Make copy_name return std::string
[external/binutils.git] / gdb / ChangeLog
1 2019-04-19  Tom Tromey  <tom@tromey.com>
2
3         * type-stack.h (struct type_stack) <insert>: Constify string.
4         * type-stack.c (type_stack::insert): Constify string.
5         * gdbtypes.h (lookup_template_type): Update.
6         (address_space_name_to_int): Update.
7         * gdbtypes.c (address_space_name_to_int): Make space_identifier
8         const.
9         (lookup_template_type): Make name const.
10         * c-exp.y: Update rules.
11         (lex_one_token, classify_name, classify_inner_name)
12         (c_print_token): Update.
13         * p-exp.y: Update rules.
14         (yylex): Update.
15         * f-exp.y: Update rules.
16         (yylex): Update.
17         * d-exp.y: Update rules.
18         (lex_one_token, classify_name, classify_inner_name): Update.
19         * parse.c (write_dollar_variable, copy_name): Return std::string.
20         * parser-defs.h (copy_name): Change return type.
21         * m2-exp.y: Update rules.
22         (yylex): Update.
23         * go-exp.y (lex_one_token): Update.
24         Update rules.
25         (classify_unsafe_function, classify_packaged_name)
26         (classify_name, yylex): Update.
27
28 2019-04-19  Sergei Trofimovich <siarheit@google.com>
29
30         * configure.ac: add --enable-source-highlight switch.
31         * configure: Regenerate.
32         * top.c (print_gdb_version): plumb --enable-source-highlight
33         status to "show configuration".
34
35 2019-04-19  Tom Tromey  <tromey@adacore.com>
36
37         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
38         Check ADA_TYPE_P.
39         (empty_record, ada_template_to_fixed_record_type_1)
40         (template_to_static_fixed_type)
41         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
42         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
43         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
44         macros.
45
46 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
47
48         PR symtab/24423:
49         * source.c (print_source_lines_base): Advance "iter" when a
50         control character is seen.
51
52 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
53
54         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
55         close to the add_com "shell".
56
57 2019-04-18  Tom Tromey  <tromey@adacore.com>
58
59         * process-stratum-target.h (class process_stratum_target)
60         <stratum>: Add "final".
61
62 2019-04-17  Tom Tromey  <tromey@adacore.com>
63
64         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
65         against nullptr before use.
66
67 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
68
69         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
70
71 2019-04-17  Jim Wilson  <jimw@sifive.com>
72             Andrew Burgess  <andrew.burgess@embecosm.com>
73
74         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
75         code read might fail, assume 4-byte breakpoint in that case.
76
77 2019-04-15  Leszek Swirski  <leszeks@google.com>
78
79         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
80         rather than a hand-rolled POD check when checking for forced MEMORY
81         classification.
82
83 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
84
85         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
86         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
87         function.
88         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
89         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
90         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
91         declaration.
92
93 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
94
95         * aarch64-linux-nat.c
96         (aarch64_linux_nat_target::thread_architecture): Add override.
97         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
98         each VQ.
99
100 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
101
102         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
103
104 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
105
106         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
107         target types of size 96-bits, add some additional comments, and
108         check that the builtin type we found was the correct size.
109
110 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
111
112         * utils.c (prompt_for_continue): Don't restore the styling at the
113         end, as applied_style has the wrong value.  This fixes styling in
114         long lists of file names that are interrupted by the "Continue?"
115         prompt.
116
117 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
118
119         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
120         * c-lang.c (c_language_defn): Likewise.
121         (cplus_language_defn): Likewise.
122         (asm_language_defn): Likewise.
123         (minimal_language_defn): Likewise.
124         * d-lang.c (d_language_defn): Likewise.
125         * f-lang.c (f_language_defn): Likewise.
126         * go-lang.c (go_language_defn): Likewise.
127         * language.c (unknown_language_defn): Likewise.
128         (auto_language_defn): Likewise.
129         * language.h (struct language_defn): Remove la_magic field.
130         (LANG_MAGIC): Delete.
131         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
132         * objc-lang.c (objc_language_defn): Likewise.
133         * opencl-lang.c (opencl_language_defn): Likewise.
134         * p-lang.c (pascal_language_defn): Likewise.
135         * rust-lang.c (rust_language_defn): Likewise.
136
137 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
138
139         * riscv-tdep.c (riscv_type_align): New function.
140         (riscv_type_alignment): Delete.
141         (riscv_arg_location): Use 'type_align'.
142         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
143
144 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
145
146         * gdbtypes.c (type_align): A struct with no non-static fields also
147         has alignment of 1.
148
149 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
150
151         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
152         component to 0.
153         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
154         member.
155         (riscv_struct_info::analyse): New implementation using new
156         analyse_inner member function.
157         (riscv_struct_info::field_offset): New member function.
158         (riscv_struct_info::m_offsets): New member variable.
159         (riscv_struct_info::analyse_inner): New private member function,
160         takes the old implementation of riscv_struct_info::analyse but
161         extended to track field offsets.
162         (riscv_call_arg_struct): Update the struct folding special cases
163         to handle cases where empty C++ structs, which are non-zero
164         length, are found.
165         (riscv_arg_location): Initialise the length of each location, a
166         non-zero length now indicates the location is in use.
167         (riscv_push_dummy_call): Allow for the first location having a
168         non-zero offset when setting up arguments.
169         (riscv_return_value): Likewise, but for return values.
170
171 2019-04-11  Tom Tromey  <tromey@adacore.com>
172
173         * utils.c (internal_vproblem): Make "msg" const.
174
175 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
176
177         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
178         * trad-frame.c (trad_frame_reset_saved_regs): New function.
179         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
180         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
181
182 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
183
184         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
185         function.
186         (fill_gregset): Call amd64_linux_collect_native_gregset instead
187         of amd64_collect_native_gregset.
188         (amd64_linux_nat_target::store_registers): Likewise.
189
190 2019-04-10  Tom Tromey  <tom@tromey.com>
191
192         * symtab.c (lookup_global_symbol_from_objfile)
193         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
194         * objfiles.h (class separate_debug_iterator): New.
195         (class separate_debug_range): New.
196         (struct objfile) <separate_debug_objfiles>: New method.
197         (objfile_separate_debug_iterate): Don't declare.
198         * objfiles.c (separate_debug_iterator::operator++): Rename from
199         objfile_separate_debug_iterate.
200         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
201         iterator.
202         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
203         iterator.
204
205 2019-04-10  Tom Tromey  <tom@tromey.com>
206
207         * symfile.c (reread_symbols): Remove old comment.
208         * objfiles.c (free_all_objfiles): Fix a typo.
209
210 2019-04-10  Tom Tromey  <tom@tromey.com>
211
212         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
213         * minsyms.c (lookup_minimal_symbol): Use foreach.
214         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
215         (lookup_minimal_symbol_solib_trampoline): Likewise.
216         * symfile.c (reread_symbols): Use foreach.
217
218 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
219             Tom Tromey  <tromey@adacore.com>
220
221         PR rust/24414:
222         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
223         (rust_lex_int_test): Change "value" to be LONGEST.
224         (rust_lex_tests): Add test for long integer literal.
225
226 2019-04-09  Tom Tromey  <tromey@adacore.com>
227
228         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
229         to bool.
230         (extended_remote_target::attach): Update.
231         (remote_target::remote_notice_new_inferior): Update.
232         (remote_target::add_current_inferior_and_thread): Update.
233         * inferior.c (exit_inferior_1): Use "false".
234         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
235
236 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
237
238         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
239         the "start" command.
240
241 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
242
243         * python/py-inferior.c (infpy_thread_from_thread_handle):
244         Adjust comments to reflect renaming of thread_from_thread_handle
245         to thread_from_handle.  Adjust keywords.  Fix type error message.
246         (inferior_object_methods): Add thread_from_handle.  Retain
247         thread_from_thread_handle, but mark it as deprecated.
248
249 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
250
251         * gdbthread.h (find_thread_by_handle): Revise declaration.
252         * thread.c (find_thread_by_handle): Likewise.  Adjust
253         implementation too.
254         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
255         support for buffer objects as handles.
256
257 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
258
259         * python/py-infthread.c (thpy_thread_handle): New function.
260         (thread_object_methods): Register thpy_thread_handle.
261
262 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
263
264         * gdbthread.h (thread_to_thread_handle): Declare.
265         * thread.c (gdbtypes.h): Include.
266         (thread_to_thread_handle): New function.
267
268         * target.h (struct target_ops): Add thread_info_to_thread_handle.
269         (target_thread_info_to_thread_handle): Declare.
270         * target.c (target_thread_info_to_thread_handle): New function.
271         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
272         * target-delegates.c: Regenerate.
273
274         * linux-thread-db.c (class thread_db_target): Add method
275         thread_info_to_thread_handle.
276         (thread_db_target::thread_info_to_thread_handle): Define.
277         * remote.c (class remote_target): Add new method
278         thread_info_to_thread_handle.
279         (remote_target::thread_info_to_thread_handle): Define.
280
281 2019-04-08  Pedro Alves  <palves@redhat.com>
282
283         * common/common-exceptions.c (throw_exception): Don't create
284         named object to throw; throw directly.
285         (throw_it): Likewise.  Don't initialize gdb_exception::message
286         here, with new; pass FMT and AP to the ctor instead.
287         * common/common-exceptions.h: Include <string>.
288         (gdb_exception::gdb_exception(enum return_reason, enum errors,
289         const char *, va_list)): New ctor.  Use std::make_shared.
290         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
291         errors)): Delete.
292         (gdb_exception_error::gdb_exception_error(enum errors, const char
293         *, va_list)): New.
294         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
295         Add assertion.
296         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
297         errors)): Delete.
298         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
299         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
300         Add assertion.
301
302 2019-04-08  Tom Tromey  <tom@tromey.com>
303
304         * valops.c (value_rtti_indirect_type): Replace throw_exception
305         with throw.
306         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
307         with throw.
308         * thread.c (thr_try_catch_cmd): Replace throw_exception with
309         throw.
310         * target.c (target_translate_tls_address): Replace throw_exception
311         with throw.
312         * stack.c (frame_apply_command_count): Replace throw_exception
313         with throw.
314         * solib-spu.c (append_ocl_sos): Replace throw_exception with
315         throw.
316         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
317         with throw.
318         * rs6000-tdep.c (rs6000_frame_cache)
319         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
320         * remote.c: Replace throw_exception with throw.
321         * record-full.c (record_full_message, record_full_wait_1)
322         (record_full_restore): Replace throw_exception with throw.
323         * record-btrace.c:
324         (get_thread_current_frame_id, record_btrace_start_replaying)
325         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
326         (cmd_record_btrace_start): Replace throw_exception with throw.
327         * parse.c (parse_exp_in_context_1): Replace throw_exception with
328         throw.
329         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
330         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
331         * linespec.c:
332         (find_linespec_symbols): Replace throw_exception with throw.
333         * infrun.c (displaced_step_prepare, resume): Replace
334         throw_exception with throw.
335         * infcmd.c (post_create_inferior): Replace throw_exception with
336         throw.
337         * inf-loop.c (inferior_event_handler): Replace throw_exception
338         with throw.
339         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
340         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
341         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
342         (get_prev_frame_always, get_frame_pc_if_available)
343         (get_frame_address_in_block_if_available, get_frame_language):
344         Replace throw_exception with throw.
345         * frame-unwind.c (frame_unwind_try_unwinder): Replace
346         throw_exception with throw.
347         * eval.c (fetch_subexp_value, evaluate_var_value)
348         (evaluate_funcall, evaluate_subexp_standard): Replace
349         throw_exception with throw.
350         * dwarf2loc.c (call_site_find_chain)
351         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
352         Replace throw_exception with throw.
353         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
354         with throw.
355         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
356         throw.
357         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
358         * completer.c (complete_line_internal): Replace throw_exception
359         with throw.
360         * compile/compile-object-run.c (compile_object_run): Replace
361         throw_exception with throw.
362         * cli/cli-script.c (process_next_line): Replace throw_exception
363         with throw.
364         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
365         (btrace_enable, btrace_maint_update_pt_packets): Replace
366         throw_exception with throw.
367         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
368         throw_exception with throw.
369         * break-catch-throw.c (re_set_exception_catchpoint): Replace
370         throw_exception with throw.
371         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
372         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
373         * aarch64-tdep.c (aarch64_make_prologue_cache)
374         (aarch64_make_stub_cache): Replace throw_exception with throw.
375
376 2019-04-08  Tom Tromey  <tom@tromey.com>
377
378         * common/common-exceptions.c (throw_exception): Rename from
379         throw_exception_cxx.  Remove old copy.  Make argument const.
380         (throw_it): Create and throw exception objects directly.
381         * common/common-exceptions.h (throw_exception): Make argument
382         const.
383         (struct gdb_exception_error): Add constructor.
384         (struct gdb_exception_quit): Add constructor.
385
386 2019-04-08  Tom Tromey  <tom@tromey.com>
387
388         * common/common-exceptions.h (exception_rethrow): Don't declare.
389         (TRY_SJLJ): Update comment.
390         (TRY, CATCH, END_CATCH): Remove.
391         * common/common-exceptions.c (exception_rethrow): Remove.
392
393 2019-04-08  Tom Tromey  <tom@tromey.com>
394
395         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
396         Remove.
397         (gdb_exception_error): Rename from
398         gdb_exception_RETURN_MASK_ERROR.
399         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
400         (gdb_quit_bad_alloc): Update.
401         * aarch64-tdep.c: Update.
402         * ada-lang.c: Update.
403         * ada-typeprint.c: Update.
404         * ada-valprint.c: Update.
405         * amd64-tdep.c: Update.
406         * arch-utils.c: Update.
407         * break-catch-throw.c: Update.
408         * breakpoint.c: Update.
409         * btrace.c: Update.
410         * c-varobj.c: Update.
411         * cli/cli-cmds.c: Update.
412         * cli/cli-interp.c: Update.
413         * cli/cli-script.c: Update.
414         * common/common-exceptions.c: Update.
415         * common/new-op.c: Update.
416         * common/selftest.c: Update.
417         * compile/compile-c-symbols.c: Update.
418         * compile/compile-cplus-symbols.c: Update.
419         * compile/compile-object-load.c: Update.
420         * compile/compile-object-run.c: Update.
421         * completer.c: Update.
422         * corelow.c: Update.
423         * cp-abi.c: Update.
424         * cp-support.c: Update.
425         * cp-valprint.c: Update.
426         * darwin-nat.c: Update.
427         * disasm-selftests.c: Update.
428         * dtrace-probe.c: Update.
429         * dwarf-index-cache.c: Update.
430         * dwarf-index-write.c: Update.
431         * dwarf2-frame-tailcall.c: Update.
432         * dwarf2-frame.c: Update.
433         * dwarf2loc.c: Update.
434         * dwarf2read.c: Update.
435         * eval.c: Update.
436         * event-loop.c: Update.
437         * event-top.c: Update.
438         * exec.c: Update.
439         * f-valprint.c: Update.
440         * fbsd-tdep.c: Update.
441         * frame-unwind.c: Update.
442         * frame.c: Update.
443         * gdbtypes.c: Update.
444         * gnu-v3-abi.c: Update.
445         * guile/guile-internal.h: Update.
446         * guile/scm-block.c: Update.
447         * guile/scm-breakpoint.c: Update.
448         * guile/scm-cmd.c: Update.
449         * guile/scm-disasm.c: Update.
450         * guile/scm-frame.c: Update.
451         * guile/scm-lazy-string.c: Update.
452         * guile/scm-math.c: Update.
453         * guile/scm-param.c: Update.
454         * guile/scm-ports.c: Update.
455         * guile/scm-pretty-print.c: Update.
456         * guile/scm-symbol.c: Update.
457         * guile/scm-symtab.c: Update.
458         * guile/scm-type.c: Update.
459         * guile/scm-value.c: Update.
460         * i386-linux-tdep.c: Update.
461         * i386-tdep.c: Update.
462         * inf-loop.c: Update.
463         * infcall.c: Update.
464         * infcmd.c: Update.
465         * infrun.c: Update.
466         * jit.c: Update.
467         * language.c: Update.
468         * linespec.c: Update.
469         * linux-fork.c: Update.
470         * linux-nat.c: Update.
471         * linux-tdep.c: Update.
472         * linux-thread-db.c: Update.
473         * main.c: Update.
474         * mi/mi-cmd-break.c: Update.
475         * mi/mi-cmd-stack.c: Update.
476         * mi/mi-interp.c: Update.
477         * mi/mi-main.c: Update.
478         * objc-lang.c: Update.
479         * p-valprint.c: Update.
480         * parse.c: Update.
481         * ppc-linux-tdep.c: Update.
482         * printcmd.c: Update.
483         * python/py-arch.c: Update.
484         * python/py-breakpoint.c: Update.
485         * python/py-cmd.c: Update.
486         * python/py-finishbreakpoint.c: Update.
487         * python/py-frame.c: Update.
488         * python/py-framefilter.c: Update.
489         * python/py-gdb-readline.c: Update.
490         * python/py-inferior.c: Update.
491         * python/py-infthread.c: Update.
492         * python/py-lazy-string.c: Update.
493         * python/py-linetable.c: Update.
494         * python/py-objfile.c: Update.
495         * python/py-param.c: Update.
496         * python/py-prettyprint.c: Update.
497         * python/py-progspace.c: Update.
498         * python/py-record-btrace.c: Update.
499         * python/py-record.c: Update.
500         * python/py-symbol.c: Update.
501         * python/py-type.c: Update.
502         * python/py-unwind.c: Update.
503         * python/py-utils.c: Update.
504         * python/py-value.c: Update.
505         * python/python.c: Update.
506         * record-btrace.c: Update.
507         * record-full.c: Update.
508         * remote-fileio.c: Update.
509         * remote.c: Update.
510         * riscv-tdep.c: Update.
511         * rs6000-aix-tdep.c: Update.
512         * rs6000-tdep.c: Update.
513         * rust-exp.y: Update.
514         * rust-lang.c: Update.
515         * s390-tdep.c: Update.
516         * selftest-arch.c: Update.
517         * solib-dsbt.c: Update.
518         * solib-frv.c: Update.
519         * solib-spu.c: Update.
520         * solib-svr4.c: Update.
521         * solib.c: Update.
522         * sparc64-linux-tdep.c: Update.
523         * stack.c: Update.
524         * symfile-mem.c: Update.
525         * symmisc.c: Update.
526         * target.c: Update.
527         * thread.c: Update.
528         * top.c: Update.
529         * tracefile-tfile.c: Update.
530         * tui/tui.c: Update.
531         * typeprint.c: Update.
532         * unittests/cli-utils-selftests.c: Update.
533         * unittests/parse-connection-spec-selftests.c: Update.
534         * valops.c: Update.
535         * valprint.c: Update.
536         * value.c: Update.
537         * varobj.c: Update.
538         * windows-nat.c: Update.
539         * x86-linux-nat.c: Update.
540         * xml-support.c: Update.
541
542 2019-04-08  Tom Tromey  <tom@tromey.com>
543
544         * xml-support.c: Use C++ exception handling.
545         * x86-linux-nat.c: Use C++ exception handling.
546         * windows-nat.c: Use C++ exception handling.
547         * varobj.c: Use C++ exception handling.
548         * value.c: Use C++ exception handling.
549         * valprint.c: Use C++ exception handling.
550         * valops.c: Use C++ exception handling.
551         * unittests/parse-connection-spec-selftests.c: Use C++ exception
552         handling.
553         * unittests/cli-utils-selftests.c: Use C++ exception handling.
554         * typeprint.c: Use C++ exception handling.
555         * tui/tui.c: Use C++ exception handling.
556         * tracefile-tfile.c: Use C++ exception handling.
557         * top.c: Use C++ exception handling.
558         * thread.c: Use C++ exception handling.
559         * target.c: Use C++ exception handling.
560         * symmisc.c: Use C++ exception handling.
561         * symfile-mem.c: Use C++ exception handling.
562         * stack.c: Use C++ exception handling.
563         * sparc64-linux-tdep.c: Use C++ exception handling.
564         * solib.c: Use C++ exception handling.
565         * solib-svr4.c: Use C++ exception handling.
566         * solib-spu.c: Use C++ exception handling.
567         * solib-frv.c: Use C++ exception handling.
568         * solib-dsbt.c: Use C++ exception handling.
569         * selftest-arch.c: Use C++ exception handling.
570         * s390-tdep.c: Use C++ exception handling.
571         * rust-lang.c: Use C++ exception handling.
572         * rust-exp.y: Use C++ exception handling.
573         * rs6000-tdep.c: Use C++ exception handling.
574         * rs6000-aix-tdep.c: Use C++ exception handling.
575         * riscv-tdep.c: Use C++ exception handling.
576         * remote.c: Use C++ exception handling.
577         * remote-fileio.c: Use C++ exception handling.
578         * record-full.c: Use C++ exception handling.
579         * record-btrace.c: Use C++ exception handling.
580         * python/python.c: Use C++ exception handling.
581         * python/py-value.c: Use C++ exception handling.
582         * python/py-utils.c: Use C++ exception handling.
583         * python/py-unwind.c: Use C++ exception handling.
584         * python/py-type.c: Use C++ exception handling.
585         * python/py-symbol.c: Use C++ exception handling.
586         * python/py-record.c: Use C++ exception handling.
587         * python/py-record-btrace.c: Use C++ exception handling.
588         * python/py-progspace.c: Use C++ exception handling.
589         * python/py-prettyprint.c: Use C++ exception handling.
590         * python/py-param.c: Use C++ exception handling.
591         * python/py-objfile.c: Use C++ exception handling.
592         * python/py-linetable.c: Use C++ exception handling.
593         * python/py-lazy-string.c: Use C++ exception handling.
594         * python/py-infthread.c: Use C++ exception handling.
595         * python/py-inferior.c: Use C++ exception handling.
596         * python/py-gdb-readline.c: Use C++ exception handling.
597         * python/py-framefilter.c: Use C++ exception handling.
598         * python/py-frame.c: Use C++ exception handling.
599         * python/py-finishbreakpoint.c: Use C++ exception handling.
600         * python/py-cmd.c: Use C++ exception handling.
601         * python/py-breakpoint.c: Use C++ exception handling.
602         * python/py-arch.c: Use C++ exception handling.
603         * printcmd.c: Use C++ exception handling.
604         * ppc-linux-tdep.c: Use C++ exception handling.
605         * parse.c: Use C++ exception handling.
606         * p-valprint.c: Use C++ exception handling.
607         * objc-lang.c: Use C++ exception handling.
608         * mi/mi-main.c: Use C++ exception handling.
609         * mi/mi-interp.c: Use C++ exception handling.
610         * mi/mi-cmd-stack.c: Use C++ exception handling.
611         * mi/mi-cmd-break.c: Use C++ exception handling.
612         * main.c: Use C++ exception handling.
613         * linux-thread-db.c: Use C++ exception handling.
614         * linux-tdep.c: Use C++ exception handling.
615         * linux-nat.c: Use C++ exception handling.
616         * linux-fork.c: Use C++ exception handling.
617         * linespec.c: Use C++ exception handling.
618         * language.c: Use C++ exception handling.
619         * jit.c: Use C++ exception handling.
620         * infrun.c: Use C++ exception handling.
621         * infcmd.c: Use C++ exception handling.
622         * infcall.c: Use C++ exception handling.
623         * inf-loop.c: Use C++ exception handling.
624         * i386-tdep.c: Use C++ exception handling.
625         * i386-linux-tdep.c: Use C++ exception handling.
626         * guile/scm-value.c: Use C++ exception handling.
627         * guile/scm-type.c: Use C++ exception handling.
628         * guile/scm-symtab.c: Use C++ exception handling.
629         * guile/scm-symbol.c: Use C++ exception handling.
630         * guile/scm-pretty-print.c: Use C++ exception handling.
631         * guile/scm-ports.c: Use C++ exception handling.
632         * guile/scm-param.c: Use C++ exception handling.
633         * guile/scm-math.c: Use C++ exception handling.
634         * guile/scm-lazy-string.c: Use C++ exception handling.
635         * guile/scm-frame.c: Use C++ exception handling.
636         * guile/scm-disasm.c: Use C++ exception handling.
637         * guile/scm-cmd.c: Use C++ exception handling.
638         * guile/scm-breakpoint.c: Use C++ exception handling.
639         * guile/scm-block.c: Use C++ exception handling.
640         * guile/guile-internal.h: Use C++ exception handling.
641         * gnu-v3-abi.c: Use C++ exception handling.
642         * gdbtypes.c: Use C++ exception handling.
643         * frame.c: Use C++ exception handling.
644         * frame-unwind.c: Use C++ exception handling.
645         * fbsd-tdep.c: Use C++ exception handling.
646         * f-valprint.c: Use C++ exception handling.
647         * exec.c: Use C++ exception handling.
648         * event-top.c: Use C++ exception handling.
649         * event-loop.c: Use C++ exception handling.
650         * eval.c: Use C++ exception handling.
651         * dwarf2read.c: Use C++ exception handling.
652         * dwarf2loc.c: Use C++ exception handling.
653         * dwarf2-frame.c: Use C++ exception handling.
654         * dwarf2-frame-tailcall.c: Use C++ exception handling.
655         * dwarf-index-write.c: Use C++ exception handling.
656         * dwarf-index-cache.c: Use C++ exception handling.
657         * dtrace-probe.c: Use C++ exception handling.
658         * disasm-selftests.c: Use C++ exception handling.
659         * darwin-nat.c: Use C++ exception handling.
660         * cp-valprint.c: Use C++ exception handling.
661         * cp-support.c: Use C++ exception handling.
662         * cp-abi.c: Use C++ exception handling.
663         * corelow.c: Use C++ exception handling.
664         * completer.c: Use C++ exception handling.
665         * compile/compile-object-run.c: Use C++ exception handling.
666         * compile/compile-object-load.c: Use C++ exception handling.
667         * compile/compile-cplus-symbols.c: Use C++ exception handling.
668         * compile/compile-c-symbols.c: Use C++ exception handling.
669         * common/selftest.c: Use C++ exception handling.
670         * common/new-op.c: Use C++ exception handling.
671         * cli/cli-script.c: Use C++ exception handling.
672         * cli/cli-interp.c: Use C++ exception handling.
673         * cli/cli-cmds.c: Use C++ exception handling.
674         * c-varobj.c: Use C++ exception handling.
675         * btrace.c: Use C++ exception handling.
676         * breakpoint.c: Use C++ exception handling.
677         * break-catch-throw.c: Use C++ exception handling.
678         * arch-utils.c: Use C++ exception handling.
679         * amd64-tdep.c: Use C++ exception handling.
680         * ada-valprint.c: Use C++ exception handling.
681         * ada-typeprint.c: Use C++ exception handling.
682         * ada-lang.c: Use C++ exception handling.
683         * aarch64-tdep.c: Use C++ exception handling.
684
685 2019-04-08  Tom Tromey  <tom@tromey.com>
686
687         * xml-support.c (gdb_xml_parser::parse): Update.
688         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
689         * value.c (show_convenience): Update.
690         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
691         (test_parse_flags_qcs): Update.
692         * thread.c (thr_try_catch_cmd): Update.
693         * target.c (target_translate_tls_address): Update.
694         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
695         (info_frame_command_core, frame_apply_command_count): Update.
696         * rust-exp.y (rust_lex_exception_test): Update.
697         * riscv-tdep.c (riscv_print_one_register_info): Update.
698         * remote.c (remote_target::enable_btrace): Update.
699         * record-btrace.c (record_btrace_enable_warn): Update.
700         * python/py-utils.c (gdbpy_convert_exception): Update.
701         * printcmd.c (do_one_display, print_variable_and_value): Update.
702         * mi/mi-main.c (mi_print_exception): Update.
703         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
704         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
705         * linux-nat.c (linux_nat_target::attach): Update.
706         * linux-fork.c (class scoped_switch_fork_info): Update.
707         * infrun.c (displaced_step_prepare): Update.
708         * infcall.c (call_function_by_hand_dummy): Update.
709         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
710         * gnu-v3-abi.c (print_one_vtable): Update.
711         * frame.c (get_prev_frame_always): Update.
712         * f-valprint.c (info_common_command_for_block): Update.
713         * exec.c (try_open_exec_file): Update.
714         * exceptions.c (print_exception, exception_print)
715         (exception_fprintf, exception_print_same): Update.
716         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
717         * dwarf-index-cache.c (index_cache::store)
718         (index_cache::lookup_gdb_index): Update.
719         * darwin-nat.c (maybe_cache_shell): Update.
720         * cp-valprint.c (cp_print_value_fields): Update.
721         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
722         (gcc_cplus_symbol_address): Update.
723         * compile/compile-c-symbols.c (gcc_convert_symbol)
724         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
725         * common/selftest.c: Update.
726         * common/common-exceptions.h (struct gdb_exception) <message>: Now
727         a std::string.
728         (exception_try_scope_entry, exception_try_scope_exit): Don't
729         declare.
730         (struct exception_try_scope): Remove.
731         (TRY): Don't use exception_try_scope.
732         (struct gdb_exception): Add constructor, operator=.
733         <what>: New method.
734         (struct gdb_exception_RETURN_MASK_ALL)
735         (struct gdb_exception_RETURN_MASK_ERROR)
736         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
737         (struct gdb_quit_bad_alloc): Update.
738         * common/common-exceptions.c (exception_none): Change
739         initializer.
740         (struct catcher) <state, exception>: Initialize inline.
741         <prev>: Remove member.
742         (current_catcher): Remove.
743         (catchers): New global.
744         (exceptions_state_mc_init): Simplify.
745         (catcher_pop): Remove.
746         (exceptions_state_mc, exceptions_state_mc_catch): Update.
747         (try_scope_depth, exception_try_scope_entry)
748         (exception_try_scope_exit): Remove.
749         (throw_exception_sjlj): Update.
750         (exception_messages, exception_messages_size): Remove.
751         (throw_it): Simplify.
752         (gdb_exception_sliced_copy): Remove.
753         (throw_exception_cxx): Update.
754         * cli/cli-script.c (script_from_file): Update.
755         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
756         Update.
757         * ada-valprint.c (ada_val_print): Update.
758         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
759         (create_excep_cond_exprs): Update.
760
761 2019-04-08  Tom Tromey  <tom@tromey.com>
762
763         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
764         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
765         (TRY, CATCH, END_CATCH): Remove some definitions.
766         * common/common-exceptions.c: Don't use GDB_XCPT.
767         (catcher_list_size): Remove.
768         (throw_exception, throw_it): Simplify.
769
770 2019-04-05  Tom Tromey  <tom@tromey.com>
771
772         Revert the header-sorting patch.
773         * ft32-tdep.c: Revert.
774         * frv-tdep.c: Revert.
775         * frv-linux-tdep.c: Revert.
776         * frame.c: Revert.
777         * frame-unwind.c: Revert.
778         * frame-base.c: Revert.
779         * fork-child.c: Revert.
780         * findvar.c: Revert.
781         * findcmd.c: Revert.
782         * filesystem.c: Revert.
783         * filename-seen-cache.h: Revert.
784         * filename-seen-cache.c: Revert.
785         * fbsd-tdep.c: Revert.
786         * fbsd-nat.h: Revert.
787         * fbsd-nat.c: Revert.
788         * f-valprint.c: Revert.
789         * f-typeprint.c: Revert.
790         * f-lang.c: Revert.
791         * extension.h: Revert.
792         * extension.c: Revert.
793         * extension-priv.h: Revert.
794         * expprint.c: Revert.
795         * exec.h: Revert.
796         * exec.c: Revert.
797         * exceptions.c: Revert.
798         * event-top.c: Revert.
799         * event-loop.c: Revert.
800         * eval.c: Revert.
801         * elfread.c: Revert.
802         * dwarf2read.h: Revert.
803         * dwarf2read.c: Revert.
804         * dwarf2loc.c: Revert.
805         * dwarf2expr.h: Revert.
806         * dwarf2expr.c: Revert.
807         * dwarf2-frame.c: Revert.
808         * dwarf2-frame-tailcall.c: Revert.
809         * dwarf-index-write.h: Revert.
810         * dwarf-index-write.c: Revert.
811         * dwarf-index-common.c: Revert.
812         * dwarf-index-cache.h: Revert.
813         * dwarf-index-cache.c: Revert.
814         * dummy-frame.c: Revert.
815         * dtrace-probe.c: Revert.
816         * disasm.h: Revert.
817         * disasm.c: Revert.
818         * disasm-selftests.c: Revert.
819         * dictionary.c: Revert.
820         * dicos-tdep.c: Revert.
821         * demangle.c: Revert.
822         * dcache.h: Revert.
823         * dcache.c: Revert.
824         * darwin-nat.h: Revert.
825         * darwin-nat.c: Revert.
826         * darwin-nat-info.c: Revert.
827         * d-valprint.c: Revert.
828         * d-namespace.c: Revert.
829         * d-lang.c: Revert.
830         * ctf.c: Revert.
831         * csky-tdep.c: Revert.
832         * csky-linux-tdep.c: Revert.
833         * cris-tdep.c: Revert.
834         * cris-linux-tdep.c: Revert.
835         * cp-valprint.c: Revert.
836         * cp-support.c: Revert.
837         * cp-namespace.c: Revert.
838         * cp-abi.c: Revert.
839         * corelow.c: Revert.
840         * corefile.c: Revert.
841         * continuations.c: Revert.
842         * completer.h: Revert.
843         * completer.c: Revert.
844         * complaints.c: Revert.
845         * coffread.c: Revert.
846         * coff-pe-read.c: Revert.
847         * cli-out.h: Revert.
848         * cli-out.c: Revert.
849         * charset.c: Revert.
850         * c-varobj.c: Revert.
851         * c-valprint.c: Revert.
852         * c-typeprint.c: Revert.
853         * c-lang.c: Revert.
854         * buildsym.c: Revert.
855         * buildsym-legacy.c: Revert.
856         * build-id.h: Revert.
857         * build-id.c: Revert.
858         * btrace.c: Revert.
859         * bsd-uthread.c: Revert.
860         * breakpoint.h: Revert.
861         * breakpoint.c: Revert.
862         * break-catch-throw.c: Revert.
863         * break-catch-syscall.c: Revert.
864         * break-catch-sig.c: Revert.
865         * blockframe.c: Revert.
866         * block.c: Revert.
867         * bfin-tdep.c: Revert.
868         * bfin-linux-tdep.c: Revert.
869         * bfd-target.c: Revert.
870         * bcache.c: Revert.
871         * ax-general.c: Revert.
872         * ax-gdb.h: Revert.
873         * ax-gdb.c: Revert.
874         * avr-tdep.c: Revert.
875         * auxv.c: Revert.
876         * auto-load.c: Revert.
877         * arm-wince-tdep.c: Revert.
878         * arm-tdep.c: Revert.
879         * arm-symbian-tdep.c: Revert.
880         * arm-pikeos-tdep.c: Revert.
881         * arm-obsd-tdep.c: Revert.
882         * arm-nbsd-tdep.c: Revert.
883         * arm-nbsd-nat.c: Revert.
884         * arm-linux-tdep.c: Revert.
885         * arm-linux-nat.c: Revert.
886         * arm-fbsd-tdep.c: Revert.
887         * arm-fbsd-nat.c: Revert.
888         * arm-bsd-tdep.c: Revert.
889         * arch-utils.c: Revert.
890         * arc-tdep.c: Revert.
891         * arc-newlib-tdep.c: Revert.
892         * annotate.h: Revert.
893         * annotate.c: Revert.
894         * amd64-windows-tdep.c: Revert.
895         * amd64-windows-nat.c: Revert.
896         * amd64-tdep.c: Revert.
897         * amd64-sol2-tdep.c: Revert.
898         * amd64-obsd-tdep.c: Revert.
899         * amd64-obsd-nat.c: Revert.
900         * amd64-nbsd-tdep.c: Revert.
901         * amd64-nbsd-nat.c: Revert.
902         * amd64-nat.c: Revert.
903         * amd64-linux-tdep.c: Revert.
904         * amd64-linux-nat.c: Revert.
905         * amd64-fbsd-tdep.c: Revert.
906         * amd64-fbsd-nat.c: Revert.
907         * amd64-dicos-tdep.c: Revert.
908         * amd64-darwin-tdep.c: Revert.
909         * amd64-bsd-nat.c: Revert.
910         * alpha-tdep.c: Revert.
911         * alpha-obsd-tdep.c: Revert.
912         * alpha-nbsd-tdep.c: Revert.
913         * alpha-mdebug-tdep.c: Revert.
914         * alpha-linux-tdep.c: Revert.
915         * alpha-linux-nat.c: Revert.
916         * alpha-bsd-tdep.c: Revert.
917         * alpha-bsd-nat.c: Revert.
918         * aix-thread.c: Revert.
919         * agent.c: Revert.
920         * addrmap.c: Revert.
921         * ada-varobj.c: Revert.
922         * ada-valprint.c: Revert.
923         * ada-typeprint.c: Revert.
924         * ada-tasks.c: Revert.
925         * ada-lang.c: Revert.
926         * aarch64-tdep.c: Revert.
927         * aarch64-ravenscar-thread.c: Revert.
928         * aarch64-newlib-tdep.c: Revert.
929         * aarch64-linux-tdep.c: Revert.
930         * aarch64-linux-nat.c: Revert.
931         * aarch64-fbsd-tdep.c: Revert.
932         * aarch64-fbsd-nat.c: Revert.
933         * aarch32-linux-nat.c: Revert.
934
935 2019-04-05  Tom Tromey  <tom@tromey.com>
936
937         * ft32-tdep.c: Sort headers.
938         * frv-tdep.c: Sort headers.
939         * frv-linux-tdep.c: Sort headers.
940         * frame.c: Sort headers.
941         * frame-unwind.c: Sort headers.
942         * frame-base.c: Sort headers.
943         * fork-child.c: Sort headers.
944         * findvar.c: Sort headers.
945         * findcmd.c: Sort headers.
946         * filesystem.c: Sort headers.
947         * filename-seen-cache.h: Sort headers.
948         * filename-seen-cache.c: Sort headers.
949         * fbsd-tdep.c: Sort headers.
950         * fbsd-nat.h: Sort headers.
951         * fbsd-nat.c: Sort headers.
952         * f-valprint.c: Sort headers.
953         * f-typeprint.c: Sort headers.
954         * f-lang.c: Sort headers.
955         * extension.h: Sort headers.
956         * extension.c: Sort headers.
957         * extension-priv.h: Sort headers.
958         * expprint.c: Sort headers.
959         * exec.h: Sort headers.
960         * exec.c: Sort headers.
961         * exceptions.c: Sort headers.
962         * event-top.c: Sort headers.
963         * event-loop.c: Sort headers.
964         * eval.c: Sort headers.
965         * elfread.c: Sort headers.
966         * dwarf2read.h: Sort headers.
967         * dwarf2read.c: Sort headers.
968         * dwarf2loc.c: Sort headers.
969         * dwarf2expr.h: Sort headers.
970         * dwarf2expr.c: Sort headers.
971         * dwarf2-frame.c: Sort headers.
972         * dwarf2-frame-tailcall.c: Sort headers.
973         * dwarf-index-write.h: Sort headers.
974         * dwarf-index-write.c: Sort headers.
975         * dwarf-index-common.c: Sort headers.
976         * dwarf-index-cache.h: Sort headers.
977         * dwarf-index-cache.c: Sort headers.
978         * dummy-frame.c: Sort headers.
979         * dtrace-probe.c: Sort headers.
980         * disasm.h: Sort headers.
981         * disasm.c: Sort headers.
982         * disasm-selftests.c: Sort headers.
983         * dictionary.c: Sort headers.
984         * dicos-tdep.c: Sort headers.
985         * demangle.c: Sort headers.
986         * dcache.h: Sort headers.
987         * dcache.c: Sort headers.
988         * darwin-nat.h: Sort headers.
989         * darwin-nat.c: Sort headers.
990         * darwin-nat-info.c: Sort headers.
991         * d-valprint.c: Sort headers.
992         * d-namespace.c: Sort headers.
993         * d-lang.c: Sort headers.
994         * ctf.c: Sort headers.
995         * csky-tdep.c: Sort headers.
996         * csky-linux-tdep.c: Sort headers.
997         * cris-tdep.c: Sort headers.
998         * cris-linux-tdep.c: Sort headers.
999         * cp-valprint.c: Sort headers.
1000         * cp-support.c: Sort headers.
1001         * cp-namespace.c: Sort headers.
1002         * cp-abi.c: Sort headers.
1003         * corelow.c: Sort headers.
1004         * corefile.c: Sort headers.
1005         * continuations.c: Sort headers.
1006         * completer.h: Sort headers.
1007         * completer.c: Sort headers.
1008         * complaints.c: Sort headers.
1009         * coffread.c: Sort headers.
1010         * coff-pe-read.c: Sort headers.
1011         * cli-out.h: Sort headers.
1012         * cli-out.c: Sort headers.
1013         * charset.c: Sort headers.
1014         * c-varobj.c: Sort headers.
1015         * c-valprint.c: Sort headers.
1016         * c-typeprint.c: Sort headers.
1017         * c-lang.c: Sort headers.
1018         * buildsym.c: Sort headers.
1019         * buildsym-legacy.c: Sort headers.
1020         * build-id.h: Sort headers.
1021         * build-id.c: Sort headers.
1022         * btrace.c: Sort headers.
1023         * bsd-uthread.c: Sort headers.
1024         * breakpoint.h: Sort headers.
1025         * breakpoint.c: Sort headers.
1026         * break-catch-throw.c: Sort headers.
1027         * break-catch-syscall.c: Sort headers.
1028         * break-catch-sig.c: Sort headers.
1029         * blockframe.c: Sort headers.
1030         * block.c: Sort headers.
1031         * bfin-tdep.c: Sort headers.
1032         * bfin-linux-tdep.c: Sort headers.
1033         * bfd-target.c: Sort headers.
1034         * bcache.c: Sort headers.
1035         * ax-general.c: Sort headers.
1036         * ax-gdb.h: Sort headers.
1037         * ax-gdb.c: Sort headers.
1038         * avr-tdep.c: Sort headers.
1039         * auxv.c: Sort headers.
1040         * auto-load.c: Sort headers.
1041         * arm-wince-tdep.c: Sort headers.
1042         * arm-tdep.c: Sort headers.
1043         * arm-symbian-tdep.c: Sort headers.
1044         * arm-pikeos-tdep.c: Sort headers.
1045         * arm-obsd-tdep.c: Sort headers.
1046         * arm-nbsd-tdep.c: Sort headers.
1047         * arm-nbsd-nat.c: Sort headers.
1048         * arm-linux-tdep.c: Sort headers.
1049         * arm-linux-nat.c: Sort headers.
1050         * arm-fbsd-tdep.c: Sort headers.
1051         * arm-fbsd-nat.c: Sort headers.
1052         * arm-bsd-tdep.c: Sort headers.
1053         * arch-utils.c: Sort headers.
1054         * arc-tdep.c: Sort headers.
1055         * arc-newlib-tdep.c: Sort headers.
1056         * annotate.h: Sort headers.
1057         * annotate.c: Sort headers.
1058         * amd64-windows-tdep.c: Sort headers.
1059         * amd64-windows-nat.c: Sort headers.
1060         * amd64-tdep.c: Sort headers.
1061         * amd64-sol2-tdep.c: Sort headers.
1062         * amd64-obsd-tdep.c: Sort headers.
1063         * amd64-obsd-nat.c: Sort headers.
1064         * amd64-nbsd-tdep.c: Sort headers.
1065         * amd64-nbsd-nat.c: Sort headers.
1066         * amd64-nat.c: Sort headers.
1067         * amd64-linux-tdep.c: Sort headers.
1068         * amd64-linux-nat.c: Sort headers.
1069         * amd64-fbsd-tdep.c: Sort headers.
1070         * amd64-fbsd-nat.c: Sort headers.
1071         * amd64-dicos-tdep.c: Sort headers.
1072         * amd64-darwin-tdep.c: Sort headers.
1073         * amd64-bsd-nat.c: Sort headers.
1074         * alpha-tdep.c: Sort headers.
1075         * alpha-obsd-tdep.c: Sort headers.
1076         * alpha-nbsd-tdep.c: Sort headers.
1077         * alpha-mdebug-tdep.c: Sort headers.
1078         * alpha-linux-tdep.c: Sort headers.
1079         * alpha-linux-nat.c: Sort headers.
1080         * alpha-bsd-tdep.c: Sort headers.
1081         * alpha-bsd-nat.c: Sort headers.
1082         * aix-thread.c: Sort headers.
1083         * agent.c: Sort headers.
1084         * addrmap.c: Sort headers.
1085         * ada-varobj.c: Sort headers.
1086         * ada-valprint.c: Sort headers.
1087         * ada-typeprint.c: Sort headers.
1088         * ada-tasks.c: Sort headers.
1089         * ada-lang.c: Sort headers.
1090         * aarch64-tdep.c: Sort headers.
1091         * aarch64-ravenscar-thread.c: Sort headers.
1092         * aarch64-newlib-tdep.c: Sort headers.
1093         * aarch64-linux-tdep.c: Sort headers.
1094         * aarch64-linux-nat.c: Sort headers.
1095         * aarch64-fbsd-tdep.c: Sort headers.
1096         * aarch64-fbsd-nat.c: Sort headers.
1097         * aarch32-linux-nat.c: Sort headers.
1098
1099 2019-04-04  Tom Tromey  <tom@tromey.com>
1100
1101         * varobj.c (varobj_create): Update.
1102         * rust-exp.y (struct rust_parser) <update_innermost_block,
1103         lookup_symbol>: New methods.
1104         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
1105         Rename.
1106         (rust_parser::rust_lookup_type)
1107         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1108         * printcmd.c (display_command, do_one_display): Update.
1109         * parser-defs.h (struct parser_state) <parser_state>: Add
1110         "tracker" parameter.
1111         (block_tracker): New member.
1112         (class innermost_block_tracker) <innermost_block_tracker>: Add
1113         "types" parameter.
1114         <reset>: Remove method.
1115         (innermost_block): Don't declare.
1116         (null_post_parser): Update.
1117         * parse.c (innermost_block): Remove global.
1118         (write_dollar_variable): Update.
1119         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
1120         Remove "tracker_types" parameter.
1121         (parse_expression): Add "tracker" parameter.
1122         (parse_expression_for_completion): Update.
1123         (null_post_parser): Add "tracker" parameter.
1124         * p-exp.y: Update rules.
1125         * m2-exp.y: Update rules.
1126         * language.h (struct language_defn) <la_post_parser>: Add
1127         "tracker" parameter.
1128         * go-exp.y: Update rules.
1129         * f-exp.y: Update rules.
1130         * expression.h (parse_expression, parse_exp_1): Add "tracker"
1131         parameter.
1132         * d-exp.y: Update rules.
1133         * c-exp.y: Update rules.
1134         * breakpoint.c (set_breakpoint_condition): Create an
1135         innermost_block_tracker.
1136         (watch_command_1): Likewise.
1137         * ada-lang.c (resolve): Add "tracker" parameter.
1138         (resolve_subexp): Likewise.
1139         * ada-exp.y (write_var_from_sym): Update.
1140
1141 2019-04-04  Tom Tromey  <tom@tromey.com>
1142
1143         * type-stack.h: New file.
1144         * type-stack.c: New file.
1145         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
1146         type-stack.h.
1147         (insert_into_type_stack, insert_type, push_type, push_type_int)
1148         (insert_type_address_space, pop_type, pop_type_int)
1149         (pop_typelist, pop_type_stack, append_type_stack)
1150         (push_type_stack, get_type_stack, push_typelist)
1151         (follow_type_instance_flags, follow_types): Don't declare.
1152         * parse.c (type_stack): Remove global.
1153         (parse_exp_in_context): Update.
1154         (insert_into_type_stack, insert_type, push_type, push_type_int)
1155         (insert_type_address_space, pop_type, pop_type_int)
1156         (pop_typelist, pop_type_stack, append_type_stack)
1157         (push_type_stack, get_type_stack, push_typelist)
1158         (follow_type_instance_flags, follow_types): Remove (moved to
1159         type-stack.c).
1160         * f-exp.y (type_stack): New global.
1161         Update rules.
1162         (push_kind_type, f_parse): Update.
1163         * d-exp.y (type_stack): New global.
1164         Update rules.
1165         (d_parse): Update.
1166         * c-exp.y (struct c_parse_state) <type_stack>: New member.
1167         Update rules.
1168         * Makefile.in (COMMON_SFILES): Add type-stack.c.
1169         (HFILES_NO_SRCDIR): Add type-stack.h.
1170
1171 2019-04-04  Tom Tromey  <tom@tromey.com>
1172
1173         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
1174         (rust_parser::convert_ast_to_expression, rust_parse)
1175         (rust_lex_test_completion, rust_lex_tests): Update.
1176         * parser-defs.h (struct expr_completion_state): New.
1177         (struct parser_state) <parser_state>: Add completion parameter.
1178         <mark_struct_expression, mark_completion_tag>: New methods.
1179         <parse_completion, m_completion_state>: New members.
1180         (prefixify_expression, null_post_parser): Update.
1181         (mark_struct_expression, mark_completion_tag): Don't declare.
1182         * parse.c (parse_completion, expout_last_struct)
1183         (expout_tag_completion_type, expout_completion_name): Remove
1184         globals.
1185         (parser_state::mark_struct_expression)
1186         (parser_state::mark_completion_tag): Now methods.
1187         (prefixify_expression): Add last_struct parameter.
1188         (prefixify_subexp): Likewise.
1189         (parse_exp_1): Update.
1190         (parse_exp_in_context): Add cstate parameter.  Update.
1191         (parse_expression_for_completion): Create an
1192         expr_completion_state.
1193         (null_post_parser): Add "completion" parameter.
1194         * p-exp.y: Update rules.
1195         (yylex): Update.
1196         * language.h (struct language_defn) <la_post_parser>: Add
1197         "completing" parameter.
1198         * go-exp.y: Update rules.
1199         (lex_one_token): Update.
1200         * expression.h (parse_completion): Don't declare.
1201         * d-exp.y: Update rules.
1202         (lex_one_token): Update rules.
1203         * c-exp.y: Update rules.
1204         (lex_one_token): Update.
1205         * ada-lang.c (resolve): Add "parse_completion" parameter.
1206         (resolve_subexp): Likewise.
1207         (ada_resolve_function): Likewise.
1208
1209 2019-04-04  Tom Tromey  <tom@tromey.com>
1210
1211         * parser-defs.h (struct parser_state) <start_arglist,
1212         end_arglist>: New methods.
1213         <arglist_len, m_funcall_chain>: New members.
1214         (arglist_len, start_arglist, end_arglist): Don't declare.
1215         * parse.c (arglist_len, funcall_chain): Remove global.
1216         (start_arglist, end_arglist): Remove functions.
1217         (parse_exp_in_context): Update.
1218         * p-exp.y: Update rules.
1219         * m2-exp.y: Update rules.
1220         * go-exp.y: Update rules.
1221         * f-exp.y: Update rules.
1222         * d-exp.y: Update rules.
1223         * c-exp.y: Update rules.
1224
1225 2019-04-04  Tom Tromey  <tom@tromey.com>
1226
1227         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
1228         lex_operator, push_back>: New methods.
1229         Update all rules.
1230         (rust_parser::lex_hex, lex_escape): Rename and update.
1231         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
1232         (rust_parser::lex_operator): Rename and update.
1233         (rust_parser::lex_number, rustyylex, rustyyerror)
1234         (rust_lex_test_init, rust_lex_test_sequence)
1235         (rust_lex_test_push_back, rust_lex_tests): Update.
1236         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
1237         parameter.
1238         <lexptr, prev_lexptr>: New members.
1239         (lexptr, prev_lexptr): Don't declare.
1240         * parse.c (lexptr, prev_lexptr): Remove globals.
1241         (parse_exp_in_context): Update.
1242         * p-exp.y (yylex, yyerror): Update.
1243         * m2-exp.y (parse_number, yylex, yyerror): Update.
1244         * go-exp.y (lex_one_token, yyerror): Update.
1245         * f-exp.y (match_string_literal, yylex, yyerror): Update.
1246         * d-exp.y (lex_one_token, yyerror): Update.
1247         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
1248         (lex_one_token, yyerror): Update.
1249         * ada-lex.l (YY_INPUT): Update.
1250         (rewind_to_char): Update.
1251         * ada-exp.y (yyerror): Update.
1252
1253 2019-04-04  Tom Tromey  <tom@tromey.com>
1254
1255         * rust-exp.y (rustyylex, rust_lex_tests): Update.
1256         * parser-defs.h (struct parser_state) <parser_state>: Add new
1257         parameter.
1258         <comma_terminates>: New member.
1259         (comma_terminates): Don't declare global.
1260         * parse.c (comma_terminates): Remove global.
1261         (parse_exp_in_context): Update.
1262         * p-exp.y (yylex): Update.
1263         * m2-exp.y (yylex): Update.
1264         * go-exp.y (lex_one_token): Update.
1265         * f-exp.y (yylex): Update.
1266         * d-exp.y (lex_one_token): Update.
1267         * c-exp.y (lex_one_token): Update.
1268         * ada-lex.l: Update.
1269
1270 2019-04-04  Tom Tromey  <tom@tromey.com>
1271
1272         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
1273         (rustyylex, rust_lex_test_init, rust_lex_test_one)
1274         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
1275         * parser-defs.h (paren_depth): Don't declare.
1276         * parse.c (paren_depth): Remove global.
1277         (parse_exp_in_context): Update.
1278         * p-exp.y (paren_depth): New global.
1279         (pascal_parse): Initialize it.
1280         * m2-exp.y (paren_depth): New global.
1281         (m2_parse): Initialize it.
1282         * go-exp.y (paren_depth): New global.
1283         (go_parse): Initialize it.
1284         * f-exp.y (paren_depth): New global.
1285         (f_parse): Initialize it.
1286         * d-exp.y (paren_depth): New global.
1287         (d_parse): Initialize it.
1288         * c-exp.y (paren_depth): New global.
1289         (c_parse): Initialize it.
1290         * ada-lex.l (paren_depth): New global.
1291         (lexer_init): Initialize it.
1292
1293 2019-04-04  Tom Tromey  <tom@tromey.com>
1294
1295         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
1296         (rust_parser::convert_ast_to_type)
1297         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1298         * parser-defs.h (struct parser_state) <parser_state>: Add
1299         parameters.  Initialize new members.
1300         <expression_context_block, expression_context_pc>: New members.
1301         * parse.c (expression_context_block, expression_context_pc):
1302         Remove globals.
1303         (parse_exp_in_context): Update.
1304         * p-exp.y: Update all rules.
1305         (yylex): Update.
1306         * m2-exp.y: Update all rules.
1307         (yylex): Update.
1308         * go-exp.y (yylex): Update.
1309         * f-exp.y (yylex): Update.
1310         * d-exp.y: Update all rules.
1311         (yylex): Update.
1312         * c-exp.y: Update all rules.
1313         (lex_one_token, classify_name, yylex, c_parse): Update.
1314         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
1315
1316 2019-04-04  Tom Tromey  <tom@tromey.com>
1317
1318         * gdbarch.h, gdbarch.c: Rebuild.
1319         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
1320         * stap-probe.h: 
1321         (struct stap_parse_info): Replace "parser_state" with
1322         "expr_builder".
1323         * parser-defs.h (struct expr_builder): Rename from "parser_state".
1324         (parser_state): New class.
1325         * parse.c (expr_builder): Rename.
1326         (expr_builder::release): Rename.
1327         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
1328         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
1329         (write_exp_elt_longcst, write_exp_elt_floatcst)
1330         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
1331         (write_exp_string_vector, write_exp_bitstring)
1332         (write_exp_msymbol, mark_struct_expression)
1333         (write_dollar_variable)
1334         (insert_type_address_space, increase_expout_size): Replace
1335         "parser_state" with "expr_builder".
1336         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
1337         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
1338         "parser_state" with "expr_builder".
1339
1340 2019-04-04  Tom Tromey  <tom@tromey.com>
1341
1342         * rust-exp.y: Replace "parse_language" with method call.
1343         * p-exp.y: 
1344         (yylex): Replace "parse_language" with method call.
1345         * m2-exp.y: 
1346         (yylex): Replace "parse_language" with method call.
1347         * go-exp.y (classify_name): Replace "parse_language" with method
1348         call.
1349         * f-exp.y (yylex): Replace "parse_language" with method call.
1350         * d-exp.y (lex_one_token): Replace "parse_language" with method
1351         call.
1352         * c-exp.y: 
1353         (lex_one_token, classify_name, yylex): Replace "parse_language"
1354         with method call.
1355         * ada-exp.y (find_primitive_type, type_char)
1356         (type_system_address): Replace "parse_language" with method call.
1357
1358 2019-04-04  Tom Tromey  <tom@tromey.com>
1359
1360         * rust-exp.y: Replace "parse_gdbarch" with method call.
1361         * parse.c (write_dollar_variable, insert_type_address_space):
1362         Replace "parse_gdbarch" with method call.
1363         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
1364         call.
1365         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
1366         call.
1367         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
1368         "parse_gdbarch" with method call.
1369         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
1370         with method call.
1371         * f-exp.y (parse_type, parse_f_type, yylex): Replace
1372         "parse_gdbarch" with method call.
1373         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
1374         "parse_gdbarch" with method call.
1375         * c-exp.y (parse_type, parse_number, classify_name): Replace
1376         "parse_gdbarch" with method call.
1377         * ada-lex.l: Replace "parse_gdbarch" with method call.
1378         * ada-exp.y (parse_type, find_primitive_type, type_char)
1379         (type_system_address): Replace "parse_gdbarch" with method call.
1380
1381 2019-04-04  Tom Tromey  <tom@tromey.com>
1382
1383         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
1384         * stap-probe.c (stap_parse_argument): Update.
1385         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
1386         initial_size parameter.
1387         * rust-exp.y (rust_lex_tests): Update.
1388         * parse.c (parser_state): Update.
1389         (parse_exp_in_context): Update.
1390         * parser-defs.h (struct parser_state) <parser_state>: Remove
1391         "initial_size" parameter.
1392
1393 2019-04-04  Tom Tromey  <tom@tromey.com>
1394
1395         * parser-defs.h (increase_expout_size): Don't declare.
1396         * parse.c (increase_expout_size): Now static.
1397
1398 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
1399
1400         * gnu-nat.c (gnu_nat_target::wait): Fix
1401         target_waitstatus_to_string call.
1402
1403 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1404
1405         * eval.c (evaluate_subexp_standard): Handle internal functions
1406         during Fortran function call handling.
1407
1408 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1409
1410         * NEWS: Mention new internal functions.
1411         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
1412         (read_base_type): Use dwarf2_init_complex_target_type.
1413         * value.c (creal_internal_fn): New function.
1414         (cimag_internal_fn): New function.
1415         (_initialize_values): Register new internal functions.
1416
1417 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1418
1419         * infrun.c (stop_all_threads): If debug_infrun, always
1420         trace the wait status after wait_one, using
1421         target_waitstatus_to_string and target_pid_to_str.
1422         (handle_inferior_event): Replace various trace of
1423         wait status kind by a single trace.
1424         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
1425         wait status kind image by target_waitstatus_to_string.
1426         * target/waitstatus.c (target_waitstatus_to_string): Fix
1427         obsolete comment.
1428
1429 2019-04-01  Tom Tromey  <tromey@adacore.com>
1430
1431         PR symtab/23331:
1432         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
1433
1434 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
1435             Pedro Alves  <palves@redhat.com>
1436
1437         * top.c (quit_force): Call 'finalize_values'.
1438         * value.c (finalize_values): New function.
1439         * value.h (finalize_values): Declare.
1440
1441 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
1442
1443         * NEWS: Announce $_gdb_major and $_gdb_minor.
1444
1445         * top.c (init_gdb_version_vars): New function.
1446         (gdb_init): Call init_gdb_version_vars.
1447
1448 2019-03-29  Tom Tromey  <tromey@adacore.com>
1449
1450         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
1451         help text.  Remove dead code.
1452
1453 2019-03-29  Keith Seitz  <keiths@redhat.com>
1454
1455         From Siddhesh Poyarekar:
1456         * f-lang.h (f77_get_upperbound): Return LONGEST.
1457         (f77_get_lowerbound): Likewise.
1458         * f-typeprint.c (f_type_print_varspec_suffix): Expand
1459         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
1460         print them.
1461         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
1462         plongest to format print it.
1463         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
1464         (f77_get_upperbound): Likewise.
1465         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
1466         LOWER_BOUND to LONGEST.
1467         (f77_create_arrayprint_offset_tbl): Likewise.
1468
1469 2019-03-29  Keith Seitz  <keiths@redhat.com>
1470
1471         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
1472         %s/pulongest for TYPE_LENGTH instead of %d in format
1473         strings.
1474         * ada-typerint.c (ada_print_type): Likewise.
1475         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
1476         * compile/compile-c-support.c (generate_register_struct): Likewise.
1477         * gdbtypes.c (recursive_dump_type): Likewise.
1478         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
1479         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
1480         instead of %d in format strings.
1481         * riscv-tdep.c (riscv_type_alignment): Cast second argument
1482         to std::min to ULONGEST.
1483         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
1484         instead of %d in format strings.
1485         * tracepoint.c (info_scope_command): Likewise.
1486         * typeprint.c (print_offset_data::update)
1487         (print_offset_data::finish): Likewise.
1488         * xtensa-tdep.c (xtensa_store_return_value)
1489         (xtensa_push_dummy_call): Likewise.
1490
1491 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
1492
1493         * windows-nat.c (display_selector): Fixed format specifications
1494         for 64-bit Cygwin.
1495
1496 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1497
1498         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
1499
1500 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
1501
1502         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
1503         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
1504         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
1505         (nios2_linux_init_abi): Install it.
1506
1507 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1508
1509         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
1510
1511 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1512
1513         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
1514
1515 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1516             Tom Tromey  <tromey@adacore.com>
1517
1518         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
1519
1520 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
1521
1522         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
1523         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
1524         method to compute the bounds of range types. Also print "[evaluated]"
1525         if the bounds' values come from a dynamic evaluation.
1526
1527 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1528
1529         * cp-valprint.c (cp_print_value_fields): Don't print trailing
1530         whitespace when pretty printing is on.
1531
1532 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1533
1534         * ppc-linux-nat.c: Add include.
1535
1536 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1537
1538         * NEWS: Mention AArch64 Pointer Authentication.
1539
1540 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1541
1542         * arm-linux-nat.c: Add include.
1543
1544 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
1545
1546         * source-cache.c (source_cache::get_source_lines): Re-read
1547         fullname after calling open_source_file.
1548
1549 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
1550
1551         * NEWS: Mention TLS support for FreeBSD.
1552
1553 2019-03-25  Tom Tromey  <tromey@adacore.com>
1554
1555         * minsyms.c (BUNCH_SIZE): Update comment.
1556         (~minimal_symbol_reader): Remove old comment.
1557         (compact_minimal_symbols): Update comment.
1558         (minimal_symbol_reader::install): Remove old comment.  Update
1559         other comments.
1560
1561 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1562
1563         * s390-linux-nat.c: Add include.
1564
1565 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1566
1567         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1568         Call linux_get_hwcap.
1569         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
1570         Likewise.
1571         (aarch64_linux_get_hwcap): Remove function.
1572         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
1573         declaration.
1574         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
1575         linux_get_hwcap.
1576         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1577         * linux-tdep.c (linux_get_hwcap): Add function.
1578         (linux_get_hwcap2): Likewise.
1579         * linux-tdep.h (linux_get_hwcap): Add declaration.
1580         (linux_get_hwcap2): Likewise.
1581         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
1582         (ppc_linux_get_hwcap2): Likewise.
1583         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
1584         linux_get_hwcap.
1585         (ppc_linux_nat_target::insert_watchpoint): Likewise.
1586         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
1587         (ppc_linux_nat_target::read_description): Likewise.
1588         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
1589         * s390-linux-nat.c: Likewise.
1590         * s390-linux-tdep.c (s390_core_read_description): Likewise.
1591
1592 2019-03-24  Tom Tromey  <tom@tromey.com>
1593
1594         * ada-lang.c (standard_lookup): Simplify initialization.
1595         (ada_lookup_symbol_nonlocal): Simplify return.
1596         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
1597         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
1598         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
1599         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
1600         initialization.
1601         * solib.c (solib_global_lookup): Simplify.
1602         * symtab.c (null_block_symbol): Remove.
1603         (symbol_cache_lookup): Simplify returns.
1604         (lookup_language_this): Simplify returns.
1605         (lookup_symbol_aux): Simplify return.
1606         (lookup_local_symbol): Simplify returns.
1607         (lookup_global_symbol_from_objfile): Simplify return.
1608         (lookup_symbol_in_objfile_symtabs)
1609         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
1610         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
1611         (lookup_static_symbol, lookup_global_symbol): Simplify return.
1612         * cp-namespace.c (cp_lookup_bare_symbol)
1613         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
1614         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
1615         (cp_lookup_nested_symbol): Don't use null_block_symbol.
1616         (cp_lookup_symbol_via_imports): Simplify initialization.
1617         (find_symbol_in_baseclass): Likewise.
1618         * symtab.h (null_block_symbol): Remove.
1619         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
1620         (d_lookup_nested_symbol, d_lookup_symbol_imports)
1621         (d_lookup_symbol_module): Likewise.
1622         (find_symbol_in_baseclass): Simplify initialization.
1623
1624 2019-03-24  Tom Tromey  <tom@tromey.com>
1625
1626         * expression.h: Don't include symtab.h.
1627         (struct block): Forward declare.
1628
1629 2019-03-24  Tom Tromey  <tom@tromey.com>
1630
1631         * c-exp.y (typebase): Remove casts.
1632         * gdbtypes.c (lookup_unsigned_typename, )
1633         (lookup_signed_typename): Remove cast.
1634         * eval.c (parse_to_comma_and_eval): Remove cast.
1635         * parse.c (write_dollar_variable): Remove cast.
1636         * block.h (struct block) <superblock>: Now const.
1637         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
1638         * psymtab.c (psym_map_matching_symbols): Make "block" const.
1639         (map_block): Make "block" const.
1640         * symfile.h (struct quick_symbol_functions)
1641         <map_matching_symbols>: Constify block argument to "callback".
1642         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
1643         const.
1644         (find_pc_sect_compunit_symtab): Make "b" const.
1645         (find_symbol_at_address): Likewise.
1646         (search_symbols): Likewise.
1647         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
1648         (dw2_debug_names_lookup_symbol): Likewise.
1649         (dw2_map_matching_symbols): Update.
1650         * p-valprint.c (pascal_val_print): Remove "block".
1651         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
1652         (aux_add_nonlocal_symbols): Make "block" const.
1653         (resolve_subexp): Remove cast.
1654         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
1655         const.
1656         (iterate_over_file_blocks): Likewise.
1657         * f-exp.y (%union) <bval>: Remove.
1658         * coffread.c (patch_opaque_types): Make "b" const.
1659         * spu-tdep.c (spu_catch_start): Make "block" const.
1660         * c-valprint.c (print_unpacked_pointer): Remove "block".
1661         * symmisc.c (dump_symtab_1): Make "b" const.
1662         (block_depth): Make "block" const.
1663         * d-exp.y (%union) <bval>: Remove.
1664         * cp-support.h (cp_lookup_rtti_type): Update.
1665         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
1666         * psymtab.c (psym_lookup_symbol): Make "block" const.
1667         (maintenance_check_psymtabs): Make "b" const.
1668         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
1669         (enumerate_locals, enumerate_args): Update.
1670         * python/py-symtab.c (stpy_global_block): Make "block" const.
1671         (stpy_static_block): Likewise.
1672         * inline-frame.c (block_starting_point_at): Make "new_block"
1673         const.
1674         * block.c (find_block_in_blockvector): Make return type const.
1675         (blockvector_for_pc_sect): Make "b" const.
1676         (find_block_in_blockvector): Make "b" const.
1677
1678 2019-03-23  Tom Tromey  <tom@tromey.com>
1679
1680         * varobj.c (varobj_create): Update.
1681         * symfile.c (clear_symtab_users): Don't reset innermost_block.
1682         * printcmd.c (display_command, do_one_display): Don't reset
1683         innermost_block.
1684         * parser-defs.h (enum innermost_block_tracker_type): Move to
1685         expression.h.
1686         (innermost_block): Update comment.
1687         * parse.c (parse_exp_1): Add tracker_types parameter.
1688         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
1689         tracker_types parameter.  Reset innermost_block.
1690         (parse_exp_in_context): Remove.
1691         (parse_expression_for_completion): Update.
1692         * objfiles.c (~objfile): Don't reset expression_context_block or
1693         innermost_block.
1694         * expression.h (enum innermost_block_tracker_type): Move from
1695         parser-defs.h.
1696         (parse_exp_1): Add tracker_types parameter.
1697         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
1698         reset innermost_block.
1699
1700 2019-03-23  Tom Tromey  <tom@tromey.com>
1701
1702         * objfiles.h: Include bcache.h.
1703
1704 2019-03-23  Tom Tromey  <tom@tromey.com>
1705
1706         * linespec.c (get_current_search_block): Use
1707         scoped_restore_current_language.
1708         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
1709
1710 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1711             Jiong Wang  <jiong.wang@arm.com>
1712
1713         * aarch64-linux-tdep.c
1714         (aarch64_linux_iterate_over_regset_sections): Check for pauth
1715         section.
1716         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
1717
1718 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1719             Jiong Wang  <jiong.wang@arm.com>
1720
1721         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
1722         instructions.
1723         (aarch64_analyze_prologue_test): Add PACIASP test.
1724         (aarch64_prologue_prev_register): Unmask PC value.
1725
1726 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1727             Jiong Wang  <jiong.wang@arm.com>
1728
1729         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
1730         (aarch64_dwarf2_prev_register): Unmask PC value.
1731         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
1732         (aarch64_execute_dwarf_cfa_vendor_op): Check for
1733         DW_CFA_AARCH64_negate_ra_state.
1734         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
1735
1736 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1737             Jiong Wang  <jiong.wang@arm.com>
1738
1739         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
1740         registers.
1741         (aarch64_pseudo_register_name): Likewise.
1742         (aarch64_pseudo_register_type): Likewise.
1743         (aarch64_pseudo_register_reggroup_p): Likewise.
1744         (aarch64_gdbarch_init): Add pauth registers.
1745         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
1746         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
1747         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
1748         (struct gdbarch_tdep): Add regnum for ra_state.
1749
1750 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1751             Jiong Wang  <jiong.wang@arm.com>
1752
1753         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
1754
1755 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1756             Jiong Wang  <jiong.wang@arm.com>
1757
1758         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
1759         function.
1760         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
1761         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
1762         (aarch64_gdbarch_init): Add puth registers.
1763         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
1764         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
1765         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
1766
1767 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1768             Jiong Wang  <jiong.wang@arm.com>
1769
1770         * aarch64-linux-nat.c
1771         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
1772         * aarch64-linux-tdep.c
1773         (aarch64_linux_core_read_description): Likewise.
1774         (aarch64_linux_get_hwcap): New function.
1775         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
1776         (aarch64_linux_get_hwcap): New declaration.
1777
1778 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1779             Jiong Wang  <jiong.wang@arm.com>
1780
1781         * aarch64-linux-nat.c
1782         (aarch64_linux_nat_target::read_description): Add pauth param.
1783         * aarch64-linux-tdep.c
1784         (aarch64_linux_core_read_description): Likewise.
1785         * aarch64-tdep.c (struct target_desc): Add in pauth.
1786         (aarch64_read_description): Add pauth param.
1787         (aarch64_gdbarch_init): Likewise.
1788         * aarch64-tdep.h (aarch64_read_description): Likewise.
1789         * arch/aarch64.c (aarch64_create_target_description): Likewise.
1790         * arch/aarch64.h (aarch64_create_target_description): Likewise.
1791         * features/Makefile: Add new files.
1792         * features/aarch64-pauth.c: New file.
1793         * features/aarch64-pauth.xml: New file.
1794
1795 2019-03-20  Tom Tromey  <tromey@adacore.com>
1796
1797         * infrun.c (handle_inferior_event): Rename from
1798         handle_inferior_event_1.  Create a scoped_value_mark.
1799         (handle_inferior_event): Remove.
1800
1801 2019-03-19  Tom Tromey  <tromey@adacore.com>
1802
1803         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
1804         * infrun.h (print_stop_event): Add "displays" parameter.
1805         * infrun.c (print_stop_event): Add "displays" parameter.
1806
1807 2019-03-19  Pedro Alves  <palves@redhat.com>
1808
1809         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
1810         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
1811         to -1.  Fix TABs vs spaces.
1812         (tui_ui_out::tui_ui_out): Don't initialize fields here.
1813         * tui/tui-out.h (tui_ui_out) Add intro comments.
1814         <m_line, m_start_of_line>: In-class initialize, and add describing
1815         comment.
1816
1817 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
1818
1819         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
1820         variable names.
1821         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
1822
1823 2019-03-18  Pedro Alves  <palves@redhat.com>
1824             Eli Zaretskii <eliz@gnu.org>
1825
1826         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
1827         m_line and m_start_of_line.
1828
1829 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
1830
1831         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
1832         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
1833         it returns a newline.  This fixes a regression in TU mode, whereby
1834         the next line is output on the same screen line as the user input.
1835
1836 2019-03-18  Tom Tromey  <tromey@adacore.com>
1837
1838         * minsyms.c (minimal_symbol_reader::install): Remove call to
1839         obstack_blank.
1840
1841 2019-03-18  Pedro Alves  <palves@redhat.com>
1842
1843         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
1844         New globals.
1845         (apply_style): New, factored out from ...
1846         (apply_ansi_escape): ... this.  Handle reverse video mode.
1847         (tui_set_reverse_mode): New function.
1848         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
1849         * tui/tui-winsource.c (tui_show_source_line): Use
1850         tui_set_reverse_mode instead of setting A_STANDOUT.
1851         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
1852         New setter methods.
1853
1854 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
1855
1856         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
1857         Handle tabs.
1858
1859 2019-03-18  Tom Tromey  <tromey@adacore.com>
1860
1861         * ada-lang.c (empty_array): Add "high" parameter.
1862         (ada_evaluate_subexp): Update.
1863
1864 2019-03-17  Sergei Trofimovich <siarheit@google.com>
1865
1866         * unittests/string_view-selftests.c: Define
1867         _initialize_string_view_selftests unconditionally.
1868
1869 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1870
1871         PR gdb/24350
1872         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
1873
1874 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1875
1876         PR gdb/24351
1877         * windows-nat.c (display_selector): Fix format specifiers.
1878
1879 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
1880
1881         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
1882         tui_refill_source_window instead of tui_refresh_win, to update the
1883         current execution line.  This fixes redisplay of the current line
1884         when stepping through the code with "next" or "step".
1885
1886 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1887
1888         * source-cache.c (source_cache::get_source_lines): Call
1889         find_source_lines to initialize s->nlines.  This fixes vertical
1890         scrolling of TUI source window when the DOWN arrow is pressed.
1891
1892 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1893
1894         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
1895         linux-thread-db.c (_initialize_thread_db): Likewise.
1896
1897 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1898
1899         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
1900         wclrtoeol in tui_show_source_line".  This reverts changes made in
1901         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
1902
1903 2019-03-15  Tom Tromey  <tom@tromey.com>
1904
1905         * symtab.h (struct minimal_symbol): Derive from
1906         general_symbol_info.
1907         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
1908         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
1909         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
1910         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
1911         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
1912         (MSYMBOL_SEARCH_NAME): Update.
1913         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
1914         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
1915         * minsyms.c (minimal_symbol_reader::record_full): Update.
1916
1917 2019-03-15  Tom Tromey  <tom@tromey.com>
1918
1919         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
1920
1921 2019-03-15  Tom Tromey  <tom@tromey.com>
1922
1923         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
1924         unique_xmalloc_ptr.
1925         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
1926         Update.
1927         * minsyms.c (lookup_minimal_symbol_by_pc_section)
1928         (build_minimal_symbol_hash_tables)
1929         (minimal_symbol_reader::install): Update.
1930
1931 2019-03-15  Tom Tromey  <tom@tromey.com>
1932
1933         * symtab.c (create_demangled_names_hash): Update.
1934         (symbol_set_names): Update.
1935         * objfiles.h (struct objfile_per_bfd_storage)
1936         <demangled_names_hash>: Now an htab_up.
1937         * objfiles.c (objfile_per_bfd_storage): Simplify.
1938
1939 2019-03-15  Tom Tromey  <tom@tromey.com>
1940
1941         * objfiles.h (struct objfile_per_bfd_storage): Declare
1942         destructor.
1943         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
1944         New.
1945         (get_objfile_bfd_data): Use new.  Don't initialize
1946         language_of_main.
1947         (free_objfile_per_bfd_storage): Remove.
1948         (objfile_bfd_data_free, objfile::~objfile): Use delete.
1949
1950 2019-03-15  Tom Tromey  <tom@tromey.com>
1951
1952         * symfile.c (reread_symbols): Update.
1953         * objfiles.c (objfile::objfile): Update.
1954         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
1955         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
1956         comment.
1957         (minimal_symbol_reader::install): Update.
1958         (terminate_minimal_symbol_table): Remove.
1959         * jit.c (jit_object_close_impl): Update.
1960
1961 2019-03-15  Tom Tromey  <tom@tromey.com>
1962
1963         * minsyms.c (minimal_symbol_reader::record_full): Remove some
1964         initializations.
1965
1966 2019-03-15  Tom Tromey  <tom@tromey.com>
1967
1968         * objfiles.h (struct objfile_per_bfd_storage)
1969         <demangled_hash_languages>: Now a bitset.
1970         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
1971         (lookup_minimal_symbol): Update.
1972
1973 2019-03-15  Tom Tromey  <tom@tromey.com>
1974
1975         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
1976         Don't return the symbol.
1977         * coffread.c (record_minimal_symbol): Use record_full.
1978
1979 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
1980
1981         The MS-Windows port of ncurses fails to switch to a color pair if
1982         one or both of the colors are the implicit default colors.  This
1983         change records the default colors when TUI is initialized, and
1984         then specifies them explicitly when a color pair uses the default
1985         colors.  This allows color styling in TUI mode on MS-Windows.
1986
1987         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
1988         ncurses_norm_attr.
1989         (tui_initialize_io) [__MINGW32__]: Record the default terminal
1990         colors in ncurses_norm_attr.
1991         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
1992         "none", replace it with the default color recorded in
1993         ncurses_norm_attr.
1994
1995 2019-03-14  Tom Tromey  <tromey@adacore.com>
1996
1997         * source-cache.h (class source_cache) <get_source_lines>: Return
1998         std::string.
1999         * source-cache.c (source_cache::extract_lines): Handle case where
2000         first_pos==npos.  Return std::string.
2001         (source_cache::get_source_lines): Update.
2002
2003 2019-03-14  Tom Tromey  <tromey@adacore.com>
2004
2005         * NEWS: Add item for "style sources" commands.
2006         * source-cache.c (source_cache::get_source_lines): Check
2007         source_styling.
2008         * cli/cli-style.c (source_styling): New global.
2009         (_initialize_cli_style): Add "style sources" commands.
2010         (show_style_sources): New function.
2011         * cli/cli-style.h (source_styling): Declare.
2012
2013 2019-03-14  Pedro Alves  <palves@redhat.com>
2014             Tom Tromey  <tromey@adacore.com>
2015
2016         * tui/tui-winsource.h (tui_refill_source_window): Declare.
2017         * tui/tui-winsource.c (tui_refill_source_window): New function,
2018         from...
2019         (tui_horizontal_source_scroll): ... here.  Move some logic.
2020         * cli/cli-style.c (set_style_enabled): Notify new observable.
2021         * tui/tui-hooks.c (tui_redisplay_source): New function.
2022         (tui_attach_detach_observers): Attach or detach
2023         tui_redisplay_source.
2024         * observable.h (source_styling_changed): New observable.
2025         * observable.c: Define source_styling_changed observable.
2026
2027 2019-03-13  Tom Tromey  <tromey@adacore.com>
2028
2029         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
2030         (i386_gnu_nat_target::store_registers): Update.
2031         * target-debug.h (target_debug_print_std_string): New macro.
2032         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2033         * windows-tdep.c (display_one_tib): Update.
2034         * tui/tui-stack.c (tui_make_status_line): Update.
2035         * top.c (print_inferior_quit_action): Update.
2036         * thread.c (thr_try_catch_cmd): Update.
2037         (add_thread_with_info): Update.
2038         (thread_target_id_str): Update.
2039         (thr_try_catch_cmd): Update.
2040         (thread_command): Update.
2041         (thread_find_command): Update.
2042         * record-btrace.c (record_btrace_target::info_record)
2043         (record_btrace_resume_thread, record_btrace_target::resume)
2044         (record_btrace_cancel_resume, record_btrace_step_thread)
2045         (record_btrace_target::wait, record_btrace_target::wait)
2046         (record_btrace_target::wait, record_btrace_target::stop): Update.
2047         * progspace.c (print_program_space): Update.
2048         * process-stratum-target.c
2049         (process_stratum_target::thread_address_space): Update.
2050         * linux-fork.c (linux_fork_mourn_inferior)
2051         (detach_checkpoint_command, info_checkpoints_command)
2052         (linux_fork_context): Update.
2053         (linux_fork_detach): Update.
2054         (class scoped_switch_fork_info): Update.
2055         (delete_checkpoint_command): Update.
2056         * infrun.c (follow_fork_inferior): Update.
2057         (follow_fork_inferior): Update.
2058         (proceed_after_vfork_done): Update.
2059         (handle_vfork_child_exec_or_exit): Update.
2060         (follow_exec): Update.
2061         (displaced_step_prepare_throw): Update.
2062         (displaced_step_restore): Update.
2063         (start_step_over): Update.
2064         (resume_1): Update.
2065         (clear_proceed_status_thread): Update.
2066         (proceed): Update.
2067         (print_target_wait_results): Update.
2068         (do_target_wait): Update.
2069         (context_switch): Update.
2070         (stop_all_threads): Update.
2071         (restart_threads): Update.
2072         (finish_step_over): Update.
2073         (handle_signal_stop): Update.
2074         (switch_back_to_stepped_thread): Update.
2075         (keep_going_pass_signal): Update.
2076         (print_exited_reason): Update.
2077         (normal_stop): Update.
2078         * inferior.c (inferior_pid_to_str): Change return type.
2079         (print_selected_inferior): Update.
2080         (add_inferior): Update.
2081         (detach_inferior): Update.
2082         * dummy-frame.c (fprint_dummy_frames): Update.
2083         * dcache.c (dcache_info_1): Update.
2084         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
2085         (btrace_fetch, btrace_clear): Update.
2086         * linux-tdep.c (linux_core_pid_to_str): Change return type.
2087         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
2088         type.
2089         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
2090         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
2091         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
2092         * gdbarch.c, gdbarch.h: Rebuild.
2093         * gdbarch.sh (core_pid_to_str): Change return type.
2094         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
2095         return type.
2096         (windows_nat_target::pid_to_str): Change return type.
2097         (windows_delete_thread): Update.
2098         (windows_nat_target::attach): Update.
2099         (windows_nat_target::files_info): Update.
2100         * target-delegates.c: Rebuild.
2101         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
2102         return type.
2103         (sol_thread_target::pid_to_str): Change return type.
2104         * remote.c (class remote_target) <pid_to_str>: Change return
2105         type.
2106         (remote_target::pid_to_str): Change return type.
2107         (extended_remote_target::attach, remote_target::remote_stop_ns)
2108         (remote_target::remote_notif_remove_queued_reply)
2109         (remote_target::push_stop_reply, remote_target::disable_btrace):
2110         Update.
2111         (extended_remote_target::attach): Update.
2112         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
2113         type.
2114         (gdbsim_target::pid_to_str): Change return type.
2115         * ravenscar-thread.c (struct ravenscar_thread_target)
2116         <pid_to_str>: Change return type.
2117         (ravenscar_thread_target::pid_to_str): Change return type.
2118         * procfs.c (class procfs_target) <pid_to_str>: Change return
2119         type.
2120         (procfs_target::pid_to_str): Change return type.
2121         (procfs_target::attach): Update.
2122         (procfs_target::detach): Update.
2123         (procfs_target::fetch_registers): Update.
2124         (procfs_target::store_registers): Update.
2125         (procfs_target::wait): Update.
2126         (procfs_target::files_info): Update.
2127         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
2128         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
2129         return type.
2130         (nto_procfs_target::pid_to_str): Change return type.
2131         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
2132         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
2133         return type.
2134         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
2135         (exit_lwp): Update.
2136         (attach_proc_task_lwp_callback, get_detach_signal)
2137         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
2138         (linux_nat_target::resume, wait_lwp, stop_callback)
2139         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
2140         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
2141         (linux_nat_wait_1, resume_stopped_resumed_lwps)
2142         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
2143         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
2144         type.
2145         (inf_ptrace_target::attach): Update.
2146         (inf_ptrace_target::files_info): Update.
2147         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
2148         type.
2149         (go32_nat_target::pid_to_str): Change return type.
2150         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
2151         (gnu_nat_target::wait): Update.
2152         (gnu_nat_target::wait): Update.
2153         (gnu_nat_target::resume): Update.
2154         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
2155         (fbsd_nat_target::wait): Update.
2156         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
2157         type.
2158         (darwin_nat_target::attach): Update.
2159         * corelow.c (class core_target) <pid_to_str>: Change return type.
2160         (core_target::pid_to_str): Change return type.
2161         * target.c (normal_pid_to_str): Change return type.
2162         (default_pid_to_str): Likewise.
2163         (target_pid_to_str): Change return type.
2164         (target_translate_tls_address): Update.
2165         (target_announce_detach): Update.
2166         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
2167         return type.
2168         (bsd_uthread_target::pid_to_str): Change return type.
2169         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
2170         type.
2171         (bsd_kvm_target::pid_to_str): Change return type.
2172         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
2173         return type.
2174         (aix_thread_target::pid_to_str): Change return type.
2175         * target.h (struct target_ops) <pid_to_str>: Change return type.
2176         (target_pid_to_str, normal_pid_to_str): Likewise.
2177         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
2178         type.
2179         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
2180         type.
2181         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
2182         return type.
2183         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
2184         type.
2185         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
2186         type.
2187         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
2188         return type.
2189
2190 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
2191
2192         * NEWS: Mention that the new default MI version is 3.  Mention
2193         changes to the output of commands and events that deal with
2194         multi-location breakpoints.
2195         * breakpoint.c: Include "mi/mi-out.h".
2196         (print_one_breakpoint): Change output syntax if using MI version
2197         >= 3.
2198         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
2199         New.
2200         (mi_multi_location_breakpoint_output_fixed): New.
2201         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
2202         (mi_cmd_fix_multi_location_breakpoint_output): New.
2203         (mi_multi_location_breakpoint_output_fixed): New.
2204         * mi/mi-cmds.c (mi_cmds): Register command
2205         -fix-multi-location-breakpoint-output.
2206         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
2207         interpreter "mi".
2208
2209 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
2210
2211         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
2212         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
2213         instantiate mi_ui_out based on interpreter name.
2214         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
2215         * mi/mi-main.c (mi_load_progress): Likewise.
2216
2217 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2218
2219         * NEWS: Combine separate "New targets" sections for 8.3.
2220
2221 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2222
2223         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
2224         (ppcfbsd_init_abi): Install gdbarch
2225         "fetch_tls_load_module_address" and "get_thread_local_address"
2226         methods.
2227
2228 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2229
2230         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
2231         (riscv_fbsd_init_abi): Install gdbarch
2232         "fetch_tls_load_module_address" and "get_thread_local_address"
2233         methods.
2234
2235 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2236
2237         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
2238         (i386fbsd_init_abi): Install gdbarch
2239         "fetch_tls_load_module_address" and "get_thread_local_address"
2240         methods.
2241
2242 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2243
2244         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
2245         (amd64fbsd_init_abi): Install gdbarch
2246         "fetch_tls_load_module_address" and "get_thread_local_address"
2247         methods.
2248
2249 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2250
2251         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
2252         (struct fbsd_pspace_data): New type.
2253         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
2254         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
2255         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
2256         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
2257         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
2258
2259 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2260
2261         * gdbtypes.c (lookup_struct_elt): New function.
2262         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
2263         * gdbtypes.h (struct struct_elt): New type.
2264         (lookup_struct_elt): New prototype.
2265
2266 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2267
2268         * gdbtypes.c (lookup_struct_elt_type): Update comment and
2269         remove disabled code block.
2270
2271 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2272
2273         * gdbarch.sh (get_thread_local_address): New method.
2274         * gdbarch.h, gdbarch.c: Regenerate.
2275         * target.c (target_translate_tls_address): Use
2276         gdbarch_get_thread_local_address if present instead of
2277         target::get_thread_local_address.
2278
2279 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2280
2281         * target.h (target::get_thread_local_address): Update comment.
2282
2283 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2284
2285         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
2286         objfile->separate_debug_objfile_backlink if not NULL.
2287
2288 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2289
2290         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
2291         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
2292         (amd64bsd_store_inferior_registers): Likewise.
2293         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2294         Enable segment base registers.
2295         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
2296         PT_GETFSBASE and PT_GETGSBASE.
2297         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
2298         PT_SETGSBASE.
2299         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
2300         segment base registers.
2301         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2302
2303 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2304
2305         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2306         Update calls to i386_target_description to add 'segments'
2307         parameter.
2308         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
2309         add segment base registers.
2310         * arch/i386.c (i386_create_target_description): Add 'segments'
2311         parameter to enable segment base registers.
2312         * arch/i386.h (i386_create_target_description): Likewise.
2313         * features/i386/32bit-segments.xml: New file.
2314         * features/i386/32bit-segments.c: Generate.
2315         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
2316         call to i386_target_description to add 'segments' parameter.
2317         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2318         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
2319         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
2320         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
2321         if feature is present.
2322         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
2323         Add 'segments' parameter to call to i386_target_description.
2324         (i386_target_description): Add 'segments' parameter to enable
2325         segment base registers.
2326         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
2327         to call to i386_target_description.
2328         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
2329         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
2330         Define I386_NUM_REGS.
2331         (i386_target_description): Add 'segments' parameter to enable
2332         segment base registers.
2333
2334 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
2335
2336         PR/24325
2337         * source-cache.c: #undef open and close, to avoid unresolved
2338         externals during linking.
2339
2340 2019-03-12  Tom Tromey  <tromey@adacore.com>
2341
2342         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
2343         const.  Add initializers.
2344         (_initialize_remote): Don't initialize ptid globals.
2345
2346 2019-03-12  Pedro Alves  <palves@redhat.com>
2347
2348         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
2349
2350 2019-03-12  Pedro Alves  <palves@redhat.com>
2351
2352         * cp-name-parser.y (main): Remove unused 'len' variable.
2353
2354 2019-03-12  Tom Tromey  <tromey@adacore.com>
2355
2356         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
2357         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
2358
2359 2019-03-12  Tom Tromey  <tromey@adacore.com>
2360
2361         * linux-nat.c (iterate_over_lwps): Update.
2362         (stop_callback): Remove parameter.
2363         (stop_wait_callback, detach_callback, resume_set_callback)
2364         (select_singlestep_lwp_callback, set_ignore_sigint)
2365         (status_callback, resumed_callback, resume_clear_callback)
2366         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
2367         data parameter.
2368         (linux_nat_target::detach, linux_nat_target::resume)
2369         (linux_stop_and_wait_all_lwps, select_event_lwp)
2370         (linux_nat_filter_event, linux_nat_wait_1)
2371         (linux_nat_target::kill, linux_nat_target::stop)
2372         (linux_nat_target::stop): Update.
2373         (linux_nat_resume_callback): Change type.
2374         (resume_stopped_resumed_lwps, count_events_callback)
2375         (select_event_lwp_callback): Likewise.
2376         (linux_stop_lwp, linux_nat_stop_lwp): Update.
2377         * arm-linux-nat.c (struct update_registers_data): Remove.
2378         (update_registers_callback): Change type.
2379         (arm_linux_insert_hw_breakpoint1): Update.
2380         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
2381         parameter.
2382         (x86_linux_dr_set_addr): Update.
2383         (x86_linux_dr_set_control): Update.
2384         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
2385         (iterate_over_lwps): Use gdb::function_view.
2386         * nat/aarch64-linux-hw-point.c (struct
2387         aarch64_dr_update_callback_param): Remove.
2388         (debug_reg_change_callback): Change type.
2389         (aarch64_notify_debug_reg_change): Update.
2390         * s390-linux-nat.c (s390_refresh_per_info): Update.
2391
2392 2019-03-11  Tom Tromey  <tromey@adacore.com>
2393
2394         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
2395         redundant assignment to "this_cu".
2396
2397 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2398
2399         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
2400
2401 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2402
2403         * gdbtypes.c (rank_one_type_parm_set): New function extracted
2404         from...
2405         (rank_one_type): ... this.
2406
2407 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2408
2409         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
2410         from...
2411         (rank_one_type): ... this.
2412
2413 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2414
2415         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
2416         from...
2417         (rank_one_type): ... this.
2418
2419 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2420
2421         * gdbtypes.c (rank_one_type_parm_float): New function extracted
2422         from...
2423         (rank_one_type): ... this.
2424
2425 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2426
2427         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
2428         from...
2429         (rank_one_type): ... this.
2430
2431 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2432
2433         * gdbtypes.c (rank_one_type_parm_range): New function extracted
2434         from...
2435         (rank_one_type): ... this.
2436
2437 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2438
2439         * gdbtypes.c (rank_one_type_parm_char): New function extracted
2440         from...
2441         (rank_one_type): ... this.
2442
2443 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2444
2445         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
2446         from...
2447         (rank_one_type): ... this.
2448
2449 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2450
2451         * gdbtypes.c (rank_one_type_parm_int): New function extracted
2452         from...
2453         (rank_one_type): ... this.
2454
2455 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2456
2457         * gdbtypes.c (rank_one_type_parm_func): New function extracted
2458         from...
2459         (rank_one_type): ... this.
2460
2461 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2462
2463         * gdbtypes.c (rank_one_type_parm_array): New function extracted
2464         from...
2465         (rank_one_type): ... this.
2466
2467 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2468
2469         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
2470         from...
2471         (rank_one_type): ... this.
2472
2473 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2474
2475         * inferior.c (initialize_inferiors): Ensure 'help set/show print
2476         inferior-events' shows the example events.
2477
2478 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
2479
2480         Support styling on native MS-Windows console
2481
2482         PR/24315
2483         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
2484         on MS-Windows if $TERM is not defined.
2485
2486         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
2487
2488         * posix-hdep.c (gdb_console_fputs):
2489         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
2490         functions.
2491         * ui-file.h (gdb_console_fputs): Add prototype.
2492
2493         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
2494         back to fputs only if the former returns zero.
2495
2496 2019-03-07  Tom Tromey  <tom@tromey.com>
2497
2498         * symmisc.c (print_symbol_bcache_statistics): Update.
2499         (print_objfile_statistics): Update.
2500         * symfile.c (allocate_symtab): Update.
2501         * stabsread.c: Don't include bcache.h.
2502         * psymtab.h (struct psymbol_bcache): Don't declare.
2503         (class psymtab_storage) <psymbol_cache>: Now a bcache.
2504         (psymbol_bcache_init, psymbol_bcache_free)
2505         (psymbol_bcache_get_bcache): Don't declare.
2506         * psymtab.c (struct psymbol_bcache): Remove.
2507         (psymtab_storage::psymtab_storage): Update.
2508         (psymtab_storage::~psymtab_storage): Update.
2509         (psymbol_bcache_init, psymbol_bcache_free)
2510         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
2511         (add_psymbol_to_bcache): Update.
2512         (allocate_psymtab): Update.
2513         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
2514         macro_cache>: No longer pointers.
2515         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
2516         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
2517         * macrotab.c (macro_bcache): Update.
2518         * macroexp.c: Don't include bcache.h.
2519         * gdbtypes.c (check_types_worklist): Update.
2520         (types_deeply_equal): Remove TRY/CATCH.  Update.
2521         * elfread.c (elf_symtab_read): Update.
2522         * dwarf2read.c: Don't include bcache.h.
2523         * buildsym.c (buildsym_compunit::get_macro_table): Update.
2524         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
2525         (print_bcache_statistics, bcache_memory_used): Don't declare.
2526         (struct bcache): Move from bcache.c.  Add constructor, destructor,
2527         methods.  Rename all data members.
2528         * bcache.c (struct bcache): Move to bcache.h.
2529         (bcache::expand_hash_table): Rename from expand_hash_table.
2530         (bcache): Remove.
2531         (bcache::insert): Rename from bcache_full.
2532         (bcache::compare): Rename from bcache_compare.
2533         (bcache_xmalloc): Remove.
2534         (bcache::~bcache): Rename from bcache_xfree.
2535         (bcache::print_statistics): Rename from print_bcache_statistics.
2536         (bcache::memory_used): Rename from bcache_memory_used.
2537
2538 2019-03-07  Pedro Alves  <palves@redhat.com>
2539
2540         * infrun.c (normal_stop): Also check for
2541         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
2542
2543 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
2544
2545         * f-lang.c (value_from_host_double): Moved to...
2546         * value.c (value_from_host_double): ...here.
2547         * value.h (value_from_host_double): Declare.
2548         * guile/scm-math.c (vlscm_convert_typed_number): Use
2549         value_from_host_double.
2550         (vlscm_convert_number): Likewise.
2551         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
2552         * python/py-value.c (convert_value_from_python): Likewise.
2553
2554 2019-03-06  Tom Tromey  <tom@tromey.com>
2555
2556         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
2557
2558 2019-03-06  Tom Tromey  <tom@tromey.com>
2559
2560         * utils.h (free_current_contents): Don't declare.
2561         * utils.c (free_current_contents): Remove.
2562
2563 2019-03-06  Tom Tromey  <tom@tromey.com>
2564
2565         * top.c (quit_force): Update.
2566         * main.c (captured_command_loop): Update.
2567         * common/new-op.c (operator new): Update.
2568         * common/common-exceptions.c (struct catcher)
2569         <save_cleanup_chain>: Remove member.
2570         (exceptions_state_mc_init): Update.
2571         (exception_try_scope_entry): Return nullptr.
2572         (exception_try_scope_exit, exception_rethrow)
2573         (throw_exception_sjlj, throw_exception_cxx): Update.
2574         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
2575         (all_cleanups, do_cleanups, discard_cleanups)
2576         (discard_final_cleanups, save_cleanups, save_final_cleanups)
2577         (restore_cleanups, restore_final_cleanups): Don't declare.
2578         (do_final_cleanups): Remove parameter.
2579         * common/cleanups.c (cleanup_chain, make_cleanup)
2580         (make_cleanup_dtor, all_cleanups, do_cleanups)
2581         (discard_my_cleanups, discard_cleanups)
2582         (discard_final_cleanups, save_my_cleanups, save_cleanups)
2583         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
2584         (null_cleanup): Remove.
2585         (do_final_cleanups): Remove parameter.
2586
2587 2019-03-06  Tom Tromey  <tom@tromey.com>
2588
2589         * remote.c (remote_target::remote_parse_stop_reply): Use
2590         unique_xmalloc_ptr.
2591
2592 2019-03-06  Tom Tromey  <tom@tromey.com>
2593
2594         * stabsread.c (struct stabs_field_info): Rename from field_info.
2595         <list, fnlist>: Add initializers.
2596         <obstack>: New member.
2597         (read_member_functions, read_struct_fields, read_baseclasses):
2598         Allocate on obstack.  Don't use cleanups.
2599         (read_one_struct_field, read_member_functions, read_struct_fields)
2600         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
2601         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
2602         (read_struct_type): Update.
2603
2604 2019-03-06  Tom Tromey  <tom@tromey.com>
2605
2606         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
2607         * common/filestuff.h (make_cleanup_close): Don't declare.
2608         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
2609         Remove.
2610
2611 2019-03-06  Tom Tromey  <tom@tromey.com>
2612
2613         * solib-aix.c: Use make_scope_exit.
2614
2615 2019-03-06  Tom Tromey  <tom@tromey.com>
2616
2617         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
2618         Use make_scope_exit.
2619
2620 2019-03-06  Tom Tromey  <tom@tromey.com>
2621
2622         * solib-svr4.c (disable_probes_interface): Remove parameter.
2623         (svr4_handle_solib_event): Use make_scope_exit.
2624
2625 2019-03-06  Tom Tromey  <tom@tromey.com>
2626
2627         * remote.c (struct stop_reply_deleter): Remove.
2628         (stop_reply_up): Update.
2629         (struct stop_reply): Derive from notif_event.  Don't typedef.
2630         <regcache>: Now a std::vector.
2631         (stop_reply_xfree): Remove.
2632         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
2633         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
2634         (remote_target::discard_pending_stop_replies): Use delete.
2635         (remote_target::remote_parse_stop_reply): Update.
2636         (remote_target::process_stop_reply): Update.
2637         * remote-notif.h (struct notif_event): Add virtual destructor.
2638         Remove "dtr" member.
2639         (struct notif_client) <alloc_event>: Return a unique_ptr.
2640         (notif_event_xfree): Don't declare.
2641         (notif_event_up): New typedef.
2642         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
2643         (notif_event_xfree, do_notif_event_xfree): Remove.
2644         (remote_notif_state_xfree): Update.
2645
2646 2019-03-06  Tom Tromey  <tom@tromey.com>
2647
2648         * infrun.c (displaced_step_clear_cleanup): Now a
2649         forward_scope_exit type.
2650         (displaced_step_prepare_throw): Update.
2651         (displaced_step_fixup): Update.
2652
2653 2019-03-06  Tom Tromey  <tom@tromey.com>
2654
2655         * inferior.h (class inferior): Update comment.
2656         * gdbthread.h (class thread_info): Update comment.
2657
2658 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
2659             Tom Tromey  <tom@tromey.com>
2660
2661         * stabsread.h (struct stab_section_list): Remove.
2662         (coffstab_build_psymtabs): Update.
2663         * dbxread.c (symbuf_sections): Now a std::vector.
2664         (sect_idx): New global.
2665         (fill_symbuf): Update.
2666         (coffstab_build_psymtabs): Change type of stabsects parameter.
2667         Update.
2668         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
2669         std::vector.
2670         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
2671         (coff_locate_sections): Update.
2672         (coff_symfile_read): Remove cleanups.  Update.
2673         (init_stringtab): Add storage parameter.
2674         (free_stringtab, free_stringtab_cleanup): Remove.
2675         (init_lineno): Add storage parameter.
2676         (free_linetab, free_linetab_cleanup): Remove.
2677
2678 2019-03-06  Pedro Alves  <palves@redhat.com>
2679
2680         * linux-fork.c (fork_info::clobber_regs): Delete.
2681         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
2682         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
2683         comment.  Adjust.
2684         (scoped_switch_fork_info::scoped_switch_fork_info)
2685         (checkpoint_command, linux_fork_context): Adjust
2686         fork_save_infrun_state calls.
2687
2688 2019-03-06  Pedro Alves  <palves@redhat.com>
2689
2690         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
2691         (inf_has_multiple_threads): Return 'bool' and rewrite using
2692         inferior_info::threads().
2693
2694 2019-03-06  Pedro Alves  <palves@redhat.com>
2695
2696         * linux-fork.c: Include <list>.
2697         (fork_list): Now a std::list instance.
2698         (fork_info): Add ctor, dtor, and in-class initialize all fields.
2699         (forks_exist_p, find_last_fork): Adjust.
2700         (new_fork): Delete.
2701         (one_fork_p): New.
2702         (add_fork): Adjust.
2703         (free_fork): Delete, folded into fork_info::~fork_info().
2704         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
2705         Adjust.
2706         (init_fork_list): Delete.
2707         (linux_fork_killall, linux_fork_mourn_inferior)
2708         (linux_fork_detach, info_checkpoints_command): Adjust.
2709         (_initialize_linux_fork): No longer call init_fork_list.
2710
2711 2019-03-06  Pedro Alves  <palves@redhat.com>
2712
2713         * linux-fork.c (new_fork): New, split out of ...
2714         (add_fork): ... this.  Return void.  Move "first fork" special
2715         case from here, to ...
2716         (checkpoint_command): ... here.
2717         * linux-linux.h (add_fork): Return void.
2718
2719 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2720
2721         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
2722
2723 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2724             Chris January  <chris.january@arm.com>
2725             David Lecomber  <david.lecomber@arm.com>
2726
2727         * f-exp.y: New token, UNOP_INTRINSIC.
2728         (exp): New pattern using UNOP_INTRINSIC token.
2729         (f77_keywords): Add 'abs' keyword.
2730         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
2731         (value_from_host_double): New function.
2732         (evaluate_subexp_f): Support UNOP_ABS.
2733
2734 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2735
2736         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
2737         types.
2738
2739 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2740
2741         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
2742         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
2743         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
2744
2745 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2746
2747         * f-exp.y (convert_to_kind_type): Handle more type kinds.
2748
2749 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2750             Chris January  <chris.january@arm.com>
2751
2752         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
2753         * f-exp.y: Define 'KIND' token.
2754         (exp): New pattern for KIND expressions.
2755         (ptype): Handle types with a kind extension.
2756         (direct_abs_decl): Extend to spot kind extensions.
2757         (f77_keywords): Add 'kind' to the list.
2758         (push_kind_type): New function.
2759         (convert_to_kind_type): New function.
2760         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
2761         * parse.c (operator_length_standard): Likewise.
2762         * parser-defs.h (enum type_pieces): Add tp_kind.
2763         * std-operator.def: Add UNOP_KIND.
2764
2765 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2766
2767         * f-exp.y (f_parse): Set yydebug.
2768
2769 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2770
2771         * f-lang.c (evaluate_subexp_f): New function.
2772         (exp_descriptor_f): New global.
2773         (f_language_defn): Use exp_descriptor_f instead of
2774         exp_descriptor_standard.
2775
2776 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2777
2778         * f-exp.y (struct token): Add comments.
2779         (dot_ops): Remove uppercase versions and the end marker.
2780         (f77_keywords): Likewise.
2781         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
2782         entries in the dot_ops array are case insensitive, and use
2783         strncasecmp to compare strings.  Also some whitespace cleanup in
2784         this area.  Similar for the f77_keywords array, except entries in
2785         this list might be case sensitive.
2786
2787 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2788
2789         * f-exp.y (struct f77_boolean_val): Add comments.
2790         (boolean_values): Remove uppercase versions, and end marker.
2791         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
2792         and use strncasecmp to achieve case insensitivity.  Additionally,
2793         perform whitespace cleanup around this code.
2794
2795 2019-03-06  Tom Tromey  <tromey@adacore.com>
2796
2797         * remote-sim.c (gdbsim_target_open): Use result of
2798         gdb_argv::release.
2799
2800 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
2801         Dirk Schubert  <dirk.schubert@arm.com>
2802         Chris January  <chris.january@arm.com>
2803
2804         * eval.c (evaluate_subexp_standard): Call Fortran argument
2805         wrapping logic.
2806         * f-lang.c (struct value): A value which can be passed into a
2807         Fortran function call.
2808         (fortran_argument_convert): Wrap Fortran arguments in a pointer
2809         where appropriate.
2810         (struct type): Value ready for a Fortran function call.
2811         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
2812         is needed.
2813         * f-lang.h (fortran_argument_convert): Declaration.
2814         (fortran_preserve_arg_pointer): Declaration.
2815         * infcall.c (value_arg_coerce): Call Fortran argument logic.
2816
2817 2019-03-05  Tom Tromey  <tromey@adacore.com>
2818
2819         * python/py-prettyprint.c (print_string_repr): Remove #if.
2820         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
2821
2822 2019-03-05  Tom Tromey  <tromey@adacore.com>
2823
2824         * target.c (the_dummy_target): Move later.  Change type to
2825         "dummy_target".
2826         (initialize_targets): Don't initialize the_dummy_target.
2827
2828 2019-03-05  Tom Tromey  <tromey@adacore.com>
2829
2830         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
2831         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
2832
2833 2019-03-05  Tom Tromey  <tromey@adacore.com>
2834
2835         * windows-nat.c (windows_nat_target::attach)
2836         (windows_nat_target::detach): Don't call gdb_flush.
2837         * valprint.c (generic_val_print, val_print, val_print_string):
2838         Don't call gdb_flush.
2839         * utils.c (defaulted_query): Don't call gdb_flush.
2840         * typeprint.c (print_type_scalar): Don't call gdb_flush.
2841         * target.c (target_announce_detach): Don't call gdb_flush.
2842         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
2843         * remote.c (extended_remote_target::attach): Don't call
2844         gdb_flush.
2845         * procfs.c (procfs_target::detach): Don't call gdb_flush.
2846         * printcmd.c (do_examine): Don't call gdb_flush.
2847         (info_display_command): Don't call gdb_flush.
2848         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
2849         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
2850         * memattr.c (info_mem_command): Don't call gdb_flush.
2851         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
2852         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
2853         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
2854         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
2855         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
2856         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
2857         (gnu_nat_target::detach): Don't call gdb_flush.
2858         * f-valprint.c (f_val_print): Don't call gdb_flush.
2859         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
2860         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
2861         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
2862         gdb_flush.
2863         * c-valprint.c (c_val_print): Don't call gdb_flush.
2864         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
2865
2866 2019-03-05  Tom Tromey  <tromey@adacore.com>
2867
2868         * varobj.c (update_dynamic_varobj_children): Update.
2869         (install_default_visualizer): Use reset, not release.
2870         * value.c (set_internalvar): Update.
2871         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
2872         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
2873         ATTRIBUTE_UNUSED_RESULT.
2874
2875 2019-03-05  Tom Tromey  <tromey@adacore.com>
2876
2877         * remote.c (class scoped_remote_fd) <release>: Add
2878         ATTRIBUTE_UNUSED_RESULT.
2879
2880 2019-03-05  Tom Tromey  <tromey@adacore.com>
2881
2882         * macroexp.c (struct macro_buffer) <release>: Add
2883         ATTRIBUTE_UNUSED_RESULT.
2884
2885 2019-03-05  Tom Tromey  <tromey@adacore.com>
2886
2887         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
2888         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
2889         ATTRIBUTE_UNUSED_RESULT.
2890
2891 2019-03-05  Tom Tromey  <tromey@adacore.com>
2892
2893         * common/scoped_fd.h (class scoped_fd) <release>: Add
2894         ATTRIBUTE_UNUSED_RESULT.
2895
2896 2019-03-05  Tom Tromey  <tromey@adacore.com>
2897
2898         * parser-defs.h (struct parser_state) <release>: Add
2899         ATTRIBUTE_UNUSED_RESULT.
2900
2901 2019-03-05  Tom Tromey  <tromey@adacore.com>
2902
2903         * utils.h (class gdb_argv) <release>: Add
2904         ATTRIBUTE_UNUSED_RESULT.
2905         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
2906
2907 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
2908
2909         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
2910         for-loop range, to avoid compiler warnings.
2911
2912         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
2913         avoid compiler warnings about unused variables.
2914
2915         * NEWS: Mention end of support for native debugging on MS-Windows
2916         before XP.
2917
2918         PR gdb/24292
2919         * common/netstuff.c:
2920         * gdbserver/gdbreplay.c
2921         * gdbserver/remote-utils.c:
2922         * ser-tcp.c:
2923         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
2924         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
2925         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
2926         'getaddrinfo' and 'freeaddrinfo' were not available before
2927         Windows XP, and mingw.org's MinGW headers by default define
2928         _WIN32_WINNT to 0x500.
2929
2930 2019-03-01  Gary Benson <gbenson@redhat.com>
2931
2932         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
2933
2934 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
2935             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2936
2937         PR gdb/8527
2938         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
2939         set_sigint_trap, clear_sigint_trap.
2940
2941 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2942
2943         * target.c (target_detach): Clear the regcache and the
2944         frame cache.
2945
2946 2019-02-27  Pedro Alves  <palves@redhat.com>
2947
2948         * utils.c (set_screen_size): When we cap the height/width sizes,
2949         tweak the corresponding command variable to show "unlimited":
2950
2951 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
2952             Pedro Alves  <palves@redhat.com>
2953
2954         * utils.c (set_screen_size): Reduce "infinite" rows and columns
2955         before calling rl_set_screen_size.
2956
2957 2019-02-27  Tom Tromey  <tromey@adacore.com>
2958
2959         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
2960         define.
2961         * python/py-value.c: Remove Python 2.4 workaround.
2962         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
2963         workaround.
2964         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
2965         Python 2.4 workaround.
2966         * python/python-internal.h: Remove Python 2.4 comment.
2967         (Py_ssize_t): Don't define.
2968         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
2969         (gdb_Py_DECREF): Remove Python 2.4 workaround.
2970         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
2971         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
2972         * python/python.c (do_start_initialization): Remove Python 2.4
2973         workaround.
2974         * python/py-prettyprint.c (class dummy_python_frame): Remove.
2975         (print_children): Remove Python 2.4 workaround.
2976         * python/py-inferior.c (buffer_procs): Remove Python 2.4
2977         workaround.
2978         (CHARBUFFERPROC_NAME): Remove.
2979         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
2980         Python 2.4 workaround.
2981
2982 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
2983
2984         * NEWS: Note minimum Python version.
2985
2986 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
2987
2988         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
2989         code from these functions.  Remove corresponding ifdefs.  Use
2990         Py_buffer_up instead of explicit calls to PyBuffer_Release.
2991         Remove gotos and target of gotos.
2992         (infpy_search_memory): Likewise.
2993
2994 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2995
2996         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
2997         (hppa_gdbarch_init): Don't register deleted functions with
2998         gdbarch.
2999
3000 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3001
3002         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
3003         (h8300_unwind_sp): Delete.
3004         (h8300_dummy_id): Delete.
3005         (h8300_gdbarch_init): Don't register deleted functions with
3006         gdbarch.
3007
3008 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3009
3010         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
3011         (ft32_unwind_pc): Delete.
3012         (ft32_unwind_sp): Delete.
3013         (ft32_gdbarch_init): Don't register deleted functions with
3014         gdbarch.
3015
3016 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3017
3018         * gdb/frv-tdep.c (frv_dummy_id): Delete.
3019         (frv_unwind_pc): Delete.
3020         (frv_unwind_sp): Delete.
3021         (frv_gdbarch_init): Don't register deleted functions with
3022         gdbarch.
3023
3024 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3025
3026         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
3027         (riscv_unwind_pc): Delete.
3028         (riscv_unwind_sp): Delete.
3029         (riscv_gdbarch_init): Don't register deleted functions with
3030         gdbarch.
3031
3032 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3033
3034         * gdb/csky-tdep.c (csky_dummy_id): Delete.
3035         (csky_unwind_pc): Delete.
3036         (csky_unwind_sp): Delete.
3037         (csky_gdbarch_init): Don't register deleted functions with
3038         gdbarch.
3039
3040 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3041
3042         * gdb/cris-tdep.c (cris_dummy_id): Delete.
3043         (cris_unwind_pc): Delete.
3044         (cris_unwind_sp): Delete.
3045         (cris_gdbarch_init): Don't register deleted functions with
3046         gdbarch.
3047
3048 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3049
3050         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
3051         (bfin_unwind_pc): Delete.
3052         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
3053
3054 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3055
3056         * gdb/arm-tdep.c (arm_dummy_id): Delete.
3057         (arm_unwind_pc): Delete.
3058         (arm_unwind_sp): Delete.
3059         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
3060
3061 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3062
3063         * gdb/arc-tdep.c (arc_dummy_id): Delete.
3064         (arc_unwind_pc): Delete.
3065         (arc_unwind_sp): Delete.
3066         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
3067
3068 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3069
3070         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
3071         (alpha_unwind_pc): Delete.
3072         (alpha_gdbarch_init): Don't register deleted functions with
3073         gdbarch.
3074
3075 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3076
3077         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
3078         (aarch64_unwind_pc): Delete.
3079         (aarch64_unwind_sp): Delete.
3080         (aarch64_gdbarch_init): Don't register deleted functions with
3081         gdbarch.
3082
3083 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3084
3085         * gdbtypes.c (type_align): Don't consider static members when
3086         computing structure alignment.
3087
3088 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3089
3090         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
3091         return 0 for other types.
3092         * arch-utils.c (default_type_align): Always return 0.
3093         * gdbarch.h: Regenerate.
3094         * gdbarch.sh (type_align): Extend comment.
3095         * gdbtypes.c (type_align): Add additional comments, always call
3096         gdbarch_type_align before applying the default rules.
3097         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
3098         generic code will then apply a suitable default.
3099         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
3100         types, return 0 for other types.
3101
3102 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3103
3104         * NEWS: Create a new section for the next release branch.
3105         Rename the section of the current branch, now that it has
3106         been cut.
3107
3108 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3109
3110         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
3111         * version.in: Bump version to 8.3.50.DATE-git.
3112
3113 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
3114
3115         * aix-thread.c (ptid_cmp): Remove unused variable.
3116         (get_signaled_thread): Likewise.
3117         (store_regs_user_thread): Likewise.
3118         (store_regs_kernel_thread): Likewise.
3119         (fetch_regs_kernel_thread): Remove shadowed variable.
3120
3121 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3122
3123         * features/riscv/32bit-cpu.xml: Add register numbers.
3124         * features/riscv/32bit-fpu.c: Regenerate.
3125         * features/riscv/32bit-fpu.xml: Add register numbers.
3126         * features/riscv/64bit-cpu.xml: Add register numbers.
3127         * features/riscv/64bit-fpu.c: Regenerate.
3128         * features/riscv/64bit-fpu.xml: Add register numbers.
3129
3130 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
3131
3132         * NEWS: Mention two argument form of gdb.Value constructor.
3133         * python/py-value.c (convert_buffer_and_type_to_value): New
3134         function.
3135         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
3136         Add support for handling an optional second argument.  Call
3137         convert_buffer_and_type_to_value as appropriate.
3138         * python/python-internal.h (Py_buffer_deleter): New struct.
3139         (Py_buffer_up): New typedef.
3140
3141 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
3142
3143         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
3144         instead of releasing ownership.
3145
3146 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
3147
3148         * dwarf2read.c (open_and_init_dwp_file): Call
3149         elf_numsections instead of bfd_count_sections to initialize
3150         dwp_file->num_sections.
3151
3152 2019-02-25  Tom Tromey  <tromey@adacore.com>
3153
3154         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
3155
3156 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3157
3158         * gcore.in: Add '--readnever' option when invoking GDB.
3159
3160 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3161
3162         * MAINTAINERS: Update my email address.
3163
3164 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3165
3166         * build-id.c (build_id_to_debug_bfd_1): New function.
3167         (build_id_to_debug_bfd): Look for separate debug file in
3168         sysroot.
3169
3170 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3171
3172         * gdbarch.sh: Update the copyright year range that is placed into
3173         generated files.
3174
3175 2019-02-22  Keith Seitz  <keiths@redhat.com>
3176
3177         PR symtab/23853
3178         * linespec.c (create_sals_line_offset): Search for the default
3179         symtab's filename instead of its fullname.
3180
3181 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3182
3183         * NEWS: Update style defaults.
3184
3185 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3186
3187         * main.c (captured_main_1): Disable styling in batch mode.
3188
3189 2019-02-20  Tom Tromey  <tom@tromey.com>
3190
3191         * symtab.c (symtab_symbol_info): Fix typos.
3192
3193 2019-02-20  Tom Tromey  <tromey@adacore.com>
3194
3195         * findcmd.c (_initialize_mem_search): Use upper case for
3196         metasyntactic variables.
3197
3198 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
3199
3200         * aarch64-tdep.c (aarch64_add_reggroups): New function.
3201         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
3202
3203 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
3204
3205         * top.h (source_file_name): Change to std::string.
3206         * top.c (source_file_name): Likewise.
3207         (command_line_input): Adjust.
3208         * cli/cli-script.c (script_from_file): Adjust.
3209
3210 2019-02-19  Tom Tromey  <tromey@adacore.com>
3211
3212         * ravenscar-thread.c
3213         (ravenscar_thread_target::update_thread_list): Don't call
3214         ada_build_task_list.
3215         * ada-lang.h (ada_build_task_list): Don't declare.
3216         * ada-tasks.c (struct ada_tasks_inferior_data)
3217         <task_list_valid_p>: Now bool.
3218         (read_known_tasks, ada_task_list_changed)
3219         (ada_tasks_invalidate_inferior_data): Update.
3220         (read_known_tasks_array): Return bool.
3221         (read_known_tasks_list): Likewise.
3222         (read_known_tasks): Return void.
3223         (ada_build_task_list): Now static.
3224
3225 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3226
3227         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
3228         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
3229
3230 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3231
3232         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
3233         variant for ada_tasks_pspace_data_handle and
3234         ada_tasks_inferior_data_handle.
3235         (ada_tasks_pspace_data_cleanup): New function.
3236         (ada_tasks_inferior_data_cleanup): New function.
3237
3238 2019-02-17  Tom Tromey  <tom@tromey.com>
3239
3240         * macrotab.h (macro_source_fullname): Return a std::string.
3241         * macrotab.c (macro_include, check_for_redefinition)
3242         (macro_undef, macro_lookup_definition, foreach_macro)
3243         (foreach_macro_in_scope): Update.
3244         (macro_source_fullname): Return a std::string.
3245         * macrocmd.c (show_pp_source_pos): Update.
3246
3247 2019-02-17  Tom Tromey  <tom@tromey.com>
3248
3249         * macrocmd.c (show_pp_source_pos): Style the file names.
3250
3251 2019-02-17  Tom Tromey  <tom@tromey.com>
3252
3253         PR tui/24197:
3254         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
3255
3256 2019-02-17  Tom Tromey  <tom@tromey.com>
3257
3258         * ada-lang.c (user_select_syms): Use filtered printing.
3259         * utils.c (wrap_style): New global.
3260         (desired_style): Remove.
3261         (emit_style_escape): Add stream parameter.
3262         (set_output_style, reset_terminal_style, prompt_for_continue):
3263         Update.
3264         (flush_wrap_buffer): Only flush gdb_stdout.
3265         (wrap_here): Set wrap_style.
3266         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
3267         treat escape sequences as a character.  Change when wrap buffer is
3268         flushed.
3269         (fputs_styled): Do not set the output style when the default is
3270         requested.
3271         * ui-style.h (struct ui_file_style) <is_default>: New method.
3272         * source.c (print_source_lines_base): Emit escape sequences in one
3273         piece.
3274
3275 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3276
3277         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
3278         integers and enumeration types.
3279
3280 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3281
3282         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
3283         instead of lookup_symbol_in_language
3284         (do_exact_match): New function.
3285         (ada_get_symbol_name_matcher): Return do_exact_match when
3286         doing a verbatim match.
3287
3288 2019-02-15  Tom Tromey  <tromey@adacore.com>
3289
3290         * ravenscar-thread.c (ravenscar_thread_target::resume)
3291         (ravenscar_thread_target::wait): Special case wildcard requests.
3292
3293 2019-02-15  Tom Tromey  <tromey@adacore.com>
3294
3295         * ravenscar-thread.c (base_ptid): Remove.
3296         (struct ravenscar_thread_target) <close>: New method.
3297         <m_base_ptid>: New member.
3298         <update_inferior_ptid, active_task, task_is_currently_active,
3299         runtime_initialized>: Declare methods.
3300         <ravenscar_thread_target>: Add constructor.
3301         (ravenscar_thread_target::task_is_currently_active)
3302         (ravenscar_thread_target::update_inferior_ptid)
3303         (ravenscar_runtime_initialized): Rename.  Now methods.
3304         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
3305         (ravenscar_thread_target::update_thread_list): Update.
3306         (ravenscar_thread_target::active_task): Now method.
3307         (ravenscar_thread_target::store_registers)
3308         (ravenscar_thread_target::prepare_to_store)
3309         (ravenscar_thread_target::prepare_to_store)
3310         (ravenscar_thread_target::mourn_inferior): Update.
3311         (ravenscar_inferior_created): Use "new" to create target.
3312         (ravenscar_thread_target::get_ada_task_ptid): Update.
3313         (_initialize_ravenscar): Don't initialize base_ptid.
3314         (ravenscar_ops): Remove global.
3315
3316 2019-02-15  Tom Tromey  <tromey@adacore.com>
3317
3318         * target.h (push_target): Declare new overload.
3319         * target.c (push_target): New overload, taking an rvalue reference.
3320         * remote.c (remote_target::open_1): Use push_target overload.
3321         * corelow.c (core_target_open): Use push_target overload.
3322
3323 2019-02-15  Tom Tromey  <tromey@adacore.com>
3324
3325         * ravenscar-thread.c (is_ravenscar_task)
3326         (ravenscar_task_is_currently_active): Return bool.
3327         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
3328         (_initialize_ravenscar): Remove "(void)".
3329         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
3330         Return bool.
3331
3332 2019-02-15  Tom Tromey  <tromey@adacore.com>
3333
3334         * ravenscar-thread.c (ravenscar_runtime_initializer)
3335         (has_ravenscar_runtime, get_running_thread_id)
3336         (ravenscar_thread_target::resume): Fix indentation.
3337
3338 2019-02-15  Tom Tromey  <tromey@adacore.com>
3339
3340         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
3341         from ravenscar_arch_ops.
3342         (sparc_ravenscar_ops::fetch_registers)
3343         (sparc_ravenscar_ops::store_registers): Now methods.
3344         (sparc_ravenscar_prepare_to_store): Remove.
3345         (sparc_ravenscar_ops): Redefine.
3346         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
3347         methods and destructor.  Remove members.
3348         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
3349         (ravenscar_thread_target::store_registers)
3350         (ravenscar_thread_target::prepare_to_store): Update.
3351         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
3352         Remove.
3353         (struct ppc_ravenscar_powerpc_ops): Derive from
3354         ravenscar_arch_ops.
3355         (ppc_ravenscar_powerpc_ops::fetch_registers)
3356         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
3357         (ppc_ravenscar_powerpc_ops): Redefine.
3358         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
3359         (ppc_ravenscar_e500_ops::fetch_registers)
3360         (ppc_ravenscar_e500_ops::store_registers): Now methods.
3361         (ppc_ravenscar_e500_ops): Redefine.
3362         * aarch64-ravenscar-thread.c
3363         (aarch64_ravenscar_generic_prepare_to_store): Remove.
3364         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
3365         (aarch64_ravenscar_fetch_registers)
3366         (aarch64_ravenscar_store_registers): Now methods.
3367         (aarch64_ravenscar_ops): Redefine.
3368
3369 2019-02-15  Tom Tromey  <tromey@adacore.com>
3370
3371         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
3372         (ravenscar_thread_target::stopped_by_hw_breakpoint)
3373         (ravenscar_thread_target::stopped_by_watchpoint)
3374         (ravenscar_thread_target::stopped_data_address)
3375         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
3376
3377 2019-02-15  Tom Tromey  <tromey@adacore.com>
3378
3379         * ravenscar-thread.c: Fix some typos.
3380
3381 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3382             Tom Tromey  <tromey@adacore.com>
3383
3384         * ada-lang.c (ada_exception_sal): Change addr_string to a
3385         std::string.
3386         (create_ada_exception_catchpoint): Update.
3387
3388 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3389             Tom Tromey  <tromey@adacore.com>
3390
3391         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
3392         (bp_location_ops): Remove.
3393         (base_breakpoint_allocate_location): Update.
3394         (free_bp_location): Update.
3395         * ada-lang.c (class ada_catchpoint_location)
3396         <ada_catchpoint_location>: Remove ops parameter.
3397         (ada_catchpoint_location_dtor): Remove.
3398         (ada_catchpoint_location_ops): Remove.
3399         (allocate_location_exception): Update.
3400         * breakpoint.h (struct bp_location_ops): Remove.
3401         (class bp_location) <bp_location>: Remove bp_location_ops
3402         parameter.
3403         <~bp_location>: Add destructor.
3404         <ops>: Remove.
3405
3406 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3407             Pedro Alves  <palves@redhat.com>
3408
3409         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
3410         'PATH_MAX'.
3411
3412 2019-02-14  David Michael  <fedora.dm0@gmail.com>
3413             Samuel Thibault  <samuel.thibault@gnu.org>
3414             Thomas Schwinge  <thomas@codesourcery.com>
3415
3416         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
3417         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
3418
3419 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3420
3421         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
3422         (check_empty): Use "const char *".
3423
3424         * gnu-nat.c (gnu_nat_target::detach): Instead of
3425         'detach_inferior (pid)' call
3426         'detach_inferior (find_inferior_pid (pid))'.
3427
3428         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
3429         'nat/fork-inferior.o'.
3430         * gnu-nat.c: #include "nat/fork-inferior.h".
3431
3432         * gnu-nat.c (gnu_nat_target::detach): Instead of
3433         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
3434         * gnu-nat.h: #include "inf-child.h".
3435         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
3436         'i386_gnu_nat_target::fetch_registers'.
3437         (gnu_store_registers): Rename/move to
3438         'i386_gnu_nat_target::store_registers'.
3439
3440         * config/i386/nm-i386gnu.h: Don't "#include" any files.
3441         * gnu-nat.h (mach_thread_info): New function.
3442         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
3443
3444         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
3445
3446 2019-02-14  Frederic Konrad  <konrad@adacore.com>
3447
3448         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
3449
3450 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
3451
3452         * windows-nat.c (windows_add_thread): Add new parameter
3453         "main_thread_p" with default value set to false.  Update
3454         function documentation as well as all callers.
3455         (windows_delete_thread): Likewise.
3456         (fake_create_process): Update call to windows_add_thread.
3457         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
3458         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
3459         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
3460         call to windows_delete_thread.
3461
3462 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
3463
3464         * MAINTAINERS: Add Andrew Burgess as global maintainer.
3465
3466 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3467
3468         * symfile.c (find_separate_debug_file): Use canonical path of
3469         sysroot with child_path instead of gdb_sysroot if it is valid.
3470
3471 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3472
3473         * symfile.c (find_separate_debug_file): Use child_path to
3474         determine if an object file is under a sysroot.
3475
3476 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3477
3478         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
3479         unittests/child-path-selftests.c.
3480         * common/pathstuff.c (child_path): New function.
3481         * common/pathstuff.h (child_path): New prototype.
3482         * unittests/child-path-selftests.c: New file.
3483
3484 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3485
3486         * symfile.c (find_separate_debug_file): Look for separate debug
3487         files in debug directories under the sysroot.
3488
3489 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3490
3491         * symtab.h (struct minimal_symbol data_p): New const method.
3492         (struct minimal_symbol text_p): Likewise.
3493         * symtab.c (output_source_filename): Use file name style
3494         to print file name.
3495         (print_symbol_info): Likewise.
3496         (print_msymbol_info): Use address style to print addresses.
3497         Use function name style to print executable text symbols.
3498         (expand_symtab_containing_pc): Use data_p.
3499         (find_pc_sect_compunit_symtab): Likewise.
3500
3501 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3502
3503         * breakpoint.c (describe_other_breakpoints): Use address style
3504         to print addresses.
3505         (say_where): Likewise.
3506
3507 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3508
3509         * ada-typeprint.c (print_func_type): Print function name
3510         style to print function name.
3511         * c-typeprint.c (c_print_type_1): Likewise.
3512
3513 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
3514
3515         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
3516         for execve.
3517
3518 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3519
3520         * c-exp.y (direct_abs_decl): Use emplace_back to record the
3521         type_stack.
3522
3523 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
3524
3525         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
3526         TYPE_CODE_REF types.
3527
3528 2019-02-08  Jim Wilson  <jimw@sifive.com>
3529
3530         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
3531         (riscv_linux_fregset): New.
3532         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
3533
3534 2019-02-07  Tom Tromey  <tom@tromey.com>
3535
3536         * thread.c (thread_cancel_execution_command): Update.
3537         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
3538         methods.
3539         (struct thread_fsm_ops): Remove.
3540         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
3541         (thread_fsm_should_stop, thread_fsm_return_value)
3542         (thread_fsm_set_finished, thread_fsm_finished_p)
3543         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
3544         Don't declare.
3545         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
3546         * infrun.c (clear_proceed_status_thread)
3547         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
3548         (print_stop_event): Update.
3549         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
3550         Add constructor.
3551         (step_command_fsm_ops): Remove.
3552         (new_step_command_fsm): Remove.
3553         (step_1): Update.
3554         (step_command_fsm::should_stop): Rename from
3555         step_command_fsm_should_stop.
3556         (step_command_fsm::clean_up): Rename from
3557         step_command_fsm_clean_up.
3558         (step_command_fsm::do_async_reply_reason): Rename from
3559         step_command_fsm_async_reply_reason.
3560         (struct until_next_fsm): Inherit from thread_fsm.  Add
3561         constructor.
3562         (until_next_fsm_ops): Remove.
3563         (new_until_next_fsm): Remove.
3564         (until_next_fsm::should_stop): Rename from
3565         until_next_fsm_should_stop.
3566         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
3567         (until_next_fsm::do_async_reply_reason): Rename from
3568         until_next_fsm_async_reply_reason.
3569         (struct finish_command_fsm): Inherit from thread_fsm.  Add
3570         constructor.  Change type of breakpoint.
3571         (finish_command_fsm_ops): Remove.
3572         (new_finish_command_fsm): Remove.
3573         (finish_command_fsm::should_stop): Rename from
3574         finish_command_fsm_should_stop.
3575         (finish_command_fsm::clean_up): Rename from
3576         finish_command_fsm_clean_up.
3577         (finish_command_fsm::return_value): Rename from
3578         finish_command_fsm_return_value.
3579         (finish_command_fsm::do_async_reply_reason): Rename from
3580         finish_command_fsm_async_reply_reason.
3581         (finish_command): Update.
3582         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
3583         Add constructor.
3584         (call_thread_fsm_ops): Remove.
3585         (call_thread_fsm::call_thread_fsm): Rename from
3586         new_call_thread_fsm.
3587         (call_thread_fsm::should_stop): Rename from
3588         call_thread_fsm_should_stop.
3589         (call_thread_fsm::should_notify_stop): Rename from
3590         call_thread_fsm_should_notify_stop.
3591         (run_inferior_call, call_function_by_hand_dummy): Update.
3592         * cli/cli-interp.c (should_print_stop_to_console): Update.
3593         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
3594         Add constructor.  Change type of location_breakpoint,
3595         caller_breakpoint.
3596         (until_break_fsm_ops): Remove.
3597         (new_until_break_fsm): Remove.
3598         (until_break_fsm::should_stop): Rename from
3599         until_break_fsm_should_stop.
3600         (until_break_fsm::clean_up): Rename from
3601         until_break_fsm_clean_up.
3602         (until_break_fsm::do_async_reply_reason): Rename from
3603         until_break_fsm_async_reply_reason.
3604         (until_break_command): Update.
3605         * thread-fsm.c: Remove.
3606         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
3607
3608 2019-02-07  Tom Tromey  <tom@tromey.com>
3609
3610         * yy-remap.h: Add include guard.
3611         * xtensa-tdep.h: Add include guard.
3612         * xcoffread.h: Rename include guard.
3613         * varobj-iter.h: Add include guard.
3614         * tui/tui.h: Rename include guard.
3615         * tui/tui-winsource.h: Rename include guard.
3616         * tui/tui-wingeneral.h: Rename include guard.
3617         * tui/tui-windata.h: Rename include guard.
3618         * tui/tui-win.h: Rename include guard.
3619         * tui/tui-stack.h: Rename include guard.
3620         * tui/tui-source.h: Rename include guard.
3621         * tui/tui-regs.h: Rename include guard.
3622         * tui/tui-out.h: Rename include guard.
3623         * tui/tui-layout.h: Rename include guard.
3624         * tui/tui-io.h: Rename include guard.
3625         * tui/tui-hooks.h: Rename include guard.
3626         * tui/tui-file.h: Rename include guard.
3627         * tui/tui-disasm.h: Rename include guard.
3628         * tui/tui-data.h: Rename include guard.
3629         * tui/tui-command.h: Rename include guard.
3630         * tic6x-tdep.h: Add include guard.
3631         * target/waitstatus.h: Rename include guard.
3632         * target/wait.h: Rename include guard.
3633         * target/target.h: Rename include guard.
3634         * target/resume.h: Rename include guard.
3635         * target-float.h: Rename include guard.
3636         * stabsread.h: Add include guard.
3637         * rs6000-tdep.h: Add include guard.
3638         * riscv-fbsd-tdep.h: Add include guard.
3639         * regformats/regdef.h: Rename include guard.
3640         * record.h: Rename include guard.
3641         * python/python.h: Rename include guard.
3642         * python/python-internal.h: Rename include guard.
3643         * python/py-stopevent.h: Rename include guard.
3644         * python/py-ref.h: Rename include guard.
3645         * python/py-record.h: Rename include guard.
3646         * python/py-record-full.h: Rename include guard.
3647         * python/py-record-btrace.h: Rename include guard.
3648         * python/py-instruction.h: Rename include guard.
3649         * python/py-events.h: Rename include guard.
3650         * python/py-event.h: Rename include guard.
3651         * procfs.h: Add include guard.
3652         * proc-utils.h: Add include guard.
3653         * p-lang.h: Add include guard.
3654         * or1k-tdep.h: Rename include guard.
3655         * observable.h: Rename include guard.
3656         * nto-tdep.h: Rename include guard.
3657         * nat/x86-linux.h: Rename include guard.
3658         * nat/x86-linux-dregs.h: Rename include guard.
3659         * nat/x86-gcc-cpuid.h: Add include guard.
3660         * nat/x86-dregs.h: Rename include guard.
3661         * nat/x86-cpuid.h: Rename include guard.
3662         * nat/ppc-linux.h: Rename include guard.
3663         * nat/mips-linux-watch.h: Rename include guard.
3664         * nat/linux-waitpid.h: Rename include guard.
3665         * nat/linux-ptrace.h: Rename include guard.
3666         * nat/linux-procfs.h: Rename include guard.
3667         * nat/linux-osdata.h: Rename include guard.
3668         * nat/linux-nat.h: Rename include guard.
3669         * nat/linux-namespaces.h: Rename include guard.
3670         * nat/linux-btrace.h: Rename include guard.
3671         * nat/glibc_thread_db.h: Rename include guard.
3672         * nat/gdb_thread_db.h: Rename include guard.
3673         * nat/gdb_ptrace.h: Rename include guard.
3674         * nat/fork-inferior.h: Rename include guard.
3675         * nat/amd64-linux-siginfo.h: Rename include guard.
3676         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
3677         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
3678         * nat/aarch64-linux.h: Rename include guard.
3679         * nat/aarch64-linux-hw-point.h: Rename include guard.
3680         * mn10300-tdep.h: Add include guard.
3681         * mips-linux-tdep.h: Add include guard.
3682         * mi/mi-parse.h: Rename include guard.
3683         * mi/mi-out.h: Rename include guard.
3684         * mi/mi-main.h: Rename include guard.
3685         * mi/mi-interp.h: Rename include guard.
3686         * mi/mi-getopt.h: Rename include guard.
3687         * mi/mi-console.h: Rename include guard.
3688         * mi/mi-common.h: Rename include guard.
3689         * mi/mi-cmds.h: Rename include guard.
3690         * mi/mi-cmd-break.h: Rename include guard.
3691         * m2-lang.h: Add include guard.
3692         * location.h: Rename include guard.
3693         * linux-record.h: Rename include guard.
3694         * linux-nat.h: Add include guard.
3695         * linux-fork.h: Add include guard.
3696         * i386-darwin-tdep.h: Rename include guard.
3697         * hppa-linux-offsets.h: Add include guard.
3698         * guile/guile.h: Rename include guard.
3699         * guile/guile-internal.h: Rename include guard.
3700         * gnu-nat.h: Rename include guard.
3701         * gdb-stabs.h: Rename include guard.
3702         * frv-tdep.h: Add include guard.
3703         * f-lang.h: Add include guard.
3704         * event-loop.h: Add include guard.
3705         * darwin-nat.h: Rename include guard.
3706         * cp-abi.h: Rename include guard.
3707         * config/sparc/nm-sol2.h: Rename include guard.
3708         * config/nm-nto.h: Rename include guard.
3709         * config/nm-linux.h: Add include guard.
3710         * config/i386/nm-i386gnu.h: Rename include guard.
3711         * config/djgpp/nl_types.h: Rename include guard.
3712         * config/djgpp/langinfo.h: Rename include guard.
3713         * compile/gcc-cp-plugin.h: Add include guard.
3714         * compile/gcc-c-plugin.h: Add include guard.
3715         * compile/compile.h: Rename include guard.
3716         * compile/compile-object-run.h: Rename include guard.
3717         * compile/compile-object-load.h: Rename include guard.
3718         * compile/compile-internal.h: Rename include guard.
3719         * compile/compile-cplus.h: Rename include guard.
3720         * compile/compile-c.h: Rename include guard.
3721         * common/xml-utils.h: Rename include guard.
3722         * common/x86-xstate.h: Rename include guard.
3723         * common/version.h: Rename include guard.
3724         * common/vec.h: Rename include guard.
3725         * common/tdesc.h: Rename include guard.
3726         * common/selftest.h: Rename include guard.
3727         * common/scoped_restore.h: Rename include guard.
3728         * common/scoped_mmap.h: Rename include guard.
3729         * common/scoped_fd.h: Rename include guard.
3730         * common/safe-iterator.h: Rename include guard.
3731         * common/run-time-clock.h: Rename include guard.
3732         * common/refcounted-object.h: Rename include guard.
3733         * common/queue.h: Rename include guard.
3734         * common/ptid.h: Rename include guard.
3735         * common/print-utils.h: Rename include guard.
3736         * common/preprocessor.h: Rename include guard.
3737         * common/pathstuff.h: Rename include guard.
3738         * common/observable.h: Rename include guard.
3739         * common/netstuff.h: Rename include guard.
3740         * common/job-control.h: Rename include guard.
3741         * common/host-defs.h: Rename include guard.
3742         * common/gdb_wait.h: Rename include guard.
3743         * common/gdb_vecs.h: Rename include guard.
3744         * common/gdb_unlinker.h: Rename include guard.
3745         * common/gdb_unique_ptr.h: Rename include guard.
3746         * common/gdb_tilde_expand.h: Rename include guard.
3747         * common/gdb_sys_time.h: Rename include guard.
3748         * common/gdb_string_view.h: Rename include guard.
3749         * common/gdb_splay_tree.h: Rename include guard.
3750         * common/gdb_setjmp.h: Rename include guard.
3751         * common/gdb_ref_ptr.h: Rename include guard.
3752         * common/gdb_optional.h: Rename include guard.
3753         * common/gdb_locale.h: Rename include guard.
3754         * common/gdb_assert.h: Rename include guard.
3755         * common/filtered-iterator.h: Rename include guard.
3756         * common/filestuff.h: Rename include guard.
3757         * common/fileio.h: Rename include guard.
3758         * common/environ.h: Rename include guard.
3759         * common/common-utils.h: Rename include guard.
3760         * common/common-types.h: Rename include guard.
3761         * common/common-regcache.h: Rename include guard.
3762         * common/common-inferior.h: Rename include guard.
3763         * common/common-gdbthread.h: Rename include guard.
3764         * common/common-exceptions.h: Rename include guard.
3765         * common/common-defs.h: Rename include guard.
3766         * common/common-debug.h: Rename include guard.
3767         * common/cleanups.h: Rename include guard.
3768         * common/buffer.h: Rename include guard.
3769         * common/btrace-common.h: Rename include guard.
3770         * common/break-common.h: Rename include guard.
3771         * cli/cli-utils.h: Rename include guard.
3772         * cli/cli-style.h: Rename include guard.
3773         * cli/cli-setshow.h: Rename include guard.
3774         * cli/cli-script.h: Rename include guard.
3775         * cli/cli-interp.h: Rename include guard.
3776         * cli/cli-decode.h: Rename include guard.
3777         * cli/cli-cmds.h: Rename include guard.
3778         * charset-list.h: Add include guard.
3779         * buildsym-legacy.h: Rename include guard.
3780         * bfin-tdep.h: Add include guard.
3781         * ax.h: Rename include guard.
3782         * arm-linux-tdep.h: Add include guard.
3783         * arm-fbsd-tdep.h: Add include guard.
3784         * arch/xtensa.h: Rename include guard.
3785         * arch/tic6x.h: Add include guard.
3786         * arch/i386.h: Add include guard.
3787         * arch/arm.h: Rename include guard.
3788         * arch/arm-linux.h: Rename include guard.
3789         * arch/arm-get-next-pcs.h: Rename include guard.
3790         * arch/amd64.h: Add include guard.
3791         * arch/aarch64-insn.h: Rename include guard.
3792         * arch-utils.h: Rename include guard.
3793         * annotate.h: Add include guard.
3794         * amd64-darwin-tdep.h: Rename include guard.
3795         * aarch64-linux-tdep.h: Add include guard.
3796         * aarch64-fbsd-tdep.h: Add include guard.
3797         * aarch32-linux-nat.h: Add include guard.
3798
3799 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3800
3801         * macrotab.c (macro_define_internal): New function that
3802         factorizes macro_define_object_internal and macro_define_function
3803         code.
3804         (macro_define_object_internal): Use macro_define_internal.
3805         (macro_define_function): Likewise.
3806
3807 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3808
3809         * macrocmd.c (extract_identifier): Return
3810         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
3811         callers.
3812
3813 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
3814
3815         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
3816
3817 2019-02-05  Tom Tromey  <tom@tromey.com>
3818
3819         * target.c (target_stack::unpush): Move assertion earlier.
3820
3821 2019-01-30  Tom Tromey  <tom@tromey.com>
3822
3823         PR python/23615:
3824         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
3825         (gdbpy_parse_and_eval): Likewise.
3826         * python/python-internal.h (gdbpy_allow_threads): New class.
3827
3828 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
3829
3830         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
3831         (aarch64_fbsd_fpregmap): Move earlier.
3832         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
3833         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3834         instead of individual calls to trad_frame_set_reg_addr.
3835         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
3836         earlier.
3837         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
3838         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3839         instead of individual calls to trad_frame_set_reg_addr.
3840
3841 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
3842
3843         * CONTRIBUTE: Replace contribution list with wiki link.
3844
3845 2019-01-25  Tom Tromey  <tom@tromey.com>
3846
3847         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
3848
3849 2019-01-25  Tom Tromey  <tom@tromey.com>
3850
3851         * xtensa-linux-nat.c: Fix common/ includes.
3852         * xml-support.h: Fix common/ includes.
3853         * xml-support.c: Fix common/ includes.
3854         * x86-linux-nat.c: Fix common/ includes.
3855         * windows-nat.c: Fix common/ includes.
3856         * varobj.h: Fix common/ includes.
3857         * varobj.c: Fix common/ includes.
3858         * value.c: Fix common/ includes.
3859         * valops.c: Fix common/ includes.
3860         * utils.c: Fix common/ includes.
3861         * unittests/xml-utils-selftests.c: Fix common/ includes.
3862         * unittests/utils-selftests.c: Fix common/ includes.
3863         * unittests/unpack-selftests.c: Fix common/ includes.
3864         * unittests/tracepoint-selftests.c: Fix common/ includes.
3865         * unittests/style-selftests.c: Fix common/ includes.
3866         * unittests/string_view-selftests.c: Fix common/ includes.
3867         * unittests/scoped_restore-selftests.c: Fix common/ includes.
3868         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
3869         * unittests/scoped_fd-selftests.c: Fix common/ includes.
3870         * unittests/rsp-low-selftests.c: Fix common/ includes.
3871         * unittests/parse-connection-spec-selftests.c: Fix common/
3872         includes.
3873         * unittests/optional-selftests.c: Fix common/ includes.
3874         * unittests/offset-type-selftests.c: Fix common/ includes.
3875         * unittests/observable-selftests.c: Fix common/ includes.
3876         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
3877         * unittests/memrange-selftests.c: Fix common/ includes.
3878         * unittests/memory-map-selftests.c: Fix common/ includes.
3879         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
3880         * unittests/function-view-selftests.c: Fix common/ includes.
3881         * unittests/environ-selftests.c: Fix common/ includes.
3882         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
3883         * unittests/common-utils-selftests.c: Fix common/ includes.
3884         * unittests/cli-utils-selftests.c: Fix common/ includes.
3885         * unittests/array-view-selftests.c: Fix common/ includes.
3886         * ui-file.c: Fix common/ includes.
3887         * tui/tui-io.c: Fix common/ includes.
3888         * tracepoint.h: Fix common/ includes.
3889         * tracepoint.c: Fix common/ includes.
3890         * tracefile-tfile.c: Fix common/ includes.
3891         * top.h: Fix common/ includes.
3892         * top.c: Fix common/ includes.
3893         * thread.c: Fix common/ includes.
3894         * target/waitstatus.h: Fix common/ includes.
3895         * target/waitstatus.c: Fix common/ includes.
3896         * target.h: Fix common/ includes.
3897         * target.c: Fix common/ includes.
3898         * target-memory.c: Fix common/ includes.
3899         * target-descriptions.c: Fix common/ includes.
3900         * symtab.h: Fix common/ includes.
3901         * symfile.c: Fix common/ includes.
3902         * stap-probe.c: Fix common/ includes.
3903         * spu-linux-nat.c: Fix common/ includes.
3904         * sparc-nat.c: Fix common/ includes.
3905         * source.c: Fix common/ includes.
3906         * solib.c: Fix common/ includes.
3907         * solib-target.c: Fix common/ includes.
3908         * ser-unix.c: Fix common/ includes.
3909         * ser-tcp.c: Fix common/ includes.
3910         * ser-pipe.c: Fix common/ includes.
3911         * ser-base.c: Fix common/ includes.
3912         * selftest-arch.c: Fix common/ includes.
3913         * s12z-tdep.c: Fix common/ includes.
3914         * rust-exp.y: Fix common/ includes.
3915         * rs6000-aix-tdep.c: Fix common/ includes.
3916         * riscv-tdep.c: Fix common/ includes.
3917         * remote.c: Fix common/ includes.
3918         * remote-notif.h: Fix common/ includes.
3919         * remote-fileio.h: Fix common/ includes.
3920         * remote-fileio.c: Fix common/ includes.
3921         * regcache.h: Fix common/ includes.
3922         * regcache.c: Fix common/ includes.
3923         * record-btrace.c: Fix common/ includes.
3924         * python/python.c: Fix common/ includes.
3925         * python/py-type.c: Fix common/ includes.
3926         * python/py-inferior.c: Fix common/ includes.
3927         * progspace.h: Fix common/ includes.
3928         * producer.c: Fix common/ includes.
3929         * procfs.c: Fix common/ includes.
3930         * proc-api.c: Fix common/ includes.
3931         * printcmd.c: Fix common/ includes.
3932         * ppc-linux-nat.c: Fix common/ includes.
3933         * parser-defs.h: Fix common/ includes.
3934         * osdata.c: Fix common/ includes.
3935         * obsd-nat.c: Fix common/ includes.
3936         * nat/x86-linux.c: Fix common/ includes.
3937         * nat/x86-linux-dregs.c: Fix common/ includes.
3938         * nat/x86-dregs.h: Fix common/ includes.
3939         * nat/x86-dregs.c: Fix common/ includes.
3940         * nat/ppc-linux.c: Fix common/ includes.
3941         * nat/mips-linux-watch.h: Fix common/ includes.
3942         * nat/mips-linux-watch.c: Fix common/ includes.
3943         * nat/linux-waitpid.c: Fix common/ includes.
3944         * nat/linux-ptrace.h: Fix common/ includes.
3945         * nat/linux-ptrace.c: Fix common/ includes.
3946         * nat/linux-procfs.c: Fix common/ includes.
3947         * nat/linux-personality.c: Fix common/ includes.
3948         * nat/linux-osdata.c: Fix common/ includes.
3949         * nat/linux-namespaces.c: Fix common/ includes.
3950         * nat/linux-btrace.h: Fix common/ includes.
3951         * nat/linux-btrace.c: Fix common/ includes.
3952         * nat/fork-inferior.c: Fix common/ includes.
3953         * nat/amd64-linux-siginfo.c: Fix common/ includes.
3954         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
3955         * nat/aarch64-linux.c: Fix common/ includes.
3956         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
3957         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
3958         * namespace.h: Fix common/ includes.
3959         * mips-linux-tdep.c: Fix common/ includes.
3960         * minsyms.c: Fix common/ includes.
3961         * mi/mi-parse.h: Fix common/ includes.
3962         * mi/mi-main.c: Fix common/ includes.
3963         * mi/mi-cmd-env.c: Fix common/ includes.
3964         * memrange.h: Fix common/ includes.
3965         * memattr.c: Fix common/ includes.
3966         * maint.h: Fix common/ includes.
3967         * maint.c: Fix common/ includes.
3968         * main.c: Fix common/ includes.
3969         * machoread.c: Fix common/ includes.
3970         * location.c: Fix common/ includes.
3971         * linux-thread-db.c: Fix common/ includes.
3972         * linux-nat.c: Fix common/ includes.
3973         * linux-fork.c: Fix common/ includes.
3974         * inline-frame.c: Fix common/ includes.
3975         * infrun.c: Fix common/ includes.
3976         * inflow.c: Fix common/ includes.
3977         * inferior.h: Fix common/ includes.
3978         * inferior.c: Fix common/ includes.
3979         * infcmd.c: Fix common/ includes.
3980         * inf-ptrace.c: Fix common/ includes.
3981         * inf-child.c: Fix common/ includes.
3982         * ia64-linux-nat.c: Fix common/ includes.
3983         * i387-tdep.c: Fix common/ includes.
3984         * i386-tdep.c: Fix common/ includes.
3985         * i386-linux-tdep.c: Fix common/ includes.
3986         * i386-linux-nat.c: Fix common/ includes.
3987         * i386-go32-tdep.c: Fix common/ includes.
3988         * i386-fbsd-tdep.c: Fix common/ includes.
3989         * i386-fbsd-nat.c: Fix common/ includes.
3990         * guile/scm-type.c: Fix common/ includes.
3991         * guile/guile.c: Fix common/ includes.
3992         * go32-nat.c: Fix common/ includes.
3993         * gnu-nat.c: Fix common/ includes.
3994         * gdbthread.h: Fix common/ includes.
3995         * gdbarch-selftests.c: Fix common/ includes.
3996         * gdb_usleep.c: Fix common/ includes.
3997         * gdb_select.h: Fix common/ includes.
3998         * gdb_bfd.c: Fix common/ includes.
3999         * gcore.c: Fix common/ includes.
4000         * fork-child.c: Fix common/ includes.
4001         * findvar.c: Fix common/ includes.
4002         * fbsd-nat.c: Fix common/ includes.
4003         * event-top.c: Fix common/ includes.
4004         * event-loop.c: Fix common/ includes.
4005         * dwarf2read.c: Fix common/ includes.
4006         * dwarf2loc.c: Fix common/ includes.
4007         * dwarf2-frame.c: Fix common/ includes.
4008         * dwarf-index-cache.c: Fix common/ includes.
4009         * dtrace-probe.c: Fix common/ includes.
4010         * disasm-selftests.c: Fix common/ includes.
4011         * defs.h: Fix common/ includes.
4012         * csky-tdep.c: Fix common/ includes.
4013         * cp-valprint.c: Fix common/ includes.
4014         * cp-support.h: Fix common/ includes.
4015         * cp-support.c: Fix common/ includes.
4016         * corelow.c: Fix common/ includes.
4017         * completer.h: Fix common/ includes.
4018         * completer.c: Fix common/ includes.
4019         * compile/compile.c: Fix common/ includes.
4020         * compile/compile-loc2c.c: Fix common/ includes.
4021         * compile/compile-cplus-types.c: Fix common/ includes.
4022         * compile/compile-cplus-symbols.c: Fix common/ includes.
4023         * command.h: Fix common/ includes.
4024         * cli/cli-dump.c: Fix common/ includes.
4025         * cli/cli-cmds.c: Fix common/ includes.
4026         * charset.c: Fix common/ includes.
4027         * build-id.c: Fix common/ includes.
4028         * btrace.h: Fix common/ includes.
4029         * btrace.c: Fix common/ includes.
4030         * breakpoint.h: Fix common/ includes.
4031         * breakpoint.c: Fix common/ includes.
4032         * ax.h: 
4033         (enum agent_op): Fix common/ includes.
4034         * ax-general.c (struct aop_map): Fix common/ includes.
4035         * ax-gdb.c: Fix common/ includes.
4036         * auxv.c: Fix common/ includes.
4037         * auto-load.c: Fix common/ includes.
4038         * arm-tdep.c: Fix common/ includes.
4039         * arch/riscv.c: Fix common/ includes.
4040         * arch/ppc-linux-common.c: Fix common/ includes.
4041         * arch/i386.c: Fix common/ includes.
4042         * arch/arm.c: Fix common/ includes.
4043         * arch/arm-linux.c: Fix common/ includes.
4044         * arch/arm-get-next-pcs.c: Fix common/ includes.
4045         * arch/amd64.c: Fix common/ includes.
4046         * arch/aarch64.c: Fix common/ includes.
4047         * arch/aarch64-insn.c: Fix common/ includes.
4048         * arch-utils.c: Fix common/ includes.
4049         * amd64-windows-tdep.c: Fix common/ includes.
4050         * amd64-tdep.c: Fix common/ includes.
4051         * amd64-sol2-tdep.c: Fix common/ includes.
4052         * amd64-obsd-tdep.c: Fix common/ includes.
4053         * amd64-nbsd-tdep.c: Fix common/ includes.
4054         * amd64-linux-tdep.c: Fix common/ includes.
4055         * amd64-linux-nat.c: Fix common/ includes.
4056         * amd64-fbsd-tdep.c: Fix common/ includes.
4057         * amd64-fbsd-nat.c: Fix common/ includes.
4058         * amd64-dicos-tdep.c: Fix common/ includes.
4059         * amd64-darwin-tdep.c: Fix common/ includes.
4060         * agent.c: Fix common/ includes.
4061         * ada-lang.h: Fix common/ includes.
4062         * ada-lang.c: Fix common/ includes.
4063         * aarch64-tdep.c: Fix common/ includes.
4064
4065 2019-01-25  Tom Tromey  <tom@tromey.com>
4066
4067         * common/create-version.sh: Use common/version.h.
4068
4069 2019-01-24  Pedro Alves  <palves@redhat.com>
4070
4071         * infrun.c (signal_stop, signal_print, signal_program)
4072         (signal_catch, signal_pass): Now arrays instead of pointers.
4073         (update_signals_program_target, do_target_resume)
4074         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
4075         * linux-nat.c (linux_nat_target::pass_signals)
4076         (linux_nat_target::create_inferior, linux_nat_target::attach):
4077         Adjust.
4078         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
4079         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
4080         * procfs.c (procfs_target::pass_signals): Adjust.
4081         * record-full.c (record_full_target::resume): Adjust.
4082         * remote.c (remote_target::pass_signals)
4083         (remote_target::program_signals): Adjust.
4084         * target-debug.h (target_debug_print_signals): Now takes a
4085         gdb::array_view as parameter.  Adjust.
4086         * target.h (target_ops) <pass_signals, program_signals>: Replace
4087         pointer and length parameters with gdb::array_view.
4088         (target_pass_signals, target_program_signals): Likewise.
4089         * target-delegates.c: Regenerate.
4090
4091 2019-01-24  Pedro Alves  <palves@redhat.com>
4092
4093         * common/forward-scope-exit.h
4094         (forward_scope_exit::forward_scope_exit): Pass arguments to
4095         m_bind_function directly, instead of creating a std::bind and
4096         copying that.
4097
4098 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
4099
4100         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4101         for static members.
4102         (pass_in_v_vfp_candidate): Likewise.
4103
4104 2019-01-23  Tom Tromey  <tom@tromey.com>
4105             Pedro Alves  <palves@redhat.com>
4106
4107         * regcache.c (class regcache_invalidator): Remove.
4108         (regcache::raw_write): Use make_scope_exit.
4109
4110 2019-01-23  Tom Tromey  <tom@tromey.com>
4111
4112         * ui-out.h (class ui_out_emit_type): Update comment.
4113
4114 2019-01-23  Tom Tromey  <tom@tromey.com>
4115
4116         * infrun.c (fetch_inferior_event): Update comment.
4117
4118 2019-01-23  Tom Tromey  <tom@tromey.com>
4119             Pedro Alves  <palves@redhat.com>
4120
4121         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
4122         parameter.
4123         (fetch_inferior_event): Use SCOPE_EXIT.
4124
4125
4126 2019-01-23  Tom Tromey  <tom@tromey.com>
4127             Pedro Alves  <palves@redhat.com>
4128
4129         * infrun.c (disable_thread_events): Delete.
4130         (stop_all_threads): Use SCOPE_EXIT.
4131
4132 2019-01-23  Tom Tromey  <tom@tromey.com>
4133             Pedro Alves  <palves@redhat.com>
4134
4135         * symfile.c: Include forward-scope-exit.h.
4136         (clear_symtab_users_cleanup): Replace forward declaration with
4137         a FORWARD_SCOPE_EXIT.
4138         (syms_from_objfile_1): Use the forward_scope_exit and
4139         gdb::optional instead of cleanup_function.
4140         (reread_symbols): Use the forward_scope_exit instead of
4141         cleanup_function.
4142         (clear_symtab_users_cleanup): Remove function.
4143
4144 2019-01-23  Tom Tromey  <tom@tromey.com>
4145             Pedro Alves  <palves@redhat.com>
4146
4147         * linux-nat.c: Include scope-exit.h.
4148         (cleanup_target_stop): Remove.
4149         (linux_nat_target::static_tracepoint_markers_by_strid): Use
4150         SCOPE_EXIT.
4151
4152 2019-01-23  Tom Tromey  <tom@tromey.com>
4153             Pedro Alves  <palves@redhat.com>
4154
4155         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
4156         (call_function_by_hand_dummy): Use SCOPE_EXIT.
4157
4158 2019-01-23  Tom Tromey  <tom@tromey.com>
4159             Andrew Burgess  <andrew.burgess@embecosm.com>
4160             Pedro Alves  <palves@redhat.com>
4161
4162         * infrun.c (fetch_inferior_event): Use scope_exit.
4163         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
4164         * top.c (execute_command): Use scope_exit.
4165         * breakpoint.c (bpstat_do_actions): Use scope_exit.
4166         * utils.c (do_bpstat_clear_actions_cleanup)
4167         (make_bpstat_clear_actions_cleanup): Remove.
4168
4169 2019-01-23  Tom Tromey  <tom@tromey.com>
4170             Pedro Alves  <palves@redhat.com>
4171
4172         * infrun.c: Include "common/scope-exit.h"
4173         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
4174         (wait_for_inferior): Use SCOPE_EXIT.
4175         (fetch_inferior_event): Use scope_exit.
4176
4177 2019-01-23  Tom Tromey  <tom@tromey.com>
4178             Pedro Alves  <palves@redhat.com>
4179
4180         * breakpoint.c (create_breakpoint): Remove cleanup.
4181
4182 2019-01-23  Tom Tromey  <tom@tromey.com>
4183             Andrew Burgess  <andrew.burgess@embecosm.com>
4184             Pedro Alves  <palves@redhat.com>
4185
4186 2019-01-23  Pedro Alves  <palves@redhat.com>
4187
4188         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
4189
4190 2019-01-23  Pedro Alves  <palves@redhat.com>
4191             Andrew Burgess  <andrew.burgess@embecosm.com>
4192
4193         * gdbthread.h: Include "common/forward-scope-exit.h".
4194         (scoped_finish_thread_state): Redefine custom class in terms of
4195         forward_scope_exit.
4196
4197 2019-01-23  Pedro Alves  <palves@redhat.com>
4198             Andrew Burgess  <andrew.burgess@embecosm.com>
4199
4200         * common/forward-scope-exit.h: New file.
4201
4202 2019-01-23  Pedro Alves  <palves@redhat.com>
4203             Andrew Burgess  <andrew.burgess@embecosm.com>
4204             Tom Tromey  <tom@tromey.com>
4205
4206         * common/scope-exit.h: New file.
4207
4208 2019-01-23  Pedro Alves  <palves@redhat.com>
4209
4210         * common/preprocessor.h (ESC): Rename to ...
4211         (ESC_PARENS): ... this.
4212         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
4213         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
4214
4215 2019-01-23  Tom Tromey  <tom@tromey.com>
4216
4217         * language.h (class scoped_switch_to_sym_language_if_auto):
4218         Initialize m_lang in both cases.
4219
4220 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
4221
4222         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
4223         with XCNEW.
4224
4225 2019-01-22  Tom Tromey  <tom@tromey.com>
4226
4227         * corelow.c: Do not include sys/file.h.
4228
4229 2019-01-22  Tom Tromey  <tom@tromey.com>
4230
4231         * tui/tui-wingeneral.h: Include gdb_curses.h.
4232
4233 2019-01-22  Tom Tromey  <tom@tromey.com>
4234
4235         * source-cache.h (class source_cache) <get_source_lines,
4236         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
4237
4238 2019-01-22  Tom Tromey  <tom@tromey.com>
4239
4240         * remote-fileio.h (struct remote_target): Declare.
4241
4242 2019-01-22  Tom Tromey  <tom@tromey.com>
4243
4244         * python/py-arch.c: Do not include py-ref.h.
4245         * python/py-bpevent.c: Do not include py-ref.h.
4246         * python/py-cmd.c: Do not include py-ref.h.
4247         * python/py-continueevent.c: Do not include py-ref.h.
4248         * python/py-event.h: Do not include py-ref.h.
4249         * python/py-evtregistry.c: Do not include py-ref.h.
4250         * python/py-finishbreakpoint.c: Do not include py-ref.h.
4251         * python/py-frame.c: Do not include py-ref.h.
4252         * python/py-framefilter.c: Do not include py-ref.h.
4253         * python/py-function.c: Do not include py-ref.h.
4254         * python/py-infevents.c: Do not include py-ref.h.
4255         * python/py-linetable.c: Do not include py-ref.h.
4256         * python/py-objfile.c: Do not include py-ref.h.
4257         * python/py-param.c: Do not include py-ref.h.
4258         * python/py-prettyprint.c: Do not include py-ref.h.
4259         * python/py-progspace.c: Do not include py-ref.h.
4260         * python/py-symbol.c: Do not include py-ref.h.
4261         * python/py-symtab.c: Do not include py-ref.h.
4262         * python/py-type.c: Do not include py-ref.h.
4263         * python/py-unwind.c: Do not include py-ref.h.
4264         * python/py-utils.c: Do not include py-ref.h.
4265         * python/py-value.c: Do not include py-ref.h.
4266         * python/py-varobj.c: Do not include py-ref.h.
4267         * python/py-xmethods.c: Do not include py-ref.h.
4268         * python/python.c: Do not include py-ref.h.
4269         * varobj.c: Do not include py-ref.h.
4270
4271 2019-01-22  Tom Tromey  <tom@tromey.com>
4272
4273         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
4274         keyword for bcache.
4275
4276 2019-01-22  Tom Tromey  <tom@tromey.com>
4277
4278         * compile/compile-cplus-types.c: Remove a comment by #include.
4279
4280 2019-01-22  Tom Tromey  <tom@tromey.com>
4281
4282         * compile/gcc-c-plugin.h: Include compile-internal.h.
4283
4284 2019-01-22  Tom Tromey  <tom@tromey.com>
4285
4286         * stabsread.c (EXTERN): Do not define.
4287         (symnum, next_symbol_text_func, processing_gcc_compilation)
4288         (within_function, global_sym_chain, global_stabs)
4289         (previous_stab_code, this_object_header_files)
4290         (n_this_object_header_files)
4291         (n_allocated_this_object_header_files): Define.
4292         * stabsread.h (EXTERN): Never define.  Use "extern".
4293
4294 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4295
4296         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
4297         history_value.
4298
4299 2019-01-21  Tom Tromey  <tom@tromey.com>
4300
4301         * ui-out.c: Fix includes.
4302         * tui/tui-source.c: Fix includes.
4303         * target.c: Fix includes.
4304         * remote.c: Fix includes.
4305         * regcache.c: Fix includes.
4306         * python/py-block.c: Fix includes.
4307         * printcmd.c: Fix includes.
4308         * or1k-tdep.c: Fix includes.
4309         * mi/mi-main.c: Fix includes.
4310         * m32r-tdep.c: Fix includes.
4311         * csky-tdep.c: Fix includes.
4312         * compile/compile-cplus-types.c: Fix includes.
4313         * cli/cli-interp.c: Fix includes.
4314
4315 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
4316
4317         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4318         for padding.
4319
4320 2019-01-16  Tom Tromey  <tom@tromey.com>
4321
4322         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
4323         earlier.
4324         (struct objfile) <msymbols_range>: Move from top level.
4325         <msymbols>: New method.
4326         (class objfile_msymbols): Remove.
4327         * symtab.c (default_collect_symbol_completion_matches_break_on):
4328         Update.
4329         * symmisc.c (dump_msymbols): Update.
4330         * stabsread.c (scan_file_globals): Update.
4331         * objc-lang.c (info_selectors_command, info_classes_command)
4332         (find_methods): Update.
4333         * minsyms.c (find_solib_trampoline_target): Update.
4334         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
4335         * coffread.c (coff_symfile_read): Update.
4336         * ada-lang.c (ada_lookup_simple_minsym)
4337         (ada_collect_symbol_completion_matches): Update.
4338
4339 2019-01-16  Tom Tromey  <tom@tromey.com>
4340
4341         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
4342         type.  Remove no-argument constructor.
4343         <iterator::operator++>: Simplify.
4344         <begin>: Update.
4345         <end>: Use minimal_symbol_count.
4346
4347 2019-01-16  Tom Tromey  <tom@tromey.com>
4348
4349         * objfiles.h (struct objfile) <psymtabs>: New method.
4350         (class objfile_psymtabs): Remove.
4351         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
4352         typedef.
4353         <range>: New method.
4354         (require_partial_symbols): Change return type.
4355         * psymtab.c (require_partial_symbols)
4356         (psym_expand_symtabs_matching): Update.
4357         * mdebugread.c (parse_partial_symbols): Update.
4358         * dbxread.c (dbx_end_psymtab): Update.
4359
4360 2019-01-15  Tom Tromey  <tom@tromey.com>
4361
4362         * symtab.c (lookup_objfile_from_block)
4363         (lookup_symbol_in_objfile_symtabs)
4364         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
4365         (find_line_symtab, info_sources_command)
4366         (default_collect_symbol_completion_matches_break_on)
4367         (make_source_files_completion_list): Update.
4368         * symmisc.c (print_objfile_statistics, dump_objfile)
4369         (maintenance_print_symbols, maintenance_info_symtabs)
4370         (maintenance_check_symtabs, maintenance_info_line_tables):
4371         Update.
4372         * source.c (select_source_symtab)
4373         (forget_cached_source_info_for_objfile): Update.
4374         * objfiles.h (class objfile_compunits): Remove.
4375         (struct objfile) <compunits_range>: New typedef.
4376         (compunits): New method.
4377         * objfiles.c (objfile_relocate1): Update.
4378         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4379         * maint.c (count_symtabs_and_blocks): Update.
4380         * linespec.c (iterate_over_all_matching_symtabs): Update.
4381         * cp-support.c (add_symbol_overload_list_qualified): Update.
4382         * coffread.c (coff_symtab_read): Update.
4383         * ada-lang.c (add_nonlocal_symbols)
4384         (ada_collect_symbol_completion_matches)
4385         (ada_add_global_exceptions): Update.
4386
4387 2019-01-15  Tom Tromey  <tom@tromey.com>
4388
4389         * progspace.h (program_space) <objfiles_safe_range>: New
4390         typedef.
4391         <objfiles_safe>: New method.
4392         * objfiles.h (class all_objfiles_safe): Remove.
4393         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
4394         * jit.c (jit_inferior_exit_hook): Update.
4395
4396 2019-01-17  Tom Tromey  <tom@tromey.com>
4397
4398         * progspace.h (program_space) <objfiles_range>: New typedef.
4399         <objfiles>: New method.
4400         <objfiles_head>: Rename from objfiles.
4401         (object_files): Update.
4402         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
4403         * guile/scm-pretty-print.c
4404         (ppscm_find_pretty_printer_from_objfiles): Update.
4405         * guile/scm-objfile.c (gdbscm_objfiles): Update.
4406         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
4407         Update.
4408         * python/py-progspace.c (pspy_get_objfiles): Update.
4409         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4410         Update.
4411         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4412         (objfpy_lookup_objfile_by_build_id): Update.
4413         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4414         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
4415         Update.
4416         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4417         (expand_symtab_containing_pc, lookup_objfile_from_block)
4418         (lookup_static_symbol, basic_lookup_transparent_type)
4419         (find_pc_sect_compunit_symtab, find_symbol_at_address)
4420         (find_line_symtab, info_sources_command)
4421         (default_collect_symbol_completion_matches_break_on)
4422         (make_source_files_completion_list, find_main_name): Update.
4423         * symmisc.c (print_symbol_bcache_statistics)
4424         (print_objfile_statistics, maintenance_print_symbols)
4425         (maintenance_print_msymbols, maintenance_print_objfiles)
4426         (maintenance_info_symtabs, maintenance_check_symtabs)
4427         (maintenance_expand_symtabs, maintenance_info_line_tables):
4428         Update.
4429         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
4430         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
4431         (map_overlay_command, unmap_overlay_command)
4432         (simple_overlay_update, expand_symtabs_matching)
4433         (map_symbol_filenames): Update.
4434         * symfile-debug.c (set_debug_symfile): Update.
4435         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
4436         Update.
4437         * source.c (select_source_symtab, forget_cached_source_info):
4438         Update.
4439         * solib.c (solib_read_symbols): Update.
4440         * solib-spu.c (append_ocl_sos): Update.
4441         * psymtab.c (maintenance_print_psymbols)
4442         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
4443         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
4444         * printcmd.c (info_symbol_command): Update.
4445         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
4446         Update.
4447         * objfiles.h (class all_objfiles): Remove.
4448         * objfiles.c (have_partial_symbols, have_full_symbols)
4449         (have_minimal_symbols, qsort_cmp, update_section_map)
4450         (shared_objfile_contains_address_p)
4451         (default_iterate_over_objfiles_in_search_order): Update.
4452         * objc-lang.c (info_selectors_command, info_classes_command)
4453         (find_methods): Update.
4454         * minsyms.c (find_solib_trampoline_target): Update.
4455         * maint.c (maintenance_info_sections)
4456         (maintenance_translate_address, count_symtabs_and_blocks):
4457         Update.
4458         * main.c (captured_main_1): Update.
4459         * linux-thread-db.c (try_thread_db_load_from_pdir)
4460         (has_libpthread): Update.
4461         * linespec.c (iterate_over_all_matching_symtabs)
4462         (search_minsyms_for_name): Update.
4463         * jit.c (jit_find_objf_with_entry_addr): Update.
4464         * hppa-tdep.c (find_unwind_entry)
4465         (hppa_lookup_stub_minimal_symbol): Update.
4466         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
4467         Update.
4468         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
4469         (elf_gnu_ifunc_resolve_by_got): Update.
4470         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
4471         * dwarf-index-write.c (save_gdb_index_command): Update.
4472         * cp-support.c (add_symbol_overload_list_qualified): Update.
4473         * breakpoint.c (create_overlay_event_breakpoint)
4474         (create_longjmp_master_breakpoint)
4475         (create_std_terminate_master_breakpoint)
4476         (create_exception_master_breakpoint): Update.
4477         * blockframe.c (find_pc_partial_function): Update.
4478         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
4479         (ada_collect_symbol_completion_matches)
4480         (ada_add_global_exceptions): Update.
4481
4482 2019-01-17  Tom Tromey  <tom@tromey.com>
4483
4484         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
4485         declare VEC.
4486         (solib_target_parse_libraries): Change return type.
4487         (library_list_start_segment, library_list_start_section)
4488         (library_list_end_library, library_list_start_library); Update.
4489         (solib_target_free_library_list): Remove.
4490         (solib_target_parse_libraries): Remove cleanup.  Change return
4491         type.
4492         (solib_target_current_sos): Update.
4493
4494 2019-01-17  Tom Tromey  <tromey@bapiya>
4495
4496         * valprint.c: Replace "the the" with "the".
4497         * symtab.c: Replace "the the" with "the".
4498         * solib.c: Replace "the the" with "the".
4499         * solib-dsbt.c: Replace "the the" with "the".
4500         * linespec.c: Replace "the the" with "the".
4501         * dwarf2loc.h: Replace "the the" with "the".
4502         * amd64-windows-tdep.c: Replace "the the" with "the".
4503         * aarch64-tdep.c: Replace "the the" with "the".
4504
4505 2019-01-16  Keith Seitz  <keiths@redhat.com>
4506
4507         PR gdb/23773
4508         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
4509         <builder>: Rename to ..
4510         <m_builder>: ... this and make private.
4511         (dwarf2_cu::get_builder): New method.  Change all users of
4512         `builder' to use this method.
4513         (dwarf2_start_symtab): Move to ...
4514         (dwarf2_cu::start_symtab): ... here.  Update all callers
4515         (setup_type_unit_groups): Move to ...
4516         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
4517         callers.
4518         (dwarf2_cu::reset_builder): New method.
4519         (process_full_compunit, process_full_type_unit): Use
4520         dwarf2_cu::reset_builder.
4521         (follow_die_offset): Record the ancestor CU if it is different
4522         from the followed DIE's CU.
4523         (follow_die_sig_1): Likewise.
4524
4525 2019-01-15  Tom Tromey  <tom@tromey.com>
4526
4527         * remote.c (class remote_state) <buf>: Now a char_vector.
4528         <buf_size>: Remove.
4529         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
4530         parameter.
4531         (remote_target::getpkt_or_notif_sane_1)
4532         (remote_target::getpkt_sane)
4533         (remote_target::getpkt_or_notif_sane): Likewise.
4534         (class remote_target) <putpkt>: New overload.
4535         (remote_target::read_frame): Change type of "buf_p".  Remove
4536         sizeof_p parameter.
4537         (packet_ok): New overload.
4538         (packet_check_result): New overload.
4539         Update all uses.
4540
4541 2019-01-14  Tom Tromey  <tom@tromey.com>
4542
4543         * remote-notif.c (handle_notification, remote_notif_ack)
4544         (remote_notif_parse): Make "buf" const.
4545         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
4546         const.
4547         (remote_notif_parse, remote_notif_ack, handle_notification):
4548         Likewise.
4549         * remote.c (remote_notif_stop_parse): Make "buf" const.
4550         (remote_target::remote_parse_stop_reply): Make "buf" const.
4551         (remote_notif_stop_ack): Make "buf" const.
4552
4553 2019-01-14  Tom Tromey  <tom@tromey.com>
4554
4555         * remote.c (remote_console_output): Make parameter const.
4556
4557 2019-01-14  Tom Tromey  <tom@tromey.com>
4558
4559         * target-debug.h (target_debug_print_signals): Constify.
4560         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
4561         * procfs.c (procfs_target::pass_signals): Update.
4562         * linux-nat.c (linux_nat_target::pass_signals): Update.
4563         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
4564         * target-delegates.c: Rebuild.
4565         * remote.c (remote_target::program_signals): Update.
4566         (remote_target::pass_signals): Update.
4567         * target.c (target_pass_signals): Constify argument.
4568         (target_program_signals): Likewise.
4569         * target.h (struct target_ops) <pass_signals, program_signals>:
4570         Constify argument.
4571         (target_pass_signals, target_program_signals): Constify argument.
4572
4573 2019-01-14  Tom Tromey  <tom@tromey.com>
4574
4575         PR tui/28819:
4576         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
4577
4578 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
4579
4580         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
4581         field.
4582         * rs6000-tdep.c: Include reggroups.h.
4583         (IS_V_ALIAS_PSEUDOREG): Define.
4584         (rs6000_register_name): Return names for the "vX" aliases.
4585         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
4586         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
4587         aliases.  Call default_register_reggroup_p for all other
4588         pseudo-registers.
4589         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
4590         New functions.
4591         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
4592         Handle "vX" aliases.
4593         (v_alias_pseudo_register_collect): New function.
4594         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
4595         (rs6000_gdbarch_init): Initialize "vX" aliases as
4596         pseudo-registers.  Restore registration of
4597         rs6000_pseudo_register_reggroup_p with
4598         set_tdesc_pseudo_register_reggroup_p.
4599
4600 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
4601
4602         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
4603         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
4604         set_gdbarch_num_pseudo_regs.
4605
4606 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4607
4608         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
4609         Remove arg prefixname, add do_set and do_show.
4610         Add member functions set_list and show_list.
4611         * cli/cli-style.c (class cli_style_option): Update accordingly.
4612         (style_set_list): Move to file scope.
4613         (style_show_list): Likewise.
4614         (set_style): Call help_list.
4615         (show_style): Call cmd_show_list.
4616         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
4617         Update to use the new macro.
4618
4619 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
4620
4621         * ada-lang.c (_initialize_ada_language): Expand the help text
4622         for the "catch exception" command.
4623
4624 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4625
4626         * symtab.c (matching_obj_sections): Initialize obj,
4627         declare it closer to its usage.
4628
4629 2019-01-10  Tom Tromey  <tom@tromey.com>
4630
4631         * thread-iter.h (inf_threads_iterator): Use next_iterator.
4632         (basic_inf_threads_range): Remove.
4633         (inf_threads_range, inf_non_exited_threads_range)
4634         (safe_inf_threads_range): Use next_adapter.
4635
4636 2019-01-10  Keith Seitz  <keiths@redhat.com>
4637
4638         PR gdb/23712
4639         PR symtab/23010
4640         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
4641         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
4642
4643 2019-01-10  Keith Seitz  <keiths@redhat.com>
4644
4645         PR gdb/23712
4646         PR symtab/23010
4647         * dictionary.c (pending_to_vector): Remove.
4648         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4649         Remove _1 suffix, replacing functions of the same name.  Update
4650         all callers.
4651         (dict_create_hashed, dict_create_hashed_expandable)
4652         (dict_create_linear, dict_create_linear_expandable, dict_free)
4653         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
4654         Make functions static.
4655
4656 2019-01-10  Keith Seitz  <keiths@redhat.com>
4657
4658         PR gdb/23712
4659         PR symtab/23010
4660         * dictionary.h (struct dictionary): Replace declaration with
4661         multidictionary.
4662         (dict_create_hashed, dict_create_hashed_expandable)
4663         (dict_create_linear, dict_create_linear_expandable)
4664         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
4665         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
4666         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
4667         taking multidictionary argument.
4668         [ALL_DICT_SYMBOLS]: Update for multidictionary.
4669         * block.h (struct block) <dict>: Change to multidictionary
4670         and rename `multidict'.
4671         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
4672         symmisc.c: Update all dictionary references to multidictionary.
4673
4674 2019-01-10  Keith Seitz  <keiths@redhat.com>
4675
4676         PR gdb/23712
4677         PR symtab/23010
4678         * dictionary.c: Include unordered_map.
4679         (pending_to_vector): New function.
4680         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4681         Rewrite the non-"_1" functions to take vector instead
4682         of linked list.
4683         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
4684         "new" _1 versions of the same name.
4685         (multidictionary): Define.
4686         (std::hash<enum language): New definition.
4687         (collate_pending_symbols_by_language, mdict_create_hashed)
4688         (mdict_create_hashed_expandable, mdict_create_linear)
4689         (mdict_create_linear_expandable, mdict_free)
4690         (find_language_dictionary, create_new_language_dictionary)
4691         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
4692         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
4693         (mdict_size, mdict_empty): New functions.
4694         * dictionary.h (mdict_iterator): Define.
4695
4696 2019-01-10  Pedro Alves  <palves@redhat.com>
4697
4698         * breakpoint.c (read_uploaded_action)
4699         (create_tracepoint_from_upload): Adjust to use
4700         gdb::unique_xmalloc_ptr.
4701         * ctf.c (ctf_write_uploaded_tp):
4702         (SET_ARRAY_FIELD): Use emplace_back.
4703         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
4704         * tracefile-tfile.c (tfile_write_uploaded_tp):
4705         * tracepoint.c (parse_tracepoint_definition): Adjust to use
4706         gdb::unique_xmalloc_ptr.
4707         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
4708         at_string, cond_string, cmd_strings>: Replace char pointers
4709         with gdb::unique_xmalloc_ptr.
4710
4711 2019-01-10  Pedro Alves  <palves@redhat.com>
4712
4713         * solib-target.c (library_list_start_library): Don't xstrdup name.
4714
4715 2019-01-10  Pedro Alves  <palves@redhat.com>
4716
4717         * mdebugread.c (parse_partial_symbols): Use
4718         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
4719
4720 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4721
4722         * linux-fork.c (scoped_switch_fork_info)
4723         <~scoped_switch_fork_info>: Fix incorrect variable name.
4724
4725 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4726
4727         * linux-fork.c (scoped_switch_fork_info)
4728         <scoped_switch_fork_info>: Make explicit.
4729         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
4730
4731 2019-01-10  Tom Tromey  <tom@tromey.com>
4732
4733         * objfiles.h (objfile::reset_psymtabs): Update.
4734         * objfiles.c (objfile::objfile): Update.
4735         * psymtab.h (psymtab_storage::obstack): Update.
4736         (psymtab_storage::m_obstack): Use gdb::optional.
4737         (class psymtab_storage): Update comment.  Remove objfile
4738         parameter.
4739         * psymtab.c (psymtab_storage::psymtab_storage): Update.
4740
4741 2019-01-10  Tom Tromey  <tom@tromey.com>
4742
4743         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
4744         <free_psymtabs>: Now private.
4745         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
4746         (allocate_psymtab): Use new method.
4747
4748 2019-01-10  Tom Tromey  <tom@tromey.com>
4749
4750         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
4751         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
4752         * mdebugread.c (parse_partial_symbols): Use
4753         allocate_dependencies.
4754         * dwarf2read.c (dwarf2_create_include_psymtab): Use
4755         allocate_dependencies.
4756         (process_psymtab_comp_unit_reader)
4757         (build_type_psymtab_dependencies): Likewise.
4758         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
4759
4760 2019-01-10  Tom Tromey  <tom@tromey.com>
4761
4762         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
4763         PSYMBOL_SET_LANGUAGE.
4764         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
4765
4766 2019-01-10  Tom Tromey  <tom@tromey.com>
4767
4768         * psymtab.h (psymtab_storage::obstack): New method.
4769         <m_obstack>: Rename from obstack; now private.
4770         * psymtab.c (psymtab_storage): Update.
4771         * dwarf2read.c (create_addrmap_from_index)
4772         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
4773         Update.
4774
4775 2019-01-10  Tom Tromey  <tom@tromey.com>
4776
4777         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
4778         * objfiles.h (objfile::reset_psymtabs): New method.
4779
4780 2019-01-10  Tom Tromey  <tom@tromey.com>
4781
4782         * symmisc.c (print_symbol_bcache_statistics): Update.
4783         (print_objfile_statistics): Update.
4784         * symfile.c (reread_symbols): Update.
4785         * psymtab.h (class psymtab_storage): New.
4786         * psymtab.c (psymtab_storage): New constructor.
4787         (~psymtab_storage): New destructor.
4788         (require_partial_symbols): Update.
4789         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
4790         (find_pc_sect_psymtab, find_pc_sect_psymbol)
4791         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
4792         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
4793         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
4794         (start_psymtab_common, end_psymtab_common)
4795         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
4796         (allocate_psymtab): Update.
4797         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
4798         Update.
4799         (dump_psymtab_addrmap, maintenance_print_psymbols)
4800         (maintenance_check_psymtabs): Update.
4801         (class objfile_psymtabs): Move to objfiles.h.
4802         * psympriv.h (discard_psymtab): Now inline.
4803         (psymtab_discarder::psymtab_discarder): Update.
4804         (psymtab_discarder::~psymtab_discarder): Update.
4805         (ALL_OBJFILE_PSYMTABS): Rewrite.
4806         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
4807         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
4808         Remove fields.
4809         <partial_symtabs>: New field.
4810         (class objfile_psymtabs): Move from psymtab.h.  Update.
4811         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
4812         psymbol_cache.
4813         (objfile::~objfile): Don't destroy psymbol_cache.
4814         * mdebugread.c (parse_partial_symbols): Update.
4815         * dwarf2read.c (create_addrmap_from_index)
4816         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
4817         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
4818         (add_partial_subprogram, dwarf2_ranges_read): Update.
4819         * dwarf-index-write.c (write_address_map)
4820         (write_one_signatured_type, recursively_write_psymbols)
4821         (class debug_names, class debug_names, write_psymtabs_to_index):
4822         Update.
4823
4824 2019-01-10  Tom Tromey  <tom@tromey.com>
4825
4826         * symtab.h (SYMBOL_SET_NAMES): Update.
4827         (symbol_set_names): Update.
4828         (MSYMBOL_SET_NAMES): Update.
4829         * symtab.c (symbol_set_names): Change argument to be an
4830         objfile_per_bfd_storage.
4831         * psymtab.c (add_psymbol_to_bcache): Update.
4832         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
4833
4834 2019-01-10  Tom Tromey  <tom@tromey.com>
4835
4836         * symtab.c (create_demangled_names_hash): Change argument to be an
4837         objfile_per_bfd_storage.
4838         (symbol_set_names): Update.
4839
4840 2019-01-10  Tom Tromey  <tom@tromey.com>
4841
4842         * xcoffread.c (xcoff_initial_scan): Unconditionally call
4843         init_psymbol_list.
4844         * psymtab.c (init_psymbol_list): Do nothing if already called.
4845         * psympriv.h (init_psymbol_list): Add comment.
4846         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
4847         init_psymbol_list.
4848         * dbxread.c (dbx_symfile_read): Unconditionally call
4849         init_psymbol_list.
4850
4851 2019-01-10  Tom Tromey  <tom@tromey.com>
4852
4853         * xcoffread.c (scan_xcoff_symtab): Update.
4854         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
4855         "where".
4856         * mdebugread.c (parse_partial_symbols)
4857         (handle_psymbol_enumerators): Update.
4858         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
4859         * dbxread.c (read_dbx_symtab): Update.
4860         * psympriv.h (psymbol_placement): New enum.
4861         (add_psymbol_to_list): Update.
4862
4863 2019-01-10  Tom Tromey  <tom@tromey.com>
4864
4865         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
4866         static_psymbols parameters.
4867         (scan_xcoff_symtab): Update.
4868         * psymtab.c (start_psymtab_common): Remove global_psymbols and
4869         static_psymbols parameters.
4870         * psympriv.h (start_psymtab_common): Update.
4871         * mdebugread.c (parse_partial_symbols): Update.
4872         * dwarf2read.c (create_partial_symtab): Update.
4873         * dbxread.c (read_dbx_symtab): Update.
4874         (start_psymtab): Remove global_psymbols and static_psymbols
4875         parameters.
4876
4877 2019-01-10  Tom Tromey  <tom@tromey.com>
4878
4879         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
4880         * psymtab.c (allocate_psymtab): Add comment.
4881         * psympriv.h (allocate_psymtab): Add comment.
4882         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
4883         initializations.
4884         * dbxread.c (dbx_end_psymtab): Remove some initializations.
4885
4886 2019-01-10  Tom Tromey  <tom@tromey.com>
4887
4888         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4889         Don't declare.
4890         * mipsread.c: Include mdebugread.h.
4891         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4892         Declare.
4893         * elfread.c: Include mdebugread.h.
4894
4895 2019-01-09  Tom Tromey  <tom@tromey.com>
4896
4897         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
4898         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
4899         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
4900         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
4901         (psym_lookup_symbol, psym_find_last_source_symtab)
4902         (psym_forget_cached_source_info, psym_print_stats)
4903         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
4904         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
4905         (psym_map_matching_symbols, psym_expand_symtabs_matching)
4906         (psym_find_compunit_symtab_by_address)
4907         (maintenance_print_psymbols, maintenance_info_psymtabs)
4908         (maintenance_check_psymtabs): Use ranged for.
4909         * psymtab.h (class objfile_psymtabs): New.
4910         (require_partial_symbols): Return objfile_psymtabs.
4911         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
4912
4913 2019-01-09  Tom Tromey  <tom@tromey.com>
4914
4915         * symfile.c (overlay_invalidate_all, find_pc_overlay)
4916         (find_pc_mapped_section, list_overlays_command)
4917         (map_overlay_command, unmap_overlay_command)
4918         (simple_overlay_update): Use all_objfiles.
4919         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
4920         * printcmd.c (info_symbol_command): Use all_objfiles.
4921         * objfiles.h (ALL_OBJSECTIONS): Remove.
4922         * maint.c (maintenance_translate_address): Use all_objfiles.
4923         * gcore.c (gcore_create_callback): Use all_objfiles.
4924         (objfile_find_memory_regions): Likewise.
4925
4926 2019-01-09  Tom Tromey  <tom@tromey.com>
4927
4928         * symtab.c (find_line_symtab, info_sources_command)
4929         (make_source_files_completion_list): Use objfile_compunits.
4930         * source.c (select_source_symtab): Use objfile_compunits.
4931         * objfiles.h (struct objfile): Update comment.
4932         (ALL_OBJFILES): Remove.
4933         (ALL_FILETABS): Remove.
4934         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
4935         objfile_compunits.
4936
4937 2019-01-09  Tom Tromey  <tom@tromey.com>
4938
4939         * symmisc.c (print_objfile_statistics, dump_objfile)
4940         (maintenance_print_symbols): Use compunit_filetabs.
4941         * source.c (forget_cached_source_info_for_objfile): Use
4942         compunit_filetabs.
4943         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
4944         (ALL_FILETABS): Use compunit_filetabs.
4945         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
4946         * coffread.c (coff_symtab_read): Use compunit_filetabs.
4947
4948 2019-01-09  Tom Tromey  <tom@tromey.com>
4949
4950         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
4951         (compunit_filetabs): New.
4952         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
4953         compunit_filetabs.
4954         (info_sources_command, make_source_files_completion_list): Remove
4955         declaration.
4956         * symmisc.c (print_objfile_statistics, dump_objfile)
4957         (maintenance_print_symbols): Remove declaration.
4958         (maintenance_info_symtabs): Use compunit_filetabs.
4959         (maintenance_info_line_tables): Likewise.
4960         * source.c (select_source_symtab): Change local variable name.
4961         (forget_cached_source_info_for_objfile): Remove declaration.
4962         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
4963         * objfiles.c (objfile_relocate1): Remove declaration.
4964         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4965         declaration.
4966         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
4967         * coffread.c (coff_symtab_read): Remove declaration.
4968         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
4969         compunit_filetabs.
4970
4971 2019-01-09  Tom Tromey  <tom@tromey.com>
4972
4973         * symtab.c (lookup_objfile_from_block)
4974         (find_pc_sect_compunit_symtab, search_symbols)
4975         (default_collect_symbol_completion_matches_break_on): Use
4976         objfile_compunits.
4977         * objfiles.h (ALL_COMPUNITS): Remove.
4978         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
4979         * cp-support.c (add_symbol_overload_list_qualified): Use
4980         objfile_compunits.
4981         * ada-lang.c (ada_collect_symbol_completion_matches)
4982         (ada_add_global_exceptions): Use objfile_compunits.
4983
4984 2019-01-09  Tom Tromey  <tom@tromey.com>
4985
4986         * source.c (select_source_symtab)
4987         (forget_cached_source_info_for_objfile): Remove declaration.
4988         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4989         declaration.
4990         * maint.c (count_symtabs_and_blocks): Remove declaration.
4991         * cp-support.c (add_symbol_overload_list_qualified): Remove
4992         declaration.
4993         * coffread.c (coff_symtab_read): Remove declaration.
4994         * symtab.c (lookup_symbol_in_objfile_symtabs)
4995         (basic_lookup_transparent_type_1): Use objfile_compunits.
4996         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
4997         (info_sources_command, search_symbols)
4998         (default_collect_symbol_completion_matches_break_on)
4999         (make_source_files_completion_list): Remove declaration.
5000         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
5001         (ada_collect_symbol_completion_matches)
5002         (ada_add_global_exceptions): Remove declaration.
5003         * linespec.c (iterate_over_all_matching_symtabs): Use
5004         objfile_compunits.
5005         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
5006         (class objfile_compunits): New.
5007         (ALL_COMPUNITS): Use objfile_compunits.
5008         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
5009         (maintenance_check_symtabs, maintenance_info_line_tables): Use
5010         objfile_compunits.
5011         * objfiles.c (objfile_relocate1): Use objfile_compunits.
5012
5013 2019-01-09  Tom Tromey  <tom@tromey.com>
5014
5015         * symtab.c (search_symbols)
5016         (default_collect_symbol_completion_matches_break_on): Use
5017         objfile_msymbols.
5018         * ada-lang.c (ada_lookup_simple_minsym)
5019         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
5020         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
5021         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
5022         objfile_msymbols.
5023         * coffread.c (coff_symfile_read): Use objfile_msymbols.
5024         * symmisc.c (dump_msymbols): Use objfile_msymbols.
5025         * objc-lang.c (find_methods): Use objfile_msymbols.
5026         (info_selectors_command, info_classes_command): Likewise.
5027         * stabsread.c (scan_file_globals): Use objfile_msymbols.
5028         * objfiles.h (class objfile_msymbols): New.
5029         (ALL_OBJFILE_MSYMBOLS): Remove.
5030         (ALL_MSYMBOLS): Remove.
5031
5032 2019-01-09  Tom Tromey  <tom@tromey.com>
5033
5034         * common/next-iterator.h (next_adapter): Add Iterator template
5035         parameter.
5036         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
5037         (class all_objfiles_safe): New.
5038         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
5039         * objfiles.c (put_objfile_before): Update comment.
5040         (add_separate_debug_objfile): Likewise.
5041         (free_all_objfiles): Use all_objfiles_safe.
5042         (objfile_purge_solibs): Likewise.
5043
5044 2019-01-09  Tom Tromey  <tom@tromey.com>
5045
5046         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5047         (expand_symtab_containing_pc, lookup_static_symbol)
5048         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
5049         (find_symbol_at_address, find_line_symtab, find_main_name): Use
5050         all_objfiles.
5051         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
5052         * breakpoint.c (create_overlay_event_breakpoint)
5053         (create_longjmp_master_breakpoint)
5054         (create_std_terminate_master_breakpoint)
5055         (create_exception_master_breakpoint): Use all_objfiles.
5056         * linux-thread-db.c (try_thread_db_load_from_pdir)
5057         (has_libpthread): Use all_objfiles.
5058         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
5059         * linespec.c (iterate_over_all_matching_symtabs)
5060         (search_minsyms_for_name): Use all_objfiles.
5061         * maint.c (maintenance_info_sections): Use all_objfiles.
5062         * main.c (captured_main_1): Use all_objfiles.
5063         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
5064         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
5065         * guile/scm-pretty-print.c
5066         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
5067         * solib-spu.c (append_ocl_sos): Use all_objfiles.
5068         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
5069         (maintenance_print_msymbols): Use all_objfiles.
5070         * source.c (select_source_symtab): Use all_objfiles.
5071         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
5072         * symfile.c (remove_symbol_file_command)
5073         (expand_symtabs_matching, map_symbol_filenames): Use
5074         all_objfiles.
5075         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
5076         all_objfiles.
5077         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
5078         * objc-lang.c (find_methods): Use all_objfiles.
5079         * objfiles.c (have_partial_symbols, have_full_symbols)
5080         (have_minimal_symbols, qsort_cmp)
5081         (default_iterate_over_objfiles_in_search_order): Use
5082         all_objfiles.
5083         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
5084         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
5085         (maintenance_check_psymtabs): Use all_objfiles.
5086         (ALL_PSYMTABS): Remove.
5087         * compile/compile-object-run.c (do_module_cleanup): Use
5088         all_objfiles.
5089         * blockframe.c (find_pc_partial_function): Use all_objfiles.
5090         * cp-support.c (add_symbol_overload_list_qualified): Use
5091         all_objfiles.
5092         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5093         Use all_objfiles.
5094         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
5095         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
5096         all_objfiles.
5097         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5098         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
5099         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5100         Uses all_objfiles.
5101         * solib.c (solib_read_symbols): Use all_objfiles
5102
5103 2019-01-09  Tom Tromey  <tom@tromey.com>
5104
5105         * probe.c (parse_probes_in_pspace): Use all_objfiles.
5106         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
5107         all_objfiles.
5108         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
5109         * symmisc.c (print_symbol_bcache_statistics)
5110         (print_objfile_statistics, maintenance_print_objfiles)
5111         (maintenance_info_symtabs, maintenance_check_symtabs)
5112         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
5113         all_objfiles.
5114         * source.c (forget_cached_source_info): Use all_objfiles.
5115         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
5116         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5117         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
5118         * objfiles.c (update_section_map): Use all_objfiles.
5119         (shared_objfile_contains_address_p): Likewise.
5120         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
5121         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
5122
5123 2019-01-09  Tom Tromey  <tom@tromey.com>
5124
5125         * common/next-iterator.h: New file.
5126         * objfiles.h (class all_objfiles): New.
5127         (struct objfile_iterator): New.
5128
5129 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5130
5131         * NEWS: Move the description of the changed "frame", "select-frame",
5132          and "info frame" commands to the Changed commands section.
5133
5134 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
5135
5136         * gdbtypes.c (check_stub_method_group): Remove handling of old
5137         mangling schemes.
5138         * linespec.c (find_methods): Likewise.
5139         * stabsread.c (read_member_functions): Likewise.
5140         * valops.c (search_struct_method): Likewise.
5141         (value_struct_elt_for_reference): Likewise.
5142         * NEWS: Mention this change.
5143
5144 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5145
5146         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
5147         print_source_lines.
5148         * source.c (print_source_lines_base): Update line number check.
5149         (print_source_lines): New function.
5150         (source_lines_range::source_lines_range): New function.
5151         * source.h (class source_lines_range): New class.
5152         (print_source_lines): New declaration.
5153
5154 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5155
5156         * linespec.c (linespec_state_destructor): Free self->canonical_names.
5157
5158 2019-01-08  Tom Tromey  <tom@tromey.com>
5159             Simon Marchi  <simon.marchi@ericsson.com>
5160
5161         PR gdb/24060
5162         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
5163         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
5164         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5165         * f-exp.y (DOLLAR_VARIABLE): Likewise.
5166         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
5167         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5168
5169 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5170
5171         * source.c (select_source_symtab): Move header comment to
5172         declaration in source.h.
5173         (forget_cached_source_info_for_objfile): Likewise.
5174         (forget_cached_source_info): Likewise.
5175         (identify_source_line): Likewise.
5176         * source.h (identify_source_line): Move declaration from symtab.h
5177         and add comment from source.c
5178         (print_source_lines): Likewise.
5179         (forget_cached_source_info_for_objfile): Likewise.
5180         (forget_cached_source_info): Likewise.
5181         (select_source_symtab): Likewise.
5182         (enum print_source_lines_flag): Move definition from symtab.h.
5183         * symtab.h (identify_source_line): Move declaration to source.h.
5184         (print_source_lines): Likewise.
5185         (forget_cached_source_info_for_objfile): Likewise.
5186         (forget_cached_source_info): Likewise.
5187         (select_source_symtab): Likewise.
5188         (enum print_source_lines_flag): Move definition to source.h.
5189         * tui/tui-hooks.c: Add 'source.h' include.
5190
5191 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5192
5193         * source.c (print_source_lines_base): Handle requests to print
5194         reverse line number sequences, and guard against empty lines
5195         string.
5196
5197 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5198
5199         * source.c (print_source_lines_base): Fix skip of '\r' if next
5200         character is '\n'.
5201
5202 2019-01-06  Tom Tromey  <tom@tromey.com>
5203
5204         * c-exp.y (struct c_parse_state) <macro_original_text,
5205         expansion_obstack>: New member.
5206         (macro_original_text, expansion_obstack): Remove globals.
5207         (scan_macro_expansion, scanning_macro_expansion)
5208         (finished_macro_expansion): Update.
5209         (scan_macro_cleanup): Remove.
5210         (yylex, c_parse): Update.
5211
5212 2019-01-06  Tom Tromey  <tom@tromey.com>
5213
5214         * c-exp.y (struct c_parse_state) <strings>: New member.
5215         (operator_stoken): Update.
5216
5217 2019-01-06  Tom Tromey  <tom@tromey.com>
5218
5219         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
5220         (union type_stack_elt) <typelist_val>: Now a pointer to
5221         std::vector.
5222         (type_stack_cleanup): Don't declare.
5223         (push_typelist): Update.
5224         * parse.c (pop_typelist): Return a std::vector.
5225         (push_typelist): Take a std::vector.
5226         (follow_types): Update.  Do not free args.
5227         (type_stack_cleanup): Remove.
5228         * c-exp.y (struct c_parse_state): New.
5229         (cpstate): New global.
5230         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
5231         (nonempty_typelist): Update.
5232         (func_mod): Create a new vector.
5233         (c_parse): Create a c_parse_state.
5234         (check_parameter_typelist): Do not delete params.
5235         (function_method): Update.  Do not delete type_list.
5236
5237 2019-01-06  Tom Tromey  <tom@tromey.com>
5238
5239         PR gdb/28155:
5240         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
5241         check_typedef.
5242         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
5243         (print_return_value): Likewise.
5244
5245 2019-01-05  Tom Tromey  <tom@tromey.com>
5246
5247         * contrib/cleanup_check.py: Remove.
5248         * contrib/gcc-with-excheck: Remove.
5249         * contrib/exsummary.py: Remove.
5250         * contrib/excheck.py: Remove.
5251
5252 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
5253
5254         * thread.c (delete_thread_1): Add gdb_assert that THR is not
5255         NULL. Initialize tpprev to NULL instead of assigning it
5256         to NULL on the next statement.
5257         * windows-nat.c (windows_delete_thread): Remove check for
5258         main_thread_id before printing thread exit notifications.
5259         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
5260         Remove thread ID check against main_thread_id.
5261         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
5262         windows_delete_thread.
5263         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
5264
5265 2019-01-04  Tom Tromey  <tom@tromey.com>
5266
5267         * compile/compile.c (_initialize_compile): Use upper case for
5268         metasyntactic variables.
5269         * symmisc.c (_initialize_symmisc): Use upper case for
5270         metasyntactic variables.
5271         * psymtab.c (_initialize_psymtab): Use upper case for
5272         metasyntactic variables.
5273         * demangle.c (demangle_command): Use upper case for metasyntactic
5274         variables.
5275         (_initialize_demangler): Likewise.
5276         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
5277         variables.
5278
5279 2019-01-03  Tom Tromey  <tom@tromey.com>
5280
5281         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
5282
5283 2019-01-03  Tom Tromey  <tom@tromey.com>
5284
5285         * python/py-symtab.c (salpy_str): Update.
5286         (struct salpy_sal_object) <symtab>: Now a PyObject.
5287         (salpy_dealloc): Update.
5288         (del_objfile_sal): Use gdbpy_ref.
5289
5290 2019-01-03  Tom Tromey  <tom@tromey.com>
5291
5292         * python/py-type.c (convert_field): Use new_reference.  Return
5293         gdbpy_ref.
5294         (make_fielditem): Return gdbpy_ref.
5295         (typy_fields): Update.
5296         (typy_getitem): Update.
5297         (field_name): Return gdbpy_ref.  Use new_reference.
5298         (typy_iterator_iternext): Update.
5299
5300 2019-01-03  Tom Tromey  <tom@tromey.com>
5301
5302         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
5303
5304 2019-01-03  Tom Tromey  <tom@tromey.com>
5305
5306         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
5307         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
5308         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
5309         (pspy_set_frame_filters, pspy_set_frame_unwinders)
5310         (pspy_set_type_printers): Likewise.
5311         * python/py-function.c (fnpy_init): Use gdbpy_ref.
5312         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
5313         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
5314         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
5315         (objfpy_set_type_printers): Likewise.
5316
5317 2019-01-03  Tom Tromey  <tom@tromey.com>
5318
5319         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
5320         (gdbpy_print_stack): Use gdbpy_err_fetch.
5321         * python/python-internal.h (class gdbpy_err_fetch): New class.
5322         (class gdbpy_enter) <m_error_type, m_error_value,
5323         m_error_traceback>: Remove.
5324         <m_error>: New member.
5325         (gdbpy_exception_to_string): Don't declare.
5326         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
5327         * python/py-value.c (convert_value_from_python): Use
5328         gdbpy_err_fetch.
5329         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
5330         gdbpy_exception_to_string.
5331         (gdbpy_handle_exception): Use gdbpy_err_fetch.
5332         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
5333         gdbpy_err_fetch.
5334
5335 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5336
5337         * linux-nat.c (delete_lwp_cleanup): Delete.
5338         (struct lwp_deleter): New struct.
5339         (lwp_info_up): New typedef.
5340         (linux_nat_target::follow_fork): Delete cleanup, and make use of
5341         lwp_info_up.
5342
5343 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5344
5345         * linux-fork.c (class scoped_switch_fork_info): New class.
5346         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
5347
5348 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5349
5350         * valops.c (find_overload_match): Remove use of null_cleanup, and
5351         calls to do_cleanups.
5352
5353 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5354
5355         * compile/compile-cplus-types.c
5356         (compile_cplus_instance::decl_name): Handle changes to
5357         cp_func_name.
5358         * cp-support.c (cp_func_name): Update header comment, update
5359         return type.
5360         * cp-support.h (cp_func_name): Update return type in declaration.
5361         * valops.c (find_overload_match): Move temp_func local to top
5362         level of function and change its type.  Use temp_func to hold and
5363         delete temporary string obtained from cp_func_name.
5364
5365 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5366
5367         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
5368         gdb::char_vector, remove cleanup, and update uses of `msg`.
5369
5370 2019-01-03  Jim Wilson  <jimw@sifive.com>
5371
5372         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
5373
5374 2019-01-02  Tom Tromey  <tom@tromey.com>
5375
5376         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
5377         (tdesc_parse_xml): Remove cleanups.
5378         * target-descriptions.h (make_cleanup_free_target_description):
5379         Don't declare.
5380         (target_desc_deleter): New struct.
5381         (target_desc_up): New typedef.
5382         * target-descriptions.c (target_desc_deleter::operator()): Rename
5383         from free_target_description.
5384         (make_cleanup_free_target_description): Remove.
5385
5386 2019-01-02  Tom Tromey  <tom@tromey.com>
5387
5388         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
5389         constructor, destructor.
5390         (linespec_parser): Remove typedef.
5391         (~linespec_parser): Rename from linespec_parser_delete.
5392         (linespec_lex_to_end, linespec_complete_label)
5393         (linespec_complete): Update.
5394         (decode_line_full): Remove cleanups.
5395         (decode_line_1): Update.
5396
5397 2019-01-02  Tom Tromey  <tom@tromey.com>
5398
5399         * python/python-internal.h (inferior_to_inferior_object): Change
5400         return type.
5401         * python/py-exitedevent.c (create_exited_event_object): Update.
5402         * python/py-inferior.c (inferior_to_inferior_object): Return
5403         gdbpy_ref.
5404         (python_new_inferior, python_inferior_deleted)
5405         (thread_to_thread_object, delete_thread_object)
5406         (build_inferior_list, gdbpy_selected_inferior): Update.
5407         * python/py-infthread.c (create_thread_object): Update.  Also fail
5408         if inferior_to_inferior_object fails.
5409
5410 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
5411
5412         * inferior.h (class inferior) <displaced_step_state>: New field.
5413         * infrun.h (struct displaced_step_state): Move here from
5414         infrun.c.  Initialize fields, add constructor.
5415         <inf>: Remove field.
5416         <reset>: New method.
5417         * infrun.c (struct displaced_step_inferior_state): Move to
5418         infrun.h.
5419         (displaced_step_inferior_states): Remove.
5420         (get_displaced_stepping_state): Adust.
5421         (displaced_step_in_progress_any_inferior): Adjust.
5422         (displaced_step_in_progress_thread): Adjust.
5423         (displaced_step_in_progress): Adjust.
5424         (add_displaced_stepping_state): Remove.
5425         (get_displaced_step_closure_by_addr): Adjust.
5426         (remove_displaced_stepping_state): Remove.
5427         (infrun_inferior_exit): Call displaced_step_state.reset.
5428         (use_displaced_stepping): Don't check for NULL.
5429         (displaced_step_prepare_throw): Call
5430         get_displaced_stepping_state.
5431         (displaced_step_fixup): Don't check for NULL.
5432         (prepare_for_detach): Don't check for NULL.
5433
5434 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5435
5436         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
5437          in case of call that did not complete.
5438
5439 2019-01-02  Andrey Utkin  <autkin@undo.io>
5440
5441         * symfile.c (find_separate_debug_file): Fix search of debug files for
5442         remote debuggee.
5443
5444 2019-01-02  Tom Tromey  <tom@tromey.com>
5445
5446         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
5447         indentation.
5448         * python/py-frame.c (frapy_older): Remove cast.
5449         (frapy_newer): Likewise.
5450         * python/py-breakpoint.c (local_setattro): Remove cast.
5451         * python/py-arch.c (archpy_name): Remove local variable.
5452         * python/py-type.c (gdbpy_lookup_type): Remove cast.
5453
5454 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
5455
5456         * unittests/basic_string_view/element_access/char/empty.cc:
5457         Fix year range in copyright header.
5458
5459 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5460
5461         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
5462         Delete.
5463         <operator==>: Update with for removed field.
5464         <hash>: Likewise.
5465         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
5466         <isa_features>: ...this.
5467         <abi_features>: New field.
5468         (riscv_isa_flen): Update comment.
5469         (riscv_abi_xlen): New declaration.
5470         (riscv_abi_flen): New declaration.
5471         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
5472         isa_features.
5473         (riscv_abi_xlen): New function.
5474         (riscv_isa_flen): Update to get answer from isa_features.
5475         (riscv_abi_flen): New function.
5476         (riscv_has_fp_abi): Update to get answer from abi_features.
5477         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
5478         xlen and flen.
5479         (riscv_call_info) <xlen, flen>: Update comment.
5480         (riscv_call_arg_struct): Remove invalid assertions
5481         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
5482         is removed.
5483         (riscv_gdbarch_init): Gather isa features and abi features
5484         separately, ensure both match on the gdbarch when reusing an old
5485         gdbarch.  Relax an error check to allow 32-bit abi float to run on
5486         a target with 64-bit float hardware.
5487
5488 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5489
5490         * source.c (search_command_helper): Stop reverse search
5491         when line 1 has been searched.
5492
5493 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5494
5495         * record-full.c (record_full_base_target::close): Rewrite
5496         record_full_core_buf_list free logic.
5497
5498 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5499
5500         * break-catch-syscall.c (print_one_catch_syscall): xfree
5501         the last text.
5502
5503 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5504
5505         * top.c (print_gdb_version): Update Copyright year in version
5506         message.
5507
5508 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5509
5510         Update copyright year range in all GDB files.
5511
5512 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
5513
5514         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
5515
5516 For older changes see ChangeLog-2018.
5517 \f
5518 Local Variables:
5519 mode: change-log
5520 left-margin: 8
5521 fill-column: 74
5522 version-control: never
5523 coding: utf-8
5524 End:
5525