Use function_view in cli-script.c
[external/binutils.git] / gdb / ChangeLog
1 2018-05-04  Tom Tromey  <tom@tromey.com>
2
3         * tracepoint.c (actions_command): Update.
4         * mi/mi-cmd-break.c (mi_command_line_array)
5         (mi_command_line_array_cnt, mi_command_line_array_ptr)
6         (mi_read_next_line): Remove.
7         (mi_cmd_break_commands): Update.
8         * cli/cli-script.h (read_command_lines, read_command_lines_1): Use
9         function_view.
10         * cli/cli-script.c (get_command_line): Update.
11         (process_next_line): Use function_view.  Constify.
12         (recurse_read_control_structure, read_command_lines)
13         (read_command_lines_1): Change argument types to function_view.
14         (do_define_command, document_command): Update.
15         * breakpoint.h (check_tracepoint_command): Don't declare.
16         * breakpoint.c (check_tracepoint_command): Remove.
17         (commands_command_1, create_tracepoint_from_upload): Update.
18
19 2018-05-04  Tom Tromey  <tom@tromey.com>
20
21         PR gdb/11750:
22         * cli/cli-script.h (enum command_control_type) <define_control>:
23         New constant.
24         * cli/cli-script.c (multi_line_command_p): Handle define_control.
25         (build_command_line, execute_control_command_1)
26         (process_next_line): Likewise.
27         (do_define_command): New function, extracted from define_command.
28         (define_command): Use it.
29
30 2018-05-04  Tom Tromey  <tom@tromey.com>
31
32         * tracepoint.c (actions_command): Update.
33         * cli/cli-script.h (read_command_lines): Update.
34         * cli/cli-script.c (read_command_lines): Constify prompt_arg.
35         (MAX_TMPBUF): Remove define.
36         (define_command): Use string_printf.
37         (document_command): Likewise.
38         * breakpoint.c (commands_command_1): Update.
39
40 2018-05-04  Tom Tromey  <tom@tromey.com>
41
42         * top.c (execute_command): Update.
43         * cli/cli-script.h (print_command_lines): Now varargs.
44         * cli/cli-script.c (print_command_lines): Now varargs.
45         (execute_control_command_1) <case while_control, case if_control>:
46         Update.
47
48 2018-05-04  Tom Tromey  <tom@tromey.com>
49
50         * tracepoint.c (all_tracepoint_actions): Rename from
51         all_tracepoint_actions_and_cleanup.  Change return type.
52         (actions_command, encode_actions_1, encode_actions)
53         (trace_dump_actions, tdump_command): Update.
54         * remote.c (remote_download_command_source): Update.
55         * python/python.c (gdbpy_eval_from_control_command)
56         (python_command, python_interactive_command): Update.
57         * mi/mi-cmd-break.c (mi_cmd_break_commands): Update.
58         * guile/guile.c (guile_command)
59         (gdbscm_eval_from_control_command, guile_command): Update.
60         * compile/compile.c (compile_code_command)
61         (compile_print_command, compile_to_object): Update.
62         * cli/cli-script.h (struct command_lines_deleter): New.
63         (counted_command_line): New typedef.
64         (struct command_line): Add constructor, destructor.
65         <body_list>: Remove.
66         <body_list_0, body_list_1>: New members.
67         (command_line_up): Remove typedef.
68         (read_command_lines, read_command_lines_1, get_command_line):
69         Update.
70         (copy_command_lines): Don't declare.
71         * cli/cli-script.c (build_command_line): Use "new".
72         (get_command_line): Return counted_command_line.
73         (print_command_lines, execute_user_command)
74         (execute_control_command_1, while_command, if_command): Update.
75         (realloc_body_list): Remove.
76         (process_next_line, recurse_read_control_structure): Update.
77         (read_command_lines, read_command_lines_1): Return counted_command_line.
78         (free_command_lines): Use "delete".
79         (copy_command_lines): Remove.
80         (define_command, document_command, show_user_1): Update.
81         * cli/cli-decode.h (struct cmd_list_element) <user_commands>: Now
82         a counted_command_line.
83         * breakpoint.h (counted_command_line): Remove typedef.
84         (breakpoint_set_commands): Update.
85         * breakpoint.c (check_no_tracepoint_commands)
86         (validate_commands_for_breakpoint): Update.
87         (breakpoint_set_commands): Change commands to be a
88         counted_command_line.
89         (commands_command_1, update_dprintf_command_list)
90         (create_tracepoint_from_upload): Update.
91
92 2018-05-04  Tom Tromey  <tom@tromey.com>
93
94         * cli/cli-decode.h (cmd_list_element): New constructor.
95         (~cmd_list_element): New destructor.
96         (struct cmd_list_element): Add initializers.
97         * cli/cli-decode.c (do_add_cmd): Use "new".
98         (delete_cmd): Use "delete".
99
100 2018-05-04  Jan Kratochvil  <jan.kratochvil@redhat.com>
101             Pedro Alves <palves@redhat.com>
102
103         PR breakpoints/19806 and support for PR external/20207.
104         * NEWS: Mention Aarch64 watchpoint improvements.
105         * aarch64-linux-nat.c (aarch64_linux_stopped_data_address): Fix missed
106         watchpoints and PR external/20207 watchpoints.
107         * nat/aarch64-linux-hw-point.c
108         (kernel_supports_any_contiguous_range): New.
109         (aarch64_watchpoint_offset): New.
110         (aarch64_watchpoint_length): Support PR external/20207 watchpoints.
111         (aarch64_point_encode_ctrl_reg): New parameter offset, new asserts.
112         (aarch64_point_is_aligned): Support PR external/20207 watchpoints.
113         (aarch64_align_watchpoint): New parameters aligned_offset_p and
114         next_addr_orig_p.  Support PR external/20207 watchpoints.
115         (aarch64_downgrade_regs): New.
116         (aarch64_dr_state_insert_one_point): New parameters offset and
117         addr_orig.
118         (aarch64_dr_state_remove_one_point): Likewise.
119         (aarch64_handle_breakpoint): Update caller.
120         (aarch64_handle_aligned_watchpoint): Likewise.
121         (aarch64_handle_unaligned_watchpoint): Support addr_orig and
122         aligned_offset.
123         (aarch64_linux_set_debug_regs): Remove const from state.  Call
124         aarch64_downgrade_regs.
125         (aarch64_show_debug_reg_state): Print also dr_addr_orig_wp.
126         * nat/aarch64-linux-hw-point.h (DR_CONTROL_LENGTH): Rename to ...
127         (DR_CONTROL_MASK): ... this.
128         (struct aarch64_debug_reg_state): New field dr_addr_orig_wp.
129         (unsigned int aarch64_watchpoint_offset): New prototype.
130         (aarch64_linux_set_debug_regs): Remove const from state.
131         * utils.c (align_up, align_down): Move to ...
132         * common/common-utils.c (align_up, align_down): ... here.
133         * utils.h (align_up, align_down): Move to ...
134         * common/common-utils.h (align_up, align_down): ... here.
135
136 2018-05-04  Joel Brobecker  <brobecker@adacore.com>
137
138         * sparc-tdep.c (sparc_structure_return_p): Re-implement to
139         match the ABI as summarized in GCC's gcc/config/sparc/sparc.c.
140         (sparc_arg_by_memory_p): Renamed from sparc_arg_on_registers_p.
141         Re-implement to match the ABI as summarized in GCC's
142         gcc/config/sparc/sparc.c.  All callers updated.
143         (sparc32_store_arguments): Remove assertion.
144
145 2018-05-04  Tom Tromey  <tom@tromey.com>
146
147         * printcmd.c: Don't include tui.h.
148         (decode_format): Use skip_spaces.
149
150 2018-05-04  Tom Tromey  <tom@tromey.com>
151
152         PR gdb/22619:
153         * printcmd.c (last_count): New global.
154         (x_command): Use saved count when repeating.
155
156 2018-05-04  Tom Tromey  <tom@tromey.com>
157
158         * nto-procfs.c (do_closedir_cleanup): Remove.
159         (procfs_pidlist): Use gdb_dir_up.
160         * procfs.c (do_closedir_cleanup): Remove.
161         (proc_update_threads): Use gdb_dir_up.
162         * common/filestuff.h (struct gdb_dir_deleter): New.
163         (gdb_dir_up): New typedef.
164
165 2018-05-04  Tom Tromey  <tom@tromey.com>
166
167         * ada-lang.c (print_mention_exception): Use std::string.
168
169 2018-05-04  Tom Tromey  <tom@tromey.com>
170
171         * ada-lang.c (create_excep_cond_exprs): Update.
172         (ada_exception_catchpoint_cond_string): Use std::string.
173
174 2018-05-04  Tom Tromey  <tom@tromey.com>
175
176         * ada-lang.c (xget_renaming_scope): Return std::string.
177         (old_renaming_is_invisible): Update.
178
179 2018-05-04  Tom Tromey  <tom@tromey.com>
180
181         * bfd-target.c (target_bfd::m_bfd): Now a gdb_bfd_ref_ptr.
182         (target_bfd::target_bfd, target_bfd::~target_bfd): Update.
183
184 2018-05-04  Ulrich Weigand  <uweigand@de.ibm.com>
185
186         * spu-linux-nat.c (spu_linux_nat_target::wait): Fix syntax error.
187
188 2018-05-04  Tom Tromey  <tom@tromey.com>
189
190         * remote.c (remote_query_supported_append): Change type.
191         (remote_check_symbols): Update.
192
193 2018-05-04  Paul Pluzhnikov  <ppluzhnikov@google.com>
194
195         PR gdb/11420
196         * configure.ac: Prepend libpython.
197         * python/python-config.py: Likewise.
198         * configure: Regenerate.
199
200 2018-05-03  Simon Marchi  <simon.marchi@ericsson.com>
201
202         * Makefile.in (%.c: %.l): Use -t instead of --stdout.
203
204 2018-05-03  Pedro Alves  <palves@redhat.com>
205
206         * s390-linux-nat.c
207         (s390_linux_nat_target::have_continuable_watchpoint): Mark with
208         override.  Write 'true' instead of '1'.
209         (s390_linux_nat_target::watchpoint_addr_within_range): Remove
210         declaration.
211
212 2018-05-02  Pedro Alves  <palves@redhat.com>
213
214         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Use
215         add_inf_child_target.
216         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Use
217         add_inf_child_target.
218         * aix-thread.c (aix_thread_target_info): New.
219         (aix_thread_target) <shortname, longname, doc>: Delete.
220         <info>: New.
221         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Use
222         add_inf_child_target.
223         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Use
224         add_inf_child_target.
225         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Use
226         add_inf_child_target.
227         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Use
228         add_inf_child_target.
229         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Use
230         add_inf_child_target.
231         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Use
232         add_inf_child_target.
233         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Use
234         add_inf_child_target.
235         * arm-linux-nat.c (_initialize_arm_linux_nat): Use
236         add_inf_child_target.
237         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Use
238         add_inf_child_target.
239         * bfd-target.c (target_bfd_target_info): New.
240         (target_bfd) <shortname, longname, doc>: Delete.
241         <info>: New.
242         * bsd-kvm.c (bsd_kvm_target_info): New.
243         (bsd_kvm_target) <shortname, longname, doc>: Delete.
244         <info>: New.
245         (bsd_kvm_target::open): Rename to ...
246         (bsd_kvm_target_open): ... this.  Adjust.
247         * bsd-uthread.c (bsd_uthread_target_info): New.
248         (bsd_uthread_target) <shortname, longname, doc>: Delete.
249         <info>: New.
250         * corefile.c (core_file_command): Adjust.
251         * corelow.c (core_target_info): New.
252         (core_target) <shortname, longname, doc>: Delete.
253         <info>: New.
254         (core_target::open): Rename to ...
255         (core_target_open): ... this.  Adjust.
256         * ctf.c (ctf_target_info): New.
257         (ctf_target) <shortname, longname, doc>: Delete.
258         <info>: New.
259         (ctf_target::open): Rename to ...
260         (ctf_target_open): ... this.
261         (_initialize_ctf): Adjust.
262         * exec.c (exec_target_info): New.
263         (exec_target) <shortname, longname, doc>: Delete.
264         <info>: New.
265         (exec_target::open): Rename to ...
266         (exec_target_open): ... this.
267         * gdbcore.h (core_target_open): Declare.
268         * go32-nat.c (_initialize_go32_nat): Use add_inf_child_target.
269         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Use
270         add_inf_child_target.
271         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Use
272         add_inf_child_target.
273         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Use
274         add_inf_child_target.
275         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Use
276         add_inf_child_target.
277         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Use
278         add_inf_child_target.
279         * i386-gnu-nat.c (_initialize_i386gnu_nat): Use
280         add_inf_child_target.
281         * i386-linux-nat.c (_initialize_i386_linux_nat): Use
282         add_inf_child_target.
283         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Use
284         add_inf_child_target.
285         * i386-obsd-nat.c (_initialize_i386obsd_nat): Use
286         add_inf_child_target.
287         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Use
288         add_inf_child_target.
289         * inf-child.c (inf_child_target_info): New.
290         (inf_child_target::info): New.
291         (inf_child_open_target): Remove 'target' parameter.  Use
292         get_native_target instead.
293         (inf_child_target::open): Delete.
294         (add_inf_child_target): New.
295         * inf-child.h (inf_child_target) <shortname, longname, doc, open>:
296         Delete.
297         <info>: New.
298         (add_inf_child_target): Declare.
299         (inf_child_open_target): Declare.
300         * linux-thread-db.c (thread_db_target_info): New.
301         (thread_db_target) <shortname, longname, doc>: Delete.
302         <info>: New.
303         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Use
304         add_inf_child_target.
305         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Use
306         add_inf_child_target.
307         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Use
308         add_inf_child_target.
309         * m88k-bsd-nat.c (_initialize_m88kbsd_nat): Use
310         add_inf_child_target.
311         * make-target-delegates (print_class): Adjust.
312         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Use
313         add_inf_child_target.
314         * mips-linux-nat.c (_initialize_mips_linux_nat): Use
315         add_inf_child_target.
316         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Use
317         add_inf_child_target.
318         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Use
319         add_inf_child_target.
320         * nto-procfs.c (nto_native_target_info): New.
321         (nto_procfs_target_native) <shortname, longname, doc>:
322         Delete.
323         <info>: New.
324         (nto_procfs_target_info): New.
325         (nto_procfs_target_procfs) <shortname, longname, doc>:
326         Delete.
327         <info>: New.
328         (init_procfs_targets): Adjust.
329         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Use
330         add_inf_child_target.
331         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Use
332         add_inf_child_target.
333         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Use
334         add_inf_child_target.
335         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Use
336         add_inf_child_target.
337         * ravenscar-thread.c (ravenscar_target_info): New.
338         (ravenscar_thread_target) <shortname, longname, doc>:
339         Delete.
340         <info>: New.
341         * record-btrace.c (record_btrace_target_info):
342         (record_btrace_target) <shortname, longname, doc>: Delete.
343         <info>: New.
344         (record_btrace_target::open): Rename to ...
345         (record_btrace_target_open): ... this.  Adjust.
346         * record-full.c (record_longname, record_doc): New.
347         (record_full_base_target) <shortname, longname, doc>: Delete.
348         <info>: New.
349         (record_full_target_info): New.
350         (record_full_target): <shortname>: Delete.
351         <info>: New.
352         (record_full_core_open_1, record_full_open_1): Update comments.
353         (record_full_base_target::open): Rename to ...
354         (record_full_open): ... this.
355         (cmd_record_full_restore): Update.
356         (_initialize_record_full): Update.
357         * remote-sim.c (remote_sim_target_info): New.
358         (gdbsim_target) <shortname, longname, doc>: Delete.
359         <info>: New.
360         (gdbsim_target::open): Rename to ...
361         (gdbsim_target_open): ... this.
362         (_initialize_remote_sim): Adjust.
363         * remote.c (remote_doc): New.
364         (remote_target_info): New.
365         (remote_target) <shortname, longname, doc>: Delete.
366         <info>: New.
367         (extended_remote_target_info): New.
368         (extended_remote_target) <shortname, longname, doc>: Delete.
369         <info>: New.
370         (remote_target::open_1): Make static.  Adjust.
371         * rs6000-nat.c (_initialize_rs6000_nat): Use add_inf_child_target.
372         * s390-linux-nat.c (_initialize_s390_nat): Use
373         add_inf_child_target.
374         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Use
375         add_inf_child_target.
376         * sol-thread.c (thread_db_target_info): New.
377         (sol_thread_target) <shortname, longname, doc>: Delete.
378         <info>: New.
379         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Use
380         add_inf_child_target.
381         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Use
382         add_inf_child_target.
383         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Use
384         add_inf_child_target.
385         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Use
386         add_inf_child_target.
387         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Use
388         add_inf_child_target.
389         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Use
390         add_inf_child_target.
391         * spu-linux-nat.c (_initialize_spu_nat): Use
392         add_inf_child_target.
393         * spu-multiarch.c (spu_multiarch_target_info): New.
394         (spu_multiarch_target) <shortname, longname, doc>: Delete.
395         <info>: New.
396         * target-delegates.c: Regenerate.
397         * target.c: Include <unordered_map>.
398         (target_ops_p): Delete.
399         (DEF_VEC_P(target_ops_p)): Delete.
400         (target_factories): New.
401         (test_target_info): New.
402         (test_target_ops::info): New.
403         (open_target): Adjust to use target_factories.
404         (add_target_with_completer): Rename to ...
405         (add_target): ... this.  Change prototype.  Register target_info
406         and open callback in target_factories.  Register target_info in
407         command context instead of target_ops.
408         (add_target): Delete old implementation.
409         (add_deprecated_target_alias): Change prototype.  Adjust.
410         (the_native_target): New.
411         (set_native_target, get_native_target): New.
412         (find_default_run_target): Use the_native_target.
413         (find_attach_target, find_run_target): Simplify.
414         (target_ops::open): Delete.
415         (dummy_target_info): New.
416         (dummy_target::shortname, dummy_target::longname)
417         (dummy_target::doc): Delete.
418         (dummy_target::info): New.
419         (debug_target::shortname, debug_target::longname)
420         (debug_target::doc): Delete.
421         (debug_target::info): New.
422         * target.h (struct target_info): New.
423         (target_ops::~target_ops): Add comment.
424         (target_ops::info): New.
425         (target_ops::shortname, target_ops::longname, target_ops::doc): No
426         longer virtual.  Implement in terms of target_info.
427         (set_native_target, get_native_target): Declare.
428         (target_open_ftype): New.
429         (add_target, add_target_with_completer)
430         (add_deprecated_target_alias): Change prototype.
431         (test_target) <shortname, longname, doc>: Delete.
432         <info>: New.
433         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Use
434         add_inf_child_target.
435         * tracefile-tfile.c (tfile_target_info): New.
436         (tfile_target) <shortname, longname, doc>: Delete.
437         <info>: New.
438         (tfile_target::open): Rename to ...
439         (tfile_target_open): ... this.
440         (_initialize_tracefile_tfile): Adjust.
441         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Use
442         add_inf_child_target.
443         * windows-nat.c (_initialize_windows_nat): Use
444         add_inf_child_target.
445         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Use
446         add_inf_child_target.
447
448 2018-05-02  Pedro Alves  <palves@redhat.com>
449
450         * linux-nat.h (linux_nat_target) <low_new_thread,
451         low_delete_thread, low_new_fork, low_forget_process,
452         low_prepare_to_resume, low_siginfo_fixup, low_status_is_event>:
453         New virtual methods.
454         (linux_nat_set_new_thread, linux_nat_set_delete_thread)
455         (linux_nat_new_fork_ftype, linux_nat_set_new_fork)
456         (linux_nat_forget_process_ftype, linux_nat_set_forget_process)
457         (linux_nat_forget_process, linux_nat_set_siginfo_fixup)
458         (linux_nat_set_prepare_to_resume, linux_nat_set_status_is_event):
459         Delete.
460         * linux-fork.c (delete_fork): Adjust to call low method.
461         * linux-nat.c (linux_nat_new_thread, linux_nat_delete_thread)
462         (linux_nat_new_fork, linux_nat_forget_process_hook)
463         (linux_nat_prepare_to_resume, linux_nat_siginfo_fixup)
464         (linux_nat_status_is_event):
465         (linux_nat_target::follow_fork, lwp_free, add_lwp, detach_one_lwp)
466         (linux_resume_one_lwp_throw, linux_handle_extended_wait): Adjust
467         to call low method.
468         (sigtrap_is_event): Rename to ...
469         (linux_nat_target::low_status_is_event): ... this.
470         (linux_nat_set_status_is_event): Delete.
471         (save_stop_reason, linux_nat_wait_1)
472         (linux_nat_target::mourn_inferior, siginfo_fixup): Adjust to call
473         low methods.
474         (linux_nat_set_new_thread, linux_nat_set_delete_thread)
475         (linux_nat_set_new_fork, linux_nat_set_forget_process)
476         (linux_nat_forget_process, linux_nat_set_siginfo_fixup)
477         (linux_nat_set_prepare_to_resume): Delete.
478         * aarch64-linux-nat.c: All linux_nat_set_* callbacks converted to
479         low virtual methods.
480         * amd64-linux-nat.c: Likewise.
481         * arm-linux-nat.c: Likewise.
482         * i386-linux-nat.c: Likewise.
483         * ia64-linux-nat.c: Likewise.
484         * mips-linux-nat.c: Likewise.
485         * ppc-linux-nat.c: Likewise.
486         * s390-linux-nat.c: Likewise.
487         * sparc64-linux-nat.c: Likewise.
488         * x86-linux-nat.c: Likewise.
489         * x86-linux-nat.h: Include "nat/x86-linux.h".
490         (x86_linux_nat_target) <low_new_fork, low_forget_process,
491         low_prepare_to_resume, low_new_thread, low_delete_thread>:
492         Override methods.
493
494 2018-05-02  Pedro Alves  <palves@redhat.com>
495
496         * target.h (target_ops)
497         <stopped_by_sw_breakpoint, supports_stopped_by_sw_breakpoint,
498         stopped_by_hw_breakpoint, supports_stopped_by_hw_breakpoint,
499         stopped_by_watchpoint, have_continuable_watchpoint,
500         stopped_data_address, watchpoint_addr_within_range,
501         can_accel_watchpoint_condition, can_run, thread_alive,
502         has_all_memory, has_memory, has_stack, has_registers,
503         has_execution, can_async_p, is_async_p, supports_non_stop,
504         always_non_stop_p, can_execute_reverse, supports_multi_process,
505         supports_enable_disable_tracepoint,
506         supports_disable_randomization, supports_string_tracing,
507         supports_evaluation_of_breakpoint_conditions,
508         can_run_breakpoint_commands, filesystem_is_local,
509         can_download_tracepoint, get_trace_state_variable_value,
510         set_trace_notes, get_tib_address, use_agent, can_use_agent,
511         record_is_replaying, record_will_replay,
512         augmented_libraries_svr4_read>: Adjust to return bool.
513         * aarch64-linux-nat.c: All implementations adjusted.
514         * aix-thread.c: All implementations adjusted.
515         * arm-linux-nat.c: All implementations adjusted.
516         * breakpoint.c: All implementations adjusted.
517         * bsd-kvm.c: All implementations adjusted.
518         * bsd-uthread.c: All implementations adjusted.
519         * corelow.c: All implementations adjusted.
520         * ctf.c: All implementations adjusted.
521         * darwin-nat.c: All implementations adjusted.
522         * darwin-nat.h: All implementations adjusted.
523         * exec.c: All implementations adjusted.
524         * fbsd-nat.c: All implementations adjusted.
525         * fbsd-nat.h: All implementations adjusted.
526         * gnu-nat.c: All implementations adjusted.
527         * gnu-nat.h: All implementations adjusted.
528         * go32-nat.c: All implementations adjusted.
529         * ia64-linux-nat.c: All implementations adjusted.
530         * inf-child.c: All implementations adjusted.
531         * inf-child.h: All implementations adjusted.
532         * inf-ptrace.c: All implementations adjusted.
533         * inf-ptrace.h: All implementations adjusted.
534         * linux-nat.c: All implementations adjusted.
535         * linux-nat.h: All implementations adjusted.
536         * mips-linux-nat.c: All implementations adjusted.
537         * nto-procfs.c: All implementations adjusted.
538         * ppc-linux-nat.c: All implementations adjusted.
539         * procfs.c: All implementations adjusted.
540         * ravenscar-thread.c: All implementations adjusted.
541         * record-btrace.c: All implementations adjusted.
542         * record-full.c: All implementations adjusted.
543         * remote-sim.c: All implementations adjusted.
544         * remote.c: All implementations adjusted.
545         * s390-linux-nat.c: All implementations adjusted.
546         * sol-thread.c: All implementations adjusted.
547         * spu-multiarch.c: All implementations adjusted.
548         * target-delegates.c: All implementations adjusted.
549         * target.c: All implementations adjusted.
550         * target.h: All implementations adjusted.
551         * tracefile-tfile.c: All implementations adjusted.
552         * tracefile.c: All implementations adjusted.
553         * tracefile.h: All implementations adjusted.
554         * windows-nat.c: All implementations adjusted.
555         * x86-linux-nat.h: All implementations adjusted.
556         * x86-nat.h: All implementations adjusted.
557
558 2018-05-02  Pedro Alves  <palves@redhat.com>
559
560         * make-target-delegates (scan_target_h): Don't trim lines here.
561         Replace sequences of tabs and/or whitespace with a single
562         whitespace.
563         (top level, parsing methods): Trim each line before processing it
564         here.
565
566 2018-05-02  Pedro Alves  <palves@redhat.com>
567             John Baldwin  <jhb@freebsd.org>
568
569         * target.h (enum strata) <debug_stratum>: New.
570         (struct target_ops) <all delegation methods>: Replace by C++
571         virtual methods, and drop "to_" prefix.  All references updated
572         throughout.
573         <to_shortname, to_longname, to_doc, to_data,
574         to_have_steppable_watchpoint, to_have_continuable_watchpoint,
575         to_has_thread_control, to_attach_no_wait>: Delete, replaced by
576         virtual methods.  All references updated throughout.
577         <can_attach, supports_terminal_ours, can_create_inferior,
578         get_thread_control_capabilities, attach_no_wait>: New
579         virtual methods.
580         <insert_breakpoint, remove_breakpoint>: Now
581         TARGET_DEFAULT_NORETURN methods.
582         <info_proc>: Now returns bool.
583         <to_magic>: Delete.
584         (OPS_MAGIC): Delete.
585         (current_target): Delete.  All references replaced by references
586         to ...
587         (target_stack): ... this.  New.
588         (target_shortname, target_longname): Adjust.
589         (target_can_run): Now a function declaration.
590         (default_child_has_all_memory, default_child_has_memory)
591         (default_child_has_stack, default_child_has_registers)
592         (default_child_has_execution): Remove target_ops parameter.
593         (complete_target_initialization): Delete.
594         (memory_breakpoint_target): New template class.
595         (test_target_ops): Refactor as a C++ class with virtual methods.
596         * make-target-delegates (NAME_PART): Tighten.
597         (POINTER_PART, CP_SYMBOL): New.
598         (SIMPLE_RETURN_PART): Reimplement.
599         (VEC_RETURN_PART): Expect less.
600         (RETURN_PART, VIRTUAL_PART): New.
601         (METHOD): Adjust to C++ virtual methods.
602         (scan_target_h): Remove reference to C99.
603         (dname): Output "target_ops::" prefix.
604         (write_function_header): Adjust to output a C++ class method.
605         (write_declaration): New.
606         (write_delegator): Adjust to output a C++ class method.
607         (tdname): Output "dummy_target::" prefix.
608         (write_tdefault, write_debugmethod): Adjust to output a C++ class
609         method.
610         (tdefault_names, debug_names): Delete.
611         (return_types, tdefaults, styles, argtypes_array): New.
612         (top level): All methods are delegators.
613         (print_class): New.
614         (top level): Print dummy_target and debug_target classes.
615         * target-delegates.c: Regenerate.
616         * target-debug.h (target_debug_print_enum_info_proc_what)
617         (target_debug_print_thread_control_capabilities)
618         (target_debug_print_thread_info_p): New.
619         * target.c (dummy_target): Delete.
620         (the_dummy_target, the_debug_target): New.
621         (target_stack): Now extern.
622         (set_targetdebug): Push/unpush debug target.
623         (default_child_has_all_memory, default_child_has_memory)
624         (default_child_has_stack, default_child_has_registers)
625         (default_child_has_execution): Remove target_ops parameter.
626         (complete_target_initialization): Delete.
627         (add_target_with_completer): No longer call
628         complete_target_initialization.
629         (target_supports_terminal_ours): Use regular delegation.
630         (update_current_target): Delete.
631         (push_target): No longer check magic number.  Don't call
632         update_current_target.
633         (unpush_target): Don't call update_current_target.
634         (target_is_pushed): No longer check magic number.
635         (target_require_runnable): Skip for all stratums over
636         process_stratum.
637         (target_ops::info_proc): New.
638         (target_info_proc): Use find_target_at and
639         find_default_run_target.
640         (target_supports_disable_randomization): Use regular delegation.
641         (target_get_osdata): Use find_target_at.
642         (target_ops::open, target_ops::close, target_ops::can_attach)
643         (target_ops::attach, target_ops::can_create_inferior)
644         (target_ops::create_inferior, target_ops::can_run)
645         (target_can_run): New.
646         (default_fileio_target): Use regular delegation.
647         (target_ops::fileio_open, target_ops::fileio_pwrite)
648         (target_ops::fileio_pread, target_ops::fileio_fstat)
649         (target_ops::fileio_close, target_ops::fileio_unlink)
650         (target_ops::fileio_readlink): New.
651         (target_fileio_open_1, target_fileio_unlink)
652         (target_fileio_readlink): Always call the target method.  Handle
653         FILEIO_ENOSYS.
654         (return_zero, return_zero_has_execution): Delete.
655         (init_dummy_target): Delete.
656         (dummy_target::dummy_target, dummy_target::shortname)
657         (dummy_target::longname, dummy_target::doc)
658         (debug_target::debug_target, debug_target::shortname)
659         (debug_target::longname, debug_target::doc): New.
660         (target_supports_delete_record): Use regular delegation.
661         (setup_target_debug): Delete.
662         (maintenance_print_target_stack): Skip debug_stratum.
663         (initialize_targets): Instantiate the_dummy_target and
664         the_debug_target.
665         * auxv.c (target_auxv_parse): Remove 'ops' parameter.  Adjust to
666         use target_stack.
667         (target_auxv_search, fprint_target_auxv): Adjust.
668         (info_auxv_command): Adjust to use target_stack.
669         * auxv.h (target_auxv_parse): Remove 'ops' parameter.
670         * exceptions.c (print_flush): Handle a NULL target_stack.
671         * regcache.c (target_ops_no_register): Refactor as class with
672         virtual methods.
673
674         * exec.c (exec_target): New class.
675         (exec_ops): Now an exec_target.
676         (exec_open, exec_close_1, exec_get_section_table)
677         (exec_xfer_partial, exec_files_info, exec_has_memory)
678         (exec_make_note_section): Refactor as exec_target methods.
679         (exec_file_clear, ignore, exec_remove_breakpoint, init_exec_ops):
680         Delete.
681         (exec_target::find_memory_regions): New.
682         (_initialize_exec): Don't call init_exec_ops.
683         * gdbcore.h (exec_file_clear): Delete.
684
685         * corefile.c (core_target): Delete.
686         (core_file_command): Adjust.
687         * corelow.c (core_target): New class.
688         (the_core_target): New.
689         (core_close): Remove target_ops parameter.
690         (core_close_cleanup): Adjust.
691         (core_target::close): New.
692         (core_open, core_detach, get_core_registers, core_files_info)
693         (core_xfer_partial, core_thread_alive, core_read_description)
694         (core_pid_to_str, core_thread_name, core_has_memory)
695         (core_has_stack, core_has_registers, core_info_proc): Rework as
696         core_target methods.
697         (ignore, core_remove_breakpoint, init_core_ops): Delete.
698         (_initialize_corelow): Initialize the_core_target.
699         * gdbcore.h (core_target): Delete.
700         (the_core_target): New.
701
702         * ctf.c: (ctf_target): New class.
703         (ctf_ops): Now a ctf_target.
704         (ctf_open, ctf_close, ctf_files_info, ctf_fetch_registers)
705         (ctf_xfer_partial, ctf_get_trace_state_variable_value)
706         (ctf_trace_find, ctf_traceframe_info): Refactor as ctf_target
707         methods.
708         (init_ctf_ops): Delete.
709         (_initialize_ctf): Don't call it.
710         * tracefile-tfile.c (tfile_target): New class.
711         (tfile_ops): Now a tfile_target.
712         (tfile_open, tfile_close, tfile_files_info)
713         (tfile_get_tracepoint_status, tfile_trace_find)
714         (tfile_fetch_registers, tfile_xfer_partial)
715         (tfile_get_trace_state_variable_value, tfile_traceframe_info):
716         Refactor as tfile_target methods.
717         (tfile_xfer_partial_features): Remove target_ops parameter.
718         (init_tfile_ops): Delete.
719         (_initialize_tracefile_tfile): Don't call it.
720         * tracefile.c (tracefile_has_all_memory, tracefile_has_memory)
721         (tracefile_has_stack, tracefile_has_registers)
722         (tracefile_thread_alive, tracefile_get_trace_status): Refactor as
723         tracefile_target methods.
724         (init_tracefile_ops): Delete.
725         (tracefile_target::tracefile_target): New.
726         * tracefile.h: Include "target.h".
727         (tracefile_target): New class.
728         (init_tracefile_ops): Delete.
729
730         * spu-multiarch.c (spu_multiarch_target): New class.
731         (spu_ops): Now a spu_multiarch_target.
732         (spu_thread_architecture, spu_region_ok_for_hw_watchpoint)
733         (spu_fetch_registers, spu_store_registers, spu_xfer_partial)
734         (spu_search_memory, spu_mourn_inferior): Refactor as
735         spu_multiarch_target methods.
736         (init_spu_ops): Delete.
737         (_initialize_spu_multiarch): Remove references to init_spu_ops,
738         complete_target_initialization.
739
740         * ravenscar-thread.c (ravenscar_thread_target): New class.
741         (ravenscar_ops): Now a ravenscar_thread_target.
742         (ravenscar_resume, ravenscar_wait, ravenscar_update_thread_list)
743         (ravenscar_thread_alive, ravenscar_pid_to_str)
744         (ravenscar_fetch_registers, ravenscar_store_registers)
745         (ravenscar_prepare_to_store, ravenscar_stopped_by_sw_breakpoint)
746         (ravenscar_stopped_by_hw_breakpoint)
747         (ravenscar_stopped_by_watchpoint, ravenscar_stopped_data_address)
748         (ravenscar_mourn_inferior, ravenscar_core_of_thread)
749         (ravenscar_get_ada_task_ptid): Refactor as ravenscar_thread_target
750         methods.
751         (init_ravenscar_thread_ops): Delete.
752         (_initialize_ravenscar): Remove references to
753         init_ravenscar_thread_ops and complete_target_initialization.
754
755         * bsd-uthread.c (bsd_uthread_ops_hack): Delete.
756         (bsd_uthread_target): New class.
757         (bsd_uthread_ops): Now a bsd_uthread_target.
758         (bsd_uthread_activate): Adjust to refer to bsd_uthread_ops.
759         (bsd_uthread_close, bsd_uthread_mourn_inferior)
760         (bsd_uthread_fetch_registers, bsd_uthread_store_registers)
761         (bsd_uthread_wait, bsd_uthread_resume, bsd_uthread_thread_alive)
762         (bsd_uthread_update_thread_list, bsd_uthread_extra_thread_info)
763         (bsd_uthread_pid_to_str): Refactor as bsd_uthread_target methods.
764         (bsd_uthread_target): Delete function.
765         (_initialize_bsd_uthread): Remove reference to
766         complete_target_initialization.
767
768         * bfd-target.c (target_bfd_data): Delete.  Fields folded into ...
769         (target_bfd): ... this new class.
770         (target_bfd_xfer_partial, target_bfd_get_section_table)
771         (target_bfd_close): Refactor as target_bfd methods.
772         (target_bfd::~target_bfd): New.
773         (target_bfd_reopen): Adjust.
774         (target_bfd::close): New.
775
776         * record-btrace.c (record_btrace_target): New class.
777         (record_btrace_ops): Now a record_btrace_target.
778         (record_btrace_open, record_btrace_stop_recording)
779         (record_btrace_disconnect, record_btrace_close)
780         (record_btrace_async, record_btrace_info)
781         (record_btrace_insn_history, record_btrace_insn_history_range)
782         (record_btrace_insn_history_from, record_btrace_call_history)
783         (record_btrace_call_history_range)
784         (record_btrace_call_history_from, record_btrace_record_method)
785         (record_btrace_is_replaying, record_btrace_will_replay)
786         (record_btrace_xfer_partial, record_btrace_insert_breakpoint)
787         (record_btrace_remove_breakpoint, record_btrace_fetch_registers)
788         (record_btrace_store_registers, record_btrace_prepare_to_store)
789         (record_btrace_to_get_unwinder)
790         (record_btrace_to_get_tailcall_unwinder, record_btrace_resume)
791         (record_btrace_commit_resume, record_btrace_wait)
792         (record_btrace_stop, record_btrace_can_execute_reverse)
793         (record_btrace_stopped_by_sw_breakpoint)
794         (record_btrace_supports_stopped_by_sw_breakpoint)
795         (record_btrace_stopped_by_hw_breakpoint)
796         (record_btrace_supports_stopped_by_hw_breakpoint)
797         (record_btrace_update_thread_list, record_btrace_thread_alive)
798         (record_btrace_goto_begin, record_btrace_goto_end)
799         (record_btrace_goto, record_btrace_stop_replaying_all)
800         (record_btrace_execution_direction)
801         (record_btrace_prepare_to_generate_core)
802         (record_btrace_done_generating_core): Refactor as
803         record_btrace_target methods.
804         (init_record_btrace_ops): Delete.
805         (_initialize_record_btrace): Remove reference to
806         init_record_btrace_ops.
807         * record-full.c (RECORD_FULL_IS_REPLAY): Adjust to always refer to
808         the execution_direction global.
809         (record_full_base_target, record_full_target)
810         (record_full_core_target): New classes.
811         (record_full_ops): Now a record_full_target.
812         (record_full_core_ops): Now a record_full_core_target.
813         (record_full_target::detach, record_full_target::disconnect)
814         (record_full_core_target::disconnect)
815         (record_full_target::mourn_inferior, record_full_target::kill):
816         New.
817         (record_full_open, record_full_close, record_full_async): Refactor
818         as methods of the record_full_base_target class.
819         (record_full_resume, record_full_commit_resume): Refactor
820         as methods of the record_full_target class.
821         (record_full_wait, record_full_stopped_by_watchpoint)
822         (record_full_stopped_data_address)
823         (record_full_stopped_by_sw_breakpoint)
824         (record_full_supports_stopped_by_sw_breakpoint)
825         (record_full_stopped_by_hw_breakpoint)
826         (record_full_supports_stopped_by_hw_breakpoint): Refactor as
827         methods of the record_full_base_target class.
828         (record_full_store_registers, record_full_xfer_partial)
829         (record_full_insert_breakpoint, record_full_remove_breakpoint):
830         Refactor as methods of the record_full_target class.
831         (record_full_can_execute_reverse, record_full_get_bookmark)
832         (record_full_goto_bookmark, record_full_execution_direction)
833         (record_full_record_method, record_full_info, record_full_delete)
834         (record_full_is_replaying, record_full_will_replay)
835         (record_full_goto_begin, record_full_goto_end, record_full_goto)
836         (record_full_stop_replaying): Refactor as methods of the
837         record_full_base_target class.
838         (record_full_core_resume, record_full_core_kill)
839         (record_full_core_fetch_registers)
840         (record_full_core_prepare_to_store)
841         (record_full_core_store_registers, record_full_core_xfer_partial)
842         (record_full_core_insert_breakpoint)
843         (record_full_core_remove_breakpoint)
844         (record_full_core_has_execution): Refactor
845         as methods of the record_full_core_target class.
846         (record_full_base_target::supports_delete_record): New.
847         (init_record_full_ops): Delete.
848         (init_record_full_core_ops): Delete.
849         (record_full_save): Refactor as method of the
850         record_full_base_target class.
851         (_initialize_record_full): Remove references to
852         init_record_full_ops and init_record_full_core_ops.
853
854         * remote.c (remote_target, extended_remote_target): New classes.
855         (remote_ops): Now a remote_target.
856         (extended_remote_ops): Now an extended_remote_target.
857         (remote_insert_fork_catchpoint, remote_remove_fork_catchpoint)
858         (remote_insert_vfork_catchpoint, remote_remove_vfork_catchpoint)
859         (remote_insert_exec_catchpoint, remote_remove_exec_catchpoint)
860         (remote_pass_signals, remote_set_syscall_catchpoint)
861         (remote_program_signals, )
862         (remote_thread_always_alive): Remove target_ops parameter.
863         (remote_thread_alive, remote_thread_name)
864         (remote_update_thread_list, remote_threads_extra_info)
865         (remote_static_tracepoint_marker_at)
866         (remote_static_tracepoint_markers_by_strid)
867         (remote_get_ada_task_ptid, remote_close, remote_start_remote)
868         (remote_open): Refactor as methods of remote_target.
869         (extended_remote_open, extended_remote_detach)
870         (extended_remote_attach, extended_remote_post_attach):
871         (extended_remote_supports_disable_randomization)
872         (extended_remote_create_inferior): : Refactor as method of
873         extended_remote_target.
874         (remote_set_permissions, remote_open_1, remote_detach)
875         (remote_follow_fork, remote_follow_exec, remote_disconnect)
876         (remote_resume, remote_commit_resume, remote_stop)
877         (remote_interrupt, remote_pass_ctrlc, remote_terminal_inferior)
878         (remote_terminal_ours, remote_wait, remote_fetch_registers)
879         (remote_prepare_to_store, remote_store_registers)
880         (remote_flash_erase, remote_flash_done, remote_files_info)
881         (remote_kill, remote_mourn, remote_insert_breakpoint)
882         (remote_remove_breakpoint, remote_insert_watchpoint)
883         (remote_watchpoint_addr_within_range)
884         (remote_remove_watchpoint, remote_region_ok_for_hw_watchpoint)
885         (remote_check_watch_resources, remote_stopped_by_sw_breakpoint)
886         (remote_supports_stopped_by_sw_breakpoint)
887         (remote_stopped_by_hw_breakpoint)
888         (remote_supports_stopped_by_hw_breakpoint)
889         (remote_stopped_by_watchpoint, remote_stopped_data_address)
890         (remote_insert_hw_breakpoint, remote_remove_hw_breakpoint)
891         (remote_verify_memory): Refactor as methods of remote_target.
892         (remote_write_qxfer, remote_read_qxfer): Remove target_ops
893         parameter.
894         (remote_xfer_partial, remote_get_memory_xfer_limit)
895         (remote_search_memory, remote_rcmd, remote_memory_map)
896         (remote_pid_to_str, remote_get_thread_local_address)
897         (remote_get_tib_address, remote_read_description): Refactor as
898         methods of remote_target.
899         (remote_target::fileio_open, remote_target::fileio_pwrite)
900         (remote_target::fileio_pread, remote_target::fileio_close): New.
901         (remote_hostio_readlink, remote_hostio_fstat)
902         (remote_filesystem_is_local, remote_can_execute_reverse)
903         (remote_supports_non_stop, remote_supports_disable_randomization)
904         (remote_supports_multi_process, remote_supports_cond_breakpoints)
905         (remote_supports_enable_disable_tracepoint)
906         (remote_supports_string_tracing)
907         (remote_can_run_breakpoint_commands, remote_trace_init)
908         (remote_download_tracepoint, remote_can_download_tracepoint)
909         (remote_download_trace_state_variable, remote_enable_tracepoint)
910         (remote_disable_tracepoint, remote_trace_set_readonly_regions)
911         (remote_trace_start, remote_get_trace_status)
912         (remote_get_tracepoint_status, remote_trace_stop)
913         (remote_trace_find, remote_get_trace_state_variable_value)
914         (remote_save_trace_data, remote_get_raw_trace_data)
915         (remote_set_disconnected_tracing, remote_core_of_thread)
916         (remote_set_circular_trace_buffer, remote_traceframe_info)
917         (remote_get_min_fast_tracepoint_insn_len)
918         (remote_set_trace_buffer_size, remote_set_trace_notes)
919         (remote_use_agent, remote_can_use_agent, remote_enable_btrace)
920         (remote_disable_btrace, remote_teardown_btrace)
921         (remote_read_btrace, remote_btrace_conf)
922         (remote_augmented_libraries_svr4_read, remote_load)
923         (remote_pid_to_exec_file, remote_can_do_single_step)
924         (remote_execution_direction, remote_thread_handle_to_thread_info):
925         Refactor as methods of remote_target.
926         (init_remote_ops, init_extended_remote_ops): Delete.
927         (remote_can_async_p, remote_is_async_p, remote_async)
928         (remote_thread_events, remote_upload_tracepoints)
929         (remote_upload_trace_state_variables): Refactor as methods of
930         remote_target.
931         (_initialize_remote): Remove references to init_remote_ops and
932         init_extended_remote_ops.
933
934         * remote-sim.c (gdbsim_target): New class.
935         (gdbsim_fetch_register, gdbsim_store_register, gdbsim_kill)
936         (gdbsim_load, gdbsim_create_inferior, gdbsim_open, gdbsim_close)
937         (gdbsim_detach, gdbsim_resume, gdbsim_interrupt)
938         (gdbsim_wait, gdbsim_prepare_to_store, gdbsim_xfer_partial)
939         (gdbsim_files_info, gdbsim_mourn_inferior, gdbsim_thread_alive)
940         (gdbsim_pid_to_str, gdbsim_has_all_memory, gdbsim_has_memory):
941         Refactor as methods of gdbsim_target.
942         (gdbsim_ops): Now a gdbsim_target.
943         (init_gdbsim_ops): Delete.
944         (gdbsim_cntrl_c): Adjust.
945         (_initialize_remote_sim): Remove reference to init_gdbsim_ops.
946
947         * amd64-linux-nat.c (amd64_linux_nat_target): New class.
948         (the_amd64_linux_nat_target): New.
949         (amd64_linux_fetch_inferior_registers)
950         (amd64_linux_store_inferior_registers): Refactor as methods of
951         amd64_linux_nat_target.
952         (_initialize_amd64_linux_nat): Adjust.  Set linux_target.
953         * i386-linux-nat.c: Don't include "linux-nat.h".
954         (i386_linux_nat_target): New class.
955         (the_i386_linux_nat_target): New.
956         (i386_linux_fetch_inferior_registers)
957         (i386_linux_store_inferior_registers, i386_linux_resume): Refactor
958         as methods of i386_linux_nat_target.
959         (_initialize_i386_linux_nat): Adjust.  Set linux_target.
960         * inf-child.c (inf_child_ops): Delete.
961         (inf_child_fetch_inferior_registers)
962         (inf_child_store_inferior_registers): Delete.
963         (inf_child_post_attach, inf_child_prepare_to_store): Refactor as
964         methods of inf_child_target.
965         (inf_child_target::supports_terminal_ours)
966         (inf_child_target::terminal_init)
967         (inf_child_target::terminal_inferior)
968         (inf_child_target::terminal_ours_for_output)
969         (inf_child_target::terminal_ours, inf_child_target::interrupt)
970         (inf_child_target::pass_ctrlc, inf_child_target::terminal_info):
971         New.
972         (inf_child_open, inf_child_disconnect, inf_child_close)
973         (inf_child_mourn_inferior, inf_child_maybe_unpush_target)
974         (inf_child_post_startup_inferior, inf_child_can_run)
975         (inf_child_pid_to_exec_file): Refactor as methods of
976         inf_child_target.
977         (inf_child_follow_fork): Delete.
978         (inf_child_target::can_create_inferior)
979         (inf_child_target::can_attach): New.
980         (inf_child_target::has_all_memory, inf_child_target::has_memory)
981         (inf_child_target::has_stack, inf_child_target::has_registers)
982         (inf_child_target::has_execution): New.
983         (inf_child_fileio_open, inf_child_fileio_pwrite)
984         (inf_child_fileio_pread, inf_child_fileio_fstat)
985         (inf_child_fileio_close, inf_child_fileio_unlink)
986         (inf_child_fileio_readlink, inf_child_use_agent)
987         (inf_child_can_use_agent): Refactor as methods of
988         inf_child_target.
989         (return_zero, inf_child_target): Delete.
990         (inf_child_target::inf_child_target): New.
991         * inf-child.h: Include "target.h".
992         (inf_child_target): Delete function prototype.
993         (inf_child_target): New class.
994         (inf_child_open_target, inf_child_mourn_inferior)
995         (inf_child_maybe_unpush_target): Delete.
996         * inf-ptrace.c (inf_ptrace_target::~inf_ptrace_target): New.
997         (inf_ptrace_follow_fork, inf_ptrace_insert_fork_catchpoint)
998         (inf_ptrace_remove_fork_catchpoint, inf_ptrace_create_inferior)
999         (inf_ptrace_post_startup_inferior, inf_ptrace_mourn_inferior)
1000         (inf_ptrace_attach, inf_ptrace_post_attach, inf_ptrace_detach)
1001         (inf_ptrace_detach_success, inf_ptrace_kill, inf_ptrace_resume)
1002         (inf_ptrace_wait, inf_ptrace_xfer_partial)
1003         (inf_ptrace_thread_alive, inf_ptrace_files_info)
1004         (inf_ptrace_pid_to_str, inf_ptrace_auxv_parse): Refactor as
1005         methods of inf_ptrace_target.
1006         (inf_ptrace_target): Delete function.
1007         * inf-ptrace.h: Include "inf-child.h".
1008         (inf_ptrace_target): Delete function declaration.
1009         (inf_ptrace_target): New class.
1010         (inf_ptrace_trad_target, inf_ptrace_detach_success): Delete.
1011         * linux-nat.c (linux_target): New.
1012         (linux_ops, linux_ops_saved, super_xfer_partial): Delete.
1013         (linux_nat_target::~linux_nat_target): New.
1014         (linux_child_post_attach, linux_child_post_startup_inferior)
1015         (linux_child_follow_fork, linux_child_insert_fork_catchpoint)
1016         (linux_child_remove_fork_catchpoint)
1017         (linux_child_insert_vfork_catchpoint)
1018         (linux_child_remove_vfork_catchpoint)
1019         (linux_child_insert_exec_catchpoint)
1020         (linux_child_remove_exec_catchpoint)
1021         (linux_child_set_syscall_catchpoint, linux_nat_pass_signals)
1022         (linux_nat_create_inferior, linux_nat_attach, linux_nat_detach)
1023         (linux_nat_resume, linux_nat_stopped_by_watchpoint)
1024         (linux_nat_stopped_data_address)
1025         (linux_nat_stopped_by_sw_breakpoint)
1026         (linux_nat_supports_stopped_by_sw_breakpoint)
1027         (linux_nat_stopped_by_hw_breakpoint)
1028         (linux_nat_supports_stopped_by_hw_breakpoint, linux_nat_wait)
1029         (linux_nat_kill, linux_nat_mourn_inferior)
1030         (linux_nat_xfer_partial, linux_nat_thread_alive)
1031         (linux_nat_update_thread_list, linux_nat_pid_to_str)
1032         (linux_nat_thread_name, linux_child_pid_to_exec_file)
1033         (linux_child_static_tracepoint_markers_by_strid)
1034         (linux_nat_is_async_p, linux_nat_can_async_p)
1035         (linux_nat_supports_non_stop, linux_nat_always_non_stop_p)
1036         (linux_nat_supports_multi_process)
1037         (linux_nat_supports_disable_randomization, linux_nat_async)
1038         (linux_nat_stop, linux_nat_close, linux_nat_thread_address_space)
1039         (linux_nat_core_of_thread, linux_nat_filesystem_is_local)
1040         (linux_nat_fileio_open, linux_nat_fileio_readlink)
1041         (linux_nat_fileio_unlink, linux_nat_thread_events): Refactor as
1042         methods of linux_nat_target.
1043         (linux_nat_wait_1, linux_xfer_siginfo, linux_proc_xfer_partial)
1044         (linux_proc_xfer_spu, linux_nat_xfer_osdata): Remove target_ops
1045         parameter.
1046         (check_stopped_by_watchpoint): Adjust.
1047         (linux_xfer_partial): Delete.
1048         (linux_target_install_ops, linux_target, linux_nat_add_target):
1049         Delete.
1050         (linux_nat_target::linux_nat_target): New.
1051         * linux-nat.h: Include "inf-ptrace.h".
1052         (linux_nat_target): New.
1053         (linux_target, linux_target_install_ops, linux_nat_add_target):
1054         Delete function declarations.
1055         (linux_target): Declare global.
1056         * linux-thread-db.c (thread_db_target): New.
1057         (thread_db_target::thread_db_target): New.
1058         (thread_db_ops): Delete.
1059         (the_thread_db_target): New.
1060         (thread_db_detach, thread_db_wait, thread_db_mourn_inferior)
1061         (thread_db_update_thread_list, thread_db_pid_to_str)
1062         (thread_db_extra_thread_info)
1063         (thread_db_thread_handle_to_thread_info)
1064         (thread_db_get_thread_local_address, thread_db_get_ada_task_ptid)
1065         (thread_db_resume): Refactor as methods of thread_db_target.
1066         (init_thread_db_ops): Delete.
1067         (_initialize_thread_db): Remove reference to init_thread_db_ops.
1068         * x86-linux-nat.c: Don't include "linux-nat.h".
1069         (super_post_startup_inferior): Delete.
1070         (x86_linux_nat_target::~x86_linux_nat_target): New.
1071         (x86_linux_child_post_startup_inferior)
1072         (x86_linux_read_description, x86_linux_enable_btrace)
1073         (x86_linux_disable_btrace, x86_linux_teardown_btrace)
1074         (x86_linux_read_btrace, x86_linux_btrace_conf): Refactor as
1075         methods of x86_linux_nat_target.
1076         (x86_linux_create_target): Delete.  Bits folded ...
1077         (x86_linux_add_target): ... here.  Now takes a linux_nat_target
1078         pointer.
1079         * x86-linux-nat.h: Include "linux-nat.h" and "x86-nat.h".
1080         (x86_linux_nat_target): New class.
1081         (x86_linux_create_target): Delete.
1082         (x86_linux_add_target): Now takes a linux_nat_target pointer.
1083         * x86-nat.c (x86_insert_watchpoint, x86_remove_watchpoint)
1084         (x86_region_ok_for_watchpoint, x86_stopped_data_address)
1085         (x86_stopped_by_watchpoint, x86_insert_hw_breakpoint)
1086         (x86_remove_hw_breakpoint, x86_can_use_hw_breakpoint)
1087         (x86_stopped_by_hw_breakpoint): Remove target_ops parameter and
1088         make extern.
1089         (x86_use_watchpoints): Delete.
1090         * x86-nat.h: Include "breakpoint.h" and "target.h".
1091         (x86_use_watchpoints): Delete.
1092         (x86_can_use_hw_breakpoint, x86_region_ok_for_hw_watchpoint)
1093         (x86_stopped_by_watchpoint, x86_stopped_data_address)
1094         (x86_insert_watchpoint, x86_remove_watchpoint)
1095         (x86_insert_hw_breakpoint, x86_remove_hw_breakpoint)
1096         (x86_stopped_by_hw_breakpoint): New declarations.
1097         (x86_nat_target): New template class.
1098
1099         * ppc-linux-nat.c (ppc_linux_nat_target): New class.
1100         (the_ppc_linux_nat_target): New.
1101         (ppc_linux_fetch_inferior_registers)
1102         (ppc_linux_can_use_hw_breakpoint)
1103         (ppc_linux_region_ok_for_hw_watchpoint)
1104         (ppc_linux_ranged_break_num_registers)
1105         (ppc_linux_insert_hw_breakpoint, ppc_linux_remove_hw_breakpoint)
1106         (ppc_linux_insert_mask_watchpoint)
1107         (ppc_linux_remove_mask_watchpoint)
1108         (ppc_linux_can_accel_watchpoint_condition)
1109         (ppc_linux_insert_watchpoint, ppc_linux_remove_watchpoint)
1110         (ppc_linux_stopped_data_address, ppc_linux_stopped_by_watchpoint)
1111         (ppc_linux_watchpoint_addr_within_range)
1112         (ppc_linux_masked_watch_num_registers)
1113         (ppc_linux_store_inferior_registers, ppc_linux_auxv_parse)
1114         (ppc_linux_read_description): Refactor as methods of
1115         ppc_linux_nat_target.
1116         (_initialize_ppc_linux_nat): Adjust.  Set linux_target.
1117
1118         * procfs.c (procfs_xfer_partial): Delete forward declaration.
1119         (procfs_target): New class.
1120         (the_procfs_target): New.
1121         (procfs_target): Delete function.
1122         (procfs_auxv_parse, procfs_attach, procfs_detach)
1123         (procfs_fetch_registers, procfs_store_registers, procfs_wait)
1124         (procfs_xfer_partial, procfs_resume, procfs_pass_signals)
1125         (procfs_files_info, procfs_kill_inferior, procfs_mourn_inferior)
1126         (procfs_create_inferior, procfs_update_thread_list)
1127         (procfs_thread_alive, procfs_pid_to_str)
1128         (procfs_can_use_hw_breakpoint, procfs_stopped_by_watchpoint)
1129         (procfs_stopped_data_address, procfs_insert_watchpoint)
1130         (procfs_remove_watchpoint, procfs_region_ok_for_hw_watchpoint)
1131         (proc_find_memory_regions, procfs_info_proc)
1132         (procfs_make_note_section): Refactor as methods of procfs_target.
1133         (_initialize_procfs): Adjust.
1134         * sol-thread.c (sol_thread_target): New class.
1135         (sol_thread_ops): Now a sol_thread_target.
1136         (sol_thread_detach, sol_thread_resume, sol_thread_wait)
1137         (sol_thread_fetch_registers, sol_thread_store_registers)
1138         (sol_thread_xfer_partial, sol_thread_mourn_inferior)
1139         (sol_thread_alive, solaris_pid_to_str, sol_update_thread_list)
1140         (sol_get_ada_task_ptid): Refactor as methods of sol_thread_target.
1141         (init_sol_thread_ops): Delete.
1142         (_initialize_sol_thread): Adjust.  Remove references to
1143         init_sol_thread_ops and complete_target_initialization.
1144
1145         * windows-nat.c (windows_nat_target): New class.
1146         (windows_fetch_inferior_registers)
1147         (windows_store_inferior_registers, windows_resume, windows_wait)
1148         (windows_attach, windows_detach, windows_pid_to_exec_file)
1149         (windows_files_info, windows_create_inferior)
1150         (windows_mourn_inferior, windows_interrupt, windows_kill_inferior)
1151         (windows_close, windows_pid_to_str, windows_xfer_partial)
1152         (windows_get_tib_address, windows_get_ada_task_ptid)
1153         (windows_thread_name, windows_thread_alive): Refactor as
1154         windows_nat_target methods.
1155         (do_initial_windows_stuff): Adjust.
1156         (windows_target): Delete function.
1157         (_initialize_windows_nat): Adjust.
1158
1159         * darwin-nat.c (darwin_resume, darwin_wait_to, darwin_interrupt)
1160         (darwin_mourn_inferior, darwin_kill_inferior)
1161         (darwin_create_inferior, darwin_attach, darwin_detach)
1162         (darwin_pid_to_str, darwin_thread_alive, darwin_xfer_partial)
1163         (darwin_pid_to_exec_file, darwin_get_ada_task_ptid)
1164         (darwin_supports_multi_process): Refactor as darwin_nat_target
1165         methods.
1166         (darwin_resume_to, darwin_files_info): Delete.
1167         (_initialize_darwin_inferior): Rename to ...
1168         (_initialize_darwin_nat): ... this.  Adjust to C++ification.
1169         * darwin-nat.h: Include "inf-child.h".
1170         (darwin_nat_target): New class.
1171         (darwin_complete_target): Delete.
1172         * i386-darwin-nat.c (i386_darwin_nat_target): New class.
1173         (darwin_target): New.
1174         (i386_darwin_fetch_inferior_registers)
1175         (i386_darwin_store_inferior_registers): Refactor as methods of
1176         darwin_nat_target.
1177         (darwin_complete_target): Delete, with ...
1178         (_initialize_i386_darwin_nat): ... bits factored out here.
1179
1180         * alpha-linux-nat.c (alpha_linux_nat_target): New class.
1181         (the_alpha_linux_nat_target): New.
1182         (alpha_linux_register_u_offset): Refactor as
1183         alpha_linux_nat_target method.
1184         (_initialize_alpha_linux_nat): Adjust.
1185         * linux-nat-trad.c (inf_ptrace_register_u_offset): Delete.
1186         (inf_ptrace_fetch_register, inf_ptrace_fetch_registers)
1187         (inf_ptrace_store_register, inf_ptrace_store_registers): Refact as
1188         methods of linux_nat_trad_target.
1189         (linux_trad_target): Delete.
1190         * linux-nat-trad.h (linux_trad_target): Delete function.
1191         (linux_nat_trad_target): New class.
1192         * mips-linux-nat.c (mips_linux_nat_target): New class.
1193         (super_fetch_registers, super_store_registers, super_close):
1194         Delete.
1195         (the_mips_linux_nat_target): New.
1196         (mips64_linux_regsets_fetch_registers)
1197         (mips64_linux_regsets_store_registers)
1198         (mips64_linux_fetch_registers, mips64_linux_store_registers)
1199         (mips_linux_register_u_offset, mips_linux_read_description)
1200         (mips_linux_can_use_hw_breakpoint)
1201         (mips_linux_stopped_by_watchpoint)
1202         (mips_linux_stopped_data_address)
1203         (mips_linux_region_ok_for_hw_watchpoint)
1204         (mips_linux_insert_watchpoint, mips_linux_remove_watchpoint)
1205         (mips_linux_close): Refactor as methods of mips_linux_nat.
1206         (_initialize_mips_linux_nat): Adjust to C++ification.
1207
1208         * aix-thread.c (aix_thread_target): New class.
1209         (aix_thread_ops): Now an aix_thread_target.
1210         (aix_thread_detach, aix_thread_resume, aix_thread_wait)
1211         (aix_thread_fetch_registers, aix_thread_store_registers)
1212         (aix_thread_xfer_partial, aix_thread_mourn_inferior)
1213         (aix_thread_thread_alive, aix_thread_pid_to_str)
1214         (aix_thread_extra_thread_info, aix_thread_get_ada_task_ptid):
1215         Refactor as methods of aix_thread_target.
1216         (init_aix_thread_ops): Delete.
1217         (_initialize_aix_thread): Remove references to init_aix_thread_ops
1218         and complete_target_initialization.
1219         * rs6000-nat.c (rs6000_xfer_shared_libraries): Delete.
1220         (rs6000_nat_target): New class.
1221         (the_rs6000_nat_target): New.
1222         (rs6000_fetch_inferior_registers, rs6000_store_inferior_registers)
1223         (rs6000_xfer_partial, rs6000_wait, rs6000_create_inferior)
1224         (rs6000_xfer_shared_libraries): Refactor as rs6000_nat_target methods.
1225         (super_create_inferior): Delete.
1226         (_initialize_rs6000_nat): Adjust to C++ification.
1227
1228         * arm-linux-nat.c (arm_linux_nat_target): New class.
1229         (the_arm_linux_nat_target): New.
1230         (arm_linux_fetch_inferior_registers)
1231         (arm_linux_store_inferior_registers, arm_linux_read_description)
1232         (arm_linux_can_use_hw_breakpoint, arm_linux_insert_hw_breakpoint)
1233         (arm_linux_remove_hw_breakpoint)
1234         (arm_linux_region_ok_for_hw_watchpoint)
1235         (arm_linux_insert_watchpoint, arm_linux_remove_watchpoint)
1236         (arm_linux_stopped_data_address, arm_linux_stopped_by_watchpoint)
1237         (arm_linux_watchpoint_addr_within_range): Refactor as methods of
1238         arm_linux_nat_target.
1239         (_initialize_arm_linux_nat): Adjust to C++ification.
1240
1241         * aarch64-linux-nat.c (aarch64_linux_nat_target): New class.
1242         (the_aarch64_linux_nat_target): New.
1243         (aarch64_linux_fetch_inferior_registers)
1244         (aarch64_linux_store_inferior_registers)
1245         (aarch64_linux_child_post_startup_inferior)
1246         (aarch64_linux_read_description)
1247         (aarch64_linux_can_use_hw_breakpoint)
1248         (aarch64_linux_insert_hw_breakpoint)
1249         (aarch64_linux_remove_hw_breakpoint)
1250         (aarch64_linux_insert_watchpoint, aarch64_linux_remove_watchpoint)
1251         (aarch64_linux_region_ok_for_hw_watchpoint)
1252         (aarch64_linux_stopped_data_address)
1253         (aarch64_linux_stopped_by_watchpoint)
1254         (aarch64_linux_watchpoint_addr_within_range)
1255         (aarch64_linux_can_do_single_step): Refactor as methods of
1256         aarch64_linux_nat_target.
1257         (super_post_startup_inferior): Delete.
1258         (_initialize_aarch64_linux_nat): Adjust to C++ification.
1259
1260         * hppa-linux-nat.c (hppa_linux_nat_target): New class.
1261         (the_hppa_linux_nat_target): New.
1262         (hppa_linux_fetch_inferior_registers)
1263         (hppa_linux_store_inferior_registers): Refactor as methods of
1264         hppa_linux_nat_target.
1265         (_initialize_hppa_linux_nat): Adjust to C++ification.
1266
1267         * ia64-linux-nat.c (ia64_linux_nat_target): New class.
1268         (the_ia64_linux_nat_target): New.
1269         (ia64_linux_insert_watchpoint, ia64_linux_remove_watchpoint)
1270         (ia64_linux_stopped_data_address)
1271         (ia64_linux_stopped_by_watchpoint, ia64_linux_fetch_registers)
1272         (ia64_linux_store_registers, ia64_linux_xfer_partial): Refactor as
1273         ia64_linux_nat_target methods.
1274         (super_xfer_partial): Delete.
1275         (_initialize_ia64_linux_nat): Adjust to C++ification.
1276
1277         * m32r-linux-nat.c (m32r_linux_nat_target): New class.
1278         (the_m32r_linux_nat_target): New.
1279         (m32r_linux_fetch_inferior_registers)
1280         (m32r_linux_store_inferior_registers): Refactor as
1281         m32r_linux_nat_target methods.
1282         (_initialize_m32r_linux_nat): Adjust to C++ification.
1283
1284         * m68k-linux-nat.c (m68k_linux_nat_target): New class.
1285         (the_m68k_linux_nat_target): New.
1286         (m68k_linux_fetch_inferior_registers)
1287         (m68k_linux_store_inferior_registers): Refactor as
1288         m68k_linux_nat_target methods.
1289         (_initialize_m68k_linux_nat): Adjust to C++ification.
1290
1291         * s390-linux-nat.c (s390_linux_nat_target): New class.
1292         (the_s390_linux_nat_target): New.
1293         (s390_linux_fetch_inferior_registers)
1294         (s390_linux_store_inferior_registers, s390_stopped_by_watchpoint)
1295         (s390_insert_watchpoint, s390_remove_watchpoint)
1296         (s390_can_use_hw_breakpoint, s390_insert_hw_breakpoint)
1297         (s390_remove_hw_breakpoint, s390_region_ok_for_hw_watchpoint)
1298         (s390_auxv_parse, s390_read_description): Refactor as methods of
1299         s390_linux_nat_target.
1300         (_initialize_s390_nat): Adjust to C++ification.
1301
1302         * sparc-linux-nat.c (sparc_linux_nat_target): New class.
1303         (the_sparc_linux_nat_target): New.
1304         (_initialize_sparc_linux_nat): Adjust to C++ification.
1305         * sparc-nat.c (sparc_fetch_inferior_registers)
1306         (sparc_store_inferior_registers): Remove target_ops parameter.
1307         * sparc-nat.h (sparc_fetch_inferior_registers)
1308         (sparc_store_inferior_registers): Remove target_ops parameter.
1309         * sparc64-linux-nat.c (sparc64_linux_nat_target): New class.
1310         (the_sparc64_linux_nat_target): New.
1311         (_initialize_sparc64_linux_nat): Adjust to C++ification.
1312
1313         * spu-linux-nat.c (spu_linux_nat_target): New class.
1314         (the_spu_linux_nat_target): New.
1315         (spu_child_post_startup_inferior, spu_child_post_attach)
1316         (spu_child_wait, spu_fetch_inferior_registers)
1317         (spu_store_inferior_registers, spu_xfer_partial)
1318         (spu_can_use_hw_breakpoint): Refactor as spu_linux_nat_target
1319         methods.
1320         (_initialize_spu_nat): Adjust to C++ification.
1321
1322         * tilegx-linux-nat.c (tilegx_linux_nat_target): New class.
1323         (the_tilegx_linux_nat_target): New.
1324         (fetch_inferior_registers, store_inferior_registers):
1325         Refactor as methods.
1326         (_initialize_tile_linux_nat): Adjust to C++ification.
1327
1328         * xtensa-linux-nat.c (xtensa_linux_nat_target): New class.
1329         (the_xtensa_linux_nat_target): New.
1330         (xtensa_linux_fetch_inferior_registers)
1331         (xtensa_linux_store_inferior_registers): Refactor as
1332         xtensa_linux_nat_target methods.
1333         (_initialize_xtensa_linux_nat): Adjust to C++ification.
1334
1335         * fbsd-nat.c (USE_SIGTRAP_SIGINFO): Delete.
1336         (fbsd_pid_to_exec_file, fbsd_find_memory_regions)
1337         (fbsd_find_memory_regions, fbsd_info_proc, fbsd_xfer_partial)
1338         (fbsd_thread_alive, fbsd_pid_to_str, fbsd_thread_name)
1339         (fbsd_update_thread_list, fbsd_resume, fbsd_wait)
1340         (fbsd_stopped_by_sw_breakpoint)
1341         (fbsd_supports_stopped_by_sw_breakpoint, fbsd_follow_fork)
1342         (fbsd_insert_fork_catchpoint, fbsd_remove_fork_catchpoint)
1343         (fbsd_insert_vfork_catchpoint, fbsd_remove_vfork_catchpoint)
1344         (fbsd_post_startup_inferior, fbsd_post_attach)
1345         (fbsd_insert_exec_catchpoint, fbsd_remove_exec_catchpoint)
1346         (fbsd_set_syscall_catchpoint)
1347         (super_xfer_partial, super_resume, super_wait)
1348         (fbsd_supports_stopped_by_hw_breakpoint): Delete.
1349         (fbsd_handle_debug_trap): Remove target_ops parameter.
1350         (fbsd_nat_add_target): Delete.
1351         * fbsd-nat.h: Include "inf-ptrace.h".
1352         (fbsd_nat_add_target): Delete.
1353         (USE_SIGTRAP_SIGINFO): Define.
1354         (fbsd_nat_target): New class.
1355
1356         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers)
1357         (amd64bsd_store_inferior_registers): Remove target_ops parameter.
1358         (amd64bsd_target): Delete.
1359         * amd64-bsd-nat.h: New file.
1360         * amd64-fbsd-nat.c: Include "amd64-bsd-nat.h" instead of
1361         "x86-bsd-nat.h".
1362         (amd64_fbsd_nat_target): New class.
1363         (the_amd64_fbsd_nat_target): New.
1364         (amd64fbsd_read_description): Refactor as method of
1365         amd64_fbsd_nat_target.
1366         (amd64_fbsd_nat_target::supports_stopped_by_hw_breakpoint): New.
1367         (_initialize_amd64fbsd_nat): Adjust to C++ification.
1368         * amd64-nat.h (amd64bsd_target): Delete function declaration.
1369         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers)
1370         (i386bsd_store_inferior_registers): Remove target_ops parameter.
1371         (i386bsd_target): Delete.
1372         * i386-bsd-nat.h (i386bsd_target): Delete function declaration.
1373         (i386bsd_fetch_inferior_registers)
1374         (i386bsd_store_inferior_registers): Declare.
1375         (i386_bsd_nat_target): New class.
1376         * i386-fbsd-nat.c (i386_fbsd_nat_target): New class.
1377         (the_i386_fbsd_nat_target): New.
1378         (i386fbsd_resume, i386fbsd_read_description): Refactor as
1379         i386_fbsd_nat_target methods.
1380         (i386_fbsd_nat_target::supports_stopped_by_hw_breakpoint): New.
1381         (_initialize_i386fbsd_nat): Adjust to C++ification.
1382         * x86-bsd-nat.c (super_mourn_inferior): Delete.
1383         (x86bsd_mourn_inferior, x86bsd_target): Delete.
1384         (_initialize_x86_bsd_nat): Adjust to C++ification.
1385         * x86-bsd-nat.h: Include "x86-nat.h".
1386         (x86bsd_target): Delete declaration.
1387         (x86bsd_nat_target): New class.
1388
1389         * aarch64-fbsd-nat.c (aarch64_fbsd_nat_target): New class.
1390         (the_aarch64_fbsd_nat_target): New.
1391         (aarch64_fbsd_fetch_inferior_registers)
1392         (aarch64_fbsd_store_inferior_registers): Refactor as methods of
1393         aarch64_fbsd_nat_target.
1394         (_initialize_aarch64_fbsd_nat): Adjust to C++ification.
1395         * alpha-bsd-nat.c (alpha_bsd_nat_target): New class.
1396         (the_alpha_bsd_nat_target): New.
1397         (alphabsd_fetch_inferior_registers)
1398         (alphabsd_store_inferior_registers): Refactor as
1399         alpha_bsd_nat_target methods.
1400         (_initialize_alphabsd_nat): Refactor as methods of
1401         alpha_bsd_nat_target.
1402         * amd64-nbsd-nat.c: Include "amd64-bsd-nat.h".
1403         (the_amd64_nbsd_nat_target): New.
1404         (_initialize_amd64nbsd_nat): Adjust to C++ification.
1405         * amd64-obsd-nat.c: Include "amd64-bsd-nat.h".
1406         (the_amd64_obsd_nat_target): New.
1407         (_initialize_amd64obsd_nat): Adjust to C++ification.
1408         * arm-fbsd-nat.c (arm_fbsd_nat_target): New.
1409         (the_arm_fbsd_nat_target): New.
1410         (arm_fbsd_fetch_inferior_registers)
1411         (arm_fbsd_store_inferior_registers, arm_fbsd_read_description):
1412         (_initialize_arm_fbsd_nat): Refactor as methods of
1413         arm_fbsd_nat_target.
1414         (_initialize_arm_fbsd_nat): Adjust to C++ification.
1415         * arm-nbsd-nat.c (arm_netbsd_nat_target): New class.
1416         (the_arm_netbsd_nat_target): New.
1417         (armnbsd_fetch_registers, armnbsd_store_registers): Refactor as
1418         arm_netbsd_nat_target.
1419         (_initialize_arm_netbsd_nat): Adjust to C++ification.
1420         * hppa-nbsd-nat.c (hppa_nbsd_nat_target): New class.
1421         (the_hppa_nbsd_nat_target): New.
1422         (hppanbsd_fetch_registers, hppanbsd_store_registers): Refactor as
1423         hppa_nbsd_nat_target methods.
1424         (_initialize_hppanbsd_nat): Adjust to C++ification.
1425         * hppa-obsd-nat.c (hppa_obsd_nat_target): New class.
1426         (the_hppa_obsd_nat_target): New.
1427         (hppaobsd_fetch_registers, hppaobsd_store_registers): Refactor as
1428         methods of hppa_obsd_nat_target.
1429         (_initialize_hppaobsd_nat): Adjust to C++ification.  Use
1430         add_target.
1431         * i386-nbsd-nat.c (the_i386_nbsd_nat_target): New.
1432         (_initialize_i386nbsd_nat): Adjust to C++ification.  Use
1433         add_target.
1434         * i386-obsd-nat.c (the_i386_obsd_nat_target): New.
1435         (_initialize_i386obsd_nat): Use add_target.
1436         * m68k-bsd-nat.c (m68k_bsd_nat_target): New class.
1437         (the_m68k_bsd_nat_target): New.
1438         (m68kbsd_fetch_inferior_registers)
1439         (m68kbsd_store_inferior_registers): Refactor as methods of
1440         m68k_bsd_nat_target.
1441         (_initialize_m68kbsd_nat): Adjust to C++ification.
1442         * mips-fbsd-nat.c (mips_fbsd_nat_target): New class.
1443         (the_mips_fbsd_nat_target): New.
1444         (mips_fbsd_fetch_inferior_registers)
1445         (mips_fbsd_store_inferior_registers): Refactor as methods of
1446         mips_fbsd_nat_target.
1447         (_initialize_mips_fbsd_nat): Adjust to C++ification.  Use
1448         add_target.
1449         * mips-nbsd-nat.c (mips_nbsd_nat_target): New class.
1450         (the_mips_nbsd_nat_target): New.
1451         (mipsnbsd_fetch_inferior_registers)
1452         (mipsnbsd_store_inferior_registers): Refactor as methods of
1453         mips_nbsd_nat_target.
1454         (_initialize_mipsnbsd_nat): Adjust to C++ification.
1455         * mips64-obsd-nat.c (mips64_obsd_nat_target): New class.
1456         (the_mips64_obsd_nat_target): New.
1457         (mips64obsd_fetch_inferior_registers)
1458         (mips64obsd_store_inferior_registers): Refactor as methods of
1459         mips64_obsd_nat_target.
1460         (_initialize_mips64obsd_nat): Adjust to C++ification.  Use
1461         add_target.
1462         * nbsd-nat.c (nbsd_pid_to_exec_file): Refactor as method of
1463         nbsd_nat_target.
1464         * nbsd-nat.h: Include "inf-ptrace.h".
1465         (nbsd_nat_target): New class.
1466         * obsd-nat.c (obsd_pid_to_str, obsd_update_thread_list)
1467         (obsd_wait): Refactor as methods of obsd_nat_target.
1468         (obsd_add_target): Delete.
1469         * obsd-nat.h: Include "inf-ptrace.h".
1470         (obsd_nat_target): New class.
1471         * ppc-fbsd-nat.c (ppc_fbsd_nat_target): New class.
1472         (the_ppc_fbsd_nat_target): New.
1473         (ppcfbsd_fetch_inferior_registers)
1474         (ppcfbsd_store_inferior_registers): Refactor as methods of
1475         ppc_fbsd_nat_target.
1476         (_initialize_ppcfbsd_nat): Adjust to C++ification.  Use
1477         add_target.
1478         * ppc-nbsd-nat.c (ppc_nbsd_nat_target): New class.
1479         (the_ppc_nbsd_nat_target): New.
1480         (ppcnbsd_fetch_inferior_registers)
1481         (ppcnbsd_store_inferior_registers): Refactor as methods of
1482         ppc_nbsd_nat_target.
1483         (_initialize_ppcnbsd_nat): Adjust to C++ification.
1484         * ppc-obsd-nat.c (ppc_obsd_nat_target): New class.
1485         (the_ppc_obsd_nat_target): New.
1486         (ppcobsd_fetch_registers, ppcobsd_store_registers): Refactor as
1487         methods of ppc_obsd_nat_target.
1488         (_initialize_ppcobsd_nat): Adjust to C++ification.  Use
1489         add_target.
1490         * sh-nbsd-nat.c (sh_nbsd_nat_target): New class.
1491         (the_sh_nbsd_nat_target): New.
1492         (shnbsd_fetch_inferior_registers)
1493         (shnbsd_store_inferior_registers): Refactor as methods of
1494         sh_nbsd_nat_target.
1495         (_initialize_shnbsd_nat): Adjust to C++ification.
1496         * sparc-nat.c (sparc_xfer_wcookie): Make extern.
1497         (inf_ptrace_xfer_partial): Delete.
1498         (sparc_xfer_partial, sparc_target): Delete.
1499         * sparc-nat.h (sparc_fetch_inferior_registers)
1500         (sparc_store_inferior_registers, sparc_xfer_wcookie): Declare.
1501         (sparc_target): Delete function declaration.
1502         (sparc_target): New template class.
1503         * sparc-nbsd-nat.c (the_sparc_nbsd_nat_target): New.
1504         (_initialize_sparcnbsd_nat): Adjust to C++ification.
1505         * sparc64-fbsd-nat.c (the_sparc64_fbsd_nat_target): New.
1506         (_initialize_sparc64fbsd_nat): Adjust to C++ification.  Use
1507         add_target.
1508         * sparc64-nbsd-nat.c (the_sparc64_nbsd_nat_target): New.
1509         (_initialize_sparc64nbsd_nat): Adjust to C++ification.
1510         * sparc64-obsd-nat.c (the_sparc64_obsd_nat_target): New.
1511         (_initialize_sparc64obsd_nat): Adjust to C++ification.  Use
1512         add_target.
1513         * vax-bsd-nat.c (vax_bsd_nat_target): New class.
1514         (the_vax_bsd_nat_target): New.
1515         (vaxbsd_fetch_inferior_registers)
1516         (vaxbsd_store_inferior_registers): Refactor as vax_bsd_nat_target
1517         methods.
1518         (_initialize_vaxbsd_nat): Adjust to C++ification.
1519
1520         * bsd-kvm.c (bsd_kvm_target): New class.
1521         (bsd_kvm_ops): Now a bsd_kvm_target.
1522         (bsd_kvm_open, bsd_kvm_close, bsd_kvm_xfer_partial)
1523         (bsd_kvm_files_info, bsd_kvm_fetch_registers)
1524         (bsd_kvm_thread_alive, bsd_kvm_pid_to_str): Refactor as methods of
1525         bsd_kvm_target.
1526         (bsd_kvm_return_one): Delete.
1527         (bsd_kvm_add_target): Adjust to C++ification.
1528
1529         * nto-procfs.c (nto_procfs_target, nto_procfs_target_native)
1530         (nto_procfs_target_procfs): New classes.
1531         (procfs_open_1, procfs_thread_alive, procfs_update_thread_list)
1532         (procfs_files_info, procfs_pid_to_exec_file, procfs_attach)
1533         (procfs_post_attach, procfs_wait, procfs_fetch_registers)
1534         (procfs_xfer_partial, procfs_detach, procfs_insert_breakpoint)
1535         (procfs_remove_breakpoint, procfs_insert_hw_breakpoint)
1536         (procfs_remove_hw_breakpoint, procfs_resume)
1537         (procfs_mourn_inferior, procfs_create_inferior, procfs_interrupt)
1538         (procfs_kill_inferior, procfs_store_registers)
1539         (procfs_pass_signals, procfs_pid_to_str, procfs_can_run): Refactor
1540         as methods of nto_procfs_target.
1541         (nto_procfs_ops): Now an nto_procfs_target_procfs.
1542         (nto_native_ops): Delete.
1543         (procfs_open, procfs_native_open): Delete.
1544         (nto_native_ops): Now an nto_procfs_target_native.
1545         (init_procfs_targets): Adjust to C++ification.
1546         (procfs_can_use_hw_breakpoint, procfs_remove_hw_watchpoint)
1547         (procfs_insert_hw_watchpoint, procfs_stopped_by_watchpoint):
1548         Refactor as methods of nto_procfs_target.
1549
1550         * go32-nat.c (go32_nat_target): New class.
1551         (the_go32_nat_target): New.
1552         (go32_attach, go32_resume, go32_wait, go32_fetch_registers)
1553         (go32_store_registers, go32_xfer_partial, go32_files_info)
1554         (go32_kill_inferior, go32_create_inferior, go32_mourn_inferior)
1555         (go32_terminal_init, go32_terminal_info, go32_terminal_inferior)
1556         (go32_terminal_ours, go32_pass_ctrlc, go32_thread_alive)
1557         (go32_pid_to_str): Refactor as methods of go32_nat_target.
1558         (go32_target): Delete.
1559         (_initialize_go32_nat): Adjust to C++ification.
1560
1561         * gnu-nat.c (gnu_wait, gnu_resume, gnu_kill_inferior)
1562         (gnu_mourn_inferior, gnu_create_inferior, gnu_attach, gnu_detach)
1563         (gnu_stop, gnu_thread_alive, gnu_xfer_partial)
1564         (gnu_find_memory_regions, gnu_pid_to_str): Refactor as methods of
1565         gnu_nat_target.
1566         (gnu_target): Delete.
1567         * gnu-nat.h (gnu_target): Delete.
1568         (gnu_nat_target): New class.
1569         * i386-gnu-nat.c (gnu_base_target): New.
1570         (i386_gnu_nat_target): New class.
1571         (the_i386_gnu_nat_target): New.
1572         (_initialize_i386gnu_nat): Adjust to C++ification.
1573
1574 2018-05-02  Pedro Alves  <palves@redhat.com>
1575
1576         * bfd-target.c (target_bfd_xclose): Rename to ...
1577         (target_bfd_close): ... this.
1578         (target_bfd_reopen): Adjust.
1579         * target.c (target_close): Remove references to to_xclose.
1580         * target.h (target_ops::to_xclose): Delete.
1581         (target_ops::to_close): Update comments.
1582
1583 2018-05-02  Pedro Alves  <palves@redhat.com>
1584
1585         * alpha-linux-nat.c: Include "linux-nat-trad.h" instead of
1586         "linux-nat.h".
1587         * configure.nat (alpha-linux, linux-mips): Add linux-nat-trad.o.
1588         * inf-ptrace.c (inf_ptrace_register_u_offset)
1589         (inf_ptrace_fetch_register, inf_ptrace_fetch_registers)
1590         (inf_ptrace_store_register, inf_ptrace_store_registers)
1591         (inf_ptrace_trad_target): Move to ...
1592         * linux-nat-trad.c: ... this new file.
1593         * linux-nat-trad.h: New file.
1594         * linux-nat.c (linux_target_install_ops): Make extern.
1595         (linux_trad_target): Delete.
1596         * linux-nat.h (linux_trad_target): Delete declaration.
1597         (linux_target_install_ops): Declare.
1598         * mips-linux-nat.c: Include "linux-nat-trad.h" instead of
1599         "linux-nat.h".
1600
1601 2018-05-02  Pedro Alves  <palves@redhat.com>
1602
1603         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Don't call
1604         procfs_target/add_target here.
1605         * procfs.c (procfs_target): Make static.
1606         (_initialize_procfs): Call add_target here.
1607         * procfs.h (struct target_ops): Remove forward declaration.
1608         (procfs_target): Remove declaration.
1609         * sparc-sol2-nat.c (_initialize_sparc_sol2_nat): Delete.
1610
1611 2018-05-02  Pedro Alves  <palves@redhat.com>
1612
1613         * procfs.c (procfs_stopped_by_watchpoint)
1614         (procfs_insert_watchpoint, procfs_remove_watchpoint)
1615         (procfs_region_ok_for_hw_watchpoint, procfs_stopped_data_address):
1616         Forward declare.
1617         (procfs_use_watchpoints): Delete, move contents...
1618         (procfs_target): ... here.
1619         * procfs.h (procfs_use_watchpoints): Delete declaration.
1620         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Don't call
1621         procfs_use_watchpoints.
1622         * sparc-sol2-nat.c (_initialize_sparc_sol2_nat): Don't call
1623         procfs_use_watchpoints.
1624
1625 2018-05-02  Tom Tromey  <tom@tromey.com>
1626
1627         PR python/20084:
1628         * python/python.c (gdbpy_parameter_value): Handle var_zuinteger
1629         and var_zuinteger_unlimited.
1630         * python/py-param.c (struct parm_constant): Add PARAM_ZUINTEGER
1631         and PARAM_ZUINTEGER_UNLIMITED.
1632         (set_parameter_value): Handle var_zuinteger and
1633         var_zuinteger_unlimited.
1634         (add_setshow_generic): Likewise.
1635         (parmpy_init): Likewise.
1636
1637 2018-04-28  Dan Robertson  <danlrobertson89@gmail.com>
1638
1639         PR rust/23124
1640         * gdb/rust-exp.y (convert_params_to_types): Ensure that the params
1641         pointer is not null before dereferencing it.
1642
1643 2018-04-30  Tom Tromey  <tom@tromey.com>
1644
1645         * darwin-nat-info.c (darwin_debug_regions_recurse): Remove use of
1646         is_mi_like_p.
1647
1648 2018-04-30  Tom Tromey  <tom@tromey.com>
1649
1650         * breakpoint.c (mention): Remove use of is_mi_like_p.
1651         (print_mention_ranged_breakpoint): Likewise.
1652         * break-catch-throw.c (print_it_exception_catchpoint): Remove use
1653         of is_mi_like_p.
1654
1655 2018-04-30  Tom Tromey  <tom@tromey.com>
1656
1657         * tracepoint.c (tvariables_info_1): Remove use of is_mi_like_p.
1658
1659 2018-04-30  Tom Tromey  <tom@tromey.com>
1660
1661         * spu-tdep.c (info_spu_mailbox_list, info_spu_dma_cmdlist)
1662         (info_spu_event_command): Remove some uses of is_mi_like_p.
1663
1664 2018-04-30  Tom Tromey  <tom@tromey.com>
1665
1666         * python/py-framefilter.c (py_print_single_arg)
1667         (enumerate_locals, py_print_args, py_print_frame): Remove some
1668         uses of is_mi_like_p.
1669
1670 2018-04-30  Tom Tromey  <tom@tromey.com>
1671
1672         * ui-out.c: Update.
1673         * cli-out.h (cli_ui_out::do_is_mi_like_p): Update.
1674         * ui-out.h (ui_out::is_mi_like_p): Now const.
1675         (ui_out::do_is_mi_like_p): Now const.
1676         * mi/mi-out.h (mi_ui_out::do_is_mi_like_p): Update.
1677
1678 2018-04-30  Tom Tromey  <tom@tromey.com>
1679
1680         * varobj.c (varobj_set_visualizer): Use new_reference.
1681         * python/python.c (gdbpy_decode_line): Use new_reference.
1682         * python/py-cmd.c (cmdpy_function, cmdpy_completer_helper): Use
1683         new_reference.
1684
1685 2018-04-30  Tom Tromey  <tom@tromey.com>
1686
1687         * varobj.c (install_new_value): Use new_reference.
1688         * value.h (value_incref): Return void.  Swap intro comment with
1689         value_decref.
1690         * value.c (set_value_parent): Use new_reference.
1691         (value_incref): Return void.  Update intro comment.
1692         (release_value): Use new_reference.
1693         * dwarf2loc.c (dwarf2_evaluate_loc_desc_full): Use new_reference.
1694
1695 2018-04-30  Tom Tromey  <tom@tromey.com>
1696
1697         * symfile-mem.c (symbol_file_add_from_memory): Use new_reference.
1698         * gdb_bfd.h (new_bfd_ref): Remove.
1699         (gdb_bfd_open): Update comment.
1700         * gdb_bfd.c (gdb_bfd_open, gdb_bfd_fopen, gdb_bfd_openr)
1701         (gdb_bfd_openw, gdb_bfd_openr_iovec, gdb_bfd_record_inclusion)
1702         (gdb_bfd_fdopenr): Use new_reference.
1703         * exec.c (exec_file_attach): Use new_reference.
1704
1705 2018-04-30  Tom Tromey  <tom@tromey.com>
1706
1707         * common/gdb_ref_ptr.h (ref_ptr::new_reference): New static
1708         method.
1709
1710 2018-04-30  Tom Tromey  <tom@tromey.com>
1711
1712         * jit.c (jit_read_code_entry): Use type_align.
1713         * i386-tdep.c (i386_gdbarch_init): Don't call
1714         set_gdbarch_long_long_align_bit.
1715         * gdbarch.sh: Remove long_long_align_bit.
1716         * gdbarch.c, gdbarch.h: Rebuild.
1717         * arc-tdep.c (arc_type_align): New function.
1718         (arc_gdbarch_init): Use arc_type_align.  Don't call
1719         set_gdbarch_long_long_align_bit.
1720
1721 2018-04-30  Tom Tromey  <tom@tromey.com>
1722
1723         * rust-lang.c (rust_type_alignment): Remove.
1724         (rust_composite_type): Use type_align.
1725
1726 2018-04-30  Tom Tromey  <tom@tromey.com>
1727
1728         * NEWS: Mention Type.align.
1729         * python/py-type.c (typy_get_alignof): New function.
1730         (type_object_getset): Add "alignof".
1731
1732 2018-04-30  Tom Tromey  <tom@tromey.com>
1733
1734         PR exp/17095:
1735         * NEWS: Update.
1736         * std-operator.def (UNOP_ALIGNOF): New operator.
1737         * expprint.c (dump_subexp_body_standard) <case UNOP_ALIGNOF>:
1738         New.
1739         * eval.c (evaluate_subexp_standard) <case UNOP_ALIGNOF>: New.
1740         * c-lang.c (c_op_print_tab): Add alignof.
1741         * c-exp.y (ALIGNOF): New token.
1742         (exp): Add "ALIGNOF" production.
1743         (ident_tokens): Add _Alignof and alignof.
1744
1745 2018-04-30  Tom Tromey  <tom@tromey.com>
1746
1747         * i386-tdep.c (i386_type_align): New function.
1748         (i386_gdbarch_init): Update.
1749         * gdbarch.sh (type_align): New method.
1750         * gdbarch.c, gdbarch.h: Rebuild.
1751         * arch-utils.h (default_type_align): Declare.
1752         * arch-utils.c (default_type_align): New function.
1753         * gdbtypes.h (TYPE_ALIGN_BITS): New define.
1754         (struct type) <align_log2>: New field.
1755         <instance_flags>: Now a bitfield.
1756         (TYPE_RAW_ALIGN): New macro.
1757         (type_align, type_raw_align, set_type_align): Declare.
1758         * gdbtypes.c (type_align, type_raw_align, set_type_align): New
1759         functions.
1760         * dwarf2read.c (quirk_rust_enum): Set type alignment.
1761         (get_alignment, maybe_set_alignment): New functions.
1762         (read_structure_type, read_enumeration_type, read_array_type)
1763         (read_set_type, read_tag_pointer_type, read_tag_reference_type)
1764         (read_subrange_type, read_base_type): Set type alignment.
1765
1766 2018-04-30  Simon Marchi  <simon.marchi@ericsson.com>
1767
1768         * dwarf2read.c (read_index_from_section): Use bool.
1769
1770 2018-04-29  Fabian Groffen  <grobian@gentoo.org>
1771
1772         PR gdb/22950
1773         * proc-events.c (init_syscall_table): Guard usage os SYS_uuidsys
1774         with #ifdef.
1775
1776 2018-04-29  John Reiser  <jreiser@BitWagon.com>
1777
1778         PR build/22873
1779         * gdb/Makefile.in: (.c:.l, .c:.y): Write the target only in the
1780         last step, and do it atomically.
1781
1782 2018-04-27  Alexandre Oliva  <aoliva@redhat.com>
1783
1784         * compile/compile-c-types.c (convert_int, convert_float):
1785         Update for C FE v1.
1786
1787 2018-04-27  Tom Tromey  <tom@tromey.com>
1788
1789         PR rust/22545:
1790         * rust-lang.c (rust_inclusive_range_type_p): New function.
1791         (rust_range): Handle inclusive ranges.
1792         (rust_compute_range): Likewise.
1793         * rust-exp.y (struct rust_op) <inclusive>: New field.
1794         (DOTDOTEQ): New constant.
1795         (range_expr): Add "..=" productions.
1796         (operator_tokens): Add "..=" token.
1797         (ast_range): Add "inclusive" parameter.
1798         (convert_ast_to_expression) <case OP_RANGE>: Handle inclusive
1799         ranges.
1800         * parse.c (operator_length_standard) <case OP_RANGE>: Handle new
1801         bounds values.
1802         * expression.h (enum range_type) <NONE_BOUND_DEFAULT_EXCLUSIVE,
1803         LOW_BOUND_DEFAULT_EXCLUSIVE>: New constants.
1804         Update comments.
1805         * expprint.c (print_subexp_standard): Handle new bounds values.
1806         (dump_subexp_body_standard): Likewise.
1807
1808 2018-04-27  Tom Tromey  <tom@tromey.com>
1809
1810         * configure: Rebuild.
1811         * warning.m4 (AM_GDB_WARNINGS): Add -Wsuggest-override.
1812         * dwarf2loc.c (class dwarf_evaluate_loc_desc): Use "override", not
1813         "OVERRIDE".
1814         (class symbol_needs_eval_context): Likewise.
1815         * dwarf2read.c (mock_mapped_index::symbol_name_count)
1816         (mock_mapped_index::symbol_name_at): Use "override".  Remove
1817         "virtual".
1818         * dwarf2-frame.c (dwarf_expr_executor::get_addr_index): Use
1819         "override".
1820         (class dwarf_expr_executor): Use "override", not "OVERRIDE".
1821         * aarch64-tdep.c (instruction_reader::read): Use "override".
1822         (instruction_reader_test::read): Likewise.
1823         * arm-tdep.c (instruction_reader::read): Use "override".
1824         (instruction_reader_thumb::read): Likewise.
1825
1826 2018-04-26  Andrzej Kaczmarek  <andrzej.kaczmarek@codecoup.pl>
1827
1828         PR remote/9665
1829         * remote.c (send_g_packet): Use putpkt/getpkt/packet_check_result
1830         instead of remote_send.
1831         (remote_send): Remove.
1832
1833 2018-04-26  Pedro Alves  <palves@redhat.com>
1834
1835         * elfread.c (elf_gnu_ifunc_resolver_return_stop): Use
1836         find_function_start_sal instead of find_pc_line.
1837
1838 2018-04-26  Pedro Alves  <palves@redhat.com>
1839
1840         * breakpoint.c (set_breakpoint_location_function): Handle
1841         mst_data_gnu_ifunc.
1842         * c-exp.y (variable production): Handle mst_data_gnu_ifunc.
1843         * elfread.c (elf_symtab_read): Give data symbols with
1844         BSF_GNU_INDIRECT_FUNCTION set mst_data_gnu_ifunc type.
1845         (elf_rel_plt_read): Update comment.
1846         * linespec.c (convert_linespec_to_sals): Handle
1847         mst_data_gnu_ifunc.
1848         (minsym_found): Handle mst_data_gnu_ifunc.
1849         * minsyms.c (msymbol_is_function, minimal_symbol_reader::record)
1850         (find_solib_trampoline_target): Handle mst_data_gnu_ifunc.
1851         * parse.c (find_minsym_type_and_address): Handle
1852         mst_data_gnu_ifunc.
1853         * symmisc.c (dump_msymbols): Handle mst_data_gnu_ifunc.
1854         * symtab.c (find_gnu_ifunc): Handle mst_data_gnu_ifunc.
1855         * symtab.h (minimal_symbol_type) <mst_text_gnu_ifunc>: Update
1856         comment.
1857         <mst_data_gnu_ifunc>: New enumerator.
1858
1859 2018-04-26  Pedro Alves  <palves@redhat.com>
1860
1861         * minsyms.c (lookup_minimal_symbol_by_pc_section_1): Rename to ...
1862         (lookup_minimal_symbol_by_pc_section): ... this.  Replace
1863         'want_trampoline' parameter by a lookup_msym_prefer parameter.
1864         Handle it.
1865         (lookup_minimal_symbol_by_pc_section): Delete old implementation.
1866         (lookup_minimal_symbol_by_pc): Adjust.
1867         (in_gnu_ifunc_stub): Prefer GNU ifunc symbols.
1868         (lookup_solib_trampoline_symbol_by_pc): Adjust.
1869         * minsyms.h (lookup_msym_prefer): New enum.
1870         (lookup_minimal_symbol_by_pc_section): Replace 'want_trampoline'
1871         parameter by a lookup_msym_prefer parameter.
1872
1873 2018-04-26  Pedro Alves  <palves@redhat.com>
1874
1875         * elfread.c (elf_gnu_ifunc_record_cache): Check if the symbol name
1876         ends in "@plt" instead of looking at the symbol's section.
1877
1878 2018-04-26  Pedro Alves  <palves@redhat.com>
1879
1880         * blockframe.c (cache_pc_function_is_gnu_ifunc): Delete.  Remove
1881         all references.
1882         (find_pc_partial_function_gnu_ifunc): Rename to ...
1883         (find_pc_partial_function): ... this, and remove references to
1884         'is_gnu_ifunc_p'.
1885         (find_pc_partial_function): Delete old implementation.
1886         * symtab.h (find_pc_partial_function_gnu_ifunc): Delete.
1887
1888 2018-04-26  Pedro Alves  <palves@redhat.com>
1889
1890         * linespec.c (struct bound_minimal_symbol_search_key): New.
1891         (convert_linespec_to_sals): Sort minimal symbols earlier.  Don't
1892         skip first line if we found a GNU ifunc minimal symbol by name.
1893         (compare_msymbols): Change parameters to work with a destructured
1894         lhs minsym.
1895         (compare_msymbols_for_qsort, compare_msymbols_for_bsearch): New
1896         functions.
1897
1898 2018-04-26  Pedro Alves  <palves@redhat.com>
1899
1900         * breakpoint.c (set_breakpoint_location_function): Don't resolve
1901         ifunc targets here.  Instead, if we have an ifunc minsym, use its
1902         address/name.
1903         (add_location_to_breakpoint): Store the minsym and the objfile in
1904         the breakpoint location.
1905         * breakpoint.h (bp_location) <msymbol, objfile>: New fields.
1906         * linespec.c (minsym_found): Resolve GNU ifunc targets here.
1907         Record the minsym in the sal.
1908         * symtab.h (symtab_and_line) <msymbol>: New field.
1909
1910 2018-04-26  Pedro Alves  <palves@redhat.com>
1911
1912         * elfread.c (elf_gnu_ifunc_resolve_by_got): Don't write to *ADDR_P
1913         unless we actually resolved the ifunc.
1914
1915 2018-04-26  Pedro Alves  <palves@redhat.com>
1916
1917         * c-exp.y (variable production): Prefer ifunc minsyms over
1918         regular function symbols.
1919         * symtab.c (find_gnu_ifunc): New function.
1920         * minsyms.h (lookup_msym_prefer): New enum.
1921         (lookup_minimal_symbol_by_pc_section): Replace 'want_trampoline'
1922         parameter by a lookup_msym_prefer parameter.
1923         * symtab.h (find_gnu_ifunc): New declaration.
1924
1925 2018-04-26  Pedro Alves  <palves@redhat.com>
1926
1927         * blockframe.c (find_gnu_ifunc_target_type): New function.
1928         (find_function_type): New.
1929         * eval.c (evaluate_var_msym_value): For GNU ifunc types, always
1930         return a value with a memory address.
1931         (eval_call): For calls to GNU ifunc functions, try to find the
1932         type of the target function from the type that the resolver
1933         returns.
1934         * gdbtypes.c (objfile_type): Don't install a return type for ifunc
1935         symbols.
1936         * infcall.c (find_function_return_type): Delete.
1937         (find_function_addr): Add 'function_type' parameter.  For calls to
1938         GNU ifunc functions, try to find the type of the target function
1939         from the type that the resolver returns, and return it via
1940         FUNCTION_TYPE.
1941         (call_function_by_hand_dummy): Adjust to use the function type
1942         returned by find_function_addr.
1943         (find_function_addr): Add 'function_type' parameter and move
1944         description here.
1945         * symtab.h (find_function_type, find_gnu_ifunc_target_type): New
1946         declarations.
1947
1948 2018-04-26  Pedro Alves  <palves@redhat.com>
1949
1950         * c-exp.y (variable production): Skip finding an alias for ifunc
1951         symbols.
1952
1953 2018-04-26  Pedro Alves  <palves@redhat.com>
1954
1955         * elfread.c (elf_rel_plt_read): Look for relocations for .got.plt too.
1956
1957 2018-04-25  Pedro Alves  <palves@redhat.com>
1958
1959         * infcmd.c (kill_command): Print the pid as string, not the whole
1960         thread's ptid.  Add comment.  s/has been killed/killed/ in output
1961         message.
1962         * remote.c (remote_detach_1): Print the pid as string, not the
1963         whole thread's ptid.
1964
1965 2018-04-24  Jan Kratochvil  <jan.kratochvil@redhat.com>
1966             Sergio Durigan Junior  <sergiodj@redhat.com>
1967             Pedro Alves  <palves@redhat.com>
1968
1969         * infcmd.c (kill_command): Print message when inferior has
1970         been killed.
1971         * inferior.c (print_inferior_events): Remove 'static'.  Set as
1972         '1'.
1973         (add_inferior): Improve message printed when
1974         'print_inferior_events' is on.
1975         (exit_inferior): Remove message printed when
1976         'print_inferior_events' is on.
1977         (detach_inferior): Improve message printed when
1978         'print_inferior_events' is on.
1979         (initialize_inferiors): Use 'add_inferior_silent' to set
1980         'current_inferior_'.
1981         * inferior.h (print_inferior_events): Declare here as
1982         'extern'.
1983         * infrun.c (follow_fork_inferior): Print '[Attaching...]' or
1984         '[Detaching...]' messages when 'print_inferior_events' is on.
1985         Use 'add_thread_silent' instead of 'add_thread'.  Add '[' and ']'
1986         as prefix/suffix for messages.  Remove periods.  Fix erroneous
1987         'Detaching after fork from child...', replace it by '... from
1988         parent...'.
1989         (handle_vfork_child_exec_or_exit): Add '[' and ']' as
1990         prefix/suffix when printing 'Detaching...' messages.  Print
1991         them when 'print_inferior_events' is on.
1992         * remote.c (remote_detach_1): Print message when detaching
1993         from inferior and '!is_fork_parent'.
1994
1995 2018-04-24  Tom Tromey  <tom@tromey.com>
1996
1997         * cli-out.h: Reindent.
1998
1999 2018-04-24  Tom Tromey  <tom@tromey.com>
2000
2001         * cli-out.c (cli_ui_out::out_field_fmt): Remove.
2002         (cli_ui_out::do_field_string): Use fputs_filtered.
2003         * cli-out.h (class cli_ui_out) <out_field_fmt>: Remove.
2004
2005 2018-04-23  Tom Tromey  <tom@tromey.com>
2006
2007         * guile/scm-frame.c (gdbscm_frame_read_var): Use
2008         gdb::unique_xmalloc_ptr.
2009
2010 2018-04-23  Tom Tromey  <tom@tromey.com>
2011
2012         * configure: Rebuild.
2013
2014 2018-04-22  Rajendra SY  <rajendra.sy@gmail.com>
2015
2016         PR gdb/23095
2017         * gdb/testsuite/gdb.base/break-probes.exp: Pass shlib_load to
2018         prepare_for_testing.  Set normal_bp to r_debug_state if target
2019         is bsd.
2020
2021 2018-04-21  Pedro Alves  <palves@redhat.com>
2022             Rajendra SY  <rajendra.sy@gmail.com>
2023
2024         * inf-ptrace.c (inf_ptrace_attach): Mark the thread as executing.
2025         * remote.c (extended_remote_attach): In all-stop mode, mark the
2026         thread as executing.
2027
2028 2018-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2029
2030         * thread.c (thread_apply_all_command): Fix comment.
2031         (thread_command): Fix comment.
2032
2033 2018-04-10  Alan Hayward  <alan.hayward@arm.com>
2034
2035         * common/tdesc.h (tdesc_create_feature): Remove xml filename
2036         parameter.
2037         * features/aarch64-core.c (create_feature_aarch64_core):
2038         Regenerate.
2039         * features/aarch64-fpu.c (create_feature_aarch64_fpu):
2040         Likewise.
2041         * features/i386/32bit-avx.c (create_feature_i386_32bit_avx):
2042         Likewise.
2043         * features/i386/32bit-avx512.c
2044         (create_feature_i386_32bit_avx512): Likewise.
2045         * features/i386/32bit-core.c (create_feature_i386_32bit_core):
2046         Likewise.
2047         * features/i386/32bit-linux.c (create_feature_i386_32bit_linux):
2048         Likewise.
2049         * features/i386/32bit-mpx.c (create_feature_i386_32bit_mpx):
2050         Likewise.
2051         * features/i386/32bit-pkeys.c (create_feature_i386_32bit_pkeys):
2052         Likewise.
2053         * features/i386/32bit-sse.c (create_feature_i386_32bit_sse):
2054         Likewise.
2055         * features/i386/64bit-avx.c (create_feature_i386_64bit_avx):
2056         Likewise.
2057         * features/i386/64bit-avx512.c
2058         (create_feature_i386_64bit_avx512): Likewise.
2059         * features/i386/64bit-core.c (create_feature_i386_64bit_core):
2060         Likewise.
2061         * features/i386/64bit-linux.c (create_feature_i386_64bit_linux):
2062         Likewise.
2063         * features/i386/64bit-mpx.c (create_feature_i386_64bit_mpx):
2064         Likewise.
2065         * features/i386/64bit-pkeys.c (create_feature_i386_64bit_pkeys):
2066         Likewise.
2067         * features/i386/64bit-segments.c
2068         (create_feature_i386_64bit_segments): Likewise.
2069         * features/i386/64bit-sse.c (create_feature_i386_64bit_sse):
2070         Likewise.
2071         * features/i386/x32-core.c
2072         (create_feature_i386_x32_core): Likewise.
2073         * features/tic6x-c6xp.c (create_feature_tic6x_c6xp): Likewise.
2074         * features/tic6x-core.c (create_feature_tic6x_core): Likewise.
2075         * features/tic6x-gp.c (create_feature_tic6x_gp): Likewise.
2076         * target-descriptions.c: In generated code, don't pass xml
2077         filename.
2078
2079 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
2080
2081         * common/tdesc.c (print_xml_feature::visit_pre): Add xml parsing.
2082         (print_xml_feature::visit_post): Likewise.
2083         (print_xml_feature::visit): Likewise.
2084         * common/tdesc.h (tdesc_get_features_xml): Use const tdesc.
2085         (print_xml_feature): Add new class.
2086         * regformats/regdat.sh: Null xmltarget on feature targets.
2087         * target-descriptions.c (struct target_desc): Add xmltarget.
2088         (maintenance_check_tdesc_xml_convert): Add unittest function.
2089         (tdesc_get_features_xml): Add function to get xml.
2090         (maintenance_check_xml_descriptions): Test xml generation.
2091         * xml-tdesc.c (string_read_description_xml): Add function.
2092         * xml-tdesc.h (string_read_description_xml): Add declaration.
2093
2094 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
2095
2096         * features/Makefile: Add feature marker to targets with new style
2097         target descriptions.
2098         * regformats/aarch64.dat: Regenerate.
2099         * regformats/i386/amd64-avx-avx512-linux.dat: Likewise.
2100         * regformats/i386/amd64-avx-linux.dat: Likewise.
2101         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Likewise.
2102         * regformats/i386/amd64-avx-mpx-linux.dat: Likewise.
2103         * regformats/i386/amd64-linux.dat: Likewise.
2104         * regformats/i386/amd64-mpx-linux.dat: Likewise.
2105         * regformats/i386/amd64.dat: Likewise.
2106         * regformats/i386/i386-avx-avx512-linux.dat: Likewise.
2107         * regformats/i386/i386-avx-linux.dat: Likewise.
2108         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Likewise.
2109         * regformats/i386/i386-avx-mpx-linux.dat: Likewise.
2110         * regformats/i386/i386-linux.dat: Likewise.
2111         * regformats/i386/i386-mmx-linux.dat: Likewise.
2112         * regformats/i386/i386-mpx-linux.dat: Likewise.
2113         * regformats/i386/i386.dat: Likewise.
2114         * regformats/i386/x32-avx-avx512-linux.dat: Likewise.
2115         * regformats/i386/x32-avx-linux.dat: Likewise.
2116         * regformats/i386/x32-linux.dat: Likewise.
2117         * regformats/tic6x-c62x-linux.dat: Likewise.
2118         * regformats/tic6x-c64x-linux.dat: Likewise.
2119         * regformats/tic6x-c64xp-linux.dat: Likewise.
2120         * regformats/regdat.sh: Parse feature marker.
2121
2122 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
2123
2124         * common/tdesc.h (tdesc_architecture_name): Add new declaration.
2125         (tdesc_osabi_name): Likewise.
2126         * target-descriptions.c (tdesc_architecture_name): Add new
2127         function.
2128         (tdesc_osabi_name): Likewise.
2129
2130 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
2131
2132         * common/tdesc.c (tdesc_predefined_type): Move to here.
2133         (tdesc_named_type): Likewise.
2134         (tdesc_create_vector): Likewise.
2135         (tdesc_create_struct): Likewise.
2136         (tdesc_set_struct_size): Likewise.
2137         (tdesc_create_union): Likewise.
2138         (tdesc_create_flags): Likewise.
2139         (tdesc_create_enum): Likewise.
2140         (tdesc_add_field): Likewise.
2141         (tdesc_add_typed_bitfield): Likewise.
2142         (tdesc_add_bitfield): Likewise.
2143         (tdesc_add_flag): Likewise.
2144         (tdesc_add_enum_value): Likewise.
2145         * common/tdesc.h (struct tdesc_type_builtin): Likewise.
2146         (struct tdesc_type_vector): Likewise.
2147         (struct tdesc_type_field): Likewise.
2148         (struct tdesc_type_with_fields): Likewise.
2149         (tdesc_create_enum): Add declaration.
2150         (tdesc_add_typed_bitfield): Likewise.
2151         (tdesc_add_enum_value): Likewise.
2152         * target-descriptions.c (tdesc_type_field): Move from here.
2153         (tdesc_type_builtin): Likewise.
2154         (tdesc_type_vector): Likewise.
2155         (tdesc_type_with_fields): Likewise.
2156         (tdesc_predefined_types): Likewise.
2157         (tdesc_named_type): Likewise.
2158         (tdesc_create_vector): Likewise.
2159         (tdesc_create_struct): Likewise.
2160         (tdesc_set_struct_size): Likewise.
2161         (tdesc_create_union): Likewise.
2162         (tdesc_create_flags): Likewise.
2163         (tdesc_create_enum): Likewise.
2164         (tdesc_add_field): Likewise.
2165         (tdesc_add_typed_bitfield): Likewise.
2166         (tdesc_add_bitfield): Likewise.
2167         (tdesc_add_flag): Likewise.
2168         (tdesc_add_enum_value): Likewise.
2169         * gdb/target-descriptions.h (tdesc_create_enum): Likewise.
2170         (tdesc_add_typed_bitfield): Likewise.
2171         (tdesc_add_enum_value): Likewise.
2172
2173 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
2174
2175         * common/tdesc.c (tdesc_feature::accept): Move to here.
2176         (tdesc_feature::operator==): Likewise.
2177         (tdesc_create_reg): Likewise.
2178         * common/tdesc.h (tdesc_type_kind): Likewise.
2179         (struct tdesc_type): Likewise.
2180         (struct tdesc_feature): Likewise.
2181         * regformats/regdat.sh: Create a feature.
2182         * target-descriptions.c (tdesc_type_kind): Move from here.
2183         (tdesc_type): Likewise.
2184         (tdesc_type_up): Likewise.
2185         (tdesc_feature): Likewise.
2186         (tdesc_create_reg): Likewise.
2187
2188 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
2189
2190         * Makefile.in: Add arch/tdesc.c
2191         * common/tdesc.c: New file.
2192         * common/tdesc.h (tdesc_element_visitor): Move to here.
2193         (tdesc_element): Likewise.
2194         (tdesc_reg): Likewise.
2195         (tdesc_reg_up): Likewise.
2196         * regformats/regdef.h (reg): Add offset to constructors.
2197         * target-descriptions.c (tdesc_element_visitor): Move from here.
2198         (tdesc_element): Likewise.
2199         (tdesc_reg): Likewise.
2200         (tdesc_reg_up): Likewise.
2201
2202 2018-04-17  Tom Tromey  <tom@tromey.com>
2203
2204         * dwarf2read.c (quirk_rust_enum): Conditionally drop the
2205         discriminant field.
2206
2207 2018-04-17  Tom Tromey  <tom@tromey.com>
2208
2209         * dwarf2read.c (quirk_rust_enum): Handle unions correctly.
2210
2211 2018-04-17  Andreas Arnez  <arnez@linux.vnet.ibm.com>
2212
2213         * symtab.c (print_symbol_info): Skip printing filename and line
2214         number when `last' is NULL.
2215         (symtab_symbol_info): Use empty string instead of NULL for first
2216         invocation of print_symbol_info.
2217         (rbreak_command): Pass NULL to `last' parameter of
2218         print_symbol_info.
2219
2220 2018-04-16  Simon Marchi  <simon.marchi@ericsson.com>
2221
2222         * linux-tdep.c (linux_spu_make_corefile_notes): Return note_data
2223         instead of nullptr.
2224
2225 2018-04-16  Pedro Alves  <palves@redhat.com>
2226
2227         * MAINTAINERS (sh): Remove.
2228         * Makefile.in (ALL_TARGET_OBS): Remove sh64-tdep.o.
2229         (HFILES_NO_SRCDIR): Remove sh64-tdep.h.
2230         (ALLDEPFILES): Remove sh64-tdep.c.
2231         * NEWS: Mentions that support for SH-5/SH64 is removed.
2232         * configure.tgt (sh*-*-linux*): Remove reference to sh64-tdep.o.
2233         (sh*-*-openbsd*): Ditto.
2234         (sh64-*-elf*): Remove.
2235         (sh*): Remove.
2236         * regcache.c (cooked_write_test): Remove bfd_mach_sh5 case.
2237         * sh-linux-tdep.c: Remove reference to bfd_mach_sh5.
2238         * sh-tdep.c: No longer include "sh64-tdep.h".
2239         (sh_gdbarch_init): Remove reference to bfd_mach_sh5.
2240         * sh64-tdep.c, sh64-tdep.h: Remove files.
2241
2242 2018-04-16  Pedro Alves  <palves@redhat.com>
2243
2244         * MAINTAINERS: Remove m88k.
2245         * Makefile.in (ALL_TARGET_OBS): Remove m88k-tdep.o.
2246         (HFILES_NO_SRCDIR): Remove m88k-tdep.h.
2247         (ALLDEPFILES): Remove m88k-bsd-nat.c and m88k-tdep.c.
2248         * NEWS: Mention that support for m88k was removed.
2249         * configure.host (m88*-*-*): Remove support.
2250         * configure.nat (m88k-*-*): Remove support.
2251         * configure.tgt (m88*-*-openbsd*): Remove.
2252         * m88k-bsd-nat.c, m88k-tdep.c, m88k-tdep.h: Delete.
2253
2254 2018-04-15  Simon Marchi  <simon.marchi@polymtl.ca>
2255
2256         * configure.tgt (x86_tobjs): New variable.
2257         (amd64_tobjs, i386_tobjs): Use it.
2258
2259 2018-04-13  Andreas Arnez  <arnez@linux.vnet.ibm.com>
2260
2261         * symtab.c (print_symbol_info): Precede the symbol definition by
2262         the line number when available.
2263         * NEWS: Advertise this enhancement.
2264
2265 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
2266
2267         * NEWS (New options): announce set/show record btrace cpu.
2268         * btrace.c: Include record-btrace.h.
2269         (btrace_compute_ftrace_pt): Skip enabling errata workarounds if
2270         the vendor is unknown.
2271         (btrace_compute_ftrace_1): Add cpu parameter.  Update callers.
2272         Maybe overwrite the btrace configuration's cpu.
2273         (btrace_compute_ftrace): Add cpu parameter.  Update callers.
2274         (btrace_fetch): Add cpu parameter.  Update callers.
2275         (btrace_maint_update_pt_packets): Call record_btrace_get_cpu.
2276         Maybe overwrite the btrace configuration's cpu.  Skip enabling
2277         errata workarounds if the vendor is unknown.
2278         * python/py-record-btrace.c: Include record-btrace.h.
2279         (recpy_bt_begin, recpy_bt_end, recpy_bt_instruction_history)
2280         (recpy_bt_function_call_history): Call record_btrace_get_cpu.
2281         * record-btrace.c (record_btrace_cpu_state_kind): New.
2282         (record_btrace_cpu): New.
2283         (set_record_btrace_cpu_cmdlist): New.
2284         (record_btrace_get_cpu): New.
2285         (require_btrace_thread, record_btrace_info)
2286         (record_btrace_resume_thread): Call record_btrace_get_cpu.
2287         (cmd_set_record_btrace_cpu_none): New.
2288         (cmd_set_record_btrace_cpu_auto): New.
2289         (cmd_set_record_btrace_cpu): New.
2290         (cmd_show_record_btrace_cpu): New.
2291         (_initialize_record_btrace): Initialize set/show record btrace cpu
2292         commands.
2293         * record-btrace.h (record_btrace_get_cpu): New.
2294
2295 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
2296
2297         * record.c (set_record_command): Fix typo in message.
2298
2299 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
2300
2301         * record-btrace.c (cmd_set_record_btrace): Print sub-commands.
2302
2303 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
2304
2305         * infrun.c (process_event_stop_test): Call
2306         gdbarch_in_indirect_branch_thunk.
2307         * gdbarch.sh (in_indirect_branch_thunk): New.
2308         * gdbarch.c: Regenerated.
2309         * gdbarch.h: Regenerated.
2310         * x86-tdep.h: New.
2311         * x86-tdep.c: New.
2312         * Makefile.in (ALL_TARGET_OBS): Add x86-tdep.o.
2313         (HFILES_NO_SRCDIR): Add x86-tdep.h.
2314         (ALLDEPFILES): Add x86-tdep.c.
2315         * arch-utils.h (default_in_indirect_branch_thunk): New.
2316         * arch-utils.c (default_in_indirect_branch_thunk): New.
2317         * i386-tdep: Include x86-tdep.h.
2318         (i386_in_indirect_branch_thunk): New.
2319         (i386_elf_init_abi): Set in_indirect_branch_thunk gdbarch
2320         function.
2321         * amd64-tdep: Include x86-tdep.h.
2322         (amd64_in_indirect_branch_thunk): New.
2323         (amd64_init_abi): Set in_indirect_branch_thunk gdbarch function.
2324
2325 2018-04-12  Jan Kratochvil  <jan.kratochvil@redhat.com>
2326
2327         PR gdb/23053
2328         * dwarf-index-write.c (data_buf::grow) (write_one_signatured_type)
2329         (recursively_write_psymbols) (debug_names::recursively_write_psymbols)
2330         (debug_names::write_one_signatured_type): Fix -D_GLIBCXX_DEBUG
2331         regression.
2332
2333 2018-04-12  Tom Tromey  <tom@tromey.com>
2334
2335         * rust-lang.c (rust_print_struct_def): Remove univariant code.
2336         (rust_evaluate_subexp): Likewise.
2337
2338 2018-04-12  Pedro Alves  <palves@redhat.com>
2339
2340         * procfs.c (procfs_detach): Make forward declaration's prototype
2341         match definition's protototype.
2342         (proc_get_LDT_entry): Remove stale do_cleanups call.
2343
2344 2018-04-12  Pedro Alves  <palves@redhat.com>
2345
2346         * target.h (target_ops::to_has_exited): Delete.
2347         (target_has_exited): Delete.
2348         * target-delegates.c: Regenerate.
2349
2350 2018-04-11  Pedro Alves  <palves@redhat.com>
2351
2352         * target.c (fileio_fh_t::t): Add comment.
2353         (target_fileio_pwrite, target_fileio_pread, target_fileio_fstat)
2354         (target_fileio_close): Handle a NULL target.
2355         (invalidate_fileio_fh): New.
2356         (target_close): Call it.
2357         * remote.c (remote_hostio_send_command): No longer check whether
2358         remote_desc is open.
2359
2360 2018-04-11  Pedro Alves  <palves@redhat.com>
2361
2362         * target.c (fileio_fh_t): Make it a named struct instead of a
2363         typedef.
2364         (fileio_fh_t::is_closed): New method.
2365         (DEF_VEC_O (fileio_fh_t)): Remove.
2366         (fileio_fhandles): Now a std::vector.
2367         (is_closed_fileio_fh): Delete.
2368         (acquire_fileio_fd): Adjust.  Rename parameters.
2369         (release_fileio_fd): Adjust.
2370         (fileio_fd_to_fh): Reimplement as a function instead of a macro.
2371         (target_fileio_pwrite, target_fileio_pread, target_fileio_fstat)
2372         (target_fileio_close): Adjust.
2373
2374 2018-04-10  Simon Marchi  <simon.marchi@ericsson.com>
2375
2376         * auto-load.c (auto_load_safe_path_vec_update): Iterate by
2377         index.
2378
2379 2018-04-10  Pedro Alves  <palves@redhat.com>
2380
2381         * gdbthread.h (finish_thread_state_cleanup): Delete declaration.
2382         (scoped_finish_thread_state): New class.
2383         * infcmd.c (run_command_1): Use it instead of finish_thread_state
2384         cleanup.
2385         * infrun.c (proceed, prepare_for_detach, wait_for_inferior)
2386         (fetch_inferior_event, normal_stop): Likewise.
2387         * thread.c (finish_thread_state_cleanup): Delete.
2388
2389 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
2390             Pedro Alves  <palves@redhat.com>
2391
2392         * value.c: Include "selftest.h" and "common/array-view.h".
2393         (struct range) <operator ==>: New.
2394         (test_ranges_contain): New.
2395         (check_ranges_vector): New.
2396         (test_insert_into_bit_range_vector): New.
2397         (_initialize_values): Register selftests.
2398         * common/array-view.h (operator==, operator!=): New.
2399
2400 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
2401
2402         * common/gdb_vecs.h (unordered_remove): Add overload that takes
2403         an iterator.
2404         * inline-frame.c: Include <algorithm>.
2405         (struct inline_state): Add constructor.
2406         (inline_state_s): Remove.
2407         (DEF_VEC_O(inline_state_s)): Remove.
2408         (inline_states): Change type to std::vector.
2409         (find_inline_frame_state): Adjust to std::vector.
2410         (allocate_inline_frame_state): Remove.
2411         (clear_inline_frame_state): Adjust to std::vector.
2412         (skip_inline_frames): Adjust to std::vector.
2413
2414 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
2415
2416         * tracepoint.h (struct trace_state_variable): Add constructor.
2417         <name>: Change type to std::string.
2418         * tracepoint.c (tsv_s): Remove.
2419         (DEF_VEC_O(tsv_s)): Remove.
2420         (tvariables): Change to std::vector.
2421         (create_trace_state_variable): Adjust to std::vector.
2422         (find_trace_state_variable): Likewise.
2423         (find_trace_state_variable_by_number): Likewise.
2424         (delete_trace_state_variable): Likewise.
2425         (trace_variable_command): Adjust to std::string.
2426         (delete_trace_variable_command): Likewise.
2427         (tvariables_info_1): Adjust to std::vector.
2428         (save_trace_state_variables): Likewise.
2429         (start_tracing): Likewise.
2430         (merge_uploaded_trace_state_variables): Adjust to std::vector
2431         and std::string.
2432         * target.h (struct target_ops)
2433         <to_download_trace_state_variable>: Pass reference to
2434         trace_state_variable.
2435         * target-debug.h (target_debug_print_const_trace_state_variable_r): New.
2436         * target-delegates.c: Re-generate.
2437         * mi/mi-interp.c (mi_tsv_created): Adjust to std::string.
2438         (mi_tsv_deleted): Likewise.
2439         * mi/mi-main.c (mi_cmd_trace_frame_collected): Likewise.
2440         * remote.c (remote_download_trace_state_variable): Change
2441         pointer to reference and adjust.
2442         * make-target-delegates (parse_argtypes): Handle references.
2443         (write_function_header): Likewise.
2444         (munge_type): Likewise.
2445
2446 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
2447
2448         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
2449         string_view-selftests.c.
2450         * unittests/basic_string_view/capacity/1.cc: Adapt to GDB
2451         testsuite.
2452         * unittests/basic_string_view/cons/char/1.cc: Likewise.
2453         * unittests/basic_string_view/cons/char/2.cc: Likewise.
2454         * unittests/basic_string_view/cons/char/3.cc: Likewise.
2455         * unittests/basic_string_view/element_access/char/1.cc:
2456         Likewise.
2457         * unittests/basic_string_view/element_access/char/empty.cc:
2458         Likewise.
2459         * unittests/basic_string_view/element_access/char/front_back.cc:
2460         Likewise.
2461         * unittests/basic_string_view/inserters/char/2.cc: Likewise.
2462         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc:
2463         Likewise.
2464         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc:
2465         Likewise.
2466         * unittests/basic_string_view/modifiers/swap/char/1.cc:
2467         Likewise.
2468         * unittests/basic_string_view/operations/compare/char/1.cc:
2469         Likewise.
2470         * unittests/basic_string_view/operations/compare/char/13650.cc:
2471         Likewise.
2472         * unittests/basic_string_view/operations/copy/char/1.cc:
2473         Likewise.
2474         * unittests/basic_string_view/operations/data/char/1.cc:
2475         Likewise.
2476         * unittests/basic_string_view/operations/find/char/1.cc:
2477         Likewise.
2478         * unittests/basic_string_view/operations/find/char/2.cc:
2479         Likewise.
2480         * unittests/basic_string_view/operations/find/char/3.cc:
2481         Likewise.
2482         * unittests/basic_string_view/operations/find/char/4.cc:
2483         Likewise.
2484         * unittests/basic_string_view/operations/rfind/char/1.cc:
2485         Likewise.
2486         * unittests/basic_string_view/operations/rfind/char/2.cc:
2487         Likewise.
2488         * unittests/basic_string_view/operations/rfind/char/3.cc:
2489         Likewise.
2490         * unittests/basic_string_view/operations/substr/char/1.cc:
2491         Likewise.
2492         * unittests/basic_string_view/operators/char/2.cc: Likewise.
2493         * unittests/string_view-selftests.c: New file.
2494
2495 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
2496
2497         * unittests/basic_string_view/capacity/1.cc: New file.
2498         * unittests/basic_string_view/capacity/empty_neg.cc: New file.
2499         * unittests/basic_string_view/cons/char/1.cc: New file.
2500         * unittests/basic_string_view/cons/char/2.cc: New file.
2501         * unittests/basic_string_view/cons/char/3.cc: New file.
2502         * unittests/basic_string_view/cons/wchar_t/1.cc: New file.
2503         * unittests/basic_string_view/cons/wchar_t/2.cc: New file.
2504         * unittests/basic_string_view/cons/wchar_t/3.cc: New file.
2505         * unittests/basic_string_view/element_access/char/1.cc: New file.
2506         * unittests/basic_string_view/element_access/char/2.cc: New file.
2507         * unittests/basic_string_view/element_access/char/empty.cc: New file.
2508         * unittests/basic_string_view/element_access/char/front_back.cc: New file.
2509         * unittests/basic_string_view/element_access/wchar_t/1.cc: New file.
2510         * unittests/basic_string_view/element_access/wchar_t/2.cc: New file.
2511         * unittests/basic_string_view/element_access/wchar_t/empty.cc: New file.
2512         * unittests/basic_string_view/element_access/wchar_t/front_back.cc: New file.
2513         * unittests/basic_string_view/include.cc: New file.
2514         * unittests/basic_string_view/inserters/char/1.cc: New file.
2515         * unittests/basic_string_view/inserters/char/2.cc: New file.
2516         * unittests/basic_string_view/inserters/char/3.cc: New file.
2517         * unittests/basic_string_view/inserters/pod/10081-out.cc: New file.
2518         * unittests/basic_string_view/inserters/wchar_t/1.cc: New file.
2519         * unittests/basic_string_view/inserters/wchar_t/2.cc: New file.
2520         * unittests/basic_string_view/inserters/wchar_t/3.cc: New file.
2521         * unittests/basic_string_view/literals/types.cc: New file.
2522         * unittests/basic_string_view/literals/values.cc: New file.
2523         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc: New file.
2524         * unittests/basic_string_view/modifiers/remove_prefix/wchar_t/1.cc: New file.
2525         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc: New file.
2526         * unittests/basic_string_view/modifiers/remove_suffix/wchar_t/1.cc: New file.
2527         * unittests/basic_string_view/modifiers/swap/char/1.cc: New file.
2528         * unittests/basic_string_view/modifiers/swap/wchar_t/1.cc: New file.
2529         * unittests/basic_string_view/operations/compare/char/1.cc: New file.
2530         * unittests/basic_string_view/operations/compare/char/13650.cc: New file.
2531         * unittests/basic_string_view/operations/compare/char/2.cc: New file.
2532         * unittests/basic_string_view/operations/compare/char/70483.cc: New file.
2533         * unittests/basic_string_view/operations/compare/wchar_t/1.cc: New file.
2534         * unittests/basic_string_view/operations/compare/wchar_t/13650.cc: New file.
2535         * unittests/basic_string_view/operations/compare/wchar_t/2.cc: New file.
2536         * unittests/basic_string_view/operations/copy/char/1.cc: New file.
2537         * unittests/basic_string_view/operations/copy/wchar_t/1.cc: New file.
2538         * unittests/basic_string_view/operations/data/char/1.cc: New file.
2539         * unittests/basic_string_view/operations/data/wchar_t/1.cc: New file.
2540         * unittests/basic_string_view/operations/find/char/1.cc: New file.
2541         * unittests/basic_string_view/operations/find/char/2.cc: New file.
2542         * unittests/basic_string_view/operations/find/char/3.cc: New file.
2543         * unittests/basic_string_view/operations/find/char/4.cc: New file.
2544         * unittests/basic_string_view/operations/find/wchar_t/1.cc: New file.
2545         * unittests/basic_string_view/operations/find/wchar_t/2.cc: New file.
2546         * unittests/basic_string_view/operations/find/wchar_t/3.cc: New file.
2547         * unittests/basic_string_view/operations/find/wchar_t/4.cc: New file.
2548         * unittests/basic_string_view/operations/rfind/char/1.cc: New file.
2549         * unittests/basic_string_view/operations/rfind/char/2.cc: New file.
2550         * unittests/basic_string_view/operations/rfind/char/3.cc: New file.
2551         * unittests/basic_string_view/operations/rfind/wchar_t/1.cc: New file.
2552         * unittests/basic_string_view/operations/rfind/wchar_t/2.cc: New file.
2553         * unittests/basic_string_view/operations/rfind/wchar_t/3.cc: New file.
2554         * unittests/basic_string_view/operations/string_conversion/1.cc: New file.
2555         * unittests/basic_string_view/operations/substr/char/1.cc: New file.
2556         * unittests/basic_string_view/operations/substr/wchar_t/1.cc: New file.
2557         * unittests/basic_string_view/operators/char/2.cc: New file.
2558         * unittests/basic_string_view/operators/wchar_t/2.cc: New file.
2559         * unittests/basic_string_view/range_access/char/1.cc: New file.
2560         * unittests/basic_string_view/range_access/wchar_t/1.cc: New file.
2561         * unittests/basic_string_view/requirements/explicit_instantiation/1.cc: New file.
2562         * unittests/basic_string_view/requirements/explicit_instantiation/char/1.cc: New file.
2563         * unittests/basic_string_view/requirements/explicit_instantiation/char16_t/1.cc: New file.
2564         * unittests/basic_string_view/requirements/explicit_instantiation/char32_t/1.cc: New file.
2565         * unittests/basic_string_view/requirements/explicit_instantiation/wchar_t/1.cc: New file.
2566         * unittests/basic_string_view/requirements/typedefs.cc: New file.
2567         * unittests/basic_string_view/typedefs.cc: New file.
2568         * unittests/basic_string_view/types/1.cc: New file.
2569
2570 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
2571
2572         * common/gdb_string_view.h: Remove libstdc++ implementation
2573         details, adjust to gdb reality.
2574         * common/gdb_string_view.tcc: Likewise.
2575         * cli/cli-script.c (struct string_view): Remove.
2576         (user_args) <m_args>: Change element type to gdb::string_view.
2577         (user_args::insert_args): Adjust.
2578
2579 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
2580
2581         * common/gdb_string_view.h: New file.
2582         * common/gdb_string_view.tcc: New file.
2583
2584 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
2585
2586         * ax_cxx_compile_stdcxx.m4: Sync with upstream.
2587         * configure: Re-generate.
2588
2589 2018-04-09  Pedro Alves  <palves@redhat.com>
2590
2591         * gdbarch.sh: Include "observable.h" instead of "observer.h".
2592         (set_target_gdbarch): Call
2593         gdb::observers::architecture_changed.notify instead of
2594         observer_notify_architecture_changed.
2595
2596 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
2597
2598         * tracepoint.c (struct current_traceframe_cleanup): Remove.
2599         (do_restore_current_traceframe_cleanup): Remove.
2600         (restore_current_traceframe_cleanup_dtor): Remove.
2601         (make_cleanup_restore_current_traceframe): Remove.
2602         (scoped_restore_current_traceframe::scoped_restore_current_traceframe):
2603         New.
2604         * tracepoint.h (struct scoped_restore_current_traceframe): New.
2605         * infrun.c (fetch_inferior_event): Use
2606         scoped_restore_current_traceframe.
2607
2608 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
2609
2610         * dwarf2read.h (struct dwarf2_per_objfile) <n_type_units>:
2611         Remove.
2612         <n_allocated_type_units>: Remove.
2613         <all_type_units>: Change to std::vector.
2614         * dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile): Adjust
2615         to std::vector change.
2616         (dwarf2_per_objfile::get_cutu): Likewise.
2617         (dwarf2_per_objfile::get_tu): Likewise.
2618         (create_signatured_type_table_from_index): Likewise.
2619         (create_signatured_type_table_from_debug_names): Likewise.
2620         (dw2_symtab_iter_next): Likewise.
2621         (dw2_print_stats): Likewise.
2622         (dw2_expand_all_symtabs): Likewise.
2623         (dw2_expand_marked_cus): Likewise.
2624         (dw2_debug_names_iterator::next): Likewise.
2625         (dwarf2_initialize_objfile): Likewise.
2626         (add_signatured_type_cu_to_table): Likewise.
2627         (create_all_type_units): Likewise.
2628         (add_type_unit): Likewise.
2629         (struct tu_abbrev_offset): Add constructor.
2630         (build_type_psymtabs_1): Adjust to std::vector change.
2631         (print_tu_stats): Likewise.
2632         * dwarf-index-write.c (check_dwarf64_offsets): Likewise.
2633         (write_debug_names): Likewise.
2634
2635 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
2636
2637         * dwarf2read.h (struct dwarf2_per_objfile) <all_comp_units>: Likewise.
2638         Make an std::vector.
2639         <n_comp_units>: Remove.
2640         * dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile): Adjust
2641         to std::vector change.
2642         (dwarf2_per_objfile::get_cutu): Likewise.
2643         (dwarf2_per_objfile::get_cu): Likewise.
2644         (create_cus_from_index): Likewise.
2645         (create_addrmap_from_index): Likewise.
2646         (create_addrmap_from_aranges): Likewise.
2647         (dwarf2_read_index): Likewise.
2648         (dw2_find_last_source_symtab): Likewise.
2649         (dw2_map_symtabs_matching_filename): Likewise.
2650         (dw2_symtab_iter_next): Likewise.
2651         (dw2_print_stats): Likewise.
2652         (dw2_expand_all_symtabs): Likewise.
2653         (dw2_expand_symtabs_with_fullname): Likewise.
2654         (dw2_expand_marked_cus): Likewise.
2655         (dw2_map_symbol_filenames): Likewise.
2656         (create_cus_from_debug_names): Likewise.
2657         (dwarf2_read_debug_names): Likewise.
2658         (dw2_debug_names_iterator::next): Likewise.
2659         (dwarf2_initialize_objfile): Likewise.
2660         (set_partial_user): Likewise.
2661         (dwarf2_build_psymtabs_hard): Likewise.
2662         (read_comp_units_from_section): Remove arguments, adjust to
2663         std::vector change.
2664         (create_all_comp_units): Adjust to std::vector and
2665         read_comp_units_from_section changes.
2666         (dwarf2_find_containing_comp_unit): Adjust to std::vector
2667         change.
2668         * dwarf-index-write.c (check_dwarf64_offsets): Likewise.
2669         (psyms_seen_size): Likewise.
2670         (write_gdbindex): Likewise.
2671         (write_debug_names): Likewise.
2672
2673 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
2674
2675         * dwarf2read.c (create_cus_from_index_list): Replace objfile arg
2676         with dwarf2_per_objfile.
2677         (create_cus_from_index): Likewise.
2678         (create_signatured_type_table_from_index): Likewise.
2679         (dwarf2_read_index): Likewise.
2680         (dwarf2_initialize_objfile): Likewise.
2681         (dwarf2_fetch_die_loc_sect_off):  Get dwarf2_per_objfile from
2682         per_cu rather than get_dwarf2_per_objfile.
2683
2684 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
2685
2686         * dwarf2read.h (struct signatured_type): Forward declare.
2687         (struct dwarf2_per_objfile) <get_cutu, get_cu, get_tu>:
2688         New methods.
2689         * dwarf2read.c (dwarf2_per_objfile::get_cutu): Rename from...
2690         (dw2_get_cutu): ...this.
2691         (dwarf2_per_objfile::get_cu): Rename from...
2692         (dw2_get_cu): ...this.
2693         (dwarf2_per_objfile::get_tu): New.
2694         (create_addrmap_from_index): Adjust.
2695         (create_addrmap_from_aranges): Adjust.
2696         (dw2_find_last_source_symtab): Adjust.
2697         (dw2_map_symtabs_matching_filename): Adjust.
2698         (dw2_symtab_iter_next): Adjust.
2699         (dw2_print_stats): Adjust.
2700         (dw2_expand_all_symtabs): Adjust.
2701         (dw2_expand_symtabs_with_fullname): Adjust.
2702         (dw2_expand_marked_cus): Adjust.
2703         (dw_expand_symtabs_matching_file_matcher): Adjust.
2704         (dw2_map_symbol_filenames): Adjust.
2705         (dw2_debug_names_iterator::next): Adjust.
2706         (dwarf2_initialize_objfile): Adjust.
2707         (set_partial_user): Adjust.
2708         (dwarf2_build_psymtabs_hard): Adjust.
2709
2710 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
2711
2712         * dwarf2read.c (create_signatured_type_table_from_debug_names):
2713         Remove unused variables.
2714         (dw2_map_symtabs_matching_filename): Likewise.
2715         (dwarf2_record_block_ranges): Likewise.
2716         (dwarf2_read_addr_index): Likewise.
2717         (follow_die_offset): Likewise.
2718
2719 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
2720
2721         * progspace.c (clone_program_space): Pass SYMFILE_DEFER_BP_RESET
2722         to symbol_file_add_main.
2723
2724 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
2725
2726         PR mi/22299
2727         * mi/mi-console.c (do_fputc_async_safe): New.
2728         (mi_console_file::write_async_safe): New.
2729         (mi_console_file::flush): Adjust calls to fputstrn_unfiltered.
2730         * mi/mi-console.h (class mi_console_file) <write_async_safe>:
2731         New.
2732         * ui-file.c (ui_file::putstrn): Adjust call to
2733         fputstrn_unfiltered.
2734         * utils.c (printchar): Replace do_fputs and do_fprintf
2735         parameters by do_fputc.
2736         (fputstr_filtered): Adjust call to printchar.
2737         (fputstr_unfiltered): Likewise.
2738         (fputstrn_filtered): Likewise.
2739         (fputstrn_unfiltered): Add do_fputc parameter, pass to
2740         printchar.
2741         * utils.h (do_fputc_ftype): New typedef.
2742         (fputstrn_unfiltered): Add do_fputc parameter.
2743
2744 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
2745
2746         * regformats/i386/i386-avx.dat: Remove.
2747
2748 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
2749
2750         PR gdb/22979
2751         * amd64-tdep.c (amd64_none_init_abi): New function.
2752         (amd64_x32_none_init_abi): New function.
2753         (_initialize_amd64_tdep): Register handlers for x86-64 and
2754         x64_32 with GDB_OSABI_NONE.
2755         * osabi.c (gdbarch_init_osabi): Allow running handlers for the
2756         GDB_OSABI_NONE osabi.
2757
2758 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
2759
2760         PR gdb/22980
2761         * defs.h (enum gdb_osabi): Remove GDB_OSABI_UNINITIALIZED, add
2762         GDB_OSABI_NONE.
2763         * arch-utils.c (gdbarch_info_init): Don't set info->osabi.
2764         * osabi.c (gdb_osabi_names): Add "unknown" entry.
2765
2766 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
2767
2768         * common/byte-vector.h (char_vector): New type.
2769         * target.h (target_read_alloc): Return
2770         gdb::optional<byte_vector>.
2771         (target_read_stralloc): Return gdb::optional<char_vector>.
2772         (target_get_osdata): Return gdb::optional<char_vector>.
2773         * target.c (target_read_alloc_1): Templatize.  Replacement
2774         manual memory management with vector.
2775         (target_read_alloc): Change return type, adjust.
2776         (target_read_stralloc): Change return type, adjust.
2777         (target_get_osdata): Change return type, adjust.
2778         * auxv.c (struct auxv_info) <length>: Remove.
2779         <data>: Change type to gdb::optional<byte_vector>.
2780         (auxv_inferior_data_cleanup): Free auxv_info with delete.
2781         (get_auxv_inferior_data): Allocate auxv_info with new, adjust.
2782         (target_auxv_search): Adjust.
2783         (fprint_target_auxv): Adjust.
2784         * avr-tdep.c (avr_io_reg_read_command): Adjust.
2785         * linux-tdep.c (linux_spu_make_corefile_notes): Adjust.
2786         (linux_make_corefile_notes): Adjust.
2787         * osdata.c (get_osdata): Adjust.
2788         * remote.c (remote_get_threads_with_qxfer): Adjust.
2789         (remote_memory_map): Adjust.
2790         (remote_traceframe_info): Adjust.
2791         (btrace_read_config): Adjust.
2792         (remote_read_btrace): Adjust.
2793         (remote_pid_to_exec_file): Adjust.
2794         * solib-aix.c (solib_aix_get_library_list): Adjust.
2795         * solib-dsbt.c (decode_loadmap): Don't free buf.
2796         (dsbt_get_initial_loadmaps): Adjust.
2797         * solib-svr4.c (svr4_current_sos_via_xfer_libraries): Adjust.
2798         * solib-target.c (solib_target_current_sos): Adjust.
2799         * tracepoint.c (sdata_make_value): Adjust.
2800         * xml-support.c (xinclude_start_include): Adjust.
2801         (xml_fetch_content_from_file): Adjust.
2802         * xml-support.h (xml_fetch_another): Change return type.
2803         (xml_fetch_content_from_file): Change return type.
2804         * xml-syscall.c (xml_init_syscalls_info): Adjust.
2805         * xml-tdesc.c (file_read_description_xml): Adjust.
2806         (fetch_available_features_from_target): Change return type.
2807         (target_fetch_description_xml): Adjust.
2808         (target_read_description_xml): Adjust.
2809
2810 2018-04-06  Tom Tromey  <tom@tromey.com>
2811
2812         * value.c (~value): Update.
2813         (struct value) <contents>: Now unique_xmalloc_ptr.
2814         (value_contents_bits_eq, allocate_value_contents)
2815         (value_contents_raw, value_contents_all_raw)
2816         (value_contents_for_printing, value_contents_for_printing_const)
2817         (set_value_enclosing_type): Update.
2818
2819 2018-04-06  Tom Tromey  <tom@tromey.com>
2820
2821         * value.c (range_s): Remove typedef, VEC.
2822         (struct range): Add operator<.
2823         (range_lessthan): Remove.
2824         (ranges_contain): Change type.
2825         (~value): Update.
2826         (struct value) <unavailable, optimized_out>: Now std::vector.
2827         (value_entirely_available)
2828         (value_entirely_covered_by_range_vector)
2829         (value_entirely_unavailable, value_entirely_optimized_out):
2830         Update.
2831         (insert_into_bit_range_vector): Change argument type.
2832         (find_first_range_overlap): Likewise.
2833         (struct ranges_and_idx, value_contents_bits_eq)
2834         (require_not_optimized_out, require_available): Update.
2835         (ranges_copy_adjusted): Change argument types.
2836         (value_optimized_out, value_copy, value_fetch_lazy): Update.
2837
2838 2018-04-06  Tom Tromey  <tom@tromey.com>
2839
2840         * value.c (~value): Update.
2841         (struct value) <parent>: Now a value_ref_ptr.
2842         (value_parent, set_value_parent, value_address, value_copy):
2843         Update.
2844
2845 2018-04-06  Tom Tromey  <tom@tromey.com>
2846
2847         * value.c (struct value): Add constructor, destructor, and member
2848         initializers.
2849         (allocate_value_lazy, value_decref): Update.
2850
2851 2018-04-06  Tom Tromey  <tom@tromey.com>
2852
2853         * value.c (struct value) <released, next>: Remove.
2854         (all_values): Now a std::vector.
2855         (allocate_value_lazy): Update.
2856         (value_next): Remove.
2857         (value_mark, value_free_to_mark, release_value)
2858         (value_release_to_mark): Update.
2859
2860 2018-04-06  Tom Tromey  <tom@tromey.com>
2861
2862         * value.h (fetch_subexp_value, value_release_to_mark): Update.
2863         (free_value_chain): Remove.
2864         * value.c (free_value_chain): Remove.
2865         (value_release_to_mark): Return a std::vector.
2866         * ppc-linux-nat.c (num_memory_accesses): Change "chain" to a
2867         std::vector.
2868         (check_condition): Update.
2869         * eval.c (fetch_subexp_value): Change "val_chain" to a
2870         std::vector.
2871         * breakpoint.c (update_watchpoint): Update.
2872         (can_use_hardware_watchpoint): Change "vals" to a std::vector.
2873
2874 2018-04-06  Tom Tromey  <tom@tromey.com>
2875
2876         * value.h (free_all_values): Remove.
2877         * value.c (free_all_values): Remove.
2878
2879 2018-04-06  Tom Tromey  <tom@tromey.com>
2880
2881         * value.c (VALUE_HISTORY_CHUNK, struct value_history_chunk)
2882         (value_history_chain, value_history_count): Remove.
2883         (value_history): New global.
2884         (record_latest_value, access_value_history, show_values)
2885         (preserve_values): Update.
2886
2887 2018-04-06  Tom Tromey  <tom@tromey.com>
2888
2889         * varobj.h (struct varobj) <value>: Now a value_ref_ptr.
2890         * varobj.c (varobj_set_display_format, varobj_set_value)
2891         (install_default_visualizer, construct_visualizer)
2892         (install_new_value, ~varobj, varobj_get_value_type)
2893         (my_value_of_variable, varobj_editable_p): Update.
2894         * c-varobj.c (c_describe_child, c_value_of_variable)
2895         (cplus_number_of_children, cplus_describe_child): Update.
2896         * ada-varobj.c (ada_number_of_children, ada_name_of_child)
2897         (ada_path_expr_of_child, ada_value_of_child, ada_type_of_child)
2898         (ada_value_of_variable, ada_value_is_changeable_p): Update.
2899
2900 2018-04-06  Tom Tromey  <tom@tromey.com>
2901
2902         * printcmd.c (last_examine_address): Change type to
2903         value_ref_ptr.
2904         (do_examine, x_command): Update.
2905
2906 2018-04-06  Tom Tromey  <tom@tromey.com>
2907
2908         * value.c (release_value): Update.
2909         * breakpoint.h (struct watchpoint) <val>: Now a value_ref_ptr.
2910         (struct bpstats) <val>: Now a value_ref_ptr.
2911         * breakpoint.c (update_watchpoint, breakpoint_init_inferior)
2912         (~bpstats, bpstats, bpstat_clear_actions, watchpoint_check)
2913         (~watchpoint, print_it_watchpoint, watch_command_1)
2914         (invalidate_bp_value_on_memory_change): Update.
2915
2916 2018-04-06  Tom Tromey  <tom@tromey.com>
2917
2918         * varobj.c (varobj_clear_saved_item)
2919         (update_dynamic_varobj_children, install_new_value, ~varobj):
2920         Update.
2921         * value.h (value_incref): Move declaration earlier.
2922         (value_decref): Rename from value_free.
2923         (struct value_ref_policy): New.
2924         (value_ref_ptr): New typedef.
2925         (struct value_deleter): Remove.
2926         (gdb_value_up): Remove typedef.
2927         (release_value): Change return type.
2928         (release_value_or_incref): Remove.
2929         * value.c (set_value_parent): Update.
2930         (value_incref): Change return type.
2931         (value_decref): Rename from value_free.
2932         (value_free_to_mark, free_all_values, free_value_chain): Update.
2933         (release_value): Return value_ref_ptr.
2934         (release_value_or_incref): Remove.
2935         (record_latest_value, set_internalvar, clear_internalvar):
2936         Update.
2937         * stack.c (info_frame_command): Don't call value_free.
2938         * python/py-value.c (valpy_dealloc, valpy_new)
2939         (value_to_value_object): Update.
2940         * printcmd.c (do_examine): Update.
2941         * opencl-lang.c (lval_func_free_closure): Update.
2942         * mi/mi-main.c (register_changed_p): Don't call value_free.
2943         * mep-tdep.c (mep_frame_prev_register): Don't call value_free.
2944         * m88k-tdep.c (m88k_frame_prev_register): Don't call value_free.
2945         * m68hc11-tdep.c (m68hc11_frame_prev_register): Don't call
2946         value_free.
2947         * guile/scm-value.c (vlscm_free_value_smob)
2948         (vlscm_scm_from_value): Update.
2949         * frame.c (frame_register_unwind, frame_unwind_register_signed)
2950         (frame_unwind_register_unsigned, get_frame_register_bytes)
2951         (put_frame_register_bytes): Don't call value_free.
2952         * findvar.c (address_from_register): Don't call value_free.
2953         * dwarf2read.c (dwarf2_compute_name): Don't call value_free.
2954         * dwarf2loc.c (entry_data_value_free_closure)
2955         (value_of_dwarf_reg_entry, free_pieced_value_closure)
2956         (dwarf2_evaluate_loc_desc_full): Update.
2957         * breakpoint.c (update_watchpoint, breakpoint_init_inferior)
2958         (~bpstats, bpstats, bpstat_clear_actions, watchpoint_check)
2959         (~watchpoint, watch_command_1)
2960         (invalidate_bp_value_on_memory_change): Update.
2961         * alpha-tdep.c (alpha_register_to_value): Don't call value_free.
2962
2963 2018-04-06  Simon Marchi  <simon.marchi@polymtl.ca>
2964
2965         PR gdb/23022
2966         * warning.m4: Add -Wno-error=deprecated-register.
2967         * configure: Re-generate.
2968
2969 2018-04-05  Tom Tromey  <tom@tromey.com>
2970
2971         * linespec.h: Remove include of "vec.h".
2972
2973 2018-04-05  Tom Tromey  <tom@tromey.com>
2974
2975         * linespec.c (typep): Remove typedef.
2976         (find_methods, find_superclass_methods): Take a std::vector.
2977         (find_method): Use std::vector.
2978
2979 2018-04-05  Tom Tromey  <tom@tromey.com>
2980
2981         * utils.c (compare_strings): Remove.
2982         * utils.h (compare_strings): Remove.
2983         * objc-lang.h (find_imps): Update.
2984         * objc-lang.c (find_methods): Take a std::vector.
2985         (uniquify_strings, find_imps): Likewise.
2986         * linespec.c (find_methods): Take a std::vector.
2987         (decode_objc): Use std::vector.
2988         (add_all_symbol_names_from_pspace, find_superclass_methods): Take
2989         a std::vector.
2990         (find_method, find_function_symbols): Use std::vector.
2991
2992 2018-04-05  Tom Tromey  <tom@tromey.com>
2993
2994         * completer.c (completion_tracker::completion_tracker): Remove
2995         cast.
2996         (completion_tracker::discard_completions): Likewise.
2997         * breakpoint.c (ambiguous_names_p): Remove cast.
2998         * ada-lang.c (_initialize_ada_language): Remove cast.
2999         * utils.h (streq): Update.
3000         (streq_hash): Add new declaration.
3001         * utils.c (streq): Return bool.
3002         (streq_hash): New function.
3003
3004 2018-04-05  Tom Tromey  <tom@tromey.com>
3005
3006         * linespec.c (event_location_to_sals) <case ADDRESS_LOCATION>:
3007         Remove a string copy.
3008
3009 2018-04-05  Tom Tromey  <tom@tromey.com>
3010
3011         * linespec.c (filter_results): Use std::vector.
3012         (decode_line_2, decode_line_full): Update.
3013
3014 2018-04-05  Tom Tromey  <tom@tromey.com>
3015
3016         * linespec.c (canonical_to_fullform): Return std::string.
3017         (filter_results): Update.
3018         (struct decode_line_2_item): Add constructor.
3019         <fullform, displayform>: Now std::string.
3020         (decode_line_2_compare_items): Now a std::sort comparator.
3021         (decode_line_2): Update.
3022
3023 2018-04-05  Tom Tromey  <tom@tromey.com>
3024
3025         * linespec.c (copy_token_string): Return a unique_xmalloc_ptr.
3026         (unexpected_linespec_error): Update.
3027         (linespec_parse_basic, parse_linespec): Update.
3028
3029 2018-04-05  Tom Tromey  <tom@tromey.com>
3030
3031         * linespec.c (linespec_parse_basic): Reindent.
3032
3033 2018-04-05  Tom Tromey  <tom@tromey.com>
3034
3035         * minsyms.h (iterate_over_minimal_symbols): Update.
3036         * minsyms.c (iterate_over_minimal_symbols): Take a
3037         gdb::function_view.
3038         * linespec.c (struct collect_minsyms): Remove.
3039         (compare_msyms): Now a std::sort comparator.
3040         (add_minsym): Add parameters.
3041         (search_minsyms_for_name): Update.  Use std::vector.
3042
3043 2018-04-03  Tom Tromey  <tom@tromey.com>
3044
3045         * mipsread.c (read_alphacoff_dynamic_symtab): Use
3046         gdb::byte_vector.
3047
3048 2018-04-02  Weimin Pan  <weimin.pan@oracle.com>
3049
3050         * MAINTAINERS (Write After Approval): Add Weimin Pan.
3051
3052 2018-04-02  Weimin Pan  <weimin.pan@oracle.com>
3053
3054         PR gdb/16959
3055         * cp-valprint.c: (cp_print_static_field) Fix infinite recursion when 
3056         printing static type.
3057
3058 2018-04-01  Tom Tromey  <tom@tromey.com>
3059
3060         * rs6000-nat.c (rs6000_ptrace_ldinfo): Return a byte_vector.
3061         (rs6000_xfer_shared_libraries): Update.
3062
3063 2018-04-01  Simon Marchi  <simon.marchi@polymtl.ca>
3064
3065         * common/gdb_vecs.h (char_ptr): Remove.
3066         * tracepoint.c (encode_actions_1): Remove usage of char_ptr.
3067
3068 2018-03-30  Simon Marchi  <simon.marchi@polymtl.ca>
3069
3070         * guile/scm-utils.c (gdbscm_parse_function_args): Replace VEC
3071         with std::vector.
3072         * common/gdb_vecs.h (DEF_VEC_P (char_ptr)): Remove.
3073
3074 2018-03-30  Simon Marchi  <simon.marchi@polymtl.ca>
3075
3076         * tracepoint.h (struct uploaded_tp): Initialize fields.
3077         <actions, step_actions, cmd_strings>: Change type to
3078         std::vector<char *>.
3079         * tracepoint.c (get_uploaded_tp): Allocate with new.
3080         (free_uploaded_tps): Free with delete.
3081         (parse_tracepoint_definition): Adjust to std::vector change.
3082         * breakpoint.c (read_uploaded_action): Likewise.
3083         (create_tracepoint_from_upload): Likewise.
3084         * ctf.c (ctf_write_uploaded_tp): Likewise.
3085         (SET_ARRAY_FIELD): Likewise.
3086         * tracefile-tfile.c (tfile_write_uploaded_tp): Likewise.
3087
3088 2018-03-30  Tom Tromey  <tom@tromey.com>
3089
3090         * solib-svr4.c (lm_info_read): Use gdb::byte_vector.  Return
3091         std::unique_ptr.
3092         (svr4_keep_data_in_core): Update.
3093         (svr4_read_so_list): Update.
3094
3095 2018-03-30  Tom Tromey  <tom@tromey.com>
3096
3097         * windows-nat.c (handle_output_debug_string, handle_exception):
3098         Update.
3099         * target.h (target_read_string): Update.
3100         * target.c (target_read_string): Change "string" to
3101         unique_xmalloc_ptr.
3102         * solib-svr4.c (open_symbol_file_object, svr4_read_so_list):
3103         Update.
3104         * solib-frv.c (frv_current_sos): Update.
3105         * solib-dsbt.c (dsbt_current_sos): Update.
3106         * solib-darwin.c (darwin_current_sos): Update.
3107         * linux-thread-db.c (inferior_has_bug): Update.
3108         * expprint.c (print_subexp_standard) <case OP_OBJC_MSGCALL>:
3109         Update.  Remove alloca.
3110         * ada-lang.c (ada_main_name): Update.
3111
3112 2018-03-30  Tom Tromey  <tom@tromey.com>
3113
3114         * dwarf2read.c (struct free_dwo_file_cleanup_data): Remove.
3115         (struct dwo_file_deleter): New.
3116         (dwo_file_up): New typedef.
3117         (open_and_init_dwo_file): Use dwo_file_up.
3118         (free_dwo_file_cleanup): Remove.
3119
3120 2018-03-30  Tom Tromey  <tom@tromey.com>
3121
3122         * dwarf2read.c (free_dwo_file): Remove "objfile" parameter.
3123         (free_dwo_file_cleanup, free_dwo_file_from_slot): Update.
3124
3125 2018-03-30  Tom Tromey  <tom@tromey.com>
3126
3127         * dwarf2read.c (class free_cached_comp_units): New class.
3128         (dw2_instantiate_symtab, dwarf2_build_psymtabs_hard): Use it.
3129         (free_cached_comp_units): Remove function.
3130
3131 2018-03-30  Tom Tromey  <tom@tromey.com>
3132
3133         * utils.h (make_cleanup_unpush_target): Remove.
3134         * inf-ptrace.c (struct target_unpusher): New.
3135         (target_unpush_up) New typedef.
3136         (inf_ptrace_create_inferior, inf_ptrace_attach): Use
3137         target_unpush_up.
3138         * utils.c (do_unpush_target, make_cleanup_unpush_target): Remove.
3139
3140 2018-03-27  Tom Tromey  <tom@tromey.com>
3141
3142         * utils.c (prompt_for_continue): Use unique_xmalloc_ptr.
3143
3144 2018-03-27  Pedro Alves  <palves@redhat.com>
3145             Tom Tromey  <tom@tromey.com>
3146
3147         * top.c (class gdb_readline_wrapper_cleanup): Add constructor,
3148         destructor.  Now a class.
3149         (gdb_readline_wrapper_cleanup): Remove function.
3150         (gdb_readline_wrapper): Remove cleanups.
3151
3152 2018-03-27  Tom Tromey  <tom@tromey.com>
3153
3154         * typeprint.h (struct type_print_options) <local_typedefs,
3155         global_typedefs>: Remove "struct" keyword.
3156         (class typedef_hash_table): New class.
3157         (recursively_update_typedef_hash, add_template_parameters)
3158         (create_typedef_hash, free_typedef_hash, copy_typedef_hash)
3159         (find_typedef_in_hash): Don't declare.
3160         * typeprint.c (struct typedef_hash_table): Move to typeprint.h.
3161         (typedef_hash_table::recursively_update): Rename from
3162         recursively_update_typedef_hash.  Now a member.
3163         (typedef_hash_table::add_template_parameters): Rename from
3164         add_template_parameters.  Now a member.
3165         (typedef_hash_table::typedef_hash_table): Now a constructor;
3166         rename from create_typedef_hash.
3167         (typedef_hash_table::~typedef_hash_table): Now a destructor;
3168         rename from free_typedef_hash.
3169         (do_free_typedef_hash, make_cleanup_free_typedef_hash)
3170         (do_free_global_table): Remove.
3171         (typedef_hash_table::typedef_hash_table): New constructor; renamed
3172         from copy_type_recursive.
3173         (create_global_typedef_table): Remove.
3174         (typedef_hash_table::find_global_typedef): Now a member of
3175         typedef_hash_table.
3176         (typedef_hash_table::find_typedef): Rename from
3177         find_typedef_in_hash; now a member.
3178         (whatis_exp): Update.
3179         * extension.h (struct ext_lang_type_printers): Add constructor and
3180         destructor.
3181         (start_ext_lang_type_printers, free_ext_lang_type_printers): Don't
3182         declare.
3183         * extension.c (ext_lang_type_printers::ext_lang_type_printers):
3184         Now a constructor; rename from start_ext_lang_type_printers.
3185         (ext_lang_type_printers): Now a destructor; rename from
3186         free_ext_lang_type_printers.
3187         * c-typeprint.c (find_typedef_for_canonicalize, c_print_type_1):
3188         Update.
3189         (c_type_print_base_struct_union): Update.  Remove cleanups.
3190
3191 2018-03-27  Tom Tromey  <tom@tromey.com>
3192
3193         * dwarf-index-write.c: Include <cmath>.
3194
3195 2018-03-27  Joel Brobecker  <brobecker@adacore.com>
3196
3197         * NEWS: Add entry describing new "set|show varsize-limit" command.
3198         * ada-lang.c (_initialize_ada_language): Add "set/show varsize-limit"
3199         command.
3200         * printcmd.c (_initialize_printcmd): Add "set var" alias of
3201         "set variable".
3202
3203 2018-03-27  Simon Marchi  <simon.marchi@ericsson.com>
3204
3205         * Makefile.in (COMMON_SFILES): Add dwarf-index-common.c and
3206         dwarf-index-write.c
3207         (HFILES_NO_SRCDIR): Add dwarf-index-common.h and dwarf2read.h.
3208         * dwarf-index-common.c: New file.
3209         * dwarf-index-common.h: New file.
3210         * dwarf-index-write.c: New file.
3211         * dwarf2read.c: Include dwarf2read.h and dwarf-index-common.h.
3212         (struct dwarf2_section_info): Move from here.
3213         (dwarf2_section_info_def): Likewise.
3214         (DEF_VEC_O (dwarf2_section_info_def)): Likewise.
3215         (offset_type): Likewise.
3216         (DW2_GDB_INDEX_SYMBOL_STATIC_SET_VALUE): Likewise.
3217         (DW2_GDB_INDEX_SYMBOL_KIND_SET_VALUE): Likewise.
3218         (DW2_GDB_INDEX_CU_SET_VALUE): Likewise.
3219         (byte_swap): Likewise.
3220         (MAYBE_SWAP): Likewise.
3221         (dwarf2_per_cu_ptr): Likewise.
3222         (DEF_VEC_P (dwarf2_per_cu_ptr)): Likewise.
3223         (struct tu_stats): Likewise.
3224         (struct dwarf2_per_objfile): Likewise.
3225         (struct dwarf2_per_cu_data): Likewise.
3226         (struct signatured_type): Likewise.
3227         (sig_type_ptr): Likewise.
3228         (DEF_VEC_P (sig_type_ptr)): Likewise.
3229         (INDEX4_SUFFIX): Likewise.
3230         (INDEX5_SUFFIX): Likewise.
3231         (DEBUG_STR_SUFFIX): Likewise.
3232         (dwarf2_read_section): Make non-static.
3233         (mapped_index_string_hash): Move from here.
3234         (dwarf5_djb_hash): Likewise.
3235         (file_write): Likewise.
3236         (class data_buf): Likewise.
3237         (struct symtab_index_entry): Likewise.
3238         (struct mapped_symtab): Likewise.
3239         (find_slot): Likewise.
3240         (hash_expand): Likewise.
3241         (add_index_entry): Likewise.
3242         (uniquify_cu_indices): Likewise.
3243         (class c_str_view): Likewise.
3244         (class c_str_view_hasher): Likewise.
3245         (class vector_hasher): Likewise.
3246         (write_hash_table): Likewise.
3247         (psym_index_map): Likewise.
3248         (struct addrmap_index_data): Likewise.
3249         (add_address_entry): Likewise.
3250         (add_address_entry_worker): Likewise.
3251         (write_address_map): Likewise.
3252         (symbol_kind): Likewise.
3253         (write_psymbols): Likewise.
3254         (struct signatured_type_index_data): Likewise.
3255         (write_one_signatured_type): Likewise.
3256         (recursively_count_psymbols): Likewise.
3257         (recursively_write_psymbols): Likewise.
3258         (class debug_names): Likewise.
3259         (check_dwarf64_offsets): Likewise.
3260         (psyms_seen_size): Likewise.
3261         (write_gdbindex): Likewise.
3262         (write_debug_names): Likewise.
3263         (assert_file_size): Likewise.
3264         (write_psymtabs_to_index): Likewise.
3265         (save_gdb_index_command): Likewise.
3266         (_initialize_dwarf2_read): Don't register the "save gdb-index"
3267         command.
3268         * dwarf2read.h: New file.
3269
3270 2018-03-27  Joel Brobecker  <brobecker@adacore.com>
3271
3272         PR gdb/22670
3273         * dwarf2read.c (dwarf2_physname): Do not return the demangled
3274         symbol name if the CU's language stores symbol names in linkage
3275         format.
3276         * language.h (struct language_defn)
3277         <la_store_sym_names_in_linkage_form_p>: New field.  Adjust
3278         all instances of this struct.
3279
3280 2018-03-26  Tom Tromey  <tom@tromey.com>
3281
3282         * stack.c (backtrace_command_1): Remove verbose code.
3283
3284 2018-03-26  Tom Tromey  <tom@tromey.com>
3285
3286         * python/py-framefilter.c (py_print_type): Don't catch
3287         exceptions.  Return void.
3288         (py_print_value): Likewise.
3289         (py_print_single_arg): Likewise.
3290         (enumerate_args): Don't catch exceptions.
3291         (py_print_args): Likewise.
3292         (py_print_frame): Likewise.
3293         (gdbpy_apply_frame_filter): Catch exceptions here.
3294
3295 2018-03-26  Tom Tromey  <tom@tromey.com>
3296
3297         * stack.c (_initialize_stack): Remove trailing newlines from help
3298         text.  Add "Usage" line to "backtrace" help.
3299
3300 2018-03-26  Tom Tromey  <tom@tromey.com>
3301
3302         PR python/16486:
3303         * python/py-framefilter.c (py_print_args): Call wrap_hint.
3304
3305 2018-03-26  Tom Tromey  <tom@tromey.com>
3306
3307         * python/py-framefilter.c (py_print_single_arg): Return
3308         EXT_LANG_BT_ERROR from catch.
3309
3310 2018-03-26  Tom Tromey  <tom@tromey.com>
3311
3312         PR backtrace/15584:
3313         * stack.c (backtrace_command_1): Move some code into no-filters
3314         "if".
3315
3316 2018-03-26  Tom Tromey  <tom@tromey.com>
3317
3318         * python/py-framefilter.c (throw_quit_or_print_exception): New
3319         function.
3320         (gdbpy_apply_frame_filter): Use it.
3321
3322 2018-03-26  Tom Tromey  <tom@tromey.com>
3323
3324         PR cli/17716:
3325         * python/py-framefilter.c (py_print_type, py_print_value)
3326         (enumerate_args, py_print_args, gdbpy_apply_frame_filter): Use
3327         RETURN_MASK_ERROR.
3328
3329 2018-03-26  Tom Tromey  <tom@tromey.com>
3330
3331         * python/py-framefilter.c (enumerate_args): Use
3332         gdb::unique_xmalloc_ptr.
3333
3334 2018-03-26  Tom Tromey  <tom@tromey.com>
3335
3336         * python/py-framefilter.c (py_print_frame): Return
3337         EXT_LANG_BT_OK.
3338         (gdbpy_apply_frame_filter): Update comment.
3339         * extension.h (enum ext_lang_bt_status) <EXT_LANG_BT_COMPLETED>:
3340         Remove.
3341         <EXT_LANG_BT_NO_FILTERS>: Change value.
3342
3343 2018-03-26  Tom Tromey  <tom@tromey.com>
3344
3345         PR backtrace/15582:
3346         * stack.c (backtrace_command): Parse "hide" argument.
3347         * python/py-framefilter.c (py_print_frame): Handle PRINT_HIDE.
3348         * extension.h (enum frame_filter_flags) <PRINT_HIDE>: New
3349         constant.
3350
3351 2018-03-26  Tom Tromey  <tom@tromey.com>
3352
3353         * stack.c (backtrace_command_1): Remove "show_locals" parameter,
3354         add "flags".
3355         (backtrace_command): Remove "fulltrace", add "flags".
3356
3357 2018-03-26  Tom Tromey  <tom@tromey.com>
3358
3359         * stack.c (backtrace_command): Rewrite command line parsing.
3360
3361 2018-03-26  Simon Marchi  <simon.marchi@ericsson.com>
3362
3363         * dwarf2read.c (DEF_VEC_I(offset_type)): Remove.
3364
3365 2018-03-26  Simon Marchi  <simon.marchi@ericsson.com>
3366
3367         * filename-seen-cache.h: Add include guard.
3368
3369 2018-03-26  Keith Seitz  <keiths@redhat.com>
3370
3371         * symfile.c (place_section): Remove "struct" from section_addr_info
3372         in comment.
3373         * windows-nat.c (struct safe_symbol_file_add_args) <addrs>: Remove
3374         "struct" keyword from section_addr_info.
3375
3376 2018-03-26  Alan Hayward  <alan.hayward@arm.com>
3377
3378         * regformats/regdef.h (reg): Add constructors.
3379
3380 2018-03-25  Pedro Alves  <palves@redhat.com>
3381
3382         * eval.c (evaluate_funcall): Swap OP_VAR_MSYM_VALUE/OP_VAR_VALUE
3383         if then/else bodies in var_func_name extraction.
3384
3385 2018-03-23  Weimin Pan  <weimin.pan@oracle.com>
3386
3387         * minsyms.c (lookup_minimal_symbol_and_objfile): Use
3388         lookup_minimal_symbol() to find symbol entry.
3389         * minsyms.h (lookup_minimal_symbol_and_objfile): Update comment.
3390
3391 2018-03-23  Keith Seitz  <keiths@redhat.com>
3392
3393         PR c++/22968
3394         * dwarf2read.c (scan_partial_symbols): Scan structs/classes for
3395         nested type definitions for C++, too.
3396
3397 2018-03-23  Tom Tromey  <tom@tromey.com>
3398
3399         * machoread.c (struct oso_el): Add a constructor.  Don't define as
3400         a typedef.
3401         (macho_register_oso): Remove.
3402         (macho_symtab_read): Take a std::vector.
3403         (oso_el_compare_name): Now a std::sort comparator.
3404         (macho_symfile_read_all_oso): Take a std::vector.
3405         (macho_symfile_read): Use std::vector.  Remove cleanups.
3406
3407 2018-03-22  Tom Tromey  <tom@tromey.com>
3408
3409         * record-full.c (record_full_exec_insn): Use gdb::byte_vector.
3410         (record_full_goto_bookmark): Use std::string.
3411
3412 2018-03-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
3413
3414         PR tdep/18295
3415         * rs6000-tdep.c (skip_prologue): Match both stwux and stdux
3416         a single mask.
3417
3418 2018-03-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
3419
3420         * rs6000-tdep.c (store_insn_p): New function.
3421         (skip_prologue): New variable alloca_reg_offset. Set lr_reg
3422         and cr_reg to their unshifted values. Use store_insn_p to
3423         match LR saves using either R1 or fdata->alloca_reg. Use
3424         store_insn_p to match CR saves. Set alloca_reg_offset
3425         when alloca_reg and framep are set. Remove lr_reg shift
3426         when assigning to fdata->lr_register.
3427
3428 2018-03-22  Andreas Arnez  <arnez@linux.vnet.ibm.com>
3429
3430         * linux-tdep.c (linux_info_proc): For "info proc cmdline", print
3431         command line args instead of emitting a warning.
3432
3433 2018-03-22  Simon Marchi  <simon.marchi@polymtl.ca>
3434
3435         * tracepoint.h (struct static_tracepoint_marker): Initialize
3436         fields, define default constructor, move constructor and move
3437         assignment, disable the rest.
3438         <str_id, extra>: Make std::string.
3439         (release_static_tracepoint_marker): Remove.
3440         (free_current_marker): Remove.
3441         * tracepoint.c (free_current_marker): Remove.
3442         (parse_static_tracepoint_marker_definition): Adjust to
3443         std::string, use new hex2str overload.
3444         (release_static_tracepoint_marker): Remove.
3445         (print_one_static_tracepoint_marker): Get marker by reference
3446         and adjust to std::string.
3447         (info_static_tracepoint_markers_command): Adjust to std::vector
3448         changes
3449         * target.h (static_tracepoint_marker_p): Remove typedef.
3450         (DEF_VEC_P(static_tracepoint_marker_p)): Remove.
3451         (struct target_ops) <to_static_tracepoint_marker_at>: Return
3452         bool.
3453         <to_static_tracepoint_markers_by_strid>: Return std::vector.
3454         * target-debug.h
3455         (target_debug_print_VEC_static_tracepoint_marker_p_p): Remove.
3456         (target_debug_print_std_vector_static_tracepoint_marker): New.
3457         (target_debug_print_struct_static_tracepoint_marker_p): Rename
3458         to...
3459         (target_debug_print_static_tracepoint_marker_p): ... this.
3460         * target-delegates.c: Re-generate.
3461         * breakpoint.h (struct tracepoint) <static_trace_marker_id>:
3462         Make std::string.
3463         * breakpoint.c (init_breakpoint_sal): Adjust to std::string.
3464         (decode_static_tracepoint_spec): Adjust to std::vector.
3465         (tracepoint_print_one_detail): Adjust to std::string.
3466         (strace_marker_decode_location): Adjust to std::string.
3467         (update_static_tracepoint): Adjust to std::string, remove call
3468         to release_static_tracepoint_marker.
3469         * linux-nat.c (linux_child_static_tracepoint_markers_by_strid):
3470         Adjust to std::vector.
3471         * remote.c (remote_static_tracepoint_marker_at): Return bool.
3472         (remote_static_tracepoint_markers_by_strid): Adjust to
3473         std::vector.
3474         * common/rsp-low.h (hex2str): New overload with explicit count
3475         of bytes.
3476         * common/rsp-low.c (hex2str): New overload with explicit count
3477         of bytes.
3478         * unittests/rsp-low-selftests.c (test_hex2str): New function.
3479         (_initialize_rsp_low_selftests): Add test_hex2str test.
3480         * unittests/tracepoint-selftests.c
3481         (test_parse_static_tracepoint_marker_definition): Adjust to
3482         std::string.
3483
3484 2018-03-22  Simon Marchi  <simon.marchi@polymtl.ca>
3485
3486         * tracepoint.c (parse_static_tracepoint_marker_definition):
3487         Consider case where the definition is followed by more
3488         definitions.
3489         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
3490         tracepoint-selftests.c.
3491         * unittests/tracepoint-selftests.c: New.
3492
3493 2018-03-21  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
3494
3495         * MAINTAINERS (Write After Approval): Add Pedro Franco de
3496         Carvalho.
3497
3498 2018-03-20  Stephen Roberts  <stephen.roberts@arm.com>
3499
3500         * symtab.c (find_pc_sect_line): fixed indentation.
3501
3502 2018-03-20  Stephen Roberts  <stephen.roberts@arm.com>
3503
3504         * symtab.c (find_pc_sect_line): now uses binary search.
3505
3506 2018-03-19  Tom Tromey  <tom@tromey.com>
3507
3508         * rust-exp.y (struct_expr_tail, struct_expr_list): Add plain
3509         "IDENT" production.
3510
3511 2018-03-19  Pedro Alves  <palves@redhat.com>
3512             Tom Tromey  <tom@tromey.com>
3513
3514         * unittests/observable-selftests.c: New file.
3515         * common/observable.h: New file.
3516         * observable.h: New file.
3517         * ada-lang.c, ada-tasks.c, agent.c, aix-thread.c, annotate.c,
3518         arm-tdep.c, auto-load.c, auxv.c, break-catch-syscall.c,
3519         breakpoint.c, bsd-uthread.c, cli/cli-interp.c, cli/cli-setshow.c,
3520         corefile.c, dummy-frame.c, event-loop.c, event-top.c, exec.c,
3521         extension.c, frame.c, gdbarch.c, guile/scm-breakpoint.c,
3522         infcall.c, infcmd.c, inferior.c, inflow.c, infrun.c, jit.c,
3523         linux-tdep.c, linux-thread-db.c, m68klinux-tdep.c,
3524         mi/mi-cmd-break.c, mi/mi-interp.c, mi/mi-main.c, objfiles.c,
3525         ppc-linux-nat.c, ppc-linux-tdep.c, printcmd.c, procfs.c,
3526         python/py-breakpoint.c, python/py-finishbreakpoint.c,
3527         python/py-inferior.c, python/py-unwind.c, ravenscar-thread.c,
3528         record-btrace.c, record-full.c, record.c, regcache.c, remote.c,
3529         riscv-tdep.c, sol-thread.c, solib-aix.c, solib-spu.c, solib.c,
3530         spu-multiarch.c, spu-tdep.c, stack.c, symfile-mem.c, symfile.c,
3531         symtab.c, thread.c, top.c, tracepoint.c, tui/tui-hooks.c,
3532         tui/tui-interp.c, valops.c: Update all users.
3533         * tui/tui-hooks.c (tui_bp_created_observer)
3534         (tui_bp_deleted_observer, tui_bp_modified_observer)
3535         (tui_inferior_exit_observer, tui_before_prompt_observer)
3536         (tui_normal_stop_observer, tui_register_changed_observer):
3537         Remove.
3538         (tui_observers_token): New global.
3539         (attach_or_detach, tui_attach_detach_observers): New functions.
3540         (tui_install_hooks, tui_remove_hooks): Use
3541         tui_attach_detach_observers.
3542         * record-btrace.c (record_btrace_thread_observer): Remove.
3543         (record_btrace_thread_observer_token): New global.
3544         * observer.sh: Remove.
3545         * observer.c: Rename to observable.c.
3546         * observable.c (namespace gdb_observers): Define new objects.
3547         (observer_debug): Move into gdb_observers namespace.
3548         (struct observer, struct observer_list, xalloc_observer_list_node)
3549         (xfree_observer_list_node, generic_observer_attach)
3550         (generic_observer_detach, generic_observer_notify): Remove.
3551         (_initialize_observer): Update.
3552         Don't include observer.inc.
3553         * Makefile.in (generated_files): Remove observer.h, observer.inc.
3554         (clean mostlyclean): Likewise.
3555         (observer.h, observer.inc): Remove targets.
3556         (SUBDIR_UNITTESTS_SRCS): Add observable-selftests.c.
3557         (COMMON_SFILES): Use observable.c, not observer.c.
3558         * .gitignore: Remove observer.h.
3559
3560 2018-03-18  Tom Tromey  <tom@tromey.com>
3561
3562         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Use
3563         gdb::def_vector.
3564         (bfd_lookup_symbol_from_dyn_symtab): Likewise.
3565
3566 2018-03-17  Tom Tromey  <tom@tromey.com>
3567
3568         * auto-load.c (auto_load_objfile_script_1): Use std::string.
3569
3570 2018-03-17  Tom Tromey  <tom@tromey.com>
3571
3572         * target.c (class scoped_target_fd): New.
3573         (target_fileio_close_cleanup): Remove.
3574         (target_fileio_read_alloc_1): Use scoped_target_fd.
3575
3576 2018-03-16  Simon Marchi  <simon.marchi@polymtl.ca>
3577
3578         * silent-rules.mk: New.
3579         * Makefile.in: Include silent-rules.mk
3580         (srcdir, VPATH, top_srcdir): Move up.
3581         (COMPILE): Add ECHO_CXX.
3582         (test-cp-name-parser$(EXEEXT)): Add ECHO_CXXLD.
3583         (init.c): Add ECHO_INIT_C.
3584         (gdb$(EXEEXT)): Add SILENCE and ECHO_CXXLD.
3585         (version.c): Add ECHO_GEN.
3586         (printcmd.o): Add ECHO_CXX.
3587         (target-float.o): Add ECHO_CXX.
3588         (ada-exp.o): Add ECHO_CXX.
3589         (stamp-xml): Add SILENCE and ECHO_GEN_XML_BUILTIN.
3590         (insight$(EXEEXT)): Add ECHO_CXXLD.
3591         * gnulib/configure.ac: Add AM_SILENT_RULES.
3592         * gnulib/aclocal.m4: Re-generate.
3593         * gnulib/configure: Re-generate.
3594         * gnulib/import/Makefile.in: Re-generate.
3595
3596 2018-03-16  Tom Tromey  <tom@tromey.com>
3597
3598         * xcoffread.c (xcoff_symfile_offsets): Change type of "addrs".
3599         * utils.h (make_cleanup_free_section_addr_info): Don't declare.
3600         * utils.c (do_free_section_addr_info)
3601         (make_cleanup_free_section_addr_info): Remove.
3602         * symfile.h (struct other_sections): Add constructor.
3603         (struct section_addr_info): Remove.
3604         (section_addr_info): New typedef.
3605         (struct sym_fns) <sym_offsets>: Change type of parameter.
3606         (build_section_addr_info_from_objfile)
3607         (relative_addr_info_to_section_offsets, addr_info_make_relative)
3608         (default_symfile_offsets, symbol_file_add)
3609         (symbol_file_add_from_bfd)
3610         (build_section_addr_info_from_section_table): Update.
3611         (alloc_section_addr_info, free_section_addr_info): Don't declare.
3612         * symfile.c (alloc_section_addr_info): Remove.
3613         (build_section_addr_info_from_section_table): Change return type.
3614         Update.
3615         (build_section_addr_info_from_bfd)
3616         (build_section_addr_info_from_objfile): Likewise.
3617         (free_section_addr_info): Remove.
3618         (relative_addr_info_to_section_offsets): Change type of "addrs".
3619         (addrs_section_compar): Now a std::sort comparator.
3620         (addrs_section_sort): Change return type.
3621         (addr_info_make_relative): Change type of "addrs".  Update.
3622         (default_symfile_offsets, syms_from_objfile_1)
3623         (syms_from_objfile, symbol_file_add_with_addrs): Likewise.
3624         (symbol_file_add_separate): Update.
3625         (symbol_file_add): Change type of "addrs".  Update.
3626         (add_symbol_file_command): Update.  Remove cleanups.
3627         * symfile-mem.c (symbol_file_add_from_memory): Update.  Remove
3628         cleanups.
3629         * symfile-debug.c (debug_sym_offsets): Change type of "info".
3630         * solib.c (solib_read_symbols): Update.
3631         * objfiles.c (objfile_relocate): Update.  Remove cleanups.
3632         * machoread.c (macho_symfile_offsets): Update.
3633         * jit.c (jit_bfd_try_read_symtab): Update.
3634
3635 2018-03-15  Simon Marchi  <simon.marchi@polymtl.ca>
3636
3637         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
3638         unittests/utils-selftests.c.
3639         * unittests/utils-selftests.c: New file.
3640
3641 2018-03-14  Tom Tromey  <tom@tromey.com>
3642
3643         PR cli/14977:
3644         * printcmd.c (printf_c_string, printf_wide_c_string): Special case
3645         for NULL.
3646
3647 2018-03-14  Tom Tromey  <tom@tromey.com>
3648
3649         PR cli/19918:
3650         * printcmd.c (printf_pointer): Allow "-" in format.
3651
3652 2018-03-14  Tom Tromey  <tom@tromey.com>
3653
3654         * printcmd.c (_initialize_printcmd): Add usage to printf.
3655
3656 2018-03-14  Yao Qi  <qiyao@sourceware.org>
3657
3658         * MAINTAINERS: Update my email address.
3659
3660 2018-03-13  Tom Tromey  <tom@tromey.com>
3661
3662         * machoread.c (macho_check_dsym): Change filenamep to a
3663         std::string*.
3664         (macho_symfile_read): Update.
3665         * symfile.c (load_command): Use std::string.
3666
3667 2018-03-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3668
3669         * riscv-tdep.c (riscv_sw_breakpoint_from_kind): Add localization
3670         to error message string.
3671         (riscv_register_name): Use xsnprintf instead of sprintf.
3672         (riscv_insn::fetch_instruction): Use gdb_assert instead of
3673         internal_error.
3674         (riscv_print_arg_location): Use gdb_assert_not_reached instead of
3675         error.
3676         (riscv_push_dummy_call): Likewise.
3677
3678 2018-03-12  Tom Tromey  <tom@tromey.com>
3679
3680         * rs6000-aix-tdep.c (rs6000_aix_core_xfer_shared_libraries_aix):
3681         Use gdb::byte_vector.
3682         * arm-tdep.c (arm_exidx_new_objfile): Use gdb::byte_vector.
3683
3684 2018-03-12  Yao Qi  <yao.qi@linaro.org>
3685
3686         * ia64-libunwind-tdep.c (libunwind_get_reg_special): Change
3687         parameter type to readable_regcache.
3688         * ia64-libunwind-tdep.h (libunwind_get_reg_special): Update
3689         the declaration.
3690
3691 2018-03-11  Tom Tromey  <tom@tromey.com>
3692
3693         * dwarf2read.c (struct nextfield): Add initializers.
3694         (struct nextfnfield): Remove.
3695         (struct fnfieldlist): Add initializers.  Remove "length" and
3696         "head", use std::vector.
3697         (struct decl_field_list): Remove.
3698         (struct field_info): Add initializers.
3699         <fields, baseclasses>: Now std::vector.
3700         <nbaseclasses, nfnfields, typedef_field_list_count,
3701         nested_types_list_count>: Remove.
3702         (dwarf2_add_field, dwarf2_add_type_defn)
3703         (dwarf2_attach_fields_to_type, dwarf2_add_member_fn)
3704         (dwarf2_attach_fn_fields_to_type, handle_struct_member_die)
3705         (process_structure_scope): Update.
3706
3707 2018-03-11  Tom Tromey  <tom@tromey.com>
3708
3709         * dwarf2read.c (sort_tu_by_abbrev_offset): Change to be suitable
3710         for use by std::sort.
3711         (build_type_psymtabs_1): Use std::vector.
3712
3713 2018-03-09  Eli Zaretskii  <eliz@gnu.org>
3714
3715         * top.c (print_gdb_configuration): Reflect LIBIPT, LIBMEMCHECK,
3716         and LIBMPFR in the printed configuration.
3717
3718 2018-03-08  Tom Tromey  <tom@tromey.com>
3719
3720         * source.c (get_filename_and_charpos): Use scoped_fd.
3721         * nto-procfs.c (procfs_open_1): Use scoped_fd.
3722         (procfs_pidlist): Likewise.
3723         * procfs.c (proc_get_LDT_entry): Use scoped_fd.
3724         (iterate_over_mappings): Likewise.
3725
3726 2018-03-08  Tom Tromey  <tom@tromey.com>
3727
3728         * infcall.c (struct call_return_meta_info)
3729         <stack_temporaries_enabled>: Remove.
3730         (get_call_return_value, call_function_by_hand_dummy): Update.
3731         * thread.c (disable_thread_stack_temporaries): Remove.
3732         (enable_thread_stack_temporaries): Remove.
3733         (thread_stack_temporaries_enabled_p): Return bool.
3734         (push_thread_stack_temporary, value_in_thread_stack_temporaries)
3735         (get_last_thread_stack_temporary): Update.
3736         * eval.c (evaluate_subexp): Update.
3737         * gdbthread.h (class enable_thread_stack_temporaries): Now a
3738         class, not a function.
3739         (value_ptr, value_vec): Remove typedefs.
3740         (class thread_info) <stack_temporaries_enabled>: Now bool.
3741         <stack_temporaries>: Now a std::vector.
3742         (thread_stack_temporaries_enabled_p)
3743         (value_in_thread_stack_temporaries): Return bool.
3744
3745 2018-03-08  Simon Marchi  <simon.marchi@ericsson.com>
3746
3747         * remote.c (putpkt_binary): Fix omitted bytes reporting.
3748         (getpkt_or_notif_sane_1): Likewise.
3749
3750 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
3751
3752         * build-id.c (build_id_to_debug_bfd): Use std::string.
3753
3754 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
3755
3756         * build-id.c (find_separate_debug_file_by_buildid): Return
3757         std::string.
3758         * build-id.h (find_separate_debug_file_by_buildid): Return
3759         std::string.
3760         * coffread.c (coff_symfile_read): Adjust to std::string.
3761         * elfread.c (elf_symfile_read): Adjust to std::string.
3762         * symfile.c (separate_debug_file_exists): Change parameter to
3763         std::string.
3764         (find_separate_debug_file): Return std::string.
3765         (find_separate_debug_file_by_debuglink): Return std::string.
3766         * symfile.h (find_separate_debug_file_by_debuglink): Return
3767         std::string.
3768
3769 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
3770
3771         * common/xml-utils.c (xml_escape_text): Move code to...
3772         (xml_escape_text_append): ... this new function.
3773         * common/xml-utils.h (xml_escape_text_append): New declaration.
3774         * unittests/xml-utils-selftests.c (test_xml_escape_text_append):
3775         New function.
3776         (_initialize_xml_utils): register test_xml_escape_text_append as
3777         a selftest.
3778
3779 2018-03-07  Alan Hayward  <alan.hayward@arm.com>
3780
3781         * defs.h: Remove MAX_REGISTER_SIZE.
3782         * regcache.c (init_regcache_descr): Remove MAX_REGISTER_SIZE
3783         asserts.
3784         * python/py-unwind.c (pyuw_sniffer): Likewise.
3785
3786 2018-03-07  Tom Tromey  <tom@tromey.com>
3787
3788         * linux-tdep.c (linux_info_proc): Update.
3789         * target.h (struct target_ops) <to_fileio_readlink>: Return
3790         optional<string>.
3791         (target_fileio_readlink): Return optional<string>.
3792         * remote.c (remote_hostio_readlink): Return optional<string>.
3793         * inf-child.c (inf_child_fileio_readlink): Return
3794         optional<string>.
3795         * target.c (target_fileio_readlink): Return optional<string>.
3796
3797 2018-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3798
3799         * regcache.c (cooked_read_test): Add riscv to the list of
3800         architectures that have a save_reggroup.
3801
3802 2018-03-07  Andreas Arnez  <arnez@linux.vnet.ibm.com>
3803
3804         * gnu-v3-abi.c (gnuv3_rtti_type): Add early exit if the given
3805         value is not a dynamic class object.
3806
3807 2018-03-06  Tom Tromey  <tom@tromey.com>
3808
3809         * rust-exp.y: Formatting fixes.
3810
3811 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3812
3813         * riscv-tdep.c (riscv_register_name): Remove target description
3814         support.
3815         (riscv_gdbarch_init): Remove target description check.
3816
3817 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3818
3819         * riscv-tdep.c: Remove 'Contributed by ...' lines from header
3820         comment.
3821         * riscv-tdep.h: Likewise.
3822
3823 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3824
3825         * riscv-tdep.c (riscv_pseudo_register_read): Delete.
3826         (riscv_pseudo_register_write): Delete.
3827         (riscv_gdbarch_init): Remove all use of pseudo registers.
3828
3829 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
3830
3831         * record-btrace.c (btrace_print_lines): Replace cleanup
3832         parameter with RAII equivalents.
3833         (btrace_insn_history): Replace cleanup with RAII equivalents.
3834         * ui-out.h (make_cleanup_ui_out_list_begin_end,
3835         make_cleanup_ui_out_tuple_begin_end): Remove.
3836         * ui-out.c (struct ui_out_end_cleanup_data, do_cleanup_end,
3837         make_cleanup_ui_out_end, make_cleanup_ui_out_tuple_begin_end,
3838         make_cleanup_ui_out_list_begin_end): Remove.
3839
3840 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
3841
3842         * record-btrace.c (record_btrace_maybe_mark_async_event): Change
3843         parameter types to std::vector.  Use bool.
3844         (record_btrace_wait): Replace VEC(tp_t) with
3845         std::vector<thread_info *>.
3846         * common/gdb_vecs.h (unordered_remove, ordered_remove): New.
3847
3848 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
3849
3850         * record-btrace.c (record_btrace_disable_callback): Remove.
3851         (struct scoped_btrace_disable): New.
3852         (record_btrace_open): Use scoped_btrace_disable.
3853
3854 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3855
3856         * riscv-tdep.c (riscv_return_value): Change type to ULONGEST for
3857         reading values from registers.
3858
3859 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3860
3861         * riscv-tdep.c (riscv_push_dummy_call): Use core_addr_to_string_nz
3862         where appropriate.
3863
3864 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3865
3866         * riscv-tdep.c (riscv_print_arg_location): Add header comment,
3867         change parameter type.  Use GDB's print functions, and use
3868         core_addr_to_string where appropriate.
3869         (riscv_push_dummy_call): Use core_addr_to_string where
3870         appropriate, update call to riscv_print_arg_location, and reindent
3871         a few lines.
3872         (riscv_return_value): Update call to riscv_print_arg_location.
3873
3874 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3875             Tim Newsome <tim@sifive.com>
3876             Albert Ou <a0u@eecs.berkeley.edu>
3877             Darius Rad <darius@bluespec.com>
3878
3879         * Makefile.in (ALL_TARGET_OBS): Add riscv-tdep.o
3880         (HFILES_NO_SRCDIR): Add riscv-tdep.h.
3881         (ALLDEPFILES): Add riscv-tdep.c
3882         * configure.tgt: Add riscv support.
3883         * riscv-tdep.c: New file.
3884         * riscv-tdep.h: New file.
3885         * NEWS: Mention new target.
3886         * MAINTAINERS: Add entry for riscv.
3887
3888 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3889
3890         * amd64-tdep.c (amd64_classify_aggregate): Ignore zero sized
3891         fields within aggregates.
3892
3893 2018-03-04  Simon Marchi  <simon.marchi@polymtl.ca>
3894
3895         * record-btrace.c (btrace_print_lines): Change type of flags to
3896         gdb_disassembly_flags.
3897
3898 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
3899
3900         * fbsd-nat.c: Include "inf-ptrace.h".
3901         (USE_SIGTRAP_SIGINFO): Conditionally define.
3902         [USE_SIGTRAP_SIGINFO] (fbsd_handle_debug_trap): New function.
3903         (fbsd_wait) [USE_SIGTRAP_SIGINFO]: Call "fbsd_handle_debug_trap".
3904         [USE_SIGTRAP_SIGINFO] (fbsd_stopped_by_sw_breakpoint): New
3905         function.
3906         [USE_SIGTRAP_SIGINFO] (fbsd_supports_stopped_by_sw_breakpoint):
3907         Likewise.
3908         [USE_SIGTRAP_SIGINFO] (fbsd_supports_stopped_by_hw_breakpoint):
3909         Likewise.
3910         (fbsd_nat_add_target) [USE_SIGTRAP_SIGINFO]: Set
3911         "stopped_by_sw_breakpoint", "supports_stopped_by_sw_breakpoint",
3912         "supports_stopped_by_hw_breakpoint" target methods.
3913
3914 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
3915
3916         * NEWS (Changes since GDB 8.1): Add "set/show debug fbsd-nat".
3917         * fbsd-nat.c (debug_fbsd_nat): New variable.
3918         (show_fbsd_nat_debug): New function.
3919         (fbsd_wait): Log LWP info if "debug_fbsd_nat" is enabled.
3920         (_initialize_fbsd_nat): Add "fbsd-nat" debug boolean command.
3921
3922 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
3923
3924         * nat/x86-dregs.c (x86_dr_stopped_by_hw_breakpoint): New function.
3925         * nat/x86-dregs.h (x86_dr_stopped_by_hw_breakpoint): New
3926         prototype.
3927         * x86-nat.c (x86_stopped_by_hw_breakpoint): New function.
3928         (x86_use_watchpoints): Set "stopped_by_hw_breakpoint" target
3929         method.
3930
3931 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
3932
3933         * common/gdb_vecs.c (free_char_ptr_vec): Remove.
3934         * common/gdb_vecs.h (free_char_ptr_vec): Remove.
3935
3936 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
3937
3938         * charset.c (struct charset_vector): New.
3939         (charsets): Change type to charset_vector.
3940         (find_charset_names): Adjust.
3941         (add_one): Adjust.
3942         (_initialize_charset): Adjust.
3943
3944 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
3945
3946         * progspace.h (struct program_space) <deleted_solibs>: Change
3947         type to std::vector<std::string>.
3948         * progspace.c (clear_program_space_solib_cache): Adjust.
3949         * breakpoint.c (print_solib_event): Adjust.
3950         (check_status_catch_solib): Adjust.
3951         * solib.c (update_solib_list): Adjust.
3952         * ui-out.h (class ui_out) <field_string>: New overload.
3953         * ui-out.c (ui_out::field_string): New overload.
3954
3955 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
3956
3957         * progspace.h (struct program_space): Add constructor and
3958         destructor, initialize fields.
3959         (add_program_space): Remove.
3960         * progspace.c (add_program_space): Rename to...
3961         (program_space::program_space): ... this.
3962         (release_program_space): Rename to...
3963         (program_space::~program_space): ... this.
3964         (delete_program_space): Use delete to delete program_space.
3965         (initialize_progspace): Use new to allocate program_space.
3966         * inferior.c (add_inferior_with_spaces): Likewise.
3967         (clone_inferior_command): Likewise.
3968         * infrun.c (follow_fork_inferior): Likewise.
3969         (handle_vfork_child_exec_or_exit): Likewise.
3970
3971 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
3972
3973         * common/gdb_vecs.h (make_cleanup_free_char_ptr_vec): Remove.
3974         (delim_string_to_char_ptr_vec): Return std::vector of
3975         gdb::unique_xmalloc_ptr.
3976         (dirnames_to_char_ptr_vec_append): Take std::vector of
3977         gdb::unique_xmalloc_ptr.
3978         (dirnames_to_char_ptr_vec): Return std::vector of
3979         gdb::unique_xmalloc_ptr.
3980         * common/gdb_vecs.c (delim_string_to_char_ptr_vec_append):
3981         Take std::vector of gdb::unique_xmalloc_ptr, adjust the code.
3982         (delim_string_to_char_ptr_vec): Return an std::vector of
3983         gdb::unique_xmalloc_ptr, adjust the code.
3984         (dirnames_to_char_ptr_vec_append): Take an std::vector of
3985         gdb::unique_xmalloc_ptr, adjust the code.
3986         (dirnames_to_char_ptr_vec): Return an std::vector of
3987         gdb::unique_xmalloc_ptr, adjust the code.
3988         * auto-load.c (auto_load_safe_path_vec): Change type to
3989         std::vector of gdb::unique_xmalloc_ptr.
3990         (auto_load_expand_dir_vars): Return an std::vector of
3991         gdb::unique_xmalloc_ptr, adjust the code.
3992         (auto_load_safe_path_vec_update): Adjust.
3993         (filename_is_in_auto_load_safe_path_vec): Adjust.
3994         (auto_load_objfile_script_1): Adjust.
3995         * build-id.c (build_id_to_debug_bfd): Adjust.
3996         * linux-thread-db.c (thread_db_load_search): Adjust.
3997         * source.c (add_path): Adjust.
3998         (openp): Adjust.
3999         * symfile.c (find_separate_debug_file): Adjust.
4000         * utils.c (do_free_char_ptr_vec): Remove.
4001         (make_cleanup_free_char_ptr_vec): Remove.
4002
4003 2018-03-01  Sergio Durigan Junior  <sergiodj@redhat.com>
4004
4005         PR gdb/22907
4006         * common/pathstuff.c: Conditionally include "<windows.h>".
4007
4008 2018-03-01  Georg Sauthoff  <mail@georg.so>
4009
4010         PR gdb/22888
4011         * gcore.in: Quote variables and switch interpreter to bash.
4012
4013 2018-03-01  Tom Tromey  <tom@tromey.com>
4014
4015         * dwarf2read.c (alloc_discriminant_info): Fix default_index
4016         assertion.  Add assertion for discriminant_index.
4017         (quirk_rust_enum): Use correct base type name in univariant case.
4018
4019 2018-03-01  Simon Marchi  <simon.marchi@ericsson.com>
4020
4021         * record.c (get_call_history_modifiers): Return a
4022         record_print_flags.
4023         (cmd_record_call_history): Adjust.
4024         * record-btrace.c (record_btrace_call_history): Adjust.
4025         (record_btrace_call_history_range): Adjust.
4026         (record_btrace_call_history_from): Adjust.
4027         * target-debug.h (target_debug_print_record_print_flags): New.
4028         * target-delegates.c: Re-generate.
4029         * target.c (target_call_history): Change flags type.
4030         (target_call_history_from): Likewise.
4031         (target_call_history_range): Likewise.
4032         * target.h (struct target_ops) <target_call_history>: Likewise.
4033         (target_call_history_from): Likewise.
4034         (target_call_history_range): Likewise.
4035
4036 2018-02-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4037             Simon Marchi  <simon.marchi@polymtl.ca>
4038
4039         * common/common-utils.c: Include "sys/stat.h".
4040         (is_regular_file): Move here from "source.c"; change return
4041         type to "bool".
4042         * common/common-utils.h (is_regular_file): New prototype.
4043         * common/pathstuff.c (contains_dir_separator): New function.
4044         * common/pathstuff.h (contains_dir_separator): New prototype.
4045         * source.c: Don't include "sys/stat.h".
4046         (is_regular_file): Move to "common/common-utils.c".
4047
4048 2018-02-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4049
4050         * Makefile.in (COMMON_SFILES): Add "common/pathstuff.c".
4051         (HFILES_NO_SRCDIR): Add "common/pathstuff.h".
4052         * auto-load.c: Include "common/pathstuff.h".
4053         * common/common-def.h (current_directory): Move here.
4054         * common/gdb_tilde_expand.c (gdb_tilde_expand_up): New
4055         function.
4056         * common/gdb_tilde_expand.h (gdb_tilde_expand_up): New
4057         prototype.
4058         * common/pathstuff.c: New file.
4059         * common/pathstuff.h: New file.
4060         * compile/compile.c: Include "common/pathstuff.h".
4061         * defs.h (current_directory): Move to "common/common-defs.h".
4062         * dwarf2read.c: Include "common/pathstuff.h".
4063         * exec.c: Likewise.
4064         * guile/scm-safe-call.c: Likewise.
4065         * linux-thread-db.c: Likewise.
4066         * main.c: Likewise.
4067         * nto-tdep.c: Likewise.
4068         * objfiles.c: Likewise.
4069         * source.c: Likewise.
4070         * symtab.c: Likewise.
4071         * utils.c: Include "common/pathstuff.h".
4072         (gdb_realpath): Move to "common/pathstuff.c".
4073         (gdb_realpath_keepfile): Likewise.
4074         (gdb_abspath): Likewise.
4075         * utils.h (gdb_realpath): Move to "common/pathstuff.h".
4076         (gdb_realpath_keepfile): Likewise.
4077         (gdb_abspath): Likewise.
4078
4079 2018-02-28  John Baldwin  <jhb@FreeBSD.org>
4080
4081         * fbsd-nat.c (fbsd_resume): Use PT_SETSTEP for stepping and a
4082         wildcard process pid for super_resume for kernels with a
4083         specific bug.
4084
4085 2018-02-27  Phil Muldoon  <pmuldoon@redhat.com>
4086
4087         * compile/compile.c (get_args): Add additional comments
4088         explaining function.
4089
4090 2018-02-27  Simon Marchi  <simon.marchi@polymtl.ca>
4091             Tom Tromey  <tom@tromey.com>
4092
4093         * target.h (memory_write_request_s): Remove typedef.  Don't define
4094         VEC.
4095         (target_write_memory_blocks): Change argument to std::vector.
4096         (struct memory_write_request): Add constructor.
4097         * target-memory.c (compare_block_starting_address): Return bool.
4098         Change argument types.
4099         (claim_memory): Change arguments to use std::vector.
4100         (split_regular_and_flash_blocks, blocks_to_erase)
4101         (compute_garbled_blocks): Likewise.
4102         (cleanup_request_data, cleanup_write_requests_vector): Remove.
4103         (target_write_memory_blocks): Change argument to std::vector.
4104         * symfile.c (struct load_section_data): Add constructor and
4105         destructor.  Use std::vector for "requests".
4106         (struct load_progress_data): Add initializers.
4107         (load_section_callback): Update.  Use "new".
4108         (clear_memory_write_data): Remove.
4109         (generic_load): Update.
4110
4111 2018-02-27  Alan Hayward  <alan.hayward@arm.com>
4112
4113         * arch/aarch64.h: Use common/tdesc.h.
4114
4115 2018-02-26  Maciej W. Rozycki  <macro@mips.com>
4116
4117         * mips-tdep.c (mips_gdbarch_init): Don't use a 32-bit BFD
4118         architecture with a 64-bit ABI.
4119
4120 2018-02-26  Maciej W. Rozycki  <macro@mips.com>
4121
4122         * gdb/mips-tdep.c (mips_gdbarch_init): Reorder ABI determination
4123         ahead of target description loading.
4124
4125 2018-02-26  Tom Tromey  <tom@tromey.com>
4126
4127         * stack.c (backtrace_command_1): Update.
4128         * python/python-internal.h (gdbpy_apply_frame_filter): Change type
4129         of "flags".
4130         * python/py-framefilter.c (py_print_frame)
4131         (gdbpy_apply_frame_filter): Change type of "flags".
4132         * mi/mi-cmd-stack.c (mi_apply_ext_lang_frame_filter): Change type
4133         of "flags".
4134         (mi_cmd_stack_list_frames, mi_cmd_stack_list_locals)
4135         (mi_cmd_stack_list_args, mi_cmd_stack_list_variables): Update.
4136         * extension.h (enum frame_filter_flag): Rename from
4137         frame_filter_flags.
4138         (frame_filter_flags): Define using DEF_ENUM_FLAGS_TYPE.
4139         (apply_ext_lang_frame_filter): Change type of "flags".
4140         * extension.c (apply_ext_lang_frame_filter): Change type of
4141         "flags".
4142         * extension-priv.h (struct extension_language_ops)
4143         <apply_frame_filter>: Change type of "flags".
4144
4145 2018-02-26  Tom Tromey  <tom@tromey.com>
4146
4147         PR python/16497:
4148         * stack.c (backtrace_command_1): Set PRINT_MORE_FRAMES flag.  Fix
4149         off-by-one in py_end computation.
4150         * python/py-framefilter.c (gdbpy_apply_frame_filter): Handle
4151         PRINT_MORE_FRAMES.
4152         * extension.h (enum frame_filter_flags) <PRINT_MORE_FRAMES>: New
4153         constant.
4154
4155 2018-02-26  Tom Tromey  <tom@tromey.com>
4156
4157         * dwarf2read.c (struct variant_field): New.
4158         (struct nextfield) <variant>: New field.
4159         (dwarf2_add_field): Handle DW_TAG_variant_part.
4160         (dwarf2_attach_fields_to_type): Attach a discriminant_info to a
4161         discriminated union.
4162         (read_structure_type): Handle DW_TAG_variant_part.
4163         (handle_struct_member_die): New function, extracted from
4164         process_structure_scope.  Handle DW_TAG_variant.
4165         (process_structure_scope): Handle discriminated unions.  Call
4166         handle_struct_member_die.
4167
4168 2018-02-26  Tom Tromey  <tom@tromey.com>
4169
4170         * rust-lang.h (rust_last_path_segment): Declare.
4171         * rust-lang.c (rust_last_path_segment): Now public.  Change
4172         contract.
4173         (struct disr_info): Remove.
4174         (RUST_ENUM_PREFIX, RUST_ENCODED_ENUM_REAL)
4175         (RUST_ENCODED_ENUM_HIDDEN, rust_union_is_untagged)
4176         (rust_get_disr_info, rust_tuple_variant_type_p): Remove.
4177         (rust_enum_p, rust_enum_variant): New function.
4178         (rust_underscore_fields): Remove "offset" parameter.
4179         (rust_print_enum): New function.
4180         (rust_val_print) <TYPE_CODE_UNION>: Remove enum code.
4181         <TYPE_CODE_STRUCT>: Call rust_print_enum when appropriate.
4182         (rust_print_struct_def): Add "for_rust_enum" parameter.  Handle
4183         enums.
4184         (rust_internal_print_type): New function, from rust_print_type.
4185         Remove enum code.
4186         (rust_print_type): Call rust_internal_print_type.
4187         (rust_evaluate_subexp) <STRUCTOP_ANONYMOUS, STRUCTOP_STRUCT>:
4188         Update enum handling.
4189         * dwarf2read.c (struct dwarf2_cu) <rust_unions>: New field.
4190         (rust_fully_qualify, alloc_discriminant_info, quirk_rust_enum)
4191         (rust_union_quirks): New functions.
4192         (process_full_comp_unit, process_full_type_unit): Call
4193         rust_union_quirks.
4194         (process_structure_scope): Update rust_unions if necessary.
4195
4196 2018-02-26  Tom Tromey  <tom@tromey.com>
4197
4198         * value.h (value_union_variant): Declare.
4199         * valops.c (value_union_variant): New function.
4200         * gdbtypes.h (TYPE_FLAG_DISCRIMINATED_UNION): New macro.
4201         (struct discriminant_info): New.
4202         (enum dynamic_prop_node_kind) <DYN_PROP_DISCRIMINATED>: New
4203         enumerator.
4204         (struct main_type) <flag_discriminated_union>: New field.
4205
4206 2018-02-26  Tom Tromey  <tom@tromey.com>
4207
4208         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4209         unittests/unpack-selftests.c.
4210         * unittests/unpack-selftests.c: New file.
4211         * value.c (unpack_bits_as_long): Fix bugs in non-bitfield cases.
4212
4213 2018-02-26  Yao Qi  <yao.qi@linaro.org>
4214
4215         * dwarf2read.c (struct partial_die_info) <read>: New method.
4216         (read_partial_die): Remove the declaration.
4217         (load_partial_dies): Update.
4218         (partial_die_info::partial_die_info):
4219         (read_partial_die): Change it to partial_die_info::read.
4220
4221 2018-02-26  Yao Qi  <yao.qi@linaro.org>
4222
4223         * dwarf2read.c (struct partial_die_info) <fixup>: New method.
4224         (fixup_partial_die): Remove declaration.
4225         (scan_partial_symbols): Update.
4226         (partial_die_parent_scope): Likewise.
4227         (partial_die_full_name): Likewise.
4228         (fixup_partial_die): Change it to partial_die_info::fixup.
4229
4230 2018-02-26  Yao Qi  <yao.qi@linaro.org>
4231
4232         * dwarf2read.c (read_partial_die): Update the declaration.
4233         (load_partial_dies): Caller update.
4234         (read_partial_die): Remove one argument abbrev_len.
4235
4236 2018-02-26  Yao Qi  <yao.qi@linaro.org>
4237
4238         * dwarf2read.c (struct partial_die_info): Add ctor, delete
4239         assignment operator.
4240         (load_partial_dies): Use ctor and copy ctor.
4241         (read_partial_die): Update.
4242         (dwarf2_cu::find_partial_die): Use ctor.
4243
4244 2018-02-26  Yao Qi  <yao.qi@linaro.org>
4245
4246         * dwarf2read.c (struct dwarf2_cu) <find_partial_die>: New method.
4247         (find_partial_die_in_comp_unit): Change it to
4248         dwarf2_cu::find_partial_die.
4249         (find_partial_die): Update.
4250
4251 2018-02-26  Yao Qi  <yao.qi@linaro.org>
4252
4253         * dwarf2read.c (read_partial_die): Remove the code checking abbrev
4254         is NULL.
4255
4256 2018-02-26  Yao Qi  <yao.qi@linaro.org>
4257
4258         * dwarf2read.c (load_partial_dies): Move the location of XOBNEW.
4259
4260 2018-02-26  Alan Hayward  <alan.hayward@arm.com>
4261
4262         * arch/amd64.h: Use common/tdesc.h.
4263         * arch/i386.c: Likewise.
4264         * arch/i386.h: Likewise.
4265         * arch/tic6x.c: Likewise.
4266         * arch/tdesc.h: Move file from here...
4267         * common/tdesc.h: ...to here.
4268         * features/aarch64-core.c: Regenerate.
4269         * features/aarch64-fpu.c: Regenerate.
4270         * features/i386/32bit-avx.c: Regenerate.
4271         * features/i386/32bit-avx512.c: Regenerate.
4272         * features/i386/32bit-core.c: Regenerate.
4273         * features/i386/32bit-linux.c: Regenerate.
4274         * features/i386/32bit-mpx.c: Regenerate.
4275         * features/i386/32bit-pkeys.c: Regenerate.
4276         * features/i386/32bit-sse.c: Regenerate.
4277         * features/i386/64bit-avx.c: Regenerate.
4278         * features/i386/64bit-avx512.c: Regenerate.
4279         * features/i386/64bit-core.c: Regenerate.
4280         * features/i386/64bit-linux.c: Regenerate.
4281         * features/i386/64bit-mpx.c: Regenerate.
4282         * features/i386/64bit-pkeys.c: Regenerate.
4283         * features/i386/64bit-segments.c: Regenerate.
4284         * features/i386/64bit-sse.c: Regenerate.
4285         * features/i386/x32-core.c: Regenerate.
4286         * features/tic6x-c6xp.c: Regenerate.
4287         * features/tic6x-core.c: Regenerate.
4288         * features/tic6x-gp.c: Regenerate.
4289         * target-descriptions.c: Use common/tdesc.h.
4290         * target-descriptions.h: Likewise.
4291
4292 2018-02-24  Tom Tromey  <tom@tromey.com>
4293
4294         * linux-thread-db.c (try_thread_db_load_from_pdir_1)
4295         (try_thread_db_load_from_dir, thread_db_load_search): Use
4296         std::string.
4297         (info_auto_load_libthread_db_compare): Return bool.  Change
4298         argument types.
4299         (info_auto_load_libthread_db): Use std::vector, std::string.
4300         Remove cleanups.
4301
4302 2018-02-24  Tom Tromey  <tom@tromey.com>
4303
4304         * i386-tdep.c (i386_fast_tracepoint_valid_at): "msg" now a
4305         std::string.
4306         * gdbarch.sh (fast_tracepoint_valid_at): Change "msg" to a
4307         std::string*.
4308         * gdbarch.c: Rebuild.
4309         * gdbarch.h: Rebuild.
4310         * breakpoint.c (check_fast_tracepoint_sals): Use std::string.
4311         * arch-utils.h (default_fast_tracepoint_valid_at): Update.
4312         * arch-utils.c (default_fast_tracepoint_valid_at): "msg" now a
4313         std::string*.
4314
4315 2018-02-23  Simon Marchi  <simon.marchi@polymtl.ca>
4316
4317         * gdbtypes.h (sect_offset): Change type to uint64_t.
4318         (sect_offset_str): New function.
4319         * dwarf2read.c (create_addrmap_from_aranges): Use
4320         sect_offset_str.
4321         (error_check_comp_unit_head): Likewise.
4322         (create_debug_type_hash_table): Likewise.
4323         (read_cutu_die_from_dwo): Likewise.
4324         (init_cutu_and_read_dies): Likewise.
4325         (init_cutu_and_read_dies_no_follow): Likewise.
4326         (process_psymtab_comp_unit_reader): Likewise.
4327         (partial_die_parent_scope): Likewise.
4328         (peek_die_abbrev): Likewise.
4329         (process_queue): Likewise.
4330         (dwarf2_physname): Likewise.
4331         (read_namespace_alias): Likewise.
4332         (read_import_statement): Likewise.
4333         (create_dwo_cu_reader): Likewise.
4334         (create_cus_hash_table): Likewise.
4335         (lookup_dwo_cutu): Likewise.
4336         (inherit_abstract_dies): Likewise.
4337         (read_func_scope): Likewise.
4338         (read_call_site_scope): Likewise.
4339         (dwarf2_add_member_fn): Likewise.
4340         (read_common_block): Likewise.
4341         (read_module_type): Likewise.
4342         (read_typedef): Likewise.
4343         (read_subrange_type): Likewise.
4344         (load_partial_dies): Likewise.
4345         (read_partial_die): Likewise.
4346         (find_partial_die): Likewise.
4347         (read_str_index): Likewise.
4348         (dwarf2_string_attr): Likewise.
4349         (build_error_marker_type): Likewise.
4350         (lookup_die_type): Likewise.
4351         (dump_die_shallow): Likewise.
4352         (follow_die_ref): Likewise.
4353         (dwarf2_fetch_die_loc_sect_off): Likewise.
4354         (dwarf2_fetch_constant_bytes): Likewise.
4355         (follow_die_sig): Likewise.
4356         (get_signatured_type): Likewise.
4357         (get_DW_AT_signature_type): Likewise.
4358         (dwarf2_find_containing_comp_unit): Likewise.
4359         (set_die_type): Likewise.
4360
4361 2018-02-21  John Baldwin  <jhb@FreeBSD.org>
4362
4363         * arch/aarch64.c: Include "common-defs.h".
4364         * arch/amd64.c: Likewise.
4365         * arch/i386.c: Likewise.
4366
4367 2018-02-21  Tom Tromey  <tom@tromey.com>
4368
4369         * value.h: (extract_field_op): Update.
4370         * eval.c (extract_field_op): Return a const char *.
4371         * expression.h (parse_expression_for_completion): Update.
4372         * completer.c (complete_expression): Update.
4373         (add_struct_fields): Make fieldname const.
4374         * parse.c (expout_completion_name): Now a unique_xmalloc_ptr.
4375         (mark_completion_tag, parse_exp_in_context_1): Update.
4376         (parse_expression_for_completion): Change "name" to
4377         unique_xmalloc_ptr*.
4378
4379 2018-02-21  Tom Tromey  <tom@tromey.com>
4380
4381         * infcall.c (call_function_by_hand_dummy): Use std::vector.
4382
4383 2018-02-21  Yao Qi  <yao.qi@linaro.org>
4384
4385         * avr-tdep.c (avr_read_pc): Change parameter type to
4386         readable_regcache.
4387         * gdbarch.sh (read_pc): Likewise.
4388         * gdbarch.c: Re-generated.
4389         * gdbarch.h: Re-generated.
4390         * hppa-tdep.c (hppa_read_pc): Change parameter type to
4391         readable_regcache.
4392         * ia64-tdep.c (ia64_read_pc): Likewise.
4393         * mips-tdep.c (mips_read_pc): Likewise.
4394         * spu-tdep.c (spu_read_pc): Likewise.
4395
4396 2018-02-21  Yao Qi  <yao.qi@linaro.org>
4397
4398         * Makefile.in (COMMON_SFILES): Add regcache-dump.c
4399         * regcache-dump.c: New file.
4400         * regcache.c: Move register_dump to regcache-dump.c.
4401         (maintenance_print_registers): Likewise.
4402         (maintenance_print_raw_registers): Likewise.
4403         (maintenance_print_cooked_registers): Likewise.
4404         (maintenance_print_register_groups): Likewise.
4405         (maintenance_print_remote_registers): Likewise.
4406         (_initialize_regcache): Likewise.
4407         * regcache.h (register_dump): Moved from regcache.c.
4408
4409 2018-02-21  Yao Qi  <yao.qi@linaro.org>
4410
4411         * regcache.c (regcache::regcache): Update.
4412         (regcache::invalidate): Move it to detached_regcache::invalidate.
4413         (get_thread_arch_aspace_regcache): Update.
4414         (regcache::raw_update): Update.
4415         (regcache::cooked_read): Remove some code.
4416         (regcache::cooked_read_value): Likewise.
4417         (regcache::raw_write): Remove assert on m_readonly_p.
4418         (regcache::raw_supply_integer): Move it to
4419         detached_regcache::raw_supply_integer.
4420         (regcache::raw_supply_zeroed): Likewise.
4421         * regcache.h (detached_regcache) <raw_supply_integer>: New
4422         declaration.
4423         <raw_supply_zeroed, invalidate>: Likewise.
4424         (regcache) <raw_supply_integer, raw_supply_zeroed>: Removed.
4425         <invalidate>: Likewise.
4426         <m_readonly_p>: Removed.
4427
4428 2018-02-21  Yao Qi  <yao.qi@linaro.org>
4429
4430         * infcmd.c (get_return_value): Let stop_regs point to
4431         get_current_regcache.
4432         * regcache.c (regcache::regcache): Remove.
4433         (register_dump_reg_buffer): New class.
4434         (regcache_print): Adjust.
4435         * regcache.h (regcache): Remove constructors.
4436
4437 2018-02-21  Yao Qi  <yao.qi@linaro.org>
4438
4439         * regcache.c (class register_dump): New class.
4440         (register_dump_regcache, register_dump_none): New class.
4441         (register_dump_remote, register_dump_groups): New class.
4442         (regcache_print): Update.
4443         * regcache.h (regcache_dump_what): Move it to regcache.c.
4444         (regcache) <dump>: Remove.
4445
4446 2018-02-21  Yao Qi  <yao.qi@linaro.org>
4447
4448         * jit.c (struct jit_unwind_private) <regcache>: Change its type to
4449          reg_buffer_rw *.
4450         (jit_unwind_reg_set_impl): Call raw_supply.
4451         (jit_frame_sniffer): Use reg_buffer_rw.
4452         * record-full.c (record_full_core_regbuf): Change its type.
4453         (record_full_core_open_1): Use reg_buffer_rw.
4454         (record_full_close): Likewise.
4455         (record_full_core_fetch_registers): Use regcache->raw_supply.
4456         (record_full_core_store_registers): Likewise.
4457         * regcache.c (regcache::get_register_status): Move it to
4458         reg_buffer.
4459         (regcache_raw_set_cached_value): Remove.
4460         (regcache::raw_set_cached_value): Remove.
4461         (regcache::raw_write): Call raw_supply.
4462         (regcache::raw_supply): Move it to reg_buffer_rw.
4463         * regcache.h (regcache_raw_set_cached_value): Remove.
4464         (reg_buffer_rw): New class.
4465
4466 2018-02-21  Yao Qi  <yao.qi@linaro.org>
4467
4468         * dummy-frame.c (dummy_frame_cache) <prev_regcache>: Use
4469         readonly_detached_regcache.
4470         (dummy_frame_prev_register): Use regcache->cooked_read.
4471         * frame.c (frame_save_as_regcache): Change return type.
4472         (frame_pop): Update.
4473         * frame.h (frame_save_as_regcache): Update declaration.
4474         * inferior.h (get_infcall_suspend_state_regcache): Update
4475         declaration.
4476         * infrun.c (infcall_suspend_state) <registers>: use
4477         readonly_detached_regcache.
4478         (save_infcall_suspend_state): Don't use regcache_dup.
4479         (get_infcall_suspend_state_regcache): Change return type.
4480         * linux-fork.c (struct fork_info) <savedregs>: Change to
4481         readonly_detached_regcache.
4482         <pc>: New field.
4483         (fork_save_infrun_state): Don't use regcache_dup.
4484         (info_checkpoints_command): Adjust.
4485         * mi/mi-main.c (register_changed_p): Update declaration.
4486         (mi_cmd_data_list_changed_registers): Use
4487         readonly_detached_regcache.
4488         (register_changed_p): Change parameter type to
4489         readonly_detached_regcache.
4490         * ppc-linux-tdep.c (ppu2spu_cache) <regcache>: Use
4491         readonly_detached_regcache.
4492         (ppu2spu_sniffer): Construct a new readonly_detached_regcache.
4493         * regcache.c (readonly_detached_regcache::readonly_detached_regcache):
4494         New.
4495         (regcache::save): Move it to reg_buffer.
4496         (regcache::restore): Change parameter type.
4497         (regcache_dup): Remove.
4498         * regcache.h (reg_buffer) <save>: New method.
4499         (readonly_detached_regcache): New class.
4500         * spu-tdep.c (spu2ppu_cache) <regcache>: Use
4501         readonly_detached_regcache.
4502         (spu2ppu_sniffer): Construct a new readonly_detached_regcache.
4503
4504 2018-02-21  Yao Qi  <yao.qi@linaro.org>
4505
4506         * frame.c (frame_save_as_regcache): Use regcache method save.
4507         (frame_pop): Use regcache method restore.
4508         * infrun.c (restore_infcall_suspend_state): Likewise.
4509         * linux-fork.c (fork_load_infrun_state): Likewise.
4510         * ppc-linux-tdep.c (ppu2spu_sniffer): User regcache method
4511         save.
4512         * regcache.c (regcache_save): Remove.
4513         (regcache::restore): More asserts.
4514         (regcache_cpy): Remove.
4515         * regcache.h (regcache_save): Remove the declaration.
4516         (regcache::restore): Move from private to public.
4517         Remove the friend declaration of regcache_cpy.
4518         (regcache_cpy): Remove declaration.
4519
4520 2018-02-21  Yao Qi  <yao.qi@linaro.org>
4521
4522         * aarch64-tdep.c (aarch64_pseudo_register_read_value): Change
4523         parameter type to 'readable_regcache *'.
4524         * amd64-tdep.c (amd64_pseudo_register_read_value): Likewise.
4525         * arm-tdep.c (arm_neon_quad_read): Likewise.
4526         (arm_pseudo_read): Likewise.
4527         * avr-tdep.c (avr_pseudo_register_read): Likewise.
4528         * bfin-tdep.c (bfin_pseudo_register_read): Likewise.
4529         * frv-tdep.c (frv_pseudo_register_read): Likewise.
4530         * gdbarch.c: Re-generated.
4531         * gdbarch.h: Re-generated.
4532         * gdbarch.sh (pseudo_register_read): Change parameter type to
4533         'readable_regcache *'.
4534         (pseudo_register_read_value): Likewise.
4535         * h8300-tdep.c (pseudo_from_raw_register): Likewise.
4536         (h8300_pseudo_register_read): Likewise.
4537         * hppa-tdep.c (hppa_pseudo_register_read): Likewise.
4538         * i386-tdep.c (i386_mmx_regnum_to_fp_regnum): Likewise.
4539         (i386_pseudo_register_read_into_value): Likewise.
4540         (i386_pseudo_register_read_value): Likewise.
4541         * i386-tdep.h (i386_pseudo_register_read_into_value): Update
4542         declaration.
4543         * ia64-tdep.c (ia64_pseudo_register_read): Likewise.
4544         * m32c-tdep.c (m32c_raw_read): Likewise.
4545         (m32c_read_flg): Likewise.
4546         (m32c_banked_register): Likewise.
4547         (m32c_banked_read): Likewise.
4548         (m32c_sb_read): Likewise.
4549         (m32c_part_read): Likewise.
4550         (m32c_cat_read): Likewise.
4551         (m32c_r3r2r1r0_read): Likewise.
4552         (m32c_pseudo_register_read): Likewise.
4553         * m68hc11-tdep.c (m68hc11_pseudo_register_read): Likewise.
4554         * mep-tdep.c (mep_pseudo_cr32_read): Likewise.
4555         (mep_pseudo_cr64_read): Likewise.
4556         (mep_pseudo_register_read): Likewise.
4557         * mips-tdep.c (mips_pseudo_register_read): Likewise.
4558         * msp430-tdep.c (msp430_pseudo_register_read): Likewise.
4559         * nds32-tdep.c (nds32_pseudo_register_read): Likewise.
4560         * regcache.c (regcache::raw_read): Move it to readable_regcache.
4561         (regcache::cooked_read): Likewise.
4562         (regcache::cooked_read_value): Likewise.
4563         (regcache_cooked_read_signed):
4564         (regcache::cooked_read): Likewise.
4565         * regcache.h (readable_regcache): New class.
4566         (regcache): Inherit readable_regcache.  Move some methods to
4567         readable_regcache.
4568         * rl78-tdep.c (rl78_pseudo_register_read): Change
4569         parameter type to 'readable_regcache *'.
4570         * rs6000-tdep.c (do_regcache_raw_read): Remove.
4571         (e500_pseudo_register_read): Change parameter type to
4572         'readable_regcache *'.
4573         (dfp_pseudo_register_read): Likewise.
4574         (vsx_pseudo_register_read): Likewise.
4575         (efpr_pseudo_register_read): Likewise.
4576         * s390-tdep.c (s390_pseudo_register_read): Likewise.
4577         * sh-tdep.c (sh_pseudo_register_read): Likewise.
4578         * sh64-tdep.c (pseudo_register_read_portions): Likewise.
4579         (sh64_pseudo_register_read): Likewise.
4580         * sparc-tdep.c (sparc32_pseudo_register_read): Likewise.
4581         * sparc64-tdep.c (sparc64_pseudo_register_read): Likewise.
4582         * spu-tdep.c (spu_pseudo_register_read_spu): Likewise.
4583         (spu_pseudo_register_read): Likewise.
4584         * xtensa-tdep.c (xtensa_register_read_masked): Likewise.
4585         (xtensa_pseudo_register_read): Likewise.
4586
4587 2018-02-21  Yao Qi  <yao.qi@linaro.org>
4588
4589         * regcache.c (regcache::regcache): Call reg_buffer ctor.
4590         (regcache::arch): Move it to reg_buffer::arch.
4591         (regcache::register_buffer): Likewise.
4592         (regcache::assert_regnum): Likewise.
4593         (regcache::num_raw_registers): Likewise.
4594         * regcache.h (reg_buffer): New class.
4595         (regcache): Inherit reg_buffer.
4596
4597 2018-02-20  Simon Marchi  <simon.marchi@ericsson.com>
4598
4599         * remote-sim.c (gdb_os_printf_filtered, gdb_os_vprintf_filtered,
4600         gdb_os_evprintf_filtered, gdb_os_error): Add ATTRIBUTE_PRINTF.
4601
4602 2018-02-20  Markus Metzger  <markus.t.metzger@intel.com>
4603
4604         * gnulib/update-gnulib.sh (IMPORTED_GNULIB_MODULES): Add mkstemp.
4605
4606 2018-02-19  Alan Hayward  <alan.hayward@arm.com>
4607
4608         * Makefile.in: (COMMON_SFILES): Add common/*.c files.
4609         (SFILES): Remove common/*.c files.
4610         (COMMON_OBS): Remove some *.o files built from common/*.c files.
4611         * common/common.host: Add common reference.
4612         * configure.ac: Likewise.
4613         * configure: Regenerate.
4614
4615 2018-02-16  Yao Qi  <yao.qi@linaro.org>
4616
4617         * block.c (block_namespace_info): Inherit allocate_on_obstack.
4618         (block_initialize_namespace): Use new.
4619         * dwarf2read.c (dwarf2_per_objfile): Inherit allocate_on_obstack.
4620         (dwarf2_free_objfile): Use delete.
4621         * gdbtypes.c (type_pair): Inherit allocate_on_obstack.
4622         (copy_type_recursive): Use new.
4623         * gdb_obstack.h (allocate_on_obstack): New.
4624
4625 2018-02-15  Yao Qi  <yao.qi@linaro.org>
4626
4627         PR gdb/22849
4628         * inferior.c (exit_inferior_1): Reset inf->control.
4629
4630 2018-02-15  Joel Brobecker  <brobecker@adacore.com>
4631
4632         * ada-lang.c (ada_to_fixed_value_create): Delete advance
4633         declaration.
4634
4635 2018-02-14  Pedro Alves  <palves@redhat.com>
4636
4637         * frame-unwind.c (frame_unwind_try_unwinder): Always call
4638         frame_cleanup_after_sniffer on exception.
4639
4640 2018-02-14  Tom Tromey  <tom@tromey.com>
4641
4642         * solist.h (struct target_so_ops) <bfd_open>: Make pathname
4643         const.
4644         (solib_bfd_open): Make pathname const.
4645         * solib.c (solib_bfd_open): Make pathname const.
4646         * solib-spu.c (spu_bfd_fopen): Make name const.
4647         (spu_bfd_open): Make pathname const.
4648         * solib-darwin.c (darwin_bfd_open): Make pathname const.
4649         * solib-aix.c (solib_aix_bfd_open): Make pathname const.
4650
4651 2018-02-14  Tom Tromey  <tom@tromey.com>
4652
4653         * symfile.c (symfile_bfd_open): Update.
4654         * source.h (openp, source_full_path_of, find_and_open_source):
4655         Change argument type to unique_xmalloc_ptr.
4656         * source.c (openp): Take a unique_xmalloc_ptr.
4657         (source_full_path_of, find_and_open_source): Likewise.
4658         (open_source_file, symtab_to_fullname): Update.
4659         * solist.h (struct target_so_ops) <find_and_open_solib>: Take a
4660         unique_xmalloc_ptr.
4661         * solib.c (solib_find_1): Use unique_xmalloc_ptr.
4662         (exec_file_find): Update.
4663         * psymtab.c (psymtab_to_fullname): Update.
4664         * nto-tdep.h (nto_find_and_open_solib): Update.
4665         * nto-tdep.c (nto_find_and_open_solib): Change temp_path to a
4666         unique_xmalloc_ptr.
4667         * exec.c (exec_file_attach): Update.
4668         * dwarf2read.c (try_open_dwop_file): Use unique_xmalloc_ptr.
4669         * cli/cli-cmds.c (find_and_open_script): Use unique_xmalloc_ptr.
4670
4671 2018-02-14  Tom Tromey  <tom@tromey.com>
4672
4673         * solib.c: Include source.h.
4674         * nto-tdep.c: Include source.h.
4675         * mi/mi-cmd-env.c: Include source.h.
4676         * infcmd.c: Include source.h.
4677         * exec.c: Include source.h.
4678         * defs.h (enum openp_flag, openp, source_full_path_of, mod_path)
4679         (add_path, directory_switch, source_path, init_source_path): Move
4680         declarations...
4681         * source.h (enum openp_flag, openp, source_full_path_of, mod_path)
4682         (add_path, directory_switch, source_path, init_source_path):
4683         ...here.
4684
4685 2018-02-14  Tom Tromey  <tom@tromey.com>
4686
4687         * solist.h (exec_file_find, solib_find): Return
4688         unique_xmalloc_ptr.
4689         (solib_bfd_fopen): Take a const char *.
4690         * solib.c (solib_find_1): Return unique_xmalloc_ptr.
4691         (exec_file_find, solib_find): Likewise.
4692         (solib_bfd_fopen): Do not take ownership of "pathname".
4693         (solib_bfd_open): Use unique_xmalloc_ptr.
4694         * solib-darwin.c (darwin_bfd_open): Use unique_xmalloc_ptr.
4695         * solib-aix.c (solib_aix_bfd_open): Use unique_xmalloc_ptr.
4696         * infrun.c (follow_exec): Use unique_xmalloc_ptr.
4697         * exec.c (exec_file_locate_attach): Use unique_xmalloc_ptr.
4698
4699 2018-02-14  Joel Brobecker  <brobecker@adacore.com>
4700
4701         * ada-lang.c (name_match_type_from_name): Remove reference to
4702         ada_name_for_lookup in function's documentation.
4703         * ada-lang.h (ada_name_for_lookup): Delete declaration.
4704
4705 2018-02-13  Simon Marchi  <simon.marchi@polymtl.ca>
4706
4707         * defs.h (enum openp_flags): New enum.
4708         (OPF_TRY_CWD_FIRST, OPF_SEARCH_IN_PATH, OPF_RETURN_REALPATH):
4709         Move to enum openp_flags.
4710         (openp_flags): New enum flags.
4711         (openp): Change parameter type to openp_flags.
4712         * source.c (openp): Change parameter type to openp_flags.
4713         * cli/cli-cmds.c (find_and_open_script): Use openp_flags.
4714         * dwarf2read.c (try_open_dwop_file): Use openp_flags.
4715
4716 2018-02-13  Simon Marchi  <simon.marchi@polymtl.ca>
4717
4718         * maint.c (_initialize_maint_cmds): Fix prefix of maint set/show
4719         per-command.
4720
4721 2018-02-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4722
4723         * dwarf2read.c (dwarf2_release_queue): Delete function, move body
4724         into...
4725         (class dwarf2_queue_guard): ...the destructor of this new class.
4726         (dw2_do_instantiate_symtab): Create instance of the new class
4727         dwarf2_queue_guard, remove cleanup.
4728
4729 2018-02-09  Tom Tromey  <tom@tromey.com>
4730
4731         * source.c (find_source_lines): Don't reference past the end of
4732         the vector.
4733
4734 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
4735
4736         * remote.c (remote_btrace_maybe_reopen): Change error message.
4737         * btrace.c (btrace_enable): Likewise.
4738         (parse_xml_btrace): Likewise.
4739         (parse_xml_btrace_conf): Likewise.
4740
4741 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
4742
4743         * nat/linux-btrace.c (diagnose_perf_event_open_fail): New.
4744         (linux_enable_pt, linux_enable_bts): Call
4745         diagnose_perf_event_open_fail.
4746
4747 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
4748
4749         * nat/linux-btrace.c (perf_event_pt_event_type): Improve error message.
4750         Remove parameter and change return type.  Update callers.  Move it.
4751         (linux_enable_bts, linux_enable_pt): Improve error message.
4752         (linux_enable_pt): Remove zero buffer size check.
4753         (linux_enable_btrace): Improve error messages.  Remove NULL return
4754         check.
4755
4756 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
4757
4758         * btrace.c (btrace_enable): Remove target_supports_btrace call.
4759         * nat/linux-btrace.c (perf_event_pt_event_type): Move.
4760         (kernel_supports_bts, kernel_supports_pt, linux_supports_bts)
4761         (linux_supports_pt, linux_supports_btrace): Remove.
4762         (linux_enable_bts): Call cpu_supports_bts.
4763         * nat/linux-btrace.h (linux_supports_btrace): Remove.
4764         * remote.c (remote_supports_btrace): Remove.
4765         (init_remote_ops): Remove remote_supports_btrace.
4766         * target-delegates.c: Regenerated.
4767         * target.c (target_supports_btrace): Remove.
4768         * target.h (target_ops) <to_supports_btrace>: Remove
4769         (target_supports_btrace): Remove.
4770         * x86-linux-nat.c (x86_linux_create_target): Remove
4771         linux_supports_btrace.
4772
4773 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
4774
4775         * nat/linux-btrace.c (linux_enable_btrace): Throw exception if enabling
4776         btrace failed.
4777         * x86-linux-nat.c (x86_linux_enable_btrace): Catch btrace enabling
4778         exception and use message in own exception.
4779
4780 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
4781
4782         * nat/linux-btrace.c: Include scoped_fd.h and scoped_mmap.h.
4783         (perf_event_pt_event_type): Use gdb_file_up.
4784         (linux_enable_bts, linux_enable_pt): Use gdb::unique_xmalloc_ptr,
4785         scoped_fd, and scoped_mmap.
4786
4787 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
4788
4789         * common/scoped_mmap.h: New.
4790         * unittests/scoped_mmap-selftest.c: New.
4791         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4792         unittests/scoped_mmap-selftest.c.
4793
4794 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
4795
4796         * common/scoped_fd.h: New.
4797         * unittests/scoped_fd-selftest.c: New.
4798         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4799         unittests/scoped_fd-selftest.c.
4800
4801 2018-02-09  Tom Tromey  <tom@tromey.com>
4802
4803         * auto-load.c (auto_load_section_scripts): Use
4804         gdb::unique_xmalloc_ptr.
4805
4806 2018-02-09  Tom Tromey  <tom@tromey.com>
4807
4808         * auto-load.c (execute_script_contents): Use std::string.
4809
4810 2018-02-09  Joel Brobecker  <brobecker@adacore.com>
4811
4812         * NEWS <Changes in GDB 8.1>: Clarify that "rbreak" is a new
4813         Python function, rather than a new command.
4814
4815 2018-02-08  Tom Tromey  <tom@tromey.com>
4816
4817         * solib.c (solib_find_1): Use std::string.
4818         (solib_bfd_fopen): Use unique_xmalloc_ptr.
4819
4820 2018-02-08  Tom Tromey  <tom@tromey.com>
4821
4822         * build-id.c (build_id_to_debug_bfd): Use unique_xmalloc_ptr.
4823
4824 2018-02-08  Tom Tromey  <tom@tromey.com>
4825
4826         * source.c (find_source_lines): Use gdb::def_vector.
4827
4828 2018-02-08  Tom Tromey  <tom@tromey.com>
4829
4830         * macrocmd.c (struct temporary_macro_definition): New.
4831         (macro_define_command): Use temporary_macro_definition.  Remove
4832         cleanups.
4833         (free_macro_definition_ptr): Remove.
4834
4835 2018-02-08  Tom Tromey  <tom@tromey.com>
4836
4837         * macroexp.c (maybe_expand): Use std::string.
4838
4839 2018-02-08  Tom Tromey  <tom@tromey.com>
4840
4841         * macroexp.c (struct macro_buffer): Add initializers for some
4842         members.
4843         (init_buffer, init_shared_buffer, free_buffer)
4844         (free_buffer_return_text): Remove.
4845         (macro_buffer): New constructors.
4846         (~macro_buffer): New destructor.
4847         (macro_buffer::set_shared): New method.
4848         (macro_buffer::resize_buffer, macro_buffer::appendc)
4849         (macro_buffer::appendmem): Now methods, not free functions.
4850         (set_token, append_tokens_without_splicing, stringify)
4851         (macro_stringify): Update.
4852         (gather_arguments): Change return type.  Remove argc_p argument,
4853         add args_ptr argument.  Use std::vector.
4854         (substitute_args): Remove argc argument.  Accept std::vector.
4855         (expand): Update.  Use std::vector.
4856         (scan, macro_expand, macro_expand_next): Update.
4857
4858 2018-02-08  Tom Tromey  <tom@tromey.com>
4859
4860         * symtab.c (default_collect_symbol_completion_matches_break_on):
4861         Use unique_xmalloc_ptr.
4862         * macroscope.h: (sal_macro_scope, user_macro_scope)
4863         (default_macro_scope): Return unique_xmalloc_ptr.
4864         * macroscope.c (sal_macro_scope, user_macro_scope)
4865         (default_macro_scope): Return unique_xmalloc_ptr.
4866         * macroexp.h (macro_expand, macro_expand_once): Return
4867         unique_xmalloc_ptr.
4868         * macroexp.c (macro_expand, macro_expand_once): Return
4869         unique_xmalloc_ptr.
4870         * macrocmd.c (macro_expand_command, macro_expand_once_command)
4871         (info_macro_command, info_macros_command): Use
4872         unique_xmalloc_ptr.
4873         * compile/compile-c-support.c (write_macro_definitions): Use
4874         unique_xmalloc_ptr.
4875         * c-exp.y (c_parse): Use unique_xmalloc_ptr.
4876
4877 2018-02-07  Simon Marchi  <simon.marchi@ericsson.com>
4878
4879         * value.c (value_static_field): Assign field type instead of
4880         containing type when returning an optimized out value.
4881
4882 2018-02-06  Yao Qi  <yao.qi@linaro.org>
4883
4884         * ft32-tdep.c (ft32_read_pc): Remove.
4885         (ft32_write_pc): Remove.
4886         (ft32_gdbarch_init): Update.
4887         * m32r-tdep.c (m32r_read_pc): Remove.
4888         (m32r_gdbarch_init): Update.
4889         * mep-tdep.c (mep_read_pc): Remove.
4890         (mep_gdbarch_init): Update.
4891         * microblaze-tdep.c (microblaze_write_pc): Remove.
4892         (microblaze_gdbarch_init): Update.
4893         * mn10300-tdep.c (mn10300_read_pc): Remove.
4894         (mn10300_write_pc): Remove.
4895         (mn10300_gdbarch_init): Update.
4896         * moxie-tdep.c (moxie_read_pc): Remove.
4897         (moxie_write_pc): Remove.
4898         (moxie_gdbarch_init): Update.
4899
4900 2018-02-06  Yao Qi  <yao.qi@linaro.org>
4901
4902         * expprint.c (print_subexp_standard): Handle
4903         OP_F77_UNDETERMINED_ARGLIST.
4904         (dump_subexp_body_standard): Likewise.
4905
4906 2018-02-05  Alan Hayward  <alan.hayward@arm.com>
4907
4908         * target-descriptions.c (tdesc_element_visitor) Add empty
4909         implementations.
4910         (tdesc_type): Move make_gdb_type from here.
4911         (tdesc_type_builtin): Likewise.
4912         (tdesc_type_vector): Likewise.
4913         (tdesc_type_with_fields): Move make_gdb_type_ functions from here.
4914         (make_gdb_type_struct): Move from tdesc_type_with_fields.
4915         (make_gdb_type_union): Likewise.
4916         (make_gdb_type_flags): Likewise.
4917         (make_gdb_type_enum): Likewise.
4918         (make_gdb_type): New function.
4919         (tdesc_register_type): Use static make_gdb_type.
4920
4921 2018-02-05  Ruslan Kabatsayev <b7.10110111@gmail.com>
4922
4923         * infcmd.c (default_print_one_register_info): Align natural-format
4924         column values consistently one under another.
4925         (pad_to_column): New function.
4926
4927 2018-02-05  Joel Brobecker  <brobecker@adacore.com>
4928
4929         * dwarf2read.c (dwarf2_physname): Move commment.
4930
4931 2018-02-01  Leszek Swirski  <leszeks@google.com>
4932
4933         * varobj.c (varobj_formatted_print_options): Allow recursive
4934         pretty printing if pretty printing is enabled.
4935
4936 2018-02-01  Leszek Swirski  <leszeks@google.com>
4937
4938         * c-exp.y (lex_one_token, classify_name, yylex): Don't classify
4939         names after a structop as a filename.
4940
4941 2018-02-01  Yao Qi  <yao.qi@linaro.org>
4942
4943         * arm-tdep.c (arm_record_data_proc_misc_ld_str): Rewrite it.
4944         (arm_record_coproc_data_proc): Likewise.
4945
4946 2018-02-01  Yao Qi  <yao.qi@linaro.org>
4947
4948         * arm-tdep.c (arm_record_extension_space): Change ret to signed.
4949
4950 2018-01-31  Nikola Prica  <nikola.prica@rt-rk.com>
4951
4952         * rs6000-tdep.c (skip_prologue): Remove shifting for lr_reg and
4953         assign shifted lr_reg to fdata->lr_register when lr_reg is set.
4954
4955 2018-01-31  Pedro Alves  <palves@redhat.com>
4956
4957         * darwin-nat.c (darwin_interrupt): Remove ptid_t parameter.
4958         * inflow.c (child_terminal_save_inferior): Wrap reference to
4959         tcgetpgrp in HAVE_TERMIOS_H.
4960         (child_interrupt, child_pass_ctrlc): Wrap references to signal in
4961         _WIN32.
4962         * remote-sim.c (gdbsim_interrupt): Remove ptid_t parameter and
4963         always iterate over all inferiors.
4964         (gdbsim_cntrl_c): Adjust.
4965         * windows-nat.c (windows_interrupt): Remove 'ptid_t' parameter.
4966
4967 2018-01-31  Joel Brobecker  <brobecker@adacore.com>
4968
4969         * gdbtypes.c (lookup_array_range_type): Make sure the array's
4970         index type is objfile-owned if the element type is as well.
4971
4972 2018-01-31  Joel Brobecker  <brobecker@adacore.com>
4973
4974         GDB 8.1 released.
4975
4976 2018-01-30  Philipp Rudo  <prudo@linux.vnet.ibm.com>
4977
4978         * s390-linux-tdep.c: Remove includes "features/s390-linux32.c" and
4979         "features/s390x-linux64.c".
4980         (_initialize_s390_linux_tdep): Remove initialization of tdescs
4981         s390_linux32 and s390x_linux64.
4982         (s390_linux_init_abi_31, s390_linux_init_abi_64): Don't set
4983         default tdesc.
4984         * s390-tdep.c: Include "features/s390-linux32.c" and
4985         "features/s390x-linux64.c".
4986         (s390_tdesc_valid): Add check for tdesc_has_registers.
4987         (s390_gdbarch_init): Make sure there is always a valid tdesc.
4988         (_initialize_s390_tdep): Initialize tdesc_s390_linux32 and
4989         tdesc_s390x_linux64.
4990         * s390-linux-tdep.h: Move export of tdesc_s390_linux32 and
4991         tdesc_s390x_linux64 to...
4992         * s390-tdep.h: ...here.
4993
4994 2018-01-30  Pedro Alves  <palves@redhat.com>
4995
4996         PR gdb/13211
4997         * config.in, configure: Regenerate.
4998         * configure.ac: Check for getpgid.
4999         * go32-nat.c (go32_pass_ctrlc): New.
5000         (go32_target): Install it.
5001         * inf-child.c (inf_child_target): Install
5002         child_terminal_save_inferior, child_pass_ctrlc and
5003         child_interrupt.
5004         * inf-ptrace.c (inf_ptrace_interrupt): Delete.
5005         (inf_ptrace_target): No longer install it.
5006         * infcmd.c (interrupt_target_1): Adjust.
5007         * inferior.h (child_terminal_save_inferior, child_pass_ctrlc)
5008         (child_interrupt): Declare.
5009         (inferior::terminal_state): New.
5010         * inflow.c (struct terminal_info): Update comments.
5011         (inferior_process_group): Delete.
5012         (terminal_is_ours): Delete.
5013         (gdb_tty_state): New.
5014         (child_terminal_init): Adjust.
5015         (is_gdb_terminal, sharing_input_terminal_1)
5016         (sharing_input_terminal): New functions.
5017         (child_terminal_inferior): Adjust.  Use sharing_input_terminal.
5018         Set the process's actual process group in the foreground if
5019         possible.  Handle is_ours_for_output/is_ours distinction.  Don't
5020         mark terminal as the inferior's if not sharing GDB's terminal.
5021         Don't check attach_flag.
5022         (child_terminal_ours_for_output, child_terminal_ours): Adjust to
5023         pass down a target_terminal_state.
5024         (child_terminal_save_inferior): New, factored out from ...
5025         (child_terminal_ours_1): ... this.  Handle
5026         target_terminal_state::is_ours_for_output.
5027         (child_interrupt, child_pass_ctrlc): New.
5028         (inflow_inferior_exit): Clear the inferior's terminal_state.
5029         (copy_terminal_info): Copy the inferior's terminal state.
5030         (_initialize_inflow): Remove reference to terminal_is_ours.
5031         * inflow.h (inferior_process_group): Delete.
5032         * nto-procfs.c (nto_handle_sigint, procfs_interrupt): Adjust.
5033         * procfs.c (procfs_target): Don't install procfs_interrupt.
5034         (procfs_interrupt): Delete.
5035         * remote.c (remote_serial_quit_handler): Adjust.
5036         (remote_interrupt): Remove ptid parameter.  Adjust.
5037         * target-delegates.c: Regenerate.
5038         * target.c: Include "terminal.h".
5039         (target_terminal::terminal_state): Rename to ...
5040         (target_terminal::m_terminal_state): ... this.
5041         (target_terminal::init): Adjust.
5042         (target_terminal::inferior): Adjust to per-inferior
5043         terminal_state.
5044         (target_terminal::restore_inferior, target_terminal_is_ours_kind): New.
5045         (target_terminal::ours, target_terminal::ours_for_output): Use
5046         target_terminal_is_ours_kind.
5047         (target_interrupt): Remove ptid parameter.  Adjust.
5048         (default_target_pass_ctrlc): Adjust.
5049         * target.h (target_ops::to_terminal_save_inferior): New field.
5050         (target_ops::to_interrupt): Remove ptid_t parameter.
5051         (target_interrupt): Remove ptid_t parameter.  Update comment.
5052         (target_pass_ctrlc): Update comment.
5053         * target/target.h (target_terminal_state): New scoped enum,
5054         factored out of ...
5055         (target_terminal::terminal_state): ... here.
5056         (target_terminal::inferior): Update comments.
5057         (target_terminal::restore_inferior): New.
5058         (target_terminal::is_inferior, target_terminal::is_ours)
5059         (target_terminal::is_ours_for_output): Adjust.
5060         (target_terminal::scoped_restore_terminal_state): Adjust to
5061         rename, and call restore_inferior() instead of inferior().
5062         (target_terminal::scoped_restore_terminal_state::m_state): Change
5063         type.
5064         (target_terminal::terminal_state): Rename to ...
5065         (target_terminal::m_terminal_state): ... this and change type.
5066
5067 2018-01-30  Pedro Alves  <palves@redhat.com>
5068
5069         * linux-nat.c (wait_for_signal): New function.
5070         (wait_lwp, linux_nat_wait_1): Use it instead of calling sigsuspend
5071         directly.
5072         (async_terminal_is_ours)
5073         (linux_nat_terminal_inferior, linux_nat_terminal_ours): Delete.
5074         (linux_nat_add_target): Don't override
5075         to_terminal_inferior/to_terminal_ours.
5076
5077 2018-01-29  Sergio Durigan Junior  <sergiodj@redhat.com>
5078
5079         * remote.c (remote_follow_fork): Don't call "detach_inferior".
5080
5081 2018-01-28  Simon Marchi  <simon.marchi@ericsson.com>
5082
5083         * dwarf2read.c (free_dwo_files): Add forward-declaration.
5084         (dwarf2_per_objfile::~dwarf2_per_objfile): Move content from
5085         dwarf2_per_objfile_free here.
5086         (dwarf2_per_objfile_free): Remove.
5087         (_initialize_dwarf2_read): Don't register
5088         dwarf2_per_objfile_free as a registry cleanup.
5089
5090 2018-01-27  Eli Zaretskii  <eliz@gnu.org>
5091
5092         Avoid compilation errors in MinGW native builds
5093
5094         The error is triggered by including python-internal.h, and the
5095         error message is:
5096
5097              In file included from d:\usr\lib\gcc\mingw32\6.3.0\include\c++\math.h:36:0,
5098                       from build-gnulib/import/math.h:27,
5099                       from d:/usr/Python26/include/pyport.h:235,
5100                       from d:/usr/Python26/include/Python.h:58,
5101                       from python/python-internal.h:94,
5102                       from python/py-arch.c:24:
5103              d:\usr\lib\gcc\mingw32\6.3.0\include\c++\cmath:1157:11: error: '::hypot' has not been declared
5104         using ::hypot;
5105                 ^~~~~
5106
5107         This happens because Python headers define 'hypot' to expand t
5108         '_hypot' in the Windows builds.
5109         * python/python-internal.h (_hypot) [__MINGW32__]: Define back to
5110         'hypoth'.  This avoids a compilation error.
5111
5112 2018-01-26  Alan Hayward  <alan.hayward@arm.com>
5113
5114         * MAINTAINERS (Write After Approval): Fix ordering.
5115
5116 2018-01-26  Alan Hayward  <alan.hayward@arm.com>
5117
5118         * MAINTAINERS (Write After Approval): Add Alan Hayward.
5119
5120 2018-01-26  Alan Modra  <amodra@gmail.com>
5121
5122         * ppc-linux-tdep.c (powerpc32_plt_stub): Make const.
5123         (powerpc32_plt_stub_so_1): Rename from powerpc32_plt_stub_so.
5124         Remove nop.  Make const.  Comment.
5125         (powerpc32_plt_stub_so_2): New.
5126         (POWERPC32_PLT_CHECK_LEN): Rename from POWERPC32_PLT_STUB_LEN.
5127         Correct count.  Update uses.
5128         (ppc_skip_trampoline_code): Match powerpc32_plt_stub_so_2 too.
5129         Move common code reading PLT entry word.  Correct
5130         powerpc32_plt_stub PLT address calculation.
5131         * ppc64-tdep.c (ppc64_standard_linkage1): Make const.
5132         (ppc64_standard_linkage2, ppc64_standard_linkage3): Likewise.
5133         (ppc64_standard_linkage4, ppc64_standard_linkage5): Likewise.
5134         (ppc64_standard_linkage6, ppc64_standard_linkage7): Likewise.
5135         (ppc64_standard_linkage8): Likewise.
5136         * rs6000-tdep.c (ppc_insns_match_pattern): Make pattern const.
5137         Correct insns description.
5138         * ppc-tdep.h (ppc_insns_match_pattern): Update prototype.
5139
5140 2018-01-24  Pedro Alves  <palves@redhat.com>
5141
5142         GCC PR libstdc++/83906
5143         * gdbtypes.c (operator==(const dynamic_prop &,
5144         const dynamic_prop &)): New.
5145         (operator==(const range_bounds &, const range_bounds &)): New.
5146         (check_types_equal): Use them instead of memcmp.
5147         * gdbtypes.h (operator==(const dynamic_prop &,
5148         const dynamic_prop &)): Declare.
5149         (operator!=(const dynamic_prop &, const dynamic_prop &)): Declare.
5150         (operator==(const range_bounds &, const range_bounds &)): Declare.
5151         (operator!=(const range_bounds &, const range_bounds &)): Declare.
5152
5153 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
5154
5155         * s390-linux-tdep.c (s390_record_address_mask)
5156         (s390_record_calc_disp_common, s390_record_calc_disp)
5157         (s390_record_calc_disp_vsce, s390_record_calc_rl, s390_popcnt)
5158         (s390_record_gpr_g, s390_record_gpr_h, s390_record_vr)
5159         (s390_process_record): Move to s390-tdep.c.
5160         (s390_linux_init_abi_any): Adjust.
5161         * s390-tdep.c (s390_record_address_mask)
5162         (s390_record_calc_disp_common, s390_record_calc_disp)
5163         (s390_record_calc_disp_vsce, s390_record_calc_rl, s390_popcnt)
5164         (s390_record_gpr_g, s390_record_gpr_h, s390_record_vr)
5165         (s390_process_record): Moved from s390-linux-tdep.c
5166         (s390_gdbarch_init): Adjust.
5167
5168 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
5169
5170         * s390-linux-nat.c (s390-tdep.h): New include.
5171         * Makefile.in (ALL_TARGET_OBS): Add s390-tdep.o.
5172         (HFILES_NO_SRCDIR): Add s390-tdep.h.
5173         (ALLDEPFILES): Add s390-tdep.c.
5174         * configure.tgt (s390*-*-linux*): Add s390-tdep.o.
5175         * s390-linux-tdep.h (HWCAP_S390_*, S390_*_REGNUM): Move to...
5176         * s390-tdep.h: ...this.  New file.
5177         * s390-linux-tdep.c (s390-tdep.h): New include.
5178         (_initialize_s390_tdep): Rename to...
5179         (_initialize_s390_linux_tdep): ...this and adjust.
5180         (s390_abi_kind, s390_vector_abi_kind, gdbarch_tdep)
5181         (enum named opcodes, S390_NUM_GPRS, S390_NUM_FPRS): Move to
5182         s390-tdep.h.
5183         (s390_break_insn, s390_breakpoint, s390_readinstruction, is_ri)
5184         (is_ril, is_rr, is_rre, is_rs, is_rsy, is_rx, is_rxy)
5185         (s390_is_partial_instruction, s390_software_single_step)
5186         (is_non_branch_ril, s390_displaced_step_copy_insn)
5187         (s390_displaced_step_fixup, s390_displaced_step_hw_singlestep)
5188         (s390_prologue_data, s390_addr, s390_store, s390_load)
5189         (s390_check_for_saved, s390_analyze_prologue, s390_skip_prologue)
5190         (s390_register_call_saved, s390_guess_tracepoint_registers)
5191         (s390_register_name, s390_dwarf_regmap, s390_dwarf_reg_to_regnum)
5192         (regnum_is_gpr_full, regnum_is_vxr_full, s390_value_from_register)
5193         (s390_pseudo_register_name, s390_pseudo_register_type)
5194         (s390_pseudo_register_read, s390_pseudo_register_write)
5195         (s390_pseudo_register_reggroup_p, s390_ax_pseudo_register_collect)
5196         (s390_ax_pseudo_register_push_stack, s390_gen_return_address)
5197         (s390_addr_bits_remove, s390_address_class_type_flags)
5198         (s390_address_class_type_flags_to_name)
5199         (s390_address_class_name_to_type_flags, s390_effective_inner_type)
5200         (s390_function_arg_float, s390_function_arg_vector)
5201         (is_power_of_two, s390_function_arg_integer, s390_arg_state)
5202         (s390_handle_arg, s390_push_dummy_call, s390_dummy_id)
5203         (s390_frame_align, s390_register_return_value, s390_return_value)
5204         (s390_stack_frame_destroyed_p, s390_unwind_pc, s390_unwind_sp)
5205         (s390_unwind_pseudo_register, s390_adjust_frame_regnum)
5206         (s390_dwarf2_prev_register, s390_dwarf2_frame_init_reg)
5207         (s390_trad_frame_prev_register, s390_unwind_cache)
5208         (s390_prologue_frame_unwind_cache)
5209         (s390_backchain_frame_unwind_cache, s390_frame_unwind_cache)
5210         (s390_frame_this_id, s390_frame_prev_register, s390_frame_unwind)
5211         (s390_stub_unwind_cache, s390_stub_frame_unwind_cache)
5212         (s390_stub_frame_this_id, s390_stub_frame_prev_register)
5213         (s390_stub_frame_sniffer, s390_stub_frame_unwind)
5214         (s390_frame_base_address, s390_local_base_address)
5215         (s390_frame_base, s390_gcc_target_options)
5216         (s390_gnu_triplet_regexp, s390_stap_is_single_operand)
5217         (s390_validate_reg_range, s390_tdesc_valid)
5218         (s390_gdbarch_tdep_alloc, s390_gdbarch_init): Move to...
5219         * s390-tdep.c: ...this.  New file.
5220
5221 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
5222
5223         * s390-linux-tdep.c (gdbarch_tdep.s390_syscall_record): New hook.
5224         (s390_process_record, s390_gdbarch_tdep_alloc)
5225         (s390_linux_init_abi_any): Use/set new hook.
5226
5227 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
5228
5229         * s390-linux-tdep.c (osabi.h): New include.
5230         (s390_linux_init_abi_31, s390_linux_init_abi_64)
5231         (s390_linux_init_abi_any): New functions.
5232         (s390_gdbarch_init, _initialize_s390_tdep): Adjust.
5233
5234 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
5235
5236         * s390-linux-tdep.c (s390_gdbarch_init): Use gdb_assert for
5237         tdesc_has_registers check
5238
5239 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
5240
5241         * s390-linux-tdep.c (s390_tdesc_valid): New function.
5242         (s390_validate_reg_range): New macro.
5243         (s390_gdbarch_init): Adjust.
5244
5245 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
5246
5247         * s390-linux-tdep.c (gdbarch_tdep) <tdesc>: New field.
5248         (s390_gdbarch_tdep_alloc): Adjust.
5249         (s390_gdbarch_init): Adjust.
5250
5251 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
5252
5253         * s390-linux-tdep.c (gdbarch_tdep) <have_linux_v1, have_linux_v2>
5254         <have_tdb>: Change type to bool.
5255         (s390_gdbarch_tdep_alloc): Adjust.
5256         (s390_gdbarch_init): Adjust.
5257
5258 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
5259
5260         * s390-linux-tdep (s390_abi_kind) <ABI_NONE>: New default field.
5261         (gdbarch_tdep) <have_upper, have_vx>: New fields.
5262         (s390_gdbarch_tdep_alloc): New function.
5263         (s390_gdbarch_init): Allocate tdep at start and use its fields
5264         instead of separate variables.
5265
5266 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
5267
5268         * s390-linux-tdep.c (s390_gdbarch_init): Remove duplicate checks
5269         when looking for cached gdbarch and add comment for remaining.
5270
5271 2018-01-22  Pedro Alves  <palves@redhat.com>
5272             Sergio Durigan Junior  <sergiodj@redhat.com>
5273
5274         * typeprint.c (whatis_exp): Initialize "val" in the "whatis type"
5275         case.
5276
5277 2018-01-22  Maciej W. Rozycki  <macro@mips.com>
5278
5279         * MAINTAINERS: Update my company e-mail address.
5280
5281 2018-01-22  Yao Qi  <yao.qi@linaro.org>
5282
5283         * regcache.c (cooked_write_test): New function.
5284         (_initialize_regcache): Register the test.
5285
5286 2018-01-22  Yao Qi  <yao.qi@linaro.org>
5287
5288         * ia64-tdep.c (ia64_pseudo_register_read): Call
5289         regcache->cooked_read instead of regcache_cooked_read_unsigned.
5290         * m32c-tdep.c (m32c_cat_read): Likewise.
5291         (m32c_r3r2r1r0_read): Likewise.
5292         * m68hc11-tdep.c (m68hc11_pseudo_register_read): Likewise.
5293         * xtensa-tdep.c (xtensa_register_read_masked): Likewise.
5294
5295 2018-01-22  Yao Qi  <yao.qi@linaro.org>
5296
5297         * aarch64-tdep.c (aarch64_pseudo_read_value): Call regcache
5298         method raw_read instead of regcache_raw_read.
5299         * amd64-tdep.c (amd64_pseudo_register_read_value): Likewise.
5300         * arm-tdep.c (arm_neon_quad_read): Likewise.
5301         * avr-tdep.c (avr_pseudo_register_read): Likewise.
5302         * bfin-tdep.c (bfin_pseudo_register_read): Likewise.
5303         * frv-tdep.c (frv_pseudo_register_read): Likewise.
5304         * h8300-tdep.c (h8300_pseudo_register_read): Likewise.
5305         * i386-tdep.c (i386_mmx_regnum_to_fp_regnum): Likewise.
5306         (i386_pseudo_register_read_into_value): Likewise.
5307         * mep-tdep.c (mep_pseudo_cr32_read): Likewise.
5308         * msp430-tdep.c (msp430_pseudo_register_read): Likewise.
5309         * nds32-tdep.c (nds32_pseudo_register_read): Likewise.
5310         * rl78-tdep.c (rl78_pseudo_register_read): Likewise.
5311         * s390-linux-tdep.c (s390_pseudo_register_read): Likewise.
5312         * sparc-tdep.c (sparc32_pseudo_register_read):  Likewise.
5313         * sparc64-tdep.c (sparc64_pseudo_register_read): Likewise.
5314         * spu-tdep.c (spu_pseudo_register_read_spu):  Likewise.
5315         * xtensa-tdep.c (xtensa_pseudo_register_read): Likewise.
5316
5317 2018-01-22  Yao Qi  <yao.qi@linaro.org>
5318
5319         * Makefile.in (ALL_TARGET_OBS): Remove mt-tdep.o.
5320         * configure.tgt: Remove target mt.
5321         * mt-tdep.c: Remove.
5322         * regcache.c (cooked_read_test): Remove the check for mt.
5323
5324 2018-01-22  Yao Qi  <yao.qi@linaro.org>
5325
5326         * jit.c (jit_frame_prev_register): Call regcache::cooked_read
5327         instead of gdbarch_pseudo_register_read_value.
5328
5329 2018-01-22  Joel Brobecker  <brobecker@adacore.com>
5330
5331         * dwarf2read.c (need_gnat_info): Return nonzero if the cu's
5332         language is Ada.
5333
5334 2018-01-22  Joel Brobecker  <brobecker@adacore.com>
5335
5336         * linespec.c (create_sals_line_offset): Remove code that preserved
5337         the symtab_and_line's line number.
5338
5339 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
5340
5341         * varobj.c (varobj_create): Don't set valid_block when creating a
5342         floating varobj.
5343
5344 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
5345
5346         * varobj.c (varobj_create): Remove out of date comment.
5347
5348 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
5349
5350         PR mi/20395
5351         * ada-exp.y (write_var_from_sym): Pass extra parameter when
5352         updating innermost block.
5353         * parse.c (innermost_block_tracker::update): Take extra type
5354         parameter, and check types match before updating innermost block.
5355         (write_dollar_variable): Update innermost block for registers.
5356         * parser-defs.h (enum innermost_block_tracker_type): New enum.
5357         (innermost_block_tracker::innermost_block_tracker): Initialise
5358         m_types member.
5359         (innermost_block_tracker::reset): Take type parameter.
5360         (innermost_block_tracker::update): Take type parameter, and pass
5361         type through as needed.
5362         (innermost_block_tracker::m_types): New member.
5363         * varobj.c (varobj_create): Pass type when reseting innermost
5364         block.
5365
5366 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
5367
5368         * ada-exp.y (write_var_from_sym): Switch to innermost_block API.
5369         * ada-lang.c (resolve_subexp): Likewise.
5370         * breakpoint.c (set_breakpoint_condition) Likewise.
5371         (watch_command_1) Likewise.
5372         * c-exp.y (variable): Likewise.
5373         * d-exp.y (PrimaryExpression): Likewise.
5374         * f-exp.y (variable): Likewise.
5375         * go-exp.y (variable): Likewise.
5376         * m2-exp.y (variable): Likewise.
5377         * objfiles.c (objfile::~objfile): Likewise.
5378         * p-exp.y (variable): Likewise.
5379         * parse.c (innermost_block): Change type.
5380         * parser-defs.h (class innermost_block_tracker): New.
5381         (innermost_block): Change to innermost_block_tracker.
5382         * printcmd.c (display_command): Switch to innermost_block API.
5383         (do_one_display): Likewise.
5384         * rust-exp.y (do_one_display): Likewise.
5385         * symfile.c (clear_symtab_users): Likewise.
5386         * varobj.c (varobj_create): Switch to innermost_block API, replace
5387         use of innermost_block with block stored on varobj object.
5388
5389 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
5390
5391         * expression.h (innermost_block): Remove declaration.
5392         * varobj.c: Add 'parser-defs.h' include.
5393
5394 2018-01-19  Tom Tromey  <tom@tromey.com>
5395
5396         * rust-lang.c (rust_lookup_symbol_nonlocal): Look up qualified
5397         symbols in the static and global blocks.
5398
5399 2018-01-19  James Clarke  <jrtc27@jrtc27.com>
5400
5401         * nat/linux-ptrace.c: Remove unnecessary reinclusion of
5402         gdb_ptrace.h, and move including gdb_wait.h ...
5403         * nat/linux-ptrace.h: ... to here.
5404
5405 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
5406
5407         * inf-ptrace.c (inf_ptrace_detach): Adjust call to
5408         inf_ptrace_detach_success.
5409         (inf_ptrace_detach_success): Add inferior parameter, use it
5410         instead of inferior_ptid, pass it to detach_inferior.
5411         * inf-ptrace.h (inf_ptrace_detach_success): Add inferior
5412         parameter.
5413         * inferior.c (detach_inferior): Add overload that takes an
5414         inferior object.
5415         * inferior.h (detach_inferior): Likewise.
5416         * linux-nat.c (linux_nat_detach): Use the inf parameter, don't
5417         use inferior_ptid, adjust call to inf_ptrace_detach_success.
5418         * linux-thread-db.c (thread_db_detach): Use inf parameter.
5419
5420 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
5421
5422         * target.h (struct target_ops) <to_detach>: Add inferior
5423         parameter.
5424         (target_detach): Likewise.
5425         * target.c (dispose_inferior): Pass inferior down.
5426         (target_detach): Pass inferior down.  Assert that it is equal to
5427         the current inferior.
5428         * aix-thread.c (aix_thread_detach): Pass inferior down.
5429         * corefile.c (core_file_command): Pass current_inferior() down.
5430         * corelow.c (core_detach): Add inferior parameter.
5431         * darwin-nat.c (darwin_detach): Likewise.
5432         * gnu-nat.c (gnu_detach): Likewise.
5433         * inf-ptrace.c (inf_ptrace_detach): Likewise.
5434         * infcmd.c (detach_command): Pass current_inferior() down to
5435         target_detach.
5436         * infrun.c (follow_fork_inferior): Pass parent_inf to
5437         target_detach.
5438         (handle_vfork_child_exec_or_exit): Pass inf->vfork_parent to
5439         target_detach.
5440         * linux-nat.c (linux_nat_detach): Add inferior parameter.
5441         * linux-thread-db.c (thread_db_detach): Likewise.
5442         * nto-procfs.c (procfs_detach): Likewise.
5443         * procfs.c (procfs_detach): Likewise.
5444         * record.c (record_detach): Likewise.
5445         * record.h (struct inferior): Forward-declare.
5446         (record_detach): Add inferior parameter.
5447         * remote-sim.c (gdbsim_detach): Likewise.
5448         * remote.c (remote_detach_1): Likewise.
5449         (remote_detach): Likewise.
5450         (extended_remote_detach): Likewise.
5451         * sol-thread.c (sol_thread_detach): Likewise.
5452         * target-debug.h (target_debug_print_inferior_p): New macro.
5453         * target-delegates.c: Re-generate.
5454         * top.c (kill_or_detach): Pass inferior down to target_detach.
5455         * windows-nat.c (windows_detach): Add inferior parameter.
5456
5457 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
5458
5459         * target.h (struct target_ops) <to_detach>: Remove args
5460         parameter.
5461         (target_detach): Likewise.
5462         * target.c (dispose_inferior): Adjust.
5463         (target_detach): Remove args parameter, adjust.
5464         * aix-thread.c (aix_thread_detach): Adjust.
5465         * corefile.c (core_file_command): Adjust.
5466         * corelow.c (core_detach): Adjust.
5467         * darwin-nat.c (darwin_detach): Adjust.
5468         * gnu-nat.c (gnu_detach): Adjust.
5469         * inf-ptrace.c (inf_ptrace_detach): Adjust.
5470         * infcmd.c (detach_command): Adjust
5471         * infrun.c (follow_fork_inferior): Adjust.
5472         (handle_vfork_child_exec_or_exit): Adjust.
5473         * linux-fork.c (linux_fork_detach): Remove args parameter.
5474         * linux-fork.h (linux_fork_detach): Likewise.
5475         * linux-nat.c (linux_nat_detach): Likewise, and adjust.
5476         * linux-thread-db.c (thread_db_detach): Likewise.
5477         * nto-procfs.c (procfs_detach): Likewise.
5478         * procfs.c (procfs_detach): Likewise.
5479         (do_detach): Remove signo parameter.
5480         * record.c (record_detach): Remove args parameter.
5481         * record.h (record_detach): Likewise.
5482         * remote-sim.c (gdbsim_detach): Likewise.
5483         * remote.c (remote_detach_1): Likewise.
5484         (remote_detach): Likewise.
5485         (extended_remote_detach): Likewise.
5486         * sol-thread.c (sol_thread_detach): Likewise.
5487         * target-delegates.c: Re-generate.
5488         * top.c (struct qt_args) <args>: Remove field.
5489         (kill_or_detach): Don't pass args.
5490         (quit_force): Don't set args.
5491         * windows-nat.c (windows_detach): Remove args parameter.
5492
5493 2018-01-19  Yao Qi  <yao.qi@linaro.org>
5494
5495         * arm-linux-tdep.c (arm_linux_gcc_target_options): New function.
5496         (arm_linux_init_abi): Install it.
5497
5498 2018-01-19  Yao Qi  <yao.qi@linaro.org>
5499
5500         * osabi.c (gdb_osabi_names): Extend the regexp for
5501         arm-linux-gnueabihf.
5502
5503 2018-01-18  Yao Qi  <yao.qi@linaro.org>
5504
5505         * dwarf2read.c (abbrev_table) <abbrevs>: Rename it to
5506         m_abbrevs.
5507         (abbrev_table::add_abbrev): Update.
5508         (abbrev_table::lookup_abbrev): Update.
5509
5510 2018-01-18  Yao Qi  <yao.qi@linaro.org>
5511
5512         * ppc-linux-tdep.c (ppu2spu_prev_register): Call cooked_read.
5513
5514 2018-01-17  Sergio Durigan Junior  <sergiodj@redhat.com>
5515
5516         * compile/compile.c (compile_to_object): Convert "triplet_rx"
5517         to "std::string".
5518
5519 2018-01-17  Tom Tromey  <tom@tromey.com>
5520
5521         * dwarf2read.c (symbolp): Remove typedef.  Don't instantiate VEC.
5522
5523 2018-01-17  Tom Tromey  <tom@tromey.com>
5524
5525         * gdbtypes.h (add_dyn_prop): Remove objfile parameter.
5526         * gdbtypes.c (add_dyn_prop): Remove objfile parameter.
5527         (create_array_type_with_stride): Update.
5528         * dwarf2read.c (set_die_type): Update.
5529
5530 2018-01-17  Tom Tromey  <tom@tromey.com>
5531
5532         * dwarf2read.c (delayed_method_info): Remove typedef.
5533         (dwarf2_cu::method_info): Now a std::vector.
5534         (add_to_method_list): Update.
5535         (free_delayed_list): Remove.
5536         (compute_delayed_physnames): Update.
5537         (process_full_comp_unit, process_full_type_unit): Clear the method
5538         list.  Remove cleanups.
5539         (psymtab_include_file_name): Add name_holder parameter.  Use
5540         unique_xmalloc_ptr.
5541         (dwarf_decode_lines): Update.
5542
5543 2018-01-17  Tom Tromey  <tom@tromey.com>
5544             Simon Marchi  <simon.marchi@ericsson.com>
5545
5546         * dwarf2read.c (struct dwarf2_cu): Add constructor, destructor.
5547         (dwarf2_per_objfile::free_cached_comp_units)
5548         (init_tu_and_read_dwo_dies, init_cutu_and_read_dies)
5549         (init_cutu_and_read_dies_no_follow): Update.
5550         (dwarf2_cu::dwarf2_cu): Rename from init_one_comp_unit.
5551         (dwarf2_cu::~dwarf2_cu): New.
5552         (free_heap_comp_unit, free_stack_comp_unit): Remove.
5553         (age_cached_comp_units, free_one_cached_comp_unit): Update.
5554
5555 2018-01-17  Tom Tromey  <tom@tromey.com>
5556             Simon Marchi  <simon.marchi@ericsson.com>
5557
5558         * dwarf2read.c (struct dwarf2_cu) <abbrev_table>: Remove.
5559         (struct die_reader_specs) <abbrev_table>: New member.
5560         (struct abbrev_table): Add constructor.
5561         <alloc_abbrev, add_abbrev, lookup_abbrev>: Declare.
5562         <abbrev_obstack>: Now an auto_obstack.
5563         (abbrev_table_up): New typedef.
5564         (init_cu_die_reader): Add abbrev_table parameter.
5565         (read_cutu_die_from_dwo): Remove abbrev_table_provided parameter.
5566         Add result_dwo_abbrev_table.
5567         (init_tu_and_read_dwo_dies, init_cutu_and_read_dies)
5568         (init_cutu_and_read_dies_no_follow, build_type_psymtabs_1):
5569         Update.
5570         (peek_die_abbrev): Take die_reader_specs, not dwarf_cu as
5571         parameter.
5572         (skip_children): Update.
5573         (abbrev_table::alloc_abbrev): Rename from
5574         abbrev_table_alloc_abbrev.
5575         (abbrev_table::add_abbrev): Rename from abbrev_table_add_abbrev.
5576         (abbrev_table::lookup_abbrev): Rename from
5577         abbrev_table_lookup_abbrev.
5578         (abbrev_table_read_table): Return abbrev_table_up.
5579         (abbrev_table_free, abbrev_table_free_cleanup)
5580         (dwarf2_read_abbrevs, dwarf2_free_abbrev_table): Remove.
5581         (load_partial_dies): Update.
5582
5583 2018-01-17  Tom Tromey  <tom@tromey.com>
5584
5585         * dwarf2read.c (dwarf2_compute_name): Update comment.
5586         (read_func_scope, read_variable): Update.
5587         (new_symbol): Remove.
5588         (new_symbol_full): Rename to new_symbol.
5589
5590 2018-01-17  Mike Gulick  <mgulick@mathworks.com>
5591
5592         PR gdb/16577
5593         * gdb_bfd.c (gdb_bfd_map_section): If unable to read object file, issue
5594         a warning instead of throwing an error, set section size to 0 and return
5595         NULL.
5596         * gdb_bfd.h (gdb_bfd_map_section): Update description.
5597
5598 2018-01-17  Simon Marchi  <simon.marchi@ericsson.com>
5599
5600         * nat/linux-ptrace.h (linux_ptrace_attach_fail_reason): Return
5601         std::string.
5602         (linux_ptrace_attach_fail_reason_string): Likewise.
5603         * nat/linux-ptrace.c (linux_ptrace_attach_fail_reason):
5604         Likewise.
5605         (linux_ptrace_attach_fail_reason_string): Likewise.
5606         * linux-nat.c (attach_proc_task_lwp_callback): Adjust.
5607
5608 2018-01-17  Simon Marchi  <simon.marchi@ericsson.com>
5609
5610         * linux-nat.c (linux_nat_attach): Remove xstrdup.
5611
5612 2018-01-17  Eldar Abusalimov  <eldar.abusalimov@jetbrains.com>
5613
5614         PR gdb/21559
5615         * configure.ac: Include <sys/types.h> prior to <sys/user.h> when
5616         checking for fs_base/gs_base fields in struct user_regs_struct.
5617         * configure: Regenerate.
5618
5619 2018-01-17  Yao Qi  <yao.qi@linaro.org>
5620
5621         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): New
5622         function.
5623         (aarch64_linux_init_abi): Install it to gdbarch hook
5624         gcc_target_options.
5625
5626 2018-01-15  Pedro Alves  <palves@redhat.com>
5627
5628         * common/signals-state-save-restore.c
5629         (save_original_signals_state): Fix typos.
5630
5631 2017-01-12  Tom Tromey  <tom@tromey.com>
5632             Sergio Durigan Junior  <sergiodj@redhat.com>
5633
5634         * Makefile.in (install-only): Install gdb-add-index.
5635
5636 2018-01-12  John Baldwin  <jhb@FreeBSD.org>
5637
5638         * fbsd-tdep.c (KVE_PROTECTION): Correct value.
5639
5640 2018-01-12  Andreas Arnez  <arnez@linux.vnet.ibm.com>
5641
5642         * infrun.c (keep_going_pass_signal): Clear step-over info when
5643         insert_breakpoints fails.
5644
5645 2018-01-11  Pedro Alves  <palves@redhat.com>
5646
5647         PR gdb/22583
5648         * infrun.c (resume): Rename to ...
5649         (resume_1): ... this.
5650         (resume): Reimplement as wrapper around resume_1.
5651
5652 2018-01-11  Pedro Alves  <palves@redhat.com>
5653
5654         PR remote/22597
5655         * remote.c (remote_parse_stop_reply): Default to the last-set
5656         general thread instead of to 'magic_null_ptid'.
5657
5658 2018-01-10  Pedro Alves  <palves@redhat.com>
5659
5660         * language.h (language_get_symbol_name_matcher): Rename ...
5661         (get_symbol_name_matcher): ... this.
5662         * language.c (language_get_symbol_name_matcher): Ditto.
5663         * dictionary.c, linespec.c, minsyms.c, psymtab.c, symtab.c: All
5664         callers adjusted.
5665
5666 2018-01-10  Pedro Alves  <palves@redhat.com>
5667
5668         PR gdb/22670
5669         * dwarf2read.c
5670         (gdb_index_symbol_name_matcher::gdb_index_symbol_name_matcher):
5671         Adjust to use language_get_symbol_name_matcher instead of
5672         language_defn::la_get_symbol_name_matcher.
5673         * language.c (language_get_symbol_name_matcher): If in Ada mode
5674         and the lookup name is a verbatim match, return Ada's matcher.
5675         * language.h (language_get_symbol_name_matcher): Adjust comment.
5676         (ada_lookup_name_info::verbatim_p):: New method.
5677
5678 2018-01-10  Pedro Alves  <palves@redhat.com>
5679
5680         PR gdb/22670
5681         * ada-lang.c (ada_collect_symbol_completion_matches): If the
5682         minsym's language is language_auto or language_cplus, pass down
5683         language_ada instead.
5684         * symtab.c (compare_symbol_name): Don't frob symbol language here.
5685
5686 2018-01-10  Pedro Alves  <palves@redhat.com>
5687
5688         PR gdb/22670
5689         * minsyms.c (linkage_name_str): New function.
5690         (iterate_over_minimal_symbols): Use it.
5691
5692 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
5693
5694         * NEWS: Document that 'info proc' now works on FreeBSD.
5695
5696 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
5697
5698         * configure.ac: Check for kinfo_getfile in libutil.
5699         * configure: Regenerate.
5700         * config.in: Regenerate.
5701         * fbsd-nat.c: Include "fbsd-tdep.h".
5702         (fbsd_fetch_cmdline): New.
5703         (fbsd_fetch_kinfo_proc): Move earlier and change to return a bool
5704         rather than calling error.
5705         (fbsd_info_proc): New.
5706         (fbsd_thread_name): Report error if fbsd_fetch_kinfo_proc fails.
5707         (fbsd_wait): Report warning if fbsd_fetch_kinfo_proc fails.
5708         (fbsd_nat_add_target): Set "to_info_proc" to "fbsd_info_proc".
5709
5710 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
5711
5712         * fbsd-nat.c (struct free_deleter): Remove.
5713         (fbsd_find_memory_regions): Use gdb::unique_xmalloc_ptr<>.
5714
5715 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
5716
5717         * fbsd-nat.c (fbsd_pid_to_exec_file) [KERN_PROC_PATHNAME]: Return
5718         NULL for an empty pathname.
5719
5720 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
5721
5722         * fbsd-tdep.c (KVE_STRUCTSIZE, KVE_START, KVE_END, KVE_OFFSET)
5723         (KVE_FLAGS, KVE_PROTECTION, KVE_PATH, KINFO_VME_PROT_READ)
5724         (KINFO_VME_PROT_WRITE, KINFO_VME_PROT_EXEC, KINFO_VME_FLAG_COW)
5725         (KINFO_VME_FLAG_NEEDS_COPY, KINFO_VME_FLAG_NOCOREDUMP)
5726         (KINFO_VME_FLAG_SUPER, KINFO_VME_FLAG_GROWS_UP)
5727         (KINFO_VME_FLAG_GROWS_DOWN, KF_STRUCTSIZE, KF_TYPE, KF_FD)
5728         (KF_PATH, KINFO_FILE_TYPE_VNODE, KINFO_FILE_FD_TYPE_CWD)
5729         (KINFO_FILE_FD_TYPE_TEXT, SIG_WORDS, struct kinfo_proc_layout)
5730         (kinfo_proc_layout_32, kinfo_proc_layout_i386)
5731         (kinfo_proc_layout_64, fbsd_vm_map_entry_flags)
5732         (fbsd_core_info_proc_mappings, fbsd_core_vnode_path)
5733         (fbsd_core_fetch_timeval, fbsd_print_sigset)
5734         (fbsd_core_info_proc_status, fbsd_core_info_proc): New.
5735         (fbsd_init_abi):  Install gdbarch "core_info_proc" method.
5736         * fbsd-tdep.h (fbsd_vm_map_entry_flags): New.
5737
5738 2018-01-08  Samuel Thibault  <samuel.thibault@ens-lyon.org>
5739
5740         * gdb/gnu-nat.c: Include <elf.h> and <link.h>.
5741         (gnu_xfer_auxv): New function.
5742         (gnu_xfer_partial): Call gnu_xfer_auxv when `object' is
5743         TARGET_OBJECT_AUXV.
5744
5745 2018-01-08  Yao Qi  <yao.qi@linaro.org>
5746             Simon Marchi  <simon.marchi@ericsson.com>
5747
5748         * Makefile.in (COMMON_SFILES): Remove selftest-arch.c and
5749         common/selftest.c.
5750         (COMMON_OBS): Remove selftest.o.
5751         * configure.ac: Append selftest-arch.c and common/selftest.c to
5752         CONFIG_SRCS.  Append selftest-arch.o and selftest.o to COMMON_OBS.
5753         * configure: Re-generated.
5754         * maint.c (maintenance_selftest): Wrap selftests::run_tests with
5755         GDB_SELF_TEST.
5756         (maintenance_info_selftests): Likewise.
5757
5758 2018-01-08  Xavier Roirand  <roirand@adacore.com>
5759
5760         * ada-valprint.c (val_print_packed_array_elements): Use
5761         proper number of elements when printing an array indexed
5762         by an enumeration type.
5763
5764 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
5765
5766         * dwarf2read.c (struct dwarf2_cu) <dwarf2_per_objfile>: Remove.
5767         (dw2_get_file_names_reader): Adjust.
5768         (lookup_dwo_signatured_type): Adjust.
5769         (lookup_dwp_signatured_type): Adjust.
5770         (lookup_signatured_type): Adjust.
5771         (create_type_unit_group): Adjust.
5772         (get_type_unit_group): Adjust.
5773         (process_psymtab_comp_unit_reader): Adjust.
5774         (build_type_psymtabs_reader): Adjust.
5775         (scan_partial_symbols): Adjust.
5776         (add_partial_symbol): Adjust.
5777         (add_partial_subprogram): Adjust.
5778         (peek_die_abbrev): Adjust.
5779         (fixup_go_packaging): Adjust.
5780         (process_imported_unit_die): Adjust.
5781         (dwarf2_compute_name): Adjust.
5782         (dwarf2_physname): Adjust.
5783         (read_import_statement): Adjust.
5784         (handle_DW_AT_stmt_list): Adjust.
5785         (read_file_scope): Adjust.
5786         (read_func_scope): Adjust.
5787         (read_lexical_block_scope): Adjust.
5788         (read_call_site_scope): Adjust.
5789         (read_variable): Adjust.
5790         (dwarf2_rnglists_process): Adjust.
5791         (dwarf2_ranges_process): Adjust.
5792         (dwarf2_ranges_read): Adjust.
5793         (dwarf2_get_pc_bounds): Adjust.
5794         (dwarf2_record_block_ranges): Adjust.
5795         (dwarf2_add_field): Adjust.
5796         (dwarf2_add_member_fn): Adjust.
5797         (read_structure_type): Adjust.
5798         (process_structure_scope): Adjust.
5799         (read_enumeration_type): Adjust.
5800         (read_array_type): Adjust.
5801         (mark_common_block_symbol_computed): Adjust.
5802         (read_common_block): Adjust.
5803         (read_namespace_type): Adjust.
5804         (read_namespace): Adjust.
5805         (read_module_type): Adjust.
5806         (read_tag_pointer_type): Adjust.
5807         (read_tag_ptr_to_member_type): Adjust.
5808         (read_tag_string_type): Adjust.
5809         (read_subroutine_type): Adjust.
5810         (read_typedef): Adjust.
5811         (read_base_type): Adjust.
5812         (attr_to_dynamic_prop): Adjust.
5813         (read_subrange_type): Adjust.
5814         (read_unspecified_type): Adjust.
5815         (dwarf2_read_abbrevs): Adjust.
5816         (load_partial_dies): Adjust.
5817         (read_partial_die): Adjust.
5818         (find_partial_die): Adjust.
5819         (guess_partial_die_structure_name): Adjust.
5820         (fixup_partial_die): Adjust.
5821         (read_attribute_value): Adjust.
5822         (read_addr_index): Adjust.
5823         (read_addr_index_from_leb128): Adjust.
5824         (read_str_index): Adjust.
5825         (dwarf2_string_attr): Adjust.
5826         (get_debug_line_section): Adjust.
5827         (dwarf_decode_line_header): Adjust.
5828         (lnp_state_machine::check_line_address): Adjust.
5829         (dwarf_decode_lines_1): Adjust.
5830         (dwarf_decode_lines): Adjust.
5831         (dwarf2_start_symtab): Adjust.
5832         (var_decode_location): Adjust.
5833         (new_symbol_full): Adjust.
5834         (dwarf2_const_value_data): Adjust.
5835         (dwarf2_const_value_attr): Adjust.
5836         (dwarf2_const_value): Adjust.
5837         (die_type): Adjust.
5838         (die_containing_type): Adjust.
5839         (build_error_marker_type): Adjust.
5840         (lookup_die_type): Adjust.
5841         (guess_full_die_structure_name): Adjust.
5842         (anonymous_struct_prefix): Adjust.
5843         (determine_prefix): Adjust.
5844         (dwarf2_name): Adjust.
5845         (follow_die_ref_or_sig): Adjust.
5846         (follow_die_offset): Adjust.
5847         (follow_die_ref): Adjust.
5848         (follow_die_sig_1): Adjust.
5849         (follow_die_sig): Adjust.
5850         (get_signatured_type): Adjust.
5851         (get_DW_AT_signature_type): Adjust.
5852         (decode_locdesc): Adjust.
5853         (dwarf_decode_macros): Adjust.
5854         (cu_debug_loc_section): Adjust.
5855         (fill_in_loclist_baton): Adjust.
5856         (dwarf2_symbol_mark_computed): Adjust.
5857         (init_one_comp_unit): Don't assign
5858         dwarf2_cu::dwarf2_per_objfile.
5859         (set_die_type): Adjust.
5860
5861 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
5862
5863         * dwarf2read.c (struct mapped_debug_names): Add constructor.
5864         <dwarf2_per_objfile>: New field.
5865         (dwarf2_per_objfile): Remove global.
5866         (get_dwarf2_per_objfile): New function.
5867         (set_dwarf2_per_objfile): New function.
5868         (dwarf2_build_psymtabs_hard): Change objfile parameter to
5869         dwarf2_per_objfile.
5870         (abbrev_table_read_table): Add dwarf2_per_objfile parameter.
5871         (read_abbrev_offset): Likewise.
5872         (read_indirect_string): Likewise.
5873         (read_indirect_line_string): Likewise.
5874         (read_indirect_string_at_offset): Likewise.
5875         (read_indirect_string_from_dwz): Likewise.
5876         (dwarf2_find_containing_comp_unit): Change objfile parameter to
5877         dwarf2_per_objfile.
5878         (age_cached_comp_units): Add dwarf2_per_objfile parameter.
5879         (create_all_comp_units): Change objfile parameter to
5880         dwarf2_per_objfile.
5881         (create_all_type_units): Likewise.
5882         (process_queue): Add dwarf2_per_objfile parameter.
5883         (read_and_check_comp_unit_head): Likewise.
5884         (lookup_dwo_unit_in_dwp): Likewise.
5885         (get_dwp_file): Likewise.
5886         (process_cu_includes): Likewise.
5887         (struct free_dwo_file_cleanup_data): New struct.
5888         (dwarf2_has_info): Use get_dwarf2_per_objfile and
5889         set_dwarf2_per_objfile.
5890         (dwarf2_get_dwz_file): Add dwarf2_per_objfile parameter.
5891         (dw2_do_instantiate_symtab): Get dwarf2_per_objfile from
5892         context, adjust calls.
5893         (dw2_instantiate_symtab): Likewise.
5894         (dw2_get_cutu): Add dwarf2_per_objfile parameter.
5895         (dw2_get_cu): Likewise.
5896         (create_cu_from_index_list): Change objfile parameter to
5897         dwarf2_per_objfile.
5898         (create_cus_from_index_list): Get dwarf2_per_objfile from
5899         context, adjust calls.
5900         (create_cus_from_index): Likewise.
5901         (create_signatured_type_table_from_index): Change objfile
5902         parameter to dwarf2_per_objfile.
5903         (create_signatured_type_table_from_debug_names): Change objfile
5904         parameter to dwarf2_per_objfile.
5905         (create_addrmap_from_index): Likewise.
5906         (create_addrmap_from_aranges): Likewise.
5907         (dwarf2_read_index): Use get_dwarf2_per_objfile, adjust calls.
5908         (dw2_setup): Remove.
5909         (dw2_get_file_names_reader): Get dwarf2_per_objfile from
5910         context.
5911         (dw2_find_last_source_symtab): Get dwarf2_per_objfile using
5912         get_dwarf2_per_objfile.
5913         (dw2_forget_cached_source_info): Likewise.
5914         (dw2_map_symtabs_matching_filename): Likewise.
5915         (struct dw2_symtab_iterator) <index>: Remove.
5916         <dwarf2_per_objfile>: New field.
5917         (dw2_symtab_iter_init): Replace index parameter with
5918         dwarf2_per_objfile.
5919         (dw2_symtab_iter_next): Use dwarf2_per_objfile from iter.
5920         (dw2_lookup_symbol): Use get_dwarf2_per_objfile and adjust.
5921         (dw2_print_stats): Likewise.
5922         (dw2_dump): Likewise.
5923         (dw2_expand_symtabs_for_function): Likewise.
5924         (dw2_expand_all_symtabs): Likewise.
5925         (dw2_expand_symtabs_with_fullname): Likewise.
5926         (dw2_expand_marked_cus): Replace index and objfile parameters
5927         with dwarf2_per_objfile.
5928         (dw_expand_symtabs_matching_file_matcher): Add
5929         dwarf2_per_objfile parameter and adjust calls.
5930         (dw2_expand_symtabs_matching): Use get_dwarf2_per_objfile and
5931         adjust calls.
5932         (dw2_find_pc_sect_compunit_symtab): Don't call dw2_setup.
5933         (dw2_map_symbol_filenames): Use get_dwarf2_per_objfile and
5934         adjust calls.
5935         (create_cus_from_debug_names_list): Replace objfile parameter
5936         with dwarf2_per_objfile and adjust calls.
5937         (create_cus_from_debug_names): Likewise.
5938         (dwarf2_read_debug_names): Likewise.
5939         (mapped_debug_names::namei_to_name): Adjust call.
5940         (dw2_debug_names_iterator::next): Likewise.
5941         (dw2_debug_names_iterator::find_vec_in_debug_names): Likewise.
5942         (dw2_debug_names_lookup_symbol): Use get_dwarf2_per_objfile.
5943         (dw2_debug_names_dump): Likewise.
5944         (dw2_debug_names_expand_symtabs_for_function): Likewise.
5945         (dw2_debug_names_expand_symtabs_matching): Likewise.
5946         (dwarf2_initialize_objfile): Likewise.
5947         (dwarf2_build_psymtabs): Likewise.
5948         (get_abbrev_section_for_cu): Get dwarf2_per_objfile from
5949         this_cu.
5950         (error_check_comp_unit_head): Add dwarf2_per_objfile parameter.
5951         (read_and_check_comp_unit_head): Likewise.
5952         (read_abbrev_offset): Likewise.
5953         (create_debug_type_hash_table): Likewise.
5954         (create_debug_types_hash_table): Likewise.
5955         (create_all_type_units): Replace objfile parameter with
5956         dwarf2_per_objfile.
5957         (add_type_unit): Add dwarf2_per_objfile parameter.
5958         (fill_in_sig_entry_from_dwo_entry): Replace objfile parameter
5959         with dwarf2_per_objfile.
5960         (lookup_dwo_signatured_type): Get dwarf2_per_objfile from cu.
5961         (lookup_dwp_signatured_type): Likewise.
5962         (lookup_signatured_type): Likewise.
5963         (read_cutu_die_from_dwo): Likewise.
5964         (init_tu_and_read_dwo_dies): Likewise.
5965         (init_cutu_and_read_dies): Likewise.
5966         (init_cutu_and_read_dies_no_follow): Likewise.
5967         (allocate_type_unit_groups_table): Add objfile parameter.
5968         (create_type_unit_group): Use dwarf2_per_objfile from cu.
5969         (get_type_unit_group): Likewise.
5970         (process_psymtab_comp_unit): Update call.
5971         (build_type_psymtabs_reader): Use dwarf2_per_objfile from cu.
5972         (build_type_psymtabs_1): Add dwarf2_per_objfile parameter.
5973         (print_tu_stats): Likewise.
5974         (build_type_psymtab_dependencies): Use dwarf2_per_objfile passed
5975         in void* parameter.
5976         (build_type_psymtabs): Change objfile parameter to
5977         dwarf2_per_objfile.
5978         (process_skeletonless_type_unit): Use dwarf2_per_objfile
5979         passed in void* parameter.
5980         (process_skeletonless_type_units): Change objfile parameter to
5981         dwarf2_per_objfile.
5982         (set_partial_user): Likewise.
5983         (dwarf2_build_psymtabs_hard): Likewise.
5984         (read_comp_units_from_section): Likewise.
5985         (create_all_comp_units): Likewise.
5986         (scan_partial_symbols): Update calls.
5987         (add_partial_symbol): Likewise.
5988         (dwarf2_read_symtab): Use get_dwarf2_per_objfile.
5989         (maybe_queue_comp_unit): Use dwarf2_read_symtab from cu.
5990         (process_queue): Add dwarf2_per_objfile parameter.
5991         (get_compunit_symtab): Use dwarf2_per_objfile from cu.
5992         (compute_compunit_symtab_includes): Likewise.
5993         (process_cu_includes): Add dwarf2_per_objfile parameter.
5994         (process_full_comp_unit): Use dwarf2_per_objfile from cu.
5995         (process_full_type_unit): Likewise.
5996         (process_imported_unit_die): Update call.
5997         (handle_DW_AT_stmt_list): Use dwarf2_per_objfile from cu.
5998         (read_file_scope): Likewise.
5999         (allocate_dwo_file_hash_table): Add objfile parameter.
6000         (lookup_dwo_file_slot): Add dwarf2_per_objfile parameter.
6001         (create_cus_hash_table): Likewise.
6002         (create_dwp_hash_table): Likewise.
6003         (create_dwo_unit_in_dwp_v1): Likewise.
6004         (create_dwp_v2_section): Likewise.
6005         (create_dwo_unit_in_dwp_v2): Likewise.
6006         (lookup_dwo_unit_in_dwp): Likewise.
6007         (try_open_dwop_file): Likewise.
6008         (open_dwo_file): Likewise. Use dwarf2_per_objfile from cu.
6009         (open_and_init_dwo_file): Use dwarf2_per_objfile from cu, update
6010         cleanup to include a reference to dwarf2_per_objfile.
6011         (open_dwp_file): Add dwarf2_per_objfile parameter.
6012         (open_and_init_dwp_file): Likewise.
6013         (get_dwp_file): Likewise.
6014         (lookup_dwo_cutu): Use dwarf2_per_objfile from cu.
6015         (queue_and_load_all_dwo_tus): Update call.
6016         (free_dwo_file_cleanup): Use dwarf2_per_objfile from cleanup
6017         data.
6018         (dwarf2_rnglists_process): Use dwarf2_per_objfile from cu.
6019         (dwarf2_ranges_process): Likewise.
6020         (dwarf2_get_pc_bounds): Likewise.
6021         (mark_common_block_symbol_computed): Likewise.
6022         (abbrev_table_read_table): Add dwarf2_per_objfile parameter.
6023         (dwarf2_read_abbrevs): Update call.
6024         (read_partial_die): Use dwarf2_per_objfile from cu.
6025         (find_partial_die): Likewise.
6026         (fixup_partial_die): Likewise.
6027         (read_attribute_value): Likewise.
6028         (read_indirect_string_at_offset_from): Add objfile parameter.
6029         (read_indirect_string_at_offset): Add dwarf2_per_objfile
6030         parameter.
6031         (read_indirect_string_from_dwz): Add objfile parameter.
6032         (read_indirect_string): Add objfile parameter.
6033         (read_addr_index_1): Add dwarf2_per_objfile parameter.
6034         (read_addr_index): Use dwarf2_per_objfile from cu.
6035         (dwarf2_read_addr_index): Use dwarf2_per_objfile from cu, don't
6036         call dw2_setup.
6037         (read_str_index): Use dwarf2_per_objfile from cu.
6038         (get_debug_line_section): Likewise.
6039         (read_formatted_entries): Add dwarf2_per_objfile parameter.
6040         (dwarf_decode_line_header): Use dwarf2_per_objfile from cu.
6041         (new_symbol_full): Use dwarf2_per_objfile from cu.
6042         (build_error_marker_type): Likewise.
6043         (lookup_die_type): Likewise.
6044         (determine_prefix): Likewise.
6045         (follow_die_offset): Likewise.
6046         (dwarf2_fetch_die_loc_sect_off): Use get_dwarf2_per_objfile.
6047         (dwarf2_fetch_constant_bytes): Don't call dw2_setup.
6048         (dwarf2_fetch_die_type_sect_off): Likewise.
6049         (dwarf2_get_die_type): Likewise.
6050         (follow_die_sig_1): Use dwarf2_per_objfile from cu.
6051         (get_signatured_type): Likewise.
6052         (get_DW_AT_signature_type): Likewise.
6053         (dwarf_decode_macro_bytes): Add dwarf2_per_objfile parameter.
6054         (dwarf_decode_macros): Use dwarf2_per_objfile from cu.
6055         (cu_debug_loc_section): Likewise.
6056         (fill_in_loclist_baton): Likewise.
6057         (dwarf2_symbol_mark_computed): Likewise.
6058         (dwarf2_find_containing_comp_unit): Change objfile parameter to
6059         dwarf2_per_objfile.
6060         (free_cached_comp_units): Use dwarf2_per_objfile passed in void*
6061         parameter.
6062         (age_cached_comp_units): Add dwarf2_per_objfile parameter.
6063         (free_one_cached_comp_unit): Use dwarf2_per_objfile from cu.
6064         (dwarf2_free_objfile): Use get_dwarf2_per_objfile.
6065         (set_die_type): Use dwarf2_free_objfile from cu.
6066         (get_die_type_at_offset): Likewise.
6067         (dwarf2_per_objfile_free): Don't assign global variable.
6068         (debug_names) <constructor>: Add dwarf2_per_objfile
6069         parameter, update m_debugstrlookup construction.
6070         (debug_names::debug_str_lookup): Add dwarf2_per_objfile
6071         parameter.
6072         <m_dwarf2_per_objfile>: New field.
6073         <lookup>: Use m_dwarf2_per_objfile.
6074         (check_dwarf64_offsets): Add dwarf2_per_objfile parameter.
6075         (psyms_seen_size): Likewise.
6076         (write_gdbindex): Replace objfile parameter with
6077         dwarf2_per_objfile.
6078         (write_debug_names): Likewise.
6079         (write_psymtabs_to_index): Likewise.
6080         (save_gdb_index_command): Use get_dwarf2_per_objfile, update
6081         calls.
6082
6083 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
6084
6085         * dwarf2read.c (struct dwarf2_cu) <objfile>: Remove.
6086         <dwarf2_per_objfile>: New field.
6087         (struct dwarf2_per_cu_data) <objfile>: Remove.
6088         <dwarf2_per_objfile>: New field.
6089         (create_cu_from_index_list): Assign dwarf2_per_objfile instead
6090         of objfile.
6091         (create_signatured_type_table_from_index): Likewise.
6092         (create_debug_type_hash_table): Likewise.
6093         (fill_in_sig_entry_from_dwo_entry): Likewise.
6094         (lookup_dwo_unit): Access objfile through dwarf2_per_objfile.
6095         (create_type_unit_group): Assign dwarf2_per_objfile instead of
6096         objfile.
6097         (create_partial_symtab): Access objfile through
6098         dwarf2_per_objfile.
6099         (process_psymtab_comp_unit_reader): Likewise.
6100         (read_comp_units_from_section): Likewise.
6101         (scan_partial_symbols): Likewise.
6102         (add_partial_symbol): Likewise.
6103         (add_partial_subprogram): Likewise.
6104         (peek_die_abbrev): Likewise.
6105         (fixup_go_packaging): Likewise.
6106         (process_full_comp_unit): Likewise.
6107         (process_full_type_unit): Likewise.
6108         (process_imported_unit_die): Likewise.
6109         (dwarf2_compute_name): Likewise.
6110         (dwarf2_physname): Likewise.
6111         (read_import_statement): Likewise.
6112         (create_cus_hash_table): Assign dwarf2_physname instead of
6113         objfile.
6114         (read_func_scope): Access objfile through dwarf2_per_objfile.
6115         (read_lexical_block_scope): Likewise.
6116         (read_call_site_scope): Likewise.
6117         (read_variable): Likewise.
6118         (dwarf2_rnglists_process): Likewise.
6119         (dwarf2_ranges_process): Likewise.
6120         (dwarf2_ranges_read): Likewise.
6121         (dwarf2_record_block_ranges): Likewise.
6122         (dwarf2_add_field): Likewise.
6123         (dwarf2_add_member_fn): Likewise.
6124         (read_structure_type): Likewise.
6125         (process_structure_scope): Likewise.
6126         (read_enumeration_type): Likewise.
6127         (read_array_type): Likewise.
6128         (read_common_block): Likewise.
6129         (read_namespace_type): Likewise.
6130         (read_namespace): Likewise.
6131         (read_module_type): Likewise.
6132         (read_tag_pointer_type): Likewise.
6133         (read_tag_ptr_to_member_type): Likewise.
6134         (read_tag_string_type): Likewise.
6135         (read_subroutine_type): Likewise.
6136         (read_typedef): Likewise.
6137         (read_base_type): Likewise.
6138         (attr_to_dynamic_prop): Likewise.
6139         (read_subrange_type): Likewise.
6140         (read_unspecified_type): Likewise.
6141         (load_partial_dies): Likewise.
6142         (read_partial_die): Likewise.
6143         (find_partial_die): Likewise.
6144         (guess_partial_die_structure_name): Likewise.
6145         (fixup_partial_die): Likewise.
6146         (read_attribute_value): Likewise.
6147         (read_addr_index_from_leb128): Likewise.
6148         (dwarf2_read_addr_index): Likewise.
6149         (dwarf2_string_attr): Likewise.
6150         (lnp_state_machine::check_line_address): Likewise.
6151         (dwarf_decode_lines_1): Likewise.
6152         (dwarf_decode_lines): Likewise.
6153         (dwarf2_start_symtab): Likewise.
6154         (var_decode_location): Likewise.
6155         (new_symbol_full): Likewise.
6156         (dwarf2_const_value_data): Likewise.
6157         (dwarf2_const_value_attr): Likewise.
6158         (dwarf2_const_value): Likewise.
6159         (die_type): Likewise.
6160         (die_containing_type): Likewise.
6161         (lookup_die_type): Likewise.
6162         (guess_full_die_structure_name): Likewise.
6163         (anonymous_struct_prefix): Likewise.
6164         (dwarf2_name): Likewise.
6165         (follow_die_ref_or_sig): Likewise.
6166         (follow_die_offset): Likewise.
6167         (follow_die_ref): Likewise.
6168         (dwarf2_fetch_die_loc_sect_off): Likewise.
6169         (dwarf2_fetch_constant_bytes): Likewise.
6170         (dwarf2_fetch_die_type_sect_off): Likewise.
6171         (dwarf2_get_die_type): Likewise.
6172         (follow_die_sig): Likewise.
6173         (decode_locdesc): Likewise.
6174         (dwarf2_per_cu_objfile): Likewise.
6175         (dwarf2_per_cu_text_offset): Likewise.
6176         (init_one_comp_unit): Assign dwarf2_per_objfile instead of
6177         objfile.
6178         (set_die_type): Access objfile through
6179         dwarf2_per_objfile.
6180
6181 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
6182
6183         * valprint.c (converted_character_d): Remove typedef.
6184         (DEF_VEC_O (converted_character_d)): Remove.
6185         (count_next_character): Use std::vector.
6186         (print_converted_chars_to_obstack): Likewise.
6187         (generic_printstr): Likewise.
6188
6189 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
6190
6191         * xml-support.h (struct gdb_xml_value): Add constructor.
6192         <value>: Change type to unique_xmalloc_ptr.
6193         (gdb_xml_value_s): Remove typedef.
6194         (DEF_VEC_O (gdb_xml_value_s)): Remove.
6195         (gdb_xml_element_start_handler): Change parameter type to
6196         std::vector.
6197         (xml_find_attribute): Likewise.
6198         * xml-support.c (xml_find_attribute): Change parameter type to
6199         std::vector and adjust.
6200         (gdb_xml_values_cleanup): Remove.
6201         (gdb_xml_parser::start_element): Adjust to std::vector.
6202         (xinclude_start_include): Change paraeter type to std::vector
6203         and adjust.
6204         * btrace.c (check_xml_btrace_version): Likewise.
6205         (parse_xml_btrace_block): Likewise.
6206         (parse_xml_btrace_pt_config_cpu): Likewise.
6207         (parse_xml_btrace_pt): Likewise.
6208         (parse_xml_btrace_conf_bts): Likewise.
6209         (parse_xml_btrace_conf_pt): Likewise.
6210         * memory-map.c (memory_map_start_memory): Likewise.
6211         (memory_map_start_property): Likewise.
6212         * osdata.c (osdata_start_osdata): Likewise.
6213         (osdata_start_item): Likewise.
6214         (osdata_start_column): Likewise.
6215         * remote.c (start_thread): Likewise.
6216         * solib-aix.c (library_list_start_library): Likewise.
6217         (library_list_start_list): Likewise.
6218         * solib-svr4.c (library_list_start_library): Likewise.
6219         (svr4_library_list_start_list): Likewise.
6220         * solib-target.c (library_list_start_segment): Likewise.
6221         (library_list_start_section): Likewise.
6222         (library_list_start_library): Likewise.
6223         (library_list_start_list): Likewise.
6224         * tracepoint.c (traceframe_info_start_memory): Likewise.
6225         (traceframe_info_start_tvar): Likewise.
6226         * xml-syscall.c (syscall_start_syscall): Likewise.
6227         * xml-tdesc.c (tdesc_start_target): Likewise.
6228         (tdesc_start_feature): Likewise.
6229         (tdesc_start_reg): Likewise.
6230         (tdesc_start_union): Likewise.
6231         (tdesc_start_struct): Likewise.
6232         (tdesc_start_flags): Likewise.
6233         (tdesc_start_enum): Likewise.
6234         (tdesc_start_field): Likewise.
6235         (tdesc_start_enum_value): Likewise.
6236         (tdesc_start_vector): Likewise.
6237
6238 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
6239
6240         * extension.h (struct xmethod_worker) <clone>: Remove.
6241         * python/py-xmethods.c (struct python_xmethod_worker) <clone>:
6242         Remove.
6243         (python_xmethod_worker::clone): Remove.
6244         * valops.c (find_overload_match): Use std::move instead of
6245         clone.
6246
6247 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
6248
6249         * extension-priv.h (enum ext_lang_rc): Remove, move to extension.h.
6250         (struct extension_language_ops) <clone_xmethod_worker_data>: Remove.
6251         <free_xmethod_worker_data>: Remove.
6252         <get_matching_xmethod_workers>: Chance VEC to std::vector.
6253         <get_xmethod_arg_types>: Remove.
6254         <get_xmethod_result_type>: Remove.
6255         <invoke_xmethod>: Remove.
6256         * extension.c (new_xmethod_worker): Remove.
6257         (clone_xmethod_worker): Remove.
6258         (get_matching_xmethod_workers): Return void, pass std::vector by
6259         pointer.
6260         (get_xmethod_arg_types): Rename to...
6261         (xmethod_worker::get_arg_types): ... this, and adjust.
6262         (get_xmethod_result_type): Rename to...
6263         (xmethod_worker::get_result_type): ... this, and adjust.
6264         (invoke_xmethod): Remove.
6265         (free_xmethod_worker): Remove.
6266         (free_xmethod_worker_vec): Remove.
6267         * extension.h (enum ext_lang_rc): Move here from
6268         extension-priv.h.
6269         (struct xmethod_worker): Add constructor and destructor.
6270         <data>: Remove.
6271         <value>: Remove.
6272         <invoke, clone, do_get_result_type, do_get_arg_types>: New
6273         virtual pure methods.
6274         <get_arg_types, get_result_type>: New methods.
6275         (xmethod_worker_ptr): Remove typedef.
6276         (DEF_VEC_P (xmethod_worker_ptr)): Remove.
6277         (xmethod_worker_vec): Remove typedef.
6278         (xmethod_worker_up): New typedef.
6279         (invoke_xmethod): Remove.
6280         (clone_xmethod_worker): Remove.
6281         (free_xmethod_worker): Remove.
6282         (free_xmethod_worker_vec): Remove.
6283         (get_xmethod_arg_types): Remove.
6284         (get_xmethod_result_type): Remove.
6285         * valops.c (find_method_list): Use std::vector, don't use
6286         intermediate vector.
6287         (value_find_oload_method_list): Use std::vector.
6288         (find_overload_match): Use std::vector.
6289         (find_oload_champ): Use std::vector.
6290         * value.c (value_free): Use operator delete.
6291         (value_of_xmethod): Rename to...
6292         (value_from_xmethod): ... this.  Don't assign
6293         xmethod_worker::value, take rvalue-reference.
6294         (result_type_of_xmethod): Adjust.
6295         (call_xmethod): Adjust.
6296         * value.h: Include extension.h.
6297         (struct xmethod_worker): Don't forward-declare.
6298         (value_of_xmethod): Rename to...
6299         (value_from_xmethod): ... this, take rvalue-reference.
6300         * python/py-xmethods.c (struct gdbpy_worker_data): Rename to...
6301         (struct python_xmethod_worker): ... this, add constructor and
6302         destructor.
6303         <invoke, clone, do_get_arg_types, do_get_result_type>: Implement.
6304         (gdbpy_free_xmethod_worker_data): Rename to...
6305         (python_xmethod_worker::~python_xmethod_worker): ... this and
6306         adjust.
6307         (gdbpy_clone_xmethod_worker_data): Rename to...
6308         (python_xmethod_worker::clone): ... this and adjust.
6309         (gdbpy_get_matching_xmethod_workers): Use std::vector, don't use
6310         temporary vector.
6311         (gdbpy_get_xmethod_arg_types): Rename to...
6312         (python_xmethod_worker::do_get_arg_types): ... this and adjust.
6313         (gdbpy_get_xmethod_result_type): Rename to...
6314         (python_xmethod_worker::do_get_result_type): ... this and
6315         adjust.
6316         (gdbpy_invoke_xmethod): Rename to...
6317         (python_xmethod_worker::invoke): ... this and adjust.
6318         (new_python_xmethod_worker): Rename to...
6319         (python_xmethod_worker::python_xmethod_worker): ... this and
6320         adjust.
6321         * python/python-internal.h (gdbpy_clone_xmethod_worker_data):
6322         Remove.
6323         (gdbpy_free_xmethod_worker_data): Remove.
6324         (gdbpy_get_matching_xmethod_workers): Use std::vector.
6325         (gdbpy_get_xmethod_arg_types): Remove.
6326         (gdbpy_get_xmethod_result_type): Remove.
6327         (gdbpy_invoke_xmethod): Remove.
6328         * python/python.c (python_extension_ops): Remove obsolete
6329         callbacks.
6330
6331 2018-01-05  Pedro Alves  <palves@redhat.com>
6332
6333         PR gdb/18653
6334         * common/signals-state-save-restore.c
6335         (save_original_signals_state): New parameter 'quiet'.  Warn if we
6336         find a custom handler preinstalled, instead of internal erroring.
6337         But only warn if !quiet.
6338         * common/signals-state-save-restore.h
6339         (save_original_signals_state): New parameter 'quiet'.
6340         * main.c (captured_main_1): Move save_original_signals_state call
6341         after option handling, and pass QUIET.
6342
6343 2018-01-05  Pedro Alves  <palves@redhat.com>
6344
6345         * spu-tdep.c (spu_catch_start): Pass
6346         symbol_name_match_type::SEARCH_NAME to block_lookup_symbol.
6347
6348 2018-01-05  Pedro Alves  <palves@redhat.com>
6349
6350         PR gdb/22670
6351         * ada-lang.c (literal_symbol_name_matcher): New function.
6352         (ada_get_symbol_name_matcher): Use it for
6353         symbol_name_match_type::SEARCH_NAME.
6354         * block.c (block_lookup_symbol): New parameter 'match_type'.  Pass
6355         it down instead of assuming symbol_name_match_type::FULL.
6356         * block.h (block_lookup_symbol): New parameter 'match_type'.
6357         * c-valprint.c (print_unpacked_pointer): Use
6358         lookup_symbol_search_name instead of lookup_symbol.
6359         * compile/compile-object-load.c (get_out_value_type): Pass down
6360         symbol_name_match_type::SEARCH_NAME.
6361         * cp-namespace.c (cp_basic_lookup_symbol): Pass down
6362         symbol_name_match_type::FULL.
6363         * cp-support.c (cp_get_symbol_name_matcher): Handle
6364         symbol_name_match_type::SEARCH_NAME.
6365         * infrun.c (insert_exception_resume_breakpoint): Use
6366         lookup_symbol_search_name.
6367         * p-valprint.c (pascal_val_print): Use lookup_symbol_search_name.
6368         * psymtab.c (maintenance_check_psymtabs): Use
6369         symbol_name_match_type::SEARCH_NAME and SYMBOL_SEARCH_NAME.
6370         * stack.c (print_frame_args): Use lookup_symbol_search_name and
6371         SYMBOL_SEARCH_NAME.
6372         * symtab.c (lookup_local_symbol): Don't demangle the lookup name
6373         if symbol_name_match_type::SEARCH_NAME.
6374         (lookup_symbol_in_language): Pass down
6375         symbol_name_match_type::FULL.
6376         (lookup_symbol_search_name): New.
6377         (lookup_language_this): Pass down
6378         symbol_name_match_type::SEARCH_NAME.
6379         (lookup_symbol_aux, lookup_local_symbol): New parameter
6380         'match_type'.  Pass it down.
6381         * symtab.h (symbol_name_match_type::SEARCH_NAME): New enumerator.
6382         (lookup_symbol_search_name): New declaration.
6383         (lookup_symbol_in_block): New 'match_type' parameter.
6384
6385 2018-01-05  Pedro Alves  <palves@redhat.com>
6386
6387         PR gdb/22670
6388         * ada-lang.c (ada_lookup_encoded_symbol): Reimplement in terms of
6389         ada_lookup_symbol.
6390         (ada_lookup_symbol): Reimplement in terms of
6391         ada_lookup_symbol_list, bits factored out from
6392         ada_lookup_encoded_symbol.
6393
6394 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
6395
6396         * ada-exp.y (write_object_renaming): When subscripting an array
6397         using a symbol as the index, pass the block in call to
6398         ada_lookup_encoded_symbol when looking that symbol up.
6399
6400 2018-01-05  Jerome Guitton  <guitton@adacore.com>
6401
6402         * ada-lang.c (ada_array_length): Use ada_index_type instead of
6403         TYPE_INDEX_TYPE.
6404
6405 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
6406
6407         * ada-lang.c (ada_to_fixed_value_create): Add handling of
6408         the case where VALUE_LVAL (val0) is not lval_memory.
6409
6410 2018-01-05  Xavier Roirand  <roirand@adacore.com>
6411
6412         * ada-valprint.c (print_optional_low_bound): Handle
6413         character-indexed array printing like boolean-indexed array
6414         printing.
6415
6416 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
6417
6418         * NEWS: Create a new section for the next release branch.
6419         Rename the section of the current branch, now that it has
6420         been cut.
6421
6422 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
6423
6424         GDB 8.1 branch created (5219ac6237c272b938c28517bf371429260c71e7):
6425         * version.in: Bump version to 8.1.50.DATE-git.
6426
6427 2018-01-03  Xavier Roirand  <roirand@adacore.com>
6428
6429         * ada-lang.h (ada_exception_catchpoint_kind) <ada_catch_handlers>:
6430         Add field.
6431         * ada-lang.c (struct exception_support_info) <catch_handlers_sym>:
6432         Add field.
6433         (default_exception_support_info) <catch_handlers_sym>: Add field.
6434         (exception_support_info_fallback) <catch_handlers_sym>: Add field.
6435         (ada_exception_name_addr_1): Add "catch handlers" handling.
6436         (ada_exception_catchpoint_cond_string) <ex>: New parameter.
6437         Update all callers.
6438         (create_excep_cond_exprs) <ex>: Add parameter.
6439         (re_set_exception): Update create_excep_cond_exprs call.
6440         (print_it_exception, print_one_exception, print_mention_exception)
6441         (print_recreate_exception): Add "catch handler" handling.
6442         (allocate_location_catch_handlers, re_set_catch_handlers)
6443         (check_status_catch_handlers, print_it_catch_handlers)
6444         (print_one_catch_handlers, print_mention_catch_handlers)
6445         (print_recreate_catch_handlers): New function.
6446         (catch_handlers_breakpoint_ops): New variable.
6447         (catch_ada_exception_command_split) <is_catch_handlers_cmd>:
6448         Add parameter.  Add "catch handler" handling.
6449         (ada_exception_sym_name, ada_exception_breakpoint_ops):
6450         Add "catch handler" handling.
6451         (ada_exception_catchpoint_cond_string): Add "catch handler"
6452         handling.
6453         (create_ada_exception_catchpoint): Update create_excep_cond_exprs
6454         call.
6455         (catch_ada_handlers_command): New function.
6456         (initialize_ada_catchpoint_ops): Initialize "catch handlers"
6457         operations structure.
6458         (_initialize_ada_language): Add "catch handlers" command entry.
6459         * NEWS: Document "catch handlers" feature.
6460
6461 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
6462
6463         * ada-lang.c (ada_value_slice_from_ptr): Take array stride into
6464         account when creating the array type of the slice.
6465         (ada_value_slice): Likewise.
6466
6467 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
6468
6469         * gdbtypes.h (enum dynamic_prop_node_kind) <DYN_PROP_BYTE_STRIDE>:
6470         New enum value.
6471         (create_array_type_with_stride): Add byte_stride_prop parameter.
6472         * gdbtypes.c (create_array_type_with_stride) <byte_stride_prop>:
6473         New parameter.  Update all callers in this file.
6474         (array_type_has_dynamic_stride): New function.
6475         (is_dynamic_type_internal, resolve_dynamic_array): Add handling
6476         of arrays with dynamic byte strides.
6477         * dwarf2read.c (read_array_type): Add support for dynamic
6478         DW_AT_byte_stride attributes.
6479
6480 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
6481
6482         * dwarf2read.c (read_unspecified_type): Treat
6483         DW_TAG_enumeration_type DIEs from Ada units as stubs.
6484
6485 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
6486
6487         Update copyright year range in all GDB files.
6488
6489 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
6490
6491         * copyright.py (BY_HAND): Remove gdb/testsuite/gdb.base/step-line.inp
6492         and gdb/testsuite/gdb.base/step-line.c.
6493
6494 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
6495
6496         * copyright.py (main): Dump the contents of
6497         MULTIPLE_COPYRIGHT_HEADERS (separately) from BY_HAND,
6498         even if BY_HAND is empty.
6499
6500 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
6501
6502         * top.c (print_gdb_version): Update Copyright year in version
6503         message.
6504
6505 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
6506
6507         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2017.
6508
6509 For older changes see ChangeLog-2017.
6510 \f
6511 Local Variables:
6512 mode: change-log
6513 left-margin: 8
6514 fill-column: 74
6515 version-control: never
6516 coding: utf-8
6517 End: