gdb/ChangeLog

   1 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
   2
   3         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
   4         update return statements.
   5         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
   6         declaration, and update comment to match.
   7         * gdbtypes.c (resolve_dynamic_array): Update call to
   8         dwarf2_evaluate_property to match new return type.
   9
  10 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
  11
  12         * valarith.c (value_subscripted_rvalue): Change lowerbound
  13         parameter type from int to LONGEST.
  14         * value.h (value_subscripted_rvalue): Likewise in declaration.
  15
  16 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
  17
  18         * cli/cli-utils.c (info_print_command_completer): New function.
  19         * cli/cli-utils.h: Add 'completer.h' include, and forward
  20         declaration for 'struct cmd_list_element'.
  21         (info_print_command_completer): Declare.
  22         * stack.c (_initialize_stack): Add completer for 'info locals' and
  23         'info args'.
  24         * symtab.c (_initialize_symtab): Add completer for 'info
  25         variables' and 'info functions'.
  26         * NEWS: Mention completion for additional info commands.
  27
  28 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
  29
  30         * cli/cli-utils.c (extract_info_print_args): Delete.
  31         (extract_arg_maybe_quoted): Delete.
  32         (info_print_options_defs): New variable.
  33         (make_info_print_options_def_group): New function.
  34         (extract_info_print_options): Define new function.
  35         * cli/cli-utils.h (extract_info_print_args): Delete.
  36         (struct info_print_options): New structure.
  37         (extract_info_print_options): Declare new function.
  38         * stack.c (info_locals_command): Update to use new
  39         extract_info_print_options, also add a header comment.
  40         (info_args_command): Likewise.
  41         * symtab.c (info_variables_command): Likewise.
  42         (info_functions_command): Likewise.
  43
  44 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
  45
  46         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
  47         to extract string arguments.
  48         * common/common-utils.c (extract_string_maybe_quoted): New function.
  49         * common/common-utils.h (extract_string_maybe_quoted): Declare.
  50
  51 2019-07-11  Tom Tromey  <tromey@adacore.com>
  52
  53         * main.c (get_init_files): Use GDBINIT, not gdbinit.
  54         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
  55         * top.h (gdbinit): Don't declare.
  56         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
  57         into...
  58         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
  59         * top.c (gdb_init): Don't call init_cli_cmds.
  60         (gdbinit): Remove.
  61         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
  62
  63 2019-07-11  Tom Tromey  <tromey@adacore.com>
  64
  65         * python/py-inferior.c (add_thread_object): Don't use thread_obj
  66         after it has been moved.
  67
  68 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
  69
  70         * valops.c (value_must_coerce_to_target): Change return type to
  71         bool.
  72         * value.h (value_must_coerce_to_target): Likewise.
  73
  74 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
  75
  76         * breakpoint.c (is_hardware_watchpoint): Remove
  77         forward-declaration.
  78         (is_masked_watchpoint): Change return type to bool.
  79         (is_tracepoint): Likewise.
  80         (is_breakpoint): Likewise.
  81         (is_hardware_watchpoint): Likewise.
  82         (is_watchpoint): Likewise.
  83         (is_no_memory_software_watchpoint): Likewise.
  84         (is_catchpoint): Likewise.
  85         (breakpoint_1): Make FILTER parameter's return type bool.
  86         is_masked_watchpoint): Change return type to bool.
  87         (save_breakpoints): Make FILTER parameter's return type bool.
  88         * breakpoint.h (is_breakpoint): Change return type to bool.
  89         (is_watchpoint): Likewise.
  90         (is_catchpoint): Likewise.
  91         (is_tracepoint): Likewise.
  92
  93 2019-07-10  Tom Tromey  <tom@tromey.com>
  94
  95         * defs.h: Don't include gdbarch.h.
  96         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
  97         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
  98         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
  99         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 100         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 101         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 102         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 103         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 104         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 105         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 106         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 107         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 108         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 109         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 110         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 111         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 112         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 113         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 114         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 115         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 116         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 117         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 118         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 119         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 120         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 121         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 122         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 123
 124 2019-07-10  Tom Tromey  <tromey@adacore.com>
 125
 126         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 127         * breakpoint.c (init_ada_exception_breakpoint): Register as
 128         bp_catchpoint.
 129         (print_one_breakpoint_location, print_one_breakpoint): Use
 130         is_ada_exception_catchpoint.
 131         * ada-lang.c (class ada_catchpoint_location): Pass
 132         bp_loc_software_breakpoint to bp_location constructor.
 133         (is_ada_exception_catchpoint): New function.
 134
 135 2019-07-10  Tom Tromey  <tromey@adacore.com>
 136
 137         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 138         VEC.
 139         (struct arm_exidx_entry): New method operator<.
 140         (struct arm_exidx_data) <section_maps>: Change type.
 141         (arm_exidx_data_free): Remove.
 142         (arm_exidx_data_key): Change type.  Move lower.
 143         (arm_exidx_new_objfile): Update.
 144         (arm_compare_exidx_entries): Remove.
 145         (arm_find_exidx_entry, _initialize_arm_tdep)
 146
 147 2019-07-10  Tom Tromey  <tromey@adacore.com>
 148
 149         * solib-spu.c (ocl_program_data_key): Change type.
 150         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 151         Update.
 152
 153 2019-07-10  Tom Tromey  <tromey@adacore.com>
 154
 155         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 156         (struct solib_aix_inferior_data) <library_list>: Change type.
 157         (solib_aix_inferior_data_handle): Change type.
 158         (get_solib_aix_inferior_data): Update.
 159         (solib_aix_free_library_list): Remove.
 160         (library_list_start_library): Update.
 161         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 162         return type.
 163         (solib_aix_get_library_list)
 164         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 165         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 166
 167 2019-07-10  Tom Tromey  <tromey@adacore.com>
 168
 169         * solib-dsbt.c (struct dsbt_info): Add initializers.
 170         (solib_dsbt_pspace_data): Change type.
 171         (dsbt_pspace_data_cleanup): Remove.
 172         (get_dsbt_info, _initialize_dsbt_solib): Update.
 173
 174 2019-07-10  Tom Tromey  <tromey@adacore.com>
 175
 176         * spu-tdep.c (spu_overlay_data): Change type.
 177         (spu_get_overlay_table, spu_overlay_new_objfile)
 178         (_initialize_spu_tdep): Update.
 179
 180 2019-07-10  Tom Tromey  <tromey@adacore.com>
 181
 182         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 183         destructor.
 184         (dbx_objfile_data_key): Change type and declare later.
 185         (DBX_SYMFILE_INFO): Rewrite.
 186         * dbxread.c (dbx_objfile_data_key): Change type.
 187         (dbx_symfile_init): Update.
 188         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 189         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 190         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 191
 192 2019-07-10  Tom Tromey  <tromey@adacore.com>
 193
 194         * jit.c (jit_program_space_key): Change type.  Move lower.
 195         (get_jit_program_space_data): Update.
 196         (jit_program_space_data_cleanup): Remove.
 197         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 198         Update.
 199         (struct jit_program_space_data): Add initializers.
 200
 201 2019-07-10  Tom Tromey  <tromey@adacore.com>
 202
 203         * solib-darwin.c (struct darwin_info): Add initializers.
 204         (solib_darwin_pspace_data): Change type.
 205         (darwin_pspace_data_cleanup): Remove.
 206         (get_darwin_info, _initialize_darwin_solib): Update.
 207
 208 2019-07-10  Tom Tromey  <tromey@adacore.com>
 209
 210         * remote-sim.c (struct sim_inferior_data): Add initializers,
 211         constructor, and destructor.
 212         (sim_inferior_data_key): Change type.  Move lower.
 213         (check_for_duplicate_sim_descriptor): Update.
 214         (get_sim_inferior_data): Use new.  Update.
 215         (~sim_inferior_data_cleanup): Rename from
 216         sim_inferior_data_cleanup.  Simplify.
 217         (gdbsim_close_inferior, simulator_command)
 218         (sim_command_completer, _initialize_remote_sim): Update.
 219         (next_pid, INITIAL_PID): Move earlier.
 220
 221 2019-07-10  Tom Tromey  <tromey@adacore.com>
 222
 223         * python/python-internal.h (create_thread_object): Return
 224         gdbpy_ref.
 225         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 226         * python/py-inferior.c (struct threadlist_entry): Add
 227         constructor.
 228         <thread_obj>: Now a gdbpy_ref.
 229         (thread_to_thread_object): Update.
 230         (add_thread_object): Use new.
 231         (delete_thread_object): Use delete.
 232         (infpy_threads): Update.
 233         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 234         GIL.
 235
 236 2019-07-10  Tom Tromey  <tromey@adacore.com>
 237
 238         * valops.c (value_cast): Specialize error message for Ada.
 239
 240 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 241
 242         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 243
 244 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 245
 246         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 247         bpstat_should_step): Return bool, adjust comments.
 248         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 249         bpstat_should_step): Likewise.
 250
 251 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 252
 253         * features/Makefile: Use feature target descriptions for Arm.
 254         * features/arm/arm-core.c: Generate new file.
 255         * features/arm/arm-fpa.c: Likewise.
 256         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 257         * features/arm/arm-m-profile.c: Likewise.
 258         * features/arm/arm-vfpv2.c: Likewise.
 259         * features/arm/arm-vfpv3.c: Likewise.
 260         * features/arm/xscale-iwmmxt.c: Likewise.
 261         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 262
 263 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 264
 265         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 266         ptrace earlier.
 267
 268 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 269
 270         * features/aarch64-pauth.c: Regenerate.
 271
 272 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 273
 274         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 275         bool.
 276         (bpstat_what): Use false instead of 0.
 277
 278 2019-07-09  Pedro Alves  <palves@redhat.com>
 279
 280         * break-catch-throw.c (is_exception_catchpoint): New.
 281         * breakpoint.c (print_one_breakpoint_location): New parameter
 282         'raw_loc'.  Handle it.  Use
 283         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 284         looking at the breakpoint's type.
 285         (print_one_breakpoint): If handling "maint info breakpoints", also
 286         print locations of exception catchpoints.
 287         * breakpoint.h (is_exception_catchpoint): Declare.
 288
 289 2019-07-09  Pedro Alves  <palves@redhat.com>
 290
 291         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 292         "addr" field.
 293         (allocate_location_exception_catchpoint): New.
 294         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 295         (initialize_throw_catchpoint_ops): Install
 296         allocate_location_exception_catchpoint as allocate_location
 297         method.
 298         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 299         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 300         bp_loc_other.
 301         (breakpoint_address_is_meaningful): Delete.
 302         (bl_address_is_meaningful): New.
 303         (breakpoint_locations_match): Adjust comment.
 304         (bp_location_from_bp_type): New, factored out of...
 305         (bp_location::bp_location(breakpoint *)): ... this.
 306         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 307         factored out of...
 308         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 309         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 310         breakpoint_address_is_meaningful.
 311         (bp_locations_compare): Adjust comment.
 312         (update_global_location_list): Use bl_address_is_meaningful
 313         instead of breakpoint_address_is_meaningful.
 314         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 315         explicit.
 316         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 317         * python/py-breakpoint.c (bppy_get_location): No longer check
 318         whether location is null.
 319
 320 2019-07-09  Pedro Alves  <palves@redhat.com>
 321
 322         PR c++/15468
 323         * breakpoint.c (print_one_breakpoint_location): Remove
 324         single-location assert.
 325
 326 2019-07-09  Tom Tromey  <tom@tromey.com>
 327
 328         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 329         * configure: Rebuild.
 330         * configure.ac: Change common to gdbsupport.
 331         * gdbsupport: Rename from common.
 332         * acinclude.m4: Change common to gdbsupport.
 333         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 334         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 335         gdbsupport.
 336         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 337         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 338         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 339         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 340         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 341         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 342         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 343         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 344         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 345         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 346         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 347         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 348         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 349         coff-pe-read.c, command.h, compile/compile-c-support.c,
 350         compile/compile-c.h, compile/compile-cplus-symbols.c,
 351         compile/compile-cplus-types.c, compile/compile-cplus.h,
 352         compile/compile-loc2c.c, compile/compile.c, completer.c,
 353         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 354         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 355         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 356         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 357         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 358         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 359         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 360         features/aarch64-core.c, features/aarch64-fpu.c,
 361         features/aarch64-pauth.c, features/aarch64-sve.c,
 362         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 363         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 364         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 365         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 366         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 367         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 368         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 369         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 370         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 371         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 372         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 373         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 374         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 375         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 376         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 377         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 378         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 379         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 380         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 381         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 382         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 383         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 384         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 385         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 386         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 387         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 388         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 389         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 390         minsyms.c, mips-linux-tdep.c, namespace.h,
 391         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 392         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 393         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 394         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 395         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 396         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 397         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 398         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 399         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 400         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 401         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 402         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 403         procfs.c, producer.c, progspace.h, psymtab.h,
 404         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 405         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 406         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 407         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 408         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 409         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 410         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 411         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 412         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 413         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 414         target-memory.c, target.c, target.h, target/waitstatus.c,
 415         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 416         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 417         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 418         unittests/array-view-selftests.c,
 419         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 420         unittests/common-utils-selftests.c,
 421         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 422         unittests/format_pieces-selftests.c,
 423         unittests/function-view-selftests.c,
 424         unittests/lookup_name_info-selftests.c,
 425         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 426         unittests/mkdir-recursive-selftests.c,
 427         unittests/observable-selftests.c,
 428         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 429         unittests/parse-connection-spec-selftests.c,
 430         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 431         unittests/scoped_fd-selftests.c,
 432         unittests/scoped_mmap-selftests.c,
 433         unittests/scoped_restore-selftests.c,
 434         unittests/string_view-selftests.c, unittests/style-selftests.c,
 435         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 436         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 437         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 438         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 439         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 440         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 441
 442 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 443
 444         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 445         bool value.
 446         (decode_digits_ordinary): Set explicit_line field in sal.
 447         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 448         symtab_and_line that was set on an explicit line number in
 449         assembler code.  Do always update the recorded symtab and line if
 450         we do skip the prologue.
 451
 452 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 453
 454         * breakpoint.c (set_breakpoint_location_function): Remove
 455         explicit_loc parameter.
 456         (momentary_breakpoint_from_master): Update call to
 457         set_breakpoint_location_function.
 458         (add_location_to_breakpoint): Likewise.
 459
 460 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 461
 462         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 463         required features based on default bfd type when no specific bfd
 464         is present.
 465
 466 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 467
 468         * NEWS: Mention that GDB printf and eval commands can now print
 469         C-style and Ada-style convenience var strings without
 470         calling the inferior.
 471         * printcmd.c (printf_c_string): Locally print GDB internal var
 472         instead of transiting via the inferior.
 473         (printf_wide_c_string): Likewise.
 474
 475 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 476
 477         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
 478
 479 2019-07-04  Tom Tromey  <tom@tromey.com>
 480
 481         PR tui/24724:
 482         * tui/tui-winsource.c (tui_clear_source_content): Update.
 483         (tui_source_window_base::set_is_exec_point_at): Fix comment.
 484         (tui_update_breakpoint_info): Update.
 485         (tui_set_exec_info_content): Update.
 486         * tui/tui-source.c (tui_set_source_content_nil): Update.
 487         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
 488         has_break.
 489         * tui/tui-data.h (enum tui_bp_flag): New.
 490         (tui_bp_flags): New enum flags type.
 491         (struct tui_source_element) <break_mode>: Change type.  Rename
 492         from has_break.
 493         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
 494         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
 495         constants.
 496         * tui/tui-winsource.h: Fix comment.
 497
 498 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 499
 500         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
 501         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
 502         (store_fpregs_to_thread)
 503         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 504         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
 505         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
 506         (IWMMXT_REGS_SIZE): Add define.
 507         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
 508         (fetch_vfp_regs, store_vfp_regs)
 509         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 510         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
 511
 512 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 513
 514         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
 515         defines.
 516         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
 517         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
 518         (ARM_INT_REGISTER_SIZE): ...to this.
 519         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
 520         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
 521         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
 522         (arm_linux_collect_gregset, supply_nwfpe_register)
 523         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
 524         defines.
 525         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
 526         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
 527         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
 528         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
 529         (arm_return_in_memory, arm_store_return_value)
 530         (arm_get_longjmp_target, arm_register_g_packet_guesses)
 531         (arm_record_ld_st_multiple): Likewise.
 532         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
 533         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
 534
 535 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 536
 537         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
 538         AARCH64_DISPLACED_MODIFIED_INSNS.
 539         * aarch64-tdep.c (struct aarch64_displaced_step_data)
 540         (aarch64_displaced_step_copy_insn): Likewise.
 541         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 542         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
 543         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
 544         ARM_DISPLACED_MODIFIED_INSNS.
 545         * arm-tdep.c (arm_gdbarch_init): Likewise.
 546         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 547         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
 548         (struct arm_displaced_step_closure): Use
 549         ARM_DISPLACED_MODIFIED_INSNS.
 550
 551 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 552
 553         * features/Makefile: Remove unused xml files.
 554         * features/aarch64.xml: Remove.
 555         * features/i386/amd64-avx-avx512-linux.xml: Remove.
 556         * features/i386/amd64-avx-avx512.xml: Remove.
 557         * features/i386/amd64-avx-linux.xml: Remove.
 558         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
 559         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
 560         * features/i386/amd64-avx-mpx-linux.xml: Remove.
 561         * features/i386/amd64-avx-mpx.xml: Remove.
 562         * features/i386/amd64-avx.xml: Remove.
 563         * features/i386/amd64-linux.xml: Remove.
 564         * features/i386/amd64-mpx-linux.xml: Remove.
 565         * features/i386/amd64-mpx.xml: Remove.
 566         * features/i386/amd64.xml: Remove.
 567         * features/i386/i386-avx-avx512-linux.xml: Remove.
 568         * features/i386/i386-avx-avx512.xml: Remove.
 569         * features/i386/i386-avx-linux.xml: Remove.
 570         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
 571         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
 572         * features/i386/i386-avx-mpx-linux.xml: Remove.
 573         * features/i386/i386-avx-mpx.xml: Remove.
 574         * features/i386/i386-avx.xml: Remove.
 575         * features/i386/i386-linux.xml: Remove.
 576         * features/i386/i386-mmx-linux.xml: Remove.
 577         * features/i386/i386-mmx.xml: Remove.
 578         * features/i386/i386-mpx-linux.xml: Remove.
 579         * features/i386/i386-mpx.xml: Remove.
 580         * features/i386/i386.xml: Remove.
 581         * features/i386/x32-avx-avx512-linux.xml: Remove.
 582         * features/i386/x32-avx-linux.xml: Remove.
 583         * features/i386/x32-linux.xml: Remove.
 584
 585 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 586
 587         * regformats/aarch64.dat: Remove.
 588         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
 589         * regformats/i386/amd64-avx-linux.dat: Remove.
 590         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
 591         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
 592         * regformats/i386/amd64-linux.dat: Remove.
 593         * regformats/i386/amd64-mpx-linux.dat: Remove.
 594         * regformats/i386/amd64.dat: Remove.
 595         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
 596         * regformats/i386/i386-avx-linux.dat: Remove.
 597         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
 598         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
 599         * regformats/i386/i386-linux.dat: Remove.
 600         * regformats/i386/i386-mmx-linux.dat: Remove.
 601         * regformats/i386/i386-mpx-linux.dat: Remove.
 602         * regformats/i386/i386.dat: Remove.
 603         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
 604         * regformats/i386/x32-avx-linux.dat: Remove.
 605         * regformats/i386/x32-linux.dat: Remove.
 606
 607 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 608
 609         * aarch64-tdep.c: Remove xml self tests.
 610         * amd64-linux-tdep.c: Likewise.
 611         * amd64-tdep.c: Likewise.
 612         * i386-linux-tdep.c: Likewise.
 613         * i386-tdep.c: Likewise.
 614
 615 2019-07-03  Pedro Alves  <palves@redhat.com>
 616
 617         PR cli/24732
 618         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
 619         (pipe_cmd_option_defs): New.
 620         (make_pipe_cmd_options_def_group): New.
 621         (pipe_command): Use gdb::option::process_options.
 622         (pipe_command_completer): New function.
 623         (_initialize_cli_cmds): Install completer for "pipe" command.
 624
 625 2019-07-03  Pedro Alves  <palves@redhat.com>
 626
 627         * cli/cli-option.c (union option_value) <string>: New field.
 628         (struct option_def_and_value): Add ctor, move ctor, dtor and
 629         use DISABLE_COPY_AND_ASSIGN.
 630         (option_def_and_value::clear_value): New.
 631         (parse_option, save_option_value_in_ctx, get_val_type_str)
 632         (add_setshow_cmds_for_options): Handle var_string.
 633         * cli-option.h (union option_def::var_address) <string>: New
 634         field.
 635         (struct string_option_def): New.
 636         * maint-test-options.c (struct test_options_opts): Add default
 637         ctor and use DISABLE_COPY_AND_ASSIGN.
 638         <string_opt>: New field.
 639         (test_options_opts::~test_options_opts): New.
 640         (test_options_opts::dump): Also dump "-string".
 641         (test_options_option_defs): Install "string.
 642
 643 2019-07-03  Pedro Alves  <palves@redhat.com>
 644
 645         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
 646         option_value with a null enumeration.
 647         (complete_options): Save the option values in the context.
 648         (save_option_value_in_ctx): New, factored out from ...
 649         (process_options): ... here.
 650         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
 651         of the function.
 652         * maint-test-options.c (test_options_opts::dump): New, factored
 653         out from ...
 654         (maintenance_test_options_command_mode): ... here.
 655         (maintenance_test_options_command_completion_result): Delete.
 656         (maintenance_test_options_command_completion_text): Update
 657         comment.
 658         (maintenance_show_test_options_completion_result): Change
 659         prototype.  Just print
 660         maintenance_test_options_command_completion_text.
 661         (save_completion_result): New.
 662         (maintenance_test_options_completer_mode): Pass options context to
 663         complete_options, and then save a dump.
 664         (_initialize_maint_test_options): Use add_cmd to install "maint
 665         show test-options-completion-result".
 666
 667 2019-07-03  Pedro Alves  <palves@redhat.com>
 668
 669         * NEWS (New commands): Mention "with" and "maint with".
 670         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
 671         (with_command, with_command_completer): New.
 672         (pipe_command): Adjust to new repeat_previous
 673         interface.
 674         (_initialize_cli_cmds): Install the "with" command and its "w"
 675         alias.
 676         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
 677         declarations.
 678         * cli/cli-setshow.c (parse_cli_var_uinteger)
 679         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
 680         argument strings for all var_types.
 681         (get_setshow_command_value_string): New, factored out from ...
 682         (do_show_command): ... this.
 683         * cli/cli-setshow.h: Include <string>.
 684         (get_setshow_command_value_string): Declare.
 685         * command.h (repeat_previous): Now returns const char *.  Adjust
 686         comment.
 687         * maint.c: Include "cli/cli-cmds.h".
 688         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
 689         (_initialize_maint_cmds): Register the "maintenance with" command.
 690         * top.c (repeat_previous): Move bits from pipe_command here:
 691         Return the saved command line, if any; error out if there's no
 692         command to relaunch.
 693
 694 2019-07-03  Pedro Alves  <palves@redhat.com>
 695
 696         * NEWS (New commands): Mention "maint set/show test-settings"
 697         instead of "maint test-settings".
 698         * maint-test-settings.c (maintenance_test_settings_list): Delete.
 699         (maintenance_test_settings_set_list): Rename to ...
 700         (maintenance_set_test_settings_list): ... this.
 701         (maintenance_test_settings_show_list): Rename to  ...
 702         (maintenance_show_test_settings_list): ... this.
 703         (maintenance_test_settings_cmd): Delete.
 704         (maintenance_test_settings_set_cmd): ...
 705         (maintenance_set_test_settings_cmd): ... this.
 706         (maintenance_test_settings_show_cmd): ...
 707         (maintenance_show_test_settings_cmd): ... this.
 708         (maintenance_test_settings_show_value_cmd):
 709         (maintenance_show_test_settings_value_cmd): ... this.
 710         (_initialize_maint_test_settings): No longer install the "maint
 711         test-settings" prefix command.  Rename "maint test-settings set"
 712         to "maint set test-settings", and "maint test-settings show" to
 713         "maint show test-settings".  Adjust all subcommands.
 714
 715 2019-07-03  Pedro Alves  <palves@redhat.com>
 716
 717         * maint-test-settings.c: Fix file's intro comment.  Replace all
 718         references to "test-options" with references to "test-settings",
 719         in comments.
 720
 721 2019-07-03  Pedro Alves  <palves@redhat.com>
 722
 723         * maint-test-settings.c (maintenance_test_settings_xxx)
 724         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
 725         New.
 726         (maintenance_test_settings_enums): Use them.
 727         (maintenance_test_settings_enum): Default to
 728         maintenance_test_settings_xxx.
 729         (_initialize_maint_test_settings): Initialize
 730         MAINTENANCE_TEST_SETTINGS_FILENAME.
 731
 732 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 733
 734         * breakpoint.h (remove_breakpoints_inf): Change return type to
 735         void, move function documentation here.
 736         * breakpoint.c (remove_breakpoints_inf): Change return type to
 737         void, move function documentation to header.
 738
 739 2019-07-02  Pedro Alves  <palves@redhat.com>
 740
 741         * NEWS (Completion improvements): Mention "info threads".
 742         * thread.c (struct info_threads_opts, info_threads_option_defs)
 743         (make_info_threads_options_def_group): New.
 744         (info_threads_command): Use gdb::option::process_options.
 745         (info_threads_command_completer): New.
 746         (_initialize_thread): Use gdb::option::build_help to build the
 747         help text for "info threads".
 748
 749 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 750
 751         * defs.h (generic_load): Move from here...
 752         * symfile.h (generic_load): ... to here.  Rename name parameter
 753         to args.
 754         * symfile.c (generic_load): Add comment.
 755
 756 2019-07-01  Tom Tromey  <tromey@adacore.com>
 757
 758         * dwarf2read.c
 759         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
 760         declaration of without_params.  Fix formatting.
 761
 762 2019-07-01  Tom Tromey  <tromey@adacore.com>
 763
 764         * ada-exp.y (find_primitive_type): Update.
 765         * ada-lang.h (ada_lookup_symbol): Update.
 766         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
 767         parameter.
 768         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
 769
 770 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 771
 772         PR breakpoints/24541
 773         * gdbarch.c: Regenerate.
 774         * gdbarch.h: Regenerate.
 775         * gdbarch.sh: Add 'stap_adjust_register'.
 776         * i386-tdep.c: Include '<unordered_set>'.
 777         (i386_stap_adjust_register): New function.
 778         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
 779         * stap-probe.c (stap_parse_register_operand): Call
 780         'gdbarch_stap_adjust_register'.
 781
 782 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 783
 784         PR python/24742
 785         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
 786         * python/python.c (do_start_initialization): Use 'xmalloc'
 787         instead of 'PyMem_Malloc'.
 788
 789 2019-06-28  Tom Tromey  <tromey@adacore.com>
 790
 791         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
 792         for Ada.
 793
 794 2019-06-27  Tom Tromey  <tromey@adacore.com>
 795
 796         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
 797         objfile_key.
 798         (arm_find_mapping_symbol, arm_record_special_symbol)
 799         (_initialize_arm_tdep): Update.
 800         (arm_objfile_data_free): Remove.
 801
 802 2019-06-27  Tom Tromey  <tromey@adacore.com>
 803
 804         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
 805         to cp_print_static_field.
 806
 807 2019-06-26  Tom Tromey  <tromey@adacore.com>
 808
 809         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
 810         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
 811         declare.
 812
 813 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 814
 815         * features/aarch64-core.c (create_feature_aarch64_core):
 816         Regenerate.
 817         * features/aarch64-core.xml: Add cpsr flags.
 818
 819 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 820
 821         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
 822         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
 823
 824 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 825
 826         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
 827         field.
 828         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
 829         use.
 830         (arm_record_special_symbol): Don't insert new symbol in sorted
 831         position, push it at the end.
 832
 833 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 834
 835         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
 836         (arm_mapping_symbol_s): Remove.
 837         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
 838         (arm_mapping_symbol_vec): New typedef.
 839         (struct arm_per_objfile): Add constructor.
 840         <section_maps>: Change type to
 841         std::unique_ptr<arm_mapping_symbol_vec[]>.
 842         (arm_compare_mapping_symbols): Remove.
 843         (arm_find_mapping_symbol): Adjust to section_maps type change.
 844         (arm_objfile_data_free): Call delete on arm_per_objfile.
 845         (arm_record_special_symbol): Adjust to section_maps type change.
 846         Allocate arm_per_objfile with new.
 847
 848 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 849
 850         * cli/cli-cmds.c (alias_command): Compare the alias prefix
 851         with the command prefix.
 852
 853 2019-06-25  Tom Tromey  <tom@tromey.com>
 854
 855         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
 856         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
 857
 858 2019-06-25  Tom Tromey  <tom@tromey.com>
 859
 860         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
 861         type.
 862         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
 863         protected.
 864
 865 2019-06-25  Tom Tromey  <tom@tromey.com>
 866
 867         * tui/tui-winsource.c
 868         (tui_source_window_base::set_is_exec_point_at): Add check against
 869         LOA_ADDRESS.
 870
 871 2019-06-25  Tom Tromey  <tom@tromey.com>
 872
 873         * tui/tui-source.c (tui_set_source_content): Don't check before
 874         xfree.
 875         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
 876
 877 2019-06-25  Tom Tromey  <tom@tromey.com>
 878
 879         * tui/tui-winsource.h (tui_update_source_window_as_is)
 880         (tui_alloc_source_buffer, tui_line_is_displayed)
 881         (tui_addr_is_displayed): Change type of win_info.
 882         * tui/tui-winsource.c (tui_update_source_window_as_is)
 883         (tui_clear_source_content, tui_show_source_line)
 884         (tui_show_source_content, tui_source_window_base::refill)
 885         (tui_source_window_base::set_is_exec_point_at)
 886         (tui_source_window_base::set_is_exec_point_at)
 887         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
 888         (tui_alloc_source_buffer, tui_line_is_displayed)
 889         (tui_addr_is_displayed): Change type of win_info.  Update.
 890         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 891         (tui_source_window_base::do_make_visible_with_new_height):
 892         Update.
 893         * tui/tui-source.c (tui_set_source_content)
 894         (tui_set_source_content_nil)
 895         (tui_source_window::do_scroll_vertical): Update.
 896         * tui/tui-layout.c (show_layout): Update.
 897         * tui/tui-disasm.c (tui_set_disassem_content)
 898         (tui_disasm_window::do_scroll_vertical): Update.
 899         * tui/tui-data.h (tui_win_content): Remove.
 900         (struct tui_gen_win_info) <content, content_size>: Remove.
 901         (struct tui_source_element): Add initializers and destructor.
 902         (union tui_which_element, struct tui_win_element): Remove.
 903         (struct tui_source_window_base) <content>: New field.
 904         (struct tui_data_window): Remove destructor.
 905         (tui_alloc_content, tui_free_win_content)
 906         (tui_free_all_source_wins_content): Don't declare.
 907         * tui/tui-data.c (tui_initialize_static_data): Update.
 908         (init_content_element, tui_alloc_content): Remove.
 909         (~tui_gen_win_info): Update.
 910         (~tui_data_window, tui_free_all_source_wins_content)
 911         (tui_free_win_content, free_content, free_content_elements):
 912         Remove.
 913
 914 2019-06-25  Tom Tromey  <tom@tromey.com>
 915
 916         * tui/tui-winsource.h (tui_clear_source_content)
 917         (tui_erase_source_content, tui_show_source_content): Change type
 918         of win_info.
 919         * tui/tui-winsource.c (tui_clear_source_content)
 920         (tui_erase_source_content, tui_show_source_content): Change type
 921         of win_info.
 922         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 923         * tui/tui-source.h (tui_set_source_content_nil): Change type of
 924         win_info.
 925         * tui/tui-source.c (tui_set_source_content_nil): Change type of
 926         win_info.
 927         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
 928
 929 2019-06-25  Tom Tromey  <tom@tromey.com>
 930
 931         * tui/tui-winsource.c (tui_clear_source_content)
 932         (tui_source_window_base::set_is_exec_point_at): Update.
 933         * tui/tui-source.c (tui_set_source_content_nil): Update.
 934         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
 935         a bool.
 936         * tui/tui-data.c (init_content_element): Update.
 937
 938 2019-06-25  Tom Tromey  <tom@tromey.com>
 939
 940         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
 941         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
 942         * tui/tui-layout.c (init_and_make_win): Update.
 943         * tui/tui.h (enum tui_win_type): Update.
 944         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
 945         tui_win_is_auxillary.
 946         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
 947         tui_win_is_auxillary.
 948
 949 2019-06-25  Tom Tromey  <tom@tromey.com>
 950
 951         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
 952         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
 953         (tui_delete_data_content_windows, tui_display_all_data)
 954         (tui_data_window::do_scroll_vertical, tui_display_data_from):
 955         Update.
 956         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
 957         * tui/tui-regs.c (tui_last_regs_line_no)
 958         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 959         (tui_show_registers): Update.
 960         (tui_show_register_group): Return void.  Update.
 961         (tui_display_registers_from, tui_display_reg_element_at_line)
 962         (tui_display_registers_from_line, tui_check_register_values):
 963         Update.
 964         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
 965         member.
 966         (struct tui_data_window) <regs_content>: Now a std::vector.
 967         <regs_content_count>: Remove.
 968         (tui_add_content_elements, tui_free_data_content): Don't declare.
 969         * tui/tui-data.c (tui_data_window::clear_detail): Update.
 970         (init_content_element): Remove DATA_WIN case.  Add assert.
 971         (tui_add_content_elements): Remove.
 972         (tui_data_window): Update.
 973         (tui_free_data_content): Remove.
 974         (free_content_elements): Remove DATA_WIN case.
 975
 976 2019-06-25  Tom Tromey  <tom@tromey.com>
 977
 978         * tui/tui-data.c (tui_data_item_window): Update.
 979         * tui/tui-windata.h (tui_check_data_values): Don't declare.
 980         * tui/tui-windata.c (tui_display_all_data)
 981         (tui_display_data_from_line): Update.
 982         (tui_check_data_values): Remove.
 983         * tui/tui-regs.c (tui_show_register_group)
 984         (tui_display_reg_element_at_line): Update.
 985         * tui/tui-hooks.c (tui_register_changed)
 986         (tui_refresh_frame_and_register_information): Call
 987         tui_check_register_values.
 988         * tui/tui-data.h (struct tui_data_window) <data_content,
 989         data_content_count, data_type>: Remove.
 990         (enum tui_data_type): Remove.
 991
 992         * tui/tui-data.c (tui_data_window::clear_detail)
 993         (~tui_data_window): Update.
 994
 995 2019-06-25  Tom Tromey  <tom@tromey.com>
 996
 997         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
 998         declare.
 999         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1000         Rename from tui_first_data_item_displayed.  Update.
1001         (tui_data_window::refresh_all)
1002         (tui_data_window::do_scroll_vertical): Update.
1003         * tui/tui-data.h (struct tui_data_window)
1004         <first_data_item_displayed>: Declare new method.
1005
1006 2019-06-25  Tom Tromey  <tom@tromey.com>
1007
1008         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1009         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1010         contents...
1011         (tui_initialize_static_data): ...here.
1012
1013 2019-06-25  Tom Tromey  <tom@tromey.com>
1014
1015         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1016         (tui_display_registers_from, tui_check_register_values): Update.
1017         (tui_display_register): Remove win_info parameter; update.
1018         (tui_get_register): Change type of parameters.
1019         * tui/tui-data.h (struct tui_data_element): Remove.
1020         (union tui_which_element) <data>: Remove.
1021         <data_window>: Change type.
1022         (struct tui_data_item_window): New.
1023         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1024         case.  Add assert.
1025         (~tui_data_item_window): New destructor.
1026         (free_content_elements): Remove DATA_ITEM_WIN case.
1027
1028 2019-06-25  Tom Tromey  <tom@tromey.com>
1029
1030         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1031         Remove.
1032
1033 2019-06-25  Tom Tromey  <tom@tromey.com>
1034
1035         * tui/tui-data.h (struct tui_command_element): Remove.
1036         (union tui_which_element) <command>: Remove.
1037         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1038         assert.
1039         (free_content_elements): Remove CMD_WIN case.
1040
1041 2019-06-25  Tom Tromey  <tom@tromey.com>
1042
1043         * tui/tui-layout.c (tui_set_layout): Update.
1044         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1045         * tui/tui-data.c (layout_def): Update.
1046
1047 2019-06-25  Tom Tromey  <tom@tromey.com>
1048
1049         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1050         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1051         (tui_source_window_base::set_new_height): Update.
1052         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1053         Update.
1054         (tui_set_locator_fullname, tui_set_locator_info)
1055         (tui_show_frame_info): Update.
1056         * tui/tui-source.c (tui_set_source_content)
1057         (tui_source_is_displayed): Update.
1058         * tui/tui-layout.c (show_source_disasm_command, show_data)
1059         (show_source_or_disasm_and_command): Update.
1060         * tui/tui-disasm.c (tui_set_disassem_content)
1061         (tui_get_begin_asm_address): Update.
1062         * tui/tui-data.h (struct tui_locator_element): Remove.
1063         (union tui_which_element) <locator>: Remove.
1064         (struct tui_locator_window): New.
1065         (tui_locator_win_info_ptr): Change return type.
1066         * tui/tui-data.c (_locator): Change type.
1067         (tui_locator_win_info_ptr): Change return type.
1068         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1069         (tui_alloc_content): Add assert.
1070
1071 2019-06-25  Tom Tromey  <tom@tromey.com>
1072
1073         * tui/tui-winsource.c
1074         (tui_exec_info_window::maybe_allocate_content): New method.
1075         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1076         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1077         (make_source_or_disasm_window): Add cast.
1078         * tui/tui-data.h (union tui_which_element) <simple_string>:
1079         Remove.
1080         (struct tui_source_info): New.
1081         (struct tui_source_window_base) <execution_info>: Change type.
1082         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1083         case, and add assert.
1084         (tui_alloc_content): Add assert.
1085
1086 2019-06-25  Tom Tromey  <tom@tromey.com>
1087
1088         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1089         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1090         * tui/tui-data.c (tui_alloc_win_info): Remove.
1091
1092 2019-06-25  Tom Tromey  <tom@tromey.com>
1093
1094         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1095         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1096         can_highlight.
1097
1098 2019-06-25  Tom Tromey  <tom@tromey.com>
1099
1100         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1101         make_visible_with_new_height method.
1102         (tui_win_info::make_visible_with_new_height): New method.
1103         (tui_source_window_base::do_make_visible_with_new_height)
1104         (tui_data_window::do_make_visible_with_new_height)
1105         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1106         (make_visible_with_new_height): Remove.
1107         (tui_resize_all, tui_adjust_win_heights): Use
1108         make_visible_with_new_height method.
1109         * tui/tui-data.h (struct tui_win_info)
1110         <do_make_visible_with_new_height, make_visible_with_new_height>:
1111         New methods.
1112         (struct tui_source_window_base, struct tui_data_window)
1113         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1114         methods.
1115
1116 2019-06-25  Tom Tromey  <tom@tromey.com>
1117
1118         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1119         method.
1120         (update_tab_width): Call update_tab_width method.
1121         * tui/tui-data.h (struct tui_win_info)
1122         (struct tui_source_window_base) <update_tab_width>: New methods.
1123
1124 2019-06-25  Tom Tromey  <tom@tromey.com>
1125
1126         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1127         parameter.
1128         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1129         parameter.
1130         (tui_gen_win_info::make_visible): Update.
1131         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1132         parameter.
1133         * tui/tui-data.h (enum tui_box): New enum.
1134         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1135
1136 2019-06-25  Tom Tromey  <tom@tromey.com>
1137
1138         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1139         init_and_make_win for EXEC_INFO_WIN.
1140         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1141         longer inline.
1142         (struct tui_win_info) <~tui_win_info>: Inline.
1143         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1144         Don't declare.
1145         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1146         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1147         Remove.
1148         (tui_initialize_static_data): Update.
1149         (~tui_gen_win_info): Handle more cleanup here.
1150         (~tui_source_window_base): Delete "execution_info".
1151         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1152
1153 2019-06-25  Tom Tromey  <tom@tromey.com>
1154
1155         * tui/tui-layout.c (make_command_window): Don't set
1156         can_highlight.
1157         (show_source_disasm_command): Call the reset method.
1158         (show_data): Don't set can_highlight.  Call the reset method.
1159         (tui_gen_win_info::reset): Rename from init_gen_win_info
1160         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1161         (show_source_or_disasm_and_command): Call the reset method.
1162         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1163         (struct tui_cmd_window): Set can_highlight.
1164
1165 2019-06-25  Tom Tromey  <tom@tromey.com>
1166
1167         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1168         from make_visible.
1169         (tui_make_visible, tui_make_invisible): Rewrite.
1170         (tui_win_info::make_visible): Remove.
1171         (tui_source_window_base::make_visible): Update.
1172         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1173         method.  Moved from...
1174         (struct tui_win_info) <make_visible>: ...here.
1175
1176 2019-06-25  Tom Tromey  <tom@tromey.com>
1177
1178         * tui/tui-winsource.c
1179         (tui_source_window_base::do_scroll_horizontal): Remove direction
1180         parameter.
1181         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1182         direction parameter.
1183         * tui/tui-win.c (tui_win_info::forward_scroll)
1184         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1185         (tui_win_info::right_scroll): Update.
1186         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1187         direction parameter.
1188         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1189         direction parameter.
1190         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1191         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1192         Remove direction parameter.
1193         (struct tui_source_window_base, struct tui_source_window)
1194         (struct tui_disasm_window, struct tui_data_window)
1195         (struct tui_cmd_window): Update.
1196
1197 2019-06-25  Tom Tromey  <tom@tromey.com>
1198
1199         * tui/tui-winsource.h (tui_set_exec_info_content)
1200         (tui_show_exec_info_content, tui_erase_exec_info_content)
1201         (tui_clear_exec_info_content, tui_update_exec_info): Change
1202         argument to tui_source_window_base.
1203         * tui/tui-winsource.c (tui_set_exec_info_content)
1204         (tui_show_exec_info_content, tui_erase_exec_info_content)
1205         (tui_clear_exec_info_content, tui_update_exec_info): Change
1206         argument to tui_source_window_base.
1207
1208 2019-06-25  Tom Tromey  <tom@tromey.com>
1209
1210         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1211         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1212
1213 2019-06-25  Tom Tromey  <tom@tromey.com>
1214
1215         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1216         check.
1217
1218 2019-06-25  Tom Tromey  <tom@tromey.com>
1219
1220         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1221         type to void.
1222         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1223         type to void.
1224         * tui/tui-source.c (tui_set_source_content): Update.
1225         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1226
1227 2019-06-25  Tom Tromey  <tom@tromey.com>
1228
1229         * tui/tui-win.c (window_name_completer, tui_set_focus)
1230         (tui_all_windows_info): Use name method.
1231         * tui/tui-data.h (struct tui_gen_win_info)
1232         (struct tui_source_window, struct tui_disasm_window)
1233         (struct tui_data_window, struct tui_cmd_window) <name>: New
1234         method.
1235         (tui_win_name): Don't declare.
1236         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1237         (tui_win_name): Remove.
1238
1239 2019-06-25  Tom Tromey  <tom@tromey.com>
1240
1241         * tui/tui-winsource.h (tui_update_source_window)
1242         (tui_update_source_window_as_is): Change parameter type.
1243         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1244         to be a tui_source_window_base.
1245         (tui_update_source_window_as_is): Likewise.
1246         * tui/tui-win.c (make_visible_with_new_height): Update.
1247
1248 2019-06-25  Tom Tromey  <tom@tromey.com>
1249
1250         * tui/tui-winsource.c (tui_erase_source_content)
1251         (tui_show_source_content, tui_show_exec_info_content)
1252         (tui_erase_exec_info_content): Use refresh_window method.
1253         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1254         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1255         from tui_refresh_win.
1256         (tui_data_window::refresh_window): New method.
1257         (tui_win_info::refresh, tui_source_window_base::refresh)
1258         (tui_refresh_all): Use refresh_window method.
1259         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1260         method.
1261         * tui/tui-regs.c (tui_display_register): Call refresh_window
1262         method.
1263         * tui/tui-layout.c (show_source_disasm_command)
1264         (show_source_or_disasm_and_command): Call refresh_window method.
1265         * tui/tui-data.h (struct tui_gen_win_info)
1266         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1267         New method.
1268
1269 2019-06-25  Tom Tromey  <tom@tromey.com>
1270
1271         * tui/tui.c (tui_rl_other_window, tui_enable)
1272         (tui_is_window_visible, tui_get_command_dimension): Update.
1273         * tui/tui-winsource.c (tui_update_source_window_as_is)
1274         (tui_clear_source_content, tui_erase_source_content)
1275         (tui_show_source_line, tui_source_window_base::refill)
1276         (tui_source_window_base::do_scroll_horizontal)
1277         (tui_source_window_base::set_is_exec_point_at)
1278         (tui_update_breakpoint_info, tui_set_exec_info_content)
1279         (tui_alloc_source_buffer, tui_line_is_displayed)
1280         (tui_addr_is_displayed): Update.
1281         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1282         (tui_check_and_display_highlight_if_needed)
1283         (tui_win_info::make_visible, tui_win_info::refresh)
1284         (tui_refresh_all): Update.
1285         * tui/tui-windata.c (tui_first_data_item_displayed)
1286         (tui_delete_data_content_windows, tui_erase_data_content)
1287         (tui_display_all_data, tui_data_window::refresh_all)
1288         (tui_check_data_values): Update.
1289         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1290         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1291         (tui_win_info::backward_scroll, tui_refresh_all_win)
1292         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1293         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1294         (tui_source_window_base::set_new_height)
1295         (tui_data_window::set_new_height)
1296         (make_invisible_and_set_new_height)
1297         (make_visible_with_new_height, new_height_ok)
1298         (parse_scrolling_args): Update.
1299         * tui/tui-stack.c (tui_show_frame_info): Update.
1300         * tui/tui-source.c (tui_set_source_content)
1301         (tui_set_source_content_nil, tui_source_is_displayed)
1302         (tui_source_window::do_scroll_vertical): Update.
1303         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1304         (tui_display_registers_from, tui_display_reg_element_at_line)
1305         (tui_check_register_values, tui_reg_command): Update.
1306         * tui/tui-layout.c (tui_default_win_height)
1307         (show_source_disasm_command, show_data, init_and_make_win)
1308         (show_source_or_disasm_and_command): Update.
1309         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1310         (tui_redisplay_readline, tui_mld_flush)
1311         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1312         (tui_getc): Update.
1313         * tui/tui-disasm.c (tui_set_disassem_content)
1314         (tui_disasm_window::do_scroll_vertical): Update.
1315         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1316         Now virtual.
1317         (struct tui_win_info): Derive from tui_gen_win_info.
1318         <~tui_win_info>: Mark as override.
1319         <generic>: Remove member.
1320         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1321         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1322         (~tui_data_window, ~tui_win_info)
1323         (tui_free_all_source_wins_content): Update.
1324         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1325
1326 2019-06-25  Tom Tromey  <tom@tromey.com>
1327
1328         * tui/tui-layout.c (init_and_make_win): Use new.
1329         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1330         destructor, initializers.
1331         (tui_alloc_generic_win_info): Don't declare.
1332         * tui/tui-data.c (_locator): Add argument to constructor.
1333         (source_win, disasm_win): New globals.
1334         (exec_info): Remove.
1335         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1336         Update.
1337         (tui_alloc_generic_win_info): Remove.
1338         (init_content_element): Use new.
1339         (tui_win_info::tui_win_info): Update.
1340         (free_content_elements) <case DATA_WIN>: Use delete.
1341
1342 2019-06-25  Tom Tromey  <tom@tromey.com>
1343
1344         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1345         * tui/tui-windata.c (tui_first_data_item_displayed)
1346         (tui_delete_data_content_windows): Update.
1347         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1348         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1349         (tui_display_registers_from, tui_check_register_values): Update.
1350         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1351         pointer.
1352         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1353         window.
1354         (tui_free_data_content): Update.
1355         (free_content_elements) <case DATA_WIN>: Free the window.
1356
1357 2019-06-25  Tom Tromey  <tom@tromey.com>
1358
1359         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1360         Update.
1361         * tui/tui-layout.c (make_command_window)
1362         (show_source_disasm_command, show_data, init_and_make_win)
1363         (show_source_or_disasm_and_command): Update.
1364         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1365         method.
1366         <can_highight, is_highlighted>: Now bool.
1367         (tui_set_win_highlight): Don't declare.
1368         * tui/tui-data.c (tui_set_win_highlight): Remove.
1369
1370 2019-06-25  Tom Tromey  <tom@tromey.com>
1371
1372         * tui/tui-wingeneral.c (make_visible): Remove check of window
1373         type.
1374
1375 2019-06-25  Tom Tromey  <tom@tromey.com>
1376
1377         * tui/tui-win.c (tui_win_info::max_height)
1378         (tui_cmd_window::max_height): New methods.
1379         (new_height_ok): Call max_height.
1380         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1381         <max_height>: New method.
1382
1383 2019-06-25  Tom Tromey  <tom@tromey.com>
1384
1385         * tui/tui-win.c (tui_source_window_base::set_new_height)
1386         (tui_data_window::set_new_height): New methods.
1387         (make_invisible_and_set_new_height): Call set_new_height method.
1388         * tui/tui-data.h (struct tui_win_info)
1389         (struct tui_source_window_base, struct tui_data_window)
1390         <set_new_height>: New method.
1391
1392 2019-06-25  Tom Tromey  <tom@tromey.com>
1393
1394         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1395         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1396         tui_refresh_data_win.
1397         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1398         method.
1399         (tui_refresh_all_win): Call the refresh_all method.
1400         (tui_set_focus): Likewise.
1401         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1402         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1403         Likewise.
1404
1405 2019-06-25  Tom Tromey  <tom@tromey.com>
1406
1407         * tui/tui-winsource.h (tui_refill_source_window)
1408         (tui_set_is_exec_point_at): Don't declare.
1409         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1410         (tui_source_window_base::refill): Rename from
1411         tui_refill_source_window.
1412         (tui_source_window_base::do_scroll_horizontal): Update.
1413         (tui_source_window_base::set_is_exec_point_at): Rename from
1414         tui_set_is_exec_point_at.
1415         (tui_update_all_breakpoint_info): Update.
1416         * tui/tui-stack.c (tui_show_frame_info): Update.
1417         * tui/tui-layout.c (show_data): Add cast.
1418         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1419         * tui/tui-data.h (struct tui_source_window_base) <refill,
1420         set_is_exec_point_at>: New methods.
1421         (tui_source_windows, tui_add_to_source_windows): Update types.
1422         (tui_add_to_source_windows): Remove redundant declaration.
1423         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1424         (tui_source_windows): Change return type.
1425         (tui_clear_source_windows_detail): Update.
1426         (tui_add_to_source_windows): Change type of parameter.
1427         (tui_free_all_source_wins_content): Update.
1428
1429 2019-06-25  Tom Tromey  <tom@tromey.com>
1430
1431         * tui/tui-wingeneral.c (tui_win_info::refresh)
1432         (tui_source_window_base::refresh): New methods.
1433         (tui_refresh_all): Call the refresh method.
1434         * tui/tui-data.h (struct tui_win_info)
1435         (struct tui_source_window_base) <refresh>: New method.
1436
1437 2019-06-25  Tom Tromey  <tom@tromey.com>
1438
1439         * tui/tui.h (tui_is_window_visible): Return bool.
1440         * tui/tui.c (tui_is_window_visible): Return bool.
1441         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1442         (tui_make_visible, tui_make_invisible)
1443         (tui_win_info::make_visible)
1444         (tui_source_window_base::make_visible, make_all_visible)
1445         (tui_make_all_visible, tui_make_all_invisible): Update.
1446         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1447         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1448         bool.
1449         (struct tui_win_info, struct tui_source_window_base)
1450         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1451         * tui/tui-data.c (tui_init_generic_part): Update.
1452
1453 2019-06-25  Tom Tromey  <tom@tromey.com>
1454
1455         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1456         (tui_source_window_base::make_visible): New methods.
1457         (make_all_visible): Make method call.
1458         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1459         (struct tui_source_window_base, struct tui_cmd_window): Override
1460         make_visible.
1461         (tui_win_is_source_type): Don't declare.
1462         * tui/tui-data.c (tui_win_is_source_type): Remove.
1463
1464 2019-06-25  Tom Tromey  <tom@tromey.com>
1465
1466         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1467         NULL check.
1468
1469 2019-06-25  Tom Tromey  <tom@tromey.com>
1470
1471         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1472         Inline constructor.  Add initializers for members.
1473         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1474         constructors; now inline in class.
1475
1476 2019-06-25  Tom Tromey  <tom@tromey.com>
1477
1478         * tui/tui-regs.c (tui_show_registers): Update.
1479         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1480         bool.
1481         * tui/tui-data.c (tui_data_window::clear_detail)
1482         (tui_data_window): Update.
1483
1484 2019-06-25  Tom Tromey  <tom@tromey.com>
1485
1486         * tui/tui-windata.c (tui_display_all_data)
1487         (tui_display_data_from_line, tui_display_data_from)
1488         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1489         Update.
1490         * tui/tui-regs.c (tui_last_regs_line_no)
1491         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1492         (tui_show_registers, tui_show_register_group)
1493         (tui_display_registers_from, tui_display_reg_element_at_line)
1494         (tui_display_registers_from_line, tui_check_register_values)
1495         (tui_reg_next, tui_reg_prev): Update.
1496         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1497         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1498         tui_data_window.
1499         (struct tui_win_info) <detail>: Remove.  Add new fields from
1500         tui_data_info.
1501         (TUI_DATA_WIN): Add cast.
1502         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1503         (~tui_data_window): Simplify.
1504
1505 2019-06-25  Tom Tromey  <tom@tromey.com>
1506
1507         * tui/tui-layout.c (show_source_disasm_command)
1508         (show_source_or_disasm_and_command): Update.
1509         * tui/tui-io.c (update_cmdwin_start_line)
1510         (tui_redisplay_readline): Update.
1511         * tui/tui-data.h (struct tui_command_info): Remove.
1512         (struct tui_win_info) <detail>: Remove command_info member.
1513         (struct tui_data_window) <start_line>: New member, from
1514         tui_command_info.
1515         (TUI_CMD_WIN): Add casts.
1516
1517 2019-06-25  Tom Tromey  <tom@tromey.com>
1518
1519         * tui/tui-winsource.c (tui_update_source_window)
1520         (tui_refill_source_window)
1521         (tui_source_window_base::do_scroll_horizontal)
1522         (tui_update_breakpoint_info, tui_set_exec_info_content)
1523         (tui_show_exec_info_content, tui_erase_exec_info_content)
1524         (tui_clear_exec_info_content): Update.
1525         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1526         Update.
1527         * tui/tui-win.c (make_invisible_and_set_new_height)
1528         (make_visible_with_new_height): Update.
1529         * tui/tui-source.c (tui_set_source_content)
1530         (tui_show_symtab_source): Update.
1531         * tui/tui-layout.c (extract_display_start_addr)
1532         (show_source_disasm_command, show_data)
1533         (make_source_or_disasm_window)
1534         (show_source_or_disasm_and_command): Update.
1535         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1536         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1537         "gdbarch".
1538         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1539         to tui_source_window_base.
1540         (struct tui_win_info) <detail>: Remove source_info member.
1541         (struct tui_source_window_base) <has_locator>: Inline.
1542         Move contents from tui_source_info; rename has_locator member to
1543         m_has_locator.
1544         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1545         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1546         header file.
1547         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1548         Simplify.
1549         (tui_free_all_source_wins_content): Cast to
1550         tui_source_window_base.
1551
1552 2019-06-25  Tom Tromey  <tom@tromey.com>
1553
1554         * tui/tui-win.c (make_invisible_and_set_new_height)
1555         (make_visible_with_new_height): Call has_locator method.
1556         * tui/tui-layout.c (show_source_disasm_command, show_data)
1557         (show_source_or_disasm_and_command): Update for bool change.
1558         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1559         (tui_win_info) <has_locator>: New method.
1560         (struct tui_source_window_base) <has_locator>: New method.
1561         (tui_win_has_locator): Don't declare.
1562         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1563         from tui_win_has_locator.
1564         (tui_source_window_base): Use false, not FALSE.
1565
1566 2019-06-25  Tom Tromey  <tom@tromey.com>
1567
1568         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1569         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1570         clear_detail method directly.
1571         (tui_clear_win_detail): Remove.
1572
1573 2019-06-25  Tom Tromey  <tom@tromey.com>
1574
1575         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1576         "this", not TUI_DISASM_WIN.
1577
1578 2019-06-25  Tom Tromey  <tom@tromey.com>
1579
1580         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1581         declare.
1582         * tui/tui-winsource.c
1583         (tui_source_window_base::do_scroll_horizontal): Rename from
1584         tui_horizontal_source_scroll.
1585         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1586         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1587         from tui_vertical_data_scroll.
1588         * tui/tui-win.h (tui_scroll): Don't declare.
1589         * tui/tui-win.c (tui_win_info::forward_scroll)
1590         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1591         (tui_win_info::right_scroll): Rename and update.
1592         (tui_scroll_forward_command, tui_scroll_backward_command)
1593         (tui_scroll_left_command, tui_scroll_right_command): Update.
1594         (tui_scroll): Remove.
1595         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1596         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1597         from tui_vertical_source_scroll.
1598         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1599         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1600         from tui_vertical_disassem_scroll.
1601         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1602         do_scroll_horizontal>: New methods.
1603         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1604         Likewise.
1605         (struct tui_source_window_base): Add do_scroll_horizontal.
1606         (struct tui_source_window, struct tui_disasm_window): Add
1607         do_scroll_vertical.
1608         (struct tui_data_window, struct tui_cmd_window): Add
1609         do_scroll_horizontal and do_scroll_vertical.
1610         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1611
1612 2019-06-25  Tom Tromey  <tom@tromey.com>
1613
1614         * tui/tui-data.h (struct tui_source_window_base): New struct.
1615         (struct tui_source_window): Derive from tui_source_window_base.
1616         (struct tui_disasm_window): New struct.
1617         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1618         from tui_source_window::clear_detail.
1619         (tui_source_window_base): Rename from tui_source_window.
1620         (~tui_source_window_base): Rename from ~tui_source_window.
1621         (tui_alloc_win_info): Create a tui_disasm_window.
1622
1623 2019-06-25  Tom Tromey  <tom@tromey.com>
1624
1625         * tui/tui-data.h (struct tui_source_window)
1626         (struct tui_data_window): Declare destructors.
1627         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1628         destructors.
1629         (tui_win_info): Simplify.
1630
1631 2019-06-25  Tom Tromey  <tom@tromey.com>
1632
1633         * tui/tui-winsource.c (tui_display_main)
1634         (tui_update_source_windows_with_addr)
1635         (tui_update_all_breakpoint_info): Update.
1636         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1637         (new_height_ok, parse_scrolling_args): Update.
1638         * tui/tui-stack.c (tui_show_frame_info): Update.
1639         * tui/tui-data.h (struct tui_list): Remove.
1640         (tui_source_windows): Return a reference to a std::vector.
1641         * tui/tui-data.c (source_windows): Now a std::vector.
1642         (tui_source_windows): Change return type.
1643         (tui_clear_source_windows): Rewrite.
1644         (tui_clear_source_windows_detail, tui_add_to_source_windows)
1645         (tui_free_all_source_wins_content): Rewrite.
1646
1647 2019-06-25  Tom Tromey  <tom@tromey.com>
1648
1649         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
1650         (struct tui_data_window, struct tui_cmd_window): Declare
1651         clear_detail method.
1652         * tui/tui-data.c (tui_source_window::clear_detail)
1653         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
1654         methods.
1655         (tui_clear_win_detail): Simplify.
1656
1657 2019-06-25  Tom Tromey  <tom@tromey.com>
1658
1659         * tui/tui-layout.c (make_source_window, make_disasm_window)
1660         (make_source_or_disasm_window): Remove win_info_ptr parameter.
1661         Return the new window.
1662         (show_source_disasm_command, show_data)
1663         (show_source_or_disasm_and_command): Update.
1664
1665 2019-06-25  Tom Tromey  <tom@tromey.com>
1666
1667         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
1668         parameter.  Return the new window.
1669         (show_source_disasm_command): Update and remove NULL check.
1670         (show_source_or_disasm_and_command): Update.
1671
1672 2019-06-25  Tom Tromey  <tom@tromey.com>
1673
1674         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
1675
1676 2019-06-25  Tom Tromey  <tom@tromey.com>
1677
1678         * tui/tui-data.h (struct tui_win_info): Make constructor
1679         protected.  Make destructor virtual.  Add initializers.
1680         (tui_source_window, tui_data_window, tui_cmd_window): New
1681         classes.
1682         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
1683         constructor.  Add "type" parameter.
1684         (tui_source_window, tui_data_window, tui_cmd_window): New
1685         constructors.
1686         (tui_alloc_win_info): Instantiate the appropriate subclass.
1687
1688 2019-06-25  Tom Tromey  <tom@tromey.com>
1689
1690         * tui/tui-win.c (tui_resize_all): Use delete.
1691         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
1692         destructor.
1693         (tui_free_window): Don't declare.
1694         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
1695         Update.
1696
1697 2019-06-25  Tom Tromey  <tom@tromey.com>
1698
1699         * tui/tui-data.h (struct tui_win_info): Add constructor.
1700         * tui/tui-data.c (tui_alloc_win_info): Use new.
1701         (tui_free_window): Use delete.
1702
1703 2019-06-22  Tom Tromey  <tom@tromey.com>
1704
1705         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
1706         declare.
1707         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
1708
1709 2019-06-22  Tom Tromey  <tom@tromey.com>
1710
1711         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
1712         declare.
1713         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
1714
1715 2019-06-22  Tom de Vries  <tdevries@suse.de>
1716
1717         * dwarf2read.c (create_addrmap_from_aranges)
1718         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
1719         instead of '%zu'.
1720
1721 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
1722
1723         * dwarf2read.h (dwarf2_section_info_def): Remove.
1724         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
1725         * dwarf2read.c (struct dwo_sections) <types>: Change type to
1726         std::vector<dwarf2_section_info>.
1727         (struct dwo_file) <~dwo_file>: Remove.
1728         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
1729         types field.
1730         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
1731         (dwarf2_read_debug_names): Likewise.
1732         (create_debug_types_hash_table): Change parameter type to
1733         array_view, adjust code accordingly.
1734         (dwarf2_locate_dwo_sections): Adjust to std::vector.
1735         (partial_die_info::fixup): Likewise.
1736         (determine_prefix): Likewise.
1737         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
1738
1739 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1740
1741         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
1742         gdb_bfd_ref_ptr.
1743         <~dwo_file>: Remove call to gdb_bfd_unref.
1744         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
1745         gdb_bfd_ref_ptr::get.
1746
1747 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1748
1749         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
1750         type to htab_up.
1751         * dwarf2read.c (struct dwo_file): Initialize fields.
1752         <~dwo_file>: New.
1753         (free_dwo_file): Remove, move content to ~dwo_file.
1754         (struct dwo_file_deleter): Remove.
1755         (dwo_file_up>: Remove custom deleter.
1756         (free_dwo_files): Remove.
1757         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
1758         dwo_files.
1759         (process_skeletonless_type_units): Call unique_ptr::get.
1760         (allocate_dwo_file_hash_table): Add deleter to created hash
1761         table.  Change return type to htab_up.
1762         (lookup_dwo_file_slot): Don't memset dwo_file, call
1763         unique_ptr::get.
1764         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
1765         (create_dwo_unit_in_dwp_v2): Likewise.
1766         (open_and_init_dwo_file): Likewise.
1767         (free_dwo_file_from_slot): Remove.
1768
1769 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1770
1771         * dwarf2read.h (struct dwarf2_section_info) <readin,
1772         is_virtual>: Change type to bool.
1773         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
1774         true instead of 1.
1775
1776 2019-06-19  Tom Tromey  <tom@tromey.com>
1777
1778         * tui/tui-data.h (tui_init_content_element): Don't declare.
1779
1780 2019-06-19  Tom Tromey  <tom@tromey.com>
1781
1782         * tui/tui-data.h (tui_init_win_info): Don't declare.
1783
1784 2019-06-19  Tom de Vries  <tdevries@suse.de>
1785
1786         * dwarf2read.h (abstract_to_concrete): Change type to
1787         std::unordered_map<sect_offset, std::vector<sect_offset>,
1788         gdb::hash_enum<sect_offset>>.
1789
1790 2019-06-19  Tom Tromey  <tromey@adacore.com>
1791
1792         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
1793         EVAL_AVOID_SIDE_EFFECTS specially.
1794
1795 2019-06-19  Tom Tromey  <tromey@adacore.com>
1796
1797         * source-cache.c (highlighter): New global.
1798         (source_cache::get_source_lines): Create a highlighter on demand.
1799
1800 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1801
1802         * defs.h (deprecated_interactive_hook): Delete declaration.
1803         * interps.c (clear_interpreter_hooks): Remove use of
1804         deprecated_interactive_hook.
1805         * top.c (deprecated_interactive_hook): Delete definition.
1806         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
1807
1808 2019-06-18  Tom de Vries  <tdevries@suse.de>
1809
1810         PR gdb/24515
1811         * dwarf2read.h (abstract_to_concrete): Change type from
1812         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
1813         std::unordered_map<sect_offset, std::vector<sect_offset>>.
1814         * dwarf2read.c (read_variable): Update.
1815         (dwarf2_fetch_die_loc_sect_off): Update.
1816
1817 2019-06-17  Tom de Vries  <tdevries@suse.de>
1818
1819         PR gdb/24617
1820         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
1821         accessing parent[parent_len - 1].
1822
1823 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
1824
1825         PR gdb/24364
1826         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
1827         call dtrace_process_dof with NULL dof.
1828
1829 2019-06-16  Tom de Vries  <tdevries@suse.de>
1830
1831         PR gdb/24445
1832         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
1833
1834 2019-06-16  Tom Tromey  <tom@tromey.com>
1835
1836         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1837         (make_all_visible): Use address of member.
1838
1839 2019-06-16  Tom Tromey  <tom@tromey.com>
1840
1841         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
1842         (tui_free_window, free_content, free_content_elements): Remove
1843         unnecessary cast.
1844         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
1845         cast.
1846         * tui/tui-regs.c (tui_show_register_group)
1847         (tui_display_registers_from, tui_display_reg_element_at_line):
1848         Remove unnecessary cast.
1849
1850 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
1851
1852         * linux-nat.c (normal_mask): Delete.
1853         (_initialize_linux_nat): Don't initialise normal_mask.
1854
1855 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
1856
1857         PR gdb/24445
1858         * dwarf-index-write.h (write_psymtabs_to_index): Add
1859         dwz_basename parameter.
1860         * dwarf-index-write.c (write_gdbindex): Move file writing to
1861         write_gdbindex_1.  Change return type void.
1862         (assert_file_size): Move up, remove filename parameter.
1863         (write_gdbindex_1): New function.
1864         (write_debug_names): Change return type to void, call
1865         assert_file_size.
1866         (struct index_wip_file): New struct.
1867         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
1868         file logic to index_wip_file.  Write index for dwz file if
1869         needed.
1870         (save_gdb_index_command): Pass basename of dwz file, if present.
1871         * dwarf-index-cache.c (index_cache::store): Obtain and pass
1872         build-id of dwz file, if present.
1873         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1874         (dwarf2_get_dwz_file): Likewise.
1875         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1876         (dwarf2_get_dwz_file): Likewise.
1877
1878 2019-06-16  Tom Tromey  <tom@tromey.com>
1879
1880         * coffread.c (process_coff_symbol): Use xstrdup.
1881         * value.c (create_internalvar): Use xstrdup.
1882
1883 2019-06-16  Tom Tromey  <tom@tromey.com>
1884
1885         * valops.c (value_cast, value_slice): Remove unnecessary cast.
1886         * breakpoint.c (stopin_command, stopat_command)
1887         (until_break_command, decode_location_default): Remove unnecessary
1888         cast.
1889         * utils.c (subset_compare): Remove unnecessary cast.
1890         * ada-lang.c (ada_update_initial_language): Remove unnecessary
1891         cast.
1892         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1893         cast.
1894         * infcmd.c (path_command): Remove unnecessary cast.
1895         * coffread.c (decode_type): Remove unnecessary cast.
1896         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1897         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1898         * tui/tui-stack.c (tui_show_locator_content)
1899         (tui_show_frame_info): Remove unnecessary cast.
1900         * tui/tui-win.c (tui_scroll_forward_command)
1901         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1902         (parse_scrolling_args): Remove unnecessary cast.
1903         * tui/tui-data.c (init_win_info, tui_del_window)
1904         (tui_free_window, tui_del_data_windows, tui_free_data_content)
1905         (free_content_elements): Remove unnecessary cast.
1906         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1907         unnecessary cast.
1908         * tui/tui-source.c (tui_set_source_content)
1909         (tui_vertical_source_scroll): Remove unnecessary cast.
1910         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1911         cast.
1912         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1913         * tui/tui-regs.c (tui_display_registers_from)
1914         (tui_display_register): Remove unnecessary cast.
1915         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1916         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1917         (make_visible): Remove unnecessary cast.
1918         * tui/tui-winsource.c (tui_erase_source_content)
1919         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1920         unnecessary cast.
1921         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1922         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1923         * stabsread.c (read_type, read_array_type, read_range_type):
1924         Remove unnecessary cast.
1925         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1926         (parse_symbol, parse_type, upgrade_type, parse_external)
1927         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
1928         unnecessary cast.
1929         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
1930
1931 2019-06-16  Tom Tromey  <tom@tromey.com>
1932
1933         * tui/tui-data.c (tui_alloc_generic_win_info)
1934         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
1935         checks.
1936
1937 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
1938             Andrew Burgess  <andrew.burgess@embecosm.com>
1939
1940         * f-typeprint.c (f_print_type): Don't return early for not
1941         associated or not allocated types.
1942         (f_type_print_varspec_suffix): Add print_rank parameter and print
1943         ranks of array types in case they dangling.
1944         (f_type_print_base): Add print_rank parameter.
1945
1946 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1947
1948         * NEWS: Mention new MI commands.
1949         * break-catch-throw.c (enum exception_event_kind): Move to
1950         breakpoint.h.
1951         (print_mention_exception_catchpoint): Output text as a single
1952         message.
1953         (catch_exception_command_1): Rename to...
1954         (catch_exception_event): ...this, make non-static, update header
1955         command, and change some parameter types.
1956         (catch_catch_command): Update for changes to
1957         catch_exception_command_1.
1958         (catch_throw_command): Likewise.
1959         (catch_rethrow_command): Likewise.
1960         * breakpoint.c (enum exception_event_kind): Delete.
1961         * breakpoint.h (enum exception_event_kind): Moved here from
1962         break-catch-throw.c.
1963         (catch_exception_event): Declare.
1964         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
1965         (mi_cmd_catch_throw): New function.
1966         (mi_cmd_catch_rethrow): New function.
1967         (mi_cmd_catch_catch): New function.
1968         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
1969         'catch-catch' entries.
1970         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
1971         (mi_cmd_catch_rethrow): Declare.
1972         (mi_cmd_catch_catch): Declare.
1973
1974 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1975
1976         * annotate.c (annotate_source_line): Change return type to void,
1977         update implementation to match.
1978         * annotate.h (annotate_source_line): Change return type to void,
1979         update header comment.
1980         * stack.c (print_frame_info): Don't change what frame information
1981         is printed based on whether annotations are on or not.
1982
1983 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1984
1985         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
1986         (annotate_source): Make static.
1987         (annotate_source_line): Moved from source.c and renamed from
1988         identify_source_line.  Update the return type.
1989         * annotate.h (annotate_source): Delete declaration.
1990         (annotate_source_line): Declaration moved from source.h, and
1991         renamed from identify_source_line.  Return type updated.
1992         * source.c (identify_source_line): Moved to annotate.c and renamed
1993         to annotate_source_line.
1994         (info_line_command): Remove check of annotation_level.
1995         * source.h (identify_source_line): Move declaration to annotate.h
1996         and rename to annotate_source_line.
1997         * stack.c: Add 'annotate.h' include.
1998         (print_frame_info): Remove check of annotation_level before
1999         calling annotate_source_line.
2000
2001 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2002
2003         * source-cache.c (source_cache::get_plain_source_lines): Use
2004         open_source_file_with_line_charpos instead of just
2005         open_source_file, remove call to find_source_lines.
2006         (source_cache::get_source_lines): Likewise.
2007         * source.c (find_source_lines): Make static.
2008         (get_filename_and_charpos): Renamed into...
2009         (open_source_file_with_line_charpos): ..this along with changes to
2010         return a scoped_fd, and some other minor clean ups.
2011         (identify_source_line): Use open_source_file_with_line_charpos.
2012         (search_command_helper): Use open_source_file_with_line_charpos
2013         instead of just open_source_file, remove call to
2014         find_source_lines.
2015         * source.h (open_source_file_with_line_charpos): Declare new
2016         function.
2017         (find_source_lines): Delete declaration.
2018
2019 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2020
2021         * source.c (get_filename_and_charpos): Remove fullname
2022         parameter.
2023         (identify_source_line): Update call to get_filename_and_charpos.
2024
2025 2019-06-14  Tom Tromey  <tromey@adacore.com>
2026
2027         PR gdb/24502:
2028         * ui-style.h (skip_ansi_escape): Update comment.
2029         * ui-file.h (class no_terminal_escape_file): New class.
2030         * ui-file.c (no_terminal_escape_file::write)
2031         (no_terminal_escape_file::puts): New methods.
2032         * cli/cli-logging.c (handle_redirections): Use
2033         no_terminal_escape_file.
2034
2035 2019-06-14  Tom Tromey  <tromey@adacore.com>
2036
2037         * NEWS: Move convenience variable news above Python news.
2038
2039 2019-06-14  Tom Tromey  <tom@tromey.com>
2040
2041         * gnulib: Move directory to top-level.
2042         * configure.ac: Don't configure gnulib.
2043         * configure: Rebuild.
2044         * common/common-defs.h: Use new path to gnulib.
2045         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2046         (GNULIB_H): Remove.
2047         (INCGNU): Look in new gnulib location.
2048         (HFILES_NO_SRCDIR): Remove gnulib files.
2049         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2050         (generated_files): Remove GNULIB_H.
2051         ($(LIBGNU), all-lib): Remove targets.
2052         (distclean): Don't mention GNULIB_BUILDDIR.
2053         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2054
2055 2019-06-14  Tom Tromey  <tromey@adacore.com>
2056
2057         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2058         Warn if symbol file does not provide any symbols.
2059
2060 2019-06-14  Tom Tromey  <tromey@adacore.com>
2061
2062         * source.c (find_and_open_source): Respect basenames_may_differ.
2063
2064 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2065
2066         * annotate.c (annotate_breakpoints_invalid): Make use of
2067         scoped_restore_terminal_state.
2068         (annotate_frames_invalid): Likewise.
2069
2070 2019-06-14  Tom Tromey  <tromey@adacore.com>
2071
2072         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2073         allow assignment to an internalvar.
2074
2075 2019-06-14  Tom Tromey  <tromey@adacore.com>
2076
2077         * ada-lex.l: Allow "_" in attribute names.
2078
2079 2019-06-14  Tom Tromey  <tromey@adacore.com>
2080
2081         PR gdb/24653:
2082         * regcache.c (registers_changed): Don't call alloca.
2083         * top.c (execute_command): Don't call alloca.
2084
2085 2019-06-13  Pedro Alves  <palves@redhat.com>
2086
2087         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2088         'expression'.  When parsing an expression, error out if there's
2089         junk after "unlimited".
2090         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2091         (do_set_command): Adjust calls to is_unlimited_literal.
2092
2093 2019-06-13  Pedro Alves  <palves@redhat.com>
2094
2095         * compile/compile.c (make_compile_options_def_group): Add braces
2096         around array_view initializer.
2097         * thread.c (make_thread_apply_all_options_def_group)
2098         (make_thread_apply_all_options_def_group): Likewise.
2099
2100 2019-06-13  Pedro Alves  <palves@redhat.com>
2101
2102         * NEWS (New commands): Mention "maint test-options
2103         require-delimiter", "maint test-options unknown-is-error", "maint
2104         test-options unknown-is-operand" and "maint show
2105         test-options-completion-result".
2106         (New command options, command completion): New section.
2107         (Completion improvements): New section.
2108         Mention that you can abbreviate "unlimited".
2109
2110 2019-06-13  Pedro Alves  <palves@redhat.com>
2111
2112         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2113         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2114         * unittests/cli-utils-selftests.c (test_parse_flags)
2115         (test_parse_flags_qcs): Delete.
2116         (test_cli_utils): Don't call deleted functions.
2117
2118 2019-06-13  Pedro Alves  <palves@redhat.com>
2119
2120         * thread.c: Include "cli/cli-option.h".
2121         (tp_array_compar_ascending): Global.
2122         (tp_array_compar): Delete function.
2123         (tp_array_compar_ascending, tp_array_compar_descending): New
2124         functions.
2125         (ascending_option_def, qcs_flag_option_def)
2126         (thr_qcs_flags_option_defs)
2127         (make_thread_apply_all_options_def_group)
2128         (make_thread_apply_options_def_group): New.
2129         (thread_apply_all_command): Use gdb::option::process_options.
2130         (thread_apply_command_completer)
2131         (thread_apply_all_command_completer): New.
2132         (thread_apply_command): Use gdb::option::process_options.
2133         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2134         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2135         to generate help text of "thread apply".  Adjust "taas"'s help.
2136         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2137         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2138
2139 2019-06-13  Pedro Alves  <palves@redhat.com>
2140
2141         * thread.c (thread_apply_command): Check for invalid TID with
2142         isdigit instead of !isalpha.
2143
2144 2019-06-13  Pedro Alves  <palves@redhat.com>
2145
2146         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2147         (validate_flags_qcs): New.
2148         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2149         (validate_flags_qcs): Declare.
2150         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2151         (make_frame_apply_options_def_group): New.
2152         (frame_apply_command_count): Process options with
2153         gdb::option::process_options.
2154         (frame_apply_completer): New.
2155         (frame_apply_level_completer, frame_apply_all_completer)
2156         (frame_apply_completer): New.
2157         (_initialize_stack): Update help of "frame apply", "frame apply
2158         level", "frame apply all" and "faas" to mention supported options
2159         and install command completers.
2160         * stack.h (frame_apply_all_completer): Declare.
2161         * thread.c: Include "stack.h".
2162         (tfaas_command): Add "--".
2163         (_initialize_thread): Update help "tfaas" to mention supported
2164         options and install command completer.
2165
2166 2019-06-13  Pedro Alves  <palves@redhat.com>
2167
2168         * completer.c (complete_nested_command_line): New.
2169         (gdb_completion_word_break_characters_throw): Add assertion.
2170         * completer.h (complete_nested_command_line): Declare.
2171
2172 2019-06-13  Pedro Alves  <palves@redhat.com>
2173
2174         * stack.c (parse_backtrace_qualifiers): New.
2175         (backtrace_command): Use it.
2176         (backtrace_command_completer): Complete on qualifiers.
2177
2178 2019-06-13  Pedro Alves  <palves@redhat.com>
2179
2180         * frame.c: Include "cli/cli-option.h.
2181         (user_set_backtrace_options): New.
2182         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2183         Delete.
2184         (get_prev_frame): Adjust.
2185         (boolean_option_def, uinteger_option_def)
2186         (set_backtrace_option_defs): New.
2187         (_initialize_frame): Adjust and use
2188         gdb::option::add_setshow_cmds_for_options to install "set
2189         backtrace past-main" and "set backtrace past-entry".
2190         * frame.h: Include "cli/cli-option.h".
2191         (struct frame_print_options): Forward declare.
2192         (print_frame_arguments_all, print_frame_arguments_scalars)
2193         (print_frame_arguments_none): Declare.
2194         (print_entry_values): Delete declaration.
2195         (struct frame_print_options, user_frame_print_options): New.
2196         (struct set_backtrace_options): New.
2197         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2198         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2199         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2200         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2201         (list_args_or_locals): Add frame_print_options parameter.
2202         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2203         * python/py-framefilter.c (enumerate_args): Pass down
2204         USER_FRAME_PRINT_OPTIONS.
2205         * stack.c: Include "cli/cli-option.h".
2206         (print_frame_arguments_all, print_frame_arguments_scalars)
2207         (print_frame_arguments_none): Declare.
2208         (print_raw_frame_arguments, print_entry_values): Delete.
2209         (user_frame_print_options): New.
2210         (boolean_option_def, enum_option_def, frame_print_option_defs):
2211         New.
2212         (struct backtrace_cmd_options): New.
2213         (bt_flag_option_def): New.
2214         (backtrace_command_option_defs): New.
2215         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2216         (print_frame_arg, read_frame_arg, print_frame_args)
2217         (print_frame_info, print_frame): Add frame_print_options parameter
2218         and use it.
2219         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2220         (backtrace_command_1): Add frame_print_options and
2221         backtrace_cmd_options parameters and use them.
2222         (make_backtrace_options_def_group): New.
2223         (backtrace_command): Process command options with
2224         gdb::option::process_options.
2225         (backtrace_command_completer): New.
2226         (_initialize_stack): Extend "backtrace"'s help to mention
2227         supported options.  Install completer for "backtrace".
2228         Install some settings commands with add_setshow_cmds_for_options.
2229
2230 2019-06-13  Pedro Alves  <palves@redhat.com>
2231
2232         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2233         and that "set/show print raw frame-arguments" are now deprecated.
2234
2235         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2236         command.
2237         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2238         * stack.c (_initialize_stack): Install "set/show print
2239         raw-frame-arguments", and deprecate "set/show print raw
2240         frame-arguments".
2241         * valprint.c (_initialize_valprint): Deprecate "set/show print
2242         raw".
2243
2244 2019-06-13  Pedro Alves  <palves@redhat.com>
2245
2246         * compile/compile.c (struct compile_options): New.
2247         (compile_flag_option_def, compile_command_option_defs)
2248         (make_compile_options_def_group): New.
2249         (compile_file_command): Handle options with
2250         gdb::option::process_options.
2251         (compile_file_command_completer): New function.
2252         (compile_code_command): Handle options with
2253         gdb::option::process_options.
2254         (compile_code_command_completer): New function.
2255         (_initialize_compiler): Install completers for "compile code" and
2256         "compile file".  Mention available options in "compile code" and
2257         "compile code"'s help.
2258         * completer.c (advance_to_completion_word): New, factored out from
2259         ...
2260         (advance_to_expression_complete_word_point): ... this.
2261         (advance_to_filename_complete_word_point): New.
2262         * completer.h (advance_to_filename_complete_word_point): New
2263         declaration.
2264
2265 2019-06-13  Pedro Alves  <palves@redhat.com>
2266
2267         * compile/compile.c: Include "cli/cli-option.h".
2268         (compile_print_value): Scope data pointer is now a
2269         value_print_options pointer; adjust.
2270         (compile_print_command): Process options.  Scope data pointer is
2271         now a value_print_options pointer; adjust.
2272         (_initialize_compile): Update "compile print"'s help to include
2273         supported options.  Install a completer for "compile print".
2274         * cp-valprint.c (show_vtblprint, show_objectprint)
2275         (show_static_field_print): Delete.
2276         (_initialize_cp_valprint): Don't install "set print
2277         static-members", "set print vtbl", "set print object" here.
2278         * printcmd.c: Include "cli/cli-option.h" and
2279         "common/gdb_optional.h".
2280         (print_command_parse_format): Rework to fill in a
2281         value_print_options instead of a format_data.
2282         (print_value): Change parameter type from format_data pointer to
2283         value_print_options reference.  Adjust.
2284         (print_command_1): Process options.  Adjust to pass down a
2285         value_print_options.
2286         (print_command_completer): New.
2287         (_initialize_printcmd): Install print_command_completer as
2288         handle_brkchars completer for the "print" command.  Update
2289         "print"'s help to include supported options.
2290         * valprint.c: Include "cli/cli-option.h".
2291         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2292         here from cp-valprint.c.
2293         (boolean_option_def, uinteger_option_def)
2294         (value_print_option_defs, make_value_print_options_def_group):
2295         New.  Use gdb::option::add_setshow_cmds_for_options to install
2296         "set print elements", "set print null-stop", "set print repeats",
2297         "set print pretty", "set print union", "set print array", "set
2298         print address", "set print symbol", "set print array-indexes".
2299         * valprint.h: Include <string> and "cli/cli-option.h".
2300         (make_value_print_options_def_group): Declare.
2301         (print_value): Change parameter type from format_data pointer to
2302         value_print_options reference.
2303         (print_command_completer): Declare.
2304
2305 2019-06-13  Pedro Alves  <palves@redhat.com>
2306
2307         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2308         (COMMON_SFILES): Add maint-test-settings.c.
2309         * cli/cli-decode.c (boolean_enums): New global, factored out from
2310         ...
2311         (add_setshow_boolean_cmd): ... here.
2312         * cli/cli-decode.h (boolean_enums): Declare.
2313         * cli/cli-option.c: New file.
2314         * cli/cli-option.h: New file.
2315         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2316         factored out from ...
2317         (parse_cli_boolean_value(const char *)): ... this.
2318         (is_unlimited_literal): Change parameter type to pointer to
2319         pointer.  Adjust and advance ARG pointer.
2320         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2321         (parse_cli_var_enum): New, factored out from ...
2322         (do_set_command): ... this.  Adjust.
2323         * cli/cli-setshow.h (parse_cli_boolean_value)
2324         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2325         (parse_cli_var_enum): Declare.
2326         * cli/cli-utils.c: Include "cli/cli-option.h".
2327         (get_ulongest): New.
2328         * cli/cli-utils.h (get_ulongest): Declare.
2329         (check_for_argument): New overloads.
2330         * maint-test-options.c: New file.
2331
2332 2019-06-13  Pedro Alves  <palves@redhat.com>
2333
2334         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2335         parse a range if "-" is at the end of the string.
2336
2337 2019-06-13  Pedro Alves  <palves@redhat.com>
2338
2339         * cli/cli-setshow.c (parse_auto_binary_operation)
2340         (parse_cli_boolean_value): Don't allow "o".
2341
2342 2019-06-13  Pedro Alves  <palves@redhat.com>
2343
2344         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2345         * NEWS: Mention maint test-settings KIND.
2346         * maint-test-settings.c: New file.
2347
2348 2019-06-13  Pedro Alves  <palves@redhat.com>
2349
2350         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2351         completer.
2352         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2353         "set" completers.
2354
2355 2019-06-13  Pedro Alves  <palves@redhat.com>
2356
2357         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2358         after item.
2359
2360 2019-06-13  Pedro Alves  <palves@redhat.com>
2361
2362         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2363
2364 2019-06-13  Pedro Alves <palves@redhat.com>
2365
2366         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2367         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2368         call.
2369         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2370         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2371         calls.
2372         (check_for_argument): Skip spaces after argument.
2373
2374 2019-06-13  Pedro Alves  <palves@redhat.com>
2375
2376         * thread.c (thread_apply_command): Adjust TID parsing.
2377         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2378         detected before end of string.
2379         (tid_is_in_list): Error out if LIST is invalid.
2380
2381 2019-06-13  Pedro Alves  <palves@redhat.com>
2382
2383         * completer.c (complete_line_internal_1): Rewind completion word
2384         point.
2385         (completion_tracker::advance_custom_word_point_by): Change
2386         parameter type to int.
2387         * completer.h (completion_tracker::advance_custom_word_point_by):
2388         Likewise.
2389
2390 2019-06-13  Pedro Alves  <palves@redhat.com>
2391
2392         * completer.c (advance_to_completion_word): Handle delimiters.
2393
2394 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2395
2396         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2397
2398 2019-06-11  Tom Tromey  <tom@tromey.com>
2399
2400         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2401         (xmalloc_failed): Move to alloc.c.
2402         * alloc.c: New file.
2403         * Makefile.in (COMMON_SFILES): Add alloc.c.
2404
2405 2019-06-11  Tom Tromey  <tom@tromey.com>
2406
2407         * nat/linux-waitpid.c: Don't include server.h.
2408         (linux_debug): Remove.
2409         (my_waitpid): Update.
2410
2411 2019-06-11  Tom Tromey  <tromey@adacore.com>
2412
2413         * infcall.c (_initialize_infcall): Remove trailing newline from
2414         help.
2415         * user-regs.c (_initialize_user_regs): Remove trailing newline
2416         from help.
2417         * typeprint.c (_initialize_typeprint): Remove trailing newline
2418         from help.
2419         * reverse.c (_initialize_reverse): Remove trailing newlines from
2420         help.
2421         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2422         from help.
2423         * language.c (add_set_language_command): Remove trailing newline
2424         from help.
2425         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2426         help.
2427         * disasm.c (_initialize_disasm): Remove trailing newline from
2428         help.
2429         * top.c (init_main): Remove trailing newline from help.
2430         * interps.c (_initialize_interpreter): Remove trailing newline
2431         from help.
2432         * btrace.c (_initialize_btrace): Remove trailing newlines from
2433         help.
2434         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2435         from help.
2436         * python/python.c (_initialize_python): Remove trailing newline
2437         from help.
2438         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2439         help.
2440         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2441         from help.  Reformat some text.
2442         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2443         from help.
2444         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2445         newline from help.
2446
2447 2019-06-11  Tom Tromey  <tromey@adacore.com>
2448
2449         * darwin-nat.c (darwin_decode_exception_message)
2450         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2451
2452 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2453
2454         * valops.c (value_slice): Check for not allocated or not
2455         associated values.
2456
2457 2019-06-10  Tom de Vries  <tdevries@suse.de>
2458
2459         PR gdb/24618
2460         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2461         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2462         invalid.
2463
2464 2019-06-10  Tom de Vries  <tdevries@suse.de>
2465
2466         PR gdb/24611
2467         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2468         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2469
2470 2019-06-10  Tom de Vries  <tdevries@suse.de>
2471
2472         PR symtab/24545
2473         * symtab.c (struct demangled_name_entry): Add language field.
2474         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2475         static minimal symbol".  Set and use language field.
2476
2477 2019-06-10  Tom Tromey  <tromey@adacore.com>
2478
2479         * ada-lang.c (_initialize_ada_language): Update help text.
2480
2481 2019-06-10  Tom Tromey  <tromey@adacore.com>
2482
2483         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2484         with a newline.
2485         * guile/guile.c (handle_boot_error): Don't end warning with a
2486         newline.
2487         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2488         warning with a newline.
2489         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2490         newline.
2491         (s12z_frame_cache): Likewise.
2492         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2493         a newline.
2494         * solib-svr4.c (disable_probes_interface): Don't end warning with
2495         a newline.
2496         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2497         newline.
2498         * python/python.c (do_finish_initialization): Don't end warning
2499         with a newline.
2500
2501 2019-06-10  Tom Tromey  <tom@tromey.com>
2502
2503         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2504         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2505         gdbpy_enter.
2506
2507 2019-06-10  Tom Tromey  <tromey@adacore.com>
2508
2509         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2510         data.
2511         (elf_new_init): Don't call stabsread_new_init.
2512         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2513         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2514         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2515
2516 2019-06-10  Tom de Vries  <tdevries@suse.de>
2517
2518         PR symtab/16264
2519         PR symtab/24517
2520         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2521
2522 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2523
2524         * source.c (find_and_open_source): Also rewrite relative file
2525         names.
2526
2527 2019-04-26  Amos Bird  <amosbird@gmail.com>
2528
2529         * annotate.c (annotate_thread_exited): Add "thread-exited"
2530         annotation.
2531
2532 2019-06-06  Tom Tromey  <tromey@adacore.com>
2533
2534         * maint.h (class scoped_command_stats): Use
2535         DISABLE_COPY_AND_ASSIGN.
2536         <print_time>: New method.
2537         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2538         print_time.
2539         (scoped_command_stats::print_time): New method.
2540
2541 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2542
2543         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2544         instructions of lengths 6 or 8 bytes.
2545
2546 2019-06-04  Pedro Alves  <palves@redhat.com>
2547
2548         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2549
2550         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2551         * breakpoint.c (condition_completer): Likewise.
2552         * cli/cli-dump.c (scan_expression): Likewise.
2553         * common/filestuff.c (mkdir_recursive): Likewise.
2554         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2555         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2556         (gdb_abspath): Likewise.
2557         * compile/compile-cplus-types.c
2558         (compile_cplus_instance::decl_name): Likewise.
2559         * completer.c (complete_explicit_location):
2560         (signal_completer, reg_or_group_completer_1): Likewise.
2561         * cp-support.c (cp_remove_params_if_any): Likewise.
2562         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2563         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2564         * infcmd.c (strip_bg_char): Likewise.
2565         * linespec.c (copy_token_string): Likewise.
2566         * mi/mi-main.c (output_cores): Likewise.
2567         * psymtab.c (psymtab_search_name):
2568         * symfile.c (test_set_ext_lang_command): Likewise.
2569         * target.c (target_fileio_read_stralloc): Likewise.
2570         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2571         * value.c (complete_internalvar): Likewise.
2572
2573 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2574
2575         Add objfile property to gdb.Type.
2576         * NEWS: Mention Python API addition.
2577         * python/py-type.c (typy_get_objfile): New method.
2578
2579 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2580
2581         * NEWS: Mention the new set|show style [title|highlight].
2582         Mention changes to "show style", "help" and "apropos".
2583
2584 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2585
2586         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2587         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2588         instead of print_help_for_command.
2589         (print_doc_of_command): New function.
2590         (help_list): Add 'apropos -v word' suggestion.
2591         (print_help_for_command): Style the command name using title style.
2592         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2593         (_initialize_cli_cmds): Describe -v in apropos_command help.
2594
2595 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2596
2597         * cli/cli-style.h (cli_style_option): Add name in constructor,
2598         add m_name class member, add constructor with intensity,
2599         add name class function.
2600         (cli_style_option::add_setshow_commands): Remove name argument.
2601         (highlight_style, title_style): New styles.
2602         * cli/cli-style.c (do_show): New function that shows a style
2603         characteristic styling the style name with itself.
2604         (set_style_name): New function.
2605         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2606         Update all callers according to the changes in cli/cli-style.h.
2607         * utils.h (fputs_highlighted): New function.
2608         * utils.c (fputs_highlighted): Likewise.
2609
2610 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2611
2612         * NEWS: Mention new pipe command and new convenience variables.
2613
2614 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2615
2616         * cli/cli-cmds.c (pipe_command): New function.
2617         (_initialize_cli_cmds): Call add_com for pipe_command.
2618         Define | as an alias for pipe.
2619         (exit_status_set_internal_vars): New function.
2620         (shell_escape): Call exit_status_set_internal_vars.
2621         cli/cli-decode.c (find_command_name_length): Recognize | as
2622         a single character command.
2623
2624 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2625
2626         * gdbcmd.h (execute_command_to_ui_file): New declaration.
2627         top.c (execute_command_to_ui_file): New function, mostly a copy
2628         of execute_command_to_string.
2629         (execute_command_to_string): Implement by calling
2630         execute_command_to_ui_file.
2631
2632 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2633
2634         * top.h (saved_command_line): Remove declaration.
2635         * top.c (previous_saved_command_line, previous_repeat_arguments):
2636         New variables.
2637         (saved_command_line): Make static, define together with other
2638         'repeat variables'.
2639         (dont_repeat): Clear repeat_arguments.
2640         (repeat_previous, get_saved_command_line, save_command_line):
2641         New functions.
2642         (gdb_init): Initialize saved_command_line
2643         and previous_saved_command_line.
2644         * main.c (captured_main_1): Remove saved_command_line initialization.
2645         * event-top.c (handle_line_of_input): Update to use
2646         the new 'repeat' related functions instead of direct access to
2647         saved_command_line.
2648         * command.h (repeat_previous, get_saved_command_line,
2649         save_command_line): New declarations.
2650         (dont_repeat): Add comment.
2651
2652 2019-05-30  Tom Tromey  <tromey@adacore.com>
2653
2654         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
2655         Fix comment.
2656         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
2657
2658 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
2659
2660         PR cli/24587
2661         * completer.c (complete): Initialize variable word.
2662
2663 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
2664
2665         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2666         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
2667         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
2668         'body' is NULL to the outter 'if', protecting the '!is_define'
2669         situation as well.
2670
2671 2019-05-29  Tom Tromey  <tromey@adacore.com>
2672
2673         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
2674         (dwarf_unknown): New function.
2675         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
2676         (dwarf_type_encoding_name): Use dwarf_unknown.
2677
2678 2019-05-29  Tom Tromey  <tromey@adacore.com>
2679
2680         PR c++/20020:
2681         * cp-valprint.c (cp_print_value_fields): Call
2682         cp_print_static_field inside "try".
2683
2684 2019-05-29  Tom Tromey  <tromey@adacore.com>
2685
2686         * inflow.c (struct terminal_info): Add default operator=.
2687         * configure: Rebuild.
2688         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
2689         -Wdeprecated-copy-dtor, -Wredundant-move.
2690
2691 2019-05-29  Tom Tromey  <tromey@adacore.com>
2692
2693         * NEWS: Add entry.
2694         * infcmd.c (print_return_value_1): Handle finish_print
2695         option.
2696         (show_print_finish): New function.
2697         (_initialize_infcmd): Add "set/show print finish" commands.
2698         * valprint.c (user_print_options): Initialize new member.
2699         * valprint.h (struct value_print_options) <finish_print>: New
2700         member.
2701
2702 2019-05-28  Tom Tromey  <tromey@adacore.com>
2703
2704         * ada-lang.c (ada_remove_Xbn_suffix)
2705         (find_old_style_renaming_symbol)
2706         (parse_old_style_renaming): Remove.
2707         (ada_find_renaming_symbol): Don't call
2708         find_old_style_renaming_symbol.
2709         (ada_is_renaming_symbol): Rename from
2710         ada_find_renaming_symbol.  Remove "block" parameter.  Return
2711         bool.  Now static.
2712         (ada_read_var_value): Update and simplify.
2713         * ada-exp.y (write_var_or_type): Remove old code.
2714
2715 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
2716
2717         * event-top.c: Remove include comment.
2718         * inflow.c (class scoped_ignore_sigttou): Move from here...
2719         * inflow.h (class scoped_ignore_sigttou): ...to here.
2720         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
2721         * top.c:  Remove include comment.
2722
2723 2019-05-27  Tom Tromey  <tom@tromey.com>
2724
2725         * NEWS: Fix typo.
2726
2727 2019-05-22  Tom Tromey  <tromey@adacore.com>
2728
2729         * target.c (target_follow_exec): Constify parameter.
2730         * target-delegates.c: Rebuild.
2731         * remote.c (remote_target::follow_exec): Constify parameter.
2732         * infrun.c (follow_exec): Constify parameter.
2733         * target.h (struct target_ops) <follow_exec>: Constify parameter.
2734         (target_follow_exec): Likewise.
2735
2736 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2737
2738         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
2739         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
2740
2741 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2742
2743         * NEWS: Add debugredirect and testsuite sections.
2744
2745 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
2746
2747         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
2748         target descriptions using exclusively floating point register name
2749         aliases.
2750
2751 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2752
2753         PR gdb/18644:
2754         * f-lang.c (build_fortran_types): Handle the case where
2755         gdbarch_floatformat_for_type returns a nullptr.
2756
2757 2019-05-21  Tom de Vries  <tdevries@suse.de>
2758
2759         PR cli/24587
2760         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
2761
2762 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2763
2764         PR gdb/18644:
2765         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
2766         16-byte floats.
2767         * i386-tdep.c (i386_floatformat_for_type): Use
2768         floatformats_ia64_quad for the 16-byte floating point component
2769         within a fortran 32-byte complex number.
2770
2771 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2772
2773         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
2774         delete default constructor.
2775         (find_partial_die): Update to return const struct.
2776         (partial_die_parent_scope): Move variable declaration into scope
2777         of its use and change its type to auto.
2778         (guess_partial_die_structure_name): Likewise.
2779         (partial_die_info::fixup): Likewise.
2780
2781 2019-05-17  Tom Tromey  <tromey@adacore.com>
2782
2783         * source.c (find_and_open_source): Remove cast.
2784
2785 2019-05-17  Tom Tromey  <tromey@adacore.com>
2786
2787         * annotate.c (annotate_source): Make "filename" const.
2788         * annotate.h (annotate_source): Use const.
2789
2790 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2791
2792         * disasm.c (set_disassembler_options): Send errors to stderr.
2793
2794 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2795
2796         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
2797         (cli_interp_base::set_logging): Check debug_redirect.
2798         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
2799         * cli/cli-logging.c (debug_redirect): Add static variable.
2800         (pop_output_files): Add default param.
2801         (handle_redirections): Print debug setting.
2802         (show_logging_command): Likewise.
2803         (_initialize_cli_logging): Add debugredirect command.
2804         * interps.c (current_interp_set_logging): Add debug_redirect
2805         parameter.
2806         * interps.h (set_logging): Add debug_redirect parameter.
2807         (current_interp_set_logging): Likewise.
2808         * mi/mi-common.h: Likewise.
2809         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
2810
2811 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2812             Tom Tromey  <tromey@adacore.com>
2813
2814         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
2815         directly.
2816         * cli/cli-interp.h (make_logging_output): Remove declaration.
2817         * cli/cli-logging.c (make_logging_output): Remove function.
2818         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
2819         directly.
2820         * ui-file.c (tee_file::tee_file): Remove bools.
2821         (tee_file::~tee_file): Remove deletes.
2822         * ui-file.h (tee_file): Remove bools.
2823
2824 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
2825
2826         * mi/mi-cmds.h (mi_cmd_complete): New function.
2827         * mi/mi-main.c (mi_cmd_complete): Likewise.
2828         * mi/mi-cmds.c: Define new MI command -complete.
2829         * NEWS: Mention new -complete command.
2830
2831 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
2832
2833         * completer.h (complete): New function.
2834         * completer.c (complete): Likewise.
2835         * cli/cli-cmds.c: (complete_command): Update to use new complete()
2836         function defined in completer.h.
2837
2838 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
2839
2840         * MAINTAINERS (Write After Approval): Add myself.
2841
2842 2019-05-17  Tom de Vries  <tdevries@suse.de>
2843
2844         PR gdb/24094
2845         * dwarf2read.c (struct cu_partial_die_info): New struct.
2846         (find_partial_die): Return cu_partial_die_info.
2847         (partial_die_parent_scope, guess_partial_die_structure_name)
2848         (partial_die_info::fixup): Handle new return type of find_partial_die.
2849
2850 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2851
2852         * stap-probe.c (stap_parse_register_operand): Make "regname" an
2853         "std::string", simplifying the algorithm.
2854
2855 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2856
2857         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2858         (stap_static_probe_ops::get_probes): Likewise.
2859
2860 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2861
2862         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2863         '-')" and "else if".
2864         (stap_parse_single_operand): Join checks for
2865         "gdbarch_stap_parse_special_token_p" and
2866         "gdbarch_stap_parse_special_token" in the same "if" statement.
2867         Invert check when verifying for operation on register
2868         displacement.
2869
2870 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2871
2872         * stap-probe.c (stap_get_opcode): Update comment.
2873         (stap_get_expected_argument_type): Likewise.
2874         (handle_stap_probe): Likewise.
2875
2876 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2877
2878         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2879         return type to 'bool'.  Adjust comment.  Use 'bool' when
2880         appropriate.
2881         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2882         * stap-probe.c (stap_parse_argument_1): Likewise.
2883         (stap_is_operator): Likewise.
2884         (stap_is_generic_prefix): Likewise.
2885         (stap_is_register_prefix): Likewise.
2886         (stap_is_register_indirection_prefix): Likewise.
2887         (stap_is_integer_prefix): Likewise.
2888         (stap_generic_check_suffix): Likewise.
2889         (stap_check_integer_suffix): Likewise.
2890         (stap_check_register_suffix): Likewise.
2891         (stap_check_register_indirection_suffix): Likewise.
2892         (stap_parse_register_operand): Likewise.
2893         (stap_parse_single_operand): Likewise.
2894         (stap_parse_argument_1): Likewise.
2895         (stap_probe::get_argument_count): Likewise.
2896         (stap_is_operator): Likewise.
2897
2898 2019-05-16  Tom Tromey  <tromey@adacore.com>
2899
2900         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2901         keyword to foreach.
2902
2903 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
2904
2905         * linux-thread-db.c (try_thread_db_load_1): Change return type
2906         to bool.
2907         (try_thread_db_load): Likewise.
2908         (try_thread_db_load_from_pdir_1): Likewise.
2909         (try_thread_db_load_from_pdir): Likewise.
2910         (try_thread_db_load_from_sdir): Likewise.
2911         (try_thread_db_load_from_dir): Likewise.
2912         (thread_db_load_search): Likewise.
2913         (has_libpthread): Likewise.
2914         (thread_db_load): Likewise.
2915
2916 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
2917
2918         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2919         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2920         NULL, and complain/return if that's the case.
2921
2922 2019-05-15  John Darrington <john@darrington.wattle.id.au>
2923
2924         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2925         (advance, posn, abstract_read_memory): New functions.
2926         [struct mem_read_abstraction]: New struct.
2927         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
2928
2929 2019-05-14  Tom Tromey  <tromey@adacore.com>
2930
2931         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
2932         value is not lval_memory.
2933
2934 2019-05-14  Tom Tromey  <tromey@adacore.com>
2935
2936         * solib.c (info_sharedlibrary_command): Style the file name.
2937
2938 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
2939
2940         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
2941         (aarch64_vnv_type): Likewise.
2942         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
2943         * common/tdesc.c: Likewise.
2944         * common/tdesc.h (enum tdesc_type_kind): Likewise.
2945         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
2946         * features/aarch64-fpu.xml: Add ieee half view.
2947         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
2948         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
2949         * gdbtypes.h (struct builtin_type): Likewise.
2950         (struct objfile_type): Likewise.
2951
2952 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
2953
2954         * language.c (language_sniff_from_mangled_name): Fix "langauge"
2955         typo.
2956         * location.h (string_to_event_location): Likewise.
2957
2958 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
2959
2960         GDB 8.3 released.
2961
2962 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2963
2964         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
2965         New variable declaration.
2966         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
2967         New variable.
2968         (print_one_breakpoint): Use ui_out::test_flags and new global
2969         variable to compute use_fixed_output.
2970         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
2971         Remove.
2972         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
2973         (mi_multi_location_breakpoint_output_fixed): Remove.
2974         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
2975         new variable.
2976         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
2977         fix_multi_location_breakpoint_output flag if version >= 3.
2978         * ui-out.h (enum ui_out_flag)
2979         <fix_multi_location_breakpoint_output>: New enumerator.
2980
2981 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2982
2983         * contrib/cc-with-tweaks.sh: Validate dwz's work.
2984
2985 2019-05-10  Tom Tromey  <tromey@adacore.com>
2986
2987         * ada-lang.c (catch_ada_completer): New function.
2988         (_initialize_ada_language): Use it.
2989
2990 2019-05-10  Tom Tromey  <tromey@adacore.com>
2991
2992         * thread.c (print_thread_info): Make "requested_threads" const.
2993         * gdbthread.h (print_thread_info): Make "requested_threads"
2994         const.
2995         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
2996         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
2997
2998 2019-05-08  Tom Tromey  <tom@tromey.com>
2999
3000         * gdbtypes.c (objfile_type_data): Change type.
3001         (objfile_type, _initialize_gdbtypes): Update.
3002
3003 2019-05-08  Tom Tromey  <tom@tromey.com>
3004
3005         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3006         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3007         (_initialize_dwarf2_frame): Update.
3008
3009 2019-05-08  Tom Tromey  <tom@tromey.com>
3010
3011         * objc-lang.c (objc_objfile_data): Change type.
3012         (find_methods): Update.
3013         (_initialize_objc_lang): Remove.
3014
3015 2019-05-08  Tom Tromey  <tom@tromey.com>
3016
3017         * stabsread.c (rs6000_builtin_type_data): Change type.
3018         (rs6000_builtin_type, _initialize_stabsread): Update.
3019
3020 2019-05-08  Tom Tromey  <tom@tromey.com>
3021
3022         * mips-tdep.c (mips_pdr_data): Remove.
3023         (_initialize_mips_tdep): Update.
3024
3025 2019-05-08  Tom Tromey  <tom@tromey.com>
3026
3027         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3028         (hppa_init_objfile_priv_data, read_unwind_info)
3029         (find_unwind_entry, _initialize_hppa_tdep): Update.
3030
3031 2019-05-08  Tom Tromey  <tom@tromey.com>
3032
3033         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3034         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3035         on obstack.
3036         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3037
3038 2019-05-08  Tom Tromey  <tom@tromey.com>
3039
3040         * mdebugread.c (basic_type_data): Change type.
3041         (basic_type, _initialize_mdebugread): Update.
3042
3043 2019-05-08  Tom Tromey  <tom@tromey.com>
3044
3045         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3046
3047 2019-05-08  Tom Tromey  <tom@tromey.com>
3048
3049         * nto-tdep.c (nto_inferior_data_reg): Change type.
3050         (nto_inferior_data): Update.
3051         (nto_inferior_data_cleanup, nto_new_inferior_data)
3052         (_initialize_nto_tdep): Remove.
3053         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3054
3055 2019-05-08  Tom Tromey  <tom@tromey.com>
3056
3057         * ada-lang.c (struct ada_inferior_data): Add initializers.
3058         (ada_inferior_data): Change type.
3059         (ada_inferior_data_cleanup): Remove.
3060         (get_ada_inferior_data, ada_inferior_exit)
3061         (struct ada_pspace_data): Add initializers, destructor.
3062         (ada_pspace_data_handle): Change type.
3063         (get_ada_pspace_data): Update.
3064         (ada_pspace_data_cleanup): Remove.
3065
3066 2019-05-08  Tom Tromey  <tom@tromey.com>
3067
3068         * coffread.c (struct coff_symfile_info): Add initializers.
3069         (coff_objfile_data_key): Move lower.  Change type.
3070         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3071         Update.
3072         (coff_free_info): Remove.
3073
3074 2019-05-08  Tom Tromey  <tom@tromey.com>
3075
3076         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3077         (fbsd_pspace_data_handle): Move lower.  Change type.
3078         (get_fbsd_pspace_data): Update.
3079         (fbsd_pspace_data_cleanup): Remove.
3080         (_initialize_fbsd_tdep): Update.
3081
3082 2019-05-08  Tom Tromey  <tom@tromey.com>
3083
3084         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3085         (get_ada_tasks_pspace_data): Update.
3086         (ada_tasks_pspace_data_cleanup): Remove.
3087         (_initialize_tasks): Update.
3088         (ada_tasks_inferior_data_handle): Change type.
3089         (get_ada_tasks_inferior_data): Update.
3090         (ada_tasks_inferior_data_cleanup): Remove.
3091         (struct ada_tasks_pspace_data): Add initializers.
3092
3093 2019-05-08  Tom Tromey  <tom@tromey.com>
3094
3095         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3096         * symfile-debug.c (debug_sym_get_probes): Change type.
3097         * stap-probe.c (handle_stap_probe):
3098         (stap_static_probe_ops::get_probes): Change type.
3099         * probe.h (class static_probe_ops) <get_probes>: Change type.
3100         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3101         (parse_probes_in_pspace): Update.
3102         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3103         Update.
3104         (any_static_probe_ops::get_probes): Change type.
3105         * elfread.c (elfread_data): New typedef.
3106         (probe_key): Change type.
3107         (elf_get_probes): Likewise.  Update.
3108         (probe_key_free): Remove.
3109         (_initialize_elfread): Update.
3110         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3111         Change type.
3112         (dtrace_process_dof_probe, dtrace_process_dof)
3113         (dtrace_static_probe_ops::get_probe): Change type.
3114
3115 2019-05-08  Tom Tromey  <tom@tromey.com>
3116
3117         * xcoffread.c (struct xcoff_symfile_info): Rename from
3118         coff_symfile_info.  Add initializers.
3119         (xcoff_objfile_data_key): Move lower.  Change type.
3120         (XCOFF_DATA): Rewrite.
3121         (xcoff_free_info): Remove.
3122         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3123         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3124         (xcoff_initial_scan): Update.
3125
3126 2019-05-08  Tom Tromey  <tom@tromey.com>
3127
3128         * solib-svr4.c (struct svr4_info): Add initializers and
3129         destructor.
3130         <probes_table>: Now an htab_up.
3131         (solib_svr4_pspace_data): Change type.
3132         (free_probes_table): Simplify.
3133         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3134         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3135         (probes_table_remove_objfile_probes, register_solib_event_probe)
3136         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3137         (_initialize_svr4_solib): Update.
3138
3139 2019-05-08  Tom Tromey  <tom@tromey.com>
3140
3141         * remote.c (remote_pspace_data): Change type.
3142         (remote_pspace_data_cleanup): Remove.
3143         (get_remote_exec_file, set_pspace_remote_exec_file)
3144         (_initialize_remote): Update.
3145
3146 2019-05-08  Tom Tromey  <tom@tromey.com>
3147
3148         * breakpoint.c (breakpoint_objfile_key): Change type.
3149         (get_breakpoint_objfile_data): Update.
3150         (free_breakpoint_objfile_data): Remove.
3151         (_initialize_breakpoint): Update.
3152
3153 2019-05-08  Tom Tromey  <tom@tromey.com>
3154
3155         * linux-tdep.c (struct linux_info): Add initializers.
3156         (linux_inferior_data): Move.  Change type.
3157         (invalidate_linux_cache_inf): Update.
3158         (linux_inferior_data_cleanup): Remove.
3159         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3160
3161 2019-05-08  Tom Tromey  <tom@tromey.com>
3162
3163         * auxv.c (auxv_inferior_data): Move.  Change type.
3164         (auxv_inferior_data_cleanup): Remove.
3165         (invalidate_auxv_cache_inf): Rewrite.
3166         (get_auxv_inferior_data, _initialize_auxv): Update.
3167
3168 2019-05-08  Tom Tromey  <tom@tromey.com>
3169
3170         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3171         (symfile_debug_objfile_data_key): Change type.
3172         (symfile_debug_installed, debug_qf_has_symbols)
3173         (debug_qf_find_last_source_symtab)
3174         (debug_qf_forget_cached_source_info)
3175         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3176         (debug_qf_print_stats, debug_qf_dump)
3177         (debug_qf_expand_symtabs_for_function)
3178         (debug_qf_expand_all_symtabs)
3179         (debug_qf_expand_symtabs_with_fullname)
3180         (debug_qf_map_matching_symbols)
3181         (debug_qf_expand_symtabs_matching)
3182         (debug_qf_find_pc_sect_compunit_symtab)
3183         (debug_qf_map_symbol_filenames)
3184         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3185         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3186         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3187         (debug_sym_read_linetable, debug_sym_relocate): Update.
3188         (symfile_debug_free_objfile): Remove.
3189         (install_symfile_debug_logging, _initialize_symfile_debug):
3190         Update.
3191
3192 2019-05-08  Tom Tromey  <tom@tromey.com>
3193
3194         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3195         allocate_on_obstack.
3196         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3197         (get_dwarf2_per_objfile): Update.
3198         (set_dwarf2_per_objfile): Remove.
3199         (dwarf2_has_info, dwarf2_get_section_info): Update.
3200         (dwarf2_free_objfile): Remove.
3201         (_initialize_dwarf2_read): Update.
3202
3203 2019-05-08  Tom Tromey  <tom@tromey.com>
3204
3205         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3206         initializers.
3207         <unsupported_script_warning_printed,
3208         script_not_found_warning_printed>: Now bool.
3209         (auto_load_pspace_data): Change type.
3210         (~auto_load_pspace_info): Rename from
3211         auto_load_pspace_data_cleanup.
3212         (get_auto_load_pspace_data, init_loaded_scripts_info)
3213         (clear_section_scripts, maybe_print_unsupported_script_warning)
3214         (maybe_print_script_not_found_warning, _initialize_auto_load):
3215         Update.
3216
3217 2019-05-08  Tom Tromey  <tom@tromey.com>
3218
3219         * objfiles.c (objfile_pspace_info): Add destructor and
3220         initializers.
3221         (objfiles_pspace_data): Change type.
3222         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3223         (get_objfile_pspace_data): Update.
3224         (objfiles_bfd_data): Change type.
3225         (get_objfile_bfd_data): Update.
3226         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3227
3228 2019-05-08  Tom Tromey  <tom@tromey.com>
3229
3230         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3231         Change type.
3232         (get_catch_syscall_inferior_data): Update.
3233         (catch_syscall_inferior_data_cleanup): Remove.
3234         (_initialize_break_catch_syscall): Update.
3235
3236 2019-05-08  Tom Tromey  <tom@tromey.com>
3237
3238         * inflow.c (struct terminal_info): Add destructor and
3239         initializers.
3240         (inflow_inferior_data): Change type.
3241         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3242         (get_inflow_inferior_data, inflow_inferior_exit)
3243         (swap_terminal_info, _initialize_inflow): Update.
3244
3245 2019-05-08  Tom Tromey  <tom@tromey.com>
3246
3247         * target-dcache.c (target_dcache_cleanup): Remove.
3248         (target_dcache_aspace_key): Change type.
3249         (target_dcache_init_p, target_dcache_invalidate)
3250         (target_dcache_get, target_dcache_get_or_init)
3251         (_initialize_target_dcache): Update.
3252         * dcache.h (struct dcache_deleter): New.
3253
3254 2019-05-08  Tom Tromey  <tom@tromey.com>
3255
3256         * symtab.c (struct symbol_cache): Add destructor and
3257         initializers.
3258         (symbol_cache_key): Move.  Change type.
3259         (make_symbol_cache, free_symbol_cache): Remove.
3260         (get_symbol_cache): Update.
3261         (symbol_cache_cleanup): Remove.
3262         (ALL_PSPACES, symbol_cache_flush)
3263         (maintenance_print_symbol_cache)
3264         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3265         Update.
3266
3267 2019-05-08  Tom Tromey  <tom@tromey.com>
3268
3269         * symtab.c (struct main_info): Add destructor and initializers.
3270         (main_progspace_key): Move.  Change type.
3271         (get_main_info): Update.
3272         (main_info_cleanup): Remove.
3273         (_initialize_symtab): Update.
3274
3275 2019-05-08  Tom Tromey  <tom@tromey.com>
3276
3277         * registry.h (DECLARE_REGISTRY): Define the _key class.
3278
3279 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3280
3281         * NEWS: Merge two 'New commands' sections.
3282
3283 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3284
3285         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3286         parameter and use Ada language definition instead.
3287         (ada_val_print_ptr): Remove unused language parameter.
3288         (ada_val_print_num): Remove language parameter and use Ada language
3289         definition instead.
3290         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3291         parameter.
3292         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3293         parameter and use Ada language definition instead.
3294         (ada_val_print_1): Update all ada_val_print_xxx calls.
3295         Remove language parameter.
3296         (ada_val_print): Update ada_val_print_1 call.
3297
3298 2019-05-08  Tom Tromey  <tromey@adacore.com>
3299
3300         * remote.c (remote_hw_watchpoint_limit)
3301         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3302         Now static.
3303
3304 2019-05-08  Tom Tromey  <tromey@adacore.com>
3305
3306         * maint.c (_initialize_maint_cmds): Move initialization code to
3307         remote.c.
3308         (watchdog, show_watchdog): Move to remote.c.
3309         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3310         "watchdog" static.
3311         (_initialize_remote): Move initialization code from maint.c.
3312         * defs.h (watchdog): Don't declare.
3313
3314 2019-05-08  Tom Tromey  <tromey@adacore.com>
3315
3316         * tui/tui-interp.c: Include main.h.
3317         * interps.c: Include main.h.
3318         * main.h (interpreter_p): Declare.
3319         * defs.h (interpreter_p): Don't declare.
3320
3321 2019-05-08  Tom Tromey  <tromey@adacore.com>
3322
3323         * dwarf2loc.c: Include dwarf2read.h.
3324         * defs.h (read_unsigned_leb128): Don't declare.
3325         * dwarf2read.h (read_unsigned_leb128): Declare.
3326
3327 2019-05-08  Tom Tromey  <tromey@adacore.com>
3328
3329         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3330         method.
3331
3332 2019-05-08  Tom Tromey  <tromey@adacore.com>
3333
3334         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3335         when no wrap column is set.
3336
3337 2019-05-08  Tom Tromey  <tromey@adacore.com>
3338
3339         * c-lang.c (c_get_string): Handle non-C-style arrays.
3340
3341 2019-05-08  Tom Tromey  <tromey@adacore.com>
3342
3343         * typeprint.c (print_offset_data::update): Print the bit offset,
3344         not the number of bits remaining.
3345
3346 2019-05-08  Tom Tromey  <tromey@adacore.com>
3347
3348         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3349         padding at end of comment.
3350
3351 2019-05-08  Tom Tromey  <tromey@adacore.com>
3352
3353         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3354         Compare main types.
3355
3356 2019-05-06  Tom Tromey  <tom@tromey.com>
3357
3358         * common/scoped_mmap.c: Include common-defs.h.
3359         * common/scoped_mmap.h: Don't include config.h.
3360
3361 2019-05-04  Tom Tromey  <tom@tromey.com>
3362
3363         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3364         (struct aarch64_call_info): Add initializers.
3365         <si>: Now a std::vector.
3366         (pass_on_stack, aarch64_push_dummy_call): Update.
3367
3368 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3369             Tom Tromey  <tom@tromey.com>
3370
3371         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3372         (ppc_threads): Now a std::vector.  Now static.
3373         (hwdebug_find_thread_points_by_tid)
3374         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3375         Update.
3376
3377 2019-05-04  Tom Tromey  <tom@tromey.com>
3378
3379         * arc-tdep.c (arc_tdesc_init): Return bool.
3380
3381 2019-05-04  Tom Tromey  <tom@tromey.com>
3382
3383         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3384         Use gdb_assert_not_reached.
3385
3386 2019-05-04  Tom Tromey  <tom@tromey.com>
3387
3388         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3389         "false".
3390
3391 2019-05-04  Tom Tromey  <tom@tromey.com>
3392
3393         * arc-tdep.c (arc_tdesc_init): Use bool.
3394
3395 2019-05-04  Tom Tromey  <tom@tromey.com>
3396
3397         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3398
3399 2019-05-04  Tom Tromey  <tom@tromey.com>
3400
3401         * cli/cli-cmds.c (valid_command_p): Return bool.
3402
3403 2019-05-04  Tom Tromey  <tom@tromey.com>
3404
3405         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3406         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3407
3408 2019-05-04  Raul Tambre  <raul@tambre.ee>
3409
3410         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3411         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3412         operator for comparison.
3413
3414 2019-05-04  Tom Tromey  <tom@tromey.com>
3415
3416         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3417         (lookup_partial_symbol, print_partial_symbols)
3418         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3419         (psymbol_compare): Update.
3420         (add_psymbol_to_bcache): Clear the entire psymbol.
3421         (maintenance_check_psymtabs): Update.
3422         * psympriv.h (struct partial_symbol): Don't derive from
3423         general_symbol_info.
3424         <obj_section, unrelocated_address, address,
3425         set_unrelocated_address>: Update.
3426         <ginfo>: New member.
3427         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3428         (debug_names::write_psymbols): Update.
3429
3430 2019-05-04  Tom de Vries  <tdevries@suse.de>
3431
3432         * contrib/cc-with-tweaks.sh: Support -n arg.
3433
3434 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3435
3436         * corelow.c (core_target::detach): Ensure frame cache and
3437         register caches are cleared.
3438         inferior.c (exit_inferior_1): Likewise.
3439
3440 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3441             Tom Tromey  <tom@tromey.com>
3442
3443         * dictionary.c (collate_pending_symbols_by_language): Remove
3444         "struct" from foreach.
3445         * symtab.c (lookup_global_symbol_from_objfile)
3446         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3447         foreach.
3448         * ser-tcp.c (net_open): Remove "struct" from foreach.
3449         * objfiles.c (objfile_relocate, objfile_rebase)
3450         (objfile_has_symbols): Remove "struct" from foreach.
3451         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3452         from foreach.
3453         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3454         foreach.
3455         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3456         "struct" from foreach.
3457         * ada-lang.c (create_excep_cond_exprs)
3458         (ada_exception_catchpoint_cond_string): Remove "struct" from
3459         foreach.
3460
3461 2019-05-03  Tom Tromey  <tromey@adacore.com>
3462
3463         * ada-exp.y (convert_char_literal): Check suffix of each
3464         enumerator.
3465
3466 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3467
3468         PR ada/21406:
3469         * ada-exp.y (yywrap): Don't define.
3470         * ada-lex.l (%option): Add noyywrap
3471         (yywrap): Remove.
3472
3473 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3474
3475         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3476         _WIN32_WINNT to the XP level, unless already defined to a higher
3477         level.
3478
3479         * unittests/parse-connection-spec-selftests.c:
3480         * ser-tcp.c:
3481         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3482         override.
3483
3484         * symfile.c (find_separate_debug_file): Remove colon from the
3485         drive spec of DOS/Windows file names of the target, so that the
3486         file name produced from DEBUGDIR and the target's directory will
3487         be valid on DOS/Windows systems.
3488
3489 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3490
3491         * rust-lang.c (val_print_struct): Handle printing structures
3492         containing strings.
3493
3494 2019-05-02  Tom Tromey  <tromey@adacore.com>
3495
3496         * valarith.c (_initialize_valarith): Remove.
3497
3498 2019-05-01  Tom Tromey  <tromey@adacore.com>
3499
3500         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3501         bitfields.
3502
3503 2019-05-01  Tom Tromey  <tromey@adacore.com>
3504
3505         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3506         for big-endian copies.
3507
3508 2019-04-30  Ali Tamur  <tamur@google.com>
3509         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3510         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3511         (read_3_bytes): New function.
3512
3513 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3514
3515         * windows-nat.c (main_thread_id): Delete.
3516         (handle_output_debug_string): Replace main_thread_id by
3517         current_event.dwThreadId.
3518         (fake_create_process): Likewise.
3519         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3520         Do not set main_thread_id.
3521         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3522         current_event.dwThreadId.
3523         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3524
3525 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3526
3527         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3528         Use current_event.dwThreadId instead of main_thread_id.
3529
3530 2019-04-30  Tom Tromey  <tromey@adacore.com>
3531
3532         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3533         (create_excep_cond_exprs): Iterate over program spaces.
3534         (ada_exception_catchpoint_cond_string): Examine all minimal
3535         symbols for exception types.
3536
3537 2019-04-30  Tom Tromey  <tromey@adacore.com>
3538
3539         PR c++/24470:
3540         * dwarf2read.c (process_structure_scope): Handle case where type
3541         has template parameters but no symbol was created.
3542
3543 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3544             Chris January  <chris.january@arm.com>
3545
3546         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3547         qualifier.
3548         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3549
3550 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3551
3552         * f-typeprint.c (f_print_type): Update rules for printing
3553         whitespace.
3554         (f_type_print_varspec_suffix): Likewise.
3555
3556 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3557             Chris January  <chris.january@arm.com>
3558
3559         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3560         function arguments.
3561
3562 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3563
3564         * f-lang.c (build_fortran_types): Change name of void type to
3565         lower case.
3566         * f-typeprint.c (f_type_print_base): Print the name of the void
3567         type, rather than a fixed string.
3568         * f-valprint.c (f_decorations): Use lower case void string.
3569
3570 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3571             Chris January  <chris.january@arm.com>
3572
3573         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3574         types for Fortran.
3575
3576 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3577             Chris January  <chris.january@arm.com>
3578             David Lecomber  <david.lecomber@arm.com>
3579
3580         * f-exp.y (BINOP_INTRINSIC): New token.
3581         (exp): New parser rule handling BINOP_INTRINSIC.
3582         (f77_keywords): Add new builtin procedures.
3583         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3584         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3585         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3586         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3587         (print_unop_subexp_f): New function.
3588         (print_binop_subexp_f): New function.
3589         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3590         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3591         (dump_subexp_body_f): Likewise.
3592         (operator_check_f): Likewise.
3593         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3594         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3595
3596 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3597
3598         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3599         UNOP_KIND.
3600         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3601         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3602         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3603         (operator_length_f): New fuction.
3604         (print_subexp_f): New function.
3605         (op_name_f): New function.
3606         (dump_subexp_body_f): New function.
3607         (operator_check_f): New function.
3608         (exp_descriptor_f): Replace standard expression handling functions
3609         with new functions.
3610         * gdb/fortran-operator.def: New file.
3611         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3612         * gdb/std-operator.def: Remove UNOP_KIND.
3613
3614 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3615
3616         * std-operator.def: Remove unbalanced, stray double quote
3617         character.
3618
3619 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3620             Chris January  <chris.january@arm.com>
3621             Daniel Everett  <daniel.everett@arm.com>
3622             Nick Forrington  <nick.forrington@arm.com>
3623             Richard Bunt  <richard.bunt@arm.com>
3624
3625         * cp-valprint.c (cp_print_value_fields): Allow an additional level
3626         of depth when printing anonymous structs or unions.
3627         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3628         Don't print either the top-level value, or the children if the
3629         max-depth is exceeded.
3630         (ppscm_print_children): When printing the key of a map, allow one
3631         extra level of depth.
3632         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3633         print either the top-level value, or the children if the max-depth
3634         is exceeded.
3635         (print_children): When printing the key of a map, allow one extra
3636         level of depth.
3637         * python/py-value.c (valpy_format_string): Add max_depth keyword.
3638         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
3639         (user_print_options): Initialise max_depth field.
3640         (val_print_scalar_or_string_type_p): New function.
3641         (val_print): Check to see if the max depth has been reached.
3642         (val_print_check_max_depth): Define new function.
3643         (show_print_max_depth): New function.
3644         (_initialize_valprint): Add 'print max-depth' option.
3645         * valprint.h (struct value_print_options) <max_depth>: New field.
3646         (val_print_check_max_depth): Declare new function.
3647         * NEWS: Document new feature.
3648
3649 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3650
3651         * ada-lang.c (ada_language_defn): Initialise new field.
3652         * c-lang.c (c_is_string_type_p): New function.
3653         (c_language_defn): Initialise new field.
3654         (cplus_language_defn): Initialise new field.
3655         (asm_language_defn): Initialise new field.
3656         (minimal_language_defn): Initialise new field.
3657         * c-lang.h (c_is_string_type_p): Declare new function.
3658         * d-lang.c (d_language_defn): Initialise new field.
3659         * f-lang.c (f_is_string_type_p): New function.
3660         (f_language_defn): Initialise new field.
3661         * go-lang.c (go_is_string_type_p): New function.
3662         (go_language_defn): Initialise new field.
3663         * language.c (default_is_string_type_p): New function.
3664         (unknown_language_defn): Initialise new field.
3665         (auto_language_defn): Initialise new field.
3666         * language.h (struct language_defn) <la_is_string_type_p>: New
3667         member variable.
3668         (default_is_string_type_p): Declare new function.
3669         * m2-lang.c (m2_language_defn): Initialise new field.
3670         * objc-lang.c (objc_language_defn): Initialise new field.
3671         * opencl-lang.c (opencl_language_defn): Initialise new field.
3672         * p-lang.c (pascal_is_string_type_p): New function.
3673         (pascal_language_defn): Initialise new field.
3674         * rust-lang.c (rust_is_string_type_p): New function.
3675         (rust_language_defn): Initialise new field.
3676
3677 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3678
3679         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
3680         New field.
3681         * ada-lang.c (ada_language_defn): Initialise new field.
3682         * c-lang.c (c_language_defn): Likewise.
3683         (cplus_language_defn): Likewise.
3684         (asm_language_defn): Likewise.
3685         (minimal_language_defn): Likewise.
3686         * d-lang.c (d_language_defn): Likewise.
3687         * f-lang.c (f_language_defn): Likewise.
3688         * go-lang.c (go_language_defn): Likewise.
3689         * language.c (unknown_language_defn): Likewise.
3690         (auto_language_defn): Likewise.
3691         * m2-lang.c (m2_language_defn): Likewise.
3692         * objc-lang.c (objc_language_defn): Likewise.
3693         * opencl-lang.c (opencl_language_defn): Likewise.
3694         * p-lang.c (pascal_language_defn): Likewise.
3695         * rust-lang.c (rust_language_defn): Likewise.
3696
3697 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3698
3699         * ada-lang.c (ada_is_character_type): Change return type to bool.
3700         (ada_is_string_type): Likewise.
3701         * ada-lang.h (ada_is_character_type): Update declaration
3702         (ada_is_string_type): Likewise.
3703
3704 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3705
3706         Support style in 'frame|thread apply'
3707
3708         * gdbcmd.h (execute_command_to_string): New term_out parameter.
3709         * record.c (record_start, record_stop): Update callers of
3710         execute_command_to_string with false.
3711         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
3712         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
3713         methods.
3714         (class string_file): New constructor with term_out parameter.
3715         Override methods term_out and can_emit_style_escape.  New member
3716         term_out.
3717         (class stdio_file): Override can_emit_style_escape.
3718         (class tee_file): Override term_out and can_emit_style_escape.
3719         * utils.h (can_emit_style_escape): Remove.
3720         * utils.c (can_emit_style_escape): Likewise.
3721         Update all callers of can_emit_style_escape (SOMESTREAM) to
3722         SOMESTREAM->can_emit_style_escape.
3723         * source-cache.c (source_cache::get_source_lines): Likewise.
3724         * stack.c (frame_apply_command_count): Call execute_command_to_string
3725         passing the term_out characteristic of the current gdb_stdout.
3726         * thread.c (thr_try_catch_cmd): Likewise.
3727         * top.c (execute_command_to_string): pass term_out parameter
3728         to construct the string_file for the command output.
3729         * ui-file.c (term_cli_styling): New function (most code moved
3730         from utils.c can_emit_style_escape).
3731         (string_file::string_file, string_file::can_emit_style_escape,
3732         stdio_file::can_emit_style_escape, tee_file::term_out,
3733         tee_file::can_emit_style_escape): New functions.
3734
3735 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3736
3737         * NEWS: Mention the new set|show may-call-functions.
3738         * infcall.c (may_call_functions_p): New variable.
3739         (show_may_call_functions_p): New function.
3740         (call_function_by_hand_dummy): Throws an error if not
3741         may-call-functions.
3742         (_initialize_infcall): Call add_setshow_boolean_cmd for
3743         may-call-functions.
3744
3745 2019-04-25  Keith Seitz  <keiths@redhat.com>
3746
3747         PR c++/24367
3748         * cp-support.c (inspect_type): Don't attempt substitutions
3749         of symbol with the same name.
3750
3751 2019-04-25  Tom Tromey  <tromey@adacore.com>
3752
3753         PR gdb/24475:
3754         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
3755         static.
3756
3757 2019-04-25  Tom Tromey  <tromey@adacore.com>
3758
3759         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
3760         rvalue reference.
3761         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
3762         (gdb_xml_parser::parse): Use std::move.
3763         * python/python-internal.h (gdbpy_convert_exception): Take a const
3764         reference.
3765         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
3766         std::move.
3767         * python/py-utils.c (gdbpy_convert_exception): Take a const
3768         reference.
3769         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3770         Use std::move.
3771         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3772         Use std::move.
3773         * mi/mi-main.c (mi_print_exception): Take a const reference.
3774         * main.c (handle_command_errors): Take a const reference.
3775         * linespec.c (parse_linespec): Use std::move.
3776         * infcall.c (run_inferior_call): Use std::move.
3777         (call_function_by_hand_dummy): Use std::move.
3778         * exec.c (try_open_exec_file): Use std::move.
3779         * exceptions.h (exception_print, exception_fprintf)
3780         (exception_print_same): Update.
3781         * exceptions.c (print_exception, exception_print)
3782         (exception_fprintf, exception_print_same): Change parameters to
3783         const reference.
3784         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
3785         * common/new-op.c: Use std::move.
3786         * common/common-exceptions.h (struct gdb_exception): Add move
3787         constructor.
3788         (struct gdb_exception_error, struct gdb_exception_quit, struct
3789         gdb_quit_bad_alloc): Change constructor to move constructor.
3790         (throw_exception): Change parameter to rvalue reference.
3791         * common/common-exceptions.c (throw_exception): Take rvalue
3792         reference.
3793         * cli/cli-interp.c (safe_execute_command): Use std::move.
3794         * breakpoint.c (insert_bp_location, location_to_sals): Use
3795         std::move.
3796
3797 2019-04-25  Tom Tromey  <tromey@adacore.com>
3798
3799         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
3800         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
3801         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
3802         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
3803         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
3804         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
3805         guile/scm-value.c: Use unpack.
3806         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
3807         gdbscm_gdb_exception.
3808         (gdbscm_throw_gdb_exception): Likewise.
3809         (struct gdbscm_gdb_exception): New.
3810         (unpack): New function.
3811         (gdbscm_wrap): Use unpack.
3812
3813 2019-04-25  Tom Tromey  <tromey@adacore.com>
3814
3815         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3816         (gdb_rl_callback_handler): Use std::move.
3817         * common/common-exceptions.h (struct gdb_exception): Add move
3818         assignment operator.
3819         (throw_exception_sjlj): Change "exception" to const reference.
3820         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
3821         (throw_exception_sjlj): Change "exception" to const reference.
3822
3823 2019-04-25  Tom Tromey  <tromey@adacore.com>
3824
3825         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
3826         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
3827         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3828         Update.
3829         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3830         Update.
3831         * mi/mi-interp.c (mi_interp::exec): Update.
3832         * linespec.c (parse_linespec): Update.
3833         * infcall.c (run_inferior_call): Update.
3834         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
3835         * guile/scm-symbol.c (gdbscm_lookup_symbol)
3836         (gdbscm_lookup_global_symbol): Update.
3837         * guile/scm-param.c (gdbscm_parameter_value): Update.
3838         * guile/scm-frame.c (gdbscm_frame_read_register)
3839         (gdbscm_frame_read_var): Update.
3840         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
3841         * exec.c (try_open_exec_file): Update.
3842         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3843         (gdb_rl_callback_handler): Update.
3844         * common/common-exceptions.h (exception_none): Don't declare.
3845         * common/common-exceptions.c (exception_none): Don't define.
3846         (struct catcher) <exception>: Update.
3847         * cli/cli-interp.c (safe_execute_command): Update.
3848         * breakpoint.c (insert_bp_location, location_to_sals): Update.
3849
3850 2019-04-25  Ali Tamur  <tamur@google.com>
3851
3852         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
3853         (read_attribute_value): Likewise.
3854         (dwarf2_read_addr_index): Update comment.
3855         (read_str_index): Add DW_FORM_strx.
3856         (dwarf2_string_attr): Likewise.
3857         (dwarf2_const_value_attr): Likewise.
3858         (dump_die_shallow): Likewise.
3859         (dwarf2_fetch_constant_bytes): Likewise.
3860         (skip_form_bytes): Likewise.
3861         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3862
3863 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
3864
3865         PR corefiles/11608
3866         PR corefiles/18187
3867         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3868         OFFSET.  Verify if current mapping contains an ELF header.
3869         (linux_find_memory_regions_full): Adjust call to
3870         dump_mapping_p.
3871
3872 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
3873             Kang Li <kanglictf@gmail.com>
3874
3875         PR gdb/21600
3876
3877         * dwarf2-frame.c (read_initial_length): Be consistent about using
3878         unsigned representation of length.
3879         (decode_frame_entry_1): Likewise.  Check for wraparound of
3880         end pointer as well as buffer overflow.
3881
3882 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3883
3884         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3885         "vq".
3886
3887 2019-04-24  Tom Tromey  <tromey@adacore.com>
3888
3889         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3890
3891 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3892
3893         * s12z-tdep.c (s12z_unwind_pc): Delete.
3894         (s12z_unwind_sp): Delete.
3895         (s12z_gdbarch_init): Don't register deleted functions with
3896         gdbarch.
3897
3898 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3899
3900         * rl78-tdep.c (rl78_unwind_sp): Delete.
3901         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3902
3903 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3904
3905         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3906         (xstormy16_unwind_pc): Delete.
3907         (xstormy16_dummy_id): Delete.
3908         (xstormy16_gdbarch_init): Don't register deleted functions with
3909         gdbarch.
3910
3911 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3912
3913         * vax-tdep.c (vax_unwind_pc): Delete.
3914         (vax_gdbarch_init): Don't register deleted function with gdbarch.
3915
3916 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3917
3918         * v850-tdep.c (v850_unwind_sp): Delete.
3919         (v850_unwind_pc): Delete.
3920         (v850_dummy_id): Delete.
3921         (v850_gdbarch_init): Don't register deleted functions with
3922         gdbarch.
3923
3924 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3925
3926         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
3927         (tilegx_unwind_pc): Delete.
3928         (tilegx_unwind_dummy_id): Delete.
3929         (tilegx_gdbarch_init): Don't register deleted functions with
3930         gdbarch.
3931
3932 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3933
3934         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
3935         (tic6x_dummy_id): Delete.
3936         (tic6x_gdbarch_init): Don't register deleted functions with
3937         gdbarch.
3938
3939 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3940
3941         * sparc-tdep.c (sparc_unwind_pc): Delete.
3942         (sparc32_gdbarch_init): Don't register deleted function with
3943         gdbarch.
3944
3945 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3946
3947         * sh-tdep.c (sh_unwind_sp): Delete.
3948         (sh_unwind_pc): Delete.
3949         (sh_dummy_id): Delete.
3950         (sh_gdbarch_init): Don't register deleted functions with
3951         gdbarch.
3952
3953 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3954
3955         * score-tdep.c (score_unwind_sp): Delete.
3956         (score_unwind_pc): Delete.
3957         (score_dummy_id): Delete.
3958         (score_gdbarch_init): Don't register deleted functions with
3959         gdbarch.
3960
3961 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3962
3963         * rx-tdep.c (rx_unwind_pc): Delete.
3964         (rx_unwind_sp): Delete.
3965         (rx_dummy_id): Delete.
3966         (rx_gdbarch_init): Don't register deleted functions with
3967         gdbarch.  Update comment.
3968
3969 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3970
3971         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
3972         (rs6000_dummy_id): Delete.
3973         (rs6000_gdbarch_init): Don't register deleted functions with
3974         gdbarch.
3975
3976 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3977
3978         * or1k-tdep.c (or1k_dummy_id): Delete.
3979         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
3980
3981 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3982
3983         * nios2-tdep.c (nios2_dummy_id): Delete.
3984         (nios2_unwind_sp): Delete.
3985         (nios2_gdbarch_init): Don't register deleted functions with
3986         gdbarch.
3987
3988 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3989
3990         * nds32-tdep.c (nds32_dummy_id): Delete.
3991         (nds32_unwind_pc): Delete.
3992         (nds32_unwind_sp): Delete.
3993         (nds32_gdbarch_init): Don't register deleted functions with
3994         gdbarch.
3995
3996 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3997
3998         * msp430-tdep.c (msp430_unwind_pc): Delete.
3999         (msp430_unwind_sp): Delete.
4000         (msp430_dummy_id): Delete.
4001         (msp430_gdbarch_init): Don't register deleted functions with
4002         gdbarch.
4003
4004 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4005
4006         * moxie-tdep.c (moxie_unwind_sp): Delete.
4007         (moxie_unwind_pc): Delete.
4008         (moxie_dummy_id): Delete.
4009         (moxie_gdbarch_init): Don't register deleted functions with
4010         gdbarch.
4011
4012 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4013
4014         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4015         (mn10300_unwind_pc): Delete.
4016         (mn10300_unwind_sp): Delete.
4017         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4018         mn10300_unwind_sp.
4019         (mn10300_frame_unwind_init): Don't register deleted functions with
4020         gdbarch.
4021
4022 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4023
4024         * mep-tdep.c (mep_unwind_pc): Delete.
4025         (mep_unwind_sp): Delete.
4026         (mep_dummy_id): Delete.
4027         (mep_gdbarch_init): Don't register deleted functions with
4028         gdbarch.
4029
4030 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4031
4032         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4033         (m68hc11_unwind_sp): Delete.
4034         (m68hc11_gdbarch_init): Don't register deleted functions with
4035         gdbarch.
4036
4037 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4038
4039         * m32r-tdep.c (m32r_unwind_sp): Delete.
4040         (m32r_unwind_pc): Delete.
4041         (m32r_dummy_id): Delete.
4042         (m32r_gdbarch_init): Don't register deleted functions with
4043         gdbarch.
4044
4045 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4046
4047         * m32c-tdep.c (m32c_unwind_pc): Delete.
4048         (m32c_unwind_sp): Delete.
4049         (m32c_dummy_id): Delete.
4050         (m32c_gdbarch_init): Don't register deleted functions with
4051         gdbarch.
4052
4053 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4054
4055         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4056         (lm32_unwind_pc): Delete.
4057         (lm32_dummy_id): Delete.
4058         (lm32_gdbarch_init): Don't register deleted functions with
4059         gdbarch.
4060
4061 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4062
4063         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4064         (iq2000_unwind_pc): Delete.
4065         (iq2000_dummy_id): Delete.
4066         (iq2000_gdbarch_init): Don't register deleted functions with
4067         gdbarch.
4068
4069 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4070
4071         * nds32-tdep.c (nds32_type_align): Delete.
4072         (nds32_push_dummy_call): Use type_align instead.
4073
4074 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4075
4076         * arm-tdep.c (arm_type_align): Only handle vector override case.
4077         (arm_push_dummy_call): Use type_align.
4078         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4079
4080 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4081
4082         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4083         case.
4084         (pass_on_stack): Use type_align.
4085         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4086         function.
4087
4088 2019-04-23  Tom Tromey  <tromey@adacore.com>
4089
4090         * dwarf2read.c (line_header::file_name_at): Remove unused
4091         overload.
4092
4093 2019-04-23  Tom de Vries  <tdevries@suse.de>
4094
4095         PR gdb/24438
4096         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4097         invocation.
4098
4099
4100 2019-03-27  Ali Tamur  <tamur@google.com>
4101
4102         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4103         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4104         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4105         (dwarf_expr_context::get_addr_index): Likewise
4106         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4107         (symbol_needs_eval_context::get_addr_index): Likewise
4108         (disassemble_dwarf_expression): Add DW_OP_addrx
4109         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4110         (read_cutu_die_from_dwo): Update comment
4111         (skip_one_die): Add DW_FORM_addrx
4112         (read_attribute_value): Likewise
4113         (var_decode_location): Add DW_OP_addrx
4114         (dwarf2_const_value_attr): Add DW_FORM_addrx
4115         (dump_die_shallow): Likewise
4116         (dwarf2_fetch_constant_bytes): Likewise
4117         (decode_locdesc): Add DW_OP_addrx
4118         (skip_form_bytes): Add DW_FORM_addrx
4119
4120 2019-04-22  Ali Tamur  <tamur@google.com>
4121
4122         * MAINTAINERS (Write After Approval): Add self.
4123
4124 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4125
4126         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4127         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4128         (open_symbol_file_object): Likewise.
4129         (svr4_default_sos): Add info parameter.
4130         (svr4_read_so_list): Likewise.
4131         (svr4_current_sos_direct): Adjust functions calls to pass down
4132         info.
4133         (svr4_current_sos_1): Add info parameter.
4134         (svr4_current_sos): Call get_svr4_info, pass info down to
4135         svr4_current_sos_1.
4136         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4137         get_svr4_info.
4138         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4139         get_svr4_info.
4140         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4141         to get_svr4_info.
4142         (probes_table_remove_objfile_probes): Likewise.
4143         (register_solib_event_probe): Add info parameter.
4144         (solist_update_incremental): Pass info parameter down to
4145         svr4_read_so_list.
4146         (disable_probes_interface): Add info parameter.
4147         (svr4_handle_solib_event): Pass current_program_space to
4148         get_svr4_info.  Adjust disable_probes_interface cleanup.
4149         (svr4_create_probe_breakpoints): Add info parameter, pass it
4150         down to register_solib_event_probe.
4151         (svr4_create_solib_event_breakpoints): Add info parameter,
4152         pass it down to svr4_create_probe_breakpoints.
4153         (enable_break): Pass info down to
4154         svr4_create_solib_event_breakpoints.
4155         (svr4_solib_create_inferior_hook): Pass current_program_space to
4156         get_svr4_info.
4157         (svr4_clear_solib): Likewise.
4158
4159 2019-04-22  Pedro Alves  <palves@redhat.com>
4160
4161         * solib-svr4.c (svr4_free_objfile_observer): New.
4162         (probe_and_action::objfile): New field.
4163         (probes_table_htab_remove_objfile_probes)
4164         (probes_table_remove_objfile_probes): New functions.
4165         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4166         in the new probe_and_action.  Don't store the probe in 'lookup'.
4167         (svr4_create_probe_breakpoints): Pass objfile to
4168         register_solib_event_probe.
4169         (_initialize_svr4_solib): Register a free_objfile observer.
4170
4171 2019-04-19  Tom Tromey  <tom@tromey.com>
4172
4173         * common/queue.h: Remove.
4174
4175 2019-04-19  Tom Tromey  <tom@tromey.com>
4176
4177         * event-loop.c: Don't include "common/queue.h".
4178
4179 2019-04-19  Tom Tromey  <tom@tromey.com>
4180
4181         * remote.c (remote_target): Use delete.
4182         * remote-notif.h: Include <list>, not "common/queue.h".
4183         (notif_client_p): Remove typedef.
4184         (remote_notif_state): Add constructor, destructor, initializer.
4185         <notif_queue>: Now a std::list.
4186         (remote_notif_state_xfree): Don't declare.
4187         * remote-notif.c (remote_notif_process, handle_notification)
4188         (remote_notif_state_allocate): Update.
4189         (~remote_notif_state): Rename from remote_notif_state_xfree.
4190
4191 2019-04-19  Tom Tromey  <tom@tromey.com>
4192
4193         * symfile.c (reread_symbols): Update.
4194         * objfiles.c (objfile_register_static_link)
4195         (objfile_lookup_static_link): Update
4196         (~objfile) Don't delete static_links.
4197         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4198
4199 2019-04-19  Tom Tromey  <tom@tromey.com>
4200
4201         * type-stack.h (struct type_stack) <insert>: Constify string.
4202         * type-stack.c (type_stack::insert): Constify string.
4203         * gdbtypes.h (lookup_template_type): Update.
4204         (address_space_name_to_int): Update.
4205         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4206         const.
4207         (lookup_template_type): Make name const.
4208         * c-exp.y: Update rules.
4209         (lex_one_token, classify_name, classify_inner_name)
4210         (c_print_token): Update.
4211         * p-exp.y: Update rules.
4212         (yylex): Update.
4213         * f-exp.y: Update rules.
4214         (yylex): Update.
4215         * d-exp.y: Update rules.
4216         (lex_one_token, classify_name, classify_inner_name): Update.
4217         * parse.c (write_dollar_variable, copy_name): Return std::string.
4218         * parser-defs.h (copy_name): Change return type.
4219         * m2-exp.y: Update rules.
4220         (yylex): Update.
4221         * go-exp.y (lex_one_token): Update.
4222         Update rules.
4223         (classify_unsafe_function, classify_packaged_name)
4224         (classify_name, yylex): Update.
4225
4226 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4227
4228         * configure.ac: add --enable-source-highlight switch.
4229         * configure: Regenerate.
4230         * top.c (print_gdb_version): plumb --enable-source-highlight
4231         status to "show configuration".
4232
4233 2019-04-19  Tom Tromey  <tromey@adacore.com>
4234
4235         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4236         Check ADA_TYPE_P.
4237         (empty_record, ada_template_to_fixed_record_type_1)
4238         (template_to_static_fixed_type)
4239         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4240         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4241         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4242         macros.
4243
4244 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4245
4246         PR symtab/24423:
4247         * source.c (print_source_lines_base): Advance "iter" when a
4248         control character is seen.
4249
4250 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4251
4252         * inferior.h (struct infcall_suspend_state_deleter):
4253         Catch exception in destructor to avoid crash.
4254
4255 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4256
4257         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4258         close to the add_com "shell".
4259
4260 2019-04-18  Tom Tromey  <tromey@adacore.com>
4261
4262         * process-stratum-target.h (class process_stratum_target)
4263         <stratum>: Add "final".
4264
4265 2019-04-17  Tom Tromey  <tromey@adacore.com>
4266
4267         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4268         against nullptr before use.
4269
4270 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4271
4272         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4273
4274 2019-04-17  Jim Wilson  <jimw@sifive.com>
4275             Andrew Burgess  <andrew.burgess@embecosm.com>
4276
4277         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4278         code read might fail, assume 4-byte breakpoint in that case.
4279
4280 2019-04-15  Leszek Swirski  <leszeks@google.com>
4281
4282         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4283         rather than a hand-rolled POD check when checking for forced MEMORY
4284         classification.
4285
4286 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4287
4288         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4289         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4290         function.
4291         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4292         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4293         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4294         declaration.
4295
4296 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4297
4298         * aarch64-linux-nat.c
4299         (aarch64_linux_nat_target::thread_architecture): Add override.
4300         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4301         each VQ.
4302
4303 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4304
4305         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4306
4307 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4308
4309         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4310         target types of size 96-bits, add some additional comments, and
4311         check that the builtin type we found was the correct size.
4312
4313 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4314
4315         * utils.c (prompt_for_continue): Don't restore the styling at the
4316         end, as applied_style has the wrong value.  This fixes styling in
4317         long lists of file names that are interrupted by the "Continue?"
4318         prompt.
4319
4320 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4321
4322         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4323         * c-lang.c (c_language_defn): Likewise.
4324         (cplus_language_defn): Likewise.
4325         (asm_language_defn): Likewise.
4326         (minimal_language_defn): Likewise.
4327         * d-lang.c (d_language_defn): Likewise.
4328         * f-lang.c (f_language_defn): Likewise.
4329         * go-lang.c (go_language_defn): Likewise.
4330         * language.c (unknown_language_defn): Likewise.
4331         (auto_language_defn): Likewise.
4332         * language.h (struct language_defn): Remove la_magic field.
4333         (LANG_MAGIC): Delete.
4334         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4335         * objc-lang.c (objc_language_defn): Likewise.
4336         * opencl-lang.c (opencl_language_defn): Likewise.
4337         * p-lang.c (pascal_language_defn): Likewise.
4338         * rust-lang.c (rust_language_defn): Likewise.
4339
4340 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4341
4342         * riscv-tdep.c (riscv_type_align): New function.
4343         (riscv_type_alignment): Delete.
4344         (riscv_arg_location): Use 'type_align'.
4345         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4346
4347 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4348
4349         * gdbtypes.c (type_align): A struct with no non-static fields also
4350         has alignment of 1.
4351
4352 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4353
4354         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4355         component to 0.
4356         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4357         member.
4358         (riscv_struct_info::analyse): New implementation using new
4359         analyse_inner member function.
4360         (riscv_struct_info::field_offset): New member function.
4361         (riscv_struct_info::m_offsets): New member variable.
4362         (riscv_struct_info::analyse_inner): New private member function,
4363         takes the old implementation of riscv_struct_info::analyse but
4364         extended to track field offsets.
4365         (riscv_call_arg_struct): Update the struct folding special cases
4366         to handle cases where empty C++ structs, which are non-zero
4367         length, are found.
4368         (riscv_arg_location): Initialise the length of each location, a
4369         non-zero length now indicates the location is in use.
4370         (riscv_push_dummy_call): Allow for the first location having a
4371         non-zero offset when setting up arguments.
4372         (riscv_return_value): Likewise, but for return values.
4373
4374 2019-04-11  Tom Tromey  <tromey@adacore.com>
4375
4376         * utils.c (internal_vproblem): Make "msg" const.
4377
4378 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4379
4380         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4381         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4382         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4383         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4384
4385 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4386
4387         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4388         function.
4389         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4390         of amd64_collect_native_gregset.
4391         (amd64_linux_nat_target::store_registers): Likewise.
4392
4393 2019-04-10  Tom Tromey  <tom@tromey.com>
4394
4395         * symtab.c (lookup_global_symbol_from_objfile)
4396         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4397         * objfiles.h (class separate_debug_iterator): New.
4398         (class separate_debug_range): New.
4399         (struct objfile) <separate_debug_objfiles>: New method.
4400         (objfile_separate_debug_iterate): Don't declare.
4401         * objfiles.c (separate_debug_iterator::operator++): Rename from
4402         objfile_separate_debug_iterate.
4403         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4404         iterator.
4405         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4406         iterator.
4407
4408 2019-04-10  Tom Tromey  <tom@tromey.com>
4409
4410         * symfile.c (reread_symbols): Remove old comment.
4411         * objfiles.c (free_all_objfiles): Fix a typo.
4412
4413 2019-04-10  Tom Tromey  <tom@tromey.com>
4414
4415         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4416         * minsyms.c (lookup_minimal_symbol): Use foreach.
4417         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4418         (lookup_minimal_symbol_solib_trampoline): Likewise.
4419         * symfile.c (reread_symbols): Use foreach.
4420
4421 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4422             Tom Tromey  <tromey@adacore.com>
4423
4424         PR rust/24414:
4425         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4426         (rust_lex_int_test): Change "value" to be LONGEST.
4427         (rust_lex_tests): Add test for long integer literal.
4428
4429 2019-04-09  Tom Tromey  <tromey@adacore.com>
4430
4431         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4432         to bool.
4433         (extended_remote_target::attach): Update.
4434         (remote_target::remote_notice_new_inferior): Update.
4435         (remote_target::add_current_inferior_and_thread): Update.
4436         * inferior.c (exit_inferior_1): Use "false".
4437         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4438
4439 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4440
4441         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4442         the "start" command.
4443
4444 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4445
4446         * python/py-inferior.c (infpy_thread_from_thread_handle):
4447         Adjust comments to reflect renaming of thread_from_thread_handle
4448         to thread_from_handle.  Adjust keywords.  Fix type error message.
4449         (inferior_object_methods): Add thread_from_handle.  Retain
4450         thread_from_thread_handle, but mark it as deprecated.
4451
4452 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4453
4454         * gdbthread.h (find_thread_by_handle): Revise declaration.
4455         * thread.c (find_thread_by_handle): Likewise.  Adjust
4456         implementation too.
4457         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4458         support for buffer objects as handles.
4459
4460 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4461
4462         * python/py-infthread.c (thpy_thread_handle): New function.
4463         (thread_object_methods): Register thpy_thread_handle.
4464
4465 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4466
4467         * gdbthread.h (thread_to_thread_handle): Declare.
4468         * thread.c (gdbtypes.h): Include.
4469         (thread_to_thread_handle): New function.
4470
4471         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4472         (target_thread_info_to_thread_handle): Declare.
4473         * target.c (target_thread_info_to_thread_handle): New function.
4474         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4475         * target-delegates.c: Regenerate.
4476
4477         * linux-thread-db.c (class thread_db_target): Add method
4478         thread_info_to_thread_handle.
4479         (thread_db_target::thread_info_to_thread_handle): Define.
4480         * remote.c (class remote_target): Add new method
4481         thread_info_to_thread_handle.
4482         (remote_target::thread_info_to_thread_handle): Define.
4483
4484 2019-04-08  Pedro Alves  <palves@redhat.com>
4485
4486         * common/common-exceptions.c (throw_exception): Don't create
4487         named object to throw; throw directly.
4488         (throw_it): Likewise.  Don't initialize gdb_exception::message
4489         here, with new; pass FMT and AP to the ctor instead.
4490         * common/common-exceptions.h: Include <string>.
4491         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4492         const char *, va_list)): New ctor.  Use std::make_shared.
4493         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4494         errors)): Delete.
4495         (gdb_exception_error::gdb_exception_error(enum errors, const char
4496         *, va_list)): New.
4497         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4498         Add assertion.
4499         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4500         errors)): Delete.
4501         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4502         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4503         Add assertion.
4504
4505 2019-04-08  Tom Tromey  <tom@tromey.com>
4506
4507         * valops.c (value_rtti_indirect_type): Replace throw_exception
4508         with throw.
4509         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4510         with throw.
4511         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4512         throw.
4513         * target.c (target_translate_tls_address): Replace throw_exception
4514         with throw.
4515         * stack.c (frame_apply_command_count): Replace throw_exception
4516         with throw.
4517         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4518         throw.
4519         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4520         with throw.
4521         * rs6000-tdep.c (rs6000_frame_cache)
4522         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4523         * remote.c: Replace throw_exception with throw.
4524         * record-full.c (record_full_message, record_full_wait_1)
4525         (record_full_restore): Replace throw_exception with throw.
4526         * record-btrace.c:
4527         (get_thread_current_frame_id, record_btrace_start_replaying)
4528         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4529         (cmd_record_btrace_start): Replace throw_exception with throw.
4530         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4531         throw.
4532         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4533         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4534         * linespec.c:
4535         (find_linespec_symbols): Replace throw_exception with throw.
4536         * infrun.c (displaced_step_prepare, resume): Replace
4537         throw_exception with throw.
4538         * infcmd.c (post_create_inferior): Replace throw_exception with
4539         throw.
4540         * inf-loop.c (inferior_event_handler): Replace throw_exception
4541         with throw.
4542         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4543         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4544         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4545         (get_prev_frame_always, get_frame_pc_if_available)
4546         (get_frame_address_in_block_if_available, get_frame_language):
4547         Replace throw_exception with throw.
4548         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4549         throw_exception with throw.
4550         * eval.c (fetch_subexp_value, evaluate_var_value)
4551         (evaluate_funcall, evaluate_subexp_standard): Replace
4552         throw_exception with throw.
4553         * dwarf2loc.c (call_site_find_chain)
4554         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4555         Replace throw_exception with throw.
4556         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4557         with throw.
4558         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4559         throw.
4560         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4561         * completer.c (complete_line_internal): Replace throw_exception
4562         with throw.
4563         * compile/compile-object-run.c (compile_object_run): Replace
4564         throw_exception with throw.
4565         * cli/cli-script.c (process_next_line): Replace throw_exception
4566         with throw.
4567         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4568         (btrace_enable, btrace_maint_update_pt_packets): Replace
4569         throw_exception with throw.
4570         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4571         throw_exception with throw.
4572         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4573         throw_exception with throw.
4574         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4575         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4576         * aarch64-tdep.c (aarch64_make_prologue_cache)
4577         (aarch64_make_stub_cache): Replace throw_exception with throw.
4578
4579 2019-04-08  Tom Tromey  <tom@tromey.com>
4580
4581         * common/common-exceptions.c (throw_exception): Rename from
4582         throw_exception_cxx.  Remove old copy.  Make argument const.
4583         (throw_it): Create and throw exception objects directly.
4584         * common/common-exceptions.h (throw_exception): Make argument
4585         const.
4586         (struct gdb_exception_error): Add constructor.
4587         (struct gdb_exception_quit): Add constructor.
4588
4589 2019-04-08  Tom Tromey  <tom@tromey.com>
4590
4591         * common/common-exceptions.h (exception_rethrow): Don't declare.
4592         (TRY_SJLJ): Update comment.
4593         (TRY, CATCH, END_CATCH): Remove.
4594         * common/common-exceptions.c (exception_rethrow): Remove.
4595
4596 2019-04-08  Tom Tromey  <tom@tromey.com>
4597
4598         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4599         Remove.
4600         (gdb_exception_error): Rename from
4601         gdb_exception_RETURN_MASK_ERROR.
4602         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4603         (gdb_quit_bad_alloc): Update.
4604         * aarch64-tdep.c: Update.
4605         * ada-lang.c: Update.
4606         * ada-typeprint.c: Update.
4607         * ada-valprint.c: Update.
4608         * amd64-tdep.c: Update.
4609         * arch-utils.c: Update.
4610         * break-catch-throw.c: Update.
4611         * breakpoint.c: Update.
4612         * btrace.c: Update.
4613         * c-varobj.c: Update.
4614         * cli/cli-cmds.c: Update.
4615         * cli/cli-interp.c: Update.
4616         * cli/cli-script.c: Update.
4617         * common/common-exceptions.c: Update.
4618         * common/new-op.c: Update.
4619         * common/selftest.c: Update.
4620         * compile/compile-c-symbols.c: Update.
4621         * compile/compile-cplus-symbols.c: Update.
4622         * compile/compile-object-load.c: Update.
4623         * compile/compile-object-run.c: Update.
4624         * completer.c: Update.
4625         * corelow.c: Update.
4626         * cp-abi.c: Update.
4627         * cp-support.c: Update.
4628         * cp-valprint.c: Update.
4629         * darwin-nat.c: Update.
4630         * disasm-selftests.c: Update.
4631         * dtrace-probe.c: Update.
4632         * dwarf-index-cache.c: Update.
4633         * dwarf-index-write.c: Update.
4634         * dwarf2-frame-tailcall.c: Update.
4635         * dwarf2-frame.c: Update.
4636         * dwarf2loc.c: Update.
4637         * dwarf2read.c: Update.
4638         * eval.c: Update.
4639         * event-loop.c: Update.
4640         * event-top.c: Update.
4641         * exec.c: Update.
4642         * f-valprint.c: Update.
4643         * fbsd-tdep.c: Update.
4644         * frame-unwind.c: Update.
4645         * frame.c: Update.
4646         * gdbtypes.c: Update.
4647         * gnu-v3-abi.c: Update.
4648         * guile/guile-internal.h: Update.
4649         * guile/scm-block.c: Update.
4650         * guile/scm-breakpoint.c: Update.
4651         * guile/scm-cmd.c: Update.
4652         * guile/scm-disasm.c: Update.
4653         * guile/scm-frame.c: Update.
4654         * guile/scm-lazy-string.c: Update.
4655         * guile/scm-math.c: Update.
4656         * guile/scm-param.c: Update.
4657         * guile/scm-ports.c: Update.
4658         * guile/scm-pretty-print.c: Update.
4659         * guile/scm-symbol.c: Update.
4660         * guile/scm-symtab.c: Update.
4661         * guile/scm-type.c: Update.
4662         * guile/scm-value.c: Update.
4663         * i386-linux-tdep.c: Update.
4664         * i386-tdep.c: Update.
4665         * inf-loop.c: Update.
4666         * infcall.c: Update.
4667         * infcmd.c: Update.
4668         * infrun.c: Update.
4669         * jit.c: Update.
4670         * language.c: Update.
4671         * linespec.c: Update.
4672         * linux-fork.c: Update.
4673         * linux-nat.c: Update.
4674         * linux-tdep.c: Update.
4675         * linux-thread-db.c: Update.
4676         * main.c: Update.
4677         * mi/mi-cmd-break.c: Update.
4678         * mi/mi-cmd-stack.c: Update.
4679         * mi/mi-interp.c: Update.
4680         * mi/mi-main.c: Update.
4681         * objc-lang.c: Update.
4682         * p-valprint.c: Update.
4683         * parse.c: Update.
4684         * ppc-linux-tdep.c: Update.
4685         * printcmd.c: Update.
4686         * python/py-arch.c: Update.
4687         * python/py-breakpoint.c: Update.
4688         * python/py-cmd.c: Update.
4689         * python/py-finishbreakpoint.c: Update.
4690         * python/py-frame.c: Update.
4691         * python/py-framefilter.c: Update.
4692         * python/py-gdb-readline.c: Update.
4693         * python/py-inferior.c: Update.
4694         * python/py-infthread.c: Update.
4695         * python/py-lazy-string.c: Update.
4696         * python/py-linetable.c: Update.
4697         * python/py-objfile.c: Update.
4698         * python/py-param.c: Update.
4699         * python/py-prettyprint.c: Update.
4700         * python/py-progspace.c: Update.
4701         * python/py-record-btrace.c: Update.
4702         * python/py-record.c: Update.
4703         * python/py-symbol.c: Update.
4704         * python/py-type.c: Update.
4705         * python/py-unwind.c: Update.
4706         * python/py-utils.c: Update.
4707         * python/py-value.c: Update.
4708         * python/python.c: Update.
4709         * record-btrace.c: Update.
4710         * record-full.c: Update.
4711         * remote-fileio.c: Update.
4712         * remote.c: Update.
4713         * riscv-tdep.c: Update.
4714         * rs6000-aix-tdep.c: Update.
4715         * rs6000-tdep.c: Update.
4716         * rust-exp.y: Update.
4717         * rust-lang.c: Update.
4718         * s390-tdep.c: Update.
4719         * selftest-arch.c: Update.
4720         * solib-dsbt.c: Update.
4721         * solib-frv.c: Update.
4722         * solib-spu.c: Update.
4723         * solib-svr4.c: Update.
4724         * solib.c: Update.
4725         * sparc64-linux-tdep.c: Update.
4726         * stack.c: Update.
4727         * symfile-mem.c: Update.
4728         * symmisc.c: Update.
4729         * target.c: Update.
4730         * thread.c: Update.
4731         * top.c: Update.
4732         * tracefile-tfile.c: Update.
4733         * tui/tui.c: Update.
4734         * typeprint.c: Update.
4735         * unittests/cli-utils-selftests.c: Update.
4736         * unittests/parse-connection-spec-selftests.c: Update.
4737         * valops.c: Update.
4738         * valprint.c: Update.
4739         * value.c: Update.
4740         * varobj.c: Update.
4741         * windows-nat.c: Update.
4742         * x86-linux-nat.c: Update.
4743         * xml-support.c: Update.
4744
4745 2019-04-08  Tom Tromey  <tom@tromey.com>
4746
4747         * xml-support.c: Use C++ exception handling.
4748         * x86-linux-nat.c: Use C++ exception handling.
4749         * windows-nat.c: Use C++ exception handling.
4750         * varobj.c: Use C++ exception handling.
4751         * value.c: Use C++ exception handling.
4752         * valprint.c: Use C++ exception handling.
4753         * valops.c: Use C++ exception handling.
4754         * unittests/parse-connection-spec-selftests.c: Use C++ exception
4755         handling.
4756         * unittests/cli-utils-selftests.c: Use C++ exception handling.
4757         * typeprint.c: Use C++ exception handling.
4758         * tui/tui.c: Use C++ exception handling.
4759         * tracefile-tfile.c: Use C++ exception handling.
4760         * top.c: Use C++ exception handling.
4761         * thread.c: Use C++ exception handling.
4762         * target.c: Use C++ exception handling.
4763         * symmisc.c: Use C++ exception handling.
4764         * symfile-mem.c: Use C++ exception handling.
4765         * stack.c: Use C++ exception handling.
4766         * sparc64-linux-tdep.c: Use C++ exception handling.
4767         * solib.c: Use C++ exception handling.
4768         * solib-svr4.c: Use C++ exception handling.
4769         * solib-spu.c: Use C++ exception handling.
4770         * solib-frv.c: Use C++ exception handling.
4771         * solib-dsbt.c: Use C++ exception handling.
4772         * selftest-arch.c: Use C++ exception handling.
4773         * s390-tdep.c: Use C++ exception handling.
4774         * rust-lang.c: Use C++ exception handling.
4775         * rust-exp.y: Use C++ exception handling.
4776         * rs6000-tdep.c: Use C++ exception handling.
4777         * rs6000-aix-tdep.c: Use C++ exception handling.
4778         * riscv-tdep.c: Use C++ exception handling.
4779         * remote.c: Use C++ exception handling.
4780         * remote-fileio.c: Use C++ exception handling.
4781         * record-full.c: Use C++ exception handling.
4782         * record-btrace.c: Use C++ exception handling.
4783         * python/python.c: Use C++ exception handling.
4784         * python/py-value.c: Use C++ exception handling.
4785         * python/py-utils.c: Use C++ exception handling.
4786         * python/py-unwind.c: Use C++ exception handling.
4787         * python/py-type.c: Use C++ exception handling.
4788         * python/py-symbol.c: Use C++ exception handling.
4789         * python/py-record.c: Use C++ exception handling.
4790         * python/py-record-btrace.c: Use C++ exception handling.
4791         * python/py-progspace.c: Use C++ exception handling.
4792         * python/py-prettyprint.c: Use C++ exception handling.
4793         * python/py-param.c: Use C++ exception handling.
4794         * python/py-objfile.c: Use C++ exception handling.
4795         * python/py-linetable.c: Use C++ exception handling.
4796         * python/py-lazy-string.c: Use C++ exception handling.
4797         * python/py-infthread.c: Use C++ exception handling.
4798         * python/py-inferior.c: Use C++ exception handling.
4799         * python/py-gdb-readline.c: Use C++ exception handling.
4800         * python/py-framefilter.c: Use C++ exception handling.
4801         * python/py-frame.c: Use C++ exception handling.
4802         * python/py-finishbreakpoint.c: Use C++ exception handling.
4803         * python/py-cmd.c: Use C++ exception handling.
4804         * python/py-breakpoint.c: Use C++ exception handling.
4805         * python/py-arch.c: Use C++ exception handling.
4806         * printcmd.c: Use C++ exception handling.
4807         * ppc-linux-tdep.c: Use C++ exception handling.
4808         * parse.c: Use C++ exception handling.
4809         * p-valprint.c: Use C++ exception handling.
4810         * objc-lang.c: Use C++ exception handling.
4811         * mi/mi-main.c: Use C++ exception handling.
4812         * mi/mi-interp.c: Use C++ exception handling.
4813         * mi/mi-cmd-stack.c: Use C++ exception handling.
4814         * mi/mi-cmd-break.c: Use C++ exception handling.
4815         * main.c: Use C++ exception handling.
4816         * linux-thread-db.c: Use C++ exception handling.
4817         * linux-tdep.c: Use C++ exception handling.
4818         * linux-nat.c: Use C++ exception handling.
4819         * linux-fork.c: Use C++ exception handling.
4820         * linespec.c: Use C++ exception handling.
4821         * language.c: Use C++ exception handling.
4822         * jit.c: Use C++ exception handling.
4823         * infrun.c: Use C++ exception handling.
4824         * infcmd.c: Use C++ exception handling.
4825         * infcall.c: Use C++ exception handling.
4826         * inf-loop.c: Use C++ exception handling.
4827         * i386-tdep.c: Use C++ exception handling.
4828         * i386-linux-tdep.c: Use C++ exception handling.
4829         * guile/scm-value.c: Use C++ exception handling.
4830         * guile/scm-type.c: Use C++ exception handling.
4831         * guile/scm-symtab.c: Use C++ exception handling.
4832         * guile/scm-symbol.c: Use C++ exception handling.
4833         * guile/scm-pretty-print.c: Use C++ exception handling.
4834         * guile/scm-ports.c: Use C++ exception handling.
4835         * guile/scm-param.c: Use C++ exception handling.
4836         * guile/scm-math.c: Use C++ exception handling.
4837         * guile/scm-lazy-string.c: Use C++ exception handling.
4838         * guile/scm-frame.c: Use C++ exception handling.
4839         * guile/scm-disasm.c: Use C++ exception handling.
4840         * guile/scm-cmd.c: Use C++ exception handling.
4841         * guile/scm-breakpoint.c: Use C++ exception handling.
4842         * guile/scm-block.c: Use C++ exception handling.
4843         * guile/guile-internal.h: Use C++ exception handling.
4844         * gnu-v3-abi.c: Use C++ exception handling.
4845         * gdbtypes.c: Use C++ exception handling.
4846         * frame.c: Use C++ exception handling.
4847         * frame-unwind.c: Use C++ exception handling.
4848         * fbsd-tdep.c: Use C++ exception handling.
4849         * f-valprint.c: Use C++ exception handling.
4850         * exec.c: Use C++ exception handling.
4851         * event-top.c: Use C++ exception handling.
4852         * event-loop.c: Use C++ exception handling.
4853         * eval.c: Use C++ exception handling.
4854         * dwarf2read.c: Use C++ exception handling.
4855         * dwarf2loc.c: Use C++ exception handling.
4856         * dwarf2-frame.c: Use C++ exception handling.
4857         * dwarf2-frame-tailcall.c: Use C++ exception handling.
4858         * dwarf-index-write.c: Use C++ exception handling.
4859         * dwarf-index-cache.c: Use C++ exception handling.
4860         * dtrace-probe.c: Use C++ exception handling.
4861         * disasm-selftests.c: Use C++ exception handling.
4862         * darwin-nat.c: Use C++ exception handling.
4863         * cp-valprint.c: Use C++ exception handling.
4864         * cp-support.c: Use C++ exception handling.
4865         * cp-abi.c: Use C++ exception handling.
4866         * corelow.c: Use C++ exception handling.
4867         * completer.c: Use C++ exception handling.
4868         * compile/compile-object-run.c: Use C++ exception handling.
4869         * compile/compile-object-load.c: Use C++ exception handling.
4870         * compile/compile-cplus-symbols.c: Use C++ exception handling.
4871         * compile/compile-c-symbols.c: Use C++ exception handling.
4872         * common/selftest.c: Use C++ exception handling.
4873         * common/new-op.c: Use C++ exception handling.
4874         * cli/cli-script.c: Use C++ exception handling.
4875         * cli/cli-interp.c: Use C++ exception handling.
4876         * cli/cli-cmds.c: Use C++ exception handling.
4877         * c-varobj.c: Use C++ exception handling.
4878         * btrace.c: Use C++ exception handling.
4879         * breakpoint.c: Use C++ exception handling.
4880         * break-catch-throw.c: Use C++ exception handling.
4881         * arch-utils.c: Use C++ exception handling.
4882         * amd64-tdep.c: Use C++ exception handling.
4883         * ada-valprint.c: Use C++ exception handling.
4884         * ada-typeprint.c: Use C++ exception handling.
4885         * ada-lang.c: Use C++ exception handling.
4886         * aarch64-tdep.c: Use C++ exception handling.
4887
4888 2019-04-08  Tom Tromey  <tom@tromey.com>
4889
4890         * xml-support.c (gdb_xml_parser::parse): Update.
4891         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4892         * value.c (show_convenience): Update.
4893         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4894         (test_parse_flags_qcs): Update.
4895         * thread.c (thr_try_catch_cmd): Update.
4896         * target.c (target_translate_tls_address): Update.
4897         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4898         (info_frame_command_core, frame_apply_command_count): Update.
4899         * rust-exp.y (rust_lex_exception_test): Update.
4900         * riscv-tdep.c (riscv_print_one_register_info): Update.
4901         * remote.c (remote_target::enable_btrace): Update.
4902         * record-btrace.c (record_btrace_enable_warn): Update.
4903         * python/py-utils.c (gdbpy_convert_exception): Update.
4904         * printcmd.c (do_one_display, print_variable_and_value): Update.
4905         * mi/mi-main.c (mi_print_exception): Update.
4906         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4907         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4908         * linux-nat.c (linux_nat_target::attach): Update.
4909         * linux-fork.c (class scoped_switch_fork_info): Update.
4910         * infrun.c (displaced_step_prepare): Update.
4911         * infcall.c (call_function_by_hand_dummy): Update.
4912         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4913         * gnu-v3-abi.c (print_one_vtable): Update.
4914         * frame.c (get_prev_frame_always): Update.
4915         * f-valprint.c (info_common_command_for_block): Update.
4916         * exec.c (try_open_exec_file): Update.
4917         * exceptions.c (print_exception, exception_print)
4918         (exception_fprintf, exception_print_same): Update.
4919         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4920         * dwarf-index-cache.c (index_cache::store)
4921         (index_cache::lookup_gdb_index): Update.
4922         * darwin-nat.c (maybe_cache_shell): Update.
4923         * cp-valprint.c (cp_print_value_fields): Update.
4924         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4925         (gcc_cplus_symbol_address): Update.
4926         * compile/compile-c-symbols.c (gcc_convert_symbol)
4927         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
4928         * common/selftest.c: Update.
4929         * common/common-exceptions.h (struct gdb_exception) <message>: Now
4930         a std::string.
4931         (exception_try_scope_entry, exception_try_scope_exit): Don't
4932         declare.
4933         (struct exception_try_scope): Remove.
4934         (TRY): Don't use exception_try_scope.
4935         (struct gdb_exception): Add constructor, operator=.
4936         <what>: New method.
4937         (struct gdb_exception_RETURN_MASK_ALL)
4938         (struct gdb_exception_RETURN_MASK_ERROR)
4939         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
4940         (struct gdb_quit_bad_alloc): Update.
4941         * common/common-exceptions.c (exception_none): Change
4942         initializer.
4943         (struct catcher) <state, exception>: Initialize inline.
4944         <prev>: Remove member.
4945         (current_catcher): Remove.
4946         (catchers): New global.
4947         (exceptions_state_mc_init): Simplify.
4948         (catcher_pop): Remove.
4949         (exceptions_state_mc, exceptions_state_mc_catch): Update.
4950         (try_scope_depth, exception_try_scope_entry)
4951         (exception_try_scope_exit): Remove.
4952         (throw_exception_sjlj): Update.
4953         (exception_messages, exception_messages_size): Remove.
4954         (throw_it): Simplify.
4955         (gdb_exception_sliced_copy): Remove.
4956         (throw_exception_cxx): Update.
4957         * cli/cli-script.c (script_from_file): Update.
4958         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
4959         Update.
4960         * ada-valprint.c (ada_val_print): Update.
4961         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
4962         (create_excep_cond_exprs): Update.
4963
4964 2019-04-08  Tom Tromey  <tom@tromey.com>
4965
4966         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
4967         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
4968         (TRY, CATCH, END_CATCH): Remove some definitions.
4969         * common/common-exceptions.c: Don't use GDB_XCPT.
4970         (catcher_list_size): Remove.
4971         (throw_exception, throw_it): Simplify.
4972
4973 2019-04-05  Tom Tromey  <tom@tromey.com>
4974
4975         Revert the header-sorting patch.
4976         * ft32-tdep.c: Revert.
4977         * frv-tdep.c: Revert.
4978         * frv-linux-tdep.c: Revert.
4979         * frame.c: Revert.
4980         * frame-unwind.c: Revert.
4981         * frame-base.c: Revert.
4982         * fork-child.c: Revert.
4983         * findvar.c: Revert.
4984         * findcmd.c: Revert.
4985         * filesystem.c: Revert.
4986         * filename-seen-cache.h: Revert.
4987         * filename-seen-cache.c: Revert.
4988         * fbsd-tdep.c: Revert.
4989         * fbsd-nat.h: Revert.
4990         * fbsd-nat.c: Revert.
4991         * f-valprint.c: Revert.
4992         * f-typeprint.c: Revert.
4993         * f-lang.c: Revert.
4994         * extension.h: Revert.
4995         * extension.c: Revert.
4996         * extension-priv.h: Revert.
4997         * expprint.c: Revert.
4998         * exec.h: Revert.
4999         * exec.c: Revert.
5000         * exceptions.c: Revert.
5001         * event-top.c: Revert.
5002         * event-loop.c: Revert.
5003         * eval.c: Revert.
5004         * elfread.c: Revert.
5005         * dwarf2read.h: Revert.
5006         * dwarf2read.c: Revert.
5007         * dwarf2loc.c: Revert.
5008         * dwarf2expr.h: Revert.
5009         * dwarf2expr.c: Revert.
5010         * dwarf2-frame.c: Revert.
5011         * dwarf2-frame-tailcall.c: Revert.
5012         * dwarf-index-write.h: Revert.
5013         * dwarf-index-write.c: Revert.
5014         * dwarf-index-common.c: Revert.
5015         * dwarf-index-cache.h: Revert.
5016         * dwarf-index-cache.c: Revert.
5017         * dummy-frame.c: Revert.
5018         * dtrace-probe.c: Revert.
5019         * disasm.h: Revert.
5020         * disasm.c: Revert.
5021         * disasm-selftests.c: Revert.
5022         * dictionary.c: Revert.
5023         * dicos-tdep.c: Revert.
5024         * demangle.c: Revert.
5025         * dcache.h: Revert.
5026         * dcache.c: Revert.
5027         * darwin-nat.h: Revert.
5028         * darwin-nat.c: Revert.
5029         * darwin-nat-info.c: Revert.
5030         * d-valprint.c: Revert.
5031         * d-namespace.c: Revert.
5032         * d-lang.c: Revert.
5033         * ctf.c: Revert.
5034         * csky-tdep.c: Revert.
5035         * csky-linux-tdep.c: Revert.
5036         * cris-tdep.c: Revert.
5037         * cris-linux-tdep.c: Revert.
5038         * cp-valprint.c: Revert.
5039         * cp-support.c: Revert.
5040         * cp-namespace.c: Revert.
5041         * cp-abi.c: Revert.
5042         * corelow.c: Revert.
5043         * corefile.c: Revert.
5044         * continuations.c: Revert.
5045         * completer.h: Revert.
5046         * completer.c: Revert.
5047         * complaints.c: Revert.
5048         * coffread.c: Revert.
5049         * coff-pe-read.c: Revert.
5050         * cli-out.h: Revert.
5051         * cli-out.c: Revert.
5052         * charset.c: Revert.
5053         * c-varobj.c: Revert.
5054         * c-valprint.c: Revert.
5055         * c-typeprint.c: Revert.
5056         * c-lang.c: Revert.
5057         * buildsym.c: Revert.
5058         * buildsym-legacy.c: Revert.
5059         * build-id.h: Revert.
5060         * build-id.c: Revert.
5061         * btrace.c: Revert.
5062         * bsd-uthread.c: Revert.
5063         * breakpoint.h: Revert.
5064         * breakpoint.c: Revert.
5065         * break-catch-throw.c: Revert.
5066         * break-catch-syscall.c: Revert.
5067         * break-catch-sig.c: Revert.
5068         * blockframe.c: Revert.
5069         * block.c: Revert.
5070         * bfin-tdep.c: Revert.
5071         * bfin-linux-tdep.c: Revert.
5072         * bfd-target.c: Revert.
5073         * bcache.c: Revert.
5074         * ax-general.c: Revert.
5075         * ax-gdb.h: Revert.
5076         * ax-gdb.c: Revert.
5077         * avr-tdep.c: Revert.
5078         * auxv.c: Revert.
5079         * auto-load.c: Revert.
5080         * arm-wince-tdep.c: Revert.
5081         * arm-tdep.c: Revert.
5082         * arm-symbian-tdep.c: Revert.
5083         * arm-pikeos-tdep.c: Revert.
5084         * arm-obsd-tdep.c: Revert.
5085         * arm-nbsd-tdep.c: Revert.
5086         * arm-nbsd-nat.c: Revert.
5087         * arm-linux-tdep.c: Revert.
5088         * arm-linux-nat.c: Revert.
5089         * arm-fbsd-tdep.c: Revert.
5090         * arm-fbsd-nat.c: Revert.
5091         * arm-bsd-tdep.c: Revert.
5092         * arch-utils.c: Revert.
5093         * arc-tdep.c: Revert.
5094         * arc-newlib-tdep.c: Revert.
5095         * annotate.h: Revert.
5096         * annotate.c: Revert.
5097         * amd64-windows-tdep.c: Revert.
5098         * amd64-windows-nat.c: Revert.
5099         * amd64-tdep.c: Revert.
5100         * amd64-sol2-tdep.c: Revert.
5101         * amd64-obsd-tdep.c: Revert.
5102         * amd64-obsd-nat.c: Revert.
5103         * amd64-nbsd-tdep.c: Revert.
5104         * amd64-nbsd-nat.c: Revert.
5105         * amd64-nat.c: Revert.
5106         * amd64-linux-tdep.c: Revert.
5107         * amd64-linux-nat.c: Revert.
5108         * amd64-fbsd-tdep.c: Revert.
5109         * amd64-fbsd-nat.c: Revert.
5110         * amd64-dicos-tdep.c: Revert.
5111         * amd64-darwin-tdep.c: Revert.
5112         * amd64-bsd-nat.c: Revert.
5113         * alpha-tdep.c: Revert.
5114         * alpha-obsd-tdep.c: Revert.
5115         * alpha-nbsd-tdep.c: Revert.
5116         * alpha-mdebug-tdep.c: Revert.
5117         * alpha-linux-tdep.c: Revert.
5118         * alpha-linux-nat.c: Revert.
5119         * alpha-bsd-tdep.c: Revert.
5120         * alpha-bsd-nat.c: Revert.
5121         * aix-thread.c: Revert.
5122         * agent.c: Revert.
5123         * addrmap.c: Revert.
5124         * ada-varobj.c: Revert.
5125         * ada-valprint.c: Revert.
5126         * ada-typeprint.c: Revert.
5127         * ada-tasks.c: Revert.
5128         * ada-lang.c: Revert.
5129         * aarch64-tdep.c: Revert.
5130         * aarch64-ravenscar-thread.c: Revert.
5131         * aarch64-newlib-tdep.c: Revert.
5132         * aarch64-linux-tdep.c: Revert.
5133         * aarch64-linux-nat.c: Revert.
5134         * aarch64-fbsd-tdep.c: Revert.
5135         * aarch64-fbsd-nat.c: Revert.
5136         * aarch32-linux-nat.c: Revert.
5137
5138 2019-04-05  Tom Tromey  <tom@tromey.com>
5139
5140         * ft32-tdep.c: Sort headers.
5141         * frv-tdep.c: Sort headers.
5142         * frv-linux-tdep.c: Sort headers.
5143         * frame.c: Sort headers.
5144         * frame-unwind.c: Sort headers.
5145         * frame-base.c: Sort headers.
5146         * fork-child.c: Sort headers.
5147         * findvar.c: Sort headers.
5148         * findcmd.c: Sort headers.
5149         * filesystem.c: Sort headers.
5150         * filename-seen-cache.h: Sort headers.
5151         * filename-seen-cache.c: Sort headers.
5152         * fbsd-tdep.c: Sort headers.
5153         * fbsd-nat.h: Sort headers.
5154         * fbsd-nat.c: Sort headers.
5155         * f-valprint.c: Sort headers.
5156         * f-typeprint.c: Sort headers.
5157         * f-lang.c: Sort headers.
5158         * extension.h: Sort headers.
5159         * extension.c: Sort headers.
5160         * extension-priv.h: Sort headers.
5161         * expprint.c: Sort headers.
5162         * exec.h: Sort headers.
5163         * exec.c: Sort headers.
5164         * exceptions.c: Sort headers.
5165         * event-top.c: Sort headers.
5166         * event-loop.c: Sort headers.
5167         * eval.c: Sort headers.
5168         * elfread.c: Sort headers.
5169         * dwarf2read.h: Sort headers.
5170         * dwarf2read.c: Sort headers.
5171         * dwarf2loc.c: Sort headers.
5172         * dwarf2expr.h: Sort headers.
5173         * dwarf2expr.c: Sort headers.
5174         * dwarf2-frame.c: Sort headers.
5175         * dwarf2-frame-tailcall.c: Sort headers.
5176         * dwarf-index-write.h: Sort headers.
5177         * dwarf-index-write.c: Sort headers.
5178         * dwarf-index-common.c: Sort headers.
5179         * dwarf-index-cache.h: Sort headers.
5180         * dwarf-index-cache.c: Sort headers.
5181         * dummy-frame.c: Sort headers.
5182         * dtrace-probe.c: Sort headers.
5183         * disasm.h: Sort headers.
5184         * disasm.c: Sort headers.
5185         * disasm-selftests.c: Sort headers.
5186         * dictionary.c: Sort headers.
5187         * dicos-tdep.c: Sort headers.
5188         * demangle.c: Sort headers.
5189         * dcache.h: Sort headers.
5190         * dcache.c: Sort headers.
5191         * darwin-nat.h: Sort headers.
5192         * darwin-nat.c: Sort headers.
5193         * darwin-nat-info.c: Sort headers.
5194         * d-valprint.c: Sort headers.
5195         * d-namespace.c: Sort headers.
5196         * d-lang.c: Sort headers.
5197         * ctf.c: Sort headers.
5198         * csky-tdep.c: Sort headers.
5199         * csky-linux-tdep.c: Sort headers.
5200         * cris-tdep.c: Sort headers.
5201         * cris-linux-tdep.c: Sort headers.
5202         * cp-valprint.c: Sort headers.
5203         * cp-support.c: Sort headers.
5204         * cp-namespace.c: Sort headers.
5205         * cp-abi.c: Sort headers.
5206         * corelow.c: Sort headers.
5207         * corefile.c: Sort headers.
5208         * continuations.c: Sort headers.
5209         * completer.h: Sort headers.
5210         * completer.c: Sort headers.
5211         * complaints.c: Sort headers.
5212         * coffread.c: Sort headers.
5213         * coff-pe-read.c: Sort headers.
5214         * cli-out.h: Sort headers.
5215         * cli-out.c: Sort headers.
5216         * charset.c: Sort headers.
5217         * c-varobj.c: Sort headers.
5218         * c-valprint.c: Sort headers.
5219         * c-typeprint.c: Sort headers.
5220         * c-lang.c: Sort headers.
5221         * buildsym.c: Sort headers.
5222         * buildsym-legacy.c: Sort headers.
5223         * build-id.h: Sort headers.
5224         * build-id.c: Sort headers.
5225         * btrace.c: Sort headers.
5226         * bsd-uthread.c: Sort headers.
5227         * breakpoint.h: Sort headers.
5228         * breakpoint.c: Sort headers.
5229         * break-catch-throw.c: Sort headers.
5230         * break-catch-syscall.c: Sort headers.
5231         * break-catch-sig.c: Sort headers.
5232         * blockframe.c: Sort headers.
5233         * block.c: Sort headers.
5234         * bfin-tdep.c: Sort headers.
5235         * bfin-linux-tdep.c: Sort headers.
5236         * bfd-target.c: Sort headers.
5237         * bcache.c: Sort headers.
5238         * ax-general.c: Sort headers.
5239         * ax-gdb.h: Sort headers.
5240         * ax-gdb.c: Sort headers.
5241         * avr-tdep.c: Sort headers.
5242         * auxv.c: Sort headers.
5243         * auto-load.c: Sort headers.
5244         * arm-wince-tdep.c: Sort headers.
5245         * arm-tdep.c: Sort headers.
5246         * arm-symbian-tdep.c: Sort headers.
5247         * arm-pikeos-tdep.c: Sort headers.
5248         * arm-obsd-tdep.c: Sort headers.
5249         * arm-nbsd-tdep.c: Sort headers.
5250         * arm-nbsd-nat.c: Sort headers.
5251         * arm-linux-tdep.c: Sort headers.
5252         * arm-linux-nat.c: Sort headers.
5253         * arm-fbsd-tdep.c: Sort headers.
5254         * arm-fbsd-nat.c: Sort headers.
5255         * arm-bsd-tdep.c: Sort headers.
5256         * arch-utils.c: Sort headers.
5257         * arc-tdep.c: Sort headers.
5258         * arc-newlib-tdep.c: Sort headers.
5259         * annotate.h: Sort headers.
5260         * annotate.c: Sort headers.
5261         * amd64-windows-tdep.c: Sort headers.
5262         * amd64-windows-nat.c: Sort headers.
5263         * amd64-tdep.c: Sort headers.
5264         * amd64-sol2-tdep.c: Sort headers.
5265         * amd64-obsd-tdep.c: Sort headers.
5266         * amd64-obsd-nat.c: Sort headers.
5267         * amd64-nbsd-tdep.c: Sort headers.
5268         * amd64-nbsd-nat.c: Sort headers.
5269         * amd64-nat.c: Sort headers.
5270         * amd64-linux-tdep.c: Sort headers.
5271         * amd64-linux-nat.c: Sort headers.
5272         * amd64-fbsd-tdep.c: Sort headers.
5273         * amd64-fbsd-nat.c: Sort headers.
5274         * amd64-dicos-tdep.c: Sort headers.
5275         * amd64-darwin-tdep.c: Sort headers.
5276         * amd64-bsd-nat.c: Sort headers.
5277         * alpha-tdep.c: Sort headers.
5278         * alpha-obsd-tdep.c: Sort headers.
5279         * alpha-nbsd-tdep.c: Sort headers.
5280         * alpha-mdebug-tdep.c: Sort headers.
5281         * alpha-linux-tdep.c: Sort headers.
5282         * alpha-linux-nat.c: Sort headers.
5283         * alpha-bsd-tdep.c: Sort headers.
5284         * alpha-bsd-nat.c: Sort headers.
5285         * aix-thread.c: Sort headers.
5286         * agent.c: Sort headers.
5287         * addrmap.c: Sort headers.
5288         * ada-varobj.c: Sort headers.
5289         * ada-valprint.c: Sort headers.
5290         * ada-typeprint.c: Sort headers.
5291         * ada-tasks.c: Sort headers.
5292         * ada-lang.c: Sort headers.
5293         * aarch64-tdep.c: Sort headers.
5294         * aarch64-ravenscar-thread.c: Sort headers.
5295         * aarch64-newlib-tdep.c: Sort headers.
5296         * aarch64-linux-tdep.c: Sort headers.
5297         * aarch64-linux-nat.c: Sort headers.
5298         * aarch64-fbsd-tdep.c: Sort headers.
5299         * aarch64-fbsd-nat.c: Sort headers.
5300         * aarch32-linux-nat.c: Sort headers.
5301
5302 2019-04-04  Tom Tromey  <tom@tromey.com>
5303
5304         * varobj.c (varobj_create): Update.
5305         * rust-exp.y (struct rust_parser) <update_innermost_block,
5306         lookup_symbol>: New methods.
5307         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5308         Rename.
5309         (rust_parser::rust_lookup_type)
5310         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5311         * printcmd.c (display_command, do_one_display): Update.
5312         * parser-defs.h (struct parser_state) <parser_state>: Add
5313         "tracker" parameter.
5314         (block_tracker): New member.
5315         (class innermost_block_tracker) <innermost_block_tracker>: Add
5316         "types" parameter.
5317         <reset>: Remove method.
5318         (innermost_block): Don't declare.
5319         (null_post_parser): Update.
5320         * parse.c (innermost_block): Remove global.
5321         (write_dollar_variable): Update.
5322         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5323         Remove "tracker_types" parameter.
5324         (parse_expression): Add "tracker" parameter.
5325         (parse_expression_for_completion): Update.
5326         (null_post_parser): Add "tracker" parameter.
5327         * p-exp.y: Update rules.
5328         * m2-exp.y: Update rules.
5329         * language.h (struct language_defn) <la_post_parser>: Add
5330         "tracker" parameter.
5331         * go-exp.y: Update rules.
5332         * f-exp.y: Update rules.
5333         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5334         parameter.
5335         * d-exp.y: Update rules.
5336         * c-exp.y: Update rules.
5337         * breakpoint.c (set_breakpoint_condition): Create an
5338         innermost_block_tracker.
5339         (watch_command_1): Likewise.
5340         * ada-lang.c (resolve): Add "tracker" parameter.
5341         (resolve_subexp): Likewise.
5342         * ada-exp.y (write_var_from_sym): Update.
5343
5344 2019-04-04  Tom Tromey  <tom@tromey.com>
5345
5346         * type-stack.h: New file.
5347         * type-stack.c: New file.
5348         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5349         type-stack.h.
5350         (insert_into_type_stack, insert_type, push_type, push_type_int)
5351         (insert_type_address_space, pop_type, pop_type_int)
5352         (pop_typelist, pop_type_stack, append_type_stack)
5353         (push_type_stack, get_type_stack, push_typelist)
5354         (follow_type_instance_flags, follow_types): Don't declare.
5355         * parse.c (type_stack): Remove global.
5356         (parse_exp_in_context): Update.
5357         (insert_into_type_stack, insert_type, push_type, push_type_int)
5358         (insert_type_address_space, pop_type, pop_type_int)
5359         (pop_typelist, pop_type_stack, append_type_stack)
5360         (push_type_stack, get_type_stack, push_typelist)
5361         (follow_type_instance_flags, follow_types): Remove (moved to
5362         type-stack.c).
5363         * f-exp.y (type_stack): New global.
5364         Update rules.
5365         (push_kind_type, f_parse): Update.
5366         * d-exp.y (type_stack): New global.
5367         Update rules.
5368         (d_parse): Update.
5369         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5370         Update rules.
5371         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5372         (HFILES_NO_SRCDIR): Add type-stack.h.
5373
5374 2019-04-04  Tom Tromey  <tom@tromey.com>
5375
5376         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5377         (rust_parser::convert_ast_to_expression, rust_parse)
5378         (rust_lex_test_completion, rust_lex_tests): Update.
5379         * parser-defs.h (struct expr_completion_state): New.
5380         (struct parser_state) <parser_state>: Add completion parameter.
5381         <mark_struct_expression, mark_completion_tag>: New methods.
5382         <parse_completion, m_completion_state>: New members.
5383         (prefixify_expression, null_post_parser): Update.
5384         (mark_struct_expression, mark_completion_tag): Don't declare.
5385         * parse.c (parse_completion, expout_last_struct)
5386         (expout_tag_completion_type, expout_completion_name): Remove
5387         globals.
5388         (parser_state::mark_struct_expression)
5389         (parser_state::mark_completion_tag): Now methods.
5390         (prefixify_expression): Add last_struct parameter.
5391         (prefixify_subexp): Likewise.
5392         (parse_exp_1): Update.
5393         (parse_exp_in_context): Add cstate parameter.  Update.
5394         (parse_expression_for_completion): Create an
5395         expr_completion_state.
5396         (null_post_parser): Add "completion" parameter.
5397         * p-exp.y: Update rules.
5398         (yylex): Update.
5399         * language.h (struct language_defn) <la_post_parser>: Add
5400         "completing" parameter.
5401         * go-exp.y: Update rules.
5402         (lex_one_token): Update.
5403         * expression.h (parse_completion): Don't declare.
5404         * d-exp.y: Update rules.
5405         (lex_one_token): Update rules.
5406         * c-exp.y: Update rules.
5407         (lex_one_token): Update.
5408         * ada-lang.c (resolve): Add "parse_completion" parameter.
5409         (resolve_subexp): Likewise.
5410         (ada_resolve_function): Likewise.
5411
5412 2019-04-04  Tom Tromey  <tom@tromey.com>
5413
5414         * parser-defs.h (struct parser_state) <start_arglist,
5415         end_arglist>: New methods.
5416         <arglist_len, m_funcall_chain>: New members.
5417         (arglist_len, start_arglist, end_arglist): Don't declare.
5418         * parse.c (arglist_len, funcall_chain): Remove global.
5419         (start_arglist, end_arglist): Remove functions.
5420         (parse_exp_in_context): Update.
5421         * p-exp.y: Update rules.
5422         * m2-exp.y: Update rules.
5423         * go-exp.y: Update rules.
5424         * f-exp.y: Update rules.
5425         * d-exp.y: Update rules.
5426         * c-exp.y: Update rules.
5427
5428 2019-04-04  Tom Tromey  <tom@tromey.com>
5429
5430         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5431         lex_operator, push_back>: New methods.
5432         Update all rules.
5433         (rust_parser::lex_hex, lex_escape): Rename and update.
5434         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5435         (rust_parser::lex_operator): Rename and update.
5436         (rust_parser::lex_number, rustyylex, rustyyerror)
5437         (rust_lex_test_init, rust_lex_test_sequence)
5438         (rust_lex_test_push_back, rust_lex_tests): Update.
5439         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5440         parameter.
5441         <lexptr, prev_lexptr>: New members.
5442         (lexptr, prev_lexptr): Don't declare.
5443         * parse.c (lexptr, prev_lexptr): Remove globals.
5444         (parse_exp_in_context): Update.
5445         * p-exp.y (yylex, yyerror): Update.
5446         * m2-exp.y (parse_number, yylex, yyerror): Update.
5447         * go-exp.y (lex_one_token, yyerror): Update.
5448         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5449         * d-exp.y (lex_one_token, yyerror): Update.
5450         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5451         (lex_one_token, yyerror): Update.
5452         * ada-lex.l (YY_INPUT): Update.
5453         (rewind_to_char): Update.
5454         * ada-exp.y (yyerror): Update.
5455
5456 2019-04-04  Tom Tromey  <tom@tromey.com>
5457
5458         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5459         * parser-defs.h (struct parser_state) <parser_state>: Add new
5460         parameter.
5461         <comma_terminates>: New member.
5462         (comma_terminates): Don't declare global.
5463         * parse.c (comma_terminates): Remove global.
5464         (parse_exp_in_context): Update.
5465         * p-exp.y (yylex): Update.
5466         * m2-exp.y (yylex): Update.
5467         * go-exp.y (lex_one_token): Update.
5468         * f-exp.y (yylex): Update.
5469         * d-exp.y (lex_one_token): Update.
5470         * c-exp.y (lex_one_token): Update.
5471         * ada-lex.l: Update.
5472
5473 2019-04-04  Tom Tromey  <tom@tromey.com>
5474
5475         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5476         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5477         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5478         * parser-defs.h (paren_depth): Don't declare.
5479         * parse.c (paren_depth): Remove global.
5480         (parse_exp_in_context): Update.
5481         * p-exp.y (paren_depth): New global.
5482         (pascal_parse): Initialize it.
5483         * m2-exp.y (paren_depth): New global.
5484         (m2_parse): Initialize it.
5485         * go-exp.y (paren_depth): New global.
5486         (go_parse): Initialize it.
5487         * f-exp.y (paren_depth): New global.
5488         (f_parse): Initialize it.
5489         * d-exp.y (paren_depth): New global.
5490         (d_parse): Initialize it.
5491         * c-exp.y (paren_depth): New global.
5492         (c_parse): Initialize it.
5493         * ada-lex.l (paren_depth): New global.
5494         (lexer_init): Initialize it.
5495
5496 2019-04-04  Tom Tromey  <tom@tromey.com>
5497
5498         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5499         (rust_parser::convert_ast_to_type)
5500         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5501         * parser-defs.h (struct parser_state) <parser_state>: Add
5502         parameters.  Initialize new members.
5503         <expression_context_block, expression_context_pc>: New members.
5504         * parse.c (expression_context_block, expression_context_pc):
5505         Remove globals.
5506         (parse_exp_in_context): Update.
5507         * p-exp.y: Update all rules.
5508         (yylex): Update.
5509         * m2-exp.y: Update all rules.
5510         (yylex): Update.
5511         * go-exp.y (yylex): Update.
5512         * f-exp.y (yylex): Update.
5513         * d-exp.y: Update all rules.
5514         (yylex): Update.
5515         * c-exp.y: Update all rules.
5516         (lex_one_token, classify_name, yylex, c_parse): Update.
5517         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5518
5519 2019-04-04  Tom Tromey  <tom@tromey.com>
5520
5521         * gdbarch.h, gdbarch.c: Rebuild.
5522         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5523         * stap-probe.h:
5524         (struct stap_parse_info): Replace "parser_state" with
5525         "expr_builder".
5526         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5527         (parser_state): New class.
5528         * parse.c (expr_builder): Rename.
5529         (expr_builder::release): Rename.
5530         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5531         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5532         (write_exp_elt_longcst, write_exp_elt_floatcst)
5533         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5534         (write_exp_string_vector, write_exp_bitstring)
5535         (write_exp_msymbol, mark_struct_expression)
5536         (write_dollar_variable)
5537         (insert_type_address_space, increase_expout_size): Replace
5538         "parser_state" with "expr_builder".
5539         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5540         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5541         "parser_state" with "expr_builder".
5542
5543 2019-04-04  Tom Tromey  <tom@tromey.com>
5544
5545         * rust-exp.y: Replace "parse_language" with method call.
5546         * p-exp.y:
5547         (yylex): Replace "parse_language" with method call.
5548         * m2-exp.y:
5549         (yylex): Replace "parse_language" with method call.
5550         * go-exp.y (classify_name): Replace "parse_language" with method
5551         call.
5552         * f-exp.y (yylex): Replace "parse_language" with method call.
5553         * d-exp.y (lex_one_token): Replace "parse_language" with method
5554         call.
5555         * c-exp.y:
5556         (lex_one_token, classify_name, yylex): Replace "parse_language"
5557         with method call.
5558         * ada-exp.y (find_primitive_type, type_char)
5559         (type_system_address): Replace "parse_language" with method call.
5560
5561 2019-04-04  Tom Tromey  <tom@tromey.com>
5562
5563         * rust-exp.y: Replace "parse_gdbarch" with method call.
5564         * parse.c (write_dollar_variable, insert_type_address_space):
5565         Replace "parse_gdbarch" with method call.
5566         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5567         call.
5568         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5569         call.
5570         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5571         "parse_gdbarch" with method call.
5572         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5573         with method call.
5574         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5575         "parse_gdbarch" with method call.
5576         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5577         "parse_gdbarch" with method call.
5578         * c-exp.y (parse_type, parse_number, classify_name): Replace
5579         "parse_gdbarch" with method call.
5580         * ada-lex.l: Replace "parse_gdbarch" with method call.
5581         * ada-exp.y (parse_type, find_primitive_type, type_char)
5582         (type_system_address): Replace "parse_gdbarch" with method call.
5583
5584 2019-04-04  Tom Tromey  <tom@tromey.com>
5585
5586         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5587         * stap-probe.c (stap_parse_argument): Update.
5588         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5589         initial_size parameter.
5590         * rust-exp.y (rust_lex_tests): Update.
5591         * parse.c (parser_state): Update.
5592         (parse_exp_in_context): Update.
5593         * parser-defs.h (struct parser_state) <parser_state>: Remove
5594         "initial_size" parameter.
5595
5596 2019-04-04  Tom Tromey  <tom@tromey.com>
5597
5598         * parser-defs.h (increase_expout_size): Don't declare.
5599         * parse.c (increase_expout_size): Now static.
5600
5601 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
5602
5603         * gnu-nat.c (gnu_nat_target::wait): Fix
5604         target_waitstatus_to_string call.
5605
5606 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5607
5608         * eval.c (evaluate_subexp_standard): Handle internal functions
5609         during Fortran function call handling.
5610
5611 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5612
5613         * NEWS: Mention new internal functions.
5614         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5615         (read_base_type): Use dwarf2_init_complex_target_type.
5616         * value.c (creal_internal_fn): New function.
5617         (cimag_internal_fn): New function.
5618         (_initialize_values): Register new internal functions.
5619
5620 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5621
5622         * infrun.c (stop_all_threads): If debug_infrun, always
5623         trace the wait status after wait_one, using
5624         target_waitstatus_to_string and target_pid_to_str.
5625         (handle_inferior_event): Replace various trace of
5626         wait status kind by a single trace.
5627         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5628         wait status kind image by target_waitstatus_to_string.
5629         * target/waitstatus.c (target_waitstatus_to_string): Fix
5630         obsolete comment.
5631
5632 2019-04-01  Tom Tromey  <tromey@adacore.com>
5633
5634         PR symtab/23331:
5635         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
5636
5637 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5638             Pedro Alves  <palves@redhat.com>
5639
5640         * top.c (quit_force): Call 'finalize_values'.
5641         * value.c (finalize_values): New function.
5642         * value.h (finalize_values): Declare.
5643
5644 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
5645
5646         * NEWS: Announce $_gdb_major and $_gdb_minor.
5647
5648         * top.c (init_gdb_version_vars): New function.
5649         (gdb_init): Call init_gdb_version_vars.
5650
5651 2019-03-29  Tom Tromey  <tromey@adacore.com>
5652
5653         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
5654         help text.  Remove dead code.
5655
5656 2019-03-29  Keith Seitz  <keiths@redhat.com>
5657
5658         From Siddhesh Poyarekar:
5659         * f-lang.h (f77_get_upperbound): Return LONGEST.
5660         (f77_get_lowerbound): Likewise.
5661         * f-typeprint.c (f_type_print_varspec_suffix): Expand
5662         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
5663         print them.
5664         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
5665         plongest to format print it.
5666         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
5667         (f77_get_upperbound): Likewise.
5668         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
5669         LOWER_BOUND to LONGEST.
5670         (f77_create_arrayprint_offset_tbl): Likewise.
5671
5672 2019-03-29  Keith Seitz  <keiths@redhat.com>
5673
5674         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
5675         %s/pulongest for TYPE_LENGTH instead of %d in format
5676         strings.
5677         * ada-typerint.c (ada_print_type): Likewise.
5678         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
5679         * compile/compile-c-support.c (generate_register_struct): Likewise.
5680         * gdbtypes.c (recursive_dump_type): Likewise.
5681         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
5682         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
5683         instead of %d in format strings.
5684         * riscv-tdep.c (riscv_type_alignment): Cast second argument
5685         to std::min to ULONGEST.
5686         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
5687         instead of %d in format strings.
5688         * tracepoint.c (info_scope_command): Likewise.
5689         * typeprint.c (print_offset_data::update)
5690         (print_offset_data::finish): Likewise.
5691         * xtensa-tdep.c (xtensa_store_return_value)
5692         (xtensa_push_dummy_call): Likewise.
5693
5694 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
5695
5696         * windows-nat.c (display_selector): Fixed format specifications
5697         for 64-bit Cygwin.
5698
5699 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5700
5701         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
5702
5703 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
5704
5705         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
5706         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
5707         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
5708         (nios2_linux_init_abi): Install it.
5709
5710 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5711
5712         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
5713
5714 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5715
5716         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
5717
5718 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5719             Tom Tromey  <tromey@adacore.com>
5720
5721         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
5722
5723 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
5724
5725         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
5726         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
5727         method to compute the bounds of range types. Also print "[evaluated]"
5728         if the bounds' values come from a dynamic evaluation.
5729
5730 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5731
5732         * cp-valprint.c (cp_print_value_fields): Don't print trailing
5733         whitespace when pretty printing is on.
5734
5735 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5736
5737         * ppc-linux-nat.c: Add include.
5738
5739 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5740
5741         * NEWS: Mention AArch64 Pointer Authentication.
5742
5743 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5744
5745         * arm-linux-nat.c: Add include.
5746
5747 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
5748
5749         * source-cache.c (source_cache::get_source_lines): Re-read
5750         fullname after calling open_source_file.
5751
5752 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
5753
5754         * NEWS: Mention TLS support for FreeBSD.
5755
5756 2019-03-25  Tom Tromey  <tromey@adacore.com>
5757
5758         * minsyms.c (BUNCH_SIZE): Update comment.
5759         (~minimal_symbol_reader): Remove old comment.
5760         (compact_minimal_symbols): Update comment.
5761         (minimal_symbol_reader::install): Remove old comment.  Update
5762         other comments.
5763
5764 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5765
5766         * s390-linux-nat.c: Add include.
5767
5768 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5769
5770         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5771         Call linux_get_hwcap.
5772         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
5773         Likewise.
5774         (aarch64_linux_get_hwcap): Remove function.
5775         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
5776         declaration.
5777         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
5778         linux_get_hwcap.
5779         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5780         * linux-tdep.c (linux_get_hwcap): Add function.
5781         (linux_get_hwcap2): Likewise.
5782         * linux-tdep.h (linux_get_hwcap): Add declaration.
5783         (linux_get_hwcap2): Likewise.
5784         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
5785         (ppc_linux_get_hwcap2): Likewise.
5786         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
5787         linux_get_hwcap.
5788         (ppc_linux_nat_target::insert_watchpoint): Likewise.
5789         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
5790         (ppc_linux_nat_target::read_description): Likewise.
5791         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
5792         * s390-linux-nat.c: Likewise.
5793         * s390-linux-tdep.c (s390_core_read_description): Likewise.
5794
5795 2019-03-24  Tom Tromey  <tom@tromey.com>
5796
5797         * ada-lang.c (standard_lookup): Simplify initialization.
5798         (ada_lookup_symbol_nonlocal): Simplify return.
5799         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
5800         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
5801         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
5802         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
5803         initialization.
5804         * solib.c (solib_global_lookup): Simplify.
5805         * symtab.c (null_block_symbol): Remove.
5806         (symbol_cache_lookup): Simplify returns.
5807         (lookup_language_this): Simplify returns.
5808         (lookup_symbol_aux): Simplify return.
5809         (lookup_local_symbol): Simplify returns.
5810         (lookup_global_symbol_from_objfile): Simplify return.
5811         (lookup_symbol_in_objfile_symtabs)
5812         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
5813         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
5814         (lookup_static_symbol, lookup_global_symbol): Simplify return.
5815         * cp-namespace.c (cp_lookup_bare_symbol)
5816         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
5817         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
5818         (cp_lookup_nested_symbol): Don't use null_block_symbol.
5819         (cp_lookup_symbol_via_imports): Simplify initialization.
5820         (find_symbol_in_baseclass): Likewise.
5821         * symtab.h (null_block_symbol): Remove.
5822         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
5823         (d_lookup_nested_symbol, d_lookup_symbol_imports)
5824         (d_lookup_symbol_module): Likewise.
5825         (find_symbol_in_baseclass): Simplify initialization.
5826
5827 2019-03-24  Tom Tromey  <tom@tromey.com>
5828
5829         * expression.h: Don't include symtab.h.
5830         (struct block): Forward declare.
5831
5832 2019-03-24  Tom Tromey  <tom@tromey.com>
5833
5834         * c-exp.y (typebase): Remove casts.
5835         * gdbtypes.c (lookup_unsigned_typename, )
5836         (lookup_signed_typename): Remove cast.
5837         * eval.c (parse_to_comma_and_eval): Remove cast.
5838         * parse.c (write_dollar_variable): Remove cast.
5839         * block.h (struct block) <superblock>: Now const.
5840         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
5841         * psymtab.c (psym_map_matching_symbols): Make "block" const.
5842         (map_block): Make "block" const.
5843         * symfile.h (struct quick_symbol_functions)
5844         <map_matching_symbols>: Constify block argument to "callback".
5845         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
5846         const.
5847         (find_pc_sect_compunit_symtab): Make "b" const.
5848         (find_symbol_at_address): Likewise.
5849         (search_symbols): Likewise.
5850         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
5851         (dw2_debug_names_lookup_symbol): Likewise.
5852         (dw2_map_matching_symbols): Update.
5853         * p-valprint.c (pascal_val_print): Remove "block".
5854         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
5855         (aux_add_nonlocal_symbols): Make "block" const.
5856         (resolve_subexp): Remove cast.
5857         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5858         const.
5859         (iterate_over_file_blocks): Likewise.
5860         * f-exp.y (%union) <bval>: Remove.
5861         * coffread.c (patch_opaque_types): Make "b" const.
5862         * spu-tdep.c (spu_catch_start): Make "block" const.
5863         * c-valprint.c (print_unpacked_pointer): Remove "block".
5864         * symmisc.c (dump_symtab_1): Make "b" const.
5865         (block_depth): Make "block" const.
5866         * d-exp.y (%union) <bval>: Remove.
5867         * cp-support.h (cp_lookup_rtti_type): Update.
5868         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5869         * psymtab.c (psym_lookup_symbol): Make "block" const.
5870         (maintenance_check_psymtabs): Make "b" const.
5871         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5872         (enumerate_locals, enumerate_args): Update.
5873         * python/py-symtab.c (stpy_global_block): Make "block" const.
5874         (stpy_static_block): Likewise.
5875         * inline-frame.c (block_starting_point_at): Make "new_block"
5876         const.
5877         * block.c (find_block_in_blockvector): Make return type const.
5878         (blockvector_for_pc_sect): Make "b" const.
5879         (find_block_in_blockvector): Make "b" const.
5880
5881 2019-03-23  Tom Tromey  <tom@tromey.com>
5882
5883         * varobj.c (varobj_create): Update.
5884         * symfile.c (clear_symtab_users): Don't reset innermost_block.
5885         * printcmd.c (display_command, do_one_display): Don't reset
5886         innermost_block.
5887         * parser-defs.h (enum innermost_block_tracker_type): Move to
5888         expression.h.
5889         (innermost_block): Update comment.
5890         * parse.c (parse_exp_1): Add tracker_types parameter.
5891         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
5892         tracker_types parameter.  Reset innermost_block.
5893         (parse_exp_in_context): Remove.
5894         (parse_expression_for_completion): Update.
5895         * objfiles.c (~objfile): Don't reset expression_context_block or
5896         innermost_block.
5897         * expression.h (enum innermost_block_tracker_type): Move from
5898         parser-defs.h.
5899         (parse_exp_1): Add tracker_types parameter.
5900         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5901         reset innermost_block.
5902
5903 2019-03-23  Tom Tromey  <tom@tromey.com>
5904
5905         * objfiles.h: Include bcache.h.
5906
5907 2019-03-23  Tom Tromey  <tom@tromey.com>
5908
5909         * linespec.c (get_current_search_block): Use
5910         scoped_restore_current_language.
5911         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5912
5913 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5914             Jiong Wang  <jiong.wang@arm.com>
5915
5916         * aarch64-linux-tdep.c
5917         (aarch64_linux_iterate_over_regset_sections): Check for pauth
5918         section.
5919         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5920
5921 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5922             Jiong Wang  <jiong.wang@arm.com>
5923
5924         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5925         instructions.
5926         (aarch64_analyze_prologue_test): Add PACIASP test.
5927         (aarch64_prologue_prev_register): Unmask PC value.
5928
5929 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5930             Jiong Wang  <jiong.wang@arm.com>
5931
5932         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
5933         (aarch64_dwarf2_prev_register): Unmask PC value.
5934         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
5935         (aarch64_execute_dwarf_cfa_vendor_op): Check for
5936         DW_CFA_AARCH64_negate_ra_state.
5937         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
5938
5939 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5940             Jiong Wang  <jiong.wang@arm.com>
5941
5942         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
5943         registers.
5944         (aarch64_pseudo_register_name): Likewise.
5945         (aarch64_pseudo_register_type): Likewise.
5946         (aarch64_pseudo_register_reggroup_p): Likewise.
5947         (aarch64_gdbarch_init): Add pauth registers.
5948         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
5949         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
5950         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
5951         (struct gdbarch_tdep): Add regnum for ra_state.
5952
5953 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5954             Jiong Wang  <jiong.wang@arm.com>
5955
5956         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
5957
5958 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5959             Jiong Wang  <jiong.wang@arm.com>
5960
5961         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
5962         function.
5963         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
5964         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
5965         (aarch64_gdbarch_init): Add puth registers.
5966         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
5967         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
5968         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
5969
5970 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5971             Jiong Wang  <jiong.wang@arm.com>
5972
5973         * aarch64-linux-nat.c
5974         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
5975         * aarch64-linux-tdep.c
5976         (aarch64_linux_core_read_description): Likewise.
5977         (aarch64_linux_get_hwcap): New function.
5978         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
5979         (aarch64_linux_get_hwcap): New declaration.
5980
5981 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5982             Jiong Wang  <jiong.wang@arm.com>
5983
5984         * aarch64-linux-nat.c
5985         (aarch64_linux_nat_target::read_description): Add pauth param.
5986         * aarch64-linux-tdep.c
5987         (aarch64_linux_core_read_description): Likewise.
5988         * aarch64-tdep.c (struct target_desc): Add in pauth.
5989         (aarch64_read_description): Add pauth param.
5990         (aarch64_gdbarch_init): Likewise.
5991         * aarch64-tdep.h (aarch64_read_description): Likewise.
5992         * arch/aarch64.c (aarch64_create_target_description): Likewise.
5993         * arch/aarch64.h (aarch64_create_target_description): Likewise.
5994         * features/Makefile: Add new files.
5995         * features/aarch64-pauth.c: New file.
5996         * features/aarch64-pauth.xml: New file.
5997
5998 2019-03-20  Tom Tromey  <tromey@adacore.com>
5999
6000         * infrun.c (handle_inferior_event): Rename from
6001         handle_inferior_event_1.  Create a scoped_value_mark.
6002         (handle_inferior_event): Remove.
6003
6004 2019-03-19  Tom Tromey  <tromey@adacore.com>
6005
6006         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6007         * infrun.h (print_stop_event): Add "displays" parameter.
6008         * infrun.c (print_stop_event): Add "displays" parameter.
6009
6010 2019-03-19  Pedro Alves  <palves@redhat.com>
6011
6012         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6013         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6014         to -1.  Fix TABs vs spaces.
6015         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6016         * tui/tui-out.h (tui_ui_out) Add intro comments.
6017         <m_line, m_start_of_line>: In-class initialize, and add describing
6018         comment.
6019
6020 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6021
6022         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6023         variable names.
6024         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6025
6026 2019-03-18  Pedro Alves  <palves@redhat.com>
6027             Eli Zaretskii <eliz@gnu.org>
6028
6029         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6030         m_line and m_start_of_line.
6031
6032 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6033
6034         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6035         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6036         it returns a newline.  This fixes a regression in TU mode, whereby
6037         the next line is output on the same screen line as the user input.
6038
6039 2019-03-18  Tom Tromey  <tromey@adacore.com>
6040
6041         * minsyms.c (minimal_symbol_reader::install): Remove call to
6042         obstack_blank.
6043
6044 2019-03-18  Pedro Alves  <palves@redhat.com>
6045
6046         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6047         New globals.
6048         (apply_style): New, factored out from ...
6049         (apply_ansi_escape): ... this.  Handle reverse video mode.
6050         (tui_set_reverse_mode): New function.
6051         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6052         * tui/tui-winsource.c (tui_show_source_line): Use
6053         tui_set_reverse_mode instead of setting A_STANDOUT.
6054         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6055         New setter methods.
6056
6057 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6058
6059         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6060         Handle tabs.
6061
6062 2019-03-18  Tom Tromey  <tromey@adacore.com>
6063
6064         * ada-lang.c (empty_array): Add "high" parameter.
6065         (ada_evaluate_subexp): Update.
6066
6067 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6068
6069         * unittests/string_view-selftests.c: Define
6070         _initialize_string_view_selftests unconditionally.
6071
6072 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6073
6074         PR gdb/24350
6075         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6076
6077 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6078
6079         PR gdb/24351
6080         * windows-nat.c (display_selector): Fix format specifiers.
6081
6082 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6083
6084         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6085         tui_refill_source_window instead of tui_refresh_win, to update the
6086         current execution line.  This fixes redisplay of the current line
6087         when stepping through the code with "next" or "step".
6088
6089 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6090
6091         * source-cache.c (source_cache::get_source_lines): Call
6092         find_source_lines to initialize s->nlines.  This fixes vertical
6093         scrolling of TUI source window when the DOWN arrow is pressed.
6094
6095 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6096
6097         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6098         linux-thread-db.c (_initialize_thread_db): Likewise.
6099
6100 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6101
6102         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6103         wclrtoeol in tui_show_source_line".  This reverts changes made in
6104         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6105
6106 2019-03-15  Tom Tromey  <tom@tromey.com>
6107
6108         * symtab.h (struct minimal_symbol): Derive from
6109         general_symbol_info.
6110         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6111         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6112         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6113         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6114         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6115         (MSYMBOL_SEARCH_NAME): Update.
6116         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6117         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6118         * minsyms.c (minimal_symbol_reader::record_full): Update.
6119
6120 2019-03-15  Tom Tromey  <tom@tromey.com>
6121
6122         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6123
6124 2019-03-15  Tom Tromey  <tom@tromey.com>
6125
6126         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6127         unique_xmalloc_ptr.
6128         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6129         Update.
6130         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6131         (build_minimal_symbol_hash_tables)
6132         (minimal_symbol_reader::install): Update.
6133
6134 2019-03-15  Tom Tromey  <tom@tromey.com>
6135
6136         * symtab.c (create_demangled_names_hash): Update.
6137         (symbol_set_names): Update.
6138         * objfiles.h (struct objfile_per_bfd_storage)
6139         <demangled_names_hash>: Now an htab_up.
6140         * objfiles.c (objfile_per_bfd_storage): Simplify.
6141
6142 2019-03-15  Tom Tromey  <tom@tromey.com>
6143
6144         * objfiles.h (struct objfile_per_bfd_storage): Declare
6145         destructor.
6146         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6147         New.
6148         (get_objfile_bfd_data): Use new.  Don't initialize
6149         language_of_main.
6150         (free_objfile_per_bfd_storage): Remove.
6151         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6152
6153 2019-03-15  Tom Tromey  <tom@tromey.com>
6154
6155         * symfile.c (reread_symbols): Update.
6156         * objfiles.c (objfile::objfile): Update.
6157         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6158         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6159         comment.
6160         (minimal_symbol_reader::install): Update.
6161         (terminate_minimal_symbol_table): Remove.
6162         * jit.c (jit_object_close_impl): Update.
6163
6164 2019-03-15  Tom Tromey  <tom@tromey.com>
6165
6166         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6167         initializations.
6168
6169 2019-03-15  Tom Tromey  <tom@tromey.com>
6170
6171         * objfiles.h (struct objfile_per_bfd_storage)
6172         <demangled_hash_languages>: Now a bitset.
6173         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6174         (lookup_minimal_symbol): Update.
6175
6176 2019-03-15  Tom Tromey  <tom@tromey.com>
6177
6178         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6179         Don't return the symbol.
6180         * coffread.c (record_minimal_symbol): Use record_full.
6181
6182 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6183
6184         The MS-Windows port of ncurses fails to switch to a color pair if
6185         one or both of the colors are the implicit default colors.  This
6186         change records the default colors when TUI is initialized, and
6187         then specifies them explicitly when a color pair uses the default
6188         colors.  This allows color styling in TUI mode on MS-Windows.
6189
6190         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6191         ncurses_norm_attr.
6192         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6193         colors in ncurses_norm_attr.
6194         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6195         "none", replace it with the default color recorded in
6196         ncurses_norm_attr.
6197
6198 2019-03-14  Tom Tromey  <tromey@adacore.com>
6199
6200         * source-cache.h (class source_cache) <get_source_lines>: Return
6201         std::string.
6202         * source-cache.c (source_cache::extract_lines): Handle case where
6203         first_pos==npos.  Return std::string.
6204         (source_cache::get_source_lines): Update.
6205
6206 2019-03-14  Tom Tromey  <tromey@adacore.com>
6207
6208         * NEWS: Add item for "style sources" commands.
6209         * source-cache.c (source_cache::get_source_lines): Check
6210         source_styling.
6211         * cli/cli-style.c (source_styling): New global.
6212         (_initialize_cli_style): Add "style sources" commands.
6213         (show_style_sources): New function.
6214         * cli/cli-style.h (source_styling): Declare.
6215
6216 2019-03-14  Pedro Alves  <palves@redhat.com>
6217             Tom Tromey  <tromey@adacore.com>
6218
6219         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6220         * tui/tui-winsource.c (tui_refill_source_window): New function,
6221         from...
6222         (tui_horizontal_source_scroll): ... here.  Move some logic.
6223         * cli/cli-style.c (set_style_enabled): Notify new observable.
6224         * tui/tui-hooks.c (tui_redisplay_source): New function.
6225         (tui_attach_detach_observers): Attach or detach
6226         tui_redisplay_source.
6227         * observable.h (source_styling_changed): New observable.
6228         * observable.c: Define source_styling_changed observable.
6229
6230 2019-03-13  Tom Tromey  <tromey@adacore.com>
6231
6232         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6233         (i386_gnu_nat_target::store_registers): Update.
6234         * target-debug.h (target_debug_print_std_string): New macro.
6235         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6236         * windows-tdep.c (display_one_tib): Update.
6237         * tui/tui-stack.c (tui_make_status_line): Update.
6238         * top.c (print_inferior_quit_action): Update.
6239         * thread.c (thr_try_catch_cmd): Update.
6240         (add_thread_with_info): Update.
6241         (thread_target_id_str): Update.
6242         (thr_try_catch_cmd): Update.
6243         (thread_command): Update.
6244         (thread_find_command): Update.
6245         * record-btrace.c (record_btrace_target::info_record)
6246         (record_btrace_resume_thread, record_btrace_target::resume)
6247         (record_btrace_cancel_resume, record_btrace_step_thread)
6248         (record_btrace_target::wait, record_btrace_target::wait)
6249         (record_btrace_target::wait, record_btrace_target::stop): Update.
6250         * progspace.c (print_program_space): Update.
6251         * process-stratum-target.c
6252         (process_stratum_target::thread_address_space): Update.
6253         * linux-fork.c (linux_fork_mourn_inferior)
6254         (detach_checkpoint_command, info_checkpoints_command)
6255         (linux_fork_context): Update.
6256         (linux_fork_detach): Update.
6257         (class scoped_switch_fork_info): Update.
6258         (delete_checkpoint_command): Update.
6259         * infrun.c (follow_fork_inferior): Update.
6260         (follow_fork_inferior): Update.
6261         (proceed_after_vfork_done): Update.
6262         (handle_vfork_child_exec_or_exit): Update.
6263         (follow_exec): Update.
6264         (displaced_step_prepare_throw): Update.
6265         (displaced_step_restore): Update.
6266         (start_step_over): Update.
6267         (resume_1): Update.
6268         (clear_proceed_status_thread): Update.
6269         (proceed): Update.
6270         (print_target_wait_results): Update.
6271         (do_target_wait): Update.
6272         (context_switch): Update.
6273         (stop_all_threads): Update.
6274         (restart_threads): Update.
6275         (finish_step_over): Update.
6276         (handle_signal_stop): Update.
6277         (switch_back_to_stepped_thread): Update.
6278         (keep_going_pass_signal): Update.
6279         (print_exited_reason): Update.
6280         (normal_stop): Update.
6281         * inferior.c (inferior_pid_to_str): Change return type.
6282         (print_selected_inferior): Update.
6283         (add_inferior): Update.
6284         (detach_inferior): Update.
6285         * dummy-frame.c (fprint_dummy_frames): Update.
6286         * dcache.c (dcache_info_1): Update.
6287         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6288         (btrace_fetch, btrace_clear): Update.
6289         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6290         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6291         type.
6292         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6293         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6294         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6295         * gdbarch.c, gdbarch.h: Rebuild.
6296         * gdbarch.sh (core_pid_to_str): Change return type.
6297         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6298         return type.
6299         (windows_nat_target::pid_to_str): Change return type.
6300         (windows_delete_thread): Update.
6301         (windows_nat_target::attach): Update.
6302         (windows_nat_target::files_info): Update.
6303         * target-delegates.c: Rebuild.
6304         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6305         return type.
6306         (sol_thread_target::pid_to_str): Change return type.
6307         * remote.c (class remote_target) <pid_to_str>: Change return
6308         type.
6309         (remote_target::pid_to_str): Change return type.
6310         (extended_remote_target::attach, remote_target::remote_stop_ns)
6311         (remote_target::remote_notif_remove_queued_reply)
6312         (remote_target::push_stop_reply, remote_target::disable_btrace):
6313         Update.
6314         (extended_remote_target::attach): Update.
6315         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6316         type.
6317         (gdbsim_target::pid_to_str): Change return type.
6318         * ravenscar-thread.c (struct ravenscar_thread_target)
6319         <pid_to_str>: Change return type.
6320         (ravenscar_thread_target::pid_to_str): Change return type.
6321         * procfs.c (class procfs_target) <pid_to_str>: Change return
6322         type.
6323         (procfs_target::pid_to_str): Change return type.
6324         (procfs_target::attach): Update.
6325         (procfs_target::detach): Update.
6326         (procfs_target::fetch_registers): Update.
6327         (procfs_target::store_registers): Update.
6328         (procfs_target::wait): Update.
6329         (procfs_target::files_info): Update.
6330         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6331         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6332         return type.
6333         (nto_procfs_target::pid_to_str): Change return type.
6334         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6335         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6336         return type.
6337         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6338         (exit_lwp): Update.
6339         (attach_proc_task_lwp_callback, get_detach_signal)
6340         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6341         (linux_nat_target::resume, wait_lwp, stop_callback)
6342         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6343         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6344         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6345         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6346         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6347         type.
6348         (inf_ptrace_target::attach): Update.
6349         (inf_ptrace_target::files_info): Update.
6350         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6351         type.
6352         (go32_nat_target::pid_to_str): Change return type.
6353         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6354         (gnu_nat_target::wait): Update.
6355         (gnu_nat_target::wait): Update.
6356         (gnu_nat_target::resume): Update.
6357         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6358         (fbsd_nat_target::wait): Update.
6359         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6360         type.
6361         (darwin_nat_target::attach): Update.
6362         * corelow.c (class core_target) <pid_to_str>: Change return type.
6363         (core_target::pid_to_str): Change return type.
6364         * target.c (normal_pid_to_str): Change return type.
6365         (default_pid_to_str): Likewise.
6366         (target_pid_to_str): Change return type.
6367         (target_translate_tls_address): Update.
6368         (target_announce_detach): Update.
6369         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6370         return type.
6371         (bsd_uthread_target::pid_to_str): Change return type.
6372         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6373         type.
6374         (bsd_kvm_target::pid_to_str): Change return type.
6375         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6376         return type.
6377         (aix_thread_target::pid_to_str): Change return type.
6378         * target.h (struct target_ops) <pid_to_str>: Change return type.
6379         (target_pid_to_str, normal_pid_to_str): Likewise.
6380         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6381         type.
6382         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6383         type.
6384         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6385         return type.
6386         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6387         type.
6388         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6389         type.
6390         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6391         return type.
6392
6393 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6394
6395         * NEWS: Mention that the new default MI version is 3.  Mention
6396         changes to the output of commands and events that deal with
6397         multi-location breakpoints.
6398         * breakpoint.c: Include "mi/mi-out.h".
6399         (print_one_breakpoint): Change output syntax if using MI version
6400         >= 3.
6401         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6402         New.
6403         (mi_multi_location_breakpoint_output_fixed): New.
6404         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6405         (mi_cmd_fix_multi_location_breakpoint_output): New.
6406         (mi_multi_location_breakpoint_output_fixed): New.
6407         * mi/mi-cmds.c (mi_cmds): Register command
6408         -fix-multi-location-breakpoint-output.
6409         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6410         interpreter "mi".
6411
6412 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6413
6414         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6415         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6416         instantiate mi_ui_out based on interpreter name.
6417         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6418         * mi/mi-main.c (mi_load_progress): Likewise.
6419
6420 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6421
6422         * NEWS: Combine separate "New targets" sections for 8.3.
6423
6424 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6425
6426         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6427         (ppcfbsd_init_abi): Install gdbarch
6428         "fetch_tls_load_module_address" and "get_thread_local_address"
6429         methods.
6430
6431 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6432
6433         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6434         (riscv_fbsd_init_abi): Install gdbarch
6435         "fetch_tls_load_module_address" and "get_thread_local_address"
6436         methods.
6437
6438 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6439
6440         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6441         (i386fbsd_init_abi): Install gdbarch
6442         "fetch_tls_load_module_address" and "get_thread_local_address"
6443         methods.
6444
6445 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6446
6447         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6448         (amd64fbsd_init_abi): Install gdbarch
6449         "fetch_tls_load_module_address" and "get_thread_local_address"
6450         methods.
6451
6452 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6453
6454         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6455         (struct fbsd_pspace_data): New type.
6456         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6457         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6458         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6459         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6460         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6461
6462 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6463
6464         * gdbtypes.c (lookup_struct_elt): New function.
6465         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6466         * gdbtypes.h (struct struct_elt): New type.
6467         (lookup_struct_elt): New prototype.
6468
6469 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6470
6471         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6472         remove disabled code block.
6473
6474 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6475
6476         * gdbarch.sh (get_thread_local_address): New method.
6477         * gdbarch.h, gdbarch.c: Regenerate.
6478         * target.c (target_translate_tls_address): Use
6479         gdbarch_get_thread_local_address if present instead of
6480         target::get_thread_local_address.
6481
6482 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6483
6484         * target.h (target::get_thread_local_address): Update comment.
6485
6486 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6487
6488         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6489         objfile->separate_debug_objfile_backlink if not NULL.
6490
6491 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6492
6493         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6494         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6495         (amd64bsd_store_inferior_registers): Likewise.
6496         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6497         Enable segment base registers.
6498         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6499         PT_GETFSBASE and PT_GETGSBASE.
6500         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6501         PT_SETGSBASE.
6502         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6503         segment base registers.
6504         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6505
6506 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6507
6508         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6509         Update calls to i386_target_description to add 'segments'
6510         parameter.
6511         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6512         add segment base registers.
6513         * arch/i386.c (i386_create_target_description): Add 'segments'
6514         parameter to enable segment base registers.
6515         * arch/i386.h (i386_create_target_description): Likewise.
6516         * features/i386/32bit-segments.xml: New file.
6517         * features/i386/32bit-segments.c: Generate.
6518         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6519         call to i386_target_description to add 'segments' parameter.
6520         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6521         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6522         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6523         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6524         if feature is present.
6525         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6526         Add 'segments' parameter to call to i386_target_description.
6527         (i386_target_description): Add 'segments' parameter to enable
6528         segment base registers.
6529         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6530         to call to i386_target_description.
6531         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6532         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6533         Define I386_NUM_REGS.
6534         (i386_target_description): Add 'segments' parameter to enable
6535         segment base registers.
6536
6537 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6538
6539         PR/24325
6540         * source-cache.c: #undef open and close, to avoid unresolved
6541         externals during linking.
6542
6543 2019-03-12  Tom Tromey  <tromey@adacore.com>
6544
6545         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6546         const.  Add initializers.
6547         (_initialize_remote): Don't initialize ptid globals.
6548
6549 2019-03-12  Pedro Alves  <palves@redhat.com>
6550
6551         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6552
6553 2019-03-12  Pedro Alves  <palves@redhat.com>
6554
6555         * cp-name-parser.y (main): Remove unused 'len' variable.
6556
6557 2019-03-12  Tom Tromey  <tromey@adacore.com>
6558
6559         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6560         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6561
6562 2019-03-12  Tom Tromey  <tromey@adacore.com>
6563
6564         * linux-nat.c (iterate_over_lwps): Update.
6565         (stop_callback): Remove parameter.
6566         (stop_wait_callback, detach_callback, resume_set_callback)
6567         (select_singlestep_lwp_callback, set_ignore_sigint)
6568         (status_callback, resumed_callback, resume_clear_callback)
6569         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6570         data parameter.
6571         (linux_nat_target::detach, linux_nat_target::resume)
6572         (linux_stop_and_wait_all_lwps, select_event_lwp)
6573         (linux_nat_filter_event, linux_nat_wait_1)
6574         (linux_nat_target::kill, linux_nat_target::stop)
6575         (linux_nat_target::stop): Update.
6576         (linux_nat_resume_callback): Change type.
6577         (resume_stopped_resumed_lwps, count_events_callback)
6578         (select_event_lwp_callback): Likewise.
6579         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6580         * arm-linux-nat.c (struct update_registers_data): Remove.
6581         (update_registers_callback): Change type.
6582         (arm_linux_insert_hw_breakpoint1): Update.
6583         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6584         parameter.
6585         (x86_linux_dr_set_addr): Update.
6586         (x86_linux_dr_set_control): Update.
6587         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6588         (iterate_over_lwps): Use gdb::function_view.
6589         * nat/aarch64-linux-hw-point.c (struct
6590         aarch64_dr_update_callback_param): Remove.
6591         (debug_reg_change_callback): Change type.
6592         (aarch64_notify_debug_reg_change): Update.
6593         * s390-linux-nat.c (s390_refresh_per_info): Update.
6594
6595 2019-03-11  Tom Tromey  <tromey@adacore.com>
6596
6597         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6598         redundant assignment to "this_cu".
6599
6600 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6601
6602         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6603
6604 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6605
6606         * gdbtypes.c (rank_one_type_parm_set): New function extracted
6607         from...
6608         (rank_one_type): ... this.
6609
6610 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6611
6612         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6613         from...
6614         (rank_one_type): ... this.
6615
6616 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6617
6618         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6619         from...
6620         (rank_one_type): ... this.
6621
6622 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6623
6624         * gdbtypes.c (rank_one_type_parm_float): New function extracted
6625         from...
6626         (rank_one_type): ... this.
6627
6628 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6629
6630         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6631         from...
6632         (rank_one_type): ... this.
6633
6634 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6635
6636         * gdbtypes.c (rank_one_type_parm_range): New function extracted
6637         from...
6638         (rank_one_type): ... this.
6639
6640 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6641
6642         * gdbtypes.c (rank_one_type_parm_char): New function extracted
6643         from...
6644         (rank_one_type): ... this.
6645
6646 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6647
6648         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
6649         from...
6650         (rank_one_type): ... this.
6651
6652 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6653
6654         * gdbtypes.c (rank_one_type_parm_int): New function extracted
6655         from...
6656         (rank_one_type): ... this.
6657
6658 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6659
6660         * gdbtypes.c (rank_one_type_parm_func): New function extracted
6661         from...
6662         (rank_one_type): ... this.
6663
6664 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6665
6666         * gdbtypes.c (rank_one_type_parm_array): New function extracted
6667         from...
6668         (rank_one_type): ... this.
6669
6670 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6671
6672         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
6673         from...
6674         (rank_one_type): ... this.
6675
6676 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6677
6678         * inferior.c (initialize_inferiors): Ensure 'help set/show print
6679         inferior-events' shows the example events.
6680
6681 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
6682
6683         Support styling on native MS-Windows console
6684
6685         PR/24315
6686         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
6687         on MS-Windows if $TERM is not defined.
6688
6689         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
6690
6691         * posix-hdep.c (gdb_console_fputs):
6692         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
6693         functions.
6694         * ui-file.h (gdb_console_fputs): Add prototype.
6695
6696         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
6697         back to fputs only if the former returns zero.
6698
6699 2019-03-07  Tom Tromey  <tom@tromey.com>
6700
6701         * symmisc.c (print_symbol_bcache_statistics): Update.
6702         (print_objfile_statistics): Update.
6703         * symfile.c (allocate_symtab): Update.
6704         * stabsread.c: Don't include bcache.h.
6705         * psymtab.h (struct psymbol_bcache): Don't declare.
6706         (class psymtab_storage) <psymbol_cache>: Now a bcache.
6707         (psymbol_bcache_init, psymbol_bcache_free)
6708         (psymbol_bcache_get_bcache): Don't declare.
6709         * psymtab.c (struct psymbol_bcache): Remove.
6710         (psymtab_storage::psymtab_storage): Update.
6711         (psymtab_storage::~psymtab_storage): Update.
6712         (psymbol_bcache_init, psymbol_bcache_free)
6713         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
6714         (add_psymbol_to_bcache): Update.
6715         (allocate_psymtab): Update.
6716         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6717         macro_cache>: No longer pointers.
6718         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
6719         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
6720         * macrotab.c (macro_bcache): Update.
6721         * macroexp.c: Don't include bcache.h.
6722         * gdbtypes.c (check_types_worklist): Update.
6723         (types_deeply_equal): Remove TRY/CATCH.  Update.
6724         * elfread.c (elf_symtab_read): Update.
6725         * dwarf2read.c: Don't include bcache.h.
6726         * buildsym.c (buildsym_compunit::get_macro_table): Update.
6727         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
6728         (print_bcache_statistics, bcache_memory_used): Don't declare.
6729         (struct bcache): Move from bcache.c.  Add constructor, destructor,
6730         methods.  Rename all data members.
6731         * bcache.c (struct bcache): Move to bcache.h.
6732         (bcache::expand_hash_table): Rename from expand_hash_table.
6733         (bcache): Remove.
6734         (bcache::insert): Rename from bcache_full.
6735         (bcache::compare): Rename from bcache_compare.
6736         (bcache_xmalloc): Remove.
6737         (bcache::~bcache): Rename from bcache_xfree.
6738         (bcache::print_statistics): Rename from print_bcache_statistics.
6739         (bcache::memory_used): Rename from bcache_memory_used.
6740
6741 2019-03-07  Pedro Alves  <palves@redhat.com>
6742
6743         * infrun.c (normal_stop): Also check for
6744         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
6745
6746 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
6747
6748         * f-lang.c (value_from_host_double): Moved to...
6749         * value.c (value_from_host_double): ...here.
6750         * value.h (value_from_host_double): Declare.
6751         * guile/scm-math.c (vlscm_convert_typed_number): Use
6752         value_from_host_double.
6753         (vlscm_convert_number): Likewise.
6754         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
6755         * python/py-value.c (convert_value_from_python): Likewise.
6756
6757 2019-03-06  Tom Tromey  <tom@tromey.com>
6758
6759         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
6760
6761 2019-03-06  Tom Tromey  <tom@tromey.com>
6762
6763         * utils.h (free_current_contents): Don't declare.
6764         * utils.c (free_current_contents): Remove.
6765
6766 2019-03-06  Tom Tromey  <tom@tromey.com>
6767
6768         * top.c (quit_force): Update.
6769         * main.c (captured_command_loop): Update.
6770         * common/new-op.c (operator new): Update.
6771         * common/common-exceptions.c (struct catcher)
6772         <save_cleanup_chain>: Remove member.
6773         (exceptions_state_mc_init): Update.
6774         (exception_try_scope_entry): Return nullptr.
6775         (exception_try_scope_exit, exception_rethrow)
6776         (throw_exception_sjlj, throw_exception_cxx): Update.
6777         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
6778         (all_cleanups, do_cleanups, discard_cleanups)
6779         (discard_final_cleanups, save_cleanups, save_final_cleanups)
6780         (restore_cleanups, restore_final_cleanups): Don't declare.
6781         (do_final_cleanups): Remove parameter.
6782         * common/cleanups.c (cleanup_chain, make_cleanup)
6783         (make_cleanup_dtor, all_cleanups, do_cleanups)
6784         (discard_my_cleanups, discard_cleanups)
6785         (discard_final_cleanups, save_my_cleanups, save_cleanups)
6786         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
6787         (null_cleanup): Remove.
6788         (do_final_cleanups): Remove parameter.
6789
6790 2019-03-06  Tom Tromey  <tom@tromey.com>
6791
6792         * remote.c (remote_target::remote_parse_stop_reply): Use
6793         unique_xmalloc_ptr.
6794
6795 2019-03-06  Tom Tromey  <tom@tromey.com>
6796
6797         * stabsread.c (struct stabs_field_info): Rename from field_info.
6798         <list, fnlist>: Add initializers.
6799         <obstack>: New member.
6800         (read_member_functions, read_struct_fields, read_baseclasses):
6801         Allocate on obstack.  Don't use cleanups.
6802         (read_one_struct_field, read_member_functions, read_struct_fields)
6803         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
6804         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
6805         (read_struct_type): Update.
6806
6807 2019-03-06  Tom Tromey  <tom@tromey.com>
6808
6809         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
6810         * common/filestuff.h (make_cleanup_close): Don't declare.
6811         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
6812         Remove.
6813
6814 2019-03-06  Tom Tromey  <tom@tromey.com>
6815
6816         * solib-aix.c: Use make_scope_exit.
6817
6818 2019-03-06  Tom Tromey  <tom@tromey.com>
6819
6820         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
6821         Use make_scope_exit.
6822
6823 2019-03-06  Tom Tromey  <tom@tromey.com>
6824
6825         * solib-svr4.c (disable_probes_interface): Remove parameter.
6826         (svr4_handle_solib_event): Use make_scope_exit.
6827
6828 2019-03-06  Tom Tromey  <tom@tromey.com>
6829
6830         * remote.c (struct stop_reply_deleter): Remove.
6831         (stop_reply_up): Update.
6832         (struct stop_reply): Derive from notif_event.  Don't typedef.
6833         <regcache>: Now a std::vector.
6834         (stop_reply_xfree): Remove.
6835         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
6836         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
6837         (remote_target::discard_pending_stop_replies): Use delete.
6838         (remote_target::remote_parse_stop_reply): Update.
6839         (remote_target::process_stop_reply): Update.
6840         * remote-notif.h (struct notif_event): Add virtual destructor.
6841         Remove "dtr" member.
6842         (struct notif_client) <alloc_event>: Return a unique_ptr.
6843         (notif_event_xfree): Don't declare.
6844         (notif_event_up): New typedef.
6845         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
6846         (notif_event_xfree, do_notif_event_xfree): Remove.
6847         (remote_notif_state_xfree): Update.
6848
6849 2019-03-06  Tom Tromey  <tom@tromey.com>
6850
6851         * infrun.c (displaced_step_clear_cleanup): Now a
6852         forward_scope_exit type.
6853         (displaced_step_prepare_throw): Update.
6854         (displaced_step_fixup): Update.
6855
6856 2019-03-06  Tom Tromey  <tom@tromey.com>
6857
6858         * inferior.h (class inferior): Update comment.
6859         * gdbthread.h (class thread_info): Update comment.
6860
6861 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
6862             Tom Tromey  <tom@tromey.com>
6863
6864         * stabsread.h (struct stab_section_list): Remove.
6865         (coffstab_build_psymtabs): Update.
6866         * dbxread.c (symbuf_sections): Now a std::vector.
6867         (sect_idx): New global.
6868         (fill_symbuf): Update.
6869         (coffstab_build_psymtabs): Change type of stabsects parameter.
6870         Update.
6871         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6872         std::vector.
6873         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6874         (coff_locate_sections): Update.
6875         (coff_symfile_read): Remove cleanups.  Update.
6876         (init_stringtab): Add storage parameter.
6877         (free_stringtab, free_stringtab_cleanup): Remove.
6878         (init_lineno): Add storage parameter.
6879         (free_linetab, free_linetab_cleanup): Remove.
6880
6881 2019-03-06  Pedro Alves  <palves@redhat.com>
6882
6883         * linux-fork.c (fork_info::clobber_regs): Delete.
6884         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6885         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
6886         comment.  Adjust.
6887         (scoped_switch_fork_info::scoped_switch_fork_info)
6888         (checkpoint_command, linux_fork_context): Adjust
6889         fork_save_infrun_state calls.
6890
6891 2019-03-06  Pedro Alves  <palves@redhat.com>
6892
6893         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6894         (inf_has_multiple_threads): Return 'bool' and rewrite using
6895         inferior_info::threads().
6896
6897 2019-03-06  Pedro Alves  <palves@redhat.com>
6898
6899         * linux-fork.c: Include <list>.
6900         (fork_list): Now a std::list instance.
6901         (fork_info): Add ctor, dtor, and in-class initialize all fields.
6902         (forks_exist_p, find_last_fork): Adjust.
6903         (new_fork): Delete.
6904         (one_fork_p): New.
6905         (add_fork): Adjust.
6906         (free_fork): Delete, folded into fork_info::~fork_info().
6907         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6908         Adjust.
6909         (init_fork_list): Delete.
6910         (linux_fork_killall, linux_fork_mourn_inferior)
6911         (linux_fork_detach, info_checkpoints_command): Adjust.
6912         (_initialize_linux_fork): No longer call init_fork_list.
6913
6914 2019-03-06  Pedro Alves  <palves@redhat.com>
6915
6916         * linux-fork.c (new_fork): New, split out of ...
6917         (add_fork): ... this.  Return void.  Move "first fork" special
6918         case from here, to ...
6919         (checkpoint_command): ... here.
6920         * linux-linux.h (add_fork): Return void.
6921
6922 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6923
6924         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6925
6926 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6927             Chris January  <chris.january@arm.com>
6928             David Lecomber  <david.lecomber@arm.com>
6929
6930         * f-exp.y: New token, UNOP_INTRINSIC.
6931         (exp): New pattern using UNOP_INTRINSIC token.
6932         (f77_keywords): Add 'abs' keyword.
6933         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
6934         (value_from_host_double): New function.
6935         (evaluate_subexp_f): Support UNOP_ABS.
6936
6937 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6938
6939         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
6940         types.
6941
6942 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6943
6944         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
6945         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
6946         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
6947
6948 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6949
6950         * f-exp.y (convert_to_kind_type): Handle more type kinds.
6951
6952 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6953             Chris January  <chris.january@arm.com>
6954
6955         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
6956         * f-exp.y: Define 'KIND' token.
6957         (exp): New pattern for KIND expressions.
6958         (ptype): Handle types with a kind extension.
6959         (direct_abs_decl): Extend to spot kind extensions.
6960         (f77_keywords): Add 'kind' to the list.
6961         (push_kind_type): New function.
6962         (convert_to_kind_type): New function.
6963         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
6964         * parse.c (operator_length_standard): Likewise.
6965         * parser-defs.h (enum type_pieces): Add tp_kind.
6966         * std-operator.def: Add UNOP_KIND.
6967
6968 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6969
6970         * f-exp.y (f_parse): Set yydebug.
6971
6972 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6973
6974         * f-lang.c (evaluate_subexp_f): New function.
6975         (exp_descriptor_f): New global.
6976         (f_language_defn): Use exp_descriptor_f instead of
6977         exp_descriptor_standard.
6978
6979 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6980
6981         * f-exp.y (struct token): Add comments.
6982         (dot_ops): Remove uppercase versions and the end marker.
6983         (f77_keywords): Likewise.
6984         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
6985         entries in the dot_ops array are case insensitive, and use
6986         strncasecmp to compare strings.  Also some whitespace cleanup in
6987         this area.  Similar for the f77_keywords array, except entries in
6988         this list might be case sensitive.
6989
6990 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6991
6992         * f-exp.y (struct f77_boolean_val): Add comments.
6993         (boolean_values): Remove uppercase versions, and end marker.
6994         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
6995         and use strncasecmp to achieve case insensitivity.  Additionally,
6996         perform whitespace cleanup around this code.
6997
6998 2019-03-06  Tom Tromey  <tromey@adacore.com>
6999
7000         * remote-sim.c (gdbsim_target_open): Use result of
7001         gdb_argv::release.
7002
7003 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7004         Dirk Schubert  <dirk.schubert@arm.com>
7005         Chris January  <chris.january@arm.com>
7006
7007         * eval.c (evaluate_subexp_standard): Call Fortran argument
7008         wrapping logic.
7009         * f-lang.c (struct value): A value which can be passed into a
7010         Fortran function call.
7011         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7012         where appropriate.
7013         (struct type): Value ready for a Fortran function call.
7014         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7015         is needed.
7016         * f-lang.h (fortran_argument_convert): Declaration.
7017         (fortran_preserve_arg_pointer): Declaration.
7018         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7019
7020 2019-03-05  Tom Tromey  <tromey@adacore.com>
7021
7022         * python/py-prettyprint.c (print_string_repr): Remove #if.
7023         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7024
7025 2019-03-05  Tom Tromey  <tromey@adacore.com>
7026
7027         * target.c (the_dummy_target): Move later.  Change type to
7028         "dummy_target".
7029         (initialize_targets): Don't initialize the_dummy_target.
7030
7031 2019-03-05  Tom Tromey  <tromey@adacore.com>
7032
7033         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7034         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7035
7036 2019-03-05  Tom Tromey  <tromey@adacore.com>
7037
7038         * windows-nat.c (windows_nat_target::attach)
7039         (windows_nat_target::detach): Don't call gdb_flush.
7040         * valprint.c (generic_val_print, val_print, val_print_string):
7041         Don't call gdb_flush.
7042         * utils.c (defaulted_query): Don't call gdb_flush.
7043         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7044         * target.c (target_announce_detach): Don't call gdb_flush.
7045         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7046         * remote.c (extended_remote_target::attach): Don't call
7047         gdb_flush.
7048         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7049         * printcmd.c (do_examine): Don't call gdb_flush.
7050         (info_display_command): Don't call gdb_flush.
7051         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7052         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7053         * memattr.c (info_mem_command): Don't call gdb_flush.
7054         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7055         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7056         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7057         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7058         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7059         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7060         (gnu_nat_target::detach): Don't call gdb_flush.
7061         * f-valprint.c (f_val_print): Don't call gdb_flush.
7062         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7063         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7064         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7065         gdb_flush.
7066         * c-valprint.c (c_val_print): Don't call gdb_flush.
7067         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7068
7069 2019-03-05  Tom Tromey  <tromey@adacore.com>
7070
7071         * varobj.c (update_dynamic_varobj_children): Update.
7072         (install_default_visualizer): Use reset, not release.
7073         * value.c (set_internalvar): Update.
7074         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7075         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7076         ATTRIBUTE_UNUSED_RESULT.
7077
7078 2019-03-05  Tom Tromey  <tromey@adacore.com>
7079
7080         * remote.c (class scoped_remote_fd) <release>: Add
7081         ATTRIBUTE_UNUSED_RESULT.
7082
7083 2019-03-05  Tom Tromey  <tromey@adacore.com>
7084
7085         * macroexp.c (struct macro_buffer) <release>: Add
7086         ATTRIBUTE_UNUSED_RESULT.
7087
7088 2019-03-05  Tom Tromey  <tromey@adacore.com>
7089
7090         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7091         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7092         ATTRIBUTE_UNUSED_RESULT.
7093
7094 2019-03-05  Tom Tromey  <tromey@adacore.com>
7095
7096         * common/scoped_fd.h (class scoped_fd) <release>: Add
7097         ATTRIBUTE_UNUSED_RESULT.
7098
7099 2019-03-05  Tom Tromey  <tromey@adacore.com>
7100
7101         * parser-defs.h (struct parser_state) <release>: Add
7102         ATTRIBUTE_UNUSED_RESULT.
7103
7104 2019-03-05  Tom Tromey  <tromey@adacore.com>
7105
7106         * utils.h (class gdb_argv) <release>: Add
7107         ATTRIBUTE_UNUSED_RESULT.
7108         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7109
7110 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7111
7112         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7113         for-loop range, to avoid compiler warnings.
7114
7115         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7116         avoid compiler warnings about unused variables.
7117
7118         * NEWS: Mention end of support for native debugging on MS-Windows
7119         before XP.
7120
7121         PR gdb/24292
7122         * common/netstuff.c:
7123         * gdbserver/gdbreplay.c
7124         * gdbserver/remote-utils.c:
7125         * ser-tcp.c:
7126         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7127         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7128         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7129         'getaddrinfo' and 'freeaddrinfo' were not available before
7130         Windows XP, and mingw.org's MinGW headers by default define
7131         _WIN32_WINNT to 0x500.
7132
7133 2019-03-01  Gary Benson <gbenson@redhat.com>
7134
7135         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7136
7137 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7138             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7139
7140         PR gdb/8527
7141         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7142         set_sigint_trap, clear_sigint_trap.
7143
7144 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7145
7146         * target.c (target_detach): Clear the regcache and the
7147         frame cache.
7148
7149 2019-02-27  Pedro Alves  <palves@redhat.com>
7150
7151         * utils.c (set_screen_size): When we cap the height/width sizes,
7152         tweak the corresponding command variable to show "unlimited":
7153
7154 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7155             Pedro Alves  <palves@redhat.com>
7156
7157         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7158         before calling rl_set_screen_size.
7159
7160 2019-02-27  Tom Tromey  <tromey@adacore.com>
7161
7162         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7163         define.
7164         * python/py-value.c: Remove Python 2.4 workaround.
7165         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7166         workaround.
7167         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7168         Python 2.4 workaround.
7169         * python/python-internal.h: Remove Python 2.4 comment.
7170         (Py_ssize_t): Don't define.
7171         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7172         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7173         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7174         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7175         * python/python.c (do_start_initialization): Remove Python 2.4
7176         workaround.
7177         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7178         (print_children): Remove Python 2.4 workaround.
7179         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7180         workaround.
7181         (CHARBUFFERPROC_NAME): Remove.
7182         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7183         Python 2.4 workaround.
7184
7185 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7186
7187         * NEWS: Note minimum Python version.
7188
7189 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7190
7191         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7192         code from these functions.  Remove corresponding ifdefs.  Use
7193         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7194         Remove gotos and target of gotos.
7195         (infpy_search_memory): Likewise.
7196
7197 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7198
7199         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7200         (hppa_gdbarch_init): Don't register deleted functions with
7201         gdbarch.
7202
7203 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7204
7205         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7206         (h8300_unwind_sp): Delete.
7207         (h8300_dummy_id): Delete.
7208         (h8300_gdbarch_init): Don't register deleted functions with
7209         gdbarch.
7210
7211 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7212
7213         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7214         (ft32_unwind_pc): Delete.
7215         (ft32_unwind_sp): Delete.
7216         (ft32_gdbarch_init): Don't register deleted functions with
7217         gdbarch.
7218
7219 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7220
7221         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7222         (frv_unwind_pc): Delete.
7223         (frv_unwind_sp): Delete.
7224         (frv_gdbarch_init): Don't register deleted functions with
7225         gdbarch.
7226
7227 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7228
7229         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7230         (riscv_unwind_pc): Delete.
7231         (riscv_unwind_sp): Delete.
7232         (riscv_gdbarch_init): Don't register deleted functions with
7233         gdbarch.
7234
7235 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7236
7237         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7238         (csky_unwind_pc): Delete.
7239         (csky_unwind_sp): Delete.
7240         (csky_gdbarch_init): Don't register deleted functions with
7241         gdbarch.
7242
7243 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7244
7245         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7246         (cris_unwind_pc): Delete.
7247         (cris_unwind_sp): Delete.
7248         (cris_gdbarch_init): Don't register deleted functions with
7249         gdbarch.
7250
7251 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7252
7253         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7254         (bfin_unwind_pc): Delete.
7255         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7256
7257 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7258
7259         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7260         (arm_unwind_pc): Delete.
7261         (arm_unwind_sp): Delete.
7262         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7263
7264 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7265
7266         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7267         (arc_unwind_pc): Delete.
7268         (arc_unwind_sp): Delete.
7269         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7270
7271 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7272
7273         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7274         (alpha_unwind_pc): Delete.
7275         (alpha_gdbarch_init): Don't register deleted functions with
7276         gdbarch.
7277
7278 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7279
7280         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7281         (aarch64_unwind_pc): Delete.
7282         (aarch64_unwind_sp): Delete.
7283         (aarch64_gdbarch_init): Don't register deleted functions with
7284         gdbarch.
7285
7286 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7287
7288         * gdbtypes.c (type_align): Don't consider static members when
7289         computing structure alignment.
7290
7291 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7292
7293         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7294         return 0 for other types.
7295         * arch-utils.c (default_type_align): Always return 0.
7296         * gdbarch.h: Regenerate.
7297         * gdbarch.sh (type_align): Extend comment.
7298         * gdbtypes.c (type_align): Add additional comments, always call
7299         gdbarch_type_align before applying the default rules.
7300         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7301         generic code will then apply a suitable default.
7302         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7303         types, return 0 for other types.
7304
7305 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7306
7307         * NEWS: Create a new section for the next release branch.
7308         Rename the section of the current branch, now that it has
7309         been cut.
7310
7311 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7312
7313         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7314         * version.in: Bump version to 8.3.50.DATE-git.
7315
7316 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7317
7318         * aix-thread.c (ptid_cmp): Remove unused variable.
7319         (get_signaled_thread): Likewise.
7320         (store_regs_user_thread): Likewise.
7321         (store_regs_kernel_thread): Likewise.
7322         (fetch_regs_kernel_thread): Remove shadowed variable.
7323
7324 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7325
7326         * features/riscv/32bit-cpu.xml: Add register numbers.
7327         * features/riscv/32bit-fpu.c: Regenerate.
7328         * features/riscv/32bit-fpu.xml: Add register numbers.
7329         * features/riscv/64bit-cpu.xml: Add register numbers.
7330         * features/riscv/64bit-fpu.c: Regenerate.
7331         * features/riscv/64bit-fpu.xml: Add register numbers.
7332
7333 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7334
7335         * NEWS: Mention two argument form of gdb.Value constructor.
7336         * python/py-value.c (convert_buffer_and_type_to_value): New
7337         function.
7338         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7339         Add support for handling an optional second argument.  Call
7340         convert_buffer_and_type_to_value as appropriate.
7341         * python/python-internal.h (Py_buffer_deleter): New struct.
7342         (Py_buffer_up): New typedef.
7343
7344 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7345
7346         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7347         instead of releasing ownership.
7348
7349 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7350
7351         * dwarf2read.c (open_and_init_dwp_file): Call
7352         elf_numsections instead of bfd_count_sections to initialize
7353         dwp_file->num_sections.
7354
7355 2019-02-25  Tom Tromey  <tromey@adacore.com>
7356
7357         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7358
7359 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7360
7361         * gcore.in: Add '--readnever' option when invoking GDB.
7362
7363 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7364
7365         * MAINTAINERS: Update my email address.
7366
7367 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7368
7369         * build-id.c (build_id_to_debug_bfd_1): New function.
7370         (build_id_to_debug_bfd): Look for separate debug file in
7371         sysroot.
7372
7373 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7374
7375         * gdbarch.sh: Update the copyright year range that is placed into
7376         generated files.
7377
7378 2019-02-22  Keith Seitz  <keiths@redhat.com>
7379
7380         PR symtab/23853
7381         * linespec.c (create_sals_line_offset): Search for the default
7382         symtab's filename instead of its fullname.
7383
7384 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7385
7386         * NEWS: Update style defaults.
7387
7388 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7389
7390         * main.c (captured_main_1): Disable styling in batch mode.
7391
7392 2019-02-20  Tom Tromey  <tom@tromey.com>
7393
7394         * symtab.c (symtab_symbol_info): Fix typos.
7395
7396 2019-02-20  Tom Tromey  <tromey@adacore.com>
7397
7398         * findcmd.c (_initialize_mem_search): Use upper case for
7399         metasyntactic variables.
7400
7401 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7402
7403         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7404         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7405
7406 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7407
7408         * top.h (source_file_name): Change to std::string.
7409         * top.c (source_file_name): Likewise.
7410         (command_line_input): Adjust.
7411         * cli/cli-script.c (script_from_file): Adjust.
7412
7413 2019-02-19  Tom Tromey  <tromey@adacore.com>
7414
7415         * ravenscar-thread.c
7416         (ravenscar_thread_target::update_thread_list): Don't call
7417         ada_build_task_list.
7418         * ada-lang.h (ada_build_task_list): Don't declare.
7419         * ada-tasks.c (struct ada_tasks_inferior_data)
7420         <task_list_valid_p>: Now bool.
7421         (read_known_tasks, ada_task_list_changed)
7422         (ada_tasks_invalidate_inferior_data): Update.
7423         (read_known_tasks_array): Return bool.
7424         (read_known_tasks_list): Likewise.
7425         (read_known_tasks): Return void.
7426         (ada_build_task_list): Now static.
7427
7428 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7429
7430         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7431         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7432
7433 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7434
7435         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7436         variant for ada_tasks_pspace_data_handle and
7437         ada_tasks_inferior_data_handle.
7438         (ada_tasks_pspace_data_cleanup): New function.
7439         (ada_tasks_inferior_data_cleanup): New function.
7440
7441 2019-02-17  Tom Tromey  <tom@tromey.com>
7442
7443         * macrotab.h (macro_source_fullname): Return a std::string.
7444         * macrotab.c (macro_include, check_for_redefinition)
7445         (macro_undef, macro_lookup_definition, foreach_macro)
7446         (foreach_macro_in_scope): Update.
7447         (macro_source_fullname): Return a std::string.
7448         * macrocmd.c (show_pp_source_pos): Update.
7449
7450 2019-02-17  Tom Tromey  <tom@tromey.com>
7451
7452         * macrocmd.c (show_pp_source_pos): Style the file names.
7453
7454 2019-02-17  Tom Tromey  <tom@tromey.com>
7455
7456         PR tui/24197:
7457         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7458
7459 2019-02-17  Tom Tromey  <tom@tromey.com>
7460
7461         * ada-lang.c (user_select_syms): Use filtered printing.
7462         * utils.c (wrap_style): New global.
7463         (desired_style): Remove.
7464         (emit_style_escape): Add stream parameter.
7465         (set_output_style, reset_terminal_style, prompt_for_continue):
7466         Update.
7467         (flush_wrap_buffer): Only flush gdb_stdout.
7468         (wrap_here): Set wrap_style.
7469         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7470         treat escape sequences as a character.  Change when wrap buffer is
7471         flushed.
7472         (fputs_styled): Do not set the output style when the default is
7473         requested.
7474         * ui-style.h (struct ui_file_style) <is_default>: New method.
7475         * source.c (print_source_lines_base): Emit escape sequences in one
7476         piece.
7477
7478 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7479
7480         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7481         integers and enumeration types.
7482
7483 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7484
7485         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7486         instead of lookup_symbol_in_language
7487         (do_exact_match): New function.
7488         (ada_get_symbol_name_matcher): Return do_exact_match when
7489         doing a verbatim match.
7490
7491 2019-02-15  Tom Tromey  <tromey@adacore.com>
7492
7493         * ravenscar-thread.c (ravenscar_thread_target::resume)
7494         (ravenscar_thread_target::wait): Special case wildcard requests.
7495
7496 2019-02-15  Tom Tromey  <tromey@adacore.com>
7497
7498         * ravenscar-thread.c (base_ptid): Remove.
7499         (struct ravenscar_thread_target) <close>: New method.
7500         <m_base_ptid>: New member.
7501         <update_inferior_ptid, active_task, task_is_currently_active,
7502         runtime_initialized>: Declare methods.
7503         <ravenscar_thread_target>: Add constructor.
7504         (ravenscar_thread_target::task_is_currently_active)
7505         (ravenscar_thread_target::update_inferior_ptid)
7506         (ravenscar_runtime_initialized): Rename.  Now methods.
7507         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7508         (ravenscar_thread_target::update_thread_list): Update.
7509         (ravenscar_thread_target::active_task): Now method.
7510         (ravenscar_thread_target::store_registers)
7511         (ravenscar_thread_target::prepare_to_store)
7512         (ravenscar_thread_target::prepare_to_store)
7513         (ravenscar_thread_target::mourn_inferior): Update.
7514         (ravenscar_inferior_created): Use "new" to create target.
7515         (ravenscar_thread_target::get_ada_task_ptid): Update.
7516         (_initialize_ravenscar): Don't initialize base_ptid.
7517         (ravenscar_ops): Remove global.
7518
7519 2019-02-15  Tom Tromey  <tromey@adacore.com>
7520
7521         * target.h (push_target): Declare new overload.
7522         * target.c (push_target): New overload, taking an rvalue reference.
7523         * remote.c (remote_target::open_1): Use push_target overload.
7524         * corelow.c (core_target_open): Use push_target overload.
7525
7526 2019-02-15  Tom Tromey  <tromey@adacore.com>
7527
7528         * ravenscar-thread.c (is_ravenscar_task)
7529         (ravenscar_task_is_currently_active): Return bool.
7530         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7531         (_initialize_ravenscar): Remove "(void)".
7532         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7533         Return bool.
7534
7535 2019-02-15  Tom Tromey  <tromey@adacore.com>
7536
7537         * ravenscar-thread.c (ravenscar_runtime_initializer)
7538         (has_ravenscar_runtime, get_running_thread_id)
7539         (ravenscar_thread_target::resume): Fix indentation.
7540
7541 2019-02-15  Tom Tromey  <tromey@adacore.com>
7542
7543         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7544         from ravenscar_arch_ops.
7545         (sparc_ravenscar_ops::fetch_registers)
7546         (sparc_ravenscar_ops::store_registers): Now methods.
7547         (sparc_ravenscar_prepare_to_store): Remove.
7548         (sparc_ravenscar_ops): Redefine.
7549         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7550         methods and destructor.  Remove members.
7551         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7552         (ravenscar_thread_target::store_registers)
7553         (ravenscar_thread_target::prepare_to_store): Update.
7554         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7555         Remove.
7556         (struct ppc_ravenscar_powerpc_ops): Derive from
7557         ravenscar_arch_ops.
7558         (ppc_ravenscar_powerpc_ops::fetch_registers)
7559         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7560         (ppc_ravenscar_powerpc_ops): Redefine.
7561         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7562         (ppc_ravenscar_e500_ops::fetch_registers)
7563         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7564         (ppc_ravenscar_e500_ops): Redefine.
7565         * aarch64-ravenscar-thread.c
7566         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7567         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7568         (aarch64_ravenscar_fetch_registers)
7569         (aarch64_ravenscar_store_registers): Now methods.
7570         (aarch64_ravenscar_ops): Redefine.
7571
7572 2019-02-15  Tom Tromey  <tromey@adacore.com>
7573
7574         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7575         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7576         (ravenscar_thread_target::stopped_by_watchpoint)
7577         (ravenscar_thread_target::stopped_data_address)
7578         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7579
7580 2019-02-15  Tom Tromey  <tromey@adacore.com>
7581
7582         * ravenscar-thread.c: Fix some typos.
7583
7584 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7585             Tom Tromey  <tromey@adacore.com>
7586
7587         * ada-lang.c (ada_exception_sal): Change addr_string to a
7588         std::string.
7589         (create_ada_exception_catchpoint): Update.
7590
7591 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7592             Tom Tromey  <tromey@adacore.com>
7593
7594         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7595         (bp_location_ops): Remove.
7596         (base_breakpoint_allocate_location): Update.
7597         (free_bp_location): Update.
7598         * ada-lang.c (class ada_catchpoint_location)
7599         <ada_catchpoint_location>: Remove ops parameter.
7600         (ada_catchpoint_location_dtor): Remove.
7601         (ada_catchpoint_location_ops): Remove.
7602         (allocate_location_exception): Update.
7603         * breakpoint.h (struct bp_location_ops): Remove.
7604         (class bp_location) <bp_location>: Remove bp_location_ops
7605         parameter.
7606         <~bp_location>: Add destructor.
7607         <ops>: Remove.
7608
7609 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7610             Pedro Alves  <palves@redhat.com>
7611
7612         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7613         'PATH_MAX'.
7614
7615 2019-02-14  David Michael  <fedora.dm0@gmail.com>
7616             Samuel Thibault  <samuel.thibault@gnu.org>
7617             Thomas Schwinge  <thomas@codesourcery.com>
7618
7619         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7620         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
7621
7622 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7623
7624         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7625         (check_empty): Use "const char *".
7626
7627         * gnu-nat.c (gnu_nat_target::detach): Instead of
7628         'detach_inferior (pid)' call
7629         'detach_inferior (find_inferior_pid (pid))'.
7630
7631         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7632         'nat/fork-inferior.o'.
7633         * gnu-nat.c: #include "nat/fork-inferior.h".
7634
7635         * gnu-nat.c (gnu_nat_target::detach): Instead of
7636         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
7637         * gnu-nat.h: #include "inf-child.h".
7638         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
7639         'i386_gnu_nat_target::fetch_registers'.
7640         (gnu_store_registers): Rename/move to
7641         'i386_gnu_nat_target::store_registers'.
7642
7643         * config/i386/nm-i386gnu.h: Don't "#include" any files.
7644         * gnu-nat.h (mach_thread_info): New function.
7645         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
7646
7647         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
7648
7649 2019-02-14  Frederic Konrad  <konrad@adacore.com>
7650
7651         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
7652
7653 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
7654
7655         * windows-nat.c (windows_add_thread): Add new parameter
7656         "main_thread_p" with default value set to false.  Update
7657         function documentation as well as all callers.
7658         (windows_delete_thread): Likewise.
7659         (fake_create_process): Update call to windows_add_thread.
7660         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
7661         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
7662         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
7663         call to windows_delete_thread.
7664
7665 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
7666
7667         * MAINTAINERS: Add Andrew Burgess as global maintainer.
7668
7669 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7670
7671         * symfile.c (find_separate_debug_file): Use canonical path of
7672         sysroot with child_path instead of gdb_sysroot if it is valid.
7673
7674 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7675
7676         * symfile.c (find_separate_debug_file): Use child_path to
7677         determine if an object file is under a sysroot.
7678
7679 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7680
7681         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
7682         unittests/child-path-selftests.c.
7683         * common/pathstuff.c (child_path): New function.
7684         * common/pathstuff.h (child_path): New prototype.
7685         * unittests/child-path-selftests.c: New file.
7686
7687 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7688
7689         * symfile.c (find_separate_debug_file): Look for separate debug
7690         files in debug directories under the sysroot.
7691
7692 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7693
7694         * symtab.h (struct minimal_symbol data_p): New const method.
7695         (struct minimal_symbol text_p): Likewise.
7696         * symtab.c (output_source_filename): Use file name style
7697         to print file name.
7698         (print_symbol_info): Likewise.
7699         (print_msymbol_info): Use address style to print addresses.
7700         Use function name style to print executable text symbols.
7701         (expand_symtab_containing_pc): Use data_p.
7702         (find_pc_sect_compunit_symtab): Likewise.
7703
7704 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7705
7706         * breakpoint.c (describe_other_breakpoints): Use address style
7707         to print addresses.
7708         (say_where): Likewise.
7709
7710 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7711
7712         * ada-typeprint.c (print_func_type): Print function name
7713         style to print function name.
7714         * c-typeprint.c (c_print_type_1): Likewise.
7715
7716 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
7717
7718         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
7719         for execve.
7720
7721 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7722
7723         * c-exp.y (direct_abs_decl): Use emplace_back to record the
7724         type_stack.
7725
7726 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
7727
7728         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
7729         TYPE_CODE_REF types.
7730
7731 2019-02-08  Jim Wilson  <jimw@sifive.com>
7732
7733         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
7734         (riscv_linux_fregset): New.
7735         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
7736
7737 2019-02-07  Tom Tromey  <tom@tromey.com>
7738
7739         * thread.c (thread_cancel_execution_command): Update.
7740         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
7741         methods.
7742         (struct thread_fsm_ops): Remove.
7743         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
7744         (thread_fsm_should_stop, thread_fsm_return_value)
7745         (thread_fsm_set_finished, thread_fsm_finished_p)
7746         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
7747         Don't declare.
7748         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
7749         * infrun.c (clear_proceed_status_thread)
7750         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
7751         (print_stop_event): Update.
7752         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
7753         Add constructor.
7754         (step_command_fsm_ops): Remove.
7755         (new_step_command_fsm): Remove.
7756         (step_1): Update.
7757         (step_command_fsm::should_stop): Rename from
7758         step_command_fsm_should_stop.
7759         (step_command_fsm::clean_up): Rename from
7760         step_command_fsm_clean_up.
7761         (step_command_fsm::do_async_reply_reason): Rename from
7762         step_command_fsm_async_reply_reason.
7763         (struct until_next_fsm): Inherit from thread_fsm.  Add
7764         constructor.
7765         (until_next_fsm_ops): Remove.
7766         (new_until_next_fsm): Remove.
7767         (until_next_fsm::should_stop): Rename from
7768         until_next_fsm_should_stop.
7769         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
7770         (until_next_fsm::do_async_reply_reason): Rename from
7771         until_next_fsm_async_reply_reason.
7772         (struct finish_command_fsm): Inherit from thread_fsm.  Add
7773         constructor.  Change type of breakpoint.
7774         (finish_command_fsm_ops): Remove.
7775         (new_finish_command_fsm): Remove.
7776         (finish_command_fsm::should_stop): Rename from
7777         finish_command_fsm_should_stop.
7778         (finish_command_fsm::clean_up): Rename from
7779         finish_command_fsm_clean_up.
7780         (finish_command_fsm::return_value): Rename from
7781         finish_command_fsm_return_value.
7782         (finish_command_fsm::do_async_reply_reason): Rename from
7783         finish_command_fsm_async_reply_reason.
7784         (finish_command): Update.
7785         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
7786         Add constructor.
7787         (call_thread_fsm_ops): Remove.
7788         (call_thread_fsm::call_thread_fsm): Rename from
7789         new_call_thread_fsm.
7790         (call_thread_fsm::should_stop): Rename from
7791         call_thread_fsm_should_stop.
7792         (call_thread_fsm::should_notify_stop): Rename from
7793         call_thread_fsm_should_notify_stop.
7794         (run_inferior_call, call_function_by_hand_dummy): Update.
7795         * cli/cli-interp.c (should_print_stop_to_console): Update.
7796         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
7797         Add constructor.  Change type of location_breakpoint,
7798         caller_breakpoint.
7799         (until_break_fsm_ops): Remove.
7800         (new_until_break_fsm): Remove.
7801         (until_break_fsm::should_stop): Rename from
7802         until_break_fsm_should_stop.
7803         (until_break_fsm::clean_up): Rename from
7804         until_break_fsm_clean_up.
7805         (until_break_fsm::do_async_reply_reason): Rename from
7806         until_break_fsm_async_reply_reason.
7807         (until_break_command): Update.
7808         * thread-fsm.c: Remove.
7809         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
7810
7811 2019-02-07  Tom Tromey  <tom@tromey.com>
7812
7813         * yy-remap.h: Add include guard.
7814         * xtensa-tdep.h: Add include guard.
7815         * xcoffread.h: Rename include guard.
7816         * varobj-iter.h: Add include guard.
7817         * tui/tui.h: Rename include guard.
7818         * tui/tui-winsource.h: Rename include guard.
7819         * tui/tui-wingeneral.h: Rename include guard.
7820         * tui/tui-windata.h: Rename include guard.
7821         * tui/tui-win.h: Rename include guard.
7822         * tui/tui-stack.h: Rename include guard.
7823         * tui/tui-source.h: Rename include guard.
7824         * tui/tui-regs.h: Rename include guard.
7825         * tui/tui-out.h: Rename include guard.
7826         * tui/tui-layout.h: Rename include guard.
7827         * tui/tui-io.h: Rename include guard.
7828         * tui/tui-hooks.h: Rename include guard.
7829         * tui/tui-file.h: Rename include guard.
7830         * tui/tui-disasm.h: Rename include guard.
7831         * tui/tui-data.h: Rename include guard.
7832         * tui/tui-command.h: Rename include guard.
7833         * tic6x-tdep.h: Add include guard.
7834         * target/waitstatus.h: Rename include guard.
7835         * target/wait.h: Rename include guard.
7836         * target/target.h: Rename include guard.
7837         * target/resume.h: Rename include guard.
7838         * target-float.h: Rename include guard.
7839         * stabsread.h: Add include guard.
7840         * rs6000-tdep.h: Add include guard.
7841         * riscv-fbsd-tdep.h: Add include guard.
7842         * regformats/regdef.h: Rename include guard.
7843         * record.h: Rename include guard.
7844         * python/python.h: Rename include guard.
7845         * python/python-internal.h: Rename include guard.
7846         * python/py-stopevent.h: Rename include guard.
7847         * python/py-ref.h: Rename include guard.
7848         * python/py-record.h: Rename include guard.
7849         * python/py-record-full.h: Rename include guard.
7850         * python/py-record-btrace.h: Rename include guard.
7851         * python/py-instruction.h: Rename include guard.
7852         * python/py-events.h: Rename include guard.
7853         * python/py-event.h: Rename include guard.
7854         * procfs.h: Add include guard.
7855         * proc-utils.h: Add include guard.
7856         * p-lang.h: Add include guard.
7857         * or1k-tdep.h: Rename include guard.
7858         * observable.h: Rename include guard.
7859         * nto-tdep.h: Rename include guard.
7860         * nat/x86-linux.h: Rename include guard.
7861         * nat/x86-linux-dregs.h: Rename include guard.
7862         * nat/x86-gcc-cpuid.h: Add include guard.
7863         * nat/x86-dregs.h: Rename include guard.
7864         * nat/x86-cpuid.h: Rename include guard.
7865         * nat/ppc-linux.h: Rename include guard.
7866         * nat/mips-linux-watch.h: Rename include guard.
7867         * nat/linux-waitpid.h: Rename include guard.
7868         * nat/linux-ptrace.h: Rename include guard.
7869         * nat/linux-procfs.h: Rename include guard.
7870         * nat/linux-osdata.h: Rename include guard.
7871         * nat/linux-nat.h: Rename include guard.
7872         * nat/linux-namespaces.h: Rename include guard.
7873         * nat/linux-btrace.h: Rename include guard.
7874         * nat/glibc_thread_db.h: Rename include guard.
7875         * nat/gdb_thread_db.h: Rename include guard.
7876         * nat/gdb_ptrace.h: Rename include guard.
7877         * nat/fork-inferior.h: Rename include guard.
7878         * nat/amd64-linux-siginfo.h: Rename include guard.
7879         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7880         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7881         * nat/aarch64-linux.h: Rename include guard.
7882         * nat/aarch64-linux-hw-point.h: Rename include guard.
7883         * mn10300-tdep.h: Add include guard.
7884         * mips-linux-tdep.h: Add include guard.
7885         * mi/mi-parse.h: Rename include guard.
7886         * mi/mi-out.h: Rename include guard.
7887         * mi/mi-main.h: Rename include guard.
7888         * mi/mi-interp.h: Rename include guard.
7889         * mi/mi-getopt.h: Rename include guard.
7890         * mi/mi-console.h: Rename include guard.
7891         * mi/mi-common.h: Rename include guard.
7892         * mi/mi-cmds.h: Rename include guard.
7893         * mi/mi-cmd-break.h: Rename include guard.
7894         * m2-lang.h: Add include guard.
7895         * location.h: Rename include guard.
7896         * linux-record.h: Rename include guard.
7897         * linux-nat.h: Add include guard.
7898         * linux-fork.h: Add include guard.
7899         * i386-darwin-tdep.h: Rename include guard.
7900         * hppa-linux-offsets.h: Add include guard.
7901         * guile/guile.h: Rename include guard.
7902         * guile/guile-internal.h: Rename include guard.
7903         * gnu-nat.h: Rename include guard.
7904         * gdb-stabs.h: Rename include guard.
7905         * frv-tdep.h: Add include guard.
7906         * f-lang.h: Add include guard.
7907         * event-loop.h: Add include guard.
7908         * darwin-nat.h: Rename include guard.
7909         * cp-abi.h: Rename include guard.
7910         * config/sparc/nm-sol2.h: Rename include guard.
7911         * config/nm-nto.h: Rename include guard.
7912         * config/nm-linux.h: Add include guard.
7913         * config/i386/nm-i386gnu.h: Rename include guard.
7914         * config/djgpp/nl_types.h: Rename include guard.
7915         * config/djgpp/langinfo.h: Rename include guard.
7916         * compile/gcc-cp-plugin.h: Add include guard.
7917         * compile/gcc-c-plugin.h: Add include guard.
7918         * compile/compile.h: Rename include guard.
7919         * compile/compile-object-run.h: Rename include guard.
7920         * compile/compile-object-load.h: Rename include guard.
7921         * compile/compile-internal.h: Rename include guard.
7922         * compile/compile-cplus.h: Rename include guard.
7923         * compile/compile-c.h: Rename include guard.
7924         * common/xml-utils.h: Rename include guard.
7925         * common/x86-xstate.h: Rename include guard.
7926         * common/version.h: Rename include guard.
7927         * common/vec.h: Rename include guard.
7928         * common/tdesc.h: Rename include guard.
7929         * common/selftest.h: Rename include guard.
7930         * common/scoped_restore.h: Rename include guard.
7931         * common/scoped_mmap.h: Rename include guard.
7932         * common/scoped_fd.h: Rename include guard.
7933         * common/safe-iterator.h: Rename include guard.
7934         * common/run-time-clock.h: Rename include guard.
7935         * common/refcounted-object.h: Rename include guard.
7936         * common/queue.h: Rename include guard.
7937         * common/ptid.h: Rename include guard.
7938         * common/print-utils.h: Rename include guard.
7939         * common/preprocessor.h: Rename include guard.
7940         * common/pathstuff.h: Rename include guard.
7941         * common/observable.h: Rename include guard.
7942         * common/netstuff.h: Rename include guard.
7943         * common/job-control.h: Rename include guard.
7944         * common/host-defs.h: Rename include guard.
7945         * common/gdb_wait.h: Rename include guard.
7946         * common/gdb_vecs.h: Rename include guard.
7947         * common/gdb_unlinker.h: Rename include guard.
7948         * common/gdb_unique_ptr.h: Rename include guard.
7949         * common/gdb_tilde_expand.h: Rename include guard.
7950         * common/gdb_sys_time.h: Rename include guard.
7951         * common/gdb_string_view.h: Rename include guard.
7952         * common/gdb_splay_tree.h: Rename include guard.
7953         * common/gdb_setjmp.h: Rename include guard.
7954         * common/gdb_ref_ptr.h: Rename include guard.
7955         * common/gdb_optional.h: Rename include guard.
7956         * common/gdb_locale.h: Rename include guard.
7957         * common/gdb_assert.h: Rename include guard.
7958         * common/filtered-iterator.h: Rename include guard.
7959         * common/filestuff.h: Rename include guard.
7960         * common/fileio.h: Rename include guard.
7961         * common/environ.h: Rename include guard.
7962         * common/common-utils.h: Rename include guard.
7963         * common/common-types.h: Rename include guard.
7964         * common/common-regcache.h: Rename include guard.
7965         * common/common-inferior.h: Rename include guard.
7966         * common/common-gdbthread.h: Rename include guard.
7967         * common/common-exceptions.h: Rename include guard.
7968         * common/common-defs.h: Rename include guard.
7969         * common/common-debug.h: Rename include guard.
7970         * common/cleanups.h: Rename include guard.
7971         * common/buffer.h: Rename include guard.
7972         * common/btrace-common.h: Rename include guard.
7973         * common/break-common.h: Rename include guard.
7974         * cli/cli-utils.h: Rename include guard.
7975         * cli/cli-style.h: Rename include guard.
7976         * cli/cli-setshow.h: Rename include guard.
7977         * cli/cli-script.h: Rename include guard.
7978         * cli/cli-interp.h: Rename include guard.
7979         * cli/cli-decode.h: Rename include guard.
7980         * cli/cli-cmds.h: Rename include guard.
7981         * charset-list.h: Add include guard.
7982         * buildsym-legacy.h: Rename include guard.
7983         * bfin-tdep.h: Add include guard.
7984         * ax.h: Rename include guard.
7985         * arm-linux-tdep.h: Add include guard.
7986         * arm-fbsd-tdep.h: Add include guard.
7987         * arch/xtensa.h: Rename include guard.
7988         * arch/tic6x.h: Add include guard.
7989         * arch/i386.h: Add include guard.
7990         * arch/arm.h: Rename include guard.
7991         * arch/arm-linux.h: Rename include guard.
7992         * arch/arm-get-next-pcs.h: Rename include guard.
7993         * arch/amd64.h: Add include guard.
7994         * arch/aarch64-insn.h: Rename include guard.
7995         * arch-utils.h: Rename include guard.
7996         * annotate.h: Add include guard.
7997         * amd64-darwin-tdep.h: Rename include guard.
7998         * aarch64-linux-tdep.h: Add include guard.
7999         * aarch64-fbsd-tdep.h: Add include guard.
8000         * aarch32-linux-nat.h: Add include guard.
8001
8002 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8003
8004         * macrotab.c (macro_define_internal): New function that
8005         factorizes macro_define_object_internal and macro_define_function
8006         code.
8007         (macro_define_object_internal): Use macro_define_internal.
8008         (macro_define_function): Likewise.
8009
8010 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8011
8012         * macrocmd.c (extract_identifier): Return
8013         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8014         callers.
8015
8016 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8017
8018         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8019
8020 2019-02-05  Tom Tromey  <tom@tromey.com>
8021
8022         * target.c (target_stack::unpush): Move assertion earlier.
8023
8024 2019-01-30  Tom Tromey  <tom@tromey.com>
8025
8026         PR python/23615:
8027         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8028         (gdbpy_parse_and_eval): Likewise.
8029         * python/python-internal.h (gdbpy_allow_threads): New class.
8030
8031 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8032
8033         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8034         (aarch64_fbsd_fpregmap): Move earlier.
8035         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8036         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8037         instead of individual calls to trad_frame_set_reg_addr.
8038         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8039         earlier.
8040         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8041         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8042         instead of individual calls to trad_frame_set_reg_addr.
8043
8044 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8045
8046         * CONTRIBUTE: Replace contribution list with wiki link.
8047
8048 2019-01-25  Tom Tromey  <tom@tromey.com>
8049
8050         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8051
8052 2019-01-25  Tom Tromey  <tom@tromey.com>
8053
8054         * xtensa-linux-nat.c: Fix common/ includes.
8055         * xml-support.h: Fix common/ includes.
8056         * xml-support.c: Fix common/ includes.
8057         * x86-linux-nat.c: Fix common/ includes.
8058         * windows-nat.c: Fix common/ includes.
8059         * varobj.h: Fix common/ includes.
8060         * varobj.c: Fix common/ includes.
8061         * value.c: Fix common/ includes.
8062         * valops.c: Fix common/ includes.
8063         * utils.c: Fix common/ includes.
8064         * unittests/xml-utils-selftests.c: Fix common/ includes.
8065         * unittests/utils-selftests.c: Fix common/ includes.
8066         * unittests/unpack-selftests.c: Fix common/ includes.
8067         * unittests/tracepoint-selftests.c: Fix common/ includes.
8068         * unittests/style-selftests.c: Fix common/ includes.
8069         * unittests/string_view-selftests.c: Fix common/ includes.
8070         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8071         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8072         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8073         * unittests/rsp-low-selftests.c: Fix common/ includes.
8074         * unittests/parse-connection-spec-selftests.c: Fix common/
8075         includes.
8076         * unittests/optional-selftests.c: Fix common/ includes.
8077         * unittests/offset-type-selftests.c: Fix common/ includes.
8078         * unittests/observable-selftests.c: Fix common/ includes.
8079         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8080         * unittests/memrange-selftests.c: Fix common/ includes.
8081         * unittests/memory-map-selftests.c: Fix common/ includes.
8082         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8083         * unittests/function-view-selftests.c: Fix common/ includes.
8084         * unittests/environ-selftests.c: Fix common/ includes.
8085         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8086         * unittests/common-utils-selftests.c: Fix common/ includes.
8087         * unittests/cli-utils-selftests.c: Fix common/ includes.
8088         * unittests/array-view-selftests.c: Fix common/ includes.
8089         * ui-file.c: Fix common/ includes.
8090         * tui/tui-io.c: Fix common/ includes.
8091         * tracepoint.h: Fix common/ includes.
8092         * tracepoint.c: Fix common/ includes.
8093         * tracefile-tfile.c: Fix common/ includes.
8094         * top.h: Fix common/ includes.
8095         * top.c: Fix common/ includes.
8096         * thread.c: Fix common/ includes.
8097         * target/waitstatus.h: Fix common/ includes.
8098         * target/waitstatus.c: Fix common/ includes.
8099         * target.h: Fix common/ includes.
8100         * target.c: Fix common/ includes.
8101         * target-memory.c: Fix common/ includes.
8102         * target-descriptions.c: Fix common/ includes.
8103         * symtab.h: Fix common/ includes.
8104         * symfile.c: Fix common/ includes.
8105         * stap-probe.c: Fix common/ includes.
8106         * spu-linux-nat.c: Fix common/ includes.
8107         * sparc-nat.c: Fix common/ includes.
8108         * source.c: Fix common/ includes.
8109         * solib.c: Fix common/ includes.
8110         * solib-target.c: Fix common/ includes.
8111         * ser-unix.c: Fix common/ includes.
8112         * ser-tcp.c: Fix common/ includes.
8113         * ser-pipe.c: Fix common/ includes.
8114         * ser-base.c: Fix common/ includes.
8115         * selftest-arch.c: Fix common/ includes.
8116         * s12z-tdep.c: Fix common/ includes.
8117         * rust-exp.y: Fix common/ includes.
8118         * rs6000-aix-tdep.c: Fix common/ includes.
8119         * riscv-tdep.c: Fix common/ includes.
8120         * remote.c: Fix common/ includes.
8121         * remote-notif.h: Fix common/ includes.
8122         * remote-fileio.h: Fix common/ includes.
8123         * remote-fileio.c: Fix common/ includes.
8124         * regcache.h: Fix common/ includes.
8125         * regcache.c: Fix common/ includes.
8126         * record-btrace.c: Fix common/ includes.
8127         * python/python.c: Fix common/ includes.
8128         * python/py-type.c: Fix common/ includes.
8129         * python/py-inferior.c: Fix common/ includes.
8130         * progspace.h: Fix common/ includes.
8131         * producer.c: Fix common/ includes.
8132         * procfs.c: Fix common/ includes.
8133         * proc-api.c: Fix common/ includes.
8134         * printcmd.c: Fix common/ includes.
8135         * ppc-linux-nat.c: Fix common/ includes.
8136         * parser-defs.h: Fix common/ includes.
8137         * osdata.c: Fix common/ includes.
8138         * obsd-nat.c: Fix common/ includes.
8139         * nat/x86-linux.c: Fix common/ includes.
8140         * nat/x86-linux-dregs.c: Fix common/ includes.
8141         * nat/x86-dregs.h: Fix common/ includes.
8142         * nat/x86-dregs.c: Fix common/ includes.
8143         * nat/ppc-linux.c: Fix common/ includes.
8144         * nat/mips-linux-watch.h: Fix common/ includes.
8145         * nat/mips-linux-watch.c: Fix common/ includes.
8146         * nat/linux-waitpid.c: Fix common/ includes.
8147         * nat/linux-ptrace.h: Fix common/ includes.
8148         * nat/linux-ptrace.c: Fix common/ includes.
8149         * nat/linux-procfs.c: Fix common/ includes.
8150         * nat/linux-personality.c: Fix common/ includes.
8151         * nat/linux-osdata.c: Fix common/ includes.
8152         * nat/linux-namespaces.c: Fix common/ includes.
8153         * nat/linux-btrace.h: Fix common/ includes.
8154         * nat/linux-btrace.c: Fix common/ includes.
8155         * nat/fork-inferior.c: Fix common/ includes.
8156         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8157         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8158         * nat/aarch64-linux.c: Fix common/ includes.
8159         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8160         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8161         * namespace.h: Fix common/ includes.
8162         * mips-linux-tdep.c: Fix common/ includes.
8163         * minsyms.c: Fix common/ includes.
8164         * mi/mi-parse.h: Fix common/ includes.
8165         * mi/mi-main.c: Fix common/ includes.
8166         * mi/mi-cmd-env.c: Fix common/ includes.
8167         * memrange.h: Fix common/ includes.
8168         * memattr.c: Fix common/ includes.
8169         * maint.h: Fix common/ includes.
8170         * maint.c: Fix common/ includes.
8171         * main.c: Fix common/ includes.
8172         * machoread.c: Fix common/ includes.
8173         * location.c: Fix common/ includes.
8174         * linux-thread-db.c: Fix common/ includes.
8175         * linux-nat.c: Fix common/ includes.
8176         * linux-fork.c: Fix common/ includes.
8177         * inline-frame.c: Fix common/ includes.
8178         * infrun.c: Fix common/ includes.
8179         * inflow.c: Fix common/ includes.
8180         * inferior.h: Fix common/ includes.
8181         * inferior.c: Fix common/ includes.
8182         * infcmd.c: Fix common/ includes.
8183         * inf-ptrace.c: Fix common/ includes.
8184         * inf-child.c: Fix common/ includes.
8185         * ia64-linux-nat.c: Fix common/ includes.
8186         * i387-tdep.c: Fix common/ includes.
8187         * i386-tdep.c: Fix common/ includes.
8188         * i386-linux-tdep.c: Fix common/ includes.
8189         * i386-linux-nat.c: Fix common/ includes.
8190         * i386-go32-tdep.c: Fix common/ includes.
8191         * i386-fbsd-tdep.c: Fix common/ includes.
8192         * i386-fbsd-nat.c: Fix common/ includes.
8193         * guile/scm-type.c: Fix common/ includes.
8194         * guile/guile.c: Fix common/ includes.
8195         * go32-nat.c: Fix common/ includes.
8196         * gnu-nat.c: Fix common/ includes.
8197         * gdbthread.h: Fix common/ includes.
8198         * gdbarch-selftests.c: Fix common/ includes.
8199         * gdb_usleep.c: Fix common/ includes.
8200         * gdb_select.h: Fix common/ includes.
8201         * gdb_bfd.c: Fix common/ includes.
8202         * gcore.c: Fix common/ includes.
8203         * fork-child.c: Fix common/ includes.
8204         * findvar.c: Fix common/ includes.
8205         * fbsd-nat.c: Fix common/ includes.
8206         * event-top.c: Fix common/ includes.
8207         * event-loop.c: Fix common/ includes.
8208         * dwarf2read.c: Fix common/ includes.
8209         * dwarf2loc.c: Fix common/ includes.
8210         * dwarf2-frame.c: Fix common/ includes.
8211         * dwarf-index-cache.c: Fix common/ includes.
8212         * dtrace-probe.c: Fix common/ includes.
8213         * disasm-selftests.c: Fix common/ includes.
8214         * defs.h: Fix common/ includes.
8215         * csky-tdep.c: Fix common/ includes.
8216         * cp-valprint.c: Fix common/ includes.
8217         * cp-support.h: Fix common/ includes.
8218         * cp-support.c: Fix common/ includes.
8219         * corelow.c: Fix common/ includes.
8220         * completer.h: Fix common/ includes.
8221         * completer.c: Fix common/ includes.
8222         * compile/compile.c: Fix common/ includes.
8223         * compile/compile-loc2c.c: Fix common/ includes.
8224         * compile/compile-cplus-types.c: Fix common/ includes.
8225         * compile/compile-cplus-symbols.c: Fix common/ includes.
8226         * command.h: Fix common/ includes.
8227         * cli/cli-dump.c: Fix common/ includes.
8228         * cli/cli-cmds.c: Fix common/ includes.
8229         * charset.c: Fix common/ includes.
8230         * build-id.c: Fix common/ includes.
8231         * btrace.h: Fix common/ includes.
8232         * btrace.c: Fix common/ includes.
8233         * breakpoint.h: Fix common/ includes.
8234         * breakpoint.c: Fix common/ includes.
8235         * ax.h:
8236         (enum agent_op): Fix common/ includes.
8237         * ax-general.c (struct aop_map): Fix common/ includes.
8238         * ax-gdb.c: Fix common/ includes.
8239         * auxv.c: Fix common/ includes.
8240         * auto-load.c: Fix common/ includes.
8241         * arm-tdep.c: Fix common/ includes.
8242         * arch/riscv.c: Fix common/ includes.
8243         * arch/ppc-linux-common.c: Fix common/ includes.
8244         * arch/i386.c: Fix common/ includes.
8245         * arch/arm.c: Fix common/ includes.
8246         * arch/arm-linux.c: Fix common/ includes.
8247         * arch/arm-get-next-pcs.c: Fix common/ includes.
8248         * arch/amd64.c: Fix common/ includes.
8249         * arch/aarch64.c: Fix common/ includes.
8250         * arch/aarch64-insn.c: Fix common/ includes.
8251         * arch-utils.c: Fix common/ includes.
8252         * amd64-windows-tdep.c: Fix common/ includes.
8253         * amd64-tdep.c: Fix common/ includes.
8254         * amd64-sol2-tdep.c: Fix common/ includes.
8255         * amd64-obsd-tdep.c: Fix common/ includes.
8256         * amd64-nbsd-tdep.c: Fix common/ includes.
8257         * amd64-linux-tdep.c: Fix common/ includes.
8258         * amd64-linux-nat.c: Fix common/ includes.
8259         * amd64-fbsd-tdep.c: Fix common/ includes.
8260         * amd64-fbsd-nat.c: Fix common/ includes.
8261         * amd64-dicos-tdep.c: Fix common/ includes.
8262         * amd64-darwin-tdep.c: Fix common/ includes.
8263         * agent.c: Fix common/ includes.
8264         * ada-lang.h: Fix common/ includes.
8265         * ada-lang.c: Fix common/ includes.
8266         * aarch64-tdep.c: Fix common/ includes.
8267
8268 2019-01-25  Tom Tromey  <tom@tromey.com>
8269
8270         * common/create-version.sh: Use common/version.h.
8271
8272 2019-01-24  Pedro Alves  <palves@redhat.com>
8273
8274         * infrun.c (signal_stop, signal_print, signal_program)
8275         (signal_catch, signal_pass): Now arrays instead of pointers.
8276         (update_signals_program_target, do_target_resume)
8277         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8278         * linux-nat.c (linux_nat_target::pass_signals)
8279         (linux_nat_target::create_inferior, linux_nat_target::attach):
8280         Adjust.
8281         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8282         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8283         * procfs.c (procfs_target::pass_signals): Adjust.
8284         * record-full.c (record_full_target::resume): Adjust.
8285         * remote.c (remote_target::pass_signals)
8286         (remote_target::program_signals): Adjust.
8287         * target-debug.h (target_debug_print_signals): Now takes a
8288         gdb::array_view as parameter.  Adjust.
8289         * target.h (target_ops) <pass_signals, program_signals>: Replace
8290         pointer and length parameters with gdb::array_view.
8291         (target_pass_signals, target_program_signals): Likewise.
8292         * target-delegates.c: Regenerate.
8293
8294 2019-01-24  Pedro Alves  <palves@redhat.com>
8295
8296         * common/forward-scope-exit.h
8297         (forward_scope_exit::forward_scope_exit): Pass arguments to
8298         m_bind_function directly, instead of creating a std::bind and
8299         copying that.
8300
8301 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8302
8303         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8304         for static members.
8305         (pass_in_v_vfp_candidate): Likewise.
8306
8307 2019-01-23  Tom Tromey  <tom@tromey.com>
8308             Pedro Alves  <palves@redhat.com>
8309
8310         * regcache.c (class regcache_invalidator): Remove.
8311         (regcache::raw_write): Use make_scope_exit.
8312
8313 2019-01-23  Tom Tromey  <tom@tromey.com>
8314
8315         * ui-out.h (class ui_out_emit_type): Update comment.
8316
8317 2019-01-23  Tom Tromey  <tom@tromey.com>
8318
8319         * infrun.c (fetch_inferior_event): Update comment.
8320
8321 2019-01-23  Tom Tromey  <tom@tromey.com>
8322             Pedro Alves  <palves@redhat.com>
8323
8324         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8325         parameter.
8326         (fetch_inferior_event): Use SCOPE_EXIT.
8327
8328
8329 2019-01-23  Tom Tromey  <tom@tromey.com>
8330             Pedro Alves  <palves@redhat.com>
8331
8332         * infrun.c (disable_thread_events): Delete.
8333         (stop_all_threads): Use SCOPE_EXIT.
8334
8335 2019-01-23  Tom Tromey  <tom@tromey.com>
8336             Pedro Alves  <palves@redhat.com>
8337
8338         * symfile.c: Include forward-scope-exit.h.
8339         (clear_symtab_users_cleanup): Replace forward declaration with
8340         a FORWARD_SCOPE_EXIT.
8341         (syms_from_objfile_1): Use the forward_scope_exit and
8342         gdb::optional instead of cleanup_function.
8343         (reread_symbols): Use the forward_scope_exit instead of
8344         cleanup_function.
8345         (clear_symtab_users_cleanup): Remove function.
8346
8347 2019-01-23  Tom Tromey  <tom@tromey.com>
8348             Pedro Alves  <palves@redhat.com>
8349
8350         * linux-nat.c: Include scope-exit.h.
8351         (cleanup_target_stop): Remove.
8352         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8353         SCOPE_EXIT.
8354
8355 2019-01-23  Tom Tromey  <tom@tromey.com>
8356             Pedro Alves  <palves@redhat.com>
8357
8358         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8359         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8360
8361 2019-01-23  Tom Tromey  <tom@tromey.com>
8362             Andrew Burgess  <andrew.burgess@embecosm.com>
8363             Pedro Alves  <palves@redhat.com>
8364
8365         * infrun.c (fetch_inferior_event): Use scope_exit.
8366         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8367         * top.c (execute_command): Use scope_exit.
8368         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8369         * utils.c (do_bpstat_clear_actions_cleanup)
8370         (make_bpstat_clear_actions_cleanup): Remove.
8371
8372 2019-01-23  Tom Tromey  <tom@tromey.com>
8373             Pedro Alves  <palves@redhat.com>
8374
8375         * infrun.c: Include "common/scope-exit.h"
8376         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8377         (wait_for_inferior): Use SCOPE_EXIT.
8378         (fetch_inferior_event): Use scope_exit.
8379
8380 2019-01-23  Tom Tromey  <tom@tromey.com>
8381             Pedro Alves  <palves@redhat.com>
8382
8383         * breakpoint.c (create_breakpoint): Remove cleanup.
8384
8385 2019-01-23  Tom Tromey  <tom@tromey.com>
8386             Andrew Burgess  <andrew.burgess@embecosm.com>
8387             Pedro Alves  <palves@redhat.com>
8388
8389 2019-01-23  Pedro Alves  <palves@redhat.com>
8390
8391         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8392
8393 2019-01-23  Pedro Alves  <palves@redhat.com>
8394             Andrew Burgess  <andrew.burgess@embecosm.com>
8395
8396         * gdbthread.h: Include "common/forward-scope-exit.h".
8397         (scoped_finish_thread_state): Redefine custom class in terms of
8398         forward_scope_exit.
8399
8400 2019-01-23  Pedro Alves  <palves@redhat.com>
8401             Andrew Burgess  <andrew.burgess@embecosm.com>
8402
8403         * common/forward-scope-exit.h: New file.
8404
8405 2019-01-23  Pedro Alves  <palves@redhat.com>
8406             Andrew Burgess  <andrew.burgess@embecosm.com>
8407             Tom Tromey  <tom@tromey.com>
8408
8409         * common/scope-exit.h: New file.
8410
8411 2019-01-23  Pedro Alves  <palves@redhat.com>
8412
8413         * common/preprocessor.h (ESC): Rename to ...
8414         (ESC_PARENS): ... this.
8415         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8416         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8417
8418 2019-01-23  Tom Tromey  <tom@tromey.com>
8419
8420         * language.h (class scoped_switch_to_sym_language_if_auto):
8421         Initialize m_lang in both cases.
8422
8423 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8424
8425         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8426         with XCNEW.
8427
8428 2019-01-22  Tom Tromey  <tom@tromey.com>
8429
8430         * corelow.c: Do not include sys/file.h.
8431
8432 2019-01-22  Tom Tromey  <tom@tromey.com>
8433
8434         * tui/tui-wingeneral.h: Include gdb_curses.h.
8435
8436 2019-01-22  Tom Tromey  <tom@tromey.com>
8437
8438         * source-cache.h (class source_cache) <get_source_lines,
8439         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8440
8441 2019-01-22  Tom Tromey  <tom@tromey.com>
8442
8443         * remote-fileio.h (struct remote_target): Declare.
8444
8445 2019-01-22  Tom Tromey  <tom@tromey.com>
8446
8447         * python/py-arch.c: Do not include py-ref.h.
8448         * python/py-bpevent.c: Do not include py-ref.h.
8449         * python/py-cmd.c: Do not include py-ref.h.
8450         * python/py-continueevent.c: Do not include py-ref.h.
8451         * python/py-event.h: Do not include py-ref.h.
8452         * python/py-evtregistry.c: Do not include py-ref.h.
8453         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8454         * python/py-frame.c: Do not include py-ref.h.
8455         * python/py-framefilter.c: Do not include py-ref.h.
8456         * python/py-function.c: Do not include py-ref.h.
8457         * python/py-infevents.c: Do not include py-ref.h.
8458         * python/py-linetable.c: Do not include py-ref.h.
8459         * python/py-objfile.c: Do not include py-ref.h.
8460         * python/py-param.c: Do not include py-ref.h.
8461         * python/py-prettyprint.c: Do not include py-ref.h.
8462         * python/py-progspace.c: Do not include py-ref.h.
8463         * python/py-symbol.c: Do not include py-ref.h.
8464         * python/py-symtab.c: Do not include py-ref.h.
8465         * python/py-type.c: Do not include py-ref.h.
8466         * python/py-unwind.c: Do not include py-ref.h.
8467         * python/py-utils.c: Do not include py-ref.h.
8468         * python/py-value.c: Do not include py-ref.h.
8469         * python/py-varobj.c: Do not include py-ref.h.
8470         * python/py-xmethods.c: Do not include py-ref.h.
8471         * python/python.c: Do not include py-ref.h.
8472         * varobj.c: Do not include py-ref.h.
8473
8474 2019-01-22  Tom Tromey  <tom@tromey.com>
8475
8476         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8477         keyword for bcache.
8478
8479 2019-01-22  Tom Tromey  <tom@tromey.com>
8480
8481         * compile/compile-cplus-types.c: Remove a comment by #include.
8482
8483 2019-01-22  Tom Tromey  <tom@tromey.com>
8484
8485         * compile/gcc-c-plugin.h: Include compile-internal.h.
8486
8487 2019-01-22  Tom Tromey  <tom@tromey.com>
8488
8489         * stabsread.c (EXTERN): Do not define.
8490         (symnum, next_symbol_text_func, processing_gcc_compilation)
8491         (within_function, global_sym_chain, global_stabs)
8492         (previous_stab_code, this_object_header_files)
8493         (n_this_object_header_files)
8494         (n_allocated_this_object_header_files): Define.
8495         * stabsread.h (EXTERN): Never define.  Use "extern".
8496
8497 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8498
8499         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8500         history_value.
8501
8502 2019-01-21  Tom Tromey  <tom@tromey.com>
8503
8504         * ui-out.c: Fix includes.
8505         * tui/tui-source.c: Fix includes.
8506         * target.c: Fix includes.
8507         * remote.c: Fix includes.
8508         * regcache.c: Fix includes.
8509         * python/py-block.c: Fix includes.
8510         * printcmd.c: Fix includes.
8511         * or1k-tdep.c: Fix includes.
8512         * mi/mi-main.c: Fix includes.
8513         * m32r-tdep.c: Fix includes.
8514         * csky-tdep.c: Fix includes.
8515         * compile/compile-cplus-types.c: Fix includes.
8516         * cli/cli-interp.c: Fix includes.
8517
8518 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8519
8520         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8521         for padding.
8522
8523 2019-01-16  Tom Tromey  <tom@tromey.com>
8524
8525         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8526         earlier.
8527         (struct objfile) <msymbols_range>: Move from top level.
8528         <msymbols>: New method.
8529         (class objfile_msymbols): Remove.
8530         * symtab.c (default_collect_symbol_completion_matches_break_on):
8531         Update.
8532         * symmisc.c (dump_msymbols): Update.
8533         * stabsread.c (scan_file_globals): Update.
8534         * objc-lang.c (info_selectors_command, info_classes_command)
8535         (find_methods): Update.
8536         * minsyms.c (find_solib_trampoline_target): Update.
8537         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8538         * coffread.c (coff_symfile_read): Update.
8539         * ada-lang.c (ada_lookup_simple_minsym)
8540         (ada_collect_symbol_completion_matches): Update.
8541
8542 2019-01-16  Tom Tromey  <tom@tromey.com>
8543
8544         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8545         type.  Remove no-argument constructor.
8546         <iterator::operator++>: Simplify.
8547         <begin>: Update.
8548         <end>: Use minimal_symbol_count.
8549
8550 2019-01-16  Tom Tromey  <tom@tromey.com>
8551
8552         * objfiles.h (struct objfile) <psymtabs>: New method.
8553         (class objfile_psymtabs): Remove.
8554         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8555         typedef.
8556         <range>: New method.
8557         (require_partial_symbols): Change return type.
8558         * psymtab.c (require_partial_symbols)
8559         (psym_expand_symtabs_matching): Update.
8560         * mdebugread.c (parse_partial_symbols): Update.
8561         * dbxread.c (dbx_end_psymtab): Update.
8562
8563 2019-01-15  Tom Tromey  <tom@tromey.com>
8564
8565         * symtab.c (lookup_objfile_from_block)
8566         (lookup_symbol_in_objfile_symtabs)
8567         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8568         (find_line_symtab, info_sources_command)
8569         (default_collect_symbol_completion_matches_break_on)
8570         (make_source_files_completion_list): Update.
8571         * symmisc.c (print_objfile_statistics, dump_objfile)
8572         (maintenance_print_symbols, maintenance_info_symtabs)
8573         (maintenance_check_symtabs, maintenance_info_line_tables):
8574         Update.
8575         * source.c (select_source_symtab)
8576         (forget_cached_source_info_for_objfile): Update.
8577         * objfiles.h (class objfile_compunits): Remove.
8578         (struct objfile) <compunits_range>: New typedef.
8579         (compunits): New method.
8580         * objfiles.c (objfile_relocate1): Update.
8581         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8582         * maint.c (count_symtabs_and_blocks): Update.
8583         * linespec.c (iterate_over_all_matching_symtabs): Update.
8584         * cp-support.c (add_symbol_overload_list_qualified): Update.
8585         * coffread.c (coff_symtab_read): Update.
8586         * ada-lang.c (add_nonlocal_symbols)
8587         (ada_collect_symbol_completion_matches)
8588         (ada_add_global_exceptions): Update.
8589
8590 2019-01-15  Tom Tromey  <tom@tromey.com>
8591
8592         * progspace.h (program_space) <objfiles_safe_range>: New
8593         typedef.
8594         <objfiles_safe>: New method.
8595         * objfiles.h (class all_objfiles_safe): Remove.
8596         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8597         * jit.c (jit_inferior_exit_hook): Update.
8598
8599 2019-01-17  Tom Tromey  <tom@tromey.com>
8600
8601         * progspace.h (program_space) <objfiles_range>: New typedef.
8602         <objfiles>: New method.
8603         <objfiles_head>: Rename from objfiles.
8604         (object_files): Update.
8605         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8606         * guile/scm-pretty-print.c
8607         (ppscm_find_pretty_printer_from_objfiles): Update.
8608         * guile/scm-objfile.c (gdbscm_objfiles): Update.
8609         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8610         Update.
8611         * python/py-progspace.c (pspy_get_objfiles): Update.
8612         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8613         Update.
8614         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8615         (objfpy_lookup_objfile_by_build_id): Update.
8616         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8617         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8618         Update.
8619         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8620         (expand_symtab_containing_pc, lookup_objfile_from_block)
8621         (lookup_static_symbol, basic_lookup_transparent_type)
8622         (find_pc_sect_compunit_symtab, find_symbol_at_address)
8623         (find_line_symtab, info_sources_command)
8624         (default_collect_symbol_completion_matches_break_on)
8625         (make_source_files_completion_list, find_main_name): Update.
8626         * symmisc.c (print_symbol_bcache_statistics)
8627         (print_objfile_statistics, maintenance_print_symbols)
8628         (maintenance_print_msymbols, maintenance_print_objfiles)
8629         (maintenance_info_symtabs, maintenance_check_symtabs)
8630         (maintenance_expand_symtabs, maintenance_info_line_tables):
8631         Update.
8632         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8633         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
8634         (map_overlay_command, unmap_overlay_command)
8635         (simple_overlay_update, expand_symtabs_matching)
8636         (map_symbol_filenames): Update.
8637         * symfile-debug.c (set_debug_symfile): Update.
8638         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
8639         Update.
8640         * source.c (select_source_symtab, forget_cached_source_info):
8641         Update.
8642         * solib.c (solib_read_symbols): Update.
8643         * solib-spu.c (append_ocl_sos): Update.
8644         * psymtab.c (maintenance_print_psymbols)
8645         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
8646         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
8647         * printcmd.c (info_symbol_command): Update.
8648         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
8649         Update.
8650         * objfiles.h (class all_objfiles): Remove.
8651         * objfiles.c (have_partial_symbols, have_full_symbols)
8652         (have_minimal_symbols, qsort_cmp, update_section_map)
8653         (shared_objfile_contains_address_p)
8654         (default_iterate_over_objfiles_in_search_order): Update.
8655         * objc-lang.c (info_selectors_command, info_classes_command)
8656         (find_methods): Update.
8657         * minsyms.c (find_solib_trampoline_target): Update.
8658         * maint.c (maintenance_info_sections)
8659         (maintenance_translate_address, count_symtabs_and_blocks):
8660         Update.
8661         * main.c (captured_main_1): Update.
8662         * linux-thread-db.c (try_thread_db_load_from_pdir)
8663         (has_libpthread): Update.
8664         * linespec.c (iterate_over_all_matching_symtabs)
8665         (search_minsyms_for_name): Update.
8666         * jit.c (jit_find_objf_with_entry_addr): Update.
8667         * hppa-tdep.c (find_unwind_entry)
8668         (hppa_lookup_stub_minimal_symbol): Update.
8669         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
8670         Update.
8671         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8672         (elf_gnu_ifunc_resolve_by_got): Update.
8673         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
8674         * dwarf-index-write.c (save_gdb_index_command): Update.
8675         * cp-support.c (add_symbol_overload_list_qualified): Update.
8676         * breakpoint.c (create_overlay_event_breakpoint)
8677         (create_longjmp_master_breakpoint)
8678         (create_std_terminate_master_breakpoint)
8679         (create_exception_master_breakpoint): Update.
8680         * blockframe.c (find_pc_partial_function): Update.
8681         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
8682         (ada_collect_symbol_completion_matches)
8683         (ada_add_global_exceptions): Update.
8684
8685 2019-01-17  Tom Tromey  <tom@tromey.com>
8686
8687         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
8688         declare VEC.
8689         (solib_target_parse_libraries): Change return type.
8690         (library_list_start_segment, library_list_start_section)
8691         (library_list_end_library, library_list_start_library); Update.
8692         (solib_target_free_library_list): Remove.
8693         (solib_target_parse_libraries): Remove cleanup.  Change return
8694         type.
8695         (solib_target_current_sos): Update.
8696
8697 2019-01-17  Tom Tromey  <tromey@bapiya>
8698
8699         * valprint.c: Replace "the the" with "the".
8700         * symtab.c: Replace "the the" with "the".
8701         * solib.c: Replace "the the" with "the".
8702         * solib-dsbt.c: Replace "the the" with "the".
8703         * linespec.c: Replace "the the" with "the".
8704         * dwarf2loc.h: Replace "the the" with "the".
8705         * amd64-windows-tdep.c: Replace "the the" with "the".
8706         * aarch64-tdep.c: Replace "the the" with "the".
8707
8708 2019-01-16  Keith Seitz  <keiths@redhat.com>
8709
8710         PR gdb/23773
8711         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
8712         <builder>: Rename to ..
8713         <m_builder>: ... this and make private.
8714         (dwarf2_cu::get_builder): New method.  Change all users of
8715         `builder' to use this method.
8716         (dwarf2_start_symtab): Move to ...
8717         (dwarf2_cu::start_symtab): ... here.  Update all callers
8718         (setup_type_unit_groups): Move to ...
8719         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
8720         callers.
8721         (dwarf2_cu::reset_builder): New method.
8722         (process_full_compunit, process_full_type_unit): Use
8723         dwarf2_cu::reset_builder.
8724         (follow_die_offset): Record the ancestor CU if it is different
8725         from the followed DIE's CU.
8726         (follow_die_sig_1): Likewise.
8727
8728 2019-01-15  Tom Tromey  <tom@tromey.com>
8729
8730         * remote.c (class remote_state) <buf>: Now a char_vector.
8731         <buf_size>: Remove.
8732         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
8733         parameter.
8734         (remote_target::getpkt_or_notif_sane_1)
8735         (remote_target::getpkt_sane)
8736         (remote_target::getpkt_or_notif_sane): Likewise.
8737         (class remote_target) <putpkt>: New overload.
8738         (remote_target::read_frame): Change type of "buf_p".  Remove
8739         sizeof_p parameter.
8740         (packet_ok): New overload.
8741         (packet_check_result): New overload.
8742         Update all uses.
8743
8744 2019-01-14  Tom Tromey  <tom@tromey.com>
8745
8746         * remote-notif.c (handle_notification, remote_notif_ack)
8747         (remote_notif_parse): Make "buf" const.
8748         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
8749         const.
8750         (remote_notif_parse, remote_notif_ack, handle_notification):
8751         Likewise.
8752         * remote.c (remote_notif_stop_parse): Make "buf" const.
8753         (remote_target::remote_parse_stop_reply): Make "buf" const.
8754         (remote_notif_stop_ack): Make "buf" const.
8755
8756 2019-01-14  Tom Tromey  <tom@tromey.com>
8757
8758         * remote.c (remote_console_output): Make parameter const.
8759
8760 2019-01-14  Tom Tromey  <tom@tromey.com>
8761
8762         * target-debug.h (target_debug_print_signals): Constify.
8763         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
8764         * procfs.c (procfs_target::pass_signals): Update.
8765         * linux-nat.c (linux_nat_target::pass_signals): Update.
8766         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
8767         * target-delegates.c: Rebuild.
8768         * remote.c (remote_target::program_signals): Update.
8769         (remote_target::pass_signals): Update.
8770         * target.c (target_pass_signals): Constify argument.
8771         (target_program_signals): Likewise.
8772         * target.h (struct target_ops) <pass_signals, program_signals>:
8773         Constify argument.
8774         (target_pass_signals, target_program_signals): Constify argument.
8775
8776 2019-01-14  Tom Tromey  <tom@tromey.com>
8777
8778         PR tui/28819:
8779         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
8780
8781 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
8782
8783         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
8784         field.
8785         * rs6000-tdep.c: Include reggroups.h.
8786         (IS_V_ALIAS_PSEUDOREG): Define.
8787         (rs6000_register_name): Return names for the "vX" aliases.
8788         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
8789         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
8790         aliases.  Call default_register_reggroup_p for all other
8791         pseudo-registers.
8792         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
8793         New functions.
8794         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
8795         Handle "vX" aliases.
8796         (v_alias_pseudo_register_collect): New function.
8797         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
8798         (rs6000_gdbarch_init): Initialize "vX" aliases as
8799         pseudo-registers.  Restore registration of
8800         rs6000_pseudo_register_reggroup_p with
8801         set_tdesc_pseudo_register_reggroup_p.
8802
8803 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
8804
8805         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
8806         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
8807         set_gdbarch_num_pseudo_regs.
8808
8809 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8810
8811         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
8812         Remove arg prefixname, add do_set and do_show.
8813         Add member functions set_list and show_list.
8814         * cli/cli-style.c (class cli_style_option): Update accordingly.
8815         (style_set_list): Move to file scope.
8816         (style_show_list): Likewise.
8817         (set_style): Call help_list.
8818         (show_style): Call cmd_show_list.
8819         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
8820         Update to use the new macro.
8821
8822 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
8823
8824         * ada-lang.c (_initialize_ada_language): Expand the help text
8825         for the "catch exception" command.
8826
8827 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8828
8829         * symtab.c (matching_obj_sections): Initialize obj,
8830         declare it closer to its usage.
8831
8832 2019-01-10  Tom Tromey  <tom@tromey.com>
8833
8834         * thread-iter.h (inf_threads_iterator): Use next_iterator.
8835         (basic_inf_threads_range): Remove.
8836         (inf_threads_range, inf_non_exited_threads_range)
8837         (safe_inf_threads_range): Use next_adapter.
8838
8839 2019-01-10  Keith Seitz  <keiths@redhat.com>
8840
8841         PR gdb/23712
8842         PR symtab/23010
8843         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
8844         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
8845
8846 2019-01-10  Keith Seitz  <keiths@redhat.com>
8847
8848         PR gdb/23712
8849         PR symtab/23010
8850         * dictionary.c (pending_to_vector): Remove.
8851         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8852         Remove _1 suffix, replacing functions of the same name.  Update
8853         all callers.
8854         (dict_create_hashed, dict_create_hashed_expandable)
8855         (dict_create_linear, dict_create_linear_expandable, dict_free)
8856         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8857         Make functions static.
8858
8859 2019-01-10  Keith Seitz  <keiths@redhat.com>
8860
8861         PR gdb/23712
8862         PR symtab/23010
8863         * dictionary.h (struct dictionary): Replace declaration with
8864         multidictionary.
8865         (dict_create_hashed, dict_create_hashed_expandable)
8866         (dict_create_linear, dict_create_linear_expandable)
8867         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8868         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8869         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8870         taking multidictionary argument.
8871         [ALL_DICT_SYMBOLS]: Update for multidictionary.
8872         * block.h (struct block) <dict>: Change to multidictionary
8873         and rename `multidict'.
8874         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8875         symmisc.c: Update all dictionary references to multidictionary.
8876
8877 2019-01-10  Keith Seitz  <keiths@redhat.com>
8878
8879         PR gdb/23712
8880         PR symtab/23010
8881         * dictionary.c: Include unordered_map.
8882         (pending_to_vector): New function.
8883         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8884         Rewrite the non-"_1" functions to take vector instead
8885         of linked list.
8886         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8887         "new" _1 versions of the same name.
8888         (multidictionary): Define.
8889         (std::hash<enum language): New definition.
8890         (collate_pending_symbols_by_language, mdict_create_hashed)
8891         (mdict_create_hashed_expandable, mdict_create_linear)
8892         (mdict_create_linear_expandable, mdict_free)
8893         (find_language_dictionary, create_new_language_dictionary)
8894         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8895         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8896         (mdict_size, mdict_empty): New functions.
8897         * dictionary.h (mdict_iterator): Define.
8898
8899 2019-01-10  Pedro Alves  <palves@redhat.com>
8900
8901         * breakpoint.c (read_uploaded_action)
8902         (create_tracepoint_from_upload): Adjust to use
8903         gdb::unique_xmalloc_ptr.
8904         * ctf.c (ctf_write_uploaded_tp):
8905         (SET_ARRAY_FIELD): Use emplace_back.
8906         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8907         * tracefile-tfile.c (tfile_write_uploaded_tp):
8908         * tracepoint.c (parse_tracepoint_definition): Adjust to use
8909         gdb::unique_xmalloc_ptr.
8910         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8911         at_string, cond_string, cmd_strings>: Replace char pointers
8912         with gdb::unique_xmalloc_ptr.
8913
8914 2019-01-10  Pedro Alves  <palves@redhat.com>
8915
8916         * solib-target.c (library_list_start_library): Don't xstrdup name.
8917
8918 2019-01-10  Pedro Alves  <palves@redhat.com>
8919
8920         * mdebugread.c (parse_partial_symbols): Use
8921         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8922
8923 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8924
8925         * linux-fork.c (scoped_switch_fork_info)
8926         <~scoped_switch_fork_info>: Fix incorrect variable name.
8927
8928 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8929
8930         * linux-fork.c (scoped_switch_fork_info)
8931         <scoped_switch_fork_info>: Make explicit.
8932         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
8933
8934 2019-01-10  Tom Tromey  <tom@tromey.com>
8935
8936         * objfiles.h (objfile::reset_psymtabs): Update.
8937         * objfiles.c (objfile::objfile): Update.
8938         * psymtab.h (psymtab_storage::obstack): Update.
8939         (psymtab_storage::m_obstack): Use gdb::optional.
8940         (class psymtab_storage): Update comment.  Remove objfile
8941         parameter.
8942         * psymtab.c (psymtab_storage::psymtab_storage): Update.
8943
8944 2019-01-10  Tom Tromey  <tom@tromey.com>
8945
8946         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
8947         <free_psymtabs>: Now private.
8948         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
8949         (allocate_psymtab): Use new method.
8950
8951 2019-01-10  Tom Tromey  <tom@tromey.com>
8952
8953         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
8954         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
8955         * mdebugread.c (parse_partial_symbols): Use
8956         allocate_dependencies.
8957         * dwarf2read.c (dwarf2_create_include_psymtab): Use
8958         allocate_dependencies.
8959         (process_psymtab_comp_unit_reader)
8960         (build_type_psymtab_dependencies): Likewise.
8961         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
8962
8963 2019-01-10  Tom Tromey  <tom@tromey.com>
8964
8965         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
8966         PSYMBOL_SET_LANGUAGE.
8967         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
8968
8969 2019-01-10  Tom Tromey  <tom@tromey.com>
8970
8971         * psymtab.h (psymtab_storage::obstack): New method.
8972         <m_obstack>: Rename from obstack; now private.
8973         * psymtab.c (psymtab_storage): Update.
8974         * dwarf2read.c (create_addrmap_from_index)
8975         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
8976         Update.
8977
8978 2019-01-10  Tom Tromey  <tom@tromey.com>
8979
8980         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
8981         * objfiles.h (objfile::reset_psymtabs): New method.
8982
8983 2019-01-10  Tom Tromey  <tom@tromey.com>
8984
8985         * symmisc.c (print_symbol_bcache_statistics): Update.
8986         (print_objfile_statistics): Update.
8987         * symfile.c (reread_symbols): Update.
8988         * psymtab.h (class psymtab_storage): New.
8989         * psymtab.c (psymtab_storage): New constructor.
8990         (~psymtab_storage): New destructor.
8991         (require_partial_symbols): Update.
8992         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
8993         (find_pc_sect_psymtab, find_pc_sect_psymbol)
8994         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
8995         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
8996         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
8997         (start_psymtab_common, end_psymtab_common)
8998         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
8999         (allocate_psymtab): Update.
9000         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9001         Update.
9002         (dump_psymtab_addrmap, maintenance_print_psymbols)
9003         (maintenance_check_psymtabs): Update.
9004         (class objfile_psymtabs): Move to objfiles.h.
9005         * psympriv.h (discard_psymtab): Now inline.
9006         (psymtab_discarder::psymtab_discarder): Update.
9007         (psymtab_discarder::~psymtab_discarder): Update.
9008         (ALL_OBJFILE_PSYMTABS): Rewrite.
9009         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9010         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9011         Remove fields.
9012         <partial_symtabs>: New field.
9013         (class objfile_psymtabs): Move from psymtab.h.  Update.
9014         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9015         psymbol_cache.
9016         (objfile::~objfile): Don't destroy psymbol_cache.
9017         * mdebugread.c (parse_partial_symbols): Update.
9018         * dwarf2read.c (create_addrmap_from_index)
9019         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9020         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9021         (add_partial_subprogram, dwarf2_ranges_read): Update.
9022         * dwarf-index-write.c (write_address_map)
9023         (write_one_signatured_type, recursively_write_psymbols)
9024         (class debug_names, class debug_names, write_psymtabs_to_index):
9025         Update.
9026
9027 2019-01-10  Tom Tromey  <tom@tromey.com>
9028
9029         * symtab.h (SYMBOL_SET_NAMES): Update.
9030         (symbol_set_names): Update.
9031         (MSYMBOL_SET_NAMES): Update.
9032         * symtab.c (symbol_set_names): Change argument to be an
9033         objfile_per_bfd_storage.
9034         * psymtab.c (add_psymbol_to_bcache): Update.
9035         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9036
9037 2019-01-10  Tom Tromey  <tom@tromey.com>
9038
9039         * symtab.c (create_demangled_names_hash): Change argument to be an
9040         objfile_per_bfd_storage.
9041         (symbol_set_names): Update.
9042
9043 2019-01-10  Tom Tromey  <tom@tromey.com>
9044
9045         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9046         init_psymbol_list.
9047         * psymtab.c (init_psymbol_list): Do nothing if already called.
9048         * psympriv.h (init_psymbol_list): Add comment.
9049         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9050         init_psymbol_list.
9051         * dbxread.c (dbx_symfile_read): Unconditionally call
9052         init_psymbol_list.
9053
9054 2019-01-10  Tom Tromey  <tom@tromey.com>
9055
9056         * xcoffread.c (scan_xcoff_symtab): Update.
9057         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9058         "where".
9059         * mdebugread.c (parse_partial_symbols)
9060         (handle_psymbol_enumerators): Update.
9061         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9062         * dbxread.c (read_dbx_symtab): Update.
9063         * psympriv.h (psymbol_placement): New enum.
9064         (add_psymbol_to_list): Update.
9065
9066 2019-01-10  Tom Tromey  <tom@tromey.com>
9067
9068         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9069         static_psymbols parameters.
9070         (scan_xcoff_symtab): Update.
9071         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9072         static_psymbols parameters.
9073         * psympriv.h (start_psymtab_common): Update.
9074         * mdebugread.c (parse_partial_symbols): Update.
9075         * dwarf2read.c (create_partial_symtab): Update.
9076         * dbxread.c (read_dbx_symtab): Update.
9077         (start_psymtab): Remove global_psymbols and static_psymbols
9078         parameters.
9079
9080 2019-01-10  Tom Tromey  <tom@tromey.com>
9081
9082         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9083         * psymtab.c (allocate_psymtab): Add comment.
9084         * psympriv.h (allocate_psymtab): Add comment.
9085         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9086         initializations.
9087         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9088
9089 2019-01-10  Tom Tromey  <tom@tromey.com>
9090
9091         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9092         Don't declare.
9093         * mipsread.c: Include mdebugread.h.
9094         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9095         Declare.
9096         * elfread.c: Include mdebugread.h.
9097
9098 2019-01-09  Tom Tromey  <tom@tromey.com>
9099
9100         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9101         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9102         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9103         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9104         (psym_lookup_symbol, psym_find_last_source_symtab)
9105         (psym_forget_cached_source_info, psym_print_stats)
9106         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9107         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9108         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9109         (psym_find_compunit_symtab_by_address)
9110         (maintenance_print_psymbols, maintenance_info_psymtabs)
9111         (maintenance_check_psymtabs): Use ranged for.
9112         * psymtab.h (class objfile_psymtabs): New.
9113         (require_partial_symbols): Return objfile_psymtabs.
9114         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9115
9116 2019-01-09  Tom Tromey  <tom@tromey.com>
9117
9118         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9119         (find_pc_mapped_section, list_overlays_command)
9120         (map_overlay_command, unmap_overlay_command)
9121         (simple_overlay_update): Use all_objfiles.
9122         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9123         * printcmd.c (info_symbol_command): Use all_objfiles.
9124         * objfiles.h (ALL_OBJSECTIONS): Remove.
9125         * maint.c (maintenance_translate_address): Use all_objfiles.
9126         * gcore.c (gcore_create_callback): Use all_objfiles.
9127         (objfile_find_memory_regions): Likewise.
9128
9129 2019-01-09  Tom Tromey  <tom@tromey.com>
9130
9131         * symtab.c (find_line_symtab, info_sources_command)
9132         (make_source_files_completion_list): Use objfile_compunits.
9133         * source.c (select_source_symtab): Use objfile_compunits.
9134         * objfiles.h (struct objfile): Update comment.
9135         (ALL_OBJFILES): Remove.
9136         (ALL_FILETABS): Remove.
9137         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9138         objfile_compunits.
9139
9140 2019-01-09  Tom Tromey  <tom@tromey.com>
9141
9142         * symmisc.c (print_objfile_statistics, dump_objfile)
9143         (maintenance_print_symbols): Use compunit_filetabs.
9144         * source.c (forget_cached_source_info_for_objfile): Use
9145         compunit_filetabs.
9146         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9147         (ALL_FILETABS): Use compunit_filetabs.
9148         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9149         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9150
9151 2019-01-09  Tom Tromey  <tom@tromey.com>
9152
9153         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9154         (compunit_filetabs): New.
9155         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9156         compunit_filetabs.
9157         (info_sources_command, make_source_files_completion_list): Remove
9158         declaration.
9159         * symmisc.c (print_objfile_statistics, dump_objfile)
9160         (maintenance_print_symbols): Remove declaration.
9161         (maintenance_info_symtabs): Use compunit_filetabs.
9162         (maintenance_info_line_tables): Likewise.
9163         * source.c (select_source_symtab): Change local variable name.
9164         (forget_cached_source_info_for_objfile): Remove declaration.
9165         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9166         * objfiles.c (objfile_relocate1): Remove declaration.
9167         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9168         declaration.
9169         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9170         * coffread.c (coff_symtab_read): Remove declaration.
9171         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9172         compunit_filetabs.
9173
9174 2019-01-09  Tom Tromey  <tom@tromey.com>
9175
9176         * symtab.c (lookup_objfile_from_block)
9177         (find_pc_sect_compunit_symtab, search_symbols)
9178         (default_collect_symbol_completion_matches_break_on): Use
9179         objfile_compunits.
9180         * objfiles.h (ALL_COMPUNITS): Remove.
9181         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9182         * cp-support.c (add_symbol_overload_list_qualified): Use
9183         objfile_compunits.
9184         * ada-lang.c (ada_collect_symbol_completion_matches)
9185         (ada_add_global_exceptions): Use objfile_compunits.
9186
9187 2019-01-09  Tom Tromey  <tom@tromey.com>
9188
9189         * source.c (select_source_symtab)
9190         (forget_cached_source_info_for_objfile): Remove declaration.
9191         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9192         declaration.
9193         * maint.c (count_symtabs_and_blocks): Remove declaration.
9194         * cp-support.c (add_symbol_overload_list_qualified): Remove
9195         declaration.
9196         * coffread.c (coff_symtab_read): Remove declaration.
9197         * symtab.c (lookup_symbol_in_objfile_symtabs)
9198         (basic_lookup_transparent_type_1): Use objfile_compunits.
9199         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9200         (info_sources_command, search_symbols)
9201         (default_collect_symbol_completion_matches_break_on)
9202         (make_source_files_completion_list): Remove declaration.
9203         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9204         (ada_collect_symbol_completion_matches)
9205         (ada_add_global_exceptions): Remove declaration.
9206         * linespec.c (iterate_over_all_matching_symtabs): Use
9207         objfile_compunits.
9208         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9209         (class objfile_compunits): New.
9210         (ALL_COMPUNITS): Use objfile_compunits.
9211         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9212         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9213         objfile_compunits.
9214         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9215
9216 2019-01-09  Tom Tromey  <tom@tromey.com>
9217
9218         * symtab.c (search_symbols)
9219         (default_collect_symbol_completion_matches_break_on): Use
9220         objfile_msymbols.
9221         * ada-lang.c (ada_lookup_simple_minsym)
9222         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9223         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9224         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9225         objfile_msymbols.
9226         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9227         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9228         * objc-lang.c (find_methods): Use objfile_msymbols.
9229         (info_selectors_command, info_classes_command): Likewise.
9230         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9231         * objfiles.h (class objfile_msymbols): New.
9232         (ALL_OBJFILE_MSYMBOLS): Remove.
9233         (ALL_MSYMBOLS): Remove.
9234
9235 2019-01-09  Tom Tromey  <tom@tromey.com>
9236
9237         * common/next-iterator.h (next_adapter): Add Iterator template
9238         parameter.
9239         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9240         (class all_objfiles_safe): New.
9241         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9242         * objfiles.c (put_objfile_before): Update comment.
9243         (add_separate_debug_objfile): Likewise.
9244         (free_all_objfiles): Use all_objfiles_safe.
9245         (objfile_purge_solibs): Likewise.
9246
9247 2019-01-09  Tom Tromey  <tom@tromey.com>
9248
9249         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9250         (expand_symtab_containing_pc, lookup_static_symbol)
9251         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9252         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9253         all_objfiles.
9254         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9255         * breakpoint.c (create_overlay_event_breakpoint)
9256         (create_longjmp_master_breakpoint)
9257         (create_std_terminate_master_breakpoint)
9258         (create_exception_master_breakpoint): Use all_objfiles.
9259         * linux-thread-db.c (try_thread_db_load_from_pdir)
9260         (has_libpthread): Use all_objfiles.
9261         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9262         * linespec.c (iterate_over_all_matching_symtabs)
9263         (search_minsyms_for_name): Use all_objfiles.
9264         * maint.c (maintenance_info_sections): Use all_objfiles.
9265         * main.c (captured_main_1): Use all_objfiles.
9266         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9267         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9268         * guile/scm-pretty-print.c
9269         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9270         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9271         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9272         (maintenance_print_msymbols): Use all_objfiles.
9273         * source.c (select_source_symtab): Use all_objfiles.
9274         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9275         * symfile.c (remove_symbol_file_command)
9276         (expand_symtabs_matching, map_symbol_filenames): Use
9277         all_objfiles.
9278         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9279         all_objfiles.
9280         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9281         * objc-lang.c (find_methods): Use all_objfiles.
9282         * objfiles.c (have_partial_symbols, have_full_symbols)
9283         (have_minimal_symbols, qsort_cmp)
9284         (default_iterate_over_objfiles_in_search_order): Use
9285         all_objfiles.
9286         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9287         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9288         (maintenance_check_psymtabs): Use all_objfiles.
9289         (ALL_PSYMTABS): Remove.
9290         * compile/compile-object-run.c (do_module_cleanup): Use
9291         all_objfiles.
9292         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9293         * cp-support.c (add_symbol_overload_list_qualified): Use
9294         all_objfiles.
9295         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9296         Use all_objfiles.
9297         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9298         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9299         all_objfiles.
9300         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9301         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9302         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9303         Uses all_objfiles.
9304         * solib.c (solib_read_symbols): Use all_objfiles
9305
9306 2019-01-09  Tom Tromey  <tom@tromey.com>
9307
9308         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9309         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9310         all_objfiles.
9311         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9312         * symmisc.c (print_symbol_bcache_statistics)
9313         (print_objfile_statistics, maintenance_print_objfiles)
9314         (maintenance_info_symtabs, maintenance_check_symtabs)
9315         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9316         all_objfiles.
9317         * source.c (forget_cached_source_info): Use all_objfiles.
9318         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9319         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9320         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9321         * objfiles.c (update_section_map): Use all_objfiles.
9322         (shared_objfile_contains_address_p): Likewise.
9323         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9324         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9325
9326 2019-01-09  Tom Tromey  <tom@tromey.com>
9327
9328         * common/next-iterator.h: New file.
9329         * objfiles.h (class all_objfiles): New.
9330         (struct objfile_iterator): New.
9331
9332 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9333
9334         * NEWS: Move the description of the changed "frame", "select-frame",
9335          and "info frame" commands to the Changed commands section.
9336
9337 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9338
9339         * gdbtypes.c (check_stub_method_group): Remove handling of old
9340         mangling schemes.
9341         * linespec.c (find_methods): Likewise.
9342         * stabsread.c (read_member_functions): Likewise.
9343         * valops.c (search_struct_method): Likewise.
9344         (value_struct_elt_for_reference): Likewise.
9345         * NEWS: Mention this change.
9346
9347 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9348
9349         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9350         print_source_lines.
9351         * source.c (print_source_lines_base): Update line number check.
9352         (print_source_lines): New function.
9353         (source_lines_range::source_lines_range): New function.
9354         * source.h (class source_lines_range): New class.
9355         (print_source_lines): New declaration.
9356
9357 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9358
9359         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9360
9361 2019-01-08  Tom Tromey  <tom@tromey.com>
9362             Simon Marchi  <simon.marchi@ericsson.com>
9363
9364         PR gdb/24060
9365         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9366         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9367         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9368         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9369         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9370         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9371
9372 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9373
9374         * source.c (select_source_symtab): Move header comment to
9375         declaration in source.h.
9376         (forget_cached_source_info_for_objfile): Likewise.
9377         (forget_cached_source_info): Likewise.
9378         (identify_source_line): Likewise.
9379         * source.h (identify_source_line): Move declaration from symtab.h
9380         and add comment from source.c
9381         (print_source_lines): Likewise.
9382         (forget_cached_source_info_for_objfile): Likewise.
9383         (forget_cached_source_info): Likewise.
9384         (select_source_symtab): Likewise.
9385         (enum print_source_lines_flag): Move definition from symtab.h.
9386         * symtab.h (identify_source_line): Move declaration to source.h.
9387         (print_source_lines): Likewise.
9388         (forget_cached_source_info_for_objfile): Likewise.
9389         (forget_cached_source_info): Likewise.
9390         (select_source_symtab): Likewise.
9391         (enum print_source_lines_flag): Move definition to source.h.
9392         * tui/tui-hooks.c: Add 'source.h' include.
9393
9394 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9395
9396         * source.c (print_source_lines_base): Handle requests to print
9397         reverse line number sequences, and guard against empty lines
9398         string.
9399
9400 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9401
9402         * source.c (print_source_lines_base): Fix skip of '\r' if next
9403         character is '\n'.
9404
9405 2019-01-06  Tom Tromey  <tom@tromey.com>
9406
9407         * c-exp.y (struct c_parse_state) <macro_original_text,
9408         expansion_obstack>: New member.
9409         (macro_original_text, expansion_obstack): Remove globals.
9410         (scan_macro_expansion, scanning_macro_expansion)
9411         (finished_macro_expansion): Update.
9412         (scan_macro_cleanup): Remove.
9413         (yylex, c_parse): Update.
9414
9415 2019-01-06  Tom Tromey  <tom@tromey.com>
9416
9417         * c-exp.y (struct c_parse_state) <strings>: New member.
9418         (operator_stoken): Update.
9419
9420 2019-01-06  Tom Tromey  <tom@tromey.com>
9421
9422         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9423         (union type_stack_elt) <typelist_val>: Now a pointer to
9424         std::vector.
9425         (type_stack_cleanup): Don't declare.
9426         (push_typelist): Update.
9427         * parse.c (pop_typelist): Return a std::vector.
9428         (push_typelist): Take a std::vector.
9429         (follow_types): Update.  Do not free args.
9430         (type_stack_cleanup): Remove.
9431         * c-exp.y (struct c_parse_state): New.
9432         (cpstate): New global.
9433         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9434         (nonempty_typelist): Update.
9435         (func_mod): Create a new vector.
9436         (c_parse): Create a c_parse_state.
9437         (check_parameter_typelist): Do not delete params.
9438         (function_method): Update.  Do not delete type_list.
9439
9440 2019-01-06  Tom Tromey  <tom@tromey.com>
9441
9442         PR gdb/28155:
9443         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9444         check_typedef.
9445         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9446         (print_return_value): Likewise.
9447
9448 2019-01-05  Tom Tromey  <tom@tromey.com>
9449
9450         * contrib/cleanup_check.py: Remove.
9451         * contrib/gcc-with-excheck: Remove.
9452         * contrib/exsummary.py: Remove.
9453         * contrib/excheck.py: Remove.
9454
9455 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9456
9457         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9458         NULL. Initialize tpprev to NULL instead of assigning it
9459         to NULL on the next statement.
9460         * windows-nat.c (windows_delete_thread): Remove check for
9461         main_thread_id before printing thread exit notifications.
9462         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9463         Remove thread ID check against main_thread_id.
9464         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9465         windows_delete_thread.
9466         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9467
9468 2019-01-04  Tom Tromey  <tom@tromey.com>
9469
9470         * compile/compile.c (_initialize_compile): Use upper case for
9471         metasyntactic variables.
9472         * symmisc.c (_initialize_symmisc): Use upper case for
9473         metasyntactic variables.
9474         * psymtab.c (_initialize_psymtab): Use upper case for
9475         metasyntactic variables.
9476         * demangle.c (demangle_command): Use upper case for metasyntactic
9477         variables.
9478         (_initialize_demangler): Likewise.
9479         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9480         variables.
9481
9482 2019-01-03  Tom Tromey  <tom@tromey.com>
9483
9484         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9485
9486 2019-01-03  Tom Tromey  <tom@tromey.com>
9487
9488         * python/py-symtab.c (salpy_str): Update.
9489         (struct salpy_sal_object) <symtab>: Now a PyObject.
9490         (salpy_dealloc): Update.
9491         (del_objfile_sal): Use gdbpy_ref.
9492
9493 2019-01-03  Tom Tromey  <tom@tromey.com>
9494
9495         * python/py-type.c (convert_field): Use new_reference.  Return
9496         gdbpy_ref.
9497         (make_fielditem): Return gdbpy_ref.
9498         (typy_fields): Update.
9499         (typy_getitem): Update.
9500         (field_name): Return gdbpy_ref.  Use new_reference.
9501         (typy_iterator_iternext): Update.
9502
9503 2019-01-03  Tom Tromey  <tom@tromey.com>
9504
9505         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9506
9507 2019-01-03  Tom Tromey  <tom@tromey.com>
9508
9509         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9510         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9511         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9512         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9513         (pspy_set_type_printers): Likewise.
9514         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9515         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9516         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9517         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9518         (objfpy_set_type_printers): Likewise.
9519
9520 2019-01-03  Tom Tromey  <tom@tromey.com>
9521
9522         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9523         (gdbpy_print_stack): Use gdbpy_err_fetch.
9524         * python/python-internal.h (class gdbpy_err_fetch): New class.
9525         (class gdbpy_enter) <m_error_type, m_error_value,
9526         m_error_traceback>: Remove.
9527         <m_error>: New member.
9528         (gdbpy_exception_to_string): Don't declare.
9529         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9530         * python/py-value.c (convert_value_from_python): Use
9531         gdbpy_err_fetch.
9532         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9533         gdbpy_exception_to_string.
9534         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9535         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9536         gdbpy_err_fetch.
9537
9538 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9539
9540         * linux-nat.c (delete_lwp_cleanup): Delete.
9541         (struct lwp_deleter): New struct.
9542         (lwp_info_up): New typedef.
9543         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9544         lwp_info_up.
9545
9546 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9547
9548         * linux-fork.c (class scoped_switch_fork_info): New class.
9549         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9550
9551 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9552
9553         * valops.c (find_overload_match): Remove use of null_cleanup, and
9554         calls to do_cleanups.
9555
9556 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9557
9558         * compile/compile-cplus-types.c
9559         (compile_cplus_instance::decl_name): Handle changes to
9560         cp_func_name.
9561         * cp-support.c (cp_func_name): Update header comment, update
9562         return type.
9563         * cp-support.h (cp_func_name): Update return type in declaration.
9564         * valops.c (find_overload_match): Move temp_func local to top
9565         level of function and change its type.  Use temp_func to hold and
9566         delete temporary string obtained from cp_func_name.
9567
9568 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9569
9570         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9571         gdb::char_vector, remove cleanup, and update uses of `msg`.
9572
9573 2019-01-03  Jim Wilson  <jimw@sifive.com>
9574
9575         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9576
9577 2019-01-02  Tom Tromey  <tom@tromey.com>
9578
9579         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9580         (tdesc_parse_xml): Remove cleanups.
9581         * target-descriptions.h (make_cleanup_free_target_description):
9582         Don't declare.
9583         (target_desc_deleter): New struct.
9584         (target_desc_up): New typedef.
9585         * target-descriptions.c (target_desc_deleter::operator()): Rename
9586         from free_target_description.
9587         (make_cleanup_free_target_description): Remove.
9588
9589 2019-01-02  Tom Tromey  <tom@tromey.com>
9590
9591         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9592         constructor, destructor.
9593         (linespec_parser): Remove typedef.
9594         (~linespec_parser): Rename from linespec_parser_delete.
9595         (linespec_lex_to_end, linespec_complete_label)
9596         (linespec_complete): Update.
9597         (decode_line_full): Remove cleanups.
9598         (decode_line_1): Update.
9599
9600 2019-01-02  Tom Tromey  <tom@tromey.com>
9601
9602         * python/python-internal.h (inferior_to_inferior_object): Change
9603         return type.
9604         * python/py-exitedevent.c (create_exited_event_object): Update.
9605         * python/py-inferior.c (inferior_to_inferior_object): Return
9606         gdbpy_ref.
9607         (python_new_inferior, python_inferior_deleted)
9608         (thread_to_thread_object, delete_thread_object)
9609         (build_inferior_list, gdbpy_selected_inferior): Update.
9610         * python/py-infthread.c (create_thread_object): Update.  Also fail
9611         if inferior_to_inferior_object fails.
9612
9613 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9614
9615         * inferior.h (class inferior) <displaced_step_state>: New field.
9616         * infrun.h (struct displaced_step_state): Move here from
9617         infrun.c.  Initialize fields, add constructor.
9618         <inf>: Remove field.
9619         <reset>: New method.
9620         * infrun.c (struct displaced_step_inferior_state): Move to
9621         infrun.h.
9622         (displaced_step_inferior_states): Remove.
9623         (get_displaced_stepping_state): Adust.
9624         (displaced_step_in_progress_any_inferior): Adjust.
9625         (displaced_step_in_progress_thread): Adjust.
9626         (displaced_step_in_progress): Adjust.
9627         (add_displaced_stepping_state): Remove.
9628         (get_displaced_step_closure_by_addr): Adjust.
9629         (remove_displaced_stepping_state): Remove.
9630         (infrun_inferior_exit): Call displaced_step_state.reset.
9631         (use_displaced_stepping): Don't check for NULL.
9632         (displaced_step_prepare_throw): Call
9633         get_displaced_stepping_state.
9634         (displaced_step_fixup): Don't check for NULL.
9635         (prepare_for_detach): Don't check for NULL.
9636
9637 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9638
9639         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
9640          in case of call that did not complete.
9641
9642 2019-01-02  Andrey Utkin  <autkin@undo.io>
9643
9644         * symfile.c (find_separate_debug_file): Fix search of debug files for
9645         remote debuggee.
9646
9647 2019-01-02  Tom Tromey  <tom@tromey.com>
9648
9649         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
9650         indentation.
9651         * python/py-frame.c (frapy_older): Remove cast.
9652         (frapy_newer): Likewise.
9653         * python/py-breakpoint.c (local_setattro): Remove cast.
9654         * python/py-arch.c (archpy_name): Remove local variable.
9655         * python/py-type.c (gdbpy_lookup_type): Remove cast.
9656
9657 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
9658
9659         * unittests/basic_string_view/element_access/char/empty.cc:
9660         Fix year range in copyright header.
9661
9662 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9663
9664         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
9665         Delete.
9666         <operator==>: Update with for removed field.
9667         <hash>: Likewise.
9668         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
9669         <isa_features>: ...this.
9670         <abi_features>: New field.
9671         (riscv_isa_flen): Update comment.
9672         (riscv_abi_xlen): New declaration.
9673         (riscv_abi_flen): New declaration.
9674         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
9675         isa_features.
9676         (riscv_abi_xlen): New function.
9677         (riscv_isa_flen): Update to get answer from isa_features.
9678         (riscv_abi_flen): New function.
9679         (riscv_has_fp_abi): Update to get answer from abi_features.
9680         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
9681         xlen and flen.
9682         (riscv_call_info) <xlen, flen>: Update comment.
9683         (riscv_call_arg_struct): Remove invalid assertions
9684         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
9685         is removed.
9686         (riscv_gdbarch_init): Gather isa features and abi features
9687         separately, ensure both match on the gdbarch when reusing an old
9688         gdbarch.  Relax an error check to allow 32-bit abi float to run on
9689         a target with 64-bit float hardware.
9690
9691 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9692
9693         * source.c (search_command_helper): Stop reverse search
9694         when line 1 has been searched.
9695
9696 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9697
9698         * record-full.c (record_full_base_target::close): Rewrite
9699         record_full_core_buf_list free logic.
9700
9701 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9702
9703         * break-catch-syscall.c (print_one_catch_syscall): xfree
9704         the last text.
9705
9706 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9707
9708         * top.c (print_gdb_version): Update Copyright year in version
9709         message.
9710
9711 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9712
9713         Update copyright year range in all GDB files.
9714
9715 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
9716
9717         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
9718
9719 For older changes see ChangeLog-2018.
9720 \f
9721 Local Variables:
9722 mode: change-log
9723 left-margin: 8
9724 fill-column: 74
9725 version-control: never
9726 coding: utf-8
9727 End:
9728