gdb/ChangeLog

   1 2019-03-07  Brian Vandenberg  <phantall@gmail.com>
   2             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
   3
   4         PR gdb/8527
   5         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
   6         set_sigint_trap, clear_sigint_trap.
   7
   8 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
   9
  10         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
  11         for-loop range, to avoid compiler warnings.
  12
  13         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
  14         avoid compiler warnings about unused variables.
  15
  16 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
  17
  18         * NEWS: Mention end of support for native debugging on MS-Windows
  19         before XP.
  20
  21 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
  22
  23         PR gdb/24292
  24         * common/netstuff.c:
  25         * gdbserver/gdbreplay.c
  26         * gdbserver/remote-utils.c:
  27         * ser-tcp.c:
  28         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
  29         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
  30         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
  31         'getaddrinfo' and 'freeaddrinfo' were not available before
  32         Windows XP, and mingw.org's MinGW headers by default define
  33         _WIN32_WINNT to 0x500.
  34
  35 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
  36
  37         * NEWS: Note minimum Python version.
  38
  39 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
  40
  41         * version.in: Set GDB version number to 8.2.90.DATE-git.
  42
  43 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
  44
  45         GDB 8.2.90 released.
  46
  47 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
  48
  49         * version.in: Set GDB version number to 8.2.90.
  50
  51 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
  52
  53         * NEWS: Change "Changes since GDB 8.2" into "Changes in GDB 8.3".
  54
  55 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
  56
  57         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
  58         * version.in: Bump version to 8.2.90.DATE-git.
  59
  60 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
  61
  62         * aix-thread.c (ptid_cmp): Remove unused variable.
  63         (get_signaled_thread): Likewise.
  64         (store_regs_user_thread): Likewise.
  65         (store_regs_kernel_thread): Likewise.
  66         (fetch_regs_kernel_thread): Remove shadowed variable.
  67
  68 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
  69
  70         * features/riscv/32bit-cpu.xml: Add register numbers.
  71         * features/riscv/32bit-fpu.c: Regenerate.
  72         * features/riscv/32bit-fpu.xml: Add register numbers.
  73         * features/riscv/64bit-cpu.xml: Add register numbers.
  74         * features/riscv/64bit-fpu.c: Regenerate.
  75         * features/riscv/64bit-fpu.xml: Add register numbers.
  76
  77 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
  78
  79         * NEWS: Mention two argument form of gdb.Value constructor.
  80         * python/py-value.c (convert_buffer_and_type_to_value): New
  81         function.
  82         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
  83         Add support for handling an optional second argument.  Call
  84         convert_buffer_and_type_to_value as appropriate.
  85         * python/python-internal.h (Py_buffer_deleter): New struct.
  86         (Py_buffer_up): New typedef.
  87
  88 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
  89
  90         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
  91         instead of releasing ownership.
  92
  93 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
  94
  95         * dwarf2read.c (open_and_init_dwp_file): Call
  96         elf_numsections instead of bfd_count_sections to initialize
  97         dwp_file->num_sections.
  98
  99 2019-02-25  Tom Tromey  <tromey@adacore.com>
 100
 101         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
 102
 103 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 104
 105         * gcore.in: Add '--readnever' option when invoking GDB.
 106
 107 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 108
 109         * MAINTAINERS: Update my email address.
 110
 111 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 112
 113         * build-id.c (build_id_to_debug_bfd_1): New function.
 114         (build_id_to_debug_bfd): Look for separate debug file in
 115         sysroot.
 116
 117 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 118
 119         * gdbarch.sh: Update the copyright year range that is placed into
 120         generated files.
 121
 122 2019-02-22  Keith Seitz  <keiths@redhat.com>
 123
 124         PR symtab/23853
 125         * linespec.c (create_sals_line_offset): Search for the default
 126         symtab's filename instead of its fullname.
 127
 128 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 129
 130         * NEWS: Update style defaults.
 131
 132 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 133
 134         * main.c (captured_main_1): Disable styling in batch mode.
 135
 136 2019-02-20  Tom Tromey  <tom@tromey.com>
 137
 138         * symtab.c (symtab_symbol_info): Fix typos.
 139
 140 2019-02-20  Tom Tromey  <tromey@adacore.com>
 141
 142         * findcmd.c (_initialize_mem_search): Use upper case for
 143         metasyntactic variables.
 144
 145 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
 146
 147         * aarch64-tdep.c (aarch64_add_reggroups): New function.
 148         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
 149
 150 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
 151
 152         * top.h (source_file_name): Change to std::string.
 153         * top.c (source_file_name): Likewise.
 154         (command_line_input): Adjust.
 155         * cli/cli-script.c (script_from_file): Adjust.
 156
 157 2019-02-19  Tom Tromey  <tromey@adacore.com>
 158
 159         * ravenscar-thread.c
 160         (ravenscar_thread_target::update_thread_list): Don't call
 161         ada_build_task_list.
 162         * ada-lang.h (ada_build_task_list): Don't declare.
 163         * ada-tasks.c (struct ada_tasks_inferior_data)
 164         <task_list_valid_p>: Now bool.
 165         (read_known_tasks, ada_task_list_changed)
 166         (ada_tasks_invalidate_inferior_data): Update.
 167         (read_known_tasks_array): Return bool.
 168         (read_known_tasks_list): Likewise.
 169         (read_known_tasks): Return void.
 170         (ada_build_task_list): Now static.
 171
 172 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 173
 174         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
 175         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
 176
 177 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 178
 179         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
 180         variant for ada_tasks_pspace_data_handle and
 181         ada_tasks_inferior_data_handle.
 182         (ada_tasks_pspace_data_cleanup): New function.
 183         (ada_tasks_inferior_data_cleanup): New function.
 184
 185 2019-02-17  Tom Tromey  <tom@tromey.com>
 186
 187         * macrotab.h (macro_source_fullname): Return a std::string.
 188         * macrotab.c (macro_include, check_for_redefinition)
 189         (macro_undef, macro_lookup_definition, foreach_macro)
 190         (foreach_macro_in_scope): Update.
 191         (macro_source_fullname): Return a std::string.
 192         * macrocmd.c (show_pp_source_pos): Update.
 193
 194 2019-02-17  Tom Tromey  <tom@tromey.com>
 195
 196         * macrocmd.c (show_pp_source_pos): Style the file names.
 197
 198 2019-02-17  Tom Tromey  <tom@tromey.com>
 199
 200         PR tui/24197:
 201         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
 202
 203 2019-02-17  Tom Tromey  <tom@tromey.com>
 204
 205         * ada-lang.c (user_select_syms): Use filtered printing.
 206         * utils.c (wrap_style): New global.
 207         (desired_style): Remove.
 208         (emit_style_escape): Add stream parameter.
 209         (set_output_style, reset_terminal_style, prompt_for_continue):
 210         Update.
 211         (flush_wrap_buffer): Only flush gdb_stdout.
 212         (wrap_here): Set wrap_style.
 213         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
 214         treat escape sequences as a character.  Change when wrap buffer is
 215         flushed.
 216         (fputs_styled): Do not set the output style when the default is
 217         requested.
 218         * ui-style.h (struct ui_file_style) <is_default>: New method.
 219         * source.c (print_source_lines_base): Emit escape sequences in one
 220         piece.
 221
 222 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 223
 224         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
 225         integers and enumeration types.
 226
 227 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 228
 229         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
 230         instead of lookup_symbol_in_language
 231         (do_exact_match): New function.
 232         (ada_get_symbol_name_matcher): Return do_exact_match when
 233         doing a verbatim match.
 234
 235 2019-02-15  Tom Tromey  <tromey@adacore.com>
 236
 237         * ravenscar-thread.c (ravenscar_thread_target::resume)
 238         (ravenscar_thread_target::wait): Special case wildcard requests.
 239
 240 2019-02-15  Tom Tromey  <tromey@adacore.com>
 241
 242         * ravenscar-thread.c (base_ptid): Remove.
 243         (struct ravenscar_thread_target) <close>: New method.
 244         <m_base_ptid>: New member.
 245         <update_inferior_ptid, active_task, task_is_currently_active,
 246         runtime_initialized>: Declare methods.
 247         <ravenscar_thread_target>: Add constructor.
 248         (ravenscar_thread_target::task_is_currently_active)
 249         (ravenscar_thread_target::update_inferior_ptid)
 250         (ravenscar_runtime_initialized): Rename.  Now methods.
 251         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
 252         (ravenscar_thread_target::update_thread_list): Update.
 253         (ravenscar_thread_target::active_task): Now method.
 254         (ravenscar_thread_target::store_registers)
 255         (ravenscar_thread_target::prepare_to_store)
 256         (ravenscar_thread_target::prepare_to_store)
 257         (ravenscar_thread_target::mourn_inferior): Update.
 258         (ravenscar_inferior_created): Use "new" to create target.
 259         (ravenscar_thread_target::get_ada_task_ptid): Update.
 260         (_initialize_ravenscar): Don't initialize base_ptid.
 261         (ravenscar_ops): Remove global.
 262
 263 2019-02-15  Tom Tromey  <tromey@adacore.com>
 264
 265         * target.h (push_target): Declare new overload.
 266         * target.c (push_target): New overload, taking an rvalue reference.
 267         * remote.c (remote_target::open_1): Use push_target overload.
 268         * corelow.c (core_target_open): Use push_target overload.
 269
 270 2019-02-15  Tom Tromey  <tromey@adacore.com>
 271
 272         * ravenscar-thread.c (is_ravenscar_task)
 273         (ravenscar_task_is_currently_active): Return bool.
 274         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
 275         (_initialize_ravenscar): Remove "(void)".
 276         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
 277         Return bool.
 278
 279 2019-02-15  Tom Tromey  <tromey@adacore.com>
 280
 281         * ravenscar-thread.c (ravenscar_runtime_initializer)
 282         (has_ravenscar_runtime, get_running_thread_id)
 283         (ravenscar_thread_target::resume): Fix indentation.
 284
 285 2019-02-15  Tom Tromey  <tromey@adacore.com>
 286
 287         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
 288         from ravenscar_arch_ops.
 289         (sparc_ravenscar_ops::fetch_registers)
 290         (sparc_ravenscar_ops::store_registers): Now methods.
 291         (sparc_ravenscar_prepare_to_store): Remove.
 292         (sparc_ravenscar_ops): Redefine.
 293         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
 294         methods and destructor.  Remove members.
 295         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
 296         (ravenscar_thread_target::store_registers)
 297         (ravenscar_thread_target::prepare_to_store): Update.
 298         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
 299         Remove.
 300         (struct ppc_ravenscar_powerpc_ops): Derive from
 301         ravenscar_arch_ops.
 302         (ppc_ravenscar_powerpc_ops::fetch_registers)
 303         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
 304         (ppc_ravenscar_powerpc_ops): Redefine.
 305         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
 306         (ppc_ravenscar_e500_ops::fetch_registers)
 307         (ppc_ravenscar_e500_ops::store_registers): Now methods.
 308         (ppc_ravenscar_e500_ops): Redefine.
 309         * aarch64-ravenscar-thread.c
 310         (aarch64_ravenscar_generic_prepare_to_store): Remove.
 311         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
 312         (aarch64_ravenscar_fetch_registers)
 313         (aarch64_ravenscar_store_registers): Now methods.
 314         (aarch64_ravenscar_ops): Redefine.
 315
 316 2019-02-15  Tom Tromey  <tromey@adacore.com>
 317
 318         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
 319         (ravenscar_thread_target::stopped_by_hw_breakpoint)
 320         (ravenscar_thread_target::stopped_by_watchpoint)
 321         (ravenscar_thread_target::stopped_data_address)
 322         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
 323
 324 2019-02-15  Tom Tromey  <tromey@adacore.com>
 325
 326         * ravenscar-thread.c: Fix some typos.
 327
 328 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 329             Tom Tromey  <tromey@adacore.com>
 330
 331         * ada-lang.c (ada_exception_sal): Change addr_string to a
 332         std::string.
 333         (create_ada_exception_catchpoint): Update.
 334
 335 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 336             Tom Tromey  <tromey@adacore.com>
 337
 338         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
 339         (bp_location_ops): Remove.
 340         (base_breakpoint_allocate_location): Update.
 341         (free_bp_location): Update.
 342         * ada-lang.c (class ada_catchpoint_location)
 343         <ada_catchpoint_location>: Remove ops parameter.
 344         (ada_catchpoint_location_dtor): Remove.
 345         (ada_catchpoint_location_ops): Remove.
 346         (allocate_location_exception): Update.
 347         * breakpoint.h (struct bp_location_ops): Remove.
 348         (class bp_location) <bp_location>: Remove bp_location_ops
 349         parameter.
 350         <~bp_location>: Add destructor.
 351         <ops>: Remove.
 352
 353 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 354             Pedro Alves  <palves@redhat.com>
 355
 356         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
 357         'PATH_MAX'.
 358
 359 2019-02-14  David Michael  <fedora.dm0@gmail.com>
 360             Samuel Thibault  <samuel.thibault@gnu.org>
 361             Thomas Schwinge  <thomas@codesourcery.com>
 362
 363         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
 364         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
 365
 366 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 367
 368         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
 369         (check_empty): Use "const char *".
 370
 371         * gnu-nat.c (gnu_nat_target::detach): Instead of
 372         'detach_inferior (pid)' call
 373         'detach_inferior (find_inferior_pid (pid))'.
 374
 375         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
 376         'nat/fork-inferior.o'.
 377         * gnu-nat.c: #include "nat/fork-inferior.h".
 378
 379         * gnu-nat.c (gnu_nat_target::detach): Instead of
 380         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
 381         * gnu-nat.h: #include "inf-child.h".
 382         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
 383         'i386_gnu_nat_target::fetch_registers'.
 384         (gnu_store_registers): Rename/move to
 385         'i386_gnu_nat_target::store_registers'.
 386
 387         * config/i386/nm-i386gnu.h: Don't "#include" any files.
 388         * gnu-nat.h (mach_thread_info): New function.
 389         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
 390
 391         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
 392
 393 2019-02-14  Frederic Konrad  <konrad@adacore.com>
 394
 395         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
 396
 397 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
 398
 399         * windows-nat.c (windows_add_thread): Add new parameter
 400         "main_thread_p" with default value set to false.  Update
 401         function documentation as well as all callers.
 402         (windows_delete_thread): Likewise.
 403         (fake_create_process): Update call to windows_add_thread.
 404         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
 405         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
 406         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
 407         call to windows_delete_thread.
 408
 409 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
 410
 411         * MAINTAINERS: Add Andrew Burgess as global maintainer.
 412
 413 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 414
 415         * symfile.c (find_separate_debug_file): Use canonical path of
 416         sysroot with child_path instead of gdb_sysroot if it is valid.
 417
 418 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 419
 420         * symfile.c (find_separate_debug_file): Use child_path to
 421         determine if an object file is under a sysroot.
 422
 423 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 424
 425         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 426         unittests/child-path-selftests.c.
 427         * common/pathstuff.c (child_path): New function.
 428         * common/pathstuff.h (child_path): New prototype.
 429         * unittests/child-path-selftests.c: New file.
 430
 431 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 432
 433         * symfile.c (find_separate_debug_file): Look for separate debug
 434         files in debug directories under the sysroot.
 435
 436 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 437
 438         * symtab.h (struct minimal_symbol data_p): New const method.
 439         (struct minimal_symbol text_p): Likewise.
 440         * symtab.c (output_source_filename): Use file name style
 441         to print file name.
 442         (print_symbol_info): Likewise.
 443         (print_msymbol_info): Use address style to print addresses.
 444         Use function name style to print executable text symbols.
 445         (expand_symtab_containing_pc): Use data_p.
 446         (find_pc_sect_compunit_symtab): Likewise.
 447
 448 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 449
 450         * breakpoint.c (describe_other_breakpoints): Use address style
 451         to print addresses.
 452         (say_where): Likewise.
 453
 454 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 455
 456         * ada-typeprint.c (print_func_type): Print function name
 457         style to print function name.
 458         * c-typeprint.c (c_print_type_1): Likewise.
 459
 460 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 461
 462         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 463         for execve.
 464
 465 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 466
 467         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 468         type_stack.
 469
 470 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 471
 472         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 473         TYPE_CODE_REF types.
 474
 475 2019-02-08  Jim Wilson  <jimw@sifive.com>
 476
 477         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 478         (riscv_linux_fregset): New.
 479         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 480
 481 2019-02-07  Tom Tromey  <tom@tromey.com>
 482
 483         * thread.c (thread_cancel_execution_command): Update.
 484         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 485         methods.
 486         (struct thread_fsm_ops): Remove.
 487         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 488         (thread_fsm_should_stop, thread_fsm_return_value)
 489         (thread_fsm_set_finished, thread_fsm_finished_p)
 490         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 491         Don't declare.
 492         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 493         * infrun.c (clear_proceed_status_thread)
 494         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 495         (print_stop_event): Update.
 496         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 497         Add constructor.
 498         (step_command_fsm_ops): Remove.
 499         (new_step_command_fsm): Remove.
 500         (step_1): Update.
 501         (step_command_fsm::should_stop): Rename from
 502         step_command_fsm_should_stop.
 503         (step_command_fsm::clean_up): Rename from
 504         step_command_fsm_clean_up.
 505         (step_command_fsm::do_async_reply_reason): Rename from
 506         step_command_fsm_async_reply_reason.
 507         (struct until_next_fsm): Inherit from thread_fsm.  Add
 508         constructor.
 509         (until_next_fsm_ops): Remove.
 510         (new_until_next_fsm): Remove.
 511         (until_next_fsm::should_stop): Rename from
 512         until_next_fsm_should_stop.
 513         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 514         (until_next_fsm::do_async_reply_reason): Rename from
 515         until_next_fsm_async_reply_reason.
 516         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 517         constructor.  Change type of breakpoint.
 518         (finish_command_fsm_ops): Remove.
 519         (new_finish_command_fsm): Remove.
 520         (finish_command_fsm::should_stop): Rename from
 521         finish_command_fsm_should_stop.
 522         (finish_command_fsm::clean_up): Rename from
 523         finish_command_fsm_clean_up.
 524         (finish_command_fsm::return_value): Rename from
 525         finish_command_fsm_return_value.
 526         (finish_command_fsm::do_async_reply_reason): Rename from
 527         finish_command_fsm_async_reply_reason.
 528         (finish_command): Update.
 529         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 530         Add constructor.
 531         (call_thread_fsm_ops): Remove.
 532         (call_thread_fsm::call_thread_fsm): Rename from
 533         new_call_thread_fsm.
 534         (call_thread_fsm::should_stop): Rename from
 535         call_thread_fsm_should_stop.
 536         (call_thread_fsm::should_notify_stop): Rename from
 537         call_thread_fsm_should_notify_stop.
 538         (run_inferior_call, call_function_by_hand_dummy): Update.
 539         * cli/cli-interp.c (should_print_stop_to_console): Update.
 540         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 541         Add constructor.  Change type of location_breakpoint,
 542         caller_breakpoint.
 543         (until_break_fsm_ops): Remove.
 544         (new_until_break_fsm): Remove.
 545         (until_break_fsm::should_stop): Rename from
 546         until_break_fsm_should_stop.
 547         (until_break_fsm::clean_up): Rename from
 548         until_break_fsm_clean_up.
 549         (until_break_fsm::do_async_reply_reason): Rename from
 550         until_break_fsm_async_reply_reason.
 551         (until_break_command): Update.
 552         * thread-fsm.c: Remove.
 553         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 554
 555 2019-02-07  Tom Tromey  <tom@tromey.com>
 556
 557         * yy-remap.h: Add include guard.
 558         * xtensa-tdep.h: Add include guard.
 559         * xcoffread.h: Rename include guard.
 560         * varobj-iter.h: Add include guard.
 561         * tui/tui.h: Rename include guard.
 562         * tui/tui-winsource.h: Rename include guard.
 563         * tui/tui-wingeneral.h: Rename include guard.
 564         * tui/tui-windata.h: Rename include guard.
 565         * tui/tui-win.h: Rename include guard.
 566         * tui/tui-stack.h: Rename include guard.
 567         * tui/tui-source.h: Rename include guard.
 568         * tui/tui-regs.h: Rename include guard.
 569         * tui/tui-out.h: Rename include guard.
 570         * tui/tui-layout.h: Rename include guard.
 571         * tui/tui-io.h: Rename include guard.
 572         * tui/tui-hooks.h: Rename include guard.
 573         * tui/tui-file.h: Rename include guard.
 574         * tui/tui-disasm.h: Rename include guard.
 575         * tui/tui-data.h: Rename include guard.
 576         * tui/tui-command.h: Rename include guard.
 577         * tic6x-tdep.h: Add include guard.
 578         * target/waitstatus.h: Rename include guard.
 579         * target/wait.h: Rename include guard.
 580         * target/target.h: Rename include guard.
 581         * target/resume.h: Rename include guard.
 582         * target-float.h: Rename include guard.
 583         * stabsread.h: Add include guard.
 584         * rs6000-tdep.h: Add include guard.
 585         * riscv-fbsd-tdep.h: Add include guard.
 586         * regformats/regdef.h: Rename include guard.
 587         * record.h: Rename include guard.
 588         * python/python.h: Rename include guard.
 589         * python/python-internal.h: Rename include guard.
 590         * python/py-stopevent.h: Rename include guard.
 591         * python/py-ref.h: Rename include guard.
 592         * python/py-record.h: Rename include guard.
 593         * python/py-record-full.h: Rename include guard.
 594         * python/py-record-btrace.h: Rename include guard.
 595         * python/py-instruction.h: Rename include guard.
 596         * python/py-events.h: Rename include guard.
 597         * python/py-event.h: Rename include guard.
 598         * procfs.h: Add include guard.
 599         * proc-utils.h: Add include guard.
 600         * p-lang.h: Add include guard.
 601         * or1k-tdep.h: Rename include guard.
 602         * observable.h: Rename include guard.
 603         * nto-tdep.h: Rename include guard.
 604         * nat/x86-linux.h: Rename include guard.
 605         * nat/x86-linux-dregs.h: Rename include guard.
 606         * nat/x86-gcc-cpuid.h: Add include guard.
 607         * nat/x86-dregs.h: Rename include guard.
 608         * nat/x86-cpuid.h: Rename include guard.
 609         * nat/ppc-linux.h: Rename include guard.
 610         * nat/mips-linux-watch.h: Rename include guard.
 611         * nat/linux-waitpid.h: Rename include guard.
 612         * nat/linux-ptrace.h: Rename include guard.
 613         * nat/linux-procfs.h: Rename include guard.
 614         * nat/linux-osdata.h: Rename include guard.
 615         * nat/linux-nat.h: Rename include guard.
 616         * nat/linux-namespaces.h: Rename include guard.
 617         * nat/linux-btrace.h: Rename include guard.
 618         * nat/glibc_thread_db.h: Rename include guard.
 619         * nat/gdb_thread_db.h: Rename include guard.
 620         * nat/gdb_ptrace.h: Rename include guard.
 621         * nat/fork-inferior.h: Rename include guard.
 622         * nat/amd64-linux-siginfo.h: Rename include guard.
 623         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 624         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 625         * nat/aarch64-linux.h: Rename include guard.
 626         * nat/aarch64-linux-hw-point.h: Rename include guard.
 627         * mn10300-tdep.h: Add include guard.
 628         * mips-linux-tdep.h: Add include guard.
 629         * mi/mi-parse.h: Rename include guard.
 630         * mi/mi-out.h: Rename include guard.
 631         * mi/mi-main.h: Rename include guard.
 632         * mi/mi-interp.h: Rename include guard.
 633         * mi/mi-getopt.h: Rename include guard.
 634         * mi/mi-console.h: Rename include guard.
 635         * mi/mi-common.h: Rename include guard.
 636         * mi/mi-cmds.h: Rename include guard.
 637         * mi/mi-cmd-break.h: Rename include guard.
 638         * m2-lang.h: Add include guard.
 639         * location.h: Rename include guard.
 640         * linux-record.h: Rename include guard.
 641         * linux-nat.h: Add include guard.
 642         * linux-fork.h: Add include guard.
 643         * i386-darwin-tdep.h: Rename include guard.
 644         * hppa-linux-offsets.h: Add include guard.
 645         * guile/guile.h: Rename include guard.
 646         * guile/guile-internal.h: Rename include guard.
 647         * gnu-nat.h: Rename include guard.
 648         * gdb-stabs.h: Rename include guard.
 649         * frv-tdep.h: Add include guard.
 650         * f-lang.h: Add include guard.
 651         * event-loop.h: Add include guard.
 652         * darwin-nat.h: Rename include guard.
 653         * cp-abi.h: Rename include guard.
 654         * config/sparc/nm-sol2.h: Rename include guard.
 655         * config/nm-nto.h: Rename include guard.
 656         * config/nm-linux.h: Add include guard.
 657         * config/i386/nm-i386gnu.h: Rename include guard.
 658         * config/djgpp/nl_types.h: Rename include guard.
 659         * config/djgpp/langinfo.h: Rename include guard.
 660         * compile/gcc-cp-plugin.h: Add include guard.
 661         * compile/gcc-c-plugin.h: Add include guard.
 662         * compile/compile.h: Rename include guard.
 663         * compile/compile-object-run.h: Rename include guard.
 664         * compile/compile-object-load.h: Rename include guard.
 665         * compile/compile-internal.h: Rename include guard.
 666         * compile/compile-cplus.h: Rename include guard.
 667         * compile/compile-c.h: Rename include guard.
 668         * common/xml-utils.h: Rename include guard.
 669         * common/x86-xstate.h: Rename include guard.
 670         * common/version.h: Rename include guard.
 671         * common/vec.h: Rename include guard.
 672         * common/tdesc.h: Rename include guard.
 673         * common/selftest.h: Rename include guard.
 674         * common/scoped_restore.h: Rename include guard.
 675         * common/scoped_mmap.h: Rename include guard.
 676         * common/scoped_fd.h: Rename include guard.
 677         * common/safe-iterator.h: Rename include guard.
 678         * common/run-time-clock.h: Rename include guard.
 679         * common/refcounted-object.h: Rename include guard.
 680         * common/queue.h: Rename include guard.
 681         * common/ptid.h: Rename include guard.
 682         * common/print-utils.h: Rename include guard.
 683         * common/preprocessor.h: Rename include guard.
 684         * common/pathstuff.h: Rename include guard.
 685         * common/observable.h: Rename include guard.
 686         * common/netstuff.h: Rename include guard.
 687         * common/job-control.h: Rename include guard.
 688         * common/host-defs.h: Rename include guard.
 689         * common/gdb_wait.h: Rename include guard.
 690         * common/gdb_vecs.h: Rename include guard.
 691         * common/gdb_unlinker.h: Rename include guard.
 692         * common/gdb_unique_ptr.h: Rename include guard.
 693         * common/gdb_tilde_expand.h: Rename include guard.
 694         * common/gdb_sys_time.h: Rename include guard.
 695         * common/gdb_string_view.h: Rename include guard.
 696         * common/gdb_splay_tree.h: Rename include guard.
 697         * common/gdb_setjmp.h: Rename include guard.
 698         * common/gdb_ref_ptr.h: Rename include guard.
 699         * common/gdb_optional.h: Rename include guard.
 700         * common/gdb_locale.h: Rename include guard.
 701         * common/gdb_assert.h: Rename include guard.
 702         * common/filtered-iterator.h: Rename include guard.
 703         * common/filestuff.h: Rename include guard.
 704         * common/fileio.h: Rename include guard.
 705         * common/environ.h: Rename include guard.
 706         * common/common-utils.h: Rename include guard.
 707         * common/common-types.h: Rename include guard.
 708         * common/common-regcache.h: Rename include guard.
 709         * common/common-inferior.h: Rename include guard.
 710         * common/common-gdbthread.h: Rename include guard.
 711         * common/common-exceptions.h: Rename include guard.
 712         * common/common-defs.h: Rename include guard.
 713         * common/common-debug.h: Rename include guard.
 714         * common/cleanups.h: Rename include guard.
 715         * common/buffer.h: Rename include guard.
 716         * common/btrace-common.h: Rename include guard.
 717         * common/break-common.h: Rename include guard.
 718         * cli/cli-utils.h: Rename include guard.
 719         * cli/cli-style.h: Rename include guard.
 720         * cli/cli-setshow.h: Rename include guard.
 721         * cli/cli-script.h: Rename include guard.
 722         * cli/cli-interp.h: Rename include guard.
 723         * cli/cli-decode.h: Rename include guard.
 724         * cli/cli-cmds.h: Rename include guard.
 725         * charset-list.h: Add include guard.
 726         * buildsym-legacy.h: Rename include guard.
 727         * bfin-tdep.h: Add include guard.
 728         * ax.h: Rename include guard.
 729         * arm-linux-tdep.h: Add include guard.
 730         * arm-fbsd-tdep.h: Add include guard.
 731         * arch/xtensa.h: Rename include guard.
 732         * arch/tic6x.h: Add include guard.
 733         * arch/i386.h: Add include guard.
 734         * arch/arm.h: Rename include guard.
 735         * arch/arm-linux.h: Rename include guard.
 736         * arch/arm-get-next-pcs.h: Rename include guard.
 737         * arch/amd64.h: Add include guard.
 738         * arch/aarch64-insn.h: Rename include guard.
 739         * arch-utils.h: Rename include guard.
 740         * annotate.h: Add include guard.
 741         * amd64-darwin-tdep.h: Rename include guard.
 742         * aarch64-linux-tdep.h: Add include guard.
 743         * aarch64-fbsd-tdep.h: Add include guard.
 744         * aarch32-linux-nat.h: Add include guard.
 745
 746 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 747
 748         * macrotab.c (macro_define_internal): New function that
 749         factorizes macro_define_object_internal and macro_define_function
 750         code.
 751         (macro_define_object_internal): Use macro_define_internal.
 752         (macro_define_function): Likewise.
 753
 754 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 755
 756         * macrocmd.c (extract_identifier): Return
 757         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
 758         callers.
 759
 760 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
 761
 762         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
 763
 764 2019-02-05  Tom Tromey  <tom@tromey.com>
 765
 766         * target.c (target_stack::unpush): Move assertion earlier.
 767
 768 2019-01-30  Tom Tromey  <tom@tromey.com>
 769
 770         PR python/23615:
 771         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
 772         (gdbpy_parse_and_eval): Likewise.
 773         * python/python-internal.h (gdbpy_allow_threads): New class.
 774
 775 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
 776
 777         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
 778         (aarch64_fbsd_fpregmap): Move earlier.
 779         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
 780         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 781         instead of individual calls to trad_frame_set_reg_addr.
 782         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
 783         earlier.
 784         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
 785         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 786         instead of individual calls to trad_frame_set_reg_addr.
 787
 788 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
 789
 790         * CONTRIBUTE: Replace contribution list with wiki link.
 791
 792 2019-01-25  Tom Tromey  <tom@tromey.com>
 793
 794         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
 795
 796 2019-01-25  Tom Tromey  <tom@tromey.com>
 797
 798         * xtensa-linux-nat.c: Fix common/ includes.
 799         * xml-support.h: Fix common/ includes.
 800         * xml-support.c: Fix common/ includes.
 801         * x86-linux-nat.c: Fix common/ includes.
 802         * windows-nat.c: Fix common/ includes.
 803         * varobj.h: Fix common/ includes.
 804         * varobj.c: Fix common/ includes.
 805         * value.c: Fix common/ includes.
 806         * valops.c: Fix common/ includes.
 807         * utils.c: Fix common/ includes.
 808         * unittests/xml-utils-selftests.c: Fix common/ includes.
 809         * unittests/utils-selftests.c: Fix common/ includes.
 810         * unittests/unpack-selftests.c: Fix common/ includes.
 811         * unittests/tracepoint-selftests.c: Fix common/ includes.
 812         * unittests/style-selftests.c: Fix common/ includes.
 813         * unittests/string_view-selftests.c: Fix common/ includes.
 814         * unittests/scoped_restore-selftests.c: Fix common/ includes.
 815         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
 816         * unittests/scoped_fd-selftests.c: Fix common/ includes.
 817         * unittests/rsp-low-selftests.c: Fix common/ includes.
 818         * unittests/parse-connection-spec-selftests.c: Fix common/
 819         includes.
 820         * unittests/optional-selftests.c: Fix common/ includes.
 821         * unittests/offset-type-selftests.c: Fix common/ includes.
 822         * unittests/observable-selftests.c: Fix common/ includes.
 823         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
 824         * unittests/memrange-selftests.c: Fix common/ includes.
 825         * unittests/memory-map-selftests.c: Fix common/ includes.
 826         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
 827         * unittests/function-view-selftests.c: Fix common/ includes.
 828         * unittests/environ-selftests.c: Fix common/ includes.
 829         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
 830         * unittests/common-utils-selftests.c: Fix common/ includes.
 831         * unittests/cli-utils-selftests.c: Fix common/ includes.
 832         * unittests/array-view-selftests.c: Fix common/ includes.
 833         * ui-file.c: Fix common/ includes.
 834         * tui/tui-io.c: Fix common/ includes.
 835         * tracepoint.h: Fix common/ includes.
 836         * tracepoint.c: Fix common/ includes.
 837         * tracefile-tfile.c: Fix common/ includes.
 838         * top.h: Fix common/ includes.
 839         * top.c: Fix common/ includes.
 840         * thread.c: Fix common/ includes.
 841         * target/waitstatus.h: Fix common/ includes.
 842         * target/waitstatus.c: Fix common/ includes.
 843         * target.h: Fix common/ includes.
 844         * target.c: Fix common/ includes.
 845         * target-memory.c: Fix common/ includes.
 846         * target-descriptions.c: Fix common/ includes.
 847         * symtab.h: Fix common/ includes.
 848         * symfile.c: Fix common/ includes.
 849         * stap-probe.c: Fix common/ includes.
 850         * spu-linux-nat.c: Fix common/ includes.
 851         * sparc-nat.c: Fix common/ includes.
 852         * source.c: Fix common/ includes.
 853         * solib.c: Fix common/ includes.
 854         * solib-target.c: Fix common/ includes.
 855         * ser-unix.c: Fix common/ includes.
 856         * ser-tcp.c: Fix common/ includes.
 857         * ser-pipe.c: Fix common/ includes.
 858         * ser-base.c: Fix common/ includes.
 859         * selftest-arch.c: Fix common/ includes.
 860         * s12z-tdep.c: Fix common/ includes.
 861         * rust-exp.y: Fix common/ includes.
 862         * rs6000-aix-tdep.c: Fix common/ includes.
 863         * riscv-tdep.c: Fix common/ includes.
 864         * remote.c: Fix common/ includes.
 865         * remote-notif.h: Fix common/ includes.
 866         * remote-fileio.h: Fix common/ includes.
 867         * remote-fileio.c: Fix common/ includes.
 868         * regcache.h: Fix common/ includes.
 869         * regcache.c: Fix common/ includes.
 870         * record-btrace.c: Fix common/ includes.
 871         * python/python.c: Fix common/ includes.
 872         * python/py-type.c: Fix common/ includes.
 873         * python/py-inferior.c: Fix common/ includes.
 874         * progspace.h: Fix common/ includes.
 875         * producer.c: Fix common/ includes.
 876         * procfs.c: Fix common/ includes.
 877         * proc-api.c: Fix common/ includes.
 878         * printcmd.c: Fix common/ includes.
 879         * ppc-linux-nat.c: Fix common/ includes.
 880         * parser-defs.h: Fix common/ includes.
 881         * osdata.c: Fix common/ includes.
 882         * obsd-nat.c: Fix common/ includes.
 883         * nat/x86-linux.c: Fix common/ includes.
 884         * nat/x86-linux-dregs.c: Fix common/ includes.
 885         * nat/x86-dregs.h: Fix common/ includes.
 886         * nat/x86-dregs.c: Fix common/ includes.
 887         * nat/ppc-linux.c: Fix common/ includes.
 888         * nat/mips-linux-watch.h: Fix common/ includes.
 889         * nat/mips-linux-watch.c: Fix common/ includes.
 890         * nat/linux-waitpid.c: Fix common/ includes.
 891         * nat/linux-ptrace.h: Fix common/ includes.
 892         * nat/linux-ptrace.c: Fix common/ includes.
 893         * nat/linux-procfs.c: Fix common/ includes.
 894         * nat/linux-personality.c: Fix common/ includes.
 895         * nat/linux-osdata.c: Fix common/ includes.
 896         * nat/linux-namespaces.c: Fix common/ includes.
 897         * nat/linux-btrace.h: Fix common/ includes.
 898         * nat/linux-btrace.c: Fix common/ includes.
 899         * nat/fork-inferior.c: Fix common/ includes.
 900         * nat/amd64-linux-siginfo.c: Fix common/ includes.
 901         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
 902         * nat/aarch64-linux.c: Fix common/ includes.
 903         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
 904         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
 905         * namespace.h: Fix common/ includes.
 906         * mips-linux-tdep.c: Fix common/ includes.
 907         * minsyms.c: Fix common/ includes.
 908         * mi/mi-parse.h: Fix common/ includes.
 909         * mi/mi-main.c: Fix common/ includes.
 910         * mi/mi-cmd-env.c: Fix common/ includes.
 911         * memrange.h: Fix common/ includes.
 912         * memattr.c: Fix common/ includes.
 913         * maint.h: Fix common/ includes.
 914         * maint.c: Fix common/ includes.
 915         * main.c: Fix common/ includes.
 916         * machoread.c: Fix common/ includes.
 917         * location.c: Fix common/ includes.
 918         * linux-thread-db.c: Fix common/ includes.
 919         * linux-nat.c: Fix common/ includes.
 920         * linux-fork.c: Fix common/ includes.
 921         * inline-frame.c: Fix common/ includes.
 922         * infrun.c: Fix common/ includes.
 923         * inflow.c: Fix common/ includes.
 924         * inferior.h: Fix common/ includes.
 925         * inferior.c: Fix common/ includes.
 926         * infcmd.c: Fix common/ includes.
 927         * inf-ptrace.c: Fix common/ includes.
 928         * inf-child.c: Fix common/ includes.
 929         * ia64-linux-nat.c: Fix common/ includes.
 930         * i387-tdep.c: Fix common/ includes.
 931         * i386-tdep.c: Fix common/ includes.
 932         * i386-linux-tdep.c: Fix common/ includes.
 933         * i386-linux-nat.c: Fix common/ includes.
 934         * i386-go32-tdep.c: Fix common/ includes.
 935         * i386-fbsd-tdep.c: Fix common/ includes.
 936         * i386-fbsd-nat.c: Fix common/ includes.
 937         * guile/scm-type.c: Fix common/ includes.
 938         * guile/guile.c: Fix common/ includes.
 939         * go32-nat.c: Fix common/ includes.
 940         * gnu-nat.c: Fix common/ includes.
 941         * gdbthread.h: Fix common/ includes.
 942         * gdbarch-selftests.c: Fix common/ includes.
 943         * gdb_usleep.c: Fix common/ includes.
 944         * gdb_select.h: Fix common/ includes.
 945         * gdb_bfd.c: Fix common/ includes.
 946         * gcore.c: Fix common/ includes.
 947         * fork-child.c: Fix common/ includes.
 948         * findvar.c: Fix common/ includes.
 949         * fbsd-nat.c: Fix common/ includes.
 950         * event-top.c: Fix common/ includes.
 951         * event-loop.c: Fix common/ includes.
 952         * dwarf2read.c: Fix common/ includes.
 953         * dwarf2loc.c: Fix common/ includes.
 954         * dwarf2-frame.c: Fix common/ includes.
 955         * dwarf-index-cache.c: Fix common/ includes.
 956         * dtrace-probe.c: Fix common/ includes.
 957         * disasm-selftests.c: Fix common/ includes.
 958         * defs.h: Fix common/ includes.
 959         * csky-tdep.c: Fix common/ includes.
 960         * cp-valprint.c: Fix common/ includes.
 961         * cp-support.h: Fix common/ includes.
 962         * cp-support.c: Fix common/ includes.
 963         * corelow.c: Fix common/ includes.
 964         * completer.h: Fix common/ includes.
 965         * completer.c: Fix common/ includes.
 966         * compile/compile.c: Fix common/ includes.
 967         * compile/compile-loc2c.c: Fix common/ includes.
 968         * compile/compile-cplus-types.c: Fix common/ includes.
 969         * compile/compile-cplus-symbols.c: Fix common/ includes.
 970         * command.h: Fix common/ includes.
 971         * cli/cli-dump.c: Fix common/ includes.
 972         * cli/cli-cmds.c: Fix common/ includes.
 973         * charset.c: Fix common/ includes.
 974         * build-id.c: Fix common/ includes.
 975         * btrace.h: Fix common/ includes.
 976         * btrace.c: Fix common/ includes.
 977         * breakpoint.h: Fix common/ includes.
 978         * breakpoint.c: Fix common/ includes.
 979         * ax.h:
 980         (enum agent_op): Fix common/ includes.
 981         * ax-general.c (struct aop_map): Fix common/ includes.
 982         * ax-gdb.c: Fix common/ includes.
 983         * auxv.c: Fix common/ includes.
 984         * auto-load.c: Fix common/ includes.
 985         * arm-tdep.c: Fix common/ includes.
 986         * arch/riscv.c: Fix common/ includes.
 987         * arch/ppc-linux-common.c: Fix common/ includes.
 988         * arch/i386.c: Fix common/ includes.
 989         * arch/arm.c: Fix common/ includes.
 990         * arch/arm-linux.c: Fix common/ includes.
 991         * arch/arm-get-next-pcs.c: Fix common/ includes.
 992         * arch/amd64.c: Fix common/ includes.
 993         * arch/aarch64.c: Fix common/ includes.
 994         * arch/aarch64-insn.c: Fix common/ includes.
 995         * arch-utils.c: Fix common/ includes.
 996         * amd64-windows-tdep.c: Fix common/ includes.
 997         * amd64-tdep.c: Fix common/ includes.
 998         * amd64-sol2-tdep.c: Fix common/ includes.
 999         * amd64-obsd-tdep.c: Fix common/ includes.
1000         * amd64-nbsd-tdep.c: Fix common/ includes.
1001         * amd64-linux-tdep.c: Fix common/ includes.
1002         * amd64-linux-nat.c: Fix common/ includes.
1003         * amd64-fbsd-tdep.c: Fix common/ includes.
1004         * amd64-fbsd-nat.c: Fix common/ includes.
1005         * amd64-dicos-tdep.c: Fix common/ includes.
1006         * amd64-darwin-tdep.c: Fix common/ includes.
1007         * agent.c: Fix common/ includes.
1008         * ada-lang.h: Fix common/ includes.
1009         * ada-lang.c: Fix common/ includes.
1010         * aarch64-tdep.c: Fix common/ includes.
1011
1012 2019-01-25  Tom Tromey  <tom@tromey.com>
1013
1014         * common/create-version.sh: Use common/version.h.
1015
1016 2019-01-24  Pedro Alves  <palves@redhat.com>
1017
1018         * infrun.c (signal_stop, signal_print, signal_program)
1019         (signal_catch, signal_pass): Now arrays instead of pointers.
1020         (update_signals_program_target, do_target_resume)
1021         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1022         * linux-nat.c (linux_nat_target::pass_signals)
1023         (linux_nat_target::create_inferior, linux_nat_target::attach):
1024         Adjust.
1025         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1026         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1027         * procfs.c (procfs_target::pass_signals): Adjust.
1028         * record-full.c (record_full_target::resume): Adjust.
1029         * remote.c (remote_target::pass_signals)
1030         (remote_target::program_signals): Adjust.
1031         * target-debug.h (target_debug_print_signals): Now takes a
1032         gdb::array_view as parameter.  Adjust.
1033         * target.h (target_ops) <pass_signals, program_signals>: Replace
1034         pointer and length parameters with gdb::array_view.
1035         (target_pass_signals, target_program_signals): Likewise.
1036         * target-delegates.c: Regenerate.
1037
1038 2019-01-24  Pedro Alves  <palves@redhat.com>
1039
1040         * common/forward-scope-exit.h
1041         (forward_scope_exit::forward_scope_exit): Pass arguments to
1042         m_bind_function directly, instead of creating a std::bind and
1043         copying that.
1044
1045 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1046
1047         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1048         for static members.
1049         (pass_in_v_vfp_candidate): Likewise.
1050
1051 2019-01-23  Tom Tromey  <tom@tromey.com>
1052             Pedro Alves  <palves@redhat.com>
1053
1054         * regcache.c (class regcache_invalidator): Remove.
1055         (regcache::raw_write): Use make_scope_exit.
1056
1057 2019-01-23  Tom Tromey  <tom@tromey.com>
1058
1059         * ui-out.h (class ui_out_emit_type): Update comment.
1060
1061 2019-01-23  Tom Tromey  <tom@tromey.com>
1062
1063         * infrun.c (fetch_inferior_event): Update comment.
1064
1065 2019-01-23  Tom Tromey  <tom@tromey.com>
1066             Pedro Alves  <palves@redhat.com>
1067
1068         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1069         parameter.
1070         (fetch_inferior_event): Use SCOPE_EXIT.
1071
1072
1073 2019-01-23  Tom Tromey  <tom@tromey.com>
1074             Pedro Alves  <palves@redhat.com>
1075
1076         * infrun.c (disable_thread_events): Delete.
1077         (stop_all_threads): Use SCOPE_EXIT.
1078
1079 2019-01-23  Tom Tromey  <tom@tromey.com>
1080             Pedro Alves  <palves@redhat.com>
1081
1082         * symfile.c: Include forward-scope-exit.h.
1083         (clear_symtab_users_cleanup): Replace forward declaration with
1084         a FORWARD_SCOPE_EXIT.
1085         (syms_from_objfile_1): Use the forward_scope_exit and
1086         gdb::optional instead of cleanup_function.
1087         (reread_symbols): Use the forward_scope_exit instead of
1088         cleanup_function.
1089         (clear_symtab_users_cleanup): Remove function.
1090
1091 2019-01-23  Tom Tromey  <tom@tromey.com>
1092             Pedro Alves  <palves@redhat.com>
1093
1094         * linux-nat.c: Include scope-exit.h.
1095         (cleanup_target_stop): Remove.
1096         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1097         SCOPE_EXIT.
1098
1099 2019-01-23  Tom Tromey  <tom@tromey.com>
1100             Pedro Alves  <palves@redhat.com>
1101
1102         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1103         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1104
1105 2019-01-23  Tom Tromey  <tom@tromey.com>
1106             Andrew Burgess  <andrew.burgess@embecosm.com>
1107             Pedro Alves  <palves@redhat.com>
1108
1109         * infrun.c (fetch_inferior_event): Use scope_exit.
1110         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1111         * top.c (execute_command): Use scope_exit.
1112         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1113         * utils.c (do_bpstat_clear_actions_cleanup)
1114         (make_bpstat_clear_actions_cleanup): Remove.
1115
1116 2019-01-23  Tom Tromey  <tom@tromey.com>
1117             Pedro Alves  <palves@redhat.com>
1118
1119         * infrun.c: Include "common/scope-exit.h"
1120         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1121         (wait_for_inferior): Use SCOPE_EXIT.
1122         (fetch_inferior_event): Use scope_exit.
1123
1124 2019-01-23  Tom Tromey  <tom@tromey.com>
1125             Pedro Alves  <palves@redhat.com>
1126
1127         * breakpoint.c (create_breakpoint): Remove cleanup.
1128
1129 2019-01-23  Tom Tromey  <tom@tromey.com>
1130             Andrew Burgess  <andrew.burgess@embecosm.com>
1131             Pedro Alves  <palves@redhat.com>
1132
1133 2019-01-23  Pedro Alves  <palves@redhat.com>
1134
1135         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1136
1137 2019-01-23  Pedro Alves  <palves@redhat.com>
1138             Andrew Burgess  <andrew.burgess@embecosm.com>
1139
1140         * gdbthread.h: Include "common/forward-scope-exit.h".
1141         (scoped_finish_thread_state): Redefine custom class in terms of
1142         forward_scope_exit.
1143
1144 2019-01-23  Pedro Alves  <palves@redhat.com>
1145             Andrew Burgess  <andrew.burgess@embecosm.com>
1146
1147         * common/forward-scope-exit.h: New file.
1148
1149 2019-01-23  Pedro Alves  <palves@redhat.com>
1150             Andrew Burgess  <andrew.burgess@embecosm.com>
1151             Tom Tromey  <tom@tromey.com>
1152
1153         * common/scope-exit.h: New file.
1154
1155 2019-01-23  Pedro Alves  <palves@redhat.com>
1156
1157         * common/preprocessor.h (ESC): Rename to ...
1158         (ESC_PARENS): ... this.
1159         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1160         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1161
1162 2019-01-23  Tom Tromey  <tom@tromey.com>
1163
1164         * language.h (class scoped_switch_to_sym_language_if_auto):
1165         Initialize m_lang in both cases.
1166
1167 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1168
1169         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1170         with XCNEW.
1171
1172 2019-01-22  Tom Tromey  <tom@tromey.com>
1173
1174         * corelow.c: Do not include sys/file.h.
1175
1176 2019-01-22  Tom Tromey  <tom@tromey.com>
1177
1178         * tui/tui-wingeneral.h: Include gdb_curses.h.
1179
1180 2019-01-22  Tom Tromey  <tom@tromey.com>
1181
1182         * source-cache.h (class source_cache) <get_source_lines,
1183         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1184
1185 2019-01-22  Tom Tromey  <tom@tromey.com>
1186
1187         * remote-fileio.h (struct remote_target): Declare.
1188
1189 2019-01-22  Tom Tromey  <tom@tromey.com>
1190
1191         * python/py-arch.c: Do not include py-ref.h.
1192         * python/py-bpevent.c: Do not include py-ref.h.
1193         * python/py-cmd.c: Do not include py-ref.h.
1194         * python/py-continueevent.c: Do not include py-ref.h.
1195         * python/py-event.h: Do not include py-ref.h.
1196         * python/py-evtregistry.c: Do not include py-ref.h.
1197         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1198         * python/py-frame.c: Do not include py-ref.h.
1199         * python/py-framefilter.c: Do not include py-ref.h.
1200         * python/py-function.c: Do not include py-ref.h.
1201         * python/py-infevents.c: Do not include py-ref.h.
1202         * python/py-linetable.c: Do not include py-ref.h.
1203         * python/py-objfile.c: Do not include py-ref.h.
1204         * python/py-param.c: Do not include py-ref.h.
1205         * python/py-prettyprint.c: Do not include py-ref.h.
1206         * python/py-progspace.c: Do not include py-ref.h.
1207         * python/py-symbol.c: Do not include py-ref.h.
1208         * python/py-symtab.c: Do not include py-ref.h.
1209         * python/py-type.c: Do not include py-ref.h.
1210         * python/py-unwind.c: Do not include py-ref.h.
1211         * python/py-utils.c: Do not include py-ref.h.
1212         * python/py-value.c: Do not include py-ref.h.
1213         * python/py-varobj.c: Do not include py-ref.h.
1214         * python/py-xmethods.c: Do not include py-ref.h.
1215         * python/python.c: Do not include py-ref.h.
1216         * varobj.c: Do not include py-ref.h.
1217
1218 2019-01-22  Tom Tromey  <tom@tromey.com>
1219
1220         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1221         keyword for bcache.
1222
1223 2019-01-22  Tom Tromey  <tom@tromey.com>
1224
1225         * compile/compile-cplus-types.c: Remove a comment by #include.
1226
1227 2019-01-22  Tom Tromey  <tom@tromey.com>
1228
1229         * compile/gcc-c-plugin.h: Include compile-internal.h.
1230
1231 2019-01-22  Tom Tromey  <tom@tromey.com>
1232
1233         * stabsread.c (EXTERN): Do not define.
1234         (symnum, next_symbol_text_func, processing_gcc_compilation)
1235         (within_function, global_sym_chain, global_stabs)
1236         (previous_stab_code, this_object_header_files)
1237         (n_this_object_header_files)
1238         (n_allocated_this_object_header_files): Define.
1239         * stabsread.h (EXTERN): Never define.  Use "extern".
1240
1241 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1242
1243         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1244         history_value.
1245
1246 2019-01-21  Tom Tromey  <tom@tromey.com>
1247
1248         * ui-out.c: Fix includes.
1249         * tui/tui-source.c: Fix includes.
1250         * target.c: Fix includes.
1251         * remote.c: Fix includes.
1252         * regcache.c: Fix includes.
1253         * python/py-block.c: Fix includes.
1254         * printcmd.c: Fix includes.
1255         * or1k-tdep.c: Fix includes.
1256         * mi/mi-main.c: Fix includes.
1257         * m32r-tdep.c: Fix includes.
1258         * csky-tdep.c: Fix includes.
1259         * compile/compile-cplus-types.c: Fix includes.
1260         * cli/cli-interp.c: Fix includes.
1261
1262 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1263
1264         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1265         for padding.
1266
1267 2019-01-16  Tom Tromey  <tom@tromey.com>
1268
1269         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1270         earlier.
1271         (struct objfile) <msymbols_range>: Move from top level.
1272         <msymbols>: New method.
1273         (class objfile_msymbols): Remove.
1274         * symtab.c (default_collect_symbol_completion_matches_break_on):
1275         Update.
1276         * symmisc.c (dump_msymbols): Update.
1277         * stabsread.c (scan_file_globals): Update.
1278         * objc-lang.c (info_selectors_command, info_classes_command)
1279         (find_methods): Update.
1280         * minsyms.c (find_solib_trampoline_target): Update.
1281         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1282         * coffread.c (coff_symfile_read): Update.
1283         * ada-lang.c (ada_lookup_simple_minsym)
1284         (ada_collect_symbol_completion_matches): Update.
1285
1286 2019-01-16  Tom Tromey  <tom@tromey.com>
1287
1288         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1289         type.  Remove no-argument constructor.
1290         <iterator::operator++>: Simplify.
1291         <begin>: Update.
1292         <end>: Use minimal_symbol_count.
1293
1294 2019-01-16  Tom Tromey  <tom@tromey.com>
1295
1296         * objfiles.h (struct objfile) <psymtabs>: New method.
1297         (class objfile_psymtabs): Remove.
1298         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1299         typedef.
1300         <range>: New method.
1301         (require_partial_symbols): Change return type.
1302         * psymtab.c (require_partial_symbols)
1303         (psym_expand_symtabs_matching): Update.
1304         * mdebugread.c (parse_partial_symbols): Update.
1305         * dbxread.c (dbx_end_psymtab): Update.
1306
1307 2019-01-15  Tom Tromey  <tom@tromey.com>
1308
1309         * symtab.c (lookup_objfile_from_block)
1310         (lookup_symbol_in_objfile_symtabs)
1311         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1312         (find_line_symtab, info_sources_command)
1313         (default_collect_symbol_completion_matches_break_on)
1314         (make_source_files_completion_list): Update.
1315         * symmisc.c (print_objfile_statistics, dump_objfile)
1316         (maintenance_print_symbols, maintenance_info_symtabs)
1317         (maintenance_check_symtabs, maintenance_info_line_tables):
1318         Update.
1319         * source.c (select_source_symtab)
1320         (forget_cached_source_info_for_objfile): Update.
1321         * objfiles.h (class objfile_compunits): Remove.
1322         (struct objfile) <compunits_range>: New typedef.
1323         (compunits): New method.
1324         * objfiles.c (objfile_relocate1): Update.
1325         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1326         * maint.c (count_symtabs_and_blocks): Update.
1327         * linespec.c (iterate_over_all_matching_symtabs): Update.
1328         * cp-support.c (add_symbol_overload_list_qualified): Update.
1329         * coffread.c (coff_symtab_read): Update.
1330         * ada-lang.c (add_nonlocal_symbols)
1331         (ada_collect_symbol_completion_matches)
1332         (ada_add_global_exceptions): Update.
1333
1334 2019-01-15  Tom Tromey  <tom@tromey.com>
1335
1336         * progspace.h (program_space) <objfiles_safe_range>: New
1337         typedef.
1338         <objfiles_safe>: New method.
1339         * objfiles.h (class all_objfiles_safe): Remove.
1340         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1341         * jit.c (jit_inferior_exit_hook): Update.
1342
1343 2019-01-17  Tom Tromey  <tom@tromey.com>
1344
1345         * progspace.h (program_space) <objfiles_range>: New typedef.
1346         <objfiles>: New method.
1347         <objfiles_head>: Rename from objfiles.
1348         (object_files): Update.
1349         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1350         * guile/scm-pretty-print.c
1351         (ppscm_find_pretty_printer_from_objfiles): Update.
1352         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1353         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1354         Update.
1355         * python/py-progspace.c (pspy_get_objfiles): Update.
1356         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1357         Update.
1358         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1359         (objfpy_lookup_objfile_by_build_id): Update.
1360         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1361         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1362         Update.
1363         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1364         (expand_symtab_containing_pc, lookup_objfile_from_block)
1365         (lookup_static_symbol, basic_lookup_transparent_type)
1366         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1367         (find_line_symtab, info_sources_command)
1368         (default_collect_symbol_completion_matches_break_on)
1369         (make_source_files_completion_list, find_main_name): Update.
1370         * symmisc.c (print_symbol_bcache_statistics)
1371         (print_objfile_statistics, maintenance_print_symbols)
1372         (maintenance_print_msymbols, maintenance_print_objfiles)
1373         (maintenance_info_symtabs, maintenance_check_symtabs)
1374         (maintenance_expand_symtabs, maintenance_info_line_tables):
1375         Update.
1376         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1377         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1378         (map_overlay_command, unmap_overlay_command)
1379         (simple_overlay_update, expand_symtabs_matching)
1380         (map_symbol_filenames): Update.
1381         * symfile-debug.c (set_debug_symfile): Update.
1382         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1383         Update.
1384         * source.c (select_source_symtab, forget_cached_source_info):
1385         Update.
1386         * solib.c (solib_read_symbols): Update.
1387         * solib-spu.c (append_ocl_sos): Update.
1388         * psymtab.c (maintenance_print_psymbols)
1389         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1390         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1391         * printcmd.c (info_symbol_command): Update.
1392         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1393         Update.
1394         * objfiles.h (class all_objfiles): Remove.
1395         * objfiles.c (have_partial_symbols, have_full_symbols)
1396         (have_minimal_symbols, qsort_cmp, update_section_map)
1397         (shared_objfile_contains_address_p)
1398         (default_iterate_over_objfiles_in_search_order): Update.
1399         * objc-lang.c (info_selectors_command, info_classes_command)
1400         (find_methods): Update.
1401         * minsyms.c (find_solib_trampoline_target): Update.
1402         * maint.c (maintenance_info_sections)
1403         (maintenance_translate_address, count_symtabs_and_blocks):
1404         Update.
1405         * main.c (captured_main_1): Update.
1406         * linux-thread-db.c (try_thread_db_load_from_pdir)
1407         (has_libpthread): Update.
1408         * linespec.c (iterate_over_all_matching_symtabs)
1409         (search_minsyms_for_name): Update.
1410         * jit.c (jit_find_objf_with_entry_addr): Update.
1411         * hppa-tdep.c (find_unwind_entry)
1412         (hppa_lookup_stub_minimal_symbol): Update.
1413         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1414         Update.
1415         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1416         (elf_gnu_ifunc_resolve_by_got): Update.
1417         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1418         * dwarf-index-write.c (save_gdb_index_command): Update.
1419         * cp-support.c (add_symbol_overload_list_qualified): Update.
1420         * breakpoint.c (create_overlay_event_breakpoint)
1421         (create_longjmp_master_breakpoint)
1422         (create_std_terminate_master_breakpoint)
1423         (create_exception_master_breakpoint): Update.
1424         * blockframe.c (find_pc_partial_function): Update.
1425         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1426         (ada_collect_symbol_completion_matches)
1427         (ada_add_global_exceptions): Update.
1428
1429 2019-01-17  Tom Tromey  <tom@tromey.com>
1430
1431         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1432         declare VEC.
1433         (solib_target_parse_libraries): Change return type.
1434         (library_list_start_segment, library_list_start_section)
1435         (library_list_end_library, library_list_start_library); Update.
1436         (solib_target_free_library_list): Remove.
1437         (solib_target_parse_libraries): Remove cleanup.  Change return
1438         type.
1439         (solib_target_current_sos): Update.
1440
1441 2019-01-17  Tom Tromey  <tromey@bapiya>
1442
1443         * valprint.c: Replace "the the" with "the".
1444         * symtab.c: Replace "the the" with "the".
1445         * solib.c: Replace "the the" with "the".
1446         * solib-dsbt.c: Replace "the the" with "the".
1447         * linespec.c: Replace "the the" with "the".
1448         * dwarf2loc.h: Replace "the the" with "the".
1449         * amd64-windows-tdep.c: Replace "the the" with "the".
1450         * aarch64-tdep.c: Replace "the the" with "the".
1451
1452 2019-01-16  Keith Seitz  <keiths@redhat.com>
1453
1454         PR gdb/23773
1455         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1456         <builder>: Rename to ..
1457         <m_builder>: ... this and make private.
1458         (dwarf2_cu::get_builder): New method.  Change all users of
1459         `builder' to use this method.
1460         (dwarf2_start_symtab): Move to ...
1461         (dwarf2_cu::start_symtab): ... here.  Update all callers
1462         (setup_type_unit_groups): Move to ...
1463         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1464         callers.
1465         (dwarf2_cu::reset_builder): New method.
1466         (process_full_compunit, process_full_type_unit): Use
1467         dwarf2_cu::reset_builder.
1468         (follow_die_offset): Record the ancestor CU if it is different
1469         from the followed DIE's CU.
1470         (follow_die_sig_1): Likewise.
1471
1472 2019-01-15  Tom Tromey  <tom@tromey.com>
1473
1474         * remote.c (class remote_state) <buf>: Now a char_vector.
1475         <buf_size>: Remove.
1476         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1477         parameter.
1478         (remote_target::getpkt_or_notif_sane_1)
1479         (remote_target::getpkt_sane)
1480         (remote_target::getpkt_or_notif_sane): Likewise.
1481         (class remote_target) <putpkt>: New overload.
1482         (remote_target::read_frame): Change type of "buf_p".  Remove
1483         sizeof_p parameter.
1484         (packet_ok): New overload.
1485         (packet_check_result): New overload.
1486         Update all uses.
1487
1488 2019-01-14  Tom Tromey  <tom@tromey.com>
1489
1490         * remote-notif.c (handle_notification, remote_notif_ack)
1491         (remote_notif_parse): Make "buf" const.
1492         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1493         const.
1494         (remote_notif_parse, remote_notif_ack, handle_notification):
1495         Likewise.
1496         * remote.c (remote_notif_stop_parse): Make "buf" const.
1497         (remote_target::remote_parse_stop_reply): Make "buf" const.
1498         (remote_notif_stop_ack): Make "buf" const.
1499
1500 2019-01-14  Tom Tromey  <tom@tromey.com>
1501
1502         * remote.c (remote_console_output): Make parameter const.
1503
1504 2019-01-14  Tom Tromey  <tom@tromey.com>
1505
1506         * target-debug.h (target_debug_print_signals): Constify.
1507         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1508         * procfs.c (procfs_target::pass_signals): Update.
1509         * linux-nat.c (linux_nat_target::pass_signals): Update.
1510         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1511         * target-delegates.c: Rebuild.
1512         * remote.c (remote_target::program_signals): Update.
1513         (remote_target::pass_signals): Update.
1514         * target.c (target_pass_signals): Constify argument.
1515         (target_program_signals): Likewise.
1516         * target.h (struct target_ops) <pass_signals, program_signals>:
1517         Constify argument.
1518         (target_pass_signals, target_program_signals): Constify argument.
1519
1520 2019-01-14  Tom Tromey  <tom@tromey.com>
1521
1522         PR tui/28819:
1523         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1524
1525 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1526
1527         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1528         field.
1529         * rs6000-tdep.c: Include reggroups.h.
1530         (IS_V_ALIAS_PSEUDOREG): Define.
1531         (rs6000_register_name): Return names for the "vX" aliases.
1532         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1533         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1534         aliases.  Call default_register_reggroup_p for all other
1535         pseudo-registers.
1536         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1537         New functions.
1538         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1539         Handle "vX" aliases.
1540         (v_alias_pseudo_register_collect): New function.
1541         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1542         (rs6000_gdbarch_init): Initialize "vX" aliases as
1543         pseudo-registers.  Restore registration of
1544         rs6000_pseudo_register_reggroup_p with
1545         set_tdesc_pseudo_register_reggroup_p.
1546
1547 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1548
1549         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1550         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1551         set_gdbarch_num_pseudo_regs.
1552
1553 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1554
1555         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1556         Remove arg prefixname, add do_set and do_show.
1557         Add member functions set_list and show_list.
1558         * cli/cli-style.c (class cli_style_option): Update accordingly.
1559         (style_set_list): Move to file scope.
1560         (style_show_list): Likewise.
1561         (set_style): Call help_list.
1562         (show_style): Call cmd_show_list.
1563         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1564         Update to use the new macro.
1565
1566 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1567
1568         * ada-lang.c (_initialize_ada_language): Expand the help text
1569         for the "catch exception" command.
1570
1571 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1572
1573         * symtab.c (matching_obj_sections): Initialize obj,
1574         declare it closer to its usage.
1575
1576 2019-01-10  Tom Tromey  <tom@tromey.com>
1577
1578         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1579         (basic_inf_threads_range): Remove.
1580         (inf_threads_range, inf_non_exited_threads_range)
1581         (safe_inf_threads_range): Use next_adapter.
1582
1583 2019-01-10  Keith Seitz  <keiths@redhat.com>
1584
1585         PR gdb/23712
1586         PR symtab/23010
1587         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1588         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1589
1590 2019-01-10  Keith Seitz  <keiths@redhat.com>
1591
1592         PR gdb/23712
1593         PR symtab/23010
1594         * dictionary.c (pending_to_vector): Remove.
1595         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1596         Remove _1 suffix, replacing functions of the same name.  Update
1597         all callers.
1598         (dict_create_hashed, dict_create_hashed_expandable)
1599         (dict_create_linear, dict_create_linear_expandable, dict_free)
1600         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1601         Make functions static.
1602
1603 2019-01-10  Keith Seitz  <keiths@redhat.com>
1604
1605         PR gdb/23712
1606         PR symtab/23010
1607         * dictionary.h (struct dictionary): Replace declaration with
1608         multidictionary.
1609         (dict_create_hashed, dict_create_hashed_expandable)
1610         (dict_create_linear, dict_create_linear_expandable)
1611         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1612         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1613         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1614         taking multidictionary argument.
1615         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1616         * block.h (struct block) <dict>: Change to multidictionary
1617         and rename `multidict'.
1618         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1619         symmisc.c: Update all dictionary references to multidictionary.
1620
1621 2019-01-10  Keith Seitz  <keiths@redhat.com>
1622
1623         PR gdb/23712
1624         PR symtab/23010
1625         * dictionary.c: Include unordered_map.
1626         (pending_to_vector): New function.
1627         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1628         Rewrite the non-"_1" functions to take vector instead
1629         of linked list.
1630         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1631         "new" _1 versions of the same name.
1632         (multidictionary): Define.
1633         (std::hash<enum language): New definition.
1634         (collate_pending_symbols_by_language, mdict_create_hashed)
1635         (mdict_create_hashed_expandable, mdict_create_linear)
1636         (mdict_create_linear_expandable, mdict_free)
1637         (find_language_dictionary, create_new_language_dictionary)
1638         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1639         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1640         (mdict_size, mdict_empty): New functions.
1641         * dictionary.h (mdict_iterator): Define.
1642
1643 2019-01-10  Pedro Alves  <palves@redhat.com>
1644
1645         * breakpoint.c (read_uploaded_action)
1646         (create_tracepoint_from_upload): Adjust to use
1647         gdb::unique_xmalloc_ptr.
1648         * ctf.c (ctf_write_uploaded_tp):
1649         (SET_ARRAY_FIELD): Use emplace_back.
1650         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1651         * tracefile-tfile.c (tfile_write_uploaded_tp):
1652         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1653         gdb::unique_xmalloc_ptr.
1654         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1655         at_string, cond_string, cmd_strings>: Replace char pointers
1656         with gdb::unique_xmalloc_ptr.
1657
1658 2019-01-10  Pedro Alves  <palves@redhat.com>
1659
1660         * solib-target.c (library_list_start_library): Don't xstrdup name.
1661
1662 2019-01-10  Pedro Alves  <palves@redhat.com>
1663
1664         * mdebugread.c (parse_partial_symbols): Use
1665         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1666
1667 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1668
1669         * linux-fork.c (scoped_switch_fork_info)
1670         <~scoped_switch_fork_info>: Fix incorrect variable name.
1671
1672 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1673
1674         * linux-fork.c (scoped_switch_fork_info)
1675         <scoped_switch_fork_info>: Make explicit.
1676         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1677
1678 2019-01-10  Tom Tromey  <tom@tromey.com>
1679
1680         * objfiles.h (objfile::reset_psymtabs): Update.
1681         * objfiles.c (objfile::objfile): Update.
1682         * psymtab.h (psymtab_storage::obstack): Update.
1683         (psymtab_storage::m_obstack): Use gdb::optional.
1684         (class psymtab_storage): Update comment.  Remove objfile
1685         parameter.
1686         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1687
1688 2019-01-10  Tom Tromey  <tom@tromey.com>
1689
1690         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1691         <free_psymtabs>: Now private.
1692         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1693         (allocate_psymtab): Use new method.
1694
1695 2019-01-10  Tom Tromey  <tom@tromey.com>
1696
1697         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1698         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1699         * mdebugread.c (parse_partial_symbols): Use
1700         allocate_dependencies.
1701         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1702         allocate_dependencies.
1703         (process_psymtab_comp_unit_reader)
1704         (build_type_psymtab_dependencies): Likewise.
1705         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1706
1707 2019-01-10  Tom Tromey  <tom@tromey.com>
1708
1709         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1710         PSYMBOL_SET_LANGUAGE.
1711         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1712
1713 2019-01-10  Tom Tromey  <tom@tromey.com>
1714
1715         * psymtab.h (psymtab_storage::obstack): New method.
1716         <m_obstack>: Rename from obstack; now private.
1717         * psymtab.c (psymtab_storage): Update.
1718         * dwarf2read.c (create_addrmap_from_index)
1719         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1720         Update.
1721
1722 2019-01-10  Tom Tromey  <tom@tromey.com>
1723
1724         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1725         * objfiles.h (objfile::reset_psymtabs): New method.
1726
1727 2019-01-10  Tom Tromey  <tom@tromey.com>
1728
1729         * symmisc.c (print_symbol_bcache_statistics): Update.
1730         (print_objfile_statistics): Update.
1731         * symfile.c (reread_symbols): Update.
1732         * psymtab.h (class psymtab_storage): New.
1733         * psymtab.c (psymtab_storage): New constructor.
1734         (~psymtab_storage): New destructor.
1735         (require_partial_symbols): Update.
1736         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1737         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1738         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1739         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1740         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1741         (start_psymtab_common, end_psymtab_common)
1742         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1743         (allocate_psymtab): Update.
1744         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1745         Update.
1746         (dump_psymtab_addrmap, maintenance_print_psymbols)
1747         (maintenance_check_psymtabs): Update.
1748         (class objfile_psymtabs): Move to objfiles.h.
1749         * psympriv.h (discard_psymtab): Now inline.
1750         (psymtab_discarder::psymtab_discarder): Update.
1751         (psymtab_discarder::~psymtab_discarder): Update.
1752         (ALL_OBJFILE_PSYMTABS): Rewrite.
1753         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1754         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1755         Remove fields.
1756         <partial_symtabs>: New field.
1757         (class objfile_psymtabs): Move from psymtab.h.  Update.
1758         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1759         psymbol_cache.
1760         (objfile::~objfile): Don't destroy psymbol_cache.
1761         * mdebugread.c (parse_partial_symbols): Update.
1762         * dwarf2read.c (create_addrmap_from_index)
1763         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1764         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1765         (add_partial_subprogram, dwarf2_ranges_read): Update.
1766         * dwarf-index-write.c (write_address_map)
1767         (write_one_signatured_type, recursively_write_psymbols)
1768         (class debug_names, class debug_names, write_psymtabs_to_index):
1769         Update.
1770
1771 2019-01-10  Tom Tromey  <tom@tromey.com>
1772
1773         * symtab.h (SYMBOL_SET_NAMES): Update.
1774         (symbol_set_names): Update.
1775         (MSYMBOL_SET_NAMES): Update.
1776         * symtab.c (symbol_set_names): Change argument to be an
1777         objfile_per_bfd_storage.
1778         * psymtab.c (add_psymbol_to_bcache): Update.
1779         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1780
1781 2019-01-10  Tom Tromey  <tom@tromey.com>
1782
1783         * symtab.c (create_demangled_names_hash): Change argument to be an
1784         objfile_per_bfd_storage.
1785         (symbol_set_names): Update.
1786
1787 2019-01-10  Tom Tromey  <tom@tromey.com>
1788
1789         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1790         init_psymbol_list.
1791         * psymtab.c (init_psymbol_list): Do nothing if already called.
1792         * psympriv.h (init_psymbol_list): Add comment.
1793         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1794         init_psymbol_list.
1795         * dbxread.c (dbx_symfile_read): Unconditionally call
1796         init_psymbol_list.
1797
1798 2019-01-10  Tom Tromey  <tom@tromey.com>
1799
1800         * xcoffread.c (scan_xcoff_symtab): Update.
1801         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1802         "where".
1803         * mdebugread.c (parse_partial_symbols)
1804         (handle_psymbol_enumerators): Update.
1805         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1806         * dbxread.c (read_dbx_symtab): Update.
1807         * psympriv.h (psymbol_placement): New enum.
1808         (add_psymbol_to_list): Update.
1809
1810 2019-01-10  Tom Tromey  <tom@tromey.com>
1811
1812         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1813         static_psymbols parameters.
1814         (scan_xcoff_symtab): Update.
1815         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1816         static_psymbols parameters.
1817         * psympriv.h (start_psymtab_common): Update.
1818         * mdebugread.c (parse_partial_symbols): Update.
1819         * dwarf2read.c (create_partial_symtab): Update.
1820         * dbxread.c (read_dbx_symtab): Update.
1821         (start_psymtab): Remove global_psymbols and static_psymbols
1822         parameters.
1823
1824 2019-01-10  Tom Tromey  <tom@tromey.com>
1825
1826         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1827         * psymtab.c (allocate_psymtab): Add comment.
1828         * psympriv.h (allocate_psymtab): Add comment.
1829         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1830         initializations.
1831         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1832
1833 2019-01-10  Tom Tromey  <tom@tromey.com>
1834
1835         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1836         Don't declare.
1837         * mipsread.c: Include mdebugread.h.
1838         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1839         Declare.
1840         * elfread.c: Include mdebugread.h.
1841
1842 2019-01-09  Tom Tromey  <tom@tromey.com>
1843
1844         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1845         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1846         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1847         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1848         (psym_lookup_symbol, psym_find_last_source_symtab)
1849         (psym_forget_cached_source_info, psym_print_stats)
1850         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1851         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1852         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1853         (psym_find_compunit_symtab_by_address)
1854         (maintenance_print_psymbols, maintenance_info_psymtabs)
1855         (maintenance_check_psymtabs): Use ranged for.
1856         * psymtab.h (class objfile_psymtabs): New.
1857         (require_partial_symbols): Return objfile_psymtabs.
1858         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1859
1860 2019-01-09  Tom Tromey  <tom@tromey.com>
1861
1862         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1863         (find_pc_mapped_section, list_overlays_command)
1864         (map_overlay_command, unmap_overlay_command)
1865         (simple_overlay_update): Use all_objfiles.
1866         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1867         * printcmd.c (info_symbol_command): Use all_objfiles.
1868         * objfiles.h (ALL_OBJSECTIONS): Remove.
1869         * maint.c (maintenance_translate_address): Use all_objfiles.
1870         * gcore.c (gcore_create_callback): Use all_objfiles.
1871         (objfile_find_memory_regions): Likewise.
1872
1873 2019-01-09  Tom Tromey  <tom@tromey.com>
1874
1875         * symtab.c (find_line_symtab, info_sources_command)
1876         (make_source_files_completion_list): Use objfile_compunits.
1877         * source.c (select_source_symtab): Use objfile_compunits.
1878         * objfiles.h (struct objfile): Update comment.
1879         (ALL_OBJFILES): Remove.
1880         (ALL_FILETABS): Remove.
1881         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1882         objfile_compunits.
1883
1884 2019-01-09  Tom Tromey  <tom@tromey.com>
1885
1886         * symmisc.c (print_objfile_statistics, dump_objfile)
1887         (maintenance_print_symbols): Use compunit_filetabs.
1888         * source.c (forget_cached_source_info_for_objfile): Use
1889         compunit_filetabs.
1890         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1891         (ALL_FILETABS): Use compunit_filetabs.
1892         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1893         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1894
1895 2019-01-09  Tom Tromey  <tom@tromey.com>
1896
1897         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1898         (compunit_filetabs): New.
1899         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1900         compunit_filetabs.
1901         (info_sources_command, make_source_files_completion_list): Remove
1902         declaration.
1903         * symmisc.c (print_objfile_statistics, dump_objfile)
1904         (maintenance_print_symbols): Remove declaration.
1905         (maintenance_info_symtabs): Use compunit_filetabs.
1906         (maintenance_info_line_tables): Likewise.
1907         * source.c (select_source_symtab): Change local variable name.
1908         (forget_cached_source_info_for_objfile): Remove declaration.
1909         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1910         * objfiles.c (objfile_relocate1): Remove declaration.
1911         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1912         declaration.
1913         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1914         * coffread.c (coff_symtab_read): Remove declaration.
1915         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1916         compunit_filetabs.
1917
1918 2019-01-09  Tom Tromey  <tom@tromey.com>
1919
1920         * symtab.c (lookup_objfile_from_block)
1921         (find_pc_sect_compunit_symtab, search_symbols)
1922         (default_collect_symbol_completion_matches_break_on): Use
1923         objfile_compunits.
1924         * objfiles.h (ALL_COMPUNITS): Remove.
1925         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1926         * cp-support.c (add_symbol_overload_list_qualified): Use
1927         objfile_compunits.
1928         * ada-lang.c (ada_collect_symbol_completion_matches)
1929         (ada_add_global_exceptions): Use objfile_compunits.
1930
1931 2019-01-09  Tom Tromey  <tom@tromey.com>
1932
1933         * source.c (select_source_symtab)
1934         (forget_cached_source_info_for_objfile): Remove declaration.
1935         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1936         declaration.
1937         * maint.c (count_symtabs_and_blocks): Remove declaration.
1938         * cp-support.c (add_symbol_overload_list_qualified): Remove
1939         declaration.
1940         * coffread.c (coff_symtab_read): Remove declaration.
1941         * symtab.c (lookup_symbol_in_objfile_symtabs)
1942         (basic_lookup_transparent_type_1): Use objfile_compunits.
1943         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
1944         (info_sources_command, search_symbols)
1945         (default_collect_symbol_completion_matches_break_on)
1946         (make_source_files_completion_list): Remove declaration.
1947         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
1948         (ada_collect_symbol_completion_matches)
1949         (ada_add_global_exceptions): Remove declaration.
1950         * linespec.c (iterate_over_all_matching_symtabs): Use
1951         objfile_compunits.
1952         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
1953         (class objfile_compunits): New.
1954         (ALL_COMPUNITS): Use objfile_compunits.
1955         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
1956         (maintenance_check_symtabs, maintenance_info_line_tables): Use
1957         objfile_compunits.
1958         * objfiles.c (objfile_relocate1): Use objfile_compunits.
1959
1960 2019-01-09  Tom Tromey  <tom@tromey.com>
1961
1962         * symtab.c (search_symbols)
1963         (default_collect_symbol_completion_matches_break_on): Use
1964         objfile_msymbols.
1965         * ada-lang.c (ada_lookup_simple_minsym)
1966         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
1967         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
1968         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
1969         objfile_msymbols.
1970         * coffread.c (coff_symfile_read): Use objfile_msymbols.
1971         * symmisc.c (dump_msymbols): Use objfile_msymbols.
1972         * objc-lang.c (find_methods): Use objfile_msymbols.
1973         (info_selectors_command, info_classes_command): Likewise.
1974         * stabsread.c (scan_file_globals): Use objfile_msymbols.
1975         * objfiles.h (class objfile_msymbols): New.
1976         (ALL_OBJFILE_MSYMBOLS): Remove.
1977         (ALL_MSYMBOLS): Remove.
1978
1979 2019-01-09  Tom Tromey  <tom@tromey.com>
1980
1981         * common/next-iterator.h (next_adapter): Add Iterator template
1982         parameter.
1983         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
1984         (class all_objfiles_safe): New.
1985         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
1986         * objfiles.c (put_objfile_before): Update comment.
1987         (add_separate_debug_objfile): Likewise.
1988         (free_all_objfiles): Use all_objfiles_safe.
1989         (objfile_purge_solibs): Likewise.
1990
1991 2019-01-09  Tom Tromey  <tom@tromey.com>
1992
1993         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1994         (expand_symtab_containing_pc, lookup_static_symbol)
1995         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
1996         (find_symbol_at_address, find_line_symtab, find_main_name): Use
1997         all_objfiles.
1998         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
1999         * breakpoint.c (create_overlay_event_breakpoint)
2000         (create_longjmp_master_breakpoint)
2001         (create_std_terminate_master_breakpoint)
2002         (create_exception_master_breakpoint): Use all_objfiles.
2003         * linux-thread-db.c (try_thread_db_load_from_pdir)
2004         (has_libpthread): Use all_objfiles.
2005         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2006         * linespec.c (iterate_over_all_matching_symtabs)
2007         (search_minsyms_for_name): Use all_objfiles.
2008         * maint.c (maintenance_info_sections): Use all_objfiles.
2009         * main.c (captured_main_1): Use all_objfiles.
2010         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2011         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2012         * guile/scm-pretty-print.c
2013         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2014         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2015         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2016         (maintenance_print_msymbols): Use all_objfiles.
2017         * source.c (select_source_symtab): Use all_objfiles.
2018         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2019         * symfile.c (remove_symbol_file_command)
2020         (expand_symtabs_matching, map_symbol_filenames): Use
2021         all_objfiles.
2022         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2023         all_objfiles.
2024         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2025         * objc-lang.c (find_methods): Use all_objfiles.
2026         * objfiles.c (have_partial_symbols, have_full_symbols)
2027         (have_minimal_symbols, qsort_cmp)
2028         (default_iterate_over_objfiles_in_search_order): Use
2029         all_objfiles.
2030         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2031         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2032         (maintenance_check_psymtabs): Use all_objfiles.
2033         (ALL_PSYMTABS): Remove.
2034         * compile/compile-object-run.c (do_module_cleanup): Use
2035         all_objfiles.
2036         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2037         * cp-support.c (add_symbol_overload_list_qualified): Use
2038         all_objfiles.
2039         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2040         Use all_objfiles.
2041         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2042         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2043         all_objfiles.
2044         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2045         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2046         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2047         Uses all_objfiles.
2048         * solib.c (solib_read_symbols): Use all_objfiles
2049
2050 2019-01-09  Tom Tromey  <tom@tromey.com>
2051
2052         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2053         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2054         all_objfiles.
2055         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2056         * symmisc.c (print_symbol_bcache_statistics)
2057         (print_objfile_statistics, maintenance_print_objfiles)
2058         (maintenance_info_symtabs, maintenance_check_symtabs)
2059         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2060         all_objfiles.
2061         * source.c (forget_cached_source_info): Use all_objfiles.
2062         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2063         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2064         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2065         * objfiles.c (update_section_map): Use all_objfiles.
2066         (shared_objfile_contains_address_p): Likewise.
2067         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2068         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2069
2070 2019-01-09  Tom Tromey  <tom@tromey.com>
2071
2072         * common/next-iterator.h: New file.
2073         * objfiles.h (class all_objfiles): New.
2074         (struct objfile_iterator): New.
2075
2076 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2077
2078         * NEWS: Move the description of the changed "frame", "select-frame",
2079          and "info frame" commands to the Changed commands section.
2080
2081 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2082
2083         * gdbtypes.c (check_stub_method_group): Remove handling of old
2084         mangling schemes.
2085         * linespec.c (find_methods): Likewise.
2086         * stabsread.c (read_member_functions): Likewise.
2087         * valops.c (search_struct_method): Likewise.
2088         (value_struct_elt_for_reference): Likewise.
2089         * NEWS: Mention this change.
2090
2091 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2092
2093         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2094         print_source_lines.
2095         * source.c (print_source_lines_base): Update line number check.
2096         (print_source_lines): New function.
2097         (source_lines_range::source_lines_range): New function.
2098         * source.h (class source_lines_range): New class.
2099         (print_source_lines): New declaration.
2100
2101 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2102
2103         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2104
2105 2019-01-08  Tom Tromey  <tom@tromey.com>
2106             Simon Marchi  <simon.marchi@ericsson.com>
2107
2108         PR gdb/24060
2109         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2110         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2111         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2112         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2113         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2114         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2115
2116 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2117
2118         * source.c (select_source_symtab): Move header comment to
2119         declaration in source.h.
2120         (forget_cached_source_info_for_objfile): Likewise.
2121         (forget_cached_source_info): Likewise.
2122         (identify_source_line): Likewise.
2123         * source.h (identify_source_line): Move declaration from symtab.h
2124         and add comment from source.c
2125         (print_source_lines): Likewise.
2126         (forget_cached_source_info_for_objfile): Likewise.
2127         (forget_cached_source_info): Likewise.
2128         (select_source_symtab): Likewise.
2129         (enum print_source_lines_flag): Move definition from symtab.h.
2130         * symtab.h (identify_source_line): Move declaration to source.h.
2131         (print_source_lines): Likewise.
2132         (forget_cached_source_info_for_objfile): Likewise.
2133         (forget_cached_source_info): Likewise.
2134         (select_source_symtab): Likewise.
2135         (enum print_source_lines_flag): Move definition to source.h.
2136         * tui/tui-hooks.c: Add 'source.h' include.
2137
2138 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2139
2140         * source.c (print_source_lines_base): Handle requests to print
2141         reverse line number sequences, and guard against empty lines
2142         string.
2143
2144 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2145
2146         * source.c (print_source_lines_base): Fix skip of '\r' if next
2147         character is '\n'.
2148
2149 2019-01-06  Tom Tromey  <tom@tromey.com>
2150
2151         * c-exp.y (struct c_parse_state) <macro_original_text,
2152         expansion_obstack>: New member.
2153         (macro_original_text, expansion_obstack): Remove globals.
2154         (scan_macro_expansion, scanning_macro_expansion)
2155         (finished_macro_expansion): Update.
2156         (scan_macro_cleanup): Remove.
2157         (yylex, c_parse): Update.
2158
2159 2019-01-06  Tom Tromey  <tom@tromey.com>
2160
2161         * c-exp.y (struct c_parse_state) <strings>: New member.
2162         (operator_stoken): Update.
2163
2164 2019-01-06  Tom Tromey  <tom@tromey.com>
2165
2166         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2167         (union type_stack_elt) <typelist_val>: Now a pointer to
2168         std::vector.
2169         (type_stack_cleanup): Don't declare.
2170         (push_typelist): Update.
2171         * parse.c (pop_typelist): Return a std::vector.
2172         (push_typelist): Take a std::vector.
2173         (follow_types): Update.  Do not free args.
2174         (type_stack_cleanup): Remove.
2175         * c-exp.y (struct c_parse_state): New.
2176         (cpstate): New global.
2177         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2178         (nonempty_typelist): Update.
2179         (func_mod): Create a new vector.
2180         (c_parse): Create a c_parse_state.
2181         (check_parameter_typelist): Do not delete params.
2182         (function_method): Update.  Do not delete type_list.
2183
2184 2019-01-06  Tom Tromey  <tom@tromey.com>
2185
2186         PR gdb/28155:
2187         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2188         check_typedef.
2189         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2190         (print_return_value): Likewise.
2191
2192 2019-01-05  Tom Tromey  <tom@tromey.com>
2193
2194         * contrib/cleanup_check.py: Remove.
2195         * contrib/gcc-with-excheck: Remove.
2196         * contrib/exsummary.py: Remove.
2197         * contrib/excheck.py: Remove.
2198
2199 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2200
2201         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2202         NULL. Initialize tpprev to NULL instead of assigning it
2203         to NULL on the next statement.
2204         * windows-nat.c (windows_delete_thread): Remove check for
2205         main_thread_id before printing thread exit notifications.
2206         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2207         Remove thread ID check against main_thread_id.
2208         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2209         windows_delete_thread.
2210         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2211
2212 2019-01-04  Tom Tromey  <tom@tromey.com>
2213
2214         * compile/compile.c (_initialize_compile): Use upper case for
2215         metasyntactic variables.
2216         * symmisc.c (_initialize_symmisc): Use upper case for
2217         metasyntactic variables.
2218         * psymtab.c (_initialize_psymtab): Use upper case for
2219         metasyntactic variables.
2220         * demangle.c (demangle_command): Use upper case for metasyntactic
2221         variables.
2222         (_initialize_demangler): Likewise.
2223         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2224         variables.
2225
2226 2019-01-03  Tom Tromey  <tom@tromey.com>
2227
2228         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2229
2230 2019-01-03  Tom Tromey  <tom@tromey.com>
2231
2232         * python/py-symtab.c (salpy_str): Update.
2233         (struct salpy_sal_object) <symtab>: Now a PyObject.
2234         (salpy_dealloc): Update.
2235         (del_objfile_sal): Use gdbpy_ref.
2236
2237 2019-01-03  Tom Tromey  <tom@tromey.com>
2238
2239         * python/py-type.c (convert_field): Use new_reference.  Return
2240         gdbpy_ref.
2241         (make_fielditem): Return gdbpy_ref.
2242         (typy_fields): Update.
2243         (typy_getitem): Update.
2244         (field_name): Return gdbpy_ref.  Use new_reference.
2245         (typy_iterator_iternext): Update.
2246
2247 2019-01-03  Tom Tromey  <tom@tromey.com>
2248
2249         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2250
2251 2019-01-03  Tom Tromey  <tom@tromey.com>
2252
2253         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2254         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2255         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2256         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2257         (pspy_set_type_printers): Likewise.
2258         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2259         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2260         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2261         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2262         (objfpy_set_type_printers): Likewise.
2263
2264 2019-01-03  Tom Tromey  <tom@tromey.com>
2265
2266         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2267         (gdbpy_print_stack): Use gdbpy_err_fetch.
2268         * python/python-internal.h (class gdbpy_err_fetch): New class.
2269         (class gdbpy_enter) <m_error_type, m_error_value,
2270         m_error_traceback>: Remove.
2271         <m_error>: New member.
2272         (gdbpy_exception_to_string): Don't declare.
2273         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2274         * python/py-value.c (convert_value_from_python): Use
2275         gdbpy_err_fetch.
2276         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2277         gdbpy_exception_to_string.
2278         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2279         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2280         gdbpy_err_fetch.
2281
2282 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2283
2284         * linux-nat.c (delete_lwp_cleanup): Delete.
2285         (struct lwp_deleter): New struct.
2286         (lwp_info_up): New typedef.
2287         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2288         lwp_info_up.
2289
2290 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2291
2292         * linux-fork.c (class scoped_switch_fork_info): New class.
2293         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2294
2295 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2296
2297         * valops.c (find_overload_match): Remove use of null_cleanup, and
2298         calls to do_cleanups.
2299
2300 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2301
2302         * compile/compile-cplus-types.c
2303         (compile_cplus_instance::decl_name): Handle changes to
2304         cp_func_name.
2305         * cp-support.c (cp_func_name): Update header comment, update
2306         return type.
2307         * cp-support.h (cp_func_name): Update return type in declaration.
2308         * valops.c (find_overload_match): Move temp_func local to top
2309         level of function and change its type.  Use temp_func to hold and
2310         delete temporary string obtained from cp_func_name.
2311
2312 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2313
2314         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2315         gdb::char_vector, remove cleanup, and update uses of `msg`.
2316
2317 2019-01-03  Jim Wilson  <jimw@sifive.com>
2318
2319         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2320
2321 2019-01-02  Tom Tromey  <tom@tromey.com>
2322
2323         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2324         (tdesc_parse_xml): Remove cleanups.
2325         * target-descriptions.h (make_cleanup_free_target_description):
2326         Don't declare.
2327         (target_desc_deleter): New struct.
2328         (target_desc_up): New typedef.
2329         * target-descriptions.c (target_desc_deleter::operator()): Rename
2330         from free_target_description.
2331         (make_cleanup_free_target_description): Remove.
2332
2333 2019-01-02  Tom Tromey  <tom@tromey.com>
2334
2335         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2336         constructor, destructor.
2337         (linespec_parser): Remove typedef.
2338         (~linespec_parser): Rename from linespec_parser_delete.
2339         (linespec_lex_to_end, linespec_complete_label)
2340         (linespec_complete): Update.
2341         (decode_line_full): Remove cleanups.
2342         (decode_line_1): Update.
2343
2344 2019-01-02  Tom Tromey  <tom@tromey.com>
2345
2346         * python/python-internal.h (inferior_to_inferior_object): Change
2347         return type.
2348         * python/py-exitedevent.c (create_exited_event_object): Update.
2349         * python/py-inferior.c (inferior_to_inferior_object): Return
2350         gdbpy_ref.
2351         (python_new_inferior, python_inferior_deleted)
2352         (thread_to_thread_object, delete_thread_object)
2353         (build_inferior_list, gdbpy_selected_inferior): Update.
2354         * python/py-infthread.c (create_thread_object): Update.  Also fail
2355         if inferior_to_inferior_object fails.
2356
2357 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2358
2359         * inferior.h (class inferior) <displaced_step_state>: New field.
2360         * infrun.h (struct displaced_step_state): Move here from
2361         infrun.c.  Initialize fields, add constructor.
2362         <inf>: Remove field.
2363         <reset>: New method.
2364         * infrun.c (struct displaced_step_inferior_state): Move to
2365         infrun.h.
2366         (displaced_step_inferior_states): Remove.
2367         (get_displaced_stepping_state): Adust.
2368         (displaced_step_in_progress_any_inferior): Adjust.
2369         (displaced_step_in_progress_thread): Adjust.
2370         (displaced_step_in_progress): Adjust.
2371         (add_displaced_stepping_state): Remove.
2372         (get_displaced_step_closure_by_addr): Adjust.
2373         (remove_displaced_stepping_state): Remove.
2374         (infrun_inferior_exit): Call displaced_step_state.reset.
2375         (use_displaced_stepping): Don't check for NULL.
2376         (displaced_step_prepare_throw): Call
2377         get_displaced_stepping_state.
2378         (displaced_step_fixup): Don't check for NULL.
2379         (prepare_for_detach): Don't check for NULL.
2380
2381 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2382
2383         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2384          in case of call that did not complete.
2385
2386 2019-01-02  Andrey Utkin  <autkin@undo.io>
2387
2388         * symfile.c (find_separate_debug_file): Fix search of debug files for
2389         remote debuggee.
2390
2391 2019-01-02  Tom Tromey  <tom@tromey.com>
2392
2393         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2394         indentation.
2395         * python/py-frame.c (frapy_older): Remove cast.
2396         (frapy_newer): Likewise.
2397         * python/py-breakpoint.c (local_setattro): Remove cast.
2398         * python/py-arch.c (archpy_name): Remove local variable.
2399         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2400
2401 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2402
2403         * unittests/basic_string_view/element_access/char/empty.cc:
2404         Fix year range in copyright header.
2405
2406 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2407
2408         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2409         Delete.
2410         <operator==>: Update with for removed field.
2411         <hash>: Likewise.
2412         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2413         <isa_features>: ...this.
2414         <abi_features>: New field.
2415         (riscv_isa_flen): Update comment.
2416         (riscv_abi_xlen): New declaration.
2417         (riscv_abi_flen): New declaration.
2418         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2419         isa_features.
2420         (riscv_abi_xlen): New function.
2421         (riscv_isa_flen): Update to get answer from isa_features.
2422         (riscv_abi_flen): New function.
2423         (riscv_has_fp_abi): Update to get answer from abi_features.
2424         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2425         xlen and flen.
2426         (riscv_call_info) <xlen, flen>: Update comment.
2427         (riscv_call_arg_struct): Remove invalid assertions
2428         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2429         is removed.
2430         (riscv_gdbarch_init): Gather isa features and abi features
2431         separately, ensure both match on the gdbarch when reusing an old
2432         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2433         a target with 64-bit float hardware.
2434
2435 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2436
2437         * source.c (search_command_helper): Stop reverse search
2438         when line 1 has been searched.
2439
2440 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2441
2442         * record-full.c (record_full_base_target::close): Rewrite
2443         record_full_core_buf_list free logic.
2444
2445 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2446
2447         * break-catch-syscall.c (print_one_catch_syscall): xfree
2448         the last text.
2449
2450 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2451
2452         * top.c (print_gdb_version): Update Copyright year in version
2453         message.
2454
2455 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2456
2457         Update copyright year range in all GDB files.
2458
2459 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2460
2461         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2462
2463 For older changes see ChangeLog-2018.
2464 \f
2465 Local Variables:
2466 mode: change-log
2467 left-margin: 8
2468 fill-column: 74
2469 version-control: never
2470 coding: utf-8
2471 End:
2472