gdb/ChangeLog

   1 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
   2             Tom Tromey  <tromey@adacore.com>
   3
   4         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
   5         (bp_location_ops): Remove.
   6         (base_breakpoint_allocate_location): Update.
   7         (free_bp_location): Update.
   8         * ada-lang.c (class ada_catchpoint_location)
   9         <ada_catchpoint_location>: Remove ops parameter.
  10         (ada_catchpoint_location_dtor): Remove.
  11         (ada_catchpoint_location_ops): Remove.
  12         (allocate_location_exception): Update.
  13         * breakpoint.h (struct bp_location_ops): Remove.
  14         (class bp_location) <bp_location>: Remove bp_location_ops
  15         parameter.
  16         <~bp_location>: Add destructor.
  17         <ops>: Remove.
  18
  19 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
  20             Pedro Alves  <palves@redhat.com>
  21
  22         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
  23         'PATH_MAX'.
  24
  25 2019-02-14  David Michael  <fedora.dm0@gmail.com>
  26             Samuel Thibault  <samuel.thibault@gnu.org>
  27             Thomas Schwinge  <thomas@codesourcery.com>
  28
  29         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
  30         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
  31
  32 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
  33
  34         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
  35         (check_empty): Use "const char *".
  36
  37         * gnu-nat.c (gnu_nat_target::detach): Instead of
  38         'detach_inferior (pid)' call
  39         'detach_inferior (find_inferior_pid (pid))'.
  40
  41         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
  42         'nat/fork-inferior.o'.
  43         * gnu-nat.c: #include "nat/fork-inferior.h".
  44
  45         * gnu-nat.c (gnu_nat_target::detach): Instead of
  46         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
  47         * gnu-nat.h: #include "inf-child.h".
  48         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
  49         'i386_gnu_nat_target::fetch_registers'.
  50         (gnu_store_registers): Rename/move to
  51         'i386_gnu_nat_target::store_registers'.
  52
  53         * config/i386/nm-i386gnu.h: Don't "#include" any files.
  54         * gnu-nat.h (mach_thread_info): New function.
  55         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
  56
  57         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
  58
  59 2019-02-14  Frederic Konrad  <konrad@adacore.com>
  60
  61         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
  62
  63 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
  64
  65         * windows-nat.c (windows_add_thread): Add new parameter
  66         "main_thread_p" with default value set to false.  Update
  67         function documentation as well as all callers.
  68         (windows_delete_thread): Likewise.
  69         (fake_create_process): Update call to windows_add_thread.
  70         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
  71         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
  72         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
  73         call to windows_delete_thread.
  74
  75 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
  76
  77         * MAINTAINERS: Add Andrew Burgess as global maintainer.
  78
  79 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
  80
  81         * symfile.c (find_separate_debug_file): Use canonical path of
  82         sysroot with child_path instead of gdb_sysroot if it is valid.
  83
  84 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
  85
  86         * symfile.c (find_separate_debug_file): Use child_path to
  87         determine if an object file is under a sysroot.
  88
  89 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
  90
  91         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
  92         unittests/child-path-selftests.c.
  93         * common/pathstuff.c (child_path): New function.
  94         * common/pathstuff.h (child_path): New prototype.
  95         * unittests/child-path-selftests.c: New file.
  96
  97 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
  98
  99         * symfile.c (find_separate_debug_file): Look for separate debug
 100         files in debug directories under the sysroot.
 101
 102 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 103
 104         * symtab.h (struct minimal_symbol data_p): New const method.
 105         (struct minimal_symbol text_p): Likewise.
 106         * symtab.c (output_source_filename): Use file name style
 107         to print file name.
 108         (print_symbol_info): Likewise.
 109         (print_msymbol_info): Use address style to print addresses.
 110         Use function name style to print executable text symbols.
 111         (expand_symtab_containing_pc): Use data_p.
 112         (find_pc_sect_compunit_symtab): Likewise.
 113
 114 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 115
 116         * breakpoint.c (describe_other_breakpoints): Use address style
 117         to print addresses.
 118         (say_where): Likewise.
 119
 120 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 121
 122         * ada-typeprint.c (print_func_type): Print function name
 123         style to print function name.
 124         * c-typeprint.c (c_print_type_1): Likewise.
 125
 126 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 127
 128         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 129         for execve.
 130
 131 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 132
 133         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 134         type_stack.
 135
 136 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 137
 138         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 139         TYPE_CODE_REF types.
 140
 141 2019-02-08  Jim Wilson  <jimw@sifive.com>
 142
 143         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 144         (riscv_linux_fregset): New.
 145         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 146
 147 2019-02-07  Tom Tromey  <tom@tromey.com>
 148
 149         * thread.c (thread_cancel_execution_command): Update.
 150         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 151         methods.
 152         (struct thread_fsm_ops): Remove.
 153         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 154         (thread_fsm_should_stop, thread_fsm_return_value)
 155         (thread_fsm_set_finished, thread_fsm_finished_p)
 156         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 157         Don't declare.
 158         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 159         * infrun.c (clear_proceed_status_thread)
 160         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 161         (print_stop_event): Update.
 162         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 163         Add constructor.
 164         (step_command_fsm_ops): Remove.
 165         (new_step_command_fsm): Remove.
 166         (step_1): Update.
 167         (step_command_fsm::should_stop): Rename from
 168         step_command_fsm_should_stop.
 169         (step_command_fsm::clean_up): Rename from
 170         step_command_fsm_clean_up.
 171         (step_command_fsm::do_async_reply_reason): Rename from
 172         step_command_fsm_async_reply_reason.
 173         (struct until_next_fsm): Inherit from thread_fsm.  Add
 174         constructor.
 175         (until_next_fsm_ops): Remove.
 176         (new_until_next_fsm): Remove.
 177         (until_next_fsm::should_stop): Rename from
 178         until_next_fsm_should_stop.
 179         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 180         (until_next_fsm::do_async_reply_reason): Rename from
 181         until_next_fsm_async_reply_reason.
 182         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 183         constructor.  Change type of breakpoint.
 184         (finish_command_fsm_ops): Remove.
 185         (new_finish_command_fsm): Remove.
 186         (finish_command_fsm::should_stop): Rename from
 187         finish_command_fsm_should_stop.
 188         (finish_command_fsm::clean_up): Rename from
 189         finish_command_fsm_clean_up.
 190         (finish_command_fsm::return_value): Rename from
 191         finish_command_fsm_return_value.
 192         (finish_command_fsm::do_async_reply_reason): Rename from
 193         finish_command_fsm_async_reply_reason.
 194         (finish_command): Update.
 195         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 196         Add constructor.
 197         (call_thread_fsm_ops): Remove.
 198         (call_thread_fsm::call_thread_fsm): Rename from
 199         new_call_thread_fsm.
 200         (call_thread_fsm::should_stop): Rename from
 201         call_thread_fsm_should_stop.
 202         (call_thread_fsm::should_notify_stop): Rename from
 203         call_thread_fsm_should_notify_stop.
 204         (run_inferior_call, call_function_by_hand_dummy): Update.
 205         * cli/cli-interp.c (should_print_stop_to_console): Update.
 206         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 207         Add constructor.  Change type of location_breakpoint,
 208         caller_breakpoint.
 209         (until_break_fsm_ops): Remove.
 210         (new_until_break_fsm): Remove.
 211         (until_break_fsm::should_stop): Rename from
 212         until_break_fsm_should_stop.
 213         (until_break_fsm::clean_up): Rename from
 214         until_break_fsm_clean_up.
 215         (until_break_fsm::do_async_reply_reason): Rename from
 216         until_break_fsm_async_reply_reason.
 217         (until_break_command): Update.
 218         * thread-fsm.c: Remove.
 219         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 220
 221 2019-02-07  Tom Tromey  <tom@tromey.com>
 222
 223         * yy-remap.h: Add include guard.
 224         * xtensa-tdep.h: Add include guard.
 225         * xcoffread.h: Rename include guard.
 226         * varobj-iter.h: Add include guard.
 227         * tui/tui.h: Rename include guard.
 228         * tui/tui-winsource.h: Rename include guard.
 229         * tui/tui-wingeneral.h: Rename include guard.
 230         * tui/tui-windata.h: Rename include guard.
 231         * tui/tui-win.h: Rename include guard.
 232         * tui/tui-stack.h: Rename include guard.
 233         * tui/tui-source.h: Rename include guard.
 234         * tui/tui-regs.h: Rename include guard.
 235         * tui/tui-out.h: Rename include guard.
 236         * tui/tui-layout.h: Rename include guard.
 237         * tui/tui-io.h: Rename include guard.
 238         * tui/tui-hooks.h: Rename include guard.
 239         * tui/tui-file.h: Rename include guard.
 240         * tui/tui-disasm.h: Rename include guard.
 241         * tui/tui-data.h: Rename include guard.
 242         * tui/tui-command.h: Rename include guard.
 243         * tic6x-tdep.h: Add include guard.
 244         * target/waitstatus.h: Rename include guard.
 245         * target/wait.h: Rename include guard.
 246         * target/target.h: Rename include guard.
 247         * target/resume.h: Rename include guard.
 248         * target-float.h: Rename include guard.
 249         * stabsread.h: Add include guard.
 250         * rs6000-tdep.h: Add include guard.
 251         * riscv-fbsd-tdep.h: Add include guard.
 252         * regformats/regdef.h: Rename include guard.
 253         * record.h: Rename include guard.
 254         * python/python.h: Rename include guard.
 255         * python/python-internal.h: Rename include guard.
 256         * python/py-stopevent.h: Rename include guard.
 257         * python/py-ref.h: Rename include guard.
 258         * python/py-record.h: Rename include guard.
 259         * python/py-record-full.h: Rename include guard.
 260         * python/py-record-btrace.h: Rename include guard.
 261         * python/py-instruction.h: Rename include guard.
 262         * python/py-events.h: Rename include guard.
 263         * python/py-event.h: Rename include guard.
 264         * procfs.h: Add include guard.
 265         * proc-utils.h: Add include guard.
 266         * p-lang.h: Add include guard.
 267         * or1k-tdep.h: Rename include guard.
 268         * observable.h: Rename include guard.
 269         * nto-tdep.h: Rename include guard.
 270         * nat/x86-linux.h: Rename include guard.
 271         * nat/x86-linux-dregs.h: Rename include guard.
 272         * nat/x86-gcc-cpuid.h: Add include guard.
 273         * nat/x86-dregs.h: Rename include guard.
 274         * nat/x86-cpuid.h: Rename include guard.
 275         * nat/ppc-linux.h: Rename include guard.
 276         * nat/mips-linux-watch.h: Rename include guard.
 277         * nat/linux-waitpid.h: Rename include guard.
 278         * nat/linux-ptrace.h: Rename include guard.
 279         * nat/linux-procfs.h: Rename include guard.
 280         * nat/linux-osdata.h: Rename include guard.
 281         * nat/linux-nat.h: Rename include guard.
 282         * nat/linux-namespaces.h: Rename include guard.
 283         * nat/linux-btrace.h: Rename include guard.
 284         * nat/glibc_thread_db.h: Rename include guard.
 285         * nat/gdb_thread_db.h: Rename include guard.
 286         * nat/gdb_ptrace.h: Rename include guard.
 287         * nat/fork-inferior.h: Rename include guard.
 288         * nat/amd64-linux-siginfo.h: Rename include guard.
 289         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 290         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 291         * nat/aarch64-linux.h: Rename include guard.
 292         * nat/aarch64-linux-hw-point.h: Rename include guard.
 293         * mn10300-tdep.h: Add include guard.
 294         * mips-linux-tdep.h: Add include guard.
 295         * mi/mi-parse.h: Rename include guard.
 296         * mi/mi-out.h: Rename include guard.
 297         * mi/mi-main.h: Rename include guard.
 298         * mi/mi-interp.h: Rename include guard.
 299         * mi/mi-getopt.h: Rename include guard.
 300         * mi/mi-console.h: Rename include guard.
 301         * mi/mi-common.h: Rename include guard.
 302         * mi/mi-cmds.h: Rename include guard.
 303         * mi/mi-cmd-break.h: Rename include guard.
 304         * m2-lang.h: Add include guard.
 305         * location.h: Rename include guard.
 306         * linux-record.h: Rename include guard.
 307         * linux-nat.h: Add include guard.
 308         * linux-fork.h: Add include guard.
 309         * i386-darwin-tdep.h: Rename include guard.
 310         * hppa-linux-offsets.h: Add include guard.
 311         * guile/guile.h: Rename include guard.
 312         * guile/guile-internal.h: Rename include guard.
 313         * gnu-nat.h: Rename include guard.
 314         * gdb-stabs.h: Rename include guard.
 315         * frv-tdep.h: Add include guard.
 316         * f-lang.h: Add include guard.
 317         * event-loop.h: Add include guard.
 318         * darwin-nat.h: Rename include guard.
 319         * cp-abi.h: Rename include guard.
 320         * config/sparc/nm-sol2.h: Rename include guard.
 321         * config/nm-nto.h: Rename include guard.
 322         * config/nm-linux.h: Add include guard.
 323         * config/i386/nm-i386gnu.h: Rename include guard.
 324         * config/djgpp/nl_types.h: Rename include guard.
 325         * config/djgpp/langinfo.h: Rename include guard.
 326         * compile/gcc-cp-plugin.h: Add include guard.
 327         * compile/gcc-c-plugin.h: Add include guard.
 328         * compile/compile.h: Rename include guard.
 329         * compile/compile-object-run.h: Rename include guard.
 330         * compile/compile-object-load.h: Rename include guard.
 331         * compile/compile-internal.h: Rename include guard.
 332         * compile/compile-cplus.h: Rename include guard.
 333         * compile/compile-c.h: Rename include guard.
 334         * common/xml-utils.h: Rename include guard.
 335         * common/x86-xstate.h: Rename include guard.
 336         * common/version.h: Rename include guard.
 337         * common/vec.h: Rename include guard.
 338         * common/tdesc.h: Rename include guard.
 339         * common/selftest.h: Rename include guard.
 340         * common/scoped_restore.h: Rename include guard.
 341         * common/scoped_mmap.h: Rename include guard.
 342         * common/scoped_fd.h: Rename include guard.
 343         * common/safe-iterator.h: Rename include guard.
 344         * common/run-time-clock.h: Rename include guard.
 345         * common/refcounted-object.h: Rename include guard.
 346         * common/queue.h: Rename include guard.
 347         * common/ptid.h: Rename include guard.
 348         * common/print-utils.h: Rename include guard.
 349         * common/preprocessor.h: Rename include guard.
 350         * common/pathstuff.h: Rename include guard.
 351         * common/observable.h: Rename include guard.
 352         * common/netstuff.h: Rename include guard.
 353         * common/job-control.h: Rename include guard.
 354         * common/host-defs.h: Rename include guard.
 355         * common/gdb_wait.h: Rename include guard.
 356         * common/gdb_vecs.h: Rename include guard.
 357         * common/gdb_unlinker.h: Rename include guard.
 358         * common/gdb_unique_ptr.h: Rename include guard.
 359         * common/gdb_tilde_expand.h: Rename include guard.
 360         * common/gdb_sys_time.h: Rename include guard.
 361         * common/gdb_string_view.h: Rename include guard.
 362         * common/gdb_splay_tree.h: Rename include guard.
 363         * common/gdb_setjmp.h: Rename include guard.
 364         * common/gdb_ref_ptr.h: Rename include guard.
 365         * common/gdb_optional.h: Rename include guard.
 366         * common/gdb_locale.h: Rename include guard.
 367         * common/gdb_assert.h: Rename include guard.
 368         * common/filtered-iterator.h: Rename include guard.
 369         * common/filestuff.h: Rename include guard.
 370         * common/fileio.h: Rename include guard.
 371         * common/environ.h: Rename include guard.
 372         * common/common-utils.h: Rename include guard.
 373         * common/common-types.h: Rename include guard.
 374         * common/common-regcache.h: Rename include guard.
 375         * common/common-inferior.h: Rename include guard.
 376         * common/common-gdbthread.h: Rename include guard.
 377         * common/common-exceptions.h: Rename include guard.
 378         * common/common-defs.h: Rename include guard.
 379         * common/common-debug.h: Rename include guard.
 380         * common/cleanups.h: Rename include guard.
 381         * common/buffer.h: Rename include guard.
 382         * common/btrace-common.h: Rename include guard.
 383         * common/break-common.h: Rename include guard.
 384         * cli/cli-utils.h: Rename include guard.
 385         * cli/cli-style.h: Rename include guard.
 386         * cli/cli-setshow.h: Rename include guard.
 387         * cli/cli-script.h: Rename include guard.
 388         * cli/cli-interp.h: Rename include guard.
 389         * cli/cli-decode.h: Rename include guard.
 390         * cli/cli-cmds.h: Rename include guard.
 391         * charset-list.h: Add include guard.
 392         * buildsym-legacy.h: Rename include guard.
 393         * bfin-tdep.h: Add include guard.
 394         * ax.h: Rename include guard.
 395         * arm-linux-tdep.h: Add include guard.
 396         * arm-fbsd-tdep.h: Add include guard.
 397         * arch/xtensa.h: Rename include guard.
 398         * arch/tic6x.h: Add include guard.
 399         * arch/i386.h: Add include guard.
 400         * arch/arm.h: Rename include guard.
 401         * arch/arm-linux.h: Rename include guard.
 402         * arch/arm-get-next-pcs.h: Rename include guard.
 403         * arch/amd64.h: Add include guard.
 404         * arch/aarch64-insn.h: Rename include guard.
 405         * arch-utils.h: Rename include guard.
 406         * annotate.h: Add include guard.
 407         * amd64-darwin-tdep.h: Rename include guard.
 408         * aarch64-linux-tdep.h: Add include guard.
 409         * aarch64-fbsd-tdep.h: Add include guard.
 410         * aarch32-linux-nat.h: Add include guard.
 411
 412 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 413
 414         * macrotab.c (macro_define_internal): New function that
 415         factorizes macro_define_object_internal and macro_define_function
 416         code.
 417         (macro_define_object_internal): Use macro_define_internal.
 418         (macro_define_function): Likewise.
 419
 420 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 421
 422         * macrocmd.c (extract_identifier): Return
 423         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
 424         callers.
 425
 426 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
 427
 428         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
 429
 430 2019-02-05  Tom Tromey  <tom@tromey.com>
 431
 432         * target.c (target_stack::unpush): Move assertion earlier.
 433
 434 2019-01-30  Tom Tromey  <tom@tromey.com>
 435
 436         PR python/23615:
 437         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
 438         (gdbpy_parse_and_eval): Likewise.
 439         * python/python-internal.h (gdbpy_allow_threads): New class.
 440
 441 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
 442
 443         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
 444         (aarch64_fbsd_fpregmap): Move earlier.
 445         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
 446         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 447         instead of individual calls to trad_frame_set_reg_addr.
 448         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
 449         earlier.
 450         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
 451         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 452         instead of individual calls to trad_frame_set_reg_addr.
 453
 454 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
 455
 456         * CONTRIBUTE: Replace contribution list with wiki link.
 457
 458 2019-01-25  Tom Tromey  <tom@tromey.com>
 459
 460         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
 461
 462 2019-01-25  Tom Tromey  <tom@tromey.com>
 463
 464         * xtensa-linux-nat.c: Fix common/ includes.
 465         * xml-support.h: Fix common/ includes.
 466         * xml-support.c: Fix common/ includes.
 467         * x86-linux-nat.c: Fix common/ includes.
 468         * windows-nat.c: Fix common/ includes.
 469         * varobj.h: Fix common/ includes.
 470         * varobj.c: Fix common/ includes.
 471         * value.c: Fix common/ includes.
 472         * valops.c: Fix common/ includes.
 473         * utils.c: Fix common/ includes.
 474         * unittests/xml-utils-selftests.c: Fix common/ includes.
 475         * unittests/utils-selftests.c: Fix common/ includes.
 476         * unittests/unpack-selftests.c: Fix common/ includes.
 477         * unittests/tracepoint-selftests.c: Fix common/ includes.
 478         * unittests/style-selftests.c: Fix common/ includes.
 479         * unittests/string_view-selftests.c: Fix common/ includes.
 480         * unittests/scoped_restore-selftests.c: Fix common/ includes.
 481         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
 482         * unittests/scoped_fd-selftests.c: Fix common/ includes.
 483         * unittests/rsp-low-selftests.c: Fix common/ includes.
 484         * unittests/parse-connection-spec-selftests.c: Fix common/
 485         includes.
 486         * unittests/optional-selftests.c: Fix common/ includes.
 487         * unittests/offset-type-selftests.c: Fix common/ includes.
 488         * unittests/observable-selftests.c: Fix common/ includes.
 489         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
 490         * unittests/memrange-selftests.c: Fix common/ includes.
 491         * unittests/memory-map-selftests.c: Fix common/ includes.
 492         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
 493         * unittests/function-view-selftests.c: Fix common/ includes.
 494         * unittests/environ-selftests.c: Fix common/ includes.
 495         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
 496         * unittests/common-utils-selftests.c: Fix common/ includes.
 497         * unittests/cli-utils-selftests.c: Fix common/ includes.
 498         * unittests/array-view-selftests.c: Fix common/ includes.
 499         * ui-file.c: Fix common/ includes.
 500         * tui/tui-io.c: Fix common/ includes.
 501         * tracepoint.h: Fix common/ includes.
 502         * tracepoint.c: Fix common/ includes.
 503         * tracefile-tfile.c: Fix common/ includes.
 504         * top.h: Fix common/ includes.
 505         * top.c: Fix common/ includes.
 506         * thread.c: Fix common/ includes.
 507         * target/waitstatus.h: Fix common/ includes.
 508         * target/waitstatus.c: Fix common/ includes.
 509         * target.h: Fix common/ includes.
 510         * target.c: Fix common/ includes.
 511         * target-memory.c: Fix common/ includes.
 512         * target-descriptions.c: Fix common/ includes.
 513         * symtab.h: Fix common/ includes.
 514         * symfile.c: Fix common/ includes.
 515         * stap-probe.c: Fix common/ includes.
 516         * spu-linux-nat.c: Fix common/ includes.
 517         * sparc-nat.c: Fix common/ includes.
 518         * source.c: Fix common/ includes.
 519         * solib.c: Fix common/ includes.
 520         * solib-target.c: Fix common/ includes.
 521         * ser-unix.c: Fix common/ includes.
 522         * ser-tcp.c: Fix common/ includes.
 523         * ser-pipe.c: Fix common/ includes.
 524         * ser-base.c: Fix common/ includes.
 525         * selftest-arch.c: Fix common/ includes.
 526         * s12z-tdep.c: Fix common/ includes.
 527         * rust-exp.y: Fix common/ includes.
 528         * rs6000-aix-tdep.c: Fix common/ includes.
 529         * riscv-tdep.c: Fix common/ includes.
 530         * remote.c: Fix common/ includes.
 531         * remote-notif.h: Fix common/ includes.
 532         * remote-fileio.h: Fix common/ includes.
 533         * remote-fileio.c: Fix common/ includes.
 534         * regcache.h: Fix common/ includes.
 535         * regcache.c: Fix common/ includes.
 536         * record-btrace.c: Fix common/ includes.
 537         * python/python.c: Fix common/ includes.
 538         * python/py-type.c: Fix common/ includes.
 539         * python/py-inferior.c: Fix common/ includes.
 540         * progspace.h: Fix common/ includes.
 541         * producer.c: Fix common/ includes.
 542         * procfs.c: Fix common/ includes.
 543         * proc-api.c: Fix common/ includes.
 544         * printcmd.c: Fix common/ includes.
 545         * ppc-linux-nat.c: Fix common/ includes.
 546         * parser-defs.h: Fix common/ includes.
 547         * osdata.c: Fix common/ includes.
 548         * obsd-nat.c: Fix common/ includes.
 549         * nat/x86-linux.c: Fix common/ includes.
 550         * nat/x86-linux-dregs.c: Fix common/ includes.
 551         * nat/x86-dregs.h: Fix common/ includes.
 552         * nat/x86-dregs.c: Fix common/ includes.
 553         * nat/ppc-linux.c: Fix common/ includes.
 554         * nat/mips-linux-watch.h: Fix common/ includes.
 555         * nat/mips-linux-watch.c: Fix common/ includes.
 556         * nat/linux-waitpid.c: Fix common/ includes.
 557         * nat/linux-ptrace.h: Fix common/ includes.
 558         * nat/linux-ptrace.c: Fix common/ includes.
 559         * nat/linux-procfs.c: Fix common/ includes.
 560         * nat/linux-personality.c: Fix common/ includes.
 561         * nat/linux-osdata.c: Fix common/ includes.
 562         * nat/linux-namespaces.c: Fix common/ includes.
 563         * nat/linux-btrace.h: Fix common/ includes.
 564         * nat/linux-btrace.c: Fix common/ includes.
 565         * nat/fork-inferior.c: Fix common/ includes.
 566         * nat/amd64-linux-siginfo.c: Fix common/ includes.
 567         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
 568         * nat/aarch64-linux.c: Fix common/ includes.
 569         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
 570         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
 571         * namespace.h: Fix common/ includes.
 572         * mips-linux-tdep.c: Fix common/ includes.
 573         * minsyms.c: Fix common/ includes.
 574         * mi/mi-parse.h: Fix common/ includes.
 575         * mi/mi-main.c: Fix common/ includes.
 576         * mi/mi-cmd-env.c: Fix common/ includes.
 577         * memrange.h: Fix common/ includes.
 578         * memattr.c: Fix common/ includes.
 579         * maint.h: Fix common/ includes.
 580         * maint.c: Fix common/ includes.
 581         * main.c: Fix common/ includes.
 582         * machoread.c: Fix common/ includes.
 583         * location.c: Fix common/ includes.
 584         * linux-thread-db.c: Fix common/ includes.
 585         * linux-nat.c: Fix common/ includes.
 586         * linux-fork.c: Fix common/ includes.
 587         * inline-frame.c: Fix common/ includes.
 588         * infrun.c: Fix common/ includes.
 589         * inflow.c: Fix common/ includes.
 590         * inferior.h: Fix common/ includes.
 591         * inferior.c: Fix common/ includes.
 592         * infcmd.c: Fix common/ includes.
 593         * inf-ptrace.c: Fix common/ includes.
 594         * inf-child.c: Fix common/ includes.
 595         * ia64-linux-nat.c: Fix common/ includes.
 596         * i387-tdep.c: Fix common/ includes.
 597         * i386-tdep.c: Fix common/ includes.
 598         * i386-linux-tdep.c: Fix common/ includes.
 599         * i386-linux-nat.c: Fix common/ includes.
 600         * i386-go32-tdep.c: Fix common/ includes.
 601         * i386-fbsd-tdep.c: Fix common/ includes.
 602         * i386-fbsd-nat.c: Fix common/ includes.
 603         * guile/scm-type.c: Fix common/ includes.
 604         * guile/guile.c: Fix common/ includes.
 605         * go32-nat.c: Fix common/ includes.
 606         * gnu-nat.c: Fix common/ includes.
 607         * gdbthread.h: Fix common/ includes.
 608         * gdbarch-selftests.c: Fix common/ includes.
 609         * gdb_usleep.c: Fix common/ includes.
 610         * gdb_select.h: Fix common/ includes.
 611         * gdb_bfd.c: Fix common/ includes.
 612         * gcore.c: Fix common/ includes.
 613         * fork-child.c: Fix common/ includes.
 614         * findvar.c: Fix common/ includes.
 615         * fbsd-nat.c: Fix common/ includes.
 616         * event-top.c: Fix common/ includes.
 617         * event-loop.c: Fix common/ includes.
 618         * dwarf2read.c: Fix common/ includes.
 619         * dwarf2loc.c: Fix common/ includes.
 620         * dwarf2-frame.c: Fix common/ includes.
 621         * dwarf-index-cache.c: Fix common/ includes.
 622         * dtrace-probe.c: Fix common/ includes.
 623         * disasm-selftests.c: Fix common/ includes.
 624         * defs.h: Fix common/ includes.
 625         * csky-tdep.c: Fix common/ includes.
 626         * cp-valprint.c: Fix common/ includes.
 627         * cp-support.h: Fix common/ includes.
 628         * cp-support.c: Fix common/ includes.
 629         * corelow.c: Fix common/ includes.
 630         * completer.h: Fix common/ includes.
 631         * completer.c: Fix common/ includes.
 632         * compile/compile.c: Fix common/ includes.
 633         * compile/compile-loc2c.c: Fix common/ includes.
 634         * compile/compile-cplus-types.c: Fix common/ includes.
 635         * compile/compile-cplus-symbols.c: Fix common/ includes.
 636         * command.h: Fix common/ includes.
 637         * cli/cli-dump.c: Fix common/ includes.
 638         * cli/cli-cmds.c: Fix common/ includes.
 639         * charset.c: Fix common/ includes.
 640         * build-id.c: Fix common/ includes.
 641         * btrace.h: Fix common/ includes.
 642         * btrace.c: Fix common/ includes.
 643         * breakpoint.h: Fix common/ includes.
 644         * breakpoint.c: Fix common/ includes.
 645         * ax.h:
 646         (enum agent_op): Fix common/ includes.
 647         * ax-general.c (struct aop_map): Fix common/ includes.
 648         * ax-gdb.c: Fix common/ includes.
 649         * auxv.c: Fix common/ includes.
 650         * auto-load.c: Fix common/ includes.
 651         * arm-tdep.c: Fix common/ includes.
 652         * arch/riscv.c: Fix common/ includes.
 653         * arch/ppc-linux-common.c: Fix common/ includes.
 654         * arch/i386.c: Fix common/ includes.
 655         * arch/arm.c: Fix common/ includes.
 656         * arch/arm-linux.c: Fix common/ includes.
 657         * arch/arm-get-next-pcs.c: Fix common/ includes.
 658         * arch/amd64.c: Fix common/ includes.
 659         * arch/aarch64.c: Fix common/ includes.
 660         * arch/aarch64-insn.c: Fix common/ includes.
 661         * arch-utils.c: Fix common/ includes.
 662         * amd64-windows-tdep.c: Fix common/ includes.
 663         * amd64-tdep.c: Fix common/ includes.
 664         * amd64-sol2-tdep.c: Fix common/ includes.
 665         * amd64-obsd-tdep.c: Fix common/ includes.
 666         * amd64-nbsd-tdep.c: Fix common/ includes.
 667         * amd64-linux-tdep.c: Fix common/ includes.
 668         * amd64-linux-nat.c: Fix common/ includes.
 669         * amd64-fbsd-tdep.c: Fix common/ includes.
 670         * amd64-fbsd-nat.c: Fix common/ includes.
 671         * amd64-dicos-tdep.c: Fix common/ includes.
 672         * amd64-darwin-tdep.c: Fix common/ includes.
 673         * agent.c: Fix common/ includes.
 674         * ada-lang.h: Fix common/ includes.
 675         * ada-lang.c: Fix common/ includes.
 676         * aarch64-tdep.c: Fix common/ includes.
 677
 678 2019-01-25  Tom Tromey  <tom@tromey.com>
 679
 680         * common/create-version.sh: Use common/version.h.
 681
 682 2019-01-24  Pedro Alves  <palves@redhat.com>
 683
 684         * infrun.c (signal_stop, signal_print, signal_program)
 685         (signal_catch, signal_pass): Now arrays instead of pointers.
 686         (update_signals_program_target, do_target_resume)
 687         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
 688         * linux-nat.c (linux_nat_target::pass_signals)
 689         (linux_nat_target::create_inferior, linux_nat_target::attach):
 690         Adjust.
 691         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
 692         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
 693         * procfs.c (procfs_target::pass_signals): Adjust.
 694         * record-full.c (record_full_target::resume): Adjust.
 695         * remote.c (remote_target::pass_signals)
 696         (remote_target::program_signals): Adjust.
 697         * target-debug.h (target_debug_print_signals): Now takes a
 698         gdb::array_view as parameter.  Adjust.
 699         * target.h (target_ops) <pass_signals, program_signals>: Replace
 700         pointer and length parameters with gdb::array_view.
 701         (target_pass_signals, target_program_signals): Likewise.
 702         * target-delegates.c: Regenerate.
 703
 704 2019-01-24  Pedro Alves  <palves@redhat.com>
 705
 706         * common/forward-scope-exit.h
 707         (forward_scope_exit::forward_scope_exit): Pass arguments to
 708         m_bind_function directly, instead of creating a std::bind and
 709         copying that.
 710
 711 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
 712
 713         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 714         for static members.
 715         (pass_in_v_vfp_candidate): Likewise.
 716
 717 2019-01-23  Tom Tromey  <tom@tromey.com>
 718             Pedro Alves  <palves@redhat.com>
 719
 720         * regcache.c (class regcache_invalidator): Remove.
 721         (regcache::raw_write): Use make_scope_exit.
 722
 723 2019-01-23  Tom Tromey  <tom@tromey.com>
 724
 725         * ui-out.h (class ui_out_emit_type): Update comment.
 726
 727 2019-01-23  Tom Tromey  <tom@tromey.com>
 728
 729         * infrun.c (fetch_inferior_event): Update comment.
 730
 731 2019-01-23  Tom Tromey  <tom@tromey.com>
 732             Pedro Alves  <palves@redhat.com>
 733
 734         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
 735         parameter.
 736         (fetch_inferior_event): Use SCOPE_EXIT.
 737
 738
 739 2019-01-23  Tom Tromey  <tom@tromey.com>
 740             Pedro Alves  <palves@redhat.com>
 741
 742         * infrun.c (disable_thread_events): Delete.
 743         (stop_all_threads): Use SCOPE_EXIT.
 744
 745 2019-01-23  Tom Tromey  <tom@tromey.com>
 746             Pedro Alves  <palves@redhat.com>
 747
 748         * symfile.c: Include forward-scope-exit.h.
 749         (clear_symtab_users_cleanup): Replace forward declaration with
 750         a FORWARD_SCOPE_EXIT.
 751         (syms_from_objfile_1): Use the forward_scope_exit and
 752         gdb::optional instead of cleanup_function.
 753         (reread_symbols): Use the forward_scope_exit instead of
 754         cleanup_function.
 755         (clear_symtab_users_cleanup): Remove function.
 756
 757 2019-01-23  Tom Tromey  <tom@tromey.com>
 758             Pedro Alves  <palves@redhat.com>
 759
 760         * linux-nat.c: Include scope-exit.h.
 761         (cleanup_target_stop): Remove.
 762         (linux_nat_target::static_tracepoint_markers_by_strid): Use
 763         SCOPE_EXIT.
 764
 765 2019-01-23  Tom Tromey  <tom@tromey.com>
 766             Pedro Alves  <palves@redhat.com>
 767
 768         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
 769         (call_function_by_hand_dummy): Use SCOPE_EXIT.
 770
 771 2019-01-23  Tom Tromey  <tom@tromey.com>
 772             Andrew Burgess  <andrew.burgess@embecosm.com>
 773             Pedro Alves  <palves@redhat.com>
 774
 775         * infrun.c (fetch_inferior_event): Use scope_exit.
 776         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
 777         * top.c (execute_command): Use scope_exit.
 778         * breakpoint.c (bpstat_do_actions): Use scope_exit.
 779         * utils.c (do_bpstat_clear_actions_cleanup)
 780         (make_bpstat_clear_actions_cleanup): Remove.
 781
 782 2019-01-23  Tom Tromey  <tom@tromey.com>
 783             Pedro Alves  <palves@redhat.com>
 784
 785         * infrun.c: Include "common/scope-exit.h"
 786         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
 787         (wait_for_inferior): Use SCOPE_EXIT.
 788         (fetch_inferior_event): Use scope_exit.
 789
 790 2019-01-23  Tom Tromey  <tom@tromey.com>
 791             Pedro Alves  <palves@redhat.com>
 792
 793         * breakpoint.c (create_breakpoint): Remove cleanup.
 794
 795 2019-01-23  Tom Tromey  <tom@tromey.com>
 796             Andrew Burgess  <andrew.burgess@embecosm.com>
 797             Pedro Alves  <palves@redhat.com>
 798
 799 2019-01-23  Pedro Alves  <palves@redhat.com>
 800
 801         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
 802
 803 2019-01-23  Pedro Alves  <palves@redhat.com>
 804             Andrew Burgess  <andrew.burgess@embecosm.com>
 805
 806         * gdbthread.h: Include "common/forward-scope-exit.h".
 807         (scoped_finish_thread_state): Redefine custom class in terms of
 808         forward_scope_exit.
 809
 810 2019-01-23  Pedro Alves  <palves@redhat.com>
 811             Andrew Burgess  <andrew.burgess@embecosm.com>
 812
 813         * common/forward-scope-exit.h: New file.
 814
 815 2019-01-23  Pedro Alves  <palves@redhat.com>
 816             Andrew Burgess  <andrew.burgess@embecosm.com>
 817             Tom Tromey  <tom@tromey.com>
 818
 819         * common/scope-exit.h: New file.
 820
 821 2019-01-23  Pedro Alves  <palves@redhat.com>
 822
 823         * common/preprocessor.h (ESC): Rename to ...
 824         (ESC_PARENS): ... this.
 825         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
 826         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
 827
 828 2019-01-23  Tom Tromey  <tom@tromey.com>
 829
 830         * language.h (class scoped_switch_to_sym_language_if_auto):
 831         Initialize m_lang in both cases.
 832
 833 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
 834
 835         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
 836         with XCNEW.
 837
 838 2019-01-22  Tom Tromey  <tom@tromey.com>
 839
 840         * corelow.c: Do not include sys/file.h.
 841
 842 2019-01-22  Tom Tromey  <tom@tromey.com>
 843
 844         * tui/tui-wingeneral.h: Include gdb_curses.h.
 845
 846 2019-01-22  Tom Tromey  <tom@tromey.com>
 847
 848         * source-cache.h (class source_cache) <get_source_lines,
 849         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
 850
 851 2019-01-22  Tom Tromey  <tom@tromey.com>
 852
 853         * remote-fileio.h (struct remote_target): Declare.
 854
 855 2019-01-22  Tom Tromey  <tom@tromey.com>
 856
 857         * python/py-arch.c: Do not include py-ref.h.
 858         * python/py-bpevent.c: Do not include py-ref.h.
 859         * python/py-cmd.c: Do not include py-ref.h.
 860         * python/py-continueevent.c: Do not include py-ref.h.
 861         * python/py-event.h: Do not include py-ref.h.
 862         * python/py-evtregistry.c: Do not include py-ref.h.
 863         * python/py-finishbreakpoint.c: Do not include py-ref.h.
 864         * python/py-frame.c: Do not include py-ref.h.
 865         * python/py-framefilter.c: Do not include py-ref.h.
 866         * python/py-function.c: Do not include py-ref.h.
 867         * python/py-infevents.c: Do not include py-ref.h.
 868         * python/py-linetable.c: Do not include py-ref.h.
 869         * python/py-objfile.c: Do not include py-ref.h.
 870         * python/py-param.c: Do not include py-ref.h.
 871         * python/py-prettyprint.c: Do not include py-ref.h.
 872         * python/py-progspace.c: Do not include py-ref.h.
 873         * python/py-symbol.c: Do not include py-ref.h.
 874         * python/py-symtab.c: Do not include py-ref.h.
 875         * python/py-type.c: Do not include py-ref.h.
 876         * python/py-unwind.c: Do not include py-ref.h.
 877         * python/py-utils.c: Do not include py-ref.h.
 878         * python/py-value.c: Do not include py-ref.h.
 879         * python/py-varobj.c: Do not include py-ref.h.
 880         * python/py-xmethods.c: Do not include py-ref.h.
 881         * python/python.c: Do not include py-ref.h.
 882         * varobj.c: Do not include py-ref.h.
 883
 884 2019-01-22  Tom Tromey  <tom@tromey.com>
 885
 886         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
 887         keyword for bcache.
 888
 889 2019-01-22  Tom Tromey  <tom@tromey.com>
 890
 891         * compile/compile-cplus-types.c: Remove a comment by #include.
 892
 893 2019-01-22  Tom Tromey  <tom@tromey.com>
 894
 895         * compile/gcc-c-plugin.h: Include compile-internal.h.
 896
 897 2019-01-22  Tom Tromey  <tom@tromey.com>
 898
 899         * stabsread.c (EXTERN): Do not define.
 900         (symnum, next_symbol_text_func, processing_gcc_compilation)
 901         (within_function, global_sym_chain, global_stabs)
 902         (previous_stab_code, this_object_header_files)
 903         (n_this_object_header_files)
 904         (n_allocated_this_object_header_files): Define.
 905         * stabsread.h (EXTERN): Never define.  Use "extern".
 906
 907 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 908
 909         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
 910         history_value.
 911
 912 2019-01-21  Tom Tromey  <tom@tromey.com>
 913
 914         * ui-out.c: Fix includes.
 915         * tui/tui-source.c: Fix includes.
 916         * target.c: Fix includes.
 917         * remote.c: Fix includes.
 918         * regcache.c: Fix includes.
 919         * python/py-block.c: Fix includes.
 920         * printcmd.c: Fix includes.
 921         * or1k-tdep.c: Fix includes.
 922         * mi/mi-main.c: Fix includes.
 923         * m32r-tdep.c: Fix includes.
 924         * csky-tdep.c: Fix includes.
 925         * compile/compile-cplus-types.c: Fix includes.
 926         * cli/cli-interp.c: Fix includes.
 927
 928 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
 929
 930         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 931         for padding.
 932
 933 2019-01-16  Tom Tromey  <tom@tromey.com>
 934
 935         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
 936         earlier.
 937         (struct objfile) <msymbols_range>: Move from top level.
 938         <msymbols>: New method.
 939         (class objfile_msymbols): Remove.
 940         * symtab.c (default_collect_symbol_completion_matches_break_on):
 941         Update.
 942         * symmisc.c (dump_msymbols): Update.
 943         * stabsread.c (scan_file_globals): Update.
 944         * objc-lang.c (info_selectors_command, info_classes_command)
 945         (find_methods): Update.
 946         * minsyms.c (find_solib_trampoline_target): Update.
 947         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
 948         * coffread.c (coff_symfile_read): Update.
 949         * ada-lang.c (ada_lookup_simple_minsym)
 950         (ada_collect_symbol_completion_matches): Update.
 951
 952 2019-01-16  Tom Tromey  <tom@tromey.com>
 953
 954         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
 955         type.  Remove no-argument constructor.
 956         <iterator::operator++>: Simplify.
 957         <begin>: Update.
 958         <end>: Use minimal_symbol_count.
 959
 960 2019-01-16  Tom Tromey  <tom@tromey.com>
 961
 962         * objfiles.h (struct objfile) <psymtabs>: New method.
 963         (class objfile_psymtabs): Remove.
 964         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
 965         typedef.
 966         <range>: New method.
 967         (require_partial_symbols): Change return type.
 968         * psymtab.c (require_partial_symbols)
 969         (psym_expand_symtabs_matching): Update.
 970         * mdebugread.c (parse_partial_symbols): Update.
 971         * dbxread.c (dbx_end_psymtab): Update.
 972
 973 2019-01-15  Tom Tromey  <tom@tromey.com>
 974
 975         * symtab.c (lookup_objfile_from_block)
 976         (lookup_symbol_in_objfile_symtabs)
 977         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
 978         (find_line_symtab, info_sources_command)
 979         (default_collect_symbol_completion_matches_break_on)
 980         (make_source_files_completion_list): Update.
 981         * symmisc.c (print_objfile_statistics, dump_objfile)
 982         (maintenance_print_symbols, maintenance_info_symtabs)
 983         (maintenance_check_symtabs, maintenance_info_line_tables):
 984         Update.
 985         * source.c (select_source_symtab)
 986         (forget_cached_source_info_for_objfile): Update.
 987         * objfiles.h (class objfile_compunits): Remove.
 988         (struct objfile) <compunits_range>: New typedef.
 989         (compunits): New method.
 990         * objfiles.c (objfile_relocate1): Update.
 991         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 992         * maint.c (count_symtabs_and_blocks): Update.
 993         * linespec.c (iterate_over_all_matching_symtabs): Update.
 994         * cp-support.c (add_symbol_overload_list_qualified): Update.
 995         * coffread.c (coff_symtab_read): Update.
 996         * ada-lang.c (add_nonlocal_symbols)
 997         (ada_collect_symbol_completion_matches)
 998         (ada_add_global_exceptions): Update.
 999
1000 2019-01-15  Tom Tromey  <tom@tromey.com>
1001
1002         * progspace.h (program_space) <objfiles_safe_range>: New
1003         typedef.
1004         <objfiles_safe>: New method.
1005         * objfiles.h (class all_objfiles_safe): Remove.
1006         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1007         * jit.c (jit_inferior_exit_hook): Update.
1008
1009 2019-01-17  Tom Tromey  <tom@tromey.com>
1010
1011         * progspace.h (program_space) <objfiles_range>: New typedef.
1012         <objfiles>: New method.
1013         <objfiles_head>: Rename from objfiles.
1014         (object_files): Update.
1015         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1016         * guile/scm-pretty-print.c
1017         (ppscm_find_pretty_printer_from_objfiles): Update.
1018         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1019         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1020         Update.
1021         * python/py-progspace.c (pspy_get_objfiles): Update.
1022         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1023         Update.
1024         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1025         (objfpy_lookup_objfile_by_build_id): Update.
1026         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1027         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1028         Update.
1029         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1030         (expand_symtab_containing_pc, lookup_objfile_from_block)
1031         (lookup_static_symbol, basic_lookup_transparent_type)
1032         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1033         (find_line_symtab, info_sources_command)
1034         (default_collect_symbol_completion_matches_break_on)
1035         (make_source_files_completion_list, find_main_name): Update.
1036         * symmisc.c (print_symbol_bcache_statistics)
1037         (print_objfile_statistics, maintenance_print_symbols)
1038         (maintenance_print_msymbols, maintenance_print_objfiles)
1039         (maintenance_info_symtabs, maintenance_check_symtabs)
1040         (maintenance_expand_symtabs, maintenance_info_line_tables):
1041         Update.
1042         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1043         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1044         (map_overlay_command, unmap_overlay_command)
1045         (simple_overlay_update, expand_symtabs_matching)
1046         (map_symbol_filenames): Update.
1047         * symfile-debug.c (set_debug_symfile): Update.
1048         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1049         Update.
1050         * source.c (select_source_symtab, forget_cached_source_info):
1051         Update.
1052         * solib.c (solib_read_symbols): Update.
1053         * solib-spu.c (append_ocl_sos): Update.
1054         * psymtab.c (maintenance_print_psymbols)
1055         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1056         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1057         * printcmd.c (info_symbol_command): Update.
1058         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1059         Update.
1060         * objfiles.h (class all_objfiles): Remove.
1061         * objfiles.c (have_partial_symbols, have_full_symbols)
1062         (have_minimal_symbols, qsort_cmp, update_section_map)
1063         (shared_objfile_contains_address_p)
1064         (default_iterate_over_objfiles_in_search_order): Update.
1065         * objc-lang.c (info_selectors_command, info_classes_command)
1066         (find_methods): Update.
1067         * minsyms.c (find_solib_trampoline_target): Update.
1068         * maint.c (maintenance_info_sections)
1069         (maintenance_translate_address, count_symtabs_and_blocks):
1070         Update.
1071         * main.c (captured_main_1): Update.
1072         * linux-thread-db.c (try_thread_db_load_from_pdir)
1073         (has_libpthread): Update.
1074         * linespec.c (iterate_over_all_matching_symtabs)
1075         (search_minsyms_for_name): Update.
1076         * jit.c (jit_find_objf_with_entry_addr): Update.
1077         * hppa-tdep.c (find_unwind_entry)
1078         (hppa_lookup_stub_minimal_symbol): Update.
1079         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1080         Update.
1081         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1082         (elf_gnu_ifunc_resolve_by_got): Update.
1083         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1084         * dwarf-index-write.c (save_gdb_index_command): Update.
1085         * cp-support.c (add_symbol_overload_list_qualified): Update.
1086         * breakpoint.c (create_overlay_event_breakpoint)
1087         (create_longjmp_master_breakpoint)
1088         (create_std_terminate_master_breakpoint)
1089         (create_exception_master_breakpoint): Update.
1090         * blockframe.c (find_pc_partial_function): Update.
1091         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1092         (ada_collect_symbol_completion_matches)
1093         (ada_add_global_exceptions): Update.
1094
1095 2019-01-17  Tom Tromey  <tom@tromey.com>
1096
1097         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1098         declare VEC.
1099         (solib_target_parse_libraries): Change return type.
1100         (library_list_start_segment, library_list_start_section)
1101         (library_list_end_library, library_list_start_library); Update.
1102         (solib_target_free_library_list): Remove.
1103         (solib_target_parse_libraries): Remove cleanup.  Change return
1104         type.
1105         (solib_target_current_sos): Update.
1106
1107 2019-01-17  Tom Tromey  <tromey@bapiya>
1108
1109         * valprint.c: Replace "the the" with "the".
1110         * symtab.c: Replace "the the" with "the".
1111         * solib.c: Replace "the the" with "the".
1112         * solib-dsbt.c: Replace "the the" with "the".
1113         * linespec.c: Replace "the the" with "the".
1114         * dwarf2loc.h: Replace "the the" with "the".
1115         * amd64-windows-tdep.c: Replace "the the" with "the".
1116         * aarch64-tdep.c: Replace "the the" with "the".
1117
1118 2019-01-16  Keith Seitz  <keiths@redhat.com>
1119
1120         PR gdb/23773
1121         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1122         <builder>: Rename to ..
1123         <m_builder>: ... this and make private.
1124         (dwarf2_cu::get_builder): New method.  Change all users of
1125         `builder' to use this method.
1126         (dwarf2_start_symtab): Move to ...
1127         (dwarf2_cu::start_symtab): ... here.  Update all callers
1128         (setup_type_unit_groups): Move to ...
1129         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1130         callers.
1131         (dwarf2_cu::reset_builder): New method.
1132         (process_full_compunit, process_full_type_unit): Use
1133         dwarf2_cu::reset_builder.
1134         (follow_die_offset): Record the ancestor CU if it is different
1135         from the followed DIE's CU.
1136         (follow_die_sig_1): Likewise.
1137
1138 2019-01-15  Tom Tromey  <tom@tromey.com>
1139
1140         * remote.c (class remote_state) <buf>: Now a char_vector.
1141         <buf_size>: Remove.
1142         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1143         parameter.
1144         (remote_target::getpkt_or_notif_sane_1)
1145         (remote_target::getpkt_sane)
1146         (remote_target::getpkt_or_notif_sane): Likewise.
1147         (class remote_target) <putpkt>: New overload.
1148         (remote_target::read_frame): Change type of "buf_p".  Remove
1149         sizeof_p parameter.
1150         (packet_ok): New overload.
1151         (packet_check_result): New overload.
1152         Update all uses.
1153
1154 2019-01-14  Tom Tromey  <tom@tromey.com>
1155
1156         * remote-notif.c (handle_notification, remote_notif_ack)
1157         (remote_notif_parse): Make "buf" const.
1158         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1159         const.
1160         (remote_notif_parse, remote_notif_ack, handle_notification):
1161         Likewise.
1162         * remote.c (remote_notif_stop_parse): Make "buf" const.
1163         (remote_target::remote_parse_stop_reply): Make "buf" const.
1164         (remote_notif_stop_ack): Make "buf" const.
1165
1166 2019-01-14  Tom Tromey  <tom@tromey.com>
1167
1168         * remote.c (remote_console_output): Make parameter const.
1169
1170 2019-01-14  Tom Tromey  <tom@tromey.com>
1171
1172         * target-debug.h (target_debug_print_signals): Constify.
1173         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1174         * procfs.c (procfs_target::pass_signals): Update.
1175         * linux-nat.c (linux_nat_target::pass_signals): Update.
1176         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1177         * target-delegates.c: Rebuild.
1178         * remote.c (remote_target::program_signals): Update.
1179         (remote_target::pass_signals): Update.
1180         * target.c (target_pass_signals): Constify argument.
1181         (target_program_signals): Likewise.
1182         * target.h (struct target_ops) <pass_signals, program_signals>:
1183         Constify argument.
1184         (target_pass_signals, target_program_signals): Constify argument.
1185
1186 2019-01-14  Tom Tromey  <tom@tromey.com>
1187
1188         PR tui/28819:
1189         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1190
1191 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1192
1193         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1194         field.
1195         * rs6000-tdep.c: Include reggroups.h.
1196         (IS_V_ALIAS_PSEUDOREG): Define.
1197         (rs6000_register_name): Return names for the "vX" aliases.
1198         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1199         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1200         aliases.  Call default_register_reggroup_p for all other
1201         pseudo-registers.
1202         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1203         New functions.
1204         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1205         Handle "vX" aliases.
1206         (v_alias_pseudo_register_collect): New function.
1207         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1208         (rs6000_gdbarch_init): Initialize "vX" aliases as
1209         pseudo-registers.  Restore registration of
1210         rs6000_pseudo_register_reggroup_p with
1211         set_tdesc_pseudo_register_reggroup_p.
1212
1213 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1214
1215         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1216         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1217         set_gdbarch_num_pseudo_regs.
1218
1219 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1220
1221         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1222         Remove arg prefixname, add do_set and do_show.
1223         Add member functions set_list and show_list.
1224         * cli/cli-style.c (class cli_style_option): Update accordingly.
1225         (style_set_list): Move to file scope.
1226         (style_show_list): Likewise.
1227         (set_style): Call help_list.
1228         (show_style): Call cmd_show_list.
1229         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1230         Update to use the new macro.
1231
1232 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1233
1234         * ada-lang.c (_initialize_ada_language): Expand the help text
1235         for the "catch exception" command.
1236
1237 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1238
1239         * symtab.c (matching_obj_sections): Initialize obj,
1240         declare it closer to its usage.
1241
1242 2019-01-10  Tom Tromey  <tom@tromey.com>
1243
1244         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1245         (basic_inf_threads_range): Remove.
1246         (inf_threads_range, inf_non_exited_threads_range)
1247         (safe_inf_threads_range): Use next_adapter.
1248
1249 2019-01-10  Keith Seitz  <keiths@redhat.com>
1250
1251         PR gdb/23712
1252         PR symtab/23010
1253         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1254         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1255
1256 2019-01-10  Keith Seitz  <keiths@redhat.com>
1257
1258         PR gdb/23712
1259         PR symtab/23010
1260         * dictionary.c (pending_to_vector): Remove.
1261         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1262         Remove _1 suffix, replacing functions of the same name.  Update
1263         all callers.
1264         (dict_create_hashed, dict_create_hashed_expandable)
1265         (dict_create_linear, dict_create_linear_expandable, dict_free)
1266         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1267         Make functions static.
1268
1269 2019-01-10  Keith Seitz  <keiths@redhat.com>
1270
1271         PR gdb/23712
1272         PR symtab/23010
1273         * dictionary.h (struct dictionary): Replace declaration with
1274         multidictionary.
1275         (dict_create_hashed, dict_create_hashed_expandable)
1276         (dict_create_linear, dict_create_linear_expandable)
1277         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1278         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1279         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1280         taking multidictionary argument.
1281         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1282         * block.h (struct block) <dict>: Change to multidictionary
1283         and rename `multidict'.
1284         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1285         symmisc.c: Update all dictionary references to multidictionary.
1286
1287 2019-01-10  Keith Seitz  <keiths@redhat.com>
1288
1289         PR gdb/23712
1290         PR symtab/23010
1291         * dictionary.c: Include unordered_map.
1292         (pending_to_vector): New function.
1293         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1294         Rewrite the non-"_1" functions to take vector instead
1295         of linked list.
1296         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1297         "new" _1 versions of the same name.
1298         (multidictionary): Define.
1299         (std::hash<enum language): New definition.
1300         (collate_pending_symbols_by_language, mdict_create_hashed)
1301         (mdict_create_hashed_expandable, mdict_create_linear)
1302         (mdict_create_linear_expandable, mdict_free)
1303         (find_language_dictionary, create_new_language_dictionary)
1304         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1305         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1306         (mdict_size, mdict_empty): New functions.
1307         * dictionary.h (mdict_iterator): Define.
1308
1309 2019-01-10  Pedro Alves  <palves@redhat.com>
1310
1311         * breakpoint.c (read_uploaded_action)
1312         (create_tracepoint_from_upload): Adjust to use
1313         gdb::unique_xmalloc_ptr.
1314         * ctf.c (ctf_write_uploaded_tp):
1315         (SET_ARRAY_FIELD): Use emplace_back.
1316         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1317         * tracefile-tfile.c (tfile_write_uploaded_tp):
1318         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1319         gdb::unique_xmalloc_ptr.
1320         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1321         at_string, cond_string, cmd_strings>: Replace char pointers
1322         with gdb::unique_xmalloc_ptr.
1323
1324 2019-01-10  Pedro Alves  <palves@redhat.com>
1325
1326         * solib-target.c (library_list_start_library): Don't xstrdup name.
1327
1328 2019-01-10  Pedro Alves  <palves@redhat.com>
1329
1330         * mdebugread.c (parse_partial_symbols): Use
1331         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1332
1333 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1334
1335         * linux-fork.c (scoped_switch_fork_info)
1336         <~scoped_switch_fork_info>: Fix incorrect variable name.
1337
1338 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1339
1340         * linux-fork.c (scoped_switch_fork_info)
1341         <scoped_switch_fork_info>: Make explicit.
1342         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1343
1344 2019-01-10  Tom Tromey  <tom@tromey.com>
1345
1346         * objfiles.h (objfile::reset_psymtabs): Update.
1347         * objfiles.c (objfile::objfile): Update.
1348         * psymtab.h (psymtab_storage::obstack): Update.
1349         (psymtab_storage::m_obstack): Use gdb::optional.
1350         (class psymtab_storage): Update comment.  Remove objfile
1351         parameter.
1352         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1353
1354 2019-01-10  Tom Tromey  <tom@tromey.com>
1355
1356         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1357         <free_psymtabs>: Now private.
1358         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1359         (allocate_psymtab): Use new method.
1360
1361 2019-01-10  Tom Tromey  <tom@tromey.com>
1362
1363         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1364         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1365         * mdebugread.c (parse_partial_symbols): Use
1366         allocate_dependencies.
1367         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1368         allocate_dependencies.
1369         (process_psymtab_comp_unit_reader)
1370         (build_type_psymtab_dependencies): Likewise.
1371         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1372
1373 2019-01-10  Tom Tromey  <tom@tromey.com>
1374
1375         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1376         PSYMBOL_SET_LANGUAGE.
1377         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1378
1379 2019-01-10  Tom Tromey  <tom@tromey.com>
1380
1381         * psymtab.h (psymtab_storage::obstack): New method.
1382         <m_obstack>: Rename from obstack; now private.
1383         * psymtab.c (psymtab_storage): Update.
1384         * dwarf2read.c (create_addrmap_from_index)
1385         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1386         Update.
1387
1388 2019-01-10  Tom Tromey  <tom@tromey.com>
1389
1390         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1391         * objfiles.h (objfile::reset_psymtabs): New method.
1392
1393 2019-01-10  Tom Tromey  <tom@tromey.com>
1394
1395         * symmisc.c (print_symbol_bcache_statistics): Update.
1396         (print_objfile_statistics): Update.
1397         * symfile.c (reread_symbols): Update.
1398         * psymtab.h (class psymtab_storage): New.
1399         * psymtab.c (psymtab_storage): New constructor.
1400         (~psymtab_storage): New destructor.
1401         (require_partial_symbols): Update.
1402         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1403         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1404         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1405         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1406         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1407         (start_psymtab_common, end_psymtab_common)
1408         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1409         (allocate_psymtab): Update.
1410         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1411         Update.
1412         (dump_psymtab_addrmap, maintenance_print_psymbols)
1413         (maintenance_check_psymtabs): Update.
1414         (class objfile_psymtabs): Move to objfiles.h.
1415         * psympriv.h (discard_psymtab): Now inline.
1416         (psymtab_discarder::psymtab_discarder): Update.
1417         (psymtab_discarder::~psymtab_discarder): Update.
1418         (ALL_OBJFILE_PSYMTABS): Rewrite.
1419         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1420         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1421         Remove fields.
1422         <partial_symtabs>: New field.
1423         (class objfile_psymtabs): Move from psymtab.h.  Update.
1424         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1425         psymbol_cache.
1426         (objfile::~objfile): Don't destroy psymbol_cache.
1427         * mdebugread.c (parse_partial_symbols): Update.
1428         * dwarf2read.c (create_addrmap_from_index)
1429         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1430         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1431         (add_partial_subprogram, dwarf2_ranges_read): Update.
1432         * dwarf-index-write.c (write_address_map)
1433         (write_one_signatured_type, recursively_write_psymbols)
1434         (class debug_names, class debug_names, write_psymtabs_to_index):
1435         Update.
1436
1437 2019-01-10  Tom Tromey  <tom@tromey.com>
1438
1439         * symtab.h (SYMBOL_SET_NAMES): Update.
1440         (symbol_set_names): Update.
1441         (MSYMBOL_SET_NAMES): Update.
1442         * symtab.c (symbol_set_names): Change argument to be an
1443         objfile_per_bfd_storage.
1444         * psymtab.c (add_psymbol_to_bcache): Update.
1445         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1446
1447 2019-01-10  Tom Tromey  <tom@tromey.com>
1448
1449         * symtab.c (create_demangled_names_hash): Change argument to be an
1450         objfile_per_bfd_storage.
1451         (symbol_set_names): Update.
1452
1453 2019-01-10  Tom Tromey  <tom@tromey.com>
1454
1455         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1456         init_psymbol_list.
1457         * psymtab.c (init_psymbol_list): Do nothing if already called.
1458         * psympriv.h (init_psymbol_list): Add comment.
1459         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1460         init_psymbol_list.
1461         * dbxread.c (dbx_symfile_read): Unconditionally call
1462         init_psymbol_list.
1463
1464 2019-01-10  Tom Tromey  <tom@tromey.com>
1465
1466         * xcoffread.c (scan_xcoff_symtab): Update.
1467         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1468         "where".
1469         * mdebugread.c (parse_partial_symbols)
1470         (handle_psymbol_enumerators): Update.
1471         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1472         * dbxread.c (read_dbx_symtab): Update.
1473         * psympriv.h (psymbol_placement): New enum.
1474         (add_psymbol_to_list): Update.
1475
1476 2019-01-10  Tom Tromey  <tom@tromey.com>
1477
1478         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1479         static_psymbols parameters.
1480         (scan_xcoff_symtab): Update.
1481         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1482         static_psymbols parameters.
1483         * psympriv.h (start_psymtab_common): Update.
1484         * mdebugread.c (parse_partial_symbols): Update.
1485         * dwarf2read.c (create_partial_symtab): Update.
1486         * dbxread.c (read_dbx_symtab): Update.
1487         (start_psymtab): Remove global_psymbols and static_psymbols
1488         parameters.
1489
1490 2019-01-10  Tom Tromey  <tom@tromey.com>
1491
1492         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1493         * psymtab.c (allocate_psymtab): Add comment.
1494         * psympriv.h (allocate_psymtab): Add comment.
1495         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1496         initializations.
1497         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1498
1499 2019-01-10  Tom Tromey  <tom@tromey.com>
1500
1501         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1502         Don't declare.
1503         * mipsread.c: Include mdebugread.h.
1504         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1505         Declare.
1506         * elfread.c: Include mdebugread.h.
1507
1508 2019-01-09  Tom Tromey  <tom@tromey.com>
1509
1510         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1511         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1512         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1513         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1514         (psym_lookup_symbol, psym_find_last_source_symtab)
1515         (psym_forget_cached_source_info, psym_print_stats)
1516         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1517         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1518         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1519         (psym_find_compunit_symtab_by_address)
1520         (maintenance_print_psymbols, maintenance_info_psymtabs)
1521         (maintenance_check_psymtabs): Use ranged for.
1522         * psymtab.h (class objfile_psymtabs): New.
1523         (require_partial_symbols): Return objfile_psymtabs.
1524         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1525
1526 2019-01-09  Tom Tromey  <tom@tromey.com>
1527
1528         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1529         (find_pc_mapped_section, list_overlays_command)
1530         (map_overlay_command, unmap_overlay_command)
1531         (simple_overlay_update): Use all_objfiles.
1532         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1533         * printcmd.c (info_symbol_command): Use all_objfiles.
1534         * objfiles.h (ALL_OBJSECTIONS): Remove.
1535         * maint.c (maintenance_translate_address): Use all_objfiles.
1536         * gcore.c (gcore_create_callback): Use all_objfiles.
1537         (objfile_find_memory_regions): Likewise.
1538
1539 2019-01-09  Tom Tromey  <tom@tromey.com>
1540
1541         * symtab.c (find_line_symtab, info_sources_command)
1542         (make_source_files_completion_list): Use objfile_compunits.
1543         * source.c (select_source_symtab): Use objfile_compunits.
1544         * objfiles.h (struct objfile): Update comment.
1545         (ALL_OBJFILES): Remove.
1546         (ALL_FILETABS): Remove.
1547         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1548         objfile_compunits.
1549
1550 2019-01-09  Tom Tromey  <tom@tromey.com>
1551
1552         * symmisc.c (print_objfile_statistics, dump_objfile)
1553         (maintenance_print_symbols): Use compunit_filetabs.
1554         * source.c (forget_cached_source_info_for_objfile): Use
1555         compunit_filetabs.
1556         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1557         (ALL_FILETABS): Use compunit_filetabs.
1558         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1559         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1560
1561 2019-01-09  Tom Tromey  <tom@tromey.com>
1562
1563         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1564         (compunit_filetabs): New.
1565         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1566         compunit_filetabs.
1567         (info_sources_command, make_source_files_completion_list): Remove
1568         declaration.
1569         * symmisc.c (print_objfile_statistics, dump_objfile)
1570         (maintenance_print_symbols): Remove declaration.
1571         (maintenance_info_symtabs): Use compunit_filetabs.
1572         (maintenance_info_line_tables): Likewise.
1573         * source.c (select_source_symtab): Change local variable name.
1574         (forget_cached_source_info_for_objfile): Remove declaration.
1575         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1576         * objfiles.c (objfile_relocate1): Remove declaration.
1577         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1578         declaration.
1579         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1580         * coffread.c (coff_symtab_read): Remove declaration.
1581         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1582         compunit_filetabs.
1583
1584 2019-01-09  Tom Tromey  <tom@tromey.com>
1585
1586         * symtab.c (lookup_objfile_from_block)
1587         (find_pc_sect_compunit_symtab, search_symbols)
1588         (default_collect_symbol_completion_matches_break_on): Use
1589         objfile_compunits.
1590         * objfiles.h (ALL_COMPUNITS): Remove.
1591         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1592         * cp-support.c (add_symbol_overload_list_qualified): Use
1593         objfile_compunits.
1594         * ada-lang.c (ada_collect_symbol_completion_matches)
1595         (ada_add_global_exceptions): Use objfile_compunits.
1596
1597 2019-01-09  Tom Tromey  <tom@tromey.com>
1598
1599         * source.c (select_source_symtab)
1600         (forget_cached_source_info_for_objfile): Remove declaration.
1601         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1602         declaration.
1603         * maint.c (count_symtabs_and_blocks): Remove declaration.
1604         * cp-support.c (add_symbol_overload_list_qualified): Remove
1605         declaration.
1606         * coffread.c (coff_symtab_read): Remove declaration.
1607         * symtab.c (lookup_symbol_in_objfile_symtabs)
1608         (basic_lookup_transparent_type_1): Use objfile_compunits.
1609         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
1610         (info_sources_command, search_symbols)
1611         (default_collect_symbol_completion_matches_break_on)
1612         (make_source_files_completion_list): Remove declaration.
1613         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
1614         (ada_collect_symbol_completion_matches)
1615         (ada_add_global_exceptions): Remove declaration.
1616         * linespec.c (iterate_over_all_matching_symtabs): Use
1617         objfile_compunits.
1618         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
1619         (class objfile_compunits): New.
1620         (ALL_COMPUNITS): Use objfile_compunits.
1621         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
1622         (maintenance_check_symtabs, maintenance_info_line_tables): Use
1623         objfile_compunits.
1624         * objfiles.c (objfile_relocate1): Use objfile_compunits.
1625
1626 2019-01-09  Tom Tromey  <tom@tromey.com>
1627
1628         * symtab.c (search_symbols)
1629         (default_collect_symbol_completion_matches_break_on): Use
1630         objfile_msymbols.
1631         * ada-lang.c (ada_lookup_simple_minsym)
1632         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
1633         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
1634         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
1635         objfile_msymbols.
1636         * coffread.c (coff_symfile_read): Use objfile_msymbols.
1637         * symmisc.c (dump_msymbols): Use objfile_msymbols.
1638         * objc-lang.c (find_methods): Use objfile_msymbols.
1639         (info_selectors_command, info_classes_command): Likewise.
1640         * stabsread.c (scan_file_globals): Use objfile_msymbols.
1641         * objfiles.h (class objfile_msymbols): New.
1642         (ALL_OBJFILE_MSYMBOLS): Remove.
1643         (ALL_MSYMBOLS): Remove.
1644
1645 2019-01-09  Tom Tromey  <tom@tromey.com>
1646
1647         * common/next-iterator.h (next_adapter): Add Iterator template
1648         parameter.
1649         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
1650         (class all_objfiles_safe): New.
1651         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
1652         * objfiles.c (put_objfile_before): Update comment.
1653         (add_separate_debug_objfile): Likewise.
1654         (free_all_objfiles): Use all_objfiles_safe.
1655         (objfile_purge_solibs): Likewise.
1656
1657 2019-01-09  Tom Tromey  <tom@tromey.com>
1658
1659         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1660         (expand_symtab_containing_pc, lookup_static_symbol)
1661         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
1662         (find_symbol_at_address, find_line_symtab, find_main_name): Use
1663         all_objfiles.
1664         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
1665         * breakpoint.c (create_overlay_event_breakpoint)
1666         (create_longjmp_master_breakpoint)
1667         (create_std_terminate_master_breakpoint)
1668         (create_exception_master_breakpoint): Use all_objfiles.
1669         * linux-thread-db.c (try_thread_db_load_from_pdir)
1670         (has_libpthread): Use all_objfiles.
1671         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
1672         * linespec.c (iterate_over_all_matching_symtabs)
1673         (search_minsyms_for_name): Use all_objfiles.
1674         * maint.c (maintenance_info_sections): Use all_objfiles.
1675         * main.c (captured_main_1): Use all_objfiles.
1676         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
1677         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
1678         * guile/scm-pretty-print.c
1679         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
1680         * solib-spu.c (append_ocl_sos): Use all_objfiles.
1681         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
1682         (maintenance_print_msymbols): Use all_objfiles.
1683         * source.c (select_source_symtab): Use all_objfiles.
1684         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
1685         * symfile.c (remove_symbol_file_command)
1686         (expand_symtabs_matching, map_symbol_filenames): Use
1687         all_objfiles.
1688         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
1689         all_objfiles.
1690         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
1691         * objc-lang.c (find_methods): Use all_objfiles.
1692         * objfiles.c (have_partial_symbols, have_full_symbols)
1693         (have_minimal_symbols, qsort_cmp)
1694         (default_iterate_over_objfiles_in_search_order): Use
1695         all_objfiles.
1696         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
1697         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
1698         (maintenance_check_psymtabs): Use all_objfiles.
1699         (ALL_PSYMTABS): Remove.
1700         * compile/compile-object-run.c (do_module_cleanup): Use
1701         all_objfiles.
1702         * blockframe.c (find_pc_partial_function): Use all_objfiles.
1703         * cp-support.c (add_symbol_overload_list_qualified): Use
1704         all_objfiles.
1705         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1706         Use all_objfiles.
1707         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
1708         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
1709         all_objfiles.
1710         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1711         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
1712         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1713         Uses all_objfiles.
1714         * solib.c (solib_read_symbols): Use all_objfiles
1715
1716 2019-01-09  Tom Tromey  <tom@tromey.com>
1717
1718         * probe.c (parse_probes_in_pspace): Use all_objfiles.
1719         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
1720         all_objfiles.
1721         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
1722         * symmisc.c (print_symbol_bcache_statistics)
1723         (print_objfile_statistics, maintenance_print_objfiles)
1724         (maintenance_info_symtabs, maintenance_check_symtabs)
1725         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
1726         all_objfiles.
1727         * source.c (forget_cached_source_info): Use all_objfiles.
1728         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
1729         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1730         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
1731         * objfiles.c (update_section_map): Use all_objfiles.
1732         (shared_objfile_contains_address_p): Likewise.
1733         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
1734         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
1735
1736 2019-01-09  Tom Tromey  <tom@tromey.com>
1737
1738         * common/next-iterator.h: New file.
1739         * objfiles.h (class all_objfiles): New.
1740         (struct objfile_iterator): New.
1741
1742 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1743
1744         * NEWS: Move the description of the changed "frame", "select-frame",
1745          and "info frame" commands to the Changed commands section.
1746
1747 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
1748
1749         * gdbtypes.c (check_stub_method_group): Remove handling of old
1750         mangling schemes.
1751         * linespec.c (find_methods): Likewise.
1752         * stabsread.c (read_member_functions): Likewise.
1753         * valops.c (search_struct_method): Likewise.
1754         (value_struct_elt_for_reference): Likewise.
1755         * NEWS: Mention this change.
1756
1757 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1758
1759         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
1760         print_source_lines.
1761         * source.c (print_source_lines_base): Update line number check.
1762         (print_source_lines): New function.
1763         (source_lines_range::source_lines_range): New function.
1764         * source.h (class source_lines_range): New class.
1765         (print_source_lines): New declaration.
1766
1767 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1768
1769         * linespec.c (linespec_state_destructor): Free self->canonical_names.
1770
1771 2019-01-08  Tom Tromey  <tom@tromey.com>
1772             Simon Marchi  <simon.marchi@ericsson.com>
1773
1774         PR gdb/24060
1775         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
1776         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
1777         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1778         * f-exp.y (DOLLAR_VARIABLE): Likewise.
1779         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
1780         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1781
1782 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1783
1784         * source.c (select_source_symtab): Move header comment to
1785         declaration in source.h.
1786         (forget_cached_source_info_for_objfile): Likewise.
1787         (forget_cached_source_info): Likewise.
1788         (identify_source_line): Likewise.
1789         * source.h (identify_source_line): Move declaration from symtab.h
1790         and add comment from source.c
1791         (print_source_lines): Likewise.
1792         (forget_cached_source_info_for_objfile): Likewise.
1793         (forget_cached_source_info): Likewise.
1794         (select_source_symtab): Likewise.
1795         (enum print_source_lines_flag): Move definition from symtab.h.
1796         * symtab.h (identify_source_line): Move declaration to source.h.
1797         (print_source_lines): Likewise.
1798         (forget_cached_source_info_for_objfile): Likewise.
1799         (forget_cached_source_info): Likewise.
1800         (select_source_symtab): Likewise.
1801         (enum print_source_lines_flag): Move definition to source.h.
1802         * tui/tui-hooks.c: Add 'source.h' include.
1803
1804 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1805
1806         * source.c (print_source_lines_base): Handle requests to print
1807         reverse line number sequences, and guard against empty lines
1808         string.
1809
1810 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1811
1812         * source.c (print_source_lines_base): Fix skip of '\r' if next
1813         character is '\n'.
1814
1815 2019-01-06  Tom Tromey  <tom@tromey.com>
1816
1817         * c-exp.y (struct c_parse_state) <macro_original_text,
1818         expansion_obstack>: New member.
1819         (macro_original_text, expansion_obstack): Remove globals.
1820         (scan_macro_expansion, scanning_macro_expansion)
1821         (finished_macro_expansion): Update.
1822         (scan_macro_cleanup): Remove.
1823         (yylex, c_parse): Update.
1824
1825 2019-01-06  Tom Tromey  <tom@tromey.com>
1826
1827         * c-exp.y (struct c_parse_state) <strings>: New member.
1828         (operator_stoken): Update.
1829
1830 2019-01-06  Tom Tromey  <tom@tromey.com>
1831
1832         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
1833         (union type_stack_elt) <typelist_val>: Now a pointer to
1834         std::vector.
1835         (type_stack_cleanup): Don't declare.
1836         (push_typelist): Update.
1837         * parse.c (pop_typelist): Return a std::vector.
1838         (push_typelist): Take a std::vector.
1839         (follow_types): Update.  Do not free args.
1840         (type_stack_cleanup): Remove.
1841         * c-exp.y (struct c_parse_state): New.
1842         (cpstate): New global.
1843         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
1844         (nonempty_typelist): Update.
1845         (func_mod): Create a new vector.
1846         (c_parse): Create a c_parse_state.
1847         (check_parameter_typelist): Do not delete params.
1848         (function_method): Update.  Do not delete type_list.
1849
1850 2019-01-06  Tom Tromey  <tom@tromey.com>
1851
1852         PR gdb/28155:
1853         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
1854         check_typedef.
1855         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
1856         (print_return_value): Likewise.
1857
1858 2019-01-05  Tom Tromey  <tom@tromey.com>
1859
1860         * contrib/cleanup_check.py: Remove.
1861         * contrib/gcc-with-excheck: Remove.
1862         * contrib/exsummary.py: Remove.
1863         * contrib/excheck.py: Remove.
1864
1865 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
1866
1867         * thread.c (delete_thread_1): Add gdb_assert that THR is not
1868         NULL. Initialize tpprev to NULL instead of assigning it
1869         to NULL on the next statement.
1870         * windows-nat.c (windows_delete_thread): Remove check for
1871         main_thread_id before printing thread exit notifications.
1872         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
1873         Remove thread ID check against main_thread_id.
1874         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
1875         windows_delete_thread.
1876         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
1877
1878 2019-01-04  Tom Tromey  <tom@tromey.com>
1879
1880         * compile/compile.c (_initialize_compile): Use upper case for
1881         metasyntactic variables.
1882         * symmisc.c (_initialize_symmisc): Use upper case for
1883         metasyntactic variables.
1884         * psymtab.c (_initialize_psymtab): Use upper case for
1885         metasyntactic variables.
1886         * demangle.c (demangle_command): Use upper case for metasyntactic
1887         variables.
1888         (_initialize_demangler): Likewise.
1889         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
1890         variables.
1891
1892 2019-01-03  Tom Tromey  <tom@tromey.com>
1893
1894         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
1895
1896 2019-01-03  Tom Tromey  <tom@tromey.com>
1897
1898         * python/py-symtab.c (salpy_str): Update.
1899         (struct salpy_sal_object) <symtab>: Now a PyObject.
1900         (salpy_dealloc): Update.
1901         (del_objfile_sal): Use gdbpy_ref.
1902
1903 2019-01-03  Tom Tromey  <tom@tromey.com>
1904
1905         * python/py-type.c (convert_field): Use new_reference.  Return
1906         gdbpy_ref.
1907         (make_fielditem): Return gdbpy_ref.
1908         (typy_fields): Update.
1909         (typy_getitem): Update.
1910         (field_name): Return gdbpy_ref.  Use new_reference.
1911         (typy_iterator_iternext): Update.
1912
1913 2019-01-03  Tom Tromey  <tom@tromey.com>
1914
1915         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
1916
1917 2019-01-03  Tom Tromey  <tom@tromey.com>
1918
1919         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
1920         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
1921         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
1922         (pspy_set_frame_filters, pspy_set_frame_unwinders)
1923         (pspy_set_type_printers): Likewise.
1924         * python/py-function.c (fnpy_init): Use gdbpy_ref.
1925         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
1926         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
1927         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
1928         (objfpy_set_type_printers): Likewise.
1929
1930 2019-01-03  Tom Tromey  <tom@tromey.com>
1931
1932         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
1933         (gdbpy_print_stack): Use gdbpy_err_fetch.
1934         * python/python-internal.h (class gdbpy_err_fetch): New class.
1935         (class gdbpy_enter) <m_error_type, m_error_value,
1936         m_error_traceback>: Remove.
1937         <m_error>: New member.
1938         (gdbpy_exception_to_string): Don't declare.
1939         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
1940         * python/py-value.c (convert_value_from_python): Use
1941         gdbpy_err_fetch.
1942         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
1943         gdbpy_exception_to_string.
1944         (gdbpy_handle_exception): Use gdbpy_err_fetch.
1945         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1946         gdbpy_err_fetch.
1947
1948 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1949
1950         * linux-nat.c (delete_lwp_cleanup): Delete.
1951         (struct lwp_deleter): New struct.
1952         (lwp_info_up): New typedef.
1953         (linux_nat_target::follow_fork): Delete cleanup, and make use of
1954         lwp_info_up.
1955
1956 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1957
1958         * linux-fork.c (class scoped_switch_fork_info): New class.
1959         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
1960
1961 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1962
1963         * valops.c (find_overload_match): Remove use of null_cleanup, and
1964         calls to do_cleanups.
1965
1966 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1967
1968         * compile/compile-cplus-types.c
1969         (compile_cplus_instance::decl_name): Handle changes to
1970         cp_func_name.
1971         * cp-support.c (cp_func_name): Update header comment, update
1972         return type.
1973         * cp-support.h (cp_func_name): Update return type in declaration.
1974         * valops.c (find_overload_match): Move temp_func local to top
1975         level of function and change its type.  Use temp_func to hold and
1976         delete temporary string obtained from cp_func_name.
1977
1978 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1979
1980         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
1981         gdb::char_vector, remove cleanup, and update uses of `msg`.
1982
1983 2019-01-03  Jim Wilson  <jimw@sifive.com>
1984
1985         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
1986
1987 2019-01-02  Tom Tromey  <tom@tromey.com>
1988
1989         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
1990         (tdesc_parse_xml): Remove cleanups.
1991         * target-descriptions.h (make_cleanup_free_target_description):
1992         Don't declare.
1993         (target_desc_deleter): New struct.
1994         (target_desc_up): New typedef.
1995         * target-descriptions.c (target_desc_deleter::operator()): Rename
1996         from free_target_description.
1997         (make_cleanup_free_target_description): Remove.
1998
1999 2019-01-02  Tom Tromey  <tom@tromey.com>
2000
2001         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2002         constructor, destructor.
2003         (linespec_parser): Remove typedef.
2004         (~linespec_parser): Rename from linespec_parser_delete.
2005         (linespec_lex_to_end, linespec_complete_label)
2006         (linespec_complete): Update.
2007         (decode_line_full): Remove cleanups.
2008         (decode_line_1): Update.
2009
2010 2019-01-02  Tom Tromey  <tom@tromey.com>
2011
2012         * python/python-internal.h (inferior_to_inferior_object): Change
2013         return type.
2014         * python/py-exitedevent.c (create_exited_event_object): Update.
2015         * python/py-inferior.c (inferior_to_inferior_object): Return
2016         gdbpy_ref.
2017         (python_new_inferior, python_inferior_deleted)
2018         (thread_to_thread_object, delete_thread_object)
2019         (build_inferior_list, gdbpy_selected_inferior): Update.
2020         * python/py-infthread.c (create_thread_object): Update.  Also fail
2021         if inferior_to_inferior_object fails.
2022
2023 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2024
2025         * inferior.h (class inferior) <displaced_step_state>: New field.
2026         * infrun.h (struct displaced_step_state): Move here from
2027         infrun.c.  Initialize fields, add constructor.
2028         <inf>: Remove field.
2029         <reset>: New method.
2030         * infrun.c (struct displaced_step_inferior_state): Move to
2031         infrun.h.
2032         (displaced_step_inferior_states): Remove.
2033         (get_displaced_stepping_state): Adust.
2034         (displaced_step_in_progress_any_inferior): Adjust.
2035         (displaced_step_in_progress_thread): Adjust.
2036         (displaced_step_in_progress): Adjust.
2037         (add_displaced_stepping_state): Remove.
2038         (get_displaced_step_closure_by_addr): Adjust.
2039         (remove_displaced_stepping_state): Remove.
2040         (infrun_inferior_exit): Call displaced_step_state.reset.
2041         (use_displaced_stepping): Don't check for NULL.
2042         (displaced_step_prepare_throw): Call
2043         get_displaced_stepping_state.
2044         (displaced_step_fixup): Don't check for NULL.
2045         (prepare_for_detach): Don't check for NULL.
2046
2047 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2048
2049         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2050          in case of call that did not complete.
2051
2052 2019-01-02  Andrey Utkin  <autkin@undo.io>
2053
2054         * symfile.c (find_separate_debug_file): Fix search of debug files for
2055         remote debuggee.
2056
2057 2019-01-02  Tom Tromey  <tom@tromey.com>
2058
2059         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2060         indentation.
2061         * python/py-frame.c (frapy_older): Remove cast.
2062         (frapy_newer): Likewise.
2063         * python/py-breakpoint.c (local_setattro): Remove cast.
2064         * python/py-arch.c (archpy_name): Remove local variable.
2065         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2066
2067 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2068
2069         * unittests/basic_string_view/element_access/char/empty.cc:
2070         Fix year range in copyright header.
2071
2072 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2073
2074         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2075         Delete.
2076         <operator==>: Update with for removed field.
2077         <hash>: Likewise.
2078         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2079         <isa_features>: ...this.
2080         <abi_features>: New field.
2081         (riscv_isa_flen): Update comment.
2082         (riscv_abi_xlen): New declaration.
2083         (riscv_abi_flen): New declaration.
2084         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2085         isa_features.
2086         (riscv_abi_xlen): New function.
2087         (riscv_isa_flen): Update to get answer from isa_features.
2088         (riscv_abi_flen): New function.
2089         (riscv_has_fp_abi): Update to get answer from abi_features.
2090         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2091         xlen and flen.
2092         (riscv_call_info) <xlen, flen>: Update comment.
2093         (riscv_call_arg_struct): Remove invalid assertions
2094         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2095         is removed.
2096         (riscv_gdbarch_init): Gather isa features and abi features
2097         separately, ensure both match on the gdbarch when reusing an old
2098         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2099         a target with 64-bit float hardware.
2100
2101 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2102
2103         * source.c (search_command_helper): Stop reverse search
2104         when line 1 has been searched.
2105
2106 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2107
2108         * record-full.c (record_full_base_target::close): Rewrite
2109         record_full_core_buf_list free logic.
2110
2111 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2112
2113         * break-catch-syscall.c (print_one_catch_syscall): xfree
2114         the last text.
2115
2116 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2117
2118         * top.c (print_gdb_version): Update Copyright year in version
2119         message.
2120
2121 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2122
2123         Update copyright year range in all GDB files.
2124
2125 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2126
2127         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2128
2129 For older changes see ChangeLog-2018.
2130 \f
2131 Local Variables:
2132 mode: change-log
2133 left-margin: 8
2134 fill-column: 74
2135 version-control: never
2136 coding: utf-8
2137 End:
2138