gdb/ChangeLog

   1 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
   2
   3         * symfile.c (find_separate_debug_file): Remove colon from the
   4         drive spec of DOS/Windows file names of the target, so that the
   5         file name produced from DEBUGDIR and the target's directory will
   6         be valid on DOS/Windows systems.
   7
   8 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
   9
  10         * rust-lang.c (val_print_struct): Handle printing structures
  11         containing strings.
  12
  13 2019-05-02  Tom Tromey  <tromey@adacore.com>
  14
  15         * valarith.c (_initialize_valarith): Remove.
  16
  17 2019-05-01  Tom Tromey  <tromey@adacore.com>
  18
  19         * ada-lang.c (ada_value_primitive_field): Treat more fields as
  20         bitfields.
  21
  22 2019-05-01  Tom Tromey  <tromey@adacore.com>
  23
  24         * ada-lang.c (ada_value_assign): Correctly compute starting offset
  25         for big-endian copies.
  26
  27 2019-04-30  Ali Tamur  <tamur@google.com>
  28         * gdb/dwarf2read.c (read_3_bytes): New declaration.
  29         (read_attribute_value): Added DW_FORM_strx1-4 cases.
  30         (read_3_bytes): New function.
  31
  32 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
  33
  34         * windows-nat.c (main_thread_id): Delete.
  35         (handle_output_debug_string): Replace main_thread_id by
  36         current_event.dwThreadId.
  37         (fake_create_process): Likewise.
  38         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
  39         Do not set main_thread_id.
  40         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
  41         current_event.dwThreadId.
  42         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
  43
  44 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
  45
  46         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
  47         Use current_event.dwThreadId instead of main_thread_id.
  48
  49 2019-04-30  Tom Tromey  <tromey@adacore.com>
  50
  51         * ada-lang.c (ada_lookup_simple_minsyms): New function.
  52         (create_excep_cond_exprs): Iterate over program spaces.
  53         (ada_exception_catchpoint_cond_string): Examine all minimal
  54         symbols for exception types.
  55
  56 2019-04-30  Tom Tromey  <tromey@adacore.com>
  57
  58         PR c++/24470:
  59         * dwarf2read.c (process_structure_scope): Handle case where type
  60         has template parameters but no symbol was created.
  61
  62 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  63             Chris January  <chris.january@arm.com>
  64
  65         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
  66         qualifier.
  67         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
  68
  69 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  70
  71         * f-typeprint.c (f_print_type): Update rules for printing
  72         whitespace.
  73         (f_type_print_varspec_suffix): Likewise.
  74
  75 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  76             Chris January  <chris.january@arm.com>
  77
  78         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
  79         function arguments.
  80
  81 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  82
  83         * f-lang.c (build_fortran_types): Change name of void type to
  84         lower case.
  85         * f-typeprint.c (f_type_print_base): Print the name of the void
  86         type, rather than a fixed string.
  87         * f-valprint.c (f_decorations): Use lower case void string.
  88
  89 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  90             Chris January  <chris.january@arm.com>
  91
  92         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
  93         types for Fortran.
  94
  95 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  96             Chris January  <chris.january@arm.com>
  97             David Lecomber  <david.lecomber@arm.com>
  98
  99         * f-exp.y (BINOP_INTRINSIC): New token.
 100         (exp): New parser rule handling BINOP_INTRINSIC.
 101         (f77_keywords): Add new builtin procedures.
 102         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 103         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 104         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 105         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 106         (print_unop_subexp_f): New function.
 107         (print_binop_subexp_f): New function.
 108         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 109         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 110         (dump_subexp_body_f): Likewise.
 111         (operator_check_f): Likewise.
 112         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 113         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 114
 115 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 116
 117         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 118         UNOP_KIND.
 119         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 120         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 121         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 122         (operator_length_f): New fuction.
 123         (print_subexp_f): New function.
 124         (op_name_f): New function.
 125         (dump_subexp_body_f): New function.
 126         (operator_check_f): New function.
 127         (exp_descriptor_f): Replace standard expression handling functions
 128         with new functions.
 129         * gdb/fortran-operator.def: New file.
 130         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 131         * gdb/std-operator.def: Remove UNOP_KIND.
 132
 133 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 134
 135         * std-operator.def: Remove unbalanced, stray double quote
 136         character.
 137
 138 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 139             Chris January  <chris.january@arm.com>
 140             Daniel Everett  <daniel.everett@arm.com>
 141             Nick Forrington  <nick.forrington@arm.com>
 142             Richard Bunt  <richard.bunt@arm.com>
 143
 144         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 145         of depth when printing anonymous structs or unions.
 146         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 147         Don't print either the top-level value, or the children if the
 148         max-depth is exceeded.
 149         (ppscm_print_children): When printing the key of a map, allow one
 150         extra level of depth.
 151         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 152         print either the top-level value, or the children if the max-depth
 153         is exceeded.
 154         (print_children): When printing the key of a map, allow one extra
 155         level of depth.
 156         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 157         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 158         (user_print_options): Initialise max_depth field.
 159         (val_print_scalar_or_string_type_p): New function.
 160         (val_print): Check to see if the max depth has been reached.
 161         (val_print_check_max_depth): Define new function.
 162         (show_print_max_depth): New function.
 163         (_initialize_valprint): Add 'print max-depth' option.
 164         * valprint.h (struct value_print_options) <max_depth>: New field.
 165         (val_print_check_max_depth): Declare new function.
 166         * NEWS: Document new feature.
 167
 168 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 169
 170         * ada-lang.c (ada_language_defn): Initialise new field.
 171         * c-lang.c (c_is_string_type_p): New function.
 172         (c_language_defn): Initialise new field.
 173         (cplus_language_defn): Initialise new field.
 174         (asm_language_defn): Initialise new field.
 175         (minimal_language_defn): Initialise new field.
 176         * c-lang.h (c_is_string_type_p): Declare new function.
 177         * d-lang.c (d_language_defn): Initialise new field.
 178         * f-lang.c (f_is_string_type_p): New function.
 179         (f_language_defn): Initialise new field.
 180         * go-lang.c (go_is_string_type_p): New function.
 181         (go_language_defn): Initialise new field.
 182         * language.c (default_is_string_type_p): New function.
 183         (unknown_language_defn): Initialise new field.
 184         (auto_language_defn): Initialise new field.
 185         * language.h (struct language_defn) <la_is_string_type_p>: New
 186         member variable.
 187         (default_is_string_type_p): Declare new function.
 188         * m2-lang.c (m2_language_defn): Initialise new field.
 189         * objc-lang.c (objc_language_defn): Initialise new field.
 190         * opencl-lang.c (opencl_language_defn): Initialise new field.
 191         * p-lang.c (pascal_is_string_type_p): New function.
 192         (pascal_language_defn): Initialise new field.
 193         * rust-lang.c (rust_is_string_type_p): New function.
 194         (rust_language_defn): Initialise new field.
 195
 196 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 197
 198         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 199         New field.
 200         * ada-lang.c (ada_language_defn): Initialise new field.
 201         * c-lang.c (c_language_defn): Likewise.
 202         (cplus_language_defn): Likewise.
 203         (asm_language_defn): Likewise.
 204         (minimal_language_defn): Likewise.
 205         * d-lang.c (d_language_defn): Likewise.
 206         * f-lang.c (f_language_defn): Likewise.
 207         * go-lang.c (go_language_defn): Likewise.
 208         * language.c (unknown_language_defn): Likewise.
 209         (auto_language_defn): Likewise.
 210         * m2-lang.c (m2_language_defn): Likewise.
 211         * objc-lang.c (objc_language_defn): Likewise.
 212         * opencl-lang.c (opencl_language_defn): Likewise.
 213         * p-lang.c (pascal_language_defn): Likewise.
 214         * rust-lang.c (rust_language_defn): Likewise.
 215
 216 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 217
 218         * ada-lang.c (ada_is_character_type): Change return type to bool.
 219         (ada_is_string_type): Likewise.
 220         * ada-lang.h (ada_is_character_type): Update declaration
 221         (ada_is_string_type): Likewise.
 222
 223 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 224
 225         Support style in 'frame|thread apply'
 226
 227         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 228         * record.c (record_start, record_stop): Update callers of
 229         execute_command_to_string with false.
 230         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 231         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 232         methods.
 233         (class string_file): New constructor with term_out parameter.
 234         Override methods term_out and can_emit_style_escape.  New member
 235         term_out.
 236         (class stdio_file): Override can_emit_style_escape.
 237         (class tee_file): Override term_out and can_emit_style_escape.
 238         * utils.h (can_emit_style_escape): Remove.
 239         * utils.c (can_emit_style_escape): Likewise.
 240         Update all callers of can_emit_style_escape (SOMESTREAM) to
 241         SOMESTREAM->can_emit_style_escape.
 242         * source-cache.c (source_cache::get_source_lines): Likewise.
 243         * stack.c (frame_apply_command_count): Call execute_command_to_string
 244         passing the term_out characteristic of the current gdb_stdout.
 245         * thread.c (thr_try_catch_cmd): Likewise.
 246         * top.c (execute_command_to_string): pass term_out parameter
 247         to construct the string_file for the command output.
 248         * ui-file.c (term_cli_styling): New function (most code moved
 249         from utils.c can_emit_style_escape).
 250         (string_file::string_file, string_file::can_emit_style_escape,
 251         stdio_file::can_emit_style_escape, tee_file::term_out,
 252         tee_file::can_emit_style_escape): New functions.
 253
 254 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 255
 256         * NEWS: Mention the new set|show may-call-functions.
 257         * infcall.c (may_call_functions_p): New variable.
 258         (show_may_call_functions_p): New function.
 259         (call_function_by_hand_dummy): Throws an error if not
 260         may-call-functions.
 261         (_initialize_infcall): Call add_setshow_boolean_cmd for
 262         may-call-functions.
 263
 264 2019-04-25  Keith Seitz  <keiths@redhat.com>
 265
 266         PR c++/24367
 267         * cp-support.c (inspect_type): Don't attempt substitutions
 268         of symbol with the same name.
 269
 270 2019-04-25  Tom Tromey  <tromey@adacore.com>
 271
 272         PR gdb/24475:
 273         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 274         static.
 275
 276 2019-04-25  Tom Tromey  <tromey@adacore.com>
 277
 278         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 279         rvalue reference.
 280         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 281         (gdb_xml_parser::parse): Use std::move.
 282         * python/python-internal.h (gdbpy_convert_exception): Take a const
 283         reference.
 284         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 285         std::move.
 286         * python/py-utils.c (gdbpy_convert_exception): Take a const
 287         reference.
 288         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 289         Use std::move.
 290         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 291         Use std::move.
 292         * mi/mi-main.c (mi_print_exception): Take a const reference.
 293         * main.c (handle_command_errors): Take a const reference.
 294         * linespec.c (parse_linespec): Use std::move.
 295         * infcall.c (run_inferior_call): Use std::move.
 296         (call_function_by_hand_dummy): Use std::move.
 297         * exec.c (try_open_exec_file): Use std::move.
 298         * exceptions.h (exception_print, exception_fprintf)
 299         (exception_print_same): Update.
 300         * exceptions.c (print_exception, exception_print)
 301         (exception_fprintf, exception_print_same): Change parameters to
 302         const reference.
 303         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
 304         * common/new-op.c: Use std::move.
 305         * common/common-exceptions.h (struct gdb_exception): Add move
 306         constructor.
 307         (struct gdb_exception_error, struct gdb_exception_quit, struct
 308         gdb_quit_bad_alloc): Change constructor to move constructor.
 309         (throw_exception): Change parameter to rvalue reference.
 310         * common/common-exceptions.c (throw_exception): Take rvalue
 311         reference.
 312         * cli/cli-interp.c (safe_execute_command): Use std::move.
 313         * breakpoint.c (insert_bp_location, location_to_sals): Use
 314         std::move.
 315
 316 2019-04-25  Tom Tromey  <tromey@adacore.com>
 317
 318         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 319         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 320         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 321         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 322         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 323         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 324         guile/scm-value.c: Use unpack.
 325         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 326         gdbscm_gdb_exception.
 327         (gdbscm_throw_gdb_exception): Likewise.
 328         (struct gdbscm_gdb_exception): New.
 329         (unpack): New function.
 330         (gdbscm_wrap): Use unpack.
 331
 332 2019-04-25  Tom Tromey  <tromey@adacore.com>
 333
 334         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 335         (gdb_rl_callback_handler): Use std::move.
 336         * common/common-exceptions.h (struct gdb_exception): Add move
 337         assignment operator.
 338         (throw_exception_sjlj): Change "exception" to const reference.
 339         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 340         (throw_exception_sjlj): Change "exception" to const reference.
 341
 342 2019-04-25  Tom Tromey  <tromey@adacore.com>
 343
 344         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 345         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 346         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 347         Update.
 348         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 349         Update.
 350         * mi/mi-interp.c (mi_interp::exec): Update.
 351         * linespec.c (parse_linespec): Update.
 352         * infcall.c (run_inferior_call): Update.
 353         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
 354         * guile/scm-symbol.c (gdbscm_lookup_symbol)
 355         (gdbscm_lookup_global_symbol): Update.
 356         * guile/scm-param.c (gdbscm_parameter_value): Update.
 357         * guile/scm-frame.c (gdbscm_frame_read_register)
 358         (gdbscm_frame_read_var): Update.
 359         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
 360         * exec.c (try_open_exec_file): Update.
 361         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 362         (gdb_rl_callback_handler): Update.
 363         * common/common-exceptions.h (exception_none): Don't declare.
 364         * common/common-exceptions.c (exception_none): Don't define.
 365         (struct catcher) <exception>: Update.
 366         * cli/cli-interp.c (safe_execute_command): Update.
 367         * breakpoint.c (insert_bp_location, location_to_sals): Update.
 368
 369 2019-04-25  Ali Tamur  <tamur@google.com>
 370
 371         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
 372         (read_attribute_value): Likewise.
 373         (dwarf2_read_addr_index): Update comment.
 374         (read_str_index): Add DW_FORM_strx.
 375         (dwarf2_string_attr): Likewise.
 376         (dwarf2_const_value_attr): Likewise.
 377         (dump_die_shallow): Likewise.
 378         (dwarf2_fetch_constant_bytes): Likewise.
 379         (skip_form_bytes): Likewise.
 380         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
 381
 382 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
 383
 384         PR corefiles/11608
 385         PR corefiles/18187
 386         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
 387         OFFSET.  Verify if current mapping contains an ELF header.
 388         (linux_find_memory_regions_full): Adjust call to
 389         dump_mapping_p.
 390
 391 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
 392             Kang Li <kanglictf@gmail.com>
 393
 394         PR gdb/21600
 395
 396         * dwarf2-frame.c (read_initial_length): Be consistent about using
 397         unsigned representation of length.
 398         (decode_frame_entry_1): Likewise.  Check for wraparound of
 399         end pointer as well as buffer overflow.
 400
 401 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
 402
 403         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
 404         "vq".
 405
 406 2019-04-24  Tom Tromey  <tromey@adacore.com>
 407
 408         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
 409
 410 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 411
 412         * s12z-tdep.c (s12z_unwind_pc): Delete.
 413         (s12z_unwind_sp): Delete.
 414         (s12z_gdbarch_init): Don't register deleted functions with
 415         gdbarch.
 416
 417 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 418
 419         * rl78-tdep.c (rl78_unwind_sp): Delete.
 420         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
 421
 422 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 423
 424         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
 425         (xstormy16_unwind_pc): Delete.
 426         (xstormy16_dummy_id): Delete.
 427         (xstormy16_gdbarch_init): Don't register deleted functions with
 428         gdbarch.
 429
 430 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 431
 432         * vax-tdep.c (vax_unwind_pc): Delete.
 433         (vax_gdbarch_init): Don't register deleted function with gdbarch.
 434
 435 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 436
 437         * v850-tdep.c (v850_unwind_sp): Delete.
 438         (v850_unwind_pc): Delete.
 439         (v850_dummy_id): Delete.
 440         (v850_gdbarch_init): Don't register deleted functions with
 441         gdbarch.
 442
 443 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 444
 445         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
 446         (tilegx_unwind_pc): Delete.
 447         (tilegx_unwind_dummy_id): Delete.
 448         (tilegx_gdbarch_init): Don't register deleted functions with
 449         gdbarch.
 450
 451 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 452
 453         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
 454         (tic6x_dummy_id): Delete.
 455         (tic6x_gdbarch_init): Don't register deleted functions with
 456         gdbarch.
 457
 458 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 459
 460         * sparc-tdep.c (sparc_unwind_pc): Delete.
 461         (sparc32_gdbarch_init): Don't register deleted function with
 462         gdbarch.
 463
 464 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 465
 466         * sh-tdep.c (sh_unwind_sp): Delete.
 467         (sh_unwind_pc): Delete.
 468         (sh_dummy_id): Delete.
 469         (sh_gdbarch_init): Don't register deleted functions with
 470         gdbarch.
 471
 472 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 473
 474         * score-tdep.c (score_unwind_sp): Delete.
 475         (score_unwind_pc): Delete.
 476         (score_dummy_id): Delete.
 477         (score_gdbarch_init): Don't register deleted functions with
 478         gdbarch.
 479
 480 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 481
 482         * rx-tdep.c (rx_unwind_pc): Delete.
 483         (rx_unwind_sp): Delete.
 484         (rx_dummy_id): Delete.
 485         (rx_gdbarch_init): Don't register deleted functions with
 486         gdbarch.  Update comment.
 487
 488 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 489
 490         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
 491         (rs6000_dummy_id): Delete.
 492         (rs6000_gdbarch_init): Don't register deleted functions with
 493         gdbarch.
 494
 495 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 496
 497         * or1k-tdep.c (or1k_dummy_id): Delete.
 498         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
 499
 500 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 501
 502         * nios2-tdep.c (nios2_dummy_id): Delete.
 503         (nios2_unwind_sp): Delete.
 504         (nios2_gdbarch_init): Don't register deleted functions with
 505         gdbarch.
 506
 507 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 508
 509         * nds32-tdep.c (nds32_dummy_id): Delete.
 510         (nds32_unwind_pc): Delete.
 511         (nds32_unwind_sp): Delete.
 512         (nds32_gdbarch_init): Don't register deleted functions with
 513         gdbarch.
 514
 515 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 516
 517         * msp430-tdep.c (msp430_unwind_pc): Delete.
 518         (msp430_unwind_sp): Delete.
 519         (msp430_dummy_id): Delete.
 520         (msp430_gdbarch_init): Don't register deleted functions with
 521         gdbarch.
 522
 523 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 524
 525         * moxie-tdep.c (moxie_unwind_sp): Delete.
 526         (moxie_unwind_pc): Delete.
 527         (moxie_dummy_id): Delete.
 528         (moxie_gdbarch_init): Don't register deleted functions with
 529         gdbarch.
 530
 531 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 532
 533         * mn10300-tdep.c (mn10300_dummy_id): Delete.
 534         (mn10300_unwind_pc): Delete.
 535         (mn10300_unwind_sp): Delete.
 536         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
 537         mn10300_unwind_sp.
 538         (mn10300_frame_unwind_init): Don't register deleted functions with
 539         gdbarch.
 540
 541 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 542
 543         * mep-tdep.c (mep_unwind_pc): Delete.
 544         (mep_unwind_sp): Delete.
 545         (mep_dummy_id): Delete.
 546         (mep_gdbarch_init): Don't register deleted functions with
 547         gdbarch.
 548
 549 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 550
 551         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
 552         (m68hc11_unwind_sp): Delete.
 553         (m68hc11_gdbarch_init): Don't register deleted functions with
 554         gdbarch.
 555
 556 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 557
 558         * m32r-tdep.c (m32r_unwind_sp): Delete.
 559         (m32r_unwind_pc): Delete.
 560         (m32r_dummy_id): Delete.
 561         (m32r_gdbarch_init): Don't register deleted functions with
 562         gdbarch.
 563
 564 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 565
 566         * m32c-tdep.c (m32c_unwind_pc): Delete.
 567         (m32c_unwind_sp): Delete.
 568         (m32c_dummy_id): Delete.
 569         (m32c_gdbarch_init): Don't register deleted functions with
 570         gdbarch.
 571
 572 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 573
 574         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
 575         (lm32_unwind_pc): Delete.
 576         (lm32_dummy_id): Delete.
 577         (lm32_gdbarch_init): Don't register deleted functions with
 578         gdbarch.
 579
 580 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 581
 582         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
 583         (iq2000_unwind_pc): Delete.
 584         (iq2000_dummy_id): Delete.
 585         (iq2000_gdbarch_init): Don't register deleted functions with
 586         gdbarch.
 587
 588 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 589
 590         * nds32-tdep.c (nds32_type_align): Delete.
 591         (nds32_push_dummy_call): Use type_align instead.
 592
 593 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 594
 595         * arm-tdep.c (arm_type_align): Only handle vector override case.
 596         (arm_push_dummy_call): Use type_align.
 597         (arm_gdbarch_init): Register arm_type_align gdbarch function.
 598
 599 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 600
 601         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
 602         case.
 603         (pass_on_stack): Use type_align.
 604         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
 605         function.
 606
 607 2019-04-23  Tom Tromey  <tromey@adacore.com>
 608
 609         * dwarf2read.c (line_header::file_name_at): Remove unused
 610         overload.
 611
 612 2019-04-23  Tom de Vries  <tdevries@suse.de>
 613
 614         PR gdb/24438
 615         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
 616         invocation.
 617
 618
 619 2019-03-27  Ali Tamur  <tamur@google.com>
 620
 621         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
 622         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
 623         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
 624         (dwarf_expr_context::get_addr_index): Likewise
 625         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
 626         (symbol_needs_eval_context::get_addr_index): Likewise
 627         (disassemble_dwarf_expression): Add DW_OP_addrx
 628         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
 629         (read_cutu_die_from_dwo): Update comment
 630         (skip_one_die): Add DW_FORM_addrx
 631         (read_attribute_value): Likewise
 632         (var_decode_location): Add DW_OP_addrx
 633         (dwarf2_const_value_attr): Add DW_FORM_addrx
 634         (dump_die_shallow): Likewise
 635         (dwarf2_fetch_constant_bytes): Likewise
 636         (decode_locdesc): Add DW_OP_addrx
 637         (skip_form_bytes): Add DW_FORM_addrx
 638
 639 2019-04-22  Ali Tamur  <tamur@google.com>
 640
 641         * MAINTAINERS (Write After Approval): Add self.
 642
 643 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
 644
 645         * solib-svr4.c (get_svr4_info): Add pspace parameter.
 646         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
 647         (open_symbol_file_object): Likewise.
 648         (svr4_default_sos): Add info parameter.
 649         (svr4_read_so_list): Likewise.
 650         (svr4_current_sos_direct): Adjust functions calls to pass down
 651         info.
 652         (svr4_current_sos_1): Add info parameter.
 653         (svr4_current_sos): Call get_svr4_info, pass info down to
 654         svr4_current_sos_1.
 655         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
 656         get_svr4_info.
 657         (svr4_in_dynsym_resolve_code): Pass current_program_space to
 658         get_svr4_info.
 659         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
 660         to get_svr4_info.
 661         (probes_table_remove_objfile_probes): Likewise.
 662         (register_solib_event_probe): Add info parameter.
 663         (solist_update_incremental): Pass info parameter down to
 664         svr4_read_so_list.
 665         (disable_probes_interface): Add info parameter.
 666         (svr4_handle_solib_event): Pass current_program_space to
 667         get_svr4_info.  Adjust disable_probes_interface cleanup.
 668         (svr4_create_probe_breakpoints): Add info parameter, pass it
 669         down to register_solib_event_probe.
 670         (svr4_create_solib_event_breakpoints): Add info parameter,
 671         pass it down to svr4_create_probe_breakpoints.
 672         (enable_break): Pass info down to
 673         svr4_create_solib_event_breakpoints.
 674         (svr4_solib_create_inferior_hook): Pass current_program_space to
 675         get_svr4_info.
 676         (svr4_clear_solib): Likewise.
 677
 678 2019-04-22  Pedro Alves  <palves@redhat.com>
 679
 680         * solib-svr4.c (svr4_free_objfile_observer): New.
 681         (probe_and_action::objfile): New field.
 682         (probes_table_htab_remove_objfile_probes)
 683         (probes_table_remove_objfile_probes): New functions.
 684         (register_solib_event_probe): Add 'objfile' parameter.  Store it
 685         in the new probe_and_action.  Don't store the probe in 'lookup'.
 686         (svr4_create_probe_breakpoints): Pass objfile to
 687         register_solib_event_probe.
 688         (_initialize_svr4_solib): Register a free_objfile observer.
 689
 690 2019-04-19  Tom Tromey  <tom@tromey.com>
 691
 692         * common/queue.h: Remove.
 693
 694 2019-04-19  Tom Tromey  <tom@tromey.com>
 695
 696         * event-loop.c: Don't include "common/queue.h".
 697
 698 2019-04-19  Tom Tromey  <tom@tromey.com>
 699
 700         * remote.c (remote_target): Use delete.
 701         * remote-notif.h: Include <list>, not "common/queue.h".
 702         (notif_client_p): Remove typedef.
 703         (remote_notif_state): Add constructor, destructor, initializer.
 704         <notif_queue>: Now a std::list.
 705         (remote_notif_state_xfree): Don't declare.
 706         * remote-notif.c (remote_notif_process, handle_notification)
 707         (remote_notif_state_allocate): Update.
 708         (~remote_notif_state): Rename from remote_notif_state_xfree.
 709
 710 2019-04-19  Tom Tromey  <tom@tromey.com>
 711
 712         * symfile.c (reread_symbols): Update.
 713         * objfiles.c (objfile_register_static_link)
 714         (objfile_lookup_static_link): Update
 715         (~objfile) Don't delete static_links.
 716         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
 717
 718 2019-04-19  Tom Tromey  <tom@tromey.com>
 719
 720         * type-stack.h (struct type_stack) <insert>: Constify string.
 721         * type-stack.c (type_stack::insert): Constify string.
 722         * gdbtypes.h (lookup_template_type): Update.
 723         (address_space_name_to_int): Update.
 724         * gdbtypes.c (address_space_name_to_int): Make space_identifier
 725         const.
 726         (lookup_template_type): Make name const.
 727         * c-exp.y: Update rules.
 728         (lex_one_token, classify_name, classify_inner_name)
 729         (c_print_token): Update.
 730         * p-exp.y: Update rules.
 731         (yylex): Update.
 732         * f-exp.y: Update rules.
 733         (yylex): Update.
 734         * d-exp.y: Update rules.
 735         (lex_one_token, classify_name, classify_inner_name): Update.
 736         * parse.c (write_dollar_variable, copy_name): Return std::string.
 737         * parser-defs.h (copy_name): Change return type.
 738         * m2-exp.y: Update rules.
 739         (yylex): Update.
 740         * go-exp.y (lex_one_token): Update.
 741         Update rules.
 742         (classify_unsafe_function, classify_packaged_name)
 743         (classify_name, yylex): Update.
 744
 745 2019-04-19  Sergei Trofimovich <siarheit@google.com>
 746
 747         * configure.ac: add --enable-source-highlight switch.
 748         * configure: Regenerate.
 749         * top.c (print_gdb_version): plumb --enable-source-highlight
 750         status to "show configuration".
 751
 752 2019-04-19  Tom Tromey  <tromey@adacore.com>
 753
 754         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
 755         Check ADA_TYPE_P.
 756         (empty_record, ada_template_to_fixed_record_type_1)
 757         (template_to_static_fixed_type)
 758         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
 759         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
 760         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
 761         macros.
 762
 763 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
 764
 765         PR symtab/24423:
 766         * source.c (print_source_lines_base): Advance "iter" when a
 767         control character is seen.
 768
 769 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 770
 771         * inferior.h (struct infcall_suspend_state_deleter):
 772         Catch exception in destructor to avoid crash.
 773
 774 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 775
 776         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
 777         close to the add_com "shell".
 778
 779 2019-04-18  Tom Tromey  <tromey@adacore.com>
 780
 781         * process-stratum-target.h (class process_stratum_target)
 782         <stratum>: Add "final".
 783
 784 2019-04-17  Tom Tromey  <tromey@adacore.com>
 785
 786         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
 787         against nullptr before use.
 788
 789 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
 790
 791         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
 792
 793 2019-04-17  Jim Wilson  <jimw@sifive.com>
 794             Andrew Burgess  <andrew.burgess@embecosm.com>
 795
 796         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
 797         code read might fail, assume 4-byte breakpoint in that case.
 798
 799 2019-04-15  Leszek Swirski  <leszeks@google.com>
 800
 801         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
 802         rather than a hand-rolled POD check when checking for forced MEMORY
 803         classification.
 804
 805 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 806
 807         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
 808         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
 809         function.
 810         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
 811         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
 812         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
 813         declaration.
 814
 815 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 816
 817         * aarch64-linux-nat.c
 818         (aarch64_linux_nat_target::thread_architecture): Add override.
 819         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
 820         each VQ.
 821
 822 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 823
 824         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
 825
 826 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
 827
 828         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
 829         target types of size 96-bits, add some additional comments, and
 830         check that the builtin type we found was the correct size.
 831
 832 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
 833
 834         * utils.c (prompt_for_continue): Don't restore the styling at the
 835         end, as applied_style has the wrong value.  This fixes styling in
 836         long lists of file names that are interrupted by the "Continue?"
 837         prompt.
 838
 839 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 840
 841         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
 842         * c-lang.c (c_language_defn): Likewise.
 843         (cplus_language_defn): Likewise.
 844         (asm_language_defn): Likewise.
 845         (minimal_language_defn): Likewise.
 846         * d-lang.c (d_language_defn): Likewise.
 847         * f-lang.c (f_language_defn): Likewise.
 848         * go-lang.c (go_language_defn): Likewise.
 849         * language.c (unknown_language_defn): Likewise.
 850         (auto_language_defn): Likewise.
 851         * language.h (struct language_defn): Remove la_magic field.
 852         (LANG_MAGIC): Delete.
 853         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
 854         * objc-lang.c (objc_language_defn): Likewise.
 855         * opencl-lang.c (opencl_language_defn): Likewise.
 856         * p-lang.c (pascal_language_defn): Likewise.
 857         * rust-lang.c (rust_language_defn): Likewise.
 858
 859 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 860
 861         * riscv-tdep.c (riscv_type_align): New function.
 862         (riscv_type_alignment): Delete.
 863         (riscv_arg_location): Use 'type_align'.
 864         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
 865
 866 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 867
 868         * gdbtypes.c (type_align): A struct with no non-static fields also
 869         has alignment of 1.
 870
 871 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 872
 873         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
 874         component to 0.
 875         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
 876         member.
 877         (riscv_struct_info::analyse): New implementation using new
 878         analyse_inner member function.
 879         (riscv_struct_info::field_offset): New member function.
 880         (riscv_struct_info::m_offsets): New member variable.
 881         (riscv_struct_info::analyse_inner): New private member function,
 882         takes the old implementation of riscv_struct_info::analyse but
 883         extended to track field offsets.
 884         (riscv_call_arg_struct): Update the struct folding special cases
 885         to handle cases where empty C++ structs, which are non-zero
 886         length, are found.
 887         (riscv_arg_location): Initialise the length of each location, a
 888         non-zero length now indicates the location is in use.
 889         (riscv_push_dummy_call): Allow for the first location having a
 890         non-zero offset when setting up arguments.
 891         (riscv_return_value): Likewise, but for return values.
 892
 893 2019-04-11  Tom Tromey  <tromey@adacore.com>
 894
 895         * utils.c (internal_vproblem): Make "msg" const.
 896
 897 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
 898
 899         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
 900         * trad-frame.c (trad_frame_reset_saved_regs): New function.
 901         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
 902         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
 903
 904 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
 905
 906         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
 907         function.
 908         (fill_gregset): Call amd64_linux_collect_native_gregset instead
 909         of amd64_collect_native_gregset.
 910         (amd64_linux_nat_target::store_registers): Likewise.
 911
 912 2019-04-10  Tom Tromey  <tom@tromey.com>
 913
 914         * symtab.c (lookup_global_symbol_from_objfile)
 915         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
 916         * objfiles.h (class separate_debug_iterator): New.
 917         (class separate_debug_range): New.
 918         (struct objfile) <separate_debug_objfiles>: New method.
 919         (objfile_separate_debug_iterate): Don't declare.
 920         * objfiles.c (separate_debug_iterator::operator++): Rename from
 921         objfile_separate_debug_iterate.
 922         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
 923         iterator.
 924         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
 925         iterator.
 926
 927 2019-04-10  Tom Tromey  <tom@tromey.com>
 928
 929         * symfile.c (reread_symbols): Remove old comment.
 930         * objfiles.c (free_all_objfiles): Fix a typo.
 931
 932 2019-04-10  Tom Tromey  <tom@tromey.com>
 933
 934         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
 935         * minsyms.c (lookup_minimal_symbol): Use foreach.
 936         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
 937         (lookup_minimal_symbol_solib_trampoline): Likewise.
 938         * symfile.c (reread_symbols): Use foreach.
 939
 940 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
 941             Tom Tromey  <tromey@adacore.com>
 942
 943         PR rust/24414:
 944         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
 945         (rust_lex_int_test): Change "value" to be LONGEST.
 946         (rust_lex_tests): Add test for long integer literal.
 947
 948 2019-04-09  Tom Tromey  <tromey@adacore.com>
 949
 950         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
 951         to bool.
 952         (extended_remote_target::attach): Update.
 953         (remote_target::remote_notice_new_inferior): Update.
 954         (remote_target::add_current_inferior_and_thread): Update.
 955         * inferior.c (exit_inferior_1): Use "false".
 956         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
 957
 958 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
 959
 960         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
 961         the "start" command.
 962
 963 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 964
 965         * python/py-inferior.c (infpy_thread_from_thread_handle):
 966         Adjust comments to reflect renaming of thread_from_thread_handle
 967         to thread_from_handle.  Adjust keywords.  Fix type error message.
 968         (inferior_object_methods): Add thread_from_handle.  Retain
 969         thread_from_thread_handle, but mark it as deprecated.
 970
 971 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 972
 973         * gdbthread.h (find_thread_by_handle): Revise declaration.
 974         * thread.c (find_thread_by_handle): Likewise.  Adjust
 975         implementation too.
 976         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
 977         support for buffer objects as handles.
 978
 979 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 980
 981         * python/py-infthread.c (thpy_thread_handle): New function.
 982         (thread_object_methods): Register thpy_thread_handle.
 983
 984 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 985
 986         * gdbthread.h (thread_to_thread_handle): Declare.
 987         * thread.c (gdbtypes.h): Include.
 988         (thread_to_thread_handle): New function.
 989
 990         * target.h (struct target_ops): Add thread_info_to_thread_handle.
 991         (target_thread_info_to_thread_handle): Declare.
 992         * target.c (target_thread_info_to_thread_handle): New function.
 993         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
 994         * target-delegates.c: Regenerate.
 995
 996         * linux-thread-db.c (class thread_db_target): Add method
 997         thread_info_to_thread_handle.
 998         (thread_db_target::thread_info_to_thread_handle): Define.
 999         * remote.c (class remote_target): Add new method
1000         thread_info_to_thread_handle.
1001         (remote_target::thread_info_to_thread_handle): Define.
1002
1003 2019-04-08  Pedro Alves  <palves@redhat.com>
1004
1005         * common/common-exceptions.c (throw_exception): Don't create
1006         named object to throw; throw directly.
1007         (throw_it): Likewise.  Don't initialize gdb_exception::message
1008         here, with new; pass FMT and AP to the ctor instead.
1009         * common/common-exceptions.h: Include <string>.
1010         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1011         const char *, va_list)): New ctor.  Use std::make_shared.
1012         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1013         errors)): Delete.
1014         (gdb_exception_error::gdb_exception_error(enum errors, const char
1015         *, va_list)): New.
1016         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1017         Add assertion.
1018         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1019         errors)): Delete.
1020         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1021         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1022         Add assertion.
1023
1024 2019-04-08  Tom Tromey  <tom@tromey.com>
1025
1026         * valops.c (value_rtti_indirect_type): Replace throw_exception
1027         with throw.
1028         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1029         with throw.
1030         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1031         throw.
1032         * target.c (target_translate_tls_address): Replace throw_exception
1033         with throw.
1034         * stack.c (frame_apply_command_count): Replace throw_exception
1035         with throw.
1036         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1037         throw.
1038         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1039         with throw.
1040         * rs6000-tdep.c (rs6000_frame_cache)
1041         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1042         * remote.c: Replace throw_exception with throw.
1043         * record-full.c (record_full_message, record_full_wait_1)
1044         (record_full_restore): Replace throw_exception with throw.
1045         * record-btrace.c:
1046         (get_thread_current_frame_id, record_btrace_start_replaying)
1047         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1048         (cmd_record_btrace_start): Replace throw_exception with throw.
1049         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1050         throw.
1051         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1052         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1053         * linespec.c:
1054         (find_linespec_symbols): Replace throw_exception with throw.
1055         * infrun.c (displaced_step_prepare, resume): Replace
1056         throw_exception with throw.
1057         * infcmd.c (post_create_inferior): Replace throw_exception with
1058         throw.
1059         * inf-loop.c (inferior_event_handler): Replace throw_exception
1060         with throw.
1061         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1062         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1063         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1064         (get_prev_frame_always, get_frame_pc_if_available)
1065         (get_frame_address_in_block_if_available, get_frame_language):
1066         Replace throw_exception with throw.
1067         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1068         throw_exception with throw.
1069         * eval.c (fetch_subexp_value, evaluate_var_value)
1070         (evaluate_funcall, evaluate_subexp_standard): Replace
1071         throw_exception with throw.
1072         * dwarf2loc.c (call_site_find_chain)
1073         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1074         Replace throw_exception with throw.
1075         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1076         with throw.
1077         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1078         throw.
1079         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1080         * completer.c (complete_line_internal): Replace throw_exception
1081         with throw.
1082         * compile/compile-object-run.c (compile_object_run): Replace
1083         throw_exception with throw.
1084         * cli/cli-script.c (process_next_line): Replace throw_exception
1085         with throw.
1086         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1087         (btrace_enable, btrace_maint_update_pt_packets): Replace
1088         throw_exception with throw.
1089         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1090         throw_exception with throw.
1091         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1092         throw_exception with throw.
1093         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1094         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1095         * aarch64-tdep.c (aarch64_make_prologue_cache)
1096         (aarch64_make_stub_cache): Replace throw_exception with throw.
1097
1098 2019-04-08  Tom Tromey  <tom@tromey.com>
1099
1100         * common/common-exceptions.c (throw_exception): Rename from
1101         throw_exception_cxx.  Remove old copy.  Make argument const.
1102         (throw_it): Create and throw exception objects directly.
1103         * common/common-exceptions.h (throw_exception): Make argument
1104         const.
1105         (struct gdb_exception_error): Add constructor.
1106         (struct gdb_exception_quit): Add constructor.
1107
1108 2019-04-08  Tom Tromey  <tom@tromey.com>
1109
1110         * common/common-exceptions.h (exception_rethrow): Don't declare.
1111         (TRY_SJLJ): Update comment.
1112         (TRY, CATCH, END_CATCH): Remove.
1113         * common/common-exceptions.c (exception_rethrow): Remove.
1114
1115 2019-04-08  Tom Tromey  <tom@tromey.com>
1116
1117         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1118         Remove.
1119         (gdb_exception_error): Rename from
1120         gdb_exception_RETURN_MASK_ERROR.
1121         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1122         (gdb_quit_bad_alloc): Update.
1123         * aarch64-tdep.c: Update.
1124         * ada-lang.c: Update.
1125         * ada-typeprint.c: Update.
1126         * ada-valprint.c: Update.
1127         * amd64-tdep.c: Update.
1128         * arch-utils.c: Update.
1129         * break-catch-throw.c: Update.
1130         * breakpoint.c: Update.
1131         * btrace.c: Update.
1132         * c-varobj.c: Update.
1133         * cli/cli-cmds.c: Update.
1134         * cli/cli-interp.c: Update.
1135         * cli/cli-script.c: Update.
1136         * common/common-exceptions.c: Update.
1137         * common/new-op.c: Update.
1138         * common/selftest.c: Update.
1139         * compile/compile-c-symbols.c: Update.
1140         * compile/compile-cplus-symbols.c: Update.
1141         * compile/compile-object-load.c: Update.
1142         * compile/compile-object-run.c: Update.
1143         * completer.c: Update.
1144         * corelow.c: Update.
1145         * cp-abi.c: Update.
1146         * cp-support.c: Update.
1147         * cp-valprint.c: Update.
1148         * darwin-nat.c: Update.
1149         * disasm-selftests.c: Update.
1150         * dtrace-probe.c: Update.
1151         * dwarf-index-cache.c: Update.
1152         * dwarf-index-write.c: Update.
1153         * dwarf2-frame-tailcall.c: Update.
1154         * dwarf2-frame.c: Update.
1155         * dwarf2loc.c: Update.
1156         * dwarf2read.c: Update.
1157         * eval.c: Update.
1158         * event-loop.c: Update.
1159         * event-top.c: Update.
1160         * exec.c: Update.
1161         * f-valprint.c: Update.
1162         * fbsd-tdep.c: Update.
1163         * frame-unwind.c: Update.
1164         * frame.c: Update.
1165         * gdbtypes.c: Update.
1166         * gnu-v3-abi.c: Update.
1167         * guile/guile-internal.h: Update.
1168         * guile/scm-block.c: Update.
1169         * guile/scm-breakpoint.c: Update.
1170         * guile/scm-cmd.c: Update.
1171         * guile/scm-disasm.c: Update.
1172         * guile/scm-frame.c: Update.
1173         * guile/scm-lazy-string.c: Update.
1174         * guile/scm-math.c: Update.
1175         * guile/scm-param.c: Update.
1176         * guile/scm-ports.c: Update.
1177         * guile/scm-pretty-print.c: Update.
1178         * guile/scm-symbol.c: Update.
1179         * guile/scm-symtab.c: Update.
1180         * guile/scm-type.c: Update.
1181         * guile/scm-value.c: Update.
1182         * i386-linux-tdep.c: Update.
1183         * i386-tdep.c: Update.
1184         * inf-loop.c: Update.
1185         * infcall.c: Update.
1186         * infcmd.c: Update.
1187         * infrun.c: Update.
1188         * jit.c: Update.
1189         * language.c: Update.
1190         * linespec.c: Update.
1191         * linux-fork.c: Update.
1192         * linux-nat.c: Update.
1193         * linux-tdep.c: Update.
1194         * linux-thread-db.c: Update.
1195         * main.c: Update.
1196         * mi/mi-cmd-break.c: Update.
1197         * mi/mi-cmd-stack.c: Update.
1198         * mi/mi-interp.c: Update.
1199         * mi/mi-main.c: Update.
1200         * objc-lang.c: Update.
1201         * p-valprint.c: Update.
1202         * parse.c: Update.
1203         * ppc-linux-tdep.c: Update.
1204         * printcmd.c: Update.
1205         * python/py-arch.c: Update.
1206         * python/py-breakpoint.c: Update.
1207         * python/py-cmd.c: Update.
1208         * python/py-finishbreakpoint.c: Update.
1209         * python/py-frame.c: Update.
1210         * python/py-framefilter.c: Update.
1211         * python/py-gdb-readline.c: Update.
1212         * python/py-inferior.c: Update.
1213         * python/py-infthread.c: Update.
1214         * python/py-lazy-string.c: Update.
1215         * python/py-linetable.c: Update.
1216         * python/py-objfile.c: Update.
1217         * python/py-param.c: Update.
1218         * python/py-prettyprint.c: Update.
1219         * python/py-progspace.c: Update.
1220         * python/py-record-btrace.c: Update.
1221         * python/py-record.c: Update.
1222         * python/py-symbol.c: Update.
1223         * python/py-type.c: Update.
1224         * python/py-unwind.c: Update.
1225         * python/py-utils.c: Update.
1226         * python/py-value.c: Update.
1227         * python/python.c: Update.
1228         * record-btrace.c: Update.
1229         * record-full.c: Update.
1230         * remote-fileio.c: Update.
1231         * remote.c: Update.
1232         * riscv-tdep.c: Update.
1233         * rs6000-aix-tdep.c: Update.
1234         * rs6000-tdep.c: Update.
1235         * rust-exp.y: Update.
1236         * rust-lang.c: Update.
1237         * s390-tdep.c: Update.
1238         * selftest-arch.c: Update.
1239         * solib-dsbt.c: Update.
1240         * solib-frv.c: Update.
1241         * solib-spu.c: Update.
1242         * solib-svr4.c: Update.
1243         * solib.c: Update.
1244         * sparc64-linux-tdep.c: Update.
1245         * stack.c: Update.
1246         * symfile-mem.c: Update.
1247         * symmisc.c: Update.
1248         * target.c: Update.
1249         * thread.c: Update.
1250         * top.c: Update.
1251         * tracefile-tfile.c: Update.
1252         * tui/tui.c: Update.
1253         * typeprint.c: Update.
1254         * unittests/cli-utils-selftests.c: Update.
1255         * unittests/parse-connection-spec-selftests.c: Update.
1256         * valops.c: Update.
1257         * valprint.c: Update.
1258         * value.c: Update.
1259         * varobj.c: Update.
1260         * windows-nat.c: Update.
1261         * x86-linux-nat.c: Update.
1262         * xml-support.c: Update.
1263
1264 2019-04-08  Tom Tromey  <tom@tromey.com>
1265
1266         * xml-support.c: Use C++ exception handling.
1267         * x86-linux-nat.c: Use C++ exception handling.
1268         * windows-nat.c: Use C++ exception handling.
1269         * varobj.c: Use C++ exception handling.
1270         * value.c: Use C++ exception handling.
1271         * valprint.c: Use C++ exception handling.
1272         * valops.c: Use C++ exception handling.
1273         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1274         handling.
1275         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1276         * typeprint.c: Use C++ exception handling.
1277         * tui/tui.c: Use C++ exception handling.
1278         * tracefile-tfile.c: Use C++ exception handling.
1279         * top.c: Use C++ exception handling.
1280         * thread.c: Use C++ exception handling.
1281         * target.c: Use C++ exception handling.
1282         * symmisc.c: Use C++ exception handling.
1283         * symfile-mem.c: Use C++ exception handling.
1284         * stack.c: Use C++ exception handling.
1285         * sparc64-linux-tdep.c: Use C++ exception handling.
1286         * solib.c: Use C++ exception handling.
1287         * solib-svr4.c: Use C++ exception handling.
1288         * solib-spu.c: Use C++ exception handling.
1289         * solib-frv.c: Use C++ exception handling.
1290         * solib-dsbt.c: Use C++ exception handling.
1291         * selftest-arch.c: Use C++ exception handling.
1292         * s390-tdep.c: Use C++ exception handling.
1293         * rust-lang.c: Use C++ exception handling.
1294         * rust-exp.y: Use C++ exception handling.
1295         * rs6000-tdep.c: Use C++ exception handling.
1296         * rs6000-aix-tdep.c: Use C++ exception handling.
1297         * riscv-tdep.c: Use C++ exception handling.
1298         * remote.c: Use C++ exception handling.
1299         * remote-fileio.c: Use C++ exception handling.
1300         * record-full.c: Use C++ exception handling.
1301         * record-btrace.c: Use C++ exception handling.
1302         * python/python.c: Use C++ exception handling.
1303         * python/py-value.c: Use C++ exception handling.
1304         * python/py-utils.c: Use C++ exception handling.
1305         * python/py-unwind.c: Use C++ exception handling.
1306         * python/py-type.c: Use C++ exception handling.
1307         * python/py-symbol.c: Use C++ exception handling.
1308         * python/py-record.c: Use C++ exception handling.
1309         * python/py-record-btrace.c: Use C++ exception handling.
1310         * python/py-progspace.c: Use C++ exception handling.
1311         * python/py-prettyprint.c: Use C++ exception handling.
1312         * python/py-param.c: Use C++ exception handling.
1313         * python/py-objfile.c: Use C++ exception handling.
1314         * python/py-linetable.c: Use C++ exception handling.
1315         * python/py-lazy-string.c: Use C++ exception handling.
1316         * python/py-infthread.c: Use C++ exception handling.
1317         * python/py-inferior.c: Use C++ exception handling.
1318         * python/py-gdb-readline.c: Use C++ exception handling.
1319         * python/py-framefilter.c: Use C++ exception handling.
1320         * python/py-frame.c: Use C++ exception handling.
1321         * python/py-finishbreakpoint.c: Use C++ exception handling.
1322         * python/py-cmd.c: Use C++ exception handling.
1323         * python/py-breakpoint.c: Use C++ exception handling.
1324         * python/py-arch.c: Use C++ exception handling.
1325         * printcmd.c: Use C++ exception handling.
1326         * ppc-linux-tdep.c: Use C++ exception handling.
1327         * parse.c: Use C++ exception handling.
1328         * p-valprint.c: Use C++ exception handling.
1329         * objc-lang.c: Use C++ exception handling.
1330         * mi/mi-main.c: Use C++ exception handling.
1331         * mi/mi-interp.c: Use C++ exception handling.
1332         * mi/mi-cmd-stack.c: Use C++ exception handling.
1333         * mi/mi-cmd-break.c: Use C++ exception handling.
1334         * main.c: Use C++ exception handling.
1335         * linux-thread-db.c: Use C++ exception handling.
1336         * linux-tdep.c: Use C++ exception handling.
1337         * linux-nat.c: Use C++ exception handling.
1338         * linux-fork.c: Use C++ exception handling.
1339         * linespec.c: Use C++ exception handling.
1340         * language.c: Use C++ exception handling.
1341         * jit.c: Use C++ exception handling.
1342         * infrun.c: Use C++ exception handling.
1343         * infcmd.c: Use C++ exception handling.
1344         * infcall.c: Use C++ exception handling.
1345         * inf-loop.c: Use C++ exception handling.
1346         * i386-tdep.c: Use C++ exception handling.
1347         * i386-linux-tdep.c: Use C++ exception handling.
1348         * guile/scm-value.c: Use C++ exception handling.
1349         * guile/scm-type.c: Use C++ exception handling.
1350         * guile/scm-symtab.c: Use C++ exception handling.
1351         * guile/scm-symbol.c: Use C++ exception handling.
1352         * guile/scm-pretty-print.c: Use C++ exception handling.
1353         * guile/scm-ports.c: Use C++ exception handling.
1354         * guile/scm-param.c: Use C++ exception handling.
1355         * guile/scm-math.c: Use C++ exception handling.
1356         * guile/scm-lazy-string.c: Use C++ exception handling.
1357         * guile/scm-frame.c: Use C++ exception handling.
1358         * guile/scm-disasm.c: Use C++ exception handling.
1359         * guile/scm-cmd.c: Use C++ exception handling.
1360         * guile/scm-breakpoint.c: Use C++ exception handling.
1361         * guile/scm-block.c: Use C++ exception handling.
1362         * guile/guile-internal.h: Use C++ exception handling.
1363         * gnu-v3-abi.c: Use C++ exception handling.
1364         * gdbtypes.c: Use C++ exception handling.
1365         * frame.c: Use C++ exception handling.
1366         * frame-unwind.c: Use C++ exception handling.
1367         * fbsd-tdep.c: Use C++ exception handling.
1368         * f-valprint.c: Use C++ exception handling.
1369         * exec.c: Use C++ exception handling.
1370         * event-top.c: Use C++ exception handling.
1371         * event-loop.c: Use C++ exception handling.
1372         * eval.c: Use C++ exception handling.
1373         * dwarf2read.c: Use C++ exception handling.
1374         * dwarf2loc.c: Use C++ exception handling.
1375         * dwarf2-frame.c: Use C++ exception handling.
1376         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1377         * dwarf-index-write.c: Use C++ exception handling.
1378         * dwarf-index-cache.c: Use C++ exception handling.
1379         * dtrace-probe.c: Use C++ exception handling.
1380         * disasm-selftests.c: Use C++ exception handling.
1381         * darwin-nat.c: Use C++ exception handling.
1382         * cp-valprint.c: Use C++ exception handling.
1383         * cp-support.c: Use C++ exception handling.
1384         * cp-abi.c: Use C++ exception handling.
1385         * corelow.c: Use C++ exception handling.
1386         * completer.c: Use C++ exception handling.
1387         * compile/compile-object-run.c: Use C++ exception handling.
1388         * compile/compile-object-load.c: Use C++ exception handling.
1389         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1390         * compile/compile-c-symbols.c: Use C++ exception handling.
1391         * common/selftest.c: Use C++ exception handling.
1392         * common/new-op.c: Use C++ exception handling.
1393         * cli/cli-script.c: Use C++ exception handling.
1394         * cli/cli-interp.c: Use C++ exception handling.
1395         * cli/cli-cmds.c: Use C++ exception handling.
1396         * c-varobj.c: Use C++ exception handling.
1397         * btrace.c: Use C++ exception handling.
1398         * breakpoint.c: Use C++ exception handling.
1399         * break-catch-throw.c: Use C++ exception handling.
1400         * arch-utils.c: Use C++ exception handling.
1401         * amd64-tdep.c: Use C++ exception handling.
1402         * ada-valprint.c: Use C++ exception handling.
1403         * ada-typeprint.c: Use C++ exception handling.
1404         * ada-lang.c: Use C++ exception handling.
1405         * aarch64-tdep.c: Use C++ exception handling.
1406
1407 2019-04-08  Tom Tromey  <tom@tromey.com>
1408
1409         * xml-support.c (gdb_xml_parser::parse): Update.
1410         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1411         * value.c (show_convenience): Update.
1412         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1413         (test_parse_flags_qcs): Update.
1414         * thread.c (thr_try_catch_cmd): Update.
1415         * target.c (target_translate_tls_address): Update.
1416         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1417         (info_frame_command_core, frame_apply_command_count): Update.
1418         * rust-exp.y (rust_lex_exception_test): Update.
1419         * riscv-tdep.c (riscv_print_one_register_info): Update.
1420         * remote.c (remote_target::enable_btrace): Update.
1421         * record-btrace.c (record_btrace_enable_warn): Update.
1422         * python/py-utils.c (gdbpy_convert_exception): Update.
1423         * printcmd.c (do_one_display, print_variable_and_value): Update.
1424         * mi/mi-main.c (mi_print_exception): Update.
1425         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1426         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1427         * linux-nat.c (linux_nat_target::attach): Update.
1428         * linux-fork.c (class scoped_switch_fork_info): Update.
1429         * infrun.c (displaced_step_prepare): Update.
1430         * infcall.c (call_function_by_hand_dummy): Update.
1431         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1432         * gnu-v3-abi.c (print_one_vtable): Update.
1433         * frame.c (get_prev_frame_always): Update.
1434         * f-valprint.c (info_common_command_for_block): Update.
1435         * exec.c (try_open_exec_file): Update.
1436         * exceptions.c (print_exception, exception_print)
1437         (exception_fprintf, exception_print_same): Update.
1438         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
1439         * dwarf-index-cache.c (index_cache::store)
1440         (index_cache::lookup_gdb_index): Update.
1441         * darwin-nat.c (maybe_cache_shell): Update.
1442         * cp-valprint.c (cp_print_value_fields): Update.
1443         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
1444         (gcc_cplus_symbol_address): Update.
1445         * compile/compile-c-symbols.c (gcc_convert_symbol)
1446         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
1447         * common/selftest.c: Update.
1448         * common/common-exceptions.h (struct gdb_exception) <message>: Now
1449         a std::string.
1450         (exception_try_scope_entry, exception_try_scope_exit): Don't
1451         declare.
1452         (struct exception_try_scope): Remove.
1453         (TRY): Don't use exception_try_scope.
1454         (struct gdb_exception): Add constructor, operator=.
1455         <what>: New method.
1456         (struct gdb_exception_RETURN_MASK_ALL)
1457         (struct gdb_exception_RETURN_MASK_ERROR)
1458         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
1459         (struct gdb_quit_bad_alloc): Update.
1460         * common/common-exceptions.c (exception_none): Change
1461         initializer.
1462         (struct catcher) <state, exception>: Initialize inline.
1463         <prev>: Remove member.
1464         (current_catcher): Remove.
1465         (catchers): New global.
1466         (exceptions_state_mc_init): Simplify.
1467         (catcher_pop): Remove.
1468         (exceptions_state_mc, exceptions_state_mc_catch): Update.
1469         (try_scope_depth, exception_try_scope_entry)
1470         (exception_try_scope_exit): Remove.
1471         (throw_exception_sjlj): Update.
1472         (exception_messages, exception_messages_size): Remove.
1473         (throw_it): Simplify.
1474         (gdb_exception_sliced_copy): Remove.
1475         (throw_exception_cxx): Update.
1476         * cli/cli-script.c (script_from_file): Update.
1477         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
1478         Update.
1479         * ada-valprint.c (ada_val_print): Update.
1480         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
1481         (create_excep_cond_exprs): Update.
1482
1483 2019-04-08  Tom Tromey  <tom@tromey.com>
1484
1485         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
1486         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
1487         (TRY, CATCH, END_CATCH): Remove some definitions.
1488         * common/common-exceptions.c: Don't use GDB_XCPT.
1489         (catcher_list_size): Remove.
1490         (throw_exception, throw_it): Simplify.
1491
1492 2019-04-05  Tom Tromey  <tom@tromey.com>
1493
1494         Revert the header-sorting patch.
1495         * ft32-tdep.c: Revert.
1496         * frv-tdep.c: Revert.
1497         * frv-linux-tdep.c: Revert.
1498         * frame.c: Revert.
1499         * frame-unwind.c: Revert.
1500         * frame-base.c: Revert.
1501         * fork-child.c: Revert.
1502         * findvar.c: Revert.
1503         * findcmd.c: Revert.
1504         * filesystem.c: Revert.
1505         * filename-seen-cache.h: Revert.
1506         * filename-seen-cache.c: Revert.
1507         * fbsd-tdep.c: Revert.
1508         * fbsd-nat.h: Revert.
1509         * fbsd-nat.c: Revert.
1510         * f-valprint.c: Revert.
1511         * f-typeprint.c: Revert.
1512         * f-lang.c: Revert.
1513         * extension.h: Revert.
1514         * extension.c: Revert.
1515         * extension-priv.h: Revert.
1516         * expprint.c: Revert.
1517         * exec.h: Revert.
1518         * exec.c: Revert.
1519         * exceptions.c: Revert.
1520         * event-top.c: Revert.
1521         * event-loop.c: Revert.
1522         * eval.c: Revert.
1523         * elfread.c: Revert.
1524         * dwarf2read.h: Revert.
1525         * dwarf2read.c: Revert.
1526         * dwarf2loc.c: Revert.
1527         * dwarf2expr.h: Revert.
1528         * dwarf2expr.c: Revert.
1529         * dwarf2-frame.c: Revert.
1530         * dwarf2-frame-tailcall.c: Revert.
1531         * dwarf-index-write.h: Revert.
1532         * dwarf-index-write.c: Revert.
1533         * dwarf-index-common.c: Revert.
1534         * dwarf-index-cache.h: Revert.
1535         * dwarf-index-cache.c: Revert.
1536         * dummy-frame.c: Revert.
1537         * dtrace-probe.c: Revert.
1538         * disasm.h: Revert.
1539         * disasm.c: Revert.
1540         * disasm-selftests.c: Revert.
1541         * dictionary.c: Revert.
1542         * dicos-tdep.c: Revert.
1543         * demangle.c: Revert.
1544         * dcache.h: Revert.
1545         * dcache.c: Revert.
1546         * darwin-nat.h: Revert.
1547         * darwin-nat.c: Revert.
1548         * darwin-nat-info.c: Revert.
1549         * d-valprint.c: Revert.
1550         * d-namespace.c: Revert.
1551         * d-lang.c: Revert.
1552         * ctf.c: Revert.
1553         * csky-tdep.c: Revert.
1554         * csky-linux-tdep.c: Revert.
1555         * cris-tdep.c: Revert.
1556         * cris-linux-tdep.c: Revert.
1557         * cp-valprint.c: Revert.
1558         * cp-support.c: Revert.
1559         * cp-namespace.c: Revert.
1560         * cp-abi.c: Revert.
1561         * corelow.c: Revert.
1562         * corefile.c: Revert.
1563         * continuations.c: Revert.
1564         * completer.h: Revert.
1565         * completer.c: Revert.
1566         * complaints.c: Revert.
1567         * coffread.c: Revert.
1568         * coff-pe-read.c: Revert.
1569         * cli-out.h: Revert.
1570         * cli-out.c: Revert.
1571         * charset.c: Revert.
1572         * c-varobj.c: Revert.
1573         * c-valprint.c: Revert.
1574         * c-typeprint.c: Revert.
1575         * c-lang.c: Revert.
1576         * buildsym.c: Revert.
1577         * buildsym-legacy.c: Revert.
1578         * build-id.h: Revert.
1579         * build-id.c: Revert.
1580         * btrace.c: Revert.
1581         * bsd-uthread.c: Revert.
1582         * breakpoint.h: Revert.
1583         * breakpoint.c: Revert.
1584         * break-catch-throw.c: Revert.
1585         * break-catch-syscall.c: Revert.
1586         * break-catch-sig.c: Revert.
1587         * blockframe.c: Revert.
1588         * block.c: Revert.
1589         * bfin-tdep.c: Revert.
1590         * bfin-linux-tdep.c: Revert.
1591         * bfd-target.c: Revert.
1592         * bcache.c: Revert.
1593         * ax-general.c: Revert.
1594         * ax-gdb.h: Revert.
1595         * ax-gdb.c: Revert.
1596         * avr-tdep.c: Revert.
1597         * auxv.c: Revert.
1598         * auto-load.c: Revert.
1599         * arm-wince-tdep.c: Revert.
1600         * arm-tdep.c: Revert.
1601         * arm-symbian-tdep.c: Revert.
1602         * arm-pikeos-tdep.c: Revert.
1603         * arm-obsd-tdep.c: Revert.
1604         * arm-nbsd-tdep.c: Revert.
1605         * arm-nbsd-nat.c: Revert.
1606         * arm-linux-tdep.c: Revert.
1607         * arm-linux-nat.c: Revert.
1608         * arm-fbsd-tdep.c: Revert.
1609         * arm-fbsd-nat.c: Revert.
1610         * arm-bsd-tdep.c: Revert.
1611         * arch-utils.c: Revert.
1612         * arc-tdep.c: Revert.
1613         * arc-newlib-tdep.c: Revert.
1614         * annotate.h: Revert.
1615         * annotate.c: Revert.
1616         * amd64-windows-tdep.c: Revert.
1617         * amd64-windows-nat.c: Revert.
1618         * amd64-tdep.c: Revert.
1619         * amd64-sol2-tdep.c: Revert.
1620         * amd64-obsd-tdep.c: Revert.
1621         * amd64-obsd-nat.c: Revert.
1622         * amd64-nbsd-tdep.c: Revert.
1623         * amd64-nbsd-nat.c: Revert.
1624         * amd64-nat.c: Revert.
1625         * amd64-linux-tdep.c: Revert.
1626         * amd64-linux-nat.c: Revert.
1627         * amd64-fbsd-tdep.c: Revert.
1628         * amd64-fbsd-nat.c: Revert.
1629         * amd64-dicos-tdep.c: Revert.
1630         * amd64-darwin-tdep.c: Revert.
1631         * amd64-bsd-nat.c: Revert.
1632         * alpha-tdep.c: Revert.
1633         * alpha-obsd-tdep.c: Revert.
1634         * alpha-nbsd-tdep.c: Revert.
1635         * alpha-mdebug-tdep.c: Revert.
1636         * alpha-linux-tdep.c: Revert.
1637         * alpha-linux-nat.c: Revert.
1638         * alpha-bsd-tdep.c: Revert.
1639         * alpha-bsd-nat.c: Revert.
1640         * aix-thread.c: Revert.
1641         * agent.c: Revert.
1642         * addrmap.c: Revert.
1643         * ada-varobj.c: Revert.
1644         * ada-valprint.c: Revert.
1645         * ada-typeprint.c: Revert.
1646         * ada-tasks.c: Revert.
1647         * ada-lang.c: Revert.
1648         * aarch64-tdep.c: Revert.
1649         * aarch64-ravenscar-thread.c: Revert.
1650         * aarch64-newlib-tdep.c: Revert.
1651         * aarch64-linux-tdep.c: Revert.
1652         * aarch64-linux-nat.c: Revert.
1653         * aarch64-fbsd-tdep.c: Revert.
1654         * aarch64-fbsd-nat.c: Revert.
1655         * aarch32-linux-nat.c: Revert.
1656
1657 2019-04-05  Tom Tromey  <tom@tromey.com>
1658
1659         * ft32-tdep.c: Sort headers.
1660         * frv-tdep.c: Sort headers.
1661         * frv-linux-tdep.c: Sort headers.
1662         * frame.c: Sort headers.
1663         * frame-unwind.c: Sort headers.
1664         * frame-base.c: Sort headers.
1665         * fork-child.c: Sort headers.
1666         * findvar.c: Sort headers.
1667         * findcmd.c: Sort headers.
1668         * filesystem.c: Sort headers.
1669         * filename-seen-cache.h: Sort headers.
1670         * filename-seen-cache.c: Sort headers.
1671         * fbsd-tdep.c: Sort headers.
1672         * fbsd-nat.h: Sort headers.
1673         * fbsd-nat.c: Sort headers.
1674         * f-valprint.c: Sort headers.
1675         * f-typeprint.c: Sort headers.
1676         * f-lang.c: Sort headers.
1677         * extension.h: Sort headers.
1678         * extension.c: Sort headers.
1679         * extension-priv.h: Sort headers.
1680         * expprint.c: Sort headers.
1681         * exec.h: Sort headers.
1682         * exec.c: Sort headers.
1683         * exceptions.c: Sort headers.
1684         * event-top.c: Sort headers.
1685         * event-loop.c: Sort headers.
1686         * eval.c: Sort headers.
1687         * elfread.c: Sort headers.
1688         * dwarf2read.h: Sort headers.
1689         * dwarf2read.c: Sort headers.
1690         * dwarf2loc.c: Sort headers.
1691         * dwarf2expr.h: Sort headers.
1692         * dwarf2expr.c: Sort headers.
1693         * dwarf2-frame.c: Sort headers.
1694         * dwarf2-frame-tailcall.c: Sort headers.
1695         * dwarf-index-write.h: Sort headers.
1696         * dwarf-index-write.c: Sort headers.
1697         * dwarf-index-common.c: Sort headers.
1698         * dwarf-index-cache.h: Sort headers.
1699         * dwarf-index-cache.c: Sort headers.
1700         * dummy-frame.c: Sort headers.
1701         * dtrace-probe.c: Sort headers.
1702         * disasm.h: Sort headers.
1703         * disasm.c: Sort headers.
1704         * disasm-selftests.c: Sort headers.
1705         * dictionary.c: Sort headers.
1706         * dicos-tdep.c: Sort headers.
1707         * demangle.c: Sort headers.
1708         * dcache.h: Sort headers.
1709         * dcache.c: Sort headers.
1710         * darwin-nat.h: Sort headers.
1711         * darwin-nat.c: Sort headers.
1712         * darwin-nat-info.c: Sort headers.
1713         * d-valprint.c: Sort headers.
1714         * d-namespace.c: Sort headers.
1715         * d-lang.c: Sort headers.
1716         * ctf.c: Sort headers.
1717         * csky-tdep.c: Sort headers.
1718         * csky-linux-tdep.c: Sort headers.
1719         * cris-tdep.c: Sort headers.
1720         * cris-linux-tdep.c: Sort headers.
1721         * cp-valprint.c: Sort headers.
1722         * cp-support.c: Sort headers.
1723         * cp-namespace.c: Sort headers.
1724         * cp-abi.c: Sort headers.
1725         * corelow.c: Sort headers.
1726         * corefile.c: Sort headers.
1727         * continuations.c: Sort headers.
1728         * completer.h: Sort headers.
1729         * completer.c: Sort headers.
1730         * complaints.c: Sort headers.
1731         * coffread.c: Sort headers.
1732         * coff-pe-read.c: Sort headers.
1733         * cli-out.h: Sort headers.
1734         * cli-out.c: Sort headers.
1735         * charset.c: Sort headers.
1736         * c-varobj.c: Sort headers.
1737         * c-valprint.c: Sort headers.
1738         * c-typeprint.c: Sort headers.
1739         * c-lang.c: Sort headers.
1740         * buildsym.c: Sort headers.
1741         * buildsym-legacy.c: Sort headers.
1742         * build-id.h: Sort headers.
1743         * build-id.c: Sort headers.
1744         * btrace.c: Sort headers.
1745         * bsd-uthread.c: Sort headers.
1746         * breakpoint.h: Sort headers.
1747         * breakpoint.c: Sort headers.
1748         * break-catch-throw.c: Sort headers.
1749         * break-catch-syscall.c: Sort headers.
1750         * break-catch-sig.c: Sort headers.
1751         * blockframe.c: Sort headers.
1752         * block.c: Sort headers.
1753         * bfin-tdep.c: Sort headers.
1754         * bfin-linux-tdep.c: Sort headers.
1755         * bfd-target.c: Sort headers.
1756         * bcache.c: Sort headers.
1757         * ax-general.c: Sort headers.
1758         * ax-gdb.h: Sort headers.
1759         * ax-gdb.c: Sort headers.
1760         * avr-tdep.c: Sort headers.
1761         * auxv.c: Sort headers.
1762         * auto-load.c: Sort headers.
1763         * arm-wince-tdep.c: Sort headers.
1764         * arm-tdep.c: Sort headers.
1765         * arm-symbian-tdep.c: Sort headers.
1766         * arm-pikeos-tdep.c: Sort headers.
1767         * arm-obsd-tdep.c: Sort headers.
1768         * arm-nbsd-tdep.c: Sort headers.
1769         * arm-nbsd-nat.c: Sort headers.
1770         * arm-linux-tdep.c: Sort headers.
1771         * arm-linux-nat.c: Sort headers.
1772         * arm-fbsd-tdep.c: Sort headers.
1773         * arm-fbsd-nat.c: Sort headers.
1774         * arm-bsd-tdep.c: Sort headers.
1775         * arch-utils.c: Sort headers.
1776         * arc-tdep.c: Sort headers.
1777         * arc-newlib-tdep.c: Sort headers.
1778         * annotate.h: Sort headers.
1779         * annotate.c: Sort headers.
1780         * amd64-windows-tdep.c: Sort headers.
1781         * amd64-windows-nat.c: Sort headers.
1782         * amd64-tdep.c: Sort headers.
1783         * amd64-sol2-tdep.c: Sort headers.
1784         * amd64-obsd-tdep.c: Sort headers.
1785         * amd64-obsd-nat.c: Sort headers.
1786         * amd64-nbsd-tdep.c: Sort headers.
1787         * amd64-nbsd-nat.c: Sort headers.
1788         * amd64-nat.c: Sort headers.
1789         * amd64-linux-tdep.c: Sort headers.
1790         * amd64-linux-nat.c: Sort headers.
1791         * amd64-fbsd-tdep.c: Sort headers.
1792         * amd64-fbsd-nat.c: Sort headers.
1793         * amd64-dicos-tdep.c: Sort headers.
1794         * amd64-darwin-tdep.c: Sort headers.
1795         * amd64-bsd-nat.c: Sort headers.
1796         * alpha-tdep.c: Sort headers.
1797         * alpha-obsd-tdep.c: Sort headers.
1798         * alpha-nbsd-tdep.c: Sort headers.
1799         * alpha-mdebug-tdep.c: Sort headers.
1800         * alpha-linux-tdep.c: Sort headers.
1801         * alpha-linux-nat.c: Sort headers.
1802         * alpha-bsd-tdep.c: Sort headers.
1803         * alpha-bsd-nat.c: Sort headers.
1804         * aix-thread.c: Sort headers.
1805         * agent.c: Sort headers.
1806         * addrmap.c: Sort headers.
1807         * ada-varobj.c: Sort headers.
1808         * ada-valprint.c: Sort headers.
1809         * ada-typeprint.c: Sort headers.
1810         * ada-tasks.c: Sort headers.
1811         * ada-lang.c: Sort headers.
1812         * aarch64-tdep.c: Sort headers.
1813         * aarch64-ravenscar-thread.c: Sort headers.
1814         * aarch64-newlib-tdep.c: Sort headers.
1815         * aarch64-linux-tdep.c: Sort headers.
1816         * aarch64-linux-nat.c: Sort headers.
1817         * aarch64-fbsd-tdep.c: Sort headers.
1818         * aarch64-fbsd-nat.c: Sort headers.
1819         * aarch32-linux-nat.c: Sort headers.
1820
1821 2019-04-04  Tom Tromey  <tom@tromey.com>
1822
1823         * varobj.c (varobj_create): Update.
1824         * rust-exp.y (struct rust_parser) <update_innermost_block,
1825         lookup_symbol>: New methods.
1826         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
1827         Rename.
1828         (rust_parser::rust_lookup_type)
1829         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1830         * printcmd.c (display_command, do_one_display): Update.
1831         * parser-defs.h (struct parser_state) <parser_state>: Add
1832         "tracker" parameter.
1833         (block_tracker): New member.
1834         (class innermost_block_tracker) <innermost_block_tracker>: Add
1835         "types" parameter.
1836         <reset>: Remove method.
1837         (innermost_block): Don't declare.
1838         (null_post_parser): Update.
1839         * parse.c (innermost_block): Remove global.
1840         (write_dollar_variable): Update.
1841         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
1842         Remove "tracker_types" parameter.
1843         (parse_expression): Add "tracker" parameter.
1844         (parse_expression_for_completion): Update.
1845         (null_post_parser): Add "tracker" parameter.
1846         * p-exp.y: Update rules.
1847         * m2-exp.y: Update rules.
1848         * language.h (struct language_defn) <la_post_parser>: Add
1849         "tracker" parameter.
1850         * go-exp.y: Update rules.
1851         * f-exp.y: Update rules.
1852         * expression.h (parse_expression, parse_exp_1): Add "tracker"
1853         parameter.
1854         * d-exp.y: Update rules.
1855         * c-exp.y: Update rules.
1856         * breakpoint.c (set_breakpoint_condition): Create an
1857         innermost_block_tracker.
1858         (watch_command_1): Likewise.
1859         * ada-lang.c (resolve): Add "tracker" parameter.
1860         (resolve_subexp): Likewise.
1861         * ada-exp.y (write_var_from_sym): Update.
1862
1863 2019-04-04  Tom Tromey  <tom@tromey.com>
1864
1865         * type-stack.h: New file.
1866         * type-stack.c: New file.
1867         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
1868         type-stack.h.
1869         (insert_into_type_stack, insert_type, push_type, push_type_int)
1870         (insert_type_address_space, pop_type, pop_type_int)
1871         (pop_typelist, pop_type_stack, append_type_stack)
1872         (push_type_stack, get_type_stack, push_typelist)
1873         (follow_type_instance_flags, follow_types): Don't declare.
1874         * parse.c (type_stack): Remove global.
1875         (parse_exp_in_context): Update.
1876         (insert_into_type_stack, insert_type, push_type, push_type_int)
1877         (insert_type_address_space, pop_type, pop_type_int)
1878         (pop_typelist, pop_type_stack, append_type_stack)
1879         (push_type_stack, get_type_stack, push_typelist)
1880         (follow_type_instance_flags, follow_types): Remove (moved to
1881         type-stack.c).
1882         * f-exp.y (type_stack): New global.
1883         Update rules.
1884         (push_kind_type, f_parse): Update.
1885         * d-exp.y (type_stack): New global.
1886         Update rules.
1887         (d_parse): Update.
1888         * c-exp.y (struct c_parse_state) <type_stack>: New member.
1889         Update rules.
1890         * Makefile.in (COMMON_SFILES): Add type-stack.c.
1891         (HFILES_NO_SRCDIR): Add type-stack.h.
1892
1893 2019-04-04  Tom Tromey  <tom@tromey.com>
1894
1895         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
1896         (rust_parser::convert_ast_to_expression, rust_parse)
1897         (rust_lex_test_completion, rust_lex_tests): Update.
1898         * parser-defs.h (struct expr_completion_state): New.
1899         (struct parser_state) <parser_state>: Add completion parameter.
1900         <mark_struct_expression, mark_completion_tag>: New methods.
1901         <parse_completion, m_completion_state>: New members.
1902         (prefixify_expression, null_post_parser): Update.
1903         (mark_struct_expression, mark_completion_tag): Don't declare.
1904         * parse.c (parse_completion, expout_last_struct)
1905         (expout_tag_completion_type, expout_completion_name): Remove
1906         globals.
1907         (parser_state::mark_struct_expression)
1908         (parser_state::mark_completion_tag): Now methods.
1909         (prefixify_expression): Add last_struct parameter.
1910         (prefixify_subexp): Likewise.
1911         (parse_exp_1): Update.
1912         (parse_exp_in_context): Add cstate parameter.  Update.
1913         (parse_expression_for_completion): Create an
1914         expr_completion_state.
1915         (null_post_parser): Add "completion" parameter.
1916         * p-exp.y: Update rules.
1917         (yylex): Update.
1918         * language.h (struct language_defn) <la_post_parser>: Add
1919         "completing" parameter.
1920         * go-exp.y: Update rules.
1921         (lex_one_token): Update.
1922         * expression.h (parse_completion): Don't declare.
1923         * d-exp.y: Update rules.
1924         (lex_one_token): Update rules.
1925         * c-exp.y: Update rules.
1926         (lex_one_token): Update.
1927         * ada-lang.c (resolve): Add "parse_completion" parameter.
1928         (resolve_subexp): Likewise.
1929         (ada_resolve_function): Likewise.
1930
1931 2019-04-04  Tom Tromey  <tom@tromey.com>
1932
1933         * parser-defs.h (struct parser_state) <start_arglist,
1934         end_arglist>: New methods.
1935         <arglist_len, m_funcall_chain>: New members.
1936         (arglist_len, start_arglist, end_arglist): Don't declare.
1937         * parse.c (arglist_len, funcall_chain): Remove global.
1938         (start_arglist, end_arglist): Remove functions.
1939         (parse_exp_in_context): Update.
1940         * p-exp.y: Update rules.
1941         * m2-exp.y: Update rules.
1942         * go-exp.y: Update rules.
1943         * f-exp.y: Update rules.
1944         * d-exp.y: Update rules.
1945         * c-exp.y: Update rules.
1946
1947 2019-04-04  Tom Tromey  <tom@tromey.com>
1948
1949         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
1950         lex_operator, push_back>: New methods.
1951         Update all rules.
1952         (rust_parser::lex_hex, lex_escape): Rename and update.
1953         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
1954         (rust_parser::lex_operator): Rename and update.
1955         (rust_parser::lex_number, rustyylex, rustyyerror)
1956         (rust_lex_test_init, rust_lex_test_sequence)
1957         (rust_lex_test_push_back, rust_lex_tests): Update.
1958         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
1959         parameter.
1960         <lexptr, prev_lexptr>: New members.
1961         (lexptr, prev_lexptr): Don't declare.
1962         * parse.c (lexptr, prev_lexptr): Remove globals.
1963         (parse_exp_in_context): Update.
1964         * p-exp.y (yylex, yyerror): Update.
1965         * m2-exp.y (parse_number, yylex, yyerror): Update.
1966         * go-exp.y (lex_one_token, yyerror): Update.
1967         * f-exp.y (match_string_literal, yylex, yyerror): Update.
1968         * d-exp.y (lex_one_token, yyerror): Update.
1969         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
1970         (lex_one_token, yyerror): Update.
1971         * ada-lex.l (YY_INPUT): Update.
1972         (rewind_to_char): Update.
1973         * ada-exp.y (yyerror): Update.
1974
1975 2019-04-04  Tom Tromey  <tom@tromey.com>
1976
1977         * rust-exp.y (rustyylex, rust_lex_tests): Update.
1978         * parser-defs.h (struct parser_state) <parser_state>: Add new
1979         parameter.
1980         <comma_terminates>: New member.
1981         (comma_terminates): Don't declare global.
1982         * parse.c (comma_terminates): Remove global.
1983         (parse_exp_in_context): Update.
1984         * p-exp.y (yylex): Update.
1985         * m2-exp.y (yylex): Update.
1986         * go-exp.y (lex_one_token): Update.
1987         * f-exp.y (yylex): Update.
1988         * d-exp.y (lex_one_token): Update.
1989         * c-exp.y (lex_one_token): Update.
1990         * ada-lex.l: Update.
1991
1992 2019-04-04  Tom Tromey  <tom@tromey.com>
1993
1994         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
1995         (rustyylex, rust_lex_test_init, rust_lex_test_one)
1996         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
1997         * parser-defs.h (paren_depth): Don't declare.
1998         * parse.c (paren_depth): Remove global.
1999         (parse_exp_in_context): Update.
2000         * p-exp.y (paren_depth): New global.
2001         (pascal_parse): Initialize it.
2002         * m2-exp.y (paren_depth): New global.
2003         (m2_parse): Initialize it.
2004         * go-exp.y (paren_depth): New global.
2005         (go_parse): Initialize it.
2006         * f-exp.y (paren_depth): New global.
2007         (f_parse): Initialize it.
2008         * d-exp.y (paren_depth): New global.
2009         (d_parse): Initialize it.
2010         * c-exp.y (paren_depth): New global.
2011         (c_parse): Initialize it.
2012         * ada-lex.l (paren_depth): New global.
2013         (lexer_init): Initialize it.
2014
2015 2019-04-04  Tom Tromey  <tom@tromey.com>
2016
2017         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2018         (rust_parser::convert_ast_to_type)
2019         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2020         * parser-defs.h (struct parser_state) <parser_state>: Add
2021         parameters.  Initialize new members.
2022         <expression_context_block, expression_context_pc>: New members.
2023         * parse.c (expression_context_block, expression_context_pc):
2024         Remove globals.
2025         (parse_exp_in_context): Update.
2026         * p-exp.y: Update all rules.
2027         (yylex): Update.
2028         * m2-exp.y: Update all rules.
2029         (yylex): Update.
2030         * go-exp.y (yylex): Update.
2031         * f-exp.y (yylex): Update.
2032         * d-exp.y: Update all rules.
2033         (yylex): Update.
2034         * c-exp.y: Update all rules.
2035         (lex_one_token, classify_name, yylex, c_parse): Update.
2036         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2037
2038 2019-04-04  Tom Tromey  <tom@tromey.com>
2039
2040         * gdbarch.h, gdbarch.c: Rebuild.
2041         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2042         * stap-probe.h:
2043         (struct stap_parse_info): Replace "parser_state" with
2044         "expr_builder".
2045         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2046         (parser_state): New class.
2047         * parse.c (expr_builder): Rename.
2048         (expr_builder::release): Rename.
2049         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2050         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2051         (write_exp_elt_longcst, write_exp_elt_floatcst)
2052         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2053         (write_exp_string_vector, write_exp_bitstring)
2054         (write_exp_msymbol, mark_struct_expression)
2055         (write_dollar_variable)
2056         (insert_type_address_space, increase_expout_size): Replace
2057         "parser_state" with "expr_builder".
2058         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2059         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2060         "parser_state" with "expr_builder".
2061
2062 2019-04-04  Tom Tromey  <tom@tromey.com>
2063
2064         * rust-exp.y: Replace "parse_language" with method call.
2065         * p-exp.y:
2066         (yylex): Replace "parse_language" with method call.
2067         * m2-exp.y:
2068         (yylex): Replace "parse_language" with method call.
2069         * go-exp.y (classify_name): Replace "parse_language" with method
2070         call.
2071         * f-exp.y (yylex): Replace "parse_language" with method call.
2072         * d-exp.y (lex_one_token): Replace "parse_language" with method
2073         call.
2074         * c-exp.y:
2075         (lex_one_token, classify_name, yylex): Replace "parse_language"
2076         with method call.
2077         * ada-exp.y (find_primitive_type, type_char)
2078         (type_system_address): Replace "parse_language" with method call.
2079
2080 2019-04-04  Tom Tromey  <tom@tromey.com>
2081
2082         * rust-exp.y: Replace "parse_gdbarch" with method call.
2083         * parse.c (write_dollar_variable, insert_type_address_space):
2084         Replace "parse_gdbarch" with method call.
2085         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2086         call.
2087         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2088         call.
2089         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2090         "parse_gdbarch" with method call.
2091         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2092         with method call.
2093         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2094         "parse_gdbarch" with method call.
2095         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2096         "parse_gdbarch" with method call.
2097         * c-exp.y (parse_type, parse_number, classify_name): Replace
2098         "parse_gdbarch" with method call.
2099         * ada-lex.l: Replace "parse_gdbarch" with method call.
2100         * ada-exp.y (parse_type, find_primitive_type, type_char)
2101         (type_system_address): Replace "parse_gdbarch" with method call.
2102
2103 2019-04-04  Tom Tromey  <tom@tromey.com>
2104
2105         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2106         * stap-probe.c (stap_parse_argument): Update.
2107         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2108         initial_size parameter.
2109         * rust-exp.y (rust_lex_tests): Update.
2110         * parse.c (parser_state): Update.
2111         (parse_exp_in_context): Update.
2112         * parser-defs.h (struct parser_state) <parser_state>: Remove
2113         "initial_size" parameter.
2114
2115 2019-04-04  Tom Tromey  <tom@tromey.com>
2116
2117         * parser-defs.h (increase_expout_size): Don't declare.
2118         * parse.c (increase_expout_size): Now static.
2119
2120 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2121
2122         * gnu-nat.c (gnu_nat_target::wait): Fix
2123         target_waitstatus_to_string call.
2124
2125 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2126
2127         * eval.c (evaluate_subexp_standard): Handle internal functions
2128         during Fortran function call handling.
2129
2130 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2131
2132         * NEWS: Mention new internal functions.
2133         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2134         (read_base_type): Use dwarf2_init_complex_target_type.
2135         * value.c (creal_internal_fn): New function.
2136         (cimag_internal_fn): New function.
2137         (_initialize_values): Register new internal functions.
2138
2139 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2140
2141         * infrun.c (stop_all_threads): If debug_infrun, always
2142         trace the wait status after wait_one, using
2143         target_waitstatus_to_string and target_pid_to_str.
2144         (handle_inferior_event): Replace various trace of
2145         wait status kind by a single trace.
2146         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2147         wait status kind image by target_waitstatus_to_string.
2148         * target/waitstatus.c (target_waitstatus_to_string): Fix
2149         obsolete comment.
2150
2151 2019-04-01  Tom Tromey  <tromey@adacore.com>
2152
2153         PR symtab/23331:
2154         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2155
2156 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2157             Pedro Alves  <palves@redhat.com>
2158
2159         * top.c (quit_force): Call 'finalize_values'.
2160         * value.c (finalize_values): New function.
2161         * value.h (finalize_values): Declare.
2162
2163 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2164
2165         * NEWS: Announce $_gdb_major and $_gdb_minor.
2166
2167         * top.c (init_gdb_version_vars): New function.
2168         (gdb_init): Call init_gdb_version_vars.
2169
2170 2019-03-29  Tom Tromey  <tromey@adacore.com>
2171
2172         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2173         help text.  Remove dead code.
2174
2175 2019-03-29  Keith Seitz  <keiths@redhat.com>
2176
2177         From Siddhesh Poyarekar:
2178         * f-lang.h (f77_get_upperbound): Return LONGEST.
2179         (f77_get_lowerbound): Likewise.
2180         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2181         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2182         print them.
2183         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2184         plongest to format print it.
2185         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2186         (f77_get_upperbound): Likewise.
2187         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2188         LOWER_BOUND to LONGEST.
2189         (f77_create_arrayprint_offset_tbl): Likewise.
2190
2191 2019-03-29  Keith Seitz  <keiths@redhat.com>
2192
2193         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2194         %s/pulongest for TYPE_LENGTH instead of %d in format
2195         strings.
2196         * ada-typerint.c (ada_print_type): Likewise.
2197         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2198         * compile/compile-c-support.c (generate_register_struct): Likewise.
2199         * gdbtypes.c (recursive_dump_type): Likewise.
2200         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2201         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2202         instead of %d in format strings.
2203         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2204         to std::min to ULONGEST.
2205         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2206         instead of %d in format strings.
2207         * tracepoint.c (info_scope_command): Likewise.
2208         * typeprint.c (print_offset_data::update)
2209         (print_offset_data::finish): Likewise.
2210         * xtensa-tdep.c (xtensa_store_return_value)
2211         (xtensa_push_dummy_call): Likewise.
2212
2213 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2214
2215         * windows-nat.c (display_selector): Fixed format specifications
2216         for 64-bit Cygwin.
2217
2218 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2219
2220         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2221
2222 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2223
2224         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2225         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2226         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2227         (nios2_linux_init_abi): Install it.
2228
2229 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2230
2231         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2232
2233 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2234
2235         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2236
2237 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2238             Tom Tromey  <tromey@adacore.com>
2239
2240         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2241
2242 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2243
2244         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2245         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2246         method to compute the bounds of range types. Also print "[evaluated]"
2247         if the bounds' values come from a dynamic evaluation.
2248
2249 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2250
2251         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2252         whitespace when pretty printing is on.
2253
2254 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2255
2256         * ppc-linux-nat.c: Add include.
2257
2258 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2259
2260         * NEWS: Mention AArch64 Pointer Authentication.
2261
2262 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2263
2264         * arm-linux-nat.c: Add include.
2265
2266 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2267
2268         * source-cache.c (source_cache::get_source_lines): Re-read
2269         fullname after calling open_source_file.
2270
2271 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2272
2273         * NEWS: Mention TLS support for FreeBSD.
2274
2275 2019-03-25  Tom Tromey  <tromey@adacore.com>
2276
2277         * minsyms.c (BUNCH_SIZE): Update comment.
2278         (~minimal_symbol_reader): Remove old comment.
2279         (compact_minimal_symbols): Update comment.
2280         (minimal_symbol_reader::install): Remove old comment.  Update
2281         other comments.
2282
2283 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2284
2285         * s390-linux-nat.c: Add include.
2286
2287 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2288
2289         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2290         Call linux_get_hwcap.
2291         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2292         Likewise.
2293         (aarch64_linux_get_hwcap): Remove function.
2294         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2295         declaration.
2296         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2297         linux_get_hwcap.
2298         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2299         * linux-tdep.c (linux_get_hwcap): Add function.
2300         (linux_get_hwcap2): Likewise.
2301         * linux-tdep.h (linux_get_hwcap): Add declaration.
2302         (linux_get_hwcap2): Likewise.
2303         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2304         (ppc_linux_get_hwcap2): Likewise.
2305         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2306         linux_get_hwcap.
2307         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2308         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2309         (ppc_linux_nat_target::read_description): Likewise.
2310         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2311         * s390-linux-nat.c: Likewise.
2312         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2313
2314 2019-03-24  Tom Tromey  <tom@tromey.com>
2315
2316         * ada-lang.c (standard_lookup): Simplify initialization.
2317         (ada_lookup_symbol_nonlocal): Simplify return.
2318         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2319         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2320         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2321         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2322         initialization.
2323         * solib.c (solib_global_lookup): Simplify.
2324         * symtab.c (null_block_symbol): Remove.
2325         (symbol_cache_lookup): Simplify returns.
2326         (lookup_language_this): Simplify returns.
2327         (lookup_symbol_aux): Simplify return.
2328         (lookup_local_symbol): Simplify returns.
2329         (lookup_global_symbol_from_objfile): Simplify return.
2330         (lookup_symbol_in_objfile_symtabs)
2331         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2332         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2333         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2334         * cp-namespace.c (cp_lookup_bare_symbol)
2335         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2336         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2337         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2338         (cp_lookup_symbol_via_imports): Simplify initialization.
2339         (find_symbol_in_baseclass): Likewise.
2340         * symtab.h (null_block_symbol): Remove.
2341         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2342         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2343         (d_lookup_symbol_module): Likewise.
2344         (find_symbol_in_baseclass): Simplify initialization.
2345
2346 2019-03-24  Tom Tromey  <tom@tromey.com>
2347
2348         * expression.h: Don't include symtab.h.
2349         (struct block): Forward declare.
2350
2351 2019-03-24  Tom Tromey  <tom@tromey.com>
2352
2353         * c-exp.y (typebase): Remove casts.
2354         * gdbtypes.c (lookup_unsigned_typename, )
2355         (lookup_signed_typename): Remove cast.
2356         * eval.c (parse_to_comma_and_eval): Remove cast.
2357         * parse.c (write_dollar_variable): Remove cast.
2358         * block.h (struct block) <superblock>: Now const.
2359         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2360         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2361         (map_block): Make "block" const.
2362         * symfile.h (struct quick_symbol_functions)
2363         <map_matching_symbols>: Constify block argument to "callback".
2364         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2365         const.
2366         (find_pc_sect_compunit_symtab): Make "b" const.
2367         (find_symbol_at_address): Likewise.
2368         (search_symbols): Likewise.
2369         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2370         (dw2_debug_names_lookup_symbol): Likewise.
2371         (dw2_map_matching_symbols): Update.
2372         * p-valprint.c (pascal_val_print): Remove "block".
2373         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2374         (aux_add_nonlocal_symbols): Make "block" const.
2375         (resolve_subexp): Remove cast.
2376         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2377         const.
2378         (iterate_over_file_blocks): Likewise.
2379         * f-exp.y (%union) <bval>: Remove.
2380         * coffread.c (patch_opaque_types): Make "b" const.
2381         * spu-tdep.c (spu_catch_start): Make "block" const.
2382         * c-valprint.c (print_unpacked_pointer): Remove "block".
2383         * symmisc.c (dump_symtab_1): Make "b" const.
2384         (block_depth): Make "block" const.
2385         * d-exp.y (%union) <bval>: Remove.
2386         * cp-support.h (cp_lookup_rtti_type): Update.
2387         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2388         * psymtab.c (psym_lookup_symbol): Make "block" const.
2389         (maintenance_check_psymtabs): Make "b" const.
2390         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2391         (enumerate_locals, enumerate_args): Update.
2392         * python/py-symtab.c (stpy_global_block): Make "block" const.
2393         (stpy_static_block): Likewise.
2394         * inline-frame.c (block_starting_point_at): Make "new_block"
2395         const.
2396         * block.c (find_block_in_blockvector): Make return type const.
2397         (blockvector_for_pc_sect): Make "b" const.
2398         (find_block_in_blockvector): Make "b" const.
2399
2400 2019-03-23  Tom Tromey  <tom@tromey.com>
2401
2402         * varobj.c (varobj_create): Update.
2403         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2404         * printcmd.c (display_command, do_one_display): Don't reset
2405         innermost_block.
2406         * parser-defs.h (enum innermost_block_tracker_type): Move to
2407         expression.h.
2408         (innermost_block): Update comment.
2409         * parse.c (parse_exp_1): Add tracker_types parameter.
2410         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2411         tracker_types parameter.  Reset innermost_block.
2412         (parse_exp_in_context): Remove.
2413         (parse_expression_for_completion): Update.
2414         * objfiles.c (~objfile): Don't reset expression_context_block or
2415         innermost_block.
2416         * expression.h (enum innermost_block_tracker_type): Move from
2417         parser-defs.h.
2418         (parse_exp_1): Add tracker_types parameter.
2419         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2420         reset innermost_block.
2421
2422 2019-03-23  Tom Tromey  <tom@tromey.com>
2423
2424         * objfiles.h: Include bcache.h.
2425
2426 2019-03-23  Tom Tromey  <tom@tromey.com>
2427
2428         * linespec.c (get_current_search_block): Use
2429         scoped_restore_current_language.
2430         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2431
2432 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2433             Jiong Wang  <jiong.wang@arm.com>
2434
2435         * aarch64-linux-tdep.c
2436         (aarch64_linux_iterate_over_regset_sections): Check for pauth
2437         section.
2438         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
2439
2440 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2441             Jiong Wang  <jiong.wang@arm.com>
2442
2443         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
2444         instructions.
2445         (aarch64_analyze_prologue_test): Add PACIASP test.
2446         (aarch64_prologue_prev_register): Unmask PC value.
2447
2448 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2449             Jiong Wang  <jiong.wang@arm.com>
2450
2451         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
2452         (aarch64_dwarf2_prev_register): Unmask PC value.
2453         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
2454         (aarch64_execute_dwarf_cfa_vendor_op): Check for
2455         DW_CFA_AARCH64_negate_ra_state.
2456         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
2457
2458 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2459             Jiong Wang  <jiong.wang@arm.com>
2460
2461         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
2462         registers.
2463         (aarch64_pseudo_register_name): Likewise.
2464         (aarch64_pseudo_register_type): Likewise.
2465         (aarch64_pseudo_register_reggroup_p): Likewise.
2466         (aarch64_gdbarch_init): Add pauth registers.
2467         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
2468         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
2469         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
2470         (struct gdbarch_tdep): Add regnum for ra_state.
2471
2472 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2473             Jiong Wang  <jiong.wang@arm.com>
2474
2475         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
2476
2477 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2478             Jiong Wang  <jiong.wang@arm.com>
2479
2480         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
2481         function.
2482         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
2483         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
2484         (aarch64_gdbarch_init): Add puth registers.
2485         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
2486         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
2487         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
2488
2489 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2490             Jiong Wang  <jiong.wang@arm.com>
2491
2492         * aarch64-linux-nat.c
2493         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
2494         * aarch64-linux-tdep.c
2495         (aarch64_linux_core_read_description): Likewise.
2496         (aarch64_linux_get_hwcap): New function.
2497         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
2498         (aarch64_linux_get_hwcap): New declaration.
2499
2500 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2501             Jiong Wang  <jiong.wang@arm.com>
2502
2503         * aarch64-linux-nat.c
2504         (aarch64_linux_nat_target::read_description): Add pauth param.
2505         * aarch64-linux-tdep.c
2506         (aarch64_linux_core_read_description): Likewise.
2507         * aarch64-tdep.c (struct target_desc): Add in pauth.
2508         (aarch64_read_description): Add pauth param.
2509         (aarch64_gdbarch_init): Likewise.
2510         * aarch64-tdep.h (aarch64_read_description): Likewise.
2511         * arch/aarch64.c (aarch64_create_target_description): Likewise.
2512         * arch/aarch64.h (aarch64_create_target_description): Likewise.
2513         * features/Makefile: Add new files.
2514         * features/aarch64-pauth.c: New file.
2515         * features/aarch64-pauth.xml: New file.
2516
2517 2019-03-20  Tom Tromey  <tromey@adacore.com>
2518
2519         * infrun.c (handle_inferior_event): Rename from
2520         handle_inferior_event_1.  Create a scoped_value_mark.
2521         (handle_inferior_event): Remove.
2522
2523 2019-03-19  Tom Tromey  <tromey@adacore.com>
2524
2525         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
2526         * infrun.h (print_stop_event): Add "displays" parameter.
2527         * infrun.c (print_stop_event): Add "displays" parameter.
2528
2529 2019-03-19  Pedro Alves  <palves@redhat.com>
2530
2531         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
2532         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
2533         to -1.  Fix TABs vs spaces.
2534         (tui_ui_out::tui_ui_out): Don't initialize fields here.
2535         * tui/tui-out.h (tui_ui_out) Add intro comments.
2536         <m_line, m_start_of_line>: In-class initialize, and add describing
2537         comment.
2538
2539 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
2540
2541         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
2542         variable names.
2543         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
2544
2545 2019-03-18  Pedro Alves  <palves@redhat.com>
2546             Eli Zaretskii <eliz@gnu.org>
2547
2548         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
2549         m_line and m_start_of_line.
2550
2551 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
2552
2553         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
2554         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
2555         it returns a newline.  This fixes a regression in TU mode, whereby
2556         the next line is output on the same screen line as the user input.
2557
2558 2019-03-18  Tom Tromey  <tromey@adacore.com>
2559
2560         * minsyms.c (minimal_symbol_reader::install): Remove call to
2561         obstack_blank.
2562
2563 2019-03-18  Pedro Alves  <palves@redhat.com>
2564
2565         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
2566         New globals.
2567         (apply_style): New, factored out from ...
2568         (apply_ansi_escape): ... this.  Handle reverse video mode.
2569         (tui_set_reverse_mode): New function.
2570         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
2571         * tui/tui-winsource.c (tui_show_source_line): Use
2572         tui_set_reverse_mode instead of setting A_STANDOUT.
2573         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
2574         New setter methods.
2575
2576 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
2577
2578         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
2579         Handle tabs.
2580
2581 2019-03-18  Tom Tromey  <tromey@adacore.com>
2582
2583         * ada-lang.c (empty_array): Add "high" parameter.
2584         (ada_evaluate_subexp): Update.
2585
2586 2019-03-17  Sergei Trofimovich <siarheit@google.com>
2587
2588         * unittests/string_view-selftests.c: Define
2589         _initialize_string_view_selftests unconditionally.
2590
2591 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2592
2593         PR gdb/24350
2594         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
2595
2596 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2597
2598         PR gdb/24351
2599         * windows-nat.c (display_selector): Fix format specifiers.
2600
2601 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
2602
2603         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
2604         tui_refill_source_window instead of tui_refresh_win, to update the
2605         current execution line.  This fixes redisplay of the current line
2606         when stepping through the code with "next" or "step".
2607
2608 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2609
2610         * source-cache.c (source_cache::get_source_lines): Call
2611         find_source_lines to initialize s->nlines.  This fixes vertical
2612         scrolling of TUI source window when the DOWN arrow is pressed.
2613
2614 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2615
2616         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
2617         linux-thread-db.c (_initialize_thread_db): Likewise.
2618
2619 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2620
2621         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
2622         wclrtoeol in tui_show_source_line".  This reverts changes made in
2623         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
2624
2625 2019-03-15  Tom Tromey  <tom@tromey.com>
2626
2627         * symtab.h (struct minimal_symbol): Derive from
2628         general_symbol_info.
2629         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
2630         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
2631         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
2632         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
2633         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
2634         (MSYMBOL_SEARCH_NAME): Update.
2635         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
2636         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
2637         * minsyms.c (minimal_symbol_reader::record_full): Update.
2638
2639 2019-03-15  Tom Tromey  <tom@tromey.com>
2640
2641         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
2642
2643 2019-03-15  Tom Tromey  <tom@tromey.com>
2644
2645         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
2646         unique_xmalloc_ptr.
2647         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
2648         Update.
2649         * minsyms.c (lookup_minimal_symbol_by_pc_section)
2650         (build_minimal_symbol_hash_tables)
2651         (minimal_symbol_reader::install): Update.
2652
2653 2019-03-15  Tom Tromey  <tom@tromey.com>
2654
2655         * symtab.c (create_demangled_names_hash): Update.
2656         (symbol_set_names): Update.
2657         * objfiles.h (struct objfile_per_bfd_storage)
2658         <demangled_names_hash>: Now an htab_up.
2659         * objfiles.c (objfile_per_bfd_storage): Simplify.
2660
2661 2019-03-15  Tom Tromey  <tom@tromey.com>
2662
2663         * objfiles.h (struct objfile_per_bfd_storage): Declare
2664         destructor.
2665         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
2666         New.
2667         (get_objfile_bfd_data): Use new.  Don't initialize
2668         language_of_main.
2669         (free_objfile_per_bfd_storage): Remove.
2670         (objfile_bfd_data_free, objfile::~objfile): Use delete.
2671
2672 2019-03-15  Tom Tromey  <tom@tromey.com>
2673
2674         * symfile.c (reread_symbols): Update.
2675         * objfiles.c (objfile::objfile): Update.
2676         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
2677         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
2678         comment.
2679         (minimal_symbol_reader::install): Update.
2680         (terminate_minimal_symbol_table): Remove.
2681         * jit.c (jit_object_close_impl): Update.
2682
2683 2019-03-15  Tom Tromey  <tom@tromey.com>
2684
2685         * minsyms.c (minimal_symbol_reader::record_full): Remove some
2686         initializations.
2687
2688 2019-03-15  Tom Tromey  <tom@tromey.com>
2689
2690         * objfiles.h (struct objfile_per_bfd_storage)
2691         <demangled_hash_languages>: Now a bitset.
2692         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
2693         (lookup_minimal_symbol): Update.
2694
2695 2019-03-15  Tom Tromey  <tom@tromey.com>
2696
2697         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
2698         Don't return the symbol.
2699         * coffread.c (record_minimal_symbol): Use record_full.
2700
2701 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
2702
2703         The MS-Windows port of ncurses fails to switch to a color pair if
2704         one or both of the colors are the implicit default colors.  This
2705         change records the default colors when TUI is initialized, and
2706         then specifies them explicitly when a color pair uses the default
2707         colors.  This allows color styling in TUI mode on MS-Windows.
2708
2709         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
2710         ncurses_norm_attr.
2711         (tui_initialize_io) [__MINGW32__]: Record the default terminal
2712         colors in ncurses_norm_attr.
2713         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
2714         "none", replace it with the default color recorded in
2715         ncurses_norm_attr.
2716
2717 2019-03-14  Tom Tromey  <tromey@adacore.com>
2718
2719         * source-cache.h (class source_cache) <get_source_lines>: Return
2720         std::string.
2721         * source-cache.c (source_cache::extract_lines): Handle case where
2722         first_pos==npos.  Return std::string.
2723         (source_cache::get_source_lines): Update.
2724
2725 2019-03-14  Tom Tromey  <tromey@adacore.com>
2726
2727         * NEWS: Add item for "style sources" commands.
2728         * source-cache.c (source_cache::get_source_lines): Check
2729         source_styling.
2730         * cli/cli-style.c (source_styling): New global.
2731         (_initialize_cli_style): Add "style sources" commands.
2732         (show_style_sources): New function.
2733         * cli/cli-style.h (source_styling): Declare.
2734
2735 2019-03-14  Pedro Alves  <palves@redhat.com>
2736             Tom Tromey  <tromey@adacore.com>
2737
2738         * tui/tui-winsource.h (tui_refill_source_window): Declare.
2739         * tui/tui-winsource.c (tui_refill_source_window): New function,
2740         from...
2741         (tui_horizontal_source_scroll): ... here.  Move some logic.
2742         * cli/cli-style.c (set_style_enabled): Notify new observable.
2743         * tui/tui-hooks.c (tui_redisplay_source): New function.
2744         (tui_attach_detach_observers): Attach or detach
2745         tui_redisplay_source.
2746         * observable.h (source_styling_changed): New observable.
2747         * observable.c: Define source_styling_changed observable.
2748
2749 2019-03-13  Tom Tromey  <tromey@adacore.com>
2750
2751         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
2752         (i386_gnu_nat_target::store_registers): Update.
2753         * target-debug.h (target_debug_print_std_string): New macro.
2754         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2755         * windows-tdep.c (display_one_tib): Update.
2756         * tui/tui-stack.c (tui_make_status_line): Update.
2757         * top.c (print_inferior_quit_action): Update.
2758         * thread.c (thr_try_catch_cmd): Update.
2759         (add_thread_with_info): Update.
2760         (thread_target_id_str): Update.
2761         (thr_try_catch_cmd): Update.
2762         (thread_command): Update.
2763         (thread_find_command): Update.
2764         * record-btrace.c (record_btrace_target::info_record)
2765         (record_btrace_resume_thread, record_btrace_target::resume)
2766         (record_btrace_cancel_resume, record_btrace_step_thread)
2767         (record_btrace_target::wait, record_btrace_target::wait)
2768         (record_btrace_target::wait, record_btrace_target::stop): Update.
2769         * progspace.c (print_program_space): Update.
2770         * process-stratum-target.c
2771         (process_stratum_target::thread_address_space): Update.
2772         * linux-fork.c (linux_fork_mourn_inferior)
2773         (detach_checkpoint_command, info_checkpoints_command)
2774         (linux_fork_context): Update.
2775         (linux_fork_detach): Update.
2776         (class scoped_switch_fork_info): Update.
2777         (delete_checkpoint_command): Update.
2778         * infrun.c (follow_fork_inferior): Update.
2779         (follow_fork_inferior): Update.
2780         (proceed_after_vfork_done): Update.
2781         (handle_vfork_child_exec_or_exit): Update.
2782         (follow_exec): Update.
2783         (displaced_step_prepare_throw): Update.
2784         (displaced_step_restore): Update.
2785         (start_step_over): Update.
2786         (resume_1): Update.
2787         (clear_proceed_status_thread): Update.
2788         (proceed): Update.
2789         (print_target_wait_results): Update.
2790         (do_target_wait): Update.
2791         (context_switch): Update.
2792         (stop_all_threads): Update.
2793         (restart_threads): Update.
2794         (finish_step_over): Update.
2795         (handle_signal_stop): Update.
2796         (switch_back_to_stepped_thread): Update.
2797         (keep_going_pass_signal): Update.
2798         (print_exited_reason): Update.
2799         (normal_stop): Update.
2800         * inferior.c (inferior_pid_to_str): Change return type.
2801         (print_selected_inferior): Update.
2802         (add_inferior): Update.
2803         (detach_inferior): Update.
2804         * dummy-frame.c (fprint_dummy_frames): Update.
2805         * dcache.c (dcache_info_1): Update.
2806         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
2807         (btrace_fetch, btrace_clear): Update.
2808         * linux-tdep.c (linux_core_pid_to_str): Change return type.
2809         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
2810         type.
2811         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
2812         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
2813         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
2814         * gdbarch.c, gdbarch.h: Rebuild.
2815         * gdbarch.sh (core_pid_to_str): Change return type.
2816         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
2817         return type.
2818         (windows_nat_target::pid_to_str): Change return type.
2819         (windows_delete_thread): Update.
2820         (windows_nat_target::attach): Update.
2821         (windows_nat_target::files_info): Update.
2822         * target-delegates.c: Rebuild.
2823         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
2824         return type.
2825         (sol_thread_target::pid_to_str): Change return type.
2826         * remote.c (class remote_target) <pid_to_str>: Change return
2827         type.
2828         (remote_target::pid_to_str): Change return type.
2829         (extended_remote_target::attach, remote_target::remote_stop_ns)
2830         (remote_target::remote_notif_remove_queued_reply)
2831         (remote_target::push_stop_reply, remote_target::disable_btrace):
2832         Update.
2833         (extended_remote_target::attach): Update.
2834         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
2835         type.
2836         (gdbsim_target::pid_to_str): Change return type.
2837         * ravenscar-thread.c (struct ravenscar_thread_target)
2838         <pid_to_str>: Change return type.
2839         (ravenscar_thread_target::pid_to_str): Change return type.
2840         * procfs.c (class procfs_target) <pid_to_str>: Change return
2841         type.
2842         (procfs_target::pid_to_str): Change return type.
2843         (procfs_target::attach): Update.
2844         (procfs_target::detach): Update.
2845         (procfs_target::fetch_registers): Update.
2846         (procfs_target::store_registers): Update.
2847         (procfs_target::wait): Update.
2848         (procfs_target::files_info): Update.
2849         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
2850         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
2851         return type.
2852         (nto_procfs_target::pid_to_str): Change return type.
2853         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
2854         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
2855         return type.
2856         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
2857         (exit_lwp): Update.
2858         (attach_proc_task_lwp_callback, get_detach_signal)
2859         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
2860         (linux_nat_target::resume, wait_lwp, stop_callback)
2861         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
2862         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
2863         (linux_nat_wait_1, resume_stopped_resumed_lwps)
2864         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
2865         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
2866         type.
2867         (inf_ptrace_target::attach): Update.
2868         (inf_ptrace_target::files_info): Update.
2869         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
2870         type.
2871         (go32_nat_target::pid_to_str): Change return type.
2872         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
2873         (gnu_nat_target::wait): Update.
2874         (gnu_nat_target::wait): Update.
2875         (gnu_nat_target::resume): Update.
2876         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
2877         (fbsd_nat_target::wait): Update.
2878         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
2879         type.
2880         (darwin_nat_target::attach): Update.
2881         * corelow.c (class core_target) <pid_to_str>: Change return type.
2882         (core_target::pid_to_str): Change return type.
2883         * target.c (normal_pid_to_str): Change return type.
2884         (default_pid_to_str): Likewise.
2885         (target_pid_to_str): Change return type.
2886         (target_translate_tls_address): Update.
2887         (target_announce_detach): Update.
2888         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
2889         return type.
2890         (bsd_uthread_target::pid_to_str): Change return type.
2891         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
2892         type.
2893         (bsd_kvm_target::pid_to_str): Change return type.
2894         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
2895         return type.
2896         (aix_thread_target::pid_to_str): Change return type.
2897         * target.h (struct target_ops) <pid_to_str>: Change return type.
2898         (target_pid_to_str, normal_pid_to_str): Likewise.
2899         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
2900         type.
2901         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
2902         type.
2903         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
2904         return type.
2905         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
2906         type.
2907         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
2908         type.
2909         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
2910         return type.
2911
2912 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
2913
2914         * NEWS: Mention that the new default MI version is 3.  Mention
2915         changes to the output of commands and events that deal with
2916         multi-location breakpoints.
2917         * breakpoint.c: Include "mi/mi-out.h".
2918         (print_one_breakpoint): Change output syntax if using MI version
2919         >= 3.
2920         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
2921         New.
2922         (mi_multi_location_breakpoint_output_fixed): New.
2923         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
2924         (mi_cmd_fix_multi_location_breakpoint_output): New.
2925         (mi_multi_location_breakpoint_output_fixed): New.
2926         * mi/mi-cmds.c (mi_cmds): Register command
2927         -fix-multi-location-breakpoint-output.
2928         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
2929         interpreter "mi".
2930
2931 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
2932
2933         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
2934         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
2935         instantiate mi_ui_out based on interpreter name.
2936         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
2937         * mi/mi-main.c (mi_load_progress): Likewise.
2938
2939 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2940
2941         * NEWS: Combine separate "New targets" sections for 8.3.
2942
2943 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2944
2945         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
2946         (ppcfbsd_init_abi): Install gdbarch
2947         "fetch_tls_load_module_address" and "get_thread_local_address"
2948         methods.
2949
2950 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2951
2952         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
2953         (riscv_fbsd_init_abi): Install gdbarch
2954         "fetch_tls_load_module_address" and "get_thread_local_address"
2955         methods.
2956
2957 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2958
2959         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
2960         (i386fbsd_init_abi): Install gdbarch
2961         "fetch_tls_load_module_address" and "get_thread_local_address"
2962         methods.
2963
2964 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2965
2966         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
2967         (amd64fbsd_init_abi): Install gdbarch
2968         "fetch_tls_load_module_address" and "get_thread_local_address"
2969         methods.
2970
2971 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2972
2973         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
2974         (struct fbsd_pspace_data): New type.
2975         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
2976         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
2977         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
2978         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
2979         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
2980
2981 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2982
2983         * gdbtypes.c (lookup_struct_elt): New function.
2984         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
2985         * gdbtypes.h (struct struct_elt): New type.
2986         (lookup_struct_elt): New prototype.
2987
2988 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2989
2990         * gdbtypes.c (lookup_struct_elt_type): Update comment and
2991         remove disabled code block.
2992
2993 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2994
2995         * gdbarch.sh (get_thread_local_address): New method.
2996         * gdbarch.h, gdbarch.c: Regenerate.
2997         * target.c (target_translate_tls_address): Use
2998         gdbarch_get_thread_local_address if present instead of
2999         target::get_thread_local_address.
3000
3001 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3002
3003         * target.h (target::get_thread_local_address): Update comment.
3004
3005 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3006
3007         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3008         objfile->separate_debug_objfile_backlink if not NULL.
3009
3010 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3011
3012         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3013         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3014         (amd64bsd_store_inferior_registers): Likewise.
3015         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3016         Enable segment base registers.
3017         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3018         PT_GETFSBASE and PT_GETGSBASE.
3019         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3020         PT_SETGSBASE.
3021         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3022         segment base registers.
3023         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3024
3025 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3026
3027         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3028         Update calls to i386_target_description to add 'segments'
3029         parameter.
3030         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3031         add segment base registers.
3032         * arch/i386.c (i386_create_target_description): Add 'segments'
3033         parameter to enable segment base registers.
3034         * arch/i386.h (i386_create_target_description): Likewise.
3035         * features/i386/32bit-segments.xml: New file.
3036         * features/i386/32bit-segments.c: Generate.
3037         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3038         call to i386_target_description to add 'segments' parameter.
3039         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3040         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3041         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3042         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3043         if feature is present.
3044         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3045         Add 'segments' parameter to call to i386_target_description.
3046         (i386_target_description): Add 'segments' parameter to enable
3047         segment base registers.
3048         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3049         to call to i386_target_description.
3050         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3051         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3052         Define I386_NUM_REGS.
3053         (i386_target_description): Add 'segments' parameter to enable
3054         segment base registers.
3055
3056 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3057
3058         PR/24325
3059         * source-cache.c: #undef open and close, to avoid unresolved
3060         externals during linking.
3061
3062 2019-03-12  Tom Tromey  <tromey@adacore.com>
3063
3064         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3065         const.  Add initializers.
3066         (_initialize_remote): Don't initialize ptid globals.
3067
3068 2019-03-12  Pedro Alves  <palves@redhat.com>
3069
3070         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3071
3072 2019-03-12  Pedro Alves  <palves@redhat.com>
3073
3074         * cp-name-parser.y (main): Remove unused 'len' variable.
3075
3076 2019-03-12  Tom Tromey  <tromey@adacore.com>
3077
3078         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3079         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3080
3081 2019-03-12  Tom Tromey  <tromey@adacore.com>
3082
3083         * linux-nat.c (iterate_over_lwps): Update.
3084         (stop_callback): Remove parameter.
3085         (stop_wait_callback, detach_callback, resume_set_callback)
3086         (select_singlestep_lwp_callback, set_ignore_sigint)
3087         (status_callback, resumed_callback, resume_clear_callback)
3088         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3089         data parameter.
3090         (linux_nat_target::detach, linux_nat_target::resume)
3091         (linux_stop_and_wait_all_lwps, select_event_lwp)
3092         (linux_nat_filter_event, linux_nat_wait_1)
3093         (linux_nat_target::kill, linux_nat_target::stop)
3094         (linux_nat_target::stop): Update.
3095         (linux_nat_resume_callback): Change type.
3096         (resume_stopped_resumed_lwps, count_events_callback)
3097         (select_event_lwp_callback): Likewise.
3098         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3099         * arm-linux-nat.c (struct update_registers_data): Remove.
3100         (update_registers_callback): Change type.
3101         (arm_linux_insert_hw_breakpoint1): Update.
3102         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3103         parameter.
3104         (x86_linux_dr_set_addr): Update.
3105         (x86_linux_dr_set_control): Update.
3106         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3107         (iterate_over_lwps): Use gdb::function_view.
3108         * nat/aarch64-linux-hw-point.c (struct
3109         aarch64_dr_update_callback_param): Remove.
3110         (debug_reg_change_callback): Change type.
3111         (aarch64_notify_debug_reg_change): Update.
3112         * s390-linux-nat.c (s390_refresh_per_info): Update.
3113
3114 2019-03-11  Tom Tromey  <tromey@adacore.com>
3115
3116         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3117         redundant assignment to "this_cu".
3118
3119 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3120
3121         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3122
3123 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3124
3125         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3126         from...
3127         (rank_one_type): ... this.
3128
3129 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3130
3131         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3132         from...
3133         (rank_one_type): ... this.
3134
3135 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3136
3137         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3138         from...
3139         (rank_one_type): ... this.
3140
3141 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3142
3143         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3144         from...
3145         (rank_one_type): ... this.
3146
3147 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3148
3149         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3150         from...
3151         (rank_one_type): ... this.
3152
3153 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3154
3155         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3156         from...
3157         (rank_one_type): ... this.
3158
3159 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3160
3161         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3162         from...
3163         (rank_one_type): ... this.
3164
3165 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3166
3167         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3168         from...
3169         (rank_one_type): ... this.
3170
3171 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3172
3173         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3174         from...
3175         (rank_one_type): ... this.
3176
3177 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3178
3179         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3180         from...
3181         (rank_one_type): ... this.
3182
3183 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3184
3185         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3186         from...
3187         (rank_one_type): ... this.
3188
3189 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3190
3191         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3192         from...
3193         (rank_one_type): ... this.
3194
3195 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3196
3197         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3198         inferior-events' shows the example events.
3199
3200 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3201
3202         Support styling on native MS-Windows console
3203
3204         PR/24315
3205         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3206         on MS-Windows if $TERM is not defined.
3207
3208         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3209
3210         * posix-hdep.c (gdb_console_fputs):
3211         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3212         functions.
3213         * ui-file.h (gdb_console_fputs): Add prototype.
3214
3215         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3216         back to fputs only if the former returns zero.
3217
3218 2019-03-07  Tom Tromey  <tom@tromey.com>
3219
3220         * symmisc.c (print_symbol_bcache_statistics): Update.
3221         (print_objfile_statistics): Update.
3222         * symfile.c (allocate_symtab): Update.
3223         * stabsread.c: Don't include bcache.h.
3224         * psymtab.h (struct psymbol_bcache): Don't declare.
3225         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3226         (psymbol_bcache_init, psymbol_bcache_free)
3227         (psymbol_bcache_get_bcache): Don't declare.
3228         * psymtab.c (struct psymbol_bcache): Remove.
3229         (psymtab_storage::psymtab_storage): Update.
3230         (psymtab_storage::~psymtab_storage): Update.
3231         (psymbol_bcache_init, psymbol_bcache_free)
3232         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3233         (add_psymbol_to_bcache): Update.
3234         (allocate_psymtab): Update.
3235         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3236         macro_cache>: No longer pointers.
3237         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3238         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3239         * macrotab.c (macro_bcache): Update.
3240         * macroexp.c: Don't include bcache.h.
3241         * gdbtypes.c (check_types_worklist): Update.
3242         (types_deeply_equal): Remove TRY/CATCH.  Update.
3243         * elfread.c (elf_symtab_read): Update.
3244         * dwarf2read.c: Don't include bcache.h.
3245         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3246         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3247         (print_bcache_statistics, bcache_memory_used): Don't declare.
3248         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3249         methods.  Rename all data members.
3250         * bcache.c (struct bcache): Move to bcache.h.
3251         (bcache::expand_hash_table): Rename from expand_hash_table.
3252         (bcache): Remove.
3253         (bcache::insert): Rename from bcache_full.
3254         (bcache::compare): Rename from bcache_compare.
3255         (bcache_xmalloc): Remove.
3256         (bcache::~bcache): Rename from bcache_xfree.
3257         (bcache::print_statistics): Rename from print_bcache_statistics.
3258         (bcache::memory_used): Rename from bcache_memory_used.
3259
3260 2019-03-07  Pedro Alves  <palves@redhat.com>
3261
3262         * infrun.c (normal_stop): Also check for
3263         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3264
3265 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3266
3267         * f-lang.c (value_from_host_double): Moved to...
3268         * value.c (value_from_host_double): ...here.
3269         * value.h (value_from_host_double): Declare.
3270         * guile/scm-math.c (vlscm_convert_typed_number): Use
3271         value_from_host_double.
3272         (vlscm_convert_number): Likewise.
3273         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3274         * python/py-value.c (convert_value_from_python): Likewise.
3275
3276 2019-03-06  Tom Tromey  <tom@tromey.com>
3277
3278         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3279
3280 2019-03-06  Tom Tromey  <tom@tromey.com>
3281
3282         * utils.h (free_current_contents): Don't declare.
3283         * utils.c (free_current_contents): Remove.
3284
3285 2019-03-06  Tom Tromey  <tom@tromey.com>
3286
3287         * top.c (quit_force): Update.
3288         * main.c (captured_command_loop): Update.
3289         * common/new-op.c (operator new): Update.
3290         * common/common-exceptions.c (struct catcher)
3291         <save_cleanup_chain>: Remove member.
3292         (exceptions_state_mc_init): Update.
3293         (exception_try_scope_entry): Return nullptr.
3294         (exception_try_scope_exit, exception_rethrow)
3295         (throw_exception_sjlj, throw_exception_cxx): Update.
3296         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3297         (all_cleanups, do_cleanups, discard_cleanups)
3298         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3299         (restore_cleanups, restore_final_cleanups): Don't declare.
3300         (do_final_cleanups): Remove parameter.
3301         * common/cleanups.c (cleanup_chain, make_cleanup)
3302         (make_cleanup_dtor, all_cleanups, do_cleanups)
3303         (discard_my_cleanups, discard_cleanups)
3304         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3305         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3306         (null_cleanup): Remove.
3307         (do_final_cleanups): Remove parameter.
3308
3309 2019-03-06  Tom Tromey  <tom@tromey.com>
3310
3311         * remote.c (remote_target::remote_parse_stop_reply): Use
3312         unique_xmalloc_ptr.
3313
3314 2019-03-06  Tom Tromey  <tom@tromey.com>
3315
3316         * stabsread.c (struct stabs_field_info): Rename from field_info.
3317         <list, fnlist>: Add initializers.
3318         <obstack>: New member.
3319         (read_member_functions, read_struct_fields, read_baseclasses):
3320         Allocate on obstack.  Don't use cleanups.
3321         (read_one_struct_field, read_member_functions, read_struct_fields)
3322         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3323         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3324         (read_struct_type): Update.
3325
3326 2019-03-06  Tom Tromey  <tom@tromey.com>
3327
3328         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3329         * common/filestuff.h (make_cleanup_close): Don't declare.
3330         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3331         Remove.
3332
3333 2019-03-06  Tom Tromey  <tom@tromey.com>
3334
3335         * solib-aix.c: Use make_scope_exit.
3336
3337 2019-03-06  Tom Tromey  <tom@tromey.com>
3338
3339         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3340         Use make_scope_exit.
3341
3342 2019-03-06  Tom Tromey  <tom@tromey.com>
3343
3344         * solib-svr4.c (disable_probes_interface): Remove parameter.
3345         (svr4_handle_solib_event): Use make_scope_exit.
3346
3347 2019-03-06  Tom Tromey  <tom@tromey.com>
3348
3349         * remote.c (struct stop_reply_deleter): Remove.
3350         (stop_reply_up): Update.
3351         (struct stop_reply): Derive from notif_event.  Don't typedef.
3352         <regcache>: Now a std::vector.
3353         (stop_reply_xfree): Remove.
3354         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3355         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3356         (remote_target::discard_pending_stop_replies): Use delete.
3357         (remote_target::remote_parse_stop_reply): Update.
3358         (remote_target::process_stop_reply): Update.
3359         * remote-notif.h (struct notif_event): Add virtual destructor.
3360         Remove "dtr" member.
3361         (struct notif_client) <alloc_event>: Return a unique_ptr.
3362         (notif_event_xfree): Don't declare.
3363         (notif_event_up): New typedef.
3364         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3365         (notif_event_xfree, do_notif_event_xfree): Remove.
3366         (remote_notif_state_xfree): Update.
3367
3368 2019-03-06  Tom Tromey  <tom@tromey.com>
3369
3370         * infrun.c (displaced_step_clear_cleanup): Now a
3371         forward_scope_exit type.
3372         (displaced_step_prepare_throw): Update.
3373         (displaced_step_fixup): Update.
3374
3375 2019-03-06  Tom Tromey  <tom@tromey.com>
3376
3377         * inferior.h (class inferior): Update comment.
3378         * gdbthread.h (class thread_info): Update comment.
3379
3380 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3381             Tom Tromey  <tom@tromey.com>
3382
3383         * stabsread.h (struct stab_section_list): Remove.
3384         (coffstab_build_psymtabs): Update.
3385         * dbxread.c (symbuf_sections): Now a std::vector.
3386         (sect_idx): New global.
3387         (fill_symbuf): Update.
3388         (coffstab_build_psymtabs): Change type of stabsects parameter.
3389         Update.
3390         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3391         std::vector.
3392         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3393         (coff_locate_sections): Update.
3394         (coff_symfile_read): Remove cleanups.  Update.
3395         (init_stringtab): Add storage parameter.
3396         (free_stringtab, free_stringtab_cleanup): Remove.
3397         (init_lineno): Add storage parameter.
3398         (free_linetab, free_linetab_cleanup): Remove.
3399
3400 2019-03-06  Pedro Alves  <palves@redhat.com>
3401
3402         * linux-fork.c (fork_info::clobber_regs): Delete.
3403         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3404         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3405         comment.  Adjust.
3406         (scoped_switch_fork_info::scoped_switch_fork_info)
3407         (checkpoint_command, linux_fork_context): Adjust
3408         fork_save_infrun_state calls.
3409
3410 2019-03-06  Pedro Alves  <palves@redhat.com>
3411
3412         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3413         (inf_has_multiple_threads): Return 'bool' and rewrite using
3414         inferior_info::threads().
3415
3416 2019-03-06  Pedro Alves  <palves@redhat.com>
3417
3418         * linux-fork.c: Include <list>.
3419         (fork_list): Now a std::list instance.
3420         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3421         (forks_exist_p, find_last_fork): Adjust.
3422         (new_fork): Delete.
3423         (one_fork_p): New.
3424         (add_fork): Adjust.
3425         (free_fork): Delete, folded into fork_info::~fork_info().
3426         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3427         Adjust.
3428         (init_fork_list): Delete.
3429         (linux_fork_killall, linux_fork_mourn_inferior)
3430         (linux_fork_detach, info_checkpoints_command): Adjust.
3431         (_initialize_linux_fork): No longer call init_fork_list.
3432
3433 2019-03-06  Pedro Alves  <palves@redhat.com>
3434
3435         * linux-fork.c (new_fork): New, split out of ...
3436         (add_fork): ... this.  Return void.  Move "first fork" special
3437         case from here, to ...
3438         (checkpoint_command): ... here.
3439         * linux-linux.h (add_fork): Return void.
3440
3441 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3442
3443         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
3444
3445 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3446             Chris January  <chris.january@arm.com>
3447             David Lecomber  <david.lecomber@arm.com>
3448
3449         * f-exp.y: New token, UNOP_INTRINSIC.
3450         (exp): New pattern using UNOP_INTRINSIC token.
3451         (f77_keywords): Add 'abs' keyword.
3452         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
3453         (value_from_host_double): New function.
3454         (evaluate_subexp_f): Support UNOP_ABS.
3455
3456 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3457
3458         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
3459         types.
3460
3461 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3462
3463         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
3464         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
3465         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
3466
3467 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3468
3469         * f-exp.y (convert_to_kind_type): Handle more type kinds.
3470
3471 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3472             Chris January  <chris.january@arm.com>
3473
3474         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
3475         * f-exp.y: Define 'KIND' token.
3476         (exp): New pattern for KIND expressions.
3477         (ptype): Handle types with a kind extension.
3478         (direct_abs_decl): Extend to spot kind extensions.
3479         (f77_keywords): Add 'kind' to the list.
3480         (push_kind_type): New function.
3481         (convert_to_kind_type): New function.
3482         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
3483         * parse.c (operator_length_standard): Likewise.
3484         * parser-defs.h (enum type_pieces): Add tp_kind.
3485         * std-operator.def: Add UNOP_KIND.
3486
3487 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3488
3489         * f-exp.y (f_parse): Set yydebug.
3490
3491 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3492
3493         * f-lang.c (evaluate_subexp_f): New function.
3494         (exp_descriptor_f): New global.
3495         (f_language_defn): Use exp_descriptor_f instead of
3496         exp_descriptor_standard.
3497
3498 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3499
3500         * f-exp.y (struct token): Add comments.
3501         (dot_ops): Remove uppercase versions and the end marker.
3502         (f77_keywords): Likewise.
3503         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
3504         entries in the dot_ops array are case insensitive, and use
3505         strncasecmp to compare strings.  Also some whitespace cleanup in
3506         this area.  Similar for the f77_keywords array, except entries in
3507         this list might be case sensitive.
3508
3509 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3510
3511         * f-exp.y (struct f77_boolean_val): Add comments.
3512         (boolean_values): Remove uppercase versions, and end marker.
3513         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
3514         and use strncasecmp to achieve case insensitivity.  Additionally,
3515         perform whitespace cleanup around this code.
3516
3517 2019-03-06  Tom Tromey  <tromey@adacore.com>
3518
3519         * remote-sim.c (gdbsim_target_open): Use result of
3520         gdb_argv::release.
3521
3522 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
3523         Dirk Schubert  <dirk.schubert@arm.com>
3524         Chris January  <chris.january@arm.com>
3525
3526         * eval.c (evaluate_subexp_standard): Call Fortran argument
3527         wrapping logic.
3528         * f-lang.c (struct value): A value which can be passed into a
3529         Fortran function call.
3530         (fortran_argument_convert): Wrap Fortran arguments in a pointer
3531         where appropriate.
3532         (struct type): Value ready for a Fortran function call.
3533         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
3534         is needed.
3535         * f-lang.h (fortran_argument_convert): Declaration.
3536         (fortran_preserve_arg_pointer): Declaration.
3537         * infcall.c (value_arg_coerce): Call Fortran argument logic.
3538
3539 2019-03-05  Tom Tromey  <tromey@adacore.com>
3540
3541         * python/py-prettyprint.c (print_string_repr): Remove #if.
3542         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
3543
3544 2019-03-05  Tom Tromey  <tromey@adacore.com>
3545
3546         * target.c (the_dummy_target): Move later.  Change type to
3547         "dummy_target".
3548         (initialize_targets): Don't initialize the_dummy_target.
3549
3550 2019-03-05  Tom Tromey  <tromey@adacore.com>
3551
3552         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
3553         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
3554
3555 2019-03-05  Tom Tromey  <tromey@adacore.com>
3556
3557         * windows-nat.c (windows_nat_target::attach)
3558         (windows_nat_target::detach): Don't call gdb_flush.
3559         * valprint.c (generic_val_print, val_print, val_print_string):
3560         Don't call gdb_flush.
3561         * utils.c (defaulted_query): Don't call gdb_flush.
3562         * typeprint.c (print_type_scalar): Don't call gdb_flush.
3563         * target.c (target_announce_detach): Don't call gdb_flush.
3564         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
3565         * remote.c (extended_remote_target::attach): Don't call
3566         gdb_flush.
3567         * procfs.c (procfs_target::detach): Don't call gdb_flush.
3568         * printcmd.c (do_examine): Don't call gdb_flush.
3569         (info_display_command): Don't call gdb_flush.
3570         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
3571         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
3572         * memattr.c (info_mem_command): Don't call gdb_flush.
3573         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
3574         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
3575         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
3576         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
3577         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
3578         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
3579         (gnu_nat_target::detach): Don't call gdb_flush.
3580         * f-valprint.c (f_val_print): Don't call gdb_flush.
3581         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
3582         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
3583         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
3584         gdb_flush.
3585         * c-valprint.c (c_val_print): Don't call gdb_flush.
3586         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
3587
3588 2019-03-05  Tom Tromey  <tromey@adacore.com>
3589
3590         * varobj.c (update_dynamic_varobj_children): Update.
3591         (install_default_visualizer): Use reset, not release.
3592         * value.c (set_internalvar): Update.
3593         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
3594         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
3595         ATTRIBUTE_UNUSED_RESULT.
3596
3597 2019-03-05  Tom Tromey  <tromey@adacore.com>
3598
3599         * remote.c (class scoped_remote_fd) <release>: Add
3600         ATTRIBUTE_UNUSED_RESULT.
3601
3602 2019-03-05  Tom Tromey  <tromey@adacore.com>
3603
3604         * macroexp.c (struct macro_buffer) <release>: Add
3605         ATTRIBUTE_UNUSED_RESULT.
3606
3607 2019-03-05  Tom Tromey  <tromey@adacore.com>
3608
3609         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
3610         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
3611         ATTRIBUTE_UNUSED_RESULT.
3612
3613 2019-03-05  Tom Tromey  <tromey@adacore.com>
3614
3615         * common/scoped_fd.h (class scoped_fd) <release>: Add
3616         ATTRIBUTE_UNUSED_RESULT.
3617
3618 2019-03-05  Tom Tromey  <tromey@adacore.com>
3619
3620         * parser-defs.h (struct parser_state) <release>: Add
3621         ATTRIBUTE_UNUSED_RESULT.
3622
3623 2019-03-05  Tom Tromey  <tromey@adacore.com>
3624
3625         * utils.h (class gdb_argv) <release>: Add
3626         ATTRIBUTE_UNUSED_RESULT.
3627         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
3628
3629 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
3630
3631         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
3632         for-loop range, to avoid compiler warnings.
3633
3634         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
3635         avoid compiler warnings about unused variables.
3636
3637         * NEWS: Mention end of support for native debugging on MS-Windows
3638         before XP.
3639
3640         PR gdb/24292
3641         * common/netstuff.c:
3642         * gdbserver/gdbreplay.c
3643         * gdbserver/remote-utils.c:
3644         * ser-tcp.c:
3645         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
3646         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
3647         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
3648         'getaddrinfo' and 'freeaddrinfo' were not available before
3649         Windows XP, and mingw.org's MinGW headers by default define
3650         _WIN32_WINNT to 0x500.
3651
3652 2019-03-01  Gary Benson <gbenson@redhat.com>
3653
3654         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
3655
3656 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
3657             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3658
3659         PR gdb/8527
3660         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
3661         set_sigint_trap, clear_sigint_trap.
3662
3663 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3664
3665         * target.c (target_detach): Clear the regcache and the
3666         frame cache.
3667
3668 2019-02-27  Pedro Alves  <palves@redhat.com>
3669
3670         * utils.c (set_screen_size): When we cap the height/width sizes,
3671         tweak the corresponding command variable to show "unlimited":
3672
3673 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
3674             Pedro Alves  <palves@redhat.com>
3675
3676         * utils.c (set_screen_size): Reduce "infinite" rows and columns
3677         before calling rl_set_screen_size.
3678
3679 2019-02-27  Tom Tromey  <tromey@adacore.com>
3680
3681         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
3682         define.
3683         * python/py-value.c: Remove Python 2.4 workaround.
3684         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
3685         workaround.
3686         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
3687         Python 2.4 workaround.
3688         * python/python-internal.h: Remove Python 2.4 comment.
3689         (Py_ssize_t): Don't define.
3690         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
3691         (gdb_Py_DECREF): Remove Python 2.4 workaround.
3692         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
3693         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
3694         * python/python.c (do_start_initialization): Remove Python 2.4
3695         workaround.
3696         * python/py-prettyprint.c (class dummy_python_frame): Remove.
3697         (print_children): Remove Python 2.4 workaround.
3698         * python/py-inferior.c (buffer_procs): Remove Python 2.4
3699         workaround.
3700         (CHARBUFFERPROC_NAME): Remove.
3701         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
3702         Python 2.4 workaround.
3703
3704 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3705
3706         * NEWS: Note minimum Python version.
3707
3708 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3709
3710         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
3711         code from these functions.  Remove corresponding ifdefs.  Use
3712         Py_buffer_up instead of explicit calls to PyBuffer_Release.
3713         Remove gotos and target of gotos.
3714         (infpy_search_memory): Likewise.
3715
3716 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3717
3718         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
3719         (hppa_gdbarch_init): Don't register deleted functions with
3720         gdbarch.
3721
3722 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3723
3724         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
3725         (h8300_unwind_sp): Delete.
3726         (h8300_dummy_id): Delete.
3727         (h8300_gdbarch_init): Don't register deleted functions with
3728         gdbarch.
3729
3730 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3731
3732         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
3733         (ft32_unwind_pc): Delete.
3734         (ft32_unwind_sp): Delete.
3735         (ft32_gdbarch_init): Don't register deleted functions with
3736         gdbarch.
3737
3738 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3739
3740         * gdb/frv-tdep.c (frv_dummy_id): Delete.
3741         (frv_unwind_pc): Delete.
3742         (frv_unwind_sp): Delete.
3743         (frv_gdbarch_init): Don't register deleted functions with
3744         gdbarch.
3745
3746 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3747
3748         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
3749         (riscv_unwind_pc): Delete.
3750         (riscv_unwind_sp): Delete.
3751         (riscv_gdbarch_init): Don't register deleted functions with
3752         gdbarch.
3753
3754 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3755
3756         * gdb/csky-tdep.c (csky_dummy_id): Delete.
3757         (csky_unwind_pc): Delete.
3758         (csky_unwind_sp): Delete.
3759         (csky_gdbarch_init): Don't register deleted functions with
3760         gdbarch.
3761
3762 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3763
3764         * gdb/cris-tdep.c (cris_dummy_id): Delete.
3765         (cris_unwind_pc): Delete.
3766         (cris_unwind_sp): Delete.
3767         (cris_gdbarch_init): Don't register deleted functions with
3768         gdbarch.
3769
3770 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3771
3772         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
3773         (bfin_unwind_pc): Delete.
3774         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
3775
3776 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3777
3778         * gdb/arm-tdep.c (arm_dummy_id): Delete.
3779         (arm_unwind_pc): Delete.
3780         (arm_unwind_sp): Delete.
3781         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
3782
3783 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3784
3785         * gdb/arc-tdep.c (arc_dummy_id): Delete.
3786         (arc_unwind_pc): Delete.
3787         (arc_unwind_sp): Delete.
3788         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
3789
3790 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3791
3792         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
3793         (alpha_unwind_pc): Delete.
3794         (alpha_gdbarch_init): Don't register deleted functions with
3795         gdbarch.
3796
3797 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3798
3799         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
3800         (aarch64_unwind_pc): Delete.
3801         (aarch64_unwind_sp): Delete.
3802         (aarch64_gdbarch_init): Don't register deleted functions with
3803         gdbarch.
3804
3805 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3806
3807         * gdbtypes.c (type_align): Don't consider static members when
3808         computing structure alignment.
3809
3810 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3811
3812         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
3813         return 0 for other types.
3814         * arch-utils.c (default_type_align): Always return 0.
3815         * gdbarch.h: Regenerate.
3816         * gdbarch.sh (type_align): Extend comment.
3817         * gdbtypes.c (type_align): Add additional comments, always call
3818         gdbarch_type_align before applying the default rules.
3819         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
3820         generic code will then apply a suitable default.
3821         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
3822         types, return 0 for other types.
3823
3824 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3825
3826         * NEWS: Create a new section for the next release branch.
3827         Rename the section of the current branch, now that it has
3828         been cut.
3829
3830 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3831
3832         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
3833         * version.in: Bump version to 8.3.50.DATE-git.
3834
3835 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
3836
3837         * aix-thread.c (ptid_cmp): Remove unused variable.
3838         (get_signaled_thread): Likewise.
3839         (store_regs_user_thread): Likewise.
3840         (store_regs_kernel_thread): Likewise.
3841         (fetch_regs_kernel_thread): Remove shadowed variable.
3842
3843 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3844
3845         * features/riscv/32bit-cpu.xml: Add register numbers.
3846         * features/riscv/32bit-fpu.c: Regenerate.
3847         * features/riscv/32bit-fpu.xml: Add register numbers.
3848         * features/riscv/64bit-cpu.xml: Add register numbers.
3849         * features/riscv/64bit-fpu.c: Regenerate.
3850         * features/riscv/64bit-fpu.xml: Add register numbers.
3851
3852 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
3853
3854         * NEWS: Mention two argument form of gdb.Value constructor.
3855         * python/py-value.c (convert_buffer_and_type_to_value): New
3856         function.
3857         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
3858         Add support for handling an optional second argument.  Call
3859         convert_buffer_and_type_to_value as appropriate.
3860         * python/python-internal.h (Py_buffer_deleter): New struct.
3861         (Py_buffer_up): New typedef.
3862
3863 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
3864
3865         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
3866         instead of releasing ownership.
3867
3868 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
3869
3870         * dwarf2read.c (open_and_init_dwp_file): Call
3871         elf_numsections instead of bfd_count_sections to initialize
3872         dwp_file->num_sections.
3873
3874 2019-02-25  Tom Tromey  <tromey@adacore.com>
3875
3876         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
3877
3878 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3879
3880         * gcore.in: Add '--readnever' option when invoking GDB.
3881
3882 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3883
3884         * MAINTAINERS: Update my email address.
3885
3886 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3887
3888         * build-id.c (build_id_to_debug_bfd_1): New function.
3889         (build_id_to_debug_bfd): Look for separate debug file in
3890         sysroot.
3891
3892 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3893
3894         * gdbarch.sh: Update the copyright year range that is placed into
3895         generated files.
3896
3897 2019-02-22  Keith Seitz  <keiths@redhat.com>
3898
3899         PR symtab/23853
3900         * linespec.c (create_sals_line_offset): Search for the default
3901         symtab's filename instead of its fullname.
3902
3903 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3904
3905         * NEWS: Update style defaults.
3906
3907 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3908
3909         * main.c (captured_main_1): Disable styling in batch mode.
3910
3911 2019-02-20  Tom Tromey  <tom@tromey.com>
3912
3913         * symtab.c (symtab_symbol_info): Fix typos.
3914
3915 2019-02-20  Tom Tromey  <tromey@adacore.com>
3916
3917         * findcmd.c (_initialize_mem_search): Use upper case for
3918         metasyntactic variables.
3919
3920 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
3921
3922         * aarch64-tdep.c (aarch64_add_reggroups): New function.
3923         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
3924
3925 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
3926
3927         * top.h (source_file_name): Change to std::string.
3928         * top.c (source_file_name): Likewise.
3929         (command_line_input): Adjust.
3930         * cli/cli-script.c (script_from_file): Adjust.
3931
3932 2019-02-19  Tom Tromey  <tromey@adacore.com>
3933
3934         * ravenscar-thread.c
3935         (ravenscar_thread_target::update_thread_list): Don't call
3936         ada_build_task_list.
3937         * ada-lang.h (ada_build_task_list): Don't declare.
3938         * ada-tasks.c (struct ada_tasks_inferior_data)
3939         <task_list_valid_p>: Now bool.
3940         (read_known_tasks, ada_task_list_changed)
3941         (ada_tasks_invalidate_inferior_data): Update.
3942         (read_known_tasks_array): Return bool.
3943         (read_known_tasks_list): Likewise.
3944         (read_known_tasks): Return void.
3945         (ada_build_task_list): Now static.
3946
3947 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3948
3949         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
3950         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
3951
3952 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3953
3954         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
3955         variant for ada_tasks_pspace_data_handle and
3956         ada_tasks_inferior_data_handle.
3957         (ada_tasks_pspace_data_cleanup): New function.
3958         (ada_tasks_inferior_data_cleanup): New function.
3959
3960 2019-02-17  Tom Tromey  <tom@tromey.com>
3961
3962         * macrotab.h (macro_source_fullname): Return a std::string.
3963         * macrotab.c (macro_include, check_for_redefinition)
3964         (macro_undef, macro_lookup_definition, foreach_macro)
3965         (foreach_macro_in_scope): Update.
3966         (macro_source_fullname): Return a std::string.
3967         * macrocmd.c (show_pp_source_pos): Update.
3968
3969 2019-02-17  Tom Tromey  <tom@tromey.com>
3970
3971         * macrocmd.c (show_pp_source_pos): Style the file names.
3972
3973 2019-02-17  Tom Tromey  <tom@tromey.com>
3974
3975         PR tui/24197:
3976         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
3977
3978 2019-02-17  Tom Tromey  <tom@tromey.com>
3979
3980         * ada-lang.c (user_select_syms): Use filtered printing.
3981         * utils.c (wrap_style): New global.
3982         (desired_style): Remove.
3983         (emit_style_escape): Add stream parameter.
3984         (set_output_style, reset_terminal_style, prompt_for_continue):
3985         Update.
3986         (flush_wrap_buffer): Only flush gdb_stdout.
3987         (wrap_here): Set wrap_style.
3988         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
3989         treat escape sequences as a character.  Change when wrap buffer is
3990         flushed.
3991         (fputs_styled): Do not set the output style when the default is
3992         requested.
3993         * ui-style.h (struct ui_file_style) <is_default>: New method.
3994         * source.c (print_source_lines_base): Emit escape sequences in one
3995         piece.
3996
3997 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3998
3999         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4000         integers and enumeration types.
4001
4002 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4003
4004         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4005         instead of lookup_symbol_in_language
4006         (do_exact_match): New function.
4007         (ada_get_symbol_name_matcher): Return do_exact_match when
4008         doing a verbatim match.
4009
4010 2019-02-15  Tom Tromey  <tromey@adacore.com>
4011
4012         * ravenscar-thread.c (ravenscar_thread_target::resume)
4013         (ravenscar_thread_target::wait): Special case wildcard requests.
4014
4015 2019-02-15  Tom Tromey  <tromey@adacore.com>
4016
4017         * ravenscar-thread.c (base_ptid): Remove.
4018         (struct ravenscar_thread_target) <close>: New method.
4019         <m_base_ptid>: New member.
4020         <update_inferior_ptid, active_task, task_is_currently_active,
4021         runtime_initialized>: Declare methods.
4022         <ravenscar_thread_target>: Add constructor.
4023         (ravenscar_thread_target::task_is_currently_active)
4024         (ravenscar_thread_target::update_inferior_ptid)
4025         (ravenscar_runtime_initialized): Rename.  Now methods.
4026         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4027         (ravenscar_thread_target::update_thread_list): Update.
4028         (ravenscar_thread_target::active_task): Now method.
4029         (ravenscar_thread_target::store_registers)
4030         (ravenscar_thread_target::prepare_to_store)
4031         (ravenscar_thread_target::prepare_to_store)
4032         (ravenscar_thread_target::mourn_inferior): Update.
4033         (ravenscar_inferior_created): Use "new" to create target.
4034         (ravenscar_thread_target::get_ada_task_ptid): Update.
4035         (_initialize_ravenscar): Don't initialize base_ptid.
4036         (ravenscar_ops): Remove global.
4037
4038 2019-02-15  Tom Tromey  <tromey@adacore.com>
4039
4040         * target.h (push_target): Declare new overload.
4041         * target.c (push_target): New overload, taking an rvalue reference.
4042         * remote.c (remote_target::open_1): Use push_target overload.
4043         * corelow.c (core_target_open): Use push_target overload.
4044
4045 2019-02-15  Tom Tromey  <tromey@adacore.com>
4046
4047         * ravenscar-thread.c (is_ravenscar_task)
4048         (ravenscar_task_is_currently_active): Return bool.
4049         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4050         (_initialize_ravenscar): Remove "(void)".
4051         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4052         Return bool.
4053
4054 2019-02-15  Tom Tromey  <tromey@adacore.com>
4055
4056         * ravenscar-thread.c (ravenscar_runtime_initializer)
4057         (has_ravenscar_runtime, get_running_thread_id)
4058         (ravenscar_thread_target::resume): Fix indentation.
4059
4060 2019-02-15  Tom Tromey  <tromey@adacore.com>
4061
4062         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4063         from ravenscar_arch_ops.
4064         (sparc_ravenscar_ops::fetch_registers)
4065         (sparc_ravenscar_ops::store_registers): Now methods.
4066         (sparc_ravenscar_prepare_to_store): Remove.
4067         (sparc_ravenscar_ops): Redefine.
4068         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4069         methods and destructor.  Remove members.
4070         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4071         (ravenscar_thread_target::store_registers)
4072         (ravenscar_thread_target::prepare_to_store): Update.
4073         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4074         Remove.
4075         (struct ppc_ravenscar_powerpc_ops): Derive from
4076         ravenscar_arch_ops.
4077         (ppc_ravenscar_powerpc_ops::fetch_registers)
4078         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4079         (ppc_ravenscar_powerpc_ops): Redefine.
4080         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4081         (ppc_ravenscar_e500_ops::fetch_registers)
4082         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4083         (ppc_ravenscar_e500_ops): Redefine.
4084         * aarch64-ravenscar-thread.c
4085         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4086         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4087         (aarch64_ravenscar_fetch_registers)
4088         (aarch64_ravenscar_store_registers): Now methods.
4089         (aarch64_ravenscar_ops): Redefine.
4090
4091 2019-02-15  Tom Tromey  <tromey@adacore.com>
4092
4093         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4094         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4095         (ravenscar_thread_target::stopped_by_watchpoint)
4096         (ravenscar_thread_target::stopped_data_address)
4097         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4098
4099 2019-02-15  Tom Tromey  <tromey@adacore.com>
4100
4101         * ravenscar-thread.c: Fix some typos.
4102
4103 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4104             Tom Tromey  <tromey@adacore.com>
4105
4106         * ada-lang.c (ada_exception_sal): Change addr_string to a
4107         std::string.
4108         (create_ada_exception_catchpoint): Update.
4109
4110 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4111             Tom Tromey  <tromey@adacore.com>
4112
4113         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4114         (bp_location_ops): Remove.
4115         (base_breakpoint_allocate_location): Update.
4116         (free_bp_location): Update.
4117         * ada-lang.c (class ada_catchpoint_location)
4118         <ada_catchpoint_location>: Remove ops parameter.
4119         (ada_catchpoint_location_dtor): Remove.
4120         (ada_catchpoint_location_ops): Remove.
4121         (allocate_location_exception): Update.
4122         * breakpoint.h (struct bp_location_ops): Remove.
4123         (class bp_location) <bp_location>: Remove bp_location_ops
4124         parameter.
4125         <~bp_location>: Add destructor.
4126         <ops>: Remove.
4127
4128 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4129             Pedro Alves  <palves@redhat.com>
4130
4131         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4132         'PATH_MAX'.
4133
4134 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4135             Samuel Thibault  <samuel.thibault@gnu.org>
4136             Thomas Schwinge  <thomas@codesourcery.com>
4137
4138         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4139         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4140
4141 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4142
4143         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4144         (check_empty): Use "const char *".
4145
4146         * gnu-nat.c (gnu_nat_target::detach): Instead of
4147         'detach_inferior (pid)' call
4148         'detach_inferior (find_inferior_pid (pid))'.
4149
4150         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4151         'nat/fork-inferior.o'.
4152         * gnu-nat.c: #include "nat/fork-inferior.h".
4153
4154         * gnu-nat.c (gnu_nat_target::detach): Instead of
4155         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4156         * gnu-nat.h: #include "inf-child.h".
4157         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4158         'i386_gnu_nat_target::fetch_registers'.
4159         (gnu_store_registers): Rename/move to
4160         'i386_gnu_nat_target::store_registers'.
4161
4162         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4163         * gnu-nat.h (mach_thread_info): New function.
4164         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4165
4166         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4167
4168 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4169
4170         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4171
4172 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4173
4174         * windows-nat.c (windows_add_thread): Add new parameter
4175         "main_thread_p" with default value set to false.  Update
4176         function documentation as well as all callers.
4177         (windows_delete_thread): Likewise.
4178         (fake_create_process): Update call to windows_add_thread.
4179         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4180         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4181         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4182         call to windows_delete_thread.
4183
4184 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4185
4186         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4187
4188 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4189
4190         * symfile.c (find_separate_debug_file): Use canonical path of
4191         sysroot with child_path instead of gdb_sysroot if it is valid.
4192
4193 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4194
4195         * symfile.c (find_separate_debug_file): Use child_path to
4196         determine if an object file is under a sysroot.
4197
4198 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4199
4200         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4201         unittests/child-path-selftests.c.
4202         * common/pathstuff.c (child_path): New function.
4203         * common/pathstuff.h (child_path): New prototype.
4204         * unittests/child-path-selftests.c: New file.
4205
4206 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4207
4208         * symfile.c (find_separate_debug_file): Look for separate debug
4209         files in debug directories under the sysroot.
4210
4211 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4212
4213         * symtab.h (struct minimal_symbol data_p): New const method.
4214         (struct minimal_symbol text_p): Likewise.
4215         * symtab.c (output_source_filename): Use file name style
4216         to print file name.
4217         (print_symbol_info): Likewise.
4218         (print_msymbol_info): Use address style to print addresses.
4219         Use function name style to print executable text symbols.
4220         (expand_symtab_containing_pc): Use data_p.
4221         (find_pc_sect_compunit_symtab): Likewise.
4222
4223 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4224
4225         * breakpoint.c (describe_other_breakpoints): Use address style
4226         to print addresses.
4227         (say_where): Likewise.
4228
4229 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4230
4231         * ada-typeprint.c (print_func_type): Print function name
4232         style to print function name.
4233         * c-typeprint.c (c_print_type_1): Likewise.
4234
4235 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4236
4237         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4238         for execve.
4239
4240 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4241
4242         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4243         type_stack.
4244
4245 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4246
4247         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4248         TYPE_CODE_REF types.
4249
4250 2019-02-08  Jim Wilson  <jimw@sifive.com>
4251
4252         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4253         (riscv_linux_fregset): New.
4254         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4255
4256 2019-02-07  Tom Tromey  <tom@tromey.com>
4257
4258         * thread.c (thread_cancel_execution_command): Update.
4259         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4260         methods.
4261         (struct thread_fsm_ops): Remove.
4262         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4263         (thread_fsm_should_stop, thread_fsm_return_value)
4264         (thread_fsm_set_finished, thread_fsm_finished_p)
4265         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4266         Don't declare.
4267         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4268         * infrun.c (clear_proceed_status_thread)
4269         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4270         (print_stop_event): Update.
4271         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4272         Add constructor.
4273         (step_command_fsm_ops): Remove.
4274         (new_step_command_fsm): Remove.
4275         (step_1): Update.
4276         (step_command_fsm::should_stop): Rename from
4277         step_command_fsm_should_stop.
4278         (step_command_fsm::clean_up): Rename from
4279         step_command_fsm_clean_up.
4280         (step_command_fsm::do_async_reply_reason): Rename from
4281         step_command_fsm_async_reply_reason.
4282         (struct until_next_fsm): Inherit from thread_fsm.  Add
4283         constructor.
4284         (until_next_fsm_ops): Remove.
4285         (new_until_next_fsm): Remove.
4286         (until_next_fsm::should_stop): Rename from
4287         until_next_fsm_should_stop.
4288         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4289         (until_next_fsm::do_async_reply_reason): Rename from
4290         until_next_fsm_async_reply_reason.
4291         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4292         constructor.  Change type of breakpoint.
4293         (finish_command_fsm_ops): Remove.
4294         (new_finish_command_fsm): Remove.
4295         (finish_command_fsm::should_stop): Rename from
4296         finish_command_fsm_should_stop.
4297         (finish_command_fsm::clean_up): Rename from
4298         finish_command_fsm_clean_up.
4299         (finish_command_fsm::return_value): Rename from
4300         finish_command_fsm_return_value.
4301         (finish_command_fsm::do_async_reply_reason): Rename from
4302         finish_command_fsm_async_reply_reason.
4303         (finish_command): Update.
4304         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4305         Add constructor.
4306         (call_thread_fsm_ops): Remove.
4307         (call_thread_fsm::call_thread_fsm): Rename from
4308         new_call_thread_fsm.
4309         (call_thread_fsm::should_stop): Rename from
4310         call_thread_fsm_should_stop.
4311         (call_thread_fsm::should_notify_stop): Rename from
4312         call_thread_fsm_should_notify_stop.
4313         (run_inferior_call, call_function_by_hand_dummy): Update.
4314         * cli/cli-interp.c (should_print_stop_to_console): Update.
4315         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4316         Add constructor.  Change type of location_breakpoint,
4317         caller_breakpoint.
4318         (until_break_fsm_ops): Remove.
4319         (new_until_break_fsm): Remove.
4320         (until_break_fsm::should_stop): Rename from
4321         until_break_fsm_should_stop.
4322         (until_break_fsm::clean_up): Rename from
4323         until_break_fsm_clean_up.
4324         (until_break_fsm::do_async_reply_reason): Rename from
4325         until_break_fsm_async_reply_reason.
4326         (until_break_command): Update.
4327         * thread-fsm.c: Remove.
4328         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4329
4330 2019-02-07  Tom Tromey  <tom@tromey.com>
4331
4332         * yy-remap.h: Add include guard.
4333         * xtensa-tdep.h: Add include guard.
4334         * xcoffread.h: Rename include guard.
4335         * varobj-iter.h: Add include guard.
4336         * tui/tui.h: Rename include guard.
4337         * tui/tui-winsource.h: Rename include guard.
4338         * tui/tui-wingeneral.h: Rename include guard.
4339         * tui/tui-windata.h: Rename include guard.
4340         * tui/tui-win.h: Rename include guard.
4341         * tui/tui-stack.h: Rename include guard.
4342         * tui/tui-source.h: Rename include guard.
4343         * tui/tui-regs.h: Rename include guard.
4344         * tui/tui-out.h: Rename include guard.
4345         * tui/tui-layout.h: Rename include guard.
4346         * tui/tui-io.h: Rename include guard.
4347         * tui/tui-hooks.h: Rename include guard.
4348         * tui/tui-file.h: Rename include guard.
4349         * tui/tui-disasm.h: Rename include guard.
4350         * tui/tui-data.h: Rename include guard.
4351         * tui/tui-command.h: Rename include guard.
4352         * tic6x-tdep.h: Add include guard.
4353         * target/waitstatus.h: Rename include guard.
4354         * target/wait.h: Rename include guard.
4355         * target/target.h: Rename include guard.
4356         * target/resume.h: Rename include guard.
4357         * target-float.h: Rename include guard.
4358         * stabsread.h: Add include guard.
4359         * rs6000-tdep.h: Add include guard.
4360         * riscv-fbsd-tdep.h: Add include guard.
4361         * regformats/regdef.h: Rename include guard.
4362         * record.h: Rename include guard.
4363         * python/python.h: Rename include guard.
4364         * python/python-internal.h: Rename include guard.
4365         * python/py-stopevent.h: Rename include guard.
4366         * python/py-ref.h: Rename include guard.
4367         * python/py-record.h: Rename include guard.
4368         * python/py-record-full.h: Rename include guard.
4369         * python/py-record-btrace.h: Rename include guard.
4370         * python/py-instruction.h: Rename include guard.
4371         * python/py-events.h: Rename include guard.
4372         * python/py-event.h: Rename include guard.
4373         * procfs.h: Add include guard.
4374         * proc-utils.h: Add include guard.
4375         * p-lang.h: Add include guard.
4376         * or1k-tdep.h: Rename include guard.
4377         * observable.h: Rename include guard.
4378         * nto-tdep.h: Rename include guard.
4379         * nat/x86-linux.h: Rename include guard.
4380         * nat/x86-linux-dregs.h: Rename include guard.
4381         * nat/x86-gcc-cpuid.h: Add include guard.
4382         * nat/x86-dregs.h: Rename include guard.
4383         * nat/x86-cpuid.h: Rename include guard.
4384         * nat/ppc-linux.h: Rename include guard.
4385         * nat/mips-linux-watch.h: Rename include guard.
4386         * nat/linux-waitpid.h: Rename include guard.
4387         * nat/linux-ptrace.h: Rename include guard.
4388         * nat/linux-procfs.h: Rename include guard.
4389         * nat/linux-osdata.h: Rename include guard.
4390         * nat/linux-nat.h: Rename include guard.
4391         * nat/linux-namespaces.h: Rename include guard.
4392         * nat/linux-btrace.h: Rename include guard.
4393         * nat/glibc_thread_db.h: Rename include guard.
4394         * nat/gdb_thread_db.h: Rename include guard.
4395         * nat/gdb_ptrace.h: Rename include guard.
4396         * nat/fork-inferior.h: Rename include guard.
4397         * nat/amd64-linux-siginfo.h: Rename include guard.
4398         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4399         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4400         * nat/aarch64-linux.h: Rename include guard.
4401         * nat/aarch64-linux-hw-point.h: Rename include guard.
4402         * mn10300-tdep.h: Add include guard.
4403         * mips-linux-tdep.h: Add include guard.
4404         * mi/mi-parse.h: Rename include guard.
4405         * mi/mi-out.h: Rename include guard.
4406         * mi/mi-main.h: Rename include guard.
4407         * mi/mi-interp.h: Rename include guard.
4408         * mi/mi-getopt.h: Rename include guard.
4409         * mi/mi-console.h: Rename include guard.
4410         * mi/mi-common.h: Rename include guard.
4411         * mi/mi-cmds.h: Rename include guard.
4412         * mi/mi-cmd-break.h: Rename include guard.
4413         * m2-lang.h: Add include guard.
4414         * location.h: Rename include guard.
4415         * linux-record.h: Rename include guard.
4416         * linux-nat.h: Add include guard.
4417         * linux-fork.h: Add include guard.
4418         * i386-darwin-tdep.h: Rename include guard.
4419         * hppa-linux-offsets.h: Add include guard.
4420         * guile/guile.h: Rename include guard.
4421         * guile/guile-internal.h: Rename include guard.
4422         * gnu-nat.h: Rename include guard.
4423         * gdb-stabs.h: Rename include guard.
4424         * frv-tdep.h: Add include guard.
4425         * f-lang.h: Add include guard.
4426         * event-loop.h: Add include guard.
4427         * darwin-nat.h: Rename include guard.
4428         * cp-abi.h: Rename include guard.
4429         * config/sparc/nm-sol2.h: Rename include guard.
4430         * config/nm-nto.h: Rename include guard.
4431         * config/nm-linux.h: Add include guard.
4432         * config/i386/nm-i386gnu.h: Rename include guard.
4433         * config/djgpp/nl_types.h: Rename include guard.
4434         * config/djgpp/langinfo.h: Rename include guard.
4435         * compile/gcc-cp-plugin.h: Add include guard.
4436         * compile/gcc-c-plugin.h: Add include guard.
4437         * compile/compile.h: Rename include guard.
4438         * compile/compile-object-run.h: Rename include guard.
4439         * compile/compile-object-load.h: Rename include guard.
4440         * compile/compile-internal.h: Rename include guard.
4441         * compile/compile-cplus.h: Rename include guard.
4442         * compile/compile-c.h: Rename include guard.
4443         * common/xml-utils.h: Rename include guard.
4444         * common/x86-xstate.h: Rename include guard.
4445         * common/version.h: Rename include guard.
4446         * common/vec.h: Rename include guard.
4447         * common/tdesc.h: Rename include guard.
4448         * common/selftest.h: Rename include guard.
4449         * common/scoped_restore.h: Rename include guard.
4450         * common/scoped_mmap.h: Rename include guard.
4451         * common/scoped_fd.h: Rename include guard.
4452         * common/safe-iterator.h: Rename include guard.
4453         * common/run-time-clock.h: Rename include guard.
4454         * common/refcounted-object.h: Rename include guard.
4455         * common/queue.h: Rename include guard.
4456         * common/ptid.h: Rename include guard.
4457         * common/print-utils.h: Rename include guard.
4458         * common/preprocessor.h: Rename include guard.
4459         * common/pathstuff.h: Rename include guard.
4460         * common/observable.h: Rename include guard.
4461         * common/netstuff.h: Rename include guard.
4462         * common/job-control.h: Rename include guard.
4463         * common/host-defs.h: Rename include guard.
4464         * common/gdb_wait.h: Rename include guard.
4465         * common/gdb_vecs.h: Rename include guard.
4466         * common/gdb_unlinker.h: Rename include guard.
4467         * common/gdb_unique_ptr.h: Rename include guard.
4468         * common/gdb_tilde_expand.h: Rename include guard.
4469         * common/gdb_sys_time.h: Rename include guard.
4470         * common/gdb_string_view.h: Rename include guard.
4471         * common/gdb_splay_tree.h: Rename include guard.
4472         * common/gdb_setjmp.h: Rename include guard.
4473         * common/gdb_ref_ptr.h: Rename include guard.
4474         * common/gdb_optional.h: Rename include guard.
4475         * common/gdb_locale.h: Rename include guard.
4476         * common/gdb_assert.h: Rename include guard.
4477         * common/filtered-iterator.h: Rename include guard.
4478         * common/filestuff.h: Rename include guard.
4479         * common/fileio.h: Rename include guard.
4480         * common/environ.h: Rename include guard.
4481         * common/common-utils.h: Rename include guard.
4482         * common/common-types.h: Rename include guard.
4483         * common/common-regcache.h: Rename include guard.
4484         * common/common-inferior.h: Rename include guard.
4485         * common/common-gdbthread.h: Rename include guard.
4486         * common/common-exceptions.h: Rename include guard.
4487         * common/common-defs.h: Rename include guard.
4488         * common/common-debug.h: Rename include guard.
4489         * common/cleanups.h: Rename include guard.
4490         * common/buffer.h: Rename include guard.
4491         * common/btrace-common.h: Rename include guard.
4492         * common/break-common.h: Rename include guard.
4493         * cli/cli-utils.h: Rename include guard.
4494         * cli/cli-style.h: Rename include guard.
4495         * cli/cli-setshow.h: Rename include guard.
4496         * cli/cli-script.h: Rename include guard.
4497         * cli/cli-interp.h: Rename include guard.
4498         * cli/cli-decode.h: Rename include guard.
4499         * cli/cli-cmds.h: Rename include guard.
4500         * charset-list.h: Add include guard.
4501         * buildsym-legacy.h: Rename include guard.
4502         * bfin-tdep.h: Add include guard.
4503         * ax.h: Rename include guard.
4504         * arm-linux-tdep.h: Add include guard.
4505         * arm-fbsd-tdep.h: Add include guard.
4506         * arch/xtensa.h: Rename include guard.
4507         * arch/tic6x.h: Add include guard.
4508         * arch/i386.h: Add include guard.
4509         * arch/arm.h: Rename include guard.
4510         * arch/arm-linux.h: Rename include guard.
4511         * arch/arm-get-next-pcs.h: Rename include guard.
4512         * arch/amd64.h: Add include guard.
4513         * arch/aarch64-insn.h: Rename include guard.
4514         * arch-utils.h: Rename include guard.
4515         * annotate.h: Add include guard.
4516         * amd64-darwin-tdep.h: Rename include guard.
4517         * aarch64-linux-tdep.h: Add include guard.
4518         * aarch64-fbsd-tdep.h: Add include guard.
4519         * aarch32-linux-nat.h: Add include guard.
4520
4521 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4522
4523         * macrotab.c (macro_define_internal): New function that
4524         factorizes macro_define_object_internal and macro_define_function
4525         code.
4526         (macro_define_object_internal): Use macro_define_internal.
4527         (macro_define_function): Likewise.
4528
4529 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4530
4531         * macrocmd.c (extract_identifier): Return
4532         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
4533         callers.
4534
4535 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
4536
4537         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
4538
4539 2019-02-05  Tom Tromey  <tom@tromey.com>
4540
4541         * target.c (target_stack::unpush): Move assertion earlier.
4542
4543 2019-01-30  Tom Tromey  <tom@tromey.com>
4544
4545         PR python/23615:
4546         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
4547         (gdbpy_parse_and_eval): Likewise.
4548         * python/python-internal.h (gdbpy_allow_threads): New class.
4549
4550 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
4551
4552         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
4553         (aarch64_fbsd_fpregmap): Move earlier.
4554         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
4555         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4556         instead of individual calls to trad_frame_set_reg_addr.
4557         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
4558         earlier.
4559         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
4560         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4561         instead of individual calls to trad_frame_set_reg_addr.
4562
4563 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
4564
4565         * CONTRIBUTE: Replace contribution list with wiki link.
4566
4567 2019-01-25  Tom Tromey  <tom@tromey.com>
4568
4569         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
4570
4571 2019-01-25  Tom Tromey  <tom@tromey.com>
4572
4573         * xtensa-linux-nat.c: Fix common/ includes.
4574         * xml-support.h: Fix common/ includes.
4575         * xml-support.c: Fix common/ includes.
4576         * x86-linux-nat.c: Fix common/ includes.
4577         * windows-nat.c: Fix common/ includes.
4578         * varobj.h: Fix common/ includes.
4579         * varobj.c: Fix common/ includes.
4580         * value.c: Fix common/ includes.
4581         * valops.c: Fix common/ includes.
4582         * utils.c: Fix common/ includes.
4583         * unittests/xml-utils-selftests.c: Fix common/ includes.
4584         * unittests/utils-selftests.c: Fix common/ includes.
4585         * unittests/unpack-selftests.c: Fix common/ includes.
4586         * unittests/tracepoint-selftests.c: Fix common/ includes.
4587         * unittests/style-selftests.c: Fix common/ includes.
4588         * unittests/string_view-selftests.c: Fix common/ includes.
4589         * unittests/scoped_restore-selftests.c: Fix common/ includes.
4590         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
4591         * unittests/scoped_fd-selftests.c: Fix common/ includes.
4592         * unittests/rsp-low-selftests.c: Fix common/ includes.
4593         * unittests/parse-connection-spec-selftests.c: Fix common/
4594         includes.
4595         * unittests/optional-selftests.c: Fix common/ includes.
4596         * unittests/offset-type-selftests.c: Fix common/ includes.
4597         * unittests/observable-selftests.c: Fix common/ includes.
4598         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
4599         * unittests/memrange-selftests.c: Fix common/ includes.
4600         * unittests/memory-map-selftests.c: Fix common/ includes.
4601         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
4602         * unittests/function-view-selftests.c: Fix common/ includes.
4603         * unittests/environ-selftests.c: Fix common/ includes.
4604         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
4605         * unittests/common-utils-selftests.c: Fix common/ includes.
4606         * unittests/cli-utils-selftests.c: Fix common/ includes.
4607         * unittests/array-view-selftests.c: Fix common/ includes.
4608         * ui-file.c: Fix common/ includes.
4609         * tui/tui-io.c: Fix common/ includes.
4610         * tracepoint.h: Fix common/ includes.
4611         * tracepoint.c: Fix common/ includes.
4612         * tracefile-tfile.c: Fix common/ includes.
4613         * top.h: Fix common/ includes.
4614         * top.c: Fix common/ includes.
4615         * thread.c: Fix common/ includes.
4616         * target/waitstatus.h: Fix common/ includes.
4617         * target/waitstatus.c: Fix common/ includes.
4618         * target.h: Fix common/ includes.
4619         * target.c: Fix common/ includes.
4620         * target-memory.c: Fix common/ includes.
4621         * target-descriptions.c: Fix common/ includes.
4622         * symtab.h: Fix common/ includes.
4623         * symfile.c: Fix common/ includes.
4624         * stap-probe.c: Fix common/ includes.
4625         * spu-linux-nat.c: Fix common/ includes.
4626         * sparc-nat.c: Fix common/ includes.
4627         * source.c: Fix common/ includes.
4628         * solib.c: Fix common/ includes.
4629         * solib-target.c: Fix common/ includes.
4630         * ser-unix.c: Fix common/ includes.
4631         * ser-tcp.c: Fix common/ includes.
4632         * ser-pipe.c: Fix common/ includes.
4633         * ser-base.c: Fix common/ includes.
4634         * selftest-arch.c: Fix common/ includes.
4635         * s12z-tdep.c: Fix common/ includes.
4636         * rust-exp.y: Fix common/ includes.
4637         * rs6000-aix-tdep.c: Fix common/ includes.
4638         * riscv-tdep.c: Fix common/ includes.
4639         * remote.c: Fix common/ includes.
4640         * remote-notif.h: Fix common/ includes.
4641         * remote-fileio.h: Fix common/ includes.
4642         * remote-fileio.c: Fix common/ includes.
4643         * regcache.h: Fix common/ includes.
4644         * regcache.c: Fix common/ includes.
4645         * record-btrace.c: Fix common/ includes.
4646         * python/python.c: Fix common/ includes.
4647         * python/py-type.c: Fix common/ includes.
4648         * python/py-inferior.c: Fix common/ includes.
4649         * progspace.h: Fix common/ includes.
4650         * producer.c: Fix common/ includes.
4651         * procfs.c: Fix common/ includes.
4652         * proc-api.c: Fix common/ includes.
4653         * printcmd.c: Fix common/ includes.
4654         * ppc-linux-nat.c: Fix common/ includes.
4655         * parser-defs.h: Fix common/ includes.
4656         * osdata.c: Fix common/ includes.
4657         * obsd-nat.c: Fix common/ includes.
4658         * nat/x86-linux.c: Fix common/ includes.
4659         * nat/x86-linux-dregs.c: Fix common/ includes.
4660         * nat/x86-dregs.h: Fix common/ includes.
4661         * nat/x86-dregs.c: Fix common/ includes.
4662         * nat/ppc-linux.c: Fix common/ includes.
4663         * nat/mips-linux-watch.h: Fix common/ includes.
4664         * nat/mips-linux-watch.c: Fix common/ includes.
4665         * nat/linux-waitpid.c: Fix common/ includes.
4666         * nat/linux-ptrace.h: Fix common/ includes.
4667         * nat/linux-ptrace.c: Fix common/ includes.
4668         * nat/linux-procfs.c: Fix common/ includes.
4669         * nat/linux-personality.c: Fix common/ includes.
4670         * nat/linux-osdata.c: Fix common/ includes.
4671         * nat/linux-namespaces.c: Fix common/ includes.
4672         * nat/linux-btrace.h: Fix common/ includes.
4673         * nat/linux-btrace.c: Fix common/ includes.
4674         * nat/fork-inferior.c: Fix common/ includes.
4675         * nat/amd64-linux-siginfo.c: Fix common/ includes.
4676         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
4677         * nat/aarch64-linux.c: Fix common/ includes.
4678         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
4679         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
4680         * namespace.h: Fix common/ includes.
4681         * mips-linux-tdep.c: Fix common/ includes.
4682         * minsyms.c: Fix common/ includes.
4683         * mi/mi-parse.h: Fix common/ includes.
4684         * mi/mi-main.c: Fix common/ includes.
4685         * mi/mi-cmd-env.c: Fix common/ includes.
4686         * memrange.h: Fix common/ includes.
4687         * memattr.c: Fix common/ includes.
4688         * maint.h: Fix common/ includes.
4689         * maint.c: Fix common/ includes.
4690         * main.c: Fix common/ includes.
4691         * machoread.c: Fix common/ includes.
4692         * location.c: Fix common/ includes.
4693         * linux-thread-db.c: Fix common/ includes.
4694         * linux-nat.c: Fix common/ includes.
4695         * linux-fork.c: Fix common/ includes.
4696         * inline-frame.c: Fix common/ includes.
4697         * infrun.c: Fix common/ includes.
4698         * inflow.c: Fix common/ includes.
4699         * inferior.h: Fix common/ includes.
4700         * inferior.c: Fix common/ includes.
4701         * infcmd.c: Fix common/ includes.
4702         * inf-ptrace.c: Fix common/ includes.
4703         * inf-child.c: Fix common/ includes.
4704         * ia64-linux-nat.c: Fix common/ includes.
4705         * i387-tdep.c: Fix common/ includes.
4706         * i386-tdep.c: Fix common/ includes.
4707         * i386-linux-tdep.c: Fix common/ includes.
4708         * i386-linux-nat.c: Fix common/ includes.
4709         * i386-go32-tdep.c: Fix common/ includes.
4710         * i386-fbsd-tdep.c: Fix common/ includes.
4711         * i386-fbsd-nat.c: Fix common/ includes.
4712         * guile/scm-type.c: Fix common/ includes.
4713         * guile/guile.c: Fix common/ includes.
4714         * go32-nat.c: Fix common/ includes.
4715         * gnu-nat.c: Fix common/ includes.
4716         * gdbthread.h: Fix common/ includes.
4717         * gdbarch-selftests.c: Fix common/ includes.
4718         * gdb_usleep.c: Fix common/ includes.
4719         * gdb_select.h: Fix common/ includes.
4720         * gdb_bfd.c: Fix common/ includes.
4721         * gcore.c: Fix common/ includes.
4722         * fork-child.c: Fix common/ includes.
4723         * findvar.c: Fix common/ includes.
4724         * fbsd-nat.c: Fix common/ includes.
4725         * event-top.c: Fix common/ includes.
4726         * event-loop.c: Fix common/ includes.
4727         * dwarf2read.c: Fix common/ includes.
4728         * dwarf2loc.c: Fix common/ includes.
4729         * dwarf2-frame.c: Fix common/ includes.
4730         * dwarf-index-cache.c: Fix common/ includes.
4731         * dtrace-probe.c: Fix common/ includes.
4732         * disasm-selftests.c: Fix common/ includes.
4733         * defs.h: Fix common/ includes.
4734         * csky-tdep.c: Fix common/ includes.
4735         * cp-valprint.c: Fix common/ includes.
4736         * cp-support.h: Fix common/ includes.
4737         * cp-support.c: Fix common/ includes.
4738         * corelow.c: Fix common/ includes.
4739         * completer.h: Fix common/ includes.
4740         * completer.c: Fix common/ includes.
4741         * compile/compile.c: Fix common/ includes.
4742         * compile/compile-loc2c.c: Fix common/ includes.
4743         * compile/compile-cplus-types.c: Fix common/ includes.
4744         * compile/compile-cplus-symbols.c: Fix common/ includes.
4745         * command.h: Fix common/ includes.
4746         * cli/cli-dump.c: Fix common/ includes.
4747         * cli/cli-cmds.c: Fix common/ includes.
4748         * charset.c: Fix common/ includes.
4749         * build-id.c: Fix common/ includes.
4750         * btrace.h: Fix common/ includes.
4751         * btrace.c: Fix common/ includes.
4752         * breakpoint.h: Fix common/ includes.
4753         * breakpoint.c: Fix common/ includes.
4754         * ax.h:
4755         (enum agent_op): Fix common/ includes.
4756         * ax-general.c (struct aop_map): Fix common/ includes.
4757         * ax-gdb.c: Fix common/ includes.
4758         * auxv.c: Fix common/ includes.
4759         * auto-load.c: Fix common/ includes.
4760         * arm-tdep.c: Fix common/ includes.
4761         * arch/riscv.c: Fix common/ includes.
4762         * arch/ppc-linux-common.c: Fix common/ includes.
4763         * arch/i386.c: Fix common/ includes.
4764         * arch/arm.c: Fix common/ includes.
4765         * arch/arm-linux.c: Fix common/ includes.
4766         * arch/arm-get-next-pcs.c: Fix common/ includes.
4767         * arch/amd64.c: Fix common/ includes.
4768         * arch/aarch64.c: Fix common/ includes.
4769         * arch/aarch64-insn.c: Fix common/ includes.
4770         * arch-utils.c: Fix common/ includes.
4771         * amd64-windows-tdep.c: Fix common/ includes.
4772         * amd64-tdep.c: Fix common/ includes.
4773         * amd64-sol2-tdep.c: Fix common/ includes.
4774         * amd64-obsd-tdep.c: Fix common/ includes.
4775         * amd64-nbsd-tdep.c: Fix common/ includes.
4776         * amd64-linux-tdep.c: Fix common/ includes.
4777         * amd64-linux-nat.c: Fix common/ includes.
4778         * amd64-fbsd-tdep.c: Fix common/ includes.
4779         * amd64-fbsd-nat.c: Fix common/ includes.
4780         * amd64-dicos-tdep.c: Fix common/ includes.
4781         * amd64-darwin-tdep.c: Fix common/ includes.
4782         * agent.c: Fix common/ includes.
4783         * ada-lang.h: Fix common/ includes.
4784         * ada-lang.c: Fix common/ includes.
4785         * aarch64-tdep.c: Fix common/ includes.
4786
4787 2019-01-25  Tom Tromey  <tom@tromey.com>
4788
4789         * common/create-version.sh: Use common/version.h.
4790
4791 2019-01-24  Pedro Alves  <palves@redhat.com>
4792
4793         * infrun.c (signal_stop, signal_print, signal_program)
4794         (signal_catch, signal_pass): Now arrays instead of pointers.
4795         (update_signals_program_target, do_target_resume)
4796         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
4797         * linux-nat.c (linux_nat_target::pass_signals)
4798         (linux_nat_target::create_inferior, linux_nat_target::attach):
4799         Adjust.
4800         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
4801         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
4802         * procfs.c (procfs_target::pass_signals): Adjust.
4803         * record-full.c (record_full_target::resume): Adjust.
4804         * remote.c (remote_target::pass_signals)
4805         (remote_target::program_signals): Adjust.
4806         * target-debug.h (target_debug_print_signals): Now takes a
4807         gdb::array_view as parameter.  Adjust.
4808         * target.h (target_ops) <pass_signals, program_signals>: Replace
4809         pointer and length parameters with gdb::array_view.
4810         (target_pass_signals, target_program_signals): Likewise.
4811         * target-delegates.c: Regenerate.
4812
4813 2019-01-24  Pedro Alves  <palves@redhat.com>
4814
4815         * common/forward-scope-exit.h
4816         (forward_scope_exit::forward_scope_exit): Pass arguments to
4817         m_bind_function directly, instead of creating a std::bind and
4818         copying that.
4819
4820 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
4821
4822         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4823         for static members.
4824         (pass_in_v_vfp_candidate): Likewise.
4825
4826 2019-01-23  Tom Tromey  <tom@tromey.com>
4827             Pedro Alves  <palves@redhat.com>
4828
4829         * regcache.c (class regcache_invalidator): Remove.
4830         (regcache::raw_write): Use make_scope_exit.
4831
4832 2019-01-23  Tom Tromey  <tom@tromey.com>
4833
4834         * ui-out.h (class ui_out_emit_type): Update comment.
4835
4836 2019-01-23  Tom Tromey  <tom@tromey.com>
4837
4838         * infrun.c (fetch_inferior_event): Update comment.
4839
4840 2019-01-23  Tom Tromey  <tom@tromey.com>
4841             Pedro Alves  <palves@redhat.com>
4842
4843         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
4844         parameter.
4845         (fetch_inferior_event): Use SCOPE_EXIT.
4846
4847
4848 2019-01-23  Tom Tromey  <tom@tromey.com>
4849             Pedro Alves  <palves@redhat.com>
4850
4851         * infrun.c (disable_thread_events): Delete.
4852         (stop_all_threads): Use SCOPE_EXIT.
4853
4854 2019-01-23  Tom Tromey  <tom@tromey.com>
4855             Pedro Alves  <palves@redhat.com>
4856
4857         * symfile.c: Include forward-scope-exit.h.
4858         (clear_symtab_users_cleanup): Replace forward declaration with
4859         a FORWARD_SCOPE_EXIT.
4860         (syms_from_objfile_1): Use the forward_scope_exit and
4861         gdb::optional instead of cleanup_function.
4862         (reread_symbols): Use the forward_scope_exit instead of
4863         cleanup_function.
4864         (clear_symtab_users_cleanup): Remove function.
4865
4866 2019-01-23  Tom Tromey  <tom@tromey.com>
4867             Pedro Alves  <palves@redhat.com>
4868
4869         * linux-nat.c: Include scope-exit.h.
4870         (cleanup_target_stop): Remove.
4871         (linux_nat_target::static_tracepoint_markers_by_strid): Use
4872         SCOPE_EXIT.
4873
4874 2019-01-23  Tom Tromey  <tom@tromey.com>
4875             Pedro Alves  <palves@redhat.com>
4876
4877         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
4878         (call_function_by_hand_dummy): Use SCOPE_EXIT.
4879
4880 2019-01-23  Tom Tromey  <tom@tromey.com>
4881             Andrew Burgess  <andrew.burgess@embecosm.com>
4882             Pedro Alves  <palves@redhat.com>
4883
4884         * infrun.c (fetch_inferior_event): Use scope_exit.
4885         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
4886         * top.c (execute_command): Use scope_exit.
4887         * breakpoint.c (bpstat_do_actions): Use scope_exit.
4888         * utils.c (do_bpstat_clear_actions_cleanup)
4889         (make_bpstat_clear_actions_cleanup): Remove.
4890
4891 2019-01-23  Tom Tromey  <tom@tromey.com>
4892             Pedro Alves  <palves@redhat.com>
4893
4894         * infrun.c: Include "common/scope-exit.h"
4895         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
4896         (wait_for_inferior): Use SCOPE_EXIT.
4897         (fetch_inferior_event): Use scope_exit.
4898
4899 2019-01-23  Tom Tromey  <tom@tromey.com>
4900             Pedro Alves  <palves@redhat.com>
4901
4902         * breakpoint.c (create_breakpoint): Remove cleanup.
4903
4904 2019-01-23  Tom Tromey  <tom@tromey.com>
4905             Andrew Burgess  <andrew.burgess@embecosm.com>
4906             Pedro Alves  <palves@redhat.com>
4907
4908 2019-01-23  Pedro Alves  <palves@redhat.com>
4909
4910         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
4911
4912 2019-01-23  Pedro Alves  <palves@redhat.com>
4913             Andrew Burgess  <andrew.burgess@embecosm.com>
4914
4915         * gdbthread.h: Include "common/forward-scope-exit.h".
4916         (scoped_finish_thread_state): Redefine custom class in terms of
4917         forward_scope_exit.
4918
4919 2019-01-23  Pedro Alves  <palves@redhat.com>
4920             Andrew Burgess  <andrew.burgess@embecosm.com>
4921
4922         * common/forward-scope-exit.h: New file.
4923
4924 2019-01-23  Pedro Alves  <palves@redhat.com>
4925             Andrew Burgess  <andrew.burgess@embecosm.com>
4926             Tom Tromey  <tom@tromey.com>
4927
4928         * common/scope-exit.h: New file.
4929
4930 2019-01-23  Pedro Alves  <palves@redhat.com>
4931
4932         * common/preprocessor.h (ESC): Rename to ...
4933         (ESC_PARENS): ... this.
4934         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
4935         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
4936
4937 2019-01-23  Tom Tromey  <tom@tromey.com>
4938
4939         * language.h (class scoped_switch_to_sym_language_if_auto):
4940         Initialize m_lang in both cases.
4941
4942 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
4943
4944         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
4945         with XCNEW.
4946
4947 2019-01-22  Tom Tromey  <tom@tromey.com>
4948
4949         * corelow.c: Do not include sys/file.h.
4950
4951 2019-01-22  Tom Tromey  <tom@tromey.com>
4952
4953         * tui/tui-wingeneral.h: Include gdb_curses.h.
4954
4955 2019-01-22  Tom Tromey  <tom@tromey.com>
4956
4957         * source-cache.h (class source_cache) <get_source_lines,
4958         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
4959
4960 2019-01-22  Tom Tromey  <tom@tromey.com>
4961
4962         * remote-fileio.h (struct remote_target): Declare.
4963
4964 2019-01-22  Tom Tromey  <tom@tromey.com>
4965
4966         * python/py-arch.c: Do not include py-ref.h.
4967         * python/py-bpevent.c: Do not include py-ref.h.
4968         * python/py-cmd.c: Do not include py-ref.h.
4969         * python/py-continueevent.c: Do not include py-ref.h.
4970         * python/py-event.h: Do not include py-ref.h.
4971         * python/py-evtregistry.c: Do not include py-ref.h.
4972         * python/py-finishbreakpoint.c: Do not include py-ref.h.
4973         * python/py-frame.c: Do not include py-ref.h.
4974         * python/py-framefilter.c: Do not include py-ref.h.
4975         * python/py-function.c: Do not include py-ref.h.
4976         * python/py-infevents.c: Do not include py-ref.h.
4977         * python/py-linetable.c: Do not include py-ref.h.
4978         * python/py-objfile.c: Do not include py-ref.h.
4979         * python/py-param.c: Do not include py-ref.h.
4980         * python/py-prettyprint.c: Do not include py-ref.h.
4981         * python/py-progspace.c: Do not include py-ref.h.
4982         * python/py-symbol.c: Do not include py-ref.h.
4983         * python/py-symtab.c: Do not include py-ref.h.
4984         * python/py-type.c: Do not include py-ref.h.
4985         * python/py-unwind.c: Do not include py-ref.h.
4986         * python/py-utils.c: Do not include py-ref.h.
4987         * python/py-value.c: Do not include py-ref.h.
4988         * python/py-varobj.c: Do not include py-ref.h.
4989         * python/py-xmethods.c: Do not include py-ref.h.
4990         * python/python.c: Do not include py-ref.h.
4991         * varobj.c: Do not include py-ref.h.
4992
4993 2019-01-22  Tom Tromey  <tom@tromey.com>
4994
4995         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
4996         keyword for bcache.
4997
4998 2019-01-22  Tom Tromey  <tom@tromey.com>
4999
5000         * compile/compile-cplus-types.c: Remove a comment by #include.
5001
5002 2019-01-22  Tom Tromey  <tom@tromey.com>
5003
5004         * compile/gcc-c-plugin.h: Include compile-internal.h.
5005
5006 2019-01-22  Tom Tromey  <tom@tromey.com>
5007
5008         * stabsread.c (EXTERN): Do not define.
5009         (symnum, next_symbol_text_func, processing_gcc_compilation)
5010         (within_function, global_sym_chain, global_stabs)
5011         (previous_stab_code, this_object_header_files)
5012         (n_this_object_header_files)
5013         (n_allocated_this_object_header_files): Define.
5014         * stabsread.h (EXTERN): Never define.  Use "extern".
5015
5016 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5017
5018         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5019         history_value.
5020
5021 2019-01-21  Tom Tromey  <tom@tromey.com>
5022
5023         * ui-out.c: Fix includes.
5024         * tui/tui-source.c: Fix includes.
5025         * target.c: Fix includes.
5026         * remote.c: Fix includes.
5027         * regcache.c: Fix includes.
5028         * python/py-block.c: Fix includes.
5029         * printcmd.c: Fix includes.
5030         * or1k-tdep.c: Fix includes.
5031         * mi/mi-main.c: Fix includes.
5032         * m32r-tdep.c: Fix includes.
5033         * csky-tdep.c: Fix includes.
5034         * compile/compile-cplus-types.c: Fix includes.
5035         * cli/cli-interp.c: Fix includes.
5036
5037 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5038
5039         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5040         for padding.
5041
5042 2019-01-16  Tom Tromey  <tom@tromey.com>
5043
5044         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5045         earlier.
5046         (struct objfile) <msymbols_range>: Move from top level.
5047         <msymbols>: New method.
5048         (class objfile_msymbols): Remove.
5049         * symtab.c (default_collect_symbol_completion_matches_break_on):
5050         Update.
5051         * symmisc.c (dump_msymbols): Update.
5052         * stabsread.c (scan_file_globals): Update.
5053         * objc-lang.c (info_selectors_command, info_classes_command)
5054         (find_methods): Update.
5055         * minsyms.c (find_solib_trampoline_target): Update.
5056         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5057         * coffread.c (coff_symfile_read): Update.
5058         * ada-lang.c (ada_lookup_simple_minsym)
5059         (ada_collect_symbol_completion_matches): Update.
5060
5061 2019-01-16  Tom Tromey  <tom@tromey.com>
5062
5063         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5064         type.  Remove no-argument constructor.
5065         <iterator::operator++>: Simplify.
5066         <begin>: Update.
5067         <end>: Use minimal_symbol_count.
5068
5069 2019-01-16  Tom Tromey  <tom@tromey.com>
5070
5071         * objfiles.h (struct objfile) <psymtabs>: New method.
5072         (class objfile_psymtabs): Remove.
5073         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5074         typedef.
5075         <range>: New method.
5076         (require_partial_symbols): Change return type.
5077         * psymtab.c (require_partial_symbols)
5078         (psym_expand_symtabs_matching): Update.
5079         * mdebugread.c (parse_partial_symbols): Update.
5080         * dbxread.c (dbx_end_psymtab): Update.
5081
5082 2019-01-15  Tom Tromey  <tom@tromey.com>
5083
5084         * symtab.c (lookup_objfile_from_block)
5085         (lookup_symbol_in_objfile_symtabs)
5086         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5087         (find_line_symtab, info_sources_command)
5088         (default_collect_symbol_completion_matches_break_on)
5089         (make_source_files_completion_list): Update.
5090         * symmisc.c (print_objfile_statistics, dump_objfile)
5091         (maintenance_print_symbols, maintenance_info_symtabs)
5092         (maintenance_check_symtabs, maintenance_info_line_tables):
5093         Update.
5094         * source.c (select_source_symtab)
5095         (forget_cached_source_info_for_objfile): Update.
5096         * objfiles.h (class objfile_compunits): Remove.
5097         (struct objfile) <compunits_range>: New typedef.
5098         (compunits): New method.
5099         * objfiles.c (objfile_relocate1): Update.
5100         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5101         * maint.c (count_symtabs_and_blocks): Update.
5102         * linespec.c (iterate_over_all_matching_symtabs): Update.
5103         * cp-support.c (add_symbol_overload_list_qualified): Update.
5104         * coffread.c (coff_symtab_read): Update.
5105         * ada-lang.c (add_nonlocal_symbols)
5106         (ada_collect_symbol_completion_matches)
5107         (ada_add_global_exceptions): Update.
5108
5109 2019-01-15  Tom Tromey  <tom@tromey.com>
5110
5111         * progspace.h (program_space) <objfiles_safe_range>: New
5112         typedef.
5113         <objfiles_safe>: New method.
5114         * objfiles.h (class all_objfiles_safe): Remove.
5115         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5116         * jit.c (jit_inferior_exit_hook): Update.
5117
5118 2019-01-17  Tom Tromey  <tom@tromey.com>
5119
5120         * progspace.h (program_space) <objfiles_range>: New typedef.
5121         <objfiles>: New method.
5122         <objfiles_head>: Rename from objfiles.
5123         (object_files): Update.
5124         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5125         * guile/scm-pretty-print.c
5126         (ppscm_find_pretty_printer_from_objfiles): Update.
5127         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5128         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5129         Update.
5130         * python/py-progspace.c (pspy_get_objfiles): Update.
5131         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5132         Update.
5133         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5134         (objfpy_lookup_objfile_by_build_id): Update.
5135         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5136         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5137         Update.
5138         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5139         (expand_symtab_containing_pc, lookup_objfile_from_block)
5140         (lookup_static_symbol, basic_lookup_transparent_type)
5141         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5142         (find_line_symtab, info_sources_command)
5143         (default_collect_symbol_completion_matches_break_on)
5144         (make_source_files_completion_list, find_main_name): Update.
5145         * symmisc.c (print_symbol_bcache_statistics)
5146         (print_objfile_statistics, maintenance_print_symbols)
5147         (maintenance_print_msymbols, maintenance_print_objfiles)
5148         (maintenance_info_symtabs, maintenance_check_symtabs)
5149         (maintenance_expand_symtabs, maintenance_info_line_tables):
5150         Update.
5151         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5152         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5153         (map_overlay_command, unmap_overlay_command)
5154         (simple_overlay_update, expand_symtabs_matching)
5155         (map_symbol_filenames): Update.
5156         * symfile-debug.c (set_debug_symfile): Update.
5157         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5158         Update.
5159         * source.c (select_source_symtab, forget_cached_source_info):
5160         Update.
5161         * solib.c (solib_read_symbols): Update.
5162         * solib-spu.c (append_ocl_sos): Update.
5163         * psymtab.c (maintenance_print_psymbols)
5164         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5165         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5166         * printcmd.c (info_symbol_command): Update.
5167         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5168         Update.
5169         * objfiles.h (class all_objfiles): Remove.
5170         * objfiles.c (have_partial_symbols, have_full_symbols)
5171         (have_minimal_symbols, qsort_cmp, update_section_map)
5172         (shared_objfile_contains_address_p)
5173         (default_iterate_over_objfiles_in_search_order): Update.
5174         * objc-lang.c (info_selectors_command, info_classes_command)
5175         (find_methods): Update.
5176         * minsyms.c (find_solib_trampoline_target): Update.
5177         * maint.c (maintenance_info_sections)
5178         (maintenance_translate_address, count_symtabs_and_blocks):
5179         Update.
5180         * main.c (captured_main_1): Update.
5181         * linux-thread-db.c (try_thread_db_load_from_pdir)
5182         (has_libpthread): Update.
5183         * linespec.c (iterate_over_all_matching_symtabs)
5184         (search_minsyms_for_name): Update.
5185         * jit.c (jit_find_objf_with_entry_addr): Update.
5186         * hppa-tdep.c (find_unwind_entry)
5187         (hppa_lookup_stub_minimal_symbol): Update.
5188         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5189         Update.
5190         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5191         (elf_gnu_ifunc_resolve_by_got): Update.
5192         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5193         * dwarf-index-write.c (save_gdb_index_command): Update.
5194         * cp-support.c (add_symbol_overload_list_qualified): Update.
5195         * breakpoint.c (create_overlay_event_breakpoint)
5196         (create_longjmp_master_breakpoint)
5197         (create_std_terminate_master_breakpoint)
5198         (create_exception_master_breakpoint): Update.
5199         * blockframe.c (find_pc_partial_function): Update.
5200         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5201         (ada_collect_symbol_completion_matches)
5202         (ada_add_global_exceptions): Update.
5203
5204 2019-01-17  Tom Tromey  <tom@tromey.com>
5205
5206         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5207         declare VEC.
5208         (solib_target_parse_libraries): Change return type.
5209         (library_list_start_segment, library_list_start_section)
5210         (library_list_end_library, library_list_start_library); Update.
5211         (solib_target_free_library_list): Remove.
5212         (solib_target_parse_libraries): Remove cleanup.  Change return
5213         type.
5214         (solib_target_current_sos): Update.
5215
5216 2019-01-17  Tom Tromey  <tromey@bapiya>
5217
5218         * valprint.c: Replace "the the" with "the".
5219         * symtab.c: Replace "the the" with "the".
5220         * solib.c: Replace "the the" with "the".
5221         * solib-dsbt.c: Replace "the the" with "the".
5222         * linespec.c: Replace "the the" with "the".
5223         * dwarf2loc.h: Replace "the the" with "the".
5224         * amd64-windows-tdep.c: Replace "the the" with "the".
5225         * aarch64-tdep.c: Replace "the the" with "the".
5226
5227 2019-01-16  Keith Seitz  <keiths@redhat.com>
5228
5229         PR gdb/23773
5230         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5231         <builder>: Rename to ..
5232         <m_builder>: ... this and make private.
5233         (dwarf2_cu::get_builder): New method.  Change all users of
5234         `builder' to use this method.
5235         (dwarf2_start_symtab): Move to ...
5236         (dwarf2_cu::start_symtab): ... here.  Update all callers
5237         (setup_type_unit_groups): Move to ...
5238         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5239         callers.
5240         (dwarf2_cu::reset_builder): New method.
5241         (process_full_compunit, process_full_type_unit): Use
5242         dwarf2_cu::reset_builder.
5243         (follow_die_offset): Record the ancestor CU if it is different
5244         from the followed DIE's CU.
5245         (follow_die_sig_1): Likewise.
5246
5247 2019-01-15  Tom Tromey  <tom@tromey.com>
5248
5249         * remote.c (class remote_state) <buf>: Now a char_vector.
5250         <buf_size>: Remove.
5251         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5252         parameter.
5253         (remote_target::getpkt_or_notif_sane_1)
5254         (remote_target::getpkt_sane)
5255         (remote_target::getpkt_or_notif_sane): Likewise.
5256         (class remote_target) <putpkt>: New overload.
5257         (remote_target::read_frame): Change type of "buf_p".  Remove
5258         sizeof_p parameter.
5259         (packet_ok): New overload.
5260         (packet_check_result): New overload.
5261         Update all uses.
5262
5263 2019-01-14  Tom Tromey  <tom@tromey.com>
5264
5265         * remote-notif.c (handle_notification, remote_notif_ack)
5266         (remote_notif_parse): Make "buf" const.
5267         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5268         const.
5269         (remote_notif_parse, remote_notif_ack, handle_notification):
5270         Likewise.
5271         * remote.c (remote_notif_stop_parse): Make "buf" const.
5272         (remote_target::remote_parse_stop_reply): Make "buf" const.
5273         (remote_notif_stop_ack): Make "buf" const.
5274
5275 2019-01-14  Tom Tromey  <tom@tromey.com>
5276
5277         * remote.c (remote_console_output): Make parameter const.
5278
5279 2019-01-14  Tom Tromey  <tom@tromey.com>
5280
5281         * target-debug.h (target_debug_print_signals): Constify.
5282         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5283         * procfs.c (procfs_target::pass_signals): Update.
5284         * linux-nat.c (linux_nat_target::pass_signals): Update.
5285         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5286         * target-delegates.c: Rebuild.
5287         * remote.c (remote_target::program_signals): Update.
5288         (remote_target::pass_signals): Update.
5289         * target.c (target_pass_signals): Constify argument.
5290         (target_program_signals): Likewise.
5291         * target.h (struct target_ops) <pass_signals, program_signals>:
5292         Constify argument.
5293         (target_pass_signals, target_program_signals): Constify argument.
5294
5295 2019-01-14  Tom Tromey  <tom@tromey.com>
5296
5297         PR tui/28819:
5298         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5299
5300 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5301
5302         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5303         field.
5304         * rs6000-tdep.c: Include reggroups.h.
5305         (IS_V_ALIAS_PSEUDOREG): Define.
5306         (rs6000_register_name): Return names for the "vX" aliases.
5307         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5308         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5309         aliases.  Call default_register_reggroup_p for all other
5310         pseudo-registers.
5311         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5312         New functions.
5313         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5314         Handle "vX" aliases.
5315         (v_alias_pseudo_register_collect): New function.
5316         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5317         (rs6000_gdbarch_init): Initialize "vX" aliases as
5318         pseudo-registers.  Restore registration of
5319         rs6000_pseudo_register_reggroup_p with
5320         set_tdesc_pseudo_register_reggroup_p.
5321
5322 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5323
5324         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5325         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5326         set_gdbarch_num_pseudo_regs.
5327
5328 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5329
5330         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5331         Remove arg prefixname, add do_set and do_show.
5332         Add member functions set_list and show_list.
5333         * cli/cli-style.c (class cli_style_option): Update accordingly.
5334         (style_set_list): Move to file scope.
5335         (style_show_list): Likewise.
5336         (set_style): Call help_list.
5337         (show_style): Call cmd_show_list.
5338         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5339         Update to use the new macro.
5340
5341 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5342
5343         * ada-lang.c (_initialize_ada_language): Expand the help text
5344         for the "catch exception" command.
5345
5346 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5347
5348         * symtab.c (matching_obj_sections): Initialize obj,
5349         declare it closer to its usage.
5350
5351 2019-01-10  Tom Tromey  <tom@tromey.com>
5352
5353         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5354         (basic_inf_threads_range): Remove.
5355         (inf_threads_range, inf_non_exited_threads_range)
5356         (safe_inf_threads_range): Use next_adapter.
5357
5358 2019-01-10  Keith Seitz  <keiths@redhat.com>
5359
5360         PR gdb/23712
5361         PR symtab/23010
5362         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5363         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5364
5365 2019-01-10  Keith Seitz  <keiths@redhat.com>
5366
5367         PR gdb/23712
5368         PR symtab/23010
5369         * dictionary.c (pending_to_vector): Remove.
5370         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5371         Remove _1 suffix, replacing functions of the same name.  Update
5372         all callers.
5373         (dict_create_hashed, dict_create_hashed_expandable)
5374         (dict_create_linear, dict_create_linear_expandable, dict_free)
5375         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5376         Make functions static.
5377
5378 2019-01-10  Keith Seitz  <keiths@redhat.com>
5379
5380         PR gdb/23712
5381         PR symtab/23010
5382         * dictionary.h (struct dictionary): Replace declaration with
5383         multidictionary.
5384         (dict_create_hashed, dict_create_hashed_expandable)
5385         (dict_create_linear, dict_create_linear_expandable)
5386         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5387         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5388         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5389         taking multidictionary argument.
5390         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5391         * block.h (struct block) <dict>: Change to multidictionary
5392         and rename `multidict'.
5393         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5394         symmisc.c: Update all dictionary references to multidictionary.
5395
5396 2019-01-10  Keith Seitz  <keiths@redhat.com>
5397
5398         PR gdb/23712
5399         PR symtab/23010
5400         * dictionary.c: Include unordered_map.
5401         (pending_to_vector): New function.
5402         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5403         Rewrite the non-"_1" functions to take vector instead
5404         of linked list.
5405         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5406         "new" _1 versions of the same name.
5407         (multidictionary): Define.
5408         (std::hash<enum language): New definition.
5409         (collate_pending_symbols_by_language, mdict_create_hashed)
5410         (mdict_create_hashed_expandable, mdict_create_linear)
5411         (mdict_create_linear_expandable, mdict_free)
5412         (find_language_dictionary, create_new_language_dictionary)
5413         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5414         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5415         (mdict_size, mdict_empty): New functions.
5416         * dictionary.h (mdict_iterator): Define.
5417
5418 2019-01-10  Pedro Alves  <palves@redhat.com>
5419
5420         * breakpoint.c (read_uploaded_action)
5421         (create_tracepoint_from_upload): Adjust to use
5422         gdb::unique_xmalloc_ptr.
5423         * ctf.c (ctf_write_uploaded_tp):
5424         (SET_ARRAY_FIELD): Use emplace_back.
5425         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5426         * tracefile-tfile.c (tfile_write_uploaded_tp):
5427         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5428         gdb::unique_xmalloc_ptr.
5429         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5430         at_string, cond_string, cmd_strings>: Replace char pointers
5431         with gdb::unique_xmalloc_ptr.
5432
5433 2019-01-10  Pedro Alves  <palves@redhat.com>
5434
5435         * solib-target.c (library_list_start_library): Don't xstrdup name.
5436
5437 2019-01-10  Pedro Alves  <palves@redhat.com>
5438
5439         * mdebugread.c (parse_partial_symbols): Use
5440         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
5441
5442 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5443
5444         * linux-fork.c (scoped_switch_fork_info)
5445         <~scoped_switch_fork_info>: Fix incorrect variable name.
5446
5447 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5448
5449         * linux-fork.c (scoped_switch_fork_info)
5450         <scoped_switch_fork_info>: Make explicit.
5451         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
5452
5453 2019-01-10  Tom Tromey  <tom@tromey.com>
5454
5455         * objfiles.h (objfile::reset_psymtabs): Update.
5456         * objfiles.c (objfile::objfile): Update.
5457         * psymtab.h (psymtab_storage::obstack): Update.
5458         (psymtab_storage::m_obstack): Use gdb::optional.
5459         (class psymtab_storage): Update comment.  Remove objfile
5460         parameter.
5461         * psymtab.c (psymtab_storage::psymtab_storage): Update.
5462
5463 2019-01-10  Tom Tromey  <tom@tromey.com>
5464
5465         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
5466         <free_psymtabs>: Now private.
5467         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
5468         (allocate_psymtab): Use new method.
5469
5470 2019-01-10  Tom Tromey  <tom@tromey.com>
5471
5472         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
5473         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
5474         * mdebugread.c (parse_partial_symbols): Use
5475         allocate_dependencies.
5476         * dwarf2read.c (dwarf2_create_include_psymtab): Use
5477         allocate_dependencies.
5478         (process_psymtab_comp_unit_reader)
5479         (build_type_psymtab_dependencies): Likewise.
5480         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
5481
5482 2019-01-10  Tom Tromey  <tom@tromey.com>
5483
5484         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
5485         PSYMBOL_SET_LANGUAGE.
5486         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
5487
5488 2019-01-10  Tom Tromey  <tom@tromey.com>
5489
5490         * psymtab.h (psymtab_storage::obstack): New method.
5491         <m_obstack>: Rename from obstack; now private.
5492         * psymtab.c (psymtab_storage): Update.
5493         * dwarf2read.c (create_addrmap_from_index)
5494         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
5495         Update.
5496
5497 2019-01-10  Tom Tromey  <tom@tromey.com>
5498
5499         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
5500         * objfiles.h (objfile::reset_psymtabs): New method.
5501
5502 2019-01-10  Tom Tromey  <tom@tromey.com>
5503
5504         * symmisc.c (print_symbol_bcache_statistics): Update.
5505         (print_objfile_statistics): Update.
5506         * symfile.c (reread_symbols): Update.
5507         * psymtab.h (class psymtab_storage): New.
5508         * psymtab.c (psymtab_storage): New constructor.
5509         (~psymtab_storage): New destructor.
5510         (require_partial_symbols): Update.
5511         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
5512         (find_pc_sect_psymtab, find_pc_sect_psymbol)
5513         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
5514         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
5515         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
5516         (start_psymtab_common, end_psymtab_common)
5517         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
5518         (allocate_psymtab): Update.
5519         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
5520         Update.
5521         (dump_psymtab_addrmap, maintenance_print_psymbols)
5522         (maintenance_check_psymtabs): Update.
5523         (class objfile_psymtabs): Move to objfiles.h.
5524         * psympriv.h (discard_psymtab): Now inline.
5525         (psymtab_discarder::psymtab_discarder): Update.
5526         (psymtab_discarder::~psymtab_discarder): Update.
5527         (ALL_OBJFILE_PSYMTABS): Rewrite.
5528         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
5529         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
5530         Remove fields.
5531         <partial_symtabs>: New field.
5532         (class objfile_psymtabs): Move from psymtab.h.  Update.
5533         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
5534         psymbol_cache.
5535         (objfile::~objfile): Don't destroy psymbol_cache.
5536         * mdebugread.c (parse_partial_symbols): Update.
5537         * dwarf2read.c (create_addrmap_from_index)
5538         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5539         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
5540         (add_partial_subprogram, dwarf2_ranges_read): Update.
5541         * dwarf-index-write.c (write_address_map)
5542         (write_one_signatured_type, recursively_write_psymbols)
5543         (class debug_names, class debug_names, write_psymtabs_to_index):
5544         Update.
5545
5546 2019-01-10  Tom Tromey  <tom@tromey.com>
5547
5548         * symtab.h (SYMBOL_SET_NAMES): Update.
5549         (symbol_set_names): Update.
5550         (MSYMBOL_SET_NAMES): Update.
5551         * symtab.c (symbol_set_names): Change argument to be an
5552         objfile_per_bfd_storage.
5553         * psymtab.c (add_psymbol_to_bcache): Update.
5554         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
5555
5556 2019-01-10  Tom Tromey  <tom@tromey.com>
5557
5558         * symtab.c (create_demangled_names_hash): Change argument to be an
5559         objfile_per_bfd_storage.
5560         (symbol_set_names): Update.
5561
5562 2019-01-10  Tom Tromey  <tom@tromey.com>
5563
5564         * xcoffread.c (xcoff_initial_scan): Unconditionally call
5565         init_psymbol_list.
5566         * psymtab.c (init_psymbol_list): Do nothing if already called.
5567         * psympriv.h (init_psymbol_list): Add comment.
5568         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
5569         init_psymbol_list.
5570         * dbxread.c (dbx_symfile_read): Unconditionally call
5571         init_psymbol_list.
5572
5573 2019-01-10  Tom Tromey  <tom@tromey.com>
5574
5575         * xcoffread.c (scan_xcoff_symtab): Update.
5576         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
5577         "where".
5578         * mdebugread.c (parse_partial_symbols)
5579         (handle_psymbol_enumerators): Update.
5580         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
5581         * dbxread.c (read_dbx_symtab): Update.
5582         * psympriv.h (psymbol_placement): New enum.
5583         (add_psymbol_to_list): Update.
5584
5585 2019-01-10  Tom Tromey  <tom@tromey.com>
5586
5587         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
5588         static_psymbols parameters.
5589         (scan_xcoff_symtab): Update.
5590         * psymtab.c (start_psymtab_common): Remove global_psymbols and
5591         static_psymbols parameters.
5592         * psympriv.h (start_psymtab_common): Update.
5593         * mdebugread.c (parse_partial_symbols): Update.
5594         * dwarf2read.c (create_partial_symtab): Update.
5595         * dbxread.c (read_dbx_symtab): Update.
5596         (start_psymtab): Remove global_psymbols and static_psymbols
5597         parameters.
5598
5599 2019-01-10  Tom Tromey  <tom@tromey.com>
5600
5601         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
5602         * psymtab.c (allocate_psymtab): Add comment.
5603         * psympriv.h (allocate_psymtab): Add comment.
5604         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
5605         initializations.
5606         * dbxread.c (dbx_end_psymtab): Remove some initializations.
5607
5608 2019-01-10  Tom Tromey  <tom@tromey.com>
5609
5610         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5611         Don't declare.
5612         * mipsread.c: Include mdebugread.h.
5613         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5614         Declare.
5615         * elfread.c: Include mdebugread.h.
5616
5617 2019-01-09  Tom Tromey  <tom@tromey.com>
5618
5619         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
5620         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
5621         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
5622         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
5623         (psym_lookup_symbol, psym_find_last_source_symtab)
5624         (psym_forget_cached_source_info, psym_print_stats)
5625         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
5626         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
5627         (psym_map_matching_symbols, psym_expand_symtabs_matching)
5628         (psym_find_compunit_symtab_by_address)
5629         (maintenance_print_psymbols, maintenance_info_psymtabs)
5630         (maintenance_check_psymtabs): Use ranged for.
5631         * psymtab.h (class objfile_psymtabs): New.
5632         (require_partial_symbols): Return objfile_psymtabs.
5633         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
5634
5635 2019-01-09  Tom Tromey  <tom@tromey.com>
5636
5637         * symfile.c (overlay_invalidate_all, find_pc_overlay)
5638         (find_pc_mapped_section, list_overlays_command)
5639         (map_overlay_command, unmap_overlay_command)
5640         (simple_overlay_update): Use all_objfiles.
5641         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
5642         * printcmd.c (info_symbol_command): Use all_objfiles.
5643         * objfiles.h (ALL_OBJSECTIONS): Remove.
5644         * maint.c (maintenance_translate_address): Use all_objfiles.
5645         * gcore.c (gcore_create_callback): Use all_objfiles.
5646         (objfile_find_memory_regions): Likewise.
5647
5648 2019-01-09  Tom Tromey  <tom@tromey.com>
5649
5650         * symtab.c (find_line_symtab, info_sources_command)
5651         (make_source_files_completion_list): Use objfile_compunits.
5652         * source.c (select_source_symtab): Use objfile_compunits.
5653         * objfiles.h (struct objfile): Update comment.
5654         (ALL_OBJFILES): Remove.
5655         (ALL_FILETABS): Remove.
5656         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
5657         objfile_compunits.
5658
5659 2019-01-09  Tom Tromey  <tom@tromey.com>
5660
5661         * symmisc.c (print_objfile_statistics, dump_objfile)
5662         (maintenance_print_symbols): Use compunit_filetabs.
5663         * source.c (forget_cached_source_info_for_objfile): Use
5664         compunit_filetabs.
5665         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
5666         (ALL_FILETABS): Use compunit_filetabs.
5667         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
5668         * coffread.c (coff_symtab_read): Use compunit_filetabs.
5669
5670 2019-01-09  Tom Tromey  <tom@tromey.com>
5671
5672         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
5673         (compunit_filetabs): New.
5674         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
5675         compunit_filetabs.
5676         (info_sources_command, make_source_files_completion_list): Remove
5677         declaration.
5678         * symmisc.c (print_objfile_statistics, dump_objfile)
5679         (maintenance_print_symbols): Remove declaration.
5680         (maintenance_info_symtabs): Use compunit_filetabs.
5681         (maintenance_info_line_tables): Likewise.
5682         * source.c (select_source_symtab): Change local variable name.
5683         (forget_cached_source_info_for_objfile): Remove declaration.
5684         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
5685         * objfiles.c (objfile_relocate1): Remove declaration.
5686         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5687         declaration.
5688         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
5689         * coffread.c (coff_symtab_read): Remove declaration.
5690         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5691         compunit_filetabs.
5692
5693 2019-01-09  Tom Tromey  <tom@tromey.com>
5694
5695         * symtab.c (lookup_objfile_from_block)
5696         (find_pc_sect_compunit_symtab, search_symbols)
5697         (default_collect_symbol_completion_matches_break_on): Use
5698         objfile_compunits.
5699         * objfiles.h (ALL_COMPUNITS): Remove.
5700         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
5701         * cp-support.c (add_symbol_overload_list_qualified): Use
5702         objfile_compunits.
5703         * ada-lang.c (ada_collect_symbol_completion_matches)
5704         (ada_add_global_exceptions): Use objfile_compunits.
5705
5706 2019-01-09  Tom Tromey  <tom@tromey.com>
5707
5708         * source.c (select_source_symtab)
5709         (forget_cached_source_info_for_objfile): Remove declaration.
5710         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5711         declaration.
5712         * maint.c (count_symtabs_and_blocks): Remove declaration.
5713         * cp-support.c (add_symbol_overload_list_qualified): Remove
5714         declaration.
5715         * coffread.c (coff_symtab_read): Remove declaration.
5716         * symtab.c (lookup_symbol_in_objfile_symtabs)
5717         (basic_lookup_transparent_type_1): Use objfile_compunits.
5718         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
5719         (info_sources_command, search_symbols)
5720         (default_collect_symbol_completion_matches_break_on)
5721         (make_source_files_completion_list): Remove declaration.
5722         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
5723         (ada_collect_symbol_completion_matches)
5724         (ada_add_global_exceptions): Remove declaration.
5725         * linespec.c (iterate_over_all_matching_symtabs): Use
5726         objfile_compunits.
5727         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
5728         (class objfile_compunits): New.
5729         (ALL_COMPUNITS): Use objfile_compunits.
5730         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
5731         (maintenance_check_symtabs, maintenance_info_line_tables): Use
5732         objfile_compunits.
5733         * objfiles.c (objfile_relocate1): Use objfile_compunits.
5734
5735 2019-01-09  Tom Tromey  <tom@tromey.com>
5736
5737         * symtab.c (search_symbols)
5738         (default_collect_symbol_completion_matches_break_on): Use
5739         objfile_msymbols.
5740         * ada-lang.c (ada_lookup_simple_minsym)
5741         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
5742         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
5743         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
5744         objfile_msymbols.
5745         * coffread.c (coff_symfile_read): Use objfile_msymbols.
5746         * symmisc.c (dump_msymbols): Use objfile_msymbols.
5747         * objc-lang.c (find_methods): Use objfile_msymbols.
5748         (info_selectors_command, info_classes_command): Likewise.
5749         * stabsread.c (scan_file_globals): Use objfile_msymbols.
5750         * objfiles.h (class objfile_msymbols): New.
5751         (ALL_OBJFILE_MSYMBOLS): Remove.
5752         (ALL_MSYMBOLS): Remove.
5753
5754 2019-01-09  Tom Tromey  <tom@tromey.com>
5755
5756         * common/next-iterator.h (next_adapter): Add Iterator template
5757         parameter.
5758         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
5759         (class all_objfiles_safe): New.
5760         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
5761         * objfiles.c (put_objfile_before): Update comment.
5762         (add_separate_debug_objfile): Likewise.
5763         (free_all_objfiles): Use all_objfiles_safe.
5764         (objfile_purge_solibs): Likewise.
5765
5766 2019-01-09  Tom Tromey  <tom@tromey.com>
5767
5768         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5769         (expand_symtab_containing_pc, lookup_static_symbol)
5770         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
5771         (find_symbol_at_address, find_line_symtab, find_main_name): Use
5772         all_objfiles.
5773         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
5774         * breakpoint.c (create_overlay_event_breakpoint)
5775         (create_longjmp_master_breakpoint)
5776         (create_std_terminate_master_breakpoint)
5777         (create_exception_master_breakpoint): Use all_objfiles.
5778         * linux-thread-db.c (try_thread_db_load_from_pdir)
5779         (has_libpthread): Use all_objfiles.
5780         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
5781         * linespec.c (iterate_over_all_matching_symtabs)
5782         (search_minsyms_for_name): Use all_objfiles.
5783         * maint.c (maintenance_info_sections): Use all_objfiles.
5784         * main.c (captured_main_1): Use all_objfiles.
5785         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
5786         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
5787         * guile/scm-pretty-print.c
5788         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
5789         * solib-spu.c (append_ocl_sos): Use all_objfiles.
5790         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
5791         (maintenance_print_msymbols): Use all_objfiles.
5792         * source.c (select_source_symtab): Use all_objfiles.
5793         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
5794         * symfile.c (remove_symbol_file_command)
5795         (expand_symtabs_matching, map_symbol_filenames): Use
5796         all_objfiles.
5797         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
5798         all_objfiles.
5799         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
5800         * objc-lang.c (find_methods): Use all_objfiles.
5801         * objfiles.c (have_partial_symbols, have_full_symbols)
5802         (have_minimal_symbols, qsort_cmp)
5803         (default_iterate_over_objfiles_in_search_order): Use
5804         all_objfiles.
5805         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
5806         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
5807         (maintenance_check_psymtabs): Use all_objfiles.
5808         (ALL_PSYMTABS): Remove.
5809         * compile/compile-object-run.c (do_module_cleanup): Use
5810         all_objfiles.
5811         * blockframe.c (find_pc_partial_function): Use all_objfiles.
5812         * cp-support.c (add_symbol_overload_list_qualified): Use
5813         all_objfiles.
5814         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5815         Use all_objfiles.
5816         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
5817         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
5818         all_objfiles.
5819         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5820         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
5821         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5822         Uses all_objfiles.
5823         * solib.c (solib_read_symbols): Use all_objfiles
5824
5825 2019-01-09  Tom Tromey  <tom@tromey.com>
5826
5827         * probe.c (parse_probes_in_pspace): Use all_objfiles.
5828         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
5829         all_objfiles.
5830         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
5831         * symmisc.c (print_symbol_bcache_statistics)
5832         (print_objfile_statistics, maintenance_print_objfiles)
5833         (maintenance_info_symtabs, maintenance_check_symtabs)
5834         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
5835         all_objfiles.
5836         * source.c (forget_cached_source_info): Use all_objfiles.
5837         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
5838         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5839         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
5840         * objfiles.c (update_section_map): Use all_objfiles.
5841         (shared_objfile_contains_address_p): Likewise.
5842         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
5843         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
5844
5845 2019-01-09  Tom Tromey  <tom@tromey.com>
5846
5847         * common/next-iterator.h: New file.
5848         * objfiles.h (class all_objfiles): New.
5849         (struct objfile_iterator): New.
5850
5851 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5852
5853         * NEWS: Move the description of the changed "frame", "select-frame",
5854          and "info frame" commands to the Changed commands section.
5855
5856 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
5857
5858         * gdbtypes.c (check_stub_method_group): Remove handling of old
5859         mangling schemes.
5860         * linespec.c (find_methods): Likewise.
5861         * stabsread.c (read_member_functions): Likewise.
5862         * valops.c (search_struct_method): Likewise.
5863         (value_struct_elt_for_reference): Likewise.
5864         * NEWS: Mention this change.
5865
5866 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5867
5868         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
5869         print_source_lines.
5870         * source.c (print_source_lines_base): Update line number check.
5871         (print_source_lines): New function.
5872         (source_lines_range::source_lines_range): New function.
5873         * source.h (class source_lines_range): New class.
5874         (print_source_lines): New declaration.
5875
5876 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5877
5878         * linespec.c (linespec_state_destructor): Free self->canonical_names.
5879
5880 2019-01-08  Tom Tromey  <tom@tromey.com>
5881             Simon Marchi  <simon.marchi@ericsson.com>
5882
5883         PR gdb/24060
5884         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
5885         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
5886         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5887         * f-exp.y (DOLLAR_VARIABLE): Likewise.
5888         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
5889         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5890
5891 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5892
5893         * source.c (select_source_symtab): Move header comment to
5894         declaration in source.h.
5895         (forget_cached_source_info_for_objfile): Likewise.
5896         (forget_cached_source_info): Likewise.
5897         (identify_source_line): Likewise.
5898         * source.h (identify_source_line): Move declaration from symtab.h
5899         and add comment from source.c
5900         (print_source_lines): Likewise.
5901         (forget_cached_source_info_for_objfile): Likewise.
5902         (forget_cached_source_info): Likewise.
5903         (select_source_symtab): Likewise.
5904         (enum print_source_lines_flag): Move definition from symtab.h.
5905         * symtab.h (identify_source_line): Move declaration to source.h.
5906         (print_source_lines): Likewise.
5907         (forget_cached_source_info_for_objfile): Likewise.
5908         (forget_cached_source_info): Likewise.
5909         (select_source_symtab): Likewise.
5910         (enum print_source_lines_flag): Move definition to source.h.
5911         * tui/tui-hooks.c: Add 'source.h' include.
5912
5913 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5914
5915         * source.c (print_source_lines_base): Handle requests to print
5916         reverse line number sequences, and guard against empty lines
5917         string.
5918
5919 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5920
5921         * source.c (print_source_lines_base): Fix skip of '\r' if next
5922         character is '\n'.
5923
5924 2019-01-06  Tom Tromey  <tom@tromey.com>
5925
5926         * c-exp.y (struct c_parse_state) <macro_original_text,
5927         expansion_obstack>: New member.
5928         (macro_original_text, expansion_obstack): Remove globals.
5929         (scan_macro_expansion, scanning_macro_expansion)
5930         (finished_macro_expansion): Update.
5931         (scan_macro_cleanup): Remove.
5932         (yylex, c_parse): Update.
5933
5934 2019-01-06  Tom Tromey  <tom@tromey.com>
5935
5936         * c-exp.y (struct c_parse_state) <strings>: New member.
5937         (operator_stoken): Update.
5938
5939 2019-01-06  Tom Tromey  <tom@tromey.com>
5940
5941         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
5942         (union type_stack_elt) <typelist_val>: Now a pointer to
5943         std::vector.
5944         (type_stack_cleanup): Don't declare.
5945         (push_typelist): Update.
5946         * parse.c (pop_typelist): Return a std::vector.
5947         (push_typelist): Take a std::vector.
5948         (follow_types): Update.  Do not free args.
5949         (type_stack_cleanup): Remove.
5950         * c-exp.y (struct c_parse_state): New.
5951         (cpstate): New global.
5952         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
5953         (nonempty_typelist): Update.
5954         (func_mod): Create a new vector.
5955         (c_parse): Create a c_parse_state.
5956         (check_parameter_typelist): Do not delete params.
5957         (function_method): Update.  Do not delete type_list.
5958
5959 2019-01-06  Tom Tromey  <tom@tromey.com>
5960
5961         PR gdb/28155:
5962         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
5963         check_typedef.
5964         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
5965         (print_return_value): Likewise.
5966
5967 2019-01-05  Tom Tromey  <tom@tromey.com>
5968
5969         * contrib/cleanup_check.py: Remove.
5970         * contrib/gcc-with-excheck: Remove.
5971         * contrib/exsummary.py: Remove.
5972         * contrib/excheck.py: Remove.
5973
5974 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
5975
5976         * thread.c (delete_thread_1): Add gdb_assert that THR is not
5977         NULL. Initialize tpprev to NULL instead of assigning it
5978         to NULL on the next statement.
5979         * windows-nat.c (windows_delete_thread): Remove check for
5980         main_thread_id before printing thread exit notifications.
5981         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
5982         Remove thread ID check against main_thread_id.
5983         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
5984         windows_delete_thread.
5985         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
5986
5987 2019-01-04  Tom Tromey  <tom@tromey.com>
5988
5989         * compile/compile.c (_initialize_compile): Use upper case for
5990         metasyntactic variables.
5991         * symmisc.c (_initialize_symmisc): Use upper case for
5992         metasyntactic variables.
5993         * psymtab.c (_initialize_psymtab): Use upper case for
5994         metasyntactic variables.
5995         * demangle.c (demangle_command): Use upper case for metasyntactic
5996         variables.
5997         (_initialize_demangler): Likewise.
5998         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
5999         variables.
6000
6001 2019-01-03  Tom Tromey  <tom@tromey.com>
6002
6003         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6004
6005 2019-01-03  Tom Tromey  <tom@tromey.com>
6006
6007         * python/py-symtab.c (salpy_str): Update.
6008         (struct salpy_sal_object) <symtab>: Now a PyObject.
6009         (salpy_dealloc): Update.
6010         (del_objfile_sal): Use gdbpy_ref.
6011
6012 2019-01-03  Tom Tromey  <tom@tromey.com>
6013
6014         * python/py-type.c (convert_field): Use new_reference.  Return
6015         gdbpy_ref.
6016         (make_fielditem): Return gdbpy_ref.
6017         (typy_fields): Update.
6018         (typy_getitem): Update.
6019         (field_name): Return gdbpy_ref.  Use new_reference.
6020         (typy_iterator_iternext): Update.
6021
6022 2019-01-03  Tom Tromey  <tom@tromey.com>
6023
6024         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6025
6026 2019-01-03  Tom Tromey  <tom@tromey.com>
6027
6028         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6029         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6030         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6031         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6032         (pspy_set_type_printers): Likewise.
6033         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6034         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6035         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6036         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6037         (objfpy_set_type_printers): Likewise.
6038
6039 2019-01-03  Tom Tromey  <tom@tromey.com>
6040
6041         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6042         (gdbpy_print_stack): Use gdbpy_err_fetch.
6043         * python/python-internal.h (class gdbpy_err_fetch): New class.
6044         (class gdbpy_enter) <m_error_type, m_error_value,
6045         m_error_traceback>: Remove.
6046         <m_error>: New member.
6047         (gdbpy_exception_to_string): Don't declare.
6048         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6049         * python/py-value.c (convert_value_from_python): Use
6050         gdbpy_err_fetch.
6051         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6052         gdbpy_exception_to_string.
6053         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6054         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6055         gdbpy_err_fetch.
6056
6057 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6058
6059         * linux-nat.c (delete_lwp_cleanup): Delete.
6060         (struct lwp_deleter): New struct.
6061         (lwp_info_up): New typedef.
6062         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6063         lwp_info_up.
6064
6065 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6066
6067         * linux-fork.c (class scoped_switch_fork_info): New class.
6068         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6069
6070 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6071
6072         * valops.c (find_overload_match): Remove use of null_cleanup, and
6073         calls to do_cleanups.
6074
6075 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6076
6077         * compile/compile-cplus-types.c
6078         (compile_cplus_instance::decl_name): Handle changes to
6079         cp_func_name.
6080         * cp-support.c (cp_func_name): Update header comment, update
6081         return type.
6082         * cp-support.h (cp_func_name): Update return type in declaration.
6083         * valops.c (find_overload_match): Move temp_func local to top
6084         level of function and change its type.  Use temp_func to hold and
6085         delete temporary string obtained from cp_func_name.
6086
6087 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6088
6089         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6090         gdb::char_vector, remove cleanup, and update uses of `msg`.
6091
6092 2019-01-03  Jim Wilson  <jimw@sifive.com>
6093
6094         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6095
6096 2019-01-02  Tom Tromey  <tom@tromey.com>
6097
6098         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6099         (tdesc_parse_xml): Remove cleanups.
6100         * target-descriptions.h (make_cleanup_free_target_description):
6101         Don't declare.
6102         (target_desc_deleter): New struct.
6103         (target_desc_up): New typedef.
6104         * target-descriptions.c (target_desc_deleter::operator()): Rename
6105         from free_target_description.
6106         (make_cleanup_free_target_description): Remove.
6107
6108 2019-01-02  Tom Tromey  <tom@tromey.com>
6109
6110         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6111         constructor, destructor.
6112         (linespec_parser): Remove typedef.
6113         (~linespec_parser): Rename from linespec_parser_delete.
6114         (linespec_lex_to_end, linespec_complete_label)
6115         (linespec_complete): Update.
6116         (decode_line_full): Remove cleanups.
6117         (decode_line_1): Update.
6118
6119 2019-01-02  Tom Tromey  <tom@tromey.com>
6120
6121         * python/python-internal.h (inferior_to_inferior_object): Change
6122         return type.
6123         * python/py-exitedevent.c (create_exited_event_object): Update.
6124         * python/py-inferior.c (inferior_to_inferior_object): Return
6125         gdbpy_ref.
6126         (python_new_inferior, python_inferior_deleted)
6127         (thread_to_thread_object, delete_thread_object)
6128         (build_inferior_list, gdbpy_selected_inferior): Update.
6129         * python/py-infthread.c (create_thread_object): Update.  Also fail
6130         if inferior_to_inferior_object fails.
6131
6132 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6133
6134         * inferior.h (class inferior) <displaced_step_state>: New field.
6135         * infrun.h (struct displaced_step_state): Move here from
6136         infrun.c.  Initialize fields, add constructor.
6137         <inf>: Remove field.
6138         <reset>: New method.
6139         * infrun.c (struct displaced_step_inferior_state): Move to
6140         infrun.h.
6141         (displaced_step_inferior_states): Remove.
6142         (get_displaced_stepping_state): Adust.
6143         (displaced_step_in_progress_any_inferior): Adjust.
6144         (displaced_step_in_progress_thread): Adjust.
6145         (displaced_step_in_progress): Adjust.
6146         (add_displaced_stepping_state): Remove.
6147         (get_displaced_step_closure_by_addr): Adjust.
6148         (remove_displaced_stepping_state): Remove.
6149         (infrun_inferior_exit): Call displaced_step_state.reset.
6150         (use_displaced_stepping): Don't check for NULL.
6151         (displaced_step_prepare_throw): Call
6152         get_displaced_stepping_state.
6153         (displaced_step_fixup): Don't check for NULL.
6154         (prepare_for_detach): Don't check for NULL.
6155
6156 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6157
6158         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6159          in case of call that did not complete.
6160
6161 2019-01-02  Andrey Utkin  <autkin@undo.io>
6162
6163         * symfile.c (find_separate_debug_file): Fix search of debug files for
6164         remote debuggee.
6165
6166 2019-01-02  Tom Tromey  <tom@tromey.com>
6167
6168         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6169         indentation.
6170         * python/py-frame.c (frapy_older): Remove cast.
6171         (frapy_newer): Likewise.
6172         * python/py-breakpoint.c (local_setattro): Remove cast.
6173         * python/py-arch.c (archpy_name): Remove local variable.
6174         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6175
6176 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6177
6178         * unittests/basic_string_view/element_access/char/empty.cc:
6179         Fix year range in copyright header.
6180
6181 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6182
6183         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6184         Delete.
6185         <operator==>: Update with for removed field.
6186         <hash>: Likewise.
6187         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6188         <isa_features>: ...this.
6189         <abi_features>: New field.
6190         (riscv_isa_flen): Update comment.
6191         (riscv_abi_xlen): New declaration.
6192         (riscv_abi_flen): New declaration.
6193         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6194         isa_features.
6195         (riscv_abi_xlen): New function.
6196         (riscv_isa_flen): Update to get answer from isa_features.
6197         (riscv_abi_flen): New function.
6198         (riscv_has_fp_abi): Update to get answer from abi_features.
6199         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6200         xlen and flen.
6201         (riscv_call_info) <xlen, flen>: Update comment.
6202         (riscv_call_arg_struct): Remove invalid assertions
6203         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6204         is removed.
6205         (riscv_gdbarch_init): Gather isa features and abi features
6206         separately, ensure both match on the gdbarch when reusing an old
6207         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6208         a target with 64-bit float hardware.
6209
6210 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6211
6212         * source.c (search_command_helper): Stop reverse search
6213         when line 1 has been searched.
6214
6215 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6216
6217         * record-full.c (record_full_base_target::close): Rewrite
6218         record_full_core_buf_list free logic.
6219
6220 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6221
6222         * break-catch-syscall.c (print_one_catch_syscall): xfree
6223         the last text.
6224
6225 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6226
6227         * top.c (print_gdb_version): Update Copyright year in version
6228         message.
6229
6230 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6231
6232         Update copyright year range in all GDB files.
6233
6234 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6235
6236         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6237
6238 For older changes see ChangeLog-2018.
6239 \f
6240 Local Variables:
6241 mode: change-log
6242 left-margin: 8
6243 fill-column: 74
6244 version-control: never
6245 coding: utf-8
6246 End:
6247