gdb/m32r: Use default gdbarch methods where possible
[external/binutils.git] / gdb / ChangeLog
1 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2
3         * m32r-tdep.c (m32r_unwind_sp): Delete.
4         (m32r_unwind_pc): Delete.
5         (m32r_dummy_id): Delete.
6         (m32r_gdbarch_init): Don't register deleted functions with
7         gdbarch.
8
9 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10
11         * m32c-tdep.c (m32c_unwind_pc): Delete.
12         (m32c_unwind_sp): Delete.
13         (m32c_dummy_id): Delete.
14         (m32c_gdbarch_init): Don't register deleted functions with
15         gdbarch.
16
17 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
18
19         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
20         (lm32_unwind_pc): Delete.
21         (lm32_dummy_id): Delete.
22         (lm32_gdbarch_init): Don't register deleted functions with
23         gdbarch.
24
25 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
26
27         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
28         (iq2000_unwind_pc): Delete.
29         (iq2000_dummy_id): Delete.
30         (iq2000_gdbarch_init): Don't register deleted functions with
31         gdbarch.
32
33 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
34
35         * nds32-tdep.c (nds32_type_align): Delete.
36         (nds32_push_dummy_call): Use type_align instead.
37
38 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
39
40         * arm-tdep.c (arm_type_align): Only handle vector override case.
41         (arm_push_dummy_call): Use type_align.
42         (arm_gdbarch_init): Register arm_type_align gdbarch function.
43
44 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
45
46         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
47         case.
48         (pass_on_stack): Use type_align.
49         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
50         function.
51
52 2019-04-23  Tom Tromey  <tromey@adacore.com>
53
54         * dwarf2read.c (line_header::file_name_at): Remove unused
55         overload.
56
57 2019-04-23  Tom de Vries  <tdevries@suse.de>
58
59         PR gdb/24438
60         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
61         invocation.
62
63
64 2019-03-27  Ali Tamur  <tamur@google.com>
65
66         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
67         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
68         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
69         (dwarf_expr_context::get_addr_index): Likewise
70         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
71         (symbol_needs_eval_context::get_addr_index): Likewise
72         (disassemble_dwarf_expression): Add DW_OP_addrx
73         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
74         (read_cutu_die_from_dwo): Update comment
75         (skip_one_die): Add DW_FORM_addrx
76         (read_attribute_value): Likewise
77         (var_decode_location): Add DW_OP_addrx
78         (dwarf2_const_value_attr): Add DW_FORM_addrx
79         (dump_die_shallow): Likewise
80         (dwarf2_fetch_constant_bytes): Likewise
81         (decode_locdesc): Add DW_OP_addrx
82         (skip_form_bytes): Add DW_FORM_addrx
83
84 2019-04-22  Ali Tamur  <tamur@google.com>
85
86         * MAINTAINERS (Write After Approval): Add self.
87
88 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
89
90         * solib-svr4.c (get_svr4_info): Add pspace parameter.
91         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
92         (open_symbol_file_object): Likewise.
93         (svr4_default_sos): Add info parameter.
94         (svr4_read_so_list): Likewise.
95         (svr4_current_sos_direct): Adjust functions calls to pass down
96         info.
97         (svr4_current_sos_1): Add info parameter.
98         (svr4_current_sos): Call get_svr4_info, pass info down to
99         svr4_current_sos_1.
100         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
101         get_svr4_info.
102         (svr4_in_dynsym_resolve_code): Pass current_program_space to
103         get_svr4_info.
104         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
105         to get_svr4_info.
106         (probes_table_remove_objfile_probes): Likewise.
107         (register_solib_event_probe): Add info parameter.
108         (solist_update_incremental): Pass info parameter down to
109         svr4_read_so_list.
110         (disable_probes_interface): Add info parameter.
111         (svr4_handle_solib_event): Pass current_program_space to
112         get_svr4_info.  Adjust disable_probes_interface cleanup.
113         (svr4_create_probe_breakpoints): Add info parameter, pass it
114         down to register_solib_event_probe.
115         (svr4_create_solib_event_breakpoints): Add info parameter,
116         pass it down to svr4_create_probe_breakpoints.
117         (enable_break): Pass info down to
118         svr4_create_solib_event_breakpoints.
119         (svr4_solib_create_inferior_hook): Pass current_program_space to
120         get_svr4_info.
121         (svr4_clear_solib): Likewise.
122
123 2019-04-22  Pedro Alves  <palves@redhat.com>
124
125         * solib-svr4.c (svr4_free_objfile_observer): New.
126         (probe_and_action::objfile): New field.
127         (probes_table_htab_remove_objfile_probes)
128         (probes_table_remove_objfile_probes): New functions.
129         (register_solib_event_probe): Add 'objfile' parameter.  Store it
130         in the new probe_and_action.  Don't store the probe in 'lookup'.
131         (svr4_create_probe_breakpoints): Pass objfile to
132         register_solib_event_probe.
133         (_initialize_svr4_solib): Register a free_objfile observer.
134
135 2019-04-19  Tom Tromey  <tom@tromey.com>
136
137         * common/queue.h: Remove.
138
139 2019-04-19  Tom Tromey  <tom@tromey.com>
140
141         * event-loop.c: Don't include "common/queue.h".
142
143 2019-04-19  Tom Tromey  <tom@tromey.com>
144
145         * remote.c (remote_target): Use delete.
146         * remote-notif.h: Include <list>, not "common/queue.h".
147         (notif_client_p): Remove typedef.
148         (remote_notif_state): Add constructor, destructor, initializer.
149         <notif_queue>: Now a std::list.
150         (remote_notif_state_xfree): Don't declare.
151         * remote-notif.c (remote_notif_process, handle_notification)
152         (remote_notif_state_allocate): Update.
153         (~remote_notif_state): Rename from remote_notif_state_xfree.
154
155 2019-04-19  Tom Tromey  <tom@tromey.com>
156
157         * symfile.c (reread_symbols): Update.
158         * objfiles.c (objfile_register_static_link)
159         (objfile_lookup_static_link): Update
160         (~objfile) Don't delete static_links.
161         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
162
163 2019-04-19  Tom Tromey  <tom@tromey.com>
164
165         * type-stack.h (struct type_stack) <insert>: Constify string.
166         * type-stack.c (type_stack::insert): Constify string.
167         * gdbtypes.h (lookup_template_type): Update.
168         (address_space_name_to_int): Update.
169         * gdbtypes.c (address_space_name_to_int): Make space_identifier
170         const.
171         (lookup_template_type): Make name const.
172         * c-exp.y: Update rules.
173         (lex_one_token, classify_name, classify_inner_name)
174         (c_print_token): Update.
175         * p-exp.y: Update rules.
176         (yylex): Update.
177         * f-exp.y: Update rules.
178         (yylex): Update.
179         * d-exp.y: Update rules.
180         (lex_one_token, classify_name, classify_inner_name): Update.
181         * parse.c (write_dollar_variable, copy_name): Return std::string.
182         * parser-defs.h (copy_name): Change return type.
183         * m2-exp.y: Update rules.
184         (yylex): Update.
185         * go-exp.y (lex_one_token): Update.
186         Update rules.
187         (classify_unsafe_function, classify_packaged_name)
188         (classify_name, yylex): Update.
189
190 2019-04-19  Sergei Trofimovich <siarheit@google.com>
191
192         * configure.ac: add --enable-source-highlight switch.
193         * configure: Regenerate.
194         * top.c (print_gdb_version): plumb --enable-source-highlight
195         status to "show configuration".
196
197 2019-04-19  Tom Tromey  <tromey@adacore.com>
198
199         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
200         Check ADA_TYPE_P.
201         (empty_record, ada_template_to_fixed_record_type_1)
202         (template_to_static_fixed_type)
203         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
204         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
205         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
206         macros.
207
208 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
209
210         PR symtab/24423:
211         * source.c (print_source_lines_base): Advance "iter" when a
212         control character is seen.
213
214 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
215
216         * inferior.h (struct infcall_suspend_state_deleter):
217         Catch exception in destructor to avoid crash.
218
219 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
220
221         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
222         close to the add_com "shell".
223
224 2019-04-18  Tom Tromey  <tromey@adacore.com>
225
226         * process-stratum-target.h (class process_stratum_target)
227         <stratum>: Add "final".
228
229 2019-04-17  Tom Tromey  <tromey@adacore.com>
230
231         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
232         against nullptr before use.
233
234 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
235
236         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
237
238 2019-04-17  Jim Wilson  <jimw@sifive.com>
239             Andrew Burgess  <andrew.burgess@embecosm.com>
240
241         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
242         code read might fail, assume 4-byte breakpoint in that case.
243
244 2019-04-15  Leszek Swirski  <leszeks@google.com>
245
246         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
247         rather than a hand-rolled POD check when checking for forced MEMORY
248         classification.
249
250 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
251
252         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
253         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
254         function.
255         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
256         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
257         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
258         declaration.
259
260 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
261
262         * aarch64-linux-nat.c
263         (aarch64_linux_nat_target::thread_architecture): Add override.
264         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
265         each VQ.
266
267 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
268
269         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
270
271 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
272
273         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
274         target types of size 96-bits, add some additional comments, and
275         check that the builtin type we found was the correct size.
276
277 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
278
279         * utils.c (prompt_for_continue): Don't restore the styling at the
280         end, as applied_style has the wrong value.  This fixes styling in
281         long lists of file names that are interrupted by the "Continue?"
282         prompt.
283
284 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
285
286         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
287         * c-lang.c (c_language_defn): Likewise.
288         (cplus_language_defn): Likewise.
289         (asm_language_defn): Likewise.
290         (minimal_language_defn): Likewise.
291         * d-lang.c (d_language_defn): Likewise.
292         * f-lang.c (f_language_defn): Likewise.
293         * go-lang.c (go_language_defn): Likewise.
294         * language.c (unknown_language_defn): Likewise.
295         (auto_language_defn): Likewise.
296         * language.h (struct language_defn): Remove la_magic field.
297         (LANG_MAGIC): Delete.
298         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
299         * objc-lang.c (objc_language_defn): Likewise.
300         * opencl-lang.c (opencl_language_defn): Likewise.
301         * p-lang.c (pascal_language_defn): Likewise.
302         * rust-lang.c (rust_language_defn): Likewise.
303
304 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
305
306         * riscv-tdep.c (riscv_type_align): New function.
307         (riscv_type_alignment): Delete.
308         (riscv_arg_location): Use 'type_align'.
309         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
310
311 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
312
313         * gdbtypes.c (type_align): A struct with no non-static fields also
314         has alignment of 1.
315
316 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
317
318         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
319         component to 0.
320         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
321         member.
322         (riscv_struct_info::analyse): New implementation using new
323         analyse_inner member function.
324         (riscv_struct_info::field_offset): New member function.
325         (riscv_struct_info::m_offsets): New member variable.
326         (riscv_struct_info::analyse_inner): New private member function,
327         takes the old implementation of riscv_struct_info::analyse but
328         extended to track field offsets.
329         (riscv_call_arg_struct): Update the struct folding special cases
330         to handle cases where empty C++ structs, which are non-zero
331         length, are found.
332         (riscv_arg_location): Initialise the length of each location, a
333         non-zero length now indicates the location is in use.
334         (riscv_push_dummy_call): Allow for the first location having a
335         non-zero offset when setting up arguments.
336         (riscv_return_value): Likewise, but for return values.
337
338 2019-04-11  Tom Tromey  <tromey@adacore.com>
339
340         * utils.c (internal_vproblem): Make "msg" const.
341
342 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
343
344         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
345         * trad-frame.c (trad_frame_reset_saved_regs): New function.
346         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
347         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
348
349 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
350
351         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
352         function.
353         (fill_gregset): Call amd64_linux_collect_native_gregset instead
354         of amd64_collect_native_gregset.
355         (amd64_linux_nat_target::store_registers): Likewise.
356
357 2019-04-10  Tom Tromey  <tom@tromey.com>
358
359         * symtab.c (lookup_global_symbol_from_objfile)
360         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
361         * objfiles.h (class separate_debug_iterator): New.
362         (class separate_debug_range): New.
363         (struct objfile) <separate_debug_objfiles>: New method.
364         (objfile_separate_debug_iterate): Don't declare.
365         * objfiles.c (separate_debug_iterator::operator++): Rename from
366         objfile_separate_debug_iterate.
367         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
368         iterator.
369         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
370         iterator.
371
372 2019-04-10  Tom Tromey  <tom@tromey.com>
373
374         * symfile.c (reread_symbols): Remove old comment.
375         * objfiles.c (free_all_objfiles): Fix a typo.
376
377 2019-04-10  Tom Tromey  <tom@tromey.com>
378
379         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
380         * minsyms.c (lookup_minimal_symbol): Use foreach.
381         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
382         (lookup_minimal_symbol_solib_trampoline): Likewise.
383         * symfile.c (reread_symbols): Use foreach.
384
385 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
386             Tom Tromey  <tromey@adacore.com>
387
388         PR rust/24414:
389         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
390         (rust_lex_int_test): Change "value" to be LONGEST.
391         (rust_lex_tests): Add test for long integer literal.
392
393 2019-04-09  Tom Tromey  <tromey@adacore.com>
394
395         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
396         to bool.
397         (extended_remote_target::attach): Update.
398         (remote_target::remote_notice_new_inferior): Update.
399         (remote_target::add_current_inferior_and_thread): Update.
400         * inferior.c (exit_inferior_1): Use "false".
401         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
402
403 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
404
405         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
406         the "start" command.
407
408 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
409
410         * python/py-inferior.c (infpy_thread_from_thread_handle):
411         Adjust comments to reflect renaming of thread_from_thread_handle
412         to thread_from_handle.  Adjust keywords.  Fix type error message.
413         (inferior_object_methods): Add thread_from_handle.  Retain
414         thread_from_thread_handle, but mark it as deprecated.
415
416 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
417
418         * gdbthread.h (find_thread_by_handle): Revise declaration.
419         * thread.c (find_thread_by_handle): Likewise.  Adjust
420         implementation too.
421         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
422         support for buffer objects as handles.
423
424 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
425
426         * python/py-infthread.c (thpy_thread_handle): New function.
427         (thread_object_methods): Register thpy_thread_handle.
428
429 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
430
431         * gdbthread.h (thread_to_thread_handle): Declare.
432         * thread.c (gdbtypes.h): Include.
433         (thread_to_thread_handle): New function.
434
435         * target.h (struct target_ops): Add thread_info_to_thread_handle.
436         (target_thread_info_to_thread_handle): Declare.
437         * target.c (target_thread_info_to_thread_handle): New function.
438         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
439         * target-delegates.c: Regenerate.
440
441         * linux-thread-db.c (class thread_db_target): Add method
442         thread_info_to_thread_handle.
443         (thread_db_target::thread_info_to_thread_handle): Define.
444         * remote.c (class remote_target): Add new method
445         thread_info_to_thread_handle.
446         (remote_target::thread_info_to_thread_handle): Define.
447
448 2019-04-08  Pedro Alves  <palves@redhat.com>
449
450         * common/common-exceptions.c (throw_exception): Don't create
451         named object to throw; throw directly.
452         (throw_it): Likewise.  Don't initialize gdb_exception::message
453         here, with new; pass FMT and AP to the ctor instead.
454         * common/common-exceptions.h: Include <string>.
455         (gdb_exception::gdb_exception(enum return_reason, enum errors,
456         const char *, va_list)): New ctor.  Use std::make_shared.
457         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
458         errors)): Delete.
459         (gdb_exception_error::gdb_exception_error(enum errors, const char
460         *, va_list)): New.
461         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
462         Add assertion.
463         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
464         errors)): Delete.
465         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
466         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
467         Add assertion.
468
469 2019-04-08  Tom Tromey  <tom@tromey.com>
470
471         * valops.c (value_rtti_indirect_type): Replace throw_exception
472         with throw.
473         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
474         with throw.
475         * thread.c (thr_try_catch_cmd): Replace throw_exception with
476         throw.
477         * target.c (target_translate_tls_address): Replace throw_exception
478         with throw.
479         * stack.c (frame_apply_command_count): Replace throw_exception
480         with throw.
481         * solib-spu.c (append_ocl_sos): Replace throw_exception with
482         throw.
483         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
484         with throw.
485         * rs6000-tdep.c (rs6000_frame_cache)
486         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
487         * remote.c: Replace throw_exception with throw.
488         * record-full.c (record_full_message, record_full_wait_1)
489         (record_full_restore): Replace throw_exception with throw.
490         * record-btrace.c:
491         (get_thread_current_frame_id, record_btrace_start_replaying)
492         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
493         (cmd_record_btrace_start): Replace throw_exception with throw.
494         * parse.c (parse_exp_in_context_1): Replace throw_exception with
495         throw.
496         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
497         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
498         * linespec.c:
499         (find_linespec_symbols): Replace throw_exception with throw.
500         * infrun.c (displaced_step_prepare, resume): Replace
501         throw_exception with throw.
502         * infcmd.c (post_create_inferior): Replace throw_exception with
503         throw.
504         * inf-loop.c (inferior_event_handler): Replace throw_exception
505         with throw.
506         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
507         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
508         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
509         (get_prev_frame_always, get_frame_pc_if_available)
510         (get_frame_address_in_block_if_available, get_frame_language):
511         Replace throw_exception with throw.
512         * frame-unwind.c (frame_unwind_try_unwinder): Replace
513         throw_exception with throw.
514         * eval.c (fetch_subexp_value, evaluate_var_value)
515         (evaluate_funcall, evaluate_subexp_standard): Replace
516         throw_exception with throw.
517         * dwarf2loc.c (call_site_find_chain)
518         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
519         Replace throw_exception with throw.
520         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
521         with throw.
522         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
523         throw.
524         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
525         * completer.c (complete_line_internal): Replace throw_exception
526         with throw.
527         * compile/compile-object-run.c (compile_object_run): Replace
528         throw_exception with throw.
529         * cli/cli-script.c (process_next_line): Replace throw_exception
530         with throw.
531         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
532         (btrace_enable, btrace_maint_update_pt_packets): Replace
533         throw_exception with throw.
534         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
535         throw_exception with throw.
536         * break-catch-throw.c (re_set_exception_catchpoint): Replace
537         throw_exception with throw.
538         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
539         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
540         * aarch64-tdep.c (aarch64_make_prologue_cache)
541         (aarch64_make_stub_cache): Replace throw_exception with throw.
542
543 2019-04-08  Tom Tromey  <tom@tromey.com>
544
545         * common/common-exceptions.c (throw_exception): Rename from
546         throw_exception_cxx.  Remove old copy.  Make argument const.
547         (throw_it): Create and throw exception objects directly.
548         * common/common-exceptions.h (throw_exception): Make argument
549         const.
550         (struct gdb_exception_error): Add constructor.
551         (struct gdb_exception_quit): Add constructor.
552
553 2019-04-08  Tom Tromey  <tom@tromey.com>
554
555         * common/common-exceptions.h (exception_rethrow): Don't declare.
556         (TRY_SJLJ): Update comment.
557         (TRY, CATCH, END_CATCH): Remove.
558         * common/common-exceptions.c (exception_rethrow): Remove.
559
560 2019-04-08  Tom Tromey  <tom@tromey.com>
561
562         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
563         Remove.
564         (gdb_exception_error): Rename from
565         gdb_exception_RETURN_MASK_ERROR.
566         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
567         (gdb_quit_bad_alloc): Update.
568         * aarch64-tdep.c: Update.
569         * ada-lang.c: Update.
570         * ada-typeprint.c: Update.
571         * ada-valprint.c: Update.
572         * amd64-tdep.c: Update.
573         * arch-utils.c: Update.
574         * break-catch-throw.c: Update.
575         * breakpoint.c: Update.
576         * btrace.c: Update.
577         * c-varobj.c: Update.
578         * cli/cli-cmds.c: Update.
579         * cli/cli-interp.c: Update.
580         * cli/cli-script.c: Update.
581         * common/common-exceptions.c: Update.
582         * common/new-op.c: Update.
583         * common/selftest.c: Update.
584         * compile/compile-c-symbols.c: Update.
585         * compile/compile-cplus-symbols.c: Update.
586         * compile/compile-object-load.c: Update.
587         * compile/compile-object-run.c: Update.
588         * completer.c: Update.
589         * corelow.c: Update.
590         * cp-abi.c: Update.
591         * cp-support.c: Update.
592         * cp-valprint.c: Update.
593         * darwin-nat.c: Update.
594         * disasm-selftests.c: Update.
595         * dtrace-probe.c: Update.
596         * dwarf-index-cache.c: Update.
597         * dwarf-index-write.c: Update.
598         * dwarf2-frame-tailcall.c: Update.
599         * dwarf2-frame.c: Update.
600         * dwarf2loc.c: Update.
601         * dwarf2read.c: Update.
602         * eval.c: Update.
603         * event-loop.c: Update.
604         * event-top.c: Update.
605         * exec.c: Update.
606         * f-valprint.c: Update.
607         * fbsd-tdep.c: Update.
608         * frame-unwind.c: Update.
609         * frame.c: Update.
610         * gdbtypes.c: Update.
611         * gnu-v3-abi.c: Update.
612         * guile/guile-internal.h: Update.
613         * guile/scm-block.c: Update.
614         * guile/scm-breakpoint.c: Update.
615         * guile/scm-cmd.c: Update.
616         * guile/scm-disasm.c: Update.
617         * guile/scm-frame.c: Update.
618         * guile/scm-lazy-string.c: Update.
619         * guile/scm-math.c: Update.
620         * guile/scm-param.c: Update.
621         * guile/scm-ports.c: Update.
622         * guile/scm-pretty-print.c: Update.
623         * guile/scm-symbol.c: Update.
624         * guile/scm-symtab.c: Update.
625         * guile/scm-type.c: Update.
626         * guile/scm-value.c: Update.
627         * i386-linux-tdep.c: Update.
628         * i386-tdep.c: Update.
629         * inf-loop.c: Update.
630         * infcall.c: Update.
631         * infcmd.c: Update.
632         * infrun.c: Update.
633         * jit.c: Update.
634         * language.c: Update.
635         * linespec.c: Update.
636         * linux-fork.c: Update.
637         * linux-nat.c: Update.
638         * linux-tdep.c: Update.
639         * linux-thread-db.c: Update.
640         * main.c: Update.
641         * mi/mi-cmd-break.c: Update.
642         * mi/mi-cmd-stack.c: Update.
643         * mi/mi-interp.c: Update.
644         * mi/mi-main.c: Update.
645         * objc-lang.c: Update.
646         * p-valprint.c: Update.
647         * parse.c: Update.
648         * ppc-linux-tdep.c: Update.
649         * printcmd.c: Update.
650         * python/py-arch.c: Update.
651         * python/py-breakpoint.c: Update.
652         * python/py-cmd.c: Update.
653         * python/py-finishbreakpoint.c: Update.
654         * python/py-frame.c: Update.
655         * python/py-framefilter.c: Update.
656         * python/py-gdb-readline.c: Update.
657         * python/py-inferior.c: Update.
658         * python/py-infthread.c: Update.
659         * python/py-lazy-string.c: Update.
660         * python/py-linetable.c: Update.
661         * python/py-objfile.c: Update.
662         * python/py-param.c: Update.
663         * python/py-prettyprint.c: Update.
664         * python/py-progspace.c: Update.
665         * python/py-record-btrace.c: Update.
666         * python/py-record.c: Update.
667         * python/py-symbol.c: Update.
668         * python/py-type.c: Update.
669         * python/py-unwind.c: Update.
670         * python/py-utils.c: Update.
671         * python/py-value.c: Update.
672         * python/python.c: Update.
673         * record-btrace.c: Update.
674         * record-full.c: Update.
675         * remote-fileio.c: Update.
676         * remote.c: Update.
677         * riscv-tdep.c: Update.
678         * rs6000-aix-tdep.c: Update.
679         * rs6000-tdep.c: Update.
680         * rust-exp.y: Update.
681         * rust-lang.c: Update.
682         * s390-tdep.c: Update.
683         * selftest-arch.c: Update.
684         * solib-dsbt.c: Update.
685         * solib-frv.c: Update.
686         * solib-spu.c: Update.
687         * solib-svr4.c: Update.
688         * solib.c: Update.
689         * sparc64-linux-tdep.c: Update.
690         * stack.c: Update.
691         * symfile-mem.c: Update.
692         * symmisc.c: Update.
693         * target.c: Update.
694         * thread.c: Update.
695         * top.c: Update.
696         * tracefile-tfile.c: Update.
697         * tui/tui.c: Update.
698         * typeprint.c: Update.
699         * unittests/cli-utils-selftests.c: Update.
700         * unittests/parse-connection-spec-selftests.c: Update.
701         * valops.c: Update.
702         * valprint.c: Update.
703         * value.c: Update.
704         * varobj.c: Update.
705         * windows-nat.c: Update.
706         * x86-linux-nat.c: Update.
707         * xml-support.c: Update.
708
709 2019-04-08  Tom Tromey  <tom@tromey.com>
710
711         * xml-support.c: Use C++ exception handling.
712         * x86-linux-nat.c: Use C++ exception handling.
713         * windows-nat.c: Use C++ exception handling.
714         * varobj.c: Use C++ exception handling.
715         * value.c: Use C++ exception handling.
716         * valprint.c: Use C++ exception handling.
717         * valops.c: Use C++ exception handling.
718         * unittests/parse-connection-spec-selftests.c: Use C++ exception
719         handling.
720         * unittests/cli-utils-selftests.c: Use C++ exception handling.
721         * typeprint.c: Use C++ exception handling.
722         * tui/tui.c: Use C++ exception handling.
723         * tracefile-tfile.c: Use C++ exception handling.
724         * top.c: Use C++ exception handling.
725         * thread.c: Use C++ exception handling.
726         * target.c: Use C++ exception handling.
727         * symmisc.c: Use C++ exception handling.
728         * symfile-mem.c: Use C++ exception handling.
729         * stack.c: Use C++ exception handling.
730         * sparc64-linux-tdep.c: Use C++ exception handling.
731         * solib.c: Use C++ exception handling.
732         * solib-svr4.c: Use C++ exception handling.
733         * solib-spu.c: Use C++ exception handling.
734         * solib-frv.c: Use C++ exception handling.
735         * solib-dsbt.c: Use C++ exception handling.
736         * selftest-arch.c: Use C++ exception handling.
737         * s390-tdep.c: Use C++ exception handling.
738         * rust-lang.c: Use C++ exception handling.
739         * rust-exp.y: Use C++ exception handling.
740         * rs6000-tdep.c: Use C++ exception handling.
741         * rs6000-aix-tdep.c: Use C++ exception handling.
742         * riscv-tdep.c: Use C++ exception handling.
743         * remote.c: Use C++ exception handling.
744         * remote-fileio.c: Use C++ exception handling.
745         * record-full.c: Use C++ exception handling.
746         * record-btrace.c: Use C++ exception handling.
747         * python/python.c: Use C++ exception handling.
748         * python/py-value.c: Use C++ exception handling.
749         * python/py-utils.c: Use C++ exception handling.
750         * python/py-unwind.c: Use C++ exception handling.
751         * python/py-type.c: Use C++ exception handling.
752         * python/py-symbol.c: Use C++ exception handling.
753         * python/py-record.c: Use C++ exception handling.
754         * python/py-record-btrace.c: Use C++ exception handling.
755         * python/py-progspace.c: Use C++ exception handling.
756         * python/py-prettyprint.c: Use C++ exception handling.
757         * python/py-param.c: Use C++ exception handling.
758         * python/py-objfile.c: Use C++ exception handling.
759         * python/py-linetable.c: Use C++ exception handling.
760         * python/py-lazy-string.c: Use C++ exception handling.
761         * python/py-infthread.c: Use C++ exception handling.
762         * python/py-inferior.c: Use C++ exception handling.
763         * python/py-gdb-readline.c: Use C++ exception handling.
764         * python/py-framefilter.c: Use C++ exception handling.
765         * python/py-frame.c: Use C++ exception handling.
766         * python/py-finishbreakpoint.c: Use C++ exception handling.
767         * python/py-cmd.c: Use C++ exception handling.
768         * python/py-breakpoint.c: Use C++ exception handling.
769         * python/py-arch.c: Use C++ exception handling.
770         * printcmd.c: Use C++ exception handling.
771         * ppc-linux-tdep.c: Use C++ exception handling.
772         * parse.c: Use C++ exception handling.
773         * p-valprint.c: Use C++ exception handling.
774         * objc-lang.c: Use C++ exception handling.
775         * mi/mi-main.c: Use C++ exception handling.
776         * mi/mi-interp.c: Use C++ exception handling.
777         * mi/mi-cmd-stack.c: Use C++ exception handling.
778         * mi/mi-cmd-break.c: Use C++ exception handling.
779         * main.c: Use C++ exception handling.
780         * linux-thread-db.c: Use C++ exception handling.
781         * linux-tdep.c: Use C++ exception handling.
782         * linux-nat.c: Use C++ exception handling.
783         * linux-fork.c: Use C++ exception handling.
784         * linespec.c: Use C++ exception handling.
785         * language.c: Use C++ exception handling.
786         * jit.c: Use C++ exception handling.
787         * infrun.c: Use C++ exception handling.
788         * infcmd.c: Use C++ exception handling.
789         * infcall.c: Use C++ exception handling.
790         * inf-loop.c: Use C++ exception handling.
791         * i386-tdep.c: Use C++ exception handling.
792         * i386-linux-tdep.c: Use C++ exception handling.
793         * guile/scm-value.c: Use C++ exception handling.
794         * guile/scm-type.c: Use C++ exception handling.
795         * guile/scm-symtab.c: Use C++ exception handling.
796         * guile/scm-symbol.c: Use C++ exception handling.
797         * guile/scm-pretty-print.c: Use C++ exception handling.
798         * guile/scm-ports.c: Use C++ exception handling.
799         * guile/scm-param.c: Use C++ exception handling.
800         * guile/scm-math.c: Use C++ exception handling.
801         * guile/scm-lazy-string.c: Use C++ exception handling.
802         * guile/scm-frame.c: Use C++ exception handling.
803         * guile/scm-disasm.c: Use C++ exception handling.
804         * guile/scm-cmd.c: Use C++ exception handling.
805         * guile/scm-breakpoint.c: Use C++ exception handling.
806         * guile/scm-block.c: Use C++ exception handling.
807         * guile/guile-internal.h: Use C++ exception handling.
808         * gnu-v3-abi.c: Use C++ exception handling.
809         * gdbtypes.c: Use C++ exception handling.
810         * frame.c: Use C++ exception handling.
811         * frame-unwind.c: Use C++ exception handling.
812         * fbsd-tdep.c: Use C++ exception handling.
813         * f-valprint.c: Use C++ exception handling.
814         * exec.c: Use C++ exception handling.
815         * event-top.c: Use C++ exception handling.
816         * event-loop.c: Use C++ exception handling.
817         * eval.c: Use C++ exception handling.
818         * dwarf2read.c: Use C++ exception handling.
819         * dwarf2loc.c: Use C++ exception handling.
820         * dwarf2-frame.c: Use C++ exception handling.
821         * dwarf2-frame-tailcall.c: Use C++ exception handling.
822         * dwarf-index-write.c: Use C++ exception handling.
823         * dwarf-index-cache.c: Use C++ exception handling.
824         * dtrace-probe.c: Use C++ exception handling.
825         * disasm-selftests.c: Use C++ exception handling.
826         * darwin-nat.c: Use C++ exception handling.
827         * cp-valprint.c: Use C++ exception handling.
828         * cp-support.c: Use C++ exception handling.
829         * cp-abi.c: Use C++ exception handling.
830         * corelow.c: Use C++ exception handling.
831         * completer.c: Use C++ exception handling.
832         * compile/compile-object-run.c: Use C++ exception handling.
833         * compile/compile-object-load.c: Use C++ exception handling.
834         * compile/compile-cplus-symbols.c: Use C++ exception handling.
835         * compile/compile-c-symbols.c: Use C++ exception handling.
836         * common/selftest.c: Use C++ exception handling.
837         * common/new-op.c: Use C++ exception handling.
838         * cli/cli-script.c: Use C++ exception handling.
839         * cli/cli-interp.c: Use C++ exception handling.
840         * cli/cli-cmds.c: Use C++ exception handling.
841         * c-varobj.c: Use C++ exception handling.
842         * btrace.c: Use C++ exception handling.
843         * breakpoint.c: Use C++ exception handling.
844         * break-catch-throw.c: Use C++ exception handling.
845         * arch-utils.c: Use C++ exception handling.
846         * amd64-tdep.c: Use C++ exception handling.
847         * ada-valprint.c: Use C++ exception handling.
848         * ada-typeprint.c: Use C++ exception handling.
849         * ada-lang.c: Use C++ exception handling.
850         * aarch64-tdep.c: Use C++ exception handling.
851
852 2019-04-08  Tom Tromey  <tom@tromey.com>
853
854         * xml-support.c (gdb_xml_parser::parse): Update.
855         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
856         * value.c (show_convenience): Update.
857         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
858         (test_parse_flags_qcs): Update.
859         * thread.c (thr_try_catch_cmd): Update.
860         * target.c (target_translate_tls_address): Update.
861         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
862         (info_frame_command_core, frame_apply_command_count): Update.
863         * rust-exp.y (rust_lex_exception_test): Update.
864         * riscv-tdep.c (riscv_print_one_register_info): Update.
865         * remote.c (remote_target::enable_btrace): Update.
866         * record-btrace.c (record_btrace_enable_warn): Update.
867         * python/py-utils.c (gdbpy_convert_exception): Update.
868         * printcmd.c (do_one_display, print_variable_and_value): Update.
869         * mi/mi-main.c (mi_print_exception): Update.
870         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
871         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
872         * linux-nat.c (linux_nat_target::attach): Update.
873         * linux-fork.c (class scoped_switch_fork_info): Update.
874         * infrun.c (displaced_step_prepare): Update.
875         * infcall.c (call_function_by_hand_dummy): Update.
876         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
877         * gnu-v3-abi.c (print_one_vtable): Update.
878         * frame.c (get_prev_frame_always): Update.
879         * f-valprint.c (info_common_command_for_block): Update.
880         * exec.c (try_open_exec_file): Update.
881         * exceptions.c (print_exception, exception_print)
882         (exception_fprintf, exception_print_same): Update.
883         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
884         * dwarf-index-cache.c (index_cache::store)
885         (index_cache::lookup_gdb_index): Update.
886         * darwin-nat.c (maybe_cache_shell): Update.
887         * cp-valprint.c (cp_print_value_fields): Update.
888         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
889         (gcc_cplus_symbol_address): Update.
890         * compile/compile-c-symbols.c (gcc_convert_symbol)
891         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
892         * common/selftest.c: Update.
893         * common/common-exceptions.h (struct gdb_exception) <message>: Now
894         a std::string.
895         (exception_try_scope_entry, exception_try_scope_exit): Don't
896         declare.
897         (struct exception_try_scope): Remove.
898         (TRY): Don't use exception_try_scope.
899         (struct gdb_exception): Add constructor, operator=.
900         <what>: New method.
901         (struct gdb_exception_RETURN_MASK_ALL)
902         (struct gdb_exception_RETURN_MASK_ERROR)
903         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
904         (struct gdb_quit_bad_alloc): Update.
905         * common/common-exceptions.c (exception_none): Change
906         initializer.
907         (struct catcher) <state, exception>: Initialize inline.
908         <prev>: Remove member.
909         (current_catcher): Remove.
910         (catchers): New global.
911         (exceptions_state_mc_init): Simplify.
912         (catcher_pop): Remove.
913         (exceptions_state_mc, exceptions_state_mc_catch): Update.
914         (try_scope_depth, exception_try_scope_entry)
915         (exception_try_scope_exit): Remove.
916         (throw_exception_sjlj): Update.
917         (exception_messages, exception_messages_size): Remove.
918         (throw_it): Simplify.
919         (gdb_exception_sliced_copy): Remove.
920         (throw_exception_cxx): Update.
921         * cli/cli-script.c (script_from_file): Update.
922         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
923         Update.
924         * ada-valprint.c (ada_val_print): Update.
925         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
926         (create_excep_cond_exprs): Update.
927
928 2019-04-08  Tom Tromey  <tom@tromey.com>
929
930         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
931         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
932         (TRY, CATCH, END_CATCH): Remove some definitions.
933         * common/common-exceptions.c: Don't use GDB_XCPT.
934         (catcher_list_size): Remove.
935         (throw_exception, throw_it): Simplify.
936
937 2019-04-05  Tom Tromey  <tom@tromey.com>
938
939         Revert the header-sorting patch.
940         * ft32-tdep.c: Revert.
941         * frv-tdep.c: Revert.
942         * frv-linux-tdep.c: Revert.
943         * frame.c: Revert.
944         * frame-unwind.c: Revert.
945         * frame-base.c: Revert.
946         * fork-child.c: Revert.
947         * findvar.c: Revert.
948         * findcmd.c: Revert.
949         * filesystem.c: Revert.
950         * filename-seen-cache.h: Revert.
951         * filename-seen-cache.c: Revert.
952         * fbsd-tdep.c: Revert.
953         * fbsd-nat.h: Revert.
954         * fbsd-nat.c: Revert.
955         * f-valprint.c: Revert.
956         * f-typeprint.c: Revert.
957         * f-lang.c: Revert.
958         * extension.h: Revert.
959         * extension.c: Revert.
960         * extension-priv.h: Revert.
961         * expprint.c: Revert.
962         * exec.h: Revert.
963         * exec.c: Revert.
964         * exceptions.c: Revert.
965         * event-top.c: Revert.
966         * event-loop.c: Revert.
967         * eval.c: Revert.
968         * elfread.c: Revert.
969         * dwarf2read.h: Revert.
970         * dwarf2read.c: Revert.
971         * dwarf2loc.c: Revert.
972         * dwarf2expr.h: Revert.
973         * dwarf2expr.c: Revert.
974         * dwarf2-frame.c: Revert.
975         * dwarf2-frame-tailcall.c: Revert.
976         * dwarf-index-write.h: Revert.
977         * dwarf-index-write.c: Revert.
978         * dwarf-index-common.c: Revert.
979         * dwarf-index-cache.h: Revert.
980         * dwarf-index-cache.c: Revert.
981         * dummy-frame.c: Revert.
982         * dtrace-probe.c: Revert.
983         * disasm.h: Revert.
984         * disasm.c: Revert.
985         * disasm-selftests.c: Revert.
986         * dictionary.c: Revert.
987         * dicos-tdep.c: Revert.
988         * demangle.c: Revert.
989         * dcache.h: Revert.
990         * dcache.c: Revert.
991         * darwin-nat.h: Revert.
992         * darwin-nat.c: Revert.
993         * darwin-nat-info.c: Revert.
994         * d-valprint.c: Revert.
995         * d-namespace.c: Revert.
996         * d-lang.c: Revert.
997         * ctf.c: Revert.
998         * csky-tdep.c: Revert.
999         * csky-linux-tdep.c: Revert.
1000         * cris-tdep.c: Revert.
1001         * cris-linux-tdep.c: Revert.
1002         * cp-valprint.c: Revert.
1003         * cp-support.c: Revert.
1004         * cp-namespace.c: Revert.
1005         * cp-abi.c: Revert.
1006         * corelow.c: Revert.
1007         * corefile.c: Revert.
1008         * continuations.c: Revert.
1009         * completer.h: Revert.
1010         * completer.c: Revert.
1011         * complaints.c: Revert.
1012         * coffread.c: Revert.
1013         * coff-pe-read.c: Revert.
1014         * cli-out.h: Revert.
1015         * cli-out.c: Revert.
1016         * charset.c: Revert.
1017         * c-varobj.c: Revert.
1018         * c-valprint.c: Revert.
1019         * c-typeprint.c: Revert.
1020         * c-lang.c: Revert.
1021         * buildsym.c: Revert.
1022         * buildsym-legacy.c: Revert.
1023         * build-id.h: Revert.
1024         * build-id.c: Revert.
1025         * btrace.c: Revert.
1026         * bsd-uthread.c: Revert.
1027         * breakpoint.h: Revert.
1028         * breakpoint.c: Revert.
1029         * break-catch-throw.c: Revert.
1030         * break-catch-syscall.c: Revert.
1031         * break-catch-sig.c: Revert.
1032         * blockframe.c: Revert.
1033         * block.c: Revert.
1034         * bfin-tdep.c: Revert.
1035         * bfin-linux-tdep.c: Revert.
1036         * bfd-target.c: Revert.
1037         * bcache.c: Revert.
1038         * ax-general.c: Revert.
1039         * ax-gdb.h: Revert.
1040         * ax-gdb.c: Revert.
1041         * avr-tdep.c: Revert.
1042         * auxv.c: Revert.
1043         * auto-load.c: Revert.
1044         * arm-wince-tdep.c: Revert.
1045         * arm-tdep.c: Revert.
1046         * arm-symbian-tdep.c: Revert.
1047         * arm-pikeos-tdep.c: Revert.
1048         * arm-obsd-tdep.c: Revert.
1049         * arm-nbsd-tdep.c: Revert.
1050         * arm-nbsd-nat.c: Revert.
1051         * arm-linux-tdep.c: Revert.
1052         * arm-linux-nat.c: Revert.
1053         * arm-fbsd-tdep.c: Revert.
1054         * arm-fbsd-nat.c: Revert.
1055         * arm-bsd-tdep.c: Revert.
1056         * arch-utils.c: Revert.
1057         * arc-tdep.c: Revert.
1058         * arc-newlib-tdep.c: Revert.
1059         * annotate.h: Revert.
1060         * annotate.c: Revert.
1061         * amd64-windows-tdep.c: Revert.
1062         * amd64-windows-nat.c: Revert.
1063         * amd64-tdep.c: Revert.
1064         * amd64-sol2-tdep.c: Revert.
1065         * amd64-obsd-tdep.c: Revert.
1066         * amd64-obsd-nat.c: Revert.
1067         * amd64-nbsd-tdep.c: Revert.
1068         * amd64-nbsd-nat.c: Revert.
1069         * amd64-nat.c: Revert.
1070         * amd64-linux-tdep.c: Revert.
1071         * amd64-linux-nat.c: Revert.
1072         * amd64-fbsd-tdep.c: Revert.
1073         * amd64-fbsd-nat.c: Revert.
1074         * amd64-dicos-tdep.c: Revert.
1075         * amd64-darwin-tdep.c: Revert.
1076         * amd64-bsd-nat.c: Revert.
1077         * alpha-tdep.c: Revert.
1078         * alpha-obsd-tdep.c: Revert.
1079         * alpha-nbsd-tdep.c: Revert.
1080         * alpha-mdebug-tdep.c: Revert.
1081         * alpha-linux-tdep.c: Revert.
1082         * alpha-linux-nat.c: Revert.
1083         * alpha-bsd-tdep.c: Revert.
1084         * alpha-bsd-nat.c: Revert.
1085         * aix-thread.c: Revert.
1086         * agent.c: Revert.
1087         * addrmap.c: Revert.
1088         * ada-varobj.c: Revert.
1089         * ada-valprint.c: Revert.
1090         * ada-typeprint.c: Revert.
1091         * ada-tasks.c: Revert.
1092         * ada-lang.c: Revert.
1093         * aarch64-tdep.c: Revert.
1094         * aarch64-ravenscar-thread.c: Revert.
1095         * aarch64-newlib-tdep.c: Revert.
1096         * aarch64-linux-tdep.c: Revert.
1097         * aarch64-linux-nat.c: Revert.
1098         * aarch64-fbsd-tdep.c: Revert.
1099         * aarch64-fbsd-nat.c: Revert.
1100         * aarch32-linux-nat.c: Revert.
1101
1102 2019-04-05  Tom Tromey  <tom@tromey.com>
1103
1104         * ft32-tdep.c: Sort headers.
1105         * frv-tdep.c: Sort headers.
1106         * frv-linux-tdep.c: Sort headers.
1107         * frame.c: Sort headers.
1108         * frame-unwind.c: Sort headers.
1109         * frame-base.c: Sort headers.
1110         * fork-child.c: Sort headers.
1111         * findvar.c: Sort headers.
1112         * findcmd.c: Sort headers.
1113         * filesystem.c: Sort headers.
1114         * filename-seen-cache.h: Sort headers.
1115         * filename-seen-cache.c: Sort headers.
1116         * fbsd-tdep.c: Sort headers.
1117         * fbsd-nat.h: Sort headers.
1118         * fbsd-nat.c: Sort headers.
1119         * f-valprint.c: Sort headers.
1120         * f-typeprint.c: Sort headers.
1121         * f-lang.c: Sort headers.
1122         * extension.h: Sort headers.
1123         * extension.c: Sort headers.
1124         * extension-priv.h: Sort headers.
1125         * expprint.c: Sort headers.
1126         * exec.h: Sort headers.
1127         * exec.c: Sort headers.
1128         * exceptions.c: Sort headers.
1129         * event-top.c: Sort headers.
1130         * event-loop.c: Sort headers.
1131         * eval.c: Sort headers.
1132         * elfread.c: Sort headers.
1133         * dwarf2read.h: Sort headers.
1134         * dwarf2read.c: Sort headers.
1135         * dwarf2loc.c: Sort headers.
1136         * dwarf2expr.h: Sort headers.
1137         * dwarf2expr.c: Sort headers.
1138         * dwarf2-frame.c: Sort headers.
1139         * dwarf2-frame-tailcall.c: Sort headers.
1140         * dwarf-index-write.h: Sort headers.
1141         * dwarf-index-write.c: Sort headers.
1142         * dwarf-index-common.c: Sort headers.
1143         * dwarf-index-cache.h: Sort headers.
1144         * dwarf-index-cache.c: Sort headers.
1145         * dummy-frame.c: Sort headers.
1146         * dtrace-probe.c: Sort headers.
1147         * disasm.h: Sort headers.
1148         * disasm.c: Sort headers.
1149         * disasm-selftests.c: Sort headers.
1150         * dictionary.c: Sort headers.
1151         * dicos-tdep.c: Sort headers.
1152         * demangle.c: Sort headers.
1153         * dcache.h: Sort headers.
1154         * dcache.c: Sort headers.
1155         * darwin-nat.h: Sort headers.
1156         * darwin-nat.c: Sort headers.
1157         * darwin-nat-info.c: Sort headers.
1158         * d-valprint.c: Sort headers.
1159         * d-namespace.c: Sort headers.
1160         * d-lang.c: Sort headers.
1161         * ctf.c: Sort headers.
1162         * csky-tdep.c: Sort headers.
1163         * csky-linux-tdep.c: Sort headers.
1164         * cris-tdep.c: Sort headers.
1165         * cris-linux-tdep.c: Sort headers.
1166         * cp-valprint.c: Sort headers.
1167         * cp-support.c: Sort headers.
1168         * cp-namespace.c: Sort headers.
1169         * cp-abi.c: Sort headers.
1170         * corelow.c: Sort headers.
1171         * corefile.c: Sort headers.
1172         * continuations.c: Sort headers.
1173         * completer.h: Sort headers.
1174         * completer.c: Sort headers.
1175         * complaints.c: Sort headers.
1176         * coffread.c: Sort headers.
1177         * coff-pe-read.c: Sort headers.
1178         * cli-out.h: Sort headers.
1179         * cli-out.c: Sort headers.
1180         * charset.c: Sort headers.
1181         * c-varobj.c: Sort headers.
1182         * c-valprint.c: Sort headers.
1183         * c-typeprint.c: Sort headers.
1184         * c-lang.c: Sort headers.
1185         * buildsym.c: Sort headers.
1186         * buildsym-legacy.c: Sort headers.
1187         * build-id.h: Sort headers.
1188         * build-id.c: Sort headers.
1189         * btrace.c: Sort headers.
1190         * bsd-uthread.c: Sort headers.
1191         * breakpoint.h: Sort headers.
1192         * breakpoint.c: Sort headers.
1193         * break-catch-throw.c: Sort headers.
1194         * break-catch-syscall.c: Sort headers.
1195         * break-catch-sig.c: Sort headers.
1196         * blockframe.c: Sort headers.
1197         * block.c: Sort headers.
1198         * bfin-tdep.c: Sort headers.
1199         * bfin-linux-tdep.c: Sort headers.
1200         * bfd-target.c: Sort headers.
1201         * bcache.c: Sort headers.
1202         * ax-general.c: Sort headers.
1203         * ax-gdb.h: Sort headers.
1204         * ax-gdb.c: Sort headers.
1205         * avr-tdep.c: Sort headers.
1206         * auxv.c: Sort headers.
1207         * auto-load.c: Sort headers.
1208         * arm-wince-tdep.c: Sort headers.
1209         * arm-tdep.c: Sort headers.
1210         * arm-symbian-tdep.c: Sort headers.
1211         * arm-pikeos-tdep.c: Sort headers.
1212         * arm-obsd-tdep.c: Sort headers.
1213         * arm-nbsd-tdep.c: Sort headers.
1214         * arm-nbsd-nat.c: Sort headers.
1215         * arm-linux-tdep.c: Sort headers.
1216         * arm-linux-nat.c: Sort headers.
1217         * arm-fbsd-tdep.c: Sort headers.
1218         * arm-fbsd-nat.c: Sort headers.
1219         * arm-bsd-tdep.c: Sort headers.
1220         * arch-utils.c: Sort headers.
1221         * arc-tdep.c: Sort headers.
1222         * arc-newlib-tdep.c: Sort headers.
1223         * annotate.h: Sort headers.
1224         * annotate.c: Sort headers.
1225         * amd64-windows-tdep.c: Sort headers.
1226         * amd64-windows-nat.c: Sort headers.
1227         * amd64-tdep.c: Sort headers.
1228         * amd64-sol2-tdep.c: Sort headers.
1229         * amd64-obsd-tdep.c: Sort headers.
1230         * amd64-obsd-nat.c: Sort headers.
1231         * amd64-nbsd-tdep.c: Sort headers.
1232         * amd64-nbsd-nat.c: Sort headers.
1233         * amd64-nat.c: Sort headers.
1234         * amd64-linux-tdep.c: Sort headers.
1235         * amd64-linux-nat.c: Sort headers.
1236         * amd64-fbsd-tdep.c: Sort headers.
1237         * amd64-fbsd-nat.c: Sort headers.
1238         * amd64-dicos-tdep.c: Sort headers.
1239         * amd64-darwin-tdep.c: Sort headers.
1240         * amd64-bsd-nat.c: Sort headers.
1241         * alpha-tdep.c: Sort headers.
1242         * alpha-obsd-tdep.c: Sort headers.
1243         * alpha-nbsd-tdep.c: Sort headers.
1244         * alpha-mdebug-tdep.c: Sort headers.
1245         * alpha-linux-tdep.c: Sort headers.
1246         * alpha-linux-nat.c: Sort headers.
1247         * alpha-bsd-tdep.c: Sort headers.
1248         * alpha-bsd-nat.c: Sort headers.
1249         * aix-thread.c: Sort headers.
1250         * agent.c: Sort headers.
1251         * addrmap.c: Sort headers.
1252         * ada-varobj.c: Sort headers.
1253         * ada-valprint.c: Sort headers.
1254         * ada-typeprint.c: Sort headers.
1255         * ada-tasks.c: Sort headers.
1256         * ada-lang.c: Sort headers.
1257         * aarch64-tdep.c: Sort headers.
1258         * aarch64-ravenscar-thread.c: Sort headers.
1259         * aarch64-newlib-tdep.c: Sort headers.
1260         * aarch64-linux-tdep.c: Sort headers.
1261         * aarch64-linux-nat.c: Sort headers.
1262         * aarch64-fbsd-tdep.c: Sort headers.
1263         * aarch64-fbsd-nat.c: Sort headers.
1264         * aarch32-linux-nat.c: Sort headers.
1265
1266 2019-04-04  Tom Tromey  <tom@tromey.com>
1267
1268         * varobj.c (varobj_create): Update.
1269         * rust-exp.y (struct rust_parser) <update_innermost_block,
1270         lookup_symbol>: New methods.
1271         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
1272         Rename.
1273         (rust_parser::rust_lookup_type)
1274         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1275         * printcmd.c (display_command, do_one_display): Update.
1276         * parser-defs.h (struct parser_state) <parser_state>: Add
1277         "tracker" parameter.
1278         (block_tracker): New member.
1279         (class innermost_block_tracker) <innermost_block_tracker>: Add
1280         "types" parameter.
1281         <reset>: Remove method.
1282         (innermost_block): Don't declare.
1283         (null_post_parser): Update.
1284         * parse.c (innermost_block): Remove global.
1285         (write_dollar_variable): Update.
1286         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
1287         Remove "tracker_types" parameter.
1288         (parse_expression): Add "tracker" parameter.
1289         (parse_expression_for_completion): Update.
1290         (null_post_parser): Add "tracker" parameter.
1291         * p-exp.y: Update rules.
1292         * m2-exp.y: Update rules.
1293         * language.h (struct language_defn) <la_post_parser>: Add
1294         "tracker" parameter.
1295         * go-exp.y: Update rules.
1296         * f-exp.y: Update rules.
1297         * expression.h (parse_expression, parse_exp_1): Add "tracker"
1298         parameter.
1299         * d-exp.y: Update rules.
1300         * c-exp.y: Update rules.
1301         * breakpoint.c (set_breakpoint_condition): Create an
1302         innermost_block_tracker.
1303         (watch_command_1): Likewise.
1304         * ada-lang.c (resolve): Add "tracker" parameter.
1305         (resolve_subexp): Likewise.
1306         * ada-exp.y (write_var_from_sym): Update.
1307
1308 2019-04-04  Tom Tromey  <tom@tromey.com>
1309
1310         * type-stack.h: New file.
1311         * type-stack.c: New file.
1312         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
1313         type-stack.h.
1314         (insert_into_type_stack, insert_type, push_type, push_type_int)
1315         (insert_type_address_space, pop_type, pop_type_int)
1316         (pop_typelist, pop_type_stack, append_type_stack)
1317         (push_type_stack, get_type_stack, push_typelist)
1318         (follow_type_instance_flags, follow_types): Don't declare.
1319         * parse.c (type_stack): Remove global.
1320         (parse_exp_in_context): Update.
1321         (insert_into_type_stack, insert_type, push_type, push_type_int)
1322         (insert_type_address_space, pop_type, pop_type_int)
1323         (pop_typelist, pop_type_stack, append_type_stack)
1324         (push_type_stack, get_type_stack, push_typelist)
1325         (follow_type_instance_flags, follow_types): Remove (moved to
1326         type-stack.c).
1327         * f-exp.y (type_stack): New global.
1328         Update rules.
1329         (push_kind_type, f_parse): Update.
1330         * d-exp.y (type_stack): New global.
1331         Update rules.
1332         (d_parse): Update.
1333         * c-exp.y (struct c_parse_state) <type_stack>: New member.
1334         Update rules.
1335         * Makefile.in (COMMON_SFILES): Add type-stack.c.
1336         (HFILES_NO_SRCDIR): Add type-stack.h.
1337
1338 2019-04-04  Tom Tromey  <tom@tromey.com>
1339
1340         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
1341         (rust_parser::convert_ast_to_expression, rust_parse)
1342         (rust_lex_test_completion, rust_lex_tests): Update.
1343         * parser-defs.h (struct expr_completion_state): New.
1344         (struct parser_state) <parser_state>: Add completion parameter.
1345         <mark_struct_expression, mark_completion_tag>: New methods.
1346         <parse_completion, m_completion_state>: New members.
1347         (prefixify_expression, null_post_parser): Update.
1348         (mark_struct_expression, mark_completion_tag): Don't declare.
1349         * parse.c (parse_completion, expout_last_struct)
1350         (expout_tag_completion_type, expout_completion_name): Remove
1351         globals.
1352         (parser_state::mark_struct_expression)
1353         (parser_state::mark_completion_tag): Now methods.
1354         (prefixify_expression): Add last_struct parameter.
1355         (prefixify_subexp): Likewise.
1356         (parse_exp_1): Update.
1357         (parse_exp_in_context): Add cstate parameter.  Update.
1358         (parse_expression_for_completion): Create an
1359         expr_completion_state.
1360         (null_post_parser): Add "completion" parameter.
1361         * p-exp.y: Update rules.
1362         (yylex): Update.
1363         * language.h (struct language_defn) <la_post_parser>: Add
1364         "completing" parameter.
1365         * go-exp.y: Update rules.
1366         (lex_one_token): Update.
1367         * expression.h (parse_completion): Don't declare.
1368         * d-exp.y: Update rules.
1369         (lex_one_token): Update rules.
1370         * c-exp.y: Update rules.
1371         (lex_one_token): Update.
1372         * ada-lang.c (resolve): Add "parse_completion" parameter.
1373         (resolve_subexp): Likewise.
1374         (ada_resolve_function): Likewise.
1375
1376 2019-04-04  Tom Tromey  <tom@tromey.com>
1377
1378         * parser-defs.h (struct parser_state) <start_arglist,
1379         end_arglist>: New methods.
1380         <arglist_len, m_funcall_chain>: New members.
1381         (arglist_len, start_arglist, end_arglist): Don't declare.
1382         * parse.c (arglist_len, funcall_chain): Remove global.
1383         (start_arglist, end_arglist): Remove functions.
1384         (parse_exp_in_context): Update.
1385         * p-exp.y: Update rules.
1386         * m2-exp.y: Update rules.
1387         * go-exp.y: Update rules.
1388         * f-exp.y: Update rules.
1389         * d-exp.y: Update rules.
1390         * c-exp.y: Update rules.
1391
1392 2019-04-04  Tom Tromey  <tom@tromey.com>
1393
1394         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
1395         lex_operator, push_back>: New methods.
1396         Update all rules.
1397         (rust_parser::lex_hex, lex_escape): Rename and update.
1398         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
1399         (rust_parser::lex_operator): Rename and update.
1400         (rust_parser::lex_number, rustyylex, rustyyerror)
1401         (rust_lex_test_init, rust_lex_test_sequence)
1402         (rust_lex_test_push_back, rust_lex_tests): Update.
1403         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
1404         parameter.
1405         <lexptr, prev_lexptr>: New members.
1406         (lexptr, prev_lexptr): Don't declare.
1407         * parse.c (lexptr, prev_lexptr): Remove globals.
1408         (parse_exp_in_context): Update.
1409         * p-exp.y (yylex, yyerror): Update.
1410         * m2-exp.y (parse_number, yylex, yyerror): Update.
1411         * go-exp.y (lex_one_token, yyerror): Update.
1412         * f-exp.y (match_string_literal, yylex, yyerror): Update.
1413         * d-exp.y (lex_one_token, yyerror): Update.
1414         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
1415         (lex_one_token, yyerror): Update.
1416         * ada-lex.l (YY_INPUT): Update.
1417         (rewind_to_char): Update.
1418         * ada-exp.y (yyerror): Update.
1419
1420 2019-04-04  Tom Tromey  <tom@tromey.com>
1421
1422         * rust-exp.y (rustyylex, rust_lex_tests): Update.
1423         * parser-defs.h (struct parser_state) <parser_state>: Add new
1424         parameter.
1425         <comma_terminates>: New member.
1426         (comma_terminates): Don't declare global.
1427         * parse.c (comma_terminates): Remove global.
1428         (parse_exp_in_context): Update.
1429         * p-exp.y (yylex): Update.
1430         * m2-exp.y (yylex): Update.
1431         * go-exp.y (lex_one_token): Update.
1432         * f-exp.y (yylex): Update.
1433         * d-exp.y (lex_one_token): Update.
1434         * c-exp.y (lex_one_token): Update.
1435         * ada-lex.l: Update.
1436
1437 2019-04-04  Tom Tromey  <tom@tromey.com>
1438
1439         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
1440         (rustyylex, rust_lex_test_init, rust_lex_test_one)
1441         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
1442         * parser-defs.h (paren_depth): Don't declare.
1443         * parse.c (paren_depth): Remove global.
1444         (parse_exp_in_context): Update.
1445         * p-exp.y (paren_depth): New global.
1446         (pascal_parse): Initialize it.
1447         * m2-exp.y (paren_depth): New global.
1448         (m2_parse): Initialize it.
1449         * go-exp.y (paren_depth): New global.
1450         (go_parse): Initialize it.
1451         * f-exp.y (paren_depth): New global.
1452         (f_parse): Initialize it.
1453         * d-exp.y (paren_depth): New global.
1454         (d_parse): Initialize it.
1455         * c-exp.y (paren_depth): New global.
1456         (c_parse): Initialize it.
1457         * ada-lex.l (paren_depth): New global.
1458         (lexer_init): Initialize it.
1459
1460 2019-04-04  Tom Tromey  <tom@tromey.com>
1461
1462         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
1463         (rust_parser::convert_ast_to_type)
1464         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1465         * parser-defs.h (struct parser_state) <parser_state>: Add
1466         parameters.  Initialize new members.
1467         <expression_context_block, expression_context_pc>: New members.
1468         * parse.c (expression_context_block, expression_context_pc):
1469         Remove globals.
1470         (parse_exp_in_context): Update.
1471         * p-exp.y: Update all rules.
1472         (yylex): Update.
1473         * m2-exp.y: Update all rules.
1474         (yylex): Update.
1475         * go-exp.y (yylex): Update.
1476         * f-exp.y (yylex): Update.
1477         * d-exp.y: Update all rules.
1478         (yylex): Update.
1479         * c-exp.y: Update all rules.
1480         (lex_one_token, classify_name, yylex, c_parse): Update.
1481         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
1482
1483 2019-04-04  Tom Tromey  <tom@tromey.com>
1484
1485         * gdbarch.h, gdbarch.c: Rebuild.
1486         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
1487         * stap-probe.h: 
1488         (struct stap_parse_info): Replace "parser_state" with
1489         "expr_builder".
1490         * parser-defs.h (struct expr_builder): Rename from "parser_state".
1491         (parser_state): New class.
1492         * parse.c (expr_builder): Rename.
1493         (expr_builder::release): Rename.
1494         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
1495         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
1496         (write_exp_elt_longcst, write_exp_elt_floatcst)
1497         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
1498         (write_exp_string_vector, write_exp_bitstring)
1499         (write_exp_msymbol, mark_struct_expression)
1500         (write_dollar_variable)
1501         (insert_type_address_space, increase_expout_size): Replace
1502         "parser_state" with "expr_builder".
1503         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
1504         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
1505         "parser_state" with "expr_builder".
1506
1507 2019-04-04  Tom Tromey  <tom@tromey.com>
1508
1509         * rust-exp.y: Replace "parse_language" with method call.
1510         * p-exp.y: 
1511         (yylex): Replace "parse_language" with method call.
1512         * m2-exp.y: 
1513         (yylex): Replace "parse_language" with method call.
1514         * go-exp.y (classify_name): Replace "parse_language" with method
1515         call.
1516         * f-exp.y (yylex): Replace "parse_language" with method call.
1517         * d-exp.y (lex_one_token): Replace "parse_language" with method
1518         call.
1519         * c-exp.y: 
1520         (lex_one_token, classify_name, yylex): Replace "parse_language"
1521         with method call.
1522         * ada-exp.y (find_primitive_type, type_char)
1523         (type_system_address): Replace "parse_language" with method call.
1524
1525 2019-04-04  Tom Tromey  <tom@tromey.com>
1526
1527         * rust-exp.y: Replace "parse_gdbarch" with method call.
1528         * parse.c (write_dollar_variable, insert_type_address_space):
1529         Replace "parse_gdbarch" with method call.
1530         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
1531         call.
1532         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
1533         call.
1534         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
1535         "parse_gdbarch" with method call.
1536         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
1537         with method call.
1538         * f-exp.y (parse_type, parse_f_type, yylex): Replace
1539         "parse_gdbarch" with method call.
1540         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
1541         "parse_gdbarch" with method call.
1542         * c-exp.y (parse_type, parse_number, classify_name): Replace
1543         "parse_gdbarch" with method call.
1544         * ada-lex.l: Replace "parse_gdbarch" with method call.
1545         * ada-exp.y (parse_type, find_primitive_type, type_char)
1546         (type_system_address): Replace "parse_gdbarch" with method call.
1547
1548 2019-04-04  Tom Tromey  <tom@tromey.com>
1549
1550         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
1551         * stap-probe.c (stap_parse_argument): Update.
1552         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
1553         initial_size parameter.
1554         * rust-exp.y (rust_lex_tests): Update.
1555         * parse.c (parser_state): Update.
1556         (parse_exp_in_context): Update.
1557         * parser-defs.h (struct parser_state) <parser_state>: Remove
1558         "initial_size" parameter.
1559
1560 2019-04-04  Tom Tromey  <tom@tromey.com>
1561
1562         * parser-defs.h (increase_expout_size): Don't declare.
1563         * parse.c (increase_expout_size): Now static.
1564
1565 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
1566
1567         * gnu-nat.c (gnu_nat_target::wait): Fix
1568         target_waitstatus_to_string call.
1569
1570 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1571
1572         * eval.c (evaluate_subexp_standard): Handle internal functions
1573         during Fortran function call handling.
1574
1575 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1576
1577         * NEWS: Mention new internal functions.
1578         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
1579         (read_base_type): Use dwarf2_init_complex_target_type.
1580         * value.c (creal_internal_fn): New function.
1581         (cimag_internal_fn): New function.
1582         (_initialize_values): Register new internal functions.
1583
1584 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1585
1586         * infrun.c (stop_all_threads): If debug_infrun, always
1587         trace the wait status after wait_one, using
1588         target_waitstatus_to_string and target_pid_to_str.
1589         (handle_inferior_event): Replace various trace of
1590         wait status kind by a single trace.
1591         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
1592         wait status kind image by target_waitstatus_to_string.
1593         * target/waitstatus.c (target_waitstatus_to_string): Fix
1594         obsolete comment.
1595
1596 2019-04-01  Tom Tromey  <tromey@adacore.com>
1597
1598         PR symtab/23331:
1599         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
1600
1601 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
1602             Pedro Alves  <palves@redhat.com>
1603
1604         * top.c (quit_force): Call 'finalize_values'.
1605         * value.c (finalize_values): New function.
1606         * value.h (finalize_values): Declare.
1607
1608 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
1609
1610         * NEWS: Announce $_gdb_major and $_gdb_minor.
1611
1612         * top.c (init_gdb_version_vars): New function.
1613         (gdb_init): Call init_gdb_version_vars.
1614
1615 2019-03-29  Tom Tromey  <tromey@adacore.com>
1616
1617         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
1618         help text.  Remove dead code.
1619
1620 2019-03-29  Keith Seitz  <keiths@redhat.com>
1621
1622         From Siddhesh Poyarekar:
1623         * f-lang.h (f77_get_upperbound): Return LONGEST.
1624         (f77_get_lowerbound): Likewise.
1625         * f-typeprint.c (f_type_print_varspec_suffix): Expand
1626         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
1627         print them.
1628         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
1629         plongest to format print it.
1630         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
1631         (f77_get_upperbound): Likewise.
1632         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
1633         LOWER_BOUND to LONGEST.
1634         (f77_create_arrayprint_offset_tbl): Likewise.
1635
1636 2019-03-29  Keith Seitz  <keiths@redhat.com>
1637
1638         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
1639         %s/pulongest for TYPE_LENGTH instead of %d in format
1640         strings.
1641         * ada-typerint.c (ada_print_type): Likewise.
1642         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
1643         * compile/compile-c-support.c (generate_register_struct): Likewise.
1644         * gdbtypes.c (recursive_dump_type): Likewise.
1645         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
1646         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
1647         instead of %d in format strings.
1648         * riscv-tdep.c (riscv_type_alignment): Cast second argument
1649         to std::min to ULONGEST.
1650         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
1651         instead of %d in format strings.
1652         * tracepoint.c (info_scope_command): Likewise.
1653         * typeprint.c (print_offset_data::update)
1654         (print_offset_data::finish): Likewise.
1655         * xtensa-tdep.c (xtensa_store_return_value)
1656         (xtensa_push_dummy_call): Likewise.
1657
1658 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
1659
1660         * windows-nat.c (display_selector): Fixed format specifications
1661         for 64-bit Cygwin.
1662
1663 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1664
1665         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
1666
1667 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
1668
1669         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
1670         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
1671         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
1672         (nios2_linux_init_abi): Install it.
1673
1674 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1675
1676         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
1677
1678 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1679
1680         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
1681
1682 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1683             Tom Tromey  <tromey@adacore.com>
1684
1685         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
1686
1687 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
1688
1689         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
1690         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
1691         method to compute the bounds of range types. Also print "[evaluated]"
1692         if the bounds' values come from a dynamic evaluation.
1693
1694 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1695
1696         * cp-valprint.c (cp_print_value_fields): Don't print trailing
1697         whitespace when pretty printing is on.
1698
1699 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1700
1701         * ppc-linux-nat.c: Add include.
1702
1703 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1704
1705         * NEWS: Mention AArch64 Pointer Authentication.
1706
1707 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1708
1709         * arm-linux-nat.c: Add include.
1710
1711 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
1712
1713         * source-cache.c (source_cache::get_source_lines): Re-read
1714         fullname after calling open_source_file.
1715
1716 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
1717
1718         * NEWS: Mention TLS support for FreeBSD.
1719
1720 2019-03-25  Tom Tromey  <tromey@adacore.com>
1721
1722         * minsyms.c (BUNCH_SIZE): Update comment.
1723         (~minimal_symbol_reader): Remove old comment.
1724         (compact_minimal_symbols): Update comment.
1725         (minimal_symbol_reader::install): Remove old comment.  Update
1726         other comments.
1727
1728 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1729
1730         * s390-linux-nat.c: Add include.
1731
1732 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1733
1734         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1735         Call linux_get_hwcap.
1736         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
1737         Likewise.
1738         (aarch64_linux_get_hwcap): Remove function.
1739         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
1740         declaration.
1741         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
1742         linux_get_hwcap.
1743         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1744         * linux-tdep.c (linux_get_hwcap): Add function.
1745         (linux_get_hwcap2): Likewise.
1746         * linux-tdep.h (linux_get_hwcap): Add declaration.
1747         (linux_get_hwcap2): Likewise.
1748         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
1749         (ppc_linux_get_hwcap2): Likewise.
1750         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
1751         linux_get_hwcap.
1752         (ppc_linux_nat_target::insert_watchpoint): Likewise.
1753         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
1754         (ppc_linux_nat_target::read_description): Likewise.
1755         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
1756         * s390-linux-nat.c: Likewise.
1757         * s390-linux-tdep.c (s390_core_read_description): Likewise.
1758
1759 2019-03-24  Tom Tromey  <tom@tromey.com>
1760
1761         * ada-lang.c (standard_lookup): Simplify initialization.
1762         (ada_lookup_symbol_nonlocal): Simplify return.
1763         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
1764         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
1765         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
1766         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
1767         initialization.
1768         * solib.c (solib_global_lookup): Simplify.
1769         * symtab.c (null_block_symbol): Remove.
1770         (symbol_cache_lookup): Simplify returns.
1771         (lookup_language_this): Simplify returns.
1772         (lookup_symbol_aux): Simplify return.
1773         (lookup_local_symbol): Simplify returns.
1774         (lookup_global_symbol_from_objfile): Simplify return.
1775         (lookup_symbol_in_objfile_symtabs)
1776         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
1777         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
1778         (lookup_static_symbol, lookup_global_symbol): Simplify return.
1779         * cp-namespace.c (cp_lookup_bare_symbol)
1780         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
1781         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
1782         (cp_lookup_nested_symbol): Don't use null_block_symbol.
1783         (cp_lookup_symbol_via_imports): Simplify initialization.
1784         (find_symbol_in_baseclass): Likewise.
1785         * symtab.h (null_block_symbol): Remove.
1786         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
1787         (d_lookup_nested_symbol, d_lookup_symbol_imports)
1788         (d_lookup_symbol_module): Likewise.
1789         (find_symbol_in_baseclass): Simplify initialization.
1790
1791 2019-03-24  Tom Tromey  <tom@tromey.com>
1792
1793         * expression.h: Don't include symtab.h.
1794         (struct block): Forward declare.
1795
1796 2019-03-24  Tom Tromey  <tom@tromey.com>
1797
1798         * c-exp.y (typebase): Remove casts.
1799         * gdbtypes.c (lookup_unsigned_typename, )
1800         (lookup_signed_typename): Remove cast.
1801         * eval.c (parse_to_comma_and_eval): Remove cast.
1802         * parse.c (write_dollar_variable): Remove cast.
1803         * block.h (struct block) <superblock>: Now const.
1804         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
1805         * psymtab.c (psym_map_matching_symbols): Make "block" const.
1806         (map_block): Make "block" const.
1807         * symfile.h (struct quick_symbol_functions)
1808         <map_matching_symbols>: Constify block argument to "callback".
1809         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
1810         const.
1811         (find_pc_sect_compunit_symtab): Make "b" const.
1812         (find_symbol_at_address): Likewise.
1813         (search_symbols): Likewise.
1814         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
1815         (dw2_debug_names_lookup_symbol): Likewise.
1816         (dw2_map_matching_symbols): Update.
1817         * p-valprint.c (pascal_val_print): Remove "block".
1818         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
1819         (aux_add_nonlocal_symbols): Make "block" const.
1820         (resolve_subexp): Remove cast.
1821         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
1822         const.
1823         (iterate_over_file_blocks): Likewise.
1824         * f-exp.y (%union) <bval>: Remove.
1825         * coffread.c (patch_opaque_types): Make "b" const.
1826         * spu-tdep.c (spu_catch_start): Make "block" const.
1827         * c-valprint.c (print_unpacked_pointer): Remove "block".
1828         * symmisc.c (dump_symtab_1): Make "b" const.
1829         (block_depth): Make "block" const.
1830         * d-exp.y (%union) <bval>: Remove.
1831         * cp-support.h (cp_lookup_rtti_type): Update.
1832         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
1833         * psymtab.c (psym_lookup_symbol): Make "block" const.
1834         (maintenance_check_psymtabs): Make "b" const.
1835         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
1836         (enumerate_locals, enumerate_args): Update.
1837         * python/py-symtab.c (stpy_global_block): Make "block" const.
1838         (stpy_static_block): Likewise.
1839         * inline-frame.c (block_starting_point_at): Make "new_block"
1840         const.
1841         * block.c (find_block_in_blockvector): Make return type const.
1842         (blockvector_for_pc_sect): Make "b" const.
1843         (find_block_in_blockvector): Make "b" const.
1844
1845 2019-03-23  Tom Tromey  <tom@tromey.com>
1846
1847         * varobj.c (varobj_create): Update.
1848         * symfile.c (clear_symtab_users): Don't reset innermost_block.
1849         * printcmd.c (display_command, do_one_display): Don't reset
1850         innermost_block.
1851         * parser-defs.h (enum innermost_block_tracker_type): Move to
1852         expression.h.
1853         (innermost_block): Update comment.
1854         * parse.c (parse_exp_1): Add tracker_types parameter.
1855         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
1856         tracker_types parameter.  Reset innermost_block.
1857         (parse_exp_in_context): Remove.
1858         (parse_expression_for_completion): Update.
1859         * objfiles.c (~objfile): Don't reset expression_context_block or
1860         innermost_block.
1861         * expression.h (enum innermost_block_tracker_type): Move from
1862         parser-defs.h.
1863         (parse_exp_1): Add tracker_types parameter.
1864         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
1865         reset innermost_block.
1866
1867 2019-03-23  Tom Tromey  <tom@tromey.com>
1868
1869         * objfiles.h: Include bcache.h.
1870
1871 2019-03-23  Tom Tromey  <tom@tromey.com>
1872
1873         * linespec.c (get_current_search_block): Use
1874         scoped_restore_current_language.
1875         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
1876
1877 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1878             Jiong Wang  <jiong.wang@arm.com>
1879
1880         * aarch64-linux-tdep.c
1881         (aarch64_linux_iterate_over_regset_sections): Check for pauth
1882         section.
1883         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
1884
1885 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1886             Jiong Wang  <jiong.wang@arm.com>
1887
1888         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
1889         instructions.
1890         (aarch64_analyze_prologue_test): Add PACIASP test.
1891         (aarch64_prologue_prev_register): Unmask PC value.
1892
1893 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1894             Jiong Wang  <jiong.wang@arm.com>
1895
1896         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
1897         (aarch64_dwarf2_prev_register): Unmask PC value.
1898         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
1899         (aarch64_execute_dwarf_cfa_vendor_op): Check for
1900         DW_CFA_AARCH64_negate_ra_state.
1901         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
1902
1903 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1904             Jiong Wang  <jiong.wang@arm.com>
1905
1906         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
1907         registers.
1908         (aarch64_pseudo_register_name): Likewise.
1909         (aarch64_pseudo_register_type): Likewise.
1910         (aarch64_pseudo_register_reggroup_p): Likewise.
1911         (aarch64_gdbarch_init): Add pauth registers.
1912         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
1913         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
1914         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
1915         (struct gdbarch_tdep): Add regnum for ra_state.
1916
1917 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1918             Jiong Wang  <jiong.wang@arm.com>
1919
1920         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
1921
1922 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1923             Jiong Wang  <jiong.wang@arm.com>
1924
1925         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
1926         function.
1927         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
1928         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
1929         (aarch64_gdbarch_init): Add puth registers.
1930         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
1931         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
1932         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
1933
1934 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1935             Jiong Wang  <jiong.wang@arm.com>
1936
1937         * aarch64-linux-nat.c
1938         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
1939         * aarch64-linux-tdep.c
1940         (aarch64_linux_core_read_description): Likewise.
1941         (aarch64_linux_get_hwcap): New function.
1942         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
1943         (aarch64_linux_get_hwcap): New declaration.
1944
1945 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1946             Jiong Wang  <jiong.wang@arm.com>
1947
1948         * aarch64-linux-nat.c
1949         (aarch64_linux_nat_target::read_description): Add pauth param.
1950         * aarch64-linux-tdep.c
1951         (aarch64_linux_core_read_description): Likewise.
1952         * aarch64-tdep.c (struct target_desc): Add in pauth.
1953         (aarch64_read_description): Add pauth param.
1954         (aarch64_gdbarch_init): Likewise.
1955         * aarch64-tdep.h (aarch64_read_description): Likewise.
1956         * arch/aarch64.c (aarch64_create_target_description): Likewise.
1957         * arch/aarch64.h (aarch64_create_target_description): Likewise.
1958         * features/Makefile: Add new files.
1959         * features/aarch64-pauth.c: New file.
1960         * features/aarch64-pauth.xml: New file.
1961
1962 2019-03-20  Tom Tromey  <tromey@adacore.com>
1963
1964         * infrun.c (handle_inferior_event): Rename from
1965         handle_inferior_event_1.  Create a scoped_value_mark.
1966         (handle_inferior_event): Remove.
1967
1968 2019-03-19  Tom Tromey  <tromey@adacore.com>
1969
1970         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
1971         * infrun.h (print_stop_event): Add "displays" parameter.
1972         * infrun.c (print_stop_event): Add "displays" parameter.
1973
1974 2019-03-19  Pedro Alves  <palves@redhat.com>
1975
1976         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
1977         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
1978         to -1.  Fix TABs vs spaces.
1979         (tui_ui_out::tui_ui_out): Don't initialize fields here.
1980         * tui/tui-out.h (tui_ui_out) Add intro comments.
1981         <m_line, m_start_of_line>: In-class initialize, and add describing
1982         comment.
1983
1984 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
1985
1986         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
1987         variable names.
1988         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
1989
1990 2019-03-18  Pedro Alves  <palves@redhat.com>
1991             Eli Zaretskii <eliz@gnu.org>
1992
1993         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
1994         m_line and m_start_of_line.
1995
1996 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
1997
1998         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
1999         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
2000         it returns a newline.  This fixes a regression in TU mode, whereby
2001         the next line is output on the same screen line as the user input.
2002
2003 2019-03-18  Tom Tromey  <tromey@adacore.com>
2004
2005         * minsyms.c (minimal_symbol_reader::install): Remove call to
2006         obstack_blank.
2007
2008 2019-03-18  Pedro Alves  <palves@redhat.com>
2009
2010         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
2011         New globals.
2012         (apply_style): New, factored out from ...
2013         (apply_ansi_escape): ... this.  Handle reverse video mode.
2014         (tui_set_reverse_mode): New function.
2015         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
2016         * tui/tui-winsource.c (tui_show_source_line): Use
2017         tui_set_reverse_mode instead of setting A_STANDOUT.
2018         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
2019         New setter methods.
2020
2021 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
2022
2023         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
2024         Handle tabs.
2025
2026 2019-03-18  Tom Tromey  <tromey@adacore.com>
2027
2028         * ada-lang.c (empty_array): Add "high" parameter.
2029         (ada_evaluate_subexp): Update.
2030
2031 2019-03-17  Sergei Trofimovich <siarheit@google.com>
2032
2033         * unittests/string_view-selftests.c: Define
2034         _initialize_string_view_selftests unconditionally.
2035
2036 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2037
2038         PR gdb/24350
2039         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
2040
2041 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2042
2043         PR gdb/24351
2044         * windows-nat.c (display_selector): Fix format specifiers.
2045
2046 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
2047
2048         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
2049         tui_refill_source_window instead of tui_refresh_win, to update the
2050         current execution line.  This fixes redisplay of the current line
2051         when stepping through the code with "next" or "step".
2052
2053 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2054
2055         * source-cache.c (source_cache::get_source_lines): Call
2056         find_source_lines to initialize s->nlines.  This fixes vertical
2057         scrolling of TUI source window when the DOWN arrow is pressed.
2058
2059 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2060
2061         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
2062         linux-thread-db.c (_initialize_thread_db): Likewise.
2063
2064 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2065
2066         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
2067         wclrtoeol in tui_show_source_line".  This reverts changes made in
2068         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
2069
2070 2019-03-15  Tom Tromey  <tom@tromey.com>
2071
2072         * symtab.h (struct minimal_symbol): Derive from
2073         general_symbol_info.
2074         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
2075         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
2076         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
2077         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
2078         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
2079         (MSYMBOL_SEARCH_NAME): Update.
2080         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
2081         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
2082         * minsyms.c (minimal_symbol_reader::record_full): Update.
2083
2084 2019-03-15  Tom Tromey  <tom@tromey.com>
2085
2086         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
2087
2088 2019-03-15  Tom Tromey  <tom@tromey.com>
2089
2090         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
2091         unique_xmalloc_ptr.
2092         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
2093         Update.
2094         * minsyms.c (lookup_minimal_symbol_by_pc_section)
2095         (build_minimal_symbol_hash_tables)
2096         (minimal_symbol_reader::install): Update.
2097
2098 2019-03-15  Tom Tromey  <tom@tromey.com>
2099
2100         * symtab.c (create_demangled_names_hash): Update.
2101         (symbol_set_names): Update.
2102         * objfiles.h (struct objfile_per_bfd_storage)
2103         <demangled_names_hash>: Now an htab_up.
2104         * objfiles.c (objfile_per_bfd_storage): Simplify.
2105
2106 2019-03-15  Tom Tromey  <tom@tromey.com>
2107
2108         * objfiles.h (struct objfile_per_bfd_storage): Declare
2109         destructor.
2110         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
2111         New.
2112         (get_objfile_bfd_data): Use new.  Don't initialize
2113         language_of_main.
2114         (free_objfile_per_bfd_storage): Remove.
2115         (objfile_bfd_data_free, objfile::~objfile): Use delete.
2116
2117 2019-03-15  Tom Tromey  <tom@tromey.com>
2118
2119         * symfile.c (reread_symbols): Update.
2120         * objfiles.c (objfile::objfile): Update.
2121         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
2122         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
2123         comment.
2124         (minimal_symbol_reader::install): Update.
2125         (terminate_minimal_symbol_table): Remove.
2126         * jit.c (jit_object_close_impl): Update.
2127
2128 2019-03-15  Tom Tromey  <tom@tromey.com>
2129
2130         * minsyms.c (minimal_symbol_reader::record_full): Remove some
2131         initializations.
2132
2133 2019-03-15  Tom Tromey  <tom@tromey.com>
2134
2135         * objfiles.h (struct objfile_per_bfd_storage)
2136         <demangled_hash_languages>: Now a bitset.
2137         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
2138         (lookup_minimal_symbol): Update.
2139
2140 2019-03-15  Tom Tromey  <tom@tromey.com>
2141
2142         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
2143         Don't return the symbol.
2144         * coffread.c (record_minimal_symbol): Use record_full.
2145
2146 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
2147
2148         The MS-Windows port of ncurses fails to switch to a color pair if
2149         one or both of the colors are the implicit default colors.  This
2150         change records the default colors when TUI is initialized, and
2151         then specifies them explicitly when a color pair uses the default
2152         colors.  This allows color styling in TUI mode on MS-Windows.
2153
2154         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
2155         ncurses_norm_attr.
2156         (tui_initialize_io) [__MINGW32__]: Record the default terminal
2157         colors in ncurses_norm_attr.
2158         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
2159         "none", replace it with the default color recorded in
2160         ncurses_norm_attr.
2161
2162 2019-03-14  Tom Tromey  <tromey@adacore.com>
2163
2164         * source-cache.h (class source_cache) <get_source_lines>: Return
2165         std::string.
2166         * source-cache.c (source_cache::extract_lines): Handle case where
2167         first_pos==npos.  Return std::string.
2168         (source_cache::get_source_lines): Update.
2169
2170 2019-03-14  Tom Tromey  <tromey@adacore.com>
2171
2172         * NEWS: Add item for "style sources" commands.
2173         * source-cache.c (source_cache::get_source_lines): Check
2174         source_styling.
2175         * cli/cli-style.c (source_styling): New global.
2176         (_initialize_cli_style): Add "style sources" commands.
2177         (show_style_sources): New function.
2178         * cli/cli-style.h (source_styling): Declare.
2179
2180 2019-03-14  Pedro Alves  <palves@redhat.com>
2181             Tom Tromey  <tromey@adacore.com>
2182
2183         * tui/tui-winsource.h (tui_refill_source_window): Declare.
2184         * tui/tui-winsource.c (tui_refill_source_window): New function,
2185         from...
2186         (tui_horizontal_source_scroll): ... here.  Move some logic.
2187         * cli/cli-style.c (set_style_enabled): Notify new observable.
2188         * tui/tui-hooks.c (tui_redisplay_source): New function.
2189         (tui_attach_detach_observers): Attach or detach
2190         tui_redisplay_source.
2191         * observable.h (source_styling_changed): New observable.
2192         * observable.c: Define source_styling_changed observable.
2193
2194 2019-03-13  Tom Tromey  <tromey@adacore.com>
2195
2196         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
2197         (i386_gnu_nat_target::store_registers): Update.
2198         * target-debug.h (target_debug_print_std_string): New macro.
2199         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2200         * windows-tdep.c (display_one_tib): Update.
2201         * tui/tui-stack.c (tui_make_status_line): Update.
2202         * top.c (print_inferior_quit_action): Update.
2203         * thread.c (thr_try_catch_cmd): Update.
2204         (add_thread_with_info): Update.
2205         (thread_target_id_str): Update.
2206         (thr_try_catch_cmd): Update.
2207         (thread_command): Update.
2208         (thread_find_command): Update.
2209         * record-btrace.c (record_btrace_target::info_record)
2210         (record_btrace_resume_thread, record_btrace_target::resume)
2211         (record_btrace_cancel_resume, record_btrace_step_thread)
2212         (record_btrace_target::wait, record_btrace_target::wait)
2213         (record_btrace_target::wait, record_btrace_target::stop): Update.
2214         * progspace.c (print_program_space): Update.
2215         * process-stratum-target.c
2216         (process_stratum_target::thread_address_space): Update.
2217         * linux-fork.c (linux_fork_mourn_inferior)
2218         (detach_checkpoint_command, info_checkpoints_command)
2219         (linux_fork_context): Update.
2220         (linux_fork_detach): Update.
2221         (class scoped_switch_fork_info): Update.
2222         (delete_checkpoint_command): Update.
2223         * infrun.c (follow_fork_inferior): Update.
2224         (follow_fork_inferior): Update.
2225         (proceed_after_vfork_done): Update.
2226         (handle_vfork_child_exec_or_exit): Update.
2227         (follow_exec): Update.
2228         (displaced_step_prepare_throw): Update.
2229         (displaced_step_restore): Update.
2230         (start_step_over): Update.
2231         (resume_1): Update.
2232         (clear_proceed_status_thread): Update.
2233         (proceed): Update.
2234         (print_target_wait_results): Update.
2235         (do_target_wait): Update.
2236         (context_switch): Update.
2237         (stop_all_threads): Update.
2238         (restart_threads): Update.
2239         (finish_step_over): Update.
2240         (handle_signal_stop): Update.
2241         (switch_back_to_stepped_thread): Update.
2242         (keep_going_pass_signal): Update.
2243         (print_exited_reason): Update.
2244         (normal_stop): Update.
2245         * inferior.c (inferior_pid_to_str): Change return type.
2246         (print_selected_inferior): Update.
2247         (add_inferior): Update.
2248         (detach_inferior): Update.
2249         * dummy-frame.c (fprint_dummy_frames): Update.
2250         * dcache.c (dcache_info_1): Update.
2251         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
2252         (btrace_fetch, btrace_clear): Update.
2253         * linux-tdep.c (linux_core_pid_to_str): Change return type.
2254         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
2255         type.
2256         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
2257         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
2258         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
2259         * gdbarch.c, gdbarch.h: Rebuild.
2260         * gdbarch.sh (core_pid_to_str): Change return type.
2261         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
2262         return type.
2263         (windows_nat_target::pid_to_str): Change return type.
2264         (windows_delete_thread): Update.
2265         (windows_nat_target::attach): Update.
2266         (windows_nat_target::files_info): Update.
2267         * target-delegates.c: Rebuild.
2268         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
2269         return type.
2270         (sol_thread_target::pid_to_str): Change return type.
2271         * remote.c (class remote_target) <pid_to_str>: Change return
2272         type.
2273         (remote_target::pid_to_str): Change return type.
2274         (extended_remote_target::attach, remote_target::remote_stop_ns)
2275         (remote_target::remote_notif_remove_queued_reply)
2276         (remote_target::push_stop_reply, remote_target::disable_btrace):
2277         Update.
2278         (extended_remote_target::attach): Update.
2279         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
2280         type.
2281         (gdbsim_target::pid_to_str): Change return type.
2282         * ravenscar-thread.c (struct ravenscar_thread_target)
2283         <pid_to_str>: Change return type.
2284         (ravenscar_thread_target::pid_to_str): Change return type.
2285         * procfs.c (class procfs_target) <pid_to_str>: Change return
2286         type.
2287         (procfs_target::pid_to_str): Change return type.
2288         (procfs_target::attach): Update.
2289         (procfs_target::detach): Update.
2290         (procfs_target::fetch_registers): Update.
2291         (procfs_target::store_registers): Update.
2292         (procfs_target::wait): Update.
2293         (procfs_target::files_info): Update.
2294         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
2295         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
2296         return type.
2297         (nto_procfs_target::pid_to_str): Change return type.
2298         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
2299         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
2300         return type.
2301         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
2302         (exit_lwp): Update.
2303         (attach_proc_task_lwp_callback, get_detach_signal)
2304         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
2305         (linux_nat_target::resume, wait_lwp, stop_callback)
2306         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
2307         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
2308         (linux_nat_wait_1, resume_stopped_resumed_lwps)
2309         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
2310         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
2311         type.
2312         (inf_ptrace_target::attach): Update.
2313         (inf_ptrace_target::files_info): Update.
2314         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
2315         type.
2316         (go32_nat_target::pid_to_str): Change return type.
2317         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
2318         (gnu_nat_target::wait): Update.
2319         (gnu_nat_target::wait): Update.
2320         (gnu_nat_target::resume): Update.
2321         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
2322         (fbsd_nat_target::wait): Update.
2323         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
2324         type.
2325         (darwin_nat_target::attach): Update.
2326         * corelow.c (class core_target) <pid_to_str>: Change return type.
2327         (core_target::pid_to_str): Change return type.
2328         * target.c (normal_pid_to_str): Change return type.
2329         (default_pid_to_str): Likewise.
2330         (target_pid_to_str): Change return type.
2331         (target_translate_tls_address): Update.
2332         (target_announce_detach): Update.
2333         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
2334         return type.
2335         (bsd_uthread_target::pid_to_str): Change return type.
2336         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
2337         type.
2338         (bsd_kvm_target::pid_to_str): Change return type.
2339         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
2340         return type.
2341         (aix_thread_target::pid_to_str): Change return type.
2342         * target.h (struct target_ops) <pid_to_str>: Change return type.
2343         (target_pid_to_str, normal_pid_to_str): Likewise.
2344         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
2345         type.
2346         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
2347         type.
2348         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
2349         return type.
2350         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
2351         type.
2352         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
2353         type.
2354         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
2355         return type.
2356
2357 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
2358
2359         * NEWS: Mention that the new default MI version is 3.  Mention
2360         changes to the output of commands and events that deal with
2361         multi-location breakpoints.
2362         * breakpoint.c: Include "mi/mi-out.h".
2363         (print_one_breakpoint): Change output syntax if using MI version
2364         >= 3.
2365         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
2366         New.
2367         (mi_multi_location_breakpoint_output_fixed): New.
2368         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
2369         (mi_cmd_fix_multi_location_breakpoint_output): New.
2370         (mi_multi_location_breakpoint_output_fixed): New.
2371         * mi/mi-cmds.c (mi_cmds): Register command
2372         -fix-multi-location-breakpoint-output.
2373         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
2374         interpreter "mi".
2375
2376 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
2377
2378         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
2379         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
2380         instantiate mi_ui_out based on interpreter name.
2381         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
2382         * mi/mi-main.c (mi_load_progress): Likewise.
2383
2384 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2385
2386         * NEWS: Combine separate "New targets" sections for 8.3.
2387
2388 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2389
2390         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
2391         (ppcfbsd_init_abi): Install gdbarch
2392         "fetch_tls_load_module_address" and "get_thread_local_address"
2393         methods.
2394
2395 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2396
2397         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
2398         (riscv_fbsd_init_abi): Install gdbarch
2399         "fetch_tls_load_module_address" and "get_thread_local_address"
2400         methods.
2401
2402 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2403
2404         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
2405         (i386fbsd_init_abi): Install gdbarch
2406         "fetch_tls_load_module_address" and "get_thread_local_address"
2407         methods.
2408
2409 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2410
2411         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
2412         (amd64fbsd_init_abi): Install gdbarch
2413         "fetch_tls_load_module_address" and "get_thread_local_address"
2414         methods.
2415
2416 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2417
2418         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
2419         (struct fbsd_pspace_data): New type.
2420         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
2421         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
2422         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
2423         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
2424         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
2425
2426 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2427
2428         * gdbtypes.c (lookup_struct_elt): New function.
2429         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
2430         * gdbtypes.h (struct struct_elt): New type.
2431         (lookup_struct_elt): New prototype.
2432
2433 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2434
2435         * gdbtypes.c (lookup_struct_elt_type): Update comment and
2436         remove disabled code block.
2437
2438 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2439
2440         * gdbarch.sh (get_thread_local_address): New method.
2441         * gdbarch.h, gdbarch.c: Regenerate.
2442         * target.c (target_translate_tls_address): Use
2443         gdbarch_get_thread_local_address if present instead of
2444         target::get_thread_local_address.
2445
2446 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2447
2448         * target.h (target::get_thread_local_address): Update comment.
2449
2450 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2451
2452         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
2453         objfile->separate_debug_objfile_backlink if not NULL.
2454
2455 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2456
2457         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
2458         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
2459         (amd64bsd_store_inferior_registers): Likewise.
2460         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2461         Enable segment base registers.
2462         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
2463         PT_GETFSBASE and PT_GETGSBASE.
2464         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
2465         PT_SETGSBASE.
2466         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
2467         segment base registers.
2468         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2469
2470 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2471
2472         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2473         Update calls to i386_target_description to add 'segments'
2474         parameter.
2475         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
2476         add segment base registers.
2477         * arch/i386.c (i386_create_target_description): Add 'segments'
2478         parameter to enable segment base registers.
2479         * arch/i386.h (i386_create_target_description): Likewise.
2480         * features/i386/32bit-segments.xml: New file.
2481         * features/i386/32bit-segments.c: Generate.
2482         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
2483         call to i386_target_description to add 'segments' parameter.
2484         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2485         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
2486         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
2487         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
2488         if feature is present.
2489         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
2490         Add 'segments' parameter to call to i386_target_description.
2491         (i386_target_description): Add 'segments' parameter to enable
2492         segment base registers.
2493         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
2494         to call to i386_target_description.
2495         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
2496         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
2497         Define I386_NUM_REGS.
2498         (i386_target_description): Add 'segments' parameter to enable
2499         segment base registers.
2500
2501 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
2502
2503         PR/24325
2504         * source-cache.c: #undef open and close, to avoid unresolved
2505         externals during linking.
2506
2507 2019-03-12  Tom Tromey  <tromey@adacore.com>
2508
2509         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
2510         const.  Add initializers.
2511         (_initialize_remote): Don't initialize ptid globals.
2512
2513 2019-03-12  Pedro Alves  <palves@redhat.com>
2514
2515         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
2516
2517 2019-03-12  Pedro Alves  <palves@redhat.com>
2518
2519         * cp-name-parser.y (main): Remove unused 'len' variable.
2520
2521 2019-03-12  Tom Tromey  <tromey@adacore.com>
2522
2523         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
2524         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
2525
2526 2019-03-12  Tom Tromey  <tromey@adacore.com>
2527
2528         * linux-nat.c (iterate_over_lwps): Update.
2529         (stop_callback): Remove parameter.
2530         (stop_wait_callback, detach_callback, resume_set_callback)
2531         (select_singlestep_lwp_callback, set_ignore_sigint)
2532         (status_callback, resumed_callback, resume_clear_callback)
2533         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
2534         data parameter.
2535         (linux_nat_target::detach, linux_nat_target::resume)
2536         (linux_stop_and_wait_all_lwps, select_event_lwp)
2537         (linux_nat_filter_event, linux_nat_wait_1)
2538         (linux_nat_target::kill, linux_nat_target::stop)
2539         (linux_nat_target::stop): Update.
2540         (linux_nat_resume_callback): Change type.
2541         (resume_stopped_resumed_lwps, count_events_callback)
2542         (select_event_lwp_callback): Likewise.
2543         (linux_stop_lwp, linux_nat_stop_lwp): Update.
2544         * arm-linux-nat.c (struct update_registers_data): Remove.
2545         (update_registers_callback): Change type.
2546         (arm_linux_insert_hw_breakpoint1): Update.
2547         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
2548         parameter.
2549         (x86_linux_dr_set_addr): Update.
2550         (x86_linux_dr_set_control): Update.
2551         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
2552         (iterate_over_lwps): Use gdb::function_view.
2553         * nat/aarch64-linux-hw-point.c (struct
2554         aarch64_dr_update_callback_param): Remove.
2555         (debug_reg_change_callback): Change type.
2556         (aarch64_notify_debug_reg_change): Update.
2557         * s390-linux-nat.c (s390_refresh_per_info): Update.
2558
2559 2019-03-11  Tom Tromey  <tromey@adacore.com>
2560
2561         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
2562         redundant assignment to "this_cu".
2563
2564 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2565
2566         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
2567
2568 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2569
2570         * gdbtypes.c (rank_one_type_parm_set): New function extracted
2571         from...
2572         (rank_one_type): ... this.
2573
2574 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2575
2576         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
2577         from...
2578         (rank_one_type): ... this.
2579
2580 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2581
2582         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
2583         from...
2584         (rank_one_type): ... this.
2585
2586 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2587
2588         * gdbtypes.c (rank_one_type_parm_float): New function extracted
2589         from...
2590         (rank_one_type): ... this.
2591
2592 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2593
2594         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
2595         from...
2596         (rank_one_type): ... this.
2597
2598 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2599
2600         * gdbtypes.c (rank_one_type_parm_range): New function extracted
2601         from...
2602         (rank_one_type): ... this.
2603
2604 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2605
2606         * gdbtypes.c (rank_one_type_parm_char): New function extracted
2607         from...
2608         (rank_one_type): ... this.
2609
2610 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2611
2612         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
2613         from...
2614         (rank_one_type): ... this.
2615
2616 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2617
2618         * gdbtypes.c (rank_one_type_parm_int): New function extracted
2619         from...
2620         (rank_one_type): ... this.
2621
2622 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2623
2624         * gdbtypes.c (rank_one_type_parm_func): New function extracted
2625         from...
2626         (rank_one_type): ... this.
2627
2628 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2629
2630         * gdbtypes.c (rank_one_type_parm_array): New function extracted
2631         from...
2632         (rank_one_type): ... this.
2633
2634 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2635
2636         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
2637         from...
2638         (rank_one_type): ... this.
2639
2640 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2641
2642         * inferior.c (initialize_inferiors): Ensure 'help set/show print
2643         inferior-events' shows the example events.
2644
2645 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
2646
2647         Support styling on native MS-Windows console
2648
2649         PR/24315
2650         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
2651         on MS-Windows if $TERM is not defined.
2652
2653         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
2654
2655         * posix-hdep.c (gdb_console_fputs):
2656         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
2657         functions.
2658         * ui-file.h (gdb_console_fputs): Add prototype.
2659
2660         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
2661         back to fputs only if the former returns zero.
2662
2663 2019-03-07  Tom Tromey  <tom@tromey.com>
2664
2665         * symmisc.c (print_symbol_bcache_statistics): Update.
2666         (print_objfile_statistics): Update.
2667         * symfile.c (allocate_symtab): Update.
2668         * stabsread.c: Don't include bcache.h.
2669         * psymtab.h (struct psymbol_bcache): Don't declare.
2670         (class psymtab_storage) <psymbol_cache>: Now a bcache.
2671         (psymbol_bcache_init, psymbol_bcache_free)
2672         (psymbol_bcache_get_bcache): Don't declare.
2673         * psymtab.c (struct psymbol_bcache): Remove.
2674         (psymtab_storage::psymtab_storage): Update.
2675         (psymtab_storage::~psymtab_storage): Update.
2676         (psymbol_bcache_init, psymbol_bcache_free)
2677         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
2678         (add_psymbol_to_bcache): Update.
2679         (allocate_psymtab): Update.
2680         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
2681         macro_cache>: No longer pointers.
2682         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
2683         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
2684         * macrotab.c (macro_bcache): Update.
2685         * macroexp.c: Don't include bcache.h.
2686         * gdbtypes.c (check_types_worklist): Update.
2687         (types_deeply_equal): Remove TRY/CATCH.  Update.
2688         * elfread.c (elf_symtab_read): Update.
2689         * dwarf2read.c: Don't include bcache.h.
2690         * buildsym.c (buildsym_compunit::get_macro_table): Update.
2691         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
2692         (print_bcache_statistics, bcache_memory_used): Don't declare.
2693         (struct bcache): Move from bcache.c.  Add constructor, destructor,
2694         methods.  Rename all data members.
2695         * bcache.c (struct bcache): Move to bcache.h.
2696         (bcache::expand_hash_table): Rename from expand_hash_table.
2697         (bcache): Remove.
2698         (bcache::insert): Rename from bcache_full.
2699         (bcache::compare): Rename from bcache_compare.
2700         (bcache_xmalloc): Remove.
2701         (bcache::~bcache): Rename from bcache_xfree.
2702         (bcache::print_statistics): Rename from print_bcache_statistics.
2703         (bcache::memory_used): Rename from bcache_memory_used.
2704
2705 2019-03-07  Pedro Alves  <palves@redhat.com>
2706
2707         * infrun.c (normal_stop): Also check for
2708         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
2709
2710 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
2711
2712         * f-lang.c (value_from_host_double): Moved to...
2713         * value.c (value_from_host_double): ...here.
2714         * value.h (value_from_host_double): Declare.
2715         * guile/scm-math.c (vlscm_convert_typed_number): Use
2716         value_from_host_double.
2717         (vlscm_convert_number): Likewise.
2718         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
2719         * python/py-value.c (convert_value_from_python): Likewise.
2720
2721 2019-03-06  Tom Tromey  <tom@tromey.com>
2722
2723         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
2724
2725 2019-03-06  Tom Tromey  <tom@tromey.com>
2726
2727         * utils.h (free_current_contents): Don't declare.
2728         * utils.c (free_current_contents): Remove.
2729
2730 2019-03-06  Tom Tromey  <tom@tromey.com>
2731
2732         * top.c (quit_force): Update.
2733         * main.c (captured_command_loop): Update.
2734         * common/new-op.c (operator new): Update.
2735         * common/common-exceptions.c (struct catcher)
2736         <save_cleanup_chain>: Remove member.
2737         (exceptions_state_mc_init): Update.
2738         (exception_try_scope_entry): Return nullptr.
2739         (exception_try_scope_exit, exception_rethrow)
2740         (throw_exception_sjlj, throw_exception_cxx): Update.
2741         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
2742         (all_cleanups, do_cleanups, discard_cleanups)
2743         (discard_final_cleanups, save_cleanups, save_final_cleanups)
2744         (restore_cleanups, restore_final_cleanups): Don't declare.
2745         (do_final_cleanups): Remove parameter.
2746         * common/cleanups.c (cleanup_chain, make_cleanup)
2747         (make_cleanup_dtor, all_cleanups, do_cleanups)
2748         (discard_my_cleanups, discard_cleanups)
2749         (discard_final_cleanups, save_my_cleanups, save_cleanups)
2750         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
2751         (null_cleanup): Remove.
2752         (do_final_cleanups): Remove parameter.
2753
2754 2019-03-06  Tom Tromey  <tom@tromey.com>
2755
2756         * remote.c (remote_target::remote_parse_stop_reply): Use
2757         unique_xmalloc_ptr.
2758
2759 2019-03-06  Tom Tromey  <tom@tromey.com>
2760
2761         * stabsread.c (struct stabs_field_info): Rename from field_info.
2762         <list, fnlist>: Add initializers.
2763         <obstack>: New member.
2764         (read_member_functions, read_struct_fields, read_baseclasses):
2765         Allocate on obstack.  Don't use cleanups.
2766         (read_one_struct_field, read_member_functions, read_struct_fields)
2767         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
2768         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
2769         (read_struct_type): Update.
2770
2771 2019-03-06  Tom Tromey  <tom@tromey.com>
2772
2773         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
2774         * common/filestuff.h (make_cleanup_close): Don't declare.
2775         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
2776         Remove.
2777
2778 2019-03-06  Tom Tromey  <tom@tromey.com>
2779
2780         * solib-aix.c: Use make_scope_exit.
2781
2782 2019-03-06  Tom Tromey  <tom@tromey.com>
2783
2784         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
2785         Use make_scope_exit.
2786
2787 2019-03-06  Tom Tromey  <tom@tromey.com>
2788
2789         * solib-svr4.c (disable_probes_interface): Remove parameter.
2790         (svr4_handle_solib_event): Use make_scope_exit.
2791
2792 2019-03-06  Tom Tromey  <tom@tromey.com>
2793
2794         * remote.c (struct stop_reply_deleter): Remove.
2795         (stop_reply_up): Update.
2796         (struct stop_reply): Derive from notif_event.  Don't typedef.
2797         <regcache>: Now a std::vector.
2798         (stop_reply_xfree): Remove.
2799         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
2800         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
2801         (remote_target::discard_pending_stop_replies): Use delete.
2802         (remote_target::remote_parse_stop_reply): Update.
2803         (remote_target::process_stop_reply): Update.
2804         * remote-notif.h (struct notif_event): Add virtual destructor.
2805         Remove "dtr" member.
2806         (struct notif_client) <alloc_event>: Return a unique_ptr.
2807         (notif_event_xfree): Don't declare.
2808         (notif_event_up): New typedef.
2809         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
2810         (notif_event_xfree, do_notif_event_xfree): Remove.
2811         (remote_notif_state_xfree): Update.
2812
2813 2019-03-06  Tom Tromey  <tom@tromey.com>
2814
2815         * infrun.c (displaced_step_clear_cleanup): Now a
2816         forward_scope_exit type.
2817         (displaced_step_prepare_throw): Update.
2818         (displaced_step_fixup): Update.
2819
2820 2019-03-06  Tom Tromey  <tom@tromey.com>
2821
2822         * inferior.h (class inferior): Update comment.
2823         * gdbthread.h (class thread_info): Update comment.
2824
2825 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
2826             Tom Tromey  <tom@tromey.com>
2827
2828         * stabsread.h (struct stab_section_list): Remove.
2829         (coffstab_build_psymtabs): Update.
2830         * dbxread.c (symbuf_sections): Now a std::vector.
2831         (sect_idx): New global.
2832         (fill_symbuf): Update.
2833         (coffstab_build_psymtabs): Change type of stabsects parameter.
2834         Update.
2835         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
2836         std::vector.
2837         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
2838         (coff_locate_sections): Update.
2839         (coff_symfile_read): Remove cleanups.  Update.
2840         (init_stringtab): Add storage parameter.
2841         (free_stringtab, free_stringtab_cleanup): Remove.
2842         (init_lineno): Add storage parameter.
2843         (free_linetab, free_linetab_cleanup): Remove.
2844
2845 2019-03-06  Pedro Alves  <palves@redhat.com>
2846
2847         * linux-fork.c (fork_info::clobber_regs): Delete.
2848         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
2849         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
2850         comment.  Adjust.
2851         (scoped_switch_fork_info::scoped_switch_fork_info)
2852         (checkpoint_command, linux_fork_context): Adjust
2853         fork_save_infrun_state calls.
2854
2855 2019-03-06  Pedro Alves  <palves@redhat.com>
2856
2857         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
2858         (inf_has_multiple_threads): Return 'bool' and rewrite using
2859         inferior_info::threads().
2860
2861 2019-03-06  Pedro Alves  <palves@redhat.com>
2862
2863         * linux-fork.c: Include <list>.
2864         (fork_list): Now a std::list instance.
2865         (fork_info): Add ctor, dtor, and in-class initialize all fields.
2866         (forks_exist_p, find_last_fork): Adjust.
2867         (new_fork): Delete.
2868         (one_fork_p): New.
2869         (add_fork): Adjust.
2870         (free_fork): Delete, folded into fork_info::~fork_info().
2871         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
2872         Adjust.
2873         (init_fork_list): Delete.
2874         (linux_fork_killall, linux_fork_mourn_inferior)
2875         (linux_fork_detach, info_checkpoints_command): Adjust.
2876         (_initialize_linux_fork): No longer call init_fork_list.
2877
2878 2019-03-06  Pedro Alves  <palves@redhat.com>
2879
2880         * linux-fork.c (new_fork): New, split out of ...
2881         (add_fork): ... this.  Return void.  Move "first fork" special
2882         case from here, to ...
2883         (checkpoint_command): ... here.
2884         * linux-linux.h (add_fork): Return void.
2885
2886 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2887
2888         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
2889
2890 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2891             Chris January  <chris.january@arm.com>
2892             David Lecomber  <david.lecomber@arm.com>
2893
2894         * f-exp.y: New token, UNOP_INTRINSIC.
2895         (exp): New pattern using UNOP_INTRINSIC token.
2896         (f77_keywords): Add 'abs' keyword.
2897         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
2898         (value_from_host_double): New function.
2899         (evaluate_subexp_f): Support UNOP_ABS.
2900
2901 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2902
2903         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
2904         types.
2905
2906 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2907
2908         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
2909         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
2910         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
2911
2912 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2913
2914         * f-exp.y (convert_to_kind_type): Handle more type kinds.
2915
2916 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2917             Chris January  <chris.january@arm.com>
2918
2919         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
2920         * f-exp.y: Define 'KIND' token.
2921         (exp): New pattern for KIND expressions.
2922         (ptype): Handle types with a kind extension.
2923         (direct_abs_decl): Extend to spot kind extensions.
2924         (f77_keywords): Add 'kind' to the list.
2925         (push_kind_type): New function.
2926         (convert_to_kind_type): New function.
2927         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
2928         * parse.c (operator_length_standard): Likewise.
2929         * parser-defs.h (enum type_pieces): Add tp_kind.
2930         * std-operator.def: Add UNOP_KIND.
2931
2932 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2933
2934         * f-exp.y (f_parse): Set yydebug.
2935
2936 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2937
2938         * f-lang.c (evaluate_subexp_f): New function.
2939         (exp_descriptor_f): New global.
2940         (f_language_defn): Use exp_descriptor_f instead of
2941         exp_descriptor_standard.
2942
2943 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2944
2945         * f-exp.y (struct token): Add comments.
2946         (dot_ops): Remove uppercase versions and the end marker.
2947         (f77_keywords): Likewise.
2948         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
2949         entries in the dot_ops array are case insensitive, and use
2950         strncasecmp to compare strings.  Also some whitespace cleanup in
2951         this area.  Similar for the f77_keywords array, except entries in
2952         this list might be case sensitive.
2953
2954 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2955
2956         * f-exp.y (struct f77_boolean_val): Add comments.
2957         (boolean_values): Remove uppercase versions, and end marker.
2958         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
2959         and use strncasecmp to achieve case insensitivity.  Additionally,
2960         perform whitespace cleanup around this code.
2961
2962 2019-03-06  Tom Tromey  <tromey@adacore.com>
2963
2964         * remote-sim.c (gdbsim_target_open): Use result of
2965         gdb_argv::release.
2966
2967 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
2968         Dirk Schubert  <dirk.schubert@arm.com>
2969         Chris January  <chris.january@arm.com>
2970
2971         * eval.c (evaluate_subexp_standard): Call Fortran argument
2972         wrapping logic.
2973         * f-lang.c (struct value): A value which can be passed into a
2974         Fortran function call.
2975         (fortran_argument_convert): Wrap Fortran arguments in a pointer
2976         where appropriate.
2977         (struct type): Value ready for a Fortran function call.
2978         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
2979         is needed.
2980         * f-lang.h (fortran_argument_convert): Declaration.
2981         (fortran_preserve_arg_pointer): Declaration.
2982         * infcall.c (value_arg_coerce): Call Fortran argument logic.
2983
2984 2019-03-05  Tom Tromey  <tromey@adacore.com>
2985
2986         * python/py-prettyprint.c (print_string_repr): Remove #if.
2987         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
2988
2989 2019-03-05  Tom Tromey  <tromey@adacore.com>
2990
2991         * target.c (the_dummy_target): Move later.  Change type to
2992         "dummy_target".
2993         (initialize_targets): Don't initialize the_dummy_target.
2994
2995 2019-03-05  Tom Tromey  <tromey@adacore.com>
2996
2997         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
2998         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
2999
3000 2019-03-05  Tom Tromey  <tromey@adacore.com>
3001
3002         * windows-nat.c (windows_nat_target::attach)
3003         (windows_nat_target::detach): Don't call gdb_flush.
3004         * valprint.c (generic_val_print, val_print, val_print_string):
3005         Don't call gdb_flush.
3006         * utils.c (defaulted_query): Don't call gdb_flush.
3007         * typeprint.c (print_type_scalar): Don't call gdb_flush.
3008         * target.c (target_announce_detach): Don't call gdb_flush.
3009         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
3010         * remote.c (extended_remote_target::attach): Don't call
3011         gdb_flush.
3012         * procfs.c (procfs_target::detach): Don't call gdb_flush.
3013         * printcmd.c (do_examine): Don't call gdb_flush.
3014         (info_display_command): Don't call gdb_flush.
3015         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
3016         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
3017         * memattr.c (info_mem_command): Don't call gdb_flush.
3018         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
3019         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
3020         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
3021         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
3022         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
3023         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
3024         (gnu_nat_target::detach): Don't call gdb_flush.
3025         * f-valprint.c (f_val_print): Don't call gdb_flush.
3026         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
3027         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
3028         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
3029         gdb_flush.
3030         * c-valprint.c (c_val_print): Don't call gdb_flush.
3031         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
3032
3033 2019-03-05  Tom Tromey  <tromey@adacore.com>
3034
3035         * varobj.c (update_dynamic_varobj_children): Update.
3036         (install_default_visualizer): Use reset, not release.
3037         * value.c (set_internalvar): Update.
3038         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
3039         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
3040         ATTRIBUTE_UNUSED_RESULT.
3041
3042 2019-03-05  Tom Tromey  <tromey@adacore.com>
3043
3044         * remote.c (class scoped_remote_fd) <release>: Add
3045         ATTRIBUTE_UNUSED_RESULT.
3046
3047 2019-03-05  Tom Tromey  <tromey@adacore.com>
3048
3049         * macroexp.c (struct macro_buffer) <release>: Add
3050         ATTRIBUTE_UNUSED_RESULT.
3051
3052 2019-03-05  Tom Tromey  <tromey@adacore.com>
3053
3054         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
3055         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
3056         ATTRIBUTE_UNUSED_RESULT.
3057
3058 2019-03-05  Tom Tromey  <tromey@adacore.com>
3059
3060         * common/scoped_fd.h (class scoped_fd) <release>: Add
3061         ATTRIBUTE_UNUSED_RESULT.
3062
3063 2019-03-05  Tom Tromey  <tromey@adacore.com>
3064
3065         * parser-defs.h (struct parser_state) <release>: Add
3066         ATTRIBUTE_UNUSED_RESULT.
3067
3068 2019-03-05  Tom Tromey  <tromey@adacore.com>
3069
3070         * utils.h (class gdb_argv) <release>: Add
3071         ATTRIBUTE_UNUSED_RESULT.
3072         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
3073
3074 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
3075
3076         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
3077         for-loop range, to avoid compiler warnings.
3078
3079         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
3080         avoid compiler warnings about unused variables.
3081
3082         * NEWS: Mention end of support for native debugging on MS-Windows
3083         before XP.
3084
3085         PR gdb/24292
3086         * common/netstuff.c:
3087         * gdbserver/gdbreplay.c
3088         * gdbserver/remote-utils.c:
3089         * ser-tcp.c:
3090         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
3091         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
3092         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
3093         'getaddrinfo' and 'freeaddrinfo' were not available before
3094         Windows XP, and mingw.org's MinGW headers by default define
3095         _WIN32_WINNT to 0x500.
3096
3097 2019-03-01  Gary Benson <gbenson@redhat.com>
3098
3099         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
3100
3101 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
3102             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3103
3104         PR gdb/8527
3105         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
3106         set_sigint_trap, clear_sigint_trap.
3107
3108 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3109
3110         * target.c (target_detach): Clear the regcache and the
3111         frame cache.
3112
3113 2019-02-27  Pedro Alves  <palves@redhat.com>
3114
3115         * utils.c (set_screen_size): When we cap the height/width sizes,
3116         tweak the corresponding command variable to show "unlimited":
3117
3118 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
3119             Pedro Alves  <palves@redhat.com>
3120
3121         * utils.c (set_screen_size): Reduce "infinite" rows and columns
3122         before calling rl_set_screen_size.
3123
3124 2019-02-27  Tom Tromey  <tromey@adacore.com>
3125
3126         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
3127         define.
3128         * python/py-value.c: Remove Python 2.4 workaround.
3129         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
3130         workaround.
3131         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
3132         Python 2.4 workaround.
3133         * python/python-internal.h: Remove Python 2.4 comment.
3134         (Py_ssize_t): Don't define.
3135         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
3136         (gdb_Py_DECREF): Remove Python 2.4 workaround.
3137         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
3138         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
3139         * python/python.c (do_start_initialization): Remove Python 2.4
3140         workaround.
3141         * python/py-prettyprint.c (class dummy_python_frame): Remove.
3142         (print_children): Remove Python 2.4 workaround.
3143         * python/py-inferior.c (buffer_procs): Remove Python 2.4
3144         workaround.
3145         (CHARBUFFERPROC_NAME): Remove.
3146         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
3147         Python 2.4 workaround.
3148
3149 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3150
3151         * NEWS: Note minimum Python version.
3152
3153 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3154
3155         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
3156         code from these functions.  Remove corresponding ifdefs.  Use
3157         Py_buffer_up instead of explicit calls to PyBuffer_Release.
3158         Remove gotos and target of gotos.
3159         (infpy_search_memory): Likewise.
3160
3161 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3162
3163         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
3164         (hppa_gdbarch_init): Don't register deleted functions with
3165         gdbarch.
3166
3167 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3168
3169         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
3170         (h8300_unwind_sp): Delete.
3171         (h8300_dummy_id): Delete.
3172         (h8300_gdbarch_init): Don't register deleted functions with
3173         gdbarch.
3174
3175 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3176
3177         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
3178         (ft32_unwind_pc): Delete.
3179         (ft32_unwind_sp): Delete.
3180         (ft32_gdbarch_init): Don't register deleted functions with
3181         gdbarch.
3182
3183 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3184
3185         * gdb/frv-tdep.c (frv_dummy_id): Delete.
3186         (frv_unwind_pc): Delete.
3187         (frv_unwind_sp): Delete.
3188         (frv_gdbarch_init): Don't register deleted functions with
3189         gdbarch.
3190
3191 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3192
3193         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
3194         (riscv_unwind_pc): Delete.
3195         (riscv_unwind_sp): Delete.
3196         (riscv_gdbarch_init): Don't register deleted functions with
3197         gdbarch.
3198
3199 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3200
3201         * gdb/csky-tdep.c (csky_dummy_id): Delete.
3202         (csky_unwind_pc): Delete.
3203         (csky_unwind_sp): Delete.
3204         (csky_gdbarch_init): Don't register deleted functions with
3205         gdbarch.
3206
3207 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3208
3209         * gdb/cris-tdep.c (cris_dummy_id): Delete.
3210         (cris_unwind_pc): Delete.
3211         (cris_unwind_sp): Delete.
3212         (cris_gdbarch_init): Don't register deleted functions with
3213         gdbarch.
3214
3215 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3216
3217         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
3218         (bfin_unwind_pc): Delete.
3219         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
3220
3221 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3222
3223         * gdb/arm-tdep.c (arm_dummy_id): Delete.
3224         (arm_unwind_pc): Delete.
3225         (arm_unwind_sp): Delete.
3226         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
3227
3228 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3229
3230         * gdb/arc-tdep.c (arc_dummy_id): Delete.
3231         (arc_unwind_pc): Delete.
3232         (arc_unwind_sp): Delete.
3233         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
3234
3235 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3236
3237         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
3238         (alpha_unwind_pc): Delete.
3239         (alpha_gdbarch_init): Don't register deleted functions with
3240         gdbarch.
3241
3242 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3243
3244         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
3245         (aarch64_unwind_pc): Delete.
3246         (aarch64_unwind_sp): Delete.
3247         (aarch64_gdbarch_init): Don't register deleted functions with
3248         gdbarch.
3249
3250 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3251
3252         * gdbtypes.c (type_align): Don't consider static members when
3253         computing structure alignment.
3254
3255 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3256
3257         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
3258         return 0 for other types.
3259         * arch-utils.c (default_type_align): Always return 0.
3260         * gdbarch.h: Regenerate.
3261         * gdbarch.sh (type_align): Extend comment.
3262         * gdbtypes.c (type_align): Add additional comments, always call
3263         gdbarch_type_align before applying the default rules.
3264         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
3265         generic code will then apply a suitable default.
3266         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
3267         types, return 0 for other types.
3268
3269 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3270
3271         * NEWS: Create a new section for the next release branch.
3272         Rename the section of the current branch, now that it has
3273         been cut.
3274
3275 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3276
3277         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
3278         * version.in: Bump version to 8.3.50.DATE-git.
3279
3280 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
3281
3282         * aix-thread.c (ptid_cmp): Remove unused variable.
3283         (get_signaled_thread): Likewise.
3284         (store_regs_user_thread): Likewise.
3285         (store_regs_kernel_thread): Likewise.
3286         (fetch_regs_kernel_thread): Remove shadowed variable.
3287
3288 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3289
3290         * features/riscv/32bit-cpu.xml: Add register numbers.
3291         * features/riscv/32bit-fpu.c: Regenerate.
3292         * features/riscv/32bit-fpu.xml: Add register numbers.
3293         * features/riscv/64bit-cpu.xml: Add register numbers.
3294         * features/riscv/64bit-fpu.c: Regenerate.
3295         * features/riscv/64bit-fpu.xml: Add register numbers.
3296
3297 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
3298
3299         * NEWS: Mention two argument form of gdb.Value constructor.
3300         * python/py-value.c (convert_buffer_and_type_to_value): New
3301         function.
3302         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
3303         Add support for handling an optional second argument.  Call
3304         convert_buffer_and_type_to_value as appropriate.
3305         * python/python-internal.h (Py_buffer_deleter): New struct.
3306         (Py_buffer_up): New typedef.
3307
3308 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
3309
3310         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
3311         instead of releasing ownership.
3312
3313 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
3314
3315         * dwarf2read.c (open_and_init_dwp_file): Call
3316         elf_numsections instead of bfd_count_sections to initialize
3317         dwp_file->num_sections.
3318
3319 2019-02-25  Tom Tromey  <tromey@adacore.com>
3320
3321         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
3322
3323 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3324
3325         * gcore.in: Add '--readnever' option when invoking GDB.
3326
3327 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3328
3329         * MAINTAINERS: Update my email address.
3330
3331 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3332
3333         * build-id.c (build_id_to_debug_bfd_1): New function.
3334         (build_id_to_debug_bfd): Look for separate debug file in
3335         sysroot.
3336
3337 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3338
3339         * gdbarch.sh: Update the copyright year range that is placed into
3340         generated files.
3341
3342 2019-02-22  Keith Seitz  <keiths@redhat.com>
3343
3344         PR symtab/23853
3345         * linespec.c (create_sals_line_offset): Search for the default
3346         symtab's filename instead of its fullname.
3347
3348 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3349
3350         * NEWS: Update style defaults.
3351
3352 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3353
3354         * main.c (captured_main_1): Disable styling in batch mode.
3355
3356 2019-02-20  Tom Tromey  <tom@tromey.com>
3357
3358         * symtab.c (symtab_symbol_info): Fix typos.
3359
3360 2019-02-20  Tom Tromey  <tromey@adacore.com>
3361
3362         * findcmd.c (_initialize_mem_search): Use upper case for
3363         metasyntactic variables.
3364
3365 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
3366
3367         * aarch64-tdep.c (aarch64_add_reggroups): New function.
3368         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
3369
3370 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
3371
3372         * top.h (source_file_name): Change to std::string.
3373         * top.c (source_file_name): Likewise.
3374         (command_line_input): Adjust.
3375         * cli/cli-script.c (script_from_file): Adjust.
3376
3377 2019-02-19  Tom Tromey  <tromey@adacore.com>
3378
3379         * ravenscar-thread.c
3380         (ravenscar_thread_target::update_thread_list): Don't call
3381         ada_build_task_list.
3382         * ada-lang.h (ada_build_task_list): Don't declare.
3383         * ada-tasks.c (struct ada_tasks_inferior_data)
3384         <task_list_valid_p>: Now bool.
3385         (read_known_tasks, ada_task_list_changed)
3386         (ada_tasks_invalidate_inferior_data): Update.
3387         (read_known_tasks_array): Return bool.
3388         (read_known_tasks_list): Likewise.
3389         (read_known_tasks): Return void.
3390         (ada_build_task_list): Now static.
3391
3392 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3393
3394         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
3395         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
3396
3397 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3398
3399         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
3400         variant for ada_tasks_pspace_data_handle and
3401         ada_tasks_inferior_data_handle.
3402         (ada_tasks_pspace_data_cleanup): New function.
3403         (ada_tasks_inferior_data_cleanup): New function.
3404
3405 2019-02-17  Tom Tromey  <tom@tromey.com>
3406
3407         * macrotab.h (macro_source_fullname): Return a std::string.
3408         * macrotab.c (macro_include, check_for_redefinition)
3409         (macro_undef, macro_lookup_definition, foreach_macro)
3410         (foreach_macro_in_scope): Update.
3411         (macro_source_fullname): Return a std::string.
3412         * macrocmd.c (show_pp_source_pos): Update.
3413
3414 2019-02-17  Tom Tromey  <tom@tromey.com>
3415
3416         * macrocmd.c (show_pp_source_pos): Style the file names.
3417
3418 2019-02-17  Tom Tromey  <tom@tromey.com>
3419
3420         PR tui/24197:
3421         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
3422
3423 2019-02-17  Tom Tromey  <tom@tromey.com>
3424
3425         * ada-lang.c (user_select_syms): Use filtered printing.
3426         * utils.c (wrap_style): New global.
3427         (desired_style): Remove.
3428         (emit_style_escape): Add stream parameter.
3429         (set_output_style, reset_terminal_style, prompt_for_continue):
3430         Update.
3431         (flush_wrap_buffer): Only flush gdb_stdout.
3432         (wrap_here): Set wrap_style.
3433         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
3434         treat escape sequences as a character.  Change when wrap buffer is
3435         flushed.
3436         (fputs_styled): Do not set the output style when the default is
3437         requested.
3438         * ui-style.h (struct ui_file_style) <is_default>: New method.
3439         * source.c (print_source_lines_base): Emit escape sequences in one
3440         piece.
3441
3442 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3443
3444         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
3445         integers and enumeration types.
3446
3447 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3448
3449         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
3450         instead of lookup_symbol_in_language
3451         (do_exact_match): New function.
3452         (ada_get_symbol_name_matcher): Return do_exact_match when
3453         doing a verbatim match.
3454
3455 2019-02-15  Tom Tromey  <tromey@adacore.com>
3456
3457         * ravenscar-thread.c (ravenscar_thread_target::resume)
3458         (ravenscar_thread_target::wait): Special case wildcard requests.
3459
3460 2019-02-15  Tom Tromey  <tromey@adacore.com>
3461
3462         * ravenscar-thread.c (base_ptid): Remove.
3463         (struct ravenscar_thread_target) <close>: New method.
3464         <m_base_ptid>: New member.
3465         <update_inferior_ptid, active_task, task_is_currently_active,
3466         runtime_initialized>: Declare methods.
3467         <ravenscar_thread_target>: Add constructor.
3468         (ravenscar_thread_target::task_is_currently_active)
3469         (ravenscar_thread_target::update_inferior_ptid)
3470         (ravenscar_runtime_initialized): Rename.  Now methods.
3471         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
3472         (ravenscar_thread_target::update_thread_list): Update.
3473         (ravenscar_thread_target::active_task): Now method.
3474         (ravenscar_thread_target::store_registers)
3475         (ravenscar_thread_target::prepare_to_store)
3476         (ravenscar_thread_target::prepare_to_store)
3477         (ravenscar_thread_target::mourn_inferior): Update.
3478         (ravenscar_inferior_created): Use "new" to create target.
3479         (ravenscar_thread_target::get_ada_task_ptid): Update.
3480         (_initialize_ravenscar): Don't initialize base_ptid.
3481         (ravenscar_ops): Remove global.
3482
3483 2019-02-15  Tom Tromey  <tromey@adacore.com>
3484
3485         * target.h (push_target): Declare new overload.
3486         * target.c (push_target): New overload, taking an rvalue reference.
3487         * remote.c (remote_target::open_1): Use push_target overload.
3488         * corelow.c (core_target_open): Use push_target overload.
3489
3490 2019-02-15  Tom Tromey  <tromey@adacore.com>
3491
3492         * ravenscar-thread.c (is_ravenscar_task)
3493         (ravenscar_task_is_currently_active): Return bool.
3494         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
3495         (_initialize_ravenscar): Remove "(void)".
3496         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
3497         Return bool.
3498
3499 2019-02-15  Tom Tromey  <tromey@adacore.com>
3500
3501         * ravenscar-thread.c (ravenscar_runtime_initializer)
3502         (has_ravenscar_runtime, get_running_thread_id)
3503         (ravenscar_thread_target::resume): Fix indentation.
3504
3505 2019-02-15  Tom Tromey  <tromey@adacore.com>
3506
3507         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
3508         from ravenscar_arch_ops.
3509         (sparc_ravenscar_ops::fetch_registers)
3510         (sparc_ravenscar_ops::store_registers): Now methods.
3511         (sparc_ravenscar_prepare_to_store): Remove.
3512         (sparc_ravenscar_ops): Redefine.
3513         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
3514         methods and destructor.  Remove members.
3515         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
3516         (ravenscar_thread_target::store_registers)
3517         (ravenscar_thread_target::prepare_to_store): Update.
3518         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
3519         Remove.
3520         (struct ppc_ravenscar_powerpc_ops): Derive from
3521         ravenscar_arch_ops.
3522         (ppc_ravenscar_powerpc_ops::fetch_registers)
3523         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
3524         (ppc_ravenscar_powerpc_ops): Redefine.
3525         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
3526         (ppc_ravenscar_e500_ops::fetch_registers)
3527         (ppc_ravenscar_e500_ops::store_registers): Now methods.
3528         (ppc_ravenscar_e500_ops): Redefine.
3529         * aarch64-ravenscar-thread.c
3530         (aarch64_ravenscar_generic_prepare_to_store): Remove.
3531         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
3532         (aarch64_ravenscar_fetch_registers)
3533         (aarch64_ravenscar_store_registers): Now methods.
3534         (aarch64_ravenscar_ops): Redefine.
3535
3536 2019-02-15  Tom Tromey  <tromey@adacore.com>
3537
3538         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
3539         (ravenscar_thread_target::stopped_by_hw_breakpoint)
3540         (ravenscar_thread_target::stopped_by_watchpoint)
3541         (ravenscar_thread_target::stopped_data_address)
3542         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
3543
3544 2019-02-15  Tom Tromey  <tromey@adacore.com>
3545
3546         * ravenscar-thread.c: Fix some typos.
3547
3548 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3549             Tom Tromey  <tromey@adacore.com>
3550
3551         * ada-lang.c (ada_exception_sal): Change addr_string to a
3552         std::string.
3553         (create_ada_exception_catchpoint): Update.
3554
3555 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3556             Tom Tromey  <tromey@adacore.com>
3557
3558         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
3559         (bp_location_ops): Remove.
3560         (base_breakpoint_allocate_location): Update.
3561         (free_bp_location): Update.
3562         * ada-lang.c (class ada_catchpoint_location)
3563         <ada_catchpoint_location>: Remove ops parameter.
3564         (ada_catchpoint_location_dtor): Remove.
3565         (ada_catchpoint_location_ops): Remove.
3566         (allocate_location_exception): Update.
3567         * breakpoint.h (struct bp_location_ops): Remove.
3568         (class bp_location) <bp_location>: Remove bp_location_ops
3569         parameter.
3570         <~bp_location>: Add destructor.
3571         <ops>: Remove.
3572
3573 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3574             Pedro Alves  <palves@redhat.com>
3575
3576         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
3577         'PATH_MAX'.
3578
3579 2019-02-14  David Michael  <fedora.dm0@gmail.com>
3580             Samuel Thibault  <samuel.thibault@gnu.org>
3581             Thomas Schwinge  <thomas@codesourcery.com>
3582
3583         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
3584         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
3585
3586 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3587
3588         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
3589         (check_empty): Use "const char *".
3590
3591         * gnu-nat.c (gnu_nat_target::detach): Instead of
3592         'detach_inferior (pid)' call
3593         'detach_inferior (find_inferior_pid (pid))'.
3594
3595         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
3596         'nat/fork-inferior.o'.
3597         * gnu-nat.c: #include "nat/fork-inferior.h".
3598
3599         * gnu-nat.c (gnu_nat_target::detach): Instead of
3600         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
3601         * gnu-nat.h: #include "inf-child.h".
3602         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
3603         'i386_gnu_nat_target::fetch_registers'.
3604         (gnu_store_registers): Rename/move to
3605         'i386_gnu_nat_target::store_registers'.
3606
3607         * config/i386/nm-i386gnu.h: Don't "#include" any files.
3608         * gnu-nat.h (mach_thread_info): New function.
3609         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
3610
3611         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
3612
3613 2019-02-14  Frederic Konrad  <konrad@adacore.com>
3614
3615         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
3616
3617 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
3618
3619         * windows-nat.c (windows_add_thread): Add new parameter
3620         "main_thread_p" with default value set to false.  Update
3621         function documentation as well as all callers.
3622         (windows_delete_thread): Likewise.
3623         (fake_create_process): Update call to windows_add_thread.
3624         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
3625         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
3626         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
3627         call to windows_delete_thread.
3628
3629 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
3630
3631         * MAINTAINERS: Add Andrew Burgess as global maintainer.
3632
3633 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3634
3635         * symfile.c (find_separate_debug_file): Use canonical path of
3636         sysroot with child_path instead of gdb_sysroot if it is valid.
3637
3638 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3639
3640         * symfile.c (find_separate_debug_file): Use child_path to
3641         determine if an object file is under a sysroot.
3642
3643 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3644
3645         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
3646         unittests/child-path-selftests.c.
3647         * common/pathstuff.c (child_path): New function.
3648         * common/pathstuff.h (child_path): New prototype.
3649         * unittests/child-path-selftests.c: New file.
3650
3651 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3652
3653         * symfile.c (find_separate_debug_file): Look for separate debug
3654         files in debug directories under the sysroot.
3655
3656 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3657
3658         * symtab.h (struct minimal_symbol data_p): New const method.
3659         (struct minimal_symbol text_p): Likewise.
3660         * symtab.c (output_source_filename): Use file name style
3661         to print file name.
3662         (print_symbol_info): Likewise.
3663         (print_msymbol_info): Use address style to print addresses.
3664         Use function name style to print executable text symbols.
3665         (expand_symtab_containing_pc): Use data_p.
3666         (find_pc_sect_compunit_symtab): Likewise.
3667
3668 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3669
3670         * breakpoint.c (describe_other_breakpoints): Use address style
3671         to print addresses.
3672         (say_where): Likewise.
3673
3674 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3675
3676         * ada-typeprint.c (print_func_type): Print function name
3677         style to print function name.
3678         * c-typeprint.c (c_print_type_1): Likewise.
3679
3680 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
3681
3682         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
3683         for execve.
3684
3685 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3686
3687         * c-exp.y (direct_abs_decl): Use emplace_back to record the
3688         type_stack.
3689
3690 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
3691
3692         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
3693         TYPE_CODE_REF types.
3694
3695 2019-02-08  Jim Wilson  <jimw@sifive.com>
3696
3697         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
3698         (riscv_linux_fregset): New.
3699         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
3700
3701 2019-02-07  Tom Tromey  <tom@tromey.com>
3702
3703         * thread.c (thread_cancel_execution_command): Update.
3704         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
3705         methods.
3706         (struct thread_fsm_ops): Remove.
3707         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
3708         (thread_fsm_should_stop, thread_fsm_return_value)
3709         (thread_fsm_set_finished, thread_fsm_finished_p)
3710         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
3711         Don't declare.
3712         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
3713         * infrun.c (clear_proceed_status_thread)
3714         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
3715         (print_stop_event): Update.
3716         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
3717         Add constructor.
3718         (step_command_fsm_ops): Remove.
3719         (new_step_command_fsm): Remove.
3720         (step_1): Update.
3721         (step_command_fsm::should_stop): Rename from
3722         step_command_fsm_should_stop.
3723         (step_command_fsm::clean_up): Rename from
3724         step_command_fsm_clean_up.
3725         (step_command_fsm::do_async_reply_reason): Rename from
3726         step_command_fsm_async_reply_reason.
3727         (struct until_next_fsm): Inherit from thread_fsm.  Add
3728         constructor.
3729         (until_next_fsm_ops): Remove.
3730         (new_until_next_fsm): Remove.
3731         (until_next_fsm::should_stop): Rename from
3732         until_next_fsm_should_stop.
3733         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
3734         (until_next_fsm::do_async_reply_reason): Rename from
3735         until_next_fsm_async_reply_reason.
3736         (struct finish_command_fsm): Inherit from thread_fsm.  Add
3737         constructor.  Change type of breakpoint.
3738         (finish_command_fsm_ops): Remove.
3739         (new_finish_command_fsm): Remove.
3740         (finish_command_fsm::should_stop): Rename from
3741         finish_command_fsm_should_stop.
3742         (finish_command_fsm::clean_up): Rename from
3743         finish_command_fsm_clean_up.
3744         (finish_command_fsm::return_value): Rename from
3745         finish_command_fsm_return_value.
3746         (finish_command_fsm::do_async_reply_reason): Rename from
3747         finish_command_fsm_async_reply_reason.
3748         (finish_command): Update.
3749         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
3750         Add constructor.
3751         (call_thread_fsm_ops): Remove.
3752         (call_thread_fsm::call_thread_fsm): Rename from
3753         new_call_thread_fsm.
3754         (call_thread_fsm::should_stop): Rename from
3755         call_thread_fsm_should_stop.
3756         (call_thread_fsm::should_notify_stop): Rename from
3757         call_thread_fsm_should_notify_stop.
3758         (run_inferior_call, call_function_by_hand_dummy): Update.
3759         * cli/cli-interp.c (should_print_stop_to_console): Update.
3760         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
3761         Add constructor.  Change type of location_breakpoint,
3762         caller_breakpoint.
3763         (until_break_fsm_ops): Remove.
3764         (new_until_break_fsm): Remove.
3765         (until_break_fsm::should_stop): Rename from
3766         until_break_fsm_should_stop.
3767         (until_break_fsm::clean_up): Rename from
3768         until_break_fsm_clean_up.
3769         (until_break_fsm::do_async_reply_reason): Rename from
3770         until_break_fsm_async_reply_reason.
3771         (until_break_command): Update.
3772         * thread-fsm.c: Remove.
3773         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
3774
3775 2019-02-07  Tom Tromey  <tom@tromey.com>
3776
3777         * yy-remap.h: Add include guard.
3778         * xtensa-tdep.h: Add include guard.
3779         * xcoffread.h: Rename include guard.
3780         * varobj-iter.h: Add include guard.
3781         * tui/tui.h: Rename include guard.
3782         * tui/tui-winsource.h: Rename include guard.
3783         * tui/tui-wingeneral.h: Rename include guard.
3784         * tui/tui-windata.h: Rename include guard.
3785         * tui/tui-win.h: Rename include guard.
3786         * tui/tui-stack.h: Rename include guard.
3787         * tui/tui-source.h: Rename include guard.
3788         * tui/tui-regs.h: Rename include guard.
3789         * tui/tui-out.h: Rename include guard.
3790         * tui/tui-layout.h: Rename include guard.
3791         * tui/tui-io.h: Rename include guard.
3792         * tui/tui-hooks.h: Rename include guard.
3793         * tui/tui-file.h: Rename include guard.
3794         * tui/tui-disasm.h: Rename include guard.
3795         * tui/tui-data.h: Rename include guard.
3796         * tui/tui-command.h: Rename include guard.
3797         * tic6x-tdep.h: Add include guard.
3798         * target/waitstatus.h: Rename include guard.
3799         * target/wait.h: Rename include guard.
3800         * target/target.h: Rename include guard.
3801         * target/resume.h: Rename include guard.
3802         * target-float.h: Rename include guard.
3803         * stabsread.h: Add include guard.
3804         * rs6000-tdep.h: Add include guard.
3805         * riscv-fbsd-tdep.h: Add include guard.
3806         * regformats/regdef.h: Rename include guard.
3807         * record.h: Rename include guard.
3808         * python/python.h: Rename include guard.
3809         * python/python-internal.h: Rename include guard.
3810         * python/py-stopevent.h: Rename include guard.
3811         * python/py-ref.h: Rename include guard.
3812         * python/py-record.h: Rename include guard.
3813         * python/py-record-full.h: Rename include guard.
3814         * python/py-record-btrace.h: Rename include guard.
3815         * python/py-instruction.h: Rename include guard.
3816         * python/py-events.h: Rename include guard.
3817         * python/py-event.h: Rename include guard.
3818         * procfs.h: Add include guard.
3819         * proc-utils.h: Add include guard.
3820         * p-lang.h: Add include guard.
3821         * or1k-tdep.h: Rename include guard.
3822         * observable.h: Rename include guard.
3823         * nto-tdep.h: Rename include guard.
3824         * nat/x86-linux.h: Rename include guard.
3825         * nat/x86-linux-dregs.h: Rename include guard.
3826         * nat/x86-gcc-cpuid.h: Add include guard.
3827         * nat/x86-dregs.h: Rename include guard.
3828         * nat/x86-cpuid.h: Rename include guard.
3829         * nat/ppc-linux.h: Rename include guard.
3830         * nat/mips-linux-watch.h: Rename include guard.
3831         * nat/linux-waitpid.h: Rename include guard.
3832         * nat/linux-ptrace.h: Rename include guard.
3833         * nat/linux-procfs.h: Rename include guard.
3834         * nat/linux-osdata.h: Rename include guard.
3835         * nat/linux-nat.h: Rename include guard.
3836         * nat/linux-namespaces.h: Rename include guard.
3837         * nat/linux-btrace.h: Rename include guard.
3838         * nat/glibc_thread_db.h: Rename include guard.
3839         * nat/gdb_thread_db.h: Rename include guard.
3840         * nat/gdb_ptrace.h: Rename include guard.
3841         * nat/fork-inferior.h: Rename include guard.
3842         * nat/amd64-linux-siginfo.h: Rename include guard.
3843         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
3844         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
3845         * nat/aarch64-linux.h: Rename include guard.
3846         * nat/aarch64-linux-hw-point.h: Rename include guard.
3847         * mn10300-tdep.h: Add include guard.
3848         * mips-linux-tdep.h: Add include guard.
3849         * mi/mi-parse.h: Rename include guard.
3850         * mi/mi-out.h: Rename include guard.
3851         * mi/mi-main.h: Rename include guard.
3852         * mi/mi-interp.h: Rename include guard.
3853         * mi/mi-getopt.h: Rename include guard.
3854         * mi/mi-console.h: Rename include guard.
3855         * mi/mi-common.h: Rename include guard.
3856         * mi/mi-cmds.h: Rename include guard.
3857         * mi/mi-cmd-break.h: Rename include guard.
3858         * m2-lang.h: Add include guard.
3859         * location.h: Rename include guard.
3860         * linux-record.h: Rename include guard.
3861         * linux-nat.h: Add include guard.
3862         * linux-fork.h: Add include guard.
3863         * i386-darwin-tdep.h: Rename include guard.
3864         * hppa-linux-offsets.h: Add include guard.
3865         * guile/guile.h: Rename include guard.
3866         * guile/guile-internal.h: Rename include guard.
3867         * gnu-nat.h: Rename include guard.
3868         * gdb-stabs.h: Rename include guard.
3869         * frv-tdep.h: Add include guard.
3870         * f-lang.h: Add include guard.
3871         * event-loop.h: Add include guard.
3872         * darwin-nat.h: Rename include guard.
3873         * cp-abi.h: Rename include guard.
3874         * config/sparc/nm-sol2.h: Rename include guard.
3875         * config/nm-nto.h: Rename include guard.
3876         * config/nm-linux.h: Add include guard.
3877         * config/i386/nm-i386gnu.h: Rename include guard.
3878         * config/djgpp/nl_types.h: Rename include guard.
3879         * config/djgpp/langinfo.h: Rename include guard.
3880         * compile/gcc-cp-plugin.h: Add include guard.
3881         * compile/gcc-c-plugin.h: Add include guard.
3882         * compile/compile.h: Rename include guard.
3883         * compile/compile-object-run.h: Rename include guard.
3884         * compile/compile-object-load.h: Rename include guard.
3885         * compile/compile-internal.h: Rename include guard.
3886         * compile/compile-cplus.h: Rename include guard.
3887         * compile/compile-c.h: Rename include guard.
3888         * common/xml-utils.h: Rename include guard.
3889         * common/x86-xstate.h: Rename include guard.
3890         * common/version.h: Rename include guard.
3891         * common/vec.h: Rename include guard.
3892         * common/tdesc.h: Rename include guard.
3893         * common/selftest.h: Rename include guard.
3894         * common/scoped_restore.h: Rename include guard.
3895         * common/scoped_mmap.h: Rename include guard.
3896         * common/scoped_fd.h: Rename include guard.
3897         * common/safe-iterator.h: Rename include guard.
3898         * common/run-time-clock.h: Rename include guard.
3899         * common/refcounted-object.h: Rename include guard.
3900         * common/queue.h: Rename include guard.
3901         * common/ptid.h: Rename include guard.
3902         * common/print-utils.h: Rename include guard.
3903         * common/preprocessor.h: Rename include guard.
3904         * common/pathstuff.h: Rename include guard.
3905         * common/observable.h: Rename include guard.
3906         * common/netstuff.h: Rename include guard.
3907         * common/job-control.h: Rename include guard.
3908         * common/host-defs.h: Rename include guard.
3909         * common/gdb_wait.h: Rename include guard.
3910         * common/gdb_vecs.h: Rename include guard.
3911         * common/gdb_unlinker.h: Rename include guard.
3912         * common/gdb_unique_ptr.h: Rename include guard.
3913         * common/gdb_tilde_expand.h: Rename include guard.
3914         * common/gdb_sys_time.h: Rename include guard.
3915         * common/gdb_string_view.h: Rename include guard.
3916         * common/gdb_splay_tree.h: Rename include guard.
3917         * common/gdb_setjmp.h: Rename include guard.
3918         * common/gdb_ref_ptr.h: Rename include guard.
3919         * common/gdb_optional.h: Rename include guard.
3920         * common/gdb_locale.h: Rename include guard.
3921         * common/gdb_assert.h: Rename include guard.
3922         * common/filtered-iterator.h: Rename include guard.
3923         * common/filestuff.h: Rename include guard.
3924         * common/fileio.h: Rename include guard.
3925         * common/environ.h: Rename include guard.
3926         * common/common-utils.h: Rename include guard.
3927         * common/common-types.h: Rename include guard.
3928         * common/common-regcache.h: Rename include guard.
3929         * common/common-inferior.h: Rename include guard.
3930         * common/common-gdbthread.h: Rename include guard.
3931         * common/common-exceptions.h: Rename include guard.
3932         * common/common-defs.h: Rename include guard.
3933         * common/common-debug.h: Rename include guard.
3934         * common/cleanups.h: Rename include guard.
3935         * common/buffer.h: Rename include guard.
3936         * common/btrace-common.h: Rename include guard.
3937         * common/break-common.h: Rename include guard.
3938         * cli/cli-utils.h: Rename include guard.
3939         * cli/cli-style.h: Rename include guard.
3940         * cli/cli-setshow.h: Rename include guard.
3941         * cli/cli-script.h: Rename include guard.
3942         * cli/cli-interp.h: Rename include guard.
3943         * cli/cli-decode.h: Rename include guard.
3944         * cli/cli-cmds.h: Rename include guard.
3945         * charset-list.h: Add include guard.
3946         * buildsym-legacy.h: Rename include guard.
3947         * bfin-tdep.h: Add include guard.
3948         * ax.h: Rename include guard.
3949         * arm-linux-tdep.h: Add include guard.
3950         * arm-fbsd-tdep.h: Add include guard.
3951         * arch/xtensa.h: Rename include guard.
3952         * arch/tic6x.h: Add include guard.
3953         * arch/i386.h: Add include guard.
3954         * arch/arm.h: Rename include guard.
3955         * arch/arm-linux.h: Rename include guard.
3956         * arch/arm-get-next-pcs.h: Rename include guard.
3957         * arch/amd64.h: Add include guard.
3958         * arch/aarch64-insn.h: Rename include guard.
3959         * arch-utils.h: Rename include guard.
3960         * annotate.h: Add include guard.
3961         * amd64-darwin-tdep.h: Rename include guard.
3962         * aarch64-linux-tdep.h: Add include guard.
3963         * aarch64-fbsd-tdep.h: Add include guard.
3964         * aarch32-linux-nat.h: Add include guard.
3965
3966 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3967
3968         * macrotab.c (macro_define_internal): New function that
3969         factorizes macro_define_object_internal and macro_define_function
3970         code.
3971         (macro_define_object_internal): Use macro_define_internal.
3972         (macro_define_function): Likewise.
3973
3974 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3975
3976         * macrocmd.c (extract_identifier): Return
3977         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
3978         callers.
3979
3980 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
3981
3982         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
3983
3984 2019-02-05  Tom Tromey  <tom@tromey.com>
3985
3986         * target.c (target_stack::unpush): Move assertion earlier.
3987
3988 2019-01-30  Tom Tromey  <tom@tromey.com>
3989
3990         PR python/23615:
3991         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
3992         (gdbpy_parse_and_eval): Likewise.
3993         * python/python-internal.h (gdbpy_allow_threads): New class.
3994
3995 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
3996
3997         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
3998         (aarch64_fbsd_fpregmap): Move earlier.
3999         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
4000         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4001         instead of individual calls to trad_frame_set_reg_addr.
4002         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
4003         earlier.
4004         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
4005         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4006         instead of individual calls to trad_frame_set_reg_addr.
4007
4008 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
4009
4010         * CONTRIBUTE: Replace contribution list with wiki link.
4011
4012 2019-01-25  Tom Tromey  <tom@tromey.com>
4013
4014         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
4015
4016 2019-01-25  Tom Tromey  <tom@tromey.com>
4017
4018         * xtensa-linux-nat.c: Fix common/ includes.
4019         * xml-support.h: Fix common/ includes.
4020         * xml-support.c: Fix common/ includes.
4021         * x86-linux-nat.c: Fix common/ includes.
4022         * windows-nat.c: Fix common/ includes.
4023         * varobj.h: Fix common/ includes.
4024         * varobj.c: Fix common/ includes.
4025         * value.c: Fix common/ includes.
4026         * valops.c: Fix common/ includes.
4027         * utils.c: Fix common/ includes.
4028         * unittests/xml-utils-selftests.c: Fix common/ includes.
4029         * unittests/utils-selftests.c: Fix common/ includes.
4030         * unittests/unpack-selftests.c: Fix common/ includes.
4031         * unittests/tracepoint-selftests.c: Fix common/ includes.
4032         * unittests/style-selftests.c: Fix common/ includes.
4033         * unittests/string_view-selftests.c: Fix common/ includes.
4034         * unittests/scoped_restore-selftests.c: Fix common/ includes.
4035         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
4036         * unittests/scoped_fd-selftests.c: Fix common/ includes.
4037         * unittests/rsp-low-selftests.c: Fix common/ includes.
4038         * unittests/parse-connection-spec-selftests.c: Fix common/
4039         includes.
4040         * unittests/optional-selftests.c: Fix common/ includes.
4041         * unittests/offset-type-selftests.c: Fix common/ includes.
4042         * unittests/observable-selftests.c: Fix common/ includes.
4043         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
4044         * unittests/memrange-selftests.c: Fix common/ includes.
4045         * unittests/memory-map-selftests.c: Fix common/ includes.
4046         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
4047         * unittests/function-view-selftests.c: Fix common/ includes.
4048         * unittests/environ-selftests.c: Fix common/ includes.
4049         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
4050         * unittests/common-utils-selftests.c: Fix common/ includes.
4051         * unittests/cli-utils-selftests.c: Fix common/ includes.
4052         * unittests/array-view-selftests.c: Fix common/ includes.
4053         * ui-file.c: Fix common/ includes.
4054         * tui/tui-io.c: Fix common/ includes.
4055         * tracepoint.h: Fix common/ includes.
4056         * tracepoint.c: Fix common/ includes.
4057         * tracefile-tfile.c: Fix common/ includes.
4058         * top.h: Fix common/ includes.
4059         * top.c: Fix common/ includes.
4060         * thread.c: Fix common/ includes.
4061         * target/waitstatus.h: Fix common/ includes.
4062         * target/waitstatus.c: Fix common/ includes.
4063         * target.h: Fix common/ includes.
4064         * target.c: Fix common/ includes.
4065         * target-memory.c: Fix common/ includes.
4066         * target-descriptions.c: Fix common/ includes.
4067         * symtab.h: Fix common/ includes.
4068         * symfile.c: Fix common/ includes.
4069         * stap-probe.c: Fix common/ includes.
4070         * spu-linux-nat.c: Fix common/ includes.
4071         * sparc-nat.c: Fix common/ includes.
4072         * source.c: Fix common/ includes.
4073         * solib.c: Fix common/ includes.
4074         * solib-target.c: Fix common/ includes.
4075         * ser-unix.c: Fix common/ includes.
4076         * ser-tcp.c: Fix common/ includes.
4077         * ser-pipe.c: Fix common/ includes.
4078         * ser-base.c: Fix common/ includes.
4079         * selftest-arch.c: Fix common/ includes.
4080         * s12z-tdep.c: Fix common/ includes.
4081         * rust-exp.y: Fix common/ includes.
4082         * rs6000-aix-tdep.c: Fix common/ includes.
4083         * riscv-tdep.c: Fix common/ includes.
4084         * remote.c: Fix common/ includes.
4085         * remote-notif.h: Fix common/ includes.
4086         * remote-fileio.h: Fix common/ includes.
4087         * remote-fileio.c: Fix common/ includes.
4088         * regcache.h: Fix common/ includes.
4089         * regcache.c: Fix common/ includes.
4090         * record-btrace.c: Fix common/ includes.
4091         * python/python.c: Fix common/ includes.
4092         * python/py-type.c: Fix common/ includes.
4093         * python/py-inferior.c: Fix common/ includes.
4094         * progspace.h: Fix common/ includes.
4095         * producer.c: Fix common/ includes.
4096         * procfs.c: Fix common/ includes.
4097         * proc-api.c: Fix common/ includes.
4098         * printcmd.c: Fix common/ includes.
4099         * ppc-linux-nat.c: Fix common/ includes.
4100         * parser-defs.h: Fix common/ includes.
4101         * osdata.c: Fix common/ includes.
4102         * obsd-nat.c: Fix common/ includes.
4103         * nat/x86-linux.c: Fix common/ includes.
4104         * nat/x86-linux-dregs.c: Fix common/ includes.
4105         * nat/x86-dregs.h: Fix common/ includes.
4106         * nat/x86-dregs.c: Fix common/ includes.
4107         * nat/ppc-linux.c: Fix common/ includes.
4108         * nat/mips-linux-watch.h: Fix common/ includes.
4109         * nat/mips-linux-watch.c: Fix common/ includes.
4110         * nat/linux-waitpid.c: Fix common/ includes.
4111         * nat/linux-ptrace.h: Fix common/ includes.
4112         * nat/linux-ptrace.c: Fix common/ includes.
4113         * nat/linux-procfs.c: Fix common/ includes.
4114         * nat/linux-personality.c: Fix common/ includes.
4115         * nat/linux-osdata.c: Fix common/ includes.
4116         * nat/linux-namespaces.c: Fix common/ includes.
4117         * nat/linux-btrace.h: Fix common/ includes.
4118         * nat/linux-btrace.c: Fix common/ includes.
4119         * nat/fork-inferior.c: Fix common/ includes.
4120         * nat/amd64-linux-siginfo.c: Fix common/ includes.
4121         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
4122         * nat/aarch64-linux.c: Fix common/ includes.
4123         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
4124         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
4125         * namespace.h: Fix common/ includes.
4126         * mips-linux-tdep.c: Fix common/ includes.
4127         * minsyms.c: Fix common/ includes.
4128         * mi/mi-parse.h: Fix common/ includes.
4129         * mi/mi-main.c: Fix common/ includes.
4130         * mi/mi-cmd-env.c: Fix common/ includes.
4131         * memrange.h: Fix common/ includes.
4132         * memattr.c: Fix common/ includes.
4133         * maint.h: Fix common/ includes.
4134         * maint.c: Fix common/ includes.
4135         * main.c: Fix common/ includes.
4136         * machoread.c: Fix common/ includes.
4137         * location.c: Fix common/ includes.
4138         * linux-thread-db.c: Fix common/ includes.
4139         * linux-nat.c: Fix common/ includes.
4140         * linux-fork.c: Fix common/ includes.
4141         * inline-frame.c: Fix common/ includes.
4142         * infrun.c: Fix common/ includes.
4143         * inflow.c: Fix common/ includes.
4144         * inferior.h: Fix common/ includes.
4145         * inferior.c: Fix common/ includes.
4146         * infcmd.c: Fix common/ includes.
4147         * inf-ptrace.c: Fix common/ includes.
4148         * inf-child.c: Fix common/ includes.
4149         * ia64-linux-nat.c: Fix common/ includes.
4150         * i387-tdep.c: Fix common/ includes.
4151         * i386-tdep.c: Fix common/ includes.
4152         * i386-linux-tdep.c: Fix common/ includes.
4153         * i386-linux-nat.c: Fix common/ includes.
4154         * i386-go32-tdep.c: Fix common/ includes.
4155         * i386-fbsd-tdep.c: Fix common/ includes.
4156         * i386-fbsd-nat.c: Fix common/ includes.
4157         * guile/scm-type.c: Fix common/ includes.
4158         * guile/guile.c: Fix common/ includes.
4159         * go32-nat.c: Fix common/ includes.
4160         * gnu-nat.c: Fix common/ includes.
4161         * gdbthread.h: Fix common/ includes.
4162         * gdbarch-selftests.c: Fix common/ includes.
4163         * gdb_usleep.c: Fix common/ includes.
4164         * gdb_select.h: Fix common/ includes.
4165         * gdb_bfd.c: Fix common/ includes.
4166         * gcore.c: Fix common/ includes.
4167         * fork-child.c: Fix common/ includes.
4168         * findvar.c: Fix common/ includes.
4169         * fbsd-nat.c: Fix common/ includes.
4170         * event-top.c: Fix common/ includes.
4171         * event-loop.c: Fix common/ includes.
4172         * dwarf2read.c: Fix common/ includes.
4173         * dwarf2loc.c: Fix common/ includes.
4174         * dwarf2-frame.c: Fix common/ includes.
4175         * dwarf-index-cache.c: Fix common/ includes.
4176         * dtrace-probe.c: Fix common/ includes.
4177         * disasm-selftests.c: Fix common/ includes.
4178         * defs.h: Fix common/ includes.
4179         * csky-tdep.c: Fix common/ includes.
4180         * cp-valprint.c: Fix common/ includes.
4181         * cp-support.h: Fix common/ includes.
4182         * cp-support.c: Fix common/ includes.
4183         * corelow.c: Fix common/ includes.
4184         * completer.h: Fix common/ includes.
4185         * completer.c: Fix common/ includes.
4186         * compile/compile.c: Fix common/ includes.
4187         * compile/compile-loc2c.c: Fix common/ includes.
4188         * compile/compile-cplus-types.c: Fix common/ includes.
4189         * compile/compile-cplus-symbols.c: Fix common/ includes.
4190         * command.h: Fix common/ includes.
4191         * cli/cli-dump.c: Fix common/ includes.
4192         * cli/cli-cmds.c: Fix common/ includes.
4193         * charset.c: Fix common/ includes.
4194         * build-id.c: Fix common/ includes.
4195         * btrace.h: Fix common/ includes.
4196         * btrace.c: Fix common/ includes.
4197         * breakpoint.h: Fix common/ includes.
4198         * breakpoint.c: Fix common/ includes.
4199         * ax.h: 
4200         (enum agent_op): Fix common/ includes.
4201         * ax-general.c (struct aop_map): Fix common/ includes.
4202         * ax-gdb.c: Fix common/ includes.
4203         * auxv.c: Fix common/ includes.
4204         * auto-load.c: Fix common/ includes.
4205         * arm-tdep.c: Fix common/ includes.
4206         * arch/riscv.c: Fix common/ includes.
4207         * arch/ppc-linux-common.c: Fix common/ includes.
4208         * arch/i386.c: Fix common/ includes.
4209         * arch/arm.c: Fix common/ includes.
4210         * arch/arm-linux.c: Fix common/ includes.
4211         * arch/arm-get-next-pcs.c: Fix common/ includes.
4212         * arch/amd64.c: Fix common/ includes.
4213         * arch/aarch64.c: Fix common/ includes.
4214         * arch/aarch64-insn.c: Fix common/ includes.
4215         * arch-utils.c: Fix common/ includes.
4216         * amd64-windows-tdep.c: Fix common/ includes.
4217         * amd64-tdep.c: Fix common/ includes.
4218         * amd64-sol2-tdep.c: Fix common/ includes.
4219         * amd64-obsd-tdep.c: Fix common/ includes.
4220         * amd64-nbsd-tdep.c: Fix common/ includes.
4221         * amd64-linux-tdep.c: Fix common/ includes.
4222         * amd64-linux-nat.c: Fix common/ includes.
4223         * amd64-fbsd-tdep.c: Fix common/ includes.
4224         * amd64-fbsd-nat.c: Fix common/ includes.
4225         * amd64-dicos-tdep.c: Fix common/ includes.
4226         * amd64-darwin-tdep.c: Fix common/ includes.
4227         * agent.c: Fix common/ includes.
4228         * ada-lang.h: Fix common/ includes.
4229         * ada-lang.c: Fix common/ includes.
4230         * aarch64-tdep.c: Fix common/ includes.
4231
4232 2019-01-25  Tom Tromey  <tom@tromey.com>
4233
4234         * common/create-version.sh: Use common/version.h.
4235
4236 2019-01-24  Pedro Alves  <palves@redhat.com>
4237
4238         * infrun.c (signal_stop, signal_print, signal_program)
4239         (signal_catch, signal_pass): Now arrays instead of pointers.
4240         (update_signals_program_target, do_target_resume)
4241         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
4242         * linux-nat.c (linux_nat_target::pass_signals)
4243         (linux_nat_target::create_inferior, linux_nat_target::attach):
4244         Adjust.
4245         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
4246         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
4247         * procfs.c (procfs_target::pass_signals): Adjust.
4248         * record-full.c (record_full_target::resume): Adjust.
4249         * remote.c (remote_target::pass_signals)
4250         (remote_target::program_signals): Adjust.
4251         * target-debug.h (target_debug_print_signals): Now takes a
4252         gdb::array_view as parameter.  Adjust.
4253         * target.h (target_ops) <pass_signals, program_signals>: Replace
4254         pointer and length parameters with gdb::array_view.
4255         (target_pass_signals, target_program_signals): Likewise.
4256         * target-delegates.c: Regenerate.
4257
4258 2019-01-24  Pedro Alves  <palves@redhat.com>
4259
4260         * common/forward-scope-exit.h
4261         (forward_scope_exit::forward_scope_exit): Pass arguments to
4262         m_bind_function directly, instead of creating a std::bind and
4263         copying that.
4264
4265 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
4266
4267         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4268         for static members.
4269         (pass_in_v_vfp_candidate): Likewise.
4270
4271 2019-01-23  Tom Tromey  <tom@tromey.com>
4272             Pedro Alves  <palves@redhat.com>
4273
4274         * regcache.c (class regcache_invalidator): Remove.
4275         (regcache::raw_write): Use make_scope_exit.
4276
4277 2019-01-23  Tom Tromey  <tom@tromey.com>
4278
4279         * ui-out.h (class ui_out_emit_type): Update comment.
4280
4281 2019-01-23  Tom Tromey  <tom@tromey.com>
4282
4283         * infrun.c (fetch_inferior_event): Update comment.
4284
4285 2019-01-23  Tom Tromey  <tom@tromey.com>
4286             Pedro Alves  <palves@redhat.com>
4287
4288         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
4289         parameter.
4290         (fetch_inferior_event): Use SCOPE_EXIT.
4291
4292
4293 2019-01-23  Tom Tromey  <tom@tromey.com>
4294             Pedro Alves  <palves@redhat.com>
4295
4296         * infrun.c (disable_thread_events): Delete.
4297         (stop_all_threads): Use SCOPE_EXIT.
4298
4299 2019-01-23  Tom Tromey  <tom@tromey.com>
4300             Pedro Alves  <palves@redhat.com>
4301
4302         * symfile.c: Include forward-scope-exit.h.
4303         (clear_symtab_users_cleanup): Replace forward declaration with
4304         a FORWARD_SCOPE_EXIT.
4305         (syms_from_objfile_1): Use the forward_scope_exit and
4306         gdb::optional instead of cleanup_function.
4307         (reread_symbols): Use the forward_scope_exit instead of
4308         cleanup_function.
4309         (clear_symtab_users_cleanup): Remove function.
4310
4311 2019-01-23  Tom Tromey  <tom@tromey.com>
4312             Pedro Alves  <palves@redhat.com>
4313
4314         * linux-nat.c: Include scope-exit.h.
4315         (cleanup_target_stop): Remove.
4316         (linux_nat_target::static_tracepoint_markers_by_strid): Use
4317         SCOPE_EXIT.
4318
4319 2019-01-23  Tom Tromey  <tom@tromey.com>
4320             Pedro Alves  <palves@redhat.com>
4321
4322         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
4323         (call_function_by_hand_dummy): Use SCOPE_EXIT.
4324
4325 2019-01-23  Tom Tromey  <tom@tromey.com>
4326             Andrew Burgess  <andrew.burgess@embecosm.com>
4327             Pedro Alves  <palves@redhat.com>
4328
4329         * infrun.c (fetch_inferior_event): Use scope_exit.
4330         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
4331         * top.c (execute_command): Use scope_exit.
4332         * breakpoint.c (bpstat_do_actions): Use scope_exit.
4333         * utils.c (do_bpstat_clear_actions_cleanup)
4334         (make_bpstat_clear_actions_cleanup): Remove.
4335
4336 2019-01-23  Tom Tromey  <tom@tromey.com>
4337             Pedro Alves  <palves@redhat.com>
4338
4339         * infrun.c: Include "common/scope-exit.h"
4340         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
4341         (wait_for_inferior): Use SCOPE_EXIT.
4342         (fetch_inferior_event): Use scope_exit.
4343
4344 2019-01-23  Tom Tromey  <tom@tromey.com>
4345             Pedro Alves  <palves@redhat.com>
4346
4347         * breakpoint.c (create_breakpoint): Remove cleanup.
4348
4349 2019-01-23  Tom Tromey  <tom@tromey.com>
4350             Andrew Burgess  <andrew.burgess@embecosm.com>
4351             Pedro Alves  <palves@redhat.com>
4352
4353 2019-01-23  Pedro Alves  <palves@redhat.com>
4354
4355         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
4356
4357 2019-01-23  Pedro Alves  <palves@redhat.com>
4358             Andrew Burgess  <andrew.burgess@embecosm.com>
4359
4360         * gdbthread.h: Include "common/forward-scope-exit.h".
4361         (scoped_finish_thread_state): Redefine custom class in terms of
4362         forward_scope_exit.
4363
4364 2019-01-23  Pedro Alves  <palves@redhat.com>
4365             Andrew Burgess  <andrew.burgess@embecosm.com>
4366
4367         * common/forward-scope-exit.h: New file.
4368
4369 2019-01-23  Pedro Alves  <palves@redhat.com>
4370             Andrew Burgess  <andrew.burgess@embecosm.com>
4371             Tom Tromey  <tom@tromey.com>
4372
4373         * common/scope-exit.h: New file.
4374
4375 2019-01-23  Pedro Alves  <palves@redhat.com>
4376
4377         * common/preprocessor.h (ESC): Rename to ...
4378         (ESC_PARENS): ... this.
4379         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
4380         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
4381
4382 2019-01-23  Tom Tromey  <tom@tromey.com>
4383
4384         * language.h (class scoped_switch_to_sym_language_if_auto):
4385         Initialize m_lang in both cases.
4386
4387 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
4388
4389         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
4390         with XCNEW.
4391
4392 2019-01-22  Tom Tromey  <tom@tromey.com>
4393
4394         * corelow.c: Do not include sys/file.h.
4395
4396 2019-01-22  Tom Tromey  <tom@tromey.com>
4397
4398         * tui/tui-wingeneral.h: Include gdb_curses.h.
4399
4400 2019-01-22  Tom Tromey  <tom@tromey.com>
4401
4402         * source-cache.h (class source_cache) <get_source_lines,
4403         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
4404
4405 2019-01-22  Tom Tromey  <tom@tromey.com>
4406
4407         * remote-fileio.h (struct remote_target): Declare.
4408
4409 2019-01-22  Tom Tromey  <tom@tromey.com>
4410
4411         * python/py-arch.c: Do not include py-ref.h.
4412         * python/py-bpevent.c: Do not include py-ref.h.
4413         * python/py-cmd.c: Do not include py-ref.h.
4414         * python/py-continueevent.c: Do not include py-ref.h.
4415         * python/py-event.h: Do not include py-ref.h.
4416         * python/py-evtregistry.c: Do not include py-ref.h.
4417         * python/py-finishbreakpoint.c: Do not include py-ref.h.
4418         * python/py-frame.c: Do not include py-ref.h.
4419         * python/py-framefilter.c: Do not include py-ref.h.
4420         * python/py-function.c: Do not include py-ref.h.
4421         * python/py-infevents.c: Do not include py-ref.h.
4422         * python/py-linetable.c: Do not include py-ref.h.
4423         * python/py-objfile.c: Do not include py-ref.h.
4424         * python/py-param.c: Do not include py-ref.h.
4425         * python/py-prettyprint.c: Do not include py-ref.h.
4426         * python/py-progspace.c: Do not include py-ref.h.
4427         * python/py-symbol.c: Do not include py-ref.h.
4428         * python/py-symtab.c: Do not include py-ref.h.
4429         * python/py-type.c: Do not include py-ref.h.
4430         * python/py-unwind.c: Do not include py-ref.h.
4431         * python/py-utils.c: Do not include py-ref.h.
4432         * python/py-value.c: Do not include py-ref.h.
4433         * python/py-varobj.c: Do not include py-ref.h.
4434         * python/py-xmethods.c: Do not include py-ref.h.
4435         * python/python.c: Do not include py-ref.h.
4436         * varobj.c: Do not include py-ref.h.
4437
4438 2019-01-22  Tom Tromey  <tom@tromey.com>
4439
4440         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
4441         keyword for bcache.
4442
4443 2019-01-22  Tom Tromey  <tom@tromey.com>
4444
4445         * compile/compile-cplus-types.c: Remove a comment by #include.
4446
4447 2019-01-22  Tom Tromey  <tom@tromey.com>
4448
4449         * compile/gcc-c-plugin.h: Include compile-internal.h.
4450
4451 2019-01-22  Tom Tromey  <tom@tromey.com>
4452
4453         * stabsread.c (EXTERN): Do not define.
4454         (symnum, next_symbol_text_func, processing_gcc_compilation)
4455         (within_function, global_sym_chain, global_stabs)
4456         (previous_stab_code, this_object_header_files)
4457         (n_this_object_header_files)
4458         (n_allocated_this_object_header_files): Define.
4459         * stabsread.h (EXTERN): Never define.  Use "extern".
4460
4461 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4462
4463         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
4464         history_value.
4465
4466 2019-01-21  Tom Tromey  <tom@tromey.com>
4467
4468         * ui-out.c: Fix includes.
4469         * tui/tui-source.c: Fix includes.
4470         * target.c: Fix includes.
4471         * remote.c: Fix includes.
4472         * regcache.c: Fix includes.
4473         * python/py-block.c: Fix includes.
4474         * printcmd.c: Fix includes.
4475         * or1k-tdep.c: Fix includes.
4476         * mi/mi-main.c: Fix includes.
4477         * m32r-tdep.c: Fix includes.
4478         * csky-tdep.c: Fix includes.
4479         * compile/compile-cplus-types.c: Fix includes.
4480         * cli/cli-interp.c: Fix includes.
4481
4482 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
4483
4484         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4485         for padding.
4486
4487 2019-01-16  Tom Tromey  <tom@tromey.com>
4488
4489         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
4490         earlier.
4491         (struct objfile) <msymbols_range>: Move from top level.
4492         <msymbols>: New method.
4493         (class objfile_msymbols): Remove.
4494         * symtab.c (default_collect_symbol_completion_matches_break_on):
4495         Update.
4496         * symmisc.c (dump_msymbols): Update.
4497         * stabsread.c (scan_file_globals): Update.
4498         * objc-lang.c (info_selectors_command, info_classes_command)
4499         (find_methods): Update.
4500         * minsyms.c (find_solib_trampoline_target): Update.
4501         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
4502         * coffread.c (coff_symfile_read): Update.
4503         * ada-lang.c (ada_lookup_simple_minsym)
4504         (ada_collect_symbol_completion_matches): Update.
4505
4506 2019-01-16  Tom Tromey  <tom@tromey.com>
4507
4508         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
4509         type.  Remove no-argument constructor.
4510         <iterator::operator++>: Simplify.
4511         <begin>: Update.
4512         <end>: Use minimal_symbol_count.
4513
4514 2019-01-16  Tom Tromey  <tom@tromey.com>
4515
4516         * objfiles.h (struct objfile) <psymtabs>: New method.
4517         (class objfile_psymtabs): Remove.
4518         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
4519         typedef.
4520         <range>: New method.
4521         (require_partial_symbols): Change return type.
4522         * psymtab.c (require_partial_symbols)
4523         (psym_expand_symtabs_matching): Update.
4524         * mdebugread.c (parse_partial_symbols): Update.
4525         * dbxread.c (dbx_end_psymtab): Update.
4526
4527 2019-01-15  Tom Tromey  <tom@tromey.com>
4528
4529         * symtab.c (lookup_objfile_from_block)
4530         (lookup_symbol_in_objfile_symtabs)
4531         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
4532         (find_line_symtab, info_sources_command)
4533         (default_collect_symbol_completion_matches_break_on)
4534         (make_source_files_completion_list): Update.
4535         * symmisc.c (print_objfile_statistics, dump_objfile)
4536         (maintenance_print_symbols, maintenance_info_symtabs)
4537         (maintenance_check_symtabs, maintenance_info_line_tables):
4538         Update.
4539         * source.c (select_source_symtab)
4540         (forget_cached_source_info_for_objfile): Update.
4541         * objfiles.h (class objfile_compunits): Remove.
4542         (struct objfile) <compunits_range>: New typedef.
4543         (compunits): New method.
4544         * objfiles.c (objfile_relocate1): Update.
4545         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4546         * maint.c (count_symtabs_and_blocks): Update.
4547         * linespec.c (iterate_over_all_matching_symtabs): Update.
4548         * cp-support.c (add_symbol_overload_list_qualified): Update.
4549         * coffread.c (coff_symtab_read): Update.
4550         * ada-lang.c (add_nonlocal_symbols)
4551         (ada_collect_symbol_completion_matches)
4552         (ada_add_global_exceptions): Update.
4553
4554 2019-01-15  Tom Tromey  <tom@tromey.com>
4555
4556         * progspace.h (program_space) <objfiles_safe_range>: New
4557         typedef.
4558         <objfiles_safe>: New method.
4559         * objfiles.h (class all_objfiles_safe): Remove.
4560         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
4561         * jit.c (jit_inferior_exit_hook): Update.
4562
4563 2019-01-17  Tom Tromey  <tom@tromey.com>
4564
4565         * progspace.h (program_space) <objfiles_range>: New typedef.
4566         <objfiles>: New method.
4567         <objfiles_head>: Rename from objfiles.
4568         (object_files): Update.
4569         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
4570         * guile/scm-pretty-print.c
4571         (ppscm_find_pretty_printer_from_objfiles): Update.
4572         * guile/scm-objfile.c (gdbscm_objfiles): Update.
4573         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
4574         Update.
4575         * python/py-progspace.c (pspy_get_objfiles): Update.
4576         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4577         Update.
4578         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4579         (objfpy_lookup_objfile_by_build_id): Update.
4580         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4581         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
4582         Update.
4583         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4584         (expand_symtab_containing_pc, lookup_objfile_from_block)
4585         (lookup_static_symbol, basic_lookup_transparent_type)
4586         (find_pc_sect_compunit_symtab, find_symbol_at_address)
4587         (find_line_symtab, info_sources_command)
4588         (default_collect_symbol_completion_matches_break_on)
4589         (make_source_files_completion_list, find_main_name): Update.
4590         * symmisc.c (print_symbol_bcache_statistics)
4591         (print_objfile_statistics, maintenance_print_symbols)
4592         (maintenance_print_msymbols, maintenance_print_objfiles)
4593         (maintenance_info_symtabs, maintenance_check_symtabs)
4594         (maintenance_expand_symtabs, maintenance_info_line_tables):
4595         Update.
4596         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
4597         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
4598         (map_overlay_command, unmap_overlay_command)
4599         (simple_overlay_update, expand_symtabs_matching)
4600         (map_symbol_filenames): Update.
4601         * symfile-debug.c (set_debug_symfile): Update.
4602         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
4603         Update.
4604         * source.c (select_source_symtab, forget_cached_source_info):
4605         Update.
4606         * solib.c (solib_read_symbols): Update.
4607         * solib-spu.c (append_ocl_sos): Update.
4608         * psymtab.c (maintenance_print_psymbols)
4609         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
4610         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
4611         * printcmd.c (info_symbol_command): Update.
4612         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
4613         Update.
4614         * objfiles.h (class all_objfiles): Remove.
4615         * objfiles.c (have_partial_symbols, have_full_symbols)
4616         (have_minimal_symbols, qsort_cmp, update_section_map)
4617         (shared_objfile_contains_address_p)
4618         (default_iterate_over_objfiles_in_search_order): Update.
4619         * objc-lang.c (info_selectors_command, info_classes_command)
4620         (find_methods): Update.
4621         * minsyms.c (find_solib_trampoline_target): Update.
4622         * maint.c (maintenance_info_sections)
4623         (maintenance_translate_address, count_symtabs_and_blocks):
4624         Update.
4625         * main.c (captured_main_1): Update.
4626         * linux-thread-db.c (try_thread_db_load_from_pdir)
4627         (has_libpthread): Update.
4628         * linespec.c (iterate_over_all_matching_symtabs)
4629         (search_minsyms_for_name): Update.
4630         * jit.c (jit_find_objf_with_entry_addr): Update.
4631         * hppa-tdep.c (find_unwind_entry)
4632         (hppa_lookup_stub_minimal_symbol): Update.
4633         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
4634         Update.
4635         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
4636         (elf_gnu_ifunc_resolve_by_got): Update.
4637         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
4638         * dwarf-index-write.c (save_gdb_index_command): Update.
4639         * cp-support.c (add_symbol_overload_list_qualified): Update.
4640         * breakpoint.c (create_overlay_event_breakpoint)
4641         (create_longjmp_master_breakpoint)
4642         (create_std_terminate_master_breakpoint)
4643         (create_exception_master_breakpoint): Update.
4644         * blockframe.c (find_pc_partial_function): Update.
4645         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
4646         (ada_collect_symbol_completion_matches)
4647         (ada_add_global_exceptions): Update.
4648
4649 2019-01-17  Tom Tromey  <tom@tromey.com>
4650
4651         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
4652         declare VEC.
4653         (solib_target_parse_libraries): Change return type.
4654         (library_list_start_segment, library_list_start_section)
4655         (library_list_end_library, library_list_start_library); Update.
4656         (solib_target_free_library_list): Remove.
4657         (solib_target_parse_libraries): Remove cleanup.  Change return
4658         type.
4659         (solib_target_current_sos): Update.
4660
4661 2019-01-17  Tom Tromey  <tromey@bapiya>
4662
4663         * valprint.c: Replace "the the" with "the".
4664         * symtab.c: Replace "the the" with "the".
4665         * solib.c: Replace "the the" with "the".
4666         * solib-dsbt.c: Replace "the the" with "the".
4667         * linespec.c: Replace "the the" with "the".
4668         * dwarf2loc.h: Replace "the the" with "the".
4669         * amd64-windows-tdep.c: Replace "the the" with "the".
4670         * aarch64-tdep.c: Replace "the the" with "the".
4671
4672 2019-01-16  Keith Seitz  <keiths@redhat.com>
4673
4674         PR gdb/23773
4675         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
4676         <builder>: Rename to ..
4677         <m_builder>: ... this and make private.
4678         (dwarf2_cu::get_builder): New method.  Change all users of
4679         `builder' to use this method.
4680         (dwarf2_start_symtab): Move to ...
4681         (dwarf2_cu::start_symtab): ... here.  Update all callers
4682         (setup_type_unit_groups): Move to ...
4683         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
4684         callers.
4685         (dwarf2_cu::reset_builder): New method.
4686         (process_full_compunit, process_full_type_unit): Use
4687         dwarf2_cu::reset_builder.
4688         (follow_die_offset): Record the ancestor CU if it is different
4689         from the followed DIE's CU.
4690         (follow_die_sig_1): Likewise.
4691
4692 2019-01-15  Tom Tromey  <tom@tromey.com>
4693
4694         * remote.c (class remote_state) <buf>: Now a char_vector.
4695         <buf_size>: Remove.
4696         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
4697         parameter.
4698         (remote_target::getpkt_or_notif_sane_1)
4699         (remote_target::getpkt_sane)
4700         (remote_target::getpkt_or_notif_sane): Likewise.
4701         (class remote_target) <putpkt>: New overload.
4702         (remote_target::read_frame): Change type of "buf_p".  Remove
4703         sizeof_p parameter.
4704         (packet_ok): New overload.
4705         (packet_check_result): New overload.
4706         Update all uses.
4707
4708 2019-01-14  Tom Tromey  <tom@tromey.com>
4709
4710         * remote-notif.c (handle_notification, remote_notif_ack)
4711         (remote_notif_parse): Make "buf" const.
4712         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
4713         const.
4714         (remote_notif_parse, remote_notif_ack, handle_notification):
4715         Likewise.
4716         * remote.c (remote_notif_stop_parse): Make "buf" const.
4717         (remote_target::remote_parse_stop_reply): Make "buf" const.
4718         (remote_notif_stop_ack): Make "buf" const.
4719
4720 2019-01-14  Tom Tromey  <tom@tromey.com>
4721
4722         * remote.c (remote_console_output): Make parameter const.
4723
4724 2019-01-14  Tom Tromey  <tom@tromey.com>
4725
4726         * target-debug.h (target_debug_print_signals): Constify.
4727         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
4728         * procfs.c (procfs_target::pass_signals): Update.
4729         * linux-nat.c (linux_nat_target::pass_signals): Update.
4730         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
4731         * target-delegates.c: Rebuild.
4732         * remote.c (remote_target::program_signals): Update.
4733         (remote_target::pass_signals): Update.
4734         * target.c (target_pass_signals): Constify argument.
4735         (target_program_signals): Likewise.
4736         * target.h (struct target_ops) <pass_signals, program_signals>:
4737         Constify argument.
4738         (target_pass_signals, target_program_signals): Constify argument.
4739
4740 2019-01-14  Tom Tromey  <tom@tromey.com>
4741
4742         PR tui/28819:
4743         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
4744
4745 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
4746
4747         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
4748         field.
4749         * rs6000-tdep.c: Include reggroups.h.
4750         (IS_V_ALIAS_PSEUDOREG): Define.
4751         (rs6000_register_name): Return names for the "vX" aliases.
4752         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
4753         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
4754         aliases.  Call default_register_reggroup_p for all other
4755         pseudo-registers.
4756         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
4757         New functions.
4758         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
4759         Handle "vX" aliases.
4760         (v_alias_pseudo_register_collect): New function.
4761         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
4762         (rs6000_gdbarch_init): Initialize "vX" aliases as
4763         pseudo-registers.  Restore registration of
4764         rs6000_pseudo_register_reggroup_p with
4765         set_tdesc_pseudo_register_reggroup_p.
4766
4767 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
4768
4769         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
4770         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
4771         set_gdbarch_num_pseudo_regs.
4772
4773 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4774
4775         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
4776         Remove arg prefixname, add do_set and do_show.
4777         Add member functions set_list and show_list.
4778         * cli/cli-style.c (class cli_style_option): Update accordingly.
4779         (style_set_list): Move to file scope.
4780         (style_show_list): Likewise.
4781         (set_style): Call help_list.
4782         (show_style): Call cmd_show_list.
4783         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
4784         Update to use the new macro.
4785
4786 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
4787
4788         * ada-lang.c (_initialize_ada_language): Expand the help text
4789         for the "catch exception" command.
4790
4791 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4792
4793         * symtab.c (matching_obj_sections): Initialize obj,
4794         declare it closer to its usage.
4795
4796 2019-01-10  Tom Tromey  <tom@tromey.com>
4797
4798         * thread-iter.h (inf_threads_iterator): Use next_iterator.
4799         (basic_inf_threads_range): Remove.
4800         (inf_threads_range, inf_non_exited_threads_range)
4801         (safe_inf_threads_range): Use next_adapter.
4802
4803 2019-01-10  Keith Seitz  <keiths@redhat.com>
4804
4805         PR gdb/23712
4806         PR symtab/23010
4807         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
4808         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
4809
4810 2019-01-10  Keith Seitz  <keiths@redhat.com>
4811
4812         PR gdb/23712
4813         PR symtab/23010
4814         * dictionary.c (pending_to_vector): Remove.
4815         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4816         Remove _1 suffix, replacing functions of the same name.  Update
4817         all callers.
4818         (dict_create_hashed, dict_create_hashed_expandable)
4819         (dict_create_linear, dict_create_linear_expandable, dict_free)
4820         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
4821         Make functions static.
4822
4823 2019-01-10  Keith Seitz  <keiths@redhat.com>
4824
4825         PR gdb/23712
4826         PR symtab/23010
4827         * dictionary.h (struct dictionary): Replace declaration with
4828         multidictionary.
4829         (dict_create_hashed, dict_create_hashed_expandable)
4830         (dict_create_linear, dict_create_linear_expandable)
4831         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
4832         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
4833         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
4834         taking multidictionary argument.
4835         [ALL_DICT_SYMBOLS]: Update for multidictionary.
4836         * block.h (struct block) <dict>: Change to multidictionary
4837         and rename `multidict'.
4838         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
4839         symmisc.c: Update all dictionary references to multidictionary.
4840
4841 2019-01-10  Keith Seitz  <keiths@redhat.com>
4842
4843         PR gdb/23712
4844         PR symtab/23010
4845         * dictionary.c: Include unordered_map.
4846         (pending_to_vector): New function.
4847         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4848         Rewrite the non-"_1" functions to take vector instead
4849         of linked list.
4850         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
4851         "new" _1 versions of the same name.
4852         (multidictionary): Define.
4853         (std::hash<enum language): New definition.
4854         (collate_pending_symbols_by_language, mdict_create_hashed)
4855         (mdict_create_hashed_expandable, mdict_create_linear)
4856         (mdict_create_linear_expandable, mdict_free)
4857         (find_language_dictionary, create_new_language_dictionary)
4858         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
4859         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
4860         (mdict_size, mdict_empty): New functions.
4861         * dictionary.h (mdict_iterator): Define.
4862
4863 2019-01-10  Pedro Alves  <palves@redhat.com>
4864
4865         * breakpoint.c (read_uploaded_action)
4866         (create_tracepoint_from_upload): Adjust to use
4867         gdb::unique_xmalloc_ptr.
4868         * ctf.c (ctf_write_uploaded_tp):
4869         (SET_ARRAY_FIELD): Use emplace_back.
4870         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
4871         * tracefile-tfile.c (tfile_write_uploaded_tp):
4872         * tracepoint.c (parse_tracepoint_definition): Adjust to use
4873         gdb::unique_xmalloc_ptr.
4874         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
4875         at_string, cond_string, cmd_strings>: Replace char pointers
4876         with gdb::unique_xmalloc_ptr.
4877
4878 2019-01-10  Pedro Alves  <palves@redhat.com>
4879
4880         * solib-target.c (library_list_start_library): Don't xstrdup name.
4881
4882 2019-01-10  Pedro Alves  <palves@redhat.com>
4883
4884         * mdebugread.c (parse_partial_symbols): Use
4885         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
4886
4887 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4888
4889         * linux-fork.c (scoped_switch_fork_info)
4890         <~scoped_switch_fork_info>: Fix incorrect variable name.
4891
4892 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4893
4894         * linux-fork.c (scoped_switch_fork_info)
4895         <scoped_switch_fork_info>: Make explicit.
4896         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
4897
4898 2019-01-10  Tom Tromey  <tom@tromey.com>
4899
4900         * objfiles.h (objfile::reset_psymtabs): Update.
4901         * objfiles.c (objfile::objfile): Update.
4902         * psymtab.h (psymtab_storage::obstack): Update.
4903         (psymtab_storage::m_obstack): Use gdb::optional.
4904         (class psymtab_storage): Update comment.  Remove objfile
4905         parameter.
4906         * psymtab.c (psymtab_storage::psymtab_storage): Update.
4907
4908 2019-01-10  Tom Tromey  <tom@tromey.com>
4909
4910         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
4911         <free_psymtabs>: Now private.
4912         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
4913         (allocate_psymtab): Use new method.
4914
4915 2019-01-10  Tom Tromey  <tom@tromey.com>
4916
4917         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
4918         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
4919         * mdebugread.c (parse_partial_symbols): Use
4920         allocate_dependencies.
4921         * dwarf2read.c (dwarf2_create_include_psymtab): Use
4922         allocate_dependencies.
4923         (process_psymtab_comp_unit_reader)
4924         (build_type_psymtab_dependencies): Likewise.
4925         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
4926
4927 2019-01-10  Tom Tromey  <tom@tromey.com>
4928
4929         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
4930         PSYMBOL_SET_LANGUAGE.
4931         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
4932
4933 2019-01-10  Tom Tromey  <tom@tromey.com>
4934
4935         * psymtab.h (psymtab_storage::obstack): New method.
4936         <m_obstack>: Rename from obstack; now private.
4937         * psymtab.c (psymtab_storage): Update.
4938         * dwarf2read.c (create_addrmap_from_index)
4939         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
4940         Update.
4941
4942 2019-01-10  Tom Tromey  <tom@tromey.com>
4943
4944         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
4945         * objfiles.h (objfile::reset_psymtabs): New method.
4946
4947 2019-01-10  Tom Tromey  <tom@tromey.com>
4948
4949         * symmisc.c (print_symbol_bcache_statistics): Update.
4950         (print_objfile_statistics): Update.
4951         * symfile.c (reread_symbols): Update.
4952         * psymtab.h (class psymtab_storage): New.
4953         * psymtab.c (psymtab_storage): New constructor.
4954         (~psymtab_storage): New destructor.
4955         (require_partial_symbols): Update.
4956         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
4957         (find_pc_sect_psymtab, find_pc_sect_psymbol)
4958         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
4959         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
4960         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
4961         (start_psymtab_common, end_psymtab_common)
4962         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
4963         (allocate_psymtab): Update.
4964         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
4965         Update.
4966         (dump_psymtab_addrmap, maintenance_print_psymbols)
4967         (maintenance_check_psymtabs): Update.
4968         (class objfile_psymtabs): Move to objfiles.h.
4969         * psympriv.h (discard_psymtab): Now inline.
4970         (psymtab_discarder::psymtab_discarder): Update.
4971         (psymtab_discarder::~psymtab_discarder): Update.
4972         (ALL_OBJFILE_PSYMTABS): Rewrite.
4973         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
4974         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
4975         Remove fields.
4976         <partial_symtabs>: New field.
4977         (class objfile_psymtabs): Move from psymtab.h.  Update.
4978         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
4979         psymbol_cache.
4980         (objfile::~objfile): Don't destroy psymbol_cache.
4981         * mdebugread.c (parse_partial_symbols): Update.
4982         * dwarf2read.c (create_addrmap_from_index)
4983         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
4984         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
4985         (add_partial_subprogram, dwarf2_ranges_read): Update.
4986         * dwarf-index-write.c (write_address_map)
4987         (write_one_signatured_type, recursively_write_psymbols)
4988         (class debug_names, class debug_names, write_psymtabs_to_index):
4989         Update.
4990
4991 2019-01-10  Tom Tromey  <tom@tromey.com>
4992
4993         * symtab.h (SYMBOL_SET_NAMES): Update.
4994         (symbol_set_names): Update.
4995         (MSYMBOL_SET_NAMES): Update.
4996         * symtab.c (symbol_set_names): Change argument to be an
4997         objfile_per_bfd_storage.
4998         * psymtab.c (add_psymbol_to_bcache): Update.
4999         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
5000
5001 2019-01-10  Tom Tromey  <tom@tromey.com>
5002
5003         * symtab.c (create_demangled_names_hash): Change argument to be an
5004         objfile_per_bfd_storage.
5005         (symbol_set_names): Update.
5006
5007 2019-01-10  Tom Tromey  <tom@tromey.com>
5008
5009         * xcoffread.c (xcoff_initial_scan): Unconditionally call
5010         init_psymbol_list.
5011         * psymtab.c (init_psymbol_list): Do nothing if already called.
5012         * psympriv.h (init_psymbol_list): Add comment.
5013         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
5014         init_psymbol_list.
5015         * dbxread.c (dbx_symfile_read): Unconditionally call
5016         init_psymbol_list.
5017
5018 2019-01-10  Tom Tromey  <tom@tromey.com>
5019
5020         * xcoffread.c (scan_xcoff_symtab): Update.
5021         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
5022         "where".
5023         * mdebugread.c (parse_partial_symbols)
5024         (handle_psymbol_enumerators): Update.
5025         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
5026         * dbxread.c (read_dbx_symtab): Update.
5027         * psympriv.h (psymbol_placement): New enum.
5028         (add_psymbol_to_list): Update.
5029
5030 2019-01-10  Tom Tromey  <tom@tromey.com>
5031
5032         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
5033         static_psymbols parameters.
5034         (scan_xcoff_symtab): Update.
5035         * psymtab.c (start_psymtab_common): Remove global_psymbols and
5036         static_psymbols parameters.
5037         * psympriv.h (start_psymtab_common): Update.
5038         * mdebugread.c (parse_partial_symbols): Update.
5039         * dwarf2read.c (create_partial_symtab): Update.
5040         * dbxread.c (read_dbx_symtab): Update.
5041         (start_psymtab): Remove global_psymbols and static_psymbols
5042         parameters.
5043
5044 2019-01-10  Tom Tromey  <tom@tromey.com>
5045
5046         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
5047         * psymtab.c (allocate_psymtab): Add comment.
5048         * psympriv.h (allocate_psymtab): Add comment.
5049         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
5050         initializations.
5051         * dbxread.c (dbx_end_psymtab): Remove some initializations.
5052
5053 2019-01-10  Tom Tromey  <tom@tromey.com>
5054
5055         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5056         Don't declare.
5057         * mipsread.c: Include mdebugread.h.
5058         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5059         Declare.
5060         * elfread.c: Include mdebugread.h.
5061
5062 2019-01-09  Tom Tromey  <tom@tromey.com>
5063
5064         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
5065         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
5066         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
5067         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
5068         (psym_lookup_symbol, psym_find_last_source_symtab)
5069         (psym_forget_cached_source_info, psym_print_stats)
5070         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
5071         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
5072         (psym_map_matching_symbols, psym_expand_symtabs_matching)
5073         (psym_find_compunit_symtab_by_address)
5074         (maintenance_print_psymbols, maintenance_info_psymtabs)
5075         (maintenance_check_psymtabs): Use ranged for.
5076         * psymtab.h (class objfile_psymtabs): New.
5077         (require_partial_symbols): Return objfile_psymtabs.
5078         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
5079
5080 2019-01-09  Tom Tromey  <tom@tromey.com>
5081
5082         * symfile.c (overlay_invalidate_all, find_pc_overlay)
5083         (find_pc_mapped_section, list_overlays_command)
5084         (map_overlay_command, unmap_overlay_command)
5085         (simple_overlay_update): Use all_objfiles.
5086         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
5087         * printcmd.c (info_symbol_command): Use all_objfiles.
5088         * objfiles.h (ALL_OBJSECTIONS): Remove.
5089         * maint.c (maintenance_translate_address): Use all_objfiles.
5090         * gcore.c (gcore_create_callback): Use all_objfiles.
5091         (objfile_find_memory_regions): Likewise.
5092
5093 2019-01-09  Tom Tromey  <tom@tromey.com>
5094
5095         * symtab.c (find_line_symtab, info_sources_command)
5096         (make_source_files_completion_list): Use objfile_compunits.
5097         * source.c (select_source_symtab): Use objfile_compunits.
5098         * objfiles.h (struct objfile): Update comment.
5099         (ALL_OBJFILES): Remove.
5100         (ALL_FILETABS): Remove.
5101         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
5102         objfile_compunits.
5103
5104 2019-01-09  Tom Tromey  <tom@tromey.com>
5105
5106         * symmisc.c (print_objfile_statistics, dump_objfile)
5107         (maintenance_print_symbols): Use compunit_filetabs.
5108         * source.c (forget_cached_source_info_for_objfile): Use
5109         compunit_filetabs.
5110         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
5111         (ALL_FILETABS): Use compunit_filetabs.
5112         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
5113         * coffread.c (coff_symtab_read): Use compunit_filetabs.
5114
5115 2019-01-09  Tom Tromey  <tom@tromey.com>
5116
5117         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
5118         (compunit_filetabs): New.
5119         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
5120         compunit_filetabs.
5121         (info_sources_command, make_source_files_completion_list): Remove
5122         declaration.
5123         * symmisc.c (print_objfile_statistics, dump_objfile)
5124         (maintenance_print_symbols): Remove declaration.
5125         (maintenance_info_symtabs): Use compunit_filetabs.
5126         (maintenance_info_line_tables): Likewise.
5127         * source.c (select_source_symtab): Change local variable name.
5128         (forget_cached_source_info_for_objfile): Remove declaration.
5129         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
5130         * objfiles.c (objfile_relocate1): Remove declaration.
5131         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5132         declaration.
5133         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
5134         * coffread.c (coff_symtab_read): Remove declaration.
5135         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5136         compunit_filetabs.
5137
5138 2019-01-09  Tom Tromey  <tom@tromey.com>
5139
5140         * symtab.c (lookup_objfile_from_block)
5141         (find_pc_sect_compunit_symtab, search_symbols)
5142         (default_collect_symbol_completion_matches_break_on): Use
5143         objfile_compunits.
5144         * objfiles.h (ALL_COMPUNITS): Remove.
5145         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
5146         * cp-support.c (add_symbol_overload_list_qualified): Use
5147         objfile_compunits.
5148         * ada-lang.c (ada_collect_symbol_completion_matches)
5149         (ada_add_global_exceptions): Use objfile_compunits.
5150
5151 2019-01-09  Tom Tromey  <tom@tromey.com>
5152
5153         * source.c (select_source_symtab)
5154         (forget_cached_source_info_for_objfile): Remove declaration.
5155         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5156         declaration.
5157         * maint.c (count_symtabs_and_blocks): Remove declaration.
5158         * cp-support.c (add_symbol_overload_list_qualified): Remove
5159         declaration.
5160         * coffread.c (coff_symtab_read): Remove declaration.
5161         * symtab.c (lookup_symbol_in_objfile_symtabs)
5162         (basic_lookup_transparent_type_1): Use objfile_compunits.
5163         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
5164         (info_sources_command, search_symbols)
5165         (default_collect_symbol_completion_matches_break_on)
5166         (make_source_files_completion_list): Remove declaration.
5167         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
5168         (ada_collect_symbol_completion_matches)
5169         (ada_add_global_exceptions): Remove declaration.
5170         * linespec.c (iterate_over_all_matching_symtabs): Use
5171         objfile_compunits.
5172         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
5173         (class objfile_compunits): New.
5174         (ALL_COMPUNITS): Use objfile_compunits.
5175         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
5176         (maintenance_check_symtabs, maintenance_info_line_tables): Use
5177         objfile_compunits.
5178         * objfiles.c (objfile_relocate1): Use objfile_compunits.
5179
5180 2019-01-09  Tom Tromey  <tom@tromey.com>
5181
5182         * symtab.c (search_symbols)
5183         (default_collect_symbol_completion_matches_break_on): Use
5184         objfile_msymbols.
5185         * ada-lang.c (ada_lookup_simple_minsym)
5186         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
5187         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
5188         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
5189         objfile_msymbols.
5190         * coffread.c (coff_symfile_read): Use objfile_msymbols.
5191         * symmisc.c (dump_msymbols): Use objfile_msymbols.
5192         * objc-lang.c (find_methods): Use objfile_msymbols.
5193         (info_selectors_command, info_classes_command): Likewise.
5194         * stabsread.c (scan_file_globals): Use objfile_msymbols.
5195         * objfiles.h (class objfile_msymbols): New.
5196         (ALL_OBJFILE_MSYMBOLS): Remove.
5197         (ALL_MSYMBOLS): Remove.
5198
5199 2019-01-09  Tom Tromey  <tom@tromey.com>
5200
5201         * common/next-iterator.h (next_adapter): Add Iterator template
5202         parameter.
5203         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
5204         (class all_objfiles_safe): New.
5205         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
5206         * objfiles.c (put_objfile_before): Update comment.
5207         (add_separate_debug_objfile): Likewise.
5208         (free_all_objfiles): Use all_objfiles_safe.
5209         (objfile_purge_solibs): Likewise.
5210
5211 2019-01-09  Tom Tromey  <tom@tromey.com>
5212
5213         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5214         (expand_symtab_containing_pc, lookup_static_symbol)
5215         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
5216         (find_symbol_at_address, find_line_symtab, find_main_name): Use
5217         all_objfiles.
5218         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
5219         * breakpoint.c (create_overlay_event_breakpoint)
5220         (create_longjmp_master_breakpoint)
5221         (create_std_terminate_master_breakpoint)
5222         (create_exception_master_breakpoint): Use all_objfiles.
5223         * linux-thread-db.c (try_thread_db_load_from_pdir)
5224         (has_libpthread): Use all_objfiles.
5225         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
5226         * linespec.c (iterate_over_all_matching_symtabs)
5227         (search_minsyms_for_name): Use all_objfiles.
5228         * maint.c (maintenance_info_sections): Use all_objfiles.
5229         * main.c (captured_main_1): Use all_objfiles.
5230         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
5231         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
5232         * guile/scm-pretty-print.c
5233         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
5234         * solib-spu.c (append_ocl_sos): Use all_objfiles.
5235         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
5236         (maintenance_print_msymbols): Use all_objfiles.
5237         * source.c (select_source_symtab): Use all_objfiles.
5238         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
5239         * symfile.c (remove_symbol_file_command)
5240         (expand_symtabs_matching, map_symbol_filenames): Use
5241         all_objfiles.
5242         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
5243         all_objfiles.
5244         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
5245         * objc-lang.c (find_methods): Use all_objfiles.
5246         * objfiles.c (have_partial_symbols, have_full_symbols)
5247         (have_minimal_symbols, qsort_cmp)
5248         (default_iterate_over_objfiles_in_search_order): Use
5249         all_objfiles.
5250         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
5251         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
5252         (maintenance_check_psymtabs): Use all_objfiles.
5253         (ALL_PSYMTABS): Remove.
5254         * compile/compile-object-run.c (do_module_cleanup): Use
5255         all_objfiles.
5256         * blockframe.c (find_pc_partial_function): Use all_objfiles.
5257         * cp-support.c (add_symbol_overload_list_qualified): Use
5258         all_objfiles.
5259         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5260         Use all_objfiles.
5261         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
5262         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
5263         all_objfiles.
5264         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5265         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
5266         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5267         Uses all_objfiles.
5268         * solib.c (solib_read_symbols): Use all_objfiles
5269
5270 2019-01-09  Tom Tromey  <tom@tromey.com>
5271
5272         * probe.c (parse_probes_in_pspace): Use all_objfiles.
5273         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
5274         all_objfiles.
5275         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
5276         * symmisc.c (print_symbol_bcache_statistics)
5277         (print_objfile_statistics, maintenance_print_objfiles)
5278         (maintenance_info_symtabs, maintenance_check_symtabs)
5279         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
5280         all_objfiles.
5281         * source.c (forget_cached_source_info): Use all_objfiles.
5282         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
5283         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5284         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
5285         * objfiles.c (update_section_map): Use all_objfiles.
5286         (shared_objfile_contains_address_p): Likewise.
5287         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
5288         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
5289
5290 2019-01-09  Tom Tromey  <tom@tromey.com>
5291
5292         * common/next-iterator.h: New file.
5293         * objfiles.h (class all_objfiles): New.
5294         (struct objfile_iterator): New.
5295
5296 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5297
5298         * NEWS: Move the description of the changed "frame", "select-frame",
5299          and "info frame" commands to the Changed commands section.
5300
5301 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
5302
5303         * gdbtypes.c (check_stub_method_group): Remove handling of old
5304         mangling schemes.
5305         * linespec.c (find_methods): Likewise.
5306         * stabsread.c (read_member_functions): Likewise.
5307         * valops.c (search_struct_method): Likewise.
5308         (value_struct_elt_for_reference): Likewise.
5309         * NEWS: Mention this change.
5310
5311 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5312
5313         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
5314         print_source_lines.
5315         * source.c (print_source_lines_base): Update line number check.
5316         (print_source_lines): New function.
5317         (source_lines_range::source_lines_range): New function.
5318         * source.h (class source_lines_range): New class.
5319         (print_source_lines): New declaration.
5320
5321 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5322
5323         * linespec.c (linespec_state_destructor): Free self->canonical_names.
5324
5325 2019-01-08  Tom Tromey  <tom@tromey.com>
5326             Simon Marchi  <simon.marchi@ericsson.com>
5327
5328         PR gdb/24060
5329         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
5330         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
5331         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5332         * f-exp.y (DOLLAR_VARIABLE): Likewise.
5333         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
5334         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5335
5336 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5337
5338         * source.c (select_source_symtab): Move header comment to
5339         declaration in source.h.
5340         (forget_cached_source_info_for_objfile): Likewise.
5341         (forget_cached_source_info): Likewise.
5342         (identify_source_line): Likewise.
5343         * source.h (identify_source_line): Move declaration from symtab.h
5344         and add comment from source.c
5345         (print_source_lines): Likewise.
5346         (forget_cached_source_info_for_objfile): Likewise.
5347         (forget_cached_source_info): Likewise.
5348         (select_source_symtab): Likewise.
5349         (enum print_source_lines_flag): Move definition from symtab.h.
5350         * symtab.h (identify_source_line): Move declaration to source.h.
5351         (print_source_lines): Likewise.
5352         (forget_cached_source_info_for_objfile): Likewise.
5353         (forget_cached_source_info): Likewise.
5354         (select_source_symtab): Likewise.
5355         (enum print_source_lines_flag): Move definition to source.h.
5356         * tui/tui-hooks.c: Add 'source.h' include.
5357
5358 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5359
5360         * source.c (print_source_lines_base): Handle requests to print
5361         reverse line number sequences, and guard against empty lines
5362         string.
5363
5364 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5365
5366         * source.c (print_source_lines_base): Fix skip of '\r' if next
5367         character is '\n'.
5368
5369 2019-01-06  Tom Tromey  <tom@tromey.com>
5370
5371         * c-exp.y (struct c_parse_state) <macro_original_text,
5372         expansion_obstack>: New member.
5373         (macro_original_text, expansion_obstack): Remove globals.
5374         (scan_macro_expansion, scanning_macro_expansion)
5375         (finished_macro_expansion): Update.
5376         (scan_macro_cleanup): Remove.
5377         (yylex, c_parse): Update.
5378
5379 2019-01-06  Tom Tromey  <tom@tromey.com>
5380
5381         * c-exp.y (struct c_parse_state) <strings>: New member.
5382         (operator_stoken): Update.
5383
5384 2019-01-06  Tom Tromey  <tom@tromey.com>
5385
5386         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
5387         (union type_stack_elt) <typelist_val>: Now a pointer to
5388         std::vector.
5389         (type_stack_cleanup): Don't declare.
5390         (push_typelist): Update.
5391         * parse.c (pop_typelist): Return a std::vector.
5392         (push_typelist): Take a std::vector.
5393         (follow_types): Update.  Do not free args.
5394         (type_stack_cleanup): Remove.
5395         * c-exp.y (struct c_parse_state): New.
5396         (cpstate): New global.
5397         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
5398         (nonempty_typelist): Update.
5399         (func_mod): Create a new vector.
5400         (c_parse): Create a c_parse_state.
5401         (check_parameter_typelist): Do not delete params.
5402         (function_method): Update.  Do not delete type_list.
5403
5404 2019-01-06  Tom Tromey  <tom@tromey.com>
5405
5406         PR gdb/28155:
5407         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
5408         check_typedef.
5409         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
5410         (print_return_value): Likewise.
5411
5412 2019-01-05  Tom Tromey  <tom@tromey.com>
5413
5414         * contrib/cleanup_check.py: Remove.
5415         * contrib/gcc-with-excheck: Remove.
5416         * contrib/exsummary.py: Remove.
5417         * contrib/excheck.py: Remove.
5418
5419 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
5420
5421         * thread.c (delete_thread_1): Add gdb_assert that THR is not
5422         NULL. Initialize tpprev to NULL instead of assigning it
5423         to NULL on the next statement.
5424         * windows-nat.c (windows_delete_thread): Remove check for
5425         main_thread_id before printing thread exit notifications.
5426         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
5427         Remove thread ID check against main_thread_id.
5428         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
5429         windows_delete_thread.
5430         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
5431
5432 2019-01-04  Tom Tromey  <tom@tromey.com>
5433
5434         * compile/compile.c (_initialize_compile): Use upper case for
5435         metasyntactic variables.
5436         * symmisc.c (_initialize_symmisc): Use upper case for
5437         metasyntactic variables.
5438         * psymtab.c (_initialize_psymtab): Use upper case for
5439         metasyntactic variables.
5440         * demangle.c (demangle_command): Use upper case for metasyntactic
5441         variables.
5442         (_initialize_demangler): Likewise.
5443         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
5444         variables.
5445
5446 2019-01-03  Tom Tromey  <tom@tromey.com>
5447
5448         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
5449
5450 2019-01-03  Tom Tromey  <tom@tromey.com>
5451
5452         * python/py-symtab.c (salpy_str): Update.
5453         (struct salpy_sal_object) <symtab>: Now a PyObject.
5454         (salpy_dealloc): Update.
5455         (del_objfile_sal): Use gdbpy_ref.
5456
5457 2019-01-03  Tom Tromey  <tom@tromey.com>
5458
5459         * python/py-type.c (convert_field): Use new_reference.  Return
5460         gdbpy_ref.
5461         (make_fielditem): Return gdbpy_ref.
5462         (typy_fields): Update.
5463         (typy_getitem): Update.
5464         (field_name): Return gdbpy_ref.  Use new_reference.
5465         (typy_iterator_iternext): Update.
5466
5467 2019-01-03  Tom Tromey  <tom@tromey.com>
5468
5469         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
5470
5471 2019-01-03  Tom Tromey  <tom@tromey.com>
5472
5473         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
5474         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
5475         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
5476         (pspy_set_frame_filters, pspy_set_frame_unwinders)
5477         (pspy_set_type_printers): Likewise.
5478         * python/py-function.c (fnpy_init): Use gdbpy_ref.
5479         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
5480         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
5481         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
5482         (objfpy_set_type_printers): Likewise.
5483
5484 2019-01-03  Tom Tromey  <tom@tromey.com>
5485
5486         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
5487         (gdbpy_print_stack): Use gdbpy_err_fetch.
5488         * python/python-internal.h (class gdbpy_err_fetch): New class.
5489         (class gdbpy_enter) <m_error_type, m_error_value,
5490         m_error_traceback>: Remove.
5491         <m_error>: New member.
5492         (gdbpy_exception_to_string): Don't declare.
5493         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
5494         * python/py-value.c (convert_value_from_python): Use
5495         gdbpy_err_fetch.
5496         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
5497         gdbpy_exception_to_string.
5498         (gdbpy_handle_exception): Use gdbpy_err_fetch.
5499         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
5500         gdbpy_err_fetch.
5501
5502 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5503
5504         * linux-nat.c (delete_lwp_cleanup): Delete.
5505         (struct lwp_deleter): New struct.
5506         (lwp_info_up): New typedef.
5507         (linux_nat_target::follow_fork): Delete cleanup, and make use of
5508         lwp_info_up.
5509
5510 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5511
5512         * linux-fork.c (class scoped_switch_fork_info): New class.
5513         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
5514
5515 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5516
5517         * valops.c (find_overload_match): Remove use of null_cleanup, and
5518         calls to do_cleanups.
5519
5520 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5521
5522         * compile/compile-cplus-types.c
5523         (compile_cplus_instance::decl_name): Handle changes to
5524         cp_func_name.
5525         * cp-support.c (cp_func_name): Update header comment, update
5526         return type.
5527         * cp-support.h (cp_func_name): Update return type in declaration.
5528         * valops.c (find_overload_match): Move temp_func local to top
5529         level of function and change its type.  Use temp_func to hold and
5530         delete temporary string obtained from cp_func_name.
5531
5532 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5533
5534         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
5535         gdb::char_vector, remove cleanup, and update uses of `msg`.
5536
5537 2019-01-03  Jim Wilson  <jimw@sifive.com>
5538
5539         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
5540
5541 2019-01-02  Tom Tromey  <tom@tromey.com>
5542
5543         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
5544         (tdesc_parse_xml): Remove cleanups.
5545         * target-descriptions.h (make_cleanup_free_target_description):
5546         Don't declare.
5547         (target_desc_deleter): New struct.
5548         (target_desc_up): New typedef.
5549         * target-descriptions.c (target_desc_deleter::operator()): Rename
5550         from free_target_description.
5551         (make_cleanup_free_target_description): Remove.
5552
5553 2019-01-02  Tom Tromey  <tom@tromey.com>
5554
5555         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
5556         constructor, destructor.
5557         (linespec_parser): Remove typedef.
5558         (~linespec_parser): Rename from linespec_parser_delete.
5559         (linespec_lex_to_end, linespec_complete_label)
5560         (linespec_complete): Update.
5561         (decode_line_full): Remove cleanups.
5562         (decode_line_1): Update.
5563
5564 2019-01-02  Tom Tromey  <tom@tromey.com>
5565
5566         * python/python-internal.h (inferior_to_inferior_object): Change
5567         return type.
5568         * python/py-exitedevent.c (create_exited_event_object): Update.
5569         * python/py-inferior.c (inferior_to_inferior_object): Return
5570         gdbpy_ref.
5571         (python_new_inferior, python_inferior_deleted)
5572         (thread_to_thread_object, delete_thread_object)
5573         (build_inferior_list, gdbpy_selected_inferior): Update.
5574         * python/py-infthread.c (create_thread_object): Update.  Also fail
5575         if inferior_to_inferior_object fails.
5576
5577 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
5578
5579         * inferior.h (class inferior) <displaced_step_state>: New field.
5580         * infrun.h (struct displaced_step_state): Move here from
5581         infrun.c.  Initialize fields, add constructor.
5582         <inf>: Remove field.
5583         <reset>: New method.
5584         * infrun.c (struct displaced_step_inferior_state): Move to
5585         infrun.h.
5586         (displaced_step_inferior_states): Remove.
5587         (get_displaced_stepping_state): Adust.
5588         (displaced_step_in_progress_any_inferior): Adjust.
5589         (displaced_step_in_progress_thread): Adjust.
5590         (displaced_step_in_progress): Adjust.
5591         (add_displaced_stepping_state): Remove.
5592         (get_displaced_step_closure_by_addr): Adjust.
5593         (remove_displaced_stepping_state): Remove.
5594         (infrun_inferior_exit): Call displaced_step_state.reset.
5595         (use_displaced_stepping): Don't check for NULL.
5596         (displaced_step_prepare_throw): Call
5597         get_displaced_stepping_state.
5598         (displaced_step_fixup): Don't check for NULL.
5599         (prepare_for_detach): Don't check for NULL.
5600
5601 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5602
5603         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
5604          in case of call that did not complete.
5605
5606 2019-01-02  Andrey Utkin  <autkin@undo.io>
5607
5608         * symfile.c (find_separate_debug_file): Fix search of debug files for
5609         remote debuggee.
5610
5611 2019-01-02  Tom Tromey  <tom@tromey.com>
5612
5613         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
5614         indentation.
5615         * python/py-frame.c (frapy_older): Remove cast.
5616         (frapy_newer): Likewise.
5617         * python/py-breakpoint.c (local_setattro): Remove cast.
5618         * python/py-arch.c (archpy_name): Remove local variable.
5619         * python/py-type.c (gdbpy_lookup_type): Remove cast.
5620
5621 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
5622
5623         * unittests/basic_string_view/element_access/char/empty.cc:
5624         Fix year range in copyright header.
5625
5626 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5627
5628         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
5629         Delete.
5630         <operator==>: Update with for removed field.
5631         <hash>: Likewise.
5632         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
5633         <isa_features>: ...this.
5634         <abi_features>: New field.
5635         (riscv_isa_flen): Update comment.
5636         (riscv_abi_xlen): New declaration.
5637         (riscv_abi_flen): New declaration.
5638         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
5639         isa_features.
5640         (riscv_abi_xlen): New function.
5641         (riscv_isa_flen): Update to get answer from isa_features.
5642         (riscv_abi_flen): New function.
5643         (riscv_has_fp_abi): Update to get answer from abi_features.
5644         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
5645         xlen and flen.
5646         (riscv_call_info) <xlen, flen>: Update comment.
5647         (riscv_call_arg_struct): Remove invalid assertions
5648         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
5649         is removed.
5650         (riscv_gdbarch_init): Gather isa features and abi features
5651         separately, ensure both match on the gdbarch when reusing an old
5652         gdbarch.  Relax an error check to allow 32-bit abi float to run on
5653         a target with 64-bit float hardware.
5654
5655 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5656
5657         * source.c (search_command_helper): Stop reverse search
5658         when line 1 has been searched.
5659
5660 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5661
5662         * record-full.c (record_full_base_target::close): Rewrite
5663         record_full_core_buf_list free logic.
5664
5665 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5666
5667         * break-catch-syscall.c (print_one_catch_syscall): xfree
5668         the last text.
5669
5670 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5671
5672         * top.c (print_gdb_version): Update Copyright year in version
5673         message.
5674
5675 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5676
5677         Update copyright year range in all GDB files.
5678
5679 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
5680
5681         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
5682
5683 For older changes see ChangeLog-2018.
5684 \f
5685 Local Variables:
5686 mode: change-log
5687 left-margin: 8
5688 fill-column: 74
5689 version-control: never
5690 coding: utf-8
5691 End:
5692