gdb/ChangeLog

   1 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
   2
   3         * breakpoint.c (breakpoint_1): Update doc and parameter names.
   4
   5 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
   6
   7         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
   8         bpstat_should_step): Return bool, adjust comments.
   9         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
  10         bpstat_should_step): Likewise.
  11
  12 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
  13
  14         * features/Makefile: Use feature target descriptions for Arm.
  15         * features/arm/arm-core.c: Generate new file.
  16         * features/arm/arm-fpa.c: Likewise.
  17         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
  18         * features/arm/arm-m-profile.c: Likewise.
  19         * features/arm/arm-vfpv2.c: Likewise.
  20         * features/arm/arm-vfpv3.c: Likewise.
  21         * features/arm/xscale-iwmmxt.c: Likewise.
  22         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
  23
  24 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
  25
  26         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
  27         ptrace earlier.
  28
  29 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
  30
  31         * features/aarch64-pauth.c: Regenerate.
  32
  33 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
  34
  35         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
  36         bool.
  37         (bpstat_what): Use false instead of 0.
  38
  39 2019-07-09  Pedro Alves  <palves@redhat.com>
  40
  41         * break-catch-throw.c (is_exception_catchpoint): New.
  42         * breakpoint.c (print_one_breakpoint_location): New parameter
  43         'raw_loc'.  Handle it.  Use
  44         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
  45         looking at the breakpoint's type.
  46         (print_one_breakpoint): If handling "maint info breakpoints", also
  47         print locations of exception catchpoints.
  48         * breakpoint.h (is_exception_catchpoint): Declare.
  49
  50 2019-07-09  Pedro Alves  <palves@redhat.com>
  51
  52         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
  53         "addr" field.
  54         (allocate_location_exception_catchpoint): New.
  55         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
  56         (initialize_throw_catchpoint_ops): Install
  57         allocate_location_exception_catchpoint as allocate_location
  58         method.
  59         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
  60         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
  61         bp_loc_other.
  62         (breakpoint_address_is_meaningful): Delete.
  63         (bl_address_is_meaningful): New.
  64         (breakpoint_locations_match): Adjust comment.
  65         (bp_location_from_bp_type): New, factored out of...
  66         (bp_location::bp_location(breakpoint *)): ... this.
  67         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
  68         factored out of...
  69         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
  70         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
  71         breakpoint_address_is_meaningful.
  72         (bp_locations_compare): Adjust comment.
  73         (update_global_location_list): Use bl_address_is_meaningful
  74         instead of breakpoint_address_is_meaningful.
  75         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
  76         explicit.
  77         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
  78         * python/py-breakpoint.c (bppy_get_location): No longer check
  79         whether location is null.
  80
  81 2019-07-09  Pedro Alves  <palves@redhat.com>
  82
  83         PR c++/15468
  84         * breakpoint.c (print_one_breakpoint_location): Remove
  85         single-location assert.
  86
  87 2019-07-09  Tom Tromey  <tom@tromey.com>
  88
  89         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
  90         * configure: Rebuild.
  91         * configure.ac: Change common to gdbsupport.
  92         * gdbsupport: Rename from common.
  93         * acinclude.m4: Change common to gdbsupport.
  94         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
  95         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
  96         gdbsupport.
  97         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
  98         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
  99         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 100         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 101         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 102         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 103         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 104         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 105         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 106         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 107         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 108         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 109         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 110         coff-pe-read.c, command.h, compile/compile-c-support.c,
 111         compile/compile-c.h, compile/compile-cplus-symbols.c,
 112         compile/compile-cplus-types.c, compile/compile-cplus.h,
 113         compile/compile-loc2c.c, compile/compile.c, completer.c,
 114         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 115         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 116         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 117         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 118         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 119         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 120         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 121         features/aarch64-core.c, features/aarch64-fpu.c,
 122         features/aarch64-pauth.c, features/aarch64-sve.c,
 123         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 124         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 125         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 126         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 127         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 128         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 129         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 130         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 131         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 132         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 133         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 134         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 135         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 136         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 137         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 138         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 139         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 140         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 141         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 142         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 143         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 144         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 145         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 146         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 147         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 148         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 149         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 150         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 151         minsyms.c, mips-linux-tdep.c, namespace.h,
 152         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 153         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 154         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 155         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 156         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 157         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 158         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 159         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 160         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 161         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 162         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 163         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 164         procfs.c, producer.c, progspace.h, psymtab.h,
 165         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 166         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 167         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 168         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 169         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 170         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 171         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 172         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 173         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 174         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 175         target-memory.c, target.c, target.h, target/waitstatus.c,
 176         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 177         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 178         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 179         unittests/array-view-selftests.c,
 180         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 181         unittests/common-utils-selftests.c,
 182         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 183         unittests/format_pieces-selftests.c,
 184         unittests/function-view-selftests.c,
 185         unittests/lookup_name_info-selftests.c,
 186         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 187         unittests/mkdir-recursive-selftests.c,
 188         unittests/observable-selftests.c,
 189         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 190         unittests/parse-connection-spec-selftests.c,
 191         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 192         unittests/scoped_fd-selftests.c,
 193         unittests/scoped_mmap-selftests.c,
 194         unittests/scoped_restore-selftests.c,
 195         unittests/string_view-selftests.c, unittests/style-selftests.c,
 196         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 197         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 198         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 199         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 200         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 201         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 202
 203 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 204
 205         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 206         bool value.
 207         (decode_digits_ordinary): Set explicit_line field in sal.
 208         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 209         symtab_and_line that was set on an explicit line number in
 210         assembler code.  Do always update the recorded symtab and line if
 211         we do skip the prologue.
 212
 213 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 214
 215         * breakpoint.c (set_breakpoint_location_function): Remove
 216         explicit_loc parameter.
 217         (momentary_breakpoint_from_master): Update call to
 218         set_breakpoint_location_function.
 219         (add_location_to_breakpoint): Likewise.
 220
 221 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 222
 223         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 224         required features based on default bfd type when no specific bfd
 225         is present.
 226
 227 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 228
 229         * NEWS: Mention that GDB printf and eval commands can now print
 230         C-style and Ada-style convenience var strings without
 231         calling the inferior.
 232         * printcmd.c (printf_c_string): Locally print GDB internal var
 233         instead of transiting via the inferior.
 234         (printf_wide_c_string): Likewise.
 235
 236 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 237
 238         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
 239
 240 2019-07-04  Tom Tromey  <tom@tromey.com>
 241
 242         PR tui/24724:
 243         * tui/tui-winsource.c (tui_clear_source_content): Update.
 244         (tui_source_window_base::set_is_exec_point_at): Fix comment.
 245         (tui_update_breakpoint_info): Update.
 246         (tui_set_exec_info_content): Update.
 247         * tui/tui-source.c (tui_set_source_content_nil): Update.
 248         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
 249         has_break.
 250         * tui/tui-data.h (enum tui_bp_flag): New.
 251         (tui_bp_flags): New enum flags type.
 252         (struct tui_source_element) <break_mode>: Change type.  Rename
 253         from has_break.
 254         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
 255         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
 256         constants.
 257         * tui/tui-winsource.h: Fix comment.
 258
 259 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 260
 261         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
 262         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
 263         (store_fpregs_to_thread)
 264         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 265         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
 266         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
 267         (IWMMXT_REGS_SIZE): Add define.
 268         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
 269         (fetch_vfp_regs, store_vfp_regs)
 270         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 271         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
 272
 273 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 274
 275         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
 276         defines.
 277         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
 278         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
 279         (ARM_INT_REGISTER_SIZE): ...to this.
 280         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
 281         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
 282         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
 283         (arm_linux_collect_gregset, supply_nwfpe_register)
 284         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
 285         defines.
 286         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
 287         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
 288         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
 289         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
 290         (arm_return_in_memory, arm_store_return_value)
 291         (arm_get_longjmp_target, arm_register_g_packet_guesses)
 292         (arm_record_ld_st_multiple): Likewise.
 293         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
 294         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
 295
 296 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 297
 298         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
 299         AARCH64_DISPLACED_MODIFIED_INSNS.
 300         * aarch64-tdep.c (struct aarch64_displaced_step_data)
 301         (aarch64_displaced_step_copy_insn): Likewise.
 302         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 303         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
 304         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
 305         ARM_DISPLACED_MODIFIED_INSNS.
 306         * arm-tdep.c (arm_gdbarch_init): Likewise.
 307         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 308         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
 309         (struct arm_displaced_step_closure): Use
 310         ARM_DISPLACED_MODIFIED_INSNS.
 311
 312 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 313
 314         * features/Makefile: Remove unused xml files.
 315         * features/aarch64.xml: Remove.
 316         * features/i386/amd64-avx-avx512-linux.xml: Remove.
 317         * features/i386/amd64-avx-avx512.xml: Remove.
 318         * features/i386/amd64-avx-linux.xml: Remove.
 319         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
 320         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
 321         * features/i386/amd64-avx-mpx-linux.xml: Remove.
 322         * features/i386/amd64-avx-mpx.xml: Remove.
 323         * features/i386/amd64-avx.xml: Remove.
 324         * features/i386/amd64-linux.xml: Remove.
 325         * features/i386/amd64-mpx-linux.xml: Remove.
 326         * features/i386/amd64-mpx.xml: Remove.
 327         * features/i386/amd64.xml: Remove.
 328         * features/i386/i386-avx-avx512-linux.xml: Remove.
 329         * features/i386/i386-avx-avx512.xml: Remove.
 330         * features/i386/i386-avx-linux.xml: Remove.
 331         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
 332         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
 333         * features/i386/i386-avx-mpx-linux.xml: Remove.
 334         * features/i386/i386-avx-mpx.xml: Remove.
 335         * features/i386/i386-avx.xml: Remove.
 336         * features/i386/i386-linux.xml: Remove.
 337         * features/i386/i386-mmx-linux.xml: Remove.
 338         * features/i386/i386-mmx.xml: Remove.
 339         * features/i386/i386-mpx-linux.xml: Remove.
 340         * features/i386/i386-mpx.xml: Remove.
 341         * features/i386/i386.xml: Remove.
 342         * features/i386/x32-avx-avx512-linux.xml: Remove.
 343         * features/i386/x32-avx-linux.xml: Remove.
 344         * features/i386/x32-linux.xml: Remove.
 345
 346 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 347
 348         * regformats/aarch64.dat: Remove.
 349         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
 350         * regformats/i386/amd64-avx-linux.dat: Remove.
 351         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
 352         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
 353         * regformats/i386/amd64-linux.dat: Remove.
 354         * regformats/i386/amd64-mpx-linux.dat: Remove.
 355         * regformats/i386/amd64.dat: Remove.
 356         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
 357         * regformats/i386/i386-avx-linux.dat: Remove.
 358         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
 359         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
 360         * regformats/i386/i386-linux.dat: Remove.
 361         * regformats/i386/i386-mmx-linux.dat: Remove.
 362         * regformats/i386/i386-mpx-linux.dat: Remove.
 363         * regformats/i386/i386.dat: Remove.
 364         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
 365         * regformats/i386/x32-avx-linux.dat: Remove.
 366         * regformats/i386/x32-linux.dat: Remove.
 367
 368 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 369
 370         * aarch64-tdep.c: Remove xml self tests.
 371         * amd64-linux-tdep.c: Likewise.
 372         * amd64-tdep.c: Likewise.
 373         * i386-linux-tdep.c: Likewise.
 374         * i386-tdep.c: Likewise.
 375
 376 2019-07-03  Pedro Alves  <palves@redhat.com>
 377
 378         PR cli/24732
 379         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
 380         (pipe_cmd_option_defs): New.
 381         (make_pipe_cmd_options_def_group): New.
 382         (pipe_command): Use gdb::option::process_options.
 383         (pipe_command_completer): New function.
 384         (_initialize_cli_cmds): Install completer for "pipe" command.
 385
 386 2019-07-03  Pedro Alves  <palves@redhat.com>
 387
 388         * cli/cli-option.c (union option_value) <string>: New field.
 389         (struct option_def_and_value): Add ctor, move ctor, dtor and
 390         use DISABLE_COPY_AND_ASSIGN.
 391         (option_def_and_value::clear_value): New.
 392         (parse_option, save_option_value_in_ctx, get_val_type_str)
 393         (add_setshow_cmds_for_options): Handle var_string.
 394         * cli-option.h (union option_def::var_address) <string>: New
 395         field.
 396         (struct string_option_def): New.
 397         * maint-test-options.c (struct test_options_opts): Add default
 398         ctor and use DISABLE_COPY_AND_ASSIGN.
 399         <string_opt>: New field.
 400         (test_options_opts::~test_options_opts): New.
 401         (test_options_opts::dump): Also dump "-string".
 402         (test_options_option_defs): Install "string.
 403
 404 2019-07-03  Pedro Alves  <palves@redhat.com>
 405
 406         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
 407         option_value with a null enumeration.
 408         (complete_options): Save the option values in the context.
 409         (save_option_value_in_ctx): New, factored out from ...
 410         (process_options): ... here.
 411         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
 412         of the function.
 413         * maint-test-options.c (test_options_opts::dump): New, factored
 414         out from ...
 415         (maintenance_test_options_command_mode): ... here.
 416         (maintenance_test_options_command_completion_result): Delete.
 417         (maintenance_test_options_command_completion_text): Update
 418         comment.
 419         (maintenance_show_test_options_completion_result): Change
 420         prototype.  Just print
 421         maintenance_test_options_command_completion_text.
 422         (save_completion_result): New.
 423         (maintenance_test_options_completer_mode): Pass options context to
 424         complete_options, and then save a dump.
 425         (_initialize_maint_test_options): Use add_cmd to install "maint
 426         show test-options-completion-result".
 427
 428 2019-07-03  Pedro Alves  <palves@redhat.com>
 429
 430         * NEWS (New commands): Mention "with" and "maint with".
 431         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
 432         (with_command, with_command_completer): New.
 433         (pipe_command): Adjust to new repeat_previous
 434         interface.
 435         (_initialize_cli_cmds): Install the "with" command and its "w"
 436         alias.
 437         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
 438         declarations.
 439         * cli/cli-setshow.c (parse_cli_var_uinteger)
 440         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
 441         argument strings for all var_types.
 442         (get_setshow_command_value_string): New, factored out from ...
 443         (do_show_command): ... this.
 444         * cli/cli-setshow.h: Include <string>.
 445         (get_setshow_command_value_string): Declare.
 446         * command.h (repeat_previous): Now returns const char *.  Adjust
 447         comment.
 448         * maint.c: Include "cli/cli-cmds.h".
 449         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
 450         (_initialize_maint_cmds): Register the "maintenance with" command.
 451         * top.c (repeat_previous): Move bits from pipe_command here:
 452         Return the saved command line, if any; error out if there's no
 453         command to relaunch.
 454
 455 2019-07-03  Pedro Alves  <palves@redhat.com>
 456
 457         * NEWS (New commands): Mention "maint set/show test-settings"
 458         instead of "maint test-settings".
 459         * maint-test-settings.c (maintenance_test_settings_list): Delete.
 460         (maintenance_test_settings_set_list): Rename to ...
 461         (maintenance_set_test_settings_list): ... this.
 462         (maintenance_test_settings_show_list): Rename to  ...
 463         (maintenance_show_test_settings_list): ... this.
 464         (maintenance_test_settings_cmd): Delete.
 465         (maintenance_test_settings_set_cmd): ...
 466         (maintenance_set_test_settings_cmd): ... this.
 467         (maintenance_test_settings_show_cmd): ...
 468         (maintenance_show_test_settings_cmd): ... this.
 469         (maintenance_test_settings_show_value_cmd):
 470         (maintenance_show_test_settings_value_cmd): ... this.
 471         (_initialize_maint_test_settings): No longer install the "maint
 472         test-settings" prefix command.  Rename "maint test-settings set"
 473         to "maint set test-settings", and "maint test-settings show" to
 474         "maint show test-settings".  Adjust all subcommands.
 475
 476 2019-07-03  Pedro Alves  <palves@redhat.com>
 477
 478         * maint-test-settings.c: Fix file's intro comment.  Replace all
 479         references to "test-options" with references to "test-settings",
 480         in comments.
 481
 482 2019-07-03  Pedro Alves  <palves@redhat.com>
 483
 484         * maint-test-settings.c (maintenance_test_settings_xxx)
 485         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
 486         New.
 487         (maintenance_test_settings_enums): Use them.
 488         (maintenance_test_settings_enum): Default to
 489         maintenance_test_settings_xxx.
 490         (_initialize_maint_test_settings): Initialize
 491         MAINTENANCE_TEST_SETTINGS_FILENAME.
 492
 493 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 494
 495         * breakpoint.h (remove_breakpoints_inf): Change return type to
 496         void, move function documentation here.
 497         * breakpoint.c (remove_breakpoints_inf): Change return type to
 498         void, move function documentation to header.
 499
 500 2019-07-02  Pedro Alves  <palves@redhat.com>
 501
 502         * NEWS (Completion improvements): Mention "info threads".
 503         * thread.c (struct info_threads_opts, info_threads_option_defs)
 504         (make_info_threads_options_def_group): New.
 505         (info_threads_command): Use gdb::option::process_options.
 506         (info_threads_command_completer): New.
 507         (_initialize_thread): Use gdb::option::build_help to build the
 508         help text for "info threads".
 509
 510 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 511
 512         * defs.h (generic_load): Move from here...
 513         * symfile.h (generic_load): ... to here.  Rename name parameter
 514         to args.
 515         * symfile.c (generic_load): Add comment.
 516
 517 2019-07-01  Tom Tromey  <tromey@adacore.com>
 518
 519         * dwarf2read.c
 520         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
 521         declaration of without_params.  Fix formatting.
 522
 523 2019-07-01  Tom Tromey  <tromey@adacore.com>
 524
 525         * ada-exp.y (find_primitive_type): Update.
 526         * ada-lang.h (ada_lookup_symbol): Update.
 527         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
 528         parameter.
 529         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
 530
 531 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 532
 533         PR breakpoints/24541
 534         * gdbarch.c: Regenerate.
 535         * gdbarch.h: Regenerate.
 536         * gdbarch.sh: Add 'stap_adjust_register'.
 537         * i386-tdep.c: Include '<unordered_set>'.
 538         (i386_stap_adjust_register): New function.
 539         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
 540         * stap-probe.c (stap_parse_register_operand): Call
 541         'gdbarch_stap_adjust_register'.
 542
 543 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 544
 545         PR python/24742
 546         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
 547         * python/python.c (do_start_initialization): Use 'xmalloc'
 548         instead of 'PyMem_Malloc'.
 549
 550 2019-06-28  Tom Tromey  <tromey@adacore.com>
 551
 552         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
 553         for Ada.
 554
 555 2019-06-27  Tom Tromey  <tromey@adacore.com>
 556
 557         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
 558         objfile_key.
 559         (arm_find_mapping_symbol, arm_record_special_symbol)
 560         (_initialize_arm_tdep): Update.
 561         (arm_objfile_data_free): Remove.
 562
 563 2019-06-27  Tom Tromey  <tromey@adacore.com>
 564
 565         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
 566         to cp_print_static_field.
 567
 568 2019-06-26  Tom Tromey  <tromey@adacore.com>
 569
 570         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
 571         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
 572         declare.
 573
 574 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 575
 576         * features/aarch64-core.c (create_feature_aarch64_core):
 577         Regenerate.
 578         * features/aarch64-core.xml: Add cpsr flags.
 579
 580 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 581
 582         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
 583         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
 584
 585 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 586
 587         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
 588         field.
 589         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
 590         use.
 591         (arm_record_special_symbol): Don't insert new symbol in sorted
 592         position, push it at the end.
 593
 594 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 595
 596         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
 597         (arm_mapping_symbol_s): Remove.
 598         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
 599         (arm_mapping_symbol_vec): New typedef.
 600         (struct arm_per_objfile): Add constructor.
 601         <section_maps>: Change type to
 602         std::unique_ptr<arm_mapping_symbol_vec[]>.
 603         (arm_compare_mapping_symbols): Remove.
 604         (arm_find_mapping_symbol): Adjust to section_maps type change.
 605         (arm_objfile_data_free): Call delete on arm_per_objfile.
 606         (arm_record_special_symbol): Adjust to section_maps type change.
 607         Allocate arm_per_objfile with new.
 608
 609 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 610
 611         * cli/cli-cmds.c (alias_command): Compare the alias prefix
 612         with the command prefix.
 613
 614 2019-06-25  Tom Tromey  <tom@tromey.com>
 615
 616         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
 617         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
 618
 619 2019-06-25  Tom Tromey  <tom@tromey.com>
 620
 621         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
 622         type.
 623         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
 624         protected.
 625
 626 2019-06-25  Tom Tromey  <tom@tromey.com>
 627
 628         * tui/tui-winsource.c
 629         (tui_source_window_base::set_is_exec_point_at): Add check against
 630         LOA_ADDRESS.
 631
 632 2019-06-25  Tom Tromey  <tom@tromey.com>
 633
 634         * tui/tui-source.c (tui_set_source_content): Don't check before
 635         xfree.
 636         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
 637
 638 2019-06-25  Tom Tromey  <tom@tromey.com>
 639
 640         * tui/tui-winsource.h (tui_update_source_window_as_is)
 641         (tui_alloc_source_buffer, tui_line_is_displayed)
 642         (tui_addr_is_displayed): Change type of win_info.
 643         * tui/tui-winsource.c (tui_update_source_window_as_is)
 644         (tui_clear_source_content, tui_show_source_line)
 645         (tui_show_source_content, tui_source_window_base::refill)
 646         (tui_source_window_base::set_is_exec_point_at)
 647         (tui_source_window_base::set_is_exec_point_at)
 648         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
 649         (tui_alloc_source_buffer, tui_line_is_displayed)
 650         (tui_addr_is_displayed): Change type of win_info.  Update.
 651         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 652         (tui_source_window_base::do_make_visible_with_new_height):
 653         Update.
 654         * tui/tui-source.c (tui_set_source_content)
 655         (tui_set_source_content_nil)
 656         (tui_source_window::do_scroll_vertical): Update.
 657         * tui/tui-layout.c (show_layout): Update.
 658         * tui/tui-disasm.c (tui_set_disassem_content)
 659         (tui_disasm_window::do_scroll_vertical): Update.
 660         * tui/tui-data.h (tui_win_content): Remove.
 661         (struct tui_gen_win_info) <content, content_size>: Remove.
 662         (struct tui_source_element): Add initializers and destructor.
 663         (union tui_which_element, struct tui_win_element): Remove.
 664         (struct tui_source_window_base) <content>: New field.
 665         (struct tui_data_window): Remove destructor.
 666         (tui_alloc_content, tui_free_win_content)
 667         (tui_free_all_source_wins_content): Don't declare.
 668         * tui/tui-data.c (tui_initialize_static_data): Update.
 669         (init_content_element, tui_alloc_content): Remove.
 670         (~tui_gen_win_info): Update.
 671         (~tui_data_window, tui_free_all_source_wins_content)
 672         (tui_free_win_content, free_content, free_content_elements):
 673         Remove.
 674
 675 2019-06-25  Tom Tromey  <tom@tromey.com>
 676
 677         * tui/tui-winsource.h (tui_clear_source_content)
 678         (tui_erase_source_content, tui_show_source_content): Change type
 679         of win_info.
 680         * tui/tui-winsource.c (tui_clear_source_content)
 681         (tui_erase_source_content, tui_show_source_content): Change type
 682         of win_info.
 683         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 684         * tui/tui-source.h (tui_set_source_content_nil): Change type of
 685         win_info.
 686         * tui/tui-source.c (tui_set_source_content_nil): Change type of
 687         win_info.
 688         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
 689
 690 2019-06-25  Tom Tromey  <tom@tromey.com>
 691
 692         * tui/tui-winsource.c (tui_clear_source_content)
 693         (tui_source_window_base::set_is_exec_point_at): Update.
 694         * tui/tui-source.c (tui_set_source_content_nil): Update.
 695         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
 696         a bool.
 697         * tui/tui-data.c (init_content_element): Update.
 698
 699 2019-06-25  Tom Tromey  <tom@tromey.com>
 700
 701         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
 702         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
 703         * tui/tui-layout.c (init_and_make_win): Update.
 704         * tui/tui.h (enum tui_win_type): Update.
 705         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
 706         tui_win_is_auxillary.
 707         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
 708         tui_win_is_auxillary.
 709
 710 2019-06-25  Tom Tromey  <tom@tromey.com>
 711
 712         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
 713         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
 714         (tui_delete_data_content_windows, tui_display_all_data)
 715         (tui_data_window::do_scroll_vertical, tui_display_data_from):
 716         Update.
 717         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
 718         * tui/tui-regs.c (tui_last_regs_line_no)
 719         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 720         (tui_show_registers): Update.
 721         (tui_show_register_group): Return void.  Update.
 722         (tui_display_registers_from, tui_display_reg_element_at_line)
 723         (tui_display_registers_from_line, tui_check_register_values):
 724         Update.
 725         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
 726         member.
 727         (struct tui_data_window) <regs_content>: Now a std::vector.
 728         <regs_content_count>: Remove.
 729         (tui_add_content_elements, tui_free_data_content): Don't declare.
 730         * tui/tui-data.c (tui_data_window::clear_detail): Update.
 731         (init_content_element): Remove DATA_WIN case.  Add assert.
 732         (tui_add_content_elements): Remove.
 733         (tui_data_window): Update.
 734         (tui_free_data_content): Remove.
 735         (free_content_elements): Remove DATA_WIN case.
 736
 737 2019-06-25  Tom Tromey  <tom@tromey.com>
 738
 739         * tui/tui-data.c (tui_data_item_window): Update.
 740         * tui/tui-windata.h (tui_check_data_values): Don't declare.
 741         * tui/tui-windata.c (tui_display_all_data)
 742         (tui_display_data_from_line): Update.
 743         (tui_check_data_values): Remove.
 744         * tui/tui-regs.c (tui_show_register_group)
 745         (tui_display_reg_element_at_line): Update.
 746         * tui/tui-hooks.c (tui_register_changed)
 747         (tui_refresh_frame_and_register_information): Call
 748         tui_check_register_values.
 749         * tui/tui-data.h (struct tui_data_window) <data_content,
 750         data_content_count, data_type>: Remove.
 751         (enum tui_data_type): Remove.
 752
 753         * tui/tui-data.c (tui_data_window::clear_detail)
 754         (~tui_data_window): Update.
 755
 756 2019-06-25  Tom Tromey  <tom@tromey.com>
 757
 758         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
 759         declare.
 760         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
 761         Rename from tui_first_data_item_displayed.  Update.
 762         (tui_data_window::refresh_all)
 763         (tui_data_window::do_scroll_vertical): Update.
 764         * tui/tui-data.h (struct tui_data_window)
 765         <first_data_item_displayed>: Declare new method.
 766
 767 2019-06-25  Tom Tromey  <tom@tromey.com>
 768
 769         * tui/tui-data.h (tui_init_generic_part): Don't declare.
 770         * tui/tui-data.c (tui_init_generic_part): Remove, moving
 771         contents...
 772         (tui_initialize_static_data): ...here.
 773
 774 2019-06-25  Tom Tromey  <tom@tromey.com>
 775
 776         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 777         (tui_display_registers_from, tui_check_register_values): Update.
 778         (tui_display_register): Remove win_info parameter; update.
 779         (tui_get_register): Change type of parameters.
 780         * tui/tui-data.h (struct tui_data_element): Remove.
 781         (union tui_which_element) <data>: Remove.
 782         <data_window>: Change type.
 783         (struct tui_data_item_window): New.
 784         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
 785         case.  Add assert.
 786         (~tui_data_item_window): New destructor.
 787         (free_content_elements): Remove DATA_ITEM_WIN case.
 788
 789 2019-06-25  Tom Tromey  <tom@tromey.com>
 790
 791         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
 792         Remove.
 793
 794 2019-06-25  Tom Tromey  <tom@tromey.com>
 795
 796         * tui/tui-data.h (struct tui_command_element): Remove.
 797         (union tui_which_element) <command>: Remove.
 798         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
 799         assert.
 800         (free_content_elements): Remove CMD_WIN case.
 801
 802 2019-06-25  Tom Tromey  <tom@tromey.com>
 803
 804         * tui/tui-layout.c (tui_set_layout): Update.
 805         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
 806         * tui/tui-data.c (layout_def): Update.
 807
 808 2019-06-25  Tom Tromey  <tom@tromey.com>
 809
 810         * tui/tui-wingeneral.c (tui_refresh_all): Update.
 811         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 812         (tui_source_window_base::set_new_height): Update.
 813         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
 814         Update.
 815         (tui_set_locator_fullname, tui_set_locator_info)
 816         (tui_show_frame_info): Update.
 817         * tui/tui-source.c (tui_set_source_content)
 818         (tui_source_is_displayed): Update.
 819         * tui/tui-layout.c (show_source_disasm_command, show_data)
 820         (show_source_or_disasm_and_command): Update.
 821         * tui/tui-disasm.c (tui_set_disassem_content)
 822         (tui_get_begin_asm_address): Update.
 823         * tui/tui-data.h (struct tui_locator_element): Remove.
 824         (union tui_which_element) <locator>: Remove.
 825         (struct tui_locator_window): New.
 826         (tui_locator_win_info_ptr): Change return type.
 827         * tui/tui-data.c (_locator): Change type.
 828         (tui_locator_win_info_ptr): Change return type.
 829         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
 830         (tui_alloc_content): Add assert.
 831
 832 2019-06-25  Tom Tromey  <tom@tromey.com>
 833
 834         * tui/tui-winsource.c
 835         (tui_exec_info_window::maybe_allocate_content): New method.
 836         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
 837         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
 838         (make_source_or_disasm_window): Add cast.
 839         * tui/tui-data.h (union tui_which_element) <simple_string>:
 840         Remove.
 841         (struct tui_source_info): New.
 842         (struct tui_source_window_base) <execution_info>: Change type.
 843         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
 844         case, and add assert.
 845         (tui_alloc_content): Add assert.
 846
 847 2019-06-25  Tom Tromey  <tom@tromey.com>
 848
 849         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
 850         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
 851         * tui/tui-data.c (tui_alloc_win_info): Remove.
 852
 853 2019-06-25  Tom Tromey  <tom@tromey.com>
 854
 855         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
 856         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
 857         can_highlight.
 858
 859 2019-06-25  Tom Tromey  <tom@tromey.com>
 860
 861         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
 862         make_visible_with_new_height method.
 863         (tui_win_info::make_visible_with_new_height): New method.
 864         (tui_source_window_base::do_make_visible_with_new_height)
 865         (tui_data_window::do_make_visible_with_new_height)
 866         (tui_cmd_window::do_make_visible_with_new_height): New methods.
 867         (make_visible_with_new_height): Remove.
 868         (tui_resize_all, tui_adjust_win_heights): Use
 869         make_visible_with_new_height method.
 870         * tui/tui-data.h (struct tui_win_info)
 871         <do_make_visible_with_new_height, make_visible_with_new_height>:
 872         New methods.
 873         (struct tui_source_window_base, struct tui_data_window)
 874         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
 875         methods.
 876
 877 2019-06-25  Tom Tromey  <tom@tromey.com>
 878
 879         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
 880         method.
 881         (update_tab_width): Call update_tab_width method.
 882         * tui/tui-data.h (struct tui_win_info)
 883         (struct tui_source_window_base) <update_tab_width>: New methods.
 884
 885 2019-06-25  Tom Tromey  <tom@tromey.com>
 886
 887         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
 888         parameter.
 889         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
 890         parameter.
 891         (tui_gen_win_info::make_visible): Update.
 892         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
 893         parameter.
 894         * tui/tui-data.h (enum tui_box): New enum.
 895         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
 896
 897 2019-06-25  Tom Tromey  <tom@tromey.com>
 898
 899         * tui/tui-layout.c (make_source_or_disasm_window): Always use
 900         init_and_make_win for EXEC_INFO_WIN.
 901         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
 902         longer inline.
 903         (struct tui_win_info) <~tui_win_info>: Inline.
 904         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 905         Don't declare.
 906         * tui/tui-data.c (source_win, disasm_win): Remove globals.
 907         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 908         Remove.
 909         (tui_initialize_static_data): Update.
 910         (~tui_gen_win_info): Handle more cleanup here.
 911         (~tui_source_window_base): Delete "execution_info".
 912         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
 913
 914 2019-06-25  Tom Tromey  <tom@tromey.com>
 915
 916         * tui/tui-layout.c (make_command_window): Don't set
 917         can_highlight.
 918         (show_source_disasm_command): Call the reset method.
 919         (show_data): Don't set can_highlight.  Call the reset method.
 920         (tui_gen_win_info::reset): Rename from init_gen_win_info
 921         (init_and_make_win): Simplify.  Return tui_gen_win_info.
 922         (show_source_or_disasm_and_command): Call the reset method.
 923         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
 924         (struct tui_cmd_window): Set can_highlight.
 925
 926 2019-06-25  Tom Tromey  <tom@tromey.com>
 927
 928         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
 929         from make_visible.
 930         (tui_make_visible, tui_make_invisible): Rewrite.
 931         (tui_win_info::make_visible): Remove.
 932         (tui_source_window_base::make_visible): Update.
 933         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
 934         method.  Moved from...
 935         (struct tui_win_info) <make_visible>: ...here.
 936
 937 2019-06-25  Tom Tromey  <tom@tromey.com>
 938
 939         * tui/tui-winsource.c
 940         (tui_source_window_base::do_scroll_horizontal): Remove direction
 941         parameter.
 942         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
 943         direction parameter.
 944         * tui/tui-win.c (tui_win_info::forward_scroll)
 945         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 946         (tui_win_info::right_scroll): Update.
 947         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
 948         direction parameter.
 949         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
 950         direction parameter.
 951         * tui/tui-data.h (enum tui_scroll_direction): Remove.
 952         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
 953         Remove direction parameter.
 954         (struct tui_source_window_base, struct tui_source_window)
 955         (struct tui_disasm_window, struct tui_data_window)
 956         (struct tui_cmd_window): Update.
 957
 958 2019-06-25  Tom Tromey  <tom@tromey.com>
 959
 960         * tui/tui-winsource.h (tui_set_exec_info_content)
 961         (tui_show_exec_info_content, tui_erase_exec_info_content)
 962         (tui_clear_exec_info_content, tui_update_exec_info): Change
 963         argument to tui_source_window_base.
 964         * tui/tui-winsource.c (tui_set_exec_info_content)
 965         (tui_show_exec_info_content, tui_erase_exec_info_content)
 966         (tui_clear_exec_info_content, tui_update_exec_info): Change
 967         argument to tui_source_window_base.
 968
 969 2019-06-25  Tom Tromey  <tom@tromey.com>
 970
 971         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
 972         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
 973
 974 2019-06-25  Tom Tromey  <tom@tromey.com>
 975
 976         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
 977         check.
 978
 979 2019-06-25  Tom Tromey  <tom@tromey.com>
 980
 981         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
 982         type to void.
 983         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
 984         type to void.
 985         * tui/tui-source.c (tui_set_source_content): Update.
 986         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 987
 988 2019-06-25  Tom Tromey  <tom@tromey.com>
 989
 990         * tui/tui-win.c (window_name_completer, tui_set_focus)
 991         (tui_all_windows_info): Use name method.
 992         * tui/tui-data.h (struct tui_gen_win_info)
 993         (struct tui_source_window, struct tui_disasm_window)
 994         (struct tui_data_window, struct tui_cmd_window) <name>: New
 995         method.
 996         (tui_win_name): Don't declare.
 997         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
 998         (tui_win_name): Remove.
 999
1000 2019-06-25  Tom Tromey  <tom@tromey.com>
1001
1002         * tui/tui-winsource.h (tui_update_source_window)
1003         (tui_update_source_window_as_is): Change parameter type.
1004         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1005         to be a tui_source_window_base.
1006         (tui_update_source_window_as_is): Likewise.
1007         * tui/tui-win.c (make_visible_with_new_height): Update.
1008
1009 2019-06-25  Tom Tromey  <tom@tromey.com>
1010
1011         * tui/tui-winsource.c (tui_erase_source_content)
1012         (tui_show_source_content, tui_show_exec_info_content)
1013         (tui_erase_exec_info_content): Use refresh_window method.
1014         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1015         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1016         from tui_refresh_win.
1017         (tui_data_window::refresh_window): New method.
1018         (tui_win_info::refresh, tui_source_window_base::refresh)
1019         (tui_refresh_all): Use refresh_window method.
1020         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1021         method.
1022         * tui/tui-regs.c (tui_display_register): Call refresh_window
1023         method.
1024         * tui/tui-layout.c (show_source_disasm_command)
1025         (show_source_or_disasm_and_command): Call refresh_window method.
1026         * tui/tui-data.h (struct tui_gen_win_info)
1027         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1028         New method.
1029
1030 2019-06-25  Tom Tromey  <tom@tromey.com>
1031
1032         * tui/tui.c (tui_rl_other_window, tui_enable)
1033         (tui_is_window_visible, tui_get_command_dimension): Update.
1034         * tui/tui-winsource.c (tui_update_source_window_as_is)
1035         (tui_clear_source_content, tui_erase_source_content)
1036         (tui_show_source_line, tui_source_window_base::refill)
1037         (tui_source_window_base::do_scroll_horizontal)
1038         (tui_source_window_base::set_is_exec_point_at)
1039         (tui_update_breakpoint_info, tui_set_exec_info_content)
1040         (tui_alloc_source_buffer, tui_line_is_displayed)
1041         (tui_addr_is_displayed): Update.
1042         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1043         (tui_check_and_display_highlight_if_needed)
1044         (tui_win_info::make_visible, tui_win_info::refresh)
1045         (tui_refresh_all): Update.
1046         * tui/tui-windata.c (tui_first_data_item_displayed)
1047         (tui_delete_data_content_windows, tui_erase_data_content)
1048         (tui_display_all_data, tui_data_window::refresh_all)
1049         (tui_check_data_values): Update.
1050         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1051         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1052         (tui_win_info::backward_scroll, tui_refresh_all_win)
1053         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1054         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1055         (tui_source_window_base::set_new_height)
1056         (tui_data_window::set_new_height)
1057         (make_invisible_and_set_new_height)
1058         (make_visible_with_new_height, new_height_ok)
1059         (parse_scrolling_args): Update.
1060         * tui/tui-stack.c (tui_show_frame_info): Update.
1061         * tui/tui-source.c (tui_set_source_content)
1062         (tui_set_source_content_nil, tui_source_is_displayed)
1063         (tui_source_window::do_scroll_vertical): Update.
1064         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1065         (tui_display_registers_from, tui_display_reg_element_at_line)
1066         (tui_check_register_values, tui_reg_command): Update.
1067         * tui/tui-layout.c (tui_default_win_height)
1068         (show_source_disasm_command, show_data, init_and_make_win)
1069         (show_source_or_disasm_and_command): Update.
1070         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1071         (tui_redisplay_readline, tui_mld_flush)
1072         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1073         (tui_getc): Update.
1074         * tui/tui-disasm.c (tui_set_disassem_content)
1075         (tui_disasm_window::do_scroll_vertical): Update.
1076         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1077         Now virtual.
1078         (struct tui_win_info): Derive from tui_gen_win_info.
1079         <~tui_win_info>: Mark as override.
1080         <generic>: Remove member.
1081         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1082         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1083         (~tui_data_window, ~tui_win_info)
1084         (tui_free_all_source_wins_content): Update.
1085         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1086
1087 2019-06-25  Tom Tromey  <tom@tromey.com>
1088
1089         * tui/tui-layout.c (init_and_make_win): Use new.
1090         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1091         destructor, initializers.
1092         (tui_alloc_generic_win_info): Don't declare.
1093         * tui/tui-data.c (_locator): Add argument to constructor.
1094         (source_win, disasm_win): New globals.
1095         (exec_info): Remove.
1096         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1097         Update.
1098         (tui_alloc_generic_win_info): Remove.
1099         (init_content_element): Use new.
1100         (tui_win_info::tui_win_info): Update.
1101         (free_content_elements) <case DATA_WIN>: Use delete.
1102
1103 2019-06-25  Tom Tromey  <tom@tromey.com>
1104
1105         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1106         * tui/tui-windata.c (tui_first_data_item_displayed)
1107         (tui_delete_data_content_windows): Update.
1108         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1109         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1110         (tui_display_registers_from, tui_check_register_values): Update.
1111         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1112         pointer.
1113         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1114         window.
1115         (tui_free_data_content): Update.
1116         (free_content_elements) <case DATA_WIN>: Free the window.
1117
1118 2019-06-25  Tom Tromey  <tom@tromey.com>
1119
1120         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1121         Update.
1122         * tui/tui-layout.c (make_command_window)
1123         (show_source_disasm_command, show_data, init_and_make_win)
1124         (show_source_or_disasm_and_command): Update.
1125         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1126         method.
1127         <can_highight, is_highlighted>: Now bool.
1128         (tui_set_win_highlight): Don't declare.
1129         * tui/tui-data.c (tui_set_win_highlight): Remove.
1130
1131 2019-06-25  Tom Tromey  <tom@tromey.com>
1132
1133         * tui/tui-wingeneral.c (make_visible): Remove check of window
1134         type.
1135
1136 2019-06-25  Tom Tromey  <tom@tromey.com>
1137
1138         * tui/tui-win.c (tui_win_info::max_height)
1139         (tui_cmd_window::max_height): New methods.
1140         (new_height_ok): Call max_height.
1141         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1142         <max_height>: New method.
1143
1144 2019-06-25  Tom Tromey  <tom@tromey.com>
1145
1146         * tui/tui-win.c (tui_source_window_base::set_new_height)
1147         (tui_data_window::set_new_height): New methods.
1148         (make_invisible_and_set_new_height): Call set_new_height method.
1149         * tui/tui-data.h (struct tui_win_info)
1150         (struct tui_source_window_base, struct tui_data_window)
1151         <set_new_height>: New method.
1152
1153 2019-06-25  Tom Tromey  <tom@tromey.com>
1154
1155         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1156         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1157         tui_refresh_data_win.
1158         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1159         method.
1160         (tui_refresh_all_win): Call the refresh_all method.
1161         (tui_set_focus): Likewise.
1162         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1163         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1164         Likewise.
1165
1166 2019-06-25  Tom Tromey  <tom@tromey.com>
1167
1168         * tui/tui-winsource.h (tui_refill_source_window)
1169         (tui_set_is_exec_point_at): Don't declare.
1170         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1171         (tui_source_window_base::refill): Rename from
1172         tui_refill_source_window.
1173         (tui_source_window_base::do_scroll_horizontal): Update.
1174         (tui_source_window_base::set_is_exec_point_at): Rename from
1175         tui_set_is_exec_point_at.
1176         (tui_update_all_breakpoint_info): Update.
1177         * tui/tui-stack.c (tui_show_frame_info): Update.
1178         * tui/tui-layout.c (show_data): Add cast.
1179         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1180         * tui/tui-data.h (struct tui_source_window_base) <refill,
1181         set_is_exec_point_at>: New methods.
1182         (tui_source_windows, tui_add_to_source_windows): Update types.
1183         (tui_add_to_source_windows): Remove redundant declaration.
1184         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1185         (tui_source_windows): Change return type.
1186         (tui_clear_source_windows_detail): Update.
1187         (tui_add_to_source_windows): Change type of parameter.
1188         (tui_free_all_source_wins_content): Update.
1189
1190 2019-06-25  Tom Tromey  <tom@tromey.com>
1191
1192         * tui/tui-wingeneral.c (tui_win_info::refresh)
1193         (tui_source_window_base::refresh): New methods.
1194         (tui_refresh_all): Call the refresh method.
1195         * tui/tui-data.h (struct tui_win_info)
1196         (struct tui_source_window_base) <refresh>: New method.
1197
1198 2019-06-25  Tom Tromey  <tom@tromey.com>
1199
1200         * tui/tui.h (tui_is_window_visible): Return bool.
1201         * tui/tui.c (tui_is_window_visible): Return bool.
1202         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1203         (tui_make_visible, tui_make_invisible)
1204         (tui_win_info::make_visible)
1205         (tui_source_window_base::make_visible, make_all_visible)
1206         (tui_make_all_visible, tui_make_all_invisible): Update.
1207         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1208         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1209         bool.
1210         (struct tui_win_info, struct tui_source_window_base)
1211         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1212         * tui/tui-data.c (tui_init_generic_part): Update.
1213
1214 2019-06-25  Tom Tromey  <tom@tromey.com>
1215
1216         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1217         (tui_source_window_base::make_visible): New methods.
1218         (make_all_visible): Make method call.
1219         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1220         (struct tui_source_window_base, struct tui_cmd_window): Override
1221         make_visible.
1222         (tui_win_is_source_type): Don't declare.
1223         * tui/tui-data.c (tui_win_is_source_type): Remove.
1224
1225 2019-06-25  Tom Tromey  <tom@tromey.com>
1226
1227         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1228         NULL check.
1229
1230 2019-06-25  Tom Tromey  <tom@tromey.com>
1231
1232         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1233         Inline constructor.  Add initializers for members.
1234         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1235         constructors; now inline in class.
1236
1237 2019-06-25  Tom Tromey  <tom@tromey.com>
1238
1239         * tui/tui-regs.c (tui_show_registers): Update.
1240         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1241         bool.
1242         * tui/tui-data.c (tui_data_window::clear_detail)
1243         (tui_data_window): Update.
1244
1245 2019-06-25  Tom Tromey  <tom@tromey.com>
1246
1247         * tui/tui-windata.c (tui_display_all_data)
1248         (tui_display_data_from_line, tui_display_data_from)
1249         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1250         Update.
1251         * tui/tui-regs.c (tui_last_regs_line_no)
1252         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1253         (tui_show_registers, tui_show_register_group)
1254         (tui_display_registers_from, tui_display_reg_element_at_line)
1255         (tui_display_registers_from_line, tui_check_register_values)
1256         (tui_reg_next, tui_reg_prev): Update.
1257         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1258         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1259         tui_data_window.
1260         (struct tui_win_info) <detail>: Remove.  Add new fields from
1261         tui_data_info.
1262         (TUI_DATA_WIN): Add cast.
1263         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1264         (~tui_data_window): Simplify.
1265
1266 2019-06-25  Tom Tromey  <tom@tromey.com>
1267
1268         * tui/tui-layout.c (show_source_disasm_command)
1269         (show_source_or_disasm_and_command): Update.
1270         * tui/tui-io.c (update_cmdwin_start_line)
1271         (tui_redisplay_readline): Update.
1272         * tui/tui-data.h (struct tui_command_info): Remove.
1273         (struct tui_win_info) <detail>: Remove command_info member.
1274         (struct tui_data_window) <start_line>: New member, from
1275         tui_command_info.
1276         (TUI_CMD_WIN): Add casts.
1277
1278 2019-06-25  Tom Tromey  <tom@tromey.com>
1279
1280         * tui/tui-winsource.c (tui_update_source_window)
1281         (tui_refill_source_window)
1282         (tui_source_window_base::do_scroll_horizontal)
1283         (tui_update_breakpoint_info, tui_set_exec_info_content)
1284         (tui_show_exec_info_content, tui_erase_exec_info_content)
1285         (tui_clear_exec_info_content): Update.
1286         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1287         Update.
1288         * tui/tui-win.c (make_invisible_and_set_new_height)
1289         (make_visible_with_new_height): Update.
1290         * tui/tui-source.c (tui_set_source_content)
1291         (tui_show_symtab_source): Update.
1292         * tui/tui-layout.c (extract_display_start_addr)
1293         (show_source_disasm_command, show_data)
1294         (make_source_or_disasm_window)
1295         (show_source_or_disasm_and_command): Update.
1296         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1297         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1298         "gdbarch".
1299         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1300         to tui_source_window_base.
1301         (struct tui_win_info) <detail>: Remove source_info member.
1302         (struct tui_source_window_base) <has_locator>: Inline.
1303         Move contents from tui_source_info; rename has_locator member to
1304         m_has_locator.
1305         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1306         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1307         header file.
1308         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1309         Simplify.
1310         (tui_free_all_source_wins_content): Cast to
1311         tui_source_window_base.
1312
1313 2019-06-25  Tom Tromey  <tom@tromey.com>
1314
1315         * tui/tui-win.c (make_invisible_and_set_new_height)
1316         (make_visible_with_new_height): Call has_locator method.
1317         * tui/tui-layout.c (show_source_disasm_command, show_data)
1318         (show_source_or_disasm_and_command): Update for bool change.
1319         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1320         (tui_win_info) <has_locator>: New method.
1321         (struct tui_source_window_base) <has_locator>: New method.
1322         (tui_win_has_locator): Don't declare.
1323         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1324         from tui_win_has_locator.
1325         (tui_source_window_base): Use false, not FALSE.
1326
1327 2019-06-25  Tom Tromey  <tom@tromey.com>
1328
1329         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1330         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1331         clear_detail method directly.
1332         (tui_clear_win_detail): Remove.
1333
1334 2019-06-25  Tom Tromey  <tom@tromey.com>
1335
1336         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1337         "this", not TUI_DISASM_WIN.
1338
1339 2019-06-25  Tom Tromey  <tom@tromey.com>
1340
1341         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1342         declare.
1343         * tui/tui-winsource.c
1344         (tui_source_window_base::do_scroll_horizontal): Rename from
1345         tui_horizontal_source_scroll.
1346         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1347         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1348         from tui_vertical_data_scroll.
1349         * tui/tui-win.h (tui_scroll): Don't declare.
1350         * tui/tui-win.c (tui_win_info::forward_scroll)
1351         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1352         (tui_win_info::right_scroll): Rename and update.
1353         (tui_scroll_forward_command, tui_scroll_backward_command)
1354         (tui_scroll_left_command, tui_scroll_right_command): Update.
1355         (tui_scroll): Remove.
1356         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1357         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1358         from tui_vertical_source_scroll.
1359         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1360         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1361         from tui_vertical_disassem_scroll.
1362         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1363         do_scroll_horizontal>: New methods.
1364         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1365         Likewise.
1366         (struct tui_source_window_base): Add do_scroll_horizontal.
1367         (struct tui_source_window, struct tui_disasm_window): Add
1368         do_scroll_vertical.
1369         (struct tui_data_window, struct tui_cmd_window): Add
1370         do_scroll_horizontal and do_scroll_vertical.
1371         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1372
1373 2019-06-25  Tom Tromey  <tom@tromey.com>
1374
1375         * tui/tui-data.h (struct tui_source_window_base): New struct.
1376         (struct tui_source_window): Derive from tui_source_window_base.
1377         (struct tui_disasm_window): New struct.
1378         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1379         from tui_source_window::clear_detail.
1380         (tui_source_window_base): Rename from tui_source_window.
1381         (~tui_source_window_base): Rename from ~tui_source_window.
1382         (tui_alloc_win_info): Create a tui_disasm_window.
1383
1384 2019-06-25  Tom Tromey  <tom@tromey.com>
1385
1386         * tui/tui-data.h (struct tui_source_window)
1387         (struct tui_data_window): Declare destructors.
1388         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1389         destructors.
1390         (tui_win_info): Simplify.
1391
1392 2019-06-25  Tom Tromey  <tom@tromey.com>
1393
1394         * tui/tui-winsource.c (tui_display_main)
1395         (tui_update_source_windows_with_addr)
1396         (tui_update_all_breakpoint_info): Update.
1397         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1398         (new_height_ok, parse_scrolling_args): Update.
1399         * tui/tui-stack.c (tui_show_frame_info): Update.
1400         * tui/tui-data.h (struct tui_list): Remove.
1401         (tui_source_windows): Return a reference to a std::vector.
1402         * tui/tui-data.c (source_windows): Now a std::vector.
1403         (tui_source_windows): Change return type.
1404         (tui_clear_source_windows): Rewrite.
1405         (tui_clear_source_windows_detail, tui_add_to_source_windows)
1406         (tui_free_all_source_wins_content): Rewrite.
1407
1408 2019-06-25  Tom Tromey  <tom@tromey.com>
1409
1410         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
1411         (struct tui_data_window, struct tui_cmd_window): Declare
1412         clear_detail method.
1413         * tui/tui-data.c (tui_source_window::clear_detail)
1414         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
1415         methods.
1416         (tui_clear_win_detail): Simplify.
1417
1418 2019-06-25  Tom Tromey  <tom@tromey.com>
1419
1420         * tui/tui-layout.c (make_source_window, make_disasm_window)
1421         (make_source_or_disasm_window): Remove win_info_ptr parameter.
1422         Return the new window.
1423         (show_source_disasm_command, show_data)
1424         (show_source_or_disasm_and_command): Update.
1425
1426 2019-06-25  Tom Tromey  <tom@tromey.com>
1427
1428         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
1429         parameter.  Return the new window.
1430         (show_source_disasm_command): Update and remove NULL check.
1431         (show_source_or_disasm_and_command): Update.
1432
1433 2019-06-25  Tom Tromey  <tom@tromey.com>
1434
1435         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
1436
1437 2019-06-25  Tom Tromey  <tom@tromey.com>
1438
1439         * tui/tui-data.h (struct tui_win_info): Make constructor
1440         protected.  Make destructor virtual.  Add initializers.
1441         (tui_source_window, tui_data_window, tui_cmd_window): New
1442         classes.
1443         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
1444         constructor.  Add "type" parameter.
1445         (tui_source_window, tui_data_window, tui_cmd_window): New
1446         constructors.
1447         (tui_alloc_win_info): Instantiate the appropriate subclass.
1448
1449 2019-06-25  Tom Tromey  <tom@tromey.com>
1450
1451         * tui/tui-win.c (tui_resize_all): Use delete.
1452         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
1453         destructor.
1454         (tui_free_window): Don't declare.
1455         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
1456         Update.
1457
1458 2019-06-25  Tom Tromey  <tom@tromey.com>
1459
1460         * tui/tui-data.h (struct tui_win_info): Add constructor.
1461         * tui/tui-data.c (tui_alloc_win_info): Use new.
1462         (tui_free_window): Use delete.
1463
1464 2019-06-22  Tom Tromey  <tom@tromey.com>
1465
1466         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
1467         declare.
1468         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
1469
1470 2019-06-22  Tom Tromey  <tom@tromey.com>
1471
1472         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
1473         declare.
1474         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
1475
1476 2019-06-22  Tom de Vries  <tdevries@suse.de>
1477
1478         * dwarf2read.c (create_addrmap_from_aranges)
1479         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
1480         instead of '%zu'.
1481
1482 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
1483
1484         * dwarf2read.h (dwarf2_section_info_def): Remove.
1485         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
1486         * dwarf2read.c (struct dwo_sections) <types>: Change type to
1487         std::vector<dwarf2_section_info>.
1488         (struct dwo_file) <~dwo_file>: Remove.
1489         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
1490         types field.
1491         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
1492         (dwarf2_read_debug_names): Likewise.
1493         (create_debug_types_hash_table): Change parameter type to
1494         array_view, adjust code accordingly.
1495         (dwarf2_locate_dwo_sections): Adjust to std::vector.
1496         (partial_die_info::fixup): Likewise.
1497         (determine_prefix): Likewise.
1498         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
1499
1500 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1501
1502         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
1503         gdb_bfd_ref_ptr.
1504         <~dwo_file>: Remove call to gdb_bfd_unref.
1505         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
1506         gdb_bfd_ref_ptr::get.
1507
1508 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1509
1510         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
1511         type to htab_up.
1512         * dwarf2read.c (struct dwo_file): Initialize fields.
1513         <~dwo_file>: New.
1514         (free_dwo_file): Remove, move content to ~dwo_file.
1515         (struct dwo_file_deleter): Remove.
1516         (dwo_file_up>: Remove custom deleter.
1517         (free_dwo_files): Remove.
1518         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
1519         dwo_files.
1520         (process_skeletonless_type_units): Call unique_ptr::get.
1521         (allocate_dwo_file_hash_table): Add deleter to created hash
1522         table.  Change return type to htab_up.
1523         (lookup_dwo_file_slot): Don't memset dwo_file, call
1524         unique_ptr::get.
1525         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
1526         (create_dwo_unit_in_dwp_v2): Likewise.
1527         (open_and_init_dwo_file): Likewise.
1528         (free_dwo_file_from_slot): Remove.
1529
1530 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1531
1532         * dwarf2read.h (struct dwarf2_section_info) <readin,
1533         is_virtual>: Change type to bool.
1534         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
1535         true instead of 1.
1536
1537 2019-06-19  Tom Tromey  <tom@tromey.com>
1538
1539         * tui/tui-data.h (tui_init_content_element): Don't declare.
1540
1541 2019-06-19  Tom Tromey  <tom@tromey.com>
1542
1543         * tui/tui-data.h (tui_init_win_info): Don't declare.
1544
1545 2019-06-19  Tom de Vries  <tdevries@suse.de>
1546
1547         * dwarf2read.h (abstract_to_concrete): Change type to
1548         std::unordered_map<sect_offset, std::vector<sect_offset>,
1549         gdb::hash_enum<sect_offset>>.
1550
1551 2019-06-19  Tom Tromey  <tromey@adacore.com>
1552
1553         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
1554         EVAL_AVOID_SIDE_EFFECTS specially.
1555
1556 2019-06-19  Tom Tromey  <tromey@adacore.com>
1557
1558         * source-cache.c (highlighter): New global.
1559         (source_cache::get_source_lines): Create a highlighter on demand.
1560
1561 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1562
1563         * defs.h (deprecated_interactive_hook): Delete declaration.
1564         * interps.c (clear_interpreter_hooks): Remove use of
1565         deprecated_interactive_hook.
1566         * top.c (deprecated_interactive_hook): Delete definition.
1567         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
1568
1569 2019-06-18  Tom de Vries  <tdevries@suse.de>
1570
1571         PR gdb/24515
1572         * dwarf2read.h (abstract_to_concrete): Change type from
1573         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
1574         std::unordered_map<sect_offset, std::vector<sect_offset>>.
1575         * dwarf2read.c (read_variable): Update.
1576         (dwarf2_fetch_die_loc_sect_off): Update.
1577
1578 2019-06-17  Tom de Vries  <tdevries@suse.de>
1579
1580         PR gdb/24617
1581         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
1582         accessing parent[parent_len - 1].
1583
1584 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
1585
1586         PR gdb/24364
1587         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
1588         call dtrace_process_dof with NULL dof.
1589
1590 2019-06-16  Tom de Vries  <tdevries@suse.de>
1591
1592         PR gdb/24445
1593         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
1594
1595 2019-06-16  Tom Tromey  <tom@tromey.com>
1596
1597         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1598         (make_all_visible): Use address of member.
1599
1600 2019-06-16  Tom Tromey  <tom@tromey.com>
1601
1602         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
1603         (tui_free_window, free_content, free_content_elements): Remove
1604         unnecessary cast.
1605         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
1606         cast.
1607         * tui/tui-regs.c (tui_show_register_group)
1608         (tui_display_registers_from, tui_display_reg_element_at_line):
1609         Remove unnecessary cast.
1610
1611 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
1612
1613         * linux-nat.c (normal_mask): Delete.
1614         (_initialize_linux_nat): Don't initialise normal_mask.
1615
1616 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
1617
1618         PR gdb/24445
1619         * dwarf-index-write.h (write_psymtabs_to_index): Add
1620         dwz_basename parameter.
1621         * dwarf-index-write.c (write_gdbindex): Move file writing to
1622         write_gdbindex_1.  Change return type void.
1623         (assert_file_size): Move up, remove filename parameter.
1624         (write_gdbindex_1): New function.
1625         (write_debug_names): Change return type to void, call
1626         assert_file_size.
1627         (struct index_wip_file): New struct.
1628         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
1629         file logic to index_wip_file.  Write index for dwz file if
1630         needed.
1631         (save_gdb_index_command): Pass basename of dwz file, if present.
1632         * dwarf-index-cache.c (index_cache::store): Obtain and pass
1633         build-id of dwz file, if present.
1634         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1635         (dwarf2_get_dwz_file): Likewise.
1636         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1637         (dwarf2_get_dwz_file): Likewise.
1638
1639 2019-06-16  Tom Tromey  <tom@tromey.com>
1640
1641         * coffread.c (process_coff_symbol): Use xstrdup.
1642         * value.c (create_internalvar): Use xstrdup.
1643
1644 2019-06-16  Tom Tromey  <tom@tromey.com>
1645
1646         * valops.c (value_cast, value_slice): Remove unnecessary cast.
1647         * breakpoint.c (stopin_command, stopat_command)
1648         (until_break_command, decode_location_default): Remove unnecessary
1649         cast.
1650         * utils.c (subset_compare): Remove unnecessary cast.
1651         * ada-lang.c (ada_update_initial_language): Remove unnecessary
1652         cast.
1653         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1654         cast.
1655         * infcmd.c (path_command): Remove unnecessary cast.
1656         * coffread.c (decode_type): Remove unnecessary cast.
1657         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1658         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1659         * tui/tui-stack.c (tui_show_locator_content)
1660         (tui_show_frame_info): Remove unnecessary cast.
1661         * tui/tui-win.c (tui_scroll_forward_command)
1662         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1663         (parse_scrolling_args): Remove unnecessary cast.
1664         * tui/tui-data.c (init_win_info, tui_del_window)
1665         (tui_free_window, tui_del_data_windows, tui_free_data_content)
1666         (free_content_elements): Remove unnecessary cast.
1667         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1668         unnecessary cast.
1669         * tui/tui-source.c (tui_set_source_content)
1670         (tui_vertical_source_scroll): Remove unnecessary cast.
1671         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1672         cast.
1673         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1674         * tui/tui-regs.c (tui_display_registers_from)
1675         (tui_display_register): Remove unnecessary cast.
1676         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1677         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1678         (make_visible): Remove unnecessary cast.
1679         * tui/tui-winsource.c (tui_erase_source_content)
1680         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1681         unnecessary cast.
1682         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1683         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1684         * stabsread.c (read_type, read_array_type, read_range_type):
1685         Remove unnecessary cast.
1686         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1687         (parse_symbol, parse_type, upgrade_type, parse_external)
1688         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
1689         unnecessary cast.
1690         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
1691
1692 2019-06-16  Tom Tromey  <tom@tromey.com>
1693
1694         * tui/tui-data.c (tui_alloc_generic_win_info)
1695         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
1696         checks.
1697
1698 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
1699             Andrew Burgess  <andrew.burgess@embecosm.com>
1700
1701         * f-typeprint.c (f_print_type): Don't return early for not
1702         associated or not allocated types.
1703         (f_type_print_varspec_suffix): Add print_rank parameter and print
1704         ranks of array types in case they dangling.
1705         (f_type_print_base): Add print_rank parameter.
1706
1707 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1708
1709         * NEWS: Mention new MI commands.
1710         * break-catch-throw.c (enum exception_event_kind): Move to
1711         breakpoint.h.
1712         (print_mention_exception_catchpoint): Output text as a single
1713         message.
1714         (catch_exception_command_1): Rename to...
1715         (catch_exception_event): ...this, make non-static, update header
1716         command, and change some parameter types.
1717         (catch_catch_command): Update for changes to
1718         catch_exception_command_1.
1719         (catch_throw_command): Likewise.
1720         (catch_rethrow_command): Likewise.
1721         * breakpoint.c (enum exception_event_kind): Delete.
1722         * breakpoint.h (enum exception_event_kind): Moved here from
1723         break-catch-throw.c.
1724         (catch_exception_event): Declare.
1725         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
1726         (mi_cmd_catch_throw): New function.
1727         (mi_cmd_catch_rethrow): New function.
1728         (mi_cmd_catch_catch): New function.
1729         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
1730         'catch-catch' entries.
1731         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
1732         (mi_cmd_catch_rethrow): Declare.
1733         (mi_cmd_catch_catch): Declare.
1734
1735 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1736
1737         * annotate.c (annotate_source_line): Change return type to void,
1738         update implementation to match.
1739         * annotate.h (annotate_source_line): Change return type to void,
1740         update header comment.
1741         * stack.c (print_frame_info): Don't change what frame information
1742         is printed based on whether annotations are on or not.
1743
1744 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1745
1746         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
1747         (annotate_source): Make static.
1748         (annotate_source_line): Moved from source.c and renamed from
1749         identify_source_line.  Update the return type.
1750         * annotate.h (annotate_source): Delete declaration.
1751         (annotate_source_line): Declaration moved from source.h, and
1752         renamed from identify_source_line.  Return type updated.
1753         * source.c (identify_source_line): Moved to annotate.c and renamed
1754         to annotate_source_line.
1755         (info_line_command): Remove check of annotation_level.
1756         * source.h (identify_source_line): Move declaration to annotate.h
1757         and rename to annotate_source_line.
1758         * stack.c: Add 'annotate.h' include.
1759         (print_frame_info): Remove check of annotation_level before
1760         calling annotate_source_line.
1761
1762 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1763
1764         * source-cache.c (source_cache::get_plain_source_lines): Use
1765         open_source_file_with_line_charpos instead of just
1766         open_source_file, remove call to find_source_lines.
1767         (source_cache::get_source_lines): Likewise.
1768         * source.c (find_source_lines): Make static.
1769         (get_filename_and_charpos): Renamed into...
1770         (open_source_file_with_line_charpos): ..this along with changes to
1771         return a scoped_fd, and some other minor clean ups.
1772         (identify_source_line): Use open_source_file_with_line_charpos.
1773         (search_command_helper): Use open_source_file_with_line_charpos
1774         instead of just open_source_file, remove call to
1775         find_source_lines.
1776         * source.h (open_source_file_with_line_charpos): Declare new
1777         function.
1778         (find_source_lines): Delete declaration.
1779
1780 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1781
1782         * source.c (get_filename_and_charpos): Remove fullname
1783         parameter.
1784         (identify_source_line): Update call to get_filename_and_charpos.
1785
1786 2019-06-14  Tom Tromey  <tromey@adacore.com>
1787
1788         PR gdb/24502:
1789         * ui-style.h (skip_ansi_escape): Update comment.
1790         * ui-file.h (class no_terminal_escape_file): New class.
1791         * ui-file.c (no_terminal_escape_file::write)
1792         (no_terminal_escape_file::puts): New methods.
1793         * cli/cli-logging.c (handle_redirections): Use
1794         no_terminal_escape_file.
1795
1796 2019-06-14  Tom Tromey  <tromey@adacore.com>
1797
1798         * NEWS: Move convenience variable news above Python news.
1799
1800 2019-06-14  Tom Tromey  <tom@tromey.com>
1801
1802         * gnulib: Move directory to top-level.
1803         * configure.ac: Don't configure gnulib.
1804         * configure: Rebuild.
1805         * common/common-defs.h: Use new path to gnulib.
1806         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
1807         (GNULIB_H): Remove.
1808         (INCGNU): Look in new gnulib location.
1809         (HFILES_NO_SRCDIR): Remove gnulib files.
1810         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
1811         (generated_files): Remove GNULIB_H.
1812         ($(LIBGNU), all-lib): Remove targets.
1813         (distclean): Don't mention GNULIB_BUILDDIR.
1814         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
1815
1816 2019-06-14  Tom Tromey  <tromey@adacore.com>
1817
1818         * symfile.c (add_symbol_file_command): Remove obsolete comment.
1819         Warn if symbol file does not provide any symbols.
1820
1821 2019-06-14  Tom Tromey  <tromey@adacore.com>
1822
1823         * source.c (find_and_open_source): Respect basenames_may_differ.
1824
1825 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
1826
1827         * annotate.c (annotate_breakpoints_invalid): Make use of
1828         scoped_restore_terminal_state.
1829         (annotate_frames_invalid): Likewise.
1830
1831 2019-06-14  Tom Tromey  <tromey@adacore.com>
1832
1833         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
1834         allow assignment to an internalvar.
1835
1836 2019-06-14  Tom Tromey  <tromey@adacore.com>
1837
1838         * ada-lex.l: Allow "_" in attribute names.
1839
1840 2019-06-14  Tom Tromey  <tromey@adacore.com>
1841
1842         PR gdb/24653:
1843         * regcache.c (registers_changed): Don't call alloca.
1844         * top.c (execute_command): Don't call alloca.
1845
1846 2019-06-13  Pedro Alves  <palves@redhat.com>
1847
1848         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
1849         'expression'.  When parsing an expression, error out if there's
1850         junk after "unlimited".
1851         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1852         (do_set_command): Adjust calls to is_unlimited_literal.
1853
1854 2019-06-13  Pedro Alves  <palves@redhat.com>
1855
1856         * compile/compile.c (make_compile_options_def_group): Add braces
1857         around array_view initializer.
1858         * thread.c (make_thread_apply_all_options_def_group)
1859         (make_thread_apply_all_options_def_group): Likewise.
1860
1861 2019-06-13  Pedro Alves  <palves@redhat.com>
1862
1863         * NEWS (New commands): Mention "maint test-options
1864         require-delimiter", "maint test-options unknown-is-error", "maint
1865         test-options unknown-is-operand" and "maint show
1866         test-options-completion-result".
1867         (New command options, command completion): New section.
1868         (Completion improvements): New section.
1869         Mention that you can abbreviate "unlimited".
1870
1871 2019-06-13  Pedro Alves  <palves@redhat.com>
1872
1873         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
1874         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
1875         * unittests/cli-utils-selftests.c (test_parse_flags)
1876         (test_parse_flags_qcs): Delete.
1877         (test_cli_utils): Don't call deleted functions.
1878
1879 2019-06-13  Pedro Alves  <palves@redhat.com>
1880
1881         * thread.c: Include "cli/cli-option.h".
1882         (tp_array_compar_ascending): Global.
1883         (tp_array_compar): Delete function.
1884         (tp_array_compar_ascending, tp_array_compar_descending): New
1885         functions.
1886         (ascending_option_def, qcs_flag_option_def)
1887         (thr_qcs_flags_option_defs)
1888         (make_thread_apply_all_options_def_group)
1889         (make_thread_apply_options_def_group): New.
1890         (thread_apply_all_command): Use gdb::option::process_options.
1891         (thread_apply_command_completer)
1892         (thread_apply_all_command_completer): New.
1893         (thread_apply_command): Use gdb::option::process_options.
1894         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
1895         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
1896         to generate help text of "thread apply".  Adjust "taas"'s help.
1897         * tid-parse.c (tid_range_parser::in_thread_range): New method.
1898         * tid-parse.h (tid_range_parser::in_thread_range): New method.
1899
1900 2019-06-13  Pedro Alves  <palves@redhat.com>
1901
1902         * thread.c (thread_apply_command): Check for invalid TID with
1903         isdigit instead of !isalpha.
1904
1905 2019-06-13  Pedro Alves  <palves@redhat.com>
1906
1907         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
1908         (validate_flags_qcs): New.
1909         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
1910         (validate_flags_qcs): Declare.
1911         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
1912         (make_frame_apply_options_def_group): New.
1913         (frame_apply_command_count): Process options with
1914         gdb::option::process_options.
1915         (frame_apply_completer): New.
1916         (frame_apply_level_completer, frame_apply_all_completer)
1917         (frame_apply_completer): New.
1918         (_initialize_stack): Update help of "frame apply", "frame apply
1919         level", "frame apply all" and "faas" to mention supported options
1920         and install command completers.
1921         * stack.h (frame_apply_all_completer): Declare.
1922         * thread.c: Include "stack.h".
1923         (tfaas_command): Add "--".
1924         (_initialize_thread): Update help "tfaas" to mention supported
1925         options and install command completer.
1926
1927 2019-06-13  Pedro Alves  <palves@redhat.com>
1928
1929         * completer.c (complete_nested_command_line): New.
1930         (gdb_completion_word_break_characters_throw): Add assertion.
1931         * completer.h (complete_nested_command_line): Declare.
1932
1933 2019-06-13  Pedro Alves  <palves@redhat.com>
1934
1935         * stack.c (parse_backtrace_qualifiers): New.
1936         (backtrace_command): Use it.
1937         (backtrace_command_completer): Complete on qualifiers.
1938
1939 2019-06-13  Pedro Alves  <palves@redhat.com>
1940
1941         * frame.c: Include "cli/cli-option.h.
1942         (user_set_backtrace_options): New.
1943         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
1944         Delete.
1945         (get_prev_frame): Adjust.
1946         (boolean_option_def, uinteger_option_def)
1947         (set_backtrace_option_defs): New.
1948         (_initialize_frame): Adjust and use
1949         gdb::option::add_setshow_cmds_for_options to install "set
1950         backtrace past-main" and "set backtrace past-entry".
1951         * frame.h: Include "cli/cli-option.h".
1952         (struct frame_print_options): Forward declare.
1953         (print_frame_arguments_all, print_frame_arguments_scalars)
1954         (print_frame_arguments_none): Declare.
1955         (print_entry_values): Delete declaration.
1956         (struct frame_print_options, user_frame_print_options): New.
1957         (struct set_backtrace_options): New.
1958         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
1959         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
1960         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
1961         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
1962         (list_args_or_locals): Add frame_print_options parameter.
1963         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1964         * python/py-framefilter.c (enumerate_args): Pass down
1965         USER_FRAME_PRINT_OPTIONS.
1966         * stack.c: Include "cli/cli-option.h".
1967         (print_frame_arguments_all, print_frame_arguments_scalars)
1968         (print_frame_arguments_none): Declare.
1969         (print_raw_frame_arguments, print_entry_values): Delete.
1970         (user_frame_print_options): New.
1971         (boolean_option_def, enum_option_def, frame_print_option_defs):
1972         New.
1973         (struct backtrace_cmd_options): New.
1974         (bt_flag_option_def): New.
1975         (backtrace_command_option_defs): New.
1976         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1977         (print_frame_arg, read_frame_arg, print_frame_args)
1978         (print_frame_info, print_frame): Add frame_print_options parameter
1979         and use it.
1980         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
1981         (backtrace_command_1): Add frame_print_options and
1982         backtrace_cmd_options parameters and use them.
1983         (make_backtrace_options_def_group): New.
1984         (backtrace_command): Process command options with
1985         gdb::option::process_options.
1986         (backtrace_command_completer): New.
1987         (_initialize_stack): Extend "backtrace"'s help to mention
1988         supported options.  Install completer for "backtrace".
1989         Install some settings commands with add_setshow_cmds_for_options.
1990
1991 2019-06-13  Pedro Alves  <palves@redhat.com>
1992
1993         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
1994         and that "set/show print raw frame-arguments" are now deprecated.
1995
1996         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
1997         command.
1998         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
1999         * stack.c (_initialize_stack): Install "set/show print
2000         raw-frame-arguments", and deprecate "set/show print raw
2001         frame-arguments".
2002         * valprint.c (_initialize_valprint): Deprecate "set/show print
2003         raw".
2004
2005 2019-06-13  Pedro Alves  <palves@redhat.com>
2006
2007         * compile/compile.c (struct compile_options): New.
2008         (compile_flag_option_def, compile_command_option_defs)
2009         (make_compile_options_def_group): New.
2010         (compile_file_command): Handle options with
2011         gdb::option::process_options.
2012         (compile_file_command_completer): New function.
2013         (compile_code_command): Handle options with
2014         gdb::option::process_options.
2015         (compile_code_command_completer): New function.
2016         (_initialize_compiler): Install completers for "compile code" and
2017         "compile file".  Mention available options in "compile code" and
2018         "compile code"'s help.
2019         * completer.c (advance_to_completion_word): New, factored out from
2020         ...
2021         (advance_to_expression_complete_word_point): ... this.
2022         (advance_to_filename_complete_word_point): New.
2023         * completer.h (advance_to_filename_complete_word_point): New
2024         declaration.
2025
2026 2019-06-13  Pedro Alves  <palves@redhat.com>
2027
2028         * compile/compile.c: Include "cli/cli-option.h".
2029         (compile_print_value): Scope data pointer is now a
2030         value_print_options pointer; adjust.
2031         (compile_print_command): Process options.  Scope data pointer is
2032         now a value_print_options pointer; adjust.
2033         (_initialize_compile): Update "compile print"'s help to include
2034         supported options.  Install a completer for "compile print".
2035         * cp-valprint.c (show_vtblprint, show_objectprint)
2036         (show_static_field_print): Delete.
2037         (_initialize_cp_valprint): Don't install "set print
2038         static-members", "set print vtbl", "set print object" here.
2039         * printcmd.c: Include "cli/cli-option.h" and
2040         "common/gdb_optional.h".
2041         (print_command_parse_format): Rework to fill in a
2042         value_print_options instead of a format_data.
2043         (print_value): Change parameter type from format_data pointer to
2044         value_print_options reference.  Adjust.
2045         (print_command_1): Process options.  Adjust to pass down a
2046         value_print_options.
2047         (print_command_completer): New.
2048         (_initialize_printcmd): Install print_command_completer as
2049         handle_brkchars completer for the "print" command.  Update
2050         "print"'s help to include supported options.
2051         * valprint.c: Include "cli/cli-option.h".
2052         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2053         here from cp-valprint.c.
2054         (boolean_option_def, uinteger_option_def)
2055         (value_print_option_defs, make_value_print_options_def_group):
2056         New.  Use gdb::option::add_setshow_cmds_for_options to install
2057         "set print elements", "set print null-stop", "set print repeats",
2058         "set print pretty", "set print union", "set print array", "set
2059         print address", "set print symbol", "set print array-indexes".
2060         * valprint.h: Include <string> and "cli/cli-option.h".
2061         (make_value_print_options_def_group): Declare.
2062         (print_value): Change parameter type from format_data pointer to
2063         value_print_options reference.
2064         (print_command_completer): Declare.
2065
2066 2019-06-13  Pedro Alves  <palves@redhat.com>
2067
2068         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2069         (COMMON_SFILES): Add maint-test-settings.c.
2070         * cli/cli-decode.c (boolean_enums): New global, factored out from
2071         ...
2072         (add_setshow_boolean_cmd): ... here.
2073         * cli/cli-decode.h (boolean_enums): Declare.
2074         * cli/cli-option.c: New file.
2075         * cli/cli-option.h: New file.
2076         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2077         factored out from ...
2078         (parse_cli_boolean_value(const char *)): ... this.
2079         (is_unlimited_literal): Change parameter type to pointer to
2080         pointer.  Adjust and advance ARG pointer.
2081         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2082         (parse_cli_var_enum): New, factored out from ...
2083         (do_set_command): ... this.  Adjust.
2084         * cli/cli-setshow.h (parse_cli_boolean_value)
2085         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2086         (parse_cli_var_enum): Declare.
2087         * cli/cli-utils.c: Include "cli/cli-option.h".
2088         (get_ulongest): New.
2089         * cli/cli-utils.h (get_ulongest): Declare.
2090         (check_for_argument): New overloads.
2091         * maint-test-options.c: New file.
2092
2093 2019-06-13  Pedro Alves  <palves@redhat.com>
2094
2095         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2096         parse a range if "-" is at the end of the string.
2097
2098 2019-06-13  Pedro Alves  <palves@redhat.com>
2099
2100         * cli/cli-setshow.c (parse_auto_binary_operation)
2101         (parse_cli_boolean_value): Don't allow "o".
2102
2103 2019-06-13  Pedro Alves  <palves@redhat.com>
2104
2105         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2106         * NEWS: Mention maint test-settings KIND.
2107         * maint-test-settings.c: New file.
2108
2109 2019-06-13  Pedro Alves  <palves@redhat.com>
2110
2111         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2112         completer.
2113         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2114         "set" completers.
2115
2116 2019-06-13  Pedro Alves  <palves@redhat.com>
2117
2118         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2119         after item.
2120
2121 2019-06-13  Pedro Alves  <palves@redhat.com>
2122
2123         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2124
2125 2019-06-13  Pedro Alves <palves@redhat.com>
2126
2127         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2128         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2129         call.
2130         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2131         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2132         calls.
2133         (check_for_argument): Skip spaces after argument.
2134
2135 2019-06-13  Pedro Alves  <palves@redhat.com>
2136
2137         * thread.c (thread_apply_command): Adjust TID parsing.
2138         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2139         detected before end of string.
2140         (tid_is_in_list): Error out if LIST is invalid.
2141
2142 2019-06-13  Pedro Alves  <palves@redhat.com>
2143
2144         * completer.c (complete_line_internal_1): Rewind completion word
2145         point.
2146         (completion_tracker::advance_custom_word_point_by): Change
2147         parameter type to int.
2148         * completer.h (completion_tracker::advance_custom_word_point_by):
2149         Likewise.
2150
2151 2019-06-13  Pedro Alves  <palves@redhat.com>
2152
2153         * completer.c (advance_to_completion_word): Handle delimiters.
2154
2155 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2156
2157         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2158
2159 2019-06-11  Tom Tromey  <tom@tromey.com>
2160
2161         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2162         (xmalloc_failed): Move to alloc.c.
2163         * alloc.c: New file.
2164         * Makefile.in (COMMON_SFILES): Add alloc.c.
2165
2166 2019-06-11  Tom Tromey  <tom@tromey.com>
2167
2168         * nat/linux-waitpid.c: Don't include server.h.
2169         (linux_debug): Remove.
2170         (my_waitpid): Update.
2171
2172 2019-06-11  Tom Tromey  <tromey@adacore.com>
2173
2174         * infcall.c (_initialize_infcall): Remove trailing newline from
2175         help.
2176         * user-regs.c (_initialize_user_regs): Remove trailing newline
2177         from help.
2178         * typeprint.c (_initialize_typeprint): Remove trailing newline
2179         from help.
2180         * reverse.c (_initialize_reverse): Remove trailing newlines from
2181         help.
2182         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2183         from help.
2184         * language.c (add_set_language_command): Remove trailing newline
2185         from help.
2186         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2187         help.
2188         * disasm.c (_initialize_disasm): Remove trailing newline from
2189         help.
2190         * top.c (init_main): Remove trailing newline from help.
2191         * interps.c (_initialize_interpreter): Remove trailing newline
2192         from help.
2193         * btrace.c (_initialize_btrace): Remove trailing newlines from
2194         help.
2195         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2196         from help.
2197         * python/python.c (_initialize_python): Remove trailing newline
2198         from help.
2199         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2200         help.
2201         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2202         from help.  Reformat some text.
2203         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2204         from help.
2205         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2206         newline from help.
2207
2208 2019-06-11  Tom Tromey  <tromey@adacore.com>
2209
2210         * darwin-nat.c (darwin_decode_exception_message)
2211         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2212
2213 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2214
2215         * valops.c (value_slice): Check for not allocated or not
2216         associated values.
2217
2218 2019-06-10  Tom de Vries  <tdevries@suse.de>
2219
2220         PR gdb/24618
2221         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2222         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2223         invalid.
2224
2225 2019-06-10  Tom de Vries  <tdevries@suse.de>
2226
2227         PR gdb/24611
2228         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2229         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2230
2231 2019-06-10  Tom de Vries  <tdevries@suse.de>
2232
2233         PR symtab/24545
2234         * symtab.c (struct demangled_name_entry): Add language field.
2235         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2236         static minimal symbol".  Set and use language field.
2237
2238 2019-06-10  Tom Tromey  <tromey@adacore.com>
2239
2240         * ada-lang.c (_initialize_ada_language): Update help text.
2241
2242 2019-06-10  Tom Tromey  <tromey@adacore.com>
2243
2244         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2245         with a newline.
2246         * guile/guile.c (handle_boot_error): Don't end warning with a
2247         newline.
2248         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2249         warning with a newline.
2250         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2251         newline.
2252         (s12z_frame_cache): Likewise.
2253         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2254         a newline.
2255         * solib-svr4.c (disable_probes_interface): Don't end warning with
2256         a newline.
2257         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2258         newline.
2259         * python/python.c (do_finish_initialization): Don't end warning
2260         with a newline.
2261
2262 2019-06-10  Tom Tromey  <tom@tromey.com>
2263
2264         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2265         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2266         gdbpy_enter.
2267
2268 2019-06-10  Tom Tromey  <tromey@adacore.com>
2269
2270         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2271         data.
2272         (elf_new_init): Don't call stabsread_new_init.
2273         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2274         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2275         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2276
2277 2019-06-10  Tom de Vries  <tdevries@suse.de>
2278
2279         PR symtab/16264
2280         PR symtab/24517
2281         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2282
2283 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2284
2285         * source.c (find_and_open_source): Also rewrite relative file
2286         names.
2287
2288 2019-04-26  Amos Bird  <amosbird@gmail.com>
2289
2290         * annotate.c (annotate_thread_exited): Add "thread-exited"
2291         annotation.
2292
2293 2019-06-06  Tom Tromey  <tromey@adacore.com>
2294
2295         * maint.h (class scoped_command_stats): Use
2296         DISABLE_COPY_AND_ASSIGN.
2297         <print_time>: New method.
2298         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2299         print_time.
2300         (scoped_command_stats::print_time): New method.
2301
2302 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2303
2304         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2305         instructions of lengths 6 or 8 bytes.
2306
2307 2019-06-04  Pedro Alves  <palves@redhat.com>
2308
2309         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2310
2311         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2312         * breakpoint.c (condition_completer): Likewise.
2313         * cli/cli-dump.c (scan_expression): Likewise.
2314         * common/filestuff.c (mkdir_recursive): Likewise.
2315         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2316         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2317         (gdb_abspath): Likewise.
2318         * compile/compile-cplus-types.c
2319         (compile_cplus_instance::decl_name): Likewise.
2320         * completer.c (complete_explicit_location):
2321         (signal_completer, reg_or_group_completer_1): Likewise.
2322         * cp-support.c (cp_remove_params_if_any): Likewise.
2323         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2324         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2325         * infcmd.c (strip_bg_char): Likewise.
2326         * linespec.c (copy_token_string): Likewise.
2327         * mi/mi-main.c (output_cores): Likewise.
2328         * psymtab.c (psymtab_search_name):
2329         * symfile.c (test_set_ext_lang_command): Likewise.
2330         * target.c (target_fileio_read_stralloc): Likewise.
2331         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2332         * value.c (complete_internalvar): Likewise.
2333
2334 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2335
2336         Add objfile property to gdb.Type.
2337         * NEWS: Mention Python API addition.
2338         * python/py-type.c (typy_get_objfile): New method.
2339
2340 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2341
2342         * NEWS: Mention the new set|show style [title|highlight].
2343         Mention changes to "show style", "help" and "apropos".
2344
2345 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2346
2347         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2348         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2349         instead of print_help_for_command.
2350         (print_doc_of_command): New function.
2351         (help_list): Add 'apropos -v word' suggestion.
2352         (print_help_for_command): Style the command name using title style.
2353         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2354         (_initialize_cli_cmds): Describe -v in apropos_command help.
2355
2356 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2357
2358         * cli/cli-style.h (cli_style_option): Add name in constructor,
2359         add m_name class member, add constructor with intensity,
2360         add name class function.
2361         (cli_style_option::add_setshow_commands): Remove name argument.
2362         (highlight_style, title_style): New styles.
2363         * cli/cli-style.c (do_show): New function that shows a style
2364         characteristic styling the style name with itself.
2365         (set_style_name): New function.
2366         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2367         Update all callers according to the changes in cli/cli-style.h.
2368         * utils.h (fputs_highlighted): New function.
2369         * utils.c (fputs_highlighted): Likewise.
2370
2371 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2372
2373         * NEWS: Mention new pipe command and new convenience variables.
2374
2375 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2376
2377         * cli/cli-cmds.c (pipe_command): New function.
2378         (_initialize_cli_cmds): Call add_com for pipe_command.
2379         Define | as an alias for pipe.
2380         (exit_status_set_internal_vars): New function.
2381         (shell_escape): Call exit_status_set_internal_vars.
2382         cli/cli-decode.c (find_command_name_length): Recognize | as
2383         a single character command.
2384
2385 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2386
2387         * gdbcmd.h (execute_command_to_ui_file): New declaration.
2388         top.c (execute_command_to_ui_file): New function, mostly a copy
2389         of execute_command_to_string.
2390         (execute_command_to_string): Implement by calling
2391         execute_command_to_ui_file.
2392
2393 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2394
2395         * top.h (saved_command_line): Remove declaration.
2396         * top.c (previous_saved_command_line, previous_repeat_arguments):
2397         New variables.
2398         (saved_command_line): Make static, define together with other
2399         'repeat variables'.
2400         (dont_repeat): Clear repeat_arguments.
2401         (repeat_previous, get_saved_command_line, save_command_line):
2402         New functions.
2403         (gdb_init): Initialize saved_command_line
2404         and previous_saved_command_line.
2405         * main.c (captured_main_1): Remove saved_command_line initialization.
2406         * event-top.c (handle_line_of_input): Update to use
2407         the new 'repeat' related functions instead of direct access to
2408         saved_command_line.
2409         * command.h (repeat_previous, get_saved_command_line,
2410         save_command_line): New declarations.
2411         (dont_repeat): Add comment.
2412
2413 2019-05-30  Tom Tromey  <tromey@adacore.com>
2414
2415         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
2416         Fix comment.
2417         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
2418
2419 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
2420
2421         PR cli/24587
2422         * completer.c (complete): Initialize variable word.
2423
2424 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
2425
2426         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2427         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
2428         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
2429         'body' is NULL to the outter 'if', protecting the '!is_define'
2430         situation as well.
2431
2432 2019-05-29  Tom Tromey  <tromey@adacore.com>
2433
2434         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
2435         (dwarf_unknown): New function.
2436         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
2437         (dwarf_type_encoding_name): Use dwarf_unknown.
2438
2439 2019-05-29  Tom Tromey  <tromey@adacore.com>
2440
2441         PR c++/20020:
2442         * cp-valprint.c (cp_print_value_fields): Call
2443         cp_print_static_field inside "try".
2444
2445 2019-05-29  Tom Tromey  <tromey@adacore.com>
2446
2447         * inflow.c (struct terminal_info): Add default operator=.
2448         * configure: Rebuild.
2449         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
2450         -Wdeprecated-copy-dtor, -Wredundant-move.
2451
2452 2019-05-29  Tom Tromey  <tromey@adacore.com>
2453
2454         * NEWS: Add entry.
2455         * infcmd.c (print_return_value_1): Handle finish_print
2456         option.
2457         (show_print_finish): New function.
2458         (_initialize_infcmd): Add "set/show print finish" commands.
2459         * valprint.c (user_print_options): Initialize new member.
2460         * valprint.h (struct value_print_options) <finish_print>: New
2461         member.
2462
2463 2019-05-28  Tom Tromey  <tromey@adacore.com>
2464
2465         * ada-lang.c (ada_remove_Xbn_suffix)
2466         (find_old_style_renaming_symbol)
2467         (parse_old_style_renaming): Remove.
2468         (ada_find_renaming_symbol): Don't call
2469         find_old_style_renaming_symbol.
2470         (ada_is_renaming_symbol): Rename from
2471         ada_find_renaming_symbol.  Remove "block" parameter.  Return
2472         bool.  Now static.
2473         (ada_read_var_value): Update and simplify.
2474         * ada-exp.y (write_var_or_type): Remove old code.
2475
2476 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
2477
2478         * event-top.c: Remove include comment.
2479         * inflow.c (class scoped_ignore_sigttou): Move from here...
2480         * inflow.h (class scoped_ignore_sigttou): ...to here.
2481         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
2482         * top.c:  Remove include comment.
2483
2484 2019-05-27  Tom Tromey  <tom@tromey.com>
2485
2486         * NEWS: Fix typo.
2487
2488 2019-05-22  Tom Tromey  <tromey@adacore.com>
2489
2490         * target.c (target_follow_exec): Constify parameter.
2491         * target-delegates.c: Rebuild.
2492         * remote.c (remote_target::follow_exec): Constify parameter.
2493         * infrun.c (follow_exec): Constify parameter.
2494         * target.h (struct target_ops) <follow_exec>: Constify parameter.
2495         (target_follow_exec): Likewise.
2496
2497 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2498
2499         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
2500         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
2501
2502 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2503
2504         * NEWS: Add debugredirect and testsuite sections.
2505
2506 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
2507
2508         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
2509         target descriptions using exclusively floating point register name
2510         aliases.
2511
2512 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2513
2514         PR gdb/18644:
2515         * f-lang.c (build_fortran_types): Handle the case where
2516         gdbarch_floatformat_for_type returns a nullptr.
2517
2518 2019-05-21  Tom de Vries  <tdevries@suse.de>
2519
2520         PR cli/24587
2521         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
2522
2523 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2524
2525         PR gdb/18644:
2526         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
2527         16-byte floats.
2528         * i386-tdep.c (i386_floatformat_for_type): Use
2529         floatformats_ia64_quad for the 16-byte floating point component
2530         within a fortran 32-byte complex number.
2531
2532 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2533
2534         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
2535         delete default constructor.
2536         (find_partial_die): Update to return const struct.
2537         (partial_die_parent_scope): Move variable declaration into scope
2538         of its use and change its type to auto.
2539         (guess_partial_die_structure_name): Likewise.
2540         (partial_die_info::fixup): Likewise.
2541
2542 2019-05-17  Tom Tromey  <tromey@adacore.com>
2543
2544         * source.c (find_and_open_source): Remove cast.
2545
2546 2019-05-17  Tom Tromey  <tromey@adacore.com>
2547
2548         * annotate.c (annotate_source): Make "filename" const.
2549         * annotate.h (annotate_source): Use const.
2550
2551 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2552
2553         * disasm.c (set_disassembler_options): Send errors to stderr.
2554
2555 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2556
2557         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
2558         (cli_interp_base::set_logging): Check debug_redirect.
2559         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
2560         * cli/cli-logging.c (debug_redirect): Add static variable.
2561         (pop_output_files): Add default param.
2562         (handle_redirections): Print debug setting.
2563         (show_logging_command): Likewise.
2564         (_initialize_cli_logging): Add debugredirect command.
2565         * interps.c (current_interp_set_logging): Add debug_redirect
2566         parameter.
2567         * interps.h (set_logging): Add debug_redirect parameter.
2568         (current_interp_set_logging): Likewise.
2569         * mi/mi-common.h: Likewise.
2570         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
2571
2572 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2573             Tom Tromey  <tromey@adacore.com>
2574
2575         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
2576         directly.
2577         * cli/cli-interp.h (make_logging_output): Remove declaration.
2578         * cli/cli-logging.c (make_logging_output): Remove function.
2579         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
2580         directly.
2581         * ui-file.c (tee_file::tee_file): Remove bools.
2582         (tee_file::~tee_file): Remove deletes.
2583         * ui-file.h (tee_file): Remove bools.
2584
2585 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
2586
2587         * mi/mi-cmds.h (mi_cmd_complete): New function.
2588         * mi/mi-main.c (mi_cmd_complete): Likewise.
2589         * mi/mi-cmds.c: Define new MI command -complete.
2590         * NEWS: Mention new -complete command.
2591
2592 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
2593
2594         * completer.h (complete): New function.
2595         * completer.c (complete): Likewise.
2596         * cli/cli-cmds.c: (complete_command): Update to use new complete()
2597         function defined in completer.h.
2598
2599 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
2600
2601         * MAINTAINERS (Write After Approval): Add myself.
2602
2603 2019-05-17  Tom de Vries  <tdevries@suse.de>
2604
2605         PR gdb/24094
2606         * dwarf2read.c (struct cu_partial_die_info): New struct.
2607         (find_partial_die): Return cu_partial_die_info.
2608         (partial_die_parent_scope, guess_partial_die_structure_name)
2609         (partial_die_info::fixup): Handle new return type of find_partial_die.
2610
2611 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2612
2613         * stap-probe.c (stap_parse_register_operand): Make "regname" an
2614         "std::string", simplifying the algorithm.
2615
2616 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2617
2618         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2619         (stap_static_probe_ops::get_probes): Likewise.
2620
2621 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2622
2623         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2624         '-')" and "else if".
2625         (stap_parse_single_operand): Join checks for
2626         "gdbarch_stap_parse_special_token_p" and
2627         "gdbarch_stap_parse_special_token" in the same "if" statement.
2628         Invert check when verifying for operation on register
2629         displacement.
2630
2631 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2632
2633         * stap-probe.c (stap_get_opcode): Update comment.
2634         (stap_get_expected_argument_type): Likewise.
2635         (handle_stap_probe): Likewise.
2636
2637 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2638
2639         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2640         return type to 'bool'.  Adjust comment.  Use 'bool' when
2641         appropriate.
2642         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2643         * stap-probe.c (stap_parse_argument_1): Likewise.
2644         (stap_is_operator): Likewise.
2645         (stap_is_generic_prefix): Likewise.
2646         (stap_is_register_prefix): Likewise.
2647         (stap_is_register_indirection_prefix): Likewise.
2648         (stap_is_integer_prefix): Likewise.
2649         (stap_generic_check_suffix): Likewise.
2650         (stap_check_integer_suffix): Likewise.
2651         (stap_check_register_suffix): Likewise.
2652         (stap_check_register_indirection_suffix): Likewise.
2653         (stap_parse_register_operand): Likewise.
2654         (stap_parse_single_operand): Likewise.
2655         (stap_parse_argument_1): Likewise.
2656         (stap_probe::get_argument_count): Likewise.
2657         (stap_is_operator): Likewise.
2658
2659 2019-05-16  Tom Tromey  <tromey@adacore.com>
2660
2661         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2662         keyword to foreach.
2663
2664 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
2665
2666         * linux-thread-db.c (try_thread_db_load_1): Change return type
2667         to bool.
2668         (try_thread_db_load): Likewise.
2669         (try_thread_db_load_from_pdir_1): Likewise.
2670         (try_thread_db_load_from_pdir): Likewise.
2671         (try_thread_db_load_from_sdir): Likewise.
2672         (try_thread_db_load_from_dir): Likewise.
2673         (thread_db_load_search): Likewise.
2674         (has_libpthread): Likewise.
2675         (thread_db_load): Likewise.
2676
2677 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
2678
2679         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2680         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2681         NULL, and complain/return if that's the case.
2682
2683 2019-05-15  John Darrington <john@darrington.wattle.id.au>
2684
2685         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2686         (advance, posn, abstract_read_memory): New functions.
2687         [struct mem_read_abstraction]: New struct.
2688         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
2689
2690 2019-05-14  Tom Tromey  <tromey@adacore.com>
2691
2692         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
2693         value is not lval_memory.
2694
2695 2019-05-14  Tom Tromey  <tromey@adacore.com>
2696
2697         * solib.c (info_sharedlibrary_command): Style the file name.
2698
2699 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
2700
2701         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
2702         (aarch64_vnv_type): Likewise.
2703         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
2704         * common/tdesc.c: Likewise.
2705         * common/tdesc.h (enum tdesc_type_kind): Likewise.
2706         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
2707         * features/aarch64-fpu.xml: Add ieee half view.
2708         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
2709         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
2710         * gdbtypes.h (struct builtin_type): Likewise.
2711         (struct objfile_type): Likewise.
2712
2713 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
2714
2715         * language.c (language_sniff_from_mangled_name): Fix "langauge"
2716         typo.
2717         * location.h (string_to_event_location): Likewise.
2718
2719 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
2720
2721         GDB 8.3 released.
2722
2723 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2724
2725         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
2726         New variable declaration.
2727         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
2728         New variable.
2729         (print_one_breakpoint): Use ui_out::test_flags and new global
2730         variable to compute use_fixed_output.
2731         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
2732         Remove.
2733         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
2734         (mi_multi_location_breakpoint_output_fixed): Remove.
2735         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
2736         new variable.
2737         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
2738         fix_multi_location_breakpoint_output flag if version >= 3.
2739         * ui-out.h (enum ui_out_flag)
2740         <fix_multi_location_breakpoint_output>: New enumerator.
2741
2742 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2743
2744         * contrib/cc-with-tweaks.sh: Validate dwz's work.
2745
2746 2019-05-10  Tom Tromey  <tromey@adacore.com>
2747
2748         * ada-lang.c (catch_ada_completer): New function.
2749         (_initialize_ada_language): Use it.
2750
2751 2019-05-10  Tom Tromey  <tromey@adacore.com>
2752
2753         * thread.c (print_thread_info): Make "requested_threads" const.
2754         * gdbthread.h (print_thread_info): Make "requested_threads"
2755         const.
2756         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
2757         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
2758
2759 2019-05-08  Tom Tromey  <tom@tromey.com>
2760
2761         * gdbtypes.c (objfile_type_data): Change type.
2762         (objfile_type, _initialize_gdbtypes): Update.
2763
2764 2019-05-08  Tom Tromey  <tom@tromey.com>
2765
2766         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
2767         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
2768         (_initialize_dwarf2_frame): Update.
2769
2770 2019-05-08  Tom Tromey  <tom@tromey.com>
2771
2772         * objc-lang.c (objc_objfile_data): Change type.
2773         (find_methods): Update.
2774         (_initialize_objc_lang): Remove.
2775
2776 2019-05-08  Tom Tromey  <tom@tromey.com>
2777
2778         * stabsread.c (rs6000_builtin_type_data): Change type.
2779         (rs6000_builtin_type, _initialize_stabsread): Update.
2780
2781 2019-05-08  Tom Tromey  <tom@tromey.com>
2782
2783         * mips-tdep.c (mips_pdr_data): Remove.
2784         (_initialize_mips_tdep): Update.
2785
2786 2019-05-08  Tom Tromey  <tom@tromey.com>
2787
2788         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
2789         (hppa_init_objfile_priv_data, read_unwind_info)
2790         (find_unwind_entry, _initialize_hppa_tdep): Update.
2791
2792 2019-05-08  Tom Tromey  <tom@tromey.com>
2793
2794         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
2795         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
2796         on obstack.
2797         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
2798
2799 2019-05-08  Tom Tromey  <tom@tromey.com>
2800
2801         * mdebugread.c (basic_type_data): Change type.
2802         (basic_type, _initialize_mdebugread): Update.
2803
2804 2019-05-08  Tom Tromey  <tom@tromey.com>
2805
2806         * common/gdb_unique_ptr.h (struct noop_deleter): New.
2807
2808 2019-05-08  Tom Tromey  <tom@tromey.com>
2809
2810         * nto-tdep.c (nto_inferior_data_reg): Change type.
2811         (nto_inferior_data): Update.
2812         (nto_inferior_data_cleanup, nto_new_inferior_data)
2813         (_initialize_nto_tdep): Remove.
2814         * nto-tdep.h (struct nto_inferior_data): Add initializers.
2815
2816 2019-05-08  Tom Tromey  <tom@tromey.com>
2817
2818         * ada-lang.c (struct ada_inferior_data): Add initializers.
2819         (ada_inferior_data): Change type.
2820         (ada_inferior_data_cleanup): Remove.
2821         (get_ada_inferior_data, ada_inferior_exit)
2822         (struct ada_pspace_data): Add initializers, destructor.
2823         (ada_pspace_data_handle): Change type.
2824         (get_ada_pspace_data): Update.
2825         (ada_pspace_data_cleanup): Remove.
2826
2827 2019-05-08  Tom Tromey  <tom@tromey.com>
2828
2829         * coffread.c (struct coff_symfile_info): Add initializers.
2830         (coff_objfile_data_key): Move lower.  Change type.
2831         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
2832         Update.
2833         (coff_free_info): Remove.
2834
2835 2019-05-08  Tom Tromey  <tom@tromey.com>
2836
2837         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
2838         (fbsd_pspace_data_handle): Move lower.  Change type.
2839         (get_fbsd_pspace_data): Update.
2840         (fbsd_pspace_data_cleanup): Remove.
2841         (_initialize_fbsd_tdep): Update.
2842
2843 2019-05-08  Tom Tromey  <tom@tromey.com>
2844
2845         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
2846         (get_ada_tasks_pspace_data): Update.
2847         (ada_tasks_pspace_data_cleanup): Remove.
2848         (_initialize_tasks): Update.
2849         (ada_tasks_inferior_data_handle): Change type.
2850         (get_ada_tasks_inferior_data): Update.
2851         (ada_tasks_inferior_data_cleanup): Remove.
2852         (struct ada_tasks_pspace_data): Add initializers.
2853
2854 2019-05-08  Tom Tromey  <tom@tromey.com>
2855
2856         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
2857         * symfile-debug.c (debug_sym_get_probes): Change type.
2858         * stap-probe.c (handle_stap_probe):
2859         (stap_static_probe_ops::get_probes): Change type.
2860         * probe.h (class static_probe_ops) <get_probes>: Change type.
2861         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
2862         (parse_probes_in_pspace): Update.
2863         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
2864         Update.
2865         (any_static_probe_ops::get_probes): Change type.
2866         * elfread.c (elfread_data): New typedef.
2867         (probe_key): Change type.
2868         (elf_get_probes): Likewise.  Update.
2869         (probe_key_free): Remove.
2870         (_initialize_elfread): Update.
2871         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
2872         Change type.
2873         (dtrace_process_dof_probe, dtrace_process_dof)
2874         (dtrace_static_probe_ops::get_probe): Change type.
2875
2876 2019-05-08  Tom Tromey  <tom@tromey.com>
2877
2878         * xcoffread.c (struct xcoff_symfile_info): Rename from
2879         coff_symfile_info.  Add initializers.
2880         (xcoff_objfile_data_key): Move lower.  Change type.
2881         (XCOFF_DATA): Rewrite.
2882         (xcoff_free_info): Remove.
2883         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
2884         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
2885         (xcoff_initial_scan): Update.
2886
2887 2019-05-08  Tom Tromey  <tom@tromey.com>
2888
2889         * solib-svr4.c (struct svr4_info): Add initializers and
2890         destructor.
2891         <probes_table>: Now an htab_up.
2892         (solib_svr4_pspace_data): Change type.
2893         (free_probes_table): Simplify.
2894         (~svr4_info): Rename from svr4_pspace_data_cleanup.
2895         (get_svr4_info, probes_table_htab_remove_objfile_probes)
2896         (probes_table_remove_objfile_probes, register_solib_event_probe)
2897         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
2898         (_initialize_svr4_solib): Update.
2899
2900 2019-05-08  Tom Tromey  <tom@tromey.com>
2901
2902         * remote.c (remote_pspace_data): Change type.
2903         (remote_pspace_data_cleanup): Remove.
2904         (get_remote_exec_file, set_pspace_remote_exec_file)
2905         (_initialize_remote): Update.
2906
2907 2019-05-08  Tom Tromey  <tom@tromey.com>
2908
2909         * breakpoint.c (breakpoint_objfile_key): Change type.
2910         (get_breakpoint_objfile_data): Update.
2911         (free_breakpoint_objfile_data): Remove.
2912         (_initialize_breakpoint): Update.
2913
2914 2019-05-08  Tom Tromey  <tom@tromey.com>
2915
2916         * linux-tdep.c (struct linux_info): Add initializers.
2917         (linux_inferior_data): Move.  Change type.
2918         (invalidate_linux_cache_inf): Update.
2919         (linux_inferior_data_cleanup): Remove.
2920         (get_linux_inferior_data, _initialize_linux_tdep): Update.
2921
2922 2019-05-08  Tom Tromey  <tom@tromey.com>
2923
2924         * auxv.c (auxv_inferior_data): Move.  Change type.
2925         (auxv_inferior_data_cleanup): Remove.
2926         (invalidate_auxv_cache_inf): Rewrite.
2927         (get_auxv_inferior_data, _initialize_auxv): Update.
2928
2929 2019-05-08  Tom Tromey  <tom@tromey.com>
2930
2931         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
2932         (symfile_debug_objfile_data_key): Change type.
2933         (symfile_debug_installed, debug_qf_has_symbols)
2934         (debug_qf_find_last_source_symtab)
2935         (debug_qf_forget_cached_source_info)
2936         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
2937         (debug_qf_print_stats, debug_qf_dump)
2938         (debug_qf_expand_symtabs_for_function)
2939         (debug_qf_expand_all_symtabs)
2940         (debug_qf_expand_symtabs_with_fullname)
2941         (debug_qf_map_matching_symbols)
2942         (debug_qf_expand_symtabs_matching)
2943         (debug_qf_find_pc_sect_compunit_symtab)
2944         (debug_qf_map_symbol_filenames)
2945         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
2946         (debug_sym_new_init, debug_sym_init, debug_sym_read)
2947         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
2948         (debug_sym_read_linetable, debug_sym_relocate): Update.
2949         (symfile_debug_free_objfile): Remove.
2950         (install_symfile_debug_logging, _initialize_symfile_debug):
2951         Update.
2952
2953 2019-05-08  Tom Tromey  <tom@tromey.com>
2954
2955         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
2956         allocate_on_obstack.
2957         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
2958         (get_dwarf2_per_objfile): Update.
2959         (set_dwarf2_per_objfile): Remove.
2960         (dwarf2_has_info, dwarf2_get_section_info): Update.
2961         (dwarf2_free_objfile): Remove.
2962         (_initialize_dwarf2_read): Update.
2963
2964 2019-05-08  Tom Tromey  <tom@tromey.com>
2965
2966         * auto-load.c (struct auto_load_pspace_info): Add destructor and
2967         initializers.
2968         <unsupported_script_warning_printed,
2969         script_not_found_warning_printed>: Now bool.
2970         (auto_load_pspace_data): Change type.
2971         (~auto_load_pspace_info): Rename from
2972         auto_load_pspace_data_cleanup.
2973         (get_auto_load_pspace_data, init_loaded_scripts_info)
2974         (clear_section_scripts, maybe_print_unsupported_script_warning)
2975         (maybe_print_script_not_found_warning, _initialize_auto_load):
2976         Update.
2977
2978 2019-05-08  Tom Tromey  <tom@tromey.com>
2979
2980         * objfiles.c (objfile_pspace_info): Add destructor and
2981         initializers.
2982         (objfiles_pspace_data): Change type.
2983         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
2984         (get_objfile_pspace_data): Update.
2985         (objfiles_bfd_data): Change type.
2986         (get_objfile_bfd_data): Update.
2987         (objfile_bfd_data_free, _initialize_objfiles): Remove.
2988
2989 2019-05-08  Tom Tromey  <tom@tromey.com>
2990
2991         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
2992         Change type.
2993         (get_catch_syscall_inferior_data): Update.
2994         (catch_syscall_inferior_data_cleanup): Remove.
2995         (_initialize_break_catch_syscall): Update.
2996
2997 2019-05-08  Tom Tromey  <tom@tromey.com>
2998
2999         * inflow.c (struct terminal_info): Add destructor and
3000         initializers.
3001         (inflow_inferior_data): Change type.
3002         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3003         (get_inflow_inferior_data, inflow_inferior_exit)
3004         (swap_terminal_info, _initialize_inflow): Update.
3005
3006 2019-05-08  Tom Tromey  <tom@tromey.com>
3007
3008         * target-dcache.c (target_dcache_cleanup): Remove.
3009         (target_dcache_aspace_key): Change type.
3010         (target_dcache_init_p, target_dcache_invalidate)
3011         (target_dcache_get, target_dcache_get_or_init)
3012         (_initialize_target_dcache): Update.
3013         * dcache.h (struct dcache_deleter): New.
3014
3015 2019-05-08  Tom Tromey  <tom@tromey.com>
3016
3017         * symtab.c (struct symbol_cache): Add destructor and
3018         initializers.
3019         (symbol_cache_key): Move.  Change type.
3020         (make_symbol_cache, free_symbol_cache): Remove.
3021         (get_symbol_cache): Update.
3022         (symbol_cache_cleanup): Remove.
3023         (ALL_PSPACES, symbol_cache_flush)
3024         (maintenance_print_symbol_cache)
3025         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3026         Update.
3027
3028 2019-05-08  Tom Tromey  <tom@tromey.com>
3029
3030         * symtab.c (struct main_info): Add destructor and initializers.
3031         (main_progspace_key): Move.  Change type.
3032         (get_main_info): Update.
3033         (main_info_cleanup): Remove.
3034         (_initialize_symtab): Update.
3035
3036 2019-05-08  Tom Tromey  <tom@tromey.com>
3037
3038         * registry.h (DECLARE_REGISTRY): Define the _key class.
3039
3040 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3041
3042         * NEWS: Merge two 'New commands' sections.
3043
3044 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3045
3046         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3047         parameter and use Ada language definition instead.
3048         (ada_val_print_ptr): Remove unused language parameter.
3049         (ada_val_print_num): Remove language parameter and use Ada language
3050         definition instead.
3051         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3052         parameter.
3053         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3054         parameter and use Ada language definition instead.
3055         (ada_val_print_1): Update all ada_val_print_xxx calls.
3056         Remove language parameter.
3057         (ada_val_print): Update ada_val_print_1 call.
3058
3059 2019-05-08  Tom Tromey  <tromey@adacore.com>
3060
3061         * remote.c (remote_hw_watchpoint_limit)
3062         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3063         Now static.
3064
3065 2019-05-08  Tom Tromey  <tromey@adacore.com>
3066
3067         * maint.c (_initialize_maint_cmds): Move initialization code to
3068         remote.c.
3069         (watchdog, show_watchdog): Move to remote.c.
3070         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3071         "watchdog" static.
3072         (_initialize_remote): Move initialization code from maint.c.
3073         * defs.h (watchdog): Don't declare.
3074
3075 2019-05-08  Tom Tromey  <tromey@adacore.com>
3076
3077         * tui/tui-interp.c: Include main.h.
3078         * interps.c: Include main.h.
3079         * main.h (interpreter_p): Declare.
3080         * defs.h (interpreter_p): Don't declare.
3081
3082 2019-05-08  Tom Tromey  <tromey@adacore.com>
3083
3084         * dwarf2loc.c: Include dwarf2read.h.
3085         * defs.h (read_unsigned_leb128): Don't declare.
3086         * dwarf2read.h (read_unsigned_leb128): Declare.
3087
3088 2019-05-08  Tom Tromey  <tromey@adacore.com>
3089
3090         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3091         method.
3092
3093 2019-05-08  Tom Tromey  <tromey@adacore.com>
3094
3095         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3096         when no wrap column is set.
3097
3098 2019-05-08  Tom Tromey  <tromey@adacore.com>
3099
3100         * c-lang.c (c_get_string): Handle non-C-style arrays.
3101
3102 2019-05-08  Tom Tromey  <tromey@adacore.com>
3103
3104         * typeprint.c (print_offset_data::update): Print the bit offset,
3105         not the number of bits remaining.
3106
3107 2019-05-08  Tom Tromey  <tromey@adacore.com>
3108
3109         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3110         padding at end of comment.
3111
3112 2019-05-08  Tom Tromey  <tromey@adacore.com>
3113
3114         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3115         Compare main types.
3116
3117 2019-05-06  Tom Tromey  <tom@tromey.com>
3118
3119         * common/scoped_mmap.c: Include common-defs.h.
3120         * common/scoped_mmap.h: Don't include config.h.
3121
3122 2019-05-04  Tom Tromey  <tom@tromey.com>
3123
3124         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3125         (struct aarch64_call_info): Add initializers.
3126         <si>: Now a std::vector.
3127         (pass_on_stack, aarch64_push_dummy_call): Update.
3128
3129 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3130             Tom Tromey  <tom@tromey.com>
3131
3132         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3133         (ppc_threads): Now a std::vector.  Now static.
3134         (hwdebug_find_thread_points_by_tid)
3135         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3136         Update.
3137
3138 2019-05-04  Tom Tromey  <tom@tromey.com>
3139
3140         * arc-tdep.c (arc_tdesc_init): Return bool.
3141
3142 2019-05-04  Tom Tromey  <tom@tromey.com>
3143
3144         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3145         Use gdb_assert_not_reached.
3146
3147 2019-05-04  Tom Tromey  <tom@tromey.com>
3148
3149         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3150         "false".
3151
3152 2019-05-04  Tom Tromey  <tom@tromey.com>
3153
3154         * arc-tdep.c (arc_tdesc_init): Use bool.
3155
3156 2019-05-04  Tom Tromey  <tom@tromey.com>
3157
3158         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3159
3160 2019-05-04  Tom Tromey  <tom@tromey.com>
3161
3162         * cli/cli-cmds.c (valid_command_p): Return bool.
3163
3164 2019-05-04  Tom Tromey  <tom@tromey.com>
3165
3166         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3167         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3168
3169 2019-05-04  Raul Tambre  <raul@tambre.ee>
3170
3171         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3172         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3173         operator for comparison.
3174
3175 2019-05-04  Tom Tromey  <tom@tromey.com>
3176
3177         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3178         (lookup_partial_symbol, print_partial_symbols)
3179         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3180         (psymbol_compare): Update.
3181         (add_psymbol_to_bcache): Clear the entire psymbol.
3182         (maintenance_check_psymtabs): Update.
3183         * psympriv.h (struct partial_symbol): Don't derive from
3184         general_symbol_info.
3185         <obj_section, unrelocated_address, address,
3186         set_unrelocated_address>: Update.
3187         <ginfo>: New member.
3188         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3189         (debug_names::write_psymbols): Update.
3190
3191 2019-05-04  Tom de Vries  <tdevries@suse.de>
3192
3193         * contrib/cc-with-tweaks.sh: Support -n arg.
3194
3195 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3196
3197         * corelow.c (core_target::detach): Ensure frame cache and
3198         register caches are cleared.
3199         inferior.c (exit_inferior_1): Likewise.
3200
3201 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3202             Tom Tromey  <tom@tromey.com>
3203
3204         * dictionary.c (collate_pending_symbols_by_language): Remove
3205         "struct" from foreach.
3206         * symtab.c (lookup_global_symbol_from_objfile)
3207         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3208         foreach.
3209         * ser-tcp.c (net_open): Remove "struct" from foreach.
3210         * objfiles.c (objfile_relocate, objfile_rebase)
3211         (objfile_has_symbols): Remove "struct" from foreach.
3212         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3213         from foreach.
3214         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3215         foreach.
3216         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3217         "struct" from foreach.
3218         * ada-lang.c (create_excep_cond_exprs)
3219         (ada_exception_catchpoint_cond_string): Remove "struct" from
3220         foreach.
3221
3222 2019-05-03  Tom Tromey  <tromey@adacore.com>
3223
3224         * ada-exp.y (convert_char_literal): Check suffix of each
3225         enumerator.
3226
3227 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3228
3229         PR ada/21406:
3230         * ada-exp.y (yywrap): Don't define.
3231         * ada-lex.l (%option): Add noyywrap
3232         (yywrap): Remove.
3233
3234 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3235
3236         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3237         _WIN32_WINNT to the XP level, unless already defined to a higher
3238         level.
3239
3240         * unittests/parse-connection-spec-selftests.c:
3241         * ser-tcp.c:
3242         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3243         override.
3244
3245         * symfile.c (find_separate_debug_file): Remove colon from the
3246         drive spec of DOS/Windows file names of the target, so that the
3247         file name produced from DEBUGDIR and the target's directory will
3248         be valid on DOS/Windows systems.
3249
3250 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3251
3252         * rust-lang.c (val_print_struct): Handle printing structures
3253         containing strings.
3254
3255 2019-05-02  Tom Tromey  <tromey@adacore.com>
3256
3257         * valarith.c (_initialize_valarith): Remove.
3258
3259 2019-05-01  Tom Tromey  <tromey@adacore.com>
3260
3261         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3262         bitfields.
3263
3264 2019-05-01  Tom Tromey  <tromey@adacore.com>
3265
3266         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3267         for big-endian copies.
3268
3269 2019-04-30  Ali Tamur  <tamur@google.com>
3270         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3271         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3272         (read_3_bytes): New function.
3273
3274 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3275
3276         * windows-nat.c (main_thread_id): Delete.
3277         (handle_output_debug_string): Replace main_thread_id by
3278         current_event.dwThreadId.
3279         (fake_create_process): Likewise.
3280         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3281         Do not set main_thread_id.
3282         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3283         current_event.dwThreadId.
3284         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3285
3286 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3287
3288         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3289         Use current_event.dwThreadId instead of main_thread_id.
3290
3291 2019-04-30  Tom Tromey  <tromey@adacore.com>
3292
3293         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3294         (create_excep_cond_exprs): Iterate over program spaces.
3295         (ada_exception_catchpoint_cond_string): Examine all minimal
3296         symbols for exception types.
3297
3298 2019-04-30  Tom Tromey  <tromey@adacore.com>
3299
3300         PR c++/24470:
3301         * dwarf2read.c (process_structure_scope): Handle case where type
3302         has template parameters but no symbol was created.
3303
3304 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3305             Chris January  <chris.january@arm.com>
3306
3307         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3308         qualifier.
3309         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3310
3311 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3312
3313         * f-typeprint.c (f_print_type): Update rules for printing
3314         whitespace.
3315         (f_type_print_varspec_suffix): Likewise.
3316
3317 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3318             Chris January  <chris.january@arm.com>
3319
3320         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3321         function arguments.
3322
3323 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3324
3325         * f-lang.c (build_fortran_types): Change name of void type to
3326         lower case.
3327         * f-typeprint.c (f_type_print_base): Print the name of the void
3328         type, rather than a fixed string.
3329         * f-valprint.c (f_decorations): Use lower case void string.
3330
3331 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3332             Chris January  <chris.january@arm.com>
3333
3334         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3335         types for Fortran.
3336
3337 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3338             Chris January  <chris.january@arm.com>
3339             David Lecomber  <david.lecomber@arm.com>
3340
3341         * f-exp.y (BINOP_INTRINSIC): New token.
3342         (exp): New parser rule handling BINOP_INTRINSIC.
3343         (f77_keywords): Add new builtin procedures.
3344         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3345         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3346         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3347         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3348         (print_unop_subexp_f): New function.
3349         (print_binop_subexp_f): New function.
3350         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3351         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3352         (dump_subexp_body_f): Likewise.
3353         (operator_check_f): Likewise.
3354         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3355         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3356
3357 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3358
3359         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3360         UNOP_KIND.
3361         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3362         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3363         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3364         (operator_length_f): New fuction.
3365         (print_subexp_f): New function.
3366         (op_name_f): New function.
3367         (dump_subexp_body_f): New function.
3368         (operator_check_f): New function.
3369         (exp_descriptor_f): Replace standard expression handling functions
3370         with new functions.
3371         * gdb/fortran-operator.def: New file.
3372         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3373         * gdb/std-operator.def: Remove UNOP_KIND.
3374
3375 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3376
3377         * std-operator.def: Remove unbalanced, stray double quote
3378         character.
3379
3380 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3381             Chris January  <chris.january@arm.com>
3382             Daniel Everett  <daniel.everett@arm.com>
3383             Nick Forrington  <nick.forrington@arm.com>
3384             Richard Bunt  <richard.bunt@arm.com>
3385
3386         * cp-valprint.c (cp_print_value_fields): Allow an additional level
3387         of depth when printing anonymous structs or unions.
3388         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3389         Don't print either the top-level value, or the children if the
3390         max-depth is exceeded.
3391         (ppscm_print_children): When printing the key of a map, allow one
3392         extra level of depth.
3393         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3394         print either the top-level value, or the children if the max-depth
3395         is exceeded.
3396         (print_children): When printing the key of a map, allow one extra
3397         level of depth.
3398         * python/py-value.c (valpy_format_string): Add max_depth keyword.
3399         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
3400         (user_print_options): Initialise max_depth field.
3401         (val_print_scalar_or_string_type_p): New function.
3402         (val_print): Check to see if the max depth has been reached.
3403         (val_print_check_max_depth): Define new function.
3404         (show_print_max_depth): New function.
3405         (_initialize_valprint): Add 'print max-depth' option.
3406         * valprint.h (struct value_print_options) <max_depth>: New field.
3407         (val_print_check_max_depth): Declare new function.
3408         * NEWS: Document new feature.
3409
3410 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3411
3412         * ada-lang.c (ada_language_defn): Initialise new field.
3413         * c-lang.c (c_is_string_type_p): New function.
3414         (c_language_defn): Initialise new field.
3415         (cplus_language_defn): Initialise new field.
3416         (asm_language_defn): Initialise new field.
3417         (minimal_language_defn): Initialise new field.
3418         * c-lang.h (c_is_string_type_p): Declare new function.
3419         * d-lang.c (d_language_defn): Initialise new field.
3420         * f-lang.c (f_is_string_type_p): New function.
3421         (f_language_defn): Initialise new field.
3422         * go-lang.c (go_is_string_type_p): New function.
3423         (go_language_defn): Initialise new field.
3424         * language.c (default_is_string_type_p): New function.
3425         (unknown_language_defn): Initialise new field.
3426         (auto_language_defn): Initialise new field.
3427         * language.h (struct language_defn) <la_is_string_type_p>: New
3428         member variable.
3429         (default_is_string_type_p): Declare new function.
3430         * m2-lang.c (m2_language_defn): Initialise new field.
3431         * objc-lang.c (objc_language_defn): Initialise new field.
3432         * opencl-lang.c (opencl_language_defn): Initialise new field.
3433         * p-lang.c (pascal_is_string_type_p): New function.
3434         (pascal_language_defn): Initialise new field.
3435         * rust-lang.c (rust_is_string_type_p): New function.
3436         (rust_language_defn): Initialise new field.
3437
3438 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3439
3440         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
3441         New field.
3442         * ada-lang.c (ada_language_defn): Initialise new field.
3443         * c-lang.c (c_language_defn): Likewise.
3444         (cplus_language_defn): Likewise.
3445         (asm_language_defn): Likewise.
3446         (minimal_language_defn): Likewise.
3447         * d-lang.c (d_language_defn): Likewise.
3448         * f-lang.c (f_language_defn): Likewise.
3449         * go-lang.c (go_language_defn): Likewise.
3450         * language.c (unknown_language_defn): Likewise.
3451         (auto_language_defn): Likewise.
3452         * m2-lang.c (m2_language_defn): Likewise.
3453         * objc-lang.c (objc_language_defn): Likewise.
3454         * opencl-lang.c (opencl_language_defn): Likewise.
3455         * p-lang.c (pascal_language_defn): Likewise.
3456         * rust-lang.c (rust_language_defn): Likewise.
3457
3458 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3459
3460         * ada-lang.c (ada_is_character_type): Change return type to bool.
3461         (ada_is_string_type): Likewise.
3462         * ada-lang.h (ada_is_character_type): Update declaration
3463         (ada_is_string_type): Likewise.
3464
3465 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3466
3467         Support style in 'frame|thread apply'
3468
3469         * gdbcmd.h (execute_command_to_string): New term_out parameter.
3470         * record.c (record_start, record_stop): Update callers of
3471         execute_command_to_string with false.
3472         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
3473         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
3474         methods.
3475         (class string_file): New constructor with term_out parameter.
3476         Override methods term_out and can_emit_style_escape.  New member
3477         term_out.
3478         (class stdio_file): Override can_emit_style_escape.
3479         (class tee_file): Override term_out and can_emit_style_escape.
3480         * utils.h (can_emit_style_escape): Remove.
3481         * utils.c (can_emit_style_escape): Likewise.
3482         Update all callers of can_emit_style_escape (SOMESTREAM) to
3483         SOMESTREAM->can_emit_style_escape.
3484         * source-cache.c (source_cache::get_source_lines): Likewise.
3485         * stack.c (frame_apply_command_count): Call execute_command_to_string
3486         passing the term_out characteristic of the current gdb_stdout.
3487         * thread.c (thr_try_catch_cmd): Likewise.
3488         * top.c (execute_command_to_string): pass term_out parameter
3489         to construct the string_file for the command output.
3490         * ui-file.c (term_cli_styling): New function (most code moved
3491         from utils.c can_emit_style_escape).
3492         (string_file::string_file, string_file::can_emit_style_escape,
3493         stdio_file::can_emit_style_escape, tee_file::term_out,
3494         tee_file::can_emit_style_escape): New functions.
3495
3496 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3497
3498         * NEWS: Mention the new set|show may-call-functions.
3499         * infcall.c (may_call_functions_p): New variable.
3500         (show_may_call_functions_p): New function.
3501         (call_function_by_hand_dummy): Throws an error if not
3502         may-call-functions.
3503         (_initialize_infcall): Call add_setshow_boolean_cmd for
3504         may-call-functions.
3505
3506 2019-04-25  Keith Seitz  <keiths@redhat.com>
3507
3508         PR c++/24367
3509         * cp-support.c (inspect_type): Don't attempt substitutions
3510         of symbol with the same name.
3511
3512 2019-04-25  Tom Tromey  <tromey@adacore.com>
3513
3514         PR gdb/24475:
3515         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
3516         static.
3517
3518 2019-04-25  Tom Tromey  <tromey@adacore.com>
3519
3520         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
3521         rvalue reference.
3522         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
3523         (gdb_xml_parser::parse): Use std::move.
3524         * python/python-internal.h (gdbpy_convert_exception): Take a const
3525         reference.
3526         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
3527         std::move.
3528         * python/py-utils.c (gdbpy_convert_exception): Take a const
3529         reference.
3530         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3531         Use std::move.
3532         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3533         Use std::move.
3534         * mi/mi-main.c (mi_print_exception): Take a const reference.
3535         * main.c (handle_command_errors): Take a const reference.
3536         * linespec.c (parse_linespec): Use std::move.
3537         * infcall.c (run_inferior_call): Use std::move.
3538         (call_function_by_hand_dummy): Use std::move.
3539         * exec.c (try_open_exec_file): Use std::move.
3540         * exceptions.h (exception_print, exception_fprintf)
3541         (exception_print_same): Update.
3542         * exceptions.c (print_exception, exception_print)
3543         (exception_fprintf, exception_print_same): Change parameters to
3544         const reference.
3545         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
3546         * common/new-op.c: Use std::move.
3547         * common/common-exceptions.h (struct gdb_exception): Add move
3548         constructor.
3549         (struct gdb_exception_error, struct gdb_exception_quit, struct
3550         gdb_quit_bad_alloc): Change constructor to move constructor.
3551         (throw_exception): Change parameter to rvalue reference.
3552         * common/common-exceptions.c (throw_exception): Take rvalue
3553         reference.
3554         * cli/cli-interp.c (safe_execute_command): Use std::move.
3555         * breakpoint.c (insert_bp_location, location_to_sals): Use
3556         std::move.
3557
3558 2019-04-25  Tom Tromey  <tromey@adacore.com>
3559
3560         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
3561         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
3562         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
3563         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
3564         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
3565         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
3566         guile/scm-value.c: Use unpack.
3567         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
3568         gdbscm_gdb_exception.
3569         (gdbscm_throw_gdb_exception): Likewise.
3570         (struct gdbscm_gdb_exception): New.
3571         (unpack): New function.
3572         (gdbscm_wrap): Use unpack.
3573
3574 2019-04-25  Tom Tromey  <tromey@adacore.com>
3575
3576         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3577         (gdb_rl_callback_handler): Use std::move.
3578         * common/common-exceptions.h (struct gdb_exception): Add move
3579         assignment operator.
3580         (throw_exception_sjlj): Change "exception" to const reference.
3581         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
3582         (throw_exception_sjlj): Change "exception" to const reference.
3583
3584 2019-04-25  Tom Tromey  <tromey@adacore.com>
3585
3586         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
3587         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
3588         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3589         Update.
3590         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3591         Update.
3592         * mi/mi-interp.c (mi_interp::exec): Update.
3593         * linespec.c (parse_linespec): Update.
3594         * infcall.c (run_inferior_call): Update.
3595         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
3596         * guile/scm-symbol.c (gdbscm_lookup_symbol)
3597         (gdbscm_lookup_global_symbol): Update.
3598         * guile/scm-param.c (gdbscm_parameter_value): Update.
3599         * guile/scm-frame.c (gdbscm_frame_read_register)
3600         (gdbscm_frame_read_var): Update.
3601         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
3602         * exec.c (try_open_exec_file): Update.
3603         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3604         (gdb_rl_callback_handler): Update.
3605         * common/common-exceptions.h (exception_none): Don't declare.
3606         * common/common-exceptions.c (exception_none): Don't define.
3607         (struct catcher) <exception>: Update.
3608         * cli/cli-interp.c (safe_execute_command): Update.
3609         * breakpoint.c (insert_bp_location, location_to_sals): Update.
3610
3611 2019-04-25  Ali Tamur  <tamur@google.com>
3612
3613         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
3614         (read_attribute_value): Likewise.
3615         (dwarf2_read_addr_index): Update comment.
3616         (read_str_index): Add DW_FORM_strx.
3617         (dwarf2_string_attr): Likewise.
3618         (dwarf2_const_value_attr): Likewise.
3619         (dump_die_shallow): Likewise.
3620         (dwarf2_fetch_constant_bytes): Likewise.
3621         (skip_form_bytes): Likewise.
3622         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3623
3624 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
3625
3626         PR corefiles/11608
3627         PR corefiles/18187
3628         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3629         OFFSET.  Verify if current mapping contains an ELF header.
3630         (linux_find_memory_regions_full): Adjust call to
3631         dump_mapping_p.
3632
3633 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
3634             Kang Li <kanglictf@gmail.com>
3635
3636         PR gdb/21600
3637
3638         * dwarf2-frame.c (read_initial_length): Be consistent about using
3639         unsigned representation of length.
3640         (decode_frame_entry_1): Likewise.  Check for wraparound of
3641         end pointer as well as buffer overflow.
3642
3643 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3644
3645         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3646         "vq".
3647
3648 2019-04-24  Tom Tromey  <tromey@adacore.com>
3649
3650         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3651
3652 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3653
3654         * s12z-tdep.c (s12z_unwind_pc): Delete.
3655         (s12z_unwind_sp): Delete.
3656         (s12z_gdbarch_init): Don't register deleted functions with
3657         gdbarch.
3658
3659 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3660
3661         * rl78-tdep.c (rl78_unwind_sp): Delete.
3662         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3663
3664 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3665
3666         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3667         (xstormy16_unwind_pc): Delete.
3668         (xstormy16_dummy_id): Delete.
3669         (xstormy16_gdbarch_init): Don't register deleted functions with
3670         gdbarch.
3671
3672 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3673
3674         * vax-tdep.c (vax_unwind_pc): Delete.
3675         (vax_gdbarch_init): Don't register deleted function with gdbarch.
3676
3677 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3678
3679         * v850-tdep.c (v850_unwind_sp): Delete.
3680         (v850_unwind_pc): Delete.
3681         (v850_dummy_id): Delete.
3682         (v850_gdbarch_init): Don't register deleted functions with
3683         gdbarch.
3684
3685 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3686
3687         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
3688         (tilegx_unwind_pc): Delete.
3689         (tilegx_unwind_dummy_id): Delete.
3690         (tilegx_gdbarch_init): Don't register deleted functions with
3691         gdbarch.
3692
3693 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3694
3695         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
3696         (tic6x_dummy_id): Delete.
3697         (tic6x_gdbarch_init): Don't register deleted functions with
3698         gdbarch.
3699
3700 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3701
3702         * sparc-tdep.c (sparc_unwind_pc): Delete.
3703         (sparc32_gdbarch_init): Don't register deleted function with
3704         gdbarch.
3705
3706 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3707
3708         * sh-tdep.c (sh_unwind_sp): Delete.
3709         (sh_unwind_pc): Delete.
3710         (sh_dummy_id): Delete.
3711         (sh_gdbarch_init): Don't register deleted functions with
3712         gdbarch.
3713
3714 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3715
3716         * score-tdep.c (score_unwind_sp): Delete.
3717         (score_unwind_pc): Delete.
3718         (score_dummy_id): Delete.
3719         (score_gdbarch_init): Don't register deleted functions with
3720         gdbarch.
3721
3722 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3723
3724         * rx-tdep.c (rx_unwind_pc): Delete.
3725         (rx_unwind_sp): Delete.
3726         (rx_dummy_id): Delete.
3727         (rx_gdbarch_init): Don't register deleted functions with
3728         gdbarch.  Update comment.
3729
3730 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3731
3732         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
3733         (rs6000_dummy_id): Delete.
3734         (rs6000_gdbarch_init): Don't register deleted functions with
3735         gdbarch.
3736
3737 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3738
3739         * or1k-tdep.c (or1k_dummy_id): Delete.
3740         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
3741
3742 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3743
3744         * nios2-tdep.c (nios2_dummy_id): Delete.
3745         (nios2_unwind_sp): Delete.
3746         (nios2_gdbarch_init): Don't register deleted functions with
3747         gdbarch.
3748
3749 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3750
3751         * nds32-tdep.c (nds32_dummy_id): Delete.
3752         (nds32_unwind_pc): Delete.
3753         (nds32_unwind_sp): Delete.
3754         (nds32_gdbarch_init): Don't register deleted functions with
3755         gdbarch.
3756
3757 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3758
3759         * msp430-tdep.c (msp430_unwind_pc): Delete.
3760         (msp430_unwind_sp): Delete.
3761         (msp430_dummy_id): Delete.
3762         (msp430_gdbarch_init): Don't register deleted functions with
3763         gdbarch.
3764
3765 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3766
3767         * moxie-tdep.c (moxie_unwind_sp): Delete.
3768         (moxie_unwind_pc): Delete.
3769         (moxie_dummy_id): Delete.
3770         (moxie_gdbarch_init): Don't register deleted functions with
3771         gdbarch.
3772
3773 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3774
3775         * mn10300-tdep.c (mn10300_dummy_id): Delete.
3776         (mn10300_unwind_pc): Delete.
3777         (mn10300_unwind_sp): Delete.
3778         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
3779         mn10300_unwind_sp.
3780         (mn10300_frame_unwind_init): Don't register deleted functions with
3781         gdbarch.
3782
3783 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3784
3785         * mep-tdep.c (mep_unwind_pc): Delete.
3786         (mep_unwind_sp): Delete.
3787         (mep_dummy_id): Delete.
3788         (mep_gdbarch_init): Don't register deleted functions with
3789         gdbarch.
3790
3791 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3792
3793         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
3794         (m68hc11_unwind_sp): Delete.
3795         (m68hc11_gdbarch_init): Don't register deleted functions with
3796         gdbarch.
3797
3798 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3799
3800         * m32r-tdep.c (m32r_unwind_sp): Delete.
3801         (m32r_unwind_pc): Delete.
3802         (m32r_dummy_id): Delete.
3803         (m32r_gdbarch_init): Don't register deleted functions with
3804         gdbarch.
3805
3806 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3807
3808         * m32c-tdep.c (m32c_unwind_pc): Delete.
3809         (m32c_unwind_sp): Delete.
3810         (m32c_dummy_id): Delete.
3811         (m32c_gdbarch_init): Don't register deleted functions with
3812         gdbarch.
3813
3814 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3815
3816         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
3817         (lm32_unwind_pc): Delete.
3818         (lm32_dummy_id): Delete.
3819         (lm32_gdbarch_init): Don't register deleted functions with
3820         gdbarch.
3821
3822 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3823
3824         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
3825         (iq2000_unwind_pc): Delete.
3826         (iq2000_dummy_id): Delete.
3827         (iq2000_gdbarch_init): Don't register deleted functions with
3828         gdbarch.
3829
3830 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3831
3832         * nds32-tdep.c (nds32_type_align): Delete.
3833         (nds32_push_dummy_call): Use type_align instead.
3834
3835 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3836
3837         * arm-tdep.c (arm_type_align): Only handle vector override case.
3838         (arm_push_dummy_call): Use type_align.
3839         (arm_gdbarch_init): Register arm_type_align gdbarch function.
3840
3841 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3842
3843         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
3844         case.
3845         (pass_on_stack): Use type_align.
3846         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
3847         function.
3848
3849 2019-04-23  Tom Tromey  <tromey@adacore.com>
3850
3851         * dwarf2read.c (line_header::file_name_at): Remove unused
3852         overload.
3853
3854 2019-04-23  Tom de Vries  <tdevries@suse.de>
3855
3856         PR gdb/24438
3857         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
3858         invocation.
3859
3860
3861 2019-03-27  Ali Tamur  <tamur@google.com>
3862
3863         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
3864         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
3865         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
3866         (dwarf_expr_context::get_addr_index): Likewise
3867         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
3868         (symbol_needs_eval_context::get_addr_index): Likewise
3869         (disassemble_dwarf_expression): Add DW_OP_addrx
3870         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
3871         (read_cutu_die_from_dwo): Update comment
3872         (skip_one_die): Add DW_FORM_addrx
3873         (read_attribute_value): Likewise
3874         (var_decode_location): Add DW_OP_addrx
3875         (dwarf2_const_value_attr): Add DW_FORM_addrx
3876         (dump_die_shallow): Likewise
3877         (dwarf2_fetch_constant_bytes): Likewise
3878         (decode_locdesc): Add DW_OP_addrx
3879         (skip_form_bytes): Add DW_FORM_addrx
3880
3881 2019-04-22  Ali Tamur  <tamur@google.com>
3882
3883         * MAINTAINERS (Write After Approval): Add self.
3884
3885 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
3886
3887         * solib-svr4.c (get_svr4_info): Add pspace parameter.
3888         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
3889         (open_symbol_file_object): Likewise.
3890         (svr4_default_sos): Add info parameter.
3891         (svr4_read_so_list): Likewise.
3892         (svr4_current_sos_direct): Adjust functions calls to pass down
3893         info.
3894         (svr4_current_sos_1): Add info parameter.
3895         (svr4_current_sos): Call get_svr4_info, pass info down to
3896         svr4_current_sos_1.
3897         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
3898         get_svr4_info.
3899         (svr4_in_dynsym_resolve_code): Pass current_program_space to
3900         get_svr4_info.
3901         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
3902         to get_svr4_info.
3903         (probes_table_remove_objfile_probes): Likewise.
3904         (register_solib_event_probe): Add info parameter.
3905         (solist_update_incremental): Pass info parameter down to
3906         svr4_read_so_list.
3907         (disable_probes_interface): Add info parameter.
3908         (svr4_handle_solib_event): Pass current_program_space to
3909         get_svr4_info.  Adjust disable_probes_interface cleanup.
3910         (svr4_create_probe_breakpoints): Add info parameter, pass it
3911         down to register_solib_event_probe.
3912         (svr4_create_solib_event_breakpoints): Add info parameter,
3913         pass it down to svr4_create_probe_breakpoints.
3914         (enable_break): Pass info down to
3915         svr4_create_solib_event_breakpoints.
3916         (svr4_solib_create_inferior_hook): Pass current_program_space to
3917         get_svr4_info.
3918         (svr4_clear_solib): Likewise.
3919
3920 2019-04-22  Pedro Alves  <palves@redhat.com>
3921
3922         * solib-svr4.c (svr4_free_objfile_observer): New.
3923         (probe_and_action::objfile): New field.
3924         (probes_table_htab_remove_objfile_probes)
3925         (probes_table_remove_objfile_probes): New functions.
3926         (register_solib_event_probe): Add 'objfile' parameter.  Store it
3927         in the new probe_and_action.  Don't store the probe in 'lookup'.
3928         (svr4_create_probe_breakpoints): Pass objfile to
3929         register_solib_event_probe.
3930         (_initialize_svr4_solib): Register a free_objfile observer.
3931
3932 2019-04-19  Tom Tromey  <tom@tromey.com>
3933
3934         * common/queue.h: Remove.
3935
3936 2019-04-19  Tom Tromey  <tom@tromey.com>
3937
3938         * event-loop.c: Don't include "common/queue.h".
3939
3940 2019-04-19  Tom Tromey  <tom@tromey.com>
3941
3942         * remote.c (remote_target): Use delete.
3943         * remote-notif.h: Include <list>, not "common/queue.h".
3944         (notif_client_p): Remove typedef.
3945         (remote_notif_state): Add constructor, destructor, initializer.
3946         <notif_queue>: Now a std::list.
3947         (remote_notif_state_xfree): Don't declare.
3948         * remote-notif.c (remote_notif_process, handle_notification)
3949         (remote_notif_state_allocate): Update.
3950         (~remote_notif_state): Rename from remote_notif_state_xfree.
3951
3952 2019-04-19  Tom Tromey  <tom@tromey.com>
3953
3954         * symfile.c (reread_symbols): Update.
3955         * objfiles.c (objfile_register_static_link)
3956         (objfile_lookup_static_link): Update
3957         (~objfile) Don't delete static_links.
3958         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
3959
3960 2019-04-19  Tom Tromey  <tom@tromey.com>
3961
3962         * type-stack.h (struct type_stack) <insert>: Constify string.
3963         * type-stack.c (type_stack::insert): Constify string.
3964         * gdbtypes.h (lookup_template_type): Update.
3965         (address_space_name_to_int): Update.
3966         * gdbtypes.c (address_space_name_to_int): Make space_identifier
3967         const.
3968         (lookup_template_type): Make name const.
3969         * c-exp.y: Update rules.
3970         (lex_one_token, classify_name, classify_inner_name)
3971         (c_print_token): Update.
3972         * p-exp.y: Update rules.
3973         (yylex): Update.
3974         * f-exp.y: Update rules.
3975         (yylex): Update.
3976         * d-exp.y: Update rules.
3977         (lex_one_token, classify_name, classify_inner_name): Update.
3978         * parse.c (write_dollar_variable, copy_name): Return std::string.
3979         * parser-defs.h (copy_name): Change return type.
3980         * m2-exp.y: Update rules.
3981         (yylex): Update.
3982         * go-exp.y (lex_one_token): Update.
3983         Update rules.
3984         (classify_unsafe_function, classify_packaged_name)
3985         (classify_name, yylex): Update.
3986
3987 2019-04-19  Sergei Trofimovich <siarheit@google.com>
3988
3989         * configure.ac: add --enable-source-highlight switch.
3990         * configure: Regenerate.
3991         * top.c (print_gdb_version): plumb --enable-source-highlight
3992         status to "show configuration".
3993
3994 2019-04-19  Tom Tromey  <tromey@adacore.com>
3995
3996         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
3997         Check ADA_TYPE_P.
3998         (empty_record, ada_template_to_fixed_record_type_1)
3999         (template_to_static_fixed_type)
4000         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4001         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4002         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4003         macros.
4004
4005 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4006
4007         PR symtab/24423:
4008         * source.c (print_source_lines_base): Advance "iter" when a
4009         control character is seen.
4010
4011 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4012
4013         * inferior.h (struct infcall_suspend_state_deleter):
4014         Catch exception in destructor to avoid crash.
4015
4016 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4017
4018         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4019         close to the add_com "shell".
4020
4021 2019-04-18  Tom Tromey  <tromey@adacore.com>
4022
4023         * process-stratum-target.h (class process_stratum_target)
4024         <stratum>: Add "final".
4025
4026 2019-04-17  Tom Tromey  <tromey@adacore.com>
4027
4028         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4029         against nullptr before use.
4030
4031 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4032
4033         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4034
4035 2019-04-17  Jim Wilson  <jimw@sifive.com>
4036             Andrew Burgess  <andrew.burgess@embecosm.com>
4037
4038         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4039         code read might fail, assume 4-byte breakpoint in that case.
4040
4041 2019-04-15  Leszek Swirski  <leszeks@google.com>
4042
4043         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4044         rather than a hand-rolled POD check when checking for forced MEMORY
4045         classification.
4046
4047 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4048
4049         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4050         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4051         function.
4052         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4053         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4054         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4055         declaration.
4056
4057 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4058
4059         * aarch64-linux-nat.c
4060         (aarch64_linux_nat_target::thread_architecture): Add override.
4061         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4062         each VQ.
4063
4064 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4065
4066         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4067
4068 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4069
4070         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4071         target types of size 96-bits, add some additional comments, and
4072         check that the builtin type we found was the correct size.
4073
4074 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4075
4076         * utils.c (prompt_for_continue): Don't restore the styling at the
4077         end, as applied_style has the wrong value.  This fixes styling in
4078         long lists of file names that are interrupted by the "Continue?"
4079         prompt.
4080
4081 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4082
4083         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4084         * c-lang.c (c_language_defn): Likewise.
4085         (cplus_language_defn): Likewise.
4086         (asm_language_defn): Likewise.
4087         (minimal_language_defn): Likewise.
4088         * d-lang.c (d_language_defn): Likewise.
4089         * f-lang.c (f_language_defn): Likewise.
4090         * go-lang.c (go_language_defn): Likewise.
4091         * language.c (unknown_language_defn): Likewise.
4092         (auto_language_defn): Likewise.
4093         * language.h (struct language_defn): Remove la_magic field.
4094         (LANG_MAGIC): Delete.
4095         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4096         * objc-lang.c (objc_language_defn): Likewise.
4097         * opencl-lang.c (opencl_language_defn): Likewise.
4098         * p-lang.c (pascal_language_defn): Likewise.
4099         * rust-lang.c (rust_language_defn): Likewise.
4100
4101 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4102
4103         * riscv-tdep.c (riscv_type_align): New function.
4104         (riscv_type_alignment): Delete.
4105         (riscv_arg_location): Use 'type_align'.
4106         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4107
4108 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4109
4110         * gdbtypes.c (type_align): A struct with no non-static fields also
4111         has alignment of 1.
4112
4113 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4114
4115         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4116         component to 0.
4117         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4118         member.
4119         (riscv_struct_info::analyse): New implementation using new
4120         analyse_inner member function.
4121         (riscv_struct_info::field_offset): New member function.
4122         (riscv_struct_info::m_offsets): New member variable.
4123         (riscv_struct_info::analyse_inner): New private member function,
4124         takes the old implementation of riscv_struct_info::analyse but
4125         extended to track field offsets.
4126         (riscv_call_arg_struct): Update the struct folding special cases
4127         to handle cases where empty C++ structs, which are non-zero
4128         length, are found.
4129         (riscv_arg_location): Initialise the length of each location, a
4130         non-zero length now indicates the location is in use.
4131         (riscv_push_dummy_call): Allow for the first location having a
4132         non-zero offset when setting up arguments.
4133         (riscv_return_value): Likewise, but for return values.
4134
4135 2019-04-11  Tom Tromey  <tromey@adacore.com>
4136
4137         * utils.c (internal_vproblem): Make "msg" const.
4138
4139 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4140
4141         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4142         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4143         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4144         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4145
4146 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4147
4148         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4149         function.
4150         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4151         of amd64_collect_native_gregset.
4152         (amd64_linux_nat_target::store_registers): Likewise.
4153
4154 2019-04-10  Tom Tromey  <tom@tromey.com>
4155
4156         * symtab.c (lookup_global_symbol_from_objfile)
4157         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4158         * objfiles.h (class separate_debug_iterator): New.
4159         (class separate_debug_range): New.
4160         (struct objfile) <separate_debug_objfiles>: New method.
4161         (objfile_separate_debug_iterate): Don't declare.
4162         * objfiles.c (separate_debug_iterator::operator++): Rename from
4163         objfile_separate_debug_iterate.
4164         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4165         iterator.
4166         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4167         iterator.
4168
4169 2019-04-10  Tom Tromey  <tom@tromey.com>
4170
4171         * symfile.c (reread_symbols): Remove old comment.
4172         * objfiles.c (free_all_objfiles): Fix a typo.
4173
4174 2019-04-10  Tom Tromey  <tom@tromey.com>
4175
4176         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4177         * minsyms.c (lookup_minimal_symbol): Use foreach.
4178         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4179         (lookup_minimal_symbol_solib_trampoline): Likewise.
4180         * symfile.c (reread_symbols): Use foreach.
4181
4182 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4183             Tom Tromey  <tromey@adacore.com>
4184
4185         PR rust/24414:
4186         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4187         (rust_lex_int_test): Change "value" to be LONGEST.
4188         (rust_lex_tests): Add test for long integer literal.
4189
4190 2019-04-09  Tom Tromey  <tromey@adacore.com>
4191
4192         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4193         to bool.
4194         (extended_remote_target::attach): Update.
4195         (remote_target::remote_notice_new_inferior): Update.
4196         (remote_target::add_current_inferior_and_thread): Update.
4197         * inferior.c (exit_inferior_1): Use "false".
4198         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4199
4200 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4201
4202         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4203         the "start" command.
4204
4205 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4206
4207         * python/py-inferior.c (infpy_thread_from_thread_handle):
4208         Adjust comments to reflect renaming of thread_from_thread_handle
4209         to thread_from_handle.  Adjust keywords.  Fix type error message.
4210         (inferior_object_methods): Add thread_from_handle.  Retain
4211         thread_from_thread_handle, but mark it as deprecated.
4212
4213 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4214
4215         * gdbthread.h (find_thread_by_handle): Revise declaration.
4216         * thread.c (find_thread_by_handle): Likewise.  Adjust
4217         implementation too.
4218         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4219         support for buffer objects as handles.
4220
4221 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4222
4223         * python/py-infthread.c (thpy_thread_handle): New function.
4224         (thread_object_methods): Register thpy_thread_handle.
4225
4226 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4227
4228         * gdbthread.h (thread_to_thread_handle): Declare.
4229         * thread.c (gdbtypes.h): Include.
4230         (thread_to_thread_handle): New function.
4231
4232         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4233         (target_thread_info_to_thread_handle): Declare.
4234         * target.c (target_thread_info_to_thread_handle): New function.
4235         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4236         * target-delegates.c: Regenerate.
4237
4238         * linux-thread-db.c (class thread_db_target): Add method
4239         thread_info_to_thread_handle.
4240         (thread_db_target::thread_info_to_thread_handle): Define.
4241         * remote.c (class remote_target): Add new method
4242         thread_info_to_thread_handle.
4243         (remote_target::thread_info_to_thread_handle): Define.
4244
4245 2019-04-08  Pedro Alves  <palves@redhat.com>
4246
4247         * common/common-exceptions.c (throw_exception): Don't create
4248         named object to throw; throw directly.
4249         (throw_it): Likewise.  Don't initialize gdb_exception::message
4250         here, with new; pass FMT and AP to the ctor instead.
4251         * common/common-exceptions.h: Include <string>.
4252         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4253         const char *, va_list)): New ctor.  Use std::make_shared.
4254         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4255         errors)): Delete.
4256         (gdb_exception_error::gdb_exception_error(enum errors, const char
4257         *, va_list)): New.
4258         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4259         Add assertion.
4260         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4261         errors)): Delete.
4262         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4263         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4264         Add assertion.
4265
4266 2019-04-08  Tom Tromey  <tom@tromey.com>
4267
4268         * valops.c (value_rtti_indirect_type): Replace throw_exception
4269         with throw.
4270         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4271         with throw.
4272         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4273         throw.
4274         * target.c (target_translate_tls_address): Replace throw_exception
4275         with throw.
4276         * stack.c (frame_apply_command_count): Replace throw_exception
4277         with throw.
4278         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4279         throw.
4280         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4281         with throw.
4282         * rs6000-tdep.c (rs6000_frame_cache)
4283         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4284         * remote.c: Replace throw_exception with throw.
4285         * record-full.c (record_full_message, record_full_wait_1)
4286         (record_full_restore): Replace throw_exception with throw.
4287         * record-btrace.c:
4288         (get_thread_current_frame_id, record_btrace_start_replaying)
4289         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4290         (cmd_record_btrace_start): Replace throw_exception with throw.
4291         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4292         throw.
4293         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4294         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4295         * linespec.c:
4296         (find_linespec_symbols): Replace throw_exception with throw.
4297         * infrun.c (displaced_step_prepare, resume): Replace
4298         throw_exception with throw.
4299         * infcmd.c (post_create_inferior): Replace throw_exception with
4300         throw.
4301         * inf-loop.c (inferior_event_handler): Replace throw_exception
4302         with throw.
4303         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4304         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4305         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4306         (get_prev_frame_always, get_frame_pc_if_available)
4307         (get_frame_address_in_block_if_available, get_frame_language):
4308         Replace throw_exception with throw.
4309         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4310         throw_exception with throw.
4311         * eval.c (fetch_subexp_value, evaluate_var_value)
4312         (evaluate_funcall, evaluate_subexp_standard): Replace
4313         throw_exception with throw.
4314         * dwarf2loc.c (call_site_find_chain)
4315         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4316         Replace throw_exception with throw.
4317         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4318         with throw.
4319         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4320         throw.
4321         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4322         * completer.c (complete_line_internal): Replace throw_exception
4323         with throw.
4324         * compile/compile-object-run.c (compile_object_run): Replace
4325         throw_exception with throw.
4326         * cli/cli-script.c (process_next_line): Replace throw_exception
4327         with throw.
4328         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4329         (btrace_enable, btrace_maint_update_pt_packets): Replace
4330         throw_exception with throw.
4331         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4332         throw_exception with throw.
4333         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4334         throw_exception with throw.
4335         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4336         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4337         * aarch64-tdep.c (aarch64_make_prologue_cache)
4338         (aarch64_make_stub_cache): Replace throw_exception with throw.
4339
4340 2019-04-08  Tom Tromey  <tom@tromey.com>
4341
4342         * common/common-exceptions.c (throw_exception): Rename from
4343         throw_exception_cxx.  Remove old copy.  Make argument const.
4344         (throw_it): Create and throw exception objects directly.
4345         * common/common-exceptions.h (throw_exception): Make argument
4346         const.
4347         (struct gdb_exception_error): Add constructor.
4348         (struct gdb_exception_quit): Add constructor.
4349
4350 2019-04-08  Tom Tromey  <tom@tromey.com>
4351
4352         * common/common-exceptions.h (exception_rethrow): Don't declare.
4353         (TRY_SJLJ): Update comment.
4354         (TRY, CATCH, END_CATCH): Remove.
4355         * common/common-exceptions.c (exception_rethrow): Remove.
4356
4357 2019-04-08  Tom Tromey  <tom@tromey.com>
4358
4359         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4360         Remove.
4361         (gdb_exception_error): Rename from
4362         gdb_exception_RETURN_MASK_ERROR.
4363         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4364         (gdb_quit_bad_alloc): Update.
4365         * aarch64-tdep.c: Update.
4366         * ada-lang.c: Update.
4367         * ada-typeprint.c: Update.
4368         * ada-valprint.c: Update.
4369         * amd64-tdep.c: Update.
4370         * arch-utils.c: Update.
4371         * break-catch-throw.c: Update.
4372         * breakpoint.c: Update.
4373         * btrace.c: Update.
4374         * c-varobj.c: Update.
4375         * cli/cli-cmds.c: Update.
4376         * cli/cli-interp.c: Update.
4377         * cli/cli-script.c: Update.
4378         * common/common-exceptions.c: Update.
4379         * common/new-op.c: Update.
4380         * common/selftest.c: Update.
4381         * compile/compile-c-symbols.c: Update.
4382         * compile/compile-cplus-symbols.c: Update.
4383         * compile/compile-object-load.c: Update.
4384         * compile/compile-object-run.c: Update.
4385         * completer.c: Update.
4386         * corelow.c: Update.
4387         * cp-abi.c: Update.
4388         * cp-support.c: Update.
4389         * cp-valprint.c: Update.
4390         * darwin-nat.c: Update.
4391         * disasm-selftests.c: Update.
4392         * dtrace-probe.c: Update.
4393         * dwarf-index-cache.c: Update.
4394         * dwarf-index-write.c: Update.
4395         * dwarf2-frame-tailcall.c: Update.
4396         * dwarf2-frame.c: Update.
4397         * dwarf2loc.c: Update.
4398         * dwarf2read.c: Update.
4399         * eval.c: Update.
4400         * event-loop.c: Update.
4401         * event-top.c: Update.
4402         * exec.c: Update.
4403         * f-valprint.c: Update.
4404         * fbsd-tdep.c: Update.
4405         * frame-unwind.c: Update.
4406         * frame.c: Update.
4407         * gdbtypes.c: Update.
4408         * gnu-v3-abi.c: Update.
4409         * guile/guile-internal.h: Update.
4410         * guile/scm-block.c: Update.
4411         * guile/scm-breakpoint.c: Update.
4412         * guile/scm-cmd.c: Update.
4413         * guile/scm-disasm.c: Update.
4414         * guile/scm-frame.c: Update.
4415         * guile/scm-lazy-string.c: Update.
4416         * guile/scm-math.c: Update.
4417         * guile/scm-param.c: Update.
4418         * guile/scm-ports.c: Update.
4419         * guile/scm-pretty-print.c: Update.
4420         * guile/scm-symbol.c: Update.
4421         * guile/scm-symtab.c: Update.
4422         * guile/scm-type.c: Update.
4423         * guile/scm-value.c: Update.
4424         * i386-linux-tdep.c: Update.
4425         * i386-tdep.c: Update.
4426         * inf-loop.c: Update.
4427         * infcall.c: Update.
4428         * infcmd.c: Update.
4429         * infrun.c: Update.
4430         * jit.c: Update.
4431         * language.c: Update.
4432         * linespec.c: Update.
4433         * linux-fork.c: Update.
4434         * linux-nat.c: Update.
4435         * linux-tdep.c: Update.
4436         * linux-thread-db.c: Update.
4437         * main.c: Update.
4438         * mi/mi-cmd-break.c: Update.
4439         * mi/mi-cmd-stack.c: Update.
4440         * mi/mi-interp.c: Update.
4441         * mi/mi-main.c: Update.
4442         * objc-lang.c: Update.
4443         * p-valprint.c: Update.
4444         * parse.c: Update.
4445         * ppc-linux-tdep.c: Update.
4446         * printcmd.c: Update.
4447         * python/py-arch.c: Update.
4448         * python/py-breakpoint.c: Update.
4449         * python/py-cmd.c: Update.
4450         * python/py-finishbreakpoint.c: Update.
4451         * python/py-frame.c: Update.
4452         * python/py-framefilter.c: Update.
4453         * python/py-gdb-readline.c: Update.
4454         * python/py-inferior.c: Update.
4455         * python/py-infthread.c: Update.
4456         * python/py-lazy-string.c: Update.
4457         * python/py-linetable.c: Update.
4458         * python/py-objfile.c: Update.
4459         * python/py-param.c: Update.
4460         * python/py-prettyprint.c: Update.
4461         * python/py-progspace.c: Update.
4462         * python/py-record-btrace.c: Update.
4463         * python/py-record.c: Update.
4464         * python/py-symbol.c: Update.
4465         * python/py-type.c: Update.
4466         * python/py-unwind.c: Update.
4467         * python/py-utils.c: Update.
4468         * python/py-value.c: Update.
4469         * python/python.c: Update.
4470         * record-btrace.c: Update.
4471         * record-full.c: Update.
4472         * remote-fileio.c: Update.
4473         * remote.c: Update.
4474         * riscv-tdep.c: Update.
4475         * rs6000-aix-tdep.c: Update.
4476         * rs6000-tdep.c: Update.
4477         * rust-exp.y: Update.
4478         * rust-lang.c: Update.
4479         * s390-tdep.c: Update.
4480         * selftest-arch.c: Update.
4481         * solib-dsbt.c: Update.
4482         * solib-frv.c: Update.
4483         * solib-spu.c: Update.
4484         * solib-svr4.c: Update.
4485         * solib.c: Update.
4486         * sparc64-linux-tdep.c: Update.
4487         * stack.c: Update.
4488         * symfile-mem.c: Update.
4489         * symmisc.c: Update.
4490         * target.c: Update.
4491         * thread.c: Update.
4492         * top.c: Update.
4493         * tracefile-tfile.c: Update.
4494         * tui/tui.c: Update.
4495         * typeprint.c: Update.
4496         * unittests/cli-utils-selftests.c: Update.
4497         * unittests/parse-connection-spec-selftests.c: Update.
4498         * valops.c: Update.
4499         * valprint.c: Update.
4500         * value.c: Update.
4501         * varobj.c: Update.
4502         * windows-nat.c: Update.
4503         * x86-linux-nat.c: Update.
4504         * xml-support.c: Update.
4505
4506 2019-04-08  Tom Tromey  <tom@tromey.com>
4507
4508         * xml-support.c: Use C++ exception handling.
4509         * x86-linux-nat.c: Use C++ exception handling.
4510         * windows-nat.c: Use C++ exception handling.
4511         * varobj.c: Use C++ exception handling.
4512         * value.c: Use C++ exception handling.
4513         * valprint.c: Use C++ exception handling.
4514         * valops.c: Use C++ exception handling.
4515         * unittests/parse-connection-spec-selftests.c: Use C++ exception
4516         handling.
4517         * unittests/cli-utils-selftests.c: Use C++ exception handling.
4518         * typeprint.c: Use C++ exception handling.
4519         * tui/tui.c: Use C++ exception handling.
4520         * tracefile-tfile.c: Use C++ exception handling.
4521         * top.c: Use C++ exception handling.
4522         * thread.c: Use C++ exception handling.
4523         * target.c: Use C++ exception handling.
4524         * symmisc.c: Use C++ exception handling.
4525         * symfile-mem.c: Use C++ exception handling.
4526         * stack.c: Use C++ exception handling.
4527         * sparc64-linux-tdep.c: Use C++ exception handling.
4528         * solib.c: Use C++ exception handling.
4529         * solib-svr4.c: Use C++ exception handling.
4530         * solib-spu.c: Use C++ exception handling.
4531         * solib-frv.c: Use C++ exception handling.
4532         * solib-dsbt.c: Use C++ exception handling.
4533         * selftest-arch.c: Use C++ exception handling.
4534         * s390-tdep.c: Use C++ exception handling.
4535         * rust-lang.c: Use C++ exception handling.
4536         * rust-exp.y: Use C++ exception handling.
4537         * rs6000-tdep.c: Use C++ exception handling.
4538         * rs6000-aix-tdep.c: Use C++ exception handling.
4539         * riscv-tdep.c: Use C++ exception handling.
4540         * remote.c: Use C++ exception handling.
4541         * remote-fileio.c: Use C++ exception handling.
4542         * record-full.c: Use C++ exception handling.
4543         * record-btrace.c: Use C++ exception handling.
4544         * python/python.c: Use C++ exception handling.
4545         * python/py-value.c: Use C++ exception handling.
4546         * python/py-utils.c: Use C++ exception handling.
4547         * python/py-unwind.c: Use C++ exception handling.
4548         * python/py-type.c: Use C++ exception handling.
4549         * python/py-symbol.c: Use C++ exception handling.
4550         * python/py-record.c: Use C++ exception handling.
4551         * python/py-record-btrace.c: Use C++ exception handling.
4552         * python/py-progspace.c: Use C++ exception handling.
4553         * python/py-prettyprint.c: Use C++ exception handling.
4554         * python/py-param.c: Use C++ exception handling.
4555         * python/py-objfile.c: Use C++ exception handling.
4556         * python/py-linetable.c: Use C++ exception handling.
4557         * python/py-lazy-string.c: Use C++ exception handling.
4558         * python/py-infthread.c: Use C++ exception handling.
4559         * python/py-inferior.c: Use C++ exception handling.
4560         * python/py-gdb-readline.c: Use C++ exception handling.
4561         * python/py-framefilter.c: Use C++ exception handling.
4562         * python/py-frame.c: Use C++ exception handling.
4563         * python/py-finishbreakpoint.c: Use C++ exception handling.
4564         * python/py-cmd.c: Use C++ exception handling.
4565         * python/py-breakpoint.c: Use C++ exception handling.
4566         * python/py-arch.c: Use C++ exception handling.
4567         * printcmd.c: Use C++ exception handling.
4568         * ppc-linux-tdep.c: Use C++ exception handling.
4569         * parse.c: Use C++ exception handling.
4570         * p-valprint.c: Use C++ exception handling.
4571         * objc-lang.c: Use C++ exception handling.
4572         * mi/mi-main.c: Use C++ exception handling.
4573         * mi/mi-interp.c: Use C++ exception handling.
4574         * mi/mi-cmd-stack.c: Use C++ exception handling.
4575         * mi/mi-cmd-break.c: Use C++ exception handling.
4576         * main.c: Use C++ exception handling.
4577         * linux-thread-db.c: Use C++ exception handling.
4578         * linux-tdep.c: Use C++ exception handling.
4579         * linux-nat.c: Use C++ exception handling.
4580         * linux-fork.c: Use C++ exception handling.
4581         * linespec.c: Use C++ exception handling.
4582         * language.c: Use C++ exception handling.
4583         * jit.c: Use C++ exception handling.
4584         * infrun.c: Use C++ exception handling.
4585         * infcmd.c: Use C++ exception handling.
4586         * infcall.c: Use C++ exception handling.
4587         * inf-loop.c: Use C++ exception handling.
4588         * i386-tdep.c: Use C++ exception handling.
4589         * i386-linux-tdep.c: Use C++ exception handling.
4590         * guile/scm-value.c: Use C++ exception handling.
4591         * guile/scm-type.c: Use C++ exception handling.
4592         * guile/scm-symtab.c: Use C++ exception handling.
4593         * guile/scm-symbol.c: Use C++ exception handling.
4594         * guile/scm-pretty-print.c: Use C++ exception handling.
4595         * guile/scm-ports.c: Use C++ exception handling.
4596         * guile/scm-param.c: Use C++ exception handling.
4597         * guile/scm-math.c: Use C++ exception handling.
4598         * guile/scm-lazy-string.c: Use C++ exception handling.
4599         * guile/scm-frame.c: Use C++ exception handling.
4600         * guile/scm-disasm.c: Use C++ exception handling.
4601         * guile/scm-cmd.c: Use C++ exception handling.
4602         * guile/scm-breakpoint.c: Use C++ exception handling.
4603         * guile/scm-block.c: Use C++ exception handling.
4604         * guile/guile-internal.h: Use C++ exception handling.
4605         * gnu-v3-abi.c: Use C++ exception handling.
4606         * gdbtypes.c: Use C++ exception handling.
4607         * frame.c: Use C++ exception handling.
4608         * frame-unwind.c: Use C++ exception handling.
4609         * fbsd-tdep.c: Use C++ exception handling.
4610         * f-valprint.c: Use C++ exception handling.
4611         * exec.c: Use C++ exception handling.
4612         * event-top.c: Use C++ exception handling.
4613         * event-loop.c: Use C++ exception handling.
4614         * eval.c: Use C++ exception handling.
4615         * dwarf2read.c: Use C++ exception handling.
4616         * dwarf2loc.c: Use C++ exception handling.
4617         * dwarf2-frame.c: Use C++ exception handling.
4618         * dwarf2-frame-tailcall.c: Use C++ exception handling.
4619         * dwarf-index-write.c: Use C++ exception handling.
4620         * dwarf-index-cache.c: Use C++ exception handling.
4621         * dtrace-probe.c: Use C++ exception handling.
4622         * disasm-selftests.c: Use C++ exception handling.
4623         * darwin-nat.c: Use C++ exception handling.
4624         * cp-valprint.c: Use C++ exception handling.
4625         * cp-support.c: Use C++ exception handling.
4626         * cp-abi.c: Use C++ exception handling.
4627         * corelow.c: Use C++ exception handling.
4628         * completer.c: Use C++ exception handling.
4629         * compile/compile-object-run.c: Use C++ exception handling.
4630         * compile/compile-object-load.c: Use C++ exception handling.
4631         * compile/compile-cplus-symbols.c: Use C++ exception handling.
4632         * compile/compile-c-symbols.c: Use C++ exception handling.
4633         * common/selftest.c: Use C++ exception handling.
4634         * common/new-op.c: Use C++ exception handling.
4635         * cli/cli-script.c: Use C++ exception handling.
4636         * cli/cli-interp.c: Use C++ exception handling.
4637         * cli/cli-cmds.c: Use C++ exception handling.
4638         * c-varobj.c: Use C++ exception handling.
4639         * btrace.c: Use C++ exception handling.
4640         * breakpoint.c: Use C++ exception handling.
4641         * break-catch-throw.c: Use C++ exception handling.
4642         * arch-utils.c: Use C++ exception handling.
4643         * amd64-tdep.c: Use C++ exception handling.
4644         * ada-valprint.c: Use C++ exception handling.
4645         * ada-typeprint.c: Use C++ exception handling.
4646         * ada-lang.c: Use C++ exception handling.
4647         * aarch64-tdep.c: Use C++ exception handling.
4648
4649 2019-04-08  Tom Tromey  <tom@tromey.com>
4650
4651         * xml-support.c (gdb_xml_parser::parse): Update.
4652         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4653         * value.c (show_convenience): Update.
4654         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4655         (test_parse_flags_qcs): Update.
4656         * thread.c (thr_try_catch_cmd): Update.
4657         * target.c (target_translate_tls_address): Update.
4658         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4659         (info_frame_command_core, frame_apply_command_count): Update.
4660         * rust-exp.y (rust_lex_exception_test): Update.
4661         * riscv-tdep.c (riscv_print_one_register_info): Update.
4662         * remote.c (remote_target::enable_btrace): Update.
4663         * record-btrace.c (record_btrace_enable_warn): Update.
4664         * python/py-utils.c (gdbpy_convert_exception): Update.
4665         * printcmd.c (do_one_display, print_variable_and_value): Update.
4666         * mi/mi-main.c (mi_print_exception): Update.
4667         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4668         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4669         * linux-nat.c (linux_nat_target::attach): Update.
4670         * linux-fork.c (class scoped_switch_fork_info): Update.
4671         * infrun.c (displaced_step_prepare): Update.
4672         * infcall.c (call_function_by_hand_dummy): Update.
4673         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4674         * gnu-v3-abi.c (print_one_vtable): Update.
4675         * frame.c (get_prev_frame_always): Update.
4676         * f-valprint.c (info_common_command_for_block): Update.
4677         * exec.c (try_open_exec_file): Update.
4678         * exceptions.c (print_exception, exception_print)
4679         (exception_fprintf, exception_print_same): Update.
4680         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4681         * dwarf-index-cache.c (index_cache::store)
4682         (index_cache::lookup_gdb_index): Update.
4683         * darwin-nat.c (maybe_cache_shell): Update.
4684         * cp-valprint.c (cp_print_value_fields): Update.
4685         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4686         (gcc_cplus_symbol_address): Update.
4687         * compile/compile-c-symbols.c (gcc_convert_symbol)
4688         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
4689         * common/selftest.c: Update.
4690         * common/common-exceptions.h (struct gdb_exception) <message>: Now
4691         a std::string.
4692         (exception_try_scope_entry, exception_try_scope_exit): Don't
4693         declare.
4694         (struct exception_try_scope): Remove.
4695         (TRY): Don't use exception_try_scope.
4696         (struct gdb_exception): Add constructor, operator=.
4697         <what>: New method.
4698         (struct gdb_exception_RETURN_MASK_ALL)
4699         (struct gdb_exception_RETURN_MASK_ERROR)
4700         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
4701         (struct gdb_quit_bad_alloc): Update.
4702         * common/common-exceptions.c (exception_none): Change
4703         initializer.
4704         (struct catcher) <state, exception>: Initialize inline.
4705         <prev>: Remove member.
4706         (current_catcher): Remove.
4707         (catchers): New global.
4708         (exceptions_state_mc_init): Simplify.
4709         (catcher_pop): Remove.
4710         (exceptions_state_mc, exceptions_state_mc_catch): Update.
4711         (try_scope_depth, exception_try_scope_entry)
4712         (exception_try_scope_exit): Remove.
4713         (throw_exception_sjlj): Update.
4714         (exception_messages, exception_messages_size): Remove.
4715         (throw_it): Simplify.
4716         (gdb_exception_sliced_copy): Remove.
4717         (throw_exception_cxx): Update.
4718         * cli/cli-script.c (script_from_file): Update.
4719         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
4720         Update.
4721         * ada-valprint.c (ada_val_print): Update.
4722         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
4723         (create_excep_cond_exprs): Update.
4724
4725 2019-04-08  Tom Tromey  <tom@tromey.com>
4726
4727         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
4728         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
4729         (TRY, CATCH, END_CATCH): Remove some definitions.
4730         * common/common-exceptions.c: Don't use GDB_XCPT.
4731         (catcher_list_size): Remove.
4732         (throw_exception, throw_it): Simplify.
4733
4734 2019-04-05  Tom Tromey  <tom@tromey.com>
4735
4736         Revert the header-sorting patch.
4737         * ft32-tdep.c: Revert.
4738         * frv-tdep.c: Revert.
4739         * frv-linux-tdep.c: Revert.
4740         * frame.c: Revert.
4741         * frame-unwind.c: Revert.
4742         * frame-base.c: Revert.
4743         * fork-child.c: Revert.
4744         * findvar.c: Revert.
4745         * findcmd.c: Revert.
4746         * filesystem.c: Revert.
4747         * filename-seen-cache.h: Revert.
4748         * filename-seen-cache.c: Revert.
4749         * fbsd-tdep.c: Revert.
4750         * fbsd-nat.h: Revert.
4751         * fbsd-nat.c: Revert.
4752         * f-valprint.c: Revert.
4753         * f-typeprint.c: Revert.
4754         * f-lang.c: Revert.
4755         * extension.h: Revert.
4756         * extension.c: Revert.
4757         * extension-priv.h: Revert.
4758         * expprint.c: Revert.
4759         * exec.h: Revert.
4760         * exec.c: Revert.
4761         * exceptions.c: Revert.
4762         * event-top.c: Revert.
4763         * event-loop.c: Revert.
4764         * eval.c: Revert.
4765         * elfread.c: Revert.
4766         * dwarf2read.h: Revert.
4767         * dwarf2read.c: Revert.
4768         * dwarf2loc.c: Revert.
4769         * dwarf2expr.h: Revert.
4770         * dwarf2expr.c: Revert.
4771         * dwarf2-frame.c: Revert.
4772         * dwarf2-frame-tailcall.c: Revert.
4773         * dwarf-index-write.h: Revert.
4774         * dwarf-index-write.c: Revert.
4775         * dwarf-index-common.c: Revert.
4776         * dwarf-index-cache.h: Revert.
4777         * dwarf-index-cache.c: Revert.
4778         * dummy-frame.c: Revert.
4779         * dtrace-probe.c: Revert.
4780         * disasm.h: Revert.
4781         * disasm.c: Revert.
4782         * disasm-selftests.c: Revert.
4783         * dictionary.c: Revert.
4784         * dicos-tdep.c: Revert.
4785         * demangle.c: Revert.
4786         * dcache.h: Revert.
4787         * dcache.c: Revert.
4788         * darwin-nat.h: Revert.
4789         * darwin-nat.c: Revert.
4790         * darwin-nat-info.c: Revert.
4791         * d-valprint.c: Revert.
4792         * d-namespace.c: Revert.
4793         * d-lang.c: Revert.
4794         * ctf.c: Revert.
4795         * csky-tdep.c: Revert.
4796         * csky-linux-tdep.c: Revert.
4797         * cris-tdep.c: Revert.
4798         * cris-linux-tdep.c: Revert.
4799         * cp-valprint.c: Revert.
4800         * cp-support.c: Revert.
4801         * cp-namespace.c: Revert.
4802         * cp-abi.c: Revert.
4803         * corelow.c: Revert.
4804         * corefile.c: Revert.
4805         * continuations.c: Revert.
4806         * completer.h: Revert.
4807         * completer.c: Revert.
4808         * complaints.c: Revert.
4809         * coffread.c: Revert.
4810         * coff-pe-read.c: Revert.
4811         * cli-out.h: Revert.
4812         * cli-out.c: Revert.
4813         * charset.c: Revert.
4814         * c-varobj.c: Revert.
4815         * c-valprint.c: Revert.
4816         * c-typeprint.c: Revert.
4817         * c-lang.c: Revert.
4818         * buildsym.c: Revert.
4819         * buildsym-legacy.c: Revert.
4820         * build-id.h: Revert.
4821         * build-id.c: Revert.
4822         * btrace.c: Revert.
4823         * bsd-uthread.c: Revert.
4824         * breakpoint.h: Revert.
4825         * breakpoint.c: Revert.
4826         * break-catch-throw.c: Revert.
4827         * break-catch-syscall.c: Revert.
4828         * break-catch-sig.c: Revert.
4829         * blockframe.c: Revert.
4830         * block.c: Revert.
4831         * bfin-tdep.c: Revert.
4832         * bfin-linux-tdep.c: Revert.
4833         * bfd-target.c: Revert.
4834         * bcache.c: Revert.
4835         * ax-general.c: Revert.
4836         * ax-gdb.h: Revert.
4837         * ax-gdb.c: Revert.
4838         * avr-tdep.c: Revert.
4839         * auxv.c: Revert.
4840         * auto-load.c: Revert.
4841         * arm-wince-tdep.c: Revert.
4842         * arm-tdep.c: Revert.
4843         * arm-symbian-tdep.c: Revert.
4844         * arm-pikeos-tdep.c: Revert.
4845         * arm-obsd-tdep.c: Revert.
4846         * arm-nbsd-tdep.c: Revert.
4847         * arm-nbsd-nat.c: Revert.
4848         * arm-linux-tdep.c: Revert.
4849         * arm-linux-nat.c: Revert.
4850         * arm-fbsd-tdep.c: Revert.
4851         * arm-fbsd-nat.c: Revert.
4852         * arm-bsd-tdep.c: Revert.
4853         * arch-utils.c: Revert.
4854         * arc-tdep.c: Revert.
4855         * arc-newlib-tdep.c: Revert.
4856         * annotate.h: Revert.
4857         * annotate.c: Revert.
4858         * amd64-windows-tdep.c: Revert.
4859         * amd64-windows-nat.c: Revert.
4860         * amd64-tdep.c: Revert.
4861         * amd64-sol2-tdep.c: Revert.
4862         * amd64-obsd-tdep.c: Revert.
4863         * amd64-obsd-nat.c: Revert.
4864         * amd64-nbsd-tdep.c: Revert.
4865         * amd64-nbsd-nat.c: Revert.
4866         * amd64-nat.c: Revert.
4867         * amd64-linux-tdep.c: Revert.
4868         * amd64-linux-nat.c: Revert.
4869         * amd64-fbsd-tdep.c: Revert.
4870         * amd64-fbsd-nat.c: Revert.
4871         * amd64-dicos-tdep.c: Revert.
4872         * amd64-darwin-tdep.c: Revert.
4873         * amd64-bsd-nat.c: Revert.
4874         * alpha-tdep.c: Revert.
4875         * alpha-obsd-tdep.c: Revert.
4876         * alpha-nbsd-tdep.c: Revert.
4877         * alpha-mdebug-tdep.c: Revert.
4878         * alpha-linux-tdep.c: Revert.
4879         * alpha-linux-nat.c: Revert.
4880         * alpha-bsd-tdep.c: Revert.
4881         * alpha-bsd-nat.c: Revert.
4882         * aix-thread.c: Revert.
4883         * agent.c: Revert.
4884         * addrmap.c: Revert.
4885         * ada-varobj.c: Revert.
4886         * ada-valprint.c: Revert.
4887         * ada-typeprint.c: Revert.
4888         * ada-tasks.c: Revert.
4889         * ada-lang.c: Revert.
4890         * aarch64-tdep.c: Revert.
4891         * aarch64-ravenscar-thread.c: Revert.
4892         * aarch64-newlib-tdep.c: Revert.
4893         * aarch64-linux-tdep.c: Revert.
4894         * aarch64-linux-nat.c: Revert.
4895         * aarch64-fbsd-tdep.c: Revert.
4896         * aarch64-fbsd-nat.c: Revert.
4897         * aarch32-linux-nat.c: Revert.
4898
4899 2019-04-05  Tom Tromey  <tom@tromey.com>
4900
4901         * ft32-tdep.c: Sort headers.
4902         * frv-tdep.c: Sort headers.
4903         * frv-linux-tdep.c: Sort headers.
4904         * frame.c: Sort headers.
4905         * frame-unwind.c: Sort headers.
4906         * frame-base.c: Sort headers.
4907         * fork-child.c: Sort headers.
4908         * findvar.c: Sort headers.
4909         * findcmd.c: Sort headers.
4910         * filesystem.c: Sort headers.
4911         * filename-seen-cache.h: Sort headers.
4912         * filename-seen-cache.c: Sort headers.
4913         * fbsd-tdep.c: Sort headers.
4914         * fbsd-nat.h: Sort headers.
4915         * fbsd-nat.c: Sort headers.
4916         * f-valprint.c: Sort headers.
4917         * f-typeprint.c: Sort headers.
4918         * f-lang.c: Sort headers.
4919         * extension.h: Sort headers.
4920         * extension.c: Sort headers.
4921         * extension-priv.h: Sort headers.
4922         * expprint.c: Sort headers.
4923         * exec.h: Sort headers.
4924         * exec.c: Sort headers.
4925         * exceptions.c: Sort headers.
4926         * event-top.c: Sort headers.
4927         * event-loop.c: Sort headers.
4928         * eval.c: Sort headers.
4929         * elfread.c: Sort headers.
4930         * dwarf2read.h: Sort headers.
4931         * dwarf2read.c: Sort headers.
4932         * dwarf2loc.c: Sort headers.
4933         * dwarf2expr.h: Sort headers.
4934         * dwarf2expr.c: Sort headers.
4935         * dwarf2-frame.c: Sort headers.
4936         * dwarf2-frame-tailcall.c: Sort headers.
4937         * dwarf-index-write.h: Sort headers.
4938         * dwarf-index-write.c: Sort headers.
4939         * dwarf-index-common.c: Sort headers.
4940         * dwarf-index-cache.h: Sort headers.
4941         * dwarf-index-cache.c: Sort headers.
4942         * dummy-frame.c: Sort headers.
4943         * dtrace-probe.c: Sort headers.
4944         * disasm.h: Sort headers.
4945         * disasm.c: Sort headers.
4946         * disasm-selftests.c: Sort headers.
4947         * dictionary.c: Sort headers.
4948         * dicos-tdep.c: Sort headers.
4949         * demangle.c: Sort headers.
4950         * dcache.h: Sort headers.
4951         * dcache.c: Sort headers.
4952         * darwin-nat.h: Sort headers.
4953         * darwin-nat.c: Sort headers.
4954         * darwin-nat-info.c: Sort headers.
4955         * d-valprint.c: Sort headers.
4956         * d-namespace.c: Sort headers.
4957         * d-lang.c: Sort headers.
4958         * ctf.c: Sort headers.
4959         * csky-tdep.c: Sort headers.
4960         * csky-linux-tdep.c: Sort headers.
4961         * cris-tdep.c: Sort headers.
4962         * cris-linux-tdep.c: Sort headers.
4963         * cp-valprint.c: Sort headers.
4964         * cp-support.c: Sort headers.
4965         * cp-namespace.c: Sort headers.
4966         * cp-abi.c: Sort headers.
4967         * corelow.c: Sort headers.
4968         * corefile.c: Sort headers.
4969         * continuations.c: Sort headers.
4970         * completer.h: Sort headers.
4971         * completer.c: Sort headers.
4972         * complaints.c: Sort headers.
4973         * coffread.c: Sort headers.
4974         * coff-pe-read.c: Sort headers.
4975         * cli-out.h: Sort headers.
4976         * cli-out.c: Sort headers.
4977         * charset.c: Sort headers.
4978         * c-varobj.c: Sort headers.
4979         * c-valprint.c: Sort headers.
4980         * c-typeprint.c: Sort headers.
4981         * c-lang.c: Sort headers.
4982         * buildsym.c: Sort headers.
4983         * buildsym-legacy.c: Sort headers.
4984         * build-id.h: Sort headers.
4985         * build-id.c: Sort headers.
4986         * btrace.c: Sort headers.
4987         * bsd-uthread.c: Sort headers.
4988         * breakpoint.h: Sort headers.
4989         * breakpoint.c: Sort headers.
4990         * break-catch-throw.c: Sort headers.
4991         * break-catch-syscall.c: Sort headers.
4992         * break-catch-sig.c: Sort headers.
4993         * blockframe.c: Sort headers.
4994         * block.c: Sort headers.
4995         * bfin-tdep.c: Sort headers.
4996         * bfin-linux-tdep.c: Sort headers.
4997         * bfd-target.c: Sort headers.
4998         * bcache.c: Sort headers.
4999         * ax-general.c: Sort headers.
5000         * ax-gdb.h: Sort headers.
5001         * ax-gdb.c: Sort headers.
5002         * avr-tdep.c: Sort headers.
5003         * auxv.c: Sort headers.
5004         * auto-load.c: Sort headers.
5005         * arm-wince-tdep.c: Sort headers.
5006         * arm-tdep.c: Sort headers.
5007         * arm-symbian-tdep.c: Sort headers.
5008         * arm-pikeos-tdep.c: Sort headers.
5009         * arm-obsd-tdep.c: Sort headers.
5010         * arm-nbsd-tdep.c: Sort headers.
5011         * arm-nbsd-nat.c: Sort headers.
5012         * arm-linux-tdep.c: Sort headers.
5013         * arm-linux-nat.c: Sort headers.
5014         * arm-fbsd-tdep.c: Sort headers.
5015         * arm-fbsd-nat.c: Sort headers.
5016         * arm-bsd-tdep.c: Sort headers.
5017         * arch-utils.c: Sort headers.
5018         * arc-tdep.c: Sort headers.
5019         * arc-newlib-tdep.c: Sort headers.
5020         * annotate.h: Sort headers.
5021         * annotate.c: Sort headers.
5022         * amd64-windows-tdep.c: Sort headers.
5023         * amd64-windows-nat.c: Sort headers.
5024         * amd64-tdep.c: Sort headers.
5025         * amd64-sol2-tdep.c: Sort headers.
5026         * amd64-obsd-tdep.c: Sort headers.
5027         * amd64-obsd-nat.c: Sort headers.
5028         * amd64-nbsd-tdep.c: Sort headers.
5029         * amd64-nbsd-nat.c: Sort headers.
5030         * amd64-nat.c: Sort headers.
5031         * amd64-linux-tdep.c: Sort headers.
5032         * amd64-linux-nat.c: Sort headers.
5033         * amd64-fbsd-tdep.c: Sort headers.
5034         * amd64-fbsd-nat.c: Sort headers.
5035         * amd64-dicos-tdep.c: Sort headers.
5036         * amd64-darwin-tdep.c: Sort headers.
5037         * amd64-bsd-nat.c: Sort headers.
5038         * alpha-tdep.c: Sort headers.
5039         * alpha-obsd-tdep.c: Sort headers.
5040         * alpha-nbsd-tdep.c: Sort headers.
5041         * alpha-mdebug-tdep.c: Sort headers.
5042         * alpha-linux-tdep.c: Sort headers.
5043         * alpha-linux-nat.c: Sort headers.
5044         * alpha-bsd-tdep.c: Sort headers.
5045         * alpha-bsd-nat.c: Sort headers.
5046         * aix-thread.c: Sort headers.
5047         * agent.c: Sort headers.
5048         * addrmap.c: Sort headers.
5049         * ada-varobj.c: Sort headers.
5050         * ada-valprint.c: Sort headers.
5051         * ada-typeprint.c: Sort headers.
5052         * ada-tasks.c: Sort headers.
5053         * ada-lang.c: Sort headers.
5054         * aarch64-tdep.c: Sort headers.
5055         * aarch64-ravenscar-thread.c: Sort headers.
5056         * aarch64-newlib-tdep.c: Sort headers.
5057         * aarch64-linux-tdep.c: Sort headers.
5058         * aarch64-linux-nat.c: Sort headers.
5059         * aarch64-fbsd-tdep.c: Sort headers.
5060         * aarch64-fbsd-nat.c: Sort headers.
5061         * aarch32-linux-nat.c: Sort headers.
5062
5063 2019-04-04  Tom Tromey  <tom@tromey.com>
5064
5065         * varobj.c (varobj_create): Update.
5066         * rust-exp.y (struct rust_parser) <update_innermost_block,
5067         lookup_symbol>: New methods.
5068         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5069         Rename.
5070         (rust_parser::rust_lookup_type)
5071         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5072         * printcmd.c (display_command, do_one_display): Update.
5073         * parser-defs.h (struct parser_state) <parser_state>: Add
5074         "tracker" parameter.
5075         (block_tracker): New member.
5076         (class innermost_block_tracker) <innermost_block_tracker>: Add
5077         "types" parameter.
5078         <reset>: Remove method.
5079         (innermost_block): Don't declare.
5080         (null_post_parser): Update.
5081         * parse.c (innermost_block): Remove global.
5082         (write_dollar_variable): Update.
5083         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5084         Remove "tracker_types" parameter.
5085         (parse_expression): Add "tracker" parameter.
5086         (parse_expression_for_completion): Update.
5087         (null_post_parser): Add "tracker" parameter.
5088         * p-exp.y: Update rules.
5089         * m2-exp.y: Update rules.
5090         * language.h (struct language_defn) <la_post_parser>: Add
5091         "tracker" parameter.
5092         * go-exp.y: Update rules.
5093         * f-exp.y: Update rules.
5094         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5095         parameter.
5096         * d-exp.y: Update rules.
5097         * c-exp.y: Update rules.
5098         * breakpoint.c (set_breakpoint_condition): Create an
5099         innermost_block_tracker.
5100         (watch_command_1): Likewise.
5101         * ada-lang.c (resolve): Add "tracker" parameter.
5102         (resolve_subexp): Likewise.
5103         * ada-exp.y (write_var_from_sym): Update.
5104
5105 2019-04-04  Tom Tromey  <tom@tromey.com>
5106
5107         * type-stack.h: New file.
5108         * type-stack.c: New file.
5109         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5110         type-stack.h.
5111         (insert_into_type_stack, insert_type, push_type, push_type_int)
5112         (insert_type_address_space, pop_type, pop_type_int)
5113         (pop_typelist, pop_type_stack, append_type_stack)
5114         (push_type_stack, get_type_stack, push_typelist)
5115         (follow_type_instance_flags, follow_types): Don't declare.
5116         * parse.c (type_stack): Remove global.
5117         (parse_exp_in_context): Update.
5118         (insert_into_type_stack, insert_type, push_type, push_type_int)
5119         (insert_type_address_space, pop_type, pop_type_int)
5120         (pop_typelist, pop_type_stack, append_type_stack)
5121         (push_type_stack, get_type_stack, push_typelist)
5122         (follow_type_instance_flags, follow_types): Remove (moved to
5123         type-stack.c).
5124         * f-exp.y (type_stack): New global.
5125         Update rules.
5126         (push_kind_type, f_parse): Update.
5127         * d-exp.y (type_stack): New global.
5128         Update rules.
5129         (d_parse): Update.
5130         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5131         Update rules.
5132         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5133         (HFILES_NO_SRCDIR): Add type-stack.h.
5134
5135 2019-04-04  Tom Tromey  <tom@tromey.com>
5136
5137         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5138         (rust_parser::convert_ast_to_expression, rust_parse)
5139         (rust_lex_test_completion, rust_lex_tests): Update.
5140         * parser-defs.h (struct expr_completion_state): New.
5141         (struct parser_state) <parser_state>: Add completion parameter.
5142         <mark_struct_expression, mark_completion_tag>: New methods.
5143         <parse_completion, m_completion_state>: New members.
5144         (prefixify_expression, null_post_parser): Update.
5145         (mark_struct_expression, mark_completion_tag): Don't declare.
5146         * parse.c (parse_completion, expout_last_struct)
5147         (expout_tag_completion_type, expout_completion_name): Remove
5148         globals.
5149         (parser_state::mark_struct_expression)
5150         (parser_state::mark_completion_tag): Now methods.
5151         (prefixify_expression): Add last_struct parameter.
5152         (prefixify_subexp): Likewise.
5153         (parse_exp_1): Update.
5154         (parse_exp_in_context): Add cstate parameter.  Update.
5155         (parse_expression_for_completion): Create an
5156         expr_completion_state.
5157         (null_post_parser): Add "completion" parameter.
5158         * p-exp.y: Update rules.
5159         (yylex): Update.
5160         * language.h (struct language_defn) <la_post_parser>: Add
5161         "completing" parameter.
5162         * go-exp.y: Update rules.
5163         (lex_one_token): Update.
5164         * expression.h (parse_completion): Don't declare.
5165         * d-exp.y: Update rules.
5166         (lex_one_token): Update rules.
5167         * c-exp.y: Update rules.
5168         (lex_one_token): Update.
5169         * ada-lang.c (resolve): Add "parse_completion" parameter.
5170         (resolve_subexp): Likewise.
5171         (ada_resolve_function): Likewise.
5172
5173 2019-04-04  Tom Tromey  <tom@tromey.com>
5174
5175         * parser-defs.h (struct parser_state) <start_arglist,
5176         end_arglist>: New methods.
5177         <arglist_len, m_funcall_chain>: New members.
5178         (arglist_len, start_arglist, end_arglist): Don't declare.
5179         * parse.c (arglist_len, funcall_chain): Remove global.
5180         (start_arglist, end_arglist): Remove functions.
5181         (parse_exp_in_context): Update.
5182         * p-exp.y: Update rules.
5183         * m2-exp.y: Update rules.
5184         * go-exp.y: Update rules.
5185         * f-exp.y: Update rules.
5186         * d-exp.y: Update rules.
5187         * c-exp.y: Update rules.
5188
5189 2019-04-04  Tom Tromey  <tom@tromey.com>
5190
5191         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5192         lex_operator, push_back>: New methods.
5193         Update all rules.
5194         (rust_parser::lex_hex, lex_escape): Rename and update.
5195         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5196         (rust_parser::lex_operator): Rename and update.
5197         (rust_parser::lex_number, rustyylex, rustyyerror)
5198         (rust_lex_test_init, rust_lex_test_sequence)
5199         (rust_lex_test_push_back, rust_lex_tests): Update.
5200         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5201         parameter.
5202         <lexptr, prev_lexptr>: New members.
5203         (lexptr, prev_lexptr): Don't declare.
5204         * parse.c (lexptr, prev_lexptr): Remove globals.
5205         (parse_exp_in_context): Update.
5206         * p-exp.y (yylex, yyerror): Update.
5207         * m2-exp.y (parse_number, yylex, yyerror): Update.
5208         * go-exp.y (lex_one_token, yyerror): Update.
5209         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5210         * d-exp.y (lex_one_token, yyerror): Update.
5211         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5212         (lex_one_token, yyerror): Update.
5213         * ada-lex.l (YY_INPUT): Update.
5214         (rewind_to_char): Update.
5215         * ada-exp.y (yyerror): Update.
5216
5217 2019-04-04  Tom Tromey  <tom@tromey.com>
5218
5219         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5220         * parser-defs.h (struct parser_state) <parser_state>: Add new
5221         parameter.
5222         <comma_terminates>: New member.
5223         (comma_terminates): Don't declare global.
5224         * parse.c (comma_terminates): Remove global.
5225         (parse_exp_in_context): Update.
5226         * p-exp.y (yylex): Update.
5227         * m2-exp.y (yylex): Update.
5228         * go-exp.y (lex_one_token): Update.
5229         * f-exp.y (yylex): Update.
5230         * d-exp.y (lex_one_token): Update.
5231         * c-exp.y (lex_one_token): Update.
5232         * ada-lex.l: Update.
5233
5234 2019-04-04  Tom Tromey  <tom@tromey.com>
5235
5236         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5237         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5238         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5239         * parser-defs.h (paren_depth): Don't declare.
5240         * parse.c (paren_depth): Remove global.
5241         (parse_exp_in_context): Update.
5242         * p-exp.y (paren_depth): New global.
5243         (pascal_parse): Initialize it.
5244         * m2-exp.y (paren_depth): New global.
5245         (m2_parse): Initialize it.
5246         * go-exp.y (paren_depth): New global.
5247         (go_parse): Initialize it.
5248         * f-exp.y (paren_depth): New global.
5249         (f_parse): Initialize it.
5250         * d-exp.y (paren_depth): New global.
5251         (d_parse): Initialize it.
5252         * c-exp.y (paren_depth): New global.
5253         (c_parse): Initialize it.
5254         * ada-lex.l (paren_depth): New global.
5255         (lexer_init): Initialize it.
5256
5257 2019-04-04  Tom Tromey  <tom@tromey.com>
5258
5259         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5260         (rust_parser::convert_ast_to_type)
5261         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5262         * parser-defs.h (struct parser_state) <parser_state>: Add
5263         parameters.  Initialize new members.
5264         <expression_context_block, expression_context_pc>: New members.
5265         * parse.c (expression_context_block, expression_context_pc):
5266         Remove globals.
5267         (parse_exp_in_context): Update.
5268         * p-exp.y: Update all rules.
5269         (yylex): Update.
5270         * m2-exp.y: Update all rules.
5271         (yylex): Update.
5272         * go-exp.y (yylex): Update.
5273         * f-exp.y (yylex): Update.
5274         * d-exp.y: Update all rules.
5275         (yylex): Update.
5276         * c-exp.y: Update all rules.
5277         (lex_one_token, classify_name, yylex, c_parse): Update.
5278         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5279
5280 2019-04-04  Tom Tromey  <tom@tromey.com>
5281
5282         * gdbarch.h, gdbarch.c: Rebuild.
5283         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5284         * stap-probe.h:
5285         (struct stap_parse_info): Replace "parser_state" with
5286         "expr_builder".
5287         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5288         (parser_state): New class.
5289         * parse.c (expr_builder): Rename.
5290         (expr_builder::release): Rename.
5291         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5292         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5293         (write_exp_elt_longcst, write_exp_elt_floatcst)
5294         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5295         (write_exp_string_vector, write_exp_bitstring)
5296         (write_exp_msymbol, mark_struct_expression)
5297         (write_dollar_variable)
5298         (insert_type_address_space, increase_expout_size): Replace
5299         "parser_state" with "expr_builder".
5300         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5301         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5302         "parser_state" with "expr_builder".
5303
5304 2019-04-04  Tom Tromey  <tom@tromey.com>
5305
5306         * rust-exp.y: Replace "parse_language" with method call.
5307         * p-exp.y:
5308         (yylex): Replace "parse_language" with method call.
5309         * m2-exp.y:
5310         (yylex): Replace "parse_language" with method call.
5311         * go-exp.y (classify_name): Replace "parse_language" with method
5312         call.
5313         * f-exp.y (yylex): Replace "parse_language" with method call.
5314         * d-exp.y (lex_one_token): Replace "parse_language" with method
5315         call.
5316         * c-exp.y:
5317         (lex_one_token, classify_name, yylex): Replace "parse_language"
5318         with method call.
5319         * ada-exp.y (find_primitive_type, type_char)
5320         (type_system_address): Replace "parse_language" with method call.
5321
5322 2019-04-04  Tom Tromey  <tom@tromey.com>
5323
5324         * rust-exp.y: Replace "parse_gdbarch" with method call.
5325         * parse.c (write_dollar_variable, insert_type_address_space):
5326         Replace "parse_gdbarch" with method call.
5327         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5328         call.
5329         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5330         call.
5331         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5332         "parse_gdbarch" with method call.
5333         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5334         with method call.
5335         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5336         "parse_gdbarch" with method call.
5337         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5338         "parse_gdbarch" with method call.
5339         * c-exp.y (parse_type, parse_number, classify_name): Replace
5340         "parse_gdbarch" with method call.
5341         * ada-lex.l: Replace "parse_gdbarch" with method call.
5342         * ada-exp.y (parse_type, find_primitive_type, type_char)
5343         (type_system_address): Replace "parse_gdbarch" with method call.
5344
5345 2019-04-04  Tom Tromey  <tom@tromey.com>
5346
5347         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5348         * stap-probe.c (stap_parse_argument): Update.
5349         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5350         initial_size parameter.
5351         * rust-exp.y (rust_lex_tests): Update.
5352         * parse.c (parser_state): Update.
5353         (parse_exp_in_context): Update.
5354         * parser-defs.h (struct parser_state) <parser_state>: Remove
5355         "initial_size" parameter.
5356
5357 2019-04-04  Tom Tromey  <tom@tromey.com>
5358
5359         * parser-defs.h (increase_expout_size): Don't declare.
5360         * parse.c (increase_expout_size): Now static.
5361
5362 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
5363
5364         * gnu-nat.c (gnu_nat_target::wait): Fix
5365         target_waitstatus_to_string call.
5366
5367 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5368
5369         * eval.c (evaluate_subexp_standard): Handle internal functions
5370         during Fortran function call handling.
5371
5372 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5373
5374         * NEWS: Mention new internal functions.
5375         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5376         (read_base_type): Use dwarf2_init_complex_target_type.
5377         * value.c (creal_internal_fn): New function.
5378         (cimag_internal_fn): New function.
5379         (_initialize_values): Register new internal functions.
5380
5381 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5382
5383         * infrun.c (stop_all_threads): If debug_infrun, always
5384         trace the wait status after wait_one, using
5385         target_waitstatus_to_string and target_pid_to_str.
5386         (handle_inferior_event): Replace various trace of
5387         wait status kind by a single trace.
5388         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5389         wait status kind image by target_waitstatus_to_string.
5390         * target/waitstatus.c (target_waitstatus_to_string): Fix
5391         obsolete comment.
5392
5393 2019-04-01  Tom Tromey  <tromey@adacore.com>
5394
5395         PR symtab/23331:
5396         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
5397
5398 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5399             Pedro Alves  <palves@redhat.com>
5400
5401         * top.c (quit_force): Call 'finalize_values'.
5402         * value.c (finalize_values): New function.
5403         * value.h (finalize_values): Declare.
5404
5405 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
5406
5407         * NEWS: Announce $_gdb_major and $_gdb_minor.
5408
5409         * top.c (init_gdb_version_vars): New function.
5410         (gdb_init): Call init_gdb_version_vars.
5411
5412 2019-03-29  Tom Tromey  <tromey@adacore.com>
5413
5414         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
5415         help text.  Remove dead code.
5416
5417 2019-03-29  Keith Seitz  <keiths@redhat.com>
5418
5419         From Siddhesh Poyarekar:
5420         * f-lang.h (f77_get_upperbound): Return LONGEST.
5421         (f77_get_lowerbound): Likewise.
5422         * f-typeprint.c (f_type_print_varspec_suffix): Expand
5423         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
5424         print them.
5425         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
5426         plongest to format print it.
5427         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
5428         (f77_get_upperbound): Likewise.
5429         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
5430         LOWER_BOUND to LONGEST.
5431         (f77_create_arrayprint_offset_tbl): Likewise.
5432
5433 2019-03-29  Keith Seitz  <keiths@redhat.com>
5434
5435         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
5436         %s/pulongest for TYPE_LENGTH instead of %d in format
5437         strings.
5438         * ada-typerint.c (ada_print_type): Likewise.
5439         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
5440         * compile/compile-c-support.c (generate_register_struct): Likewise.
5441         * gdbtypes.c (recursive_dump_type): Likewise.
5442         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
5443         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
5444         instead of %d in format strings.
5445         * riscv-tdep.c (riscv_type_alignment): Cast second argument
5446         to std::min to ULONGEST.
5447         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
5448         instead of %d in format strings.
5449         * tracepoint.c (info_scope_command): Likewise.
5450         * typeprint.c (print_offset_data::update)
5451         (print_offset_data::finish): Likewise.
5452         * xtensa-tdep.c (xtensa_store_return_value)
5453         (xtensa_push_dummy_call): Likewise.
5454
5455 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
5456
5457         * windows-nat.c (display_selector): Fixed format specifications
5458         for 64-bit Cygwin.
5459
5460 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5461
5462         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
5463
5464 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
5465
5466         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
5467         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
5468         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
5469         (nios2_linux_init_abi): Install it.
5470
5471 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5472
5473         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
5474
5475 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5476
5477         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
5478
5479 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5480             Tom Tromey  <tromey@adacore.com>
5481
5482         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
5483
5484 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
5485
5486         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
5487         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
5488         method to compute the bounds of range types. Also print "[evaluated]"
5489         if the bounds' values come from a dynamic evaluation.
5490
5491 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5492
5493         * cp-valprint.c (cp_print_value_fields): Don't print trailing
5494         whitespace when pretty printing is on.
5495
5496 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5497
5498         * ppc-linux-nat.c: Add include.
5499
5500 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5501
5502         * NEWS: Mention AArch64 Pointer Authentication.
5503
5504 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5505
5506         * arm-linux-nat.c: Add include.
5507
5508 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
5509
5510         * source-cache.c (source_cache::get_source_lines): Re-read
5511         fullname after calling open_source_file.
5512
5513 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
5514
5515         * NEWS: Mention TLS support for FreeBSD.
5516
5517 2019-03-25  Tom Tromey  <tromey@adacore.com>
5518
5519         * minsyms.c (BUNCH_SIZE): Update comment.
5520         (~minimal_symbol_reader): Remove old comment.
5521         (compact_minimal_symbols): Update comment.
5522         (minimal_symbol_reader::install): Remove old comment.  Update
5523         other comments.
5524
5525 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5526
5527         * s390-linux-nat.c: Add include.
5528
5529 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5530
5531         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5532         Call linux_get_hwcap.
5533         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
5534         Likewise.
5535         (aarch64_linux_get_hwcap): Remove function.
5536         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
5537         declaration.
5538         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
5539         linux_get_hwcap.
5540         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5541         * linux-tdep.c (linux_get_hwcap): Add function.
5542         (linux_get_hwcap2): Likewise.
5543         * linux-tdep.h (linux_get_hwcap): Add declaration.
5544         (linux_get_hwcap2): Likewise.
5545         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
5546         (ppc_linux_get_hwcap2): Likewise.
5547         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
5548         linux_get_hwcap.
5549         (ppc_linux_nat_target::insert_watchpoint): Likewise.
5550         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
5551         (ppc_linux_nat_target::read_description): Likewise.
5552         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
5553         * s390-linux-nat.c: Likewise.
5554         * s390-linux-tdep.c (s390_core_read_description): Likewise.
5555
5556 2019-03-24  Tom Tromey  <tom@tromey.com>
5557
5558         * ada-lang.c (standard_lookup): Simplify initialization.
5559         (ada_lookup_symbol_nonlocal): Simplify return.
5560         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
5561         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
5562         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
5563         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
5564         initialization.
5565         * solib.c (solib_global_lookup): Simplify.
5566         * symtab.c (null_block_symbol): Remove.
5567         (symbol_cache_lookup): Simplify returns.
5568         (lookup_language_this): Simplify returns.
5569         (lookup_symbol_aux): Simplify return.
5570         (lookup_local_symbol): Simplify returns.
5571         (lookup_global_symbol_from_objfile): Simplify return.
5572         (lookup_symbol_in_objfile_symtabs)
5573         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
5574         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
5575         (lookup_static_symbol, lookup_global_symbol): Simplify return.
5576         * cp-namespace.c (cp_lookup_bare_symbol)
5577         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
5578         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
5579         (cp_lookup_nested_symbol): Don't use null_block_symbol.
5580         (cp_lookup_symbol_via_imports): Simplify initialization.
5581         (find_symbol_in_baseclass): Likewise.
5582         * symtab.h (null_block_symbol): Remove.
5583         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
5584         (d_lookup_nested_symbol, d_lookup_symbol_imports)
5585         (d_lookup_symbol_module): Likewise.
5586         (find_symbol_in_baseclass): Simplify initialization.
5587
5588 2019-03-24  Tom Tromey  <tom@tromey.com>
5589
5590         * expression.h: Don't include symtab.h.
5591         (struct block): Forward declare.
5592
5593 2019-03-24  Tom Tromey  <tom@tromey.com>
5594
5595         * c-exp.y (typebase): Remove casts.
5596         * gdbtypes.c (lookup_unsigned_typename, )
5597         (lookup_signed_typename): Remove cast.
5598         * eval.c (parse_to_comma_and_eval): Remove cast.
5599         * parse.c (write_dollar_variable): Remove cast.
5600         * block.h (struct block) <superblock>: Now const.
5601         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
5602         * psymtab.c (psym_map_matching_symbols): Make "block" const.
5603         (map_block): Make "block" const.
5604         * symfile.h (struct quick_symbol_functions)
5605         <map_matching_symbols>: Constify block argument to "callback".
5606         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
5607         const.
5608         (find_pc_sect_compunit_symtab): Make "b" const.
5609         (find_symbol_at_address): Likewise.
5610         (search_symbols): Likewise.
5611         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
5612         (dw2_debug_names_lookup_symbol): Likewise.
5613         (dw2_map_matching_symbols): Update.
5614         * p-valprint.c (pascal_val_print): Remove "block".
5615         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
5616         (aux_add_nonlocal_symbols): Make "block" const.
5617         (resolve_subexp): Remove cast.
5618         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5619         const.
5620         (iterate_over_file_blocks): Likewise.
5621         * f-exp.y (%union) <bval>: Remove.
5622         * coffread.c (patch_opaque_types): Make "b" const.
5623         * spu-tdep.c (spu_catch_start): Make "block" const.
5624         * c-valprint.c (print_unpacked_pointer): Remove "block".
5625         * symmisc.c (dump_symtab_1): Make "b" const.
5626         (block_depth): Make "block" const.
5627         * d-exp.y (%union) <bval>: Remove.
5628         * cp-support.h (cp_lookup_rtti_type): Update.
5629         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5630         * psymtab.c (psym_lookup_symbol): Make "block" const.
5631         (maintenance_check_psymtabs): Make "b" const.
5632         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5633         (enumerate_locals, enumerate_args): Update.
5634         * python/py-symtab.c (stpy_global_block): Make "block" const.
5635         (stpy_static_block): Likewise.
5636         * inline-frame.c (block_starting_point_at): Make "new_block"
5637         const.
5638         * block.c (find_block_in_blockvector): Make return type const.
5639         (blockvector_for_pc_sect): Make "b" const.
5640         (find_block_in_blockvector): Make "b" const.
5641
5642 2019-03-23  Tom Tromey  <tom@tromey.com>
5643
5644         * varobj.c (varobj_create): Update.
5645         * symfile.c (clear_symtab_users): Don't reset innermost_block.
5646         * printcmd.c (display_command, do_one_display): Don't reset
5647         innermost_block.
5648         * parser-defs.h (enum innermost_block_tracker_type): Move to
5649         expression.h.
5650         (innermost_block): Update comment.
5651         * parse.c (parse_exp_1): Add tracker_types parameter.
5652         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
5653         tracker_types parameter.  Reset innermost_block.
5654         (parse_exp_in_context): Remove.
5655         (parse_expression_for_completion): Update.
5656         * objfiles.c (~objfile): Don't reset expression_context_block or
5657         innermost_block.
5658         * expression.h (enum innermost_block_tracker_type): Move from
5659         parser-defs.h.
5660         (parse_exp_1): Add tracker_types parameter.
5661         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5662         reset innermost_block.
5663
5664 2019-03-23  Tom Tromey  <tom@tromey.com>
5665
5666         * objfiles.h: Include bcache.h.
5667
5668 2019-03-23  Tom Tromey  <tom@tromey.com>
5669
5670         * linespec.c (get_current_search_block): Use
5671         scoped_restore_current_language.
5672         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5673
5674 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5675             Jiong Wang  <jiong.wang@arm.com>
5676
5677         * aarch64-linux-tdep.c
5678         (aarch64_linux_iterate_over_regset_sections): Check for pauth
5679         section.
5680         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5681
5682 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5683             Jiong Wang  <jiong.wang@arm.com>
5684
5685         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5686         instructions.
5687         (aarch64_analyze_prologue_test): Add PACIASP test.
5688         (aarch64_prologue_prev_register): Unmask PC value.
5689
5690 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5691             Jiong Wang  <jiong.wang@arm.com>
5692
5693         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
5694         (aarch64_dwarf2_prev_register): Unmask PC value.
5695         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
5696         (aarch64_execute_dwarf_cfa_vendor_op): Check for
5697         DW_CFA_AARCH64_negate_ra_state.
5698         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
5699
5700 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5701             Jiong Wang  <jiong.wang@arm.com>
5702
5703         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
5704         registers.
5705         (aarch64_pseudo_register_name): Likewise.
5706         (aarch64_pseudo_register_type): Likewise.
5707         (aarch64_pseudo_register_reggroup_p): Likewise.
5708         (aarch64_gdbarch_init): Add pauth registers.
5709         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
5710         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
5711         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
5712         (struct gdbarch_tdep): Add regnum for ra_state.
5713
5714 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5715             Jiong Wang  <jiong.wang@arm.com>
5716
5717         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
5718
5719 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5720             Jiong Wang  <jiong.wang@arm.com>
5721
5722         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
5723         function.
5724         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
5725         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
5726         (aarch64_gdbarch_init): Add puth registers.
5727         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
5728         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
5729         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
5730
5731 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5732             Jiong Wang  <jiong.wang@arm.com>
5733
5734         * aarch64-linux-nat.c
5735         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
5736         * aarch64-linux-tdep.c
5737         (aarch64_linux_core_read_description): Likewise.
5738         (aarch64_linux_get_hwcap): New function.
5739         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
5740         (aarch64_linux_get_hwcap): New declaration.
5741
5742 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5743             Jiong Wang  <jiong.wang@arm.com>
5744
5745         * aarch64-linux-nat.c
5746         (aarch64_linux_nat_target::read_description): Add pauth param.
5747         * aarch64-linux-tdep.c
5748         (aarch64_linux_core_read_description): Likewise.
5749         * aarch64-tdep.c (struct target_desc): Add in pauth.
5750         (aarch64_read_description): Add pauth param.
5751         (aarch64_gdbarch_init): Likewise.
5752         * aarch64-tdep.h (aarch64_read_description): Likewise.
5753         * arch/aarch64.c (aarch64_create_target_description): Likewise.
5754         * arch/aarch64.h (aarch64_create_target_description): Likewise.
5755         * features/Makefile: Add new files.
5756         * features/aarch64-pauth.c: New file.
5757         * features/aarch64-pauth.xml: New file.
5758
5759 2019-03-20  Tom Tromey  <tromey@adacore.com>
5760
5761         * infrun.c (handle_inferior_event): Rename from
5762         handle_inferior_event_1.  Create a scoped_value_mark.
5763         (handle_inferior_event): Remove.
5764
5765 2019-03-19  Tom Tromey  <tromey@adacore.com>
5766
5767         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
5768         * infrun.h (print_stop_event): Add "displays" parameter.
5769         * infrun.c (print_stop_event): Add "displays" parameter.
5770
5771 2019-03-19  Pedro Alves  <palves@redhat.com>
5772
5773         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
5774         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
5775         to -1.  Fix TABs vs spaces.
5776         (tui_ui_out::tui_ui_out): Don't initialize fields here.
5777         * tui/tui-out.h (tui_ui_out) Add intro comments.
5778         <m_line, m_start_of_line>: In-class initialize, and add describing
5779         comment.
5780
5781 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
5782
5783         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
5784         variable names.
5785         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
5786
5787 2019-03-18  Pedro Alves  <palves@redhat.com>
5788             Eli Zaretskii <eliz@gnu.org>
5789
5790         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
5791         m_line and m_start_of_line.
5792
5793 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
5794
5795         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
5796         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
5797         it returns a newline.  This fixes a regression in TU mode, whereby
5798         the next line is output on the same screen line as the user input.
5799
5800 2019-03-18  Tom Tromey  <tromey@adacore.com>
5801
5802         * minsyms.c (minimal_symbol_reader::install): Remove call to
5803         obstack_blank.
5804
5805 2019-03-18  Pedro Alves  <palves@redhat.com>
5806
5807         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
5808         New globals.
5809         (apply_style): New, factored out from ...
5810         (apply_ansi_escape): ... this.  Handle reverse video mode.
5811         (tui_set_reverse_mode): New function.
5812         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
5813         * tui/tui-winsource.c (tui_show_source_line): Use
5814         tui_set_reverse_mode instead of setting A_STANDOUT.
5815         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
5816         New setter methods.
5817
5818 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
5819
5820         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
5821         Handle tabs.
5822
5823 2019-03-18  Tom Tromey  <tromey@adacore.com>
5824
5825         * ada-lang.c (empty_array): Add "high" parameter.
5826         (ada_evaluate_subexp): Update.
5827
5828 2019-03-17  Sergei Trofimovich <siarheit@google.com>
5829
5830         * unittests/string_view-selftests.c: Define
5831         _initialize_string_view_selftests unconditionally.
5832
5833 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5834
5835         PR gdb/24350
5836         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
5837
5838 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5839
5840         PR gdb/24351
5841         * windows-nat.c (display_selector): Fix format specifiers.
5842
5843 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
5844
5845         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
5846         tui_refill_source_window instead of tui_refresh_win, to update the
5847         current execution line.  This fixes redisplay of the current line
5848         when stepping through the code with "next" or "step".
5849
5850 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5851
5852         * source-cache.c (source_cache::get_source_lines): Call
5853         find_source_lines to initialize s->nlines.  This fixes vertical
5854         scrolling of TUI source window when the DOWN arrow is pressed.
5855
5856 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5857
5858         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
5859         linux-thread-db.c (_initialize_thread_db): Likewise.
5860
5861 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5862
5863         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
5864         wclrtoeol in tui_show_source_line".  This reverts changes made in
5865         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
5866
5867 2019-03-15  Tom Tromey  <tom@tromey.com>
5868
5869         * symtab.h (struct minimal_symbol): Derive from
5870         general_symbol_info.
5871         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
5872         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
5873         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
5874         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
5875         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
5876         (MSYMBOL_SEARCH_NAME): Update.
5877         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
5878         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
5879         * minsyms.c (minimal_symbol_reader::record_full): Update.
5880
5881 2019-03-15  Tom Tromey  <tom@tromey.com>
5882
5883         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
5884
5885 2019-03-15  Tom Tromey  <tom@tromey.com>
5886
5887         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
5888         unique_xmalloc_ptr.
5889         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
5890         Update.
5891         * minsyms.c (lookup_minimal_symbol_by_pc_section)
5892         (build_minimal_symbol_hash_tables)
5893         (minimal_symbol_reader::install): Update.
5894
5895 2019-03-15  Tom Tromey  <tom@tromey.com>
5896
5897         * symtab.c (create_demangled_names_hash): Update.
5898         (symbol_set_names): Update.
5899         * objfiles.h (struct objfile_per_bfd_storage)
5900         <demangled_names_hash>: Now an htab_up.
5901         * objfiles.c (objfile_per_bfd_storage): Simplify.
5902
5903 2019-03-15  Tom Tromey  <tom@tromey.com>
5904
5905         * objfiles.h (struct objfile_per_bfd_storage): Declare
5906         destructor.
5907         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
5908         New.
5909         (get_objfile_bfd_data): Use new.  Don't initialize
5910         language_of_main.
5911         (free_objfile_per_bfd_storage): Remove.
5912         (objfile_bfd_data_free, objfile::~objfile): Use delete.
5913
5914 2019-03-15  Tom Tromey  <tom@tromey.com>
5915
5916         * symfile.c (reread_symbols): Update.
5917         * objfiles.c (objfile::objfile): Update.
5918         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
5919         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
5920         comment.
5921         (minimal_symbol_reader::install): Update.
5922         (terminate_minimal_symbol_table): Remove.
5923         * jit.c (jit_object_close_impl): Update.
5924
5925 2019-03-15  Tom Tromey  <tom@tromey.com>
5926
5927         * minsyms.c (minimal_symbol_reader::record_full): Remove some
5928         initializations.
5929
5930 2019-03-15  Tom Tromey  <tom@tromey.com>
5931
5932         * objfiles.h (struct objfile_per_bfd_storage)
5933         <demangled_hash_languages>: Now a bitset.
5934         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
5935         (lookup_minimal_symbol): Update.
5936
5937 2019-03-15  Tom Tromey  <tom@tromey.com>
5938
5939         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
5940         Don't return the symbol.
5941         * coffread.c (record_minimal_symbol): Use record_full.
5942
5943 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
5944
5945         The MS-Windows port of ncurses fails to switch to a color pair if
5946         one or both of the colors are the implicit default colors.  This
5947         change records the default colors when TUI is initialized, and
5948         then specifies them explicitly when a color pair uses the default
5949         colors.  This allows color styling in TUI mode on MS-Windows.
5950
5951         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
5952         ncurses_norm_attr.
5953         (tui_initialize_io) [__MINGW32__]: Record the default terminal
5954         colors in ncurses_norm_attr.
5955         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
5956         "none", replace it with the default color recorded in
5957         ncurses_norm_attr.
5958
5959 2019-03-14  Tom Tromey  <tromey@adacore.com>
5960
5961         * source-cache.h (class source_cache) <get_source_lines>: Return
5962         std::string.
5963         * source-cache.c (source_cache::extract_lines): Handle case where
5964         first_pos==npos.  Return std::string.
5965         (source_cache::get_source_lines): Update.
5966
5967 2019-03-14  Tom Tromey  <tromey@adacore.com>
5968
5969         * NEWS: Add item for "style sources" commands.
5970         * source-cache.c (source_cache::get_source_lines): Check
5971         source_styling.
5972         * cli/cli-style.c (source_styling): New global.
5973         (_initialize_cli_style): Add "style sources" commands.
5974         (show_style_sources): New function.
5975         * cli/cli-style.h (source_styling): Declare.
5976
5977 2019-03-14  Pedro Alves  <palves@redhat.com>
5978             Tom Tromey  <tromey@adacore.com>
5979
5980         * tui/tui-winsource.h (tui_refill_source_window): Declare.
5981         * tui/tui-winsource.c (tui_refill_source_window): New function,
5982         from...
5983         (tui_horizontal_source_scroll): ... here.  Move some logic.
5984         * cli/cli-style.c (set_style_enabled): Notify new observable.
5985         * tui/tui-hooks.c (tui_redisplay_source): New function.
5986         (tui_attach_detach_observers): Attach or detach
5987         tui_redisplay_source.
5988         * observable.h (source_styling_changed): New observable.
5989         * observable.c: Define source_styling_changed observable.
5990
5991 2019-03-13  Tom Tromey  <tromey@adacore.com>
5992
5993         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
5994         (i386_gnu_nat_target::store_registers): Update.
5995         * target-debug.h (target_debug_print_std_string): New macro.
5996         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5997         * windows-tdep.c (display_one_tib): Update.
5998         * tui/tui-stack.c (tui_make_status_line): Update.
5999         * top.c (print_inferior_quit_action): Update.
6000         * thread.c (thr_try_catch_cmd): Update.
6001         (add_thread_with_info): Update.
6002         (thread_target_id_str): Update.
6003         (thr_try_catch_cmd): Update.
6004         (thread_command): Update.
6005         (thread_find_command): Update.
6006         * record-btrace.c (record_btrace_target::info_record)
6007         (record_btrace_resume_thread, record_btrace_target::resume)
6008         (record_btrace_cancel_resume, record_btrace_step_thread)
6009         (record_btrace_target::wait, record_btrace_target::wait)
6010         (record_btrace_target::wait, record_btrace_target::stop): Update.
6011         * progspace.c (print_program_space): Update.
6012         * process-stratum-target.c
6013         (process_stratum_target::thread_address_space): Update.
6014         * linux-fork.c (linux_fork_mourn_inferior)
6015         (detach_checkpoint_command, info_checkpoints_command)
6016         (linux_fork_context): Update.
6017         (linux_fork_detach): Update.
6018         (class scoped_switch_fork_info): Update.
6019         (delete_checkpoint_command): Update.
6020         * infrun.c (follow_fork_inferior): Update.
6021         (follow_fork_inferior): Update.
6022         (proceed_after_vfork_done): Update.
6023         (handle_vfork_child_exec_or_exit): Update.
6024         (follow_exec): Update.
6025         (displaced_step_prepare_throw): Update.
6026         (displaced_step_restore): Update.
6027         (start_step_over): Update.
6028         (resume_1): Update.
6029         (clear_proceed_status_thread): Update.
6030         (proceed): Update.
6031         (print_target_wait_results): Update.
6032         (do_target_wait): Update.
6033         (context_switch): Update.
6034         (stop_all_threads): Update.
6035         (restart_threads): Update.
6036         (finish_step_over): Update.
6037         (handle_signal_stop): Update.
6038         (switch_back_to_stepped_thread): Update.
6039         (keep_going_pass_signal): Update.
6040         (print_exited_reason): Update.
6041         (normal_stop): Update.
6042         * inferior.c (inferior_pid_to_str): Change return type.
6043         (print_selected_inferior): Update.
6044         (add_inferior): Update.
6045         (detach_inferior): Update.
6046         * dummy-frame.c (fprint_dummy_frames): Update.
6047         * dcache.c (dcache_info_1): Update.
6048         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6049         (btrace_fetch, btrace_clear): Update.
6050         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6051         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6052         type.
6053         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6054         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6055         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6056         * gdbarch.c, gdbarch.h: Rebuild.
6057         * gdbarch.sh (core_pid_to_str): Change return type.
6058         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6059         return type.
6060         (windows_nat_target::pid_to_str): Change return type.
6061         (windows_delete_thread): Update.
6062         (windows_nat_target::attach): Update.
6063         (windows_nat_target::files_info): Update.
6064         * target-delegates.c: Rebuild.
6065         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6066         return type.
6067         (sol_thread_target::pid_to_str): Change return type.
6068         * remote.c (class remote_target) <pid_to_str>: Change return
6069         type.
6070         (remote_target::pid_to_str): Change return type.
6071         (extended_remote_target::attach, remote_target::remote_stop_ns)
6072         (remote_target::remote_notif_remove_queued_reply)
6073         (remote_target::push_stop_reply, remote_target::disable_btrace):
6074         Update.
6075         (extended_remote_target::attach): Update.
6076         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6077         type.
6078         (gdbsim_target::pid_to_str): Change return type.
6079         * ravenscar-thread.c (struct ravenscar_thread_target)
6080         <pid_to_str>: Change return type.
6081         (ravenscar_thread_target::pid_to_str): Change return type.
6082         * procfs.c (class procfs_target) <pid_to_str>: Change return
6083         type.
6084         (procfs_target::pid_to_str): Change return type.
6085         (procfs_target::attach): Update.
6086         (procfs_target::detach): Update.
6087         (procfs_target::fetch_registers): Update.
6088         (procfs_target::store_registers): Update.
6089         (procfs_target::wait): Update.
6090         (procfs_target::files_info): Update.
6091         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6092         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6093         return type.
6094         (nto_procfs_target::pid_to_str): Change return type.
6095         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6096         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6097         return type.
6098         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6099         (exit_lwp): Update.
6100         (attach_proc_task_lwp_callback, get_detach_signal)
6101         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6102         (linux_nat_target::resume, wait_lwp, stop_callback)
6103         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6104         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6105         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6106         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6107         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6108         type.
6109         (inf_ptrace_target::attach): Update.
6110         (inf_ptrace_target::files_info): Update.
6111         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6112         type.
6113         (go32_nat_target::pid_to_str): Change return type.
6114         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6115         (gnu_nat_target::wait): Update.
6116         (gnu_nat_target::wait): Update.
6117         (gnu_nat_target::resume): Update.
6118         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6119         (fbsd_nat_target::wait): Update.
6120         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6121         type.
6122         (darwin_nat_target::attach): Update.
6123         * corelow.c (class core_target) <pid_to_str>: Change return type.
6124         (core_target::pid_to_str): Change return type.
6125         * target.c (normal_pid_to_str): Change return type.
6126         (default_pid_to_str): Likewise.
6127         (target_pid_to_str): Change return type.
6128         (target_translate_tls_address): Update.
6129         (target_announce_detach): Update.
6130         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6131         return type.
6132         (bsd_uthread_target::pid_to_str): Change return type.
6133         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6134         type.
6135         (bsd_kvm_target::pid_to_str): Change return type.
6136         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6137         return type.
6138         (aix_thread_target::pid_to_str): Change return type.
6139         * target.h (struct target_ops) <pid_to_str>: Change return type.
6140         (target_pid_to_str, normal_pid_to_str): Likewise.
6141         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6142         type.
6143         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6144         type.
6145         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6146         return type.
6147         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6148         type.
6149         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6150         type.
6151         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6152         return type.
6153
6154 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6155
6156         * NEWS: Mention that the new default MI version is 3.  Mention
6157         changes to the output of commands and events that deal with
6158         multi-location breakpoints.
6159         * breakpoint.c: Include "mi/mi-out.h".
6160         (print_one_breakpoint): Change output syntax if using MI version
6161         >= 3.
6162         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6163         New.
6164         (mi_multi_location_breakpoint_output_fixed): New.
6165         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6166         (mi_cmd_fix_multi_location_breakpoint_output): New.
6167         (mi_multi_location_breakpoint_output_fixed): New.
6168         * mi/mi-cmds.c (mi_cmds): Register command
6169         -fix-multi-location-breakpoint-output.
6170         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6171         interpreter "mi".
6172
6173 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6174
6175         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6176         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6177         instantiate mi_ui_out based on interpreter name.
6178         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6179         * mi/mi-main.c (mi_load_progress): Likewise.
6180
6181 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6182
6183         * NEWS: Combine separate "New targets" sections for 8.3.
6184
6185 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6186
6187         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6188         (ppcfbsd_init_abi): Install gdbarch
6189         "fetch_tls_load_module_address" and "get_thread_local_address"
6190         methods.
6191
6192 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6193
6194         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6195         (riscv_fbsd_init_abi): Install gdbarch
6196         "fetch_tls_load_module_address" and "get_thread_local_address"
6197         methods.
6198
6199 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6200
6201         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6202         (i386fbsd_init_abi): Install gdbarch
6203         "fetch_tls_load_module_address" and "get_thread_local_address"
6204         methods.
6205
6206 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6207
6208         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6209         (amd64fbsd_init_abi): Install gdbarch
6210         "fetch_tls_load_module_address" and "get_thread_local_address"
6211         methods.
6212
6213 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6214
6215         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6216         (struct fbsd_pspace_data): New type.
6217         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6218         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6219         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6220         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6221         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6222
6223 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6224
6225         * gdbtypes.c (lookup_struct_elt): New function.
6226         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6227         * gdbtypes.h (struct struct_elt): New type.
6228         (lookup_struct_elt): New prototype.
6229
6230 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6231
6232         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6233         remove disabled code block.
6234
6235 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6236
6237         * gdbarch.sh (get_thread_local_address): New method.
6238         * gdbarch.h, gdbarch.c: Regenerate.
6239         * target.c (target_translate_tls_address): Use
6240         gdbarch_get_thread_local_address if present instead of
6241         target::get_thread_local_address.
6242
6243 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6244
6245         * target.h (target::get_thread_local_address): Update comment.
6246
6247 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6248
6249         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6250         objfile->separate_debug_objfile_backlink if not NULL.
6251
6252 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6253
6254         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6255         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6256         (amd64bsd_store_inferior_registers): Likewise.
6257         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6258         Enable segment base registers.
6259         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6260         PT_GETFSBASE and PT_GETGSBASE.
6261         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6262         PT_SETGSBASE.
6263         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6264         segment base registers.
6265         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6266
6267 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6268
6269         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6270         Update calls to i386_target_description to add 'segments'
6271         parameter.
6272         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6273         add segment base registers.
6274         * arch/i386.c (i386_create_target_description): Add 'segments'
6275         parameter to enable segment base registers.
6276         * arch/i386.h (i386_create_target_description): Likewise.
6277         * features/i386/32bit-segments.xml: New file.
6278         * features/i386/32bit-segments.c: Generate.
6279         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6280         call to i386_target_description to add 'segments' parameter.
6281         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6282         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6283         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6284         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6285         if feature is present.
6286         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6287         Add 'segments' parameter to call to i386_target_description.
6288         (i386_target_description): Add 'segments' parameter to enable
6289         segment base registers.
6290         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6291         to call to i386_target_description.
6292         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6293         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6294         Define I386_NUM_REGS.
6295         (i386_target_description): Add 'segments' parameter to enable
6296         segment base registers.
6297
6298 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6299
6300         PR/24325
6301         * source-cache.c: #undef open and close, to avoid unresolved
6302         externals during linking.
6303
6304 2019-03-12  Tom Tromey  <tromey@adacore.com>
6305
6306         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6307         const.  Add initializers.
6308         (_initialize_remote): Don't initialize ptid globals.
6309
6310 2019-03-12  Pedro Alves  <palves@redhat.com>
6311
6312         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6313
6314 2019-03-12  Pedro Alves  <palves@redhat.com>
6315
6316         * cp-name-parser.y (main): Remove unused 'len' variable.
6317
6318 2019-03-12  Tom Tromey  <tromey@adacore.com>
6319
6320         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6321         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6322
6323 2019-03-12  Tom Tromey  <tromey@adacore.com>
6324
6325         * linux-nat.c (iterate_over_lwps): Update.
6326         (stop_callback): Remove parameter.
6327         (stop_wait_callback, detach_callback, resume_set_callback)
6328         (select_singlestep_lwp_callback, set_ignore_sigint)
6329         (status_callback, resumed_callback, resume_clear_callback)
6330         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6331         data parameter.
6332         (linux_nat_target::detach, linux_nat_target::resume)
6333         (linux_stop_and_wait_all_lwps, select_event_lwp)
6334         (linux_nat_filter_event, linux_nat_wait_1)
6335         (linux_nat_target::kill, linux_nat_target::stop)
6336         (linux_nat_target::stop): Update.
6337         (linux_nat_resume_callback): Change type.
6338         (resume_stopped_resumed_lwps, count_events_callback)
6339         (select_event_lwp_callback): Likewise.
6340         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6341         * arm-linux-nat.c (struct update_registers_data): Remove.
6342         (update_registers_callback): Change type.
6343         (arm_linux_insert_hw_breakpoint1): Update.
6344         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6345         parameter.
6346         (x86_linux_dr_set_addr): Update.
6347         (x86_linux_dr_set_control): Update.
6348         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6349         (iterate_over_lwps): Use gdb::function_view.
6350         * nat/aarch64-linux-hw-point.c (struct
6351         aarch64_dr_update_callback_param): Remove.
6352         (debug_reg_change_callback): Change type.
6353         (aarch64_notify_debug_reg_change): Update.
6354         * s390-linux-nat.c (s390_refresh_per_info): Update.
6355
6356 2019-03-11  Tom Tromey  <tromey@adacore.com>
6357
6358         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6359         redundant assignment to "this_cu".
6360
6361 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6362
6363         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6364
6365 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6366
6367         * gdbtypes.c (rank_one_type_parm_set): New function extracted
6368         from...
6369         (rank_one_type): ... this.
6370
6371 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6372
6373         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6374         from...
6375         (rank_one_type): ... this.
6376
6377 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6378
6379         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6380         from...
6381         (rank_one_type): ... this.
6382
6383 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6384
6385         * gdbtypes.c (rank_one_type_parm_float): New function extracted
6386         from...
6387         (rank_one_type): ... this.
6388
6389 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6390
6391         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6392         from...
6393         (rank_one_type): ... this.
6394
6395 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6396
6397         * gdbtypes.c (rank_one_type_parm_range): New function extracted
6398         from...
6399         (rank_one_type): ... this.
6400
6401 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6402
6403         * gdbtypes.c (rank_one_type_parm_char): New function extracted
6404         from...
6405         (rank_one_type): ... this.
6406
6407 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6408
6409         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
6410         from...
6411         (rank_one_type): ... this.
6412
6413 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6414
6415         * gdbtypes.c (rank_one_type_parm_int): New function extracted
6416         from...
6417         (rank_one_type): ... this.
6418
6419 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6420
6421         * gdbtypes.c (rank_one_type_parm_func): New function extracted
6422         from...
6423         (rank_one_type): ... this.
6424
6425 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6426
6427         * gdbtypes.c (rank_one_type_parm_array): New function extracted
6428         from...
6429         (rank_one_type): ... this.
6430
6431 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6432
6433         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
6434         from...
6435         (rank_one_type): ... this.
6436
6437 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6438
6439         * inferior.c (initialize_inferiors): Ensure 'help set/show print
6440         inferior-events' shows the example events.
6441
6442 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
6443
6444         Support styling on native MS-Windows console
6445
6446         PR/24315
6447         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
6448         on MS-Windows if $TERM is not defined.
6449
6450         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
6451
6452         * posix-hdep.c (gdb_console_fputs):
6453         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
6454         functions.
6455         * ui-file.h (gdb_console_fputs): Add prototype.
6456
6457         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
6458         back to fputs only if the former returns zero.
6459
6460 2019-03-07  Tom Tromey  <tom@tromey.com>
6461
6462         * symmisc.c (print_symbol_bcache_statistics): Update.
6463         (print_objfile_statistics): Update.
6464         * symfile.c (allocate_symtab): Update.
6465         * stabsread.c: Don't include bcache.h.
6466         * psymtab.h (struct psymbol_bcache): Don't declare.
6467         (class psymtab_storage) <psymbol_cache>: Now a bcache.
6468         (psymbol_bcache_init, psymbol_bcache_free)
6469         (psymbol_bcache_get_bcache): Don't declare.
6470         * psymtab.c (struct psymbol_bcache): Remove.
6471         (psymtab_storage::psymtab_storage): Update.
6472         (psymtab_storage::~psymtab_storage): Update.
6473         (psymbol_bcache_init, psymbol_bcache_free)
6474         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
6475         (add_psymbol_to_bcache): Update.
6476         (allocate_psymtab): Update.
6477         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6478         macro_cache>: No longer pointers.
6479         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
6480         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
6481         * macrotab.c (macro_bcache): Update.
6482         * macroexp.c: Don't include bcache.h.
6483         * gdbtypes.c (check_types_worklist): Update.
6484         (types_deeply_equal): Remove TRY/CATCH.  Update.
6485         * elfread.c (elf_symtab_read): Update.
6486         * dwarf2read.c: Don't include bcache.h.
6487         * buildsym.c (buildsym_compunit::get_macro_table): Update.
6488         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
6489         (print_bcache_statistics, bcache_memory_used): Don't declare.
6490         (struct bcache): Move from bcache.c.  Add constructor, destructor,
6491         methods.  Rename all data members.
6492         * bcache.c (struct bcache): Move to bcache.h.
6493         (bcache::expand_hash_table): Rename from expand_hash_table.
6494         (bcache): Remove.
6495         (bcache::insert): Rename from bcache_full.
6496         (bcache::compare): Rename from bcache_compare.
6497         (bcache_xmalloc): Remove.
6498         (bcache::~bcache): Rename from bcache_xfree.
6499         (bcache::print_statistics): Rename from print_bcache_statistics.
6500         (bcache::memory_used): Rename from bcache_memory_used.
6501
6502 2019-03-07  Pedro Alves  <palves@redhat.com>
6503
6504         * infrun.c (normal_stop): Also check for
6505         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
6506
6507 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
6508
6509         * f-lang.c (value_from_host_double): Moved to...
6510         * value.c (value_from_host_double): ...here.
6511         * value.h (value_from_host_double): Declare.
6512         * guile/scm-math.c (vlscm_convert_typed_number): Use
6513         value_from_host_double.
6514         (vlscm_convert_number): Likewise.
6515         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
6516         * python/py-value.c (convert_value_from_python): Likewise.
6517
6518 2019-03-06  Tom Tromey  <tom@tromey.com>
6519
6520         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
6521
6522 2019-03-06  Tom Tromey  <tom@tromey.com>
6523
6524         * utils.h (free_current_contents): Don't declare.
6525         * utils.c (free_current_contents): Remove.
6526
6527 2019-03-06  Tom Tromey  <tom@tromey.com>
6528
6529         * top.c (quit_force): Update.
6530         * main.c (captured_command_loop): Update.
6531         * common/new-op.c (operator new): Update.
6532         * common/common-exceptions.c (struct catcher)
6533         <save_cleanup_chain>: Remove member.
6534         (exceptions_state_mc_init): Update.
6535         (exception_try_scope_entry): Return nullptr.
6536         (exception_try_scope_exit, exception_rethrow)
6537         (throw_exception_sjlj, throw_exception_cxx): Update.
6538         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
6539         (all_cleanups, do_cleanups, discard_cleanups)
6540         (discard_final_cleanups, save_cleanups, save_final_cleanups)
6541         (restore_cleanups, restore_final_cleanups): Don't declare.
6542         (do_final_cleanups): Remove parameter.
6543         * common/cleanups.c (cleanup_chain, make_cleanup)
6544         (make_cleanup_dtor, all_cleanups, do_cleanups)
6545         (discard_my_cleanups, discard_cleanups)
6546         (discard_final_cleanups, save_my_cleanups, save_cleanups)
6547         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
6548         (null_cleanup): Remove.
6549         (do_final_cleanups): Remove parameter.
6550
6551 2019-03-06  Tom Tromey  <tom@tromey.com>
6552
6553         * remote.c (remote_target::remote_parse_stop_reply): Use
6554         unique_xmalloc_ptr.
6555
6556 2019-03-06  Tom Tromey  <tom@tromey.com>
6557
6558         * stabsread.c (struct stabs_field_info): Rename from field_info.
6559         <list, fnlist>: Add initializers.
6560         <obstack>: New member.
6561         (read_member_functions, read_struct_fields, read_baseclasses):
6562         Allocate on obstack.  Don't use cleanups.
6563         (read_one_struct_field, read_member_functions, read_struct_fields)
6564         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
6565         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
6566         (read_struct_type): Update.
6567
6568 2019-03-06  Tom Tromey  <tom@tromey.com>
6569
6570         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
6571         * common/filestuff.h (make_cleanup_close): Don't declare.
6572         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
6573         Remove.
6574
6575 2019-03-06  Tom Tromey  <tom@tromey.com>
6576
6577         * solib-aix.c: Use make_scope_exit.
6578
6579 2019-03-06  Tom Tromey  <tom@tromey.com>
6580
6581         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
6582         Use make_scope_exit.
6583
6584 2019-03-06  Tom Tromey  <tom@tromey.com>
6585
6586         * solib-svr4.c (disable_probes_interface): Remove parameter.
6587         (svr4_handle_solib_event): Use make_scope_exit.
6588
6589 2019-03-06  Tom Tromey  <tom@tromey.com>
6590
6591         * remote.c (struct stop_reply_deleter): Remove.
6592         (stop_reply_up): Update.
6593         (struct stop_reply): Derive from notif_event.  Don't typedef.
6594         <regcache>: Now a std::vector.
6595         (stop_reply_xfree): Remove.
6596         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
6597         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
6598         (remote_target::discard_pending_stop_replies): Use delete.
6599         (remote_target::remote_parse_stop_reply): Update.
6600         (remote_target::process_stop_reply): Update.
6601         * remote-notif.h (struct notif_event): Add virtual destructor.
6602         Remove "dtr" member.
6603         (struct notif_client) <alloc_event>: Return a unique_ptr.
6604         (notif_event_xfree): Don't declare.
6605         (notif_event_up): New typedef.
6606         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
6607         (notif_event_xfree, do_notif_event_xfree): Remove.
6608         (remote_notif_state_xfree): Update.
6609
6610 2019-03-06  Tom Tromey  <tom@tromey.com>
6611
6612         * infrun.c (displaced_step_clear_cleanup): Now a
6613         forward_scope_exit type.
6614         (displaced_step_prepare_throw): Update.
6615         (displaced_step_fixup): Update.
6616
6617 2019-03-06  Tom Tromey  <tom@tromey.com>
6618
6619         * inferior.h (class inferior): Update comment.
6620         * gdbthread.h (class thread_info): Update comment.
6621
6622 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
6623             Tom Tromey  <tom@tromey.com>
6624
6625         * stabsread.h (struct stab_section_list): Remove.
6626         (coffstab_build_psymtabs): Update.
6627         * dbxread.c (symbuf_sections): Now a std::vector.
6628         (sect_idx): New global.
6629         (fill_symbuf): Update.
6630         (coffstab_build_psymtabs): Change type of stabsects parameter.
6631         Update.
6632         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6633         std::vector.
6634         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6635         (coff_locate_sections): Update.
6636         (coff_symfile_read): Remove cleanups.  Update.
6637         (init_stringtab): Add storage parameter.
6638         (free_stringtab, free_stringtab_cleanup): Remove.
6639         (init_lineno): Add storage parameter.
6640         (free_linetab, free_linetab_cleanup): Remove.
6641
6642 2019-03-06  Pedro Alves  <palves@redhat.com>
6643
6644         * linux-fork.c (fork_info::clobber_regs): Delete.
6645         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6646         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
6647         comment.  Adjust.
6648         (scoped_switch_fork_info::scoped_switch_fork_info)
6649         (checkpoint_command, linux_fork_context): Adjust
6650         fork_save_infrun_state calls.
6651
6652 2019-03-06  Pedro Alves  <palves@redhat.com>
6653
6654         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6655         (inf_has_multiple_threads): Return 'bool' and rewrite using
6656         inferior_info::threads().
6657
6658 2019-03-06  Pedro Alves  <palves@redhat.com>
6659
6660         * linux-fork.c: Include <list>.
6661         (fork_list): Now a std::list instance.
6662         (fork_info): Add ctor, dtor, and in-class initialize all fields.
6663         (forks_exist_p, find_last_fork): Adjust.
6664         (new_fork): Delete.
6665         (one_fork_p): New.
6666         (add_fork): Adjust.
6667         (free_fork): Delete, folded into fork_info::~fork_info().
6668         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6669         Adjust.
6670         (init_fork_list): Delete.
6671         (linux_fork_killall, linux_fork_mourn_inferior)
6672         (linux_fork_detach, info_checkpoints_command): Adjust.
6673         (_initialize_linux_fork): No longer call init_fork_list.
6674
6675 2019-03-06  Pedro Alves  <palves@redhat.com>
6676
6677         * linux-fork.c (new_fork): New, split out of ...
6678         (add_fork): ... this.  Return void.  Move "first fork" special
6679         case from here, to ...
6680         (checkpoint_command): ... here.
6681         * linux-linux.h (add_fork): Return void.
6682
6683 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6684
6685         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6686
6687 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6688             Chris January  <chris.january@arm.com>
6689             David Lecomber  <david.lecomber@arm.com>
6690
6691         * f-exp.y: New token, UNOP_INTRINSIC.
6692         (exp): New pattern using UNOP_INTRINSIC token.
6693         (f77_keywords): Add 'abs' keyword.
6694         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
6695         (value_from_host_double): New function.
6696         (evaluate_subexp_f): Support UNOP_ABS.
6697
6698 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6699
6700         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
6701         types.
6702
6703 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6704
6705         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
6706         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
6707         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
6708
6709 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6710
6711         * f-exp.y (convert_to_kind_type): Handle more type kinds.
6712
6713 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6714             Chris January  <chris.january@arm.com>
6715
6716         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
6717         * f-exp.y: Define 'KIND' token.
6718         (exp): New pattern for KIND expressions.
6719         (ptype): Handle types with a kind extension.
6720         (direct_abs_decl): Extend to spot kind extensions.
6721         (f77_keywords): Add 'kind' to the list.
6722         (push_kind_type): New function.
6723         (convert_to_kind_type): New function.
6724         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
6725         * parse.c (operator_length_standard): Likewise.
6726         * parser-defs.h (enum type_pieces): Add tp_kind.
6727         * std-operator.def: Add UNOP_KIND.
6728
6729 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6730
6731         * f-exp.y (f_parse): Set yydebug.
6732
6733 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6734
6735         * f-lang.c (evaluate_subexp_f): New function.
6736         (exp_descriptor_f): New global.
6737         (f_language_defn): Use exp_descriptor_f instead of
6738         exp_descriptor_standard.
6739
6740 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6741
6742         * f-exp.y (struct token): Add comments.
6743         (dot_ops): Remove uppercase versions and the end marker.
6744         (f77_keywords): Likewise.
6745         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
6746         entries in the dot_ops array are case insensitive, and use
6747         strncasecmp to compare strings.  Also some whitespace cleanup in
6748         this area.  Similar for the f77_keywords array, except entries in
6749         this list might be case sensitive.
6750
6751 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6752
6753         * f-exp.y (struct f77_boolean_val): Add comments.
6754         (boolean_values): Remove uppercase versions, and end marker.
6755         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
6756         and use strncasecmp to achieve case insensitivity.  Additionally,
6757         perform whitespace cleanup around this code.
6758
6759 2019-03-06  Tom Tromey  <tromey@adacore.com>
6760
6761         * remote-sim.c (gdbsim_target_open): Use result of
6762         gdb_argv::release.
6763
6764 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
6765         Dirk Schubert  <dirk.schubert@arm.com>
6766         Chris January  <chris.january@arm.com>
6767
6768         * eval.c (evaluate_subexp_standard): Call Fortran argument
6769         wrapping logic.
6770         * f-lang.c (struct value): A value which can be passed into a
6771         Fortran function call.
6772         (fortran_argument_convert): Wrap Fortran arguments in a pointer
6773         where appropriate.
6774         (struct type): Value ready for a Fortran function call.
6775         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
6776         is needed.
6777         * f-lang.h (fortran_argument_convert): Declaration.
6778         (fortran_preserve_arg_pointer): Declaration.
6779         * infcall.c (value_arg_coerce): Call Fortran argument logic.
6780
6781 2019-03-05  Tom Tromey  <tromey@adacore.com>
6782
6783         * python/py-prettyprint.c (print_string_repr): Remove #if.
6784         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
6785
6786 2019-03-05  Tom Tromey  <tromey@adacore.com>
6787
6788         * target.c (the_dummy_target): Move later.  Change type to
6789         "dummy_target".
6790         (initialize_targets): Don't initialize the_dummy_target.
6791
6792 2019-03-05  Tom Tromey  <tromey@adacore.com>
6793
6794         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
6795         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
6796
6797 2019-03-05  Tom Tromey  <tromey@adacore.com>
6798
6799         * windows-nat.c (windows_nat_target::attach)
6800         (windows_nat_target::detach): Don't call gdb_flush.
6801         * valprint.c (generic_val_print, val_print, val_print_string):
6802         Don't call gdb_flush.
6803         * utils.c (defaulted_query): Don't call gdb_flush.
6804         * typeprint.c (print_type_scalar): Don't call gdb_flush.
6805         * target.c (target_announce_detach): Don't call gdb_flush.
6806         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
6807         * remote.c (extended_remote_target::attach): Don't call
6808         gdb_flush.
6809         * procfs.c (procfs_target::detach): Don't call gdb_flush.
6810         * printcmd.c (do_examine): Don't call gdb_flush.
6811         (info_display_command): Don't call gdb_flush.
6812         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
6813         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
6814         * memattr.c (info_mem_command): Don't call gdb_flush.
6815         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
6816         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
6817         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
6818         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
6819         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
6820         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
6821         (gnu_nat_target::detach): Don't call gdb_flush.
6822         * f-valprint.c (f_val_print): Don't call gdb_flush.
6823         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
6824         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
6825         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
6826         gdb_flush.
6827         * c-valprint.c (c_val_print): Don't call gdb_flush.
6828         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
6829
6830 2019-03-05  Tom Tromey  <tromey@adacore.com>
6831
6832         * varobj.c (update_dynamic_varobj_children): Update.
6833         (install_default_visualizer): Use reset, not release.
6834         * value.c (set_internalvar): Update.
6835         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
6836         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
6837         ATTRIBUTE_UNUSED_RESULT.
6838
6839 2019-03-05  Tom Tromey  <tromey@adacore.com>
6840
6841         * remote.c (class scoped_remote_fd) <release>: Add
6842         ATTRIBUTE_UNUSED_RESULT.
6843
6844 2019-03-05  Tom Tromey  <tromey@adacore.com>
6845
6846         * macroexp.c (struct macro_buffer) <release>: Add
6847         ATTRIBUTE_UNUSED_RESULT.
6848
6849 2019-03-05  Tom Tromey  <tromey@adacore.com>
6850
6851         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
6852         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
6853         ATTRIBUTE_UNUSED_RESULT.
6854
6855 2019-03-05  Tom Tromey  <tromey@adacore.com>
6856
6857         * common/scoped_fd.h (class scoped_fd) <release>: Add
6858         ATTRIBUTE_UNUSED_RESULT.
6859
6860 2019-03-05  Tom Tromey  <tromey@adacore.com>
6861
6862         * parser-defs.h (struct parser_state) <release>: Add
6863         ATTRIBUTE_UNUSED_RESULT.
6864
6865 2019-03-05  Tom Tromey  <tromey@adacore.com>
6866
6867         * utils.h (class gdb_argv) <release>: Add
6868         ATTRIBUTE_UNUSED_RESULT.
6869         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
6870
6871 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
6872
6873         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
6874         for-loop range, to avoid compiler warnings.
6875
6876         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
6877         avoid compiler warnings about unused variables.
6878
6879         * NEWS: Mention end of support for native debugging on MS-Windows
6880         before XP.
6881
6882         PR gdb/24292
6883         * common/netstuff.c:
6884         * gdbserver/gdbreplay.c
6885         * gdbserver/remote-utils.c:
6886         * ser-tcp.c:
6887         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
6888         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
6889         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
6890         'getaddrinfo' and 'freeaddrinfo' were not available before
6891         Windows XP, and mingw.org's MinGW headers by default define
6892         _WIN32_WINNT to 0x500.
6893
6894 2019-03-01  Gary Benson <gbenson@redhat.com>
6895
6896         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
6897
6898 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
6899             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
6900
6901         PR gdb/8527
6902         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
6903         set_sigint_trap, clear_sigint_trap.
6904
6905 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6906
6907         * target.c (target_detach): Clear the regcache and the
6908         frame cache.
6909
6910 2019-02-27  Pedro Alves  <palves@redhat.com>
6911
6912         * utils.c (set_screen_size): When we cap the height/width sizes,
6913         tweak the corresponding command variable to show "unlimited":
6914
6915 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
6916             Pedro Alves  <palves@redhat.com>
6917
6918         * utils.c (set_screen_size): Reduce "infinite" rows and columns
6919         before calling rl_set_screen_size.
6920
6921 2019-02-27  Tom Tromey  <tromey@adacore.com>
6922
6923         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
6924         define.
6925         * python/py-value.c: Remove Python 2.4 workaround.
6926         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
6927         workaround.
6928         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
6929         Python 2.4 workaround.
6930         * python/python-internal.h: Remove Python 2.4 comment.
6931         (Py_ssize_t): Don't define.
6932         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
6933         (gdb_Py_DECREF): Remove Python 2.4 workaround.
6934         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
6935         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
6936         * python/python.c (do_start_initialization): Remove Python 2.4
6937         workaround.
6938         * python/py-prettyprint.c (class dummy_python_frame): Remove.
6939         (print_children): Remove Python 2.4 workaround.
6940         * python/py-inferior.c (buffer_procs): Remove Python 2.4
6941         workaround.
6942         (CHARBUFFERPROC_NAME): Remove.
6943         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
6944         Python 2.4 workaround.
6945
6946 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6947
6948         * NEWS: Note minimum Python version.
6949
6950 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6951
6952         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
6953         code from these functions.  Remove corresponding ifdefs.  Use
6954         Py_buffer_up instead of explicit calls to PyBuffer_Release.
6955         Remove gotos and target of gotos.
6956         (infpy_search_memory): Likewise.
6957
6958 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6959
6960         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
6961         (hppa_gdbarch_init): Don't register deleted functions with
6962         gdbarch.
6963
6964 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6965
6966         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
6967         (h8300_unwind_sp): Delete.
6968         (h8300_dummy_id): Delete.
6969         (h8300_gdbarch_init): Don't register deleted functions with
6970         gdbarch.
6971
6972 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6973
6974         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
6975         (ft32_unwind_pc): Delete.
6976         (ft32_unwind_sp): Delete.
6977         (ft32_gdbarch_init): Don't register deleted functions with
6978         gdbarch.
6979
6980 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6981
6982         * gdb/frv-tdep.c (frv_dummy_id): Delete.
6983         (frv_unwind_pc): Delete.
6984         (frv_unwind_sp): Delete.
6985         (frv_gdbarch_init): Don't register deleted functions with
6986         gdbarch.
6987
6988 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6989
6990         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
6991         (riscv_unwind_pc): Delete.
6992         (riscv_unwind_sp): Delete.
6993         (riscv_gdbarch_init): Don't register deleted functions with
6994         gdbarch.
6995
6996 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6997
6998         * gdb/csky-tdep.c (csky_dummy_id): Delete.
6999         (csky_unwind_pc): Delete.
7000         (csky_unwind_sp): Delete.
7001         (csky_gdbarch_init): Don't register deleted functions with
7002         gdbarch.
7003
7004 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7005
7006         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7007         (cris_unwind_pc): Delete.
7008         (cris_unwind_sp): Delete.
7009         (cris_gdbarch_init): Don't register deleted functions with
7010         gdbarch.
7011
7012 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7013
7014         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7015         (bfin_unwind_pc): Delete.
7016         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7017
7018 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7019
7020         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7021         (arm_unwind_pc): Delete.
7022         (arm_unwind_sp): Delete.
7023         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7024
7025 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7026
7027         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7028         (arc_unwind_pc): Delete.
7029         (arc_unwind_sp): Delete.
7030         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7031
7032 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7033
7034         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7035         (alpha_unwind_pc): Delete.
7036         (alpha_gdbarch_init): Don't register deleted functions with
7037         gdbarch.
7038
7039 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7040
7041         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7042         (aarch64_unwind_pc): Delete.
7043         (aarch64_unwind_sp): Delete.
7044         (aarch64_gdbarch_init): Don't register deleted functions with
7045         gdbarch.
7046
7047 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7048
7049         * gdbtypes.c (type_align): Don't consider static members when
7050         computing structure alignment.
7051
7052 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7053
7054         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7055         return 0 for other types.
7056         * arch-utils.c (default_type_align): Always return 0.
7057         * gdbarch.h: Regenerate.
7058         * gdbarch.sh (type_align): Extend comment.
7059         * gdbtypes.c (type_align): Add additional comments, always call
7060         gdbarch_type_align before applying the default rules.
7061         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7062         generic code will then apply a suitable default.
7063         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7064         types, return 0 for other types.
7065
7066 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7067
7068         * NEWS: Create a new section for the next release branch.
7069         Rename the section of the current branch, now that it has
7070         been cut.
7071
7072 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7073
7074         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7075         * version.in: Bump version to 8.3.50.DATE-git.
7076
7077 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7078
7079         * aix-thread.c (ptid_cmp): Remove unused variable.
7080         (get_signaled_thread): Likewise.
7081         (store_regs_user_thread): Likewise.
7082         (store_regs_kernel_thread): Likewise.
7083         (fetch_regs_kernel_thread): Remove shadowed variable.
7084
7085 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7086
7087         * features/riscv/32bit-cpu.xml: Add register numbers.
7088         * features/riscv/32bit-fpu.c: Regenerate.
7089         * features/riscv/32bit-fpu.xml: Add register numbers.
7090         * features/riscv/64bit-cpu.xml: Add register numbers.
7091         * features/riscv/64bit-fpu.c: Regenerate.
7092         * features/riscv/64bit-fpu.xml: Add register numbers.
7093
7094 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7095
7096         * NEWS: Mention two argument form of gdb.Value constructor.
7097         * python/py-value.c (convert_buffer_and_type_to_value): New
7098         function.
7099         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7100         Add support for handling an optional second argument.  Call
7101         convert_buffer_and_type_to_value as appropriate.
7102         * python/python-internal.h (Py_buffer_deleter): New struct.
7103         (Py_buffer_up): New typedef.
7104
7105 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7106
7107         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7108         instead of releasing ownership.
7109
7110 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7111
7112         * dwarf2read.c (open_and_init_dwp_file): Call
7113         elf_numsections instead of bfd_count_sections to initialize
7114         dwp_file->num_sections.
7115
7116 2019-02-25  Tom Tromey  <tromey@adacore.com>
7117
7118         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7119
7120 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7121
7122         * gcore.in: Add '--readnever' option when invoking GDB.
7123
7124 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7125
7126         * MAINTAINERS: Update my email address.
7127
7128 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7129
7130         * build-id.c (build_id_to_debug_bfd_1): New function.
7131         (build_id_to_debug_bfd): Look for separate debug file in
7132         sysroot.
7133
7134 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7135
7136         * gdbarch.sh: Update the copyright year range that is placed into
7137         generated files.
7138
7139 2019-02-22  Keith Seitz  <keiths@redhat.com>
7140
7141         PR symtab/23853
7142         * linespec.c (create_sals_line_offset): Search for the default
7143         symtab's filename instead of its fullname.
7144
7145 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7146
7147         * NEWS: Update style defaults.
7148
7149 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7150
7151         * main.c (captured_main_1): Disable styling in batch mode.
7152
7153 2019-02-20  Tom Tromey  <tom@tromey.com>
7154
7155         * symtab.c (symtab_symbol_info): Fix typos.
7156
7157 2019-02-20  Tom Tromey  <tromey@adacore.com>
7158
7159         * findcmd.c (_initialize_mem_search): Use upper case for
7160         metasyntactic variables.
7161
7162 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7163
7164         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7165         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7166
7167 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7168
7169         * top.h (source_file_name): Change to std::string.
7170         * top.c (source_file_name): Likewise.
7171         (command_line_input): Adjust.
7172         * cli/cli-script.c (script_from_file): Adjust.
7173
7174 2019-02-19  Tom Tromey  <tromey@adacore.com>
7175
7176         * ravenscar-thread.c
7177         (ravenscar_thread_target::update_thread_list): Don't call
7178         ada_build_task_list.
7179         * ada-lang.h (ada_build_task_list): Don't declare.
7180         * ada-tasks.c (struct ada_tasks_inferior_data)
7181         <task_list_valid_p>: Now bool.
7182         (read_known_tasks, ada_task_list_changed)
7183         (ada_tasks_invalidate_inferior_data): Update.
7184         (read_known_tasks_array): Return bool.
7185         (read_known_tasks_list): Likewise.
7186         (read_known_tasks): Return void.
7187         (ada_build_task_list): Now static.
7188
7189 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7190
7191         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7192         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7193
7194 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7195
7196         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7197         variant for ada_tasks_pspace_data_handle and
7198         ada_tasks_inferior_data_handle.
7199         (ada_tasks_pspace_data_cleanup): New function.
7200         (ada_tasks_inferior_data_cleanup): New function.
7201
7202 2019-02-17  Tom Tromey  <tom@tromey.com>
7203
7204         * macrotab.h (macro_source_fullname): Return a std::string.
7205         * macrotab.c (macro_include, check_for_redefinition)
7206         (macro_undef, macro_lookup_definition, foreach_macro)
7207         (foreach_macro_in_scope): Update.
7208         (macro_source_fullname): Return a std::string.
7209         * macrocmd.c (show_pp_source_pos): Update.
7210
7211 2019-02-17  Tom Tromey  <tom@tromey.com>
7212
7213         * macrocmd.c (show_pp_source_pos): Style the file names.
7214
7215 2019-02-17  Tom Tromey  <tom@tromey.com>
7216
7217         PR tui/24197:
7218         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7219
7220 2019-02-17  Tom Tromey  <tom@tromey.com>
7221
7222         * ada-lang.c (user_select_syms): Use filtered printing.
7223         * utils.c (wrap_style): New global.
7224         (desired_style): Remove.
7225         (emit_style_escape): Add stream parameter.
7226         (set_output_style, reset_terminal_style, prompt_for_continue):
7227         Update.
7228         (flush_wrap_buffer): Only flush gdb_stdout.
7229         (wrap_here): Set wrap_style.
7230         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7231         treat escape sequences as a character.  Change when wrap buffer is
7232         flushed.
7233         (fputs_styled): Do not set the output style when the default is
7234         requested.
7235         * ui-style.h (struct ui_file_style) <is_default>: New method.
7236         * source.c (print_source_lines_base): Emit escape sequences in one
7237         piece.
7238
7239 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7240
7241         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7242         integers and enumeration types.
7243
7244 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7245
7246         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7247         instead of lookup_symbol_in_language
7248         (do_exact_match): New function.
7249         (ada_get_symbol_name_matcher): Return do_exact_match when
7250         doing a verbatim match.
7251
7252 2019-02-15  Tom Tromey  <tromey@adacore.com>
7253
7254         * ravenscar-thread.c (ravenscar_thread_target::resume)
7255         (ravenscar_thread_target::wait): Special case wildcard requests.
7256
7257 2019-02-15  Tom Tromey  <tromey@adacore.com>
7258
7259         * ravenscar-thread.c (base_ptid): Remove.
7260         (struct ravenscar_thread_target) <close>: New method.
7261         <m_base_ptid>: New member.
7262         <update_inferior_ptid, active_task, task_is_currently_active,
7263         runtime_initialized>: Declare methods.
7264         <ravenscar_thread_target>: Add constructor.
7265         (ravenscar_thread_target::task_is_currently_active)
7266         (ravenscar_thread_target::update_inferior_ptid)
7267         (ravenscar_runtime_initialized): Rename.  Now methods.
7268         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7269         (ravenscar_thread_target::update_thread_list): Update.
7270         (ravenscar_thread_target::active_task): Now method.
7271         (ravenscar_thread_target::store_registers)
7272         (ravenscar_thread_target::prepare_to_store)
7273         (ravenscar_thread_target::prepare_to_store)
7274         (ravenscar_thread_target::mourn_inferior): Update.
7275         (ravenscar_inferior_created): Use "new" to create target.
7276         (ravenscar_thread_target::get_ada_task_ptid): Update.
7277         (_initialize_ravenscar): Don't initialize base_ptid.
7278         (ravenscar_ops): Remove global.
7279
7280 2019-02-15  Tom Tromey  <tromey@adacore.com>
7281
7282         * target.h (push_target): Declare new overload.
7283         * target.c (push_target): New overload, taking an rvalue reference.
7284         * remote.c (remote_target::open_1): Use push_target overload.
7285         * corelow.c (core_target_open): Use push_target overload.
7286
7287 2019-02-15  Tom Tromey  <tromey@adacore.com>
7288
7289         * ravenscar-thread.c (is_ravenscar_task)
7290         (ravenscar_task_is_currently_active): Return bool.
7291         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7292         (_initialize_ravenscar): Remove "(void)".
7293         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7294         Return bool.
7295
7296 2019-02-15  Tom Tromey  <tromey@adacore.com>
7297
7298         * ravenscar-thread.c (ravenscar_runtime_initializer)
7299         (has_ravenscar_runtime, get_running_thread_id)
7300         (ravenscar_thread_target::resume): Fix indentation.
7301
7302 2019-02-15  Tom Tromey  <tromey@adacore.com>
7303
7304         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7305         from ravenscar_arch_ops.
7306         (sparc_ravenscar_ops::fetch_registers)
7307         (sparc_ravenscar_ops::store_registers): Now methods.
7308         (sparc_ravenscar_prepare_to_store): Remove.
7309         (sparc_ravenscar_ops): Redefine.
7310         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7311         methods and destructor.  Remove members.
7312         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7313         (ravenscar_thread_target::store_registers)
7314         (ravenscar_thread_target::prepare_to_store): Update.
7315         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7316         Remove.
7317         (struct ppc_ravenscar_powerpc_ops): Derive from
7318         ravenscar_arch_ops.
7319         (ppc_ravenscar_powerpc_ops::fetch_registers)
7320         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7321         (ppc_ravenscar_powerpc_ops): Redefine.
7322         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7323         (ppc_ravenscar_e500_ops::fetch_registers)
7324         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7325         (ppc_ravenscar_e500_ops): Redefine.
7326         * aarch64-ravenscar-thread.c
7327         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7328         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7329         (aarch64_ravenscar_fetch_registers)
7330         (aarch64_ravenscar_store_registers): Now methods.
7331         (aarch64_ravenscar_ops): Redefine.
7332
7333 2019-02-15  Tom Tromey  <tromey@adacore.com>
7334
7335         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7336         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7337         (ravenscar_thread_target::stopped_by_watchpoint)
7338         (ravenscar_thread_target::stopped_data_address)
7339         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7340
7341 2019-02-15  Tom Tromey  <tromey@adacore.com>
7342
7343         * ravenscar-thread.c: Fix some typos.
7344
7345 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7346             Tom Tromey  <tromey@adacore.com>
7347
7348         * ada-lang.c (ada_exception_sal): Change addr_string to a
7349         std::string.
7350         (create_ada_exception_catchpoint): Update.
7351
7352 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7353             Tom Tromey  <tromey@adacore.com>
7354
7355         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7356         (bp_location_ops): Remove.
7357         (base_breakpoint_allocate_location): Update.
7358         (free_bp_location): Update.
7359         * ada-lang.c (class ada_catchpoint_location)
7360         <ada_catchpoint_location>: Remove ops parameter.
7361         (ada_catchpoint_location_dtor): Remove.
7362         (ada_catchpoint_location_ops): Remove.
7363         (allocate_location_exception): Update.
7364         * breakpoint.h (struct bp_location_ops): Remove.
7365         (class bp_location) <bp_location>: Remove bp_location_ops
7366         parameter.
7367         <~bp_location>: Add destructor.
7368         <ops>: Remove.
7369
7370 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7371             Pedro Alves  <palves@redhat.com>
7372
7373         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7374         'PATH_MAX'.
7375
7376 2019-02-14  David Michael  <fedora.dm0@gmail.com>
7377             Samuel Thibault  <samuel.thibault@gnu.org>
7378             Thomas Schwinge  <thomas@codesourcery.com>
7379
7380         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7381         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
7382
7383 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7384
7385         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7386         (check_empty): Use "const char *".
7387
7388         * gnu-nat.c (gnu_nat_target::detach): Instead of
7389         'detach_inferior (pid)' call
7390         'detach_inferior (find_inferior_pid (pid))'.
7391
7392         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7393         'nat/fork-inferior.o'.
7394         * gnu-nat.c: #include "nat/fork-inferior.h".
7395
7396         * gnu-nat.c (gnu_nat_target::detach): Instead of
7397         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
7398         * gnu-nat.h: #include "inf-child.h".
7399         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
7400         'i386_gnu_nat_target::fetch_registers'.
7401         (gnu_store_registers): Rename/move to
7402         'i386_gnu_nat_target::store_registers'.
7403
7404         * config/i386/nm-i386gnu.h: Don't "#include" any files.
7405         * gnu-nat.h (mach_thread_info): New function.
7406         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
7407
7408         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
7409
7410 2019-02-14  Frederic Konrad  <konrad@adacore.com>
7411
7412         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
7413
7414 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
7415
7416         * windows-nat.c (windows_add_thread): Add new parameter
7417         "main_thread_p" with default value set to false.  Update
7418         function documentation as well as all callers.
7419         (windows_delete_thread): Likewise.
7420         (fake_create_process): Update call to windows_add_thread.
7421         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
7422         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
7423         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
7424         call to windows_delete_thread.
7425
7426 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
7427
7428         * MAINTAINERS: Add Andrew Burgess as global maintainer.
7429
7430 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7431
7432         * symfile.c (find_separate_debug_file): Use canonical path of
7433         sysroot with child_path instead of gdb_sysroot if it is valid.
7434
7435 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7436
7437         * symfile.c (find_separate_debug_file): Use child_path to
7438         determine if an object file is under a sysroot.
7439
7440 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7441
7442         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
7443         unittests/child-path-selftests.c.
7444         * common/pathstuff.c (child_path): New function.
7445         * common/pathstuff.h (child_path): New prototype.
7446         * unittests/child-path-selftests.c: New file.
7447
7448 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7449
7450         * symfile.c (find_separate_debug_file): Look for separate debug
7451         files in debug directories under the sysroot.
7452
7453 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7454
7455         * symtab.h (struct minimal_symbol data_p): New const method.
7456         (struct minimal_symbol text_p): Likewise.
7457         * symtab.c (output_source_filename): Use file name style
7458         to print file name.
7459         (print_symbol_info): Likewise.
7460         (print_msymbol_info): Use address style to print addresses.
7461         Use function name style to print executable text symbols.
7462         (expand_symtab_containing_pc): Use data_p.
7463         (find_pc_sect_compunit_symtab): Likewise.
7464
7465 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7466
7467         * breakpoint.c (describe_other_breakpoints): Use address style
7468         to print addresses.
7469         (say_where): Likewise.
7470
7471 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7472
7473         * ada-typeprint.c (print_func_type): Print function name
7474         style to print function name.
7475         * c-typeprint.c (c_print_type_1): Likewise.
7476
7477 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
7478
7479         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
7480         for execve.
7481
7482 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7483
7484         * c-exp.y (direct_abs_decl): Use emplace_back to record the
7485         type_stack.
7486
7487 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
7488
7489         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
7490         TYPE_CODE_REF types.
7491
7492 2019-02-08  Jim Wilson  <jimw@sifive.com>
7493
7494         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
7495         (riscv_linux_fregset): New.
7496         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
7497
7498 2019-02-07  Tom Tromey  <tom@tromey.com>
7499
7500         * thread.c (thread_cancel_execution_command): Update.
7501         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
7502         methods.
7503         (struct thread_fsm_ops): Remove.
7504         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
7505         (thread_fsm_should_stop, thread_fsm_return_value)
7506         (thread_fsm_set_finished, thread_fsm_finished_p)
7507         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
7508         Don't declare.
7509         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
7510         * infrun.c (clear_proceed_status_thread)
7511         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
7512         (print_stop_event): Update.
7513         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
7514         Add constructor.
7515         (step_command_fsm_ops): Remove.
7516         (new_step_command_fsm): Remove.
7517         (step_1): Update.
7518         (step_command_fsm::should_stop): Rename from
7519         step_command_fsm_should_stop.
7520         (step_command_fsm::clean_up): Rename from
7521         step_command_fsm_clean_up.
7522         (step_command_fsm::do_async_reply_reason): Rename from
7523         step_command_fsm_async_reply_reason.
7524         (struct until_next_fsm): Inherit from thread_fsm.  Add
7525         constructor.
7526         (until_next_fsm_ops): Remove.
7527         (new_until_next_fsm): Remove.
7528         (until_next_fsm::should_stop): Rename from
7529         until_next_fsm_should_stop.
7530         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
7531         (until_next_fsm::do_async_reply_reason): Rename from
7532         until_next_fsm_async_reply_reason.
7533         (struct finish_command_fsm): Inherit from thread_fsm.  Add
7534         constructor.  Change type of breakpoint.
7535         (finish_command_fsm_ops): Remove.
7536         (new_finish_command_fsm): Remove.
7537         (finish_command_fsm::should_stop): Rename from
7538         finish_command_fsm_should_stop.
7539         (finish_command_fsm::clean_up): Rename from
7540         finish_command_fsm_clean_up.
7541         (finish_command_fsm::return_value): Rename from
7542         finish_command_fsm_return_value.
7543         (finish_command_fsm::do_async_reply_reason): Rename from
7544         finish_command_fsm_async_reply_reason.
7545         (finish_command): Update.
7546         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
7547         Add constructor.
7548         (call_thread_fsm_ops): Remove.
7549         (call_thread_fsm::call_thread_fsm): Rename from
7550         new_call_thread_fsm.
7551         (call_thread_fsm::should_stop): Rename from
7552         call_thread_fsm_should_stop.
7553         (call_thread_fsm::should_notify_stop): Rename from
7554         call_thread_fsm_should_notify_stop.
7555         (run_inferior_call, call_function_by_hand_dummy): Update.
7556         * cli/cli-interp.c (should_print_stop_to_console): Update.
7557         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
7558         Add constructor.  Change type of location_breakpoint,
7559         caller_breakpoint.
7560         (until_break_fsm_ops): Remove.
7561         (new_until_break_fsm): Remove.
7562         (until_break_fsm::should_stop): Rename from
7563         until_break_fsm_should_stop.
7564         (until_break_fsm::clean_up): Rename from
7565         until_break_fsm_clean_up.
7566         (until_break_fsm::do_async_reply_reason): Rename from
7567         until_break_fsm_async_reply_reason.
7568         (until_break_command): Update.
7569         * thread-fsm.c: Remove.
7570         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
7571
7572 2019-02-07  Tom Tromey  <tom@tromey.com>
7573
7574         * yy-remap.h: Add include guard.
7575         * xtensa-tdep.h: Add include guard.
7576         * xcoffread.h: Rename include guard.
7577         * varobj-iter.h: Add include guard.
7578         * tui/tui.h: Rename include guard.
7579         * tui/tui-winsource.h: Rename include guard.
7580         * tui/tui-wingeneral.h: Rename include guard.
7581         * tui/tui-windata.h: Rename include guard.
7582         * tui/tui-win.h: Rename include guard.
7583         * tui/tui-stack.h: Rename include guard.
7584         * tui/tui-source.h: Rename include guard.
7585         * tui/tui-regs.h: Rename include guard.
7586         * tui/tui-out.h: Rename include guard.
7587         * tui/tui-layout.h: Rename include guard.
7588         * tui/tui-io.h: Rename include guard.
7589         * tui/tui-hooks.h: Rename include guard.
7590         * tui/tui-file.h: Rename include guard.
7591         * tui/tui-disasm.h: Rename include guard.
7592         * tui/tui-data.h: Rename include guard.
7593         * tui/tui-command.h: Rename include guard.
7594         * tic6x-tdep.h: Add include guard.
7595         * target/waitstatus.h: Rename include guard.
7596         * target/wait.h: Rename include guard.
7597         * target/target.h: Rename include guard.
7598         * target/resume.h: Rename include guard.
7599         * target-float.h: Rename include guard.
7600         * stabsread.h: Add include guard.
7601         * rs6000-tdep.h: Add include guard.
7602         * riscv-fbsd-tdep.h: Add include guard.
7603         * regformats/regdef.h: Rename include guard.
7604         * record.h: Rename include guard.
7605         * python/python.h: Rename include guard.
7606         * python/python-internal.h: Rename include guard.
7607         * python/py-stopevent.h: Rename include guard.
7608         * python/py-ref.h: Rename include guard.
7609         * python/py-record.h: Rename include guard.
7610         * python/py-record-full.h: Rename include guard.
7611         * python/py-record-btrace.h: Rename include guard.
7612         * python/py-instruction.h: Rename include guard.
7613         * python/py-events.h: Rename include guard.
7614         * python/py-event.h: Rename include guard.
7615         * procfs.h: Add include guard.
7616         * proc-utils.h: Add include guard.
7617         * p-lang.h: Add include guard.
7618         * or1k-tdep.h: Rename include guard.
7619         * observable.h: Rename include guard.
7620         * nto-tdep.h: Rename include guard.
7621         * nat/x86-linux.h: Rename include guard.
7622         * nat/x86-linux-dregs.h: Rename include guard.
7623         * nat/x86-gcc-cpuid.h: Add include guard.
7624         * nat/x86-dregs.h: Rename include guard.
7625         * nat/x86-cpuid.h: Rename include guard.
7626         * nat/ppc-linux.h: Rename include guard.
7627         * nat/mips-linux-watch.h: Rename include guard.
7628         * nat/linux-waitpid.h: Rename include guard.
7629         * nat/linux-ptrace.h: Rename include guard.
7630         * nat/linux-procfs.h: Rename include guard.
7631         * nat/linux-osdata.h: Rename include guard.
7632         * nat/linux-nat.h: Rename include guard.
7633         * nat/linux-namespaces.h: Rename include guard.
7634         * nat/linux-btrace.h: Rename include guard.
7635         * nat/glibc_thread_db.h: Rename include guard.
7636         * nat/gdb_thread_db.h: Rename include guard.
7637         * nat/gdb_ptrace.h: Rename include guard.
7638         * nat/fork-inferior.h: Rename include guard.
7639         * nat/amd64-linux-siginfo.h: Rename include guard.
7640         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7641         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7642         * nat/aarch64-linux.h: Rename include guard.
7643         * nat/aarch64-linux-hw-point.h: Rename include guard.
7644         * mn10300-tdep.h: Add include guard.
7645         * mips-linux-tdep.h: Add include guard.
7646         * mi/mi-parse.h: Rename include guard.
7647         * mi/mi-out.h: Rename include guard.
7648         * mi/mi-main.h: Rename include guard.
7649         * mi/mi-interp.h: Rename include guard.
7650         * mi/mi-getopt.h: Rename include guard.
7651         * mi/mi-console.h: Rename include guard.
7652         * mi/mi-common.h: Rename include guard.
7653         * mi/mi-cmds.h: Rename include guard.
7654         * mi/mi-cmd-break.h: Rename include guard.
7655         * m2-lang.h: Add include guard.
7656         * location.h: Rename include guard.
7657         * linux-record.h: Rename include guard.
7658         * linux-nat.h: Add include guard.
7659         * linux-fork.h: Add include guard.
7660         * i386-darwin-tdep.h: Rename include guard.
7661         * hppa-linux-offsets.h: Add include guard.
7662         * guile/guile.h: Rename include guard.
7663         * guile/guile-internal.h: Rename include guard.
7664         * gnu-nat.h: Rename include guard.
7665         * gdb-stabs.h: Rename include guard.
7666         * frv-tdep.h: Add include guard.
7667         * f-lang.h: Add include guard.
7668         * event-loop.h: Add include guard.
7669         * darwin-nat.h: Rename include guard.
7670         * cp-abi.h: Rename include guard.
7671         * config/sparc/nm-sol2.h: Rename include guard.
7672         * config/nm-nto.h: Rename include guard.
7673         * config/nm-linux.h: Add include guard.
7674         * config/i386/nm-i386gnu.h: Rename include guard.
7675         * config/djgpp/nl_types.h: Rename include guard.
7676         * config/djgpp/langinfo.h: Rename include guard.
7677         * compile/gcc-cp-plugin.h: Add include guard.
7678         * compile/gcc-c-plugin.h: Add include guard.
7679         * compile/compile.h: Rename include guard.
7680         * compile/compile-object-run.h: Rename include guard.
7681         * compile/compile-object-load.h: Rename include guard.
7682         * compile/compile-internal.h: Rename include guard.
7683         * compile/compile-cplus.h: Rename include guard.
7684         * compile/compile-c.h: Rename include guard.
7685         * common/xml-utils.h: Rename include guard.
7686         * common/x86-xstate.h: Rename include guard.
7687         * common/version.h: Rename include guard.
7688         * common/vec.h: Rename include guard.
7689         * common/tdesc.h: Rename include guard.
7690         * common/selftest.h: Rename include guard.
7691         * common/scoped_restore.h: Rename include guard.
7692         * common/scoped_mmap.h: Rename include guard.
7693         * common/scoped_fd.h: Rename include guard.
7694         * common/safe-iterator.h: Rename include guard.
7695         * common/run-time-clock.h: Rename include guard.
7696         * common/refcounted-object.h: Rename include guard.
7697         * common/queue.h: Rename include guard.
7698         * common/ptid.h: Rename include guard.
7699         * common/print-utils.h: Rename include guard.
7700         * common/preprocessor.h: Rename include guard.
7701         * common/pathstuff.h: Rename include guard.
7702         * common/observable.h: Rename include guard.
7703         * common/netstuff.h: Rename include guard.
7704         * common/job-control.h: Rename include guard.
7705         * common/host-defs.h: Rename include guard.
7706         * common/gdb_wait.h: Rename include guard.
7707         * common/gdb_vecs.h: Rename include guard.
7708         * common/gdb_unlinker.h: Rename include guard.
7709         * common/gdb_unique_ptr.h: Rename include guard.
7710         * common/gdb_tilde_expand.h: Rename include guard.
7711         * common/gdb_sys_time.h: Rename include guard.
7712         * common/gdb_string_view.h: Rename include guard.
7713         * common/gdb_splay_tree.h: Rename include guard.
7714         * common/gdb_setjmp.h: Rename include guard.
7715         * common/gdb_ref_ptr.h: Rename include guard.
7716         * common/gdb_optional.h: Rename include guard.
7717         * common/gdb_locale.h: Rename include guard.
7718         * common/gdb_assert.h: Rename include guard.
7719         * common/filtered-iterator.h: Rename include guard.
7720         * common/filestuff.h: Rename include guard.
7721         * common/fileio.h: Rename include guard.
7722         * common/environ.h: Rename include guard.
7723         * common/common-utils.h: Rename include guard.
7724         * common/common-types.h: Rename include guard.
7725         * common/common-regcache.h: Rename include guard.
7726         * common/common-inferior.h: Rename include guard.
7727         * common/common-gdbthread.h: Rename include guard.
7728         * common/common-exceptions.h: Rename include guard.
7729         * common/common-defs.h: Rename include guard.
7730         * common/common-debug.h: Rename include guard.
7731         * common/cleanups.h: Rename include guard.
7732         * common/buffer.h: Rename include guard.
7733         * common/btrace-common.h: Rename include guard.
7734         * common/break-common.h: Rename include guard.
7735         * cli/cli-utils.h: Rename include guard.
7736         * cli/cli-style.h: Rename include guard.
7737         * cli/cli-setshow.h: Rename include guard.
7738         * cli/cli-script.h: Rename include guard.
7739         * cli/cli-interp.h: Rename include guard.
7740         * cli/cli-decode.h: Rename include guard.
7741         * cli/cli-cmds.h: Rename include guard.
7742         * charset-list.h: Add include guard.
7743         * buildsym-legacy.h: Rename include guard.
7744         * bfin-tdep.h: Add include guard.
7745         * ax.h: Rename include guard.
7746         * arm-linux-tdep.h: Add include guard.
7747         * arm-fbsd-tdep.h: Add include guard.
7748         * arch/xtensa.h: Rename include guard.
7749         * arch/tic6x.h: Add include guard.
7750         * arch/i386.h: Add include guard.
7751         * arch/arm.h: Rename include guard.
7752         * arch/arm-linux.h: Rename include guard.
7753         * arch/arm-get-next-pcs.h: Rename include guard.
7754         * arch/amd64.h: Add include guard.
7755         * arch/aarch64-insn.h: Rename include guard.
7756         * arch-utils.h: Rename include guard.
7757         * annotate.h: Add include guard.
7758         * amd64-darwin-tdep.h: Rename include guard.
7759         * aarch64-linux-tdep.h: Add include guard.
7760         * aarch64-fbsd-tdep.h: Add include guard.
7761         * aarch32-linux-nat.h: Add include guard.
7762
7763 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7764
7765         * macrotab.c (macro_define_internal): New function that
7766         factorizes macro_define_object_internal and macro_define_function
7767         code.
7768         (macro_define_object_internal): Use macro_define_internal.
7769         (macro_define_function): Likewise.
7770
7771 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7772
7773         * macrocmd.c (extract_identifier): Return
7774         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
7775         callers.
7776
7777 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
7778
7779         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
7780
7781 2019-02-05  Tom Tromey  <tom@tromey.com>
7782
7783         * target.c (target_stack::unpush): Move assertion earlier.
7784
7785 2019-01-30  Tom Tromey  <tom@tromey.com>
7786
7787         PR python/23615:
7788         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
7789         (gdbpy_parse_and_eval): Likewise.
7790         * python/python-internal.h (gdbpy_allow_threads): New class.
7791
7792 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
7793
7794         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
7795         (aarch64_fbsd_fpregmap): Move earlier.
7796         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
7797         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7798         instead of individual calls to trad_frame_set_reg_addr.
7799         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
7800         earlier.
7801         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
7802         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7803         instead of individual calls to trad_frame_set_reg_addr.
7804
7805 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
7806
7807         * CONTRIBUTE: Replace contribution list with wiki link.
7808
7809 2019-01-25  Tom Tromey  <tom@tromey.com>
7810
7811         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
7812
7813 2019-01-25  Tom Tromey  <tom@tromey.com>
7814
7815         * xtensa-linux-nat.c: Fix common/ includes.
7816         * xml-support.h: Fix common/ includes.
7817         * xml-support.c: Fix common/ includes.
7818         * x86-linux-nat.c: Fix common/ includes.
7819         * windows-nat.c: Fix common/ includes.
7820         * varobj.h: Fix common/ includes.
7821         * varobj.c: Fix common/ includes.
7822         * value.c: Fix common/ includes.
7823         * valops.c: Fix common/ includes.
7824         * utils.c: Fix common/ includes.
7825         * unittests/xml-utils-selftests.c: Fix common/ includes.
7826         * unittests/utils-selftests.c: Fix common/ includes.
7827         * unittests/unpack-selftests.c: Fix common/ includes.
7828         * unittests/tracepoint-selftests.c: Fix common/ includes.
7829         * unittests/style-selftests.c: Fix common/ includes.
7830         * unittests/string_view-selftests.c: Fix common/ includes.
7831         * unittests/scoped_restore-selftests.c: Fix common/ includes.
7832         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
7833         * unittests/scoped_fd-selftests.c: Fix common/ includes.
7834         * unittests/rsp-low-selftests.c: Fix common/ includes.
7835         * unittests/parse-connection-spec-selftests.c: Fix common/
7836         includes.
7837         * unittests/optional-selftests.c: Fix common/ includes.
7838         * unittests/offset-type-selftests.c: Fix common/ includes.
7839         * unittests/observable-selftests.c: Fix common/ includes.
7840         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
7841         * unittests/memrange-selftests.c: Fix common/ includes.
7842         * unittests/memory-map-selftests.c: Fix common/ includes.
7843         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
7844         * unittests/function-view-selftests.c: Fix common/ includes.
7845         * unittests/environ-selftests.c: Fix common/ includes.
7846         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
7847         * unittests/common-utils-selftests.c: Fix common/ includes.
7848         * unittests/cli-utils-selftests.c: Fix common/ includes.
7849         * unittests/array-view-selftests.c: Fix common/ includes.
7850         * ui-file.c: Fix common/ includes.
7851         * tui/tui-io.c: Fix common/ includes.
7852         * tracepoint.h: Fix common/ includes.
7853         * tracepoint.c: Fix common/ includes.
7854         * tracefile-tfile.c: Fix common/ includes.
7855         * top.h: Fix common/ includes.
7856         * top.c: Fix common/ includes.
7857         * thread.c: Fix common/ includes.
7858         * target/waitstatus.h: Fix common/ includes.
7859         * target/waitstatus.c: Fix common/ includes.
7860         * target.h: Fix common/ includes.
7861         * target.c: Fix common/ includes.
7862         * target-memory.c: Fix common/ includes.
7863         * target-descriptions.c: Fix common/ includes.
7864         * symtab.h: Fix common/ includes.
7865         * symfile.c: Fix common/ includes.
7866         * stap-probe.c: Fix common/ includes.
7867         * spu-linux-nat.c: Fix common/ includes.
7868         * sparc-nat.c: Fix common/ includes.
7869         * source.c: Fix common/ includes.
7870         * solib.c: Fix common/ includes.
7871         * solib-target.c: Fix common/ includes.
7872         * ser-unix.c: Fix common/ includes.
7873         * ser-tcp.c: Fix common/ includes.
7874         * ser-pipe.c: Fix common/ includes.
7875         * ser-base.c: Fix common/ includes.
7876         * selftest-arch.c: Fix common/ includes.
7877         * s12z-tdep.c: Fix common/ includes.
7878         * rust-exp.y: Fix common/ includes.
7879         * rs6000-aix-tdep.c: Fix common/ includes.
7880         * riscv-tdep.c: Fix common/ includes.
7881         * remote.c: Fix common/ includes.
7882         * remote-notif.h: Fix common/ includes.
7883         * remote-fileio.h: Fix common/ includes.
7884         * remote-fileio.c: Fix common/ includes.
7885         * regcache.h: Fix common/ includes.
7886         * regcache.c: Fix common/ includes.
7887         * record-btrace.c: Fix common/ includes.
7888         * python/python.c: Fix common/ includes.
7889         * python/py-type.c: Fix common/ includes.
7890         * python/py-inferior.c: Fix common/ includes.
7891         * progspace.h: Fix common/ includes.
7892         * producer.c: Fix common/ includes.
7893         * procfs.c: Fix common/ includes.
7894         * proc-api.c: Fix common/ includes.
7895         * printcmd.c: Fix common/ includes.
7896         * ppc-linux-nat.c: Fix common/ includes.
7897         * parser-defs.h: Fix common/ includes.
7898         * osdata.c: Fix common/ includes.
7899         * obsd-nat.c: Fix common/ includes.
7900         * nat/x86-linux.c: Fix common/ includes.
7901         * nat/x86-linux-dregs.c: Fix common/ includes.
7902         * nat/x86-dregs.h: Fix common/ includes.
7903         * nat/x86-dregs.c: Fix common/ includes.
7904         * nat/ppc-linux.c: Fix common/ includes.
7905         * nat/mips-linux-watch.h: Fix common/ includes.
7906         * nat/mips-linux-watch.c: Fix common/ includes.
7907         * nat/linux-waitpid.c: Fix common/ includes.
7908         * nat/linux-ptrace.h: Fix common/ includes.
7909         * nat/linux-ptrace.c: Fix common/ includes.
7910         * nat/linux-procfs.c: Fix common/ includes.
7911         * nat/linux-personality.c: Fix common/ includes.
7912         * nat/linux-osdata.c: Fix common/ includes.
7913         * nat/linux-namespaces.c: Fix common/ includes.
7914         * nat/linux-btrace.h: Fix common/ includes.
7915         * nat/linux-btrace.c: Fix common/ includes.
7916         * nat/fork-inferior.c: Fix common/ includes.
7917         * nat/amd64-linux-siginfo.c: Fix common/ includes.
7918         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
7919         * nat/aarch64-linux.c: Fix common/ includes.
7920         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
7921         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
7922         * namespace.h: Fix common/ includes.
7923         * mips-linux-tdep.c: Fix common/ includes.
7924         * minsyms.c: Fix common/ includes.
7925         * mi/mi-parse.h: Fix common/ includes.
7926         * mi/mi-main.c: Fix common/ includes.
7927         * mi/mi-cmd-env.c: Fix common/ includes.
7928         * memrange.h: Fix common/ includes.
7929         * memattr.c: Fix common/ includes.
7930         * maint.h: Fix common/ includes.
7931         * maint.c: Fix common/ includes.
7932         * main.c: Fix common/ includes.
7933         * machoread.c: Fix common/ includes.
7934         * location.c: Fix common/ includes.
7935         * linux-thread-db.c: Fix common/ includes.
7936         * linux-nat.c: Fix common/ includes.
7937         * linux-fork.c: Fix common/ includes.
7938         * inline-frame.c: Fix common/ includes.
7939         * infrun.c: Fix common/ includes.
7940         * inflow.c: Fix common/ includes.
7941         * inferior.h: Fix common/ includes.
7942         * inferior.c: Fix common/ includes.
7943         * infcmd.c: Fix common/ includes.
7944         * inf-ptrace.c: Fix common/ includes.
7945         * inf-child.c: Fix common/ includes.
7946         * ia64-linux-nat.c: Fix common/ includes.
7947         * i387-tdep.c: Fix common/ includes.
7948         * i386-tdep.c: Fix common/ includes.
7949         * i386-linux-tdep.c: Fix common/ includes.
7950         * i386-linux-nat.c: Fix common/ includes.
7951         * i386-go32-tdep.c: Fix common/ includes.
7952         * i386-fbsd-tdep.c: Fix common/ includes.
7953         * i386-fbsd-nat.c: Fix common/ includes.
7954         * guile/scm-type.c: Fix common/ includes.
7955         * guile/guile.c: Fix common/ includes.
7956         * go32-nat.c: Fix common/ includes.
7957         * gnu-nat.c: Fix common/ includes.
7958         * gdbthread.h: Fix common/ includes.
7959         * gdbarch-selftests.c: Fix common/ includes.
7960         * gdb_usleep.c: Fix common/ includes.
7961         * gdb_select.h: Fix common/ includes.
7962         * gdb_bfd.c: Fix common/ includes.
7963         * gcore.c: Fix common/ includes.
7964         * fork-child.c: Fix common/ includes.
7965         * findvar.c: Fix common/ includes.
7966         * fbsd-nat.c: Fix common/ includes.
7967         * event-top.c: Fix common/ includes.
7968         * event-loop.c: Fix common/ includes.
7969         * dwarf2read.c: Fix common/ includes.
7970         * dwarf2loc.c: Fix common/ includes.
7971         * dwarf2-frame.c: Fix common/ includes.
7972         * dwarf-index-cache.c: Fix common/ includes.
7973         * dtrace-probe.c: Fix common/ includes.
7974         * disasm-selftests.c: Fix common/ includes.
7975         * defs.h: Fix common/ includes.
7976         * csky-tdep.c: Fix common/ includes.
7977         * cp-valprint.c: Fix common/ includes.
7978         * cp-support.h: Fix common/ includes.
7979         * cp-support.c: Fix common/ includes.
7980         * corelow.c: Fix common/ includes.
7981         * completer.h: Fix common/ includes.
7982         * completer.c: Fix common/ includes.
7983         * compile/compile.c: Fix common/ includes.
7984         * compile/compile-loc2c.c: Fix common/ includes.
7985         * compile/compile-cplus-types.c: Fix common/ includes.
7986         * compile/compile-cplus-symbols.c: Fix common/ includes.
7987         * command.h: Fix common/ includes.
7988         * cli/cli-dump.c: Fix common/ includes.
7989         * cli/cli-cmds.c: Fix common/ includes.
7990         * charset.c: Fix common/ includes.
7991         * build-id.c: Fix common/ includes.
7992         * btrace.h: Fix common/ includes.
7993         * btrace.c: Fix common/ includes.
7994         * breakpoint.h: Fix common/ includes.
7995         * breakpoint.c: Fix common/ includes.
7996         * ax.h:
7997         (enum agent_op): Fix common/ includes.
7998         * ax-general.c (struct aop_map): Fix common/ includes.
7999         * ax-gdb.c: Fix common/ includes.
8000         * auxv.c: Fix common/ includes.
8001         * auto-load.c: Fix common/ includes.
8002         * arm-tdep.c: Fix common/ includes.
8003         * arch/riscv.c: Fix common/ includes.
8004         * arch/ppc-linux-common.c: Fix common/ includes.
8005         * arch/i386.c: Fix common/ includes.
8006         * arch/arm.c: Fix common/ includes.
8007         * arch/arm-linux.c: Fix common/ includes.
8008         * arch/arm-get-next-pcs.c: Fix common/ includes.
8009         * arch/amd64.c: Fix common/ includes.
8010         * arch/aarch64.c: Fix common/ includes.
8011         * arch/aarch64-insn.c: Fix common/ includes.
8012         * arch-utils.c: Fix common/ includes.
8013         * amd64-windows-tdep.c: Fix common/ includes.
8014         * amd64-tdep.c: Fix common/ includes.
8015         * amd64-sol2-tdep.c: Fix common/ includes.
8016         * amd64-obsd-tdep.c: Fix common/ includes.
8017         * amd64-nbsd-tdep.c: Fix common/ includes.
8018         * amd64-linux-tdep.c: Fix common/ includes.
8019         * amd64-linux-nat.c: Fix common/ includes.
8020         * amd64-fbsd-tdep.c: Fix common/ includes.
8021         * amd64-fbsd-nat.c: Fix common/ includes.
8022         * amd64-dicos-tdep.c: Fix common/ includes.
8023         * amd64-darwin-tdep.c: Fix common/ includes.
8024         * agent.c: Fix common/ includes.
8025         * ada-lang.h: Fix common/ includes.
8026         * ada-lang.c: Fix common/ includes.
8027         * aarch64-tdep.c: Fix common/ includes.
8028
8029 2019-01-25  Tom Tromey  <tom@tromey.com>
8030
8031         * common/create-version.sh: Use common/version.h.
8032
8033 2019-01-24  Pedro Alves  <palves@redhat.com>
8034
8035         * infrun.c (signal_stop, signal_print, signal_program)
8036         (signal_catch, signal_pass): Now arrays instead of pointers.
8037         (update_signals_program_target, do_target_resume)
8038         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8039         * linux-nat.c (linux_nat_target::pass_signals)
8040         (linux_nat_target::create_inferior, linux_nat_target::attach):
8041         Adjust.
8042         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8043         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8044         * procfs.c (procfs_target::pass_signals): Adjust.
8045         * record-full.c (record_full_target::resume): Adjust.
8046         * remote.c (remote_target::pass_signals)
8047         (remote_target::program_signals): Adjust.
8048         * target-debug.h (target_debug_print_signals): Now takes a
8049         gdb::array_view as parameter.  Adjust.
8050         * target.h (target_ops) <pass_signals, program_signals>: Replace
8051         pointer and length parameters with gdb::array_view.
8052         (target_pass_signals, target_program_signals): Likewise.
8053         * target-delegates.c: Regenerate.
8054
8055 2019-01-24  Pedro Alves  <palves@redhat.com>
8056
8057         * common/forward-scope-exit.h
8058         (forward_scope_exit::forward_scope_exit): Pass arguments to
8059         m_bind_function directly, instead of creating a std::bind and
8060         copying that.
8061
8062 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8063
8064         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8065         for static members.
8066         (pass_in_v_vfp_candidate): Likewise.
8067
8068 2019-01-23  Tom Tromey  <tom@tromey.com>
8069             Pedro Alves  <palves@redhat.com>
8070
8071         * regcache.c (class regcache_invalidator): Remove.
8072         (regcache::raw_write): Use make_scope_exit.
8073
8074 2019-01-23  Tom Tromey  <tom@tromey.com>
8075
8076         * ui-out.h (class ui_out_emit_type): Update comment.
8077
8078 2019-01-23  Tom Tromey  <tom@tromey.com>
8079
8080         * infrun.c (fetch_inferior_event): Update comment.
8081
8082 2019-01-23  Tom Tromey  <tom@tromey.com>
8083             Pedro Alves  <palves@redhat.com>
8084
8085         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8086         parameter.
8087         (fetch_inferior_event): Use SCOPE_EXIT.
8088
8089
8090 2019-01-23  Tom Tromey  <tom@tromey.com>
8091             Pedro Alves  <palves@redhat.com>
8092
8093         * infrun.c (disable_thread_events): Delete.
8094         (stop_all_threads): Use SCOPE_EXIT.
8095
8096 2019-01-23  Tom Tromey  <tom@tromey.com>
8097             Pedro Alves  <palves@redhat.com>
8098
8099         * symfile.c: Include forward-scope-exit.h.
8100         (clear_symtab_users_cleanup): Replace forward declaration with
8101         a FORWARD_SCOPE_EXIT.
8102         (syms_from_objfile_1): Use the forward_scope_exit and
8103         gdb::optional instead of cleanup_function.
8104         (reread_symbols): Use the forward_scope_exit instead of
8105         cleanup_function.
8106         (clear_symtab_users_cleanup): Remove function.
8107
8108 2019-01-23  Tom Tromey  <tom@tromey.com>
8109             Pedro Alves  <palves@redhat.com>
8110
8111         * linux-nat.c: Include scope-exit.h.
8112         (cleanup_target_stop): Remove.
8113         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8114         SCOPE_EXIT.
8115
8116 2019-01-23  Tom Tromey  <tom@tromey.com>
8117             Pedro Alves  <palves@redhat.com>
8118
8119         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8120         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8121
8122 2019-01-23  Tom Tromey  <tom@tromey.com>
8123             Andrew Burgess  <andrew.burgess@embecosm.com>
8124             Pedro Alves  <palves@redhat.com>
8125
8126         * infrun.c (fetch_inferior_event): Use scope_exit.
8127         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8128         * top.c (execute_command): Use scope_exit.
8129         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8130         * utils.c (do_bpstat_clear_actions_cleanup)
8131         (make_bpstat_clear_actions_cleanup): Remove.
8132
8133 2019-01-23  Tom Tromey  <tom@tromey.com>
8134             Pedro Alves  <palves@redhat.com>
8135
8136         * infrun.c: Include "common/scope-exit.h"
8137         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8138         (wait_for_inferior): Use SCOPE_EXIT.
8139         (fetch_inferior_event): Use scope_exit.
8140
8141 2019-01-23  Tom Tromey  <tom@tromey.com>
8142             Pedro Alves  <palves@redhat.com>
8143
8144         * breakpoint.c (create_breakpoint): Remove cleanup.
8145
8146 2019-01-23  Tom Tromey  <tom@tromey.com>
8147             Andrew Burgess  <andrew.burgess@embecosm.com>
8148             Pedro Alves  <palves@redhat.com>
8149
8150 2019-01-23  Pedro Alves  <palves@redhat.com>
8151
8152         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8153
8154 2019-01-23  Pedro Alves  <palves@redhat.com>
8155             Andrew Burgess  <andrew.burgess@embecosm.com>
8156
8157         * gdbthread.h: Include "common/forward-scope-exit.h".
8158         (scoped_finish_thread_state): Redefine custom class in terms of
8159         forward_scope_exit.
8160
8161 2019-01-23  Pedro Alves  <palves@redhat.com>
8162             Andrew Burgess  <andrew.burgess@embecosm.com>
8163
8164         * common/forward-scope-exit.h: New file.
8165
8166 2019-01-23  Pedro Alves  <palves@redhat.com>
8167             Andrew Burgess  <andrew.burgess@embecosm.com>
8168             Tom Tromey  <tom@tromey.com>
8169
8170         * common/scope-exit.h: New file.
8171
8172 2019-01-23  Pedro Alves  <palves@redhat.com>
8173
8174         * common/preprocessor.h (ESC): Rename to ...
8175         (ESC_PARENS): ... this.
8176         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8177         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8178
8179 2019-01-23  Tom Tromey  <tom@tromey.com>
8180
8181         * language.h (class scoped_switch_to_sym_language_if_auto):
8182         Initialize m_lang in both cases.
8183
8184 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8185
8186         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8187         with XCNEW.
8188
8189 2019-01-22  Tom Tromey  <tom@tromey.com>
8190
8191         * corelow.c: Do not include sys/file.h.
8192
8193 2019-01-22  Tom Tromey  <tom@tromey.com>
8194
8195         * tui/tui-wingeneral.h: Include gdb_curses.h.
8196
8197 2019-01-22  Tom Tromey  <tom@tromey.com>
8198
8199         * source-cache.h (class source_cache) <get_source_lines,
8200         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8201
8202 2019-01-22  Tom Tromey  <tom@tromey.com>
8203
8204         * remote-fileio.h (struct remote_target): Declare.
8205
8206 2019-01-22  Tom Tromey  <tom@tromey.com>
8207
8208         * python/py-arch.c: Do not include py-ref.h.
8209         * python/py-bpevent.c: Do not include py-ref.h.
8210         * python/py-cmd.c: Do not include py-ref.h.
8211         * python/py-continueevent.c: Do not include py-ref.h.
8212         * python/py-event.h: Do not include py-ref.h.
8213         * python/py-evtregistry.c: Do not include py-ref.h.
8214         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8215         * python/py-frame.c: Do not include py-ref.h.
8216         * python/py-framefilter.c: Do not include py-ref.h.
8217         * python/py-function.c: Do not include py-ref.h.
8218         * python/py-infevents.c: Do not include py-ref.h.
8219         * python/py-linetable.c: Do not include py-ref.h.
8220         * python/py-objfile.c: Do not include py-ref.h.
8221         * python/py-param.c: Do not include py-ref.h.
8222         * python/py-prettyprint.c: Do not include py-ref.h.
8223         * python/py-progspace.c: Do not include py-ref.h.
8224         * python/py-symbol.c: Do not include py-ref.h.
8225         * python/py-symtab.c: Do not include py-ref.h.
8226         * python/py-type.c: Do not include py-ref.h.
8227         * python/py-unwind.c: Do not include py-ref.h.
8228         * python/py-utils.c: Do not include py-ref.h.
8229         * python/py-value.c: Do not include py-ref.h.
8230         * python/py-varobj.c: Do not include py-ref.h.
8231         * python/py-xmethods.c: Do not include py-ref.h.
8232         * python/python.c: Do not include py-ref.h.
8233         * varobj.c: Do not include py-ref.h.
8234
8235 2019-01-22  Tom Tromey  <tom@tromey.com>
8236
8237         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8238         keyword for bcache.
8239
8240 2019-01-22  Tom Tromey  <tom@tromey.com>
8241
8242         * compile/compile-cplus-types.c: Remove a comment by #include.
8243
8244 2019-01-22  Tom Tromey  <tom@tromey.com>
8245
8246         * compile/gcc-c-plugin.h: Include compile-internal.h.
8247
8248 2019-01-22  Tom Tromey  <tom@tromey.com>
8249
8250         * stabsread.c (EXTERN): Do not define.
8251         (symnum, next_symbol_text_func, processing_gcc_compilation)
8252         (within_function, global_sym_chain, global_stabs)
8253         (previous_stab_code, this_object_header_files)
8254         (n_this_object_header_files)
8255         (n_allocated_this_object_header_files): Define.
8256         * stabsread.h (EXTERN): Never define.  Use "extern".
8257
8258 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8259
8260         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8261         history_value.
8262
8263 2019-01-21  Tom Tromey  <tom@tromey.com>
8264
8265         * ui-out.c: Fix includes.
8266         * tui/tui-source.c: Fix includes.
8267         * target.c: Fix includes.
8268         * remote.c: Fix includes.
8269         * regcache.c: Fix includes.
8270         * python/py-block.c: Fix includes.
8271         * printcmd.c: Fix includes.
8272         * or1k-tdep.c: Fix includes.
8273         * mi/mi-main.c: Fix includes.
8274         * m32r-tdep.c: Fix includes.
8275         * csky-tdep.c: Fix includes.
8276         * compile/compile-cplus-types.c: Fix includes.
8277         * cli/cli-interp.c: Fix includes.
8278
8279 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8280
8281         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8282         for padding.
8283
8284 2019-01-16  Tom Tromey  <tom@tromey.com>
8285
8286         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8287         earlier.
8288         (struct objfile) <msymbols_range>: Move from top level.
8289         <msymbols>: New method.
8290         (class objfile_msymbols): Remove.
8291         * symtab.c (default_collect_symbol_completion_matches_break_on):
8292         Update.
8293         * symmisc.c (dump_msymbols): Update.
8294         * stabsread.c (scan_file_globals): Update.
8295         * objc-lang.c (info_selectors_command, info_classes_command)
8296         (find_methods): Update.
8297         * minsyms.c (find_solib_trampoline_target): Update.
8298         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8299         * coffread.c (coff_symfile_read): Update.
8300         * ada-lang.c (ada_lookup_simple_minsym)
8301         (ada_collect_symbol_completion_matches): Update.
8302
8303 2019-01-16  Tom Tromey  <tom@tromey.com>
8304
8305         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8306         type.  Remove no-argument constructor.
8307         <iterator::operator++>: Simplify.
8308         <begin>: Update.
8309         <end>: Use minimal_symbol_count.
8310
8311 2019-01-16  Tom Tromey  <tom@tromey.com>
8312
8313         * objfiles.h (struct objfile) <psymtabs>: New method.
8314         (class objfile_psymtabs): Remove.
8315         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8316         typedef.
8317         <range>: New method.
8318         (require_partial_symbols): Change return type.
8319         * psymtab.c (require_partial_symbols)
8320         (psym_expand_symtabs_matching): Update.
8321         * mdebugread.c (parse_partial_symbols): Update.
8322         * dbxread.c (dbx_end_psymtab): Update.
8323
8324 2019-01-15  Tom Tromey  <tom@tromey.com>
8325
8326         * symtab.c (lookup_objfile_from_block)
8327         (lookup_symbol_in_objfile_symtabs)
8328         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8329         (find_line_symtab, info_sources_command)
8330         (default_collect_symbol_completion_matches_break_on)
8331         (make_source_files_completion_list): Update.
8332         * symmisc.c (print_objfile_statistics, dump_objfile)
8333         (maintenance_print_symbols, maintenance_info_symtabs)
8334         (maintenance_check_symtabs, maintenance_info_line_tables):
8335         Update.
8336         * source.c (select_source_symtab)
8337         (forget_cached_source_info_for_objfile): Update.
8338         * objfiles.h (class objfile_compunits): Remove.
8339         (struct objfile) <compunits_range>: New typedef.
8340         (compunits): New method.
8341         * objfiles.c (objfile_relocate1): Update.
8342         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8343         * maint.c (count_symtabs_and_blocks): Update.
8344         * linespec.c (iterate_over_all_matching_symtabs): Update.
8345         * cp-support.c (add_symbol_overload_list_qualified): Update.
8346         * coffread.c (coff_symtab_read): Update.
8347         * ada-lang.c (add_nonlocal_symbols)
8348         (ada_collect_symbol_completion_matches)
8349         (ada_add_global_exceptions): Update.
8350
8351 2019-01-15  Tom Tromey  <tom@tromey.com>
8352
8353         * progspace.h (program_space) <objfiles_safe_range>: New
8354         typedef.
8355         <objfiles_safe>: New method.
8356         * objfiles.h (class all_objfiles_safe): Remove.
8357         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8358         * jit.c (jit_inferior_exit_hook): Update.
8359
8360 2019-01-17  Tom Tromey  <tom@tromey.com>
8361
8362         * progspace.h (program_space) <objfiles_range>: New typedef.
8363         <objfiles>: New method.
8364         <objfiles_head>: Rename from objfiles.
8365         (object_files): Update.
8366         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8367         * guile/scm-pretty-print.c
8368         (ppscm_find_pretty_printer_from_objfiles): Update.
8369         * guile/scm-objfile.c (gdbscm_objfiles): Update.
8370         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8371         Update.
8372         * python/py-progspace.c (pspy_get_objfiles): Update.
8373         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8374         Update.
8375         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8376         (objfpy_lookup_objfile_by_build_id): Update.
8377         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8378         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8379         Update.
8380         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8381         (expand_symtab_containing_pc, lookup_objfile_from_block)
8382         (lookup_static_symbol, basic_lookup_transparent_type)
8383         (find_pc_sect_compunit_symtab, find_symbol_at_address)
8384         (find_line_symtab, info_sources_command)
8385         (default_collect_symbol_completion_matches_break_on)
8386         (make_source_files_completion_list, find_main_name): Update.
8387         * symmisc.c (print_symbol_bcache_statistics)
8388         (print_objfile_statistics, maintenance_print_symbols)
8389         (maintenance_print_msymbols, maintenance_print_objfiles)
8390         (maintenance_info_symtabs, maintenance_check_symtabs)
8391         (maintenance_expand_symtabs, maintenance_info_line_tables):
8392         Update.
8393         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8394         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
8395         (map_overlay_command, unmap_overlay_command)
8396         (simple_overlay_update, expand_symtabs_matching)
8397         (map_symbol_filenames): Update.
8398         * symfile-debug.c (set_debug_symfile): Update.
8399         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
8400         Update.
8401         * source.c (select_source_symtab, forget_cached_source_info):
8402         Update.
8403         * solib.c (solib_read_symbols): Update.
8404         * solib-spu.c (append_ocl_sos): Update.
8405         * psymtab.c (maintenance_print_psymbols)
8406         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
8407         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
8408         * printcmd.c (info_symbol_command): Update.
8409         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
8410         Update.
8411         * objfiles.h (class all_objfiles): Remove.
8412         * objfiles.c (have_partial_symbols, have_full_symbols)
8413         (have_minimal_symbols, qsort_cmp, update_section_map)
8414         (shared_objfile_contains_address_p)
8415         (default_iterate_over_objfiles_in_search_order): Update.
8416         * objc-lang.c (info_selectors_command, info_classes_command)
8417         (find_methods): Update.
8418         * minsyms.c (find_solib_trampoline_target): Update.
8419         * maint.c (maintenance_info_sections)
8420         (maintenance_translate_address, count_symtabs_and_blocks):
8421         Update.
8422         * main.c (captured_main_1): Update.
8423         * linux-thread-db.c (try_thread_db_load_from_pdir)
8424         (has_libpthread): Update.
8425         * linespec.c (iterate_over_all_matching_symtabs)
8426         (search_minsyms_for_name): Update.
8427         * jit.c (jit_find_objf_with_entry_addr): Update.
8428         * hppa-tdep.c (find_unwind_entry)
8429         (hppa_lookup_stub_minimal_symbol): Update.
8430         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
8431         Update.
8432         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8433         (elf_gnu_ifunc_resolve_by_got): Update.
8434         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
8435         * dwarf-index-write.c (save_gdb_index_command): Update.
8436         * cp-support.c (add_symbol_overload_list_qualified): Update.
8437         * breakpoint.c (create_overlay_event_breakpoint)
8438         (create_longjmp_master_breakpoint)
8439         (create_std_terminate_master_breakpoint)
8440         (create_exception_master_breakpoint): Update.
8441         * blockframe.c (find_pc_partial_function): Update.
8442         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
8443         (ada_collect_symbol_completion_matches)
8444         (ada_add_global_exceptions): Update.
8445
8446 2019-01-17  Tom Tromey  <tom@tromey.com>
8447
8448         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
8449         declare VEC.
8450         (solib_target_parse_libraries): Change return type.
8451         (library_list_start_segment, library_list_start_section)
8452         (library_list_end_library, library_list_start_library); Update.
8453         (solib_target_free_library_list): Remove.
8454         (solib_target_parse_libraries): Remove cleanup.  Change return
8455         type.
8456         (solib_target_current_sos): Update.
8457
8458 2019-01-17  Tom Tromey  <tromey@bapiya>
8459
8460         * valprint.c: Replace "the the" with "the".
8461         * symtab.c: Replace "the the" with "the".
8462         * solib.c: Replace "the the" with "the".
8463         * solib-dsbt.c: Replace "the the" with "the".
8464         * linespec.c: Replace "the the" with "the".
8465         * dwarf2loc.h: Replace "the the" with "the".
8466         * amd64-windows-tdep.c: Replace "the the" with "the".
8467         * aarch64-tdep.c: Replace "the the" with "the".
8468
8469 2019-01-16  Keith Seitz  <keiths@redhat.com>
8470
8471         PR gdb/23773
8472         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
8473         <builder>: Rename to ..
8474         <m_builder>: ... this and make private.
8475         (dwarf2_cu::get_builder): New method.  Change all users of
8476         `builder' to use this method.
8477         (dwarf2_start_symtab): Move to ...
8478         (dwarf2_cu::start_symtab): ... here.  Update all callers
8479         (setup_type_unit_groups): Move to ...
8480         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
8481         callers.
8482         (dwarf2_cu::reset_builder): New method.
8483         (process_full_compunit, process_full_type_unit): Use
8484         dwarf2_cu::reset_builder.
8485         (follow_die_offset): Record the ancestor CU if it is different
8486         from the followed DIE's CU.
8487         (follow_die_sig_1): Likewise.
8488
8489 2019-01-15  Tom Tromey  <tom@tromey.com>
8490
8491         * remote.c (class remote_state) <buf>: Now a char_vector.
8492         <buf_size>: Remove.
8493         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
8494         parameter.
8495         (remote_target::getpkt_or_notif_sane_1)
8496         (remote_target::getpkt_sane)
8497         (remote_target::getpkt_or_notif_sane): Likewise.
8498         (class remote_target) <putpkt>: New overload.
8499         (remote_target::read_frame): Change type of "buf_p".  Remove
8500         sizeof_p parameter.
8501         (packet_ok): New overload.
8502         (packet_check_result): New overload.
8503         Update all uses.
8504
8505 2019-01-14  Tom Tromey  <tom@tromey.com>
8506
8507         * remote-notif.c (handle_notification, remote_notif_ack)
8508         (remote_notif_parse): Make "buf" const.
8509         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
8510         const.
8511         (remote_notif_parse, remote_notif_ack, handle_notification):
8512         Likewise.
8513         * remote.c (remote_notif_stop_parse): Make "buf" const.
8514         (remote_target::remote_parse_stop_reply): Make "buf" const.
8515         (remote_notif_stop_ack): Make "buf" const.
8516
8517 2019-01-14  Tom Tromey  <tom@tromey.com>
8518
8519         * remote.c (remote_console_output): Make parameter const.
8520
8521 2019-01-14  Tom Tromey  <tom@tromey.com>
8522
8523         * target-debug.h (target_debug_print_signals): Constify.
8524         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
8525         * procfs.c (procfs_target::pass_signals): Update.
8526         * linux-nat.c (linux_nat_target::pass_signals): Update.
8527         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
8528         * target-delegates.c: Rebuild.
8529         * remote.c (remote_target::program_signals): Update.
8530         (remote_target::pass_signals): Update.
8531         * target.c (target_pass_signals): Constify argument.
8532         (target_program_signals): Likewise.
8533         * target.h (struct target_ops) <pass_signals, program_signals>:
8534         Constify argument.
8535         (target_pass_signals, target_program_signals): Constify argument.
8536
8537 2019-01-14  Tom Tromey  <tom@tromey.com>
8538
8539         PR tui/28819:
8540         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
8541
8542 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
8543
8544         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
8545         field.
8546         * rs6000-tdep.c: Include reggroups.h.
8547         (IS_V_ALIAS_PSEUDOREG): Define.
8548         (rs6000_register_name): Return names for the "vX" aliases.
8549         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
8550         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
8551         aliases.  Call default_register_reggroup_p for all other
8552         pseudo-registers.
8553         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
8554         New functions.
8555         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
8556         Handle "vX" aliases.
8557         (v_alias_pseudo_register_collect): New function.
8558         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
8559         (rs6000_gdbarch_init): Initialize "vX" aliases as
8560         pseudo-registers.  Restore registration of
8561         rs6000_pseudo_register_reggroup_p with
8562         set_tdesc_pseudo_register_reggroup_p.
8563
8564 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
8565
8566         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
8567         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
8568         set_gdbarch_num_pseudo_regs.
8569
8570 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8571
8572         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
8573         Remove arg prefixname, add do_set and do_show.
8574         Add member functions set_list and show_list.
8575         * cli/cli-style.c (class cli_style_option): Update accordingly.
8576         (style_set_list): Move to file scope.
8577         (style_show_list): Likewise.
8578         (set_style): Call help_list.
8579         (show_style): Call cmd_show_list.
8580         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
8581         Update to use the new macro.
8582
8583 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
8584
8585         * ada-lang.c (_initialize_ada_language): Expand the help text
8586         for the "catch exception" command.
8587
8588 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8589
8590         * symtab.c (matching_obj_sections): Initialize obj,
8591         declare it closer to its usage.
8592
8593 2019-01-10  Tom Tromey  <tom@tromey.com>
8594
8595         * thread-iter.h (inf_threads_iterator): Use next_iterator.
8596         (basic_inf_threads_range): Remove.
8597         (inf_threads_range, inf_non_exited_threads_range)
8598         (safe_inf_threads_range): Use next_adapter.
8599
8600 2019-01-10  Keith Seitz  <keiths@redhat.com>
8601
8602         PR gdb/23712
8603         PR symtab/23010
8604         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
8605         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
8606
8607 2019-01-10  Keith Seitz  <keiths@redhat.com>
8608
8609         PR gdb/23712
8610         PR symtab/23010
8611         * dictionary.c (pending_to_vector): Remove.
8612         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8613         Remove _1 suffix, replacing functions of the same name.  Update
8614         all callers.
8615         (dict_create_hashed, dict_create_hashed_expandable)
8616         (dict_create_linear, dict_create_linear_expandable, dict_free)
8617         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8618         Make functions static.
8619
8620 2019-01-10  Keith Seitz  <keiths@redhat.com>
8621
8622         PR gdb/23712
8623         PR symtab/23010
8624         * dictionary.h (struct dictionary): Replace declaration with
8625         multidictionary.
8626         (dict_create_hashed, dict_create_hashed_expandable)
8627         (dict_create_linear, dict_create_linear_expandable)
8628         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8629         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8630         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8631         taking multidictionary argument.
8632         [ALL_DICT_SYMBOLS]: Update for multidictionary.
8633         * block.h (struct block) <dict>: Change to multidictionary
8634         and rename `multidict'.
8635         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8636         symmisc.c: Update all dictionary references to multidictionary.
8637
8638 2019-01-10  Keith Seitz  <keiths@redhat.com>
8639
8640         PR gdb/23712
8641         PR symtab/23010
8642         * dictionary.c: Include unordered_map.
8643         (pending_to_vector): New function.
8644         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8645         Rewrite the non-"_1" functions to take vector instead
8646         of linked list.
8647         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8648         "new" _1 versions of the same name.
8649         (multidictionary): Define.
8650         (std::hash<enum language): New definition.
8651         (collate_pending_symbols_by_language, mdict_create_hashed)
8652         (mdict_create_hashed_expandable, mdict_create_linear)
8653         (mdict_create_linear_expandable, mdict_free)
8654         (find_language_dictionary, create_new_language_dictionary)
8655         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8656         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8657         (mdict_size, mdict_empty): New functions.
8658         * dictionary.h (mdict_iterator): Define.
8659
8660 2019-01-10  Pedro Alves  <palves@redhat.com>
8661
8662         * breakpoint.c (read_uploaded_action)
8663         (create_tracepoint_from_upload): Adjust to use
8664         gdb::unique_xmalloc_ptr.
8665         * ctf.c (ctf_write_uploaded_tp):
8666         (SET_ARRAY_FIELD): Use emplace_back.
8667         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8668         * tracefile-tfile.c (tfile_write_uploaded_tp):
8669         * tracepoint.c (parse_tracepoint_definition): Adjust to use
8670         gdb::unique_xmalloc_ptr.
8671         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8672         at_string, cond_string, cmd_strings>: Replace char pointers
8673         with gdb::unique_xmalloc_ptr.
8674
8675 2019-01-10  Pedro Alves  <palves@redhat.com>
8676
8677         * solib-target.c (library_list_start_library): Don't xstrdup name.
8678
8679 2019-01-10  Pedro Alves  <palves@redhat.com>
8680
8681         * mdebugread.c (parse_partial_symbols): Use
8682         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8683
8684 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8685
8686         * linux-fork.c (scoped_switch_fork_info)
8687         <~scoped_switch_fork_info>: Fix incorrect variable name.
8688
8689 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8690
8691         * linux-fork.c (scoped_switch_fork_info)
8692         <scoped_switch_fork_info>: Make explicit.
8693         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
8694
8695 2019-01-10  Tom Tromey  <tom@tromey.com>
8696
8697         * objfiles.h (objfile::reset_psymtabs): Update.
8698         * objfiles.c (objfile::objfile): Update.
8699         * psymtab.h (psymtab_storage::obstack): Update.
8700         (psymtab_storage::m_obstack): Use gdb::optional.
8701         (class psymtab_storage): Update comment.  Remove objfile
8702         parameter.
8703         * psymtab.c (psymtab_storage::psymtab_storage): Update.
8704
8705 2019-01-10  Tom Tromey  <tom@tromey.com>
8706
8707         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
8708         <free_psymtabs>: Now private.
8709         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
8710         (allocate_psymtab): Use new method.
8711
8712 2019-01-10  Tom Tromey  <tom@tromey.com>
8713
8714         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
8715         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
8716         * mdebugread.c (parse_partial_symbols): Use
8717         allocate_dependencies.
8718         * dwarf2read.c (dwarf2_create_include_psymtab): Use
8719         allocate_dependencies.
8720         (process_psymtab_comp_unit_reader)
8721         (build_type_psymtab_dependencies): Likewise.
8722         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
8723
8724 2019-01-10  Tom Tromey  <tom@tromey.com>
8725
8726         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
8727         PSYMBOL_SET_LANGUAGE.
8728         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
8729
8730 2019-01-10  Tom Tromey  <tom@tromey.com>
8731
8732         * psymtab.h (psymtab_storage::obstack): New method.
8733         <m_obstack>: Rename from obstack; now private.
8734         * psymtab.c (psymtab_storage): Update.
8735         * dwarf2read.c (create_addrmap_from_index)
8736         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
8737         Update.
8738
8739 2019-01-10  Tom Tromey  <tom@tromey.com>
8740
8741         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
8742         * objfiles.h (objfile::reset_psymtabs): New method.
8743
8744 2019-01-10  Tom Tromey  <tom@tromey.com>
8745
8746         * symmisc.c (print_symbol_bcache_statistics): Update.
8747         (print_objfile_statistics): Update.
8748         * symfile.c (reread_symbols): Update.
8749         * psymtab.h (class psymtab_storage): New.
8750         * psymtab.c (psymtab_storage): New constructor.
8751         (~psymtab_storage): New destructor.
8752         (require_partial_symbols): Update.
8753         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
8754         (find_pc_sect_psymtab, find_pc_sect_psymbol)
8755         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
8756         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
8757         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
8758         (start_psymtab_common, end_psymtab_common)
8759         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
8760         (allocate_psymtab): Update.
8761         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
8762         Update.
8763         (dump_psymtab_addrmap, maintenance_print_psymbols)
8764         (maintenance_check_psymtabs): Update.
8765         (class objfile_psymtabs): Move to objfiles.h.
8766         * psympriv.h (discard_psymtab): Now inline.
8767         (psymtab_discarder::psymtab_discarder): Update.
8768         (psymtab_discarder::~psymtab_discarder): Update.
8769         (ALL_OBJFILE_PSYMTABS): Rewrite.
8770         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
8771         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
8772         Remove fields.
8773         <partial_symtabs>: New field.
8774         (class objfile_psymtabs): Move from psymtab.h.  Update.
8775         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
8776         psymbol_cache.
8777         (objfile::~objfile): Don't destroy psymbol_cache.
8778         * mdebugread.c (parse_partial_symbols): Update.
8779         * dwarf2read.c (create_addrmap_from_index)
8780         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
8781         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
8782         (add_partial_subprogram, dwarf2_ranges_read): Update.
8783         * dwarf-index-write.c (write_address_map)
8784         (write_one_signatured_type, recursively_write_psymbols)
8785         (class debug_names, class debug_names, write_psymtabs_to_index):
8786         Update.
8787
8788 2019-01-10  Tom Tromey  <tom@tromey.com>
8789
8790         * symtab.h (SYMBOL_SET_NAMES): Update.
8791         (symbol_set_names): Update.
8792         (MSYMBOL_SET_NAMES): Update.
8793         * symtab.c (symbol_set_names): Change argument to be an
8794         objfile_per_bfd_storage.
8795         * psymtab.c (add_psymbol_to_bcache): Update.
8796         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
8797
8798 2019-01-10  Tom Tromey  <tom@tromey.com>
8799
8800         * symtab.c (create_demangled_names_hash): Change argument to be an
8801         objfile_per_bfd_storage.
8802         (symbol_set_names): Update.
8803
8804 2019-01-10  Tom Tromey  <tom@tromey.com>
8805
8806         * xcoffread.c (xcoff_initial_scan): Unconditionally call
8807         init_psymbol_list.
8808         * psymtab.c (init_psymbol_list): Do nothing if already called.
8809         * psympriv.h (init_psymbol_list): Add comment.
8810         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
8811         init_psymbol_list.
8812         * dbxread.c (dbx_symfile_read): Unconditionally call
8813         init_psymbol_list.
8814
8815 2019-01-10  Tom Tromey  <tom@tromey.com>
8816
8817         * xcoffread.c (scan_xcoff_symtab): Update.
8818         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
8819         "where".
8820         * mdebugread.c (parse_partial_symbols)
8821         (handle_psymbol_enumerators): Update.
8822         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
8823         * dbxread.c (read_dbx_symtab): Update.
8824         * psympriv.h (psymbol_placement): New enum.
8825         (add_psymbol_to_list): Update.
8826
8827 2019-01-10  Tom Tromey  <tom@tromey.com>
8828
8829         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
8830         static_psymbols parameters.
8831         (scan_xcoff_symtab): Update.
8832         * psymtab.c (start_psymtab_common): Remove global_psymbols and
8833         static_psymbols parameters.
8834         * psympriv.h (start_psymtab_common): Update.
8835         * mdebugread.c (parse_partial_symbols): Update.
8836         * dwarf2read.c (create_partial_symtab): Update.
8837         * dbxread.c (read_dbx_symtab): Update.
8838         (start_psymtab): Remove global_psymbols and static_psymbols
8839         parameters.
8840
8841 2019-01-10  Tom Tromey  <tom@tromey.com>
8842
8843         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
8844         * psymtab.c (allocate_psymtab): Add comment.
8845         * psympriv.h (allocate_psymtab): Add comment.
8846         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
8847         initializations.
8848         * dbxread.c (dbx_end_psymtab): Remove some initializations.
8849
8850 2019-01-10  Tom Tromey  <tom@tromey.com>
8851
8852         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8853         Don't declare.
8854         * mipsread.c: Include mdebugread.h.
8855         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8856         Declare.
8857         * elfread.c: Include mdebugread.h.
8858
8859 2019-01-09  Tom Tromey  <tom@tromey.com>
8860
8861         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
8862         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
8863         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
8864         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
8865         (psym_lookup_symbol, psym_find_last_source_symtab)
8866         (psym_forget_cached_source_info, psym_print_stats)
8867         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
8868         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
8869         (psym_map_matching_symbols, psym_expand_symtabs_matching)
8870         (psym_find_compunit_symtab_by_address)
8871         (maintenance_print_psymbols, maintenance_info_psymtabs)
8872         (maintenance_check_psymtabs): Use ranged for.
8873         * psymtab.h (class objfile_psymtabs): New.
8874         (require_partial_symbols): Return objfile_psymtabs.
8875         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
8876
8877 2019-01-09  Tom Tromey  <tom@tromey.com>
8878
8879         * symfile.c (overlay_invalidate_all, find_pc_overlay)
8880         (find_pc_mapped_section, list_overlays_command)
8881         (map_overlay_command, unmap_overlay_command)
8882         (simple_overlay_update): Use all_objfiles.
8883         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
8884         * printcmd.c (info_symbol_command): Use all_objfiles.
8885         * objfiles.h (ALL_OBJSECTIONS): Remove.
8886         * maint.c (maintenance_translate_address): Use all_objfiles.
8887         * gcore.c (gcore_create_callback): Use all_objfiles.
8888         (objfile_find_memory_regions): Likewise.
8889
8890 2019-01-09  Tom Tromey  <tom@tromey.com>
8891
8892         * symtab.c (find_line_symtab, info_sources_command)
8893         (make_source_files_completion_list): Use objfile_compunits.
8894         * source.c (select_source_symtab): Use objfile_compunits.
8895         * objfiles.h (struct objfile): Update comment.
8896         (ALL_OBJFILES): Remove.
8897         (ALL_FILETABS): Remove.
8898         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
8899         objfile_compunits.
8900
8901 2019-01-09  Tom Tromey  <tom@tromey.com>
8902
8903         * symmisc.c (print_objfile_statistics, dump_objfile)
8904         (maintenance_print_symbols): Use compunit_filetabs.
8905         * source.c (forget_cached_source_info_for_objfile): Use
8906         compunit_filetabs.
8907         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
8908         (ALL_FILETABS): Use compunit_filetabs.
8909         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
8910         * coffread.c (coff_symtab_read): Use compunit_filetabs.
8911
8912 2019-01-09  Tom Tromey  <tom@tromey.com>
8913
8914         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
8915         (compunit_filetabs): New.
8916         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
8917         compunit_filetabs.
8918         (info_sources_command, make_source_files_completion_list): Remove
8919         declaration.
8920         * symmisc.c (print_objfile_statistics, dump_objfile)
8921         (maintenance_print_symbols): Remove declaration.
8922         (maintenance_info_symtabs): Use compunit_filetabs.
8923         (maintenance_info_line_tables): Likewise.
8924         * source.c (select_source_symtab): Change local variable name.
8925         (forget_cached_source_info_for_objfile): Remove declaration.
8926         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
8927         * objfiles.c (objfile_relocate1): Remove declaration.
8928         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8929         declaration.
8930         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
8931         * coffread.c (coff_symtab_read): Remove declaration.
8932         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
8933         compunit_filetabs.
8934
8935 2019-01-09  Tom Tromey  <tom@tromey.com>
8936
8937         * symtab.c (lookup_objfile_from_block)
8938         (find_pc_sect_compunit_symtab, search_symbols)
8939         (default_collect_symbol_completion_matches_break_on): Use
8940         objfile_compunits.
8941         * objfiles.h (ALL_COMPUNITS): Remove.
8942         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
8943         * cp-support.c (add_symbol_overload_list_qualified): Use
8944         objfile_compunits.
8945         * ada-lang.c (ada_collect_symbol_completion_matches)
8946         (ada_add_global_exceptions): Use objfile_compunits.
8947
8948 2019-01-09  Tom Tromey  <tom@tromey.com>
8949
8950         * source.c (select_source_symtab)
8951         (forget_cached_source_info_for_objfile): Remove declaration.
8952         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8953         declaration.
8954         * maint.c (count_symtabs_and_blocks): Remove declaration.
8955         * cp-support.c (add_symbol_overload_list_qualified): Remove
8956         declaration.
8957         * coffread.c (coff_symtab_read): Remove declaration.
8958         * symtab.c (lookup_symbol_in_objfile_symtabs)
8959         (basic_lookup_transparent_type_1): Use objfile_compunits.
8960         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
8961         (info_sources_command, search_symbols)
8962         (default_collect_symbol_completion_matches_break_on)
8963         (make_source_files_completion_list): Remove declaration.
8964         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
8965         (ada_collect_symbol_completion_matches)
8966         (ada_add_global_exceptions): Remove declaration.
8967         * linespec.c (iterate_over_all_matching_symtabs): Use
8968         objfile_compunits.
8969         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
8970         (class objfile_compunits): New.
8971         (ALL_COMPUNITS): Use objfile_compunits.
8972         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
8973         (maintenance_check_symtabs, maintenance_info_line_tables): Use
8974         objfile_compunits.
8975         * objfiles.c (objfile_relocate1): Use objfile_compunits.
8976
8977 2019-01-09  Tom Tromey  <tom@tromey.com>
8978
8979         * symtab.c (search_symbols)
8980         (default_collect_symbol_completion_matches_break_on): Use
8981         objfile_msymbols.
8982         * ada-lang.c (ada_lookup_simple_minsym)
8983         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
8984         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
8985         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
8986         objfile_msymbols.
8987         * coffread.c (coff_symfile_read): Use objfile_msymbols.
8988         * symmisc.c (dump_msymbols): Use objfile_msymbols.
8989         * objc-lang.c (find_methods): Use objfile_msymbols.
8990         (info_selectors_command, info_classes_command): Likewise.
8991         * stabsread.c (scan_file_globals): Use objfile_msymbols.
8992         * objfiles.h (class objfile_msymbols): New.
8993         (ALL_OBJFILE_MSYMBOLS): Remove.
8994         (ALL_MSYMBOLS): Remove.
8995
8996 2019-01-09  Tom Tromey  <tom@tromey.com>
8997
8998         * common/next-iterator.h (next_adapter): Add Iterator template
8999         parameter.
9000         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9001         (class all_objfiles_safe): New.
9002         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9003         * objfiles.c (put_objfile_before): Update comment.
9004         (add_separate_debug_objfile): Likewise.
9005         (free_all_objfiles): Use all_objfiles_safe.
9006         (objfile_purge_solibs): Likewise.
9007
9008 2019-01-09  Tom Tromey  <tom@tromey.com>
9009
9010         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9011         (expand_symtab_containing_pc, lookup_static_symbol)
9012         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9013         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9014         all_objfiles.
9015         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9016         * breakpoint.c (create_overlay_event_breakpoint)
9017         (create_longjmp_master_breakpoint)
9018         (create_std_terminate_master_breakpoint)
9019         (create_exception_master_breakpoint): Use all_objfiles.
9020         * linux-thread-db.c (try_thread_db_load_from_pdir)
9021         (has_libpthread): Use all_objfiles.
9022         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9023         * linespec.c (iterate_over_all_matching_symtabs)
9024         (search_minsyms_for_name): Use all_objfiles.
9025         * maint.c (maintenance_info_sections): Use all_objfiles.
9026         * main.c (captured_main_1): Use all_objfiles.
9027         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9028         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9029         * guile/scm-pretty-print.c
9030         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9031         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9032         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9033         (maintenance_print_msymbols): Use all_objfiles.
9034         * source.c (select_source_symtab): Use all_objfiles.
9035         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9036         * symfile.c (remove_symbol_file_command)
9037         (expand_symtabs_matching, map_symbol_filenames): Use
9038         all_objfiles.
9039         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9040         all_objfiles.
9041         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9042         * objc-lang.c (find_methods): Use all_objfiles.
9043         * objfiles.c (have_partial_symbols, have_full_symbols)
9044         (have_minimal_symbols, qsort_cmp)
9045         (default_iterate_over_objfiles_in_search_order): Use
9046         all_objfiles.
9047         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9048         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9049         (maintenance_check_psymtabs): Use all_objfiles.
9050         (ALL_PSYMTABS): Remove.
9051         * compile/compile-object-run.c (do_module_cleanup): Use
9052         all_objfiles.
9053         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9054         * cp-support.c (add_symbol_overload_list_qualified): Use
9055         all_objfiles.
9056         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9057         Use all_objfiles.
9058         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9059         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9060         all_objfiles.
9061         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9062         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9063         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9064         Uses all_objfiles.
9065         * solib.c (solib_read_symbols): Use all_objfiles
9066
9067 2019-01-09  Tom Tromey  <tom@tromey.com>
9068
9069         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9070         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9071         all_objfiles.
9072         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9073         * symmisc.c (print_symbol_bcache_statistics)
9074         (print_objfile_statistics, maintenance_print_objfiles)
9075         (maintenance_info_symtabs, maintenance_check_symtabs)
9076         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9077         all_objfiles.
9078         * source.c (forget_cached_source_info): Use all_objfiles.
9079         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9080         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9081         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9082         * objfiles.c (update_section_map): Use all_objfiles.
9083         (shared_objfile_contains_address_p): Likewise.
9084         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9085         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9086
9087 2019-01-09  Tom Tromey  <tom@tromey.com>
9088
9089         * common/next-iterator.h: New file.
9090         * objfiles.h (class all_objfiles): New.
9091         (struct objfile_iterator): New.
9092
9093 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9094
9095         * NEWS: Move the description of the changed "frame", "select-frame",
9096          and "info frame" commands to the Changed commands section.
9097
9098 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9099
9100         * gdbtypes.c (check_stub_method_group): Remove handling of old
9101         mangling schemes.
9102         * linespec.c (find_methods): Likewise.
9103         * stabsread.c (read_member_functions): Likewise.
9104         * valops.c (search_struct_method): Likewise.
9105         (value_struct_elt_for_reference): Likewise.
9106         * NEWS: Mention this change.
9107
9108 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9109
9110         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9111         print_source_lines.
9112         * source.c (print_source_lines_base): Update line number check.
9113         (print_source_lines): New function.
9114         (source_lines_range::source_lines_range): New function.
9115         * source.h (class source_lines_range): New class.
9116         (print_source_lines): New declaration.
9117
9118 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9119
9120         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9121
9122 2019-01-08  Tom Tromey  <tom@tromey.com>
9123             Simon Marchi  <simon.marchi@ericsson.com>
9124
9125         PR gdb/24060
9126         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9127         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9128         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9129         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9130         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9131         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9132
9133 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9134
9135         * source.c (select_source_symtab): Move header comment to
9136         declaration in source.h.
9137         (forget_cached_source_info_for_objfile): Likewise.
9138         (forget_cached_source_info): Likewise.
9139         (identify_source_line): Likewise.
9140         * source.h (identify_source_line): Move declaration from symtab.h
9141         and add comment from source.c
9142         (print_source_lines): Likewise.
9143         (forget_cached_source_info_for_objfile): Likewise.
9144         (forget_cached_source_info): Likewise.
9145         (select_source_symtab): Likewise.
9146         (enum print_source_lines_flag): Move definition from symtab.h.
9147         * symtab.h (identify_source_line): Move declaration to source.h.
9148         (print_source_lines): Likewise.
9149         (forget_cached_source_info_for_objfile): Likewise.
9150         (forget_cached_source_info): Likewise.
9151         (select_source_symtab): Likewise.
9152         (enum print_source_lines_flag): Move definition to source.h.
9153         * tui/tui-hooks.c: Add 'source.h' include.
9154
9155 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9156
9157         * source.c (print_source_lines_base): Handle requests to print
9158         reverse line number sequences, and guard against empty lines
9159         string.
9160
9161 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9162
9163         * source.c (print_source_lines_base): Fix skip of '\r' if next
9164         character is '\n'.
9165
9166 2019-01-06  Tom Tromey  <tom@tromey.com>
9167
9168         * c-exp.y (struct c_parse_state) <macro_original_text,
9169         expansion_obstack>: New member.
9170         (macro_original_text, expansion_obstack): Remove globals.
9171         (scan_macro_expansion, scanning_macro_expansion)
9172         (finished_macro_expansion): Update.
9173         (scan_macro_cleanup): Remove.
9174         (yylex, c_parse): Update.
9175
9176 2019-01-06  Tom Tromey  <tom@tromey.com>
9177
9178         * c-exp.y (struct c_parse_state) <strings>: New member.
9179         (operator_stoken): Update.
9180
9181 2019-01-06  Tom Tromey  <tom@tromey.com>
9182
9183         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9184         (union type_stack_elt) <typelist_val>: Now a pointer to
9185         std::vector.
9186         (type_stack_cleanup): Don't declare.
9187         (push_typelist): Update.
9188         * parse.c (pop_typelist): Return a std::vector.
9189         (push_typelist): Take a std::vector.
9190         (follow_types): Update.  Do not free args.
9191         (type_stack_cleanup): Remove.
9192         * c-exp.y (struct c_parse_state): New.
9193         (cpstate): New global.
9194         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9195         (nonempty_typelist): Update.
9196         (func_mod): Create a new vector.
9197         (c_parse): Create a c_parse_state.
9198         (check_parameter_typelist): Do not delete params.
9199         (function_method): Update.  Do not delete type_list.
9200
9201 2019-01-06  Tom Tromey  <tom@tromey.com>
9202
9203         PR gdb/28155:
9204         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9205         check_typedef.
9206         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9207         (print_return_value): Likewise.
9208
9209 2019-01-05  Tom Tromey  <tom@tromey.com>
9210
9211         * contrib/cleanup_check.py: Remove.
9212         * contrib/gcc-with-excheck: Remove.
9213         * contrib/exsummary.py: Remove.
9214         * contrib/excheck.py: Remove.
9215
9216 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9217
9218         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9219         NULL. Initialize tpprev to NULL instead of assigning it
9220         to NULL on the next statement.
9221         * windows-nat.c (windows_delete_thread): Remove check for
9222         main_thread_id before printing thread exit notifications.
9223         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9224         Remove thread ID check against main_thread_id.
9225         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9226         windows_delete_thread.
9227         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9228
9229 2019-01-04  Tom Tromey  <tom@tromey.com>
9230
9231         * compile/compile.c (_initialize_compile): Use upper case for
9232         metasyntactic variables.
9233         * symmisc.c (_initialize_symmisc): Use upper case for
9234         metasyntactic variables.
9235         * psymtab.c (_initialize_psymtab): Use upper case for
9236         metasyntactic variables.
9237         * demangle.c (demangle_command): Use upper case for metasyntactic
9238         variables.
9239         (_initialize_demangler): Likewise.
9240         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9241         variables.
9242
9243 2019-01-03  Tom Tromey  <tom@tromey.com>
9244
9245         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9246
9247 2019-01-03  Tom Tromey  <tom@tromey.com>
9248
9249         * python/py-symtab.c (salpy_str): Update.
9250         (struct salpy_sal_object) <symtab>: Now a PyObject.
9251         (salpy_dealloc): Update.
9252         (del_objfile_sal): Use gdbpy_ref.
9253
9254 2019-01-03  Tom Tromey  <tom@tromey.com>
9255
9256         * python/py-type.c (convert_field): Use new_reference.  Return
9257         gdbpy_ref.
9258         (make_fielditem): Return gdbpy_ref.
9259         (typy_fields): Update.
9260         (typy_getitem): Update.
9261         (field_name): Return gdbpy_ref.  Use new_reference.
9262         (typy_iterator_iternext): Update.
9263
9264 2019-01-03  Tom Tromey  <tom@tromey.com>
9265
9266         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9267
9268 2019-01-03  Tom Tromey  <tom@tromey.com>
9269
9270         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9271         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9272         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9273         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9274         (pspy_set_type_printers): Likewise.
9275         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9276         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9277         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9278         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9279         (objfpy_set_type_printers): Likewise.
9280
9281 2019-01-03  Tom Tromey  <tom@tromey.com>
9282
9283         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9284         (gdbpy_print_stack): Use gdbpy_err_fetch.
9285         * python/python-internal.h (class gdbpy_err_fetch): New class.
9286         (class gdbpy_enter) <m_error_type, m_error_value,
9287         m_error_traceback>: Remove.
9288         <m_error>: New member.
9289         (gdbpy_exception_to_string): Don't declare.
9290         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9291         * python/py-value.c (convert_value_from_python): Use
9292         gdbpy_err_fetch.
9293         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9294         gdbpy_exception_to_string.
9295         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9296         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9297         gdbpy_err_fetch.
9298
9299 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9300
9301         * linux-nat.c (delete_lwp_cleanup): Delete.
9302         (struct lwp_deleter): New struct.
9303         (lwp_info_up): New typedef.
9304         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9305         lwp_info_up.
9306
9307 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9308
9309         * linux-fork.c (class scoped_switch_fork_info): New class.
9310         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9311
9312 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9313
9314         * valops.c (find_overload_match): Remove use of null_cleanup, and
9315         calls to do_cleanups.
9316
9317 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9318
9319         * compile/compile-cplus-types.c
9320         (compile_cplus_instance::decl_name): Handle changes to
9321         cp_func_name.
9322         * cp-support.c (cp_func_name): Update header comment, update
9323         return type.
9324         * cp-support.h (cp_func_name): Update return type in declaration.
9325         * valops.c (find_overload_match): Move temp_func local to top
9326         level of function and change its type.  Use temp_func to hold and
9327         delete temporary string obtained from cp_func_name.
9328
9329 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9330
9331         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9332         gdb::char_vector, remove cleanup, and update uses of `msg`.
9333
9334 2019-01-03  Jim Wilson  <jimw@sifive.com>
9335
9336         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9337
9338 2019-01-02  Tom Tromey  <tom@tromey.com>
9339
9340         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9341         (tdesc_parse_xml): Remove cleanups.
9342         * target-descriptions.h (make_cleanup_free_target_description):
9343         Don't declare.
9344         (target_desc_deleter): New struct.
9345         (target_desc_up): New typedef.
9346         * target-descriptions.c (target_desc_deleter::operator()): Rename
9347         from free_target_description.
9348         (make_cleanup_free_target_description): Remove.
9349
9350 2019-01-02  Tom Tromey  <tom@tromey.com>
9351
9352         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9353         constructor, destructor.
9354         (linespec_parser): Remove typedef.
9355         (~linespec_parser): Rename from linespec_parser_delete.
9356         (linespec_lex_to_end, linespec_complete_label)
9357         (linespec_complete): Update.
9358         (decode_line_full): Remove cleanups.
9359         (decode_line_1): Update.
9360
9361 2019-01-02  Tom Tromey  <tom@tromey.com>
9362
9363         * python/python-internal.h (inferior_to_inferior_object): Change
9364         return type.
9365         * python/py-exitedevent.c (create_exited_event_object): Update.
9366         * python/py-inferior.c (inferior_to_inferior_object): Return
9367         gdbpy_ref.
9368         (python_new_inferior, python_inferior_deleted)
9369         (thread_to_thread_object, delete_thread_object)
9370         (build_inferior_list, gdbpy_selected_inferior): Update.
9371         * python/py-infthread.c (create_thread_object): Update.  Also fail
9372         if inferior_to_inferior_object fails.
9373
9374 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9375
9376         * inferior.h (class inferior) <displaced_step_state>: New field.
9377         * infrun.h (struct displaced_step_state): Move here from
9378         infrun.c.  Initialize fields, add constructor.
9379         <inf>: Remove field.
9380         <reset>: New method.
9381         * infrun.c (struct displaced_step_inferior_state): Move to
9382         infrun.h.
9383         (displaced_step_inferior_states): Remove.
9384         (get_displaced_stepping_state): Adust.
9385         (displaced_step_in_progress_any_inferior): Adjust.
9386         (displaced_step_in_progress_thread): Adjust.
9387         (displaced_step_in_progress): Adjust.
9388         (add_displaced_stepping_state): Remove.
9389         (get_displaced_step_closure_by_addr): Adjust.
9390         (remove_displaced_stepping_state): Remove.
9391         (infrun_inferior_exit): Call displaced_step_state.reset.
9392         (use_displaced_stepping): Don't check for NULL.
9393         (displaced_step_prepare_throw): Call
9394         get_displaced_stepping_state.
9395         (displaced_step_fixup): Don't check for NULL.
9396         (prepare_for_detach): Don't check for NULL.
9397
9398 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9399
9400         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
9401          in case of call that did not complete.
9402
9403 2019-01-02  Andrey Utkin  <autkin@undo.io>
9404
9405         * symfile.c (find_separate_debug_file): Fix search of debug files for
9406         remote debuggee.
9407
9408 2019-01-02  Tom Tromey  <tom@tromey.com>
9409
9410         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
9411         indentation.
9412         * python/py-frame.c (frapy_older): Remove cast.
9413         (frapy_newer): Likewise.
9414         * python/py-breakpoint.c (local_setattro): Remove cast.
9415         * python/py-arch.c (archpy_name): Remove local variable.
9416         * python/py-type.c (gdbpy_lookup_type): Remove cast.
9417
9418 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
9419
9420         * unittests/basic_string_view/element_access/char/empty.cc:
9421         Fix year range in copyright header.
9422
9423 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9424
9425         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
9426         Delete.
9427         <operator==>: Update with for removed field.
9428         <hash>: Likewise.
9429         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
9430         <isa_features>: ...this.
9431         <abi_features>: New field.
9432         (riscv_isa_flen): Update comment.
9433         (riscv_abi_xlen): New declaration.
9434         (riscv_abi_flen): New declaration.
9435         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
9436         isa_features.
9437         (riscv_abi_xlen): New function.
9438         (riscv_isa_flen): Update to get answer from isa_features.
9439         (riscv_abi_flen): New function.
9440         (riscv_has_fp_abi): Update to get answer from abi_features.
9441         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
9442         xlen and flen.
9443         (riscv_call_info) <xlen, flen>: Update comment.
9444         (riscv_call_arg_struct): Remove invalid assertions
9445         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
9446         is removed.
9447         (riscv_gdbarch_init): Gather isa features and abi features
9448         separately, ensure both match on the gdbarch when reusing an old
9449         gdbarch.  Relax an error check to allow 32-bit abi float to run on
9450         a target with 64-bit float hardware.
9451
9452 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9453
9454         * source.c (search_command_helper): Stop reverse search
9455         when line 1 has been searched.
9456
9457 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9458
9459         * record-full.c (record_full_base_target::close): Rewrite
9460         record_full_core_buf_list free logic.
9461
9462 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9463
9464         * break-catch-syscall.c (print_one_catch_syscall): xfree
9465         the last text.
9466
9467 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9468
9469         * top.c (print_gdb_version): Update Copyright year in version
9470         message.
9471
9472 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9473
9474         Update copyright year range in all GDB files.
9475
9476 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
9477
9478         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
9479
9480 For older changes see ChangeLog-2018.
9481 \f
9482 Local Variables:
9483 mode: change-log
9484 left-margin: 8
9485 fill-column: 74
9486 version-control: never
9487 coding: utf-8
9488 End:
9489