gdb/ChangeLog

   1 2019-02-15  Tom Tromey  <tromey@adacore.com>
   2
   3         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
   4         (ravenscar_thread_target::stopped_by_hw_breakpoint)
   5         (ravenscar_thread_target::stopped_by_watchpoint)
   6         (ravenscar_thread_target::stopped_data_address)
   7         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
   8
   9 2019-02-15  Tom Tromey  <tromey@adacore.com>
  10
  11         * ravenscar-thread.c: Fix some typos.
  12
  13 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  14             Tom Tromey  <tromey@adacore.com>
  15
  16         * ada-lang.c (ada_exception_sal): Change addr_string to a
  17         std::string.
  18         (create_ada_exception_catchpoint): Update.
  19
  20 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  21             Tom Tromey  <tromey@adacore.com>
  22
  23         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
  24         (bp_location_ops): Remove.
  25         (base_breakpoint_allocate_location): Update.
  26         (free_bp_location): Update.
  27         * ada-lang.c (class ada_catchpoint_location)
  28         <ada_catchpoint_location>: Remove ops parameter.
  29         (ada_catchpoint_location_dtor): Remove.
  30         (ada_catchpoint_location_ops): Remove.
  31         (allocate_location_exception): Update.
  32         * breakpoint.h (struct bp_location_ops): Remove.
  33         (class bp_location) <bp_location>: Remove bp_location_ops
  34         parameter.
  35         <~bp_location>: Add destructor.
  36         <ops>: Remove.
  37
  38 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
  39             Pedro Alves  <palves@redhat.com>
  40
  41         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
  42         'PATH_MAX'.
  43
  44 2019-02-14  David Michael  <fedora.dm0@gmail.com>
  45             Samuel Thibault  <samuel.thibault@gnu.org>
  46             Thomas Schwinge  <thomas@codesourcery.com>
  47
  48         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
  49         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
  50
  51 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
  52
  53         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
  54         (check_empty): Use "const char *".
  55
  56         * gnu-nat.c (gnu_nat_target::detach): Instead of
  57         'detach_inferior (pid)' call
  58         'detach_inferior (find_inferior_pid (pid))'.
  59
  60         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
  61         'nat/fork-inferior.o'.
  62         * gnu-nat.c: #include "nat/fork-inferior.h".
  63
  64         * gnu-nat.c (gnu_nat_target::detach): Instead of
  65         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
  66         * gnu-nat.h: #include "inf-child.h".
  67         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
  68         'i386_gnu_nat_target::fetch_registers'.
  69         (gnu_store_registers): Rename/move to
  70         'i386_gnu_nat_target::store_registers'.
  71
  72         * config/i386/nm-i386gnu.h: Don't "#include" any files.
  73         * gnu-nat.h (mach_thread_info): New function.
  74         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
  75
  76         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
  77
  78 2019-02-14  Frederic Konrad  <konrad@adacore.com>
  79
  80         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
  81
  82 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
  83
  84         * windows-nat.c (windows_add_thread): Add new parameter
  85         "main_thread_p" with default value set to false.  Update
  86         function documentation as well as all callers.
  87         (windows_delete_thread): Likewise.
  88         (fake_create_process): Update call to windows_add_thread.
  89         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
  90         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
  91         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
  92         call to windows_delete_thread.
  93
  94 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
  95
  96         * MAINTAINERS: Add Andrew Burgess as global maintainer.
  97
  98 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
  99
 100         * symfile.c (find_separate_debug_file): Use canonical path of
 101         sysroot with child_path instead of gdb_sysroot if it is valid.
 102
 103 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 104
 105         * symfile.c (find_separate_debug_file): Use child_path to
 106         determine if an object file is under a sysroot.
 107
 108 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 109
 110         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 111         unittests/child-path-selftests.c.
 112         * common/pathstuff.c (child_path): New function.
 113         * common/pathstuff.h (child_path): New prototype.
 114         * unittests/child-path-selftests.c: New file.
 115
 116 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 117
 118         * symfile.c (find_separate_debug_file): Look for separate debug
 119         files in debug directories under the sysroot.
 120
 121 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 122
 123         * symtab.h (struct minimal_symbol data_p): New const method.
 124         (struct minimal_symbol text_p): Likewise.
 125         * symtab.c (output_source_filename): Use file name style
 126         to print file name.
 127         (print_symbol_info): Likewise.
 128         (print_msymbol_info): Use address style to print addresses.
 129         Use function name style to print executable text symbols.
 130         (expand_symtab_containing_pc): Use data_p.
 131         (find_pc_sect_compunit_symtab): Likewise.
 132
 133 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 134
 135         * breakpoint.c (describe_other_breakpoints): Use address style
 136         to print addresses.
 137         (say_where): Likewise.
 138
 139 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 140
 141         * ada-typeprint.c (print_func_type): Print function name
 142         style to print function name.
 143         * c-typeprint.c (c_print_type_1): Likewise.
 144
 145 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 146
 147         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 148         for execve.
 149
 150 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 151
 152         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 153         type_stack.
 154
 155 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 156
 157         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 158         TYPE_CODE_REF types.
 159
 160 2019-02-08  Jim Wilson  <jimw@sifive.com>
 161
 162         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 163         (riscv_linux_fregset): New.
 164         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 165
 166 2019-02-07  Tom Tromey  <tom@tromey.com>
 167
 168         * thread.c (thread_cancel_execution_command): Update.
 169         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 170         methods.
 171         (struct thread_fsm_ops): Remove.
 172         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 173         (thread_fsm_should_stop, thread_fsm_return_value)
 174         (thread_fsm_set_finished, thread_fsm_finished_p)
 175         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 176         Don't declare.
 177         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 178         * infrun.c (clear_proceed_status_thread)
 179         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 180         (print_stop_event): Update.
 181         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 182         Add constructor.
 183         (step_command_fsm_ops): Remove.
 184         (new_step_command_fsm): Remove.
 185         (step_1): Update.
 186         (step_command_fsm::should_stop): Rename from
 187         step_command_fsm_should_stop.
 188         (step_command_fsm::clean_up): Rename from
 189         step_command_fsm_clean_up.
 190         (step_command_fsm::do_async_reply_reason): Rename from
 191         step_command_fsm_async_reply_reason.
 192         (struct until_next_fsm): Inherit from thread_fsm.  Add
 193         constructor.
 194         (until_next_fsm_ops): Remove.
 195         (new_until_next_fsm): Remove.
 196         (until_next_fsm::should_stop): Rename from
 197         until_next_fsm_should_stop.
 198         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 199         (until_next_fsm::do_async_reply_reason): Rename from
 200         until_next_fsm_async_reply_reason.
 201         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 202         constructor.  Change type of breakpoint.
 203         (finish_command_fsm_ops): Remove.
 204         (new_finish_command_fsm): Remove.
 205         (finish_command_fsm::should_stop): Rename from
 206         finish_command_fsm_should_stop.
 207         (finish_command_fsm::clean_up): Rename from
 208         finish_command_fsm_clean_up.
 209         (finish_command_fsm::return_value): Rename from
 210         finish_command_fsm_return_value.
 211         (finish_command_fsm::do_async_reply_reason): Rename from
 212         finish_command_fsm_async_reply_reason.
 213         (finish_command): Update.
 214         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 215         Add constructor.
 216         (call_thread_fsm_ops): Remove.
 217         (call_thread_fsm::call_thread_fsm): Rename from
 218         new_call_thread_fsm.
 219         (call_thread_fsm::should_stop): Rename from
 220         call_thread_fsm_should_stop.
 221         (call_thread_fsm::should_notify_stop): Rename from
 222         call_thread_fsm_should_notify_stop.
 223         (run_inferior_call, call_function_by_hand_dummy): Update.
 224         * cli/cli-interp.c (should_print_stop_to_console): Update.
 225         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 226         Add constructor.  Change type of location_breakpoint,
 227         caller_breakpoint.
 228         (until_break_fsm_ops): Remove.
 229         (new_until_break_fsm): Remove.
 230         (until_break_fsm::should_stop): Rename from
 231         until_break_fsm_should_stop.
 232         (until_break_fsm::clean_up): Rename from
 233         until_break_fsm_clean_up.
 234         (until_break_fsm::do_async_reply_reason): Rename from
 235         until_break_fsm_async_reply_reason.
 236         (until_break_command): Update.
 237         * thread-fsm.c: Remove.
 238         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 239
 240 2019-02-07  Tom Tromey  <tom@tromey.com>
 241
 242         * yy-remap.h: Add include guard.
 243         * xtensa-tdep.h: Add include guard.
 244         * xcoffread.h: Rename include guard.
 245         * varobj-iter.h: Add include guard.
 246         * tui/tui.h: Rename include guard.
 247         * tui/tui-winsource.h: Rename include guard.
 248         * tui/tui-wingeneral.h: Rename include guard.
 249         * tui/tui-windata.h: Rename include guard.
 250         * tui/tui-win.h: Rename include guard.
 251         * tui/tui-stack.h: Rename include guard.
 252         * tui/tui-source.h: Rename include guard.
 253         * tui/tui-regs.h: Rename include guard.
 254         * tui/tui-out.h: Rename include guard.
 255         * tui/tui-layout.h: Rename include guard.
 256         * tui/tui-io.h: Rename include guard.
 257         * tui/tui-hooks.h: Rename include guard.
 258         * tui/tui-file.h: Rename include guard.
 259         * tui/tui-disasm.h: Rename include guard.
 260         * tui/tui-data.h: Rename include guard.
 261         * tui/tui-command.h: Rename include guard.
 262         * tic6x-tdep.h: Add include guard.
 263         * target/waitstatus.h: Rename include guard.
 264         * target/wait.h: Rename include guard.
 265         * target/target.h: Rename include guard.
 266         * target/resume.h: Rename include guard.
 267         * target-float.h: Rename include guard.
 268         * stabsread.h: Add include guard.
 269         * rs6000-tdep.h: Add include guard.
 270         * riscv-fbsd-tdep.h: Add include guard.
 271         * regformats/regdef.h: Rename include guard.
 272         * record.h: Rename include guard.
 273         * python/python.h: Rename include guard.
 274         * python/python-internal.h: Rename include guard.
 275         * python/py-stopevent.h: Rename include guard.
 276         * python/py-ref.h: Rename include guard.
 277         * python/py-record.h: Rename include guard.
 278         * python/py-record-full.h: Rename include guard.
 279         * python/py-record-btrace.h: Rename include guard.
 280         * python/py-instruction.h: Rename include guard.
 281         * python/py-events.h: Rename include guard.
 282         * python/py-event.h: Rename include guard.
 283         * procfs.h: Add include guard.
 284         * proc-utils.h: Add include guard.
 285         * p-lang.h: Add include guard.
 286         * or1k-tdep.h: Rename include guard.
 287         * observable.h: Rename include guard.
 288         * nto-tdep.h: Rename include guard.
 289         * nat/x86-linux.h: Rename include guard.
 290         * nat/x86-linux-dregs.h: Rename include guard.
 291         * nat/x86-gcc-cpuid.h: Add include guard.
 292         * nat/x86-dregs.h: Rename include guard.
 293         * nat/x86-cpuid.h: Rename include guard.
 294         * nat/ppc-linux.h: Rename include guard.
 295         * nat/mips-linux-watch.h: Rename include guard.
 296         * nat/linux-waitpid.h: Rename include guard.
 297         * nat/linux-ptrace.h: Rename include guard.
 298         * nat/linux-procfs.h: Rename include guard.
 299         * nat/linux-osdata.h: Rename include guard.
 300         * nat/linux-nat.h: Rename include guard.
 301         * nat/linux-namespaces.h: Rename include guard.
 302         * nat/linux-btrace.h: Rename include guard.
 303         * nat/glibc_thread_db.h: Rename include guard.
 304         * nat/gdb_thread_db.h: Rename include guard.
 305         * nat/gdb_ptrace.h: Rename include guard.
 306         * nat/fork-inferior.h: Rename include guard.
 307         * nat/amd64-linux-siginfo.h: Rename include guard.
 308         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 309         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 310         * nat/aarch64-linux.h: Rename include guard.
 311         * nat/aarch64-linux-hw-point.h: Rename include guard.
 312         * mn10300-tdep.h: Add include guard.
 313         * mips-linux-tdep.h: Add include guard.
 314         * mi/mi-parse.h: Rename include guard.
 315         * mi/mi-out.h: Rename include guard.
 316         * mi/mi-main.h: Rename include guard.
 317         * mi/mi-interp.h: Rename include guard.
 318         * mi/mi-getopt.h: Rename include guard.
 319         * mi/mi-console.h: Rename include guard.
 320         * mi/mi-common.h: Rename include guard.
 321         * mi/mi-cmds.h: Rename include guard.
 322         * mi/mi-cmd-break.h: Rename include guard.
 323         * m2-lang.h: Add include guard.
 324         * location.h: Rename include guard.
 325         * linux-record.h: Rename include guard.
 326         * linux-nat.h: Add include guard.
 327         * linux-fork.h: Add include guard.
 328         * i386-darwin-tdep.h: Rename include guard.
 329         * hppa-linux-offsets.h: Add include guard.
 330         * guile/guile.h: Rename include guard.
 331         * guile/guile-internal.h: Rename include guard.
 332         * gnu-nat.h: Rename include guard.
 333         * gdb-stabs.h: Rename include guard.
 334         * frv-tdep.h: Add include guard.
 335         * f-lang.h: Add include guard.
 336         * event-loop.h: Add include guard.
 337         * darwin-nat.h: Rename include guard.
 338         * cp-abi.h: Rename include guard.
 339         * config/sparc/nm-sol2.h: Rename include guard.
 340         * config/nm-nto.h: Rename include guard.
 341         * config/nm-linux.h: Add include guard.
 342         * config/i386/nm-i386gnu.h: Rename include guard.
 343         * config/djgpp/nl_types.h: Rename include guard.
 344         * config/djgpp/langinfo.h: Rename include guard.
 345         * compile/gcc-cp-plugin.h: Add include guard.
 346         * compile/gcc-c-plugin.h: Add include guard.
 347         * compile/compile.h: Rename include guard.
 348         * compile/compile-object-run.h: Rename include guard.
 349         * compile/compile-object-load.h: Rename include guard.
 350         * compile/compile-internal.h: Rename include guard.
 351         * compile/compile-cplus.h: Rename include guard.
 352         * compile/compile-c.h: Rename include guard.
 353         * common/xml-utils.h: Rename include guard.
 354         * common/x86-xstate.h: Rename include guard.
 355         * common/version.h: Rename include guard.
 356         * common/vec.h: Rename include guard.
 357         * common/tdesc.h: Rename include guard.
 358         * common/selftest.h: Rename include guard.
 359         * common/scoped_restore.h: Rename include guard.
 360         * common/scoped_mmap.h: Rename include guard.
 361         * common/scoped_fd.h: Rename include guard.
 362         * common/safe-iterator.h: Rename include guard.
 363         * common/run-time-clock.h: Rename include guard.
 364         * common/refcounted-object.h: Rename include guard.
 365         * common/queue.h: Rename include guard.
 366         * common/ptid.h: Rename include guard.
 367         * common/print-utils.h: Rename include guard.
 368         * common/preprocessor.h: Rename include guard.
 369         * common/pathstuff.h: Rename include guard.
 370         * common/observable.h: Rename include guard.
 371         * common/netstuff.h: Rename include guard.
 372         * common/job-control.h: Rename include guard.
 373         * common/host-defs.h: Rename include guard.
 374         * common/gdb_wait.h: Rename include guard.
 375         * common/gdb_vecs.h: Rename include guard.
 376         * common/gdb_unlinker.h: Rename include guard.
 377         * common/gdb_unique_ptr.h: Rename include guard.
 378         * common/gdb_tilde_expand.h: Rename include guard.
 379         * common/gdb_sys_time.h: Rename include guard.
 380         * common/gdb_string_view.h: Rename include guard.
 381         * common/gdb_splay_tree.h: Rename include guard.
 382         * common/gdb_setjmp.h: Rename include guard.
 383         * common/gdb_ref_ptr.h: Rename include guard.
 384         * common/gdb_optional.h: Rename include guard.
 385         * common/gdb_locale.h: Rename include guard.
 386         * common/gdb_assert.h: Rename include guard.
 387         * common/filtered-iterator.h: Rename include guard.
 388         * common/filestuff.h: Rename include guard.
 389         * common/fileio.h: Rename include guard.
 390         * common/environ.h: Rename include guard.
 391         * common/common-utils.h: Rename include guard.
 392         * common/common-types.h: Rename include guard.
 393         * common/common-regcache.h: Rename include guard.
 394         * common/common-inferior.h: Rename include guard.
 395         * common/common-gdbthread.h: Rename include guard.
 396         * common/common-exceptions.h: Rename include guard.
 397         * common/common-defs.h: Rename include guard.
 398         * common/common-debug.h: Rename include guard.
 399         * common/cleanups.h: Rename include guard.
 400         * common/buffer.h: Rename include guard.
 401         * common/btrace-common.h: Rename include guard.
 402         * common/break-common.h: Rename include guard.
 403         * cli/cli-utils.h: Rename include guard.
 404         * cli/cli-style.h: Rename include guard.
 405         * cli/cli-setshow.h: Rename include guard.
 406         * cli/cli-script.h: Rename include guard.
 407         * cli/cli-interp.h: Rename include guard.
 408         * cli/cli-decode.h: Rename include guard.
 409         * cli/cli-cmds.h: Rename include guard.
 410         * charset-list.h: Add include guard.
 411         * buildsym-legacy.h: Rename include guard.
 412         * bfin-tdep.h: Add include guard.
 413         * ax.h: Rename include guard.
 414         * arm-linux-tdep.h: Add include guard.
 415         * arm-fbsd-tdep.h: Add include guard.
 416         * arch/xtensa.h: Rename include guard.
 417         * arch/tic6x.h: Add include guard.
 418         * arch/i386.h: Add include guard.
 419         * arch/arm.h: Rename include guard.
 420         * arch/arm-linux.h: Rename include guard.
 421         * arch/arm-get-next-pcs.h: Rename include guard.
 422         * arch/amd64.h: Add include guard.
 423         * arch/aarch64-insn.h: Rename include guard.
 424         * arch-utils.h: Rename include guard.
 425         * annotate.h: Add include guard.
 426         * amd64-darwin-tdep.h: Rename include guard.
 427         * aarch64-linux-tdep.h: Add include guard.
 428         * aarch64-fbsd-tdep.h: Add include guard.
 429         * aarch32-linux-nat.h: Add include guard.
 430
 431 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 432
 433         * macrotab.c (macro_define_internal): New function that
 434         factorizes macro_define_object_internal and macro_define_function
 435         code.
 436         (macro_define_object_internal): Use macro_define_internal.
 437         (macro_define_function): Likewise.
 438
 439 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 440
 441         * macrocmd.c (extract_identifier): Return
 442         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
 443         callers.
 444
 445 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
 446
 447         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
 448
 449 2019-02-05  Tom Tromey  <tom@tromey.com>
 450
 451         * target.c (target_stack::unpush): Move assertion earlier.
 452
 453 2019-01-30  Tom Tromey  <tom@tromey.com>
 454
 455         PR python/23615:
 456         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
 457         (gdbpy_parse_and_eval): Likewise.
 458         * python/python-internal.h (gdbpy_allow_threads): New class.
 459
 460 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
 461
 462         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
 463         (aarch64_fbsd_fpregmap): Move earlier.
 464         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
 465         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 466         instead of individual calls to trad_frame_set_reg_addr.
 467         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
 468         earlier.
 469         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
 470         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 471         instead of individual calls to trad_frame_set_reg_addr.
 472
 473 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
 474
 475         * CONTRIBUTE: Replace contribution list with wiki link.
 476
 477 2019-01-25  Tom Tromey  <tom@tromey.com>
 478
 479         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
 480
 481 2019-01-25  Tom Tromey  <tom@tromey.com>
 482
 483         * xtensa-linux-nat.c: Fix common/ includes.
 484         * xml-support.h: Fix common/ includes.
 485         * xml-support.c: Fix common/ includes.
 486         * x86-linux-nat.c: Fix common/ includes.
 487         * windows-nat.c: Fix common/ includes.
 488         * varobj.h: Fix common/ includes.
 489         * varobj.c: Fix common/ includes.
 490         * value.c: Fix common/ includes.
 491         * valops.c: Fix common/ includes.
 492         * utils.c: Fix common/ includes.
 493         * unittests/xml-utils-selftests.c: Fix common/ includes.
 494         * unittests/utils-selftests.c: Fix common/ includes.
 495         * unittests/unpack-selftests.c: Fix common/ includes.
 496         * unittests/tracepoint-selftests.c: Fix common/ includes.
 497         * unittests/style-selftests.c: Fix common/ includes.
 498         * unittests/string_view-selftests.c: Fix common/ includes.
 499         * unittests/scoped_restore-selftests.c: Fix common/ includes.
 500         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
 501         * unittests/scoped_fd-selftests.c: Fix common/ includes.
 502         * unittests/rsp-low-selftests.c: Fix common/ includes.
 503         * unittests/parse-connection-spec-selftests.c: Fix common/
 504         includes.
 505         * unittests/optional-selftests.c: Fix common/ includes.
 506         * unittests/offset-type-selftests.c: Fix common/ includes.
 507         * unittests/observable-selftests.c: Fix common/ includes.
 508         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
 509         * unittests/memrange-selftests.c: Fix common/ includes.
 510         * unittests/memory-map-selftests.c: Fix common/ includes.
 511         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
 512         * unittests/function-view-selftests.c: Fix common/ includes.
 513         * unittests/environ-selftests.c: Fix common/ includes.
 514         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
 515         * unittests/common-utils-selftests.c: Fix common/ includes.
 516         * unittests/cli-utils-selftests.c: Fix common/ includes.
 517         * unittests/array-view-selftests.c: Fix common/ includes.
 518         * ui-file.c: Fix common/ includes.
 519         * tui/tui-io.c: Fix common/ includes.
 520         * tracepoint.h: Fix common/ includes.
 521         * tracepoint.c: Fix common/ includes.
 522         * tracefile-tfile.c: Fix common/ includes.
 523         * top.h: Fix common/ includes.
 524         * top.c: Fix common/ includes.
 525         * thread.c: Fix common/ includes.
 526         * target/waitstatus.h: Fix common/ includes.
 527         * target/waitstatus.c: Fix common/ includes.
 528         * target.h: Fix common/ includes.
 529         * target.c: Fix common/ includes.
 530         * target-memory.c: Fix common/ includes.
 531         * target-descriptions.c: Fix common/ includes.
 532         * symtab.h: Fix common/ includes.
 533         * symfile.c: Fix common/ includes.
 534         * stap-probe.c: Fix common/ includes.
 535         * spu-linux-nat.c: Fix common/ includes.
 536         * sparc-nat.c: Fix common/ includes.
 537         * source.c: Fix common/ includes.
 538         * solib.c: Fix common/ includes.
 539         * solib-target.c: Fix common/ includes.
 540         * ser-unix.c: Fix common/ includes.
 541         * ser-tcp.c: Fix common/ includes.
 542         * ser-pipe.c: Fix common/ includes.
 543         * ser-base.c: Fix common/ includes.
 544         * selftest-arch.c: Fix common/ includes.
 545         * s12z-tdep.c: Fix common/ includes.
 546         * rust-exp.y: Fix common/ includes.
 547         * rs6000-aix-tdep.c: Fix common/ includes.
 548         * riscv-tdep.c: Fix common/ includes.
 549         * remote.c: Fix common/ includes.
 550         * remote-notif.h: Fix common/ includes.
 551         * remote-fileio.h: Fix common/ includes.
 552         * remote-fileio.c: Fix common/ includes.
 553         * regcache.h: Fix common/ includes.
 554         * regcache.c: Fix common/ includes.
 555         * record-btrace.c: Fix common/ includes.
 556         * python/python.c: Fix common/ includes.
 557         * python/py-type.c: Fix common/ includes.
 558         * python/py-inferior.c: Fix common/ includes.
 559         * progspace.h: Fix common/ includes.
 560         * producer.c: Fix common/ includes.
 561         * procfs.c: Fix common/ includes.
 562         * proc-api.c: Fix common/ includes.
 563         * printcmd.c: Fix common/ includes.
 564         * ppc-linux-nat.c: Fix common/ includes.
 565         * parser-defs.h: Fix common/ includes.
 566         * osdata.c: Fix common/ includes.
 567         * obsd-nat.c: Fix common/ includes.
 568         * nat/x86-linux.c: Fix common/ includes.
 569         * nat/x86-linux-dregs.c: Fix common/ includes.
 570         * nat/x86-dregs.h: Fix common/ includes.
 571         * nat/x86-dregs.c: Fix common/ includes.
 572         * nat/ppc-linux.c: Fix common/ includes.
 573         * nat/mips-linux-watch.h: Fix common/ includes.
 574         * nat/mips-linux-watch.c: Fix common/ includes.
 575         * nat/linux-waitpid.c: Fix common/ includes.
 576         * nat/linux-ptrace.h: Fix common/ includes.
 577         * nat/linux-ptrace.c: Fix common/ includes.
 578         * nat/linux-procfs.c: Fix common/ includes.
 579         * nat/linux-personality.c: Fix common/ includes.
 580         * nat/linux-osdata.c: Fix common/ includes.
 581         * nat/linux-namespaces.c: Fix common/ includes.
 582         * nat/linux-btrace.h: Fix common/ includes.
 583         * nat/linux-btrace.c: Fix common/ includes.
 584         * nat/fork-inferior.c: Fix common/ includes.
 585         * nat/amd64-linux-siginfo.c: Fix common/ includes.
 586         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
 587         * nat/aarch64-linux.c: Fix common/ includes.
 588         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
 589         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
 590         * namespace.h: Fix common/ includes.
 591         * mips-linux-tdep.c: Fix common/ includes.
 592         * minsyms.c: Fix common/ includes.
 593         * mi/mi-parse.h: Fix common/ includes.
 594         * mi/mi-main.c: Fix common/ includes.
 595         * mi/mi-cmd-env.c: Fix common/ includes.
 596         * memrange.h: Fix common/ includes.
 597         * memattr.c: Fix common/ includes.
 598         * maint.h: Fix common/ includes.
 599         * maint.c: Fix common/ includes.
 600         * main.c: Fix common/ includes.
 601         * machoread.c: Fix common/ includes.
 602         * location.c: Fix common/ includes.
 603         * linux-thread-db.c: Fix common/ includes.
 604         * linux-nat.c: Fix common/ includes.
 605         * linux-fork.c: Fix common/ includes.
 606         * inline-frame.c: Fix common/ includes.
 607         * infrun.c: Fix common/ includes.
 608         * inflow.c: Fix common/ includes.
 609         * inferior.h: Fix common/ includes.
 610         * inferior.c: Fix common/ includes.
 611         * infcmd.c: Fix common/ includes.
 612         * inf-ptrace.c: Fix common/ includes.
 613         * inf-child.c: Fix common/ includes.
 614         * ia64-linux-nat.c: Fix common/ includes.
 615         * i387-tdep.c: Fix common/ includes.
 616         * i386-tdep.c: Fix common/ includes.
 617         * i386-linux-tdep.c: Fix common/ includes.
 618         * i386-linux-nat.c: Fix common/ includes.
 619         * i386-go32-tdep.c: Fix common/ includes.
 620         * i386-fbsd-tdep.c: Fix common/ includes.
 621         * i386-fbsd-nat.c: Fix common/ includes.
 622         * guile/scm-type.c: Fix common/ includes.
 623         * guile/guile.c: Fix common/ includes.
 624         * go32-nat.c: Fix common/ includes.
 625         * gnu-nat.c: Fix common/ includes.
 626         * gdbthread.h: Fix common/ includes.
 627         * gdbarch-selftests.c: Fix common/ includes.
 628         * gdb_usleep.c: Fix common/ includes.
 629         * gdb_select.h: Fix common/ includes.
 630         * gdb_bfd.c: Fix common/ includes.
 631         * gcore.c: Fix common/ includes.
 632         * fork-child.c: Fix common/ includes.
 633         * findvar.c: Fix common/ includes.
 634         * fbsd-nat.c: Fix common/ includes.
 635         * event-top.c: Fix common/ includes.
 636         * event-loop.c: Fix common/ includes.
 637         * dwarf2read.c: Fix common/ includes.
 638         * dwarf2loc.c: Fix common/ includes.
 639         * dwarf2-frame.c: Fix common/ includes.
 640         * dwarf-index-cache.c: Fix common/ includes.
 641         * dtrace-probe.c: Fix common/ includes.
 642         * disasm-selftests.c: Fix common/ includes.
 643         * defs.h: Fix common/ includes.
 644         * csky-tdep.c: Fix common/ includes.
 645         * cp-valprint.c: Fix common/ includes.
 646         * cp-support.h: Fix common/ includes.
 647         * cp-support.c: Fix common/ includes.
 648         * corelow.c: Fix common/ includes.
 649         * completer.h: Fix common/ includes.
 650         * completer.c: Fix common/ includes.
 651         * compile/compile.c: Fix common/ includes.
 652         * compile/compile-loc2c.c: Fix common/ includes.
 653         * compile/compile-cplus-types.c: Fix common/ includes.
 654         * compile/compile-cplus-symbols.c: Fix common/ includes.
 655         * command.h: Fix common/ includes.
 656         * cli/cli-dump.c: Fix common/ includes.
 657         * cli/cli-cmds.c: Fix common/ includes.
 658         * charset.c: Fix common/ includes.
 659         * build-id.c: Fix common/ includes.
 660         * btrace.h: Fix common/ includes.
 661         * btrace.c: Fix common/ includes.
 662         * breakpoint.h: Fix common/ includes.
 663         * breakpoint.c: Fix common/ includes.
 664         * ax.h:
 665         (enum agent_op): Fix common/ includes.
 666         * ax-general.c (struct aop_map): Fix common/ includes.
 667         * ax-gdb.c: Fix common/ includes.
 668         * auxv.c: Fix common/ includes.
 669         * auto-load.c: Fix common/ includes.
 670         * arm-tdep.c: Fix common/ includes.
 671         * arch/riscv.c: Fix common/ includes.
 672         * arch/ppc-linux-common.c: Fix common/ includes.
 673         * arch/i386.c: Fix common/ includes.
 674         * arch/arm.c: Fix common/ includes.
 675         * arch/arm-linux.c: Fix common/ includes.
 676         * arch/arm-get-next-pcs.c: Fix common/ includes.
 677         * arch/amd64.c: Fix common/ includes.
 678         * arch/aarch64.c: Fix common/ includes.
 679         * arch/aarch64-insn.c: Fix common/ includes.
 680         * arch-utils.c: Fix common/ includes.
 681         * amd64-windows-tdep.c: Fix common/ includes.
 682         * amd64-tdep.c: Fix common/ includes.
 683         * amd64-sol2-tdep.c: Fix common/ includes.
 684         * amd64-obsd-tdep.c: Fix common/ includes.
 685         * amd64-nbsd-tdep.c: Fix common/ includes.
 686         * amd64-linux-tdep.c: Fix common/ includes.
 687         * amd64-linux-nat.c: Fix common/ includes.
 688         * amd64-fbsd-tdep.c: Fix common/ includes.
 689         * amd64-fbsd-nat.c: Fix common/ includes.
 690         * amd64-dicos-tdep.c: Fix common/ includes.
 691         * amd64-darwin-tdep.c: Fix common/ includes.
 692         * agent.c: Fix common/ includes.
 693         * ada-lang.h: Fix common/ includes.
 694         * ada-lang.c: Fix common/ includes.
 695         * aarch64-tdep.c: Fix common/ includes.
 696
 697 2019-01-25  Tom Tromey  <tom@tromey.com>
 698
 699         * common/create-version.sh: Use common/version.h.
 700
 701 2019-01-24  Pedro Alves  <palves@redhat.com>
 702
 703         * infrun.c (signal_stop, signal_print, signal_program)
 704         (signal_catch, signal_pass): Now arrays instead of pointers.
 705         (update_signals_program_target, do_target_resume)
 706         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
 707         * linux-nat.c (linux_nat_target::pass_signals)
 708         (linux_nat_target::create_inferior, linux_nat_target::attach):
 709         Adjust.
 710         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
 711         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
 712         * procfs.c (procfs_target::pass_signals): Adjust.
 713         * record-full.c (record_full_target::resume): Adjust.
 714         * remote.c (remote_target::pass_signals)
 715         (remote_target::program_signals): Adjust.
 716         * target-debug.h (target_debug_print_signals): Now takes a
 717         gdb::array_view as parameter.  Adjust.
 718         * target.h (target_ops) <pass_signals, program_signals>: Replace
 719         pointer and length parameters with gdb::array_view.
 720         (target_pass_signals, target_program_signals): Likewise.
 721         * target-delegates.c: Regenerate.
 722
 723 2019-01-24  Pedro Alves  <palves@redhat.com>
 724
 725         * common/forward-scope-exit.h
 726         (forward_scope_exit::forward_scope_exit): Pass arguments to
 727         m_bind_function directly, instead of creating a std::bind and
 728         copying that.
 729
 730 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
 731
 732         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 733         for static members.
 734         (pass_in_v_vfp_candidate): Likewise.
 735
 736 2019-01-23  Tom Tromey  <tom@tromey.com>
 737             Pedro Alves  <palves@redhat.com>
 738
 739         * regcache.c (class regcache_invalidator): Remove.
 740         (regcache::raw_write): Use make_scope_exit.
 741
 742 2019-01-23  Tom Tromey  <tom@tromey.com>
 743
 744         * ui-out.h (class ui_out_emit_type): Update comment.
 745
 746 2019-01-23  Tom Tromey  <tom@tromey.com>
 747
 748         * infrun.c (fetch_inferior_event): Update comment.
 749
 750 2019-01-23  Tom Tromey  <tom@tromey.com>
 751             Pedro Alves  <palves@redhat.com>
 752
 753         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
 754         parameter.
 755         (fetch_inferior_event): Use SCOPE_EXIT.
 756
 757
 758 2019-01-23  Tom Tromey  <tom@tromey.com>
 759             Pedro Alves  <palves@redhat.com>
 760
 761         * infrun.c (disable_thread_events): Delete.
 762         (stop_all_threads): Use SCOPE_EXIT.
 763
 764 2019-01-23  Tom Tromey  <tom@tromey.com>
 765             Pedro Alves  <palves@redhat.com>
 766
 767         * symfile.c: Include forward-scope-exit.h.
 768         (clear_symtab_users_cleanup): Replace forward declaration with
 769         a FORWARD_SCOPE_EXIT.
 770         (syms_from_objfile_1): Use the forward_scope_exit and
 771         gdb::optional instead of cleanup_function.
 772         (reread_symbols): Use the forward_scope_exit instead of
 773         cleanup_function.
 774         (clear_symtab_users_cleanup): Remove function.
 775
 776 2019-01-23  Tom Tromey  <tom@tromey.com>
 777             Pedro Alves  <palves@redhat.com>
 778
 779         * linux-nat.c: Include scope-exit.h.
 780         (cleanup_target_stop): Remove.
 781         (linux_nat_target::static_tracepoint_markers_by_strid): Use
 782         SCOPE_EXIT.
 783
 784 2019-01-23  Tom Tromey  <tom@tromey.com>
 785             Pedro Alves  <palves@redhat.com>
 786
 787         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
 788         (call_function_by_hand_dummy): Use SCOPE_EXIT.
 789
 790 2019-01-23  Tom Tromey  <tom@tromey.com>
 791             Andrew Burgess  <andrew.burgess@embecosm.com>
 792             Pedro Alves  <palves@redhat.com>
 793
 794         * infrun.c (fetch_inferior_event): Use scope_exit.
 795         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
 796         * top.c (execute_command): Use scope_exit.
 797         * breakpoint.c (bpstat_do_actions): Use scope_exit.
 798         * utils.c (do_bpstat_clear_actions_cleanup)
 799         (make_bpstat_clear_actions_cleanup): Remove.
 800
 801 2019-01-23  Tom Tromey  <tom@tromey.com>
 802             Pedro Alves  <palves@redhat.com>
 803
 804         * infrun.c: Include "common/scope-exit.h"
 805         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
 806         (wait_for_inferior): Use SCOPE_EXIT.
 807         (fetch_inferior_event): Use scope_exit.
 808
 809 2019-01-23  Tom Tromey  <tom@tromey.com>
 810             Pedro Alves  <palves@redhat.com>
 811
 812         * breakpoint.c (create_breakpoint): Remove cleanup.
 813
 814 2019-01-23  Tom Tromey  <tom@tromey.com>
 815             Andrew Burgess  <andrew.burgess@embecosm.com>
 816             Pedro Alves  <palves@redhat.com>
 817
 818 2019-01-23  Pedro Alves  <palves@redhat.com>
 819
 820         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
 821
 822 2019-01-23  Pedro Alves  <palves@redhat.com>
 823             Andrew Burgess  <andrew.burgess@embecosm.com>
 824
 825         * gdbthread.h: Include "common/forward-scope-exit.h".
 826         (scoped_finish_thread_state): Redefine custom class in terms of
 827         forward_scope_exit.
 828
 829 2019-01-23  Pedro Alves  <palves@redhat.com>
 830             Andrew Burgess  <andrew.burgess@embecosm.com>
 831
 832         * common/forward-scope-exit.h: New file.
 833
 834 2019-01-23  Pedro Alves  <palves@redhat.com>
 835             Andrew Burgess  <andrew.burgess@embecosm.com>
 836             Tom Tromey  <tom@tromey.com>
 837
 838         * common/scope-exit.h: New file.
 839
 840 2019-01-23  Pedro Alves  <palves@redhat.com>
 841
 842         * common/preprocessor.h (ESC): Rename to ...
 843         (ESC_PARENS): ... this.
 844         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
 845         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
 846
 847 2019-01-23  Tom Tromey  <tom@tromey.com>
 848
 849         * language.h (class scoped_switch_to_sym_language_if_auto):
 850         Initialize m_lang in both cases.
 851
 852 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
 853
 854         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
 855         with XCNEW.
 856
 857 2019-01-22  Tom Tromey  <tom@tromey.com>
 858
 859         * corelow.c: Do not include sys/file.h.
 860
 861 2019-01-22  Tom Tromey  <tom@tromey.com>
 862
 863         * tui/tui-wingeneral.h: Include gdb_curses.h.
 864
 865 2019-01-22  Tom Tromey  <tom@tromey.com>
 866
 867         * source-cache.h (class source_cache) <get_source_lines,
 868         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
 869
 870 2019-01-22  Tom Tromey  <tom@tromey.com>
 871
 872         * remote-fileio.h (struct remote_target): Declare.
 873
 874 2019-01-22  Tom Tromey  <tom@tromey.com>
 875
 876         * python/py-arch.c: Do not include py-ref.h.
 877         * python/py-bpevent.c: Do not include py-ref.h.
 878         * python/py-cmd.c: Do not include py-ref.h.
 879         * python/py-continueevent.c: Do not include py-ref.h.
 880         * python/py-event.h: Do not include py-ref.h.
 881         * python/py-evtregistry.c: Do not include py-ref.h.
 882         * python/py-finishbreakpoint.c: Do not include py-ref.h.
 883         * python/py-frame.c: Do not include py-ref.h.
 884         * python/py-framefilter.c: Do not include py-ref.h.
 885         * python/py-function.c: Do not include py-ref.h.
 886         * python/py-infevents.c: Do not include py-ref.h.
 887         * python/py-linetable.c: Do not include py-ref.h.
 888         * python/py-objfile.c: Do not include py-ref.h.
 889         * python/py-param.c: Do not include py-ref.h.
 890         * python/py-prettyprint.c: Do not include py-ref.h.
 891         * python/py-progspace.c: Do not include py-ref.h.
 892         * python/py-symbol.c: Do not include py-ref.h.
 893         * python/py-symtab.c: Do not include py-ref.h.
 894         * python/py-type.c: Do not include py-ref.h.
 895         * python/py-unwind.c: Do not include py-ref.h.
 896         * python/py-utils.c: Do not include py-ref.h.
 897         * python/py-value.c: Do not include py-ref.h.
 898         * python/py-varobj.c: Do not include py-ref.h.
 899         * python/py-xmethods.c: Do not include py-ref.h.
 900         * python/python.c: Do not include py-ref.h.
 901         * varobj.c: Do not include py-ref.h.
 902
 903 2019-01-22  Tom Tromey  <tom@tromey.com>
 904
 905         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
 906         keyword for bcache.
 907
 908 2019-01-22  Tom Tromey  <tom@tromey.com>
 909
 910         * compile/compile-cplus-types.c: Remove a comment by #include.
 911
 912 2019-01-22  Tom Tromey  <tom@tromey.com>
 913
 914         * compile/gcc-c-plugin.h: Include compile-internal.h.
 915
 916 2019-01-22  Tom Tromey  <tom@tromey.com>
 917
 918         * stabsread.c (EXTERN): Do not define.
 919         (symnum, next_symbol_text_func, processing_gcc_compilation)
 920         (within_function, global_sym_chain, global_stabs)
 921         (previous_stab_code, this_object_header_files)
 922         (n_this_object_header_files)
 923         (n_allocated_this_object_header_files): Define.
 924         * stabsread.h (EXTERN): Never define.  Use "extern".
 925
 926 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 927
 928         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
 929         history_value.
 930
 931 2019-01-21  Tom Tromey  <tom@tromey.com>
 932
 933         * ui-out.c: Fix includes.
 934         * tui/tui-source.c: Fix includes.
 935         * target.c: Fix includes.
 936         * remote.c: Fix includes.
 937         * regcache.c: Fix includes.
 938         * python/py-block.c: Fix includes.
 939         * printcmd.c: Fix includes.
 940         * or1k-tdep.c: Fix includes.
 941         * mi/mi-main.c: Fix includes.
 942         * m32r-tdep.c: Fix includes.
 943         * csky-tdep.c: Fix includes.
 944         * compile/compile-cplus-types.c: Fix includes.
 945         * cli/cli-interp.c: Fix includes.
 946
 947 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
 948
 949         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 950         for padding.
 951
 952 2019-01-16  Tom Tromey  <tom@tromey.com>
 953
 954         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
 955         earlier.
 956         (struct objfile) <msymbols_range>: Move from top level.
 957         <msymbols>: New method.
 958         (class objfile_msymbols): Remove.
 959         * symtab.c (default_collect_symbol_completion_matches_break_on):
 960         Update.
 961         * symmisc.c (dump_msymbols): Update.
 962         * stabsread.c (scan_file_globals): Update.
 963         * objc-lang.c (info_selectors_command, info_classes_command)
 964         (find_methods): Update.
 965         * minsyms.c (find_solib_trampoline_target): Update.
 966         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
 967         * coffread.c (coff_symfile_read): Update.
 968         * ada-lang.c (ada_lookup_simple_minsym)
 969         (ada_collect_symbol_completion_matches): Update.
 970
 971 2019-01-16  Tom Tromey  <tom@tromey.com>
 972
 973         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
 974         type.  Remove no-argument constructor.
 975         <iterator::operator++>: Simplify.
 976         <begin>: Update.
 977         <end>: Use minimal_symbol_count.
 978
 979 2019-01-16  Tom Tromey  <tom@tromey.com>
 980
 981         * objfiles.h (struct objfile) <psymtabs>: New method.
 982         (class objfile_psymtabs): Remove.
 983         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
 984         typedef.
 985         <range>: New method.
 986         (require_partial_symbols): Change return type.
 987         * psymtab.c (require_partial_symbols)
 988         (psym_expand_symtabs_matching): Update.
 989         * mdebugread.c (parse_partial_symbols): Update.
 990         * dbxread.c (dbx_end_psymtab): Update.
 991
 992 2019-01-15  Tom Tromey  <tom@tromey.com>
 993
 994         * symtab.c (lookup_objfile_from_block)
 995         (lookup_symbol_in_objfile_symtabs)
 996         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
 997         (find_line_symtab, info_sources_command)
 998         (default_collect_symbol_completion_matches_break_on)
 999         (make_source_files_completion_list): Update.
1000         * symmisc.c (print_objfile_statistics, dump_objfile)
1001         (maintenance_print_symbols, maintenance_info_symtabs)
1002         (maintenance_check_symtabs, maintenance_info_line_tables):
1003         Update.
1004         * source.c (select_source_symtab)
1005         (forget_cached_source_info_for_objfile): Update.
1006         * objfiles.h (class objfile_compunits): Remove.
1007         (struct objfile) <compunits_range>: New typedef.
1008         (compunits): New method.
1009         * objfiles.c (objfile_relocate1): Update.
1010         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1011         * maint.c (count_symtabs_and_blocks): Update.
1012         * linespec.c (iterate_over_all_matching_symtabs): Update.
1013         * cp-support.c (add_symbol_overload_list_qualified): Update.
1014         * coffread.c (coff_symtab_read): Update.
1015         * ada-lang.c (add_nonlocal_symbols)
1016         (ada_collect_symbol_completion_matches)
1017         (ada_add_global_exceptions): Update.
1018
1019 2019-01-15  Tom Tromey  <tom@tromey.com>
1020
1021         * progspace.h (program_space) <objfiles_safe_range>: New
1022         typedef.
1023         <objfiles_safe>: New method.
1024         * objfiles.h (class all_objfiles_safe): Remove.
1025         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1026         * jit.c (jit_inferior_exit_hook): Update.
1027
1028 2019-01-17  Tom Tromey  <tom@tromey.com>
1029
1030         * progspace.h (program_space) <objfiles_range>: New typedef.
1031         <objfiles>: New method.
1032         <objfiles_head>: Rename from objfiles.
1033         (object_files): Update.
1034         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1035         * guile/scm-pretty-print.c
1036         (ppscm_find_pretty_printer_from_objfiles): Update.
1037         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1038         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1039         Update.
1040         * python/py-progspace.c (pspy_get_objfiles): Update.
1041         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1042         Update.
1043         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1044         (objfpy_lookup_objfile_by_build_id): Update.
1045         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1046         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1047         Update.
1048         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1049         (expand_symtab_containing_pc, lookup_objfile_from_block)
1050         (lookup_static_symbol, basic_lookup_transparent_type)
1051         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1052         (find_line_symtab, info_sources_command)
1053         (default_collect_symbol_completion_matches_break_on)
1054         (make_source_files_completion_list, find_main_name): Update.
1055         * symmisc.c (print_symbol_bcache_statistics)
1056         (print_objfile_statistics, maintenance_print_symbols)
1057         (maintenance_print_msymbols, maintenance_print_objfiles)
1058         (maintenance_info_symtabs, maintenance_check_symtabs)
1059         (maintenance_expand_symtabs, maintenance_info_line_tables):
1060         Update.
1061         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1062         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1063         (map_overlay_command, unmap_overlay_command)
1064         (simple_overlay_update, expand_symtabs_matching)
1065         (map_symbol_filenames): Update.
1066         * symfile-debug.c (set_debug_symfile): Update.
1067         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1068         Update.
1069         * source.c (select_source_symtab, forget_cached_source_info):
1070         Update.
1071         * solib.c (solib_read_symbols): Update.
1072         * solib-spu.c (append_ocl_sos): Update.
1073         * psymtab.c (maintenance_print_psymbols)
1074         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1075         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1076         * printcmd.c (info_symbol_command): Update.
1077         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1078         Update.
1079         * objfiles.h (class all_objfiles): Remove.
1080         * objfiles.c (have_partial_symbols, have_full_symbols)
1081         (have_minimal_symbols, qsort_cmp, update_section_map)
1082         (shared_objfile_contains_address_p)
1083         (default_iterate_over_objfiles_in_search_order): Update.
1084         * objc-lang.c (info_selectors_command, info_classes_command)
1085         (find_methods): Update.
1086         * minsyms.c (find_solib_trampoline_target): Update.
1087         * maint.c (maintenance_info_sections)
1088         (maintenance_translate_address, count_symtabs_and_blocks):
1089         Update.
1090         * main.c (captured_main_1): Update.
1091         * linux-thread-db.c (try_thread_db_load_from_pdir)
1092         (has_libpthread): Update.
1093         * linespec.c (iterate_over_all_matching_symtabs)
1094         (search_minsyms_for_name): Update.
1095         * jit.c (jit_find_objf_with_entry_addr): Update.
1096         * hppa-tdep.c (find_unwind_entry)
1097         (hppa_lookup_stub_minimal_symbol): Update.
1098         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1099         Update.
1100         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1101         (elf_gnu_ifunc_resolve_by_got): Update.
1102         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1103         * dwarf-index-write.c (save_gdb_index_command): Update.
1104         * cp-support.c (add_symbol_overload_list_qualified): Update.
1105         * breakpoint.c (create_overlay_event_breakpoint)
1106         (create_longjmp_master_breakpoint)
1107         (create_std_terminate_master_breakpoint)
1108         (create_exception_master_breakpoint): Update.
1109         * blockframe.c (find_pc_partial_function): Update.
1110         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1111         (ada_collect_symbol_completion_matches)
1112         (ada_add_global_exceptions): Update.
1113
1114 2019-01-17  Tom Tromey  <tom@tromey.com>
1115
1116         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1117         declare VEC.
1118         (solib_target_parse_libraries): Change return type.
1119         (library_list_start_segment, library_list_start_section)
1120         (library_list_end_library, library_list_start_library); Update.
1121         (solib_target_free_library_list): Remove.
1122         (solib_target_parse_libraries): Remove cleanup.  Change return
1123         type.
1124         (solib_target_current_sos): Update.
1125
1126 2019-01-17  Tom Tromey  <tromey@bapiya>
1127
1128         * valprint.c: Replace "the the" with "the".
1129         * symtab.c: Replace "the the" with "the".
1130         * solib.c: Replace "the the" with "the".
1131         * solib-dsbt.c: Replace "the the" with "the".
1132         * linespec.c: Replace "the the" with "the".
1133         * dwarf2loc.h: Replace "the the" with "the".
1134         * amd64-windows-tdep.c: Replace "the the" with "the".
1135         * aarch64-tdep.c: Replace "the the" with "the".
1136
1137 2019-01-16  Keith Seitz  <keiths@redhat.com>
1138
1139         PR gdb/23773
1140         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1141         <builder>: Rename to ..
1142         <m_builder>: ... this and make private.
1143         (dwarf2_cu::get_builder): New method.  Change all users of
1144         `builder' to use this method.
1145         (dwarf2_start_symtab): Move to ...
1146         (dwarf2_cu::start_symtab): ... here.  Update all callers
1147         (setup_type_unit_groups): Move to ...
1148         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1149         callers.
1150         (dwarf2_cu::reset_builder): New method.
1151         (process_full_compunit, process_full_type_unit): Use
1152         dwarf2_cu::reset_builder.
1153         (follow_die_offset): Record the ancestor CU if it is different
1154         from the followed DIE's CU.
1155         (follow_die_sig_1): Likewise.
1156
1157 2019-01-15  Tom Tromey  <tom@tromey.com>
1158
1159         * remote.c (class remote_state) <buf>: Now a char_vector.
1160         <buf_size>: Remove.
1161         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1162         parameter.
1163         (remote_target::getpkt_or_notif_sane_1)
1164         (remote_target::getpkt_sane)
1165         (remote_target::getpkt_or_notif_sane): Likewise.
1166         (class remote_target) <putpkt>: New overload.
1167         (remote_target::read_frame): Change type of "buf_p".  Remove
1168         sizeof_p parameter.
1169         (packet_ok): New overload.
1170         (packet_check_result): New overload.
1171         Update all uses.
1172
1173 2019-01-14  Tom Tromey  <tom@tromey.com>
1174
1175         * remote-notif.c (handle_notification, remote_notif_ack)
1176         (remote_notif_parse): Make "buf" const.
1177         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1178         const.
1179         (remote_notif_parse, remote_notif_ack, handle_notification):
1180         Likewise.
1181         * remote.c (remote_notif_stop_parse): Make "buf" const.
1182         (remote_target::remote_parse_stop_reply): Make "buf" const.
1183         (remote_notif_stop_ack): Make "buf" const.
1184
1185 2019-01-14  Tom Tromey  <tom@tromey.com>
1186
1187         * remote.c (remote_console_output): Make parameter const.
1188
1189 2019-01-14  Tom Tromey  <tom@tromey.com>
1190
1191         * target-debug.h (target_debug_print_signals): Constify.
1192         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1193         * procfs.c (procfs_target::pass_signals): Update.
1194         * linux-nat.c (linux_nat_target::pass_signals): Update.
1195         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1196         * target-delegates.c: Rebuild.
1197         * remote.c (remote_target::program_signals): Update.
1198         (remote_target::pass_signals): Update.
1199         * target.c (target_pass_signals): Constify argument.
1200         (target_program_signals): Likewise.
1201         * target.h (struct target_ops) <pass_signals, program_signals>:
1202         Constify argument.
1203         (target_pass_signals, target_program_signals): Constify argument.
1204
1205 2019-01-14  Tom Tromey  <tom@tromey.com>
1206
1207         PR tui/28819:
1208         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1209
1210 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1211
1212         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1213         field.
1214         * rs6000-tdep.c: Include reggroups.h.
1215         (IS_V_ALIAS_PSEUDOREG): Define.
1216         (rs6000_register_name): Return names for the "vX" aliases.
1217         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1218         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1219         aliases.  Call default_register_reggroup_p for all other
1220         pseudo-registers.
1221         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1222         New functions.
1223         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1224         Handle "vX" aliases.
1225         (v_alias_pseudo_register_collect): New function.
1226         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1227         (rs6000_gdbarch_init): Initialize "vX" aliases as
1228         pseudo-registers.  Restore registration of
1229         rs6000_pseudo_register_reggroup_p with
1230         set_tdesc_pseudo_register_reggroup_p.
1231
1232 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1233
1234         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1235         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1236         set_gdbarch_num_pseudo_regs.
1237
1238 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1239
1240         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1241         Remove arg prefixname, add do_set and do_show.
1242         Add member functions set_list and show_list.
1243         * cli/cli-style.c (class cli_style_option): Update accordingly.
1244         (style_set_list): Move to file scope.
1245         (style_show_list): Likewise.
1246         (set_style): Call help_list.
1247         (show_style): Call cmd_show_list.
1248         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1249         Update to use the new macro.
1250
1251 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1252
1253         * ada-lang.c (_initialize_ada_language): Expand the help text
1254         for the "catch exception" command.
1255
1256 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1257
1258         * symtab.c (matching_obj_sections): Initialize obj,
1259         declare it closer to its usage.
1260
1261 2019-01-10  Tom Tromey  <tom@tromey.com>
1262
1263         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1264         (basic_inf_threads_range): Remove.
1265         (inf_threads_range, inf_non_exited_threads_range)
1266         (safe_inf_threads_range): Use next_adapter.
1267
1268 2019-01-10  Keith Seitz  <keiths@redhat.com>
1269
1270         PR gdb/23712
1271         PR symtab/23010
1272         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1273         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1274
1275 2019-01-10  Keith Seitz  <keiths@redhat.com>
1276
1277         PR gdb/23712
1278         PR symtab/23010
1279         * dictionary.c (pending_to_vector): Remove.
1280         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1281         Remove _1 suffix, replacing functions of the same name.  Update
1282         all callers.
1283         (dict_create_hashed, dict_create_hashed_expandable)
1284         (dict_create_linear, dict_create_linear_expandable, dict_free)
1285         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1286         Make functions static.
1287
1288 2019-01-10  Keith Seitz  <keiths@redhat.com>
1289
1290         PR gdb/23712
1291         PR symtab/23010
1292         * dictionary.h (struct dictionary): Replace declaration with
1293         multidictionary.
1294         (dict_create_hashed, dict_create_hashed_expandable)
1295         (dict_create_linear, dict_create_linear_expandable)
1296         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1297         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1298         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1299         taking multidictionary argument.
1300         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1301         * block.h (struct block) <dict>: Change to multidictionary
1302         and rename `multidict'.
1303         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1304         symmisc.c: Update all dictionary references to multidictionary.
1305
1306 2019-01-10  Keith Seitz  <keiths@redhat.com>
1307
1308         PR gdb/23712
1309         PR symtab/23010
1310         * dictionary.c: Include unordered_map.
1311         (pending_to_vector): New function.
1312         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1313         Rewrite the non-"_1" functions to take vector instead
1314         of linked list.
1315         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1316         "new" _1 versions of the same name.
1317         (multidictionary): Define.
1318         (std::hash<enum language): New definition.
1319         (collate_pending_symbols_by_language, mdict_create_hashed)
1320         (mdict_create_hashed_expandable, mdict_create_linear)
1321         (mdict_create_linear_expandable, mdict_free)
1322         (find_language_dictionary, create_new_language_dictionary)
1323         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1324         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1325         (mdict_size, mdict_empty): New functions.
1326         * dictionary.h (mdict_iterator): Define.
1327
1328 2019-01-10  Pedro Alves  <palves@redhat.com>
1329
1330         * breakpoint.c (read_uploaded_action)
1331         (create_tracepoint_from_upload): Adjust to use
1332         gdb::unique_xmalloc_ptr.
1333         * ctf.c (ctf_write_uploaded_tp):
1334         (SET_ARRAY_FIELD): Use emplace_back.
1335         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1336         * tracefile-tfile.c (tfile_write_uploaded_tp):
1337         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1338         gdb::unique_xmalloc_ptr.
1339         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1340         at_string, cond_string, cmd_strings>: Replace char pointers
1341         with gdb::unique_xmalloc_ptr.
1342
1343 2019-01-10  Pedro Alves  <palves@redhat.com>
1344
1345         * solib-target.c (library_list_start_library): Don't xstrdup name.
1346
1347 2019-01-10  Pedro Alves  <palves@redhat.com>
1348
1349         * mdebugread.c (parse_partial_symbols): Use
1350         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1351
1352 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1353
1354         * linux-fork.c (scoped_switch_fork_info)
1355         <~scoped_switch_fork_info>: Fix incorrect variable name.
1356
1357 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1358
1359         * linux-fork.c (scoped_switch_fork_info)
1360         <scoped_switch_fork_info>: Make explicit.
1361         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1362
1363 2019-01-10  Tom Tromey  <tom@tromey.com>
1364
1365         * objfiles.h (objfile::reset_psymtabs): Update.
1366         * objfiles.c (objfile::objfile): Update.
1367         * psymtab.h (psymtab_storage::obstack): Update.
1368         (psymtab_storage::m_obstack): Use gdb::optional.
1369         (class psymtab_storage): Update comment.  Remove objfile
1370         parameter.
1371         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1372
1373 2019-01-10  Tom Tromey  <tom@tromey.com>
1374
1375         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1376         <free_psymtabs>: Now private.
1377         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1378         (allocate_psymtab): Use new method.
1379
1380 2019-01-10  Tom Tromey  <tom@tromey.com>
1381
1382         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1383         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1384         * mdebugread.c (parse_partial_symbols): Use
1385         allocate_dependencies.
1386         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1387         allocate_dependencies.
1388         (process_psymtab_comp_unit_reader)
1389         (build_type_psymtab_dependencies): Likewise.
1390         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1391
1392 2019-01-10  Tom Tromey  <tom@tromey.com>
1393
1394         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1395         PSYMBOL_SET_LANGUAGE.
1396         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1397
1398 2019-01-10  Tom Tromey  <tom@tromey.com>
1399
1400         * psymtab.h (psymtab_storage::obstack): New method.
1401         <m_obstack>: Rename from obstack; now private.
1402         * psymtab.c (psymtab_storage): Update.
1403         * dwarf2read.c (create_addrmap_from_index)
1404         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1405         Update.
1406
1407 2019-01-10  Tom Tromey  <tom@tromey.com>
1408
1409         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1410         * objfiles.h (objfile::reset_psymtabs): New method.
1411
1412 2019-01-10  Tom Tromey  <tom@tromey.com>
1413
1414         * symmisc.c (print_symbol_bcache_statistics): Update.
1415         (print_objfile_statistics): Update.
1416         * symfile.c (reread_symbols): Update.
1417         * psymtab.h (class psymtab_storage): New.
1418         * psymtab.c (psymtab_storage): New constructor.
1419         (~psymtab_storage): New destructor.
1420         (require_partial_symbols): Update.
1421         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1422         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1423         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1424         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1425         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1426         (start_psymtab_common, end_psymtab_common)
1427         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1428         (allocate_psymtab): Update.
1429         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1430         Update.
1431         (dump_psymtab_addrmap, maintenance_print_psymbols)
1432         (maintenance_check_psymtabs): Update.
1433         (class objfile_psymtabs): Move to objfiles.h.
1434         * psympriv.h (discard_psymtab): Now inline.
1435         (psymtab_discarder::psymtab_discarder): Update.
1436         (psymtab_discarder::~psymtab_discarder): Update.
1437         (ALL_OBJFILE_PSYMTABS): Rewrite.
1438         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1439         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1440         Remove fields.
1441         <partial_symtabs>: New field.
1442         (class objfile_psymtabs): Move from psymtab.h.  Update.
1443         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1444         psymbol_cache.
1445         (objfile::~objfile): Don't destroy psymbol_cache.
1446         * mdebugread.c (parse_partial_symbols): Update.
1447         * dwarf2read.c (create_addrmap_from_index)
1448         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1449         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1450         (add_partial_subprogram, dwarf2_ranges_read): Update.
1451         * dwarf-index-write.c (write_address_map)
1452         (write_one_signatured_type, recursively_write_psymbols)
1453         (class debug_names, class debug_names, write_psymtabs_to_index):
1454         Update.
1455
1456 2019-01-10  Tom Tromey  <tom@tromey.com>
1457
1458         * symtab.h (SYMBOL_SET_NAMES): Update.
1459         (symbol_set_names): Update.
1460         (MSYMBOL_SET_NAMES): Update.
1461         * symtab.c (symbol_set_names): Change argument to be an
1462         objfile_per_bfd_storage.
1463         * psymtab.c (add_psymbol_to_bcache): Update.
1464         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1465
1466 2019-01-10  Tom Tromey  <tom@tromey.com>
1467
1468         * symtab.c (create_demangled_names_hash): Change argument to be an
1469         objfile_per_bfd_storage.
1470         (symbol_set_names): Update.
1471
1472 2019-01-10  Tom Tromey  <tom@tromey.com>
1473
1474         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1475         init_psymbol_list.
1476         * psymtab.c (init_psymbol_list): Do nothing if already called.
1477         * psympriv.h (init_psymbol_list): Add comment.
1478         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1479         init_psymbol_list.
1480         * dbxread.c (dbx_symfile_read): Unconditionally call
1481         init_psymbol_list.
1482
1483 2019-01-10  Tom Tromey  <tom@tromey.com>
1484
1485         * xcoffread.c (scan_xcoff_symtab): Update.
1486         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1487         "where".
1488         * mdebugread.c (parse_partial_symbols)
1489         (handle_psymbol_enumerators): Update.
1490         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1491         * dbxread.c (read_dbx_symtab): Update.
1492         * psympriv.h (psymbol_placement): New enum.
1493         (add_psymbol_to_list): Update.
1494
1495 2019-01-10  Tom Tromey  <tom@tromey.com>
1496
1497         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1498         static_psymbols parameters.
1499         (scan_xcoff_symtab): Update.
1500         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1501         static_psymbols parameters.
1502         * psympriv.h (start_psymtab_common): Update.
1503         * mdebugread.c (parse_partial_symbols): Update.
1504         * dwarf2read.c (create_partial_symtab): Update.
1505         * dbxread.c (read_dbx_symtab): Update.
1506         (start_psymtab): Remove global_psymbols and static_psymbols
1507         parameters.
1508
1509 2019-01-10  Tom Tromey  <tom@tromey.com>
1510
1511         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1512         * psymtab.c (allocate_psymtab): Add comment.
1513         * psympriv.h (allocate_psymtab): Add comment.
1514         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1515         initializations.
1516         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1517
1518 2019-01-10  Tom Tromey  <tom@tromey.com>
1519
1520         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1521         Don't declare.
1522         * mipsread.c: Include mdebugread.h.
1523         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1524         Declare.
1525         * elfread.c: Include mdebugread.h.
1526
1527 2019-01-09  Tom Tromey  <tom@tromey.com>
1528
1529         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1530         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1531         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1532         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1533         (psym_lookup_symbol, psym_find_last_source_symtab)
1534         (psym_forget_cached_source_info, psym_print_stats)
1535         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1536         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1537         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1538         (psym_find_compunit_symtab_by_address)
1539         (maintenance_print_psymbols, maintenance_info_psymtabs)
1540         (maintenance_check_psymtabs): Use ranged for.
1541         * psymtab.h (class objfile_psymtabs): New.
1542         (require_partial_symbols): Return objfile_psymtabs.
1543         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1544
1545 2019-01-09  Tom Tromey  <tom@tromey.com>
1546
1547         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1548         (find_pc_mapped_section, list_overlays_command)
1549         (map_overlay_command, unmap_overlay_command)
1550         (simple_overlay_update): Use all_objfiles.
1551         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1552         * printcmd.c (info_symbol_command): Use all_objfiles.
1553         * objfiles.h (ALL_OBJSECTIONS): Remove.
1554         * maint.c (maintenance_translate_address): Use all_objfiles.
1555         * gcore.c (gcore_create_callback): Use all_objfiles.
1556         (objfile_find_memory_regions): Likewise.
1557
1558 2019-01-09  Tom Tromey  <tom@tromey.com>
1559
1560         * symtab.c (find_line_symtab, info_sources_command)
1561         (make_source_files_completion_list): Use objfile_compunits.
1562         * source.c (select_source_symtab): Use objfile_compunits.
1563         * objfiles.h (struct objfile): Update comment.
1564         (ALL_OBJFILES): Remove.
1565         (ALL_FILETABS): Remove.
1566         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1567         objfile_compunits.
1568
1569 2019-01-09  Tom Tromey  <tom@tromey.com>
1570
1571         * symmisc.c (print_objfile_statistics, dump_objfile)
1572         (maintenance_print_symbols): Use compunit_filetabs.
1573         * source.c (forget_cached_source_info_for_objfile): Use
1574         compunit_filetabs.
1575         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1576         (ALL_FILETABS): Use compunit_filetabs.
1577         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1578         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1579
1580 2019-01-09  Tom Tromey  <tom@tromey.com>
1581
1582         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1583         (compunit_filetabs): New.
1584         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1585         compunit_filetabs.
1586         (info_sources_command, make_source_files_completion_list): Remove
1587         declaration.
1588         * symmisc.c (print_objfile_statistics, dump_objfile)
1589         (maintenance_print_symbols): Remove declaration.
1590         (maintenance_info_symtabs): Use compunit_filetabs.
1591         (maintenance_info_line_tables): Likewise.
1592         * source.c (select_source_symtab): Change local variable name.
1593         (forget_cached_source_info_for_objfile): Remove declaration.
1594         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1595         * objfiles.c (objfile_relocate1): Remove declaration.
1596         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1597         declaration.
1598         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1599         * coffread.c (coff_symtab_read): Remove declaration.
1600         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1601         compunit_filetabs.
1602
1603 2019-01-09  Tom Tromey  <tom@tromey.com>
1604
1605         * symtab.c (lookup_objfile_from_block)
1606         (find_pc_sect_compunit_symtab, search_symbols)
1607         (default_collect_symbol_completion_matches_break_on): Use
1608         objfile_compunits.
1609         * objfiles.h (ALL_COMPUNITS): Remove.
1610         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1611         * cp-support.c (add_symbol_overload_list_qualified): Use
1612         objfile_compunits.
1613         * ada-lang.c (ada_collect_symbol_completion_matches)
1614         (ada_add_global_exceptions): Use objfile_compunits.
1615
1616 2019-01-09  Tom Tromey  <tom@tromey.com>
1617
1618         * source.c (select_source_symtab)
1619         (forget_cached_source_info_for_objfile): Remove declaration.
1620         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1621         declaration.
1622         * maint.c (count_symtabs_and_blocks): Remove declaration.
1623         * cp-support.c (add_symbol_overload_list_qualified): Remove
1624         declaration.
1625         * coffread.c (coff_symtab_read): Remove declaration.
1626         * symtab.c (lookup_symbol_in_objfile_symtabs)
1627         (basic_lookup_transparent_type_1): Use objfile_compunits.
1628         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
1629         (info_sources_command, search_symbols)
1630         (default_collect_symbol_completion_matches_break_on)
1631         (make_source_files_completion_list): Remove declaration.
1632         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
1633         (ada_collect_symbol_completion_matches)
1634         (ada_add_global_exceptions): Remove declaration.
1635         * linespec.c (iterate_over_all_matching_symtabs): Use
1636         objfile_compunits.
1637         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
1638         (class objfile_compunits): New.
1639         (ALL_COMPUNITS): Use objfile_compunits.
1640         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
1641         (maintenance_check_symtabs, maintenance_info_line_tables): Use
1642         objfile_compunits.
1643         * objfiles.c (objfile_relocate1): Use objfile_compunits.
1644
1645 2019-01-09  Tom Tromey  <tom@tromey.com>
1646
1647         * symtab.c (search_symbols)
1648         (default_collect_symbol_completion_matches_break_on): Use
1649         objfile_msymbols.
1650         * ada-lang.c (ada_lookup_simple_minsym)
1651         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
1652         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
1653         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
1654         objfile_msymbols.
1655         * coffread.c (coff_symfile_read): Use objfile_msymbols.
1656         * symmisc.c (dump_msymbols): Use objfile_msymbols.
1657         * objc-lang.c (find_methods): Use objfile_msymbols.
1658         (info_selectors_command, info_classes_command): Likewise.
1659         * stabsread.c (scan_file_globals): Use objfile_msymbols.
1660         * objfiles.h (class objfile_msymbols): New.
1661         (ALL_OBJFILE_MSYMBOLS): Remove.
1662         (ALL_MSYMBOLS): Remove.
1663
1664 2019-01-09  Tom Tromey  <tom@tromey.com>
1665
1666         * common/next-iterator.h (next_adapter): Add Iterator template
1667         parameter.
1668         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
1669         (class all_objfiles_safe): New.
1670         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
1671         * objfiles.c (put_objfile_before): Update comment.
1672         (add_separate_debug_objfile): Likewise.
1673         (free_all_objfiles): Use all_objfiles_safe.
1674         (objfile_purge_solibs): Likewise.
1675
1676 2019-01-09  Tom Tromey  <tom@tromey.com>
1677
1678         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1679         (expand_symtab_containing_pc, lookup_static_symbol)
1680         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
1681         (find_symbol_at_address, find_line_symtab, find_main_name): Use
1682         all_objfiles.
1683         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
1684         * breakpoint.c (create_overlay_event_breakpoint)
1685         (create_longjmp_master_breakpoint)
1686         (create_std_terminate_master_breakpoint)
1687         (create_exception_master_breakpoint): Use all_objfiles.
1688         * linux-thread-db.c (try_thread_db_load_from_pdir)
1689         (has_libpthread): Use all_objfiles.
1690         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
1691         * linespec.c (iterate_over_all_matching_symtabs)
1692         (search_minsyms_for_name): Use all_objfiles.
1693         * maint.c (maintenance_info_sections): Use all_objfiles.
1694         * main.c (captured_main_1): Use all_objfiles.
1695         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
1696         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
1697         * guile/scm-pretty-print.c
1698         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
1699         * solib-spu.c (append_ocl_sos): Use all_objfiles.
1700         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
1701         (maintenance_print_msymbols): Use all_objfiles.
1702         * source.c (select_source_symtab): Use all_objfiles.
1703         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
1704         * symfile.c (remove_symbol_file_command)
1705         (expand_symtabs_matching, map_symbol_filenames): Use
1706         all_objfiles.
1707         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
1708         all_objfiles.
1709         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
1710         * objc-lang.c (find_methods): Use all_objfiles.
1711         * objfiles.c (have_partial_symbols, have_full_symbols)
1712         (have_minimal_symbols, qsort_cmp)
1713         (default_iterate_over_objfiles_in_search_order): Use
1714         all_objfiles.
1715         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
1716         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
1717         (maintenance_check_psymtabs): Use all_objfiles.
1718         (ALL_PSYMTABS): Remove.
1719         * compile/compile-object-run.c (do_module_cleanup): Use
1720         all_objfiles.
1721         * blockframe.c (find_pc_partial_function): Use all_objfiles.
1722         * cp-support.c (add_symbol_overload_list_qualified): Use
1723         all_objfiles.
1724         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1725         Use all_objfiles.
1726         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
1727         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
1728         all_objfiles.
1729         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1730         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
1731         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1732         Uses all_objfiles.
1733         * solib.c (solib_read_symbols): Use all_objfiles
1734
1735 2019-01-09  Tom Tromey  <tom@tromey.com>
1736
1737         * probe.c (parse_probes_in_pspace): Use all_objfiles.
1738         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
1739         all_objfiles.
1740         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
1741         * symmisc.c (print_symbol_bcache_statistics)
1742         (print_objfile_statistics, maintenance_print_objfiles)
1743         (maintenance_info_symtabs, maintenance_check_symtabs)
1744         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
1745         all_objfiles.
1746         * source.c (forget_cached_source_info): Use all_objfiles.
1747         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
1748         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1749         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
1750         * objfiles.c (update_section_map): Use all_objfiles.
1751         (shared_objfile_contains_address_p): Likewise.
1752         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
1753         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
1754
1755 2019-01-09  Tom Tromey  <tom@tromey.com>
1756
1757         * common/next-iterator.h: New file.
1758         * objfiles.h (class all_objfiles): New.
1759         (struct objfile_iterator): New.
1760
1761 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1762
1763         * NEWS: Move the description of the changed "frame", "select-frame",
1764          and "info frame" commands to the Changed commands section.
1765
1766 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
1767
1768         * gdbtypes.c (check_stub_method_group): Remove handling of old
1769         mangling schemes.
1770         * linespec.c (find_methods): Likewise.
1771         * stabsread.c (read_member_functions): Likewise.
1772         * valops.c (search_struct_method): Likewise.
1773         (value_struct_elt_for_reference): Likewise.
1774         * NEWS: Mention this change.
1775
1776 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1777
1778         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
1779         print_source_lines.
1780         * source.c (print_source_lines_base): Update line number check.
1781         (print_source_lines): New function.
1782         (source_lines_range::source_lines_range): New function.
1783         * source.h (class source_lines_range): New class.
1784         (print_source_lines): New declaration.
1785
1786 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1787
1788         * linespec.c (linespec_state_destructor): Free self->canonical_names.
1789
1790 2019-01-08  Tom Tromey  <tom@tromey.com>
1791             Simon Marchi  <simon.marchi@ericsson.com>
1792
1793         PR gdb/24060
1794         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
1795         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
1796         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1797         * f-exp.y (DOLLAR_VARIABLE): Likewise.
1798         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
1799         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1800
1801 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1802
1803         * source.c (select_source_symtab): Move header comment to
1804         declaration in source.h.
1805         (forget_cached_source_info_for_objfile): Likewise.
1806         (forget_cached_source_info): Likewise.
1807         (identify_source_line): Likewise.
1808         * source.h (identify_source_line): Move declaration from symtab.h
1809         and add comment from source.c
1810         (print_source_lines): Likewise.
1811         (forget_cached_source_info_for_objfile): Likewise.
1812         (forget_cached_source_info): Likewise.
1813         (select_source_symtab): Likewise.
1814         (enum print_source_lines_flag): Move definition from symtab.h.
1815         * symtab.h (identify_source_line): Move declaration to source.h.
1816         (print_source_lines): Likewise.
1817         (forget_cached_source_info_for_objfile): Likewise.
1818         (forget_cached_source_info): Likewise.
1819         (select_source_symtab): Likewise.
1820         (enum print_source_lines_flag): Move definition to source.h.
1821         * tui/tui-hooks.c: Add 'source.h' include.
1822
1823 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1824
1825         * source.c (print_source_lines_base): Handle requests to print
1826         reverse line number sequences, and guard against empty lines
1827         string.
1828
1829 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1830
1831         * source.c (print_source_lines_base): Fix skip of '\r' if next
1832         character is '\n'.
1833
1834 2019-01-06  Tom Tromey  <tom@tromey.com>
1835
1836         * c-exp.y (struct c_parse_state) <macro_original_text,
1837         expansion_obstack>: New member.
1838         (macro_original_text, expansion_obstack): Remove globals.
1839         (scan_macro_expansion, scanning_macro_expansion)
1840         (finished_macro_expansion): Update.
1841         (scan_macro_cleanup): Remove.
1842         (yylex, c_parse): Update.
1843
1844 2019-01-06  Tom Tromey  <tom@tromey.com>
1845
1846         * c-exp.y (struct c_parse_state) <strings>: New member.
1847         (operator_stoken): Update.
1848
1849 2019-01-06  Tom Tromey  <tom@tromey.com>
1850
1851         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
1852         (union type_stack_elt) <typelist_val>: Now a pointer to
1853         std::vector.
1854         (type_stack_cleanup): Don't declare.
1855         (push_typelist): Update.
1856         * parse.c (pop_typelist): Return a std::vector.
1857         (push_typelist): Take a std::vector.
1858         (follow_types): Update.  Do not free args.
1859         (type_stack_cleanup): Remove.
1860         * c-exp.y (struct c_parse_state): New.
1861         (cpstate): New global.
1862         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
1863         (nonempty_typelist): Update.
1864         (func_mod): Create a new vector.
1865         (c_parse): Create a c_parse_state.
1866         (check_parameter_typelist): Do not delete params.
1867         (function_method): Update.  Do not delete type_list.
1868
1869 2019-01-06  Tom Tromey  <tom@tromey.com>
1870
1871         PR gdb/28155:
1872         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
1873         check_typedef.
1874         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
1875         (print_return_value): Likewise.
1876
1877 2019-01-05  Tom Tromey  <tom@tromey.com>
1878
1879         * contrib/cleanup_check.py: Remove.
1880         * contrib/gcc-with-excheck: Remove.
1881         * contrib/exsummary.py: Remove.
1882         * contrib/excheck.py: Remove.
1883
1884 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
1885
1886         * thread.c (delete_thread_1): Add gdb_assert that THR is not
1887         NULL. Initialize tpprev to NULL instead of assigning it
1888         to NULL on the next statement.
1889         * windows-nat.c (windows_delete_thread): Remove check for
1890         main_thread_id before printing thread exit notifications.
1891         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
1892         Remove thread ID check against main_thread_id.
1893         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
1894         windows_delete_thread.
1895         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
1896
1897 2019-01-04  Tom Tromey  <tom@tromey.com>
1898
1899         * compile/compile.c (_initialize_compile): Use upper case for
1900         metasyntactic variables.
1901         * symmisc.c (_initialize_symmisc): Use upper case for
1902         metasyntactic variables.
1903         * psymtab.c (_initialize_psymtab): Use upper case for
1904         metasyntactic variables.
1905         * demangle.c (demangle_command): Use upper case for metasyntactic
1906         variables.
1907         (_initialize_demangler): Likewise.
1908         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
1909         variables.
1910
1911 2019-01-03  Tom Tromey  <tom@tromey.com>
1912
1913         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
1914
1915 2019-01-03  Tom Tromey  <tom@tromey.com>
1916
1917         * python/py-symtab.c (salpy_str): Update.
1918         (struct salpy_sal_object) <symtab>: Now a PyObject.
1919         (salpy_dealloc): Update.
1920         (del_objfile_sal): Use gdbpy_ref.
1921
1922 2019-01-03  Tom Tromey  <tom@tromey.com>
1923
1924         * python/py-type.c (convert_field): Use new_reference.  Return
1925         gdbpy_ref.
1926         (make_fielditem): Return gdbpy_ref.
1927         (typy_fields): Update.
1928         (typy_getitem): Update.
1929         (field_name): Return gdbpy_ref.  Use new_reference.
1930         (typy_iterator_iternext): Update.
1931
1932 2019-01-03  Tom Tromey  <tom@tromey.com>
1933
1934         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
1935
1936 2019-01-03  Tom Tromey  <tom@tromey.com>
1937
1938         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
1939         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
1940         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
1941         (pspy_set_frame_filters, pspy_set_frame_unwinders)
1942         (pspy_set_type_printers): Likewise.
1943         * python/py-function.c (fnpy_init): Use gdbpy_ref.
1944         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
1945         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
1946         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
1947         (objfpy_set_type_printers): Likewise.
1948
1949 2019-01-03  Tom Tromey  <tom@tromey.com>
1950
1951         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
1952         (gdbpy_print_stack): Use gdbpy_err_fetch.
1953         * python/python-internal.h (class gdbpy_err_fetch): New class.
1954         (class gdbpy_enter) <m_error_type, m_error_value,
1955         m_error_traceback>: Remove.
1956         <m_error>: New member.
1957         (gdbpy_exception_to_string): Don't declare.
1958         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
1959         * python/py-value.c (convert_value_from_python): Use
1960         gdbpy_err_fetch.
1961         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
1962         gdbpy_exception_to_string.
1963         (gdbpy_handle_exception): Use gdbpy_err_fetch.
1964         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1965         gdbpy_err_fetch.
1966
1967 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1968
1969         * linux-nat.c (delete_lwp_cleanup): Delete.
1970         (struct lwp_deleter): New struct.
1971         (lwp_info_up): New typedef.
1972         (linux_nat_target::follow_fork): Delete cleanup, and make use of
1973         lwp_info_up.
1974
1975 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1976
1977         * linux-fork.c (class scoped_switch_fork_info): New class.
1978         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
1979
1980 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1981
1982         * valops.c (find_overload_match): Remove use of null_cleanup, and
1983         calls to do_cleanups.
1984
1985 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1986
1987         * compile/compile-cplus-types.c
1988         (compile_cplus_instance::decl_name): Handle changes to
1989         cp_func_name.
1990         * cp-support.c (cp_func_name): Update header comment, update
1991         return type.
1992         * cp-support.h (cp_func_name): Update return type in declaration.
1993         * valops.c (find_overload_match): Move temp_func local to top
1994         level of function and change its type.  Use temp_func to hold and
1995         delete temporary string obtained from cp_func_name.
1996
1997 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1998
1999         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2000         gdb::char_vector, remove cleanup, and update uses of `msg`.
2001
2002 2019-01-03  Jim Wilson  <jimw@sifive.com>
2003
2004         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2005
2006 2019-01-02  Tom Tromey  <tom@tromey.com>
2007
2008         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2009         (tdesc_parse_xml): Remove cleanups.
2010         * target-descriptions.h (make_cleanup_free_target_description):
2011         Don't declare.
2012         (target_desc_deleter): New struct.
2013         (target_desc_up): New typedef.
2014         * target-descriptions.c (target_desc_deleter::operator()): Rename
2015         from free_target_description.
2016         (make_cleanup_free_target_description): Remove.
2017
2018 2019-01-02  Tom Tromey  <tom@tromey.com>
2019
2020         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2021         constructor, destructor.
2022         (linespec_parser): Remove typedef.
2023         (~linespec_parser): Rename from linespec_parser_delete.
2024         (linespec_lex_to_end, linespec_complete_label)
2025         (linespec_complete): Update.
2026         (decode_line_full): Remove cleanups.
2027         (decode_line_1): Update.
2028
2029 2019-01-02  Tom Tromey  <tom@tromey.com>
2030
2031         * python/python-internal.h (inferior_to_inferior_object): Change
2032         return type.
2033         * python/py-exitedevent.c (create_exited_event_object): Update.
2034         * python/py-inferior.c (inferior_to_inferior_object): Return
2035         gdbpy_ref.
2036         (python_new_inferior, python_inferior_deleted)
2037         (thread_to_thread_object, delete_thread_object)
2038         (build_inferior_list, gdbpy_selected_inferior): Update.
2039         * python/py-infthread.c (create_thread_object): Update.  Also fail
2040         if inferior_to_inferior_object fails.
2041
2042 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2043
2044         * inferior.h (class inferior) <displaced_step_state>: New field.
2045         * infrun.h (struct displaced_step_state): Move here from
2046         infrun.c.  Initialize fields, add constructor.
2047         <inf>: Remove field.
2048         <reset>: New method.
2049         * infrun.c (struct displaced_step_inferior_state): Move to
2050         infrun.h.
2051         (displaced_step_inferior_states): Remove.
2052         (get_displaced_stepping_state): Adust.
2053         (displaced_step_in_progress_any_inferior): Adjust.
2054         (displaced_step_in_progress_thread): Adjust.
2055         (displaced_step_in_progress): Adjust.
2056         (add_displaced_stepping_state): Remove.
2057         (get_displaced_step_closure_by_addr): Adjust.
2058         (remove_displaced_stepping_state): Remove.
2059         (infrun_inferior_exit): Call displaced_step_state.reset.
2060         (use_displaced_stepping): Don't check for NULL.
2061         (displaced_step_prepare_throw): Call
2062         get_displaced_stepping_state.
2063         (displaced_step_fixup): Don't check for NULL.
2064         (prepare_for_detach): Don't check for NULL.
2065
2066 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2067
2068         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2069          in case of call that did not complete.
2070
2071 2019-01-02  Andrey Utkin  <autkin@undo.io>
2072
2073         * symfile.c (find_separate_debug_file): Fix search of debug files for
2074         remote debuggee.
2075
2076 2019-01-02  Tom Tromey  <tom@tromey.com>
2077
2078         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2079         indentation.
2080         * python/py-frame.c (frapy_older): Remove cast.
2081         (frapy_newer): Likewise.
2082         * python/py-breakpoint.c (local_setattro): Remove cast.
2083         * python/py-arch.c (archpy_name): Remove local variable.
2084         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2085
2086 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2087
2088         * unittests/basic_string_view/element_access/char/empty.cc:
2089         Fix year range in copyright header.
2090
2091 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2092
2093         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2094         Delete.
2095         <operator==>: Update with for removed field.
2096         <hash>: Likewise.
2097         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2098         <isa_features>: ...this.
2099         <abi_features>: New field.
2100         (riscv_isa_flen): Update comment.
2101         (riscv_abi_xlen): New declaration.
2102         (riscv_abi_flen): New declaration.
2103         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2104         isa_features.
2105         (riscv_abi_xlen): New function.
2106         (riscv_isa_flen): Update to get answer from isa_features.
2107         (riscv_abi_flen): New function.
2108         (riscv_has_fp_abi): Update to get answer from abi_features.
2109         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2110         xlen and flen.
2111         (riscv_call_info) <xlen, flen>: Update comment.
2112         (riscv_call_arg_struct): Remove invalid assertions
2113         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2114         is removed.
2115         (riscv_gdbarch_init): Gather isa features and abi features
2116         separately, ensure both match on the gdbarch when reusing an old
2117         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2118         a target with 64-bit float hardware.
2119
2120 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2121
2122         * source.c (search_command_helper): Stop reverse search
2123         when line 1 has been searched.
2124
2125 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2126
2127         * record-full.c (record_full_base_target::close): Rewrite
2128         record_full_core_buf_list free logic.
2129
2130 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2131
2132         * break-catch-syscall.c (print_one_catch_syscall): xfree
2133         the last text.
2134
2135 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2136
2137         * top.c (print_gdb_version): Update Copyright year in version
2138         message.
2139
2140 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2141
2142         Update copyright year range in all GDB files.
2143
2144 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2145
2146         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2147
2148 For older changes see ChangeLog-2018.
2149 \f
2150 Local Variables:
2151 mode: change-log
2152 left-margin: 8
2153 fill-column: 74
2154 version-control: never
2155 coding: utf-8
2156 End:
2157