gdb/ChangeLog

   1 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
   2
   3         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
   4         * version.in: Bump version to 8.2.90.DATE-git.
   5
   6 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
   7
   8         * aix-thread.c (ptid_cmp): Remove unused variable.
   9         (get_signaled_thread): Likewise.
  10         (store_regs_user_thread): Likewise.
  11         (store_regs_kernel_thread): Likewise.
  12         (fetch_regs_kernel_thread): Remove shadowed variable.
  13
  14 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
  15
  16         * features/riscv/32bit-cpu.xml: Add register numbers.
  17         * features/riscv/32bit-fpu.c: Regenerate.
  18         * features/riscv/32bit-fpu.xml: Add register numbers.
  19         * features/riscv/64bit-cpu.xml: Add register numbers.
  20         * features/riscv/64bit-fpu.c: Regenerate.
  21         * features/riscv/64bit-fpu.xml: Add register numbers.
  22
  23 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
  24
  25         * NEWS: Mention two argument form of gdb.Value constructor.
  26         * python/py-value.c (convert_buffer_and_type_to_value): New
  27         function.
  28         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
  29         Add support for handling an optional second argument.  Call
  30         convert_buffer_and_type_to_value as appropriate.
  31         * python/python-internal.h (Py_buffer_deleter): New struct.
  32         (Py_buffer_up): New typedef.
  33
  34 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
  35
  36         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
  37         instead of releasing ownership.
  38
  39 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
  40
  41         * dwarf2read.c (open_and_init_dwp_file): Call
  42         elf_numsections instead of bfd_count_sections to initialize
  43         dwp_file->num_sections.
  44
  45 2019-02-25  Tom Tromey  <tromey@adacore.com>
  46
  47         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
  48
  49 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
  50
  51         * gcore.in: Add '--readnever' option when invoking GDB.
  52
  53 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
  54
  55         * MAINTAINERS: Update my email address.
  56
  57 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
  58
  59         * build-id.c (build_id_to_debug_bfd_1): New function.
  60         (build_id_to_debug_bfd): Look for separate debug file in
  61         sysroot.
  62
  63 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
  64
  65         * gdbarch.sh: Update the copyright year range that is placed into
  66         generated files.
  67
  68 2019-02-22  Keith Seitz  <keiths@redhat.com>
  69
  70         PR symtab/23853
  71         * linespec.c (create_sals_line_offset): Search for the default
  72         symtab's filename instead of its fullname.
  73
  74 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
  75
  76         * NEWS: Update style defaults.
  77
  78 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
  79
  80         * main.c (captured_main_1): Disable styling in batch mode.
  81
  82 2019-02-20  Tom Tromey  <tom@tromey.com>
  83
  84         * symtab.c (symtab_symbol_info): Fix typos.
  85
  86 2019-02-20  Tom Tromey  <tromey@adacore.com>
  87
  88         * findcmd.c (_initialize_mem_search): Use upper case for
  89         metasyntactic variables.
  90
  91 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
  92
  93         * aarch64-tdep.c (aarch64_add_reggroups): New function.
  94         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
  95
  96 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
  97
  98         * top.h (source_file_name): Change to std::string.
  99         * top.c (source_file_name): Likewise.
 100         (command_line_input): Adjust.
 101         * cli/cli-script.c (script_from_file): Adjust.
 102
 103 2019-02-19  Tom Tromey  <tromey@adacore.com>
 104
 105         * ravenscar-thread.c
 106         (ravenscar_thread_target::update_thread_list): Don't call
 107         ada_build_task_list.
 108         * ada-lang.h (ada_build_task_list): Don't declare.
 109         * ada-tasks.c (struct ada_tasks_inferior_data)
 110         <task_list_valid_p>: Now bool.
 111         (read_known_tasks, ada_task_list_changed)
 112         (ada_tasks_invalidate_inferior_data): Update.
 113         (read_known_tasks_array): Return bool.
 114         (read_known_tasks_list): Likewise.
 115         (read_known_tasks): Return void.
 116         (ada_build_task_list): Now static.
 117
 118 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 119
 120         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
 121         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
 122
 123 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 124
 125         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
 126         variant for ada_tasks_pspace_data_handle and
 127         ada_tasks_inferior_data_handle.
 128         (ada_tasks_pspace_data_cleanup): New function.
 129         (ada_tasks_inferior_data_cleanup): New function.
 130
 131 2019-02-17  Tom Tromey  <tom@tromey.com>
 132
 133         * macrotab.h (macro_source_fullname): Return a std::string.
 134         * macrotab.c (macro_include, check_for_redefinition)
 135         (macro_undef, macro_lookup_definition, foreach_macro)
 136         (foreach_macro_in_scope): Update.
 137         (macro_source_fullname): Return a std::string.
 138         * macrocmd.c (show_pp_source_pos): Update.
 139
 140 2019-02-17  Tom Tromey  <tom@tromey.com>
 141
 142         * macrocmd.c (show_pp_source_pos): Style the file names.
 143
 144 2019-02-17  Tom Tromey  <tom@tromey.com>
 145
 146         PR tui/24197:
 147         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
 148
 149 2019-02-17  Tom Tromey  <tom@tromey.com>
 150
 151         * ada-lang.c (user_select_syms): Use filtered printing.
 152         * utils.c (wrap_style): New global.
 153         (desired_style): Remove.
 154         (emit_style_escape): Add stream parameter.
 155         (set_output_style, reset_terminal_style, prompt_for_continue):
 156         Update.
 157         (flush_wrap_buffer): Only flush gdb_stdout.
 158         (wrap_here): Set wrap_style.
 159         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
 160         treat escape sequences as a character.  Change when wrap buffer is
 161         flushed.
 162         (fputs_styled): Do not set the output style when the default is
 163         requested.
 164         * ui-style.h (struct ui_file_style) <is_default>: New method.
 165         * source.c (print_source_lines_base): Emit escape sequences in one
 166         piece.
 167
 168 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 169
 170         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
 171         integers and enumeration types.
 172
 173 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 174
 175         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
 176         instead of lookup_symbol_in_language
 177         (do_exact_match): New function.
 178         (ada_get_symbol_name_matcher): Return do_exact_match when
 179         doing a verbatim match.
 180
 181 2019-02-15  Tom Tromey  <tromey@adacore.com>
 182
 183         * ravenscar-thread.c (ravenscar_thread_target::resume)
 184         (ravenscar_thread_target::wait): Special case wildcard requests.
 185
 186 2019-02-15  Tom Tromey  <tromey@adacore.com>
 187
 188         * ravenscar-thread.c (base_ptid): Remove.
 189         (struct ravenscar_thread_target) <close>: New method.
 190         <m_base_ptid>: New member.
 191         <update_inferior_ptid, active_task, task_is_currently_active,
 192         runtime_initialized>: Declare methods.
 193         <ravenscar_thread_target>: Add constructor.
 194         (ravenscar_thread_target::task_is_currently_active)
 195         (ravenscar_thread_target::update_inferior_ptid)
 196         (ravenscar_runtime_initialized): Rename.  Now methods.
 197         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
 198         (ravenscar_thread_target::update_thread_list): Update.
 199         (ravenscar_thread_target::active_task): Now method.
 200         (ravenscar_thread_target::store_registers)
 201         (ravenscar_thread_target::prepare_to_store)
 202         (ravenscar_thread_target::prepare_to_store)
 203         (ravenscar_thread_target::mourn_inferior): Update.
 204         (ravenscar_inferior_created): Use "new" to create target.
 205         (ravenscar_thread_target::get_ada_task_ptid): Update.
 206         (_initialize_ravenscar): Don't initialize base_ptid.
 207         (ravenscar_ops): Remove global.
 208
 209 2019-02-15  Tom Tromey  <tromey@adacore.com>
 210
 211         * target.h (push_target): Declare new overload.
 212         * target.c (push_target): New overload, taking an rvalue reference.
 213         * remote.c (remote_target::open_1): Use push_target overload.
 214         * corelow.c (core_target_open): Use push_target overload.
 215
 216 2019-02-15  Tom Tromey  <tromey@adacore.com>
 217
 218         * ravenscar-thread.c (is_ravenscar_task)
 219         (ravenscar_task_is_currently_active): Return bool.
 220         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
 221         (_initialize_ravenscar): Remove "(void)".
 222         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
 223         Return bool.
 224
 225 2019-02-15  Tom Tromey  <tromey@adacore.com>
 226
 227         * ravenscar-thread.c (ravenscar_runtime_initializer)
 228         (has_ravenscar_runtime, get_running_thread_id)
 229         (ravenscar_thread_target::resume): Fix indentation.
 230
 231 2019-02-15  Tom Tromey  <tromey@adacore.com>
 232
 233         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
 234         from ravenscar_arch_ops.
 235         (sparc_ravenscar_ops::fetch_registers)
 236         (sparc_ravenscar_ops::store_registers): Now methods.
 237         (sparc_ravenscar_prepare_to_store): Remove.
 238         (sparc_ravenscar_ops): Redefine.
 239         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
 240         methods and destructor.  Remove members.
 241         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
 242         (ravenscar_thread_target::store_registers)
 243         (ravenscar_thread_target::prepare_to_store): Update.
 244         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
 245         Remove.
 246         (struct ppc_ravenscar_powerpc_ops): Derive from
 247         ravenscar_arch_ops.
 248         (ppc_ravenscar_powerpc_ops::fetch_registers)
 249         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
 250         (ppc_ravenscar_powerpc_ops): Redefine.
 251         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
 252         (ppc_ravenscar_e500_ops::fetch_registers)
 253         (ppc_ravenscar_e500_ops::store_registers): Now methods.
 254         (ppc_ravenscar_e500_ops): Redefine.
 255         * aarch64-ravenscar-thread.c
 256         (aarch64_ravenscar_generic_prepare_to_store): Remove.
 257         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
 258         (aarch64_ravenscar_fetch_registers)
 259         (aarch64_ravenscar_store_registers): Now methods.
 260         (aarch64_ravenscar_ops): Redefine.
 261
 262 2019-02-15  Tom Tromey  <tromey@adacore.com>
 263
 264         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
 265         (ravenscar_thread_target::stopped_by_hw_breakpoint)
 266         (ravenscar_thread_target::stopped_by_watchpoint)
 267         (ravenscar_thread_target::stopped_data_address)
 268         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
 269
 270 2019-02-15  Tom Tromey  <tromey@adacore.com>
 271
 272         * ravenscar-thread.c: Fix some typos.
 273
 274 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 275             Tom Tromey  <tromey@adacore.com>
 276
 277         * ada-lang.c (ada_exception_sal): Change addr_string to a
 278         std::string.
 279         (create_ada_exception_catchpoint): Update.
 280
 281 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 282             Tom Tromey  <tromey@adacore.com>
 283
 284         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
 285         (bp_location_ops): Remove.
 286         (base_breakpoint_allocate_location): Update.
 287         (free_bp_location): Update.
 288         * ada-lang.c (class ada_catchpoint_location)
 289         <ada_catchpoint_location>: Remove ops parameter.
 290         (ada_catchpoint_location_dtor): Remove.
 291         (ada_catchpoint_location_ops): Remove.
 292         (allocate_location_exception): Update.
 293         * breakpoint.h (struct bp_location_ops): Remove.
 294         (class bp_location) <bp_location>: Remove bp_location_ops
 295         parameter.
 296         <~bp_location>: Add destructor.
 297         <ops>: Remove.
 298
 299 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 300             Pedro Alves  <palves@redhat.com>
 301
 302         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
 303         'PATH_MAX'.
 304
 305 2019-02-14  David Michael  <fedora.dm0@gmail.com>
 306             Samuel Thibault  <samuel.thibault@gnu.org>
 307             Thomas Schwinge  <thomas@codesourcery.com>
 308
 309         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
 310         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
 311
 312 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 313
 314         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
 315         (check_empty): Use "const char *".
 316
 317         * gnu-nat.c (gnu_nat_target::detach): Instead of
 318         'detach_inferior (pid)' call
 319         'detach_inferior (find_inferior_pid (pid))'.
 320
 321         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
 322         'nat/fork-inferior.o'.
 323         * gnu-nat.c: #include "nat/fork-inferior.h".
 324
 325         * gnu-nat.c (gnu_nat_target::detach): Instead of
 326         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
 327         * gnu-nat.h: #include "inf-child.h".
 328         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
 329         'i386_gnu_nat_target::fetch_registers'.
 330         (gnu_store_registers): Rename/move to
 331         'i386_gnu_nat_target::store_registers'.
 332
 333         * config/i386/nm-i386gnu.h: Don't "#include" any files.
 334         * gnu-nat.h (mach_thread_info): New function.
 335         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
 336
 337         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
 338
 339 2019-02-14  Frederic Konrad  <konrad@adacore.com>
 340
 341         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
 342
 343 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
 344
 345         * windows-nat.c (windows_add_thread): Add new parameter
 346         "main_thread_p" with default value set to false.  Update
 347         function documentation as well as all callers.
 348         (windows_delete_thread): Likewise.
 349         (fake_create_process): Update call to windows_add_thread.
 350         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
 351         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
 352         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
 353         call to windows_delete_thread.
 354
 355 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
 356
 357         * MAINTAINERS: Add Andrew Burgess as global maintainer.
 358
 359 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 360
 361         * symfile.c (find_separate_debug_file): Use canonical path of
 362         sysroot with child_path instead of gdb_sysroot if it is valid.
 363
 364 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 365
 366         * symfile.c (find_separate_debug_file): Use child_path to
 367         determine if an object file is under a sysroot.
 368
 369 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 370
 371         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 372         unittests/child-path-selftests.c.
 373         * common/pathstuff.c (child_path): New function.
 374         * common/pathstuff.h (child_path): New prototype.
 375         * unittests/child-path-selftests.c: New file.
 376
 377 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 378
 379         * symfile.c (find_separate_debug_file): Look for separate debug
 380         files in debug directories under the sysroot.
 381
 382 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 383
 384         * symtab.h (struct minimal_symbol data_p): New const method.
 385         (struct minimal_symbol text_p): Likewise.
 386         * symtab.c (output_source_filename): Use file name style
 387         to print file name.
 388         (print_symbol_info): Likewise.
 389         (print_msymbol_info): Use address style to print addresses.
 390         Use function name style to print executable text symbols.
 391         (expand_symtab_containing_pc): Use data_p.
 392         (find_pc_sect_compunit_symtab): Likewise.
 393
 394 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 395
 396         * breakpoint.c (describe_other_breakpoints): Use address style
 397         to print addresses.
 398         (say_where): Likewise.
 399
 400 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 401
 402         * ada-typeprint.c (print_func_type): Print function name
 403         style to print function name.
 404         * c-typeprint.c (c_print_type_1): Likewise.
 405
 406 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 407
 408         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 409         for execve.
 410
 411 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 412
 413         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 414         type_stack.
 415
 416 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 417
 418         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 419         TYPE_CODE_REF types.
 420
 421 2019-02-08  Jim Wilson  <jimw@sifive.com>
 422
 423         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 424         (riscv_linux_fregset): New.
 425         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 426
 427 2019-02-07  Tom Tromey  <tom@tromey.com>
 428
 429         * thread.c (thread_cancel_execution_command): Update.
 430         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 431         methods.
 432         (struct thread_fsm_ops): Remove.
 433         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 434         (thread_fsm_should_stop, thread_fsm_return_value)
 435         (thread_fsm_set_finished, thread_fsm_finished_p)
 436         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 437         Don't declare.
 438         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 439         * infrun.c (clear_proceed_status_thread)
 440         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 441         (print_stop_event): Update.
 442         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 443         Add constructor.
 444         (step_command_fsm_ops): Remove.
 445         (new_step_command_fsm): Remove.
 446         (step_1): Update.
 447         (step_command_fsm::should_stop): Rename from
 448         step_command_fsm_should_stop.
 449         (step_command_fsm::clean_up): Rename from
 450         step_command_fsm_clean_up.
 451         (step_command_fsm::do_async_reply_reason): Rename from
 452         step_command_fsm_async_reply_reason.
 453         (struct until_next_fsm): Inherit from thread_fsm.  Add
 454         constructor.
 455         (until_next_fsm_ops): Remove.
 456         (new_until_next_fsm): Remove.
 457         (until_next_fsm::should_stop): Rename from
 458         until_next_fsm_should_stop.
 459         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 460         (until_next_fsm::do_async_reply_reason): Rename from
 461         until_next_fsm_async_reply_reason.
 462         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 463         constructor.  Change type of breakpoint.
 464         (finish_command_fsm_ops): Remove.
 465         (new_finish_command_fsm): Remove.
 466         (finish_command_fsm::should_stop): Rename from
 467         finish_command_fsm_should_stop.
 468         (finish_command_fsm::clean_up): Rename from
 469         finish_command_fsm_clean_up.
 470         (finish_command_fsm::return_value): Rename from
 471         finish_command_fsm_return_value.
 472         (finish_command_fsm::do_async_reply_reason): Rename from
 473         finish_command_fsm_async_reply_reason.
 474         (finish_command): Update.
 475         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 476         Add constructor.
 477         (call_thread_fsm_ops): Remove.
 478         (call_thread_fsm::call_thread_fsm): Rename from
 479         new_call_thread_fsm.
 480         (call_thread_fsm::should_stop): Rename from
 481         call_thread_fsm_should_stop.
 482         (call_thread_fsm::should_notify_stop): Rename from
 483         call_thread_fsm_should_notify_stop.
 484         (run_inferior_call, call_function_by_hand_dummy): Update.
 485         * cli/cli-interp.c (should_print_stop_to_console): Update.
 486         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 487         Add constructor.  Change type of location_breakpoint,
 488         caller_breakpoint.
 489         (until_break_fsm_ops): Remove.
 490         (new_until_break_fsm): Remove.
 491         (until_break_fsm::should_stop): Rename from
 492         until_break_fsm_should_stop.
 493         (until_break_fsm::clean_up): Rename from
 494         until_break_fsm_clean_up.
 495         (until_break_fsm::do_async_reply_reason): Rename from
 496         until_break_fsm_async_reply_reason.
 497         (until_break_command): Update.
 498         * thread-fsm.c: Remove.
 499         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 500
 501 2019-02-07  Tom Tromey  <tom@tromey.com>
 502
 503         * yy-remap.h: Add include guard.
 504         * xtensa-tdep.h: Add include guard.
 505         * xcoffread.h: Rename include guard.
 506         * varobj-iter.h: Add include guard.
 507         * tui/tui.h: Rename include guard.
 508         * tui/tui-winsource.h: Rename include guard.
 509         * tui/tui-wingeneral.h: Rename include guard.
 510         * tui/tui-windata.h: Rename include guard.
 511         * tui/tui-win.h: Rename include guard.
 512         * tui/tui-stack.h: Rename include guard.
 513         * tui/tui-source.h: Rename include guard.
 514         * tui/tui-regs.h: Rename include guard.
 515         * tui/tui-out.h: Rename include guard.
 516         * tui/tui-layout.h: Rename include guard.
 517         * tui/tui-io.h: Rename include guard.
 518         * tui/tui-hooks.h: Rename include guard.
 519         * tui/tui-file.h: Rename include guard.
 520         * tui/tui-disasm.h: Rename include guard.
 521         * tui/tui-data.h: Rename include guard.
 522         * tui/tui-command.h: Rename include guard.
 523         * tic6x-tdep.h: Add include guard.
 524         * target/waitstatus.h: Rename include guard.
 525         * target/wait.h: Rename include guard.
 526         * target/target.h: Rename include guard.
 527         * target/resume.h: Rename include guard.
 528         * target-float.h: Rename include guard.
 529         * stabsread.h: Add include guard.
 530         * rs6000-tdep.h: Add include guard.
 531         * riscv-fbsd-tdep.h: Add include guard.
 532         * regformats/regdef.h: Rename include guard.
 533         * record.h: Rename include guard.
 534         * python/python.h: Rename include guard.
 535         * python/python-internal.h: Rename include guard.
 536         * python/py-stopevent.h: Rename include guard.
 537         * python/py-ref.h: Rename include guard.
 538         * python/py-record.h: Rename include guard.
 539         * python/py-record-full.h: Rename include guard.
 540         * python/py-record-btrace.h: Rename include guard.
 541         * python/py-instruction.h: Rename include guard.
 542         * python/py-events.h: Rename include guard.
 543         * python/py-event.h: Rename include guard.
 544         * procfs.h: Add include guard.
 545         * proc-utils.h: Add include guard.
 546         * p-lang.h: Add include guard.
 547         * or1k-tdep.h: Rename include guard.
 548         * observable.h: Rename include guard.
 549         * nto-tdep.h: Rename include guard.
 550         * nat/x86-linux.h: Rename include guard.
 551         * nat/x86-linux-dregs.h: Rename include guard.
 552         * nat/x86-gcc-cpuid.h: Add include guard.
 553         * nat/x86-dregs.h: Rename include guard.
 554         * nat/x86-cpuid.h: Rename include guard.
 555         * nat/ppc-linux.h: Rename include guard.
 556         * nat/mips-linux-watch.h: Rename include guard.
 557         * nat/linux-waitpid.h: Rename include guard.
 558         * nat/linux-ptrace.h: Rename include guard.
 559         * nat/linux-procfs.h: Rename include guard.
 560         * nat/linux-osdata.h: Rename include guard.
 561         * nat/linux-nat.h: Rename include guard.
 562         * nat/linux-namespaces.h: Rename include guard.
 563         * nat/linux-btrace.h: Rename include guard.
 564         * nat/glibc_thread_db.h: Rename include guard.
 565         * nat/gdb_thread_db.h: Rename include guard.
 566         * nat/gdb_ptrace.h: Rename include guard.
 567         * nat/fork-inferior.h: Rename include guard.
 568         * nat/amd64-linux-siginfo.h: Rename include guard.
 569         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 570         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 571         * nat/aarch64-linux.h: Rename include guard.
 572         * nat/aarch64-linux-hw-point.h: Rename include guard.
 573         * mn10300-tdep.h: Add include guard.
 574         * mips-linux-tdep.h: Add include guard.
 575         * mi/mi-parse.h: Rename include guard.
 576         * mi/mi-out.h: Rename include guard.
 577         * mi/mi-main.h: Rename include guard.
 578         * mi/mi-interp.h: Rename include guard.
 579         * mi/mi-getopt.h: Rename include guard.
 580         * mi/mi-console.h: Rename include guard.
 581         * mi/mi-common.h: Rename include guard.
 582         * mi/mi-cmds.h: Rename include guard.
 583         * mi/mi-cmd-break.h: Rename include guard.
 584         * m2-lang.h: Add include guard.
 585         * location.h: Rename include guard.
 586         * linux-record.h: Rename include guard.
 587         * linux-nat.h: Add include guard.
 588         * linux-fork.h: Add include guard.
 589         * i386-darwin-tdep.h: Rename include guard.
 590         * hppa-linux-offsets.h: Add include guard.
 591         * guile/guile.h: Rename include guard.
 592         * guile/guile-internal.h: Rename include guard.
 593         * gnu-nat.h: Rename include guard.
 594         * gdb-stabs.h: Rename include guard.
 595         * frv-tdep.h: Add include guard.
 596         * f-lang.h: Add include guard.
 597         * event-loop.h: Add include guard.
 598         * darwin-nat.h: Rename include guard.
 599         * cp-abi.h: Rename include guard.
 600         * config/sparc/nm-sol2.h: Rename include guard.
 601         * config/nm-nto.h: Rename include guard.
 602         * config/nm-linux.h: Add include guard.
 603         * config/i386/nm-i386gnu.h: Rename include guard.
 604         * config/djgpp/nl_types.h: Rename include guard.
 605         * config/djgpp/langinfo.h: Rename include guard.
 606         * compile/gcc-cp-plugin.h: Add include guard.
 607         * compile/gcc-c-plugin.h: Add include guard.
 608         * compile/compile.h: Rename include guard.
 609         * compile/compile-object-run.h: Rename include guard.
 610         * compile/compile-object-load.h: Rename include guard.
 611         * compile/compile-internal.h: Rename include guard.
 612         * compile/compile-cplus.h: Rename include guard.
 613         * compile/compile-c.h: Rename include guard.
 614         * common/xml-utils.h: Rename include guard.
 615         * common/x86-xstate.h: Rename include guard.
 616         * common/version.h: Rename include guard.
 617         * common/vec.h: Rename include guard.
 618         * common/tdesc.h: Rename include guard.
 619         * common/selftest.h: Rename include guard.
 620         * common/scoped_restore.h: Rename include guard.
 621         * common/scoped_mmap.h: Rename include guard.
 622         * common/scoped_fd.h: Rename include guard.
 623         * common/safe-iterator.h: Rename include guard.
 624         * common/run-time-clock.h: Rename include guard.
 625         * common/refcounted-object.h: Rename include guard.
 626         * common/queue.h: Rename include guard.
 627         * common/ptid.h: Rename include guard.
 628         * common/print-utils.h: Rename include guard.
 629         * common/preprocessor.h: Rename include guard.
 630         * common/pathstuff.h: Rename include guard.
 631         * common/observable.h: Rename include guard.
 632         * common/netstuff.h: Rename include guard.
 633         * common/job-control.h: Rename include guard.
 634         * common/host-defs.h: Rename include guard.
 635         * common/gdb_wait.h: Rename include guard.
 636         * common/gdb_vecs.h: Rename include guard.
 637         * common/gdb_unlinker.h: Rename include guard.
 638         * common/gdb_unique_ptr.h: Rename include guard.
 639         * common/gdb_tilde_expand.h: Rename include guard.
 640         * common/gdb_sys_time.h: Rename include guard.
 641         * common/gdb_string_view.h: Rename include guard.
 642         * common/gdb_splay_tree.h: Rename include guard.
 643         * common/gdb_setjmp.h: Rename include guard.
 644         * common/gdb_ref_ptr.h: Rename include guard.
 645         * common/gdb_optional.h: Rename include guard.
 646         * common/gdb_locale.h: Rename include guard.
 647         * common/gdb_assert.h: Rename include guard.
 648         * common/filtered-iterator.h: Rename include guard.
 649         * common/filestuff.h: Rename include guard.
 650         * common/fileio.h: Rename include guard.
 651         * common/environ.h: Rename include guard.
 652         * common/common-utils.h: Rename include guard.
 653         * common/common-types.h: Rename include guard.
 654         * common/common-regcache.h: Rename include guard.
 655         * common/common-inferior.h: Rename include guard.
 656         * common/common-gdbthread.h: Rename include guard.
 657         * common/common-exceptions.h: Rename include guard.
 658         * common/common-defs.h: Rename include guard.
 659         * common/common-debug.h: Rename include guard.
 660         * common/cleanups.h: Rename include guard.
 661         * common/buffer.h: Rename include guard.
 662         * common/btrace-common.h: Rename include guard.
 663         * common/break-common.h: Rename include guard.
 664         * cli/cli-utils.h: Rename include guard.
 665         * cli/cli-style.h: Rename include guard.
 666         * cli/cli-setshow.h: Rename include guard.
 667         * cli/cli-script.h: Rename include guard.
 668         * cli/cli-interp.h: Rename include guard.
 669         * cli/cli-decode.h: Rename include guard.
 670         * cli/cli-cmds.h: Rename include guard.
 671         * charset-list.h: Add include guard.
 672         * buildsym-legacy.h: Rename include guard.
 673         * bfin-tdep.h: Add include guard.
 674         * ax.h: Rename include guard.
 675         * arm-linux-tdep.h: Add include guard.
 676         * arm-fbsd-tdep.h: Add include guard.
 677         * arch/xtensa.h: Rename include guard.
 678         * arch/tic6x.h: Add include guard.
 679         * arch/i386.h: Add include guard.
 680         * arch/arm.h: Rename include guard.
 681         * arch/arm-linux.h: Rename include guard.
 682         * arch/arm-get-next-pcs.h: Rename include guard.
 683         * arch/amd64.h: Add include guard.
 684         * arch/aarch64-insn.h: Rename include guard.
 685         * arch-utils.h: Rename include guard.
 686         * annotate.h: Add include guard.
 687         * amd64-darwin-tdep.h: Rename include guard.
 688         * aarch64-linux-tdep.h: Add include guard.
 689         * aarch64-fbsd-tdep.h: Add include guard.
 690         * aarch32-linux-nat.h: Add include guard.
 691
 692 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 693
 694         * macrotab.c (macro_define_internal): New function that
 695         factorizes macro_define_object_internal and macro_define_function
 696         code.
 697         (macro_define_object_internal): Use macro_define_internal.
 698         (macro_define_function): Likewise.
 699
 700 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 701
 702         * macrocmd.c (extract_identifier): Return
 703         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
 704         callers.
 705
 706 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
 707
 708         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
 709
 710 2019-02-05  Tom Tromey  <tom@tromey.com>
 711
 712         * target.c (target_stack::unpush): Move assertion earlier.
 713
 714 2019-01-30  Tom Tromey  <tom@tromey.com>
 715
 716         PR python/23615:
 717         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
 718         (gdbpy_parse_and_eval): Likewise.
 719         * python/python-internal.h (gdbpy_allow_threads): New class.
 720
 721 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
 722
 723         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
 724         (aarch64_fbsd_fpregmap): Move earlier.
 725         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
 726         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 727         instead of individual calls to trad_frame_set_reg_addr.
 728         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
 729         earlier.
 730         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
 731         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 732         instead of individual calls to trad_frame_set_reg_addr.
 733
 734 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
 735
 736         * CONTRIBUTE: Replace contribution list with wiki link.
 737
 738 2019-01-25  Tom Tromey  <tom@tromey.com>
 739
 740         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
 741
 742 2019-01-25  Tom Tromey  <tom@tromey.com>
 743
 744         * xtensa-linux-nat.c: Fix common/ includes.
 745         * xml-support.h: Fix common/ includes.
 746         * xml-support.c: Fix common/ includes.
 747         * x86-linux-nat.c: Fix common/ includes.
 748         * windows-nat.c: Fix common/ includes.
 749         * varobj.h: Fix common/ includes.
 750         * varobj.c: Fix common/ includes.
 751         * value.c: Fix common/ includes.
 752         * valops.c: Fix common/ includes.
 753         * utils.c: Fix common/ includes.
 754         * unittests/xml-utils-selftests.c: Fix common/ includes.
 755         * unittests/utils-selftests.c: Fix common/ includes.
 756         * unittests/unpack-selftests.c: Fix common/ includes.
 757         * unittests/tracepoint-selftests.c: Fix common/ includes.
 758         * unittests/style-selftests.c: Fix common/ includes.
 759         * unittests/string_view-selftests.c: Fix common/ includes.
 760         * unittests/scoped_restore-selftests.c: Fix common/ includes.
 761         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
 762         * unittests/scoped_fd-selftests.c: Fix common/ includes.
 763         * unittests/rsp-low-selftests.c: Fix common/ includes.
 764         * unittests/parse-connection-spec-selftests.c: Fix common/
 765         includes.
 766         * unittests/optional-selftests.c: Fix common/ includes.
 767         * unittests/offset-type-selftests.c: Fix common/ includes.
 768         * unittests/observable-selftests.c: Fix common/ includes.
 769         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
 770         * unittests/memrange-selftests.c: Fix common/ includes.
 771         * unittests/memory-map-selftests.c: Fix common/ includes.
 772         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
 773         * unittests/function-view-selftests.c: Fix common/ includes.
 774         * unittests/environ-selftests.c: Fix common/ includes.
 775         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
 776         * unittests/common-utils-selftests.c: Fix common/ includes.
 777         * unittests/cli-utils-selftests.c: Fix common/ includes.
 778         * unittests/array-view-selftests.c: Fix common/ includes.
 779         * ui-file.c: Fix common/ includes.
 780         * tui/tui-io.c: Fix common/ includes.
 781         * tracepoint.h: Fix common/ includes.
 782         * tracepoint.c: Fix common/ includes.
 783         * tracefile-tfile.c: Fix common/ includes.
 784         * top.h: Fix common/ includes.
 785         * top.c: Fix common/ includes.
 786         * thread.c: Fix common/ includes.
 787         * target/waitstatus.h: Fix common/ includes.
 788         * target/waitstatus.c: Fix common/ includes.
 789         * target.h: Fix common/ includes.
 790         * target.c: Fix common/ includes.
 791         * target-memory.c: Fix common/ includes.
 792         * target-descriptions.c: Fix common/ includes.
 793         * symtab.h: Fix common/ includes.
 794         * symfile.c: Fix common/ includes.
 795         * stap-probe.c: Fix common/ includes.
 796         * spu-linux-nat.c: Fix common/ includes.
 797         * sparc-nat.c: Fix common/ includes.
 798         * source.c: Fix common/ includes.
 799         * solib.c: Fix common/ includes.
 800         * solib-target.c: Fix common/ includes.
 801         * ser-unix.c: Fix common/ includes.
 802         * ser-tcp.c: Fix common/ includes.
 803         * ser-pipe.c: Fix common/ includes.
 804         * ser-base.c: Fix common/ includes.
 805         * selftest-arch.c: Fix common/ includes.
 806         * s12z-tdep.c: Fix common/ includes.
 807         * rust-exp.y: Fix common/ includes.
 808         * rs6000-aix-tdep.c: Fix common/ includes.
 809         * riscv-tdep.c: Fix common/ includes.
 810         * remote.c: Fix common/ includes.
 811         * remote-notif.h: Fix common/ includes.
 812         * remote-fileio.h: Fix common/ includes.
 813         * remote-fileio.c: Fix common/ includes.
 814         * regcache.h: Fix common/ includes.
 815         * regcache.c: Fix common/ includes.
 816         * record-btrace.c: Fix common/ includes.
 817         * python/python.c: Fix common/ includes.
 818         * python/py-type.c: Fix common/ includes.
 819         * python/py-inferior.c: Fix common/ includes.
 820         * progspace.h: Fix common/ includes.
 821         * producer.c: Fix common/ includes.
 822         * procfs.c: Fix common/ includes.
 823         * proc-api.c: Fix common/ includes.
 824         * printcmd.c: Fix common/ includes.
 825         * ppc-linux-nat.c: Fix common/ includes.
 826         * parser-defs.h: Fix common/ includes.
 827         * osdata.c: Fix common/ includes.
 828         * obsd-nat.c: Fix common/ includes.
 829         * nat/x86-linux.c: Fix common/ includes.
 830         * nat/x86-linux-dregs.c: Fix common/ includes.
 831         * nat/x86-dregs.h: Fix common/ includes.
 832         * nat/x86-dregs.c: Fix common/ includes.
 833         * nat/ppc-linux.c: Fix common/ includes.
 834         * nat/mips-linux-watch.h: Fix common/ includes.
 835         * nat/mips-linux-watch.c: Fix common/ includes.
 836         * nat/linux-waitpid.c: Fix common/ includes.
 837         * nat/linux-ptrace.h: Fix common/ includes.
 838         * nat/linux-ptrace.c: Fix common/ includes.
 839         * nat/linux-procfs.c: Fix common/ includes.
 840         * nat/linux-personality.c: Fix common/ includes.
 841         * nat/linux-osdata.c: Fix common/ includes.
 842         * nat/linux-namespaces.c: Fix common/ includes.
 843         * nat/linux-btrace.h: Fix common/ includes.
 844         * nat/linux-btrace.c: Fix common/ includes.
 845         * nat/fork-inferior.c: Fix common/ includes.
 846         * nat/amd64-linux-siginfo.c: Fix common/ includes.
 847         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
 848         * nat/aarch64-linux.c: Fix common/ includes.
 849         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
 850         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
 851         * namespace.h: Fix common/ includes.
 852         * mips-linux-tdep.c: Fix common/ includes.
 853         * minsyms.c: Fix common/ includes.
 854         * mi/mi-parse.h: Fix common/ includes.
 855         * mi/mi-main.c: Fix common/ includes.
 856         * mi/mi-cmd-env.c: Fix common/ includes.
 857         * memrange.h: Fix common/ includes.
 858         * memattr.c: Fix common/ includes.
 859         * maint.h: Fix common/ includes.
 860         * maint.c: Fix common/ includes.
 861         * main.c: Fix common/ includes.
 862         * machoread.c: Fix common/ includes.
 863         * location.c: Fix common/ includes.
 864         * linux-thread-db.c: Fix common/ includes.
 865         * linux-nat.c: Fix common/ includes.
 866         * linux-fork.c: Fix common/ includes.
 867         * inline-frame.c: Fix common/ includes.
 868         * infrun.c: Fix common/ includes.
 869         * inflow.c: Fix common/ includes.
 870         * inferior.h: Fix common/ includes.
 871         * inferior.c: Fix common/ includes.
 872         * infcmd.c: Fix common/ includes.
 873         * inf-ptrace.c: Fix common/ includes.
 874         * inf-child.c: Fix common/ includes.
 875         * ia64-linux-nat.c: Fix common/ includes.
 876         * i387-tdep.c: Fix common/ includes.
 877         * i386-tdep.c: Fix common/ includes.
 878         * i386-linux-tdep.c: Fix common/ includes.
 879         * i386-linux-nat.c: Fix common/ includes.
 880         * i386-go32-tdep.c: Fix common/ includes.
 881         * i386-fbsd-tdep.c: Fix common/ includes.
 882         * i386-fbsd-nat.c: Fix common/ includes.
 883         * guile/scm-type.c: Fix common/ includes.
 884         * guile/guile.c: Fix common/ includes.
 885         * go32-nat.c: Fix common/ includes.
 886         * gnu-nat.c: Fix common/ includes.
 887         * gdbthread.h: Fix common/ includes.
 888         * gdbarch-selftests.c: Fix common/ includes.
 889         * gdb_usleep.c: Fix common/ includes.
 890         * gdb_select.h: Fix common/ includes.
 891         * gdb_bfd.c: Fix common/ includes.
 892         * gcore.c: Fix common/ includes.
 893         * fork-child.c: Fix common/ includes.
 894         * findvar.c: Fix common/ includes.
 895         * fbsd-nat.c: Fix common/ includes.
 896         * event-top.c: Fix common/ includes.
 897         * event-loop.c: Fix common/ includes.
 898         * dwarf2read.c: Fix common/ includes.
 899         * dwarf2loc.c: Fix common/ includes.
 900         * dwarf2-frame.c: Fix common/ includes.
 901         * dwarf-index-cache.c: Fix common/ includes.
 902         * dtrace-probe.c: Fix common/ includes.
 903         * disasm-selftests.c: Fix common/ includes.
 904         * defs.h: Fix common/ includes.
 905         * csky-tdep.c: Fix common/ includes.
 906         * cp-valprint.c: Fix common/ includes.
 907         * cp-support.h: Fix common/ includes.
 908         * cp-support.c: Fix common/ includes.
 909         * corelow.c: Fix common/ includes.
 910         * completer.h: Fix common/ includes.
 911         * completer.c: Fix common/ includes.
 912         * compile/compile.c: Fix common/ includes.
 913         * compile/compile-loc2c.c: Fix common/ includes.
 914         * compile/compile-cplus-types.c: Fix common/ includes.
 915         * compile/compile-cplus-symbols.c: Fix common/ includes.
 916         * command.h: Fix common/ includes.
 917         * cli/cli-dump.c: Fix common/ includes.
 918         * cli/cli-cmds.c: Fix common/ includes.
 919         * charset.c: Fix common/ includes.
 920         * build-id.c: Fix common/ includes.
 921         * btrace.h: Fix common/ includes.
 922         * btrace.c: Fix common/ includes.
 923         * breakpoint.h: Fix common/ includes.
 924         * breakpoint.c: Fix common/ includes.
 925         * ax.h:
 926         (enum agent_op): Fix common/ includes.
 927         * ax-general.c (struct aop_map): Fix common/ includes.
 928         * ax-gdb.c: Fix common/ includes.
 929         * auxv.c: Fix common/ includes.
 930         * auto-load.c: Fix common/ includes.
 931         * arm-tdep.c: Fix common/ includes.
 932         * arch/riscv.c: Fix common/ includes.
 933         * arch/ppc-linux-common.c: Fix common/ includes.
 934         * arch/i386.c: Fix common/ includes.
 935         * arch/arm.c: Fix common/ includes.
 936         * arch/arm-linux.c: Fix common/ includes.
 937         * arch/arm-get-next-pcs.c: Fix common/ includes.
 938         * arch/amd64.c: Fix common/ includes.
 939         * arch/aarch64.c: Fix common/ includes.
 940         * arch/aarch64-insn.c: Fix common/ includes.
 941         * arch-utils.c: Fix common/ includes.
 942         * amd64-windows-tdep.c: Fix common/ includes.
 943         * amd64-tdep.c: Fix common/ includes.
 944         * amd64-sol2-tdep.c: Fix common/ includes.
 945         * amd64-obsd-tdep.c: Fix common/ includes.
 946         * amd64-nbsd-tdep.c: Fix common/ includes.
 947         * amd64-linux-tdep.c: Fix common/ includes.
 948         * amd64-linux-nat.c: Fix common/ includes.
 949         * amd64-fbsd-tdep.c: Fix common/ includes.
 950         * amd64-fbsd-nat.c: Fix common/ includes.
 951         * amd64-dicos-tdep.c: Fix common/ includes.
 952         * amd64-darwin-tdep.c: Fix common/ includes.
 953         * agent.c: Fix common/ includes.
 954         * ada-lang.h: Fix common/ includes.
 955         * ada-lang.c: Fix common/ includes.
 956         * aarch64-tdep.c: Fix common/ includes.
 957
 958 2019-01-25  Tom Tromey  <tom@tromey.com>
 959
 960         * common/create-version.sh: Use common/version.h.
 961
 962 2019-01-24  Pedro Alves  <palves@redhat.com>
 963
 964         * infrun.c (signal_stop, signal_print, signal_program)
 965         (signal_catch, signal_pass): Now arrays instead of pointers.
 966         (update_signals_program_target, do_target_resume)
 967         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
 968         * linux-nat.c (linux_nat_target::pass_signals)
 969         (linux_nat_target::create_inferior, linux_nat_target::attach):
 970         Adjust.
 971         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
 972         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
 973         * procfs.c (procfs_target::pass_signals): Adjust.
 974         * record-full.c (record_full_target::resume): Adjust.
 975         * remote.c (remote_target::pass_signals)
 976         (remote_target::program_signals): Adjust.
 977         * target-debug.h (target_debug_print_signals): Now takes a
 978         gdb::array_view as parameter.  Adjust.
 979         * target.h (target_ops) <pass_signals, program_signals>: Replace
 980         pointer and length parameters with gdb::array_view.
 981         (target_pass_signals, target_program_signals): Likewise.
 982         * target-delegates.c: Regenerate.
 983
 984 2019-01-24  Pedro Alves  <palves@redhat.com>
 985
 986         * common/forward-scope-exit.h
 987         (forward_scope_exit::forward_scope_exit): Pass arguments to
 988         m_bind_function directly, instead of creating a std::bind and
 989         copying that.
 990
 991 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
 992
 993         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 994         for static members.
 995         (pass_in_v_vfp_candidate): Likewise.
 996
 997 2019-01-23  Tom Tromey  <tom@tromey.com>
 998             Pedro Alves  <palves@redhat.com>
 999
1000         * regcache.c (class regcache_invalidator): Remove.
1001         (regcache::raw_write): Use make_scope_exit.
1002
1003 2019-01-23  Tom Tromey  <tom@tromey.com>
1004
1005         * ui-out.h (class ui_out_emit_type): Update comment.
1006
1007 2019-01-23  Tom Tromey  <tom@tromey.com>
1008
1009         * infrun.c (fetch_inferior_event): Update comment.
1010
1011 2019-01-23  Tom Tromey  <tom@tromey.com>
1012             Pedro Alves  <palves@redhat.com>
1013
1014         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1015         parameter.
1016         (fetch_inferior_event): Use SCOPE_EXIT.
1017
1018
1019 2019-01-23  Tom Tromey  <tom@tromey.com>
1020             Pedro Alves  <palves@redhat.com>
1021
1022         * infrun.c (disable_thread_events): Delete.
1023         (stop_all_threads): Use SCOPE_EXIT.
1024
1025 2019-01-23  Tom Tromey  <tom@tromey.com>
1026             Pedro Alves  <palves@redhat.com>
1027
1028         * symfile.c: Include forward-scope-exit.h.
1029         (clear_symtab_users_cleanup): Replace forward declaration with
1030         a FORWARD_SCOPE_EXIT.
1031         (syms_from_objfile_1): Use the forward_scope_exit and
1032         gdb::optional instead of cleanup_function.
1033         (reread_symbols): Use the forward_scope_exit instead of
1034         cleanup_function.
1035         (clear_symtab_users_cleanup): Remove function.
1036
1037 2019-01-23  Tom Tromey  <tom@tromey.com>
1038             Pedro Alves  <palves@redhat.com>
1039
1040         * linux-nat.c: Include scope-exit.h.
1041         (cleanup_target_stop): Remove.
1042         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1043         SCOPE_EXIT.
1044
1045 2019-01-23  Tom Tromey  <tom@tromey.com>
1046             Pedro Alves  <palves@redhat.com>
1047
1048         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1049         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1050
1051 2019-01-23  Tom Tromey  <tom@tromey.com>
1052             Andrew Burgess  <andrew.burgess@embecosm.com>
1053             Pedro Alves  <palves@redhat.com>
1054
1055         * infrun.c (fetch_inferior_event): Use scope_exit.
1056         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1057         * top.c (execute_command): Use scope_exit.
1058         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1059         * utils.c (do_bpstat_clear_actions_cleanup)
1060         (make_bpstat_clear_actions_cleanup): Remove.
1061
1062 2019-01-23  Tom Tromey  <tom@tromey.com>
1063             Pedro Alves  <palves@redhat.com>
1064
1065         * infrun.c: Include "common/scope-exit.h"
1066         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1067         (wait_for_inferior): Use SCOPE_EXIT.
1068         (fetch_inferior_event): Use scope_exit.
1069
1070 2019-01-23  Tom Tromey  <tom@tromey.com>
1071             Pedro Alves  <palves@redhat.com>
1072
1073         * breakpoint.c (create_breakpoint): Remove cleanup.
1074
1075 2019-01-23  Tom Tromey  <tom@tromey.com>
1076             Andrew Burgess  <andrew.burgess@embecosm.com>
1077             Pedro Alves  <palves@redhat.com>
1078
1079 2019-01-23  Pedro Alves  <palves@redhat.com>
1080
1081         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1082
1083 2019-01-23  Pedro Alves  <palves@redhat.com>
1084             Andrew Burgess  <andrew.burgess@embecosm.com>
1085
1086         * gdbthread.h: Include "common/forward-scope-exit.h".
1087         (scoped_finish_thread_state): Redefine custom class in terms of
1088         forward_scope_exit.
1089
1090 2019-01-23  Pedro Alves  <palves@redhat.com>
1091             Andrew Burgess  <andrew.burgess@embecosm.com>
1092
1093         * common/forward-scope-exit.h: New file.
1094
1095 2019-01-23  Pedro Alves  <palves@redhat.com>
1096             Andrew Burgess  <andrew.burgess@embecosm.com>
1097             Tom Tromey  <tom@tromey.com>
1098
1099         * common/scope-exit.h: New file.
1100
1101 2019-01-23  Pedro Alves  <palves@redhat.com>
1102
1103         * common/preprocessor.h (ESC): Rename to ...
1104         (ESC_PARENS): ... this.
1105         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1106         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1107
1108 2019-01-23  Tom Tromey  <tom@tromey.com>
1109
1110         * language.h (class scoped_switch_to_sym_language_if_auto):
1111         Initialize m_lang in both cases.
1112
1113 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1114
1115         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1116         with XCNEW.
1117
1118 2019-01-22  Tom Tromey  <tom@tromey.com>
1119
1120         * corelow.c: Do not include sys/file.h.
1121
1122 2019-01-22  Tom Tromey  <tom@tromey.com>
1123
1124         * tui/tui-wingeneral.h: Include gdb_curses.h.
1125
1126 2019-01-22  Tom Tromey  <tom@tromey.com>
1127
1128         * source-cache.h (class source_cache) <get_source_lines,
1129         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1130
1131 2019-01-22  Tom Tromey  <tom@tromey.com>
1132
1133         * remote-fileio.h (struct remote_target): Declare.
1134
1135 2019-01-22  Tom Tromey  <tom@tromey.com>
1136
1137         * python/py-arch.c: Do not include py-ref.h.
1138         * python/py-bpevent.c: Do not include py-ref.h.
1139         * python/py-cmd.c: Do not include py-ref.h.
1140         * python/py-continueevent.c: Do not include py-ref.h.
1141         * python/py-event.h: Do not include py-ref.h.
1142         * python/py-evtregistry.c: Do not include py-ref.h.
1143         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1144         * python/py-frame.c: Do not include py-ref.h.
1145         * python/py-framefilter.c: Do not include py-ref.h.
1146         * python/py-function.c: Do not include py-ref.h.
1147         * python/py-infevents.c: Do not include py-ref.h.
1148         * python/py-linetable.c: Do not include py-ref.h.
1149         * python/py-objfile.c: Do not include py-ref.h.
1150         * python/py-param.c: Do not include py-ref.h.
1151         * python/py-prettyprint.c: Do not include py-ref.h.
1152         * python/py-progspace.c: Do not include py-ref.h.
1153         * python/py-symbol.c: Do not include py-ref.h.
1154         * python/py-symtab.c: Do not include py-ref.h.
1155         * python/py-type.c: Do not include py-ref.h.
1156         * python/py-unwind.c: Do not include py-ref.h.
1157         * python/py-utils.c: Do not include py-ref.h.
1158         * python/py-value.c: Do not include py-ref.h.
1159         * python/py-varobj.c: Do not include py-ref.h.
1160         * python/py-xmethods.c: Do not include py-ref.h.
1161         * python/python.c: Do not include py-ref.h.
1162         * varobj.c: Do not include py-ref.h.
1163
1164 2019-01-22  Tom Tromey  <tom@tromey.com>
1165
1166         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1167         keyword for bcache.
1168
1169 2019-01-22  Tom Tromey  <tom@tromey.com>
1170
1171         * compile/compile-cplus-types.c: Remove a comment by #include.
1172
1173 2019-01-22  Tom Tromey  <tom@tromey.com>
1174
1175         * compile/gcc-c-plugin.h: Include compile-internal.h.
1176
1177 2019-01-22  Tom Tromey  <tom@tromey.com>
1178
1179         * stabsread.c (EXTERN): Do not define.
1180         (symnum, next_symbol_text_func, processing_gcc_compilation)
1181         (within_function, global_sym_chain, global_stabs)
1182         (previous_stab_code, this_object_header_files)
1183         (n_this_object_header_files)
1184         (n_allocated_this_object_header_files): Define.
1185         * stabsread.h (EXTERN): Never define.  Use "extern".
1186
1187 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1188
1189         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1190         history_value.
1191
1192 2019-01-21  Tom Tromey  <tom@tromey.com>
1193
1194         * ui-out.c: Fix includes.
1195         * tui/tui-source.c: Fix includes.
1196         * target.c: Fix includes.
1197         * remote.c: Fix includes.
1198         * regcache.c: Fix includes.
1199         * python/py-block.c: Fix includes.
1200         * printcmd.c: Fix includes.
1201         * or1k-tdep.c: Fix includes.
1202         * mi/mi-main.c: Fix includes.
1203         * m32r-tdep.c: Fix includes.
1204         * csky-tdep.c: Fix includes.
1205         * compile/compile-cplus-types.c: Fix includes.
1206         * cli/cli-interp.c: Fix includes.
1207
1208 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1209
1210         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1211         for padding.
1212
1213 2019-01-16  Tom Tromey  <tom@tromey.com>
1214
1215         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1216         earlier.
1217         (struct objfile) <msymbols_range>: Move from top level.
1218         <msymbols>: New method.
1219         (class objfile_msymbols): Remove.
1220         * symtab.c (default_collect_symbol_completion_matches_break_on):
1221         Update.
1222         * symmisc.c (dump_msymbols): Update.
1223         * stabsread.c (scan_file_globals): Update.
1224         * objc-lang.c (info_selectors_command, info_classes_command)
1225         (find_methods): Update.
1226         * minsyms.c (find_solib_trampoline_target): Update.
1227         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1228         * coffread.c (coff_symfile_read): Update.
1229         * ada-lang.c (ada_lookup_simple_minsym)
1230         (ada_collect_symbol_completion_matches): Update.
1231
1232 2019-01-16  Tom Tromey  <tom@tromey.com>
1233
1234         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1235         type.  Remove no-argument constructor.
1236         <iterator::operator++>: Simplify.
1237         <begin>: Update.
1238         <end>: Use minimal_symbol_count.
1239
1240 2019-01-16  Tom Tromey  <tom@tromey.com>
1241
1242         * objfiles.h (struct objfile) <psymtabs>: New method.
1243         (class objfile_psymtabs): Remove.
1244         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1245         typedef.
1246         <range>: New method.
1247         (require_partial_symbols): Change return type.
1248         * psymtab.c (require_partial_symbols)
1249         (psym_expand_symtabs_matching): Update.
1250         * mdebugread.c (parse_partial_symbols): Update.
1251         * dbxread.c (dbx_end_psymtab): Update.
1252
1253 2019-01-15  Tom Tromey  <tom@tromey.com>
1254
1255         * symtab.c (lookup_objfile_from_block)
1256         (lookup_symbol_in_objfile_symtabs)
1257         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1258         (find_line_symtab, info_sources_command)
1259         (default_collect_symbol_completion_matches_break_on)
1260         (make_source_files_completion_list): Update.
1261         * symmisc.c (print_objfile_statistics, dump_objfile)
1262         (maintenance_print_symbols, maintenance_info_symtabs)
1263         (maintenance_check_symtabs, maintenance_info_line_tables):
1264         Update.
1265         * source.c (select_source_symtab)
1266         (forget_cached_source_info_for_objfile): Update.
1267         * objfiles.h (class objfile_compunits): Remove.
1268         (struct objfile) <compunits_range>: New typedef.
1269         (compunits): New method.
1270         * objfiles.c (objfile_relocate1): Update.
1271         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1272         * maint.c (count_symtabs_and_blocks): Update.
1273         * linespec.c (iterate_over_all_matching_symtabs): Update.
1274         * cp-support.c (add_symbol_overload_list_qualified): Update.
1275         * coffread.c (coff_symtab_read): Update.
1276         * ada-lang.c (add_nonlocal_symbols)
1277         (ada_collect_symbol_completion_matches)
1278         (ada_add_global_exceptions): Update.
1279
1280 2019-01-15  Tom Tromey  <tom@tromey.com>
1281
1282         * progspace.h (program_space) <objfiles_safe_range>: New
1283         typedef.
1284         <objfiles_safe>: New method.
1285         * objfiles.h (class all_objfiles_safe): Remove.
1286         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1287         * jit.c (jit_inferior_exit_hook): Update.
1288
1289 2019-01-17  Tom Tromey  <tom@tromey.com>
1290
1291         * progspace.h (program_space) <objfiles_range>: New typedef.
1292         <objfiles>: New method.
1293         <objfiles_head>: Rename from objfiles.
1294         (object_files): Update.
1295         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1296         * guile/scm-pretty-print.c
1297         (ppscm_find_pretty_printer_from_objfiles): Update.
1298         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1299         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1300         Update.
1301         * python/py-progspace.c (pspy_get_objfiles): Update.
1302         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1303         Update.
1304         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1305         (objfpy_lookup_objfile_by_build_id): Update.
1306         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1307         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1308         Update.
1309         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1310         (expand_symtab_containing_pc, lookup_objfile_from_block)
1311         (lookup_static_symbol, basic_lookup_transparent_type)
1312         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1313         (find_line_symtab, info_sources_command)
1314         (default_collect_symbol_completion_matches_break_on)
1315         (make_source_files_completion_list, find_main_name): Update.
1316         * symmisc.c (print_symbol_bcache_statistics)
1317         (print_objfile_statistics, maintenance_print_symbols)
1318         (maintenance_print_msymbols, maintenance_print_objfiles)
1319         (maintenance_info_symtabs, maintenance_check_symtabs)
1320         (maintenance_expand_symtabs, maintenance_info_line_tables):
1321         Update.
1322         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1323         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1324         (map_overlay_command, unmap_overlay_command)
1325         (simple_overlay_update, expand_symtabs_matching)
1326         (map_symbol_filenames): Update.
1327         * symfile-debug.c (set_debug_symfile): Update.
1328         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1329         Update.
1330         * source.c (select_source_symtab, forget_cached_source_info):
1331         Update.
1332         * solib.c (solib_read_symbols): Update.
1333         * solib-spu.c (append_ocl_sos): Update.
1334         * psymtab.c (maintenance_print_psymbols)
1335         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1336         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1337         * printcmd.c (info_symbol_command): Update.
1338         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1339         Update.
1340         * objfiles.h (class all_objfiles): Remove.
1341         * objfiles.c (have_partial_symbols, have_full_symbols)
1342         (have_minimal_symbols, qsort_cmp, update_section_map)
1343         (shared_objfile_contains_address_p)
1344         (default_iterate_over_objfiles_in_search_order): Update.
1345         * objc-lang.c (info_selectors_command, info_classes_command)
1346         (find_methods): Update.
1347         * minsyms.c (find_solib_trampoline_target): Update.
1348         * maint.c (maintenance_info_sections)
1349         (maintenance_translate_address, count_symtabs_and_blocks):
1350         Update.
1351         * main.c (captured_main_1): Update.
1352         * linux-thread-db.c (try_thread_db_load_from_pdir)
1353         (has_libpthread): Update.
1354         * linespec.c (iterate_over_all_matching_symtabs)
1355         (search_minsyms_for_name): Update.
1356         * jit.c (jit_find_objf_with_entry_addr): Update.
1357         * hppa-tdep.c (find_unwind_entry)
1358         (hppa_lookup_stub_minimal_symbol): Update.
1359         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1360         Update.
1361         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1362         (elf_gnu_ifunc_resolve_by_got): Update.
1363         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1364         * dwarf-index-write.c (save_gdb_index_command): Update.
1365         * cp-support.c (add_symbol_overload_list_qualified): Update.
1366         * breakpoint.c (create_overlay_event_breakpoint)
1367         (create_longjmp_master_breakpoint)
1368         (create_std_terminate_master_breakpoint)
1369         (create_exception_master_breakpoint): Update.
1370         * blockframe.c (find_pc_partial_function): Update.
1371         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1372         (ada_collect_symbol_completion_matches)
1373         (ada_add_global_exceptions): Update.
1374
1375 2019-01-17  Tom Tromey  <tom@tromey.com>
1376
1377         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1378         declare VEC.
1379         (solib_target_parse_libraries): Change return type.
1380         (library_list_start_segment, library_list_start_section)
1381         (library_list_end_library, library_list_start_library); Update.
1382         (solib_target_free_library_list): Remove.
1383         (solib_target_parse_libraries): Remove cleanup.  Change return
1384         type.
1385         (solib_target_current_sos): Update.
1386
1387 2019-01-17  Tom Tromey  <tromey@bapiya>
1388
1389         * valprint.c: Replace "the the" with "the".
1390         * symtab.c: Replace "the the" with "the".
1391         * solib.c: Replace "the the" with "the".
1392         * solib-dsbt.c: Replace "the the" with "the".
1393         * linespec.c: Replace "the the" with "the".
1394         * dwarf2loc.h: Replace "the the" with "the".
1395         * amd64-windows-tdep.c: Replace "the the" with "the".
1396         * aarch64-tdep.c: Replace "the the" with "the".
1397
1398 2019-01-16  Keith Seitz  <keiths@redhat.com>
1399
1400         PR gdb/23773
1401         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1402         <builder>: Rename to ..
1403         <m_builder>: ... this and make private.
1404         (dwarf2_cu::get_builder): New method.  Change all users of
1405         `builder' to use this method.
1406         (dwarf2_start_symtab): Move to ...
1407         (dwarf2_cu::start_symtab): ... here.  Update all callers
1408         (setup_type_unit_groups): Move to ...
1409         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1410         callers.
1411         (dwarf2_cu::reset_builder): New method.
1412         (process_full_compunit, process_full_type_unit): Use
1413         dwarf2_cu::reset_builder.
1414         (follow_die_offset): Record the ancestor CU if it is different
1415         from the followed DIE's CU.
1416         (follow_die_sig_1): Likewise.
1417
1418 2019-01-15  Tom Tromey  <tom@tromey.com>
1419
1420         * remote.c (class remote_state) <buf>: Now a char_vector.
1421         <buf_size>: Remove.
1422         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1423         parameter.
1424         (remote_target::getpkt_or_notif_sane_1)
1425         (remote_target::getpkt_sane)
1426         (remote_target::getpkt_or_notif_sane): Likewise.
1427         (class remote_target) <putpkt>: New overload.
1428         (remote_target::read_frame): Change type of "buf_p".  Remove
1429         sizeof_p parameter.
1430         (packet_ok): New overload.
1431         (packet_check_result): New overload.
1432         Update all uses.
1433
1434 2019-01-14  Tom Tromey  <tom@tromey.com>
1435
1436         * remote-notif.c (handle_notification, remote_notif_ack)
1437         (remote_notif_parse): Make "buf" const.
1438         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1439         const.
1440         (remote_notif_parse, remote_notif_ack, handle_notification):
1441         Likewise.
1442         * remote.c (remote_notif_stop_parse): Make "buf" const.
1443         (remote_target::remote_parse_stop_reply): Make "buf" const.
1444         (remote_notif_stop_ack): Make "buf" const.
1445
1446 2019-01-14  Tom Tromey  <tom@tromey.com>
1447
1448         * remote.c (remote_console_output): Make parameter const.
1449
1450 2019-01-14  Tom Tromey  <tom@tromey.com>
1451
1452         * target-debug.h (target_debug_print_signals): Constify.
1453         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1454         * procfs.c (procfs_target::pass_signals): Update.
1455         * linux-nat.c (linux_nat_target::pass_signals): Update.
1456         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1457         * target-delegates.c: Rebuild.
1458         * remote.c (remote_target::program_signals): Update.
1459         (remote_target::pass_signals): Update.
1460         * target.c (target_pass_signals): Constify argument.
1461         (target_program_signals): Likewise.
1462         * target.h (struct target_ops) <pass_signals, program_signals>:
1463         Constify argument.
1464         (target_pass_signals, target_program_signals): Constify argument.
1465
1466 2019-01-14  Tom Tromey  <tom@tromey.com>
1467
1468         PR tui/28819:
1469         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1470
1471 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1472
1473         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1474         field.
1475         * rs6000-tdep.c: Include reggroups.h.
1476         (IS_V_ALIAS_PSEUDOREG): Define.
1477         (rs6000_register_name): Return names for the "vX" aliases.
1478         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1479         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1480         aliases.  Call default_register_reggroup_p for all other
1481         pseudo-registers.
1482         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1483         New functions.
1484         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1485         Handle "vX" aliases.
1486         (v_alias_pseudo_register_collect): New function.
1487         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1488         (rs6000_gdbarch_init): Initialize "vX" aliases as
1489         pseudo-registers.  Restore registration of
1490         rs6000_pseudo_register_reggroup_p with
1491         set_tdesc_pseudo_register_reggroup_p.
1492
1493 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1494
1495         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1496         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1497         set_gdbarch_num_pseudo_regs.
1498
1499 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1500
1501         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1502         Remove arg prefixname, add do_set and do_show.
1503         Add member functions set_list and show_list.
1504         * cli/cli-style.c (class cli_style_option): Update accordingly.
1505         (style_set_list): Move to file scope.
1506         (style_show_list): Likewise.
1507         (set_style): Call help_list.
1508         (show_style): Call cmd_show_list.
1509         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1510         Update to use the new macro.
1511
1512 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1513
1514         * ada-lang.c (_initialize_ada_language): Expand the help text
1515         for the "catch exception" command.
1516
1517 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1518
1519         * symtab.c (matching_obj_sections): Initialize obj,
1520         declare it closer to its usage.
1521
1522 2019-01-10  Tom Tromey  <tom@tromey.com>
1523
1524         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1525         (basic_inf_threads_range): Remove.
1526         (inf_threads_range, inf_non_exited_threads_range)
1527         (safe_inf_threads_range): Use next_adapter.
1528
1529 2019-01-10  Keith Seitz  <keiths@redhat.com>
1530
1531         PR gdb/23712
1532         PR symtab/23010
1533         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1534         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1535
1536 2019-01-10  Keith Seitz  <keiths@redhat.com>
1537
1538         PR gdb/23712
1539         PR symtab/23010
1540         * dictionary.c (pending_to_vector): Remove.
1541         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1542         Remove _1 suffix, replacing functions of the same name.  Update
1543         all callers.
1544         (dict_create_hashed, dict_create_hashed_expandable)
1545         (dict_create_linear, dict_create_linear_expandable, dict_free)
1546         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1547         Make functions static.
1548
1549 2019-01-10  Keith Seitz  <keiths@redhat.com>
1550
1551         PR gdb/23712
1552         PR symtab/23010
1553         * dictionary.h (struct dictionary): Replace declaration with
1554         multidictionary.
1555         (dict_create_hashed, dict_create_hashed_expandable)
1556         (dict_create_linear, dict_create_linear_expandable)
1557         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1558         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1559         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1560         taking multidictionary argument.
1561         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1562         * block.h (struct block) <dict>: Change to multidictionary
1563         and rename `multidict'.
1564         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1565         symmisc.c: Update all dictionary references to multidictionary.
1566
1567 2019-01-10  Keith Seitz  <keiths@redhat.com>
1568
1569         PR gdb/23712
1570         PR symtab/23010
1571         * dictionary.c: Include unordered_map.
1572         (pending_to_vector): New function.
1573         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1574         Rewrite the non-"_1" functions to take vector instead
1575         of linked list.
1576         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1577         "new" _1 versions of the same name.
1578         (multidictionary): Define.
1579         (std::hash<enum language): New definition.
1580         (collate_pending_symbols_by_language, mdict_create_hashed)
1581         (mdict_create_hashed_expandable, mdict_create_linear)
1582         (mdict_create_linear_expandable, mdict_free)
1583         (find_language_dictionary, create_new_language_dictionary)
1584         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1585         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1586         (mdict_size, mdict_empty): New functions.
1587         * dictionary.h (mdict_iterator): Define.
1588
1589 2019-01-10  Pedro Alves  <palves@redhat.com>
1590
1591         * breakpoint.c (read_uploaded_action)
1592         (create_tracepoint_from_upload): Adjust to use
1593         gdb::unique_xmalloc_ptr.
1594         * ctf.c (ctf_write_uploaded_tp):
1595         (SET_ARRAY_FIELD): Use emplace_back.
1596         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1597         * tracefile-tfile.c (tfile_write_uploaded_tp):
1598         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1599         gdb::unique_xmalloc_ptr.
1600         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1601         at_string, cond_string, cmd_strings>: Replace char pointers
1602         with gdb::unique_xmalloc_ptr.
1603
1604 2019-01-10  Pedro Alves  <palves@redhat.com>
1605
1606         * solib-target.c (library_list_start_library): Don't xstrdup name.
1607
1608 2019-01-10  Pedro Alves  <palves@redhat.com>
1609
1610         * mdebugread.c (parse_partial_symbols): Use
1611         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1612
1613 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1614
1615         * linux-fork.c (scoped_switch_fork_info)
1616         <~scoped_switch_fork_info>: Fix incorrect variable name.
1617
1618 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1619
1620         * linux-fork.c (scoped_switch_fork_info)
1621         <scoped_switch_fork_info>: Make explicit.
1622         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1623
1624 2019-01-10  Tom Tromey  <tom@tromey.com>
1625
1626         * objfiles.h (objfile::reset_psymtabs): Update.
1627         * objfiles.c (objfile::objfile): Update.
1628         * psymtab.h (psymtab_storage::obstack): Update.
1629         (psymtab_storage::m_obstack): Use gdb::optional.
1630         (class psymtab_storage): Update comment.  Remove objfile
1631         parameter.
1632         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1633
1634 2019-01-10  Tom Tromey  <tom@tromey.com>
1635
1636         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1637         <free_psymtabs>: Now private.
1638         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1639         (allocate_psymtab): Use new method.
1640
1641 2019-01-10  Tom Tromey  <tom@tromey.com>
1642
1643         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1644         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1645         * mdebugread.c (parse_partial_symbols): Use
1646         allocate_dependencies.
1647         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1648         allocate_dependencies.
1649         (process_psymtab_comp_unit_reader)
1650         (build_type_psymtab_dependencies): Likewise.
1651         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1652
1653 2019-01-10  Tom Tromey  <tom@tromey.com>
1654
1655         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1656         PSYMBOL_SET_LANGUAGE.
1657         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1658
1659 2019-01-10  Tom Tromey  <tom@tromey.com>
1660
1661         * psymtab.h (psymtab_storage::obstack): New method.
1662         <m_obstack>: Rename from obstack; now private.
1663         * psymtab.c (psymtab_storage): Update.
1664         * dwarf2read.c (create_addrmap_from_index)
1665         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1666         Update.
1667
1668 2019-01-10  Tom Tromey  <tom@tromey.com>
1669
1670         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1671         * objfiles.h (objfile::reset_psymtabs): New method.
1672
1673 2019-01-10  Tom Tromey  <tom@tromey.com>
1674
1675         * symmisc.c (print_symbol_bcache_statistics): Update.
1676         (print_objfile_statistics): Update.
1677         * symfile.c (reread_symbols): Update.
1678         * psymtab.h (class psymtab_storage): New.
1679         * psymtab.c (psymtab_storage): New constructor.
1680         (~psymtab_storage): New destructor.
1681         (require_partial_symbols): Update.
1682         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1683         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1684         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1685         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1686         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1687         (start_psymtab_common, end_psymtab_common)
1688         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1689         (allocate_psymtab): Update.
1690         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1691         Update.
1692         (dump_psymtab_addrmap, maintenance_print_psymbols)
1693         (maintenance_check_psymtabs): Update.
1694         (class objfile_psymtabs): Move to objfiles.h.
1695         * psympriv.h (discard_psymtab): Now inline.
1696         (psymtab_discarder::psymtab_discarder): Update.
1697         (psymtab_discarder::~psymtab_discarder): Update.
1698         (ALL_OBJFILE_PSYMTABS): Rewrite.
1699         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1700         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1701         Remove fields.
1702         <partial_symtabs>: New field.
1703         (class objfile_psymtabs): Move from psymtab.h.  Update.
1704         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1705         psymbol_cache.
1706         (objfile::~objfile): Don't destroy psymbol_cache.
1707         * mdebugread.c (parse_partial_symbols): Update.
1708         * dwarf2read.c (create_addrmap_from_index)
1709         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1710         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1711         (add_partial_subprogram, dwarf2_ranges_read): Update.
1712         * dwarf-index-write.c (write_address_map)
1713         (write_one_signatured_type, recursively_write_psymbols)
1714         (class debug_names, class debug_names, write_psymtabs_to_index):
1715         Update.
1716
1717 2019-01-10  Tom Tromey  <tom@tromey.com>
1718
1719         * symtab.h (SYMBOL_SET_NAMES): Update.
1720         (symbol_set_names): Update.
1721         (MSYMBOL_SET_NAMES): Update.
1722         * symtab.c (symbol_set_names): Change argument to be an
1723         objfile_per_bfd_storage.
1724         * psymtab.c (add_psymbol_to_bcache): Update.
1725         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1726
1727 2019-01-10  Tom Tromey  <tom@tromey.com>
1728
1729         * symtab.c (create_demangled_names_hash): Change argument to be an
1730         objfile_per_bfd_storage.
1731         (symbol_set_names): Update.
1732
1733 2019-01-10  Tom Tromey  <tom@tromey.com>
1734
1735         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1736         init_psymbol_list.
1737         * psymtab.c (init_psymbol_list): Do nothing if already called.
1738         * psympriv.h (init_psymbol_list): Add comment.
1739         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1740         init_psymbol_list.
1741         * dbxread.c (dbx_symfile_read): Unconditionally call
1742         init_psymbol_list.
1743
1744 2019-01-10  Tom Tromey  <tom@tromey.com>
1745
1746         * xcoffread.c (scan_xcoff_symtab): Update.
1747         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1748         "where".
1749         * mdebugread.c (parse_partial_symbols)
1750         (handle_psymbol_enumerators): Update.
1751         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1752         * dbxread.c (read_dbx_symtab): Update.
1753         * psympriv.h (psymbol_placement): New enum.
1754         (add_psymbol_to_list): Update.
1755
1756 2019-01-10  Tom Tromey  <tom@tromey.com>
1757
1758         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1759         static_psymbols parameters.
1760         (scan_xcoff_symtab): Update.
1761         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1762         static_psymbols parameters.
1763         * psympriv.h (start_psymtab_common): Update.
1764         * mdebugread.c (parse_partial_symbols): Update.
1765         * dwarf2read.c (create_partial_symtab): Update.
1766         * dbxread.c (read_dbx_symtab): Update.
1767         (start_psymtab): Remove global_psymbols and static_psymbols
1768         parameters.
1769
1770 2019-01-10  Tom Tromey  <tom@tromey.com>
1771
1772         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1773         * psymtab.c (allocate_psymtab): Add comment.
1774         * psympriv.h (allocate_psymtab): Add comment.
1775         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1776         initializations.
1777         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1778
1779 2019-01-10  Tom Tromey  <tom@tromey.com>
1780
1781         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1782         Don't declare.
1783         * mipsread.c: Include mdebugread.h.
1784         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1785         Declare.
1786         * elfread.c: Include mdebugread.h.
1787
1788 2019-01-09  Tom Tromey  <tom@tromey.com>
1789
1790         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1791         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1792         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1793         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1794         (psym_lookup_symbol, psym_find_last_source_symtab)
1795         (psym_forget_cached_source_info, psym_print_stats)
1796         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1797         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1798         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1799         (psym_find_compunit_symtab_by_address)
1800         (maintenance_print_psymbols, maintenance_info_psymtabs)
1801         (maintenance_check_psymtabs): Use ranged for.
1802         * psymtab.h (class objfile_psymtabs): New.
1803         (require_partial_symbols): Return objfile_psymtabs.
1804         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1805
1806 2019-01-09  Tom Tromey  <tom@tromey.com>
1807
1808         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1809         (find_pc_mapped_section, list_overlays_command)
1810         (map_overlay_command, unmap_overlay_command)
1811         (simple_overlay_update): Use all_objfiles.
1812         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1813         * printcmd.c (info_symbol_command): Use all_objfiles.
1814         * objfiles.h (ALL_OBJSECTIONS): Remove.
1815         * maint.c (maintenance_translate_address): Use all_objfiles.
1816         * gcore.c (gcore_create_callback): Use all_objfiles.
1817         (objfile_find_memory_regions): Likewise.
1818
1819 2019-01-09  Tom Tromey  <tom@tromey.com>
1820
1821         * symtab.c (find_line_symtab, info_sources_command)
1822         (make_source_files_completion_list): Use objfile_compunits.
1823         * source.c (select_source_symtab): Use objfile_compunits.
1824         * objfiles.h (struct objfile): Update comment.
1825         (ALL_OBJFILES): Remove.
1826         (ALL_FILETABS): Remove.
1827         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1828         objfile_compunits.
1829
1830 2019-01-09  Tom Tromey  <tom@tromey.com>
1831
1832         * symmisc.c (print_objfile_statistics, dump_objfile)
1833         (maintenance_print_symbols): Use compunit_filetabs.
1834         * source.c (forget_cached_source_info_for_objfile): Use
1835         compunit_filetabs.
1836         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1837         (ALL_FILETABS): Use compunit_filetabs.
1838         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1839         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1840
1841 2019-01-09  Tom Tromey  <tom@tromey.com>
1842
1843         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1844         (compunit_filetabs): New.
1845         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1846         compunit_filetabs.
1847         (info_sources_command, make_source_files_completion_list): Remove
1848         declaration.
1849         * symmisc.c (print_objfile_statistics, dump_objfile)
1850         (maintenance_print_symbols): Remove declaration.
1851         (maintenance_info_symtabs): Use compunit_filetabs.
1852         (maintenance_info_line_tables): Likewise.
1853         * source.c (select_source_symtab): Change local variable name.
1854         (forget_cached_source_info_for_objfile): Remove declaration.
1855         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1856         * objfiles.c (objfile_relocate1): Remove declaration.
1857         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1858         declaration.
1859         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1860         * coffread.c (coff_symtab_read): Remove declaration.
1861         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1862         compunit_filetabs.
1863
1864 2019-01-09  Tom Tromey  <tom@tromey.com>
1865
1866         * symtab.c (lookup_objfile_from_block)
1867         (find_pc_sect_compunit_symtab, search_symbols)
1868         (default_collect_symbol_completion_matches_break_on): Use
1869         objfile_compunits.
1870         * objfiles.h (ALL_COMPUNITS): Remove.
1871         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1872         * cp-support.c (add_symbol_overload_list_qualified): Use
1873         objfile_compunits.
1874         * ada-lang.c (ada_collect_symbol_completion_matches)
1875         (ada_add_global_exceptions): Use objfile_compunits.
1876
1877 2019-01-09  Tom Tromey  <tom@tromey.com>
1878
1879         * source.c (select_source_symtab)
1880         (forget_cached_source_info_for_objfile): Remove declaration.
1881         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1882         declaration.
1883         * maint.c (count_symtabs_and_blocks): Remove declaration.
1884         * cp-support.c (add_symbol_overload_list_qualified): Remove
1885         declaration.
1886         * coffread.c (coff_symtab_read): Remove declaration.
1887         * symtab.c (lookup_symbol_in_objfile_symtabs)
1888         (basic_lookup_transparent_type_1): Use objfile_compunits.
1889         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
1890         (info_sources_command, search_symbols)
1891         (default_collect_symbol_completion_matches_break_on)
1892         (make_source_files_completion_list): Remove declaration.
1893         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
1894         (ada_collect_symbol_completion_matches)
1895         (ada_add_global_exceptions): Remove declaration.
1896         * linespec.c (iterate_over_all_matching_symtabs): Use
1897         objfile_compunits.
1898         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
1899         (class objfile_compunits): New.
1900         (ALL_COMPUNITS): Use objfile_compunits.
1901         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
1902         (maintenance_check_symtabs, maintenance_info_line_tables): Use
1903         objfile_compunits.
1904         * objfiles.c (objfile_relocate1): Use objfile_compunits.
1905
1906 2019-01-09  Tom Tromey  <tom@tromey.com>
1907
1908         * symtab.c (search_symbols)
1909         (default_collect_symbol_completion_matches_break_on): Use
1910         objfile_msymbols.
1911         * ada-lang.c (ada_lookup_simple_minsym)
1912         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
1913         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
1914         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
1915         objfile_msymbols.
1916         * coffread.c (coff_symfile_read): Use objfile_msymbols.
1917         * symmisc.c (dump_msymbols): Use objfile_msymbols.
1918         * objc-lang.c (find_methods): Use objfile_msymbols.
1919         (info_selectors_command, info_classes_command): Likewise.
1920         * stabsread.c (scan_file_globals): Use objfile_msymbols.
1921         * objfiles.h (class objfile_msymbols): New.
1922         (ALL_OBJFILE_MSYMBOLS): Remove.
1923         (ALL_MSYMBOLS): Remove.
1924
1925 2019-01-09  Tom Tromey  <tom@tromey.com>
1926
1927         * common/next-iterator.h (next_adapter): Add Iterator template
1928         parameter.
1929         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
1930         (class all_objfiles_safe): New.
1931         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
1932         * objfiles.c (put_objfile_before): Update comment.
1933         (add_separate_debug_objfile): Likewise.
1934         (free_all_objfiles): Use all_objfiles_safe.
1935         (objfile_purge_solibs): Likewise.
1936
1937 2019-01-09  Tom Tromey  <tom@tromey.com>
1938
1939         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1940         (expand_symtab_containing_pc, lookup_static_symbol)
1941         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
1942         (find_symbol_at_address, find_line_symtab, find_main_name): Use
1943         all_objfiles.
1944         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
1945         * breakpoint.c (create_overlay_event_breakpoint)
1946         (create_longjmp_master_breakpoint)
1947         (create_std_terminate_master_breakpoint)
1948         (create_exception_master_breakpoint): Use all_objfiles.
1949         * linux-thread-db.c (try_thread_db_load_from_pdir)
1950         (has_libpthread): Use all_objfiles.
1951         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
1952         * linespec.c (iterate_over_all_matching_symtabs)
1953         (search_minsyms_for_name): Use all_objfiles.
1954         * maint.c (maintenance_info_sections): Use all_objfiles.
1955         * main.c (captured_main_1): Use all_objfiles.
1956         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
1957         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
1958         * guile/scm-pretty-print.c
1959         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
1960         * solib-spu.c (append_ocl_sos): Use all_objfiles.
1961         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
1962         (maintenance_print_msymbols): Use all_objfiles.
1963         * source.c (select_source_symtab): Use all_objfiles.
1964         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
1965         * symfile.c (remove_symbol_file_command)
1966         (expand_symtabs_matching, map_symbol_filenames): Use
1967         all_objfiles.
1968         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
1969         all_objfiles.
1970         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
1971         * objc-lang.c (find_methods): Use all_objfiles.
1972         * objfiles.c (have_partial_symbols, have_full_symbols)
1973         (have_minimal_symbols, qsort_cmp)
1974         (default_iterate_over_objfiles_in_search_order): Use
1975         all_objfiles.
1976         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
1977         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
1978         (maintenance_check_psymtabs): Use all_objfiles.
1979         (ALL_PSYMTABS): Remove.
1980         * compile/compile-object-run.c (do_module_cleanup): Use
1981         all_objfiles.
1982         * blockframe.c (find_pc_partial_function): Use all_objfiles.
1983         * cp-support.c (add_symbol_overload_list_qualified): Use
1984         all_objfiles.
1985         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1986         Use all_objfiles.
1987         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
1988         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
1989         all_objfiles.
1990         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1991         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
1992         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1993         Uses all_objfiles.
1994         * solib.c (solib_read_symbols): Use all_objfiles
1995
1996 2019-01-09  Tom Tromey  <tom@tromey.com>
1997
1998         * probe.c (parse_probes_in_pspace): Use all_objfiles.
1999         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2000         all_objfiles.
2001         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2002         * symmisc.c (print_symbol_bcache_statistics)
2003         (print_objfile_statistics, maintenance_print_objfiles)
2004         (maintenance_info_symtabs, maintenance_check_symtabs)
2005         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2006         all_objfiles.
2007         * source.c (forget_cached_source_info): Use all_objfiles.
2008         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2009         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2010         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2011         * objfiles.c (update_section_map): Use all_objfiles.
2012         (shared_objfile_contains_address_p): Likewise.
2013         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2014         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2015
2016 2019-01-09  Tom Tromey  <tom@tromey.com>
2017
2018         * common/next-iterator.h: New file.
2019         * objfiles.h (class all_objfiles): New.
2020         (struct objfile_iterator): New.
2021
2022 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2023
2024         * NEWS: Move the description of the changed "frame", "select-frame",
2025          and "info frame" commands to the Changed commands section.
2026
2027 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2028
2029         * gdbtypes.c (check_stub_method_group): Remove handling of old
2030         mangling schemes.
2031         * linespec.c (find_methods): Likewise.
2032         * stabsread.c (read_member_functions): Likewise.
2033         * valops.c (search_struct_method): Likewise.
2034         (value_struct_elt_for_reference): Likewise.
2035         * NEWS: Mention this change.
2036
2037 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2038
2039         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2040         print_source_lines.
2041         * source.c (print_source_lines_base): Update line number check.
2042         (print_source_lines): New function.
2043         (source_lines_range::source_lines_range): New function.
2044         * source.h (class source_lines_range): New class.
2045         (print_source_lines): New declaration.
2046
2047 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2048
2049         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2050
2051 2019-01-08  Tom Tromey  <tom@tromey.com>
2052             Simon Marchi  <simon.marchi@ericsson.com>
2053
2054         PR gdb/24060
2055         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2056         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2057         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2058         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2059         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2060         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2061
2062 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2063
2064         * source.c (select_source_symtab): Move header comment to
2065         declaration in source.h.
2066         (forget_cached_source_info_for_objfile): Likewise.
2067         (forget_cached_source_info): Likewise.
2068         (identify_source_line): Likewise.
2069         * source.h (identify_source_line): Move declaration from symtab.h
2070         and add comment from source.c
2071         (print_source_lines): Likewise.
2072         (forget_cached_source_info_for_objfile): Likewise.
2073         (forget_cached_source_info): Likewise.
2074         (select_source_symtab): Likewise.
2075         (enum print_source_lines_flag): Move definition from symtab.h.
2076         * symtab.h (identify_source_line): Move declaration to source.h.
2077         (print_source_lines): Likewise.
2078         (forget_cached_source_info_for_objfile): Likewise.
2079         (forget_cached_source_info): Likewise.
2080         (select_source_symtab): Likewise.
2081         (enum print_source_lines_flag): Move definition to source.h.
2082         * tui/tui-hooks.c: Add 'source.h' include.
2083
2084 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2085
2086         * source.c (print_source_lines_base): Handle requests to print
2087         reverse line number sequences, and guard against empty lines
2088         string.
2089
2090 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2091
2092         * source.c (print_source_lines_base): Fix skip of '\r' if next
2093         character is '\n'.
2094
2095 2019-01-06  Tom Tromey  <tom@tromey.com>
2096
2097         * c-exp.y (struct c_parse_state) <macro_original_text,
2098         expansion_obstack>: New member.
2099         (macro_original_text, expansion_obstack): Remove globals.
2100         (scan_macro_expansion, scanning_macro_expansion)
2101         (finished_macro_expansion): Update.
2102         (scan_macro_cleanup): Remove.
2103         (yylex, c_parse): Update.
2104
2105 2019-01-06  Tom Tromey  <tom@tromey.com>
2106
2107         * c-exp.y (struct c_parse_state) <strings>: New member.
2108         (operator_stoken): Update.
2109
2110 2019-01-06  Tom Tromey  <tom@tromey.com>
2111
2112         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2113         (union type_stack_elt) <typelist_val>: Now a pointer to
2114         std::vector.
2115         (type_stack_cleanup): Don't declare.
2116         (push_typelist): Update.
2117         * parse.c (pop_typelist): Return a std::vector.
2118         (push_typelist): Take a std::vector.
2119         (follow_types): Update.  Do not free args.
2120         (type_stack_cleanup): Remove.
2121         * c-exp.y (struct c_parse_state): New.
2122         (cpstate): New global.
2123         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2124         (nonempty_typelist): Update.
2125         (func_mod): Create a new vector.
2126         (c_parse): Create a c_parse_state.
2127         (check_parameter_typelist): Do not delete params.
2128         (function_method): Update.  Do not delete type_list.
2129
2130 2019-01-06  Tom Tromey  <tom@tromey.com>
2131
2132         PR gdb/28155:
2133         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2134         check_typedef.
2135         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2136         (print_return_value): Likewise.
2137
2138 2019-01-05  Tom Tromey  <tom@tromey.com>
2139
2140         * contrib/cleanup_check.py: Remove.
2141         * contrib/gcc-with-excheck: Remove.
2142         * contrib/exsummary.py: Remove.
2143         * contrib/excheck.py: Remove.
2144
2145 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2146
2147         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2148         NULL. Initialize tpprev to NULL instead of assigning it
2149         to NULL on the next statement.
2150         * windows-nat.c (windows_delete_thread): Remove check for
2151         main_thread_id before printing thread exit notifications.
2152         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2153         Remove thread ID check against main_thread_id.
2154         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2155         windows_delete_thread.
2156         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2157
2158 2019-01-04  Tom Tromey  <tom@tromey.com>
2159
2160         * compile/compile.c (_initialize_compile): Use upper case for
2161         metasyntactic variables.
2162         * symmisc.c (_initialize_symmisc): Use upper case for
2163         metasyntactic variables.
2164         * psymtab.c (_initialize_psymtab): Use upper case for
2165         metasyntactic variables.
2166         * demangle.c (demangle_command): Use upper case for metasyntactic
2167         variables.
2168         (_initialize_demangler): Likewise.
2169         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2170         variables.
2171
2172 2019-01-03  Tom Tromey  <tom@tromey.com>
2173
2174         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2175
2176 2019-01-03  Tom Tromey  <tom@tromey.com>
2177
2178         * python/py-symtab.c (salpy_str): Update.
2179         (struct salpy_sal_object) <symtab>: Now a PyObject.
2180         (salpy_dealloc): Update.
2181         (del_objfile_sal): Use gdbpy_ref.
2182
2183 2019-01-03  Tom Tromey  <tom@tromey.com>
2184
2185         * python/py-type.c (convert_field): Use new_reference.  Return
2186         gdbpy_ref.
2187         (make_fielditem): Return gdbpy_ref.
2188         (typy_fields): Update.
2189         (typy_getitem): Update.
2190         (field_name): Return gdbpy_ref.  Use new_reference.
2191         (typy_iterator_iternext): Update.
2192
2193 2019-01-03  Tom Tromey  <tom@tromey.com>
2194
2195         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2196
2197 2019-01-03  Tom Tromey  <tom@tromey.com>
2198
2199         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2200         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2201         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2202         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2203         (pspy_set_type_printers): Likewise.
2204         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2205         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2206         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2207         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2208         (objfpy_set_type_printers): Likewise.
2209
2210 2019-01-03  Tom Tromey  <tom@tromey.com>
2211
2212         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2213         (gdbpy_print_stack): Use gdbpy_err_fetch.
2214         * python/python-internal.h (class gdbpy_err_fetch): New class.
2215         (class gdbpy_enter) <m_error_type, m_error_value,
2216         m_error_traceback>: Remove.
2217         <m_error>: New member.
2218         (gdbpy_exception_to_string): Don't declare.
2219         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2220         * python/py-value.c (convert_value_from_python): Use
2221         gdbpy_err_fetch.
2222         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2223         gdbpy_exception_to_string.
2224         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2225         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2226         gdbpy_err_fetch.
2227
2228 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2229
2230         * linux-nat.c (delete_lwp_cleanup): Delete.
2231         (struct lwp_deleter): New struct.
2232         (lwp_info_up): New typedef.
2233         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2234         lwp_info_up.
2235
2236 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2237
2238         * linux-fork.c (class scoped_switch_fork_info): New class.
2239         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2240
2241 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2242
2243         * valops.c (find_overload_match): Remove use of null_cleanup, and
2244         calls to do_cleanups.
2245
2246 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2247
2248         * compile/compile-cplus-types.c
2249         (compile_cplus_instance::decl_name): Handle changes to
2250         cp_func_name.
2251         * cp-support.c (cp_func_name): Update header comment, update
2252         return type.
2253         * cp-support.h (cp_func_name): Update return type in declaration.
2254         * valops.c (find_overload_match): Move temp_func local to top
2255         level of function and change its type.  Use temp_func to hold and
2256         delete temporary string obtained from cp_func_name.
2257
2258 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2259
2260         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2261         gdb::char_vector, remove cleanup, and update uses of `msg`.
2262
2263 2019-01-03  Jim Wilson  <jimw@sifive.com>
2264
2265         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2266
2267 2019-01-02  Tom Tromey  <tom@tromey.com>
2268
2269         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2270         (tdesc_parse_xml): Remove cleanups.
2271         * target-descriptions.h (make_cleanup_free_target_description):
2272         Don't declare.
2273         (target_desc_deleter): New struct.
2274         (target_desc_up): New typedef.
2275         * target-descriptions.c (target_desc_deleter::operator()): Rename
2276         from free_target_description.
2277         (make_cleanup_free_target_description): Remove.
2278
2279 2019-01-02  Tom Tromey  <tom@tromey.com>
2280
2281         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2282         constructor, destructor.
2283         (linespec_parser): Remove typedef.
2284         (~linespec_parser): Rename from linespec_parser_delete.
2285         (linespec_lex_to_end, linespec_complete_label)
2286         (linespec_complete): Update.
2287         (decode_line_full): Remove cleanups.
2288         (decode_line_1): Update.
2289
2290 2019-01-02  Tom Tromey  <tom@tromey.com>
2291
2292         * python/python-internal.h (inferior_to_inferior_object): Change
2293         return type.
2294         * python/py-exitedevent.c (create_exited_event_object): Update.
2295         * python/py-inferior.c (inferior_to_inferior_object): Return
2296         gdbpy_ref.
2297         (python_new_inferior, python_inferior_deleted)
2298         (thread_to_thread_object, delete_thread_object)
2299         (build_inferior_list, gdbpy_selected_inferior): Update.
2300         * python/py-infthread.c (create_thread_object): Update.  Also fail
2301         if inferior_to_inferior_object fails.
2302
2303 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2304
2305         * inferior.h (class inferior) <displaced_step_state>: New field.
2306         * infrun.h (struct displaced_step_state): Move here from
2307         infrun.c.  Initialize fields, add constructor.
2308         <inf>: Remove field.
2309         <reset>: New method.
2310         * infrun.c (struct displaced_step_inferior_state): Move to
2311         infrun.h.
2312         (displaced_step_inferior_states): Remove.
2313         (get_displaced_stepping_state): Adust.
2314         (displaced_step_in_progress_any_inferior): Adjust.
2315         (displaced_step_in_progress_thread): Adjust.
2316         (displaced_step_in_progress): Adjust.
2317         (add_displaced_stepping_state): Remove.
2318         (get_displaced_step_closure_by_addr): Adjust.
2319         (remove_displaced_stepping_state): Remove.
2320         (infrun_inferior_exit): Call displaced_step_state.reset.
2321         (use_displaced_stepping): Don't check for NULL.
2322         (displaced_step_prepare_throw): Call
2323         get_displaced_stepping_state.
2324         (displaced_step_fixup): Don't check for NULL.
2325         (prepare_for_detach): Don't check for NULL.
2326
2327 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2328
2329         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2330          in case of call that did not complete.
2331
2332 2019-01-02  Andrey Utkin  <autkin@undo.io>
2333
2334         * symfile.c (find_separate_debug_file): Fix search of debug files for
2335         remote debuggee.
2336
2337 2019-01-02  Tom Tromey  <tom@tromey.com>
2338
2339         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2340         indentation.
2341         * python/py-frame.c (frapy_older): Remove cast.
2342         (frapy_newer): Likewise.
2343         * python/py-breakpoint.c (local_setattro): Remove cast.
2344         * python/py-arch.c (archpy_name): Remove local variable.
2345         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2346
2347 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2348
2349         * unittests/basic_string_view/element_access/char/empty.cc:
2350         Fix year range in copyright header.
2351
2352 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2353
2354         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2355         Delete.
2356         <operator==>: Update with for removed field.
2357         <hash>: Likewise.
2358         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2359         <isa_features>: ...this.
2360         <abi_features>: New field.
2361         (riscv_isa_flen): Update comment.
2362         (riscv_abi_xlen): New declaration.
2363         (riscv_abi_flen): New declaration.
2364         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2365         isa_features.
2366         (riscv_abi_xlen): New function.
2367         (riscv_isa_flen): Update to get answer from isa_features.
2368         (riscv_abi_flen): New function.
2369         (riscv_has_fp_abi): Update to get answer from abi_features.
2370         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2371         xlen and flen.
2372         (riscv_call_info) <xlen, flen>: Update comment.
2373         (riscv_call_arg_struct): Remove invalid assertions
2374         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2375         is removed.
2376         (riscv_gdbarch_init): Gather isa features and abi features
2377         separately, ensure both match on the gdbarch when reusing an old
2378         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2379         a target with 64-bit float hardware.
2380
2381 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2382
2383         * source.c (search_command_helper): Stop reverse search
2384         when line 1 has been searched.
2385
2386 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2387
2388         * record-full.c (record_full_base_target::close): Rewrite
2389         record_full_core_buf_list free logic.
2390
2391 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2392
2393         * break-catch-syscall.c (print_one_catch_syscall): xfree
2394         the last text.
2395
2396 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2397
2398         * top.c (print_gdb_version): Update Copyright year in version
2399         message.
2400
2401 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2402
2403         Update copyright year range in all GDB files.
2404
2405 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2406
2407         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2408
2409 For older changes see ChangeLog-2018.
2410 \f
2411 Local Variables:
2412 mode: change-log
2413 left-margin: 8
2414 fill-column: 74
2415 version-control: never
2416 coding: utf-8
2417 End:
2418