gdb: Don't skip prologue for explicit line breakpoints in assembler
[external/binutils.git] / gdb / ChangeLog
1 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2
3         * linespec.c (decode_digits_list_mode): Set explicit_line to a
4         bool value.
5         (decode_digits_ordinary): Set explicit_line field in sal.
6         * symtab.c (skip_prologue_sal): Don't skip prologue for a
7         symtab_and_line that was set on an explicit line number in
8         assembler code.  Do always update the recorded symtab and line if
9         we do skip the prologue.
10
11 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
12
13         * breakpoint.c (set_breakpoint_location_function): Remove
14         explicit_loc parameter.
15         (momentary_breakpoint_from_master): Update call to
16         set_breakpoint_location_function.
17         (add_location_to_breakpoint): Likewise.
18
19 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
20
21         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
22         required features based on default bfd type when no specific bfd
23         is present.
24
25 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
26
27         * NEWS: Mention that GDB printf and eval commands can now print
28         C-style and Ada-style convenience var strings without
29         calling the inferior.
30         * printcmd.c (printf_c_string): Locally print GDB internal var
31         instead of transiting via the inferior.
32         (printf_wide_c_string): Likewise.
33
34 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
35
36         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
37
38 2019-07-04  Tom Tromey  <tom@tromey.com>
39
40         PR tui/24724:
41         * tui/tui-winsource.c (tui_clear_source_content): Update.
42         (tui_source_window_base::set_is_exec_point_at): Fix comment.
43         (tui_update_breakpoint_info): Update.
44         (tui_set_exec_info_content): Update.
45         * tui/tui-source.c (tui_set_source_content_nil): Update.
46         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
47         has_break.
48         * tui/tui-data.h (enum tui_bp_flag): New.
49         (tui_bp_flags): New enum flags type.
50         (struct tui_source_element) <break_mode>: Change type.  Rename
51         from has_break.
52         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
53         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
54         constants.
55         * tui/tui-winsource.h: Fix comment.
56
57 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
58
59         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
60         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
61         (store_fpregs_to_thread)
62         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
63         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
64         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
65         (IWMMXT_REGS_SIZE): Add define.
66         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
67         (fetch_vfp_regs, store_vfp_regs)
68         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
69         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
70
71 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
72
73         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
74         defines.
75         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
76         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
77         (ARM_INT_REGISTER_SIZE): ...to this.
78         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
79         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
80         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
81         (arm_linux_collect_gregset, supply_nwfpe_register)
82         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
83         defines.
84         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
85         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
86         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
87         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
88         (arm_return_in_memory, arm_store_return_value)
89         (arm_get_longjmp_target, arm_register_g_packet_guesses)
90         (arm_record_ld_st_multiple): Likewise.
91         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
92         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
93
94 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
95
96         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
97         AARCH64_DISPLACED_MODIFIED_INSNS.
98         * aarch64-tdep.c (struct aarch64_displaced_step_data)
99         (aarch64_displaced_step_copy_insn): Likewise.
100         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
101         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
102         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
103         ARM_DISPLACED_MODIFIED_INSNS.
104         * arm-tdep.c (arm_gdbarch_init): Likewise.
105         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
106         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
107         (struct arm_displaced_step_closure): Use
108         ARM_DISPLACED_MODIFIED_INSNS.
109
110 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
111
112         * features/Makefile: Remove unused xml files.
113         * features/aarch64.xml: Remove.
114         * features/i386/amd64-avx-avx512-linux.xml: Remove.
115         * features/i386/amd64-avx-avx512.xml: Remove.
116         * features/i386/amd64-avx-linux.xml: Remove.
117         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
118         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
119         * features/i386/amd64-avx-mpx-linux.xml: Remove.
120         * features/i386/amd64-avx-mpx.xml: Remove.
121         * features/i386/amd64-avx.xml: Remove.
122         * features/i386/amd64-linux.xml: Remove.
123         * features/i386/amd64-mpx-linux.xml: Remove.
124         * features/i386/amd64-mpx.xml: Remove.
125         * features/i386/amd64.xml: Remove.
126         * features/i386/i386-avx-avx512-linux.xml: Remove.
127         * features/i386/i386-avx-avx512.xml: Remove.
128         * features/i386/i386-avx-linux.xml: Remove.
129         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
130         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
131         * features/i386/i386-avx-mpx-linux.xml: Remove.
132         * features/i386/i386-avx-mpx.xml: Remove.
133         * features/i386/i386-avx.xml: Remove.
134         * features/i386/i386-linux.xml: Remove.
135         * features/i386/i386-mmx-linux.xml: Remove.
136         * features/i386/i386-mmx.xml: Remove.
137         * features/i386/i386-mpx-linux.xml: Remove.
138         * features/i386/i386-mpx.xml: Remove.
139         * features/i386/i386.xml: Remove.
140         * features/i386/x32-avx-avx512-linux.xml: Remove.
141         * features/i386/x32-avx-linux.xml: Remove.
142         * features/i386/x32-linux.xml: Remove.
143
144 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
145
146         * regformats/aarch64.dat: Remove.
147         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
148         * regformats/i386/amd64-avx-linux.dat: Remove.
149         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
150         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
151         * regformats/i386/amd64-linux.dat: Remove.
152         * regformats/i386/amd64-mpx-linux.dat: Remove.
153         * regformats/i386/amd64.dat: Remove.
154         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
155         * regformats/i386/i386-avx-linux.dat: Remove.
156         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
157         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
158         * regformats/i386/i386-linux.dat: Remove.
159         * regformats/i386/i386-mmx-linux.dat: Remove.
160         * regformats/i386/i386-mpx-linux.dat: Remove.
161         * regformats/i386/i386.dat: Remove.
162         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
163         * regformats/i386/x32-avx-linux.dat: Remove.
164         * regformats/i386/x32-linux.dat: Remove.
165
166 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
167
168         * aarch64-tdep.c: Remove xml self tests.
169         * amd64-linux-tdep.c: Likewise.
170         * amd64-tdep.c: Likewise.
171         * i386-linux-tdep.c: Likewise.
172         * i386-tdep.c: Likewise.
173
174 2019-07-03  Pedro Alves  <palves@redhat.com>
175
176         PR cli/24732
177         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
178         (pipe_cmd_option_defs): New.
179         (make_pipe_cmd_options_def_group): New.
180         (pipe_command): Use gdb::option::process_options.
181         (pipe_command_completer): New function.
182         (_initialize_cli_cmds): Install completer for "pipe" command.
183
184 2019-07-03  Pedro Alves  <palves@redhat.com>
185
186         * cli/cli-option.c (union option_value) <string>: New field.
187         (struct option_def_and_value): Add ctor, move ctor, dtor and
188         use DISABLE_COPY_AND_ASSIGN.
189         (option_def_and_value::clear_value): New.
190         (parse_option, save_option_value_in_ctx, get_val_type_str)
191         (add_setshow_cmds_for_options): Handle var_string.
192         * cli-option.h (union option_def::var_address) <string>: New
193         field.
194         (struct string_option_def): New.
195         * maint-test-options.c (struct test_options_opts): Add default
196         ctor and use DISABLE_COPY_AND_ASSIGN.
197         <string_opt>: New field.
198         (test_options_opts::~test_options_opts): New.
199         (test_options_opts::dump): Also dump "-string".
200         (test_options_option_defs): Install "string.
201
202 2019-07-03  Pedro Alves  <palves@redhat.com>
203
204         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
205         option_value with a null enumeration.
206         (complete_options): Save the option values in the context.
207         (save_option_value_in_ctx): New, factored out from ...
208         (process_options): ... here.
209         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
210         of the function.
211         * maint-test-options.c (test_options_opts::dump): New, factored
212         out from ...
213         (maintenance_test_options_command_mode): ... here.
214         (maintenance_test_options_command_completion_result): Delete.
215         (maintenance_test_options_command_completion_text): Update
216         comment.
217         (maintenance_show_test_options_completion_result): Change
218         prototype.  Just print
219         maintenance_test_options_command_completion_text.
220         (save_completion_result): New.
221         (maintenance_test_options_completer_mode): Pass options context to
222         complete_options, and then save a dump.
223         (_initialize_maint_test_options): Use add_cmd to install "maint
224         show test-options-completion-result".
225
226 2019-07-03  Pedro Alves  <palves@redhat.com>
227
228         * NEWS (New commands): Mention "with" and "maint with".
229         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
230         (with_command, with_command_completer): New.
231         (pipe_command): Adjust to new repeat_previous
232         interface.
233         (_initialize_cli_cmds): Install the "with" command and its "w"
234         alias.
235         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
236         declarations.
237         * cli/cli-setshow.c (parse_cli_var_uinteger)
238         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
239         argument strings for all var_types.
240         (get_setshow_command_value_string): New, factored out from ...
241         (do_show_command): ... this.
242         * cli/cli-setshow.h: Include <string>.
243         (get_setshow_command_value_string): Declare.
244         * command.h (repeat_previous): Now returns const char *.  Adjust
245         comment.
246         * maint.c: Include "cli/cli-cmds.h".
247         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
248         (_initialize_maint_cmds): Register the "maintenance with" command.
249         * top.c (repeat_previous): Move bits from pipe_command here:
250         Return the saved command line, if any; error out if there's no
251         command to relaunch.
252
253 2019-07-03  Pedro Alves  <palves@redhat.com>
254
255         * NEWS (New commands): Mention "maint set/show test-settings"
256         instead of "maint test-settings".
257         * maint-test-settings.c (maintenance_test_settings_list): Delete.
258         (maintenance_test_settings_set_list): Rename to ...
259         (maintenance_set_test_settings_list): ... this.
260         (maintenance_test_settings_show_list): Rename to  ...
261         (maintenance_show_test_settings_list): ... this.
262         (maintenance_test_settings_cmd): Delete.
263         (maintenance_test_settings_set_cmd): ...
264         (maintenance_set_test_settings_cmd): ... this.
265         (maintenance_test_settings_show_cmd): ...
266         (maintenance_show_test_settings_cmd): ... this.
267         (maintenance_test_settings_show_value_cmd):
268         (maintenance_show_test_settings_value_cmd): ... this.
269         (_initialize_maint_test_settings): No longer install the "maint
270         test-settings" prefix command.  Rename "maint test-settings set"
271         to "maint set test-settings", and "maint test-settings show" to
272         "maint show test-settings".  Adjust all subcommands.
273
274 2019-07-03  Pedro Alves  <palves@redhat.com>
275
276         * maint-test-settings.c: Fix file's intro comment.  Replace all
277         references to "test-options" with references to "test-settings",
278         in comments.
279
280 2019-07-03  Pedro Alves  <palves@redhat.com>
281
282         * maint-test-settings.c (maintenance_test_settings_xxx)
283         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
284         New.
285         (maintenance_test_settings_enums): Use them.
286         (maintenance_test_settings_enum): Default to
287         maintenance_test_settings_xxx.
288         (_initialize_maint_test_settings): Initialize
289         MAINTENANCE_TEST_SETTINGS_FILENAME.
290
291 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
292
293         * breakpoint.h (remove_breakpoints_inf): Change return type to
294         void, move function documentation here.
295         * breakpoint.c (remove_breakpoints_inf): Change return type to
296         void, move function documentation to header.
297
298 2019-07-02  Pedro Alves  <palves@redhat.com>
299
300         * NEWS (Completion improvements): Mention "info threads".
301         * thread.c (struct info_threads_opts, info_threads_option_defs)
302         (make_info_threads_options_def_group): New.
303         (info_threads_command): Use gdb::option::process_options.
304         (info_threads_command_completer): New.
305         (_initialize_thread): Use gdb::option::build_help to build the
306         help text for "info threads".
307
308 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
309
310         * defs.h (generic_load): Move from here...
311         * symfile.h (generic_load): ... to here.  Rename name parameter
312         to args.
313         * symfile.c (generic_load): Add comment.
314
315 2019-07-01  Tom Tromey  <tromey@adacore.com>
316
317         * dwarf2read.c
318         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
319         declaration of without_params.  Fix formatting.
320
321 2019-07-01  Tom Tromey  <tromey@adacore.com>
322
323         * ada-exp.y (find_primitive_type): Update.
324         * ada-lang.h (ada_lookup_symbol): Update.
325         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
326         parameter.
327         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
328
329 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
330
331         PR breakpoints/24541
332         * gdbarch.c: Regenerate.
333         * gdbarch.h: Regenerate.
334         * gdbarch.sh: Add 'stap_adjust_register'.
335         * i386-tdep.c: Include '<unordered_set>'.
336         (i386_stap_adjust_register): New function.
337         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
338         * stap-probe.c (stap_parse_register_operand): Call
339         'gdbarch_stap_adjust_register'.
340
341 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
342
343         PR python/24742
344         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
345         * python/python.c (do_start_initialization): Use 'xmalloc'
346         instead of 'PyMem_Malloc'.
347
348 2019-06-28  Tom Tromey  <tromey@adacore.com>
349
350         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
351         for Ada.
352
353 2019-06-27  Tom Tromey  <tromey@adacore.com>
354
355         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
356         objfile_key.
357         (arm_find_mapping_symbol, arm_record_special_symbol)
358         (_initialize_arm_tdep): Update.
359         (arm_objfile_data_free): Remove.
360
361 2019-06-27  Tom Tromey  <tromey@adacore.com>
362
363         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
364         to cp_print_static_field.
365
366 2019-06-26  Tom Tromey  <tromey@adacore.com>
367
368         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
369         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
370         declare.
371
372 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
373
374         * features/aarch64-core.c (create_feature_aarch64_core):
375         Regenerate.
376         * features/aarch64-core.xml: Add cpsr flags.
377
378 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
379
380         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
381         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
382
383 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
384
385         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
386         field.
387         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
388         use.
389         (arm_record_special_symbol): Don't insert new symbol in sorted
390         position, push it at the end.
391
392 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
393
394         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
395         (arm_mapping_symbol_s): Remove.
396         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
397         (arm_mapping_symbol_vec): New typedef.
398         (struct arm_per_objfile): Add constructor.
399         <section_maps>: Change type to
400         std::unique_ptr<arm_mapping_symbol_vec[]>.
401         (arm_compare_mapping_symbols): Remove.
402         (arm_find_mapping_symbol): Adjust to section_maps type change.
403         (arm_objfile_data_free): Call delete on arm_per_objfile.
404         (arm_record_special_symbol): Adjust to section_maps type change.
405         Allocate arm_per_objfile with new.
406
407 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
408
409         * cli/cli-cmds.c (alias_command): Compare the alias prefix
410         with the command prefix.
411
412 2019-06-25  Tom Tromey  <tom@tromey.com>
413
414         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
415         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
416
417 2019-06-25  Tom Tromey  <tom@tromey.com>
418
419         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
420         type.
421         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
422         protected.
423
424 2019-06-25  Tom Tromey  <tom@tromey.com>
425
426         * tui/tui-winsource.c
427         (tui_source_window_base::set_is_exec_point_at): Add check against
428         LOA_ADDRESS.
429
430 2019-06-25  Tom Tromey  <tom@tromey.com>
431
432         * tui/tui-source.c (tui_set_source_content): Don't check before
433         xfree.
434         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
435
436 2019-06-25  Tom Tromey  <tom@tromey.com>
437
438         * tui/tui-winsource.h (tui_update_source_window_as_is)
439         (tui_alloc_source_buffer, tui_line_is_displayed)
440         (tui_addr_is_displayed): Change type of win_info.
441         * tui/tui-winsource.c (tui_update_source_window_as_is)
442         (tui_clear_source_content, tui_show_source_line)
443         (tui_show_source_content, tui_source_window_base::refill)
444         (tui_source_window_base::set_is_exec_point_at)
445         (tui_source_window_base::set_is_exec_point_at)
446         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
447         (tui_alloc_source_buffer, tui_line_is_displayed)
448         (tui_addr_is_displayed): Change type of win_info.  Update.
449         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
450         (tui_source_window_base::do_make_visible_with_new_height):
451         Update.
452         * tui/tui-source.c (tui_set_source_content)
453         (tui_set_source_content_nil)
454         (tui_source_window::do_scroll_vertical): Update.
455         * tui/tui-layout.c (show_layout): Update.
456         * tui/tui-disasm.c (tui_set_disassem_content)
457         (tui_disasm_window::do_scroll_vertical): Update.
458         * tui/tui-data.h (tui_win_content): Remove.
459         (struct tui_gen_win_info) <content, content_size>: Remove.
460         (struct tui_source_element): Add initializers and destructor.
461         (union tui_which_element, struct tui_win_element): Remove.
462         (struct tui_source_window_base) <content>: New field.
463         (struct tui_data_window): Remove destructor.
464         (tui_alloc_content, tui_free_win_content)
465         (tui_free_all_source_wins_content): Don't declare.
466         * tui/tui-data.c (tui_initialize_static_data): Update.
467         (init_content_element, tui_alloc_content): Remove.
468         (~tui_gen_win_info): Update.
469         (~tui_data_window, tui_free_all_source_wins_content)
470         (tui_free_win_content, free_content, free_content_elements):
471         Remove.
472
473 2019-06-25  Tom Tromey  <tom@tromey.com>
474
475         * tui/tui-winsource.h (tui_clear_source_content)
476         (tui_erase_source_content, tui_show_source_content): Change type
477         of win_info.
478         * tui/tui-winsource.c (tui_clear_source_content)
479         (tui_erase_source_content, tui_show_source_content): Change type
480         of win_info.
481         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
482         * tui/tui-source.h (tui_set_source_content_nil): Change type of
483         win_info.
484         * tui/tui-source.c (tui_set_source_content_nil): Change type of
485         win_info.
486         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
487
488 2019-06-25  Tom Tromey  <tom@tromey.com>
489
490         * tui/tui-winsource.c (tui_clear_source_content)
491         (tui_source_window_base::set_is_exec_point_at): Update.
492         * tui/tui-source.c (tui_set_source_content_nil): Update.
493         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
494         a bool.
495         * tui/tui-data.c (init_content_element): Update.
496
497 2019-06-25  Tom Tromey  <tom@tromey.com>
498
499         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
500         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
501         * tui/tui-layout.c (init_and_make_win): Update.
502         * tui/tui.h (enum tui_win_type): Update.
503         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
504         tui_win_is_auxillary.
505         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
506         tui_win_is_auxillary.
507
508 2019-06-25  Tom Tromey  <tom@tromey.com>
509
510         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
511         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
512         (tui_delete_data_content_windows, tui_display_all_data)
513         (tui_data_window::do_scroll_vertical, tui_display_data_from):
514         Update.
515         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
516         * tui/tui-regs.c (tui_last_regs_line_no)
517         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
518         (tui_show_registers): Update.
519         (tui_show_register_group): Return void.  Update.
520         (tui_display_registers_from, tui_display_reg_element_at_line)
521         (tui_display_registers_from_line, tui_check_register_values):
522         Update.
523         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
524         member.
525         (struct tui_data_window) <regs_content>: Now a std::vector.
526         <regs_content_count>: Remove.
527         (tui_add_content_elements, tui_free_data_content): Don't declare.
528         * tui/tui-data.c (tui_data_window::clear_detail): Update.
529         (init_content_element): Remove DATA_WIN case.  Add assert.
530         (tui_add_content_elements): Remove.
531         (tui_data_window): Update.
532         (tui_free_data_content): Remove.
533         (free_content_elements): Remove DATA_WIN case.
534
535 2019-06-25  Tom Tromey  <tom@tromey.com>
536
537         * tui/tui-data.c (tui_data_item_window): Update.
538         * tui/tui-windata.h (tui_check_data_values): Don't declare.
539         * tui/tui-windata.c (tui_display_all_data)
540         (tui_display_data_from_line): Update.
541         (tui_check_data_values): Remove.
542         * tui/tui-regs.c (tui_show_register_group)
543         (tui_display_reg_element_at_line): Update.
544         * tui/tui-hooks.c (tui_register_changed)
545         (tui_refresh_frame_and_register_information): Call
546         tui_check_register_values.
547         * tui/tui-data.h (struct tui_data_window) <data_content,
548         data_content_count, data_type>: Remove.
549         (enum tui_data_type): Remove.
550
551         * tui/tui-data.c (tui_data_window::clear_detail)
552         (~tui_data_window): Update.
553
554 2019-06-25  Tom Tromey  <tom@tromey.com>
555
556         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
557         declare.
558         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
559         Rename from tui_first_data_item_displayed.  Update.
560         (tui_data_window::refresh_all)
561         (tui_data_window::do_scroll_vertical): Update.
562         * tui/tui-data.h (struct tui_data_window)
563         <first_data_item_displayed>: Declare new method.
564
565 2019-06-25  Tom Tromey  <tom@tromey.com>
566
567         * tui/tui-data.h (tui_init_generic_part): Don't declare.
568         * tui/tui-data.c (tui_init_generic_part): Remove, moving
569         contents...
570         (tui_initialize_static_data): ...here.
571
572 2019-06-25  Tom Tromey  <tom@tromey.com>
573
574         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
575         (tui_display_registers_from, tui_check_register_values): Update.
576         (tui_display_register): Remove win_info parameter; update.
577         (tui_get_register): Change type of parameters.
578         * tui/tui-data.h (struct tui_data_element): Remove.
579         (union tui_which_element) <data>: Remove.
580         <data_window>: Change type.
581         (struct tui_data_item_window): New.
582         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
583         case.  Add assert.
584         (~tui_data_item_window): New destructor.
585         (free_content_elements): Remove DATA_ITEM_WIN case.
586
587 2019-06-25  Tom Tromey  <tom@tromey.com>
588
589         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
590         Remove.
591
592 2019-06-25  Tom Tromey  <tom@tromey.com>
593
594         * tui/tui-data.h (struct tui_command_element): Remove.
595         (union tui_which_element) <command>: Remove.
596         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
597         assert.
598         (free_content_elements): Remove CMD_WIN case.
599
600 2019-06-25  Tom Tromey  <tom@tromey.com>
601
602         * tui/tui-layout.c (tui_set_layout): Update.
603         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
604         * tui/tui-data.c (layout_def): Update.
605
606 2019-06-25  Tom Tromey  <tom@tromey.com>
607
608         * tui/tui-wingeneral.c (tui_refresh_all): Update.
609         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
610         (tui_source_window_base::set_new_height): Update.
611         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
612         Update.
613         (tui_set_locator_fullname, tui_set_locator_info)
614         (tui_show_frame_info): Update.
615         * tui/tui-source.c (tui_set_source_content)
616         (tui_source_is_displayed): Update.
617         * tui/tui-layout.c (show_source_disasm_command, show_data)
618         (show_source_or_disasm_and_command): Update.
619         * tui/tui-disasm.c (tui_set_disassem_content)
620         (tui_get_begin_asm_address): Update.
621         * tui/tui-data.h (struct tui_locator_element): Remove.
622         (union tui_which_element) <locator>: Remove.
623         (struct tui_locator_window): New.
624         (tui_locator_win_info_ptr): Change return type.
625         * tui/tui-data.c (_locator): Change type.
626         (tui_locator_win_info_ptr): Change return type.
627         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
628         (tui_alloc_content): Add assert.
629
630 2019-06-25  Tom Tromey  <tom@tromey.com>
631
632         * tui/tui-winsource.c
633         (tui_exec_info_window::maybe_allocate_content): New method.
634         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
635         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
636         (make_source_or_disasm_window): Add cast.
637         * tui/tui-data.h (union tui_which_element) <simple_string>:
638         Remove.
639         (struct tui_source_info): New.
640         (struct tui_source_window_base) <execution_info>: Change type.
641         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
642         case, and add assert.
643         (tui_alloc_content): Add assert.
644
645 2019-06-25  Tom Tromey  <tom@tromey.com>
646
647         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
648         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
649         * tui/tui-data.c (tui_alloc_win_info): Remove.
650
651 2019-06-25  Tom Tromey  <tom@tromey.com>
652
653         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
654         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
655         can_highlight.
656
657 2019-06-25  Tom Tromey  <tom@tromey.com>
658
659         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
660         make_visible_with_new_height method.
661         (tui_win_info::make_visible_with_new_height): New method.
662         (tui_source_window_base::do_make_visible_with_new_height)
663         (tui_data_window::do_make_visible_with_new_height)
664         (tui_cmd_window::do_make_visible_with_new_height): New methods.
665         (make_visible_with_new_height): Remove.
666         (tui_resize_all, tui_adjust_win_heights): Use
667         make_visible_with_new_height method.
668         * tui/tui-data.h (struct tui_win_info)
669         <do_make_visible_with_new_height, make_visible_with_new_height>:
670         New methods.
671         (struct tui_source_window_base, struct tui_data_window)
672         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
673         methods.
674
675 2019-06-25  Tom Tromey  <tom@tromey.com>
676
677         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
678         method.
679         (update_tab_width): Call update_tab_width method.
680         * tui/tui-data.h (struct tui_win_info)
681         (struct tui_source_window_base) <update_tab_width>: New methods.
682
683 2019-06-25  Tom Tromey  <tom@tromey.com>
684
685         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
686         parameter.
687         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
688         parameter.
689         (tui_gen_win_info::make_visible): Update.
690         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
691         parameter.
692         * tui/tui-data.h (enum tui_box): New enum.
693         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
694
695 2019-06-25  Tom Tromey  <tom@tromey.com>
696
697         * tui/tui-layout.c (make_source_or_disasm_window): Always use
698         init_and_make_win for EXEC_INFO_WIN.
699         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
700         longer inline.
701         (struct tui_win_info) <~tui_win_info>: Inline.
702         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
703         Don't declare.
704         * tui/tui-data.c (source_win, disasm_win): Remove globals.
705         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
706         Remove.
707         (tui_initialize_static_data): Update.
708         (~tui_gen_win_info): Handle more cleanup here.
709         (~tui_source_window_base): Delete "execution_info".
710         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
711
712 2019-06-25  Tom Tromey  <tom@tromey.com>
713
714         * tui/tui-layout.c (make_command_window): Don't set
715         can_highlight.
716         (show_source_disasm_command): Call the reset method.
717         (show_data): Don't set can_highlight.  Call the reset method.
718         (tui_gen_win_info::reset): Rename from init_gen_win_info
719         (init_and_make_win): Simplify.  Return tui_gen_win_info.
720         (show_source_or_disasm_and_command): Call the reset method.
721         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
722         (struct tui_cmd_window): Set can_highlight.
723
724 2019-06-25  Tom Tromey  <tom@tromey.com>
725
726         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
727         from make_visible.
728         (tui_make_visible, tui_make_invisible): Rewrite.
729         (tui_win_info::make_visible): Remove.
730         (tui_source_window_base::make_visible): Update.
731         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
732         method.  Moved from...
733         (struct tui_win_info) <make_visible>: ...here.
734
735 2019-06-25  Tom Tromey  <tom@tromey.com>
736
737         * tui/tui-winsource.c
738         (tui_source_window_base::do_scroll_horizontal): Remove direction
739         parameter.
740         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
741         direction parameter.
742         * tui/tui-win.c (tui_win_info::forward_scroll)
743         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
744         (tui_win_info::right_scroll): Update.
745         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
746         direction parameter.
747         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
748         direction parameter.
749         * tui/tui-data.h (enum tui_scroll_direction): Remove.
750         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
751         Remove direction parameter.
752         (struct tui_source_window_base, struct tui_source_window)
753         (struct tui_disasm_window, struct tui_data_window)
754         (struct tui_cmd_window): Update.
755
756 2019-06-25  Tom Tromey  <tom@tromey.com>
757
758         * tui/tui-winsource.h (tui_set_exec_info_content)
759         (tui_show_exec_info_content, tui_erase_exec_info_content)
760         (tui_clear_exec_info_content, tui_update_exec_info): Change
761         argument to tui_source_window_base.
762         * tui/tui-winsource.c (tui_set_exec_info_content)
763         (tui_show_exec_info_content, tui_erase_exec_info_content)
764         (tui_clear_exec_info_content, tui_update_exec_info): Change
765         argument to tui_source_window_base.
766
767 2019-06-25  Tom Tromey  <tom@tromey.com>
768
769         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
770         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
771
772 2019-06-25  Tom Tromey  <tom@tromey.com>
773
774         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
775         check.
776
777 2019-06-25  Tom Tromey  <tom@tromey.com>
778
779         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
780         type to void.
781         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
782         type to void.
783         * tui/tui-source.c (tui_set_source_content): Update.
784         * tui/tui-disasm.c (tui_set_disassem_content): Update.
785
786 2019-06-25  Tom Tromey  <tom@tromey.com>
787
788         * tui/tui-win.c (window_name_completer, tui_set_focus)
789         (tui_all_windows_info): Use name method.
790         * tui/tui-data.h (struct tui_gen_win_info)
791         (struct tui_source_window, struct tui_disasm_window)
792         (struct tui_data_window, struct tui_cmd_window) <name>: New
793         method.
794         (tui_win_name): Don't declare.
795         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
796         (tui_win_name): Remove.
797
798 2019-06-25  Tom Tromey  <tom@tromey.com>
799
800         * tui/tui-winsource.h (tui_update_source_window)
801         (tui_update_source_window_as_is): Change parameter type.
802         * tui/tui-winsource.c (tui_update_source_window): Change win_info
803         to be a tui_source_window_base.
804         (tui_update_source_window_as_is): Likewise.
805         * tui/tui-win.c (make_visible_with_new_height): Update.
806
807 2019-06-25  Tom Tromey  <tom@tromey.com>
808
809         * tui/tui-winsource.c (tui_erase_source_content)
810         (tui_show_source_content, tui_show_exec_info_content)
811         (tui_erase_exec_info_content): Use refresh_window method.
812         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
813         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
814         from tui_refresh_win.
815         (tui_data_window::refresh_window): New method.
816         (tui_win_info::refresh, tui_source_window_base::refresh)
817         (tui_refresh_all): Use refresh_window method.
818         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
819         method.
820         * tui/tui-regs.c (tui_display_register): Call refresh_window
821         method.
822         * tui/tui-layout.c (show_source_disasm_command)
823         (show_source_or_disasm_and_command): Call refresh_window method.
824         * tui/tui-data.h (struct tui_gen_win_info)
825         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
826         New method.
827
828 2019-06-25  Tom Tromey  <tom@tromey.com>
829
830         * tui/tui.c (tui_rl_other_window, tui_enable)
831         (tui_is_window_visible, tui_get_command_dimension): Update.
832         * tui/tui-winsource.c (tui_update_source_window_as_is)
833         (tui_clear_source_content, tui_erase_source_content)
834         (tui_show_source_line, tui_source_window_base::refill)
835         (tui_source_window_base::do_scroll_horizontal)
836         (tui_source_window_base::set_is_exec_point_at)
837         (tui_update_breakpoint_info, tui_set_exec_info_content)
838         (tui_alloc_source_buffer, tui_line_is_displayed)
839         (tui_addr_is_displayed): Update.
840         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
841         (tui_check_and_display_highlight_if_needed)
842         (tui_win_info::make_visible, tui_win_info::refresh)
843         (tui_refresh_all): Update.
844         * tui/tui-windata.c (tui_first_data_item_displayed)
845         (tui_delete_data_content_windows, tui_erase_data_content)
846         (tui_display_all_data, tui_data_window::refresh_all)
847         (tui_check_data_values): Update.
848         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
849         (tui_set_win_focus_to, tui_win_info::forward_scroll)
850         (tui_win_info::backward_scroll, tui_refresh_all_win)
851         (tui_resize_all, tui_set_focus, tui_all_windows_info)
852         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
853         (tui_source_window_base::set_new_height)
854         (tui_data_window::set_new_height)
855         (make_invisible_and_set_new_height)
856         (make_visible_with_new_height, new_height_ok)
857         (parse_scrolling_args): Update.
858         * tui/tui-stack.c (tui_show_frame_info): Update.
859         * tui/tui-source.c (tui_set_source_content)
860         (tui_set_source_content_nil, tui_source_is_displayed)
861         (tui_source_window::do_scroll_vertical): Update.
862         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
863         (tui_display_registers_from, tui_display_reg_element_at_line)
864         (tui_check_register_values, tui_reg_command): Update.
865         * tui/tui-layout.c (tui_default_win_height)
866         (show_source_disasm_command, show_data, init_and_make_win)
867         (show_source_or_disasm_and_command): Update.
868         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
869         (tui_redisplay_readline, tui_mld_flush)
870         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
871         (tui_getc): Update.
872         * tui/tui-disasm.c (tui_set_disassem_content)
873         (tui_disasm_window::do_scroll_vertical): Update.
874         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
875         Now virtual.
876         (struct tui_win_info): Derive from tui_gen_win_info.
877         <~tui_win_info>: Mark as override.
878         <generic>: Remove member.
879         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
880         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
881         (~tui_data_window, ~tui_win_info)
882         (tui_free_all_source_wins_content): Update.
883         * tui/tui-command.c (tui_refresh_cmd_win): Update.
884
885 2019-06-25  Tom Tromey  <tom@tromey.com>
886
887         * tui/tui-layout.c (init_and_make_win): Use new.
888         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
889         destructor, initializers.
890         (tui_alloc_generic_win_info): Don't declare.
891         * tui/tui-data.c (_locator): Add argument to constructor.
892         (source_win, disasm_win): New globals.
893         (exec_info): Remove.
894         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
895         Update.
896         (tui_alloc_generic_win_info): Remove.
897         (init_content_element): Use new.
898         (tui_win_info::tui_win_info): Update.
899         (free_content_elements) <case DATA_WIN>: Use delete.
900
901 2019-06-25  Tom Tromey  <tom@tromey.com>
902
903         * tui/tui-wingeneral.c (tui_refresh_win): Update.
904         * tui/tui-windata.c (tui_first_data_item_displayed)
905         (tui_delete_data_content_windows): Update.
906         * tui/tui-win.c (tui_data_window::set_new_height): Update.
907         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
908         (tui_display_registers_from, tui_check_register_values): Update.
909         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
910         pointer.
911         * tui/tui-data.c (init_content_element): Update.  Allocate the new
912         window.
913         (tui_free_data_content): Update.
914         (free_content_elements) <case DATA_WIN>: Free the window.
915
916 2019-06-25  Tom Tromey  <tom@tromey.com>
917
918         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
919         Update.
920         * tui/tui-layout.c (make_command_window)
921         (show_source_disasm_command, show_data, init_and_make_win)
922         (show_source_or_disasm_and_command): Update.
923         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
924         method.
925         <can_highight, is_highlighted>: Now bool.
926         (tui_set_win_highlight): Don't declare.
927         * tui/tui-data.c (tui_set_win_highlight): Remove.
928
929 2019-06-25  Tom Tromey  <tom@tromey.com>
930
931         * tui/tui-wingeneral.c (make_visible): Remove check of window
932         type.
933
934 2019-06-25  Tom Tromey  <tom@tromey.com>
935
936         * tui/tui-win.c (tui_win_info::max_height)
937         (tui_cmd_window::max_height): New methods.
938         (new_height_ok): Call max_height.
939         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
940         <max_height>: New method.
941
942 2019-06-25  Tom Tromey  <tom@tromey.com>
943
944         * tui/tui-win.c (tui_source_window_base::set_new_height)
945         (tui_data_window::set_new_height): New methods.
946         (make_invisible_and_set_new_height): Call set_new_height method.
947         * tui/tui-data.h (struct tui_win_info)
948         (struct tui_source_window_base, struct tui_data_window)
949         <set_new_height>: New method.
950
951 2019-06-25  Tom Tromey  <tom@tromey.com>
952
953         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
954         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
955         tui_refresh_data_win.
956         * tui/tui-win.c (tui_source_window_base::refresh_all): New
957         method.
958         (tui_refresh_all_win): Call the refresh_all method.
959         (tui_set_focus): Likewise.
960         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
961         (struct tui_source_window_base, struct tui_data_window) <refresh>:
962         Likewise.
963
964 2019-06-25  Tom Tromey  <tom@tromey.com>
965
966         * tui/tui-winsource.h (tui_refill_source_window)
967         (tui_set_is_exec_point_at): Don't declare.
968         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
969         (tui_source_window_base::refill): Rename from
970         tui_refill_source_window.
971         (tui_source_window_base::do_scroll_horizontal): Update.
972         (tui_source_window_base::set_is_exec_point_at): Rename from
973         tui_set_is_exec_point_at.
974         (tui_update_all_breakpoint_info): Update.
975         * tui/tui-stack.c (tui_show_frame_info): Update.
976         * tui/tui-layout.c (show_data): Add cast.
977         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
978         * tui/tui-data.h (struct tui_source_window_base) <refill,
979         set_is_exec_point_at>: New methods.
980         (tui_source_windows, tui_add_to_source_windows): Update types.
981         (tui_add_to_source_windows): Remove redundant declaration.
982         * tui/tui-data.c (source_windows): Store tui_source_window_base.
983         (tui_source_windows): Change return type.
984         (tui_clear_source_windows_detail): Update.
985         (tui_add_to_source_windows): Change type of parameter.
986         (tui_free_all_source_wins_content): Update.
987
988 2019-06-25  Tom Tromey  <tom@tromey.com>
989
990         * tui/tui-wingeneral.c (tui_win_info::refresh)
991         (tui_source_window_base::refresh): New methods.
992         (tui_refresh_all): Call the refresh method.
993         * tui/tui-data.h (struct tui_win_info)
994         (struct tui_source_window_base) <refresh>: New method.
995
996 2019-06-25  Tom Tromey  <tom@tromey.com>
997
998         * tui/tui.h (tui_is_window_visible): Return bool.
999         * tui/tui.c (tui_is_window_visible): Return bool.
1000         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1001         (tui_make_visible, tui_make_invisible)
1002         (tui_win_info::make_visible)
1003         (tui_source_window_base::make_visible, make_all_visible)
1004         (tui_make_all_visible, tui_make_all_invisible): Update.
1005         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1006         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1007         bool.
1008         (struct tui_win_info, struct tui_source_window_base)
1009         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1010         * tui/tui-data.c (tui_init_generic_part): Update.
1011
1012 2019-06-25  Tom Tromey  <tom@tromey.com>
1013
1014         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1015         (tui_source_window_base::make_visible): New methods.
1016         (make_all_visible): Make method call.
1017         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1018         (struct tui_source_window_base, struct tui_cmd_window): Override
1019         make_visible.
1020         (tui_win_is_source_type): Don't declare.
1021         * tui/tui-data.c (tui_win_is_source_type): Remove.
1022
1023 2019-06-25  Tom Tromey  <tom@tromey.com>
1024
1025         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1026         NULL check.
1027
1028 2019-06-25  Tom Tromey  <tom@tromey.com>
1029
1030         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1031         Inline constructor.  Add initializers for members.
1032         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1033         constructors; now inline in class.
1034
1035 2019-06-25  Tom Tromey  <tom@tromey.com>
1036
1037         * tui/tui-regs.c (tui_show_registers): Update.
1038         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1039         bool.
1040         * tui/tui-data.c (tui_data_window::clear_detail)
1041         (tui_data_window): Update.
1042
1043 2019-06-25  Tom Tromey  <tom@tromey.com>
1044
1045         * tui/tui-windata.c (tui_display_all_data)
1046         (tui_display_data_from_line, tui_display_data_from)
1047         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1048         Update.
1049         * tui/tui-regs.c (tui_last_regs_line_no)
1050         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1051         (tui_show_registers, tui_show_register_group)
1052         (tui_display_registers_from, tui_display_reg_element_at_line)
1053         (tui_display_registers_from_line, tui_check_register_values)
1054         (tui_reg_next, tui_reg_prev): Update.
1055         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1056         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1057         tui_data_window.
1058         (struct tui_win_info) <detail>: Remove.  Add new fields from
1059         tui_data_info.
1060         (TUI_DATA_WIN): Add cast.
1061         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1062         (~tui_data_window): Simplify.
1063
1064 2019-06-25  Tom Tromey  <tom@tromey.com>
1065
1066         * tui/tui-layout.c (show_source_disasm_command)
1067         (show_source_or_disasm_and_command): Update.
1068         * tui/tui-io.c (update_cmdwin_start_line)
1069         (tui_redisplay_readline): Update.
1070         * tui/tui-data.h (struct tui_command_info): Remove.
1071         (struct tui_win_info) <detail>: Remove command_info member.
1072         (struct tui_data_window) <start_line>: New member, from
1073         tui_command_info.
1074         (TUI_CMD_WIN): Add casts.
1075
1076 2019-06-25  Tom Tromey  <tom@tromey.com>
1077
1078         * tui/tui-winsource.c (tui_update_source_window)
1079         (tui_refill_source_window)
1080         (tui_source_window_base::do_scroll_horizontal)
1081         (tui_update_breakpoint_info, tui_set_exec_info_content)
1082         (tui_show_exec_info_content, tui_erase_exec_info_content)
1083         (tui_clear_exec_info_content): Update.
1084         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1085         Update.
1086         * tui/tui-win.c (make_invisible_and_set_new_height)
1087         (make_visible_with_new_height): Update.
1088         * tui/tui-source.c (tui_set_source_content)
1089         (tui_show_symtab_source): Update.
1090         * tui/tui-layout.c (extract_display_start_addr)
1091         (show_source_disasm_command, show_data)
1092         (make_source_or_disasm_window)
1093         (show_source_or_disasm_and_command): Update.
1094         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1095         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1096         "gdbarch".
1097         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1098         to tui_source_window_base.
1099         (struct tui_win_info) <detail>: Remove source_info member.
1100         (struct tui_source_window_base) <has_locator>: Inline.
1101         Move contents from tui_source_info; rename has_locator member to
1102         m_has_locator.
1103         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1104         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1105         header file.
1106         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1107         Simplify.
1108         (tui_free_all_source_wins_content): Cast to
1109         tui_source_window_base.
1110
1111 2019-06-25  Tom Tromey  <tom@tromey.com>
1112
1113         * tui/tui-win.c (make_invisible_and_set_new_height)
1114         (make_visible_with_new_height): Call has_locator method.
1115         * tui/tui-layout.c (show_source_disasm_command, show_data)
1116         (show_source_or_disasm_and_command): Update for bool change.
1117         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1118         (tui_win_info) <has_locator>: New method.
1119         (struct tui_source_window_base) <has_locator>: New method.
1120         (tui_win_has_locator): Don't declare.
1121         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1122         from tui_win_has_locator.
1123         (tui_source_window_base): Use false, not FALSE.
1124
1125 2019-06-25  Tom Tromey  <tom@tromey.com>
1126
1127         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1128         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1129         clear_detail method directly.
1130         (tui_clear_win_detail): Remove.
1131
1132 2019-06-25  Tom Tromey  <tom@tromey.com>
1133
1134         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1135         "this", not TUI_DISASM_WIN.
1136
1137 2019-06-25  Tom Tromey  <tom@tromey.com>
1138
1139         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1140         declare.
1141         * tui/tui-winsource.c
1142         (tui_source_window_base::do_scroll_horizontal): Rename from
1143         tui_horizontal_source_scroll.
1144         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1145         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1146         from tui_vertical_data_scroll.
1147         * tui/tui-win.h (tui_scroll): Don't declare.
1148         * tui/tui-win.c (tui_win_info::forward_scroll)
1149         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1150         (tui_win_info::right_scroll): Rename and update.
1151         (tui_scroll_forward_command, tui_scroll_backward_command)
1152         (tui_scroll_left_command, tui_scroll_right_command): Update.
1153         (tui_scroll): Remove.
1154         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1155         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1156         from tui_vertical_source_scroll.
1157         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1158         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1159         from tui_vertical_disassem_scroll.
1160         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1161         do_scroll_horizontal>: New methods.
1162         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1163         Likewise.
1164         (struct tui_source_window_base): Add do_scroll_horizontal.
1165         (struct tui_source_window, struct tui_disasm_window): Add
1166         do_scroll_vertical.
1167         (struct tui_data_window, struct tui_cmd_window): Add
1168         do_scroll_horizontal and do_scroll_vertical.
1169         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1170
1171 2019-06-25  Tom Tromey  <tom@tromey.com>
1172
1173         * tui/tui-data.h (struct tui_source_window_base): New struct.
1174         (struct tui_source_window): Derive from tui_source_window_base.
1175         (struct tui_disasm_window): New struct.
1176         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1177         from tui_source_window::clear_detail.
1178         (tui_source_window_base): Rename from tui_source_window.
1179         (~tui_source_window_base): Rename from ~tui_source_window.
1180         (tui_alloc_win_info): Create a tui_disasm_window.
1181
1182 2019-06-25  Tom Tromey  <tom@tromey.com>
1183
1184         * tui/tui-data.h (struct tui_source_window)
1185         (struct tui_data_window): Declare destructors.
1186         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1187         destructors.
1188         (tui_win_info): Simplify.
1189
1190 2019-06-25  Tom Tromey  <tom@tromey.com>
1191
1192         * tui/tui-winsource.c (tui_display_main)
1193         (tui_update_source_windows_with_addr)
1194         (tui_update_all_breakpoint_info): Update.
1195         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1196         (new_height_ok, parse_scrolling_args): Update.
1197         * tui/tui-stack.c (tui_show_frame_info): Update.
1198         * tui/tui-data.h (struct tui_list): Remove.
1199         (tui_source_windows): Return a reference to a std::vector.
1200         * tui/tui-data.c (source_windows): Now a std::vector.
1201         (tui_source_windows): Change return type.
1202         (tui_clear_source_windows): Rewrite.
1203         (tui_clear_source_windows_detail, tui_add_to_source_windows)
1204         (tui_free_all_source_wins_content): Rewrite.
1205
1206 2019-06-25  Tom Tromey  <tom@tromey.com>
1207
1208         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
1209         (struct tui_data_window, struct tui_cmd_window): Declare
1210         clear_detail method.
1211         * tui/tui-data.c (tui_source_window::clear_detail)
1212         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
1213         methods.
1214         (tui_clear_win_detail): Simplify.
1215
1216 2019-06-25  Tom Tromey  <tom@tromey.com>
1217
1218         * tui/tui-layout.c (make_source_window, make_disasm_window)
1219         (make_source_or_disasm_window): Remove win_info_ptr parameter.
1220         Return the new window.
1221         (show_source_disasm_command, show_data)
1222         (show_source_or_disasm_and_command): Update.
1223
1224 2019-06-25  Tom Tromey  <tom@tromey.com>
1225
1226         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
1227         parameter.  Return the new window.
1228         (show_source_disasm_command): Update and remove NULL check.
1229         (show_source_or_disasm_and_command): Update.
1230
1231 2019-06-25  Tom Tromey  <tom@tromey.com>
1232
1233         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
1234
1235 2019-06-25  Tom Tromey  <tom@tromey.com>
1236
1237         * tui/tui-data.h (struct tui_win_info): Make constructor
1238         protected.  Make destructor virtual.  Add initializers.
1239         (tui_source_window, tui_data_window, tui_cmd_window): New
1240         classes.
1241         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
1242         constructor.  Add "type" parameter.
1243         (tui_source_window, tui_data_window, tui_cmd_window): New
1244         constructors.
1245         (tui_alloc_win_info): Instantiate the appropriate subclass.
1246
1247 2019-06-25  Tom Tromey  <tom@tromey.com>
1248
1249         * tui/tui-win.c (tui_resize_all): Use delete.
1250         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
1251         destructor.
1252         (tui_free_window): Don't declare.
1253         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
1254         Update.
1255
1256 2019-06-25  Tom Tromey  <tom@tromey.com>
1257
1258         * tui/tui-data.h (struct tui_win_info): Add constructor.
1259         * tui/tui-data.c (tui_alloc_win_info): Use new.
1260         (tui_free_window): Use delete.
1261
1262 2019-06-22  Tom Tromey  <tom@tromey.com>
1263
1264         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
1265         declare.
1266         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
1267
1268 2019-06-22  Tom Tromey  <tom@tromey.com>
1269
1270         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
1271         declare.
1272         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
1273
1274 2019-06-22  Tom de Vries  <tdevries@suse.de>
1275
1276         * dwarf2read.c (create_addrmap_from_aranges)
1277         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
1278         instead of '%zu'.
1279
1280 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
1281
1282         * dwarf2read.h (dwarf2_section_info_def): Remove.
1283         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
1284         * dwarf2read.c (struct dwo_sections) <types>: Change type to
1285         std::vector<dwarf2_section_info>.
1286         (struct dwo_file) <~dwo_file>: Remove.
1287         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
1288         types field.
1289         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
1290         (dwarf2_read_debug_names): Likewise.
1291         (create_debug_types_hash_table): Change parameter type to
1292         array_view, adjust code accordingly.
1293         (dwarf2_locate_dwo_sections): Adjust to std::vector.
1294         (partial_die_info::fixup): Likewise.
1295         (determine_prefix): Likewise.
1296         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
1297
1298 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1299
1300         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
1301         gdb_bfd_ref_ptr.
1302         <~dwo_file>: Remove call to gdb_bfd_unref.
1303         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
1304         gdb_bfd_ref_ptr::get.
1305
1306 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1307
1308         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
1309         type to htab_up.
1310         * dwarf2read.c (struct dwo_file): Initialize fields.
1311         <~dwo_file>: New.
1312         (free_dwo_file): Remove, move content to ~dwo_file.
1313         (struct dwo_file_deleter): Remove.
1314         (dwo_file_up>: Remove custom deleter.
1315         (free_dwo_files): Remove.
1316         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
1317         dwo_files.
1318         (process_skeletonless_type_units): Call unique_ptr::get.
1319         (allocate_dwo_file_hash_table): Add deleter to created hash
1320         table.  Change return type to htab_up.
1321         (lookup_dwo_file_slot): Don't memset dwo_file, call
1322         unique_ptr::get.
1323         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
1324         (create_dwo_unit_in_dwp_v2): Likewise.
1325         (open_and_init_dwo_file): Likewise.
1326         (free_dwo_file_from_slot): Remove.
1327
1328 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1329
1330         * dwarf2read.h (struct dwarf2_section_info) <readin,
1331         is_virtual>: Change type to bool.
1332         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
1333         true instead of 1.
1334
1335 2019-06-19  Tom Tromey  <tom@tromey.com>
1336
1337         * tui/tui-data.h (tui_init_content_element): Don't declare.
1338
1339 2019-06-19  Tom Tromey  <tom@tromey.com>
1340
1341         * tui/tui-data.h (tui_init_win_info): Don't declare.
1342
1343 2019-06-19  Tom de Vries  <tdevries@suse.de>
1344
1345         * dwarf2read.h (abstract_to_concrete): Change type to
1346         std::unordered_map<sect_offset, std::vector<sect_offset>,
1347         gdb::hash_enum<sect_offset>>.
1348
1349 2019-06-19  Tom Tromey  <tromey@adacore.com>
1350
1351         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
1352         EVAL_AVOID_SIDE_EFFECTS specially.
1353
1354 2019-06-19  Tom Tromey  <tromey@adacore.com>
1355
1356         * source-cache.c (highlighter): New global.
1357         (source_cache::get_source_lines): Create a highlighter on demand.
1358
1359 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1360
1361         * defs.h (deprecated_interactive_hook): Delete declaration.
1362         * interps.c (clear_interpreter_hooks): Remove use of
1363         deprecated_interactive_hook.
1364         * top.c (deprecated_interactive_hook): Delete definition.
1365         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
1366
1367 2019-06-18  Tom de Vries  <tdevries@suse.de>
1368
1369         PR gdb/24515
1370         * dwarf2read.h (abstract_to_concrete): Change type from
1371         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
1372         std::unordered_map<sect_offset, std::vector<sect_offset>>.
1373         * dwarf2read.c (read_variable): Update.
1374         (dwarf2_fetch_die_loc_sect_off): Update.
1375
1376 2019-06-17  Tom de Vries  <tdevries@suse.de>
1377
1378         PR gdb/24617
1379         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
1380         accessing parent[parent_len - 1].
1381
1382 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
1383
1384         PR gdb/24364
1385         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
1386         call dtrace_process_dof with NULL dof.
1387
1388 2019-06-16  Tom de Vries  <tdevries@suse.de>
1389
1390         PR gdb/24445
1391         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
1392
1393 2019-06-16  Tom Tromey  <tom@tromey.com>
1394
1395         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1396         (make_all_visible): Use address of member.
1397
1398 2019-06-16  Tom Tromey  <tom@tromey.com>
1399
1400         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
1401         (tui_free_window, free_content, free_content_elements): Remove
1402         unnecessary cast.
1403         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
1404         cast.
1405         * tui/tui-regs.c (tui_show_register_group)
1406         (tui_display_registers_from, tui_display_reg_element_at_line):
1407         Remove unnecessary cast.
1408
1409 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
1410
1411         * linux-nat.c (normal_mask): Delete.
1412         (_initialize_linux_nat): Don't initialise normal_mask.
1413
1414 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
1415
1416         PR gdb/24445
1417         * dwarf-index-write.h (write_psymtabs_to_index): Add
1418         dwz_basename parameter.
1419         * dwarf-index-write.c (write_gdbindex): Move file writing to
1420         write_gdbindex_1.  Change return type void.
1421         (assert_file_size): Move up, remove filename parameter.
1422         (write_gdbindex_1): New function.
1423         (write_debug_names): Change return type to void, call
1424         assert_file_size.
1425         (struct index_wip_file): New struct.
1426         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
1427         file logic to index_wip_file.  Write index for dwz file if
1428         needed.
1429         (save_gdb_index_command): Pass basename of dwz file, if present.
1430         * dwarf-index-cache.c (index_cache::store): Obtain and pass
1431         build-id of dwz file, if present.
1432         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1433         (dwarf2_get_dwz_file): Likewise.
1434         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1435         (dwarf2_get_dwz_file): Likewise.
1436
1437 2019-06-16  Tom Tromey  <tom@tromey.com>
1438
1439         * coffread.c (process_coff_symbol): Use xstrdup.
1440         * value.c (create_internalvar): Use xstrdup.
1441
1442 2019-06-16  Tom Tromey  <tom@tromey.com>
1443
1444         * valops.c (value_cast, value_slice): Remove unnecessary cast.
1445         * breakpoint.c (stopin_command, stopat_command)
1446         (until_break_command, decode_location_default): Remove unnecessary
1447         cast.
1448         * utils.c (subset_compare): Remove unnecessary cast.
1449         * ada-lang.c (ada_update_initial_language): Remove unnecessary
1450         cast.
1451         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1452         cast.
1453         * infcmd.c (path_command): Remove unnecessary cast.
1454         * coffread.c (decode_type): Remove unnecessary cast.
1455         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1456         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1457         * tui/tui-stack.c (tui_show_locator_content)
1458         (tui_show_frame_info): Remove unnecessary cast.
1459         * tui/tui-win.c (tui_scroll_forward_command)
1460         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1461         (parse_scrolling_args): Remove unnecessary cast.
1462         * tui/tui-data.c (init_win_info, tui_del_window)
1463         (tui_free_window, tui_del_data_windows, tui_free_data_content)
1464         (free_content_elements): Remove unnecessary cast.
1465         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1466         unnecessary cast.
1467         * tui/tui-source.c (tui_set_source_content)
1468         (tui_vertical_source_scroll): Remove unnecessary cast.
1469         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1470         cast.
1471         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1472         * tui/tui-regs.c (tui_display_registers_from)
1473         (tui_display_register): Remove unnecessary cast.
1474         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1475         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1476         (make_visible): Remove unnecessary cast.
1477         * tui/tui-winsource.c (tui_erase_source_content)
1478         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1479         unnecessary cast.
1480         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1481         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1482         * stabsread.c (read_type, read_array_type, read_range_type):
1483         Remove unnecessary cast.
1484         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1485         (parse_symbol, parse_type, upgrade_type, parse_external)
1486         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
1487         unnecessary cast.
1488         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
1489
1490 2019-06-16  Tom Tromey  <tom@tromey.com>
1491
1492         * tui/tui-data.c (tui_alloc_generic_win_info)
1493         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
1494         checks.
1495
1496 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
1497             Andrew Burgess  <andrew.burgess@embecosm.com>
1498
1499         * f-typeprint.c (f_print_type): Don't return early for not
1500         associated or not allocated types.
1501         (f_type_print_varspec_suffix): Add print_rank parameter and print
1502         ranks of array types in case they dangling.
1503         (f_type_print_base): Add print_rank parameter.
1504
1505 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1506
1507         * NEWS: Mention new MI commands.
1508         * break-catch-throw.c (enum exception_event_kind): Move to
1509         breakpoint.h.
1510         (print_mention_exception_catchpoint): Output text as a single
1511         message.
1512         (catch_exception_command_1): Rename to...
1513         (catch_exception_event): ...this, make non-static, update header
1514         command, and change some parameter types.
1515         (catch_catch_command): Update for changes to
1516         catch_exception_command_1.
1517         (catch_throw_command): Likewise.
1518         (catch_rethrow_command): Likewise.
1519         * breakpoint.c (enum exception_event_kind): Delete.
1520         * breakpoint.h (enum exception_event_kind): Moved here from
1521         break-catch-throw.c.
1522         (catch_exception_event): Declare.
1523         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
1524         (mi_cmd_catch_throw): New function.
1525         (mi_cmd_catch_rethrow): New function.
1526         (mi_cmd_catch_catch): New function.
1527         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
1528         'catch-catch' entries.
1529         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
1530         (mi_cmd_catch_rethrow): Declare.
1531         (mi_cmd_catch_catch): Declare.
1532
1533 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1534
1535         * annotate.c (annotate_source_line): Change return type to void,
1536         update implementation to match.
1537         * annotate.h (annotate_source_line): Change return type to void,
1538         update header comment.
1539         * stack.c (print_frame_info): Don't change what frame information
1540         is printed based on whether annotations are on or not.
1541
1542 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1543
1544         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
1545         (annotate_source): Make static.
1546         (annotate_source_line): Moved from source.c and renamed from
1547         identify_source_line.  Update the return type.
1548         * annotate.h (annotate_source): Delete declaration.
1549         (annotate_source_line): Declaration moved from source.h, and
1550         renamed from identify_source_line.  Return type updated.
1551         * source.c (identify_source_line): Moved to annotate.c and renamed
1552         to annotate_source_line.
1553         (info_line_command): Remove check of annotation_level.
1554         * source.h (identify_source_line): Move declaration to annotate.h
1555         and rename to annotate_source_line.
1556         * stack.c: Add 'annotate.h' include.
1557         (print_frame_info): Remove check of annotation_level before
1558         calling annotate_source_line.
1559
1560 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1561
1562         * source-cache.c (source_cache::get_plain_source_lines): Use
1563         open_source_file_with_line_charpos instead of just
1564         open_source_file, remove call to find_source_lines.
1565         (source_cache::get_source_lines): Likewise.
1566         * source.c (find_source_lines): Make static.
1567         (get_filename_and_charpos): Renamed into...
1568         (open_source_file_with_line_charpos): ..this along with changes to
1569         return a scoped_fd, and some other minor clean ups.
1570         (identify_source_line): Use open_source_file_with_line_charpos.
1571         (search_command_helper): Use open_source_file_with_line_charpos
1572         instead of just open_source_file, remove call to
1573         find_source_lines.
1574         * source.h (open_source_file_with_line_charpos): Declare new
1575         function.
1576         (find_source_lines): Delete declaration.
1577
1578 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1579
1580         * source.c (get_filename_and_charpos): Remove fullname
1581         parameter.
1582         (identify_source_line): Update call to get_filename_and_charpos.
1583
1584 2019-06-14  Tom Tromey  <tromey@adacore.com>
1585
1586         PR gdb/24502:
1587         * ui-style.h (skip_ansi_escape): Update comment.
1588         * ui-file.h (class no_terminal_escape_file): New class.
1589         * ui-file.c (no_terminal_escape_file::write)
1590         (no_terminal_escape_file::puts): New methods.
1591         * cli/cli-logging.c (handle_redirections): Use
1592         no_terminal_escape_file.
1593
1594 2019-06-14  Tom Tromey  <tromey@adacore.com>
1595
1596         * NEWS: Move convenience variable news above Python news.
1597
1598 2019-06-14  Tom Tromey  <tom@tromey.com>
1599
1600         * gnulib: Move directory to top-level.
1601         * configure.ac: Don't configure gnulib.
1602         * configure: Rebuild.
1603         * common/common-defs.h: Use new path to gnulib.
1604         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
1605         (GNULIB_H): Remove.
1606         (INCGNU): Look in new gnulib location.
1607         (HFILES_NO_SRCDIR): Remove gnulib files.
1608         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
1609         (generated_files): Remove GNULIB_H.
1610         ($(LIBGNU), all-lib): Remove targets.
1611         (distclean): Don't mention GNULIB_BUILDDIR.
1612         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
1613
1614 2019-06-14  Tom Tromey  <tromey@adacore.com>
1615
1616         * symfile.c (add_symbol_file_command): Remove obsolete comment.
1617         Warn if symbol file does not provide any symbols.
1618
1619 2019-06-14  Tom Tromey  <tromey@adacore.com>
1620
1621         * source.c (find_and_open_source): Respect basenames_may_differ.
1622
1623 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
1624
1625         * annotate.c (annotate_breakpoints_invalid): Make use of
1626         scoped_restore_terminal_state.
1627         (annotate_frames_invalid): Likewise.
1628
1629 2019-06-14  Tom Tromey  <tromey@adacore.com>
1630
1631         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
1632         allow assignment to an internalvar.
1633
1634 2019-06-14  Tom Tromey  <tromey@adacore.com>
1635
1636         * ada-lex.l: Allow "_" in attribute names.
1637
1638 2019-06-14  Tom Tromey  <tromey@adacore.com>
1639
1640         PR gdb/24653:
1641         * regcache.c (registers_changed): Don't call alloca.
1642         * top.c (execute_command): Don't call alloca.
1643
1644 2019-06-13  Pedro Alves  <palves@redhat.com>
1645
1646         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
1647         'expression'.  When parsing an expression, error out if there's
1648         junk after "unlimited".
1649         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1650         (do_set_command): Adjust calls to is_unlimited_literal.
1651
1652 2019-06-13  Pedro Alves  <palves@redhat.com>
1653
1654         * compile/compile.c (make_compile_options_def_group): Add braces
1655         around array_view initializer.
1656         * thread.c (make_thread_apply_all_options_def_group)
1657         (make_thread_apply_all_options_def_group): Likewise.
1658
1659 2019-06-13  Pedro Alves  <palves@redhat.com>
1660
1661         * NEWS (New commands): Mention "maint test-options
1662         require-delimiter", "maint test-options unknown-is-error", "maint
1663         test-options unknown-is-operand" and "maint show
1664         test-options-completion-result".
1665         (New command options, command completion): New section.
1666         (Completion improvements): New section.
1667         Mention that you can abbreviate "unlimited".
1668
1669 2019-06-13  Pedro Alves  <palves@redhat.com>
1670
1671         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
1672         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
1673         * unittests/cli-utils-selftests.c (test_parse_flags)
1674         (test_parse_flags_qcs): Delete.
1675         (test_cli_utils): Don't call deleted functions.
1676
1677 2019-06-13  Pedro Alves  <palves@redhat.com>
1678
1679         * thread.c: Include "cli/cli-option.h".
1680         (tp_array_compar_ascending): Global.
1681         (tp_array_compar): Delete function.
1682         (tp_array_compar_ascending, tp_array_compar_descending): New
1683         functions.
1684         (ascending_option_def, qcs_flag_option_def)
1685         (thr_qcs_flags_option_defs)
1686         (make_thread_apply_all_options_def_group)
1687         (make_thread_apply_options_def_group): New.
1688         (thread_apply_all_command): Use gdb::option::process_options.
1689         (thread_apply_command_completer)
1690         (thread_apply_all_command_completer): New.
1691         (thread_apply_command): Use gdb::option::process_options.
1692         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
1693         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
1694         to generate help text of "thread apply".  Adjust "taas"'s help.
1695         * tid-parse.c (tid_range_parser::in_thread_range): New method.
1696         * tid-parse.h (tid_range_parser::in_thread_range): New method.
1697
1698 2019-06-13  Pedro Alves  <palves@redhat.com>
1699
1700         * thread.c (thread_apply_command): Check for invalid TID with
1701         isdigit instead of !isalpha.
1702
1703 2019-06-13  Pedro Alves  <palves@redhat.com>
1704
1705         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
1706         (validate_flags_qcs): New.
1707         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
1708         (validate_flags_qcs): Declare.
1709         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
1710         (make_frame_apply_options_def_group): New.
1711         (frame_apply_command_count): Process options with
1712         gdb::option::process_options.
1713         (frame_apply_completer): New.
1714         (frame_apply_level_completer, frame_apply_all_completer)
1715         (frame_apply_completer): New.
1716         (_initialize_stack): Update help of "frame apply", "frame apply
1717         level", "frame apply all" and "faas" to mention supported options
1718         and install command completers.
1719         * stack.h (frame_apply_all_completer): Declare.
1720         * thread.c: Include "stack.h".
1721         (tfaas_command): Add "--".
1722         (_initialize_thread): Update help "tfaas" to mention supported
1723         options and install command completer.
1724
1725 2019-06-13  Pedro Alves  <palves@redhat.com>
1726
1727         * completer.c (complete_nested_command_line): New.
1728         (gdb_completion_word_break_characters_throw): Add assertion.
1729         * completer.h (complete_nested_command_line): Declare.
1730
1731 2019-06-13  Pedro Alves  <palves@redhat.com>
1732
1733         * stack.c (parse_backtrace_qualifiers): New.
1734         (backtrace_command): Use it.
1735         (backtrace_command_completer): Complete on qualifiers.
1736
1737 2019-06-13  Pedro Alves  <palves@redhat.com>
1738
1739         * frame.c: Include "cli/cli-option.h.
1740         (user_set_backtrace_options): New.
1741         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
1742         Delete.
1743         (get_prev_frame): Adjust.
1744         (boolean_option_def, uinteger_option_def)
1745         (set_backtrace_option_defs): New.
1746         (_initialize_frame): Adjust and use
1747         gdb::option::add_setshow_cmds_for_options to install "set
1748         backtrace past-main" and "set backtrace past-entry".
1749         * frame.h: Include "cli/cli-option.h".
1750         (struct frame_print_options): Forward declare.
1751         (print_frame_arguments_all, print_frame_arguments_scalars)
1752         (print_frame_arguments_none): Declare.
1753         (print_entry_values): Delete declaration.
1754         (struct frame_print_options, user_frame_print_options): New.
1755         (struct set_backtrace_options): New.
1756         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
1757         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
1758         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
1759         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
1760         (list_args_or_locals): Add frame_print_options parameter.
1761         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1762         * python/py-framefilter.c (enumerate_args): Pass down
1763         USER_FRAME_PRINT_OPTIONS.
1764         * stack.c: Include "cli/cli-option.h".
1765         (print_frame_arguments_all, print_frame_arguments_scalars)
1766         (print_frame_arguments_none): Declare.
1767         (print_raw_frame_arguments, print_entry_values): Delete.
1768         (user_frame_print_options): New.
1769         (boolean_option_def, enum_option_def, frame_print_option_defs):
1770         New.
1771         (struct backtrace_cmd_options): New.
1772         (bt_flag_option_def): New.
1773         (backtrace_command_option_defs): New.
1774         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1775         (print_frame_arg, read_frame_arg, print_frame_args)
1776         (print_frame_info, print_frame): Add frame_print_options parameter
1777         and use it.
1778         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
1779         (backtrace_command_1): Add frame_print_options and
1780         backtrace_cmd_options parameters and use them.
1781         (make_backtrace_options_def_group): New.
1782         (backtrace_command): Process command options with
1783         gdb::option::process_options.
1784         (backtrace_command_completer): New.
1785         (_initialize_stack): Extend "backtrace"'s help to mention
1786         supported options.  Install completer for "backtrace".
1787         Install some settings commands with add_setshow_cmds_for_options.
1788
1789 2019-06-13  Pedro Alves  <palves@redhat.com>
1790
1791         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
1792         and that "set/show print raw frame-arguments" are now deprecated.
1793
1794         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
1795         command.
1796         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
1797         * stack.c (_initialize_stack): Install "set/show print
1798         raw-frame-arguments", and deprecate "set/show print raw
1799         frame-arguments".
1800         * valprint.c (_initialize_valprint): Deprecate "set/show print
1801         raw".
1802
1803 2019-06-13  Pedro Alves  <palves@redhat.com>
1804
1805         * compile/compile.c (struct compile_options): New.
1806         (compile_flag_option_def, compile_command_option_defs)
1807         (make_compile_options_def_group): New.
1808         (compile_file_command): Handle options with
1809         gdb::option::process_options.
1810         (compile_file_command_completer): New function.
1811         (compile_code_command): Handle options with
1812         gdb::option::process_options.
1813         (compile_code_command_completer): New function.
1814         (_initialize_compiler): Install completers for "compile code" and
1815         "compile file".  Mention available options in "compile code" and
1816         "compile code"'s help.
1817         * completer.c (advance_to_completion_word): New, factored out from
1818         ...
1819         (advance_to_expression_complete_word_point): ... this.
1820         (advance_to_filename_complete_word_point): New.
1821         * completer.h (advance_to_filename_complete_word_point): New
1822         declaration.
1823
1824 2019-06-13  Pedro Alves  <palves@redhat.com>
1825
1826         * compile/compile.c: Include "cli/cli-option.h".
1827         (compile_print_value): Scope data pointer is now a
1828         value_print_options pointer; adjust.
1829         (compile_print_command): Process options.  Scope data pointer is
1830         now a value_print_options pointer; adjust.
1831         (_initialize_compile): Update "compile print"'s help to include
1832         supported options.  Install a completer for "compile print".
1833         * cp-valprint.c (show_vtblprint, show_objectprint)
1834         (show_static_field_print): Delete.
1835         (_initialize_cp_valprint): Don't install "set print
1836         static-members", "set print vtbl", "set print object" here.
1837         * printcmd.c: Include "cli/cli-option.h" and
1838         "common/gdb_optional.h".
1839         (print_command_parse_format): Rework to fill in a
1840         value_print_options instead of a format_data.
1841         (print_value): Change parameter type from format_data pointer to
1842         value_print_options reference.  Adjust.
1843         (print_command_1): Process options.  Adjust to pass down a
1844         value_print_options.
1845         (print_command_completer): New.
1846         (_initialize_printcmd): Install print_command_completer as
1847         handle_brkchars completer for the "print" command.  Update
1848         "print"'s help to include supported options.
1849         * valprint.c: Include "cli/cli-option.h".
1850         (show_vtblprint, show_objectprint, show_static_field_print): Moved
1851         here from cp-valprint.c.
1852         (boolean_option_def, uinteger_option_def)
1853         (value_print_option_defs, make_value_print_options_def_group):
1854         New.  Use gdb::option::add_setshow_cmds_for_options to install
1855         "set print elements", "set print null-stop", "set print repeats",
1856         "set print pretty", "set print union", "set print array", "set
1857         print address", "set print symbol", "set print array-indexes".
1858         * valprint.h: Include <string> and "cli/cli-option.h".
1859         (make_value_print_options_def_group): Declare.
1860         (print_value): Change parameter type from format_data pointer to
1861         value_print_options reference.
1862         (print_command_completer): Declare.
1863
1864 2019-06-13  Pedro Alves  <palves@redhat.com>
1865
1866         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
1867         (COMMON_SFILES): Add maint-test-settings.c.
1868         * cli/cli-decode.c (boolean_enums): New global, factored out from
1869         ...
1870         (add_setshow_boolean_cmd): ... here.
1871         * cli/cli-decode.h (boolean_enums): Declare.
1872         * cli/cli-option.c: New file.
1873         * cli/cli-option.h: New file.
1874         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
1875         factored out from ...
1876         (parse_cli_boolean_value(const char *)): ... this.
1877         (is_unlimited_literal): Change parameter type to pointer to
1878         pointer.  Adjust and advance ARG pointer.
1879         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1880         (parse_cli_var_enum): New, factored out from ...
1881         (do_set_command): ... this.  Adjust.
1882         * cli/cli-setshow.h (parse_cli_boolean_value)
1883         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1884         (parse_cli_var_enum): Declare.
1885         * cli/cli-utils.c: Include "cli/cli-option.h".
1886         (get_ulongest): New.
1887         * cli/cli-utils.h (get_ulongest): Declare.
1888         (check_for_argument): New overloads.
1889         * maint-test-options.c: New file.
1890
1891 2019-06-13  Pedro Alves  <palves@redhat.com>
1892
1893         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
1894         parse a range if "-" is at the end of the string.
1895
1896 2019-06-13  Pedro Alves  <palves@redhat.com>
1897
1898         * cli/cli-setshow.c (parse_auto_binary_operation)
1899         (parse_cli_boolean_value): Don't allow "o".
1900
1901 2019-06-13  Pedro Alves  <palves@redhat.com>
1902
1903         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
1904         * NEWS: Mention maint test-settings KIND.
1905         * maint-test-settings.c: New file.
1906
1907 2019-06-13  Pedro Alves  <palves@redhat.com>
1908
1909         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
1910         completer.
1911         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
1912         "set" completers.
1913
1914 2019-06-13  Pedro Alves  <palves@redhat.com>
1915
1916         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
1917         after item.
1918
1919 2019-06-13  Pedro Alves  <palves@redhat.com>
1920
1921         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
1922
1923 2019-06-13  Pedro Alves <palves@redhat.com>
1924
1925         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
1926         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
1927         call.
1928         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
1929         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
1930         calls.
1931         (check_for_argument): Skip spaces after argument.
1932
1933 2019-06-13  Pedro Alves  <palves@redhat.com>
1934
1935         * thread.c (thread_apply_command): Adjust TID parsing.
1936         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
1937         detected before end of string.
1938         (tid_is_in_list): Error out if LIST is invalid.
1939
1940 2019-06-13  Pedro Alves  <palves@redhat.com>
1941
1942         * completer.c (complete_line_internal_1): Rewind completion word
1943         point.
1944         (completion_tracker::advance_custom_word_point_by): Change
1945         parameter type to int.
1946         * completer.h (completion_tracker::advance_custom_word_point_by):
1947         Likewise.
1948
1949 2019-06-13  Pedro Alves  <palves@redhat.com>
1950
1951         * completer.c (advance_to_completion_word): Handle delimiters.
1952
1953 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
1954
1955         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
1956
1957 2019-06-11  Tom Tromey  <tom@tromey.com>
1958
1959         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
1960         (xmalloc_failed): Move to alloc.c.
1961         * alloc.c: New file.
1962         * Makefile.in (COMMON_SFILES): Add alloc.c.
1963
1964 2019-06-11  Tom Tromey  <tom@tromey.com>
1965
1966         * nat/linux-waitpid.c: Don't include server.h.
1967         (linux_debug): Remove.
1968         (my_waitpid): Update.
1969
1970 2019-06-11  Tom Tromey  <tromey@adacore.com>
1971
1972         * infcall.c (_initialize_infcall): Remove trailing newline from
1973         help.
1974         * user-regs.c (_initialize_user_regs): Remove trailing newline
1975         from help.
1976         * typeprint.c (_initialize_typeprint): Remove trailing newline
1977         from help.
1978         * reverse.c (_initialize_reverse): Remove trailing newlines from
1979         help.
1980         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
1981         from help.
1982         * language.c (add_set_language_command): Remove trailing newline
1983         from help.
1984         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
1985         help.
1986         * disasm.c (_initialize_disasm): Remove trailing newline from
1987         help.
1988         * top.c (init_main): Remove trailing newline from help.
1989         * interps.c (_initialize_interpreter): Remove trailing newline
1990         from help.
1991         * btrace.c (_initialize_btrace): Remove trailing newlines from
1992         help.
1993         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
1994         from help.
1995         * python/python.c (_initialize_python): Remove trailing newline
1996         from help.
1997         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
1998         help.
1999         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2000         from help.  Reformat some text.
2001         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2002         from help.
2003         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2004         newline from help.
2005
2006 2019-06-11  Tom Tromey  <tromey@adacore.com>
2007
2008         * darwin-nat.c (darwin_decode_exception_message)
2009         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2010
2011 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2012
2013         * valops.c (value_slice): Check for not allocated or not
2014         associated values.
2015
2016 2019-06-10  Tom de Vries  <tdevries@suse.de>
2017
2018         PR gdb/24618
2019         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2020         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2021         invalid.
2022
2023 2019-06-10  Tom de Vries  <tdevries@suse.de>
2024
2025         PR gdb/24611
2026         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2027         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2028
2029 2019-06-10  Tom de Vries  <tdevries@suse.de>
2030
2031         PR symtab/24545
2032         * symtab.c (struct demangled_name_entry): Add language field.
2033         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2034         static minimal symbol".  Set and use language field.
2035
2036 2019-06-10  Tom Tromey  <tromey@adacore.com>
2037
2038         * ada-lang.c (_initialize_ada_language): Update help text.
2039
2040 2019-06-10  Tom Tromey  <tromey@adacore.com>
2041
2042         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2043         with a newline.
2044         * guile/guile.c (handle_boot_error): Don't end warning with a
2045         newline.
2046         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2047         warning with a newline.
2048         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2049         newline.
2050         (s12z_frame_cache): Likewise.
2051         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2052         a newline.
2053         * solib-svr4.c (disable_probes_interface): Don't end warning with
2054         a newline.
2055         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2056         newline.
2057         * python/python.c (do_finish_initialization): Don't end warning
2058         with a newline.
2059
2060 2019-06-10  Tom Tromey  <tom@tromey.com>
2061
2062         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2063         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2064         gdbpy_enter.
2065
2066 2019-06-10  Tom Tromey  <tromey@adacore.com>
2067
2068         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2069         data.
2070         (elf_new_init): Don't call stabsread_new_init.
2071         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2072         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2073         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2074
2075 2019-06-10  Tom de Vries  <tdevries@suse.de>
2076
2077         PR symtab/16264
2078         PR symtab/24517
2079         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2080
2081 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2082
2083         * source.c (find_and_open_source): Also rewrite relative file
2084         names.
2085
2086 2019-04-26  Amos Bird  <amosbird@gmail.com>
2087
2088         * annotate.c (annotate_thread_exited): Add "thread-exited"
2089         annotation.
2090
2091 2019-06-06  Tom Tromey  <tromey@adacore.com>
2092
2093         * maint.h (class scoped_command_stats): Use
2094         DISABLE_COPY_AND_ASSIGN.
2095         <print_time>: New method.
2096         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2097         print_time.
2098         (scoped_command_stats::print_time): New method.
2099
2100 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2101
2102         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2103         instructions of lengths 6 or 8 bytes.
2104
2105 2019-06-04  Pedro Alves  <palves@redhat.com>
2106
2107         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2108
2109         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2110         * breakpoint.c (condition_completer): Likewise.
2111         * cli/cli-dump.c (scan_expression): Likewise.
2112         * common/filestuff.c (mkdir_recursive): Likewise.
2113         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2114         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2115         (gdb_abspath): Likewise.
2116         * compile/compile-cplus-types.c
2117         (compile_cplus_instance::decl_name): Likewise.
2118         * completer.c (complete_explicit_location):
2119         (signal_completer, reg_or_group_completer_1): Likewise.
2120         * cp-support.c (cp_remove_params_if_any): Likewise.
2121         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2122         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2123         * infcmd.c (strip_bg_char): Likewise.
2124         * linespec.c (copy_token_string): Likewise.
2125         * mi/mi-main.c (output_cores): Likewise.
2126         * psymtab.c (psymtab_search_name):
2127         * symfile.c (test_set_ext_lang_command): Likewise.
2128         * target.c (target_fileio_read_stralloc): Likewise.
2129         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2130         * value.c (complete_internalvar): Likewise.
2131
2132 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2133
2134         Add objfile property to gdb.Type.
2135         * NEWS: Mention Python API addition.
2136         * python/py-type.c (typy_get_objfile): New method.
2137
2138 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2139
2140         * NEWS: Mention the new set|show style [title|highlight].
2141         Mention changes to "show style", "help" and "apropos".
2142
2143 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2144
2145         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2146         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2147         instead of print_help_for_command.
2148         (print_doc_of_command): New function.
2149         (help_list): Add 'apropos -v word' suggestion.
2150         (print_help_for_command): Style the command name using title style.
2151         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2152         (_initialize_cli_cmds): Describe -v in apropos_command help.
2153
2154 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2155
2156         * cli/cli-style.h (cli_style_option): Add name in constructor,
2157         add m_name class member, add constructor with intensity,
2158         add name class function.
2159         (cli_style_option::add_setshow_commands): Remove name argument.
2160         (highlight_style, title_style): New styles.
2161         * cli/cli-style.c (do_show): New function that shows a style
2162         characteristic styling the style name with itself.
2163         (set_style_name): New function.
2164         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2165         Update all callers according to the changes in cli/cli-style.h.
2166         * utils.h (fputs_highlighted): New function.
2167         * utils.c (fputs_highlighted): Likewise.
2168
2169 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2170
2171         * NEWS: Mention new pipe command and new convenience variables.
2172
2173 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2174
2175         * cli/cli-cmds.c (pipe_command): New function.
2176         (_initialize_cli_cmds): Call add_com for pipe_command.
2177         Define | as an alias for pipe.
2178         (exit_status_set_internal_vars): New function.
2179         (shell_escape): Call exit_status_set_internal_vars.
2180         cli/cli-decode.c (find_command_name_length): Recognize | as
2181         a single character command.
2182
2183 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2184
2185         * gdbcmd.h (execute_command_to_ui_file): New declaration.
2186         top.c (execute_command_to_ui_file): New function, mostly a copy
2187         of execute_command_to_string.
2188         (execute_command_to_string): Implement by calling
2189         execute_command_to_ui_file.
2190
2191 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2192
2193         * top.h (saved_command_line): Remove declaration.
2194         * top.c (previous_saved_command_line, previous_repeat_arguments):
2195         New variables.
2196         (saved_command_line): Make static, define together with other
2197         'repeat variables'.
2198         (dont_repeat): Clear repeat_arguments.
2199         (repeat_previous, get_saved_command_line, save_command_line):
2200         New functions.
2201         (gdb_init): Initialize saved_command_line
2202         and previous_saved_command_line.
2203         * main.c (captured_main_1): Remove saved_command_line initialization.
2204         * event-top.c (handle_line_of_input): Update to use
2205         the new 'repeat' related functions instead of direct access to
2206         saved_command_line.
2207         * command.h (repeat_previous, get_saved_command_line,
2208         save_command_line): New declarations.
2209         (dont_repeat): Add comment.
2210
2211 2019-05-30  Tom Tromey  <tromey@adacore.com>
2212
2213         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
2214         Fix comment.
2215         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
2216
2217 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
2218
2219         PR cli/24587
2220         * completer.c (complete): Initialize variable word.
2221
2222 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
2223
2224         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2225         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
2226         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
2227         'body' is NULL to the outter 'if', protecting the '!is_define'
2228         situation as well.
2229
2230 2019-05-29  Tom Tromey  <tromey@adacore.com>
2231
2232         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
2233         (dwarf_unknown): New function.
2234         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
2235         (dwarf_type_encoding_name): Use dwarf_unknown.
2236
2237 2019-05-29  Tom Tromey  <tromey@adacore.com>
2238
2239         PR c++/20020:
2240         * cp-valprint.c (cp_print_value_fields): Call
2241         cp_print_static_field inside "try".
2242
2243 2019-05-29  Tom Tromey  <tromey@adacore.com>
2244
2245         * inflow.c (struct terminal_info): Add default operator=.
2246         * configure: Rebuild.
2247         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
2248         -Wdeprecated-copy-dtor, -Wredundant-move.
2249
2250 2019-05-29  Tom Tromey  <tromey@adacore.com>
2251
2252         * NEWS: Add entry.
2253         * infcmd.c (print_return_value_1): Handle finish_print
2254         option.
2255         (show_print_finish): New function.
2256         (_initialize_infcmd): Add "set/show print finish" commands.
2257         * valprint.c (user_print_options): Initialize new member.
2258         * valprint.h (struct value_print_options) <finish_print>: New
2259         member.
2260
2261 2019-05-28  Tom Tromey  <tromey@adacore.com>
2262
2263         * ada-lang.c (ada_remove_Xbn_suffix)
2264         (find_old_style_renaming_symbol)
2265         (parse_old_style_renaming): Remove.
2266         (ada_find_renaming_symbol): Don't call
2267         find_old_style_renaming_symbol.
2268         (ada_is_renaming_symbol): Rename from
2269         ada_find_renaming_symbol.  Remove "block" parameter.  Return
2270         bool.  Now static.
2271         (ada_read_var_value): Update and simplify.
2272         * ada-exp.y (write_var_or_type): Remove old code.
2273
2274 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
2275
2276         * event-top.c: Remove include comment.
2277         * inflow.c (class scoped_ignore_sigttou): Move from here...
2278         * inflow.h (class scoped_ignore_sigttou): ...to here.
2279         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
2280         * top.c:  Remove include comment.
2281
2282 2019-05-27  Tom Tromey  <tom@tromey.com>
2283
2284         * NEWS: Fix typo.
2285
2286 2019-05-22  Tom Tromey  <tromey@adacore.com>
2287
2288         * target.c (target_follow_exec): Constify parameter.
2289         * target-delegates.c: Rebuild.
2290         * remote.c (remote_target::follow_exec): Constify parameter.
2291         * infrun.c (follow_exec): Constify parameter.
2292         * target.h (struct target_ops) <follow_exec>: Constify parameter.
2293         (target_follow_exec): Likewise.
2294
2295 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2296
2297         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
2298         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
2299
2300 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2301
2302         * NEWS: Add debugredirect and testsuite sections.
2303
2304 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
2305
2306         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
2307         target descriptions using exclusively floating point register name
2308         aliases.
2309
2310 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2311
2312         PR gdb/18644:
2313         * f-lang.c (build_fortran_types): Handle the case where
2314         gdbarch_floatformat_for_type returns a nullptr.
2315
2316 2019-05-21  Tom de Vries  <tdevries@suse.de>
2317
2318         PR cli/24587
2319         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
2320
2321 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2322
2323         PR gdb/18644:
2324         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
2325         16-byte floats.
2326         * i386-tdep.c (i386_floatformat_for_type): Use
2327         floatformats_ia64_quad for the 16-byte floating point component
2328         within a fortran 32-byte complex number.
2329
2330 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2331
2332         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
2333         delete default constructor.
2334         (find_partial_die): Update to return const struct.
2335         (partial_die_parent_scope): Move variable declaration into scope
2336         of its use and change its type to auto.
2337         (guess_partial_die_structure_name): Likewise.
2338         (partial_die_info::fixup): Likewise.
2339
2340 2019-05-17  Tom Tromey  <tromey@adacore.com>
2341
2342         * source.c (find_and_open_source): Remove cast.
2343
2344 2019-05-17  Tom Tromey  <tromey@adacore.com>
2345
2346         * annotate.c (annotate_source): Make "filename" const.
2347         * annotate.h (annotate_source): Use const.
2348
2349 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2350
2351         * disasm.c (set_disassembler_options): Send errors to stderr.
2352
2353 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2354
2355         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
2356         (cli_interp_base::set_logging): Check debug_redirect.
2357         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
2358         * cli/cli-logging.c (debug_redirect): Add static variable.
2359         (pop_output_files): Add default param.
2360         (handle_redirections): Print debug setting.
2361         (show_logging_command): Likewise.
2362         (_initialize_cli_logging): Add debugredirect command.
2363         * interps.c (current_interp_set_logging): Add debug_redirect
2364         parameter.
2365         * interps.h (set_logging): Add debug_redirect parameter.
2366         (current_interp_set_logging): Likewise.
2367         * mi/mi-common.h: Likewise.
2368         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
2369
2370 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2371             Tom Tromey  <tromey@adacore.com>
2372
2373         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
2374         directly.
2375         * cli/cli-interp.h (make_logging_output): Remove declaration.
2376         * cli/cli-logging.c (make_logging_output): Remove function.
2377         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
2378         directly.
2379         * ui-file.c (tee_file::tee_file): Remove bools.
2380         (tee_file::~tee_file): Remove deletes.
2381         * ui-file.h (tee_file): Remove bools.
2382
2383 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
2384
2385         * mi/mi-cmds.h (mi_cmd_complete): New function.
2386         * mi/mi-main.c (mi_cmd_complete): Likewise.
2387         * mi/mi-cmds.c: Define new MI command -complete.
2388         * NEWS: Mention new -complete command.
2389
2390 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
2391
2392         * completer.h (complete): New function.
2393         * completer.c (complete): Likewise.
2394         * cli/cli-cmds.c: (complete_command): Update to use new complete()
2395         function defined in completer.h.
2396
2397 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
2398
2399         * MAINTAINERS (Write After Approval): Add myself.
2400
2401 2019-05-17  Tom de Vries  <tdevries@suse.de>
2402
2403         PR gdb/24094
2404         * dwarf2read.c (struct cu_partial_die_info): New struct.
2405         (find_partial_die): Return cu_partial_die_info.
2406         (partial_die_parent_scope, guess_partial_die_structure_name)
2407         (partial_die_info::fixup): Handle new return type of find_partial_die.
2408
2409 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2410
2411         * stap-probe.c (stap_parse_register_operand): Make "regname" an
2412         "std::string", simplifying the algorithm.
2413
2414 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2415
2416         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2417         (stap_static_probe_ops::get_probes): Likewise.
2418
2419 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2420
2421         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2422         '-')" and "else if".
2423         (stap_parse_single_operand): Join checks for
2424         "gdbarch_stap_parse_special_token_p" and
2425         "gdbarch_stap_parse_special_token" in the same "if" statement.
2426         Invert check when verifying for operation on register
2427         displacement.
2428
2429 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2430
2431         * stap-probe.c (stap_get_opcode): Update comment.
2432         (stap_get_expected_argument_type): Likewise.
2433         (handle_stap_probe): Likewise.
2434
2435 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2436
2437         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2438         return type to 'bool'.  Adjust comment.  Use 'bool' when
2439         appropriate.
2440         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2441         * stap-probe.c (stap_parse_argument_1): Likewise.
2442         (stap_is_operator): Likewise.
2443         (stap_is_generic_prefix): Likewise.
2444         (stap_is_register_prefix): Likewise.
2445         (stap_is_register_indirection_prefix): Likewise.
2446         (stap_is_integer_prefix): Likewise.
2447         (stap_generic_check_suffix): Likewise.
2448         (stap_check_integer_suffix): Likewise.
2449         (stap_check_register_suffix): Likewise.
2450         (stap_check_register_indirection_suffix): Likewise.
2451         (stap_parse_register_operand): Likewise.
2452         (stap_parse_single_operand): Likewise.
2453         (stap_parse_argument_1): Likewise.
2454         (stap_probe::get_argument_count): Likewise.
2455         (stap_is_operator): Likewise.
2456
2457 2019-05-16  Tom Tromey  <tromey@adacore.com>
2458
2459         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2460         keyword to foreach.
2461
2462 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
2463
2464         * linux-thread-db.c (try_thread_db_load_1): Change return type
2465         to bool.
2466         (try_thread_db_load): Likewise.
2467         (try_thread_db_load_from_pdir_1): Likewise.
2468         (try_thread_db_load_from_pdir): Likewise.
2469         (try_thread_db_load_from_sdir): Likewise.
2470         (try_thread_db_load_from_dir): Likewise.
2471         (thread_db_load_search): Likewise.
2472         (has_libpthread): Likewise.
2473         (thread_db_load): Likewise.
2474
2475 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
2476
2477         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2478         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2479         NULL, and complain/return if that's the case.
2480
2481 2019-05-15  John Darrington <john@darrington.wattle.id.au>
2482
2483         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2484         (advance, posn, abstract_read_memory): New functions.
2485         [struct mem_read_abstraction]: New struct.
2486         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
2487
2488 2019-05-14  Tom Tromey  <tromey@adacore.com>
2489
2490         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
2491         value is not lval_memory.
2492
2493 2019-05-14  Tom Tromey  <tromey@adacore.com>
2494
2495         * solib.c (info_sharedlibrary_command): Style the file name.
2496
2497 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
2498
2499         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
2500         (aarch64_vnv_type): Likewise.
2501         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
2502         * common/tdesc.c: Likewise.
2503         * common/tdesc.h (enum tdesc_type_kind): Likewise.
2504         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
2505         * features/aarch64-fpu.xml: Add ieee half view.
2506         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
2507         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
2508         * gdbtypes.h (struct builtin_type): Likewise.
2509         (struct objfile_type): Likewise.
2510
2511 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
2512
2513         * language.c (language_sniff_from_mangled_name): Fix "langauge"
2514         typo.
2515         * location.h (string_to_event_location): Likewise.
2516
2517 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
2518
2519         GDB 8.3 released.
2520
2521 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2522
2523         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
2524         New variable declaration.
2525         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
2526         New variable.
2527         (print_one_breakpoint): Use ui_out::test_flags and new global
2528         variable to compute use_fixed_output.
2529         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
2530         Remove.
2531         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
2532         (mi_multi_location_breakpoint_output_fixed): Remove.
2533         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
2534         new variable.
2535         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
2536         fix_multi_location_breakpoint_output flag if version >= 3.
2537         * ui-out.h (enum ui_out_flag)
2538         <fix_multi_location_breakpoint_output>: New enumerator.
2539
2540 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2541
2542         * contrib/cc-with-tweaks.sh: Validate dwz's work.
2543
2544 2019-05-10  Tom Tromey  <tromey@adacore.com>
2545
2546         * ada-lang.c (catch_ada_completer): New function.
2547         (_initialize_ada_language): Use it.
2548
2549 2019-05-10  Tom Tromey  <tromey@adacore.com>
2550
2551         * thread.c (print_thread_info): Make "requested_threads" const.
2552         * gdbthread.h (print_thread_info): Make "requested_threads"
2553         const.
2554         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
2555         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
2556
2557 2019-05-08  Tom Tromey  <tom@tromey.com>
2558
2559         * gdbtypes.c (objfile_type_data): Change type.
2560         (objfile_type, _initialize_gdbtypes): Update.
2561
2562 2019-05-08  Tom Tromey  <tom@tromey.com>
2563
2564         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
2565         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
2566         (_initialize_dwarf2_frame): Update.
2567
2568 2019-05-08  Tom Tromey  <tom@tromey.com>
2569
2570         * objc-lang.c (objc_objfile_data): Change type.
2571         (find_methods): Update.
2572         (_initialize_objc_lang): Remove.
2573
2574 2019-05-08  Tom Tromey  <tom@tromey.com>
2575
2576         * stabsread.c (rs6000_builtin_type_data): Change type.
2577         (rs6000_builtin_type, _initialize_stabsread): Update.
2578
2579 2019-05-08  Tom Tromey  <tom@tromey.com>
2580
2581         * mips-tdep.c (mips_pdr_data): Remove.
2582         (_initialize_mips_tdep): Update.
2583
2584 2019-05-08  Tom Tromey  <tom@tromey.com>
2585
2586         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
2587         (hppa_init_objfile_priv_data, read_unwind_info)
2588         (find_unwind_entry, _initialize_hppa_tdep): Update.
2589
2590 2019-05-08  Tom Tromey  <tom@tromey.com>
2591
2592         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
2593         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
2594         on obstack.
2595         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
2596
2597 2019-05-08  Tom Tromey  <tom@tromey.com>
2598
2599         * mdebugread.c (basic_type_data): Change type.
2600         (basic_type, _initialize_mdebugread): Update.
2601
2602 2019-05-08  Tom Tromey  <tom@tromey.com>
2603
2604         * common/gdb_unique_ptr.h (struct noop_deleter): New.
2605
2606 2019-05-08  Tom Tromey  <tom@tromey.com>
2607
2608         * nto-tdep.c (nto_inferior_data_reg): Change type.
2609         (nto_inferior_data): Update.
2610         (nto_inferior_data_cleanup, nto_new_inferior_data)
2611         (_initialize_nto_tdep): Remove.
2612         * nto-tdep.h (struct nto_inferior_data): Add initializers.
2613
2614 2019-05-08  Tom Tromey  <tom@tromey.com>
2615
2616         * ada-lang.c (struct ada_inferior_data): Add initializers.
2617         (ada_inferior_data): Change type.
2618         (ada_inferior_data_cleanup): Remove.
2619         (get_ada_inferior_data, ada_inferior_exit)
2620         (struct ada_pspace_data): Add initializers, destructor.
2621         (ada_pspace_data_handle): Change type.
2622         (get_ada_pspace_data): Update.
2623         (ada_pspace_data_cleanup): Remove.
2624
2625 2019-05-08  Tom Tromey  <tom@tromey.com>
2626
2627         * coffread.c (struct coff_symfile_info): Add initializers.
2628         (coff_objfile_data_key): Move lower.  Change type.
2629         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
2630         Update.
2631         (coff_free_info): Remove.
2632
2633 2019-05-08  Tom Tromey  <tom@tromey.com>
2634
2635         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
2636         (fbsd_pspace_data_handle): Move lower.  Change type.
2637         (get_fbsd_pspace_data): Update.
2638         (fbsd_pspace_data_cleanup): Remove.
2639         (_initialize_fbsd_tdep): Update.
2640
2641 2019-05-08  Tom Tromey  <tom@tromey.com>
2642
2643         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
2644         (get_ada_tasks_pspace_data): Update.
2645         (ada_tasks_pspace_data_cleanup): Remove.
2646         (_initialize_tasks): Update.
2647         (ada_tasks_inferior_data_handle): Change type.
2648         (get_ada_tasks_inferior_data): Update.
2649         (ada_tasks_inferior_data_cleanup): Remove.
2650         (struct ada_tasks_pspace_data): Add initializers.
2651
2652 2019-05-08  Tom Tromey  <tom@tromey.com>
2653
2654         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
2655         * symfile-debug.c (debug_sym_get_probes): Change type.
2656         * stap-probe.c (handle_stap_probe):
2657         (stap_static_probe_ops::get_probes): Change type.
2658         * probe.h (class static_probe_ops) <get_probes>: Change type.
2659         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
2660         (parse_probes_in_pspace): Update.
2661         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
2662         Update.
2663         (any_static_probe_ops::get_probes): Change type.
2664         * elfread.c (elfread_data): New typedef.
2665         (probe_key): Change type.
2666         (elf_get_probes): Likewise.  Update.
2667         (probe_key_free): Remove.
2668         (_initialize_elfread): Update.
2669         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
2670         Change type.
2671         (dtrace_process_dof_probe, dtrace_process_dof)
2672         (dtrace_static_probe_ops::get_probe): Change type.
2673
2674 2019-05-08  Tom Tromey  <tom@tromey.com>
2675
2676         * xcoffread.c (struct xcoff_symfile_info): Rename from
2677         coff_symfile_info.  Add initializers.
2678         (xcoff_objfile_data_key): Move lower.  Change type.
2679         (XCOFF_DATA): Rewrite.
2680         (xcoff_free_info): Remove.
2681         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
2682         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
2683         (xcoff_initial_scan): Update.
2684
2685 2019-05-08  Tom Tromey  <tom@tromey.com>
2686
2687         * solib-svr4.c (struct svr4_info): Add initializers and
2688         destructor.
2689         <probes_table>: Now an htab_up.
2690         (solib_svr4_pspace_data): Change type.
2691         (free_probes_table): Simplify.
2692         (~svr4_info): Rename from svr4_pspace_data_cleanup.
2693         (get_svr4_info, probes_table_htab_remove_objfile_probes)
2694         (probes_table_remove_objfile_probes, register_solib_event_probe)
2695         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
2696         (_initialize_svr4_solib): Update.
2697
2698 2019-05-08  Tom Tromey  <tom@tromey.com>
2699
2700         * remote.c (remote_pspace_data): Change type.
2701         (remote_pspace_data_cleanup): Remove.
2702         (get_remote_exec_file, set_pspace_remote_exec_file)
2703         (_initialize_remote): Update.
2704
2705 2019-05-08  Tom Tromey  <tom@tromey.com>
2706
2707         * breakpoint.c (breakpoint_objfile_key): Change type.
2708         (get_breakpoint_objfile_data): Update.
2709         (free_breakpoint_objfile_data): Remove.
2710         (_initialize_breakpoint): Update.
2711
2712 2019-05-08  Tom Tromey  <tom@tromey.com>
2713
2714         * linux-tdep.c (struct linux_info): Add initializers.
2715         (linux_inferior_data): Move.  Change type.
2716         (invalidate_linux_cache_inf): Update.
2717         (linux_inferior_data_cleanup): Remove.
2718         (get_linux_inferior_data, _initialize_linux_tdep): Update.
2719
2720 2019-05-08  Tom Tromey  <tom@tromey.com>
2721
2722         * auxv.c (auxv_inferior_data): Move.  Change type.
2723         (auxv_inferior_data_cleanup): Remove.
2724         (invalidate_auxv_cache_inf): Rewrite.
2725         (get_auxv_inferior_data, _initialize_auxv): Update.
2726
2727 2019-05-08  Tom Tromey  <tom@tromey.com>
2728
2729         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
2730         (symfile_debug_objfile_data_key): Change type.
2731         (symfile_debug_installed, debug_qf_has_symbols)
2732         (debug_qf_find_last_source_symtab)
2733         (debug_qf_forget_cached_source_info)
2734         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
2735         (debug_qf_print_stats, debug_qf_dump)
2736         (debug_qf_expand_symtabs_for_function)
2737         (debug_qf_expand_all_symtabs)
2738         (debug_qf_expand_symtabs_with_fullname)
2739         (debug_qf_map_matching_symbols)
2740         (debug_qf_expand_symtabs_matching)
2741         (debug_qf_find_pc_sect_compunit_symtab)
2742         (debug_qf_map_symbol_filenames)
2743         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
2744         (debug_sym_new_init, debug_sym_init, debug_sym_read)
2745         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
2746         (debug_sym_read_linetable, debug_sym_relocate): Update.
2747         (symfile_debug_free_objfile): Remove.
2748         (install_symfile_debug_logging, _initialize_symfile_debug):
2749         Update.
2750
2751 2019-05-08  Tom Tromey  <tom@tromey.com>
2752
2753         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
2754         allocate_on_obstack.
2755         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
2756         (get_dwarf2_per_objfile): Update.
2757         (set_dwarf2_per_objfile): Remove.
2758         (dwarf2_has_info, dwarf2_get_section_info): Update.
2759         (dwarf2_free_objfile): Remove.
2760         (_initialize_dwarf2_read): Update.
2761
2762 2019-05-08  Tom Tromey  <tom@tromey.com>
2763
2764         * auto-load.c (struct auto_load_pspace_info): Add destructor and
2765         initializers.
2766         <unsupported_script_warning_printed,
2767         script_not_found_warning_printed>: Now bool.
2768         (auto_load_pspace_data): Change type.
2769         (~auto_load_pspace_info): Rename from
2770         auto_load_pspace_data_cleanup.
2771         (get_auto_load_pspace_data, init_loaded_scripts_info)
2772         (clear_section_scripts, maybe_print_unsupported_script_warning)
2773         (maybe_print_script_not_found_warning, _initialize_auto_load):
2774         Update.
2775
2776 2019-05-08  Tom Tromey  <tom@tromey.com>
2777
2778         * objfiles.c (objfile_pspace_info): Add destructor and
2779         initializers.
2780         (objfiles_pspace_data): Change type.
2781         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
2782         (get_objfile_pspace_data): Update.
2783         (objfiles_bfd_data): Change type.
2784         (get_objfile_bfd_data): Update.
2785         (objfile_bfd_data_free, _initialize_objfiles): Remove.
2786
2787 2019-05-08  Tom Tromey  <tom@tromey.com>
2788
2789         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
2790         Change type.
2791         (get_catch_syscall_inferior_data): Update.
2792         (catch_syscall_inferior_data_cleanup): Remove.
2793         (_initialize_break_catch_syscall): Update.
2794
2795 2019-05-08  Tom Tromey  <tom@tromey.com>
2796
2797         * inflow.c (struct terminal_info): Add destructor and
2798         initializers.
2799         (inflow_inferior_data): Change type.
2800         (~terminal_info): Rename from inflow_inferior_data_cleanup.
2801         (get_inflow_inferior_data, inflow_inferior_exit)
2802         (swap_terminal_info, _initialize_inflow): Update.
2803
2804 2019-05-08  Tom Tromey  <tom@tromey.com>
2805
2806         * target-dcache.c (target_dcache_cleanup): Remove.
2807         (target_dcache_aspace_key): Change type.
2808         (target_dcache_init_p, target_dcache_invalidate)
2809         (target_dcache_get, target_dcache_get_or_init)
2810         (_initialize_target_dcache): Update.
2811         * dcache.h (struct dcache_deleter): New.
2812
2813 2019-05-08  Tom Tromey  <tom@tromey.com>
2814
2815         * symtab.c (struct symbol_cache): Add destructor and
2816         initializers.
2817         (symbol_cache_key): Move.  Change type.
2818         (make_symbol_cache, free_symbol_cache): Remove.
2819         (get_symbol_cache): Update.
2820         (symbol_cache_cleanup): Remove.
2821         (ALL_PSPACES, symbol_cache_flush)
2822         (maintenance_print_symbol_cache)
2823         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
2824         Update.
2825
2826 2019-05-08  Tom Tromey  <tom@tromey.com>
2827
2828         * symtab.c (struct main_info): Add destructor and initializers.
2829         (main_progspace_key): Move.  Change type.
2830         (get_main_info): Update.
2831         (main_info_cleanup): Remove.
2832         (_initialize_symtab): Update.
2833
2834 2019-05-08  Tom Tromey  <tom@tromey.com>
2835
2836         * registry.h (DECLARE_REGISTRY): Define the _key class.
2837
2838 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2839
2840         * NEWS: Merge two 'New commands' sections.
2841
2842 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
2843
2844         * ada-valprint.c (ada_val_print_gnat_array): Remove language
2845         parameter and use Ada language definition instead.
2846         (ada_val_print_ptr): Remove unused language parameter.
2847         (ada_val_print_num): Remove language parameter and use Ada language
2848         definition instead.
2849         (ada_val_print_enum, ada_val_print_flt): Remove unused language
2850         parameter.
2851         (ada_val_print_struct_union, ada_val_print_ref): Remove language
2852         parameter and use Ada language definition instead.
2853         (ada_val_print_1): Update all ada_val_print_xxx calls.
2854         Remove language parameter.
2855         (ada_val_print): Update ada_val_print_1 call.
2856
2857 2019-05-08  Tom Tromey  <tromey@adacore.com>
2858
2859         * remote.c (remote_hw_watchpoint_limit)
2860         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
2861         Now static.
2862
2863 2019-05-08  Tom Tromey  <tromey@adacore.com>
2864
2865         * maint.c (_initialize_maint_cmds): Move initialization code to
2866         remote.c.
2867         (watchdog, show_watchdog): Move to remote.c.
2868         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
2869         "watchdog" static.
2870         (_initialize_remote): Move initialization code from maint.c.
2871         * defs.h (watchdog): Don't declare.
2872
2873 2019-05-08  Tom Tromey  <tromey@adacore.com>
2874
2875         * tui/tui-interp.c: Include main.h.
2876         * interps.c: Include main.h.
2877         * main.h (interpreter_p): Declare.
2878         * defs.h (interpreter_p): Don't declare.
2879
2880 2019-05-08  Tom Tromey  <tromey@adacore.com>
2881
2882         * dwarf2loc.c: Include dwarf2read.h.
2883         * defs.h (read_unsigned_leb128): Don't declare.
2884         * dwarf2read.h (read_unsigned_leb128): Declare.
2885
2886 2019-05-08  Tom Tromey  <tromey@adacore.com>
2887
2888         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
2889         method.
2890
2891 2019-05-08  Tom Tromey  <tromey@adacore.com>
2892
2893         * utils.c (fputs_maybe_filtered): Reset style after paging, even
2894         when no wrap column is set.
2895
2896 2019-05-08  Tom Tromey  <tromey@adacore.com>
2897
2898         * c-lang.c (c_get_string): Handle non-C-style arrays.
2899
2900 2019-05-08  Tom Tromey  <tromey@adacore.com>
2901
2902         * typeprint.c (print_offset_data::update): Print the bit offset,
2903         not the number of bits remaining.
2904
2905 2019-05-08  Tom Tromey  <tromey@adacore.com>
2906
2907         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
2908         padding at end of comment.
2909
2910 2019-05-08  Tom Tromey  <tromey@adacore.com>
2911
2912         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
2913         Compare main types.
2914
2915 2019-05-06  Tom Tromey  <tom@tromey.com>
2916
2917         * common/scoped_mmap.c: Include common-defs.h.
2918         * common/scoped_mmap.h: Don't include config.h.
2919
2920 2019-05-04  Tom Tromey  <tom@tromey.com>
2921
2922         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
2923         (struct aarch64_call_info): Add initializers.
2924         <si>: Now a std::vector.
2925         (pass_on_stack, aarch64_push_dummy_call): Update.
2926
2927 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
2928             Tom Tromey  <tom@tromey.com>
2929
2930         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
2931         (ppc_threads): Now a std::vector.  Now static.
2932         (hwdebug_find_thread_points_by_tid)
2933         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
2934         Update.
2935
2936 2019-05-04  Tom Tromey  <tom@tromey.com>
2937
2938         * arc-tdep.c (arc_tdesc_init): Return bool.
2939
2940 2019-05-04  Tom Tromey  <tom@tromey.com>
2941
2942         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
2943         Use gdb_assert_not_reached.
2944
2945 2019-05-04  Tom Tromey  <tom@tromey.com>
2946
2947         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
2948         "false".
2949
2950 2019-05-04  Tom Tromey  <tom@tromey.com>
2951
2952         * arc-tdep.c (arc_tdesc_init): Use bool.
2953
2954 2019-05-04  Tom Tromey  <tom@tromey.com>
2955
2956         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
2957
2958 2019-05-04  Tom Tromey  <tom@tromey.com>
2959
2960         * cli/cli-cmds.c (valid_command_p): Return bool.
2961
2962 2019-05-04  Tom Tromey  <tom@tromey.com>
2963
2964         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
2965         * command.h (valid_user_defined_cmd_name_p): Channge return type.
2966
2967 2019-05-04  Raul Tambre  <raul@tambre.ee>
2968
2969         * python/lib/gdb/prompt.py (_ExtendedPrompt)
2970         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
2971         operator for comparison.
2972
2973 2019-05-04  Tom Tromey  <tom@tromey.com>
2974
2975         * psymtab.c (psymbol_name_matches, match_partial_symbol)
2976         (lookup_partial_symbol, print_partial_symbols)
2977         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
2978         (psymbol_compare): Update.
2979         (add_psymbol_to_bcache): Clear the entire psymbol.
2980         (maintenance_check_psymtabs): Update.
2981         * psympriv.h (struct partial_symbol): Don't derive from
2982         general_symbol_info.
2983         <obj_section, unrelocated_address, address,
2984         set_unrelocated_address>: Update.
2985         <ginfo>: New member.
2986         * dwarf-index-write.c (write_psymbols, debug_names::insert)
2987         (debug_names::write_psymbols): Update.
2988
2989 2019-05-04  Tom de Vries  <tdevries@suse.de>
2990
2991         * contrib/cc-with-tweaks.sh: Support -n arg.
2992
2993 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2994
2995         * corelow.c (core_target::detach): Ensure frame cache and
2996         register caches are cleared.
2997         inferior.c (exit_inferior_1): Likewise.
2998
2999 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3000             Tom Tromey  <tom@tromey.com>
3001
3002         * dictionary.c (collate_pending_symbols_by_language): Remove
3003         "struct" from foreach.
3004         * symtab.c (lookup_global_symbol_from_objfile)
3005         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3006         foreach.
3007         * ser-tcp.c (net_open): Remove "struct" from foreach.
3008         * objfiles.c (objfile_relocate, objfile_rebase)
3009         (objfile_has_symbols): Remove "struct" from foreach.
3010         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3011         from foreach.
3012         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3013         foreach.
3014         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3015         "struct" from foreach.
3016         * ada-lang.c (create_excep_cond_exprs)
3017         (ada_exception_catchpoint_cond_string): Remove "struct" from
3018         foreach.
3019
3020 2019-05-03  Tom Tromey  <tromey@adacore.com>
3021
3022         * ada-exp.y (convert_char_literal): Check suffix of each
3023         enumerator.
3024
3025 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3026
3027         PR ada/21406:
3028         * ada-exp.y (yywrap): Don't define.
3029         * ada-lex.l (%option): Add noyywrap
3030         (yywrap): Remove.
3031
3032 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3033
3034         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3035         _WIN32_WINNT to the XP level, unless already defined to a higher
3036         level.
3037
3038         * unittests/parse-connection-spec-selftests.c:
3039         * ser-tcp.c:
3040         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3041         override.
3042
3043         * symfile.c (find_separate_debug_file): Remove colon from the
3044         drive spec of DOS/Windows file names of the target, so that the
3045         file name produced from DEBUGDIR and the target's directory will
3046         be valid on DOS/Windows systems.
3047
3048 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3049
3050         * rust-lang.c (val_print_struct): Handle printing structures
3051         containing strings.
3052
3053 2019-05-02  Tom Tromey  <tromey@adacore.com>
3054
3055         * valarith.c (_initialize_valarith): Remove.
3056
3057 2019-05-01  Tom Tromey  <tromey@adacore.com>
3058
3059         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3060         bitfields.
3061
3062 2019-05-01  Tom Tromey  <tromey@adacore.com>
3063
3064         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3065         for big-endian copies.
3066
3067 2019-04-30  Ali Tamur  <tamur@google.com>
3068         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3069         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3070         (read_3_bytes): New function.
3071
3072 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3073
3074         * windows-nat.c (main_thread_id): Delete.
3075         (handle_output_debug_string): Replace main_thread_id by
3076         current_event.dwThreadId.
3077         (fake_create_process): Likewise.
3078         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3079         Do not set main_thread_id.
3080         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3081         current_event.dwThreadId.
3082         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3083
3084 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3085
3086         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3087         Use current_event.dwThreadId instead of main_thread_id.
3088
3089 2019-04-30  Tom Tromey  <tromey@adacore.com>
3090
3091         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3092         (create_excep_cond_exprs): Iterate over program spaces.
3093         (ada_exception_catchpoint_cond_string): Examine all minimal
3094         symbols for exception types.
3095
3096 2019-04-30  Tom Tromey  <tromey@adacore.com>
3097
3098         PR c++/24470:
3099         * dwarf2read.c (process_structure_scope): Handle case where type
3100         has template parameters but no symbol was created.
3101
3102 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3103             Chris January  <chris.january@arm.com>
3104
3105         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3106         qualifier.
3107         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3108
3109 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3110
3111         * f-typeprint.c (f_print_type): Update rules for printing
3112         whitespace.
3113         (f_type_print_varspec_suffix): Likewise.
3114
3115 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3116             Chris January  <chris.january@arm.com>
3117
3118         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3119         function arguments.
3120
3121 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3122
3123         * f-lang.c (build_fortran_types): Change name of void type to
3124         lower case.
3125         * f-typeprint.c (f_type_print_base): Print the name of the void
3126         type, rather than a fixed string.
3127         * f-valprint.c (f_decorations): Use lower case void string.
3128
3129 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3130             Chris January  <chris.january@arm.com>
3131
3132         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3133         types for Fortran.
3134
3135 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3136             Chris January  <chris.january@arm.com>
3137             David Lecomber  <david.lecomber@arm.com>
3138
3139         * f-exp.y (BINOP_INTRINSIC): New token.
3140         (exp): New parser rule handling BINOP_INTRINSIC.
3141         (f77_keywords): Add new builtin procedures.
3142         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3143         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3144         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3145         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3146         (print_unop_subexp_f): New function.
3147         (print_binop_subexp_f): New function.
3148         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3149         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3150         (dump_subexp_body_f): Likewise.
3151         (operator_check_f): Likewise.
3152         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3153         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3154
3155 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3156
3157         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3158         UNOP_KIND.
3159         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3160         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3161         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3162         (operator_length_f): New fuction.
3163         (print_subexp_f): New function.
3164         (op_name_f): New function.
3165         (dump_subexp_body_f): New function.
3166         (operator_check_f): New function.
3167         (exp_descriptor_f): Replace standard expression handling functions
3168         with new functions.
3169         * gdb/fortran-operator.def: New file.
3170         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3171         * gdb/std-operator.def: Remove UNOP_KIND.
3172
3173 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3174
3175         * std-operator.def: Remove unbalanced, stray double quote
3176         character.
3177
3178 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3179             Chris January  <chris.january@arm.com>
3180             Daniel Everett  <daniel.everett@arm.com>
3181             Nick Forrington  <nick.forrington@arm.com>
3182             Richard Bunt  <richard.bunt@arm.com>
3183
3184         * cp-valprint.c (cp_print_value_fields): Allow an additional level
3185         of depth when printing anonymous structs or unions.
3186         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3187         Don't print either the top-level value, or the children if the
3188         max-depth is exceeded.
3189         (ppscm_print_children): When printing the key of a map, allow one
3190         extra level of depth.
3191         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3192         print either the top-level value, or the children if the max-depth
3193         is exceeded.
3194         (print_children): When printing the key of a map, allow one extra
3195         level of depth.
3196         * python/py-value.c (valpy_format_string): Add max_depth keyword.
3197         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
3198         (user_print_options): Initialise max_depth field.
3199         (val_print_scalar_or_string_type_p): New function.
3200         (val_print): Check to see if the max depth has been reached.
3201         (val_print_check_max_depth): Define new function.
3202         (show_print_max_depth): New function.
3203         (_initialize_valprint): Add 'print max-depth' option.
3204         * valprint.h (struct value_print_options) <max_depth>: New field.
3205         (val_print_check_max_depth): Declare new function.
3206         * NEWS: Document new feature.
3207
3208 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3209
3210         * ada-lang.c (ada_language_defn): Initialise new field.
3211         * c-lang.c (c_is_string_type_p): New function.
3212         (c_language_defn): Initialise new field.
3213         (cplus_language_defn): Initialise new field.
3214         (asm_language_defn): Initialise new field.
3215         (minimal_language_defn): Initialise new field.
3216         * c-lang.h (c_is_string_type_p): Declare new function.
3217         * d-lang.c (d_language_defn): Initialise new field.
3218         * f-lang.c (f_is_string_type_p): New function.
3219         (f_language_defn): Initialise new field.
3220         * go-lang.c (go_is_string_type_p): New function.
3221         (go_language_defn): Initialise new field.
3222         * language.c (default_is_string_type_p): New function.
3223         (unknown_language_defn): Initialise new field.
3224         (auto_language_defn): Initialise new field.
3225         * language.h (struct language_defn) <la_is_string_type_p>: New
3226         member variable.
3227         (default_is_string_type_p): Declare new function.
3228         * m2-lang.c (m2_language_defn): Initialise new field.
3229         * objc-lang.c (objc_language_defn): Initialise new field.
3230         * opencl-lang.c (opencl_language_defn): Initialise new field.
3231         * p-lang.c (pascal_is_string_type_p): New function.
3232         (pascal_language_defn): Initialise new field.
3233         * rust-lang.c (rust_is_string_type_p): New function.
3234         (rust_language_defn): Initialise new field.
3235
3236 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3237
3238         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
3239         New field.
3240         * ada-lang.c (ada_language_defn): Initialise new field.
3241         * c-lang.c (c_language_defn): Likewise.
3242         (cplus_language_defn): Likewise.
3243         (asm_language_defn): Likewise.
3244         (minimal_language_defn): Likewise.
3245         * d-lang.c (d_language_defn): Likewise.
3246         * f-lang.c (f_language_defn): Likewise.
3247         * go-lang.c (go_language_defn): Likewise.
3248         * language.c (unknown_language_defn): Likewise.
3249         (auto_language_defn): Likewise.
3250         * m2-lang.c (m2_language_defn): Likewise.
3251         * objc-lang.c (objc_language_defn): Likewise.
3252         * opencl-lang.c (opencl_language_defn): Likewise.
3253         * p-lang.c (pascal_language_defn): Likewise.
3254         * rust-lang.c (rust_language_defn): Likewise.
3255
3256 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3257
3258         * ada-lang.c (ada_is_character_type): Change return type to bool.
3259         (ada_is_string_type): Likewise.
3260         * ada-lang.h (ada_is_character_type): Update declaration
3261         (ada_is_string_type): Likewise.
3262
3263 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3264
3265         Support style in 'frame|thread apply'
3266
3267         * gdbcmd.h (execute_command_to_string): New term_out parameter.
3268         * record.c (record_start, record_stop): Update callers of
3269         execute_command_to_string with false.
3270         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
3271         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
3272         methods.
3273         (class string_file): New constructor with term_out parameter.
3274         Override methods term_out and can_emit_style_escape.  New member
3275         term_out.
3276         (class stdio_file): Override can_emit_style_escape.
3277         (class tee_file): Override term_out and can_emit_style_escape.
3278         * utils.h (can_emit_style_escape): Remove.
3279         * utils.c (can_emit_style_escape): Likewise.
3280         Update all callers of can_emit_style_escape (SOMESTREAM) to
3281         SOMESTREAM->can_emit_style_escape.
3282         * source-cache.c (source_cache::get_source_lines): Likewise.
3283         * stack.c (frame_apply_command_count): Call execute_command_to_string
3284         passing the term_out characteristic of the current gdb_stdout.
3285         * thread.c (thr_try_catch_cmd): Likewise.
3286         * top.c (execute_command_to_string): pass term_out parameter
3287         to construct the string_file for the command output.
3288         * ui-file.c (term_cli_styling): New function (most code moved
3289         from utils.c can_emit_style_escape).
3290         (string_file::string_file, string_file::can_emit_style_escape,
3291         stdio_file::can_emit_style_escape, tee_file::term_out,
3292         tee_file::can_emit_style_escape): New functions.
3293
3294 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3295
3296         * NEWS: Mention the new set|show may-call-functions.
3297         * infcall.c (may_call_functions_p): New variable.
3298         (show_may_call_functions_p): New function.
3299         (call_function_by_hand_dummy): Throws an error if not
3300         may-call-functions.
3301         (_initialize_infcall): Call add_setshow_boolean_cmd for
3302         may-call-functions.
3303
3304 2019-04-25  Keith Seitz  <keiths@redhat.com>
3305
3306         PR c++/24367
3307         * cp-support.c (inspect_type): Don't attempt substitutions
3308         of symbol with the same name.
3309
3310 2019-04-25  Tom Tromey  <tromey@adacore.com>
3311
3312         PR gdb/24475:
3313         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
3314         static.
3315
3316 2019-04-25  Tom Tromey  <tromey@adacore.com>
3317
3318         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
3319         rvalue reference.
3320         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
3321         (gdb_xml_parser::parse): Use std::move.
3322         * python/python-internal.h (gdbpy_convert_exception): Take a const
3323         reference.
3324         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
3325         std::move.
3326         * python/py-utils.c (gdbpy_convert_exception): Take a const
3327         reference.
3328         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3329         Use std::move.
3330         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3331         Use std::move.
3332         * mi/mi-main.c (mi_print_exception): Take a const reference.
3333         * main.c (handle_command_errors): Take a const reference.
3334         * linespec.c (parse_linespec): Use std::move.
3335         * infcall.c (run_inferior_call): Use std::move.
3336         (call_function_by_hand_dummy): Use std::move.
3337         * exec.c (try_open_exec_file): Use std::move.
3338         * exceptions.h (exception_print, exception_fprintf)
3339         (exception_print_same): Update.
3340         * exceptions.c (print_exception, exception_print)
3341         (exception_fprintf, exception_print_same): Change parameters to
3342         const reference.
3343         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
3344         * common/new-op.c: Use std::move.
3345         * common/common-exceptions.h (struct gdb_exception): Add move
3346         constructor.
3347         (struct gdb_exception_error, struct gdb_exception_quit, struct
3348         gdb_quit_bad_alloc): Change constructor to move constructor.
3349         (throw_exception): Change parameter to rvalue reference.
3350         * common/common-exceptions.c (throw_exception): Take rvalue
3351         reference.
3352         * cli/cli-interp.c (safe_execute_command): Use std::move.
3353         * breakpoint.c (insert_bp_location, location_to_sals): Use
3354         std::move.
3355
3356 2019-04-25  Tom Tromey  <tromey@adacore.com>
3357
3358         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
3359         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
3360         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
3361         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
3362         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
3363         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
3364         guile/scm-value.c: Use unpack.
3365         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
3366         gdbscm_gdb_exception.
3367         (gdbscm_throw_gdb_exception): Likewise.
3368         (struct gdbscm_gdb_exception): New.
3369         (unpack): New function.
3370         (gdbscm_wrap): Use unpack.
3371
3372 2019-04-25  Tom Tromey  <tromey@adacore.com>
3373
3374         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3375         (gdb_rl_callback_handler): Use std::move.
3376         * common/common-exceptions.h (struct gdb_exception): Add move
3377         assignment operator.
3378         (throw_exception_sjlj): Change "exception" to const reference.
3379         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
3380         (throw_exception_sjlj): Change "exception" to const reference.
3381
3382 2019-04-25  Tom Tromey  <tromey@adacore.com>
3383
3384         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
3385         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
3386         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3387         Update.
3388         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3389         Update.
3390         * mi/mi-interp.c (mi_interp::exec): Update.
3391         * linespec.c (parse_linespec): Update.
3392         * infcall.c (run_inferior_call): Update.
3393         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
3394         * guile/scm-symbol.c (gdbscm_lookup_symbol)
3395         (gdbscm_lookup_global_symbol): Update.
3396         * guile/scm-param.c (gdbscm_parameter_value): Update.
3397         * guile/scm-frame.c (gdbscm_frame_read_register)
3398         (gdbscm_frame_read_var): Update.
3399         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
3400         * exec.c (try_open_exec_file): Update.
3401         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3402         (gdb_rl_callback_handler): Update.
3403         * common/common-exceptions.h (exception_none): Don't declare.
3404         * common/common-exceptions.c (exception_none): Don't define.
3405         (struct catcher) <exception>: Update.
3406         * cli/cli-interp.c (safe_execute_command): Update.
3407         * breakpoint.c (insert_bp_location, location_to_sals): Update.
3408
3409 2019-04-25  Ali Tamur  <tamur@google.com>
3410
3411         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
3412         (read_attribute_value): Likewise.
3413         (dwarf2_read_addr_index): Update comment.
3414         (read_str_index): Add DW_FORM_strx.
3415         (dwarf2_string_attr): Likewise.
3416         (dwarf2_const_value_attr): Likewise.
3417         (dump_die_shallow): Likewise.
3418         (dwarf2_fetch_constant_bytes): Likewise.
3419         (skip_form_bytes): Likewise.
3420         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3421
3422 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
3423
3424         PR corefiles/11608
3425         PR corefiles/18187
3426         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3427         OFFSET.  Verify if current mapping contains an ELF header.
3428         (linux_find_memory_regions_full): Adjust call to
3429         dump_mapping_p.
3430
3431 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
3432             Kang Li <kanglictf@gmail.com>
3433
3434         PR gdb/21600
3435
3436         * dwarf2-frame.c (read_initial_length): Be consistent about using
3437         unsigned representation of length.
3438         (decode_frame_entry_1): Likewise.  Check for wraparound of
3439         end pointer as well as buffer overflow.
3440
3441 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3442
3443         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3444         "vq".
3445
3446 2019-04-24  Tom Tromey  <tromey@adacore.com>
3447
3448         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3449
3450 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3451
3452         * s12z-tdep.c (s12z_unwind_pc): Delete.
3453         (s12z_unwind_sp): Delete.
3454         (s12z_gdbarch_init): Don't register deleted functions with
3455         gdbarch.
3456
3457 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3458
3459         * rl78-tdep.c (rl78_unwind_sp): Delete.
3460         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3461
3462 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3463
3464         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3465         (xstormy16_unwind_pc): Delete.
3466         (xstormy16_dummy_id): Delete.
3467         (xstormy16_gdbarch_init): Don't register deleted functions with
3468         gdbarch.
3469
3470 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3471
3472         * vax-tdep.c (vax_unwind_pc): Delete.
3473         (vax_gdbarch_init): Don't register deleted function with gdbarch.
3474
3475 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3476
3477         * v850-tdep.c (v850_unwind_sp): Delete.
3478         (v850_unwind_pc): Delete.
3479         (v850_dummy_id): Delete.
3480         (v850_gdbarch_init): Don't register deleted functions with
3481         gdbarch.
3482
3483 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3484
3485         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
3486         (tilegx_unwind_pc): Delete.
3487         (tilegx_unwind_dummy_id): Delete.
3488         (tilegx_gdbarch_init): Don't register deleted functions with
3489         gdbarch.
3490
3491 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3492
3493         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
3494         (tic6x_dummy_id): Delete.
3495         (tic6x_gdbarch_init): Don't register deleted functions with
3496         gdbarch.
3497
3498 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3499
3500         * sparc-tdep.c (sparc_unwind_pc): Delete.
3501         (sparc32_gdbarch_init): Don't register deleted function with
3502         gdbarch.
3503
3504 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3505
3506         * sh-tdep.c (sh_unwind_sp): Delete.
3507         (sh_unwind_pc): Delete.
3508         (sh_dummy_id): Delete.
3509         (sh_gdbarch_init): Don't register deleted functions with
3510         gdbarch.
3511
3512 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3513
3514         * score-tdep.c (score_unwind_sp): Delete.
3515         (score_unwind_pc): Delete.
3516         (score_dummy_id): Delete.
3517         (score_gdbarch_init): Don't register deleted functions with
3518         gdbarch.
3519
3520 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3521
3522         * rx-tdep.c (rx_unwind_pc): Delete.
3523         (rx_unwind_sp): Delete.
3524         (rx_dummy_id): Delete.
3525         (rx_gdbarch_init): Don't register deleted functions with
3526         gdbarch.  Update comment.
3527
3528 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3529
3530         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
3531         (rs6000_dummy_id): Delete.
3532         (rs6000_gdbarch_init): Don't register deleted functions with
3533         gdbarch.
3534
3535 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3536
3537         * or1k-tdep.c (or1k_dummy_id): Delete.
3538         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
3539
3540 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3541
3542         * nios2-tdep.c (nios2_dummy_id): Delete.
3543         (nios2_unwind_sp): Delete.
3544         (nios2_gdbarch_init): Don't register deleted functions with
3545         gdbarch.
3546
3547 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3548
3549         * nds32-tdep.c (nds32_dummy_id): Delete.
3550         (nds32_unwind_pc): Delete.
3551         (nds32_unwind_sp): Delete.
3552         (nds32_gdbarch_init): Don't register deleted functions with
3553         gdbarch.
3554
3555 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3556
3557         * msp430-tdep.c (msp430_unwind_pc): Delete.
3558         (msp430_unwind_sp): Delete.
3559         (msp430_dummy_id): Delete.
3560         (msp430_gdbarch_init): Don't register deleted functions with
3561         gdbarch.
3562
3563 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3564
3565         * moxie-tdep.c (moxie_unwind_sp): Delete.
3566         (moxie_unwind_pc): Delete.
3567         (moxie_dummy_id): Delete.
3568         (moxie_gdbarch_init): Don't register deleted functions with
3569         gdbarch.
3570
3571 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3572
3573         * mn10300-tdep.c (mn10300_dummy_id): Delete.
3574         (mn10300_unwind_pc): Delete.
3575         (mn10300_unwind_sp): Delete.
3576         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
3577         mn10300_unwind_sp.
3578         (mn10300_frame_unwind_init): Don't register deleted functions with
3579         gdbarch.
3580
3581 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3582
3583         * mep-tdep.c (mep_unwind_pc): Delete.
3584         (mep_unwind_sp): Delete.
3585         (mep_dummy_id): Delete.
3586         (mep_gdbarch_init): Don't register deleted functions with
3587         gdbarch.
3588
3589 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3590
3591         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
3592         (m68hc11_unwind_sp): Delete.
3593         (m68hc11_gdbarch_init): Don't register deleted functions with
3594         gdbarch.
3595
3596 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3597
3598         * m32r-tdep.c (m32r_unwind_sp): Delete.
3599         (m32r_unwind_pc): Delete.
3600         (m32r_dummy_id): Delete.
3601         (m32r_gdbarch_init): Don't register deleted functions with
3602         gdbarch.
3603
3604 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3605
3606         * m32c-tdep.c (m32c_unwind_pc): Delete.
3607         (m32c_unwind_sp): Delete.
3608         (m32c_dummy_id): Delete.
3609         (m32c_gdbarch_init): Don't register deleted functions with
3610         gdbarch.
3611
3612 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3613
3614         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
3615         (lm32_unwind_pc): Delete.
3616         (lm32_dummy_id): Delete.
3617         (lm32_gdbarch_init): Don't register deleted functions with
3618         gdbarch.
3619
3620 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3621
3622         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
3623         (iq2000_unwind_pc): Delete.
3624         (iq2000_dummy_id): Delete.
3625         (iq2000_gdbarch_init): Don't register deleted functions with
3626         gdbarch.
3627
3628 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3629
3630         * nds32-tdep.c (nds32_type_align): Delete.
3631         (nds32_push_dummy_call): Use type_align instead.
3632
3633 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3634
3635         * arm-tdep.c (arm_type_align): Only handle vector override case.
3636         (arm_push_dummy_call): Use type_align.
3637         (arm_gdbarch_init): Register arm_type_align gdbarch function.
3638
3639 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3640
3641         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
3642         case.
3643         (pass_on_stack): Use type_align.
3644         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
3645         function.
3646
3647 2019-04-23  Tom Tromey  <tromey@adacore.com>
3648
3649         * dwarf2read.c (line_header::file_name_at): Remove unused
3650         overload.
3651
3652 2019-04-23  Tom de Vries  <tdevries@suse.de>
3653
3654         PR gdb/24438
3655         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
3656         invocation.
3657
3658
3659 2019-03-27  Ali Tamur  <tamur@google.com>
3660
3661         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
3662         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
3663         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
3664         (dwarf_expr_context::get_addr_index): Likewise
3665         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
3666         (symbol_needs_eval_context::get_addr_index): Likewise
3667         (disassemble_dwarf_expression): Add DW_OP_addrx
3668         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
3669         (read_cutu_die_from_dwo): Update comment
3670         (skip_one_die): Add DW_FORM_addrx
3671         (read_attribute_value): Likewise
3672         (var_decode_location): Add DW_OP_addrx
3673         (dwarf2_const_value_attr): Add DW_FORM_addrx
3674         (dump_die_shallow): Likewise
3675         (dwarf2_fetch_constant_bytes): Likewise
3676         (decode_locdesc): Add DW_OP_addrx
3677         (skip_form_bytes): Add DW_FORM_addrx
3678
3679 2019-04-22  Ali Tamur  <tamur@google.com>
3680
3681         * MAINTAINERS (Write After Approval): Add self.
3682
3683 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
3684
3685         * solib-svr4.c (get_svr4_info): Add pspace parameter.
3686         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
3687         (open_symbol_file_object): Likewise.
3688         (svr4_default_sos): Add info parameter.
3689         (svr4_read_so_list): Likewise.
3690         (svr4_current_sos_direct): Adjust functions calls to pass down
3691         info.
3692         (svr4_current_sos_1): Add info parameter.
3693         (svr4_current_sos): Call get_svr4_info, pass info down to
3694         svr4_current_sos_1.
3695         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
3696         get_svr4_info.
3697         (svr4_in_dynsym_resolve_code): Pass current_program_space to
3698         get_svr4_info.
3699         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
3700         to get_svr4_info.
3701         (probes_table_remove_objfile_probes): Likewise.
3702         (register_solib_event_probe): Add info parameter.
3703         (solist_update_incremental): Pass info parameter down to
3704         svr4_read_so_list.
3705         (disable_probes_interface): Add info parameter.
3706         (svr4_handle_solib_event): Pass current_program_space to
3707         get_svr4_info.  Adjust disable_probes_interface cleanup.
3708         (svr4_create_probe_breakpoints): Add info parameter, pass it
3709         down to register_solib_event_probe.
3710         (svr4_create_solib_event_breakpoints): Add info parameter,
3711         pass it down to svr4_create_probe_breakpoints.
3712         (enable_break): Pass info down to
3713         svr4_create_solib_event_breakpoints.
3714         (svr4_solib_create_inferior_hook): Pass current_program_space to
3715         get_svr4_info.
3716         (svr4_clear_solib): Likewise.
3717
3718 2019-04-22  Pedro Alves  <palves@redhat.com>
3719
3720         * solib-svr4.c (svr4_free_objfile_observer): New.
3721         (probe_and_action::objfile): New field.
3722         (probes_table_htab_remove_objfile_probes)
3723         (probes_table_remove_objfile_probes): New functions.
3724         (register_solib_event_probe): Add 'objfile' parameter.  Store it
3725         in the new probe_and_action.  Don't store the probe in 'lookup'.
3726         (svr4_create_probe_breakpoints): Pass objfile to
3727         register_solib_event_probe.
3728         (_initialize_svr4_solib): Register a free_objfile observer.
3729
3730 2019-04-19  Tom Tromey  <tom@tromey.com>
3731
3732         * common/queue.h: Remove.
3733
3734 2019-04-19  Tom Tromey  <tom@tromey.com>
3735
3736         * event-loop.c: Don't include "common/queue.h".
3737
3738 2019-04-19  Tom Tromey  <tom@tromey.com>
3739
3740         * remote.c (remote_target): Use delete.
3741         * remote-notif.h: Include <list>, not "common/queue.h".
3742         (notif_client_p): Remove typedef.
3743         (remote_notif_state): Add constructor, destructor, initializer.
3744         <notif_queue>: Now a std::list.
3745         (remote_notif_state_xfree): Don't declare.
3746         * remote-notif.c (remote_notif_process, handle_notification)
3747         (remote_notif_state_allocate): Update.
3748         (~remote_notif_state): Rename from remote_notif_state_xfree.
3749
3750 2019-04-19  Tom Tromey  <tom@tromey.com>
3751
3752         * symfile.c (reread_symbols): Update.
3753         * objfiles.c (objfile_register_static_link)
3754         (objfile_lookup_static_link): Update
3755         (~objfile) Don't delete static_links.
3756         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
3757
3758 2019-04-19  Tom Tromey  <tom@tromey.com>
3759
3760         * type-stack.h (struct type_stack) <insert>: Constify string.
3761         * type-stack.c (type_stack::insert): Constify string.
3762         * gdbtypes.h (lookup_template_type): Update.
3763         (address_space_name_to_int): Update.
3764         * gdbtypes.c (address_space_name_to_int): Make space_identifier
3765         const.
3766         (lookup_template_type): Make name const.
3767         * c-exp.y: Update rules.
3768         (lex_one_token, classify_name, classify_inner_name)
3769         (c_print_token): Update.
3770         * p-exp.y: Update rules.
3771         (yylex): Update.
3772         * f-exp.y: Update rules.
3773         (yylex): Update.
3774         * d-exp.y: Update rules.
3775         (lex_one_token, classify_name, classify_inner_name): Update.
3776         * parse.c (write_dollar_variable, copy_name): Return std::string.
3777         * parser-defs.h (copy_name): Change return type.
3778         * m2-exp.y: Update rules.
3779         (yylex): Update.
3780         * go-exp.y (lex_one_token): Update.
3781         Update rules.
3782         (classify_unsafe_function, classify_packaged_name)
3783         (classify_name, yylex): Update.
3784
3785 2019-04-19  Sergei Trofimovich <siarheit@google.com>
3786
3787         * configure.ac: add --enable-source-highlight switch.
3788         * configure: Regenerate.
3789         * top.c (print_gdb_version): plumb --enable-source-highlight
3790         status to "show configuration".
3791
3792 2019-04-19  Tom Tromey  <tromey@adacore.com>
3793
3794         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
3795         Check ADA_TYPE_P.
3796         (empty_record, ada_template_to_fixed_record_type_1)
3797         (template_to_static_fixed_type)
3798         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
3799         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
3800         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
3801         macros.
3802
3803 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
3804
3805         PR symtab/24423:
3806         * source.c (print_source_lines_base): Advance "iter" when a
3807         control character is seen.
3808
3809 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3810
3811         * inferior.h (struct infcall_suspend_state_deleter):
3812         Catch exception in destructor to avoid crash.
3813
3814 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3815
3816         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
3817         close to the add_com "shell".
3818
3819 2019-04-18  Tom Tromey  <tromey@adacore.com>
3820
3821         * process-stratum-target.h (class process_stratum_target)
3822         <stratum>: Add "final".
3823
3824 2019-04-17  Tom Tromey  <tromey@adacore.com>
3825
3826         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
3827         against nullptr before use.
3828
3829 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
3830
3831         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
3832
3833 2019-04-17  Jim Wilson  <jimw@sifive.com>
3834             Andrew Burgess  <andrew.burgess@embecosm.com>
3835
3836         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
3837         code read might fail, assume 4-byte breakpoint in that case.
3838
3839 2019-04-15  Leszek Swirski  <leszeks@google.com>
3840
3841         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
3842         rather than a hand-rolled POD check when checking for forced MEMORY
3843         classification.
3844
3845 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3846
3847         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
3848         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
3849         function.
3850         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
3851         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
3852         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
3853         declaration.
3854
3855 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3856
3857         * aarch64-linux-nat.c
3858         (aarch64_linux_nat_target::thread_architecture): Add override.
3859         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
3860         each VQ.
3861
3862 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3863
3864         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
3865
3866 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
3867
3868         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
3869         target types of size 96-bits, add some additional comments, and
3870         check that the builtin type we found was the correct size.
3871
3872 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
3873
3874         * utils.c (prompt_for_continue): Don't restore the styling at the
3875         end, as applied_style has the wrong value.  This fixes styling in
3876         long lists of file names that are interrupted by the "Continue?"
3877         prompt.
3878
3879 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3880
3881         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
3882         * c-lang.c (c_language_defn): Likewise.
3883         (cplus_language_defn): Likewise.
3884         (asm_language_defn): Likewise.
3885         (minimal_language_defn): Likewise.
3886         * d-lang.c (d_language_defn): Likewise.
3887         * f-lang.c (f_language_defn): Likewise.
3888         * go-lang.c (go_language_defn): Likewise.
3889         * language.c (unknown_language_defn): Likewise.
3890         (auto_language_defn): Likewise.
3891         * language.h (struct language_defn): Remove la_magic field.
3892         (LANG_MAGIC): Delete.
3893         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
3894         * objc-lang.c (objc_language_defn): Likewise.
3895         * opencl-lang.c (opencl_language_defn): Likewise.
3896         * p-lang.c (pascal_language_defn): Likewise.
3897         * rust-lang.c (rust_language_defn): Likewise.
3898
3899 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3900
3901         * riscv-tdep.c (riscv_type_align): New function.
3902         (riscv_type_alignment): Delete.
3903         (riscv_arg_location): Use 'type_align'.
3904         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
3905
3906 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3907
3908         * gdbtypes.c (type_align): A struct with no non-static fields also
3909         has alignment of 1.
3910
3911 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3912
3913         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
3914         component to 0.
3915         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
3916         member.
3917         (riscv_struct_info::analyse): New implementation using new
3918         analyse_inner member function.
3919         (riscv_struct_info::field_offset): New member function.
3920         (riscv_struct_info::m_offsets): New member variable.
3921         (riscv_struct_info::analyse_inner): New private member function,
3922         takes the old implementation of riscv_struct_info::analyse but
3923         extended to track field offsets.
3924         (riscv_call_arg_struct): Update the struct folding special cases
3925         to handle cases where empty C++ structs, which are non-zero
3926         length, are found.
3927         (riscv_arg_location): Initialise the length of each location, a
3928         non-zero length now indicates the location is in use.
3929         (riscv_push_dummy_call): Allow for the first location having a
3930         non-zero offset when setting up arguments.
3931         (riscv_return_value): Likewise, but for return values.
3932
3933 2019-04-11  Tom Tromey  <tromey@adacore.com>
3934
3935         * utils.c (internal_vproblem): Make "msg" const.
3936
3937 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
3938
3939         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
3940         * trad-frame.c (trad_frame_reset_saved_regs): New function.
3941         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
3942         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
3943
3944 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
3945
3946         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
3947         function.
3948         (fill_gregset): Call amd64_linux_collect_native_gregset instead
3949         of amd64_collect_native_gregset.
3950         (amd64_linux_nat_target::store_registers): Likewise.
3951
3952 2019-04-10  Tom Tromey  <tom@tromey.com>
3953
3954         * symtab.c (lookup_global_symbol_from_objfile)
3955         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
3956         * objfiles.h (class separate_debug_iterator): New.
3957         (class separate_debug_range): New.
3958         (struct objfile) <separate_debug_objfiles>: New method.
3959         (objfile_separate_debug_iterate): Don't declare.
3960         * objfiles.c (separate_debug_iterator::operator++): Rename from
3961         objfile_separate_debug_iterate.
3962         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
3963         iterator.
3964         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
3965         iterator.
3966
3967 2019-04-10  Tom Tromey  <tom@tromey.com>
3968
3969         * symfile.c (reread_symbols): Remove old comment.
3970         * objfiles.c (free_all_objfiles): Fix a typo.
3971
3972 2019-04-10  Tom Tromey  <tom@tromey.com>
3973
3974         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
3975         * minsyms.c (lookup_minimal_symbol): Use foreach.
3976         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
3977         (lookup_minimal_symbol_solib_trampoline): Likewise.
3978         * symfile.c (reread_symbols): Use foreach.
3979
3980 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
3981             Tom Tromey  <tromey@adacore.com>
3982
3983         PR rust/24414:
3984         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
3985         (rust_lex_int_test): Change "value" to be LONGEST.
3986         (rust_lex_tests): Add test for long integer literal.
3987
3988 2019-04-09  Tom Tromey  <tromey@adacore.com>
3989
3990         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
3991         to bool.
3992         (extended_remote_target::attach): Update.
3993         (remote_target::remote_notice_new_inferior): Update.
3994         (remote_target::add_current_inferior_and_thread): Update.
3995         * inferior.c (exit_inferior_1): Use "false".
3996         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
3997
3998 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
3999
4000         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4001         the "start" command.
4002
4003 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4004
4005         * python/py-inferior.c (infpy_thread_from_thread_handle):
4006         Adjust comments to reflect renaming of thread_from_thread_handle
4007         to thread_from_handle.  Adjust keywords.  Fix type error message.
4008         (inferior_object_methods): Add thread_from_handle.  Retain
4009         thread_from_thread_handle, but mark it as deprecated.
4010
4011 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4012
4013         * gdbthread.h (find_thread_by_handle): Revise declaration.
4014         * thread.c (find_thread_by_handle): Likewise.  Adjust
4015         implementation too.
4016         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4017         support for buffer objects as handles.
4018
4019 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4020
4021         * python/py-infthread.c (thpy_thread_handle): New function.
4022         (thread_object_methods): Register thpy_thread_handle.
4023
4024 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4025
4026         * gdbthread.h (thread_to_thread_handle): Declare.
4027         * thread.c (gdbtypes.h): Include.
4028         (thread_to_thread_handle): New function.
4029
4030         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4031         (target_thread_info_to_thread_handle): Declare.
4032         * target.c (target_thread_info_to_thread_handle): New function.
4033         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4034         * target-delegates.c: Regenerate.
4035
4036         * linux-thread-db.c (class thread_db_target): Add method
4037         thread_info_to_thread_handle.
4038         (thread_db_target::thread_info_to_thread_handle): Define.
4039         * remote.c (class remote_target): Add new method
4040         thread_info_to_thread_handle.
4041         (remote_target::thread_info_to_thread_handle): Define.
4042
4043 2019-04-08  Pedro Alves  <palves@redhat.com>
4044
4045         * common/common-exceptions.c (throw_exception): Don't create
4046         named object to throw; throw directly.
4047         (throw_it): Likewise.  Don't initialize gdb_exception::message
4048         here, with new; pass FMT and AP to the ctor instead.
4049         * common/common-exceptions.h: Include <string>.
4050         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4051         const char *, va_list)): New ctor.  Use std::make_shared.
4052         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4053         errors)): Delete.
4054         (gdb_exception_error::gdb_exception_error(enum errors, const char
4055         *, va_list)): New.
4056         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4057         Add assertion.
4058         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4059         errors)): Delete.
4060         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4061         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4062         Add assertion.
4063
4064 2019-04-08  Tom Tromey  <tom@tromey.com>
4065
4066         * valops.c (value_rtti_indirect_type): Replace throw_exception
4067         with throw.
4068         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4069         with throw.
4070         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4071         throw.
4072         * target.c (target_translate_tls_address): Replace throw_exception
4073         with throw.
4074         * stack.c (frame_apply_command_count): Replace throw_exception
4075         with throw.
4076         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4077         throw.
4078         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4079         with throw.
4080         * rs6000-tdep.c (rs6000_frame_cache)
4081         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4082         * remote.c: Replace throw_exception with throw.
4083         * record-full.c (record_full_message, record_full_wait_1)
4084         (record_full_restore): Replace throw_exception with throw.
4085         * record-btrace.c:
4086         (get_thread_current_frame_id, record_btrace_start_replaying)
4087         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4088         (cmd_record_btrace_start): Replace throw_exception with throw.
4089         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4090         throw.
4091         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4092         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4093         * linespec.c:
4094         (find_linespec_symbols): Replace throw_exception with throw.
4095         * infrun.c (displaced_step_prepare, resume): Replace
4096         throw_exception with throw.
4097         * infcmd.c (post_create_inferior): Replace throw_exception with
4098         throw.
4099         * inf-loop.c (inferior_event_handler): Replace throw_exception
4100         with throw.
4101         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4102         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4103         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4104         (get_prev_frame_always, get_frame_pc_if_available)
4105         (get_frame_address_in_block_if_available, get_frame_language):
4106         Replace throw_exception with throw.
4107         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4108         throw_exception with throw.
4109         * eval.c (fetch_subexp_value, evaluate_var_value)
4110         (evaluate_funcall, evaluate_subexp_standard): Replace
4111         throw_exception with throw.
4112         * dwarf2loc.c (call_site_find_chain)
4113         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4114         Replace throw_exception with throw.
4115         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4116         with throw.
4117         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4118         throw.
4119         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4120         * completer.c (complete_line_internal): Replace throw_exception
4121         with throw.
4122         * compile/compile-object-run.c (compile_object_run): Replace
4123         throw_exception with throw.
4124         * cli/cli-script.c (process_next_line): Replace throw_exception
4125         with throw.
4126         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4127         (btrace_enable, btrace_maint_update_pt_packets): Replace
4128         throw_exception with throw.
4129         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4130         throw_exception with throw.
4131         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4132         throw_exception with throw.
4133         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4134         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4135         * aarch64-tdep.c (aarch64_make_prologue_cache)
4136         (aarch64_make_stub_cache): Replace throw_exception with throw.
4137
4138 2019-04-08  Tom Tromey  <tom@tromey.com>
4139
4140         * common/common-exceptions.c (throw_exception): Rename from
4141         throw_exception_cxx.  Remove old copy.  Make argument const.
4142         (throw_it): Create and throw exception objects directly.
4143         * common/common-exceptions.h (throw_exception): Make argument
4144         const.
4145         (struct gdb_exception_error): Add constructor.
4146         (struct gdb_exception_quit): Add constructor.
4147
4148 2019-04-08  Tom Tromey  <tom@tromey.com>
4149
4150         * common/common-exceptions.h (exception_rethrow): Don't declare.
4151         (TRY_SJLJ): Update comment.
4152         (TRY, CATCH, END_CATCH): Remove.
4153         * common/common-exceptions.c (exception_rethrow): Remove.
4154
4155 2019-04-08  Tom Tromey  <tom@tromey.com>
4156
4157         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4158         Remove.
4159         (gdb_exception_error): Rename from
4160         gdb_exception_RETURN_MASK_ERROR.
4161         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4162         (gdb_quit_bad_alloc): Update.
4163         * aarch64-tdep.c: Update.
4164         * ada-lang.c: Update.
4165         * ada-typeprint.c: Update.
4166         * ada-valprint.c: Update.
4167         * amd64-tdep.c: Update.
4168         * arch-utils.c: Update.
4169         * break-catch-throw.c: Update.
4170         * breakpoint.c: Update.
4171         * btrace.c: Update.
4172         * c-varobj.c: Update.
4173         * cli/cli-cmds.c: Update.
4174         * cli/cli-interp.c: Update.
4175         * cli/cli-script.c: Update.
4176         * common/common-exceptions.c: Update.
4177         * common/new-op.c: Update.
4178         * common/selftest.c: Update.
4179         * compile/compile-c-symbols.c: Update.
4180         * compile/compile-cplus-symbols.c: Update.
4181         * compile/compile-object-load.c: Update.
4182         * compile/compile-object-run.c: Update.
4183         * completer.c: Update.
4184         * corelow.c: Update.
4185         * cp-abi.c: Update.
4186         * cp-support.c: Update.
4187         * cp-valprint.c: Update.
4188         * darwin-nat.c: Update.
4189         * disasm-selftests.c: Update.
4190         * dtrace-probe.c: Update.
4191         * dwarf-index-cache.c: Update.
4192         * dwarf-index-write.c: Update.
4193         * dwarf2-frame-tailcall.c: Update.
4194         * dwarf2-frame.c: Update.
4195         * dwarf2loc.c: Update.
4196         * dwarf2read.c: Update.
4197         * eval.c: Update.
4198         * event-loop.c: Update.
4199         * event-top.c: Update.
4200         * exec.c: Update.
4201         * f-valprint.c: Update.
4202         * fbsd-tdep.c: Update.
4203         * frame-unwind.c: Update.
4204         * frame.c: Update.
4205         * gdbtypes.c: Update.
4206         * gnu-v3-abi.c: Update.
4207         * guile/guile-internal.h: Update.
4208         * guile/scm-block.c: Update.
4209         * guile/scm-breakpoint.c: Update.
4210         * guile/scm-cmd.c: Update.
4211         * guile/scm-disasm.c: Update.
4212         * guile/scm-frame.c: Update.
4213         * guile/scm-lazy-string.c: Update.
4214         * guile/scm-math.c: Update.
4215         * guile/scm-param.c: Update.
4216         * guile/scm-ports.c: Update.
4217         * guile/scm-pretty-print.c: Update.
4218         * guile/scm-symbol.c: Update.
4219         * guile/scm-symtab.c: Update.
4220         * guile/scm-type.c: Update.
4221         * guile/scm-value.c: Update.
4222         * i386-linux-tdep.c: Update.
4223         * i386-tdep.c: Update.
4224         * inf-loop.c: Update.
4225         * infcall.c: Update.
4226         * infcmd.c: Update.
4227         * infrun.c: Update.
4228         * jit.c: Update.
4229         * language.c: Update.
4230         * linespec.c: Update.
4231         * linux-fork.c: Update.
4232         * linux-nat.c: Update.
4233         * linux-tdep.c: Update.
4234         * linux-thread-db.c: Update.
4235         * main.c: Update.
4236         * mi/mi-cmd-break.c: Update.
4237         * mi/mi-cmd-stack.c: Update.
4238         * mi/mi-interp.c: Update.
4239         * mi/mi-main.c: Update.
4240         * objc-lang.c: Update.
4241         * p-valprint.c: Update.
4242         * parse.c: Update.
4243         * ppc-linux-tdep.c: Update.
4244         * printcmd.c: Update.
4245         * python/py-arch.c: Update.
4246         * python/py-breakpoint.c: Update.
4247         * python/py-cmd.c: Update.
4248         * python/py-finishbreakpoint.c: Update.
4249         * python/py-frame.c: Update.
4250         * python/py-framefilter.c: Update.
4251         * python/py-gdb-readline.c: Update.
4252         * python/py-inferior.c: Update.
4253         * python/py-infthread.c: Update.
4254         * python/py-lazy-string.c: Update.
4255         * python/py-linetable.c: Update.
4256         * python/py-objfile.c: Update.
4257         * python/py-param.c: Update.
4258         * python/py-prettyprint.c: Update.
4259         * python/py-progspace.c: Update.
4260         * python/py-record-btrace.c: Update.
4261         * python/py-record.c: Update.
4262         * python/py-symbol.c: Update.
4263         * python/py-type.c: Update.
4264         * python/py-unwind.c: Update.
4265         * python/py-utils.c: Update.
4266         * python/py-value.c: Update.
4267         * python/python.c: Update.
4268         * record-btrace.c: Update.
4269         * record-full.c: Update.
4270         * remote-fileio.c: Update.
4271         * remote.c: Update.
4272         * riscv-tdep.c: Update.
4273         * rs6000-aix-tdep.c: Update.
4274         * rs6000-tdep.c: Update.
4275         * rust-exp.y: Update.
4276         * rust-lang.c: Update.
4277         * s390-tdep.c: Update.
4278         * selftest-arch.c: Update.
4279         * solib-dsbt.c: Update.
4280         * solib-frv.c: Update.
4281         * solib-spu.c: Update.
4282         * solib-svr4.c: Update.
4283         * solib.c: Update.
4284         * sparc64-linux-tdep.c: Update.
4285         * stack.c: Update.
4286         * symfile-mem.c: Update.
4287         * symmisc.c: Update.
4288         * target.c: Update.
4289         * thread.c: Update.
4290         * top.c: Update.
4291         * tracefile-tfile.c: Update.
4292         * tui/tui.c: Update.
4293         * typeprint.c: Update.
4294         * unittests/cli-utils-selftests.c: Update.
4295         * unittests/parse-connection-spec-selftests.c: Update.
4296         * valops.c: Update.
4297         * valprint.c: Update.
4298         * value.c: Update.
4299         * varobj.c: Update.
4300         * windows-nat.c: Update.
4301         * x86-linux-nat.c: Update.
4302         * xml-support.c: Update.
4303
4304 2019-04-08  Tom Tromey  <tom@tromey.com>
4305
4306         * xml-support.c: Use C++ exception handling.
4307         * x86-linux-nat.c: Use C++ exception handling.
4308         * windows-nat.c: Use C++ exception handling.
4309         * varobj.c: Use C++ exception handling.
4310         * value.c: Use C++ exception handling.
4311         * valprint.c: Use C++ exception handling.
4312         * valops.c: Use C++ exception handling.
4313         * unittests/parse-connection-spec-selftests.c: Use C++ exception
4314         handling.
4315         * unittests/cli-utils-selftests.c: Use C++ exception handling.
4316         * typeprint.c: Use C++ exception handling.
4317         * tui/tui.c: Use C++ exception handling.
4318         * tracefile-tfile.c: Use C++ exception handling.
4319         * top.c: Use C++ exception handling.
4320         * thread.c: Use C++ exception handling.
4321         * target.c: Use C++ exception handling.
4322         * symmisc.c: Use C++ exception handling.
4323         * symfile-mem.c: Use C++ exception handling.
4324         * stack.c: Use C++ exception handling.
4325         * sparc64-linux-tdep.c: Use C++ exception handling.
4326         * solib.c: Use C++ exception handling.
4327         * solib-svr4.c: Use C++ exception handling.
4328         * solib-spu.c: Use C++ exception handling.
4329         * solib-frv.c: Use C++ exception handling.
4330         * solib-dsbt.c: Use C++ exception handling.
4331         * selftest-arch.c: Use C++ exception handling.
4332         * s390-tdep.c: Use C++ exception handling.
4333         * rust-lang.c: Use C++ exception handling.
4334         * rust-exp.y: Use C++ exception handling.
4335         * rs6000-tdep.c: Use C++ exception handling.
4336         * rs6000-aix-tdep.c: Use C++ exception handling.
4337         * riscv-tdep.c: Use C++ exception handling.
4338         * remote.c: Use C++ exception handling.
4339         * remote-fileio.c: Use C++ exception handling.
4340         * record-full.c: Use C++ exception handling.
4341         * record-btrace.c: Use C++ exception handling.
4342         * python/python.c: Use C++ exception handling.
4343         * python/py-value.c: Use C++ exception handling.
4344         * python/py-utils.c: Use C++ exception handling.
4345         * python/py-unwind.c: Use C++ exception handling.
4346         * python/py-type.c: Use C++ exception handling.
4347         * python/py-symbol.c: Use C++ exception handling.
4348         * python/py-record.c: Use C++ exception handling.
4349         * python/py-record-btrace.c: Use C++ exception handling.
4350         * python/py-progspace.c: Use C++ exception handling.
4351         * python/py-prettyprint.c: Use C++ exception handling.
4352         * python/py-param.c: Use C++ exception handling.
4353         * python/py-objfile.c: Use C++ exception handling.
4354         * python/py-linetable.c: Use C++ exception handling.
4355         * python/py-lazy-string.c: Use C++ exception handling.
4356         * python/py-infthread.c: Use C++ exception handling.
4357         * python/py-inferior.c: Use C++ exception handling.
4358         * python/py-gdb-readline.c: Use C++ exception handling.
4359         * python/py-framefilter.c: Use C++ exception handling.
4360         * python/py-frame.c: Use C++ exception handling.
4361         * python/py-finishbreakpoint.c: Use C++ exception handling.
4362         * python/py-cmd.c: Use C++ exception handling.
4363         * python/py-breakpoint.c: Use C++ exception handling.
4364         * python/py-arch.c: Use C++ exception handling.
4365         * printcmd.c: Use C++ exception handling.
4366         * ppc-linux-tdep.c: Use C++ exception handling.
4367         * parse.c: Use C++ exception handling.
4368         * p-valprint.c: Use C++ exception handling.
4369         * objc-lang.c: Use C++ exception handling.
4370         * mi/mi-main.c: Use C++ exception handling.
4371         * mi/mi-interp.c: Use C++ exception handling.
4372         * mi/mi-cmd-stack.c: Use C++ exception handling.
4373         * mi/mi-cmd-break.c: Use C++ exception handling.
4374         * main.c: Use C++ exception handling.
4375         * linux-thread-db.c: Use C++ exception handling.
4376         * linux-tdep.c: Use C++ exception handling.
4377         * linux-nat.c: Use C++ exception handling.
4378         * linux-fork.c: Use C++ exception handling.
4379         * linespec.c: Use C++ exception handling.
4380         * language.c: Use C++ exception handling.
4381         * jit.c: Use C++ exception handling.
4382         * infrun.c: Use C++ exception handling.
4383         * infcmd.c: Use C++ exception handling.
4384         * infcall.c: Use C++ exception handling.
4385         * inf-loop.c: Use C++ exception handling.
4386         * i386-tdep.c: Use C++ exception handling.
4387         * i386-linux-tdep.c: Use C++ exception handling.
4388         * guile/scm-value.c: Use C++ exception handling.
4389         * guile/scm-type.c: Use C++ exception handling.
4390         * guile/scm-symtab.c: Use C++ exception handling.
4391         * guile/scm-symbol.c: Use C++ exception handling.
4392         * guile/scm-pretty-print.c: Use C++ exception handling.
4393         * guile/scm-ports.c: Use C++ exception handling.
4394         * guile/scm-param.c: Use C++ exception handling.
4395         * guile/scm-math.c: Use C++ exception handling.
4396         * guile/scm-lazy-string.c: Use C++ exception handling.
4397         * guile/scm-frame.c: Use C++ exception handling.
4398         * guile/scm-disasm.c: Use C++ exception handling.
4399         * guile/scm-cmd.c: Use C++ exception handling.
4400         * guile/scm-breakpoint.c: Use C++ exception handling.
4401         * guile/scm-block.c: Use C++ exception handling.
4402         * guile/guile-internal.h: Use C++ exception handling.
4403         * gnu-v3-abi.c: Use C++ exception handling.
4404         * gdbtypes.c: Use C++ exception handling.
4405         * frame.c: Use C++ exception handling.
4406         * frame-unwind.c: Use C++ exception handling.
4407         * fbsd-tdep.c: Use C++ exception handling.
4408         * f-valprint.c: Use C++ exception handling.
4409         * exec.c: Use C++ exception handling.
4410         * event-top.c: Use C++ exception handling.
4411         * event-loop.c: Use C++ exception handling.
4412         * eval.c: Use C++ exception handling.
4413         * dwarf2read.c: Use C++ exception handling.
4414         * dwarf2loc.c: Use C++ exception handling.
4415         * dwarf2-frame.c: Use C++ exception handling.
4416         * dwarf2-frame-tailcall.c: Use C++ exception handling.
4417         * dwarf-index-write.c: Use C++ exception handling.
4418         * dwarf-index-cache.c: Use C++ exception handling.
4419         * dtrace-probe.c: Use C++ exception handling.
4420         * disasm-selftests.c: Use C++ exception handling.
4421         * darwin-nat.c: Use C++ exception handling.
4422         * cp-valprint.c: Use C++ exception handling.
4423         * cp-support.c: Use C++ exception handling.
4424         * cp-abi.c: Use C++ exception handling.
4425         * corelow.c: Use C++ exception handling.
4426         * completer.c: Use C++ exception handling.
4427         * compile/compile-object-run.c: Use C++ exception handling.
4428         * compile/compile-object-load.c: Use C++ exception handling.
4429         * compile/compile-cplus-symbols.c: Use C++ exception handling.
4430         * compile/compile-c-symbols.c: Use C++ exception handling.
4431         * common/selftest.c: Use C++ exception handling.
4432         * common/new-op.c: Use C++ exception handling.
4433         * cli/cli-script.c: Use C++ exception handling.
4434         * cli/cli-interp.c: Use C++ exception handling.
4435         * cli/cli-cmds.c: Use C++ exception handling.
4436         * c-varobj.c: Use C++ exception handling.
4437         * btrace.c: Use C++ exception handling.
4438         * breakpoint.c: Use C++ exception handling.
4439         * break-catch-throw.c: Use C++ exception handling.
4440         * arch-utils.c: Use C++ exception handling.
4441         * amd64-tdep.c: Use C++ exception handling.
4442         * ada-valprint.c: Use C++ exception handling.
4443         * ada-typeprint.c: Use C++ exception handling.
4444         * ada-lang.c: Use C++ exception handling.
4445         * aarch64-tdep.c: Use C++ exception handling.
4446
4447 2019-04-08  Tom Tromey  <tom@tromey.com>
4448
4449         * xml-support.c (gdb_xml_parser::parse): Update.
4450         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4451         * value.c (show_convenience): Update.
4452         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4453         (test_parse_flags_qcs): Update.
4454         * thread.c (thr_try_catch_cmd): Update.
4455         * target.c (target_translate_tls_address): Update.
4456         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4457         (info_frame_command_core, frame_apply_command_count): Update.
4458         * rust-exp.y (rust_lex_exception_test): Update.
4459         * riscv-tdep.c (riscv_print_one_register_info): Update.
4460         * remote.c (remote_target::enable_btrace): Update.
4461         * record-btrace.c (record_btrace_enable_warn): Update.
4462         * python/py-utils.c (gdbpy_convert_exception): Update.
4463         * printcmd.c (do_one_display, print_variable_and_value): Update.
4464         * mi/mi-main.c (mi_print_exception): Update.
4465         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4466         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4467         * linux-nat.c (linux_nat_target::attach): Update.
4468         * linux-fork.c (class scoped_switch_fork_info): Update.
4469         * infrun.c (displaced_step_prepare): Update.
4470         * infcall.c (call_function_by_hand_dummy): Update.
4471         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4472         * gnu-v3-abi.c (print_one_vtable): Update.
4473         * frame.c (get_prev_frame_always): Update.
4474         * f-valprint.c (info_common_command_for_block): Update.
4475         * exec.c (try_open_exec_file): Update.
4476         * exceptions.c (print_exception, exception_print)
4477         (exception_fprintf, exception_print_same): Update.
4478         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4479         * dwarf-index-cache.c (index_cache::store)
4480         (index_cache::lookup_gdb_index): Update.
4481         * darwin-nat.c (maybe_cache_shell): Update.
4482         * cp-valprint.c (cp_print_value_fields): Update.
4483         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4484         (gcc_cplus_symbol_address): Update.
4485         * compile/compile-c-symbols.c (gcc_convert_symbol)
4486         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
4487         * common/selftest.c: Update.
4488         * common/common-exceptions.h (struct gdb_exception) <message>: Now
4489         a std::string.
4490         (exception_try_scope_entry, exception_try_scope_exit): Don't
4491         declare.
4492         (struct exception_try_scope): Remove.
4493         (TRY): Don't use exception_try_scope.
4494         (struct gdb_exception): Add constructor, operator=.
4495         <what>: New method.
4496         (struct gdb_exception_RETURN_MASK_ALL)
4497         (struct gdb_exception_RETURN_MASK_ERROR)
4498         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
4499         (struct gdb_quit_bad_alloc): Update.
4500         * common/common-exceptions.c (exception_none): Change
4501         initializer.
4502         (struct catcher) <state, exception>: Initialize inline.
4503         <prev>: Remove member.
4504         (current_catcher): Remove.
4505         (catchers): New global.
4506         (exceptions_state_mc_init): Simplify.
4507         (catcher_pop): Remove.
4508         (exceptions_state_mc, exceptions_state_mc_catch): Update.
4509         (try_scope_depth, exception_try_scope_entry)
4510         (exception_try_scope_exit): Remove.
4511         (throw_exception_sjlj): Update.
4512         (exception_messages, exception_messages_size): Remove.
4513         (throw_it): Simplify.
4514         (gdb_exception_sliced_copy): Remove.
4515         (throw_exception_cxx): Update.
4516         * cli/cli-script.c (script_from_file): Update.
4517         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
4518         Update.
4519         * ada-valprint.c (ada_val_print): Update.
4520         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
4521         (create_excep_cond_exprs): Update.
4522
4523 2019-04-08  Tom Tromey  <tom@tromey.com>
4524
4525         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
4526         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
4527         (TRY, CATCH, END_CATCH): Remove some definitions.
4528         * common/common-exceptions.c: Don't use GDB_XCPT.
4529         (catcher_list_size): Remove.
4530         (throw_exception, throw_it): Simplify.
4531
4532 2019-04-05  Tom Tromey  <tom@tromey.com>
4533
4534         Revert the header-sorting patch.
4535         * ft32-tdep.c: Revert.
4536         * frv-tdep.c: Revert.
4537         * frv-linux-tdep.c: Revert.
4538         * frame.c: Revert.
4539         * frame-unwind.c: Revert.
4540         * frame-base.c: Revert.
4541         * fork-child.c: Revert.
4542         * findvar.c: Revert.
4543         * findcmd.c: Revert.
4544         * filesystem.c: Revert.
4545         * filename-seen-cache.h: Revert.
4546         * filename-seen-cache.c: Revert.
4547         * fbsd-tdep.c: Revert.
4548         * fbsd-nat.h: Revert.
4549         * fbsd-nat.c: Revert.
4550         * f-valprint.c: Revert.
4551         * f-typeprint.c: Revert.
4552         * f-lang.c: Revert.
4553         * extension.h: Revert.
4554         * extension.c: Revert.
4555         * extension-priv.h: Revert.
4556         * expprint.c: Revert.
4557         * exec.h: Revert.
4558         * exec.c: Revert.
4559         * exceptions.c: Revert.
4560         * event-top.c: Revert.
4561         * event-loop.c: Revert.
4562         * eval.c: Revert.
4563         * elfread.c: Revert.
4564         * dwarf2read.h: Revert.
4565         * dwarf2read.c: Revert.
4566         * dwarf2loc.c: Revert.
4567         * dwarf2expr.h: Revert.
4568         * dwarf2expr.c: Revert.
4569         * dwarf2-frame.c: Revert.
4570         * dwarf2-frame-tailcall.c: Revert.
4571         * dwarf-index-write.h: Revert.
4572         * dwarf-index-write.c: Revert.
4573         * dwarf-index-common.c: Revert.
4574         * dwarf-index-cache.h: Revert.
4575         * dwarf-index-cache.c: Revert.
4576         * dummy-frame.c: Revert.
4577         * dtrace-probe.c: Revert.
4578         * disasm.h: Revert.
4579         * disasm.c: Revert.
4580         * disasm-selftests.c: Revert.
4581         * dictionary.c: Revert.
4582         * dicos-tdep.c: Revert.
4583         * demangle.c: Revert.
4584         * dcache.h: Revert.
4585         * dcache.c: Revert.
4586         * darwin-nat.h: Revert.
4587         * darwin-nat.c: Revert.
4588         * darwin-nat-info.c: Revert.
4589         * d-valprint.c: Revert.
4590         * d-namespace.c: Revert.
4591         * d-lang.c: Revert.
4592         * ctf.c: Revert.
4593         * csky-tdep.c: Revert.
4594         * csky-linux-tdep.c: Revert.
4595         * cris-tdep.c: Revert.
4596         * cris-linux-tdep.c: Revert.
4597         * cp-valprint.c: Revert.
4598         * cp-support.c: Revert.
4599         * cp-namespace.c: Revert.
4600         * cp-abi.c: Revert.
4601         * corelow.c: Revert.
4602         * corefile.c: Revert.
4603         * continuations.c: Revert.
4604         * completer.h: Revert.
4605         * completer.c: Revert.
4606         * complaints.c: Revert.
4607         * coffread.c: Revert.
4608         * coff-pe-read.c: Revert.
4609         * cli-out.h: Revert.
4610         * cli-out.c: Revert.
4611         * charset.c: Revert.
4612         * c-varobj.c: Revert.
4613         * c-valprint.c: Revert.
4614         * c-typeprint.c: Revert.
4615         * c-lang.c: Revert.
4616         * buildsym.c: Revert.
4617         * buildsym-legacy.c: Revert.
4618         * build-id.h: Revert.
4619         * build-id.c: Revert.
4620         * btrace.c: Revert.
4621         * bsd-uthread.c: Revert.
4622         * breakpoint.h: Revert.
4623         * breakpoint.c: Revert.
4624         * break-catch-throw.c: Revert.
4625         * break-catch-syscall.c: Revert.
4626         * break-catch-sig.c: Revert.
4627         * blockframe.c: Revert.
4628         * block.c: Revert.
4629         * bfin-tdep.c: Revert.
4630         * bfin-linux-tdep.c: Revert.
4631         * bfd-target.c: Revert.
4632         * bcache.c: Revert.
4633         * ax-general.c: Revert.
4634         * ax-gdb.h: Revert.
4635         * ax-gdb.c: Revert.
4636         * avr-tdep.c: Revert.
4637         * auxv.c: Revert.
4638         * auto-load.c: Revert.
4639         * arm-wince-tdep.c: Revert.
4640         * arm-tdep.c: Revert.
4641         * arm-symbian-tdep.c: Revert.
4642         * arm-pikeos-tdep.c: Revert.
4643         * arm-obsd-tdep.c: Revert.
4644         * arm-nbsd-tdep.c: Revert.
4645         * arm-nbsd-nat.c: Revert.
4646         * arm-linux-tdep.c: Revert.
4647         * arm-linux-nat.c: Revert.
4648         * arm-fbsd-tdep.c: Revert.
4649         * arm-fbsd-nat.c: Revert.
4650         * arm-bsd-tdep.c: Revert.
4651         * arch-utils.c: Revert.
4652         * arc-tdep.c: Revert.
4653         * arc-newlib-tdep.c: Revert.
4654         * annotate.h: Revert.
4655         * annotate.c: Revert.
4656         * amd64-windows-tdep.c: Revert.
4657         * amd64-windows-nat.c: Revert.
4658         * amd64-tdep.c: Revert.
4659         * amd64-sol2-tdep.c: Revert.
4660         * amd64-obsd-tdep.c: Revert.
4661         * amd64-obsd-nat.c: Revert.
4662         * amd64-nbsd-tdep.c: Revert.
4663         * amd64-nbsd-nat.c: Revert.
4664         * amd64-nat.c: Revert.
4665         * amd64-linux-tdep.c: Revert.
4666         * amd64-linux-nat.c: Revert.
4667         * amd64-fbsd-tdep.c: Revert.
4668         * amd64-fbsd-nat.c: Revert.
4669         * amd64-dicos-tdep.c: Revert.
4670         * amd64-darwin-tdep.c: Revert.
4671         * amd64-bsd-nat.c: Revert.
4672         * alpha-tdep.c: Revert.
4673         * alpha-obsd-tdep.c: Revert.
4674         * alpha-nbsd-tdep.c: Revert.
4675         * alpha-mdebug-tdep.c: Revert.
4676         * alpha-linux-tdep.c: Revert.
4677         * alpha-linux-nat.c: Revert.
4678         * alpha-bsd-tdep.c: Revert.
4679         * alpha-bsd-nat.c: Revert.
4680         * aix-thread.c: Revert.
4681         * agent.c: Revert.
4682         * addrmap.c: Revert.
4683         * ada-varobj.c: Revert.
4684         * ada-valprint.c: Revert.
4685         * ada-typeprint.c: Revert.
4686         * ada-tasks.c: Revert.
4687         * ada-lang.c: Revert.
4688         * aarch64-tdep.c: Revert.
4689         * aarch64-ravenscar-thread.c: Revert.
4690         * aarch64-newlib-tdep.c: Revert.
4691         * aarch64-linux-tdep.c: Revert.
4692         * aarch64-linux-nat.c: Revert.
4693         * aarch64-fbsd-tdep.c: Revert.
4694         * aarch64-fbsd-nat.c: Revert.
4695         * aarch32-linux-nat.c: Revert.
4696
4697 2019-04-05  Tom Tromey  <tom@tromey.com>
4698
4699         * ft32-tdep.c: Sort headers.
4700         * frv-tdep.c: Sort headers.
4701         * frv-linux-tdep.c: Sort headers.
4702         * frame.c: Sort headers.
4703         * frame-unwind.c: Sort headers.
4704         * frame-base.c: Sort headers.
4705         * fork-child.c: Sort headers.
4706         * findvar.c: Sort headers.
4707         * findcmd.c: Sort headers.
4708         * filesystem.c: Sort headers.
4709         * filename-seen-cache.h: Sort headers.
4710         * filename-seen-cache.c: Sort headers.
4711         * fbsd-tdep.c: Sort headers.
4712         * fbsd-nat.h: Sort headers.
4713         * fbsd-nat.c: Sort headers.
4714         * f-valprint.c: Sort headers.
4715         * f-typeprint.c: Sort headers.
4716         * f-lang.c: Sort headers.
4717         * extension.h: Sort headers.
4718         * extension.c: Sort headers.
4719         * extension-priv.h: Sort headers.
4720         * expprint.c: Sort headers.
4721         * exec.h: Sort headers.
4722         * exec.c: Sort headers.
4723         * exceptions.c: Sort headers.
4724         * event-top.c: Sort headers.
4725         * event-loop.c: Sort headers.
4726         * eval.c: Sort headers.
4727         * elfread.c: Sort headers.
4728         * dwarf2read.h: Sort headers.
4729         * dwarf2read.c: Sort headers.
4730         * dwarf2loc.c: Sort headers.
4731         * dwarf2expr.h: Sort headers.
4732         * dwarf2expr.c: Sort headers.
4733         * dwarf2-frame.c: Sort headers.
4734         * dwarf2-frame-tailcall.c: Sort headers.
4735         * dwarf-index-write.h: Sort headers.
4736         * dwarf-index-write.c: Sort headers.
4737         * dwarf-index-common.c: Sort headers.
4738         * dwarf-index-cache.h: Sort headers.
4739         * dwarf-index-cache.c: Sort headers.
4740         * dummy-frame.c: Sort headers.
4741         * dtrace-probe.c: Sort headers.
4742         * disasm.h: Sort headers.
4743         * disasm.c: Sort headers.
4744         * disasm-selftests.c: Sort headers.
4745         * dictionary.c: Sort headers.
4746         * dicos-tdep.c: Sort headers.
4747         * demangle.c: Sort headers.
4748         * dcache.h: Sort headers.
4749         * dcache.c: Sort headers.
4750         * darwin-nat.h: Sort headers.
4751         * darwin-nat.c: Sort headers.
4752         * darwin-nat-info.c: Sort headers.
4753         * d-valprint.c: Sort headers.
4754         * d-namespace.c: Sort headers.
4755         * d-lang.c: Sort headers.
4756         * ctf.c: Sort headers.
4757         * csky-tdep.c: Sort headers.
4758         * csky-linux-tdep.c: Sort headers.
4759         * cris-tdep.c: Sort headers.
4760         * cris-linux-tdep.c: Sort headers.
4761         * cp-valprint.c: Sort headers.
4762         * cp-support.c: Sort headers.
4763         * cp-namespace.c: Sort headers.
4764         * cp-abi.c: Sort headers.
4765         * corelow.c: Sort headers.
4766         * corefile.c: Sort headers.
4767         * continuations.c: Sort headers.
4768         * completer.h: Sort headers.
4769         * completer.c: Sort headers.
4770         * complaints.c: Sort headers.
4771         * coffread.c: Sort headers.
4772         * coff-pe-read.c: Sort headers.
4773         * cli-out.h: Sort headers.
4774         * cli-out.c: Sort headers.
4775         * charset.c: Sort headers.
4776         * c-varobj.c: Sort headers.
4777         * c-valprint.c: Sort headers.
4778         * c-typeprint.c: Sort headers.
4779         * c-lang.c: Sort headers.
4780         * buildsym.c: Sort headers.
4781         * buildsym-legacy.c: Sort headers.
4782         * build-id.h: Sort headers.
4783         * build-id.c: Sort headers.
4784         * btrace.c: Sort headers.
4785         * bsd-uthread.c: Sort headers.
4786         * breakpoint.h: Sort headers.
4787         * breakpoint.c: Sort headers.
4788         * break-catch-throw.c: Sort headers.
4789         * break-catch-syscall.c: Sort headers.
4790         * break-catch-sig.c: Sort headers.
4791         * blockframe.c: Sort headers.
4792         * block.c: Sort headers.
4793         * bfin-tdep.c: Sort headers.
4794         * bfin-linux-tdep.c: Sort headers.
4795         * bfd-target.c: Sort headers.
4796         * bcache.c: Sort headers.
4797         * ax-general.c: Sort headers.
4798         * ax-gdb.h: Sort headers.
4799         * ax-gdb.c: Sort headers.
4800         * avr-tdep.c: Sort headers.
4801         * auxv.c: Sort headers.
4802         * auto-load.c: Sort headers.
4803         * arm-wince-tdep.c: Sort headers.
4804         * arm-tdep.c: Sort headers.
4805         * arm-symbian-tdep.c: Sort headers.
4806         * arm-pikeos-tdep.c: Sort headers.
4807         * arm-obsd-tdep.c: Sort headers.
4808         * arm-nbsd-tdep.c: Sort headers.
4809         * arm-nbsd-nat.c: Sort headers.
4810         * arm-linux-tdep.c: Sort headers.
4811         * arm-linux-nat.c: Sort headers.
4812         * arm-fbsd-tdep.c: Sort headers.
4813         * arm-fbsd-nat.c: Sort headers.
4814         * arm-bsd-tdep.c: Sort headers.
4815         * arch-utils.c: Sort headers.
4816         * arc-tdep.c: Sort headers.
4817         * arc-newlib-tdep.c: Sort headers.
4818         * annotate.h: Sort headers.
4819         * annotate.c: Sort headers.
4820         * amd64-windows-tdep.c: Sort headers.
4821         * amd64-windows-nat.c: Sort headers.
4822         * amd64-tdep.c: Sort headers.
4823         * amd64-sol2-tdep.c: Sort headers.
4824         * amd64-obsd-tdep.c: Sort headers.
4825         * amd64-obsd-nat.c: Sort headers.
4826         * amd64-nbsd-tdep.c: Sort headers.
4827         * amd64-nbsd-nat.c: Sort headers.
4828         * amd64-nat.c: Sort headers.
4829         * amd64-linux-tdep.c: Sort headers.
4830         * amd64-linux-nat.c: Sort headers.
4831         * amd64-fbsd-tdep.c: Sort headers.
4832         * amd64-fbsd-nat.c: Sort headers.
4833         * amd64-dicos-tdep.c: Sort headers.
4834         * amd64-darwin-tdep.c: Sort headers.
4835         * amd64-bsd-nat.c: Sort headers.
4836         * alpha-tdep.c: Sort headers.
4837         * alpha-obsd-tdep.c: Sort headers.
4838         * alpha-nbsd-tdep.c: Sort headers.
4839         * alpha-mdebug-tdep.c: Sort headers.
4840         * alpha-linux-tdep.c: Sort headers.
4841         * alpha-linux-nat.c: Sort headers.
4842         * alpha-bsd-tdep.c: Sort headers.
4843         * alpha-bsd-nat.c: Sort headers.
4844         * aix-thread.c: Sort headers.
4845         * agent.c: Sort headers.
4846         * addrmap.c: Sort headers.
4847         * ada-varobj.c: Sort headers.
4848         * ada-valprint.c: Sort headers.
4849         * ada-typeprint.c: Sort headers.
4850         * ada-tasks.c: Sort headers.
4851         * ada-lang.c: Sort headers.
4852         * aarch64-tdep.c: Sort headers.
4853         * aarch64-ravenscar-thread.c: Sort headers.
4854         * aarch64-newlib-tdep.c: Sort headers.
4855         * aarch64-linux-tdep.c: Sort headers.
4856         * aarch64-linux-nat.c: Sort headers.
4857         * aarch64-fbsd-tdep.c: Sort headers.
4858         * aarch64-fbsd-nat.c: Sort headers.
4859         * aarch32-linux-nat.c: Sort headers.
4860
4861 2019-04-04  Tom Tromey  <tom@tromey.com>
4862
4863         * varobj.c (varobj_create): Update.
4864         * rust-exp.y (struct rust_parser) <update_innermost_block,
4865         lookup_symbol>: New methods.
4866         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
4867         Rename.
4868         (rust_parser::rust_lookup_type)
4869         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4870         * printcmd.c (display_command, do_one_display): Update.
4871         * parser-defs.h (struct parser_state) <parser_state>: Add
4872         "tracker" parameter.
4873         (block_tracker): New member.
4874         (class innermost_block_tracker) <innermost_block_tracker>: Add
4875         "types" parameter.
4876         <reset>: Remove method.
4877         (innermost_block): Don't declare.
4878         (null_post_parser): Update.
4879         * parse.c (innermost_block): Remove global.
4880         (write_dollar_variable): Update.
4881         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
4882         Remove "tracker_types" parameter.
4883         (parse_expression): Add "tracker" parameter.
4884         (parse_expression_for_completion): Update.
4885         (null_post_parser): Add "tracker" parameter.
4886         * p-exp.y: Update rules.
4887         * m2-exp.y: Update rules.
4888         * language.h (struct language_defn) <la_post_parser>: Add
4889         "tracker" parameter.
4890         * go-exp.y: Update rules.
4891         * f-exp.y: Update rules.
4892         * expression.h (parse_expression, parse_exp_1): Add "tracker"
4893         parameter.
4894         * d-exp.y: Update rules.
4895         * c-exp.y: Update rules.
4896         * breakpoint.c (set_breakpoint_condition): Create an
4897         innermost_block_tracker.
4898         (watch_command_1): Likewise.
4899         * ada-lang.c (resolve): Add "tracker" parameter.
4900         (resolve_subexp): Likewise.
4901         * ada-exp.y (write_var_from_sym): Update.
4902
4903 2019-04-04  Tom Tromey  <tom@tromey.com>
4904
4905         * type-stack.h: New file.
4906         * type-stack.c: New file.
4907         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
4908         type-stack.h.
4909         (insert_into_type_stack, insert_type, push_type, push_type_int)
4910         (insert_type_address_space, pop_type, pop_type_int)
4911         (pop_typelist, pop_type_stack, append_type_stack)
4912         (push_type_stack, get_type_stack, push_typelist)
4913         (follow_type_instance_flags, follow_types): Don't declare.
4914         * parse.c (type_stack): Remove global.
4915         (parse_exp_in_context): Update.
4916         (insert_into_type_stack, insert_type, push_type, push_type_int)
4917         (insert_type_address_space, pop_type, pop_type_int)
4918         (pop_typelist, pop_type_stack, append_type_stack)
4919         (push_type_stack, get_type_stack, push_typelist)
4920         (follow_type_instance_flags, follow_types): Remove (moved to
4921         type-stack.c).
4922         * f-exp.y (type_stack): New global.
4923         Update rules.
4924         (push_kind_type, f_parse): Update.
4925         * d-exp.y (type_stack): New global.
4926         Update rules.
4927         (d_parse): Update.
4928         * c-exp.y (struct c_parse_state) <type_stack>: New member.
4929         Update rules.
4930         * Makefile.in (COMMON_SFILES): Add type-stack.c.
4931         (HFILES_NO_SRCDIR): Add type-stack.h.
4932
4933 2019-04-04  Tom Tromey  <tom@tromey.com>
4934
4935         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
4936         (rust_parser::convert_ast_to_expression, rust_parse)
4937         (rust_lex_test_completion, rust_lex_tests): Update.
4938         * parser-defs.h (struct expr_completion_state): New.
4939         (struct parser_state) <parser_state>: Add completion parameter.
4940         <mark_struct_expression, mark_completion_tag>: New methods.
4941         <parse_completion, m_completion_state>: New members.
4942         (prefixify_expression, null_post_parser): Update.
4943         (mark_struct_expression, mark_completion_tag): Don't declare.
4944         * parse.c (parse_completion, expout_last_struct)
4945         (expout_tag_completion_type, expout_completion_name): Remove
4946         globals.
4947         (parser_state::mark_struct_expression)
4948         (parser_state::mark_completion_tag): Now methods.
4949         (prefixify_expression): Add last_struct parameter.
4950         (prefixify_subexp): Likewise.
4951         (parse_exp_1): Update.
4952         (parse_exp_in_context): Add cstate parameter.  Update.
4953         (parse_expression_for_completion): Create an
4954         expr_completion_state.
4955         (null_post_parser): Add "completion" parameter.
4956         * p-exp.y: Update rules.
4957         (yylex): Update.
4958         * language.h (struct language_defn) <la_post_parser>: Add
4959         "completing" parameter.
4960         * go-exp.y: Update rules.
4961         (lex_one_token): Update.
4962         * expression.h (parse_completion): Don't declare.
4963         * d-exp.y: Update rules.
4964         (lex_one_token): Update rules.
4965         * c-exp.y: Update rules.
4966         (lex_one_token): Update.
4967         * ada-lang.c (resolve): Add "parse_completion" parameter.
4968         (resolve_subexp): Likewise.
4969         (ada_resolve_function): Likewise.
4970
4971 2019-04-04  Tom Tromey  <tom@tromey.com>
4972
4973         * parser-defs.h (struct parser_state) <start_arglist,
4974         end_arglist>: New methods.
4975         <arglist_len, m_funcall_chain>: New members.
4976         (arglist_len, start_arglist, end_arglist): Don't declare.
4977         * parse.c (arglist_len, funcall_chain): Remove global.
4978         (start_arglist, end_arglist): Remove functions.
4979         (parse_exp_in_context): Update.
4980         * p-exp.y: Update rules.
4981         * m2-exp.y: Update rules.
4982         * go-exp.y: Update rules.
4983         * f-exp.y: Update rules.
4984         * d-exp.y: Update rules.
4985         * c-exp.y: Update rules.
4986
4987 2019-04-04  Tom Tromey  <tom@tromey.com>
4988
4989         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
4990         lex_operator, push_back>: New methods.
4991         Update all rules.
4992         (rust_parser::lex_hex, lex_escape): Rename and update.
4993         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
4994         (rust_parser::lex_operator): Rename and update.
4995         (rust_parser::lex_number, rustyylex, rustyyerror)
4996         (rust_lex_test_init, rust_lex_test_sequence)
4997         (rust_lex_test_push_back, rust_lex_tests): Update.
4998         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
4999         parameter.
5000         <lexptr, prev_lexptr>: New members.
5001         (lexptr, prev_lexptr): Don't declare.
5002         * parse.c (lexptr, prev_lexptr): Remove globals.
5003         (parse_exp_in_context): Update.
5004         * p-exp.y (yylex, yyerror): Update.
5005         * m2-exp.y (parse_number, yylex, yyerror): Update.
5006         * go-exp.y (lex_one_token, yyerror): Update.
5007         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5008         * d-exp.y (lex_one_token, yyerror): Update.
5009         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5010         (lex_one_token, yyerror): Update.
5011         * ada-lex.l (YY_INPUT): Update.
5012         (rewind_to_char): Update.
5013         * ada-exp.y (yyerror): Update.
5014
5015 2019-04-04  Tom Tromey  <tom@tromey.com>
5016
5017         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5018         * parser-defs.h (struct parser_state) <parser_state>: Add new
5019         parameter.
5020         <comma_terminates>: New member.
5021         (comma_terminates): Don't declare global.
5022         * parse.c (comma_terminates): Remove global.
5023         (parse_exp_in_context): Update.
5024         * p-exp.y (yylex): Update.
5025         * m2-exp.y (yylex): Update.
5026         * go-exp.y (lex_one_token): Update.
5027         * f-exp.y (yylex): Update.
5028         * d-exp.y (lex_one_token): Update.
5029         * c-exp.y (lex_one_token): Update.
5030         * ada-lex.l: Update.
5031
5032 2019-04-04  Tom Tromey  <tom@tromey.com>
5033
5034         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5035         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5036         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5037         * parser-defs.h (paren_depth): Don't declare.
5038         * parse.c (paren_depth): Remove global.
5039         (parse_exp_in_context): Update.
5040         * p-exp.y (paren_depth): New global.
5041         (pascal_parse): Initialize it.
5042         * m2-exp.y (paren_depth): New global.
5043         (m2_parse): Initialize it.
5044         * go-exp.y (paren_depth): New global.
5045         (go_parse): Initialize it.
5046         * f-exp.y (paren_depth): New global.
5047         (f_parse): Initialize it.
5048         * d-exp.y (paren_depth): New global.
5049         (d_parse): Initialize it.
5050         * c-exp.y (paren_depth): New global.
5051         (c_parse): Initialize it.
5052         * ada-lex.l (paren_depth): New global.
5053         (lexer_init): Initialize it.
5054
5055 2019-04-04  Tom Tromey  <tom@tromey.com>
5056
5057         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5058         (rust_parser::convert_ast_to_type)
5059         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5060         * parser-defs.h (struct parser_state) <parser_state>: Add
5061         parameters.  Initialize new members.
5062         <expression_context_block, expression_context_pc>: New members.
5063         * parse.c (expression_context_block, expression_context_pc):
5064         Remove globals.
5065         (parse_exp_in_context): Update.
5066         * p-exp.y: Update all rules.
5067         (yylex): Update.
5068         * m2-exp.y: Update all rules.
5069         (yylex): Update.
5070         * go-exp.y (yylex): Update.
5071         * f-exp.y (yylex): Update.
5072         * d-exp.y: Update all rules.
5073         (yylex): Update.
5074         * c-exp.y: Update all rules.
5075         (lex_one_token, classify_name, yylex, c_parse): Update.
5076         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5077
5078 2019-04-04  Tom Tromey  <tom@tromey.com>
5079
5080         * gdbarch.h, gdbarch.c: Rebuild.
5081         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5082         * stap-probe.h: 
5083         (struct stap_parse_info): Replace "parser_state" with
5084         "expr_builder".
5085         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5086         (parser_state): New class.
5087         * parse.c (expr_builder): Rename.
5088         (expr_builder::release): Rename.
5089         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5090         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5091         (write_exp_elt_longcst, write_exp_elt_floatcst)
5092         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5093         (write_exp_string_vector, write_exp_bitstring)
5094         (write_exp_msymbol, mark_struct_expression)
5095         (write_dollar_variable)
5096         (insert_type_address_space, increase_expout_size): Replace
5097         "parser_state" with "expr_builder".
5098         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5099         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5100         "parser_state" with "expr_builder".
5101
5102 2019-04-04  Tom Tromey  <tom@tromey.com>
5103
5104         * rust-exp.y: Replace "parse_language" with method call.
5105         * p-exp.y: 
5106         (yylex): Replace "parse_language" with method call.
5107         * m2-exp.y: 
5108         (yylex): Replace "parse_language" with method call.
5109         * go-exp.y (classify_name): Replace "parse_language" with method
5110         call.
5111         * f-exp.y (yylex): Replace "parse_language" with method call.
5112         * d-exp.y (lex_one_token): Replace "parse_language" with method
5113         call.
5114         * c-exp.y: 
5115         (lex_one_token, classify_name, yylex): Replace "parse_language"
5116         with method call.
5117         * ada-exp.y (find_primitive_type, type_char)
5118         (type_system_address): Replace "parse_language" with method call.
5119
5120 2019-04-04  Tom Tromey  <tom@tromey.com>
5121
5122         * rust-exp.y: Replace "parse_gdbarch" with method call.
5123         * parse.c (write_dollar_variable, insert_type_address_space):
5124         Replace "parse_gdbarch" with method call.
5125         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5126         call.
5127         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5128         call.
5129         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5130         "parse_gdbarch" with method call.
5131         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5132         with method call.
5133         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5134         "parse_gdbarch" with method call.
5135         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5136         "parse_gdbarch" with method call.
5137         * c-exp.y (parse_type, parse_number, classify_name): Replace
5138         "parse_gdbarch" with method call.
5139         * ada-lex.l: Replace "parse_gdbarch" with method call.
5140         * ada-exp.y (parse_type, find_primitive_type, type_char)
5141         (type_system_address): Replace "parse_gdbarch" with method call.
5142
5143 2019-04-04  Tom Tromey  <tom@tromey.com>
5144
5145         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5146         * stap-probe.c (stap_parse_argument): Update.
5147         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5148         initial_size parameter.
5149         * rust-exp.y (rust_lex_tests): Update.
5150         * parse.c (parser_state): Update.
5151         (parse_exp_in_context): Update.
5152         * parser-defs.h (struct parser_state) <parser_state>: Remove
5153         "initial_size" parameter.
5154
5155 2019-04-04  Tom Tromey  <tom@tromey.com>
5156
5157         * parser-defs.h (increase_expout_size): Don't declare.
5158         * parse.c (increase_expout_size): Now static.
5159
5160 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
5161
5162         * gnu-nat.c (gnu_nat_target::wait): Fix
5163         target_waitstatus_to_string call.
5164
5165 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5166
5167         * eval.c (evaluate_subexp_standard): Handle internal functions
5168         during Fortran function call handling.
5169
5170 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5171
5172         * NEWS: Mention new internal functions.
5173         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5174         (read_base_type): Use dwarf2_init_complex_target_type.
5175         * value.c (creal_internal_fn): New function.
5176         (cimag_internal_fn): New function.
5177         (_initialize_values): Register new internal functions.
5178
5179 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5180
5181         * infrun.c (stop_all_threads): If debug_infrun, always
5182         trace the wait status after wait_one, using
5183         target_waitstatus_to_string and target_pid_to_str.
5184         (handle_inferior_event): Replace various trace of
5185         wait status kind by a single trace.
5186         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5187         wait status kind image by target_waitstatus_to_string.
5188         * target/waitstatus.c (target_waitstatus_to_string): Fix
5189         obsolete comment.
5190
5191 2019-04-01  Tom Tromey  <tromey@adacore.com>
5192
5193         PR symtab/23331:
5194         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
5195
5196 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5197             Pedro Alves  <palves@redhat.com>
5198
5199         * top.c (quit_force): Call 'finalize_values'.
5200         * value.c (finalize_values): New function.
5201         * value.h (finalize_values): Declare.
5202
5203 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
5204
5205         * NEWS: Announce $_gdb_major and $_gdb_minor.
5206
5207         * top.c (init_gdb_version_vars): New function.
5208         (gdb_init): Call init_gdb_version_vars.
5209
5210 2019-03-29  Tom Tromey  <tromey@adacore.com>
5211
5212         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
5213         help text.  Remove dead code.
5214
5215 2019-03-29  Keith Seitz  <keiths@redhat.com>
5216
5217         From Siddhesh Poyarekar:
5218         * f-lang.h (f77_get_upperbound): Return LONGEST.
5219         (f77_get_lowerbound): Likewise.
5220         * f-typeprint.c (f_type_print_varspec_suffix): Expand
5221         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
5222         print them.
5223         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
5224         plongest to format print it.
5225         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
5226         (f77_get_upperbound): Likewise.
5227         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
5228         LOWER_BOUND to LONGEST.
5229         (f77_create_arrayprint_offset_tbl): Likewise.
5230
5231 2019-03-29  Keith Seitz  <keiths@redhat.com>
5232
5233         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
5234         %s/pulongest for TYPE_LENGTH instead of %d in format
5235         strings.
5236         * ada-typerint.c (ada_print_type): Likewise.
5237         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
5238         * compile/compile-c-support.c (generate_register_struct): Likewise.
5239         * gdbtypes.c (recursive_dump_type): Likewise.
5240         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
5241         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
5242         instead of %d in format strings.
5243         * riscv-tdep.c (riscv_type_alignment): Cast second argument
5244         to std::min to ULONGEST.
5245         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
5246         instead of %d in format strings.
5247         * tracepoint.c (info_scope_command): Likewise.
5248         * typeprint.c (print_offset_data::update)
5249         (print_offset_data::finish): Likewise.
5250         * xtensa-tdep.c (xtensa_store_return_value)
5251         (xtensa_push_dummy_call): Likewise.
5252
5253 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
5254
5255         * windows-nat.c (display_selector): Fixed format specifications
5256         for 64-bit Cygwin.
5257
5258 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5259
5260         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
5261
5262 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
5263
5264         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
5265         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
5266         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
5267         (nios2_linux_init_abi): Install it.
5268
5269 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5270
5271         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
5272
5273 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5274
5275         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
5276
5277 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5278             Tom Tromey  <tromey@adacore.com>
5279
5280         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
5281
5282 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
5283
5284         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
5285         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
5286         method to compute the bounds of range types. Also print "[evaluated]"
5287         if the bounds' values come from a dynamic evaluation.
5288
5289 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5290
5291         * cp-valprint.c (cp_print_value_fields): Don't print trailing
5292         whitespace when pretty printing is on.
5293
5294 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5295
5296         * ppc-linux-nat.c: Add include.
5297
5298 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5299
5300         * NEWS: Mention AArch64 Pointer Authentication.
5301
5302 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5303
5304         * arm-linux-nat.c: Add include.
5305
5306 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
5307
5308         * source-cache.c (source_cache::get_source_lines): Re-read
5309         fullname after calling open_source_file.
5310
5311 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
5312
5313         * NEWS: Mention TLS support for FreeBSD.
5314
5315 2019-03-25  Tom Tromey  <tromey@adacore.com>
5316
5317         * minsyms.c (BUNCH_SIZE): Update comment.
5318         (~minimal_symbol_reader): Remove old comment.
5319         (compact_minimal_symbols): Update comment.
5320         (minimal_symbol_reader::install): Remove old comment.  Update
5321         other comments.
5322
5323 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5324
5325         * s390-linux-nat.c: Add include.
5326
5327 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5328
5329         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5330         Call linux_get_hwcap.
5331         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
5332         Likewise.
5333         (aarch64_linux_get_hwcap): Remove function.
5334         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
5335         declaration.
5336         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
5337         linux_get_hwcap.
5338         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5339         * linux-tdep.c (linux_get_hwcap): Add function.
5340         (linux_get_hwcap2): Likewise.
5341         * linux-tdep.h (linux_get_hwcap): Add declaration.
5342         (linux_get_hwcap2): Likewise.
5343         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
5344         (ppc_linux_get_hwcap2): Likewise.
5345         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
5346         linux_get_hwcap.
5347         (ppc_linux_nat_target::insert_watchpoint): Likewise.
5348         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
5349         (ppc_linux_nat_target::read_description): Likewise.
5350         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
5351         * s390-linux-nat.c: Likewise.
5352         * s390-linux-tdep.c (s390_core_read_description): Likewise.
5353
5354 2019-03-24  Tom Tromey  <tom@tromey.com>
5355
5356         * ada-lang.c (standard_lookup): Simplify initialization.
5357         (ada_lookup_symbol_nonlocal): Simplify return.
5358         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
5359         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
5360         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
5361         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
5362         initialization.
5363         * solib.c (solib_global_lookup): Simplify.
5364         * symtab.c (null_block_symbol): Remove.
5365         (symbol_cache_lookup): Simplify returns.
5366         (lookup_language_this): Simplify returns.
5367         (lookup_symbol_aux): Simplify return.
5368         (lookup_local_symbol): Simplify returns.
5369         (lookup_global_symbol_from_objfile): Simplify return.
5370         (lookup_symbol_in_objfile_symtabs)
5371         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
5372         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
5373         (lookup_static_symbol, lookup_global_symbol): Simplify return.
5374         * cp-namespace.c (cp_lookup_bare_symbol)
5375         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
5376         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
5377         (cp_lookup_nested_symbol): Don't use null_block_symbol.
5378         (cp_lookup_symbol_via_imports): Simplify initialization.
5379         (find_symbol_in_baseclass): Likewise.
5380         * symtab.h (null_block_symbol): Remove.
5381         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
5382         (d_lookup_nested_symbol, d_lookup_symbol_imports)
5383         (d_lookup_symbol_module): Likewise.
5384         (find_symbol_in_baseclass): Simplify initialization.
5385
5386 2019-03-24  Tom Tromey  <tom@tromey.com>
5387
5388         * expression.h: Don't include symtab.h.
5389         (struct block): Forward declare.
5390
5391 2019-03-24  Tom Tromey  <tom@tromey.com>
5392
5393         * c-exp.y (typebase): Remove casts.
5394         * gdbtypes.c (lookup_unsigned_typename, )
5395         (lookup_signed_typename): Remove cast.
5396         * eval.c (parse_to_comma_and_eval): Remove cast.
5397         * parse.c (write_dollar_variable): Remove cast.
5398         * block.h (struct block) <superblock>: Now const.
5399         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
5400         * psymtab.c (psym_map_matching_symbols): Make "block" const.
5401         (map_block): Make "block" const.
5402         * symfile.h (struct quick_symbol_functions)
5403         <map_matching_symbols>: Constify block argument to "callback".
5404         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
5405         const.
5406         (find_pc_sect_compunit_symtab): Make "b" const.
5407         (find_symbol_at_address): Likewise.
5408         (search_symbols): Likewise.
5409         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
5410         (dw2_debug_names_lookup_symbol): Likewise.
5411         (dw2_map_matching_symbols): Update.
5412         * p-valprint.c (pascal_val_print): Remove "block".
5413         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
5414         (aux_add_nonlocal_symbols): Make "block" const.
5415         (resolve_subexp): Remove cast.
5416         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5417         const.
5418         (iterate_over_file_blocks): Likewise.
5419         * f-exp.y (%union) <bval>: Remove.
5420         * coffread.c (patch_opaque_types): Make "b" const.
5421         * spu-tdep.c (spu_catch_start): Make "block" const.
5422         * c-valprint.c (print_unpacked_pointer): Remove "block".
5423         * symmisc.c (dump_symtab_1): Make "b" const.
5424         (block_depth): Make "block" const.
5425         * d-exp.y (%union) <bval>: Remove.
5426         * cp-support.h (cp_lookup_rtti_type): Update.
5427         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5428         * psymtab.c (psym_lookup_symbol): Make "block" const.
5429         (maintenance_check_psymtabs): Make "b" const.
5430         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5431         (enumerate_locals, enumerate_args): Update.
5432         * python/py-symtab.c (stpy_global_block): Make "block" const.
5433         (stpy_static_block): Likewise.
5434         * inline-frame.c (block_starting_point_at): Make "new_block"
5435         const.
5436         * block.c (find_block_in_blockvector): Make return type const.
5437         (blockvector_for_pc_sect): Make "b" const.
5438         (find_block_in_blockvector): Make "b" const.
5439
5440 2019-03-23  Tom Tromey  <tom@tromey.com>
5441
5442         * varobj.c (varobj_create): Update.
5443         * symfile.c (clear_symtab_users): Don't reset innermost_block.
5444         * printcmd.c (display_command, do_one_display): Don't reset
5445         innermost_block.
5446         * parser-defs.h (enum innermost_block_tracker_type): Move to
5447         expression.h.
5448         (innermost_block): Update comment.
5449         * parse.c (parse_exp_1): Add tracker_types parameter.
5450         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
5451         tracker_types parameter.  Reset innermost_block.
5452         (parse_exp_in_context): Remove.
5453         (parse_expression_for_completion): Update.
5454         * objfiles.c (~objfile): Don't reset expression_context_block or
5455         innermost_block.
5456         * expression.h (enum innermost_block_tracker_type): Move from
5457         parser-defs.h.
5458         (parse_exp_1): Add tracker_types parameter.
5459         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5460         reset innermost_block.
5461
5462 2019-03-23  Tom Tromey  <tom@tromey.com>
5463
5464         * objfiles.h: Include bcache.h.
5465
5466 2019-03-23  Tom Tromey  <tom@tromey.com>
5467
5468         * linespec.c (get_current_search_block): Use
5469         scoped_restore_current_language.
5470         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5471
5472 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5473             Jiong Wang  <jiong.wang@arm.com>
5474
5475         * aarch64-linux-tdep.c
5476         (aarch64_linux_iterate_over_regset_sections): Check for pauth
5477         section.
5478         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5479
5480 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5481             Jiong Wang  <jiong.wang@arm.com>
5482
5483         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5484         instructions.
5485         (aarch64_analyze_prologue_test): Add PACIASP test.
5486         (aarch64_prologue_prev_register): Unmask PC value.
5487
5488 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5489             Jiong Wang  <jiong.wang@arm.com>
5490
5491         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
5492         (aarch64_dwarf2_prev_register): Unmask PC value.
5493         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
5494         (aarch64_execute_dwarf_cfa_vendor_op): Check for
5495         DW_CFA_AARCH64_negate_ra_state.
5496         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
5497
5498 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5499             Jiong Wang  <jiong.wang@arm.com>
5500
5501         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
5502         registers.
5503         (aarch64_pseudo_register_name): Likewise.
5504         (aarch64_pseudo_register_type): Likewise.
5505         (aarch64_pseudo_register_reggroup_p): Likewise.
5506         (aarch64_gdbarch_init): Add pauth registers.
5507         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
5508         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
5509         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
5510         (struct gdbarch_tdep): Add regnum for ra_state.
5511
5512 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5513             Jiong Wang  <jiong.wang@arm.com>
5514
5515         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
5516
5517 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5518             Jiong Wang  <jiong.wang@arm.com>
5519
5520         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
5521         function.
5522         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
5523         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
5524         (aarch64_gdbarch_init): Add puth registers.
5525         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
5526         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
5527         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
5528
5529 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5530             Jiong Wang  <jiong.wang@arm.com>
5531
5532         * aarch64-linux-nat.c
5533         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
5534         * aarch64-linux-tdep.c
5535         (aarch64_linux_core_read_description): Likewise.
5536         (aarch64_linux_get_hwcap): New function.
5537         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
5538         (aarch64_linux_get_hwcap): New declaration.
5539
5540 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5541             Jiong Wang  <jiong.wang@arm.com>
5542
5543         * aarch64-linux-nat.c
5544         (aarch64_linux_nat_target::read_description): Add pauth param.
5545         * aarch64-linux-tdep.c
5546         (aarch64_linux_core_read_description): Likewise.
5547         * aarch64-tdep.c (struct target_desc): Add in pauth.
5548         (aarch64_read_description): Add pauth param.
5549         (aarch64_gdbarch_init): Likewise.
5550         * aarch64-tdep.h (aarch64_read_description): Likewise.
5551         * arch/aarch64.c (aarch64_create_target_description): Likewise.
5552         * arch/aarch64.h (aarch64_create_target_description): Likewise.
5553         * features/Makefile: Add new files.
5554         * features/aarch64-pauth.c: New file.
5555         * features/aarch64-pauth.xml: New file.
5556
5557 2019-03-20  Tom Tromey  <tromey@adacore.com>
5558
5559         * infrun.c (handle_inferior_event): Rename from
5560         handle_inferior_event_1.  Create a scoped_value_mark.
5561         (handle_inferior_event): Remove.
5562
5563 2019-03-19  Tom Tromey  <tromey@adacore.com>
5564
5565         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
5566         * infrun.h (print_stop_event): Add "displays" parameter.
5567         * infrun.c (print_stop_event): Add "displays" parameter.
5568
5569 2019-03-19  Pedro Alves  <palves@redhat.com>
5570
5571         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
5572         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
5573         to -1.  Fix TABs vs spaces.
5574         (tui_ui_out::tui_ui_out): Don't initialize fields here.
5575         * tui/tui-out.h (tui_ui_out) Add intro comments.
5576         <m_line, m_start_of_line>: In-class initialize, and add describing
5577         comment.
5578
5579 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
5580
5581         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
5582         variable names.
5583         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
5584
5585 2019-03-18  Pedro Alves  <palves@redhat.com>
5586             Eli Zaretskii <eliz@gnu.org>
5587
5588         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
5589         m_line and m_start_of_line.
5590
5591 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
5592
5593         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
5594         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
5595         it returns a newline.  This fixes a regression in TU mode, whereby
5596         the next line is output on the same screen line as the user input.
5597
5598 2019-03-18  Tom Tromey  <tromey@adacore.com>
5599
5600         * minsyms.c (minimal_symbol_reader::install): Remove call to
5601         obstack_blank.
5602
5603 2019-03-18  Pedro Alves  <palves@redhat.com>
5604
5605         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
5606         New globals.
5607         (apply_style): New, factored out from ...
5608         (apply_ansi_escape): ... this.  Handle reverse video mode.
5609         (tui_set_reverse_mode): New function.
5610         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
5611         * tui/tui-winsource.c (tui_show_source_line): Use
5612         tui_set_reverse_mode instead of setting A_STANDOUT.
5613         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
5614         New setter methods.
5615
5616 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
5617
5618         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
5619         Handle tabs.
5620
5621 2019-03-18  Tom Tromey  <tromey@adacore.com>
5622
5623         * ada-lang.c (empty_array): Add "high" parameter.
5624         (ada_evaluate_subexp): Update.
5625
5626 2019-03-17  Sergei Trofimovich <siarheit@google.com>
5627
5628         * unittests/string_view-selftests.c: Define
5629         _initialize_string_view_selftests unconditionally.
5630
5631 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5632
5633         PR gdb/24350
5634         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
5635
5636 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5637
5638         PR gdb/24351
5639         * windows-nat.c (display_selector): Fix format specifiers.
5640
5641 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
5642
5643         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
5644         tui_refill_source_window instead of tui_refresh_win, to update the
5645         current execution line.  This fixes redisplay of the current line
5646         when stepping through the code with "next" or "step".
5647
5648 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5649
5650         * source-cache.c (source_cache::get_source_lines): Call
5651         find_source_lines to initialize s->nlines.  This fixes vertical
5652         scrolling of TUI source window when the DOWN arrow is pressed.
5653
5654 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5655
5656         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
5657         linux-thread-db.c (_initialize_thread_db): Likewise.
5658
5659 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5660
5661         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
5662         wclrtoeol in tui_show_source_line".  This reverts changes made in
5663         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
5664
5665 2019-03-15  Tom Tromey  <tom@tromey.com>
5666
5667         * symtab.h (struct minimal_symbol): Derive from
5668         general_symbol_info.
5669         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
5670         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
5671         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
5672         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
5673         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
5674         (MSYMBOL_SEARCH_NAME): Update.
5675         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
5676         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
5677         * minsyms.c (minimal_symbol_reader::record_full): Update.
5678
5679 2019-03-15  Tom Tromey  <tom@tromey.com>
5680
5681         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
5682
5683 2019-03-15  Tom Tromey  <tom@tromey.com>
5684
5685         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
5686         unique_xmalloc_ptr.
5687         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
5688         Update.
5689         * minsyms.c (lookup_minimal_symbol_by_pc_section)
5690         (build_minimal_symbol_hash_tables)
5691         (minimal_symbol_reader::install): Update.
5692
5693 2019-03-15  Tom Tromey  <tom@tromey.com>
5694
5695         * symtab.c (create_demangled_names_hash): Update.
5696         (symbol_set_names): Update.
5697         * objfiles.h (struct objfile_per_bfd_storage)
5698         <demangled_names_hash>: Now an htab_up.
5699         * objfiles.c (objfile_per_bfd_storage): Simplify.
5700
5701 2019-03-15  Tom Tromey  <tom@tromey.com>
5702
5703         * objfiles.h (struct objfile_per_bfd_storage): Declare
5704         destructor.
5705         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
5706         New.
5707         (get_objfile_bfd_data): Use new.  Don't initialize
5708         language_of_main.
5709         (free_objfile_per_bfd_storage): Remove.
5710         (objfile_bfd_data_free, objfile::~objfile): Use delete.
5711
5712 2019-03-15  Tom Tromey  <tom@tromey.com>
5713
5714         * symfile.c (reread_symbols): Update.
5715         * objfiles.c (objfile::objfile): Update.
5716         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
5717         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
5718         comment.
5719         (minimal_symbol_reader::install): Update.
5720         (terminate_minimal_symbol_table): Remove.
5721         * jit.c (jit_object_close_impl): Update.
5722
5723 2019-03-15  Tom Tromey  <tom@tromey.com>
5724
5725         * minsyms.c (minimal_symbol_reader::record_full): Remove some
5726         initializations.
5727
5728 2019-03-15  Tom Tromey  <tom@tromey.com>
5729
5730         * objfiles.h (struct objfile_per_bfd_storage)
5731         <demangled_hash_languages>: Now a bitset.
5732         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
5733         (lookup_minimal_symbol): Update.
5734
5735 2019-03-15  Tom Tromey  <tom@tromey.com>
5736
5737         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
5738         Don't return the symbol.
5739         * coffread.c (record_minimal_symbol): Use record_full.
5740
5741 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
5742
5743         The MS-Windows port of ncurses fails to switch to a color pair if
5744         one or both of the colors are the implicit default colors.  This
5745         change records the default colors when TUI is initialized, and
5746         then specifies them explicitly when a color pair uses the default
5747         colors.  This allows color styling in TUI mode on MS-Windows.
5748
5749         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
5750         ncurses_norm_attr.
5751         (tui_initialize_io) [__MINGW32__]: Record the default terminal
5752         colors in ncurses_norm_attr.
5753         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
5754         "none", replace it with the default color recorded in
5755         ncurses_norm_attr.
5756
5757 2019-03-14  Tom Tromey  <tromey@adacore.com>
5758
5759         * source-cache.h (class source_cache) <get_source_lines>: Return
5760         std::string.
5761         * source-cache.c (source_cache::extract_lines): Handle case where
5762         first_pos==npos.  Return std::string.
5763         (source_cache::get_source_lines): Update.
5764
5765 2019-03-14  Tom Tromey  <tromey@adacore.com>
5766
5767         * NEWS: Add item for "style sources" commands.
5768         * source-cache.c (source_cache::get_source_lines): Check
5769         source_styling.
5770         * cli/cli-style.c (source_styling): New global.
5771         (_initialize_cli_style): Add "style sources" commands.
5772         (show_style_sources): New function.
5773         * cli/cli-style.h (source_styling): Declare.
5774
5775 2019-03-14  Pedro Alves  <palves@redhat.com>
5776             Tom Tromey  <tromey@adacore.com>
5777
5778         * tui/tui-winsource.h (tui_refill_source_window): Declare.
5779         * tui/tui-winsource.c (tui_refill_source_window): New function,
5780         from...
5781         (tui_horizontal_source_scroll): ... here.  Move some logic.
5782         * cli/cli-style.c (set_style_enabled): Notify new observable.
5783         * tui/tui-hooks.c (tui_redisplay_source): New function.
5784         (tui_attach_detach_observers): Attach or detach
5785         tui_redisplay_source.
5786         * observable.h (source_styling_changed): New observable.
5787         * observable.c: Define source_styling_changed observable.
5788
5789 2019-03-13  Tom Tromey  <tromey@adacore.com>
5790
5791         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
5792         (i386_gnu_nat_target::store_registers): Update.
5793         * target-debug.h (target_debug_print_std_string): New macro.
5794         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5795         * windows-tdep.c (display_one_tib): Update.
5796         * tui/tui-stack.c (tui_make_status_line): Update.
5797         * top.c (print_inferior_quit_action): Update.
5798         * thread.c (thr_try_catch_cmd): Update.
5799         (add_thread_with_info): Update.
5800         (thread_target_id_str): Update.
5801         (thr_try_catch_cmd): Update.
5802         (thread_command): Update.
5803         (thread_find_command): Update.
5804         * record-btrace.c (record_btrace_target::info_record)
5805         (record_btrace_resume_thread, record_btrace_target::resume)
5806         (record_btrace_cancel_resume, record_btrace_step_thread)
5807         (record_btrace_target::wait, record_btrace_target::wait)
5808         (record_btrace_target::wait, record_btrace_target::stop): Update.
5809         * progspace.c (print_program_space): Update.
5810         * process-stratum-target.c
5811         (process_stratum_target::thread_address_space): Update.
5812         * linux-fork.c (linux_fork_mourn_inferior)
5813         (detach_checkpoint_command, info_checkpoints_command)
5814         (linux_fork_context): Update.
5815         (linux_fork_detach): Update.
5816         (class scoped_switch_fork_info): Update.
5817         (delete_checkpoint_command): Update.
5818         * infrun.c (follow_fork_inferior): Update.
5819         (follow_fork_inferior): Update.
5820         (proceed_after_vfork_done): Update.
5821         (handle_vfork_child_exec_or_exit): Update.
5822         (follow_exec): Update.
5823         (displaced_step_prepare_throw): Update.
5824         (displaced_step_restore): Update.
5825         (start_step_over): Update.
5826         (resume_1): Update.
5827         (clear_proceed_status_thread): Update.
5828         (proceed): Update.
5829         (print_target_wait_results): Update.
5830         (do_target_wait): Update.
5831         (context_switch): Update.
5832         (stop_all_threads): Update.
5833         (restart_threads): Update.
5834         (finish_step_over): Update.
5835         (handle_signal_stop): Update.
5836         (switch_back_to_stepped_thread): Update.
5837         (keep_going_pass_signal): Update.
5838         (print_exited_reason): Update.
5839         (normal_stop): Update.
5840         * inferior.c (inferior_pid_to_str): Change return type.
5841         (print_selected_inferior): Update.
5842         (add_inferior): Update.
5843         (detach_inferior): Update.
5844         * dummy-frame.c (fprint_dummy_frames): Update.
5845         * dcache.c (dcache_info_1): Update.
5846         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
5847         (btrace_fetch, btrace_clear): Update.
5848         * linux-tdep.c (linux_core_pid_to_str): Change return type.
5849         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
5850         type.
5851         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
5852         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
5853         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
5854         * gdbarch.c, gdbarch.h: Rebuild.
5855         * gdbarch.sh (core_pid_to_str): Change return type.
5856         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
5857         return type.
5858         (windows_nat_target::pid_to_str): Change return type.
5859         (windows_delete_thread): Update.
5860         (windows_nat_target::attach): Update.
5861         (windows_nat_target::files_info): Update.
5862         * target-delegates.c: Rebuild.
5863         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
5864         return type.
5865         (sol_thread_target::pid_to_str): Change return type.
5866         * remote.c (class remote_target) <pid_to_str>: Change return
5867         type.
5868         (remote_target::pid_to_str): Change return type.
5869         (extended_remote_target::attach, remote_target::remote_stop_ns)
5870         (remote_target::remote_notif_remove_queued_reply)
5871         (remote_target::push_stop_reply, remote_target::disable_btrace):
5872         Update.
5873         (extended_remote_target::attach): Update.
5874         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
5875         type.
5876         (gdbsim_target::pid_to_str): Change return type.
5877         * ravenscar-thread.c (struct ravenscar_thread_target)
5878         <pid_to_str>: Change return type.
5879         (ravenscar_thread_target::pid_to_str): Change return type.
5880         * procfs.c (class procfs_target) <pid_to_str>: Change return
5881         type.
5882         (procfs_target::pid_to_str): Change return type.
5883         (procfs_target::attach): Update.
5884         (procfs_target::detach): Update.
5885         (procfs_target::fetch_registers): Update.
5886         (procfs_target::store_registers): Update.
5887         (procfs_target::wait): Update.
5888         (procfs_target::files_info): Update.
5889         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
5890         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
5891         return type.
5892         (nto_procfs_target::pid_to_str): Change return type.
5893         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
5894         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
5895         return type.
5896         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
5897         (exit_lwp): Update.
5898         (attach_proc_task_lwp_callback, get_detach_signal)
5899         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
5900         (linux_nat_target::resume, wait_lwp, stop_callback)
5901         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
5902         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
5903         (linux_nat_wait_1, resume_stopped_resumed_lwps)
5904         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
5905         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
5906         type.
5907         (inf_ptrace_target::attach): Update.
5908         (inf_ptrace_target::files_info): Update.
5909         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
5910         type.
5911         (go32_nat_target::pid_to_str): Change return type.
5912         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
5913         (gnu_nat_target::wait): Update.
5914         (gnu_nat_target::wait): Update.
5915         (gnu_nat_target::resume): Update.
5916         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
5917         (fbsd_nat_target::wait): Update.
5918         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
5919         type.
5920         (darwin_nat_target::attach): Update.
5921         * corelow.c (class core_target) <pid_to_str>: Change return type.
5922         (core_target::pid_to_str): Change return type.
5923         * target.c (normal_pid_to_str): Change return type.
5924         (default_pid_to_str): Likewise.
5925         (target_pid_to_str): Change return type.
5926         (target_translate_tls_address): Update.
5927         (target_announce_detach): Update.
5928         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
5929         return type.
5930         (bsd_uthread_target::pid_to_str): Change return type.
5931         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
5932         type.
5933         (bsd_kvm_target::pid_to_str): Change return type.
5934         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
5935         return type.
5936         (aix_thread_target::pid_to_str): Change return type.
5937         * target.h (struct target_ops) <pid_to_str>: Change return type.
5938         (target_pid_to_str, normal_pid_to_str): Likewise.
5939         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
5940         type.
5941         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
5942         type.
5943         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
5944         return type.
5945         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
5946         type.
5947         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
5948         type.
5949         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
5950         return type.
5951
5952 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
5953
5954         * NEWS: Mention that the new default MI version is 3.  Mention
5955         changes to the output of commands and events that deal with
5956         multi-location breakpoints.
5957         * breakpoint.c: Include "mi/mi-out.h".
5958         (print_one_breakpoint): Change output syntax if using MI version
5959         >= 3.
5960         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
5961         New.
5962         (mi_multi_location_breakpoint_output_fixed): New.
5963         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
5964         (mi_cmd_fix_multi_location_breakpoint_output): New.
5965         (mi_multi_location_breakpoint_output_fixed): New.
5966         * mi/mi-cmds.c (mi_cmds): Register command
5967         -fix-multi-location-breakpoint-output.
5968         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
5969         interpreter "mi".
5970
5971 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
5972
5973         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
5974         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
5975         instantiate mi_ui_out based on interpreter name.
5976         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
5977         * mi/mi-main.c (mi_load_progress): Likewise.
5978
5979 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5980
5981         * NEWS: Combine separate "New targets" sections for 8.3.
5982
5983 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5984
5985         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
5986         (ppcfbsd_init_abi): Install gdbarch
5987         "fetch_tls_load_module_address" and "get_thread_local_address"
5988         methods.
5989
5990 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5991
5992         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
5993         (riscv_fbsd_init_abi): Install gdbarch
5994         "fetch_tls_load_module_address" and "get_thread_local_address"
5995         methods.
5996
5997 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5998
5999         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6000         (i386fbsd_init_abi): Install gdbarch
6001         "fetch_tls_load_module_address" and "get_thread_local_address"
6002         methods.
6003
6004 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6005
6006         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6007         (amd64fbsd_init_abi): Install gdbarch
6008         "fetch_tls_load_module_address" and "get_thread_local_address"
6009         methods.
6010
6011 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6012
6013         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6014         (struct fbsd_pspace_data): New type.
6015         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6016         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6017         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6018         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6019         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6020
6021 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6022
6023         * gdbtypes.c (lookup_struct_elt): New function.
6024         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6025         * gdbtypes.h (struct struct_elt): New type.
6026         (lookup_struct_elt): New prototype.
6027
6028 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6029
6030         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6031         remove disabled code block.
6032
6033 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6034
6035         * gdbarch.sh (get_thread_local_address): New method.
6036         * gdbarch.h, gdbarch.c: Regenerate.
6037         * target.c (target_translate_tls_address): Use
6038         gdbarch_get_thread_local_address if present instead of
6039         target::get_thread_local_address.
6040
6041 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6042
6043         * target.h (target::get_thread_local_address): Update comment.
6044
6045 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6046
6047         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6048         objfile->separate_debug_objfile_backlink if not NULL.
6049
6050 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6051
6052         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6053         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6054         (amd64bsd_store_inferior_registers): Likewise.
6055         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6056         Enable segment base registers.
6057         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6058         PT_GETFSBASE and PT_GETGSBASE.
6059         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6060         PT_SETGSBASE.
6061         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6062         segment base registers.
6063         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6064
6065 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6066
6067         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6068         Update calls to i386_target_description to add 'segments'
6069         parameter.
6070         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6071         add segment base registers.
6072         * arch/i386.c (i386_create_target_description): Add 'segments'
6073         parameter to enable segment base registers.
6074         * arch/i386.h (i386_create_target_description): Likewise.
6075         * features/i386/32bit-segments.xml: New file.
6076         * features/i386/32bit-segments.c: Generate.
6077         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6078         call to i386_target_description to add 'segments' parameter.
6079         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6080         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6081         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6082         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6083         if feature is present.
6084         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6085         Add 'segments' parameter to call to i386_target_description.
6086         (i386_target_description): Add 'segments' parameter to enable
6087         segment base registers.
6088         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6089         to call to i386_target_description.
6090         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6091         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6092         Define I386_NUM_REGS.
6093         (i386_target_description): Add 'segments' parameter to enable
6094         segment base registers.
6095
6096 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6097
6098         PR/24325
6099         * source-cache.c: #undef open and close, to avoid unresolved
6100         externals during linking.
6101
6102 2019-03-12  Tom Tromey  <tromey@adacore.com>
6103
6104         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6105         const.  Add initializers.
6106         (_initialize_remote): Don't initialize ptid globals.
6107
6108 2019-03-12  Pedro Alves  <palves@redhat.com>
6109
6110         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6111
6112 2019-03-12  Pedro Alves  <palves@redhat.com>
6113
6114         * cp-name-parser.y (main): Remove unused 'len' variable.
6115
6116 2019-03-12  Tom Tromey  <tromey@adacore.com>
6117
6118         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6119         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6120
6121 2019-03-12  Tom Tromey  <tromey@adacore.com>
6122
6123         * linux-nat.c (iterate_over_lwps): Update.
6124         (stop_callback): Remove parameter.
6125         (stop_wait_callback, detach_callback, resume_set_callback)
6126         (select_singlestep_lwp_callback, set_ignore_sigint)
6127         (status_callback, resumed_callback, resume_clear_callback)
6128         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6129         data parameter.
6130         (linux_nat_target::detach, linux_nat_target::resume)
6131         (linux_stop_and_wait_all_lwps, select_event_lwp)
6132         (linux_nat_filter_event, linux_nat_wait_1)
6133         (linux_nat_target::kill, linux_nat_target::stop)
6134         (linux_nat_target::stop): Update.
6135         (linux_nat_resume_callback): Change type.
6136         (resume_stopped_resumed_lwps, count_events_callback)
6137         (select_event_lwp_callback): Likewise.
6138         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6139         * arm-linux-nat.c (struct update_registers_data): Remove.
6140         (update_registers_callback): Change type.
6141         (arm_linux_insert_hw_breakpoint1): Update.
6142         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6143         parameter.
6144         (x86_linux_dr_set_addr): Update.
6145         (x86_linux_dr_set_control): Update.
6146         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6147         (iterate_over_lwps): Use gdb::function_view.
6148         * nat/aarch64-linux-hw-point.c (struct
6149         aarch64_dr_update_callback_param): Remove.
6150         (debug_reg_change_callback): Change type.
6151         (aarch64_notify_debug_reg_change): Update.
6152         * s390-linux-nat.c (s390_refresh_per_info): Update.
6153
6154 2019-03-11  Tom Tromey  <tromey@adacore.com>
6155
6156         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6157         redundant assignment to "this_cu".
6158
6159 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6160
6161         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6162
6163 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6164
6165         * gdbtypes.c (rank_one_type_parm_set): New function extracted
6166         from...
6167         (rank_one_type): ... this.
6168
6169 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6170
6171         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6172         from...
6173         (rank_one_type): ... this.
6174
6175 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6176
6177         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6178         from...
6179         (rank_one_type): ... this.
6180
6181 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6182
6183         * gdbtypes.c (rank_one_type_parm_float): New function extracted
6184         from...
6185         (rank_one_type): ... this.
6186
6187 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6188
6189         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6190         from...
6191         (rank_one_type): ... this.
6192
6193 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6194
6195         * gdbtypes.c (rank_one_type_parm_range): New function extracted
6196         from...
6197         (rank_one_type): ... this.
6198
6199 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6200
6201         * gdbtypes.c (rank_one_type_parm_char): New function extracted
6202         from...
6203         (rank_one_type): ... this.
6204
6205 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6206
6207         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
6208         from...
6209         (rank_one_type): ... this.
6210
6211 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6212
6213         * gdbtypes.c (rank_one_type_parm_int): New function extracted
6214         from...
6215         (rank_one_type): ... this.
6216
6217 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6218
6219         * gdbtypes.c (rank_one_type_parm_func): New function extracted
6220         from...
6221         (rank_one_type): ... this.
6222
6223 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6224
6225         * gdbtypes.c (rank_one_type_parm_array): New function extracted
6226         from...
6227         (rank_one_type): ... this.
6228
6229 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6230
6231         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
6232         from...
6233         (rank_one_type): ... this.
6234
6235 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6236
6237         * inferior.c (initialize_inferiors): Ensure 'help set/show print
6238         inferior-events' shows the example events.
6239
6240 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
6241
6242         Support styling on native MS-Windows console
6243
6244         PR/24315
6245         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
6246         on MS-Windows if $TERM is not defined.
6247
6248         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
6249
6250         * posix-hdep.c (gdb_console_fputs):
6251         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
6252         functions.
6253         * ui-file.h (gdb_console_fputs): Add prototype.
6254
6255         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
6256         back to fputs only if the former returns zero.
6257
6258 2019-03-07  Tom Tromey  <tom@tromey.com>
6259
6260         * symmisc.c (print_symbol_bcache_statistics): Update.
6261         (print_objfile_statistics): Update.
6262         * symfile.c (allocate_symtab): Update.
6263         * stabsread.c: Don't include bcache.h.
6264         * psymtab.h (struct psymbol_bcache): Don't declare.
6265         (class psymtab_storage) <psymbol_cache>: Now a bcache.
6266         (psymbol_bcache_init, psymbol_bcache_free)
6267         (psymbol_bcache_get_bcache): Don't declare.
6268         * psymtab.c (struct psymbol_bcache): Remove.
6269         (psymtab_storage::psymtab_storage): Update.
6270         (psymtab_storage::~psymtab_storage): Update.
6271         (psymbol_bcache_init, psymbol_bcache_free)
6272         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
6273         (add_psymbol_to_bcache): Update.
6274         (allocate_psymtab): Update.
6275         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6276         macro_cache>: No longer pointers.
6277         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
6278         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
6279         * macrotab.c (macro_bcache): Update.
6280         * macroexp.c: Don't include bcache.h.
6281         * gdbtypes.c (check_types_worklist): Update.
6282         (types_deeply_equal): Remove TRY/CATCH.  Update.
6283         * elfread.c (elf_symtab_read): Update.
6284         * dwarf2read.c: Don't include bcache.h.
6285         * buildsym.c (buildsym_compunit::get_macro_table): Update.
6286         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
6287         (print_bcache_statistics, bcache_memory_used): Don't declare.
6288         (struct bcache): Move from bcache.c.  Add constructor, destructor,
6289         methods.  Rename all data members.
6290         * bcache.c (struct bcache): Move to bcache.h.
6291         (bcache::expand_hash_table): Rename from expand_hash_table.
6292         (bcache): Remove.
6293         (bcache::insert): Rename from bcache_full.
6294         (bcache::compare): Rename from bcache_compare.
6295         (bcache_xmalloc): Remove.
6296         (bcache::~bcache): Rename from bcache_xfree.
6297         (bcache::print_statistics): Rename from print_bcache_statistics.
6298         (bcache::memory_used): Rename from bcache_memory_used.
6299
6300 2019-03-07  Pedro Alves  <palves@redhat.com>
6301
6302         * infrun.c (normal_stop): Also check for
6303         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
6304
6305 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
6306
6307         * f-lang.c (value_from_host_double): Moved to...
6308         * value.c (value_from_host_double): ...here.
6309         * value.h (value_from_host_double): Declare.
6310         * guile/scm-math.c (vlscm_convert_typed_number): Use
6311         value_from_host_double.
6312         (vlscm_convert_number): Likewise.
6313         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
6314         * python/py-value.c (convert_value_from_python): Likewise.
6315
6316 2019-03-06  Tom Tromey  <tom@tromey.com>
6317
6318         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
6319
6320 2019-03-06  Tom Tromey  <tom@tromey.com>
6321
6322         * utils.h (free_current_contents): Don't declare.
6323         * utils.c (free_current_contents): Remove.
6324
6325 2019-03-06  Tom Tromey  <tom@tromey.com>
6326
6327         * top.c (quit_force): Update.
6328         * main.c (captured_command_loop): Update.
6329         * common/new-op.c (operator new): Update.
6330         * common/common-exceptions.c (struct catcher)
6331         <save_cleanup_chain>: Remove member.
6332         (exceptions_state_mc_init): Update.
6333         (exception_try_scope_entry): Return nullptr.
6334         (exception_try_scope_exit, exception_rethrow)
6335         (throw_exception_sjlj, throw_exception_cxx): Update.
6336         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
6337         (all_cleanups, do_cleanups, discard_cleanups)
6338         (discard_final_cleanups, save_cleanups, save_final_cleanups)
6339         (restore_cleanups, restore_final_cleanups): Don't declare.
6340         (do_final_cleanups): Remove parameter.
6341         * common/cleanups.c (cleanup_chain, make_cleanup)
6342         (make_cleanup_dtor, all_cleanups, do_cleanups)
6343         (discard_my_cleanups, discard_cleanups)
6344         (discard_final_cleanups, save_my_cleanups, save_cleanups)
6345         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
6346         (null_cleanup): Remove.
6347         (do_final_cleanups): Remove parameter.
6348
6349 2019-03-06  Tom Tromey  <tom@tromey.com>
6350
6351         * remote.c (remote_target::remote_parse_stop_reply): Use
6352         unique_xmalloc_ptr.
6353
6354 2019-03-06  Tom Tromey  <tom@tromey.com>
6355
6356         * stabsread.c (struct stabs_field_info): Rename from field_info.
6357         <list, fnlist>: Add initializers.
6358         <obstack>: New member.
6359         (read_member_functions, read_struct_fields, read_baseclasses):
6360         Allocate on obstack.  Don't use cleanups.
6361         (read_one_struct_field, read_member_functions, read_struct_fields)
6362         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
6363         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
6364         (read_struct_type): Update.
6365
6366 2019-03-06  Tom Tromey  <tom@tromey.com>
6367
6368         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
6369         * common/filestuff.h (make_cleanup_close): Don't declare.
6370         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
6371         Remove.
6372
6373 2019-03-06  Tom Tromey  <tom@tromey.com>
6374
6375         * solib-aix.c: Use make_scope_exit.
6376
6377 2019-03-06  Tom Tromey  <tom@tromey.com>
6378
6379         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
6380         Use make_scope_exit.
6381
6382 2019-03-06  Tom Tromey  <tom@tromey.com>
6383
6384         * solib-svr4.c (disable_probes_interface): Remove parameter.
6385         (svr4_handle_solib_event): Use make_scope_exit.
6386
6387 2019-03-06  Tom Tromey  <tom@tromey.com>
6388
6389         * remote.c (struct stop_reply_deleter): Remove.
6390         (stop_reply_up): Update.
6391         (struct stop_reply): Derive from notif_event.  Don't typedef.
6392         <regcache>: Now a std::vector.
6393         (stop_reply_xfree): Remove.
6394         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
6395         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
6396         (remote_target::discard_pending_stop_replies): Use delete.
6397         (remote_target::remote_parse_stop_reply): Update.
6398         (remote_target::process_stop_reply): Update.
6399         * remote-notif.h (struct notif_event): Add virtual destructor.
6400         Remove "dtr" member.
6401         (struct notif_client) <alloc_event>: Return a unique_ptr.
6402         (notif_event_xfree): Don't declare.
6403         (notif_event_up): New typedef.
6404         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
6405         (notif_event_xfree, do_notif_event_xfree): Remove.
6406         (remote_notif_state_xfree): Update.
6407
6408 2019-03-06  Tom Tromey  <tom@tromey.com>
6409
6410         * infrun.c (displaced_step_clear_cleanup): Now a
6411         forward_scope_exit type.
6412         (displaced_step_prepare_throw): Update.
6413         (displaced_step_fixup): Update.
6414
6415 2019-03-06  Tom Tromey  <tom@tromey.com>
6416
6417         * inferior.h (class inferior): Update comment.
6418         * gdbthread.h (class thread_info): Update comment.
6419
6420 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
6421             Tom Tromey  <tom@tromey.com>
6422
6423         * stabsread.h (struct stab_section_list): Remove.
6424         (coffstab_build_psymtabs): Update.
6425         * dbxread.c (symbuf_sections): Now a std::vector.
6426         (sect_idx): New global.
6427         (fill_symbuf): Update.
6428         (coffstab_build_psymtabs): Change type of stabsects parameter.
6429         Update.
6430         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6431         std::vector.
6432         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6433         (coff_locate_sections): Update.
6434         (coff_symfile_read): Remove cleanups.  Update.
6435         (init_stringtab): Add storage parameter.
6436         (free_stringtab, free_stringtab_cleanup): Remove.
6437         (init_lineno): Add storage parameter.
6438         (free_linetab, free_linetab_cleanup): Remove.
6439
6440 2019-03-06  Pedro Alves  <palves@redhat.com>
6441
6442         * linux-fork.c (fork_info::clobber_regs): Delete.
6443         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6444         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
6445         comment.  Adjust.
6446         (scoped_switch_fork_info::scoped_switch_fork_info)
6447         (checkpoint_command, linux_fork_context): Adjust
6448         fork_save_infrun_state calls.
6449
6450 2019-03-06  Pedro Alves  <palves@redhat.com>
6451
6452         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6453         (inf_has_multiple_threads): Return 'bool' and rewrite using
6454         inferior_info::threads().
6455
6456 2019-03-06  Pedro Alves  <palves@redhat.com>
6457
6458         * linux-fork.c: Include <list>.
6459         (fork_list): Now a std::list instance.
6460         (fork_info): Add ctor, dtor, and in-class initialize all fields.
6461         (forks_exist_p, find_last_fork): Adjust.
6462         (new_fork): Delete.
6463         (one_fork_p): New.
6464         (add_fork): Adjust.
6465         (free_fork): Delete, folded into fork_info::~fork_info().
6466         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6467         Adjust.
6468         (init_fork_list): Delete.
6469         (linux_fork_killall, linux_fork_mourn_inferior)
6470         (linux_fork_detach, info_checkpoints_command): Adjust.
6471         (_initialize_linux_fork): No longer call init_fork_list.
6472
6473 2019-03-06  Pedro Alves  <palves@redhat.com>
6474
6475         * linux-fork.c (new_fork): New, split out of ...
6476         (add_fork): ... this.  Return void.  Move "first fork" special
6477         case from here, to ...
6478         (checkpoint_command): ... here.
6479         * linux-linux.h (add_fork): Return void.
6480
6481 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6482
6483         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6484
6485 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6486             Chris January  <chris.january@arm.com>
6487             David Lecomber  <david.lecomber@arm.com>
6488
6489         * f-exp.y: New token, UNOP_INTRINSIC.
6490         (exp): New pattern using UNOP_INTRINSIC token.
6491         (f77_keywords): Add 'abs' keyword.
6492         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
6493         (value_from_host_double): New function.
6494         (evaluate_subexp_f): Support UNOP_ABS.
6495
6496 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6497
6498         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
6499         types.
6500
6501 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6502
6503         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
6504         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
6505         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
6506
6507 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6508
6509         * f-exp.y (convert_to_kind_type): Handle more type kinds.
6510
6511 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6512             Chris January  <chris.january@arm.com>
6513
6514         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
6515         * f-exp.y: Define 'KIND' token.
6516         (exp): New pattern for KIND expressions.
6517         (ptype): Handle types with a kind extension.
6518         (direct_abs_decl): Extend to spot kind extensions.
6519         (f77_keywords): Add 'kind' to the list.
6520         (push_kind_type): New function.
6521         (convert_to_kind_type): New function.
6522         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
6523         * parse.c (operator_length_standard): Likewise.
6524         * parser-defs.h (enum type_pieces): Add tp_kind.
6525         * std-operator.def: Add UNOP_KIND.
6526
6527 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6528
6529         * f-exp.y (f_parse): Set yydebug.
6530
6531 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6532
6533         * f-lang.c (evaluate_subexp_f): New function.
6534         (exp_descriptor_f): New global.
6535         (f_language_defn): Use exp_descriptor_f instead of
6536         exp_descriptor_standard.
6537
6538 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6539
6540         * f-exp.y (struct token): Add comments.
6541         (dot_ops): Remove uppercase versions and the end marker.
6542         (f77_keywords): Likewise.
6543         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
6544         entries in the dot_ops array are case insensitive, and use
6545         strncasecmp to compare strings.  Also some whitespace cleanup in
6546         this area.  Similar for the f77_keywords array, except entries in
6547         this list might be case sensitive.
6548
6549 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6550
6551         * f-exp.y (struct f77_boolean_val): Add comments.
6552         (boolean_values): Remove uppercase versions, and end marker.
6553         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
6554         and use strncasecmp to achieve case insensitivity.  Additionally,
6555         perform whitespace cleanup around this code.
6556
6557 2019-03-06  Tom Tromey  <tromey@adacore.com>
6558
6559         * remote-sim.c (gdbsim_target_open): Use result of
6560         gdb_argv::release.
6561
6562 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
6563         Dirk Schubert  <dirk.schubert@arm.com>
6564         Chris January  <chris.january@arm.com>
6565
6566         * eval.c (evaluate_subexp_standard): Call Fortran argument
6567         wrapping logic.
6568         * f-lang.c (struct value): A value which can be passed into a
6569         Fortran function call.
6570         (fortran_argument_convert): Wrap Fortran arguments in a pointer
6571         where appropriate.
6572         (struct type): Value ready for a Fortran function call.
6573         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
6574         is needed.
6575         * f-lang.h (fortran_argument_convert): Declaration.
6576         (fortran_preserve_arg_pointer): Declaration.
6577         * infcall.c (value_arg_coerce): Call Fortran argument logic.
6578
6579 2019-03-05  Tom Tromey  <tromey@adacore.com>
6580
6581         * python/py-prettyprint.c (print_string_repr): Remove #if.
6582         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
6583
6584 2019-03-05  Tom Tromey  <tromey@adacore.com>
6585
6586         * target.c (the_dummy_target): Move later.  Change type to
6587         "dummy_target".
6588         (initialize_targets): Don't initialize the_dummy_target.
6589
6590 2019-03-05  Tom Tromey  <tromey@adacore.com>
6591
6592         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
6593         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
6594
6595 2019-03-05  Tom Tromey  <tromey@adacore.com>
6596
6597         * windows-nat.c (windows_nat_target::attach)
6598         (windows_nat_target::detach): Don't call gdb_flush.
6599         * valprint.c (generic_val_print, val_print, val_print_string):
6600         Don't call gdb_flush.
6601         * utils.c (defaulted_query): Don't call gdb_flush.
6602         * typeprint.c (print_type_scalar): Don't call gdb_flush.
6603         * target.c (target_announce_detach): Don't call gdb_flush.
6604         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
6605         * remote.c (extended_remote_target::attach): Don't call
6606         gdb_flush.
6607         * procfs.c (procfs_target::detach): Don't call gdb_flush.
6608         * printcmd.c (do_examine): Don't call gdb_flush.
6609         (info_display_command): Don't call gdb_flush.
6610         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
6611         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
6612         * memattr.c (info_mem_command): Don't call gdb_flush.
6613         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
6614         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
6615         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
6616         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
6617         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
6618         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
6619         (gnu_nat_target::detach): Don't call gdb_flush.
6620         * f-valprint.c (f_val_print): Don't call gdb_flush.
6621         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
6622         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
6623         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
6624         gdb_flush.
6625         * c-valprint.c (c_val_print): Don't call gdb_flush.
6626         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
6627
6628 2019-03-05  Tom Tromey  <tromey@adacore.com>
6629
6630         * varobj.c (update_dynamic_varobj_children): Update.
6631         (install_default_visualizer): Use reset, not release.
6632         * value.c (set_internalvar): Update.
6633         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
6634         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
6635         ATTRIBUTE_UNUSED_RESULT.
6636
6637 2019-03-05  Tom Tromey  <tromey@adacore.com>
6638
6639         * remote.c (class scoped_remote_fd) <release>: Add
6640         ATTRIBUTE_UNUSED_RESULT.
6641
6642 2019-03-05  Tom Tromey  <tromey@adacore.com>
6643
6644         * macroexp.c (struct macro_buffer) <release>: Add
6645         ATTRIBUTE_UNUSED_RESULT.
6646
6647 2019-03-05  Tom Tromey  <tromey@adacore.com>
6648
6649         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
6650         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
6651         ATTRIBUTE_UNUSED_RESULT.
6652
6653 2019-03-05  Tom Tromey  <tromey@adacore.com>
6654
6655         * common/scoped_fd.h (class scoped_fd) <release>: Add
6656         ATTRIBUTE_UNUSED_RESULT.
6657
6658 2019-03-05  Tom Tromey  <tromey@adacore.com>
6659
6660         * parser-defs.h (struct parser_state) <release>: Add
6661         ATTRIBUTE_UNUSED_RESULT.
6662
6663 2019-03-05  Tom Tromey  <tromey@adacore.com>
6664
6665         * utils.h (class gdb_argv) <release>: Add
6666         ATTRIBUTE_UNUSED_RESULT.
6667         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
6668
6669 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
6670
6671         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
6672         for-loop range, to avoid compiler warnings.
6673
6674         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
6675         avoid compiler warnings about unused variables.
6676
6677         * NEWS: Mention end of support for native debugging on MS-Windows
6678         before XP.
6679
6680         PR gdb/24292
6681         * common/netstuff.c:
6682         * gdbserver/gdbreplay.c
6683         * gdbserver/remote-utils.c:
6684         * ser-tcp.c:
6685         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
6686         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
6687         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
6688         'getaddrinfo' and 'freeaddrinfo' were not available before
6689         Windows XP, and mingw.org's MinGW headers by default define
6690         _WIN32_WINNT to 0x500.
6691
6692 2019-03-01  Gary Benson <gbenson@redhat.com>
6693
6694         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
6695
6696 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
6697             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
6698
6699         PR gdb/8527
6700         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
6701         set_sigint_trap, clear_sigint_trap.
6702
6703 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6704
6705         * target.c (target_detach): Clear the regcache and the
6706         frame cache.
6707
6708 2019-02-27  Pedro Alves  <palves@redhat.com>
6709
6710         * utils.c (set_screen_size): When we cap the height/width sizes,
6711         tweak the corresponding command variable to show "unlimited":
6712
6713 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
6714             Pedro Alves  <palves@redhat.com>
6715
6716         * utils.c (set_screen_size): Reduce "infinite" rows and columns
6717         before calling rl_set_screen_size.
6718
6719 2019-02-27  Tom Tromey  <tromey@adacore.com>
6720
6721         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
6722         define.
6723         * python/py-value.c: Remove Python 2.4 workaround.
6724         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
6725         workaround.
6726         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
6727         Python 2.4 workaround.
6728         * python/python-internal.h: Remove Python 2.4 comment.
6729         (Py_ssize_t): Don't define.
6730         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
6731         (gdb_Py_DECREF): Remove Python 2.4 workaround.
6732         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
6733         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
6734         * python/python.c (do_start_initialization): Remove Python 2.4
6735         workaround.
6736         * python/py-prettyprint.c (class dummy_python_frame): Remove.
6737         (print_children): Remove Python 2.4 workaround.
6738         * python/py-inferior.c (buffer_procs): Remove Python 2.4
6739         workaround.
6740         (CHARBUFFERPROC_NAME): Remove.
6741         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
6742         Python 2.4 workaround.
6743
6744 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6745
6746         * NEWS: Note minimum Python version.
6747
6748 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6749
6750         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
6751         code from these functions.  Remove corresponding ifdefs.  Use
6752         Py_buffer_up instead of explicit calls to PyBuffer_Release.
6753         Remove gotos and target of gotos.
6754         (infpy_search_memory): Likewise.
6755
6756 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6757
6758         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
6759         (hppa_gdbarch_init): Don't register deleted functions with
6760         gdbarch.
6761
6762 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6763
6764         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
6765         (h8300_unwind_sp): Delete.
6766         (h8300_dummy_id): Delete.
6767         (h8300_gdbarch_init): Don't register deleted functions with
6768         gdbarch.
6769
6770 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6771
6772         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
6773         (ft32_unwind_pc): Delete.
6774         (ft32_unwind_sp): Delete.
6775         (ft32_gdbarch_init): Don't register deleted functions with
6776         gdbarch.
6777
6778 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6779
6780         * gdb/frv-tdep.c (frv_dummy_id): Delete.
6781         (frv_unwind_pc): Delete.
6782         (frv_unwind_sp): Delete.
6783         (frv_gdbarch_init): Don't register deleted functions with
6784         gdbarch.
6785
6786 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6787
6788         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
6789         (riscv_unwind_pc): Delete.
6790         (riscv_unwind_sp): Delete.
6791         (riscv_gdbarch_init): Don't register deleted functions with
6792         gdbarch.
6793
6794 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6795
6796         * gdb/csky-tdep.c (csky_dummy_id): Delete.
6797         (csky_unwind_pc): Delete.
6798         (csky_unwind_sp): Delete.
6799         (csky_gdbarch_init): Don't register deleted functions with
6800         gdbarch.
6801
6802 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6803
6804         * gdb/cris-tdep.c (cris_dummy_id): Delete.
6805         (cris_unwind_pc): Delete.
6806         (cris_unwind_sp): Delete.
6807         (cris_gdbarch_init): Don't register deleted functions with
6808         gdbarch.
6809
6810 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6811
6812         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
6813         (bfin_unwind_pc): Delete.
6814         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
6815
6816 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6817
6818         * gdb/arm-tdep.c (arm_dummy_id): Delete.
6819         (arm_unwind_pc): Delete.
6820         (arm_unwind_sp): Delete.
6821         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
6822
6823 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6824
6825         * gdb/arc-tdep.c (arc_dummy_id): Delete.
6826         (arc_unwind_pc): Delete.
6827         (arc_unwind_sp): Delete.
6828         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
6829
6830 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6831
6832         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
6833         (alpha_unwind_pc): Delete.
6834         (alpha_gdbarch_init): Don't register deleted functions with
6835         gdbarch.
6836
6837 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6838
6839         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
6840         (aarch64_unwind_pc): Delete.
6841         (aarch64_unwind_sp): Delete.
6842         (aarch64_gdbarch_init): Don't register deleted functions with
6843         gdbarch.
6844
6845 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6846
6847         * gdbtypes.c (type_align): Don't consider static members when
6848         computing structure alignment.
6849
6850 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6851
6852         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
6853         return 0 for other types.
6854         * arch-utils.c (default_type_align): Always return 0.
6855         * gdbarch.h: Regenerate.
6856         * gdbarch.sh (type_align): Extend comment.
6857         * gdbtypes.c (type_align): Add additional comments, always call
6858         gdbarch_type_align before applying the default rules.
6859         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
6860         generic code will then apply a suitable default.
6861         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
6862         types, return 0 for other types.
6863
6864 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6865
6866         * NEWS: Create a new section for the next release branch.
6867         Rename the section of the current branch, now that it has
6868         been cut.
6869
6870 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6871
6872         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
6873         * version.in: Bump version to 8.3.50.DATE-git.
6874
6875 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
6876
6877         * aix-thread.c (ptid_cmp): Remove unused variable.
6878         (get_signaled_thread): Likewise.
6879         (store_regs_user_thread): Likewise.
6880         (store_regs_kernel_thread): Likewise.
6881         (fetch_regs_kernel_thread): Remove shadowed variable.
6882
6883 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6884
6885         * features/riscv/32bit-cpu.xml: Add register numbers.
6886         * features/riscv/32bit-fpu.c: Regenerate.
6887         * features/riscv/32bit-fpu.xml: Add register numbers.
6888         * features/riscv/64bit-cpu.xml: Add register numbers.
6889         * features/riscv/64bit-fpu.c: Regenerate.
6890         * features/riscv/64bit-fpu.xml: Add register numbers.
6891
6892 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
6893
6894         * NEWS: Mention two argument form of gdb.Value constructor.
6895         * python/py-value.c (convert_buffer_and_type_to_value): New
6896         function.
6897         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
6898         Add support for handling an optional second argument.  Call
6899         convert_buffer_and_type_to_value as appropriate.
6900         * python/python-internal.h (Py_buffer_deleter): New struct.
6901         (Py_buffer_up): New typedef.
6902
6903 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
6904
6905         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
6906         instead of releasing ownership.
6907
6908 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
6909
6910         * dwarf2read.c (open_and_init_dwp_file): Call
6911         elf_numsections instead of bfd_count_sections to initialize
6912         dwp_file->num_sections.
6913
6914 2019-02-25  Tom Tromey  <tromey@adacore.com>
6915
6916         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
6917
6918 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
6919
6920         * gcore.in: Add '--readnever' option when invoking GDB.
6921
6922 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6923
6924         * MAINTAINERS: Update my email address.
6925
6926 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6927
6928         * build-id.c (build_id_to_debug_bfd_1): New function.
6929         (build_id_to_debug_bfd): Look for separate debug file in
6930         sysroot.
6931
6932 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6933
6934         * gdbarch.sh: Update the copyright year range that is placed into
6935         generated files.
6936
6937 2019-02-22  Keith Seitz  <keiths@redhat.com>
6938
6939         PR symtab/23853
6940         * linespec.c (create_sals_line_offset): Search for the default
6941         symtab's filename instead of its fullname.
6942
6943 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6944
6945         * NEWS: Update style defaults.
6946
6947 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6948
6949         * main.c (captured_main_1): Disable styling in batch mode.
6950
6951 2019-02-20  Tom Tromey  <tom@tromey.com>
6952
6953         * symtab.c (symtab_symbol_info): Fix typos.
6954
6955 2019-02-20  Tom Tromey  <tromey@adacore.com>
6956
6957         * findcmd.c (_initialize_mem_search): Use upper case for
6958         metasyntactic variables.
6959
6960 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
6961
6962         * aarch64-tdep.c (aarch64_add_reggroups): New function.
6963         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
6964
6965 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
6966
6967         * top.h (source_file_name): Change to std::string.
6968         * top.c (source_file_name): Likewise.
6969         (command_line_input): Adjust.
6970         * cli/cli-script.c (script_from_file): Adjust.
6971
6972 2019-02-19  Tom Tromey  <tromey@adacore.com>
6973
6974         * ravenscar-thread.c
6975         (ravenscar_thread_target::update_thread_list): Don't call
6976         ada_build_task_list.
6977         * ada-lang.h (ada_build_task_list): Don't declare.
6978         * ada-tasks.c (struct ada_tasks_inferior_data)
6979         <task_list_valid_p>: Now bool.
6980         (read_known_tasks, ada_task_list_changed)
6981         (ada_tasks_invalidate_inferior_data): Update.
6982         (read_known_tasks_array): Return bool.
6983         (read_known_tasks_list): Likewise.
6984         (read_known_tasks): Return void.
6985         (ada_build_task_list): Now static.
6986
6987 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6988
6989         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
6990         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
6991
6992 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6993
6994         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
6995         variant for ada_tasks_pspace_data_handle and
6996         ada_tasks_inferior_data_handle.
6997         (ada_tasks_pspace_data_cleanup): New function.
6998         (ada_tasks_inferior_data_cleanup): New function.
6999
7000 2019-02-17  Tom Tromey  <tom@tromey.com>
7001
7002         * macrotab.h (macro_source_fullname): Return a std::string.
7003         * macrotab.c (macro_include, check_for_redefinition)
7004         (macro_undef, macro_lookup_definition, foreach_macro)
7005         (foreach_macro_in_scope): Update.
7006         (macro_source_fullname): Return a std::string.
7007         * macrocmd.c (show_pp_source_pos): Update.
7008
7009 2019-02-17  Tom Tromey  <tom@tromey.com>
7010
7011         * macrocmd.c (show_pp_source_pos): Style the file names.
7012
7013 2019-02-17  Tom Tromey  <tom@tromey.com>
7014
7015         PR tui/24197:
7016         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7017
7018 2019-02-17  Tom Tromey  <tom@tromey.com>
7019
7020         * ada-lang.c (user_select_syms): Use filtered printing.
7021         * utils.c (wrap_style): New global.
7022         (desired_style): Remove.
7023         (emit_style_escape): Add stream parameter.
7024         (set_output_style, reset_terminal_style, prompt_for_continue):
7025         Update.
7026         (flush_wrap_buffer): Only flush gdb_stdout.
7027         (wrap_here): Set wrap_style.
7028         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7029         treat escape sequences as a character.  Change when wrap buffer is
7030         flushed.
7031         (fputs_styled): Do not set the output style when the default is
7032         requested.
7033         * ui-style.h (struct ui_file_style) <is_default>: New method.
7034         * source.c (print_source_lines_base): Emit escape sequences in one
7035         piece.
7036
7037 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7038
7039         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7040         integers and enumeration types.
7041
7042 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7043
7044         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7045         instead of lookup_symbol_in_language
7046         (do_exact_match): New function.
7047         (ada_get_symbol_name_matcher): Return do_exact_match when
7048         doing a verbatim match.
7049
7050 2019-02-15  Tom Tromey  <tromey@adacore.com>
7051
7052         * ravenscar-thread.c (ravenscar_thread_target::resume)
7053         (ravenscar_thread_target::wait): Special case wildcard requests.
7054
7055 2019-02-15  Tom Tromey  <tromey@adacore.com>
7056
7057         * ravenscar-thread.c (base_ptid): Remove.
7058         (struct ravenscar_thread_target) <close>: New method.
7059         <m_base_ptid>: New member.
7060         <update_inferior_ptid, active_task, task_is_currently_active,
7061         runtime_initialized>: Declare methods.
7062         <ravenscar_thread_target>: Add constructor.
7063         (ravenscar_thread_target::task_is_currently_active)
7064         (ravenscar_thread_target::update_inferior_ptid)
7065         (ravenscar_runtime_initialized): Rename.  Now methods.
7066         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7067         (ravenscar_thread_target::update_thread_list): Update.
7068         (ravenscar_thread_target::active_task): Now method.
7069         (ravenscar_thread_target::store_registers)
7070         (ravenscar_thread_target::prepare_to_store)
7071         (ravenscar_thread_target::prepare_to_store)
7072         (ravenscar_thread_target::mourn_inferior): Update.
7073         (ravenscar_inferior_created): Use "new" to create target.
7074         (ravenscar_thread_target::get_ada_task_ptid): Update.
7075         (_initialize_ravenscar): Don't initialize base_ptid.
7076         (ravenscar_ops): Remove global.
7077
7078 2019-02-15  Tom Tromey  <tromey@adacore.com>
7079
7080         * target.h (push_target): Declare new overload.
7081         * target.c (push_target): New overload, taking an rvalue reference.
7082         * remote.c (remote_target::open_1): Use push_target overload.
7083         * corelow.c (core_target_open): Use push_target overload.
7084
7085 2019-02-15  Tom Tromey  <tromey@adacore.com>
7086
7087         * ravenscar-thread.c (is_ravenscar_task)
7088         (ravenscar_task_is_currently_active): Return bool.
7089         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7090         (_initialize_ravenscar): Remove "(void)".
7091         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7092         Return bool.
7093
7094 2019-02-15  Tom Tromey  <tromey@adacore.com>
7095
7096         * ravenscar-thread.c (ravenscar_runtime_initializer)
7097         (has_ravenscar_runtime, get_running_thread_id)
7098         (ravenscar_thread_target::resume): Fix indentation.
7099
7100 2019-02-15  Tom Tromey  <tromey@adacore.com>
7101
7102         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7103         from ravenscar_arch_ops.
7104         (sparc_ravenscar_ops::fetch_registers)
7105         (sparc_ravenscar_ops::store_registers): Now methods.
7106         (sparc_ravenscar_prepare_to_store): Remove.
7107         (sparc_ravenscar_ops): Redefine.
7108         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7109         methods and destructor.  Remove members.
7110         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7111         (ravenscar_thread_target::store_registers)
7112         (ravenscar_thread_target::prepare_to_store): Update.
7113         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7114         Remove.
7115         (struct ppc_ravenscar_powerpc_ops): Derive from
7116         ravenscar_arch_ops.
7117         (ppc_ravenscar_powerpc_ops::fetch_registers)
7118         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7119         (ppc_ravenscar_powerpc_ops): Redefine.
7120         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7121         (ppc_ravenscar_e500_ops::fetch_registers)
7122         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7123         (ppc_ravenscar_e500_ops): Redefine.
7124         * aarch64-ravenscar-thread.c
7125         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7126         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7127         (aarch64_ravenscar_fetch_registers)
7128         (aarch64_ravenscar_store_registers): Now methods.
7129         (aarch64_ravenscar_ops): Redefine.
7130
7131 2019-02-15  Tom Tromey  <tromey@adacore.com>
7132
7133         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7134         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7135         (ravenscar_thread_target::stopped_by_watchpoint)
7136         (ravenscar_thread_target::stopped_data_address)
7137         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7138
7139 2019-02-15  Tom Tromey  <tromey@adacore.com>
7140
7141         * ravenscar-thread.c: Fix some typos.
7142
7143 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7144             Tom Tromey  <tromey@adacore.com>
7145
7146         * ada-lang.c (ada_exception_sal): Change addr_string to a
7147         std::string.
7148         (create_ada_exception_catchpoint): Update.
7149
7150 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7151             Tom Tromey  <tromey@adacore.com>
7152
7153         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7154         (bp_location_ops): Remove.
7155         (base_breakpoint_allocate_location): Update.
7156         (free_bp_location): Update.
7157         * ada-lang.c (class ada_catchpoint_location)
7158         <ada_catchpoint_location>: Remove ops parameter.
7159         (ada_catchpoint_location_dtor): Remove.
7160         (ada_catchpoint_location_ops): Remove.
7161         (allocate_location_exception): Update.
7162         * breakpoint.h (struct bp_location_ops): Remove.
7163         (class bp_location) <bp_location>: Remove bp_location_ops
7164         parameter.
7165         <~bp_location>: Add destructor.
7166         <ops>: Remove.
7167
7168 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7169             Pedro Alves  <palves@redhat.com>
7170
7171         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7172         'PATH_MAX'.
7173
7174 2019-02-14  David Michael  <fedora.dm0@gmail.com>
7175             Samuel Thibault  <samuel.thibault@gnu.org>
7176             Thomas Schwinge  <thomas@codesourcery.com>
7177
7178         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7179         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
7180
7181 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7182
7183         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7184         (check_empty): Use "const char *".
7185
7186         * gnu-nat.c (gnu_nat_target::detach): Instead of
7187         'detach_inferior (pid)' call
7188         'detach_inferior (find_inferior_pid (pid))'.
7189
7190         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7191         'nat/fork-inferior.o'.
7192         * gnu-nat.c: #include "nat/fork-inferior.h".
7193
7194         * gnu-nat.c (gnu_nat_target::detach): Instead of
7195         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
7196         * gnu-nat.h: #include "inf-child.h".
7197         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
7198         'i386_gnu_nat_target::fetch_registers'.
7199         (gnu_store_registers): Rename/move to
7200         'i386_gnu_nat_target::store_registers'.
7201
7202         * config/i386/nm-i386gnu.h: Don't "#include" any files.
7203         * gnu-nat.h (mach_thread_info): New function.
7204         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
7205
7206         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
7207
7208 2019-02-14  Frederic Konrad  <konrad@adacore.com>
7209
7210         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
7211
7212 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
7213
7214         * windows-nat.c (windows_add_thread): Add new parameter
7215         "main_thread_p" with default value set to false.  Update
7216         function documentation as well as all callers.
7217         (windows_delete_thread): Likewise.
7218         (fake_create_process): Update call to windows_add_thread.
7219         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
7220         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
7221         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
7222         call to windows_delete_thread.
7223
7224 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
7225
7226         * MAINTAINERS: Add Andrew Burgess as global maintainer.
7227
7228 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7229
7230         * symfile.c (find_separate_debug_file): Use canonical path of
7231         sysroot with child_path instead of gdb_sysroot if it is valid.
7232
7233 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7234
7235         * symfile.c (find_separate_debug_file): Use child_path to
7236         determine if an object file is under a sysroot.
7237
7238 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7239
7240         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
7241         unittests/child-path-selftests.c.
7242         * common/pathstuff.c (child_path): New function.
7243         * common/pathstuff.h (child_path): New prototype.
7244         * unittests/child-path-selftests.c: New file.
7245
7246 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7247
7248         * symfile.c (find_separate_debug_file): Look for separate debug
7249         files in debug directories under the sysroot.
7250
7251 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7252
7253         * symtab.h (struct minimal_symbol data_p): New const method.
7254         (struct minimal_symbol text_p): Likewise.
7255         * symtab.c (output_source_filename): Use file name style
7256         to print file name.
7257         (print_symbol_info): Likewise.
7258         (print_msymbol_info): Use address style to print addresses.
7259         Use function name style to print executable text symbols.
7260         (expand_symtab_containing_pc): Use data_p.
7261         (find_pc_sect_compunit_symtab): Likewise.
7262
7263 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7264
7265         * breakpoint.c (describe_other_breakpoints): Use address style
7266         to print addresses.
7267         (say_where): Likewise.
7268
7269 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7270
7271         * ada-typeprint.c (print_func_type): Print function name
7272         style to print function name.
7273         * c-typeprint.c (c_print_type_1): Likewise.
7274
7275 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
7276
7277         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
7278         for execve.
7279
7280 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7281
7282         * c-exp.y (direct_abs_decl): Use emplace_back to record the
7283         type_stack.
7284
7285 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
7286
7287         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
7288         TYPE_CODE_REF types.
7289
7290 2019-02-08  Jim Wilson  <jimw@sifive.com>
7291
7292         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
7293         (riscv_linux_fregset): New.
7294         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
7295
7296 2019-02-07  Tom Tromey  <tom@tromey.com>
7297
7298         * thread.c (thread_cancel_execution_command): Update.
7299         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
7300         methods.
7301         (struct thread_fsm_ops): Remove.
7302         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
7303         (thread_fsm_should_stop, thread_fsm_return_value)
7304         (thread_fsm_set_finished, thread_fsm_finished_p)
7305         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
7306         Don't declare.
7307         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
7308         * infrun.c (clear_proceed_status_thread)
7309         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
7310         (print_stop_event): Update.
7311         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
7312         Add constructor.
7313         (step_command_fsm_ops): Remove.
7314         (new_step_command_fsm): Remove.
7315         (step_1): Update.
7316         (step_command_fsm::should_stop): Rename from
7317         step_command_fsm_should_stop.
7318         (step_command_fsm::clean_up): Rename from
7319         step_command_fsm_clean_up.
7320         (step_command_fsm::do_async_reply_reason): Rename from
7321         step_command_fsm_async_reply_reason.
7322         (struct until_next_fsm): Inherit from thread_fsm.  Add
7323         constructor.
7324         (until_next_fsm_ops): Remove.
7325         (new_until_next_fsm): Remove.
7326         (until_next_fsm::should_stop): Rename from
7327         until_next_fsm_should_stop.
7328         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
7329         (until_next_fsm::do_async_reply_reason): Rename from
7330         until_next_fsm_async_reply_reason.
7331         (struct finish_command_fsm): Inherit from thread_fsm.  Add
7332         constructor.  Change type of breakpoint.
7333         (finish_command_fsm_ops): Remove.
7334         (new_finish_command_fsm): Remove.
7335         (finish_command_fsm::should_stop): Rename from
7336         finish_command_fsm_should_stop.
7337         (finish_command_fsm::clean_up): Rename from
7338         finish_command_fsm_clean_up.
7339         (finish_command_fsm::return_value): Rename from
7340         finish_command_fsm_return_value.
7341         (finish_command_fsm::do_async_reply_reason): Rename from
7342         finish_command_fsm_async_reply_reason.
7343         (finish_command): Update.
7344         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
7345         Add constructor.
7346         (call_thread_fsm_ops): Remove.
7347         (call_thread_fsm::call_thread_fsm): Rename from
7348         new_call_thread_fsm.
7349         (call_thread_fsm::should_stop): Rename from
7350         call_thread_fsm_should_stop.
7351         (call_thread_fsm::should_notify_stop): Rename from
7352         call_thread_fsm_should_notify_stop.
7353         (run_inferior_call, call_function_by_hand_dummy): Update.
7354         * cli/cli-interp.c (should_print_stop_to_console): Update.
7355         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
7356         Add constructor.  Change type of location_breakpoint,
7357         caller_breakpoint.
7358         (until_break_fsm_ops): Remove.
7359         (new_until_break_fsm): Remove.
7360         (until_break_fsm::should_stop): Rename from
7361         until_break_fsm_should_stop.
7362         (until_break_fsm::clean_up): Rename from
7363         until_break_fsm_clean_up.
7364         (until_break_fsm::do_async_reply_reason): Rename from
7365         until_break_fsm_async_reply_reason.
7366         (until_break_command): Update.
7367         * thread-fsm.c: Remove.
7368         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
7369
7370 2019-02-07  Tom Tromey  <tom@tromey.com>
7371
7372         * yy-remap.h: Add include guard.
7373         * xtensa-tdep.h: Add include guard.
7374         * xcoffread.h: Rename include guard.
7375         * varobj-iter.h: Add include guard.
7376         * tui/tui.h: Rename include guard.
7377         * tui/tui-winsource.h: Rename include guard.
7378         * tui/tui-wingeneral.h: Rename include guard.
7379         * tui/tui-windata.h: Rename include guard.
7380         * tui/tui-win.h: Rename include guard.
7381         * tui/tui-stack.h: Rename include guard.
7382         * tui/tui-source.h: Rename include guard.
7383         * tui/tui-regs.h: Rename include guard.
7384         * tui/tui-out.h: Rename include guard.
7385         * tui/tui-layout.h: Rename include guard.
7386         * tui/tui-io.h: Rename include guard.
7387         * tui/tui-hooks.h: Rename include guard.
7388         * tui/tui-file.h: Rename include guard.
7389         * tui/tui-disasm.h: Rename include guard.
7390         * tui/tui-data.h: Rename include guard.
7391         * tui/tui-command.h: Rename include guard.
7392         * tic6x-tdep.h: Add include guard.
7393         * target/waitstatus.h: Rename include guard.
7394         * target/wait.h: Rename include guard.
7395         * target/target.h: Rename include guard.
7396         * target/resume.h: Rename include guard.
7397         * target-float.h: Rename include guard.
7398         * stabsread.h: Add include guard.
7399         * rs6000-tdep.h: Add include guard.
7400         * riscv-fbsd-tdep.h: Add include guard.
7401         * regformats/regdef.h: Rename include guard.
7402         * record.h: Rename include guard.
7403         * python/python.h: Rename include guard.
7404         * python/python-internal.h: Rename include guard.
7405         * python/py-stopevent.h: Rename include guard.
7406         * python/py-ref.h: Rename include guard.
7407         * python/py-record.h: Rename include guard.
7408         * python/py-record-full.h: Rename include guard.
7409         * python/py-record-btrace.h: Rename include guard.
7410         * python/py-instruction.h: Rename include guard.
7411         * python/py-events.h: Rename include guard.
7412         * python/py-event.h: Rename include guard.
7413         * procfs.h: Add include guard.
7414         * proc-utils.h: Add include guard.
7415         * p-lang.h: Add include guard.
7416         * or1k-tdep.h: Rename include guard.
7417         * observable.h: Rename include guard.
7418         * nto-tdep.h: Rename include guard.
7419         * nat/x86-linux.h: Rename include guard.
7420         * nat/x86-linux-dregs.h: Rename include guard.
7421         * nat/x86-gcc-cpuid.h: Add include guard.
7422         * nat/x86-dregs.h: Rename include guard.
7423         * nat/x86-cpuid.h: Rename include guard.
7424         * nat/ppc-linux.h: Rename include guard.
7425         * nat/mips-linux-watch.h: Rename include guard.
7426         * nat/linux-waitpid.h: Rename include guard.
7427         * nat/linux-ptrace.h: Rename include guard.
7428         * nat/linux-procfs.h: Rename include guard.
7429         * nat/linux-osdata.h: Rename include guard.
7430         * nat/linux-nat.h: Rename include guard.
7431         * nat/linux-namespaces.h: Rename include guard.
7432         * nat/linux-btrace.h: Rename include guard.
7433         * nat/glibc_thread_db.h: Rename include guard.
7434         * nat/gdb_thread_db.h: Rename include guard.
7435         * nat/gdb_ptrace.h: Rename include guard.
7436         * nat/fork-inferior.h: Rename include guard.
7437         * nat/amd64-linux-siginfo.h: Rename include guard.
7438         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7439         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7440         * nat/aarch64-linux.h: Rename include guard.
7441         * nat/aarch64-linux-hw-point.h: Rename include guard.
7442         * mn10300-tdep.h: Add include guard.
7443         * mips-linux-tdep.h: Add include guard.
7444         * mi/mi-parse.h: Rename include guard.
7445         * mi/mi-out.h: Rename include guard.
7446         * mi/mi-main.h: Rename include guard.
7447         * mi/mi-interp.h: Rename include guard.
7448         * mi/mi-getopt.h: Rename include guard.
7449         * mi/mi-console.h: Rename include guard.
7450         * mi/mi-common.h: Rename include guard.
7451         * mi/mi-cmds.h: Rename include guard.
7452         * mi/mi-cmd-break.h: Rename include guard.
7453         * m2-lang.h: Add include guard.
7454         * location.h: Rename include guard.
7455         * linux-record.h: Rename include guard.
7456         * linux-nat.h: Add include guard.
7457         * linux-fork.h: Add include guard.
7458         * i386-darwin-tdep.h: Rename include guard.
7459         * hppa-linux-offsets.h: Add include guard.
7460         * guile/guile.h: Rename include guard.
7461         * guile/guile-internal.h: Rename include guard.
7462         * gnu-nat.h: Rename include guard.
7463         * gdb-stabs.h: Rename include guard.
7464         * frv-tdep.h: Add include guard.
7465         * f-lang.h: Add include guard.
7466         * event-loop.h: Add include guard.
7467         * darwin-nat.h: Rename include guard.
7468         * cp-abi.h: Rename include guard.
7469         * config/sparc/nm-sol2.h: Rename include guard.
7470         * config/nm-nto.h: Rename include guard.
7471         * config/nm-linux.h: Add include guard.
7472         * config/i386/nm-i386gnu.h: Rename include guard.
7473         * config/djgpp/nl_types.h: Rename include guard.
7474         * config/djgpp/langinfo.h: Rename include guard.
7475         * compile/gcc-cp-plugin.h: Add include guard.
7476         * compile/gcc-c-plugin.h: Add include guard.
7477         * compile/compile.h: Rename include guard.
7478         * compile/compile-object-run.h: Rename include guard.
7479         * compile/compile-object-load.h: Rename include guard.
7480         * compile/compile-internal.h: Rename include guard.
7481         * compile/compile-cplus.h: Rename include guard.
7482         * compile/compile-c.h: Rename include guard.
7483         * common/xml-utils.h: Rename include guard.
7484         * common/x86-xstate.h: Rename include guard.
7485         * common/version.h: Rename include guard.
7486         * common/vec.h: Rename include guard.
7487         * common/tdesc.h: Rename include guard.
7488         * common/selftest.h: Rename include guard.
7489         * common/scoped_restore.h: Rename include guard.
7490         * common/scoped_mmap.h: Rename include guard.
7491         * common/scoped_fd.h: Rename include guard.
7492         * common/safe-iterator.h: Rename include guard.
7493         * common/run-time-clock.h: Rename include guard.
7494         * common/refcounted-object.h: Rename include guard.
7495         * common/queue.h: Rename include guard.
7496         * common/ptid.h: Rename include guard.
7497         * common/print-utils.h: Rename include guard.
7498         * common/preprocessor.h: Rename include guard.
7499         * common/pathstuff.h: Rename include guard.
7500         * common/observable.h: Rename include guard.
7501         * common/netstuff.h: Rename include guard.
7502         * common/job-control.h: Rename include guard.
7503         * common/host-defs.h: Rename include guard.
7504         * common/gdb_wait.h: Rename include guard.
7505         * common/gdb_vecs.h: Rename include guard.
7506         * common/gdb_unlinker.h: Rename include guard.
7507         * common/gdb_unique_ptr.h: Rename include guard.
7508         * common/gdb_tilde_expand.h: Rename include guard.
7509         * common/gdb_sys_time.h: Rename include guard.
7510         * common/gdb_string_view.h: Rename include guard.
7511         * common/gdb_splay_tree.h: Rename include guard.
7512         * common/gdb_setjmp.h: Rename include guard.
7513         * common/gdb_ref_ptr.h: Rename include guard.
7514         * common/gdb_optional.h: Rename include guard.
7515         * common/gdb_locale.h: Rename include guard.
7516         * common/gdb_assert.h: Rename include guard.
7517         * common/filtered-iterator.h: Rename include guard.
7518         * common/filestuff.h: Rename include guard.
7519         * common/fileio.h: Rename include guard.
7520         * common/environ.h: Rename include guard.
7521         * common/common-utils.h: Rename include guard.
7522         * common/common-types.h: Rename include guard.
7523         * common/common-regcache.h: Rename include guard.
7524         * common/common-inferior.h: Rename include guard.
7525         * common/common-gdbthread.h: Rename include guard.
7526         * common/common-exceptions.h: Rename include guard.
7527         * common/common-defs.h: Rename include guard.
7528         * common/common-debug.h: Rename include guard.
7529         * common/cleanups.h: Rename include guard.
7530         * common/buffer.h: Rename include guard.
7531         * common/btrace-common.h: Rename include guard.
7532         * common/break-common.h: Rename include guard.
7533         * cli/cli-utils.h: Rename include guard.
7534         * cli/cli-style.h: Rename include guard.
7535         * cli/cli-setshow.h: Rename include guard.
7536         * cli/cli-script.h: Rename include guard.
7537         * cli/cli-interp.h: Rename include guard.
7538         * cli/cli-decode.h: Rename include guard.
7539         * cli/cli-cmds.h: Rename include guard.
7540         * charset-list.h: Add include guard.
7541         * buildsym-legacy.h: Rename include guard.
7542         * bfin-tdep.h: Add include guard.
7543         * ax.h: Rename include guard.
7544         * arm-linux-tdep.h: Add include guard.
7545         * arm-fbsd-tdep.h: Add include guard.
7546         * arch/xtensa.h: Rename include guard.
7547         * arch/tic6x.h: Add include guard.
7548         * arch/i386.h: Add include guard.
7549         * arch/arm.h: Rename include guard.
7550         * arch/arm-linux.h: Rename include guard.
7551         * arch/arm-get-next-pcs.h: Rename include guard.
7552         * arch/amd64.h: Add include guard.
7553         * arch/aarch64-insn.h: Rename include guard.
7554         * arch-utils.h: Rename include guard.
7555         * annotate.h: Add include guard.
7556         * amd64-darwin-tdep.h: Rename include guard.
7557         * aarch64-linux-tdep.h: Add include guard.
7558         * aarch64-fbsd-tdep.h: Add include guard.
7559         * aarch32-linux-nat.h: Add include guard.
7560
7561 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7562
7563         * macrotab.c (macro_define_internal): New function that
7564         factorizes macro_define_object_internal and macro_define_function
7565         code.
7566         (macro_define_object_internal): Use macro_define_internal.
7567         (macro_define_function): Likewise.
7568
7569 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7570
7571         * macrocmd.c (extract_identifier): Return
7572         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
7573         callers.
7574
7575 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
7576
7577         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
7578
7579 2019-02-05  Tom Tromey  <tom@tromey.com>
7580
7581         * target.c (target_stack::unpush): Move assertion earlier.
7582
7583 2019-01-30  Tom Tromey  <tom@tromey.com>
7584
7585         PR python/23615:
7586         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
7587         (gdbpy_parse_and_eval): Likewise.
7588         * python/python-internal.h (gdbpy_allow_threads): New class.
7589
7590 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
7591
7592         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
7593         (aarch64_fbsd_fpregmap): Move earlier.
7594         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
7595         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7596         instead of individual calls to trad_frame_set_reg_addr.
7597         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
7598         earlier.
7599         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
7600         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7601         instead of individual calls to trad_frame_set_reg_addr.
7602
7603 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
7604
7605         * CONTRIBUTE: Replace contribution list with wiki link.
7606
7607 2019-01-25  Tom Tromey  <tom@tromey.com>
7608
7609         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
7610
7611 2019-01-25  Tom Tromey  <tom@tromey.com>
7612
7613         * xtensa-linux-nat.c: Fix common/ includes.
7614         * xml-support.h: Fix common/ includes.
7615         * xml-support.c: Fix common/ includes.
7616         * x86-linux-nat.c: Fix common/ includes.
7617         * windows-nat.c: Fix common/ includes.
7618         * varobj.h: Fix common/ includes.
7619         * varobj.c: Fix common/ includes.
7620         * value.c: Fix common/ includes.
7621         * valops.c: Fix common/ includes.
7622         * utils.c: Fix common/ includes.
7623         * unittests/xml-utils-selftests.c: Fix common/ includes.
7624         * unittests/utils-selftests.c: Fix common/ includes.
7625         * unittests/unpack-selftests.c: Fix common/ includes.
7626         * unittests/tracepoint-selftests.c: Fix common/ includes.
7627         * unittests/style-selftests.c: Fix common/ includes.
7628         * unittests/string_view-selftests.c: Fix common/ includes.
7629         * unittests/scoped_restore-selftests.c: Fix common/ includes.
7630         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
7631         * unittests/scoped_fd-selftests.c: Fix common/ includes.
7632         * unittests/rsp-low-selftests.c: Fix common/ includes.
7633         * unittests/parse-connection-spec-selftests.c: Fix common/
7634         includes.
7635         * unittests/optional-selftests.c: Fix common/ includes.
7636         * unittests/offset-type-selftests.c: Fix common/ includes.
7637         * unittests/observable-selftests.c: Fix common/ includes.
7638         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
7639         * unittests/memrange-selftests.c: Fix common/ includes.
7640         * unittests/memory-map-selftests.c: Fix common/ includes.
7641         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
7642         * unittests/function-view-selftests.c: Fix common/ includes.
7643         * unittests/environ-selftests.c: Fix common/ includes.
7644         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
7645         * unittests/common-utils-selftests.c: Fix common/ includes.
7646         * unittests/cli-utils-selftests.c: Fix common/ includes.
7647         * unittests/array-view-selftests.c: Fix common/ includes.
7648         * ui-file.c: Fix common/ includes.
7649         * tui/tui-io.c: Fix common/ includes.
7650         * tracepoint.h: Fix common/ includes.
7651         * tracepoint.c: Fix common/ includes.
7652         * tracefile-tfile.c: Fix common/ includes.
7653         * top.h: Fix common/ includes.
7654         * top.c: Fix common/ includes.
7655         * thread.c: Fix common/ includes.
7656         * target/waitstatus.h: Fix common/ includes.
7657         * target/waitstatus.c: Fix common/ includes.
7658         * target.h: Fix common/ includes.
7659         * target.c: Fix common/ includes.
7660         * target-memory.c: Fix common/ includes.
7661         * target-descriptions.c: Fix common/ includes.
7662         * symtab.h: Fix common/ includes.
7663         * symfile.c: Fix common/ includes.
7664         * stap-probe.c: Fix common/ includes.
7665         * spu-linux-nat.c: Fix common/ includes.
7666         * sparc-nat.c: Fix common/ includes.
7667         * source.c: Fix common/ includes.
7668         * solib.c: Fix common/ includes.
7669         * solib-target.c: Fix common/ includes.
7670         * ser-unix.c: Fix common/ includes.
7671         * ser-tcp.c: Fix common/ includes.
7672         * ser-pipe.c: Fix common/ includes.
7673         * ser-base.c: Fix common/ includes.
7674         * selftest-arch.c: Fix common/ includes.
7675         * s12z-tdep.c: Fix common/ includes.
7676         * rust-exp.y: Fix common/ includes.
7677         * rs6000-aix-tdep.c: Fix common/ includes.
7678         * riscv-tdep.c: Fix common/ includes.
7679         * remote.c: Fix common/ includes.
7680         * remote-notif.h: Fix common/ includes.
7681         * remote-fileio.h: Fix common/ includes.
7682         * remote-fileio.c: Fix common/ includes.
7683         * regcache.h: Fix common/ includes.
7684         * regcache.c: Fix common/ includes.
7685         * record-btrace.c: Fix common/ includes.
7686         * python/python.c: Fix common/ includes.
7687         * python/py-type.c: Fix common/ includes.
7688         * python/py-inferior.c: Fix common/ includes.
7689         * progspace.h: Fix common/ includes.
7690         * producer.c: Fix common/ includes.
7691         * procfs.c: Fix common/ includes.
7692         * proc-api.c: Fix common/ includes.
7693         * printcmd.c: Fix common/ includes.
7694         * ppc-linux-nat.c: Fix common/ includes.
7695         * parser-defs.h: Fix common/ includes.
7696         * osdata.c: Fix common/ includes.
7697         * obsd-nat.c: Fix common/ includes.
7698         * nat/x86-linux.c: Fix common/ includes.
7699         * nat/x86-linux-dregs.c: Fix common/ includes.
7700         * nat/x86-dregs.h: Fix common/ includes.
7701         * nat/x86-dregs.c: Fix common/ includes.
7702         * nat/ppc-linux.c: Fix common/ includes.
7703         * nat/mips-linux-watch.h: Fix common/ includes.
7704         * nat/mips-linux-watch.c: Fix common/ includes.
7705         * nat/linux-waitpid.c: Fix common/ includes.
7706         * nat/linux-ptrace.h: Fix common/ includes.
7707         * nat/linux-ptrace.c: Fix common/ includes.
7708         * nat/linux-procfs.c: Fix common/ includes.
7709         * nat/linux-personality.c: Fix common/ includes.
7710         * nat/linux-osdata.c: Fix common/ includes.
7711         * nat/linux-namespaces.c: Fix common/ includes.
7712         * nat/linux-btrace.h: Fix common/ includes.
7713         * nat/linux-btrace.c: Fix common/ includes.
7714         * nat/fork-inferior.c: Fix common/ includes.
7715         * nat/amd64-linux-siginfo.c: Fix common/ includes.
7716         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
7717         * nat/aarch64-linux.c: Fix common/ includes.
7718         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
7719         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
7720         * namespace.h: Fix common/ includes.
7721         * mips-linux-tdep.c: Fix common/ includes.
7722         * minsyms.c: Fix common/ includes.
7723         * mi/mi-parse.h: Fix common/ includes.
7724         * mi/mi-main.c: Fix common/ includes.
7725         * mi/mi-cmd-env.c: Fix common/ includes.
7726         * memrange.h: Fix common/ includes.
7727         * memattr.c: Fix common/ includes.
7728         * maint.h: Fix common/ includes.
7729         * maint.c: Fix common/ includes.
7730         * main.c: Fix common/ includes.
7731         * machoread.c: Fix common/ includes.
7732         * location.c: Fix common/ includes.
7733         * linux-thread-db.c: Fix common/ includes.
7734         * linux-nat.c: Fix common/ includes.
7735         * linux-fork.c: Fix common/ includes.
7736         * inline-frame.c: Fix common/ includes.
7737         * infrun.c: Fix common/ includes.
7738         * inflow.c: Fix common/ includes.
7739         * inferior.h: Fix common/ includes.
7740         * inferior.c: Fix common/ includes.
7741         * infcmd.c: Fix common/ includes.
7742         * inf-ptrace.c: Fix common/ includes.
7743         * inf-child.c: Fix common/ includes.
7744         * ia64-linux-nat.c: Fix common/ includes.
7745         * i387-tdep.c: Fix common/ includes.
7746         * i386-tdep.c: Fix common/ includes.
7747         * i386-linux-tdep.c: Fix common/ includes.
7748         * i386-linux-nat.c: Fix common/ includes.
7749         * i386-go32-tdep.c: Fix common/ includes.
7750         * i386-fbsd-tdep.c: Fix common/ includes.
7751         * i386-fbsd-nat.c: Fix common/ includes.
7752         * guile/scm-type.c: Fix common/ includes.
7753         * guile/guile.c: Fix common/ includes.
7754         * go32-nat.c: Fix common/ includes.
7755         * gnu-nat.c: Fix common/ includes.
7756         * gdbthread.h: Fix common/ includes.
7757         * gdbarch-selftests.c: Fix common/ includes.
7758         * gdb_usleep.c: Fix common/ includes.
7759         * gdb_select.h: Fix common/ includes.
7760         * gdb_bfd.c: Fix common/ includes.
7761         * gcore.c: Fix common/ includes.
7762         * fork-child.c: Fix common/ includes.
7763         * findvar.c: Fix common/ includes.
7764         * fbsd-nat.c: Fix common/ includes.
7765         * event-top.c: Fix common/ includes.
7766         * event-loop.c: Fix common/ includes.
7767         * dwarf2read.c: Fix common/ includes.
7768         * dwarf2loc.c: Fix common/ includes.
7769         * dwarf2-frame.c: Fix common/ includes.
7770         * dwarf-index-cache.c: Fix common/ includes.
7771         * dtrace-probe.c: Fix common/ includes.
7772         * disasm-selftests.c: Fix common/ includes.
7773         * defs.h: Fix common/ includes.
7774         * csky-tdep.c: Fix common/ includes.
7775         * cp-valprint.c: Fix common/ includes.
7776         * cp-support.h: Fix common/ includes.
7777         * cp-support.c: Fix common/ includes.
7778         * corelow.c: Fix common/ includes.
7779         * completer.h: Fix common/ includes.
7780         * completer.c: Fix common/ includes.
7781         * compile/compile.c: Fix common/ includes.
7782         * compile/compile-loc2c.c: Fix common/ includes.
7783         * compile/compile-cplus-types.c: Fix common/ includes.
7784         * compile/compile-cplus-symbols.c: Fix common/ includes.
7785         * command.h: Fix common/ includes.
7786         * cli/cli-dump.c: Fix common/ includes.
7787         * cli/cli-cmds.c: Fix common/ includes.
7788         * charset.c: Fix common/ includes.
7789         * build-id.c: Fix common/ includes.
7790         * btrace.h: Fix common/ includes.
7791         * btrace.c: Fix common/ includes.
7792         * breakpoint.h: Fix common/ includes.
7793         * breakpoint.c: Fix common/ includes.
7794         * ax.h: 
7795         (enum agent_op): Fix common/ includes.
7796         * ax-general.c (struct aop_map): Fix common/ includes.
7797         * ax-gdb.c: Fix common/ includes.
7798         * auxv.c: Fix common/ includes.
7799         * auto-load.c: Fix common/ includes.
7800         * arm-tdep.c: Fix common/ includes.
7801         * arch/riscv.c: Fix common/ includes.
7802         * arch/ppc-linux-common.c: Fix common/ includes.
7803         * arch/i386.c: Fix common/ includes.
7804         * arch/arm.c: Fix common/ includes.
7805         * arch/arm-linux.c: Fix common/ includes.
7806         * arch/arm-get-next-pcs.c: Fix common/ includes.
7807         * arch/amd64.c: Fix common/ includes.
7808         * arch/aarch64.c: Fix common/ includes.
7809         * arch/aarch64-insn.c: Fix common/ includes.
7810         * arch-utils.c: Fix common/ includes.
7811         * amd64-windows-tdep.c: Fix common/ includes.
7812         * amd64-tdep.c: Fix common/ includes.
7813         * amd64-sol2-tdep.c: Fix common/ includes.
7814         * amd64-obsd-tdep.c: Fix common/ includes.
7815         * amd64-nbsd-tdep.c: Fix common/ includes.
7816         * amd64-linux-tdep.c: Fix common/ includes.
7817         * amd64-linux-nat.c: Fix common/ includes.
7818         * amd64-fbsd-tdep.c: Fix common/ includes.
7819         * amd64-fbsd-nat.c: Fix common/ includes.
7820         * amd64-dicos-tdep.c: Fix common/ includes.
7821         * amd64-darwin-tdep.c: Fix common/ includes.
7822         * agent.c: Fix common/ includes.
7823         * ada-lang.h: Fix common/ includes.
7824         * ada-lang.c: Fix common/ includes.
7825         * aarch64-tdep.c: Fix common/ includes.
7826
7827 2019-01-25  Tom Tromey  <tom@tromey.com>
7828
7829         * common/create-version.sh: Use common/version.h.
7830
7831 2019-01-24  Pedro Alves  <palves@redhat.com>
7832
7833         * infrun.c (signal_stop, signal_print, signal_program)
7834         (signal_catch, signal_pass): Now arrays instead of pointers.
7835         (update_signals_program_target, do_target_resume)
7836         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
7837         * linux-nat.c (linux_nat_target::pass_signals)
7838         (linux_nat_target::create_inferior, linux_nat_target::attach):
7839         Adjust.
7840         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
7841         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
7842         * procfs.c (procfs_target::pass_signals): Adjust.
7843         * record-full.c (record_full_target::resume): Adjust.
7844         * remote.c (remote_target::pass_signals)
7845         (remote_target::program_signals): Adjust.
7846         * target-debug.h (target_debug_print_signals): Now takes a
7847         gdb::array_view as parameter.  Adjust.
7848         * target.h (target_ops) <pass_signals, program_signals>: Replace
7849         pointer and length parameters with gdb::array_view.
7850         (target_pass_signals, target_program_signals): Likewise.
7851         * target-delegates.c: Regenerate.
7852
7853 2019-01-24  Pedro Alves  <palves@redhat.com>
7854
7855         * common/forward-scope-exit.h
7856         (forward_scope_exit::forward_scope_exit): Pass arguments to
7857         m_bind_function directly, instead of creating a std::bind and
7858         copying that.
7859
7860 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
7861
7862         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7863         for static members.
7864         (pass_in_v_vfp_candidate): Likewise.
7865
7866 2019-01-23  Tom Tromey  <tom@tromey.com>
7867             Pedro Alves  <palves@redhat.com>
7868
7869         * regcache.c (class regcache_invalidator): Remove.
7870         (regcache::raw_write): Use make_scope_exit.
7871
7872 2019-01-23  Tom Tromey  <tom@tromey.com>
7873
7874         * ui-out.h (class ui_out_emit_type): Update comment.
7875
7876 2019-01-23  Tom Tromey  <tom@tromey.com>
7877
7878         * infrun.c (fetch_inferior_event): Update comment.
7879
7880 2019-01-23  Tom Tromey  <tom@tromey.com>
7881             Pedro Alves  <palves@redhat.com>
7882
7883         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
7884         parameter.
7885         (fetch_inferior_event): Use SCOPE_EXIT.
7886
7887
7888 2019-01-23  Tom Tromey  <tom@tromey.com>
7889             Pedro Alves  <palves@redhat.com>
7890
7891         * infrun.c (disable_thread_events): Delete.
7892         (stop_all_threads): Use SCOPE_EXIT.
7893
7894 2019-01-23  Tom Tromey  <tom@tromey.com>
7895             Pedro Alves  <palves@redhat.com>
7896
7897         * symfile.c: Include forward-scope-exit.h.
7898         (clear_symtab_users_cleanup): Replace forward declaration with
7899         a FORWARD_SCOPE_EXIT.
7900         (syms_from_objfile_1): Use the forward_scope_exit and
7901         gdb::optional instead of cleanup_function.
7902         (reread_symbols): Use the forward_scope_exit instead of
7903         cleanup_function.
7904         (clear_symtab_users_cleanup): Remove function.
7905
7906 2019-01-23  Tom Tromey  <tom@tromey.com>
7907             Pedro Alves  <palves@redhat.com>
7908
7909         * linux-nat.c: Include scope-exit.h.
7910         (cleanup_target_stop): Remove.
7911         (linux_nat_target::static_tracepoint_markers_by_strid): Use
7912         SCOPE_EXIT.
7913
7914 2019-01-23  Tom Tromey  <tom@tromey.com>
7915             Pedro Alves  <palves@redhat.com>
7916
7917         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
7918         (call_function_by_hand_dummy): Use SCOPE_EXIT.
7919
7920 2019-01-23  Tom Tromey  <tom@tromey.com>
7921             Andrew Burgess  <andrew.burgess@embecosm.com>
7922             Pedro Alves  <palves@redhat.com>
7923
7924         * infrun.c (fetch_inferior_event): Use scope_exit.
7925         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
7926         * top.c (execute_command): Use scope_exit.
7927         * breakpoint.c (bpstat_do_actions): Use scope_exit.
7928         * utils.c (do_bpstat_clear_actions_cleanup)
7929         (make_bpstat_clear_actions_cleanup): Remove.
7930
7931 2019-01-23  Tom Tromey  <tom@tromey.com>
7932             Pedro Alves  <palves@redhat.com>
7933
7934         * infrun.c: Include "common/scope-exit.h"
7935         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
7936         (wait_for_inferior): Use SCOPE_EXIT.
7937         (fetch_inferior_event): Use scope_exit.
7938
7939 2019-01-23  Tom Tromey  <tom@tromey.com>
7940             Pedro Alves  <palves@redhat.com>
7941
7942         * breakpoint.c (create_breakpoint): Remove cleanup.
7943
7944 2019-01-23  Tom Tromey  <tom@tromey.com>
7945             Andrew Burgess  <andrew.burgess@embecosm.com>
7946             Pedro Alves  <palves@redhat.com>
7947
7948 2019-01-23  Pedro Alves  <palves@redhat.com>
7949
7950         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
7951
7952 2019-01-23  Pedro Alves  <palves@redhat.com>
7953             Andrew Burgess  <andrew.burgess@embecosm.com>
7954
7955         * gdbthread.h: Include "common/forward-scope-exit.h".
7956         (scoped_finish_thread_state): Redefine custom class in terms of
7957         forward_scope_exit.
7958
7959 2019-01-23  Pedro Alves  <palves@redhat.com>
7960             Andrew Burgess  <andrew.burgess@embecosm.com>
7961
7962         * common/forward-scope-exit.h: New file.
7963
7964 2019-01-23  Pedro Alves  <palves@redhat.com>
7965             Andrew Burgess  <andrew.burgess@embecosm.com>
7966             Tom Tromey  <tom@tromey.com>
7967
7968         * common/scope-exit.h: New file.
7969
7970 2019-01-23  Pedro Alves  <palves@redhat.com>
7971
7972         * common/preprocessor.h (ESC): Rename to ...
7973         (ESC_PARENS): ... this.
7974         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
7975         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
7976
7977 2019-01-23  Tom Tromey  <tom@tromey.com>
7978
7979         * language.h (class scoped_switch_to_sym_language_if_auto):
7980         Initialize m_lang in both cases.
7981
7982 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
7983
7984         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
7985         with XCNEW.
7986
7987 2019-01-22  Tom Tromey  <tom@tromey.com>
7988
7989         * corelow.c: Do not include sys/file.h.
7990
7991 2019-01-22  Tom Tromey  <tom@tromey.com>
7992
7993         * tui/tui-wingeneral.h: Include gdb_curses.h.
7994
7995 2019-01-22  Tom Tromey  <tom@tromey.com>
7996
7997         * source-cache.h (class source_cache) <get_source_lines,
7998         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
7999
8000 2019-01-22  Tom Tromey  <tom@tromey.com>
8001
8002         * remote-fileio.h (struct remote_target): Declare.
8003
8004 2019-01-22  Tom Tromey  <tom@tromey.com>
8005
8006         * python/py-arch.c: Do not include py-ref.h.
8007         * python/py-bpevent.c: Do not include py-ref.h.
8008         * python/py-cmd.c: Do not include py-ref.h.
8009         * python/py-continueevent.c: Do not include py-ref.h.
8010         * python/py-event.h: Do not include py-ref.h.
8011         * python/py-evtregistry.c: Do not include py-ref.h.
8012         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8013         * python/py-frame.c: Do not include py-ref.h.
8014         * python/py-framefilter.c: Do not include py-ref.h.
8015         * python/py-function.c: Do not include py-ref.h.
8016         * python/py-infevents.c: Do not include py-ref.h.
8017         * python/py-linetable.c: Do not include py-ref.h.
8018         * python/py-objfile.c: Do not include py-ref.h.
8019         * python/py-param.c: Do not include py-ref.h.
8020         * python/py-prettyprint.c: Do not include py-ref.h.
8021         * python/py-progspace.c: Do not include py-ref.h.
8022         * python/py-symbol.c: Do not include py-ref.h.
8023         * python/py-symtab.c: Do not include py-ref.h.
8024         * python/py-type.c: Do not include py-ref.h.
8025         * python/py-unwind.c: Do not include py-ref.h.
8026         * python/py-utils.c: Do not include py-ref.h.
8027         * python/py-value.c: Do not include py-ref.h.
8028         * python/py-varobj.c: Do not include py-ref.h.
8029         * python/py-xmethods.c: Do not include py-ref.h.
8030         * python/python.c: Do not include py-ref.h.
8031         * varobj.c: Do not include py-ref.h.
8032
8033 2019-01-22  Tom Tromey  <tom@tromey.com>
8034
8035         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8036         keyword for bcache.
8037
8038 2019-01-22  Tom Tromey  <tom@tromey.com>
8039
8040         * compile/compile-cplus-types.c: Remove a comment by #include.
8041
8042 2019-01-22  Tom Tromey  <tom@tromey.com>
8043
8044         * compile/gcc-c-plugin.h: Include compile-internal.h.
8045
8046 2019-01-22  Tom Tromey  <tom@tromey.com>
8047
8048         * stabsread.c (EXTERN): Do not define.
8049         (symnum, next_symbol_text_func, processing_gcc_compilation)
8050         (within_function, global_sym_chain, global_stabs)
8051         (previous_stab_code, this_object_header_files)
8052         (n_this_object_header_files)
8053         (n_allocated_this_object_header_files): Define.
8054         * stabsread.h (EXTERN): Never define.  Use "extern".
8055
8056 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8057
8058         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8059         history_value.
8060
8061 2019-01-21  Tom Tromey  <tom@tromey.com>
8062
8063         * ui-out.c: Fix includes.
8064         * tui/tui-source.c: Fix includes.
8065         * target.c: Fix includes.
8066         * remote.c: Fix includes.
8067         * regcache.c: Fix includes.
8068         * python/py-block.c: Fix includes.
8069         * printcmd.c: Fix includes.
8070         * or1k-tdep.c: Fix includes.
8071         * mi/mi-main.c: Fix includes.
8072         * m32r-tdep.c: Fix includes.
8073         * csky-tdep.c: Fix includes.
8074         * compile/compile-cplus-types.c: Fix includes.
8075         * cli/cli-interp.c: Fix includes.
8076
8077 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8078
8079         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8080         for padding.
8081
8082 2019-01-16  Tom Tromey  <tom@tromey.com>
8083
8084         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8085         earlier.
8086         (struct objfile) <msymbols_range>: Move from top level.
8087         <msymbols>: New method.
8088         (class objfile_msymbols): Remove.
8089         * symtab.c (default_collect_symbol_completion_matches_break_on):
8090         Update.
8091         * symmisc.c (dump_msymbols): Update.
8092         * stabsread.c (scan_file_globals): Update.
8093         * objc-lang.c (info_selectors_command, info_classes_command)
8094         (find_methods): Update.
8095         * minsyms.c (find_solib_trampoline_target): Update.
8096         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8097         * coffread.c (coff_symfile_read): Update.
8098         * ada-lang.c (ada_lookup_simple_minsym)
8099         (ada_collect_symbol_completion_matches): Update.
8100
8101 2019-01-16  Tom Tromey  <tom@tromey.com>
8102
8103         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8104         type.  Remove no-argument constructor.
8105         <iterator::operator++>: Simplify.
8106         <begin>: Update.
8107         <end>: Use minimal_symbol_count.
8108
8109 2019-01-16  Tom Tromey  <tom@tromey.com>
8110
8111         * objfiles.h (struct objfile) <psymtabs>: New method.
8112         (class objfile_psymtabs): Remove.
8113         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8114         typedef.
8115         <range>: New method.
8116         (require_partial_symbols): Change return type.
8117         * psymtab.c (require_partial_symbols)
8118         (psym_expand_symtabs_matching): Update.
8119         * mdebugread.c (parse_partial_symbols): Update.
8120         * dbxread.c (dbx_end_psymtab): Update.
8121
8122 2019-01-15  Tom Tromey  <tom@tromey.com>
8123
8124         * symtab.c (lookup_objfile_from_block)
8125         (lookup_symbol_in_objfile_symtabs)
8126         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8127         (find_line_symtab, info_sources_command)
8128         (default_collect_symbol_completion_matches_break_on)
8129         (make_source_files_completion_list): Update.
8130         * symmisc.c (print_objfile_statistics, dump_objfile)
8131         (maintenance_print_symbols, maintenance_info_symtabs)
8132         (maintenance_check_symtabs, maintenance_info_line_tables):
8133         Update.
8134         * source.c (select_source_symtab)
8135         (forget_cached_source_info_for_objfile): Update.
8136         * objfiles.h (class objfile_compunits): Remove.
8137         (struct objfile) <compunits_range>: New typedef.
8138         (compunits): New method.
8139         * objfiles.c (objfile_relocate1): Update.
8140         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8141         * maint.c (count_symtabs_and_blocks): Update.
8142         * linespec.c (iterate_over_all_matching_symtabs): Update.
8143         * cp-support.c (add_symbol_overload_list_qualified): Update.
8144         * coffread.c (coff_symtab_read): Update.
8145         * ada-lang.c (add_nonlocal_symbols)
8146         (ada_collect_symbol_completion_matches)
8147         (ada_add_global_exceptions): Update.
8148
8149 2019-01-15  Tom Tromey  <tom@tromey.com>
8150
8151         * progspace.h (program_space) <objfiles_safe_range>: New
8152         typedef.
8153         <objfiles_safe>: New method.
8154         * objfiles.h (class all_objfiles_safe): Remove.
8155         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8156         * jit.c (jit_inferior_exit_hook): Update.
8157
8158 2019-01-17  Tom Tromey  <tom@tromey.com>
8159
8160         * progspace.h (program_space) <objfiles_range>: New typedef.
8161         <objfiles>: New method.
8162         <objfiles_head>: Rename from objfiles.
8163         (object_files): Update.
8164         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8165         * guile/scm-pretty-print.c
8166         (ppscm_find_pretty_printer_from_objfiles): Update.
8167         * guile/scm-objfile.c (gdbscm_objfiles): Update.
8168         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8169         Update.
8170         * python/py-progspace.c (pspy_get_objfiles): Update.
8171         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8172         Update.
8173         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8174         (objfpy_lookup_objfile_by_build_id): Update.
8175         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8176         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8177         Update.
8178         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8179         (expand_symtab_containing_pc, lookup_objfile_from_block)
8180         (lookup_static_symbol, basic_lookup_transparent_type)
8181         (find_pc_sect_compunit_symtab, find_symbol_at_address)
8182         (find_line_symtab, info_sources_command)
8183         (default_collect_symbol_completion_matches_break_on)
8184         (make_source_files_completion_list, find_main_name): Update.
8185         * symmisc.c (print_symbol_bcache_statistics)
8186         (print_objfile_statistics, maintenance_print_symbols)
8187         (maintenance_print_msymbols, maintenance_print_objfiles)
8188         (maintenance_info_symtabs, maintenance_check_symtabs)
8189         (maintenance_expand_symtabs, maintenance_info_line_tables):
8190         Update.
8191         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8192         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
8193         (map_overlay_command, unmap_overlay_command)
8194         (simple_overlay_update, expand_symtabs_matching)
8195         (map_symbol_filenames): Update.
8196         * symfile-debug.c (set_debug_symfile): Update.
8197         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
8198         Update.
8199         * source.c (select_source_symtab, forget_cached_source_info):
8200         Update.
8201         * solib.c (solib_read_symbols): Update.
8202         * solib-spu.c (append_ocl_sos): Update.
8203         * psymtab.c (maintenance_print_psymbols)
8204         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
8205         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
8206         * printcmd.c (info_symbol_command): Update.
8207         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
8208         Update.
8209         * objfiles.h (class all_objfiles): Remove.
8210         * objfiles.c (have_partial_symbols, have_full_symbols)
8211         (have_minimal_symbols, qsort_cmp, update_section_map)
8212         (shared_objfile_contains_address_p)
8213         (default_iterate_over_objfiles_in_search_order): Update.
8214         * objc-lang.c (info_selectors_command, info_classes_command)
8215         (find_methods): Update.
8216         * minsyms.c (find_solib_trampoline_target): Update.
8217         * maint.c (maintenance_info_sections)
8218         (maintenance_translate_address, count_symtabs_and_blocks):
8219         Update.
8220         * main.c (captured_main_1): Update.
8221         * linux-thread-db.c (try_thread_db_load_from_pdir)
8222         (has_libpthread): Update.
8223         * linespec.c (iterate_over_all_matching_symtabs)
8224         (search_minsyms_for_name): Update.
8225         * jit.c (jit_find_objf_with_entry_addr): Update.
8226         * hppa-tdep.c (find_unwind_entry)
8227         (hppa_lookup_stub_minimal_symbol): Update.
8228         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
8229         Update.
8230         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8231         (elf_gnu_ifunc_resolve_by_got): Update.
8232         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
8233         * dwarf-index-write.c (save_gdb_index_command): Update.
8234         * cp-support.c (add_symbol_overload_list_qualified): Update.
8235         * breakpoint.c (create_overlay_event_breakpoint)
8236         (create_longjmp_master_breakpoint)
8237         (create_std_terminate_master_breakpoint)
8238         (create_exception_master_breakpoint): Update.
8239         * blockframe.c (find_pc_partial_function): Update.
8240         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
8241         (ada_collect_symbol_completion_matches)
8242         (ada_add_global_exceptions): Update.
8243
8244 2019-01-17  Tom Tromey  <tom@tromey.com>
8245
8246         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
8247         declare VEC.
8248         (solib_target_parse_libraries): Change return type.
8249         (library_list_start_segment, library_list_start_section)
8250         (library_list_end_library, library_list_start_library); Update.
8251         (solib_target_free_library_list): Remove.
8252         (solib_target_parse_libraries): Remove cleanup.  Change return
8253         type.
8254         (solib_target_current_sos): Update.
8255
8256 2019-01-17  Tom Tromey  <tromey@bapiya>
8257
8258         * valprint.c: Replace "the the" with "the".
8259         * symtab.c: Replace "the the" with "the".
8260         * solib.c: Replace "the the" with "the".
8261         * solib-dsbt.c: Replace "the the" with "the".
8262         * linespec.c: Replace "the the" with "the".
8263         * dwarf2loc.h: Replace "the the" with "the".
8264         * amd64-windows-tdep.c: Replace "the the" with "the".
8265         * aarch64-tdep.c: Replace "the the" with "the".
8266
8267 2019-01-16  Keith Seitz  <keiths@redhat.com>
8268
8269         PR gdb/23773
8270         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
8271         <builder>: Rename to ..
8272         <m_builder>: ... this and make private.
8273         (dwarf2_cu::get_builder): New method.  Change all users of
8274         `builder' to use this method.
8275         (dwarf2_start_symtab): Move to ...
8276         (dwarf2_cu::start_symtab): ... here.  Update all callers
8277         (setup_type_unit_groups): Move to ...
8278         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
8279         callers.
8280         (dwarf2_cu::reset_builder): New method.
8281         (process_full_compunit, process_full_type_unit): Use
8282         dwarf2_cu::reset_builder.
8283         (follow_die_offset): Record the ancestor CU if it is different
8284         from the followed DIE's CU.
8285         (follow_die_sig_1): Likewise.
8286
8287 2019-01-15  Tom Tromey  <tom@tromey.com>
8288
8289         * remote.c (class remote_state) <buf>: Now a char_vector.
8290         <buf_size>: Remove.
8291         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
8292         parameter.
8293         (remote_target::getpkt_or_notif_sane_1)
8294         (remote_target::getpkt_sane)
8295         (remote_target::getpkt_or_notif_sane): Likewise.
8296         (class remote_target) <putpkt>: New overload.
8297         (remote_target::read_frame): Change type of "buf_p".  Remove
8298         sizeof_p parameter.
8299         (packet_ok): New overload.
8300         (packet_check_result): New overload.
8301         Update all uses.
8302
8303 2019-01-14  Tom Tromey  <tom@tromey.com>
8304
8305         * remote-notif.c (handle_notification, remote_notif_ack)
8306         (remote_notif_parse): Make "buf" const.
8307         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
8308         const.
8309         (remote_notif_parse, remote_notif_ack, handle_notification):
8310         Likewise.
8311         * remote.c (remote_notif_stop_parse): Make "buf" const.
8312         (remote_target::remote_parse_stop_reply): Make "buf" const.
8313         (remote_notif_stop_ack): Make "buf" const.
8314
8315 2019-01-14  Tom Tromey  <tom@tromey.com>
8316
8317         * remote.c (remote_console_output): Make parameter const.
8318
8319 2019-01-14  Tom Tromey  <tom@tromey.com>
8320
8321         * target-debug.h (target_debug_print_signals): Constify.
8322         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
8323         * procfs.c (procfs_target::pass_signals): Update.
8324         * linux-nat.c (linux_nat_target::pass_signals): Update.
8325         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
8326         * target-delegates.c: Rebuild.
8327         * remote.c (remote_target::program_signals): Update.
8328         (remote_target::pass_signals): Update.
8329         * target.c (target_pass_signals): Constify argument.
8330         (target_program_signals): Likewise.
8331         * target.h (struct target_ops) <pass_signals, program_signals>:
8332         Constify argument.
8333         (target_pass_signals, target_program_signals): Constify argument.
8334
8335 2019-01-14  Tom Tromey  <tom@tromey.com>
8336
8337         PR tui/28819:
8338         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
8339
8340 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
8341
8342         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
8343         field.
8344         * rs6000-tdep.c: Include reggroups.h.
8345         (IS_V_ALIAS_PSEUDOREG): Define.
8346         (rs6000_register_name): Return names for the "vX" aliases.
8347         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
8348         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
8349         aliases.  Call default_register_reggroup_p for all other
8350         pseudo-registers.
8351         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
8352         New functions.
8353         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
8354         Handle "vX" aliases.
8355         (v_alias_pseudo_register_collect): New function.
8356         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
8357         (rs6000_gdbarch_init): Initialize "vX" aliases as
8358         pseudo-registers.  Restore registration of
8359         rs6000_pseudo_register_reggroup_p with
8360         set_tdesc_pseudo_register_reggroup_p.
8361
8362 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
8363
8364         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
8365         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
8366         set_gdbarch_num_pseudo_regs.
8367
8368 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8369
8370         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
8371         Remove arg prefixname, add do_set and do_show.
8372         Add member functions set_list and show_list.
8373         * cli/cli-style.c (class cli_style_option): Update accordingly.
8374         (style_set_list): Move to file scope.
8375         (style_show_list): Likewise.
8376         (set_style): Call help_list.
8377         (show_style): Call cmd_show_list.
8378         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
8379         Update to use the new macro.
8380
8381 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
8382
8383         * ada-lang.c (_initialize_ada_language): Expand the help text
8384         for the "catch exception" command.
8385
8386 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8387
8388         * symtab.c (matching_obj_sections): Initialize obj,
8389         declare it closer to its usage.
8390
8391 2019-01-10  Tom Tromey  <tom@tromey.com>
8392
8393         * thread-iter.h (inf_threads_iterator): Use next_iterator.
8394         (basic_inf_threads_range): Remove.
8395         (inf_threads_range, inf_non_exited_threads_range)
8396         (safe_inf_threads_range): Use next_adapter.
8397
8398 2019-01-10  Keith Seitz  <keiths@redhat.com>
8399
8400         PR gdb/23712
8401         PR symtab/23010
8402         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
8403         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
8404
8405 2019-01-10  Keith Seitz  <keiths@redhat.com>
8406
8407         PR gdb/23712
8408         PR symtab/23010
8409         * dictionary.c (pending_to_vector): Remove.
8410         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8411         Remove _1 suffix, replacing functions of the same name.  Update
8412         all callers.
8413         (dict_create_hashed, dict_create_hashed_expandable)
8414         (dict_create_linear, dict_create_linear_expandable, dict_free)
8415         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8416         Make functions static.
8417
8418 2019-01-10  Keith Seitz  <keiths@redhat.com>
8419
8420         PR gdb/23712
8421         PR symtab/23010
8422         * dictionary.h (struct dictionary): Replace declaration with
8423         multidictionary.
8424         (dict_create_hashed, dict_create_hashed_expandable)
8425         (dict_create_linear, dict_create_linear_expandable)
8426         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8427         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8428         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8429         taking multidictionary argument.
8430         [ALL_DICT_SYMBOLS]: Update for multidictionary.
8431         * block.h (struct block) <dict>: Change to multidictionary
8432         and rename `multidict'.
8433         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8434         symmisc.c: Update all dictionary references to multidictionary.
8435
8436 2019-01-10  Keith Seitz  <keiths@redhat.com>
8437
8438         PR gdb/23712
8439         PR symtab/23010
8440         * dictionary.c: Include unordered_map.
8441         (pending_to_vector): New function.
8442         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8443         Rewrite the non-"_1" functions to take vector instead
8444         of linked list.
8445         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8446         "new" _1 versions of the same name.
8447         (multidictionary): Define.
8448         (std::hash<enum language): New definition.
8449         (collate_pending_symbols_by_language, mdict_create_hashed)
8450         (mdict_create_hashed_expandable, mdict_create_linear)
8451         (mdict_create_linear_expandable, mdict_free)
8452         (find_language_dictionary, create_new_language_dictionary)
8453         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8454         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8455         (mdict_size, mdict_empty): New functions.
8456         * dictionary.h (mdict_iterator): Define.
8457
8458 2019-01-10  Pedro Alves  <palves@redhat.com>
8459
8460         * breakpoint.c (read_uploaded_action)
8461         (create_tracepoint_from_upload): Adjust to use
8462         gdb::unique_xmalloc_ptr.
8463         * ctf.c (ctf_write_uploaded_tp):
8464         (SET_ARRAY_FIELD): Use emplace_back.
8465         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8466         * tracefile-tfile.c (tfile_write_uploaded_tp):
8467         * tracepoint.c (parse_tracepoint_definition): Adjust to use
8468         gdb::unique_xmalloc_ptr.
8469         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8470         at_string, cond_string, cmd_strings>: Replace char pointers
8471         with gdb::unique_xmalloc_ptr.
8472
8473 2019-01-10  Pedro Alves  <palves@redhat.com>
8474
8475         * solib-target.c (library_list_start_library): Don't xstrdup name.
8476
8477 2019-01-10  Pedro Alves  <palves@redhat.com>
8478
8479         * mdebugread.c (parse_partial_symbols): Use
8480         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8481
8482 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8483
8484         * linux-fork.c (scoped_switch_fork_info)
8485         <~scoped_switch_fork_info>: Fix incorrect variable name.
8486
8487 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8488
8489         * linux-fork.c (scoped_switch_fork_info)
8490         <scoped_switch_fork_info>: Make explicit.
8491         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
8492
8493 2019-01-10  Tom Tromey  <tom@tromey.com>
8494
8495         * objfiles.h (objfile::reset_psymtabs): Update.
8496         * objfiles.c (objfile::objfile): Update.
8497         * psymtab.h (psymtab_storage::obstack): Update.
8498         (psymtab_storage::m_obstack): Use gdb::optional.
8499         (class psymtab_storage): Update comment.  Remove objfile
8500         parameter.
8501         * psymtab.c (psymtab_storage::psymtab_storage): Update.
8502
8503 2019-01-10  Tom Tromey  <tom@tromey.com>
8504
8505         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
8506         <free_psymtabs>: Now private.
8507         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
8508         (allocate_psymtab): Use new method.
8509
8510 2019-01-10  Tom Tromey  <tom@tromey.com>
8511
8512         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
8513         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
8514         * mdebugread.c (parse_partial_symbols): Use
8515         allocate_dependencies.
8516         * dwarf2read.c (dwarf2_create_include_psymtab): Use
8517         allocate_dependencies.
8518         (process_psymtab_comp_unit_reader)
8519         (build_type_psymtab_dependencies): Likewise.
8520         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
8521
8522 2019-01-10  Tom Tromey  <tom@tromey.com>
8523
8524         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
8525         PSYMBOL_SET_LANGUAGE.
8526         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
8527
8528 2019-01-10  Tom Tromey  <tom@tromey.com>
8529
8530         * psymtab.h (psymtab_storage::obstack): New method.
8531         <m_obstack>: Rename from obstack; now private.
8532         * psymtab.c (psymtab_storage): Update.
8533         * dwarf2read.c (create_addrmap_from_index)
8534         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
8535         Update.
8536
8537 2019-01-10  Tom Tromey  <tom@tromey.com>
8538
8539         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
8540         * objfiles.h (objfile::reset_psymtabs): New method.
8541
8542 2019-01-10  Tom Tromey  <tom@tromey.com>
8543
8544         * symmisc.c (print_symbol_bcache_statistics): Update.
8545         (print_objfile_statistics): Update.
8546         * symfile.c (reread_symbols): Update.
8547         * psymtab.h (class psymtab_storage): New.
8548         * psymtab.c (psymtab_storage): New constructor.
8549         (~psymtab_storage): New destructor.
8550         (require_partial_symbols): Update.
8551         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
8552         (find_pc_sect_psymtab, find_pc_sect_psymbol)
8553         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
8554         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
8555         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
8556         (start_psymtab_common, end_psymtab_common)
8557         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
8558         (allocate_psymtab): Update.
8559         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
8560         Update.
8561         (dump_psymtab_addrmap, maintenance_print_psymbols)
8562         (maintenance_check_psymtabs): Update.
8563         (class objfile_psymtabs): Move to objfiles.h.
8564         * psympriv.h (discard_psymtab): Now inline.
8565         (psymtab_discarder::psymtab_discarder): Update.
8566         (psymtab_discarder::~psymtab_discarder): Update.
8567         (ALL_OBJFILE_PSYMTABS): Rewrite.
8568         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
8569         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
8570         Remove fields.
8571         <partial_symtabs>: New field.
8572         (class objfile_psymtabs): Move from psymtab.h.  Update.
8573         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
8574         psymbol_cache.
8575         (objfile::~objfile): Don't destroy psymbol_cache.
8576         * mdebugread.c (parse_partial_symbols): Update.
8577         * dwarf2read.c (create_addrmap_from_index)
8578         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
8579         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
8580         (add_partial_subprogram, dwarf2_ranges_read): Update.
8581         * dwarf-index-write.c (write_address_map)
8582         (write_one_signatured_type, recursively_write_psymbols)
8583         (class debug_names, class debug_names, write_psymtabs_to_index):
8584         Update.
8585
8586 2019-01-10  Tom Tromey  <tom@tromey.com>
8587
8588         * symtab.h (SYMBOL_SET_NAMES): Update.
8589         (symbol_set_names): Update.
8590         (MSYMBOL_SET_NAMES): Update.
8591         * symtab.c (symbol_set_names): Change argument to be an
8592         objfile_per_bfd_storage.
8593         * psymtab.c (add_psymbol_to_bcache): Update.
8594         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
8595
8596 2019-01-10  Tom Tromey  <tom@tromey.com>
8597
8598         * symtab.c (create_demangled_names_hash): Change argument to be an
8599         objfile_per_bfd_storage.
8600         (symbol_set_names): Update.
8601
8602 2019-01-10  Tom Tromey  <tom@tromey.com>
8603
8604         * xcoffread.c (xcoff_initial_scan): Unconditionally call
8605         init_psymbol_list.
8606         * psymtab.c (init_psymbol_list): Do nothing if already called.
8607         * psympriv.h (init_psymbol_list): Add comment.
8608         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
8609         init_psymbol_list.
8610         * dbxread.c (dbx_symfile_read): Unconditionally call
8611         init_psymbol_list.
8612
8613 2019-01-10  Tom Tromey  <tom@tromey.com>
8614
8615         * xcoffread.c (scan_xcoff_symtab): Update.
8616         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
8617         "where".
8618         * mdebugread.c (parse_partial_symbols)
8619         (handle_psymbol_enumerators): Update.
8620         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
8621         * dbxread.c (read_dbx_symtab): Update.
8622         * psympriv.h (psymbol_placement): New enum.
8623         (add_psymbol_to_list): Update.
8624
8625 2019-01-10  Tom Tromey  <tom@tromey.com>
8626
8627         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
8628         static_psymbols parameters.
8629         (scan_xcoff_symtab): Update.
8630         * psymtab.c (start_psymtab_common): Remove global_psymbols and
8631         static_psymbols parameters.
8632         * psympriv.h (start_psymtab_common): Update.
8633         * mdebugread.c (parse_partial_symbols): Update.
8634         * dwarf2read.c (create_partial_symtab): Update.
8635         * dbxread.c (read_dbx_symtab): Update.
8636         (start_psymtab): Remove global_psymbols and static_psymbols
8637         parameters.
8638
8639 2019-01-10  Tom Tromey  <tom@tromey.com>
8640
8641         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
8642         * psymtab.c (allocate_psymtab): Add comment.
8643         * psympriv.h (allocate_psymtab): Add comment.
8644         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
8645         initializations.
8646         * dbxread.c (dbx_end_psymtab): Remove some initializations.
8647
8648 2019-01-10  Tom Tromey  <tom@tromey.com>
8649
8650         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8651         Don't declare.
8652         * mipsread.c: Include mdebugread.h.
8653         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8654         Declare.
8655         * elfread.c: Include mdebugread.h.
8656
8657 2019-01-09  Tom Tromey  <tom@tromey.com>
8658
8659         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
8660         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
8661         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
8662         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
8663         (psym_lookup_symbol, psym_find_last_source_symtab)
8664         (psym_forget_cached_source_info, psym_print_stats)
8665         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
8666         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
8667         (psym_map_matching_symbols, psym_expand_symtabs_matching)
8668         (psym_find_compunit_symtab_by_address)
8669         (maintenance_print_psymbols, maintenance_info_psymtabs)
8670         (maintenance_check_psymtabs): Use ranged for.
8671         * psymtab.h (class objfile_psymtabs): New.
8672         (require_partial_symbols): Return objfile_psymtabs.
8673         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
8674
8675 2019-01-09  Tom Tromey  <tom@tromey.com>
8676
8677         * symfile.c (overlay_invalidate_all, find_pc_overlay)
8678         (find_pc_mapped_section, list_overlays_command)
8679         (map_overlay_command, unmap_overlay_command)
8680         (simple_overlay_update): Use all_objfiles.
8681         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
8682         * printcmd.c (info_symbol_command): Use all_objfiles.
8683         * objfiles.h (ALL_OBJSECTIONS): Remove.
8684         * maint.c (maintenance_translate_address): Use all_objfiles.
8685         * gcore.c (gcore_create_callback): Use all_objfiles.
8686         (objfile_find_memory_regions): Likewise.
8687
8688 2019-01-09  Tom Tromey  <tom@tromey.com>
8689
8690         * symtab.c (find_line_symtab, info_sources_command)
8691         (make_source_files_completion_list): Use objfile_compunits.
8692         * source.c (select_source_symtab): Use objfile_compunits.
8693         * objfiles.h (struct objfile): Update comment.
8694         (ALL_OBJFILES): Remove.
8695         (ALL_FILETABS): Remove.
8696         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
8697         objfile_compunits.
8698
8699 2019-01-09  Tom Tromey  <tom@tromey.com>
8700
8701         * symmisc.c (print_objfile_statistics, dump_objfile)
8702         (maintenance_print_symbols): Use compunit_filetabs.
8703         * source.c (forget_cached_source_info_for_objfile): Use
8704         compunit_filetabs.
8705         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
8706         (ALL_FILETABS): Use compunit_filetabs.
8707         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
8708         * coffread.c (coff_symtab_read): Use compunit_filetabs.
8709
8710 2019-01-09  Tom Tromey  <tom@tromey.com>
8711
8712         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
8713         (compunit_filetabs): New.
8714         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
8715         compunit_filetabs.
8716         (info_sources_command, make_source_files_completion_list): Remove
8717         declaration.
8718         * symmisc.c (print_objfile_statistics, dump_objfile)
8719         (maintenance_print_symbols): Remove declaration.
8720         (maintenance_info_symtabs): Use compunit_filetabs.
8721         (maintenance_info_line_tables): Likewise.
8722         * source.c (select_source_symtab): Change local variable name.
8723         (forget_cached_source_info_for_objfile): Remove declaration.
8724         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
8725         * objfiles.c (objfile_relocate1): Remove declaration.
8726         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8727         declaration.
8728         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
8729         * coffread.c (coff_symtab_read): Remove declaration.
8730         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
8731         compunit_filetabs.
8732
8733 2019-01-09  Tom Tromey  <tom@tromey.com>
8734
8735         * symtab.c (lookup_objfile_from_block)
8736         (find_pc_sect_compunit_symtab, search_symbols)
8737         (default_collect_symbol_completion_matches_break_on): Use
8738         objfile_compunits.
8739         * objfiles.h (ALL_COMPUNITS): Remove.
8740         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
8741         * cp-support.c (add_symbol_overload_list_qualified): Use
8742         objfile_compunits.
8743         * ada-lang.c (ada_collect_symbol_completion_matches)
8744         (ada_add_global_exceptions): Use objfile_compunits.
8745
8746 2019-01-09  Tom Tromey  <tom@tromey.com>
8747
8748         * source.c (select_source_symtab)
8749         (forget_cached_source_info_for_objfile): Remove declaration.
8750         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8751         declaration.
8752         * maint.c (count_symtabs_and_blocks): Remove declaration.
8753         * cp-support.c (add_symbol_overload_list_qualified): Remove
8754         declaration.
8755         * coffread.c (coff_symtab_read): Remove declaration.
8756         * symtab.c (lookup_symbol_in_objfile_symtabs)
8757         (basic_lookup_transparent_type_1): Use objfile_compunits.
8758         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
8759         (info_sources_command, search_symbols)
8760         (default_collect_symbol_completion_matches_break_on)
8761         (make_source_files_completion_list): Remove declaration.
8762         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
8763         (ada_collect_symbol_completion_matches)
8764         (ada_add_global_exceptions): Remove declaration.
8765         * linespec.c (iterate_over_all_matching_symtabs): Use
8766         objfile_compunits.
8767         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
8768         (class objfile_compunits): New.
8769         (ALL_COMPUNITS): Use objfile_compunits.
8770         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
8771         (maintenance_check_symtabs, maintenance_info_line_tables): Use
8772         objfile_compunits.
8773         * objfiles.c (objfile_relocate1): Use objfile_compunits.
8774
8775 2019-01-09  Tom Tromey  <tom@tromey.com>
8776
8777         * symtab.c (search_symbols)
8778         (default_collect_symbol_completion_matches_break_on): Use
8779         objfile_msymbols.
8780         * ada-lang.c (ada_lookup_simple_minsym)
8781         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
8782         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
8783         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
8784         objfile_msymbols.
8785         * coffread.c (coff_symfile_read): Use objfile_msymbols.
8786         * symmisc.c (dump_msymbols): Use objfile_msymbols.
8787         * objc-lang.c (find_methods): Use objfile_msymbols.
8788         (info_selectors_command, info_classes_command): Likewise.
8789         * stabsread.c (scan_file_globals): Use objfile_msymbols.
8790         * objfiles.h (class objfile_msymbols): New.
8791         (ALL_OBJFILE_MSYMBOLS): Remove.
8792         (ALL_MSYMBOLS): Remove.
8793
8794 2019-01-09  Tom Tromey  <tom@tromey.com>
8795
8796         * common/next-iterator.h (next_adapter): Add Iterator template
8797         parameter.
8798         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
8799         (class all_objfiles_safe): New.
8800         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
8801         * objfiles.c (put_objfile_before): Update comment.
8802         (add_separate_debug_objfile): Likewise.
8803         (free_all_objfiles): Use all_objfiles_safe.
8804         (objfile_purge_solibs): Likewise.
8805
8806 2019-01-09  Tom Tromey  <tom@tromey.com>
8807
8808         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8809         (expand_symtab_containing_pc, lookup_static_symbol)
8810         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
8811         (find_symbol_at_address, find_line_symtab, find_main_name): Use
8812         all_objfiles.
8813         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
8814         * breakpoint.c (create_overlay_event_breakpoint)
8815         (create_longjmp_master_breakpoint)
8816         (create_std_terminate_master_breakpoint)
8817         (create_exception_master_breakpoint): Use all_objfiles.
8818         * linux-thread-db.c (try_thread_db_load_from_pdir)
8819         (has_libpthread): Use all_objfiles.
8820         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
8821         * linespec.c (iterate_over_all_matching_symtabs)
8822         (search_minsyms_for_name): Use all_objfiles.
8823         * maint.c (maintenance_info_sections): Use all_objfiles.
8824         * main.c (captured_main_1): Use all_objfiles.
8825         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
8826         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
8827         * guile/scm-pretty-print.c
8828         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
8829         * solib-spu.c (append_ocl_sos): Use all_objfiles.
8830         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
8831         (maintenance_print_msymbols): Use all_objfiles.
8832         * source.c (select_source_symtab): Use all_objfiles.
8833         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
8834         * symfile.c (remove_symbol_file_command)
8835         (expand_symtabs_matching, map_symbol_filenames): Use
8836         all_objfiles.
8837         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
8838         all_objfiles.
8839         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
8840         * objc-lang.c (find_methods): Use all_objfiles.
8841         * objfiles.c (have_partial_symbols, have_full_symbols)
8842         (have_minimal_symbols, qsort_cmp)
8843         (default_iterate_over_objfiles_in_search_order): Use
8844         all_objfiles.
8845         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
8846         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
8847         (maintenance_check_psymtabs): Use all_objfiles.
8848         (ALL_PSYMTABS): Remove.
8849         * compile/compile-object-run.c (do_module_cleanup): Use
8850         all_objfiles.
8851         * blockframe.c (find_pc_partial_function): Use all_objfiles.
8852         * cp-support.c (add_symbol_overload_list_qualified): Use
8853         all_objfiles.
8854         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8855         Use all_objfiles.
8856         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
8857         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
8858         all_objfiles.
8859         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8860         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
8861         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8862         Uses all_objfiles.
8863         * solib.c (solib_read_symbols): Use all_objfiles
8864
8865 2019-01-09  Tom Tromey  <tom@tromey.com>
8866
8867         * probe.c (parse_probes_in_pspace): Use all_objfiles.
8868         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
8869         all_objfiles.
8870         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
8871         * symmisc.c (print_symbol_bcache_statistics)
8872         (print_objfile_statistics, maintenance_print_objfiles)
8873         (maintenance_info_symtabs, maintenance_check_symtabs)
8874         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
8875         all_objfiles.
8876         * source.c (forget_cached_source_info): Use all_objfiles.
8877         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
8878         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8879         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
8880         * objfiles.c (update_section_map): Use all_objfiles.
8881         (shared_objfile_contains_address_p): Likewise.
8882         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
8883         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
8884
8885 2019-01-09  Tom Tromey  <tom@tromey.com>
8886
8887         * common/next-iterator.h: New file.
8888         * objfiles.h (class all_objfiles): New.
8889         (struct objfile_iterator): New.
8890
8891 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8892
8893         * NEWS: Move the description of the changed "frame", "select-frame",
8894          and "info frame" commands to the Changed commands section.
8895
8896 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
8897
8898         * gdbtypes.c (check_stub_method_group): Remove handling of old
8899         mangling schemes.
8900         * linespec.c (find_methods): Likewise.
8901         * stabsread.c (read_member_functions): Likewise.
8902         * valops.c (search_struct_method): Likewise.
8903         (value_struct_elt_for_reference): Likewise.
8904         * NEWS: Mention this change.
8905
8906 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
8907
8908         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
8909         print_source_lines.
8910         * source.c (print_source_lines_base): Update line number check.
8911         (print_source_lines): New function.
8912         (source_lines_range::source_lines_range): New function.
8913         * source.h (class source_lines_range): New class.
8914         (print_source_lines): New declaration.
8915
8916 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8917
8918         * linespec.c (linespec_state_destructor): Free self->canonical_names.
8919
8920 2019-01-08  Tom Tromey  <tom@tromey.com>
8921             Simon Marchi  <simon.marchi@ericsson.com>
8922
8923         PR gdb/24060
8924         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
8925         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
8926         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8927         * f-exp.y (DOLLAR_VARIABLE): Likewise.
8928         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
8929         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8930
8931 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8932
8933         * source.c (select_source_symtab): Move header comment to
8934         declaration in source.h.
8935         (forget_cached_source_info_for_objfile): Likewise.
8936         (forget_cached_source_info): Likewise.
8937         (identify_source_line): Likewise.
8938         * source.h (identify_source_line): Move declaration from symtab.h
8939         and add comment from source.c
8940         (print_source_lines): Likewise.
8941         (forget_cached_source_info_for_objfile): Likewise.
8942         (forget_cached_source_info): Likewise.
8943         (select_source_symtab): Likewise.
8944         (enum print_source_lines_flag): Move definition from symtab.h.
8945         * symtab.h (identify_source_line): Move declaration to source.h.
8946         (print_source_lines): Likewise.
8947         (forget_cached_source_info_for_objfile): Likewise.
8948         (forget_cached_source_info): Likewise.
8949         (select_source_symtab): Likewise.
8950         (enum print_source_lines_flag): Move definition to source.h.
8951         * tui/tui-hooks.c: Add 'source.h' include.
8952
8953 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8954
8955         * source.c (print_source_lines_base): Handle requests to print
8956         reverse line number sequences, and guard against empty lines
8957         string.
8958
8959 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8960
8961         * source.c (print_source_lines_base): Fix skip of '\r' if next
8962         character is '\n'.
8963
8964 2019-01-06  Tom Tromey  <tom@tromey.com>
8965
8966         * c-exp.y (struct c_parse_state) <macro_original_text,
8967         expansion_obstack>: New member.
8968         (macro_original_text, expansion_obstack): Remove globals.
8969         (scan_macro_expansion, scanning_macro_expansion)
8970         (finished_macro_expansion): Update.
8971         (scan_macro_cleanup): Remove.
8972         (yylex, c_parse): Update.
8973
8974 2019-01-06  Tom Tromey  <tom@tromey.com>
8975
8976         * c-exp.y (struct c_parse_state) <strings>: New member.
8977         (operator_stoken): Update.
8978
8979 2019-01-06  Tom Tromey  <tom@tromey.com>
8980
8981         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
8982         (union type_stack_elt) <typelist_val>: Now a pointer to
8983         std::vector.
8984         (type_stack_cleanup): Don't declare.
8985         (push_typelist): Update.
8986         * parse.c (pop_typelist): Return a std::vector.
8987         (push_typelist): Take a std::vector.
8988         (follow_types): Update.  Do not free args.
8989         (type_stack_cleanup): Remove.
8990         * c-exp.y (struct c_parse_state): New.
8991         (cpstate): New global.
8992         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
8993         (nonempty_typelist): Update.
8994         (func_mod): Create a new vector.
8995         (c_parse): Create a c_parse_state.
8996         (check_parameter_typelist): Do not delete params.
8997         (function_method): Update.  Do not delete type_list.
8998
8999 2019-01-06  Tom Tromey  <tom@tromey.com>
9000
9001         PR gdb/28155:
9002         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9003         check_typedef.
9004         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9005         (print_return_value): Likewise.
9006
9007 2019-01-05  Tom Tromey  <tom@tromey.com>
9008
9009         * contrib/cleanup_check.py: Remove.
9010         * contrib/gcc-with-excheck: Remove.
9011         * contrib/exsummary.py: Remove.
9012         * contrib/excheck.py: Remove.
9013
9014 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9015
9016         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9017         NULL. Initialize tpprev to NULL instead of assigning it
9018         to NULL on the next statement.
9019         * windows-nat.c (windows_delete_thread): Remove check for
9020         main_thread_id before printing thread exit notifications.
9021         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9022         Remove thread ID check against main_thread_id.
9023         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9024         windows_delete_thread.
9025         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9026
9027 2019-01-04  Tom Tromey  <tom@tromey.com>
9028
9029         * compile/compile.c (_initialize_compile): Use upper case for
9030         metasyntactic variables.
9031         * symmisc.c (_initialize_symmisc): Use upper case for
9032         metasyntactic variables.
9033         * psymtab.c (_initialize_psymtab): Use upper case for
9034         metasyntactic variables.
9035         * demangle.c (demangle_command): Use upper case for metasyntactic
9036         variables.
9037         (_initialize_demangler): Likewise.
9038         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9039         variables.
9040
9041 2019-01-03  Tom Tromey  <tom@tromey.com>
9042
9043         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9044
9045 2019-01-03  Tom Tromey  <tom@tromey.com>
9046
9047         * python/py-symtab.c (salpy_str): Update.
9048         (struct salpy_sal_object) <symtab>: Now a PyObject.
9049         (salpy_dealloc): Update.
9050         (del_objfile_sal): Use gdbpy_ref.
9051
9052 2019-01-03  Tom Tromey  <tom@tromey.com>
9053
9054         * python/py-type.c (convert_field): Use new_reference.  Return
9055         gdbpy_ref.
9056         (make_fielditem): Return gdbpy_ref.
9057         (typy_fields): Update.
9058         (typy_getitem): Update.
9059         (field_name): Return gdbpy_ref.  Use new_reference.
9060         (typy_iterator_iternext): Update.
9061
9062 2019-01-03  Tom Tromey  <tom@tromey.com>
9063
9064         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9065
9066 2019-01-03  Tom Tromey  <tom@tromey.com>
9067
9068         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9069         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9070         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9071         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9072         (pspy_set_type_printers): Likewise.
9073         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9074         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9075         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9076         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9077         (objfpy_set_type_printers): Likewise.
9078
9079 2019-01-03  Tom Tromey  <tom@tromey.com>
9080
9081         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9082         (gdbpy_print_stack): Use gdbpy_err_fetch.
9083         * python/python-internal.h (class gdbpy_err_fetch): New class.
9084         (class gdbpy_enter) <m_error_type, m_error_value,
9085         m_error_traceback>: Remove.
9086         <m_error>: New member.
9087         (gdbpy_exception_to_string): Don't declare.
9088         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9089         * python/py-value.c (convert_value_from_python): Use
9090         gdbpy_err_fetch.
9091         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9092         gdbpy_exception_to_string.
9093         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9094         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9095         gdbpy_err_fetch.
9096
9097 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9098
9099         * linux-nat.c (delete_lwp_cleanup): Delete.
9100         (struct lwp_deleter): New struct.
9101         (lwp_info_up): New typedef.
9102         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9103         lwp_info_up.
9104
9105 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9106
9107         * linux-fork.c (class scoped_switch_fork_info): New class.
9108         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9109
9110 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9111
9112         * valops.c (find_overload_match): Remove use of null_cleanup, and
9113         calls to do_cleanups.
9114
9115 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9116
9117         * compile/compile-cplus-types.c
9118         (compile_cplus_instance::decl_name): Handle changes to
9119         cp_func_name.
9120         * cp-support.c (cp_func_name): Update header comment, update
9121         return type.
9122         * cp-support.h (cp_func_name): Update return type in declaration.
9123         * valops.c (find_overload_match): Move temp_func local to top
9124         level of function and change its type.  Use temp_func to hold and
9125         delete temporary string obtained from cp_func_name.
9126
9127 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9128
9129         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9130         gdb::char_vector, remove cleanup, and update uses of `msg`.
9131
9132 2019-01-03  Jim Wilson  <jimw@sifive.com>
9133
9134         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9135
9136 2019-01-02  Tom Tromey  <tom@tromey.com>
9137
9138         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9139         (tdesc_parse_xml): Remove cleanups.
9140         * target-descriptions.h (make_cleanup_free_target_description):
9141         Don't declare.
9142         (target_desc_deleter): New struct.
9143         (target_desc_up): New typedef.
9144         * target-descriptions.c (target_desc_deleter::operator()): Rename
9145         from free_target_description.
9146         (make_cleanup_free_target_description): Remove.
9147
9148 2019-01-02  Tom Tromey  <tom@tromey.com>
9149
9150         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9151         constructor, destructor.
9152         (linespec_parser): Remove typedef.
9153         (~linespec_parser): Rename from linespec_parser_delete.
9154         (linespec_lex_to_end, linespec_complete_label)
9155         (linespec_complete): Update.
9156         (decode_line_full): Remove cleanups.
9157         (decode_line_1): Update.
9158
9159 2019-01-02  Tom Tromey  <tom@tromey.com>
9160
9161         * python/python-internal.h (inferior_to_inferior_object): Change
9162         return type.
9163         * python/py-exitedevent.c (create_exited_event_object): Update.
9164         * python/py-inferior.c (inferior_to_inferior_object): Return
9165         gdbpy_ref.
9166         (python_new_inferior, python_inferior_deleted)
9167         (thread_to_thread_object, delete_thread_object)
9168         (build_inferior_list, gdbpy_selected_inferior): Update.
9169         * python/py-infthread.c (create_thread_object): Update.  Also fail
9170         if inferior_to_inferior_object fails.
9171
9172 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9173
9174         * inferior.h (class inferior) <displaced_step_state>: New field.
9175         * infrun.h (struct displaced_step_state): Move here from
9176         infrun.c.  Initialize fields, add constructor.
9177         <inf>: Remove field.
9178         <reset>: New method.
9179         * infrun.c (struct displaced_step_inferior_state): Move to
9180         infrun.h.
9181         (displaced_step_inferior_states): Remove.
9182         (get_displaced_stepping_state): Adust.
9183         (displaced_step_in_progress_any_inferior): Adjust.
9184         (displaced_step_in_progress_thread): Adjust.
9185         (displaced_step_in_progress): Adjust.
9186         (add_displaced_stepping_state): Remove.
9187         (get_displaced_step_closure_by_addr): Adjust.
9188         (remove_displaced_stepping_state): Remove.
9189         (infrun_inferior_exit): Call displaced_step_state.reset.
9190         (use_displaced_stepping): Don't check for NULL.
9191         (displaced_step_prepare_throw): Call
9192         get_displaced_stepping_state.
9193         (displaced_step_fixup): Don't check for NULL.
9194         (prepare_for_detach): Don't check for NULL.
9195
9196 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9197
9198         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
9199          in case of call that did not complete.
9200
9201 2019-01-02  Andrey Utkin  <autkin@undo.io>
9202
9203         * symfile.c (find_separate_debug_file): Fix search of debug files for
9204         remote debuggee.
9205
9206 2019-01-02  Tom Tromey  <tom@tromey.com>
9207
9208         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
9209         indentation.
9210         * python/py-frame.c (frapy_older): Remove cast.
9211         (frapy_newer): Likewise.
9212         * python/py-breakpoint.c (local_setattro): Remove cast.
9213         * python/py-arch.c (archpy_name): Remove local variable.
9214         * python/py-type.c (gdbpy_lookup_type): Remove cast.
9215
9216 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
9217
9218         * unittests/basic_string_view/element_access/char/empty.cc:
9219         Fix year range in copyright header.
9220
9221 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9222
9223         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
9224         Delete.
9225         <operator==>: Update with for removed field.
9226         <hash>: Likewise.
9227         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
9228         <isa_features>: ...this.
9229         <abi_features>: New field.
9230         (riscv_isa_flen): Update comment.
9231         (riscv_abi_xlen): New declaration.
9232         (riscv_abi_flen): New declaration.
9233         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
9234         isa_features.
9235         (riscv_abi_xlen): New function.
9236         (riscv_isa_flen): Update to get answer from isa_features.
9237         (riscv_abi_flen): New function.
9238         (riscv_has_fp_abi): Update to get answer from abi_features.
9239         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
9240         xlen and flen.
9241         (riscv_call_info) <xlen, flen>: Update comment.
9242         (riscv_call_arg_struct): Remove invalid assertions
9243         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
9244         is removed.
9245         (riscv_gdbarch_init): Gather isa features and abi features
9246         separately, ensure both match on the gdbarch when reusing an old
9247         gdbarch.  Relax an error check to allow 32-bit abi float to run on
9248         a target with 64-bit float hardware.
9249
9250 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9251
9252         * source.c (search_command_helper): Stop reverse search
9253         when line 1 has been searched.
9254
9255 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9256
9257         * record-full.c (record_full_base_target::close): Rewrite
9258         record_full_core_buf_list free logic.
9259
9260 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9261
9262         * break-catch-syscall.c (print_one_catch_syscall): xfree
9263         the last text.
9264
9265 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9266
9267         * top.c (print_gdb_version): Update Copyright year in version
9268         message.
9269
9270 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9271
9272         Update copyright year range in all GDB files.
9273
9274 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
9275
9276         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
9277
9278 For older changes see ChangeLog-2018.
9279 \f
9280 Local Variables:
9281 mode: change-log
9282 left-margin: 8
9283 fill-column: 74
9284 version-control: never
9285 coding: utf-8
9286 End:
9287