Move more allocations to psymtab obstack
[external/binutils.git] / gdb / ChangeLog
1 2019-01-10  Tom Tromey  <tom@tromey.com>
2
3         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
4         PSYMBOL_SET_LANGUAGE.
5         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
6
7 2019-01-10  Tom Tromey  <tom@tromey.com>
8
9         * psymtab.h (psymtab_storage::obstack): New method.
10         <m_obstack>: Rename from obstack; now private.
11         * psymtab.c (psymtab_storage): Update.
12         * dwarf2read.c (create_addrmap_from_index)
13         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
14         Update.
15
16 2019-01-10  Tom Tromey  <tom@tromey.com>
17
18         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
19         * objfiles.h (objfile::reset_psymtabs): New method.
20
21 2019-01-10  Tom Tromey  <tom@tromey.com>
22
23         * symmisc.c (print_symbol_bcache_statistics): Update.
24         (print_objfile_statistics): Update.
25         * symfile.c (reread_symbols): Update.
26         * psymtab.h (class psymtab_storage): New.
27         * psymtab.c (psymtab_storage): New constructor.
28         (~psymtab_storage): New destructor.
29         (require_partial_symbols): Update.
30         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
31         (find_pc_sect_psymtab, find_pc_sect_psymbol)
32         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
33         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
34         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
35         (start_psymtab_common, end_psymtab_common)
36         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
37         (allocate_psymtab): Update.
38         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
39         Update.
40         (dump_psymtab_addrmap, maintenance_print_psymbols)
41         (maintenance_check_psymtabs): Update.
42         (class objfile_psymtabs): Move to objfiles.h.
43         * psympriv.h (discard_psymtab): Now inline.
44         (psymtab_discarder::psymtab_discarder): Update.
45         (psymtab_discarder::~psymtab_discarder): Update.
46         (ALL_OBJFILE_PSYMTABS): Rewrite.
47         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
48         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
49         Remove fields.
50         <partial_symtabs>: New field.
51         (class objfile_psymtabs): Move from psymtab.h.  Update.
52         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
53         psymbol_cache.
54         (objfile::~objfile): Don't destroy psymbol_cache.
55         * mdebugread.c (parse_partial_symbols): Update.
56         * dwarf2read.c (create_addrmap_from_index)
57         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
58         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
59         (add_partial_subprogram, dwarf2_ranges_read): Update.
60         * dwarf-index-write.c (write_address_map)
61         (write_one_signatured_type, recursively_write_psymbols)
62         (class debug_names, class debug_names, write_psymtabs_to_index):
63         Update.
64
65 2019-01-10  Tom Tromey  <tom@tromey.com>
66
67         * symtab.h (SYMBOL_SET_NAMES): Update.
68         (symbol_set_names): Update.
69         (MSYMBOL_SET_NAMES): Update.
70         * symtab.c (symbol_set_names): Change argument to be an
71         objfile_per_bfd_storage.
72         * psymtab.c (add_psymbol_to_bcache): Update.
73         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
74
75 2019-01-10  Tom Tromey  <tom@tromey.com>
76
77         * symtab.c (create_demangled_names_hash): Change argument to be an
78         objfile_per_bfd_storage.
79         (symbol_set_names): Update.
80
81 2019-01-10  Tom Tromey  <tom@tromey.com>
82
83         * xcoffread.c (xcoff_initial_scan): Unconditionally call
84         init_psymbol_list.
85         * psymtab.c (init_psymbol_list): Do nothing if already called.
86         * psympriv.h (init_psymbol_list): Add comment.
87         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
88         init_psymbol_list.
89         * dbxread.c (dbx_symfile_read): Unconditionally call
90         init_psymbol_list.
91
92 2019-01-10  Tom Tromey  <tom@tromey.com>
93
94         * xcoffread.c (scan_xcoff_symtab): Update.
95         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
96         "where".
97         * mdebugread.c (parse_partial_symbols)
98         (handle_psymbol_enumerators): Update.
99         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
100         * dbxread.c (read_dbx_symtab): Update.
101         * psympriv.h (psymbol_placement): New enum.
102         (add_psymbol_to_list): Update.
103
104 2019-01-10  Tom Tromey  <tom@tromey.com>
105
106         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
107         static_psymbols parameters.
108         (scan_xcoff_symtab): Update.
109         * psymtab.c (start_psymtab_common): Remove global_psymbols and
110         static_psymbols parameters.
111         * psympriv.h (start_psymtab_common): Update.
112         * mdebugread.c (parse_partial_symbols): Update.
113         * dwarf2read.c (create_partial_symtab): Update.
114         * dbxread.c (read_dbx_symtab): Update.
115         (start_psymtab): Remove global_psymbols and static_psymbols
116         parameters.
117
118 2019-01-10  Tom Tromey  <tom@tromey.com>
119
120         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
121         * psymtab.c (allocate_psymtab): Add comment.
122         * psympriv.h (allocate_psymtab): Add comment.
123         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
124         initializations.
125         * dbxread.c (dbx_end_psymtab): Remove some initializations.
126
127 2019-01-10  Tom Tromey  <tom@tromey.com>
128
129         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
130         Don't declare.
131         * mipsread.c: Include mdebugread.h.
132         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
133         Declare.
134         * elfread.c: Include mdebugread.h.
135
136 2019-01-09  Tom Tromey  <tom@tromey.com>
137
138         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
139         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
140         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
141         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
142         (psym_lookup_symbol, psym_find_last_source_symtab)
143         (psym_forget_cached_source_info, psym_print_stats)
144         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
145         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
146         (psym_map_matching_symbols, psym_expand_symtabs_matching)
147         (psym_find_compunit_symtab_by_address)
148         (maintenance_print_psymbols, maintenance_info_psymtabs)
149         (maintenance_check_psymtabs): Use ranged for.
150         * psymtab.h (class objfile_psymtabs): New.
151         (require_partial_symbols): Return objfile_psymtabs.
152         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
153
154 2019-01-09  Tom Tromey  <tom@tromey.com>
155
156         * symfile.c (overlay_invalidate_all, find_pc_overlay)
157         (find_pc_mapped_section, list_overlays_command)
158         (map_overlay_command, unmap_overlay_command)
159         (simple_overlay_update): Use all_objfiles.
160         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
161         * printcmd.c (info_symbol_command): Use all_objfiles.
162         * objfiles.h (ALL_OBJSECTIONS): Remove.
163         * maint.c (maintenance_translate_address): Use all_objfiles.
164         * gcore.c (gcore_create_callback): Use all_objfiles.
165         (objfile_find_memory_regions): Likewise.
166
167 2019-01-09  Tom Tromey  <tom@tromey.com>
168
169         * symtab.c (find_line_symtab, info_sources_command)
170         (make_source_files_completion_list): Use objfile_compunits.
171         * source.c (select_source_symtab): Use objfile_compunits.
172         * objfiles.h (struct objfile): Update comment.
173         (ALL_OBJFILES): Remove.
174         (ALL_FILETABS): Remove.
175         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
176         objfile_compunits.
177
178 2019-01-09  Tom Tromey  <tom@tromey.com>
179
180         * symmisc.c (print_objfile_statistics, dump_objfile)
181         (maintenance_print_symbols): Use compunit_filetabs.
182         * source.c (forget_cached_source_info_for_objfile): Use
183         compunit_filetabs.
184         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
185         (ALL_FILETABS): Use compunit_filetabs.
186         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
187         * coffread.c (coff_symtab_read): Use compunit_filetabs.
188
189 2019-01-09  Tom Tromey  <tom@tromey.com>
190
191         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
192         (compunit_filetabs): New.
193         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
194         compunit_filetabs.
195         (info_sources_command, make_source_files_completion_list): Remove
196         declaration.
197         * symmisc.c (print_objfile_statistics, dump_objfile)
198         (maintenance_print_symbols): Remove declaration.
199         (maintenance_info_symtabs): Use compunit_filetabs.
200         (maintenance_info_line_tables): Likewise.
201         * source.c (select_source_symtab): Change local variable name.
202         (forget_cached_source_info_for_objfile): Remove declaration.
203         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
204         * objfiles.c (objfile_relocate1): Remove declaration.
205         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
206         declaration.
207         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
208         * coffread.c (coff_symtab_read): Remove declaration.
209         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
210         compunit_filetabs.
211
212 2019-01-09  Tom Tromey  <tom@tromey.com>
213
214         * symtab.c (lookup_objfile_from_block)
215         (find_pc_sect_compunit_symtab, search_symbols)
216         (default_collect_symbol_completion_matches_break_on): Use
217         objfile_compunits.
218         * objfiles.h (ALL_COMPUNITS): Remove.
219         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
220         * cp-support.c (add_symbol_overload_list_qualified): Use
221         objfile_compunits.
222         * ada-lang.c (ada_collect_symbol_completion_matches)
223         (ada_add_global_exceptions): Use objfile_compunits.
224
225 2019-01-09  Tom Tromey  <tom@tromey.com>
226
227         * source.c (select_source_symtab)
228         (forget_cached_source_info_for_objfile): Remove declaration.
229         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
230         declaration.
231         * maint.c (count_symtabs_and_blocks): Remove declaration.
232         * cp-support.c (add_symbol_overload_list_qualified): Remove
233         declaration.
234         * coffread.c (coff_symtab_read): Remove declaration.
235         * symtab.c (lookup_symbol_in_objfile_symtabs)
236         (basic_lookup_transparent_type_1): Use objfile_compunits.
237         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
238         (info_sources_command, search_symbols)
239         (default_collect_symbol_completion_matches_break_on)
240         (make_source_files_completion_list): Remove declaration.
241         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
242         (ada_collect_symbol_completion_matches)
243         (ada_add_global_exceptions): Remove declaration.
244         * linespec.c (iterate_over_all_matching_symtabs): Use
245         objfile_compunits.
246         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
247         (class objfile_compunits): New.
248         (ALL_COMPUNITS): Use objfile_compunits.
249         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
250         (maintenance_check_symtabs, maintenance_info_line_tables): Use
251         objfile_compunits.
252         * objfiles.c (objfile_relocate1): Use objfile_compunits.
253
254 2019-01-09  Tom Tromey  <tom@tromey.com>
255
256         * symtab.c (search_symbols)
257         (default_collect_symbol_completion_matches_break_on): Use
258         objfile_msymbols.
259         * ada-lang.c (ada_lookup_simple_minsym)
260         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
261         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
262         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
263         objfile_msymbols.
264         * coffread.c (coff_symfile_read): Use objfile_msymbols.
265         * symmisc.c (dump_msymbols): Use objfile_msymbols.
266         * objc-lang.c (find_methods): Use objfile_msymbols.
267         (info_selectors_command, info_classes_command): Likewise.
268         * stabsread.c (scan_file_globals): Use objfile_msymbols.
269         * objfiles.h (class objfile_msymbols): New.
270         (ALL_OBJFILE_MSYMBOLS): Remove.
271         (ALL_MSYMBOLS): Remove.
272
273 2019-01-09  Tom Tromey  <tom@tromey.com>
274
275         * common/next-iterator.h (next_adapter): Add Iterator template
276         parameter.
277         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
278         (class all_objfiles_safe): New.
279         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
280         * objfiles.c (put_objfile_before): Update comment.
281         (add_separate_debug_objfile): Likewise.
282         (free_all_objfiles): Use all_objfiles_safe.
283         (objfile_purge_solibs): Likewise.
284
285 2019-01-09  Tom Tromey  <tom@tromey.com>
286
287         * symtab.c (iterate_over_symtabs, matching_obj_sections)
288         (expand_symtab_containing_pc, lookup_static_symbol)
289         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
290         (find_symbol_at_address, find_line_symtab, find_main_name): Use
291         all_objfiles.
292         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
293         * breakpoint.c (create_overlay_event_breakpoint)
294         (create_longjmp_master_breakpoint)
295         (create_std_terminate_master_breakpoint)
296         (create_exception_master_breakpoint): Use all_objfiles.
297         * linux-thread-db.c (try_thread_db_load_from_pdir)
298         (has_libpthread): Use all_objfiles.
299         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
300         * linespec.c (iterate_over_all_matching_symtabs)
301         (search_minsyms_for_name): Use all_objfiles.
302         * maint.c (maintenance_info_sections): Use all_objfiles.
303         * main.c (captured_main_1): Use all_objfiles.
304         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
305         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
306         * guile/scm-pretty-print.c
307         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
308         * solib-spu.c (append_ocl_sos): Use all_objfiles.
309         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
310         (maintenance_print_msymbols): Use all_objfiles.
311         * source.c (select_source_symtab): Use all_objfiles.
312         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
313         * symfile.c (remove_symbol_file_command)
314         (expand_symtabs_matching, map_symbol_filenames): Use
315         all_objfiles.
316         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
317         all_objfiles.
318         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
319         * objc-lang.c (find_methods): Use all_objfiles.
320         * objfiles.c (have_partial_symbols, have_full_symbols)
321         (have_minimal_symbols, qsort_cmp)
322         (default_iterate_over_objfiles_in_search_order): Use
323         all_objfiles.
324         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
325         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
326         (maintenance_check_psymtabs): Use all_objfiles.
327         (ALL_PSYMTABS): Remove.
328         * compile/compile-object-run.c (do_module_cleanup): Use
329         all_objfiles.
330         * blockframe.c (find_pc_partial_function): Use all_objfiles.
331         * cp-support.c (add_symbol_overload_list_qualified): Use
332         all_objfiles.
333         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
334         Use all_objfiles.
335         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
336         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
337         all_objfiles.
338         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
339         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
340         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
341         Uses all_objfiles.
342         * solib.c (solib_read_symbols): Use all_objfiles
343
344 2019-01-09  Tom Tromey  <tom@tromey.com>
345
346         * probe.c (parse_probes_in_pspace): Use all_objfiles.
347         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
348         all_objfiles.
349         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
350         * symmisc.c (print_symbol_bcache_statistics)
351         (print_objfile_statistics, maintenance_print_objfiles)
352         (maintenance_info_symtabs, maintenance_check_symtabs)
353         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
354         all_objfiles.
355         * source.c (forget_cached_source_info): Use all_objfiles.
356         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
357         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
358         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
359         * objfiles.c (update_section_map): Use all_objfiles.
360         (shared_objfile_contains_address_p): Likewise.
361         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
362         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
363
364 2019-01-09  Tom Tromey  <tom@tromey.com>
365
366         * common/next-iterator.h: New file.
367         * objfiles.h (class all_objfiles): New.
368         (struct objfile_iterator): New.
369
370 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
371
372         * NEWS: Move the description of the changed "frame", "select-frame",
373          and "info frame" commands to the Changed commands section.
374
375 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
376
377         * gdbtypes.c (check_stub_method_group): Remove handling of old
378         mangling schemes.
379         * linespec.c (find_methods): Likewise.
380         * stabsread.c (read_member_functions): Likewise.
381         * valops.c (search_struct_method): Likewise.
382         (value_struct_elt_for_reference): Likewise.
383         * NEWS: Mention this change.
384
385 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
386
387         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
388         print_source_lines.
389         * source.c (print_source_lines_base): Update line number check.
390         (print_source_lines): New function.
391         (source_lines_range::source_lines_range): New function.
392         * source.h (class source_lines_range): New class.
393         (print_source_lines): New declaration.
394
395 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
396
397         * linespec.c (linespec_state_destructor): Free self->canonical_names.
398
399 2019-01-08  Tom Tromey  <tom@tromey.com>
400             Simon Marchi  <simon.marchi@ericsson.com>
401
402         PR gdb/24060
403         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
404         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
405         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
406         * f-exp.y (DOLLAR_VARIABLE): Likewise.
407         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
408         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
409
410 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
411
412         * source.c (select_source_symtab): Move header comment to
413         declaration in source.h.
414         (forget_cached_source_info_for_objfile): Likewise.
415         (forget_cached_source_info): Likewise.
416         (identify_source_line): Likewise.
417         * source.h (identify_source_line): Move declaration from symtab.h
418         and add comment from source.c
419         (print_source_lines): Likewise.
420         (forget_cached_source_info_for_objfile): Likewise.
421         (forget_cached_source_info): Likewise.
422         (select_source_symtab): Likewise.
423         (enum print_source_lines_flag): Move definition from symtab.h.
424         * symtab.h (identify_source_line): Move declaration to source.h.
425         (print_source_lines): Likewise.
426         (forget_cached_source_info_for_objfile): Likewise.
427         (forget_cached_source_info): Likewise.
428         (select_source_symtab): Likewise.
429         (enum print_source_lines_flag): Move definition to source.h.
430         * tui/tui-hooks.c: Add 'source.h' include.
431
432 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
433
434         * source.c (print_source_lines_base): Handle requests to print
435         reverse line number sequences, and guard against empty lines
436         string.
437
438 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
439
440         * source.c (print_source_lines_base): Fix skip of '\r' if next
441         character is '\n'.
442
443 2019-01-06  Tom Tromey  <tom@tromey.com>
444
445         * c-exp.y (struct c_parse_state) <macro_original_text,
446         expansion_obstack>: New member.
447         (macro_original_text, expansion_obstack): Remove globals.
448         (scan_macro_expansion, scanning_macro_expansion)
449         (finished_macro_expansion): Update.
450         (scan_macro_cleanup): Remove.
451         (yylex, c_parse): Update.
452
453 2019-01-06  Tom Tromey  <tom@tromey.com>
454
455         * c-exp.y (struct c_parse_state) <strings>: New member.
456         (operator_stoken): Update.
457
458 2019-01-06  Tom Tromey  <tom@tromey.com>
459
460         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
461         (union type_stack_elt) <typelist_val>: Now a pointer to
462         std::vector.
463         (type_stack_cleanup): Don't declare.
464         (push_typelist): Update.
465         * parse.c (pop_typelist): Return a std::vector.
466         (push_typelist): Take a std::vector.
467         (follow_types): Update.  Do not free args.
468         (type_stack_cleanup): Remove.
469         * c-exp.y (struct c_parse_state): New.
470         (cpstate): New global.
471         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
472         (nonempty_typelist): Update.
473         (func_mod): Create a new vector.
474         (c_parse): Create a c_parse_state.
475         (check_parameter_typelist): Do not delete params.
476         (function_method): Update.  Do not delete type_list.
477
478 2019-01-06  Tom Tromey  <tom@tromey.com>
479
480         PR gdb/28155:
481         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
482         check_typedef.
483         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
484         (print_return_value): Likewise.
485
486 2019-01-05  Tom Tromey  <tom@tromey.com>
487
488         * contrib/cleanup_check.py: Remove.
489         * contrib/gcc-with-excheck: Remove.
490         * contrib/exsummary.py: Remove.
491         * contrib/excheck.py: Remove.
492
493 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
494
495         * thread.c (delete_thread_1): Add gdb_assert that THR is not
496         NULL. Initialize tpprev to NULL instead of assigning it
497         to NULL on the next statement.
498         * windows-nat.c (windows_delete_thread): Remove check for
499         main_thread_id before printing thread exit notifications.
500         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
501         Remove thread ID check against main_thread_id.
502         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
503         windows_delete_thread.
504         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
505
506 2019-01-04  Tom Tromey  <tom@tromey.com>
507
508         * compile/compile.c (_initialize_compile): Use upper case for
509         metasyntactic variables.
510         * symmisc.c (_initialize_symmisc): Use upper case for
511         metasyntactic variables.
512         * psymtab.c (_initialize_psymtab): Use upper case for
513         metasyntactic variables.
514         * demangle.c (demangle_command): Use upper case for metasyntactic
515         variables.
516         (_initialize_demangler): Likewise.
517         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
518         variables.
519
520 2019-01-03  Tom Tromey  <tom@tromey.com>
521
522         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
523
524 2019-01-03  Tom Tromey  <tom@tromey.com>
525
526         * python/py-symtab.c (salpy_str): Update.
527         (struct salpy_sal_object) <symtab>: Now a PyObject.
528         (salpy_dealloc): Update.
529         (del_objfile_sal): Use gdbpy_ref.
530
531 2019-01-03  Tom Tromey  <tom@tromey.com>
532
533         * python/py-type.c (convert_field): Use new_reference.  Return
534         gdbpy_ref.
535         (make_fielditem): Return gdbpy_ref.
536         (typy_fields): Update.
537         (typy_getitem): Update.
538         (field_name): Return gdbpy_ref.  Use new_reference.
539         (typy_iterator_iternext): Update.
540
541 2019-01-03  Tom Tromey  <tom@tromey.com>
542
543         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
544
545 2019-01-03  Tom Tromey  <tom@tromey.com>
546
547         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
548         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
549         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
550         (pspy_set_frame_filters, pspy_set_frame_unwinders)
551         (pspy_set_type_printers): Likewise.
552         * python/py-function.c (fnpy_init): Use gdbpy_ref.
553         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
554         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
555         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
556         (objfpy_set_type_printers): Likewise.
557
558 2019-01-03  Tom Tromey  <tom@tromey.com>
559
560         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
561         (gdbpy_print_stack): Use gdbpy_err_fetch.
562         * python/python-internal.h (class gdbpy_err_fetch): New class.
563         (class gdbpy_enter) <m_error_type, m_error_value,
564         m_error_traceback>: Remove.
565         <m_error>: New member.
566         (gdbpy_exception_to_string): Don't declare.
567         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
568         * python/py-value.c (convert_value_from_python): Use
569         gdbpy_err_fetch.
570         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
571         gdbpy_exception_to_string.
572         (gdbpy_handle_exception): Use gdbpy_err_fetch.
573         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
574         gdbpy_err_fetch.
575
576 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
577
578         * linux-nat.c (delete_lwp_cleanup): Delete.
579         (struct lwp_deleter): New struct.
580         (lwp_info_up): New typedef.
581         (linux_nat_target::follow_fork): Delete cleanup, and make use of
582         lwp_info_up.
583
584 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
585
586         * linux-fork.c (class scoped_switch_fork_info): New class.
587         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
588
589 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
590
591         * valops.c (find_overload_match): Remove use of null_cleanup, and
592         calls to do_cleanups.
593
594 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
595
596         * compile/compile-cplus-types.c
597         (compile_cplus_instance::decl_name): Handle changes to
598         cp_func_name.
599         * cp-support.c (cp_func_name): Update header comment, update
600         return type.
601         * cp-support.h (cp_func_name): Update return type in declaration.
602         * valops.c (find_overload_match): Move temp_func local to top
603         level of function and change its type.  Use temp_func to hold and
604         delete temporary string obtained from cp_func_name.
605
606 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
607
608         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
609         gdb::char_vector, remove cleanup, and update uses of `msg`.
610
611 2019-01-03  Jim Wilson  <jimw@sifive.com>
612
613         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
614
615 2019-01-02  Tom Tromey  <tom@tromey.com>
616
617         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
618         (tdesc_parse_xml): Remove cleanups.
619         * target-descriptions.h (make_cleanup_free_target_description):
620         Don't declare.
621         (target_desc_deleter): New struct.
622         (target_desc_up): New typedef.
623         * target-descriptions.c (target_desc_deleter::operator()): Rename
624         from free_target_description.
625         (make_cleanup_free_target_description): Remove.
626
627 2019-01-02  Tom Tromey  <tom@tromey.com>
628
629         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
630         constructor, destructor.
631         (linespec_parser): Remove typedef.
632         (~linespec_parser): Rename from linespec_parser_delete.
633         (linespec_lex_to_end, linespec_complete_label)
634         (linespec_complete): Update.
635         (decode_line_full): Remove cleanups.
636         (decode_line_1): Update.
637
638 2019-01-02  Tom Tromey  <tom@tromey.com>
639
640         * python/python-internal.h (inferior_to_inferior_object): Change
641         return type.
642         * python/py-exitedevent.c (create_exited_event_object): Update.
643         * python/py-inferior.c (inferior_to_inferior_object): Return
644         gdbpy_ref.
645         (python_new_inferior, python_inferior_deleted)
646         (thread_to_thread_object, delete_thread_object)
647         (build_inferior_list, gdbpy_selected_inferior): Update.
648         * python/py-infthread.c (create_thread_object): Update.  Also fail
649         if inferior_to_inferior_object fails.
650
651 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
652
653         * inferior.h (class inferior) <displaced_step_state>: New field.
654         * infrun.h (struct displaced_step_state): Move here from
655         infrun.c.  Initialize fields, add constructor.
656         <inf>: Remove field.
657         <reset>: New method.
658         * infrun.c (struct displaced_step_inferior_state): Move to
659         infrun.h.
660         (displaced_step_inferior_states): Remove.
661         (get_displaced_stepping_state): Adust.
662         (displaced_step_in_progress_any_inferior): Adjust.
663         (displaced_step_in_progress_thread): Adjust.
664         (displaced_step_in_progress): Adjust.
665         (add_displaced_stepping_state): Remove.
666         (get_displaced_step_closure_by_addr): Adjust.
667         (remove_displaced_stepping_state): Remove.
668         (infrun_inferior_exit): Call displaced_step_state.reset.
669         (use_displaced_stepping): Don't check for NULL.
670         (displaced_step_prepare_throw): Call
671         get_displaced_stepping_state.
672         (displaced_step_fixup): Don't check for NULL.
673         (prepare_for_detach): Don't check for NULL.
674
675 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
676
677         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
678          in case of call that did not complete.
679
680 2019-01-02  Andrey Utkin  <autkin@undo.io>
681
682         * symfile.c (find_separate_debug_file): Fix search of debug files for
683         remote debuggee.
684
685 2019-01-02  Tom Tromey  <tom@tromey.com>
686
687         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
688         indentation.
689         * python/py-frame.c (frapy_older): Remove cast.
690         (frapy_newer): Likewise.
691         * python/py-breakpoint.c (local_setattro): Remove cast.
692         * python/py-arch.c (archpy_name): Remove local variable.
693         * python/py-type.c (gdbpy_lookup_type): Remove cast.
694
695 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
696
697         * unittests/basic_string_view/element_access/char/empty.cc:
698         Fix year range in copyright header.
699
700 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
701
702         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
703         Delete.
704         <operator==>: Update with for removed field.
705         <hash>: Likewise.
706         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
707         <isa_features>: ...this.
708         <abi_features>: New field.
709         (riscv_isa_flen): Update comment.
710         (riscv_abi_xlen): New declaration.
711         (riscv_abi_flen): New declaration.
712         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
713         isa_features.
714         (riscv_abi_xlen): New function.
715         (riscv_isa_flen): Update to get answer from isa_features.
716         (riscv_abi_flen): New function.
717         (riscv_has_fp_abi): Update to get answer from abi_features.
718         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
719         xlen and flen.
720         (riscv_call_info) <xlen, flen>: Update comment.
721         (riscv_call_arg_struct): Remove invalid assertions
722         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
723         is removed.
724         (riscv_gdbarch_init): Gather isa features and abi features
725         separately, ensure both match on the gdbarch when reusing an old
726         gdbarch.  Relax an error check to allow 32-bit abi float to run on
727         a target with 64-bit float hardware.
728
729 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
730
731         * source.c (search_command_helper): Stop reverse search
732         when line 1 has been searched.
733
734 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
735
736         * record-full.c (record_full_base_target::close): Rewrite
737         record_full_core_buf_list free logic.
738
739 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
740
741         * break-catch-syscall.c (print_one_catch_syscall): xfree
742         the last text.
743
744 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
745
746         * top.c (print_gdb_version): Update Copyright year in version
747         message.
748
749 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
750
751         Update copyright year range in all GDB files.
752
753 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
754
755         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
756
757 For older changes see ChangeLog-2018.
758 \f
759 Local Variables:
760 mode: change-log
761 left-margin: 8
762 fill-column: 74
763 version-control: never
764 coding: utf-8
765 End:
766