Make first and last lines of 'command help documentation' consistent.
[external/binutils.git] / gdb / ChangeLog
1 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2
3         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
4         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
5         the full first line, except when FOR_VALUE_PREFIX.  In this case,
6         the trailing '.' is not output, and the first character is uppercased.
7         (print_help_for_command): Update call to print_doc_line.
8         (print_doc_of_command): Likewise.
9         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
10         * cli/cli-option.c (append_indented_doc): Do not append newline.
11         (build_help_option): Append newline after first appended_indented_doc
12         only if a second call is done.
13         (build_help): Append 2 new lines before each option, except the first
14         one.
15         * compile/compile.c (_initialize_compile): Add new lines after
16         %OPTIONS%, when not at the end of the help.
17         Change help doc or code
18         producing the help doc to respect the invariants.
19         * maint-test-options.c (_initialize_maint_test_options): Likewise.
20         Also removed the new line after 'Options:', as all other commands
21         do not put an empty line between 'Options:' and the first option.
22         * printcmd.c (_initialize_printcmd): Likewise.
23         * stack.c (_initialize_stack): Likewise.
24         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
25         incorrectly telling COMMAND is optional.
26         * ada-lang.c (_initialize_ada_language): Change help doc or code
27         producing the help doc to respect the invariants.
28         * ada-tasks.c (_initialize_ada_tasks): Likewise.
29         * breakpoint.c (_initialize_breakpoint): Likewise.
30         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
31         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
32         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
33         * cli/cli-style.c (cli_style_option::add_setshow_commands,
34         _initialize_cli_style): Likewise.
35         * corelow.c (core_target_info): Likewise.
36         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
37         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
38         * filesystem.c (_initialize_filesystem): Likewise.
39         * frame.c (_initialize_frame): Likewise.
40         * gnu-nat.c (add_task_commands): Likewise.
41         * infcall.c (_initialize_infcall): Likewise.
42         * infcmd.c (_initialize_infcmd): Likewise.
43         * interps.c (_initialize_interpreter): Likewise.
44         * language.c (_initialize_language): Likewise.
45         * linux-fork.c (_initialize_linux_fork): Likewise.
46         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
47         * maint.c (_initialize_maint_cmds): Likewise.
48         * memattr.c (_initialize_mem): Likewise.
49         * printcmd.c (_initialize_printcmd): Likewise.
50         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
51         _RegEx): Likewise.
52         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
53         * record-btrace.c (_initialize_record_btrace): Likewise.
54         * record-full.c (_initialize_record_full): Likewise.
55         * record.c (_initialize_record): Likewise.
56         * regcache-dump.c (_initialize_regcache_dump): Likewise.
57         * regcache.c (_initialize_regcache): Likewise.
58         * remote.c (add_packet_config_cmd, init_remote_threadtests,
59         _initialize_remote): Likewise.
60         * ser-tcp.c (_initialize_ser_tcp): Likewise.
61         * serial.c (_initialize_serial): Likewise.
62         * skip.c (_initialize_step_skip): Likewise.
63         * source.c (_initialize_source): Likewise.
64         * stack.c (_initialize_stack): Likewise.
65         * symfile.c (_initialize_symfile): Likewise.
66         * symtab.c (_initialize_symtab): Likewise.
67         * target-descriptions.c (_initialize_target_descriptions): Likewise.
68         * top.c (init_main): Likewise.
69         * tracefile-tfile.c (tfile_target_info): Likewise.
70         * tracepoint.c (_initialize_tracepoint): Likewise.
71         * tui/tui-win.c (_initialize_tui_win): Likewise.
72         * utils.c (add_internal_problem_command): Likewise.
73         * valprint.c (value_print_option_defs): Likewise.
74
75 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
76
77         PR build/24886
78         * configure.ac: Drop enable-libmcheck support.
79         * configure, config.in: Rebuild.
80         * libmcheck.m4: Remove.
81         * acinclude.m4: Don't include it.
82         * Makefile.in: Don't distribute it.
83         * top.c (print_gdb_configuration): Don't mention it.
84
85 2019-08-06  Tom Tromey  <tom@tromey.com>
86
87         * utils.c (set_output_style): Sometimes pass stream to
88         emit_style_escape.
89         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
90         * record-btrace.c (btrace_insn_history): Update.
91         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
92         method.
93         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
94         Update initializers.
95         <m_uiout>: New field.
96         <m_di>: Move lower.
97         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
98         Remove "uiout" parameter.
99         (dump_insns): Update.
100         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
101         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
102
103 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
104
105         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
106         (error_in_psymtab_expansion): Likewise.
107         (lookup_symbol_via_quick_fns): Likewise.
108         (basic_lookup_transparent_type_quick): Likewise.
109         (basic_lookup_transparent_type_1): Likewise.
110
111 2019-08-06  Tom Tromey  <tromey@adacore.com>
112
113         * source.c (last_source_error): Now bool.
114         (print_source_lines_base): Make "noprint" bool.  Only open
115         source file when last_source_visited changes.
116
117 2019-08-06  Tom Tromey  <tromey@adacore.com>
118
119         * annotate.c (annotate_source_line): Use g_source_cache.
120         * source-cache.c (source_cache::get_plain_source_lines): Change
121         parameters.  Populate m_offset_cache.
122         (source_cache::ensure): New method.
123         (source_cache::get_line_charpos): New method.
124         (extract_lines): Move lower.  Change parameters.
125         (source_cache::get_source_lines): Move lower.
126         * source-cache.h (class source_cache): Update comment.
127         <get_line_charpos>: New method.
128         <get_source_lines>: Update comment.
129         <clear>: Clear m_offset_cache.
130         <get_plain_source_lines>: Change parameters.
131         <ensure>: New method
132         <m_offset_cache>: New member.
133         * source.c (forget_cached_source_info_for_objfile): Update.
134         (info_source_command): Use g_source_cache.
135         (find_source_lines, open_source_file_with_line_charpos): Remove.
136         (print_source_lines_base, search_command_helper): Use g_source_cache.
137         * source.h (open_source_file_with_line_charpos): Don't declare.
138         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
139         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
140         Use g_source_cache.
141
142 2019-08-06  Tom Tromey  <tromey@adacore.com>
143
144         * source-cache.c (source_cache::get_plain_source_lines):
145         Remove "first_line" and "last_line" parameters.
146         (source_cache::get_source_lines): Cache plain text.
147         * source-cache.h (class source_cache)
148         <get_plain_source_lines>: Update.
149
150 2019-08-06  Tom Tromey  <tromey@adacore.com>
151
152         * source-cache.c (extract_lines): No longer a method.
153         Changed type of parameter.  Include final newline.
154         (selftests::extract_lines_test): New function.
155         (_initialize_source_cache): Likewise.
156         * source-cache.h (class source_cache)
157         <extract_lines>: Don't declare.
158
159 2019-08-06  Tom Tromey  <tromey@adacore.com>
160
161         * breakpoint.c (init_breakpoint_sal): Update.
162         (breakpoint): Update.
163         * breakpoint.h (struct breakpoint) <filter>: Now a
164         unique_xmalloc_ptr.
165
166 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
167
168         * NEWS: Mention dictionary access on blocks.
169         * python/py-block.c (blpy_getitem): New function.
170         (block_object_as_mapping): New struct.
171         (block_object_type): Use new struct for tp_as_mapping field.
172
173 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
174
175         * objfiles.h (objfile): Add a comment describing partial symbols.
176
177 2019-08-05  Tom Tromey  <tromey@adacore.com>
178
179         * compile/compile.c (_initialize_compile): Use _(), not N_().
180         * thread.c (_initialize_thread): Use _(), not N_().
181         * stack.c (_initialize_stack): Use _(), not N_().
182         * printcmd.c (_initialize_printcmd): Use _(), not N_().
183
184 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
185
186         * dwarf2read.c (struct dw2_symtab_iterator):
187         <want_specific_block>: Remove.
188         <block_index>: Change type to gdb::optional.
189         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
190         change type of BLOCK_INDEX parameter to gdb::optional.
191         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
192         (dw2_lookup_symbol): Don't pass argument for
193         WANT_SPECIFIC_BLOCK.
194         (dw2_expand_symtabs_for_function): Don't pass argument for
195         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
196         (class dw2_debug_names_iterator)
197         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
198         parameter, change BLOCK_INDEX type to gdb::optional.
199         <m_want_specific_block>: Remove.
200         <m_block_index>: Change type to gdb::optional.
201         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
202         gdb::optional.  Re-write in function of gdb::optional.
203         (dw2_debug_names_lookup_symbol): Don't pass argument for
204         WANT_SPECIFIC_BLOCK.
205         (dw2_debug_names_expand_symtabs_for_function): Don't pass
206         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
207         BLOCK_INDEX.
208
209 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
210
211         * NEWS: Mention changes to "info sources" command.
212
213 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
214
215         * symtab.c (filename_partial_match_opts): New struct type.
216         (struct output_source_filename_data): New members
217         regexp, c_regexp, partial_match.
218         (output_source_filename): Use new members to decide to print file.
219         (info_sources_option_defs): New variable.
220         (make_info_sources_options_def_group, print_info_sources_header,
221         info_sources_command_completer):
222         New functions.
223         (info_sources_command): Read new optional arguments.
224         (_initialize_symtab): Update info sources help.
225
226 2019-08-02  Alexandre Oliva <oliva@adacore.com>
227
228         * ada-lang.c (exception_support_info_v0): Renamed from...
229         (default_exception_support_info): ... this.  Create new
230         definition for v1.
231         (ada_has_this_exception_support): Look up catch_handlers_sym.
232         (ada_exception_support_info_sniffer): Try v0 after default.
233
234 2019-08-01  Tom Tromey  <tromey@adacore.com>
235
236         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
237         gdbarch.h.
238
239 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
240
241         * s12z-tdep.c: Fix include path for s12z-opc.h.
242
243 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
244
245         * NEWS: Require GNU make 3.82.
246
247 2019-07-16  Tom Tromey  <tom@tromey.com>
248
249         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
250         declare.
251
252 2019-07-30  Tom Tromey  <tromey@adacore.com>
253
254         * block.c (contained_in): Remove BLOCK_FUNCTION check.
255
256 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
257
258         * printcmd.c (print_address_symbolic): Print negative offsets.
259         (build_address_symbolic): Force signed arithmetic when computing
260         offset.
261
262 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
263
264         PR/24474: Add a function to lookup static variables.
265         * NEWS: Mention this new function.
266         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
267         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
268         * python/python.c (python_GdbMethods): Add new function.
269
270 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
271
272         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
273         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
274         (objfpy_lookup_static_symbol): New function.
275         (objfile_object_methods): Add new functions.
276
277 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
278
279         * NEWS: Mention 'set|show print frame-info'.  Mention new
280         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
281         backtrace argument.  Mention that python frame filtering code
282         is now consistent with what 'backtrace' command prints.
283
284 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
285
286         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
287         comments.
288         (print_frame_info_auto, print_frame_info_source_line,
289         print_frame_info_location, print_frame_info_source_and_location,
290         print_frame_info_location_and_address, print_frame_info_short_location):
291         New declarations.
292         (struct frame_print_options): New member print_frame_info.
293         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
294         * stack.h (get_user_print_what_frame_info): New declaration.
295         (frame_show_address): New declaration.
296         * stack.c (print_frame_arguments_choices): New value 'presence'.
297         (print_frame_info_auto, print_frame_info_source_line,
298         print_frame_info_location, print_frame_info_source_and_location,
299         print_frame_info_location_and_address, print_frame_info_short_location,
300         print_frame_info_choices, print_frame_info_print_what): New definitions.
301         (print_frame_args): Only print dots for args if print frame-arguments
302         is 'presence'.
303         (frame_print_option_defs): New element for "frame-info".
304         (get_user_print_what_frame_info): New function.
305         (frame_show_address): Make non static.  Move comment to stack.h.
306         (print_frame_info_to_print_what): New function.
307         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
308         to decide what to print.
309         (backtrace_command_1): Handle the new print_frame_arguments_presence
310         value.
311         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
312         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
313         (py_print_frame): In non-mi mode, use LOCATION as default for
314         print_what, similarly to frame information printed directly by
315         backtrace command. Handle frame-info user option in non MI mode.
316
317 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
318
319         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
320         Add case for debugging 32-bit target on 64-bit host.  Revise
321         comment.
322
323 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
324
325         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
326         instead of find_function_entry_range_from_pc.
327
328 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
329
330         * stack.c (find_frame_funname): Remove code which preferred
331         minsym over symtab sym in "certain pathological cases".
332
333         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
334         parameter.  Change type of "do_demangle" to bool.
335         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
336         Pass suitable "prefer_sym_over_minsym" flag to
337         build_address_symbolic().  Don't output "+" for negative offsets.
338         * printcmd.c (print_address_symbolic): Update invocation of
339         build_address_symbolic to include a "prefer_sym_over_minsym"
340         flag.
341         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
342         Restrict cases in which use of minimal symbol is preferred to that
343         of a found symbol.  Update comments.
344
345         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
346         for entry pc when entry pc is out of range for that FDE.
347
348 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
349
350         PR gdb/24839:
351         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
352         type.
353
354 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
355
356         * python/py-objfile.c (add_separate_debug_file): Fix comment about
357         this function's Python signature.
358
359
360 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
361
362         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
363         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
364         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
365         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
366         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
367
368
369 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
370
371         * h8300-tdep.c (h8300_register_name_common): New.
372         h8300_register_name): Use h8300_register_name_common.
373         (h8300s_register_name): Likewise.
374         (h8300sx_register_name): Likewise.
375         (h8300h_register_nam): New.
376         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
377
378
379 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
380
381         * arm-tdep.c (arm_skip_cmse_entry): New function.
382         (arm_is_sgstubs_section): New function.
383         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
384
385 2019-07-22  Tom Tromey  <tom@tromey.com>
386
387         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
388         Don't self-assign.
389
390 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
391
392         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
393         type_print.
394
395 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
396
397         * symtab.c (search_symbols): Adjust msymbol matching type arrays
398         so that GDB doesn't match any msymbols when searching in the
399         TYPES_DOMAIN.
400         (print_symbol_info): Print using typedef_print or type_print based
401         on the type of the symbol.  Add updated FIXME comment moved from...
402         (_initialize_symtab): ... move and update FIXME comment to above.
403
404 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
405
406         * NEWS: Mention adding -q option to "info types".
407         * symtab.c (struct info_types_options): New struct.
408         (info_types_options_defs): New variable.
409         (make_info_types_options_def_group): New function.
410         (info_types_command): Use gdb::option framework to parse options.
411         (info_types_command_completer): New function.
412         (_initialize_symtab): Extend the help text on "info types" and
413         register command completer.
414
415 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
416
417         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
418         (lookup_symbol_in_objfile): Change int to block_enum and add a
419         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
420
421 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
422
423         * MAINTAINERS (Write After Approval): Add self.
424
425 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
426
427         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
428         instruction to the dummy code region.
429
430 2019-07-19  Tom Tromey  <tromey@adacore.com>
431
432         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
433         (ARGSUSED, PARAMS, __func__): Remove rules.
434
435 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
436
437         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
438         * features/arm/arm-with-iwmmxt.c: Remove.
439         * features/arm/arm-with-iwmmxt.xml: Remove.
440         * features/arm/arm-with-m-fpa-layout.c: Remove.
441         * features/arm/arm-with-m-fpa-layout.xml: Remove.
442         * features/arm/arm-with-m-vfp-d16.c: Remove.
443         * features/arm/arm-with-m-vfp-d16.xml: Remove.
444         * features/arm/arm-with-m.c: Remove.
445         * features/arm/arm-with-m.xml: Remove.
446         * features/arm/arm-with-neon.c: Remove.
447         * features/arm/arm-with-neon.xml: Remove.
448         * features/arm/arm-with-vfpv2.c: Remove.
449         * features/arm/arm-with-vfpv2.xml: Remove.
450         * features/arm/arm-with-vfpv3.c: Remove.
451         * features/arm/arm-with-vfpv3.xml: Remove.
452
453 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
454
455         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
456
457 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
458
459         * arch/aarch32.c (aarch32_create_target_description): Create
460         target descriptions using features.
461         * arch/arm.c (arm_create_target_description)
462         (arm_create_mprofile_target_description): Likewise.
463         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
464
465 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
466
467         * Makefile.in: Add new files.
468         * aarch32-tdep.c: New file.
469         * aarch32-tdep.h: New file.
470         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
471         Call aarch32_read_description.
472         * arch/aarch32.c: New file.
473         * arch/aarch32.h: New file.
474         * arch/arm.c (arm_create_target_description)
475         (arm_create_mprofile_target_description): New function.
476         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
477         (arm_create_target_description)
478         (arm_create_mprofile_target_description): New declaration.
479         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
480         read_description functions.
481         * arm-linux-nat.c (arm_linux_nat_target::read_description):
482         Likewise.
483         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
484         * arm-tdep.c (tdesc_arm_list): New variable.
485         (arm_register_g_packet_guesses): Call create description functions.
486         (arm_read_description) (arm_read_mprofile_description): New
487         function.
488         * arm-tdep.h (arm_read_description)
489         (arm_read_mprofile_description): Add declaration.
490         * configure.tgt: Add new files.
491
492 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
493
494         * top.c (new_ui_command): Open specified terminal just once.
495
496 2019-07-18  Tom Tromey  <tromey@adacore.com>
497
498         * symtab.c (main_name): Constify return type.
499         * symfile.c (set_initial_language): Update.
500         * symtab.h (main_name): Constify return type.
501
502 2019-07-17  Tom Tromey  <tom@tromey.com>
503
504         * tui/tui-winsource.c (tui_update_source_window)
505         (tui_update_source_window_as_is)
506         (tui_update_source_windows_with_line): Remove return.
507         * tui/tui-disasm.c (tui_show_disassem)
508         (tui_show_disassem_and_update_source): Remove return.
509         * tui/tui.c (tui_reset): Remove return.
510         * tui/tui-wingeneral.c
511         (tui_check_and_display_highlight_if_needed): Remove return.
512
513 2019-07-17  Tom Tromey  <tom@tromey.com>
514
515         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
516
517 2019-07-17  Tom Tromey  <tom@tromey.com>
518
519         * tui/tui-winsource.h (struct tui_exec_info_window)
520         (struct tui_source_window_base): Move from tui-data.h.
521         * tui/tui-winsource.c: Move many method definitions from
522         elsewhere.  Remove "structuring" comments.
523         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
524         (tui_source_window_base::refresh_window): Move to
525         tui-winsource.c.
526         * tui/tui-win.c (tui_source_window_base::refresh_all)
527         (tui_source_window_base::update_tab_width)
528         (tui_source_window_base::set_new_height)
529         (tui_source_window_base::do_make_visible_with_new_height): Move to
530         tui-winsource.c.
531         * tui/tui-source.h: Update.
532         * tui/tui-source.c (tui_source_window_base::reset): Move to
533         tui-winsource.c.
534         * tui/tui-disasm.h: Update.
535         * tui/tui-data.h (struct tui_exec_info_window): Move to
536         tui-winsource.h.
537         (struct tui_source_window_base): Likewise.
538         * tui/tui-data.c (tui_source_window_base::clear_detail)
539         (tui_source_window_base, ~tui_source_window_base): Move to
540         tui-winsource.c.
541
542 2019-07-17  Tom Tromey  <tom@tromey.com>
543
544         * tui/tui-win.c (tui_resize_all)
545         (tui_source_window_base::update_tab_width)
546         (tui_adjust_win_heights): Update.
547         (tui_win_info::make_invisible_and_set_new_height): Rename from
548         make_invisible_and_set_new_height.
549         * tui/tui-data.h (struct tui_win_info)
550         <make_invisible_and_set_new_height>: New method.
551
552 2019-07-17  Tom Tromey  <tom@tromey.com>
553
554         * tui/tui.c: Update.
555         * tui/tui-source.h (struct tui_source_window): Move from
556         tui-data.h.
557         * tui/tui-layout.c: Update.
558         * tui/tui-disasm.c: Update.
559         * tui/tui-data.h (struct tui_source_window): Move to
560         tui-source.h.
561
562 2019-07-17  Tom Tromey  <tom@tromey.com>
563
564         * tui/tui-disasm.h (struct tui_disasm_window): Move from
565         tui-data.h.
566         * tui/tui-data.h (struct tui_disasm_window): Move to
567         tui-disasm.h.
568
569 2019-07-17  Tom Tromey  <tom@tromey.com>
570
571         * tui/tui-regs.h (struct tui_data_item_window): Move from
572         tui-data.h.
573         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
574         * tui/tui-data.h (struct tui_data_item_window): Move to
575         tui-regs.h.
576         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
577
578 2019-07-17  Tom Tromey  <tom@tromey.com>
579
580         * tui/tui.c: Update.
581         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
582         (tui_cmd_window::max_height): Move to tui-command.c.
583         * tui/tui-layout.c: Update.
584         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
585         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
586         tui-command.c.
587         * tui/tui-command.h (struct tui_cmd_window): Move from
588         tui-data.h.
589         * tui/tui-command.c: Remove "structuring" comments.
590         (tui_cmd_window::clear_detail)
591         (tui_cmd_window::do_make_visible_with_new_height)
592         (tui_cmd_window::max_height): Move from elsewhere.
593
594 2019-07-17  Tom Tromey  <tom@tromey.com>
595
596         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
597         Now static.
598         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
599         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
600
601 2019-07-17  Tom Tromey  <tom@tromey.com>
602
603         * tui/tui.c: Update.
604         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
605         tui-regs.c.
606         * tui/tui-windata.h: Remove file.
607         * tui/tui-windata.c: Remove file.
608         * tui/tui-win.c (tui_data_window::set_new_height)
609         (tui_data_window::do_make_visible_with_new_height): Move to
610         tui-regs.c.
611         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
612         * tui/tui-regs.c: Remove "structuring" comments.
613         (tui_data_window::first_data_item_displayed)
614         (tui_data_window::delete_data_content_windows)
615         (tui_data_window::erase_data_content)
616         (tui_data_window::display_all_data)
617         (tui_data_window::refresh_all)
618         (tui_data_window::do_scroll_vertical)
619         (tui_data_window::clear_detail, tui_data_window::set_new_height)
620         (tui_data_window::do_make_visible_with_new_height)
621         (tui_data_window::refresh_window): Move from elsewhere.
622         (_initialize_tui_regs): Move to end of file.
623         * tui/tui-layout.c: Update.
624         * tui/tui-hooks.c: Update.
625         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
626         * tui/tui-data.c (tui_data_window::clear_detail): Move to
627         tui-regs.c.
628         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
629
630 2019-07-17  Tom Tromey  <tom@tromey.com>
631
632         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
633         seen.
634
635 2019-07-17  Tom Tromey  <tom@tromey.com>
636
637         * tui/tui-win.c (tui_source_window_base::set_new_height)
638         (tui_source_window_base::do_make_visible_with_new_height): Use
639         m_has_locator field directly.
640         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
641         method.
642         (struct tui_source_window_base) <has_locator>: Likewise.
643
644 2019-07-17  Tom Tromey  <tom@tromey.com>
645
646         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
647         Don't declare.
648         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
649         Remove.
650         * tui/tui-win.c (tui_source_window_base::set_new_height)
651         (tui_source_window_base::set_new_height)
652         (make_invisible_and_set_new_height)
653         (tui_source_window_base::do_make_visible_with_new_height)
654         (tui_source_window_base::do_make_visible_with_new_height):
655         Update.
656         * tui/tui-layout.c (show_source_disasm_command, show_data)
657         (show_source_or_disasm_and_command): Update.
658         * tui/tui-layout.c (show_layout): Update.
659
660 2019-07-17  Tom Tromey  <tom@tromey.com>
661
662         * tui/tui-layout.c (make_data_window): Remove.
663         (show_data): Unify creation and re-initialization cases.
664
665 2019-07-17  Tom Tromey  <tom@tromey.com>
666
667         * tui/tui-layout.c (make_source_window, make_disasm_window):
668         Remove.
669         (show_data): Unify creation and re-initialization cases.
670
671 2019-07-17  Tom Tromey  <tom@tromey.com>
672
673         * tui/tui-layout.c (make_command_window): Remove.
674         (show_source_disasm_command, show_source_or_disasm_and_command):
675         Unify creation and re-initialization cases.
676
677 2019-07-17  Tom Tromey  <tom@tromey.com>
678
679         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
680         creation and re-initialization cases.
681
682 2019-07-17  Tom Tromey  <tom@tromey.com>
683
684         * tui/tui-regs.c (tui_get_register): Return void.
685
686 2019-07-17  Tom Tromey  <tom@tromey.com>
687
688         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
689         Simplify.
690
691 2019-07-17  Tom Tromey  <tom@tromey.com>
692
693         * tui/tui-layout.c (show_source_disasm_command): Simplify window
694         resetting.
695
696 2019-07-17  Tom Tromey  <tom@tromey.com>
697
698         * tui/tui.h (tui_set_layout_by_name): Don't declare.
699         * tui/tui-regs.c (tui_reg_layout): New function.
700         (tui_show_registers, tui_reg_command): Use it.
701         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
702         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
703         parameters.
704         (tui_layout_command): Remove.
705
706 2019-07-17  Tom Tromey  <tom@tromey.com>
707
708         * tui/tui-layout.h (tui/tui-layout): Return void.
709         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
710
711 2019-07-17  Tom Tromey  <tom@tromey.com>
712
713         * tui/tui-layout.c (show_source_disasm_command, show_data):
714         Update.
715         (reset_locator): Remove.
716         (show_source_or_disasm_and_command): Update.
717
718 2019-07-17  Tom Tromey  <tom@tromey.com>
719
720         * tui/tui-source.c (tui_source_window_base::reset): Remove
721         win_type parameter.
722         * tui/tui-layout.c (make_command_window, make_source_window)
723         (make_disasm_window, make_data_window)
724         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
725         (reset_locator, show_source_or_disasm_and_command): Update.
726         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
727         win_type parameter.
728         (struct tui_source_window_base) <reset>: Likewise.
729
730 2019-07-17  Tom Tromey  <tom@tromey.com>
731
732         * tui/tui-layout.c (show_source_disasm_command): Use
733         reset_locator.
734         (reset_locator): New function.
735         (init_and_make_win): Remove.
736         (show_source_or_disasm_and_command): Use reset_locator.
737
738 2019-07-17  Tom Tromey  <tom@tromey.com>
739
740         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
741         condition.
742         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
743         Remove condition.
744         * tui/tui-source.c (tui_source_window_base::reset): New method.
745         * tui/tui-layout.c (make_command_window): Don't call
746         init_and_make_win.
747         (make_source_window, make_disasm_window): Don't call
748         make_source_or_disasm_window.
749         (make_data_window): Don't call init_and_make_win.  Change calling
750         convention.
751         (show_source_disasm_command, show_data): Simplify.
752         (make_source_or_disasm_window): Remove.
753         (show_source_or_disasm_and_command): Simplify.
754         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
755         (struct tui_source_window_base) <reset>: Likewise.
756         <execution_info>: Remove initializer.
757         * tui/tui-data.c (tui_source_window_base): Initialize
758         execution_info.
759
760 2019-07-17  Tom Tromey  <tom@tromey.com>
761
762         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
763         variable.
764
765 2019-07-17  Tom Tromey  <tom@tromey.com>
766
767         * tui/tui.c (tui_rl_other_window): Update.
768         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
769         superclass method first.  Always iterate over regs_content.
770         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
771         method.
772         * tui/tui-win.c (tui_set_focus_command): Update.
773
774 2019-07-17  Tom Tromey  <tom@tromey.com>
775
776         * tui/tui-win.c (tui_set_focus_command): Rename from
777         tui_set_focus.  Call tui_enable.
778         (tui_set_focus_command): Remove.
779
780 2019-07-17  Tom Tromey  <tom@tromey.com>
781
782         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
783         refresh_window.
784         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
785         touchwin.
786         (tui_data_window::refresh_window): Call refresh_window on data
787         items.  Always call superclass refresh_window.
788         (tui_win_info::refresh): Remove.
789         (tui_source_window_base::refresh_window): Update.
790         (tui_refresh_all): Update.
791         * tui/tui-layout.c (show_source_disasm_command): Remove call to
792         refresh_window.
793         (show_source_or_disasm_and_command): Likewise.
794         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
795         (struct tui_source_window_base) <refresh>: Likewise.
796
797 2019-07-17  Tom Tromey  <tom@tromey.com>
798
799         * tui/tui-winsource.c (tui_clear_source_content)
800         (tui_show_source_content): Update.
801         * tui/tui-source.c (tui_source_window::showing_source_p): Check
802         whether content is empty.
803         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
804         Remove.
805
806 2019-07-17  Tom Tromey  <tom@tromey.com>
807
808         * tui/tui-winsource.c (tui_erase_source_content): Clear the
809         window's contents.
810         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
811         * tui/tui-source.c (tui_set_source_content_nil): Remove.
812
813 2019-07-17  Tom Tromey  <tom@tromey.com>
814
815         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
816         (struct tui_data_item_window): Update.
817
818 2019-07-17  Tom Tromey  <tom@tromey.com>
819
820         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
821         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
822         defines.
823
824 2019-07-17  Tom Tromey  <tom@tromey.com>
825
826         * tui/tui-winsource.h (tui_erase_source_content)
827         (tui_clear_source_content): Remove "display_prompt" parameter.
828         * tui/tui-winsource.c (tui_update_source_window_as_is)
829         (tui_update_source_windows_with_addr): Update.
830         (tui_clear_source_content): Remove "display_prompt" parameter.
831         (tui_erase_source_content): Likewise.  Simplify.
832         (tui_show_source_content): Update.
833         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
834         * tui/tui-stack.c (tui_show_frame_info): Update.
835         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
836         Remove defines.
837
838 2019-07-17  Tom Tromey  <tom@tromey.com>
839
840         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
841         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
842         parameter.
843         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
844         parameter.
845
846 2019-07-17  Tom Tromey  <tom@tromey.com>
847
848         * tui/tui-winsource.c (tui_clear_source_content)
849         (tui_show_source_content, tui_show_exec_info_content)
850         (tui_clear_exec_info_content): Update.
851         * tui/tui-stack.c (tui_show_locator_content): Update.
852         (tui_show_frame_info): Update.
853         * tui/tui-source.h (tui_source_window): Don't declare.
854         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
855         from tui_source_is_displayed.
856         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
857         Remove field.
858         (struct tui_source_window_base) <content_in_use>: New field.  Now
859         bool.
860         (struct tui_source_window) <showing_source_p>: New method.
861         (TUI_SRC_WIN): Change cast.
862         * tui/tui-data.c (tui_initialize_static_data): Update.
863
864 2019-07-17  Tom Tromey  <tom@tromey.com>
865
866         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
867         location_matches_p.
868         * tui/tui-source.c (tui_source_window::location_matches_p): New
869         method.
870         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
871         method.
872         * tui/tui-data.h (struct tui_source_window_base)
873         <location_matches_p>: New method.
874         (struct tui_source_window, struct tui_disasm_window)
875         <location_matches_p>: Likewise.
876
877 2019-07-17  Tom Tromey  <tom@tromey.com>
878
879         * tui/tui-win.c (tui_set_win_height_command): Rename from
880         tui_set_win_height.
881         (tui_set_win_height_command): Remove.
882
883 2019-07-17  Tom Tromey  <tom@tromey.com>
884
885         * tui/tui-source.c (tui_source_window): New constructor.  Add
886         observer.
887         (~tui_source_window): New destructor.
888         (tui_source_window::style_changed): New method.
889         * tui/tui-hooks.c (tui_redisplay_source): Remove.
890         (tui_attach_detach_observers): Update.
891         * tui/tui-data.h (struct tui_source_window): Make constructor not
892         inline.  Add destructor.
893         (struct tui_source_window) <style_changed>: New method.
894         <m_observable>: New member.
895
896 2019-07-17  Tom Tromey  <tom@tromey.com>
897
898         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
899         * tui/tui-win.c (tui_resize_all): Fix typo.
900
901 2019-07-17  Tom Tromey  <tom@tromey.com>
902
903         * tui/tui-wingeneral.h (tui_refresh_all): Update.
904         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
905         (tui_refresh_all): Remove "list" parameter.  Use foreach.
906         * tui/tui-win.c (window_name_completer): Use foreach.
907         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
908         (update_tab_width): Likewise.
909         * tui/tui-layout.c (show_layout): Update.
910         * tui/tui-data.h (class tui_window_iterator): New.
911         (struct all_tui_windows): New.
912         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
913
914 2019-07-17  Tom Tromey  <tom@tromey.com>
915
916         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
917         parameter.  Don't reference globals.
918         (tui_reg_command): Update.
919
920 2019-07-17  Tom Tromey  <tom@tromey.com>
921
922         * tui/tui-regs.c (tui_show_registers): Simplify.
923
924 2019-07-17  Tom Tromey  <tom@tromey.com>
925
926         * tui/tui-regs.c (tui_show_registers): Update.
927         (tui_show_register_group): Add win_info parameter.
928
929 2019-07-17  Tom Tromey  <tom@tromey.com>
930
931         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
932         Rename from tui_display_reg_element_at_line.
933         (tui_data_window::display_registers_from_line): Update.
934         * tui/tui-data.h (struct tui_data_window)
935         <display_reg_element_at_line>: New method.
936
937 2019-07-17  Tom Tromey  <tom@tromey.com>
938
939         * tui/tui-regs.h (tui_display_registers_from)
940         (tui_display_registers_from_line): Don't declare.
941         * tui/tui-windata.c (tui_data_window::display_all_data)
942         (tui_data_window::refresh_all)
943         (tui_data_window::do_scroll_vertical): Update.
944         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
945         from tui_display_registers_from.
946         (tui_display_reg_element_at_line): Update.
947         (tui_data_window::display_registers_from_line): Rename from
948         tui_display_registers_from_line.
949         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
950         display_registers_from_line>: New methods.
951
952 2019-07-17  Tom Tromey  <tom@tromey.com>
953
954         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
955         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
956         from tui_erase_data_content.
957         (tui_data_window::display_all_data)
958         (tui_data_window::refresh_all)
959         (tui_data_window::do_scroll_vertical): Update.
960         * tui/tui-regs.c (tui_show_registers): Update.
961         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
962         New method.
963
964 2019-07-17  Tom Tromey  <tom@tromey.com>
965
966         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
967         declare.
968         * tui/tui-windata.c
969         (tui_data_window::delete_data_content_windows): Rename from
970         tui_delete_data_content_windows.
971         (tui_data_window::display_all_data)
972         (tui_data_window::do_scroll_vertical): Update.
973         * tui/tui-data.h (struct tui_data_window)
974         <delete_data_content_windows>: New method.
975
976 2019-07-17  Tom Tromey  <tom@tromey.com>
977
978         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
979         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
980
981 2019-07-17  Tom Tromey  <tom@tromey.com>
982
983         * tui/tui-windata.h (tui_display_all_data): Don't declare.
984         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
985         from tui_display_all_data.
986         * tui/tui-win.c
987         (tui_data_window::do_make_visible_with_new_height): Update.
988         * tui/tui-regs.c (tui_show_registers): Update.
989         * tui/tui-layout.c (tui_set_layout): Update.
990         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
991         method.
992
993 2019-07-17  Tom Tromey  <tom@tromey.com>
994
995         * tui/tui-windata.h (tui_display_data_from): Don't declare.
996         * tui/tui-windata.c (tui_display_data_from): Remove.
997         (tui_data_window::refresh_all): Update.
998
999 2019-07-17  Tom Tromey  <tom@tromey.com>
1000
1001         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1002         * tui/tui-windata.c (tui_display_data_from_line): Remove.
1003         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1004         tui_display_registers_from_line.
1005         * tui/tui-regs.h (tui_display_registers_from_line): Update.
1006         * tui/tui-regs.c (tui_display_registers_from_line): Remove
1007         "force_display" parameter.
1008
1009 2019-07-17  Tom Tromey  <tom@tromey.com>
1010
1011         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1012         declare.
1013         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1014         Rename from tui_first_reg_element_no_inline.
1015         (tui_display_reg_element_at_line)
1016         (tui_display_registers_from_line): Update.
1017         * tui/tui-data.h (struct tui_data_window)
1018         <first_reg_element_no_inline>: New method.
1019
1020 2019-07-17  Tom Tromey  <tom@tromey.com>
1021
1022         * tui/tui-windata.c (tui_display_data_from)
1023         (tui_data_window::do_scroll_vertical): Update.
1024         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1025         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1026         Rename from tui_line_from_reg_element_no.
1027         (tui_display_registers_from_line): Update.
1028         * tui/tui-data.h (struct tui_data_window)
1029         <line_from_reg_element_no>: New method.
1030
1031 2019-07-17  Tom Tromey  <tom@tromey.com>
1032
1033         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1034         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1035         tui_last_regs_line_no.
1036         (tui_display_reg_element_at_line)
1037         (tui_display_registers_from_line): Update.
1038         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1039         method.
1040
1041 2019-07-17  Tom Tromey  <tom@tromey.com>
1042
1043         PR tui/24722:
1044         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1045         (tui_update_breakpoint_info): Add "being_deleted" parameter.
1046         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1047         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1048         (tui_update_breakpoint_info): Likewise.
1049         * tui/tui-hooks.c (tui_event_create_breakpoint)
1050         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1051         Update.
1052
1053 2019-07-17  Tom Tromey  <tom@tromey.com>
1054
1055         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1056
1057 2019-07-17  Tom Tromey  <tom@tromey.com>
1058
1059         * tui/tui-winsource.c (tui_update_source_window_as_is)
1060         (tui_update_source_windows_with_addr): Update.
1061         * tui/tui-source.h (tui_set_source_content)
1062         (tui_show_symtab_source): Add "win_info" parameter.
1063         * tui/tui-source.c (tui_set_source_content): Add "win_info"
1064         parameter.
1065         (tui_show_symtab_source): Likewise.
1066
1067 2019-07-17  Tom Tromey  <tom@tromey.com>
1068
1069         * tui/tui-wingeneral.c
1070         (tui_check_and_display_highlight_if_needed): Check can_highlight.
1071
1072 2019-07-17  Tom Tromey  <tom@tromey.com>
1073
1074         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1075         (struct tui_cmd_window) <can_scroll>: New method.
1076         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1077         method.
1078
1079 2019-07-17  Tom Tromey  <tromey@adacore.com>
1080
1081         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1082         do_field_signed>: Rename.  Change type of "value".
1083         * ui-out.c (ui_out::field_signed): Rename from field_int.
1084         Change type of "value".
1085         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
1086         type of "value".
1087         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1088         do_field_int.  Change type of "value".
1089         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1090         do_field_int.  Change type of "value".
1091         * tracepoint.c (trace_status_mi, tfind_1)
1092         (print_one_static_tracepoint_marker): Update.
1093         * thread.c (print_thread_info_1, print_selected_thread_frame):
1094         Update.
1095         * stack.c (print_frame, print_frame_info): Update.
1096         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1097         Update.
1098         * source.c (print_source_lines_base): Update.
1099         * skip.c (info_skip_command): Update.
1100         * record-btrace.c (btrace_ui_out_decode_error)
1101         (btrace_call_history_src_line): Update.
1102         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1103         Update.
1104         * progspace.c (print_program_space): Update.
1105         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1106         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1107         do_field_int.  Change type of "value".
1108         * mi/mi-out.c (mi_ui_out::do_table_begin)
1109         (mi_ui_out::do_table_header): Update.
1110         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
1111         type of "value".
1112         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1113         (mi_cmd_data_list_changed_registers, output_register)
1114         (mi_cmd_data_read_memory, mi_load_progress)
1115         (mi_cmd_trace_frame_collected): Update.
1116         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1117         Update.
1118         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1119         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1120         (mi_cmd_var_list_children, varobj_update_one): Update.
1121         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1122         (mi_cmd_stack_list_args, list_arg_or_local): Update.
1123         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1124         * inferior.c (print_inferior): Update.
1125         * gdb_bfd.c (print_one_bfd): Update.
1126         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1127         Update.
1128         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1129         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1130         do_field_int.  Change type of "value".
1131         * cli-out.c (cli_ui_out::do_field_signed): Rename from
1132         do_field_int.  Change type of "value".
1133         * breakpoint.c (watchpoint_check, print_breakpoint_location)
1134         (print_one_breakpoint_location, print_it_catch_fork)
1135         (print_one_catch_fork, print_it_catch_vfork)
1136         (print_one_catch_vfork, print_it_catch_solib)
1137         (print_it_catch_exec, print_it_ranged_breakpoint)
1138         (print_mention_watchpoint, print_mention_masked_watchpoint)
1139         (bkpt_print_it, update_static_tracepoint): Update.
1140         * break-catch-throw.c (print_it_exception_catchpoint): Update.
1141         * break-catch-syscall.c (print_it_catch_syscall): Update.
1142         * ada-tasks.c (print_ada_task_info): Update.
1143         * ada-lang.c (print_it_exception, print_mention_exception):
1144         Update.
1145
1146 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1147
1148         PR breakpoints/24541
1149         * gdbarch.c: Regenerate.
1150         * gdbarch.h: Regenerate.
1151         * gdbarch.sh: Adjust return type and parameter types for
1152         'stap_adjust_register'.
1153         (i386_stap_adjust_register): Adjust signature and return new
1154         register name.
1155         * stap-probe.c (stap_parse_register_operand): Adjust use of
1156         'gdbarch_stap_adjust_register'.
1157
1158 2019-07-17  Tom Tromey  <tromey@adacore.com>
1159
1160         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
1161         declare VEC.
1162         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
1163         std::vector.
1164         (struct s390_process_info): Add initializers.
1165         (s390_add_process): Use new.
1166         (s390_linux_nat_target::low_forget_process): Use delete.
1167         (s390_linux_nat_target::low_new_fork)
1168         (s390_linux_nat_target::stopped_by_watchpoint)
1169         (s390_linux_nat_target::low_prepare_to_resume)
1170         (s390_linux_nat_target::insert_watchpoint)
1171         (s390_linux_nat_target::insert_hw_breakpoint)
1172         (s390_linux_nat_target::remove_watchpoint)
1173         (s390_linux_nat_target::remove_hw_breakpoint): Update.
1174
1175 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1176
1177         * aarch64-fbsd-nat.c: Include regcache.h.
1178         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1179         argument.
1180         (aarch64_fbsd_nat_target::fetch_registers)
1181         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1182         variable.
1183         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1184
1185 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1186
1187         * fbsd-nat.c: Include gdbarch.h.
1188
1189 2019-07-15  Tom Tromey  <tromey@adacore.com>
1190
1191         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1192
1193 2019-07-15  Tom Tromey  <tromey@adacore.com>
1194
1195         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1196         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1197         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1198         * cli-out.c (cli_ui_out::do_field_int): New method.
1199         * ui-out.c (ui_out::field_unsigned): New method.
1200         * symfile.c (generic_load): Use field_unsigned.
1201         (print_transfer_performance): Likewise.
1202         * record-btrace.c (ui_out_field_uint): Remove.
1203         (btrace_call_history_insn_range, btrace_call_history): Use
1204         field_unsigned.
1205         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
1206         field_unsigned.
1207         * ui-out.h (class ui_out) <field_unsigned>: New method.
1208         <do_field_unsigned>: Likewise.
1209
1210 2019-07-15  Tom Tromey  <tromey@adacore.com>
1211
1212         * mi/mi-main.c (list_available_thread_groups): Use field_string.
1213         * mi/mi-interp.c (mi_memory_changed): Use field_string.
1214         * target.c (flash_erase_command): Use field_string.
1215         * infrun.c (print_signal_received_reason): Use field_string.
1216         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
1217         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
1218         field_string.
1219         * ada-tasks.c (print_ada_task_info): Use field_string.
1220
1221 2019-07-15  Tom Tromey  <tromey@adacore.com>
1222
1223         * target.c (flash_erase_command): Use field_core_addr.
1224         * symfile.c (generic_load): Use field_core_addr.
1225         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1226         Use field_core_addr.
1227         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
1228         field_core_addr.
1229
1230 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1231
1232         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1233         value if its desired type is smaller than a CORE_ADDR and signed.
1234
1235 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1236
1237         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1238         of changes to field names, and use new is_reference field to
1239         decide if a property is a reference or not.
1240         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1241         field.
1242         (struct dwarf2_property_baton): Update header comment, rename
1243         'referenced_type' to 'property_type' and update comments.
1244         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1245         default property type, store in property baton, update to take
1246         accound of renamed field.
1247         (read_func_scope): Update call to attr_to_dynamic_prop.
1248         (read_array_type): Likewise.
1249         (dwarf2_per_cu_addr_sized_int_type): New function.
1250         (read_subrange_index_type): Move type finding code to
1251         dwarf2_per_cu_addr_sized_int_type.
1252         (read_subrange_type): Update calls to attr_to_dynamic_prop.
1253         (dwarf2_per_cu_addr_type): New function.
1254         (set_die_type): Update calls to attr_to_dynamic_prop.
1255
1256 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1257
1258         * dwarf2read.c (read_subrange_index_type): New function.
1259         (read_subrange_type): Move code into new function and call it.
1260         * gdbtypes.c (create_range_type): Add some asserts.
1261
1262 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1263
1264         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1265         update return statements.
1266         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1267         declaration, and update comment to match.
1268         * gdbtypes.c (resolve_dynamic_array): Update call to
1269         dwarf2_evaluate_property to match new return type.
1270
1271 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1272
1273         * valarith.c (value_subscripted_rvalue): Change lowerbound
1274         parameter type from int to LONGEST.
1275         * value.h (value_subscripted_rvalue): Likewise in declaration.
1276
1277 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1278
1279         * cli/cli-utils.c (info_print_command_completer): New function.
1280         * cli/cli-utils.h: Add 'completer.h' include, and forward
1281         declaration for 'struct cmd_list_element'.
1282         (info_print_command_completer): Declare.
1283         * stack.c (_initialize_stack): Add completer for 'info locals' and
1284         'info args'.
1285         * symtab.c (_initialize_symtab): Add completer for 'info
1286         variables' and 'info functions'.
1287         * NEWS: Mention completion for additional info commands.
1288
1289 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1290
1291         * cli/cli-utils.c (extract_info_print_args): Delete.
1292         (extract_arg_maybe_quoted): Delete.
1293         (info_print_options_defs): New variable.
1294         (make_info_print_options_def_group): New function.
1295         (extract_info_print_options): Define new function.
1296         * cli/cli-utils.h (extract_info_print_args): Delete.
1297         (struct info_print_options): New structure.
1298         (extract_info_print_options): Declare new function.
1299         * stack.c (info_locals_command): Update to use new
1300         extract_info_print_options, also add a header comment.
1301         (info_args_command): Likewise.
1302         * symtab.c (info_variables_command): Likewise.
1303         (info_functions_command): Likewise.
1304
1305 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1306
1307         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1308         to extract string arguments.
1309         * common/common-utils.c (extract_string_maybe_quoted): New function.
1310         * common/common-utils.h (extract_string_maybe_quoted): Declare.
1311
1312 2019-07-11  Tom Tromey  <tromey@adacore.com>
1313
1314         * main.c (get_init_files): Use GDBINIT, not gdbinit.
1315         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1316         * top.h (gdbinit): Don't declare.
1317         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1318         into...
1319         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
1320         * top.c (gdb_init): Don't call init_cli_cmds.
1321         (gdbinit): Remove.
1322         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1323
1324 2019-07-11  Tom Tromey  <tromey@adacore.com>
1325
1326         * python/py-inferior.c (add_thread_object): Don't use thread_obj
1327         after it has been moved.
1328
1329 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1330
1331         * valops.c (value_must_coerce_to_target): Change return type to
1332         bool.
1333         * value.h (value_must_coerce_to_target): Likewise.
1334
1335 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
1336
1337         * breakpoint.c (is_hardware_watchpoint): Remove
1338         forward-declaration.
1339         (is_masked_watchpoint): Change return type to bool.
1340         (is_tracepoint): Likewise.
1341         (is_breakpoint): Likewise.
1342         (is_hardware_watchpoint): Likewise.
1343         (is_watchpoint): Likewise.
1344         (is_no_memory_software_watchpoint): Likewise.
1345         (is_catchpoint): Likewise.
1346         (breakpoint_1): Make FILTER parameter's return type bool.
1347         is_masked_watchpoint): Change return type to bool.
1348         (save_breakpoints): Make FILTER parameter's return type bool.
1349         * breakpoint.h (is_breakpoint): Change return type to bool.
1350         (is_watchpoint): Likewise.
1351         (is_catchpoint): Likewise.
1352         (is_tracepoint): Likewise.
1353
1354 2019-07-10  Tom Tromey  <tom@tromey.com>
1355
1356         * defs.h: Don't include gdbarch.h.
1357         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1358         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1359         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1360         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1361         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1362         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1363         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1364         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1365         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1366         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1367         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1368         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1369         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1370         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1371         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1372         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1373         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1374         record-btrace.c, record.h, regcache-dump.c, regcache.h,
1375         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1376         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1377         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1378         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1379         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1380         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1381         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1382         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1383         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1384
1385 2019-07-10  Tom Tromey  <tromey@adacore.com>
1386
1387         * ada-lang.h (is_ada_exception_catchpoint): Declare.
1388         * breakpoint.c (init_ada_exception_breakpoint): Register as
1389         bp_catchpoint.
1390         (print_one_breakpoint_location, print_one_breakpoint): Use
1391         is_ada_exception_catchpoint.
1392         * ada-lang.c (class ada_catchpoint_location): Pass
1393         bp_loc_software_breakpoint to bp_location constructor.
1394         (is_ada_exception_catchpoint): New function.
1395
1396 2019-07-10  Tom Tromey  <tromey@adacore.com>
1397
1398         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
1399         VEC.
1400         (struct arm_exidx_entry): New method operator<.
1401         (struct arm_exidx_data) <section_maps>: Change type.
1402         (arm_exidx_data_free): Remove.
1403         (arm_exidx_data_key): Change type.  Move lower.
1404         (arm_exidx_new_objfile): Update.
1405         (arm_compare_exidx_entries): Remove.
1406         (arm_find_exidx_entry, _initialize_arm_tdep)
1407
1408 2019-07-10  Tom Tromey  <tromey@adacore.com>
1409
1410         * solib-spu.c (ocl_program_data_key): Change type.
1411         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1412         Update.
1413
1414 2019-07-10  Tom Tromey  <tromey@adacore.com>
1415
1416         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1417         (struct solib_aix_inferior_data) <library_list>: Change type.
1418         (solib_aix_inferior_data_handle): Change type.
1419         (get_solib_aix_inferior_data): Update.
1420         (solib_aix_free_library_list): Remove.
1421         (library_list_start_library): Update.
1422         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1423         return type.
1424         (solib_aix_get_library_list)
1425         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1426         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1427
1428 2019-07-10  Tom Tromey  <tromey@adacore.com>
1429
1430         * solib-dsbt.c (struct dsbt_info): Add initializers.
1431         (solib_dsbt_pspace_data): Change type.
1432         (dsbt_pspace_data_cleanup): Remove.
1433         (get_dsbt_info, _initialize_dsbt_solib): Update.
1434
1435 2019-07-10  Tom Tromey  <tromey@adacore.com>
1436
1437         * spu-tdep.c (spu_overlay_data): Change type.
1438         (spu_get_overlay_table, spu_overlay_new_objfile)
1439         (_initialize_spu_tdep): Update.
1440
1441 2019-07-10  Tom Tromey  <tromey@adacore.com>
1442
1443         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1444         destructor.
1445         (dbx_objfile_data_key): Change type and declare later.
1446         (DBX_SYMFILE_INFO): Rewrite.
1447         * dbxread.c (dbx_objfile_data_key): Change type.
1448         (dbx_symfile_init): Update.
1449         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1450         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1451         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1452
1453 2019-07-10  Tom Tromey  <tromey@adacore.com>
1454
1455         * jit.c (jit_program_space_key): Change type.  Move lower.
1456         (get_jit_program_space_data): Update.
1457         (jit_program_space_data_cleanup): Remove.
1458         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1459         Update.
1460         (struct jit_program_space_data): Add initializers.
1461
1462 2019-07-10  Tom Tromey  <tromey@adacore.com>
1463
1464         * solib-darwin.c (struct darwin_info): Add initializers.
1465         (solib_darwin_pspace_data): Change type.
1466         (darwin_pspace_data_cleanup): Remove.
1467         (get_darwin_info, _initialize_darwin_solib): Update.
1468
1469 2019-07-10  Tom Tromey  <tromey@adacore.com>
1470
1471         * remote-sim.c (struct sim_inferior_data): Add initializers,
1472         constructor, and destructor.
1473         (sim_inferior_data_key): Change type.  Move lower.
1474         (check_for_duplicate_sim_descriptor): Update.
1475         (get_sim_inferior_data): Use new.  Update.
1476         (~sim_inferior_data_cleanup): Rename from
1477         sim_inferior_data_cleanup.  Simplify.
1478         (gdbsim_close_inferior, simulator_command)
1479         (sim_command_completer, _initialize_remote_sim): Update.
1480         (next_pid, INITIAL_PID): Move earlier.
1481
1482 2019-07-10  Tom Tromey  <tromey@adacore.com>
1483
1484         * python/python-internal.h (create_thread_object): Return
1485         gdbpy_ref.
1486         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1487         * python/py-inferior.c (struct threadlist_entry): Add
1488         constructor.
1489         <thread_obj>: Now a gdbpy_ref.
1490         (thread_to_thread_object): Update.
1491         (add_thread_object): Use new.
1492         (delete_thread_object): Use delete.
1493         (infpy_threads): Update.
1494         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1495         GIL.
1496
1497 2019-07-10  Tom Tromey  <tromey@adacore.com>
1498
1499         * valops.c (value_cast): Specialize error message for Ada.
1500
1501 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1502
1503         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1504
1505 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1506
1507         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1508         bpstat_should_step): Return bool, adjust comments.
1509         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1510         bpstat_should_step): Likewise.
1511
1512 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1513
1514         * features/Makefile: Use feature target descriptions for Arm.
1515         * features/arm/arm-core.c: Generate new file.
1516         * features/arm/arm-fpa.c: Likewise.
1517         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1518         * features/arm/arm-m-profile.c: Likewise.
1519         * features/arm/arm-vfpv2.c: Likewise.
1520         * features/arm/arm-vfpv3.c: Likewise.
1521         * features/arm/xscale-iwmmxt.c: Likewise.
1522         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1523
1524 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1525
1526         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1527         ptrace earlier.
1528
1529 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1530
1531         * features/aarch64-pauth.c: Regenerate.
1532
1533 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1534
1535         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1536         bool.
1537         (bpstat_what): Use false instead of 0.
1538
1539 2019-07-09  Pedro Alves  <palves@redhat.com>
1540
1541         * break-catch-throw.c (is_exception_catchpoint): New.
1542         * breakpoint.c (print_one_breakpoint_location): New parameter
1543         'raw_loc'.  Handle it.  Use
1544         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1545         looking at the breakpoint's type.
1546         (print_one_breakpoint): If handling "maint info breakpoints", also
1547         print locations of exception catchpoints.
1548         * breakpoint.h (is_exception_catchpoint): Declare.
1549
1550 2019-07-09  Pedro Alves  <palves@redhat.com>
1551
1552         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1553         "addr" field.
1554         (allocate_location_exception_catchpoint): New.
1555         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1556         (initialize_throw_catchpoint_ops): Install
1557         allocate_location_exception_catchpoint as allocate_location
1558         method.
1559         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1560         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1561         bp_loc_other.
1562         (breakpoint_address_is_meaningful): Delete.
1563         (bl_address_is_meaningful): New.
1564         (breakpoint_locations_match): Adjust comment.
1565         (bp_location_from_bp_type): New, factored out of...
1566         (bp_location::bp_location(breakpoint *)): ... this.
1567         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1568         factored out of...
1569         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1570         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1571         breakpoint_address_is_meaningful.
1572         (bp_locations_compare): Adjust comment.
1573         (update_global_location_list): Use bl_address_is_meaningful
1574         instead of breakpoint_address_is_meaningful.
1575         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1576         explicit.
1577         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1578         * python/py-breakpoint.c (bppy_get_location): No longer check
1579         whether location is null.
1580
1581 2019-07-09  Pedro Alves  <palves@redhat.com>
1582
1583         PR c++/15468
1584         * breakpoint.c (print_one_breakpoint_location): Remove
1585         single-location assert.
1586
1587 2019-07-09  Tom Tromey  <tom@tromey.com>
1588
1589         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1590         * configure: Rebuild.
1591         * configure.ac: Change common to gdbsupport.
1592         * gdbsupport: Rename from common.
1593         * acinclude.m4: Change common to gdbsupport.
1594         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1595         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1596         gdbsupport.
1597         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1598         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1599         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1600         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1601         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1602         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1603         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1604         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1605         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1606         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1607         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1608         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1609         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1610         coff-pe-read.c, command.h, compile/compile-c-support.c,
1611         compile/compile-c.h, compile/compile-cplus-symbols.c,
1612         compile/compile-cplus-types.c, compile/compile-cplus.h,
1613         compile/compile-loc2c.c, compile/compile.c, completer.c,
1614         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1615         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1616         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1617         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1618         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1619         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1620         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1621         features/aarch64-core.c, features/aarch64-fpu.c,
1622         features/aarch64-pauth.c, features/aarch64-sve.c,
1623         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1624         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1625         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1626         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1627         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1628         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1629         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1630         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1631         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1632         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1633         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1634         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1635         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1636         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1637         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1638         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1639         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1640         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1641         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1642         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1643         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1644         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1645         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1646         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1647         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1648         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1649         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1650         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1651         minsyms.c, mips-linux-tdep.c, namespace.h,
1652         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1653         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1654         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1655         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1656         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1657         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1658         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1659         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1660         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1661         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1662         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1663         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1664         procfs.c, producer.c, progspace.h, psymtab.h,
1665         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1666         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1667         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1668         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1669         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1670         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1671         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1672         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1673         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1674         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1675         target-memory.c, target.c, target.h, target/waitstatus.c,
1676         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1677         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1678         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1679         unittests/array-view-selftests.c,
1680         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1681         unittests/common-utils-selftests.c,
1682         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1683         unittests/format_pieces-selftests.c,
1684         unittests/function-view-selftests.c,
1685         unittests/lookup_name_info-selftests.c,
1686         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1687         unittests/mkdir-recursive-selftests.c,
1688         unittests/observable-selftests.c,
1689         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1690         unittests/parse-connection-spec-selftests.c,
1691         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1692         unittests/scoped_fd-selftests.c,
1693         unittests/scoped_mmap-selftests.c,
1694         unittests/scoped_restore-selftests.c,
1695         unittests/string_view-selftests.c, unittests/style-selftests.c,
1696         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1697         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1698         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1699         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1700         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1701         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1702
1703 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1704
1705         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1706         bool value.
1707         (decode_digits_ordinary): Set explicit_line field in sal.
1708         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1709         symtab_and_line that was set on an explicit line number in
1710         assembler code.  Do always update the recorded symtab and line if
1711         we do skip the prologue.
1712
1713 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1714
1715         * breakpoint.c (set_breakpoint_location_function): Remove
1716         explicit_loc parameter.
1717         (momentary_breakpoint_from_master): Update call to
1718         set_breakpoint_location_function.
1719         (add_location_to_breakpoint): Likewise.
1720
1721 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1722
1723         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1724         required features based on default bfd type when no specific bfd
1725         is present.
1726
1727 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1728
1729         * NEWS: Mention that GDB printf and eval commands can now print
1730         C-style and Ada-style convenience var strings without
1731         calling the inferior.
1732         * printcmd.c (printf_c_string): Locally print GDB internal var
1733         instead of transiting via the inferior.
1734         (printf_wide_c_string): Likewise.
1735
1736 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1737
1738         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1739
1740 2019-07-04  Tom Tromey  <tom@tromey.com>
1741
1742         PR tui/24724:
1743         * tui/tui-winsource.c (tui_clear_source_content): Update.
1744         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1745         (tui_update_breakpoint_info): Update.
1746         (tui_set_exec_info_content): Update.
1747         * tui/tui-source.c (tui_set_source_content_nil): Update.
1748         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1749         has_break.
1750         * tui/tui-data.h (enum tui_bp_flag): New.
1751         (tui_bp_flags): New enum flags type.
1752         (struct tui_source_element) <break_mode>: Change type.  Rename
1753         from has_break.
1754         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1755         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1756         constants.
1757         * tui/tui-winsource.h: Fix comment.
1758
1759 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1760
1761         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1762         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1763         (store_fpregs_to_thread)
1764         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1765         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1766         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1767         (IWMMXT_REGS_SIZE): Add define.
1768         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1769         (fetch_vfp_regs, store_vfp_regs)
1770         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1771         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1772
1773 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1774
1775         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1776         defines.
1777         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1778         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1779         (ARM_INT_REGISTER_SIZE): ...to this.
1780         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1781         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1782         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1783         (arm_linux_collect_gregset, supply_nwfpe_register)
1784         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1785         defines.
1786         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1787         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1788         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1789         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1790         (arm_return_in_memory, arm_store_return_value)
1791         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1792         (arm_record_ld_st_multiple): Likewise.
1793         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1794         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1795
1796 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1797
1798         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1799         AARCH64_DISPLACED_MODIFIED_INSNS.
1800         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1801         (aarch64_displaced_step_copy_insn): Likewise.
1802         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1803         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1804         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1805         ARM_DISPLACED_MODIFIED_INSNS.
1806         * arm-tdep.c (arm_gdbarch_init): Likewise.
1807         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1808         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1809         (struct arm_displaced_step_closure): Use
1810         ARM_DISPLACED_MODIFIED_INSNS.
1811
1812 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1813
1814         * features/Makefile: Remove unused xml files.
1815         * features/aarch64.xml: Remove.
1816         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1817         * features/i386/amd64-avx-avx512.xml: Remove.
1818         * features/i386/amd64-avx-linux.xml: Remove.
1819         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1820         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1821         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1822         * features/i386/amd64-avx-mpx.xml: Remove.
1823         * features/i386/amd64-avx.xml: Remove.
1824         * features/i386/amd64-linux.xml: Remove.
1825         * features/i386/amd64-mpx-linux.xml: Remove.
1826         * features/i386/amd64-mpx.xml: Remove.
1827         * features/i386/amd64.xml: Remove.
1828         * features/i386/i386-avx-avx512-linux.xml: Remove.
1829         * features/i386/i386-avx-avx512.xml: Remove.
1830         * features/i386/i386-avx-linux.xml: Remove.
1831         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1832         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1833         * features/i386/i386-avx-mpx-linux.xml: Remove.
1834         * features/i386/i386-avx-mpx.xml: Remove.
1835         * features/i386/i386-avx.xml: Remove.
1836         * features/i386/i386-linux.xml: Remove.
1837         * features/i386/i386-mmx-linux.xml: Remove.
1838         * features/i386/i386-mmx.xml: Remove.
1839         * features/i386/i386-mpx-linux.xml: Remove.
1840         * features/i386/i386-mpx.xml: Remove.
1841         * features/i386/i386.xml: Remove.
1842         * features/i386/x32-avx-avx512-linux.xml: Remove.
1843         * features/i386/x32-avx-linux.xml: Remove.
1844         * features/i386/x32-linux.xml: Remove.
1845
1846 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1847
1848         * regformats/aarch64.dat: Remove.
1849         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1850         * regformats/i386/amd64-avx-linux.dat: Remove.
1851         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1852         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1853         * regformats/i386/amd64-linux.dat: Remove.
1854         * regformats/i386/amd64-mpx-linux.dat: Remove.
1855         * regformats/i386/amd64.dat: Remove.
1856         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1857         * regformats/i386/i386-avx-linux.dat: Remove.
1858         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1859         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1860         * regformats/i386/i386-linux.dat: Remove.
1861         * regformats/i386/i386-mmx-linux.dat: Remove.
1862         * regformats/i386/i386-mpx-linux.dat: Remove.
1863         * regformats/i386/i386.dat: Remove.
1864         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1865         * regformats/i386/x32-avx-linux.dat: Remove.
1866         * regformats/i386/x32-linux.dat: Remove.
1867
1868 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1869
1870         * aarch64-tdep.c: Remove xml self tests.
1871         * amd64-linux-tdep.c: Likewise.
1872         * amd64-tdep.c: Likewise.
1873         * i386-linux-tdep.c: Likewise.
1874         * i386-tdep.c: Likewise.
1875
1876 2019-07-03  Pedro Alves  <palves@redhat.com>
1877
1878         PR cli/24732
1879         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1880         (pipe_cmd_option_defs): New.
1881         (make_pipe_cmd_options_def_group): New.
1882         (pipe_command): Use gdb::option::process_options.
1883         (pipe_command_completer): New function.
1884         (_initialize_cli_cmds): Install completer for "pipe" command.
1885
1886 2019-07-03  Pedro Alves  <palves@redhat.com>
1887
1888         * cli/cli-option.c (union option_value) <string>: New field.
1889         (struct option_def_and_value): Add ctor, move ctor, dtor and
1890         use DISABLE_COPY_AND_ASSIGN.
1891         (option_def_and_value::clear_value): New.
1892         (parse_option, save_option_value_in_ctx, get_val_type_str)
1893         (add_setshow_cmds_for_options): Handle var_string.
1894         * cli-option.h (union option_def::var_address) <string>: New
1895         field.
1896         (struct string_option_def): New.
1897         * maint-test-options.c (struct test_options_opts): Add default
1898         ctor and use DISABLE_COPY_AND_ASSIGN.
1899         <string_opt>: New field.
1900         (test_options_opts::~test_options_opts): New.
1901         (test_options_opts::dump): Also dump "-string".
1902         (test_options_option_defs): Install "string.
1903
1904 2019-07-03  Pedro Alves  <palves@redhat.com>
1905
1906         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1907         option_value with a null enumeration.
1908         (complete_options): Save the option values in the context.
1909         (save_option_value_in_ctx): New, factored out from ...
1910         (process_options): ... here.
1911         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1912         of the function.
1913         * maint-test-options.c (test_options_opts::dump): New, factored
1914         out from ...
1915         (maintenance_test_options_command_mode): ... here.
1916         (maintenance_test_options_command_completion_result): Delete.
1917         (maintenance_test_options_command_completion_text): Update
1918         comment.
1919         (maintenance_show_test_options_completion_result): Change
1920         prototype.  Just print
1921         maintenance_test_options_command_completion_text.
1922         (save_completion_result): New.
1923         (maintenance_test_options_completer_mode): Pass options context to
1924         complete_options, and then save a dump.
1925         (_initialize_maint_test_options): Use add_cmd to install "maint
1926         show test-options-completion-result".
1927
1928 2019-07-03  Pedro Alves  <palves@redhat.com>
1929
1930         * NEWS (New commands): Mention "with" and "maint with".
1931         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1932         (with_command, with_command_completer): New.
1933         (pipe_command): Adjust to new repeat_previous
1934         interface.
1935         (_initialize_cli_cmds): Install the "with" command and its "w"
1936         alias.
1937         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1938         declarations.
1939         * cli/cli-setshow.c (parse_cli_var_uinteger)
1940         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1941         argument strings for all var_types.
1942         (get_setshow_command_value_string): New, factored out from ...
1943         (do_show_command): ... this.
1944         * cli/cli-setshow.h: Include <string>.
1945         (get_setshow_command_value_string): Declare.
1946         * command.h (repeat_previous): Now returns const char *.  Adjust
1947         comment.
1948         * maint.c: Include "cli/cli-cmds.h".
1949         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1950         (_initialize_maint_cmds): Register the "maintenance with" command.
1951         * top.c (repeat_previous): Move bits from pipe_command here:
1952         Return the saved command line, if any; error out if there's no
1953         command to relaunch.
1954
1955 2019-07-03  Pedro Alves  <palves@redhat.com>
1956
1957         * NEWS (New commands): Mention "maint set/show test-settings"
1958         instead of "maint test-settings".
1959         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1960         (maintenance_test_settings_set_list): Rename to ...
1961         (maintenance_set_test_settings_list): ... this.
1962         (maintenance_test_settings_show_list): Rename to  ...
1963         (maintenance_show_test_settings_list): ... this.
1964         (maintenance_test_settings_cmd): Delete.
1965         (maintenance_test_settings_set_cmd): ...
1966         (maintenance_set_test_settings_cmd): ... this.
1967         (maintenance_test_settings_show_cmd): ...
1968         (maintenance_show_test_settings_cmd): ... this.
1969         (maintenance_test_settings_show_value_cmd):
1970         (maintenance_show_test_settings_value_cmd): ... this.
1971         (_initialize_maint_test_settings): No longer install the "maint
1972         test-settings" prefix command.  Rename "maint test-settings set"
1973         to "maint set test-settings", and "maint test-settings show" to
1974         "maint show test-settings".  Adjust all subcommands.
1975
1976 2019-07-03  Pedro Alves  <palves@redhat.com>
1977
1978         * maint-test-settings.c: Fix file's intro comment.  Replace all
1979         references to "test-options" with references to "test-settings",
1980         in comments.
1981
1982 2019-07-03  Pedro Alves  <palves@redhat.com>
1983
1984         * maint-test-settings.c (maintenance_test_settings_xxx)
1985         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1986         New.
1987         (maintenance_test_settings_enums): Use them.
1988         (maintenance_test_settings_enum): Default to
1989         maintenance_test_settings_xxx.
1990         (_initialize_maint_test_settings): Initialize
1991         MAINTENANCE_TEST_SETTINGS_FILENAME.
1992
1993 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1994
1995         * breakpoint.h (remove_breakpoints_inf): Change return type to
1996         void, move function documentation here.
1997         * breakpoint.c (remove_breakpoints_inf): Change return type to
1998         void, move function documentation to header.
1999
2000 2019-07-02  Pedro Alves  <palves@redhat.com>
2001
2002         * NEWS (Completion improvements): Mention "info threads".
2003         * thread.c (struct info_threads_opts, info_threads_option_defs)
2004         (make_info_threads_options_def_group): New.
2005         (info_threads_command): Use gdb::option::process_options.
2006         (info_threads_command_completer): New.
2007         (_initialize_thread): Use gdb::option::build_help to build the
2008         help text for "info threads".
2009
2010 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2011
2012         * defs.h (generic_load): Move from here...
2013         * symfile.h (generic_load): ... to here.  Rename name parameter
2014         to args.
2015         * symfile.c (generic_load): Add comment.
2016
2017 2019-07-01  Tom Tromey  <tromey@adacore.com>
2018
2019         * dwarf2read.c
2020         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2021         declaration of without_params.  Fix formatting.
2022
2023 2019-07-01  Tom Tromey  <tromey@adacore.com>
2024
2025         * ada-exp.y (find_primitive_type): Update.
2026         * ada-lang.h (ada_lookup_symbol): Update.
2027         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2028         parameter.
2029         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2030
2031 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2032
2033         PR breakpoints/24541
2034         * gdbarch.c: Regenerate.
2035         * gdbarch.h: Regenerate.
2036         * gdbarch.sh: Add 'stap_adjust_register'.
2037         * i386-tdep.c: Include '<unordered_set>'.
2038         (i386_stap_adjust_register): New function.
2039         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2040         * stap-probe.c (stap_parse_register_operand): Call
2041         'gdbarch_stap_adjust_register'.
2042
2043 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2044
2045         PR python/24742
2046         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2047         * python/python.c (do_start_initialization): Use 'xmalloc'
2048         instead of 'PyMem_Malloc'.
2049
2050 2019-06-28  Tom Tromey  <tromey@adacore.com>
2051
2052         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2053         for Ada.
2054
2055 2019-06-27  Tom Tromey  <tromey@adacore.com>
2056
2057         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
2058         objfile_key.
2059         (arm_find_mapping_symbol, arm_record_special_symbol)
2060         (_initialize_arm_tdep): Update.
2061         (arm_objfile_data_free): Remove.
2062
2063 2019-06-27  Tom Tromey  <tromey@adacore.com>
2064
2065         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2066         to cp_print_static_field.
2067
2068 2019-06-26  Tom Tromey  <tromey@adacore.com>
2069
2070         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2071         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2072         declare.
2073
2074 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2075
2076         * features/aarch64-core.c (create_feature_aarch64_core):
2077         Regenerate.
2078         * features/aarch64-core.xml: Add cpsr flags.
2079
2080 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2081
2082         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2083         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2084
2085 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2086
2087         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2088         field.
2089         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2090         use.
2091         (arm_record_special_symbol): Don't insert new symbol in sorted
2092         position, push it at the end.
2093
2094 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2095
2096         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2097         (arm_mapping_symbol_s): Remove.
2098         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2099         (arm_mapping_symbol_vec): New typedef.
2100         (struct arm_per_objfile): Add constructor.
2101         <section_maps>: Change type to
2102         std::unique_ptr<arm_mapping_symbol_vec[]>.
2103         (arm_compare_mapping_symbols): Remove.
2104         (arm_find_mapping_symbol): Adjust to section_maps type change.
2105         (arm_objfile_data_free): Call delete on arm_per_objfile.
2106         (arm_record_special_symbol): Adjust to section_maps type change.
2107         Allocate arm_per_objfile with new.
2108
2109 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2110
2111         * cli/cli-cmds.c (alias_command): Compare the alias prefix
2112         with the command prefix.
2113
2114 2019-06-25  Tom Tromey  <tom@tromey.com>
2115
2116         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2117         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2118
2119 2019-06-25  Tom Tromey  <tom@tromey.com>
2120
2121         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2122         type.
2123         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2124         protected.
2125
2126 2019-06-25  Tom Tromey  <tom@tromey.com>
2127
2128         * tui/tui-winsource.c
2129         (tui_source_window_base::set_is_exec_point_at): Add check against
2130         LOA_ADDRESS.
2131
2132 2019-06-25  Tom Tromey  <tom@tromey.com>
2133
2134         * tui/tui-source.c (tui_set_source_content): Don't check before
2135         xfree.
2136         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2137
2138 2019-06-25  Tom Tromey  <tom@tromey.com>
2139
2140         * tui/tui-winsource.h (tui_update_source_window_as_is)
2141         (tui_alloc_source_buffer, tui_line_is_displayed)
2142         (tui_addr_is_displayed): Change type of win_info.
2143         * tui/tui-winsource.c (tui_update_source_window_as_is)
2144         (tui_clear_source_content, tui_show_source_line)
2145         (tui_show_source_content, tui_source_window_base::refill)
2146         (tui_source_window_base::set_is_exec_point_at)
2147         (tui_source_window_base::set_is_exec_point_at)
2148         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2149         (tui_alloc_source_buffer, tui_line_is_displayed)
2150         (tui_addr_is_displayed): Change type of win_info.  Update.
2151         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2152         (tui_source_window_base::do_make_visible_with_new_height):
2153         Update.
2154         * tui/tui-source.c (tui_set_source_content)
2155         (tui_set_source_content_nil)
2156         (tui_source_window::do_scroll_vertical): Update.
2157         * tui/tui-layout.c (show_layout): Update.
2158         * tui/tui-disasm.c (tui_set_disassem_content)
2159         (tui_disasm_window::do_scroll_vertical): Update.
2160         * tui/tui-data.h (tui_win_content): Remove.
2161         (struct tui_gen_win_info) <content, content_size>: Remove.
2162         (struct tui_source_element): Add initializers and destructor.
2163         (union tui_which_element, struct tui_win_element): Remove.
2164         (struct tui_source_window_base) <content>: New field.
2165         (struct tui_data_window): Remove destructor.
2166         (tui_alloc_content, tui_free_win_content)
2167         (tui_free_all_source_wins_content): Don't declare.
2168         * tui/tui-data.c (tui_initialize_static_data): Update.
2169         (init_content_element, tui_alloc_content): Remove.
2170         (~tui_gen_win_info): Update.
2171         (~tui_data_window, tui_free_all_source_wins_content)
2172         (tui_free_win_content, free_content, free_content_elements):
2173         Remove.
2174
2175 2019-06-25  Tom Tromey  <tom@tromey.com>
2176
2177         * tui/tui-winsource.h (tui_clear_source_content)
2178         (tui_erase_source_content, tui_show_source_content): Change type
2179         of win_info.
2180         * tui/tui-winsource.c (tui_clear_source_content)
2181         (tui_erase_source_content, tui_show_source_content): Change type
2182         of win_info.
2183         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2184         * tui/tui-source.h (tui_set_source_content_nil): Change type of
2185         win_info.
2186         * tui/tui-source.c (tui_set_source_content_nil): Change type of
2187         win_info.
2188         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2189
2190 2019-06-25  Tom Tromey  <tom@tromey.com>
2191
2192         * tui/tui-winsource.c (tui_clear_source_content)
2193         (tui_source_window_base::set_is_exec_point_at): Update.
2194         * tui/tui-source.c (tui_set_source_content_nil): Update.
2195         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2196         a bool.
2197         * tui/tui-data.c (init_content_element): Update.
2198
2199 2019-06-25  Tom Tromey  <tom@tromey.com>
2200
2201         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2202         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2203         * tui/tui-layout.c (init_and_make_win): Update.
2204         * tui/tui.h (enum tui_win_type): Update.
2205         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
2206         tui_win_is_auxillary.
2207         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
2208         tui_win_is_auxillary.
2209
2210 2019-06-25  Tom Tromey  <tom@tromey.com>
2211
2212         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
2213         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
2214         (tui_delete_data_content_windows, tui_display_all_data)
2215         (tui_data_window::do_scroll_vertical, tui_display_data_from):
2216         Update.
2217         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
2218         * tui/tui-regs.c (tui_last_regs_line_no)
2219         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2220         (tui_show_registers): Update.
2221         (tui_show_register_group): Return void.  Update.
2222         (tui_display_registers_from, tui_display_reg_element_at_line)
2223         (tui_display_registers_from_line, tui_check_register_values):
2224         Update.
2225         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2226         member.
2227         (struct tui_data_window) <regs_content>: Now a std::vector.
2228         <regs_content_count>: Remove.
2229         (tui_add_content_elements, tui_free_data_content): Don't declare.
2230         * tui/tui-data.c (tui_data_window::clear_detail): Update.
2231         (init_content_element): Remove DATA_WIN case.  Add assert.
2232         (tui_add_content_elements): Remove.
2233         (tui_data_window): Update.
2234         (tui_free_data_content): Remove.
2235         (free_content_elements): Remove DATA_WIN case.
2236
2237 2019-06-25  Tom Tromey  <tom@tromey.com>
2238
2239         * tui/tui-data.c (tui_data_item_window): Update.
2240         * tui/tui-windata.h (tui_check_data_values): Don't declare.
2241         * tui/tui-windata.c (tui_display_all_data)
2242         (tui_display_data_from_line): Update.
2243         (tui_check_data_values): Remove.
2244         * tui/tui-regs.c (tui_show_register_group)
2245         (tui_display_reg_element_at_line): Update.
2246         * tui/tui-hooks.c (tui_register_changed)
2247         (tui_refresh_frame_and_register_information): Call
2248         tui_check_register_values.
2249         * tui/tui-data.h (struct tui_data_window) <data_content,
2250         data_content_count, data_type>: Remove.
2251         (enum tui_data_type): Remove.
2252
2253         * tui/tui-data.c (tui_data_window::clear_detail)
2254         (~tui_data_window): Update.
2255
2256 2019-06-25  Tom Tromey  <tom@tromey.com>
2257
2258         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2259         declare.
2260         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2261         Rename from tui_first_data_item_displayed.  Update.
2262         (tui_data_window::refresh_all)
2263         (tui_data_window::do_scroll_vertical): Update.
2264         * tui/tui-data.h (struct tui_data_window)
2265         <first_data_item_displayed>: Declare new method.
2266
2267 2019-06-25  Tom Tromey  <tom@tromey.com>
2268
2269         * tui/tui-data.h (tui_init_generic_part): Don't declare.
2270         * tui/tui-data.c (tui_init_generic_part): Remove, moving
2271         contents...
2272         (tui_initialize_static_data): ...here.
2273
2274 2019-06-25  Tom Tromey  <tom@tromey.com>
2275
2276         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2277         (tui_display_registers_from, tui_check_register_values): Update.
2278         (tui_display_register): Remove win_info parameter; update.
2279         (tui_get_register): Change type of parameters.
2280         * tui/tui-data.h (struct tui_data_element): Remove.
2281         (union tui_which_element) <data>: Remove.
2282         <data_window>: Change type.
2283         (struct tui_data_item_window): New.
2284         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2285         case.  Add assert.
2286         (~tui_data_item_window): New destructor.
2287         (free_content_elements): Remove DATA_ITEM_WIN case.
2288
2289 2019-06-25  Tom Tromey  <tom@tromey.com>
2290
2291         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2292         Remove.
2293
2294 2019-06-25  Tom Tromey  <tom@tromey.com>
2295
2296         * tui/tui-data.h (struct tui_command_element): Remove.
2297         (union tui_which_element) <command>: Remove.
2298         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
2299         assert.
2300         (free_content_elements): Remove CMD_WIN case.
2301
2302 2019-06-25  Tom Tromey  <tom@tromey.com>
2303
2304         * tui/tui-layout.c (tui_set_layout): Update.
2305         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2306         * tui/tui-data.c (layout_def): Update.
2307
2308 2019-06-25  Tom Tromey  <tom@tromey.com>
2309
2310         * tui/tui-wingeneral.c (tui_refresh_all): Update.
2311         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2312         (tui_source_window_base::set_new_height): Update.
2313         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2314         Update.
2315         (tui_set_locator_fullname, tui_set_locator_info)
2316         (tui_show_frame_info): Update.
2317         * tui/tui-source.c (tui_set_source_content)
2318         (tui_source_is_displayed): Update.
2319         * tui/tui-layout.c (show_source_disasm_command, show_data)
2320         (show_source_or_disasm_and_command): Update.
2321         * tui/tui-disasm.c (tui_set_disassem_content)
2322         (tui_get_begin_asm_address): Update.
2323         * tui/tui-data.h (struct tui_locator_element): Remove.
2324         (union tui_which_element) <locator>: Remove.
2325         (struct tui_locator_window): New.
2326         (tui_locator_win_info_ptr): Change return type.
2327         * tui/tui-data.c (_locator): Change type.
2328         (tui_locator_win_info_ptr): Change return type.
2329         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
2330         (tui_alloc_content): Add assert.
2331
2332 2019-06-25  Tom Tromey  <tom@tromey.com>
2333
2334         * tui/tui-winsource.c
2335         (tui_exec_info_window::maybe_allocate_content): New method.
2336         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2337         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2338         (make_source_or_disasm_window): Add cast.
2339         * tui/tui-data.h (union tui_which_element) <simple_string>:
2340         Remove.
2341         (struct tui_source_info): New.
2342         (struct tui_source_window_base) <execution_info>: Change type.
2343         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2344         case, and add assert.
2345         (tui_alloc_content): Add assert.
2346
2347 2019-06-25  Tom Tromey  <tom@tromey.com>
2348
2349         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2350         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2351         * tui/tui-data.c (tui_alloc_win_info): Remove.
2352
2353 2019-06-25  Tom Tromey  <tom@tromey.com>
2354
2355         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2356         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2357         can_highlight.
2358
2359 2019-06-25  Tom Tromey  <tom@tromey.com>
2360
2361         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2362         make_visible_with_new_height method.
2363         (tui_win_info::make_visible_with_new_height): New method.
2364         (tui_source_window_base::do_make_visible_with_new_height)
2365         (tui_data_window::do_make_visible_with_new_height)
2366         (tui_cmd_window::do_make_visible_with_new_height): New methods.
2367         (make_visible_with_new_height): Remove.
2368         (tui_resize_all, tui_adjust_win_heights): Use
2369         make_visible_with_new_height method.
2370         * tui/tui-data.h (struct tui_win_info)
2371         <do_make_visible_with_new_height, make_visible_with_new_height>:
2372         New methods.
2373         (struct tui_source_window_base, struct tui_data_window)
2374         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2375         methods.
2376
2377 2019-06-25  Tom Tromey  <tom@tromey.com>
2378
2379         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2380         method.
2381         (update_tab_width): Call update_tab_width method.
2382         * tui/tui-data.h (struct tui_win_info)
2383         (struct tui_source_window_base) <update_tab_width>: New methods.
2384
2385 2019-06-25  Tom Tromey  <tom@tromey.com>
2386
2387         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2388         parameter.
2389         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2390         parameter.
2391         (tui_gen_win_info::make_visible): Update.
2392         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2393         parameter.
2394         * tui/tui-data.h (enum tui_box): New enum.
2395         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2396
2397 2019-06-25  Tom Tromey  <tom@tromey.com>
2398
2399         * tui/tui-layout.c (make_source_or_disasm_window): Always use
2400         init_and_make_win for EXEC_INFO_WIN.
2401         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2402         longer inline.
2403         (struct tui_win_info) <~tui_win_info>: Inline.
2404         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2405         Don't declare.
2406         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2407         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2408         Remove.
2409         (tui_initialize_static_data): Update.
2410         (~tui_gen_win_info): Handle more cleanup here.
2411         (~tui_source_window_base): Delete "execution_info".
2412         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2413
2414 2019-06-25  Tom Tromey  <tom@tromey.com>
2415
2416         * tui/tui-layout.c (make_command_window): Don't set
2417         can_highlight.
2418         (show_source_disasm_command): Call the reset method.
2419         (show_data): Don't set can_highlight.  Call the reset method.
2420         (tui_gen_win_info::reset): Rename from init_gen_win_info
2421         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2422         (show_source_or_disasm_and_command): Call the reset method.
2423         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2424         (struct tui_cmd_window): Set can_highlight.
2425
2426 2019-06-25  Tom Tromey  <tom@tromey.com>
2427
2428         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2429         from make_visible.
2430         (tui_make_visible, tui_make_invisible): Rewrite.
2431         (tui_win_info::make_visible): Remove.
2432         (tui_source_window_base::make_visible): Update.
2433         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2434         method.  Moved from...
2435         (struct tui_win_info) <make_visible>: ...here.
2436
2437 2019-06-25  Tom Tromey  <tom@tromey.com>
2438
2439         * tui/tui-winsource.c
2440         (tui_source_window_base::do_scroll_horizontal): Remove direction
2441         parameter.
2442         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2443         direction parameter.
2444         * tui/tui-win.c (tui_win_info::forward_scroll)
2445         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2446         (tui_win_info::right_scroll): Update.
2447         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2448         direction parameter.
2449         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2450         direction parameter.
2451         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2452         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2453         Remove direction parameter.
2454         (struct tui_source_window_base, struct tui_source_window)
2455         (struct tui_disasm_window, struct tui_data_window)
2456         (struct tui_cmd_window): Update.
2457
2458 2019-06-25  Tom Tromey  <tom@tromey.com>
2459
2460         * tui/tui-winsource.h (tui_set_exec_info_content)
2461         (tui_show_exec_info_content, tui_erase_exec_info_content)
2462         (tui_clear_exec_info_content, tui_update_exec_info): Change
2463         argument to tui_source_window_base.
2464         * tui/tui-winsource.c (tui_set_exec_info_content)
2465         (tui_show_exec_info_content, tui_erase_exec_info_content)
2466         (tui_clear_exec_info_content, tui_update_exec_info): Change
2467         argument to tui_source_window_base.
2468
2469 2019-06-25  Tom Tromey  <tom@tromey.com>
2470
2471         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2472         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2473
2474 2019-06-25  Tom Tromey  <tom@tromey.com>
2475
2476         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2477         check.
2478
2479 2019-06-25  Tom Tromey  <tom@tromey.com>
2480
2481         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2482         type to void.
2483         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2484         type to void.
2485         * tui/tui-source.c (tui_set_source_content): Update.
2486         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2487
2488 2019-06-25  Tom Tromey  <tom@tromey.com>
2489
2490         * tui/tui-win.c (window_name_completer, tui_set_focus)
2491         (tui_all_windows_info): Use name method.
2492         * tui/tui-data.h (struct tui_gen_win_info)
2493         (struct tui_source_window, struct tui_disasm_window)
2494         (struct tui_data_window, struct tui_cmd_window) <name>: New
2495         method.
2496         (tui_win_name): Don't declare.
2497         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2498         (tui_win_name): Remove.
2499
2500 2019-06-25  Tom Tromey  <tom@tromey.com>
2501
2502         * tui/tui-winsource.h (tui_update_source_window)
2503         (tui_update_source_window_as_is): Change parameter type.
2504         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2505         to be a tui_source_window_base.
2506         (tui_update_source_window_as_is): Likewise.
2507         * tui/tui-win.c (make_visible_with_new_height): Update.
2508
2509 2019-06-25  Tom Tromey  <tom@tromey.com>
2510
2511         * tui/tui-winsource.c (tui_erase_source_content)
2512         (tui_show_source_content, tui_show_exec_info_content)
2513         (tui_erase_exec_info_content): Use refresh_window method.
2514         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2515         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2516         from tui_refresh_win.
2517         (tui_data_window::refresh_window): New method.
2518         (tui_win_info::refresh, tui_source_window_base::refresh)
2519         (tui_refresh_all): Use refresh_window method.
2520         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2521         method.
2522         * tui/tui-regs.c (tui_display_register): Call refresh_window
2523         method.
2524         * tui/tui-layout.c (show_source_disasm_command)
2525         (show_source_or_disasm_and_command): Call refresh_window method.
2526         * tui/tui-data.h (struct tui_gen_win_info)
2527         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2528         New method.
2529
2530 2019-06-25  Tom Tromey  <tom@tromey.com>
2531
2532         * tui/tui.c (tui_rl_other_window, tui_enable)
2533         (tui_is_window_visible, tui_get_command_dimension): Update.
2534         * tui/tui-winsource.c (tui_update_source_window_as_is)
2535         (tui_clear_source_content, tui_erase_source_content)
2536         (tui_show_source_line, tui_source_window_base::refill)
2537         (tui_source_window_base::do_scroll_horizontal)
2538         (tui_source_window_base::set_is_exec_point_at)
2539         (tui_update_breakpoint_info, tui_set_exec_info_content)
2540         (tui_alloc_source_buffer, tui_line_is_displayed)
2541         (tui_addr_is_displayed): Update.
2542         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2543         (tui_check_and_display_highlight_if_needed)
2544         (tui_win_info::make_visible, tui_win_info::refresh)
2545         (tui_refresh_all): Update.
2546         * tui/tui-windata.c (tui_first_data_item_displayed)
2547         (tui_delete_data_content_windows, tui_erase_data_content)
2548         (tui_display_all_data, tui_data_window::refresh_all)
2549         (tui_check_data_values): Update.
2550         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2551         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2552         (tui_win_info::backward_scroll, tui_refresh_all_win)
2553         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2554         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2555         (tui_source_window_base::set_new_height)
2556         (tui_data_window::set_new_height)
2557         (make_invisible_and_set_new_height)
2558         (make_visible_with_new_height, new_height_ok)
2559         (parse_scrolling_args): Update.
2560         * tui/tui-stack.c (tui_show_frame_info): Update.
2561         * tui/tui-source.c (tui_set_source_content)
2562         (tui_set_source_content_nil, tui_source_is_displayed)
2563         (tui_source_window::do_scroll_vertical): Update.
2564         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2565         (tui_display_registers_from, tui_display_reg_element_at_line)
2566         (tui_check_register_values, tui_reg_command): Update.
2567         * tui/tui-layout.c (tui_default_win_height)
2568         (show_source_disasm_command, show_data, init_and_make_win)
2569         (show_source_or_disasm_and_command): Update.
2570         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2571         (tui_redisplay_readline, tui_mld_flush)
2572         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2573         (tui_getc): Update.
2574         * tui/tui-disasm.c (tui_set_disassem_content)
2575         (tui_disasm_window::do_scroll_vertical): Update.
2576         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2577         Now virtual.
2578         (struct tui_win_info): Derive from tui_gen_win_info.
2579         <~tui_win_info>: Mark as override.
2580         <generic>: Remove member.
2581         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2582         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2583         (~tui_data_window, ~tui_win_info)
2584         (tui_free_all_source_wins_content): Update.
2585         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2586
2587 2019-06-25  Tom Tromey  <tom@tromey.com>
2588
2589         * tui/tui-layout.c (init_and_make_win): Use new.
2590         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2591         destructor, initializers.
2592         (tui_alloc_generic_win_info): Don't declare.
2593         * tui/tui-data.c (_locator): Add argument to constructor.
2594         (source_win, disasm_win): New globals.
2595         (exec_info): Remove.
2596         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2597         Update.
2598         (tui_alloc_generic_win_info): Remove.
2599         (init_content_element): Use new.
2600         (tui_win_info::tui_win_info): Update.
2601         (free_content_elements) <case DATA_WIN>: Use delete.
2602
2603 2019-06-25  Tom Tromey  <tom@tromey.com>
2604
2605         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2606         * tui/tui-windata.c (tui_first_data_item_displayed)
2607         (tui_delete_data_content_windows): Update.
2608         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2609         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2610         (tui_display_registers_from, tui_check_register_values): Update.
2611         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2612         pointer.
2613         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2614         window.
2615         (tui_free_data_content): Update.
2616         (free_content_elements) <case DATA_WIN>: Free the window.
2617
2618 2019-06-25  Tom Tromey  <tom@tromey.com>
2619
2620         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2621         Update.
2622         * tui/tui-layout.c (make_command_window)
2623         (show_source_disasm_command, show_data, init_and_make_win)
2624         (show_source_or_disasm_and_command): Update.
2625         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2626         method.
2627         <can_highight, is_highlighted>: Now bool.
2628         (tui_set_win_highlight): Don't declare.
2629         * tui/tui-data.c (tui_set_win_highlight): Remove.
2630
2631 2019-06-25  Tom Tromey  <tom@tromey.com>
2632
2633         * tui/tui-wingeneral.c (make_visible): Remove check of window
2634         type.
2635
2636 2019-06-25  Tom Tromey  <tom@tromey.com>
2637
2638         * tui/tui-win.c (tui_win_info::max_height)
2639         (tui_cmd_window::max_height): New methods.
2640         (new_height_ok): Call max_height.
2641         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2642         <max_height>: New method.
2643
2644 2019-06-25  Tom Tromey  <tom@tromey.com>
2645
2646         * tui/tui-win.c (tui_source_window_base::set_new_height)
2647         (tui_data_window::set_new_height): New methods.
2648         (make_invisible_and_set_new_height): Call set_new_height method.
2649         * tui/tui-data.h (struct tui_win_info)
2650         (struct tui_source_window_base, struct tui_data_window)
2651         <set_new_height>: New method.
2652
2653 2019-06-25  Tom Tromey  <tom@tromey.com>
2654
2655         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2656         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2657         tui_refresh_data_win.
2658         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2659         method.
2660         (tui_refresh_all_win): Call the refresh_all method.
2661         (tui_set_focus): Likewise.
2662         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2663         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2664         Likewise.
2665
2666 2019-06-25  Tom Tromey  <tom@tromey.com>
2667
2668         * tui/tui-winsource.h (tui_refill_source_window)
2669         (tui_set_is_exec_point_at): Don't declare.
2670         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2671         (tui_source_window_base::refill): Rename from
2672         tui_refill_source_window.
2673         (tui_source_window_base::do_scroll_horizontal): Update.
2674         (tui_source_window_base::set_is_exec_point_at): Rename from
2675         tui_set_is_exec_point_at.
2676         (tui_update_all_breakpoint_info): Update.
2677         * tui/tui-stack.c (tui_show_frame_info): Update.
2678         * tui/tui-layout.c (show_data): Add cast.
2679         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2680         * tui/tui-data.h (struct tui_source_window_base) <refill,
2681         set_is_exec_point_at>: New methods.
2682         (tui_source_windows, tui_add_to_source_windows): Update types.
2683         (tui_add_to_source_windows): Remove redundant declaration.
2684         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2685         (tui_source_windows): Change return type.
2686         (tui_clear_source_windows_detail): Update.
2687         (tui_add_to_source_windows): Change type of parameter.
2688         (tui_free_all_source_wins_content): Update.
2689
2690 2019-06-25  Tom Tromey  <tom@tromey.com>
2691
2692         * tui/tui-wingeneral.c (tui_win_info::refresh)
2693         (tui_source_window_base::refresh): New methods.
2694         (tui_refresh_all): Call the refresh method.
2695         * tui/tui-data.h (struct tui_win_info)
2696         (struct tui_source_window_base) <refresh>: New method.
2697
2698 2019-06-25  Tom Tromey  <tom@tromey.com>
2699
2700         * tui/tui.h (tui_is_window_visible): Return bool.
2701         * tui/tui.c (tui_is_window_visible): Return bool.
2702         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2703         (tui_make_visible, tui_make_invisible)
2704         (tui_win_info::make_visible)
2705         (tui_source_window_base::make_visible, make_all_visible)
2706         (tui_make_all_visible, tui_make_all_invisible): Update.
2707         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2708         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2709         bool.
2710         (struct tui_win_info, struct tui_source_window_base)
2711         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2712         * tui/tui-data.c (tui_init_generic_part): Update.
2713
2714 2019-06-25  Tom Tromey  <tom@tromey.com>
2715
2716         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2717         (tui_source_window_base::make_visible): New methods.
2718         (make_all_visible): Make method call.
2719         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2720         (struct tui_source_window_base, struct tui_cmd_window): Override
2721         make_visible.
2722         (tui_win_is_source_type): Don't declare.
2723         * tui/tui-data.c (tui_win_is_source_type): Remove.
2724
2725 2019-06-25  Tom Tromey  <tom@tromey.com>
2726
2727         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2728         NULL check.
2729
2730 2019-06-25  Tom Tromey  <tom@tromey.com>
2731
2732         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2733         Inline constructor.  Add initializers for members.
2734         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2735         constructors; now inline in class.
2736
2737 2019-06-25  Tom Tromey  <tom@tromey.com>
2738
2739         * tui/tui-regs.c (tui_show_registers): Update.
2740         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2741         bool.
2742         * tui/tui-data.c (tui_data_window::clear_detail)
2743         (tui_data_window): Update.
2744
2745 2019-06-25  Tom Tromey  <tom@tromey.com>
2746
2747         * tui/tui-windata.c (tui_display_all_data)
2748         (tui_display_data_from_line, tui_display_data_from)
2749         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2750         Update.
2751         * tui/tui-regs.c (tui_last_regs_line_no)
2752         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2753         (tui_show_registers, tui_show_register_group)
2754         (tui_display_registers_from, tui_display_reg_element_at_line)
2755         (tui_display_registers_from_line, tui_check_register_values)
2756         (tui_reg_next, tui_reg_prev): Update.
2757         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2758         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2759         tui_data_window.
2760         (struct tui_win_info) <detail>: Remove.  Add new fields from
2761         tui_data_info.
2762         (TUI_DATA_WIN): Add cast.
2763         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2764         (~tui_data_window): Simplify.
2765
2766 2019-06-25  Tom Tromey  <tom@tromey.com>
2767
2768         * tui/tui-layout.c (show_source_disasm_command)
2769         (show_source_or_disasm_and_command): Update.
2770         * tui/tui-io.c (update_cmdwin_start_line)
2771         (tui_redisplay_readline): Update.
2772         * tui/tui-data.h (struct tui_command_info): Remove.
2773         (struct tui_win_info) <detail>: Remove command_info member.
2774         (struct tui_data_window) <start_line>: New member, from
2775         tui_command_info.
2776         (TUI_CMD_WIN): Add casts.
2777
2778 2019-06-25  Tom Tromey  <tom@tromey.com>
2779
2780         * tui/tui-winsource.c (tui_update_source_window)
2781         (tui_refill_source_window)
2782         (tui_source_window_base::do_scroll_horizontal)
2783         (tui_update_breakpoint_info, tui_set_exec_info_content)
2784         (tui_show_exec_info_content, tui_erase_exec_info_content)
2785         (tui_clear_exec_info_content): Update.
2786         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2787         Update.
2788         * tui/tui-win.c (make_invisible_and_set_new_height)
2789         (make_visible_with_new_height): Update.
2790         * tui/tui-source.c (tui_set_source_content)
2791         (tui_show_symtab_source): Update.
2792         * tui/tui-layout.c (extract_display_start_addr)
2793         (show_source_disasm_command, show_data)
2794         (make_source_or_disasm_window)
2795         (show_source_or_disasm_and_command): Update.
2796         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2797         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2798         "gdbarch".
2799         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2800         to tui_source_window_base.
2801         (struct tui_win_info) <detail>: Remove source_info member.
2802         (struct tui_source_window_base) <has_locator>: Inline.
2803         Move contents from tui_source_info; rename has_locator member to
2804         m_has_locator.
2805         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2806         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2807         header file.
2808         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2809         Simplify.
2810         (tui_free_all_source_wins_content): Cast to
2811         tui_source_window_base.
2812
2813 2019-06-25  Tom Tromey  <tom@tromey.com>
2814
2815         * tui/tui-win.c (make_invisible_and_set_new_height)
2816         (make_visible_with_new_height): Call has_locator method.
2817         * tui/tui-layout.c (show_source_disasm_command, show_data)
2818         (show_source_or_disasm_and_command): Update for bool change.
2819         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2820         (tui_win_info) <has_locator>: New method.
2821         (struct tui_source_window_base) <has_locator>: New method.
2822         (tui_win_has_locator): Don't declare.
2823         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2824         from tui_win_has_locator.
2825         (tui_source_window_base): Use false, not FALSE.
2826
2827 2019-06-25  Tom Tromey  <tom@tromey.com>
2828
2829         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2830         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2831         clear_detail method directly.
2832         (tui_clear_win_detail): Remove.
2833
2834 2019-06-25  Tom Tromey  <tom@tromey.com>
2835
2836         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2837         "this", not TUI_DISASM_WIN.
2838
2839 2019-06-25  Tom Tromey  <tom@tromey.com>
2840
2841         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2842         declare.
2843         * tui/tui-winsource.c
2844         (tui_source_window_base::do_scroll_horizontal): Rename from
2845         tui_horizontal_source_scroll.
2846         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2847         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2848         from tui_vertical_data_scroll.
2849         * tui/tui-win.h (tui_scroll): Don't declare.
2850         * tui/tui-win.c (tui_win_info::forward_scroll)
2851         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2852         (tui_win_info::right_scroll): Rename and update.
2853         (tui_scroll_forward_command, tui_scroll_backward_command)
2854         (tui_scroll_left_command, tui_scroll_right_command): Update.
2855         (tui_scroll): Remove.
2856         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2857         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2858         from tui_vertical_source_scroll.
2859         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2860         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2861         from tui_vertical_disassem_scroll.
2862         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2863         do_scroll_horizontal>: New methods.
2864         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2865         Likewise.
2866         (struct tui_source_window_base): Add do_scroll_horizontal.
2867         (struct tui_source_window, struct tui_disasm_window): Add
2868         do_scroll_vertical.
2869         (struct tui_data_window, struct tui_cmd_window): Add
2870         do_scroll_horizontal and do_scroll_vertical.
2871         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2872
2873 2019-06-25  Tom Tromey  <tom@tromey.com>
2874
2875         * tui/tui-data.h (struct tui_source_window_base): New struct.
2876         (struct tui_source_window): Derive from tui_source_window_base.
2877         (struct tui_disasm_window): New struct.
2878         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2879         from tui_source_window::clear_detail.
2880         (tui_source_window_base): Rename from tui_source_window.
2881         (~tui_source_window_base): Rename from ~tui_source_window.
2882         (tui_alloc_win_info): Create a tui_disasm_window.
2883
2884 2019-06-25  Tom Tromey  <tom@tromey.com>
2885
2886         * tui/tui-data.h (struct tui_source_window)
2887         (struct tui_data_window): Declare destructors.
2888         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2889         destructors.
2890         (tui_win_info): Simplify.
2891
2892 2019-06-25  Tom Tromey  <tom@tromey.com>
2893
2894         * tui/tui-winsource.c (tui_display_main)
2895         (tui_update_source_windows_with_addr)
2896         (tui_update_all_breakpoint_info): Update.
2897         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2898         (new_height_ok, parse_scrolling_args): Update.
2899         * tui/tui-stack.c (tui_show_frame_info): Update.
2900         * tui/tui-data.h (struct tui_list): Remove.
2901         (tui_source_windows): Return a reference to a std::vector.
2902         * tui/tui-data.c (source_windows): Now a std::vector.
2903         (tui_source_windows): Change return type.
2904         (tui_clear_source_windows): Rewrite.
2905         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2906         (tui_free_all_source_wins_content): Rewrite.
2907
2908 2019-06-25  Tom Tromey  <tom@tromey.com>
2909
2910         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2911         (struct tui_data_window, struct tui_cmd_window): Declare
2912         clear_detail method.
2913         * tui/tui-data.c (tui_source_window::clear_detail)
2914         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2915         methods.
2916         (tui_clear_win_detail): Simplify.
2917
2918 2019-06-25  Tom Tromey  <tom@tromey.com>
2919
2920         * tui/tui-layout.c (make_source_window, make_disasm_window)
2921         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2922         Return the new window.
2923         (show_source_disasm_command, show_data)
2924         (show_source_or_disasm_and_command): Update.
2925
2926 2019-06-25  Tom Tromey  <tom@tromey.com>
2927
2928         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2929         parameter.  Return the new window.
2930         (show_source_disasm_command): Update and remove NULL check.
2931         (show_source_or_disasm_and_command): Update.
2932
2933 2019-06-25  Tom Tromey  <tom@tromey.com>
2934
2935         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2936
2937 2019-06-25  Tom Tromey  <tom@tromey.com>
2938
2939         * tui/tui-data.h (struct tui_win_info): Make constructor
2940         protected.  Make destructor virtual.  Add initializers.
2941         (tui_source_window, tui_data_window, tui_cmd_window): New
2942         classes.
2943         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2944         constructor.  Add "type" parameter.
2945         (tui_source_window, tui_data_window, tui_cmd_window): New
2946         constructors.
2947         (tui_alloc_win_info): Instantiate the appropriate subclass.
2948
2949 2019-06-25  Tom Tromey  <tom@tromey.com>
2950
2951         * tui/tui-win.c (tui_resize_all): Use delete.
2952         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2953         destructor.
2954         (tui_free_window): Don't declare.
2955         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2956         Update.
2957
2958 2019-06-25  Tom Tromey  <tom@tromey.com>
2959
2960         * tui/tui-data.h (struct tui_win_info): Add constructor.
2961         * tui/tui-data.c (tui_alloc_win_info): Use new.
2962         (tui_free_window): Use delete.
2963
2964 2019-06-22  Tom Tromey  <tom@tromey.com>
2965
2966         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2967         declare.
2968         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2969
2970 2019-06-22  Tom Tromey  <tom@tromey.com>
2971
2972         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2973         declare.
2974         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2975
2976 2019-06-22  Tom de Vries  <tdevries@suse.de>
2977
2978         * dwarf2read.c (create_addrmap_from_aranges)
2979         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2980         instead of '%zu'.
2981
2982 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2983
2984         * dwarf2read.h (dwarf2_section_info_def): Remove.
2985         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2986         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2987         std::vector<dwarf2_section_info>.
2988         (struct dwo_file) <~dwo_file>: Remove.
2989         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2990         types field.
2991         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2992         (dwarf2_read_debug_names): Likewise.
2993         (create_debug_types_hash_table): Change parameter type to
2994         array_view, adjust code accordingly.
2995         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2996         (partial_die_info::fixup): Likewise.
2997         (determine_prefix): Likewise.
2998         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2999
3000 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3001
3002         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3003         gdb_bfd_ref_ptr.
3004         <~dwo_file>: Remove call to gdb_bfd_unref.
3005         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3006         gdb_bfd_ref_ptr::get.
3007
3008 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3009
3010         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3011         type to htab_up.
3012         * dwarf2read.c (struct dwo_file): Initialize fields.
3013         <~dwo_file>: New.
3014         (free_dwo_file): Remove, move content to ~dwo_file.
3015         (struct dwo_file_deleter): Remove.
3016         (dwo_file_up>: Remove custom deleter.
3017         (free_dwo_files): Remove.
3018         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3019         dwo_files.
3020         (process_skeletonless_type_units): Call unique_ptr::get.
3021         (allocate_dwo_file_hash_table): Add deleter to created hash
3022         table.  Change return type to htab_up.
3023         (lookup_dwo_file_slot): Don't memset dwo_file, call
3024         unique_ptr::get.
3025         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3026         (create_dwo_unit_in_dwp_v2): Likewise.
3027         (open_and_init_dwo_file): Likewise.
3028         (free_dwo_file_from_slot): Remove.
3029
3030 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3031
3032         * dwarf2read.h (struct dwarf2_section_info) <readin,
3033         is_virtual>: Change type to bool.
3034         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3035         true instead of 1.
3036
3037 2019-06-19  Tom Tromey  <tom@tromey.com>
3038
3039         * tui/tui-data.h (tui_init_content_element): Don't declare.
3040
3041 2019-06-19  Tom Tromey  <tom@tromey.com>
3042
3043         * tui/tui-data.h (tui_init_win_info): Don't declare.
3044
3045 2019-06-19  Tom de Vries  <tdevries@suse.de>
3046
3047         * dwarf2read.h (abstract_to_concrete): Change type to
3048         std::unordered_map<sect_offset, std::vector<sect_offset>,
3049         gdb::hash_enum<sect_offset>>.
3050
3051 2019-06-19  Tom Tromey  <tromey@adacore.com>
3052
3053         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3054         EVAL_AVOID_SIDE_EFFECTS specially.
3055
3056 2019-06-19  Tom Tromey  <tromey@adacore.com>
3057
3058         * source-cache.c (highlighter): New global.
3059         (source_cache::get_source_lines): Create a highlighter on demand.
3060
3061 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3062
3063         * defs.h (deprecated_interactive_hook): Delete declaration.
3064         * interps.c (clear_interpreter_hooks): Remove use of
3065         deprecated_interactive_hook.
3066         * top.c (deprecated_interactive_hook): Delete definition.
3067         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3068
3069 2019-06-18  Tom de Vries  <tdevries@suse.de>
3070
3071         PR gdb/24515
3072         * dwarf2read.h (abstract_to_concrete): Change type from
3073         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3074         std::unordered_map<sect_offset, std::vector<sect_offset>>.
3075         * dwarf2read.c (read_variable): Update.
3076         (dwarf2_fetch_die_loc_sect_off): Update.
3077
3078 2019-06-17  Tom de Vries  <tdevries@suse.de>
3079
3080         PR gdb/24617
3081         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3082         accessing parent[parent_len - 1].
3083
3084 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
3085
3086         PR gdb/24364
3087         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3088         call dtrace_process_dof with NULL dof.
3089
3090 2019-06-16  Tom de Vries  <tdevries@suse.de>
3091
3092         PR gdb/24445
3093         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3094
3095 2019-06-16  Tom Tromey  <tom@tromey.com>
3096
3097         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3098         (make_all_visible): Use address of member.
3099
3100 2019-06-16  Tom Tromey  <tom@tromey.com>
3101
3102         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3103         (tui_free_window, free_content, free_content_elements): Remove
3104         unnecessary cast.
3105         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3106         cast.
3107         * tui/tui-regs.c (tui_show_register_group)
3108         (tui_display_registers_from, tui_display_reg_element_at_line):
3109         Remove unnecessary cast.
3110
3111 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
3112
3113         * linux-nat.c (normal_mask): Delete.
3114         (_initialize_linux_nat): Don't initialise normal_mask.
3115
3116 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
3117
3118         PR gdb/24445
3119         * dwarf-index-write.h (write_psymtabs_to_index): Add
3120         dwz_basename parameter.
3121         * dwarf-index-write.c (write_gdbindex): Move file writing to
3122         write_gdbindex_1.  Change return type void.
3123         (assert_file_size): Move up, remove filename parameter.
3124         (write_gdbindex_1): New function.
3125         (write_debug_names): Change return type to void, call
3126         assert_file_size.
3127         (struct index_wip_file): New struct.
3128         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
3129         file logic to index_wip_file.  Write index for dwz file if
3130         needed.
3131         (save_gdb_index_command): Pass basename of dwz file, if present.
3132         * dwarf-index-cache.c (index_cache::store): Obtain and pass
3133         build-id of dwz file, if present.
3134         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3135         (dwarf2_get_dwz_file): Likewise.
3136         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3137         (dwarf2_get_dwz_file): Likewise.
3138
3139 2019-06-16  Tom Tromey  <tom@tromey.com>
3140
3141         * coffread.c (process_coff_symbol): Use xstrdup.
3142         * value.c (create_internalvar): Use xstrdup.
3143
3144 2019-06-16  Tom Tromey  <tom@tromey.com>
3145
3146         * valops.c (value_cast, value_slice): Remove unnecessary cast.
3147         * breakpoint.c (stopin_command, stopat_command)
3148         (until_break_command, decode_location_default): Remove unnecessary
3149         cast.
3150         * utils.c (subset_compare): Remove unnecessary cast.
3151         * ada-lang.c (ada_update_initial_language): Remove unnecessary
3152         cast.
3153         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3154         cast.
3155         * infcmd.c (path_command): Remove unnecessary cast.
3156         * coffread.c (decode_type): Remove unnecessary cast.
3157         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3158         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3159         * tui/tui-stack.c (tui_show_locator_content)
3160         (tui_show_frame_info): Remove unnecessary cast.
3161         * tui/tui-win.c (tui_scroll_forward_command)
3162         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
3163         (parse_scrolling_args): Remove unnecessary cast.
3164         * tui/tui-data.c (init_win_info, tui_del_window)
3165         (tui_free_window, tui_del_data_windows, tui_free_data_content)
3166         (free_content_elements): Remove unnecessary cast.
3167         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
3168         unnecessary cast.
3169         * tui/tui-source.c (tui_set_source_content)
3170         (tui_vertical_source_scroll): Remove unnecessary cast.
3171         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3172         cast.
3173         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3174         * tui/tui-regs.c (tui_display_registers_from)
3175         (tui_display_register): Remove unnecessary cast.
3176         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3177         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3178         (make_visible): Remove unnecessary cast.
3179         * tui/tui-winsource.c (tui_erase_source_content)
3180         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3181         unnecessary cast.
3182         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3183         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3184         * stabsread.c (read_type, read_array_type, read_range_type):
3185         Remove unnecessary cast.
3186         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3187         (parse_symbol, parse_type, upgrade_type, parse_external)
3188         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3189         unnecessary cast.
3190         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3191
3192 2019-06-16  Tom Tromey  <tom@tromey.com>
3193
3194         * tui/tui-data.c (tui_alloc_generic_win_info)
3195         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3196         checks.
3197
3198 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
3199             Andrew Burgess  <andrew.burgess@embecosm.com>
3200
3201         * f-typeprint.c (f_print_type): Don't return early for not
3202         associated or not allocated types.
3203         (f_type_print_varspec_suffix): Add print_rank parameter and print
3204         ranks of array types in case they dangling.
3205         (f_type_print_base): Add print_rank parameter.
3206
3207 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3208
3209         * NEWS: Mention new MI commands.
3210         * break-catch-throw.c (enum exception_event_kind): Move to
3211         breakpoint.h.
3212         (print_mention_exception_catchpoint): Output text as a single
3213         message.
3214         (catch_exception_command_1): Rename to...
3215         (catch_exception_event): ...this, make non-static, update header
3216         command, and change some parameter types.
3217         (catch_catch_command): Update for changes to
3218         catch_exception_command_1.
3219         (catch_throw_command): Likewise.
3220         (catch_rethrow_command): Likewise.
3221         * breakpoint.c (enum exception_event_kind): Delete.
3222         * breakpoint.h (enum exception_event_kind): Moved here from
3223         break-catch-throw.c.
3224         (catch_exception_event): Declare.
3225         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3226         (mi_cmd_catch_throw): New function.
3227         (mi_cmd_catch_rethrow): New function.
3228         (mi_cmd_catch_catch): New function.
3229         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
3230         'catch-catch' entries.
3231         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
3232         (mi_cmd_catch_rethrow): Declare.
3233         (mi_cmd_catch_catch): Declare.
3234
3235 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3236
3237         * annotate.c (annotate_source_line): Change return type to void,
3238         update implementation to match.
3239         * annotate.h (annotate_source_line): Change return type to void,
3240         update header comment.
3241         * stack.c (print_frame_info): Don't change what frame information
3242         is printed based on whether annotations are on or not.
3243
3244 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3245
3246         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3247         (annotate_source): Make static.
3248         (annotate_source_line): Moved from source.c and renamed from
3249         identify_source_line.  Update the return type.
3250         * annotate.h (annotate_source): Delete declaration.
3251         (annotate_source_line): Declaration moved from source.h, and
3252         renamed from identify_source_line.  Return type updated.
3253         * source.c (identify_source_line): Moved to annotate.c and renamed
3254         to annotate_source_line.
3255         (info_line_command): Remove check of annotation_level.
3256         * source.h (identify_source_line): Move declaration to annotate.h
3257         and rename to annotate_source_line.
3258         * stack.c: Add 'annotate.h' include.
3259         (print_frame_info): Remove check of annotation_level before
3260         calling annotate_source_line.
3261
3262 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3263
3264         * source-cache.c (source_cache::get_plain_source_lines): Use
3265         open_source_file_with_line_charpos instead of just
3266         open_source_file, remove call to find_source_lines.
3267         (source_cache::get_source_lines): Likewise.
3268         * source.c (find_source_lines): Make static.
3269         (get_filename_and_charpos): Renamed into...
3270         (open_source_file_with_line_charpos): ..this along with changes to
3271         return a scoped_fd, and some other minor clean ups.
3272         (identify_source_line): Use open_source_file_with_line_charpos.
3273         (search_command_helper): Use open_source_file_with_line_charpos
3274         instead of just open_source_file, remove call to
3275         find_source_lines.
3276         * source.h (open_source_file_with_line_charpos): Declare new
3277         function.
3278         (find_source_lines): Delete declaration.
3279
3280 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3281
3282         * source.c (get_filename_and_charpos): Remove fullname
3283         parameter.
3284         (identify_source_line): Update call to get_filename_and_charpos.
3285
3286 2019-06-14  Tom Tromey  <tromey@adacore.com>
3287
3288         PR gdb/24502:
3289         * ui-style.h (skip_ansi_escape): Update comment.
3290         * ui-file.h (class no_terminal_escape_file): New class.
3291         * ui-file.c (no_terminal_escape_file::write)
3292         (no_terminal_escape_file::puts): New methods.
3293         * cli/cli-logging.c (handle_redirections): Use
3294         no_terminal_escape_file.
3295
3296 2019-06-14  Tom Tromey  <tromey@adacore.com>
3297
3298         * NEWS: Move convenience variable news above Python news.
3299
3300 2019-06-14  Tom Tromey  <tom@tromey.com>
3301
3302         * gnulib: Move directory to top-level.
3303         * configure.ac: Don't configure gnulib.
3304         * configure: Rebuild.
3305         * common/common-defs.h: Use new path to gnulib.
3306         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3307         (GNULIB_H): Remove.
3308         (INCGNU): Look in new gnulib location.
3309         (HFILES_NO_SRCDIR): Remove gnulib files.
3310         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3311         (generated_files): Remove GNULIB_H.
3312         ($(LIBGNU), all-lib): Remove targets.
3313         (distclean): Don't mention GNULIB_BUILDDIR.
3314         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3315
3316 2019-06-14  Tom Tromey  <tromey@adacore.com>
3317
3318         * symfile.c (add_symbol_file_command): Remove obsolete comment.
3319         Warn if symbol file does not provide any symbols.
3320
3321 2019-06-14  Tom Tromey  <tromey@adacore.com>
3322
3323         * source.c (find_and_open_source): Respect basenames_may_differ.
3324
3325 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
3326
3327         * annotate.c (annotate_breakpoints_invalid): Make use of
3328         scoped_restore_terminal_state.
3329         (annotate_frames_invalid): Likewise.
3330
3331 2019-06-14  Tom Tromey  <tromey@adacore.com>
3332
3333         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3334         allow assignment to an internalvar.
3335
3336 2019-06-14  Tom Tromey  <tromey@adacore.com>
3337
3338         * ada-lex.l: Allow "_" in attribute names.
3339
3340 2019-06-14  Tom Tromey  <tromey@adacore.com>
3341
3342         PR gdb/24653:
3343         * regcache.c (registers_changed): Don't call alloca.
3344         * top.c (execute_command): Don't call alloca.
3345
3346 2019-06-13  Pedro Alves  <palves@redhat.com>
3347
3348         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3349         'expression'.  When parsing an expression, error out if there's
3350         junk after "unlimited".
3351         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3352         (do_set_command): Adjust calls to is_unlimited_literal.
3353
3354 2019-06-13  Pedro Alves  <palves@redhat.com>
3355
3356         * compile/compile.c (make_compile_options_def_group): Add braces
3357         around array_view initializer.
3358         * thread.c (make_thread_apply_all_options_def_group)
3359         (make_thread_apply_all_options_def_group): Likewise.
3360
3361 2019-06-13  Pedro Alves  <palves@redhat.com>
3362
3363         * NEWS (New commands): Mention "maint test-options
3364         require-delimiter", "maint test-options unknown-is-error", "maint
3365         test-options unknown-is-operand" and "maint show
3366         test-options-completion-result".
3367         (New command options, command completion): New section.
3368         (Completion improvements): New section.
3369         Mention that you can abbreviate "unlimited".
3370
3371 2019-06-13  Pedro Alves  <palves@redhat.com>
3372
3373         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3374         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3375         * unittests/cli-utils-selftests.c (test_parse_flags)
3376         (test_parse_flags_qcs): Delete.
3377         (test_cli_utils): Don't call deleted functions.
3378
3379 2019-06-13  Pedro Alves  <palves@redhat.com>
3380
3381         * thread.c: Include "cli/cli-option.h".
3382         (tp_array_compar_ascending): Global.
3383         (tp_array_compar): Delete function.
3384         (tp_array_compar_ascending, tp_array_compar_descending): New
3385         functions.
3386         (ascending_option_def, qcs_flag_option_def)
3387         (thr_qcs_flags_option_defs)
3388         (make_thread_apply_all_options_def_group)
3389         (make_thread_apply_options_def_group): New.
3390         (thread_apply_all_command): Use gdb::option::process_options.
3391         (thread_apply_command_completer)
3392         (thread_apply_all_command_completer): New.
3393         (thread_apply_command): Use gdb::option::process_options.
3394         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3395         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
3396         to generate help text of "thread apply".  Adjust "taas"'s help.
3397         * tid-parse.c (tid_range_parser::in_thread_range): New method.
3398         * tid-parse.h (tid_range_parser::in_thread_range): New method.
3399
3400 2019-06-13  Pedro Alves  <palves@redhat.com>
3401
3402         * thread.c (thread_apply_command): Check for invalid TID with
3403         isdigit instead of !isalpha.
3404
3405 2019-06-13  Pedro Alves  <palves@redhat.com>
3406
3407         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3408         (validate_flags_qcs): New.
3409         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3410         (validate_flags_qcs): Declare.
3411         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3412         (make_frame_apply_options_def_group): New.
3413         (frame_apply_command_count): Process options with
3414         gdb::option::process_options.
3415         (frame_apply_completer): New.
3416         (frame_apply_level_completer, frame_apply_all_completer)
3417         (frame_apply_completer): New.
3418         (_initialize_stack): Update help of "frame apply", "frame apply
3419         level", "frame apply all" and "faas" to mention supported options
3420         and install command completers.
3421         * stack.h (frame_apply_all_completer): Declare.
3422         * thread.c: Include "stack.h".
3423         (tfaas_command): Add "--".
3424         (_initialize_thread): Update help "tfaas" to mention supported
3425         options and install command completer.
3426
3427 2019-06-13  Pedro Alves  <palves@redhat.com>
3428
3429         * completer.c (complete_nested_command_line): New.
3430         (gdb_completion_word_break_characters_throw): Add assertion.
3431         * completer.h (complete_nested_command_line): Declare.
3432
3433 2019-06-13  Pedro Alves  <palves@redhat.com>
3434
3435         * stack.c (parse_backtrace_qualifiers): New.
3436         (backtrace_command): Use it.
3437         (backtrace_command_completer): Complete on qualifiers.
3438
3439 2019-06-13  Pedro Alves  <palves@redhat.com>
3440
3441         * frame.c: Include "cli/cli-option.h.
3442         (user_set_backtrace_options): New.
3443         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3444         Delete.
3445         (get_prev_frame): Adjust.
3446         (boolean_option_def, uinteger_option_def)
3447         (set_backtrace_option_defs): New.
3448         (_initialize_frame): Adjust and use
3449         gdb::option::add_setshow_cmds_for_options to install "set
3450         backtrace past-main" and "set backtrace past-entry".
3451         * frame.h: Include "cli/cli-option.h".
3452         (struct frame_print_options): Forward declare.
3453         (print_frame_arguments_all, print_frame_arguments_scalars)
3454         (print_frame_arguments_none): Declare.
3455         (print_entry_values): Delete declaration.
3456         (struct frame_print_options, user_frame_print_options): New.
3457         (struct set_backtrace_options): New.
3458         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3459         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3460         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3461         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3462         (list_args_or_locals): Add frame_print_options parameter.
3463         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3464         * python/py-framefilter.c (enumerate_args): Pass down
3465         USER_FRAME_PRINT_OPTIONS.
3466         * stack.c: Include "cli/cli-option.h".
3467         (print_frame_arguments_all, print_frame_arguments_scalars)
3468         (print_frame_arguments_none): Declare.
3469         (print_raw_frame_arguments, print_entry_values): Delete.
3470         (user_frame_print_options): New.
3471         (boolean_option_def, enum_option_def, frame_print_option_defs):
3472         New.
3473         (struct backtrace_cmd_options): New.
3474         (bt_flag_option_def): New.
3475         (backtrace_command_option_defs): New.
3476         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3477         (print_frame_arg, read_frame_arg, print_frame_args)
3478         (print_frame_info, print_frame): Add frame_print_options parameter
3479         and use it.
3480         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3481         (backtrace_command_1): Add frame_print_options and
3482         backtrace_cmd_options parameters and use them.
3483         (make_backtrace_options_def_group): New.
3484         (backtrace_command): Process command options with
3485         gdb::option::process_options.
3486         (backtrace_command_completer): New.
3487         (_initialize_stack): Extend "backtrace"'s help to mention
3488         supported options.  Install completer for "backtrace".
3489         Install some settings commands with add_setshow_cmds_for_options.
3490
3491 2019-06-13  Pedro Alves  <palves@redhat.com>
3492
3493         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3494         and that "set/show print raw frame-arguments" are now deprecated.
3495
3496         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3497         command.
3498         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3499         * stack.c (_initialize_stack): Install "set/show print
3500         raw-frame-arguments", and deprecate "set/show print raw
3501         frame-arguments".
3502         * valprint.c (_initialize_valprint): Deprecate "set/show print
3503         raw".
3504
3505 2019-06-13  Pedro Alves  <palves@redhat.com>
3506
3507         * compile/compile.c (struct compile_options): New.
3508         (compile_flag_option_def, compile_command_option_defs)
3509         (make_compile_options_def_group): New.
3510         (compile_file_command): Handle options with
3511         gdb::option::process_options.
3512         (compile_file_command_completer): New function.
3513         (compile_code_command): Handle options with
3514         gdb::option::process_options.
3515         (compile_code_command_completer): New function.
3516         (_initialize_compiler): Install completers for "compile code" and
3517         "compile file".  Mention available options in "compile code" and
3518         "compile code"'s help.
3519         * completer.c (advance_to_completion_word): New, factored out from
3520         ...
3521         (advance_to_expression_complete_word_point): ... this.
3522         (advance_to_filename_complete_word_point): New.
3523         * completer.h (advance_to_filename_complete_word_point): New
3524         declaration.
3525
3526 2019-06-13  Pedro Alves  <palves@redhat.com>
3527
3528         * compile/compile.c: Include "cli/cli-option.h".
3529         (compile_print_value): Scope data pointer is now a
3530         value_print_options pointer; adjust.
3531         (compile_print_command): Process options.  Scope data pointer is
3532         now a value_print_options pointer; adjust.
3533         (_initialize_compile): Update "compile print"'s help to include
3534         supported options.  Install a completer for "compile print".
3535         * cp-valprint.c (show_vtblprint, show_objectprint)
3536         (show_static_field_print): Delete.
3537         (_initialize_cp_valprint): Don't install "set print
3538         static-members", "set print vtbl", "set print object" here.
3539         * printcmd.c: Include "cli/cli-option.h" and
3540         "common/gdb_optional.h".
3541         (print_command_parse_format): Rework to fill in a
3542         value_print_options instead of a format_data.
3543         (print_value): Change parameter type from format_data pointer to
3544         value_print_options reference.  Adjust.
3545         (print_command_1): Process options.  Adjust to pass down a
3546         value_print_options.
3547         (print_command_completer): New.
3548         (_initialize_printcmd): Install print_command_completer as
3549         handle_brkchars completer for the "print" command.  Update
3550         "print"'s help to include supported options.
3551         * valprint.c: Include "cli/cli-option.h".
3552         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3553         here from cp-valprint.c.
3554         (boolean_option_def, uinteger_option_def)
3555         (value_print_option_defs, make_value_print_options_def_group):
3556         New.  Use gdb::option::add_setshow_cmds_for_options to install
3557         "set print elements", "set print null-stop", "set print repeats",
3558         "set print pretty", "set print union", "set print array", "set
3559         print address", "set print symbol", "set print array-indexes".
3560         * valprint.h: Include <string> and "cli/cli-option.h".
3561         (make_value_print_options_def_group): Declare.
3562         (print_value): Change parameter type from format_data pointer to
3563         value_print_options reference.
3564         (print_command_completer): Declare.
3565
3566 2019-06-13  Pedro Alves  <palves@redhat.com>
3567
3568         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3569         (COMMON_SFILES): Add maint-test-settings.c.
3570         * cli/cli-decode.c (boolean_enums): New global, factored out from
3571         ...
3572         (add_setshow_boolean_cmd): ... here.
3573         * cli/cli-decode.h (boolean_enums): Declare.
3574         * cli/cli-option.c: New file.
3575         * cli/cli-option.h: New file.
3576         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3577         factored out from ...
3578         (parse_cli_boolean_value(const char *)): ... this.
3579         (is_unlimited_literal): Change parameter type to pointer to
3580         pointer.  Adjust and advance ARG pointer.
3581         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3582         (parse_cli_var_enum): New, factored out from ...
3583         (do_set_command): ... this.  Adjust.
3584         * cli/cli-setshow.h (parse_cli_boolean_value)
3585         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3586         (parse_cli_var_enum): Declare.
3587         * cli/cli-utils.c: Include "cli/cli-option.h".
3588         (get_ulongest): New.
3589         * cli/cli-utils.h (get_ulongest): Declare.
3590         (check_for_argument): New overloads.
3591         * maint-test-options.c: New file.
3592
3593 2019-06-13  Pedro Alves  <palves@redhat.com>
3594
3595         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3596         parse a range if "-" is at the end of the string.
3597
3598 2019-06-13  Pedro Alves  <palves@redhat.com>
3599
3600         * cli/cli-setshow.c (parse_auto_binary_operation)
3601         (parse_cli_boolean_value): Don't allow "o".
3602
3603 2019-06-13  Pedro Alves  <palves@redhat.com>
3604
3605         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3606         * NEWS: Mention maint test-settings KIND.
3607         * maint-test-settings.c: New file.
3608
3609 2019-06-13  Pedro Alves  <palves@redhat.com>
3610
3611         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3612         completer.
3613         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3614         "set" completers.
3615
3616 2019-06-13  Pedro Alves  <palves@redhat.com>
3617
3618         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3619         after item.
3620
3621 2019-06-13  Pedro Alves  <palves@redhat.com>
3622
3623         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3624
3625 2019-06-13  Pedro Alves <palves@redhat.com>
3626
3627         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3628         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3629         call.
3630         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3631         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3632         calls.
3633         (check_for_argument): Skip spaces after argument.
3634
3635 2019-06-13  Pedro Alves  <palves@redhat.com>
3636
3637         * thread.c (thread_apply_command): Adjust TID parsing.
3638         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3639         detected before end of string.
3640         (tid_is_in_list): Error out if LIST is invalid.
3641
3642 2019-06-13  Pedro Alves  <palves@redhat.com>
3643
3644         * completer.c (complete_line_internal_1): Rewind completion word
3645         point.
3646         (completion_tracker::advance_custom_word_point_by): Change
3647         parameter type to int.
3648         * completer.h (completion_tracker::advance_custom_word_point_by):
3649         Likewise.
3650
3651 2019-06-13  Pedro Alves  <palves@redhat.com>
3652
3653         * completer.c (advance_to_completion_word): Handle delimiters.
3654
3655 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3656
3657         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3658
3659 2019-06-11  Tom Tromey  <tom@tromey.com>
3660
3661         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3662         (xmalloc_failed): Move to alloc.c.
3663         * alloc.c: New file.
3664         * Makefile.in (COMMON_SFILES): Add alloc.c.
3665
3666 2019-06-11  Tom Tromey  <tom@tromey.com>
3667
3668         * nat/linux-waitpid.c: Don't include server.h.
3669         (linux_debug): Remove.
3670         (my_waitpid): Update.
3671
3672 2019-06-11  Tom Tromey  <tromey@adacore.com>
3673
3674         * infcall.c (_initialize_infcall): Remove trailing newline from
3675         help.
3676         * user-regs.c (_initialize_user_regs): Remove trailing newline
3677         from help.
3678         * typeprint.c (_initialize_typeprint): Remove trailing newline
3679         from help.
3680         * reverse.c (_initialize_reverse): Remove trailing newlines from
3681         help.
3682         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3683         from help.
3684         * language.c (add_set_language_command): Remove trailing newline
3685         from help.
3686         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3687         help.
3688         * disasm.c (_initialize_disasm): Remove trailing newline from
3689         help.
3690         * top.c (init_main): Remove trailing newline from help.
3691         * interps.c (_initialize_interpreter): Remove trailing newline
3692         from help.
3693         * btrace.c (_initialize_btrace): Remove trailing newlines from
3694         help.
3695         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3696         from help.
3697         * python/python.c (_initialize_python): Remove trailing newline
3698         from help.
3699         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3700         help.
3701         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3702         from help.  Reformat some text.
3703         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3704         from help.
3705         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3706         newline from help.
3707
3708 2019-06-11  Tom Tromey  <tromey@adacore.com>
3709
3710         * darwin-nat.c (darwin_decode_exception_message)
3711         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3712
3713 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3714
3715         * valops.c (value_slice): Check for not allocated or not
3716         associated values.
3717
3718 2019-06-10  Tom de Vries  <tdevries@suse.de>
3719
3720         PR gdb/24618
3721         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3722         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3723         invalid.
3724
3725 2019-06-10  Tom de Vries  <tdevries@suse.de>
3726
3727         PR gdb/24611
3728         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3729         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3730
3731 2019-06-10  Tom de Vries  <tdevries@suse.de>
3732
3733         PR symtab/24545
3734         * symtab.c (struct demangled_name_entry): Add language field.
3735         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3736         static minimal symbol".  Set and use language field.
3737
3738 2019-06-10  Tom Tromey  <tromey@adacore.com>
3739
3740         * ada-lang.c (_initialize_ada_language): Update help text.
3741
3742 2019-06-10  Tom Tromey  <tromey@adacore.com>
3743
3744         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3745         with a newline.
3746         * guile/guile.c (handle_boot_error): Don't end warning with a
3747         newline.
3748         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3749         warning with a newline.
3750         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3751         newline.
3752         (s12z_frame_cache): Likewise.
3753         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3754         a newline.
3755         * solib-svr4.c (disable_probes_interface): Don't end warning with
3756         a newline.
3757         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3758         newline.
3759         * python/python.c (do_finish_initialization): Don't end warning
3760         with a newline.
3761
3762 2019-06-10  Tom Tromey  <tom@tromey.com>
3763
3764         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3765         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3766         gdbpy_enter.
3767
3768 2019-06-10  Tom Tromey  <tromey@adacore.com>
3769
3770         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3771         data.
3772         (elf_new_init): Don't call stabsread_new_init.
3773         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3774         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3775         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3776
3777 2019-06-10  Tom de Vries  <tdevries@suse.de>
3778
3779         PR symtab/16264
3780         PR symtab/24517
3781         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3782
3783 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3784
3785         * source.c (find_and_open_source): Also rewrite relative file
3786         names.
3787
3788 2019-04-26  Amos Bird  <amosbird@gmail.com>
3789
3790         * annotate.c (annotate_thread_exited): Add "thread-exited"
3791         annotation.
3792
3793 2019-06-06  Tom Tromey  <tromey@adacore.com>
3794
3795         * maint.h (class scoped_command_stats): Use
3796         DISABLE_COPY_AND_ASSIGN.
3797         <print_time>: New method.
3798         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3799         print_time.
3800         (scoped_command_stats::print_time): New method.
3801
3802 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3803
3804         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3805         instructions of lengths 6 or 8 bytes.
3806
3807 2019-06-04  Pedro Alves  <palves@redhat.com>
3808
3809         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3810
3811         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3812         * breakpoint.c (condition_completer): Likewise.
3813         * cli/cli-dump.c (scan_expression): Likewise.
3814         * common/filestuff.c (mkdir_recursive): Likewise.
3815         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3816         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3817         (gdb_abspath): Likewise.
3818         * compile/compile-cplus-types.c
3819         (compile_cplus_instance::decl_name): Likewise.
3820         * completer.c (complete_explicit_location):
3821         (signal_completer, reg_or_group_completer_1): Likewise.
3822         * cp-support.c (cp_remove_params_if_any): Likewise.
3823         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3824         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3825         * infcmd.c (strip_bg_char): Likewise.
3826         * linespec.c (copy_token_string): Likewise.
3827         * mi/mi-main.c (output_cores): Likewise.
3828         * psymtab.c (psymtab_search_name):
3829         * symfile.c (test_set_ext_lang_command): Likewise.
3830         * target.c (target_fileio_read_stralloc): Likewise.
3831         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3832         * value.c (complete_internalvar): Likewise.
3833
3834 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3835
3836         Add objfile property to gdb.Type.
3837         * NEWS: Mention Python API addition.
3838         * python/py-type.c (typy_get_objfile): New method.
3839
3840 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3841
3842         * NEWS: Mention the new set|show style [title|highlight].
3843         Mention changes to "show style", "help" and "apropos".
3844
3845 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3846
3847         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3848         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3849         instead of print_help_for_command.
3850         (print_doc_of_command): New function.
3851         (help_list): Add 'apropos -v word' suggestion.
3852         (print_help_for_command): Style the command name using title style.
3853         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3854         (_initialize_cli_cmds): Describe -v in apropos_command help.
3855
3856 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3857
3858         * cli/cli-style.h (cli_style_option): Add name in constructor,
3859         add m_name class member, add constructor with intensity,
3860         add name class function.
3861         (cli_style_option::add_setshow_commands): Remove name argument.
3862         (highlight_style, title_style): New styles.
3863         * cli/cli-style.c (do_show): New function that shows a style
3864         characteristic styling the style name with itself.
3865         (set_style_name): New function.
3866         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3867         Update all callers according to the changes in cli/cli-style.h.
3868         * utils.h (fputs_highlighted): New function.
3869         * utils.c (fputs_highlighted): Likewise.
3870
3871 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3872
3873         * NEWS: Mention new pipe command and new convenience variables.
3874
3875 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3876
3877         * cli/cli-cmds.c (pipe_command): New function.
3878         (_initialize_cli_cmds): Call add_com for pipe_command.
3879         Define | as an alias for pipe.
3880         (exit_status_set_internal_vars): New function.
3881         (shell_escape): Call exit_status_set_internal_vars.
3882         cli/cli-decode.c (find_command_name_length): Recognize | as
3883         a single character command.
3884
3885 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3886
3887         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3888         top.c (execute_command_to_ui_file): New function, mostly a copy
3889         of execute_command_to_string.
3890         (execute_command_to_string): Implement by calling
3891         execute_command_to_ui_file.
3892
3893 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3894
3895         * top.h (saved_command_line): Remove declaration.
3896         * top.c (previous_saved_command_line, previous_repeat_arguments):
3897         New variables.
3898         (saved_command_line): Make static, define together with other
3899         'repeat variables'.
3900         (dont_repeat): Clear repeat_arguments.
3901         (repeat_previous, get_saved_command_line, save_command_line):
3902         New functions.
3903         (gdb_init): Initialize saved_command_line
3904         and previous_saved_command_line.
3905         * main.c (captured_main_1): Remove saved_command_line initialization.
3906         * event-top.c (handle_line_of_input): Update to use
3907         the new 'repeat' related functions instead of direct access to
3908         saved_command_line.
3909         * command.h (repeat_previous, get_saved_command_line,
3910         save_command_line): New declarations.
3911         (dont_repeat): Add comment.
3912
3913 2019-05-30  Tom Tromey  <tromey@adacore.com>
3914
3915         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3916         Fix comment.
3917         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3918
3919 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3920
3921         PR cli/24587
3922         * completer.c (complete): Initialize variable word.
3923
3924 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3925
3926         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3927         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3928         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3929         'body' is NULL to the outter 'if', protecting the '!is_define'
3930         situation as well.
3931
3932 2019-05-29  Tom Tromey  <tromey@adacore.com>
3933
3934         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3935         (dwarf_unknown): New function.
3936         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3937         (dwarf_type_encoding_name): Use dwarf_unknown.
3938
3939 2019-05-29  Tom Tromey  <tromey@adacore.com>
3940
3941         PR c++/20020:
3942         * cp-valprint.c (cp_print_value_fields): Call
3943         cp_print_static_field inside "try".
3944
3945 2019-05-29  Tom Tromey  <tromey@adacore.com>
3946
3947         * inflow.c (struct terminal_info): Add default operator=.
3948         * configure: Rebuild.
3949         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3950         -Wdeprecated-copy-dtor, -Wredundant-move.
3951
3952 2019-05-29  Tom Tromey  <tromey@adacore.com>
3953
3954         * NEWS: Add entry.
3955         * infcmd.c (print_return_value_1): Handle finish_print
3956         option.
3957         (show_print_finish): New function.
3958         (_initialize_infcmd): Add "set/show print finish" commands.
3959         * valprint.c (user_print_options): Initialize new member.
3960         * valprint.h (struct value_print_options) <finish_print>: New
3961         member.
3962
3963 2019-05-28  Tom Tromey  <tromey@adacore.com>
3964
3965         * ada-lang.c (ada_remove_Xbn_suffix)
3966         (find_old_style_renaming_symbol)
3967         (parse_old_style_renaming): Remove.
3968         (ada_find_renaming_symbol): Don't call
3969         find_old_style_renaming_symbol.
3970         (ada_is_renaming_symbol): Rename from
3971         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3972         bool.  Now static.
3973         (ada_read_var_value): Update and simplify.
3974         * ada-exp.y (write_var_or_type): Remove old code.
3975
3976 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3977
3978         * event-top.c: Remove include comment.
3979         * inflow.c (class scoped_ignore_sigttou): Move from here...
3980         * inflow.h (class scoped_ignore_sigttou): ...to here.
3981         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3982         * top.c:  Remove include comment.
3983
3984 2019-05-27  Tom Tromey  <tom@tromey.com>
3985
3986         * NEWS: Fix typo.
3987
3988 2019-05-22  Tom Tromey  <tromey@adacore.com>
3989
3990         * target.c (target_follow_exec): Constify parameter.
3991         * target-delegates.c: Rebuild.
3992         * remote.c (remote_target::follow_exec): Constify parameter.
3993         * infrun.c (follow_exec): Constify parameter.
3994         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3995         (target_follow_exec): Likewise.
3996
3997 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3998
3999         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4000         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4001
4002 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4003
4004         * NEWS: Add debugredirect and testsuite sections.
4005
4006 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
4007
4008         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4009         target descriptions using exclusively floating point register name
4010         aliases.
4011
4012 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
4013
4014         PR gdb/18644:
4015         * f-lang.c (build_fortran_types): Handle the case where
4016         gdbarch_floatformat_for_type returns a nullptr.
4017
4018 2019-05-21  Tom de Vries  <tdevries@suse.de>
4019
4020         PR cli/24587
4021         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4022
4023 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4024
4025         PR gdb/18644:
4026         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4027         16-byte floats.
4028         * i386-tdep.c (i386_floatformat_for_type): Use
4029         floatformats_ia64_quad for the 16-byte floating point component
4030         within a fortran 32-byte complex number.
4031
4032 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4033
4034         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4035         delete default constructor.
4036         (find_partial_die): Update to return const struct.
4037         (partial_die_parent_scope): Move variable declaration into scope
4038         of its use and change its type to auto.
4039         (guess_partial_die_structure_name): Likewise.
4040         (partial_die_info::fixup): Likewise.
4041
4042 2019-05-17  Tom Tromey  <tromey@adacore.com>
4043
4044         * source.c (find_and_open_source): Remove cast.
4045
4046 2019-05-17  Tom Tromey  <tromey@adacore.com>
4047
4048         * annotate.c (annotate_source): Make "filename" const.
4049         * annotate.h (annotate_source): Use const.
4050
4051 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4052
4053         * disasm.c (set_disassembler_options): Send errors to stderr.
4054
4055 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4056
4057         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4058         (cli_interp_base::set_logging): Check debug_redirect.
4059         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4060         * cli/cli-logging.c (debug_redirect): Add static variable.
4061         (pop_output_files): Add default param.
4062         (handle_redirections): Print debug setting.
4063         (show_logging_command): Likewise.
4064         (_initialize_cli_logging): Add debugredirect command.
4065         * interps.c (current_interp_set_logging): Add debug_redirect
4066         parameter.
4067         * interps.h (set_logging): Add debug_redirect parameter.
4068         (current_interp_set_logging): Likewise.
4069         * mi/mi-common.h: Likewise.
4070         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4071
4072 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4073             Tom Tromey  <tromey@adacore.com>
4074
4075         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4076         directly.
4077         * cli/cli-interp.h (make_logging_output): Remove declaration.
4078         * cli/cli-logging.c (make_logging_output): Remove function.
4079         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4080         directly.
4081         * ui-file.c (tee_file::tee_file): Remove bools.
4082         (tee_file::~tee_file): Remove deletes.
4083         * ui-file.h (tee_file): Remove bools.
4084
4085 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
4086
4087         * mi/mi-cmds.h (mi_cmd_complete): New function.
4088         * mi/mi-main.c (mi_cmd_complete): Likewise.
4089         * mi/mi-cmds.c: Define new MI command -complete.
4090         * NEWS: Mention new -complete command.
4091
4092 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
4093
4094         * completer.h (complete): New function.
4095         * completer.c (complete): Likewise.
4096         * cli/cli-cmds.c: (complete_command): Update to use new complete()
4097         function defined in completer.h.
4098
4099 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
4100
4101         * MAINTAINERS (Write After Approval): Add myself.
4102
4103 2019-05-17  Tom de Vries  <tdevries@suse.de>
4104
4105         PR gdb/24094
4106         * dwarf2read.c (struct cu_partial_die_info): New struct.
4107         (find_partial_die): Return cu_partial_die_info.
4108         (partial_die_parent_scope, guess_partial_die_structure_name)
4109         (partial_die_info::fixup): Handle new return type of find_partial_die.
4110
4111 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4112
4113         * stap-probe.c (stap_parse_register_operand): Make "regname" an
4114         "std::string", simplifying the algorithm.
4115
4116 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4117
4118         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4119         (stap_static_probe_ops::get_probes): Likewise.
4120
4121 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4122
4123         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4124         '-')" and "else if".
4125         (stap_parse_single_operand): Join checks for
4126         "gdbarch_stap_parse_special_token_p" and
4127         "gdbarch_stap_parse_special_token" in the same "if" statement.
4128         Invert check when verifying for operation on register
4129         displacement.
4130
4131 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4132
4133         * stap-probe.c (stap_get_opcode): Update comment.
4134         (stap_get_expected_argument_type): Likewise.
4135         (handle_stap_probe): Likewise.
4136
4137 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4138
4139         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4140         return type to 'bool'.  Adjust comment.  Use 'bool' when
4141         appropriate.
4142         (i386_stap_parse_special_token_three_arg_disp): Likewise.
4143         * stap-probe.c (stap_parse_argument_1): Likewise.
4144         (stap_is_operator): Likewise.
4145         (stap_is_generic_prefix): Likewise.
4146         (stap_is_register_prefix): Likewise.
4147         (stap_is_register_indirection_prefix): Likewise.
4148         (stap_is_integer_prefix): Likewise.
4149         (stap_generic_check_suffix): Likewise.
4150         (stap_check_integer_suffix): Likewise.
4151         (stap_check_register_suffix): Likewise.
4152         (stap_check_register_indirection_suffix): Likewise.
4153         (stap_parse_register_operand): Likewise.
4154         (stap_parse_single_operand): Likewise.
4155         (stap_parse_argument_1): Likewise.
4156         (stap_probe::get_argument_count): Likewise.
4157         (stap_is_operator): Likewise.
4158
4159 2019-05-16  Tom Tromey  <tromey@adacore.com>
4160
4161         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
4162         keyword to foreach.
4163
4164 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
4165
4166         * linux-thread-db.c (try_thread_db_load_1): Change return type
4167         to bool.
4168         (try_thread_db_load): Likewise.
4169         (try_thread_db_load_from_pdir_1): Likewise.
4170         (try_thread_db_load_from_pdir): Likewise.
4171         (try_thread_db_load_from_sdir): Likewise.
4172         (try_thread_db_load_from_dir): Likewise.
4173         (thread_db_load_search): Likewise.
4174         (has_libpthread): Likewise.
4175         (thread_db_load): Likewise.
4176
4177 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
4178
4179         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4180         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4181         NULL, and complain/return if that's the case.
4182
4183 2019-05-15  John Darrington <john@darrington.wattle.id.au>
4184
4185         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4186         (advance, posn, abstract_read_memory): New functions.
4187         [struct mem_read_abstraction]: New struct.
4188         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4189
4190 2019-05-14  Tom Tromey  <tromey@adacore.com>
4191
4192         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4193         value is not lval_memory.
4194
4195 2019-05-14  Tom Tromey  <tromey@adacore.com>
4196
4197         * solib.c (info_sharedlibrary_command): Style the file name.
4198
4199 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
4200
4201         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4202         (aarch64_vnv_type): Likewise.
4203         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4204         * common/tdesc.c: Likewise.
4205         * common/tdesc.h (enum tdesc_type_kind): Likewise.
4206         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
4207         * features/aarch64-fpu.xml: Add ieee half view.
4208         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
4209         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
4210         * gdbtypes.h (struct builtin_type): Likewise.
4211         (struct objfile_type): Likewise.
4212
4213 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
4214
4215         * language.c (language_sniff_from_mangled_name): Fix "langauge"
4216         typo.
4217         * location.h (string_to_event_location): Likewise.
4218
4219 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
4220
4221         GDB 8.3 released.
4222
4223 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4224
4225         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4226         New variable declaration.
4227         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
4228         New variable.
4229         (print_one_breakpoint): Use ui_out::test_flags and new global
4230         variable to compute use_fixed_output.
4231         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
4232         Remove.
4233         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4234         (mi_multi_location_breakpoint_output_fixed): Remove.
4235         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4236         new variable.
4237         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4238         fix_multi_location_breakpoint_output flag if version >= 3.
4239         * ui-out.h (enum ui_out_flag)
4240         <fix_multi_location_breakpoint_output>: New enumerator.
4241
4242 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4243
4244         * contrib/cc-with-tweaks.sh: Validate dwz's work.
4245
4246 2019-05-10  Tom Tromey  <tromey@adacore.com>
4247
4248         * ada-lang.c (catch_ada_completer): New function.
4249         (_initialize_ada_language): Use it.
4250
4251 2019-05-10  Tom Tromey  <tromey@adacore.com>
4252
4253         * thread.c (print_thread_info): Make "requested_threads" const.
4254         * gdbthread.h (print_thread_info): Make "requested_threads"
4255         const.
4256         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4257         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4258
4259 2019-05-08  Tom Tromey  <tom@tromey.com>
4260
4261         * gdbtypes.c (objfile_type_data): Change type.
4262         (objfile_type, _initialize_gdbtypes): Update.
4263
4264 2019-05-08  Tom Tromey  <tom@tromey.com>
4265
4266         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4267         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4268         (_initialize_dwarf2_frame): Update.
4269
4270 2019-05-08  Tom Tromey  <tom@tromey.com>
4271
4272         * objc-lang.c (objc_objfile_data): Change type.
4273         (find_methods): Update.
4274         (_initialize_objc_lang): Remove.
4275
4276 2019-05-08  Tom Tromey  <tom@tromey.com>
4277
4278         * stabsread.c (rs6000_builtin_type_data): Change type.
4279         (rs6000_builtin_type, _initialize_stabsread): Update.
4280
4281 2019-05-08  Tom Tromey  <tom@tromey.com>
4282
4283         * mips-tdep.c (mips_pdr_data): Remove.
4284         (_initialize_mips_tdep): Update.
4285
4286 2019-05-08  Tom Tromey  <tom@tromey.com>
4287
4288         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4289         (hppa_init_objfile_priv_data, read_unwind_info)
4290         (find_unwind_entry, _initialize_hppa_tdep): Update.
4291
4292 2019-05-08  Tom Tromey  <tom@tromey.com>
4293
4294         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4295         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
4296         on obstack.
4297         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4298
4299 2019-05-08  Tom Tromey  <tom@tromey.com>
4300
4301         * mdebugread.c (basic_type_data): Change type.
4302         (basic_type, _initialize_mdebugread): Update.
4303
4304 2019-05-08  Tom Tromey  <tom@tromey.com>
4305
4306         * common/gdb_unique_ptr.h (struct noop_deleter): New.
4307
4308 2019-05-08  Tom Tromey  <tom@tromey.com>
4309
4310         * nto-tdep.c (nto_inferior_data_reg): Change type.
4311         (nto_inferior_data): Update.
4312         (nto_inferior_data_cleanup, nto_new_inferior_data)
4313         (_initialize_nto_tdep): Remove.
4314         * nto-tdep.h (struct nto_inferior_data): Add initializers.
4315
4316 2019-05-08  Tom Tromey  <tom@tromey.com>
4317
4318         * ada-lang.c (struct ada_inferior_data): Add initializers.
4319         (ada_inferior_data): Change type.
4320         (ada_inferior_data_cleanup): Remove.
4321         (get_ada_inferior_data, ada_inferior_exit)
4322         (struct ada_pspace_data): Add initializers, destructor.
4323         (ada_pspace_data_handle): Change type.
4324         (get_ada_pspace_data): Update.
4325         (ada_pspace_data_cleanup): Remove.
4326
4327 2019-05-08  Tom Tromey  <tom@tromey.com>
4328
4329         * coffread.c (struct coff_symfile_info): Add initializers.
4330         (coff_objfile_data_key): Move lower.  Change type.
4331         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4332         Update.
4333         (coff_free_info): Remove.
4334
4335 2019-05-08  Tom Tromey  <tom@tromey.com>
4336
4337         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4338         (fbsd_pspace_data_handle): Move lower.  Change type.
4339         (get_fbsd_pspace_data): Update.
4340         (fbsd_pspace_data_cleanup): Remove.
4341         (_initialize_fbsd_tdep): Update.
4342
4343 2019-05-08  Tom Tromey  <tom@tromey.com>
4344
4345         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4346         (get_ada_tasks_pspace_data): Update.
4347         (ada_tasks_pspace_data_cleanup): Remove.
4348         (_initialize_tasks): Update.
4349         (ada_tasks_inferior_data_handle): Change type.
4350         (get_ada_tasks_inferior_data): Update.
4351         (ada_tasks_inferior_data_cleanup): Remove.
4352         (struct ada_tasks_pspace_data): Add initializers.
4353
4354 2019-05-08  Tom Tromey  <tom@tromey.com>
4355
4356         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4357         * symfile-debug.c (debug_sym_get_probes): Change type.
4358         * stap-probe.c (handle_stap_probe):
4359         (stap_static_probe_ops::get_probes): Change type.
4360         * probe.h (class static_probe_ops) <get_probes>: Change type.
4361         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4362         (parse_probes_in_pspace): Update.
4363         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4364         Update.
4365         (any_static_probe_ops::get_probes): Change type.
4366         * elfread.c (elfread_data): New typedef.
4367         (probe_key): Change type.
4368         (elf_get_probes): Likewise.  Update.
4369         (probe_key_free): Remove.
4370         (_initialize_elfread): Update.
4371         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4372         Change type.
4373         (dtrace_process_dof_probe, dtrace_process_dof)
4374         (dtrace_static_probe_ops::get_probe): Change type.
4375
4376 2019-05-08  Tom Tromey  <tom@tromey.com>
4377
4378         * xcoffread.c (struct xcoff_symfile_info): Rename from
4379         coff_symfile_info.  Add initializers.
4380         (xcoff_objfile_data_key): Move lower.  Change type.
4381         (XCOFF_DATA): Rewrite.
4382         (xcoff_free_info): Remove.
4383         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4384         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4385         (xcoff_initial_scan): Update.
4386
4387 2019-05-08  Tom Tromey  <tom@tromey.com>
4388
4389         * solib-svr4.c (struct svr4_info): Add initializers and
4390         destructor.
4391         <probes_table>: Now an htab_up.
4392         (solib_svr4_pspace_data): Change type.
4393         (free_probes_table): Simplify.
4394         (~svr4_info): Rename from svr4_pspace_data_cleanup.
4395         (get_svr4_info, probes_table_htab_remove_objfile_probes)
4396         (probes_table_remove_objfile_probes, register_solib_event_probe)
4397         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4398         (_initialize_svr4_solib): Update.
4399
4400 2019-05-08  Tom Tromey  <tom@tromey.com>
4401
4402         * remote.c (remote_pspace_data): Change type.
4403         (remote_pspace_data_cleanup): Remove.
4404         (get_remote_exec_file, set_pspace_remote_exec_file)
4405         (_initialize_remote): Update.
4406
4407 2019-05-08  Tom Tromey  <tom@tromey.com>
4408
4409         * breakpoint.c (breakpoint_objfile_key): Change type.
4410         (get_breakpoint_objfile_data): Update.
4411         (free_breakpoint_objfile_data): Remove.
4412         (_initialize_breakpoint): Update.
4413
4414 2019-05-08  Tom Tromey  <tom@tromey.com>
4415
4416         * linux-tdep.c (struct linux_info): Add initializers.
4417         (linux_inferior_data): Move.  Change type.
4418         (invalidate_linux_cache_inf): Update.
4419         (linux_inferior_data_cleanup): Remove.
4420         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4421
4422 2019-05-08  Tom Tromey  <tom@tromey.com>
4423
4424         * auxv.c (auxv_inferior_data): Move.  Change type.
4425         (auxv_inferior_data_cleanup): Remove.
4426         (invalidate_auxv_cache_inf): Rewrite.
4427         (get_auxv_inferior_data, _initialize_auxv): Update.
4428
4429 2019-05-08  Tom Tromey  <tom@tromey.com>
4430
4431         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4432         (symfile_debug_objfile_data_key): Change type.
4433         (symfile_debug_installed, debug_qf_has_symbols)
4434         (debug_qf_find_last_source_symtab)
4435         (debug_qf_forget_cached_source_info)
4436         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4437         (debug_qf_print_stats, debug_qf_dump)
4438         (debug_qf_expand_symtabs_for_function)
4439         (debug_qf_expand_all_symtabs)
4440         (debug_qf_expand_symtabs_with_fullname)
4441         (debug_qf_map_matching_symbols)
4442         (debug_qf_expand_symtabs_matching)
4443         (debug_qf_find_pc_sect_compunit_symtab)
4444         (debug_qf_map_symbol_filenames)
4445         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4446         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4447         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4448         (debug_sym_read_linetable, debug_sym_relocate): Update.
4449         (symfile_debug_free_objfile): Remove.
4450         (install_symfile_debug_logging, _initialize_symfile_debug):
4451         Update.
4452
4453 2019-05-08  Tom Tromey  <tom@tromey.com>
4454
4455         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4456         allocate_on_obstack.
4457         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4458         (get_dwarf2_per_objfile): Update.
4459         (set_dwarf2_per_objfile): Remove.
4460         (dwarf2_has_info, dwarf2_get_section_info): Update.
4461         (dwarf2_free_objfile): Remove.
4462         (_initialize_dwarf2_read): Update.
4463
4464 2019-05-08  Tom Tromey  <tom@tromey.com>
4465
4466         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4467         initializers.
4468         <unsupported_script_warning_printed,
4469         script_not_found_warning_printed>: Now bool.
4470         (auto_load_pspace_data): Change type.
4471         (~auto_load_pspace_info): Rename from
4472         auto_load_pspace_data_cleanup.
4473         (get_auto_load_pspace_data, init_loaded_scripts_info)
4474         (clear_section_scripts, maybe_print_unsupported_script_warning)
4475         (maybe_print_script_not_found_warning, _initialize_auto_load):
4476         Update.
4477
4478 2019-05-08  Tom Tromey  <tom@tromey.com>
4479
4480         * objfiles.c (objfile_pspace_info): Add destructor and
4481         initializers.
4482         (objfiles_pspace_data): Change type.
4483         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4484         (get_objfile_pspace_data): Update.
4485         (objfiles_bfd_data): Change type.
4486         (get_objfile_bfd_data): Update.
4487         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4488
4489 2019-05-08  Tom Tromey  <tom@tromey.com>
4490
4491         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4492         Change type.
4493         (get_catch_syscall_inferior_data): Update.
4494         (catch_syscall_inferior_data_cleanup): Remove.
4495         (_initialize_break_catch_syscall): Update.
4496
4497 2019-05-08  Tom Tromey  <tom@tromey.com>
4498
4499         * inflow.c (struct terminal_info): Add destructor and
4500         initializers.
4501         (inflow_inferior_data): Change type.
4502         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4503         (get_inflow_inferior_data, inflow_inferior_exit)
4504         (swap_terminal_info, _initialize_inflow): Update.
4505
4506 2019-05-08  Tom Tromey  <tom@tromey.com>
4507
4508         * target-dcache.c (target_dcache_cleanup): Remove.
4509         (target_dcache_aspace_key): Change type.
4510         (target_dcache_init_p, target_dcache_invalidate)
4511         (target_dcache_get, target_dcache_get_or_init)
4512         (_initialize_target_dcache): Update.
4513         * dcache.h (struct dcache_deleter): New.
4514
4515 2019-05-08  Tom Tromey  <tom@tromey.com>
4516
4517         * symtab.c (struct symbol_cache): Add destructor and
4518         initializers.
4519         (symbol_cache_key): Move.  Change type.
4520         (make_symbol_cache, free_symbol_cache): Remove.
4521         (get_symbol_cache): Update.
4522         (symbol_cache_cleanup): Remove.
4523         (ALL_PSPACES, symbol_cache_flush)
4524         (maintenance_print_symbol_cache)
4525         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4526         Update.
4527
4528 2019-05-08  Tom Tromey  <tom@tromey.com>
4529
4530         * symtab.c (struct main_info): Add destructor and initializers.
4531         (main_progspace_key): Move.  Change type.
4532         (get_main_info): Update.
4533         (main_info_cleanup): Remove.
4534         (_initialize_symtab): Update.
4535
4536 2019-05-08  Tom Tromey  <tom@tromey.com>
4537
4538         * registry.h (DECLARE_REGISTRY): Define the _key class.
4539
4540 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4541
4542         * NEWS: Merge two 'New commands' sections.
4543
4544 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4545
4546         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4547         parameter and use Ada language definition instead.
4548         (ada_val_print_ptr): Remove unused language parameter.
4549         (ada_val_print_num): Remove language parameter and use Ada language
4550         definition instead.
4551         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4552         parameter.
4553         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4554         parameter and use Ada language definition instead.
4555         (ada_val_print_1): Update all ada_val_print_xxx calls.
4556         Remove language parameter.
4557         (ada_val_print): Update ada_val_print_1 call.
4558
4559 2019-05-08  Tom Tromey  <tromey@adacore.com>
4560
4561         * remote.c (remote_hw_watchpoint_limit)
4562         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4563         Now static.
4564
4565 2019-05-08  Tom Tromey  <tromey@adacore.com>
4566
4567         * maint.c (_initialize_maint_cmds): Move initialization code to
4568         remote.c.
4569         (watchdog, show_watchdog): Move to remote.c.
4570         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4571         "watchdog" static.
4572         (_initialize_remote): Move initialization code from maint.c.
4573         * defs.h (watchdog): Don't declare.
4574
4575 2019-05-08  Tom Tromey  <tromey@adacore.com>
4576
4577         * tui/tui-interp.c: Include main.h.
4578         * interps.c: Include main.h.
4579         * main.h (interpreter_p): Declare.
4580         * defs.h (interpreter_p): Don't declare.
4581
4582 2019-05-08  Tom Tromey  <tromey@adacore.com>
4583
4584         * dwarf2loc.c: Include dwarf2read.h.
4585         * defs.h (read_unsigned_leb128): Don't declare.
4586         * dwarf2read.h (read_unsigned_leb128): Declare.
4587
4588 2019-05-08  Tom Tromey  <tromey@adacore.com>
4589
4590         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4591         method.
4592
4593 2019-05-08  Tom Tromey  <tromey@adacore.com>
4594
4595         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4596         when no wrap column is set.
4597
4598 2019-05-08  Tom Tromey  <tromey@adacore.com>
4599
4600         * c-lang.c (c_get_string): Handle non-C-style arrays.
4601
4602 2019-05-08  Tom Tromey  <tromey@adacore.com>
4603
4604         * typeprint.c (print_offset_data::update): Print the bit offset,
4605         not the number of bits remaining.
4606
4607 2019-05-08  Tom Tromey  <tromey@adacore.com>
4608
4609         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4610         padding at end of comment.
4611
4612 2019-05-08  Tom Tromey  <tromey@adacore.com>
4613
4614         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4615         Compare main types.
4616
4617 2019-05-06  Tom Tromey  <tom@tromey.com>
4618
4619         * common/scoped_mmap.c: Include common-defs.h.
4620         * common/scoped_mmap.h: Don't include config.h.
4621
4622 2019-05-04  Tom Tromey  <tom@tromey.com>
4623
4624         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4625         (struct aarch64_call_info): Add initializers.
4626         <si>: Now a std::vector.
4627         (pass_on_stack, aarch64_push_dummy_call): Update.
4628
4629 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4630             Tom Tromey  <tom@tromey.com>
4631
4632         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4633         (ppc_threads): Now a std::vector.  Now static.
4634         (hwdebug_find_thread_points_by_tid)
4635         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4636         Update.
4637
4638 2019-05-04  Tom Tromey  <tom@tromey.com>
4639
4640         * arc-tdep.c (arc_tdesc_init): Return bool.
4641
4642 2019-05-04  Tom Tromey  <tom@tromey.com>
4643
4644         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4645         Use gdb_assert_not_reached.
4646
4647 2019-05-04  Tom Tromey  <tom@tromey.com>
4648
4649         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4650         "false".
4651
4652 2019-05-04  Tom Tromey  <tom@tromey.com>
4653
4654         * arc-tdep.c (arc_tdesc_init): Use bool.
4655
4656 2019-05-04  Tom Tromey  <tom@tromey.com>
4657
4658         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4659
4660 2019-05-04  Tom Tromey  <tom@tromey.com>
4661
4662         * cli/cli-cmds.c (valid_command_p): Return bool.
4663
4664 2019-05-04  Tom Tromey  <tom@tromey.com>
4665
4666         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4667         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4668
4669 2019-05-04  Raul Tambre  <raul@tambre.ee>
4670
4671         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4672         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4673         operator for comparison.
4674
4675 2019-05-04  Tom Tromey  <tom@tromey.com>
4676
4677         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4678         (lookup_partial_symbol, print_partial_symbols)
4679         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4680         (psymbol_compare): Update.
4681         (add_psymbol_to_bcache): Clear the entire psymbol.
4682         (maintenance_check_psymtabs): Update.
4683         * psympriv.h (struct partial_symbol): Don't derive from
4684         general_symbol_info.
4685         <obj_section, unrelocated_address, address,
4686         set_unrelocated_address>: Update.
4687         <ginfo>: New member.
4688         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4689         (debug_names::write_psymbols): Update.
4690
4691 2019-05-04  Tom de Vries  <tdevries@suse.de>
4692
4693         * contrib/cc-with-tweaks.sh: Support -n arg.
4694
4695 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4696
4697         * corelow.c (core_target::detach): Ensure frame cache and
4698         register caches are cleared.
4699         inferior.c (exit_inferior_1): Likewise.
4700
4701 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4702             Tom Tromey  <tom@tromey.com>
4703
4704         * dictionary.c (collate_pending_symbols_by_language): Remove
4705         "struct" from foreach.
4706         * symtab.c (lookup_global_symbol_from_objfile)
4707         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4708         foreach.
4709         * ser-tcp.c (net_open): Remove "struct" from foreach.
4710         * objfiles.c (objfile_relocate, objfile_rebase)
4711         (objfile_has_symbols): Remove "struct" from foreach.
4712         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4713         from foreach.
4714         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4715         foreach.
4716         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4717         "struct" from foreach.
4718         * ada-lang.c (create_excep_cond_exprs)
4719         (ada_exception_catchpoint_cond_string): Remove "struct" from
4720         foreach.
4721
4722 2019-05-03  Tom Tromey  <tromey@adacore.com>
4723
4724         * ada-exp.y (convert_char_literal): Check suffix of each
4725         enumerator.
4726
4727 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4728
4729         PR ada/21406:
4730         * ada-exp.y (yywrap): Don't define.
4731         * ada-lex.l (%option): Add noyywrap
4732         (yywrap): Remove.
4733
4734 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4735
4736         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4737         _WIN32_WINNT to the XP level, unless already defined to a higher
4738         level.
4739
4740         * unittests/parse-connection-spec-selftests.c:
4741         * ser-tcp.c:
4742         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4743         override.
4744
4745         * symfile.c (find_separate_debug_file): Remove colon from the
4746         drive spec of DOS/Windows file names of the target, so that the
4747         file name produced from DEBUGDIR and the target's directory will
4748         be valid on DOS/Windows systems.
4749
4750 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4751
4752         * rust-lang.c (val_print_struct): Handle printing structures
4753         containing strings.
4754
4755 2019-05-02  Tom Tromey  <tromey@adacore.com>
4756
4757         * valarith.c (_initialize_valarith): Remove.
4758
4759 2019-05-01  Tom Tromey  <tromey@adacore.com>
4760
4761         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4762         bitfields.
4763
4764 2019-05-01  Tom Tromey  <tromey@adacore.com>
4765
4766         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4767         for big-endian copies.
4768
4769 2019-04-30  Ali Tamur  <tamur@google.com>
4770         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4771         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4772         (read_3_bytes): New function.
4773
4774 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4775
4776         * windows-nat.c (main_thread_id): Delete.
4777         (handle_output_debug_string): Replace main_thread_id by
4778         current_event.dwThreadId.
4779         (fake_create_process): Likewise.
4780         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4781         Do not set main_thread_id.
4782         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4783         current_event.dwThreadId.
4784         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4785
4786 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4787
4788         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4789         Use current_event.dwThreadId instead of main_thread_id.
4790
4791 2019-04-30  Tom Tromey  <tromey@adacore.com>
4792
4793         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4794         (create_excep_cond_exprs): Iterate over program spaces.
4795         (ada_exception_catchpoint_cond_string): Examine all minimal
4796         symbols for exception types.
4797
4798 2019-04-30  Tom Tromey  <tromey@adacore.com>
4799
4800         PR c++/24470:
4801         * dwarf2read.c (process_structure_scope): Handle case where type
4802         has template parameters but no symbol was created.
4803
4804 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4805             Chris January  <chris.january@arm.com>
4806
4807         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4808         qualifier.
4809         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4810
4811 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4812
4813         * f-typeprint.c (f_print_type): Update rules for printing
4814         whitespace.
4815         (f_type_print_varspec_suffix): Likewise.
4816
4817 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4818             Chris January  <chris.january@arm.com>
4819
4820         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4821         function arguments.
4822
4823 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4824
4825         * f-lang.c (build_fortran_types): Change name of void type to
4826         lower case.
4827         * f-typeprint.c (f_type_print_base): Print the name of the void
4828         type, rather than a fixed string.
4829         * f-valprint.c (f_decorations): Use lower case void string.
4830
4831 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4832             Chris January  <chris.january@arm.com>
4833
4834         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4835         types for Fortran.
4836
4837 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4838             Chris January  <chris.january@arm.com>
4839             David Lecomber  <david.lecomber@arm.com>
4840
4841         * f-exp.y (BINOP_INTRINSIC): New token.
4842         (exp): New parser rule handling BINOP_INTRINSIC.
4843         (f77_keywords): Add new builtin procedures.
4844         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4845         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4846         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4847         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4848         (print_unop_subexp_f): New function.
4849         (print_binop_subexp_f): New function.
4850         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4851         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4852         (dump_subexp_body_f): Likewise.
4853         (operator_check_f): Likewise.
4854         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4855         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4856
4857 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4858
4859         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4860         UNOP_KIND.
4861         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4862         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4863         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4864         (operator_length_f): New fuction.
4865         (print_subexp_f): New function.
4866         (op_name_f): New function.
4867         (dump_subexp_body_f): New function.
4868         (operator_check_f): New function.
4869         (exp_descriptor_f): Replace standard expression handling functions
4870         with new functions.
4871         * gdb/fortran-operator.def: New file.
4872         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4873         * gdb/std-operator.def: Remove UNOP_KIND.
4874
4875 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4876
4877         * std-operator.def: Remove unbalanced, stray double quote
4878         character.
4879
4880 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4881             Chris January  <chris.january@arm.com>
4882             Daniel Everett  <daniel.everett@arm.com>
4883             Nick Forrington  <nick.forrington@arm.com>
4884             Richard Bunt  <richard.bunt@arm.com>
4885
4886         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4887         of depth when printing anonymous structs or unions.
4888         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4889         Don't print either the top-level value, or the children if the
4890         max-depth is exceeded.
4891         (ppscm_print_children): When printing the key of a map, allow one
4892         extra level of depth.
4893         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4894         print either the top-level value, or the children if the max-depth
4895         is exceeded.
4896         (print_children): When printing the key of a map, allow one extra
4897         level of depth.
4898         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4899         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4900         (user_print_options): Initialise max_depth field.
4901         (val_print_scalar_or_string_type_p): New function.
4902         (val_print): Check to see if the max depth has been reached.
4903         (val_print_check_max_depth): Define new function.
4904         (show_print_max_depth): New function.
4905         (_initialize_valprint): Add 'print max-depth' option.
4906         * valprint.h (struct value_print_options) <max_depth>: New field.
4907         (val_print_check_max_depth): Declare new function.
4908         * NEWS: Document new feature.
4909
4910 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4911
4912         * ada-lang.c (ada_language_defn): Initialise new field.
4913         * c-lang.c (c_is_string_type_p): New function.
4914         (c_language_defn): Initialise new field.
4915         (cplus_language_defn): Initialise new field.
4916         (asm_language_defn): Initialise new field.
4917         (minimal_language_defn): Initialise new field.
4918         * c-lang.h (c_is_string_type_p): Declare new function.
4919         * d-lang.c (d_language_defn): Initialise new field.
4920         * f-lang.c (f_is_string_type_p): New function.
4921         (f_language_defn): Initialise new field.
4922         * go-lang.c (go_is_string_type_p): New function.
4923         (go_language_defn): Initialise new field.
4924         * language.c (default_is_string_type_p): New function.
4925         (unknown_language_defn): Initialise new field.
4926         (auto_language_defn): Initialise new field.
4927         * language.h (struct language_defn) <la_is_string_type_p>: New
4928         member variable.
4929         (default_is_string_type_p): Declare new function.
4930         * m2-lang.c (m2_language_defn): Initialise new field.
4931         * objc-lang.c (objc_language_defn): Initialise new field.
4932         * opencl-lang.c (opencl_language_defn): Initialise new field.
4933         * p-lang.c (pascal_is_string_type_p): New function.
4934         (pascal_language_defn): Initialise new field.
4935         * rust-lang.c (rust_is_string_type_p): New function.
4936         (rust_language_defn): Initialise new field.
4937
4938 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4939
4940         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4941         New field.
4942         * ada-lang.c (ada_language_defn): Initialise new field.
4943         * c-lang.c (c_language_defn): Likewise.
4944         (cplus_language_defn): Likewise.
4945         (asm_language_defn): Likewise.
4946         (minimal_language_defn): Likewise.
4947         * d-lang.c (d_language_defn): Likewise.
4948         * f-lang.c (f_language_defn): Likewise.
4949         * go-lang.c (go_language_defn): Likewise.
4950         * language.c (unknown_language_defn): Likewise.
4951         (auto_language_defn): Likewise.
4952         * m2-lang.c (m2_language_defn): Likewise.
4953         * objc-lang.c (objc_language_defn): Likewise.
4954         * opencl-lang.c (opencl_language_defn): Likewise.
4955         * p-lang.c (pascal_language_defn): Likewise.
4956         * rust-lang.c (rust_language_defn): Likewise.
4957
4958 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4959
4960         * ada-lang.c (ada_is_character_type): Change return type to bool.
4961         (ada_is_string_type): Likewise.
4962         * ada-lang.h (ada_is_character_type): Update declaration
4963         (ada_is_string_type): Likewise.
4964
4965 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4966
4967         Support style in 'frame|thread apply'
4968
4969         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4970         * record.c (record_start, record_stop): Update callers of
4971         execute_command_to_string with false.
4972         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4973         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4974         methods.
4975         (class string_file): New constructor with term_out parameter.
4976         Override methods term_out and can_emit_style_escape.  New member
4977         term_out.
4978         (class stdio_file): Override can_emit_style_escape.
4979         (class tee_file): Override term_out and can_emit_style_escape.
4980         * utils.h (can_emit_style_escape): Remove.
4981         * utils.c (can_emit_style_escape): Likewise.
4982         Update all callers of can_emit_style_escape (SOMESTREAM) to
4983         SOMESTREAM->can_emit_style_escape.
4984         * source-cache.c (source_cache::get_source_lines): Likewise.
4985         * stack.c (frame_apply_command_count): Call execute_command_to_string
4986         passing the term_out characteristic of the current gdb_stdout.
4987         * thread.c (thr_try_catch_cmd): Likewise.
4988         * top.c (execute_command_to_string): pass term_out parameter
4989         to construct the string_file for the command output.
4990         * ui-file.c (term_cli_styling): New function (most code moved
4991         from utils.c can_emit_style_escape).
4992         (string_file::string_file, string_file::can_emit_style_escape,
4993         stdio_file::can_emit_style_escape, tee_file::term_out,
4994         tee_file::can_emit_style_escape): New functions.
4995
4996 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4997
4998         * NEWS: Mention the new set|show may-call-functions.
4999         * infcall.c (may_call_functions_p): New variable.
5000         (show_may_call_functions_p): New function.
5001         (call_function_by_hand_dummy): Throws an error if not
5002         may-call-functions.
5003         (_initialize_infcall): Call add_setshow_boolean_cmd for
5004         may-call-functions.
5005
5006 2019-04-25  Keith Seitz  <keiths@redhat.com>
5007
5008         PR c++/24367
5009         * cp-support.c (inspect_type): Don't attempt substitutions
5010         of symbol with the same name.
5011
5012 2019-04-25  Tom Tromey  <tromey@adacore.com>
5013
5014         PR gdb/24475:
5015         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5016         static.
5017
5018 2019-04-25  Tom Tromey  <tromey@adacore.com>
5019
5020         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5021         rvalue reference.
5022         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5023         (gdb_xml_parser::parse): Use std::move.
5024         * python/python-internal.h (gdbpy_convert_exception): Take a const
5025         reference.
5026         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5027         std::move.
5028         * python/py-utils.c (gdbpy_convert_exception): Take a const
5029         reference.
5030         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5031         Use std::move.
5032         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5033         Use std::move.
5034         * mi/mi-main.c (mi_print_exception): Take a const reference.
5035         * main.c (handle_command_errors): Take a const reference.
5036         * linespec.c (parse_linespec): Use std::move.
5037         * infcall.c (run_inferior_call): Use std::move.
5038         (call_function_by_hand_dummy): Use std::move.
5039         * exec.c (try_open_exec_file): Use std::move.
5040         * exceptions.h (exception_print, exception_fprintf)
5041         (exception_print_same): Update.
5042         * exceptions.c (print_exception, exception_print)
5043         (exception_fprintf, exception_print_same): Change parameters to
5044         const reference.
5045         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5046         * common/new-op.c: Use std::move.
5047         * common/common-exceptions.h (struct gdb_exception): Add move
5048         constructor.
5049         (struct gdb_exception_error, struct gdb_exception_quit, struct
5050         gdb_quit_bad_alloc): Change constructor to move constructor.
5051         (throw_exception): Change parameter to rvalue reference.
5052         * common/common-exceptions.c (throw_exception): Take rvalue
5053         reference.
5054         * cli/cli-interp.c (safe_execute_command): Use std::move.
5055         * breakpoint.c (insert_bp_location, location_to_sals): Use
5056         std::move.
5057
5058 2019-04-25  Tom Tromey  <tromey@adacore.com>
5059
5060         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5061         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5062         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5063         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5064         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5065         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5066         guile/scm-value.c: Use unpack.
5067         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5068         gdbscm_gdb_exception.
5069         (gdbscm_throw_gdb_exception): Likewise.
5070         (struct gdbscm_gdb_exception): New.
5071         (unpack): New function.
5072         (gdbscm_wrap): Use unpack.
5073
5074 2019-04-25  Tom Tromey  <tromey@adacore.com>
5075
5076         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5077         (gdb_rl_callback_handler): Use std::move.
5078         * common/common-exceptions.h (struct gdb_exception): Add move
5079         assignment operator.
5080         (throw_exception_sjlj): Change "exception" to const reference.
5081         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5082         (throw_exception_sjlj): Change "exception" to const reference.
5083
5084 2019-04-25  Tom Tromey  <tromey@adacore.com>
5085
5086         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5087         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5088         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5089         Update.
5090         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5091         Update.
5092         * mi/mi-interp.c (mi_interp::exec): Update.
5093         * linespec.c (parse_linespec): Update.
5094         * infcall.c (run_inferior_call): Update.
5095         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5096         * guile/scm-symbol.c (gdbscm_lookup_symbol)
5097         (gdbscm_lookup_global_symbol): Update.
5098         * guile/scm-param.c (gdbscm_parameter_value): Update.
5099         * guile/scm-frame.c (gdbscm_frame_read_register)
5100         (gdbscm_frame_read_var): Update.
5101         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5102         * exec.c (try_open_exec_file): Update.
5103         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5104         (gdb_rl_callback_handler): Update.
5105         * common/common-exceptions.h (exception_none): Don't declare.
5106         * common/common-exceptions.c (exception_none): Don't define.
5107         (struct catcher) <exception>: Update.
5108         * cli/cli-interp.c (safe_execute_command): Update.
5109         * breakpoint.c (insert_bp_location, location_to_sals): Update.
5110
5111 2019-04-25  Ali Tamur  <tamur@google.com>
5112
5113         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5114         (read_attribute_value): Likewise.
5115         (dwarf2_read_addr_index): Update comment.
5116         (read_str_index): Add DW_FORM_strx.
5117         (dwarf2_string_attr): Likewise.
5118         (dwarf2_const_value_attr): Likewise.
5119         (dump_die_shallow): Likewise.
5120         (dwarf2_fetch_constant_bytes): Likewise.
5121         (skip_form_bytes): Likewise.
5122         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5123
5124 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
5125
5126         PR corefiles/11608
5127         PR corefiles/18187
5128         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5129         OFFSET.  Verify if current mapping contains an ELF header.
5130         (linux_find_memory_regions_full): Adjust call to
5131         dump_mapping_p.
5132
5133 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
5134             Kang Li <kanglictf@gmail.com>
5135
5136         PR gdb/21600
5137
5138         * dwarf2-frame.c (read_initial_length): Be consistent about using
5139         unsigned representation of length.
5140         (decode_frame_entry_1): Likewise.  Check for wraparound of
5141         end pointer as well as buffer overflow.
5142
5143 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
5144
5145         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5146         "vq".
5147
5148 2019-04-24  Tom Tromey  <tromey@adacore.com>
5149
5150         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5151
5152 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5153
5154         * s12z-tdep.c (s12z_unwind_pc): Delete.
5155         (s12z_unwind_sp): Delete.
5156         (s12z_gdbarch_init): Don't register deleted functions with
5157         gdbarch.
5158
5159 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5160
5161         * rl78-tdep.c (rl78_unwind_sp): Delete.
5162         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
5163
5164 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5165
5166         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5167         (xstormy16_unwind_pc): Delete.
5168         (xstormy16_dummy_id): Delete.
5169         (xstormy16_gdbarch_init): Don't register deleted functions with
5170         gdbarch.
5171
5172 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5173
5174         * vax-tdep.c (vax_unwind_pc): Delete.
5175         (vax_gdbarch_init): Don't register deleted function with gdbarch.
5176
5177 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5178
5179         * v850-tdep.c (v850_unwind_sp): Delete.
5180         (v850_unwind_pc): Delete.
5181         (v850_dummy_id): Delete.
5182         (v850_gdbarch_init): Don't register deleted functions with
5183         gdbarch.
5184
5185 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5186
5187         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5188         (tilegx_unwind_pc): Delete.
5189         (tilegx_unwind_dummy_id): Delete.
5190         (tilegx_gdbarch_init): Don't register deleted functions with
5191         gdbarch.
5192
5193 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5194
5195         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5196         (tic6x_dummy_id): Delete.
5197         (tic6x_gdbarch_init): Don't register deleted functions with
5198         gdbarch.
5199
5200 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5201
5202         * sparc-tdep.c (sparc_unwind_pc): Delete.
5203         (sparc32_gdbarch_init): Don't register deleted function with
5204         gdbarch.
5205
5206 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5207
5208         * sh-tdep.c (sh_unwind_sp): Delete.
5209         (sh_unwind_pc): Delete.
5210         (sh_dummy_id): Delete.
5211         (sh_gdbarch_init): Don't register deleted functions with
5212         gdbarch.
5213
5214 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5215
5216         * score-tdep.c (score_unwind_sp): Delete.
5217         (score_unwind_pc): Delete.
5218         (score_dummy_id): Delete.
5219         (score_gdbarch_init): Don't register deleted functions with
5220         gdbarch.
5221
5222 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5223
5224         * rx-tdep.c (rx_unwind_pc): Delete.
5225         (rx_unwind_sp): Delete.
5226         (rx_dummy_id): Delete.
5227         (rx_gdbarch_init): Don't register deleted functions with
5228         gdbarch.  Update comment.
5229
5230 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5231
5232         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5233         (rs6000_dummy_id): Delete.
5234         (rs6000_gdbarch_init): Don't register deleted functions with
5235         gdbarch.
5236
5237 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5238
5239         * or1k-tdep.c (or1k_dummy_id): Delete.
5240         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5241
5242 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5243
5244         * nios2-tdep.c (nios2_dummy_id): Delete.
5245         (nios2_unwind_sp): Delete.
5246         (nios2_gdbarch_init): Don't register deleted functions with
5247         gdbarch.
5248
5249 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5250
5251         * nds32-tdep.c (nds32_dummy_id): Delete.
5252         (nds32_unwind_pc): Delete.
5253         (nds32_unwind_sp): Delete.
5254         (nds32_gdbarch_init): Don't register deleted functions with
5255         gdbarch.
5256
5257 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5258
5259         * msp430-tdep.c (msp430_unwind_pc): Delete.
5260         (msp430_unwind_sp): Delete.
5261         (msp430_dummy_id): Delete.
5262         (msp430_gdbarch_init): Don't register deleted functions with
5263         gdbarch.
5264
5265 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5266
5267         * moxie-tdep.c (moxie_unwind_sp): Delete.
5268         (moxie_unwind_pc): Delete.
5269         (moxie_dummy_id): Delete.
5270         (moxie_gdbarch_init): Don't register deleted functions with
5271         gdbarch.
5272
5273 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5274
5275         * mn10300-tdep.c (mn10300_dummy_id): Delete.
5276         (mn10300_unwind_pc): Delete.
5277         (mn10300_unwind_sp): Delete.
5278         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5279         mn10300_unwind_sp.
5280         (mn10300_frame_unwind_init): Don't register deleted functions with
5281         gdbarch.
5282
5283 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5284
5285         * mep-tdep.c (mep_unwind_pc): Delete.
5286         (mep_unwind_sp): Delete.
5287         (mep_dummy_id): Delete.
5288         (mep_gdbarch_init): Don't register deleted functions with
5289         gdbarch.
5290
5291 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5292
5293         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5294         (m68hc11_unwind_sp): Delete.
5295         (m68hc11_gdbarch_init): Don't register deleted functions with
5296         gdbarch.
5297
5298 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5299
5300         * m32r-tdep.c (m32r_unwind_sp): Delete.
5301         (m32r_unwind_pc): Delete.
5302         (m32r_dummy_id): Delete.
5303         (m32r_gdbarch_init): Don't register deleted functions with
5304         gdbarch.
5305
5306 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5307
5308         * m32c-tdep.c (m32c_unwind_pc): Delete.
5309         (m32c_unwind_sp): Delete.
5310         (m32c_dummy_id): Delete.
5311         (m32c_gdbarch_init): Don't register deleted functions with
5312         gdbarch.
5313
5314 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5315
5316         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5317         (lm32_unwind_pc): Delete.
5318         (lm32_dummy_id): Delete.
5319         (lm32_gdbarch_init): Don't register deleted functions with
5320         gdbarch.
5321
5322 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5323
5324         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5325         (iq2000_unwind_pc): Delete.
5326         (iq2000_dummy_id): Delete.
5327         (iq2000_gdbarch_init): Don't register deleted functions with
5328         gdbarch.
5329
5330 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5331
5332         * nds32-tdep.c (nds32_type_align): Delete.
5333         (nds32_push_dummy_call): Use type_align instead.
5334
5335 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5336
5337         * arm-tdep.c (arm_type_align): Only handle vector override case.
5338         (arm_push_dummy_call): Use type_align.
5339         (arm_gdbarch_init): Register arm_type_align gdbarch function.
5340
5341 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5342
5343         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5344         case.
5345         (pass_on_stack): Use type_align.
5346         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5347         function.
5348
5349 2019-04-23  Tom Tromey  <tromey@adacore.com>
5350
5351         * dwarf2read.c (line_header::file_name_at): Remove unused
5352         overload.
5353
5354 2019-04-23  Tom de Vries  <tdevries@suse.de>
5355
5356         PR gdb/24438
5357         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5358         invocation.
5359
5360
5361 2019-03-27  Ali Tamur  <tamur@google.com>
5362
5363         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5364         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5365         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5366         (dwarf_expr_context::get_addr_index): Likewise
5367         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5368         (symbol_needs_eval_context::get_addr_index): Likewise
5369         (disassemble_dwarf_expression): Add DW_OP_addrx
5370         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5371         (read_cutu_die_from_dwo): Update comment
5372         (skip_one_die): Add DW_FORM_addrx
5373         (read_attribute_value): Likewise
5374         (var_decode_location): Add DW_OP_addrx
5375         (dwarf2_const_value_attr): Add DW_FORM_addrx
5376         (dump_die_shallow): Likewise
5377         (dwarf2_fetch_constant_bytes): Likewise
5378         (decode_locdesc): Add DW_OP_addrx
5379         (skip_form_bytes): Add DW_FORM_addrx
5380
5381 2019-04-22  Ali Tamur  <tamur@google.com>
5382
5383         * MAINTAINERS (Write After Approval): Add self.
5384
5385 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
5386
5387         * solib-svr4.c (get_svr4_info): Add pspace parameter.
5388         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5389         (open_symbol_file_object): Likewise.
5390         (svr4_default_sos): Add info parameter.
5391         (svr4_read_so_list): Likewise.
5392         (svr4_current_sos_direct): Adjust functions calls to pass down
5393         info.
5394         (svr4_current_sos_1): Add info parameter.
5395         (svr4_current_sos): Call get_svr4_info, pass info down to
5396         svr4_current_sos_1.
5397         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5398         get_svr4_info.
5399         (svr4_in_dynsym_resolve_code): Pass current_program_space to
5400         get_svr4_info.
5401         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5402         to get_svr4_info.
5403         (probes_table_remove_objfile_probes): Likewise.
5404         (register_solib_event_probe): Add info parameter.
5405         (solist_update_incremental): Pass info parameter down to
5406         svr4_read_so_list.
5407         (disable_probes_interface): Add info parameter.
5408         (svr4_handle_solib_event): Pass current_program_space to
5409         get_svr4_info.  Adjust disable_probes_interface cleanup.
5410         (svr4_create_probe_breakpoints): Add info parameter, pass it
5411         down to register_solib_event_probe.
5412         (svr4_create_solib_event_breakpoints): Add info parameter,
5413         pass it down to svr4_create_probe_breakpoints.
5414         (enable_break): Pass info down to
5415         svr4_create_solib_event_breakpoints.
5416         (svr4_solib_create_inferior_hook): Pass current_program_space to
5417         get_svr4_info.
5418         (svr4_clear_solib): Likewise.
5419
5420 2019-04-22  Pedro Alves  <palves@redhat.com>
5421
5422         * solib-svr4.c (svr4_free_objfile_observer): New.
5423         (probe_and_action::objfile): New field.
5424         (probes_table_htab_remove_objfile_probes)
5425         (probes_table_remove_objfile_probes): New functions.
5426         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5427         in the new probe_and_action.  Don't store the probe in 'lookup'.
5428         (svr4_create_probe_breakpoints): Pass objfile to
5429         register_solib_event_probe.
5430         (_initialize_svr4_solib): Register a free_objfile observer.
5431
5432 2019-04-19  Tom Tromey  <tom@tromey.com>
5433
5434         * common/queue.h: Remove.
5435
5436 2019-04-19  Tom Tromey  <tom@tromey.com>
5437
5438         * event-loop.c: Don't include "common/queue.h".
5439
5440 2019-04-19  Tom Tromey  <tom@tromey.com>
5441
5442         * remote.c (remote_target): Use delete.
5443         * remote-notif.h: Include <list>, not "common/queue.h".
5444         (notif_client_p): Remove typedef.
5445         (remote_notif_state): Add constructor, destructor, initializer.
5446         <notif_queue>: Now a std::list.
5447         (remote_notif_state_xfree): Don't declare.
5448         * remote-notif.c (remote_notif_process, handle_notification)
5449         (remote_notif_state_allocate): Update.
5450         (~remote_notif_state): Rename from remote_notif_state_xfree.
5451
5452 2019-04-19  Tom Tromey  <tom@tromey.com>
5453
5454         * symfile.c (reread_symbols): Update.
5455         * objfiles.c (objfile_register_static_link)
5456         (objfile_lookup_static_link): Update
5457         (~objfile) Don't delete static_links.
5458         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5459
5460 2019-04-19  Tom Tromey  <tom@tromey.com>
5461
5462         * type-stack.h (struct type_stack) <insert>: Constify string.
5463         * type-stack.c (type_stack::insert): Constify string.
5464         * gdbtypes.h (lookup_template_type): Update.
5465         (address_space_name_to_int): Update.
5466         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5467         const.
5468         (lookup_template_type): Make name const.
5469         * c-exp.y: Update rules.
5470         (lex_one_token, classify_name, classify_inner_name)
5471         (c_print_token): Update.
5472         * p-exp.y: Update rules.
5473         (yylex): Update.
5474         * f-exp.y: Update rules.
5475         (yylex): Update.
5476         * d-exp.y: Update rules.
5477         (lex_one_token, classify_name, classify_inner_name): Update.
5478         * parse.c (write_dollar_variable, copy_name): Return std::string.
5479         * parser-defs.h (copy_name): Change return type.
5480         * m2-exp.y: Update rules.
5481         (yylex): Update.
5482         * go-exp.y (lex_one_token): Update.
5483         Update rules.
5484         (classify_unsafe_function, classify_packaged_name)
5485         (classify_name, yylex): Update.
5486
5487 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5488
5489         * configure.ac: add --enable-source-highlight switch.
5490         * configure: Regenerate.
5491         * top.c (print_gdb_version): plumb --enable-source-highlight
5492         status to "show configuration".
5493
5494 2019-04-19  Tom Tromey  <tromey@adacore.com>
5495
5496         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5497         Check ADA_TYPE_P.
5498         (empty_record, ada_template_to_fixed_record_type_1)
5499         (template_to_static_fixed_type)
5500         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5501         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5502         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5503         macros.
5504
5505 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5506
5507         PR symtab/24423:
5508         * source.c (print_source_lines_base): Advance "iter" when a
5509         control character is seen.
5510
5511 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5512
5513         * inferior.h (struct infcall_suspend_state_deleter):
5514         Catch exception in destructor to avoid crash.
5515
5516 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5517
5518         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5519         close to the add_com "shell".
5520
5521 2019-04-18  Tom Tromey  <tromey@adacore.com>
5522
5523         * process-stratum-target.h (class process_stratum_target)
5524         <stratum>: Add "final".
5525
5526 2019-04-17  Tom Tromey  <tromey@adacore.com>
5527
5528         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5529         against nullptr before use.
5530
5531 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5532
5533         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5534
5535 2019-04-17  Jim Wilson  <jimw@sifive.com>
5536             Andrew Burgess  <andrew.burgess@embecosm.com>
5537
5538         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5539         code read might fail, assume 4-byte breakpoint in that case.
5540
5541 2019-04-15  Leszek Swirski  <leszeks@google.com>
5542
5543         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5544         rather than a hand-rolled POD check when checking for forced MEMORY
5545         classification.
5546
5547 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5548
5549         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5550         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5551         function.
5552         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5553         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5554         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5555         declaration.
5556
5557 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5558
5559         * aarch64-linux-nat.c
5560         (aarch64_linux_nat_target::thread_architecture): Add override.
5561         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5562         each VQ.
5563
5564 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5565
5566         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5567
5568 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5569
5570         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5571         target types of size 96-bits, add some additional comments, and
5572         check that the builtin type we found was the correct size.
5573
5574 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5575
5576         * utils.c (prompt_for_continue): Don't restore the styling at the
5577         end, as applied_style has the wrong value.  This fixes styling in
5578         long lists of file names that are interrupted by the "Continue?"
5579         prompt.
5580
5581 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5582
5583         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5584         * c-lang.c (c_language_defn): Likewise.
5585         (cplus_language_defn): Likewise.
5586         (asm_language_defn): Likewise.
5587         (minimal_language_defn): Likewise.
5588         * d-lang.c (d_language_defn): Likewise.
5589         * f-lang.c (f_language_defn): Likewise.
5590         * go-lang.c (go_language_defn): Likewise.
5591         * language.c (unknown_language_defn): Likewise.
5592         (auto_language_defn): Likewise.
5593         * language.h (struct language_defn): Remove la_magic field.
5594         (LANG_MAGIC): Delete.
5595         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5596         * objc-lang.c (objc_language_defn): Likewise.
5597         * opencl-lang.c (opencl_language_defn): Likewise.
5598         * p-lang.c (pascal_language_defn): Likewise.
5599         * rust-lang.c (rust_language_defn): Likewise.
5600
5601 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5602
5603         * riscv-tdep.c (riscv_type_align): New function.
5604         (riscv_type_alignment): Delete.
5605         (riscv_arg_location): Use 'type_align'.
5606         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5607
5608 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5609
5610         * gdbtypes.c (type_align): A struct with no non-static fields also
5611         has alignment of 1.
5612
5613 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5614
5615         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5616         component to 0.
5617         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5618         member.
5619         (riscv_struct_info::analyse): New implementation using new
5620         analyse_inner member function.
5621         (riscv_struct_info::field_offset): New member function.
5622         (riscv_struct_info::m_offsets): New member variable.
5623         (riscv_struct_info::analyse_inner): New private member function,
5624         takes the old implementation of riscv_struct_info::analyse but
5625         extended to track field offsets.
5626         (riscv_call_arg_struct): Update the struct folding special cases
5627         to handle cases where empty C++ structs, which are non-zero
5628         length, are found.
5629         (riscv_arg_location): Initialise the length of each location, a
5630         non-zero length now indicates the location is in use.
5631         (riscv_push_dummy_call): Allow for the first location having a
5632         non-zero offset when setting up arguments.
5633         (riscv_return_value): Likewise, but for return values.
5634
5635 2019-04-11  Tom Tromey  <tromey@adacore.com>
5636
5637         * utils.c (internal_vproblem): Make "msg" const.
5638
5639 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5640
5641         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5642         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5643         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5644         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5645
5646 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5647
5648         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5649         function.
5650         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5651         of amd64_collect_native_gregset.
5652         (amd64_linux_nat_target::store_registers): Likewise.
5653
5654 2019-04-10  Tom Tromey  <tom@tromey.com>
5655
5656         * symtab.c (lookup_global_symbol_from_objfile)
5657         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5658         * objfiles.h (class separate_debug_iterator): New.
5659         (class separate_debug_range): New.
5660         (struct objfile) <separate_debug_objfiles>: New method.
5661         (objfile_separate_debug_iterate): Don't declare.
5662         * objfiles.c (separate_debug_iterator::operator++): Rename from
5663         objfile_separate_debug_iterate.
5664         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5665         iterator.
5666         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5667         iterator.
5668
5669 2019-04-10  Tom Tromey  <tom@tromey.com>
5670
5671         * symfile.c (reread_symbols): Remove old comment.
5672         * objfiles.c (free_all_objfiles): Fix a typo.
5673
5674 2019-04-10  Tom Tromey  <tom@tromey.com>
5675
5676         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5677         * minsyms.c (lookup_minimal_symbol): Use foreach.
5678         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5679         (lookup_minimal_symbol_solib_trampoline): Likewise.
5680         * symfile.c (reread_symbols): Use foreach.
5681
5682 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5683             Tom Tromey  <tromey@adacore.com>
5684
5685         PR rust/24414:
5686         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5687         (rust_lex_int_test): Change "value" to be LONGEST.
5688         (rust_lex_tests): Add test for long integer literal.
5689
5690 2019-04-09  Tom Tromey  <tromey@adacore.com>
5691
5692         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5693         to bool.
5694         (extended_remote_target::attach): Update.
5695         (remote_target::remote_notice_new_inferior): Update.
5696         (remote_target::add_current_inferior_and_thread): Update.
5697         * inferior.c (exit_inferior_1): Use "false".
5698         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5699
5700 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5701
5702         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5703         the "start" command.
5704
5705 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5706
5707         * python/py-inferior.c (infpy_thread_from_thread_handle):
5708         Adjust comments to reflect renaming of thread_from_thread_handle
5709         to thread_from_handle.  Adjust keywords.  Fix type error message.
5710         (inferior_object_methods): Add thread_from_handle.  Retain
5711         thread_from_thread_handle, but mark it as deprecated.
5712
5713 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5714
5715         * gdbthread.h (find_thread_by_handle): Revise declaration.
5716         * thread.c (find_thread_by_handle): Likewise.  Adjust
5717         implementation too.
5718         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5719         support for buffer objects as handles.
5720
5721 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5722
5723         * python/py-infthread.c (thpy_thread_handle): New function.
5724         (thread_object_methods): Register thpy_thread_handle.
5725
5726 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5727
5728         * gdbthread.h (thread_to_thread_handle): Declare.
5729         * thread.c (gdbtypes.h): Include.
5730         (thread_to_thread_handle): New function.
5731
5732         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5733         (target_thread_info_to_thread_handle): Declare.
5734         * target.c (target_thread_info_to_thread_handle): New function.
5735         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5736         * target-delegates.c: Regenerate.
5737
5738         * linux-thread-db.c (class thread_db_target): Add method
5739         thread_info_to_thread_handle.
5740         (thread_db_target::thread_info_to_thread_handle): Define.
5741         * remote.c (class remote_target): Add new method
5742         thread_info_to_thread_handle.
5743         (remote_target::thread_info_to_thread_handle): Define.
5744
5745 2019-04-08  Pedro Alves  <palves@redhat.com>
5746
5747         * common/common-exceptions.c (throw_exception): Don't create
5748         named object to throw; throw directly.
5749         (throw_it): Likewise.  Don't initialize gdb_exception::message
5750         here, with new; pass FMT and AP to the ctor instead.
5751         * common/common-exceptions.h: Include <string>.
5752         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5753         const char *, va_list)): New ctor.  Use std::make_shared.
5754         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5755         errors)): Delete.
5756         (gdb_exception_error::gdb_exception_error(enum errors, const char
5757         *, va_list)): New.
5758         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5759         Add assertion.
5760         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5761         errors)): Delete.
5762         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5763         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5764         Add assertion.
5765
5766 2019-04-08  Tom Tromey  <tom@tromey.com>
5767
5768         * valops.c (value_rtti_indirect_type): Replace throw_exception
5769         with throw.
5770         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5771         with throw.
5772         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5773         throw.
5774         * target.c (target_translate_tls_address): Replace throw_exception
5775         with throw.
5776         * stack.c (frame_apply_command_count): Replace throw_exception
5777         with throw.
5778         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5779         throw.
5780         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5781         with throw.
5782         * rs6000-tdep.c (rs6000_frame_cache)
5783         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5784         * remote.c: Replace throw_exception with throw.
5785         * record-full.c (record_full_message, record_full_wait_1)
5786         (record_full_restore): Replace throw_exception with throw.
5787         * record-btrace.c:
5788         (get_thread_current_frame_id, record_btrace_start_replaying)
5789         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5790         (cmd_record_btrace_start): Replace throw_exception with throw.
5791         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5792         throw.
5793         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5794         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5795         * linespec.c:
5796         (find_linespec_symbols): Replace throw_exception with throw.
5797         * infrun.c (displaced_step_prepare, resume): Replace
5798         throw_exception with throw.
5799         * infcmd.c (post_create_inferior): Replace throw_exception with
5800         throw.
5801         * inf-loop.c (inferior_event_handler): Replace throw_exception
5802         with throw.
5803         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5804         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5805         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5806         (get_prev_frame_always, get_frame_pc_if_available)
5807         (get_frame_address_in_block_if_available, get_frame_language):
5808         Replace throw_exception with throw.
5809         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5810         throw_exception with throw.
5811         * eval.c (fetch_subexp_value, evaluate_var_value)
5812         (evaluate_funcall, evaluate_subexp_standard): Replace
5813         throw_exception with throw.
5814         * dwarf2loc.c (call_site_find_chain)
5815         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5816         Replace throw_exception with throw.
5817         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5818         with throw.
5819         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5820         throw.
5821         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5822         * completer.c (complete_line_internal): Replace throw_exception
5823         with throw.
5824         * compile/compile-object-run.c (compile_object_run): Replace
5825         throw_exception with throw.
5826         * cli/cli-script.c (process_next_line): Replace throw_exception
5827         with throw.
5828         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5829         (btrace_enable, btrace_maint_update_pt_packets): Replace
5830         throw_exception with throw.
5831         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5832         throw_exception with throw.
5833         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5834         throw_exception with throw.
5835         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5836         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5837         * aarch64-tdep.c (aarch64_make_prologue_cache)
5838         (aarch64_make_stub_cache): Replace throw_exception with throw.
5839
5840 2019-04-08  Tom Tromey  <tom@tromey.com>
5841
5842         * common/common-exceptions.c (throw_exception): Rename from
5843         throw_exception_cxx.  Remove old copy.  Make argument const.
5844         (throw_it): Create and throw exception objects directly.
5845         * common/common-exceptions.h (throw_exception): Make argument
5846         const.
5847         (struct gdb_exception_error): Add constructor.
5848         (struct gdb_exception_quit): Add constructor.
5849
5850 2019-04-08  Tom Tromey  <tom@tromey.com>
5851
5852         * common/common-exceptions.h (exception_rethrow): Don't declare.
5853         (TRY_SJLJ): Update comment.
5854         (TRY, CATCH, END_CATCH): Remove.
5855         * common/common-exceptions.c (exception_rethrow): Remove.
5856
5857 2019-04-08  Tom Tromey  <tom@tromey.com>
5858
5859         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5860         Remove.
5861         (gdb_exception_error): Rename from
5862         gdb_exception_RETURN_MASK_ERROR.
5863         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5864         (gdb_quit_bad_alloc): Update.
5865         * aarch64-tdep.c: Update.
5866         * ada-lang.c: Update.
5867         * ada-typeprint.c: Update.
5868         * ada-valprint.c: Update.
5869         * amd64-tdep.c: Update.
5870         * arch-utils.c: Update.
5871         * break-catch-throw.c: Update.
5872         * breakpoint.c: Update.
5873         * btrace.c: Update.
5874         * c-varobj.c: Update.
5875         * cli/cli-cmds.c: Update.
5876         * cli/cli-interp.c: Update.
5877         * cli/cli-script.c: Update.
5878         * common/common-exceptions.c: Update.
5879         * common/new-op.c: Update.
5880         * common/selftest.c: Update.
5881         * compile/compile-c-symbols.c: Update.
5882         * compile/compile-cplus-symbols.c: Update.
5883         * compile/compile-object-load.c: Update.
5884         * compile/compile-object-run.c: Update.
5885         * completer.c: Update.
5886         * corelow.c: Update.
5887         * cp-abi.c: Update.
5888         * cp-support.c: Update.
5889         * cp-valprint.c: Update.
5890         * darwin-nat.c: Update.
5891         * disasm-selftests.c: Update.
5892         * dtrace-probe.c: Update.
5893         * dwarf-index-cache.c: Update.
5894         * dwarf-index-write.c: Update.
5895         * dwarf2-frame-tailcall.c: Update.
5896         * dwarf2-frame.c: Update.
5897         * dwarf2loc.c: Update.
5898         * dwarf2read.c: Update.
5899         * eval.c: Update.
5900         * event-loop.c: Update.
5901         * event-top.c: Update.
5902         * exec.c: Update.
5903         * f-valprint.c: Update.
5904         * fbsd-tdep.c: Update.
5905         * frame-unwind.c: Update.
5906         * frame.c: Update.
5907         * gdbtypes.c: Update.
5908         * gnu-v3-abi.c: Update.
5909         * guile/guile-internal.h: Update.
5910         * guile/scm-block.c: Update.
5911         * guile/scm-breakpoint.c: Update.
5912         * guile/scm-cmd.c: Update.
5913         * guile/scm-disasm.c: Update.
5914         * guile/scm-frame.c: Update.
5915         * guile/scm-lazy-string.c: Update.
5916         * guile/scm-math.c: Update.
5917         * guile/scm-param.c: Update.
5918         * guile/scm-ports.c: Update.
5919         * guile/scm-pretty-print.c: Update.
5920         * guile/scm-symbol.c: Update.
5921         * guile/scm-symtab.c: Update.
5922         * guile/scm-type.c: Update.
5923         * guile/scm-value.c: Update.
5924         * i386-linux-tdep.c: Update.
5925         * i386-tdep.c: Update.
5926         * inf-loop.c: Update.
5927         * infcall.c: Update.
5928         * infcmd.c: Update.
5929         * infrun.c: Update.
5930         * jit.c: Update.
5931         * language.c: Update.
5932         * linespec.c: Update.
5933         * linux-fork.c: Update.
5934         * linux-nat.c: Update.
5935         * linux-tdep.c: Update.
5936         * linux-thread-db.c: Update.
5937         * main.c: Update.
5938         * mi/mi-cmd-break.c: Update.
5939         * mi/mi-cmd-stack.c: Update.
5940         * mi/mi-interp.c: Update.
5941         * mi/mi-main.c: Update.
5942         * objc-lang.c: Update.
5943         * p-valprint.c: Update.
5944         * parse.c: Update.
5945         * ppc-linux-tdep.c: Update.
5946         * printcmd.c: Update.
5947         * python/py-arch.c: Update.
5948         * python/py-breakpoint.c: Update.
5949         * python/py-cmd.c: Update.
5950         * python/py-finishbreakpoint.c: Update.
5951         * python/py-frame.c: Update.
5952         * python/py-framefilter.c: Update.
5953         * python/py-gdb-readline.c: Update.
5954         * python/py-inferior.c: Update.
5955         * python/py-infthread.c: Update.
5956         * python/py-lazy-string.c: Update.
5957         * python/py-linetable.c: Update.
5958         * python/py-objfile.c: Update.
5959         * python/py-param.c: Update.
5960         * python/py-prettyprint.c: Update.
5961         * python/py-progspace.c: Update.
5962         * python/py-record-btrace.c: Update.
5963         * python/py-record.c: Update.
5964         * python/py-symbol.c: Update.
5965         * python/py-type.c: Update.
5966         * python/py-unwind.c: Update.
5967         * python/py-utils.c: Update.
5968         * python/py-value.c: Update.
5969         * python/python.c: Update.
5970         * record-btrace.c: Update.
5971         * record-full.c: Update.
5972         * remote-fileio.c: Update.
5973         * remote.c: Update.
5974         * riscv-tdep.c: Update.
5975         * rs6000-aix-tdep.c: Update.
5976         * rs6000-tdep.c: Update.
5977         * rust-exp.y: Update.
5978         * rust-lang.c: Update.
5979         * s390-tdep.c: Update.
5980         * selftest-arch.c: Update.
5981         * solib-dsbt.c: Update.
5982         * solib-frv.c: Update.
5983         * solib-spu.c: Update.
5984         * solib-svr4.c: Update.
5985         * solib.c: Update.
5986         * sparc64-linux-tdep.c: Update.
5987         * stack.c: Update.
5988         * symfile-mem.c: Update.
5989         * symmisc.c: Update.
5990         * target.c: Update.
5991         * thread.c: Update.
5992         * top.c: Update.
5993         * tracefile-tfile.c: Update.
5994         * tui/tui.c: Update.
5995         * typeprint.c: Update.
5996         * unittests/cli-utils-selftests.c: Update.
5997         * unittests/parse-connection-spec-selftests.c: Update.
5998         * valops.c: Update.
5999         * valprint.c: Update.
6000         * value.c: Update.
6001         * varobj.c: Update.
6002         * windows-nat.c: Update.
6003         * x86-linux-nat.c: Update.
6004         * xml-support.c: Update.
6005
6006 2019-04-08  Tom Tromey  <tom@tromey.com>
6007
6008         * xml-support.c: Use C++ exception handling.
6009         * x86-linux-nat.c: Use C++ exception handling.
6010         * windows-nat.c: Use C++ exception handling.
6011         * varobj.c: Use C++ exception handling.
6012         * value.c: Use C++ exception handling.
6013         * valprint.c: Use C++ exception handling.
6014         * valops.c: Use C++ exception handling.
6015         * unittests/parse-connection-spec-selftests.c: Use C++ exception
6016         handling.
6017         * unittests/cli-utils-selftests.c: Use C++ exception handling.
6018         * typeprint.c: Use C++ exception handling.
6019         * tui/tui.c: Use C++ exception handling.
6020         * tracefile-tfile.c: Use C++ exception handling.
6021         * top.c: Use C++ exception handling.
6022         * thread.c: Use C++ exception handling.
6023         * target.c: Use C++ exception handling.
6024         * symmisc.c: Use C++ exception handling.
6025         * symfile-mem.c: Use C++ exception handling.
6026         * stack.c: Use C++ exception handling.
6027         * sparc64-linux-tdep.c: Use C++ exception handling.
6028         * solib.c: Use C++ exception handling.
6029         * solib-svr4.c: Use C++ exception handling.
6030         * solib-spu.c: Use C++ exception handling.
6031         * solib-frv.c: Use C++ exception handling.
6032         * solib-dsbt.c: Use C++ exception handling.
6033         * selftest-arch.c: Use C++ exception handling.
6034         * s390-tdep.c: Use C++ exception handling.
6035         * rust-lang.c: Use C++ exception handling.
6036         * rust-exp.y: Use C++ exception handling.
6037         * rs6000-tdep.c: Use C++ exception handling.
6038         * rs6000-aix-tdep.c: Use C++ exception handling.
6039         * riscv-tdep.c: Use C++ exception handling.
6040         * remote.c: Use C++ exception handling.
6041         * remote-fileio.c: Use C++ exception handling.
6042         * record-full.c: Use C++ exception handling.
6043         * record-btrace.c: Use C++ exception handling.
6044         * python/python.c: Use C++ exception handling.
6045         * python/py-value.c: Use C++ exception handling.
6046         * python/py-utils.c: Use C++ exception handling.
6047         * python/py-unwind.c: Use C++ exception handling.
6048         * python/py-type.c: Use C++ exception handling.
6049         * python/py-symbol.c: Use C++ exception handling.
6050         * python/py-record.c: Use C++ exception handling.
6051         * python/py-record-btrace.c: Use C++ exception handling.
6052         * python/py-progspace.c: Use C++ exception handling.
6053         * python/py-prettyprint.c: Use C++ exception handling.
6054         * python/py-param.c: Use C++ exception handling.
6055         * python/py-objfile.c: Use C++ exception handling.
6056         * python/py-linetable.c: Use C++ exception handling.
6057         * python/py-lazy-string.c: Use C++ exception handling.
6058         * python/py-infthread.c: Use C++ exception handling.
6059         * python/py-inferior.c: Use C++ exception handling.
6060         * python/py-gdb-readline.c: Use C++ exception handling.
6061         * python/py-framefilter.c: Use C++ exception handling.
6062         * python/py-frame.c: Use C++ exception handling.
6063         * python/py-finishbreakpoint.c: Use C++ exception handling.
6064         * python/py-cmd.c: Use C++ exception handling.
6065         * python/py-breakpoint.c: Use C++ exception handling.
6066         * python/py-arch.c: Use C++ exception handling.
6067         * printcmd.c: Use C++ exception handling.
6068         * ppc-linux-tdep.c: Use C++ exception handling.
6069         * parse.c: Use C++ exception handling.
6070         * p-valprint.c: Use C++ exception handling.
6071         * objc-lang.c: Use C++ exception handling.
6072         * mi/mi-main.c: Use C++ exception handling.
6073         * mi/mi-interp.c: Use C++ exception handling.
6074         * mi/mi-cmd-stack.c: Use C++ exception handling.
6075         * mi/mi-cmd-break.c: Use C++ exception handling.
6076         * main.c: Use C++ exception handling.
6077         * linux-thread-db.c: Use C++ exception handling.
6078         * linux-tdep.c: Use C++ exception handling.
6079         * linux-nat.c: Use C++ exception handling.
6080         * linux-fork.c: Use C++ exception handling.
6081         * linespec.c: Use C++ exception handling.
6082         * language.c: Use C++ exception handling.
6083         * jit.c: Use C++ exception handling.
6084         * infrun.c: Use C++ exception handling.
6085         * infcmd.c: Use C++ exception handling.
6086         * infcall.c: Use C++ exception handling.
6087         * inf-loop.c: Use C++ exception handling.
6088         * i386-tdep.c: Use C++ exception handling.
6089         * i386-linux-tdep.c: Use C++ exception handling.
6090         * guile/scm-value.c: Use C++ exception handling.
6091         * guile/scm-type.c: Use C++ exception handling.
6092         * guile/scm-symtab.c: Use C++ exception handling.
6093         * guile/scm-symbol.c: Use C++ exception handling.
6094         * guile/scm-pretty-print.c: Use C++ exception handling.
6095         * guile/scm-ports.c: Use C++ exception handling.
6096         * guile/scm-param.c: Use C++ exception handling.
6097         * guile/scm-math.c: Use C++ exception handling.
6098         * guile/scm-lazy-string.c: Use C++ exception handling.
6099         * guile/scm-frame.c: Use C++ exception handling.
6100         * guile/scm-disasm.c: Use C++ exception handling.
6101         * guile/scm-cmd.c: Use C++ exception handling.
6102         * guile/scm-breakpoint.c: Use C++ exception handling.
6103         * guile/scm-block.c: Use C++ exception handling.
6104         * guile/guile-internal.h: Use C++ exception handling.
6105         * gnu-v3-abi.c: Use C++ exception handling.
6106         * gdbtypes.c: Use C++ exception handling.
6107         * frame.c: Use C++ exception handling.
6108         * frame-unwind.c: Use C++ exception handling.
6109         * fbsd-tdep.c: Use C++ exception handling.
6110         * f-valprint.c: Use C++ exception handling.
6111         * exec.c: Use C++ exception handling.
6112         * event-top.c: Use C++ exception handling.
6113         * event-loop.c: Use C++ exception handling.
6114         * eval.c: Use C++ exception handling.
6115         * dwarf2read.c: Use C++ exception handling.
6116         * dwarf2loc.c: Use C++ exception handling.
6117         * dwarf2-frame.c: Use C++ exception handling.
6118         * dwarf2-frame-tailcall.c: Use C++ exception handling.
6119         * dwarf-index-write.c: Use C++ exception handling.
6120         * dwarf-index-cache.c: Use C++ exception handling.
6121         * dtrace-probe.c: Use C++ exception handling.
6122         * disasm-selftests.c: Use C++ exception handling.
6123         * darwin-nat.c: Use C++ exception handling.
6124         * cp-valprint.c: Use C++ exception handling.
6125         * cp-support.c: Use C++ exception handling.
6126         * cp-abi.c: Use C++ exception handling.
6127         * corelow.c: Use C++ exception handling.
6128         * completer.c: Use C++ exception handling.
6129         * compile/compile-object-run.c: Use C++ exception handling.
6130         * compile/compile-object-load.c: Use C++ exception handling.
6131         * compile/compile-cplus-symbols.c: Use C++ exception handling.
6132         * compile/compile-c-symbols.c: Use C++ exception handling.
6133         * common/selftest.c: Use C++ exception handling.
6134         * common/new-op.c: Use C++ exception handling.
6135         * cli/cli-script.c: Use C++ exception handling.
6136         * cli/cli-interp.c: Use C++ exception handling.
6137         * cli/cli-cmds.c: Use C++ exception handling.
6138         * c-varobj.c: Use C++ exception handling.
6139         * btrace.c: Use C++ exception handling.
6140         * breakpoint.c: Use C++ exception handling.
6141         * break-catch-throw.c: Use C++ exception handling.
6142         * arch-utils.c: Use C++ exception handling.
6143         * amd64-tdep.c: Use C++ exception handling.
6144         * ada-valprint.c: Use C++ exception handling.
6145         * ada-typeprint.c: Use C++ exception handling.
6146         * ada-lang.c: Use C++ exception handling.
6147         * aarch64-tdep.c: Use C++ exception handling.
6148
6149 2019-04-08  Tom Tromey  <tom@tromey.com>
6150
6151         * xml-support.c (gdb_xml_parser::parse): Update.
6152         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6153         * value.c (show_convenience): Update.
6154         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6155         (test_parse_flags_qcs): Update.
6156         * thread.c (thr_try_catch_cmd): Update.
6157         * target.c (target_translate_tls_address): Update.
6158         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6159         (info_frame_command_core, frame_apply_command_count): Update.
6160         * rust-exp.y (rust_lex_exception_test): Update.
6161         * riscv-tdep.c (riscv_print_one_register_info): Update.
6162         * remote.c (remote_target::enable_btrace): Update.
6163         * record-btrace.c (record_btrace_enable_warn): Update.
6164         * python/py-utils.c (gdbpy_convert_exception): Update.
6165         * printcmd.c (do_one_display, print_variable_and_value): Update.
6166         * mi/mi-main.c (mi_print_exception): Update.
6167         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
6168         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6169         * linux-nat.c (linux_nat_target::attach): Update.
6170         * linux-fork.c (class scoped_switch_fork_info): Update.
6171         * infrun.c (displaced_step_prepare): Update.
6172         * infcall.c (call_function_by_hand_dummy): Update.
6173         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6174         * gnu-v3-abi.c (print_one_vtable): Update.
6175         * frame.c (get_prev_frame_always): Update.
6176         * f-valprint.c (info_common_command_for_block): Update.
6177         * exec.c (try_open_exec_file): Update.
6178         * exceptions.c (print_exception, exception_print)
6179         (exception_fprintf, exception_print_same): Update.
6180         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6181         * dwarf-index-cache.c (index_cache::store)
6182         (index_cache::lookup_gdb_index): Update.
6183         * darwin-nat.c (maybe_cache_shell): Update.
6184         * cp-valprint.c (cp_print_value_fields): Update.
6185         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6186         (gcc_cplus_symbol_address): Update.
6187         * compile/compile-c-symbols.c (gcc_convert_symbol)
6188         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6189         * common/selftest.c: Update.
6190         * common/common-exceptions.h (struct gdb_exception) <message>: Now
6191         a std::string.
6192         (exception_try_scope_entry, exception_try_scope_exit): Don't
6193         declare.
6194         (struct exception_try_scope): Remove.
6195         (TRY): Don't use exception_try_scope.
6196         (struct gdb_exception): Add constructor, operator=.
6197         <what>: New method.
6198         (struct gdb_exception_RETURN_MASK_ALL)
6199         (struct gdb_exception_RETURN_MASK_ERROR)
6200         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6201         (struct gdb_quit_bad_alloc): Update.
6202         * common/common-exceptions.c (exception_none): Change
6203         initializer.
6204         (struct catcher) <state, exception>: Initialize inline.
6205         <prev>: Remove member.
6206         (current_catcher): Remove.
6207         (catchers): New global.
6208         (exceptions_state_mc_init): Simplify.
6209         (catcher_pop): Remove.
6210         (exceptions_state_mc, exceptions_state_mc_catch): Update.
6211         (try_scope_depth, exception_try_scope_entry)
6212         (exception_try_scope_exit): Remove.
6213         (throw_exception_sjlj): Update.
6214         (exception_messages, exception_messages_size): Remove.
6215         (throw_it): Simplify.
6216         (gdb_exception_sliced_copy): Remove.
6217         (throw_exception_cxx): Update.
6218         * cli/cli-script.c (script_from_file): Update.
6219         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
6220         Update.
6221         * ada-valprint.c (ada_val_print): Update.
6222         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
6223         (create_excep_cond_exprs): Update.
6224
6225 2019-04-08  Tom Tromey  <tom@tromey.com>
6226
6227         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
6228         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
6229         (TRY, CATCH, END_CATCH): Remove some definitions.
6230         * common/common-exceptions.c: Don't use GDB_XCPT.
6231         (catcher_list_size): Remove.
6232         (throw_exception, throw_it): Simplify.
6233
6234 2019-04-05  Tom Tromey  <tom@tromey.com>
6235
6236         Revert the header-sorting patch.
6237         * ft32-tdep.c: Revert.
6238         * frv-tdep.c: Revert.
6239         * frv-linux-tdep.c: Revert.
6240         * frame.c: Revert.
6241         * frame-unwind.c: Revert.
6242         * frame-base.c: Revert.
6243         * fork-child.c: Revert.
6244         * findvar.c: Revert.
6245         * findcmd.c: Revert.
6246         * filesystem.c: Revert.
6247         * filename-seen-cache.h: Revert.
6248         * filename-seen-cache.c: Revert.
6249         * fbsd-tdep.c: Revert.
6250         * fbsd-nat.h: Revert.
6251         * fbsd-nat.c: Revert.
6252         * f-valprint.c: Revert.
6253         * f-typeprint.c: Revert.
6254         * f-lang.c: Revert.
6255         * extension.h: Revert.
6256         * extension.c: Revert.
6257         * extension-priv.h: Revert.
6258         * expprint.c: Revert.
6259         * exec.h: Revert.
6260         * exec.c: Revert.
6261         * exceptions.c: Revert.
6262         * event-top.c: Revert.
6263         * event-loop.c: Revert.
6264         * eval.c: Revert.
6265         * elfread.c: Revert.
6266         * dwarf2read.h: Revert.
6267         * dwarf2read.c: Revert.
6268         * dwarf2loc.c: Revert.
6269         * dwarf2expr.h: Revert.
6270         * dwarf2expr.c: Revert.
6271         * dwarf2-frame.c: Revert.
6272         * dwarf2-frame-tailcall.c: Revert.
6273         * dwarf-index-write.h: Revert.
6274         * dwarf-index-write.c: Revert.
6275         * dwarf-index-common.c: Revert.
6276         * dwarf-index-cache.h: Revert.
6277         * dwarf-index-cache.c: Revert.
6278         * dummy-frame.c: Revert.
6279         * dtrace-probe.c: Revert.
6280         * disasm.h: Revert.
6281         * disasm.c: Revert.
6282         * disasm-selftests.c: Revert.
6283         * dictionary.c: Revert.
6284         * dicos-tdep.c: Revert.
6285         * demangle.c: Revert.
6286         * dcache.h: Revert.
6287         * dcache.c: Revert.
6288         * darwin-nat.h: Revert.
6289         * darwin-nat.c: Revert.
6290         * darwin-nat-info.c: Revert.
6291         * d-valprint.c: Revert.
6292         * d-namespace.c: Revert.
6293         * d-lang.c: Revert.
6294         * ctf.c: Revert.
6295         * csky-tdep.c: Revert.
6296         * csky-linux-tdep.c: Revert.
6297         * cris-tdep.c: Revert.
6298         * cris-linux-tdep.c: Revert.
6299         * cp-valprint.c: Revert.
6300         * cp-support.c: Revert.
6301         * cp-namespace.c: Revert.
6302         * cp-abi.c: Revert.
6303         * corelow.c: Revert.
6304         * corefile.c: Revert.
6305         * continuations.c: Revert.
6306         * completer.h: Revert.
6307         * completer.c: Revert.
6308         * complaints.c: Revert.
6309         * coffread.c: Revert.
6310         * coff-pe-read.c: Revert.
6311         * cli-out.h: Revert.
6312         * cli-out.c: Revert.
6313         * charset.c: Revert.
6314         * c-varobj.c: Revert.
6315         * c-valprint.c: Revert.
6316         * c-typeprint.c: Revert.
6317         * c-lang.c: Revert.
6318         * buildsym.c: Revert.
6319         * buildsym-legacy.c: Revert.
6320         * build-id.h: Revert.
6321         * build-id.c: Revert.
6322         * btrace.c: Revert.
6323         * bsd-uthread.c: Revert.
6324         * breakpoint.h: Revert.
6325         * breakpoint.c: Revert.
6326         * break-catch-throw.c: Revert.
6327         * break-catch-syscall.c: Revert.
6328         * break-catch-sig.c: Revert.
6329         * blockframe.c: Revert.
6330         * block.c: Revert.
6331         * bfin-tdep.c: Revert.
6332         * bfin-linux-tdep.c: Revert.
6333         * bfd-target.c: Revert.
6334         * bcache.c: Revert.
6335         * ax-general.c: Revert.
6336         * ax-gdb.h: Revert.
6337         * ax-gdb.c: Revert.
6338         * avr-tdep.c: Revert.
6339         * auxv.c: Revert.
6340         * auto-load.c: Revert.
6341         * arm-wince-tdep.c: Revert.
6342         * arm-tdep.c: Revert.
6343         * arm-symbian-tdep.c: Revert.
6344         * arm-pikeos-tdep.c: Revert.
6345         * arm-obsd-tdep.c: Revert.
6346         * arm-nbsd-tdep.c: Revert.
6347         * arm-nbsd-nat.c: Revert.
6348         * arm-linux-tdep.c: Revert.
6349         * arm-linux-nat.c: Revert.
6350         * arm-fbsd-tdep.c: Revert.
6351         * arm-fbsd-nat.c: Revert.
6352         * arm-bsd-tdep.c: Revert.
6353         * arch-utils.c: Revert.
6354         * arc-tdep.c: Revert.
6355         * arc-newlib-tdep.c: Revert.
6356         * annotate.h: Revert.
6357         * annotate.c: Revert.
6358         * amd64-windows-tdep.c: Revert.
6359         * amd64-windows-nat.c: Revert.
6360         * amd64-tdep.c: Revert.
6361         * amd64-sol2-tdep.c: Revert.
6362         * amd64-obsd-tdep.c: Revert.
6363         * amd64-obsd-nat.c: Revert.
6364         * amd64-nbsd-tdep.c: Revert.
6365         * amd64-nbsd-nat.c: Revert.
6366         * amd64-nat.c: Revert.
6367         * amd64-linux-tdep.c: Revert.
6368         * amd64-linux-nat.c: Revert.
6369         * amd64-fbsd-tdep.c: Revert.
6370         * amd64-fbsd-nat.c: Revert.
6371         * amd64-dicos-tdep.c: Revert.
6372         * amd64-darwin-tdep.c: Revert.
6373         * amd64-bsd-nat.c: Revert.
6374         * alpha-tdep.c: Revert.
6375         * alpha-obsd-tdep.c: Revert.
6376         * alpha-nbsd-tdep.c: Revert.
6377         * alpha-mdebug-tdep.c: Revert.
6378         * alpha-linux-tdep.c: Revert.
6379         * alpha-linux-nat.c: Revert.
6380         * alpha-bsd-tdep.c: Revert.
6381         * alpha-bsd-nat.c: Revert.
6382         * aix-thread.c: Revert.
6383         * agent.c: Revert.
6384         * addrmap.c: Revert.
6385         * ada-varobj.c: Revert.
6386         * ada-valprint.c: Revert.
6387         * ada-typeprint.c: Revert.
6388         * ada-tasks.c: Revert.
6389         * ada-lang.c: Revert.
6390         * aarch64-tdep.c: Revert.
6391         * aarch64-ravenscar-thread.c: Revert.
6392         * aarch64-newlib-tdep.c: Revert.
6393         * aarch64-linux-tdep.c: Revert.
6394         * aarch64-linux-nat.c: Revert.
6395         * aarch64-fbsd-tdep.c: Revert.
6396         * aarch64-fbsd-nat.c: Revert.
6397         * aarch32-linux-nat.c: Revert.
6398
6399 2019-04-05  Tom Tromey  <tom@tromey.com>
6400
6401         * ft32-tdep.c: Sort headers.
6402         * frv-tdep.c: Sort headers.
6403         * frv-linux-tdep.c: Sort headers.
6404         * frame.c: Sort headers.
6405         * frame-unwind.c: Sort headers.
6406         * frame-base.c: Sort headers.
6407         * fork-child.c: Sort headers.
6408         * findvar.c: Sort headers.
6409         * findcmd.c: Sort headers.
6410         * filesystem.c: Sort headers.
6411         * filename-seen-cache.h: Sort headers.
6412         * filename-seen-cache.c: Sort headers.
6413         * fbsd-tdep.c: Sort headers.
6414         * fbsd-nat.h: Sort headers.
6415         * fbsd-nat.c: Sort headers.
6416         * f-valprint.c: Sort headers.
6417         * f-typeprint.c: Sort headers.
6418         * f-lang.c: Sort headers.
6419         * extension.h: Sort headers.
6420         * extension.c: Sort headers.
6421         * extension-priv.h: Sort headers.
6422         * expprint.c: Sort headers.
6423         * exec.h: Sort headers.
6424         * exec.c: Sort headers.
6425         * exceptions.c: Sort headers.
6426         * event-top.c: Sort headers.
6427         * event-loop.c: Sort headers.
6428         * eval.c: Sort headers.
6429         * elfread.c: Sort headers.
6430         * dwarf2read.h: Sort headers.
6431         * dwarf2read.c: Sort headers.
6432         * dwarf2loc.c: Sort headers.
6433         * dwarf2expr.h: Sort headers.
6434         * dwarf2expr.c: Sort headers.
6435         * dwarf2-frame.c: Sort headers.
6436         * dwarf2-frame-tailcall.c: Sort headers.
6437         * dwarf-index-write.h: Sort headers.
6438         * dwarf-index-write.c: Sort headers.
6439         * dwarf-index-common.c: Sort headers.
6440         * dwarf-index-cache.h: Sort headers.
6441         * dwarf-index-cache.c: Sort headers.
6442         * dummy-frame.c: Sort headers.
6443         * dtrace-probe.c: Sort headers.
6444         * disasm.h: Sort headers.
6445         * disasm.c: Sort headers.
6446         * disasm-selftests.c: Sort headers.
6447         * dictionary.c: Sort headers.
6448         * dicos-tdep.c: Sort headers.
6449         * demangle.c: Sort headers.
6450         * dcache.h: Sort headers.
6451         * dcache.c: Sort headers.
6452         * darwin-nat.h: Sort headers.
6453         * darwin-nat.c: Sort headers.
6454         * darwin-nat-info.c: Sort headers.
6455         * d-valprint.c: Sort headers.
6456         * d-namespace.c: Sort headers.
6457         * d-lang.c: Sort headers.
6458         * ctf.c: Sort headers.
6459         * csky-tdep.c: Sort headers.
6460         * csky-linux-tdep.c: Sort headers.
6461         * cris-tdep.c: Sort headers.
6462         * cris-linux-tdep.c: Sort headers.
6463         * cp-valprint.c: Sort headers.
6464         * cp-support.c: Sort headers.
6465         * cp-namespace.c: Sort headers.
6466         * cp-abi.c: Sort headers.
6467         * corelow.c: Sort headers.
6468         * corefile.c: Sort headers.
6469         * continuations.c: Sort headers.
6470         * completer.h: Sort headers.
6471         * completer.c: Sort headers.
6472         * complaints.c: Sort headers.
6473         * coffread.c: Sort headers.
6474         * coff-pe-read.c: Sort headers.
6475         * cli-out.h: Sort headers.
6476         * cli-out.c: Sort headers.
6477         * charset.c: Sort headers.
6478         * c-varobj.c: Sort headers.
6479         * c-valprint.c: Sort headers.
6480         * c-typeprint.c: Sort headers.
6481         * c-lang.c: Sort headers.
6482         * buildsym.c: Sort headers.
6483         * buildsym-legacy.c: Sort headers.
6484         * build-id.h: Sort headers.
6485         * build-id.c: Sort headers.
6486         * btrace.c: Sort headers.
6487         * bsd-uthread.c: Sort headers.
6488         * breakpoint.h: Sort headers.
6489         * breakpoint.c: Sort headers.
6490         * break-catch-throw.c: Sort headers.
6491         * break-catch-syscall.c: Sort headers.
6492         * break-catch-sig.c: Sort headers.
6493         * blockframe.c: Sort headers.
6494         * block.c: Sort headers.
6495         * bfin-tdep.c: Sort headers.
6496         * bfin-linux-tdep.c: Sort headers.
6497         * bfd-target.c: Sort headers.
6498         * bcache.c: Sort headers.
6499         * ax-general.c: Sort headers.
6500         * ax-gdb.h: Sort headers.
6501         * ax-gdb.c: Sort headers.
6502         * avr-tdep.c: Sort headers.
6503         * auxv.c: Sort headers.
6504         * auto-load.c: Sort headers.
6505         * arm-wince-tdep.c: Sort headers.
6506         * arm-tdep.c: Sort headers.
6507         * arm-symbian-tdep.c: Sort headers.
6508         * arm-pikeos-tdep.c: Sort headers.
6509         * arm-obsd-tdep.c: Sort headers.
6510         * arm-nbsd-tdep.c: Sort headers.
6511         * arm-nbsd-nat.c: Sort headers.
6512         * arm-linux-tdep.c: Sort headers.
6513         * arm-linux-nat.c: Sort headers.
6514         * arm-fbsd-tdep.c: Sort headers.
6515         * arm-fbsd-nat.c: Sort headers.
6516         * arm-bsd-tdep.c: Sort headers.
6517         * arch-utils.c: Sort headers.
6518         * arc-tdep.c: Sort headers.
6519         * arc-newlib-tdep.c: Sort headers.
6520         * annotate.h: Sort headers.
6521         * annotate.c: Sort headers.
6522         * amd64-windows-tdep.c: Sort headers.
6523         * amd64-windows-nat.c: Sort headers.
6524         * amd64-tdep.c: Sort headers.
6525         * amd64-sol2-tdep.c: Sort headers.
6526         * amd64-obsd-tdep.c: Sort headers.
6527         * amd64-obsd-nat.c: Sort headers.
6528         * amd64-nbsd-tdep.c: Sort headers.
6529         * amd64-nbsd-nat.c: Sort headers.
6530         * amd64-nat.c: Sort headers.
6531         * amd64-linux-tdep.c: Sort headers.
6532         * amd64-linux-nat.c: Sort headers.
6533         * amd64-fbsd-tdep.c: Sort headers.
6534         * amd64-fbsd-nat.c: Sort headers.
6535         * amd64-dicos-tdep.c: Sort headers.
6536         * amd64-darwin-tdep.c: Sort headers.
6537         * amd64-bsd-nat.c: Sort headers.
6538         * alpha-tdep.c: Sort headers.
6539         * alpha-obsd-tdep.c: Sort headers.
6540         * alpha-nbsd-tdep.c: Sort headers.
6541         * alpha-mdebug-tdep.c: Sort headers.
6542         * alpha-linux-tdep.c: Sort headers.
6543         * alpha-linux-nat.c: Sort headers.
6544         * alpha-bsd-tdep.c: Sort headers.
6545         * alpha-bsd-nat.c: Sort headers.
6546         * aix-thread.c: Sort headers.
6547         * agent.c: Sort headers.
6548         * addrmap.c: Sort headers.
6549         * ada-varobj.c: Sort headers.
6550         * ada-valprint.c: Sort headers.
6551         * ada-typeprint.c: Sort headers.
6552         * ada-tasks.c: Sort headers.
6553         * ada-lang.c: Sort headers.
6554         * aarch64-tdep.c: Sort headers.
6555         * aarch64-ravenscar-thread.c: Sort headers.
6556         * aarch64-newlib-tdep.c: Sort headers.
6557         * aarch64-linux-tdep.c: Sort headers.
6558         * aarch64-linux-nat.c: Sort headers.
6559         * aarch64-fbsd-tdep.c: Sort headers.
6560         * aarch64-fbsd-nat.c: Sort headers.
6561         * aarch32-linux-nat.c: Sort headers.
6562
6563 2019-04-04  Tom Tromey  <tom@tromey.com>
6564
6565         * varobj.c (varobj_create): Update.
6566         * rust-exp.y (struct rust_parser) <update_innermost_block,
6567         lookup_symbol>: New methods.
6568         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6569         Rename.
6570         (rust_parser::rust_lookup_type)
6571         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6572         * printcmd.c (display_command, do_one_display): Update.
6573         * parser-defs.h (struct parser_state) <parser_state>: Add
6574         "tracker" parameter.
6575         (block_tracker): New member.
6576         (class innermost_block_tracker) <innermost_block_tracker>: Add
6577         "types" parameter.
6578         <reset>: Remove method.
6579         (innermost_block): Don't declare.
6580         (null_post_parser): Update.
6581         * parse.c (innermost_block): Remove global.
6582         (write_dollar_variable): Update.
6583         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6584         Remove "tracker_types" parameter.
6585         (parse_expression): Add "tracker" parameter.
6586         (parse_expression_for_completion): Update.
6587         (null_post_parser): Add "tracker" parameter.
6588         * p-exp.y: Update rules.
6589         * m2-exp.y: Update rules.
6590         * language.h (struct language_defn) <la_post_parser>: Add
6591         "tracker" parameter.
6592         * go-exp.y: Update rules.
6593         * f-exp.y: Update rules.
6594         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6595         parameter.
6596         * d-exp.y: Update rules.
6597         * c-exp.y: Update rules.
6598         * breakpoint.c (set_breakpoint_condition): Create an
6599         innermost_block_tracker.
6600         (watch_command_1): Likewise.
6601         * ada-lang.c (resolve): Add "tracker" parameter.
6602         (resolve_subexp): Likewise.
6603         * ada-exp.y (write_var_from_sym): Update.
6604
6605 2019-04-04  Tom Tromey  <tom@tromey.com>
6606
6607         * type-stack.h: New file.
6608         * type-stack.c: New file.
6609         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6610         type-stack.h.
6611         (insert_into_type_stack, insert_type, push_type, push_type_int)
6612         (insert_type_address_space, pop_type, pop_type_int)
6613         (pop_typelist, pop_type_stack, append_type_stack)
6614         (push_type_stack, get_type_stack, push_typelist)
6615         (follow_type_instance_flags, follow_types): Don't declare.
6616         * parse.c (type_stack): Remove global.
6617         (parse_exp_in_context): Update.
6618         (insert_into_type_stack, insert_type, push_type, push_type_int)
6619         (insert_type_address_space, pop_type, pop_type_int)
6620         (pop_typelist, pop_type_stack, append_type_stack)
6621         (push_type_stack, get_type_stack, push_typelist)
6622         (follow_type_instance_flags, follow_types): Remove (moved to
6623         type-stack.c).
6624         * f-exp.y (type_stack): New global.
6625         Update rules.
6626         (push_kind_type, f_parse): Update.
6627         * d-exp.y (type_stack): New global.
6628         Update rules.
6629         (d_parse): Update.
6630         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6631         Update rules.
6632         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6633         (HFILES_NO_SRCDIR): Add type-stack.h.
6634
6635 2019-04-04  Tom Tromey  <tom@tromey.com>
6636
6637         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6638         (rust_parser::convert_ast_to_expression, rust_parse)
6639         (rust_lex_test_completion, rust_lex_tests): Update.
6640         * parser-defs.h (struct expr_completion_state): New.
6641         (struct parser_state) <parser_state>: Add completion parameter.
6642         <mark_struct_expression, mark_completion_tag>: New methods.
6643         <parse_completion, m_completion_state>: New members.
6644         (prefixify_expression, null_post_parser): Update.
6645         (mark_struct_expression, mark_completion_tag): Don't declare.
6646         * parse.c (parse_completion, expout_last_struct)
6647         (expout_tag_completion_type, expout_completion_name): Remove
6648         globals.
6649         (parser_state::mark_struct_expression)
6650         (parser_state::mark_completion_tag): Now methods.
6651         (prefixify_expression): Add last_struct parameter.
6652         (prefixify_subexp): Likewise.
6653         (parse_exp_1): Update.
6654         (parse_exp_in_context): Add cstate parameter.  Update.
6655         (parse_expression_for_completion): Create an
6656         expr_completion_state.
6657         (null_post_parser): Add "completion" parameter.
6658         * p-exp.y: Update rules.
6659         (yylex): Update.
6660         * language.h (struct language_defn) <la_post_parser>: Add
6661         "completing" parameter.
6662         * go-exp.y: Update rules.
6663         (lex_one_token): Update.
6664         * expression.h (parse_completion): Don't declare.
6665         * d-exp.y: Update rules.
6666         (lex_one_token): Update rules.
6667         * c-exp.y: Update rules.
6668         (lex_one_token): Update.
6669         * ada-lang.c (resolve): Add "parse_completion" parameter.
6670         (resolve_subexp): Likewise.
6671         (ada_resolve_function): Likewise.
6672
6673 2019-04-04  Tom Tromey  <tom@tromey.com>
6674
6675         * parser-defs.h (struct parser_state) <start_arglist,
6676         end_arglist>: New methods.
6677         <arglist_len, m_funcall_chain>: New members.
6678         (arglist_len, start_arglist, end_arglist): Don't declare.
6679         * parse.c (arglist_len, funcall_chain): Remove global.
6680         (start_arglist, end_arglist): Remove functions.
6681         (parse_exp_in_context): Update.
6682         * p-exp.y: Update rules.
6683         * m2-exp.y: Update rules.
6684         * go-exp.y: Update rules.
6685         * f-exp.y: Update rules.
6686         * d-exp.y: Update rules.
6687         * c-exp.y: Update rules.
6688
6689 2019-04-04  Tom Tromey  <tom@tromey.com>
6690
6691         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6692         lex_operator, push_back>: New methods.
6693         Update all rules.
6694         (rust_parser::lex_hex, lex_escape): Rename and update.
6695         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6696         (rust_parser::lex_operator): Rename and update.
6697         (rust_parser::lex_number, rustyylex, rustyyerror)
6698         (rust_lex_test_init, rust_lex_test_sequence)
6699         (rust_lex_test_push_back, rust_lex_tests): Update.
6700         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6701         parameter.
6702         <lexptr, prev_lexptr>: New members.
6703         (lexptr, prev_lexptr): Don't declare.
6704         * parse.c (lexptr, prev_lexptr): Remove globals.
6705         (parse_exp_in_context): Update.
6706         * p-exp.y (yylex, yyerror): Update.
6707         * m2-exp.y (parse_number, yylex, yyerror): Update.
6708         * go-exp.y (lex_one_token, yyerror): Update.
6709         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6710         * d-exp.y (lex_one_token, yyerror): Update.
6711         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6712         (lex_one_token, yyerror): Update.
6713         * ada-lex.l (YY_INPUT): Update.
6714         (rewind_to_char): Update.
6715         * ada-exp.y (yyerror): Update.
6716
6717 2019-04-04  Tom Tromey  <tom@tromey.com>
6718
6719         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6720         * parser-defs.h (struct parser_state) <parser_state>: Add new
6721         parameter.
6722         <comma_terminates>: New member.
6723         (comma_terminates): Don't declare global.
6724         * parse.c (comma_terminates): Remove global.
6725         (parse_exp_in_context): Update.
6726         * p-exp.y (yylex): Update.
6727         * m2-exp.y (yylex): Update.
6728         * go-exp.y (lex_one_token): Update.
6729         * f-exp.y (yylex): Update.
6730         * d-exp.y (lex_one_token): Update.
6731         * c-exp.y (lex_one_token): Update.
6732         * ada-lex.l: Update.
6733
6734 2019-04-04  Tom Tromey  <tom@tromey.com>
6735
6736         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6737         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6738         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6739         * parser-defs.h (paren_depth): Don't declare.
6740         * parse.c (paren_depth): Remove global.
6741         (parse_exp_in_context): Update.
6742         * p-exp.y (paren_depth): New global.
6743         (pascal_parse): Initialize it.
6744         * m2-exp.y (paren_depth): New global.
6745         (m2_parse): Initialize it.
6746         * go-exp.y (paren_depth): New global.
6747         (go_parse): Initialize it.
6748         * f-exp.y (paren_depth): New global.
6749         (f_parse): Initialize it.
6750         * d-exp.y (paren_depth): New global.
6751         (d_parse): Initialize it.
6752         * c-exp.y (paren_depth): New global.
6753         (c_parse): Initialize it.
6754         * ada-lex.l (paren_depth): New global.
6755         (lexer_init): Initialize it.
6756
6757 2019-04-04  Tom Tromey  <tom@tromey.com>
6758
6759         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6760         (rust_parser::convert_ast_to_type)
6761         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6762         * parser-defs.h (struct parser_state) <parser_state>: Add
6763         parameters.  Initialize new members.
6764         <expression_context_block, expression_context_pc>: New members.
6765         * parse.c (expression_context_block, expression_context_pc):
6766         Remove globals.
6767         (parse_exp_in_context): Update.
6768         * p-exp.y: Update all rules.
6769         (yylex): Update.
6770         * m2-exp.y: Update all rules.
6771         (yylex): Update.
6772         * go-exp.y (yylex): Update.
6773         * f-exp.y (yylex): Update.
6774         * d-exp.y: Update all rules.
6775         (yylex): Update.
6776         * c-exp.y: Update all rules.
6777         (lex_one_token, classify_name, yylex, c_parse): Update.
6778         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6779
6780 2019-04-04  Tom Tromey  <tom@tromey.com>
6781
6782         * gdbarch.h, gdbarch.c: Rebuild.
6783         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6784         * stap-probe.h: 
6785         (struct stap_parse_info): Replace "parser_state" with
6786         "expr_builder".
6787         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6788         (parser_state): New class.
6789         * parse.c (expr_builder): Rename.
6790         (expr_builder::release): Rename.
6791         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6792         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6793         (write_exp_elt_longcst, write_exp_elt_floatcst)
6794         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6795         (write_exp_string_vector, write_exp_bitstring)
6796         (write_exp_msymbol, mark_struct_expression)
6797         (write_dollar_variable)
6798         (insert_type_address_space, increase_expout_size): Replace
6799         "parser_state" with "expr_builder".
6800         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6801         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6802         "parser_state" with "expr_builder".
6803
6804 2019-04-04  Tom Tromey  <tom@tromey.com>
6805
6806         * rust-exp.y: Replace "parse_language" with method call.
6807         * p-exp.y: 
6808         (yylex): Replace "parse_language" with method call.
6809         * m2-exp.y: 
6810         (yylex): Replace "parse_language" with method call.
6811         * go-exp.y (classify_name): Replace "parse_language" with method
6812         call.
6813         * f-exp.y (yylex): Replace "parse_language" with method call.
6814         * d-exp.y (lex_one_token): Replace "parse_language" with method
6815         call.
6816         * c-exp.y: 
6817         (lex_one_token, classify_name, yylex): Replace "parse_language"
6818         with method call.
6819         * ada-exp.y (find_primitive_type, type_char)
6820         (type_system_address): Replace "parse_language" with method call.
6821
6822 2019-04-04  Tom Tromey  <tom@tromey.com>
6823
6824         * rust-exp.y: Replace "parse_gdbarch" with method call.
6825         * parse.c (write_dollar_variable, insert_type_address_space):
6826         Replace "parse_gdbarch" with method call.
6827         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6828         call.
6829         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6830         call.
6831         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6832         "parse_gdbarch" with method call.
6833         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6834         with method call.
6835         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6836         "parse_gdbarch" with method call.
6837         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6838         "parse_gdbarch" with method call.
6839         * c-exp.y (parse_type, parse_number, classify_name): Replace
6840         "parse_gdbarch" with method call.
6841         * ada-lex.l: Replace "parse_gdbarch" with method call.
6842         * ada-exp.y (parse_type, find_primitive_type, type_char)
6843         (type_system_address): Replace "parse_gdbarch" with method call.
6844
6845 2019-04-04  Tom Tromey  <tom@tromey.com>
6846
6847         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6848         * stap-probe.c (stap_parse_argument): Update.
6849         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6850         initial_size parameter.
6851         * rust-exp.y (rust_lex_tests): Update.
6852         * parse.c (parser_state): Update.
6853         (parse_exp_in_context): Update.
6854         * parser-defs.h (struct parser_state) <parser_state>: Remove
6855         "initial_size" parameter.
6856
6857 2019-04-04  Tom Tromey  <tom@tromey.com>
6858
6859         * parser-defs.h (increase_expout_size): Don't declare.
6860         * parse.c (increase_expout_size): Now static.
6861
6862 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6863
6864         * gnu-nat.c (gnu_nat_target::wait): Fix
6865         target_waitstatus_to_string call.
6866
6867 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6868
6869         * eval.c (evaluate_subexp_standard): Handle internal functions
6870         during Fortran function call handling.
6871
6872 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6873
6874         * NEWS: Mention new internal functions.
6875         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6876         (read_base_type): Use dwarf2_init_complex_target_type.
6877         * value.c (creal_internal_fn): New function.
6878         (cimag_internal_fn): New function.
6879         (_initialize_values): Register new internal functions.
6880
6881 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6882
6883         * infrun.c (stop_all_threads): If debug_infrun, always
6884         trace the wait status after wait_one, using
6885         target_waitstatus_to_string and target_pid_to_str.
6886         (handle_inferior_event): Replace various trace of
6887         wait status kind by a single trace.
6888         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6889         wait status kind image by target_waitstatus_to_string.
6890         * target/waitstatus.c (target_waitstatus_to_string): Fix
6891         obsolete comment.
6892
6893 2019-04-01  Tom Tromey  <tromey@adacore.com>
6894
6895         PR symtab/23331:
6896         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6897
6898 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6899             Pedro Alves  <palves@redhat.com>
6900
6901         * top.c (quit_force): Call 'finalize_values'.
6902         * value.c (finalize_values): New function.
6903         * value.h (finalize_values): Declare.
6904
6905 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6906
6907         * NEWS: Announce $_gdb_major and $_gdb_minor.
6908
6909         * top.c (init_gdb_version_vars): New function.
6910         (gdb_init): Call init_gdb_version_vars.
6911
6912 2019-03-29  Tom Tromey  <tromey@adacore.com>
6913
6914         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6915         help text.  Remove dead code.
6916
6917 2019-03-29  Keith Seitz  <keiths@redhat.com>
6918
6919         From Siddhesh Poyarekar:
6920         * f-lang.h (f77_get_upperbound): Return LONGEST.
6921         (f77_get_lowerbound): Likewise.
6922         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6923         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6924         print them.
6925         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6926         plongest to format print it.
6927         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6928         (f77_get_upperbound): Likewise.
6929         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6930         LOWER_BOUND to LONGEST.
6931         (f77_create_arrayprint_offset_tbl): Likewise.
6932
6933 2019-03-29  Keith Seitz  <keiths@redhat.com>
6934
6935         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6936         %s/pulongest for TYPE_LENGTH instead of %d in format
6937         strings.
6938         * ada-typerint.c (ada_print_type): Likewise.
6939         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6940         * compile/compile-c-support.c (generate_register_struct): Likewise.
6941         * gdbtypes.c (recursive_dump_type): Likewise.
6942         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6943         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6944         instead of %d in format strings.
6945         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6946         to std::min to ULONGEST.
6947         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6948         instead of %d in format strings.
6949         * tracepoint.c (info_scope_command): Likewise.
6950         * typeprint.c (print_offset_data::update)
6951         (print_offset_data::finish): Likewise.
6952         * xtensa-tdep.c (xtensa_store_return_value)
6953         (xtensa_push_dummy_call): Likewise.
6954
6955 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6956
6957         * windows-nat.c (display_selector): Fixed format specifications
6958         for 64-bit Cygwin.
6959
6960 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6961
6962         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6963
6964 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6965
6966         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6967         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6968         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6969         (nios2_linux_init_abi): Install it.
6970
6971 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6972
6973         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6974
6975 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6976
6977         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6978
6979 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6980             Tom Tromey  <tromey@adacore.com>
6981
6982         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6983
6984 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6985
6986         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6987         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6988         method to compute the bounds of range types. Also print "[evaluated]"
6989         if the bounds' values come from a dynamic evaluation.
6990
6991 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6992
6993         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6994         whitespace when pretty printing is on.
6995
6996 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6997
6998         * ppc-linux-nat.c: Add include.
6999
7000 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7001
7002         * NEWS: Mention AArch64 Pointer Authentication.
7003
7004 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7005
7006         * arm-linux-nat.c: Add include.
7007
7008 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
7009
7010         * source-cache.c (source_cache::get_source_lines): Re-read
7011         fullname after calling open_source_file.
7012
7013 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
7014
7015         * NEWS: Mention TLS support for FreeBSD.
7016
7017 2019-03-25  Tom Tromey  <tromey@adacore.com>
7018
7019         * minsyms.c (BUNCH_SIZE): Update comment.
7020         (~minimal_symbol_reader): Remove old comment.
7021         (compact_minimal_symbols): Update comment.
7022         (minimal_symbol_reader::install): Remove old comment.  Update
7023         other comments.
7024
7025 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7026
7027         * s390-linux-nat.c: Add include.
7028
7029 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7030
7031         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7032         Call linux_get_hwcap.
7033         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7034         Likewise.
7035         (aarch64_linux_get_hwcap): Remove function.
7036         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7037         declaration.
7038         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7039         linux_get_hwcap.
7040         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7041         * linux-tdep.c (linux_get_hwcap): Add function.
7042         (linux_get_hwcap2): Likewise.
7043         * linux-tdep.h (linux_get_hwcap): Add declaration.
7044         (linux_get_hwcap2): Likewise.
7045         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7046         (ppc_linux_get_hwcap2): Likewise.
7047         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7048         linux_get_hwcap.
7049         (ppc_linux_nat_target::insert_watchpoint): Likewise.
7050         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7051         (ppc_linux_nat_target::read_description): Likewise.
7052         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7053         * s390-linux-nat.c: Likewise.
7054         * s390-linux-tdep.c (s390_core_read_description): Likewise.
7055
7056 2019-03-24  Tom Tromey  <tom@tromey.com>
7057
7058         * ada-lang.c (standard_lookup): Simplify initialization.
7059         (ada_lookup_symbol_nonlocal): Simplify return.
7060         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7061         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7062         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7063         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7064         initialization.
7065         * solib.c (solib_global_lookup): Simplify.
7066         * symtab.c (null_block_symbol): Remove.
7067         (symbol_cache_lookup): Simplify returns.
7068         (lookup_language_this): Simplify returns.
7069         (lookup_symbol_aux): Simplify return.
7070         (lookup_local_symbol): Simplify returns.
7071         (lookup_global_symbol_from_objfile): Simplify return.
7072         (lookup_symbol_in_objfile_symtabs)
7073         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7074         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7075         (lookup_static_symbol, lookup_global_symbol): Simplify return.
7076         * cp-namespace.c (cp_lookup_bare_symbol)
7077         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7078         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7079         (cp_lookup_nested_symbol): Don't use null_block_symbol.
7080         (cp_lookup_symbol_via_imports): Simplify initialization.
7081         (find_symbol_in_baseclass): Likewise.
7082         * symtab.h (null_block_symbol): Remove.
7083         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7084         (d_lookup_nested_symbol, d_lookup_symbol_imports)
7085         (d_lookup_symbol_module): Likewise.
7086         (find_symbol_in_baseclass): Simplify initialization.
7087
7088 2019-03-24  Tom Tromey  <tom@tromey.com>
7089
7090         * expression.h: Don't include symtab.h.
7091         (struct block): Forward declare.
7092
7093 2019-03-24  Tom Tromey  <tom@tromey.com>
7094
7095         * c-exp.y (typebase): Remove casts.
7096         * gdbtypes.c (lookup_unsigned_typename, )
7097         (lookup_signed_typename): Remove cast.
7098         * eval.c (parse_to_comma_and_eval): Remove cast.
7099         * parse.c (write_dollar_variable): Remove cast.
7100         * block.h (struct block) <superblock>: Now const.
7101         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7102         * psymtab.c (psym_map_matching_symbols): Make "block" const.
7103         (map_block): Make "block" const.
7104         * symfile.h (struct quick_symbol_functions)
7105         <map_matching_symbols>: Constify block argument to "callback".
7106         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7107         const.
7108         (find_pc_sect_compunit_symtab): Make "b" const.
7109         (find_symbol_at_address): Likewise.
7110         (search_symbols): Likewise.
7111         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7112         (dw2_debug_names_lookup_symbol): Likewise.
7113         (dw2_map_matching_symbols): Update.
7114         * p-valprint.c (pascal_val_print): Remove "block".
7115         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7116         (aux_add_nonlocal_symbols): Make "block" const.
7117         (resolve_subexp): Remove cast.
7118         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7119         const.
7120         (iterate_over_file_blocks): Likewise.
7121         * f-exp.y (%union) <bval>: Remove.
7122         * coffread.c (patch_opaque_types): Make "b" const.
7123         * spu-tdep.c (spu_catch_start): Make "block" const.
7124         * c-valprint.c (print_unpacked_pointer): Remove "block".
7125         * symmisc.c (dump_symtab_1): Make "b" const.
7126         (block_depth): Make "block" const.
7127         * d-exp.y (%union) <bval>: Remove.
7128         * cp-support.h (cp_lookup_rtti_type): Update.
7129         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7130         * psymtab.c (psym_lookup_symbol): Make "block" const.
7131         (maintenance_check_psymtabs): Make "b" const.
7132         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7133         (enumerate_locals, enumerate_args): Update.
7134         * python/py-symtab.c (stpy_global_block): Make "block" const.
7135         (stpy_static_block): Likewise.
7136         * inline-frame.c (block_starting_point_at): Make "new_block"
7137         const.
7138         * block.c (find_block_in_blockvector): Make return type const.
7139         (blockvector_for_pc_sect): Make "b" const.
7140         (find_block_in_blockvector): Make "b" const.
7141
7142 2019-03-23  Tom Tromey  <tom@tromey.com>
7143
7144         * varobj.c (varobj_create): Update.
7145         * symfile.c (clear_symtab_users): Don't reset innermost_block.
7146         * printcmd.c (display_command, do_one_display): Don't reset
7147         innermost_block.
7148         * parser-defs.h (enum innermost_block_tracker_type): Move to
7149         expression.h.
7150         (innermost_block): Update comment.
7151         * parse.c (parse_exp_1): Add tracker_types parameter.
7152         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
7153         tracker_types parameter.  Reset innermost_block.
7154         (parse_exp_in_context): Remove.
7155         (parse_expression_for_completion): Update.
7156         * objfiles.c (~objfile): Don't reset expression_context_block or
7157         innermost_block.
7158         * expression.h (enum innermost_block_tracker_type): Move from
7159         parser-defs.h.
7160         (parse_exp_1): Add tracker_types parameter.
7161         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
7162         reset innermost_block.
7163
7164 2019-03-23  Tom Tromey  <tom@tromey.com>
7165
7166         * objfiles.h: Include bcache.h.
7167
7168 2019-03-23  Tom Tromey  <tom@tromey.com>
7169
7170         * linespec.c (get_current_search_block): Use
7171         scoped_restore_current_language.
7172         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7173
7174 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7175             Jiong Wang  <jiong.wang@arm.com>
7176
7177         * aarch64-linux-tdep.c
7178         (aarch64_linux_iterate_over_regset_sections): Check for pauth
7179         section.
7180         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7181
7182 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7183             Jiong Wang  <jiong.wang@arm.com>
7184
7185         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7186         instructions.
7187         (aarch64_analyze_prologue_test): Add PACIASP test.
7188         (aarch64_prologue_prev_register): Unmask PC value.
7189
7190 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7191             Jiong Wang  <jiong.wang@arm.com>
7192
7193         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7194         (aarch64_dwarf2_prev_register): Unmask PC value.
7195         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7196         (aarch64_execute_dwarf_cfa_vendor_op): Check for
7197         DW_CFA_AARCH64_negate_ra_state.
7198         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7199
7200 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7201             Jiong Wang  <jiong.wang@arm.com>
7202
7203         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7204         registers.
7205         (aarch64_pseudo_register_name): Likewise.
7206         (aarch64_pseudo_register_type): Likewise.
7207         (aarch64_pseudo_register_reggroup_p): Likewise.
7208         (aarch64_gdbarch_init): Add pauth registers.
7209         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
7210         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
7211         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
7212         (struct gdbarch_tdep): Add regnum for ra_state.
7213
7214 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7215             Jiong Wang  <jiong.wang@arm.com>
7216
7217         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
7218
7219 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7220             Jiong Wang  <jiong.wang@arm.com>
7221
7222         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
7223         function.
7224         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7225         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7226         (aarch64_gdbarch_init): Add puth registers.
7227         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
7228         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
7229         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
7230
7231 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7232             Jiong Wang  <jiong.wang@arm.com>
7233
7234         * aarch64-linux-nat.c
7235         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7236         * aarch64-linux-tdep.c
7237         (aarch64_linux_core_read_description): Likewise.
7238         (aarch64_linux_get_hwcap): New function.
7239         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7240         (aarch64_linux_get_hwcap): New declaration.
7241
7242 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7243             Jiong Wang  <jiong.wang@arm.com>
7244
7245         * aarch64-linux-nat.c
7246         (aarch64_linux_nat_target::read_description): Add pauth param.
7247         * aarch64-linux-tdep.c
7248         (aarch64_linux_core_read_description): Likewise.
7249         * aarch64-tdep.c (struct target_desc): Add in pauth.
7250         (aarch64_read_description): Add pauth param.
7251         (aarch64_gdbarch_init): Likewise.
7252         * aarch64-tdep.h (aarch64_read_description): Likewise.
7253         * arch/aarch64.c (aarch64_create_target_description): Likewise.
7254         * arch/aarch64.h (aarch64_create_target_description): Likewise.
7255         * features/Makefile: Add new files.
7256         * features/aarch64-pauth.c: New file.
7257         * features/aarch64-pauth.xml: New file.
7258
7259 2019-03-20  Tom Tromey  <tromey@adacore.com>
7260
7261         * infrun.c (handle_inferior_event): Rename from
7262         handle_inferior_event_1.  Create a scoped_value_mark.
7263         (handle_inferior_event): Remove.
7264
7265 2019-03-19  Tom Tromey  <tromey@adacore.com>
7266
7267         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7268         * infrun.h (print_stop_event): Add "displays" parameter.
7269         * infrun.c (print_stop_event): Add "displays" parameter.
7270
7271 2019-03-19  Pedro Alves  <palves@redhat.com>
7272
7273         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7274         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
7275         to -1.  Fix TABs vs spaces.
7276         (tui_ui_out::tui_ui_out): Don't initialize fields here.
7277         * tui/tui-out.h (tui_ui_out) Add intro comments.
7278         <m_line, m_start_of_line>: In-class initialize, and add describing
7279         comment.
7280
7281 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
7282
7283         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7284         variable names.
7285         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7286
7287 2019-03-18  Pedro Alves  <palves@redhat.com>
7288             Eli Zaretskii <eliz@gnu.org>
7289
7290         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7291         m_line and m_start_of_line.
7292
7293 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
7294
7295         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7296         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7297         it returns a newline.  This fixes a regression in TU mode, whereby
7298         the next line is output on the same screen line as the user input.
7299
7300 2019-03-18  Tom Tromey  <tromey@adacore.com>
7301
7302         * minsyms.c (minimal_symbol_reader::install): Remove call to
7303         obstack_blank.
7304
7305 2019-03-18  Pedro Alves  <palves@redhat.com>
7306
7307         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7308         New globals.
7309         (apply_style): New, factored out from ...
7310         (apply_ansi_escape): ... this.  Handle reverse video mode.
7311         (tui_set_reverse_mode): New function.
7312         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7313         * tui/tui-winsource.c (tui_show_source_line): Use
7314         tui_set_reverse_mode instead of setting A_STANDOUT.
7315         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7316         New setter methods.
7317
7318 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
7319
7320         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7321         Handle tabs.
7322
7323 2019-03-18  Tom Tromey  <tromey@adacore.com>
7324
7325         * ada-lang.c (empty_array): Add "high" parameter.
7326         (ada_evaluate_subexp): Update.
7327
7328 2019-03-17  Sergei Trofimovich <siarheit@google.com>
7329
7330         * unittests/string_view-selftests.c: Define
7331         _initialize_string_view_selftests unconditionally.
7332
7333 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7334
7335         PR gdb/24350
7336         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7337
7338 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7339
7340         PR gdb/24351
7341         * windows-nat.c (display_selector): Fix format specifiers.
7342
7343 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
7344
7345         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7346         tui_refill_source_window instead of tui_refresh_win, to update the
7347         current execution line.  This fixes redisplay of the current line
7348         when stepping through the code with "next" or "step".
7349
7350 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7351
7352         * source-cache.c (source_cache::get_source_lines): Call
7353         find_source_lines to initialize s->nlines.  This fixes vertical
7354         scrolling of TUI source window when the DOWN arrow is pressed.
7355
7356 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7357
7358         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7359         linux-thread-db.c (_initialize_thread_db): Likewise.
7360
7361 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7362
7363         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7364         wclrtoeol in tui_show_source_line".  This reverts changes made in
7365         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7366
7367 2019-03-15  Tom Tromey  <tom@tromey.com>
7368
7369         * symtab.h (struct minimal_symbol): Derive from
7370         general_symbol_info.
7371         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7372         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7373         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7374         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7375         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7376         (MSYMBOL_SEARCH_NAME): Update.
7377         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7378         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7379         * minsyms.c (minimal_symbol_reader::record_full): Update.
7380
7381 2019-03-15  Tom Tromey  <tom@tromey.com>
7382
7383         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7384
7385 2019-03-15  Tom Tromey  <tom@tromey.com>
7386
7387         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7388         unique_xmalloc_ptr.
7389         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7390         Update.
7391         * minsyms.c (lookup_minimal_symbol_by_pc_section)
7392         (build_minimal_symbol_hash_tables)
7393         (minimal_symbol_reader::install): Update.
7394
7395 2019-03-15  Tom Tromey  <tom@tromey.com>
7396
7397         * symtab.c (create_demangled_names_hash): Update.
7398         (symbol_set_names): Update.
7399         * objfiles.h (struct objfile_per_bfd_storage)
7400         <demangled_names_hash>: Now an htab_up.
7401         * objfiles.c (objfile_per_bfd_storage): Simplify.
7402
7403 2019-03-15  Tom Tromey  <tom@tromey.com>
7404
7405         * objfiles.h (struct objfile_per_bfd_storage): Declare
7406         destructor.
7407         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7408         New.
7409         (get_objfile_bfd_data): Use new.  Don't initialize
7410         language_of_main.
7411         (free_objfile_per_bfd_storage): Remove.
7412         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7413
7414 2019-03-15  Tom Tromey  <tom@tromey.com>
7415
7416         * symfile.c (reread_symbols): Update.
7417         * objfiles.c (objfile::objfile): Update.
7418         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7419         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7420         comment.
7421         (minimal_symbol_reader::install): Update.
7422         (terminate_minimal_symbol_table): Remove.
7423         * jit.c (jit_object_close_impl): Update.
7424
7425 2019-03-15  Tom Tromey  <tom@tromey.com>
7426
7427         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7428         initializations.
7429
7430 2019-03-15  Tom Tromey  <tom@tromey.com>
7431
7432         * objfiles.h (struct objfile_per_bfd_storage)
7433         <demangled_hash_languages>: Now a bitset.
7434         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7435         (lookup_minimal_symbol): Update.
7436
7437 2019-03-15  Tom Tromey  <tom@tromey.com>
7438
7439         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7440         Don't return the symbol.
7441         * coffread.c (record_minimal_symbol): Use record_full.
7442
7443 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7444
7445         The MS-Windows port of ncurses fails to switch to a color pair if
7446         one or both of the colors are the implicit default colors.  This
7447         change records the default colors when TUI is initialized, and
7448         then specifies them explicitly when a color pair uses the default
7449         colors.  This allows color styling in TUI mode on MS-Windows.
7450
7451         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7452         ncurses_norm_attr.
7453         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7454         colors in ncurses_norm_attr.
7455         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7456         "none", replace it with the default color recorded in
7457         ncurses_norm_attr.
7458
7459 2019-03-14  Tom Tromey  <tromey@adacore.com>
7460
7461         * source-cache.h (class source_cache) <get_source_lines>: Return
7462         std::string.
7463         * source-cache.c (source_cache::extract_lines): Handle case where
7464         first_pos==npos.  Return std::string.
7465         (source_cache::get_source_lines): Update.
7466
7467 2019-03-14  Tom Tromey  <tromey@adacore.com>
7468
7469         * NEWS: Add item for "style sources" commands.
7470         * source-cache.c (source_cache::get_source_lines): Check
7471         source_styling.
7472         * cli/cli-style.c (source_styling): New global.
7473         (_initialize_cli_style): Add "style sources" commands.
7474         (show_style_sources): New function.
7475         * cli/cli-style.h (source_styling): Declare.
7476
7477 2019-03-14  Pedro Alves  <palves@redhat.com>
7478             Tom Tromey  <tromey@adacore.com>
7479
7480         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7481         * tui/tui-winsource.c (tui_refill_source_window): New function,
7482         from...
7483         (tui_horizontal_source_scroll): ... here.  Move some logic.
7484         * cli/cli-style.c (set_style_enabled): Notify new observable.
7485         * tui/tui-hooks.c (tui_redisplay_source): New function.
7486         (tui_attach_detach_observers): Attach or detach
7487         tui_redisplay_source.
7488         * observable.h (source_styling_changed): New observable.
7489         * observable.c: Define source_styling_changed observable.
7490
7491 2019-03-13  Tom Tromey  <tromey@adacore.com>
7492
7493         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7494         (i386_gnu_nat_target::store_registers): Update.
7495         * target-debug.h (target_debug_print_std_string): New macro.
7496         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7497         * windows-tdep.c (display_one_tib): Update.
7498         * tui/tui-stack.c (tui_make_status_line): Update.
7499         * top.c (print_inferior_quit_action): Update.
7500         * thread.c (thr_try_catch_cmd): Update.
7501         (add_thread_with_info): Update.
7502         (thread_target_id_str): Update.
7503         (thr_try_catch_cmd): Update.
7504         (thread_command): Update.
7505         (thread_find_command): Update.
7506         * record-btrace.c (record_btrace_target::info_record)
7507         (record_btrace_resume_thread, record_btrace_target::resume)
7508         (record_btrace_cancel_resume, record_btrace_step_thread)
7509         (record_btrace_target::wait, record_btrace_target::wait)
7510         (record_btrace_target::wait, record_btrace_target::stop): Update.
7511         * progspace.c (print_program_space): Update.
7512         * process-stratum-target.c
7513         (process_stratum_target::thread_address_space): Update.
7514         * linux-fork.c (linux_fork_mourn_inferior)
7515         (detach_checkpoint_command, info_checkpoints_command)
7516         (linux_fork_context): Update.
7517         (linux_fork_detach): Update.
7518         (class scoped_switch_fork_info): Update.
7519         (delete_checkpoint_command): Update.
7520         * infrun.c (follow_fork_inferior): Update.
7521         (follow_fork_inferior): Update.
7522         (proceed_after_vfork_done): Update.
7523         (handle_vfork_child_exec_or_exit): Update.
7524         (follow_exec): Update.
7525         (displaced_step_prepare_throw): Update.
7526         (displaced_step_restore): Update.
7527         (start_step_over): Update.
7528         (resume_1): Update.
7529         (clear_proceed_status_thread): Update.
7530         (proceed): Update.
7531         (print_target_wait_results): Update.
7532         (do_target_wait): Update.
7533         (context_switch): Update.
7534         (stop_all_threads): Update.
7535         (restart_threads): Update.
7536         (finish_step_over): Update.
7537         (handle_signal_stop): Update.
7538         (switch_back_to_stepped_thread): Update.
7539         (keep_going_pass_signal): Update.
7540         (print_exited_reason): Update.
7541         (normal_stop): Update.
7542         * inferior.c (inferior_pid_to_str): Change return type.
7543         (print_selected_inferior): Update.
7544         (add_inferior): Update.
7545         (detach_inferior): Update.
7546         * dummy-frame.c (fprint_dummy_frames): Update.
7547         * dcache.c (dcache_info_1): Update.
7548         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7549         (btrace_fetch, btrace_clear): Update.
7550         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7551         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7552         type.
7553         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7554         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7555         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7556         * gdbarch.c, gdbarch.h: Rebuild.
7557         * gdbarch.sh (core_pid_to_str): Change return type.
7558         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7559         return type.
7560         (windows_nat_target::pid_to_str): Change return type.
7561         (windows_delete_thread): Update.
7562         (windows_nat_target::attach): Update.
7563         (windows_nat_target::files_info): Update.
7564         * target-delegates.c: Rebuild.
7565         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7566         return type.
7567         (sol_thread_target::pid_to_str): Change return type.
7568         * remote.c (class remote_target) <pid_to_str>: Change return
7569         type.
7570         (remote_target::pid_to_str): Change return type.
7571         (extended_remote_target::attach, remote_target::remote_stop_ns)
7572         (remote_target::remote_notif_remove_queued_reply)
7573         (remote_target::push_stop_reply, remote_target::disable_btrace):
7574         Update.
7575         (extended_remote_target::attach): Update.
7576         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7577         type.
7578         (gdbsim_target::pid_to_str): Change return type.
7579         * ravenscar-thread.c (struct ravenscar_thread_target)
7580         <pid_to_str>: Change return type.
7581         (ravenscar_thread_target::pid_to_str): Change return type.
7582         * procfs.c (class procfs_target) <pid_to_str>: Change return
7583         type.
7584         (procfs_target::pid_to_str): Change return type.
7585         (procfs_target::attach): Update.
7586         (procfs_target::detach): Update.
7587         (procfs_target::fetch_registers): Update.
7588         (procfs_target::store_registers): Update.
7589         (procfs_target::wait): Update.
7590         (procfs_target::files_info): Update.
7591         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7592         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7593         return type.
7594         (nto_procfs_target::pid_to_str): Change return type.
7595         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7596         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7597         return type.
7598         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7599         (exit_lwp): Update.
7600         (attach_proc_task_lwp_callback, get_detach_signal)
7601         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7602         (linux_nat_target::resume, wait_lwp, stop_callback)
7603         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7604         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7605         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7606         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7607         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7608         type.
7609         (inf_ptrace_target::attach): Update.
7610         (inf_ptrace_target::files_info): Update.
7611         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7612         type.
7613         (go32_nat_target::pid_to_str): Change return type.
7614         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7615         (gnu_nat_target::wait): Update.
7616         (gnu_nat_target::wait): Update.
7617         (gnu_nat_target::resume): Update.
7618         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7619         (fbsd_nat_target::wait): Update.
7620         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7621         type.
7622         (darwin_nat_target::attach): Update.
7623         * corelow.c (class core_target) <pid_to_str>: Change return type.
7624         (core_target::pid_to_str): Change return type.
7625         * target.c (normal_pid_to_str): Change return type.
7626         (default_pid_to_str): Likewise.
7627         (target_pid_to_str): Change return type.
7628         (target_translate_tls_address): Update.
7629         (target_announce_detach): Update.
7630         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7631         return type.
7632         (bsd_uthread_target::pid_to_str): Change return type.
7633         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7634         type.
7635         (bsd_kvm_target::pid_to_str): Change return type.
7636         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7637         return type.
7638         (aix_thread_target::pid_to_str): Change return type.
7639         * target.h (struct target_ops) <pid_to_str>: Change return type.
7640         (target_pid_to_str, normal_pid_to_str): Likewise.
7641         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7642         type.
7643         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7644         type.
7645         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7646         return type.
7647         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7648         type.
7649         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7650         type.
7651         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7652         return type.
7653
7654 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7655
7656         * NEWS: Mention that the new default MI version is 3.  Mention
7657         changes to the output of commands and events that deal with
7658         multi-location breakpoints.
7659         * breakpoint.c: Include "mi/mi-out.h".
7660         (print_one_breakpoint): Change output syntax if using MI version
7661         >= 3.
7662         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7663         New.
7664         (mi_multi_location_breakpoint_output_fixed): New.
7665         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7666         (mi_cmd_fix_multi_location_breakpoint_output): New.
7667         (mi_multi_location_breakpoint_output_fixed): New.
7668         * mi/mi-cmds.c (mi_cmds): Register command
7669         -fix-multi-location-breakpoint-output.
7670         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7671         interpreter "mi".
7672
7673 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7674
7675         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7676         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7677         instantiate mi_ui_out based on interpreter name.
7678         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7679         * mi/mi-main.c (mi_load_progress): Likewise.
7680
7681 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7682
7683         * NEWS: Combine separate "New targets" sections for 8.3.
7684
7685 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7686
7687         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7688         (ppcfbsd_init_abi): Install gdbarch
7689         "fetch_tls_load_module_address" and "get_thread_local_address"
7690         methods.
7691
7692 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7693
7694         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7695         (riscv_fbsd_init_abi): Install gdbarch
7696         "fetch_tls_load_module_address" and "get_thread_local_address"
7697         methods.
7698
7699 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7700
7701         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7702         (i386fbsd_init_abi): Install gdbarch
7703         "fetch_tls_load_module_address" and "get_thread_local_address"
7704         methods.
7705
7706 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7707
7708         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7709         (amd64fbsd_init_abi): Install gdbarch
7710         "fetch_tls_load_module_address" and "get_thread_local_address"
7711         methods.
7712
7713 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7714
7715         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7716         (struct fbsd_pspace_data): New type.
7717         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7718         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7719         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7720         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7721         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7722
7723 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7724
7725         * gdbtypes.c (lookup_struct_elt): New function.
7726         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7727         * gdbtypes.h (struct struct_elt): New type.
7728         (lookup_struct_elt): New prototype.
7729
7730 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7731
7732         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7733         remove disabled code block.
7734
7735 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7736
7737         * gdbarch.sh (get_thread_local_address): New method.
7738         * gdbarch.h, gdbarch.c: Regenerate.
7739         * target.c (target_translate_tls_address): Use
7740         gdbarch_get_thread_local_address if present instead of
7741         target::get_thread_local_address.
7742
7743 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7744
7745         * target.h (target::get_thread_local_address): Update comment.
7746
7747 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7748
7749         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7750         objfile->separate_debug_objfile_backlink if not NULL.
7751
7752 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7753
7754         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7755         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7756         (amd64bsd_store_inferior_registers): Likewise.
7757         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7758         Enable segment base registers.
7759         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7760         PT_GETFSBASE and PT_GETGSBASE.
7761         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7762         PT_SETGSBASE.
7763         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7764         segment base registers.
7765         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7766
7767 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7768
7769         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7770         Update calls to i386_target_description to add 'segments'
7771         parameter.
7772         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7773         add segment base registers.
7774         * arch/i386.c (i386_create_target_description): Add 'segments'
7775         parameter to enable segment base registers.
7776         * arch/i386.h (i386_create_target_description): Likewise.
7777         * features/i386/32bit-segments.xml: New file.
7778         * features/i386/32bit-segments.c: Generate.
7779         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7780         call to i386_target_description to add 'segments' parameter.
7781         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7782         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7783         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7784         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7785         if feature is present.
7786         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7787         Add 'segments' parameter to call to i386_target_description.
7788         (i386_target_description): Add 'segments' parameter to enable
7789         segment base registers.
7790         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7791         to call to i386_target_description.
7792         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7793         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7794         Define I386_NUM_REGS.
7795         (i386_target_description): Add 'segments' parameter to enable
7796         segment base registers.
7797
7798 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7799
7800         PR/24325
7801         * source-cache.c: #undef open and close, to avoid unresolved
7802         externals during linking.
7803
7804 2019-03-12  Tom Tromey  <tromey@adacore.com>
7805
7806         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7807         const.  Add initializers.
7808         (_initialize_remote): Don't initialize ptid globals.
7809
7810 2019-03-12  Pedro Alves  <palves@redhat.com>
7811
7812         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7813
7814 2019-03-12  Pedro Alves  <palves@redhat.com>
7815
7816         * cp-name-parser.y (main): Remove unused 'len' variable.
7817
7818 2019-03-12  Tom Tromey  <tromey@adacore.com>
7819
7820         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7821         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7822
7823 2019-03-12  Tom Tromey  <tromey@adacore.com>
7824
7825         * linux-nat.c (iterate_over_lwps): Update.
7826         (stop_callback): Remove parameter.
7827         (stop_wait_callback, detach_callback, resume_set_callback)
7828         (select_singlestep_lwp_callback, set_ignore_sigint)
7829         (status_callback, resumed_callback, resume_clear_callback)
7830         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7831         data parameter.
7832         (linux_nat_target::detach, linux_nat_target::resume)
7833         (linux_stop_and_wait_all_lwps, select_event_lwp)
7834         (linux_nat_filter_event, linux_nat_wait_1)
7835         (linux_nat_target::kill, linux_nat_target::stop)
7836         (linux_nat_target::stop): Update.
7837         (linux_nat_resume_callback): Change type.
7838         (resume_stopped_resumed_lwps, count_events_callback)
7839         (select_event_lwp_callback): Likewise.
7840         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7841         * arm-linux-nat.c (struct update_registers_data): Remove.
7842         (update_registers_callback): Change type.
7843         (arm_linux_insert_hw_breakpoint1): Update.
7844         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7845         parameter.
7846         (x86_linux_dr_set_addr): Update.
7847         (x86_linux_dr_set_control): Update.
7848         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7849         (iterate_over_lwps): Use gdb::function_view.
7850         * nat/aarch64-linux-hw-point.c (struct
7851         aarch64_dr_update_callback_param): Remove.
7852         (debug_reg_change_callback): Change type.
7853         (aarch64_notify_debug_reg_change): Update.
7854         * s390-linux-nat.c (s390_refresh_per_info): Update.
7855
7856 2019-03-11  Tom Tromey  <tromey@adacore.com>
7857
7858         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7859         redundant assignment to "this_cu".
7860
7861 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7862
7863         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7864
7865 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7866
7867         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7868         from...
7869         (rank_one_type): ... this.
7870
7871 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7872
7873         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7874         from...
7875         (rank_one_type): ... this.
7876
7877 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7878
7879         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7880         from...
7881         (rank_one_type): ... this.
7882
7883 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7884
7885         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7886         from...
7887         (rank_one_type): ... this.
7888
7889 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7890
7891         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7892         from...
7893         (rank_one_type): ... this.
7894
7895 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7896
7897         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7898         from...
7899         (rank_one_type): ... this.
7900
7901 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7902
7903         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7904         from...
7905         (rank_one_type): ... this.
7906
7907 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7908
7909         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7910         from...
7911         (rank_one_type): ... this.
7912
7913 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7914
7915         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7916         from...
7917         (rank_one_type): ... this.
7918
7919 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7920
7921         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7922         from...
7923         (rank_one_type): ... this.
7924
7925 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7926
7927         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7928         from...
7929         (rank_one_type): ... this.
7930
7931 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7932
7933         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7934         from...
7935         (rank_one_type): ... this.
7936
7937 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7938
7939         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7940         inferior-events' shows the example events.
7941
7942 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7943
7944         Support styling on native MS-Windows console
7945
7946         PR/24315
7947         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7948         on MS-Windows if $TERM is not defined.
7949
7950         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7951
7952         * posix-hdep.c (gdb_console_fputs):
7953         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7954         functions.
7955         * ui-file.h (gdb_console_fputs): Add prototype.
7956
7957         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7958         back to fputs only if the former returns zero.
7959
7960 2019-03-07  Tom Tromey  <tom@tromey.com>
7961
7962         * symmisc.c (print_symbol_bcache_statistics): Update.
7963         (print_objfile_statistics): Update.
7964         * symfile.c (allocate_symtab): Update.
7965         * stabsread.c: Don't include bcache.h.
7966         * psymtab.h (struct psymbol_bcache): Don't declare.
7967         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7968         (psymbol_bcache_init, psymbol_bcache_free)
7969         (psymbol_bcache_get_bcache): Don't declare.
7970         * psymtab.c (struct psymbol_bcache): Remove.
7971         (psymtab_storage::psymtab_storage): Update.
7972         (psymtab_storage::~psymtab_storage): Update.
7973         (psymbol_bcache_init, psymbol_bcache_free)
7974         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7975         (add_psymbol_to_bcache): Update.
7976         (allocate_psymtab): Update.
7977         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7978         macro_cache>: No longer pointers.
7979         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7980         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7981         * macrotab.c (macro_bcache): Update.
7982         * macroexp.c: Don't include bcache.h.
7983         * gdbtypes.c (check_types_worklist): Update.
7984         (types_deeply_equal): Remove TRY/CATCH.  Update.
7985         * elfread.c (elf_symtab_read): Update.
7986         * dwarf2read.c: Don't include bcache.h.
7987         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7988         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7989         (print_bcache_statistics, bcache_memory_used): Don't declare.
7990         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7991         methods.  Rename all data members.
7992         * bcache.c (struct bcache): Move to bcache.h.
7993         (bcache::expand_hash_table): Rename from expand_hash_table.
7994         (bcache): Remove.
7995         (bcache::insert): Rename from bcache_full.
7996         (bcache::compare): Rename from bcache_compare.
7997         (bcache_xmalloc): Remove.
7998         (bcache::~bcache): Rename from bcache_xfree.
7999         (bcache::print_statistics): Rename from print_bcache_statistics.
8000         (bcache::memory_used): Rename from bcache_memory_used.
8001
8002 2019-03-07  Pedro Alves  <palves@redhat.com>
8003
8004         * infrun.c (normal_stop): Also check for
8005         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8006
8007 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
8008
8009         * f-lang.c (value_from_host_double): Moved to...
8010         * value.c (value_from_host_double): ...here.
8011         * value.h (value_from_host_double): Declare.
8012         * guile/scm-math.c (vlscm_convert_typed_number): Use
8013         value_from_host_double.
8014         (vlscm_convert_number): Likewise.
8015         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8016         * python/py-value.c (convert_value_from_python): Likewise.
8017
8018 2019-03-06  Tom Tromey  <tom@tromey.com>
8019
8020         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8021
8022 2019-03-06  Tom Tromey  <tom@tromey.com>
8023
8024         * utils.h (free_current_contents): Don't declare.
8025         * utils.c (free_current_contents): Remove.
8026
8027 2019-03-06  Tom Tromey  <tom@tromey.com>
8028
8029         * top.c (quit_force): Update.
8030         * main.c (captured_command_loop): Update.
8031         * common/new-op.c (operator new): Update.
8032         * common/common-exceptions.c (struct catcher)
8033         <save_cleanup_chain>: Remove member.
8034         (exceptions_state_mc_init): Update.
8035         (exception_try_scope_entry): Return nullptr.
8036         (exception_try_scope_exit, exception_rethrow)
8037         (throw_exception_sjlj, throw_exception_cxx): Update.
8038         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8039         (all_cleanups, do_cleanups, discard_cleanups)
8040         (discard_final_cleanups, save_cleanups, save_final_cleanups)
8041         (restore_cleanups, restore_final_cleanups): Don't declare.
8042         (do_final_cleanups): Remove parameter.
8043         * common/cleanups.c (cleanup_chain, make_cleanup)
8044         (make_cleanup_dtor, all_cleanups, do_cleanups)
8045         (discard_my_cleanups, discard_cleanups)
8046         (discard_final_cleanups, save_my_cleanups, save_cleanups)
8047         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8048         (null_cleanup): Remove.
8049         (do_final_cleanups): Remove parameter.
8050
8051 2019-03-06  Tom Tromey  <tom@tromey.com>
8052
8053         * remote.c (remote_target::remote_parse_stop_reply): Use
8054         unique_xmalloc_ptr.
8055
8056 2019-03-06  Tom Tromey  <tom@tromey.com>
8057
8058         * stabsread.c (struct stabs_field_info): Rename from field_info.
8059         <list, fnlist>: Add initializers.
8060         <obstack>: New member.
8061         (read_member_functions, read_struct_fields, read_baseclasses):
8062         Allocate on obstack.  Don't use cleanups.
8063         (read_one_struct_field, read_member_functions, read_struct_fields)
8064         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8065         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8066         (read_struct_type): Update.
8067
8068 2019-03-06  Tom Tromey  <tom@tromey.com>
8069
8070         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8071         * common/filestuff.h (make_cleanup_close): Don't declare.
8072         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8073         Remove.
8074
8075 2019-03-06  Tom Tromey  <tom@tromey.com>
8076
8077         * solib-aix.c: Use make_scope_exit.
8078
8079 2019-03-06  Tom Tromey  <tom@tromey.com>
8080
8081         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8082         Use make_scope_exit.
8083
8084 2019-03-06  Tom Tromey  <tom@tromey.com>
8085
8086         * solib-svr4.c (disable_probes_interface): Remove parameter.
8087         (svr4_handle_solib_event): Use make_scope_exit.
8088
8089 2019-03-06  Tom Tromey  <tom@tromey.com>
8090
8091         * remote.c (struct stop_reply_deleter): Remove.
8092         (stop_reply_up): Update.
8093         (struct stop_reply): Derive from notif_event.  Don't typedef.
8094         <regcache>: Now a std::vector.
8095         (stop_reply_xfree): Remove.
8096         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8097         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
8098         (remote_target::discard_pending_stop_replies): Use delete.
8099         (remote_target::remote_parse_stop_reply): Update.
8100         (remote_target::process_stop_reply): Update.
8101         * remote-notif.h (struct notif_event): Add virtual destructor.
8102         Remove "dtr" member.
8103         (struct notif_client) <alloc_event>: Return a unique_ptr.
8104         (notif_event_xfree): Don't declare.
8105         (notif_event_up): New typedef.
8106         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8107         (notif_event_xfree, do_notif_event_xfree): Remove.
8108         (remote_notif_state_xfree): Update.
8109
8110 2019-03-06  Tom Tromey  <tom@tromey.com>
8111
8112         * infrun.c (displaced_step_clear_cleanup): Now a
8113         forward_scope_exit type.
8114         (displaced_step_prepare_throw): Update.
8115         (displaced_step_fixup): Update.
8116
8117 2019-03-06  Tom Tromey  <tom@tromey.com>
8118
8119         * inferior.h (class inferior): Update comment.
8120         * gdbthread.h (class thread_info): Update comment.
8121
8122 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
8123             Tom Tromey  <tom@tromey.com>
8124
8125         * stabsread.h (struct stab_section_list): Remove.
8126         (coffstab_build_psymtabs): Update.
8127         * dbxread.c (symbuf_sections): Now a std::vector.
8128         (sect_idx): New global.
8129         (fill_symbuf): Update.
8130         (coffstab_build_psymtabs): Change type of stabsects parameter.
8131         Update.
8132         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8133         std::vector.
8134         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8135         (coff_locate_sections): Update.
8136         (coff_symfile_read): Remove cleanups.  Update.
8137         (init_stringtab): Add storage parameter.
8138         (free_stringtab, free_stringtab_cleanup): Remove.
8139         (init_lineno): Add storage parameter.
8140         (free_linetab, free_linetab_cleanup): Remove.
8141
8142 2019-03-06  Pedro Alves  <palves@redhat.com>
8143
8144         * linux-fork.c (fork_info::clobber_regs): Delete.
8145         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8146         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
8147         comment.  Adjust.
8148         (scoped_switch_fork_info::scoped_switch_fork_info)
8149         (checkpoint_command, linux_fork_context): Adjust
8150         fork_save_infrun_state calls.
8151
8152 2019-03-06  Pedro Alves  <palves@redhat.com>
8153
8154         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8155         (inf_has_multiple_threads): Return 'bool' and rewrite using
8156         inferior_info::threads().
8157
8158 2019-03-06  Pedro Alves  <palves@redhat.com>
8159
8160         * linux-fork.c: Include <list>.
8161         (fork_list): Now a std::list instance.
8162         (fork_info): Add ctor, dtor, and in-class initialize all fields.
8163         (forks_exist_p, find_last_fork): Adjust.
8164         (new_fork): Delete.
8165         (one_fork_p): New.
8166         (add_fork): Adjust.
8167         (free_fork): Delete, folded into fork_info::~fork_info().
8168         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
8169         Adjust.
8170         (init_fork_list): Delete.
8171         (linux_fork_killall, linux_fork_mourn_inferior)
8172         (linux_fork_detach, info_checkpoints_command): Adjust.
8173         (_initialize_linux_fork): No longer call init_fork_list.
8174
8175 2019-03-06  Pedro Alves  <palves@redhat.com>
8176
8177         * linux-fork.c (new_fork): New, split out of ...
8178         (add_fork): ... this.  Return void.  Move "first fork" special
8179         case from here, to ...
8180         (checkpoint_command): ... here.
8181         * linux-linux.h (add_fork): Return void.
8182
8183 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8184
8185         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8186
8187 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8188             Chris January  <chris.january@arm.com>
8189             David Lecomber  <david.lecomber@arm.com>
8190
8191         * f-exp.y: New token, UNOP_INTRINSIC.
8192         (exp): New pattern using UNOP_INTRINSIC token.
8193         (f77_keywords): Add 'abs' keyword.
8194         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8195         (value_from_host_double): New function.
8196         (evaluate_subexp_f): Support UNOP_ABS.
8197
8198 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8199
8200         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8201         types.
8202
8203 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8204
8205         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
8206         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
8207         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
8208
8209 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8210
8211         * f-exp.y (convert_to_kind_type): Handle more type kinds.
8212
8213 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8214             Chris January  <chris.january@arm.com>
8215
8216         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
8217         * f-exp.y: Define 'KIND' token.
8218         (exp): New pattern for KIND expressions.
8219         (ptype): Handle types with a kind extension.
8220         (direct_abs_decl): Extend to spot kind extensions.
8221         (f77_keywords): Add 'kind' to the list.
8222         (push_kind_type): New function.
8223         (convert_to_kind_type): New function.
8224         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8225         * parse.c (operator_length_standard): Likewise.
8226         * parser-defs.h (enum type_pieces): Add tp_kind.
8227         * std-operator.def: Add UNOP_KIND.
8228
8229 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8230
8231         * f-exp.y (f_parse): Set yydebug.
8232
8233 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8234
8235         * f-lang.c (evaluate_subexp_f): New function.
8236         (exp_descriptor_f): New global.
8237         (f_language_defn): Use exp_descriptor_f instead of
8238         exp_descriptor_standard.
8239
8240 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8241
8242         * f-exp.y (struct token): Add comments.
8243         (dot_ops): Remove uppercase versions and the end marker.
8244         (f77_keywords): Likewise.
8245         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8246         entries in the dot_ops array are case insensitive, and use
8247         strncasecmp to compare strings.  Also some whitespace cleanup in
8248         this area.  Similar for the f77_keywords array, except entries in
8249         this list might be case sensitive.
8250
8251 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8252
8253         * f-exp.y (struct f77_boolean_val): Add comments.
8254         (boolean_values): Remove uppercase versions, and end marker.
8255         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8256         and use strncasecmp to achieve case insensitivity.  Additionally,
8257         perform whitespace cleanup around this code.
8258
8259 2019-03-06  Tom Tromey  <tromey@adacore.com>
8260
8261         * remote-sim.c (gdbsim_target_open): Use result of
8262         gdb_argv::release.
8263
8264 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
8265         Dirk Schubert  <dirk.schubert@arm.com>
8266         Chris January  <chris.january@arm.com>
8267
8268         * eval.c (evaluate_subexp_standard): Call Fortran argument
8269         wrapping logic.
8270         * f-lang.c (struct value): A value which can be passed into a
8271         Fortran function call.
8272         (fortran_argument_convert): Wrap Fortran arguments in a pointer
8273         where appropriate.
8274         (struct type): Value ready for a Fortran function call.
8275         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8276         is needed.
8277         * f-lang.h (fortran_argument_convert): Declaration.
8278         (fortran_preserve_arg_pointer): Declaration.
8279         * infcall.c (value_arg_coerce): Call Fortran argument logic.
8280
8281 2019-03-05  Tom Tromey  <tromey@adacore.com>
8282
8283         * python/py-prettyprint.c (print_string_repr): Remove #if.
8284         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8285
8286 2019-03-05  Tom Tromey  <tromey@adacore.com>
8287
8288         * target.c (the_dummy_target): Move later.  Change type to
8289         "dummy_target".
8290         (initialize_targets): Don't initialize the_dummy_target.
8291
8292 2019-03-05  Tom Tromey  <tromey@adacore.com>
8293
8294         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8295         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8296
8297 2019-03-05  Tom Tromey  <tromey@adacore.com>
8298
8299         * windows-nat.c (windows_nat_target::attach)
8300         (windows_nat_target::detach): Don't call gdb_flush.
8301         * valprint.c (generic_val_print, val_print, val_print_string):
8302         Don't call gdb_flush.
8303         * utils.c (defaulted_query): Don't call gdb_flush.
8304         * typeprint.c (print_type_scalar): Don't call gdb_flush.
8305         * target.c (target_announce_detach): Don't call gdb_flush.
8306         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8307         * remote.c (extended_remote_target::attach): Don't call
8308         gdb_flush.
8309         * procfs.c (procfs_target::detach): Don't call gdb_flush.
8310         * printcmd.c (do_examine): Don't call gdb_flush.
8311         (info_display_command): Don't call gdb_flush.
8312         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8313         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8314         * memattr.c (info_mem_command): Don't call gdb_flush.
8315         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8316         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8317         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8318         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8319         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8320         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8321         (gnu_nat_target::detach): Don't call gdb_flush.
8322         * f-valprint.c (f_val_print): Don't call gdb_flush.
8323         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8324         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8325         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8326         gdb_flush.
8327         * c-valprint.c (c_val_print): Don't call gdb_flush.
8328         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8329
8330 2019-03-05  Tom Tromey  <tromey@adacore.com>
8331
8332         * varobj.c (update_dynamic_varobj_children): Update.
8333         (install_default_visualizer): Use reset, not release.
8334         * value.c (set_internalvar): Update.
8335         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8336         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8337         ATTRIBUTE_UNUSED_RESULT.
8338
8339 2019-03-05  Tom Tromey  <tromey@adacore.com>
8340
8341         * remote.c (class scoped_remote_fd) <release>: Add
8342         ATTRIBUTE_UNUSED_RESULT.
8343
8344 2019-03-05  Tom Tromey  <tromey@adacore.com>
8345
8346         * macroexp.c (struct macro_buffer) <release>: Add
8347         ATTRIBUTE_UNUSED_RESULT.
8348
8349 2019-03-05  Tom Tromey  <tromey@adacore.com>
8350
8351         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8352         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8353         ATTRIBUTE_UNUSED_RESULT.
8354
8355 2019-03-05  Tom Tromey  <tromey@adacore.com>
8356
8357         * common/scoped_fd.h (class scoped_fd) <release>: Add
8358         ATTRIBUTE_UNUSED_RESULT.
8359
8360 2019-03-05  Tom Tromey  <tromey@adacore.com>
8361
8362         * parser-defs.h (struct parser_state) <release>: Add
8363         ATTRIBUTE_UNUSED_RESULT.
8364
8365 2019-03-05  Tom Tromey  <tromey@adacore.com>
8366
8367         * utils.h (class gdb_argv) <release>: Add
8368         ATTRIBUTE_UNUSED_RESULT.
8369         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8370
8371 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
8372
8373         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8374         for-loop range, to avoid compiler warnings.
8375
8376         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8377         avoid compiler warnings about unused variables.
8378
8379         * NEWS: Mention end of support for native debugging on MS-Windows
8380         before XP.
8381
8382         PR gdb/24292
8383         * common/netstuff.c:
8384         * gdbserver/gdbreplay.c
8385         * gdbserver/remote-utils.c:
8386         * ser-tcp.c:
8387         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8388         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
8389         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8390         'getaddrinfo' and 'freeaddrinfo' were not available before
8391         Windows XP, and mingw.org's MinGW headers by default define
8392         _WIN32_WINNT to 0x500.
8393
8394 2019-03-01  Gary Benson <gbenson@redhat.com>
8395
8396         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8397
8398 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
8399             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
8400
8401         PR gdb/8527
8402         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8403         set_sigint_trap, clear_sigint_trap.
8404
8405 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8406
8407         * target.c (target_detach): Clear the regcache and the
8408         frame cache.
8409
8410 2019-02-27  Pedro Alves  <palves@redhat.com>
8411
8412         * utils.c (set_screen_size): When we cap the height/width sizes,
8413         tweak the corresponding command variable to show "unlimited":
8414
8415 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8416             Pedro Alves  <palves@redhat.com>
8417
8418         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8419         before calling rl_set_screen_size.
8420
8421 2019-02-27  Tom Tromey  <tromey@adacore.com>
8422
8423         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8424         define.
8425         * python/py-value.c: Remove Python 2.4 workaround.
8426         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8427         workaround.
8428         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8429         Python 2.4 workaround.
8430         * python/python-internal.h: Remove Python 2.4 comment.
8431         (Py_ssize_t): Don't define.
8432         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8433         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8434         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8435         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8436         * python/python.c (do_start_initialization): Remove Python 2.4
8437         workaround.
8438         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8439         (print_children): Remove Python 2.4 workaround.
8440         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8441         workaround.
8442         (CHARBUFFERPROC_NAME): Remove.
8443         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8444         Python 2.4 workaround.
8445
8446 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8447
8448         * NEWS: Note minimum Python version.
8449
8450 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8451
8452         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8453         code from these functions.  Remove corresponding ifdefs.  Use
8454         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8455         Remove gotos and target of gotos.
8456         (infpy_search_memory): Likewise.
8457
8458 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8459
8460         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8461         (hppa_gdbarch_init): Don't register deleted functions with
8462         gdbarch.
8463
8464 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8465
8466         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8467         (h8300_unwind_sp): Delete.
8468         (h8300_dummy_id): Delete.
8469         (h8300_gdbarch_init): Don't register deleted functions with
8470         gdbarch.
8471
8472 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8473
8474         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8475         (ft32_unwind_pc): Delete.
8476         (ft32_unwind_sp): Delete.
8477         (ft32_gdbarch_init): Don't register deleted functions with
8478         gdbarch.
8479
8480 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8481
8482         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8483         (frv_unwind_pc): Delete.
8484         (frv_unwind_sp): Delete.
8485         (frv_gdbarch_init): Don't register deleted functions with
8486         gdbarch.
8487
8488 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8489
8490         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8491         (riscv_unwind_pc): Delete.
8492         (riscv_unwind_sp): Delete.
8493         (riscv_gdbarch_init): Don't register deleted functions with
8494         gdbarch.
8495
8496 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8497
8498         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8499         (csky_unwind_pc): Delete.
8500         (csky_unwind_sp): Delete.
8501         (csky_gdbarch_init): Don't register deleted functions with
8502         gdbarch.
8503
8504 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8505
8506         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8507         (cris_unwind_pc): Delete.
8508         (cris_unwind_sp): Delete.
8509         (cris_gdbarch_init): Don't register deleted functions with
8510         gdbarch.
8511
8512 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8513
8514         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8515         (bfin_unwind_pc): Delete.
8516         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8517
8518 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8519
8520         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8521         (arm_unwind_pc): Delete.
8522         (arm_unwind_sp): Delete.
8523         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8524
8525 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8526
8527         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8528         (arc_unwind_pc): Delete.
8529         (arc_unwind_sp): Delete.
8530         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8531
8532 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8533
8534         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8535         (alpha_unwind_pc): Delete.
8536         (alpha_gdbarch_init): Don't register deleted functions with
8537         gdbarch.
8538
8539 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8540
8541         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8542         (aarch64_unwind_pc): Delete.
8543         (aarch64_unwind_sp): Delete.
8544         (aarch64_gdbarch_init): Don't register deleted functions with
8545         gdbarch.
8546
8547 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8548
8549         * gdbtypes.c (type_align): Don't consider static members when
8550         computing structure alignment.
8551
8552 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8553
8554         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8555         return 0 for other types.
8556         * arch-utils.c (default_type_align): Always return 0.
8557         * gdbarch.h: Regenerate.
8558         * gdbarch.sh (type_align): Extend comment.
8559         * gdbtypes.c (type_align): Add additional comments, always call
8560         gdbarch_type_align before applying the default rules.
8561         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8562         generic code will then apply a suitable default.
8563         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8564         types, return 0 for other types.
8565
8566 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8567
8568         * NEWS: Create a new section for the next release branch.
8569         Rename the section of the current branch, now that it has
8570         been cut.
8571
8572 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8573
8574         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8575         * version.in: Bump version to 8.3.50.DATE-git.
8576
8577 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8578
8579         * aix-thread.c (ptid_cmp): Remove unused variable.
8580         (get_signaled_thread): Likewise.
8581         (store_regs_user_thread): Likewise.
8582         (store_regs_kernel_thread): Likewise.
8583         (fetch_regs_kernel_thread): Remove shadowed variable.
8584
8585 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8586
8587         * features/riscv/32bit-cpu.xml: Add register numbers.
8588         * features/riscv/32bit-fpu.c: Regenerate.
8589         * features/riscv/32bit-fpu.xml: Add register numbers.
8590         * features/riscv/64bit-cpu.xml: Add register numbers.
8591         * features/riscv/64bit-fpu.c: Regenerate.
8592         * features/riscv/64bit-fpu.xml: Add register numbers.
8593
8594 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8595
8596         * NEWS: Mention two argument form of gdb.Value constructor.
8597         * python/py-value.c (convert_buffer_and_type_to_value): New
8598         function.
8599         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8600         Add support for handling an optional second argument.  Call
8601         convert_buffer_and_type_to_value as appropriate.
8602         * python/python-internal.h (Py_buffer_deleter): New struct.
8603         (Py_buffer_up): New typedef.
8604
8605 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8606
8607         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8608         instead of releasing ownership.
8609
8610 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8611
8612         * dwarf2read.c (open_and_init_dwp_file): Call
8613         elf_numsections instead of bfd_count_sections to initialize
8614         dwp_file->num_sections.
8615
8616 2019-02-25  Tom Tromey  <tromey@adacore.com>
8617
8618         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8619
8620 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8621
8622         * gcore.in: Add '--readnever' option when invoking GDB.
8623
8624 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8625
8626         * MAINTAINERS: Update my email address.
8627
8628 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8629
8630         * build-id.c (build_id_to_debug_bfd_1): New function.
8631         (build_id_to_debug_bfd): Look for separate debug file in
8632         sysroot.
8633
8634 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8635
8636         * gdbarch.sh: Update the copyright year range that is placed into
8637         generated files.
8638
8639 2019-02-22  Keith Seitz  <keiths@redhat.com>
8640
8641         PR symtab/23853
8642         * linespec.c (create_sals_line_offset): Search for the default
8643         symtab's filename instead of its fullname.
8644
8645 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8646
8647         * NEWS: Update style defaults.
8648
8649 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8650
8651         * main.c (captured_main_1): Disable styling in batch mode.
8652
8653 2019-02-20  Tom Tromey  <tom@tromey.com>
8654
8655         * symtab.c (symtab_symbol_info): Fix typos.
8656
8657 2019-02-20  Tom Tromey  <tromey@adacore.com>
8658
8659         * findcmd.c (_initialize_mem_search): Use upper case for
8660         metasyntactic variables.
8661
8662 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8663
8664         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8665         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8666
8667 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8668
8669         * top.h (source_file_name): Change to std::string.
8670         * top.c (source_file_name): Likewise.
8671         (command_line_input): Adjust.
8672         * cli/cli-script.c (script_from_file): Adjust.
8673
8674 2019-02-19  Tom Tromey  <tromey@adacore.com>
8675
8676         * ravenscar-thread.c
8677         (ravenscar_thread_target::update_thread_list): Don't call
8678         ada_build_task_list.
8679         * ada-lang.h (ada_build_task_list): Don't declare.
8680         * ada-tasks.c (struct ada_tasks_inferior_data)
8681         <task_list_valid_p>: Now bool.
8682         (read_known_tasks, ada_task_list_changed)
8683         (ada_tasks_invalidate_inferior_data): Update.
8684         (read_known_tasks_array): Return bool.
8685         (read_known_tasks_list): Likewise.
8686         (read_known_tasks): Return void.
8687         (ada_build_task_list): Now static.
8688
8689 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8690
8691         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8692         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8693
8694 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8695
8696         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8697         variant for ada_tasks_pspace_data_handle and
8698         ada_tasks_inferior_data_handle.
8699         (ada_tasks_pspace_data_cleanup): New function.
8700         (ada_tasks_inferior_data_cleanup): New function.
8701
8702 2019-02-17  Tom Tromey  <tom@tromey.com>
8703
8704         * macrotab.h (macro_source_fullname): Return a std::string.
8705         * macrotab.c (macro_include, check_for_redefinition)
8706         (macro_undef, macro_lookup_definition, foreach_macro)
8707         (foreach_macro_in_scope): Update.
8708         (macro_source_fullname): Return a std::string.
8709         * macrocmd.c (show_pp_source_pos): Update.
8710
8711 2019-02-17  Tom Tromey  <tom@tromey.com>
8712
8713         * macrocmd.c (show_pp_source_pos): Style the file names.
8714
8715 2019-02-17  Tom Tromey  <tom@tromey.com>
8716
8717         PR tui/24197:
8718         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8719
8720 2019-02-17  Tom Tromey  <tom@tromey.com>
8721
8722         * ada-lang.c (user_select_syms): Use filtered printing.
8723         * utils.c (wrap_style): New global.
8724         (desired_style): Remove.
8725         (emit_style_escape): Add stream parameter.
8726         (set_output_style, reset_terminal_style, prompt_for_continue):
8727         Update.
8728         (flush_wrap_buffer): Only flush gdb_stdout.
8729         (wrap_here): Set wrap_style.
8730         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8731         treat escape sequences as a character.  Change when wrap buffer is
8732         flushed.
8733         (fputs_styled): Do not set the output style when the default is
8734         requested.
8735         * ui-style.h (struct ui_file_style) <is_default>: New method.
8736         * source.c (print_source_lines_base): Emit escape sequences in one
8737         piece.
8738
8739 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8740
8741         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8742         integers and enumeration types.
8743
8744 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8745
8746         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8747         instead of lookup_symbol_in_language
8748         (do_exact_match): New function.
8749         (ada_get_symbol_name_matcher): Return do_exact_match when
8750         doing a verbatim match.
8751
8752 2019-02-15  Tom Tromey  <tromey@adacore.com>
8753
8754         * ravenscar-thread.c (ravenscar_thread_target::resume)
8755         (ravenscar_thread_target::wait): Special case wildcard requests.
8756
8757 2019-02-15  Tom Tromey  <tromey@adacore.com>
8758
8759         * ravenscar-thread.c (base_ptid): Remove.
8760         (struct ravenscar_thread_target) <close>: New method.
8761         <m_base_ptid>: New member.
8762         <update_inferior_ptid, active_task, task_is_currently_active,
8763         runtime_initialized>: Declare methods.
8764         <ravenscar_thread_target>: Add constructor.
8765         (ravenscar_thread_target::task_is_currently_active)
8766         (ravenscar_thread_target::update_inferior_ptid)
8767         (ravenscar_runtime_initialized): Rename.  Now methods.
8768         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8769         (ravenscar_thread_target::update_thread_list): Update.
8770         (ravenscar_thread_target::active_task): Now method.
8771         (ravenscar_thread_target::store_registers)
8772         (ravenscar_thread_target::prepare_to_store)
8773         (ravenscar_thread_target::prepare_to_store)
8774         (ravenscar_thread_target::mourn_inferior): Update.
8775         (ravenscar_inferior_created): Use "new" to create target.
8776         (ravenscar_thread_target::get_ada_task_ptid): Update.
8777         (_initialize_ravenscar): Don't initialize base_ptid.
8778         (ravenscar_ops): Remove global.
8779
8780 2019-02-15  Tom Tromey  <tromey@adacore.com>
8781
8782         * target.h (push_target): Declare new overload.
8783         * target.c (push_target): New overload, taking an rvalue reference.
8784         * remote.c (remote_target::open_1): Use push_target overload.
8785         * corelow.c (core_target_open): Use push_target overload.
8786
8787 2019-02-15  Tom Tromey  <tromey@adacore.com>
8788
8789         * ravenscar-thread.c (is_ravenscar_task)
8790         (ravenscar_task_is_currently_active): Return bool.
8791         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8792         (_initialize_ravenscar): Remove "(void)".
8793         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8794         Return bool.
8795
8796 2019-02-15  Tom Tromey  <tromey@adacore.com>
8797
8798         * ravenscar-thread.c (ravenscar_runtime_initializer)
8799         (has_ravenscar_runtime, get_running_thread_id)
8800         (ravenscar_thread_target::resume): Fix indentation.
8801
8802 2019-02-15  Tom Tromey  <tromey@adacore.com>
8803
8804         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8805         from ravenscar_arch_ops.
8806         (sparc_ravenscar_ops::fetch_registers)
8807         (sparc_ravenscar_ops::store_registers): Now methods.
8808         (sparc_ravenscar_prepare_to_store): Remove.
8809         (sparc_ravenscar_ops): Redefine.
8810         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8811         methods and destructor.  Remove members.
8812         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8813         (ravenscar_thread_target::store_registers)
8814         (ravenscar_thread_target::prepare_to_store): Update.
8815         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8816         Remove.
8817         (struct ppc_ravenscar_powerpc_ops): Derive from
8818         ravenscar_arch_ops.
8819         (ppc_ravenscar_powerpc_ops::fetch_registers)
8820         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8821         (ppc_ravenscar_powerpc_ops): Redefine.
8822         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8823         (ppc_ravenscar_e500_ops::fetch_registers)
8824         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8825         (ppc_ravenscar_e500_ops): Redefine.
8826         * aarch64-ravenscar-thread.c
8827         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8828         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8829         (aarch64_ravenscar_fetch_registers)
8830         (aarch64_ravenscar_store_registers): Now methods.
8831         (aarch64_ravenscar_ops): Redefine.
8832
8833 2019-02-15  Tom Tromey  <tromey@adacore.com>
8834
8835         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8836         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8837         (ravenscar_thread_target::stopped_by_watchpoint)
8838         (ravenscar_thread_target::stopped_data_address)
8839         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8840
8841 2019-02-15  Tom Tromey  <tromey@adacore.com>
8842
8843         * ravenscar-thread.c: Fix some typos.
8844
8845 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8846             Tom Tromey  <tromey@adacore.com>
8847
8848         * ada-lang.c (ada_exception_sal): Change addr_string to a
8849         std::string.
8850         (create_ada_exception_catchpoint): Update.
8851
8852 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8853             Tom Tromey  <tromey@adacore.com>
8854
8855         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8856         (bp_location_ops): Remove.
8857         (base_breakpoint_allocate_location): Update.
8858         (free_bp_location): Update.
8859         * ada-lang.c (class ada_catchpoint_location)
8860         <ada_catchpoint_location>: Remove ops parameter.
8861         (ada_catchpoint_location_dtor): Remove.
8862         (ada_catchpoint_location_ops): Remove.
8863         (allocate_location_exception): Update.
8864         * breakpoint.h (struct bp_location_ops): Remove.
8865         (class bp_location) <bp_location>: Remove bp_location_ops
8866         parameter.
8867         <~bp_location>: Add destructor.
8868         <ops>: Remove.
8869
8870 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8871             Pedro Alves  <palves@redhat.com>
8872
8873         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8874         'PATH_MAX'.
8875
8876 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8877             Samuel Thibault  <samuel.thibault@gnu.org>
8878             Thomas Schwinge  <thomas@codesourcery.com>
8879
8880         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8881         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8882
8883 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8884
8885         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8886         (check_empty): Use "const char *".
8887
8888         * gnu-nat.c (gnu_nat_target::detach): Instead of
8889         'detach_inferior (pid)' call
8890         'detach_inferior (find_inferior_pid (pid))'.
8891
8892         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8893         'nat/fork-inferior.o'.
8894         * gnu-nat.c: #include "nat/fork-inferior.h".
8895
8896         * gnu-nat.c (gnu_nat_target::detach): Instead of
8897         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8898         * gnu-nat.h: #include "inf-child.h".
8899         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8900         'i386_gnu_nat_target::fetch_registers'.
8901         (gnu_store_registers): Rename/move to
8902         'i386_gnu_nat_target::store_registers'.
8903
8904         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8905         * gnu-nat.h (mach_thread_info): New function.
8906         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8907
8908         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8909
8910 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8911
8912         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8913
8914 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8915
8916         * windows-nat.c (windows_add_thread): Add new parameter
8917         "main_thread_p" with default value set to false.  Update
8918         function documentation as well as all callers.
8919         (windows_delete_thread): Likewise.
8920         (fake_create_process): Update call to windows_add_thread.
8921         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8922         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8923         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8924         call to windows_delete_thread.
8925
8926 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8927
8928         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8929
8930 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8931
8932         * symfile.c (find_separate_debug_file): Use canonical path of
8933         sysroot with child_path instead of gdb_sysroot if it is valid.
8934
8935 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8936
8937         * symfile.c (find_separate_debug_file): Use child_path to
8938         determine if an object file is under a sysroot.
8939
8940 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8941
8942         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8943         unittests/child-path-selftests.c.
8944         * common/pathstuff.c (child_path): New function.
8945         * common/pathstuff.h (child_path): New prototype.
8946         * unittests/child-path-selftests.c: New file.
8947
8948 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8949
8950         * symfile.c (find_separate_debug_file): Look for separate debug
8951         files in debug directories under the sysroot.
8952
8953 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8954
8955         * symtab.h (struct minimal_symbol data_p): New const method.
8956         (struct minimal_symbol text_p): Likewise.
8957         * symtab.c (output_source_filename): Use file name style
8958         to print file name.
8959         (print_symbol_info): Likewise.
8960         (print_msymbol_info): Use address style to print addresses.
8961         Use function name style to print executable text symbols.
8962         (expand_symtab_containing_pc): Use data_p.
8963         (find_pc_sect_compunit_symtab): Likewise.
8964
8965 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8966
8967         * breakpoint.c (describe_other_breakpoints): Use address style
8968         to print addresses.
8969         (say_where): Likewise.
8970
8971 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8972
8973         * ada-typeprint.c (print_func_type): Print function name
8974         style to print function name.
8975         * c-typeprint.c (c_print_type_1): Likewise.
8976
8977 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8978
8979         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8980         for execve.
8981
8982 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8983
8984         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8985         type_stack.
8986
8987 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8988
8989         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8990         TYPE_CODE_REF types.
8991
8992 2019-02-08  Jim Wilson  <jimw@sifive.com>
8993
8994         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8995         (riscv_linux_fregset): New.
8996         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8997
8998 2019-02-07  Tom Tromey  <tom@tromey.com>
8999
9000         * thread.c (thread_cancel_execution_command): Update.
9001         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9002         methods.
9003         (struct thread_fsm_ops): Remove.
9004         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9005         (thread_fsm_should_stop, thread_fsm_return_value)
9006         (thread_fsm_set_finished, thread_fsm_finished_p)
9007         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9008         Don't declare.
9009         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9010         * infrun.c (clear_proceed_status_thread)
9011         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9012         (print_stop_event): Update.
9013         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9014         Add constructor.
9015         (step_command_fsm_ops): Remove.
9016         (new_step_command_fsm): Remove.
9017         (step_1): Update.
9018         (step_command_fsm::should_stop): Rename from
9019         step_command_fsm_should_stop.
9020         (step_command_fsm::clean_up): Rename from
9021         step_command_fsm_clean_up.
9022         (step_command_fsm::do_async_reply_reason): Rename from
9023         step_command_fsm_async_reply_reason.
9024         (struct until_next_fsm): Inherit from thread_fsm.  Add
9025         constructor.
9026         (until_next_fsm_ops): Remove.
9027         (new_until_next_fsm): Remove.
9028         (until_next_fsm::should_stop): Rename from
9029         until_next_fsm_should_stop.
9030         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9031         (until_next_fsm::do_async_reply_reason): Rename from
9032         until_next_fsm_async_reply_reason.
9033         (struct finish_command_fsm): Inherit from thread_fsm.  Add
9034         constructor.  Change type of breakpoint.
9035         (finish_command_fsm_ops): Remove.
9036         (new_finish_command_fsm): Remove.
9037         (finish_command_fsm::should_stop): Rename from
9038         finish_command_fsm_should_stop.
9039         (finish_command_fsm::clean_up): Rename from
9040         finish_command_fsm_clean_up.
9041         (finish_command_fsm::return_value): Rename from
9042         finish_command_fsm_return_value.
9043         (finish_command_fsm::do_async_reply_reason): Rename from
9044         finish_command_fsm_async_reply_reason.
9045         (finish_command): Update.
9046         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9047         Add constructor.
9048         (call_thread_fsm_ops): Remove.
9049         (call_thread_fsm::call_thread_fsm): Rename from
9050         new_call_thread_fsm.
9051         (call_thread_fsm::should_stop): Rename from
9052         call_thread_fsm_should_stop.
9053         (call_thread_fsm::should_notify_stop): Rename from
9054         call_thread_fsm_should_notify_stop.
9055         (run_inferior_call, call_function_by_hand_dummy): Update.
9056         * cli/cli-interp.c (should_print_stop_to_console): Update.
9057         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9058         Add constructor.  Change type of location_breakpoint,
9059         caller_breakpoint.
9060         (until_break_fsm_ops): Remove.
9061         (new_until_break_fsm): Remove.
9062         (until_break_fsm::should_stop): Rename from
9063         until_break_fsm_should_stop.
9064         (until_break_fsm::clean_up): Rename from
9065         until_break_fsm_clean_up.
9066         (until_break_fsm::do_async_reply_reason): Rename from
9067         until_break_fsm_async_reply_reason.
9068         (until_break_command): Update.
9069         * thread-fsm.c: Remove.
9070         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9071
9072 2019-02-07  Tom Tromey  <tom@tromey.com>
9073
9074         * yy-remap.h: Add include guard.
9075         * xtensa-tdep.h: Add include guard.
9076         * xcoffread.h: Rename include guard.
9077         * varobj-iter.h: Add include guard.
9078         * tui/tui.h: Rename include guard.
9079         * tui/tui-winsource.h: Rename include guard.
9080         * tui/tui-wingeneral.h: Rename include guard.
9081         * tui/tui-windata.h: Rename include guard.
9082         * tui/tui-win.h: Rename include guard.
9083         * tui/tui-stack.h: Rename include guard.
9084         * tui/tui-source.h: Rename include guard.
9085         * tui/tui-regs.h: Rename include guard.
9086         * tui/tui-out.h: Rename include guard.
9087         * tui/tui-layout.h: Rename include guard.
9088         * tui/tui-io.h: Rename include guard.
9089         * tui/tui-hooks.h: Rename include guard.
9090         * tui/tui-file.h: Rename include guard.
9091         * tui/tui-disasm.h: Rename include guard.
9092         * tui/tui-data.h: Rename include guard.
9093         * tui/tui-command.h: Rename include guard.
9094         * tic6x-tdep.h: Add include guard.
9095         * target/waitstatus.h: Rename include guard.
9096         * target/wait.h: Rename include guard.
9097         * target/target.h: Rename include guard.
9098         * target/resume.h: Rename include guard.
9099         * target-float.h: Rename include guard.
9100         * stabsread.h: Add include guard.
9101         * rs6000-tdep.h: Add include guard.
9102         * riscv-fbsd-tdep.h: Add include guard.
9103         * regformats/regdef.h: Rename include guard.
9104         * record.h: Rename include guard.
9105         * python/python.h: Rename include guard.
9106         * python/python-internal.h: Rename include guard.
9107         * python/py-stopevent.h: Rename include guard.
9108         * python/py-ref.h: Rename include guard.
9109         * python/py-record.h: Rename include guard.
9110         * python/py-record-full.h: Rename include guard.
9111         * python/py-record-btrace.h: Rename include guard.
9112         * python/py-instruction.h: Rename include guard.
9113         * python/py-events.h: Rename include guard.
9114         * python/py-event.h: Rename include guard.
9115         * procfs.h: Add include guard.
9116         * proc-utils.h: Add include guard.
9117         * p-lang.h: Add include guard.
9118         * or1k-tdep.h: Rename include guard.
9119         * observable.h: Rename include guard.
9120         * nto-tdep.h: Rename include guard.
9121         * nat/x86-linux.h: Rename include guard.
9122         * nat/x86-linux-dregs.h: Rename include guard.
9123         * nat/x86-gcc-cpuid.h: Add include guard.
9124         * nat/x86-dregs.h: Rename include guard.
9125         * nat/x86-cpuid.h: Rename include guard.
9126         * nat/ppc-linux.h: Rename include guard.
9127         * nat/mips-linux-watch.h: Rename include guard.
9128         * nat/linux-waitpid.h: Rename include guard.
9129         * nat/linux-ptrace.h: Rename include guard.
9130         * nat/linux-procfs.h: Rename include guard.
9131         * nat/linux-osdata.h: Rename include guard.
9132         * nat/linux-nat.h: Rename include guard.
9133         * nat/linux-namespaces.h: Rename include guard.
9134         * nat/linux-btrace.h: Rename include guard.
9135         * nat/glibc_thread_db.h: Rename include guard.
9136         * nat/gdb_thread_db.h: Rename include guard.
9137         * nat/gdb_ptrace.h: Rename include guard.
9138         * nat/fork-inferior.h: Rename include guard.
9139         * nat/amd64-linux-siginfo.h: Rename include guard.
9140         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9141         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9142         * nat/aarch64-linux.h: Rename include guard.
9143         * nat/aarch64-linux-hw-point.h: Rename include guard.
9144         * mn10300-tdep.h: Add include guard.
9145         * mips-linux-tdep.h: Add include guard.
9146         * mi/mi-parse.h: Rename include guard.
9147         * mi/mi-out.h: Rename include guard.
9148         * mi/mi-main.h: Rename include guard.
9149         * mi/mi-interp.h: Rename include guard.
9150         * mi/mi-getopt.h: Rename include guard.
9151         * mi/mi-console.h: Rename include guard.
9152         * mi/mi-common.h: Rename include guard.
9153         * mi/mi-cmds.h: Rename include guard.
9154         * mi/mi-cmd-break.h: Rename include guard.
9155         * m2-lang.h: Add include guard.
9156         * location.h: Rename include guard.
9157         * linux-record.h: Rename include guard.
9158         * linux-nat.h: Add include guard.
9159         * linux-fork.h: Add include guard.
9160         * i386-darwin-tdep.h: Rename include guard.
9161         * hppa-linux-offsets.h: Add include guard.
9162         * guile/guile.h: Rename include guard.
9163         * guile/guile-internal.h: Rename include guard.
9164         * gnu-nat.h: Rename include guard.
9165         * gdb-stabs.h: Rename include guard.
9166         * frv-tdep.h: Add include guard.
9167         * f-lang.h: Add include guard.
9168         * event-loop.h: Add include guard.
9169         * darwin-nat.h: Rename include guard.
9170         * cp-abi.h: Rename include guard.
9171         * config/sparc/nm-sol2.h: Rename include guard.
9172         * config/nm-nto.h: Rename include guard.
9173         * config/nm-linux.h: Add include guard.
9174         * config/i386/nm-i386gnu.h: Rename include guard.
9175         * config/djgpp/nl_types.h: Rename include guard.
9176         * config/djgpp/langinfo.h: Rename include guard.
9177         * compile/gcc-cp-plugin.h: Add include guard.
9178         * compile/gcc-c-plugin.h: Add include guard.
9179         * compile/compile.h: Rename include guard.
9180         * compile/compile-object-run.h: Rename include guard.
9181         * compile/compile-object-load.h: Rename include guard.
9182         * compile/compile-internal.h: Rename include guard.
9183         * compile/compile-cplus.h: Rename include guard.
9184         * compile/compile-c.h: Rename include guard.
9185         * common/xml-utils.h: Rename include guard.
9186         * common/x86-xstate.h: Rename include guard.
9187         * common/version.h: Rename include guard.
9188         * common/vec.h: Rename include guard.
9189         * common/tdesc.h: Rename include guard.
9190         * common/selftest.h: Rename include guard.
9191         * common/scoped_restore.h: Rename include guard.
9192         * common/scoped_mmap.h: Rename include guard.
9193         * common/scoped_fd.h: Rename include guard.
9194         * common/safe-iterator.h: Rename include guard.
9195         * common/run-time-clock.h: Rename include guard.
9196         * common/refcounted-object.h: Rename include guard.
9197         * common/queue.h: Rename include guard.
9198         * common/ptid.h: Rename include guard.
9199         * common/print-utils.h: Rename include guard.
9200         * common/preprocessor.h: Rename include guard.
9201         * common/pathstuff.h: Rename include guard.
9202         * common/observable.h: Rename include guard.
9203         * common/netstuff.h: Rename include guard.
9204         * common/job-control.h: Rename include guard.
9205         * common/host-defs.h: Rename include guard.
9206         * common/gdb_wait.h: Rename include guard.
9207         * common/gdb_vecs.h: Rename include guard.
9208         * common/gdb_unlinker.h: Rename include guard.
9209         * common/gdb_unique_ptr.h: Rename include guard.
9210         * common/gdb_tilde_expand.h: Rename include guard.
9211         * common/gdb_sys_time.h: Rename include guard.
9212         * common/gdb_string_view.h: Rename include guard.
9213         * common/gdb_splay_tree.h: Rename include guard.
9214         * common/gdb_setjmp.h: Rename include guard.
9215         * common/gdb_ref_ptr.h: Rename include guard.
9216         * common/gdb_optional.h: Rename include guard.
9217         * common/gdb_locale.h: Rename include guard.
9218         * common/gdb_assert.h: Rename include guard.
9219         * common/filtered-iterator.h: Rename include guard.
9220         * common/filestuff.h: Rename include guard.
9221         * common/fileio.h: Rename include guard.
9222         * common/environ.h: Rename include guard.
9223         * common/common-utils.h: Rename include guard.
9224         * common/common-types.h: Rename include guard.
9225         * common/common-regcache.h: Rename include guard.
9226         * common/common-inferior.h: Rename include guard.
9227         * common/common-gdbthread.h: Rename include guard.
9228         * common/common-exceptions.h: Rename include guard.
9229         * common/common-defs.h: Rename include guard.
9230         * common/common-debug.h: Rename include guard.
9231         * common/cleanups.h: Rename include guard.
9232         * common/buffer.h: Rename include guard.
9233         * common/btrace-common.h: Rename include guard.
9234         * common/break-common.h: Rename include guard.
9235         * cli/cli-utils.h: Rename include guard.
9236         * cli/cli-style.h: Rename include guard.
9237         * cli/cli-setshow.h: Rename include guard.
9238         * cli/cli-script.h: Rename include guard.
9239         * cli/cli-interp.h: Rename include guard.
9240         * cli/cli-decode.h: Rename include guard.
9241         * cli/cli-cmds.h: Rename include guard.
9242         * charset-list.h: Add include guard.
9243         * buildsym-legacy.h: Rename include guard.
9244         * bfin-tdep.h: Add include guard.
9245         * ax.h: Rename include guard.
9246         * arm-linux-tdep.h: Add include guard.
9247         * arm-fbsd-tdep.h: Add include guard.
9248         * arch/xtensa.h: Rename include guard.
9249         * arch/tic6x.h: Add include guard.
9250         * arch/i386.h: Add include guard.
9251         * arch/arm.h: Rename include guard.
9252         * arch/arm-linux.h: Rename include guard.
9253         * arch/arm-get-next-pcs.h: Rename include guard.
9254         * arch/amd64.h: Add include guard.
9255         * arch/aarch64-insn.h: Rename include guard.
9256         * arch-utils.h: Rename include guard.
9257         * annotate.h: Add include guard.
9258         * amd64-darwin-tdep.h: Rename include guard.
9259         * aarch64-linux-tdep.h: Add include guard.
9260         * aarch64-fbsd-tdep.h: Add include guard.
9261         * aarch32-linux-nat.h: Add include guard.
9262
9263 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9264
9265         * macrotab.c (macro_define_internal): New function that
9266         factorizes macro_define_object_internal and macro_define_function
9267         code.
9268         (macro_define_object_internal): Use macro_define_internal.
9269         (macro_define_function): Likewise.
9270
9271 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9272
9273         * macrocmd.c (extract_identifier): Return
9274         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9275         callers.
9276
9277 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
9278
9279         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9280
9281 2019-02-05  Tom Tromey  <tom@tromey.com>
9282
9283         * target.c (target_stack::unpush): Move assertion earlier.
9284
9285 2019-01-30  Tom Tromey  <tom@tromey.com>
9286
9287         PR python/23615:
9288         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9289         (gdbpy_parse_and_eval): Likewise.
9290         * python/python-internal.h (gdbpy_allow_threads): New class.
9291
9292 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
9293
9294         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9295         (aarch64_fbsd_fpregmap): Move earlier.
9296         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9297         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9298         instead of individual calls to trad_frame_set_reg_addr.
9299         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9300         earlier.
9301         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9302         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9303         instead of individual calls to trad_frame_set_reg_addr.
9304
9305 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
9306
9307         * CONTRIBUTE: Replace contribution list with wiki link.
9308
9309 2019-01-25  Tom Tromey  <tom@tromey.com>
9310
9311         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9312
9313 2019-01-25  Tom Tromey  <tom@tromey.com>
9314
9315         * xtensa-linux-nat.c: Fix common/ includes.
9316         * xml-support.h: Fix common/ includes.
9317         * xml-support.c: Fix common/ includes.
9318         * x86-linux-nat.c: Fix common/ includes.
9319         * windows-nat.c: Fix common/ includes.
9320         * varobj.h: Fix common/ includes.
9321         * varobj.c: Fix common/ includes.
9322         * value.c: Fix common/ includes.
9323         * valops.c: Fix common/ includes.
9324         * utils.c: Fix common/ includes.
9325         * unittests/xml-utils-selftests.c: Fix common/ includes.
9326         * unittests/utils-selftests.c: Fix common/ includes.
9327         * unittests/unpack-selftests.c: Fix common/ includes.
9328         * unittests/tracepoint-selftests.c: Fix common/ includes.
9329         * unittests/style-selftests.c: Fix common/ includes.
9330         * unittests/string_view-selftests.c: Fix common/ includes.
9331         * unittests/scoped_restore-selftests.c: Fix common/ includes.
9332         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9333         * unittests/scoped_fd-selftests.c: Fix common/ includes.
9334         * unittests/rsp-low-selftests.c: Fix common/ includes.
9335         * unittests/parse-connection-spec-selftests.c: Fix common/
9336         includes.
9337         * unittests/optional-selftests.c: Fix common/ includes.
9338         * unittests/offset-type-selftests.c: Fix common/ includes.
9339         * unittests/observable-selftests.c: Fix common/ includes.
9340         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9341         * unittests/memrange-selftests.c: Fix common/ includes.
9342         * unittests/memory-map-selftests.c: Fix common/ includes.
9343         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9344         * unittests/function-view-selftests.c: Fix common/ includes.
9345         * unittests/environ-selftests.c: Fix common/ includes.
9346         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9347         * unittests/common-utils-selftests.c: Fix common/ includes.
9348         * unittests/cli-utils-selftests.c: Fix common/ includes.
9349         * unittests/array-view-selftests.c: Fix common/ includes.
9350         * ui-file.c: Fix common/ includes.
9351         * tui/tui-io.c: Fix common/ includes.
9352         * tracepoint.h: Fix common/ includes.
9353         * tracepoint.c: Fix common/ includes.
9354         * tracefile-tfile.c: Fix common/ includes.
9355         * top.h: Fix common/ includes.
9356         * top.c: Fix common/ includes.
9357         * thread.c: Fix common/ includes.
9358         * target/waitstatus.h: Fix common/ includes.
9359         * target/waitstatus.c: Fix common/ includes.
9360         * target.h: Fix common/ includes.
9361         * target.c: Fix common/ includes.
9362         * target-memory.c: Fix common/ includes.
9363         * target-descriptions.c: Fix common/ includes.
9364         * symtab.h: Fix common/ includes.
9365         * symfile.c: Fix common/ includes.
9366         * stap-probe.c: Fix common/ includes.
9367         * spu-linux-nat.c: Fix common/ includes.
9368         * sparc-nat.c: Fix common/ includes.
9369         * source.c: Fix common/ includes.
9370         * solib.c: Fix common/ includes.
9371         * solib-target.c: Fix common/ includes.
9372         * ser-unix.c: Fix common/ includes.
9373         * ser-tcp.c: Fix common/ includes.
9374         * ser-pipe.c: Fix common/ includes.
9375         * ser-base.c: Fix common/ includes.
9376         * selftest-arch.c: Fix common/ includes.
9377         * s12z-tdep.c: Fix common/ includes.
9378         * rust-exp.y: Fix common/ includes.
9379         * rs6000-aix-tdep.c: Fix common/ includes.
9380         * riscv-tdep.c: Fix common/ includes.
9381         * remote.c: Fix common/ includes.
9382         * remote-notif.h: Fix common/ includes.
9383         * remote-fileio.h: Fix common/ includes.
9384         * remote-fileio.c: Fix common/ includes.
9385         * regcache.h: Fix common/ includes.
9386         * regcache.c: Fix common/ includes.
9387         * record-btrace.c: Fix common/ includes.
9388         * python/python.c: Fix common/ includes.
9389         * python/py-type.c: Fix common/ includes.
9390         * python/py-inferior.c: Fix common/ includes.
9391         * progspace.h: Fix common/ includes.
9392         * producer.c: Fix common/ includes.
9393         * procfs.c: Fix common/ includes.
9394         * proc-api.c: Fix common/ includes.
9395         * printcmd.c: Fix common/ includes.
9396         * ppc-linux-nat.c: Fix common/ includes.
9397         * parser-defs.h: Fix common/ includes.
9398         * osdata.c: Fix common/ includes.
9399         * obsd-nat.c: Fix common/ includes.
9400         * nat/x86-linux.c: Fix common/ includes.
9401         * nat/x86-linux-dregs.c: Fix common/ includes.
9402         * nat/x86-dregs.h: Fix common/ includes.
9403         * nat/x86-dregs.c: Fix common/ includes.
9404         * nat/ppc-linux.c: Fix common/ includes.
9405         * nat/mips-linux-watch.h: Fix common/ includes.
9406         * nat/mips-linux-watch.c: Fix common/ includes.
9407         * nat/linux-waitpid.c: Fix common/ includes.
9408         * nat/linux-ptrace.h: Fix common/ includes.
9409         * nat/linux-ptrace.c: Fix common/ includes.
9410         * nat/linux-procfs.c: Fix common/ includes.
9411         * nat/linux-personality.c: Fix common/ includes.
9412         * nat/linux-osdata.c: Fix common/ includes.
9413         * nat/linux-namespaces.c: Fix common/ includes.
9414         * nat/linux-btrace.h: Fix common/ includes.
9415         * nat/linux-btrace.c: Fix common/ includes.
9416         * nat/fork-inferior.c: Fix common/ includes.
9417         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9418         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9419         * nat/aarch64-linux.c: Fix common/ includes.
9420         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9421         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9422         * namespace.h: Fix common/ includes.
9423         * mips-linux-tdep.c: Fix common/ includes.
9424         * minsyms.c: Fix common/ includes.
9425         * mi/mi-parse.h: Fix common/ includes.
9426         * mi/mi-main.c: Fix common/ includes.
9427         * mi/mi-cmd-env.c: Fix common/ includes.
9428         * memrange.h: Fix common/ includes.
9429         * memattr.c: Fix common/ includes.
9430         * maint.h: Fix common/ includes.
9431         * maint.c: Fix common/ includes.
9432         * main.c: Fix common/ includes.
9433         * machoread.c: Fix common/ includes.
9434         * location.c: Fix common/ includes.
9435         * linux-thread-db.c: Fix common/ includes.
9436         * linux-nat.c: Fix common/ includes.
9437         * linux-fork.c: Fix common/ includes.
9438         * inline-frame.c: Fix common/ includes.
9439         * infrun.c: Fix common/ includes.
9440         * inflow.c: Fix common/ includes.
9441         * inferior.h: Fix common/ includes.
9442         * inferior.c: Fix common/ includes.
9443         * infcmd.c: Fix common/ includes.
9444         * inf-ptrace.c: Fix common/ includes.
9445         * inf-child.c: Fix common/ includes.
9446         * ia64-linux-nat.c: Fix common/ includes.
9447         * i387-tdep.c: Fix common/ includes.
9448         * i386-tdep.c: Fix common/ includes.
9449         * i386-linux-tdep.c: Fix common/ includes.
9450         * i386-linux-nat.c: Fix common/ includes.
9451         * i386-go32-tdep.c: Fix common/ includes.
9452         * i386-fbsd-tdep.c: Fix common/ includes.
9453         * i386-fbsd-nat.c: Fix common/ includes.
9454         * guile/scm-type.c: Fix common/ includes.
9455         * guile/guile.c: Fix common/ includes.
9456         * go32-nat.c: Fix common/ includes.
9457         * gnu-nat.c: Fix common/ includes.
9458         * gdbthread.h: Fix common/ includes.
9459         * gdbarch-selftests.c: Fix common/ includes.
9460         * gdb_usleep.c: Fix common/ includes.
9461         * gdb_select.h: Fix common/ includes.
9462         * gdb_bfd.c: Fix common/ includes.
9463         * gcore.c: Fix common/ includes.
9464         * fork-child.c: Fix common/ includes.
9465         * findvar.c: Fix common/ includes.
9466         * fbsd-nat.c: Fix common/ includes.
9467         * event-top.c: Fix common/ includes.
9468         * event-loop.c: Fix common/ includes.
9469         * dwarf2read.c: Fix common/ includes.
9470         * dwarf2loc.c: Fix common/ includes.
9471         * dwarf2-frame.c: Fix common/ includes.
9472         * dwarf-index-cache.c: Fix common/ includes.
9473         * dtrace-probe.c: Fix common/ includes.
9474         * disasm-selftests.c: Fix common/ includes.
9475         * defs.h: Fix common/ includes.
9476         * csky-tdep.c: Fix common/ includes.
9477         * cp-valprint.c: Fix common/ includes.
9478         * cp-support.h: Fix common/ includes.
9479         * cp-support.c: Fix common/ includes.
9480         * corelow.c: Fix common/ includes.
9481         * completer.h: Fix common/ includes.
9482         * completer.c: Fix common/ includes.
9483         * compile/compile.c: Fix common/ includes.
9484         * compile/compile-loc2c.c: Fix common/ includes.
9485         * compile/compile-cplus-types.c: Fix common/ includes.
9486         * compile/compile-cplus-symbols.c: Fix common/ includes.
9487         * command.h: Fix common/ includes.
9488         * cli/cli-dump.c: Fix common/ includes.
9489         * cli/cli-cmds.c: Fix common/ includes.
9490         * charset.c: Fix common/ includes.
9491         * build-id.c: Fix common/ includes.
9492         * btrace.h: Fix common/ includes.
9493         * btrace.c: Fix common/ includes.
9494         * breakpoint.h: Fix common/ includes.
9495         * breakpoint.c: Fix common/ includes.
9496         * ax.h: 
9497         (enum agent_op): Fix common/ includes.
9498         * ax-general.c (struct aop_map): Fix common/ includes.
9499         * ax-gdb.c: Fix common/ includes.
9500         * auxv.c: Fix common/ includes.
9501         * auto-load.c: Fix common/ includes.
9502         * arm-tdep.c: Fix common/ includes.
9503         * arch/riscv.c: Fix common/ includes.
9504         * arch/ppc-linux-common.c: Fix common/ includes.
9505         * arch/i386.c: Fix common/ includes.
9506         * arch/arm.c: Fix common/ includes.
9507         * arch/arm-linux.c: Fix common/ includes.
9508         * arch/arm-get-next-pcs.c: Fix common/ includes.
9509         * arch/amd64.c: Fix common/ includes.
9510         * arch/aarch64.c: Fix common/ includes.
9511         * arch/aarch64-insn.c: Fix common/ includes.
9512         * arch-utils.c: Fix common/ includes.
9513         * amd64-windows-tdep.c: Fix common/ includes.
9514         * amd64-tdep.c: Fix common/ includes.
9515         * amd64-sol2-tdep.c: Fix common/ includes.
9516         * amd64-obsd-tdep.c: Fix common/ includes.
9517         * amd64-nbsd-tdep.c: Fix common/ includes.
9518         * amd64-linux-tdep.c: Fix common/ includes.
9519         * amd64-linux-nat.c: Fix common/ includes.
9520         * amd64-fbsd-tdep.c: Fix common/ includes.
9521         * amd64-fbsd-nat.c: Fix common/ includes.
9522         * amd64-dicos-tdep.c: Fix common/ includes.
9523         * amd64-darwin-tdep.c: Fix common/ includes.
9524         * agent.c: Fix common/ includes.
9525         * ada-lang.h: Fix common/ includes.
9526         * ada-lang.c: Fix common/ includes.
9527         * aarch64-tdep.c: Fix common/ includes.
9528
9529 2019-01-25  Tom Tromey  <tom@tromey.com>
9530
9531         * common/create-version.sh: Use common/version.h.
9532
9533 2019-01-24  Pedro Alves  <palves@redhat.com>
9534
9535         * infrun.c (signal_stop, signal_print, signal_program)
9536         (signal_catch, signal_pass): Now arrays instead of pointers.
9537         (update_signals_program_target, do_target_resume)
9538         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9539         * linux-nat.c (linux_nat_target::pass_signals)
9540         (linux_nat_target::create_inferior, linux_nat_target::attach):
9541         Adjust.
9542         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9543         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9544         * procfs.c (procfs_target::pass_signals): Adjust.
9545         * record-full.c (record_full_target::resume): Adjust.
9546         * remote.c (remote_target::pass_signals)
9547         (remote_target::program_signals): Adjust.
9548         * target-debug.h (target_debug_print_signals): Now takes a
9549         gdb::array_view as parameter.  Adjust.
9550         * target.h (target_ops) <pass_signals, program_signals>: Replace
9551         pointer and length parameters with gdb::array_view.
9552         (target_pass_signals, target_program_signals): Likewise.
9553         * target-delegates.c: Regenerate.
9554
9555 2019-01-24  Pedro Alves  <palves@redhat.com>
9556
9557         * common/forward-scope-exit.h
9558         (forward_scope_exit::forward_scope_exit): Pass arguments to
9559         m_bind_function directly, instead of creating a std::bind and
9560         copying that.
9561
9562 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9563
9564         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9565         for static members.
9566         (pass_in_v_vfp_candidate): Likewise.
9567
9568 2019-01-23  Tom Tromey  <tom@tromey.com>
9569             Pedro Alves  <palves@redhat.com>
9570
9571         * regcache.c (class regcache_invalidator): Remove.
9572         (regcache::raw_write): Use make_scope_exit.
9573
9574 2019-01-23  Tom Tromey  <tom@tromey.com>
9575
9576         * ui-out.h (class ui_out_emit_type): Update comment.
9577
9578 2019-01-23  Tom Tromey  <tom@tromey.com>
9579
9580         * infrun.c (fetch_inferior_event): Update comment.
9581
9582 2019-01-23  Tom Tromey  <tom@tromey.com>
9583             Pedro Alves  <palves@redhat.com>
9584
9585         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9586         parameter.
9587         (fetch_inferior_event): Use SCOPE_EXIT.
9588
9589
9590 2019-01-23  Tom Tromey  <tom@tromey.com>
9591             Pedro Alves  <palves@redhat.com>
9592
9593         * infrun.c (disable_thread_events): Delete.
9594         (stop_all_threads): Use SCOPE_EXIT.
9595
9596 2019-01-23  Tom Tromey  <tom@tromey.com>
9597             Pedro Alves  <palves@redhat.com>
9598
9599         * symfile.c: Include forward-scope-exit.h.
9600         (clear_symtab_users_cleanup): Replace forward declaration with
9601         a FORWARD_SCOPE_EXIT.
9602         (syms_from_objfile_1): Use the forward_scope_exit and
9603         gdb::optional instead of cleanup_function.
9604         (reread_symbols): Use the forward_scope_exit instead of
9605         cleanup_function.
9606         (clear_symtab_users_cleanup): Remove function.
9607
9608 2019-01-23  Tom Tromey  <tom@tromey.com>
9609             Pedro Alves  <palves@redhat.com>
9610
9611         * linux-nat.c: Include scope-exit.h.
9612         (cleanup_target_stop): Remove.
9613         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9614         SCOPE_EXIT.
9615
9616 2019-01-23  Tom Tromey  <tom@tromey.com>
9617             Pedro Alves  <palves@redhat.com>
9618
9619         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9620         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9621
9622 2019-01-23  Tom Tromey  <tom@tromey.com>
9623             Andrew Burgess  <andrew.burgess@embecosm.com>
9624             Pedro Alves  <palves@redhat.com>
9625
9626         * infrun.c (fetch_inferior_event): Use scope_exit.
9627         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9628         * top.c (execute_command): Use scope_exit.
9629         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9630         * utils.c (do_bpstat_clear_actions_cleanup)
9631         (make_bpstat_clear_actions_cleanup): Remove.
9632
9633 2019-01-23  Tom Tromey  <tom@tromey.com>
9634             Pedro Alves  <palves@redhat.com>
9635
9636         * infrun.c: Include "common/scope-exit.h"
9637         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9638         (wait_for_inferior): Use SCOPE_EXIT.
9639         (fetch_inferior_event): Use scope_exit.
9640
9641 2019-01-23  Tom Tromey  <tom@tromey.com>
9642             Pedro Alves  <palves@redhat.com>
9643
9644         * breakpoint.c (create_breakpoint): Remove cleanup.
9645
9646 2019-01-23  Tom Tromey  <tom@tromey.com>
9647             Andrew Burgess  <andrew.burgess@embecosm.com>
9648             Pedro Alves  <palves@redhat.com>
9649
9650 2019-01-23  Pedro Alves  <palves@redhat.com>
9651
9652         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9653
9654 2019-01-23  Pedro Alves  <palves@redhat.com>
9655             Andrew Burgess  <andrew.burgess@embecosm.com>
9656
9657         * gdbthread.h: Include "common/forward-scope-exit.h".
9658         (scoped_finish_thread_state): Redefine custom class in terms of
9659         forward_scope_exit.
9660
9661 2019-01-23  Pedro Alves  <palves@redhat.com>
9662             Andrew Burgess  <andrew.burgess@embecosm.com>
9663
9664         * common/forward-scope-exit.h: New file.
9665
9666 2019-01-23  Pedro Alves  <palves@redhat.com>
9667             Andrew Burgess  <andrew.burgess@embecosm.com>
9668             Tom Tromey  <tom@tromey.com>
9669
9670         * common/scope-exit.h: New file.
9671
9672 2019-01-23  Pedro Alves  <palves@redhat.com>
9673
9674         * common/preprocessor.h (ESC): Rename to ...
9675         (ESC_PARENS): ... this.
9676         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9677         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9678
9679 2019-01-23  Tom Tromey  <tom@tromey.com>
9680
9681         * language.h (class scoped_switch_to_sym_language_if_auto):
9682         Initialize m_lang in both cases.
9683
9684 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9685
9686         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9687         with XCNEW.
9688
9689 2019-01-22  Tom Tromey  <tom@tromey.com>
9690
9691         * corelow.c: Do not include sys/file.h.
9692
9693 2019-01-22  Tom Tromey  <tom@tromey.com>
9694
9695         * tui/tui-wingeneral.h: Include gdb_curses.h.
9696
9697 2019-01-22  Tom Tromey  <tom@tromey.com>
9698
9699         * source-cache.h (class source_cache) <get_source_lines,
9700         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9701
9702 2019-01-22  Tom Tromey  <tom@tromey.com>
9703
9704         * remote-fileio.h (struct remote_target): Declare.
9705
9706 2019-01-22  Tom Tromey  <tom@tromey.com>
9707
9708         * python/py-arch.c: Do not include py-ref.h.
9709         * python/py-bpevent.c: Do not include py-ref.h.
9710         * python/py-cmd.c: Do not include py-ref.h.
9711         * python/py-continueevent.c: Do not include py-ref.h.
9712         * python/py-event.h: Do not include py-ref.h.
9713         * python/py-evtregistry.c: Do not include py-ref.h.
9714         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9715         * python/py-frame.c: Do not include py-ref.h.
9716         * python/py-framefilter.c: Do not include py-ref.h.
9717         * python/py-function.c: Do not include py-ref.h.
9718         * python/py-infevents.c: Do not include py-ref.h.
9719         * python/py-linetable.c: Do not include py-ref.h.
9720         * python/py-objfile.c: Do not include py-ref.h.
9721         * python/py-param.c: Do not include py-ref.h.
9722         * python/py-prettyprint.c: Do not include py-ref.h.
9723         * python/py-progspace.c: Do not include py-ref.h.
9724         * python/py-symbol.c: Do not include py-ref.h.
9725         * python/py-symtab.c: Do not include py-ref.h.
9726         * python/py-type.c: Do not include py-ref.h.
9727         * python/py-unwind.c: Do not include py-ref.h.
9728         * python/py-utils.c: Do not include py-ref.h.
9729         * python/py-value.c: Do not include py-ref.h.
9730         * python/py-varobj.c: Do not include py-ref.h.
9731         * python/py-xmethods.c: Do not include py-ref.h.
9732         * python/python.c: Do not include py-ref.h.
9733         * varobj.c: Do not include py-ref.h.
9734
9735 2019-01-22  Tom Tromey  <tom@tromey.com>
9736
9737         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9738         keyword for bcache.
9739
9740 2019-01-22  Tom Tromey  <tom@tromey.com>
9741
9742         * compile/compile-cplus-types.c: Remove a comment by #include.
9743
9744 2019-01-22  Tom Tromey  <tom@tromey.com>
9745
9746         * compile/gcc-c-plugin.h: Include compile-internal.h.
9747
9748 2019-01-22  Tom Tromey  <tom@tromey.com>
9749
9750         * stabsread.c (EXTERN): Do not define.
9751         (symnum, next_symbol_text_func, processing_gcc_compilation)
9752         (within_function, global_sym_chain, global_stabs)
9753         (previous_stab_code, this_object_header_files)
9754         (n_this_object_header_files)
9755         (n_allocated_this_object_header_files): Define.
9756         * stabsread.h (EXTERN): Never define.  Use "extern".
9757
9758 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9759
9760         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9761         history_value.
9762
9763 2019-01-21  Tom Tromey  <tom@tromey.com>
9764
9765         * ui-out.c: Fix includes.
9766         * tui/tui-source.c: Fix includes.
9767         * target.c: Fix includes.
9768         * remote.c: Fix includes.
9769         * regcache.c: Fix includes.
9770         * python/py-block.c: Fix includes.
9771         * printcmd.c: Fix includes.
9772         * or1k-tdep.c: Fix includes.
9773         * mi/mi-main.c: Fix includes.
9774         * m32r-tdep.c: Fix includes.
9775         * csky-tdep.c: Fix includes.
9776         * compile/compile-cplus-types.c: Fix includes.
9777         * cli/cli-interp.c: Fix includes.
9778
9779 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9780
9781         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9782         for padding.
9783
9784 2019-01-16  Tom Tromey  <tom@tromey.com>
9785
9786         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9787         earlier.
9788         (struct objfile) <msymbols_range>: Move from top level.
9789         <msymbols>: New method.
9790         (class objfile_msymbols): Remove.
9791         * symtab.c (default_collect_symbol_completion_matches_break_on):
9792         Update.
9793         * symmisc.c (dump_msymbols): Update.
9794         * stabsread.c (scan_file_globals): Update.
9795         * objc-lang.c (info_selectors_command, info_classes_command)
9796         (find_methods): Update.
9797         * minsyms.c (find_solib_trampoline_target): Update.
9798         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9799         * coffread.c (coff_symfile_read): Update.
9800         * ada-lang.c (ada_lookup_simple_minsym)
9801         (ada_collect_symbol_completion_matches): Update.
9802
9803 2019-01-16  Tom Tromey  <tom@tromey.com>
9804
9805         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9806         type.  Remove no-argument constructor.
9807         <iterator::operator++>: Simplify.
9808         <begin>: Update.
9809         <end>: Use minimal_symbol_count.
9810
9811 2019-01-16  Tom Tromey  <tom@tromey.com>
9812
9813         * objfiles.h (struct objfile) <psymtabs>: New method.
9814         (class objfile_psymtabs): Remove.
9815         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9816         typedef.
9817         <range>: New method.
9818         (require_partial_symbols): Change return type.
9819         * psymtab.c (require_partial_symbols)
9820         (psym_expand_symtabs_matching): Update.
9821         * mdebugread.c (parse_partial_symbols): Update.
9822         * dbxread.c (dbx_end_psymtab): Update.
9823
9824 2019-01-15  Tom Tromey  <tom@tromey.com>
9825
9826         * symtab.c (lookup_objfile_from_block)
9827         (lookup_symbol_in_objfile_symtabs)
9828         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9829         (find_line_symtab, info_sources_command)
9830         (default_collect_symbol_completion_matches_break_on)
9831         (make_source_files_completion_list): Update.
9832         * symmisc.c (print_objfile_statistics, dump_objfile)
9833         (maintenance_print_symbols, maintenance_info_symtabs)
9834         (maintenance_check_symtabs, maintenance_info_line_tables):
9835         Update.
9836         * source.c (select_source_symtab)
9837         (forget_cached_source_info_for_objfile): Update.
9838         * objfiles.h (class objfile_compunits): Remove.
9839         (struct objfile) <compunits_range>: New typedef.
9840         (compunits): New method.
9841         * objfiles.c (objfile_relocate1): Update.
9842         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9843         * maint.c (count_symtabs_and_blocks): Update.
9844         * linespec.c (iterate_over_all_matching_symtabs): Update.
9845         * cp-support.c (add_symbol_overload_list_qualified): Update.
9846         * coffread.c (coff_symtab_read): Update.
9847         * ada-lang.c (add_nonlocal_symbols)
9848         (ada_collect_symbol_completion_matches)
9849         (ada_add_global_exceptions): Update.
9850
9851 2019-01-15  Tom Tromey  <tom@tromey.com>
9852
9853         * progspace.h (program_space) <objfiles_safe_range>: New
9854         typedef.
9855         <objfiles_safe>: New method.
9856         * objfiles.h (class all_objfiles_safe): Remove.
9857         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9858         * jit.c (jit_inferior_exit_hook): Update.
9859
9860 2019-01-17  Tom Tromey  <tom@tromey.com>
9861
9862         * progspace.h (program_space) <objfiles_range>: New typedef.
9863         <objfiles>: New method.
9864         <objfiles_head>: Rename from objfiles.
9865         (object_files): Update.
9866         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9867         * guile/scm-pretty-print.c
9868         (ppscm_find_pretty_printer_from_objfiles): Update.
9869         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9870         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9871         Update.
9872         * python/py-progspace.c (pspy_get_objfiles): Update.
9873         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9874         Update.
9875         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9876         (objfpy_lookup_objfile_by_build_id): Update.
9877         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9878         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9879         Update.
9880         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9881         (expand_symtab_containing_pc, lookup_objfile_from_block)
9882         (lookup_static_symbol, basic_lookup_transparent_type)
9883         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9884         (find_line_symtab, info_sources_command)
9885         (default_collect_symbol_completion_matches_break_on)
9886         (make_source_files_completion_list, find_main_name): Update.
9887         * symmisc.c (print_symbol_bcache_statistics)
9888         (print_objfile_statistics, maintenance_print_symbols)
9889         (maintenance_print_msymbols, maintenance_print_objfiles)
9890         (maintenance_info_symtabs, maintenance_check_symtabs)
9891         (maintenance_expand_symtabs, maintenance_info_line_tables):
9892         Update.
9893         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9894         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9895         (map_overlay_command, unmap_overlay_command)
9896         (simple_overlay_update, expand_symtabs_matching)
9897         (map_symbol_filenames): Update.
9898         * symfile-debug.c (set_debug_symfile): Update.
9899         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9900         Update.
9901         * source.c (select_source_symtab, forget_cached_source_info):
9902         Update.
9903         * solib.c (solib_read_symbols): Update.
9904         * solib-spu.c (append_ocl_sos): Update.
9905         * psymtab.c (maintenance_print_psymbols)
9906         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9907         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9908         * printcmd.c (info_symbol_command): Update.
9909         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9910         Update.
9911         * objfiles.h (class all_objfiles): Remove.
9912         * objfiles.c (have_partial_symbols, have_full_symbols)
9913         (have_minimal_symbols, qsort_cmp, update_section_map)
9914         (shared_objfile_contains_address_p)
9915         (default_iterate_over_objfiles_in_search_order): Update.
9916         * objc-lang.c (info_selectors_command, info_classes_command)
9917         (find_methods): Update.
9918         * minsyms.c (find_solib_trampoline_target): Update.
9919         * maint.c (maintenance_info_sections)
9920         (maintenance_translate_address, count_symtabs_and_blocks):
9921         Update.
9922         * main.c (captured_main_1): Update.
9923         * linux-thread-db.c (try_thread_db_load_from_pdir)
9924         (has_libpthread): Update.
9925         * linespec.c (iterate_over_all_matching_symtabs)
9926         (search_minsyms_for_name): Update.
9927         * jit.c (jit_find_objf_with_entry_addr): Update.
9928         * hppa-tdep.c (find_unwind_entry)
9929         (hppa_lookup_stub_minimal_symbol): Update.
9930         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9931         Update.
9932         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9933         (elf_gnu_ifunc_resolve_by_got): Update.
9934         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9935         * dwarf-index-write.c (save_gdb_index_command): Update.
9936         * cp-support.c (add_symbol_overload_list_qualified): Update.
9937         * breakpoint.c (create_overlay_event_breakpoint)
9938         (create_longjmp_master_breakpoint)
9939         (create_std_terminate_master_breakpoint)
9940         (create_exception_master_breakpoint): Update.
9941         * blockframe.c (find_pc_partial_function): Update.
9942         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9943         (ada_collect_symbol_completion_matches)
9944         (ada_add_global_exceptions): Update.
9945
9946 2019-01-17  Tom Tromey  <tom@tromey.com>
9947
9948         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9949         declare VEC.
9950         (solib_target_parse_libraries): Change return type.
9951         (library_list_start_segment, library_list_start_section)
9952         (library_list_end_library, library_list_start_library); Update.
9953         (solib_target_free_library_list): Remove.
9954         (solib_target_parse_libraries): Remove cleanup.  Change return
9955         type.
9956         (solib_target_current_sos): Update.
9957
9958 2019-01-17  Tom Tromey  <tromey@bapiya>
9959
9960         * valprint.c: Replace "the the" with "the".
9961         * symtab.c: Replace "the the" with "the".
9962         * solib.c: Replace "the the" with "the".
9963         * solib-dsbt.c: Replace "the the" with "the".
9964         * linespec.c: Replace "the the" with "the".
9965         * dwarf2loc.h: Replace "the the" with "the".
9966         * amd64-windows-tdep.c: Replace "the the" with "the".
9967         * aarch64-tdep.c: Replace "the the" with "the".
9968
9969 2019-01-16  Keith Seitz  <keiths@redhat.com>
9970
9971         PR gdb/23773
9972         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9973         <builder>: Rename to ..
9974         <m_builder>: ... this and make private.
9975         (dwarf2_cu::get_builder): New method.  Change all users of
9976         `builder' to use this method.
9977         (dwarf2_start_symtab): Move to ...
9978         (dwarf2_cu::start_symtab): ... here.  Update all callers
9979         (setup_type_unit_groups): Move to ...
9980         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9981         callers.
9982         (dwarf2_cu::reset_builder): New method.
9983         (process_full_compunit, process_full_type_unit): Use
9984         dwarf2_cu::reset_builder.
9985         (follow_die_offset): Record the ancestor CU if it is different
9986         from the followed DIE's CU.
9987         (follow_die_sig_1): Likewise.
9988
9989 2019-01-15  Tom Tromey  <tom@tromey.com>
9990
9991         * remote.c (class remote_state) <buf>: Now a char_vector.
9992         <buf_size>: Remove.
9993         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9994         parameter.
9995         (remote_target::getpkt_or_notif_sane_1)
9996         (remote_target::getpkt_sane)
9997         (remote_target::getpkt_or_notif_sane): Likewise.
9998         (class remote_target) <putpkt>: New overload.
9999         (remote_target::read_frame): Change type of "buf_p".  Remove
10000         sizeof_p parameter.
10001         (packet_ok): New overload.
10002         (packet_check_result): New overload.
10003         Update all uses.
10004
10005 2019-01-14  Tom Tromey  <tom@tromey.com>
10006
10007         * remote-notif.c (handle_notification, remote_notif_ack)
10008         (remote_notif_parse): Make "buf" const.
10009         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10010         const.
10011         (remote_notif_parse, remote_notif_ack, handle_notification):
10012         Likewise.
10013         * remote.c (remote_notif_stop_parse): Make "buf" const.
10014         (remote_target::remote_parse_stop_reply): Make "buf" const.
10015         (remote_notif_stop_ack): Make "buf" const.
10016
10017 2019-01-14  Tom Tromey  <tom@tromey.com>
10018
10019         * remote.c (remote_console_output): Make parameter const.
10020
10021 2019-01-14  Tom Tromey  <tom@tromey.com>
10022
10023         * target-debug.h (target_debug_print_signals): Constify.
10024         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10025         * procfs.c (procfs_target::pass_signals): Update.
10026         * linux-nat.c (linux_nat_target::pass_signals): Update.
10027         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10028         * target-delegates.c: Rebuild.
10029         * remote.c (remote_target::program_signals): Update.
10030         (remote_target::pass_signals): Update.
10031         * target.c (target_pass_signals): Constify argument.
10032         (target_program_signals): Likewise.
10033         * target.h (struct target_ops) <pass_signals, program_signals>:
10034         Constify argument.
10035         (target_pass_signals, target_program_signals): Constify argument.
10036
10037 2019-01-14  Tom Tromey  <tom@tromey.com>
10038
10039         PR tui/28819:
10040         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10041
10042 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
10043
10044         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10045         field.
10046         * rs6000-tdep.c: Include reggroups.h.
10047         (IS_V_ALIAS_PSEUDOREG): Define.
10048         (rs6000_register_name): Return names for the "vX" aliases.
10049         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10050         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
10051         aliases.  Call default_register_reggroup_p for all other
10052         pseudo-registers.
10053         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10054         New functions.
10055         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10056         Handle "vX" aliases.
10057         (v_alias_pseudo_register_collect): New function.
10058         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10059         (rs6000_gdbarch_init): Initialize "vX" aliases as
10060         pseudo-registers.  Restore registration of
10061         rs6000_pseudo_register_reggroup_p with
10062         set_tdesc_pseudo_register_reggroup_p.
10063
10064 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
10065
10066         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10067         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10068         set_gdbarch_num_pseudo_regs.
10069
10070 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10071
10072         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10073         Remove arg prefixname, add do_set and do_show.
10074         Add member functions set_list and show_list.
10075         * cli/cli-style.c (class cli_style_option): Update accordingly.
10076         (style_set_list): Move to file scope.
10077         (style_show_list): Likewise.
10078         (set_style): Call help_list.
10079         (show_style): Call cmd_show_list.
10080         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10081         Update to use the new macro.
10082
10083 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
10084
10085         * ada-lang.c (_initialize_ada_language): Expand the help text
10086         for the "catch exception" command.
10087
10088 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10089
10090         * symtab.c (matching_obj_sections): Initialize obj,
10091         declare it closer to its usage.
10092
10093 2019-01-10  Tom Tromey  <tom@tromey.com>
10094
10095         * thread-iter.h (inf_threads_iterator): Use next_iterator.
10096         (basic_inf_threads_range): Remove.
10097         (inf_threads_range, inf_non_exited_threads_range)
10098         (safe_inf_threads_range): Use next_adapter.
10099
10100 2019-01-10  Keith Seitz  <keiths@redhat.com>
10101
10102         PR gdb/23712
10103         PR symtab/23010
10104         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10105         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10106
10107 2019-01-10  Keith Seitz  <keiths@redhat.com>
10108
10109         PR gdb/23712
10110         PR symtab/23010
10111         * dictionary.c (pending_to_vector): Remove.
10112         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10113         Remove _1 suffix, replacing functions of the same name.  Update
10114         all callers.
10115         (dict_create_hashed, dict_create_hashed_expandable)
10116         (dict_create_linear, dict_create_linear_expandable, dict_free)
10117         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10118         Make functions static.
10119
10120 2019-01-10  Keith Seitz  <keiths@redhat.com>
10121
10122         PR gdb/23712
10123         PR symtab/23010
10124         * dictionary.h (struct dictionary): Replace declaration with
10125         multidictionary.
10126         (dict_create_hashed, dict_create_hashed_expandable)
10127         (dict_create_linear, dict_create_linear_expandable)
10128         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10129         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10130         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10131         taking multidictionary argument.
10132         [ALL_DICT_SYMBOLS]: Update for multidictionary.
10133         * block.h (struct block) <dict>: Change to multidictionary
10134         and rename `multidict'.
10135         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10136         symmisc.c: Update all dictionary references to multidictionary.
10137
10138 2019-01-10  Keith Seitz  <keiths@redhat.com>
10139
10140         PR gdb/23712
10141         PR symtab/23010
10142         * dictionary.c: Include unordered_map.
10143         (pending_to_vector): New function.
10144         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10145         Rewrite the non-"_1" functions to take vector instead
10146         of linked list.
10147         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10148         "new" _1 versions of the same name.
10149         (multidictionary): Define.
10150         (std::hash<enum language): New definition.
10151         (collate_pending_symbols_by_language, mdict_create_hashed)
10152         (mdict_create_hashed_expandable, mdict_create_linear)
10153         (mdict_create_linear_expandable, mdict_free)
10154         (find_language_dictionary, create_new_language_dictionary)
10155         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10156         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
10157         (mdict_size, mdict_empty): New functions.
10158         * dictionary.h (mdict_iterator): Define.
10159
10160 2019-01-10  Pedro Alves  <palves@redhat.com>
10161
10162         * breakpoint.c (read_uploaded_action)
10163         (create_tracepoint_from_upload): Adjust to use
10164         gdb::unique_xmalloc_ptr.
10165         * ctf.c (ctf_write_uploaded_tp):
10166         (SET_ARRAY_FIELD): Use emplace_back.
10167         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
10168         * tracefile-tfile.c (tfile_write_uploaded_tp):
10169         * tracepoint.c (parse_tracepoint_definition): Adjust to use
10170         gdb::unique_xmalloc_ptr.
10171         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10172         at_string, cond_string, cmd_strings>: Replace char pointers
10173         with gdb::unique_xmalloc_ptr.
10174
10175 2019-01-10  Pedro Alves  <palves@redhat.com>
10176
10177         * solib-target.c (library_list_start_library): Don't xstrdup name.
10178
10179 2019-01-10  Pedro Alves  <palves@redhat.com>
10180
10181         * mdebugread.c (parse_partial_symbols): Use
10182         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10183
10184 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10185
10186         * linux-fork.c (scoped_switch_fork_info)
10187         <~scoped_switch_fork_info>: Fix incorrect variable name.
10188
10189 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10190
10191         * linux-fork.c (scoped_switch_fork_info)
10192         <scoped_switch_fork_info>: Make explicit.
10193         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10194
10195 2019-01-10  Tom Tromey  <tom@tromey.com>
10196
10197         * objfiles.h (objfile::reset_psymtabs): Update.
10198         * objfiles.c (objfile::objfile): Update.
10199         * psymtab.h (psymtab_storage::obstack): Update.
10200         (psymtab_storage::m_obstack): Use gdb::optional.
10201         (class psymtab_storage): Update comment.  Remove objfile
10202         parameter.
10203         * psymtab.c (psymtab_storage::psymtab_storage): Update.
10204
10205 2019-01-10  Tom Tromey  <tom@tromey.com>
10206
10207         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
10208         <free_psymtabs>: Now private.
10209         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
10210         (allocate_psymtab): Use new method.
10211
10212 2019-01-10  Tom Tromey  <tom@tromey.com>
10213
10214         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
10215         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
10216         * mdebugread.c (parse_partial_symbols): Use
10217         allocate_dependencies.
10218         * dwarf2read.c (dwarf2_create_include_psymtab): Use
10219         allocate_dependencies.
10220         (process_psymtab_comp_unit_reader)
10221         (build_type_psymtab_dependencies): Likewise.
10222         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
10223
10224 2019-01-10  Tom Tromey  <tom@tromey.com>
10225
10226         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
10227         PSYMBOL_SET_LANGUAGE.
10228         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
10229
10230 2019-01-10  Tom Tromey  <tom@tromey.com>
10231
10232         * psymtab.h (psymtab_storage::obstack): New method.
10233         <m_obstack>: Rename from obstack; now private.
10234         * psymtab.c (psymtab_storage): Update.
10235         * dwarf2read.c (create_addrmap_from_index)
10236         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10237         Update.
10238
10239 2019-01-10  Tom Tromey  <tom@tromey.com>
10240
10241         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10242         * objfiles.h (objfile::reset_psymtabs): New method.
10243
10244 2019-01-10  Tom Tromey  <tom@tromey.com>
10245
10246         * symmisc.c (print_symbol_bcache_statistics): Update.
10247         (print_objfile_statistics): Update.
10248         * symfile.c (reread_symbols): Update.
10249         * psymtab.h (class psymtab_storage): New.
10250         * psymtab.c (psymtab_storage): New constructor.
10251         (~psymtab_storage): New destructor.
10252         (require_partial_symbols): Update.
10253         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10254         (find_pc_sect_psymtab, find_pc_sect_psymbol)
10255         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10256         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10257         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10258         (start_psymtab_common, end_psymtab_common)
10259         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10260         (allocate_psymtab): Update.
10261         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10262         Update.
10263         (dump_psymtab_addrmap, maintenance_print_psymbols)
10264         (maintenance_check_psymtabs): Update.
10265         (class objfile_psymtabs): Move to objfiles.h.
10266         * psympriv.h (discard_psymtab): Now inline.
10267         (psymtab_discarder::psymtab_discarder): Update.
10268         (psymtab_discarder::~psymtab_discarder): Update.
10269         (ALL_OBJFILE_PSYMTABS): Rewrite.
10270         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10271         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10272         Remove fields.
10273         <partial_symtabs>: New field.
10274         (class objfile_psymtabs): Move from psymtab.h.  Update.
10275         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10276         psymbol_cache.
10277         (objfile::~objfile): Don't destroy psymbol_cache.
10278         * mdebugread.c (parse_partial_symbols): Update.
10279         * dwarf2read.c (create_addrmap_from_index)
10280         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10281         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10282         (add_partial_subprogram, dwarf2_ranges_read): Update.
10283         * dwarf-index-write.c (write_address_map)
10284         (write_one_signatured_type, recursively_write_psymbols)
10285         (class debug_names, class debug_names, write_psymtabs_to_index):
10286         Update.
10287
10288 2019-01-10  Tom Tromey  <tom@tromey.com>
10289
10290         * symtab.h (SYMBOL_SET_NAMES): Update.
10291         (symbol_set_names): Update.
10292         (MSYMBOL_SET_NAMES): Update.
10293         * symtab.c (symbol_set_names): Change argument to be an
10294         objfile_per_bfd_storage.
10295         * psymtab.c (add_psymbol_to_bcache): Update.
10296         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10297
10298 2019-01-10  Tom Tromey  <tom@tromey.com>
10299
10300         * symtab.c (create_demangled_names_hash): Change argument to be an
10301         objfile_per_bfd_storage.
10302         (symbol_set_names): Update.
10303
10304 2019-01-10  Tom Tromey  <tom@tromey.com>
10305
10306         * xcoffread.c (xcoff_initial_scan): Unconditionally call
10307         init_psymbol_list.
10308         * psymtab.c (init_psymbol_list): Do nothing if already called.
10309         * psympriv.h (init_psymbol_list): Add comment.
10310         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10311         init_psymbol_list.
10312         * dbxread.c (dbx_symfile_read): Unconditionally call
10313         init_psymbol_list.
10314
10315 2019-01-10  Tom Tromey  <tom@tromey.com>
10316
10317         * xcoffread.c (scan_xcoff_symtab): Update.
10318         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10319         "where".
10320         * mdebugread.c (parse_partial_symbols)
10321         (handle_psymbol_enumerators): Update.
10322         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10323         * dbxread.c (read_dbx_symtab): Update.
10324         * psympriv.h (psymbol_placement): New enum.
10325         (add_psymbol_to_list): Update.
10326
10327 2019-01-10  Tom Tromey  <tom@tromey.com>
10328
10329         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10330         static_psymbols parameters.
10331         (scan_xcoff_symtab): Update.
10332         * psymtab.c (start_psymtab_common): Remove global_psymbols and
10333         static_psymbols parameters.
10334         * psympriv.h (start_psymtab_common): Update.
10335         * mdebugread.c (parse_partial_symbols): Update.
10336         * dwarf2read.c (create_partial_symtab): Update.
10337         * dbxread.c (read_dbx_symtab): Update.
10338         (start_psymtab): Remove global_psymbols and static_psymbols
10339         parameters.
10340
10341 2019-01-10  Tom Tromey  <tom@tromey.com>
10342
10343         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10344         * psymtab.c (allocate_psymtab): Add comment.
10345         * psympriv.h (allocate_psymtab): Add comment.
10346         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10347         initializations.
10348         * dbxread.c (dbx_end_psymtab): Remove some initializations.
10349
10350 2019-01-10  Tom Tromey  <tom@tromey.com>
10351
10352         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10353         Don't declare.
10354         * mipsread.c: Include mdebugread.h.
10355         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10356         Declare.
10357         * elfread.c: Include mdebugread.h.
10358
10359 2019-01-09  Tom Tromey  <tom@tromey.com>
10360
10361         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10362         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10363         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10364         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10365         (psym_lookup_symbol, psym_find_last_source_symtab)
10366         (psym_forget_cached_source_info, psym_print_stats)
10367         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10368         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10369         (psym_map_matching_symbols, psym_expand_symtabs_matching)
10370         (psym_find_compunit_symtab_by_address)
10371         (maintenance_print_psymbols, maintenance_info_psymtabs)
10372         (maintenance_check_psymtabs): Use ranged for.
10373         * psymtab.h (class objfile_psymtabs): New.
10374         (require_partial_symbols): Return objfile_psymtabs.
10375         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10376
10377 2019-01-09  Tom Tromey  <tom@tromey.com>
10378
10379         * symfile.c (overlay_invalidate_all, find_pc_overlay)
10380         (find_pc_mapped_section, list_overlays_command)
10381         (map_overlay_command, unmap_overlay_command)
10382         (simple_overlay_update): Use all_objfiles.
10383         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10384         * printcmd.c (info_symbol_command): Use all_objfiles.
10385         * objfiles.h (ALL_OBJSECTIONS): Remove.
10386         * maint.c (maintenance_translate_address): Use all_objfiles.
10387         * gcore.c (gcore_create_callback): Use all_objfiles.
10388         (objfile_find_memory_regions): Likewise.
10389
10390 2019-01-09  Tom Tromey  <tom@tromey.com>
10391
10392         * symtab.c (find_line_symtab, info_sources_command)
10393         (make_source_files_completion_list): Use objfile_compunits.
10394         * source.c (select_source_symtab): Use objfile_compunits.
10395         * objfiles.h (struct objfile): Update comment.
10396         (ALL_OBJFILES): Remove.
10397         (ALL_FILETABS): Remove.
10398         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10399         objfile_compunits.
10400
10401 2019-01-09  Tom Tromey  <tom@tromey.com>
10402
10403         * symmisc.c (print_objfile_statistics, dump_objfile)
10404         (maintenance_print_symbols): Use compunit_filetabs.
10405         * source.c (forget_cached_source_info_for_objfile): Use
10406         compunit_filetabs.
10407         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10408         (ALL_FILETABS): Use compunit_filetabs.
10409         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10410         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10411
10412 2019-01-09  Tom Tromey  <tom@tromey.com>
10413
10414         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10415         (compunit_filetabs): New.
10416         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10417         compunit_filetabs.
10418         (info_sources_command, make_source_files_completion_list): Remove
10419         declaration.
10420         * symmisc.c (print_objfile_statistics, dump_objfile)
10421         (maintenance_print_symbols): Remove declaration.
10422         (maintenance_info_symtabs): Use compunit_filetabs.
10423         (maintenance_info_line_tables): Likewise.
10424         * source.c (select_source_symtab): Change local variable name.
10425         (forget_cached_source_info_for_objfile): Remove declaration.
10426         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10427         * objfiles.c (objfile_relocate1): Remove declaration.
10428         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10429         declaration.
10430         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10431         * coffread.c (coff_symtab_read): Remove declaration.
10432         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10433         compunit_filetabs.
10434
10435 2019-01-09  Tom Tromey  <tom@tromey.com>
10436
10437         * symtab.c (lookup_objfile_from_block)
10438         (find_pc_sect_compunit_symtab, search_symbols)
10439         (default_collect_symbol_completion_matches_break_on): Use
10440         objfile_compunits.
10441         * objfiles.h (ALL_COMPUNITS): Remove.
10442         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10443         * cp-support.c (add_symbol_overload_list_qualified): Use
10444         objfile_compunits.
10445         * ada-lang.c (ada_collect_symbol_completion_matches)
10446         (ada_add_global_exceptions): Use objfile_compunits.
10447
10448 2019-01-09  Tom Tromey  <tom@tromey.com>
10449
10450         * source.c (select_source_symtab)
10451         (forget_cached_source_info_for_objfile): Remove declaration.
10452         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10453         declaration.
10454         * maint.c (count_symtabs_and_blocks): Remove declaration.
10455         * cp-support.c (add_symbol_overload_list_qualified): Remove
10456         declaration.
10457         * coffread.c (coff_symtab_read): Remove declaration.
10458         * symtab.c (lookup_symbol_in_objfile_symtabs)
10459         (basic_lookup_transparent_type_1): Use objfile_compunits.
10460         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10461         (info_sources_command, search_symbols)
10462         (default_collect_symbol_completion_matches_break_on)
10463         (make_source_files_completion_list): Remove declaration.
10464         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10465         (ada_collect_symbol_completion_matches)
10466         (ada_add_global_exceptions): Remove declaration.
10467         * linespec.c (iterate_over_all_matching_symtabs): Use
10468         objfile_compunits.
10469         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10470         (class objfile_compunits): New.
10471         (ALL_COMPUNITS): Use objfile_compunits.
10472         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10473         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10474         objfile_compunits.
10475         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10476
10477 2019-01-09  Tom Tromey  <tom@tromey.com>
10478
10479         * symtab.c (search_symbols)
10480         (default_collect_symbol_completion_matches_break_on): Use
10481         objfile_msymbols.
10482         * ada-lang.c (ada_lookup_simple_minsym)
10483         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10484         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10485         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10486         objfile_msymbols.
10487         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10488         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10489         * objc-lang.c (find_methods): Use objfile_msymbols.
10490         (info_selectors_command, info_classes_command): Likewise.
10491         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10492         * objfiles.h (class objfile_msymbols): New.
10493         (ALL_OBJFILE_MSYMBOLS): Remove.
10494         (ALL_MSYMBOLS): Remove.
10495
10496 2019-01-09  Tom Tromey  <tom@tromey.com>
10497
10498         * common/next-iterator.h (next_adapter): Add Iterator template
10499         parameter.
10500         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10501         (class all_objfiles_safe): New.
10502         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10503         * objfiles.c (put_objfile_before): Update comment.
10504         (add_separate_debug_objfile): Likewise.
10505         (free_all_objfiles): Use all_objfiles_safe.
10506         (objfile_purge_solibs): Likewise.
10507
10508 2019-01-09  Tom Tromey  <tom@tromey.com>
10509
10510         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10511         (expand_symtab_containing_pc, lookup_static_symbol)
10512         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10513         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10514         all_objfiles.
10515         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10516         * breakpoint.c (create_overlay_event_breakpoint)
10517         (create_longjmp_master_breakpoint)
10518         (create_std_terminate_master_breakpoint)
10519         (create_exception_master_breakpoint): Use all_objfiles.
10520         * linux-thread-db.c (try_thread_db_load_from_pdir)
10521         (has_libpthread): Use all_objfiles.
10522         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10523         * linespec.c (iterate_over_all_matching_symtabs)
10524         (search_minsyms_for_name): Use all_objfiles.
10525         * maint.c (maintenance_info_sections): Use all_objfiles.
10526         * main.c (captured_main_1): Use all_objfiles.
10527         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10528         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10529         * guile/scm-pretty-print.c
10530         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10531         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10532         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10533         (maintenance_print_msymbols): Use all_objfiles.
10534         * source.c (select_source_symtab): Use all_objfiles.
10535         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10536         * symfile.c (remove_symbol_file_command)
10537         (expand_symtabs_matching, map_symbol_filenames): Use
10538         all_objfiles.
10539         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10540         all_objfiles.
10541         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10542         * objc-lang.c (find_methods): Use all_objfiles.
10543         * objfiles.c (have_partial_symbols, have_full_symbols)
10544         (have_minimal_symbols, qsort_cmp)
10545         (default_iterate_over_objfiles_in_search_order): Use
10546         all_objfiles.
10547         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10548         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10549         (maintenance_check_psymtabs): Use all_objfiles.
10550         (ALL_PSYMTABS): Remove.
10551         * compile/compile-object-run.c (do_module_cleanup): Use
10552         all_objfiles.
10553         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10554         * cp-support.c (add_symbol_overload_list_qualified): Use
10555         all_objfiles.
10556         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10557         Use all_objfiles.
10558         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10559         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10560         all_objfiles.
10561         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10562         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10563         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10564         Uses all_objfiles.
10565         * solib.c (solib_read_symbols): Use all_objfiles
10566
10567 2019-01-09  Tom Tromey  <tom@tromey.com>
10568
10569         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10570         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10571         all_objfiles.
10572         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10573         * symmisc.c (print_symbol_bcache_statistics)
10574         (print_objfile_statistics, maintenance_print_objfiles)
10575         (maintenance_info_symtabs, maintenance_check_symtabs)
10576         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10577         all_objfiles.
10578         * source.c (forget_cached_source_info): Use all_objfiles.
10579         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10580         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10581         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10582         * objfiles.c (update_section_map): Use all_objfiles.
10583         (shared_objfile_contains_address_p): Likewise.
10584         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10585         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10586
10587 2019-01-09  Tom Tromey  <tom@tromey.com>
10588
10589         * common/next-iterator.h: New file.
10590         * objfiles.h (class all_objfiles): New.
10591         (struct objfile_iterator): New.
10592
10593 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10594
10595         * NEWS: Move the description of the changed "frame", "select-frame",
10596          and "info frame" commands to the Changed commands section.
10597
10598 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10599
10600         * gdbtypes.c (check_stub_method_group): Remove handling of old
10601         mangling schemes.
10602         * linespec.c (find_methods): Likewise.
10603         * stabsread.c (read_member_functions): Likewise.
10604         * valops.c (search_struct_method): Likewise.
10605         (value_struct_elt_for_reference): Likewise.
10606         * NEWS: Mention this change.
10607
10608 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10609
10610         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10611         print_source_lines.
10612         * source.c (print_source_lines_base): Update line number check.
10613         (print_source_lines): New function.
10614         (source_lines_range::source_lines_range): New function.
10615         * source.h (class source_lines_range): New class.
10616         (print_source_lines): New declaration.
10617
10618 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10619
10620         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10621
10622 2019-01-08  Tom Tromey  <tom@tromey.com>
10623             Simon Marchi  <simon.marchi@ericsson.com>
10624
10625         PR gdb/24060
10626         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10627         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10628         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10629         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10630         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10631         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10632
10633 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10634
10635         * source.c (select_source_symtab): Move header comment to
10636         declaration in source.h.
10637         (forget_cached_source_info_for_objfile): Likewise.
10638         (forget_cached_source_info): Likewise.
10639         (identify_source_line): Likewise.
10640         * source.h (identify_source_line): Move declaration from symtab.h
10641         and add comment from source.c
10642         (print_source_lines): Likewise.
10643         (forget_cached_source_info_for_objfile): Likewise.
10644         (forget_cached_source_info): Likewise.
10645         (select_source_symtab): Likewise.
10646         (enum print_source_lines_flag): Move definition from symtab.h.
10647         * symtab.h (identify_source_line): Move declaration to source.h.
10648         (print_source_lines): Likewise.
10649         (forget_cached_source_info_for_objfile): Likewise.
10650         (forget_cached_source_info): Likewise.
10651         (select_source_symtab): Likewise.
10652         (enum print_source_lines_flag): Move definition to source.h.
10653         * tui/tui-hooks.c: Add 'source.h' include.
10654
10655 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10656
10657         * source.c (print_source_lines_base): Handle requests to print
10658         reverse line number sequences, and guard against empty lines
10659         string.
10660
10661 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10662
10663         * source.c (print_source_lines_base): Fix skip of '\r' if next
10664         character is '\n'.
10665
10666 2019-01-06  Tom Tromey  <tom@tromey.com>
10667
10668         * c-exp.y (struct c_parse_state) <macro_original_text,
10669         expansion_obstack>: New member.
10670         (macro_original_text, expansion_obstack): Remove globals.
10671         (scan_macro_expansion, scanning_macro_expansion)
10672         (finished_macro_expansion): Update.
10673         (scan_macro_cleanup): Remove.
10674         (yylex, c_parse): Update.
10675
10676 2019-01-06  Tom Tromey  <tom@tromey.com>
10677
10678         * c-exp.y (struct c_parse_state) <strings>: New member.
10679         (operator_stoken): Update.
10680
10681 2019-01-06  Tom Tromey  <tom@tromey.com>
10682
10683         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10684         (union type_stack_elt) <typelist_val>: Now a pointer to
10685         std::vector.
10686         (type_stack_cleanup): Don't declare.
10687         (push_typelist): Update.
10688         * parse.c (pop_typelist): Return a std::vector.
10689         (push_typelist): Take a std::vector.
10690         (follow_types): Update.  Do not free args.
10691         (type_stack_cleanup): Remove.
10692         * c-exp.y (struct c_parse_state): New.
10693         (cpstate): New global.
10694         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10695         (nonempty_typelist): Update.
10696         (func_mod): Create a new vector.
10697         (c_parse): Create a c_parse_state.
10698         (check_parameter_typelist): Do not delete params.
10699         (function_method): Update.  Do not delete type_list.
10700
10701 2019-01-06  Tom Tromey  <tom@tromey.com>
10702
10703         PR gdb/28155:
10704         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10705         check_typedef.
10706         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10707         (print_return_value): Likewise.
10708
10709 2019-01-05  Tom Tromey  <tom@tromey.com>
10710
10711         * contrib/cleanup_check.py: Remove.
10712         * contrib/gcc-with-excheck: Remove.
10713         * contrib/exsummary.py: Remove.
10714         * contrib/excheck.py: Remove.
10715
10716 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10717
10718         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10719         NULL. Initialize tpprev to NULL instead of assigning it
10720         to NULL on the next statement.
10721         * windows-nat.c (windows_delete_thread): Remove check for
10722         main_thread_id before printing thread exit notifications.
10723         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10724         Remove thread ID check against main_thread_id.
10725         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10726         windows_delete_thread.
10727         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10728
10729 2019-01-04  Tom Tromey  <tom@tromey.com>
10730
10731         * compile/compile.c (_initialize_compile): Use upper case for
10732         metasyntactic variables.
10733         * symmisc.c (_initialize_symmisc): Use upper case for
10734         metasyntactic variables.
10735         * psymtab.c (_initialize_psymtab): Use upper case for
10736         metasyntactic variables.
10737         * demangle.c (demangle_command): Use upper case for metasyntactic
10738         variables.
10739         (_initialize_demangler): Likewise.
10740         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10741         variables.
10742
10743 2019-01-03  Tom Tromey  <tom@tromey.com>
10744
10745         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10746
10747 2019-01-03  Tom Tromey  <tom@tromey.com>
10748
10749         * python/py-symtab.c (salpy_str): Update.
10750         (struct salpy_sal_object) <symtab>: Now a PyObject.
10751         (salpy_dealloc): Update.
10752         (del_objfile_sal): Use gdbpy_ref.
10753
10754 2019-01-03  Tom Tromey  <tom@tromey.com>
10755
10756         * python/py-type.c (convert_field): Use new_reference.  Return
10757         gdbpy_ref.
10758         (make_fielditem): Return gdbpy_ref.
10759         (typy_fields): Update.
10760         (typy_getitem): Update.
10761         (field_name): Return gdbpy_ref.  Use new_reference.
10762         (typy_iterator_iternext): Update.
10763
10764 2019-01-03  Tom Tromey  <tom@tromey.com>
10765
10766         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10767
10768 2019-01-03  Tom Tromey  <tom@tromey.com>
10769
10770         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10771         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10772         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10773         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10774         (pspy_set_type_printers): Likewise.
10775         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10776         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10777         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10778         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10779         (objfpy_set_type_printers): Likewise.
10780
10781 2019-01-03  Tom Tromey  <tom@tromey.com>
10782
10783         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10784         (gdbpy_print_stack): Use gdbpy_err_fetch.
10785         * python/python-internal.h (class gdbpy_err_fetch): New class.
10786         (class gdbpy_enter) <m_error_type, m_error_value,
10787         m_error_traceback>: Remove.
10788         <m_error>: New member.
10789         (gdbpy_exception_to_string): Don't declare.
10790         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10791         * python/py-value.c (convert_value_from_python): Use
10792         gdbpy_err_fetch.
10793         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10794         gdbpy_exception_to_string.
10795         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10796         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10797         gdbpy_err_fetch.
10798
10799 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10800
10801         * linux-nat.c (delete_lwp_cleanup): Delete.
10802         (struct lwp_deleter): New struct.
10803         (lwp_info_up): New typedef.
10804         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10805         lwp_info_up.
10806
10807 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10808
10809         * linux-fork.c (class scoped_switch_fork_info): New class.
10810         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10811
10812 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10813
10814         * valops.c (find_overload_match): Remove use of null_cleanup, and
10815         calls to do_cleanups.
10816
10817 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10818
10819         * compile/compile-cplus-types.c
10820         (compile_cplus_instance::decl_name): Handle changes to
10821         cp_func_name.
10822         * cp-support.c (cp_func_name): Update header comment, update
10823         return type.
10824         * cp-support.h (cp_func_name): Update return type in declaration.
10825         * valops.c (find_overload_match): Move temp_func local to top
10826         level of function and change its type.  Use temp_func to hold and
10827         delete temporary string obtained from cp_func_name.
10828
10829 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10830
10831         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10832         gdb::char_vector, remove cleanup, and update uses of `msg`.
10833
10834 2019-01-03  Jim Wilson  <jimw@sifive.com>
10835
10836         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10837
10838 2019-01-02  Tom Tromey  <tom@tromey.com>
10839
10840         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10841         (tdesc_parse_xml): Remove cleanups.
10842         * target-descriptions.h (make_cleanup_free_target_description):
10843         Don't declare.
10844         (target_desc_deleter): New struct.
10845         (target_desc_up): New typedef.
10846         * target-descriptions.c (target_desc_deleter::operator()): Rename
10847         from free_target_description.
10848         (make_cleanup_free_target_description): Remove.
10849
10850 2019-01-02  Tom Tromey  <tom@tromey.com>
10851
10852         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10853         constructor, destructor.
10854         (linespec_parser): Remove typedef.
10855         (~linespec_parser): Rename from linespec_parser_delete.
10856         (linespec_lex_to_end, linespec_complete_label)
10857         (linespec_complete): Update.
10858         (decode_line_full): Remove cleanups.
10859         (decode_line_1): Update.
10860
10861 2019-01-02  Tom Tromey  <tom@tromey.com>
10862
10863         * python/python-internal.h (inferior_to_inferior_object): Change
10864         return type.
10865         * python/py-exitedevent.c (create_exited_event_object): Update.
10866         * python/py-inferior.c (inferior_to_inferior_object): Return
10867         gdbpy_ref.
10868         (python_new_inferior, python_inferior_deleted)
10869         (thread_to_thread_object, delete_thread_object)
10870         (build_inferior_list, gdbpy_selected_inferior): Update.
10871         * python/py-infthread.c (create_thread_object): Update.  Also fail
10872         if inferior_to_inferior_object fails.
10873
10874 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10875
10876         * inferior.h (class inferior) <displaced_step_state>: New field.
10877         * infrun.h (struct displaced_step_state): Move here from
10878         infrun.c.  Initialize fields, add constructor.
10879         <inf>: Remove field.
10880         <reset>: New method.
10881         * infrun.c (struct displaced_step_inferior_state): Move to
10882         infrun.h.
10883         (displaced_step_inferior_states): Remove.
10884         (get_displaced_stepping_state): Adust.
10885         (displaced_step_in_progress_any_inferior): Adjust.
10886         (displaced_step_in_progress_thread): Adjust.
10887         (displaced_step_in_progress): Adjust.
10888         (add_displaced_stepping_state): Remove.
10889         (get_displaced_step_closure_by_addr): Adjust.
10890         (remove_displaced_stepping_state): Remove.
10891         (infrun_inferior_exit): Call displaced_step_state.reset.
10892         (use_displaced_stepping): Don't check for NULL.
10893         (displaced_step_prepare_throw): Call
10894         get_displaced_stepping_state.
10895         (displaced_step_fixup): Don't check for NULL.
10896         (prepare_for_detach): Don't check for NULL.
10897
10898 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10899
10900         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10901          in case of call that did not complete.
10902
10903 2019-01-02  Andrey Utkin  <autkin@undo.io>
10904
10905         * symfile.c (find_separate_debug_file): Fix search of debug files for
10906         remote debuggee.
10907
10908 2019-01-02  Tom Tromey  <tom@tromey.com>
10909
10910         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10911         indentation.
10912         * python/py-frame.c (frapy_older): Remove cast.
10913         (frapy_newer): Likewise.
10914         * python/py-breakpoint.c (local_setattro): Remove cast.
10915         * python/py-arch.c (archpy_name): Remove local variable.
10916         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10917
10918 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10919
10920         * unittests/basic_string_view/element_access/char/empty.cc:
10921         Fix year range in copyright header.
10922
10923 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10924
10925         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10926         Delete.
10927         <operator==>: Update with for removed field.
10928         <hash>: Likewise.
10929         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10930         <isa_features>: ...this.
10931         <abi_features>: New field.
10932         (riscv_isa_flen): Update comment.
10933         (riscv_abi_xlen): New declaration.
10934         (riscv_abi_flen): New declaration.
10935         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10936         isa_features.
10937         (riscv_abi_xlen): New function.
10938         (riscv_isa_flen): Update to get answer from isa_features.
10939         (riscv_abi_flen): New function.
10940         (riscv_has_fp_abi): Update to get answer from abi_features.
10941         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10942         xlen and flen.
10943         (riscv_call_info) <xlen, flen>: Update comment.
10944         (riscv_call_arg_struct): Remove invalid assertions
10945         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10946         is removed.
10947         (riscv_gdbarch_init): Gather isa features and abi features
10948         separately, ensure both match on the gdbarch when reusing an old
10949         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10950         a target with 64-bit float hardware.
10951
10952 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10953
10954         * source.c (search_command_helper): Stop reverse search
10955         when line 1 has been searched.
10956
10957 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10958
10959         * record-full.c (record_full_base_target::close): Rewrite
10960         record_full_core_buf_list free logic.
10961
10962 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10963
10964         * break-catch-syscall.c (print_one_catch_syscall): xfree
10965         the last text.
10966
10967 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10968
10969         * top.c (print_gdb_version): Update Copyright year in version
10970         message.
10971
10972 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10973
10974         Update copyright year range in all GDB files.
10975
10976 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10977
10978         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10979
10980 For older changes see ChangeLog-2018.
10981 \f
10982 Local Variables:
10983 mode: change-log
10984 left-margin: 8
10985 fill-column: 74
10986 version-control: never
10987 coding: utf-8
10988 End:
10989