gdb/ChangeLog

   1 2019-07-17  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-winsource.c (tui_update_source_window_as_is)
   4         (tui_update_source_windows_with_addr): Update.
   5         * tui/tui-source.h (tui_set_source_content)
   6         (tui_show_symtab_source): Add "win_info" parameter.
   7         * tui/tui-source.c (tui_set_source_content): Add "win_info"
   8         parameter.
   9         (tui_show_symtab_source): Likewise.
  10
  11 2019-07-17  Tom Tromey  <tom@tromey.com>
  12
  13         * tui/tui-wingeneral.c
  14         (tui_check_and_display_highlight_if_needed): Check can_highlight.
  15
  16 2019-07-17  Tom Tromey  <tom@tromey.com>
  17
  18         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
  19         (struct tui_cmd_window) <can_scroll>: New method.
  20         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
  21         method.
  22
  23 2019-07-17  Tom Tromey  <tromey@adacore.com>
  24
  25         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
  26         do_field_signed>: Rename.  Change type of "value".
  27         * ui-out.c (ui_out::field_signed): Rename from field_int.
  28         Change type of "value".
  29         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
  30         type of "value".
  31         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
  32         do_field_int.  Change type of "value".
  33         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
  34         do_field_int.  Change type of "value".
  35         * tracepoint.c (trace_status_mi, tfind_1)
  36         (print_one_static_tracepoint_marker): Update.
  37         * thread.c (print_thread_info_1, print_selected_thread_frame):
  38         Update.
  39         * stack.c (print_frame, print_frame_info): Update.
  40         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
  41         Update.
  42         * source.c (print_source_lines_base): Update.
  43         * skip.c (info_skip_command): Update.
  44         * record-btrace.c (btrace_ui_out_decode_error)
  45         (btrace_call_history_src_line): Update.
  46         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
  47         Update.
  48         * progspace.c (print_program_space): Update.
  49         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
  50         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
  51         do_field_int.  Change type of "value".
  52         * mi/mi-out.c (mi_ui_out::do_table_begin)
  53         (mi_ui_out::do_table_header): Update.
  54         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
  55         type of "value".
  56         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
  57         (mi_cmd_data_list_changed_registers, output_register)
  58         (mi_cmd_data_read_memory, mi_load_progress)
  59         (mi_cmd_trace_frame_collected): Update.
  60         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
  61         Update.
  62         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
  63         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
  64         (mi_cmd_var_list_children, varobj_update_one): Update.
  65         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
  66         (mi_cmd_stack_list_args, list_arg_or_local): Update.
  67         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
  68         * inferior.c (print_inferior): Update.
  69         * gdb_bfd.c (print_one_bfd): Update.
  70         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
  71         Update.
  72         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
  73         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
  74         do_field_int.  Change type of "value".
  75         * cli-out.c (cli_ui_out::do_field_signed): Rename from
  76         do_field_int.  Change type of "value".
  77         * breakpoint.c (watchpoint_check, print_breakpoint_location)
  78         (print_one_breakpoint_location, print_it_catch_fork)
  79         (print_one_catch_fork, print_it_catch_vfork)
  80         (print_one_catch_vfork, print_it_catch_solib)
  81         (print_it_catch_exec, print_it_ranged_breakpoint)
  82         (print_mention_watchpoint, print_mention_masked_watchpoint)
  83         (bkpt_print_it, update_static_tracepoint): Update.
  84         * break-catch-throw.c (print_it_exception_catchpoint): Update.
  85         * break-catch-syscall.c (print_it_catch_syscall): Update.
  86         * ada-tasks.c (print_ada_task_info): Update.
  87         * ada-lang.c (print_it_exception, print_mention_exception):
  88         Update.
  89
  90 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
  91
  92         PR breakpoints/24541
  93         * gdbarch.c: Regenerate.
  94         * gdbarch.h: Regenerate.
  95         * gdbarch.sh: Adjust return type and parameter types for
  96         'stap_adjust_register'.
  97         (i386_stap_adjust_register): Adjust signature and return new
  98         register name.
  99         * stap-probe.c (stap_parse_register_operand): Adjust use of
 100         'gdbarch_stap_adjust_register'.
 101
 102 2019-07-17  Tom Tromey  <tromey@adacore.com>
 103
 104         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 105         declare VEC.
 106         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 107         std::vector.
 108         (struct s390_process_info): Add initializers.
 109         (s390_add_process): Use new.
 110         (s390_linux_nat_target::low_forget_process): Use delete.
 111         (s390_linux_nat_target::low_new_fork)
 112         (s390_linux_nat_target::stopped_by_watchpoint)
 113         (s390_linux_nat_target::low_prepare_to_resume)
 114         (s390_linux_nat_target::insert_watchpoint)
 115         (s390_linux_nat_target::insert_hw_breakpoint)
 116         (s390_linux_nat_target::remove_watchpoint)
 117         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 118
 119 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 120
 121         * aarch64-fbsd-nat.c: Include regcache.h.
 122         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 123         argument.
 124         (aarch64_fbsd_nat_target::fetch_registers)
 125         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 126         variable.
 127         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 128
 129 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 130
 131         * fbsd-nat.c: Include gdbarch.h.
 132
 133 2019-07-15  Tom Tromey  <tromey@adacore.com>
 134
 135         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 136
 137 2019-07-15  Tom Tromey  <tromey@adacore.com>
 138
 139         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 140         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 141         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 142         * cli-out.c (cli_ui_out::do_field_int): New method.
 143         * ui-out.c (ui_out::field_unsigned): New method.
 144         * symfile.c (generic_load): Use field_unsigned.
 145         (print_transfer_performance): Likewise.
 146         * record-btrace.c (ui_out_field_uint): Remove.
 147         (btrace_call_history_insn_range, btrace_call_history): Use
 148         field_unsigned.
 149         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 150         field_unsigned.
 151         * ui-out.h (class ui_out) <field_unsigned>: New method.
 152         <do_field_unsigned>: Likewise.
 153
 154 2019-07-15  Tom Tromey  <tromey@adacore.com>
 155
 156         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 157         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 158         * target.c (flash_erase_command): Use field_string.
 159         * infrun.c (print_signal_received_reason): Use field_string.
 160         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 161         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 162         field_string.
 163         * ada-tasks.c (print_ada_task_info): Use field_string.
 164
 165 2019-07-15  Tom Tromey  <tromey@adacore.com>
 166
 167         * target.c (flash_erase_command): Use field_core_addr.
 168         * symfile.c (generic_load): Use field_core_addr.
 169         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 170         Use field_core_addr.
 171         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 172         field_core_addr.
 173
 174 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 175
 176         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 177         value if its desired type is smaller than a CORE_ADDR and signed.
 178
 179 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 180
 181         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 182         of changes to field names, and use new is_reference field to
 183         decide if a property is a reference or not.
 184         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 185         field.
 186         (struct dwarf2_property_baton): Update header comment, rename
 187         'referenced_type' to 'property_type' and update comments.
 188         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 189         default property type, store in property baton, update to take
 190         accound of renamed field.
 191         (read_func_scope): Update call to attr_to_dynamic_prop.
 192         (read_array_type): Likewise.
 193         (dwarf2_per_cu_addr_sized_int_type): New function.
 194         (read_subrange_index_type): Move type finding code to
 195         dwarf2_per_cu_addr_sized_int_type.
 196         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 197         (dwarf2_per_cu_addr_type): New function.
 198         (set_die_type): Update calls to attr_to_dynamic_prop.
 199
 200 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 201
 202         * dwarf2read.c (read_subrange_index_type): New function.
 203         (read_subrange_type): Move code into new function and call it.
 204         * gdbtypes.c (create_range_type): Add some asserts.
 205
 206 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 207
 208         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 209         update return statements.
 210         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 211         declaration, and update comment to match.
 212         * gdbtypes.c (resolve_dynamic_array): Update call to
 213         dwarf2_evaluate_property to match new return type.
 214
 215 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 216
 217         * valarith.c (value_subscripted_rvalue): Change lowerbound
 218         parameter type from int to LONGEST.
 219         * value.h (value_subscripted_rvalue): Likewise in declaration.
 220
 221 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 222
 223         * cli/cli-utils.c (info_print_command_completer): New function.
 224         * cli/cli-utils.h: Add 'completer.h' include, and forward
 225         declaration for 'struct cmd_list_element'.
 226         (info_print_command_completer): Declare.
 227         * stack.c (_initialize_stack): Add completer for 'info locals' and
 228         'info args'.
 229         * symtab.c (_initialize_symtab): Add completer for 'info
 230         variables' and 'info functions'.
 231         * NEWS: Mention completion for additional info commands.
 232
 233 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 234
 235         * cli/cli-utils.c (extract_info_print_args): Delete.
 236         (extract_arg_maybe_quoted): Delete.
 237         (info_print_options_defs): New variable.
 238         (make_info_print_options_def_group): New function.
 239         (extract_info_print_options): Define new function.
 240         * cli/cli-utils.h (extract_info_print_args): Delete.
 241         (struct info_print_options): New structure.
 242         (extract_info_print_options): Declare new function.
 243         * stack.c (info_locals_command): Update to use new
 244         extract_info_print_options, also add a header comment.
 245         (info_args_command): Likewise.
 246         * symtab.c (info_variables_command): Likewise.
 247         (info_functions_command): Likewise.
 248
 249 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 250
 251         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 252         to extract string arguments.
 253         * common/common-utils.c (extract_string_maybe_quoted): New function.
 254         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 255
 256 2019-07-11  Tom Tromey  <tromey@adacore.com>
 257
 258         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 259         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 260         * top.h (gdbinit): Don't declare.
 261         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 262         into...
 263         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 264         * top.c (gdb_init): Don't call init_cli_cmds.
 265         (gdbinit): Remove.
 266         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 267
 268 2019-07-11  Tom Tromey  <tromey@adacore.com>
 269
 270         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 271         after it has been moved.
 272
 273 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 274
 275         * valops.c (value_must_coerce_to_target): Change return type to
 276         bool.
 277         * value.h (value_must_coerce_to_target): Likewise.
 278
 279 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 280
 281         * breakpoint.c (is_hardware_watchpoint): Remove
 282         forward-declaration.
 283         (is_masked_watchpoint): Change return type to bool.
 284         (is_tracepoint): Likewise.
 285         (is_breakpoint): Likewise.
 286         (is_hardware_watchpoint): Likewise.
 287         (is_watchpoint): Likewise.
 288         (is_no_memory_software_watchpoint): Likewise.
 289         (is_catchpoint): Likewise.
 290         (breakpoint_1): Make FILTER parameter's return type bool.
 291         is_masked_watchpoint): Change return type to bool.
 292         (save_breakpoints): Make FILTER parameter's return type bool.
 293         * breakpoint.h (is_breakpoint): Change return type to bool.
 294         (is_watchpoint): Likewise.
 295         (is_catchpoint): Likewise.
 296         (is_tracepoint): Likewise.
 297
 298 2019-07-10  Tom Tromey  <tom@tromey.com>
 299
 300         * defs.h: Don't include gdbarch.h.
 301         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 302         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 303         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 304         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 305         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 306         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 307         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 308         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 309         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 310         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 311         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 312         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 313         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 314         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 315         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 316         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 317         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 318         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 319         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 320         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 321         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 322         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 323         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 324         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 325         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 326         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 327         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 328
 329 2019-07-10  Tom Tromey  <tromey@adacore.com>
 330
 331         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 332         * breakpoint.c (init_ada_exception_breakpoint): Register as
 333         bp_catchpoint.
 334         (print_one_breakpoint_location, print_one_breakpoint): Use
 335         is_ada_exception_catchpoint.
 336         * ada-lang.c (class ada_catchpoint_location): Pass
 337         bp_loc_software_breakpoint to bp_location constructor.
 338         (is_ada_exception_catchpoint): New function.
 339
 340 2019-07-10  Tom Tromey  <tromey@adacore.com>
 341
 342         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 343         VEC.
 344         (struct arm_exidx_entry): New method operator<.
 345         (struct arm_exidx_data) <section_maps>: Change type.
 346         (arm_exidx_data_free): Remove.
 347         (arm_exidx_data_key): Change type.  Move lower.
 348         (arm_exidx_new_objfile): Update.
 349         (arm_compare_exidx_entries): Remove.
 350         (arm_find_exidx_entry, _initialize_arm_tdep)
 351
 352 2019-07-10  Tom Tromey  <tromey@adacore.com>
 353
 354         * solib-spu.c (ocl_program_data_key): Change type.
 355         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 356         Update.
 357
 358 2019-07-10  Tom Tromey  <tromey@adacore.com>
 359
 360         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 361         (struct solib_aix_inferior_data) <library_list>: Change type.
 362         (solib_aix_inferior_data_handle): Change type.
 363         (get_solib_aix_inferior_data): Update.
 364         (solib_aix_free_library_list): Remove.
 365         (library_list_start_library): Update.
 366         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 367         return type.
 368         (solib_aix_get_library_list)
 369         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 370         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 371
 372 2019-07-10  Tom Tromey  <tromey@adacore.com>
 373
 374         * solib-dsbt.c (struct dsbt_info): Add initializers.
 375         (solib_dsbt_pspace_data): Change type.
 376         (dsbt_pspace_data_cleanup): Remove.
 377         (get_dsbt_info, _initialize_dsbt_solib): Update.
 378
 379 2019-07-10  Tom Tromey  <tromey@adacore.com>
 380
 381         * spu-tdep.c (spu_overlay_data): Change type.
 382         (spu_get_overlay_table, spu_overlay_new_objfile)
 383         (_initialize_spu_tdep): Update.
 384
 385 2019-07-10  Tom Tromey  <tromey@adacore.com>
 386
 387         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 388         destructor.
 389         (dbx_objfile_data_key): Change type and declare later.
 390         (DBX_SYMFILE_INFO): Rewrite.
 391         * dbxread.c (dbx_objfile_data_key): Change type.
 392         (dbx_symfile_init): Update.
 393         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 394         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 395         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 396
 397 2019-07-10  Tom Tromey  <tromey@adacore.com>
 398
 399         * jit.c (jit_program_space_key): Change type.  Move lower.
 400         (get_jit_program_space_data): Update.
 401         (jit_program_space_data_cleanup): Remove.
 402         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 403         Update.
 404         (struct jit_program_space_data): Add initializers.
 405
 406 2019-07-10  Tom Tromey  <tromey@adacore.com>
 407
 408         * solib-darwin.c (struct darwin_info): Add initializers.
 409         (solib_darwin_pspace_data): Change type.
 410         (darwin_pspace_data_cleanup): Remove.
 411         (get_darwin_info, _initialize_darwin_solib): Update.
 412
 413 2019-07-10  Tom Tromey  <tromey@adacore.com>
 414
 415         * remote-sim.c (struct sim_inferior_data): Add initializers,
 416         constructor, and destructor.
 417         (sim_inferior_data_key): Change type.  Move lower.
 418         (check_for_duplicate_sim_descriptor): Update.
 419         (get_sim_inferior_data): Use new.  Update.
 420         (~sim_inferior_data_cleanup): Rename from
 421         sim_inferior_data_cleanup.  Simplify.
 422         (gdbsim_close_inferior, simulator_command)
 423         (sim_command_completer, _initialize_remote_sim): Update.
 424         (next_pid, INITIAL_PID): Move earlier.
 425
 426 2019-07-10  Tom Tromey  <tromey@adacore.com>
 427
 428         * python/python-internal.h (create_thread_object): Return
 429         gdbpy_ref.
 430         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 431         * python/py-inferior.c (struct threadlist_entry): Add
 432         constructor.
 433         <thread_obj>: Now a gdbpy_ref.
 434         (thread_to_thread_object): Update.
 435         (add_thread_object): Use new.
 436         (delete_thread_object): Use delete.
 437         (infpy_threads): Update.
 438         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 439         GIL.
 440
 441 2019-07-10  Tom Tromey  <tromey@adacore.com>
 442
 443         * valops.c (value_cast): Specialize error message for Ada.
 444
 445 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 446
 447         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 448
 449 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 450
 451         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 452         bpstat_should_step): Return bool, adjust comments.
 453         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 454         bpstat_should_step): Likewise.
 455
 456 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 457
 458         * features/Makefile: Use feature target descriptions for Arm.
 459         * features/arm/arm-core.c: Generate new file.
 460         * features/arm/arm-fpa.c: Likewise.
 461         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 462         * features/arm/arm-m-profile.c: Likewise.
 463         * features/arm/arm-vfpv2.c: Likewise.
 464         * features/arm/arm-vfpv3.c: Likewise.
 465         * features/arm/xscale-iwmmxt.c: Likewise.
 466         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 467
 468 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 469
 470         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 471         ptrace earlier.
 472
 473 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 474
 475         * features/aarch64-pauth.c: Regenerate.
 476
 477 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 478
 479         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 480         bool.
 481         (bpstat_what): Use false instead of 0.
 482
 483 2019-07-09  Pedro Alves  <palves@redhat.com>
 484
 485         * break-catch-throw.c (is_exception_catchpoint): New.
 486         * breakpoint.c (print_one_breakpoint_location): New parameter
 487         'raw_loc'.  Handle it.  Use
 488         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 489         looking at the breakpoint's type.
 490         (print_one_breakpoint): If handling "maint info breakpoints", also
 491         print locations of exception catchpoints.
 492         * breakpoint.h (is_exception_catchpoint): Declare.
 493
 494 2019-07-09  Pedro Alves  <palves@redhat.com>
 495
 496         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 497         "addr" field.
 498         (allocate_location_exception_catchpoint): New.
 499         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 500         (initialize_throw_catchpoint_ops): Install
 501         allocate_location_exception_catchpoint as allocate_location
 502         method.
 503         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 504         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 505         bp_loc_other.
 506         (breakpoint_address_is_meaningful): Delete.
 507         (bl_address_is_meaningful): New.
 508         (breakpoint_locations_match): Adjust comment.
 509         (bp_location_from_bp_type): New, factored out of...
 510         (bp_location::bp_location(breakpoint *)): ... this.
 511         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 512         factored out of...
 513         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 514         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 515         breakpoint_address_is_meaningful.
 516         (bp_locations_compare): Adjust comment.
 517         (update_global_location_list): Use bl_address_is_meaningful
 518         instead of breakpoint_address_is_meaningful.
 519         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 520         explicit.
 521         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 522         * python/py-breakpoint.c (bppy_get_location): No longer check
 523         whether location is null.
 524
 525 2019-07-09  Pedro Alves  <palves@redhat.com>
 526
 527         PR c++/15468
 528         * breakpoint.c (print_one_breakpoint_location): Remove
 529         single-location assert.
 530
 531 2019-07-09  Tom Tromey  <tom@tromey.com>
 532
 533         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 534         * configure: Rebuild.
 535         * configure.ac: Change common to gdbsupport.
 536         * gdbsupport: Rename from common.
 537         * acinclude.m4: Change common to gdbsupport.
 538         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 539         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 540         gdbsupport.
 541         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 542         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 543         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 544         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 545         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 546         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 547         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 548         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 549         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 550         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 551         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 552         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 553         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 554         coff-pe-read.c, command.h, compile/compile-c-support.c,
 555         compile/compile-c.h, compile/compile-cplus-symbols.c,
 556         compile/compile-cplus-types.c, compile/compile-cplus.h,
 557         compile/compile-loc2c.c, compile/compile.c, completer.c,
 558         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 559         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 560         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 561         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 562         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 563         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 564         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 565         features/aarch64-core.c, features/aarch64-fpu.c,
 566         features/aarch64-pauth.c, features/aarch64-sve.c,
 567         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 568         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 569         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 570         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 571         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 572         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 573         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 574         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 575         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 576         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 577         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 578         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 579         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 580         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 581         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 582         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 583         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 584         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 585         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 586         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 587         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 588         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 589         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 590         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 591         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 592         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 593         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 594         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 595         minsyms.c, mips-linux-tdep.c, namespace.h,
 596         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 597         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 598         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 599         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 600         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 601         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 602         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 603         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 604         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 605         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 606         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 607         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 608         procfs.c, producer.c, progspace.h, psymtab.h,
 609         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 610         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 611         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 612         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 613         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 614         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 615         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 616         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 617         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 618         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 619         target-memory.c, target.c, target.h, target/waitstatus.c,
 620         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 621         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 622         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 623         unittests/array-view-selftests.c,
 624         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 625         unittests/common-utils-selftests.c,
 626         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 627         unittests/format_pieces-selftests.c,
 628         unittests/function-view-selftests.c,
 629         unittests/lookup_name_info-selftests.c,
 630         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 631         unittests/mkdir-recursive-selftests.c,
 632         unittests/observable-selftests.c,
 633         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 634         unittests/parse-connection-spec-selftests.c,
 635         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 636         unittests/scoped_fd-selftests.c,
 637         unittests/scoped_mmap-selftests.c,
 638         unittests/scoped_restore-selftests.c,
 639         unittests/string_view-selftests.c, unittests/style-selftests.c,
 640         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 641         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 642         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 643         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 644         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 645         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 646
 647 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 648
 649         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 650         bool value.
 651         (decode_digits_ordinary): Set explicit_line field in sal.
 652         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 653         symtab_and_line that was set on an explicit line number in
 654         assembler code.  Do always update the recorded symtab and line if
 655         we do skip the prologue.
 656
 657 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 658
 659         * breakpoint.c (set_breakpoint_location_function): Remove
 660         explicit_loc parameter.
 661         (momentary_breakpoint_from_master): Update call to
 662         set_breakpoint_location_function.
 663         (add_location_to_breakpoint): Likewise.
 664
 665 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 666
 667         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 668         required features based on default bfd type when no specific bfd
 669         is present.
 670
 671 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 672
 673         * NEWS: Mention that GDB printf and eval commands can now print
 674         C-style and Ada-style convenience var strings without
 675         calling the inferior.
 676         * printcmd.c (printf_c_string): Locally print GDB internal var
 677         instead of transiting via the inferior.
 678         (printf_wide_c_string): Likewise.
 679
 680 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 681
 682         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
 683
 684 2019-07-04  Tom Tromey  <tom@tromey.com>
 685
 686         PR tui/24724:
 687         * tui/tui-winsource.c (tui_clear_source_content): Update.
 688         (tui_source_window_base::set_is_exec_point_at): Fix comment.
 689         (tui_update_breakpoint_info): Update.
 690         (tui_set_exec_info_content): Update.
 691         * tui/tui-source.c (tui_set_source_content_nil): Update.
 692         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
 693         has_break.
 694         * tui/tui-data.h (enum tui_bp_flag): New.
 695         (tui_bp_flags): New enum flags type.
 696         (struct tui_source_element) <break_mode>: Change type.  Rename
 697         from has_break.
 698         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
 699         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
 700         constants.
 701         * tui/tui-winsource.h: Fix comment.
 702
 703 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 704
 705         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
 706         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
 707         (store_fpregs_to_thread)
 708         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 709         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
 710         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
 711         (IWMMXT_REGS_SIZE): Add define.
 712         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
 713         (fetch_vfp_regs, store_vfp_regs)
 714         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 715         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
 716
 717 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 718
 719         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
 720         defines.
 721         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
 722         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
 723         (ARM_INT_REGISTER_SIZE): ...to this.
 724         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
 725         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
 726         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
 727         (arm_linux_collect_gregset, supply_nwfpe_register)
 728         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
 729         defines.
 730         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
 731         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
 732         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
 733         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
 734         (arm_return_in_memory, arm_store_return_value)
 735         (arm_get_longjmp_target, arm_register_g_packet_guesses)
 736         (arm_record_ld_st_multiple): Likewise.
 737         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
 738         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
 739
 740 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 741
 742         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
 743         AARCH64_DISPLACED_MODIFIED_INSNS.
 744         * aarch64-tdep.c (struct aarch64_displaced_step_data)
 745         (aarch64_displaced_step_copy_insn): Likewise.
 746         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 747         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
 748         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
 749         ARM_DISPLACED_MODIFIED_INSNS.
 750         * arm-tdep.c (arm_gdbarch_init): Likewise.
 751         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 752         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
 753         (struct arm_displaced_step_closure): Use
 754         ARM_DISPLACED_MODIFIED_INSNS.
 755
 756 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 757
 758         * features/Makefile: Remove unused xml files.
 759         * features/aarch64.xml: Remove.
 760         * features/i386/amd64-avx-avx512-linux.xml: Remove.
 761         * features/i386/amd64-avx-avx512.xml: Remove.
 762         * features/i386/amd64-avx-linux.xml: Remove.
 763         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
 764         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
 765         * features/i386/amd64-avx-mpx-linux.xml: Remove.
 766         * features/i386/amd64-avx-mpx.xml: Remove.
 767         * features/i386/amd64-avx.xml: Remove.
 768         * features/i386/amd64-linux.xml: Remove.
 769         * features/i386/amd64-mpx-linux.xml: Remove.
 770         * features/i386/amd64-mpx.xml: Remove.
 771         * features/i386/amd64.xml: Remove.
 772         * features/i386/i386-avx-avx512-linux.xml: Remove.
 773         * features/i386/i386-avx-avx512.xml: Remove.
 774         * features/i386/i386-avx-linux.xml: Remove.
 775         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
 776         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
 777         * features/i386/i386-avx-mpx-linux.xml: Remove.
 778         * features/i386/i386-avx-mpx.xml: Remove.
 779         * features/i386/i386-avx.xml: Remove.
 780         * features/i386/i386-linux.xml: Remove.
 781         * features/i386/i386-mmx-linux.xml: Remove.
 782         * features/i386/i386-mmx.xml: Remove.
 783         * features/i386/i386-mpx-linux.xml: Remove.
 784         * features/i386/i386-mpx.xml: Remove.
 785         * features/i386/i386.xml: Remove.
 786         * features/i386/x32-avx-avx512-linux.xml: Remove.
 787         * features/i386/x32-avx-linux.xml: Remove.
 788         * features/i386/x32-linux.xml: Remove.
 789
 790 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 791
 792         * regformats/aarch64.dat: Remove.
 793         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
 794         * regformats/i386/amd64-avx-linux.dat: Remove.
 795         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
 796         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
 797         * regformats/i386/amd64-linux.dat: Remove.
 798         * regformats/i386/amd64-mpx-linux.dat: Remove.
 799         * regformats/i386/amd64.dat: Remove.
 800         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
 801         * regformats/i386/i386-avx-linux.dat: Remove.
 802         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
 803         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
 804         * regformats/i386/i386-linux.dat: Remove.
 805         * regformats/i386/i386-mmx-linux.dat: Remove.
 806         * regformats/i386/i386-mpx-linux.dat: Remove.
 807         * regformats/i386/i386.dat: Remove.
 808         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
 809         * regformats/i386/x32-avx-linux.dat: Remove.
 810         * regformats/i386/x32-linux.dat: Remove.
 811
 812 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 813
 814         * aarch64-tdep.c: Remove xml self tests.
 815         * amd64-linux-tdep.c: Likewise.
 816         * amd64-tdep.c: Likewise.
 817         * i386-linux-tdep.c: Likewise.
 818         * i386-tdep.c: Likewise.
 819
 820 2019-07-03  Pedro Alves  <palves@redhat.com>
 821
 822         PR cli/24732
 823         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
 824         (pipe_cmd_option_defs): New.
 825         (make_pipe_cmd_options_def_group): New.
 826         (pipe_command): Use gdb::option::process_options.
 827         (pipe_command_completer): New function.
 828         (_initialize_cli_cmds): Install completer for "pipe" command.
 829
 830 2019-07-03  Pedro Alves  <palves@redhat.com>
 831
 832         * cli/cli-option.c (union option_value) <string>: New field.
 833         (struct option_def_and_value): Add ctor, move ctor, dtor and
 834         use DISABLE_COPY_AND_ASSIGN.
 835         (option_def_and_value::clear_value): New.
 836         (parse_option, save_option_value_in_ctx, get_val_type_str)
 837         (add_setshow_cmds_for_options): Handle var_string.
 838         * cli-option.h (union option_def::var_address) <string>: New
 839         field.
 840         (struct string_option_def): New.
 841         * maint-test-options.c (struct test_options_opts): Add default
 842         ctor and use DISABLE_COPY_AND_ASSIGN.
 843         <string_opt>: New field.
 844         (test_options_opts::~test_options_opts): New.
 845         (test_options_opts::dump): Also dump "-string".
 846         (test_options_option_defs): Install "string.
 847
 848 2019-07-03  Pedro Alves  <palves@redhat.com>
 849
 850         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
 851         option_value with a null enumeration.
 852         (complete_options): Save the option values in the context.
 853         (save_option_value_in_ctx): New, factored out from ...
 854         (process_options): ... here.
 855         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
 856         of the function.
 857         * maint-test-options.c (test_options_opts::dump): New, factored
 858         out from ...
 859         (maintenance_test_options_command_mode): ... here.
 860         (maintenance_test_options_command_completion_result): Delete.
 861         (maintenance_test_options_command_completion_text): Update
 862         comment.
 863         (maintenance_show_test_options_completion_result): Change
 864         prototype.  Just print
 865         maintenance_test_options_command_completion_text.
 866         (save_completion_result): New.
 867         (maintenance_test_options_completer_mode): Pass options context to
 868         complete_options, and then save a dump.
 869         (_initialize_maint_test_options): Use add_cmd to install "maint
 870         show test-options-completion-result".
 871
 872 2019-07-03  Pedro Alves  <palves@redhat.com>
 873
 874         * NEWS (New commands): Mention "with" and "maint with".
 875         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
 876         (with_command, with_command_completer): New.
 877         (pipe_command): Adjust to new repeat_previous
 878         interface.
 879         (_initialize_cli_cmds): Install the "with" command and its "w"
 880         alias.
 881         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
 882         declarations.
 883         * cli/cli-setshow.c (parse_cli_var_uinteger)
 884         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
 885         argument strings for all var_types.
 886         (get_setshow_command_value_string): New, factored out from ...
 887         (do_show_command): ... this.
 888         * cli/cli-setshow.h: Include <string>.
 889         (get_setshow_command_value_string): Declare.
 890         * command.h (repeat_previous): Now returns const char *.  Adjust
 891         comment.
 892         * maint.c: Include "cli/cli-cmds.h".
 893         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
 894         (_initialize_maint_cmds): Register the "maintenance with" command.
 895         * top.c (repeat_previous): Move bits from pipe_command here:
 896         Return the saved command line, if any; error out if there's no
 897         command to relaunch.
 898
 899 2019-07-03  Pedro Alves  <palves@redhat.com>
 900
 901         * NEWS (New commands): Mention "maint set/show test-settings"
 902         instead of "maint test-settings".
 903         * maint-test-settings.c (maintenance_test_settings_list): Delete.
 904         (maintenance_test_settings_set_list): Rename to ...
 905         (maintenance_set_test_settings_list): ... this.
 906         (maintenance_test_settings_show_list): Rename to  ...
 907         (maintenance_show_test_settings_list): ... this.
 908         (maintenance_test_settings_cmd): Delete.
 909         (maintenance_test_settings_set_cmd): ...
 910         (maintenance_set_test_settings_cmd): ... this.
 911         (maintenance_test_settings_show_cmd): ...
 912         (maintenance_show_test_settings_cmd): ... this.
 913         (maintenance_test_settings_show_value_cmd):
 914         (maintenance_show_test_settings_value_cmd): ... this.
 915         (_initialize_maint_test_settings): No longer install the "maint
 916         test-settings" prefix command.  Rename "maint test-settings set"
 917         to "maint set test-settings", and "maint test-settings show" to
 918         "maint show test-settings".  Adjust all subcommands.
 919
 920 2019-07-03  Pedro Alves  <palves@redhat.com>
 921
 922         * maint-test-settings.c: Fix file's intro comment.  Replace all
 923         references to "test-options" with references to "test-settings",
 924         in comments.
 925
 926 2019-07-03  Pedro Alves  <palves@redhat.com>
 927
 928         * maint-test-settings.c (maintenance_test_settings_xxx)
 929         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
 930         New.
 931         (maintenance_test_settings_enums): Use them.
 932         (maintenance_test_settings_enum): Default to
 933         maintenance_test_settings_xxx.
 934         (_initialize_maint_test_settings): Initialize
 935         MAINTENANCE_TEST_SETTINGS_FILENAME.
 936
 937 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 938
 939         * breakpoint.h (remove_breakpoints_inf): Change return type to
 940         void, move function documentation here.
 941         * breakpoint.c (remove_breakpoints_inf): Change return type to
 942         void, move function documentation to header.
 943
 944 2019-07-02  Pedro Alves  <palves@redhat.com>
 945
 946         * NEWS (Completion improvements): Mention "info threads".
 947         * thread.c (struct info_threads_opts, info_threads_option_defs)
 948         (make_info_threads_options_def_group): New.
 949         (info_threads_command): Use gdb::option::process_options.
 950         (info_threads_command_completer): New.
 951         (_initialize_thread): Use gdb::option::build_help to build the
 952         help text for "info threads".
 953
 954 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 955
 956         * defs.h (generic_load): Move from here...
 957         * symfile.h (generic_load): ... to here.  Rename name parameter
 958         to args.
 959         * symfile.c (generic_load): Add comment.
 960
 961 2019-07-01  Tom Tromey  <tromey@adacore.com>
 962
 963         * dwarf2read.c
 964         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
 965         declaration of without_params.  Fix formatting.
 966
 967 2019-07-01  Tom Tromey  <tromey@adacore.com>
 968
 969         * ada-exp.y (find_primitive_type): Update.
 970         * ada-lang.h (ada_lookup_symbol): Update.
 971         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
 972         parameter.
 973         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
 974
 975 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 976
 977         PR breakpoints/24541
 978         * gdbarch.c: Regenerate.
 979         * gdbarch.h: Regenerate.
 980         * gdbarch.sh: Add 'stap_adjust_register'.
 981         * i386-tdep.c: Include '<unordered_set>'.
 982         (i386_stap_adjust_register): New function.
 983         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
 984         * stap-probe.c (stap_parse_register_operand): Call
 985         'gdbarch_stap_adjust_register'.
 986
 987 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 988
 989         PR python/24742
 990         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
 991         * python/python.c (do_start_initialization): Use 'xmalloc'
 992         instead of 'PyMem_Malloc'.
 993
 994 2019-06-28  Tom Tromey  <tromey@adacore.com>
 995
 996         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
 997         for Ada.
 998
 999 2019-06-27  Tom Tromey  <tromey@adacore.com>
1000
1001         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1002         objfile_key.
1003         (arm_find_mapping_symbol, arm_record_special_symbol)
1004         (_initialize_arm_tdep): Update.
1005         (arm_objfile_data_free): Remove.
1006
1007 2019-06-27  Tom Tromey  <tromey@adacore.com>
1008
1009         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1010         to cp_print_static_field.
1011
1012 2019-06-26  Tom Tromey  <tromey@adacore.com>
1013
1014         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1015         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1016         declare.
1017
1018 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1019
1020         * features/aarch64-core.c (create_feature_aarch64_core):
1021         Regenerate.
1022         * features/aarch64-core.xml: Add cpsr flags.
1023
1024 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1025
1026         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1027         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1028
1029 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1030
1031         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1032         field.
1033         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1034         use.
1035         (arm_record_special_symbol): Don't insert new symbol in sorted
1036         position, push it at the end.
1037
1038 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1039
1040         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1041         (arm_mapping_symbol_s): Remove.
1042         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1043         (arm_mapping_symbol_vec): New typedef.
1044         (struct arm_per_objfile): Add constructor.
1045         <section_maps>: Change type to
1046         std::unique_ptr<arm_mapping_symbol_vec[]>.
1047         (arm_compare_mapping_symbols): Remove.
1048         (arm_find_mapping_symbol): Adjust to section_maps type change.
1049         (arm_objfile_data_free): Call delete on arm_per_objfile.
1050         (arm_record_special_symbol): Adjust to section_maps type change.
1051         Allocate arm_per_objfile with new.
1052
1053 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1054
1055         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1056         with the command prefix.
1057
1058 2019-06-25  Tom Tromey  <tom@tromey.com>
1059
1060         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1061         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1062
1063 2019-06-25  Tom Tromey  <tom@tromey.com>
1064
1065         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1066         type.
1067         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1068         protected.
1069
1070 2019-06-25  Tom Tromey  <tom@tromey.com>
1071
1072         * tui/tui-winsource.c
1073         (tui_source_window_base::set_is_exec_point_at): Add check against
1074         LOA_ADDRESS.
1075
1076 2019-06-25  Tom Tromey  <tom@tromey.com>
1077
1078         * tui/tui-source.c (tui_set_source_content): Don't check before
1079         xfree.
1080         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1081
1082 2019-06-25  Tom Tromey  <tom@tromey.com>
1083
1084         * tui/tui-winsource.h (tui_update_source_window_as_is)
1085         (tui_alloc_source_buffer, tui_line_is_displayed)
1086         (tui_addr_is_displayed): Change type of win_info.
1087         * tui/tui-winsource.c (tui_update_source_window_as_is)
1088         (tui_clear_source_content, tui_show_source_line)
1089         (tui_show_source_content, tui_source_window_base::refill)
1090         (tui_source_window_base::set_is_exec_point_at)
1091         (tui_source_window_base::set_is_exec_point_at)
1092         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1093         (tui_alloc_source_buffer, tui_line_is_displayed)
1094         (tui_addr_is_displayed): Change type of win_info.  Update.
1095         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1096         (tui_source_window_base::do_make_visible_with_new_height):
1097         Update.
1098         * tui/tui-source.c (tui_set_source_content)
1099         (tui_set_source_content_nil)
1100         (tui_source_window::do_scroll_vertical): Update.
1101         * tui/tui-layout.c (show_layout): Update.
1102         * tui/tui-disasm.c (tui_set_disassem_content)
1103         (tui_disasm_window::do_scroll_vertical): Update.
1104         * tui/tui-data.h (tui_win_content): Remove.
1105         (struct tui_gen_win_info) <content, content_size>: Remove.
1106         (struct tui_source_element): Add initializers and destructor.
1107         (union tui_which_element, struct tui_win_element): Remove.
1108         (struct tui_source_window_base) <content>: New field.
1109         (struct tui_data_window): Remove destructor.
1110         (tui_alloc_content, tui_free_win_content)
1111         (tui_free_all_source_wins_content): Don't declare.
1112         * tui/tui-data.c (tui_initialize_static_data): Update.
1113         (init_content_element, tui_alloc_content): Remove.
1114         (~tui_gen_win_info): Update.
1115         (~tui_data_window, tui_free_all_source_wins_content)
1116         (tui_free_win_content, free_content, free_content_elements):
1117         Remove.
1118
1119 2019-06-25  Tom Tromey  <tom@tromey.com>
1120
1121         * tui/tui-winsource.h (tui_clear_source_content)
1122         (tui_erase_source_content, tui_show_source_content): Change type
1123         of win_info.
1124         * tui/tui-winsource.c (tui_clear_source_content)
1125         (tui_erase_source_content, tui_show_source_content): Change type
1126         of win_info.
1127         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1128         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1129         win_info.
1130         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1131         win_info.
1132         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1133
1134 2019-06-25  Tom Tromey  <tom@tromey.com>
1135
1136         * tui/tui-winsource.c (tui_clear_source_content)
1137         (tui_source_window_base::set_is_exec_point_at): Update.
1138         * tui/tui-source.c (tui_set_source_content_nil): Update.
1139         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1140         a bool.
1141         * tui/tui-data.c (init_content_element): Update.
1142
1143 2019-06-25  Tom Tromey  <tom@tromey.com>
1144
1145         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1146         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1147         * tui/tui-layout.c (init_and_make_win): Update.
1148         * tui/tui.h (enum tui_win_type): Update.
1149         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1150         tui_win_is_auxillary.
1151         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1152         tui_win_is_auxillary.
1153
1154 2019-06-25  Tom Tromey  <tom@tromey.com>
1155
1156         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1157         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1158         (tui_delete_data_content_windows, tui_display_all_data)
1159         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1160         Update.
1161         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1162         * tui/tui-regs.c (tui_last_regs_line_no)
1163         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1164         (tui_show_registers): Update.
1165         (tui_show_register_group): Return void.  Update.
1166         (tui_display_registers_from, tui_display_reg_element_at_line)
1167         (tui_display_registers_from_line, tui_check_register_values):
1168         Update.
1169         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1170         member.
1171         (struct tui_data_window) <regs_content>: Now a std::vector.
1172         <regs_content_count>: Remove.
1173         (tui_add_content_elements, tui_free_data_content): Don't declare.
1174         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1175         (init_content_element): Remove DATA_WIN case.  Add assert.
1176         (tui_add_content_elements): Remove.
1177         (tui_data_window): Update.
1178         (tui_free_data_content): Remove.
1179         (free_content_elements): Remove DATA_WIN case.
1180
1181 2019-06-25  Tom Tromey  <tom@tromey.com>
1182
1183         * tui/tui-data.c (tui_data_item_window): Update.
1184         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1185         * tui/tui-windata.c (tui_display_all_data)
1186         (tui_display_data_from_line): Update.
1187         (tui_check_data_values): Remove.
1188         * tui/tui-regs.c (tui_show_register_group)
1189         (tui_display_reg_element_at_line): Update.
1190         * tui/tui-hooks.c (tui_register_changed)
1191         (tui_refresh_frame_and_register_information): Call
1192         tui_check_register_values.
1193         * tui/tui-data.h (struct tui_data_window) <data_content,
1194         data_content_count, data_type>: Remove.
1195         (enum tui_data_type): Remove.
1196
1197         * tui/tui-data.c (tui_data_window::clear_detail)
1198         (~tui_data_window): Update.
1199
1200 2019-06-25  Tom Tromey  <tom@tromey.com>
1201
1202         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1203         declare.
1204         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1205         Rename from tui_first_data_item_displayed.  Update.
1206         (tui_data_window::refresh_all)
1207         (tui_data_window::do_scroll_vertical): Update.
1208         * tui/tui-data.h (struct tui_data_window)
1209         <first_data_item_displayed>: Declare new method.
1210
1211 2019-06-25  Tom Tromey  <tom@tromey.com>
1212
1213         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1214         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1215         contents...
1216         (tui_initialize_static_data): ...here.
1217
1218 2019-06-25  Tom Tromey  <tom@tromey.com>
1219
1220         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1221         (tui_display_registers_from, tui_check_register_values): Update.
1222         (tui_display_register): Remove win_info parameter; update.
1223         (tui_get_register): Change type of parameters.
1224         * tui/tui-data.h (struct tui_data_element): Remove.
1225         (union tui_which_element) <data>: Remove.
1226         <data_window>: Change type.
1227         (struct tui_data_item_window): New.
1228         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1229         case.  Add assert.
1230         (~tui_data_item_window): New destructor.
1231         (free_content_elements): Remove DATA_ITEM_WIN case.
1232
1233 2019-06-25  Tom Tromey  <tom@tromey.com>
1234
1235         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1236         Remove.
1237
1238 2019-06-25  Tom Tromey  <tom@tromey.com>
1239
1240         * tui/tui-data.h (struct tui_command_element): Remove.
1241         (union tui_which_element) <command>: Remove.
1242         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1243         assert.
1244         (free_content_elements): Remove CMD_WIN case.
1245
1246 2019-06-25  Tom Tromey  <tom@tromey.com>
1247
1248         * tui/tui-layout.c (tui_set_layout): Update.
1249         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1250         * tui/tui-data.c (layout_def): Update.
1251
1252 2019-06-25  Tom Tromey  <tom@tromey.com>
1253
1254         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1255         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1256         (tui_source_window_base::set_new_height): Update.
1257         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1258         Update.
1259         (tui_set_locator_fullname, tui_set_locator_info)
1260         (tui_show_frame_info): Update.
1261         * tui/tui-source.c (tui_set_source_content)
1262         (tui_source_is_displayed): Update.
1263         * tui/tui-layout.c (show_source_disasm_command, show_data)
1264         (show_source_or_disasm_and_command): Update.
1265         * tui/tui-disasm.c (tui_set_disassem_content)
1266         (tui_get_begin_asm_address): Update.
1267         * tui/tui-data.h (struct tui_locator_element): Remove.
1268         (union tui_which_element) <locator>: Remove.
1269         (struct tui_locator_window): New.
1270         (tui_locator_win_info_ptr): Change return type.
1271         * tui/tui-data.c (_locator): Change type.
1272         (tui_locator_win_info_ptr): Change return type.
1273         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1274         (tui_alloc_content): Add assert.
1275
1276 2019-06-25  Tom Tromey  <tom@tromey.com>
1277
1278         * tui/tui-winsource.c
1279         (tui_exec_info_window::maybe_allocate_content): New method.
1280         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1281         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1282         (make_source_or_disasm_window): Add cast.
1283         * tui/tui-data.h (union tui_which_element) <simple_string>:
1284         Remove.
1285         (struct tui_source_info): New.
1286         (struct tui_source_window_base) <execution_info>: Change type.
1287         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1288         case, and add assert.
1289         (tui_alloc_content): Add assert.
1290
1291 2019-06-25  Tom Tromey  <tom@tromey.com>
1292
1293         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1294         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1295         * tui/tui-data.c (tui_alloc_win_info): Remove.
1296
1297 2019-06-25  Tom Tromey  <tom@tromey.com>
1298
1299         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1300         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1301         can_highlight.
1302
1303 2019-06-25  Tom Tromey  <tom@tromey.com>
1304
1305         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1306         make_visible_with_new_height method.
1307         (tui_win_info::make_visible_with_new_height): New method.
1308         (tui_source_window_base::do_make_visible_with_new_height)
1309         (tui_data_window::do_make_visible_with_new_height)
1310         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1311         (make_visible_with_new_height): Remove.
1312         (tui_resize_all, tui_adjust_win_heights): Use
1313         make_visible_with_new_height method.
1314         * tui/tui-data.h (struct tui_win_info)
1315         <do_make_visible_with_new_height, make_visible_with_new_height>:
1316         New methods.
1317         (struct tui_source_window_base, struct tui_data_window)
1318         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1319         methods.
1320
1321 2019-06-25  Tom Tromey  <tom@tromey.com>
1322
1323         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1324         method.
1325         (update_tab_width): Call update_tab_width method.
1326         * tui/tui-data.h (struct tui_win_info)
1327         (struct tui_source_window_base) <update_tab_width>: New methods.
1328
1329 2019-06-25  Tom Tromey  <tom@tromey.com>
1330
1331         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1332         parameter.
1333         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1334         parameter.
1335         (tui_gen_win_info::make_visible): Update.
1336         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1337         parameter.
1338         * tui/tui-data.h (enum tui_box): New enum.
1339         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1340
1341 2019-06-25  Tom Tromey  <tom@tromey.com>
1342
1343         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1344         init_and_make_win for EXEC_INFO_WIN.
1345         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1346         longer inline.
1347         (struct tui_win_info) <~tui_win_info>: Inline.
1348         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1349         Don't declare.
1350         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1351         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1352         Remove.
1353         (tui_initialize_static_data): Update.
1354         (~tui_gen_win_info): Handle more cleanup here.
1355         (~tui_source_window_base): Delete "execution_info".
1356         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1357
1358 2019-06-25  Tom Tromey  <tom@tromey.com>
1359
1360         * tui/tui-layout.c (make_command_window): Don't set
1361         can_highlight.
1362         (show_source_disasm_command): Call the reset method.
1363         (show_data): Don't set can_highlight.  Call the reset method.
1364         (tui_gen_win_info::reset): Rename from init_gen_win_info
1365         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1366         (show_source_or_disasm_and_command): Call the reset method.
1367         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1368         (struct tui_cmd_window): Set can_highlight.
1369
1370 2019-06-25  Tom Tromey  <tom@tromey.com>
1371
1372         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1373         from make_visible.
1374         (tui_make_visible, tui_make_invisible): Rewrite.
1375         (tui_win_info::make_visible): Remove.
1376         (tui_source_window_base::make_visible): Update.
1377         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1378         method.  Moved from...
1379         (struct tui_win_info) <make_visible>: ...here.
1380
1381 2019-06-25  Tom Tromey  <tom@tromey.com>
1382
1383         * tui/tui-winsource.c
1384         (tui_source_window_base::do_scroll_horizontal): Remove direction
1385         parameter.
1386         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1387         direction parameter.
1388         * tui/tui-win.c (tui_win_info::forward_scroll)
1389         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1390         (tui_win_info::right_scroll): Update.
1391         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1392         direction parameter.
1393         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1394         direction parameter.
1395         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1396         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1397         Remove direction parameter.
1398         (struct tui_source_window_base, struct tui_source_window)
1399         (struct tui_disasm_window, struct tui_data_window)
1400         (struct tui_cmd_window): Update.
1401
1402 2019-06-25  Tom Tromey  <tom@tromey.com>
1403
1404         * tui/tui-winsource.h (tui_set_exec_info_content)
1405         (tui_show_exec_info_content, tui_erase_exec_info_content)
1406         (tui_clear_exec_info_content, tui_update_exec_info): Change
1407         argument to tui_source_window_base.
1408         * tui/tui-winsource.c (tui_set_exec_info_content)
1409         (tui_show_exec_info_content, tui_erase_exec_info_content)
1410         (tui_clear_exec_info_content, tui_update_exec_info): Change
1411         argument to tui_source_window_base.
1412
1413 2019-06-25  Tom Tromey  <tom@tromey.com>
1414
1415         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1416         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1417
1418 2019-06-25  Tom Tromey  <tom@tromey.com>
1419
1420         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1421         check.
1422
1423 2019-06-25  Tom Tromey  <tom@tromey.com>
1424
1425         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1426         type to void.
1427         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1428         type to void.
1429         * tui/tui-source.c (tui_set_source_content): Update.
1430         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1431
1432 2019-06-25  Tom Tromey  <tom@tromey.com>
1433
1434         * tui/tui-win.c (window_name_completer, tui_set_focus)
1435         (tui_all_windows_info): Use name method.
1436         * tui/tui-data.h (struct tui_gen_win_info)
1437         (struct tui_source_window, struct tui_disasm_window)
1438         (struct tui_data_window, struct tui_cmd_window) <name>: New
1439         method.
1440         (tui_win_name): Don't declare.
1441         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1442         (tui_win_name): Remove.
1443
1444 2019-06-25  Tom Tromey  <tom@tromey.com>
1445
1446         * tui/tui-winsource.h (tui_update_source_window)
1447         (tui_update_source_window_as_is): Change parameter type.
1448         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1449         to be a tui_source_window_base.
1450         (tui_update_source_window_as_is): Likewise.
1451         * tui/tui-win.c (make_visible_with_new_height): Update.
1452
1453 2019-06-25  Tom Tromey  <tom@tromey.com>
1454
1455         * tui/tui-winsource.c (tui_erase_source_content)
1456         (tui_show_source_content, tui_show_exec_info_content)
1457         (tui_erase_exec_info_content): Use refresh_window method.
1458         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1459         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1460         from tui_refresh_win.
1461         (tui_data_window::refresh_window): New method.
1462         (tui_win_info::refresh, tui_source_window_base::refresh)
1463         (tui_refresh_all): Use refresh_window method.
1464         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1465         method.
1466         * tui/tui-regs.c (tui_display_register): Call refresh_window
1467         method.
1468         * tui/tui-layout.c (show_source_disasm_command)
1469         (show_source_or_disasm_and_command): Call refresh_window method.
1470         * tui/tui-data.h (struct tui_gen_win_info)
1471         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1472         New method.
1473
1474 2019-06-25  Tom Tromey  <tom@tromey.com>
1475
1476         * tui/tui.c (tui_rl_other_window, tui_enable)
1477         (tui_is_window_visible, tui_get_command_dimension): Update.
1478         * tui/tui-winsource.c (tui_update_source_window_as_is)
1479         (tui_clear_source_content, tui_erase_source_content)
1480         (tui_show_source_line, tui_source_window_base::refill)
1481         (tui_source_window_base::do_scroll_horizontal)
1482         (tui_source_window_base::set_is_exec_point_at)
1483         (tui_update_breakpoint_info, tui_set_exec_info_content)
1484         (tui_alloc_source_buffer, tui_line_is_displayed)
1485         (tui_addr_is_displayed): Update.
1486         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1487         (tui_check_and_display_highlight_if_needed)
1488         (tui_win_info::make_visible, tui_win_info::refresh)
1489         (tui_refresh_all): Update.
1490         * tui/tui-windata.c (tui_first_data_item_displayed)
1491         (tui_delete_data_content_windows, tui_erase_data_content)
1492         (tui_display_all_data, tui_data_window::refresh_all)
1493         (tui_check_data_values): Update.
1494         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1495         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1496         (tui_win_info::backward_scroll, tui_refresh_all_win)
1497         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1498         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1499         (tui_source_window_base::set_new_height)
1500         (tui_data_window::set_new_height)
1501         (make_invisible_and_set_new_height)
1502         (make_visible_with_new_height, new_height_ok)
1503         (parse_scrolling_args): Update.
1504         * tui/tui-stack.c (tui_show_frame_info): Update.
1505         * tui/tui-source.c (tui_set_source_content)
1506         (tui_set_source_content_nil, tui_source_is_displayed)
1507         (tui_source_window::do_scroll_vertical): Update.
1508         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1509         (tui_display_registers_from, tui_display_reg_element_at_line)
1510         (tui_check_register_values, tui_reg_command): Update.
1511         * tui/tui-layout.c (tui_default_win_height)
1512         (show_source_disasm_command, show_data, init_and_make_win)
1513         (show_source_or_disasm_and_command): Update.
1514         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1515         (tui_redisplay_readline, tui_mld_flush)
1516         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1517         (tui_getc): Update.
1518         * tui/tui-disasm.c (tui_set_disassem_content)
1519         (tui_disasm_window::do_scroll_vertical): Update.
1520         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1521         Now virtual.
1522         (struct tui_win_info): Derive from tui_gen_win_info.
1523         <~tui_win_info>: Mark as override.
1524         <generic>: Remove member.
1525         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1526         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1527         (~tui_data_window, ~tui_win_info)
1528         (tui_free_all_source_wins_content): Update.
1529         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1530
1531 2019-06-25  Tom Tromey  <tom@tromey.com>
1532
1533         * tui/tui-layout.c (init_and_make_win): Use new.
1534         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1535         destructor, initializers.
1536         (tui_alloc_generic_win_info): Don't declare.
1537         * tui/tui-data.c (_locator): Add argument to constructor.
1538         (source_win, disasm_win): New globals.
1539         (exec_info): Remove.
1540         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1541         Update.
1542         (tui_alloc_generic_win_info): Remove.
1543         (init_content_element): Use new.
1544         (tui_win_info::tui_win_info): Update.
1545         (free_content_elements) <case DATA_WIN>: Use delete.
1546
1547 2019-06-25  Tom Tromey  <tom@tromey.com>
1548
1549         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1550         * tui/tui-windata.c (tui_first_data_item_displayed)
1551         (tui_delete_data_content_windows): Update.
1552         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1553         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1554         (tui_display_registers_from, tui_check_register_values): Update.
1555         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1556         pointer.
1557         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1558         window.
1559         (tui_free_data_content): Update.
1560         (free_content_elements) <case DATA_WIN>: Free the window.
1561
1562 2019-06-25  Tom Tromey  <tom@tromey.com>
1563
1564         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1565         Update.
1566         * tui/tui-layout.c (make_command_window)
1567         (show_source_disasm_command, show_data, init_and_make_win)
1568         (show_source_or_disasm_and_command): Update.
1569         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1570         method.
1571         <can_highight, is_highlighted>: Now bool.
1572         (tui_set_win_highlight): Don't declare.
1573         * tui/tui-data.c (tui_set_win_highlight): Remove.
1574
1575 2019-06-25  Tom Tromey  <tom@tromey.com>
1576
1577         * tui/tui-wingeneral.c (make_visible): Remove check of window
1578         type.
1579
1580 2019-06-25  Tom Tromey  <tom@tromey.com>
1581
1582         * tui/tui-win.c (tui_win_info::max_height)
1583         (tui_cmd_window::max_height): New methods.
1584         (new_height_ok): Call max_height.
1585         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1586         <max_height>: New method.
1587
1588 2019-06-25  Tom Tromey  <tom@tromey.com>
1589
1590         * tui/tui-win.c (tui_source_window_base::set_new_height)
1591         (tui_data_window::set_new_height): New methods.
1592         (make_invisible_and_set_new_height): Call set_new_height method.
1593         * tui/tui-data.h (struct tui_win_info)
1594         (struct tui_source_window_base, struct tui_data_window)
1595         <set_new_height>: New method.
1596
1597 2019-06-25  Tom Tromey  <tom@tromey.com>
1598
1599         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1600         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1601         tui_refresh_data_win.
1602         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1603         method.
1604         (tui_refresh_all_win): Call the refresh_all method.
1605         (tui_set_focus): Likewise.
1606         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1607         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1608         Likewise.
1609
1610 2019-06-25  Tom Tromey  <tom@tromey.com>
1611
1612         * tui/tui-winsource.h (tui_refill_source_window)
1613         (tui_set_is_exec_point_at): Don't declare.
1614         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1615         (tui_source_window_base::refill): Rename from
1616         tui_refill_source_window.
1617         (tui_source_window_base::do_scroll_horizontal): Update.
1618         (tui_source_window_base::set_is_exec_point_at): Rename from
1619         tui_set_is_exec_point_at.
1620         (tui_update_all_breakpoint_info): Update.
1621         * tui/tui-stack.c (tui_show_frame_info): Update.
1622         * tui/tui-layout.c (show_data): Add cast.
1623         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1624         * tui/tui-data.h (struct tui_source_window_base) <refill,
1625         set_is_exec_point_at>: New methods.
1626         (tui_source_windows, tui_add_to_source_windows): Update types.
1627         (tui_add_to_source_windows): Remove redundant declaration.
1628         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1629         (tui_source_windows): Change return type.
1630         (tui_clear_source_windows_detail): Update.
1631         (tui_add_to_source_windows): Change type of parameter.
1632         (tui_free_all_source_wins_content): Update.
1633
1634 2019-06-25  Tom Tromey  <tom@tromey.com>
1635
1636         * tui/tui-wingeneral.c (tui_win_info::refresh)
1637         (tui_source_window_base::refresh): New methods.
1638         (tui_refresh_all): Call the refresh method.
1639         * tui/tui-data.h (struct tui_win_info)
1640         (struct tui_source_window_base) <refresh>: New method.
1641
1642 2019-06-25  Tom Tromey  <tom@tromey.com>
1643
1644         * tui/tui.h (tui_is_window_visible): Return bool.
1645         * tui/tui.c (tui_is_window_visible): Return bool.
1646         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1647         (tui_make_visible, tui_make_invisible)
1648         (tui_win_info::make_visible)
1649         (tui_source_window_base::make_visible, make_all_visible)
1650         (tui_make_all_visible, tui_make_all_invisible): Update.
1651         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1652         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1653         bool.
1654         (struct tui_win_info, struct tui_source_window_base)
1655         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1656         * tui/tui-data.c (tui_init_generic_part): Update.
1657
1658 2019-06-25  Tom Tromey  <tom@tromey.com>
1659
1660         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1661         (tui_source_window_base::make_visible): New methods.
1662         (make_all_visible): Make method call.
1663         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1664         (struct tui_source_window_base, struct tui_cmd_window): Override
1665         make_visible.
1666         (tui_win_is_source_type): Don't declare.
1667         * tui/tui-data.c (tui_win_is_source_type): Remove.
1668
1669 2019-06-25  Tom Tromey  <tom@tromey.com>
1670
1671         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1672         NULL check.
1673
1674 2019-06-25  Tom Tromey  <tom@tromey.com>
1675
1676         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1677         Inline constructor.  Add initializers for members.
1678         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1679         constructors; now inline in class.
1680
1681 2019-06-25  Tom Tromey  <tom@tromey.com>
1682
1683         * tui/tui-regs.c (tui_show_registers): Update.
1684         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1685         bool.
1686         * tui/tui-data.c (tui_data_window::clear_detail)
1687         (tui_data_window): Update.
1688
1689 2019-06-25  Tom Tromey  <tom@tromey.com>
1690
1691         * tui/tui-windata.c (tui_display_all_data)
1692         (tui_display_data_from_line, tui_display_data_from)
1693         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1694         Update.
1695         * tui/tui-regs.c (tui_last_regs_line_no)
1696         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1697         (tui_show_registers, tui_show_register_group)
1698         (tui_display_registers_from, tui_display_reg_element_at_line)
1699         (tui_display_registers_from_line, tui_check_register_values)
1700         (tui_reg_next, tui_reg_prev): Update.
1701         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1702         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1703         tui_data_window.
1704         (struct tui_win_info) <detail>: Remove.  Add new fields from
1705         tui_data_info.
1706         (TUI_DATA_WIN): Add cast.
1707         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1708         (~tui_data_window): Simplify.
1709
1710 2019-06-25  Tom Tromey  <tom@tromey.com>
1711
1712         * tui/tui-layout.c (show_source_disasm_command)
1713         (show_source_or_disasm_and_command): Update.
1714         * tui/tui-io.c (update_cmdwin_start_line)
1715         (tui_redisplay_readline): Update.
1716         * tui/tui-data.h (struct tui_command_info): Remove.
1717         (struct tui_win_info) <detail>: Remove command_info member.
1718         (struct tui_data_window) <start_line>: New member, from
1719         tui_command_info.
1720         (TUI_CMD_WIN): Add casts.
1721
1722 2019-06-25  Tom Tromey  <tom@tromey.com>
1723
1724         * tui/tui-winsource.c (tui_update_source_window)
1725         (tui_refill_source_window)
1726         (tui_source_window_base::do_scroll_horizontal)
1727         (tui_update_breakpoint_info, tui_set_exec_info_content)
1728         (tui_show_exec_info_content, tui_erase_exec_info_content)
1729         (tui_clear_exec_info_content): Update.
1730         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1731         Update.
1732         * tui/tui-win.c (make_invisible_and_set_new_height)
1733         (make_visible_with_new_height): Update.
1734         * tui/tui-source.c (tui_set_source_content)
1735         (tui_show_symtab_source): Update.
1736         * tui/tui-layout.c (extract_display_start_addr)
1737         (show_source_disasm_command, show_data)
1738         (make_source_or_disasm_window)
1739         (show_source_or_disasm_and_command): Update.
1740         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1741         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1742         "gdbarch".
1743         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1744         to tui_source_window_base.
1745         (struct tui_win_info) <detail>: Remove source_info member.
1746         (struct tui_source_window_base) <has_locator>: Inline.
1747         Move contents from tui_source_info; rename has_locator member to
1748         m_has_locator.
1749         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1750         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1751         header file.
1752         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1753         Simplify.
1754         (tui_free_all_source_wins_content): Cast to
1755         tui_source_window_base.
1756
1757 2019-06-25  Tom Tromey  <tom@tromey.com>
1758
1759         * tui/tui-win.c (make_invisible_and_set_new_height)
1760         (make_visible_with_new_height): Call has_locator method.
1761         * tui/tui-layout.c (show_source_disasm_command, show_data)
1762         (show_source_or_disasm_and_command): Update for bool change.
1763         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1764         (tui_win_info) <has_locator>: New method.
1765         (struct tui_source_window_base) <has_locator>: New method.
1766         (tui_win_has_locator): Don't declare.
1767         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1768         from tui_win_has_locator.
1769         (tui_source_window_base): Use false, not FALSE.
1770
1771 2019-06-25  Tom Tromey  <tom@tromey.com>
1772
1773         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1774         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1775         clear_detail method directly.
1776         (tui_clear_win_detail): Remove.
1777
1778 2019-06-25  Tom Tromey  <tom@tromey.com>
1779
1780         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1781         "this", not TUI_DISASM_WIN.
1782
1783 2019-06-25  Tom Tromey  <tom@tromey.com>
1784
1785         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1786         declare.
1787         * tui/tui-winsource.c
1788         (tui_source_window_base::do_scroll_horizontal): Rename from
1789         tui_horizontal_source_scroll.
1790         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1791         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1792         from tui_vertical_data_scroll.
1793         * tui/tui-win.h (tui_scroll): Don't declare.
1794         * tui/tui-win.c (tui_win_info::forward_scroll)
1795         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1796         (tui_win_info::right_scroll): Rename and update.
1797         (tui_scroll_forward_command, tui_scroll_backward_command)
1798         (tui_scroll_left_command, tui_scroll_right_command): Update.
1799         (tui_scroll): Remove.
1800         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1801         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1802         from tui_vertical_source_scroll.
1803         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1804         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1805         from tui_vertical_disassem_scroll.
1806         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1807         do_scroll_horizontal>: New methods.
1808         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1809         Likewise.
1810         (struct tui_source_window_base): Add do_scroll_horizontal.
1811         (struct tui_source_window, struct tui_disasm_window): Add
1812         do_scroll_vertical.
1813         (struct tui_data_window, struct tui_cmd_window): Add
1814         do_scroll_horizontal and do_scroll_vertical.
1815         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1816
1817 2019-06-25  Tom Tromey  <tom@tromey.com>
1818
1819         * tui/tui-data.h (struct tui_source_window_base): New struct.
1820         (struct tui_source_window): Derive from tui_source_window_base.
1821         (struct tui_disasm_window): New struct.
1822         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1823         from tui_source_window::clear_detail.
1824         (tui_source_window_base): Rename from tui_source_window.
1825         (~tui_source_window_base): Rename from ~tui_source_window.
1826         (tui_alloc_win_info): Create a tui_disasm_window.
1827
1828 2019-06-25  Tom Tromey  <tom@tromey.com>
1829
1830         * tui/tui-data.h (struct tui_source_window)
1831         (struct tui_data_window): Declare destructors.
1832         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1833         destructors.
1834         (tui_win_info): Simplify.
1835
1836 2019-06-25  Tom Tromey  <tom@tromey.com>
1837
1838         * tui/tui-winsource.c (tui_display_main)
1839         (tui_update_source_windows_with_addr)
1840         (tui_update_all_breakpoint_info): Update.
1841         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1842         (new_height_ok, parse_scrolling_args): Update.
1843         * tui/tui-stack.c (tui_show_frame_info): Update.
1844         * tui/tui-data.h (struct tui_list): Remove.
1845         (tui_source_windows): Return a reference to a std::vector.
1846         * tui/tui-data.c (source_windows): Now a std::vector.
1847         (tui_source_windows): Change return type.
1848         (tui_clear_source_windows): Rewrite.
1849         (tui_clear_source_windows_detail, tui_add_to_source_windows)
1850         (tui_free_all_source_wins_content): Rewrite.
1851
1852 2019-06-25  Tom Tromey  <tom@tromey.com>
1853
1854         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
1855         (struct tui_data_window, struct tui_cmd_window): Declare
1856         clear_detail method.
1857         * tui/tui-data.c (tui_source_window::clear_detail)
1858         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
1859         methods.
1860         (tui_clear_win_detail): Simplify.
1861
1862 2019-06-25  Tom Tromey  <tom@tromey.com>
1863
1864         * tui/tui-layout.c (make_source_window, make_disasm_window)
1865         (make_source_or_disasm_window): Remove win_info_ptr parameter.
1866         Return the new window.
1867         (show_source_disasm_command, show_data)
1868         (show_source_or_disasm_and_command): Update.
1869
1870 2019-06-25  Tom Tromey  <tom@tromey.com>
1871
1872         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
1873         parameter.  Return the new window.
1874         (show_source_disasm_command): Update and remove NULL check.
1875         (show_source_or_disasm_and_command): Update.
1876
1877 2019-06-25  Tom Tromey  <tom@tromey.com>
1878
1879         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
1880
1881 2019-06-25  Tom Tromey  <tom@tromey.com>
1882
1883         * tui/tui-data.h (struct tui_win_info): Make constructor
1884         protected.  Make destructor virtual.  Add initializers.
1885         (tui_source_window, tui_data_window, tui_cmd_window): New
1886         classes.
1887         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
1888         constructor.  Add "type" parameter.
1889         (tui_source_window, tui_data_window, tui_cmd_window): New
1890         constructors.
1891         (tui_alloc_win_info): Instantiate the appropriate subclass.
1892
1893 2019-06-25  Tom Tromey  <tom@tromey.com>
1894
1895         * tui/tui-win.c (tui_resize_all): Use delete.
1896         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
1897         destructor.
1898         (tui_free_window): Don't declare.
1899         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
1900         Update.
1901
1902 2019-06-25  Tom Tromey  <tom@tromey.com>
1903
1904         * tui/tui-data.h (struct tui_win_info): Add constructor.
1905         * tui/tui-data.c (tui_alloc_win_info): Use new.
1906         (tui_free_window): Use delete.
1907
1908 2019-06-22  Tom Tromey  <tom@tromey.com>
1909
1910         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
1911         declare.
1912         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
1913
1914 2019-06-22  Tom Tromey  <tom@tromey.com>
1915
1916         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
1917         declare.
1918         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
1919
1920 2019-06-22  Tom de Vries  <tdevries@suse.de>
1921
1922         * dwarf2read.c (create_addrmap_from_aranges)
1923         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
1924         instead of '%zu'.
1925
1926 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
1927
1928         * dwarf2read.h (dwarf2_section_info_def): Remove.
1929         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
1930         * dwarf2read.c (struct dwo_sections) <types>: Change type to
1931         std::vector<dwarf2_section_info>.
1932         (struct dwo_file) <~dwo_file>: Remove.
1933         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
1934         types field.
1935         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
1936         (dwarf2_read_debug_names): Likewise.
1937         (create_debug_types_hash_table): Change parameter type to
1938         array_view, adjust code accordingly.
1939         (dwarf2_locate_dwo_sections): Adjust to std::vector.
1940         (partial_die_info::fixup): Likewise.
1941         (determine_prefix): Likewise.
1942         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
1943
1944 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1945
1946         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
1947         gdb_bfd_ref_ptr.
1948         <~dwo_file>: Remove call to gdb_bfd_unref.
1949         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
1950         gdb_bfd_ref_ptr::get.
1951
1952 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1953
1954         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
1955         type to htab_up.
1956         * dwarf2read.c (struct dwo_file): Initialize fields.
1957         <~dwo_file>: New.
1958         (free_dwo_file): Remove, move content to ~dwo_file.
1959         (struct dwo_file_deleter): Remove.
1960         (dwo_file_up>: Remove custom deleter.
1961         (free_dwo_files): Remove.
1962         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
1963         dwo_files.
1964         (process_skeletonless_type_units): Call unique_ptr::get.
1965         (allocate_dwo_file_hash_table): Add deleter to created hash
1966         table.  Change return type to htab_up.
1967         (lookup_dwo_file_slot): Don't memset dwo_file, call
1968         unique_ptr::get.
1969         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
1970         (create_dwo_unit_in_dwp_v2): Likewise.
1971         (open_and_init_dwo_file): Likewise.
1972         (free_dwo_file_from_slot): Remove.
1973
1974 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1975
1976         * dwarf2read.h (struct dwarf2_section_info) <readin,
1977         is_virtual>: Change type to bool.
1978         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
1979         true instead of 1.
1980
1981 2019-06-19  Tom Tromey  <tom@tromey.com>
1982
1983         * tui/tui-data.h (tui_init_content_element): Don't declare.
1984
1985 2019-06-19  Tom Tromey  <tom@tromey.com>
1986
1987         * tui/tui-data.h (tui_init_win_info): Don't declare.
1988
1989 2019-06-19  Tom de Vries  <tdevries@suse.de>
1990
1991         * dwarf2read.h (abstract_to_concrete): Change type to
1992         std::unordered_map<sect_offset, std::vector<sect_offset>,
1993         gdb::hash_enum<sect_offset>>.
1994
1995 2019-06-19  Tom Tromey  <tromey@adacore.com>
1996
1997         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
1998         EVAL_AVOID_SIDE_EFFECTS specially.
1999
2000 2019-06-19  Tom Tromey  <tromey@adacore.com>
2001
2002         * source-cache.c (highlighter): New global.
2003         (source_cache::get_source_lines): Create a highlighter on demand.
2004
2005 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2006
2007         * defs.h (deprecated_interactive_hook): Delete declaration.
2008         * interps.c (clear_interpreter_hooks): Remove use of
2009         deprecated_interactive_hook.
2010         * top.c (deprecated_interactive_hook): Delete definition.
2011         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2012
2013 2019-06-18  Tom de Vries  <tdevries@suse.de>
2014
2015         PR gdb/24515
2016         * dwarf2read.h (abstract_to_concrete): Change type from
2017         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2018         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2019         * dwarf2read.c (read_variable): Update.
2020         (dwarf2_fetch_die_loc_sect_off): Update.
2021
2022 2019-06-17  Tom de Vries  <tdevries@suse.de>
2023
2024         PR gdb/24617
2025         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2026         accessing parent[parent_len - 1].
2027
2028 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2029
2030         PR gdb/24364
2031         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2032         call dtrace_process_dof with NULL dof.
2033
2034 2019-06-16  Tom de Vries  <tdevries@suse.de>
2035
2036         PR gdb/24445
2037         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2038
2039 2019-06-16  Tom Tromey  <tom@tromey.com>
2040
2041         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2042         (make_all_visible): Use address of member.
2043
2044 2019-06-16  Tom Tromey  <tom@tromey.com>
2045
2046         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2047         (tui_free_window, free_content, free_content_elements): Remove
2048         unnecessary cast.
2049         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2050         cast.
2051         * tui/tui-regs.c (tui_show_register_group)
2052         (tui_display_registers_from, tui_display_reg_element_at_line):
2053         Remove unnecessary cast.
2054
2055 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2056
2057         * linux-nat.c (normal_mask): Delete.
2058         (_initialize_linux_nat): Don't initialise normal_mask.
2059
2060 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2061
2062         PR gdb/24445
2063         * dwarf-index-write.h (write_psymtabs_to_index): Add
2064         dwz_basename parameter.
2065         * dwarf-index-write.c (write_gdbindex): Move file writing to
2066         write_gdbindex_1.  Change return type void.
2067         (assert_file_size): Move up, remove filename parameter.
2068         (write_gdbindex_1): New function.
2069         (write_debug_names): Change return type to void, call
2070         assert_file_size.
2071         (struct index_wip_file): New struct.
2072         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2073         file logic to index_wip_file.  Write index for dwz file if
2074         needed.
2075         (save_gdb_index_command): Pass basename of dwz file, if present.
2076         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2077         build-id of dwz file, if present.
2078         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2079         (dwarf2_get_dwz_file): Likewise.
2080         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2081         (dwarf2_get_dwz_file): Likewise.
2082
2083 2019-06-16  Tom Tromey  <tom@tromey.com>
2084
2085         * coffread.c (process_coff_symbol): Use xstrdup.
2086         * value.c (create_internalvar): Use xstrdup.
2087
2088 2019-06-16  Tom Tromey  <tom@tromey.com>
2089
2090         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2091         * breakpoint.c (stopin_command, stopat_command)
2092         (until_break_command, decode_location_default): Remove unnecessary
2093         cast.
2094         * utils.c (subset_compare): Remove unnecessary cast.
2095         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2096         cast.
2097         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2098         cast.
2099         * infcmd.c (path_command): Remove unnecessary cast.
2100         * coffread.c (decode_type): Remove unnecessary cast.
2101         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2102         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2103         * tui/tui-stack.c (tui_show_locator_content)
2104         (tui_show_frame_info): Remove unnecessary cast.
2105         * tui/tui-win.c (tui_scroll_forward_command)
2106         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2107         (parse_scrolling_args): Remove unnecessary cast.
2108         * tui/tui-data.c (init_win_info, tui_del_window)
2109         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2110         (free_content_elements): Remove unnecessary cast.
2111         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2112         unnecessary cast.
2113         * tui/tui-source.c (tui_set_source_content)
2114         (tui_vertical_source_scroll): Remove unnecessary cast.
2115         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2116         cast.
2117         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2118         * tui/tui-regs.c (tui_display_registers_from)
2119         (tui_display_register): Remove unnecessary cast.
2120         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2121         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2122         (make_visible): Remove unnecessary cast.
2123         * tui/tui-winsource.c (tui_erase_source_content)
2124         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2125         unnecessary cast.
2126         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2127         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2128         * stabsread.c (read_type, read_array_type, read_range_type):
2129         Remove unnecessary cast.
2130         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2131         (parse_symbol, parse_type, upgrade_type, parse_external)
2132         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2133         unnecessary cast.
2134         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2135
2136 2019-06-16  Tom Tromey  <tom@tromey.com>
2137
2138         * tui/tui-data.c (tui_alloc_generic_win_info)
2139         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2140         checks.
2141
2142 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2143             Andrew Burgess  <andrew.burgess@embecosm.com>
2144
2145         * f-typeprint.c (f_print_type): Don't return early for not
2146         associated or not allocated types.
2147         (f_type_print_varspec_suffix): Add print_rank parameter and print
2148         ranks of array types in case they dangling.
2149         (f_type_print_base): Add print_rank parameter.
2150
2151 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2152
2153         * NEWS: Mention new MI commands.
2154         * break-catch-throw.c (enum exception_event_kind): Move to
2155         breakpoint.h.
2156         (print_mention_exception_catchpoint): Output text as a single
2157         message.
2158         (catch_exception_command_1): Rename to...
2159         (catch_exception_event): ...this, make non-static, update header
2160         command, and change some parameter types.
2161         (catch_catch_command): Update for changes to
2162         catch_exception_command_1.
2163         (catch_throw_command): Likewise.
2164         (catch_rethrow_command): Likewise.
2165         * breakpoint.c (enum exception_event_kind): Delete.
2166         * breakpoint.h (enum exception_event_kind): Moved here from
2167         break-catch-throw.c.
2168         (catch_exception_event): Declare.
2169         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2170         (mi_cmd_catch_throw): New function.
2171         (mi_cmd_catch_rethrow): New function.
2172         (mi_cmd_catch_catch): New function.
2173         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2174         'catch-catch' entries.
2175         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2176         (mi_cmd_catch_rethrow): Declare.
2177         (mi_cmd_catch_catch): Declare.
2178
2179 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2180
2181         * annotate.c (annotate_source_line): Change return type to void,
2182         update implementation to match.
2183         * annotate.h (annotate_source_line): Change return type to void,
2184         update header comment.
2185         * stack.c (print_frame_info): Don't change what frame information
2186         is printed based on whether annotations are on or not.
2187
2188 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2189
2190         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2191         (annotate_source): Make static.
2192         (annotate_source_line): Moved from source.c and renamed from
2193         identify_source_line.  Update the return type.
2194         * annotate.h (annotate_source): Delete declaration.
2195         (annotate_source_line): Declaration moved from source.h, and
2196         renamed from identify_source_line.  Return type updated.
2197         * source.c (identify_source_line): Moved to annotate.c and renamed
2198         to annotate_source_line.
2199         (info_line_command): Remove check of annotation_level.
2200         * source.h (identify_source_line): Move declaration to annotate.h
2201         and rename to annotate_source_line.
2202         * stack.c: Add 'annotate.h' include.
2203         (print_frame_info): Remove check of annotation_level before
2204         calling annotate_source_line.
2205
2206 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2207
2208         * source-cache.c (source_cache::get_plain_source_lines): Use
2209         open_source_file_with_line_charpos instead of just
2210         open_source_file, remove call to find_source_lines.
2211         (source_cache::get_source_lines): Likewise.
2212         * source.c (find_source_lines): Make static.
2213         (get_filename_and_charpos): Renamed into...
2214         (open_source_file_with_line_charpos): ..this along with changes to
2215         return a scoped_fd, and some other minor clean ups.
2216         (identify_source_line): Use open_source_file_with_line_charpos.
2217         (search_command_helper): Use open_source_file_with_line_charpos
2218         instead of just open_source_file, remove call to
2219         find_source_lines.
2220         * source.h (open_source_file_with_line_charpos): Declare new
2221         function.
2222         (find_source_lines): Delete declaration.
2223
2224 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2225
2226         * source.c (get_filename_and_charpos): Remove fullname
2227         parameter.
2228         (identify_source_line): Update call to get_filename_and_charpos.
2229
2230 2019-06-14  Tom Tromey  <tromey@adacore.com>
2231
2232         PR gdb/24502:
2233         * ui-style.h (skip_ansi_escape): Update comment.
2234         * ui-file.h (class no_terminal_escape_file): New class.
2235         * ui-file.c (no_terminal_escape_file::write)
2236         (no_terminal_escape_file::puts): New methods.
2237         * cli/cli-logging.c (handle_redirections): Use
2238         no_terminal_escape_file.
2239
2240 2019-06-14  Tom Tromey  <tromey@adacore.com>
2241
2242         * NEWS: Move convenience variable news above Python news.
2243
2244 2019-06-14  Tom Tromey  <tom@tromey.com>
2245
2246         * gnulib: Move directory to top-level.
2247         * configure.ac: Don't configure gnulib.
2248         * configure: Rebuild.
2249         * common/common-defs.h: Use new path to gnulib.
2250         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2251         (GNULIB_H): Remove.
2252         (INCGNU): Look in new gnulib location.
2253         (HFILES_NO_SRCDIR): Remove gnulib files.
2254         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2255         (generated_files): Remove GNULIB_H.
2256         ($(LIBGNU), all-lib): Remove targets.
2257         (distclean): Don't mention GNULIB_BUILDDIR.
2258         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2259
2260 2019-06-14  Tom Tromey  <tromey@adacore.com>
2261
2262         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2263         Warn if symbol file does not provide any symbols.
2264
2265 2019-06-14  Tom Tromey  <tromey@adacore.com>
2266
2267         * source.c (find_and_open_source): Respect basenames_may_differ.
2268
2269 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2270
2271         * annotate.c (annotate_breakpoints_invalid): Make use of
2272         scoped_restore_terminal_state.
2273         (annotate_frames_invalid): Likewise.
2274
2275 2019-06-14  Tom Tromey  <tromey@adacore.com>
2276
2277         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2278         allow assignment to an internalvar.
2279
2280 2019-06-14  Tom Tromey  <tromey@adacore.com>
2281
2282         * ada-lex.l: Allow "_" in attribute names.
2283
2284 2019-06-14  Tom Tromey  <tromey@adacore.com>
2285
2286         PR gdb/24653:
2287         * regcache.c (registers_changed): Don't call alloca.
2288         * top.c (execute_command): Don't call alloca.
2289
2290 2019-06-13  Pedro Alves  <palves@redhat.com>
2291
2292         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2293         'expression'.  When parsing an expression, error out if there's
2294         junk after "unlimited".
2295         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2296         (do_set_command): Adjust calls to is_unlimited_literal.
2297
2298 2019-06-13  Pedro Alves  <palves@redhat.com>
2299
2300         * compile/compile.c (make_compile_options_def_group): Add braces
2301         around array_view initializer.
2302         * thread.c (make_thread_apply_all_options_def_group)
2303         (make_thread_apply_all_options_def_group): Likewise.
2304
2305 2019-06-13  Pedro Alves  <palves@redhat.com>
2306
2307         * NEWS (New commands): Mention "maint test-options
2308         require-delimiter", "maint test-options unknown-is-error", "maint
2309         test-options unknown-is-operand" and "maint show
2310         test-options-completion-result".
2311         (New command options, command completion): New section.
2312         (Completion improvements): New section.
2313         Mention that you can abbreviate "unlimited".
2314
2315 2019-06-13  Pedro Alves  <palves@redhat.com>
2316
2317         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2318         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2319         * unittests/cli-utils-selftests.c (test_parse_flags)
2320         (test_parse_flags_qcs): Delete.
2321         (test_cli_utils): Don't call deleted functions.
2322
2323 2019-06-13  Pedro Alves  <palves@redhat.com>
2324
2325         * thread.c: Include "cli/cli-option.h".
2326         (tp_array_compar_ascending): Global.
2327         (tp_array_compar): Delete function.
2328         (tp_array_compar_ascending, tp_array_compar_descending): New
2329         functions.
2330         (ascending_option_def, qcs_flag_option_def)
2331         (thr_qcs_flags_option_defs)
2332         (make_thread_apply_all_options_def_group)
2333         (make_thread_apply_options_def_group): New.
2334         (thread_apply_all_command): Use gdb::option::process_options.
2335         (thread_apply_command_completer)
2336         (thread_apply_all_command_completer): New.
2337         (thread_apply_command): Use gdb::option::process_options.
2338         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2339         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2340         to generate help text of "thread apply".  Adjust "taas"'s help.
2341         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2342         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2343
2344 2019-06-13  Pedro Alves  <palves@redhat.com>
2345
2346         * thread.c (thread_apply_command): Check for invalid TID with
2347         isdigit instead of !isalpha.
2348
2349 2019-06-13  Pedro Alves  <palves@redhat.com>
2350
2351         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2352         (validate_flags_qcs): New.
2353         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2354         (validate_flags_qcs): Declare.
2355         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2356         (make_frame_apply_options_def_group): New.
2357         (frame_apply_command_count): Process options with
2358         gdb::option::process_options.
2359         (frame_apply_completer): New.
2360         (frame_apply_level_completer, frame_apply_all_completer)
2361         (frame_apply_completer): New.
2362         (_initialize_stack): Update help of "frame apply", "frame apply
2363         level", "frame apply all" and "faas" to mention supported options
2364         and install command completers.
2365         * stack.h (frame_apply_all_completer): Declare.
2366         * thread.c: Include "stack.h".
2367         (tfaas_command): Add "--".
2368         (_initialize_thread): Update help "tfaas" to mention supported
2369         options and install command completer.
2370
2371 2019-06-13  Pedro Alves  <palves@redhat.com>
2372
2373         * completer.c (complete_nested_command_line): New.
2374         (gdb_completion_word_break_characters_throw): Add assertion.
2375         * completer.h (complete_nested_command_line): Declare.
2376
2377 2019-06-13  Pedro Alves  <palves@redhat.com>
2378
2379         * stack.c (parse_backtrace_qualifiers): New.
2380         (backtrace_command): Use it.
2381         (backtrace_command_completer): Complete on qualifiers.
2382
2383 2019-06-13  Pedro Alves  <palves@redhat.com>
2384
2385         * frame.c: Include "cli/cli-option.h.
2386         (user_set_backtrace_options): New.
2387         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2388         Delete.
2389         (get_prev_frame): Adjust.
2390         (boolean_option_def, uinteger_option_def)
2391         (set_backtrace_option_defs): New.
2392         (_initialize_frame): Adjust and use
2393         gdb::option::add_setshow_cmds_for_options to install "set
2394         backtrace past-main" and "set backtrace past-entry".
2395         * frame.h: Include "cli/cli-option.h".
2396         (struct frame_print_options): Forward declare.
2397         (print_frame_arguments_all, print_frame_arguments_scalars)
2398         (print_frame_arguments_none): Declare.
2399         (print_entry_values): Delete declaration.
2400         (struct frame_print_options, user_frame_print_options): New.
2401         (struct set_backtrace_options): New.
2402         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2403         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2404         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2405         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2406         (list_args_or_locals): Add frame_print_options parameter.
2407         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2408         * python/py-framefilter.c (enumerate_args): Pass down
2409         USER_FRAME_PRINT_OPTIONS.
2410         * stack.c: Include "cli/cli-option.h".
2411         (print_frame_arguments_all, print_frame_arguments_scalars)
2412         (print_frame_arguments_none): Declare.
2413         (print_raw_frame_arguments, print_entry_values): Delete.
2414         (user_frame_print_options): New.
2415         (boolean_option_def, enum_option_def, frame_print_option_defs):
2416         New.
2417         (struct backtrace_cmd_options): New.
2418         (bt_flag_option_def): New.
2419         (backtrace_command_option_defs): New.
2420         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2421         (print_frame_arg, read_frame_arg, print_frame_args)
2422         (print_frame_info, print_frame): Add frame_print_options parameter
2423         and use it.
2424         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2425         (backtrace_command_1): Add frame_print_options and
2426         backtrace_cmd_options parameters and use them.
2427         (make_backtrace_options_def_group): New.
2428         (backtrace_command): Process command options with
2429         gdb::option::process_options.
2430         (backtrace_command_completer): New.
2431         (_initialize_stack): Extend "backtrace"'s help to mention
2432         supported options.  Install completer for "backtrace".
2433         Install some settings commands with add_setshow_cmds_for_options.
2434
2435 2019-06-13  Pedro Alves  <palves@redhat.com>
2436
2437         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2438         and that "set/show print raw frame-arguments" are now deprecated.
2439
2440         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2441         command.
2442         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2443         * stack.c (_initialize_stack): Install "set/show print
2444         raw-frame-arguments", and deprecate "set/show print raw
2445         frame-arguments".
2446         * valprint.c (_initialize_valprint): Deprecate "set/show print
2447         raw".
2448
2449 2019-06-13  Pedro Alves  <palves@redhat.com>
2450
2451         * compile/compile.c (struct compile_options): New.
2452         (compile_flag_option_def, compile_command_option_defs)
2453         (make_compile_options_def_group): New.
2454         (compile_file_command): Handle options with
2455         gdb::option::process_options.
2456         (compile_file_command_completer): New function.
2457         (compile_code_command): Handle options with
2458         gdb::option::process_options.
2459         (compile_code_command_completer): New function.
2460         (_initialize_compiler): Install completers for "compile code" and
2461         "compile file".  Mention available options in "compile code" and
2462         "compile code"'s help.
2463         * completer.c (advance_to_completion_word): New, factored out from
2464         ...
2465         (advance_to_expression_complete_word_point): ... this.
2466         (advance_to_filename_complete_word_point): New.
2467         * completer.h (advance_to_filename_complete_word_point): New
2468         declaration.
2469
2470 2019-06-13  Pedro Alves  <palves@redhat.com>
2471
2472         * compile/compile.c: Include "cli/cli-option.h".
2473         (compile_print_value): Scope data pointer is now a
2474         value_print_options pointer; adjust.
2475         (compile_print_command): Process options.  Scope data pointer is
2476         now a value_print_options pointer; adjust.
2477         (_initialize_compile): Update "compile print"'s help to include
2478         supported options.  Install a completer for "compile print".
2479         * cp-valprint.c (show_vtblprint, show_objectprint)
2480         (show_static_field_print): Delete.
2481         (_initialize_cp_valprint): Don't install "set print
2482         static-members", "set print vtbl", "set print object" here.
2483         * printcmd.c: Include "cli/cli-option.h" and
2484         "common/gdb_optional.h".
2485         (print_command_parse_format): Rework to fill in a
2486         value_print_options instead of a format_data.
2487         (print_value): Change parameter type from format_data pointer to
2488         value_print_options reference.  Adjust.
2489         (print_command_1): Process options.  Adjust to pass down a
2490         value_print_options.
2491         (print_command_completer): New.
2492         (_initialize_printcmd): Install print_command_completer as
2493         handle_brkchars completer for the "print" command.  Update
2494         "print"'s help to include supported options.
2495         * valprint.c: Include "cli/cli-option.h".
2496         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2497         here from cp-valprint.c.
2498         (boolean_option_def, uinteger_option_def)
2499         (value_print_option_defs, make_value_print_options_def_group):
2500         New.  Use gdb::option::add_setshow_cmds_for_options to install
2501         "set print elements", "set print null-stop", "set print repeats",
2502         "set print pretty", "set print union", "set print array", "set
2503         print address", "set print symbol", "set print array-indexes".
2504         * valprint.h: Include <string> and "cli/cli-option.h".
2505         (make_value_print_options_def_group): Declare.
2506         (print_value): Change parameter type from format_data pointer to
2507         value_print_options reference.
2508         (print_command_completer): Declare.
2509
2510 2019-06-13  Pedro Alves  <palves@redhat.com>
2511
2512         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2513         (COMMON_SFILES): Add maint-test-settings.c.
2514         * cli/cli-decode.c (boolean_enums): New global, factored out from
2515         ...
2516         (add_setshow_boolean_cmd): ... here.
2517         * cli/cli-decode.h (boolean_enums): Declare.
2518         * cli/cli-option.c: New file.
2519         * cli/cli-option.h: New file.
2520         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2521         factored out from ...
2522         (parse_cli_boolean_value(const char *)): ... this.
2523         (is_unlimited_literal): Change parameter type to pointer to
2524         pointer.  Adjust and advance ARG pointer.
2525         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2526         (parse_cli_var_enum): New, factored out from ...
2527         (do_set_command): ... this.  Adjust.
2528         * cli/cli-setshow.h (parse_cli_boolean_value)
2529         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2530         (parse_cli_var_enum): Declare.
2531         * cli/cli-utils.c: Include "cli/cli-option.h".
2532         (get_ulongest): New.
2533         * cli/cli-utils.h (get_ulongest): Declare.
2534         (check_for_argument): New overloads.
2535         * maint-test-options.c: New file.
2536
2537 2019-06-13  Pedro Alves  <palves@redhat.com>
2538
2539         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2540         parse a range if "-" is at the end of the string.
2541
2542 2019-06-13  Pedro Alves  <palves@redhat.com>
2543
2544         * cli/cli-setshow.c (parse_auto_binary_operation)
2545         (parse_cli_boolean_value): Don't allow "o".
2546
2547 2019-06-13  Pedro Alves  <palves@redhat.com>
2548
2549         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2550         * NEWS: Mention maint test-settings KIND.
2551         * maint-test-settings.c: New file.
2552
2553 2019-06-13  Pedro Alves  <palves@redhat.com>
2554
2555         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2556         completer.
2557         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2558         "set" completers.
2559
2560 2019-06-13  Pedro Alves  <palves@redhat.com>
2561
2562         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2563         after item.
2564
2565 2019-06-13  Pedro Alves  <palves@redhat.com>
2566
2567         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2568
2569 2019-06-13  Pedro Alves <palves@redhat.com>
2570
2571         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2572         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2573         call.
2574         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2575         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2576         calls.
2577         (check_for_argument): Skip spaces after argument.
2578
2579 2019-06-13  Pedro Alves  <palves@redhat.com>
2580
2581         * thread.c (thread_apply_command): Adjust TID parsing.
2582         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2583         detected before end of string.
2584         (tid_is_in_list): Error out if LIST is invalid.
2585
2586 2019-06-13  Pedro Alves  <palves@redhat.com>
2587
2588         * completer.c (complete_line_internal_1): Rewind completion word
2589         point.
2590         (completion_tracker::advance_custom_word_point_by): Change
2591         parameter type to int.
2592         * completer.h (completion_tracker::advance_custom_word_point_by):
2593         Likewise.
2594
2595 2019-06-13  Pedro Alves  <palves@redhat.com>
2596
2597         * completer.c (advance_to_completion_word): Handle delimiters.
2598
2599 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2600
2601         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2602
2603 2019-06-11  Tom Tromey  <tom@tromey.com>
2604
2605         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2606         (xmalloc_failed): Move to alloc.c.
2607         * alloc.c: New file.
2608         * Makefile.in (COMMON_SFILES): Add alloc.c.
2609
2610 2019-06-11  Tom Tromey  <tom@tromey.com>
2611
2612         * nat/linux-waitpid.c: Don't include server.h.
2613         (linux_debug): Remove.
2614         (my_waitpid): Update.
2615
2616 2019-06-11  Tom Tromey  <tromey@adacore.com>
2617
2618         * infcall.c (_initialize_infcall): Remove trailing newline from
2619         help.
2620         * user-regs.c (_initialize_user_regs): Remove trailing newline
2621         from help.
2622         * typeprint.c (_initialize_typeprint): Remove trailing newline
2623         from help.
2624         * reverse.c (_initialize_reverse): Remove trailing newlines from
2625         help.
2626         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2627         from help.
2628         * language.c (add_set_language_command): Remove trailing newline
2629         from help.
2630         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2631         help.
2632         * disasm.c (_initialize_disasm): Remove trailing newline from
2633         help.
2634         * top.c (init_main): Remove trailing newline from help.
2635         * interps.c (_initialize_interpreter): Remove trailing newline
2636         from help.
2637         * btrace.c (_initialize_btrace): Remove trailing newlines from
2638         help.
2639         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2640         from help.
2641         * python/python.c (_initialize_python): Remove trailing newline
2642         from help.
2643         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2644         help.
2645         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2646         from help.  Reformat some text.
2647         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2648         from help.
2649         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2650         newline from help.
2651
2652 2019-06-11  Tom Tromey  <tromey@adacore.com>
2653
2654         * darwin-nat.c (darwin_decode_exception_message)
2655         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2656
2657 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2658
2659         * valops.c (value_slice): Check for not allocated or not
2660         associated values.
2661
2662 2019-06-10  Tom de Vries  <tdevries@suse.de>
2663
2664         PR gdb/24618
2665         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2666         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2667         invalid.
2668
2669 2019-06-10  Tom de Vries  <tdevries@suse.de>
2670
2671         PR gdb/24611
2672         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2673         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2674
2675 2019-06-10  Tom de Vries  <tdevries@suse.de>
2676
2677         PR symtab/24545
2678         * symtab.c (struct demangled_name_entry): Add language field.
2679         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2680         static minimal symbol".  Set and use language field.
2681
2682 2019-06-10  Tom Tromey  <tromey@adacore.com>
2683
2684         * ada-lang.c (_initialize_ada_language): Update help text.
2685
2686 2019-06-10  Tom Tromey  <tromey@adacore.com>
2687
2688         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2689         with a newline.
2690         * guile/guile.c (handle_boot_error): Don't end warning with a
2691         newline.
2692         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2693         warning with a newline.
2694         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2695         newline.
2696         (s12z_frame_cache): Likewise.
2697         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2698         a newline.
2699         * solib-svr4.c (disable_probes_interface): Don't end warning with
2700         a newline.
2701         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2702         newline.
2703         * python/python.c (do_finish_initialization): Don't end warning
2704         with a newline.
2705
2706 2019-06-10  Tom Tromey  <tom@tromey.com>
2707
2708         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2709         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2710         gdbpy_enter.
2711
2712 2019-06-10  Tom Tromey  <tromey@adacore.com>
2713
2714         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2715         data.
2716         (elf_new_init): Don't call stabsread_new_init.
2717         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2718         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2719         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2720
2721 2019-06-10  Tom de Vries  <tdevries@suse.de>
2722
2723         PR symtab/16264
2724         PR symtab/24517
2725         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2726
2727 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2728
2729         * source.c (find_and_open_source): Also rewrite relative file
2730         names.
2731
2732 2019-04-26  Amos Bird  <amosbird@gmail.com>
2733
2734         * annotate.c (annotate_thread_exited): Add "thread-exited"
2735         annotation.
2736
2737 2019-06-06  Tom Tromey  <tromey@adacore.com>
2738
2739         * maint.h (class scoped_command_stats): Use
2740         DISABLE_COPY_AND_ASSIGN.
2741         <print_time>: New method.
2742         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2743         print_time.
2744         (scoped_command_stats::print_time): New method.
2745
2746 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2747
2748         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2749         instructions of lengths 6 or 8 bytes.
2750
2751 2019-06-04  Pedro Alves  <palves@redhat.com>
2752
2753         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2754
2755         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2756         * breakpoint.c (condition_completer): Likewise.
2757         * cli/cli-dump.c (scan_expression): Likewise.
2758         * common/filestuff.c (mkdir_recursive): Likewise.
2759         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2760         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2761         (gdb_abspath): Likewise.
2762         * compile/compile-cplus-types.c
2763         (compile_cplus_instance::decl_name): Likewise.
2764         * completer.c (complete_explicit_location):
2765         (signal_completer, reg_or_group_completer_1): Likewise.
2766         * cp-support.c (cp_remove_params_if_any): Likewise.
2767         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2768         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2769         * infcmd.c (strip_bg_char): Likewise.
2770         * linespec.c (copy_token_string): Likewise.
2771         * mi/mi-main.c (output_cores): Likewise.
2772         * psymtab.c (psymtab_search_name):
2773         * symfile.c (test_set_ext_lang_command): Likewise.
2774         * target.c (target_fileio_read_stralloc): Likewise.
2775         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2776         * value.c (complete_internalvar): Likewise.
2777
2778 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2779
2780         Add objfile property to gdb.Type.
2781         * NEWS: Mention Python API addition.
2782         * python/py-type.c (typy_get_objfile): New method.
2783
2784 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2785
2786         * NEWS: Mention the new set|show style [title|highlight].
2787         Mention changes to "show style", "help" and "apropos".
2788
2789 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2790
2791         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2792         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2793         instead of print_help_for_command.
2794         (print_doc_of_command): New function.
2795         (help_list): Add 'apropos -v word' suggestion.
2796         (print_help_for_command): Style the command name using title style.
2797         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2798         (_initialize_cli_cmds): Describe -v in apropos_command help.
2799
2800 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2801
2802         * cli/cli-style.h (cli_style_option): Add name in constructor,
2803         add m_name class member, add constructor with intensity,
2804         add name class function.
2805         (cli_style_option::add_setshow_commands): Remove name argument.
2806         (highlight_style, title_style): New styles.
2807         * cli/cli-style.c (do_show): New function that shows a style
2808         characteristic styling the style name with itself.
2809         (set_style_name): New function.
2810         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2811         Update all callers according to the changes in cli/cli-style.h.
2812         * utils.h (fputs_highlighted): New function.
2813         * utils.c (fputs_highlighted): Likewise.
2814
2815 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2816
2817         * NEWS: Mention new pipe command and new convenience variables.
2818
2819 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2820
2821         * cli/cli-cmds.c (pipe_command): New function.
2822         (_initialize_cli_cmds): Call add_com for pipe_command.
2823         Define | as an alias for pipe.
2824         (exit_status_set_internal_vars): New function.
2825         (shell_escape): Call exit_status_set_internal_vars.
2826         cli/cli-decode.c (find_command_name_length): Recognize | as
2827         a single character command.
2828
2829 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2830
2831         * gdbcmd.h (execute_command_to_ui_file): New declaration.
2832         top.c (execute_command_to_ui_file): New function, mostly a copy
2833         of execute_command_to_string.
2834         (execute_command_to_string): Implement by calling
2835         execute_command_to_ui_file.
2836
2837 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2838
2839         * top.h (saved_command_line): Remove declaration.
2840         * top.c (previous_saved_command_line, previous_repeat_arguments):
2841         New variables.
2842         (saved_command_line): Make static, define together with other
2843         'repeat variables'.
2844         (dont_repeat): Clear repeat_arguments.
2845         (repeat_previous, get_saved_command_line, save_command_line):
2846         New functions.
2847         (gdb_init): Initialize saved_command_line
2848         and previous_saved_command_line.
2849         * main.c (captured_main_1): Remove saved_command_line initialization.
2850         * event-top.c (handle_line_of_input): Update to use
2851         the new 'repeat' related functions instead of direct access to
2852         saved_command_line.
2853         * command.h (repeat_previous, get_saved_command_line,
2854         save_command_line): New declarations.
2855         (dont_repeat): Add comment.
2856
2857 2019-05-30  Tom Tromey  <tromey@adacore.com>
2858
2859         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
2860         Fix comment.
2861         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
2862
2863 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
2864
2865         PR cli/24587
2866         * completer.c (complete): Initialize variable word.
2867
2868 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
2869
2870         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2871         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
2872         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
2873         'body' is NULL to the outter 'if', protecting the '!is_define'
2874         situation as well.
2875
2876 2019-05-29  Tom Tromey  <tromey@adacore.com>
2877
2878         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
2879         (dwarf_unknown): New function.
2880         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
2881         (dwarf_type_encoding_name): Use dwarf_unknown.
2882
2883 2019-05-29  Tom Tromey  <tromey@adacore.com>
2884
2885         PR c++/20020:
2886         * cp-valprint.c (cp_print_value_fields): Call
2887         cp_print_static_field inside "try".
2888
2889 2019-05-29  Tom Tromey  <tromey@adacore.com>
2890
2891         * inflow.c (struct terminal_info): Add default operator=.
2892         * configure: Rebuild.
2893         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
2894         -Wdeprecated-copy-dtor, -Wredundant-move.
2895
2896 2019-05-29  Tom Tromey  <tromey@adacore.com>
2897
2898         * NEWS: Add entry.
2899         * infcmd.c (print_return_value_1): Handle finish_print
2900         option.
2901         (show_print_finish): New function.
2902         (_initialize_infcmd): Add "set/show print finish" commands.
2903         * valprint.c (user_print_options): Initialize new member.
2904         * valprint.h (struct value_print_options) <finish_print>: New
2905         member.
2906
2907 2019-05-28  Tom Tromey  <tromey@adacore.com>
2908
2909         * ada-lang.c (ada_remove_Xbn_suffix)
2910         (find_old_style_renaming_symbol)
2911         (parse_old_style_renaming): Remove.
2912         (ada_find_renaming_symbol): Don't call
2913         find_old_style_renaming_symbol.
2914         (ada_is_renaming_symbol): Rename from
2915         ada_find_renaming_symbol.  Remove "block" parameter.  Return
2916         bool.  Now static.
2917         (ada_read_var_value): Update and simplify.
2918         * ada-exp.y (write_var_or_type): Remove old code.
2919
2920 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
2921
2922         * event-top.c: Remove include comment.
2923         * inflow.c (class scoped_ignore_sigttou): Move from here...
2924         * inflow.h (class scoped_ignore_sigttou): ...to here.
2925         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
2926         * top.c:  Remove include comment.
2927
2928 2019-05-27  Tom Tromey  <tom@tromey.com>
2929
2930         * NEWS: Fix typo.
2931
2932 2019-05-22  Tom Tromey  <tromey@adacore.com>
2933
2934         * target.c (target_follow_exec): Constify parameter.
2935         * target-delegates.c: Rebuild.
2936         * remote.c (remote_target::follow_exec): Constify parameter.
2937         * infrun.c (follow_exec): Constify parameter.
2938         * target.h (struct target_ops) <follow_exec>: Constify parameter.
2939         (target_follow_exec): Likewise.
2940
2941 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2942
2943         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
2944         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
2945
2946 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2947
2948         * NEWS: Add debugredirect and testsuite sections.
2949
2950 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
2951
2952         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
2953         target descriptions using exclusively floating point register name
2954         aliases.
2955
2956 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2957
2958         PR gdb/18644:
2959         * f-lang.c (build_fortran_types): Handle the case where
2960         gdbarch_floatformat_for_type returns a nullptr.
2961
2962 2019-05-21  Tom de Vries  <tdevries@suse.de>
2963
2964         PR cli/24587
2965         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
2966
2967 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2968
2969         PR gdb/18644:
2970         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
2971         16-byte floats.
2972         * i386-tdep.c (i386_floatformat_for_type): Use
2973         floatformats_ia64_quad for the 16-byte floating point component
2974         within a fortran 32-byte complex number.
2975
2976 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2977
2978         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
2979         delete default constructor.
2980         (find_partial_die): Update to return const struct.
2981         (partial_die_parent_scope): Move variable declaration into scope
2982         of its use and change its type to auto.
2983         (guess_partial_die_structure_name): Likewise.
2984         (partial_die_info::fixup): Likewise.
2985
2986 2019-05-17  Tom Tromey  <tromey@adacore.com>
2987
2988         * source.c (find_and_open_source): Remove cast.
2989
2990 2019-05-17  Tom Tromey  <tromey@adacore.com>
2991
2992         * annotate.c (annotate_source): Make "filename" const.
2993         * annotate.h (annotate_source): Use const.
2994
2995 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2996
2997         * disasm.c (set_disassembler_options): Send errors to stderr.
2998
2999 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3000
3001         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3002         (cli_interp_base::set_logging): Check debug_redirect.
3003         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3004         * cli/cli-logging.c (debug_redirect): Add static variable.
3005         (pop_output_files): Add default param.
3006         (handle_redirections): Print debug setting.
3007         (show_logging_command): Likewise.
3008         (_initialize_cli_logging): Add debugredirect command.
3009         * interps.c (current_interp_set_logging): Add debug_redirect
3010         parameter.
3011         * interps.h (set_logging): Add debug_redirect parameter.
3012         (current_interp_set_logging): Likewise.
3013         * mi/mi-common.h: Likewise.
3014         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3015
3016 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3017             Tom Tromey  <tromey@adacore.com>
3018
3019         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3020         directly.
3021         * cli/cli-interp.h (make_logging_output): Remove declaration.
3022         * cli/cli-logging.c (make_logging_output): Remove function.
3023         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3024         directly.
3025         * ui-file.c (tee_file::tee_file): Remove bools.
3026         (tee_file::~tee_file): Remove deletes.
3027         * ui-file.h (tee_file): Remove bools.
3028
3029 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3030
3031         * mi/mi-cmds.h (mi_cmd_complete): New function.
3032         * mi/mi-main.c (mi_cmd_complete): Likewise.
3033         * mi/mi-cmds.c: Define new MI command -complete.
3034         * NEWS: Mention new -complete command.
3035
3036 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3037
3038         * completer.h (complete): New function.
3039         * completer.c (complete): Likewise.
3040         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3041         function defined in completer.h.
3042
3043 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3044
3045         * MAINTAINERS (Write After Approval): Add myself.
3046
3047 2019-05-17  Tom de Vries  <tdevries@suse.de>
3048
3049         PR gdb/24094
3050         * dwarf2read.c (struct cu_partial_die_info): New struct.
3051         (find_partial_die): Return cu_partial_die_info.
3052         (partial_die_parent_scope, guess_partial_die_structure_name)
3053         (partial_die_info::fixup): Handle new return type of find_partial_die.
3054
3055 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3056
3057         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3058         "std::string", simplifying the algorithm.
3059
3060 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3061
3062         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3063         (stap_static_probe_ops::get_probes): Likewise.
3064
3065 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3066
3067         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3068         '-')" and "else if".
3069         (stap_parse_single_operand): Join checks for
3070         "gdbarch_stap_parse_special_token_p" and
3071         "gdbarch_stap_parse_special_token" in the same "if" statement.
3072         Invert check when verifying for operation on register
3073         displacement.
3074
3075 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3076
3077         * stap-probe.c (stap_get_opcode): Update comment.
3078         (stap_get_expected_argument_type): Likewise.
3079         (handle_stap_probe): Likewise.
3080
3081 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3082
3083         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3084         return type to 'bool'.  Adjust comment.  Use 'bool' when
3085         appropriate.
3086         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3087         * stap-probe.c (stap_parse_argument_1): Likewise.
3088         (stap_is_operator): Likewise.
3089         (stap_is_generic_prefix): Likewise.
3090         (stap_is_register_prefix): Likewise.
3091         (stap_is_register_indirection_prefix): Likewise.
3092         (stap_is_integer_prefix): Likewise.
3093         (stap_generic_check_suffix): Likewise.
3094         (stap_check_integer_suffix): Likewise.
3095         (stap_check_register_suffix): Likewise.
3096         (stap_check_register_indirection_suffix): Likewise.
3097         (stap_parse_register_operand): Likewise.
3098         (stap_parse_single_operand): Likewise.
3099         (stap_parse_argument_1): Likewise.
3100         (stap_probe::get_argument_count): Likewise.
3101         (stap_is_operator): Likewise.
3102
3103 2019-05-16  Tom Tromey  <tromey@adacore.com>
3104
3105         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3106         keyword to foreach.
3107
3108 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3109
3110         * linux-thread-db.c (try_thread_db_load_1): Change return type
3111         to bool.
3112         (try_thread_db_load): Likewise.
3113         (try_thread_db_load_from_pdir_1): Likewise.
3114         (try_thread_db_load_from_pdir): Likewise.
3115         (try_thread_db_load_from_sdir): Likewise.
3116         (try_thread_db_load_from_dir): Likewise.
3117         (thread_db_load_search): Likewise.
3118         (has_libpthread): Likewise.
3119         (thread_db_load): Likewise.
3120
3121 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3122
3123         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3124         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3125         NULL, and complain/return if that's the case.
3126
3127 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3128
3129         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3130         (advance, posn, abstract_read_memory): New functions.
3131         [struct mem_read_abstraction]: New struct.
3132         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3133
3134 2019-05-14  Tom Tromey  <tromey@adacore.com>
3135
3136         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3137         value is not lval_memory.
3138
3139 2019-05-14  Tom Tromey  <tromey@adacore.com>
3140
3141         * solib.c (info_sharedlibrary_command): Style the file name.
3142
3143 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3144
3145         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3146         (aarch64_vnv_type): Likewise.
3147         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3148         * common/tdesc.c: Likewise.
3149         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3150         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3151         * features/aarch64-fpu.xml: Add ieee half view.
3152         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3153         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3154         * gdbtypes.h (struct builtin_type): Likewise.
3155         (struct objfile_type): Likewise.
3156
3157 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3158
3159         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3160         typo.
3161         * location.h (string_to_event_location): Likewise.
3162
3163 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3164
3165         GDB 8.3 released.
3166
3167 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3168
3169         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3170         New variable declaration.
3171         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3172         New variable.
3173         (print_one_breakpoint): Use ui_out::test_flags and new global
3174         variable to compute use_fixed_output.
3175         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3176         Remove.
3177         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3178         (mi_multi_location_breakpoint_output_fixed): Remove.
3179         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3180         new variable.
3181         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3182         fix_multi_location_breakpoint_output flag if version >= 3.
3183         * ui-out.h (enum ui_out_flag)
3184         <fix_multi_location_breakpoint_output>: New enumerator.
3185
3186 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3187
3188         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3189
3190 2019-05-10  Tom Tromey  <tromey@adacore.com>
3191
3192         * ada-lang.c (catch_ada_completer): New function.
3193         (_initialize_ada_language): Use it.
3194
3195 2019-05-10  Tom Tromey  <tromey@adacore.com>
3196
3197         * thread.c (print_thread_info): Make "requested_threads" const.
3198         * gdbthread.h (print_thread_info): Make "requested_threads"
3199         const.
3200         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3201         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3202
3203 2019-05-08  Tom Tromey  <tom@tromey.com>
3204
3205         * gdbtypes.c (objfile_type_data): Change type.
3206         (objfile_type, _initialize_gdbtypes): Update.
3207
3208 2019-05-08  Tom Tromey  <tom@tromey.com>
3209
3210         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3211         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3212         (_initialize_dwarf2_frame): Update.
3213
3214 2019-05-08  Tom Tromey  <tom@tromey.com>
3215
3216         * objc-lang.c (objc_objfile_data): Change type.
3217         (find_methods): Update.
3218         (_initialize_objc_lang): Remove.
3219
3220 2019-05-08  Tom Tromey  <tom@tromey.com>
3221
3222         * stabsread.c (rs6000_builtin_type_data): Change type.
3223         (rs6000_builtin_type, _initialize_stabsread): Update.
3224
3225 2019-05-08  Tom Tromey  <tom@tromey.com>
3226
3227         * mips-tdep.c (mips_pdr_data): Remove.
3228         (_initialize_mips_tdep): Update.
3229
3230 2019-05-08  Tom Tromey  <tom@tromey.com>
3231
3232         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3233         (hppa_init_objfile_priv_data, read_unwind_info)
3234         (find_unwind_entry, _initialize_hppa_tdep): Update.
3235
3236 2019-05-08  Tom Tromey  <tom@tromey.com>
3237
3238         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3239         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3240         on obstack.
3241         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3242
3243 2019-05-08  Tom Tromey  <tom@tromey.com>
3244
3245         * mdebugread.c (basic_type_data): Change type.
3246         (basic_type, _initialize_mdebugread): Update.
3247
3248 2019-05-08  Tom Tromey  <tom@tromey.com>
3249
3250         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3251
3252 2019-05-08  Tom Tromey  <tom@tromey.com>
3253
3254         * nto-tdep.c (nto_inferior_data_reg): Change type.
3255         (nto_inferior_data): Update.
3256         (nto_inferior_data_cleanup, nto_new_inferior_data)
3257         (_initialize_nto_tdep): Remove.
3258         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3259
3260 2019-05-08  Tom Tromey  <tom@tromey.com>
3261
3262         * ada-lang.c (struct ada_inferior_data): Add initializers.
3263         (ada_inferior_data): Change type.
3264         (ada_inferior_data_cleanup): Remove.
3265         (get_ada_inferior_data, ada_inferior_exit)
3266         (struct ada_pspace_data): Add initializers, destructor.
3267         (ada_pspace_data_handle): Change type.
3268         (get_ada_pspace_data): Update.
3269         (ada_pspace_data_cleanup): Remove.
3270
3271 2019-05-08  Tom Tromey  <tom@tromey.com>
3272
3273         * coffread.c (struct coff_symfile_info): Add initializers.
3274         (coff_objfile_data_key): Move lower.  Change type.
3275         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3276         Update.
3277         (coff_free_info): Remove.
3278
3279 2019-05-08  Tom Tromey  <tom@tromey.com>
3280
3281         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3282         (fbsd_pspace_data_handle): Move lower.  Change type.
3283         (get_fbsd_pspace_data): Update.
3284         (fbsd_pspace_data_cleanup): Remove.
3285         (_initialize_fbsd_tdep): Update.
3286
3287 2019-05-08  Tom Tromey  <tom@tromey.com>
3288
3289         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3290         (get_ada_tasks_pspace_data): Update.
3291         (ada_tasks_pspace_data_cleanup): Remove.
3292         (_initialize_tasks): Update.
3293         (ada_tasks_inferior_data_handle): Change type.
3294         (get_ada_tasks_inferior_data): Update.
3295         (ada_tasks_inferior_data_cleanup): Remove.
3296         (struct ada_tasks_pspace_data): Add initializers.
3297
3298 2019-05-08  Tom Tromey  <tom@tromey.com>
3299
3300         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3301         * symfile-debug.c (debug_sym_get_probes): Change type.
3302         * stap-probe.c (handle_stap_probe):
3303         (stap_static_probe_ops::get_probes): Change type.
3304         * probe.h (class static_probe_ops) <get_probes>: Change type.
3305         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3306         (parse_probes_in_pspace): Update.
3307         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3308         Update.
3309         (any_static_probe_ops::get_probes): Change type.
3310         * elfread.c (elfread_data): New typedef.
3311         (probe_key): Change type.
3312         (elf_get_probes): Likewise.  Update.
3313         (probe_key_free): Remove.
3314         (_initialize_elfread): Update.
3315         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3316         Change type.
3317         (dtrace_process_dof_probe, dtrace_process_dof)
3318         (dtrace_static_probe_ops::get_probe): Change type.
3319
3320 2019-05-08  Tom Tromey  <tom@tromey.com>
3321
3322         * xcoffread.c (struct xcoff_symfile_info): Rename from
3323         coff_symfile_info.  Add initializers.
3324         (xcoff_objfile_data_key): Move lower.  Change type.
3325         (XCOFF_DATA): Rewrite.
3326         (xcoff_free_info): Remove.
3327         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3328         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3329         (xcoff_initial_scan): Update.
3330
3331 2019-05-08  Tom Tromey  <tom@tromey.com>
3332
3333         * solib-svr4.c (struct svr4_info): Add initializers and
3334         destructor.
3335         <probes_table>: Now an htab_up.
3336         (solib_svr4_pspace_data): Change type.
3337         (free_probes_table): Simplify.
3338         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3339         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3340         (probes_table_remove_objfile_probes, register_solib_event_probe)
3341         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3342         (_initialize_svr4_solib): Update.
3343
3344 2019-05-08  Tom Tromey  <tom@tromey.com>
3345
3346         * remote.c (remote_pspace_data): Change type.
3347         (remote_pspace_data_cleanup): Remove.
3348         (get_remote_exec_file, set_pspace_remote_exec_file)
3349         (_initialize_remote): Update.
3350
3351 2019-05-08  Tom Tromey  <tom@tromey.com>
3352
3353         * breakpoint.c (breakpoint_objfile_key): Change type.
3354         (get_breakpoint_objfile_data): Update.
3355         (free_breakpoint_objfile_data): Remove.
3356         (_initialize_breakpoint): Update.
3357
3358 2019-05-08  Tom Tromey  <tom@tromey.com>
3359
3360         * linux-tdep.c (struct linux_info): Add initializers.
3361         (linux_inferior_data): Move.  Change type.
3362         (invalidate_linux_cache_inf): Update.
3363         (linux_inferior_data_cleanup): Remove.
3364         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3365
3366 2019-05-08  Tom Tromey  <tom@tromey.com>
3367
3368         * auxv.c (auxv_inferior_data): Move.  Change type.
3369         (auxv_inferior_data_cleanup): Remove.
3370         (invalidate_auxv_cache_inf): Rewrite.
3371         (get_auxv_inferior_data, _initialize_auxv): Update.
3372
3373 2019-05-08  Tom Tromey  <tom@tromey.com>
3374
3375         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3376         (symfile_debug_objfile_data_key): Change type.
3377         (symfile_debug_installed, debug_qf_has_symbols)
3378         (debug_qf_find_last_source_symtab)
3379         (debug_qf_forget_cached_source_info)
3380         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3381         (debug_qf_print_stats, debug_qf_dump)
3382         (debug_qf_expand_symtabs_for_function)
3383         (debug_qf_expand_all_symtabs)
3384         (debug_qf_expand_symtabs_with_fullname)
3385         (debug_qf_map_matching_symbols)
3386         (debug_qf_expand_symtabs_matching)
3387         (debug_qf_find_pc_sect_compunit_symtab)
3388         (debug_qf_map_symbol_filenames)
3389         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3390         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3391         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3392         (debug_sym_read_linetable, debug_sym_relocate): Update.
3393         (symfile_debug_free_objfile): Remove.
3394         (install_symfile_debug_logging, _initialize_symfile_debug):
3395         Update.
3396
3397 2019-05-08  Tom Tromey  <tom@tromey.com>
3398
3399         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3400         allocate_on_obstack.
3401         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3402         (get_dwarf2_per_objfile): Update.
3403         (set_dwarf2_per_objfile): Remove.
3404         (dwarf2_has_info, dwarf2_get_section_info): Update.
3405         (dwarf2_free_objfile): Remove.
3406         (_initialize_dwarf2_read): Update.
3407
3408 2019-05-08  Tom Tromey  <tom@tromey.com>
3409
3410         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3411         initializers.
3412         <unsupported_script_warning_printed,
3413         script_not_found_warning_printed>: Now bool.
3414         (auto_load_pspace_data): Change type.
3415         (~auto_load_pspace_info): Rename from
3416         auto_load_pspace_data_cleanup.
3417         (get_auto_load_pspace_data, init_loaded_scripts_info)
3418         (clear_section_scripts, maybe_print_unsupported_script_warning)
3419         (maybe_print_script_not_found_warning, _initialize_auto_load):
3420         Update.
3421
3422 2019-05-08  Tom Tromey  <tom@tromey.com>
3423
3424         * objfiles.c (objfile_pspace_info): Add destructor and
3425         initializers.
3426         (objfiles_pspace_data): Change type.
3427         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3428         (get_objfile_pspace_data): Update.
3429         (objfiles_bfd_data): Change type.
3430         (get_objfile_bfd_data): Update.
3431         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3432
3433 2019-05-08  Tom Tromey  <tom@tromey.com>
3434
3435         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3436         Change type.
3437         (get_catch_syscall_inferior_data): Update.
3438         (catch_syscall_inferior_data_cleanup): Remove.
3439         (_initialize_break_catch_syscall): Update.
3440
3441 2019-05-08  Tom Tromey  <tom@tromey.com>
3442
3443         * inflow.c (struct terminal_info): Add destructor and
3444         initializers.
3445         (inflow_inferior_data): Change type.
3446         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3447         (get_inflow_inferior_data, inflow_inferior_exit)
3448         (swap_terminal_info, _initialize_inflow): Update.
3449
3450 2019-05-08  Tom Tromey  <tom@tromey.com>
3451
3452         * target-dcache.c (target_dcache_cleanup): Remove.
3453         (target_dcache_aspace_key): Change type.
3454         (target_dcache_init_p, target_dcache_invalidate)
3455         (target_dcache_get, target_dcache_get_or_init)
3456         (_initialize_target_dcache): Update.
3457         * dcache.h (struct dcache_deleter): New.
3458
3459 2019-05-08  Tom Tromey  <tom@tromey.com>
3460
3461         * symtab.c (struct symbol_cache): Add destructor and
3462         initializers.
3463         (symbol_cache_key): Move.  Change type.
3464         (make_symbol_cache, free_symbol_cache): Remove.
3465         (get_symbol_cache): Update.
3466         (symbol_cache_cleanup): Remove.
3467         (ALL_PSPACES, symbol_cache_flush)
3468         (maintenance_print_symbol_cache)
3469         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3470         Update.
3471
3472 2019-05-08  Tom Tromey  <tom@tromey.com>
3473
3474         * symtab.c (struct main_info): Add destructor and initializers.
3475         (main_progspace_key): Move.  Change type.
3476         (get_main_info): Update.
3477         (main_info_cleanup): Remove.
3478         (_initialize_symtab): Update.
3479
3480 2019-05-08  Tom Tromey  <tom@tromey.com>
3481
3482         * registry.h (DECLARE_REGISTRY): Define the _key class.
3483
3484 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3485
3486         * NEWS: Merge two 'New commands' sections.
3487
3488 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3489
3490         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3491         parameter and use Ada language definition instead.
3492         (ada_val_print_ptr): Remove unused language parameter.
3493         (ada_val_print_num): Remove language parameter and use Ada language
3494         definition instead.
3495         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3496         parameter.
3497         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3498         parameter and use Ada language definition instead.
3499         (ada_val_print_1): Update all ada_val_print_xxx calls.
3500         Remove language parameter.
3501         (ada_val_print): Update ada_val_print_1 call.
3502
3503 2019-05-08  Tom Tromey  <tromey@adacore.com>
3504
3505         * remote.c (remote_hw_watchpoint_limit)
3506         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3507         Now static.
3508
3509 2019-05-08  Tom Tromey  <tromey@adacore.com>
3510
3511         * maint.c (_initialize_maint_cmds): Move initialization code to
3512         remote.c.
3513         (watchdog, show_watchdog): Move to remote.c.
3514         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3515         "watchdog" static.
3516         (_initialize_remote): Move initialization code from maint.c.
3517         * defs.h (watchdog): Don't declare.
3518
3519 2019-05-08  Tom Tromey  <tromey@adacore.com>
3520
3521         * tui/tui-interp.c: Include main.h.
3522         * interps.c: Include main.h.
3523         * main.h (interpreter_p): Declare.
3524         * defs.h (interpreter_p): Don't declare.
3525
3526 2019-05-08  Tom Tromey  <tromey@adacore.com>
3527
3528         * dwarf2loc.c: Include dwarf2read.h.
3529         * defs.h (read_unsigned_leb128): Don't declare.
3530         * dwarf2read.h (read_unsigned_leb128): Declare.
3531
3532 2019-05-08  Tom Tromey  <tromey@adacore.com>
3533
3534         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3535         method.
3536
3537 2019-05-08  Tom Tromey  <tromey@adacore.com>
3538
3539         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3540         when no wrap column is set.
3541
3542 2019-05-08  Tom Tromey  <tromey@adacore.com>
3543
3544         * c-lang.c (c_get_string): Handle non-C-style arrays.
3545
3546 2019-05-08  Tom Tromey  <tromey@adacore.com>
3547
3548         * typeprint.c (print_offset_data::update): Print the bit offset,
3549         not the number of bits remaining.
3550
3551 2019-05-08  Tom Tromey  <tromey@adacore.com>
3552
3553         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3554         padding at end of comment.
3555
3556 2019-05-08  Tom Tromey  <tromey@adacore.com>
3557
3558         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3559         Compare main types.
3560
3561 2019-05-06  Tom Tromey  <tom@tromey.com>
3562
3563         * common/scoped_mmap.c: Include common-defs.h.
3564         * common/scoped_mmap.h: Don't include config.h.
3565
3566 2019-05-04  Tom Tromey  <tom@tromey.com>
3567
3568         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3569         (struct aarch64_call_info): Add initializers.
3570         <si>: Now a std::vector.
3571         (pass_on_stack, aarch64_push_dummy_call): Update.
3572
3573 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3574             Tom Tromey  <tom@tromey.com>
3575
3576         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3577         (ppc_threads): Now a std::vector.  Now static.
3578         (hwdebug_find_thread_points_by_tid)
3579         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3580         Update.
3581
3582 2019-05-04  Tom Tromey  <tom@tromey.com>
3583
3584         * arc-tdep.c (arc_tdesc_init): Return bool.
3585
3586 2019-05-04  Tom Tromey  <tom@tromey.com>
3587
3588         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3589         Use gdb_assert_not_reached.
3590
3591 2019-05-04  Tom Tromey  <tom@tromey.com>
3592
3593         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3594         "false".
3595
3596 2019-05-04  Tom Tromey  <tom@tromey.com>
3597
3598         * arc-tdep.c (arc_tdesc_init): Use bool.
3599
3600 2019-05-04  Tom Tromey  <tom@tromey.com>
3601
3602         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3603
3604 2019-05-04  Tom Tromey  <tom@tromey.com>
3605
3606         * cli/cli-cmds.c (valid_command_p): Return bool.
3607
3608 2019-05-04  Tom Tromey  <tom@tromey.com>
3609
3610         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3611         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3612
3613 2019-05-04  Raul Tambre  <raul@tambre.ee>
3614
3615         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3616         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3617         operator for comparison.
3618
3619 2019-05-04  Tom Tromey  <tom@tromey.com>
3620
3621         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3622         (lookup_partial_symbol, print_partial_symbols)
3623         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3624         (psymbol_compare): Update.
3625         (add_psymbol_to_bcache): Clear the entire psymbol.
3626         (maintenance_check_psymtabs): Update.
3627         * psympriv.h (struct partial_symbol): Don't derive from
3628         general_symbol_info.
3629         <obj_section, unrelocated_address, address,
3630         set_unrelocated_address>: Update.
3631         <ginfo>: New member.
3632         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3633         (debug_names::write_psymbols): Update.
3634
3635 2019-05-04  Tom de Vries  <tdevries@suse.de>
3636
3637         * contrib/cc-with-tweaks.sh: Support -n arg.
3638
3639 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3640
3641         * corelow.c (core_target::detach): Ensure frame cache and
3642         register caches are cleared.
3643         inferior.c (exit_inferior_1): Likewise.
3644
3645 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3646             Tom Tromey  <tom@tromey.com>
3647
3648         * dictionary.c (collate_pending_symbols_by_language): Remove
3649         "struct" from foreach.
3650         * symtab.c (lookup_global_symbol_from_objfile)
3651         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3652         foreach.
3653         * ser-tcp.c (net_open): Remove "struct" from foreach.
3654         * objfiles.c (objfile_relocate, objfile_rebase)
3655         (objfile_has_symbols): Remove "struct" from foreach.
3656         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3657         from foreach.
3658         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3659         foreach.
3660         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3661         "struct" from foreach.
3662         * ada-lang.c (create_excep_cond_exprs)
3663         (ada_exception_catchpoint_cond_string): Remove "struct" from
3664         foreach.
3665
3666 2019-05-03  Tom Tromey  <tromey@adacore.com>
3667
3668         * ada-exp.y (convert_char_literal): Check suffix of each
3669         enumerator.
3670
3671 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3672
3673         PR ada/21406:
3674         * ada-exp.y (yywrap): Don't define.
3675         * ada-lex.l (%option): Add noyywrap
3676         (yywrap): Remove.
3677
3678 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3679
3680         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3681         _WIN32_WINNT to the XP level, unless already defined to a higher
3682         level.
3683
3684         * unittests/parse-connection-spec-selftests.c:
3685         * ser-tcp.c:
3686         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3687         override.
3688
3689         * symfile.c (find_separate_debug_file): Remove colon from the
3690         drive spec of DOS/Windows file names of the target, so that the
3691         file name produced from DEBUGDIR and the target's directory will
3692         be valid on DOS/Windows systems.
3693
3694 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3695
3696         * rust-lang.c (val_print_struct): Handle printing structures
3697         containing strings.
3698
3699 2019-05-02  Tom Tromey  <tromey@adacore.com>
3700
3701         * valarith.c (_initialize_valarith): Remove.
3702
3703 2019-05-01  Tom Tromey  <tromey@adacore.com>
3704
3705         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3706         bitfields.
3707
3708 2019-05-01  Tom Tromey  <tromey@adacore.com>
3709
3710         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3711         for big-endian copies.
3712
3713 2019-04-30  Ali Tamur  <tamur@google.com>
3714         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3715         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3716         (read_3_bytes): New function.
3717
3718 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3719
3720         * windows-nat.c (main_thread_id): Delete.
3721         (handle_output_debug_string): Replace main_thread_id by
3722         current_event.dwThreadId.
3723         (fake_create_process): Likewise.
3724         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3725         Do not set main_thread_id.
3726         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3727         current_event.dwThreadId.
3728         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3729
3730 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3731
3732         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3733         Use current_event.dwThreadId instead of main_thread_id.
3734
3735 2019-04-30  Tom Tromey  <tromey@adacore.com>
3736
3737         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3738         (create_excep_cond_exprs): Iterate over program spaces.
3739         (ada_exception_catchpoint_cond_string): Examine all minimal
3740         symbols for exception types.
3741
3742 2019-04-30  Tom Tromey  <tromey@adacore.com>
3743
3744         PR c++/24470:
3745         * dwarf2read.c (process_structure_scope): Handle case where type
3746         has template parameters but no symbol was created.
3747
3748 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3749             Chris January  <chris.january@arm.com>
3750
3751         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3752         qualifier.
3753         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3754
3755 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3756
3757         * f-typeprint.c (f_print_type): Update rules for printing
3758         whitespace.
3759         (f_type_print_varspec_suffix): Likewise.
3760
3761 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3762             Chris January  <chris.january@arm.com>
3763
3764         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3765         function arguments.
3766
3767 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3768
3769         * f-lang.c (build_fortran_types): Change name of void type to
3770         lower case.
3771         * f-typeprint.c (f_type_print_base): Print the name of the void
3772         type, rather than a fixed string.
3773         * f-valprint.c (f_decorations): Use lower case void string.
3774
3775 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3776             Chris January  <chris.january@arm.com>
3777
3778         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3779         types for Fortran.
3780
3781 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3782             Chris January  <chris.january@arm.com>
3783             David Lecomber  <david.lecomber@arm.com>
3784
3785         * f-exp.y (BINOP_INTRINSIC): New token.
3786         (exp): New parser rule handling BINOP_INTRINSIC.
3787         (f77_keywords): Add new builtin procedures.
3788         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3789         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3790         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3791         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3792         (print_unop_subexp_f): New function.
3793         (print_binop_subexp_f): New function.
3794         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3795         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3796         (dump_subexp_body_f): Likewise.
3797         (operator_check_f): Likewise.
3798         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3799         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3800
3801 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3802
3803         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3804         UNOP_KIND.
3805         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3806         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3807         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3808         (operator_length_f): New fuction.
3809         (print_subexp_f): New function.
3810         (op_name_f): New function.
3811         (dump_subexp_body_f): New function.
3812         (operator_check_f): New function.
3813         (exp_descriptor_f): Replace standard expression handling functions
3814         with new functions.
3815         * gdb/fortran-operator.def: New file.
3816         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3817         * gdb/std-operator.def: Remove UNOP_KIND.
3818
3819 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3820
3821         * std-operator.def: Remove unbalanced, stray double quote
3822         character.
3823
3824 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3825             Chris January  <chris.january@arm.com>
3826             Daniel Everett  <daniel.everett@arm.com>
3827             Nick Forrington  <nick.forrington@arm.com>
3828             Richard Bunt  <richard.bunt@arm.com>
3829
3830         * cp-valprint.c (cp_print_value_fields): Allow an additional level
3831         of depth when printing anonymous structs or unions.
3832         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3833         Don't print either the top-level value, or the children if the
3834         max-depth is exceeded.
3835         (ppscm_print_children): When printing the key of a map, allow one
3836         extra level of depth.
3837         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3838         print either the top-level value, or the children if the max-depth
3839         is exceeded.
3840         (print_children): When printing the key of a map, allow one extra
3841         level of depth.
3842         * python/py-value.c (valpy_format_string): Add max_depth keyword.
3843         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
3844         (user_print_options): Initialise max_depth field.
3845         (val_print_scalar_or_string_type_p): New function.
3846         (val_print): Check to see if the max depth has been reached.
3847         (val_print_check_max_depth): Define new function.
3848         (show_print_max_depth): New function.
3849         (_initialize_valprint): Add 'print max-depth' option.
3850         * valprint.h (struct value_print_options) <max_depth>: New field.
3851         (val_print_check_max_depth): Declare new function.
3852         * NEWS: Document new feature.
3853
3854 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3855
3856         * ada-lang.c (ada_language_defn): Initialise new field.
3857         * c-lang.c (c_is_string_type_p): New function.
3858         (c_language_defn): Initialise new field.
3859         (cplus_language_defn): Initialise new field.
3860         (asm_language_defn): Initialise new field.
3861         (minimal_language_defn): Initialise new field.
3862         * c-lang.h (c_is_string_type_p): Declare new function.
3863         * d-lang.c (d_language_defn): Initialise new field.
3864         * f-lang.c (f_is_string_type_p): New function.
3865         (f_language_defn): Initialise new field.
3866         * go-lang.c (go_is_string_type_p): New function.
3867         (go_language_defn): Initialise new field.
3868         * language.c (default_is_string_type_p): New function.
3869         (unknown_language_defn): Initialise new field.
3870         (auto_language_defn): Initialise new field.
3871         * language.h (struct language_defn) <la_is_string_type_p>: New
3872         member variable.
3873         (default_is_string_type_p): Declare new function.
3874         * m2-lang.c (m2_language_defn): Initialise new field.
3875         * objc-lang.c (objc_language_defn): Initialise new field.
3876         * opencl-lang.c (opencl_language_defn): Initialise new field.
3877         * p-lang.c (pascal_is_string_type_p): New function.
3878         (pascal_language_defn): Initialise new field.
3879         * rust-lang.c (rust_is_string_type_p): New function.
3880         (rust_language_defn): Initialise new field.
3881
3882 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3883
3884         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
3885         New field.
3886         * ada-lang.c (ada_language_defn): Initialise new field.
3887         * c-lang.c (c_language_defn): Likewise.
3888         (cplus_language_defn): Likewise.
3889         (asm_language_defn): Likewise.
3890         (minimal_language_defn): Likewise.
3891         * d-lang.c (d_language_defn): Likewise.
3892         * f-lang.c (f_language_defn): Likewise.
3893         * go-lang.c (go_language_defn): Likewise.
3894         * language.c (unknown_language_defn): Likewise.
3895         (auto_language_defn): Likewise.
3896         * m2-lang.c (m2_language_defn): Likewise.
3897         * objc-lang.c (objc_language_defn): Likewise.
3898         * opencl-lang.c (opencl_language_defn): Likewise.
3899         * p-lang.c (pascal_language_defn): Likewise.
3900         * rust-lang.c (rust_language_defn): Likewise.
3901
3902 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3903
3904         * ada-lang.c (ada_is_character_type): Change return type to bool.
3905         (ada_is_string_type): Likewise.
3906         * ada-lang.h (ada_is_character_type): Update declaration
3907         (ada_is_string_type): Likewise.
3908
3909 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3910
3911         Support style in 'frame|thread apply'
3912
3913         * gdbcmd.h (execute_command_to_string): New term_out parameter.
3914         * record.c (record_start, record_stop): Update callers of
3915         execute_command_to_string with false.
3916         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
3917         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
3918         methods.
3919         (class string_file): New constructor with term_out parameter.
3920         Override methods term_out and can_emit_style_escape.  New member
3921         term_out.
3922         (class stdio_file): Override can_emit_style_escape.
3923         (class tee_file): Override term_out and can_emit_style_escape.
3924         * utils.h (can_emit_style_escape): Remove.
3925         * utils.c (can_emit_style_escape): Likewise.
3926         Update all callers of can_emit_style_escape (SOMESTREAM) to
3927         SOMESTREAM->can_emit_style_escape.
3928         * source-cache.c (source_cache::get_source_lines): Likewise.
3929         * stack.c (frame_apply_command_count): Call execute_command_to_string
3930         passing the term_out characteristic of the current gdb_stdout.
3931         * thread.c (thr_try_catch_cmd): Likewise.
3932         * top.c (execute_command_to_string): pass term_out parameter
3933         to construct the string_file for the command output.
3934         * ui-file.c (term_cli_styling): New function (most code moved
3935         from utils.c can_emit_style_escape).
3936         (string_file::string_file, string_file::can_emit_style_escape,
3937         stdio_file::can_emit_style_escape, tee_file::term_out,
3938         tee_file::can_emit_style_escape): New functions.
3939
3940 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3941
3942         * NEWS: Mention the new set|show may-call-functions.
3943         * infcall.c (may_call_functions_p): New variable.
3944         (show_may_call_functions_p): New function.
3945         (call_function_by_hand_dummy): Throws an error if not
3946         may-call-functions.
3947         (_initialize_infcall): Call add_setshow_boolean_cmd for
3948         may-call-functions.
3949
3950 2019-04-25  Keith Seitz  <keiths@redhat.com>
3951
3952         PR c++/24367
3953         * cp-support.c (inspect_type): Don't attempt substitutions
3954         of symbol with the same name.
3955
3956 2019-04-25  Tom Tromey  <tromey@adacore.com>
3957
3958         PR gdb/24475:
3959         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
3960         static.
3961
3962 2019-04-25  Tom Tromey  <tromey@adacore.com>
3963
3964         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
3965         rvalue reference.
3966         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
3967         (gdb_xml_parser::parse): Use std::move.
3968         * python/python-internal.h (gdbpy_convert_exception): Take a const
3969         reference.
3970         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
3971         std::move.
3972         * python/py-utils.c (gdbpy_convert_exception): Take a const
3973         reference.
3974         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3975         Use std::move.
3976         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3977         Use std::move.
3978         * mi/mi-main.c (mi_print_exception): Take a const reference.
3979         * main.c (handle_command_errors): Take a const reference.
3980         * linespec.c (parse_linespec): Use std::move.
3981         * infcall.c (run_inferior_call): Use std::move.
3982         (call_function_by_hand_dummy): Use std::move.
3983         * exec.c (try_open_exec_file): Use std::move.
3984         * exceptions.h (exception_print, exception_fprintf)
3985         (exception_print_same): Update.
3986         * exceptions.c (print_exception, exception_print)
3987         (exception_fprintf, exception_print_same): Change parameters to
3988         const reference.
3989         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
3990         * common/new-op.c: Use std::move.
3991         * common/common-exceptions.h (struct gdb_exception): Add move
3992         constructor.
3993         (struct gdb_exception_error, struct gdb_exception_quit, struct
3994         gdb_quit_bad_alloc): Change constructor to move constructor.
3995         (throw_exception): Change parameter to rvalue reference.
3996         * common/common-exceptions.c (throw_exception): Take rvalue
3997         reference.
3998         * cli/cli-interp.c (safe_execute_command): Use std::move.
3999         * breakpoint.c (insert_bp_location, location_to_sals): Use
4000         std::move.
4001
4002 2019-04-25  Tom Tromey  <tromey@adacore.com>
4003
4004         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4005         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4006         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4007         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4008         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4009         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4010         guile/scm-value.c: Use unpack.
4011         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4012         gdbscm_gdb_exception.
4013         (gdbscm_throw_gdb_exception): Likewise.
4014         (struct gdbscm_gdb_exception): New.
4015         (unpack): New function.
4016         (gdbscm_wrap): Use unpack.
4017
4018 2019-04-25  Tom Tromey  <tromey@adacore.com>
4019
4020         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4021         (gdb_rl_callback_handler): Use std::move.
4022         * common/common-exceptions.h (struct gdb_exception): Add move
4023         assignment operator.
4024         (throw_exception_sjlj): Change "exception" to const reference.
4025         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4026         (throw_exception_sjlj): Change "exception" to const reference.
4027
4028 2019-04-25  Tom Tromey  <tromey@adacore.com>
4029
4030         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4031         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4032         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4033         Update.
4034         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4035         Update.
4036         * mi/mi-interp.c (mi_interp::exec): Update.
4037         * linespec.c (parse_linespec): Update.
4038         * infcall.c (run_inferior_call): Update.
4039         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4040         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4041         (gdbscm_lookup_global_symbol): Update.
4042         * guile/scm-param.c (gdbscm_parameter_value): Update.
4043         * guile/scm-frame.c (gdbscm_frame_read_register)
4044         (gdbscm_frame_read_var): Update.
4045         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4046         * exec.c (try_open_exec_file): Update.
4047         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4048         (gdb_rl_callback_handler): Update.
4049         * common/common-exceptions.h (exception_none): Don't declare.
4050         * common/common-exceptions.c (exception_none): Don't define.
4051         (struct catcher) <exception>: Update.
4052         * cli/cli-interp.c (safe_execute_command): Update.
4053         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4054
4055 2019-04-25  Ali Tamur  <tamur@google.com>
4056
4057         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4058         (read_attribute_value): Likewise.
4059         (dwarf2_read_addr_index): Update comment.
4060         (read_str_index): Add DW_FORM_strx.
4061         (dwarf2_string_attr): Likewise.
4062         (dwarf2_const_value_attr): Likewise.
4063         (dump_die_shallow): Likewise.
4064         (dwarf2_fetch_constant_bytes): Likewise.
4065         (skip_form_bytes): Likewise.
4066         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4067
4068 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4069
4070         PR corefiles/11608
4071         PR corefiles/18187
4072         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4073         OFFSET.  Verify if current mapping contains an ELF header.
4074         (linux_find_memory_regions_full): Adjust call to
4075         dump_mapping_p.
4076
4077 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4078             Kang Li <kanglictf@gmail.com>
4079
4080         PR gdb/21600
4081
4082         * dwarf2-frame.c (read_initial_length): Be consistent about using
4083         unsigned representation of length.
4084         (decode_frame_entry_1): Likewise.  Check for wraparound of
4085         end pointer as well as buffer overflow.
4086
4087 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4088
4089         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4090         "vq".
4091
4092 2019-04-24  Tom Tromey  <tromey@adacore.com>
4093
4094         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4095
4096 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4097
4098         * s12z-tdep.c (s12z_unwind_pc): Delete.
4099         (s12z_unwind_sp): Delete.
4100         (s12z_gdbarch_init): Don't register deleted functions with
4101         gdbarch.
4102
4103 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4104
4105         * rl78-tdep.c (rl78_unwind_sp): Delete.
4106         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4107
4108 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4109
4110         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4111         (xstormy16_unwind_pc): Delete.
4112         (xstormy16_dummy_id): Delete.
4113         (xstormy16_gdbarch_init): Don't register deleted functions with
4114         gdbarch.
4115
4116 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4117
4118         * vax-tdep.c (vax_unwind_pc): Delete.
4119         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4120
4121 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4122
4123         * v850-tdep.c (v850_unwind_sp): Delete.
4124         (v850_unwind_pc): Delete.
4125         (v850_dummy_id): Delete.
4126         (v850_gdbarch_init): Don't register deleted functions with
4127         gdbarch.
4128
4129 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4130
4131         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4132         (tilegx_unwind_pc): Delete.
4133         (tilegx_unwind_dummy_id): Delete.
4134         (tilegx_gdbarch_init): Don't register deleted functions with
4135         gdbarch.
4136
4137 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4138
4139         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4140         (tic6x_dummy_id): Delete.
4141         (tic6x_gdbarch_init): Don't register deleted functions with
4142         gdbarch.
4143
4144 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4145
4146         * sparc-tdep.c (sparc_unwind_pc): Delete.
4147         (sparc32_gdbarch_init): Don't register deleted function with
4148         gdbarch.
4149
4150 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4151
4152         * sh-tdep.c (sh_unwind_sp): Delete.
4153         (sh_unwind_pc): Delete.
4154         (sh_dummy_id): Delete.
4155         (sh_gdbarch_init): Don't register deleted functions with
4156         gdbarch.
4157
4158 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4159
4160         * score-tdep.c (score_unwind_sp): Delete.
4161         (score_unwind_pc): Delete.
4162         (score_dummy_id): Delete.
4163         (score_gdbarch_init): Don't register deleted functions with
4164         gdbarch.
4165
4166 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4167
4168         * rx-tdep.c (rx_unwind_pc): Delete.
4169         (rx_unwind_sp): Delete.
4170         (rx_dummy_id): Delete.
4171         (rx_gdbarch_init): Don't register deleted functions with
4172         gdbarch.  Update comment.
4173
4174 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4175
4176         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4177         (rs6000_dummy_id): Delete.
4178         (rs6000_gdbarch_init): Don't register deleted functions with
4179         gdbarch.
4180
4181 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4182
4183         * or1k-tdep.c (or1k_dummy_id): Delete.
4184         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4185
4186 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4187
4188         * nios2-tdep.c (nios2_dummy_id): Delete.
4189         (nios2_unwind_sp): Delete.
4190         (nios2_gdbarch_init): Don't register deleted functions with
4191         gdbarch.
4192
4193 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4194
4195         * nds32-tdep.c (nds32_dummy_id): Delete.
4196         (nds32_unwind_pc): Delete.
4197         (nds32_unwind_sp): Delete.
4198         (nds32_gdbarch_init): Don't register deleted functions with
4199         gdbarch.
4200
4201 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4202
4203         * msp430-tdep.c (msp430_unwind_pc): Delete.
4204         (msp430_unwind_sp): Delete.
4205         (msp430_dummy_id): Delete.
4206         (msp430_gdbarch_init): Don't register deleted functions with
4207         gdbarch.
4208
4209 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4210
4211         * moxie-tdep.c (moxie_unwind_sp): Delete.
4212         (moxie_unwind_pc): Delete.
4213         (moxie_dummy_id): Delete.
4214         (moxie_gdbarch_init): Don't register deleted functions with
4215         gdbarch.
4216
4217 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4218
4219         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4220         (mn10300_unwind_pc): Delete.
4221         (mn10300_unwind_sp): Delete.
4222         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4223         mn10300_unwind_sp.
4224         (mn10300_frame_unwind_init): Don't register deleted functions with
4225         gdbarch.
4226
4227 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4228
4229         * mep-tdep.c (mep_unwind_pc): Delete.
4230         (mep_unwind_sp): Delete.
4231         (mep_dummy_id): Delete.
4232         (mep_gdbarch_init): Don't register deleted functions with
4233         gdbarch.
4234
4235 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4236
4237         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4238         (m68hc11_unwind_sp): Delete.
4239         (m68hc11_gdbarch_init): Don't register deleted functions with
4240         gdbarch.
4241
4242 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4243
4244         * m32r-tdep.c (m32r_unwind_sp): Delete.
4245         (m32r_unwind_pc): Delete.
4246         (m32r_dummy_id): Delete.
4247         (m32r_gdbarch_init): Don't register deleted functions with
4248         gdbarch.
4249
4250 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4251
4252         * m32c-tdep.c (m32c_unwind_pc): Delete.
4253         (m32c_unwind_sp): Delete.
4254         (m32c_dummy_id): Delete.
4255         (m32c_gdbarch_init): Don't register deleted functions with
4256         gdbarch.
4257
4258 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4259
4260         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4261         (lm32_unwind_pc): Delete.
4262         (lm32_dummy_id): Delete.
4263         (lm32_gdbarch_init): Don't register deleted functions with
4264         gdbarch.
4265
4266 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4267
4268         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4269         (iq2000_unwind_pc): Delete.
4270         (iq2000_dummy_id): Delete.
4271         (iq2000_gdbarch_init): Don't register deleted functions with
4272         gdbarch.
4273
4274 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4275
4276         * nds32-tdep.c (nds32_type_align): Delete.
4277         (nds32_push_dummy_call): Use type_align instead.
4278
4279 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4280
4281         * arm-tdep.c (arm_type_align): Only handle vector override case.
4282         (arm_push_dummy_call): Use type_align.
4283         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4284
4285 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4286
4287         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4288         case.
4289         (pass_on_stack): Use type_align.
4290         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4291         function.
4292
4293 2019-04-23  Tom Tromey  <tromey@adacore.com>
4294
4295         * dwarf2read.c (line_header::file_name_at): Remove unused
4296         overload.
4297
4298 2019-04-23  Tom de Vries  <tdevries@suse.de>
4299
4300         PR gdb/24438
4301         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4302         invocation.
4303
4304
4305 2019-03-27  Ali Tamur  <tamur@google.com>
4306
4307         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4308         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4309         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4310         (dwarf_expr_context::get_addr_index): Likewise
4311         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4312         (symbol_needs_eval_context::get_addr_index): Likewise
4313         (disassemble_dwarf_expression): Add DW_OP_addrx
4314         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4315         (read_cutu_die_from_dwo): Update comment
4316         (skip_one_die): Add DW_FORM_addrx
4317         (read_attribute_value): Likewise
4318         (var_decode_location): Add DW_OP_addrx
4319         (dwarf2_const_value_attr): Add DW_FORM_addrx
4320         (dump_die_shallow): Likewise
4321         (dwarf2_fetch_constant_bytes): Likewise
4322         (decode_locdesc): Add DW_OP_addrx
4323         (skip_form_bytes): Add DW_FORM_addrx
4324
4325 2019-04-22  Ali Tamur  <tamur@google.com>
4326
4327         * MAINTAINERS (Write After Approval): Add self.
4328
4329 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4330
4331         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4332         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4333         (open_symbol_file_object): Likewise.
4334         (svr4_default_sos): Add info parameter.
4335         (svr4_read_so_list): Likewise.
4336         (svr4_current_sos_direct): Adjust functions calls to pass down
4337         info.
4338         (svr4_current_sos_1): Add info parameter.
4339         (svr4_current_sos): Call get_svr4_info, pass info down to
4340         svr4_current_sos_1.
4341         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4342         get_svr4_info.
4343         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4344         get_svr4_info.
4345         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4346         to get_svr4_info.
4347         (probes_table_remove_objfile_probes): Likewise.
4348         (register_solib_event_probe): Add info parameter.
4349         (solist_update_incremental): Pass info parameter down to
4350         svr4_read_so_list.
4351         (disable_probes_interface): Add info parameter.
4352         (svr4_handle_solib_event): Pass current_program_space to
4353         get_svr4_info.  Adjust disable_probes_interface cleanup.
4354         (svr4_create_probe_breakpoints): Add info parameter, pass it
4355         down to register_solib_event_probe.
4356         (svr4_create_solib_event_breakpoints): Add info parameter,
4357         pass it down to svr4_create_probe_breakpoints.
4358         (enable_break): Pass info down to
4359         svr4_create_solib_event_breakpoints.
4360         (svr4_solib_create_inferior_hook): Pass current_program_space to
4361         get_svr4_info.
4362         (svr4_clear_solib): Likewise.
4363
4364 2019-04-22  Pedro Alves  <palves@redhat.com>
4365
4366         * solib-svr4.c (svr4_free_objfile_observer): New.
4367         (probe_and_action::objfile): New field.
4368         (probes_table_htab_remove_objfile_probes)
4369         (probes_table_remove_objfile_probes): New functions.
4370         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4371         in the new probe_and_action.  Don't store the probe in 'lookup'.
4372         (svr4_create_probe_breakpoints): Pass objfile to
4373         register_solib_event_probe.
4374         (_initialize_svr4_solib): Register a free_objfile observer.
4375
4376 2019-04-19  Tom Tromey  <tom@tromey.com>
4377
4378         * common/queue.h: Remove.
4379
4380 2019-04-19  Tom Tromey  <tom@tromey.com>
4381
4382         * event-loop.c: Don't include "common/queue.h".
4383
4384 2019-04-19  Tom Tromey  <tom@tromey.com>
4385
4386         * remote.c (remote_target): Use delete.
4387         * remote-notif.h: Include <list>, not "common/queue.h".
4388         (notif_client_p): Remove typedef.
4389         (remote_notif_state): Add constructor, destructor, initializer.
4390         <notif_queue>: Now a std::list.
4391         (remote_notif_state_xfree): Don't declare.
4392         * remote-notif.c (remote_notif_process, handle_notification)
4393         (remote_notif_state_allocate): Update.
4394         (~remote_notif_state): Rename from remote_notif_state_xfree.
4395
4396 2019-04-19  Tom Tromey  <tom@tromey.com>
4397
4398         * symfile.c (reread_symbols): Update.
4399         * objfiles.c (objfile_register_static_link)
4400         (objfile_lookup_static_link): Update
4401         (~objfile) Don't delete static_links.
4402         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4403
4404 2019-04-19  Tom Tromey  <tom@tromey.com>
4405
4406         * type-stack.h (struct type_stack) <insert>: Constify string.
4407         * type-stack.c (type_stack::insert): Constify string.
4408         * gdbtypes.h (lookup_template_type): Update.
4409         (address_space_name_to_int): Update.
4410         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4411         const.
4412         (lookup_template_type): Make name const.
4413         * c-exp.y: Update rules.
4414         (lex_one_token, classify_name, classify_inner_name)
4415         (c_print_token): Update.
4416         * p-exp.y: Update rules.
4417         (yylex): Update.
4418         * f-exp.y: Update rules.
4419         (yylex): Update.
4420         * d-exp.y: Update rules.
4421         (lex_one_token, classify_name, classify_inner_name): Update.
4422         * parse.c (write_dollar_variable, copy_name): Return std::string.
4423         * parser-defs.h (copy_name): Change return type.
4424         * m2-exp.y: Update rules.
4425         (yylex): Update.
4426         * go-exp.y (lex_one_token): Update.
4427         Update rules.
4428         (classify_unsafe_function, classify_packaged_name)
4429         (classify_name, yylex): Update.
4430
4431 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4432
4433         * configure.ac: add --enable-source-highlight switch.
4434         * configure: Regenerate.
4435         * top.c (print_gdb_version): plumb --enable-source-highlight
4436         status to "show configuration".
4437
4438 2019-04-19  Tom Tromey  <tromey@adacore.com>
4439
4440         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4441         Check ADA_TYPE_P.
4442         (empty_record, ada_template_to_fixed_record_type_1)
4443         (template_to_static_fixed_type)
4444         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4445         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4446         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4447         macros.
4448
4449 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4450
4451         PR symtab/24423:
4452         * source.c (print_source_lines_base): Advance "iter" when a
4453         control character is seen.
4454
4455 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4456
4457         * inferior.h (struct infcall_suspend_state_deleter):
4458         Catch exception in destructor to avoid crash.
4459
4460 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4461
4462         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4463         close to the add_com "shell".
4464
4465 2019-04-18  Tom Tromey  <tromey@adacore.com>
4466
4467         * process-stratum-target.h (class process_stratum_target)
4468         <stratum>: Add "final".
4469
4470 2019-04-17  Tom Tromey  <tromey@adacore.com>
4471
4472         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4473         against nullptr before use.
4474
4475 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4476
4477         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4478
4479 2019-04-17  Jim Wilson  <jimw@sifive.com>
4480             Andrew Burgess  <andrew.burgess@embecosm.com>
4481
4482         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4483         code read might fail, assume 4-byte breakpoint in that case.
4484
4485 2019-04-15  Leszek Swirski  <leszeks@google.com>
4486
4487         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4488         rather than a hand-rolled POD check when checking for forced MEMORY
4489         classification.
4490
4491 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4492
4493         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4494         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4495         function.
4496         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4497         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4498         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4499         declaration.
4500
4501 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4502
4503         * aarch64-linux-nat.c
4504         (aarch64_linux_nat_target::thread_architecture): Add override.
4505         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4506         each VQ.
4507
4508 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4509
4510         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4511
4512 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4513
4514         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4515         target types of size 96-bits, add some additional comments, and
4516         check that the builtin type we found was the correct size.
4517
4518 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4519
4520         * utils.c (prompt_for_continue): Don't restore the styling at the
4521         end, as applied_style has the wrong value.  This fixes styling in
4522         long lists of file names that are interrupted by the "Continue?"
4523         prompt.
4524
4525 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4526
4527         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4528         * c-lang.c (c_language_defn): Likewise.
4529         (cplus_language_defn): Likewise.
4530         (asm_language_defn): Likewise.
4531         (minimal_language_defn): Likewise.
4532         * d-lang.c (d_language_defn): Likewise.
4533         * f-lang.c (f_language_defn): Likewise.
4534         * go-lang.c (go_language_defn): Likewise.
4535         * language.c (unknown_language_defn): Likewise.
4536         (auto_language_defn): Likewise.
4537         * language.h (struct language_defn): Remove la_magic field.
4538         (LANG_MAGIC): Delete.
4539         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4540         * objc-lang.c (objc_language_defn): Likewise.
4541         * opencl-lang.c (opencl_language_defn): Likewise.
4542         * p-lang.c (pascal_language_defn): Likewise.
4543         * rust-lang.c (rust_language_defn): Likewise.
4544
4545 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4546
4547         * riscv-tdep.c (riscv_type_align): New function.
4548         (riscv_type_alignment): Delete.
4549         (riscv_arg_location): Use 'type_align'.
4550         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4551
4552 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4553
4554         * gdbtypes.c (type_align): A struct with no non-static fields also
4555         has alignment of 1.
4556
4557 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4558
4559         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4560         component to 0.
4561         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4562         member.
4563         (riscv_struct_info::analyse): New implementation using new
4564         analyse_inner member function.
4565         (riscv_struct_info::field_offset): New member function.
4566         (riscv_struct_info::m_offsets): New member variable.
4567         (riscv_struct_info::analyse_inner): New private member function,
4568         takes the old implementation of riscv_struct_info::analyse but
4569         extended to track field offsets.
4570         (riscv_call_arg_struct): Update the struct folding special cases
4571         to handle cases where empty C++ structs, which are non-zero
4572         length, are found.
4573         (riscv_arg_location): Initialise the length of each location, a
4574         non-zero length now indicates the location is in use.
4575         (riscv_push_dummy_call): Allow for the first location having a
4576         non-zero offset when setting up arguments.
4577         (riscv_return_value): Likewise, but for return values.
4578
4579 2019-04-11  Tom Tromey  <tromey@adacore.com>
4580
4581         * utils.c (internal_vproblem): Make "msg" const.
4582
4583 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4584
4585         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4586         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4587         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4588         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4589
4590 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4591
4592         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4593         function.
4594         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4595         of amd64_collect_native_gregset.
4596         (amd64_linux_nat_target::store_registers): Likewise.
4597
4598 2019-04-10  Tom Tromey  <tom@tromey.com>
4599
4600         * symtab.c (lookup_global_symbol_from_objfile)
4601         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4602         * objfiles.h (class separate_debug_iterator): New.
4603         (class separate_debug_range): New.
4604         (struct objfile) <separate_debug_objfiles>: New method.
4605         (objfile_separate_debug_iterate): Don't declare.
4606         * objfiles.c (separate_debug_iterator::operator++): Rename from
4607         objfile_separate_debug_iterate.
4608         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4609         iterator.
4610         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4611         iterator.
4612
4613 2019-04-10  Tom Tromey  <tom@tromey.com>
4614
4615         * symfile.c (reread_symbols): Remove old comment.
4616         * objfiles.c (free_all_objfiles): Fix a typo.
4617
4618 2019-04-10  Tom Tromey  <tom@tromey.com>
4619
4620         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4621         * minsyms.c (lookup_minimal_symbol): Use foreach.
4622         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4623         (lookup_minimal_symbol_solib_trampoline): Likewise.
4624         * symfile.c (reread_symbols): Use foreach.
4625
4626 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4627             Tom Tromey  <tromey@adacore.com>
4628
4629         PR rust/24414:
4630         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4631         (rust_lex_int_test): Change "value" to be LONGEST.
4632         (rust_lex_tests): Add test for long integer literal.
4633
4634 2019-04-09  Tom Tromey  <tromey@adacore.com>
4635
4636         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4637         to bool.
4638         (extended_remote_target::attach): Update.
4639         (remote_target::remote_notice_new_inferior): Update.
4640         (remote_target::add_current_inferior_and_thread): Update.
4641         * inferior.c (exit_inferior_1): Use "false".
4642         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4643
4644 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4645
4646         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4647         the "start" command.
4648
4649 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4650
4651         * python/py-inferior.c (infpy_thread_from_thread_handle):
4652         Adjust comments to reflect renaming of thread_from_thread_handle
4653         to thread_from_handle.  Adjust keywords.  Fix type error message.
4654         (inferior_object_methods): Add thread_from_handle.  Retain
4655         thread_from_thread_handle, but mark it as deprecated.
4656
4657 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4658
4659         * gdbthread.h (find_thread_by_handle): Revise declaration.
4660         * thread.c (find_thread_by_handle): Likewise.  Adjust
4661         implementation too.
4662         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4663         support for buffer objects as handles.
4664
4665 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4666
4667         * python/py-infthread.c (thpy_thread_handle): New function.
4668         (thread_object_methods): Register thpy_thread_handle.
4669
4670 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4671
4672         * gdbthread.h (thread_to_thread_handle): Declare.
4673         * thread.c (gdbtypes.h): Include.
4674         (thread_to_thread_handle): New function.
4675
4676         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4677         (target_thread_info_to_thread_handle): Declare.
4678         * target.c (target_thread_info_to_thread_handle): New function.
4679         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4680         * target-delegates.c: Regenerate.
4681
4682         * linux-thread-db.c (class thread_db_target): Add method
4683         thread_info_to_thread_handle.
4684         (thread_db_target::thread_info_to_thread_handle): Define.
4685         * remote.c (class remote_target): Add new method
4686         thread_info_to_thread_handle.
4687         (remote_target::thread_info_to_thread_handle): Define.
4688
4689 2019-04-08  Pedro Alves  <palves@redhat.com>
4690
4691         * common/common-exceptions.c (throw_exception): Don't create
4692         named object to throw; throw directly.
4693         (throw_it): Likewise.  Don't initialize gdb_exception::message
4694         here, with new; pass FMT and AP to the ctor instead.
4695         * common/common-exceptions.h: Include <string>.
4696         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4697         const char *, va_list)): New ctor.  Use std::make_shared.
4698         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4699         errors)): Delete.
4700         (gdb_exception_error::gdb_exception_error(enum errors, const char
4701         *, va_list)): New.
4702         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4703         Add assertion.
4704         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4705         errors)): Delete.
4706         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4707         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4708         Add assertion.
4709
4710 2019-04-08  Tom Tromey  <tom@tromey.com>
4711
4712         * valops.c (value_rtti_indirect_type): Replace throw_exception
4713         with throw.
4714         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4715         with throw.
4716         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4717         throw.
4718         * target.c (target_translate_tls_address): Replace throw_exception
4719         with throw.
4720         * stack.c (frame_apply_command_count): Replace throw_exception
4721         with throw.
4722         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4723         throw.
4724         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4725         with throw.
4726         * rs6000-tdep.c (rs6000_frame_cache)
4727         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4728         * remote.c: Replace throw_exception with throw.
4729         * record-full.c (record_full_message, record_full_wait_1)
4730         (record_full_restore): Replace throw_exception with throw.
4731         * record-btrace.c:
4732         (get_thread_current_frame_id, record_btrace_start_replaying)
4733         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4734         (cmd_record_btrace_start): Replace throw_exception with throw.
4735         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4736         throw.
4737         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4738         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4739         * linespec.c:
4740         (find_linespec_symbols): Replace throw_exception with throw.
4741         * infrun.c (displaced_step_prepare, resume): Replace
4742         throw_exception with throw.
4743         * infcmd.c (post_create_inferior): Replace throw_exception with
4744         throw.
4745         * inf-loop.c (inferior_event_handler): Replace throw_exception
4746         with throw.
4747         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4748         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4749         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4750         (get_prev_frame_always, get_frame_pc_if_available)
4751         (get_frame_address_in_block_if_available, get_frame_language):
4752         Replace throw_exception with throw.
4753         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4754         throw_exception with throw.
4755         * eval.c (fetch_subexp_value, evaluate_var_value)
4756         (evaluate_funcall, evaluate_subexp_standard): Replace
4757         throw_exception with throw.
4758         * dwarf2loc.c (call_site_find_chain)
4759         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4760         Replace throw_exception with throw.
4761         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4762         with throw.
4763         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4764         throw.
4765         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4766         * completer.c (complete_line_internal): Replace throw_exception
4767         with throw.
4768         * compile/compile-object-run.c (compile_object_run): Replace
4769         throw_exception with throw.
4770         * cli/cli-script.c (process_next_line): Replace throw_exception
4771         with throw.
4772         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4773         (btrace_enable, btrace_maint_update_pt_packets): Replace
4774         throw_exception with throw.
4775         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4776         throw_exception with throw.
4777         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4778         throw_exception with throw.
4779         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4780         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4781         * aarch64-tdep.c (aarch64_make_prologue_cache)
4782         (aarch64_make_stub_cache): Replace throw_exception with throw.
4783
4784 2019-04-08  Tom Tromey  <tom@tromey.com>
4785
4786         * common/common-exceptions.c (throw_exception): Rename from
4787         throw_exception_cxx.  Remove old copy.  Make argument const.
4788         (throw_it): Create and throw exception objects directly.
4789         * common/common-exceptions.h (throw_exception): Make argument
4790         const.
4791         (struct gdb_exception_error): Add constructor.
4792         (struct gdb_exception_quit): Add constructor.
4793
4794 2019-04-08  Tom Tromey  <tom@tromey.com>
4795
4796         * common/common-exceptions.h (exception_rethrow): Don't declare.
4797         (TRY_SJLJ): Update comment.
4798         (TRY, CATCH, END_CATCH): Remove.
4799         * common/common-exceptions.c (exception_rethrow): Remove.
4800
4801 2019-04-08  Tom Tromey  <tom@tromey.com>
4802
4803         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4804         Remove.
4805         (gdb_exception_error): Rename from
4806         gdb_exception_RETURN_MASK_ERROR.
4807         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4808         (gdb_quit_bad_alloc): Update.
4809         * aarch64-tdep.c: Update.
4810         * ada-lang.c: Update.
4811         * ada-typeprint.c: Update.
4812         * ada-valprint.c: Update.
4813         * amd64-tdep.c: Update.
4814         * arch-utils.c: Update.
4815         * break-catch-throw.c: Update.
4816         * breakpoint.c: Update.
4817         * btrace.c: Update.
4818         * c-varobj.c: Update.
4819         * cli/cli-cmds.c: Update.
4820         * cli/cli-interp.c: Update.
4821         * cli/cli-script.c: Update.
4822         * common/common-exceptions.c: Update.
4823         * common/new-op.c: Update.
4824         * common/selftest.c: Update.
4825         * compile/compile-c-symbols.c: Update.
4826         * compile/compile-cplus-symbols.c: Update.
4827         * compile/compile-object-load.c: Update.
4828         * compile/compile-object-run.c: Update.
4829         * completer.c: Update.
4830         * corelow.c: Update.
4831         * cp-abi.c: Update.
4832         * cp-support.c: Update.
4833         * cp-valprint.c: Update.
4834         * darwin-nat.c: Update.
4835         * disasm-selftests.c: Update.
4836         * dtrace-probe.c: Update.
4837         * dwarf-index-cache.c: Update.
4838         * dwarf-index-write.c: Update.
4839         * dwarf2-frame-tailcall.c: Update.
4840         * dwarf2-frame.c: Update.
4841         * dwarf2loc.c: Update.
4842         * dwarf2read.c: Update.
4843         * eval.c: Update.
4844         * event-loop.c: Update.
4845         * event-top.c: Update.
4846         * exec.c: Update.
4847         * f-valprint.c: Update.
4848         * fbsd-tdep.c: Update.
4849         * frame-unwind.c: Update.
4850         * frame.c: Update.
4851         * gdbtypes.c: Update.
4852         * gnu-v3-abi.c: Update.
4853         * guile/guile-internal.h: Update.
4854         * guile/scm-block.c: Update.
4855         * guile/scm-breakpoint.c: Update.
4856         * guile/scm-cmd.c: Update.
4857         * guile/scm-disasm.c: Update.
4858         * guile/scm-frame.c: Update.
4859         * guile/scm-lazy-string.c: Update.
4860         * guile/scm-math.c: Update.
4861         * guile/scm-param.c: Update.
4862         * guile/scm-ports.c: Update.
4863         * guile/scm-pretty-print.c: Update.
4864         * guile/scm-symbol.c: Update.
4865         * guile/scm-symtab.c: Update.
4866         * guile/scm-type.c: Update.
4867         * guile/scm-value.c: Update.
4868         * i386-linux-tdep.c: Update.
4869         * i386-tdep.c: Update.
4870         * inf-loop.c: Update.
4871         * infcall.c: Update.
4872         * infcmd.c: Update.
4873         * infrun.c: Update.
4874         * jit.c: Update.
4875         * language.c: Update.
4876         * linespec.c: Update.
4877         * linux-fork.c: Update.
4878         * linux-nat.c: Update.
4879         * linux-tdep.c: Update.
4880         * linux-thread-db.c: Update.
4881         * main.c: Update.
4882         * mi/mi-cmd-break.c: Update.
4883         * mi/mi-cmd-stack.c: Update.
4884         * mi/mi-interp.c: Update.
4885         * mi/mi-main.c: Update.
4886         * objc-lang.c: Update.
4887         * p-valprint.c: Update.
4888         * parse.c: Update.
4889         * ppc-linux-tdep.c: Update.
4890         * printcmd.c: Update.
4891         * python/py-arch.c: Update.
4892         * python/py-breakpoint.c: Update.
4893         * python/py-cmd.c: Update.
4894         * python/py-finishbreakpoint.c: Update.
4895         * python/py-frame.c: Update.
4896         * python/py-framefilter.c: Update.
4897         * python/py-gdb-readline.c: Update.
4898         * python/py-inferior.c: Update.
4899         * python/py-infthread.c: Update.
4900         * python/py-lazy-string.c: Update.
4901         * python/py-linetable.c: Update.
4902         * python/py-objfile.c: Update.
4903         * python/py-param.c: Update.
4904         * python/py-prettyprint.c: Update.
4905         * python/py-progspace.c: Update.
4906         * python/py-record-btrace.c: Update.
4907         * python/py-record.c: Update.
4908         * python/py-symbol.c: Update.
4909         * python/py-type.c: Update.
4910         * python/py-unwind.c: Update.
4911         * python/py-utils.c: Update.
4912         * python/py-value.c: Update.
4913         * python/python.c: Update.
4914         * record-btrace.c: Update.
4915         * record-full.c: Update.
4916         * remote-fileio.c: Update.
4917         * remote.c: Update.
4918         * riscv-tdep.c: Update.
4919         * rs6000-aix-tdep.c: Update.
4920         * rs6000-tdep.c: Update.
4921         * rust-exp.y: Update.
4922         * rust-lang.c: Update.
4923         * s390-tdep.c: Update.
4924         * selftest-arch.c: Update.
4925         * solib-dsbt.c: Update.
4926         * solib-frv.c: Update.
4927         * solib-spu.c: Update.
4928         * solib-svr4.c: Update.
4929         * solib.c: Update.
4930         * sparc64-linux-tdep.c: Update.
4931         * stack.c: Update.
4932         * symfile-mem.c: Update.
4933         * symmisc.c: Update.
4934         * target.c: Update.
4935         * thread.c: Update.
4936         * top.c: Update.
4937         * tracefile-tfile.c: Update.
4938         * tui/tui.c: Update.
4939         * typeprint.c: Update.
4940         * unittests/cli-utils-selftests.c: Update.
4941         * unittests/parse-connection-spec-selftests.c: Update.
4942         * valops.c: Update.
4943         * valprint.c: Update.
4944         * value.c: Update.
4945         * varobj.c: Update.
4946         * windows-nat.c: Update.
4947         * x86-linux-nat.c: Update.
4948         * xml-support.c: Update.
4949
4950 2019-04-08  Tom Tromey  <tom@tromey.com>
4951
4952         * xml-support.c: Use C++ exception handling.
4953         * x86-linux-nat.c: Use C++ exception handling.
4954         * windows-nat.c: Use C++ exception handling.
4955         * varobj.c: Use C++ exception handling.
4956         * value.c: Use C++ exception handling.
4957         * valprint.c: Use C++ exception handling.
4958         * valops.c: Use C++ exception handling.
4959         * unittests/parse-connection-spec-selftests.c: Use C++ exception
4960         handling.
4961         * unittests/cli-utils-selftests.c: Use C++ exception handling.
4962         * typeprint.c: Use C++ exception handling.
4963         * tui/tui.c: Use C++ exception handling.
4964         * tracefile-tfile.c: Use C++ exception handling.
4965         * top.c: Use C++ exception handling.
4966         * thread.c: Use C++ exception handling.
4967         * target.c: Use C++ exception handling.
4968         * symmisc.c: Use C++ exception handling.
4969         * symfile-mem.c: Use C++ exception handling.
4970         * stack.c: Use C++ exception handling.
4971         * sparc64-linux-tdep.c: Use C++ exception handling.
4972         * solib.c: Use C++ exception handling.
4973         * solib-svr4.c: Use C++ exception handling.
4974         * solib-spu.c: Use C++ exception handling.
4975         * solib-frv.c: Use C++ exception handling.
4976         * solib-dsbt.c: Use C++ exception handling.
4977         * selftest-arch.c: Use C++ exception handling.
4978         * s390-tdep.c: Use C++ exception handling.
4979         * rust-lang.c: Use C++ exception handling.
4980         * rust-exp.y: Use C++ exception handling.
4981         * rs6000-tdep.c: Use C++ exception handling.
4982         * rs6000-aix-tdep.c: Use C++ exception handling.
4983         * riscv-tdep.c: Use C++ exception handling.
4984         * remote.c: Use C++ exception handling.
4985         * remote-fileio.c: Use C++ exception handling.
4986         * record-full.c: Use C++ exception handling.
4987         * record-btrace.c: Use C++ exception handling.
4988         * python/python.c: Use C++ exception handling.
4989         * python/py-value.c: Use C++ exception handling.
4990         * python/py-utils.c: Use C++ exception handling.
4991         * python/py-unwind.c: Use C++ exception handling.
4992         * python/py-type.c: Use C++ exception handling.
4993         * python/py-symbol.c: Use C++ exception handling.
4994         * python/py-record.c: Use C++ exception handling.
4995         * python/py-record-btrace.c: Use C++ exception handling.
4996         * python/py-progspace.c: Use C++ exception handling.
4997         * python/py-prettyprint.c: Use C++ exception handling.
4998         * python/py-param.c: Use C++ exception handling.
4999         * python/py-objfile.c: Use C++ exception handling.
5000         * python/py-linetable.c: Use C++ exception handling.
5001         * python/py-lazy-string.c: Use C++ exception handling.
5002         * python/py-infthread.c: Use C++ exception handling.
5003         * python/py-inferior.c: Use C++ exception handling.
5004         * python/py-gdb-readline.c: Use C++ exception handling.
5005         * python/py-framefilter.c: Use C++ exception handling.
5006         * python/py-frame.c: Use C++ exception handling.
5007         * python/py-finishbreakpoint.c: Use C++ exception handling.
5008         * python/py-cmd.c: Use C++ exception handling.
5009         * python/py-breakpoint.c: Use C++ exception handling.
5010         * python/py-arch.c: Use C++ exception handling.
5011         * printcmd.c: Use C++ exception handling.
5012         * ppc-linux-tdep.c: Use C++ exception handling.
5013         * parse.c: Use C++ exception handling.
5014         * p-valprint.c: Use C++ exception handling.
5015         * objc-lang.c: Use C++ exception handling.
5016         * mi/mi-main.c: Use C++ exception handling.
5017         * mi/mi-interp.c: Use C++ exception handling.
5018         * mi/mi-cmd-stack.c: Use C++ exception handling.
5019         * mi/mi-cmd-break.c: Use C++ exception handling.
5020         * main.c: Use C++ exception handling.
5021         * linux-thread-db.c: Use C++ exception handling.
5022         * linux-tdep.c: Use C++ exception handling.
5023         * linux-nat.c: Use C++ exception handling.
5024         * linux-fork.c: Use C++ exception handling.
5025         * linespec.c: Use C++ exception handling.
5026         * language.c: Use C++ exception handling.
5027         * jit.c: Use C++ exception handling.
5028         * infrun.c: Use C++ exception handling.
5029         * infcmd.c: Use C++ exception handling.
5030         * infcall.c: Use C++ exception handling.
5031         * inf-loop.c: Use C++ exception handling.
5032         * i386-tdep.c: Use C++ exception handling.
5033         * i386-linux-tdep.c: Use C++ exception handling.
5034         * guile/scm-value.c: Use C++ exception handling.
5035         * guile/scm-type.c: Use C++ exception handling.
5036         * guile/scm-symtab.c: Use C++ exception handling.
5037         * guile/scm-symbol.c: Use C++ exception handling.
5038         * guile/scm-pretty-print.c: Use C++ exception handling.
5039         * guile/scm-ports.c: Use C++ exception handling.
5040         * guile/scm-param.c: Use C++ exception handling.
5041         * guile/scm-math.c: Use C++ exception handling.
5042         * guile/scm-lazy-string.c: Use C++ exception handling.
5043         * guile/scm-frame.c: Use C++ exception handling.
5044         * guile/scm-disasm.c: Use C++ exception handling.
5045         * guile/scm-cmd.c: Use C++ exception handling.
5046         * guile/scm-breakpoint.c: Use C++ exception handling.
5047         * guile/scm-block.c: Use C++ exception handling.
5048         * guile/guile-internal.h: Use C++ exception handling.
5049         * gnu-v3-abi.c: Use C++ exception handling.
5050         * gdbtypes.c: Use C++ exception handling.
5051         * frame.c: Use C++ exception handling.
5052         * frame-unwind.c: Use C++ exception handling.
5053         * fbsd-tdep.c: Use C++ exception handling.
5054         * f-valprint.c: Use C++ exception handling.
5055         * exec.c: Use C++ exception handling.
5056         * event-top.c: Use C++ exception handling.
5057         * event-loop.c: Use C++ exception handling.
5058         * eval.c: Use C++ exception handling.
5059         * dwarf2read.c: Use C++ exception handling.
5060         * dwarf2loc.c: Use C++ exception handling.
5061         * dwarf2-frame.c: Use C++ exception handling.
5062         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5063         * dwarf-index-write.c: Use C++ exception handling.
5064         * dwarf-index-cache.c: Use C++ exception handling.
5065         * dtrace-probe.c: Use C++ exception handling.
5066         * disasm-selftests.c: Use C++ exception handling.
5067         * darwin-nat.c: Use C++ exception handling.
5068         * cp-valprint.c: Use C++ exception handling.
5069         * cp-support.c: Use C++ exception handling.
5070         * cp-abi.c: Use C++ exception handling.
5071         * corelow.c: Use C++ exception handling.
5072         * completer.c: Use C++ exception handling.
5073         * compile/compile-object-run.c: Use C++ exception handling.
5074         * compile/compile-object-load.c: Use C++ exception handling.
5075         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5076         * compile/compile-c-symbols.c: Use C++ exception handling.
5077         * common/selftest.c: Use C++ exception handling.
5078         * common/new-op.c: Use C++ exception handling.
5079         * cli/cli-script.c: Use C++ exception handling.
5080         * cli/cli-interp.c: Use C++ exception handling.
5081         * cli/cli-cmds.c: Use C++ exception handling.
5082         * c-varobj.c: Use C++ exception handling.
5083         * btrace.c: Use C++ exception handling.
5084         * breakpoint.c: Use C++ exception handling.
5085         * break-catch-throw.c: Use C++ exception handling.
5086         * arch-utils.c: Use C++ exception handling.
5087         * amd64-tdep.c: Use C++ exception handling.
5088         * ada-valprint.c: Use C++ exception handling.
5089         * ada-typeprint.c: Use C++ exception handling.
5090         * ada-lang.c: Use C++ exception handling.
5091         * aarch64-tdep.c: Use C++ exception handling.
5092
5093 2019-04-08  Tom Tromey  <tom@tromey.com>
5094
5095         * xml-support.c (gdb_xml_parser::parse): Update.
5096         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5097         * value.c (show_convenience): Update.
5098         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5099         (test_parse_flags_qcs): Update.
5100         * thread.c (thr_try_catch_cmd): Update.
5101         * target.c (target_translate_tls_address): Update.
5102         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5103         (info_frame_command_core, frame_apply_command_count): Update.
5104         * rust-exp.y (rust_lex_exception_test): Update.
5105         * riscv-tdep.c (riscv_print_one_register_info): Update.
5106         * remote.c (remote_target::enable_btrace): Update.
5107         * record-btrace.c (record_btrace_enable_warn): Update.
5108         * python/py-utils.c (gdbpy_convert_exception): Update.
5109         * printcmd.c (do_one_display, print_variable_and_value): Update.
5110         * mi/mi-main.c (mi_print_exception): Update.
5111         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5112         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5113         * linux-nat.c (linux_nat_target::attach): Update.
5114         * linux-fork.c (class scoped_switch_fork_info): Update.
5115         * infrun.c (displaced_step_prepare): Update.
5116         * infcall.c (call_function_by_hand_dummy): Update.
5117         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5118         * gnu-v3-abi.c (print_one_vtable): Update.
5119         * frame.c (get_prev_frame_always): Update.
5120         * f-valprint.c (info_common_command_for_block): Update.
5121         * exec.c (try_open_exec_file): Update.
5122         * exceptions.c (print_exception, exception_print)
5123         (exception_fprintf, exception_print_same): Update.
5124         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5125         * dwarf-index-cache.c (index_cache::store)
5126         (index_cache::lookup_gdb_index): Update.
5127         * darwin-nat.c (maybe_cache_shell): Update.
5128         * cp-valprint.c (cp_print_value_fields): Update.
5129         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5130         (gcc_cplus_symbol_address): Update.
5131         * compile/compile-c-symbols.c (gcc_convert_symbol)
5132         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5133         * common/selftest.c: Update.
5134         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5135         a std::string.
5136         (exception_try_scope_entry, exception_try_scope_exit): Don't
5137         declare.
5138         (struct exception_try_scope): Remove.
5139         (TRY): Don't use exception_try_scope.
5140         (struct gdb_exception): Add constructor, operator=.
5141         <what>: New method.
5142         (struct gdb_exception_RETURN_MASK_ALL)
5143         (struct gdb_exception_RETURN_MASK_ERROR)
5144         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5145         (struct gdb_quit_bad_alloc): Update.
5146         * common/common-exceptions.c (exception_none): Change
5147         initializer.
5148         (struct catcher) <state, exception>: Initialize inline.
5149         <prev>: Remove member.
5150         (current_catcher): Remove.
5151         (catchers): New global.
5152         (exceptions_state_mc_init): Simplify.
5153         (catcher_pop): Remove.
5154         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5155         (try_scope_depth, exception_try_scope_entry)
5156         (exception_try_scope_exit): Remove.
5157         (throw_exception_sjlj): Update.
5158         (exception_messages, exception_messages_size): Remove.
5159         (throw_it): Simplify.
5160         (gdb_exception_sliced_copy): Remove.
5161         (throw_exception_cxx): Update.
5162         * cli/cli-script.c (script_from_file): Update.
5163         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5164         Update.
5165         * ada-valprint.c (ada_val_print): Update.
5166         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5167         (create_excep_cond_exprs): Update.
5168
5169 2019-04-08  Tom Tromey  <tom@tromey.com>
5170
5171         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5172         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5173         (TRY, CATCH, END_CATCH): Remove some definitions.
5174         * common/common-exceptions.c: Don't use GDB_XCPT.
5175         (catcher_list_size): Remove.
5176         (throw_exception, throw_it): Simplify.
5177
5178 2019-04-05  Tom Tromey  <tom@tromey.com>
5179
5180         Revert the header-sorting patch.
5181         * ft32-tdep.c: Revert.
5182         * frv-tdep.c: Revert.
5183         * frv-linux-tdep.c: Revert.
5184         * frame.c: Revert.
5185         * frame-unwind.c: Revert.
5186         * frame-base.c: Revert.
5187         * fork-child.c: Revert.
5188         * findvar.c: Revert.
5189         * findcmd.c: Revert.
5190         * filesystem.c: Revert.
5191         * filename-seen-cache.h: Revert.
5192         * filename-seen-cache.c: Revert.
5193         * fbsd-tdep.c: Revert.
5194         * fbsd-nat.h: Revert.
5195         * fbsd-nat.c: Revert.
5196         * f-valprint.c: Revert.
5197         * f-typeprint.c: Revert.
5198         * f-lang.c: Revert.
5199         * extension.h: Revert.
5200         * extension.c: Revert.
5201         * extension-priv.h: Revert.
5202         * expprint.c: Revert.
5203         * exec.h: Revert.
5204         * exec.c: Revert.
5205         * exceptions.c: Revert.
5206         * event-top.c: Revert.
5207         * event-loop.c: Revert.
5208         * eval.c: Revert.
5209         * elfread.c: Revert.
5210         * dwarf2read.h: Revert.
5211         * dwarf2read.c: Revert.
5212         * dwarf2loc.c: Revert.
5213         * dwarf2expr.h: Revert.
5214         * dwarf2expr.c: Revert.
5215         * dwarf2-frame.c: Revert.
5216         * dwarf2-frame-tailcall.c: Revert.
5217         * dwarf-index-write.h: Revert.
5218         * dwarf-index-write.c: Revert.
5219         * dwarf-index-common.c: Revert.
5220         * dwarf-index-cache.h: Revert.
5221         * dwarf-index-cache.c: Revert.
5222         * dummy-frame.c: Revert.
5223         * dtrace-probe.c: Revert.
5224         * disasm.h: Revert.
5225         * disasm.c: Revert.
5226         * disasm-selftests.c: Revert.
5227         * dictionary.c: Revert.
5228         * dicos-tdep.c: Revert.
5229         * demangle.c: Revert.
5230         * dcache.h: Revert.
5231         * dcache.c: Revert.
5232         * darwin-nat.h: Revert.
5233         * darwin-nat.c: Revert.
5234         * darwin-nat-info.c: Revert.
5235         * d-valprint.c: Revert.
5236         * d-namespace.c: Revert.
5237         * d-lang.c: Revert.
5238         * ctf.c: Revert.
5239         * csky-tdep.c: Revert.
5240         * csky-linux-tdep.c: Revert.
5241         * cris-tdep.c: Revert.
5242         * cris-linux-tdep.c: Revert.
5243         * cp-valprint.c: Revert.
5244         * cp-support.c: Revert.
5245         * cp-namespace.c: Revert.
5246         * cp-abi.c: Revert.
5247         * corelow.c: Revert.
5248         * corefile.c: Revert.
5249         * continuations.c: Revert.
5250         * completer.h: Revert.
5251         * completer.c: Revert.
5252         * complaints.c: Revert.
5253         * coffread.c: Revert.
5254         * coff-pe-read.c: Revert.
5255         * cli-out.h: Revert.
5256         * cli-out.c: Revert.
5257         * charset.c: Revert.
5258         * c-varobj.c: Revert.
5259         * c-valprint.c: Revert.
5260         * c-typeprint.c: Revert.
5261         * c-lang.c: Revert.
5262         * buildsym.c: Revert.
5263         * buildsym-legacy.c: Revert.
5264         * build-id.h: Revert.
5265         * build-id.c: Revert.
5266         * btrace.c: Revert.
5267         * bsd-uthread.c: Revert.
5268         * breakpoint.h: Revert.
5269         * breakpoint.c: Revert.
5270         * break-catch-throw.c: Revert.
5271         * break-catch-syscall.c: Revert.
5272         * break-catch-sig.c: Revert.
5273         * blockframe.c: Revert.
5274         * block.c: Revert.
5275         * bfin-tdep.c: Revert.
5276         * bfin-linux-tdep.c: Revert.
5277         * bfd-target.c: Revert.
5278         * bcache.c: Revert.
5279         * ax-general.c: Revert.
5280         * ax-gdb.h: Revert.
5281         * ax-gdb.c: Revert.
5282         * avr-tdep.c: Revert.
5283         * auxv.c: Revert.
5284         * auto-load.c: Revert.
5285         * arm-wince-tdep.c: Revert.
5286         * arm-tdep.c: Revert.
5287         * arm-symbian-tdep.c: Revert.
5288         * arm-pikeos-tdep.c: Revert.
5289         * arm-obsd-tdep.c: Revert.
5290         * arm-nbsd-tdep.c: Revert.
5291         * arm-nbsd-nat.c: Revert.
5292         * arm-linux-tdep.c: Revert.
5293         * arm-linux-nat.c: Revert.
5294         * arm-fbsd-tdep.c: Revert.
5295         * arm-fbsd-nat.c: Revert.
5296         * arm-bsd-tdep.c: Revert.
5297         * arch-utils.c: Revert.
5298         * arc-tdep.c: Revert.
5299         * arc-newlib-tdep.c: Revert.
5300         * annotate.h: Revert.
5301         * annotate.c: Revert.
5302         * amd64-windows-tdep.c: Revert.
5303         * amd64-windows-nat.c: Revert.
5304         * amd64-tdep.c: Revert.
5305         * amd64-sol2-tdep.c: Revert.
5306         * amd64-obsd-tdep.c: Revert.
5307         * amd64-obsd-nat.c: Revert.
5308         * amd64-nbsd-tdep.c: Revert.
5309         * amd64-nbsd-nat.c: Revert.
5310         * amd64-nat.c: Revert.
5311         * amd64-linux-tdep.c: Revert.
5312         * amd64-linux-nat.c: Revert.
5313         * amd64-fbsd-tdep.c: Revert.
5314         * amd64-fbsd-nat.c: Revert.
5315         * amd64-dicos-tdep.c: Revert.
5316         * amd64-darwin-tdep.c: Revert.
5317         * amd64-bsd-nat.c: Revert.
5318         * alpha-tdep.c: Revert.
5319         * alpha-obsd-tdep.c: Revert.
5320         * alpha-nbsd-tdep.c: Revert.
5321         * alpha-mdebug-tdep.c: Revert.
5322         * alpha-linux-tdep.c: Revert.
5323         * alpha-linux-nat.c: Revert.
5324         * alpha-bsd-tdep.c: Revert.
5325         * alpha-bsd-nat.c: Revert.
5326         * aix-thread.c: Revert.
5327         * agent.c: Revert.
5328         * addrmap.c: Revert.
5329         * ada-varobj.c: Revert.
5330         * ada-valprint.c: Revert.
5331         * ada-typeprint.c: Revert.
5332         * ada-tasks.c: Revert.
5333         * ada-lang.c: Revert.
5334         * aarch64-tdep.c: Revert.
5335         * aarch64-ravenscar-thread.c: Revert.
5336         * aarch64-newlib-tdep.c: Revert.
5337         * aarch64-linux-tdep.c: Revert.
5338         * aarch64-linux-nat.c: Revert.
5339         * aarch64-fbsd-tdep.c: Revert.
5340         * aarch64-fbsd-nat.c: Revert.
5341         * aarch32-linux-nat.c: Revert.
5342
5343 2019-04-05  Tom Tromey  <tom@tromey.com>
5344
5345         * ft32-tdep.c: Sort headers.
5346         * frv-tdep.c: Sort headers.
5347         * frv-linux-tdep.c: Sort headers.
5348         * frame.c: Sort headers.
5349         * frame-unwind.c: Sort headers.
5350         * frame-base.c: Sort headers.
5351         * fork-child.c: Sort headers.
5352         * findvar.c: Sort headers.
5353         * findcmd.c: Sort headers.
5354         * filesystem.c: Sort headers.
5355         * filename-seen-cache.h: Sort headers.
5356         * filename-seen-cache.c: Sort headers.
5357         * fbsd-tdep.c: Sort headers.
5358         * fbsd-nat.h: Sort headers.
5359         * fbsd-nat.c: Sort headers.
5360         * f-valprint.c: Sort headers.
5361         * f-typeprint.c: Sort headers.
5362         * f-lang.c: Sort headers.
5363         * extension.h: Sort headers.
5364         * extension.c: Sort headers.
5365         * extension-priv.h: Sort headers.
5366         * expprint.c: Sort headers.
5367         * exec.h: Sort headers.
5368         * exec.c: Sort headers.
5369         * exceptions.c: Sort headers.
5370         * event-top.c: Sort headers.
5371         * event-loop.c: Sort headers.
5372         * eval.c: Sort headers.
5373         * elfread.c: Sort headers.
5374         * dwarf2read.h: Sort headers.
5375         * dwarf2read.c: Sort headers.
5376         * dwarf2loc.c: Sort headers.
5377         * dwarf2expr.h: Sort headers.
5378         * dwarf2expr.c: Sort headers.
5379         * dwarf2-frame.c: Sort headers.
5380         * dwarf2-frame-tailcall.c: Sort headers.
5381         * dwarf-index-write.h: Sort headers.
5382         * dwarf-index-write.c: Sort headers.
5383         * dwarf-index-common.c: Sort headers.
5384         * dwarf-index-cache.h: Sort headers.
5385         * dwarf-index-cache.c: Sort headers.
5386         * dummy-frame.c: Sort headers.
5387         * dtrace-probe.c: Sort headers.
5388         * disasm.h: Sort headers.
5389         * disasm.c: Sort headers.
5390         * disasm-selftests.c: Sort headers.
5391         * dictionary.c: Sort headers.
5392         * dicos-tdep.c: Sort headers.
5393         * demangle.c: Sort headers.
5394         * dcache.h: Sort headers.
5395         * dcache.c: Sort headers.
5396         * darwin-nat.h: Sort headers.
5397         * darwin-nat.c: Sort headers.
5398         * darwin-nat-info.c: Sort headers.
5399         * d-valprint.c: Sort headers.
5400         * d-namespace.c: Sort headers.
5401         * d-lang.c: Sort headers.
5402         * ctf.c: Sort headers.
5403         * csky-tdep.c: Sort headers.
5404         * csky-linux-tdep.c: Sort headers.
5405         * cris-tdep.c: Sort headers.
5406         * cris-linux-tdep.c: Sort headers.
5407         * cp-valprint.c: Sort headers.
5408         * cp-support.c: Sort headers.
5409         * cp-namespace.c: Sort headers.
5410         * cp-abi.c: Sort headers.
5411         * corelow.c: Sort headers.
5412         * corefile.c: Sort headers.
5413         * continuations.c: Sort headers.
5414         * completer.h: Sort headers.
5415         * completer.c: Sort headers.
5416         * complaints.c: Sort headers.
5417         * coffread.c: Sort headers.
5418         * coff-pe-read.c: Sort headers.
5419         * cli-out.h: Sort headers.
5420         * cli-out.c: Sort headers.
5421         * charset.c: Sort headers.
5422         * c-varobj.c: Sort headers.
5423         * c-valprint.c: Sort headers.
5424         * c-typeprint.c: Sort headers.
5425         * c-lang.c: Sort headers.
5426         * buildsym.c: Sort headers.
5427         * buildsym-legacy.c: Sort headers.
5428         * build-id.h: Sort headers.
5429         * build-id.c: Sort headers.
5430         * btrace.c: Sort headers.
5431         * bsd-uthread.c: Sort headers.
5432         * breakpoint.h: Sort headers.
5433         * breakpoint.c: Sort headers.
5434         * break-catch-throw.c: Sort headers.
5435         * break-catch-syscall.c: Sort headers.
5436         * break-catch-sig.c: Sort headers.
5437         * blockframe.c: Sort headers.
5438         * block.c: Sort headers.
5439         * bfin-tdep.c: Sort headers.
5440         * bfin-linux-tdep.c: Sort headers.
5441         * bfd-target.c: Sort headers.
5442         * bcache.c: Sort headers.
5443         * ax-general.c: Sort headers.
5444         * ax-gdb.h: Sort headers.
5445         * ax-gdb.c: Sort headers.
5446         * avr-tdep.c: Sort headers.
5447         * auxv.c: Sort headers.
5448         * auto-load.c: Sort headers.
5449         * arm-wince-tdep.c: Sort headers.
5450         * arm-tdep.c: Sort headers.
5451         * arm-symbian-tdep.c: Sort headers.
5452         * arm-pikeos-tdep.c: Sort headers.
5453         * arm-obsd-tdep.c: Sort headers.
5454         * arm-nbsd-tdep.c: Sort headers.
5455         * arm-nbsd-nat.c: Sort headers.
5456         * arm-linux-tdep.c: Sort headers.
5457         * arm-linux-nat.c: Sort headers.
5458         * arm-fbsd-tdep.c: Sort headers.
5459         * arm-fbsd-nat.c: Sort headers.
5460         * arm-bsd-tdep.c: Sort headers.
5461         * arch-utils.c: Sort headers.
5462         * arc-tdep.c: Sort headers.
5463         * arc-newlib-tdep.c: Sort headers.
5464         * annotate.h: Sort headers.
5465         * annotate.c: Sort headers.
5466         * amd64-windows-tdep.c: Sort headers.
5467         * amd64-windows-nat.c: Sort headers.
5468         * amd64-tdep.c: Sort headers.
5469         * amd64-sol2-tdep.c: Sort headers.
5470         * amd64-obsd-tdep.c: Sort headers.
5471         * amd64-obsd-nat.c: Sort headers.
5472         * amd64-nbsd-tdep.c: Sort headers.
5473         * amd64-nbsd-nat.c: Sort headers.
5474         * amd64-nat.c: Sort headers.
5475         * amd64-linux-tdep.c: Sort headers.
5476         * amd64-linux-nat.c: Sort headers.
5477         * amd64-fbsd-tdep.c: Sort headers.
5478         * amd64-fbsd-nat.c: Sort headers.
5479         * amd64-dicos-tdep.c: Sort headers.
5480         * amd64-darwin-tdep.c: Sort headers.
5481         * amd64-bsd-nat.c: Sort headers.
5482         * alpha-tdep.c: Sort headers.
5483         * alpha-obsd-tdep.c: Sort headers.
5484         * alpha-nbsd-tdep.c: Sort headers.
5485         * alpha-mdebug-tdep.c: Sort headers.
5486         * alpha-linux-tdep.c: Sort headers.
5487         * alpha-linux-nat.c: Sort headers.
5488         * alpha-bsd-tdep.c: Sort headers.
5489         * alpha-bsd-nat.c: Sort headers.
5490         * aix-thread.c: Sort headers.
5491         * agent.c: Sort headers.
5492         * addrmap.c: Sort headers.
5493         * ada-varobj.c: Sort headers.
5494         * ada-valprint.c: Sort headers.
5495         * ada-typeprint.c: Sort headers.
5496         * ada-tasks.c: Sort headers.
5497         * ada-lang.c: Sort headers.
5498         * aarch64-tdep.c: Sort headers.
5499         * aarch64-ravenscar-thread.c: Sort headers.
5500         * aarch64-newlib-tdep.c: Sort headers.
5501         * aarch64-linux-tdep.c: Sort headers.
5502         * aarch64-linux-nat.c: Sort headers.
5503         * aarch64-fbsd-tdep.c: Sort headers.
5504         * aarch64-fbsd-nat.c: Sort headers.
5505         * aarch32-linux-nat.c: Sort headers.
5506
5507 2019-04-04  Tom Tromey  <tom@tromey.com>
5508
5509         * varobj.c (varobj_create): Update.
5510         * rust-exp.y (struct rust_parser) <update_innermost_block,
5511         lookup_symbol>: New methods.
5512         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5513         Rename.
5514         (rust_parser::rust_lookup_type)
5515         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5516         * printcmd.c (display_command, do_one_display): Update.
5517         * parser-defs.h (struct parser_state) <parser_state>: Add
5518         "tracker" parameter.
5519         (block_tracker): New member.
5520         (class innermost_block_tracker) <innermost_block_tracker>: Add
5521         "types" parameter.
5522         <reset>: Remove method.
5523         (innermost_block): Don't declare.
5524         (null_post_parser): Update.
5525         * parse.c (innermost_block): Remove global.
5526         (write_dollar_variable): Update.
5527         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5528         Remove "tracker_types" parameter.
5529         (parse_expression): Add "tracker" parameter.
5530         (parse_expression_for_completion): Update.
5531         (null_post_parser): Add "tracker" parameter.
5532         * p-exp.y: Update rules.
5533         * m2-exp.y: Update rules.
5534         * language.h (struct language_defn) <la_post_parser>: Add
5535         "tracker" parameter.
5536         * go-exp.y: Update rules.
5537         * f-exp.y: Update rules.
5538         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5539         parameter.
5540         * d-exp.y: Update rules.
5541         * c-exp.y: Update rules.
5542         * breakpoint.c (set_breakpoint_condition): Create an
5543         innermost_block_tracker.
5544         (watch_command_1): Likewise.
5545         * ada-lang.c (resolve): Add "tracker" parameter.
5546         (resolve_subexp): Likewise.
5547         * ada-exp.y (write_var_from_sym): Update.
5548
5549 2019-04-04  Tom Tromey  <tom@tromey.com>
5550
5551         * type-stack.h: New file.
5552         * type-stack.c: New file.
5553         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5554         type-stack.h.
5555         (insert_into_type_stack, insert_type, push_type, push_type_int)
5556         (insert_type_address_space, pop_type, pop_type_int)
5557         (pop_typelist, pop_type_stack, append_type_stack)
5558         (push_type_stack, get_type_stack, push_typelist)
5559         (follow_type_instance_flags, follow_types): Don't declare.
5560         * parse.c (type_stack): Remove global.
5561         (parse_exp_in_context): Update.
5562         (insert_into_type_stack, insert_type, push_type, push_type_int)
5563         (insert_type_address_space, pop_type, pop_type_int)
5564         (pop_typelist, pop_type_stack, append_type_stack)
5565         (push_type_stack, get_type_stack, push_typelist)
5566         (follow_type_instance_flags, follow_types): Remove (moved to
5567         type-stack.c).
5568         * f-exp.y (type_stack): New global.
5569         Update rules.
5570         (push_kind_type, f_parse): Update.
5571         * d-exp.y (type_stack): New global.
5572         Update rules.
5573         (d_parse): Update.
5574         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5575         Update rules.
5576         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5577         (HFILES_NO_SRCDIR): Add type-stack.h.
5578
5579 2019-04-04  Tom Tromey  <tom@tromey.com>
5580
5581         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5582         (rust_parser::convert_ast_to_expression, rust_parse)
5583         (rust_lex_test_completion, rust_lex_tests): Update.
5584         * parser-defs.h (struct expr_completion_state): New.
5585         (struct parser_state) <parser_state>: Add completion parameter.
5586         <mark_struct_expression, mark_completion_tag>: New methods.
5587         <parse_completion, m_completion_state>: New members.
5588         (prefixify_expression, null_post_parser): Update.
5589         (mark_struct_expression, mark_completion_tag): Don't declare.
5590         * parse.c (parse_completion, expout_last_struct)
5591         (expout_tag_completion_type, expout_completion_name): Remove
5592         globals.
5593         (parser_state::mark_struct_expression)
5594         (parser_state::mark_completion_tag): Now methods.
5595         (prefixify_expression): Add last_struct parameter.
5596         (prefixify_subexp): Likewise.
5597         (parse_exp_1): Update.
5598         (parse_exp_in_context): Add cstate parameter.  Update.
5599         (parse_expression_for_completion): Create an
5600         expr_completion_state.
5601         (null_post_parser): Add "completion" parameter.
5602         * p-exp.y: Update rules.
5603         (yylex): Update.
5604         * language.h (struct language_defn) <la_post_parser>: Add
5605         "completing" parameter.
5606         * go-exp.y: Update rules.
5607         (lex_one_token): Update.
5608         * expression.h (parse_completion): Don't declare.
5609         * d-exp.y: Update rules.
5610         (lex_one_token): Update rules.
5611         * c-exp.y: Update rules.
5612         (lex_one_token): Update.
5613         * ada-lang.c (resolve): Add "parse_completion" parameter.
5614         (resolve_subexp): Likewise.
5615         (ada_resolve_function): Likewise.
5616
5617 2019-04-04  Tom Tromey  <tom@tromey.com>
5618
5619         * parser-defs.h (struct parser_state) <start_arglist,
5620         end_arglist>: New methods.
5621         <arglist_len, m_funcall_chain>: New members.
5622         (arglist_len, start_arglist, end_arglist): Don't declare.
5623         * parse.c (arglist_len, funcall_chain): Remove global.
5624         (start_arglist, end_arglist): Remove functions.
5625         (parse_exp_in_context): Update.
5626         * p-exp.y: Update rules.
5627         * m2-exp.y: Update rules.
5628         * go-exp.y: Update rules.
5629         * f-exp.y: Update rules.
5630         * d-exp.y: Update rules.
5631         * c-exp.y: Update rules.
5632
5633 2019-04-04  Tom Tromey  <tom@tromey.com>
5634
5635         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5636         lex_operator, push_back>: New methods.
5637         Update all rules.
5638         (rust_parser::lex_hex, lex_escape): Rename and update.
5639         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5640         (rust_parser::lex_operator): Rename and update.
5641         (rust_parser::lex_number, rustyylex, rustyyerror)
5642         (rust_lex_test_init, rust_lex_test_sequence)
5643         (rust_lex_test_push_back, rust_lex_tests): Update.
5644         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5645         parameter.
5646         <lexptr, prev_lexptr>: New members.
5647         (lexptr, prev_lexptr): Don't declare.
5648         * parse.c (lexptr, prev_lexptr): Remove globals.
5649         (parse_exp_in_context): Update.
5650         * p-exp.y (yylex, yyerror): Update.
5651         * m2-exp.y (parse_number, yylex, yyerror): Update.
5652         * go-exp.y (lex_one_token, yyerror): Update.
5653         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5654         * d-exp.y (lex_one_token, yyerror): Update.
5655         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5656         (lex_one_token, yyerror): Update.
5657         * ada-lex.l (YY_INPUT): Update.
5658         (rewind_to_char): Update.
5659         * ada-exp.y (yyerror): Update.
5660
5661 2019-04-04  Tom Tromey  <tom@tromey.com>
5662
5663         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5664         * parser-defs.h (struct parser_state) <parser_state>: Add new
5665         parameter.
5666         <comma_terminates>: New member.
5667         (comma_terminates): Don't declare global.
5668         * parse.c (comma_terminates): Remove global.
5669         (parse_exp_in_context): Update.
5670         * p-exp.y (yylex): Update.
5671         * m2-exp.y (yylex): Update.
5672         * go-exp.y (lex_one_token): Update.
5673         * f-exp.y (yylex): Update.
5674         * d-exp.y (lex_one_token): Update.
5675         * c-exp.y (lex_one_token): Update.
5676         * ada-lex.l: Update.
5677
5678 2019-04-04  Tom Tromey  <tom@tromey.com>
5679
5680         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5681         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5682         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5683         * parser-defs.h (paren_depth): Don't declare.
5684         * parse.c (paren_depth): Remove global.
5685         (parse_exp_in_context): Update.
5686         * p-exp.y (paren_depth): New global.
5687         (pascal_parse): Initialize it.
5688         * m2-exp.y (paren_depth): New global.
5689         (m2_parse): Initialize it.
5690         * go-exp.y (paren_depth): New global.
5691         (go_parse): Initialize it.
5692         * f-exp.y (paren_depth): New global.
5693         (f_parse): Initialize it.
5694         * d-exp.y (paren_depth): New global.
5695         (d_parse): Initialize it.
5696         * c-exp.y (paren_depth): New global.
5697         (c_parse): Initialize it.
5698         * ada-lex.l (paren_depth): New global.
5699         (lexer_init): Initialize it.
5700
5701 2019-04-04  Tom Tromey  <tom@tromey.com>
5702
5703         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5704         (rust_parser::convert_ast_to_type)
5705         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5706         * parser-defs.h (struct parser_state) <parser_state>: Add
5707         parameters.  Initialize new members.
5708         <expression_context_block, expression_context_pc>: New members.
5709         * parse.c (expression_context_block, expression_context_pc):
5710         Remove globals.
5711         (parse_exp_in_context): Update.
5712         * p-exp.y: Update all rules.
5713         (yylex): Update.
5714         * m2-exp.y: Update all rules.
5715         (yylex): Update.
5716         * go-exp.y (yylex): Update.
5717         * f-exp.y (yylex): Update.
5718         * d-exp.y: Update all rules.
5719         (yylex): Update.
5720         * c-exp.y: Update all rules.
5721         (lex_one_token, classify_name, yylex, c_parse): Update.
5722         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5723
5724 2019-04-04  Tom Tromey  <tom@tromey.com>
5725
5726         * gdbarch.h, gdbarch.c: Rebuild.
5727         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5728         * stap-probe.h:
5729         (struct stap_parse_info): Replace "parser_state" with
5730         "expr_builder".
5731         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5732         (parser_state): New class.
5733         * parse.c (expr_builder): Rename.
5734         (expr_builder::release): Rename.
5735         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5736         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5737         (write_exp_elt_longcst, write_exp_elt_floatcst)
5738         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5739         (write_exp_string_vector, write_exp_bitstring)
5740         (write_exp_msymbol, mark_struct_expression)
5741         (write_dollar_variable)
5742         (insert_type_address_space, increase_expout_size): Replace
5743         "parser_state" with "expr_builder".
5744         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5745         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5746         "parser_state" with "expr_builder".
5747
5748 2019-04-04  Tom Tromey  <tom@tromey.com>
5749
5750         * rust-exp.y: Replace "parse_language" with method call.
5751         * p-exp.y:
5752         (yylex): Replace "parse_language" with method call.
5753         * m2-exp.y:
5754         (yylex): Replace "parse_language" with method call.
5755         * go-exp.y (classify_name): Replace "parse_language" with method
5756         call.
5757         * f-exp.y (yylex): Replace "parse_language" with method call.
5758         * d-exp.y (lex_one_token): Replace "parse_language" with method
5759         call.
5760         * c-exp.y:
5761         (lex_one_token, classify_name, yylex): Replace "parse_language"
5762         with method call.
5763         * ada-exp.y (find_primitive_type, type_char)
5764         (type_system_address): Replace "parse_language" with method call.
5765
5766 2019-04-04  Tom Tromey  <tom@tromey.com>
5767
5768         * rust-exp.y: Replace "parse_gdbarch" with method call.
5769         * parse.c (write_dollar_variable, insert_type_address_space):
5770         Replace "parse_gdbarch" with method call.
5771         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5772         call.
5773         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5774         call.
5775         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5776         "parse_gdbarch" with method call.
5777         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5778         with method call.
5779         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5780         "parse_gdbarch" with method call.
5781         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5782         "parse_gdbarch" with method call.
5783         * c-exp.y (parse_type, parse_number, classify_name): Replace
5784         "parse_gdbarch" with method call.
5785         * ada-lex.l: Replace "parse_gdbarch" with method call.
5786         * ada-exp.y (parse_type, find_primitive_type, type_char)
5787         (type_system_address): Replace "parse_gdbarch" with method call.
5788
5789 2019-04-04  Tom Tromey  <tom@tromey.com>
5790
5791         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5792         * stap-probe.c (stap_parse_argument): Update.
5793         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5794         initial_size parameter.
5795         * rust-exp.y (rust_lex_tests): Update.
5796         * parse.c (parser_state): Update.
5797         (parse_exp_in_context): Update.
5798         * parser-defs.h (struct parser_state) <parser_state>: Remove
5799         "initial_size" parameter.
5800
5801 2019-04-04  Tom Tromey  <tom@tromey.com>
5802
5803         * parser-defs.h (increase_expout_size): Don't declare.
5804         * parse.c (increase_expout_size): Now static.
5805
5806 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
5807
5808         * gnu-nat.c (gnu_nat_target::wait): Fix
5809         target_waitstatus_to_string call.
5810
5811 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5812
5813         * eval.c (evaluate_subexp_standard): Handle internal functions
5814         during Fortran function call handling.
5815
5816 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5817
5818         * NEWS: Mention new internal functions.
5819         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5820         (read_base_type): Use dwarf2_init_complex_target_type.
5821         * value.c (creal_internal_fn): New function.
5822         (cimag_internal_fn): New function.
5823         (_initialize_values): Register new internal functions.
5824
5825 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5826
5827         * infrun.c (stop_all_threads): If debug_infrun, always
5828         trace the wait status after wait_one, using
5829         target_waitstatus_to_string and target_pid_to_str.
5830         (handle_inferior_event): Replace various trace of
5831         wait status kind by a single trace.
5832         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5833         wait status kind image by target_waitstatus_to_string.
5834         * target/waitstatus.c (target_waitstatus_to_string): Fix
5835         obsolete comment.
5836
5837 2019-04-01  Tom Tromey  <tromey@adacore.com>
5838
5839         PR symtab/23331:
5840         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
5841
5842 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5843             Pedro Alves  <palves@redhat.com>
5844
5845         * top.c (quit_force): Call 'finalize_values'.
5846         * value.c (finalize_values): New function.
5847         * value.h (finalize_values): Declare.
5848
5849 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
5850
5851         * NEWS: Announce $_gdb_major and $_gdb_minor.
5852
5853         * top.c (init_gdb_version_vars): New function.
5854         (gdb_init): Call init_gdb_version_vars.
5855
5856 2019-03-29  Tom Tromey  <tromey@adacore.com>
5857
5858         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
5859         help text.  Remove dead code.
5860
5861 2019-03-29  Keith Seitz  <keiths@redhat.com>
5862
5863         From Siddhesh Poyarekar:
5864         * f-lang.h (f77_get_upperbound): Return LONGEST.
5865         (f77_get_lowerbound): Likewise.
5866         * f-typeprint.c (f_type_print_varspec_suffix): Expand
5867         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
5868         print them.
5869         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
5870         plongest to format print it.
5871         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
5872         (f77_get_upperbound): Likewise.
5873         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
5874         LOWER_BOUND to LONGEST.
5875         (f77_create_arrayprint_offset_tbl): Likewise.
5876
5877 2019-03-29  Keith Seitz  <keiths@redhat.com>
5878
5879         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
5880         %s/pulongest for TYPE_LENGTH instead of %d in format
5881         strings.
5882         * ada-typerint.c (ada_print_type): Likewise.
5883         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
5884         * compile/compile-c-support.c (generate_register_struct): Likewise.
5885         * gdbtypes.c (recursive_dump_type): Likewise.
5886         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
5887         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
5888         instead of %d in format strings.
5889         * riscv-tdep.c (riscv_type_alignment): Cast second argument
5890         to std::min to ULONGEST.
5891         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
5892         instead of %d in format strings.
5893         * tracepoint.c (info_scope_command): Likewise.
5894         * typeprint.c (print_offset_data::update)
5895         (print_offset_data::finish): Likewise.
5896         * xtensa-tdep.c (xtensa_store_return_value)
5897         (xtensa_push_dummy_call): Likewise.
5898
5899 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
5900
5901         * windows-nat.c (display_selector): Fixed format specifications
5902         for 64-bit Cygwin.
5903
5904 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5905
5906         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
5907
5908 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
5909
5910         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
5911         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
5912         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
5913         (nios2_linux_init_abi): Install it.
5914
5915 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5916
5917         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
5918
5919 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5920
5921         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
5922
5923 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5924             Tom Tromey  <tromey@adacore.com>
5925
5926         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
5927
5928 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
5929
5930         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
5931         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
5932         method to compute the bounds of range types. Also print "[evaluated]"
5933         if the bounds' values come from a dynamic evaluation.
5934
5935 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5936
5937         * cp-valprint.c (cp_print_value_fields): Don't print trailing
5938         whitespace when pretty printing is on.
5939
5940 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5941
5942         * ppc-linux-nat.c: Add include.
5943
5944 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5945
5946         * NEWS: Mention AArch64 Pointer Authentication.
5947
5948 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5949
5950         * arm-linux-nat.c: Add include.
5951
5952 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
5953
5954         * source-cache.c (source_cache::get_source_lines): Re-read
5955         fullname after calling open_source_file.
5956
5957 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
5958
5959         * NEWS: Mention TLS support for FreeBSD.
5960
5961 2019-03-25  Tom Tromey  <tromey@adacore.com>
5962
5963         * minsyms.c (BUNCH_SIZE): Update comment.
5964         (~minimal_symbol_reader): Remove old comment.
5965         (compact_minimal_symbols): Update comment.
5966         (minimal_symbol_reader::install): Remove old comment.  Update
5967         other comments.
5968
5969 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5970
5971         * s390-linux-nat.c: Add include.
5972
5973 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5974
5975         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5976         Call linux_get_hwcap.
5977         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
5978         Likewise.
5979         (aarch64_linux_get_hwcap): Remove function.
5980         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
5981         declaration.
5982         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
5983         linux_get_hwcap.
5984         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5985         * linux-tdep.c (linux_get_hwcap): Add function.
5986         (linux_get_hwcap2): Likewise.
5987         * linux-tdep.h (linux_get_hwcap): Add declaration.
5988         (linux_get_hwcap2): Likewise.
5989         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
5990         (ppc_linux_get_hwcap2): Likewise.
5991         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
5992         linux_get_hwcap.
5993         (ppc_linux_nat_target::insert_watchpoint): Likewise.
5994         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
5995         (ppc_linux_nat_target::read_description): Likewise.
5996         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
5997         * s390-linux-nat.c: Likewise.
5998         * s390-linux-tdep.c (s390_core_read_description): Likewise.
5999
6000 2019-03-24  Tom Tromey  <tom@tromey.com>
6001
6002         * ada-lang.c (standard_lookup): Simplify initialization.
6003         (ada_lookup_symbol_nonlocal): Simplify return.
6004         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6005         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6006         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6007         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6008         initialization.
6009         * solib.c (solib_global_lookup): Simplify.
6010         * symtab.c (null_block_symbol): Remove.
6011         (symbol_cache_lookup): Simplify returns.
6012         (lookup_language_this): Simplify returns.
6013         (lookup_symbol_aux): Simplify return.
6014         (lookup_local_symbol): Simplify returns.
6015         (lookup_global_symbol_from_objfile): Simplify return.
6016         (lookup_symbol_in_objfile_symtabs)
6017         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6018         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6019         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6020         * cp-namespace.c (cp_lookup_bare_symbol)
6021         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6022         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6023         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6024         (cp_lookup_symbol_via_imports): Simplify initialization.
6025         (find_symbol_in_baseclass): Likewise.
6026         * symtab.h (null_block_symbol): Remove.
6027         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6028         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6029         (d_lookup_symbol_module): Likewise.
6030         (find_symbol_in_baseclass): Simplify initialization.
6031
6032 2019-03-24  Tom Tromey  <tom@tromey.com>
6033
6034         * expression.h: Don't include symtab.h.
6035         (struct block): Forward declare.
6036
6037 2019-03-24  Tom Tromey  <tom@tromey.com>
6038
6039         * c-exp.y (typebase): Remove casts.
6040         * gdbtypes.c (lookup_unsigned_typename, )
6041         (lookup_signed_typename): Remove cast.
6042         * eval.c (parse_to_comma_and_eval): Remove cast.
6043         * parse.c (write_dollar_variable): Remove cast.
6044         * block.h (struct block) <superblock>: Now const.
6045         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6046         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6047         (map_block): Make "block" const.
6048         * symfile.h (struct quick_symbol_functions)
6049         <map_matching_symbols>: Constify block argument to "callback".
6050         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6051         const.
6052         (find_pc_sect_compunit_symtab): Make "b" const.
6053         (find_symbol_at_address): Likewise.
6054         (search_symbols): Likewise.
6055         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6056         (dw2_debug_names_lookup_symbol): Likewise.
6057         (dw2_map_matching_symbols): Update.
6058         * p-valprint.c (pascal_val_print): Remove "block".
6059         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6060         (aux_add_nonlocal_symbols): Make "block" const.
6061         (resolve_subexp): Remove cast.
6062         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6063         const.
6064         (iterate_over_file_blocks): Likewise.
6065         * f-exp.y (%union) <bval>: Remove.
6066         * coffread.c (patch_opaque_types): Make "b" const.
6067         * spu-tdep.c (spu_catch_start): Make "block" const.
6068         * c-valprint.c (print_unpacked_pointer): Remove "block".
6069         * symmisc.c (dump_symtab_1): Make "b" const.
6070         (block_depth): Make "block" const.
6071         * d-exp.y (%union) <bval>: Remove.
6072         * cp-support.h (cp_lookup_rtti_type): Update.
6073         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6074         * psymtab.c (psym_lookup_symbol): Make "block" const.
6075         (maintenance_check_psymtabs): Make "b" const.
6076         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6077         (enumerate_locals, enumerate_args): Update.
6078         * python/py-symtab.c (stpy_global_block): Make "block" const.
6079         (stpy_static_block): Likewise.
6080         * inline-frame.c (block_starting_point_at): Make "new_block"
6081         const.
6082         * block.c (find_block_in_blockvector): Make return type const.
6083         (blockvector_for_pc_sect): Make "b" const.
6084         (find_block_in_blockvector): Make "b" const.
6085
6086 2019-03-23  Tom Tromey  <tom@tromey.com>
6087
6088         * varobj.c (varobj_create): Update.
6089         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6090         * printcmd.c (display_command, do_one_display): Don't reset
6091         innermost_block.
6092         * parser-defs.h (enum innermost_block_tracker_type): Move to
6093         expression.h.
6094         (innermost_block): Update comment.
6095         * parse.c (parse_exp_1): Add tracker_types parameter.
6096         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6097         tracker_types parameter.  Reset innermost_block.
6098         (parse_exp_in_context): Remove.
6099         (parse_expression_for_completion): Update.
6100         * objfiles.c (~objfile): Don't reset expression_context_block or
6101         innermost_block.
6102         * expression.h (enum innermost_block_tracker_type): Move from
6103         parser-defs.h.
6104         (parse_exp_1): Add tracker_types parameter.
6105         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6106         reset innermost_block.
6107
6108 2019-03-23  Tom Tromey  <tom@tromey.com>
6109
6110         * objfiles.h: Include bcache.h.
6111
6112 2019-03-23  Tom Tromey  <tom@tromey.com>
6113
6114         * linespec.c (get_current_search_block): Use
6115         scoped_restore_current_language.
6116         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6117
6118 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6119             Jiong Wang  <jiong.wang@arm.com>
6120
6121         * aarch64-linux-tdep.c
6122         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6123         section.
6124         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6125
6126 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6127             Jiong Wang  <jiong.wang@arm.com>
6128
6129         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6130         instructions.
6131         (aarch64_analyze_prologue_test): Add PACIASP test.
6132         (aarch64_prologue_prev_register): Unmask PC value.
6133
6134 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6135             Jiong Wang  <jiong.wang@arm.com>
6136
6137         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6138         (aarch64_dwarf2_prev_register): Unmask PC value.
6139         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6140         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6141         DW_CFA_AARCH64_negate_ra_state.
6142         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6143
6144 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6145             Jiong Wang  <jiong.wang@arm.com>
6146
6147         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6148         registers.
6149         (aarch64_pseudo_register_name): Likewise.
6150         (aarch64_pseudo_register_type): Likewise.
6151         (aarch64_pseudo_register_reggroup_p): Likewise.
6152         (aarch64_gdbarch_init): Add pauth registers.
6153         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6154         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6155         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6156         (struct gdbarch_tdep): Add regnum for ra_state.
6157
6158 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6159             Jiong Wang  <jiong.wang@arm.com>
6160
6161         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6162
6163 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6164             Jiong Wang  <jiong.wang@arm.com>
6165
6166         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6167         function.
6168         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6169         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6170         (aarch64_gdbarch_init): Add puth registers.
6171         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6172         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6173         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6174
6175 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6176             Jiong Wang  <jiong.wang@arm.com>
6177
6178         * aarch64-linux-nat.c
6179         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6180         * aarch64-linux-tdep.c
6181         (aarch64_linux_core_read_description): Likewise.
6182         (aarch64_linux_get_hwcap): New function.
6183         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6184         (aarch64_linux_get_hwcap): New declaration.
6185
6186 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6187             Jiong Wang  <jiong.wang@arm.com>
6188
6189         * aarch64-linux-nat.c
6190         (aarch64_linux_nat_target::read_description): Add pauth param.
6191         * aarch64-linux-tdep.c
6192         (aarch64_linux_core_read_description): Likewise.
6193         * aarch64-tdep.c (struct target_desc): Add in pauth.
6194         (aarch64_read_description): Add pauth param.
6195         (aarch64_gdbarch_init): Likewise.
6196         * aarch64-tdep.h (aarch64_read_description): Likewise.
6197         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6198         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6199         * features/Makefile: Add new files.
6200         * features/aarch64-pauth.c: New file.
6201         * features/aarch64-pauth.xml: New file.
6202
6203 2019-03-20  Tom Tromey  <tromey@adacore.com>
6204
6205         * infrun.c (handle_inferior_event): Rename from
6206         handle_inferior_event_1.  Create a scoped_value_mark.
6207         (handle_inferior_event): Remove.
6208
6209 2019-03-19  Tom Tromey  <tromey@adacore.com>
6210
6211         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6212         * infrun.h (print_stop_event): Add "displays" parameter.
6213         * infrun.c (print_stop_event): Add "displays" parameter.
6214
6215 2019-03-19  Pedro Alves  <palves@redhat.com>
6216
6217         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6218         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6219         to -1.  Fix TABs vs spaces.
6220         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6221         * tui/tui-out.h (tui_ui_out) Add intro comments.
6222         <m_line, m_start_of_line>: In-class initialize, and add describing
6223         comment.
6224
6225 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6226
6227         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6228         variable names.
6229         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6230
6231 2019-03-18  Pedro Alves  <palves@redhat.com>
6232             Eli Zaretskii <eliz@gnu.org>
6233
6234         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6235         m_line and m_start_of_line.
6236
6237 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6238
6239         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6240         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6241         it returns a newline.  This fixes a regression in TU mode, whereby
6242         the next line is output on the same screen line as the user input.
6243
6244 2019-03-18  Tom Tromey  <tromey@adacore.com>
6245
6246         * minsyms.c (minimal_symbol_reader::install): Remove call to
6247         obstack_blank.
6248
6249 2019-03-18  Pedro Alves  <palves@redhat.com>
6250
6251         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6252         New globals.
6253         (apply_style): New, factored out from ...
6254         (apply_ansi_escape): ... this.  Handle reverse video mode.
6255         (tui_set_reverse_mode): New function.
6256         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6257         * tui/tui-winsource.c (tui_show_source_line): Use
6258         tui_set_reverse_mode instead of setting A_STANDOUT.
6259         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6260         New setter methods.
6261
6262 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6263
6264         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6265         Handle tabs.
6266
6267 2019-03-18  Tom Tromey  <tromey@adacore.com>
6268
6269         * ada-lang.c (empty_array): Add "high" parameter.
6270         (ada_evaluate_subexp): Update.
6271
6272 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6273
6274         * unittests/string_view-selftests.c: Define
6275         _initialize_string_view_selftests unconditionally.
6276
6277 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6278
6279         PR gdb/24350
6280         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6281
6282 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6283
6284         PR gdb/24351
6285         * windows-nat.c (display_selector): Fix format specifiers.
6286
6287 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6288
6289         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6290         tui_refill_source_window instead of tui_refresh_win, to update the
6291         current execution line.  This fixes redisplay of the current line
6292         when stepping through the code with "next" or "step".
6293
6294 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6295
6296         * source-cache.c (source_cache::get_source_lines): Call
6297         find_source_lines to initialize s->nlines.  This fixes vertical
6298         scrolling of TUI source window when the DOWN arrow is pressed.
6299
6300 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6301
6302         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6303         linux-thread-db.c (_initialize_thread_db): Likewise.
6304
6305 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6306
6307         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6308         wclrtoeol in tui_show_source_line".  This reverts changes made in
6309         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6310
6311 2019-03-15  Tom Tromey  <tom@tromey.com>
6312
6313         * symtab.h (struct minimal_symbol): Derive from
6314         general_symbol_info.
6315         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6316         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6317         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6318         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6319         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6320         (MSYMBOL_SEARCH_NAME): Update.
6321         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6322         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6323         * minsyms.c (minimal_symbol_reader::record_full): Update.
6324
6325 2019-03-15  Tom Tromey  <tom@tromey.com>
6326
6327         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6328
6329 2019-03-15  Tom Tromey  <tom@tromey.com>
6330
6331         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6332         unique_xmalloc_ptr.
6333         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6334         Update.
6335         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6336         (build_minimal_symbol_hash_tables)
6337         (minimal_symbol_reader::install): Update.
6338
6339 2019-03-15  Tom Tromey  <tom@tromey.com>
6340
6341         * symtab.c (create_demangled_names_hash): Update.
6342         (symbol_set_names): Update.
6343         * objfiles.h (struct objfile_per_bfd_storage)
6344         <demangled_names_hash>: Now an htab_up.
6345         * objfiles.c (objfile_per_bfd_storage): Simplify.
6346
6347 2019-03-15  Tom Tromey  <tom@tromey.com>
6348
6349         * objfiles.h (struct objfile_per_bfd_storage): Declare
6350         destructor.
6351         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6352         New.
6353         (get_objfile_bfd_data): Use new.  Don't initialize
6354         language_of_main.
6355         (free_objfile_per_bfd_storage): Remove.
6356         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6357
6358 2019-03-15  Tom Tromey  <tom@tromey.com>
6359
6360         * symfile.c (reread_symbols): Update.
6361         * objfiles.c (objfile::objfile): Update.
6362         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6363         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6364         comment.
6365         (minimal_symbol_reader::install): Update.
6366         (terminate_minimal_symbol_table): Remove.
6367         * jit.c (jit_object_close_impl): Update.
6368
6369 2019-03-15  Tom Tromey  <tom@tromey.com>
6370
6371         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6372         initializations.
6373
6374 2019-03-15  Tom Tromey  <tom@tromey.com>
6375
6376         * objfiles.h (struct objfile_per_bfd_storage)
6377         <demangled_hash_languages>: Now a bitset.
6378         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6379         (lookup_minimal_symbol): Update.
6380
6381 2019-03-15  Tom Tromey  <tom@tromey.com>
6382
6383         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6384         Don't return the symbol.
6385         * coffread.c (record_minimal_symbol): Use record_full.
6386
6387 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6388
6389         The MS-Windows port of ncurses fails to switch to a color pair if
6390         one or both of the colors are the implicit default colors.  This
6391         change records the default colors when TUI is initialized, and
6392         then specifies them explicitly when a color pair uses the default
6393         colors.  This allows color styling in TUI mode on MS-Windows.
6394
6395         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6396         ncurses_norm_attr.
6397         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6398         colors in ncurses_norm_attr.
6399         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6400         "none", replace it with the default color recorded in
6401         ncurses_norm_attr.
6402
6403 2019-03-14  Tom Tromey  <tromey@adacore.com>
6404
6405         * source-cache.h (class source_cache) <get_source_lines>: Return
6406         std::string.
6407         * source-cache.c (source_cache::extract_lines): Handle case where
6408         first_pos==npos.  Return std::string.
6409         (source_cache::get_source_lines): Update.
6410
6411 2019-03-14  Tom Tromey  <tromey@adacore.com>
6412
6413         * NEWS: Add item for "style sources" commands.
6414         * source-cache.c (source_cache::get_source_lines): Check
6415         source_styling.
6416         * cli/cli-style.c (source_styling): New global.
6417         (_initialize_cli_style): Add "style sources" commands.
6418         (show_style_sources): New function.
6419         * cli/cli-style.h (source_styling): Declare.
6420
6421 2019-03-14  Pedro Alves  <palves@redhat.com>
6422             Tom Tromey  <tromey@adacore.com>
6423
6424         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6425         * tui/tui-winsource.c (tui_refill_source_window): New function,
6426         from...
6427         (tui_horizontal_source_scroll): ... here.  Move some logic.
6428         * cli/cli-style.c (set_style_enabled): Notify new observable.
6429         * tui/tui-hooks.c (tui_redisplay_source): New function.
6430         (tui_attach_detach_observers): Attach or detach
6431         tui_redisplay_source.
6432         * observable.h (source_styling_changed): New observable.
6433         * observable.c: Define source_styling_changed observable.
6434
6435 2019-03-13  Tom Tromey  <tromey@adacore.com>
6436
6437         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6438         (i386_gnu_nat_target::store_registers): Update.
6439         * target-debug.h (target_debug_print_std_string): New macro.
6440         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6441         * windows-tdep.c (display_one_tib): Update.
6442         * tui/tui-stack.c (tui_make_status_line): Update.
6443         * top.c (print_inferior_quit_action): Update.
6444         * thread.c (thr_try_catch_cmd): Update.
6445         (add_thread_with_info): Update.
6446         (thread_target_id_str): Update.
6447         (thr_try_catch_cmd): Update.
6448         (thread_command): Update.
6449         (thread_find_command): Update.
6450         * record-btrace.c (record_btrace_target::info_record)
6451         (record_btrace_resume_thread, record_btrace_target::resume)
6452         (record_btrace_cancel_resume, record_btrace_step_thread)
6453         (record_btrace_target::wait, record_btrace_target::wait)
6454         (record_btrace_target::wait, record_btrace_target::stop): Update.
6455         * progspace.c (print_program_space): Update.
6456         * process-stratum-target.c
6457         (process_stratum_target::thread_address_space): Update.
6458         * linux-fork.c (linux_fork_mourn_inferior)
6459         (detach_checkpoint_command, info_checkpoints_command)
6460         (linux_fork_context): Update.
6461         (linux_fork_detach): Update.
6462         (class scoped_switch_fork_info): Update.
6463         (delete_checkpoint_command): Update.
6464         * infrun.c (follow_fork_inferior): Update.
6465         (follow_fork_inferior): Update.
6466         (proceed_after_vfork_done): Update.
6467         (handle_vfork_child_exec_or_exit): Update.
6468         (follow_exec): Update.
6469         (displaced_step_prepare_throw): Update.
6470         (displaced_step_restore): Update.
6471         (start_step_over): Update.
6472         (resume_1): Update.
6473         (clear_proceed_status_thread): Update.
6474         (proceed): Update.
6475         (print_target_wait_results): Update.
6476         (do_target_wait): Update.
6477         (context_switch): Update.
6478         (stop_all_threads): Update.
6479         (restart_threads): Update.
6480         (finish_step_over): Update.
6481         (handle_signal_stop): Update.
6482         (switch_back_to_stepped_thread): Update.
6483         (keep_going_pass_signal): Update.
6484         (print_exited_reason): Update.
6485         (normal_stop): Update.
6486         * inferior.c (inferior_pid_to_str): Change return type.
6487         (print_selected_inferior): Update.
6488         (add_inferior): Update.
6489         (detach_inferior): Update.
6490         * dummy-frame.c (fprint_dummy_frames): Update.
6491         * dcache.c (dcache_info_1): Update.
6492         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6493         (btrace_fetch, btrace_clear): Update.
6494         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6495         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6496         type.
6497         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6498         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6499         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6500         * gdbarch.c, gdbarch.h: Rebuild.
6501         * gdbarch.sh (core_pid_to_str): Change return type.
6502         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6503         return type.
6504         (windows_nat_target::pid_to_str): Change return type.
6505         (windows_delete_thread): Update.
6506         (windows_nat_target::attach): Update.
6507         (windows_nat_target::files_info): Update.
6508         * target-delegates.c: Rebuild.
6509         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6510         return type.
6511         (sol_thread_target::pid_to_str): Change return type.
6512         * remote.c (class remote_target) <pid_to_str>: Change return
6513         type.
6514         (remote_target::pid_to_str): Change return type.
6515         (extended_remote_target::attach, remote_target::remote_stop_ns)
6516         (remote_target::remote_notif_remove_queued_reply)
6517         (remote_target::push_stop_reply, remote_target::disable_btrace):
6518         Update.
6519         (extended_remote_target::attach): Update.
6520         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6521         type.
6522         (gdbsim_target::pid_to_str): Change return type.
6523         * ravenscar-thread.c (struct ravenscar_thread_target)
6524         <pid_to_str>: Change return type.
6525         (ravenscar_thread_target::pid_to_str): Change return type.
6526         * procfs.c (class procfs_target) <pid_to_str>: Change return
6527         type.
6528         (procfs_target::pid_to_str): Change return type.
6529         (procfs_target::attach): Update.
6530         (procfs_target::detach): Update.
6531         (procfs_target::fetch_registers): Update.
6532         (procfs_target::store_registers): Update.
6533         (procfs_target::wait): Update.
6534         (procfs_target::files_info): Update.
6535         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6536         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6537         return type.
6538         (nto_procfs_target::pid_to_str): Change return type.
6539         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6540         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6541         return type.
6542         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6543         (exit_lwp): Update.
6544         (attach_proc_task_lwp_callback, get_detach_signal)
6545         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6546         (linux_nat_target::resume, wait_lwp, stop_callback)
6547         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6548         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6549         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6550         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6551         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6552         type.
6553         (inf_ptrace_target::attach): Update.
6554         (inf_ptrace_target::files_info): Update.
6555         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6556         type.
6557         (go32_nat_target::pid_to_str): Change return type.
6558         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6559         (gnu_nat_target::wait): Update.
6560         (gnu_nat_target::wait): Update.
6561         (gnu_nat_target::resume): Update.
6562         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6563         (fbsd_nat_target::wait): Update.
6564         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6565         type.
6566         (darwin_nat_target::attach): Update.
6567         * corelow.c (class core_target) <pid_to_str>: Change return type.
6568         (core_target::pid_to_str): Change return type.
6569         * target.c (normal_pid_to_str): Change return type.
6570         (default_pid_to_str): Likewise.
6571         (target_pid_to_str): Change return type.
6572         (target_translate_tls_address): Update.
6573         (target_announce_detach): Update.
6574         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6575         return type.
6576         (bsd_uthread_target::pid_to_str): Change return type.
6577         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6578         type.
6579         (bsd_kvm_target::pid_to_str): Change return type.
6580         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6581         return type.
6582         (aix_thread_target::pid_to_str): Change return type.
6583         * target.h (struct target_ops) <pid_to_str>: Change return type.
6584         (target_pid_to_str, normal_pid_to_str): Likewise.
6585         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6586         type.
6587         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6588         type.
6589         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6590         return type.
6591         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6592         type.
6593         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6594         type.
6595         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6596         return type.
6597
6598 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6599
6600         * NEWS: Mention that the new default MI version is 3.  Mention
6601         changes to the output of commands and events that deal with
6602         multi-location breakpoints.
6603         * breakpoint.c: Include "mi/mi-out.h".
6604         (print_one_breakpoint): Change output syntax if using MI version
6605         >= 3.
6606         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6607         New.
6608         (mi_multi_location_breakpoint_output_fixed): New.
6609         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6610         (mi_cmd_fix_multi_location_breakpoint_output): New.
6611         (mi_multi_location_breakpoint_output_fixed): New.
6612         * mi/mi-cmds.c (mi_cmds): Register command
6613         -fix-multi-location-breakpoint-output.
6614         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6615         interpreter "mi".
6616
6617 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6618
6619         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6620         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6621         instantiate mi_ui_out based on interpreter name.
6622         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6623         * mi/mi-main.c (mi_load_progress): Likewise.
6624
6625 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6626
6627         * NEWS: Combine separate "New targets" sections for 8.3.
6628
6629 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6630
6631         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6632         (ppcfbsd_init_abi): Install gdbarch
6633         "fetch_tls_load_module_address" and "get_thread_local_address"
6634         methods.
6635
6636 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6637
6638         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6639         (riscv_fbsd_init_abi): Install gdbarch
6640         "fetch_tls_load_module_address" and "get_thread_local_address"
6641         methods.
6642
6643 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6644
6645         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6646         (i386fbsd_init_abi): Install gdbarch
6647         "fetch_tls_load_module_address" and "get_thread_local_address"
6648         methods.
6649
6650 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6651
6652         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6653         (amd64fbsd_init_abi): Install gdbarch
6654         "fetch_tls_load_module_address" and "get_thread_local_address"
6655         methods.
6656
6657 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6658
6659         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6660         (struct fbsd_pspace_data): New type.
6661         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6662         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6663         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6664         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6665         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6666
6667 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6668
6669         * gdbtypes.c (lookup_struct_elt): New function.
6670         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6671         * gdbtypes.h (struct struct_elt): New type.
6672         (lookup_struct_elt): New prototype.
6673
6674 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6675
6676         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6677         remove disabled code block.
6678
6679 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6680
6681         * gdbarch.sh (get_thread_local_address): New method.
6682         * gdbarch.h, gdbarch.c: Regenerate.
6683         * target.c (target_translate_tls_address): Use
6684         gdbarch_get_thread_local_address if present instead of
6685         target::get_thread_local_address.
6686
6687 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6688
6689         * target.h (target::get_thread_local_address): Update comment.
6690
6691 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6692
6693         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6694         objfile->separate_debug_objfile_backlink if not NULL.
6695
6696 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6697
6698         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6699         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6700         (amd64bsd_store_inferior_registers): Likewise.
6701         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6702         Enable segment base registers.
6703         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6704         PT_GETFSBASE and PT_GETGSBASE.
6705         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6706         PT_SETGSBASE.
6707         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6708         segment base registers.
6709         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6710
6711 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6712
6713         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6714         Update calls to i386_target_description to add 'segments'
6715         parameter.
6716         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6717         add segment base registers.
6718         * arch/i386.c (i386_create_target_description): Add 'segments'
6719         parameter to enable segment base registers.
6720         * arch/i386.h (i386_create_target_description): Likewise.
6721         * features/i386/32bit-segments.xml: New file.
6722         * features/i386/32bit-segments.c: Generate.
6723         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6724         call to i386_target_description to add 'segments' parameter.
6725         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6726         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6727         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6728         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6729         if feature is present.
6730         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6731         Add 'segments' parameter to call to i386_target_description.
6732         (i386_target_description): Add 'segments' parameter to enable
6733         segment base registers.
6734         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6735         to call to i386_target_description.
6736         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6737         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6738         Define I386_NUM_REGS.
6739         (i386_target_description): Add 'segments' parameter to enable
6740         segment base registers.
6741
6742 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6743
6744         PR/24325
6745         * source-cache.c: #undef open and close, to avoid unresolved
6746         externals during linking.
6747
6748 2019-03-12  Tom Tromey  <tromey@adacore.com>
6749
6750         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6751         const.  Add initializers.
6752         (_initialize_remote): Don't initialize ptid globals.
6753
6754 2019-03-12  Pedro Alves  <palves@redhat.com>
6755
6756         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6757
6758 2019-03-12  Pedro Alves  <palves@redhat.com>
6759
6760         * cp-name-parser.y (main): Remove unused 'len' variable.
6761
6762 2019-03-12  Tom Tromey  <tromey@adacore.com>
6763
6764         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6765         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6766
6767 2019-03-12  Tom Tromey  <tromey@adacore.com>
6768
6769         * linux-nat.c (iterate_over_lwps): Update.
6770         (stop_callback): Remove parameter.
6771         (stop_wait_callback, detach_callback, resume_set_callback)
6772         (select_singlestep_lwp_callback, set_ignore_sigint)
6773         (status_callback, resumed_callback, resume_clear_callback)
6774         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6775         data parameter.
6776         (linux_nat_target::detach, linux_nat_target::resume)
6777         (linux_stop_and_wait_all_lwps, select_event_lwp)
6778         (linux_nat_filter_event, linux_nat_wait_1)
6779         (linux_nat_target::kill, linux_nat_target::stop)
6780         (linux_nat_target::stop): Update.
6781         (linux_nat_resume_callback): Change type.
6782         (resume_stopped_resumed_lwps, count_events_callback)
6783         (select_event_lwp_callback): Likewise.
6784         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6785         * arm-linux-nat.c (struct update_registers_data): Remove.
6786         (update_registers_callback): Change type.
6787         (arm_linux_insert_hw_breakpoint1): Update.
6788         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6789         parameter.
6790         (x86_linux_dr_set_addr): Update.
6791         (x86_linux_dr_set_control): Update.
6792         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6793         (iterate_over_lwps): Use gdb::function_view.
6794         * nat/aarch64-linux-hw-point.c (struct
6795         aarch64_dr_update_callback_param): Remove.
6796         (debug_reg_change_callback): Change type.
6797         (aarch64_notify_debug_reg_change): Update.
6798         * s390-linux-nat.c (s390_refresh_per_info): Update.
6799
6800 2019-03-11  Tom Tromey  <tromey@adacore.com>
6801
6802         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6803         redundant assignment to "this_cu".
6804
6805 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6806
6807         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6808
6809 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6810
6811         * gdbtypes.c (rank_one_type_parm_set): New function extracted
6812         from...
6813         (rank_one_type): ... this.
6814
6815 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6816
6817         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6818         from...
6819         (rank_one_type): ... this.
6820
6821 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6822
6823         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6824         from...
6825         (rank_one_type): ... this.
6826
6827 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6828
6829         * gdbtypes.c (rank_one_type_parm_float): New function extracted
6830         from...
6831         (rank_one_type): ... this.
6832
6833 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6834
6835         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6836         from...
6837         (rank_one_type): ... this.
6838
6839 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6840
6841         * gdbtypes.c (rank_one_type_parm_range): New function extracted
6842         from...
6843         (rank_one_type): ... this.
6844
6845 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6846
6847         * gdbtypes.c (rank_one_type_parm_char): New function extracted
6848         from...
6849         (rank_one_type): ... this.
6850
6851 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6852
6853         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
6854         from...
6855         (rank_one_type): ... this.
6856
6857 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6858
6859         * gdbtypes.c (rank_one_type_parm_int): New function extracted
6860         from...
6861         (rank_one_type): ... this.
6862
6863 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6864
6865         * gdbtypes.c (rank_one_type_parm_func): New function extracted
6866         from...
6867         (rank_one_type): ... this.
6868
6869 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6870
6871         * gdbtypes.c (rank_one_type_parm_array): New function extracted
6872         from...
6873         (rank_one_type): ... this.
6874
6875 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6876
6877         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
6878         from...
6879         (rank_one_type): ... this.
6880
6881 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6882
6883         * inferior.c (initialize_inferiors): Ensure 'help set/show print
6884         inferior-events' shows the example events.
6885
6886 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
6887
6888         Support styling on native MS-Windows console
6889
6890         PR/24315
6891         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
6892         on MS-Windows if $TERM is not defined.
6893
6894         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
6895
6896         * posix-hdep.c (gdb_console_fputs):
6897         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
6898         functions.
6899         * ui-file.h (gdb_console_fputs): Add prototype.
6900
6901         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
6902         back to fputs only if the former returns zero.
6903
6904 2019-03-07  Tom Tromey  <tom@tromey.com>
6905
6906         * symmisc.c (print_symbol_bcache_statistics): Update.
6907         (print_objfile_statistics): Update.
6908         * symfile.c (allocate_symtab): Update.
6909         * stabsread.c: Don't include bcache.h.
6910         * psymtab.h (struct psymbol_bcache): Don't declare.
6911         (class psymtab_storage) <psymbol_cache>: Now a bcache.
6912         (psymbol_bcache_init, psymbol_bcache_free)
6913         (psymbol_bcache_get_bcache): Don't declare.
6914         * psymtab.c (struct psymbol_bcache): Remove.
6915         (psymtab_storage::psymtab_storage): Update.
6916         (psymtab_storage::~psymtab_storage): Update.
6917         (psymbol_bcache_init, psymbol_bcache_free)
6918         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
6919         (add_psymbol_to_bcache): Update.
6920         (allocate_psymtab): Update.
6921         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6922         macro_cache>: No longer pointers.
6923         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
6924         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
6925         * macrotab.c (macro_bcache): Update.
6926         * macroexp.c: Don't include bcache.h.
6927         * gdbtypes.c (check_types_worklist): Update.
6928         (types_deeply_equal): Remove TRY/CATCH.  Update.
6929         * elfread.c (elf_symtab_read): Update.
6930         * dwarf2read.c: Don't include bcache.h.
6931         * buildsym.c (buildsym_compunit::get_macro_table): Update.
6932         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
6933         (print_bcache_statistics, bcache_memory_used): Don't declare.
6934         (struct bcache): Move from bcache.c.  Add constructor, destructor,
6935         methods.  Rename all data members.
6936         * bcache.c (struct bcache): Move to bcache.h.
6937         (bcache::expand_hash_table): Rename from expand_hash_table.
6938         (bcache): Remove.
6939         (bcache::insert): Rename from bcache_full.
6940         (bcache::compare): Rename from bcache_compare.
6941         (bcache_xmalloc): Remove.
6942         (bcache::~bcache): Rename from bcache_xfree.
6943         (bcache::print_statistics): Rename from print_bcache_statistics.
6944         (bcache::memory_used): Rename from bcache_memory_used.
6945
6946 2019-03-07  Pedro Alves  <palves@redhat.com>
6947
6948         * infrun.c (normal_stop): Also check for
6949         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
6950
6951 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
6952
6953         * f-lang.c (value_from_host_double): Moved to...
6954         * value.c (value_from_host_double): ...here.
6955         * value.h (value_from_host_double): Declare.
6956         * guile/scm-math.c (vlscm_convert_typed_number): Use
6957         value_from_host_double.
6958         (vlscm_convert_number): Likewise.
6959         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
6960         * python/py-value.c (convert_value_from_python): Likewise.
6961
6962 2019-03-06  Tom Tromey  <tom@tromey.com>
6963
6964         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
6965
6966 2019-03-06  Tom Tromey  <tom@tromey.com>
6967
6968         * utils.h (free_current_contents): Don't declare.
6969         * utils.c (free_current_contents): Remove.
6970
6971 2019-03-06  Tom Tromey  <tom@tromey.com>
6972
6973         * top.c (quit_force): Update.
6974         * main.c (captured_command_loop): Update.
6975         * common/new-op.c (operator new): Update.
6976         * common/common-exceptions.c (struct catcher)
6977         <save_cleanup_chain>: Remove member.
6978         (exceptions_state_mc_init): Update.
6979         (exception_try_scope_entry): Return nullptr.
6980         (exception_try_scope_exit, exception_rethrow)
6981         (throw_exception_sjlj, throw_exception_cxx): Update.
6982         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
6983         (all_cleanups, do_cleanups, discard_cleanups)
6984         (discard_final_cleanups, save_cleanups, save_final_cleanups)
6985         (restore_cleanups, restore_final_cleanups): Don't declare.
6986         (do_final_cleanups): Remove parameter.
6987         * common/cleanups.c (cleanup_chain, make_cleanup)
6988         (make_cleanup_dtor, all_cleanups, do_cleanups)
6989         (discard_my_cleanups, discard_cleanups)
6990         (discard_final_cleanups, save_my_cleanups, save_cleanups)
6991         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
6992         (null_cleanup): Remove.
6993         (do_final_cleanups): Remove parameter.
6994
6995 2019-03-06  Tom Tromey  <tom@tromey.com>
6996
6997         * remote.c (remote_target::remote_parse_stop_reply): Use
6998         unique_xmalloc_ptr.
6999
7000 2019-03-06  Tom Tromey  <tom@tromey.com>
7001
7002         * stabsread.c (struct stabs_field_info): Rename from field_info.
7003         <list, fnlist>: Add initializers.
7004         <obstack>: New member.
7005         (read_member_functions, read_struct_fields, read_baseclasses):
7006         Allocate on obstack.  Don't use cleanups.
7007         (read_one_struct_field, read_member_functions, read_struct_fields)
7008         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7009         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7010         (read_struct_type): Update.
7011
7012 2019-03-06  Tom Tromey  <tom@tromey.com>
7013
7014         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7015         * common/filestuff.h (make_cleanup_close): Don't declare.
7016         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7017         Remove.
7018
7019 2019-03-06  Tom Tromey  <tom@tromey.com>
7020
7021         * solib-aix.c: Use make_scope_exit.
7022
7023 2019-03-06  Tom Tromey  <tom@tromey.com>
7024
7025         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7026         Use make_scope_exit.
7027
7028 2019-03-06  Tom Tromey  <tom@tromey.com>
7029
7030         * solib-svr4.c (disable_probes_interface): Remove parameter.
7031         (svr4_handle_solib_event): Use make_scope_exit.
7032
7033 2019-03-06  Tom Tromey  <tom@tromey.com>
7034
7035         * remote.c (struct stop_reply_deleter): Remove.
7036         (stop_reply_up): Update.
7037         (struct stop_reply): Derive from notif_event.  Don't typedef.
7038         <regcache>: Now a std::vector.
7039         (stop_reply_xfree): Remove.
7040         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7041         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7042         (remote_target::discard_pending_stop_replies): Use delete.
7043         (remote_target::remote_parse_stop_reply): Update.
7044         (remote_target::process_stop_reply): Update.
7045         * remote-notif.h (struct notif_event): Add virtual destructor.
7046         Remove "dtr" member.
7047         (struct notif_client) <alloc_event>: Return a unique_ptr.
7048         (notif_event_xfree): Don't declare.
7049         (notif_event_up): New typedef.
7050         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7051         (notif_event_xfree, do_notif_event_xfree): Remove.
7052         (remote_notif_state_xfree): Update.
7053
7054 2019-03-06  Tom Tromey  <tom@tromey.com>
7055
7056         * infrun.c (displaced_step_clear_cleanup): Now a
7057         forward_scope_exit type.
7058         (displaced_step_prepare_throw): Update.
7059         (displaced_step_fixup): Update.
7060
7061 2019-03-06  Tom Tromey  <tom@tromey.com>
7062
7063         * inferior.h (class inferior): Update comment.
7064         * gdbthread.h (class thread_info): Update comment.
7065
7066 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7067             Tom Tromey  <tom@tromey.com>
7068
7069         * stabsread.h (struct stab_section_list): Remove.
7070         (coffstab_build_psymtabs): Update.
7071         * dbxread.c (symbuf_sections): Now a std::vector.
7072         (sect_idx): New global.
7073         (fill_symbuf): Update.
7074         (coffstab_build_psymtabs): Change type of stabsects parameter.
7075         Update.
7076         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7077         std::vector.
7078         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7079         (coff_locate_sections): Update.
7080         (coff_symfile_read): Remove cleanups.  Update.
7081         (init_stringtab): Add storage parameter.
7082         (free_stringtab, free_stringtab_cleanup): Remove.
7083         (init_lineno): Add storage parameter.
7084         (free_linetab, free_linetab_cleanup): Remove.
7085
7086 2019-03-06  Pedro Alves  <palves@redhat.com>
7087
7088         * linux-fork.c (fork_info::clobber_regs): Delete.
7089         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7090         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7091         comment.  Adjust.
7092         (scoped_switch_fork_info::scoped_switch_fork_info)
7093         (checkpoint_command, linux_fork_context): Adjust
7094         fork_save_infrun_state calls.
7095
7096 2019-03-06  Pedro Alves  <palves@redhat.com>
7097
7098         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7099         (inf_has_multiple_threads): Return 'bool' and rewrite using
7100         inferior_info::threads().
7101
7102 2019-03-06  Pedro Alves  <palves@redhat.com>
7103
7104         * linux-fork.c: Include <list>.
7105         (fork_list): Now a std::list instance.
7106         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7107         (forks_exist_p, find_last_fork): Adjust.
7108         (new_fork): Delete.
7109         (one_fork_p): New.
7110         (add_fork): Adjust.
7111         (free_fork): Delete, folded into fork_info::~fork_info().
7112         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7113         Adjust.
7114         (init_fork_list): Delete.
7115         (linux_fork_killall, linux_fork_mourn_inferior)
7116         (linux_fork_detach, info_checkpoints_command): Adjust.
7117         (_initialize_linux_fork): No longer call init_fork_list.
7118
7119 2019-03-06  Pedro Alves  <palves@redhat.com>
7120
7121         * linux-fork.c (new_fork): New, split out of ...
7122         (add_fork): ... this.  Return void.  Move "first fork" special
7123         case from here, to ...
7124         (checkpoint_command): ... here.
7125         * linux-linux.h (add_fork): Return void.
7126
7127 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7128
7129         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7130
7131 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7132             Chris January  <chris.january@arm.com>
7133             David Lecomber  <david.lecomber@arm.com>
7134
7135         * f-exp.y: New token, UNOP_INTRINSIC.
7136         (exp): New pattern using UNOP_INTRINSIC token.
7137         (f77_keywords): Add 'abs' keyword.
7138         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7139         (value_from_host_double): New function.
7140         (evaluate_subexp_f): Support UNOP_ABS.
7141
7142 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7143
7144         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7145         types.
7146
7147 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7148
7149         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7150         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7151         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7152
7153 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7154
7155         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7156
7157 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7158             Chris January  <chris.january@arm.com>
7159
7160         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7161         * f-exp.y: Define 'KIND' token.
7162         (exp): New pattern for KIND expressions.
7163         (ptype): Handle types with a kind extension.
7164         (direct_abs_decl): Extend to spot kind extensions.
7165         (f77_keywords): Add 'kind' to the list.
7166         (push_kind_type): New function.
7167         (convert_to_kind_type): New function.
7168         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7169         * parse.c (operator_length_standard): Likewise.
7170         * parser-defs.h (enum type_pieces): Add tp_kind.
7171         * std-operator.def: Add UNOP_KIND.
7172
7173 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7174
7175         * f-exp.y (f_parse): Set yydebug.
7176
7177 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7178
7179         * f-lang.c (evaluate_subexp_f): New function.
7180         (exp_descriptor_f): New global.
7181         (f_language_defn): Use exp_descriptor_f instead of
7182         exp_descriptor_standard.
7183
7184 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7185
7186         * f-exp.y (struct token): Add comments.
7187         (dot_ops): Remove uppercase versions and the end marker.
7188         (f77_keywords): Likewise.
7189         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7190         entries in the dot_ops array are case insensitive, and use
7191         strncasecmp to compare strings.  Also some whitespace cleanup in
7192         this area.  Similar for the f77_keywords array, except entries in
7193         this list might be case sensitive.
7194
7195 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7196
7197         * f-exp.y (struct f77_boolean_val): Add comments.
7198         (boolean_values): Remove uppercase versions, and end marker.
7199         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7200         and use strncasecmp to achieve case insensitivity.  Additionally,
7201         perform whitespace cleanup around this code.
7202
7203 2019-03-06  Tom Tromey  <tromey@adacore.com>
7204
7205         * remote-sim.c (gdbsim_target_open): Use result of
7206         gdb_argv::release.
7207
7208 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7209         Dirk Schubert  <dirk.schubert@arm.com>
7210         Chris January  <chris.january@arm.com>
7211
7212         * eval.c (evaluate_subexp_standard): Call Fortran argument
7213         wrapping logic.
7214         * f-lang.c (struct value): A value which can be passed into a
7215         Fortran function call.
7216         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7217         where appropriate.
7218         (struct type): Value ready for a Fortran function call.
7219         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7220         is needed.
7221         * f-lang.h (fortran_argument_convert): Declaration.
7222         (fortran_preserve_arg_pointer): Declaration.
7223         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7224
7225 2019-03-05  Tom Tromey  <tromey@adacore.com>
7226
7227         * python/py-prettyprint.c (print_string_repr): Remove #if.
7228         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7229
7230 2019-03-05  Tom Tromey  <tromey@adacore.com>
7231
7232         * target.c (the_dummy_target): Move later.  Change type to
7233         "dummy_target".
7234         (initialize_targets): Don't initialize the_dummy_target.
7235
7236 2019-03-05  Tom Tromey  <tromey@adacore.com>
7237
7238         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7239         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7240
7241 2019-03-05  Tom Tromey  <tromey@adacore.com>
7242
7243         * windows-nat.c (windows_nat_target::attach)
7244         (windows_nat_target::detach): Don't call gdb_flush.
7245         * valprint.c (generic_val_print, val_print, val_print_string):
7246         Don't call gdb_flush.
7247         * utils.c (defaulted_query): Don't call gdb_flush.
7248         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7249         * target.c (target_announce_detach): Don't call gdb_flush.
7250         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7251         * remote.c (extended_remote_target::attach): Don't call
7252         gdb_flush.
7253         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7254         * printcmd.c (do_examine): Don't call gdb_flush.
7255         (info_display_command): Don't call gdb_flush.
7256         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7257         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7258         * memattr.c (info_mem_command): Don't call gdb_flush.
7259         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7260         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7261         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7262         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7263         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7264         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7265         (gnu_nat_target::detach): Don't call gdb_flush.
7266         * f-valprint.c (f_val_print): Don't call gdb_flush.
7267         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7268         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7269         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7270         gdb_flush.
7271         * c-valprint.c (c_val_print): Don't call gdb_flush.
7272         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7273
7274 2019-03-05  Tom Tromey  <tromey@adacore.com>
7275
7276         * varobj.c (update_dynamic_varobj_children): Update.
7277         (install_default_visualizer): Use reset, not release.
7278         * value.c (set_internalvar): Update.
7279         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7280         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7281         ATTRIBUTE_UNUSED_RESULT.
7282
7283 2019-03-05  Tom Tromey  <tromey@adacore.com>
7284
7285         * remote.c (class scoped_remote_fd) <release>: Add
7286         ATTRIBUTE_UNUSED_RESULT.
7287
7288 2019-03-05  Tom Tromey  <tromey@adacore.com>
7289
7290         * macroexp.c (struct macro_buffer) <release>: Add
7291         ATTRIBUTE_UNUSED_RESULT.
7292
7293 2019-03-05  Tom Tromey  <tromey@adacore.com>
7294
7295         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7296         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7297         ATTRIBUTE_UNUSED_RESULT.
7298
7299 2019-03-05  Tom Tromey  <tromey@adacore.com>
7300
7301         * common/scoped_fd.h (class scoped_fd) <release>: Add
7302         ATTRIBUTE_UNUSED_RESULT.
7303
7304 2019-03-05  Tom Tromey  <tromey@adacore.com>
7305
7306         * parser-defs.h (struct parser_state) <release>: Add
7307         ATTRIBUTE_UNUSED_RESULT.
7308
7309 2019-03-05  Tom Tromey  <tromey@adacore.com>
7310
7311         * utils.h (class gdb_argv) <release>: Add
7312         ATTRIBUTE_UNUSED_RESULT.
7313         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7314
7315 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7316
7317         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7318         for-loop range, to avoid compiler warnings.
7319
7320         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7321         avoid compiler warnings about unused variables.
7322
7323         * NEWS: Mention end of support for native debugging on MS-Windows
7324         before XP.
7325
7326         PR gdb/24292
7327         * common/netstuff.c:
7328         * gdbserver/gdbreplay.c
7329         * gdbserver/remote-utils.c:
7330         * ser-tcp.c:
7331         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7332         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7333         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7334         'getaddrinfo' and 'freeaddrinfo' were not available before
7335         Windows XP, and mingw.org's MinGW headers by default define
7336         _WIN32_WINNT to 0x500.
7337
7338 2019-03-01  Gary Benson <gbenson@redhat.com>
7339
7340         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7341
7342 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7343             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7344
7345         PR gdb/8527
7346         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7347         set_sigint_trap, clear_sigint_trap.
7348
7349 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7350
7351         * target.c (target_detach): Clear the regcache and the
7352         frame cache.
7353
7354 2019-02-27  Pedro Alves  <palves@redhat.com>
7355
7356         * utils.c (set_screen_size): When we cap the height/width sizes,
7357         tweak the corresponding command variable to show "unlimited":
7358
7359 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7360             Pedro Alves  <palves@redhat.com>
7361
7362         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7363         before calling rl_set_screen_size.
7364
7365 2019-02-27  Tom Tromey  <tromey@adacore.com>
7366
7367         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7368         define.
7369         * python/py-value.c: Remove Python 2.4 workaround.
7370         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7371         workaround.
7372         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7373         Python 2.4 workaround.
7374         * python/python-internal.h: Remove Python 2.4 comment.
7375         (Py_ssize_t): Don't define.
7376         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7377         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7378         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7379         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7380         * python/python.c (do_start_initialization): Remove Python 2.4
7381         workaround.
7382         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7383         (print_children): Remove Python 2.4 workaround.
7384         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7385         workaround.
7386         (CHARBUFFERPROC_NAME): Remove.
7387         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7388         Python 2.4 workaround.
7389
7390 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7391
7392         * NEWS: Note minimum Python version.
7393
7394 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7395
7396         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7397         code from these functions.  Remove corresponding ifdefs.  Use
7398         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7399         Remove gotos and target of gotos.
7400         (infpy_search_memory): Likewise.
7401
7402 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7403
7404         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7405         (hppa_gdbarch_init): Don't register deleted functions with
7406         gdbarch.
7407
7408 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7409
7410         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7411         (h8300_unwind_sp): Delete.
7412         (h8300_dummy_id): Delete.
7413         (h8300_gdbarch_init): Don't register deleted functions with
7414         gdbarch.
7415
7416 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7417
7418         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7419         (ft32_unwind_pc): Delete.
7420         (ft32_unwind_sp): Delete.
7421         (ft32_gdbarch_init): Don't register deleted functions with
7422         gdbarch.
7423
7424 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7425
7426         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7427         (frv_unwind_pc): Delete.
7428         (frv_unwind_sp): Delete.
7429         (frv_gdbarch_init): Don't register deleted functions with
7430         gdbarch.
7431
7432 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7433
7434         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7435         (riscv_unwind_pc): Delete.
7436         (riscv_unwind_sp): Delete.
7437         (riscv_gdbarch_init): Don't register deleted functions with
7438         gdbarch.
7439
7440 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7441
7442         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7443         (csky_unwind_pc): Delete.
7444         (csky_unwind_sp): Delete.
7445         (csky_gdbarch_init): Don't register deleted functions with
7446         gdbarch.
7447
7448 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7449
7450         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7451         (cris_unwind_pc): Delete.
7452         (cris_unwind_sp): Delete.
7453         (cris_gdbarch_init): Don't register deleted functions with
7454         gdbarch.
7455
7456 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7457
7458         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7459         (bfin_unwind_pc): Delete.
7460         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7461
7462 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7463
7464         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7465         (arm_unwind_pc): Delete.
7466         (arm_unwind_sp): Delete.
7467         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7468
7469 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7470
7471         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7472         (arc_unwind_pc): Delete.
7473         (arc_unwind_sp): Delete.
7474         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7475
7476 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7477
7478         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7479         (alpha_unwind_pc): Delete.
7480         (alpha_gdbarch_init): Don't register deleted functions with
7481         gdbarch.
7482
7483 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7484
7485         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7486         (aarch64_unwind_pc): Delete.
7487         (aarch64_unwind_sp): Delete.
7488         (aarch64_gdbarch_init): Don't register deleted functions with
7489         gdbarch.
7490
7491 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7492
7493         * gdbtypes.c (type_align): Don't consider static members when
7494         computing structure alignment.
7495
7496 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7497
7498         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7499         return 0 for other types.
7500         * arch-utils.c (default_type_align): Always return 0.
7501         * gdbarch.h: Regenerate.
7502         * gdbarch.sh (type_align): Extend comment.
7503         * gdbtypes.c (type_align): Add additional comments, always call
7504         gdbarch_type_align before applying the default rules.
7505         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7506         generic code will then apply a suitable default.
7507         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7508         types, return 0 for other types.
7509
7510 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7511
7512         * NEWS: Create a new section for the next release branch.
7513         Rename the section of the current branch, now that it has
7514         been cut.
7515
7516 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7517
7518         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7519         * version.in: Bump version to 8.3.50.DATE-git.
7520
7521 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7522
7523         * aix-thread.c (ptid_cmp): Remove unused variable.
7524         (get_signaled_thread): Likewise.
7525         (store_regs_user_thread): Likewise.
7526         (store_regs_kernel_thread): Likewise.
7527         (fetch_regs_kernel_thread): Remove shadowed variable.
7528
7529 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7530
7531         * features/riscv/32bit-cpu.xml: Add register numbers.
7532         * features/riscv/32bit-fpu.c: Regenerate.
7533         * features/riscv/32bit-fpu.xml: Add register numbers.
7534         * features/riscv/64bit-cpu.xml: Add register numbers.
7535         * features/riscv/64bit-fpu.c: Regenerate.
7536         * features/riscv/64bit-fpu.xml: Add register numbers.
7537
7538 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7539
7540         * NEWS: Mention two argument form of gdb.Value constructor.
7541         * python/py-value.c (convert_buffer_and_type_to_value): New
7542         function.
7543         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7544         Add support for handling an optional second argument.  Call
7545         convert_buffer_and_type_to_value as appropriate.
7546         * python/python-internal.h (Py_buffer_deleter): New struct.
7547         (Py_buffer_up): New typedef.
7548
7549 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7550
7551         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7552         instead of releasing ownership.
7553
7554 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7555
7556         * dwarf2read.c (open_and_init_dwp_file): Call
7557         elf_numsections instead of bfd_count_sections to initialize
7558         dwp_file->num_sections.
7559
7560 2019-02-25  Tom Tromey  <tromey@adacore.com>
7561
7562         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7563
7564 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7565
7566         * gcore.in: Add '--readnever' option when invoking GDB.
7567
7568 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7569
7570         * MAINTAINERS: Update my email address.
7571
7572 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7573
7574         * build-id.c (build_id_to_debug_bfd_1): New function.
7575         (build_id_to_debug_bfd): Look for separate debug file in
7576         sysroot.
7577
7578 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7579
7580         * gdbarch.sh: Update the copyright year range that is placed into
7581         generated files.
7582
7583 2019-02-22  Keith Seitz  <keiths@redhat.com>
7584
7585         PR symtab/23853
7586         * linespec.c (create_sals_line_offset): Search for the default
7587         symtab's filename instead of its fullname.
7588
7589 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7590
7591         * NEWS: Update style defaults.
7592
7593 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7594
7595         * main.c (captured_main_1): Disable styling in batch mode.
7596
7597 2019-02-20  Tom Tromey  <tom@tromey.com>
7598
7599         * symtab.c (symtab_symbol_info): Fix typos.
7600
7601 2019-02-20  Tom Tromey  <tromey@adacore.com>
7602
7603         * findcmd.c (_initialize_mem_search): Use upper case for
7604         metasyntactic variables.
7605
7606 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7607
7608         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7609         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7610
7611 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7612
7613         * top.h (source_file_name): Change to std::string.
7614         * top.c (source_file_name): Likewise.
7615         (command_line_input): Adjust.
7616         * cli/cli-script.c (script_from_file): Adjust.
7617
7618 2019-02-19  Tom Tromey  <tromey@adacore.com>
7619
7620         * ravenscar-thread.c
7621         (ravenscar_thread_target::update_thread_list): Don't call
7622         ada_build_task_list.
7623         * ada-lang.h (ada_build_task_list): Don't declare.
7624         * ada-tasks.c (struct ada_tasks_inferior_data)
7625         <task_list_valid_p>: Now bool.
7626         (read_known_tasks, ada_task_list_changed)
7627         (ada_tasks_invalidate_inferior_data): Update.
7628         (read_known_tasks_array): Return bool.
7629         (read_known_tasks_list): Likewise.
7630         (read_known_tasks): Return void.
7631         (ada_build_task_list): Now static.
7632
7633 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7634
7635         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7636         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7637
7638 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7639
7640         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7641         variant for ada_tasks_pspace_data_handle and
7642         ada_tasks_inferior_data_handle.
7643         (ada_tasks_pspace_data_cleanup): New function.
7644         (ada_tasks_inferior_data_cleanup): New function.
7645
7646 2019-02-17  Tom Tromey  <tom@tromey.com>
7647
7648         * macrotab.h (macro_source_fullname): Return a std::string.
7649         * macrotab.c (macro_include, check_for_redefinition)
7650         (macro_undef, macro_lookup_definition, foreach_macro)
7651         (foreach_macro_in_scope): Update.
7652         (macro_source_fullname): Return a std::string.
7653         * macrocmd.c (show_pp_source_pos): Update.
7654
7655 2019-02-17  Tom Tromey  <tom@tromey.com>
7656
7657         * macrocmd.c (show_pp_source_pos): Style the file names.
7658
7659 2019-02-17  Tom Tromey  <tom@tromey.com>
7660
7661         PR tui/24197:
7662         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7663
7664 2019-02-17  Tom Tromey  <tom@tromey.com>
7665
7666         * ada-lang.c (user_select_syms): Use filtered printing.
7667         * utils.c (wrap_style): New global.
7668         (desired_style): Remove.
7669         (emit_style_escape): Add stream parameter.
7670         (set_output_style, reset_terminal_style, prompt_for_continue):
7671         Update.
7672         (flush_wrap_buffer): Only flush gdb_stdout.
7673         (wrap_here): Set wrap_style.
7674         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7675         treat escape sequences as a character.  Change when wrap buffer is
7676         flushed.
7677         (fputs_styled): Do not set the output style when the default is
7678         requested.
7679         * ui-style.h (struct ui_file_style) <is_default>: New method.
7680         * source.c (print_source_lines_base): Emit escape sequences in one
7681         piece.
7682
7683 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7684
7685         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7686         integers and enumeration types.
7687
7688 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7689
7690         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7691         instead of lookup_symbol_in_language
7692         (do_exact_match): New function.
7693         (ada_get_symbol_name_matcher): Return do_exact_match when
7694         doing a verbatim match.
7695
7696 2019-02-15  Tom Tromey  <tromey@adacore.com>
7697
7698         * ravenscar-thread.c (ravenscar_thread_target::resume)
7699         (ravenscar_thread_target::wait): Special case wildcard requests.
7700
7701 2019-02-15  Tom Tromey  <tromey@adacore.com>
7702
7703         * ravenscar-thread.c (base_ptid): Remove.
7704         (struct ravenscar_thread_target) <close>: New method.
7705         <m_base_ptid>: New member.
7706         <update_inferior_ptid, active_task, task_is_currently_active,
7707         runtime_initialized>: Declare methods.
7708         <ravenscar_thread_target>: Add constructor.
7709         (ravenscar_thread_target::task_is_currently_active)
7710         (ravenscar_thread_target::update_inferior_ptid)
7711         (ravenscar_runtime_initialized): Rename.  Now methods.
7712         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7713         (ravenscar_thread_target::update_thread_list): Update.
7714         (ravenscar_thread_target::active_task): Now method.
7715         (ravenscar_thread_target::store_registers)
7716         (ravenscar_thread_target::prepare_to_store)
7717         (ravenscar_thread_target::prepare_to_store)
7718         (ravenscar_thread_target::mourn_inferior): Update.
7719         (ravenscar_inferior_created): Use "new" to create target.
7720         (ravenscar_thread_target::get_ada_task_ptid): Update.
7721         (_initialize_ravenscar): Don't initialize base_ptid.
7722         (ravenscar_ops): Remove global.
7723
7724 2019-02-15  Tom Tromey  <tromey@adacore.com>
7725
7726         * target.h (push_target): Declare new overload.
7727         * target.c (push_target): New overload, taking an rvalue reference.
7728         * remote.c (remote_target::open_1): Use push_target overload.
7729         * corelow.c (core_target_open): Use push_target overload.
7730
7731 2019-02-15  Tom Tromey  <tromey@adacore.com>
7732
7733         * ravenscar-thread.c (is_ravenscar_task)
7734         (ravenscar_task_is_currently_active): Return bool.
7735         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7736         (_initialize_ravenscar): Remove "(void)".
7737         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7738         Return bool.
7739
7740 2019-02-15  Tom Tromey  <tromey@adacore.com>
7741
7742         * ravenscar-thread.c (ravenscar_runtime_initializer)
7743         (has_ravenscar_runtime, get_running_thread_id)
7744         (ravenscar_thread_target::resume): Fix indentation.
7745
7746 2019-02-15  Tom Tromey  <tromey@adacore.com>
7747
7748         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7749         from ravenscar_arch_ops.
7750         (sparc_ravenscar_ops::fetch_registers)
7751         (sparc_ravenscar_ops::store_registers): Now methods.
7752         (sparc_ravenscar_prepare_to_store): Remove.
7753         (sparc_ravenscar_ops): Redefine.
7754         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7755         methods and destructor.  Remove members.
7756         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7757         (ravenscar_thread_target::store_registers)
7758         (ravenscar_thread_target::prepare_to_store): Update.
7759         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7760         Remove.
7761         (struct ppc_ravenscar_powerpc_ops): Derive from
7762         ravenscar_arch_ops.
7763         (ppc_ravenscar_powerpc_ops::fetch_registers)
7764         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7765         (ppc_ravenscar_powerpc_ops): Redefine.
7766         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7767         (ppc_ravenscar_e500_ops::fetch_registers)
7768         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7769         (ppc_ravenscar_e500_ops): Redefine.
7770         * aarch64-ravenscar-thread.c
7771         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7772         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7773         (aarch64_ravenscar_fetch_registers)
7774         (aarch64_ravenscar_store_registers): Now methods.
7775         (aarch64_ravenscar_ops): Redefine.
7776
7777 2019-02-15  Tom Tromey  <tromey@adacore.com>
7778
7779         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7780         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7781         (ravenscar_thread_target::stopped_by_watchpoint)
7782         (ravenscar_thread_target::stopped_data_address)
7783         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7784
7785 2019-02-15  Tom Tromey  <tromey@adacore.com>
7786
7787         * ravenscar-thread.c: Fix some typos.
7788
7789 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7790             Tom Tromey  <tromey@adacore.com>
7791
7792         * ada-lang.c (ada_exception_sal): Change addr_string to a
7793         std::string.
7794         (create_ada_exception_catchpoint): Update.
7795
7796 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7797             Tom Tromey  <tromey@adacore.com>
7798
7799         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7800         (bp_location_ops): Remove.
7801         (base_breakpoint_allocate_location): Update.
7802         (free_bp_location): Update.
7803         * ada-lang.c (class ada_catchpoint_location)
7804         <ada_catchpoint_location>: Remove ops parameter.
7805         (ada_catchpoint_location_dtor): Remove.
7806         (ada_catchpoint_location_ops): Remove.
7807         (allocate_location_exception): Update.
7808         * breakpoint.h (struct bp_location_ops): Remove.
7809         (class bp_location) <bp_location>: Remove bp_location_ops
7810         parameter.
7811         <~bp_location>: Add destructor.
7812         <ops>: Remove.
7813
7814 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7815             Pedro Alves  <palves@redhat.com>
7816
7817         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7818         'PATH_MAX'.
7819
7820 2019-02-14  David Michael  <fedora.dm0@gmail.com>
7821             Samuel Thibault  <samuel.thibault@gnu.org>
7822             Thomas Schwinge  <thomas@codesourcery.com>
7823
7824         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7825         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
7826
7827 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7828
7829         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7830         (check_empty): Use "const char *".
7831
7832         * gnu-nat.c (gnu_nat_target::detach): Instead of
7833         'detach_inferior (pid)' call
7834         'detach_inferior (find_inferior_pid (pid))'.
7835
7836         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7837         'nat/fork-inferior.o'.
7838         * gnu-nat.c: #include "nat/fork-inferior.h".
7839
7840         * gnu-nat.c (gnu_nat_target::detach): Instead of
7841         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
7842         * gnu-nat.h: #include "inf-child.h".
7843         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
7844         'i386_gnu_nat_target::fetch_registers'.
7845         (gnu_store_registers): Rename/move to
7846         'i386_gnu_nat_target::store_registers'.
7847
7848         * config/i386/nm-i386gnu.h: Don't "#include" any files.
7849         * gnu-nat.h (mach_thread_info): New function.
7850         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
7851
7852         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
7853
7854 2019-02-14  Frederic Konrad  <konrad@adacore.com>
7855
7856         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
7857
7858 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
7859
7860         * windows-nat.c (windows_add_thread): Add new parameter
7861         "main_thread_p" with default value set to false.  Update
7862         function documentation as well as all callers.
7863         (windows_delete_thread): Likewise.
7864         (fake_create_process): Update call to windows_add_thread.
7865         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
7866         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
7867         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
7868         call to windows_delete_thread.
7869
7870 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
7871
7872         * MAINTAINERS: Add Andrew Burgess as global maintainer.
7873
7874 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7875
7876         * symfile.c (find_separate_debug_file): Use canonical path of
7877         sysroot with child_path instead of gdb_sysroot if it is valid.
7878
7879 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7880
7881         * symfile.c (find_separate_debug_file): Use child_path to
7882         determine if an object file is under a sysroot.
7883
7884 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7885
7886         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
7887         unittests/child-path-selftests.c.
7888         * common/pathstuff.c (child_path): New function.
7889         * common/pathstuff.h (child_path): New prototype.
7890         * unittests/child-path-selftests.c: New file.
7891
7892 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7893
7894         * symfile.c (find_separate_debug_file): Look for separate debug
7895         files in debug directories under the sysroot.
7896
7897 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7898
7899         * symtab.h (struct minimal_symbol data_p): New const method.
7900         (struct minimal_symbol text_p): Likewise.
7901         * symtab.c (output_source_filename): Use file name style
7902         to print file name.
7903         (print_symbol_info): Likewise.
7904         (print_msymbol_info): Use address style to print addresses.
7905         Use function name style to print executable text symbols.
7906         (expand_symtab_containing_pc): Use data_p.
7907         (find_pc_sect_compunit_symtab): Likewise.
7908
7909 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7910
7911         * breakpoint.c (describe_other_breakpoints): Use address style
7912         to print addresses.
7913         (say_where): Likewise.
7914
7915 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7916
7917         * ada-typeprint.c (print_func_type): Print function name
7918         style to print function name.
7919         * c-typeprint.c (c_print_type_1): Likewise.
7920
7921 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
7922
7923         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
7924         for execve.
7925
7926 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7927
7928         * c-exp.y (direct_abs_decl): Use emplace_back to record the
7929         type_stack.
7930
7931 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
7932
7933         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
7934         TYPE_CODE_REF types.
7935
7936 2019-02-08  Jim Wilson  <jimw@sifive.com>
7937
7938         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
7939         (riscv_linux_fregset): New.
7940         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
7941
7942 2019-02-07  Tom Tromey  <tom@tromey.com>
7943
7944         * thread.c (thread_cancel_execution_command): Update.
7945         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
7946         methods.
7947         (struct thread_fsm_ops): Remove.
7948         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
7949         (thread_fsm_should_stop, thread_fsm_return_value)
7950         (thread_fsm_set_finished, thread_fsm_finished_p)
7951         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
7952         Don't declare.
7953         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
7954         * infrun.c (clear_proceed_status_thread)
7955         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
7956         (print_stop_event): Update.
7957         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
7958         Add constructor.
7959         (step_command_fsm_ops): Remove.
7960         (new_step_command_fsm): Remove.
7961         (step_1): Update.
7962         (step_command_fsm::should_stop): Rename from
7963         step_command_fsm_should_stop.
7964         (step_command_fsm::clean_up): Rename from
7965         step_command_fsm_clean_up.
7966         (step_command_fsm::do_async_reply_reason): Rename from
7967         step_command_fsm_async_reply_reason.
7968         (struct until_next_fsm): Inherit from thread_fsm.  Add
7969         constructor.
7970         (until_next_fsm_ops): Remove.
7971         (new_until_next_fsm): Remove.
7972         (until_next_fsm::should_stop): Rename from
7973         until_next_fsm_should_stop.
7974         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
7975         (until_next_fsm::do_async_reply_reason): Rename from
7976         until_next_fsm_async_reply_reason.
7977         (struct finish_command_fsm): Inherit from thread_fsm.  Add
7978         constructor.  Change type of breakpoint.
7979         (finish_command_fsm_ops): Remove.
7980         (new_finish_command_fsm): Remove.
7981         (finish_command_fsm::should_stop): Rename from
7982         finish_command_fsm_should_stop.
7983         (finish_command_fsm::clean_up): Rename from
7984         finish_command_fsm_clean_up.
7985         (finish_command_fsm::return_value): Rename from
7986         finish_command_fsm_return_value.
7987         (finish_command_fsm::do_async_reply_reason): Rename from
7988         finish_command_fsm_async_reply_reason.
7989         (finish_command): Update.
7990         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
7991         Add constructor.
7992         (call_thread_fsm_ops): Remove.
7993         (call_thread_fsm::call_thread_fsm): Rename from
7994         new_call_thread_fsm.
7995         (call_thread_fsm::should_stop): Rename from
7996         call_thread_fsm_should_stop.
7997         (call_thread_fsm::should_notify_stop): Rename from
7998         call_thread_fsm_should_notify_stop.
7999         (run_inferior_call, call_function_by_hand_dummy): Update.
8000         * cli/cli-interp.c (should_print_stop_to_console): Update.
8001         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8002         Add constructor.  Change type of location_breakpoint,
8003         caller_breakpoint.
8004         (until_break_fsm_ops): Remove.
8005         (new_until_break_fsm): Remove.
8006         (until_break_fsm::should_stop): Rename from
8007         until_break_fsm_should_stop.
8008         (until_break_fsm::clean_up): Rename from
8009         until_break_fsm_clean_up.
8010         (until_break_fsm::do_async_reply_reason): Rename from
8011         until_break_fsm_async_reply_reason.
8012         (until_break_command): Update.
8013         * thread-fsm.c: Remove.
8014         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8015
8016 2019-02-07  Tom Tromey  <tom@tromey.com>
8017
8018         * yy-remap.h: Add include guard.
8019         * xtensa-tdep.h: Add include guard.
8020         * xcoffread.h: Rename include guard.
8021         * varobj-iter.h: Add include guard.
8022         * tui/tui.h: Rename include guard.
8023         * tui/tui-winsource.h: Rename include guard.
8024         * tui/tui-wingeneral.h: Rename include guard.
8025         * tui/tui-windata.h: Rename include guard.
8026         * tui/tui-win.h: Rename include guard.
8027         * tui/tui-stack.h: Rename include guard.
8028         * tui/tui-source.h: Rename include guard.
8029         * tui/tui-regs.h: Rename include guard.
8030         * tui/tui-out.h: Rename include guard.
8031         * tui/tui-layout.h: Rename include guard.
8032         * tui/tui-io.h: Rename include guard.
8033         * tui/tui-hooks.h: Rename include guard.
8034         * tui/tui-file.h: Rename include guard.
8035         * tui/tui-disasm.h: Rename include guard.
8036         * tui/tui-data.h: Rename include guard.
8037         * tui/tui-command.h: Rename include guard.
8038         * tic6x-tdep.h: Add include guard.
8039         * target/waitstatus.h: Rename include guard.
8040         * target/wait.h: Rename include guard.
8041         * target/target.h: Rename include guard.
8042         * target/resume.h: Rename include guard.
8043         * target-float.h: Rename include guard.
8044         * stabsread.h: Add include guard.
8045         * rs6000-tdep.h: Add include guard.
8046         * riscv-fbsd-tdep.h: Add include guard.
8047         * regformats/regdef.h: Rename include guard.
8048         * record.h: Rename include guard.
8049         * python/python.h: Rename include guard.
8050         * python/python-internal.h: Rename include guard.
8051         * python/py-stopevent.h: Rename include guard.
8052         * python/py-ref.h: Rename include guard.
8053         * python/py-record.h: Rename include guard.
8054         * python/py-record-full.h: Rename include guard.
8055         * python/py-record-btrace.h: Rename include guard.
8056         * python/py-instruction.h: Rename include guard.
8057         * python/py-events.h: Rename include guard.
8058         * python/py-event.h: Rename include guard.
8059         * procfs.h: Add include guard.
8060         * proc-utils.h: Add include guard.
8061         * p-lang.h: Add include guard.
8062         * or1k-tdep.h: Rename include guard.
8063         * observable.h: Rename include guard.
8064         * nto-tdep.h: Rename include guard.
8065         * nat/x86-linux.h: Rename include guard.
8066         * nat/x86-linux-dregs.h: Rename include guard.
8067         * nat/x86-gcc-cpuid.h: Add include guard.
8068         * nat/x86-dregs.h: Rename include guard.
8069         * nat/x86-cpuid.h: Rename include guard.
8070         * nat/ppc-linux.h: Rename include guard.
8071         * nat/mips-linux-watch.h: Rename include guard.
8072         * nat/linux-waitpid.h: Rename include guard.
8073         * nat/linux-ptrace.h: Rename include guard.
8074         * nat/linux-procfs.h: Rename include guard.
8075         * nat/linux-osdata.h: Rename include guard.
8076         * nat/linux-nat.h: Rename include guard.
8077         * nat/linux-namespaces.h: Rename include guard.
8078         * nat/linux-btrace.h: Rename include guard.
8079         * nat/glibc_thread_db.h: Rename include guard.
8080         * nat/gdb_thread_db.h: Rename include guard.
8081         * nat/gdb_ptrace.h: Rename include guard.
8082         * nat/fork-inferior.h: Rename include guard.
8083         * nat/amd64-linux-siginfo.h: Rename include guard.
8084         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8085         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8086         * nat/aarch64-linux.h: Rename include guard.
8087         * nat/aarch64-linux-hw-point.h: Rename include guard.
8088         * mn10300-tdep.h: Add include guard.
8089         * mips-linux-tdep.h: Add include guard.
8090         * mi/mi-parse.h: Rename include guard.
8091         * mi/mi-out.h: Rename include guard.
8092         * mi/mi-main.h: Rename include guard.
8093         * mi/mi-interp.h: Rename include guard.
8094         * mi/mi-getopt.h: Rename include guard.
8095         * mi/mi-console.h: Rename include guard.
8096         * mi/mi-common.h: Rename include guard.
8097         * mi/mi-cmds.h: Rename include guard.
8098         * mi/mi-cmd-break.h: Rename include guard.
8099         * m2-lang.h: Add include guard.
8100         * location.h: Rename include guard.
8101         * linux-record.h: Rename include guard.
8102         * linux-nat.h: Add include guard.
8103         * linux-fork.h: Add include guard.
8104         * i386-darwin-tdep.h: Rename include guard.
8105         * hppa-linux-offsets.h: Add include guard.
8106         * guile/guile.h: Rename include guard.
8107         * guile/guile-internal.h: Rename include guard.
8108         * gnu-nat.h: Rename include guard.
8109         * gdb-stabs.h: Rename include guard.
8110         * frv-tdep.h: Add include guard.
8111         * f-lang.h: Add include guard.
8112         * event-loop.h: Add include guard.
8113         * darwin-nat.h: Rename include guard.
8114         * cp-abi.h: Rename include guard.
8115         * config/sparc/nm-sol2.h: Rename include guard.
8116         * config/nm-nto.h: Rename include guard.
8117         * config/nm-linux.h: Add include guard.
8118         * config/i386/nm-i386gnu.h: Rename include guard.
8119         * config/djgpp/nl_types.h: Rename include guard.
8120         * config/djgpp/langinfo.h: Rename include guard.
8121         * compile/gcc-cp-plugin.h: Add include guard.
8122         * compile/gcc-c-plugin.h: Add include guard.
8123         * compile/compile.h: Rename include guard.
8124         * compile/compile-object-run.h: Rename include guard.
8125         * compile/compile-object-load.h: Rename include guard.
8126         * compile/compile-internal.h: Rename include guard.
8127         * compile/compile-cplus.h: Rename include guard.
8128         * compile/compile-c.h: Rename include guard.
8129         * common/xml-utils.h: Rename include guard.
8130         * common/x86-xstate.h: Rename include guard.
8131         * common/version.h: Rename include guard.
8132         * common/vec.h: Rename include guard.
8133         * common/tdesc.h: Rename include guard.
8134         * common/selftest.h: Rename include guard.
8135         * common/scoped_restore.h: Rename include guard.
8136         * common/scoped_mmap.h: Rename include guard.
8137         * common/scoped_fd.h: Rename include guard.
8138         * common/safe-iterator.h: Rename include guard.
8139         * common/run-time-clock.h: Rename include guard.
8140         * common/refcounted-object.h: Rename include guard.
8141         * common/queue.h: Rename include guard.
8142         * common/ptid.h: Rename include guard.
8143         * common/print-utils.h: Rename include guard.
8144         * common/preprocessor.h: Rename include guard.
8145         * common/pathstuff.h: Rename include guard.
8146         * common/observable.h: Rename include guard.
8147         * common/netstuff.h: Rename include guard.
8148         * common/job-control.h: Rename include guard.
8149         * common/host-defs.h: Rename include guard.
8150         * common/gdb_wait.h: Rename include guard.
8151         * common/gdb_vecs.h: Rename include guard.
8152         * common/gdb_unlinker.h: Rename include guard.
8153         * common/gdb_unique_ptr.h: Rename include guard.
8154         * common/gdb_tilde_expand.h: Rename include guard.
8155         * common/gdb_sys_time.h: Rename include guard.
8156         * common/gdb_string_view.h: Rename include guard.
8157         * common/gdb_splay_tree.h: Rename include guard.
8158         * common/gdb_setjmp.h: Rename include guard.
8159         * common/gdb_ref_ptr.h: Rename include guard.
8160         * common/gdb_optional.h: Rename include guard.
8161         * common/gdb_locale.h: Rename include guard.
8162         * common/gdb_assert.h: Rename include guard.
8163         * common/filtered-iterator.h: Rename include guard.
8164         * common/filestuff.h: Rename include guard.
8165         * common/fileio.h: Rename include guard.
8166         * common/environ.h: Rename include guard.
8167         * common/common-utils.h: Rename include guard.
8168         * common/common-types.h: Rename include guard.
8169         * common/common-regcache.h: Rename include guard.
8170         * common/common-inferior.h: Rename include guard.
8171         * common/common-gdbthread.h: Rename include guard.
8172         * common/common-exceptions.h: Rename include guard.
8173         * common/common-defs.h: Rename include guard.
8174         * common/common-debug.h: Rename include guard.
8175         * common/cleanups.h: Rename include guard.
8176         * common/buffer.h: Rename include guard.
8177         * common/btrace-common.h: Rename include guard.
8178         * common/break-common.h: Rename include guard.
8179         * cli/cli-utils.h: Rename include guard.
8180         * cli/cli-style.h: Rename include guard.
8181         * cli/cli-setshow.h: Rename include guard.
8182         * cli/cli-script.h: Rename include guard.
8183         * cli/cli-interp.h: Rename include guard.
8184         * cli/cli-decode.h: Rename include guard.
8185         * cli/cli-cmds.h: Rename include guard.
8186         * charset-list.h: Add include guard.
8187         * buildsym-legacy.h: Rename include guard.
8188         * bfin-tdep.h: Add include guard.
8189         * ax.h: Rename include guard.
8190         * arm-linux-tdep.h: Add include guard.
8191         * arm-fbsd-tdep.h: Add include guard.
8192         * arch/xtensa.h: Rename include guard.
8193         * arch/tic6x.h: Add include guard.
8194         * arch/i386.h: Add include guard.
8195         * arch/arm.h: Rename include guard.
8196         * arch/arm-linux.h: Rename include guard.
8197         * arch/arm-get-next-pcs.h: Rename include guard.
8198         * arch/amd64.h: Add include guard.
8199         * arch/aarch64-insn.h: Rename include guard.
8200         * arch-utils.h: Rename include guard.
8201         * annotate.h: Add include guard.
8202         * amd64-darwin-tdep.h: Rename include guard.
8203         * aarch64-linux-tdep.h: Add include guard.
8204         * aarch64-fbsd-tdep.h: Add include guard.
8205         * aarch32-linux-nat.h: Add include guard.
8206
8207 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8208
8209         * macrotab.c (macro_define_internal): New function that
8210         factorizes macro_define_object_internal and macro_define_function
8211         code.
8212         (macro_define_object_internal): Use macro_define_internal.
8213         (macro_define_function): Likewise.
8214
8215 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8216
8217         * macrocmd.c (extract_identifier): Return
8218         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8219         callers.
8220
8221 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8222
8223         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8224
8225 2019-02-05  Tom Tromey  <tom@tromey.com>
8226
8227         * target.c (target_stack::unpush): Move assertion earlier.
8228
8229 2019-01-30  Tom Tromey  <tom@tromey.com>
8230
8231         PR python/23615:
8232         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8233         (gdbpy_parse_and_eval): Likewise.
8234         * python/python-internal.h (gdbpy_allow_threads): New class.
8235
8236 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8237
8238         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8239         (aarch64_fbsd_fpregmap): Move earlier.
8240         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8241         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8242         instead of individual calls to trad_frame_set_reg_addr.
8243         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8244         earlier.
8245         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8246         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8247         instead of individual calls to trad_frame_set_reg_addr.
8248
8249 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8250
8251         * CONTRIBUTE: Replace contribution list with wiki link.
8252
8253 2019-01-25  Tom Tromey  <tom@tromey.com>
8254
8255         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8256
8257 2019-01-25  Tom Tromey  <tom@tromey.com>
8258
8259         * xtensa-linux-nat.c: Fix common/ includes.
8260         * xml-support.h: Fix common/ includes.
8261         * xml-support.c: Fix common/ includes.
8262         * x86-linux-nat.c: Fix common/ includes.
8263         * windows-nat.c: Fix common/ includes.
8264         * varobj.h: Fix common/ includes.
8265         * varobj.c: Fix common/ includes.
8266         * value.c: Fix common/ includes.
8267         * valops.c: Fix common/ includes.
8268         * utils.c: Fix common/ includes.
8269         * unittests/xml-utils-selftests.c: Fix common/ includes.
8270         * unittests/utils-selftests.c: Fix common/ includes.
8271         * unittests/unpack-selftests.c: Fix common/ includes.
8272         * unittests/tracepoint-selftests.c: Fix common/ includes.
8273         * unittests/style-selftests.c: Fix common/ includes.
8274         * unittests/string_view-selftests.c: Fix common/ includes.
8275         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8276         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8277         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8278         * unittests/rsp-low-selftests.c: Fix common/ includes.
8279         * unittests/parse-connection-spec-selftests.c: Fix common/
8280         includes.
8281         * unittests/optional-selftests.c: Fix common/ includes.
8282         * unittests/offset-type-selftests.c: Fix common/ includes.
8283         * unittests/observable-selftests.c: Fix common/ includes.
8284         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8285         * unittests/memrange-selftests.c: Fix common/ includes.
8286         * unittests/memory-map-selftests.c: Fix common/ includes.
8287         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8288         * unittests/function-view-selftests.c: Fix common/ includes.
8289         * unittests/environ-selftests.c: Fix common/ includes.
8290         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8291         * unittests/common-utils-selftests.c: Fix common/ includes.
8292         * unittests/cli-utils-selftests.c: Fix common/ includes.
8293         * unittests/array-view-selftests.c: Fix common/ includes.
8294         * ui-file.c: Fix common/ includes.
8295         * tui/tui-io.c: Fix common/ includes.
8296         * tracepoint.h: Fix common/ includes.
8297         * tracepoint.c: Fix common/ includes.
8298         * tracefile-tfile.c: Fix common/ includes.
8299         * top.h: Fix common/ includes.
8300         * top.c: Fix common/ includes.
8301         * thread.c: Fix common/ includes.
8302         * target/waitstatus.h: Fix common/ includes.
8303         * target/waitstatus.c: Fix common/ includes.
8304         * target.h: Fix common/ includes.
8305         * target.c: Fix common/ includes.
8306         * target-memory.c: Fix common/ includes.
8307         * target-descriptions.c: Fix common/ includes.
8308         * symtab.h: Fix common/ includes.
8309         * symfile.c: Fix common/ includes.
8310         * stap-probe.c: Fix common/ includes.
8311         * spu-linux-nat.c: Fix common/ includes.
8312         * sparc-nat.c: Fix common/ includes.
8313         * source.c: Fix common/ includes.
8314         * solib.c: Fix common/ includes.
8315         * solib-target.c: Fix common/ includes.
8316         * ser-unix.c: Fix common/ includes.
8317         * ser-tcp.c: Fix common/ includes.
8318         * ser-pipe.c: Fix common/ includes.
8319         * ser-base.c: Fix common/ includes.
8320         * selftest-arch.c: Fix common/ includes.
8321         * s12z-tdep.c: Fix common/ includes.
8322         * rust-exp.y: Fix common/ includes.
8323         * rs6000-aix-tdep.c: Fix common/ includes.
8324         * riscv-tdep.c: Fix common/ includes.
8325         * remote.c: Fix common/ includes.
8326         * remote-notif.h: Fix common/ includes.
8327         * remote-fileio.h: Fix common/ includes.
8328         * remote-fileio.c: Fix common/ includes.
8329         * regcache.h: Fix common/ includes.
8330         * regcache.c: Fix common/ includes.
8331         * record-btrace.c: Fix common/ includes.
8332         * python/python.c: Fix common/ includes.
8333         * python/py-type.c: Fix common/ includes.
8334         * python/py-inferior.c: Fix common/ includes.
8335         * progspace.h: Fix common/ includes.
8336         * producer.c: Fix common/ includes.
8337         * procfs.c: Fix common/ includes.
8338         * proc-api.c: Fix common/ includes.
8339         * printcmd.c: Fix common/ includes.
8340         * ppc-linux-nat.c: Fix common/ includes.
8341         * parser-defs.h: Fix common/ includes.
8342         * osdata.c: Fix common/ includes.
8343         * obsd-nat.c: Fix common/ includes.
8344         * nat/x86-linux.c: Fix common/ includes.
8345         * nat/x86-linux-dregs.c: Fix common/ includes.
8346         * nat/x86-dregs.h: Fix common/ includes.
8347         * nat/x86-dregs.c: Fix common/ includes.
8348         * nat/ppc-linux.c: Fix common/ includes.
8349         * nat/mips-linux-watch.h: Fix common/ includes.
8350         * nat/mips-linux-watch.c: Fix common/ includes.
8351         * nat/linux-waitpid.c: Fix common/ includes.
8352         * nat/linux-ptrace.h: Fix common/ includes.
8353         * nat/linux-ptrace.c: Fix common/ includes.
8354         * nat/linux-procfs.c: Fix common/ includes.
8355         * nat/linux-personality.c: Fix common/ includes.
8356         * nat/linux-osdata.c: Fix common/ includes.
8357         * nat/linux-namespaces.c: Fix common/ includes.
8358         * nat/linux-btrace.h: Fix common/ includes.
8359         * nat/linux-btrace.c: Fix common/ includes.
8360         * nat/fork-inferior.c: Fix common/ includes.
8361         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8362         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8363         * nat/aarch64-linux.c: Fix common/ includes.
8364         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8365         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8366         * namespace.h: Fix common/ includes.
8367         * mips-linux-tdep.c: Fix common/ includes.
8368         * minsyms.c: Fix common/ includes.
8369         * mi/mi-parse.h: Fix common/ includes.
8370         * mi/mi-main.c: Fix common/ includes.
8371         * mi/mi-cmd-env.c: Fix common/ includes.
8372         * memrange.h: Fix common/ includes.
8373         * memattr.c: Fix common/ includes.
8374         * maint.h: Fix common/ includes.
8375         * maint.c: Fix common/ includes.
8376         * main.c: Fix common/ includes.
8377         * machoread.c: Fix common/ includes.
8378         * location.c: Fix common/ includes.
8379         * linux-thread-db.c: Fix common/ includes.
8380         * linux-nat.c: Fix common/ includes.
8381         * linux-fork.c: Fix common/ includes.
8382         * inline-frame.c: Fix common/ includes.
8383         * infrun.c: Fix common/ includes.
8384         * inflow.c: Fix common/ includes.
8385         * inferior.h: Fix common/ includes.
8386         * inferior.c: Fix common/ includes.
8387         * infcmd.c: Fix common/ includes.
8388         * inf-ptrace.c: Fix common/ includes.
8389         * inf-child.c: Fix common/ includes.
8390         * ia64-linux-nat.c: Fix common/ includes.
8391         * i387-tdep.c: Fix common/ includes.
8392         * i386-tdep.c: Fix common/ includes.
8393         * i386-linux-tdep.c: Fix common/ includes.
8394         * i386-linux-nat.c: Fix common/ includes.
8395         * i386-go32-tdep.c: Fix common/ includes.
8396         * i386-fbsd-tdep.c: Fix common/ includes.
8397         * i386-fbsd-nat.c: Fix common/ includes.
8398         * guile/scm-type.c: Fix common/ includes.
8399         * guile/guile.c: Fix common/ includes.
8400         * go32-nat.c: Fix common/ includes.
8401         * gnu-nat.c: Fix common/ includes.
8402         * gdbthread.h: Fix common/ includes.
8403         * gdbarch-selftests.c: Fix common/ includes.
8404         * gdb_usleep.c: Fix common/ includes.
8405         * gdb_select.h: Fix common/ includes.
8406         * gdb_bfd.c: Fix common/ includes.
8407         * gcore.c: Fix common/ includes.
8408         * fork-child.c: Fix common/ includes.
8409         * findvar.c: Fix common/ includes.
8410         * fbsd-nat.c: Fix common/ includes.
8411         * event-top.c: Fix common/ includes.
8412         * event-loop.c: Fix common/ includes.
8413         * dwarf2read.c: Fix common/ includes.
8414         * dwarf2loc.c: Fix common/ includes.
8415         * dwarf2-frame.c: Fix common/ includes.
8416         * dwarf-index-cache.c: Fix common/ includes.
8417         * dtrace-probe.c: Fix common/ includes.
8418         * disasm-selftests.c: Fix common/ includes.
8419         * defs.h: Fix common/ includes.
8420         * csky-tdep.c: Fix common/ includes.
8421         * cp-valprint.c: Fix common/ includes.
8422         * cp-support.h: Fix common/ includes.
8423         * cp-support.c: Fix common/ includes.
8424         * corelow.c: Fix common/ includes.
8425         * completer.h: Fix common/ includes.
8426         * completer.c: Fix common/ includes.
8427         * compile/compile.c: Fix common/ includes.
8428         * compile/compile-loc2c.c: Fix common/ includes.
8429         * compile/compile-cplus-types.c: Fix common/ includes.
8430         * compile/compile-cplus-symbols.c: Fix common/ includes.
8431         * command.h: Fix common/ includes.
8432         * cli/cli-dump.c: Fix common/ includes.
8433         * cli/cli-cmds.c: Fix common/ includes.
8434         * charset.c: Fix common/ includes.
8435         * build-id.c: Fix common/ includes.
8436         * btrace.h: Fix common/ includes.
8437         * btrace.c: Fix common/ includes.
8438         * breakpoint.h: Fix common/ includes.
8439         * breakpoint.c: Fix common/ includes.
8440         * ax.h:
8441         (enum agent_op): Fix common/ includes.
8442         * ax-general.c (struct aop_map): Fix common/ includes.
8443         * ax-gdb.c: Fix common/ includes.
8444         * auxv.c: Fix common/ includes.
8445         * auto-load.c: Fix common/ includes.
8446         * arm-tdep.c: Fix common/ includes.
8447         * arch/riscv.c: Fix common/ includes.
8448         * arch/ppc-linux-common.c: Fix common/ includes.
8449         * arch/i386.c: Fix common/ includes.
8450         * arch/arm.c: Fix common/ includes.
8451         * arch/arm-linux.c: Fix common/ includes.
8452         * arch/arm-get-next-pcs.c: Fix common/ includes.
8453         * arch/amd64.c: Fix common/ includes.
8454         * arch/aarch64.c: Fix common/ includes.
8455         * arch/aarch64-insn.c: Fix common/ includes.
8456         * arch-utils.c: Fix common/ includes.
8457         * amd64-windows-tdep.c: Fix common/ includes.
8458         * amd64-tdep.c: Fix common/ includes.
8459         * amd64-sol2-tdep.c: Fix common/ includes.
8460         * amd64-obsd-tdep.c: Fix common/ includes.
8461         * amd64-nbsd-tdep.c: Fix common/ includes.
8462         * amd64-linux-tdep.c: Fix common/ includes.
8463         * amd64-linux-nat.c: Fix common/ includes.
8464         * amd64-fbsd-tdep.c: Fix common/ includes.
8465         * amd64-fbsd-nat.c: Fix common/ includes.
8466         * amd64-dicos-tdep.c: Fix common/ includes.
8467         * amd64-darwin-tdep.c: Fix common/ includes.
8468         * agent.c: Fix common/ includes.
8469         * ada-lang.h: Fix common/ includes.
8470         * ada-lang.c: Fix common/ includes.
8471         * aarch64-tdep.c: Fix common/ includes.
8472
8473 2019-01-25  Tom Tromey  <tom@tromey.com>
8474
8475         * common/create-version.sh: Use common/version.h.
8476
8477 2019-01-24  Pedro Alves  <palves@redhat.com>
8478
8479         * infrun.c (signal_stop, signal_print, signal_program)
8480         (signal_catch, signal_pass): Now arrays instead of pointers.
8481         (update_signals_program_target, do_target_resume)
8482         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8483         * linux-nat.c (linux_nat_target::pass_signals)
8484         (linux_nat_target::create_inferior, linux_nat_target::attach):
8485         Adjust.
8486         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8487         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8488         * procfs.c (procfs_target::pass_signals): Adjust.
8489         * record-full.c (record_full_target::resume): Adjust.
8490         * remote.c (remote_target::pass_signals)
8491         (remote_target::program_signals): Adjust.
8492         * target-debug.h (target_debug_print_signals): Now takes a
8493         gdb::array_view as parameter.  Adjust.
8494         * target.h (target_ops) <pass_signals, program_signals>: Replace
8495         pointer and length parameters with gdb::array_view.
8496         (target_pass_signals, target_program_signals): Likewise.
8497         * target-delegates.c: Regenerate.
8498
8499 2019-01-24  Pedro Alves  <palves@redhat.com>
8500
8501         * common/forward-scope-exit.h
8502         (forward_scope_exit::forward_scope_exit): Pass arguments to
8503         m_bind_function directly, instead of creating a std::bind and
8504         copying that.
8505
8506 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8507
8508         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8509         for static members.
8510         (pass_in_v_vfp_candidate): Likewise.
8511
8512 2019-01-23  Tom Tromey  <tom@tromey.com>
8513             Pedro Alves  <palves@redhat.com>
8514
8515         * regcache.c (class regcache_invalidator): Remove.
8516         (regcache::raw_write): Use make_scope_exit.
8517
8518 2019-01-23  Tom Tromey  <tom@tromey.com>
8519
8520         * ui-out.h (class ui_out_emit_type): Update comment.
8521
8522 2019-01-23  Tom Tromey  <tom@tromey.com>
8523
8524         * infrun.c (fetch_inferior_event): Update comment.
8525
8526 2019-01-23  Tom Tromey  <tom@tromey.com>
8527             Pedro Alves  <palves@redhat.com>
8528
8529         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8530         parameter.
8531         (fetch_inferior_event): Use SCOPE_EXIT.
8532
8533
8534 2019-01-23  Tom Tromey  <tom@tromey.com>
8535             Pedro Alves  <palves@redhat.com>
8536
8537         * infrun.c (disable_thread_events): Delete.
8538         (stop_all_threads): Use SCOPE_EXIT.
8539
8540 2019-01-23  Tom Tromey  <tom@tromey.com>
8541             Pedro Alves  <palves@redhat.com>
8542
8543         * symfile.c: Include forward-scope-exit.h.
8544         (clear_symtab_users_cleanup): Replace forward declaration with
8545         a FORWARD_SCOPE_EXIT.
8546         (syms_from_objfile_1): Use the forward_scope_exit and
8547         gdb::optional instead of cleanup_function.
8548         (reread_symbols): Use the forward_scope_exit instead of
8549         cleanup_function.
8550         (clear_symtab_users_cleanup): Remove function.
8551
8552 2019-01-23  Tom Tromey  <tom@tromey.com>
8553             Pedro Alves  <palves@redhat.com>
8554
8555         * linux-nat.c: Include scope-exit.h.
8556         (cleanup_target_stop): Remove.
8557         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8558         SCOPE_EXIT.
8559
8560 2019-01-23  Tom Tromey  <tom@tromey.com>
8561             Pedro Alves  <palves@redhat.com>
8562
8563         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8564         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8565
8566 2019-01-23  Tom Tromey  <tom@tromey.com>
8567             Andrew Burgess  <andrew.burgess@embecosm.com>
8568             Pedro Alves  <palves@redhat.com>
8569
8570         * infrun.c (fetch_inferior_event): Use scope_exit.
8571         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8572         * top.c (execute_command): Use scope_exit.
8573         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8574         * utils.c (do_bpstat_clear_actions_cleanup)
8575         (make_bpstat_clear_actions_cleanup): Remove.
8576
8577 2019-01-23  Tom Tromey  <tom@tromey.com>
8578             Pedro Alves  <palves@redhat.com>
8579
8580         * infrun.c: Include "common/scope-exit.h"
8581         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8582         (wait_for_inferior): Use SCOPE_EXIT.
8583         (fetch_inferior_event): Use scope_exit.
8584
8585 2019-01-23  Tom Tromey  <tom@tromey.com>
8586             Pedro Alves  <palves@redhat.com>
8587
8588         * breakpoint.c (create_breakpoint): Remove cleanup.
8589
8590 2019-01-23  Tom Tromey  <tom@tromey.com>
8591             Andrew Burgess  <andrew.burgess@embecosm.com>
8592             Pedro Alves  <palves@redhat.com>
8593
8594 2019-01-23  Pedro Alves  <palves@redhat.com>
8595
8596         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8597
8598 2019-01-23  Pedro Alves  <palves@redhat.com>
8599             Andrew Burgess  <andrew.burgess@embecosm.com>
8600
8601         * gdbthread.h: Include "common/forward-scope-exit.h".
8602         (scoped_finish_thread_state): Redefine custom class in terms of
8603         forward_scope_exit.
8604
8605 2019-01-23  Pedro Alves  <palves@redhat.com>
8606             Andrew Burgess  <andrew.burgess@embecosm.com>
8607
8608         * common/forward-scope-exit.h: New file.
8609
8610 2019-01-23  Pedro Alves  <palves@redhat.com>
8611             Andrew Burgess  <andrew.burgess@embecosm.com>
8612             Tom Tromey  <tom@tromey.com>
8613
8614         * common/scope-exit.h: New file.
8615
8616 2019-01-23  Pedro Alves  <palves@redhat.com>
8617
8618         * common/preprocessor.h (ESC): Rename to ...
8619         (ESC_PARENS): ... this.
8620         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8621         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8622
8623 2019-01-23  Tom Tromey  <tom@tromey.com>
8624
8625         * language.h (class scoped_switch_to_sym_language_if_auto):
8626         Initialize m_lang in both cases.
8627
8628 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8629
8630         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8631         with XCNEW.
8632
8633 2019-01-22  Tom Tromey  <tom@tromey.com>
8634
8635         * corelow.c: Do not include sys/file.h.
8636
8637 2019-01-22  Tom Tromey  <tom@tromey.com>
8638
8639         * tui/tui-wingeneral.h: Include gdb_curses.h.
8640
8641 2019-01-22  Tom Tromey  <tom@tromey.com>
8642
8643         * source-cache.h (class source_cache) <get_source_lines,
8644         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8645
8646 2019-01-22  Tom Tromey  <tom@tromey.com>
8647
8648         * remote-fileio.h (struct remote_target): Declare.
8649
8650 2019-01-22  Tom Tromey  <tom@tromey.com>
8651
8652         * python/py-arch.c: Do not include py-ref.h.
8653         * python/py-bpevent.c: Do not include py-ref.h.
8654         * python/py-cmd.c: Do not include py-ref.h.
8655         * python/py-continueevent.c: Do not include py-ref.h.
8656         * python/py-event.h: Do not include py-ref.h.
8657         * python/py-evtregistry.c: Do not include py-ref.h.
8658         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8659         * python/py-frame.c: Do not include py-ref.h.
8660         * python/py-framefilter.c: Do not include py-ref.h.
8661         * python/py-function.c: Do not include py-ref.h.
8662         * python/py-infevents.c: Do not include py-ref.h.
8663         * python/py-linetable.c: Do not include py-ref.h.
8664         * python/py-objfile.c: Do not include py-ref.h.
8665         * python/py-param.c: Do not include py-ref.h.
8666         * python/py-prettyprint.c: Do not include py-ref.h.
8667         * python/py-progspace.c: Do not include py-ref.h.
8668         * python/py-symbol.c: Do not include py-ref.h.
8669         * python/py-symtab.c: Do not include py-ref.h.
8670         * python/py-type.c: Do not include py-ref.h.
8671         * python/py-unwind.c: Do not include py-ref.h.
8672         * python/py-utils.c: Do not include py-ref.h.
8673         * python/py-value.c: Do not include py-ref.h.
8674         * python/py-varobj.c: Do not include py-ref.h.
8675         * python/py-xmethods.c: Do not include py-ref.h.
8676         * python/python.c: Do not include py-ref.h.
8677         * varobj.c: Do not include py-ref.h.
8678
8679 2019-01-22  Tom Tromey  <tom@tromey.com>
8680
8681         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8682         keyword for bcache.
8683
8684 2019-01-22  Tom Tromey  <tom@tromey.com>
8685
8686         * compile/compile-cplus-types.c: Remove a comment by #include.
8687
8688 2019-01-22  Tom Tromey  <tom@tromey.com>
8689
8690         * compile/gcc-c-plugin.h: Include compile-internal.h.
8691
8692 2019-01-22  Tom Tromey  <tom@tromey.com>
8693
8694         * stabsread.c (EXTERN): Do not define.
8695         (symnum, next_symbol_text_func, processing_gcc_compilation)
8696         (within_function, global_sym_chain, global_stabs)
8697         (previous_stab_code, this_object_header_files)
8698         (n_this_object_header_files)
8699         (n_allocated_this_object_header_files): Define.
8700         * stabsread.h (EXTERN): Never define.  Use "extern".
8701
8702 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8703
8704         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8705         history_value.
8706
8707 2019-01-21  Tom Tromey  <tom@tromey.com>
8708
8709         * ui-out.c: Fix includes.
8710         * tui/tui-source.c: Fix includes.
8711         * target.c: Fix includes.
8712         * remote.c: Fix includes.
8713         * regcache.c: Fix includes.
8714         * python/py-block.c: Fix includes.
8715         * printcmd.c: Fix includes.
8716         * or1k-tdep.c: Fix includes.
8717         * mi/mi-main.c: Fix includes.
8718         * m32r-tdep.c: Fix includes.
8719         * csky-tdep.c: Fix includes.
8720         * compile/compile-cplus-types.c: Fix includes.
8721         * cli/cli-interp.c: Fix includes.
8722
8723 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8724
8725         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8726         for padding.
8727
8728 2019-01-16  Tom Tromey  <tom@tromey.com>
8729
8730         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8731         earlier.
8732         (struct objfile) <msymbols_range>: Move from top level.
8733         <msymbols>: New method.
8734         (class objfile_msymbols): Remove.
8735         * symtab.c (default_collect_symbol_completion_matches_break_on):
8736         Update.
8737         * symmisc.c (dump_msymbols): Update.
8738         * stabsread.c (scan_file_globals): Update.
8739         * objc-lang.c (info_selectors_command, info_classes_command)
8740         (find_methods): Update.
8741         * minsyms.c (find_solib_trampoline_target): Update.
8742         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8743         * coffread.c (coff_symfile_read): Update.
8744         * ada-lang.c (ada_lookup_simple_minsym)
8745         (ada_collect_symbol_completion_matches): Update.
8746
8747 2019-01-16  Tom Tromey  <tom@tromey.com>
8748
8749         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8750         type.  Remove no-argument constructor.
8751         <iterator::operator++>: Simplify.
8752         <begin>: Update.
8753         <end>: Use minimal_symbol_count.
8754
8755 2019-01-16  Tom Tromey  <tom@tromey.com>
8756
8757         * objfiles.h (struct objfile) <psymtabs>: New method.
8758         (class objfile_psymtabs): Remove.
8759         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8760         typedef.
8761         <range>: New method.
8762         (require_partial_symbols): Change return type.
8763         * psymtab.c (require_partial_symbols)
8764         (psym_expand_symtabs_matching): Update.
8765         * mdebugread.c (parse_partial_symbols): Update.
8766         * dbxread.c (dbx_end_psymtab): Update.
8767
8768 2019-01-15  Tom Tromey  <tom@tromey.com>
8769
8770         * symtab.c (lookup_objfile_from_block)
8771         (lookup_symbol_in_objfile_symtabs)
8772         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8773         (find_line_symtab, info_sources_command)
8774         (default_collect_symbol_completion_matches_break_on)
8775         (make_source_files_completion_list): Update.
8776         * symmisc.c (print_objfile_statistics, dump_objfile)
8777         (maintenance_print_symbols, maintenance_info_symtabs)
8778         (maintenance_check_symtabs, maintenance_info_line_tables):
8779         Update.
8780         * source.c (select_source_symtab)
8781         (forget_cached_source_info_for_objfile): Update.
8782         * objfiles.h (class objfile_compunits): Remove.
8783         (struct objfile) <compunits_range>: New typedef.
8784         (compunits): New method.
8785         * objfiles.c (objfile_relocate1): Update.
8786         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8787         * maint.c (count_symtabs_and_blocks): Update.
8788         * linespec.c (iterate_over_all_matching_symtabs): Update.
8789         * cp-support.c (add_symbol_overload_list_qualified): Update.
8790         * coffread.c (coff_symtab_read): Update.
8791         * ada-lang.c (add_nonlocal_symbols)
8792         (ada_collect_symbol_completion_matches)
8793         (ada_add_global_exceptions): Update.
8794
8795 2019-01-15  Tom Tromey  <tom@tromey.com>
8796
8797         * progspace.h (program_space) <objfiles_safe_range>: New
8798         typedef.
8799         <objfiles_safe>: New method.
8800         * objfiles.h (class all_objfiles_safe): Remove.
8801         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8802         * jit.c (jit_inferior_exit_hook): Update.
8803
8804 2019-01-17  Tom Tromey  <tom@tromey.com>
8805
8806         * progspace.h (program_space) <objfiles_range>: New typedef.
8807         <objfiles>: New method.
8808         <objfiles_head>: Rename from objfiles.
8809         (object_files): Update.
8810         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8811         * guile/scm-pretty-print.c
8812         (ppscm_find_pretty_printer_from_objfiles): Update.
8813         * guile/scm-objfile.c (gdbscm_objfiles): Update.
8814         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8815         Update.
8816         * python/py-progspace.c (pspy_get_objfiles): Update.
8817         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8818         Update.
8819         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8820         (objfpy_lookup_objfile_by_build_id): Update.
8821         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8822         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8823         Update.
8824         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8825         (expand_symtab_containing_pc, lookup_objfile_from_block)
8826         (lookup_static_symbol, basic_lookup_transparent_type)
8827         (find_pc_sect_compunit_symtab, find_symbol_at_address)
8828         (find_line_symtab, info_sources_command)
8829         (default_collect_symbol_completion_matches_break_on)
8830         (make_source_files_completion_list, find_main_name): Update.
8831         * symmisc.c (print_symbol_bcache_statistics)
8832         (print_objfile_statistics, maintenance_print_symbols)
8833         (maintenance_print_msymbols, maintenance_print_objfiles)
8834         (maintenance_info_symtabs, maintenance_check_symtabs)
8835         (maintenance_expand_symtabs, maintenance_info_line_tables):
8836         Update.
8837         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8838         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
8839         (map_overlay_command, unmap_overlay_command)
8840         (simple_overlay_update, expand_symtabs_matching)
8841         (map_symbol_filenames): Update.
8842         * symfile-debug.c (set_debug_symfile): Update.
8843         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
8844         Update.
8845         * source.c (select_source_symtab, forget_cached_source_info):
8846         Update.
8847         * solib.c (solib_read_symbols): Update.
8848         * solib-spu.c (append_ocl_sos): Update.
8849         * psymtab.c (maintenance_print_psymbols)
8850         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
8851         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
8852         * printcmd.c (info_symbol_command): Update.
8853         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
8854         Update.
8855         * objfiles.h (class all_objfiles): Remove.
8856         * objfiles.c (have_partial_symbols, have_full_symbols)
8857         (have_minimal_symbols, qsort_cmp, update_section_map)
8858         (shared_objfile_contains_address_p)
8859         (default_iterate_over_objfiles_in_search_order): Update.
8860         * objc-lang.c (info_selectors_command, info_classes_command)
8861         (find_methods): Update.
8862         * minsyms.c (find_solib_trampoline_target): Update.
8863         * maint.c (maintenance_info_sections)
8864         (maintenance_translate_address, count_symtabs_and_blocks):
8865         Update.
8866         * main.c (captured_main_1): Update.
8867         * linux-thread-db.c (try_thread_db_load_from_pdir)
8868         (has_libpthread): Update.
8869         * linespec.c (iterate_over_all_matching_symtabs)
8870         (search_minsyms_for_name): Update.
8871         * jit.c (jit_find_objf_with_entry_addr): Update.
8872         * hppa-tdep.c (find_unwind_entry)
8873         (hppa_lookup_stub_minimal_symbol): Update.
8874         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
8875         Update.
8876         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8877         (elf_gnu_ifunc_resolve_by_got): Update.
8878         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
8879         * dwarf-index-write.c (save_gdb_index_command): Update.
8880         * cp-support.c (add_symbol_overload_list_qualified): Update.
8881         * breakpoint.c (create_overlay_event_breakpoint)
8882         (create_longjmp_master_breakpoint)
8883         (create_std_terminate_master_breakpoint)
8884         (create_exception_master_breakpoint): Update.
8885         * blockframe.c (find_pc_partial_function): Update.
8886         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
8887         (ada_collect_symbol_completion_matches)
8888         (ada_add_global_exceptions): Update.
8889
8890 2019-01-17  Tom Tromey  <tom@tromey.com>
8891
8892         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
8893         declare VEC.
8894         (solib_target_parse_libraries): Change return type.
8895         (library_list_start_segment, library_list_start_section)
8896         (library_list_end_library, library_list_start_library); Update.
8897         (solib_target_free_library_list): Remove.
8898         (solib_target_parse_libraries): Remove cleanup.  Change return
8899         type.
8900         (solib_target_current_sos): Update.
8901
8902 2019-01-17  Tom Tromey  <tromey@bapiya>
8903
8904         * valprint.c: Replace "the the" with "the".
8905         * symtab.c: Replace "the the" with "the".
8906         * solib.c: Replace "the the" with "the".
8907         * solib-dsbt.c: Replace "the the" with "the".
8908         * linespec.c: Replace "the the" with "the".
8909         * dwarf2loc.h: Replace "the the" with "the".
8910         * amd64-windows-tdep.c: Replace "the the" with "the".
8911         * aarch64-tdep.c: Replace "the the" with "the".
8912
8913 2019-01-16  Keith Seitz  <keiths@redhat.com>
8914
8915         PR gdb/23773
8916         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
8917         <builder>: Rename to ..
8918         <m_builder>: ... this and make private.
8919         (dwarf2_cu::get_builder): New method.  Change all users of
8920         `builder' to use this method.
8921         (dwarf2_start_symtab): Move to ...
8922         (dwarf2_cu::start_symtab): ... here.  Update all callers
8923         (setup_type_unit_groups): Move to ...
8924         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
8925         callers.
8926         (dwarf2_cu::reset_builder): New method.
8927         (process_full_compunit, process_full_type_unit): Use
8928         dwarf2_cu::reset_builder.
8929         (follow_die_offset): Record the ancestor CU if it is different
8930         from the followed DIE's CU.
8931         (follow_die_sig_1): Likewise.
8932
8933 2019-01-15  Tom Tromey  <tom@tromey.com>
8934
8935         * remote.c (class remote_state) <buf>: Now a char_vector.
8936         <buf_size>: Remove.
8937         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
8938         parameter.
8939         (remote_target::getpkt_or_notif_sane_1)
8940         (remote_target::getpkt_sane)
8941         (remote_target::getpkt_or_notif_sane): Likewise.
8942         (class remote_target) <putpkt>: New overload.
8943         (remote_target::read_frame): Change type of "buf_p".  Remove
8944         sizeof_p parameter.
8945         (packet_ok): New overload.
8946         (packet_check_result): New overload.
8947         Update all uses.
8948
8949 2019-01-14  Tom Tromey  <tom@tromey.com>
8950
8951         * remote-notif.c (handle_notification, remote_notif_ack)
8952         (remote_notif_parse): Make "buf" const.
8953         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
8954         const.
8955         (remote_notif_parse, remote_notif_ack, handle_notification):
8956         Likewise.
8957         * remote.c (remote_notif_stop_parse): Make "buf" const.
8958         (remote_target::remote_parse_stop_reply): Make "buf" const.
8959         (remote_notif_stop_ack): Make "buf" const.
8960
8961 2019-01-14  Tom Tromey  <tom@tromey.com>
8962
8963         * remote.c (remote_console_output): Make parameter const.
8964
8965 2019-01-14  Tom Tromey  <tom@tromey.com>
8966
8967         * target-debug.h (target_debug_print_signals): Constify.
8968         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
8969         * procfs.c (procfs_target::pass_signals): Update.
8970         * linux-nat.c (linux_nat_target::pass_signals): Update.
8971         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
8972         * target-delegates.c: Rebuild.
8973         * remote.c (remote_target::program_signals): Update.
8974         (remote_target::pass_signals): Update.
8975         * target.c (target_pass_signals): Constify argument.
8976         (target_program_signals): Likewise.
8977         * target.h (struct target_ops) <pass_signals, program_signals>:
8978         Constify argument.
8979         (target_pass_signals, target_program_signals): Constify argument.
8980
8981 2019-01-14  Tom Tromey  <tom@tromey.com>
8982
8983         PR tui/28819:
8984         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
8985
8986 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
8987
8988         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
8989         field.
8990         * rs6000-tdep.c: Include reggroups.h.
8991         (IS_V_ALIAS_PSEUDOREG): Define.
8992         (rs6000_register_name): Return names for the "vX" aliases.
8993         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
8994         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
8995         aliases.  Call default_register_reggroup_p for all other
8996         pseudo-registers.
8997         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
8998         New functions.
8999         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9000         Handle "vX" aliases.
9001         (v_alias_pseudo_register_collect): New function.
9002         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9003         (rs6000_gdbarch_init): Initialize "vX" aliases as
9004         pseudo-registers.  Restore registration of
9005         rs6000_pseudo_register_reggroup_p with
9006         set_tdesc_pseudo_register_reggroup_p.
9007
9008 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9009
9010         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9011         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9012         set_gdbarch_num_pseudo_regs.
9013
9014 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9015
9016         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9017         Remove arg prefixname, add do_set and do_show.
9018         Add member functions set_list and show_list.
9019         * cli/cli-style.c (class cli_style_option): Update accordingly.
9020         (style_set_list): Move to file scope.
9021         (style_show_list): Likewise.
9022         (set_style): Call help_list.
9023         (show_style): Call cmd_show_list.
9024         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9025         Update to use the new macro.
9026
9027 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9028
9029         * ada-lang.c (_initialize_ada_language): Expand the help text
9030         for the "catch exception" command.
9031
9032 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9033
9034         * symtab.c (matching_obj_sections): Initialize obj,
9035         declare it closer to its usage.
9036
9037 2019-01-10  Tom Tromey  <tom@tromey.com>
9038
9039         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9040         (basic_inf_threads_range): Remove.
9041         (inf_threads_range, inf_non_exited_threads_range)
9042         (safe_inf_threads_range): Use next_adapter.
9043
9044 2019-01-10  Keith Seitz  <keiths@redhat.com>
9045
9046         PR gdb/23712
9047         PR symtab/23010
9048         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9049         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9050
9051 2019-01-10  Keith Seitz  <keiths@redhat.com>
9052
9053         PR gdb/23712
9054         PR symtab/23010
9055         * dictionary.c (pending_to_vector): Remove.
9056         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9057         Remove _1 suffix, replacing functions of the same name.  Update
9058         all callers.
9059         (dict_create_hashed, dict_create_hashed_expandable)
9060         (dict_create_linear, dict_create_linear_expandable, dict_free)
9061         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9062         Make functions static.
9063
9064 2019-01-10  Keith Seitz  <keiths@redhat.com>
9065
9066         PR gdb/23712
9067         PR symtab/23010
9068         * dictionary.h (struct dictionary): Replace declaration with
9069         multidictionary.
9070         (dict_create_hashed, dict_create_hashed_expandable)
9071         (dict_create_linear, dict_create_linear_expandable)
9072         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9073         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9074         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9075         taking multidictionary argument.
9076         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9077         * block.h (struct block) <dict>: Change to multidictionary
9078         and rename `multidict'.
9079         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9080         symmisc.c: Update all dictionary references to multidictionary.
9081
9082 2019-01-10  Keith Seitz  <keiths@redhat.com>
9083
9084         PR gdb/23712
9085         PR symtab/23010
9086         * dictionary.c: Include unordered_map.
9087         (pending_to_vector): New function.
9088         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9089         Rewrite the non-"_1" functions to take vector instead
9090         of linked list.
9091         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9092         "new" _1 versions of the same name.
9093         (multidictionary): Define.
9094         (std::hash<enum language): New definition.
9095         (collate_pending_symbols_by_language, mdict_create_hashed)
9096         (mdict_create_hashed_expandable, mdict_create_linear)
9097         (mdict_create_linear_expandable, mdict_free)
9098         (find_language_dictionary, create_new_language_dictionary)
9099         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9100         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9101         (mdict_size, mdict_empty): New functions.
9102         * dictionary.h (mdict_iterator): Define.
9103
9104 2019-01-10  Pedro Alves  <palves@redhat.com>
9105
9106         * breakpoint.c (read_uploaded_action)
9107         (create_tracepoint_from_upload): Adjust to use
9108         gdb::unique_xmalloc_ptr.
9109         * ctf.c (ctf_write_uploaded_tp):
9110         (SET_ARRAY_FIELD): Use emplace_back.
9111         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9112         * tracefile-tfile.c (tfile_write_uploaded_tp):
9113         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9114         gdb::unique_xmalloc_ptr.
9115         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9116         at_string, cond_string, cmd_strings>: Replace char pointers
9117         with gdb::unique_xmalloc_ptr.
9118
9119 2019-01-10  Pedro Alves  <palves@redhat.com>
9120
9121         * solib-target.c (library_list_start_library): Don't xstrdup name.
9122
9123 2019-01-10  Pedro Alves  <palves@redhat.com>
9124
9125         * mdebugread.c (parse_partial_symbols): Use
9126         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9127
9128 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9129
9130         * linux-fork.c (scoped_switch_fork_info)
9131         <~scoped_switch_fork_info>: Fix incorrect variable name.
9132
9133 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9134
9135         * linux-fork.c (scoped_switch_fork_info)
9136         <scoped_switch_fork_info>: Make explicit.
9137         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9138
9139 2019-01-10  Tom Tromey  <tom@tromey.com>
9140
9141         * objfiles.h (objfile::reset_psymtabs): Update.
9142         * objfiles.c (objfile::objfile): Update.
9143         * psymtab.h (psymtab_storage::obstack): Update.
9144         (psymtab_storage::m_obstack): Use gdb::optional.
9145         (class psymtab_storage): Update comment.  Remove objfile
9146         parameter.
9147         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9148
9149 2019-01-10  Tom Tromey  <tom@tromey.com>
9150
9151         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9152         <free_psymtabs>: Now private.
9153         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9154         (allocate_psymtab): Use new method.
9155
9156 2019-01-10  Tom Tromey  <tom@tromey.com>
9157
9158         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9159         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9160         * mdebugread.c (parse_partial_symbols): Use
9161         allocate_dependencies.
9162         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9163         allocate_dependencies.
9164         (process_psymtab_comp_unit_reader)
9165         (build_type_psymtab_dependencies): Likewise.
9166         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9167
9168 2019-01-10  Tom Tromey  <tom@tromey.com>
9169
9170         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9171         PSYMBOL_SET_LANGUAGE.
9172         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9173
9174 2019-01-10  Tom Tromey  <tom@tromey.com>
9175
9176         * psymtab.h (psymtab_storage::obstack): New method.
9177         <m_obstack>: Rename from obstack; now private.
9178         * psymtab.c (psymtab_storage): Update.
9179         * dwarf2read.c (create_addrmap_from_index)
9180         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9181         Update.
9182
9183 2019-01-10  Tom Tromey  <tom@tromey.com>
9184
9185         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9186         * objfiles.h (objfile::reset_psymtabs): New method.
9187
9188 2019-01-10  Tom Tromey  <tom@tromey.com>
9189
9190         * symmisc.c (print_symbol_bcache_statistics): Update.
9191         (print_objfile_statistics): Update.
9192         * symfile.c (reread_symbols): Update.
9193         * psymtab.h (class psymtab_storage): New.
9194         * psymtab.c (psymtab_storage): New constructor.
9195         (~psymtab_storage): New destructor.
9196         (require_partial_symbols): Update.
9197         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9198         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9199         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9200         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9201         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9202         (start_psymtab_common, end_psymtab_common)
9203         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9204         (allocate_psymtab): Update.
9205         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9206         Update.
9207         (dump_psymtab_addrmap, maintenance_print_psymbols)
9208         (maintenance_check_psymtabs): Update.
9209         (class objfile_psymtabs): Move to objfiles.h.
9210         * psympriv.h (discard_psymtab): Now inline.
9211         (psymtab_discarder::psymtab_discarder): Update.
9212         (psymtab_discarder::~psymtab_discarder): Update.
9213         (ALL_OBJFILE_PSYMTABS): Rewrite.
9214         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9215         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9216         Remove fields.
9217         <partial_symtabs>: New field.
9218         (class objfile_psymtabs): Move from psymtab.h.  Update.
9219         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9220         psymbol_cache.
9221         (objfile::~objfile): Don't destroy psymbol_cache.
9222         * mdebugread.c (parse_partial_symbols): Update.
9223         * dwarf2read.c (create_addrmap_from_index)
9224         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9225         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9226         (add_partial_subprogram, dwarf2_ranges_read): Update.
9227         * dwarf-index-write.c (write_address_map)
9228         (write_one_signatured_type, recursively_write_psymbols)
9229         (class debug_names, class debug_names, write_psymtabs_to_index):
9230         Update.
9231
9232 2019-01-10  Tom Tromey  <tom@tromey.com>
9233
9234         * symtab.h (SYMBOL_SET_NAMES): Update.
9235         (symbol_set_names): Update.
9236         (MSYMBOL_SET_NAMES): Update.
9237         * symtab.c (symbol_set_names): Change argument to be an
9238         objfile_per_bfd_storage.
9239         * psymtab.c (add_psymbol_to_bcache): Update.
9240         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9241
9242 2019-01-10  Tom Tromey  <tom@tromey.com>
9243
9244         * symtab.c (create_demangled_names_hash): Change argument to be an
9245         objfile_per_bfd_storage.
9246         (symbol_set_names): Update.
9247
9248 2019-01-10  Tom Tromey  <tom@tromey.com>
9249
9250         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9251         init_psymbol_list.
9252         * psymtab.c (init_psymbol_list): Do nothing if already called.
9253         * psympriv.h (init_psymbol_list): Add comment.
9254         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9255         init_psymbol_list.
9256         * dbxread.c (dbx_symfile_read): Unconditionally call
9257         init_psymbol_list.
9258
9259 2019-01-10  Tom Tromey  <tom@tromey.com>
9260
9261         * xcoffread.c (scan_xcoff_symtab): Update.
9262         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9263         "where".
9264         * mdebugread.c (parse_partial_symbols)
9265         (handle_psymbol_enumerators): Update.
9266         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9267         * dbxread.c (read_dbx_symtab): Update.
9268         * psympriv.h (psymbol_placement): New enum.
9269         (add_psymbol_to_list): Update.
9270
9271 2019-01-10  Tom Tromey  <tom@tromey.com>
9272
9273         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9274         static_psymbols parameters.
9275         (scan_xcoff_symtab): Update.
9276         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9277         static_psymbols parameters.
9278         * psympriv.h (start_psymtab_common): Update.
9279         * mdebugread.c (parse_partial_symbols): Update.
9280         * dwarf2read.c (create_partial_symtab): Update.
9281         * dbxread.c (read_dbx_symtab): Update.
9282         (start_psymtab): Remove global_psymbols and static_psymbols
9283         parameters.
9284
9285 2019-01-10  Tom Tromey  <tom@tromey.com>
9286
9287         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9288         * psymtab.c (allocate_psymtab): Add comment.
9289         * psympriv.h (allocate_psymtab): Add comment.
9290         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9291         initializations.
9292         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9293
9294 2019-01-10  Tom Tromey  <tom@tromey.com>
9295
9296         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9297         Don't declare.
9298         * mipsread.c: Include mdebugread.h.
9299         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9300         Declare.
9301         * elfread.c: Include mdebugread.h.
9302
9303 2019-01-09  Tom Tromey  <tom@tromey.com>
9304
9305         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9306         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9307         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9308         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9309         (psym_lookup_symbol, psym_find_last_source_symtab)
9310         (psym_forget_cached_source_info, psym_print_stats)
9311         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9312         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9313         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9314         (psym_find_compunit_symtab_by_address)
9315         (maintenance_print_psymbols, maintenance_info_psymtabs)
9316         (maintenance_check_psymtabs): Use ranged for.
9317         * psymtab.h (class objfile_psymtabs): New.
9318         (require_partial_symbols): Return objfile_psymtabs.
9319         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9320
9321 2019-01-09  Tom Tromey  <tom@tromey.com>
9322
9323         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9324         (find_pc_mapped_section, list_overlays_command)
9325         (map_overlay_command, unmap_overlay_command)
9326         (simple_overlay_update): Use all_objfiles.
9327         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9328         * printcmd.c (info_symbol_command): Use all_objfiles.
9329         * objfiles.h (ALL_OBJSECTIONS): Remove.
9330         * maint.c (maintenance_translate_address): Use all_objfiles.
9331         * gcore.c (gcore_create_callback): Use all_objfiles.
9332         (objfile_find_memory_regions): Likewise.
9333
9334 2019-01-09  Tom Tromey  <tom@tromey.com>
9335
9336         * symtab.c (find_line_symtab, info_sources_command)
9337         (make_source_files_completion_list): Use objfile_compunits.
9338         * source.c (select_source_symtab): Use objfile_compunits.
9339         * objfiles.h (struct objfile): Update comment.
9340         (ALL_OBJFILES): Remove.
9341         (ALL_FILETABS): Remove.
9342         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9343         objfile_compunits.
9344
9345 2019-01-09  Tom Tromey  <tom@tromey.com>
9346
9347         * symmisc.c (print_objfile_statistics, dump_objfile)
9348         (maintenance_print_symbols): Use compunit_filetabs.
9349         * source.c (forget_cached_source_info_for_objfile): Use
9350         compunit_filetabs.
9351         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9352         (ALL_FILETABS): Use compunit_filetabs.
9353         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9354         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9355
9356 2019-01-09  Tom Tromey  <tom@tromey.com>
9357
9358         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9359         (compunit_filetabs): New.
9360         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9361         compunit_filetabs.
9362         (info_sources_command, make_source_files_completion_list): Remove
9363         declaration.
9364         * symmisc.c (print_objfile_statistics, dump_objfile)
9365         (maintenance_print_symbols): Remove declaration.
9366         (maintenance_info_symtabs): Use compunit_filetabs.
9367         (maintenance_info_line_tables): Likewise.
9368         * source.c (select_source_symtab): Change local variable name.
9369         (forget_cached_source_info_for_objfile): Remove declaration.
9370         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9371         * objfiles.c (objfile_relocate1): Remove declaration.
9372         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9373         declaration.
9374         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9375         * coffread.c (coff_symtab_read): Remove declaration.
9376         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9377         compunit_filetabs.
9378
9379 2019-01-09  Tom Tromey  <tom@tromey.com>
9380
9381         * symtab.c (lookup_objfile_from_block)
9382         (find_pc_sect_compunit_symtab, search_symbols)
9383         (default_collect_symbol_completion_matches_break_on): Use
9384         objfile_compunits.
9385         * objfiles.h (ALL_COMPUNITS): Remove.
9386         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9387         * cp-support.c (add_symbol_overload_list_qualified): Use
9388         objfile_compunits.
9389         * ada-lang.c (ada_collect_symbol_completion_matches)
9390         (ada_add_global_exceptions): Use objfile_compunits.
9391
9392 2019-01-09  Tom Tromey  <tom@tromey.com>
9393
9394         * source.c (select_source_symtab)
9395         (forget_cached_source_info_for_objfile): Remove declaration.
9396         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9397         declaration.
9398         * maint.c (count_symtabs_and_blocks): Remove declaration.
9399         * cp-support.c (add_symbol_overload_list_qualified): Remove
9400         declaration.
9401         * coffread.c (coff_symtab_read): Remove declaration.
9402         * symtab.c (lookup_symbol_in_objfile_symtabs)
9403         (basic_lookup_transparent_type_1): Use objfile_compunits.
9404         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9405         (info_sources_command, search_symbols)
9406         (default_collect_symbol_completion_matches_break_on)
9407         (make_source_files_completion_list): Remove declaration.
9408         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9409         (ada_collect_symbol_completion_matches)
9410         (ada_add_global_exceptions): Remove declaration.
9411         * linespec.c (iterate_over_all_matching_symtabs): Use
9412         objfile_compunits.
9413         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9414         (class objfile_compunits): New.
9415         (ALL_COMPUNITS): Use objfile_compunits.
9416         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9417         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9418         objfile_compunits.
9419         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9420
9421 2019-01-09  Tom Tromey  <tom@tromey.com>
9422
9423         * symtab.c (search_symbols)
9424         (default_collect_symbol_completion_matches_break_on): Use
9425         objfile_msymbols.
9426         * ada-lang.c (ada_lookup_simple_minsym)
9427         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9428         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9429         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9430         objfile_msymbols.
9431         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9432         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9433         * objc-lang.c (find_methods): Use objfile_msymbols.
9434         (info_selectors_command, info_classes_command): Likewise.
9435         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9436         * objfiles.h (class objfile_msymbols): New.
9437         (ALL_OBJFILE_MSYMBOLS): Remove.
9438         (ALL_MSYMBOLS): Remove.
9439
9440 2019-01-09  Tom Tromey  <tom@tromey.com>
9441
9442         * common/next-iterator.h (next_adapter): Add Iterator template
9443         parameter.
9444         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9445         (class all_objfiles_safe): New.
9446         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9447         * objfiles.c (put_objfile_before): Update comment.
9448         (add_separate_debug_objfile): Likewise.
9449         (free_all_objfiles): Use all_objfiles_safe.
9450         (objfile_purge_solibs): Likewise.
9451
9452 2019-01-09  Tom Tromey  <tom@tromey.com>
9453
9454         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9455         (expand_symtab_containing_pc, lookup_static_symbol)
9456         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9457         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9458         all_objfiles.
9459         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9460         * breakpoint.c (create_overlay_event_breakpoint)
9461         (create_longjmp_master_breakpoint)
9462         (create_std_terminate_master_breakpoint)
9463         (create_exception_master_breakpoint): Use all_objfiles.
9464         * linux-thread-db.c (try_thread_db_load_from_pdir)
9465         (has_libpthread): Use all_objfiles.
9466         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9467         * linespec.c (iterate_over_all_matching_symtabs)
9468         (search_minsyms_for_name): Use all_objfiles.
9469         * maint.c (maintenance_info_sections): Use all_objfiles.
9470         * main.c (captured_main_1): Use all_objfiles.
9471         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9472         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9473         * guile/scm-pretty-print.c
9474         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9475         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9476         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9477         (maintenance_print_msymbols): Use all_objfiles.
9478         * source.c (select_source_symtab): Use all_objfiles.
9479         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9480         * symfile.c (remove_symbol_file_command)
9481         (expand_symtabs_matching, map_symbol_filenames): Use
9482         all_objfiles.
9483         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9484         all_objfiles.
9485         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9486         * objc-lang.c (find_methods): Use all_objfiles.
9487         * objfiles.c (have_partial_symbols, have_full_symbols)
9488         (have_minimal_symbols, qsort_cmp)
9489         (default_iterate_over_objfiles_in_search_order): Use
9490         all_objfiles.
9491         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9492         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9493         (maintenance_check_psymtabs): Use all_objfiles.
9494         (ALL_PSYMTABS): Remove.
9495         * compile/compile-object-run.c (do_module_cleanup): Use
9496         all_objfiles.
9497         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9498         * cp-support.c (add_symbol_overload_list_qualified): Use
9499         all_objfiles.
9500         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9501         Use all_objfiles.
9502         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9503         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9504         all_objfiles.
9505         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9506         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9507         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9508         Uses all_objfiles.
9509         * solib.c (solib_read_symbols): Use all_objfiles
9510
9511 2019-01-09  Tom Tromey  <tom@tromey.com>
9512
9513         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9514         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9515         all_objfiles.
9516         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9517         * symmisc.c (print_symbol_bcache_statistics)
9518         (print_objfile_statistics, maintenance_print_objfiles)
9519         (maintenance_info_symtabs, maintenance_check_symtabs)
9520         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9521         all_objfiles.
9522         * source.c (forget_cached_source_info): Use all_objfiles.
9523         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9524         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9525         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9526         * objfiles.c (update_section_map): Use all_objfiles.
9527         (shared_objfile_contains_address_p): Likewise.
9528         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9529         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9530
9531 2019-01-09  Tom Tromey  <tom@tromey.com>
9532
9533         * common/next-iterator.h: New file.
9534         * objfiles.h (class all_objfiles): New.
9535         (struct objfile_iterator): New.
9536
9537 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9538
9539         * NEWS: Move the description of the changed "frame", "select-frame",
9540          and "info frame" commands to the Changed commands section.
9541
9542 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9543
9544         * gdbtypes.c (check_stub_method_group): Remove handling of old
9545         mangling schemes.
9546         * linespec.c (find_methods): Likewise.
9547         * stabsread.c (read_member_functions): Likewise.
9548         * valops.c (search_struct_method): Likewise.
9549         (value_struct_elt_for_reference): Likewise.
9550         * NEWS: Mention this change.
9551
9552 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9553
9554         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9555         print_source_lines.
9556         * source.c (print_source_lines_base): Update line number check.
9557         (print_source_lines): New function.
9558         (source_lines_range::source_lines_range): New function.
9559         * source.h (class source_lines_range): New class.
9560         (print_source_lines): New declaration.
9561
9562 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9563
9564         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9565
9566 2019-01-08  Tom Tromey  <tom@tromey.com>
9567             Simon Marchi  <simon.marchi@ericsson.com>
9568
9569         PR gdb/24060
9570         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9571         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9572         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9573         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9574         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9575         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9576
9577 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9578
9579         * source.c (select_source_symtab): Move header comment to
9580         declaration in source.h.
9581         (forget_cached_source_info_for_objfile): Likewise.
9582         (forget_cached_source_info): Likewise.
9583         (identify_source_line): Likewise.
9584         * source.h (identify_source_line): Move declaration from symtab.h
9585         and add comment from source.c
9586         (print_source_lines): Likewise.
9587         (forget_cached_source_info_for_objfile): Likewise.
9588         (forget_cached_source_info): Likewise.
9589         (select_source_symtab): Likewise.
9590         (enum print_source_lines_flag): Move definition from symtab.h.
9591         * symtab.h (identify_source_line): Move declaration to source.h.
9592         (print_source_lines): Likewise.
9593         (forget_cached_source_info_for_objfile): Likewise.
9594         (forget_cached_source_info): Likewise.
9595         (select_source_symtab): Likewise.
9596         (enum print_source_lines_flag): Move definition to source.h.
9597         * tui/tui-hooks.c: Add 'source.h' include.
9598
9599 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9600
9601         * source.c (print_source_lines_base): Handle requests to print
9602         reverse line number sequences, and guard against empty lines
9603         string.
9604
9605 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9606
9607         * source.c (print_source_lines_base): Fix skip of '\r' if next
9608         character is '\n'.
9609
9610 2019-01-06  Tom Tromey  <tom@tromey.com>
9611
9612         * c-exp.y (struct c_parse_state) <macro_original_text,
9613         expansion_obstack>: New member.
9614         (macro_original_text, expansion_obstack): Remove globals.
9615         (scan_macro_expansion, scanning_macro_expansion)
9616         (finished_macro_expansion): Update.
9617         (scan_macro_cleanup): Remove.
9618         (yylex, c_parse): Update.
9619
9620 2019-01-06  Tom Tromey  <tom@tromey.com>
9621
9622         * c-exp.y (struct c_parse_state) <strings>: New member.
9623         (operator_stoken): Update.
9624
9625 2019-01-06  Tom Tromey  <tom@tromey.com>
9626
9627         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9628         (union type_stack_elt) <typelist_val>: Now a pointer to
9629         std::vector.
9630         (type_stack_cleanup): Don't declare.
9631         (push_typelist): Update.
9632         * parse.c (pop_typelist): Return a std::vector.
9633         (push_typelist): Take a std::vector.
9634         (follow_types): Update.  Do not free args.
9635         (type_stack_cleanup): Remove.
9636         * c-exp.y (struct c_parse_state): New.
9637         (cpstate): New global.
9638         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9639         (nonempty_typelist): Update.
9640         (func_mod): Create a new vector.
9641         (c_parse): Create a c_parse_state.
9642         (check_parameter_typelist): Do not delete params.
9643         (function_method): Update.  Do not delete type_list.
9644
9645 2019-01-06  Tom Tromey  <tom@tromey.com>
9646
9647         PR gdb/28155:
9648         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9649         check_typedef.
9650         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9651         (print_return_value): Likewise.
9652
9653 2019-01-05  Tom Tromey  <tom@tromey.com>
9654
9655         * contrib/cleanup_check.py: Remove.
9656         * contrib/gcc-with-excheck: Remove.
9657         * contrib/exsummary.py: Remove.
9658         * contrib/excheck.py: Remove.
9659
9660 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9661
9662         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9663         NULL. Initialize tpprev to NULL instead of assigning it
9664         to NULL on the next statement.
9665         * windows-nat.c (windows_delete_thread): Remove check for
9666         main_thread_id before printing thread exit notifications.
9667         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9668         Remove thread ID check against main_thread_id.
9669         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9670         windows_delete_thread.
9671         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9672
9673 2019-01-04  Tom Tromey  <tom@tromey.com>
9674
9675         * compile/compile.c (_initialize_compile): Use upper case for
9676         metasyntactic variables.
9677         * symmisc.c (_initialize_symmisc): Use upper case for
9678         metasyntactic variables.
9679         * psymtab.c (_initialize_psymtab): Use upper case for
9680         metasyntactic variables.
9681         * demangle.c (demangle_command): Use upper case for metasyntactic
9682         variables.
9683         (_initialize_demangler): Likewise.
9684         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9685         variables.
9686
9687 2019-01-03  Tom Tromey  <tom@tromey.com>
9688
9689         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9690
9691 2019-01-03  Tom Tromey  <tom@tromey.com>
9692
9693         * python/py-symtab.c (salpy_str): Update.
9694         (struct salpy_sal_object) <symtab>: Now a PyObject.
9695         (salpy_dealloc): Update.
9696         (del_objfile_sal): Use gdbpy_ref.
9697
9698 2019-01-03  Tom Tromey  <tom@tromey.com>
9699
9700         * python/py-type.c (convert_field): Use new_reference.  Return
9701         gdbpy_ref.
9702         (make_fielditem): Return gdbpy_ref.
9703         (typy_fields): Update.
9704         (typy_getitem): Update.
9705         (field_name): Return gdbpy_ref.  Use new_reference.
9706         (typy_iterator_iternext): Update.
9707
9708 2019-01-03  Tom Tromey  <tom@tromey.com>
9709
9710         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9711
9712 2019-01-03  Tom Tromey  <tom@tromey.com>
9713
9714         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9715         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9716         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9717         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9718         (pspy_set_type_printers): Likewise.
9719         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9720         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9721         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9722         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9723         (objfpy_set_type_printers): Likewise.
9724
9725 2019-01-03  Tom Tromey  <tom@tromey.com>
9726
9727         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9728         (gdbpy_print_stack): Use gdbpy_err_fetch.
9729         * python/python-internal.h (class gdbpy_err_fetch): New class.
9730         (class gdbpy_enter) <m_error_type, m_error_value,
9731         m_error_traceback>: Remove.
9732         <m_error>: New member.
9733         (gdbpy_exception_to_string): Don't declare.
9734         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9735         * python/py-value.c (convert_value_from_python): Use
9736         gdbpy_err_fetch.
9737         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9738         gdbpy_exception_to_string.
9739         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9740         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9741         gdbpy_err_fetch.
9742
9743 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9744
9745         * linux-nat.c (delete_lwp_cleanup): Delete.
9746         (struct lwp_deleter): New struct.
9747         (lwp_info_up): New typedef.
9748         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9749         lwp_info_up.
9750
9751 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9752
9753         * linux-fork.c (class scoped_switch_fork_info): New class.
9754         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9755
9756 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9757
9758         * valops.c (find_overload_match): Remove use of null_cleanup, and
9759         calls to do_cleanups.
9760
9761 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9762
9763         * compile/compile-cplus-types.c
9764         (compile_cplus_instance::decl_name): Handle changes to
9765         cp_func_name.
9766         * cp-support.c (cp_func_name): Update header comment, update
9767         return type.
9768         * cp-support.h (cp_func_name): Update return type in declaration.
9769         * valops.c (find_overload_match): Move temp_func local to top
9770         level of function and change its type.  Use temp_func to hold and
9771         delete temporary string obtained from cp_func_name.
9772
9773 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9774
9775         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9776         gdb::char_vector, remove cleanup, and update uses of `msg`.
9777
9778 2019-01-03  Jim Wilson  <jimw@sifive.com>
9779
9780         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9781
9782 2019-01-02  Tom Tromey  <tom@tromey.com>
9783
9784         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9785         (tdesc_parse_xml): Remove cleanups.
9786         * target-descriptions.h (make_cleanup_free_target_description):
9787         Don't declare.
9788         (target_desc_deleter): New struct.
9789         (target_desc_up): New typedef.
9790         * target-descriptions.c (target_desc_deleter::operator()): Rename
9791         from free_target_description.
9792         (make_cleanup_free_target_description): Remove.
9793
9794 2019-01-02  Tom Tromey  <tom@tromey.com>
9795
9796         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9797         constructor, destructor.
9798         (linespec_parser): Remove typedef.
9799         (~linespec_parser): Rename from linespec_parser_delete.
9800         (linespec_lex_to_end, linespec_complete_label)
9801         (linespec_complete): Update.
9802         (decode_line_full): Remove cleanups.
9803         (decode_line_1): Update.
9804
9805 2019-01-02  Tom Tromey  <tom@tromey.com>
9806
9807         * python/python-internal.h (inferior_to_inferior_object): Change
9808         return type.
9809         * python/py-exitedevent.c (create_exited_event_object): Update.
9810         * python/py-inferior.c (inferior_to_inferior_object): Return
9811         gdbpy_ref.
9812         (python_new_inferior, python_inferior_deleted)
9813         (thread_to_thread_object, delete_thread_object)
9814         (build_inferior_list, gdbpy_selected_inferior): Update.
9815         * python/py-infthread.c (create_thread_object): Update.  Also fail
9816         if inferior_to_inferior_object fails.
9817
9818 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9819
9820         * inferior.h (class inferior) <displaced_step_state>: New field.
9821         * infrun.h (struct displaced_step_state): Move here from
9822         infrun.c.  Initialize fields, add constructor.
9823         <inf>: Remove field.
9824         <reset>: New method.
9825         * infrun.c (struct displaced_step_inferior_state): Move to
9826         infrun.h.
9827         (displaced_step_inferior_states): Remove.
9828         (get_displaced_stepping_state): Adust.
9829         (displaced_step_in_progress_any_inferior): Adjust.
9830         (displaced_step_in_progress_thread): Adjust.
9831         (displaced_step_in_progress): Adjust.
9832         (add_displaced_stepping_state): Remove.
9833         (get_displaced_step_closure_by_addr): Adjust.
9834         (remove_displaced_stepping_state): Remove.
9835         (infrun_inferior_exit): Call displaced_step_state.reset.
9836         (use_displaced_stepping): Don't check for NULL.
9837         (displaced_step_prepare_throw): Call
9838         get_displaced_stepping_state.
9839         (displaced_step_fixup): Don't check for NULL.
9840         (prepare_for_detach): Don't check for NULL.
9841
9842 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9843
9844         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
9845          in case of call that did not complete.
9846
9847 2019-01-02  Andrey Utkin  <autkin@undo.io>
9848
9849         * symfile.c (find_separate_debug_file): Fix search of debug files for
9850         remote debuggee.
9851
9852 2019-01-02  Tom Tromey  <tom@tromey.com>
9853
9854         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
9855         indentation.
9856         * python/py-frame.c (frapy_older): Remove cast.
9857         (frapy_newer): Likewise.
9858         * python/py-breakpoint.c (local_setattro): Remove cast.
9859         * python/py-arch.c (archpy_name): Remove local variable.
9860         * python/py-type.c (gdbpy_lookup_type): Remove cast.
9861
9862 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
9863
9864         * unittests/basic_string_view/element_access/char/empty.cc:
9865         Fix year range in copyright header.
9866
9867 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9868
9869         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
9870         Delete.
9871         <operator==>: Update with for removed field.
9872         <hash>: Likewise.
9873         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
9874         <isa_features>: ...this.
9875         <abi_features>: New field.
9876         (riscv_isa_flen): Update comment.
9877         (riscv_abi_xlen): New declaration.
9878         (riscv_abi_flen): New declaration.
9879         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
9880         isa_features.
9881         (riscv_abi_xlen): New function.
9882         (riscv_isa_flen): Update to get answer from isa_features.
9883         (riscv_abi_flen): New function.
9884         (riscv_has_fp_abi): Update to get answer from abi_features.
9885         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
9886         xlen and flen.
9887         (riscv_call_info) <xlen, flen>: Update comment.
9888         (riscv_call_arg_struct): Remove invalid assertions
9889         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
9890         is removed.
9891         (riscv_gdbarch_init): Gather isa features and abi features
9892         separately, ensure both match on the gdbarch when reusing an old
9893         gdbarch.  Relax an error check to allow 32-bit abi float to run on
9894         a target with 64-bit float hardware.
9895
9896 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9897
9898         * source.c (search_command_helper): Stop reverse search
9899         when line 1 has been searched.
9900
9901 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9902
9903         * record-full.c (record_full_base_target::close): Rewrite
9904         record_full_core_buf_list free logic.
9905
9906 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9907
9908         * break-catch-syscall.c (print_one_catch_syscall): xfree
9909         the last text.
9910
9911 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9912
9913         * top.c (print_gdb_version): Update Copyright year in version
9914         message.
9915
9916 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9917
9918         Update copyright year range in all GDB files.
9919
9920 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
9921
9922         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
9923
9924 For older changes see ChangeLog-2018.
9925 \f
9926 Local Variables:
9927 mode: change-log
9928 left-margin: 8
9929 fill-column: 74
9930 version-control: never
9931 coding: utf-8
9932 End:
9933