Fix crash in dwarf2read.c with template parameters
[external/binutils.git] / gdb / ChangeLog
1 2019-04-30  Tom Tromey  <tromey@adacore.com>
2
3         PR c++/24470:
4         * dwarf2read.c (process_structure_scope): Handle case where type
5         has template parameters but no symbol was created.
6
7 2019-04-19  Sergei Trofimovich <siarheit@google.com>
8
9         * configure.ac: add --enable-source-highlight switch.
10         * configure: Regenerate.
11         * top.c (print_gdb_version): plumb --enable-source-highlight
12         status to "show configuration".
13
14 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
15
16         PR symtab/24423:
17         * source.c (print_source_lines_base): Advance "iter" when a
18         control character is seen.
19
20 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
21
22         * inferior.h (struct infcall_suspend_state_deleter):
23         Catch exception in destructor to avoid crash.
24
25 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
26
27         * utils.c (prompt_for_continue): Don't restore the styling at the
28         end, as applied_style has the wrong value.  This fixes styling in
29         long lists of file names that are interrupted by the "Continue?"
30         prompt.
31
32 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
33
34         * version.in: Set GDB version number to 8.2.91.DATE-git.
35
36 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
37
38         GDB 8.2.91 released.
39
40 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
41
42         * version.in: Set GDB version number to 8.2.91.
43
44 2019-03-20  Tom Tromey  <tromey@adacore.com>
45
46         PR gdb/24391
47         * infrun.c (handle_inferior_event): Rename from
48         handle_inferior_event_1.  Create a scoped_value_mark.
49         (handle_inferior_event): Remove.
50
51 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
52
53         * source-cache.c (source_cache::get_source_lines): Re-read
54         fullname after calling open_source_file.
55
56 2019-03-18  Pedro Alves  <palves@redhat.com>
57             Eli Zaretskii <eliz@gnu.org>
58
59         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
60         m_line and m_start_of_line.
61
62 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
63
64         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
65         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
66         it returns a newline.  This fixes a regression in TU mode, whereby
67         the next line is output on the same screen line as the user input.
68
69 2019-03-18  Pedro Alves  <palves@redhat.com>
70
71         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
72         New globals.
73         (apply_style): New, factored out from ...
74         (apply_ansi_escape): ... this.  Handle reverse video mode.
75         (tui_set_reverse_mode): New function.
76         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
77         * tui/tui-winsource.c (tui_show_source_line): Use
78         tui_set_reverse_mode instead of setting A_STANDOUT.
79         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
80         New setter methods.
81
82 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
83
84         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
85         Handle tabs.
86
87 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
88
89         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
90         tui_refill_source_window instead of tui_refresh_win, to update the
91         current execution line.  This fixes redisplay of the current line
92         when stepping through the code with "next" or "step".
93
94 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
95
96         * source-cache.c (source_cache::get_source_lines): Call
97         find_source_lines to initialize s->nlines.  This fixes vertical
98         scrolling of TUI source window when the DOWN arrow is pressed.
99
100 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
101
102         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
103         wclrtoeol in tui_show_source_line".  This reverts changes made in
104         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
105
106 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
107
108         * NEWS: Combine separate "New targets" sections for 8.3.
109
110 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
111
112         The MS-Windows port of ncurses fails to switch to a color pair if
113         one or both of the colors are the implicit default colors.  This
114         change records the default colors when TUI is initialized, and
115         then specifies them explicitly when a color pair uses the default
116         colors.  This allows color styling in TUI mode on MS-Windows.
117
118         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
119         ncurses_norm_attr.
120         (tui_initialize_io) [__MINGW32__]: Record the default terminal
121         colors in ncurses_norm_attr.
122         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
123         "none", replace it with the default color recorded in
124         ncurses_norm_attr.
125
126 2019-03-14  Tom Tromey  <tromey@adacore.com>
127
128         * source-cache.h (class source_cache) <get_source_lines>: Return
129         std::string.
130         * source-cache.c (source_cache::extract_lines): Handle case where
131         first_pos==npos.  Return std::string.
132         (source_cache::get_source_lines): Update.
133
134 2019-03-14  Tom Tromey  <tromey@adacore.com>
135
136         * NEWS: Add item for "style sources" commands.
137         * source-cache.c (source_cache::get_source_lines): Check
138         source_styling.
139         * cli/cli-style.c (source_styling): New global.
140         (_initialize_cli_style): Add "style sources" commands.
141         (show_style_sources): New function.
142         * cli/cli-style.h (source_styling): Declare.
143
144 2019-03-14  Pedro Alves  <palves@redhat.com>
145             Tom Tromey  <tromey@adacore.com>
146
147         * tui/tui-winsource.h (tui_refill_source_window): Declare.
148         * tui/tui-winsource.c (tui_refill_source_window): New function,
149         from...
150         (tui_horizontal_source_scroll): ... here.  Move some logic.
151         * cli/cli-style.c (set_style_enabled): Notify new observable.
152         * tui/tui-hooks.c (tui_redisplay_source): New function.
153         (tui_attach_detach_observers): Attach or detach
154         tui_redisplay_source.
155         * observable.h (source_styling_changed): New observable.
156         * observable.c: Define source_styling_changed observable.
157
158 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
159
160         PR/24325
161         * source-cache.c: #undef open and close, to avoid unresolved
162         externals during linking.
163
164 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
165
166         Support styling on native MS-Windows console
167
168         PR/24315
169         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
170         on MS-Windows if $TERM is not defined.
171
172         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
173
174         * posix-hdep.c (gdb_console_fputs):
175         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
176         functions.
177         * ui-file.h (gdb_console_fputs): Add prototype.
178
179         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
180         back to fputs only if the former returns zero.
181
182 2019-03-07  Brian Vandenberg  <phantall@gmail.com>
183             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
184
185         PR gdb/8527
186         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
187         set_sigint_trap, clear_sigint_trap.
188
189 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
190
191         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
192         for-loop range, to avoid compiler warnings.
193
194         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
195         avoid compiler warnings about unused variables.
196
197 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
198
199         * NEWS: Mention end of support for native debugging on MS-Windows
200         before XP.
201
202 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
203
204         PR gdb/24292
205         * common/netstuff.c:
206         * gdbserver/gdbreplay.c
207         * gdbserver/remote-utils.c:
208         * ser-tcp.c:
209         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
210         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
211         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
212         'getaddrinfo' and 'freeaddrinfo' were not available before
213         Windows XP, and mingw.org's MinGW headers by default define
214         _WIN32_WINNT to 0x500.
215
216 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
217     
218         * NEWS: Note minimum Python version.
219
220 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
221
222         * version.in: Set GDB version number to 8.2.90.DATE-git.
223
224 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
225
226         GDB 8.2.90 released.
227
228 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
229
230         * version.in: Set GDB version number to 8.2.90.
231
232 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
233
234         * NEWS: Change "Changes since GDB 8.2" into "Changes in GDB 8.3".
235
236 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
237
238         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
239         * version.in: Bump version to 8.2.90.DATE-git.
240
241 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
242
243         * aix-thread.c (ptid_cmp): Remove unused variable.
244         (get_signaled_thread): Likewise.
245         (store_regs_user_thread): Likewise.
246         (store_regs_kernel_thread): Likewise.
247         (fetch_regs_kernel_thread): Remove shadowed variable.
248
249 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
250
251         * features/riscv/32bit-cpu.xml: Add register numbers.
252         * features/riscv/32bit-fpu.c: Regenerate.
253         * features/riscv/32bit-fpu.xml: Add register numbers.
254         * features/riscv/64bit-cpu.xml: Add register numbers.
255         * features/riscv/64bit-fpu.c: Regenerate.
256         * features/riscv/64bit-fpu.xml: Add register numbers.
257
258 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
259
260         * NEWS: Mention two argument form of gdb.Value constructor.
261         * python/py-value.c (convert_buffer_and_type_to_value): New
262         function.
263         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
264         Add support for handling an optional second argument.  Call
265         convert_buffer_and_type_to_value as appropriate.
266         * python/python-internal.h (Py_buffer_deleter): New struct.
267         (Py_buffer_up): New typedef.
268
269 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
270
271         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
272         instead of releasing ownership.
273
274 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
275
276         * dwarf2read.c (open_and_init_dwp_file): Call
277         elf_numsections instead of bfd_count_sections to initialize
278         dwp_file->num_sections.
279
280 2019-02-25  Tom Tromey  <tromey@adacore.com>
281
282         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
283
284 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
285
286         * gcore.in: Add '--readnever' option when invoking GDB.
287
288 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
289
290         * MAINTAINERS: Update my email address.
291
292 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
293
294         * build-id.c (build_id_to_debug_bfd_1): New function.
295         (build_id_to_debug_bfd): Look for separate debug file in
296         sysroot.
297
298 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
299
300         * gdbarch.sh: Update the copyright year range that is placed into
301         generated files.
302
303 2019-02-22  Keith Seitz  <keiths@redhat.com>
304
305         PR symtab/23853
306         * linespec.c (create_sals_line_offset): Search for the default
307         symtab's filename instead of its fullname.
308
309 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
310
311         * NEWS: Update style defaults.
312
313 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
314
315         * main.c (captured_main_1): Disable styling in batch mode.
316
317 2019-02-20  Tom Tromey  <tom@tromey.com>
318
319         * symtab.c (symtab_symbol_info): Fix typos.
320
321 2019-02-20  Tom Tromey  <tromey@adacore.com>
322
323         * findcmd.c (_initialize_mem_search): Use upper case for
324         metasyntactic variables.
325
326 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
327
328         * aarch64-tdep.c (aarch64_add_reggroups): New function.
329         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
330
331 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
332
333         * top.h (source_file_name): Change to std::string.
334         * top.c (source_file_name): Likewise.
335         (command_line_input): Adjust.
336         * cli/cli-script.c (script_from_file): Adjust.
337
338 2019-02-19  Tom Tromey  <tromey@adacore.com>
339
340         * ravenscar-thread.c
341         (ravenscar_thread_target::update_thread_list): Don't call
342         ada_build_task_list.
343         * ada-lang.h (ada_build_task_list): Don't declare.
344         * ada-tasks.c (struct ada_tasks_inferior_data)
345         <task_list_valid_p>: Now bool.
346         (read_known_tasks, ada_task_list_changed)
347         (ada_tasks_invalidate_inferior_data): Update.
348         (read_known_tasks_array): Return bool.
349         (read_known_tasks_list): Likewise.
350         (read_known_tasks): Return void.
351         (ada_build_task_list): Now static.
352
353 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
354
355         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
356         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
357
358 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
359
360         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
361         variant for ada_tasks_pspace_data_handle and
362         ada_tasks_inferior_data_handle.
363         (ada_tasks_pspace_data_cleanup): New function.
364         (ada_tasks_inferior_data_cleanup): New function.
365
366 2019-02-17  Tom Tromey  <tom@tromey.com>
367
368         * macrotab.h (macro_source_fullname): Return a std::string.
369         * macrotab.c (macro_include, check_for_redefinition)
370         (macro_undef, macro_lookup_definition, foreach_macro)
371         (foreach_macro_in_scope): Update.
372         (macro_source_fullname): Return a std::string.
373         * macrocmd.c (show_pp_source_pos): Update.
374
375 2019-02-17  Tom Tromey  <tom@tromey.com>
376
377         * macrocmd.c (show_pp_source_pos): Style the file names.
378
379 2019-02-17  Tom Tromey  <tom@tromey.com>
380
381         PR tui/24197:
382         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
383
384 2019-02-17  Tom Tromey  <tom@tromey.com>
385
386         * ada-lang.c (user_select_syms): Use filtered printing.
387         * utils.c (wrap_style): New global.
388         (desired_style): Remove.
389         (emit_style_escape): Add stream parameter.
390         (set_output_style, reset_terminal_style, prompt_for_continue):
391         Update.
392         (flush_wrap_buffer): Only flush gdb_stdout.
393         (wrap_here): Set wrap_style.
394         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
395         treat escape sequences as a character.  Change when wrap buffer is
396         flushed.
397         (fputs_styled): Do not set the output style when the default is
398         requested.
399         * ui-style.h (struct ui_file_style) <is_default>: New method.
400         * source.c (print_source_lines_base): Emit escape sequences in one
401         piece.
402
403 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
404
405         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
406         integers and enumeration types.
407
408 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
409
410         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
411         instead of lookup_symbol_in_language
412         (do_exact_match): New function.
413         (ada_get_symbol_name_matcher): Return do_exact_match when
414         doing a verbatim match.
415
416 2019-02-15  Tom Tromey  <tromey@adacore.com>
417
418         * ravenscar-thread.c (ravenscar_thread_target::resume)
419         (ravenscar_thread_target::wait): Special case wildcard requests.
420
421 2019-02-15  Tom Tromey  <tromey@adacore.com>
422
423         * ravenscar-thread.c (base_ptid): Remove.
424         (struct ravenscar_thread_target) <close>: New method.
425         <m_base_ptid>: New member.
426         <update_inferior_ptid, active_task, task_is_currently_active,
427         runtime_initialized>: Declare methods.
428         <ravenscar_thread_target>: Add constructor.
429         (ravenscar_thread_target::task_is_currently_active)
430         (ravenscar_thread_target::update_inferior_ptid)
431         (ravenscar_runtime_initialized): Rename.  Now methods.
432         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
433         (ravenscar_thread_target::update_thread_list): Update.
434         (ravenscar_thread_target::active_task): Now method.
435         (ravenscar_thread_target::store_registers)
436         (ravenscar_thread_target::prepare_to_store)
437         (ravenscar_thread_target::prepare_to_store)
438         (ravenscar_thread_target::mourn_inferior): Update.
439         (ravenscar_inferior_created): Use "new" to create target.
440         (ravenscar_thread_target::get_ada_task_ptid): Update.
441         (_initialize_ravenscar): Don't initialize base_ptid.
442         (ravenscar_ops): Remove global.
443
444 2019-02-15  Tom Tromey  <tromey@adacore.com>
445
446         * target.h (push_target): Declare new overload.
447         * target.c (push_target): New overload, taking an rvalue reference.
448         * remote.c (remote_target::open_1): Use push_target overload.
449         * corelow.c (core_target_open): Use push_target overload.
450
451 2019-02-15  Tom Tromey  <tromey@adacore.com>
452
453         * ravenscar-thread.c (is_ravenscar_task)
454         (ravenscar_task_is_currently_active): Return bool.
455         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
456         (_initialize_ravenscar): Remove "(void)".
457         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
458         Return bool.
459
460 2019-02-15  Tom Tromey  <tromey@adacore.com>
461
462         * ravenscar-thread.c (ravenscar_runtime_initializer)
463         (has_ravenscar_runtime, get_running_thread_id)
464         (ravenscar_thread_target::resume): Fix indentation.
465
466 2019-02-15  Tom Tromey  <tromey@adacore.com>
467
468         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
469         from ravenscar_arch_ops.
470         (sparc_ravenscar_ops::fetch_registers)
471         (sparc_ravenscar_ops::store_registers): Now methods.
472         (sparc_ravenscar_prepare_to_store): Remove.
473         (sparc_ravenscar_ops): Redefine.
474         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
475         methods and destructor.  Remove members.
476         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
477         (ravenscar_thread_target::store_registers)
478         (ravenscar_thread_target::prepare_to_store): Update.
479         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
480         Remove.
481         (struct ppc_ravenscar_powerpc_ops): Derive from
482         ravenscar_arch_ops.
483         (ppc_ravenscar_powerpc_ops::fetch_registers)
484         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
485         (ppc_ravenscar_powerpc_ops): Redefine.
486         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
487         (ppc_ravenscar_e500_ops::fetch_registers)
488         (ppc_ravenscar_e500_ops::store_registers): Now methods.
489         (ppc_ravenscar_e500_ops): Redefine.
490         * aarch64-ravenscar-thread.c
491         (aarch64_ravenscar_generic_prepare_to_store): Remove.
492         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
493         (aarch64_ravenscar_fetch_registers)
494         (aarch64_ravenscar_store_registers): Now methods.
495         (aarch64_ravenscar_ops): Redefine.
496
497 2019-02-15  Tom Tromey  <tromey@adacore.com>
498
499         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
500         (ravenscar_thread_target::stopped_by_hw_breakpoint)
501         (ravenscar_thread_target::stopped_by_watchpoint)
502         (ravenscar_thread_target::stopped_data_address)
503         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
504
505 2019-02-15  Tom Tromey  <tromey@adacore.com>
506
507         * ravenscar-thread.c: Fix some typos.
508
509 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
510             Tom Tromey  <tromey@adacore.com>
511
512         * ada-lang.c (ada_exception_sal): Change addr_string to a
513         std::string.
514         (create_ada_exception_catchpoint): Update.
515
516 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
517             Tom Tromey  <tromey@adacore.com>
518
519         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
520         (bp_location_ops): Remove.
521         (base_breakpoint_allocate_location): Update.
522         (free_bp_location): Update.
523         * ada-lang.c (class ada_catchpoint_location)
524         <ada_catchpoint_location>: Remove ops parameter.
525         (ada_catchpoint_location_dtor): Remove.
526         (ada_catchpoint_location_ops): Remove.
527         (allocate_location_exception): Update.
528         * breakpoint.h (struct bp_location_ops): Remove.
529         (class bp_location) <bp_location>: Remove bp_location_ops
530         parameter.
531         <~bp_location>: Add destructor.
532         <ops>: Remove.
533
534 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
535             Pedro Alves  <palves@redhat.com>
536
537         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
538         'PATH_MAX'.
539
540 2019-02-14  David Michael  <fedora.dm0@gmail.com>
541             Samuel Thibault  <samuel.thibault@gnu.org>
542             Thomas Schwinge  <thomas@codesourcery.com>
543
544         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
545         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
546
547 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
548
549         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
550         (check_empty): Use "const char *".
551
552         * gnu-nat.c (gnu_nat_target::detach): Instead of
553         'detach_inferior (pid)' call
554         'detach_inferior (find_inferior_pid (pid))'.
555
556         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
557         'nat/fork-inferior.o'.
558         * gnu-nat.c: #include "nat/fork-inferior.h".
559
560         * gnu-nat.c (gnu_nat_target::detach): Instead of
561         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
562         * gnu-nat.h: #include "inf-child.h".
563         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
564         'i386_gnu_nat_target::fetch_registers'.
565         (gnu_store_registers): Rename/move to
566         'i386_gnu_nat_target::store_registers'.
567
568         * config/i386/nm-i386gnu.h: Don't "#include" any files.
569         * gnu-nat.h (mach_thread_info): New function.
570         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
571
572         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
573
574 2019-02-14  Frederic Konrad  <konrad@adacore.com>
575
576         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
577
578 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
579
580         * windows-nat.c (windows_add_thread): Add new parameter
581         "main_thread_p" with default value set to false.  Update
582         function documentation as well as all callers.
583         (windows_delete_thread): Likewise.
584         (fake_create_process): Update call to windows_add_thread.
585         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
586         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
587         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
588         call to windows_delete_thread.
589
590 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
591
592         * MAINTAINERS: Add Andrew Burgess as global maintainer.
593
594 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
595
596         * symfile.c (find_separate_debug_file): Use canonical path of
597         sysroot with child_path instead of gdb_sysroot if it is valid.
598
599 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
600
601         * symfile.c (find_separate_debug_file): Use child_path to
602         determine if an object file is under a sysroot.
603
604 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
605
606         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
607         unittests/child-path-selftests.c.
608         * common/pathstuff.c (child_path): New function.
609         * common/pathstuff.h (child_path): New prototype.
610         * unittests/child-path-selftests.c: New file.
611
612 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
613
614         * symfile.c (find_separate_debug_file): Look for separate debug
615         files in debug directories under the sysroot.
616
617 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
618
619         * symtab.h (struct minimal_symbol data_p): New const method.
620         (struct minimal_symbol text_p): Likewise.
621         * symtab.c (output_source_filename): Use file name style
622         to print file name.
623         (print_symbol_info): Likewise.
624         (print_msymbol_info): Use address style to print addresses.
625         Use function name style to print executable text symbols.
626         (expand_symtab_containing_pc): Use data_p.
627         (find_pc_sect_compunit_symtab): Likewise.
628
629 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
630
631         * breakpoint.c (describe_other_breakpoints): Use address style
632         to print addresses.
633         (say_where): Likewise.
634
635 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
636
637         * ada-typeprint.c (print_func_type): Print function name
638         style to print function name.
639         * c-typeprint.c (c_print_type_1): Likewise.
640
641 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
642
643         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
644         for execve.
645
646 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
647
648         * c-exp.y (direct_abs_decl): Use emplace_back to record the
649         type_stack.
650
651 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
652
653         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
654         TYPE_CODE_REF types.
655
656 2019-02-08  Jim Wilson  <jimw@sifive.com>
657
658         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
659         (riscv_linux_fregset): New.
660         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
661
662 2019-02-07  Tom Tromey  <tom@tromey.com>
663
664         * thread.c (thread_cancel_execution_command): Update.
665         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
666         methods.
667         (struct thread_fsm_ops): Remove.
668         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
669         (thread_fsm_should_stop, thread_fsm_return_value)
670         (thread_fsm_set_finished, thread_fsm_finished_p)
671         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
672         Don't declare.
673         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
674         * infrun.c (clear_proceed_status_thread)
675         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
676         (print_stop_event): Update.
677         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
678         Add constructor.
679         (step_command_fsm_ops): Remove.
680         (new_step_command_fsm): Remove.
681         (step_1): Update.
682         (step_command_fsm::should_stop): Rename from
683         step_command_fsm_should_stop.
684         (step_command_fsm::clean_up): Rename from
685         step_command_fsm_clean_up.
686         (step_command_fsm::do_async_reply_reason): Rename from
687         step_command_fsm_async_reply_reason.
688         (struct until_next_fsm): Inherit from thread_fsm.  Add
689         constructor.
690         (until_next_fsm_ops): Remove.
691         (new_until_next_fsm): Remove.
692         (until_next_fsm::should_stop): Rename from
693         until_next_fsm_should_stop.
694         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
695         (until_next_fsm::do_async_reply_reason): Rename from
696         until_next_fsm_async_reply_reason.
697         (struct finish_command_fsm): Inherit from thread_fsm.  Add
698         constructor.  Change type of breakpoint.
699         (finish_command_fsm_ops): Remove.
700         (new_finish_command_fsm): Remove.
701         (finish_command_fsm::should_stop): Rename from
702         finish_command_fsm_should_stop.
703         (finish_command_fsm::clean_up): Rename from
704         finish_command_fsm_clean_up.
705         (finish_command_fsm::return_value): Rename from
706         finish_command_fsm_return_value.
707         (finish_command_fsm::do_async_reply_reason): Rename from
708         finish_command_fsm_async_reply_reason.
709         (finish_command): Update.
710         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
711         Add constructor.
712         (call_thread_fsm_ops): Remove.
713         (call_thread_fsm::call_thread_fsm): Rename from
714         new_call_thread_fsm.
715         (call_thread_fsm::should_stop): Rename from
716         call_thread_fsm_should_stop.
717         (call_thread_fsm::should_notify_stop): Rename from
718         call_thread_fsm_should_notify_stop.
719         (run_inferior_call, call_function_by_hand_dummy): Update.
720         * cli/cli-interp.c (should_print_stop_to_console): Update.
721         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
722         Add constructor.  Change type of location_breakpoint,
723         caller_breakpoint.
724         (until_break_fsm_ops): Remove.
725         (new_until_break_fsm): Remove.
726         (until_break_fsm::should_stop): Rename from
727         until_break_fsm_should_stop.
728         (until_break_fsm::clean_up): Rename from
729         until_break_fsm_clean_up.
730         (until_break_fsm::do_async_reply_reason): Rename from
731         until_break_fsm_async_reply_reason.
732         (until_break_command): Update.
733         * thread-fsm.c: Remove.
734         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
735
736 2019-02-07  Tom Tromey  <tom@tromey.com>
737
738         * yy-remap.h: Add include guard.
739         * xtensa-tdep.h: Add include guard.
740         * xcoffread.h: Rename include guard.
741         * varobj-iter.h: Add include guard.
742         * tui/tui.h: Rename include guard.
743         * tui/tui-winsource.h: Rename include guard.
744         * tui/tui-wingeneral.h: Rename include guard.
745         * tui/tui-windata.h: Rename include guard.
746         * tui/tui-win.h: Rename include guard.
747         * tui/tui-stack.h: Rename include guard.
748         * tui/tui-source.h: Rename include guard.
749         * tui/tui-regs.h: Rename include guard.
750         * tui/tui-out.h: Rename include guard.
751         * tui/tui-layout.h: Rename include guard.
752         * tui/tui-io.h: Rename include guard.
753         * tui/tui-hooks.h: Rename include guard.
754         * tui/tui-file.h: Rename include guard.
755         * tui/tui-disasm.h: Rename include guard.
756         * tui/tui-data.h: Rename include guard.
757         * tui/tui-command.h: Rename include guard.
758         * tic6x-tdep.h: Add include guard.
759         * target/waitstatus.h: Rename include guard.
760         * target/wait.h: Rename include guard.
761         * target/target.h: Rename include guard.
762         * target/resume.h: Rename include guard.
763         * target-float.h: Rename include guard.
764         * stabsread.h: Add include guard.
765         * rs6000-tdep.h: Add include guard.
766         * riscv-fbsd-tdep.h: Add include guard.
767         * regformats/regdef.h: Rename include guard.
768         * record.h: Rename include guard.
769         * python/python.h: Rename include guard.
770         * python/python-internal.h: Rename include guard.
771         * python/py-stopevent.h: Rename include guard.
772         * python/py-ref.h: Rename include guard.
773         * python/py-record.h: Rename include guard.
774         * python/py-record-full.h: Rename include guard.
775         * python/py-record-btrace.h: Rename include guard.
776         * python/py-instruction.h: Rename include guard.
777         * python/py-events.h: Rename include guard.
778         * python/py-event.h: Rename include guard.
779         * procfs.h: Add include guard.
780         * proc-utils.h: Add include guard.
781         * p-lang.h: Add include guard.
782         * or1k-tdep.h: Rename include guard.
783         * observable.h: Rename include guard.
784         * nto-tdep.h: Rename include guard.
785         * nat/x86-linux.h: Rename include guard.
786         * nat/x86-linux-dregs.h: Rename include guard.
787         * nat/x86-gcc-cpuid.h: Add include guard.
788         * nat/x86-dregs.h: Rename include guard.
789         * nat/x86-cpuid.h: Rename include guard.
790         * nat/ppc-linux.h: Rename include guard.
791         * nat/mips-linux-watch.h: Rename include guard.
792         * nat/linux-waitpid.h: Rename include guard.
793         * nat/linux-ptrace.h: Rename include guard.
794         * nat/linux-procfs.h: Rename include guard.
795         * nat/linux-osdata.h: Rename include guard.
796         * nat/linux-nat.h: Rename include guard.
797         * nat/linux-namespaces.h: Rename include guard.
798         * nat/linux-btrace.h: Rename include guard.
799         * nat/glibc_thread_db.h: Rename include guard.
800         * nat/gdb_thread_db.h: Rename include guard.
801         * nat/gdb_ptrace.h: Rename include guard.
802         * nat/fork-inferior.h: Rename include guard.
803         * nat/amd64-linux-siginfo.h: Rename include guard.
804         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
805         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
806         * nat/aarch64-linux.h: Rename include guard.
807         * nat/aarch64-linux-hw-point.h: Rename include guard.
808         * mn10300-tdep.h: Add include guard.
809         * mips-linux-tdep.h: Add include guard.
810         * mi/mi-parse.h: Rename include guard.
811         * mi/mi-out.h: Rename include guard.
812         * mi/mi-main.h: Rename include guard.
813         * mi/mi-interp.h: Rename include guard.
814         * mi/mi-getopt.h: Rename include guard.
815         * mi/mi-console.h: Rename include guard.
816         * mi/mi-common.h: Rename include guard.
817         * mi/mi-cmds.h: Rename include guard.
818         * mi/mi-cmd-break.h: Rename include guard.
819         * m2-lang.h: Add include guard.
820         * location.h: Rename include guard.
821         * linux-record.h: Rename include guard.
822         * linux-nat.h: Add include guard.
823         * linux-fork.h: Add include guard.
824         * i386-darwin-tdep.h: Rename include guard.
825         * hppa-linux-offsets.h: Add include guard.
826         * guile/guile.h: Rename include guard.
827         * guile/guile-internal.h: Rename include guard.
828         * gnu-nat.h: Rename include guard.
829         * gdb-stabs.h: Rename include guard.
830         * frv-tdep.h: Add include guard.
831         * f-lang.h: Add include guard.
832         * event-loop.h: Add include guard.
833         * darwin-nat.h: Rename include guard.
834         * cp-abi.h: Rename include guard.
835         * config/sparc/nm-sol2.h: Rename include guard.
836         * config/nm-nto.h: Rename include guard.
837         * config/nm-linux.h: Add include guard.
838         * config/i386/nm-i386gnu.h: Rename include guard.
839         * config/djgpp/nl_types.h: Rename include guard.
840         * config/djgpp/langinfo.h: Rename include guard.
841         * compile/gcc-cp-plugin.h: Add include guard.
842         * compile/gcc-c-plugin.h: Add include guard.
843         * compile/compile.h: Rename include guard.
844         * compile/compile-object-run.h: Rename include guard.
845         * compile/compile-object-load.h: Rename include guard.
846         * compile/compile-internal.h: Rename include guard.
847         * compile/compile-cplus.h: Rename include guard.
848         * compile/compile-c.h: Rename include guard.
849         * common/xml-utils.h: Rename include guard.
850         * common/x86-xstate.h: Rename include guard.
851         * common/version.h: Rename include guard.
852         * common/vec.h: Rename include guard.
853         * common/tdesc.h: Rename include guard.
854         * common/selftest.h: Rename include guard.
855         * common/scoped_restore.h: Rename include guard.
856         * common/scoped_mmap.h: Rename include guard.
857         * common/scoped_fd.h: Rename include guard.
858         * common/safe-iterator.h: Rename include guard.
859         * common/run-time-clock.h: Rename include guard.
860         * common/refcounted-object.h: Rename include guard.
861         * common/queue.h: Rename include guard.
862         * common/ptid.h: Rename include guard.
863         * common/print-utils.h: Rename include guard.
864         * common/preprocessor.h: Rename include guard.
865         * common/pathstuff.h: Rename include guard.
866         * common/observable.h: Rename include guard.
867         * common/netstuff.h: Rename include guard.
868         * common/job-control.h: Rename include guard.
869         * common/host-defs.h: Rename include guard.
870         * common/gdb_wait.h: Rename include guard.
871         * common/gdb_vecs.h: Rename include guard.
872         * common/gdb_unlinker.h: Rename include guard.
873         * common/gdb_unique_ptr.h: Rename include guard.
874         * common/gdb_tilde_expand.h: Rename include guard.
875         * common/gdb_sys_time.h: Rename include guard.
876         * common/gdb_string_view.h: Rename include guard.
877         * common/gdb_splay_tree.h: Rename include guard.
878         * common/gdb_setjmp.h: Rename include guard.
879         * common/gdb_ref_ptr.h: Rename include guard.
880         * common/gdb_optional.h: Rename include guard.
881         * common/gdb_locale.h: Rename include guard.
882         * common/gdb_assert.h: Rename include guard.
883         * common/filtered-iterator.h: Rename include guard.
884         * common/filestuff.h: Rename include guard.
885         * common/fileio.h: Rename include guard.
886         * common/environ.h: Rename include guard.
887         * common/common-utils.h: Rename include guard.
888         * common/common-types.h: Rename include guard.
889         * common/common-regcache.h: Rename include guard.
890         * common/common-inferior.h: Rename include guard.
891         * common/common-gdbthread.h: Rename include guard.
892         * common/common-exceptions.h: Rename include guard.
893         * common/common-defs.h: Rename include guard.
894         * common/common-debug.h: Rename include guard.
895         * common/cleanups.h: Rename include guard.
896         * common/buffer.h: Rename include guard.
897         * common/btrace-common.h: Rename include guard.
898         * common/break-common.h: Rename include guard.
899         * cli/cli-utils.h: Rename include guard.
900         * cli/cli-style.h: Rename include guard.
901         * cli/cli-setshow.h: Rename include guard.
902         * cli/cli-script.h: Rename include guard.
903         * cli/cli-interp.h: Rename include guard.
904         * cli/cli-decode.h: Rename include guard.
905         * cli/cli-cmds.h: Rename include guard.
906         * charset-list.h: Add include guard.
907         * buildsym-legacy.h: Rename include guard.
908         * bfin-tdep.h: Add include guard.
909         * ax.h: Rename include guard.
910         * arm-linux-tdep.h: Add include guard.
911         * arm-fbsd-tdep.h: Add include guard.
912         * arch/xtensa.h: Rename include guard.
913         * arch/tic6x.h: Add include guard.
914         * arch/i386.h: Add include guard.
915         * arch/arm.h: Rename include guard.
916         * arch/arm-linux.h: Rename include guard.
917         * arch/arm-get-next-pcs.h: Rename include guard.
918         * arch/amd64.h: Add include guard.
919         * arch/aarch64-insn.h: Rename include guard.
920         * arch-utils.h: Rename include guard.
921         * annotate.h: Add include guard.
922         * amd64-darwin-tdep.h: Rename include guard.
923         * aarch64-linux-tdep.h: Add include guard.
924         * aarch64-fbsd-tdep.h: Add include guard.
925         * aarch32-linux-nat.h: Add include guard.
926
927 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
928
929         * macrotab.c (macro_define_internal): New function that
930         factorizes macro_define_object_internal and macro_define_function
931         code.
932         (macro_define_object_internal): Use macro_define_internal.
933         (macro_define_function): Likewise.
934
935 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
936
937         * macrocmd.c (extract_identifier): Return
938         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
939         callers.
940
941 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
942
943         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
944
945 2019-02-05  Tom Tromey  <tom@tromey.com>
946
947         * target.c (target_stack::unpush): Move assertion earlier.
948
949 2019-01-30  Tom Tromey  <tom@tromey.com>
950
951         PR python/23615:
952         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
953         (gdbpy_parse_and_eval): Likewise.
954         * python/python-internal.h (gdbpy_allow_threads): New class.
955
956 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
957
958         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
959         (aarch64_fbsd_fpregmap): Move earlier.
960         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
961         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
962         instead of individual calls to trad_frame_set_reg_addr.
963         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
964         earlier.
965         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
966         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
967         instead of individual calls to trad_frame_set_reg_addr.
968
969 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
970
971         * CONTRIBUTE: Replace contribution list with wiki link.
972
973 2019-01-25  Tom Tromey  <tom@tromey.com>
974
975         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
976
977 2019-01-25  Tom Tromey  <tom@tromey.com>
978
979         * xtensa-linux-nat.c: Fix common/ includes.
980         * xml-support.h: Fix common/ includes.
981         * xml-support.c: Fix common/ includes.
982         * x86-linux-nat.c: Fix common/ includes.
983         * windows-nat.c: Fix common/ includes.
984         * varobj.h: Fix common/ includes.
985         * varobj.c: Fix common/ includes.
986         * value.c: Fix common/ includes.
987         * valops.c: Fix common/ includes.
988         * utils.c: Fix common/ includes.
989         * unittests/xml-utils-selftests.c: Fix common/ includes.
990         * unittests/utils-selftests.c: Fix common/ includes.
991         * unittests/unpack-selftests.c: Fix common/ includes.
992         * unittests/tracepoint-selftests.c: Fix common/ includes.
993         * unittests/style-selftests.c: Fix common/ includes.
994         * unittests/string_view-selftests.c: Fix common/ includes.
995         * unittests/scoped_restore-selftests.c: Fix common/ includes.
996         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
997         * unittests/scoped_fd-selftests.c: Fix common/ includes.
998         * unittests/rsp-low-selftests.c: Fix common/ includes.
999         * unittests/parse-connection-spec-selftests.c: Fix common/
1000         includes.
1001         * unittests/optional-selftests.c: Fix common/ includes.
1002         * unittests/offset-type-selftests.c: Fix common/ includes.
1003         * unittests/observable-selftests.c: Fix common/ includes.
1004         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
1005         * unittests/memrange-selftests.c: Fix common/ includes.
1006         * unittests/memory-map-selftests.c: Fix common/ includes.
1007         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
1008         * unittests/function-view-selftests.c: Fix common/ includes.
1009         * unittests/environ-selftests.c: Fix common/ includes.
1010         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
1011         * unittests/common-utils-selftests.c: Fix common/ includes.
1012         * unittests/cli-utils-selftests.c: Fix common/ includes.
1013         * unittests/array-view-selftests.c: Fix common/ includes.
1014         * ui-file.c: Fix common/ includes.
1015         * tui/tui-io.c: Fix common/ includes.
1016         * tracepoint.h: Fix common/ includes.
1017         * tracepoint.c: Fix common/ includes.
1018         * tracefile-tfile.c: Fix common/ includes.
1019         * top.h: Fix common/ includes.
1020         * top.c: Fix common/ includes.
1021         * thread.c: Fix common/ includes.
1022         * target/waitstatus.h: Fix common/ includes.
1023         * target/waitstatus.c: Fix common/ includes.
1024         * target.h: Fix common/ includes.
1025         * target.c: Fix common/ includes.
1026         * target-memory.c: Fix common/ includes.
1027         * target-descriptions.c: Fix common/ includes.
1028         * symtab.h: Fix common/ includes.
1029         * symfile.c: Fix common/ includes.
1030         * stap-probe.c: Fix common/ includes.
1031         * spu-linux-nat.c: Fix common/ includes.
1032         * sparc-nat.c: Fix common/ includes.
1033         * source.c: Fix common/ includes.
1034         * solib.c: Fix common/ includes.
1035         * solib-target.c: Fix common/ includes.
1036         * ser-unix.c: Fix common/ includes.
1037         * ser-tcp.c: Fix common/ includes.
1038         * ser-pipe.c: Fix common/ includes.
1039         * ser-base.c: Fix common/ includes.
1040         * selftest-arch.c: Fix common/ includes.
1041         * s12z-tdep.c: Fix common/ includes.
1042         * rust-exp.y: Fix common/ includes.
1043         * rs6000-aix-tdep.c: Fix common/ includes.
1044         * riscv-tdep.c: Fix common/ includes.
1045         * remote.c: Fix common/ includes.
1046         * remote-notif.h: Fix common/ includes.
1047         * remote-fileio.h: Fix common/ includes.
1048         * remote-fileio.c: Fix common/ includes.
1049         * regcache.h: Fix common/ includes.
1050         * regcache.c: Fix common/ includes.
1051         * record-btrace.c: Fix common/ includes.
1052         * python/python.c: Fix common/ includes.
1053         * python/py-type.c: Fix common/ includes.
1054         * python/py-inferior.c: Fix common/ includes.
1055         * progspace.h: Fix common/ includes.
1056         * producer.c: Fix common/ includes.
1057         * procfs.c: Fix common/ includes.
1058         * proc-api.c: Fix common/ includes.
1059         * printcmd.c: Fix common/ includes.
1060         * ppc-linux-nat.c: Fix common/ includes.
1061         * parser-defs.h: Fix common/ includes.
1062         * osdata.c: Fix common/ includes.
1063         * obsd-nat.c: Fix common/ includes.
1064         * nat/x86-linux.c: Fix common/ includes.
1065         * nat/x86-linux-dregs.c: Fix common/ includes.
1066         * nat/x86-dregs.h: Fix common/ includes.
1067         * nat/x86-dregs.c: Fix common/ includes.
1068         * nat/ppc-linux.c: Fix common/ includes.
1069         * nat/mips-linux-watch.h: Fix common/ includes.
1070         * nat/mips-linux-watch.c: Fix common/ includes.
1071         * nat/linux-waitpid.c: Fix common/ includes.
1072         * nat/linux-ptrace.h: Fix common/ includes.
1073         * nat/linux-ptrace.c: Fix common/ includes.
1074         * nat/linux-procfs.c: Fix common/ includes.
1075         * nat/linux-personality.c: Fix common/ includes.
1076         * nat/linux-osdata.c: Fix common/ includes.
1077         * nat/linux-namespaces.c: Fix common/ includes.
1078         * nat/linux-btrace.h: Fix common/ includes.
1079         * nat/linux-btrace.c: Fix common/ includes.
1080         * nat/fork-inferior.c: Fix common/ includes.
1081         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1082         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1083         * nat/aarch64-linux.c: Fix common/ includes.
1084         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1085         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1086         * namespace.h: Fix common/ includes.
1087         * mips-linux-tdep.c: Fix common/ includes.
1088         * minsyms.c: Fix common/ includes.
1089         * mi/mi-parse.h: Fix common/ includes.
1090         * mi/mi-main.c: Fix common/ includes.
1091         * mi/mi-cmd-env.c: Fix common/ includes.
1092         * memrange.h: Fix common/ includes.
1093         * memattr.c: Fix common/ includes.
1094         * maint.h: Fix common/ includes.
1095         * maint.c: Fix common/ includes.
1096         * main.c: Fix common/ includes.
1097         * machoread.c: Fix common/ includes.
1098         * location.c: Fix common/ includes.
1099         * linux-thread-db.c: Fix common/ includes.
1100         * linux-nat.c: Fix common/ includes.
1101         * linux-fork.c: Fix common/ includes.
1102         * inline-frame.c: Fix common/ includes.
1103         * infrun.c: Fix common/ includes.
1104         * inflow.c: Fix common/ includes.
1105         * inferior.h: Fix common/ includes.
1106         * inferior.c: Fix common/ includes.
1107         * infcmd.c: Fix common/ includes.
1108         * inf-ptrace.c: Fix common/ includes.
1109         * inf-child.c: Fix common/ includes.
1110         * ia64-linux-nat.c: Fix common/ includes.
1111         * i387-tdep.c: Fix common/ includes.
1112         * i386-tdep.c: Fix common/ includes.
1113         * i386-linux-tdep.c: Fix common/ includes.
1114         * i386-linux-nat.c: Fix common/ includes.
1115         * i386-go32-tdep.c: Fix common/ includes.
1116         * i386-fbsd-tdep.c: Fix common/ includes.
1117         * i386-fbsd-nat.c: Fix common/ includes.
1118         * guile/scm-type.c: Fix common/ includes.
1119         * guile/guile.c: Fix common/ includes.
1120         * go32-nat.c: Fix common/ includes.
1121         * gnu-nat.c: Fix common/ includes.
1122         * gdbthread.h: Fix common/ includes.
1123         * gdbarch-selftests.c: Fix common/ includes.
1124         * gdb_usleep.c: Fix common/ includes.
1125         * gdb_select.h: Fix common/ includes.
1126         * gdb_bfd.c: Fix common/ includes.
1127         * gcore.c: Fix common/ includes.
1128         * fork-child.c: Fix common/ includes.
1129         * findvar.c: Fix common/ includes.
1130         * fbsd-nat.c: Fix common/ includes.
1131         * event-top.c: Fix common/ includes.
1132         * event-loop.c: Fix common/ includes.
1133         * dwarf2read.c: Fix common/ includes.
1134         * dwarf2loc.c: Fix common/ includes.
1135         * dwarf2-frame.c: Fix common/ includes.
1136         * dwarf-index-cache.c: Fix common/ includes.
1137         * dtrace-probe.c: Fix common/ includes.
1138         * disasm-selftests.c: Fix common/ includes.
1139         * defs.h: Fix common/ includes.
1140         * csky-tdep.c: Fix common/ includes.
1141         * cp-valprint.c: Fix common/ includes.
1142         * cp-support.h: Fix common/ includes.
1143         * cp-support.c: Fix common/ includes.
1144         * corelow.c: Fix common/ includes.
1145         * completer.h: Fix common/ includes.
1146         * completer.c: Fix common/ includes.
1147         * compile/compile.c: Fix common/ includes.
1148         * compile/compile-loc2c.c: Fix common/ includes.
1149         * compile/compile-cplus-types.c: Fix common/ includes.
1150         * compile/compile-cplus-symbols.c: Fix common/ includes.
1151         * command.h: Fix common/ includes.
1152         * cli/cli-dump.c: Fix common/ includes.
1153         * cli/cli-cmds.c: Fix common/ includes.
1154         * charset.c: Fix common/ includes.
1155         * build-id.c: Fix common/ includes.
1156         * btrace.h: Fix common/ includes.
1157         * btrace.c: Fix common/ includes.
1158         * breakpoint.h: Fix common/ includes.
1159         * breakpoint.c: Fix common/ includes.
1160         * ax.h: 
1161         (enum agent_op): Fix common/ includes.
1162         * ax-general.c (struct aop_map): Fix common/ includes.
1163         * ax-gdb.c: Fix common/ includes.
1164         * auxv.c: Fix common/ includes.
1165         * auto-load.c: Fix common/ includes.
1166         * arm-tdep.c: Fix common/ includes.
1167         * arch/riscv.c: Fix common/ includes.
1168         * arch/ppc-linux-common.c: Fix common/ includes.
1169         * arch/i386.c: Fix common/ includes.
1170         * arch/arm.c: Fix common/ includes.
1171         * arch/arm-linux.c: Fix common/ includes.
1172         * arch/arm-get-next-pcs.c: Fix common/ includes.
1173         * arch/amd64.c: Fix common/ includes.
1174         * arch/aarch64.c: Fix common/ includes.
1175         * arch/aarch64-insn.c: Fix common/ includes.
1176         * arch-utils.c: Fix common/ includes.
1177         * amd64-windows-tdep.c: Fix common/ includes.
1178         * amd64-tdep.c: Fix common/ includes.
1179         * amd64-sol2-tdep.c: Fix common/ includes.
1180         * amd64-obsd-tdep.c: Fix common/ includes.
1181         * amd64-nbsd-tdep.c: Fix common/ includes.
1182         * amd64-linux-tdep.c: Fix common/ includes.
1183         * amd64-linux-nat.c: Fix common/ includes.
1184         * amd64-fbsd-tdep.c: Fix common/ includes.
1185         * amd64-fbsd-nat.c: Fix common/ includes.
1186         * amd64-dicos-tdep.c: Fix common/ includes.
1187         * amd64-darwin-tdep.c: Fix common/ includes.
1188         * agent.c: Fix common/ includes.
1189         * ada-lang.h: Fix common/ includes.
1190         * ada-lang.c: Fix common/ includes.
1191         * aarch64-tdep.c: Fix common/ includes.
1192
1193 2019-01-25  Tom Tromey  <tom@tromey.com>
1194
1195         * common/create-version.sh: Use common/version.h.
1196
1197 2019-01-24  Pedro Alves  <palves@redhat.com>
1198
1199         * infrun.c (signal_stop, signal_print, signal_program)
1200         (signal_catch, signal_pass): Now arrays instead of pointers.
1201         (update_signals_program_target, do_target_resume)
1202         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1203         * linux-nat.c (linux_nat_target::pass_signals)
1204         (linux_nat_target::create_inferior, linux_nat_target::attach):
1205         Adjust.
1206         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1207         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1208         * procfs.c (procfs_target::pass_signals): Adjust.
1209         * record-full.c (record_full_target::resume): Adjust.
1210         * remote.c (remote_target::pass_signals)
1211         (remote_target::program_signals): Adjust.
1212         * target-debug.h (target_debug_print_signals): Now takes a
1213         gdb::array_view as parameter.  Adjust.
1214         * target.h (target_ops) <pass_signals, program_signals>: Replace
1215         pointer and length parameters with gdb::array_view.
1216         (target_pass_signals, target_program_signals): Likewise.
1217         * target-delegates.c: Regenerate.
1218
1219 2019-01-24  Pedro Alves  <palves@redhat.com>
1220
1221         * common/forward-scope-exit.h
1222         (forward_scope_exit::forward_scope_exit): Pass arguments to
1223         m_bind_function directly, instead of creating a std::bind and
1224         copying that.
1225
1226 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1227
1228         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1229         for static members.
1230         (pass_in_v_vfp_candidate): Likewise.
1231
1232 2019-01-23  Tom Tromey  <tom@tromey.com>
1233             Pedro Alves  <palves@redhat.com>
1234
1235         * regcache.c (class regcache_invalidator): Remove.
1236         (regcache::raw_write): Use make_scope_exit.
1237
1238 2019-01-23  Tom Tromey  <tom@tromey.com>
1239
1240         * ui-out.h (class ui_out_emit_type): Update comment.
1241
1242 2019-01-23  Tom Tromey  <tom@tromey.com>
1243
1244         * infrun.c (fetch_inferior_event): Update comment.
1245
1246 2019-01-23  Tom Tromey  <tom@tromey.com>
1247             Pedro Alves  <palves@redhat.com>
1248
1249         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1250         parameter.
1251         (fetch_inferior_event): Use SCOPE_EXIT.
1252
1253
1254 2019-01-23  Tom Tromey  <tom@tromey.com>
1255             Pedro Alves  <palves@redhat.com>
1256
1257         * infrun.c (disable_thread_events): Delete.
1258         (stop_all_threads): Use SCOPE_EXIT.
1259
1260 2019-01-23  Tom Tromey  <tom@tromey.com>
1261             Pedro Alves  <palves@redhat.com>
1262
1263         * symfile.c: Include forward-scope-exit.h.
1264         (clear_symtab_users_cleanup): Replace forward declaration with
1265         a FORWARD_SCOPE_EXIT.
1266         (syms_from_objfile_1): Use the forward_scope_exit and
1267         gdb::optional instead of cleanup_function.
1268         (reread_symbols): Use the forward_scope_exit instead of
1269         cleanup_function.
1270         (clear_symtab_users_cleanup): Remove function.
1271
1272 2019-01-23  Tom Tromey  <tom@tromey.com>
1273             Pedro Alves  <palves@redhat.com>
1274
1275         * linux-nat.c: Include scope-exit.h.
1276         (cleanup_target_stop): Remove.
1277         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1278         SCOPE_EXIT.
1279
1280 2019-01-23  Tom Tromey  <tom@tromey.com>
1281             Pedro Alves  <palves@redhat.com>
1282
1283         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1284         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1285
1286 2019-01-23  Tom Tromey  <tom@tromey.com>
1287             Andrew Burgess  <andrew.burgess@embecosm.com>
1288             Pedro Alves  <palves@redhat.com>
1289
1290         * infrun.c (fetch_inferior_event): Use scope_exit.
1291         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1292         * top.c (execute_command): Use scope_exit.
1293         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1294         * utils.c (do_bpstat_clear_actions_cleanup)
1295         (make_bpstat_clear_actions_cleanup): Remove.
1296
1297 2019-01-23  Tom Tromey  <tom@tromey.com>
1298             Pedro Alves  <palves@redhat.com>
1299
1300         * infrun.c: Include "common/scope-exit.h"
1301         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1302         (wait_for_inferior): Use SCOPE_EXIT.
1303         (fetch_inferior_event): Use scope_exit.
1304
1305 2019-01-23  Tom Tromey  <tom@tromey.com>
1306             Pedro Alves  <palves@redhat.com>
1307
1308         * breakpoint.c (create_breakpoint): Remove cleanup.
1309
1310 2019-01-23  Tom Tromey  <tom@tromey.com>
1311             Andrew Burgess  <andrew.burgess@embecosm.com>
1312             Pedro Alves  <palves@redhat.com>
1313
1314 2019-01-23  Pedro Alves  <palves@redhat.com>
1315
1316         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1317
1318 2019-01-23  Pedro Alves  <palves@redhat.com>
1319             Andrew Burgess  <andrew.burgess@embecosm.com>
1320
1321         * gdbthread.h: Include "common/forward-scope-exit.h".
1322         (scoped_finish_thread_state): Redefine custom class in terms of
1323         forward_scope_exit.
1324
1325 2019-01-23  Pedro Alves  <palves@redhat.com>
1326             Andrew Burgess  <andrew.burgess@embecosm.com>
1327
1328         * common/forward-scope-exit.h: New file.
1329
1330 2019-01-23  Pedro Alves  <palves@redhat.com>
1331             Andrew Burgess  <andrew.burgess@embecosm.com>
1332             Tom Tromey  <tom@tromey.com>
1333
1334         * common/scope-exit.h: New file.
1335
1336 2019-01-23  Pedro Alves  <palves@redhat.com>
1337
1338         * common/preprocessor.h (ESC): Rename to ...
1339         (ESC_PARENS): ... this.
1340         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1341         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1342
1343 2019-01-23  Tom Tromey  <tom@tromey.com>
1344
1345         * language.h (class scoped_switch_to_sym_language_if_auto):
1346         Initialize m_lang in both cases.
1347
1348 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1349
1350         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1351         with XCNEW.
1352
1353 2019-01-22  Tom Tromey  <tom@tromey.com>
1354
1355         * corelow.c: Do not include sys/file.h.
1356
1357 2019-01-22  Tom Tromey  <tom@tromey.com>
1358
1359         * tui/tui-wingeneral.h: Include gdb_curses.h.
1360
1361 2019-01-22  Tom Tromey  <tom@tromey.com>
1362
1363         * source-cache.h (class source_cache) <get_source_lines,
1364         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1365
1366 2019-01-22  Tom Tromey  <tom@tromey.com>
1367
1368         * remote-fileio.h (struct remote_target): Declare.
1369
1370 2019-01-22  Tom Tromey  <tom@tromey.com>
1371
1372         * python/py-arch.c: Do not include py-ref.h.
1373         * python/py-bpevent.c: Do not include py-ref.h.
1374         * python/py-cmd.c: Do not include py-ref.h.
1375         * python/py-continueevent.c: Do not include py-ref.h.
1376         * python/py-event.h: Do not include py-ref.h.
1377         * python/py-evtregistry.c: Do not include py-ref.h.
1378         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1379         * python/py-frame.c: Do not include py-ref.h.
1380         * python/py-framefilter.c: Do not include py-ref.h.
1381         * python/py-function.c: Do not include py-ref.h.
1382         * python/py-infevents.c: Do not include py-ref.h.
1383         * python/py-linetable.c: Do not include py-ref.h.
1384         * python/py-objfile.c: Do not include py-ref.h.
1385         * python/py-param.c: Do not include py-ref.h.
1386         * python/py-prettyprint.c: Do not include py-ref.h.
1387         * python/py-progspace.c: Do not include py-ref.h.
1388         * python/py-symbol.c: Do not include py-ref.h.
1389         * python/py-symtab.c: Do not include py-ref.h.
1390         * python/py-type.c: Do not include py-ref.h.
1391         * python/py-unwind.c: Do not include py-ref.h.
1392         * python/py-utils.c: Do not include py-ref.h.
1393         * python/py-value.c: Do not include py-ref.h.
1394         * python/py-varobj.c: Do not include py-ref.h.
1395         * python/py-xmethods.c: Do not include py-ref.h.
1396         * python/python.c: Do not include py-ref.h.
1397         * varobj.c: Do not include py-ref.h.
1398
1399 2019-01-22  Tom Tromey  <tom@tromey.com>
1400
1401         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1402         keyword for bcache.
1403
1404 2019-01-22  Tom Tromey  <tom@tromey.com>
1405
1406         * compile/compile-cplus-types.c: Remove a comment by #include.
1407
1408 2019-01-22  Tom Tromey  <tom@tromey.com>
1409
1410         * compile/gcc-c-plugin.h: Include compile-internal.h.
1411
1412 2019-01-22  Tom Tromey  <tom@tromey.com>
1413
1414         * stabsread.c (EXTERN): Do not define.
1415         (symnum, next_symbol_text_func, processing_gcc_compilation)
1416         (within_function, global_sym_chain, global_stabs)
1417         (previous_stab_code, this_object_header_files)
1418         (n_this_object_header_files)
1419         (n_allocated_this_object_header_files): Define.
1420         * stabsread.h (EXTERN): Never define.  Use "extern".
1421
1422 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1423
1424         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1425         history_value.
1426
1427 2019-01-21  Tom Tromey  <tom@tromey.com>
1428
1429         * ui-out.c: Fix includes.
1430         * tui/tui-source.c: Fix includes.
1431         * target.c: Fix includes.
1432         * remote.c: Fix includes.
1433         * regcache.c: Fix includes.
1434         * python/py-block.c: Fix includes.
1435         * printcmd.c: Fix includes.
1436         * or1k-tdep.c: Fix includes.
1437         * mi/mi-main.c: Fix includes.
1438         * m32r-tdep.c: Fix includes.
1439         * csky-tdep.c: Fix includes.
1440         * compile/compile-cplus-types.c: Fix includes.
1441         * cli/cli-interp.c: Fix includes.
1442
1443 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1444
1445         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1446         for padding.
1447
1448 2019-01-16  Tom Tromey  <tom@tromey.com>
1449
1450         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1451         earlier.
1452         (struct objfile) <msymbols_range>: Move from top level.
1453         <msymbols>: New method.
1454         (class objfile_msymbols): Remove.
1455         * symtab.c (default_collect_symbol_completion_matches_break_on):
1456         Update.
1457         * symmisc.c (dump_msymbols): Update.
1458         * stabsread.c (scan_file_globals): Update.
1459         * objc-lang.c (info_selectors_command, info_classes_command)
1460         (find_methods): Update.
1461         * minsyms.c (find_solib_trampoline_target): Update.
1462         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1463         * coffread.c (coff_symfile_read): Update.
1464         * ada-lang.c (ada_lookup_simple_minsym)
1465         (ada_collect_symbol_completion_matches): Update.
1466
1467 2019-01-16  Tom Tromey  <tom@tromey.com>
1468
1469         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1470         type.  Remove no-argument constructor.
1471         <iterator::operator++>: Simplify.
1472         <begin>: Update.
1473         <end>: Use minimal_symbol_count.
1474
1475 2019-01-16  Tom Tromey  <tom@tromey.com>
1476
1477         * objfiles.h (struct objfile) <psymtabs>: New method.
1478         (class objfile_psymtabs): Remove.
1479         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1480         typedef.
1481         <range>: New method.
1482         (require_partial_symbols): Change return type.
1483         * psymtab.c (require_partial_symbols)
1484         (psym_expand_symtabs_matching): Update.
1485         * mdebugread.c (parse_partial_symbols): Update.
1486         * dbxread.c (dbx_end_psymtab): Update.
1487
1488 2019-01-15  Tom Tromey  <tom@tromey.com>
1489
1490         * symtab.c (lookup_objfile_from_block)
1491         (lookup_symbol_in_objfile_symtabs)
1492         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1493         (find_line_symtab, info_sources_command)
1494         (default_collect_symbol_completion_matches_break_on)
1495         (make_source_files_completion_list): Update.
1496         * symmisc.c (print_objfile_statistics, dump_objfile)
1497         (maintenance_print_symbols, maintenance_info_symtabs)
1498         (maintenance_check_symtabs, maintenance_info_line_tables):
1499         Update.
1500         * source.c (select_source_symtab)
1501         (forget_cached_source_info_for_objfile): Update.
1502         * objfiles.h (class objfile_compunits): Remove.
1503         (struct objfile) <compunits_range>: New typedef.
1504         (compunits): New method.
1505         * objfiles.c (objfile_relocate1): Update.
1506         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1507         * maint.c (count_symtabs_and_blocks): Update.
1508         * linespec.c (iterate_over_all_matching_symtabs): Update.
1509         * cp-support.c (add_symbol_overload_list_qualified): Update.
1510         * coffread.c (coff_symtab_read): Update.
1511         * ada-lang.c (add_nonlocal_symbols)
1512         (ada_collect_symbol_completion_matches)
1513         (ada_add_global_exceptions): Update.
1514
1515 2019-01-15  Tom Tromey  <tom@tromey.com>
1516
1517         * progspace.h (program_space) <objfiles_safe_range>: New
1518         typedef.
1519         <objfiles_safe>: New method.
1520         * objfiles.h (class all_objfiles_safe): Remove.
1521         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1522         * jit.c (jit_inferior_exit_hook): Update.
1523
1524 2019-01-17  Tom Tromey  <tom@tromey.com>
1525
1526         * progspace.h (program_space) <objfiles_range>: New typedef.
1527         <objfiles>: New method.
1528         <objfiles_head>: Rename from objfiles.
1529         (object_files): Update.
1530         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1531         * guile/scm-pretty-print.c
1532         (ppscm_find_pretty_printer_from_objfiles): Update.
1533         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1534         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1535         Update.
1536         * python/py-progspace.c (pspy_get_objfiles): Update.
1537         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1538         Update.
1539         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1540         (objfpy_lookup_objfile_by_build_id): Update.
1541         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1542         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1543         Update.
1544         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1545         (expand_symtab_containing_pc, lookup_objfile_from_block)
1546         (lookup_static_symbol, basic_lookup_transparent_type)
1547         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1548         (find_line_symtab, info_sources_command)
1549         (default_collect_symbol_completion_matches_break_on)
1550         (make_source_files_completion_list, find_main_name): Update.
1551         * symmisc.c (print_symbol_bcache_statistics)
1552         (print_objfile_statistics, maintenance_print_symbols)
1553         (maintenance_print_msymbols, maintenance_print_objfiles)
1554         (maintenance_info_symtabs, maintenance_check_symtabs)
1555         (maintenance_expand_symtabs, maintenance_info_line_tables):
1556         Update.
1557         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1558         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1559         (map_overlay_command, unmap_overlay_command)
1560         (simple_overlay_update, expand_symtabs_matching)
1561         (map_symbol_filenames): Update.
1562         * symfile-debug.c (set_debug_symfile): Update.
1563         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1564         Update.
1565         * source.c (select_source_symtab, forget_cached_source_info):
1566         Update.
1567         * solib.c (solib_read_symbols): Update.
1568         * solib-spu.c (append_ocl_sos): Update.
1569         * psymtab.c (maintenance_print_psymbols)
1570         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1571         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1572         * printcmd.c (info_symbol_command): Update.
1573         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1574         Update.
1575         * objfiles.h (class all_objfiles): Remove.
1576         * objfiles.c (have_partial_symbols, have_full_symbols)
1577         (have_minimal_symbols, qsort_cmp, update_section_map)
1578         (shared_objfile_contains_address_p)
1579         (default_iterate_over_objfiles_in_search_order): Update.
1580         * objc-lang.c (info_selectors_command, info_classes_command)
1581         (find_methods): Update.
1582         * minsyms.c (find_solib_trampoline_target): Update.
1583         * maint.c (maintenance_info_sections)
1584         (maintenance_translate_address, count_symtabs_and_blocks):
1585         Update.
1586         * main.c (captured_main_1): Update.
1587         * linux-thread-db.c (try_thread_db_load_from_pdir)
1588         (has_libpthread): Update.
1589         * linespec.c (iterate_over_all_matching_symtabs)
1590         (search_minsyms_for_name): Update.
1591         * jit.c (jit_find_objf_with_entry_addr): Update.
1592         * hppa-tdep.c (find_unwind_entry)
1593         (hppa_lookup_stub_minimal_symbol): Update.
1594         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1595         Update.
1596         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1597         (elf_gnu_ifunc_resolve_by_got): Update.
1598         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1599         * dwarf-index-write.c (save_gdb_index_command): Update.
1600         * cp-support.c (add_symbol_overload_list_qualified): Update.
1601         * breakpoint.c (create_overlay_event_breakpoint)
1602         (create_longjmp_master_breakpoint)
1603         (create_std_terminate_master_breakpoint)
1604         (create_exception_master_breakpoint): Update.
1605         * blockframe.c (find_pc_partial_function): Update.
1606         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1607         (ada_collect_symbol_completion_matches)
1608         (ada_add_global_exceptions): Update.
1609
1610 2019-01-17  Tom Tromey  <tom@tromey.com>
1611
1612         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1613         declare VEC.
1614         (solib_target_parse_libraries): Change return type.
1615         (library_list_start_segment, library_list_start_section)
1616         (library_list_end_library, library_list_start_library); Update.
1617         (solib_target_free_library_list): Remove.
1618         (solib_target_parse_libraries): Remove cleanup.  Change return
1619         type.
1620         (solib_target_current_sos): Update.
1621
1622 2019-01-17  Tom Tromey  <tromey@bapiya>
1623
1624         * valprint.c: Replace "the the" with "the".
1625         * symtab.c: Replace "the the" with "the".
1626         * solib.c: Replace "the the" with "the".
1627         * solib-dsbt.c: Replace "the the" with "the".
1628         * linespec.c: Replace "the the" with "the".
1629         * dwarf2loc.h: Replace "the the" with "the".
1630         * amd64-windows-tdep.c: Replace "the the" with "the".
1631         * aarch64-tdep.c: Replace "the the" with "the".
1632
1633 2019-01-16  Keith Seitz  <keiths@redhat.com>
1634
1635         PR gdb/23773
1636         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1637         <builder>: Rename to ..
1638         <m_builder>: ... this and make private.
1639         (dwarf2_cu::get_builder): New method.  Change all users of
1640         `builder' to use this method.
1641         (dwarf2_start_symtab): Move to ...
1642         (dwarf2_cu::start_symtab): ... here.  Update all callers
1643         (setup_type_unit_groups): Move to ...
1644         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1645         callers.
1646         (dwarf2_cu::reset_builder): New method.
1647         (process_full_compunit, process_full_type_unit): Use
1648         dwarf2_cu::reset_builder.
1649         (follow_die_offset): Record the ancestor CU if it is different
1650         from the followed DIE's CU.
1651         (follow_die_sig_1): Likewise.
1652
1653 2019-01-15  Tom Tromey  <tom@tromey.com>
1654
1655         * remote.c (class remote_state) <buf>: Now a char_vector.
1656         <buf_size>: Remove.
1657         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1658         parameter.
1659         (remote_target::getpkt_or_notif_sane_1)
1660         (remote_target::getpkt_sane)
1661         (remote_target::getpkt_or_notif_sane): Likewise.
1662         (class remote_target) <putpkt>: New overload.
1663         (remote_target::read_frame): Change type of "buf_p".  Remove
1664         sizeof_p parameter.
1665         (packet_ok): New overload.
1666         (packet_check_result): New overload.
1667         Update all uses.
1668
1669 2019-01-14  Tom Tromey  <tom@tromey.com>
1670
1671         * remote-notif.c (handle_notification, remote_notif_ack)
1672         (remote_notif_parse): Make "buf" const.
1673         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1674         const.
1675         (remote_notif_parse, remote_notif_ack, handle_notification):
1676         Likewise.
1677         * remote.c (remote_notif_stop_parse): Make "buf" const.
1678         (remote_target::remote_parse_stop_reply): Make "buf" const.
1679         (remote_notif_stop_ack): Make "buf" const.
1680
1681 2019-01-14  Tom Tromey  <tom@tromey.com>
1682
1683         * remote.c (remote_console_output): Make parameter const.
1684
1685 2019-01-14  Tom Tromey  <tom@tromey.com>
1686
1687         * target-debug.h (target_debug_print_signals): Constify.
1688         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1689         * procfs.c (procfs_target::pass_signals): Update.
1690         * linux-nat.c (linux_nat_target::pass_signals): Update.
1691         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1692         * target-delegates.c: Rebuild.
1693         * remote.c (remote_target::program_signals): Update.
1694         (remote_target::pass_signals): Update.
1695         * target.c (target_pass_signals): Constify argument.
1696         (target_program_signals): Likewise.
1697         * target.h (struct target_ops) <pass_signals, program_signals>:
1698         Constify argument.
1699         (target_pass_signals, target_program_signals): Constify argument.
1700
1701 2019-01-14  Tom Tromey  <tom@tromey.com>
1702
1703         PR tui/28819:
1704         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1705
1706 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1707
1708         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1709         field.
1710         * rs6000-tdep.c: Include reggroups.h.
1711         (IS_V_ALIAS_PSEUDOREG): Define.
1712         (rs6000_register_name): Return names for the "vX" aliases.
1713         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1714         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1715         aliases.  Call default_register_reggroup_p for all other
1716         pseudo-registers.
1717         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1718         New functions.
1719         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1720         Handle "vX" aliases.
1721         (v_alias_pseudo_register_collect): New function.
1722         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1723         (rs6000_gdbarch_init): Initialize "vX" aliases as
1724         pseudo-registers.  Restore registration of
1725         rs6000_pseudo_register_reggroup_p with
1726         set_tdesc_pseudo_register_reggroup_p.
1727
1728 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1729
1730         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1731         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1732         set_gdbarch_num_pseudo_regs.
1733
1734 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1735
1736         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1737         Remove arg prefixname, add do_set and do_show.
1738         Add member functions set_list and show_list.
1739         * cli/cli-style.c (class cli_style_option): Update accordingly.
1740         (style_set_list): Move to file scope.
1741         (style_show_list): Likewise.
1742         (set_style): Call help_list.
1743         (show_style): Call cmd_show_list.
1744         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1745         Update to use the new macro.
1746
1747 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1748
1749         * ada-lang.c (_initialize_ada_language): Expand the help text
1750         for the "catch exception" command.
1751
1752 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1753
1754         * symtab.c (matching_obj_sections): Initialize obj,
1755         declare it closer to its usage.
1756
1757 2019-01-10  Tom Tromey  <tom@tromey.com>
1758
1759         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1760         (basic_inf_threads_range): Remove.
1761         (inf_threads_range, inf_non_exited_threads_range)
1762         (safe_inf_threads_range): Use next_adapter.
1763
1764 2019-01-10  Keith Seitz  <keiths@redhat.com>
1765
1766         PR gdb/23712
1767         PR symtab/23010
1768         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1769         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1770
1771 2019-01-10  Keith Seitz  <keiths@redhat.com>
1772
1773         PR gdb/23712
1774         PR symtab/23010
1775         * dictionary.c (pending_to_vector): Remove.
1776         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1777         Remove _1 suffix, replacing functions of the same name.  Update
1778         all callers.
1779         (dict_create_hashed, dict_create_hashed_expandable)
1780         (dict_create_linear, dict_create_linear_expandable, dict_free)
1781         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1782         Make functions static.
1783
1784 2019-01-10  Keith Seitz  <keiths@redhat.com>
1785
1786         PR gdb/23712
1787         PR symtab/23010
1788         * dictionary.h (struct dictionary): Replace declaration with
1789         multidictionary.
1790         (dict_create_hashed, dict_create_hashed_expandable)
1791         (dict_create_linear, dict_create_linear_expandable)
1792         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1793         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1794         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1795         taking multidictionary argument.
1796         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1797         * block.h (struct block) <dict>: Change to multidictionary
1798         and rename `multidict'.
1799         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1800         symmisc.c: Update all dictionary references to multidictionary.
1801
1802 2019-01-10  Keith Seitz  <keiths@redhat.com>
1803
1804         PR gdb/23712
1805         PR symtab/23010
1806         * dictionary.c: Include unordered_map.
1807         (pending_to_vector): New function.
1808         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1809         Rewrite the non-"_1" functions to take vector instead
1810         of linked list.
1811         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1812         "new" _1 versions of the same name.
1813         (multidictionary): Define.
1814         (std::hash<enum language): New definition.
1815         (collate_pending_symbols_by_language, mdict_create_hashed)
1816         (mdict_create_hashed_expandable, mdict_create_linear)
1817         (mdict_create_linear_expandable, mdict_free)
1818         (find_language_dictionary, create_new_language_dictionary)
1819         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1820         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1821         (mdict_size, mdict_empty): New functions.
1822         * dictionary.h (mdict_iterator): Define.
1823
1824 2019-01-10  Pedro Alves  <palves@redhat.com>
1825
1826         * breakpoint.c (read_uploaded_action)
1827         (create_tracepoint_from_upload): Adjust to use
1828         gdb::unique_xmalloc_ptr.
1829         * ctf.c (ctf_write_uploaded_tp):
1830         (SET_ARRAY_FIELD): Use emplace_back.
1831         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1832         * tracefile-tfile.c (tfile_write_uploaded_tp):
1833         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1834         gdb::unique_xmalloc_ptr.
1835         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1836         at_string, cond_string, cmd_strings>: Replace char pointers
1837         with gdb::unique_xmalloc_ptr.
1838
1839 2019-01-10  Pedro Alves  <palves@redhat.com>
1840
1841         * solib-target.c (library_list_start_library): Don't xstrdup name.
1842
1843 2019-01-10  Pedro Alves  <palves@redhat.com>
1844
1845         * mdebugread.c (parse_partial_symbols): Use
1846         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1847
1848 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1849
1850         * linux-fork.c (scoped_switch_fork_info)
1851         <~scoped_switch_fork_info>: Fix incorrect variable name.
1852
1853 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1854
1855         * linux-fork.c (scoped_switch_fork_info)
1856         <scoped_switch_fork_info>: Make explicit.
1857         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1858
1859 2019-01-10  Tom Tromey  <tom@tromey.com>
1860
1861         * objfiles.h (objfile::reset_psymtabs): Update.
1862         * objfiles.c (objfile::objfile): Update.
1863         * psymtab.h (psymtab_storage::obstack): Update.
1864         (psymtab_storage::m_obstack): Use gdb::optional.
1865         (class psymtab_storage): Update comment.  Remove objfile
1866         parameter.
1867         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1868
1869 2019-01-10  Tom Tromey  <tom@tromey.com>
1870
1871         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1872         <free_psymtabs>: Now private.
1873         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1874         (allocate_psymtab): Use new method.
1875
1876 2019-01-10  Tom Tromey  <tom@tromey.com>
1877
1878         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1879         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1880         * mdebugread.c (parse_partial_symbols): Use
1881         allocate_dependencies.
1882         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1883         allocate_dependencies.
1884         (process_psymtab_comp_unit_reader)
1885         (build_type_psymtab_dependencies): Likewise.
1886         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1887
1888 2019-01-10  Tom Tromey  <tom@tromey.com>
1889
1890         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1891         PSYMBOL_SET_LANGUAGE.
1892         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1893
1894 2019-01-10  Tom Tromey  <tom@tromey.com>
1895
1896         * psymtab.h (psymtab_storage::obstack): New method.
1897         <m_obstack>: Rename from obstack; now private.
1898         * psymtab.c (psymtab_storage): Update.
1899         * dwarf2read.c (create_addrmap_from_index)
1900         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1901         Update.
1902
1903 2019-01-10  Tom Tromey  <tom@tromey.com>
1904
1905         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1906         * objfiles.h (objfile::reset_psymtabs): New method.
1907
1908 2019-01-10  Tom Tromey  <tom@tromey.com>
1909
1910         * symmisc.c (print_symbol_bcache_statistics): Update.
1911         (print_objfile_statistics): Update.
1912         * symfile.c (reread_symbols): Update.
1913         * psymtab.h (class psymtab_storage): New.
1914         * psymtab.c (psymtab_storage): New constructor.
1915         (~psymtab_storage): New destructor.
1916         (require_partial_symbols): Update.
1917         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1918         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1919         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1920         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1921         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1922         (start_psymtab_common, end_psymtab_common)
1923         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1924         (allocate_psymtab): Update.
1925         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1926         Update.
1927         (dump_psymtab_addrmap, maintenance_print_psymbols)
1928         (maintenance_check_psymtabs): Update.
1929         (class objfile_psymtabs): Move to objfiles.h.
1930         * psympriv.h (discard_psymtab): Now inline.
1931         (psymtab_discarder::psymtab_discarder): Update.
1932         (psymtab_discarder::~psymtab_discarder): Update.
1933         (ALL_OBJFILE_PSYMTABS): Rewrite.
1934         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1935         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1936         Remove fields.
1937         <partial_symtabs>: New field.
1938         (class objfile_psymtabs): Move from psymtab.h.  Update.
1939         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1940         psymbol_cache.
1941         (objfile::~objfile): Don't destroy psymbol_cache.
1942         * mdebugread.c (parse_partial_symbols): Update.
1943         * dwarf2read.c (create_addrmap_from_index)
1944         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1945         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1946         (add_partial_subprogram, dwarf2_ranges_read): Update.
1947         * dwarf-index-write.c (write_address_map)
1948         (write_one_signatured_type, recursively_write_psymbols)
1949         (class debug_names, class debug_names, write_psymtabs_to_index):
1950         Update.
1951
1952 2019-01-10  Tom Tromey  <tom@tromey.com>
1953
1954         * symtab.h (SYMBOL_SET_NAMES): Update.
1955         (symbol_set_names): Update.
1956         (MSYMBOL_SET_NAMES): Update.
1957         * symtab.c (symbol_set_names): Change argument to be an
1958         objfile_per_bfd_storage.
1959         * psymtab.c (add_psymbol_to_bcache): Update.
1960         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1961
1962 2019-01-10  Tom Tromey  <tom@tromey.com>
1963
1964         * symtab.c (create_demangled_names_hash): Change argument to be an
1965         objfile_per_bfd_storage.
1966         (symbol_set_names): Update.
1967
1968 2019-01-10  Tom Tromey  <tom@tromey.com>
1969
1970         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1971         init_psymbol_list.
1972         * psymtab.c (init_psymbol_list): Do nothing if already called.
1973         * psympriv.h (init_psymbol_list): Add comment.
1974         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1975         init_psymbol_list.
1976         * dbxread.c (dbx_symfile_read): Unconditionally call
1977         init_psymbol_list.
1978
1979 2019-01-10  Tom Tromey  <tom@tromey.com>
1980
1981         * xcoffread.c (scan_xcoff_symtab): Update.
1982         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1983         "where".
1984         * mdebugread.c (parse_partial_symbols)
1985         (handle_psymbol_enumerators): Update.
1986         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1987         * dbxread.c (read_dbx_symtab): Update.
1988         * psympriv.h (psymbol_placement): New enum.
1989         (add_psymbol_to_list): Update.
1990
1991 2019-01-10  Tom Tromey  <tom@tromey.com>
1992
1993         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1994         static_psymbols parameters.
1995         (scan_xcoff_symtab): Update.
1996         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1997         static_psymbols parameters.
1998         * psympriv.h (start_psymtab_common): Update.
1999         * mdebugread.c (parse_partial_symbols): Update.
2000         * dwarf2read.c (create_partial_symtab): Update.
2001         * dbxread.c (read_dbx_symtab): Update.
2002         (start_psymtab): Remove global_psymbols and static_psymbols
2003         parameters.
2004
2005 2019-01-10  Tom Tromey  <tom@tromey.com>
2006
2007         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
2008         * psymtab.c (allocate_psymtab): Add comment.
2009         * psympriv.h (allocate_psymtab): Add comment.
2010         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
2011         initializations.
2012         * dbxread.c (dbx_end_psymtab): Remove some initializations.
2013
2014 2019-01-10  Tom Tromey  <tom@tromey.com>
2015
2016         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2017         Don't declare.
2018         * mipsread.c: Include mdebugread.h.
2019         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2020         Declare.
2021         * elfread.c: Include mdebugread.h.
2022
2023 2019-01-09  Tom Tromey  <tom@tromey.com>
2024
2025         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
2026         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
2027         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
2028         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
2029         (psym_lookup_symbol, psym_find_last_source_symtab)
2030         (psym_forget_cached_source_info, psym_print_stats)
2031         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
2032         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
2033         (psym_map_matching_symbols, psym_expand_symtabs_matching)
2034         (psym_find_compunit_symtab_by_address)
2035         (maintenance_print_psymbols, maintenance_info_psymtabs)
2036         (maintenance_check_psymtabs): Use ranged for.
2037         * psymtab.h (class objfile_psymtabs): New.
2038         (require_partial_symbols): Return objfile_psymtabs.
2039         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
2040
2041 2019-01-09  Tom Tromey  <tom@tromey.com>
2042
2043         * symfile.c (overlay_invalidate_all, find_pc_overlay)
2044         (find_pc_mapped_section, list_overlays_command)
2045         (map_overlay_command, unmap_overlay_command)
2046         (simple_overlay_update): Use all_objfiles.
2047         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
2048         * printcmd.c (info_symbol_command): Use all_objfiles.
2049         * objfiles.h (ALL_OBJSECTIONS): Remove.
2050         * maint.c (maintenance_translate_address): Use all_objfiles.
2051         * gcore.c (gcore_create_callback): Use all_objfiles.
2052         (objfile_find_memory_regions): Likewise.
2053
2054 2019-01-09  Tom Tromey  <tom@tromey.com>
2055
2056         * symtab.c (find_line_symtab, info_sources_command)
2057         (make_source_files_completion_list): Use objfile_compunits.
2058         * source.c (select_source_symtab): Use objfile_compunits.
2059         * objfiles.h (struct objfile): Update comment.
2060         (ALL_OBJFILES): Remove.
2061         (ALL_FILETABS): Remove.
2062         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2063         objfile_compunits.
2064
2065 2019-01-09  Tom Tromey  <tom@tromey.com>
2066
2067         * symmisc.c (print_objfile_statistics, dump_objfile)
2068         (maintenance_print_symbols): Use compunit_filetabs.
2069         * source.c (forget_cached_source_info_for_objfile): Use
2070         compunit_filetabs.
2071         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2072         (ALL_FILETABS): Use compunit_filetabs.
2073         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2074         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2075
2076 2019-01-09  Tom Tromey  <tom@tromey.com>
2077
2078         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2079         (compunit_filetabs): New.
2080         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2081         compunit_filetabs.
2082         (info_sources_command, make_source_files_completion_list): Remove
2083         declaration.
2084         * symmisc.c (print_objfile_statistics, dump_objfile)
2085         (maintenance_print_symbols): Remove declaration.
2086         (maintenance_info_symtabs): Use compunit_filetabs.
2087         (maintenance_info_line_tables): Likewise.
2088         * source.c (select_source_symtab): Change local variable name.
2089         (forget_cached_source_info_for_objfile): Remove declaration.
2090         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2091         * objfiles.c (objfile_relocate1): Remove declaration.
2092         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2093         declaration.
2094         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2095         * coffread.c (coff_symtab_read): Remove declaration.
2096         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2097         compunit_filetabs.
2098
2099 2019-01-09  Tom Tromey  <tom@tromey.com>
2100
2101         * symtab.c (lookup_objfile_from_block)
2102         (find_pc_sect_compunit_symtab, search_symbols)
2103         (default_collect_symbol_completion_matches_break_on): Use
2104         objfile_compunits.
2105         * objfiles.h (ALL_COMPUNITS): Remove.
2106         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2107         * cp-support.c (add_symbol_overload_list_qualified): Use
2108         objfile_compunits.
2109         * ada-lang.c (ada_collect_symbol_completion_matches)
2110         (ada_add_global_exceptions): Use objfile_compunits.
2111
2112 2019-01-09  Tom Tromey  <tom@tromey.com>
2113
2114         * source.c (select_source_symtab)
2115         (forget_cached_source_info_for_objfile): Remove declaration.
2116         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2117         declaration.
2118         * maint.c (count_symtabs_and_blocks): Remove declaration.
2119         * cp-support.c (add_symbol_overload_list_qualified): Remove
2120         declaration.
2121         * coffread.c (coff_symtab_read): Remove declaration.
2122         * symtab.c (lookup_symbol_in_objfile_symtabs)
2123         (basic_lookup_transparent_type_1): Use objfile_compunits.
2124         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2125         (info_sources_command, search_symbols)
2126         (default_collect_symbol_completion_matches_break_on)
2127         (make_source_files_completion_list): Remove declaration.
2128         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2129         (ada_collect_symbol_completion_matches)
2130         (ada_add_global_exceptions): Remove declaration.
2131         * linespec.c (iterate_over_all_matching_symtabs): Use
2132         objfile_compunits.
2133         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2134         (class objfile_compunits): New.
2135         (ALL_COMPUNITS): Use objfile_compunits.
2136         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2137         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2138         objfile_compunits.
2139         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2140
2141 2019-01-09  Tom Tromey  <tom@tromey.com>
2142
2143         * symtab.c (search_symbols)
2144         (default_collect_symbol_completion_matches_break_on): Use
2145         objfile_msymbols.
2146         * ada-lang.c (ada_lookup_simple_minsym)
2147         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2148         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2149         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2150         objfile_msymbols.
2151         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2152         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2153         * objc-lang.c (find_methods): Use objfile_msymbols.
2154         (info_selectors_command, info_classes_command): Likewise.
2155         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2156         * objfiles.h (class objfile_msymbols): New.
2157         (ALL_OBJFILE_MSYMBOLS): Remove.
2158         (ALL_MSYMBOLS): Remove.
2159
2160 2019-01-09  Tom Tromey  <tom@tromey.com>
2161
2162         * common/next-iterator.h (next_adapter): Add Iterator template
2163         parameter.
2164         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2165         (class all_objfiles_safe): New.
2166         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2167         * objfiles.c (put_objfile_before): Update comment.
2168         (add_separate_debug_objfile): Likewise.
2169         (free_all_objfiles): Use all_objfiles_safe.
2170         (objfile_purge_solibs): Likewise.
2171
2172 2019-01-09  Tom Tromey  <tom@tromey.com>
2173
2174         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2175         (expand_symtab_containing_pc, lookup_static_symbol)
2176         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2177         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2178         all_objfiles.
2179         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2180         * breakpoint.c (create_overlay_event_breakpoint)
2181         (create_longjmp_master_breakpoint)
2182         (create_std_terminate_master_breakpoint)
2183         (create_exception_master_breakpoint): Use all_objfiles.
2184         * linux-thread-db.c (try_thread_db_load_from_pdir)
2185         (has_libpthread): Use all_objfiles.
2186         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2187         * linespec.c (iterate_over_all_matching_symtabs)
2188         (search_minsyms_for_name): Use all_objfiles.
2189         * maint.c (maintenance_info_sections): Use all_objfiles.
2190         * main.c (captured_main_1): Use all_objfiles.
2191         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2192         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2193         * guile/scm-pretty-print.c
2194         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2195         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2196         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2197         (maintenance_print_msymbols): Use all_objfiles.
2198         * source.c (select_source_symtab): Use all_objfiles.
2199         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2200         * symfile.c (remove_symbol_file_command)
2201         (expand_symtabs_matching, map_symbol_filenames): Use
2202         all_objfiles.
2203         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2204         all_objfiles.
2205         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2206         * objc-lang.c (find_methods): Use all_objfiles.
2207         * objfiles.c (have_partial_symbols, have_full_symbols)
2208         (have_minimal_symbols, qsort_cmp)
2209         (default_iterate_over_objfiles_in_search_order): Use
2210         all_objfiles.
2211         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2212         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2213         (maintenance_check_psymtabs): Use all_objfiles.
2214         (ALL_PSYMTABS): Remove.
2215         * compile/compile-object-run.c (do_module_cleanup): Use
2216         all_objfiles.
2217         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2218         * cp-support.c (add_symbol_overload_list_qualified): Use
2219         all_objfiles.
2220         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2221         Use all_objfiles.
2222         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2223         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2224         all_objfiles.
2225         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2226         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2227         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2228         Uses all_objfiles.
2229         * solib.c (solib_read_symbols): Use all_objfiles
2230
2231 2019-01-09  Tom Tromey  <tom@tromey.com>
2232
2233         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2234         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2235         all_objfiles.
2236         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2237         * symmisc.c (print_symbol_bcache_statistics)
2238         (print_objfile_statistics, maintenance_print_objfiles)
2239         (maintenance_info_symtabs, maintenance_check_symtabs)
2240         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2241         all_objfiles.
2242         * source.c (forget_cached_source_info): Use all_objfiles.
2243         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2244         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2245         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2246         * objfiles.c (update_section_map): Use all_objfiles.
2247         (shared_objfile_contains_address_p): Likewise.
2248         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2249         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2250
2251 2019-01-09  Tom Tromey  <tom@tromey.com>
2252
2253         * common/next-iterator.h: New file.
2254         * objfiles.h (class all_objfiles): New.
2255         (struct objfile_iterator): New.
2256
2257 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2258
2259         * NEWS: Move the description of the changed "frame", "select-frame",
2260          and "info frame" commands to the Changed commands section.
2261
2262 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2263
2264         * gdbtypes.c (check_stub_method_group): Remove handling of old
2265         mangling schemes.
2266         * linespec.c (find_methods): Likewise.
2267         * stabsread.c (read_member_functions): Likewise.
2268         * valops.c (search_struct_method): Likewise.
2269         (value_struct_elt_for_reference): Likewise.
2270         * NEWS: Mention this change.
2271
2272 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2273
2274         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2275         print_source_lines.
2276         * source.c (print_source_lines_base): Update line number check.
2277         (print_source_lines): New function.
2278         (source_lines_range::source_lines_range): New function.
2279         * source.h (class source_lines_range): New class.
2280         (print_source_lines): New declaration.
2281
2282 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2283
2284         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2285
2286 2019-01-08  Tom Tromey  <tom@tromey.com>
2287             Simon Marchi  <simon.marchi@ericsson.com>
2288
2289         PR gdb/24060
2290         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2291         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2292         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2293         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2294         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2295         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2296
2297 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2298
2299         * source.c (select_source_symtab): Move header comment to
2300         declaration in source.h.
2301         (forget_cached_source_info_for_objfile): Likewise.
2302         (forget_cached_source_info): Likewise.
2303         (identify_source_line): Likewise.
2304         * source.h (identify_source_line): Move declaration from symtab.h
2305         and add comment from source.c
2306         (print_source_lines): Likewise.
2307         (forget_cached_source_info_for_objfile): Likewise.
2308         (forget_cached_source_info): Likewise.
2309         (select_source_symtab): Likewise.
2310         (enum print_source_lines_flag): Move definition from symtab.h.
2311         * symtab.h (identify_source_line): Move declaration to source.h.
2312         (print_source_lines): Likewise.
2313         (forget_cached_source_info_for_objfile): Likewise.
2314         (forget_cached_source_info): Likewise.
2315         (select_source_symtab): Likewise.
2316         (enum print_source_lines_flag): Move definition to source.h.
2317         * tui/tui-hooks.c: Add 'source.h' include.
2318
2319 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2320
2321         * source.c (print_source_lines_base): Handle requests to print
2322         reverse line number sequences, and guard against empty lines
2323         string.
2324
2325 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2326
2327         * source.c (print_source_lines_base): Fix skip of '\r' if next
2328         character is '\n'.
2329
2330 2019-01-06  Tom Tromey  <tom@tromey.com>
2331
2332         * c-exp.y (struct c_parse_state) <macro_original_text,
2333         expansion_obstack>: New member.
2334         (macro_original_text, expansion_obstack): Remove globals.
2335         (scan_macro_expansion, scanning_macro_expansion)
2336         (finished_macro_expansion): Update.
2337         (scan_macro_cleanup): Remove.
2338         (yylex, c_parse): Update.
2339
2340 2019-01-06  Tom Tromey  <tom@tromey.com>
2341
2342         * c-exp.y (struct c_parse_state) <strings>: New member.
2343         (operator_stoken): Update.
2344
2345 2019-01-06  Tom Tromey  <tom@tromey.com>
2346
2347         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2348         (union type_stack_elt) <typelist_val>: Now a pointer to
2349         std::vector.
2350         (type_stack_cleanup): Don't declare.
2351         (push_typelist): Update.
2352         * parse.c (pop_typelist): Return a std::vector.
2353         (push_typelist): Take a std::vector.
2354         (follow_types): Update.  Do not free args.
2355         (type_stack_cleanup): Remove.
2356         * c-exp.y (struct c_parse_state): New.
2357         (cpstate): New global.
2358         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2359         (nonempty_typelist): Update.
2360         (func_mod): Create a new vector.
2361         (c_parse): Create a c_parse_state.
2362         (check_parameter_typelist): Do not delete params.
2363         (function_method): Update.  Do not delete type_list.
2364
2365 2019-01-06  Tom Tromey  <tom@tromey.com>
2366
2367         PR gdb/28155:
2368         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2369         check_typedef.
2370         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2371         (print_return_value): Likewise.
2372
2373 2019-01-05  Tom Tromey  <tom@tromey.com>
2374
2375         * contrib/cleanup_check.py: Remove.
2376         * contrib/gcc-with-excheck: Remove.
2377         * contrib/exsummary.py: Remove.
2378         * contrib/excheck.py: Remove.
2379
2380 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2381
2382         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2383         NULL. Initialize tpprev to NULL instead of assigning it
2384         to NULL on the next statement.
2385         * windows-nat.c (windows_delete_thread): Remove check for
2386         main_thread_id before printing thread exit notifications.
2387         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2388         Remove thread ID check against main_thread_id.
2389         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2390         windows_delete_thread.
2391         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2392
2393 2019-01-04  Tom Tromey  <tom@tromey.com>
2394
2395         * compile/compile.c (_initialize_compile): Use upper case for
2396         metasyntactic variables.
2397         * symmisc.c (_initialize_symmisc): Use upper case for
2398         metasyntactic variables.
2399         * psymtab.c (_initialize_psymtab): Use upper case for
2400         metasyntactic variables.
2401         * demangle.c (demangle_command): Use upper case for metasyntactic
2402         variables.
2403         (_initialize_demangler): Likewise.
2404         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2405         variables.
2406
2407 2019-01-03  Tom Tromey  <tom@tromey.com>
2408
2409         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2410
2411 2019-01-03  Tom Tromey  <tom@tromey.com>
2412
2413         * python/py-symtab.c (salpy_str): Update.
2414         (struct salpy_sal_object) <symtab>: Now a PyObject.
2415         (salpy_dealloc): Update.
2416         (del_objfile_sal): Use gdbpy_ref.
2417
2418 2019-01-03  Tom Tromey  <tom@tromey.com>
2419
2420         * python/py-type.c (convert_field): Use new_reference.  Return
2421         gdbpy_ref.
2422         (make_fielditem): Return gdbpy_ref.
2423         (typy_fields): Update.
2424         (typy_getitem): Update.
2425         (field_name): Return gdbpy_ref.  Use new_reference.
2426         (typy_iterator_iternext): Update.
2427
2428 2019-01-03  Tom Tromey  <tom@tromey.com>
2429
2430         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2431
2432 2019-01-03  Tom Tromey  <tom@tromey.com>
2433
2434         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2435         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2436         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2437         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2438         (pspy_set_type_printers): Likewise.
2439         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2440         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2441         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2442         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2443         (objfpy_set_type_printers): Likewise.
2444
2445 2019-01-03  Tom Tromey  <tom@tromey.com>
2446
2447         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2448         (gdbpy_print_stack): Use gdbpy_err_fetch.
2449         * python/python-internal.h (class gdbpy_err_fetch): New class.
2450         (class gdbpy_enter) <m_error_type, m_error_value,
2451         m_error_traceback>: Remove.
2452         <m_error>: New member.
2453         (gdbpy_exception_to_string): Don't declare.
2454         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2455         * python/py-value.c (convert_value_from_python): Use
2456         gdbpy_err_fetch.
2457         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2458         gdbpy_exception_to_string.
2459         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2460         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2461         gdbpy_err_fetch.
2462
2463 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2464
2465         * linux-nat.c (delete_lwp_cleanup): Delete.
2466         (struct lwp_deleter): New struct.
2467         (lwp_info_up): New typedef.
2468         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2469         lwp_info_up.
2470
2471 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2472
2473         * linux-fork.c (class scoped_switch_fork_info): New class.
2474         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2475
2476 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2477
2478         * valops.c (find_overload_match): Remove use of null_cleanup, and
2479         calls to do_cleanups.
2480
2481 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2482
2483         * compile/compile-cplus-types.c
2484         (compile_cplus_instance::decl_name): Handle changes to
2485         cp_func_name.
2486         * cp-support.c (cp_func_name): Update header comment, update
2487         return type.
2488         * cp-support.h (cp_func_name): Update return type in declaration.
2489         * valops.c (find_overload_match): Move temp_func local to top
2490         level of function and change its type.  Use temp_func to hold and
2491         delete temporary string obtained from cp_func_name.
2492
2493 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2494
2495         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2496         gdb::char_vector, remove cleanup, and update uses of `msg`.
2497
2498 2019-01-03  Jim Wilson  <jimw@sifive.com>
2499
2500         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2501
2502 2019-01-02  Tom Tromey  <tom@tromey.com>
2503
2504         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2505         (tdesc_parse_xml): Remove cleanups.
2506         * target-descriptions.h (make_cleanup_free_target_description):
2507         Don't declare.
2508         (target_desc_deleter): New struct.
2509         (target_desc_up): New typedef.
2510         * target-descriptions.c (target_desc_deleter::operator()): Rename
2511         from free_target_description.
2512         (make_cleanup_free_target_description): Remove.
2513
2514 2019-01-02  Tom Tromey  <tom@tromey.com>
2515
2516         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2517         constructor, destructor.
2518         (linespec_parser): Remove typedef.
2519         (~linespec_parser): Rename from linespec_parser_delete.
2520         (linespec_lex_to_end, linespec_complete_label)
2521         (linespec_complete): Update.
2522         (decode_line_full): Remove cleanups.
2523         (decode_line_1): Update.
2524
2525 2019-01-02  Tom Tromey  <tom@tromey.com>
2526
2527         * python/python-internal.h (inferior_to_inferior_object): Change
2528         return type.
2529         * python/py-exitedevent.c (create_exited_event_object): Update.
2530         * python/py-inferior.c (inferior_to_inferior_object): Return
2531         gdbpy_ref.
2532         (python_new_inferior, python_inferior_deleted)
2533         (thread_to_thread_object, delete_thread_object)
2534         (build_inferior_list, gdbpy_selected_inferior): Update.
2535         * python/py-infthread.c (create_thread_object): Update.  Also fail
2536         if inferior_to_inferior_object fails.
2537
2538 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2539
2540         * inferior.h (class inferior) <displaced_step_state>: New field.
2541         * infrun.h (struct displaced_step_state): Move here from
2542         infrun.c.  Initialize fields, add constructor.
2543         <inf>: Remove field.
2544         <reset>: New method.
2545         * infrun.c (struct displaced_step_inferior_state): Move to
2546         infrun.h.
2547         (displaced_step_inferior_states): Remove.
2548         (get_displaced_stepping_state): Adust.
2549         (displaced_step_in_progress_any_inferior): Adjust.
2550         (displaced_step_in_progress_thread): Adjust.
2551         (displaced_step_in_progress): Adjust.
2552         (add_displaced_stepping_state): Remove.
2553         (get_displaced_step_closure_by_addr): Adjust.
2554         (remove_displaced_stepping_state): Remove.
2555         (infrun_inferior_exit): Call displaced_step_state.reset.
2556         (use_displaced_stepping): Don't check for NULL.
2557         (displaced_step_prepare_throw): Call
2558         get_displaced_stepping_state.
2559         (displaced_step_fixup): Don't check for NULL.
2560         (prepare_for_detach): Don't check for NULL.
2561
2562 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2563
2564         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2565          in case of call that did not complete.
2566
2567 2019-01-02  Andrey Utkin  <autkin@undo.io>
2568
2569         * symfile.c (find_separate_debug_file): Fix search of debug files for
2570         remote debuggee.
2571
2572 2019-01-02  Tom Tromey  <tom@tromey.com>
2573
2574         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2575         indentation.
2576         * python/py-frame.c (frapy_older): Remove cast.
2577         (frapy_newer): Likewise.
2578         * python/py-breakpoint.c (local_setattro): Remove cast.
2579         * python/py-arch.c (archpy_name): Remove local variable.
2580         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2581
2582 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2583
2584         * unittests/basic_string_view/element_access/char/empty.cc:
2585         Fix year range in copyright header.
2586
2587 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2588
2589         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2590         Delete.
2591         <operator==>: Update with for removed field.
2592         <hash>: Likewise.
2593         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2594         <isa_features>: ...this.
2595         <abi_features>: New field.
2596         (riscv_isa_flen): Update comment.
2597         (riscv_abi_xlen): New declaration.
2598         (riscv_abi_flen): New declaration.
2599         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2600         isa_features.
2601         (riscv_abi_xlen): New function.
2602         (riscv_isa_flen): Update to get answer from isa_features.
2603         (riscv_abi_flen): New function.
2604         (riscv_has_fp_abi): Update to get answer from abi_features.
2605         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2606         xlen and flen.
2607         (riscv_call_info) <xlen, flen>: Update comment.
2608         (riscv_call_arg_struct): Remove invalid assertions
2609         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2610         is removed.
2611         (riscv_gdbarch_init): Gather isa features and abi features
2612         separately, ensure both match on the gdbarch when reusing an old
2613         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2614         a target with 64-bit float hardware.
2615
2616 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2617
2618         * source.c (search_command_helper): Stop reverse search
2619         when line 1 has been searched.
2620
2621 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2622
2623         * record-full.c (record_full_base_target::close): Rewrite
2624         record_full_core_buf_list free logic.
2625
2626 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2627
2628         * break-catch-syscall.c (print_one_catch_syscall): xfree
2629         the last text.
2630
2631 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2632
2633         * top.c (print_gdb_version): Update Copyright year in version
2634         message.
2635
2636 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2637
2638         Update copyright year range in all GDB files.
2639
2640 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2641
2642         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2643
2644 For older changes see ChangeLog-2018.
2645 \f
2646 Local Variables:
2647 mode: change-log
2648 left-margin: 8
2649 fill-column: 74
2650 version-control: never
2651 coding: utf-8
2652 End:
2653