gdb/ChangeLog

   1 2019-04-04  Tom Tromey  <tom@tromey.com>
   2
   3         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
   4         lex_operator, push_back>: New methods.
   5         Update all rules.
   6         (rust_parser::lex_hex, lex_escape): Rename and update.
   7         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
   8         (rust_parser::lex_operator): Rename and update.
   9         (rust_parser::lex_number, rustyylex, rustyyerror)
  10         (rust_lex_test_init, rust_lex_test_sequence)
  11         (rust_lex_test_push_back, rust_lex_tests): Update.
  12         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
  13         parameter.
  14         <lexptr, prev_lexptr>: New members.
  15         (lexptr, prev_lexptr): Don't declare.
  16         * parse.c (lexptr, prev_lexptr): Remove globals.
  17         (parse_exp_in_context): Update.
  18         * p-exp.y (yylex, yyerror): Update.
  19         * m2-exp.y (parse_number, yylex, yyerror): Update.
  20         * go-exp.y (lex_one_token, yyerror): Update.
  21         * f-exp.y (match_string_literal, yylex, yyerror): Update.
  22         * d-exp.y (lex_one_token, yyerror): Update.
  23         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
  24         (lex_one_token, yyerror): Update.
  25         * ada-lex.l (YY_INPUT): Update.
  26         (rewind_to_char): Update.
  27         * ada-exp.y (yyerror): Update.
  28
  29 2019-04-04  Tom Tromey  <tom@tromey.com>
  30
  31         * rust-exp.y (rustyylex, rust_lex_tests): Update.
  32         * parser-defs.h (struct parser_state) <parser_state>: Add new
  33         parameter.
  34         <comma_terminates>: New member.
  35         (comma_terminates): Don't declare global.
  36         * parse.c (comma_terminates): Remove global.
  37         (parse_exp_in_context): Update.
  38         * p-exp.y (yylex): Update.
  39         * m2-exp.y (yylex): Update.
  40         * go-exp.y (lex_one_token): Update.
  41         * f-exp.y (yylex): Update.
  42         * d-exp.y (lex_one_token): Update.
  43         * c-exp.y (lex_one_token): Update.
  44         * ada-lex.l: Update.
  45
  46 2019-04-04  Tom Tromey  <tom@tromey.com>
  47
  48         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
  49         (rustyylex, rust_lex_test_init, rust_lex_test_one)
  50         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
  51         * parser-defs.h (paren_depth): Don't declare.
  52         * parse.c (paren_depth): Remove global.
  53         (parse_exp_in_context): Update.
  54         * p-exp.y (paren_depth): New global.
  55         (pascal_parse): Initialize it.
  56         * m2-exp.y (paren_depth): New global.
  57         (m2_parse): Initialize it.
  58         * go-exp.y (paren_depth): New global.
  59         (go_parse): Initialize it.
  60         * f-exp.y (paren_depth): New global.
  61         (f_parse): Initialize it.
  62         * d-exp.y (paren_depth): New global.
  63         (d_parse): Initialize it.
  64         * c-exp.y (paren_depth): New global.
  65         (c_parse): Initialize it.
  66         * ada-lex.l (paren_depth): New global.
  67         (lexer_init): Initialize it.
  68
  69 2019-04-04  Tom Tromey  <tom@tromey.com>
  70
  71         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
  72         (rust_parser::convert_ast_to_type)
  73         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
  74         * parser-defs.h (struct parser_state) <parser_state>: Add
  75         parameters.  Initialize new members.
  76         <expression_context_block, expression_context_pc>: New members.
  77         * parse.c (expression_context_block, expression_context_pc):
  78         Remove globals.
  79         (parse_exp_in_context): Update.
  80         * p-exp.y: Update all rules.
  81         (yylex): Update.
  82         * m2-exp.y: Update all rules.
  83         (yylex): Update.
  84         * go-exp.y (yylex): Update.
  85         * f-exp.y (yylex): Update.
  86         * d-exp.y: Update all rules.
  87         (yylex): Update.
  88         * c-exp.y: Update all rules.
  89         (lex_one_token, classify_name, yylex, c_parse): Update.
  90         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
  91
  92 2019-04-04  Tom Tromey  <tom@tromey.com>
  93
  94         * gdbarch.h, gdbarch.c: Rebuild.
  95         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
  96         * stap-probe.h:
  97         (struct stap_parse_info): Replace "parser_state" with
  98         "expr_builder".
  99         * parser-defs.h (struct expr_builder): Rename from "parser_state".
 100         (parser_state): New class.
 101         * parse.c (expr_builder): Rename.
 102         (expr_builder::release): Rename.
 103         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
 104         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
 105         (write_exp_elt_longcst, write_exp_elt_floatcst)
 106         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
 107         (write_exp_string_vector, write_exp_bitstring)
 108         (write_exp_msymbol, mark_struct_expression)
 109         (write_dollar_variable)
 110         (insert_type_address_space, increase_expout_size): Replace
 111         "parser_state" with "expr_builder".
 112         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
 113         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
 114         "parser_state" with "expr_builder".
 115
 116 2019-04-04  Tom Tromey  <tom@tromey.com>
 117
 118         * rust-exp.y: Replace "parse_language" with method call.
 119         * p-exp.y:
 120         (yylex): Replace "parse_language" with method call.
 121         * m2-exp.y:
 122         (yylex): Replace "parse_language" with method call.
 123         * go-exp.y (classify_name): Replace "parse_language" with method
 124         call.
 125         * f-exp.y (yylex): Replace "parse_language" with method call.
 126         * d-exp.y (lex_one_token): Replace "parse_language" with method
 127         call.
 128         * c-exp.y:
 129         (lex_one_token, classify_name, yylex): Replace "parse_language"
 130         with method call.
 131         * ada-exp.y (find_primitive_type, type_char)
 132         (type_system_address): Replace "parse_language" with method call.
 133
 134 2019-04-04  Tom Tromey  <tom@tromey.com>
 135
 136         * rust-exp.y: Replace "parse_gdbarch" with method call.
 137         * parse.c (write_dollar_variable, insert_type_address_space):
 138         Replace "parse_gdbarch" with method call.
 139         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
 140         call.
 141         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
 142         call.
 143         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
 144         "parse_gdbarch" with method call.
 145         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
 146         with method call.
 147         * f-exp.y (parse_type, parse_f_type, yylex): Replace
 148         "parse_gdbarch" with method call.
 149         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
 150         "parse_gdbarch" with method call.
 151         * c-exp.y (parse_type, parse_number, classify_name): Replace
 152         "parse_gdbarch" with method call.
 153         * ada-lex.l: Replace "parse_gdbarch" with method call.
 154         * ada-exp.y (parse_type, find_primitive_type, type_char)
 155         (type_system_address): Replace "parse_gdbarch" with method call.
 156
 157 2019-04-04  Tom Tromey  <tom@tromey.com>
 158
 159         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
 160         * stap-probe.c (stap_parse_argument): Update.
 161         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
 162         initial_size parameter.
 163         * rust-exp.y (rust_lex_tests): Update.
 164         * parse.c (parser_state): Update.
 165         (parse_exp_in_context): Update.
 166         * parser-defs.h (struct parser_state) <parser_state>: Remove
 167         "initial_size" parameter.
 168
 169 2019-04-04  Tom Tromey  <tom@tromey.com>
 170
 171         * parser-defs.h (increase_expout_size): Don't declare.
 172         * parse.c (increase_expout_size): Now static.
 173
 174 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
 175
 176         * gnu-nat.c (gnu_nat_target::wait): Fix
 177         target_waitstatus_to_string call.
 178
 179 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 180
 181         * eval.c (evaluate_subexp_standard): Handle internal functions
 182         during Fortran function call handling.
 183
 184 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 185
 186         * NEWS: Mention new internal functions.
 187         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
 188         (read_base_type): Use dwarf2_init_complex_target_type.
 189         * value.c (creal_internal_fn): New function.
 190         (cimag_internal_fn): New function.
 191         (_initialize_values): Register new internal functions.
 192
 193 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 194
 195         * infrun.c (stop_all_threads): If debug_infrun, always
 196         trace the wait status after wait_one, using
 197         target_waitstatus_to_string and target_pid_to_str.
 198         (handle_inferior_event): Replace various trace of
 199         wait status kind by a single trace.
 200         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
 201         wait status kind image by target_waitstatus_to_string.
 202         * target/waitstatus.c (target_waitstatus_to_string): Fix
 203         obsolete comment.
 204
 205 2019-04-01  Tom Tromey  <tromey@adacore.com>
 206
 207         PR symtab/23331:
 208         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
 209
 210 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
 211             Pedro Alves  <palves@redhat.com>
 212
 213         * top.c (quit_force): Call 'finalize_values'.
 214         * value.c (finalize_values): New function.
 215         * value.h (finalize_values): Declare.
 216
 217 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
 218
 219         * NEWS: Announce $_gdb_major and $_gdb_minor.
 220
 221         * top.c (init_gdb_version_vars): New function.
 222         (gdb_init): Call init_gdb_version_vars.
 223
 224 2019-03-29  Tom Tromey  <tromey@adacore.com>
 225
 226         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
 227         help text.  Remove dead code.
 228
 229 2019-03-29  Keith Seitz  <keiths@redhat.com>
 230
 231         From Siddhesh Poyarekar:
 232         * f-lang.h (f77_get_upperbound): Return LONGEST.
 233         (f77_get_lowerbound): Likewise.
 234         * f-typeprint.c (f_type_print_varspec_suffix): Expand
 235         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
 236         print them.
 237         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
 238         plongest to format print it.
 239         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
 240         (f77_get_upperbound): Likewise.
 241         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
 242         LOWER_BOUND to LONGEST.
 243         (f77_create_arrayprint_offset_tbl): Likewise.
 244
 245 2019-03-29  Keith Seitz  <keiths@redhat.com>
 246
 247         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
 248         %s/pulongest for TYPE_LENGTH instead of %d in format
 249         strings.
 250         * ada-typerint.c (ada_print_type): Likewise.
 251         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
 252         * compile/compile-c-support.c (generate_register_struct): Likewise.
 253         * gdbtypes.c (recursive_dump_type): Likewise.
 254         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
 255         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
 256         instead of %d in format strings.
 257         * riscv-tdep.c (riscv_type_alignment): Cast second argument
 258         to std::min to ULONGEST.
 259         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
 260         instead of %d in format strings.
 261         * tracepoint.c (info_scope_command): Likewise.
 262         * typeprint.c (print_offset_data::update)
 263         (print_offset_data::finish): Likewise.
 264         * xtensa-tdep.c (xtensa_store_return_value)
 265         (xtensa_push_dummy_call): Likewise.
 266
 267 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
 268
 269         * windows-nat.c (display_selector): Fixed format specifications
 270         for 64-bit Cygwin.
 271
 272 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 273
 274         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
 275
 276 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
 277
 278         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
 279         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
 280         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
 281         (nios2_linux_init_abi): Install it.
 282
 283 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
 284
 285         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
 286
 287 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
 288
 289         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
 290
 291 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 292             Tom Tromey  <tromey@adacore.com>
 293
 294         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
 295
 296 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
 297
 298         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
 299         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
 300         method to compute the bounds of range types. Also print "[evaluated]"
 301         if the bounds' values come from a dynamic evaluation.
 302
 303 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
 304
 305         * cp-valprint.c (cp_print_value_fields): Don't print trailing
 306         whitespace when pretty printing is on.
 307
 308 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
 309
 310         * ppc-linux-nat.c: Add include.
 311
 312 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
 313
 314         * NEWS: Mention AArch64 Pointer Authentication.
 315
 316 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
 317
 318         * arm-linux-nat.c: Add include.
 319
 320 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
 321
 322         * source-cache.c (source_cache::get_source_lines): Re-read
 323         fullname after calling open_source_file.
 324
 325 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
 326
 327         * NEWS: Mention TLS support for FreeBSD.
 328
 329 2019-03-25  Tom Tromey  <tromey@adacore.com>
 330
 331         * minsyms.c (BUNCH_SIZE): Update comment.
 332         (~minimal_symbol_reader): Remove old comment.
 333         (compact_minimal_symbols): Update comment.
 334         (minimal_symbol_reader::install): Remove old comment.  Update
 335         other comments.
 336
 337 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
 338
 339         * s390-linux-nat.c: Add include.
 340
 341 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
 342
 343         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 344         Call linux_get_hwcap.
 345         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
 346         Likewise.
 347         (aarch64_linux_get_hwcap): Remove function.
 348         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
 349         declaration.
 350         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
 351         linux_get_hwcap.
 352         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 353         * linux-tdep.c (linux_get_hwcap): Add function.
 354         (linux_get_hwcap2): Likewise.
 355         * linux-tdep.h (linux_get_hwcap): Add declaration.
 356         (linux_get_hwcap2): Likewise.
 357         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
 358         (ppc_linux_get_hwcap2): Likewise.
 359         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
 360         linux_get_hwcap.
 361         (ppc_linux_nat_target::insert_watchpoint): Likewise.
 362         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
 363         (ppc_linux_nat_target::read_description): Likewise.
 364         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
 365         * s390-linux-nat.c: Likewise.
 366         * s390-linux-tdep.c (s390_core_read_description): Likewise.
 367
 368 2019-03-24  Tom Tromey  <tom@tromey.com>
 369
 370         * ada-lang.c (standard_lookup): Simplify initialization.
 371         (ada_lookup_symbol_nonlocal): Simplify return.
 372         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
 373         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
 374         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
 375         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
 376         initialization.
 377         * solib.c (solib_global_lookup): Simplify.
 378         * symtab.c (null_block_symbol): Remove.
 379         (symbol_cache_lookup): Simplify returns.
 380         (lookup_language_this): Simplify returns.
 381         (lookup_symbol_aux): Simplify return.
 382         (lookup_local_symbol): Simplify returns.
 383         (lookup_global_symbol_from_objfile): Simplify return.
 384         (lookup_symbol_in_objfile_symtabs)
 385         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
 386         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
 387         (lookup_static_symbol, lookup_global_symbol): Simplify return.
 388         * cp-namespace.c (cp_lookup_bare_symbol)
 389         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
 390         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
 391         (cp_lookup_nested_symbol): Don't use null_block_symbol.
 392         (cp_lookup_symbol_via_imports): Simplify initialization.
 393         (find_symbol_in_baseclass): Likewise.
 394         * symtab.h (null_block_symbol): Remove.
 395         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
 396         (d_lookup_nested_symbol, d_lookup_symbol_imports)
 397         (d_lookup_symbol_module): Likewise.
 398         (find_symbol_in_baseclass): Simplify initialization.
 399
 400 2019-03-24  Tom Tromey  <tom@tromey.com>
 401
 402         * expression.h: Don't include symtab.h.
 403         (struct block): Forward declare.
 404
 405 2019-03-24  Tom Tromey  <tom@tromey.com>
 406
 407         * c-exp.y (typebase): Remove casts.
 408         * gdbtypes.c (lookup_unsigned_typename, )
 409         (lookup_signed_typename): Remove cast.
 410         * eval.c (parse_to_comma_and_eval): Remove cast.
 411         * parse.c (write_dollar_variable): Remove cast.
 412         * block.h (struct block) <superblock>: Now const.
 413         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
 414         * psymtab.c (psym_map_matching_symbols): Make "block" const.
 415         (map_block): Make "block" const.
 416         * symfile.h (struct quick_symbol_functions)
 417         <map_matching_symbols>: Constify block argument to "callback".
 418         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
 419         const.
 420         (find_pc_sect_compunit_symtab): Make "b" const.
 421         (find_symbol_at_address): Likewise.
 422         (search_symbols): Likewise.
 423         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
 424         (dw2_debug_names_lookup_symbol): Likewise.
 425         (dw2_map_matching_symbols): Update.
 426         * p-valprint.c (pascal_val_print): Remove "block".
 427         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
 428         (aux_add_nonlocal_symbols): Make "block" const.
 429         (resolve_subexp): Remove cast.
 430         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
 431         const.
 432         (iterate_over_file_blocks): Likewise.
 433         * f-exp.y (%union) <bval>: Remove.
 434         * coffread.c (patch_opaque_types): Make "b" const.
 435         * spu-tdep.c (spu_catch_start): Make "block" const.
 436         * c-valprint.c (print_unpacked_pointer): Remove "block".
 437         * symmisc.c (dump_symtab_1): Make "b" const.
 438         (block_depth): Make "block" const.
 439         * d-exp.y (%union) <bval>: Remove.
 440         * cp-support.h (cp_lookup_rtti_type): Update.
 441         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
 442         * psymtab.c (psym_lookup_symbol): Make "block" const.
 443         (maintenance_check_psymtabs): Make "b" const.
 444         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
 445         (enumerate_locals, enumerate_args): Update.
 446         * python/py-symtab.c (stpy_global_block): Make "block" const.
 447         (stpy_static_block): Likewise.
 448         * inline-frame.c (block_starting_point_at): Make "new_block"
 449         const.
 450         * block.c (find_block_in_blockvector): Make return type const.
 451         (blockvector_for_pc_sect): Make "b" const.
 452         (find_block_in_blockvector): Make "b" const.
 453
 454 2019-03-23  Tom Tromey  <tom@tromey.com>
 455
 456         * varobj.c (varobj_create): Update.
 457         * symfile.c (clear_symtab_users): Don't reset innermost_block.
 458         * printcmd.c (display_command, do_one_display): Don't reset
 459         innermost_block.
 460         * parser-defs.h (enum innermost_block_tracker_type): Move to
 461         expression.h.
 462         (innermost_block): Update comment.
 463         * parse.c (parse_exp_1): Add tracker_types parameter.
 464         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
 465         tracker_types parameter.  Reset innermost_block.
 466         (parse_exp_in_context): Remove.
 467         (parse_expression_for_completion): Update.
 468         * objfiles.c (~objfile): Don't reset expression_context_block or
 469         innermost_block.
 470         * expression.h (enum innermost_block_tracker_type): Move from
 471         parser-defs.h.
 472         (parse_exp_1): Add tracker_types parameter.
 473         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
 474         reset innermost_block.
 475
 476 2019-03-23  Tom Tromey  <tom@tromey.com>
 477
 478         * objfiles.h: Include bcache.h.
 479
 480 2019-03-23  Tom Tromey  <tom@tromey.com>
 481
 482         * linespec.c (get_current_search_block): Use
 483         scoped_restore_current_language.
 484         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
 485
 486 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 487             Jiong Wang  <jiong.wang@arm.com>
 488
 489         * aarch64-linux-tdep.c
 490         (aarch64_linux_iterate_over_regset_sections): Check for pauth
 491         section.
 492         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
 493
 494 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 495             Jiong Wang  <jiong.wang@arm.com>
 496
 497         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
 498         instructions.
 499         (aarch64_analyze_prologue_test): Add PACIASP test.
 500         (aarch64_prologue_prev_register): Unmask PC value.
 501
 502 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 503             Jiong Wang  <jiong.wang@arm.com>
 504
 505         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
 506         (aarch64_dwarf2_prev_register): Unmask PC value.
 507         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
 508         (aarch64_execute_dwarf_cfa_vendor_op): Check for
 509         DW_CFA_AARCH64_negate_ra_state.
 510         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
 511
 512 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 513             Jiong Wang  <jiong.wang@arm.com>
 514
 515         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
 516         registers.
 517         (aarch64_pseudo_register_name): Likewise.
 518         (aarch64_pseudo_register_type): Likewise.
 519         (aarch64_pseudo_register_reggroup_p): Likewise.
 520         (aarch64_gdbarch_init): Add pauth registers.
 521         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
 522         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
 523         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
 524         (struct gdbarch_tdep): Add regnum for ra_state.
 525
 526 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 527             Jiong Wang  <jiong.wang@arm.com>
 528
 529         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
 530
 531 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 532             Jiong Wang  <jiong.wang@arm.com>
 533
 534         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
 535         function.
 536         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
 537         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
 538         (aarch64_gdbarch_init): Add puth registers.
 539         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
 540         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
 541         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
 542
 543 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 544             Jiong Wang  <jiong.wang@arm.com>
 545
 546         * aarch64-linux-nat.c
 547         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
 548         * aarch64-linux-tdep.c
 549         (aarch64_linux_core_read_description): Likewise.
 550         (aarch64_linux_get_hwcap): New function.
 551         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
 552         (aarch64_linux_get_hwcap): New declaration.
 553
 554 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 555             Jiong Wang  <jiong.wang@arm.com>
 556
 557         * aarch64-linux-nat.c
 558         (aarch64_linux_nat_target::read_description): Add pauth param.
 559         * aarch64-linux-tdep.c
 560         (aarch64_linux_core_read_description): Likewise.
 561         * aarch64-tdep.c (struct target_desc): Add in pauth.
 562         (aarch64_read_description): Add pauth param.
 563         (aarch64_gdbarch_init): Likewise.
 564         * aarch64-tdep.h (aarch64_read_description): Likewise.
 565         * arch/aarch64.c (aarch64_create_target_description): Likewise.
 566         * arch/aarch64.h (aarch64_create_target_description): Likewise.
 567         * features/Makefile: Add new files.
 568         * features/aarch64-pauth.c: New file.
 569         * features/aarch64-pauth.xml: New file.
 570
 571 2019-03-20  Tom Tromey  <tromey@adacore.com>
 572
 573         * infrun.c (handle_inferior_event): Rename from
 574         handle_inferior_event_1.  Create a scoped_value_mark.
 575         (handle_inferior_event): Remove.
 576
 577 2019-03-19  Tom Tromey  <tromey@adacore.com>
 578
 579         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
 580         * infrun.h (print_stop_event): Add "displays" parameter.
 581         * infrun.c (print_stop_event): Add "displays" parameter.
 582
 583 2019-03-19  Pedro Alves  <palves@redhat.com>
 584
 585         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
 586         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
 587         to -1.  Fix TABs vs spaces.
 588         (tui_ui_out::tui_ui_out): Don't initialize fields here.
 589         * tui/tui-out.h (tui_ui_out) Add intro comments.
 590         <m_line, m_start_of_line>: In-class initialize, and add describing
 591         comment.
 592
 593 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
 594
 595         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
 596         variable names.
 597         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
 598
 599 2019-03-18  Pedro Alves  <palves@redhat.com>
 600             Eli Zaretskii <eliz@gnu.org>
 601
 602         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
 603         m_line and m_start_of_line.
 604
 605 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
 606
 607         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
 608         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
 609         it returns a newline.  This fixes a regression in TU mode, whereby
 610         the next line is output on the same screen line as the user input.
 611
 612 2019-03-18  Tom Tromey  <tromey@adacore.com>
 613
 614         * minsyms.c (minimal_symbol_reader::install): Remove call to
 615         obstack_blank.
 616
 617 2019-03-18  Pedro Alves  <palves@redhat.com>
 618
 619         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
 620         New globals.
 621         (apply_style): New, factored out from ...
 622         (apply_ansi_escape): ... this.  Handle reverse video mode.
 623         (tui_set_reverse_mode): New function.
 624         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
 625         * tui/tui-winsource.c (tui_show_source_line): Use
 626         tui_set_reverse_mode instead of setting A_STANDOUT.
 627         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
 628         New setter methods.
 629
 630 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
 631
 632         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
 633         Handle tabs.
 634
 635 2019-03-18  Tom Tromey  <tromey@adacore.com>
 636
 637         * ada-lang.c (empty_array): Add "high" parameter.
 638         (ada_evaluate_subexp): Update.
 639
 640 2019-03-17  Sergei Trofimovich <siarheit@google.com>
 641
 642         * unittests/string_view-selftests.c: Define
 643         _initialize_string_view_selftests unconditionally.
 644
 645 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 646
 647         PR gdb/24350
 648         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
 649
 650 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 651
 652         PR gdb/24351
 653         * windows-nat.c (display_selector): Fix format specifiers.
 654
 655 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
 656
 657         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
 658         tui_refill_source_window instead of tui_refresh_win, to update the
 659         current execution line.  This fixes redisplay of the current line
 660         when stepping through the code with "next" or "step".
 661
 662 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 663
 664         * source-cache.c (source_cache::get_source_lines): Call
 665         find_source_lines to initialize s->nlines.  This fixes vertical
 666         scrolling of TUI source window when the DOWN arrow is pressed.
 667
 668 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 669
 670         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
 671         linux-thread-db.c (_initialize_thread_db): Likewise.
 672
 673 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 674
 675         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
 676         wclrtoeol in tui_show_source_line".  This reverts changes made in
 677         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
 678
 679 2019-03-15  Tom Tromey  <tom@tromey.com>
 680
 681         * symtab.h (struct minimal_symbol): Derive from
 682         general_symbol_info.
 683         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
 684         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
 685         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
 686         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
 687         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
 688         (MSYMBOL_SEARCH_NAME): Update.
 689         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
 690         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
 691         * minsyms.c (minimal_symbol_reader::record_full): Update.
 692
 693 2019-03-15  Tom Tromey  <tom@tromey.com>
 694
 695         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
 696
 697 2019-03-15  Tom Tromey  <tom@tromey.com>
 698
 699         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
 700         unique_xmalloc_ptr.
 701         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
 702         Update.
 703         * minsyms.c (lookup_minimal_symbol_by_pc_section)
 704         (build_minimal_symbol_hash_tables)
 705         (minimal_symbol_reader::install): Update.
 706
 707 2019-03-15  Tom Tromey  <tom@tromey.com>
 708
 709         * symtab.c (create_demangled_names_hash): Update.
 710         (symbol_set_names): Update.
 711         * objfiles.h (struct objfile_per_bfd_storage)
 712         <demangled_names_hash>: Now an htab_up.
 713         * objfiles.c (objfile_per_bfd_storage): Simplify.
 714
 715 2019-03-15  Tom Tromey  <tom@tromey.com>
 716
 717         * objfiles.h (struct objfile_per_bfd_storage): Declare
 718         destructor.
 719         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
 720         New.
 721         (get_objfile_bfd_data): Use new.  Don't initialize
 722         language_of_main.
 723         (free_objfile_per_bfd_storage): Remove.
 724         (objfile_bfd_data_free, objfile::~objfile): Use delete.
 725
 726 2019-03-15  Tom Tromey  <tom@tromey.com>
 727
 728         * symfile.c (reread_symbols): Update.
 729         * objfiles.c (objfile::objfile): Update.
 730         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
 731         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
 732         comment.
 733         (minimal_symbol_reader::install): Update.
 734         (terminate_minimal_symbol_table): Remove.
 735         * jit.c (jit_object_close_impl): Update.
 736
 737 2019-03-15  Tom Tromey  <tom@tromey.com>
 738
 739         * minsyms.c (minimal_symbol_reader::record_full): Remove some
 740         initializations.
 741
 742 2019-03-15  Tom Tromey  <tom@tromey.com>
 743
 744         * objfiles.h (struct objfile_per_bfd_storage)
 745         <demangled_hash_languages>: Now a bitset.
 746         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 747         (lookup_minimal_symbol): Update.
 748
 749 2019-03-15  Tom Tromey  <tom@tromey.com>
 750
 751         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
 752         Don't return the symbol.
 753         * coffread.c (record_minimal_symbol): Use record_full.
 754
 755 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
 756
 757         The MS-Windows port of ncurses fails to switch to a color pair if
 758         one or both of the colors are the implicit default colors.  This
 759         change records the default colors when TUI is initialized, and
 760         then specifies them explicitly when a color pair uses the default
 761         colors.  This allows color styling in TUI mode on MS-Windows.
 762
 763         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
 764         ncurses_norm_attr.
 765         (tui_initialize_io) [__MINGW32__]: Record the default terminal
 766         colors in ncurses_norm_attr.
 767         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
 768         "none", replace it with the default color recorded in
 769         ncurses_norm_attr.
 770
 771 2019-03-14  Tom Tromey  <tromey@adacore.com>
 772
 773         * source-cache.h (class source_cache) <get_source_lines>: Return
 774         std::string.
 775         * source-cache.c (source_cache::extract_lines): Handle case where
 776         first_pos==npos.  Return std::string.
 777         (source_cache::get_source_lines): Update.
 778
 779 2019-03-14  Tom Tromey  <tromey@adacore.com>
 780
 781         * NEWS: Add item for "style sources" commands.
 782         * source-cache.c (source_cache::get_source_lines): Check
 783         source_styling.
 784         * cli/cli-style.c (source_styling): New global.
 785         (_initialize_cli_style): Add "style sources" commands.
 786         (show_style_sources): New function.
 787         * cli/cli-style.h (source_styling): Declare.
 788
 789 2019-03-14  Pedro Alves  <palves@redhat.com>
 790             Tom Tromey  <tromey@adacore.com>
 791
 792         * tui/tui-winsource.h (tui_refill_source_window): Declare.
 793         * tui/tui-winsource.c (tui_refill_source_window): New function,
 794         from...
 795         (tui_horizontal_source_scroll): ... here.  Move some logic.
 796         * cli/cli-style.c (set_style_enabled): Notify new observable.
 797         * tui/tui-hooks.c (tui_redisplay_source): New function.
 798         (tui_attach_detach_observers): Attach or detach
 799         tui_redisplay_source.
 800         * observable.h (source_styling_changed): New observable.
 801         * observable.c: Define source_styling_changed observable.
 802
 803 2019-03-13  Tom Tromey  <tromey@adacore.com>
 804
 805         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
 806         (i386_gnu_nat_target::store_registers): Update.
 807         * target-debug.h (target_debug_print_std_string): New macro.
 808         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
 809         * windows-tdep.c (display_one_tib): Update.
 810         * tui/tui-stack.c (tui_make_status_line): Update.
 811         * top.c (print_inferior_quit_action): Update.
 812         * thread.c (thr_try_catch_cmd): Update.
 813         (add_thread_with_info): Update.
 814         (thread_target_id_str): Update.
 815         (thr_try_catch_cmd): Update.
 816         (thread_command): Update.
 817         (thread_find_command): Update.
 818         * record-btrace.c (record_btrace_target::info_record)
 819         (record_btrace_resume_thread, record_btrace_target::resume)
 820         (record_btrace_cancel_resume, record_btrace_step_thread)
 821         (record_btrace_target::wait, record_btrace_target::wait)
 822         (record_btrace_target::wait, record_btrace_target::stop): Update.
 823         * progspace.c (print_program_space): Update.
 824         * process-stratum-target.c
 825         (process_stratum_target::thread_address_space): Update.
 826         * linux-fork.c (linux_fork_mourn_inferior)
 827         (detach_checkpoint_command, info_checkpoints_command)
 828         (linux_fork_context): Update.
 829         (linux_fork_detach): Update.
 830         (class scoped_switch_fork_info): Update.
 831         (delete_checkpoint_command): Update.
 832         * infrun.c (follow_fork_inferior): Update.
 833         (follow_fork_inferior): Update.
 834         (proceed_after_vfork_done): Update.
 835         (handle_vfork_child_exec_or_exit): Update.
 836         (follow_exec): Update.
 837         (displaced_step_prepare_throw): Update.
 838         (displaced_step_restore): Update.
 839         (start_step_over): Update.
 840         (resume_1): Update.
 841         (clear_proceed_status_thread): Update.
 842         (proceed): Update.
 843         (print_target_wait_results): Update.
 844         (do_target_wait): Update.
 845         (context_switch): Update.
 846         (stop_all_threads): Update.
 847         (restart_threads): Update.
 848         (finish_step_over): Update.
 849         (handle_signal_stop): Update.
 850         (switch_back_to_stepped_thread): Update.
 851         (keep_going_pass_signal): Update.
 852         (print_exited_reason): Update.
 853         (normal_stop): Update.
 854         * inferior.c (inferior_pid_to_str): Change return type.
 855         (print_selected_inferior): Update.
 856         (add_inferior): Update.
 857         (detach_inferior): Update.
 858         * dummy-frame.c (fprint_dummy_frames): Update.
 859         * dcache.c (dcache_info_1): Update.
 860         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
 861         (btrace_fetch, btrace_clear): Update.
 862         * linux-tdep.c (linux_core_pid_to_str): Change return type.
 863         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
 864         type.
 865         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
 866         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
 867         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
 868         * gdbarch.c, gdbarch.h: Rebuild.
 869         * gdbarch.sh (core_pid_to_str): Change return type.
 870         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
 871         return type.
 872         (windows_nat_target::pid_to_str): Change return type.
 873         (windows_delete_thread): Update.
 874         (windows_nat_target::attach): Update.
 875         (windows_nat_target::files_info): Update.
 876         * target-delegates.c: Rebuild.
 877         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
 878         return type.
 879         (sol_thread_target::pid_to_str): Change return type.
 880         * remote.c (class remote_target) <pid_to_str>: Change return
 881         type.
 882         (remote_target::pid_to_str): Change return type.
 883         (extended_remote_target::attach, remote_target::remote_stop_ns)
 884         (remote_target::remote_notif_remove_queued_reply)
 885         (remote_target::push_stop_reply, remote_target::disable_btrace):
 886         Update.
 887         (extended_remote_target::attach): Update.
 888         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
 889         type.
 890         (gdbsim_target::pid_to_str): Change return type.
 891         * ravenscar-thread.c (struct ravenscar_thread_target)
 892         <pid_to_str>: Change return type.
 893         (ravenscar_thread_target::pid_to_str): Change return type.
 894         * procfs.c (class procfs_target) <pid_to_str>: Change return
 895         type.
 896         (procfs_target::pid_to_str): Change return type.
 897         (procfs_target::attach): Update.
 898         (procfs_target::detach): Update.
 899         (procfs_target::fetch_registers): Update.
 900         (procfs_target::store_registers): Update.
 901         (procfs_target::wait): Update.
 902         (procfs_target::files_info): Update.
 903         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
 904         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
 905         return type.
 906         (nto_procfs_target::pid_to_str): Change return type.
 907         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
 908         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
 909         return type.
 910         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
 911         (exit_lwp): Update.
 912         (attach_proc_task_lwp_callback, get_detach_signal)
 913         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
 914         (linux_nat_target::resume, wait_lwp, stop_callback)
 915         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
 916         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
 917         (linux_nat_wait_1, resume_stopped_resumed_lwps)
 918         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
 919         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
 920         type.
 921         (inf_ptrace_target::attach): Update.
 922         (inf_ptrace_target::files_info): Update.
 923         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
 924         type.
 925         (go32_nat_target::pid_to_str): Change return type.
 926         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
 927         (gnu_nat_target::wait): Update.
 928         (gnu_nat_target::wait): Update.
 929         (gnu_nat_target::resume): Update.
 930         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
 931         (fbsd_nat_target::wait): Update.
 932         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
 933         type.
 934         (darwin_nat_target::attach): Update.
 935         * corelow.c (class core_target) <pid_to_str>: Change return type.
 936         (core_target::pid_to_str): Change return type.
 937         * target.c (normal_pid_to_str): Change return type.
 938         (default_pid_to_str): Likewise.
 939         (target_pid_to_str): Change return type.
 940         (target_translate_tls_address): Update.
 941         (target_announce_detach): Update.
 942         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
 943         return type.
 944         (bsd_uthread_target::pid_to_str): Change return type.
 945         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
 946         type.
 947         (bsd_kvm_target::pid_to_str): Change return type.
 948         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
 949         return type.
 950         (aix_thread_target::pid_to_str): Change return type.
 951         * target.h (struct target_ops) <pid_to_str>: Change return type.
 952         (target_pid_to_str, normal_pid_to_str): Likewise.
 953         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
 954         type.
 955         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
 956         type.
 957         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
 958         return type.
 959         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
 960         type.
 961         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
 962         type.
 963         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
 964         return type.
 965
 966 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
 967
 968         * NEWS: Mention that the new default MI version is 3.  Mention
 969         changes to the output of commands and events that deal with
 970         multi-location breakpoints.
 971         * breakpoint.c: Include "mi/mi-out.h".
 972         (print_one_breakpoint): Change output syntax if using MI version
 973         >= 3.
 974         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
 975         New.
 976         (mi_multi_location_breakpoint_output_fixed): New.
 977         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
 978         (mi_cmd_fix_multi_location_breakpoint_output): New.
 979         (mi_multi_location_breakpoint_output_fixed): New.
 980         * mi/mi-cmds.c (mi_cmds): Register command
 981         -fix-multi-location-breakpoint-output.
 982         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
 983         interpreter "mi".
 984
 985 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
 986
 987         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
 988         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
 989         instantiate mi_ui_out based on interpreter name.
 990         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
 991         * mi/mi-main.c (mi_load_progress): Likewise.
 992
 993 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 994
 995         * NEWS: Combine separate "New targets" sections for 8.3.
 996
 997 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 998
 999         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
1000         (ppcfbsd_init_abi): Install gdbarch
1001         "fetch_tls_load_module_address" and "get_thread_local_address"
1002         methods.
1003
1004 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1005
1006         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
1007         (riscv_fbsd_init_abi): Install gdbarch
1008         "fetch_tls_load_module_address" and "get_thread_local_address"
1009         methods.
1010
1011 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1012
1013         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
1014         (i386fbsd_init_abi): Install gdbarch
1015         "fetch_tls_load_module_address" and "get_thread_local_address"
1016         methods.
1017
1018 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1019
1020         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
1021         (amd64fbsd_init_abi): Install gdbarch
1022         "fetch_tls_load_module_address" and "get_thread_local_address"
1023         methods.
1024
1025 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1026
1027         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
1028         (struct fbsd_pspace_data): New type.
1029         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
1030         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
1031         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
1032         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
1033         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
1034
1035 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1036
1037         * gdbtypes.c (lookup_struct_elt): New function.
1038         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
1039         * gdbtypes.h (struct struct_elt): New type.
1040         (lookup_struct_elt): New prototype.
1041
1042 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1043
1044         * gdbtypes.c (lookup_struct_elt_type): Update comment and
1045         remove disabled code block.
1046
1047 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1048
1049         * gdbarch.sh (get_thread_local_address): New method.
1050         * gdbarch.h, gdbarch.c: Regenerate.
1051         * target.c (target_translate_tls_address): Use
1052         gdbarch_get_thread_local_address if present instead of
1053         target::get_thread_local_address.
1054
1055 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1056
1057         * target.h (target::get_thread_local_address): Update comment.
1058
1059 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1060
1061         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
1062         objfile->separate_debug_objfile_backlink if not NULL.
1063
1064 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1065
1066         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
1067         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
1068         (amd64bsd_store_inferior_registers): Likewise.
1069         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
1070         Enable segment base registers.
1071         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
1072         PT_GETFSBASE and PT_GETGSBASE.
1073         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
1074         PT_SETGSBASE.
1075         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
1076         segment base registers.
1077         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
1078
1079 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1080
1081         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
1082         Update calls to i386_target_description to add 'segments'
1083         parameter.
1084         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
1085         add segment base registers.
1086         * arch/i386.c (i386_create_target_description): Add 'segments'
1087         parameter to enable segment base registers.
1088         * arch/i386.h (i386_create_target_description): Likewise.
1089         * features/i386/32bit-segments.xml: New file.
1090         * features/i386/32bit-segments.c: Generate.
1091         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
1092         call to i386_target_description to add 'segments' parameter.
1093         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
1094         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
1095         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
1096         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
1097         if feature is present.
1098         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
1099         Add 'segments' parameter to call to i386_target_description.
1100         (i386_target_description): Add 'segments' parameter to enable
1101         segment base registers.
1102         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
1103         to call to i386_target_description.
1104         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
1105         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
1106         Define I386_NUM_REGS.
1107         (i386_target_description): Add 'segments' parameter to enable
1108         segment base registers.
1109
1110 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
1111
1112         PR/24325
1113         * source-cache.c: #undef open and close, to avoid unresolved
1114         externals during linking.
1115
1116 2019-03-12  Tom Tromey  <tromey@adacore.com>
1117
1118         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
1119         const.  Add initializers.
1120         (_initialize_remote): Don't initialize ptid globals.
1121
1122 2019-03-12  Pedro Alves  <palves@redhat.com>
1123
1124         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
1125
1126 2019-03-12  Pedro Alves  <palves@redhat.com>
1127
1128         * cp-name-parser.y (main): Remove unused 'len' variable.
1129
1130 2019-03-12  Tom Tromey  <tromey@adacore.com>
1131
1132         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
1133         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
1134
1135 2019-03-12  Tom Tromey  <tromey@adacore.com>
1136
1137         * linux-nat.c (iterate_over_lwps): Update.
1138         (stop_callback): Remove parameter.
1139         (stop_wait_callback, detach_callback, resume_set_callback)
1140         (select_singlestep_lwp_callback, set_ignore_sigint)
1141         (status_callback, resumed_callback, resume_clear_callback)
1142         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
1143         data parameter.
1144         (linux_nat_target::detach, linux_nat_target::resume)
1145         (linux_stop_and_wait_all_lwps, select_event_lwp)
1146         (linux_nat_filter_event, linux_nat_wait_1)
1147         (linux_nat_target::kill, linux_nat_target::stop)
1148         (linux_nat_target::stop): Update.
1149         (linux_nat_resume_callback): Change type.
1150         (resume_stopped_resumed_lwps, count_events_callback)
1151         (select_event_lwp_callback): Likewise.
1152         (linux_stop_lwp, linux_nat_stop_lwp): Update.
1153         * arm-linux-nat.c (struct update_registers_data): Remove.
1154         (update_registers_callback): Change type.
1155         (arm_linux_insert_hw_breakpoint1): Update.
1156         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
1157         parameter.
1158         (x86_linux_dr_set_addr): Update.
1159         (x86_linux_dr_set_control): Update.
1160         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
1161         (iterate_over_lwps): Use gdb::function_view.
1162         * nat/aarch64-linux-hw-point.c (struct
1163         aarch64_dr_update_callback_param): Remove.
1164         (debug_reg_change_callback): Change type.
1165         (aarch64_notify_debug_reg_change): Update.
1166         * s390-linux-nat.c (s390_refresh_per_info): Update.
1167
1168 2019-03-11  Tom Tromey  <tromey@adacore.com>
1169
1170         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
1171         redundant assignment to "this_cu".
1172
1173 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1174
1175         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
1176
1177 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1178
1179         * gdbtypes.c (rank_one_type_parm_set): New function extracted
1180         from...
1181         (rank_one_type): ... this.
1182
1183 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1184
1185         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
1186         from...
1187         (rank_one_type): ... this.
1188
1189 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1190
1191         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
1192         from...
1193         (rank_one_type): ... this.
1194
1195 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1196
1197         * gdbtypes.c (rank_one_type_parm_float): New function extracted
1198         from...
1199         (rank_one_type): ... this.
1200
1201 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1202
1203         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
1204         from...
1205         (rank_one_type): ... this.
1206
1207 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1208
1209         * gdbtypes.c (rank_one_type_parm_range): New function extracted
1210         from...
1211         (rank_one_type): ... this.
1212
1213 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1214
1215         * gdbtypes.c (rank_one_type_parm_char): New function extracted
1216         from...
1217         (rank_one_type): ... this.
1218
1219 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1220
1221         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
1222         from...
1223         (rank_one_type): ... this.
1224
1225 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1226
1227         * gdbtypes.c (rank_one_type_parm_int): New function extracted
1228         from...
1229         (rank_one_type): ... this.
1230
1231 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1232
1233         * gdbtypes.c (rank_one_type_parm_func): New function extracted
1234         from...
1235         (rank_one_type): ... this.
1236
1237 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1238
1239         * gdbtypes.c (rank_one_type_parm_array): New function extracted
1240         from...
1241         (rank_one_type): ... this.
1242
1243 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1244
1245         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
1246         from...
1247         (rank_one_type): ... this.
1248
1249 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1250
1251         * inferior.c (initialize_inferiors): Ensure 'help set/show print
1252         inferior-events' shows the example events.
1253
1254 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
1255
1256         Support styling on native MS-Windows console
1257
1258         PR/24315
1259         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
1260         on MS-Windows if $TERM is not defined.
1261
1262         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
1263
1264         * posix-hdep.c (gdb_console_fputs):
1265         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
1266         functions.
1267         * ui-file.h (gdb_console_fputs): Add prototype.
1268
1269         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
1270         back to fputs only if the former returns zero.
1271
1272 2019-03-07  Tom Tromey  <tom@tromey.com>
1273
1274         * symmisc.c (print_symbol_bcache_statistics): Update.
1275         (print_objfile_statistics): Update.
1276         * symfile.c (allocate_symtab): Update.
1277         * stabsread.c: Don't include bcache.h.
1278         * psymtab.h (struct psymbol_bcache): Don't declare.
1279         (class psymtab_storage) <psymbol_cache>: Now a bcache.
1280         (psymbol_bcache_init, psymbol_bcache_free)
1281         (psymbol_bcache_get_bcache): Don't declare.
1282         * psymtab.c (struct psymbol_bcache): Remove.
1283         (psymtab_storage::psymtab_storage): Update.
1284         (psymtab_storage::~psymtab_storage): Update.
1285         (psymbol_bcache_init, psymbol_bcache_free)
1286         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
1287         (add_psymbol_to_bcache): Update.
1288         (allocate_psymtab): Update.
1289         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
1290         macro_cache>: No longer pointers.
1291         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
1292         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
1293         * macrotab.c (macro_bcache): Update.
1294         * macroexp.c: Don't include bcache.h.
1295         * gdbtypes.c (check_types_worklist): Update.
1296         (types_deeply_equal): Remove TRY/CATCH.  Update.
1297         * elfread.c (elf_symtab_read): Update.
1298         * dwarf2read.c: Don't include bcache.h.
1299         * buildsym.c (buildsym_compunit::get_macro_table): Update.
1300         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
1301         (print_bcache_statistics, bcache_memory_used): Don't declare.
1302         (struct bcache): Move from bcache.c.  Add constructor, destructor,
1303         methods.  Rename all data members.
1304         * bcache.c (struct bcache): Move to bcache.h.
1305         (bcache::expand_hash_table): Rename from expand_hash_table.
1306         (bcache): Remove.
1307         (bcache::insert): Rename from bcache_full.
1308         (bcache::compare): Rename from bcache_compare.
1309         (bcache_xmalloc): Remove.
1310         (bcache::~bcache): Rename from bcache_xfree.
1311         (bcache::print_statistics): Rename from print_bcache_statistics.
1312         (bcache::memory_used): Rename from bcache_memory_used.
1313
1314 2019-03-07  Pedro Alves  <palves@redhat.com>
1315
1316         * infrun.c (normal_stop): Also check for
1317         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
1318
1319 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
1320
1321         * f-lang.c (value_from_host_double): Moved to...
1322         * value.c (value_from_host_double): ...here.
1323         * value.h (value_from_host_double): Declare.
1324         * guile/scm-math.c (vlscm_convert_typed_number): Use
1325         value_from_host_double.
1326         (vlscm_convert_number): Likewise.
1327         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
1328         * python/py-value.c (convert_value_from_python): Likewise.
1329
1330 2019-03-06  Tom Tromey  <tom@tromey.com>
1331
1332         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
1333
1334 2019-03-06  Tom Tromey  <tom@tromey.com>
1335
1336         * utils.h (free_current_contents): Don't declare.
1337         * utils.c (free_current_contents): Remove.
1338
1339 2019-03-06  Tom Tromey  <tom@tromey.com>
1340
1341         * top.c (quit_force): Update.
1342         * main.c (captured_command_loop): Update.
1343         * common/new-op.c (operator new): Update.
1344         * common/common-exceptions.c (struct catcher)
1345         <save_cleanup_chain>: Remove member.
1346         (exceptions_state_mc_init): Update.
1347         (exception_try_scope_entry): Return nullptr.
1348         (exception_try_scope_exit, exception_rethrow)
1349         (throw_exception_sjlj, throw_exception_cxx): Update.
1350         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
1351         (all_cleanups, do_cleanups, discard_cleanups)
1352         (discard_final_cleanups, save_cleanups, save_final_cleanups)
1353         (restore_cleanups, restore_final_cleanups): Don't declare.
1354         (do_final_cleanups): Remove parameter.
1355         * common/cleanups.c (cleanup_chain, make_cleanup)
1356         (make_cleanup_dtor, all_cleanups, do_cleanups)
1357         (discard_my_cleanups, discard_cleanups)
1358         (discard_final_cleanups, save_my_cleanups, save_cleanups)
1359         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
1360         (null_cleanup): Remove.
1361         (do_final_cleanups): Remove parameter.
1362
1363 2019-03-06  Tom Tromey  <tom@tromey.com>
1364
1365         * remote.c (remote_target::remote_parse_stop_reply): Use
1366         unique_xmalloc_ptr.
1367
1368 2019-03-06  Tom Tromey  <tom@tromey.com>
1369
1370         * stabsread.c (struct stabs_field_info): Rename from field_info.
1371         <list, fnlist>: Add initializers.
1372         <obstack>: New member.
1373         (read_member_functions, read_struct_fields, read_baseclasses):
1374         Allocate on obstack.  Don't use cleanups.
1375         (read_one_struct_field, read_member_functions, read_struct_fields)
1376         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
1377         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
1378         (read_struct_type): Update.
1379
1380 2019-03-06  Tom Tromey  <tom@tromey.com>
1381
1382         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
1383         * common/filestuff.h (make_cleanup_close): Don't declare.
1384         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
1385         Remove.
1386
1387 2019-03-06  Tom Tromey  <tom@tromey.com>
1388
1389         * solib-aix.c: Use make_scope_exit.
1390
1391 2019-03-06  Tom Tromey  <tom@tromey.com>
1392
1393         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
1394         Use make_scope_exit.
1395
1396 2019-03-06  Tom Tromey  <tom@tromey.com>
1397
1398         * solib-svr4.c (disable_probes_interface): Remove parameter.
1399         (svr4_handle_solib_event): Use make_scope_exit.
1400
1401 2019-03-06  Tom Tromey  <tom@tromey.com>
1402
1403         * remote.c (struct stop_reply_deleter): Remove.
1404         (stop_reply_up): Update.
1405         (struct stop_reply): Derive from notif_event.  Don't typedef.
1406         <regcache>: Now a std::vector.
1407         (stop_reply_xfree): Remove.
1408         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
1409         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
1410         (remote_target::discard_pending_stop_replies): Use delete.
1411         (remote_target::remote_parse_stop_reply): Update.
1412         (remote_target::process_stop_reply): Update.
1413         * remote-notif.h (struct notif_event): Add virtual destructor.
1414         Remove "dtr" member.
1415         (struct notif_client) <alloc_event>: Return a unique_ptr.
1416         (notif_event_xfree): Don't declare.
1417         (notif_event_up): New typedef.
1418         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
1419         (notif_event_xfree, do_notif_event_xfree): Remove.
1420         (remote_notif_state_xfree): Update.
1421
1422 2019-03-06  Tom Tromey  <tom@tromey.com>
1423
1424         * infrun.c (displaced_step_clear_cleanup): Now a
1425         forward_scope_exit type.
1426         (displaced_step_prepare_throw): Update.
1427         (displaced_step_fixup): Update.
1428
1429 2019-03-06  Tom Tromey  <tom@tromey.com>
1430
1431         * inferior.h (class inferior): Update comment.
1432         * gdbthread.h (class thread_info): Update comment.
1433
1434 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
1435             Tom Tromey  <tom@tromey.com>
1436
1437         * stabsread.h (struct stab_section_list): Remove.
1438         (coffstab_build_psymtabs): Update.
1439         * dbxread.c (symbuf_sections): Now a std::vector.
1440         (sect_idx): New global.
1441         (fill_symbuf): Update.
1442         (coffstab_build_psymtabs): Change type of stabsects parameter.
1443         Update.
1444         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
1445         std::vector.
1446         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
1447         (coff_locate_sections): Update.
1448         (coff_symfile_read): Remove cleanups.  Update.
1449         (init_stringtab): Add storage parameter.
1450         (free_stringtab, free_stringtab_cleanup): Remove.
1451         (init_lineno): Add storage parameter.
1452         (free_linetab, free_linetab_cleanup): Remove.
1453
1454 2019-03-06  Pedro Alves  <palves@redhat.com>
1455
1456         * linux-fork.c (fork_info::clobber_regs): Delete.
1457         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
1458         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
1459         comment.  Adjust.
1460         (scoped_switch_fork_info::scoped_switch_fork_info)
1461         (checkpoint_command, linux_fork_context): Adjust
1462         fork_save_infrun_state calls.
1463
1464 2019-03-06  Pedro Alves  <palves@redhat.com>
1465
1466         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
1467         (inf_has_multiple_threads): Return 'bool' and rewrite using
1468         inferior_info::threads().
1469
1470 2019-03-06  Pedro Alves  <palves@redhat.com>
1471
1472         * linux-fork.c: Include <list>.
1473         (fork_list): Now a std::list instance.
1474         (fork_info): Add ctor, dtor, and in-class initialize all fields.
1475         (forks_exist_p, find_last_fork): Adjust.
1476         (new_fork): Delete.
1477         (one_fork_p): New.
1478         (add_fork): Adjust.
1479         (free_fork): Delete, folded into fork_info::~fork_info().
1480         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
1481         Adjust.
1482         (init_fork_list): Delete.
1483         (linux_fork_killall, linux_fork_mourn_inferior)
1484         (linux_fork_detach, info_checkpoints_command): Adjust.
1485         (_initialize_linux_fork): No longer call init_fork_list.
1486
1487 2019-03-06  Pedro Alves  <palves@redhat.com>
1488
1489         * linux-fork.c (new_fork): New, split out of ...
1490         (add_fork): ... this.  Return void.  Move "first fork" special
1491         case from here, to ...
1492         (checkpoint_command): ... here.
1493         * linux-linux.h (add_fork): Return void.
1494
1495 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1496
1497         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
1498
1499 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1500             Chris January  <chris.january@arm.com>
1501             David Lecomber  <david.lecomber@arm.com>
1502
1503         * f-exp.y: New token, UNOP_INTRINSIC.
1504         (exp): New pattern using UNOP_INTRINSIC token.
1505         (f77_keywords): Add 'abs' keyword.
1506         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
1507         (value_from_host_double): New function.
1508         (evaluate_subexp_f): Support UNOP_ABS.
1509
1510 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1511
1512         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
1513         types.
1514
1515 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1516
1517         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
1518         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
1519         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
1520
1521 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1522
1523         * f-exp.y (convert_to_kind_type): Handle more type kinds.
1524
1525 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1526             Chris January  <chris.january@arm.com>
1527
1528         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
1529         * f-exp.y: Define 'KIND' token.
1530         (exp): New pattern for KIND expressions.
1531         (ptype): Handle types with a kind extension.
1532         (direct_abs_decl): Extend to spot kind extensions.
1533         (f77_keywords): Add 'kind' to the list.
1534         (push_kind_type): New function.
1535         (convert_to_kind_type): New function.
1536         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
1537         * parse.c (operator_length_standard): Likewise.
1538         * parser-defs.h (enum type_pieces): Add tp_kind.
1539         * std-operator.def: Add UNOP_KIND.
1540
1541 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1542
1543         * f-exp.y (f_parse): Set yydebug.
1544
1545 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1546
1547         * f-lang.c (evaluate_subexp_f): New function.
1548         (exp_descriptor_f): New global.
1549         (f_language_defn): Use exp_descriptor_f instead of
1550         exp_descriptor_standard.
1551
1552 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1553
1554         * f-exp.y (struct token): Add comments.
1555         (dot_ops): Remove uppercase versions and the end marker.
1556         (f77_keywords): Likewise.
1557         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
1558         entries in the dot_ops array are case insensitive, and use
1559         strncasecmp to compare strings.  Also some whitespace cleanup in
1560         this area.  Similar for the f77_keywords array, except entries in
1561         this list might be case sensitive.
1562
1563 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1564
1565         * f-exp.y (struct f77_boolean_val): Add comments.
1566         (boolean_values): Remove uppercase versions, and end marker.
1567         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
1568         and use strncasecmp to achieve case insensitivity.  Additionally,
1569         perform whitespace cleanup around this code.
1570
1571 2019-03-06  Tom Tromey  <tromey@adacore.com>
1572
1573         * remote-sim.c (gdbsim_target_open): Use result of
1574         gdb_argv::release.
1575
1576 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
1577         Dirk Schubert  <dirk.schubert@arm.com>
1578         Chris January  <chris.january@arm.com>
1579
1580         * eval.c (evaluate_subexp_standard): Call Fortran argument
1581         wrapping logic.
1582         * f-lang.c (struct value): A value which can be passed into a
1583         Fortran function call.
1584         (fortran_argument_convert): Wrap Fortran arguments in a pointer
1585         where appropriate.
1586         (struct type): Value ready for a Fortran function call.
1587         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
1588         is needed.
1589         * f-lang.h (fortran_argument_convert): Declaration.
1590         (fortran_preserve_arg_pointer): Declaration.
1591         * infcall.c (value_arg_coerce): Call Fortran argument logic.
1592
1593 2019-03-05  Tom Tromey  <tromey@adacore.com>
1594
1595         * python/py-prettyprint.c (print_string_repr): Remove #if.
1596         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
1597
1598 2019-03-05  Tom Tromey  <tromey@adacore.com>
1599
1600         * target.c (the_dummy_target): Move later.  Change type to
1601         "dummy_target".
1602         (initialize_targets): Don't initialize the_dummy_target.
1603
1604 2019-03-05  Tom Tromey  <tromey@adacore.com>
1605
1606         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
1607         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
1608
1609 2019-03-05  Tom Tromey  <tromey@adacore.com>
1610
1611         * windows-nat.c (windows_nat_target::attach)
1612         (windows_nat_target::detach): Don't call gdb_flush.
1613         * valprint.c (generic_val_print, val_print, val_print_string):
1614         Don't call gdb_flush.
1615         * utils.c (defaulted_query): Don't call gdb_flush.
1616         * typeprint.c (print_type_scalar): Don't call gdb_flush.
1617         * target.c (target_announce_detach): Don't call gdb_flush.
1618         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
1619         * remote.c (extended_remote_target::attach): Don't call
1620         gdb_flush.
1621         * procfs.c (procfs_target::detach): Don't call gdb_flush.
1622         * printcmd.c (do_examine): Don't call gdb_flush.
1623         (info_display_command): Don't call gdb_flush.
1624         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
1625         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
1626         * memattr.c (info_mem_command): Don't call gdb_flush.
1627         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
1628         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
1629         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
1630         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
1631         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
1632         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
1633         (gnu_nat_target::detach): Don't call gdb_flush.
1634         * f-valprint.c (f_val_print): Don't call gdb_flush.
1635         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
1636         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
1637         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
1638         gdb_flush.
1639         * c-valprint.c (c_val_print): Don't call gdb_flush.
1640         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
1641
1642 2019-03-05  Tom Tromey  <tromey@adacore.com>
1643
1644         * varobj.c (update_dynamic_varobj_children): Update.
1645         (install_default_visualizer): Use reset, not release.
1646         * value.c (set_internalvar): Update.
1647         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
1648         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
1649         ATTRIBUTE_UNUSED_RESULT.
1650
1651 2019-03-05  Tom Tromey  <tromey@adacore.com>
1652
1653         * remote.c (class scoped_remote_fd) <release>: Add
1654         ATTRIBUTE_UNUSED_RESULT.
1655
1656 2019-03-05  Tom Tromey  <tromey@adacore.com>
1657
1658         * macroexp.c (struct macro_buffer) <release>: Add
1659         ATTRIBUTE_UNUSED_RESULT.
1660
1661 2019-03-05  Tom Tromey  <tromey@adacore.com>
1662
1663         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
1664         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
1665         ATTRIBUTE_UNUSED_RESULT.
1666
1667 2019-03-05  Tom Tromey  <tromey@adacore.com>
1668
1669         * common/scoped_fd.h (class scoped_fd) <release>: Add
1670         ATTRIBUTE_UNUSED_RESULT.
1671
1672 2019-03-05  Tom Tromey  <tromey@adacore.com>
1673
1674         * parser-defs.h (struct parser_state) <release>: Add
1675         ATTRIBUTE_UNUSED_RESULT.
1676
1677 2019-03-05  Tom Tromey  <tromey@adacore.com>
1678
1679         * utils.h (class gdb_argv) <release>: Add
1680         ATTRIBUTE_UNUSED_RESULT.
1681         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
1682
1683 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
1684
1685         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
1686         for-loop range, to avoid compiler warnings.
1687
1688         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
1689         avoid compiler warnings about unused variables.
1690
1691         * NEWS: Mention end of support for native debugging on MS-Windows
1692         before XP.
1693
1694         PR gdb/24292
1695         * common/netstuff.c:
1696         * gdbserver/gdbreplay.c
1697         * gdbserver/remote-utils.c:
1698         * ser-tcp.c:
1699         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
1700         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
1701         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
1702         'getaddrinfo' and 'freeaddrinfo' were not available before
1703         Windows XP, and mingw.org's MinGW headers by default define
1704         _WIN32_WINNT to 0x500.
1705
1706 2019-03-01  Gary Benson <gbenson@redhat.com>
1707
1708         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
1709
1710 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
1711             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1712
1713         PR gdb/8527
1714         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
1715         set_sigint_trap, clear_sigint_trap.
1716
1717 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1718
1719         * target.c (target_detach): Clear the regcache and the
1720         frame cache.
1721
1722 2019-02-27  Pedro Alves  <palves@redhat.com>
1723
1724         * utils.c (set_screen_size): When we cap the height/width sizes,
1725         tweak the corresponding command variable to show "unlimited":
1726
1727 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
1728             Pedro Alves  <palves@redhat.com>
1729
1730         * utils.c (set_screen_size): Reduce "infinite" rows and columns
1731         before calling rl_set_screen_size.
1732
1733 2019-02-27  Tom Tromey  <tromey@adacore.com>
1734
1735         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
1736         define.
1737         * python/py-value.c: Remove Python 2.4 workaround.
1738         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
1739         workaround.
1740         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
1741         Python 2.4 workaround.
1742         * python/python-internal.h: Remove Python 2.4 comment.
1743         (Py_ssize_t): Don't define.
1744         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
1745         (gdb_Py_DECREF): Remove Python 2.4 workaround.
1746         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
1747         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
1748         * python/python.c (do_start_initialization): Remove Python 2.4
1749         workaround.
1750         * python/py-prettyprint.c (class dummy_python_frame): Remove.
1751         (print_children): Remove Python 2.4 workaround.
1752         * python/py-inferior.c (buffer_procs): Remove Python 2.4
1753         workaround.
1754         (CHARBUFFERPROC_NAME): Remove.
1755         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
1756         Python 2.4 workaround.
1757
1758 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1759
1760         * NEWS: Note minimum Python version.
1761
1762 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1763
1764         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
1765         code from these functions.  Remove corresponding ifdefs.  Use
1766         Py_buffer_up instead of explicit calls to PyBuffer_Release.
1767         Remove gotos and target of gotos.
1768         (infpy_search_memory): Likewise.
1769
1770 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1771
1772         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
1773         (hppa_gdbarch_init): Don't register deleted functions with
1774         gdbarch.
1775
1776 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1777
1778         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
1779         (h8300_unwind_sp): Delete.
1780         (h8300_dummy_id): Delete.
1781         (h8300_gdbarch_init): Don't register deleted functions with
1782         gdbarch.
1783
1784 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1785
1786         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
1787         (ft32_unwind_pc): Delete.
1788         (ft32_unwind_sp): Delete.
1789         (ft32_gdbarch_init): Don't register deleted functions with
1790         gdbarch.
1791
1792 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1793
1794         * gdb/frv-tdep.c (frv_dummy_id): Delete.
1795         (frv_unwind_pc): Delete.
1796         (frv_unwind_sp): Delete.
1797         (frv_gdbarch_init): Don't register deleted functions with
1798         gdbarch.
1799
1800 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1801
1802         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1803         (riscv_unwind_pc): Delete.
1804         (riscv_unwind_sp): Delete.
1805         (riscv_gdbarch_init): Don't register deleted functions with
1806         gdbarch.
1807
1808 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1809
1810         * gdb/csky-tdep.c (csky_dummy_id): Delete.
1811         (csky_unwind_pc): Delete.
1812         (csky_unwind_sp): Delete.
1813         (csky_gdbarch_init): Don't register deleted functions with
1814         gdbarch.
1815
1816 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1817
1818         * gdb/cris-tdep.c (cris_dummy_id): Delete.
1819         (cris_unwind_pc): Delete.
1820         (cris_unwind_sp): Delete.
1821         (cris_gdbarch_init): Don't register deleted functions with
1822         gdbarch.
1823
1824 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1825
1826         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1827         (bfin_unwind_pc): Delete.
1828         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1829
1830 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1831
1832         * gdb/arm-tdep.c (arm_dummy_id): Delete.
1833         (arm_unwind_pc): Delete.
1834         (arm_unwind_sp): Delete.
1835         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1836
1837 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1838
1839         * gdb/arc-tdep.c (arc_dummy_id): Delete.
1840         (arc_unwind_pc): Delete.
1841         (arc_unwind_sp): Delete.
1842         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1843
1844 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1845
1846         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1847         (alpha_unwind_pc): Delete.
1848         (alpha_gdbarch_init): Don't register deleted functions with
1849         gdbarch.
1850
1851 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1852
1853         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1854         (aarch64_unwind_pc): Delete.
1855         (aarch64_unwind_sp): Delete.
1856         (aarch64_gdbarch_init): Don't register deleted functions with
1857         gdbarch.
1858
1859 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1860
1861         * gdbtypes.c (type_align): Don't consider static members when
1862         computing structure alignment.
1863
1864 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1865
1866         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1867         return 0 for other types.
1868         * arch-utils.c (default_type_align): Always return 0.
1869         * gdbarch.h: Regenerate.
1870         * gdbarch.sh (type_align): Extend comment.
1871         * gdbtypes.c (type_align): Add additional comments, always call
1872         gdbarch_type_align before applying the default rules.
1873         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
1874         generic code will then apply a suitable default.
1875         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
1876         types, return 0 for other types.
1877
1878 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1879
1880         * NEWS: Create a new section for the next release branch.
1881         Rename the section of the current branch, now that it has
1882         been cut.
1883
1884 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1885
1886         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
1887         * version.in: Bump version to 8.3.50.DATE-git.
1888
1889 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
1890
1891         * aix-thread.c (ptid_cmp): Remove unused variable.
1892         (get_signaled_thread): Likewise.
1893         (store_regs_user_thread): Likewise.
1894         (store_regs_kernel_thread): Likewise.
1895         (fetch_regs_kernel_thread): Remove shadowed variable.
1896
1897 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1898
1899         * features/riscv/32bit-cpu.xml: Add register numbers.
1900         * features/riscv/32bit-fpu.c: Regenerate.
1901         * features/riscv/32bit-fpu.xml: Add register numbers.
1902         * features/riscv/64bit-cpu.xml: Add register numbers.
1903         * features/riscv/64bit-fpu.c: Regenerate.
1904         * features/riscv/64bit-fpu.xml: Add register numbers.
1905
1906 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
1907
1908         * NEWS: Mention two argument form of gdb.Value constructor.
1909         * python/py-value.c (convert_buffer_and_type_to_value): New
1910         function.
1911         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
1912         Add support for handling an optional second argument.  Call
1913         convert_buffer_and_type_to_value as appropriate.
1914         * python/python-internal.h (Py_buffer_deleter): New struct.
1915         (Py_buffer_up): New typedef.
1916
1917 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
1918
1919         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
1920         instead of releasing ownership.
1921
1922 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
1923
1924         * dwarf2read.c (open_and_init_dwp_file): Call
1925         elf_numsections instead of bfd_count_sections to initialize
1926         dwp_file->num_sections.
1927
1928 2019-02-25  Tom Tromey  <tromey@adacore.com>
1929
1930         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
1931
1932 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1933
1934         * gcore.in: Add '--readnever' option when invoking GDB.
1935
1936 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1937
1938         * MAINTAINERS: Update my email address.
1939
1940 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1941
1942         * build-id.c (build_id_to_debug_bfd_1): New function.
1943         (build_id_to_debug_bfd): Look for separate debug file in
1944         sysroot.
1945
1946 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1947
1948         * gdbarch.sh: Update the copyright year range that is placed into
1949         generated files.
1950
1951 2019-02-22  Keith Seitz  <keiths@redhat.com>
1952
1953         PR symtab/23853
1954         * linespec.c (create_sals_line_offset): Search for the default
1955         symtab's filename instead of its fullname.
1956
1957 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1958
1959         * NEWS: Update style defaults.
1960
1961 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1962
1963         * main.c (captured_main_1): Disable styling in batch mode.
1964
1965 2019-02-20  Tom Tromey  <tom@tromey.com>
1966
1967         * symtab.c (symtab_symbol_info): Fix typos.
1968
1969 2019-02-20  Tom Tromey  <tromey@adacore.com>
1970
1971         * findcmd.c (_initialize_mem_search): Use upper case for
1972         metasyntactic variables.
1973
1974 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
1975
1976         * aarch64-tdep.c (aarch64_add_reggroups): New function.
1977         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
1978
1979 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
1980
1981         * top.h (source_file_name): Change to std::string.
1982         * top.c (source_file_name): Likewise.
1983         (command_line_input): Adjust.
1984         * cli/cli-script.c (script_from_file): Adjust.
1985
1986 2019-02-19  Tom Tromey  <tromey@adacore.com>
1987
1988         * ravenscar-thread.c
1989         (ravenscar_thread_target::update_thread_list): Don't call
1990         ada_build_task_list.
1991         * ada-lang.h (ada_build_task_list): Don't declare.
1992         * ada-tasks.c (struct ada_tasks_inferior_data)
1993         <task_list_valid_p>: Now bool.
1994         (read_known_tasks, ada_task_list_changed)
1995         (ada_tasks_invalidate_inferior_data): Update.
1996         (read_known_tasks_array): Return bool.
1997         (read_known_tasks_list): Likewise.
1998         (read_known_tasks): Return void.
1999         (ada_build_task_list): Now static.
2000
2001 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2002
2003         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
2004         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
2005
2006 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2007
2008         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
2009         variant for ada_tasks_pspace_data_handle and
2010         ada_tasks_inferior_data_handle.
2011         (ada_tasks_pspace_data_cleanup): New function.
2012         (ada_tasks_inferior_data_cleanup): New function.
2013
2014 2019-02-17  Tom Tromey  <tom@tromey.com>
2015
2016         * macrotab.h (macro_source_fullname): Return a std::string.
2017         * macrotab.c (macro_include, check_for_redefinition)
2018         (macro_undef, macro_lookup_definition, foreach_macro)
2019         (foreach_macro_in_scope): Update.
2020         (macro_source_fullname): Return a std::string.
2021         * macrocmd.c (show_pp_source_pos): Update.
2022
2023 2019-02-17  Tom Tromey  <tom@tromey.com>
2024
2025         * macrocmd.c (show_pp_source_pos): Style the file names.
2026
2027 2019-02-17  Tom Tromey  <tom@tromey.com>
2028
2029         PR tui/24197:
2030         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
2031
2032 2019-02-17  Tom Tromey  <tom@tromey.com>
2033
2034         * ada-lang.c (user_select_syms): Use filtered printing.
2035         * utils.c (wrap_style): New global.
2036         (desired_style): Remove.
2037         (emit_style_escape): Add stream parameter.
2038         (set_output_style, reset_terminal_style, prompt_for_continue):
2039         Update.
2040         (flush_wrap_buffer): Only flush gdb_stdout.
2041         (wrap_here): Set wrap_style.
2042         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
2043         treat escape sequences as a character.  Change when wrap buffer is
2044         flushed.
2045         (fputs_styled): Do not set the output style when the default is
2046         requested.
2047         * ui-style.h (struct ui_file_style) <is_default>: New method.
2048         * source.c (print_source_lines_base): Emit escape sequences in one
2049         piece.
2050
2051 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
2052
2053         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
2054         integers and enumeration types.
2055
2056 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
2057
2058         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
2059         instead of lookup_symbol_in_language
2060         (do_exact_match): New function.
2061         (ada_get_symbol_name_matcher): Return do_exact_match when
2062         doing a verbatim match.
2063
2064 2019-02-15  Tom Tromey  <tromey@adacore.com>
2065
2066         * ravenscar-thread.c (ravenscar_thread_target::resume)
2067         (ravenscar_thread_target::wait): Special case wildcard requests.
2068
2069 2019-02-15  Tom Tromey  <tromey@adacore.com>
2070
2071         * ravenscar-thread.c (base_ptid): Remove.
2072         (struct ravenscar_thread_target) <close>: New method.
2073         <m_base_ptid>: New member.
2074         <update_inferior_ptid, active_task, task_is_currently_active,
2075         runtime_initialized>: Declare methods.
2076         <ravenscar_thread_target>: Add constructor.
2077         (ravenscar_thread_target::task_is_currently_active)
2078         (ravenscar_thread_target::update_inferior_ptid)
2079         (ravenscar_runtime_initialized): Rename.  Now methods.
2080         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
2081         (ravenscar_thread_target::update_thread_list): Update.
2082         (ravenscar_thread_target::active_task): Now method.
2083         (ravenscar_thread_target::store_registers)
2084         (ravenscar_thread_target::prepare_to_store)
2085         (ravenscar_thread_target::prepare_to_store)
2086         (ravenscar_thread_target::mourn_inferior): Update.
2087         (ravenscar_inferior_created): Use "new" to create target.
2088         (ravenscar_thread_target::get_ada_task_ptid): Update.
2089         (_initialize_ravenscar): Don't initialize base_ptid.
2090         (ravenscar_ops): Remove global.
2091
2092 2019-02-15  Tom Tromey  <tromey@adacore.com>
2093
2094         * target.h (push_target): Declare new overload.
2095         * target.c (push_target): New overload, taking an rvalue reference.
2096         * remote.c (remote_target::open_1): Use push_target overload.
2097         * corelow.c (core_target_open): Use push_target overload.
2098
2099 2019-02-15  Tom Tromey  <tromey@adacore.com>
2100
2101         * ravenscar-thread.c (is_ravenscar_task)
2102         (ravenscar_task_is_currently_active): Return bool.
2103         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
2104         (_initialize_ravenscar): Remove "(void)".
2105         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
2106         Return bool.
2107
2108 2019-02-15  Tom Tromey  <tromey@adacore.com>
2109
2110         * ravenscar-thread.c (ravenscar_runtime_initializer)
2111         (has_ravenscar_runtime, get_running_thread_id)
2112         (ravenscar_thread_target::resume): Fix indentation.
2113
2114 2019-02-15  Tom Tromey  <tromey@adacore.com>
2115
2116         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
2117         from ravenscar_arch_ops.
2118         (sparc_ravenscar_ops::fetch_registers)
2119         (sparc_ravenscar_ops::store_registers): Now methods.
2120         (sparc_ravenscar_prepare_to_store): Remove.
2121         (sparc_ravenscar_ops): Redefine.
2122         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
2123         methods and destructor.  Remove members.
2124         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
2125         (ravenscar_thread_target::store_registers)
2126         (ravenscar_thread_target::prepare_to_store): Update.
2127         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
2128         Remove.
2129         (struct ppc_ravenscar_powerpc_ops): Derive from
2130         ravenscar_arch_ops.
2131         (ppc_ravenscar_powerpc_ops::fetch_registers)
2132         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
2133         (ppc_ravenscar_powerpc_ops): Redefine.
2134         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
2135         (ppc_ravenscar_e500_ops::fetch_registers)
2136         (ppc_ravenscar_e500_ops::store_registers): Now methods.
2137         (ppc_ravenscar_e500_ops): Redefine.
2138         * aarch64-ravenscar-thread.c
2139         (aarch64_ravenscar_generic_prepare_to_store): Remove.
2140         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
2141         (aarch64_ravenscar_fetch_registers)
2142         (aarch64_ravenscar_store_registers): Now methods.
2143         (aarch64_ravenscar_ops): Redefine.
2144
2145 2019-02-15  Tom Tromey  <tromey@adacore.com>
2146
2147         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
2148         (ravenscar_thread_target::stopped_by_hw_breakpoint)
2149         (ravenscar_thread_target::stopped_by_watchpoint)
2150         (ravenscar_thread_target::stopped_data_address)
2151         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
2152
2153 2019-02-15  Tom Tromey  <tromey@adacore.com>
2154
2155         * ravenscar-thread.c: Fix some typos.
2156
2157 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2158             Tom Tromey  <tromey@adacore.com>
2159
2160         * ada-lang.c (ada_exception_sal): Change addr_string to a
2161         std::string.
2162         (create_ada_exception_catchpoint): Update.
2163
2164 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2165             Tom Tromey  <tromey@adacore.com>
2166
2167         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
2168         (bp_location_ops): Remove.
2169         (base_breakpoint_allocate_location): Update.
2170         (free_bp_location): Update.
2171         * ada-lang.c (class ada_catchpoint_location)
2172         <ada_catchpoint_location>: Remove ops parameter.
2173         (ada_catchpoint_location_dtor): Remove.
2174         (ada_catchpoint_location_ops): Remove.
2175         (allocate_location_exception): Update.
2176         * breakpoint.h (struct bp_location_ops): Remove.
2177         (class bp_location) <bp_location>: Remove bp_location_ops
2178         parameter.
2179         <~bp_location>: Add destructor.
2180         <ops>: Remove.
2181
2182 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
2183             Pedro Alves  <palves@redhat.com>
2184
2185         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
2186         'PATH_MAX'.
2187
2188 2019-02-14  David Michael  <fedora.dm0@gmail.com>
2189             Samuel Thibault  <samuel.thibault@gnu.org>
2190             Thomas Schwinge  <thomas@codesourcery.com>
2191
2192         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
2193         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
2194
2195 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
2196
2197         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
2198         (check_empty): Use "const char *".
2199
2200         * gnu-nat.c (gnu_nat_target::detach): Instead of
2201         'detach_inferior (pid)' call
2202         'detach_inferior (find_inferior_pid (pid))'.
2203
2204         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
2205         'nat/fork-inferior.o'.
2206         * gnu-nat.c: #include "nat/fork-inferior.h".
2207
2208         * gnu-nat.c (gnu_nat_target::detach): Instead of
2209         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
2210         * gnu-nat.h: #include "inf-child.h".
2211         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
2212         'i386_gnu_nat_target::fetch_registers'.
2213         (gnu_store_registers): Rename/move to
2214         'i386_gnu_nat_target::store_registers'.
2215
2216         * config/i386/nm-i386gnu.h: Don't "#include" any files.
2217         * gnu-nat.h (mach_thread_info): New function.
2218         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
2219
2220         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
2221
2222 2019-02-14  Frederic Konrad  <konrad@adacore.com>
2223
2224         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
2225
2226 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
2227
2228         * windows-nat.c (windows_add_thread): Add new parameter
2229         "main_thread_p" with default value set to false.  Update
2230         function documentation as well as all callers.
2231         (windows_delete_thread): Likewise.
2232         (fake_create_process): Update call to windows_add_thread.
2233         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
2234         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
2235         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
2236         call to windows_delete_thread.
2237
2238 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
2239
2240         * MAINTAINERS: Add Andrew Burgess as global maintainer.
2241
2242 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2243
2244         * symfile.c (find_separate_debug_file): Use canonical path of
2245         sysroot with child_path instead of gdb_sysroot if it is valid.
2246
2247 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2248
2249         * symfile.c (find_separate_debug_file): Use child_path to
2250         determine if an object file is under a sysroot.
2251
2252 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2253
2254         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
2255         unittests/child-path-selftests.c.
2256         * common/pathstuff.c (child_path): New function.
2257         * common/pathstuff.h (child_path): New prototype.
2258         * unittests/child-path-selftests.c: New file.
2259
2260 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2261
2262         * symfile.c (find_separate_debug_file): Look for separate debug
2263         files in debug directories under the sysroot.
2264
2265 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2266
2267         * symtab.h (struct minimal_symbol data_p): New const method.
2268         (struct minimal_symbol text_p): Likewise.
2269         * symtab.c (output_source_filename): Use file name style
2270         to print file name.
2271         (print_symbol_info): Likewise.
2272         (print_msymbol_info): Use address style to print addresses.
2273         Use function name style to print executable text symbols.
2274         (expand_symtab_containing_pc): Use data_p.
2275         (find_pc_sect_compunit_symtab): Likewise.
2276
2277 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2278
2279         * breakpoint.c (describe_other_breakpoints): Use address style
2280         to print addresses.
2281         (say_where): Likewise.
2282
2283 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2284
2285         * ada-typeprint.c (print_func_type): Print function name
2286         style to print function name.
2287         * c-typeprint.c (c_print_type_1): Likewise.
2288
2289 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
2290
2291         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
2292         for execve.
2293
2294 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2295
2296         * c-exp.y (direct_abs_decl): Use emplace_back to record the
2297         type_stack.
2298
2299 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
2300
2301         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
2302         TYPE_CODE_REF types.
2303
2304 2019-02-08  Jim Wilson  <jimw@sifive.com>
2305
2306         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
2307         (riscv_linux_fregset): New.
2308         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
2309
2310 2019-02-07  Tom Tromey  <tom@tromey.com>
2311
2312         * thread.c (thread_cancel_execution_command): Update.
2313         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
2314         methods.
2315         (struct thread_fsm_ops): Remove.
2316         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
2317         (thread_fsm_should_stop, thread_fsm_return_value)
2318         (thread_fsm_set_finished, thread_fsm_finished_p)
2319         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
2320         Don't declare.
2321         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
2322         * infrun.c (clear_proceed_status_thread)
2323         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
2324         (print_stop_event): Update.
2325         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
2326         Add constructor.
2327         (step_command_fsm_ops): Remove.
2328         (new_step_command_fsm): Remove.
2329         (step_1): Update.
2330         (step_command_fsm::should_stop): Rename from
2331         step_command_fsm_should_stop.
2332         (step_command_fsm::clean_up): Rename from
2333         step_command_fsm_clean_up.
2334         (step_command_fsm::do_async_reply_reason): Rename from
2335         step_command_fsm_async_reply_reason.
2336         (struct until_next_fsm): Inherit from thread_fsm.  Add
2337         constructor.
2338         (until_next_fsm_ops): Remove.
2339         (new_until_next_fsm): Remove.
2340         (until_next_fsm::should_stop): Rename from
2341         until_next_fsm_should_stop.
2342         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
2343         (until_next_fsm::do_async_reply_reason): Rename from
2344         until_next_fsm_async_reply_reason.
2345         (struct finish_command_fsm): Inherit from thread_fsm.  Add
2346         constructor.  Change type of breakpoint.
2347         (finish_command_fsm_ops): Remove.
2348         (new_finish_command_fsm): Remove.
2349         (finish_command_fsm::should_stop): Rename from
2350         finish_command_fsm_should_stop.
2351         (finish_command_fsm::clean_up): Rename from
2352         finish_command_fsm_clean_up.
2353         (finish_command_fsm::return_value): Rename from
2354         finish_command_fsm_return_value.
2355         (finish_command_fsm::do_async_reply_reason): Rename from
2356         finish_command_fsm_async_reply_reason.
2357         (finish_command): Update.
2358         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
2359         Add constructor.
2360         (call_thread_fsm_ops): Remove.
2361         (call_thread_fsm::call_thread_fsm): Rename from
2362         new_call_thread_fsm.
2363         (call_thread_fsm::should_stop): Rename from
2364         call_thread_fsm_should_stop.
2365         (call_thread_fsm::should_notify_stop): Rename from
2366         call_thread_fsm_should_notify_stop.
2367         (run_inferior_call, call_function_by_hand_dummy): Update.
2368         * cli/cli-interp.c (should_print_stop_to_console): Update.
2369         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
2370         Add constructor.  Change type of location_breakpoint,
2371         caller_breakpoint.
2372         (until_break_fsm_ops): Remove.
2373         (new_until_break_fsm): Remove.
2374         (until_break_fsm::should_stop): Rename from
2375         until_break_fsm_should_stop.
2376         (until_break_fsm::clean_up): Rename from
2377         until_break_fsm_clean_up.
2378         (until_break_fsm::do_async_reply_reason): Rename from
2379         until_break_fsm_async_reply_reason.
2380         (until_break_command): Update.
2381         * thread-fsm.c: Remove.
2382         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
2383
2384 2019-02-07  Tom Tromey  <tom@tromey.com>
2385
2386         * yy-remap.h: Add include guard.
2387         * xtensa-tdep.h: Add include guard.
2388         * xcoffread.h: Rename include guard.
2389         * varobj-iter.h: Add include guard.
2390         * tui/tui.h: Rename include guard.
2391         * tui/tui-winsource.h: Rename include guard.
2392         * tui/tui-wingeneral.h: Rename include guard.
2393         * tui/tui-windata.h: Rename include guard.
2394         * tui/tui-win.h: Rename include guard.
2395         * tui/tui-stack.h: Rename include guard.
2396         * tui/tui-source.h: Rename include guard.
2397         * tui/tui-regs.h: Rename include guard.
2398         * tui/tui-out.h: Rename include guard.
2399         * tui/tui-layout.h: Rename include guard.
2400         * tui/tui-io.h: Rename include guard.
2401         * tui/tui-hooks.h: Rename include guard.
2402         * tui/tui-file.h: Rename include guard.
2403         * tui/tui-disasm.h: Rename include guard.
2404         * tui/tui-data.h: Rename include guard.
2405         * tui/tui-command.h: Rename include guard.
2406         * tic6x-tdep.h: Add include guard.
2407         * target/waitstatus.h: Rename include guard.
2408         * target/wait.h: Rename include guard.
2409         * target/target.h: Rename include guard.
2410         * target/resume.h: Rename include guard.
2411         * target-float.h: Rename include guard.
2412         * stabsread.h: Add include guard.
2413         * rs6000-tdep.h: Add include guard.
2414         * riscv-fbsd-tdep.h: Add include guard.
2415         * regformats/regdef.h: Rename include guard.
2416         * record.h: Rename include guard.
2417         * python/python.h: Rename include guard.
2418         * python/python-internal.h: Rename include guard.
2419         * python/py-stopevent.h: Rename include guard.
2420         * python/py-ref.h: Rename include guard.
2421         * python/py-record.h: Rename include guard.
2422         * python/py-record-full.h: Rename include guard.
2423         * python/py-record-btrace.h: Rename include guard.
2424         * python/py-instruction.h: Rename include guard.
2425         * python/py-events.h: Rename include guard.
2426         * python/py-event.h: Rename include guard.
2427         * procfs.h: Add include guard.
2428         * proc-utils.h: Add include guard.
2429         * p-lang.h: Add include guard.
2430         * or1k-tdep.h: Rename include guard.
2431         * observable.h: Rename include guard.
2432         * nto-tdep.h: Rename include guard.
2433         * nat/x86-linux.h: Rename include guard.
2434         * nat/x86-linux-dregs.h: Rename include guard.
2435         * nat/x86-gcc-cpuid.h: Add include guard.
2436         * nat/x86-dregs.h: Rename include guard.
2437         * nat/x86-cpuid.h: Rename include guard.
2438         * nat/ppc-linux.h: Rename include guard.
2439         * nat/mips-linux-watch.h: Rename include guard.
2440         * nat/linux-waitpid.h: Rename include guard.
2441         * nat/linux-ptrace.h: Rename include guard.
2442         * nat/linux-procfs.h: Rename include guard.
2443         * nat/linux-osdata.h: Rename include guard.
2444         * nat/linux-nat.h: Rename include guard.
2445         * nat/linux-namespaces.h: Rename include guard.
2446         * nat/linux-btrace.h: Rename include guard.
2447         * nat/glibc_thread_db.h: Rename include guard.
2448         * nat/gdb_thread_db.h: Rename include guard.
2449         * nat/gdb_ptrace.h: Rename include guard.
2450         * nat/fork-inferior.h: Rename include guard.
2451         * nat/amd64-linux-siginfo.h: Rename include guard.
2452         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
2453         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
2454         * nat/aarch64-linux.h: Rename include guard.
2455         * nat/aarch64-linux-hw-point.h: Rename include guard.
2456         * mn10300-tdep.h: Add include guard.
2457         * mips-linux-tdep.h: Add include guard.
2458         * mi/mi-parse.h: Rename include guard.
2459         * mi/mi-out.h: Rename include guard.
2460         * mi/mi-main.h: Rename include guard.
2461         * mi/mi-interp.h: Rename include guard.
2462         * mi/mi-getopt.h: Rename include guard.
2463         * mi/mi-console.h: Rename include guard.
2464         * mi/mi-common.h: Rename include guard.
2465         * mi/mi-cmds.h: Rename include guard.
2466         * mi/mi-cmd-break.h: Rename include guard.
2467         * m2-lang.h: Add include guard.
2468         * location.h: Rename include guard.
2469         * linux-record.h: Rename include guard.
2470         * linux-nat.h: Add include guard.
2471         * linux-fork.h: Add include guard.
2472         * i386-darwin-tdep.h: Rename include guard.
2473         * hppa-linux-offsets.h: Add include guard.
2474         * guile/guile.h: Rename include guard.
2475         * guile/guile-internal.h: Rename include guard.
2476         * gnu-nat.h: Rename include guard.
2477         * gdb-stabs.h: Rename include guard.
2478         * frv-tdep.h: Add include guard.
2479         * f-lang.h: Add include guard.
2480         * event-loop.h: Add include guard.
2481         * darwin-nat.h: Rename include guard.
2482         * cp-abi.h: Rename include guard.
2483         * config/sparc/nm-sol2.h: Rename include guard.
2484         * config/nm-nto.h: Rename include guard.
2485         * config/nm-linux.h: Add include guard.
2486         * config/i386/nm-i386gnu.h: Rename include guard.
2487         * config/djgpp/nl_types.h: Rename include guard.
2488         * config/djgpp/langinfo.h: Rename include guard.
2489         * compile/gcc-cp-plugin.h: Add include guard.
2490         * compile/gcc-c-plugin.h: Add include guard.
2491         * compile/compile.h: Rename include guard.
2492         * compile/compile-object-run.h: Rename include guard.
2493         * compile/compile-object-load.h: Rename include guard.
2494         * compile/compile-internal.h: Rename include guard.
2495         * compile/compile-cplus.h: Rename include guard.
2496         * compile/compile-c.h: Rename include guard.
2497         * common/xml-utils.h: Rename include guard.
2498         * common/x86-xstate.h: Rename include guard.
2499         * common/version.h: Rename include guard.
2500         * common/vec.h: Rename include guard.
2501         * common/tdesc.h: Rename include guard.
2502         * common/selftest.h: Rename include guard.
2503         * common/scoped_restore.h: Rename include guard.
2504         * common/scoped_mmap.h: Rename include guard.
2505         * common/scoped_fd.h: Rename include guard.
2506         * common/safe-iterator.h: Rename include guard.
2507         * common/run-time-clock.h: Rename include guard.
2508         * common/refcounted-object.h: Rename include guard.
2509         * common/queue.h: Rename include guard.
2510         * common/ptid.h: Rename include guard.
2511         * common/print-utils.h: Rename include guard.
2512         * common/preprocessor.h: Rename include guard.
2513         * common/pathstuff.h: Rename include guard.
2514         * common/observable.h: Rename include guard.
2515         * common/netstuff.h: Rename include guard.
2516         * common/job-control.h: Rename include guard.
2517         * common/host-defs.h: Rename include guard.
2518         * common/gdb_wait.h: Rename include guard.
2519         * common/gdb_vecs.h: Rename include guard.
2520         * common/gdb_unlinker.h: Rename include guard.
2521         * common/gdb_unique_ptr.h: Rename include guard.
2522         * common/gdb_tilde_expand.h: Rename include guard.
2523         * common/gdb_sys_time.h: Rename include guard.
2524         * common/gdb_string_view.h: Rename include guard.
2525         * common/gdb_splay_tree.h: Rename include guard.
2526         * common/gdb_setjmp.h: Rename include guard.
2527         * common/gdb_ref_ptr.h: Rename include guard.
2528         * common/gdb_optional.h: Rename include guard.
2529         * common/gdb_locale.h: Rename include guard.
2530         * common/gdb_assert.h: Rename include guard.
2531         * common/filtered-iterator.h: Rename include guard.
2532         * common/filestuff.h: Rename include guard.
2533         * common/fileio.h: Rename include guard.
2534         * common/environ.h: Rename include guard.
2535         * common/common-utils.h: Rename include guard.
2536         * common/common-types.h: Rename include guard.
2537         * common/common-regcache.h: Rename include guard.
2538         * common/common-inferior.h: Rename include guard.
2539         * common/common-gdbthread.h: Rename include guard.
2540         * common/common-exceptions.h: Rename include guard.
2541         * common/common-defs.h: Rename include guard.
2542         * common/common-debug.h: Rename include guard.
2543         * common/cleanups.h: Rename include guard.
2544         * common/buffer.h: Rename include guard.
2545         * common/btrace-common.h: Rename include guard.
2546         * common/break-common.h: Rename include guard.
2547         * cli/cli-utils.h: Rename include guard.
2548         * cli/cli-style.h: Rename include guard.
2549         * cli/cli-setshow.h: Rename include guard.
2550         * cli/cli-script.h: Rename include guard.
2551         * cli/cli-interp.h: Rename include guard.
2552         * cli/cli-decode.h: Rename include guard.
2553         * cli/cli-cmds.h: Rename include guard.
2554         * charset-list.h: Add include guard.
2555         * buildsym-legacy.h: Rename include guard.
2556         * bfin-tdep.h: Add include guard.
2557         * ax.h: Rename include guard.
2558         * arm-linux-tdep.h: Add include guard.
2559         * arm-fbsd-tdep.h: Add include guard.
2560         * arch/xtensa.h: Rename include guard.
2561         * arch/tic6x.h: Add include guard.
2562         * arch/i386.h: Add include guard.
2563         * arch/arm.h: Rename include guard.
2564         * arch/arm-linux.h: Rename include guard.
2565         * arch/arm-get-next-pcs.h: Rename include guard.
2566         * arch/amd64.h: Add include guard.
2567         * arch/aarch64-insn.h: Rename include guard.
2568         * arch-utils.h: Rename include guard.
2569         * annotate.h: Add include guard.
2570         * amd64-darwin-tdep.h: Rename include guard.
2571         * aarch64-linux-tdep.h: Add include guard.
2572         * aarch64-fbsd-tdep.h: Add include guard.
2573         * aarch32-linux-nat.h: Add include guard.
2574
2575 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2576
2577         * macrotab.c (macro_define_internal): New function that
2578         factorizes macro_define_object_internal and macro_define_function
2579         code.
2580         (macro_define_object_internal): Use macro_define_internal.
2581         (macro_define_function): Likewise.
2582
2583 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2584
2585         * macrocmd.c (extract_identifier): Return
2586         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
2587         callers.
2588
2589 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
2590
2591         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
2592
2593 2019-02-05  Tom Tromey  <tom@tromey.com>
2594
2595         * target.c (target_stack::unpush): Move assertion earlier.
2596
2597 2019-01-30  Tom Tromey  <tom@tromey.com>
2598
2599         PR python/23615:
2600         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
2601         (gdbpy_parse_and_eval): Likewise.
2602         * python/python-internal.h (gdbpy_allow_threads): New class.
2603
2604 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
2605
2606         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
2607         (aarch64_fbsd_fpregmap): Move earlier.
2608         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
2609         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2610         instead of individual calls to trad_frame_set_reg_addr.
2611         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
2612         earlier.
2613         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
2614         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2615         instead of individual calls to trad_frame_set_reg_addr.
2616
2617 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
2618
2619         * CONTRIBUTE: Replace contribution list with wiki link.
2620
2621 2019-01-25  Tom Tromey  <tom@tromey.com>
2622
2623         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
2624
2625 2019-01-25  Tom Tromey  <tom@tromey.com>
2626
2627         * xtensa-linux-nat.c: Fix common/ includes.
2628         * xml-support.h: Fix common/ includes.
2629         * xml-support.c: Fix common/ includes.
2630         * x86-linux-nat.c: Fix common/ includes.
2631         * windows-nat.c: Fix common/ includes.
2632         * varobj.h: Fix common/ includes.
2633         * varobj.c: Fix common/ includes.
2634         * value.c: Fix common/ includes.
2635         * valops.c: Fix common/ includes.
2636         * utils.c: Fix common/ includes.
2637         * unittests/xml-utils-selftests.c: Fix common/ includes.
2638         * unittests/utils-selftests.c: Fix common/ includes.
2639         * unittests/unpack-selftests.c: Fix common/ includes.
2640         * unittests/tracepoint-selftests.c: Fix common/ includes.
2641         * unittests/style-selftests.c: Fix common/ includes.
2642         * unittests/string_view-selftests.c: Fix common/ includes.
2643         * unittests/scoped_restore-selftests.c: Fix common/ includes.
2644         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
2645         * unittests/scoped_fd-selftests.c: Fix common/ includes.
2646         * unittests/rsp-low-selftests.c: Fix common/ includes.
2647         * unittests/parse-connection-spec-selftests.c: Fix common/
2648         includes.
2649         * unittests/optional-selftests.c: Fix common/ includes.
2650         * unittests/offset-type-selftests.c: Fix common/ includes.
2651         * unittests/observable-selftests.c: Fix common/ includes.
2652         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
2653         * unittests/memrange-selftests.c: Fix common/ includes.
2654         * unittests/memory-map-selftests.c: Fix common/ includes.
2655         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
2656         * unittests/function-view-selftests.c: Fix common/ includes.
2657         * unittests/environ-selftests.c: Fix common/ includes.
2658         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
2659         * unittests/common-utils-selftests.c: Fix common/ includes.
2660         * unittests/cli-utils-selftests.c: Fix common/ includes.
2661         * unittests/array-view-selftests.c: Fix common/ includes.
2662         * ui-file.c: Fix common/ includes.
2663         * tui/tui-io.c: Fix common/ includes.
2664         * tracepoint.h: Fix common/ includes.
2665         * tracepoint.c: Fix common/ includes.
2666         * tracefile-tfile.c: Fix common/ includes.
2667         * top.h: Fix common/ includes.
2668         * top.c: Fix common/ includes.
2669         * thread.c: Fix common/ includes.
2670         * target/waitstatus.h: Fix common/ includes.
2671         * target/waitstatus.c: Fix common/ includes.
2672         * target.h: Fix common/ includes.
2673         * target.c: Fix common/ includes.
2674         * target-memory.c: Fix common/ includes.
2675         * target-descriptions.c: Fix common/ includes.
2676         * symtab.h: Fix common/ includes.
2677         * symfile.c: Fix common/ includes.
2678         * stap-probe.c: Fix common/ includes.
2679         * spu-linux-nat.c: Fix common/ includes.
2680         * sparc-nat.c: Fix common/ includes.
2681         * source.c: Fix common/ includes.
2682         * solib.c: Fix common/ includes.
2683         * solib-target.c: Fix common/ includes.
2684         * ser-unix.c: Fix common/ includes.
2685         * ser-tcp.c: Fix common/ includes.
2686         * ser-pipe.c: Fix common/ includes.
2687         * ser-base.c: Fix common/ includes.
2688         * selftest-arch.c: Fix common/ includes.
2689         * s12z-tdep.c: Fix common/ includes.
2690         * rust-exp.y: Fix common/ includes.
2691         * rs6000-aix-tdep.c: Fix common/ includes.
2692         * riscv-tdep.c: Fix common/ includes.
2693         * remote.c: Fix common/ includes.
2694         * remote-notif.h: Fix common/ includes.
2695         * remote-fileio.h: Fix common/ includes.
2696         * remote-fileio.c: Fix common/ includes.
2697         * regcache.h: Fix common/ includes.
2698         * regcache.c: Fix common/ includes.
2699         * record-btrace.c: Fix common/ includes.
2700         * python/python.c: Fix common/ includes.
2701         * python/py-type.c: Fix common/ includes.
2702         * python/py-inferior.c: Fix common/ includes.
2703         * progspace.h: Fix common/ includes.
2704         * producer.c: Fix common/ includes.
2705         * procfs.c: Fix common/ includes.
2706         * proc-api.c: Fix common/ includes.
2707         * printcmd.c: Fix common/ includes.
2708         * ppc-linux-nat.c: Fix common/ includes.
2709         * parser-defs.h: Fix common/ includes.
2710         * osdata.c: Fix common/ includes.
2711         * obsd-nat.c: Fix common/ includes.
2712         * nat/x86-linux.c: Fix common/ includes.
2713         * nat/x86-linux-dregs.c: Fix common/ includes.
2714         * nat/x86-dregs.h: Fix common/ includes.
2715         * nat/x86-dregs.c: Fix common/ includes.
2716         * nat/ppc-linux.c: Fix common/ includes.
2717         * nat/mips-linux-watch.h: Fix common/ includes.
2718         * nat/mips-linux-watch.c: Fix common/ includes.
2719         * nat/linux-waitpid.c: Fix common/ includes.
2720         * nat/linux-ptrace.h: Fix common/ includes.
2721         * nat/linux-ptrace.c: Fix common/ includes.
2722         * nat/linux-procfs.c: Fix common/ includes.
2723         * nat/linux-personality.c: Fix common/ includes.
2724         * nat/linux-osdata.c: Fix common/ includes.
2725         * nat/linux-namespaces.c: Fix common/ includes.
2726         * nat/linux-btrace.h: Fix common/ includes.
2727         * nat/linux-btrace.c: Fix common/ includes.
2728         * nat/fork-inferior.c: Fix common/ includes.
2729         * nat/amd64-linux-siginfo.c: Fix common/ includes.
2730         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
2731         * nat/aarch64-linux.c: Fix common/ includes.
2732         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
2733         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
2734         * namespace.h: Fix common/ includes.
2735         * mips-linux-tdep.c: Fix common/ includes.
2736         * minsyms.c: Fix common/ includes.
2737         * mi/mi-parse.h: Fix common/ includes.
2738         * mi/mi-main.c: Fix common/ includes.
2739         * mi/mi-cmd-env.c: Fix common/ includes.
2740         * memrange.h: Fix common/ includes.
2741         * memattr.c: Fix common/ includes.
2742         * maint.h: Fix common/ includes.
2743         * maint.c: Fix common/ includes.
2744         * main.c: Fix common/ includes.
2745         * machoread.c: Fix common/ includes.
2746         * location.c: Fix common/ includes.
2747         * linux-thread-db.c: Fix common/ includes.
2748         * linux-nat.c: Fix common/ includes.
2749         * linux-fork.c: Fix common/ includes.
2750         * inline-frame.c: Fix common/ includes.
2751         * infrun.c: Fix common/ includes.
2752         * inflow.c: Fix common/ includes.
2753         * inferior.h: Fix common/ includes.
2754         * inferior.c: Fix common/ includes.
2755         * infcmd.c: Fix common/ includes.
2756         * inf-ptrace.c: Fix common/ includes.
2757         * inf-child.c: Fix common/ includes.
2758         * ia64-linux-nat.c: Fix common/ includes.
2759         * i387-tdep.c: Fix common/ includes.
2760         * i386-tdep.c: Fix common/ includes.
2761         * i386-linux-tdep.c: Fix common/ includes.
2762         * i386-linux-nat.c: Fix common/ includes.
2763         * i386-go32-tdep.c: Fix common/ includes.
2764         * i386-fbsd-tdep.c: Fix common/ includes.
2765         * i386-fbsd-nat.c: Fix common/ includes.
2766         * guile/scm-type.c: Fix common/ includes.
2767         * guile/guile.c: Fix common/ includes.
2768         * go32-nat.c: Fix common/ includes.
2769         * gnu-nat.c: Fix common/ includes.
2770         * gdbthread.h: Fix common/ includes.
2771         * gdbarch-selftests.c: Fix common/ includes.
2772         * gdb_usleep.c: Fix common/ includes.
2773         * gdb_select.h: Fix common/ includes.
2774         * gdb_bfd.c: Fix common/ includes.
2775         * gcore.c: Fix common/ includes.
2776         * fork-child.c: Fix common/ includes.
2777         * findvar.c: Fix common/ includes.
2778         * fbsd-nat.c: Fix common/ includes.
2779         * event-top.c: Fix common/ includes.
2780         * event-loop.c: Fix common/ includes.
2781         * dwarf2read.c: Fix common/ includes.
2782         * dwarf2loc.c: Fix common/ includes.
2783         * dwarf2-frame.c: Fix common/ includes.
2784         * dwarf-index-cache.c: Fix common/ includes.
2785         * dtrace-probe.c: Fix common/ includes.
2786         * disasm-selftests.c: Fix common/ includes.
2787         * defs.h: Fix common/ includes.
2788         * csky-tdep.c: Fix common/ includes.
2789         * cp-valprint.c: Fix common/ includes.
2790         * cp-support.h: Fix common/ includes.
2791         * cp-support.c: Fix common/ includes.
2792         * corelow.c: Fix common/ includes.
2793         * completer.h: Fix common/ includes.
2794         * completer.c: Fix common/ includes.
2795         * compile/compile.c: Fix common/ includes.
2796         * compile/compile-loc2c.c: Fix common/ includes.
2797         * compile/compile-cplus-types.c: Fix common/ includes.
2798         * compile/compile-cplus-symbols.c: Fix common/ includes.
2799         * command.h: Fix common/ includes.
2800         * cli/cli-dump.c: Fix common/ includes.
2801         * cli/cli-cmds.c: Fix common/ includes.
2802         * charset.c: Fix common/ includes.
2803         * build-id.c: Fix common/ includes.
2804         * btrace.h: Fix common/ includes.
2805         * btrace.c: Fix common/ includes.
2806         * breakpoint.h: Fix common/ includes.
2807         * breakpoint.c: Fix common/ includes.
2808         * ax.h:
2809         (enum agent_op): Fix common/ includes.
2810         * ax-general.c (struct aop_map): Fix common/ includes.
2811         * ax-gdb.c: Fix common/ includes.
2812         * auxv.c: Fix common/ includes.
2813         * auto-load.c: Fix common/ includes.
2814         * arm-tdep.c: Fix common/ includes.
2815         * arch/riscv.c: Fix common/ includes.
2816         * arch/ppc-linux-common.c: Fix common/ includes.
2817         * arch/i386.c: Fix common/ includes.
2818         * arch/arm.c: Fix common/ includes.
2819         * arch/arm-linux.c: Fix common/ includes.
2820         * arch/arm-get-next-pcs.c: Fix common/ includes.
2821         * arch/amd64.c: Fix common/ includes.
2822         * arch/aarch64.c: Fix common/ includes.
2823         * arch/aarch64-insn.c: Fix common/ includes.
2824         * arch-utils.c: Fix common/ includes.
2825         * amd64-windows-tdep.c: Fix common/ includes.
2826         * amd64-tdep.c: Fix common/ includes.
2827         * amd64-sol2-tdep.c: Fix common/ includes.
2828         * amd64-obsd-tdep.c: Fix common/ includes.
2829         * amd64-nbsd-tdep.c: Fix common/ includes.
2830         * amd64-linux-tdep.c: Fix common/ includes.
2831         * amd64-linux-nat.c: Fix common/ includes.
2832         * amd64-fbsd-tdep.c: Fix common/ includes.
2833         * amd64-fbsd-nat.c: Fix common/ includes.
2834         * amd64-dicos-tdep.c: Fix common/ includes.
2835         * amd64-darwin-tdep.c: Fix common/ includes.
2836         * agent.c: Fix common/ includes.
2837         * ada-lang.h: Fix common/ includes.
2838         * ada-lang.c: Fix common/ includes.
2839         * aarch64-tdep.c: Fix common/ includes.
2840
2841 2019-01-25  Tom Tromey  <tom@tromey.com>
2842
2843         * common/create-version.sh: Use common/version.h.
2844
2845 2019-01-24  Pedro Alves  <palves@redhat.com>
2846
2847         * infrun.c (signal_stop, signal_print, signal_program)
2848         (signal_catch, signal_pass): Now arrays instead of pointers.
2849         (update_signals_program_target, do_target_resume)
2850         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2851         * linux-nat.c (linux_nat_target::pass_signals)
2852         (linux_nat_target::create_inferior, linux_nat_target::attach):
2853         Adjust.
2854         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2855         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2856         * procfs.c (procfs_target::pass_signals): Adjust.
2857         * record-full.c (record_full_target::resume): Adjust.
2858         * remote.c (remote_target::pass_signals)
2859         (remote_target::program_signals): Adjust.
2860         * target-debug.h (target_debug_print_signals): Now takes a
2861         gdb::array_view as parameter.  Adjust.
2862         * target.h (target_ops) <pass_signals, program_signals>: Replace
2863         pointer and length parameters with gdb::array_view.
2864         (target_pass_signals, target_program_signals): Likewise.
2865         * target-delegates.c: Regenerate.
2866
2867 2019-01-24  Pedro Alves  <palves@redhat.com>
2868
2869         * common/forward-scope-exit.h
2870         (forward_scope_exit::forward_scope_exit): Pass arguments to
2871         m_bind_function directly, instead of creating a std::bind and
2872         copying that.
2873
2874 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
2875
2876         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2877         for static members.
2878         (pass_in_v_vfp_candidate): Likewise.
2879
2880 2019-01-23  Tom Tromey  <tom@tromey.com>
2881             Pedro Alves  <palves@redhat.com>
2882
2883         * regcache.c (class regcache_invalidator): Remove.
2884         (regcache::raw_write): Use make_scope_exit.
2885
2886 2019-01-23  Tom Tromey  <tom@tromey.com>
2887
2888         * ui-out.h (class ui_out_emit_type): Update comment.
2889
2890 2019-01-23  Tom Tromey  <tom@tromey.com>
2891
2892         * infrun.c (fetch_inferior_event): Update comment.
2893
2894 2019-01-23  Tom Tromey  <tom@tromey.com>
2895             Pedro Alves  <palves@redhat.com>
2896
2897         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
2898         parameter.
2899         (fetch_inferior_event): Use SCOPE_EXIT.
2900
2901
2902 2019-01-23  Tom Tromey  <tom@tromey.com>
2903             Pedro Alves  <palves@redhat.com>
2904
2905         * infrun.c (disable_thread_events): Delete.
2906         (stop_all_threads): Use SCOPE_EXIT.
2907
2908 2019-01-23  Tom Tromey  <tom@tromey.com>
2909             Pedro Alves  <palves@redhat.com>
2910
2911         * symfile.c: Include forward-scope-exit.h.
2912         (clear_symtab_users_cleanup): Replace forward declaration with
2913         a FORWARD_SCOPE_EXIT.
2914         (syms_from_objfile_1): Use the forward_scope_exit and
2915         gdb::optional instead of cleanup_function.
2916         (reread_symbols): Use the forward_scope_exit instead of
2917         cleanup_function.
2918         (clear_symtab_users_cleanup): Remove function.
2919
2920 2019-01-23  Tom Tromey  <tom@tromey.com>
2921             Pedro Alves  <palves@redhat.com>
2922
2923         * linux-nat.c: Include scope-exit.h.
2924         (cleanup_target_stop): Remove.
2925         (linux_nat_target::static_tracepoint_markers_by_strid): Use
2926         SCOPE_EXIT.
2927
2928 2019-01-23  Tom Tromey  <tom@tromey.com>
2929             Pedro Alves  <palves@redhat.com>
2930
2931         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
2932         (call_function_by_hand_dummy): Use SCOPE_EXIT.
2933
2934 2019-01-23  Tom Tromey  <tom@tromey.com>
2935             Andrew Burgess  <andrew.burgess@embecosm.com>
2936             Pedro Alves  <palves@redhat.com>
2937
2938         * infrun.c (fetch_inferior_event): Use scope_exit.
2939         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
2940         * top.c (execute_command): Use scope_exit.
2941         * breakpoint.c (bpstat_do_actions): Use scope_exit.
2942         * utils.c (do_bpstat_clear_actions_cleanup)
2943         (make_bpstat_clear_actions_cleanup): Remove.
2944
2945 2019-01-23  Tom Tromey  <tom@tromey.com>
2946             Pedro Alves  <palves@redhat.com>
2947
2948         * infrun.c: Include "common/scope-exit.h"
2949         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
2950         (wait_for_inferior): Use SCOPE_EXIT.
2951         (fetch_inferior_event): Use scope_exit.
2952
2953 2019-01-23  Tom Tromey  <tom@tromey.com>
2954             Pedro Alves  <palves@redhat.com>
2955
2956         * breakpoint.c (create_breakpoint): Remove cleanup.
2957
2958 2019-01-23  Tom Tromey  <tom@tromey.com>
2959             Andrew Burgess  <andrew.burgess@embecosm.com>
2960             Pedro Alves  <palves@redhat.com>
2961
2962 2019-01-23  Pedro Alves  <palves@redhat.com>
2963
2964         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
2965
2966 2019-01-23  Pedro Alves  <palves@redhat.com>
2967             Andrew Burgess  <andrew.burgess@embecosm.com>
2968
2969         * gdbthread.h: Include "common/forward-scope-exit.h".
2970         (scoped_finish_thread_state): Redefine custom class in terms of
2971         forward_scope_exit.
2972
2973 2019-01-23  Pedro Alves  <palves@redhat.com>
2974             Andrew Burgess  <andrew.burgess@embecosm.com>
2975
2976         * common/forward-scope-exit.h: New file.
2977
2978 2019-01-23  Pedro Alves  <palves@redhat.com>
2979             Andrew Burgess  <andrew.burgess@embecosm.com>
2980             Tom Tromey  <tom@tromey.com>
2981
2982         * common/scope-exit.h: New file.
2983
2984 2019-01-23  Pedro Alves  <palves@redhat.com>
2985
2986         * common/preprocessor.h (ESC): Rename to ...
2987         (ESC_PARENS): ... this.
2988         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
2989         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
2990
2991 2019-01-23  Tom Tromey  <tom@tromey.com>
2992
2993         * language.h (class scoped_switch_to_sym_language_if_auto):
2994         Initialize m_lang in both cases.
2995
2996 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
2997
2998         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
2999         with XCNEW.
3000
3001 2019-01-22  Tom Tromey  <tom@tromey.com>
3002
3003         * corelow.c: Do not include sys/file.h.
3004
3005 2019-01-22  Tom Tromey  <tom@tromey.com>
3006
3007         * tui/tui-wingeneral.h: Include gdb_curses.h.
3008
3009 2019-01-22  Tom Tromey  <tom@tromey.com>
3010
3011         * source-cache.h (class source_cache) <get_source_lines,
3012         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
3013
3014 2019-01-22  Tom Tromey  <tom@tromey.com>
3015
3016         * remote-fileio.h (struct remote_target): Declare.
3017
3018 2019-01-22  Tom Tromey  <tom@tromey.com>
3019
3020         * python/py-arch.c: Do not include py-ref.h.
3021         * python/py-bpevent.c: Do not include py-ref.h.
3022         * python/py-cmd.c: Do not include py-ref.h.
3023         * python/py-continueevent.c: Do not include py-ref.h.
3024         * python/py-event.h: Do not include py-ref.h.
3025         * python/py-evtregistry.c: Do not include py-ref.h.
3026         * python/py-finishbreakpoint.c: Do not include py-ref.h.
3027         * python/py-frame.c: Do not include py-ref.h.
3028         * python/py-framefilter.c: Do not include py-ref.h.
3029         * python/py-function.c: Do not include py-ref.h.
3030         * python/py-infevents.c: Do not include py-ref.h.
3031         * python/py-linetable.c: Do not include py-ref.h.
3032         * python/py-objfile.c: Do not include py-ref.h.
3033         * python/py-param.c: Do not include py-ref.h.
3034         * python/py-prettyprint.c: Do not include py-ref.h.
3035         * python/py-progspace.c: Do not include py-ref.h.
3036         * python/py-symbol.c: Do not include py-ref.h.
3037         * python/py-symtab.c: Do not include py-ref.h.
3038         * python/py-type.c: Do not include py-ref.h.
3039         * python/py-unwind.c: Do not include py-ref.h.
3040         * python/py-utils.c: Do not include py-ref.h.
3041         * python/py-value.c: Do not include py-ref.h.
3042         * python/py-varobj.c: Do not include py-ref.h.
3043         * python/py-xmethods.c: Do not include py-ref.h.
3044         * python/python.c: Do not include py-ref.h.
3045         * varobj.c: Do not include py-ref.h.
3046
3047 2019-01-22  Tom Tromey  <tom@tromey.com>
3048
3049         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
3050         keyword for bcache.
3051
3052 2019-01-22  Tom Tromey  <tom@tromey.com>
3053
3054         * compile/compile-cplus-types.c: Remove a comment by #include.
3055
3056 2019-01-22  Tom Tromey  <tom@tromey.com>
3057
3058         * compile/gcc-c-plugin.h: Include compile-internal.h.
3059
3060 2019-01-22  Tom Tromey  <tom@tromey.com>
3061
3062         * stabsread.c (EXTERN): Do not define.
3063         (symnum, next_symbol_text_func, processing_gcc_compilation)
3064         (within_function, global_sym_chain, global_stabs)
3065         (previous_stab_code, this_object_header_files)
3066         (n_this_object_header_files)
3067         (n_allocated_this_object_header_files): Define.
3068         * stabsread.h (EXTERN): Never define.  Use "extern".
3069
3070 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3071
3072         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
3073         history_value.
3074
3075 2019-01-21  Tom Tromey  <tom@tromey.com>
3076
3077         * ui-out.c: Fix includes.
3078         * tui/tui-source.c: Fix includes.
3079         * target.c: Fix includes.
3080         * remote.c: Fix includes.
3081         * regcache.c: Fix includes.
3082         * python/py-block.c: Fix includes.
3083         * printcmd.c: Fix includes.
3084         * or1k-tdep.c: Fix includes.
3085         * mi/mi-main.c: Fix includes.
3086         * m32r-tdep.c: Fix includes.
3087         * csky-tdep.c: Fix includes.
3088         * compile/compile-cplus-types.c: Fix includes.
3089         * cli/cli-interp.c: Fix includes.
3090
3091 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
3092
3093         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
3094         for padding.
3095
3096 2019-01-16  Tom Tromey  <tom@tromey.com>
3097
3098         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
3099         earlier.
3100         (struct objfile) <msymbols_range>: Move from top level.
3101         <msymbols>: New method.
3102         (class objfile_msymbols): Remove.
3103         * symtab.c (default_collect_symbol_completion_matches_break_on):
3104         Update.
3105         * symmisc.c (dump_msymbols): Update.
3106         * stabsread.c (scan_file_globals): Update.
3107         * objc-lang.c (info_selectors_command, info_classes_command)
3108         (find_methods): Update.
3109         * minsyms.c (find_solib_trampoline_target): Update.
3110         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
3111         * coffread.c (coff_symfile_read): Update.
3112         * ada-lang.c (ada_lookup_simple_minsym)
3113         (ada_collect_symbol_completion_matches): Update.
3114
3115 2019-01-16  Tom Tromey  <tom@tromey.com>
3116
3117         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
3118         type.  Remove no-argument constructor.
3119         <iterator::operator++>: Simplify.
3120         <begin>: Update.
3121         <end>: Use minimal_symbol_count.
3122
3123 2019-01-16  Tom Tromey  <tom@tromey.com>
3124
3125         * objfiles.h (struct objfile) <psymtabs>: New method.
3126         (class objfile_psymtabs): Remove.
3127         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
3128         typedef.
3129         <range>: New method.
3130         (require_partial_symbols): Change return type.
3131         * psymtab.c (require_partial_symbols)
3132         (psym_expand_symtabs_matching): Update.
3133         * mdebugread.c (parse_partial_symbols): Update.
3134         * dbxread.c (dbx_end_psymtab): Update.
3135
3136 2019-01-15  Tom Tromey  <tom@tromey.com>
3137
3138         * symtab.c (lookup_objfile_from_block)
3139         (lookup_symbol_in_objfile_symtabs)
3140         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
3141         (find_line_symtab, info_sources_command)
3142         (default_collect_symbol_completion_matches_break_on)
3143         (make_source_files_completion_list): Update.
3144         * symmisc.c (print_objfile_statistics, dump_objfile)
3145         (maintenance_print_symbols, maintenance_info_symtabs)
3146         (maintenance_check_symtabs, maintenance_info_line_tables):
3147         Update.
3148         * source.c (select_source_symtab)
3149         (forget_cached_source_info_for_objfile): Update.
3150         * objfiles.h (class objfile_compunits): Remove.
3151         (struct objfile) <compunits_range>: New typedef.
3152         (compunits): New method.
3153         * objfiles.c (objfile_relocate1): Update.
3154         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
3155         * maint.c (count_symtabs_and_blocks): Update.
3156         * linespec.c (iterate_over_all_matching_symtabs): Update.
3157         * cp-support.c (add_symbol_overload_list_qualified): Update.
3158         * coffread.c (coff_symtab_read): Update.
3159         * ada-lang.c (add_nonlocal_symbols)
3160         (ada_collect_symbol_completion_matches)
3161         (ada_add_global_exceptions): Update.
3162
3163 2019-01-15  Tom Tromey  <tom@tromey.com>
3164
3165         * progspace.h (program_space) <objfiles_safe_range>: New
3166         typedef.
3167         <objfiles_safe>: New method.
3168         * objfiles.h (class all_objfiles_safe): Remove.
3169         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
3170         * jit.c (jit_inferior_exit_hook): Update.
3171
3172 2019-01-17  Tom Tromey  <tom@tromey.com>
3173
3174         * progspace.h (program_space) <objfiles_range>: New typedef.
3175         <objfiles>: New method.
3176         <objfiles_head>: Rename from objfiles.
3177         (object_files): Update.
3178         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
3179         * guile/scm-pretty-print.c
3180         (ppscm_find_pretty_printer_from_objfiles): Update.
3181         * guile/scm-objfile.c (gdbscm_objfiles): Update.
3182         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
3183         Update.
3184         * python/py-progspace.c (pspy_get_objfiles): Update.
3185         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3186         Update.
3187         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3188         (objfpy_lookup_objfile_by_build_id): Update.
3189         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
3190         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3191         Update.
3192         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3193         (expand_symtab_containing_pc, lookup_objfile_from_block)
3194         (lookup_static_symbol, basic_lookup_transparent_type)
3195         (find_pc_sect_compunit_symtab, find_symbol_at_address)
3196         (find_line_symtab, info_sources_command)
3197         (default_collect_symbol_completion_matches_break_on)
3198         (make_source_files_completion_list, find_main_name): Update.
3199         * symmisc.c (print_symbol_bcache_statistics)
3200         (print_objfile_statistics, maintenance_print_symbols)
3201         (maintenance_print_msymbols, maintenance_print_objfiles)
3202         (maintenance_info_symtabs, maintenance_check_symtabs)
3203         (maintenance_expand_symtabs, maintenance_info_line_tables):
3204         Update.
3205         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
3206         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
3207         (map_overlay_command, unmap_overlay_command)
3208         (simple_overlay_update, expand_symtabs_matching)
3209         (map_symbol_filenames): Update.
3210         * symfile-debug.c (set_debug_symfile): Update.
3211         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
3212         Update.
3213         * source.c (select_source_symtab, forget_cached_source_info):
3214         Update.
3215         * solib.c (solib_read_symbols): Update.
3216         * solib-spu.c (append_ocl_sos): Update.
3217         * psymtab.c (maintenance_print_psymbols)
3218         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
3219         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
3220         * printcmd.c (info_symbol_command): Update.
3221         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
3222         Update.
3223         * objfiles.h (class all_objfiles): Remove.
3224         * objfiles.c (have_partial_symbols, have_full_symbols)
3225         (have_minimal_symbols, qsort_cmp, update_section_map)
3226         (shared_objfile_contains_address_p)
3227         (default_iterate_over_objfiles_in_search_order): Update.
3228         * objc-lang.c (info_selectors_command, info_classes_command)
3229         (find_methods): Update.
3230         * minsyms.c (find_solib_trampoline_target): Update.
3231         * maint.c (maintenance_info_sections)
3232         (maintenance_translate_address, count_symtabs_and_blocks):
3233         Update.
3234         * main.c (captured_main_1): Update.
3235         * linux-thread-db.c (try_thread_db_load_from_pdir)
3236         (has_libpthread): Update.
3237         * linespec.c (iterate_over_all_matching_symtabs)
3238         (search_minsyms_for_name): Update.
3239         * jit.c (jit_find_objf_with_entry_addr): Update.
3240         * hppa-tdep.c (find_unwind_entry)
3241         (hppa_lookup_stub_minimal_symbol): Update.
3242         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
3243         Update.
3244         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3245         (elf_gnu_ifunc_resolve_by_got): Update.
3246         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
3247         * dwarf-index-write.c (save_gdb_index_command): Update.
3248         * cp-support.c (add_symbol_overload_list_qualified): Update.
3249         * breakpoint.c (create_overlay_event_breakpoint)
3250         (create_longjmp_master_breakpoint)
3251         (create_std_terminate_master_breakpoint)
3252         (create_exception_master_breakpoint): Update.
3253         * blockframe.c (find_pc_partial_function): Update.
3254         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
3255         (ada_collect_symbol_completion_matches)
3256         (ada_add_global_exceptions): Update.
3257
3258 2019-01-17  Tom Tromey  <tom@tromey.com>
3259
3260         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
3261         declare VEC.
3262         (solib_target_parse_libraries): Change return type.
3263         (library_list_start_segment, library_list_start_section)
3264         (library_list_end_library, library_list_start_library); Update.
3265         (solib_target_free_library_list): Remove.
3266         (solib_target_parse_libraries): Remove cleanup.  Change return
3267         type.
3268         (solib_target_current_sos): Update.
3269
3270 2019-01-17  Tom Tromey  <tromey@bapiya>
3271
3272         * valprint.c: Replace "the the" with "the".
3273         * symtab.c: Replace "the the" with "the".
3274         * solib.c: Replace "the the" with "the".
3275         * solib-dsbt.c: Replace "the the" with "the".
3276         * linespec.c: Replace "the the" with "the".
3277         * dwarf2loc.h: Replace "the the" with "the".
3278         * amd64-windows-tdep.c: Replace "the the" with "the".
3279         * aarch64-tdep.c: Replace "the the" with "the".
3280
3281 2019-01-16  Keith Seitz  <keiths@redhat.com>
3282
3283         PR gdb/23773
3284         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
3285         <builder>: Rename to ..
3286         <m_builder>: ... this and make private.
3287         (dwarf2_cu::get_builder): New method.  Change all users of
3288         `builder' to use this method.
3289         (dwarf2_start_symtab): Move to ...
3290         (dwarf2_cu::start_symtab): ... here.  Update all callers
3291         (setup_type_unit_groups): Move to ...
3292         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
3293         callers.
3294         (dwarf2_cu::reset_builder): New method.
3295         (process_full_compunit, process_full_type_unit): Use
3296         dwarf2_cu::reset_builder.
3297         (follow_die_offset): Record the ancestor CU if it is different
3298         from the followed DIE's CU.
3299         (follow_die_sig_1): Likewise.
3300
3301 2019-01-15  Tom Tromey  <tom@tromey.com>
3302
3303         * remote.c (class remote_state) <buf>: Now a char_vector.
3304         <buf_size>: Remove.
3305         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
3306         parameter.
3307         (remote_target::getpkt_or_notif_sane_1)
3308         (remote_target::getpkt_sane)
3309         (remote_target::getpkt_or_notif_sane): Likewise.
3310         (class remote_target) <putpkt>: New overload.
3311         (remote_target::read_frame): Change type of "buf_p".  Remove
3312         sizeof_p parameter.
3313         (packet_ok): New overload.
3314         (packet_check_result): New overload.
3315         Update all uses.
3316
3317 2019-01-14  Tom Tromey  <tom@tromey.com>
3318
3319         * remote-notif.c (handle_notification, remote_notif_ack)
3320         (remote_notif_parse): Make "buf" const.
3321         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
3322         const.
3323         (remote_notif_parse, remote_notif_ack, handle_notification):
3324         Likewise.
3325         * remote.c (remote_notif_stop_parse): Make "buf" const.
3326         (remote_target::remote_parse_stop_reply): Make "buf" const.
3327         (remote_notif_stop_ack): Make "buf" const.
3328
3329 2019-01-14  Tom Tromey  <tom@tromey.com>
3330
3331         * remote.c (remote_console_output): Make parameter const.
3332
3333 2019-01-14  Tom Tromey  <tom@tromey.com>
3334
3335         * target-debug.h (target_debug_print_signals): Constify.
3336         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
3337         * procfs.c (procfs_target::pass_signals): Update.
3338         * linux-nat.c (linux_nat_target::pass_signals): Update.
3339         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
3340         * target-delegates.c: Rebuild.
3341         * remote.c (remote_target::program_signals): Update.
3342         (remote_target::pass_signals): Update.
3343         * target.c (target_pass_signals): Constify argument.
3344         (target_program_signals): Likewise.
3345         * target.h (struct target_ops) <pass_signals, program_signals>:
3346         Constify argument.
3347         (target_pass_signals, target_program_signals): Constify argument.
3348
3349 2019-01-14  Tom Tromey  <tom@tromey.com>
3350
3351         PR tui/28819:
3352         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
3353
3354 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3355
3356         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
3357         field.
3358         * rs6000-tdep.c: Include reggroups.h.
3359         (IS_V_ALIAS_PSEUDOREG): Define.
3360         (rs6000_register_name): Return names for the "vX" aliases.
3361         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
3362         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
3363         aliases.  Call default_register_reggroup_p for all other
3364         pseudo-registers.
3365         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
3366         New functions.
3367         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
3368         Handle "vX" aliases.
3369         (v_alias_pseudo_register_collect): New function.
3370         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
3371         (rs6000_gdbarch_init): Initialize "vX" aliases as
3372         pseudo-registers.  Restore registration of
3373         rs6000_pseudo_register_reggroup_p with
3374         set_tdesc_pseudo_register_reggroup_p.
3375
3376 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
3377
3378         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
3379         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
3380         set_gdbarch_num_pseudo_regs.
3381
3382 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3383
3384         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
3385         Remove arg prefixname, add do_set and do_show.
3386         Add member functions set_list and show_list.
3387         * cli/cli-style.c (class cli_style_option): Update accordingly.
3388         (style_set_list): Move to file scope.
3389         (style_show_list): Likewise.
3390         (set_style): Call help_list.
3391         (show_style): Call cmd_show_list.
3392         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
3393         Update to use the new macro.
3394
3395 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
3396
3397         * ada-lang.c (_initialize_ada_language): Expand the help text
3398         for the "catch exception" command.
3399
3400 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3401
3402         * symtab.c (matching_obj_sections): Initialize obj,
3403         declare it closer to its usage.
3404
3405 2019-01-10  Tom Tromey  <tom@tromey.com>
3406
3407         * thread-iter.h (inf_threads_iterator): Use next_iterator.
3408         (basic_inf_threads_range): Remove.
3409         (inf_threads_range, inf_non_exited_threads_range)
3410         (safe_inf_threads_range): Use next_adapter.
3411
3412 2019-01-10  Keith Seitz  <keiths@redhat.com>
3413
3414         PR gdb/23712
3415         PR symtab/23010
3416         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
3417         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
3418
3419 2019-01-10  Keith Seitz  <keiths@redhat.com>
3420
3421         PR gdb/23712
3422         PR symtab/23010
3423         * dictionary.c (pending_to_vector): Remove.
3424         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3425         Remove _1 suffix, replacing functions of the same name.  Update
3426         all callers.
3427         (dict_create_hashed, dict_create_hashed_expandable)
3428         (dict_create_linear, dict_create_linear_expandable, dict_free)
3429         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
3430         Make functions static.
3431
3432 2019-01-10  Keith Seitz  <keiths@redhat.com>
3433
3434         PR gdb/23712
3435         PR symtab/23010
3436         * dictionary.h (struct dictionary): Replace declaration with
3437         multidictionary.
3438         (dict_create_hashed, dict_create_hashed_expandable)
3439         (dict_create_linear, dict_create_linear_expandable)
3440         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
3441         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
3442         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
3443         taking multidictionary argument.
3444         [ALL_DICT_SYMBOLS]: Update for multidictionary.
3445         * block.h (struct block) <dict>: Change to multidictionary
3446         and rename `multidict'.
3447         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
3448         symmisc.c: Update all dictionary references to multidictionary.
3449
3450 2019-01-10  Keith Seitz  <keiths@redhat.com>
3451
3452         PR gdb/23712
3453         PR symtab/23010
3454         * dictionary.c: Include unordered_map.
3455         (pending_to_vector): New function.
3456         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3457         Rewrite the non-"_1" functions to take vector instead
3458         of linked list.
3459         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
3460         "new" _1 versions of the same name.
3461         (multidictionary): Define.
3462         (std::hash<enum language): New definition.
3463         (collate_pending_symbols_by_language, mdict_create_hashed)
3464         (mdict_create_hashed_expandable, mdict_create_linear)
3465         (mdict_create_linear_expandable, mdict_free)
3466         (find_language_dictionary, create_new_language_dictionary)
3467         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
3468         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
3469         (mdict_size, mdict_empty): New functions.
3470         * dictionary.h (mdict_iterator): Define.
3471
3472 2019-01-10  Pedro Alves  <palves@redhat.com>
3473
3474         * breakpoint.c (read_uploaded_action)
3475         (create_tracepoint_from_upload): Adjust to use
3476         gdb::unique_xmalloc_ptr.
3477         * ctf.c (ctf_write_uploaded_tp):
3478         (SET_ARRAY_FIELD): Use emplace_back.
3479         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
3480         * tracefile-tfile.c (tfile_write_uploaded_tp):
3481         * tracepoint.c (parse_tracepoint_definition): Adjust to use
3482         gdb::unique_xmalloc_ptr.
3483         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
3484         at_string, cond_string, cmd_strings>: Replace char pointers
3485         with gdb::unique_xmalloc_ptr.
3486
3487 2019-01-10  Pedro Alves  <palves@redhat.com>
3488
3489         * solib-target.c (library_list_start_library): Don't xstrdup name.
3490
3491 2019-01-10  Pedro Alves  <palves@redhat.com>
3492
3493         * mdebugread.c (parse_partial_symbols): Use
3494         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
3495
3496 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3497
3498         * linux-fork.c (scoped_switch_fork_info)
3499         <~scoped_switch_fork_info>: Fix incorrect variable name.
3500
3501 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3502
3503         * linux-fork.c (scoped_switch_fork_info)
3504         <scoped_switch_fork_info>: Make explicit.
3505         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
3506
3507 2019-01-10  Tom Tromey  <tom@tromey.com>
3508
3509         * objfiles.h (objfile::reset_psymtabs): Update.
3510         * objfiles.c (objfile::objfile): Update.
3511         * psymtab.h (psymtab_storage::obstack): Update.
3512         (psymtab_storage::m_obstack): Use gdb::optional.
3513         (class psymtab_storage): Update comment.  Remove objfile
3514         parameter.
3515         * psymtab.c (psymtab_storage::psymtab_storage): Update.
3516
3517 2019-01-10  Tom Tromey  <tom@tromey.com>
3518
3519         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
3520         <free_psymtabs>: Now private.
3521         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
3522         (allocate_psymtab): Use new method.
3523
3524 2019-01-10  Tom Tromey  <tom@tromey.com>
3525
3526         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
3527         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
3528         * mdebugread.c (parse_partial_symbols): Use
3529         allocate_dependencies.
3530         * dwarf2read.c (dwarf2_create_include_psymtab): Use
3531         allocate_dependencies.
3532         (process_psymtab_comp_unit_reader)
3533         (build_type_psymtab_dependencies): Likewise.
3534         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
3535
3536 2019-01-10  Tom Tromey  <tom@tromey.com>
3537
3538         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
3539         PSYMBOL_SET_LANGUAGE.
3540         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
3541
3542 2019-01-10  Tom Tromey  <tom@tromey.com>
3543
3544         * psymtab.h (psymtab_storage::obstack): New method.
3545         <m_obstack>: Rename from obstack; now private.
3546         * psymtab.c (psymtab_storage): Update.
3547         * dwarf2read.c (create_addrmap_from_index)
3548         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
3549         Update.
3550
3551 2019-01-10  Tom Tromey  <tom@tromey.com>
3552
3553         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
3554         * objfiles.h (objfile::reset_psymtabs): New method.
3555
3556 2019-01-10  Tom Tromey  <tom@tromey.com>
3557
3558         * symmisc.c (print_symbol_bcache_statistics): Update.
3559         (print_objfile_statistics): Update.
3560         * symfile.c (reread_symbols): Update.
3561         * psymtab.h (class psymtab_storage): New.
3562         * psymtab.c (psymtab_storage): New constructor.
3563         (~psymtab_storage): New destructor.
3564         (require_partial_symbols): Update.
3565         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
3566         (find_pc_sect_psymtab, find_pc_sect_psymbol)
3567         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
3568         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
3569         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
3570         (start_psymtab_common, end_psymtab_common)
3571         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
3572         (allocate_psymtab): Update.
3573         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
3574         Update.
3575         (dump_psymtab_addrmap, maintenance_print_psymbols)
3576         (maintenance_check_psymtabs): Update.
3577         (class objfile_psymtabs): Move to objfiles.h.
3578         * psympriv.h (discard_psymtab): Now inline.
3579         (psymtab_discarder::psymtab_discarder): Update.
3580         (psymtab_discarder::~psymtab_discarder): Update.
3581         (ALL_OBJFILE_PSYMTABS): Rewrite.
3582         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
3583         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
3584         Remove fields.
3585         <partial_symtabs>: New field.
3586         (class objfile_psymtabs): Move from psymtab.h.  Update.
3587         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
3588         psymbol_cache.
3589         (objfile::~objfile): Don't destroy psymbol_cache.
3590         * mdebugread.c (parse_partial_symbols): Update.
3591         * dwarf2read.c (create_addrmap_from_index)
3592         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
3593         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
3594         (add_partial_subprogram, dwarf2_ranges_read): Update.
3595         * dwarf-index-write.c (write_address_map)
3596         (write_one_signatured_type, recursively_write_psymbols)
3597         (class debug_names, class debug_names, write_psymtabs_to_index):
3598         Update.
3599
3600 2019-01-10  Tom Tromey  <tom@tromey.com>
3601
3602         * symtab.h (SYMBOL_SET_NAMES): Update.
3603         (symbol_set_names): Update.
3604         (MSYMBOL_SET_NAMES): Update.
3605         * symtab.c (symbol_set_names): Change argument to be an
3606         objfile_per_bfd_storage.
3607         * psymtab.c (add_psymbol_to_bcache): Update.
3608         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
3609
3610 2019-01-10  Tom Tromey  <tom@tromey.com>
3611
3612         * symtab.c (create_demangled_names_hash): Change argument to be an
3613         objfile_per_bfd_storage.
3614         (symbol_set_names): Update.
3615
3616 2019-01-10  Tom Tromey  <tom@tromey.com>
3617
3618         * xcoffread.c (xcoff_initial_scan): Unconditionally call
3619         init_psymbol_list.
3620         * psymtab.c (init_psymbol_list): Do nothing if already called.
3621         * psympriv.h (init_psymbol_list): Add comment.
3622         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
3623         init_psymbol_list.
3624         * dbxread.c (dbx_symfile_read): Unconditionally call
3625         init_psymbol_list.
3626
3627 2019-01-10  Tom Tromey  <tom@tromey.com>
3628
3629         * xcoffread.c (scan_xcoff_symtab): Update.
3630         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
3631         "where".
3632         * mdebugread.c (parse_partial_symbols)
3633         (handle_psymbol_enumerators): Update.
3634         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
3635         * dbxread.c (read_dbx_symtab): Update.
3636         * psympriv.h (psymbol_placement): New enum.
3637         (add_psymbol_to_list): Update.
3638
3639 2019-01-10  Tom Tromey  <tom@tromey.com>
3640
3641         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
3642         static_psymbols parameters.
3643         (scan_xcoff_symtab): Update.
3644         * psymtab.c (start_psymtab_common): Remove global_psymbols and
3645         static_psymbols parameters.
3646         * psympriv.h (start_psymtab_common): Update.
3647         * mdebugread.c (parse_partial_symbols): Update.
3648         * dwarf2read.c (create_partial_symtab): Update.
3649         * dbxread.c (read_dbx_symtab): Update.
3650         (start_psymtab): Remove global_psymbols and static_psymbols
3651         parameters.
3652
3653 2019-01-10  Tom Tromey  <tom@tromey.com>
3654
3655         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
3656         * psymtab.c (allocate_psymtab): Add comment.
3657         * psympriv.h (allocate_psymtab): Add comment.
3658         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
3659         initializations.
3660         * dbxread.c (dbx_end_psymtab): Remove some initializations.
3661
3662 2019-01-10  Tom Tromey  <tom@tromey.com>
3663
3664         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3665         Don't declare.
3666         * mipsread.c: Include mdebugread.h.
3667         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3668         Declare.
3669         * elfread.c: Include mdebugread.h.
3670
3671 2019-01-09  Tom Tromey  <tom@tromey.com>
3672
3673         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
3674         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
3675         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
3676         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
3677         (psym_lookup_symbol, psym_find_last_source_symtab)
3678         (psym_forget_cached_source_info, psym_print_stats)
3679         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
3680         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
3681         (psym_map_matching_symbols, psym_expand_symtabs_matching)
3682         (psym_find_compunit_symtab_by_address)
3683         (maintenance_print_psymbols, maintenance_info_psymtabs)
3684         (maintenance_check_psymtabs): Use ranged for.
3685         * psymtab.h (class objfile_psymtabs): New.
3686         (require_partial_symbols): Return objfile_psymtabs.
3687         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
3688
3689 2019-01-09  Tom Tromey  <tom@tromey.com>
3690
3691         * symfile.c (overlay_invalidate_all, find_pc_overlay)
3692         (find_pc_mapped_section, list_overlays_command)
3693         (map_overlay_command, unmap_overlay_command)
3694         (simple_overlay_update): Use all_objfiles.
3695         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
3696         * printcmd.c (info_symbol_command): Use all_objfiles.
3697         * objfiles.h (ALL_OBJSECTIONS): Remove.
3698         * maint.c (maintenance_translate_address): Use all_objfiles.
3699         * gcore.c (gcore_create_callback): Use all_objfiles.
3700         (objfile_find_memory_regions): Likewise.
3701
3702 2019-01-09  Tom Tromey  <tom@tromey.com>
3703
3704         * symtab.c (find_line_symtab, info_sources_command)
3705         (make_source_files_completion_list): Use objfile_compunits.
3706         * source.c (select_source_symtab): Use objfile_compunits.
3707         * objfiles.h (struct objfile): Update comment.
3708         (ALL_OBJFILES): Remove.
3709         (ALL_FILETABS): Remove.
3710         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
3711         objfile_compunits.
3712
3713 2019-01-09  Tom Tromey  <tom@tromey.com>
3714
3715         * symmisc.c (print_objfile_statistics, dump_objfile)
3716         (maintenance_print_symbols): Use compunit_filetabs.
3717         * source.c (forget_cached_source_info_for_objfile): Use
3718         compunit_filetabs.
3719         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
3720         (ALL_FILETABS): Use compunit_filetabs.
3721         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
3722         * coffread.c (coff_symtab_read): Use compunit_filetabs.
3723
3724 2019-01-09  Tom Tromey  <tom@tromey.com>
3725
3726         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
3727         (compunit_filetabs): New.
3728         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
3729         compunit_filetabs.
3730         (info_sources_command, make_source_files_completion_list): Remove
3731         declaration.
3732         * symmisc.c (print_objfile_statistics, dump_objfile)
3733         (maintenance_print_symbols): Remove declaration.
3734         (maintenance_info_symtabs): Use compunit_filetabs.
3735         (maintenance_info_line_tables): Likewise.
3736         * source.c (select_source_symtab): Change local variable name.
3737         (forget_cached_source_info_for_objfile): Remove declaration.
3738         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
3739         * objfiles.c (objfile_relocate1): Remove declaration.
3740         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3741         declaration.
3742         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
3743         * coffread.c (coff_symtab_read): Remove declaration.
3744         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3745         compunit_filetabs.
3746
3747 2019-01-09  Tom Tromey  <tom@tromey.com>
3748
3749         * symtab.c (lookup_objfile_from_block)
3750         (find_pc_sect_compunit_symtab, search_symbols)
3751         (default_collect_symbol_completion_matches_break_on): Use
3752         objfile_compunits.
3753         * objfiles.h (ALL_COMPUNITS): Remove.
3754         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
3755         * cp-support.c (add_symbol_overload_list_qualified): Use
3756         objfile_compunits.
3757         * ada-lang.c (ada_collect_symbol_completion_matches)
3758         (ada_add_global_exceptions): Use objfile_compunits.
3759
3760 2019-01-09  Tom Tromey  <tom@tromey.com>
3761
3762         * source.c (select_source_symtab)
3763         (forget_cached_source_info_for_objfile): Remove declaration.
3764         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3765         declaration.
3766         * maint.c (count_symtabs_and_blocks): Remove declaration.
3767         * cp-support.c (add_symbol_overload_list_qualified): Remove
3768         declaration.
3769         * coffread.c (coff_symtab_read): Remove declaration.
3770         * symtab.c (lookup_symbol_in_objfile_symtabs)
3771         (basic_lookup_transparent_type_1): Use objfile_compunits.
3772         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
3773         (info_sources_command, search_symbols)
3774         (default_collect_symbol_completion_matches_break_on)
3775         (make_source_files_completion_list): Remove declaration.
3776         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
3777         (ada_collect_symbol_completion_matches)
3778         (ada_add_global_exceptions): Remove declaration.
3779         * linespec.c (iterate_over_all_matching_symtabs): Use
3780         objfile_compunits.
3781         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
3782         (class objfile_compunits): New.
3783         (ALL_COMPUNITS): Use objfile_compunits.
3784         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
3785         (maintenance_check_symtabs, maintenance_info_line_tables): Use
3786         objfile_compunits.
3787         * objfiles.c (objfile_relocate1): Use objfile_compunits.
3788
3789 2019-01-09  Tom Tromey  <tom@tromey.com>
3790
3791         * symtab.c (search_symbols)
3792         (default_collect_symbol_completion_matches_break_on): Use
3793         objfile_msymbols.
3794         * ada-lang.c (ada_lookup_simple_minsym)
3795         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
3796         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
3797         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
3798         objfile_msymbols.
3799         * coffread.c (coff_symfile_read): Use objfile_msymbols.
3800         * symmisc.c (dump_msymbols): Use objfile_msymbols.
3801         * objc-lang.c (find_methods): Use objfile_msymbols.
3802         (info_selectors_command, info_classes_command): Likewise.
3803         * stabsread.c (scan_file_globals): Use objfile_msymbols.
3804         * objfiles.h (class objfile_msymbols): New.
3805         (ALL_OBJFILE_MSYMBOLS): Remove.
3806         (ALL_MSYMBOLS): Remove.
3807
3808 2019-01-09  Tom Tromey  <tom@tromey.com>
3809
3810         * common/next-iterator.h (next_adapter): Add Iterator template
3811         parameter.
3812         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3813         (class all_objfiles_safe): New.
3814         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3815         * objfiles.c (put_objfile_before): Update comment.
3816         (add_separate_debug_objfile): Likewise.
3817         (free_all_objfiles): Use all_objfiles_safe.
3818         (objfile_purge_solibs): Likewise.
3819
3820 2019-01-09  Tom Tromey  <tom@tromey.com>
3821
3822         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3823         (expand_symtab_containing_pc, lookup_static_symbol)
3824         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3825         (find_symbol_at_address, find_line_symtab, find_main_name): Use
3826         all_objfiles.
3827         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3828         * breakpoint.c (create_overlay_event_breakpoint)
3829         (create_longjmp_master_breakpoint)
3830         (create_std_terminate_master_breakpoint)
3831         (create_exception_master_breakpoint): Use all_objfiles.
3832         * linux-thread-db.c (try_thread_db_load_from_pdir)
3833         (has_libpthread): Use all_objfiles.
3834         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3835         * linespec.c (iterate_over_all_matching_symtabs)
3836         (search_minsyms_for_name): Use all_objfiles.
3837         * maint.c (maintenance_info_sections): Use all_objfiles.
3838         * main.c (captured_main_1): Use all_objfiles.
3839         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3840         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3841         * guile/scm-pretty-print.c
3842         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3843         * solib-spu.c (append_ocl_sos): Use all_objfiles.
3844         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3845         (maintenance_print_msymbols): Use all_objfiles.
3846         * source.c (select_source_symtab): Use all_objfiles.
3847         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3848         * symfile.c (remove_symbol_file_command)
3849         (expand_symtabs_matching, map_symbol_filenames): Use
3850         all_objfiles.
3851         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3852         all_objfiles.
3853         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3854         * objc-lang.c (find_methods): Use all_objfiles.
3855         * objfiles.c (have_partial_symbols, have_full_symbols)
3856         (have_minimal_symbols, qsort_cmp)
3857         (default_iterate_over_objfiles_in_search_order): Use
3858         all_objfiles.
3859         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3860         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3861         (maintenance_check_psymtabs): Use all_objfiles.
3862         (ALL_PSYMTABS): Remove.
3863         * compile/compile-object-run.c (do_module_cleanup): Use
3864         all_objfiles.
3865         * blockframe.c (find_pc_partial_function): Use all_objfiles.
3866         * cp-support.c (add_symbol_overload_list_qualified): Use
3867         all_objfiles.
3868         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3869         Use all_objfiles.
3870         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3871         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3872         all_objfiles.
3873         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3874         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
3875         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3876         Uses all_objfiles.
3877         * solib.c (solib_read_symbols): Use all_objfiles
3878
3879 2019-01-09  Tom Tromey  <tom@tromey.com>
3880
3881         * probe.c (parse_probes_in_pspace): Use all_objfiles.
3882         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
3883         all_objfiles.
3884         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
3885         * symmisc.c (print_symbol_bcache_statistics)
3886         (print_objfile_statistics, maintenance_print_objfiles)
3887         (maintenance_info_symtabs, maintenance_check_symtabs)
3888         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
3889         all_objfiles.
3890         * source.c (forget_cached_source_info): Use all_objfiles.
3891         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
3892         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3893         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
3894         * objfiles.c (update_section_map): Use all_objfiles.
3895         (shared_objfile_contains_address_p): Likewise.
3896         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
3897         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
3898
3899 2019-01-09  Tom Tromey  <tom@tromey.com>
3900
3901         * common/next-iterator.h: New file.
3902         * objfiles.h (class all_objfiles): New.
3903         (struct objfile_iterator): New.
3904
3905 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3906
3907         * NEWS: Move the description of the changed "frame", "select-frame",
3908          and "info frame" commands to the Changed commands section.
3909
3910 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
3911
3912         * gdbtypes.c (check_stub_method_group): Remove handling of old
3913         mangling schemes.
3914         * linespec.c (find_methods): Likewise.
3915         * stabsread.c (read_member_functions): Likewise.
3916         * valops.c (search_struct_method): Likewise.
3917         (value_struct_elt_for_reference): Likewise.
3918         * NEWS: Mention this change.
3919
3920 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3921
3922         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
3923         print_source_lines.
3924         * source.c (print_source_lines_base): Update line number check.
3925         (print_source_lines): New function.
3926         (source_lines_range::source_lines_range): New function.
3927         * source.h (class source_lines_range): New class.
3928         (print_source_lines): New declaration.
3929
3930 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3931
3932         * linespec.c (linespec_state_destructor): Free self->canonical_names.
3933
3934 2019-01-08  Tom Tromey  <tom@tromey.com>
3935             Simon Marchi  <simon.marchi@ericsson.com>
3936
3937         PR gdb/24060
3938         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
3939         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
3940         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3941         * f-exp.y (DOLLAR_VARIABLE): Likewise.
3942         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
3943         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3944
3945 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3946
3947         * source.c (select_source_symtab): Move header comment to
3948         declaration in source.h.
3949         (forget_cached_source_info_for_objfile): Likewise.
3950         (forget_cached_source_info): Likewise.
3951         (identify_source_line): Likewise.
3952         * source.h (identify_source_line): Move declaration from symtab.h
3953         and add comment from source.c
3954         (print_source_lines): Likewise.
3955         (forget_cached_source_info_for_objfile): Likewise.
3956         (forget_cached_source_info): Likewise.
3957         (select_source_symtab): Likewise.
3958         (enum print_source_lines_flag): Move definition from symtab.h.
3959         * symtab.h (identify_source_line): Move declaration to source.h.
3960         (print_source_lines): Likewise.
3961         (forget_cached_source_info_for_objfile): Likewise.
3962         (forget_cached_source_info): Likewise.
3963         (select_source_symtab): Likewise.
3964         (enum print_source_lines_flag): Move definition to source.h.
3965         * tui/tui-hooks.c: Add 'source.h' include.
3966
3967 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3968
3969         * source.c (print_source_lines_base): Handle requests to print
3970         reverse line number sequences, and guard against empty lines
3971         string.
3972
3973 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3974
3975         * source.c (print_source_lines_base): Fix skip of '\r' if next
3976         character is '\n'.
3977
3978 2019-01-06  Tom Tromey  <tom@tromey.com>
3979
3980         * c-exp.y (struct c_parse_state) <macro_original_text,
3981         expansion_obstack>: New member.
3982         (macro_original_text, expansion_obstack): Remove globals.
3983         (scan_macro_expansion, scanning_macro_expansion)
3984         (finished_macro_expansion): Update.
3985         (scan_macro_cleanup): Remove.
3986         (yylex, c_parse): Update.
3987
3988 2019-01-06  Tom Tromey  <tom@tromey.com>
3989
3990         * c-exp.y (struct c_parse_state) <strings>: New member.
3991         (operator_stoken): Update.
3992
3993 2019-01-06  Tom Tromey  <tom@tromey.com>
3994
3995         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
3996         (union type_stack_elt) <typelist_val>: Now a pointer to
3997         std::vector.
3998         (type_stack_cleanup): Don't declare.
3999         (push_typelist): Update.
4000         * parse.c (pop_typelist): Return a std::vector.
4001         (push_typelist): Take a std::vector.
4002         (follow_types): Update.  Do not free args.
4003         (type_stack_cleanup): Remove.
4004         * c-exp.y (struct c_parse_state): New.
4005         (cpstate): New global.
4006         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
4007         (nonempty_typelist): Update.
4008         (func_mod): Create a new vector.
4009         (c_parse): Create a c_parse_state.
4010         (check_parameter_typelist): Do not delete params.
4011         (function_method): Update.  Do not delete type_list.
4012
4013 2019-01-06  Tom Tromey  <tom@tromey.com>
4014
4015         PR gdb/28155:
4016         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
4017         check_typedef.
4018         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
4019         (print_return_value): Likewise.
4020
4021 2019-01-05  Tom Tromey  <tom@tromey.com>
4022
4023         * contrib/cleanup_check.py: Remove.
4024         * contrib/gcc-with-excheck: Remove.
4025         * contrib/exsummary.py: Remove.
4026         * contrib/excheck.py: Remove.
4027
4028 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
4029
4030         * thread.c (delete_thread_1): Add gdb_assert that THR is not
4031         NULL. Initialize tpprev to NULL instead of assigning it
4032         to NULL on the next statement.
4033         * windows-nat.c (windows_delete_thread): Remove check for
4034         main_thread_id before printing thread exit notifications.
4035         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
4036         Remove thread ID check against main_thread_id.
4037         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
4038         windows_delete_thread.
4039         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
4040
4041 2019-01-04  Tom Tromey  <tom@tromey.com>
4042
4043         * compile/compile.c (_initialize_compile): Use upper case for
4044         metasyntactic variables.
4045         * symmisc.c (_initialize_symmisc): Use upper case for
4046         metasyntactic variables.
4047         * psymtab.c (_initialize_psymtab): Use upper case for
4048         metasyntactic variables.
4049         * demangle.c (demangle_command): Use upper case for metasyntactic
4050         variables.
4051         (_initialize_demangler): Likewise.
4052         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
4053         variables.
4054
4055 2019-01-03  Tom Tromey  <tom@tromey.com>
4056
4057         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
4058
4059 2019-01-03  Tom Tromey  <tom@tromey.com>
4060
4061         * python/py-symtab.c (salpy_str): Update.
4062         (struct salpy_sal_object) <symtab>: Now a PyObject.
4063         (salpy_dealloc): Update.
4064         (del_objfile_sal): Use gdbpy_ref.
4065
4066 2019-01-03  Tom Tromey  <tom@tromey.com>
4067
4068         * python/py-type.c (convert_field): Use new_reference.  Return
4069         gdbpy_ref.
4070         (make_fielditem): Return gdbpy_ref.
4071         (typy_fields): Update.
4072         (typy_getitem): Update.
4073         (field_name): Return gdbpy_ref.  Use new_reference.
4074         (typy_iterator_iternext): Update.
4075
4076 2019-01-03  Tom Tromey  <tom@tromey.com>
4077
4078         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
4079
4080 2019-01-03  Tom Tromey  <tom@tromey.com>
4081
4082         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
4083         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
4084         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
4085         (pspy_set_frame_filters, pspy_set_frame_unwinders)
4086         (pspy_set_type_printers): Likewise.
4087         * python/py-function.c (fnpy_init): Use gdbpy_ref.
4088         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
4089         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
4090         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
4091         (objfpy_set_type_printers): Likewise.
4092
4093 2019-01-03  Tom Tromey  <tom@tromey.com>
4094
4095         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
4096         (gdbpy_print_stack): Use gdbpy_err_fetch.
4097         * python/python-internal.h (class gdbpy_err_fetch): New class.
4098         (class gdbpy_enter) <m_error_type, m_error_value,
4099         m_error_traceback>: Remove.
4100         <m_error>: New member.
4101         (gdbpy_exception_to_string): Don't declare.
4102         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
4103         * python/py-value.c (convert_value_from_python): Use
4104         gdbpy_err_fetch.
4105         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
4106         gdbpy_exception_to_string.
4107         (gdbpy_handle_exception): Use gdbpy_err_fetch.
4108         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
4109         gdbpy_err_fetch.
4110
4111 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4112
4113         * linux-nat.c (delete_lwp_cleanup): Delete.
4114         (struct lwp_deleter): New struct.
4115         (lwp_info_up): New typedef.
4116         (linux_nat_target::follow_fork): Delete cleanup, and make use of
4117         lwp_info_up.
4118
4119 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4120
4121         * linux-fork.c (class scoped_switch_fork_info): New class.
4122         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
4123
4124 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4125
4126         * valops.c (find_overload_match): Remove use of null_cleanup, and
4127         calls to do_cleanups.
4128
4129 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4130
4131         * compile/compile-cplus-types.c
4132         (compile_cplus_instance::decl_name): Handle changes to
4133         cp_func_name.
4134         * cp-support.c (cp_func_name): Update header comment, update
4135         return type.
4136         * cp-support.h (cp_func_name): Update return type in declaration.
4137         * valops.c (find_overload_match): Move temp_func local to top
4138         level of function and change its type.  Use temp_func to hold and
4139         delete temporary string obtained from cp_func_name.
4140
4141 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4142
4143         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
4144         gdb::char_vector, remove cleanup, and update uses of `msg`.
4145
4146 2019-01-03  Jim Wilson  <jimw@sifive.com>
4147
4148         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
4149
4150 2019-01-02  Tom Tromey  <tom@tromey.com>
4151
4152         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
4153         (tdesc_parse_xml): Remove cleanups.
4154         * target-descriptions.h (make_cleanup_free_target_description):
4155         Don't declare.
4156         (target_desc_deleter): New struct.
4157         (target_desc_up): New typedef.
4158         * target-descriptions.c (target_desc_deleter::operator()): Rename
4159         from free_target_description.
4160         (make_cleanup_free_target_description): Remove.
4161
4162 2019-01-02  Tom Tromey  <tom@tromey.com>
4163
4164         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
4165         constructor, destructor.
4166         (linespec_parser): Remove typedef.
4167         (~linespec_parser): Rename from linespec_parser_delete.
4168         (linespec_lex_to_end, linespec_complete_label)
4169         (linespec_complete): Update.
4170         (decode_line_full): Remove cleanups.
4171         (decode_line_1): Update.
4172
4173 2019-01-02  Tom Tromey  <tom@tromey.com>
4174
4175         * python/python-internal.h (inferior_to_inferior_object): Change
4176         return type.
4177         * python/py-exitedevent.c (create_exited_event_object): Update.
4178         * python/py-inferior.c (inferior_to_inferior_object): Return
4179         gdbpy_ref.
4180         (python_new_inferior, python_inferior_deleted)
4181         (thread_to_thread_object, delete_thread_object)
4182         (build_inferior_list, gdbpy_selected_inferior): Update.
4183         * python/py-infthread.c (create_thread_object): Update.  Also fail
4184         if inferior_to_inferior_object fails.
4185
4186 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
4187
4188         * inferior.h (class inferior) <displaced_step_state>: New field.
4189         * infrun.h (struct displaced_step_state): Move here from
4190         infrun.c.  Initialize fields, add constructor.
4191         <inf>: Remove field.
4192         <reset>: New method.
4193         * infrun.c (struct displaced_step_inferior_state): Move to
4194         infrun.h.
4195         (displaced_step_inferior_states): Remove.
4196         (get_displaced_stepping_state): Adust.
4197         (displaced_step_in_progress_any_inferior): Adjust.
4198         (displaced_step_in_progress_thread): Adjust.
4199         (displaced_step_in_progress): Adjust.
4200         (add_displaced_stepping_state): Remove.
4201         (get_displaced_step_closure_by_addr): Adjust.
4202         (remove_displaced_stepping_state): Remove.
4203         (infrun_inferior_exit): Call displaced_step_state.reset.
4204         (use_displaced_stepping): Don't check for NULL.
4205         (displaced_step_prepare_throw): Call
4206         get_displaced_stepping_state.
4207         (displaced_step_fixup): Don't check for NULL.
4208         (prepare_for_detach): Don't check for NULL.
4209
4210 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4211
4212         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
4213          in case of call that did not complete.
4214
4215 2019-01-02  Andrey Utkin  <autkin@undo.io>
4216
4217         * symfile.c (find_separate_debug_file): Fix search of debug files for
4218         remote debuggee.
4219
4220 2019-01-02  Tom Tromey  <tom@tromey.com>
4221
4222         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
4223         indentation.
4224         * python/py-frame.c (frapy_older): Remove cast.
4225         (frapy_newer): Likewise.
4226         * python/py-breakpoint.c (local_setattro): Remove cast.
4227         * python/py-arch.c (archpy_name): Remove local variable.
4228         * python/py-type.c (gdbpy_lookup_type): Remove cast.
4229
4230 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
4231
4232         * unittests/basic_string_view/element_access/char/empty.cc:
4233         Fix year range in copyright header.
4234
4235 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4236
4237         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
4238         Delete.
4239         <operator==>: Update with for removed field.
4240         <hash>: Likewise.
4241         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
4242         <isa_features>: ...this.
4243         <abi_features>: New field.
4244         (riscv_isa_flen): Update comment.
4245         (riscv_abi_xlen): New declaration.
4246         (riscv_abi_flen): New declaration.
4247         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
4248         isa_features.
4249         (riscv_abi_xlen): New function.
4250         (riscv_isa_flen): Update to get answer from isa_features.
4251         (riscv_abi_flen): New function.
4252         (riscv_has_fp_abi): Update to get answer from abi_features.
4253         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
4254         xlen and flen.
4255         (riscv_call_info) <xlen, flen>: Update comment.
4256         (riscv_call_arg_struct): Remove invalid assertions
4257         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
4258         is removed.
4259         (riscv_gdbarch_init): Gather isa features and abi features
4260         separately, ensure both match on the gdbarch when reusing an old
4261         gdbarch.  Relax an error check to allow 32-bit abi float to run on
4262         a target with 64-bit float hardware.
4263
4264 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4265
4266         * source.c (search_command_helper): Stop reverse search
4267         when line 1 has been searched.
4268
4269 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4270
4271         * record-full.c (record_full_base_target::close): Rewrite
4272         record_full_core_buf_list free logic.
4273
4274 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4275
4276         * break-catch-syscall.c (print_one_catch_syscall): xfree
4277         the last text.
4278
4279 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
4280
4281         * top.c (print_gdb_version): Update Copyright year in version
4282         message.
4283
4284 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
4285
4286         Update copyright year range in all GDB files.
4287
4288 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
4289
4290         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
4291
4292 For older changes see ChangeLog-2018.
4293 \f
4294 Local Variables:
4295 mode: change-log
4296 left-margin: 8
4297 fill-column: 74
4298 version-control: never
4299 coding: utf-8
4300 End:
4301