gdb/ChangeLog

   1 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
   2
   3         * stack.c (find_frame_funname): Remove code which preferred
   4         minsym over symtab sym in "certain pathological cases".
   5
   6 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
   7
   8         PR gdb/24839:
   9         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
  10         type.
  11
  12 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
  13
  14         * python/py-objfile.c (add_separate_debug_file): Fix comment about
  15         this function's Python signature.
  16
  17
  18 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
  19
  20         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
  21         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
  22         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
  23         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
  24         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
  25
  26
  27 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
  28
  29         * h8300-tdep.c (h8300_register_name_common): New.
  30         h8300_register_name): Use h8300_register_name_common.
  31         (h8300s_register_name): Likewise.
  32         (h8300sx_register_name): Likewise.
  33         (h8300h_register_nam): New.
  34         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
  35
  36
  37 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
  38
  39         * arm-tdep.c (arm_skip_cmse_entry): New function.
  40         (arm_is_sgstubs_section): New function.
  41         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
  42
  43 2019-07-22  Tom Tromey  <tom@tromey.com>
  44
  45         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
  46         Don't self-assign.
  47
  48 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
  49
  50         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
  51         type_print.
  52
  53 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
  54
  55         * symtab.c (search_symbols): Adjust msymbol matching type arrays
  56         so that GDB doesn't match any msymbols when searching in the
  57         TYPES_DOMAIN.
  58         (print_symbol_info): Print using typedef_print or type_print based
  59         on the type of the symbol.  Add updated FIXME comment moved from...
  60         (_initialize_symtab): ... move and update FIXME comment to above.
  61
  62 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
  63
  64         * NEWS: Mention adding -q option to "info types".
  65         * symtab.c (struct info_types_options): New struct.
  66         (info_types_options_defs): New variable.
  67         (make_info_types_options_def_group): New function.
  68         (info_types_command): Use gdb::option framework to parse options.
  69         (info_types_command_completer): New function.
  70         (_initialize_symtab): Extend the help text on "info types" and
  71         register command completer.
  72
  73 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
  74
  75         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
  76         (lookup_symbol_in_objfile): Change int to block_enum and add a
  77         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
  78
  79 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
  80
  81         * MAINTAINERS (Write After Approval): Add self.
  82
  83 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
  84
  85         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
  86         instruction to the dummy code region.
  87
  88 2019-07-19  Tom Tromey  <tromey@adacore.com>
  89
  90         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
  91         (ARGSUSED, PARAMS, __func__): Remove rules.
  92
  93 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
  94
  95         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
  96         * features/arm/arm-with-iwmmxt.c: Remove.
  97         * features/arm/arm-with-iwmmxt.xml: Remove.
  98         * features/arm/arm-with-m-fpa-layout.c: Remove.
  99         * features/arm/arm-with-m-fpa-layout.xml: Remove.
 100         * features/arm/arm-with-m-vfp-d16.c: Remove.
 101         * features/arm/arm-with-m-vfp-d16.xml: Remove.
 102         * features/arm/arm-with-m.c: Remove.
 103         * features/arm/arm-with-m.xml: Remove.
 104         * features/arm/arm-with-neon.c: Remove.
 105         * features/arm/arm-with-neon.xml: Remove.
 106         * features/arm/arm-with-vfpv2.c: Remove.
 107         * features/arm/arm-with-vfpv2.xml: Remove.
 108         * features/arm/arm-with-vfpv3.c: Remove.
 109         * features/arm/arm-with-vfpv3.xml: Remove.
 110
 111 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 112
 113         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
 114
 115 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 116
 117         * arch/aarch32.c (aarch32_create_target_description): Create
 118         target descriptions using features.
 119         * arch/arm.c (arm_create_target_description)
 120         (arm_create_mprofile_target_description): Likewise.
 121         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
 122
 123 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 124
 125         * Makefile.in: Add new files.
 126         * aarch32-tdep.c: New file.
 127         * aarch32-tdep.h: New file.
 128         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 129         Call aarch32_read_description.
 130         * arch/aarch32.c: New file.
 131         * arch/aarch32.h: New file.
 132         * arch/arm.c (arm_create_target_description)
 133         (arm_create_mprofile_target_description): New function.
 134         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
 135         (arm_create_target_description)
 136         (arm_create_mprofile_target_description): New declaration.
 137         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
 138         read_description functions.
 139         * arm-linux-nat.c (arm_linux_nat_target::read_description):
 140         Likewise.
 141         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 142         * arm-tdep.c (tdesc_arm_list): New variable.
 143         (arm_register_g_packet_guesses): Call create description functions.
 144         (arm_read_description) (arm_read_mprofile_description): New
 145         function.
 146         * arm-tdep.h (arm_read_description)
 147         (arm_read_mprofile_description): Add declaration.
 148         * configure.tgt: Add new files.
 149
 150 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
 151
 152         * top.c (new_ui_command): Open specified terminal just once.
 153
 154 2019-07-18  Tom Tromey  <tromey@adacore.com>
 155
 156         * symtab.c (main_name): Constify return type.
 157         * symfile.c (set_initial_language): Update.
 158         * symtab.h (main_name): Constify return type.
 159
 160 2019-07-17  Tom Tromey  <tom@tromey.com>
 161
 162         * tui/tui-winsource.c (tui_update_source_window)
 163         (tui_update_source_window_as_is)
 164         (tui_update_source_windows_with_line): Remove return.
 165         * tui/tui-disasm.c (tui_show_disassem)
 166         (tui_show_disassem_and_update_source): Remove return.
 167         * tui/tui.c (tui_reset): Remove return.
 168         * tui/tui-wingeneral.c
 169         (tui_check_and_display_highlight_if_needed): Remove return.
 170
 171 2019-07-17  Tom Tromey  <tom@tromey.com>
 172
 173         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
 174
 175 2019-07-17  Tom Tromey  <tom@tromey.com>
 176
 177         * tui/tui-winsource.h (struct tui_exec_info_window)
 178         (struct tui_source_window_base): Move from tui-data.h.
 179         * tui/tui-winsource.c: Move many method definitions from
 180         elsewhere.  Remove "structuring" comments.
 181         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
 182         (tui_source_window_base::refresh_window): Move to
 183         tui-winsource.c.
 184         * tui/tui-win.c (tui_source_window_base::refresh_all)
 185         (tui_source_window_base::update_tab_width)
 186         (tui_source_window_base::set_new_height)
 187         (tui_source_window_base::do_make_visible_with_new_height): Move to
 188         tui-winsource.c.
 189         * tui/tui-source.h: Update.
 190         * tui/tui-source.c (tui_source_window_base::reset): Move to
 191         tui-winsource.c.
 192         * tui/tui-disasm.h: Update.
 193         * tui/tui-data.h (struct tui_exec_info_window): Move to
 194         tui-winsource.h.
 195         (struct tui_source_window_base): Likewise.
 196         * tui/tui-data.c (tui_source_window_base::clear_detail)
 197         (tui_source_window_base, ~tui_source_window_base): Move to
 198         tui-winsource.c.
 199
 200 2019-07-17  Tom Tromey  <tom@tromey.com>
 201
 202         * tui/tui-win.c (tui_resize_all)
 203         (tui_source_window_base::update_tab_width)
 204         (tui_adjust_win_heights): Update.
 205         (tui_win_info::make_invisible_and_set_new_height): Rename from
 206         make_invisible_and_set_new_height.
 207         * tui/tui-data.h (struct tui_win_info)
 208         <make_invisible_and_set_new_height>: New method.
 209
 210 2019-07-17  Tom Tromey  <tom@tromey.com>
 211
 212         * tui/tui.c: Update.
 213         * tui/tui-source.h (struct tui_source_window): Move from
 214         tui-data.h.
 215         * tui/tui-layout.c: Update.
 216         * tui/tui-disasm.c: Update.
 217         * tui/tui-data.h (struct tui_source_window): Move to
 218         tui-source.h.
 219
 220 2019-07-17  Tom Tromey  <tom@tromey.com>
 221
 222         * tui/tui-disasm.h (struct tui_disasm_window): Move from
 223         tui-data.h.
 224         * tui/tui-data.h (struct tui_disasm_window): Move to
 225         tui-disasm.h.
 226
 227 2019-07-17  Tom Tromey  <tom@tromey.com>
 228
 229         * tui/tui-regs.h (struct tui_data_item_window): Move from
 230         tui-data.h.
 231         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
 232         * tui/tui-data.h (struct tui_data_item_window): Move to
 233         tui-regs.h.
 234         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
 235
 236 2019-07-17  Tom Tromey  <tom@tromey.com>
 237
 238         * tui/tui.c: Update.
 239         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
 240         (tui_cmd_window::max_height): Move to tui-command.c.
 241         * tui/tui-layout.c: Update.
 242         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
 243         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
 244         tui-command.c.
 245         * tui/tui-command.h (struct tui_cmd_window): Move from
 246         tui-data.h.
 247         * tui/tui-command.c: Remove "structuring" comments.
 248         (tui_cmd_window::clear_detail)
 249         (tui_cmd_window::do_make_visible_with_new_height)
 250         (tui_cmd_window::max_height): Move from elsewhere.
 251
 252 2019-07-17  Tom Tromey  <tom@tromey.com>
 253
 254         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
 255         Now static.
 256         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
 257         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
 258
 259 2019-07-17  Tom Tromey  <tom@tromey.com>
 260
 261         * tui/tui.c: Update.
 262         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
 263         tui-regs.c.
 264         * tui/tui-windata.h: Remove file.
 265         * tui/tui-windata.c: Remove file.
 266         * tui/tui-win.c (tui_data_window::set_new_height)
 267         (tui_data_window::do_make_visible_with_new_height): Move to
 268         tui-regs.c.
 269         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
 270         * tui/tui-regs.c: Remove "structuring" comments.
 271         (tui_data_window::first_data_item_displayed)
 272         (tui_data_window::delete_data_content_windows)
 273         (tui_data_window::erase_data_content)
 274         (tui_data_window::display_all_data)
 275         (tui_data_window::refresh_all)
 276         (tui_data_window::do_scroll_vertical)
 277         (tui_data_window::clear_detail, tui_data_window::set_new_height)
 278         (tui_data_window::do_make_visible_with_new_height)
 279         (tui_data_window::refresh_window): Move from elsewhere.
 280         (_initialize_tui_regs): Move to end of file.
 281         * tui/tui-layout.c: Update.
 282         * tui/tui-hooks.c: Update.
 283         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
 284         * tui/tui-data.c (tui_data_window::clear_detail): Move to
 285         tui-regs.c.
 286         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
 287
 288 2019-07-17  Tom Tromey  <tom@tromey.com>
 289
 290         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
 291         seen.
 292
 293 2019-07-17  Tom Tromey  <tom@tromey.com>
 294
 295         * tui/tui-win.c (tui_source_window_base::set_new_height)
 296         (tui_source_window_base::do_make_visible_with_new_height): Use
 297         m_has_locator field directly.
 298         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
 299         method.
 300         (struct tui_source_window_base) <has_locator>: Likewise.
 301
 302 2019-07-17  Tom Tromey  <tom@tromey.com>
 303
 304         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
 305         Don't declare.
 306         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
 307         Remove.
 308         * tui/tui-win.c (tui_source_window_base::set_new_height)
 309         (tui_source_window_base::set_new_height)
 310         (make_invisible_and_set_new_height)
 311         (tui_source_window_base::do_make_visible_with_new_height)
 312         (tui_source_window_base::do_make_visible_with_new_height):
 313         Update.
 314         * tui/tui-layout.c (show_source_disasm_command, show_data)
 315         (show_source_or_disasm_and_command): Update.
 316         * tui/tui-layout.c (show_layout): Update.
 317
 318 2019-07-17  Tom Tromey  <tom@tromey.com>
 319
 320         * tui/tui-layout.c (make_data_window): Remove.
 321         (show_data): Unify creation and re-initialization cases.
 322
 323 2019-07-17  Tom Tromey  <tom@tromey.com>
 324
 325         * tui/tui-layout.c (make_source_window, make_disasm_window):
 326         Remove.
 327         (show_data): Unify creation and re-initialization cases.
 328
 329 2019-07-17  Tom Tromey  <tom@tromey.com>
 330
 331         * tui/tui-layout.c (make_command_window): Remove.
 332         (show_source_disasm_command, show_source_or_disasm_and_command):
 333         Unify creation and re-initialization cases.
 334
 335 2019-07-17  Tom Tromey  <tom@tromey.com>
 336
 337         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 338         creation and re-initialization cases.
 339
 340 2019-07-17  Tom Tromey  <tom@tromey.com>
 341
 342         * tui/tui-regs.c (tui_get_register): Return void.
 343
 344 2019-07-17  Tom Tromey  <tom@tromey.com>
 345
 346         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 347         Simplify.
 348
 349 2019-07-17  Tom Tromey  <tom@tromey.com>
 350
 351         * tui/tui-layout.c (show_source_disasm_command): Simplify window
 352         resetting.
 353
 354 2019-07-17  Tom Tromey  <tom@tromey.com>
 355
 356         * tui/tui.h (tui_set_layout_by_name): Don't declare.
 357         * tui/tui-regs.c (tui_reg_layout): New function.
 358         (tui_show_registers, tui_reg_command): Use it.
 359         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 360         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 361         parameters.
 362         (tui_layout_command): Remove.
 363
 364 2019-07-17  Tom Tromey  <tom@tromey.com>
 365
 366         * tui/tui-layout.h (tui/tui-layout): Return void.
 367         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 368
 369 2019-07-17  Tom Tromey  <tom@tromey.com>
 370
 371         * tui/tui-layout.c (show_source_disasm_command, show_data):
 372         Update.
 373         (reset_locator): Remove.
 374         (show_source_or_disasm_and_command): Update.
 375
 376 2019-07-17  Tom Tromey  <tom@tromey.com>
 377
 378         * tui/tui-source.c (tui_source_window_base::reset): Remove
 379         win_type parameter.
 380         * tui/tui-layout.c (make_command_window, make_source_window)
 381         (make_disasm_window, make_data_window)
 382         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 383         (reset_locator, show_source_or_disasm_and_command): Update.
 384         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 385         win_type parameter.
 386         (struct tui_source_window_base) <reset>: Likewise.
 387
 388 2019-07-17  Tom Tromey  <tom@tromey.com>
 389
 390         * tui/tui-layout.c (show_source_disasm_command): Use
 391         reset_locator.
 392         (reset_locator): New function.
 393         (init_and_make_win): Remove.
 394         (show_source_or_disasm_and_command): Use reset_locator.
 395
 396 2019-07-17  Tom Tromey  <tom@tromey.com>
 397
 398         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 399         condition.
 400         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 401         Remove condition.
 402         * tui/tui-source.c (tui_source_window_base::reset): New method.
 403         * tui/tui-layout.c (make_command_window): Don't call
 404         init_and_make_win.
 405         (make_source_window, make_disasm_window): Don't call
 406         make_source_or_disasm_window.
 407         (make_data_window): Don't call init_and_make_win.  Change calling
 408         convention.
 409         (show_source_disasm_command, show_data): Simplify.
 410         (make_source_or_disasm_window): Remove.
 411         (show_source_or_disasm_and_command): Simplify.
 412         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 413         (struct tui_source_window_base) <reset>: Likewise.
 414         <execution_info>: Remove initializer.
 415         * tui/tui-data.c (tui_source_window_base): Initialize
 416         execution_info.
 417
 418 2019-07-17  Tom Tromey  <tom@tromey.com>
 419
 420         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 421         variable.
 422
 423 2019-07-17  Tom Tromey  <tom@tromey.com>
 424
 425         * tui/tui.c (tui_rl_other_window): Update.
 426         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 427         superclass method first.  Always iterate over regs_content.
 428         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 429         method.
 430         * tui/tui-win.c (tui_set_focus_command): Update.
 431
 432 2019-07-17  Tom Tromey  <tom@tromey.com>
 433
 434         * tui/tui-win.c (tui_set_focus_command): Rename from
 435         tui_set_focus.  Call tui_enable.
 436         (tui_set_focus_command): Remove.
 437
 438 2019-07-17  Tom Tromey  <tom@tromey.com>
 439
 440         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 441         refresh_window.
 442         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 443         touchwin.
 444         (tui_data_window::refresh_window): Call refresh_window on data
 445         items.  Always call superclass refresh_window.
 446         (tui_win_info::refresh): Remove.
 447         (tui_source_window_base::refresh_window): Update.
 448         (tui_refresh_all): Update.
 449         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 450         refresh_window.
 451         (show_source_or_disasm_and_command): Likewise.
 452         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 453         (struct tui_source_window_base) <refresh>: Likewise.
 454
 455 2019-07-17  Tom Tromey  <tom@tromey.com>
 456
 457         * tui/tui-winsource.c (tui_clear_source_content)
 458         (tui_show_source_content): Update.
 459         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 460         whether content is empty.
 461         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 462         Remove.
 463
 464 2019-07-17  Tom Tromey  <tom@tromey.com>
 465
 466         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 467         window's contents.
 468         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 469         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 470
 471 2019-07-17  Tom Tromey  <tom@tromey.com>
 472
 473         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 474         (struct tui_data_item_window): Update.
 475
 476 2019-07-17  Tom Tromey  <tom@tromey.com>
 477
 478         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 479         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 480         defines.
 481
 482 2019-07-17  Tom Tromey  <tom@tromey.com>
 483
 484         * tui/tui-winsource.h (tui_erase_source_content)
 485         (tui_clear_source_content): Remove "display_prompt" parameter.
 486         * tui/tui-winsource.c (tui_update_source_window_as_is)
 487         (tui_update_source_windows_with_addr): Update.
 488         (tui_clear_source_content): Remove "display_prompt" parameter.
 489         (tui_erase_source_content): Likewise.  Simplify.
 490         (tui_show_source_content): Update.
 491         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 492         * tui/tui-stack.c (tui_show_frame_info): Update.
 493         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 494         Remove defines.
 495
 496 2019-07-17  Tom Tromey  <tom@tromey.com>
 497
 498         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 499         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 500         parameter.
 501         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 502         parameter.
 503
 504 2019-07-17  Tom Tromey  <tom@tromey.com>
 505
 506         * tui/tui-winsource.c (tui_clear_source_content)
 507         (tui_show_source_content, tui_show_exec_info_content)
 508         (tui_clear_exec_info_content): Update.
 509         * tui/tui-stack.c (tui_show_locator_content): Update.
 510         (tui_show_frame_info): Update.
 511         * tui/tui-source.h (tui_source_window): Don't declare.
 512         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 513         from tui_source_is_displayed.
 514         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 515         Remove field.
 516         (struct tui_source_window_base) <content_in_use>: New field.  Now
 517         bool.
 518         (struct tui_source_window) <showing_source_p>: New method.
 519         (TUI_SRC_WIN): Change cast.
 520         * tui/tui-data.c (tui_initialize_static_data): Update.
 521
 522 2019-07-17  Tom Tromey  <tom@tromey.com>
 523
 524         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 525         location_matches_p.
 526         * tui/tui-source.c (tui_source_window::location_matches_p): New
 527         method.
 528         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 529         method.
 530         * tui/tui-data.h (struct tui_source_window_base)
 531         <location_matches_p>: New method.
 532         (struct tui_source_window, struct tui_disasm_window)
 533         <location_matches_p>: Likewise.
 534
 535 2019-07-17  Tom Tromey  <tom@tromey.com>
 536
 537         * tui/tui-win.c (tui_set_win_height_command): Rename from
 538         tui_set_win_height.
 539         (tui_set_win_height_command): Remove.
 540
 541 2019-07-17  Tom Tromey  <tom@tromey.com>
 542
 543         * tui/tui-source.c (tui_source_window): New constructor.  Add
 544         observer.
 545         (~tui_source_window): New destructor.
 546         (tui_source_window::style_changed): New method.
 547         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 548         (tui_attach_detach_observers): Update.
 549         * tui/tui-data.h (struct tui_source_window): Make constructor not
 550         inline.  Add destructor.
 551         (struct tui_source_window) <style_changed>: New method.
 552         <m_observable>: New member.
 553
 554 2019-07-17  Tom Tromey  <tom@tromey.com>
 555
 556         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 557         * tui/tui-win.c (tui_resize_all): Fix typo.
 558
 559 2019-07-17  Tom Tromey  <tom@tromey.com>
 560
 561         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 562         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 563         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 564         * tui/tui-win.c (window_name_completer): Use foreach.
 565         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 566         (update_tab_width): Likewise.
 567         * tui/tui-layout.c (show_layout): Update.
 568         * tui/tui-data.h (class tui_window_iterator): New.
 569         (struct all_tui_windows): New.
 570         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 571
 572 2019-07-17  Tom Tromey  <tom@tromey.com>
 573
 574         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 575         parameter.  Don't reference globals.
 576         (tui_reg_command): Update.
 577
 578 2019-07-17  Tom Tromey  <tom@tromey.com>
 579
 580         * tui/tui-regs.c (tui_show_registers): Simplify.
 581
 582 2019-07-17  Tom Tromey  <tom@tromey.com>
 583
 584         * tui/tui-regs.c (tui_show_registers): Update.
 585         (tui_show_register_group): Add win_info parameter.
 586
 587 2019-07-17  Tom Tromey  <tom@tromey.com>
 588
 589         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 590         Rename from tui_display_reg_element_at_line.
 591         (tui_data_window::display_registers_from_line): Update.
 592         * tui/tui-data.h (struct tui_data_window)
 593         <display_reg_element_at_line>: New method.
 594
 595 2019-07-17  Tom Tromey  <tom@tromey.com>
 596
 597         * tui/tui-regs.h (tui_display_registers_from)
 598         (tui_display_registers_from_line): Don't declare.
 599         * tui/tui-windata.c (tui_data_window::display_all_data)
 600         (tui_data_window::refresh_all)
 601         (tui_data_window::do_scroll_vertical): Update.
 602         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 603         from tui_display_registers_from.
 604         (tui_display_reg_element_at_line): Update.
 605         (tui_data_window::display_registers_from_line): Rename from
 606         tui_display_registers_from_line.
 607         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 608         display_registers_from_line>: New methods.
 609
 610 2019-07-17  Tom Tromey  <tom@tromey.com>
 611
 612         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 613         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 614         from tui_erase_data_content.
 615         (tui_data_window::display_all_data)
 616         (tui_data_window::refresh_all)
 617         (tui_data_window::do_scroll_vertical): Update.
 618         * tui/tui-regs.c (tui_show_registers): Update.
 619         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 620         New method.
 621
 622 2019-07-17  Tom Tromey  <tom@tromey.com>
 623
 624         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 625         declare.
 626         * tui/tui-windata.c
 627         (tui_data_window::delete_data_content_windows): Rename from
 628         tui_delete_data_content_windows.
 629         (tui_data_window::display_all_data)
 630         (tui_data_window::do_scroll_vertical): Update.
 631         * tui/tui-data.h (struct tui_data_window)
 632         <delete_data_content_windows>: New method.
 633
 634 2019-07-17  Tom Tromey  <tom@tromey.com>
 635
 636         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 637         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 638
 639 2019-07-17  Tom Tromey  <tom@tromey.com>
 640
 641         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 642         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 643         from tui_display_all_data.
 644         * tui/tui-win.c
 645         (tui_data_window::do_make_visible_with_new_height): Update.
 646         * tui/tui-regs.c (tui_show_registers): Update.
 647         * tui/tui-layout.c (tui_set_layout): Update.
 648         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 649         method.
 650
 651 2019-07-17  Tom Tromey  <tom@tromey.com>
 652
 653         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 654         * tui/tui-windata.c (tui_display_data_from): Remove.
 655         (tui_data_window::refresh_all): Update.
 656
 657 2019-07-17  Tom Tromey  <tom@tromey.com>
 658
 659         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 660         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 661         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 662         tui_display_registers_from_line.
 663         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 664         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 665         "force_display" parameter.
 666
 667 2019-07-17  Tom Tromey  <tom@tromey.com>
 668
 669         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 670         declare.
 671         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 672         Rename from tui_first_reg_element_no_inline.
 673         (tui_display_reg_element_at_line)
 674         (tui_display_registers_from_line): Update.
 675         * tui/tui-data.h (struct tui_data_window)
 676         <first_reg_element_no_inline>: New method.
 677
 678 2019-07-17  Tom Tromey  <tom@tromey.com>
 679
 680         * tui/tui-windata.c (tui_display_data_from)
 681         (tui_data_window::do_scroll_vertical): Update.
 682         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 683         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 684         Rename from tui_line_from_reg_element_no.
 685         (tui_display_registers_from_line): Update.
 686         * tui/tui-data.h (struct tui_data_window)
 687         <line_from_reg_element_no>: New method.
 688
 689 2019-07-17  Tom Tromey  <tom@tromey.com>
 690
 691         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 692         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 693         tui_last_regs_line_no.
 694         (tui_display_reg_element_at_line)
 695         (tui_display_registers_from_line): Update.
 696         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 697         method.
 698
 699 2019-07-17  Tom Tromey  <tom@tromey.com>
 700
 701         PR tui/24722:
 702         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 703         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 704         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 705         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 706         (tui_update_breakpoint_info): Likewise.
 707         * tui/tui-hooks.c (tui_event_create_breakpoint)
 708         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 709         Update.
 710
 711 2019-07-17  Tom Tromey  <tom@tromey.com>
 712
 713         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 714
 715 2019-07-17  Tom Tromey  <tom@tromey.com>
 716
 717         * tui/tui-winsource.c (tui_update_source_window_as_is)
 718         (tui_update_source_windows_with_addr): Update.
 719         * tui/tui-source.h (tui_set_source_content)
 720         (tui_show_symtab_source): Add "win_info" parameter.
 721         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 722         parameter.
 723         (tui_show_symtab_source): Likewise.
 724
 725 2019-07-17  Tom Tromey  <tom@tromey.com>
 726
 727         * tui/tui-wingeneral.c
 728         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 729
 730 2019-07-17  Tom Tromey  <tom@tromey.com>
 731
 732         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 733         (struct tui_cmd_window) <can_scroll>: New method.
 734         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 735         method.
 736
 737 2019-07-17  Tom Tromey  <tromey@adacore.com>
 738
 739         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 740         do_field_signed>: Rename.  Change type of "value".
 741         * ui-out.c (ui_out::field_signed): Rename from field_int.
 742         Change type of "value".
 743         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 744         type of "value".
 745         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 746         do_field_int.  Change type of "value".
 747         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 748         do_field_int.  Change type of "value".
 749         * tracepoint.c (trace_status_mi, tfind_1)
 750         (print_one_static_tracepoint_marker): Update.
 751         * thread.c (print_thread_info_1, print_selected_thread_frame):
 752         Update.
 753         * stack.c (print_frame, print_frame_info): Update.
 754         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 755         Update.
 756         * source.c (print_source_lines_base): Update.
 757         * skip.c (info_skip_command): Update.
 758         * record-btrace.c (btrace_ui_out_decode_error)
 759         (btrace_call_history_src_line): Update.
 760         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 761         Update.
 762         * progspace.c (print_program_space): Update.
 763         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 764         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 765         do_field_int.  Change type of "value".
 766         * mi/mi-out.c (mi_ui_out::do_table_begin)
 767         (mi_ui_out::do_table_header): Update.
 768         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 769         type of "value".
 770         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 771         (mi_cmd_data_list_changed_registers, output_register)
 772         (mi_cmd_data_read_memory, mi_load_progress)
 773         (mi_cmd_trace_frame_collected): Update.
 774         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 775         Update.
 776         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 777         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 778         (mi_cmd_var_list_children, varobj_update_one): Update.
 779         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 780         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 781         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 782         * inferior.c (print_inferior): Update.
 783         * gdb_bfd.c (print_one_bfd): Update.
 784         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 785         Update.
 786         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 787         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 788         do_field_int.  Change type of "value".
 789         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 790         do_field_int.  Change type of "value".
 791         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 792         (print_one_breakpoint_location, print_it_catch_fork)
 793         (print_one_catch_fork, print_it_catch_vfork)
 794         (print_one_catch_vfork, print_it_catch_solib)
 795         (print_it_catch_exec, print_it_ranged_breakpoint)
 796         (print_mention_watchpoint, print_mention_masked_watchpoint)
 797         (bkpt_print_it, update_static_tracepoint): Update.
 798         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 799         * break-catch-syscall.c (print_it_catch_syscall): Update.
 800         * ada-tasks.c (print_ada_task_info): Update.
 801         * ada-lang.c (print_it_exception, print_mention_exception):
 802         Update.
 803
 804 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 805
 806         PR breakpoints/24541
 807         * gdbarch.c: Regenerate.
 808         * gdbarch.h: Regenerate.
 809         * gdbarch.sh: Adjust return type and parameter types for
 810         'stap_adjust_register'.
 811         (i386_stap_adjust_register): Adjust signature and return new
 812         register name.
 813         * stap-probe.c (stap_parse_register_operand): Adjust use of
 814         'gdbarch_stap_adjust_register'.
 815
 816 2019-07-17  Tom Tromey  <tromey@adacore.com>
 817
 818         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 819         declare VEC.
 820         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 821         std::vector.
 822         (struct s390_process_info): Add initializers.
 823         (s390_add_process): Use new.
 824         (s390_linux_nat_target::low_forget_process): Use delete.
 825         (s390_linux_nat_target::low_new_fork)
 826         (s390_linux_nat_target::stopped_by_watchpoint)
 827         (s390_linux_nat_target::low_prepare_to_resume)
 828         (s390_linux_nat_target::insert_watchpoint)
 829         (s390_linux_nat_target::insert_hw_breakpoint)
 830         (s390_linux_nat_target::remove_watchpoint)
 831         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 832
 833 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 834
 835         * aarch64-fbsd-nat.c: Include regcache.h.
 836         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 837         argument.
 838         (aarch64_fbsd_nat_target::fetch_registers)
 839         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 840         variable.
 841         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 842
 843 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 844
 845         * fbsd-nat.c: Include gdbarch.h.
 846
 847 2019-07-15  Tom Tromey  <tromey@adacore.com>
 848
 849         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 850
 851 2019-07-15  Tom Tromey  <tromey@adacore.com>
 852
 853         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 854         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 855         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 856         * cli-out.c (cli_ui_out::do_field_int): New method.
 857         * ui-out.c (ui_out::field_unsigned): New method.
 858         * symfile.c (generic_load): Use field_unsigned.
 859         (print_transfer_performance): Likewise.
 860         * record-btrace.c (ui_out_field_uint): Remove.
 861         (btrace_call_history_insn_range, btrace_call_history): Use
 862         field_unsigned.
 863         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 864         field_unsigned.
 865         * ui-out.h (class ui_out) <field_unsigned>: New method.
 866         <do_field_unsigned>: Likewise.
 867
 868 2019-07-15  Tom Tromey  <tromey@adacore.com>
 869
 870         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 871         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 872         * target.c (flash_erase_command): Use field_string.
 873         * infrun.c (print_signal_received_reason): Use field_string.
 874         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 875         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 876         field_string.
 877         * ada-tasks.c (print_ada_task_info): Use field_string.
 878
 879 2019-07-15  Tom Tromey  <tromey@adacore.com>
 880
 881         * target.c (flash_erase_command): Use field_core_addr.
 882         * symfile.c (generic_load): Use field_core_addr.
 883         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 884         Use field_core_addr.
 885         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 886         field_core_addr.
 887
 888 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 889
 890         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 891         value if its desired type is smaller than a CORE_ADDR and signed.
 892
 893 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 894
 895         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 896         of changes to field names, and use new is_reference field to
 897         decide if a property is a reference or not.
 898         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 899         field.
 900         (struct dwarf2_property_baton): Update header comment, rename
 901         'referenced_type' to 'property_type' and update comments.
 902         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 903         default property type, store in property baton, update to take
 904         accound of renamed field.
 905         (read_func_scope): Update call to attr_to_dynamic_prop.
 906         (read_array_type): Likewise.
 907         (dwarf2_per_cu_addr_sized_int_type): New function.
 908         (read_subrange_index_type): Move type finding code to
 909         dwarf2_per_cu_addr_sized_int_type.
 910         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 911         (dwarf2_per_cu_addr_type): New function.
 912         (set_die_type): Update calls to attr_to_dynamic_prop.
 913
 914 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 915
 916         * dwarf2read.c (read_subrange_index_type): New function.
 917         (read_subrange_type): Move code into new function and call it.
 918         * gdbtypes.c (create_range_type): Add some asserts.
 919
 920 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 921
 922         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 923         update return statements.
 924         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 925         declaration, and update comment to match.
 926         * gdbtypes.c (resolve_dynamic_array): Update call to
 927         dwarf2_evaluate_property to match new return type.
 928
 929 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 930
 931         * valarith.c (value_subscripted_rvalue): Change lowerbound
 932         parameter type from int to LONGEST.
 933         * value.h (value_subscripted_rvalue): Likewise in declaration.
 934
 935 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 936
 937         * cli/cli-utils.c (info_print_command_completer): New function.
 938         * cli/cli-utils.h: Add 'completer.h' include, and forward
 939         declaration for 'struct cmd_list_element'.
 940         (info_print_command_completer): Declare.
 941         * stack.c (_initialize_stack): Add completer for 'info locals' and
 942         'info args'.
 943         * symtab.c (_initialize_symtab): Add completer for 'info
 944         variables' and 'info functions'.
 945         * NEWS: Mention completion for additional info commands.
 946
 947 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 948
 949         * cli/cli-utils.c (extract_info_print_args): Delete.
 950         (extract_arg_maybe_quoted): Delete.
 951         (info_print_options_defs): New variable.
 952         (make_info_print_options_def_group): New function.
 953         (extract_info_print_options): Define new function.
 954         * cli/cli-utils.h (extract_info_print_args): Delete.
 955         (struct info_print_options): New structure.
 956         (extract_info_print_options): Declare new function.
 957         * stack.c (info_locals_command): Update to use new
 958         extract_info_print_options, also add a header comment.
 959         (info_args_command): Likewise.
 960         * symtab.c (info_variables_command): Likewise.
 961         (info_functions_command): Likewise.
 962
 963 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 964
 965         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 966         to extract string arguments.
 967         * common/common-utils.c (extract_string_maybe_quoted): New function.
 968         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 969
 970 2019-07-11  Tom Tromey  <tromey@adacore.com>
 971
 972         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 973         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 974         * top.h (gdbinit): Don't declare.
 975         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 976         into...
 977         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 978         * top.c (gdb_init): Don't call init_cli_cmds.
 979         (gdbinit): Remove.
 980         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 981
 982 2019-07-11  Tom Tromey  <tromey@adacore.com>
 983
 984         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 985         after it has been moved.
 986
 987 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 988
 989         * valops.c (value_must_coerce_to_target): Change return type to
 990         bool.
 991         * value.h (value_must_coerce_to_target): Likewise.
 992
 993 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 994
 995         * breakpoint.c (is_hardware_watchpoint): Remove
 996         forward-declaration.
 997         (is_masked_watchpoint): Change return type to bool.
 998         (is_tracepoint): Likewise.
 999         (is_breakpoint): Likewise.
1000         (is_hardware_watchpoint): Likewise.
1001         (is_watchpoint): Likewise.
1002         (is_no_memory_software_watchpoint): Likewise.
1003         (is_catchpoint): Likewise.
1004         (breakpoint_1): Make FILTER parameter's return type bool.
1005         is_masked_watchpoint): Change return type to bool.
1006         (save_breakpoints): Make FILTER parameter's return type bool.
1007         * breakpoint.h (is_breakpoint): Change return type to bool.
1008         (is_watchpoint): Likewise.
1009         (is_catchpoint): Likewise.
1010         (is_tracepoint): Likewise.
1011
1012 2019-07-10  Tom Tromey  <tom@tromey.com>
1013
1014         * defs.h: Don't include gdbarch.h.
1015         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1016         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1017         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1018         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1019         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1020         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1021         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1022         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1023         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1024         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1025         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1026         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1027         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1028         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1029         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1030         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1031         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1032         record-btrace.c, record.h, regcache-dump.c, regcache.h,
1033         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1034         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1035         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1036         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1037         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1038         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1039         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1040         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1041         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1042
1043 2019-07-10  Tom Tromey  <tromey@adacore.com>
1044
1045         * ada-lang.h (is_ada_exception_catchpoint): Declare.
1046         * breakpoint.c (init_ada_exception_breakpoint): Register as
1047         bp_catchpoint.
1048         (print_one_breakpoint_location, print_one_breakpoint): Use
1049         is_ada_exception_catchpoint.
1050         * ada-lang.c (class ada_catchpoint_location): Pass
1051         bp_loc_software_breakpoint to bp_location constructor.
1052         (is_ada_exception_catchpoint): New function.
1053
1054 2019-07-10  Tom Tromey  <tromey@adacore.com>
1055
1056         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
1057         VEC.
1058         (struct arm_exidx_entry): New method operator<.
1059         (struct arm_exidx_data) <section_maps>: Change type.
1060         (arm_exidx_data_free): Remove.
1061         (arm_exidx_data_key): Change type.  Move lower.
1062         (arm_exidx_new_objfile): Update.
1063         (arm_compare_exidx_entries): Remove.
1064         (arm_find_exidx_entry, _initialize_arm_tdep)
1065
1066 2019-07-10  Tom Tromey  <tromey@adacore.com>
1067
1068         * solib-spu.c (ocl_program_data_key): Change type.
1069         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1070         Update.
1071
1072 2019-07-10  Tom Tromey  <tromey@adacore.com>
1073
1074         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1075         (struct solib_aix_inferior_data) <library_list>: Change type.
1076         (solib_aix_inferior_data_handle): Change type.
1077         (get_solib_aix_inferior_data): Update.
1078         (solib_aix_free_library_list): Remove.
1079         (library_list_start_library): Update.
1080         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1081         return type.
1082         (solib_aix_get_library_list)
1083         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1084         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1085
1086 2019-07-10  Tom Tromey  <tromey@adacore.com>
1087
1088         * solib-dsbt.c (struct dsbt_info): Add initializers.
1089         (solib_dsbt_pspace_data): Change type.
1090         (dsbt_pspace_data_cleanup): Remove.
1091         (get_dsbt_info, _initialize_dsbt_solib): Update.
1092
1093 2019-07-10  Tom Tromey  <tromey@adacore.com>
1094
1095         * spu-tdep.c (spu_overlay_data): Change type.
1096         (spu_get_overlay_table, spu_overlay_new_objfile)
1097         (_initialize_spu_tdep): Update.
1098
1099 2019-07-10  Tom Tromey  <tromey@adacore.com>
1100
1101         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1102         destructor.
1103         (dbx_objfile_data_key): Change type and declare later.
1104         (DBX_SYMFILE_INFO): Rewrite.
1105         * dbxread.c (dbx_objfile_data_key): Change type.
1106         (dbx_symfile_init): Update.
1107         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1108         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1109         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1110
1111 2019-07-10  Tom Tromey  <tromey@adacore.com>
1112
1113         * jit.c (jit_program_space_key): Change type.  Move lower.
1114         (get_jit_program_space_data): Update.
1115         (jit_program_space_data_cleanup): Remove.
1116         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1117         Update.
1118         (struct jit_program_space_data): Add initializers.
1119
1120 2019-07-10  Tom Tromey  <tromey@adacore.com>
1121
1122         * solib-darwin.c (struct darwin_info): Add initializers.
1123         (solib_darwin_pspace_data): Change type.
1124         (darwin_pspace_data_cleanup): Remove.
1125         (get_darwin_info, _initialize_darwin_solib): Update.
1126
1127 2019-07-10  Tom Tromey  <tromey@adacore.com>
1128
1129         * remote-sim.c (struct sim_inferior_data): Add initializers,
1130         constructor, and destructor.
1131         (sim_inferior_data_key): Change type.  Move lower.
1132         (check_for_duplicate_sim_descriptor): Update.
1133         (get_sim_inferior_data): Use new.  Update.
1134         (~sim_inferior_data_cleanup): Rename from
1135         sim_inferior_data_cleanup.  Simplify.
1136         (gdbsim_close_inferior, simulator_command)
1137         (sim_command_completer, _initialize_remote_sim): Update.
1138         (next_pid, INITIAL_PID): Move earlier.
1139
1140 2019-07-10  Tom Tromey  <tromey@adacore.com>
1141
1142         * python/python-internal.h (create_thread_object): Return
1143         gdbpy_ref.
1144         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1145         * python/py-inferior.c (struct threadlist_entry): Add
1146         constructor.
1147         <thread_obj>: Now a gdbpy_ref.
1148         (thread_to_thread_object): Update.
1149         (add_thread_object): Use new.
1150         (delete_thread_object): Use delete.
1151         (infpy_threads): Update.
1152         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1153         GIL.
1154
1155 2019-07-10  Tom Tromey  <tromey@adacore.com>
1156
1157         * valops.c (value_cast): Specialize error message for Ada.
1158
1159 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1160
1161         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1162
1163 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1164
1165         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1166         bpstat_should_step): Return bool, adjust comments.
1167         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1168         bpstat_should_step): Likewise.
1169
1170 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1171
1172         * features/Makefile: Use feature target descriptions for Arm.
1173         * features/arm/arm-core.c: Generate new file.
1174         * features/arm/arm-fpa.c: Likewise.
1175         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1176         * features/arm/arm-m-profile.c: Likewise.
1177         * features/arm/arm-vfpv2.c: Likewise.
1178         * features/arm/arm-vfpv3.c: Likewise.
1179         * features/arm/xscale-iwmmxt.c: Likewise.
1180         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1181
1182 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1183
1184         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1185         ptrace earlier.
1186
1187 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1188
1189         * features/aarch64-pauth.c: Regenerate.
1190
1191 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1192
1193         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1194         bool.
1195         (bpstat_what): Use false instead of 0.
1196
1197 2019-07-09  Pedro Alves  <palves@redhat.com>
1198
1199         * break-catch-throw.c (is_exception_catchpoint): New.
1200         * breakpoint.c (print_one_breakpoint_location): New parameter
1201         'raw_loc'.  Handle it.  Use
1202         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1203         looking at the breakpoint's type.
1204         (print_one_breakpoint): If handling "maint info breakpoints", also
1205         print locations of exception catchpoints.
1206         * breakpoint.h (is_exception_catchpoint): Declare.
1207
1208 2019-07-09  Pedro Alves  <palves@redhat.com>
1209
1210         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1211         "addr" field.
1212         (allocate_location_exception_catchpoint): New.
1213         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1214         (initialize_throw_catchpoint_ops): Install
1215         allocate_location_exception_catchpoint as allocate_location
1216         method.
1217         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1218         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1219         bp_loc_other.
1220         (breakpoint_address_is_meaningful): Delete.
1221         (bl_address_is_meaningful): New.
1222         (breakpoint_locations_match): Adjust comment.
1223         (bp_location_from_bp_type): New, factored out of...
1224         (bp_location::bp_location(breakpoint *)): ... this.
1225         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1226         factored out of...
1227         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1228         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1229         breakpoint_address_is_meaningful.
1230         (bp_locations_compare): Adjust comment.
1231         (update_global_location_list): Use bl_address_is_meaningful
1232         instead of breakpoint_address_is_meaningful.
1233         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1234         explicit.
1235         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1236         * python/py-breakpoint.c (bppy_get_location): No longer check
1237         whether location is null.
1238
1239 2019-07-09  Pedro Alves  <palves@redhat.com>
1240
1241         PR c++/15468
1242         * breakpoint.c (print_one_breakpoint_location): Remove
1243         single-location assert.
1244
1245 2019-07-09  Tom Tromey  <tom@tromey.com>
1246
1247         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1248         * configure: Rebuild.
1249         * configure.ac: Change common to gdbsupport.
1250         * gdbsupport: Rename from common.
1251         * acinclude.m4: Change common to gdbsupport.
1252         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1253         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1254         gdbsupport.
1255         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1256         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1257         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1258         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1259         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1260         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1261         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1262         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1263         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1264         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1265         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1266         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1267         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1268         coff-pe-read.c, command.h, compile/compile-c-support.c,
1269         compile/compile-c.h, compile/compile-cplus-symbols.c,
1270         compile/compile-cplus-types.c, compile/compile-cplus.h,
1271         compile/compile-loc2c.c, compile/compile.c, completer.c,
1272         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1273         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1274         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1275         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1276         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1277         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1278         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1279         features/aarch64-core.c, features/aarch64-fpu.c,
1280         features/aarch64-pauth.c, features/aarch64-sve.c,
1281         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1282         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1283         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1284         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1285         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1286         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1287         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1288         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1289         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1290         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1291         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1292         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1293         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1294         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1295         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1296         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1297         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1298         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1299         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1300         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1301         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1302         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1303         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1304         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1305         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1306         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1307         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1308         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1309         minsyms.c, mips-linux-tdep.c, namespace.h,
1310         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1311         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1312         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1313         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1314         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1315         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1316         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1317         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1318         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1319         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1320         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1321         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1322         procfs.c, producer.c, progspace.h, psymtab.h,
1323         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1324         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1325         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1326         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1327         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1328         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1329         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1330         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1331         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1332         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1333         target-memory.c, target.c, target.h, target/waitstatus.c,
1334         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1335         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1336         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1337         unittests/array-view-selftests.c,
1338         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1339         unittests/common-utils-selftests.c,
1340         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1341         unittests/format_pieces-selftests.c,
1342         unittests/function-view-selftests.c,
1343         unittests/lookup_name_info-selftests.c,
1344         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1345         unittests/mkdir-recursive-selftests.c,
1346         unittests/observable-selftests.c,
1347         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1348         unittests/parse-connection-spec-selftests.c,
1349         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1350         unittests/scoped_fd-selftests.c,
1351         unittests/scoped_mmap-selftests.c,
1352         unittests/scoped_restore-selftests.c,
1353         unittests/string_view-selftests.c, unittests/style-selftests.c,
1354         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1355         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1356         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1357         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1358         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1359         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1360
1361 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1362
1363         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1364         bool value.
1365         (decode_digits_ordinary): Set explicit_line field in sal.
1366         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1367         symtab_and_line that was set on an explicit line number in
1368         assembler code.  Do always update the recorded symtab and line if
1369         we do skip the prologue.
1370
1371 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1372
1373         * breakpoint.c (set_breakpoint_location_function): Remove
1374         explicit_loc parameter.
1375         (momentary_breakpoint_from_master): Update call to
1376         set_breakpoint_location_function.
1377         (add_location_to_breakpoint): Likewise.
1378
1379 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1380
1381         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1382         required features based on default bfd type when no specific bfd
1383         is present.
1384
1385 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1386
1387         * NEWS: Mention that GDB printf and eval commands can now print
1388         C-style and Ada-style convenience var strings without
1389         calling the inferior.
1390         * printcmd.c (printf_c_string): Locally print GDB internal var
1391         instead of transiting via the inferior.
1392         (printf_wide_c_string): Likewise.
1393
1394 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1395
1396         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1397
1398 2019-07-04  Tom Tromey  <tom@tromey.com>
1399
1400         PR tui/24724:
1401         * tui/tui-winsource.c (tui_clear_source_content): Update.
1402         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1403         (tui_update_breakpoint_info): Update.
1404         (tui_set_exec_info_content): Update.
1405         * tui/tui-source.c (tui_set_source_content_nil): Update.
1406         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1407         has_break.
1408         * tui/tui-data.h (enum tui_bp_flag): New.
1409         (tui_bp_flags): New enum flags type.
1410         (struct tui_source_element) <break_mode>: Change type.  Rename
1411         from has_break.
1412         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1413         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1414         constants.
1415         * tui/tui-winsource.h: Fix comment.
1416
1417 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1418
1419         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1420         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1421         (store_fpregs_to_thread)
1422         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1423         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1424         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1425         (IWMMXT_REGS_SIZE): Add define.
1426         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1427         (fetch_vfp_regs, store_vfp_regs)
1428         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1429         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1430
1431 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1432
1433         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1434         defines.
1435         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1436         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1437         (ARM_INT_REGISTER_SIZE): ...to this.
1438         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1439         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1440         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1441         (arm_linux_collect_gregset, supply_nwfpe_register)
1442         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1443         defines.
1444         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1445         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1446         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1447         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1448         (arm_return_in_memory, arm_store_return_value)
1449         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1450         (arm_record_ld_st_multiple): Likewise.
1451         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1452         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1453
1454 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1455
1456         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1457         AARCH64_DISPLACED_MODIFIED_INSNS.
1458         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1459         (aarch64_displaced_step_copy_insn): Likewise.
1460         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1461         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1462         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1463         ARM_DISPLACED_MODIFIED_INSNS.
1464         * arm-tdep.c (arm_gdbarch_init): Likewise.
1465         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1466         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1467         (struct arm_displaced_step_closure): Use
1468         ARM_DISPLACED_MODIFIED_INSNS.
1469
1470 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1471
1472         * features/Makefile: Remove unused xml files.
1473         * features/aarch64.xml: Remove.
1474         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1475         * features/i386/amd64-avx-avx512.xml: Remove.
1476         * features/i386/amd64-avx-linux.xml: Remove.
1477         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1478         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1479         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1480         * features/i386/amd64-avx-mpx.xml: Remove.
1481         * features/i386/amd64-avx.xml: Remove.
1482         * features/i386/amd64-linux.xml: Remove.
1483         * features/i386/amd64-mpx-linux.xml: Remove.
1484         * features/i386/amd64-mpx.xml: Remove.
1485         * features/i386/amd64.xml: Remove.
1486         * features/i386/i386-avx-avx512-linux.xml: Remove.
1487         * features/i386/i386-avx-avx512.xml: Remove.
1488         * features/i386/i386-avx-linux.xml: Remove.
1489         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1490         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1491         * features/i386/i386-avx-mpx-linux.xml: Remove.
1492         * features/i386/i386-avx-mpx.xml: Remove.
1493         * features/i386/i386-avx.xml: Remove.
1494         * features/i386/i386-linux.xml: Remove.
1495         * features/i386/i386-mmx-linux.xml: Remove.
1496         * features/i386/i386-mmx.xml: Remove.
1497         * features/i386/i386-mpx-linux.xml: Remove.
1498         * features/i386/i386-mpx.xml: Remove.
1499         * features/i386/i386.xml: Remove.
1500         * features/i386/x32-avx-avx512-linux.xml: Remove.
1501         * features/i386/x32-avx-linux.xml: Remove.
1502         * features/i386/x32-linux.xml: Remove.
1503
1504 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1505
1506         * regformats/aarch64.dat: Remove.
1507         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1508         * regformats/i386/amd64-avx-linux.dat: Remove.
1509         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1510         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1511         * regformats/i386/amd64-linux.dat: Remove.
1512         * regformats/i386/amd64-mpx-linux.dat: Remove.
1513         * regformats/i386/amd64.dat: Remove.
1514         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1515         * regformats/i386/i386-avx-linux.dat: Remove.
1516         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1517         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1518         * regformats/i386/i386-linux.dat: Remove.
1519         * regformats/i386/i386-mmx-linux.dat: Remove.
1520         * regformats/i386/i386-mpx-linux.dat: Remove.
1521         * regformats/i386/i386.dat: Remove.
1522         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1523         * regformats/i386/x32-avx-linux.dat: Remove.
1524         * regformats/i386/x32-linux.dat: Remove.
1525
1526 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1527
1528         * aarch64-tdep.c: Remove xml self tests.
1529         * amd64-linux-tdep.c: Likewise.
1530         * amd64-tdep.c: Likewise.
1531         * i386-linux-tdep.c: Likewise.
1532         * i386-tdep.c: Likewise.
1533
1534 2019-07-03  Pedro Alves  <palves@redhat.com>
1535
1536         PR cli/24732
1537         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1538         (pipe_cmd_option_defs): New.
1539         (make_pipe_cmd_options_def_group): New.
1540         (pipe_command): Use gdb::option::process_options.
1541         (pipe_command_completer): New function.
1542         (_initialize_cli_cmds): Install completer for "pipe" command.
1543
1544 2019-07-03  Pedro Alves  <palves@redhat.com>
1545
1546         * cli/cli-option.c (union option_value) <string>: New field.
1547         (struct option_def_and_value): Add ctor, move ctor, dtor and
1548         use DISABLE_COPY_AND_ASSIGN.
1549         (option_def_and_value::clear_value): New.
1550         (parse_option, save_option_value_in_ctx, get_val_type_str)
1551         (add_setshow_cmds_for_options): Handle var_string.
1552         * cli-option.h (union option_def::var_address) <string>: New
1553         field.
1554         (struct string_option_def): New.
1555         * maint-test-options.c (struct test_options_opts): Add default
1556         ctor and use DISABLE_COPY_AND_ASSIGN.
1557         <string_opt>: New field.
1558         (test_options_opts::~test_options_opts): New.
1559         (test_options_opts::dump): Also dump "-string".
1560         (test_options_option_defs): Install "string.
1561
1562 2019-07-03  Pedro Alves  <palves@redhat.com>
1563
1564         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1565         option_value with a null enumeration.
1566         (complete_options): Save the option values in the context.
1567         (save_option_value_in_ctx): New, factored out from ...
1568         (process_options): ... here.
1569         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1570         of the function.
1571         * maint-test-options.c (test_options_opts::dump): New, factored
1572         out from ...
1573         (maintenance_test_options_command_mode): ... here.
1574         (maintenance_test_options_command_completion_result): Delete.
1575         (maintenance_test_options_command_completion_text): Update
1576         comment.
1577         (maintenance_show_test_options_completion_result): Change
1578         prototype.  Just print
1579         maintenance_test_options_command_completion_text.
1580         (save_completion_result): New.
1581         (maintenance_test_options_completer_mode): Pass options context to
1582         complete_options, and then save a dump.
1583         (_initialize_maint_test_options): Use add_cmd to install "maint
1584         show test-options-completion-result".
1585
1586 2019-07-03  Pedro Alves  <palves@redhat.com>
1587
1588         * NEWS (New commands): Mention "with" and "maint with".
1589         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1590         (with_command, with_command_completer): New.
1591         (pipe_command): Adjust to new repeat_previous
1592         interface.
1593         (_initialize_cli_cmds): Install the "with" command and its "w"
1594         alias.
1595         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1596         declarations.
1597         * cli/cli-setshow.c (parse_cli_var_uinteger)
1598         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1599         argument strings for all var_types.
1600         (get_setshow_command_value_string): New, factored out from ...
1601         (do_show_command): ... this.
1602         * cli/cli-setshow.h: Include <string>.
1603         (get_setshow_command_value_string): Declare.
1604         * command.h (repeat_previous): Now returns const char *.  Adjust
1605         comment.
1606         * maint.c: Include "cli/cli-cmds.h".
1607         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1608         (_initialize_maint_cmds): Register the "maintenance with" command.
1609         * top.c (repeat_previous): Move bits from pipe_command here:
1610         Return the saved command line, if any; error out if there's no
1611         command to relaunch.
1612
1613 2019-07-03  Pedro Alves  <palves@redhat.com>
1614
1615         * NEWS (New commands): Mention "maint set/show test-settings"
1616         instead of "maint test-settings".
1617         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1618         (maintenance_test_settings_set_list): Rename to ...
1619         (maintenance_set_test_settings_list): ... this.
1620         (maintenance_test_settings_show_list): Rename to  ...
1621         (maintenance_show_test_settings_list): ... this.
1622         (maintenance_test_settings_cmd): Delete.
1623         (maintenance_test_settings_set_cmd): ...
1624         (maintenance_set_test_settings_cmd): ... this.
1625         (maintenance_test_settings_show_cmd): ...
1626         (maintenance_show_test_settings_cmd): ... this.
1627         (maintenance_test_settings_show_value_cmd):
1628         (maintenance_show_test_settings_value_cmd): ... this.
1629         (_initialize_maint_test_settings): No longer install the "maint
1630         test-settings" prefix command.  Rename "maint test-settings set"
1631         to "maint set test-settings", and "maint test-settings show" to
1632         "maint show test-settings".  Adjust all subcommands.
1633
1634 2019-07-03  Pedro Alves  <palves@redhat.com>
1635
1636         * maint-test-settings.c: Fix file's intro comment.  Replace all
1637         references to "test-options" with references to "test-settings",
1638         in comments.
1639
1640 2019-07-03  Pedro Alves  <palves@redhat.com>
1641
1642         * maint-test-settings.c (maintenance_test_settings_xxx)
1643         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1644         New.
1645         (maintenance_test_settings_enums): Use them.
1646         (maintenance_test_settings_enum): Default to
1647         maintenance_test_settings_xxx.
1648         (_initialize_maint_test_settings): Initialize
1649         MAINTENANCE_TEST_SETTINGS_FILENAME.
1650
1651 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1652
1653         * breakpoint.h (remove_breakpoints_inf): Change return type to
1654         void, move function documentation here.
1655         * breakpoint.c (remove_breakpoints_inf): Change return type to
1656         void, move function documentation to header.
1657
1658 2019-07-02  Pedro Alves  <palves@redhat.com>
1659
1660         * NEWS (Completion improvements): Mention "info threads".
1661         * thread.c (struct info_threads_opts, info_threads_option_defs)
1662         (make_info_threads_options_def_group): New.
1663         (info_threads_command): Use gdb::option::process_options.
1664         (info_threads_command_completer): New.
1665         (_initialize_thread): Use gdb::option::build_help to build the
1666         help text for "info threads".
1667
1668 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1669
1670         * defs.h (generic_load): Move from here...
1671         * symfile.h (generic_load): ... to here.  Rename name parameter
1672         to args.
1673         * symfile.c (generic_load): Add comment.
1674
1675 2019-07-01  Tom Tromey  <tromey@adacore.com>
1676
1677         * dwarf2read.c
1678         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1679         declaration of without_params.  Fix formatting.
1680
1681 2019-07-01  Tom Tromey  <tromey@adacore.com>
1682
1683         * ada-exp.y (find_primitive_type): Update.
1684         * ada-lang.h (ada_lookup_symbol): Update.
1685         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1686         parameter.
1687         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1688
1689 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1690
1691         PR breakpoints/24541
1692         * gdbarch.c: Regenerate.
1693         * gdbarch.h: Regenerate.
1694         * gdbarch.sh: Add 'stap_adjust_register'.
1695         * i386-tdep.c: Include '<unordered_set>'.
1696         (i386_stap_adjust_register): New function.
1697         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1698         * stap-probe.c (stap_parse_register_operand): Call
1699         'gdbarch_stap_adjust_register'.
1700
1701 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1702
1703         PR python/24742
1704         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1705         * python/python.c (do_start_initialization): Use 'xmalloc'
1706         instead of 'PyMem_Malloc'.
1707
1708 2019-06-28  Tom Tromey  <tromey@adacore.com>
1709
1710         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1711         for Ada.
1712
1713 2019-06-27  Tom Tromey  <tromey@adacore.com>
1714
1715         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1716         objfile_key.
1717         (arm_find_mapping_symbol, arm_record_special_symbol)
1718         (_initialize_arm_tdep): Update.
1719         (arm_objfile_data_free): Remove.
1720
1721 2019-06-27  Tom Tromey  <tromey@adacore.com>
1722
1723         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1724         to cp_print_static_field.
1725
1726 2019-06-26  Tom Tromey  <tromey@adacore.com>
1727
1728         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1729         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1730         declare.
1731
1732 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1733
1734         * features/aarch64-core.c (create_feature_aarch64_core):
1735         Regenerate.
1736         * features/aarch64-core.xml: Add cpsr flags.
1737
1738 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1739
1740         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1741         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1742
1743 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1744
1745         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1746         field.
1747         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1748         use.
1749         (arm_record_special_symbol): Don't insert new symbol in sorted
1750         position, push it at the end.
1751
1752 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1753
1754         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1755         (arm_mapping_symbol_s): Remove.
1756         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1757         (arm_mapping_symbol_vec): New typedef.
1758         (struct arm_per_objfile): Add constructor.
1759         <section_maps>: Change type to
1760         std::unique_ptr<arm_mapping_symbol_vec[]>.
1761         (arm_compare_mapping_symbols): Remove.
1762         (arm_find_mapping_symbol): Adjust to section_maps type change.
1763         (arm_objfile_data_free): Call delete on arm_per_objfile.
1764         (arm_record_special_symbol): Adjust to section_maps type change.
1765         Allocate arm_per_objfile with new.
1766
1767 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1768
1769         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1770         with the command prefix.
1771
1772 2019-06-25  Tom Tromey  <tom@tromey.com>
1773
1774         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1775         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1776
1777 2019-06-25  Tom Tromey  <tom@tromey.com>
1778
1779         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1780         type.
1781         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1782         protected.
1783
1784 2019-06-25  Tom Tromey  <tom@tromey.com>
1785
1786         * tui/tui-winsource.c
1787         (tui_source_window_base::set_is_exec_point_at): Add check against
1788         LOA_ADDRESS.
1789
1790 2019-06-25  Tom Tromey  <tom@tromey.com>
1791
1792         * tui/tui-source.c (tui_set_source_content): Don't check before
1793         xfree.
1794         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1795
1796 2019-06-25  Tom Tromey  <tom@tromey.com>
1797
1798         * tui/tui-winsource.h (tui_update_source_window_as_is)
1799         (tui_alloc_source_buffer, tui_line_is_displayed)
1800         (tui_addr_is_displayed): Change type of win_info.
1801         * tui/tui-winsource.c (tui_update_source_window_as_is)
1802         (tui_clear_source_content, tui_show_source_line)
1803         (tui_show_source_content, tui_source_window_base::refill)
1804         (tui_source_window_base::set_is_exec_point_at)
1805         (tui_source_window_base::set_is_exec_point_at)
1806         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1807         (tui_alloc_source_buffer, tui_line_is_displayed)
1808         (tui_addr_is_displayed): Change type of win_info.  Update.
1809         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1810         (tui_source_window_base::do_make_visible_with_new_height):
1811         Update.
1812         * tui/tui-source.c (tui_set_source_content)
1813         (tui_set_source_content_nil)
1814         (tui_source_window::do_scroll_vertical): Update.
1815         * tui/tui-layout.c (show_layout): Update.
1816         * tui/tui-disasm.c (tui_set_disassem_content)
1817         (tui_disasm_window::do_scroll_vertical): Update.
1818         * tui/tui-data.h (tui_win_content): Remove.
1819         (struct tui_gen_win_info) <content, content_size>: Remove.
1820         (struct tui_source_element): Add initializers and destructor.
1821         (union tui_which_element, struct tui_win_element): Remove.
1822         (struct tui_source_window_base) <content>: New field.
1823         (struct tui_data_window): Remove destructor.
1824         (tui_alloc_content, tui_free_win_content)
1825         (tui_free_all_source_wins_content): Don't declare.
1826         * tui/tui-data.c (tui_initialize_static_data): Update.
1827         (init_content_element, tui_alloc_content): Remove.
1828         (~tui_gen_win_info): Update.
1829         (~tui_data_window, tui_free_all_source_wins_content)
1830         (tui_free_win_content, free_content, free_content_elements):
1831         Remove.
1832
1833 2019-06-25  Tom Tromey  <tom@tromey.com>
1834
1835         * tui/tui-winsource.h (tui_clear_source_content)
1836         (tui_erase_source_content, tui_show_source_content): Change type
1837         of win_info.
1838         * tui/tui-winsource.c (tui_clear_source_content)
1839         (tui_erase_source_content, tui_show_source_content): Change type
1840         of win_info.
1841         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1842         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1843         win_info.
1844         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1845         win_info.
1846         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1847
1848 2019-06-25  Tom Tromey  <tom@tromey.com>
1849
1850         * tui/tui-winsource.c (tui_clear_source_content)
1851         (tui_source_window_base::set_is_exec_point_at): Update.
1852         * tui/tui-source.c (tui_set_source_content_nil): Update.
1853         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1854         a bool.
1855         * tui/tui-data.c (init_content_element): Update.
1856
1857 2019-06-25  Tom Tromey  <tom@tromey.com>
1858
1859         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1860         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1861         * tui/tui-layout.c (init_and_make_win): Update.
1862         * tui/tui.h (enum tui_win_type): Update.
1863         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1864         tui_win_is_auxillary.
1865         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1866         tui_win_is_auxillary.
1867
1868 2019-06-25  Tom Tromey  <tom@tromey.com>
1869
1870         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1871         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1872         (tui_delete_data_content_windows, tui_display_all_data)
1873         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1874         Update.
1875         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1876         * tui/tui-regs.c (tui_last_regs_line_no)
1877         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1878         (tui_show_registers): Update.
1879         (tui_show_register_group): Return void.  Update.
1880         (tui_display_registers_from, tui_display_reg_element_at_line)
1881         (tui_display_registers_from_line, tui_check_register_values):
1882         Update.
1883         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1884         member.
1885         (struct tui_data_window) <regs_content>: Now a std::vector.
1886         <regs_content_count>: Remove.
1887         (tui_add_content_elements, tui_free_data_content): Don't declare.
1888         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1889         (init_content_element): Remove DATA_WIN case.  Add assert.
1890         (tui_add_content_elements): Remove.
1891         (tui_data_window): Update.
1892         (tui_free_data_content): Remove.
1893         (free_content_elements): Remove DATA_WIN case.
1894
1895 2019-06-25  Tom Tromey  <tom@tromey.com>
1896
1897         * tui/tui-data.c (tui_data_item_window): Update.
1898         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1899         * tui/tui-windata.c (tui_display_all_data)
1900         (tui_display_data_from_line): Update.
1901         (tui_check_data_values): Remove.
1902         * tui/tui-regs.c (tui_show_register_group)
1903         (tui_display_reg_element_at_line): Update.
1904         * tui/tui-hooks.c (tui_register_changed)
1905         (tui_refresh_frame_and_register_information): Call
1906         tui_check_register_values.
1907         * tui/tui-data.h (struct tui_data_window) <data_content,
1908         data_content_count, data_type>: Remove.
1909         (enum tui_data_type): Remove.
1910
1911         * tui/tui-data.c (tui_data_window::clear_detail)
1912         (~tui_data_window): Update.
1913
1914 2019-06-25  Tom Tromey  <tom@tromey.com>
1915
1916         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1917         declare.
1918         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1919         Rename from tui_first_data_item_displayed.  Update.
1920         (tui_data_window::refresh_all)
1921         (tui_data_window::do_scroll_vertical): Update.
1922         * tui/tui-data.h (struct tui_data_window)
1923         <first_data_item_displayed>: Declare new method.
1924
1925 2019-06-25  Tom Tromey  <tom@tromey.com>
1926
1927         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1928         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1929         contents...
1930         (tui_initialize_static_data): ...here.
1931
1932 2019-06-25  Tom Tromey  <tom@tromey.com>
1933
1934         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1935         (tui_display_registers_from, tui_check_register_values): Update.
1936         (tui_display_register): Remove win_info parameter; update.
1937         (tui_get_register): Change type of parameters.
1938         * tui/tui-data.h (struct tui_data_element): Remove.
1939         (union tui_which_element) <data>: Remove.
1940         <data_window>: Change type.
1941         (struct tui_data_item_window): New.
1942         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1943         case.  Add assert.
1944         (~tui_data_item_window): New destructor.
1945         (free_content_elements): Remove DATA_ITEM_WIN case.
1946
1947 2019-06-25  Tom Tromey  <tom@tromey.com>
1948
1949         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1950         Remove.
1951
1952 2019-06-25  Tom Tromey  <tom@tromey.com>
1953
1954         * tui/tui-data.h (struct tui_command_element): Remove.
1955         (union tui_which_element) <command>: Remove.
1956         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1957         assert.
1958         (free_content_elements): Remove CMD_WIN case.
1959
1960 2019-06-25  Tom Tromey  <tom@tromey.com>
1961
1962         * tui/tui-layout.c (tui_set_layout): Update.
1963         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1964         * tui/tui-data.c (layout_def): Update.
1965
1966 2019-06-25  Tom Tromey  <tom@tromey.com>
1967
1968         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1969         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1970         (tui_source_window_base::set_new_height): Update.
1971         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1972         Update.
1973         (tui_set_locator_fullname, tui_set_locator_info)
1974         (tui_show_frame_info): Update.
1975         * tui/tui-source.c (tui_set_source_content)
1976         (tui_source_is_displayed): Update.
1977         * tui/tui-layout.c (show_source_disasm_command, show_data)
1978         (show_source_or_disasm_and_command): Update.
1979         * tui/tui-disasm.c (tui_set_disassem_content)
1980         (tui_get_begin_asm_address): Update.
1981         * tui/tui-data.h (struct tui_locator_element): Remove.
1982         (union tui_which_element) <locator>: Remove.
1983         (struct tui_locator_window): New.
1984         (tui_locator_win_info_ptr): Change return type.
1985         * tui/tui-data.c (_locator): Change type.
1986         (tui_locator_win_info_ptr): Change return type.
1987         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1988         (tui_alloc_content): Add assert.
1989
1990 2019-06-25  Tom Tromey  <tom@tromey.com>
1991
1992         * tui/tui-winsource.c
1993         (tui_exec_info_window::maybe_allocate_content): New method.
1994         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1995         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1996         (make_source_or_disasm_window): Add cast.
1997         * tui/tui-data.h (union tui_which_element) <simple_string>:
1998         Remove.
1999         (struct tui_source_info): New.
2000         (struct tui_source_window_base) <execution_info>: Change type.
2001         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2002         case, and add assert.
2003         (tui_alloc_content): Add assert.
2004
2005 2019-06-25  Tom Tromey  <tom@tromey.com>
2006
2007         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2008         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2009         * tui/tui-data.c (tui_alloc_win_info): Remove.
2010
2011 2019-06-25  Tom Tromey  <tom@tromey.com>
2012
2013         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2014         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2015         can_highlight.
2016
2017 2019-06-25  Tom Tromey  <tom@tromey.com>
2018
2019         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2020         make_visible_with_new_height method.
2021         (tui_win_info::make_visible_with_new_height): New method.
2022         (tui_source_window_base::do_make_visible_with_new_height)
2023         (tui_data_window::do_make_visible_with_new_height)
2024         (tui_cmd_window::do_make_visible_with_new_height): New methods.
2025         (make_visible_with_new_height): Remove.
2026         (tui_resize_all, tui_adjust_win_heights): Use
2027         make_visible_with_new_height method.
2028         * tui/tui-data.h (struct tui_win_info)
2029         <do_make_visible_with_new_height, make_visible_with_new_height>:
2030         New methods.
2031         (struct tui_source_window_base, struct tui_data_window)
2032         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2033         methods.
2034
2035 2019-06-25  Tom Tromey  <tom@tromey.com>
2036
2037         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2038         method.
2039         (update_tab_width): Call update_tab_width method.
2040         * tui/tui-data.h (struct tui_win_info)
2041         (struct tui_source_window_base) <update_tab_width>: New methods.
2042
2043 2019-06-25  Tom Tromey  <tom@tromey.com>
2044
2045         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2046         parameter.
2047         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2048         parameter.
2049         (tui_gen_win_info::make_visible): Update.
2050         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2051         parameter.
2052         * tui/tui-data.h (enum tui_box): New enum.
2053         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2054
2055 2019-06-25  Tom Tromey  <tom@tromey.com>
2056
2057         * tui/tui-layout.c (make_source_or_disasm_window): Always use
2058         init_and_make_win for EXEC_INFO_WIN.
2059         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2060         longer inline.
2061         (struct tui_win_info) <~tui_win_info>: Inline.
2062         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2063         Don't declare.
2064         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2065         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2066         Remove.
2067         (tui_initialize_static_data): Update.
2068         (~tui_gen_win_info): Handle more cleanup here.
2069         (~tui_source_window_base): Delete "execution_info".
2070         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2071
2072 2019-06-25  Tom Tromey  <tom@tromey.com>
2073
2074         * tui/tui-layout.c (make_command_window): Don't set
2075         can_highlight.
2076         (show_source_disasm_command): Call the reset method.
2077         (show_data): Don't set can_highlight.  Call the reset method.
2078         (tui_gen_win_info::reset): Rename from init_gen_win_info
2079         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2080         (show_source_or_disasm_and_command): Call the reset method.
2081         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2082         (struct tui_cmd_window): Set can_highlight.
2083
2084 2019-06-25  Tom Tromey  <tom@tromey.com>
2085
2086         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2087         from make_visible.
2088         (tui_make_visible, tui_make_invisible): Rewrite.
2089         (tui_win_info::make_visible): Remove.
2090         (tui_source_window_base::make_visible): Update.
2091         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2092         method.  Moved from...
2093         (struct tui_win_info) <make_visible>: ...here.
2094
2095 2019-06-25  Tom Tromey  <tom@tromey.com>
2096
2097         * tui/tui-winsource.c
2098         (tui_source_window_base::do_scroll_horizontal): Remove direction
2099         parameter.
2100         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2101         direction parameter.
2102         * tui/tui-win.c (tui_win_info::forward_scroll)
2103         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2104         (tui_win_info::right_scroll): Update.
2105         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2106         direction parameter.
2107         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2108         direction parameter.
2109         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2110         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2111         Remove direction parameter.
2112         (struct tui_source_window_base, struct tui_source_window)
2113         (struct tui_disasm_window, struct tui_data_window)
2114         (struct tui_cmd_window): Update.
2115
2116 2019-06-25  Tom Tromey  <tom@tromey.com>
2117
2118         * tui/tui-winsource.h (tui_set_exec_info_content)
2119         (tui_show_exec_info_content, tui_erase_exec_info_content)
2120         (tui_clear_exec_info_content, tui_update_exec_info): Change
2121         argument to tui_source_window_base.
2122         * tui/tui-winsource.c (tui_set_exec_info_content)
2123         (tui_show_exec_info_content, tui_erase_exec_info_content)
2124         (tui_clear_exec_info_content, tui_update_exec_info): Change
2125         argument to tui_source_window_base.
2126
2127 2019-06-25  Tom Tromey  <tom@tromey.com>
2128
2129         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2130         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2131
2132 2019-06-25  Tom Tromey  <tom@tromey.com>
2133
2134         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2135         check.
2136
2137 2019-06-25  Tom Tromey  <tom@tromey.com>
2138
2139         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2140         type to void.
2141         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2142         type to void.
2143         * tui/tui-source.c (tui_set_source_content): Update.
2144         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2145
2146 2019-06-25  Tom Tromey  <tom@tromey.com>
2147
2148         * tui/tui-win.c (window_name_completer, tui_set_focus)
2149         (tui_all_windows_info): Use name method.
2150         * tui/tui-data.h (struct tui_gen_win_info)
2151         (struct tui_source_window, struct tui_disasm_window)
2152         (struct tui_data_window, struct tui_cmd_window) <name>: New
2153         method.
2154         (tui_win_name): Don't declare.
2155         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2156         (tui_win_name): Remove.
2157
2158 2019-06-25  Tom Tromey  <tom@tromey.com>
2159
2160         * tui/tui-winsource.h (tui_update_source_window)
2161         (tui_update_source_window_as_is): Change parameter type.
2162         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2163         to be a tui_source_window_base.
2164         (tui_update_source_window_as_is): Likewise.
2165         * tui/tui-win.c (make_visible_with_new_height): Update.
2166
2167 2019-06-25  Tom Tromey  <tom@tromey.com>
2168
2169         * tui/tui-winsource.c (tui_erase_source_content)
2170         (tui_show_source_content, tui_show_exec_info_content)
2171         (tui_erase_exec_info_content): Use refresh_window method.
2172         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2173         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2174         from tui_refresh_win.
2175         (tui_data_window::refresh_window): New method.
2176         (tui_win_info::refresh, tui_source_window_base::refresh)
2177         (tui_refresh_all): Use refresh_window method.
2178         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2179         method.
2180         * tui/tui-regs.c (tui_display_register): Call refresh_window
2181         method.
2182         * tui/tui-layout.c (show_source_disasm_command)
2183         (show_source_or_disasm_and_command): Call refresh_window method.
2184         * tui/tui-data.h (struct tui_gen_win_info)
2185         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2186         New method.
2187
2188 2019-06-25  Tom Tromey  <tom@tromey.com>
2189
2190         * tui/tui.c (tui_rl_other_window, tui_enable)
2191         (tui_is_window_visible, tui_get_command_dimension): Update.
2192         * tui/tui-winsource.c (tui_update_source_window_as_is)
2193         (tui_clear_source_content, tui_erase_source_content)
2194         (tui_show_source_line, tui_source_window_base::refill)
2195         (tui_source_window_base::do_scroll_horizontal)
2196         (tui_source_window_base::set_is_exec_point_at)
2197         (tui_update_breakpoint_info, tui_set_exec_info_content)
2198         (tui_alloc_source_buffer, tui_line_is_displayed)
2199         (tui_addr_is_displayed): Update.
2200         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2201         (tui_check_and_display_highlight_if_needed)
2202         (tui_win_info::make_visible, tui_win_info::refresh)
2203         (tui_refresh_all): Update.
2204         * tui/tui-windata.c (tui_first_data_item_displayed)
2205         (tui_delete_data_content_windows, tui_erase_data_content)
2206         (tui_display_all_data, tui_data_window::refresh_all)
2207         (tui_check_data_values): Update.
2208         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2209         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2210         (tui_win_info::backward_scroll, tui_refresh_all_win)
2211         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2212         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2213         (tui_source_window_base::set_new_height)
2214         (tui_data_window::set_new_height)
2215         (make_invisible_and_set_new_height)
2216         (make_visible_with_new_height, new_height_ok)
2217         (parse_scrolling_args): Update.
2218         * tui/tui-stack.c (tui_show_frame_info): Update.
2219         * tui/tui-source.c (tui_set_source_content)
2220         (tui_set_source_content_nil, tui_source_is_displayed)
2221         (tui_source_window::do_scroll_vertical): Update.
2222         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2223         (tui_display_registers_from, tui_display_reg_element_at_line)
2224         (tui_check_register_values, tui_reg_command): Update.
2225         * tui/tui-layout.c (tui_default_win_height)
2226         (show_source_disasm_command, show_data, init_and_make_win)
2227         (show_source_or_disasm_and_command): Update.
2228         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2229         (tui_redisplay_readline, tui_mld_flush)
2230         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2231         (tui_getc): Update.
2232         * tui/tui-disasm.c (tui_set_disassem_content)
2233         (tui_disasm_window::do_scroll_vertical): Update.
2234         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2235         Now virtual.
2236         (struct tui_win_info): Derive from tui_gen_win_info.
2237         <~tui_win_info>: Mark as override.
2238         <generic>: Remove member.
2239         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2240         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2241         (~tui_data_window, ~tui_win_info)
2242         (tui_free_all_source_wins_content): Update.
2243         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2244
2245 2019-06-25  Tom Tromey  <tom@tromey.com>
2246
2247         * tui/tui-layout.c (init_and_make_win): Use new.
2248         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2249         destructor, initializers.
2250         (tui_alloc_generic_win_info): Don't declare.
2251         * tui/tui-data.c (_locator): Add argument to constructor.
2252         (source_win, disasm_win): New globals.
2253         (exec_info): Remove.
2254         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2255         Update.
2256         (tui_alloc_generic_win_info): Remove.
2257         (init_content_element): Use new.
2258         (tui_win_info::tui_win_info): Update.
2259         (free_content_elements) <case DATA_WIN>: Use delete.
2260
2261 2019-06-25  Tom Tromey  <tom@tromey.com>
2262
2263         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2264         * tui/tui-windata.c (tui_first_data_item_displayed)
2265         (tui_delete_data_content_windows): Update.
2266         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2267         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2268         (tui_display_registers_from, tui_check_register_values): Update.
2269         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2270         pointer.
2271         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2272         window.
2273         (tui_free_data_content): Update.
2274         (free_content_elements) <case DATA_WIN>: Free the window.
2275
2276 2019-06-25  Tom Tromey  <tom@tromey.com>
2277
2278         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2279         Update.
2280         * tui/tui-layout.c (make_command_window)
2281         (show_source_disasm_command, show_data, init_and_make_win)
2282         (show_source_or_disasm_and_command): Update.
2283         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2284         method.
2285         <can_highight, is_highlighted>: Now bool.
2286         (tui_set_win_highlight): Don't declare.
2287         * tui/tui-data.c (tui_set_win_highlight): Remove.
2288
2289 2019-06-25  Tom Tromey  <tom@tromey.com>
2290
2291         * tui/tui-wingeneral.c (make_visible): Remove check of window
2292         type.
2293
2294 2019-06-25  Tom Tromey  <tom@tromey.com>
2295
2296         * tui/tui-win.c (tui_win_info::max_height)
2297         (tui_cmd_window::max_height): New methods.
2298         (new_height_ok): Call max_height.
2299         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2300         <max_height>: New method.
2301
2302 2019-06-25  Tom Tromey  <tom@tromey.com>
2303
2304         * tui/tui-win.c (tui_source_window_base::set_new_height)
2305         (tui_data_window::set_new_height): New methods.
2306         (make_invisible_and_set_new_height): Call set_new_height method.
2307         * tui/tui-data.h (struct tui_win_info)
2308         (struct tui_source_window_base, struct tui_data_window)
2309         <set_new_height>: New method.
2310
2311 2019-06-25  Tom Tromey  <tom@tromey.com>
2312
2313         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2314         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2315         tui_refresh_data_win.
2316         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2317         method.
2318         (tui_refresh_all_win): Call the refresh_all method.
2319         (tui_set_focus): Likewise.
2320         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2321         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2322         Likewise.
2323
2324 2019-06-25  Tom Tromey  <tom@tromey.com>
2325
2326         * tui/tui-winsource.h (tui_refill_source_window)
2327         (tui_set_is_exec_point_at): Don't declare.
2328         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2329         (tui_source_window_base::refill): Rename from
2330         tui_refill_source_window.
2331         (tui_source_window_base::do_scroll_horizontal): Update.
2332         (tui_source_window_base::set_is_exec_point_at): Rename from
2333         tui_set_is_exec_point_at.
2334         (tui_update_all_breakpoint_info): Update.
2335         * tui/tui-stack.c (tui_show_frame_info): Update.
2336         * tui/tui-layout.c (show_data): Add cast.
2337         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2338         * tui/tui-data.h (struct tui_source_window_base) <refill,
2339         set_is_exec_point_at>: New methods.
2340         (tui_source_windows, tui_add_to_source_windows): Update types.
2341         (tui_add_to_source_windows): Remove redundant declaration.
2342         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2343         (tui_source_windows): Change return type.
2344         (tui_clear_source_windows_detail): Update.
2345         (tui_add_to_source_windows): Change type of parameter.
2346         (tui_free_all_source_wins_content): Update.
2347
2348 2019-06-25  Tom Tromey  <tom@tromey.com>
2349
2350         * tui/tui-wingeneral.c (tui_win_info::refresh)
2351         (tui_source_window_base::refresh): New methods.
2352         (tui_refresh_all): Call the refresh method.
2353         * tui/tui-data.h (struct tui_win_info)
2354         (struct tui_source_window_base) <refresh>: New method.
2355
2356 2019-06-25  Tom Tromey  <tom@tromey.com>
2357
2358         * tui/tui.h (tui_is_window_visible): Return bool.
2359         * tui/tui.c (tui_is_window_visible): Return bool.
2360         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2361         (tui_make_visible, tui_make_invisible)
2362         (tui_win_info::make_visible)
2363         (tui_source_window_base::make_visible, make_all_visible)
2364         (tui_make_all_visible, tui_make_all_invisible): Update.
2365         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2366         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2367         bool.
2368         (struct tui_win_info, struct tui_source_window_base)
2369         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2370         * tui/tui-data.c (tui_init_generic_part): Update.
2371
2372 2019-06-25  Tom Tromey  <tom@tromey.com>
2373
2374         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2375         (tui_source_window_base::make_visible): New methods.
2376         (make_all_visible): Make method call.
2377         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2378         (struct tui_source_window_base, struct tui_cmd_window): Override
2379         make_visible.
2380         (tui_win_is_source_type): Don't declare.
2381         * tui/tui-data.c (tui_win_is_source_type): Remove.
2382
2383 2019-06-25  Tom Tromey  <tom@tromey.com>
2384
2385         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2386         NULL check.
2387
2388 2019-06-25  Tom Tromey  <tom@tromey.com>
2389
2390         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2391         Inline constructor.  Add initializers for members.
2392         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2393         constructors; now inline in class.
2394
2395 2019-06-25  Tom Tromey  <tom@tromey.com>
2396
2397         * tui/tui-regs.c (tui_show_registers): Update.
2398         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2399         bool.
2400         * tui/tui-data.c (tui_data_window::clear_detail)
2401         (tui_data_window): Update.
2402
2403 2019-06-25  Tom Tromey  <tom@tromey.com>
2404
2405         * tui/tui-windata.c (tui_display_all_data)
2406         (tui_display_data_from_line, tui_display_data_from)
2407         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2408         Update.
2409         * tui/tui-regs.c (tui_last_regs_line_no)
2410         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2411         (tui_show_registers, tui_show_register_group)
2412         (tui_display_registers_from, tui_display_reg_element_at_line)
2413         (tui_display_registers_from_line, tui_check_register_values)
2414         (tui_reg_next, tui_reg_prev): Update.
2415         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2416         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2417         tui_data_window.
2418         (struct tui_win_info) <detail>: Remove.  Add new fields from
2419         tui_data_info.
2420         (TUI_DATA_WIN): Add cast.
2421         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2422         (~tui_data_window): Simplify.
2423
2424 2019-06-25  Tom Tromey  <tom@tromey.com>
2425
2426         * tui/tui-layout.c (show_source_disasm_command)
2427         (show_source_or_disasm_and_command): Update.
2428         * tui/tui-io.c (update_cmdwin_start_line)
2429         (tui_redisplay_readline): Update.
2430         * tui/tui-data.h (struct tui_command_info): Remove.
2431         (struct tui_win_info) <detail>: Remove command_info member.
2432         (struct tui_data_window) <start_line>: New member, from
2433         tui_command_info.
2434         (TUI_CMD_WIN): Add casts.
2435
2436 2019-06-25  Tom Tromey  <tom@tromey.com>
2437
2438         * tui/tui-winsource.c (tui_update_source_window)
2439         (tui_refill_source_window)
2440         (tui_source_window_base::do_scroll_horizontal)
2441         (tui_update_breakpoint_info, tui_set_exec_info_content)
2442         (tui_show_exec_info_content, tui_erase_exec_info_content)
2443         (tui_clear_exec_info_content): Update.
2444         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2445         Update.
2446         * tui/tui-win.c (make_invisible_and_set_new_height)
2447         (make_visible_with_new_height): Update.
2448         * tui/tui-source.c (tui_set_source_content)
2449         (tui_show_symtab_source): Update.
2450         * tui/tui-layout.c (extract_display_start_addr)
2451         (show_source_disasm_command, show_data)
2452         (make_source_or_disasm_window)
2453         (show_source_or_disasm_and_command): Update.
2454         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2455         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2456         "gdbarch".
2457         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2458         to tui_source_window_base.
2459         (struct tui_win_info) <detail>: Remove source_info member.
2460         (struct tui_source_window_base) <has_locator>: Inline.
2461         Move contents from tui_source_info; rename has_locator member to
2462         m_has_locator.
2463         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2464         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2465         header file.
2466         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2467         Simplify.
2468         (tui_free_all_source_wins_content): Cast to
2469         tui_source_window_base.
2470
2471 2019-06-25  Tom Tromey  <tom@tromey.com>
2472
2473         * tui/tui-win.c (make_invisible_and_set_new_height)
2474         (make_visible_with_new_height): Call has_locator method.
2475         * tui/tui-layout.c (show_source_disasm_command, show_data)
2476         (show_source_or_disasm_and_command): Update for bool change.
2477         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2478         (tui_win_info) <has_locator>: New method.
2479         (struct tui_source_window_base) <has_locator>: New method.
2480         (tui_win_has_locator): Don't declare.
2481         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2482         from tui_win_has_locator.
2483         (tui_source_window_base): Use false, not FALSE.
2484
2485 2019-06-25  Tom Tromey  <tom@tromey.com>
2486
2487         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2488         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2489         clear_detail method directly.
2490         (tui_clear_win_detail): Remove.
2491
2492 2019-06-25  Tom Tromey  <tom@tromey.com>
2493
2494         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2495         "this", not TUI_DISASM_WIN.
2496
2497 2019-06-25  Tom Tromey  <tom@tromey.com>
2498
2499         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2500         declare.
2501         * tui/tui-winsource.c
2502         (tui_source_window_base::do_scroll_horizontal): Rename from
2503         tui_horizontal_source_scroll.
2504         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2505         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2506         from tui_vertical_data_scroll.
2507         * tui/tui-win.h (tui_scroll): Don't declare.
2508         * tui/tui-win.c (tui_win_info::forward_scroll)
2509         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2510         (tui_win_info::right_scroll): Rename and update.
2511         (tui_scroll_forward_command, tui_scroll_backward_command)
2512         (tui_scroll_left_command, tui_scroll_right_command): Update.
2513         (tui_scroll): Remove.
2514         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2515         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2516         from tui_vertical_source_scroll.
2517         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2518         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2519         from tui_vertical_disassem_scroll.
2520         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2521         do_scroll_horizontal>: New methods.
2522         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2523         Likewise.
2524         (struct tui_source_window_base): Add do_scroll_horizontal.
2525         (struct tui_source_window, struct tui_disasm_window): Add
2526         do_scroll_vertical.
2527         (struct tui_data_window, struct tui_cmd_window): Add
2528         do_scroll_horizontal and do_scroll_vertical.
2529         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2530
2531 2019-06-25  Tom Tromey  <tom@tromey.com>
2532
2533         * tui/tui-data.h (struct tui_source_window_base): New struct.
2534         (struct tui_source_window): Derive from tui_source_window_base.
2535         (struct tui_disasm_window): New struct.
2536         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2537         from tui_source_window::clear_detail.
2538         (tui_source_window_base): Rename from tui_source_window.
2539         (~tui_source_window_base): Rename from ~tui_source_window.
2540         (tui_alloc_win_info): Create a tui_disasm_window.
2541
2542 2019-06-25  Tom Tromey  <tom@tromey.com>
2543
2544         * tui/tui-data.h (struct tui_source_window)
2545         (struct tui_data_window): Declare destructors.
2546         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2547         destructors.
2548         (tui_win_info): Simplify.
2549
2550 2019-06-25  Tom Tromey  <tom@tromey.com>
2551
2552         * tui/tui-winsource.c (tui_display_main)
2553         (tui_update_source_windows_with_addr)
2554         (tui_update_all_breakpoint_info): Update.
2555         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2556         (new_height_ok, parse_scrolling_args): Update.
2557         * tui/tui-stack.c (tui_show_frame_info): Update.
2558         * tui/tui-data.h (struct tui_list): Remove.
2559         (tui_source_windows): Return a reference to a std::vector.
2560         * tui/tui-data.c (source_windows): Now a std::vector.
2561         (tui_source_windows): Change return type.
2562         (tui_clear_source_windows): Rewrite.
2563         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2564         (tui_free_all_source_wins_content): Rewrite.
2565
2566 2019-06-25  Tom Tromey  <tom@tromey.com>
2567
2568         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2569         (struct tui_data_window, struct tui_cmd_window): Declare
2570         clear_detail method.
2571         * tui/tui-data.c (tui_source_window::clear_detail)
2572         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2573         methods.
2574         (tui_clear_win_detail): Simplify.
2575
2576 2019-06-25  Tom Tromey  <tom@tromey.com>
2577
2578         * tui/tui-layout.c (make_source_window, make_disasm_window)
2579         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2580         Return the new window.
2581         (show_source_disasm_command, show_data)
2582         (show_source_or_disasm_and_command): Update.
2583
2584 2019-06-25  Tom Tromey  <tom@tromey.com>
2585
2586         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2587         parameter.  Return the new window.
2588         (show_source_disasm_command): Update and remove NULL check.
2589         (show_source_or_disasm_and_command): Update.
2590
2591 2019-06-25  Tom Tromey  <tom@tromey.com>
2592
2593         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2594
2595 2019-06-25  Tom Tromey  <tom@tromey.com>
2596
2597         * tui/tui-data.h (struct tui_win_info): Make constructor
2598         protected.  Make destructor virtual.  Add initializers.
2599         (tui_source_window, tui_data_window, tui_cmd_window): New
2600         classes.
2601         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2602         constructor.  Add "type" parameter.
2603         (tui_source_window, tui_data_window, tui_cmd_window): New
2604         constructors.
2605         (tui_alloc_win_info): Instantiate the appropriate subclass.
2606
2607 2019-06-25  Tom Tromey  <tom@tromey.com>
2608
2609         * tui/tui-win.c (tui_resize_all): Use delete.
2610         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2611         destructor.
2612         (tui_free_window): Don't declare.
2613         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2614         Update.
2615
2616 2019-06-25  Tom Tromey  <tom@tromey.com>
2617
2618         * tui/tui-data.h (struct tui_win_info): Add constructor.
2619         * tui/tui-data.c (tui_alloc_win_info): Use new.
2620         (tui_free_window): Use delete.
2621
2622 2019-06-22  Tom Tromey  <tom@tromey.com>
2623
2624         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2625         declare.
2626         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2627
2628 2019-06-22  Tom Tromey  <tom@tromey.com>
2629
2630         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2631         declare.
2632         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2633
2634 2019-06-22  Tom de Vries  <tdevries@suse.de>
2635
2636         * dwarf2read.c (create_addrmap_from_aranges)
2637         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2638         instead of '%zu'.
2639
2640 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2641
2642         * dwarf2read.h (dwarf2_section_info_def): Remove.
2643         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2644         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2645         std::vector<dwarf2_section_info>.
2646         (struct dwo_file) <~dwo_file>: Remove.
2647         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2648         types field.
2649         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2650         (dwarf2_read_debug_names): Likewise.
2651         (create_debug_types_hash_table): Change parameter type to
2652         array_view, adjust code accordingly.
2653         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2654         (partial_die_info::fixup): Likewise.
2655         (determine_prefix): Likewise.
2656         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2657
2658 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2659
2660         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2661         gdb_bfd_ref_ptr.
2662         <~dwo_file>: Remove call to gdb_bfd_unref.
2663         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2664         gdb_bfd_ref_ptr::get.
2665
2666 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2667
2668         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2669         type to htab_up.
2670         * dwarf2read.c (struct dwo_file): Initialize fields.
2671         <~dwo_file>: New.
2672         (free_dwo_file): Remove, move content to ~dwo_file.
2673         (struct dwo_file_deleter): Remove.
2674         (dwo_file_up>: Remove custom deleter.
2675         (free_dwo_files): Remove.
2676         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2677         dwo_files.
2678         (process_skeletonless_type_units): Call unique_ptr::get.
2679         (allocate_dwo_file_hash_table): Add deleter to created hash
2680         table.  Change return type to htab_up.
2681         (lookup_dwo_file_slot): Don't memset dwo_file, call
2682         unique_ptr::get.
2683         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2684         (create_dwo_unit_in_dwp_v2): Likewise.
2685         (open_and_init_dwo_file): Likewise.
2686         (free_dwo_file_from_slot): Remove.
2687
2688 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2689
2690         * dwarf2read.h (struct dwarf2_section_info) <readin,
2691         is_virtual>: Change type to bool.
2692         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2693         true instead of 1.
2694
2695 2019-06-19  Tom Tromey  <tom@tromey.com>
2696
2697         * tui/tui-data.h (tui_init_content_element): Don't declare.
2698
2699 2019-06-19  Tom Tromey  <tom@tromey.com>
2700
2701         * tui/tui-data.h (tui_init_win_info): Don't declare.
2702
2703 2019-06-19  Tom de Vries  <tdevries@suse.de>
2704
2705         * dwarf2read.h (abstract_to_concrete): Change type to
2706         std::unordered_map<sect_offset, std::vector<sect_offset>,
2707         gdb::hash_enum<sect_offset>>.
2708
2709 2019-06-19  Tom Tromey  <tromey@adacore.com>
2710
2711         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2712         EVAL_AVOID_SIDE_EFFECTS specially.
2713
2714 2019-06-19  Tom Tromey  <tromey@adacore.com>
2715
2716         * source-cache.c (highlighter): New global.
2717         (source_cache::get_source_lines): Create a highlighter on demand.
2718
2719 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2720
2721         * defs.h (deprecated_interactive_hook): Delete declaration.
2722         * interps.c (clear_interpreter_hooks): Remove use of
2723         deprecated_interactive_hook.
2724         * top.c (deprecated_interactive_hook): Delete definition.
2725         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2726
2727 2019-06-18  Tom de Vries  <tdevries@suse.de>
2728
2729         PR gdb/24515
2730         * dwarf2read.h (abstract_to_concrete): Change type from
2731         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2732         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2733         * dwarf2read.c (read_variable): Update.
2734         (dwarf2_fetch_die_loc_sect_off): Update.
2735
2736 2019-06-17  Tom de Vries  <tdevries@suse.de>
2737
2738         PR gdb/24617
2739         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2740         accessing parent[parent_len - 1].
2741
2742 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2743
2744         PR gdb/24364
2745         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2746         call dtrace_process_dof with NULL dof.
2747
2748 2019-06-16  Tom de Vries  <tdevries@suse.de>
2749
2750         PR gdb/24445
2751         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2752
2753 2019-06-16  Tom Tromey  <tom@tromey.com>
2754
2755         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2756         (make_all_visible): Use address of member.
2757
2758 2019-06-16  Tom Tromey  <tom@tromey.com>
2759
2760         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2761         (tui_free_window, free_content, free_content_elements): Remove
2762         unnecessary cast.
2763         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2764         cast.
2765         * tui/tui-regs.c (tui_show_register_group)
2766         (tui_display_registers_from, tui_display_reg_element_at_line):
2767         Remove unnecessary cast.
2768
2769 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2770
2771         * linux-nat.c (normal_mask): Delete.
2772         (_initialize_linux_nat): Don't initialise normal_mask.
2773
2774 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2775
2776         PR gdb/24445
2777         * dwarf-index-write.h (write_psymtabs_to_index): Add
2778         dwz_basename parameter.
2779         * dwarf-index-write.c (write_gdbindex): Move file writing to
2780         write_gdbindex_1.  Change return type void.
2781         (assert_file_size): Move up, remove filename parameter.
2782         (write_gdbindex_1): New function.
2783         (write_debug_names): Change return type to void, call
2784         assert_file_size.
2785         (struct index_wip_file): New struct.
2786         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2787         file logic to index_wip_file.  Write index for dwz file if
2788         needed.
2789         (save_gdb_index_command): Pass basename of dwz file, if present.
2790         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2791         build-id of dwz file, if present.
2792         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2793         (dwarf2_get_dwz_file): Likewise.
2794         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2795         (dwarf2_get_dwz_file): Likewise.
2796
2797 2019-06-16  Tom Tromey  <tom@tromey.com>
2798
2799         * coffread.c (process_coff_symbol): Use xstrdup.
2800         * value.c (create_internalvar): Use xstrdup.
2801
2802 2019-06-16  Tom Tromey  <tom@tromey.com>
2803
2804         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2805         * breakpoint.c (stopin_command, stopat_command)
2806         (until_break_command, decode_location_default): Remove unnecessary
2807         cast.
2808         * utils.c (subset_compare): Remove unnecessary cast.
2809         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2810         cast.
2811         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2812         cast.
2813         * infcmd.c (path_command): Remove unnecessary cast.
2814         * coffread.c (decode_type): Remove unnecessary cast.
2815         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2816         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2817         * tui/tui-stack.c (tui_show_locator_content)
2818         (tui_show_frame_info): Remove unnecessary cast.
2819         * tui/tui-win.c (tui_scroll_forward_command)
2820         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2821         (parse_scrolling_args): Remove unnecessary cast.
2822         * tui/tui-data.c (init_win_info, tui_del_window)
2823         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2824         (free_content_elements): Remove unnecessary cast.
2825         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2826         unnecessary cast.
2827         * tui/tui-source.c (tui_set_source_content)
2828         (tui_vertical_source_scroll): Remove unnecessary cast.
2829         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2830         cast.
2831         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2832         * tui/tui-regs.c (tui_display_registers_from)
2833         (tui_display_register): Remove unnecessary cast.
2834         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2835         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2836         (make_visible): Remove unnecessary cast.
2837         * tui/tui-winsource.c (tui_erase_source_content)
2838         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2839         unnecessary cast.
2840         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2841         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2842         * stabsread.c (read_type, read_array_type, read_range_type):
2843         Remove unnecessary cast.
2844         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2845         (parse_symbol, parse_type, upgrade_type, parse_external)
2846         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2847         unnecessary cast.
2848         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2849
2850 2019-06-16  Tom Tromey  <tom@tromey.com>
2851
2852         * tui/tui-data.c (tui_alloc_generic_win_info)
2853         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2854         checks.
2855
2856 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2857             Andrew Burgess  <andrew.burgess@embecosm.com>
2858
2859         * f-typeprint.c (f_print_type): Don't return early for not
2860         associated or not allocated types.
2861         (f_type_print_varspec_suffix): Add print_rank parameter and print
2862         ranks of array types in case they dangling.
2863         (f_type_print_base): Add print_rank parameter.
2864
2865 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2866
2867         * NEWS: Mention new MI commands.
2868         * break-catch-throw.c (enum exception_event_kind): Move to
2869         breakpoint.h.
2870         (print_mention_exception_catchpoint): Output text as a single
2871         message.
2872         (catch_exception_command_1): Rename to...
2873         (catch_exception_event): ...this, make non-static, update header
2874         command, and change some parameter types.
2875         (catch_catch_command): Update for changes to
2876         catch_exception_command_1.
2877         (catch_throw_command): Likewise.
2878         (catch_rethrow_command): Likewise.
2879         * breakpoint.c (enum exception_event_kind): Delete.
2880         * breakpoint.h (enum exception_event_kind): Moved here from
2881         break-catch-throw.c.
2882         (catch_exception_event): Declare.
2883         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2884         (mi_cmd_catch_throw): New function.
2885         (mi_cmd_catch_rethrow): New function.
2886         (mi_cmd_catch_catch): New function.
2887         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2888         'catch-catch' entries.
2889         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2890         (mi_cmd_catch_rethrow): Declare.
2891         (mi_cmd_catch_catch): Declare.
2892
2893 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2894
2895         * annotate.c (annotate_source_line): Change return type to void,
2896         update implementation to match.
2897         * annotate.h (annotate_source_line): Change return type to void,
2898         update header comment.
2899         * stack.c (print_frame_info): Don't change what frame information
2900         is printed based on whether annotations are on or not.
2901
2902 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2903
2904         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2905         (annotate_source): Make static.
2906         (annotate_source_line): Moved from source.c and renamed from
2907         identify_source_line.  Update the return type.
2908         * annotate.h (annotate_source): Delete declaration.
2909         (annotate_source_line): Declaration moved from source.h, and
2910         renamed from identify_source_line.  Return type updated.
2911         * source.c (identify_source_line): Moved to annotate.c and renamed
2912         to annotate_source_line.
2913         (info_line_command): Remove check of annotation_level.
2914         * source.h (identify_source_line): Move declaration to annotate.h
2915         and rename to annotate_source_line.
2916         * stack.c: Add 'annotate.h' include.
2917         (print_frame_info): Remove check of annotation_level before
2918         calling annotate_source_line.
2919
2920 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2921
2922         * source-cache.c (source_cache::get_plain_source_lines): Use
2923         open_source_file_with_line_charpos instead of just
2924         open_source_file, remove call to find_source_lines.
2925         (source_cache::get_source_lines): Likewise.
2926         * source.c (find_source_lines): Make static.
2927         (get_filename_and_charpos): Renamed into...
2928         (open_source_file_with_line_charpos): ..this along with changes to
2929         return a scoped_fd, and some other minor clean ups.
2930         (identify_source_line): Use open_source_file_with_line_charpos.
2931         (search_command_helper): Use open_source_file_with_line_charpos
2932         instead of just open_source_file, remove call to
2933         find_source_lines.
2934         * source.h (open_source_file_with_line_charpos): Declare new
2935         function.
2936         (find_source_lines): Delete declaration.
2937
2938 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2939
2940         * source.c (get_filename_and_charpos): Remove fullname
2941         parameter.
2942         (identify_source_line): Update call to get_filename_and_charpos.
2943
2944 2019-06-14  Tom Tromey  <tromey@adacore.com>
2945
2946         PR gdb/24502:
2947         * ui-style.h (skip_ansi_escape): Update comment.
2948         * ui-file.h (class no_terminal_escape_file): New class.
2949         * ui-file.c (no_terminal_escape_file::write)
2950         (no_terminal_escape_file::puts): New methods.
2951         * cli/cli-logging.c (handle_redirections): Use
2952         no_terminal_escape_file.
2953
2954 2019-06-14  Tom Tromey  <tromey@adacore.com>
2955
2956         * NEWS: Move convenience variable news above Python news.
2957
2958 2019-06-14  Tom Tromey  <tom@tromey.com>
2959
2960         * gnulib: Move directory to top-level.
2961         * configure.ac: Don't configure gnulib.
2962         * configure: Rebuild.
2963         * common/common-defs.h: Use new path to gnulib.
2964         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2965         (GNULIB_H): Remove.
2966         (INCGNU): Look in new gnulib location.
2967         (HFILES_NO_SRCDIR): Remove gnulib files.
2968         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2969         (generated_files): Remove GNULIB_H.
2970         ($(LIBGNU), all-lib): Remove targets.
2971         (distclean): Don't mention GNULIB_BUILDDIR.
2972         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2973
2974 2019-06-14  Tom Tromey  <tromey@adacore.com>
2975
2976         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2977         Warn if symbol file does not provide any symbols.
2978
2979 2019-06-14  Tom Tromey  <tromey@adacore.com>
2980
2981         * source.c (find_and_open_source): Respect basenames_may_differ.
2982
2983 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2984
2985         * annotate.c (annotate_breakpoints_invalid): Make use of
2986         scoped_restore_terminal_state.
2987         (annotate_frames_invalid): Likewise.
2988
2989 2019-06-14  Tom Tromey  <tromey@adacore.com>
2990
2991         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2992         allow assignment to an internalvar.
2993
2994 2019-06-14  Tom Tromey  <tromey@adacore.com>
2995
2996         * ada-lex.l: Allow "_" in attribute names.
2997
2998 2019-06-14  Tom Tromey  <tromey@adacore.com>
2999
3000         PR gdb/24653:
3001         * regcache.c (registers_changed): Don't call alloca.
3002         * top.c (execute_command): Don't call alloca.
3003
3004 2019-06-13  Pedro Alves  <palves@redhat.com>
3005
3006         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3007         'expression'.  When parsing an expression, error out if there's
3008         junk after "unlimited".
3009         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3010         (do_set_command): Adjust calls to is_unlimited_literal.
3011
3012 2019-06-13  Pedro Alves  <palves@redhat.com>
3013
3014         * compile/compile.c (make_compile_options_def_group): Add braces
3015         around array_view initializer.
3016         * thread.c (make_thread_apply_all_options_def_group)
3017         (make_thread_apply_all_options_def_group): Likewise.
3018
3019 2019-06-13  Pedro Alves  <palves@redhat.com>
3020
3021         * NEWS (New commands): Mention "maint test-options
3022         require-delimiter", "maint test-options unknown-is-error", "maint
3023         test-options unknown-is-operand" and "maint show
3024         test-options-completion-result".
3025         (New command options, command completion): New section.
3026         (Completion improvements): New section.
3027         Mention that you can abbreviate "unlimited".
3028
3029 2019-06-13  Pedro Alves  <palves@redhat.com>
3030
3031         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3032         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3033         * unittests/cli-utils-selftests.c (test_parse_flags)
3034         (test_parse_flags_qcs): Delete.
3035         (test_cli_utils): Don't call deleted functions.
3036
3037 2019-06-13  Pedro Alves  <palves@redhat.com>
3038
3039         * thread.c: Include "cli/cli-option.h".
3040         (tp_array_compar_ascending): Global.
3041         (tp_array_compar): Delete function.
3042         (tp_array_compar_ascending, tp_array_compar_descending): New
3043         functions.
3044         (ascending_option_def, qcs_flag_option_def)
3045         (thr_qcs_flags_option_defs)
3046         (make_thread_apply_all_options_def_group)
3047         (make_thread_apply_options_def_group): New.
3048         (thread_apply_all_command): Use gdb::option::process_options.
3049         (thread_apply_command_completer)
3050         (thread_apply_all_command_completer): New.
3051         (thread_apply_command): Use gdb::option::process_options.
3052         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3053         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
3054         to generate help text of "thread apply".  Adjust "taas"'s help.
3055         * tid-parse.c (tid_range_parser::in_thread_range): New method.
3056         * tid-parse.h (tid_range_parser::in_thread_range): New method.
3057
3058 2019-06-13  Pedro Alves  <palves@redhat.com>
3059
3060         * thread.c (thread_apply_command): Check for invalid TID with
3061         isdigit instead of !isalpha.
3062
3063 2019-06-13  Pedro Alves  <palves@redhat.com>
3064
3065         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3066         (validate_flags_qcs): New.
3067         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3068         (validate_flags_qcs): Declare.
3069         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3070         (make_frame_apply_options_def_group): New.
3071         (frame_apply_command_count): Process options with
3072         gdb::option::process_options.
3073         (frame_apply_completer): New.
3074         (frame_apply_level_completer, frame_apply_all_completer)
3075         (frame_apply_completer): New.
3076         (_initialize_stack): Update help of "frame apply", "frame apply
3077         level", "frame apply all" and "faas" to mention supported options
3078         and install command completers.
3079         * stack.h (frame_apply_all_completer): Declare.
3080         * thread.c: Include "stack.h".
3081         (tfaas_command): Add "--".
3082         (_initialize_thread): Update help "tfaas" to mention supported
3083         options and install command completer.
3084
3085 2019-06-13  Pedro Alves  <palves@redhat.com>
3086
3087         * completer.c (complete_nested_command_line): New.
3088         (gdb_completion_word_break_characters_throw): Add assertion.
3089         * completer.h (complete_nested_command_line): Declare.
3090
3091 2019-06-13  Pedro Alves  <palves@redhat.com>
3092
3093         * stack.c (parse_backtrace_qualifiers): New.
3094         (backtrace_command): Use it.
3095         (backtrace_command_completer): Complete on qualifiers.
3096
3097 2019-06-13  Pedro Alves  <palves@redhat.com>
3098
3099         * frame.c: Include "cli/cli-option.h.
3100         (user_set_backtrace_options): New.
3101         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3102         Delete.
3103         (get_prev_frame): Adjust.
3104         (boolean_option_def, uinteger_option_def)
3105         (set_backtrace_option_defs): New.
3106         (_initialize_frame): Adjust and use
3107         gdb::option::add_setshow_cmds_for_options to install "set
3108         backtrace past-main" and "set backtrace past-entry".
3109         * frame.h: Include "cli/cli-option.h".
3110         (struct frame_print_options): Forward declare.
3111         (print_frame_arguments_all, print_frame_arguments_scalars)
3112         (print_frame_arguments_none): Declare.
3113         (print_entry_values): Delete declaration.
3114         (struct frame_print_options, user_frame_print_options): New.
3115         (struct set_backtrace_options): New.
3116         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3117         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3118         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3119         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3120         (list_args_or_locals): Add frame_print_options parameter.
3121         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3122         * python/py-framefilter.c (enumerate_args): Pass down
3123         USER_FRAME_PRINT_OPTIONS.
3124         * stack.c: Include "cli/cli-option.h".
3125         (print_frame_arguments_all, print_frame_arguments_scalars)
3126         (print_frame_arguments_none): Declare.
3127         (print_raw_frame_arguments, print_entry_values): Delete.
3128         (user_frame_print_options): New.
3129         (boolean_option_def, enum_option_def, frame_print_option_defs):
3130         New.
3131         (struct backtrace_cmd_options): New.
3132         (bt_flag_option_def): New.
3133         (backtrace_command_option_defs): New.
3134         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3135         (print_frame_arg, read_frame_arg, print_frame_args)
3136         (print_frame_info, print_frame): Add frame_print_options parameter
3137         and use it.
3138         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3139         (backtrace_command_1): Add frame_print_options and
3140         backtrace_cmd_options parameters and use them.
3141         (make_backtrace_options_def_group): New.
3142         (backtrace_command): Process command options with
3143         gdb::option::process_options.
3144         (backtrace_command_completer): New.
3145         (_initialize_stack): Extend "backtrace"'s help to mention
3146         supported options.  Install completer for "backtrace".
3147         Install some settings commands with add_setshow_cmds_for_options.
3148
3149 2019-06-13  Pedro Alves  <palves@redhat.com>
3150
3151         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3152         and that "set/show print raw frame-arguments" are now deprecated.
3153
3154         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3155         command.
3156         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3157         * stack.c (_initialize_stack): Install "set/show print
3158         raw-frame-arguments", and deprecate "set/show print raw
3159         frame-arguments".
3160         * valprint.c (_initialize_valprint): Deprecate "set/show print
3161         raw".
3162
3163 2019-06-13  Pedro Alves  <palves@redhat.com>
3164
3165         * compile/compile.c (struct compile_options): New.
3166         (compile_flag_option_def, compile_command_option_defs)
3167         (make_compile_options_def_group): New.
3168         (compile_file_command): Handle options with
3169         gdb::option::process_options.
3170         (compile_file_command_completer): New function.
3171         (compile_code_command): Handle options with
3172         gdb::option::process_options.
3173         (compile_code_command_completer): New function.
3174         (_initialize_compiler): Install completers for "compile code" and
3175         "compile file".  Mention available options in "compile code" and
3176         "compile code"'s help.
3177         * completer.c (advance_to_completion_word): New, factored out from
3178         ...
3179         (advance_to_expression_complete_word_point): ... this.
3180         (advance_to_filename_complete_word_point): New.
3181         * completer.h (advance_to_filename_complete_word_point): New
3182         declaration.
3183
3184 2019-06-13  Pedro Alves  <palves@redhat.com>
3185
3186         * compile/compile.c: Include "cli/cli-option.h".
3187         (compile_print_value): Scope data pointer is now a
3188         value_print_options pointer; adjust.
3189         (compile_print_command): Process options.  Scope data pointer is
3190         now a value_print_options pointer; adjust.
3191         (_initialize_compile): Update "compile print"'s help to include
3192         supported options.  Install a completer for "compile print".
3193         * cp-valprint.c (show_vtblprint, show_objectprint)
3194         (show_static_field_print): Delete.
3195         (_initialize_cp_valprint): Don't install "set print
3196         static-members", "set print vtbl", "set print object" here.
3197         * printcmd.c: Include "cli/cli-option.h" and
3198         "common/gdb_optional.h".
3199         (print_command_parse_format): Rework to fill in a
3200         value_print_options instead of a format_data.
3201         (print_value): Change parameter type from format_data pointer to
3202         value_print_options reference.  Adjust.
3203         (print_command_1): Process options.  Adjust to pass down a
3204         value_print_options.
3205         (print_command_completer): New.
3206         (_initialize_printcmd): Install print_command_completer as
3207         handle_brkchars completer for the "print" command.  Update
3208         "print"'s help to include supported options.
3209         * valprint.c: Include "cli/cli-option.h".
3210         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3211         here from cp-valprint.c.
3212         (boolean_option_def, uinteger_option_def)
3213         (value_print_option_defs, make_value_print_options_def_group):
3214         New.  Use gdb::option::add_setshow_cmds_for_options to install
3215         "set print elements", "set print null-stop", "set print repeats",
3216         "set print pretty", "set print union", "set print array", "set
3217         print address", "set print symbol", "set print array-indexes".
3218         * valprint.h: Include <string> and "cli/cli-option.h".
3219         (make_value_print_options_def_group): Declare.
3220         (print_value): Change parameter type from format_data pointer to
3221         value_print_options reference.
3222         (print_command_completer): Declare.
3223
3224 2019-06-13  Pedro Alves  <palves@redhat.com>
3225
3226         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3227         (COMMON_SFILES): Add maint-test-settings.c.
3228         * cli/cli-decode.c (boolean_enums): New global, factored out from
3229         ...
3230         (add_setshow_boolean_cmd): ... here.
3231         * cli/cli-decode.h (boolean_enums): Declare.
3232         * cli/cli-option.c: New file.
3233         * cli/cli-option.h: New file.
3234         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3235         factored out from ...
3236         (parse_cli_boolean_value(const char *)): ... this.
3237         (is_unlimited_literal): Change parameter type to pointer to
3238         pointer.  Adjust and advance ARG pointer.
3239         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3240         (parse_cli_var_enum): New, factored out from ...
3241         (do_set_command): ... this.  Adjust.
3242         * cli/cli-setshow.h (parse_cli_boolean_value)
3243         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3244         (parse_cli_var_enum): Declare.
3245         * cli/cli-utils.c: Include "cli/cli-option.h".
3246         (get_ulongest): New.
3247         * cli/cli-utils.h (get_ulongest): Declare.
3248         (check_for_argument): New overloads.
3249         * maint-test-options.c: New file.
3250
3251 2019-06-13  Pedro Alves  <palves@redhat.com>
3252
3253         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3254         parse a range if "-" is at the end of the string.
3255
3256 2019-06-13  Pedro Alves  <palves@redhat.com>
3257
3258         * cli/cli-setshow.c (parse_auto_binary_operation)
3259         (parse_cli_boolean_value): Don't allow "o".
3260
3261 2019-06-13  Pedro Alves  <palves@redhat.com>
3262
3263         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3264         * NEWS: Mention maint test-settings KIND.
3265         * maint-test-settings.c: New file.
3266
3267 2019-06-13  Pedro Alves  <palves@redhat.com>
3268
3269         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3270         completer.
3271         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3272         "set" completers.
3273
3274 2019-06-13  Pedro Alves  <palves@redhat.com>
3275
3276         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3277         after item.
3278
3279 2019-06-13  Pedro Alves  <palves@redhat.com>
3280
3281         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3282
3283 2019-06-13  Pedro Alves <palves@redhat.com>
3284
3285         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3286         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3287         call.
3288         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3289         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3290         calls.
3291         (check_for_argument): Skip spaces after argument.
3292
3293 2019-06-13  Pedro Alves  <palves@redhat.com>
3294
3295         * thread.c (thread_apply_command): Adjust TID parsing.
3296         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3297         detected before end of string.
3298         (tid_is_in_list): Error out if LIST is invalid.
3299
3300 2019-06-13  Pedro Alves  <palves@redhat.com>
3301
3302         * completer.c (complete_line_internal_1): Rewind completion word
3303         point.
3304         (completion_tracker::advance_custom_word_point_by): Change
3305         parameter type to int.
3306         * completer.h (completion_tracker::advance_custom_word_point_by):
3307         Likewise.
3308
3309 2019-06-13  Pedro Alves  <palves@redhat.com>
3310
3311         * completer.c (advance_to_completion_word): Handle delimiters.
3312
3313 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3314
3315         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3316
3317 2019-06-11  Tom Tromey  <tom@tromey.com>
3318
3319         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3320         (xmalloc_failed): Move to alloc.c.
3321         * alloc.c: New file.
3322         * Makefile.in (COMMON_SFILES): Add alloc.c.
3323
3324 2019-06-11  Tom Tromey  <tom@tromey.com>
3325
3326         * nat/linux-waitpid.c: Don't include server.h.
3327         (linux_debug): Remove.
3328         (my_waitpid): Update.
3329
3330 2019-06-11  Tom Tromey  <tromey@adacore.com>
3331
3332         * infcall.c (_initialize_infcall): Remove trailing newline from
3333         help.
3334         * user-regs.c (_initialize_user_regs): Remove trailing newline
3335         from help.
3336         * typeprint.c (_initialize_typeprint): Remove trailing newline
3337         from help.
3338         * reverse.c (_initialize_reverse): Remove trailing newlines from
3339         help.
3340         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3341         from help.
3342         * language.c (add_set_language_command): Remove trailing newline
3343         from help.
3344         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3345         help.
3346         * disasm.c (_initialize_disasm): Remove trailing newline from
3347         help.
3348         * top.c (init_main): Remove trailing newline from help.
3349         * interps.c (_initialize_interpreter): Remove trailing newline
3350         from help.
3351         * btrace.c (_initialize_btrace): Remove trailing newlines from
3352         help.
3353         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3354         from help.
3355         * python/python.c (_initialize_python): Remove trailing newline
3356         from help.
3357         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3358         help.
3359         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3360         from help.  Reformat some text.
3361         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3362         from help.
3363         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3364         newline from help.
3365
3366 2019-06-11  Tom Tromey  <tromey@adacore.com>
3367
3368         * darwin-nat.c (darwin_decode_exception_message)
3369         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3370
3371 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3372
3373         * valops.c (value_slice): Check for not allocated or not
3374         associated values.
3375
3376 2019-06-10  Tom de Vries  <tdevries@suse.de>
3377
3378         PR gdb/24618
3379         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3380         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3381         invalid.
3382
3383 2019-06-10  Tom de Vries  <tdevries@suse.de>
3384
3385         PR gdb/24611
3386         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3387         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3388
3389 2019-06-10  Tom de Vries  <tdevries@suse.de>
3390
3391         PR symtab/24545
3392         * symtab.c (struct demangled_name_entry): Add language field.
3393         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3394         static minimal symbol".  Set and use language field.
3395
3396 2019-06-10  Tom Tromey  <tromey@adacore.com>
3397
3398         * ada-lang.c (_initialize_ada_language): Update help text.
3399
3400 2019-06-10  Tom Tromey  <tromey@adacore.com>
3401
3402         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3403         with a newline.
3404         * guile/guile.c (handle_boot_error): Don't end warning with a
3405         newline.
3406         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3407         warning with a newline.
3408         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3409         newline.
3410         (s12z_frame_cache): Likewise.
3411         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3412         a newline.
3413         * solib-svr4.c (disable_probes_interface): Don't end warning with
3414         a newline.
3415         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3416         newline.
3417         * python/python.c (do_finish_initialization): Don't end warning
3418         with a newline.
3419
3420 2019-06-10  Tom Tromey  <tom@tromey.com>
3421
3422         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3423         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3424         gdbpy_enter.
3425
3426 2019-06-10  Tom Tromey  <tromey@adacore.com>
3427
3428         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3429         data.
3430         (elf_new_init): Don't call stabsread_new_init.
3431         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3432         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3433         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3434
3435 2019-06-10  Tom de Vries  <tdevries@suse.de>
3436
3437         PR symtab/16264
3438         PR symtab/24517
3439         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3440
3441 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3442
3443         * source.c (find_and_open_source): Also rewrite relative file
3444         names.
3445
3446 2019-04-26  Amos Bird  <amosbird@gmail.com>
3447
3448         * annotate.c (annotate_thread_exited): Add "thread-exited"
3449         annotation.
3450
3451 2019-06-06  Tom Tromey  <tromey@adacore.com>
3452
3453         * maint.h (class scoped_command_stats): Use
3454         DISABLE_COPY_AND_ASSIGN.
3455         <print_time>: New method.
3456         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3457         print_time.
3458         (scoped_command_stats::print_time): New method.
3459
3460 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3461
3462         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3463         instructions of lengths 6 or 8 bytes.
3464
3465 2019-06-04  Pedro Alves  <palves@redhat.com>
3466
3467         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3468
3469         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3470         * breakpoint.c (condition_completer): Likewise.
3471         * cli/cli-dump.c (scan_expression): Likewise.
3472         * common/filestuff.c (mkdir_recursive): Likewise.
3473         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3474         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3475         (gdb_abspath): Likewise.
3476         * compile/compile-cplus-types.c
3477         (compile_cplus_instance::decl_name): Likewise.
3478         * completer.c (complete_explicit_location):
3479         (signal_completer, reg_or_group_completer_1): Likewise.
3480         * cp-support.c (cp_remove_params_if_any): Likewise.
3481         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3482         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3483         * infcmd.c (strip_bg_char): Likewise.
3484         * linespec.c (copy_token_string): Likewise.
3485         * mi/mi-main.c (output_cores): Likewise.
3486         * psymtab.c (psymtab_search_name):
3487         * symfile.c (test_set_ext_lang_command): Likewise.
3488         * target.c (target_fileio_read_stralloc): Likewise.
3489         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3490         * value.c (complete_internalvar): Likewise.
3491
3492 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3493
3494         Add objfile property to gdb.Type.
3495         * NEWS: Mention Python API addition.
3496         * python/py-type.c (typy_get_objfile): New method.
3497
3498 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3499
3500         * NEWS: Mention the new set|show style [title|highlight].
3501         Mention changes to "show style", "help" and "apropos".
3502
3503 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3504
3505         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3506         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3507         instead of print_help_for_command.
3508         (print_doc_of_command): New function.
3509         (help_list): Add 'apropos -v word' suggestion.
3510         (print_help_for_command): Style the command name using title style.
3511         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3512         (_initialize_cli_cmds): Describe -v in apropos_command help.
3513
3514 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3515
3516         * cli/cli-style.h (cli_style_option): Add name in constructor,
3517         add m_name class member, add constructor with intensity,
3518         add name class function.
3519         (cli_style_option::add_setshow_commands): Remove name argument.
3520         (highlight_style, title_style): New styles.
3521         * cli/cli-style.c (do_show): New function that shows a style
3522         characteristic styling the style name with itself.
3523         (set_style_name): New function.
3524         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3525         Update all callers according to the changes in cli/cli-style.h.
3526         * utils.h (fputs_highlighted): New function.
3527         * utils.c (fputs_highlighted): Likewise.
3528
3529 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3530
3531         * NEWS: Mention new pipe command and new convenience variables.
3532
3533 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3534
3535         * cli/cli-cmds.c (pipe_command): New function.
3536         (_initialize_cli_cmds): Call add_com for pipe_command.
3537         Define | as an alias for pipe.
3538         (exit_status_set_internal_vars): New function.
3539         (shell_escape): Call exit_status_set_internal_vars.
3540         cli/cli-decode.c (find_command_name_length): Recognize | as
3541         a single character command.
3542
3543 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3544
3545         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3546         top.c (execute_command_to_ui_file): New function, mostly a copy
3547         of execute_command_to_string.
3548         (execute_command_to_string): Implement by calling
3549         execute_command_to_ui_file.
3550
3551 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3552
3553         * top.h (saved_command_line): Remove declaration.
3554         * top.c (previous_saved_command_line, previous_repeat_arguments):
3555         New variables.
3556         (saved_command_line): Make static, define together with other
3557         'repeat variables'.
3558         (dont_repeat): Clear repeat_arguments.
3559         (repeat_previous, get_saved_command_line, save_command_line):
3560         New functions.
3561         (gdb_init): Initialize saved_command_line
3562         and previous_saved_command_line.
3563         * main.c (captured_main_1): Remove saved_command_line initialization.
3564         * event-top.c (handle_line_of_input): Update to use
3565         the new 'repeat' related functions instead of direct access to
3566         saved_command_line.
3567         * command.h (repeat_previous, get_saved_command_line,
3568         save_command_line): New declarations.
3569         (dont_repeat): Add comment.
3570
3571 2019-05-30  Tom Tromey  <tromey@adacore.com>
3572
3573         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3574         Fix comment.
3575         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3576
3577 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3578
3579         PR cli/24587
3580         * completer.c (complete): Initialize variable word.
3581
3582 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3583
3584         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3585         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3586         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3587         'body' is NULL to the outter 'if', protecting the '!is_define'
3588         situation as well.
3589
3590 2019-05-29  Tom Tromey  <tromey@adacore.com>
3591
3592         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3593         (dwarf_unknown): New function.
3594         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3595         (dwarf_type_encoding_name): Use dwarf_unknown.
3596
3597 2019-05-29  Tom Tromey  <tromey@adacore.com>
3598
3599         PR c++/20020:
3600         * cp-valprint.c (cp_print_value_fields): Call
3601         cp_print_static_field inside "try".
3602
3603 2019-05-29  Tom Tromey  <tromey@adacore.com>
3604
3605         * inflow.c (struct terminal_info): Add default operator=.
3606         * configure: Rebuild.
3607         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3608         -Wdeprecated-copy-dtor, -Wredundant-move.
3609
3610 2019-05-29  Tom Tromey  <tromey@adacore.com>
3611
3612         * NEWS: Add entry.
3613         * infcmd.c (print_return_value_1): Handle finish_print
3614         option.
3615         (show_print_finish): New function.
3616         (_initialize_infcmd): Add "set/show print finish" commands.
3617         * valprint.c (user_print_options): Initialize new member.
3618         * valprint.h (struct value_print_options) <finish_print>: New
3619         member.
3620
3621 2019-05-28  Tom Tromey  <tromey@adacore.com>
3622
3623         * ada-lang.c (ada_remove_Xbn_suffix)
3624         (find_old_style_renaming_symbol)
3625         (parse_old_style_renaming): Remove.
3626         (ada_find_renaming_symbol): Don't call
3627         find_old_style_renaming_symbol.
3628         (ada_is_renaming_symbol): Rename from
3629         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3630         bool.  Now static.
3631         (ada_read_var_value): Update and simplify.
3632         * ada-exp.y (write_var_or_type): Remove old code.
3633
3634 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3635
3636         * event-top.c: Remove include comment.
3637         * inflow.c (class scoped_ignore_sigttou): Move from here...
3638         * inflow.h (class scoped_ignore_sigttou): ...to here.
3639         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3640         * top.c:  Remove include comment.
3641
3642 2019-05-27  Tom Tromey  <tom@tromey.com>
3643
3644         * NEWS: Fix typo.
3645
3646 2019-05-22  Tom Tromey  <tromey@adacore.com>
3647
3648         * target.c (target_follow_exec): Constify parameter.
3649         * target-delegates.c: Rebuild.
3650         * remote.c (remote_target::follow_exec): Constify parameter.
3651         * infrun.c (follow_exec): Constify parameter.
3652         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3653         (target_follow_exec): Likewise.
3654
3655 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3656
3657         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3658         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3659
3660 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3661
3662         * NEWS: Add debugredirect and testsuite sections.
3663
3664 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3665
3666         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3667         target descriptions using exclusively floating point register name
3668         aliases.
3669
3670 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3671
3672         PR gdb/18644:
3673         * f-lang.c (build_fortran_types): Handle the case where
3674         gdbarch_floatformat_for_type returns a nullptr.
3675
3676 2019-05-21  Tom de Vries  <tdevries@suse.de>
3677
3678         PR cli/24587
3679         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3680
3681 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3682
3683         PR gdb/18644:
3684         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3685         16-byte floats.
3686         * i386-tdep.c (i386_floatformat_for_type): Use
3687         floatformats_ia64_quad for the 16-byte floating point component
3688         within a fortran 32-byte complex number.
3689
3690 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3691
3692         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3693         delete default constructor.
3694         (find_partial_die): Update to return const struct.
3695         (partial_die_parent_scope): Move variable declaration into scope
3696         of its use and change its type to auto.
3697         (guess_partial_die_structure_name): Likewise.
3698         (partial_die_info::fixup): Likewise.
3699
3700 2019-05-17  Tom Tromey  <tromey@adacore.com>
3701
3702         * source.c (find_and_open_source): Remove cast.
3703
3704 2019-05-17  Tom Tromey  <tromey@adacore.com>
3705
3706         * annotate.c (annotate_source): Make "filename" const.
3707         * annotate.h (annotate_source): Use const.
3708
3709 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3710
3711         * disasm.c (set_disassembler_options): Send errors to stderr.
3712
3713 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3714
3715         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3716         (cli_interp_base::set_logging): Check debug_redirect.
3717         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3718         * cli/cli-logging.c (debug_redirect): Add static variable.
3719         (pop_output_files): Add default param.
3720         (handle_redirections): Print debug setting.
3721         (show_logging_command): Likewise.
3722         (_initialize_cli_logging): Add debugredirect command.
3723         * interps.c (current_interp_set_logging): Add debug_redirect
3724         parameter.
3725         * interps.h (set_logging): Add debug_redirect parameter.
3726         (current_interp_set_logging): Likewise.
3727         * mi/mi-common.h: Likewise.
3728         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3729
3730 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3731             Tom Tromey  <tromey@adacore.com>
3732
3733         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3734         directly.
3735         * cli/cli-interp.h (make_logging_output): Remove declaration.
3736         * cli/cli-logging.c (make_logging_output): Remove function.
3737         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3738         directly.
3739         * ui-file.c (tee_file::tee_file): Remove bools.
3740         (tee_file::~tee_file): Remove deletes.
3741         * ui-file.h (tee_file): Remove bools.
3742
3743 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3744
3745         * mi/mi-cmds.h (mi_cmd_complete): New function.
3746         * mi/mi-main.c (mi_cmd_complete): Likewise.
3747         * mi/mi-cmds.c: Define new MI command -complete.
3748         * NEWS: Mention new -complete command.
3749
3750 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3751
3752         * completer.h (complete): New function.
3753         * completer.c (complete): Likewise.
3754         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3755         function defined in completer.h.
3756
3757 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3758
3759         * MAINTAINERS (Write After Approval): Add myself.
3760
3761 2019-05-17  Tom de Vries  <tdevries@suse.de>
3762
3763         PR gdb/24094
3764         * dwarf2read.c (struct cu_partial_die_info): New struct.
3765         (find_partial_die): Return cu_partial_die_info.
3766         (partial_die_parent_scope, guess_partial_die_structure_name)
3767         (partial_die_info::fixup): Handle new return type of find_partial_die.
3768
3769 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3770
3771         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3772         "std::string", simplifying the algorithm.
3773
3774 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3775
3776         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3777         (stap_static_probe_ops::get_probes): Likewise.
3778
3779 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3780
3781         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3782         '-')" and "else if".
3783         (stap_parse_single_operand): Join checks for
3784         "gdbarch_stap_parse_special_token_p" and
3785         "gdbarch_stap_parse_special_token" in the same "if" statement.
3786         Invert check when verifying for operation on register
3787         displacement.
3788
3789 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3790
3791         * stap-probe.c (stap_get_opcode): Update comment.
3792         (stap_get_expected_argument_type): Likewise.
3793         (handle_stap_probe): Likewise.
3794
3795 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3796
3797         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3798         return type to 'bool'.  Adjust comment.  Use 'bool' when
3799         appropriate.
3800         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3801         * stap-probe.c (stap_parse_argument_1): Likewise.
3802         (stap_is_operator): Likewise.
3803         (stap_is_generic_prefix): Likewise.
3804         (stap_is_register_prefix): Likewise.
3805         (stap_is_register_indirection_prefix): Likewise.
3806         (stap_is_integer_prefix): Likewise.
3807         (stap_generic_check_suffix): Likewise.
3808         (stap_check_integer_suffix): Likewise.
3809         (stap_check_register_suffix): Likewise.
3810         (stap_check_register_indirection_suffix): Likewise.
3811         (stap_parse_register_operand): Likewise.
3812         (stap_parse_single_operand): Likewise.
3813         (stap_parse_argument_1): Likewise.
3814         (stap_probe::get_argument_count): Likewise.
3815         (stap_is_operator): Likewise.
3816
3817 2019-05-16  Tom Tromey  <tromey@adacore.com>
3818
3819         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3820         keyword to foreach.
3821
3822 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3823
3824         * linux-thread-db.c (try_thread_db_load_1): Change return type
3825         to bool.
3826         (try_thread_db_load): Likewise.
3827         (try_thread_db_load_from_pdir_1): Likewise.
3828         (try_thread_db_load_from_pdir): Likewise.
3829         (try_thread_db_load_from_sdir): Likewise.
3830         (try_thread_db_load_from_dir): Likewise.
3831         (thread_db_load_search): Likewise.
3832         (has_libpthread): Likewise.
3833         (thread_db_load): Likewise.
3834
3835 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3836
3837         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3838         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3839         NULL, and complain/return if that's the case.
3840
3841 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3842
3843         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3844         (advance, posn, abstract_read_memory): New functions.
3845         [struct mem_read_abstraction]: New struct.
3846         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3847
3848 2019-05-14  Tom Tromey  <tromey@adacore.com>
3849
3850         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3851         value is not lval_memory.
3852
3853 2019-05-14  Tom Tromey  <tromey@adacore.com>
3854
3855         * solib.c (info_sharedlibrary_command): Style the file name.
3856
3857 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3858
3859         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3860         (aarch64_vnv_type): Likewise.
3861         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3862         * common/tdesc.c: Likewise.
3863         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3864         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3865         * features/aarch64-fpu.xml: Add ieee half view.
3866         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3867         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3868         * gdbtypes.h (struct builtin_type): Likewise.
3869         (struct objfile_type): Likewise.
3870
3871 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3872
3873         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3874         typo.
3875         * location.h (string_to_event_location): Likewise.
3876
3877 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3878
3879         GDB 8.3 released.
3880
3881 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3882
3883         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3884         New variable declaration.
3885         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3886         New variable.
3887         (print_one_breakpoint): Use ui_out::test_flags and new global
3888         variable to compute use_fixed_output.
3889         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3890         Remove.
3891         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3892         (mi_multi_location_breakpoint_output_fixed): Remove.
3893         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3894         new variable.
3895         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3896         fix_multi_location_breakpoint_output flag if version >= 3.
3897         * ui-out.h (enum ui_out_flag)
3898         <fix_multi_location_breakpoint_output>: New enumerator.
3899
3900 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3901
3902         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3903
3904 2019-05-10  Tom Tromey  <tromey@adacore.com>
3905
3906         * ada-lang.c (catch_ada_completer): New function.
3907         (_initialize_ada_language): Use it.
3908
3909 2019-05-10  Tom Tromey  <tromey@adacore.com>
3910
3911         * thread.c (print_thread_info): Make "requested_threads" const.
3912         * gdbthread.h (print_thread_info): Make "requested_threads"
3913         const.
3914         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3915         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3916
3917 2019-05-08  Tom Tromey  <tom@tromey.com>
3918
3919         * gdbtypes.c (objfile_type_data): Change type.
3920         (objfile_type, _initialize_gdbtypes): Update.
3921
3922 2019-05-08  Tom Tromey  <tom@tromey.com>
3923
3924         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3925         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3926         (_initialize_dwarf2_frame): Update.
3927
3928 2019-05-08  Tom Tromey  <tom@tromey.com>
3929
3930         * objc-lang.c (objc_objfile_data): Change type.
3931         (find_methods): Update.
3932         (_initialize_objc_lang): Remove.
3933
3934 2019-05-08  Tom Tromey  <tom@tromey.com>
3935
3936         * stabsread.c (rs6000_builtin_type_data): Change type.
3937         (rs6000_builtin_type, _initialize_stabsread): Update.
3938
3939 2019-05-08  Tom Tromey  <tom@tromey.com>
3940
3941         * mips-tdep.c (mips_pdr_data): Remove.
3942         (_initialize_mips_tdep): Update.
3943
3944 2019-05-08  Tom Tromey  <tom@tromey.com>
3945
3946         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3947         (hppa_init_objfile_priv_data, read_unwind_info)
3948         (find_unwind_entry, _initialize_hppa_tdep): Update.
3949
3950 2019-05-08  Tom Tromey  <tom@tromey.com>
3951
3952         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3953         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3954         on obstack.
3955         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3956
3957 2019-05-08  Tom Tromey  <tom@tromey.com>
3958
3959         * mdebugread.c (basic_type_data): Change type.
3960         (basic_type, _initialize_mdebugread): Update.
3961
3962 2019-05-08  Tom Tromey  <tom@tromey.com>
3963
3964         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3965
3966 2019-05-08  Tom Tromey  <tom@tromey.com>
3967
3968         * nto-tdep.c (nto_inferior_data_reg): Change type.
3969         (nto_inferior_data): Update.
3970         (nto_inferior_data_cleanup, nto_new_inferior_data)
3971         (_initialize_nto_tdep): Remove.
3972         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3973
3974 2019-05-08  Tom Tromey  <tom@tromey.com>
3975
3976         * ada-lang.c (struct ada_inferior_data): Add initializers.
3977         (ada_inferior_data): Change type.
3978         (ada_inferior_data_cleanup): Remove.
3979         (get_ada_inferior_data, ada_inferior_exit)
3980         (struct ada_pspace_data): Add initializers, destructor.
3981         (ada_pspace_data_handle): Change type.
3982         (get_ada_pspace_data): Update.
3983         (ada_pspace_data_cleanup): Remove.
3984
3985 2019-05-08  Tom Tromey  <tom@tromey.com>
3986
3987         * coffread.c (struct coff_symfile_info): Add initializers.
3988         (coff_objfile_data_key): Move lower.  Change type.
3989         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3990         Update.
3991         (coff_free_info): Remove.
3992
3993 2019-05-08  Tom Tromey  <tom@tromey.com>
3994
3995         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3996         (fbsd_pspace_data_handle): Move lower.  Change type.
3997         (get_fbsd_pspace_data): Update.
3998         (fbsd_pspace_data_cleanup): Remove.
3999         (_initialize_fbsd_tdep): Update.
4000
4001 2019-05-08  Tom Tromey  <tom@tromey.com>
4002
4003         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4004         (get_ada_tasks_pspace_data): Update.
4005         (ada_tasks_pspace_data_cleanup): Remove.
4006         (_initialize_tasks): Update.
4007         (ada_tasks_inferior_data_handle): Change type.
4008         (get_ada_tasks_inferior_data): Update.
4009         (ada_tasks_inferior_data_cleanup): Remove.
4010         (struct ada_tasks_pspace_data): Add initializers.
4011
4012 2019-05-08  Tom Tromey  <tom@tromey.com>
4013
4014         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4015         * symfile-debug.c (debug_sym_get_probes): Change type.
4016         * stap-probe.c (handle_stap_probe):
4017         (stap_static_probe_ops::get_probes): Change type.
4018         * probe.h (class static_probe_ops) <get_probes>: Change type.
4019         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4020         (parse_probes_in_pspace): Update.
4021         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4022         Update.
4023         (any_static_probe_ops::get_probes): Change type.
4024         * elfread.c (elfread_data): New typedef.
4025         (probe_key): Change type.
4026         (elf_get_probes): Likewise.  Update.
4027         (probe_key_free): Remove.
4028         (_initialize_elfread): Update.
4029         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4030         Change type.
4031         (dtrace_process_dof_probe, dtrace_process_dof)
4032         (dtrace_static_probe_ops::get_probe): Change type.
4033
4034 2019-05-08  Tom Tromey  <tom@tromey.com>
4035
4036         * xcoffread.c (struct xcoff_symfile_info): Rename from
4037         coff_symfile_info.  Add initializers.
4038         (xcoff_objfile_data_key): Move lower.  Change type.
4039         (XCOFF_DATA): Rewrite.
4040         (xcoff_free_info): Remove.
4041         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4042         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4043         (xcoff_initial_scan): Update.
4044
4045 2019-05-08  Tom Tromey  <tom@tromey.com>
4046
4047         * solib-svr4.c (struct svr4_info): Add initializers and
4048         destructor.
4049         <probes_table>: Now an htab_up.
4050         (solib_svr4_pspace_data): Change type.
4051         (free_probes_table): Simplify.
4052         (~svr4_info): Rename from svr4_pspace_data_cleanup.
4053         (get_svr4_info, probes_table_htab_remove_objfile_probes)
4054         (probes_table_remove_objfile_probes, register_solib_event_probe)
4055         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4056         (_initialize_svr4_solib): Update.
4057
4058 2019-05-08  Tom Tromey  <tom@tromey.com>
4059
4060         * remote.c (remote_pspace_data): Change type.
4061         (remote_pspace_data_cleanup): Remove.
4062         (get_remote_exec_file, set_pspace_remote_exec_file)
4063         (_initialize_remote): Update.
4064
4065 2019-05-08  Tom Tromey  <tom@tromey.com>
4066
4067         * breakpoint.c (breakpoint_objfile_key): Change type.
4068         (get_breakpoint_objfile_data): Update.
4069         (free_breakpoint_objfile_data): Remove.
4070         (_initialize_breakpoint): Update.
4071
4072 2019-05-08  Tom Tromey  <tom@tromey.com>
4073
4074         * linux-tdep.c (struct linux_info): Add initializers.
4075         (linux_inferior_data): Move.  Change type.
4076         (invalidate_linux_cache_inf): Update.
4077         (linux_inferior_data_cleanup): Remove.
4078         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4079
4080 2019-05-08  Tom Tromey  <tom@tromey.com>
4081
4082         * auxv.c (auxv_inferior_data): Move.  Change type.
4083         (auxv_inferior_data_cleanup): Remove.
4084         (invalidate_auxv_cache_inf): Rewrite.
4085         (get_auxv_inferior_data, _initialize_auxv): Update.
4086
4087 2019-05-08  Tom Tromey  <tom@tromey.com>
4088
4089         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4090         (symfile_debug_objfile_data_key): Change type.
4091         (symfile_debug_installed, debug_qf_has_symbols)
4092         (debug_qf_find_last_source_symtab)
4093         (debug_qf_forget_cached_source_info)
4094         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4095         (debug_qf_print_stats, debug_qf_dump)
4096         (debug_qf_expand_symtabs_for_function)
4097         (debug_qf_expand_all_symtabs)
4098         (debug_qf_expand_symtabs_with_fullname)
4099         (debug_qf_map_matching_symbols)
4100         (debug_qf_expand_symtabs_matching)
4101         (debug_qf_find_pc_sect_compunit_symtab)
4102         (debug_qf_map_symbol_filenames)
4103         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4104         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4105         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4106         (debug_sym_read_linetable, debug_sym_relocate): Update.
4107         (symfile_debug_free_objfile): Remove.
4108         (install_symfile_debug_logging, _initialize_symfile_debug):
4109         Update.
4110
4111 2019-05-08  Tom Tromey  <tom@tromey.com>
4112
4113         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4114         allocate_on_obstack.
4115         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4116         (get_dwarf2_per_objfile): Update.
4117         (set_dwarf2_per_objfile): Remove.
4118         (dwarf2_has_info, dwarf2_get_section_info): Update.
4119         (dwarf2_free_objfile): Remove.
4120         (_initialize_dwarf2_read): Update.
4121
4122 2019-05-08  Tom Tromey  <tom@tromey.com>
4123
4124         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4125         initializers.
4126         <unsupported_script_warning_printed,
4127         script_not_found_warning_printed>: Now bool.
4128         (auto_load_pspace_data): Change type.
4129         (~auto_load_pspace_info): Rename from
4130         auto_load_pspace_data_cleanup.
4131         (get_auto_load_pspace_data, init_loaded_scripts_info)
4132         (clear_section_scripts, maybe_print_unsupported_script_warning)
4133         (maybe_print_script_not_found_warning, _initialize_auto_load):
4134         Update.
4135
4136 2019-05-08  Tom Tromey  <tom@tromey.com>
4137
4138         * objfiles.c (objfile_pspace_info): Add destructor and
4139         initializers.
4140         (objfiles_pspace_data): Change type.
4141         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4142         (get_objfile_pspace_data): Update.
4143         (objfiles_bfd_data): Change type.
4144         (get_objfile_bfd_data): Update.
4145         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4146
4147 2019-05-08  Tom Tromey  <tom@tromey.com>
4148
4149         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4150         Change type.
4151         (get_catch_syscall_inferior_data): Update.
4152         (catch_syscall_inferior_data_cleanup): Remove.
4153         (_initialize_break_catch_syscall): Update.
4154
4155 2019-05-08  Tom Tromey  <tom@tromey.com>
4156
4157         * inflow.c (struct terminal_info): Add destructor and
4158         initializers.
4159         (inflow_inferior_data): Change type.
4160         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4161         (get_inflow_inferior_data, inflow_inferior_exit)
4162         (swap_terminal_info, _initialize_inflow): Update.
4163
4164 2019-05-08  Tom Tromey  <tom@tromey.com>
4165
4166         * target-dcache.c (target_dcache_cleanup): Remove.
4167         (target_dcache_aspace_key): Change type.
4168         (target_dcache_init_p, target_dcache_invalidate)
4169         (target_dcache_get, target_dcache_get_or_init)
4170         (_initialize_target_dcache): Update.
4171         * dcache.h (struct dcache_deleter): New.
4172
4173 2019-05-08  Tom Tromey  <tom@tromey.com>
4174
4175         * symtab.c (struct symbol_cache): Add destructor and
4176         initializers.
4177         (symbol_cache_key): Move.  Change type.
4178         (make_symbol_cache, free_symbol_cache): Remove.
4179         (get_symbol_cache): Update.
4180         (symbol_cache_cleanup): Remove.
4181         (ALL_PSPACES, symbol_cache_flush)
4182         (maintenance_print_symbol_cache)
4183         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4184         Update.
4185
4186 2019-05-08  Tom Tromey  <tom@tromey.com>
4187
4188         * symtab.c (struct main_info): Add destructor and initializers.
4189         (main_progspace_key): Move.  Change type.
4190         (get_main_info): Update.
4191         (main_info_cleanup): Remove.
4192         (_initialize_symtab): Update.
4193
4194 2019-05-08  Tom Tromey  <tom@tromey.com>
4195
4196         * registry.h (DECLARE_REGISTRY): Define the _key class.
4197
4198 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4199
4200         * NEWS: Merge two 'New commands' sections.
4201
4202 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4203
4204         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4205         parameter and use Ada language definition instead.
4206         (ada_val_print_ptr): Remove unused language parameter.
4207         (ada_val_print_num): Remove language parameter and use Ada language
4208         definition instead.
4209         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4210         parameter.
4211         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4212         parameter and use Ada language definition instead.
4213         (ada_val_print_1): Update all ada_val_print_xxx calls.
4214         Remove language parameter.
4215         (ada_val_print): Update ada_val_print_1 call.
4216
4217 2019-05-08  Tom Tromey  <tromey@adacore.com>
4218
4219         * remote.c (remote_hw_watchpoint_limit)
4220         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4221         Now static.
4222
4223 2019-05-08  Tom Tromey  <tromey@adacore.com>
4224
4225         * maint.c (_initialize_maint_cmds): Move initialization code to
4226         remote.c.
4227         (watchdog, show_watchdog): Move to remote.c.
4228         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4229         "watchdog" static.
4230         (_initialize_remote): Move initialization code from maint.c.
4231         * defs.h (watchdog): Don't declare.
4232
4233 2019-05-08  Tom Tromey  <tromey@adacore.com>
4234
4235         * tui/tui-interp.c: Include main.h.
4236         * interps.c: Include main.h.
4237         * main.h (interpreter_p): Declare.
4238         * defs.h (interpreter_p): Don't declare.
4239
4240 2019-05-08  Tom Tromey  <tromey@adacore.com>
4241
4242         * dwarf2loc.c: Include dwarf2read.h.
4243         * defs.h (read_unsigned_leb128): Don't declare.
4244         * dwarf2read.h (read_unsigned_leb128): Declare.
4245
4246 2019-05-08  Tom Tromey  <tromey@adacore.com>
4247
4248         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4249         method.
4250
4251 2019-05-08  Tom Tromey  <tromey@adacore.com>
4252
4253         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4254         when no wrap column is set.
4255
4256 2019-05-08  Tom Tromey  <tromey@adacore.com>
4257
4258         * c-lang.c (c_get_string): Handle non-C-style arrays.
4259
4260 2019-05-08  Tom Tromey  <tromey@adacore.com>
4261
4262         * typeprint.c (print_offset_data::update): Print the bit offset,
4263         not the number of bits remaining.
4264
4265 2019-05-08  Tom Tromey  <tromey@adacore.com>
4266
4267         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4268         padding at end of comment.
4269
4270 2019-05-08  Tom Tromey  <tromey@adacore.com>
4271
4272         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4273         Compare main types.
4274
4275 2019-05-06  Tom Tromey  <tom@tromey.com>
4276
4277         * common/scoped_mmap.c: Include common-defs.h.
4278         * common/scoped_mmap.h: Don't include config.h.
4279
4280 2019-05-04  Tom Tromey  <tom@tromey.com>
4281
4282         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4283         (struct aarch64_call_info): Add initializers.
4284         <si>: Now a std::vector.
4285         (pass_on_stack, aarch64_push_dummy_call): Update.
4286
4287 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4288             Tom Tromey  <tom@tromey.com>
4289
4290         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4291         (ppc_threads): Now a std::vector.  Now static.
4292         (hwdebug_find_thread_points_by_tid)
4293         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4294         Update.
4295
4296 2019-05-04  Tom Tromey  <tom@tromey.com>
4297
4298         * arc-tdep.c (arc_tdesc_init): Return bool.
4299
4300 2019-05-04  Tom Tromey  <tom@tromey.com>
4301
4302         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4303         Use gdb_assert_not_reached.
4304
4305 2019-05-04  Tom Tromey  <tom@tromey.com>
4306
4307         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4308         "false".
4309
4310 2019-05-04  Tom Tromey  <tom@tromey.com>
4311
4312         * arc-tdep.c (arc_tdesc_init): Use bool.
4313
4314 2019-05-04  Tom Tromey  <tom@tromey.com>
4315
4316         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4317
4318 2019-05-04  Tom Tromey  <tom@tromey.com>
4319
4320         * cli/cli-cmds.c (valid_command_p): Return bool.
4321
4322 2019-05-04  Tom Tromey  <tom@tromey.com>
4323
4324         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4325         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4326
4327 2019-05-04  Raul Tambre  <raul@tambre.ee>
4328
4329         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4330         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4331         operator for comparison.
4332
4333 2019-05-04  Tom Tromey  <tom@tromey.com>
4334
4335         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4336         (lookup_partial_symbol, print_partial_symbols)
4337         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4338         (psymbol_compare): Update.
4339         (add_psymbol_to_bcache): Clear the entire psymbol.
4340         (maintenance_check_psymtabs): Update.
4341         * psympriv.h (struct partial_symbol): Don't derive from
4342         general_symbol_info.
4343         <obj_section, unrelocated_address, address,
4344         set_unrelocated_address>: Update.
4345         <ginfo>: New member.
4346         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4347         (debug_names::write_psymbols): Update.
4348
4349 2019-05-04  Tom de Vries  <tdevries@suse.de>
4350
4351         * contrib/cc-with-tweaks.sh: Support -n arg.
4352
4353 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4354
4355         * corelow.c (core_target::detach): Ensure frame cache and
4356         register caches are cleared.
4357         inferior.c (exit_inferior_1): Likewise.
4358
4359 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4360             Tom Tromey  <tom@tromey.com>
4361
4362         * dictionary.c (collate_pending_symbols_by_language): Remove
4363         "struct" from foreach.
4364         * symtab.c (lookup_global_symbol_from_objfile)
4365         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4366         foreach.
4367         * ser-tcp.c (net_open): Remove "struct" from foreach.
4368         * objfiles.c (objfile_relocate, objfile_rebase)
4369         (objfile_has_symbols): Remove "struct" from foreach.
4370         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4371         from foreach.
4372         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4373         foreach.
4374         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4375         "struct" from foreach.
4376         * ada-lang.c (create_excep_cond_exprs)
4377         (ada_exception_catchpoint_cond_string): Remove "struct" from
4378         foreach.
4379
4380 2019-05-03  Tom Tromey  <tromey@adacore.com>
4381
4382         * ada-exp.y (convert_char_literal): Check suffix of each
4383         enumerator.
4384
4385 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4386
4387         PR ada/21406:
4388         * ada-exp.y (yywrap): Don't define.
4389         * ada-lex.l (%option): Add noyywrap
4390         (yywrap): Remove.
4391
4392 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4393
4394         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4395         _WIN32_WINNT to the XP level, unless already defined to a higher
4396         level.
4397
4398         * unittests/parse-connection-spec-selftests.c:
4399         * ser-tcp.c:
4400         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4401         override.
4402
4403         * symfile.c (find_separate_debug_file): Remove colon from the
4404         drive spec of DOS/Windows file names of the target, so that the
4405         file name produced from DEBUGDIR and the target's directory will
4406         be valid on DOS/Windows systems.
4407
4408 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4409
4410         * rust-lang.c (val_print_struct): Handle printing structures
4411         containing strings.
4412
4413 2019-05-02  Tom Tromey  <tromey@adacore.com>
4414
4415         * valarith.c (_initialize_valarith): Remove.
4416
4417 2019-05-01  Tom Tromey  <tromey@adacore.com>
4418
4419         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4420         bitfields.
4421
4422 2019-05-01  Tom Tromey  <tromey@adacore.com>
4423
4424         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4425         for big-endian copies.
4426
4427 2019-04-30  Ali Tamur  <tamur@google.com>
4428         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4429         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4430         (read_3_bytes): New function.
4431
4432 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4433
4434         * windows-nat.c (main_thread_id): Delete.
4435         (handle_output_debug_string): Replace main_thread_id by
4436         current_event.dwThreadId.
4437         (fake_create_process): Likewise.
4438         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4439         Do not set main_thread_id.
4440         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4441         current_event.dwThreadId.
4442         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4443
4444 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4445
4446         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4447         Use current_event.dwThreadId instead of main_thread_id.
4448
4449 2019-04-30  Tom Tromey  <tromey@adacore.com>
4450
4451         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4452         (create_excep_cond_exprs): Iterate over program spaces.
4453         (ada_exception_catchpoint_cond_string): Examine all minimal
4454         symbols for exception types.
4455
4456 2019-04-30  Tom Tromey  <tromey@adacore.com>
4457
4458         PR c++/24470:
4459         * dwarf2read.c (process_structure_scope): Handle case where type
4460         has template parameters but no symbol was created.
4461
4462 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4463             Chris January  <chris.january@arm.com>
4464
4465         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4466         qualifier.
4467         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4468
4469 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4470
4471         * f-typeprint.c (f_print_type): Update rules for printing
4472         whitespace.
4473         (f_type_print_varspec_suffix): Likewise.
4474
4475 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4476             Chris January  <chris.january@arm.com>
4477
4478         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4479         function arguments.
4480
4481 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4482
4483         * f-lang.c (build_fortran_types): Change name of void type to
4484         lower case.
4485         * f-typeprint.c (f_type_print_base): Print the name of the void
4486         type, rather than a fixed string.
4487         * f-valprint.c (f_decorations): Use lower case void string.
4488
4489 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4490             Chris January  <chris.january@arm.com>
4491
4492         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4493         types for Fortran.
4494
4495 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4496             Chris January  <chris.january@arm.com>
4497             David Lecomber  <david.lecomber@arm.com>
4498
4499         * f-exp.y (BINOP_INTRINSIC): New token.
4500         (exp): New parser rule handling BINOP_INTRINSIC.
4501         (f77_keywords): Add new builtin procedures.
4502         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4503         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4504         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4505         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4506         (print_unop_subexp_f): New function.
4507         (print_binop_subexp_f): New function.
4508         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4509         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4510         (dump_subexp_body_f): Likewise.
4511         (operator_check_f): Likewise.
4512         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4513         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4514
4515 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4516
4517         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4518         UNOP_KIND.
4519         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4520         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4521         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4522         (operator_length_f): New fuction.
4523         (print_subexp_f): New function.
4524         (op_name_f): New function.
4525         (dump_subexp_body_f): New function.
4526         (operator_check_f): New function.
4527         (exp_descriptor_f): Replace standard expression handling functions
4528         with new functions.
4529         * gdb/fortran-operator.def: New file.
4530         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4531         * gdb/std-operator.def: Remove UNOP_KIND.
4532
4533 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4534
4535         * std-operator.def: Remove unbalanced, stray double quote
4536         character.
4537
4538 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4539             Chris January  <chris.january@arm.com>
4540             Daniel Everett  <daniel.everett@arm.com>
4541             Nick Forrington  <nick.forrington@arm.com>
4542             Richard Bunt  <richard.bunt@arm.com>
4543
4544         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4545         of depth when printing anonymous structs or unions.
4546         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4547         Don't print either the top-level value, or the children if the
4548         max-depth is exceeded.
4549         (ppscm_print_children): When printing the key of a map, allow one
4550         extra level of depth.
4551         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4552         print either the top-level value, or the children if the max-depth
4553         is exceeded.
4554         (print_children): When printing the key of a map, allow one extra
4555         level of depth.
4556         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4557         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4558         (user_print_options): Initialise max_depth field.
4559         (val_print_scalar_or_string_type_p): New function.
4560         (val_print): Check to see if the max depth has been reached.
4561         (val_print_check_max_depth): Define new function.
4562         (show_print_max_depth): New function.
4563         (_initialize_valprint): Add 'print max-depth' option.
4564         * valprint.h (struct value_print_options) <max_depth>: New field.
4565         (val_print_check_max_depth): Declare new function.
4566         * NEWS: Document new feature.
4567
4568 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4569
4570         * ada-lang.c (ada_language_defn): Initialise new field.
4571         * c-lang.c (c_is_string_type_p): New function.
4572         (c_language_defn): Initialise new field.
4573         (cplus_language_defn): Initialise new field.
4574         (asm_language_defn): Initialise new field.
4575         (minimal_language_defn): Initialise new field.
4576         * c-lang.h (c_is_string_type_p): Declare new function.
4577         * d-lang.c (d_language_defn): Initialise new field.
4578         * f-lang.c (f_is_string_type_p): New function.
4579         (f_language_defn): Initialise new field.
4580         * go-lang.c (go_is_string_type_p): New function.
4581         (go_language_defn): Initialise new field.
4582         * language.c (default_is_string_type_p): New function.
4583         (unknown_language_defn): Initialise new field.
4584         (auto_language_defn): Initialise new field.
4585         * language.h (struct language_defn) <la_is_string_type_p>: New
4586         member variable.
4587         (default_is_string_type_p): Declare new function.
4588         * m2-lang.c (m2_language_defn): Initialise new field.
4589         * objc-lang.c (objc_language_defn): Initialise new field.
4590         * opencl-lang.c (opencl_language_defn): Initialise new field.
4591         * p-lang.c (pascal_is_string_type_p): New function.
4592         (pascal_language_defn): Initialise new field.
4593         * rust-lang.c (rust_is_string_type_p): New function.
4594         (rust_language_defn): Initialise new field.
4595
4596 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4597
4598         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4599         New field.
4600         * ada-lang.c (ada_language_defn): Initialise new field.
4601         * c-lang.c (c_language_defn): Likewise.
4602         (cplus_language_defn): Likewise.
4603         (asm_language_defn): Likewise.
4604         (minimal_language_defn): Likewise.
4605         * d-lang.c (d_language_defn): Likewise.
4606         * f-lang.c (f_language_defn): Likewise.
4607         * go-lang.c (go_language_defn): Likewise.
4608         * language.c (unknown_language_defn): Likewise.
4609         (auto_language_defn): Likewise.
4610         * m2-lang.c (m2_language_defn): Likewise.
4611         * objc-lang.c (objc_language_defn): Likewise.
4612         * opencl-lang.c (opencl_language_defn): Likewise.
4613         * p-lang.c (pascal_language_defn): Likewise.
4614         * rust-lang.c (rust_language_defn): Likewise.
4615
4616 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4617
4618         * ada-lang.c (ada_is_character_type): Change return type to bool.
4619         (ada_is_string_type): Likewise.
4620         * ada-lang.h (ada_is_character_type): Update declaration
4621         (ada_is_string_type): Likewise.
4622
4623 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4624
4625         Support style in 'frame|thread apply'
4626
4627         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4628         * record.c (record_start, record_stop): Update callers of
4629         execute_command_to_string with false.
4630         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4631         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4632         methods.
4633         (class string_file): New constructor with term_out parameter.
4634         Override methods term_out and can_emit_style_escape.  New member
4635         term_out.
4636         (class stdio_file): Override can_emit_style_escape.
4637         (class tee_file): Override term_out and can_emit_style_escape.
4638         * utils.h (can_emit_style_escape): Remove.
4639         * utils.c (can_emit_style_escape): Likewise.
4640         Update all callers of can_emit_style_escape (SOMESTREAM) to
4641         SOMESTREAM->can_emit_style_escape.
4642         * source-cache.c (source_cache::get_source_lines): Likewise.
4643         * stack.c (frame_apply_command_count): Call execute_command_to_string
4644         passing the term_out characteristic of the current gdb_stdout.
4645         * thread.c (thr_try_catch_cmd): Likewise.
4646         * top.c (execute_command_to_string): pass term_out parameter
4647         to construct the string_file for the command output.
4648         * ui-file.c (term_cli_styling): New function (most code moved
4649         from utils.c can_emit_style_escape).
4650         (string_file::string_file, string_file::can_emit_style_escape,
4651         stdio_file::can_emit_style_escape, tee_file::term_out,
4652         tee_file::can_emit_style_escape): New functions.
4653
4654 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4655
4656         * NEWS: Mention the new set|show may-call-functions.
4657         * infcall.c (may_call_functions_p): New variable.
4658         (show_may_call_functions_p): New function.
4659         (call_function_by_hand_dummy): Throws an error if not
4660         may-call-functions.
4661         (_initialize_infcall): Call add_setshow_boolean_cmd for
4662         may-call-functions.
4663
4664 2019-04-25  Keith Seitz  <keiths@redhat.com>
4665
4666         PR c++/24367
4667         * cp-support.c (inspect_type): Don't attempt substitutions
4668         of symbol with the same name.
4669
4670 2019-04-25  Tom Tromey  <tromey@adacore.com>
4671
4672         PR gdb/24475:
4673         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4674         static.
4675
4676 2019-04-25  Tom Tromey  <tromey@adacore.com>
4677
4678         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4679         rvalue reference.
4680         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4681         (gdb_xml_parser::parse): Use std::move.
4682         * python/python-internal.h (gdbpy_convert_exception): Take a const
4683         reference.
4684         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4685         std::move.
4686         * python/py-utils.c (gdbpy_convert_exception): Take a const
4687         reference.
4688         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4689         Use std::move.
4690         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4691         Use std::move.
4692         * mi/mi-main.c (mi_print_exception): Take a const reference.
4693         * main.c (handle_command_errors): Take a const reference.
4694         * linespec.c (parse_linespec): Use std::move.
4695         * infcall.c (run_inferior_call): Use std::move.
4696         (call_function_by_hand_dummy): Use std::move.
4697         * exec.c (try_open_exec_file): Use std::move.
4698         * exceptions.h (exception_print, exception_fprintf)
4699         (exception_print_same): Update.
4700         * exceptions.c (print_exception, exception_print)
4701         (exception_fprintf, exception_print_same): Change parameters to
4702         const reference.
4703         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4704         * common/new-op.c: Use std::move.
4705         * common/common-exceptions.h (struct gdb_exception): Add move
4706         constructor.
4707         (struct gdb_exception_error, struct gdb_exception_quit, struct
4708         gdb_quit_bad_alloc): Change constructor to move constructor.
4709         (throw_exception): Change parameter to rvalue reference.
4710         * common/common-exceptions.c (throw_exception): Take rvalue
4711         reference.
4712         * cli/cli-interp.c (safe_execute_command): Use std::move.
4713         * breakpoint.c (insert_bp_location, location_to_sals): Use
4714         std::move.
4715
4716 2019-04-25  Tom Tromey  <tromey@adacore.com>
4717
4718         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4719         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4720         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4721         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4722         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4723         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4724         guile/scm-value.c: Use unpack.
4725         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4726         gdbscm_gdb_exception.
4727         (gdbscm_throw_gdb_exception): Likewise.
4728         (struct gdbscm_gdb_exception): New.
4729         (unpack): New function.
4730         (gdbscm_wrap): Use unpack.
4731
4732 2019-04-25  Tom Tromey  <tromey@adacore.com>
4733
4734         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4735         (gdb_rl_callback_handler): Use std::move.
4736         * common/common-exceptions.h (struct gdb_exception): Add move
4737         assignment operator.
4738         (throw_exception_sjlj): Change "exception" to const reference.
4739         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4740         (throw_exception_sjlj): Change "exception" to const reference.
4741
4742 2019-04-25  Tom Tromey  <tromey@adacore.com>
4743
4744         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4745         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4746         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4747         Update.
4748         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4749         Update.
4750         * mi/mi-interp.c (mi_interp::exec): Update.
4751         * linespec.c (parse_linespec): Update.
4752         * infcall.c (run_inferior_call): Update.
4753         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4754         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4755         (gdbscm_lookup_global_symbol): Update.
4756         * guile/scm-param.c (gdbscm_parameter_value): Update.
4757         * guile/scm-frame.c (gdbscm_frame_read_register)
4758         (gdbscm_frame_read_var): Update.
4759         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4760         * exec.c (try_open_exec_file): Update.
4761         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4762         (gdb_rl_callback_handler): Update.
4763         * common/common-exceptions.h (exception_none): Don't declare.
4764         * common/common-exceptions.c (exception_none): Don't define.
4765         (struct catcher) <exception>: Update.
4766         * cli/cli-interp.c (safe_execute_command): Update.
4767         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4768
4769 2019-04-25  Ali Tamur  <tamur@google.com>
4770
4771         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4772         (read_attribute_value): Likewise.
4773         (dwarf2_read_addr_index): Update comment.
4774         (read_str_index): Add DW_FORM_strx.
4775         (dwarf2_string_attr): Likewise.
4776         (dwarf2_const_value_attr): Likewise.
4777         (dump_die_shallow): Likewise.
4778         (dwarf2_fetch_constant_bytes): Likewise.
4779         (skip_form_bytes): Likewise.
4780         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4781
4782 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4783
4784         PR corefiles/11608
4785         PR corefiles/18187
4786         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4787         OFFSET.  Verify if current mapping contains an ELF header.
4788         (linux_find_memory_regions_full): Adjust call to
4789         dump_mapping_p.
4790
4791 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4792             Kang Li <kanglictf@gmail.com>
4793
4794         PR gdb/21600
4795
4796         * dwarf2-frame.c (read_initial_length): Be consistent about using
4797         unsigned representation of length.
4798         (decode_frame_entry_1): Likewise.  Check for wraparound of
4799         end pointer as well as buffer overflow.
4800
4801 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4802
4803         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4804         "vq".
4805
4806 2019-04-24  Tom Tromey  <tromey@adacore.com>
4807
4808         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4809
4810 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4811
4812         * s12z-tdep.c (s12z_unwind_pc): Delete.
4813         (s12z_unwind_sp): Delete.
4814         (s12z_gdbarch_init): Don't register deleted functions with
4815         gdbarch.
4816
4817 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4818
4819         * rl78-tdep.c (rl78_unwind_sp): Delete.
4820         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4821
4822 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4823
4824         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4825         (xstormy16_unwind_pc): Delete.
4826         (xstormy16_dummy_id): Delete.
4827         (xstormy16_gdbarch_init): Don't register deleted functions with
4828         gdbarch.
4829
4830 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4831
4832         * vax-tdep.c (vax_unwind_pc): Delete.
4833         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4834
4835 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4836
4837         * v850-tdep.c (v850_unwind_sp): Delete.
4838         (v850_unwind_pc): Delete.
4839         (v850_dummy_id): Delete.
4840         (v850_gdbarch_init): Don't register deleted functions with
4841         gdbarch.
4842
4843 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4844
4845         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4846         (tilegx_unwind_pc): Delete.
4847         (tilegx_unwind_dummy_id): Delete.
4848         (tilegx_gdbarch_init): Don't register deleted functions with
4849         gdbarch.
4850
4851 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4852
4853         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4854         (tic6x_dummy_id): Delete.
4855         (tic6x_gdbarch_init): Don't register deleted functions with
4856         gdbarch.
4857
4858 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4859
4860         * sparc-tdep.c (sparc_unwind_pc): Delete.
4861         (sparc32_gdbarch_init): Don't register deleted function with
4862         gdbarch.
4863
4864 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4865
4866         * sh-tdep.c (sh_unwind_sp): Delete.
4867         (sh_unwind_pc): Delete.
4868         (sh_dummy_id): Delete.
4869         (sh_gdbarch_init): Don't register deleted functions with
4870         gdbarch.
4871
4872 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4873
4874         * score-tdep.c (score_unwind_sp): Delete.
4875         (score_unwind_pc): Delete.
4876         (score_dummy_id): Delete.
4877         (score_gdbarch_init): Don't register deleted functions with
4878         gdbarch.
4879
4880 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4881
4882         * rx-tdep.c (rx_unwind_pc): Delete.
4883         (rx_unwind_sp): Delete.
4884         (rx_dummy_id): Delete.
4885         (rx_gdbarch_init): Don't register deleted functions with
4886         gdbarch.  Update comment.
4887
4888 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4889
4890         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4891         (rs6000_dummy_id): Delete.
4892         (rs6000_gdbarch_init): Don't register deleted functions with
4893         gdbarch.
4894
4895 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4896
4897         * or1k-tdep.c (or1k_dummy_id): Delete.
4898         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4899
4900 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4901
4902         * nios2-tdep.c (nios2_dummy_id): Delete.
4903         (nios2_unwind_sp): Delete.
4904         (nios2_gdbarch_init): Don't register deleted functions with
4905         gdbarch.
4906
4907 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4908
4909         * nds32-tdep.c (nds32_dummy_id): Delete.
4910         (nds32_unwind_pc): Delete.
4911         (nds32_unwind_sp): Delete.
4912         (nds32_gdbarch_init): Don't register deleted functions with
4913         gdbarch.
4914
4915 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4916
4917         * msp430-tdep.c (msp430_unwind_pc): Delete.
4918         (msp430_unwind_sp): Delete.
4919         (msp430_dummy_id): Delete.
4920         (msp430_gdbarch_init): Don't register deleted functions with
4921         gdbarch.
4922
4923 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4924
4925         * moxie-tdep.c (moxie_unwind_sp): Delete.
4926         (moxie_unwind_pc): Delete.
4927         (moxie_dummy_id): Delete.
4928         (moxie_gdbarch_init): Don't register deleted functions with
4929         gdbarch.
4930
4931 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4932
4933         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4934         (mn10300_unwind_pc): Delete.
4935         (mn10300_unwind_sp): Delete.
4936         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4937         mn10300_unwind_sp.
4938         (mn10300_frame_unwind_init): Don't register deleted functions with
4939         gdbarch.
4940
4941 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4942
4943         * mep-tdep.c (mep_unwind_pc): Delete.
4944         (mep_unwind_sp): Delete.
4945         (mep_dummy_id): Delete.
4946         (mep_gdbarch_init): Don't register deleted functions with
4947         gdbarch.
4948
4949 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4950
4951         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4952         (m68hc11_unwind_sp): Delete.
4953         (m68hc11_gdbarch_init): Don't register deleted functions with
4954         gdbarch.
4955
4956 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4957
4958         * m32r-tdep.c (m32r_unwind_sp): Delete.
4959         (m32r_unwind_pc): Delete.
4960         (m32r_dummy_id): Delete.
4961         (m32r_gdbarch_init): Don't register deleted functions with
4962         gdbarch.
4963
4964 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4965
4966         * m32c-tdep.c (m32c_unwind_pc): Delete.
4967         (m32c_unwind_sp): Delete.
4968         (m32c_dummy_id): Delete.
4969         (m32c_gdbarch_init): Don't register deleted functions with
4970         gdbarch.
4971
4972 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4973
4974         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4975         (lm32_unwind_pc): Delete.
4976         (lm32_dummy_id): Delete.
4977         (lm32_gdbarch_init): Don't register deleted functions with
4978         gdbarch.
4979
4980 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4981
4982         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4983         (iq2000_unwind_pc): Delete.
4984         (iq2000_dummy_id): Delete.
4985         (iq2000_gdbarch_init): Don't register deleted functions with
4986         gdbarch.
4987
4988 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4989
4990         * nds32-tdep.c (nds32_type_align): Delete.
4991         (nds32_push_dummy_call): Use type_align instead.
4992
4993 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4994
4995         * arm-tdep.c (arm_type_align): Only handle vector override case.
4996         (arm_push_dummy_call): Use type_align.
4997         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4998
4999 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5000
5001         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5002         case.
5003         (pass_on_stack): Use type_align.
5004         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5005         function.
5006
5007 2019-04-23  Tom Tromey  <tromey@adacore.com>
5008
5009         * dwarf2read.c (line_header::file_name_at): Remove unused
5010         overload.
5011
5012 2019-04-23  Tom de Vries  <tdevries@suse.de>
5013
5014         PR gdb/24438
5015         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5016         invocation.
5017
5018
5019 2019-03-27  Ali Tamur  <tamur@google.com>
5020
5021         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5022         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5023         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5024         (dwarf_expr_context::get_addr_index): Likewise
5025         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5026         (symbol_needs_eval_context::get_addr_index): Likewise
5027         (disassemble_dwarf_expression): Add DW_OP_addrx
5028         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5029         (read_cutu_die_from_dwo): Update comment
5030         (skip_one_die): Add DW_FORM_addrx
5031         (read_attribute_value): Likewise
5032         (var_decode_location): Add DW_OP_addrx
5033         (dwarf2_const_value_attr): Add DW_FORM_addrx
5034         (dump_die_shallow): Likewise
5035         (dwarf2_fetch_constant_bytes): Likewise
5036         (decode_locdesc): Add DW_OP_addrx
5037         (skip_form_bytes): Add DW_FORM_addrx
5038
5039 2019-04-22  Ali Tamur  <tamur@google.com>
5040
5041         * MAINTAINERS (Write After Approval): Add self.
5042
5043 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
5044
5045         * solib-svr4.c (get_svr4_info): Add pspace parameter.
5046         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5047         (open_symbol_file_object): Likewise.
5048         (svr4_default_sos): Add info parameter.
5049         (svr4_read_so_list): Likewise.
5050         (svr4_current_sos_direct): Adjust functions calls to pass down
5051         info.
5052         (svr4_current_sos_1): Add info parameter.
5053         (svr4_current_sos): Call get_svr4_info, pass info down to
5054         svr4_current_sos_1.
5055         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5056         get_svr4_info.
5057         (svr4_in_dynsym_resolve_code): Pass current_program_space to
5058         get_svr4_info.
5059         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5060         to get_svr4_info.
5061         (probes_table_remove_objfile_probes): Likewise.
5062         (register_solib_event_probe): Add info parameter.
5063         (solist_update_incremental): Pass info parameter down to
5064         svr4_read_so_list.
5065         (disable_probes_interface): Add info parameter.
5066         (svr4_handle_solib_event): Pass current_program_space to
5067         get_svr4_info.  Adjust disable_probes_interface cleanup.
5068         (svr4_create_probe_breakpoints): Add info parameter, pass it
5069         down to register_solib_event_probe.
5070         (svr4_create_solib_event_breakpoints): Add info parameter,
5071         pass it down to svr4_create_probe_breakpoints.
5072         (enable_break): Pass info down to
5073         svr4_create_solib_event_breakpoints.
5074         (svr4_solib_create_inferior_hook): Pass current_program_space to
5075         get_svr4_info.
5076         (svr4_clear_solib): Likewise.
5077
5078 2019-04-22  Pedro Alves  <palves@redhat.com>
5079
5080         * solib-svr4.c (svr4_free_objfile_observer): New.
5081         (probe_and_action::objfile): New field.
5082         (probes_table_htab_remove_objfile_probes)
5083         (probes_table_remove_objfile_probes): New functions.
5084         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5085         in the new probe_and_action.  Don't store the probe in 'lookup'.
5086         (svr4_create_probe_breakpoints): Pass objfile to
5087         register_solib_event_probe.
5088         (_initialize_svr4_solib): Register a free_objfile observer.
5089
5090 2019-04-19  Tom Tromey  <tom@tromey.com>
5091
5092         * common/queue.h: Remove.
5093
5094 2019-04-19  Tom Tromey  <tom@tromey.com>
5095
5096         * event-loop.c: Don't include "common/queue.h".
5097
5098 2019-04-19  Tom Tromey  <tom@tromey.com>
5099
5100         * remote.c (remote_target): Use delete.
5101         * remote-notif.h: Include <list>, not "common/queue.h".
5102         (notif_client_p): Remove typedef.
5103         (remote_notif_state): Add constructor, destructor, initializer.
5104         <notif_queue>: Now a std::list.
5105         (remote_notif_state_xfree): Don't declare.
5106         * remote-notif.c (remote_notif_process, handle_notification)
5107         (remote_notif_state_allocate): Update.
5108         (~remote_notif_state): Rename from remote_notif_state_xfree.
5109
5110 2019-04-19  Tom Tromey  <tom@tromey.com>
5111
5112         * symfile.c (reread_symbols): Update.
5113         * objfiles.c (objfile_register_static_link)
5114         (objfile_lookup_static_link): Update
5115         (~objfile) Don't delete static_links.
5116         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5117
5118 2019-04-19  Tom Tromey  <tom@tromey.com>
5119
5120         * type-stack.h (struct type_stack) <insert>: Constify string.
5121         * type-stack.c (type_stack::insert): Constify string.
5122         * gdbtypes.h (lookup_template_type): Update.
5123         (address_space_name_to_int): Update.
5124         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5125         const.
5126         (lookup_template_type): Make name const.
5127         * c-exp.y: Update rules.
5128         (lex_one_token, classify_name, classify_inner_name)
5129         (c_print_token): Update.
5130         * p-exp.y: Update rules.
5131         (yylex): Update.
5132         * f-exp.y: Update rules.
5133         (yylex): Update.
5134         * d-exp.y: Update rules.
5135         (lex_one_token, classify_name, classify_inner_name): Update.
5136         * parse.c (write_dollar_variable, copy_name): Return std::string.
5137         * parser-defs.h (copy_name): Change return type.
5138         * m2-exp.y: Update rules.
5139         (yylex): Update.
5140         * go-exp.y (lex_one_token): Update.
5141         Update rules.
5142         (classify_unsafe_function, classify_packaged_name)
5143         (classify_name, yylex): Update.
5144
5145 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5146
5147         * configure.ac: add --enable-source-highlight switch.
5148         * configure: Regenerate.
5149         * top.c (print_gdb_version): plumb --enable-source-highlight
5150         status to "show configuration".
5151
5152 2019-04-19  Tom Tromey  <tromey@adacore.com>
5153
5154         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5155         Check ADA_TYPE_P.
5156         (empty_record, ada_template_to_fixed_record_type_1)
5157         (template_to_static_fixed_type)
5158         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5159         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5160         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5161         macros.
5162
5163 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5164
5165         PR symtab/24423:
5166         * source.c (print_source_lines_base): Advance "iter" when a
5167         control character is seen.
5168
5169 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5170
5171         * inferior.h (struct infcall_suspend_state_deleter):
5172         Catch exception in destructor to avoid crash.
5173
5174 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5175
5176         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5177         close to the add_com "shell".
5178
5179 2019-04-18  Tom Tromey  <tromey@adacore.com>
5180
5181         * process-stratum-target.h (class process_stratum_target)
5182         <stratum>: Add "final".
5183
5184 2019-04-17  Tom Tromey  <tromey@adacore.com>
5185
5186         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5187         against nullptr before use.
5188
5189 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5190
5191         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5192
5193 2019-04-17  Jim Wilson  <jimw@sifive.com>
5194             Andrew Burgess  <andrew.burgess@embecosm.com>
5195
5196         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5197         code read might fail, assume 4-byte breakpoint in that case.
5198
5199 2019-04-15  Leszek Swirski  <leszeks@google.com>
5200
5201         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5202         rather than a hand-rolled POD check when checking for forced MEMORY
5203         classification.
5204
5205 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5206
5207         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5208         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5209         function.
5210         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5211         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5212         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5213         declaration.
5214
5215 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5216
5217         * aarch64-linux-nat.c
5218         (aarch64_linux_nat_target::thread_architecture): Add override.
5219         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5220         each VQ.
5221
5222 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5223
5224         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5225
5226 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5227
5228         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5229         target types of size 96-bits, add some additional comments, and
5230         check that the builtin type we found was the correct size.
5231
5232 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5233
5234         * utils.c (prompt_for_continue): Don't restore the styling at the
5235         end, as applied_style has the wrong value.  This fixes styling in
5236         long lists of file names that are interrupted by the "Continue?"
5237         prompt.
5238
5239 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5240
5241         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5242         * c-lang.c (c_language_defn): Likewise.
5243         (cplus_language_defn): Likewise.
5244         (asm_language_defn): Likewise.
5245         (minimal_language_defn): Likewise.
5246         * d-lang.c (d_language_defn): Likewise.
5247         * f-lang.c (f_language_defn): Likewise.
5248         * go-lang.c (go_language_defn): Likewise.
5249         * language.c (unknown_language_defn): Likewise.
5250         (auto_language_defn): Likewise.
5251         * language.h (struct language_defn): Remove la_magic field.
5252         (LANG_MAGIC): Delete.
5253         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5254         * objc-lang.c (objc_language_defn): Likewise.
5255         * opencl-lang.c (opencl_language_defn): Likewise.
5256         * p-lang.c (pascal_language_defn): Likewise.
5257         * rust-lang.c (rust_language_defn): Likewise.
5258
5259 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5260
5261         * riscv-tdep.c (riscv_type_align): New function.
5262         (riscv_type_alignment): Delete.
5263         (riscv_arg_location): Use 'type_align'.
5264         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5265
5266 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5267
5268         * gdbtypes.c (type_align): A struct with no non-static fields also
5269         has alignment of 1.
5270
5271 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5272
5273         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5274         component to 0.
5275         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5276         member.
5277         (riscv_struct_info::analyse): New implementation using new
5278         analyse_inner member function.
5279         (riscv_struct_info::field_offset): New member function.
5280         (riscv_struct_info::m_offsets): New member variable.
5281         (riscv_struct_info::analyse_inner): New private member function,
5282         takes the old implementation of riscv_struct_info::analyse but
5283         extended to track field offsets.
5284         (riscv_call_arg_struct): Update the struct folding special cases
5285         to handle cases where empty C++ structs, which are non-zero
5286         length, are found.
5287         (riscv_arg_location): Initialise the length of each location, a
5288         non-zero length now indicates the location is in use.
5289         (riscv_push_dummy_call): Allow for the first location having a
5290         non-zero offset when setting up arguments.
5291         (riscv_return_value): Likewise, but for return values.
5292
5293 2019-04-11  Tom Tromey  <tromey@adacore.com>
5294
5295         * utils.c (internal_vproblem): Make "msg" const.
5296
5297 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5298
5299         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5300         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5301         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5302         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5303
5304 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5305
5306         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5307         function.
5308         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5309         of amd64_collect_native_gregset.
5310         (amd64_linux_nat_target::store_registers): Likewise.
5311
5312 2019-04-10  Tom Tromey  <tom@tromey.com>
5313
5314         * symtab.c (lookup_global_symbol_from_objfile)
5315         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5316         * objfiles.h (class separate_debug_iterator): New.
5317         (class separate_debug_range): New.
5318         (struct objfile) <separate_debug_objfiles>: New method.
5319         (objfile_separate_debug_iterate): Don't declare.
5320         * objfiles.c (separate_debug_iterator::operator++): Rename from
5321         objfile_separate_debug_iterate.
5322         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5323         iterator.
5324         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5325         iterator.
5326
5327 2019-04-10  Tom Tromey  <tom@tromey.com>
5328
5329         * symfile.c (reread_symbols): Remove old comment.
5330         * objfiles.c (free_all_objfiles): Fix a typo.
5331
5332 2019-04-10  Tom Tromey  <tom@tromey.com>
5333
5334         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5335         * minsyms.c (lookup_minimal_symbol): Use foreach.
5336         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5337         (lookup_minimal_symbol_solib_trampoline): Likewise.
5338         * symfile.c (reread_symbols): Use foreach.
5339
5340 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5341             Tom Tromey  <tromey@adacore.com>
5342
5343         PR rust/24414:
5344         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5345         (rust_lex_int_test): Change "value" to be LONGEST.
5346         (rust_lex_tests): Add test for long integer literal.
5347
5348 2019-04-09  Tom Tromey  <tromey@adacore.com>
5349
5350         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5351         to bool.
5352         (extended_remote_target::attach): Update.
5353         (remote_target::remote_notice_new_inferior): Update.
5354         (remote_target::add_current_inferior_and_thread): Update.
5355         * inferior.c (exit_inferior_1): Use "false".
5356         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5357
5358 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5359
5360         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5361         the "start" command.
5362
5363 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5364
5365         * python/py-inferior.c (infpy_thread_from_thread_handle):
5366         Adjust comments to reflect renaming of thread_from_thread_handle
5367         to thread_from_handle.  Adjust keywords.  Fix type error message.
5368         (inferior_object_methods): Add thread_from_handle.  Retain
5369         thread_from_thread_handle, but mark it as deprecated.
5370
5371 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5372
5373         * gdbthread.h (find_thread_by_handle): Revise declaration.
5374         * thread.c (find_thread_by_handle): Likewise.  Adjust
5375         implementation too.
5376         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5377         support for buffer objects as handles.
5378
5379 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5380
5381         * python/py-infthread.c (thpy_thread_handle): New function.
5382         (thread_object_methods): Register thpy_thread_handle.
5383
5384 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5385
5386         * gdbthread.h (thread_to_thread_handle): Declare.
5387         * thread.c (gdbtypes.h): Include.
5388         (thread_to_thread_handle): New function.
5389
5390         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5391         (target_thread_info_to_thread_handle): Declare.
5392         * target.c (target_thread_info_to_thread_handle): New function.
5393         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5394         * target-delegates.c: Regenerate.
5395
5396         * linux-thread-db.c (class thread_db_target): Add method
5397         thread_info_to_thread_handle.
5398         (thread_db_target::thread_info_to_thread_handle): Define.
5399         * remote.c (class remote_target): Add new method
5400         thread_info_to_thread_handle.
5401         (remote_target::thread_info_to_thread_handle): Define.
5402
5403 2019-04-08  Pedro Alves  <palves@redhat.com>
5404
5405         * common/common-exceptions.c (throw_exception): Don't create
5406         named object to throw; throw directly.
5407         (throw_it): Likewise.  Don't initialize gdb_exception::message
5408         here, with new; pass FMT and AP to the ctor instead.
5409         * common/common-exceptions.h: Include <string>.
5410         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5411         const char *, va_list)): New ctor.  Use std::make_shared.
5412         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5413         errors)): Delete.
5414         (gdb_exception_error::gdb_exception_error(enum errors, const char
5415         *, va_list)): New.
5416         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5417         Add assertion.
5418         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5419         errors)): Delete.
5420         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5421         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5422         Add assertion.
5423
5424 2019-04-08  Tom Tromey  <tom@tromey.com>
5425
5426         * valops.c (value_rtti_indirect_type): Replace throw_exception
5427         with throw.
5428         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5429         with throw.
5430         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5431         throw.
5432         * target.c (target_translate_tls_address): Replace throw_exception
5433         with throw.
5434         * stack.c (frame_apply_command_count): Replace throw_exception
5435         with throw.
5436         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5437         throw.
5438         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5439         with throw.
5440         * rs6000-tdep.c (rs6000_frame_cache)
5441         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5442         * remote.c: Replace throw_exception with throw.
5443         * record-full.c (record_full_message, record_full_wait_1)
5444         (record_full_restore): Replace throw_exception with throw.
5445         * record-btrace.c:
5446         (get_thread_current_frame_id, record_btrace_start_replaying)
5447         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5448         (cmd_record_btrace_start): Replace throw_exception with throw.
5449         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5450         throw.
5451         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5452         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5453         * linespec.c:
5454         (find_linespec_symbols): Replace throw_exception with throw.
5455         * infrun.c (displaced_step_prepare, resume): Replace
5456         throw_exception with throw.
5457         * infcmd.c (post_create_inferior): Replace throw_exception with
5458         throw.
5459         * inf-loop.c (inferior_event_handler): Replace throw_exception
5460         with throw.
5461         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5462         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5463         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5464         (get_prev_frame_always, get_frame_pc_if_available)
5465         (get_frame_address_in_block_if_available, get_frame_language):
5466         Replace throw_exception with throw.
5467         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5468         throw_exception with throw.
5469         * eval.c (fetch_subexp_value, evaluate_var_value)
5470         (evaluate_funcall, evaluate_subexp_standard): Replace
5471         throw_exception with throw.
5472         * dwarf2loc.c (call_site_find_chain)
5473         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5474         Replace throw_exception with throw.
5475         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5476         with throw.
5477         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5478         throw.
5479         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5480         * completer.c (complete_line_internal): Replace throw_exception
5481         with throw.
5482         * compile/compile-object-run.c (compile_object_run): Replace
5483         throw_exception with throw.
5484         * cli/cli-script.c (process_next_line): Replace throw_exception
5485         with throw.
5486         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5487         (btrace_enable, btrace_maint_update_pt_packets): Replace
5488         throw_exception with throw.
5489         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5490         throw_exception with throw.
5491         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5492         throw_exception with throw.
5493         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5494         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5495         * aarch64-tdep.c (aarch64_make_prologue_cache)
5496         (aarch64_make_stub_cache): Replace throw_exception with throw.
5497
5498 2019-04-08  Tom Tromey  <tom@tromey.com>
5499
5500         * common/common-exceptions.c (throw_exception): Rename from
5501         throw_exception_cxx.  Remove old copy.  Make argument const.
5502         (throw_it): Create and throw exception objects directly.
5503         * common/common-exceptions.h (throw_exception): Make argument
5504         const.
5505         (struct gdb_exception_error): Add constructor.
5506         (struct gdb_exception_quit): Add constructor.
5507
5508 2019-04-08  Tom Tromey  <tom@tromey.com>
5509
5510         * common/common-exceptions.h (exception_rethrow): Don't declare.
5511         (TRY_SJLJ): Update comment.
5512         (TRY, CATCH, END_CATCH): Remove.
5513         * common/common-exceptions.c (exception_rethrow): Remove.
5514
5515 2019-04-08  Tom Tromey  <tom@tromey.com>
5516
5517         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5518         Remove.
5519         (gdb_exception_error): Rename from
5520         gdb_exception_RETURN_MASK_ERROR.
5521         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5522         (gdb_quit_bad_alloc): Update.
5523         * aarch64-tdep.c: Update.
5524         * ada-lang.c: Update.
5525         * ada-typeprint.c: Update.
5526         * ada-valprint.c: Update.
5527         * amd64-tdep.c: Update.
5528         * arch-utils.c: Update.
5529         * break-catch-throw.c: Update.
5530         * breakpoint.c: Update.
5531         * btrace.c: Update.
5532         * c-varobj.c: Update.
5533         * cli/cli-cmds.c: Update.
5534         * cli/cli-interp.c: Update.
5535         * cli/cli-script.c: Update.
5536         * common/common-exceptions.c: Update.
5537         * common/new-op.c: Update.
5538         * common/selftest.c: Update.
5539         * compile/compile-c-symbols.c: Update.
5540         * compile/compile-cplus-symbols.c: Update.
5541         * compile/compile-object-load.c: Update.
5542         * compile/compile-object-run.c: Update.
5543         * completer.c: Update.
5544         * corelow.c: Update.
5545         * cp-abi.c: Update.
5546         * cp-support.c: Update.
5547         * cp-valprint.c: Update.
5548         * darwin-nat.c: Update.
5549         * disasm-selftests.c: Update.
5550         * dtrace-probe.c: Update.
5551         * dwarf-index-cache.c: Update.
5552         * dwarf-index-write.c: Update.
5553         * dwarf2-frame-tailcall.c: Update.
5554         * dwarf2-frame.c: Update.
5555         * dwarf2loc.c: Update.
5556         * dwarf2read.c: Update.
5557         * eval.c: Update.
5558         * event-loop.c: Update.
5559         * event-top.c: Update.
5560         * exec.c: Update.
5561         * f-valprint.c: Update.
5562         * fbsd-tdep.c: Update.
5563         * frame-unwind.c: Update.
5564         * frame.c: Update.
5565         * gdbtypes.c: Update.
5566         * gnu-v3-abi.c: Update.
5567         * guile/guile-internal.h: Update.
5568         * guile/scm-block.c: Update.
5569         * guile/scm-breakpoint.c: Update.
5570         * guile/scm-cmd.c: Update.
5571         * guile/scm-disasm.c: Update.
5572         * guile/scm-frame.c: Update.
5573         * guile/scm-lazy-string.c: Update.
5574         * guile/scm-math.c: Update.
5575         * guile/scm-param.c: Update.
5576         * guile/scm-ports.c: Update.
5577         * guile/scm-pretty-print.c: Update.
5578         * guile/scm-symbol.c: Update.
5579         * guile/scm-symtab.c: Update.
5580         * guile/scm-type.c: Update.
5581         * guile/scm-value.c: Update.
5582         * i386-linux-tdep.c: Update.
5583         * i386-tdep.c: Update.
5584         * inf-loop.c: Update.
5585         * infcall.c: Update.
5586         * infcmd.c: Update.
5587         * infrun.c: Update.
5588         * jit.c: Update.
5589         * language.c: Update.
5590         * linespec.c: Update.
5591         * linux-fork.c: Update.
5592         * linux-nat.c: Update.
5593         * linux-tdep.c: Update.
5594         * linux-thread-db.c: Update.
5595         * main.c: Update.
5596         * mi/mi-cmd-break.c: Update.
5597         * mi/mi-cmd-stack.c: Update.
5598         * mi/mi-interp.c: Update.
5599         * mi/mi-main.c: Update.
5600         * objc-lang.c: Update.
5601         * p-valprint.c: Update.
5602         * parse.c: Update.
5603         * ppc-linux-tdep.c: Update.
5604         * printcmd.c: Update.
5605         * python/py-arch.c: Update.
5606         * python/py-breakpoint.c: Update.
5607         * python/py-cmd.c: Update.
5608         * python/py-finishbreakpoint.c: Update.
5609         * python/py-frame.c: Update.
5610         * python/py-framefilter.c: Update.
5611         * python/py-gdb-readline.c: Update.
5612         * python/py-inferior.c: Update.
5613         * python/py-infthread.c: Update.
5614         * python/py-lazy-string.c: Update.
5615         * python/py-linetable.c: Update.
5616         * python/py-objfile.c: Update.
5617         * python/py-param.c: Update.
5618         * python/py-prettyprint.c: Update.
5619         * python/py-progspace.c: Update.
5620         * python/py-record-btrace.c: Update.
5621         * python/py-record.c: Update.
5622         * python/py-symbol.c: Update.
5623         * python/py-type.c: Update.
5624         * python/py-unwind.c: Update.
5625         * python/py-utils.c: Update.
5626         * python/py-value.c: Update.
5627         * python/python.c: Update.
5628         * record-btrace.c: Update.
5629         * record-full.c: Update.
5630         * remote-fileio.c: Update.
5631         * remote.c: Update.
5632         * riscv-tdep.c: Update.
5633         * rs6000-aix-tdep.c: Update.
5634         * rs6000-tdep.c: Update.
5635         * rust-exp.y: Update.
5636         * rust-lang.c: Update.
5637         * s390-tdep.c: Update.
5638         * selftest-arch.c: Update.
5639         * solib-dsbt.c: Update.
5640         * solib-frv.c: Update.
5641         * solib-spu.c: Update.
5642         * solib-svr4.c: Update.
5643         * solib.c: Update.
5644         * sparc64-linux-tdep.c: Update.
5645         * stack.c: Update.
5646         * symfile-mem.c: Update.
5647         * symmisc.c: Update.
5648         * target.c: Update.
5649         * thread.c: Update.
5650         * top.c: Update.
5651         * tracefile-tfile.c: Update.
5652         * tui/tui.c: Update.
5653         * typeprint.c: Update.
5654         * unittests/cli-utils-selftests.c: Update.
5655         * unittests/parse-connection-spec-selftests.c: Update.
5656         * valops.c: Update.
5657         * valprint.c: Update.
5658         * value.c: Update.
5659         * varobj.c: Update.
5660         * windows-nat.c: Update.
5661         * x86-linux-nat.c: Update.
5662         * xml-support.c: Update.
5663
5664 2019-04-08  Tom Tromey  <tom@tromey.com>
5665
5666         * xml-support.c: Use C++ exception handling.
5667         * x86-linux-nat.c: Use C++ exception handling.
5668         * windows-nat.c: Use C++ exception handling.
5669         * varobj.c: Use C++ exception handling.
5670         * value.c: Use C++ exception handling.
5671         * valprint.c: Use C++ exception handling.
5672         * valops.c: Use C++ exception handling.
5673         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5674         handling.
5675         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5676         * typeprint.c: Use C++ exception handling.
5677         * tui/tui.c: Use C++ exception handling.
5678         * tracefile-tfile.c: Use C++ exception handling.
5679         * top.c: Use C++ exception handling.
5680         * thread.c: Use C++ exception handling.
5681         * target.c: Use C++ exception handling.
5682         * symmisc.c: Use C++ exception handling.
5683         * symfile-mem.c: Use C++ exception handling.
5684         * stack.c: Use C++ exception handling.
5685         * sparc64-linux-tdep.c: Use C++ exception handling.
5686         * solib.c: Use C++ exception handling.
5687         * solib-svr4.c: Use C++ exception handling.
5688         * solib-spu.c: Use C++ exception handling.
5689         * solib-frv.c: Use C++ exception handling.
5690         * solib-dsbt.c: Use C++ exception handling.
5691         * selftest-arch.c: Use C++ exception handling.
5692         * s390-tdep.c: Use C++ exception handling.
5693         * rust-lang.c: Use C++ exception handling.
5694         * rust-exp.y: Use C++ exception handling.
5695         * rs6000-tdep.c: Use C++ exception handling.
5696         * rs6000-aix-tdep.c: Use C++ exception handling.
5697         * riscv-tdep.c: Use C++ exception handling.
5698         * remote.c: Use C++ exception handling.
5699         * remote-fileio.c: Use C++ exception handling.
5700         * record-full.c: Use C++ exception handling.
5701         * record-btrace.c: Use C++ exception handling.
5702         * python/python.c: Use C++ exception handling.
5703         * python/py-value.c: Use C++ exception handling.
5704         * python/py-utils.c: Use C++ exception handling.
5705         * python/py-unwind.c: Use C++ exception handling.
5706         * python/py-type.c: Use C++ exception handling.
5707         * python/py-symbol.c: Use C++ exception handling.
5708         * python/py-record.c: Use C++ exception handling.
5709         * python/py-record-btrace.c: Use C++ exception handling.
5710         * python/py-progspace.c: Use C++ exception handling.
5711         * python/py-prettyprint.c: Use C++ exception handling.
5712         * python/py-param.c: Use C++ exception handling.
5713         * python/py-objfile.c: Use C++ exception handling.
5714         * python/py-linetable.c: Use C++ exception handling.
5715         * python/py-lazy-string.c: Use C++ exception handling.
5716         * python/py-infthread.c: Use C++ exception handling.
5717         * python/py-inferior.c: Use C++ exception handling.
5718         * python/py-gdb-readline.c: Use C++ exception handling.
5719         * python/py-framefilter.c: Use C++ exception handling.
5720         * python/py-frame.c: Use C++ exception handling.
5721         * python/py-finishbreakpoint.c: Use C++ exception handling.
5722         * python/py-cmd.c: Use C++ exception handling.
5723         * python/py-breakpoint.c: Use C++ exception handling.
5724         * python/py-arch.c: Use C++ exception handling.
5725         * printcmd.c: Use C++ exception handling.
5726         * ppc-linux-tdep.c: Use C++ exception handling.
5727         * parse.c: Use C++ exception handling.
5728         * p-valprint.c: Use C++ exception handling.
5729         * objc-lang.c: Use C++ exception handling.
5730         * mi/mi-main.c: Use C++ exception handling.
5731         * mi/mi-interp.c: Use C++ exception handling.
5732         * mi/mi-cmd-stack.c: Use C++ exception handling.
5733         * mi/mi-cmd-break.c: Use C++ exception handling.
5734         * main.c: Use C++ exception handling.
5735         * linux-thread-db.c: Use C++ exception handling.
5736         * linux-tdep.c: Use C++ exception handling.
5737         * linux-nat.c: Use C++ exception handling.
5738         * linux-fork.c: Use C++ exception handling.
5739         * linespec.c: Use C++ exception handling.
5740         * language.c: Use C++ exception handling.
5741         * jit.c: Use C++ exception handling.
5742         * infrun.c: Use C++ exception handling.
5743         * infcmd.c: Use C++ exception handling.
5744         * infcall.c: Use C++ exception handling.
5745         * inf-loop.c: Use C++ exception handling.
5746         * i386-tdep.c: Use C++ exception handling.
5747         * i386-linux-tdep.c: Use C++ exception handling.
5748         * guile/scm-value.c: Use C++ exception handling.
5749         * guile/scm-type.c: Use C++ exception handling.
5750         * guile/scm-symtab.c: Use C++ exception handling.
5751         * guile/scm-symbol.c: Use C++ exception handling.
5752         * guile/scm-pretty-print.c: Use C++ exception handling.
5753         * guile/scm-ports.c: Use C++ exception handling.
5754         * guile/scm-param.c: Use C++ exception handling.
5755         * guile/scm-math.c: Use C++ exception handling.
5756         * guile/scm-lazy-string.c: Use C++ exception handling.
5757         * guile/scm-frame.c: Use C++ exception handling.
5758         * guile/scm-disasm.c: Use C++ exception handling.
5759         * guile/scm-cmd.c: Use C++ exception handling.
5760         * guile/scm-breakpoint.c: Use C++ exception handling.
5761         * guile/scm-block.c: Use C++ exception handling.
5762         * guile/guile-internal.h: Use C++ exception handling.
5763         * gnu-v3-abi.c: Use C++ exception handling.
5764         * gdbtypes.c: Use C++ exception handling.
5765         * frame.c: Use C++ exception handling.
5766         * frame-unwind.c: Use C++ exception handling.
5767         * fbsd-tdep.c: Use C++ exception handling.
5768         * f-valprint.c: Use C++ exception handling.
5769         * exec.c: Use C++ exception handling.
5770         * event-top.c: Use C++ exception handling.
5771         * event-loop.c: Use C++ exception handling.
5772         * eval.c: Use C++ exception handling.
5773         * dwarf2read.c: Use C++ exception handling.
5774         * dwarf2loc.c: Use C++ exception handling.
5775         * dwarf2-frame.c: Use C++ exception handling.
5776         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5777         * dwarf-index-write.c: Use C++ exception handling.
5778         * dwarf-index-cache.c: Use C++ exception handling.
5779         * dtrace-probe.c: Use C++ exception handling.
5780         * disasm-selftests.c: Use C++ exception handling.
5781         * darwin-nat.c: Use C++ exception handling.
5782         * cp-valprint.c: Use C++ exception handling.
5783         * cp-support.c: Use C++ exception handling.
5784         * cp-abi.c: Use C++ exception handling.
5785         * corelow.c: Use C++ exception handling.
5786         * completer.c: Use C++ exception handling.
5787         * compile/compile-object-run.c: Use C++ exception handling.
5788         * compile/compile-object-load.c: Use C++ exception handling.
5789         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5790         * compile/compile-c-symbols.c: Use C++ exception handling.
5791         * common/selftest.c: Use C++ exception handling.
5792         * common/new-op.c: Use C++ exception handling.
5793         * cli/cli-script.c: Use C++ exception handling.
5794         * cli/cli-interp.c: Use C++ exception handling.
5795         * cli/cli-cmds.c: Use C++ exception handling.
5796         * c-varobj.c: Use C++ exception handling.
5797         * btrace.c: Use C++ exception handling.
5798         * breakpoint.c: Use C++ exception handling.
5799         * break-catch-throw.c: Use C++ exception handling.
5800         * arch-utils.c: Use C++ exception handling.
5801         * amd64-tdep.c: Use C++ exception handling.
5802         * ada-valprint.c: Use C++ exception handling.
5803         * ada-typeprint.c: Use C++ exception handling.
5804         * ada-lang.c: Use C++ exception handling.
5805         * aarch64-tdep.c: Use C++ exception handling.
5806
5807 2019-04-08  Tom Tromey  <tom@tromey.com>
5808
5809         * xml-support.c (gdb_xml_parser::parse): Update.
5810         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5811         * value.c (show_convenience): Update.
5812         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5813         (test_parse_flags_qcs): Update.
5814         * thread.c (thr_try_catch_cmd): Update.
5815         * target.c (target_translate_tls_address): Update.
5816         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5817         (info_frame_command_core, frame_apply_command_count): Update.
5818         * rust-exp.y (rust_lex_exception_test): Update.
5819         * riscv-tdep.c (riscv_print_one_register_info): Update.
5820         * remote.c (remote_target::enable_btrace): Update.
5821         * record-btrace.c (record_btrace_enable_warn): Update.
5822         * python/py-utils.c (gdbpy_convert_exception): Update.
5823         * printcmd.c (do_one_display, print_variable_and_value): Update.
5824         * mi/mi-main.c (mi_print_exception): Update.
5825         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5826         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5827         * linux-nat.c (linux_nat_target::attach): Update.
5828         * linux-fork.c (class scoped_switch_fork_info): Update.
5829         * infrun.c (displaced_step_prepare): Update.
5830         * infcall.c (call_function_by_hand_dummy): Update.
5831         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5832         * gnu-v3-abi.c (print_one_vtable): Update.
5833         * frame.c (get_prev_frame_always): Update.
5834         * f-valprint.c (info_common_command_for_block): Update.
5835         * exec.c (try_open_exec_file): Update.
5836         * exceptions.c (print_exception, exception_print)
5837         (exception_fprintf, exception_print_same): Update.
5838         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5839         * dwarf-index-cache.c (index_cache::store)
5840         (index_cache::lookup_gdb_index): Update.
5841         * darwin-nat.c (maybe_cache_shell): Update.
5842         * cp-valprint.c (cp_print_value_fields): Update.
5843         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5844         (gcc_cplus_symbol_address): Update.
5845         * compile/compile-c-symbols.c (gcc_convert_symbol)
5846         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5847         * common/selftest.c: Update.
5848         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5849         a std::string.
5850         (exception_try_scope_entry, exception_try_scope_exit): Don't
5851         declare.
5852         (struct exception_try_scope): Remove.
5853         (TRY): Don't use exception_try_scope.
5854         (struct gdb_exception): Add constructor, operator=.
5855         <what>: New method.
5856         (struct gdb_exception_RETURN_MASK_ALL)
5857         (struct gdb_exception_RETURN_MASK_ERROR)
5858         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5859         (struct gdb_quit_bad_alloc): Update.
5860         * common/common-exceptions.c (exception_none): Change
5861         initializer.
5862         (struct catcher) <state, exception>: Initialize inline.
5863         <prev>: Remove member.
5864         (current_catcher): Remove.
5865         (catchers): New global.
5866         (exceptions_state_mc_init): Simplify.
5867         (catcher_pop): Remove.
5868         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5869         (try_scope_depth, exception_try_scope_entry)
5870         (exception_try_scope_exit): Remove.
5871         (throw_exception_sjlj): Update.
5872         (exception_messages, exception_messages_size): Remove.
5873         (throw_it): Simplify.
5874         (gdb_exception_sliced_copy): Remove.
5875         (throw_exception_cxx): Update.
5876         * cli/cli-script.c (script_from_file): Update.
5877         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5878         Update.
5879         * ada-valprint.c (ada_val_print): Update.
5880         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5881         (create_excep_cond_exprs): Update.
5882
5883 2019-04-08  Tom Tromey  <tom@tromey.com>
5884
5885         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5886         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5887         (TRY, CATCH, END_CATCH): Remove some definitions.
5888         * common/common-exceptions.c: Don't use GDB_XCPT.
5889         (catcher_list_size): Remove.
5890         (throw_exception, throw_it): Simplify.
5891
5892 2019-04-05  Tom Tromey  <tom@tromey.com>
5893
5894         Revert the header-sorting patch.
5895         * ft32-tdep.c: Revert.
5896         * frv-tdep.c: Revert.
5897         * frv-linux-tdep.c: Revert.
5898         * frame.c: Revert.
5899         * frame-unwind.c: Revert.
5900         * frame-base.c: Revert.
5901         * fork-child.c: Revert.
5902         * findvar.c: Revert.
5903         * findcmd.c: Revert.
5904         * filesystem.c: Revert.
5905         * filename-seen-cache.h: Revert.
5906         * filename-seen-cache.c: Revert.
5907         * fbsd-tdep.c: Revert.
5908         * fbsd-nat.h: Revert.
5909         * fbsd-nat.c: Revert.
5910         * f-valprint.c: Revert.
5911         * f-typeprint.c: Revert.
5912         * f-lang.c: Revert.
5913         * extension.h: Revert.
5914         * extension.c: Revert.
5915         * extension-priv.h: Revert.
5916         * expprint.c: Revert.
5917         * exec.h: Revert.
5918         * exec.c: Revert.
5919         * exceptions.c: Revert.
5920         * event-top.c: Revert.
5921         * event-loop.c: Revert.
5922         * eval.c: Revert.
5923         * elfread.c: Revert.
5924         * dwarf2read.h: Revert.
5925         * dwarf2read.c: Revert.
5926         * dwarf2loc.c: Revert.
5927         * dwarf2expr.h: Revert.
5928         * dwarf2expr.c: Revert.
5929         * dwarf2-frame.c: Revert.
5930         * dwarf2-frame-tailcall.c: Revert.
5931         * dwarf-index-write.h: Revert.
5932         * dwarf-index-write.c: Revert.
5933         * dwarf-index-common.c: Revert.
5934         * dwarf-index-cache.h: Revert.
5935         * dwarf-index-cache.c: Revert.
5936         * dummy-frame.c: Revert.
5937         * dtrace-probe.c: Revert.
5938         * disasm.h: Revert.
5939         * disasm.c: Revert.
5940         * disasm-selftests.c: Revert.
5941         * dictionary.c: Revert.
5942         * dicos-tdep.c: Revert.
5943         * demangle.c: Revert.
5944         * dcache.h: Revert.
5945         * dcache.c: Revert.
5946         * darwin-nat.h: Revert.
5947         * darwin-nat.c: Revert.
5948         * darwin-nat-info.c: Revert.
5949         * d-valprint.c: Revert.
5950         * d-namespace.c: Revert.
5951         * d-lang.c: Revert.
5952         * ctf.c: Revert.
5953         * csky-tdep.c: Revert.
5954         * csky-linux-tdep.c: Revert.
5955         * cris-tdep.c: Revert.
5956         * cris-linux-tdep.c: Revert.
5957         * cp-valprint.c: Revert.
5958         * cp-support.c: Revert.
5959         * cp-namespace.c: Revert.
5960         * cp-abi.c: Revert.
5961         * corelow.c: Revert.
5962         * corefile.c: Revert.
5963         * continuations.c: Revert.
5964         * completer.h: Revert.
5965         * completer.c: Revert.
5966         * complaints.c: Revert.
5967         * coffread.c: Revert.
5968         * coff-pe-read.c: Revert.
5969         * cli-out.h: Revert.
5970         * cli-out.c: Revert.
5971         * charset.c: Revert.
5972         * c-varobj.c: Revert.
5973         * c-valprint.c: Revert.
5974         * c-typeprint.c: Revert.
5975         * c-lang.c: Revert.
5976         * buildsym.c: Revert.
5977         * buildsym-legacy.c: Revert.
5978         * build-id.h: Revert.
5979         * build-id.c: Revert.
5980         * btrace.c: Revert.
5981         * bsd-uthread.c: Revert.
5982         * breakpoint.h: Revert.
5983         * breakpoint.c: Revert.
5984         * break-catch-throw.c: Revert.
5985         * break-catch-syscall.c: Revert.
5986         * break-catch-sig.c: Revert.
5987         * blockframe.c: Revert.
5988         * block.c: Revert.
5989         * bfin-tdep.c: Revert.
5990         * bfin-linux-tdep.c: Revert.
5991         * bfd-target.c: Revert.
5992         * bcache.c: Revert.
5993         * ax-general.c: Revert.
5994         * ax-gdb.h: Revert.
5995         * ax-gdb.c: Revert.
5996         * avr-tdep.c: Revert.
5997         * auxv.c: Revert.
5998         * auto-load.c: Revert.
5999         * arm-wince-tdep.c: Revert.
6000         * arm-tdep.c: Revert.
6001         * arm-symbian-tdep.c: Revert.
6002         * arm-pikeos-tdep.c: Revert.
6003         * arm-obsd-tdep.c: Revert.
6004         * arm-nbsd-tdep.c: Revert.
6005         * arm-nbsd-nat.c: Revert.
6006         * arm-linux-tdep.c: Revert.
6007         * arm-linux-nat.c: Revert.
6008         * arm-fbsd-tdep.c: Revert.
6009         * arm-fbsd-nat.c: Revert.
6010         * arm-bsd-tdep.c: Revert.
6011         * arch-utils.c: Revert.
6012         * arc-tdep.c: Revert.
6013         * arc-newlib-tdep.c: Revert.
6014         * annotate.h: Revert.
6015         * annotate.c: Revert.
6016         * amd64-windows-tdep.c: Revert.
6017         * amd64-windows-nat.c: Revert.
6018         * amd64-tdep.c: Revert.
6019         * amd64-sol2-tdep.c: Revert.
6020         * amd64-obsd-tdep.c: Revert.
6021         * amd64-obsd-nat.c: Revert.
6022         * amd64-nbsd-tdep.c: Revert.
6023         * amd64-nbsd-nat.c: Revert.
6024         * amd64-nat.c: Revert.
6025         * amd64-linux-tdep.c: Revert.
6026         * amd64-linux-nat.c: Revert.
6027         * amd64-fbsd-tdep.c: Revert.
6028         * amd64-fbsd-nat.c: Revert.
6029         * amd64-dicos-tdep.c: Revert.
6030         * amd64-darwin-tdep.c: Revert.
6031         * amd64-bsd-nat.c: Revert.
6032         * alpha-tdep.c: Revert.
6033         * alpha-obsd-tdep.c: Revert.
6034         * alpha-nbsd-tdep.c: Revert.
6035         * alpha-mdebug-tdep.c: Revert.
6036         * alpha-linux-tdep.c: Revert.
6037         * alpha-linux-nat.c: Revert.
6038         * alpha-bsd-tdep.c: Revert.
6039         * alpha-bsd-nat.c: Revert.
6040         * aix-thread.c: Revert.
6041         * agent.c: Revert.
6042         * addrmap.c: Revert.
6043         * ada-varobj.c: Revert.
6044         * ada-valprint.c: Revert.
6045         * ada-typeprint.c: Revert.
6046         * ada-tasks.c: Revert.
6047         * ada-lang.c: Revert.
6048         * aarch64-tdep.c: Revert.
6049         * aarch64-ravenscar-thread.c: Revert.
6050         * aarch64-newlib-tdep.c: Revert.
6051         * aarch64-linux-tdep.c: Revert.
6052         * aarch64-linux-nat.c: Revert.
6053         * aarch64-fbsd-tdep.c: Revert.
6054         * aarch64-fbsd-nat.c: Revert.
6055         * aarch32-linux-nat.c: Revert.
6056
6057 2019-04-05  Tom Tromey  <tom@tromey.com>
6058
6059         * ft32-tdep.c: Sort headers.
6060         * frv-tdep.c: Sort headers.
6061         * frv-linux-tdep.c: Sort headers.
6062         * frame.c: Sort headers.
6063         * frame-unwind.c: Sort headers.
6064         * frame-base.c: Sort headers.
6065         * fork-child.c: Sort headers.
6066         * findvar.c: Sort headers.
6067         * findcmd.c: Sort headers.
6068         * filesystem.c: Sort headers.
6069         * filename-seen-cache.h: Sort headers.
6070         * filename-seen-cache.c: Sort headers.
6071         * fbsd-tdep.c: Sort headers.
6072         * fbsd-nat.h: Sort headers.
6073         * fbsd-nat.c: Sort headers.
6074         * f-valprint.c: Sort headers.
6075         * f-typeprint.c: Sort headers.
6076         * f-lang.c: Sort headers.
6077         * extension.h: Sort headers.
6078         * extension.c: Sort headers.
6079         * extension-priv.h: Sort headers.
6080         * expprint.c: Sort headers.
6081         * exec.h: Sort headers.
6082         * exec.c: Sort headers.
6083         * exceptions.c: Sort headers.
6084         * event-top.c: Sort headers.
6085         * event-loop.c: Sort headers.
6086         * eval.c: Sort headers.
6087         * elfread.c: Sort headers.
6088         * dwarf2read.h: Sort headers.
6089         * dwarf2read.c: Sort headers.
6090         * dwarf2loc.c: Sort headers.
6091         * dwarf2expr.h: Sort headers.
6092         * dwarf2expr.c: Sort headers.
6093         * dwarf2-frame.c: Sort headers.
6094         * dwarf2-frame-tailcall.c: Sort headers.
6095         * dwarf-index-write.h: Sort headers.
6096         * dwarf-index-write.c: Sort headers.
6097         * dwarf-index-common.c: Sort headers.
6098         * dwarf-index-cache.h: Sort headers.
6099         * dwarf-index-cache.c: Sort headers.
6100         * dummy-frame.c: Sort headers.
6101         * dtrace-probe.c: Sort headers.
6102         * disasm.h: Sort headers.
6103         * disasm.c: Sort headers.
6104         * disasm-selftests.c: Sort headers.
6105         * dictionary.c: Sort headers.
6106         * dicos-tdep.c: Sort headers.
6107         * demangle.c: Sort headers.
6108         * dcache.h: Sort headers.
6109         * dcache.c: Sort headers.
6110         * darwin-nat.h: Sort headers.
6111         * darwin-nat.c: Sort headers.
6112         * darwin-nat-info.c: Sort headers.
6113         * d-valprint.c: Sort headers.
6114         * d-namespace.c: Sort headers.
6115         * d-lang.c: Sort headers.
6116         * ctf.c: Sort headers.
6117         * csky-tdep.c: Sort headers.
6118         * csky-linux-tdep.c: Sort headers.
6119         * cris-tdep.c: Sort headers.
6120         * cris-linux-tdep.c: Sort headers.
6121         * cp-valprint.c: Sort headers.
6122         * cp-support.c: Sort headers.
6123         * cp-namespace.c: Sort headers.
6124         * cp-abi.c: Sort headers.
6125         * corelow.c: Sort headers.
6126         * corefile.c: Sort headers.
6127         * continuations.c: Sort headers.
6128         * completer.h: Sort headers.
6129         * completer.c: Sort headers.
6130         * complaints.c: Sort headers.
6131         * coffread.c: Sort headers.
6132         * coff-pe-read.c: Sort headers.
6133         * cli-out.h: Sort headers.
6134         * cli-out.c: Sort headers.
6135         * charset.c: Sort headers.
6136         * c-varobj.c: Sort headers.
6137         * c-valprint.c: Sort headers.
6138         * c-typeprint.c: Sort headers.
6139         * c-lang.c: Sort headers.
6140         * buildsym.c: Sort headers.
6141         * buildsym-legacy.c: Sort headers.
6142         * build-id.h: Sort headers.
6143         * build-id.c: Sort headers.
6144         * btrace.c: Sort headers.
6145         * bsd-uthread.c: Sort headers.
6146         * breakpoint.h: Sort headers.
6147         * breakpoint.c: Sort headers.
6148         * break-catch-throw.c: Sort headers.
6149         * break-catch-syscall.c: Sort headers.
6150         * break-catch-sig.c: Sort headers.
6151         * blockframe.c: Sort headers.
6152         * block.c: Sort headers.
6153         * bfin-tdep.c: Sort headers.
6154         * bfin-linux-tdep.c: Sort headers.
6155         * bfd-target.c: Sort headers.
6156         * bcache.c: Sort headers.
6157         * ax-general.c: Sort headers.
6158         * ax-gdb.h: Sort headers.
6159         * ax-gdb.c: Sort headers.
6160         * avr-tdep.c: Sort headers.
6161         * auxv.c: Sort headers.
6162         * auto-load.c: Sort headers.
6163         * arm-wince-tdep.c: Sort headers.
6164         * arm-tdep.c: Sort headers.
6165         * arm-symbian-tdep.c: Sort headers.
6166         * arm-pikeos-tdep.c: Sort headers.
6167         * arm-obsd-tdep.c: Sort headers.
6168         * arm-nbsd-tdep.c: Sort headers.
6169         * arm-nbsd-nat.c: Sort headers.
6170         * arm-linux-tdep.c: Sort headers.
6171         * arm-linux-nat.c: Sort headers.
6172         * arm-fbsd-tdep.c: Sort headers.
6173         * arm-fbsd-nat.c: Sort headers.
6174         * arm-bsd-tdep.c: Sort headers.
6175         * arch-utils.c: Sort headers.
6176         * arc-tdep.c: Sort headers.
6177         * arc-newlib-tdep.c: Sort headers.
6178         * annotate.h: Sort headers.
6179         * annotate.c: Sort headers.
6180         * amd64-windows-tdep.c: Sort headers.
6181         * amd64-windows-nat.c: Sort headers.
6182         * amd64-tdep.c: Sort headers.
6183         * amd64-sol2-tdep.c: Sort headers.
6184         * amd64-obsd-tdep.c: Sort headers.
6185         * amd64-obsd-nat.c: Sort headers.
6186         * amd64-nbsd-tdep.c: Sort headers.
6187         * amd64-nbsd-nat.c: Sort headers.
6188         * amd64-nat.c: Sort headers.
6189         * amd64-linux-tdep.c: Sort headers.
6190         * amd64-linux-nat.c: Sort headers.
6191         * amd64-fbsd-tdep.c: Sort headers.
6192         * amd64-fbsd-nat.c: Sort headers.
6193         * amd64-dicos-tdep.c: Sort headers.
6194         * amd64-darwin-tdep.c: Sort headers.
6195         * amd64-bsd-nat.c: Sort headers.
6196         * alpha-tdep.c: Sort headers.
6197         * alpha-obsd-tdep.c: Sort headers.
6198         * alpha-nbsd-tdep.c: Sort headers.
6199         * alpha-mdebug-tdep.c: Sort headers.
6200         * alpha-linux-tdep.c: Sort headers.
6201         * alpha-linux-nat.c: Sort headers.
6202         * alpha-bsd-tdep.c: Sort headers.
6203         * alpha-bsd-nat.c: Sort headers.
6204         * aix-thread.c: Sort headers.
6205         * agent.c: Sort headers.
6206         * addrmap.c: Sort headers.
6207         * ada-varobj.c: Sort headers.
6208         * ada-valprint.c: Sort headers.
6209         * ada-typeprint.c: Sort headers.
6210         * ada-tasks.c: Sort headers.
6211         * ada-lang.c: Sort headers.
6212         * aarch64-tdep.c: Sort headers.
6213         * aarch64-ravenscar-thread.c: Sort headers.
6214         * aarch64-newlib-tdep.c: Sort headers.
6215         * aarch64-linux-tdep.c: Sort headers.
6216         * aarch64-linux-nat.c: Sort headers.
6217         * aarch64-fbsd-tdep.c: Sort headers.
6218         * aarch64-fbsd-nat.c: Sort headers.
6219         * aarch32-linux-nat.c: Sort headers.
6220
6221 2019-04-04  Tom Tromey  <tom@tromey.com>
6222
6223         * varobj.c (varobj_create): Update.
6224         * rust-exp.y (struct rust_parser) <update_innermost_block,
6225         lookup_symbol>: New methods.
6226         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6227         Rename.
6228         (rust_parser::rust_lookup_type)
6229         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6230         * printcmd.c (display_command, do_one_display): Update.
6231         * parser-defs.h (struct parser_state) <parser_state>: Add
6232         "tracker" parameter.
6233         (block_tracker): New member.
6234         (class innermost_block_tracker) <innermost_block_tracker>: Add
6235         "types" parameter.
6236         <reset>: Remove method.
6237         (innermost_block): Don't declare.
6238         (null_post_parser): Update.
6239         * parse.c (innermost_block): Remove global.
6240         (write_dollar_variable): Update.
6241         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6242         Remove "tracker_types" parameter.
6243         (parse_expression): Add "tracker" parameter.
6244         (parse_expression_for_completion): Update.
6245         (null_post_parser): Add "tracker" parameter.
6246         * p-exp.y: Update rules.
6247         * m2-exp.y: Update rules.
6248         * language.h (struct language_defn) <la_post_parser>: Add
6249         "tracker" parameter.
6250         * go-exp.y: Update rules.
6251         * f-exp.y: Update rules.
6252         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6253         parameter.
6254         * d-exp.y: Update rules.
6255         * c-exp.y: Update rules.
6256         * breakpoint.c (set_breakpoint_condition): Create an
6257         innermost_block_tracker.
6258         (watch_command_1): Likewise.
6259         * ada-lang.c (resolve): Add "tracker" parameter.
6260         (resolve_subexp): Likewise.
6261         * ada-exp.y (write_var_from_sym): Update.
6262
6263 2019-04-04  Tom Tromey  <tom@tromey.com>
6264
6265         * type-stack.h: New file.
6266         * type-stack.c: New file.
6267         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6268         type-stack.h.
6269         (insert_into_type_stack, insert_type, push_type, push_type_int)
6270         (insert_type_address_space, pop_type, pop_type_int)
6271         (pop_typelist, pop_type_stack, append_type_stack)
6272         (push_type_stack, get_type_stack, push_typelist)
6273         (follow_type_instance_flags, follow_types): Don't declare.
6274         * parse.c (type_stack): Remove global.
6275         (parse_exp_in_context): Update.
6276         (insert_into_type_stack, insert_type, push_type, push_type_int)
6277         (insert_type_address_space, pop_type, pop_type_int)
6278         (pop_typelist, pop_type_stack, append_type_stack)
6279         (push_type_stack, get_type_stack, push_typelist)
6280         (follow_type_instance_flags, follow_types): Remove (moved to
6281         type-stack.c).
6282         * f-exp.y (type_stack): New global.
6283         Update rules.
6284         (push_kind_type, f_parse): Update.
6285         * d-exp.y (type_stack): New global.
6286         Update rules.
6287         (d_parse): Update.
6288         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6289         Update rules.
6290         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6291         (HFILES_NO_SRCDIR): Add type-stack.h.
6292
6293 2019-04-04  Tom Tromey  <tom@tromey.com>
6294
6295         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6296         (rust_parser::convert_ast_to_expression, rust_parse)
6297         (rust_lex_test_completion, rust_lex_tests): Update.
6298         * parser-defs.h (struct expr_completion_state): New.
6299         (struct parser_state) <parser_state>: Add completion parameter.
6300         <mark_struct_expression, mark_completion_tag>: New methods.
6301         <parse_completion, m_completion_state>: New members.
6302         (prefixify_expression, null_post_parser): Update.
6303         (mark_struct_expression, mark_completion_tag): Don't declare.
6304         * parse.c (parse_completion, expout_last_struct)
6305         (expout_tag_completion_type, expout_completion_name): Remove
6306         globals.
6307         (parser_state::mark_struct_expression)
6308         (parser_state::mark_completion_tag): Now methods.
6309         (prefixify_expression): Add last_struct parameter.
6310         (prefixify_subexp): Likewise.
6311         (parse_exp_1): Update.
6312         (parse_exp_in_context): Add cstate parameter.  Update.
6313         (parse_expression_for_completion): Create an
6314         expr_completion_state.
6315         (null_post_parser): Add "completion" parameter.
6316         * p-exp.y: Update rules.
6317         (yylex): Update.
6318         * language.h (struct language_defn) <la_post_parser>: Add
6319         "completing" parameter.
6320         * go-exp.y: Update rules.
6321         (lex_one_token): Update.
6322         * expression.h (parse_completion): Don't declare.
6323         * d-exp.y: Update rules.
6324         (lex_one_token): Update rules.
6325         * c-exp.y: Update rules.
6326         (lex_one_token): Update.
6327         * ada-lang.c (resolve): Add "parse_completion" parameter.
6328         (resolve_subexp): Likewise.
6329         (ada_resolve_function): Likewise.
6330
6331 2019-04-04  Tom Tromey  <tom@tromey.com>
6332
6333         * parser-defs.h (struct parser_state) <start_arglist,
6334         end_arglist>: New methods.
6335         <arglist_len, m_funcall_chain>: New members.
6336         (arglist_len, start_arglist, end_arglist): Don't declare.
6337         * parse.c (arglist_len, funcall_chain): Remove global.
6338         (start_arglist, end_arglist): Remove functions.
6339         (parse_exp_in_context): Update.
6340         * p-exp.y: Update rules.
6341         * m2-exp.y: Update rules.
6342         * go-exp.y: Update rules.
6343         * f-exp.y: Update rules.
6344         * d-exp.y: Update rules.
6345         * c-exp.y: Update rules.
6346
6347 2019-04-04  Tom Tromey  <tom@tromey.com>
6348
6349         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6350         lex_operator, push_back>: New methods.
6351         Update all rules.
6352         (rust_parser::lex_hex, lex_escape): Rename and update.
6353         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6354         (rust_parser::lex_operator): Rename and update.
6355         (rust_parser::lex_number, rustyylex, rustyyerror)
6356         (rust_lex_test_init, rust_lex_test_sequence)
6357         (rust_lex_test_push_back, rust_lex_tests): Update.
6358         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6359         parameter.
6360         <lexptr, prev_lexptr>: New members.
6361         (lexptr, prev_lexptr): Don't declare.
6362         * parse.c (lexptr, prev_lexptr): Remove globals.
6363         (parse_exp_in_context): Update.
6364         * p-exp.y (yylex, yyerror): Update.
6365         * m2-exp.y (parse_number, yylex, yyerror): Update.
6366         * go-exp.y (lex_one_token, yyerror): Update.
6367         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6368         * d-exp.y (lex_one_token, yyerror): Update.
6369         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6370         (lex_one_token, yyerror): Update.
6371         * ada-lex.l (YY_INPUT): Update.
6372         (rewind_to_char): Update.
6373         * ada-exp.y (yyerror): Update.
6374
6375 2019-04-04  Tom Tromey  <tom@tromey.com>
6376
6377         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6378         * parser-defs.h (struct parser_state) <parser_state>: Add new
6379         parameter.
6380         <comma_terminates>: New member.
6381         (comma_terminates): Don't declare global.
6382         * parse.c (comma_terminates): Remove global.
6383         (parse_exp_in_context): Update.
6384         * p-exp.y (yylex): Update.
6385         * m2-exp.y (yylex): Update.
6386         * go-exp.y (lex_one_token): Update.
6387         * f-exp.y (yylex): Update.
6388         * d-exp.y (lex_one_token): Update.
6389         * c-exp.y (lex_one_token): Update.
6390         * ada-lex.l: Update.
6391
6392 2019-04-04  Tom Tromey  <tom@tromey.com>
6393
6394         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6395         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6396         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6397         * parser-defs.h (paren_depth): Don't declare.
6398         * parse.c (paren_depth): Remove global.
6399         (parse_exp_in_context): Update.
6400         * p-exp.y (paren_depth): New global.
6401         (pascal_parse): Initialize it.
6402         * m2-exp.y (paren_depth): New global.
6403         (m2_parse): Initialize it.
6404         * go-exp.y (paren_depth): New global.
6405         (go_parse): Initialize it.
6406         * f-exp.y (paren_depth): New global.
6407         (f_parse): Initialize it.
6408         * d-exp.y (paren_depth): New global.
6409         (d_parse): Initialize it.
6410         * c-exp.y (paren_depth): New global.
6411         (c_parse): Initialize it.
6412         * ada-lex.l (paren_depth): New global.
6413         (lexer_init): Initialize it.
6414
6415 2019-04-04  Tom Tromey  <tom@tromey.com>
6416
6417         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6418         (rust_parser::convert_ast_to_type)
6419         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6420         * parser-defs.h (struct parser_state) <parser_state>: Add
6421         parameters.  Initialize new members.
6422         <expression_context_block, expression_context_pc>: New members.
6423         * parse.c (expression_context_block, expression_context_pc):
6424         Remove globals.
6425         (parse_exp_in_context): Update.
6426         * p-exp.y: Update all rules.
6427         (yylex): Update.
6428         * m2-exp.y: Update all rules.
6429         (yylex): Update.
6430         * go-exp.y (yylex): Update.
6431         * f-exp.y (yylex): Update.
6432         * d-exp.y: Update all rules.
6433         (yylex): Update.
6434         * c-exp.y: Update all rules.
6435         (lex_one_token, classify_name, yylex, c_parse): Update.
6436         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6437
6438 2019-04-04  Tom Tromey  <tom@tromey.com>
6439
6440         * gdbarch.h, gdbarch.c: Rebuild.
6441         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6442         * stap-probe.h:
6443         (struct stap_parse_info): Replace "parser_state" with
6444         "expr_builder".
6445         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6446         (parser_state): New class.
6447         * parse.c (expr_builder): Rename.
6448         (expr_builder::release): Rename.
6449         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6450         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6451         (write_exp_elt_longcst, write_exp_elt_floatcst)
6452         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6453         (write_exp_string_vector, write_exp_bitstring)
6454         (write_exp_msymbol, mark_struct_expression)
6455         (write_dollar_variable)
6456         (insert_type_address_space, increase_expout_size): Replace
6457         "parser_state" with "expr_builder".
6458         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6459         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6460         "parser_state" with "expr_builder".
6461
6462 2019-04-04  Tom Tromey  <tom@tromey.com>
6463
6464         * rust-exp.y: Replace "parse_language" with method call.
6465         * p-exp.y:
6466         (yylex): Replace "parse_language" with method call.
6467         * m2-exp.y:
6468         (yylex): Replace "parse_language" with method call.
6469         * go-exp.y (classify_name): Replace "parse_language" with method
6470         call.
6471         * f-exp.y (yylex): Replace "parse_language" with method call.
6472         * d-exp.y (lex_one_token): Replace "parse_language" with method
6473         call.
6474         * c-exp.y:
6475         (lex_one_token, classify_name, yylex): Replace "parse_language"
6476         with method call.
6477         * ada-exp.y (find_primitive_type, type_char)
6478         (type_system_address): Replace "parse_language" with method call.
6479
6480 2019-04-04  Tom Tromey  <tom@tromey.com>
6481
6482         * rust-exp.y: Replace "parse_gdbarch" with method call.
6483         * parse.c (write_dollar_variable, insert_type_address_space):
6484         Replace "parse_gdbarch" with method call.
6485         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6486         call.
6487         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6488         call.
6489         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6490         "parse_gdbarch" with method call.
6491         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6492         with method call.
6493         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6494         "parse_gdbarch" with method call.
6495         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6496         "parse_gdbarch" with method call.
6497         * c-exp.y (parse_type, parse_number, classify_name): Replace
6498         "parse_gdbarch" with method call.
6499         * ada-lex.l: Replace "parse_gdbarch" with method call.
6500         * ada-exp.y (parse_type, find_primitive_type, type_char)
6501         (type_system_address): Replace "parse_gdbarch" with method call.
6502
6503 2019-04-04  Tom Tromey  <tom@tromey.com>
6504
6505         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6506         * stap-probe.c (stap_parse_argument): Update.
6507         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6508         initial_size parameter.
6509         * rust-exp.y (rust_lex_tests): Update.
6510         * parse.c (parser_state): Update.
6511         (parse_exp_in_context): Update.
6512         * parser-defs.h (struct parser_state) <parser_state>: Remove
6513         "initial_size" parameter.
6514
6515 2019-04-04  Tom Tromey  <tom@tromey.com>
6516
6517         * parser-defs.h (increase_expout_size): Don't declare.
6518         * parse.c (increase_expout_size): Now static.
6519
6520 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6521
6522         * gnu-nat.c (gnu_nat_target::wait): Fix
6523         target_waitstatus_to_string call.
6524
6525 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6526
6527         * eval.c (evaluate_subexp_standard): Handle internal functions
6528         during Fortran function call handling.
6529
6530 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6531
6532         * NEWS: Mention new internal functions.
6533         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6534         (read_base_type): Use dwarf2_init_complex_target_type.
6535         * value.c (creal_internal_fn): New function.
6536         (cimag_internal_fn): New function.
6537         (_initialize_values): Register new internal functions.
6538
6539 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6540
6541         * infrun.c (stop_all_threads): If debug_infrun, always
6542         trace the wait status after wait_one, using
6543         target_waitstatus_to_string and target_pid_to_str.
6544         (handle_inferior_event): Replace various trace of
6545         wait status kind by a single trace.
6546         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6547         wait status kind image by target_waitstatus_to_string.
6548         * target/waitstatus.c (target_waitstatus_to_string): Fix
6549         obsolete comment.
6550
6551 2019-04-01  Tom Tromey  <tromey@adacore.com>
6552
6553         PR symtab/23331:
6554         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6555
6556 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6557             Pedro Alves  <palves@redhat.com>
6558
6559         * top.c (quit_force): Call 'finalize_values'.
6560         * value.c (finalize_values): New function.
6561         * value.h (finalize_values): Declare.
6562
6563 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6564
6565         * NEWS: Announce $_gdb_major and $_gdb_minor.
6566
6567         * top.c (init_gdb_version_vars): New function.
6568         (gdb_init): Call init_gdb_version_vars.
6569
6570 2019-03-29  Tom Tromey  <tromey@adacore.com>
6571
6572         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6573         help text.  Remove dead code.
6574
6575 2019-03-29  Keith Seitz  <keiths@redhat.com>
6576
6577         From Siddhesh Poyarekar:
6578         * f-lang.h (f77_get_upperbound): Return LONGEST.
6579         (f77_get_lowerbound): Likewise.
6580         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6581         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6582         print them.
6583         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6584         plongest to format print it.
6585         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6586         (f77_get_upperbound): Likewise.
6587         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6588         LOWER_BOUND to LONGEST.
6589         (f77_create_arrayprint_offset_tbl): Likewise.
6590
6591 2019-03-29  Keith Seitz  <keiths@redhat.com>
6592
6593         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6594         %s/pulongest for TYPE_LENGTH instead of %d in format
6595         strings.
6596         * ada-typerint.c (ada_print_type): Likewise.
6597         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6598         * compile/compile-c-support.c (generate_register_struct): Likewise.
6599         * gdbtypes.c (recursive_dump_type): Likewise.
6600         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6601         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6602         instead of %d in format strings.
6603         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6604         to std::min to ULONGEST.
6605         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6606         instead of %d in format strings.
6607         * tracepoint.c (info_scope_command): Likewise.
6608         * typeprint.c (print_offset_data::update)
6609         (print_offset_data::finish): Likewise.
6610         * xtensa-tdep.c (xtensa_store_return_value)
6611         (xtensa_push_dummy_call): Likewise.
6612
6613 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6614
6615         * windows-nat.c (display_selector): Fixed format specifications
6616         for 64-bit Cygwin.
6617
6618 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6619
6620         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6621
6622 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6623
6624         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6625         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6626         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6627         (nios2_linux_init_abi): Install it.
6628
6629 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6630
6631         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6632
6633 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6634
6635         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6636
6637 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6638             Tom Tromey  <tromey@adacore.com>
6639
6640         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6641
6642 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6643
6644         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6645         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6646         method to compute the bounds of range types. Also print "[evaluated]"
6647         if the bounds' values come from a dynamic evaluation.
6648
6649 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6650
6651         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6652         whitespace when pretty printing is on.
6653
6654 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6655
6656         * ppc-linux-nat.c: Add include.
6657
6658 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6659
6660         * NEWS: Mention AArch64 Pointer Authentication.
6661
6662 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6663
6664         * arm-linux-nat.c: Add include.
6665
6666 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6667
6668         * source-cache.c (source_cache::get_source_lines): Re-read
6669         fullname after calling open_source_file.
6670
6671 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6672
6673         * NEWS: Mention TLS support for FreeBSD.
6674
6675 2019-03-25  Tom Tromey  <tromey@adacore.com>
6676
6677         * minsyms.c (BUNCH_SIZE): Update comment.
6678         (~minimal_symbol_reader): Remove old comment.
6679         (compact_minimal_symbols): Update comment.
6680         (minimal_symbol_reader::install): Remove old comment.  Update
6681         other comments.
6682
6683 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6684
6685         * s390-linux-nat.c: Add include.
6686
6687 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6688
6689         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6690         Call linux_get_hwcap.
6691         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6692         Likewise.
6693         (aarch64_linux_get_hwcap): Remove function.
6694         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6695         declaration.
6696         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6697         linux_get_hwcap.
6698         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6699         * linux-tdep.c (linux_get_hwcap): Add function.
6700         (linux_get_hwcap2): Likewise.
6701         * linux-tdep.h (linux_get_hwcap): Add declaration.
6702         (linux_get_hwcap2): Likewise.
6703         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6704         (ppc_linux_get_hwcap2): Likewise.
6705         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6706         linux_get_hwcap.
6707         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6708         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6709         (ppc_linux_nat_target::read_description): Likewise.
6710         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6711         * s390-linux-nat.c: Likewise.
6712         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6713
6714 2019-03-24  Tom Tromey  <tom@tromey.com>
6715
6716         * ada-lang.c (standard_lookup): Simplify initialization.
6717         (ada_lookup_symbol_nonlocal): Simplify return.
6718         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6719         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6720         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6721         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6722         initialization.
6723         * solib.c (solib_global_lookup): Simplify.
6724         * symtab.c (null_block_symbol): Remove.
6725         (symbol_cache_lookup): Simplify returns.
6726         (lookup_language_this): Simplify returns.
6727         (lookup_symbol_aux): Simplify return.
6728         (lookup_local_symbol): Simplify returns.
6729         (lookup_global_symbol_from_objfile): Simplify return.
6730         (lookup_symbol_in_objfile_symtabs)
6731         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6732         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6733         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6734         * cp-namespace.c (cp_lookup_bare_symbol)
6735         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6736         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6737         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6738         (cp_lookup_symbol_via_imports): Simplify initialization.
6739         (find_symbol_in_baseclass): Likewise.
6740         * symtab.h (null_block_symbol): Remove.
6741         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6742         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6743         (d_lookup_symbol_module): Likewise.
6744         (find_symbol_in_baseclass): Simplify initialization.
6745
6746 2019-03-24  Tom Tromey  <tom@tromey.com>
6747
6748         * expression.h: Don't include symtab.h.
6749         (struct block): Forward declare.
6750
6751 2019-03-24  Tom Tromey  <tom@tromey.com>
6752
6753         * c-exp.y (typebase): Remove casts.
6754         * gdbtypes.c (lookup_unsigned_typename, )
6755         (lookup_signed_typename): Remove cast.
6756         * eval.c (parse_to_comma_and_eval): Remove cast.
6757         * parse.c (write_dollar_variable): Remove cast.
6758         * block.h (struct block) <superblock>: Now const.
6759         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6760         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6761         (map_block): Make "block" const.
6762         * symfile.h (struct quick_symbol_functions)
6763         <map_matching_symbols>: Constify block argument to "callback".
6764         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6765         const.
6766         (find_pc_sect_compunit_symtab): Make "b" const.
6767         (find_symbol_at_address): Likewise.
6768         (search_symbols): Likewise.
6769         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6770         (dw2_debug_names_lookup_symbol): Likewise.
6771         (dw2_map_matching_symbols): Update.
6772         * p-valprint.c (pascal_val_print): Remove "block".
6773         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6774         (aux_add_nonlocal_symbols): Make "block" const.
6775         (resolve_subexp): Remove cast.
6776         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6777         const.
6778         (iterate_over_file_blocks): Likewise.
6779         * f-exp.y (%union) <bval>: Remove.
6780         * coffread.c (patch_opaque_types): Make "b" const.
6781         * spu-tdep.c (spu_catch_start): Make "block" const.
6782         * c-valprint.c (print_unpacked_pointer): Remove "block".
6783         * symmisc.c (dump_symtab_1): Make "b" const.
6784         (block_depth): Make "block" const.
6785         * d-exp.y (%union) <bval>: Remove.
6786         * cp-support.h (cp_lookup_rtti_type): Update.
6787         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6788         * psymtab.c (psym_lookup_symbol): Make "block" const.
6789         (maintenance_check_psymtabs): Make "b" const.
6790         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6791         (enumerate_locals, enumerate_args): Update.
6792         * python/py-symtab.c (stpy_global_block): Make "block" const.
6793         (stpy_static_block): Likewise.
6794         * inline-frame.c (block_starting_point_at): Make "new_block"
6795         const.
6796         * block.c (find_block_in_blockvector): Make return type const.
6797         (blockvector_for_pc_sect): Make "b" const.
6798         (find_block_in_blockvector): Make "b" const.
6799
6800 2019-03-23  Tom Tromey  <tom@tromey.com>
6801
6802         * varobj.c (varobj_create): Update.
6803         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6804         * printcmd.c (display_command, do_one_display): Don't reset
6805         innermost_block.
6806         * parser-defs.h (enum innermost_block_tracker_type): Move to
6807         expression.h.
6808         (innermost_block): Update comment.
6809         * parse.c (parse_exp_1): Add tracker_types parameter.
6810         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6811         tracker_types parameter.  Reset innermost_block.
6812         (parse_exp_in_context): Remove.
6813         (parse_expression_for_completion): Update.
6814         * objfiles.c (~objfile): Don't reset expression_context_block or
6815         innermost_block.
6816         * expression.h (enum innermost_block_tracker_type): Move from
6817         parser-defs.h.
6818         (parse_exp_1): Add tracker_types parameter.
6819         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6820         reset innermost_block.
6821
6822 2019-03-23  Tom Tromey  <tom@tromey.com>
6823
6824         * objfiles.h: Include bcache.h.
6825
6826 2019-03-23  Tom Tromey  <tom@tromey.com>
6827
6828         * linespec.c (get_current_search_block): Use
6829         scoped_restore_current_language.
6830         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6831
6832 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6833             Jiong Wang  <jiong.wang@arm.com>
6834
6835         * aarch64-linux-tdep.c
6836         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6837         section.
6838         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6839
6840 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6841             Jiong Wang  <jiong.wang@arm.com>
6842
6843         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6844         instructions.
6845         (aarch64_analyze_prologue_test): Add PACIASP test.
6846         (aarch64_prologue_prev_register): Unmask PC value.
6847
6848 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6849             Jiong Wang  <jiong.wang@arm.com>
6850
6851         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6852         (aarch64_dwarf2_prev_register): Unmask PC value.
6853         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6854         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6855         DW_CFA_AARCH64_negate_ra_state.
6856         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6857
6858 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6859             Jiong Wang  <jiong.wang@arm.com>
6860
6861         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6862         registers.
6863         (aarch64_pseudo_register_name): Likewise.
6864         (aarch64_pseudo_register_type): Likewise.
6865         (aarch64_pseudo_register_reggroup_p): Likewise.
6866         (aarch64_gdbarch_init): Add pauth registers.
6867         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6868         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6869         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6870         (struct gdbarch_tdep): Add regnum for ra_state.
6871
6872 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6873             Jiong Wang  <jiong.wang@arm.com>
6874
6875         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6876
6877 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6878             Jiong Wang  <jiong.wang@arm.com>
6879
6880         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6881         function.
6882         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6883         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6884         (aarch64_gdbarch_init): Add puth registers.
6885         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6886         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6887         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6888
6889 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6890             Jiong Wang  <jiong.wang@arm.com>
6891
6892         * aarch64-linux-nat.c
6893         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6894         * aarch64-linux-tdep.c
6895         (aarch64_linux_core_read_description): Likewise.
6896         (aarch64_linux_get_hwcap): New function.
6897         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6898         (aarch64_linux_get_hwcap): New declaration.
6899
6900 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6901             Jiong Wang  <jiong.wang@arm.com>
6902
6903         * aarch64-linux-nat.c
6904         (aarch64_linux_nat_target::read_description): Add pauth param.
6905         * aarch64-linux-tdep.c
6906         (aarch64_linux_core_read_description): Likewise.
6907         * aarch64-tdep.c (struct target_desc): Add in pauth.
6908         (aarch64_read_description): Add pauth param.
6909         (aarch64_gdbarch_init): Likewise.
6910         * aarch64-tdep.h (aarch64_read_description): Likewise.
6911         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6912         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6913         * features/Makefile: Add new files.
6914         * features/aarch64-pauth.c: New file.
6915         * features/aarch64-pauth.xml: New file.
6916
6917 2019-03-20  Tom Tromey  <tromey@adacore.com>
6918
6919         * infrun.c (handle_inferior_event): Rename from
6920         handle_inferior_event_1.  Create a scoped_value_mark.
6921         (handle_inferior_event): Remove.
6922
6923 2019-03-19  Tom Tromey  <tromey@adacore.com>
6924
6925         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6926         * infrun.h (print_stop_event): Add "displays" parameter.
6927         * infrun.c (print_stop_event): Add "displays" parameter.
6928
6929 2019-03-19  Pedro Alves  <palves@redhat.com>
6930
6931         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6932         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6933         to -1.  Fix TABs vs spaces.
6934         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6935         * tui/tui-out.h (tui_ui_out) Add intro comments.
6936         <m_line, m_start_of_line>: In-class initialize, and add describing
6937         comment.
6938
6939 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6940
6941         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6942         variable names.
6943         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6944
6945 2019-03-18  Pedro Alves  <palves@redhat.com>
6946             Eli Zaretskii <eliz@gnu.org>
6947
6948         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6949         m_line and m_start_of_line.
6950
6951 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6952
6953         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6954         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6955         it returns a newline.  This fixes a regression in TU mode, whereby
6956         the next line is output on the same screen line as the user input.
6957
6958 2019-03-18  Tom Tromey  <tromey@adacore.com>
6959
6960         * minsyms.c (minimal_symbol_reader::install): Remove call to
6961         obstack_blank.
6962
6963 2019-03-18  Pedro Alves  <palves@redhat.com>
6964
6965         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6966         New globals.
6967         (apply_style): New, factored out from ...
6968         (apply_ansi_escape): ... this.  Handle reverse video mode.
6969         (tui_set_reverse_mode): New function.
6970         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6971         * tui/tui-winsource.c (tui_show_source_line): Use
6972         tui_set_reverse_mode instead of setting A_STANDOUT.
6973         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6974         New setter methods.
6975
6976 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6977
6978         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6979         Handle tabs.
6980
6981 2019-03-18  Tom Tromey  <tromey@adacore.com>
6982
6983         * ada-lang.c (empty_array): Add "high" parameter.
6984         (ada_evaluate_subexp): Update.
6985
6986 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6987
6988         * unittests/string_view-selftests.c: Define
6989         _initialize_string_view_selftests unconditionally.
6990
6991 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6992
6993         PR gdb/24350
6994         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6995
6996 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6997
6998         PR gdb/24351
6999         * windows-nat.c (display_selector): Fix format specifiers.
7000
7001 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
7002
7003         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7004         tui_refill_source_window instead of tui_refresh_win, to update the
7005         current execution line.  This fixes redisplay of the current line
7006         when stepping through the code with "next" or "step".
7007
7008 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7009
7010         * source-cache.c (source_cache::get_source_lines): Call
7011         find_source_lines to initialize s->nlines.  This fixes vertical
7012         scrolling of TUI source window when the DOWN arrow is pressed.
7013
7014 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7015
7016         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7017         linux-thread-db.c (_initialize_thread_db): Likewise.
7018
7019 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7020
7021         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7022         wclrtoeol in tui_show_source_line".  This reverts changes made in
7023         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7024
7025 2019-03-15  Tom Tromey  <tom@tromey.com>
7026
7027         * symtab.h (struct minimal_symbol): Derive from
7028         general_symbol_info.
7029         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7030         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7031         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7032         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7033         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7034         (MSYMBOL_SEARCH_NAME): Update.
7035         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7036         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7037         * minsyms.c (minimal_symbol_reader::record_full): Update.
7038
7039 2019-03-15  Tom Tromey  <tom@tromey.com>
7040
7041         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7042
7043 2019-03-15  Tom Tromey  <tom@tromey.com>
7044
7045         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7046         unique_xmalloc_ptr.
7047         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7048         Update.
7049         * minsyms.c (lookup_minimal_symbol_by_pc_section)
7050         (build_minimal_symbol_hash_tables)
7051         (minimal_symbol_reader::install): Update.
7052
7053 2019-03-15  Tom Tromey  <tom@tromey.com>
7054
7055         * symtab.c (create_demangled_names_hash): Update.
7056         (symbol_set_names): Update.
7057         * objfiles.h (struct objfile_per_bfd_storage)
7058         <demangled_names_hash>: Now an htab_up.
7059         * objfiles.c (objfile_per_bfd_storage): Simplify.
7060
7061 2019-03-15  Tom Tromey  <tom@tromey.com>
7062
7063         * objfiles.h (struct objfile_per_bfd_storage): Declare
7064         destructor.
7065         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7066         New.
7067         (get_objfile_bfd_data): Use new.  Don't initialize
7068         language_of_main.
7069         (free_objfile_per_bfd_storage): Remove.
7070         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7071
7072 2019-03-15  Tom Tromey  <tom@tromey.com>
7073
7074         * symfile.c (reread_symbols): Update.
7075         * objfiles.c (objfile::objfile): Update.
7076         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7077         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7078         comment.
7079         (minimal_symbol_reader::install): Update.
7080         (terminate_minimal_symbol_table): Remove.
7081         * jit.c (jit_object_close_impl): Update.
7082
7083 2019-03-15  Tom Tromey  <tom@tromey.com>
7084
7085         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7086         initializations.
7087
7088 2019-03-15  Tom Tromey  <tom@tromey.com>
7089
7090         * objfiles.h (struct objfile_per_bfd_storage)
7091         <demangled_hash_languages>: Now a bitset.
7092         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7093         (lookup_minimal_symbol): Update.
7094
7095 2019-03-15  Tom Tromey  <tom@tromey.com>
7096
7097         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7098         Don't return the symbol.
7099         * coffread.c (record_minimal_symbol): Use record_full.
7100
7101 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7102
7103         The MS-Windows port of ncurses fails to switch to a color pair if
7104         one or both of the colors are the implicit default colors.  This
7105         change records the default colors when TUI is initialized, and
7106         then specifies them explicitly when a color pair uses the default
7107         colors.  This allows color styling in TUI mode on MS-Windows.
7108
7109         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7110         ncurses_norm_attr.
7111         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7112         colors in ncurses_norm_attr.
7113         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7114         "none", replace it with the default color recorded in
7115         ncurses_norm_attr.
7116
7117 2019-03-14  Tom Tromey  <tromey@adacore.com>
7118
7119         * source-cache.h (class source_cache) <get_source_lines>: Return
7120         std::string.
7121         * source-cache.c (source_cache::extract_lines): Handle case where
7122         first_pos==npos.  Return std::string.
7123         (source_cache::get_source_lines): Update.
7124
7125 2019-03-14  Tom Tromey  <tromey@adacore.com>
7126
7127         * NEWS: Add item for "style sources" commands.
7128         * source-cache.c (source_cache::get_source_lines): Check
7129         source_styling.
7130         * cli/cli-style.c (source_styling): New global.
7131         (_initialize_cli_style): Add "style sources" commands.
7132         (show_style_sources): New function.
7133         * cli/cli-style.h (source_styling): Declare.
7134
7135 2019-03-14  Pedro Alves  <palves@redhat.com>
7136             Tom Tromey  <tromey@adacore.com>
7137
7138         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7139         * tui/tui-winsource.c (tui_refill_source_window): New function,
7140         from...
7141         (tui_horizontal_source_scroll): ... here.  Move some logic.
7142         * cli/cli-style.c (set_style_enabled): Notify new observable.
7143         * tui/tui-hooks.c (tui_redisplay_source): New function.
7144         (tui_attach_detach_observers): Attach or detach
7145         tui_redisplay_source.
7146         * observable.h (source_styling_changed): New observable.
7147         * observable.c: Define source_styling_changed observable.
7148
7149 2019-03-13  Tom Tromey  <tromey@adacore.com>
7150
7151         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7152         (i386_gnu_nat_target::store_registers): Update.
7153         * target-debug.h (target_debug_print_std_string): New macro.
7154         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7155         * windows-tdep.c (display_one_tib): Update.
7156         * tui/tui-stack.c (tui_make_status_line): Update.
7157         * top.c (print_inferior_quit_action): Update.
7158         * thread.c (thr_try_catch_cmd): Update.
7159         (add_thread_with_info): Update.
7160         (thread_target_id_str): Update.
7161         (thr_try_catch_cmd): Update.
7162         (thread_command): Update.
7163         (thread_find_command): Update.
7164         * record-btrace.c (record_btrace_target::info_record)
7165         (record_btrace_resume_thread, record_btrace_target::resume)
7166         (record_btrace_cancel_resume, record_btrace_step_thread)
7167         (record_btrace_target::wait, record_btrace_target::wait)
7168         (record_btrace_target::wait, record_btrace_target::stop): Update.
7169         * progspace.c (print_program_space): Update.
7170         * process-stratum-target.c
7171         (process_stratum_target::thread_address_space): Update.
7172         * linux-fork.c (linux_fork_mourn_inferior)
7173         (detach_checkpoint_command, info_checkpoints_command)
7174         (linux_fork_context): Update.
7175         (linux_fork_detach): Update.
7176         (class scoped_switch_fork_info): Update.
7177         (delete_checkpoint_command): Update.
7178         * infrun.c (follow_fork_inferior): Update.
7179         (follow_fork_inferior): Update.
7180         (proceed_after_vfork_done): Update.
7181         (handle_vfork_child_exec_or_exit): Update.
7182         (follow_exec): Update.
7183         (displaced_step_prepare_throw): Update.
7184         (displaced_step_restore): Update.
7185         (start_step_over): Update.
7186         (resume_1): Update.
7187         (clear_proceed_status_thread): Update.
7188         (proceed): Update.
7189         (print_target_wait_results): Update.
7190         (do_target_wait): Update.
7191         (context_switch): Update.
7192         (stop_all_threads): Update.
7193         (restart_threads): Update.
7194         (finish_step_over): Update.
7195         (handle_signal_stop): Update.
7196         (switch_back_to_stepped_thread): Update.
7197         (keep_going_pass_signal): Update.
7198         (print_exited_reason): Update.
7199         (normal_stop): Update.
7200         * inferior.c (inferior_pid_to_str): Change return type.
7201         (print_selected_inferior): Update.
7202         (add_inferior): Update.
7203         (detach_inferior): Update.
7204         * dummy-frame.c (fprint_dummy_frames): Update.
7205         * dcache.c (dcache_info_1): Update.
7206         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7207         (btrace_fetch, btrace_clear): Update.
7208         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7209         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7210         type.
7211         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7212         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7213         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7214         * gdbarch.c, gdbarch.h: Rebuild.
7215         * gdbarch.sh (core_pid_to_str): Change return type.
7216         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7217         return type.
7218         (windows_nat_target::pid_to_str): Change return type.
7219         (windows_delete_thread): Update.
7220         (windows_nat_target::attach): Update.
7221         (windows_nat_target::files_info): Update.
7222         * target-delegates.c: Rebuild.
7223         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7224         return type.
7225         (sol_thread_target::pid_to_str): Change return type.
7226         * remote.c (class remote_target) <pid_to_str>: Change return
7227         type.
7228         (remote_target::pid_to_str): Change return type.
7229         (extended_remote_target::attach, remote_target::remote_stop_ns)
7230         (remote_target::remote_notif_remove_queued_reply)
7231         (remote_target::push_stop_reply, remote_target::disable_btrace):
7232         Update.
7233         (extended_remote_target::attach): Update.
7234         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7235         type.
7236         (gdbsim_target::pid_to_str): Change return type.
7237         * ravenscar-thread.c (struct ravenscar_thread_target)
7238         <pid_to_str>: Change return type.
7239         (ravenscar_thread_target::pid_to_str): Change return type.
7240         * procfs.c (class procfs_target) <pid_to_str>: Change return
7241         type.
7242         (procfs_target::pid_to_str): Change return type.
7243         (procfs_target::attach): Update.
7244         (procfs_target::detach): Update.
7245         (procfs_target::fetch_registers): Update.
7246         (procfs_target::store_registers): Update.
7247         (procfs_target::wait): Update.
7248         (procfs_target::files_info): Update.
7249         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7250         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7251         return type.
7252         (nto_procfs_target::pid_to_str): Change return type.
7253         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7254         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7255         return type.
7256         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7257         (exit_lwp): Update.
7258         (attach_proc_task_lwp_callback, get_detach_signal)
7259         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7260         (linux_nat_target::resume, wait_lwp, stop_callback)
7261         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7262         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7263         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7264         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7265         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7266         type.
7267         (inf_ptrace_target::attach): Update.
7268         (inf_ptrace_target::files_info): Update.
7269         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7270         type.
7271         (go32_nat_target::pid_to_str): Change return type.
7272         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7273         (gnu_nat_target::wait): Update.
7274         (gnu_nat_target::wait): Update.
7275         (gnu_nat_target::resume): Update.
7276         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7277         (fbsd_nat_target::wait): Update.
7278         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7279         type.
7280         (darwin_nat_target::attach): Update.
7281         * corelow.c (class core_target) <pid_to_str>: Change return type.
7282         (core_target::pid_to_str): Change return type.
7283         * target.c (normal_pid_to_str): Change return type.
7284         (default_pid_to_str): Likewise.
7285         (target_pid_to_str): Change return type.
7286         (target_translate_tls_address): Update.
7287         (target_announce_detach): Update.
7288         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7289         return type.
7290         (bsd_uthread_target::pid_to_str): Change return type.
7291         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7292         type.
7293         (bsd_kvm_target::pid_to_str): Change return type.
7294         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7295         return type.
7296         (aix_thread_target::pid_to_str): Change return type.
7297         * target.h (struct target_ops) <pid_to_str>: Change return type.
7298         (target_pid_to_str, normal_pid_to_str): Likewise.
7299         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7300         type.
7301         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7302         type.
7303         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7304         return type.
7305         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7306         type.
7307         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7308         type.
7309         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7310         return type.
7311
7312 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7313
7314         * NEWS: Mention that the new default MI version is 3.  Mention
7315         changes to the output of commands and events that deal with
7316         multi-location breakpoints.
7317         * breakpoint.c: Include "mi/mi-out.h".
7318         (print_one_breakpoint): Change output syntax if using MI version
7319         >= 3.
7320         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7321         New.
7322         (mi_multi_location_breakpoint_output_fixed): New.
7323         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7324         (mi_cmd_fix_multi_location_breakpoint_output): New.
7325         (mi_multi_location_breakpoint_output_fixed): New.
7326         * mi/mi-cmds.c (mi_cmds): Register command
7327         -fix-multi-location-breakpoint-output.
7328         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7329         interpreter "mi".
7330
7331 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7332
7333         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7334         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7335         instantiate mi_ui_out based on interpreter name.
7336         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7337         * mi/mi-main.c (mi_load_progress): Likewise.
7338
7339 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7340
7341         * NEWS: Combine separate "New targets" sections for 8.3.
7342
7343 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7344
7345         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7346         (ppcfbsd_init_abi): Install gdbarch
7347         "fetch_tls_load_module_address" and "get_thread_local_address"
7348         methods.
7349
7350 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7351
7352         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7353         (riscv_fbsd_init_abi): Install gdbarch
7354         "fetch_tls_load_module_address" and "get_thread_local_address"
7355         methods.
7356
7357 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7358
7359         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7360         (i386fbsd_init_abi): Install gdbarch
7361         "fetch_tls_load_module_address" and "get_thread_local_address"
7362         methods.
7363
7364 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7365
7366         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7367         (amd64fbsd_init_abi): Install gdbarch
7368         "fetch_tls_load_module_address" and "get_thread_local_address"
7369         methods.
7370
7371 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7372
7373         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7374         (struct fbsd_pspace_data): New type.
7375         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7376         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7377         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7378         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7379         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7380
7381 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7382
7383         * gdbtypes.c (lookup_struct_elt): New function.
7384         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7385         * gdbtypes.h (struct struct_elt): New type.
7386         (lookup_struct_elt): New prototype.
7387
7388 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7389
7390         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7391         remove disabled code block.
7392
7393 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7394
7395         * gdbarch.sh (get_thread_local_address): New method.
7396         * gdbarch.h, gdbarch.c: Regenerate.
7397         * target.c (target_translate_tls_address): Use
7398         gdbarch_get_thread_local_address if present instead of
7399         target::get_thread_local_address.
7400
7401 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7402
7403         * target.h (target::get_thread_local_address): Update comment.
7404
7405 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7406
7407         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7408         objfile->separate_debug_objfile_backlink if not NULL.
7409
7410 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7411
7412         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7413         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7414         (amd64bsd_store_inferior_registers): Likewise.
7415         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7416         Enable segment base registers.
7417         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7418         PT_GETFSBASE and PT_GETGSBASE.
7419         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7420         PT_SETGSBASE.
7421         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7422         segment base registers.
7423         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7424
7425 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7426
7427         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7428         Update calls to i386_target_description to add 'segments'
7429         parameter.
7430         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7431         add segment base registers.
7432         * arch/i386.c (i386_create_target_description): Add 'segments'
7433         parameter to enable segment base registers.
7434         * arch/i386.h (i386_create_target_description): Likewise.
7435         * features/i386/32bit-segments.xml: New file.
7436         * features/i386/32bit-segments.c: Generate.
7437         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7438         call to i386_target_description to add 'segments' parameter.
7439         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7440         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7441         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7442         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7443         if feature is present.
7444         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7445         Add 'segments' parameter to call to i386_target_description.
7446         (i386_target_description): Add 'segments' parameter to enable
7447         segment base registers.
7448         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7449         to call to i386_target_description.
7450         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7451         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7452         Define I386_NUM_REGS.
7453         (i386_target_description): Add 'segments' parameter to enable
7454         segment base registers.
7455
7456 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7457
7458         PR/24325
7459         * source-cache.c: #undef open and close, to avoid unresolved
7460         externals during linking.
7461
7462 2019-03-12  Tom Tromey  <tromey@adacore.com>
7463
7464         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7465         const.  Add initializers.
7466         (_initialize_remote): Don't initialize ptid globals.
7467
7468 2019-03-12  Pedro Alves  <palves@redhat.com>
7469
7470         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7471
7472 2019-03-12  Pedro Alves  <palves@redhat.com>
7473
7474         * cp-name-parser.y (main): Remove unused 'len' variable.
7475
7476 2019-03-12  Tom Tromey  <tromey@adacore.com>
7477
7478         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7479         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7480
7481 2019-03-12  Tom Tromey  <tromey@adacore.com>
7482
7483         * linux-nat.c (iterate_over_lwps): Update.
7484         (stop_callback): Remove parameter.
7485         (stop_wait_callback, detach_callback, resume_set_callback)
7486         (select_singlestep_lwp_callback, set_ignore_sigint)
7487         (status_callback, resumed_callback, resume_clear_callback)
7488         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7489         data parameter.
7490         (linux_nat_target::detach, linux_nat_target::resume)
7491         (linux_stop_and_wait_all_lwps, select_event_lwp)
7492         (linux_nat_filter_event, linux_nat_wait_1)
7493         (linux_nat_target::kill, linux_nat_target::stop)
7494         (linux_nat_target::stop): Update.
7495         (linux_nat_resume_callback): Change type.
7496         (resume_stopped_resumed_lwps, count_events_callback)
7497         (select_event_lwp_callback): Likewise.
7498         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7499         * arm-linux-nat.c (struct update_registers_data): Remove.
7500         (update_registers_callback): Change type.
7501         (arm_linux_insert_hw_breakpoint1): Update.
7502         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7503         parameter.
7504         (x86_linux_dr_set_addr): Update.
7505         (x86_linux_dr_set_control): Update.
7506         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7507         (iterate_over_lwps): Use gdb::function_view.
7508         * nat/aarch64-linux-hw-point.c (struct
7509         aarch64_dr_update_callback_param): Remove.
7510         (debug_reg_change_callback): Change type.
7511         (aarch64_notify_debug_reg_change): Update.
7512         * s390-linux-nat.c (s390_refresh_per_info): Update.
7513
7514 2019-03-11  Tom Tromey  <tromey@adacore.com>
7515
7516         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7517         redundant assignment to "this_cu".
7518
7519 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7520
7521         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7522
7523 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7524
7525         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7526         from...
7527         (rank_one_type): ... this.
7528
7529 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7530
7531         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7532         from...
7533         (rank_one_type): ... this.
7534
7535 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7536
7537         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7538         from...
7539         (rank_one_type): ... this.
7540
7541 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7542
7543         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7544         from...
7545         (rank_one_type): ... this.
7546
7547 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7548
7549         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7550         from...
7551         (rank_one_type): ... this.
7552
7553 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7554
7555         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7556         from...
7557         (rank_one_type): ... this.
7558
7559 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7560
7561         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7562         from...
7563         (rank_one_type): ... this.
7564
7565 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7566
7567         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7568         from...
7569         (rank_one_type): ... this.
7570
7571 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7572
7573         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7574         from...
7575         (rank_one_type): ... this.
7576
7577 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7578
7579         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7580         from...
7581         (rank_one_type): ... this.
7582
7583 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7584
7585         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7586         from...
7587         (rank_one_type): ... this.
7588
7589 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7590
7591         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7592         from...
7593         (rank_one_type): ... this.
7594
7595 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7596
7597         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7598         inferior-events' shows the example events.
7599
7600 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7601
7602         Support styling on native MS-Windows console
7603
7604         PR/24315
7605         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7606         on MS-Windows if $TERM is not defined.
7607
7608         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7609
7610         * posix-hdep.c (gdb_console_fputs):
7611         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7612         functions.
7613         * ui-file.h (gdb_console_fputs): Add prototype.
7614
7615         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7616         back to fputs only if the former returns zero.
7617
7618 2019-03-07  Tom Tromey  <tom@tromey.com>
7619
7620         * symmisc.c (print_symbol_bcache_statistics): Update.
7621         (print_objfile_statistics): Update.
7622         * symfile.c (allocate_symtab): Update.
7623         * stabsread.c: Don't include bcache.h.
7624         * psymtab.h (struct psymbol_bcache): Don't declare.
7625         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7626         (psymbol_bcache_init, psymbol_bcache_free)
7627         (psymbol_bcache_get_bcache): Don't declare.
7628         * psymtab.c (struct psymbol_bcache): Remove.
7629         (psymtab_storage::psymtab_storage): Update.
7630         (psymtab_storage::~psymtab_storage): Update.
7631         (psymbol_bcache_init, psymbol_bcache_free)
7632         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7633         (add_psymbol_to_bcache): Update.
7634         (allocate_psymtab): Update.
7635         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7636         macro_cache>: No longer pointers.
7637         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7638         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7639         * macrotab.c (macro_bcache): Update.
7640         * macroexp.c: Don't include bcache.h.
7641         * gdbtypes.c (check_types_worklist): Update.
7642         (types_deeply_equal): Remove TRY/CATCH.  Update.
7643         * elfread.c (elf_symtab_read): Update.
7644         * dwarf2read.c: Don't include bcache.h.
7645         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7646         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7647         (print_bcache_statistics, bcache_memory_used): Don't declare.
7648         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7649         methods.  Rename all data members.
7650         * bcache.c (struct bcache): Move to bcache.h.
7651         (bcache::expand_hash_table): Rename from expand_hash_table.
7652         (bcache): Remove.
7653         (bcache::insert): Rename from bcache_full.
7654         (bcache::compare): Rename from bcache_compare.
7655         (bcache_xmalloc): Remove.
7656         (bcache::~bcache): Rename from bcache_xfree.
7657         (bcache::print_statistics): Rename from print_bcache_statistics.
7658         (bcache::memory_used): Rename from bcache_memory_used.
7659
7660 2019-03-07  Pedro Alves  <palves@redhat.com>
7661
7662         * infrun.c (normal_stop): Also check for
7663         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7664
7665 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7666
7667         * f-lang.c (value_from_host_double): Moved to...
7668         * value.c (value_from_host_double): ...here.
7669         * value.h (value_from_host_double): Declare.
7670         * guile/scm-math.c (vlscm_convert_typed_number): Use
7671         value_from_host_double.
7672         (vlscm_convert_number): Likewise.
7673         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7674         * python/py-value.c (convert_value_from_python): Likewise.
7675
7676 2019-03-06  Tom Tromey  <tom@tromey.com>
7677
7678         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7679
7680 2019-03-06  Tom Tromey  <tom@tromey.com>
7681
7682         * utils.h (free_current_contents): Don't declare.
7683         * utils.c (free_current_contents): Remove.
7684
7685 2019-03-06  Tom Tromey  <tom@tromey.com>
7686
7687         * top.c (quit_force): Update.
7688         * main.c (captured_command_loop): Update.
7689         * common/new-op.c (operator new): Update.
7690         * common/common-exceptions.c (struct catcher)
7691         <save_cleanup_chain>: Remove member.
7692         (exceptions_state_mc_init): Update.
7693         (exception_try_scope_entry): Return nullptr.
7694         (exception_try_scope_exit, exception_rethrow)
7695         (throw_exception_sjlj, throw_exception_cxx): Update.
7696         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7697         (all_cleanups, do_cleanups, discard_cleanups)
7698         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7699         (restore_cleanups, restore_final_cleanups): Don't declare.
7700         (do_final_cleanups): Remove parameter.
7701         * common/cleanups.c (cleanup_chain, make_cleanup)
7702         (make_cleanup_dtor, all_cleanups, do_cleanups)
7703         (discard_my_cleanups, discard_cleanups)
7704         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7705         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7706         (null_cleanup): Remove.
7707         (do_final_cleanups): Remove parameter.
7708
7709 2019-03-06  Tom Tromey  <tom@tromey.com>
7710
7711         * remote.c (remote_target::remote_parse_stop_reply): Use
7712         unique_xmalloc_ptr.
7713
7714 2019-03-06  Tom Tromey  <tom@tromey.com>
7715
7716         * stabsread.c (struct stabs_field_info): Rename from field_info.
7717         <list, fnlist>: Add initializers.
7718         <obstack>: New member.
7719         (read_member_functions, read_struct_fields, read_baseclasses):
7720         Allocate on obstack.  Don't use cleanups.
7721         (read_one_struct_field, read_member_functions, read_struct_fields)
7722         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7723         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7724         (read_struct_type): Update.
7725
7726 2019-03-06  Tom Tromey  <tom@tromey.com>
7727
7728         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7729         * common/filestuff.h (make_cleanup_close): Don't declare.
7730         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7731         Remove.
7732
7733 2019-03-06  Tom Tromey  <tom@tromey.com>
7734
7735         * solib-aix.c: Use make_scope_exit.
7736
7737 2019-03-06  Tom Tromey  <tom@tromey.com>
7738
7739         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7740         Use make_scope_exit.
7741
7742 2019-03-06  Tom Tromey  <tom@tromey.com>
7743
7744         * solib-svr4.c (disable_probes_interface): Remove parameter.
7745         (svr4_handle_solib_event): Use make_scope_exit.
7746
7747 2019-03-06  Tom Tromey  <tom@tromey.com>
7748
7749         * remote.c (struct stop_reply_deleter): Remove.
7750         (stop_reply_up): Update.
7751         (struct stop_reply): Derive from notif_event.  Don't typedef.
7752         <regcache>: Now a std::vector.
7753         (stop_reply_xfree): Remove.
7754         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7755         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7756         (remote_target::discard_pending_stop_replies): Use delete.
7757         (remote_target::remote_parse_stop_reply): Update.
7758         (remote_target::process_stop_reply): Update.
7759         * remote-notif.h (struct notif_event): Add virtual destructor.
7760         Remove "dtr" member.
7761         (struct notif_client) <alloc_event>: Return a unique_ptr.
7762         (notif_event_xfree): Don't declare.
7763         (notif_event_up): New typedef.
7764         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7765         (notif_event_xfree, do_notif_event_xfree): Remove.
7766         (remote_notif_state_xfree): Update.
7767
7768 2019-03-06  Tom Tromey  <tom@tromey.com>
7769
7770         * infrun.c (displaced_step_clear_cleanup): Now a
7771         forward_scope_exit type.
7772         (displaced_step_prepare_throw): Update.
7773         (displaced_step_fixup): Update.
7774
7775 2019-03-06  Tom Tromey  <tom@tromey.com>
7776
7777         * inferior.h (class inferior): Update comment.
7778         * gdbthread.h (class thread_info): Update comment.
7779
7780 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7781             Tom Tromey  <tom@tromey.com>
7782
7783         * stabsread.h (struct stab_section_list): Remove.
7784         (coffstab_build_psymtabs): Update.
7785         * dbxread.c (symbuf_sections): Now a std::vector.
7786         (sect_idx): New global.
7787         (fill_symbuf): Update.
7788         (coffstab_build_psymtabs): Change type of stabsects parameter.
7789         Update.
7790         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7791         std::vector.
7792         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7793         (coff_locate_sections): Update.
7794         (coff_symfile_read): Remove cleanups.  Update.
7795         (init_stringtab): Add storage parameter.
7796         (free_stringtab, free_stringtab_cleanup): Remove.
7797         (init_lineno): Add storage parameter.
7798         (free_linetab, free_linetab_cleanup): Remove.
7799
7800 2019-03-06  Pedro Alves  <palves@redhat.com>
7801
7802         * linux-fork.c (fork_info::clobber_regs): Delete.
7803         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7804         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7805         comment.  Adjust.
7806         (scoped_switch_fork_info::scoped_switch_fork_info)
7807         (checkpoint_command, linux_fork_context): Adjust
7808         fork_save_infrun_state calls.
7809
7810 2019-03-06  Pedro Alves  <palves@redhat.com>
7811
7812         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7813         (inf_has_multiple_threads): Return 'bool' and rewrite using
7814         inferior_info::threads().
7815
7816 2019-03-06  Pedro Alves  <palves@redhat.com>
7817
7818         * linux-fork.c: Include <list>.
7819         (fork_list): Now a std::list instance.
7820         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7821         (forks_exist_p, find_last_fork): Adjust.
7822         (new_fork): Delete.
7823         (one_fork_p): New.
7824         (add_fork): Adjust.
7825         (free_fork): Delete, folded into fork_info::~fork_info().
7826         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7827         Adjust.
7828         (init_fork_list): Delete.
7829         (linux_fork_killall, linux_fork_mourn_inferior)
7830         (linux_fork_detach, info_checkpoints_command): Adjust.
7831         (_initialize_linux_fork): No longer call init_fork_list.
7832
7833 2019-03-06  Pedro Alves  <palves@redhat.com>
7834
7835         * linux-fork.c (new_fork): New, split out of ...
7836         (add_fork): ... this.  Return void.  Move "first fork" special
7837         case from here, to ...
7838         (checkpoint_command): ... here.
7839         * linux-linux.h (add_fork): Return void.
7840
7841 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7842
7843         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7844
7845 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7846             Chris January  <chris.january@arm.com>
7847             David Lecomber  <david.lecomber@arm.com>
7848
7849         * f-exp.y: New token, UNOP_INTRINSIC.
7850         (exp): New pattern using UNOP_INTRINSIC token.
7851         (f77_keywords): Add 'abs' keyword.
7852         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7853         (value_from_host_double): New function.
7854         (evaluate_subexp_f): Support UNOP_ABS.
7855
7856 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7857
7858         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7859         types.
7860
7861 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7862
7863         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7864         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7865         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7866
7867 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7868
7869         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7870
7871 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7872             Chris January  <chris.january@arm.com>
7873
7874         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7875         * f-exp.y: Define 'KIND' token.
7876         (exp): New pattern for KIND expressions.
7877         (ptype): Handle types with a kind extension.
7878         (direct_abs_decl): Extend to spot kind extensions.
7879         (f77_keywords): Add 'kind' to the list.
7880         (push_kind_type): New function.
7881         (convert_to_kind_type): New function.
7882         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7883         * parse.c (operator_length_standard): Likewise.
7884         * parser-defs.h (enum type_pieces): Add tp_kind.
7885         * std-operator.def: Add UNOP_KIND.
7886
7887 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7888
7889         * f-exp.y (f_parse): Set yydebug.
7890
7891 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7892
7893         * f-lang.c (evaluate_subexp_f): New function.
7894         (exp_descriptor_f): New global.
7895         (f_language_defn): Use exp_descriptor_f instead of
7896         exp_descriptor_standard.
7897
7898 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7899
7900         * f-exp.y (struct token): Add comments.
7901         (dot_ops): Remove uppercase versions and the end marker.
7902         (f77_keywords): Likewise.
7903         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7904         entries in the dot_ops array are case insensitive, and use
7905         strncasecmp to compare strings.  Also some whitespace cleanup in
7906         this area.  Similar for the f77_keywords array, except entries in
7907         this list might be case sensitive.
7908
7909 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7910
7911         * f-exp.y (struct f77_boolean_val): Add comments.
7912         (boolean_values): Remove uppercase versions, and end marker.
7913         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7914         and use strncasecmp to achieve case insensitivity.  Additionally,
7915         perform whitespace cleanup around this code.
7916
7917 2019-03-06  Tom Tromey  <tromey@adacore.com>
7918
7919         * remote-sim.c (gdbsim_target_open): Use result of
7920         gdb_argv::release.
7921
7922 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7923         Dirk Schubert  <dirk.schubert@arm.com>
7924         Chris January  <chris.january@arm.com>
7925
7926         * eval.c (evaluate_subexp_standard): Call Fortran argument
7927         wrapping logic.
7928         * f-lang.c (struct value): A value which can be passed into a
7929         Fortran function call.
7930         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7931         where appropriate.
7932         (struct type): Value ready for a Fortran function call.
7933         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7934         is needed.
7935         * f-lang.h (fortran_argument_convert): Declaration.
7936         (fortran_preserve_arg_pointer): Declaration.
7937         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7938
7939 2019-03-05  Tom Tromey  <tromey@adacore.com>
7940
7941         * python/py-prettyprint.c (print_string_repr): Remove #if.
7942         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7943
7944 2019-03-05  Tom Tromey  <tromey@adacore.com>
7945
7946         * target.c (the_dummy_target): Move later.  Change type to
7947         "dummy_target".
7948         (initialize_targets): Don't initialize the_dummy_target.
7949
7950 2019-03-05  Tom Tromey  <tromey@adacore.com>
7951
7952         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7953         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7954
7955 2019-03-05  Tom Tromey  <tromey@adacore.com>
7956
7957         * windows-nat.c (windows_nat_target::attach)
7958         (windows_nat_target::detach): Don't call gdb_flush.
7959         * valprint.c (generic_val_print, val_print, val_print_string):
7960         Don't call gdb_flush.
7961         * utils.c (defaulted_query): Don't call gdb_flush.
7962         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7963         * target.c (target_announce_detach): Don't call gdb_flush.
7964         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7965         * remote.c (extended_remote_target::attach): Don't call
7966         gdb_flush.
7967         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7968         * printcmd.c (do_examine): Don't call gdb_flush.
7969         (info_display_command): Don't call gdb_flush.
7970         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7971         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7972         * memattr.c (info_mem_command): Don't call gdb_flush.
7973         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7974         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7975         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7976         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7977         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7978         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7979         (gnu_nat_target::detach): Don't call gdb_flush.
7980         * f-valprint.c (f_val_print): Don't call gdb_flush.
7981         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7982         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7983         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7984         gdb_flush.
7985         * c-valprint.c (c_val_print): Don't call gdb_flush.
7986         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7987
7988 2019-03-05  Tom Tromey  <tromey@adacore.com>
7989
7990         * varobj.c (update_dynamic_varobj_children): Update.
7991         (install_default_visualizer): Use reset, not release.
7992         * value.c (set_internalvar): Update.
7993         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7994         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7995         ATTRIBUTE_UNUSED_RESULT.
7996
7997 2019-03-05  Tom Tromey  <tromey@adacore.com>
7998
7999         * remote.c (class scoped_remote_fd) <release>: Add
8000         ATTRIBUTE_UNUSED_RESULT.
8001
8002 2019-03-05  Tom Tromey  <tromey@adacore.com>
8003
8004         * macroexp.c (struct macro_buffer) <release>: Add
8005         ATTRIBUTE_UNUSED_RESULT.
8006
8007 2019-03-05  Tom Tromey  <tromey@adacore.com>
8008
8009         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8010         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8011         ATTRIBUTE_UNUSED_RESULT.
8012
8013 2019-03-05  Tom Tromey  <tromey@adacore.com>
8014
8015         * common/scoped_fd.h (class scoped_fd) <release>: Add
8016         ATTRIBUTE_UNUSED_RESULT.
8017
8018 2019-03-05  Tom Tromey  <tromey@adacore.com>
8019
8020         * parser-defs.h (struct parser_state) <release>: Add
8021         ATTRIBUTE_UNUSED_RESULT.
8022
8023 2019-03-05  Tom Tromey  <tromey@adacore.com>
8024
8025         * utils.h (class gdb_argv) <release>: Add
8026         ATTRIBUTE_UNUSED_RESULT.
8027         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8028
8029 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
8030
8031         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8032         for-loop range, to avoid compiler warnings.
8033
8034         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8035         avoid compiler warnings about unused variables.
8036
8037         * NEWS: Mention end of support for native debugging on MS-Windows
8038         before XP.
8039
8040         PR gdb/24292
8041         * common/netstuff.c:
8042         * gdbserver/gdbreplay.c
8043         * gdbserver/remote-utils.c:
8044         * ser-tcp.c:
8045         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8046         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
8047         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8048         'getaddrinfo' and 'freeaddrinfo' were not available before
8049         Windows XP, and mingw.org's MinGW headers by default define
8050         _WIN32_WINNT to 0x500.
8051
8052 2019-03-01  Gary Benson <gbenson@redhat.com>
8053
8054         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8055
8056 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
8057             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
8058
8059         PR gdb/8527
8060         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8061         set_sigint_trap, clear_sigint_trap.
8062
8063 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8064
8065         * target.c (target_detach): Clear the regcache and the
8066         frame cache.
8067
8068 2019-02-27  Pedro Alves  <palves@redhat.com>
8069
8070         * utils.c (set_screen_size): When we cap the height/width sizes,
8071         tweak the corresponding command variable to show "unlimited":
8072
8073 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8074             Pedro Alves  <palves@redhat.com>
8075
8076         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8077         before calling rl_set_screen_size.
8078
8079 2019-02-27  Tom Tromey  <tromey@adacore.com>
8080
8081         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8082         define.
8083         * python/py-value.c: Remove Python 2.4 workaround.
8084         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8085         workaround.
8086         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8087         Python 2.4 workaround.
8088         * python/python-internal.h: Remove Python 2.4 comment.
8089         (Py_ssize_t): Don't define.
8090         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8091         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8092         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8093         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8094         * python/python.c (do_start_initialization): Remove Python 2.4
8095         workaround.
8096         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8097         (print_children): Remove Python 2.4 workaround.
8098         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8099         workaround.
8100         (CHARBUFFERPROC_NAME): Remove.
8101         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8102         Python 2.4 workaround.
8103
8104 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8105
8106         * NEWS: Note minimum Python version.
8107
8108 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8109
8110         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8111         code from these functions.  Remove corresponding ifdefs.  Use
8112         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8113         Remove gotos and target of gotos.
8114         (infpy_search_memory): Likewise.
8115
8116 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8117
8118         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8119         (hppa_gdbarch_init): Don't register deleted functions with
8120         gdbarch.
8121
8122 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8123
8124         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8125         (h8300_unwind_sp): Delete.
8126         (h8300_dummy_id): Delete.
8127         (h8300_gdbarch_init): Don't register deleted functions with
8128         gdbarch.
8129
8130 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8131
8132         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8133         (ft32_unwind_pc): Delete.
8134         (ft32_unwind_sp): Delete.
8135         (ft32_gdbarch_init): Don't register deleted functions with
8136         gdbarch.
8137
8138 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8139
8140         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8141         (frv_unwind_pc): Delete.
8142         (frv_unwind_sp): Delete.
8143         (frv_gdbarch_init): Don't register deleted functions with
8144         gdbarch.
8145
8146 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8147
8148         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8149         (riscv_unwind_pc): Delete.
8150         (riscv_unwind_sp): Delete.
8151         (riscv_gdbarch_init): Don't register deleted functions with
8152         gdbarch.
8153
8154 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8155
8156         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8157         (csky_unwind_pc): Delete.
8158         (csky_unwind_sp): Delete.
8159         (csky_gdbarch_init): Don't register deleted functions with
8160         gdbarch.
8161
8162 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8163
8164         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8165         (cris_unwind_pc): Delete.
8166         (cris_unwind_sp): Delete.
8167         (cris_gdbarch_init): Don't register deleted functions with
8168         gdbarch.
8169
8170 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8171
8172         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8173         (bfin_unwind_pc): Delete.
8174         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8175
8176 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8177
8178         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8179         (arm_unwind_pc): Delete.
8180         (arm_unwind_sp): Delete.
8181         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8182
8183 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8184
8185         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8186         (arc_unwind_pc): Delete.
8187         (arc_unwind_sp): Delete.
8188         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8189
8190 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8191
8192         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8193         (alpha_unwind_pc): Delete.
8194         (alpha_gdbarch_init): Don't register deleted functions with
8195         gdbarch.
8196
8197 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8198
8199         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8200         (aarch64_unwind_pc): Delete.
8201         (aarch64_unwind_sp): Delete.
8202         (aarch64_gdbarch_init): Don't register deleted functions with
8203         gdbarch.
8204
8205 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8206
8207         * gdbtypes.c (type_align): Don't consider static members when
8208         computing structure alignment.
8209
8210 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8211
8212         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8213         return 0 for other types.
8214         * arch-utils.c (default_type_align): Always return 0.
8215         * gdbarch.h: Regenerate.
8216         * gdbarch.sh (type_align): Extend comment.
8217         * gdbtypes.c (type_align): Add additional comments, always call
8218         gdbarch_type_align before applying the default rules.
8219         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8220         generic code will then apply a suitable default.
8221         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8222         types, return 0 for other types.
8223
8224 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8225
8226         * NEWS: Create a new section for the next release branch.
8227         Rename the section of the current branch, now that it has
8228         been cut.
8229
8230 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8231
8232         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8233         * version.in: Bump version to 8.3.50.DATE-git.
8234
8235 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8236
8237         * aix-thread.c (ptid_cmp): Remove unused variable.
8238         (get_signaled_thread): Likewise.
8239         (store_regs_user_thread): Likewise.
8240         (store_regs_kernel_thread): Likewise.
8241         (fetch_regs_kernel_thread): Remove shadowed variable.
8242
8243 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8244
8245         * features/riscv/32bit-cpu.xml: Add register numbers.
8246         * features/riscv/32bit-fpu.c: Regenerate.
8247         * features/riscv/32bit-fpu.xml: Add register numbers.
8248         * features/riscv/64bit-cpu.xml: Add register numbers.
8249         * features/riscv/64bit-fpu.c: Regenerate.
8250         * features/riscv/64bit-fpu.xml: Add register numbers.
8251
8252 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8253
8254         * NEWS: Mention two argument form of gdb.Value constructor.
8255         * python/py-value.c (convert_buffer_and_type_to_value): New
8256         function.
8257         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8258         Add support for handling an optional second argument.  Call
8259         convert_buffer_and_type_to_value as appropriate.
8260         * python/python-internal.h (Py_buffer_deleter): New struct.
8261         (Py_buffer_up): New typedef.
8262
8263 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8264
8265         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8266         instead of releasing ownership.
8267
8268 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8269
8270         * dwarf2read.c (open_and_init_dwp_file): Call
8271         elf_numsections instead of bfd_count_sections to initialize
8272         dwp_file->num_sections.
8273
8274 2019-02-25  Tom Tromey  <tromey@adacore.com>
8275
8276         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8277
8278 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8279
8280         * gcore.in: Add '--readnever' option when invoking GDB.
8281
8282 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8283
8284         * MAINTAINERS: Update my email address.
8285
8286 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8287
8288         * build-id.c (build_id_to_debug_bfd_1): New function.
8289         (build_id_to_debug_bfd): Look for separate debug file in
8290         sysroot.
8291
8292 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8293
8294         * gdbarch.sh: Update the copyright year range that is placed into
8295         generated files.
8296
8297 2019-02-22  Keith Seitz  <keiths@redhat.com>
8298
8299         PR symtab/23853
8300         * linespec.c (create_sals_line_offset): Search for the default
8301         symtab's filename instead of its fullname.
8302
8303 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8304
8305         * NEWS: Update style defaults.
8306
8307 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8308
8309         * main.c (captured_main_1): Disable styling in batch mode.
8310
8311 2019-02-20  Tom Tromey  <tom@tromey.com>
8312
8313         * symtab.c (symtab_symbol_info): Fix typos.
8314
8315 2019-02-20  Tom Tromey  <tromey@adacore.com>
8316
8317         * findcmd.c (_initialize_mem_search): Use upper case for
8318         metasyntactic variables.
8319
8320 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8321
8322         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8323         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8324
8325 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8326
8327         * top.h (source_file_name): Change to std::string.
8328         * top.c (source_file_name): Likewise.
8329         (command_line_input): Adjust.
8330         * cli/cli-script.c (script_from_file): Adjust.
8331
8332 2019-02-19  Tom Tromey  <tromey@adacore.com>
8333
8334         * ravenscar-thread.c
8335         (ravenscar_thread_target::update_thread_list): Don't call
8336         ada_build_task_list.
8337         * ada-lang.h (ada_build_task_list): Don't declare.
8338         * ada-tasks.c (struct ada_tasks_inferior_data)
8339         <task_list_valid_p>: Now bool.
8340         (read_known_tasks, ada_task_list_changed)
8341         (ada_tasks_invalidate_inferior_data): Update.
8342         (read_known_tasks_array): Return bool.
8343         (read_known_tasks_list): Likewise.
8344         (read_known_tasks): Return void.
8345         (ada_build_task_list): Now static.
8346
8347 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8348
8349         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8350         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8351
8352 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8353
8354         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8355         variant for ada_tasks_pspace_data_handle and
8356         ada_tasks_inferior_data_handle.
8357         (ada_tasks_pspace_data_cleanup): New function.
8358         (ada_tasks_inferior_data_cleanup): New function.
8359
8360 2019-02-17  Tom Tromey  <tom@tromey.com>
8361
8362         * macrotab.h (macro_source_fullname): Return a std::string.
8363         * macrotab.c (macro_include, check_for_redefinition)
8364         (macro_undef, macro_lookup_definition, foreach_macro)
8365         (foreach_macro_in_scope): Update.
8366         (macro_source_fullname): Return a std::string.
8367         * macrocmd.c (show_pp_source_pos): Update.
8368
8369 2019-02-17  Tom Tromey  <tom@tromey.com>
8370
8371         * macrocmd.c (show_pp_source_pos): Style the file names.
8372
8373 2019-02-17  Tom Tromey  <tom@tromey.com>
8374
8375         PR tui/24197:
8376         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8377
8378 2019-02-17  Tom Tromey  <tom@tromey.com>
8379
8380         * ada-lang.c (user_select_syms): Use filtered printing.
8381         * utils.c (wrap_style): New global.
8382         (desired_style): Remove.
8383         (emit_style_escape): Add stream parameter.
8384         (set_output_style, reset_terminal_style, prompt_for_continue):
8385         Update.
8386         (flush_wrap_buffer): Only flush gdb_stdout.
8387         (wrap_here): Set wrap_style.
8388         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8389         treat escape sequences as a character.  Change when wrap buffer is
8390         flushed.
8391         (fputs_styled): Do not set the output style when the default is
8392         requested.
8393         * ui-style.h (struct ui_file_style) <is_default>: New method.
8394         * source.c (print_source_lines_base): Emit escape sequences in one
8395         piece.
8396
8397 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8398
8399         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8400         integers and enumeration types.
8401
8402 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8403
8404         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8405         instead of lookup_symbol_in_language
8406         (do_exact_match): New function.
8407         (ada_get_symbol_name_matcher): Return do_exact_match when
8408         doing a verbatim match.
8409
8410 2019-02-15  Tom Tromey  <tromey@adacore.com>
8411
8412         * ravenscar-thread.c (ravenscar_thread_target::resume)
8413         (ravenscar_thread_target::wait): Special case wildcard requests.
8414
8415 2019-02-15  Tom Tromey  <tromey@adacore.com>
8416
8417         * ravenscar-thread.c (base_ptid): Remove.
8418         (struct ravenscar_thread_target) <close>: New method.
8419         <m_base_ptid>: New member.
8420         <update_inferior_ptid, active_task, task_is_currently_active,
8421         runtime_initialized>: Declare methods.
8422         <ravenscar_thread_target>: Add constructor.
8423         (ravenscar_thread_target::task_is_currently_active)
8424         (ravenscar_thread_target::update_inferior_ptid)
8425         (ravenscar_runtime_initialized): Rename.  Now methods.
8426         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8427         (ravenscar_thread_target::update_thread_list): Update.
8428         (ravenscar_thread_target::active_task): Now method.
8429         (ravenscar_thread_target::store_registers)
8430         (ravenscar_thread_target::prepare_to_store)
8431         (ravenscar_thread_target::prepare_to_store)
8432         (ravenscar_thread_target::mourn_inferior): Update.
8433         (ravenscar_inferior_created): Use "new" to create target.
8434         (ravenscar_thread_target::get_ada_task_ptid): Update.
8435         (_initialize_ravenscar): Don't initialize base_ptid.
8436         (ravenscar_ops): Remove global.
8437
8438 2019-02-15  Tom Tromey  <tromey@adacore.com>
8439
8440         * target.h (push_target): Declare new overload.
8441         * target.c (push_target): New overload, taking an rvalue reference.
8442         * remote.c (remote_target::open_1): Use push_target overload.
8443         * corelow.c (core_target_open): Use push_target overload.
8444
8445 2019-02-15  Tom Tromey  <tromey@adacore.com>
8446
8447         * ravenscar-thread.c (is_ravenscar_task)
8448         (ravenscar_task_is_currently_active): Return bool.
8449         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8450         (_initialize_ravenscar): Remove "(void)".
8451         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8452         Return bool.
8453
8454 2019-02-15  Tom Tromey  <tromey@adacore.com>
8455
8456         * ravenscar-thread.c (ravenscar_runtime_initializer)
8457         (has_ravenscar_runtime, get_running_thread_id)
8458         (ravenscar_thread_target::resume): Fix indentation.
8459
8460 2019-02-15  Tom Tromey  <tromey@adacore.com>
8461
8462         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8463         from ravenscar_arch_ops.
8464         (sparc_ravenscar_ops::fetch_registers)
8465         (sparc_ravenscar_ops::store_registers): Now methods.
8466         (sparc_ravenscar_prepare_to_store): Remove.
8467         (sparc_ravenscar_ops): Redefine.
8468         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8469         methods and destructor.  Remove members.
8470         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8471         (ravenscar_thread_target::store_registers)
8472         (ravenscar_thread_target::prepare_to_store): Update.
8473         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8474         Remove.
8475         (struct ppc_ravenscar_powerpc_ops): Derive from
8476         ravenscar_arch_ops.
8477         (ppc_ravenscar_powerpc_ops::fetch_registers)
8478         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8479         (ppc_ravenscar_powerpc_ops): Redefine.
8480         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8481         (ppc_ravenscar_e500_ops::fetch_registers)
8482         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8483         (ppc_ravenscar_e500_ops): Redefine.
8484         * aarch64-ravenscar-thread.c
8485         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8486         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8487         (aarch64_ravenscar_fetch_registers)
8488         (aarch64_ravenscar_store_registers): Now methods.
8489         (aarch64_ravenscar_ops): Redefine.
8490
8491 2019-02-15  Tom Tromey  <tromey@adacore.com>
8492
8493         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8494         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8495         (ravenscar_thread_target::stopped_by_watchpoint)
8496         (ravenscar_thread_target::stopped_data_address)
8497         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8498
8499 2019-02-15  Tom Tromey  <tromey@adacore.com>
8500
8501         * ravenscar-thread.c: Fix some typos.
8502
8503 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8504             Tom Tromey  <tromey@adacore.com>
8505
8506         * ada-lang.c (ada_exception_sal): Change addr_string to a
8507         std::string.
8508         (create_ada_exception_catchpoint): Update.
8509
8510 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8511             Tom Tromey  <tromey@adacore.com>
8512
8513         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8514         (bp_location_ops): Remove.
8515         (base_breakpoint_allocate_location): Update.
8516         (free_bp_location): Update.
8517         * ada-lang.c (class ada_catchpoint_location)
8518         <ada_catchpoint_location>: Remove ops parameter.
8519         (ada_catchpoint_location_dtor): Remove.
8520         (ada_catchpoint_location_ops): Remove.
8521         (allocate_location_exception): Update.
8522         * breakpoint.h (struct bp_location_ops): Remove.
8523         (class bp_location) <bp_location>: Remove bp_location_ops
8524         parameter.
8525         <~bp_location>: Add destructor.
8526         <ops>: Remove.
8527
8528 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8529             Pedro Alves  <palves@redhat.com>
8530
8531         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8532         'PATH_MAX'.
8533
8534 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8535             Samuel Thibault  <samuel.thibault@gnu.org>
8536             Thomas Schwinge  <thomas@codesourcery.com>
8537
8538         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8539         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8540
8541 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8542
8543         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8544         (check_empty): Use "const char *".
8545
8546         * gnu-nat.c (gnu_nat_target::detach): Instead of
8547         'detach_inferior (pid)' call
8548         'detach_inferior (find_inferior_pid (pid))'.
8549
8550         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8551         'nat/fork-inferior.o'.
8552         * gnu-nat.c: #include "nat/fork-inferior.h".
8553
8554         * gnu-nat.c (gnu_nat_target::detach): Instead of
8555         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8556         * gnu-nat.h: #include "inf-child.h".
8557         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8558         'i386_gnu_nat_target::fetch_registers'.
8559         (gnu_store_registers): Rename/move to
8560         'i386_gnu_nat_target::store_registers'.
8561
8562         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8563         * gnu-nat.h (mach_thread_info): New function.
8564         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8565
8566         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8567
8568 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8569
8570         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8571
8572 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8573
8574         * windows-nat.c (windows_add_thread): Add new parameter
8575         "main_thread_p" with default value set to false.  Update
8576         function documentation as well as all callers.
8577         (windows_delete_thread): Likewise.
8578         (fake_create_process): Update call to windows_add_thread.
8579         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8580         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8581         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8582         call to windows_delete_thread.
8583
8584 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8585
8586         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8587
8588 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8589
8590         * symfile.c (find_separate_debug_file): Use canonical path of
8591         sysroot with child_path instead of gdb_sysroot if it is valid.
8592
8593 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8594
8595         * symfile.c (find_separate_debug_file): Use child_path to
8596         determine if an object file is under a sysroot.
8597
8598 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8599
8600         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8601         unittests/child-path-selftests.c.
8602         * common/pathstuff.c (child_path): New function.
8603         * common/pathstuff.h (child_path): New prototype.
8604         * unittests/child-path-selftests.c: New file.
8605
8606 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8607
8608         * symfile.c (find_separate_debug_file): Look for separate debug
8609         files in debug directories under the sysroot.
8610
8611 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8612
8613         * symtab.h (struct minimal_symbol data_p): New const method.
8614         (struct minimal_symbol text_p): Likewise.
8615         * symtab.c (output_source_filename): Use file name style
8616         to print file name.
8617         (print_symbol_info): Likewise.
8618         (print_msymbol_info): Use address style to print addresses.
8619         Use function name style to print executable text symbols.
8620         (expand_symtab_containing_pc): Use data_p.
8621         (find_pc_sect_compunit_symtab): Likewise.
8622
8623 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8624
8625         * breakpoint.c (describe_other_breakpoints): Use address style
8626         to print addresses.
8627         (say_where): Likewise.
8628
8629 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8630
8631         * ada-typeprint.c (print_func_type): Print function name
8632         style to print function name.
8633         * c-typeprint.c (c_print_type_1): Likewise.
8634
8635 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8636
8637         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8638         for execve.
8639
8640 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8641
8642         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8643         type_stack.
8644
8645 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8646
8647         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8648         TYPE_CODE_REF types.
8649
8650 2019-02-08  Jim Wilson  <jimw@sifive.com>
8651
8652         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8653         (riscv_linux_fregset): New.
8654         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8655
8656 2019-02-07  Tom Tromey  <tom@tromey.com>
8657
8658         * thread.c (thread_cancel_execution_command): Update.
8659         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8660         methods.
8661         (struct thread_fsm_ops): Remove.
8662         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8663         (thread_fsm_should_stop, thread_fsm_return_value)
8664         (thread_fsm_set_finished, thread_fsm_finished_p)
8665         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8666         Don't declare.
8667         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8668         * infrun.c (clear_proceed_status_thread)
8669         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8670         (print_stop_event): Update.
8671         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8672         Add constructor.
8673         (step_command_fsm_ops): Remove.
8674         (new_step_command_fsm): Remove.
8675         (step_1): Update.
8676         (step_command_fsm::should_stop): Rename from
8677         step_command_fsm_should_stop.
8678         (step_command_fsm::clean_up): Rename from
8679         step_command_fsm_clean_up.
8680         (step_command_fsm::do_async_reply_reason): Rename from
8681         step_command_fsm_async_reply_reason.
8682         (struct until_next_fsm): Inherit from thread_fsm.  Add
8683         constructor.
8684         (until_next_fsm_ops): Remove.
8685         (new_until_next_fsm): Remove.
8686         (until_next_fsm::should_stop): Rename from
8687         until_next_fsm_should_stop.
8688         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8689         (until_next_fsm::do_async_reply_reason): Rename from
8690         until_next_fsm_async_reply_reason.
8691         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8692         constructor.  Change type of breakpoint.
8693         (finish_command_fsm_ops): Remove.
8694         (new_finish_command_fsm): Remove.
8695         (finish_command_fsm::should_stop): Rename from
8696         finish_command_fsm_should_stop.
8697         (finish_command_fsm::clean_up): Rename from
8698         finish_command_fsm_clean_up.
8699         (finish_command_fsm::return_value): Rename from
8700         finish_command_fsm_return_value.
8701         (finish_command_fsm::do_async_reply_reason): Rename from
8702         finish_command_fsm_async_reply_reason.
8703         (finish_command): Update.
8704         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8705         Add constructor.
8706         (call_thread_fsm_ops): Remove.
8707         (call_thread_fsm::call_thread_fsm): Rename from
8708         new_call_thread_fsm.
8709         (call_thread_fsm::should_stop): Rename from
8710         call_thread_fsm_should_stop.
8711         (call_thread_fsm::should_notify_stop): Rename from
8712         call_thread_fsm_should_notify_stop.
8713         (run_inferior_call, call_function_by_hand_dummy): Update.
8714         * cli/cli-interp.c (should_print_stop_to_console): Update.
8715         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8716         Add constructor.  Change type of location_breakpoint,
8717         caller_breakpoint.
8718         (until_break_fsm_ops): Remove.
8719         (new_until_break_fsm): Remove.
8720         (until_break_fsm::should_stop): Rename from
8721         until_break_fsm_should_stop.
8722         (until_break_fsm::clean_up): Rename from
8723         until_break_fsm_clean_up.
8724         (until_break_fsm::do_async_reply_reason): Rename from
8725         until_break_fsm_async_reply_reason.
8726         (until_break_command): Update.
8727         * thread-fsm.c: Remove.
8728         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8729
8730 2019-02-07  Tom Tromey  <tom@tromey.com>
8731
8732         * yy-remap.h: Add include guard.
8733         * xtensa-tdep.h: Add include guard.
8734         * xcoffread.h: Rename include guard.
8735         * varobj-iter.h: Add include guard.
8736         * tui/tui.h: Rename include guard.
8737         * tui/tui-winsource.h: Rename include guard.
8738         * tui/tui-wingeneral.h: Rename include guard.
8739         * tui/tui-windata.h: Rename include guard.
8740         * tui/tui-win.h: Rename include guard.
8741         * tui/tui-stack.h: Rename include guard.
8742         * tui/tui-source.h: Rename include guard.
8743         * tui/tui-regs.h: Rename include guard.
8744         * tui/tui-out.h: Rename include guard.
8745         * tui/tui-layout.h: Rename include guard.
8746         * tui/tui-io.h: Rename include guard.
8747         * tui/tui-hooks.h: Rename include guard.
8748         * tui/tui-file.h: Rename include guard.
8749         * tui/tui-disasm.h: Rename include guard.
8750         * tui/tui-data.h: Rename include guard.
8751         * tui/tui-command.h: Rename include guard.
8752         * tic6x-tdep.h: Add include guard.
8753         * target/waitstatus.h: Rename include guard.
8754         * target/wait.h: Rename include guard.
8755         * target/target.h: Rename include guard.
8756         * target/resume.h: Rename include guard.
8757         * target-float.h: Rename include guard.
8758         * stabsread.h: Add include guard.
8759         * rs6000-tdep.h: Add include guard.
8760         * riscv-fbsd-tdep.h: Add include guard.
8761         * regformats/regdef.h: Rename include guard.
8762         * record.h: Rename include guard.
8763         * python/python.h: Rename include guard.
8764         * python/python-internal.h: Rename include guard.
8765         * python/py-stopevent.h: Rename include guard.
8766         * python/py-ref.h: Rename include guard.
8767         * python/py-record.h: Rename include guard.
8768         * python/py-record-full.h: Rename include guard.
8769         * python/py-record-btrace.h: Rename include guard.
8770         * python/py-instruction.h: Rename include guard.
8771         * python/py-events.h: Rename include guard.
8772         * python/py-event.h: Rename include guard.
8773         * procfs.h: Add include guard.
8774         * proc-utils.h: Add include guard.
8775         * p-lang.h: Add include guard.
8776         * or1k-tdep.h: Rename include guard.
8777         * observable.h: Rename include guard.
8778         * nto-tdep.h: Rename include guard.
8779         * nat/x86-linux.h: Rename include guard.
8780         * nat/x86-linux-dregs.h: Rename include guard.
8781         * nat/x86-gcc-cpuid.h: Add include guard.
8782         * nat/x86-dregs.h: Rename include guard.
8783         * nat/x86-cpuid.h: Rename include guard.
8784         * nat/ppc-linux.h: Rename include guard.
8785         * nat/mips-linux-watch.h: Rename include guard.
8786         * nat/linux-waitpid.h: Rename include guard.
8787         * nat/linux-ptrace.h: Rename include guard.
8788         * nat/linux-procfs.h: Rename include guard.
8789         * nat/linux-osdata.h: Rename include guard.
8790         * nat/linux-nat.h: Rename include guard.
8791         * nat/linux-namespaces.h: Rename include guard.
8792         * nat/linux-btrace.h: Rename include guard.
8793         * nat/glibc_thread_db.h: Rename include guard.
8794         * nat/gdb_thread_db.h: Rename include guard.
8795         * nat/gdb_ptrace.h: Rename include guard.
8796         * nat/fork-inferior.h: Rename include guard.
8797         * nat/amd64-linux-siginfo.h: Rename include guard.
8798         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8799         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8800         * nat/aarch64-linux.h: Rename include guard.
8801         * nat/aarch64-linux-hw-point.h: Rename include guard.
8802         * mn10300-tdep.h: Add include guard.
8803         * mips-linux-tdep.h: Add include guard.
8804         * mi/mi-parse.h: Rename include guard.
8805         * mi/mi-out.h: Rename include guard.
8806         * mi/mi-main.h: Rename include guard.
8807         * mi/mi-interp.h: Rename include guard.
8808         * mi/mi-getopt.h: Rename include guard.
8809         * mi/mi-console.h: Rename include guard.
8810         * mi/mi-common.h: Rename include guard.
8811         * mi/mi-cmds.h: Rename include guard.
8812         * mi/mi-cmd-break.h: Rename include guard.
8813         * m2-lang.h: Add include guard.
8814         * location.h: Rename include guard.
8815         * linux-record.h: Rename include guard.
8816         * linux-nat.h: Add include guard.
8817         * linux-fork.h: Add include guard.
8818         * i386-darwin-tdep.h: Rename include guard.
8819         * hppa-linux-offsets.h: Add include guard.
8820         * guile/guile.h: Rename include guard.
8821         * guile/guile-internal.h: Rename include guard.
8822         * gnu-nat.h: Rename include guard.
8823         * gdb-stabs.h: Rename include guard.
8824         * frv-tdep.h: Add include guard.
8825         * f-lang.h: Add include guard.
8826         * event-loop.h: Add include guard.
8827         * darwin-nat.h: Rename include guard.
8828         * cp-abi.h: Rename include guard.
8829         * config/sparc/nm-sol2.h: Rename include guard.
8830         * config/nm-nto.h: Rename include guard.
8831         * config/nm-linux.h: Add include guard.
8832         * config/i386/nm-i386gnu.h: Rename include guard.
8833         * config/djgpp/nl_types.h: Rename include guard.
8834         * config/djgpp/langinfo.h: Rename include guard.
8835         * compile/gcc-cp-plugin.h: Add include guard.
8836         * compile/gcc-c-plugin.h: Add include guard.
8837         * compile/compile.h: Rename include guard.
8838         * compile/compile-object-run.h: Rename include guard.
8839         * compile/compile-object-load.h: Rename include guard.
8840         * compile/compile-internal.h: Rename include guard.
8841         * compile/compile-cplus.h: Rename include guard.
8842         * compile/compile-c.h: Rename include guard.
8843         * common/xml-utils.h: Rename include guard.
8844         * common/x86-xstate.h: Rename include guard.
8845         * common/version.h: Rename include guard.
8846         * common/vec.h: Rename include guard.
8847         * common/tdesc.h: Rename include guard.
8848         * common/selftest.h: Rename include guard.
8849         * common/scoped_restore.h: Rename include guard.
8850         * common/scoped_mmap.h: Rename include guard.
8851         * common/scoped_fd.h: Rename include guard.
8852         * common/safe-iterator.h: Rename include guard.
8853         * common/run-time-clock.h: Rename include guard.
8854         * common/refcounted-object.h: Rename include guard.
8855         * common/queue.h: Rename include guard.
8856         * common/ptid.h: Rename include guard.
8857         * common/print-utils.h: Rename include guard.
8858         * common/preprocessor.h: Rename include guard.
8859         * common/pathstuff.h: Rename include guard.
8860         * common/observable.h: Rename include guard.
8861         * common/netstuff.h: Rename include guard.
8862         * common/job-control.h: Rename include guard.
8863         * common/host-defs.h: Rename include guard.
8864         * common/gdb_wait.h: Rename include guard.
8865         * common/gdb_vecs.h: Rename include guard.
8866         * common/gdb_unlinker.h: Rename include guard.
8867         * common/gdb_unique_ptr.h: Rename include guard.
8868         * common/gdb_tilde_expand.h: Rename include guard.
8869         * common/gdb_sys_time.h: Rename include guard.
8870         * common/gdb_string_view.h: Rename include guard.
8871         * common/gdb_splay_tree.h: Rename include guard.
8872         * common/gdb_setjmp.h: Rename include guard.
8873         * common/gdb_ref_ptr.h: Rename include guard.
8874         * common/gdb_optional.h: Rename include guard.
8875         * common/gdb_locale.h: Rename include guard.
8876         * common/gdb_assert.h: Rename include guard.
8877         * common/filtered-iterator.h: Rename include guard.
8878         * common/filestuff.h: Rename include guard.
8879         * common/fileio.h: Rename include guard.
8880         * common/environ.h: Rename include guard.
8881         * common/common-utils.h: Rename include guard.
8882         * common/common-types.h: Rename include guard.
8883         * common/common-regcache.h: Rename include guard.
8884         * common/common-inferior.h: Rename include guard.
8885         * common/common-gdbthread.h: Rename include guard.
8886         * common/common-exceptions.h: Rename include guard.
8887         * common/common-defs.h: Rename include guard.
8888         * common/common-debug.h: Rename include guard.
8889         * common/cleanups.h: Rename include guard.
8890         * common/buffer.h: Rename include guard.
8891         * common/btrace-common.h: Rename include guard.
8892         * common/break-common.h: Rename include guard.
8893         * cli/cli-utils.h: Rename include guard.
8894         * cli/cli-style.h: Rename include guard.
8895         * cli/cli-setshow.h: Rename include guard.
8896         * cli/cli-script.h: Rename include guard.
8897         * cli/cli-interp.h: Rename include guard.
8898         * cli/cli-decode.h: Rename include guard.
8899         * cli/cli-cmds.h: Rename include guard.
8900         * charset-list.h: Add include guard.
8901         * buildsym-legacy.h: Rename include guard.
8902         * bfin-tdep.h: Add include guard.
8903         * ax.h: Rename include guard.
8904         * arm-linux-tdep.h: Add include guard.
8905         * arm-fbsd-tdep.h: Add include guard.
8906         * arch/xtensa.h: Rename include guard.
8907         * arch/tic6x.h: Add include guard.
8908         * arch/i386.h: Add include guard.
8909         * arch/arm.h: Rename include guard.
8910         * arch/arm-linux.h: Rename include guard.
8911         * arch/arm-get-next-pcs.h: Rename include guard.
8912         * arch/amd64.h: Add include guard.
8913         * arch/aarch64-insn.h: Rename include guard.
8914         * arch-utils.h: Rename include guard.
8915         * annotate.h: Add include guard.
8916         * amd64-darwin-tdep.h: Rename include guard.
8917         * aarch64-linux-tdep.h: Add include guard.
8918         * aarch64-fbsd-tdep.h: Add include guard.
8919         * aarch32-linux-nat.h: Add include guard.
8920
8921 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8922
8923         * macrotab.c (macro_define_internal): New function that
8924         factorizes macro_define_object_internal and macro_define_function
8925         code.
8926         (macro_define_object_internal): Use macro_define_internal.
8927         (macro_define_function): Likewise.
8928
8929 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8930
8931         * macrocmd.c (extract_identifier): Return
8932         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8933         callers.
8934
8935 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8936
8937         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8938
8939 2019-02-05  Tom Tromey  <tom@tromey.com>
8940
8941         * target.c (target_stack::unpush): Move assertion earlier.
8942
8943 2019-01-30  Tom Tromey  <tom@tromey.com>
8944
8945         PR python/23615:
8946         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8947         (gdbpy_parse_and_eval): Likewise.
8948         * python/python-internal.h (gdbpy_allow_threads): New class.
8949
8950 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8951
8952         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8953         (aarch64_fbsd_fpregmap): Move earlier.
8954         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8955         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8956         instead of individual calls to trad_frame_set_reg_addr.
8957         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8958         earlier.
8959         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8960         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8961         instead of individual calls to trad_frame_set_reg_addr.
8962
8963 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8964
8965         * CONTRIBUTE: Replace contribution list with wiki link.
8966
8967 2019-01-25  Tom Tromey  <tom@tromey.com>
8968
8969         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8970
8971 2019-01-25  Tom Tromey  <tom@tromey.com>
8972
8973         * xtensa-linux-nat.c: Fix common/ includes.
8974         * xml-support.h: Fix common/ includes.
8975         * xml-support.c: Fix common/ includes.
8976         * x86-linux-nat.c: Fix common/ includes.
8977         * windows-nat.c: Fix common/ includes.
8978         * varobj.h: Fix common/ includes.
8979         * varobj.c: Fix common/ includes.
8980         * value.c: Fix common/ includes.
8981         * valops.c: Fix common/ includes.
8982         * utils.c: Fix common/ includes.
8983         * unittests/xml-utils-selftests.c: Fix common/ includes.
8984         * unittests/utils-selftests.c: Fix common/ includes.
8985         * unittests/unpack-selftests.c: Fix common/ includes.
8986         * unittests/tracepoint-selftests.c: Fix common/ includes.
8987         * unittests/style-selftests.c: Fix common/ includes.
8988         * unittests/string_view-selftests.c: Fix common/ includes.
8989         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8990         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8991         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8992         * unittests/rsp-low-selftests.c: Fix common/ includes.
8993         * unittests/parse-connection-spec-selftests.c: Fix common/
8994         includes.
8995         * unittests/optional-selftests.c: Fix common/ includes.
8996         * unittests/offset-type-selftests.c: Fix common/ includes.
8997         * unittests/observable-selftests.c: Fix common/ includes.
8998         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8999         * unittests/memrange-selftests.c: Fix common/ includes.
9000         * unittests/memory-map-selftests.c: Fix common/ includes.
9001         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9002         * unittests/function-view-selftests.c: Fix common/ includes.
9003         * unittests/environ-selftests.c: Fix common/ includes.
9004         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9005         * unittests/common-utils-selftests.c: Fix common/ includes.
9006         * unittests/cli-utils-selftests.c: Fix common/ includes.
9007         * unittests/array-view-selftests.c: Fix common/ includes.
9008         * ui-file.c: Fix common/ includes.
9009         * tui/tui-io.c: Fix common/ includes.
9010         * tracepoint.h: Fix common/ includes.
9011         * tracepoint.c: Fix common/ includes.
9012         * tracefile-tfile.c: Fix common/ includes.
9013         * top.h: Fix common/ includes.
9014         * top.c: Fix common/ includes.
9015         * thread.c: Fix common/ includes.
9016         * target/waitstatus.h: Fix common/ includes.
9017         * target/waitstatus.c: Fix common/ includes.
9018         * target.h: Fix common/ includes.
9019         * target.c: Fix common/ includes.
9020         * target-memory.c: Fix common/ includes.
9021         * target-descriptions.c: Fix common/ includes.
9022         * symtab.h: Fix common/ includes.
9023         * symfile.c: Fix common/ includes.
9024         * stap-probe.c: Fix common/ includes.
9025         * spu-linux-nat.c: Fix common/ includes.
9026         * sparc-nat.c: Fix common/ includes.
9027         * source.c: Fix common/ includes.
9028         * solib.c: Fix common/ includes.
9029         * solib-target.c: Fix common/ includes.
9030         * ser-unix.c: Fix common/ includes.
9031         * ser-tcp.c: Fix common/ includes.
9032         * ser-pipe.c: Fix common/ includes.
9033         * ser-base.c: Fix common/ includes.
9034         * selftest-arch.c: Fix common/ includes.
9035         * s12z-tdep.c: Fix common/ includes.
9036         * rust-exp.y: Fix common/ includes.
9037         * rs6000-aix-tdep.c: Fix common/ includes.
9038         * riscv-tdep.c: Fix common/ includes.
9039         * remote.c: Fix common/ includes.
9040         * remote-notif.h: Fix common/ includes.
9041         * remote-fileio.h: Fix common/ includes.
9042         * remote-fileio.c: Fix common/ includes.
9043         * regcache.h: Fix common/ includes.
9044         * regcache.c: Fix common/ includes.
9045         * record-btrace.c: Fix common/ includes.
9046         * python/python.c: Fix common/ includes.
9047         * python/py-type.c: Fix common/ includes.
9048         * python/py-inferior.c: Fix common/ includes.
9049         * progspace.h: Fix common/ includes.
9050         * producer.c: Fix common/ includes.
9051         * procfs.c: Fix common/ includes.
9052         * proc-api.c: Fix common/ includes.
9053         * printcmd.c: Fix common/ includes.
9054         * ppc-linux-nat.c: Fix common/ includes.
9055         * parser-defs.h: Fix common/ includes.
9056         * osdata.c: Fix common/ includes.
9057         * obsd-nat.c: Fix common/ includes.
9058         * nat/x86-linux.c: Fix common/ includes.
9059         * nat/x86-linux-dregs.c: Fix common/ includes.
9060         * nat/x86-dregs.h: Fix common/ includes.
9061         * nat/x86-dregs.c: Fix common/ includes.
9062         * nat/ppc-linux.c: Fix common/ includes.
9063         * nat/mips-linux-watch.h: Fix common/ includes.
9064         * nat/mips-linux-watch.c: Fix common/ includes.
9065         * nat/linux-waitpid.c: Fix common/ includes.
9066         * nat/linux-ptrace.h: Fix common/ includes.
9067         * nat/linux-ptrace.c: Fix common/ includes.
9068         * nat/linux-procfs.c: Fix common/ includes.
9069         * nat/linux-personality.c: Fix common/ includes.
9070         * nat/linux-osdata.c: Fix common/ includes.
9071         * nat/linux-namespaces.c: Fix common/ includes.
9072         * nat/linux-btrace.h: Fix common/ includes.
9073         * nat/linux-btrace.c: Fix common/ includes.
9074         * nat/fork-inferior.c: Fix common/ includes.
9075         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9076         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9077         * nat/aarch64-linux.c: Fix common/ includes.
9078         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9079         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9080         * namespace.h: Fix common/ includes.
9081         * mips-linux-tdep.c: Fix common/ includes.
9082         * minsyms.c: Fix common/ includes.
9083         * mi/mi-parse.h: Fix common/ includes.
9084         * mi/mi-main.c: Fix common/ includes.
9085         * mi/mi-cmd-env.c: Fix common/ includes.
9086         * memrange.h: Fix common/ includes.
9087         * memattr.c: Fix common/ includes.
9088         * maint.h: Fix common/ includes.
9089         * maint.c: Fix common/ includes.
9090         * main.c: Fix common/ includes.
9091         * machoread.c: Fix common/ includes.
9092         * location.c: Fix common/ includes.
9093         * linux-thread-db.c: Fix common/ includes.
9094         * linux-nat.c: Fix common/ includes.
9095         * linux-fork.c: Fix common/ includes.
9096         * inline-frame.c: Fix common/ includes.
9097         * infrun.c: Fix common/ includes.
9098         * inflow.c: Fix common/ includes.
9099         * inferior.h: Fix common/ includes.
9100         * inferior.c: Fix common/ includes.
9101         * infcmd.c: Fix common/ includes.
9102         * inf-ptrace.c: Fix common/ includes.
9103         * inf-child.c: Fix common/ includes.
9104         * ia64-linux-nat.c: Fix common/ includes.
9105         * i387-tdep.c: Fix common/ includes.
9106         * i386-tdep.c: Fix common/ includes.
9107         * i386-linux-tdep.c: Fix common/ includes.
9108         * i386-linux-nat.c: Fix common/ includes.
9109         * i386-go32-tdep.c: Fix common/ includes.
9110         * i386-fbsd-tdep.c: Fix common/ includes.
9111         * i386-fbsd-nat.c: Fix common/ includes.
9112         * guile/scm-type.c: Fix common/ includes.
9113         * guile/guile.c: Fix common/ includes.
9114         * go32-nat.c: Fix common/ includes.
9115         * gnu-nat.c: Fix common/ includes.
9116         * gdbthread.h: Fix common/ includes.
9117         * gdbarch-selftests.c: Fix common/ includes.
9118         * gdb_usleep.c: Fix common/ includes.
9119         * gdb_select.h: Fix common/ includes.
9120         * gdb_bfd.c: Fix common/ includes.
9121         * gcore.c: Fix common/ includes.
9122         * fork-child.c: Fix common/ includes.
9123         * findvar.c: Fix common/ includes.
9124         * fbsd-nat.c: Fix common/ includes.
9125         * event-top.c: Fix common/ includes.
9126         * event-loop.c: Fix common/ includes.
9127         * dwarf2read.c: Fix common/ includes.
9128         * dwarf2loc.c: Fix common/ includes.
9129         * dwarf2-frame.c: Fix common/ includes.
9130         * dwarf-index-cache.c: Fix common/ includes.
9131         * dtrace-probe.c: Fix common/ includes.
9132         * disasm-selftests.c: Fix common/ includes.
9133         * defs.h: Fix common/ includes.
9134         * csky-tdep.c: Fix common/ includes.
9135         * cp-valprint.c: Fix common/ includes.
9136         * cp-support.h: Fix common/ includes.
9137         * cp-support.c: Fix common/ includes.
9138         * corelow.c: Fix common/ includes.
9139         * completer.h: Fix common/ includes.
9140         * completer.c: Fix common/ includes.
9141         * compile/compile.c: Fix common/ includes.
9142         * compile/compile-loc2c.c: Fix common/ includes.
9143         * compile/compile-cplus-types.c: Fix common/ includes.
9144         * compile/compile-cplus-symbols.c: Fix common/ includes.
9145         * command.h: Fix common/ includes.
9146         * cli/cli-dump.c: Fix common/ includes.
9147         * cli/cli-cmds.c: Fix common/ includes.
9148         * charset.c: Fix common/ includes.
9149         * build-id.c: Fix common/ includes.
9150         * btrace.h: Fix common/ includes.
9151         * btrace.c: Fix common/ includes.
9152         * breakpoint.h: Fix common/ includes.
9153         * breakpoint.c: Fix common/ includes.
9154         * ax.h:
9155         (enum agent_op): Fix common/ includes.
9156         * ax-general.c (struct aop_map): Fix common/ includes.
9157         * ax-gdb.c: Fix common/ includes.
9158         * auxv.c: Fix common/ includes.
9159         * auto-load.c: Fix common/ includes.
9160         * arm-tdep.c: Fix common/ includes.
9161         * arch/riscv.c: Fix common/ includes.
9162         * arch/ppc-linux-common.c: Fix common/ includes.
9163         * arch/i386.c: Fix common/ includes.
9164         * arch/arm.c: Fix common/ includes.
9165         * arch/arm-linux.c: Fix common/ includes.
9166         * arch/arm-get-next-pcs.c: Fix common/ includes.
9167         * arch/amd64.c: Fix common/ includes.
9168         * arch/aarch64.c: Fix common/ includes.
9169         * arch/aarch64-insn.c: Fix common/ includes.
9170         * arch-utils.c: Fix common/ includes.
9171         * amd64-windows-tdep.c: Fix common/ includes.
9172         * amd64-tdep.c: Fix common/ includes.
9173         * amd64-sol2-tdep.c: Fix common/ includes.
9174         * amd64-obsd-tdep.c: Fix common/ includes.
9175         * amd64-nbsd-tdep.c: Fix common/ includes.
9176         * amd64-linux-tdep.c: Fix common/ includes.
9177         * amd64-linux-nat.c: Fix common/ includes.
9178         * amd64-fbsd-tdep.c: Fix common/ includes.
9179         * amd64-fbsd-nat.c: Fix common/ includes.
9180         * amd64-dicos-tdep.c: Fix common/ includes.
9181         * amd64-darwin-tdep.c: Fix common/ includes.
9182         * agent.c: Fix common/ includes.
9183         * ada-lang.h: Fix common/ includes.
9184         * ada-lang.c: Fix common/ includes.
9185         * aarch64-tdep.c: Fix common/ includes.
9186
9187 2019-01-25  Tom Tromey  <tom@tromey.com>
9188
9189         * common/create-version.sh: Use common/version.h.
9190
9191 2019-01-24  Pedro Alves  <palves@redhat.com>
9192
9193         * infrun.c (signal_stop, signal_print, signal_program)
9194         (signal_catch, signal_pass): Now arrays instead of pointers.
9195         (update_signals_program_target, do_target_resume)
9196         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9197         * linux-nat.c (linux_nat_target::pass_signals)
9198         (linux_nat_target::create_inferior, linux_nat_target::attach):
9199         Adjust.
9200         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9201         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9202         * procfs.c (procfs_target::pass_signals): Adjust.
9203         * record-full.c (record_full_target::resume): Adjust.
9204         * remote.c (remote_target::pass_signals)
9205         (remote_target::program_signals): Adjust.
9206         * target-debug.h (target_debug_print_signals): Now takes a
9207         gdb::array_view as parameter.  Adjust.
9208         * target.h (target_ops) <pass_signals, program_signals>: Replace
9209         pointer and length parameters with gdb::array_view.
9210         (target_pass_signals, target_program_signals): Likewise.
9211         * target-delegates.c: Regenerate.
9212
9213 2019-01-24  Pedro Alves  <palves@redhat.com>
9214
9215         * common/forward-scope-exit.h
9216         (forward_scope_exit::forward_scope_exit): Pass arguments to
9217         m_bind_function directly, instead of creating a std::bind and
9218         copying that.
9219
9220 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9221
9222         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9223         for static members.
9224         (pass_in_v_vfp_candidate): Likewise.
9225
9226 2019-01-23  Tom Tromey  <tom@tromey.com>
9227             Pedro Alves  <palves@redhat.com>
9228
9229         * regcache.c (class regcache_invalidator): Remove.
9230         (regcache::raw_write): Use make_scope_exit.
9231
9232 2019-01-23  Tom Tromey  <tom@tromey.com>
9233
9234         * ui-out.h (class ui_out_emit_type): Update comment.
9235
9236 2019-01-23  Tom Tromey  <tom@tromey.com>
9237
9238         * infrun.c (fetch_inferior_event): Update comment.
9239
9240 2019-01-23  Tom Tromey  <tom@tromey.com>
9241             Pedro Alves  <palves@redhat.com>
9242
9243         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9244         parameter.
9245         (fetch_inferior_event): Use SCOPE_EXIT.
9246
9247
9248 2019-01-23  Tom Tromey  <tom@tromey.com>
9249             Pedro Alves  <palves@redhat.com>
9250
9251         * infrun.c (disable_thread_events): Delete.
9252         (stop_all_threads): Use SCOPE_EXIT.
9253
9254 2019-01-23  Tom Tromey  <tom@tromey.com>
9255             Pedro Alves  <palves@redhat.com>
9256
9257         * symfile.c: Include forward-scope-exit.h.
9258         (clear_symtab_users_cleanup): Replace forward declaration with
9259         a FORWARD_SCOPE_EXIT.
9260         (syms_from_objfile_1): Use the forward_scope_exit and
9261         gdb::optional instead of cleanup_function.
9262         (reread_symbols): Use the forward_scope_exit instead of
9263         cleanup_function.
9264         (clear_symtab_users_cleanup): Remove function.
9265
9266 2019-01-23  Tom Tromey  <tom@tromey.com>
9267             Pedro Alves  <palves@redhat.com>
9268
9269         * linux-nat.c: Include scope-exit.h.
9270         (cleanup_target_stop): Remove.
9271         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9272         SCOPE_EXIT.
9273
9274 2019-01-23  Tom Tromey  <tom@tromey.com>
9275             Pedro Alves  <palves@redhat.com>
9276
9277         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9278         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9279
9280 2019-01-23  Tom Tromey  <tom@tromey.com>
9281             Andrew Burgess  <andrew.burgess@embecosm.com>
9282             Pedro Alves  <palves@redhat.com>
9283
9284         * infrun.c (fetch_inferior_event): Use scope_exit.
9285         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9286         * top.c (execute_command): Use scope_exit.
9287         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9288         * utils.c (do_bpstat_clear_actions_cleanup)
9289         (make_bpstat_clear_actions_cleanup): Remove.
9290
9291 2019-01-23  Tom Tromey  <tom@tromey.com>
9292             Pedro Alves  <palves@redhat.com>
9293
9294         * infrun.c: Include "common/scope-exit.h"
9295         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9296         (wait_for_inferior): Use SCOPE_EXIT.
9297         (fetch_inferior_event): Use scope_exit.
9298
9299 2019-01-23  Tom Tromey  <tom@tromey.com>
9300             Pedro Alves  <palves@redhat.com>
9301
9302         * breakpoint.c (create_breakpoint): Remove cleanup.
9303
9304 2019-01-23  Tom Tromey  <tom@tromey.com>
9305             Andrew Burgess  <andrew.burgess@embecosm.com>
9306             Pedro Alves  <palves@redhat.com>
9307
9308 2019-01-23  Pedro Alves  <palves@redhat.com>
9309
9310         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9311
9312 2019-01-23  Pedro Alves  <palves@redhat.com>
9313             Andrew Burgess  <andrew.burgess@embecosm.com>
9314
9315         * gdbthread.h: Include "common/forward-scope-exit.h".
9316         (scoped_finish_thread_state): Redefine custom class in terms of
9317         forward_scope_exit.
9318
9319 2019-01-23  Pedro Alves  <palves@redhat.com>
9320             Andrew Burgess  <andrew.burgess@embecosm.com>
9321
9322         * common/forward-scope-exit.h: New file.
9323
9324 2019-01-23  Pedro Alves  <palves@redhat.com>
9325             Andrew Burgess  <andrew.burgess@embecosm.com>
9326             Tom Tromey  <tom@tromey.com>
9327
9328         * common/scope-exit.h: New file.
9329
9330 2019-01-23  Pedro Alves  <palves@redhat.com>
9331
9332         * common/preprocessor.h (ESC): Rename to ...
9333         (ESC_PARENS): ... this.
9334         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9335         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9336
9337 2019-01-23  Tom Tromey  <tom@tromey.com>
9338
9339         * language.h (class scoped_switch_to_sym_language_if_auto):
9340         Initialize m_lang in both cases.
9341
9342 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9343
9344         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9345         with XCNEW.
9346
9347 2019-01-22  Tom Tromey  <tom@tromey.com>
9348
9349         * corelow.c: Do not include sys/file.h.
9350
9351 2019-01-22  Tom Tromey  <tom@tromey.com>
9352
9353         * tui/tui-wingeneral.h: Include gdb_curses.h.
9354
9355 2019-01-22  Tom Tromey  <tom@tromey.com>
9356
9357         * source-cache.h (class source_cache) <get_source_lines,
9358         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9359
9360 2019-01-22  Tom Tromey  <tom@tromey.com>
9361
9362         * remote-fileio.h (struct remote_target): Declare.
9363
9364 2019-01-22  Tom Tromey  <tom@tromey.com>
9365
9366         * python/py-arch.c: Do not include py-ref.h.
9367         * python/py-bpevent.c: Do not include py-ref.h.
9368         * python/py-cmd.c: Do not include py-ref.h.
9369         * python/py-continueevent.c: Do not include py-ref.h.
9370         * python/py-event.h: Do not include py-ref.h.
9371         * python/py-evtregistry.c: Do not include py-ref.h.
9372         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9373         * python/py-frame.c: Do not include py-ref.h.
9374         * python/py-framefilter.c: Do not include py-ref.h.
9375         * python/py-function.c: Do not include py-ref.h.
9376         * python/py-infevents.c: Do not include py-ref.h.
9377         * python/py-linetable.c: Do not include py-ref.h.
9378         * python/py-objfile.c: Do not include py-ref.h.
9379         * python/py-param.c: Do not include py-ref.h.
9380         * python/py-prettyprint.c: Do not include py-ref.h.
9381         * python/py-progspace.c: Do not include py-ref.h.
9382         * python/py-symbol.c: Do not include py-ref.h.
9383         * python/py-symtab.c: Do not include py-ref.h.
9384         * python/py-type.c: Do not include py-ref.h.
9385         * python/py-unwind.c: Do not include py-ref.h.
9386         * python/py-utils.c: Do not include py-ref.h.
9387         * python/py-value.c: Do not include py-ref.h.
9388         * python/py-varobj.c: Do not include py-ref.h.
9389         * python/py-xmethods.c: Do not include py-ref.h.
9390         * python/python.c: Do not include py-ref.h.
9391         * varobj.c: Do not include py-ref.h.
9392
9393 2019-01-22  Tom Tromey  <tom@tromey.com>
9394
9395         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9396         keyword for bcache.
9397
9398 2019-01-22  Tom Tromey  <tom@tromey.com>
9399
9400         * compile/compile-cplus-types.c: Remove a comment by #include.
9401
9402 2019-01-22  Tom Tromey  <tom@tromey.com>
9403
9404         * compile/gcc-c-plugin.h: Include compile-internal.h.
9405
9406 2019-01-22  Tom Tromey  <tom@tromey.com>
9407
9408         * stabsread.c (EXTERN): Do not define.
9409         (symnum, next_symbol_text_func, processing_gcc_compilation)
9410         (within_function, global_sym_chain, global_stabs)
9411         (previous_stab_code, this_object_header_files)
9412         (n_this_object_header_files)
9413         (n_allocated_this_object_header_files): Define.
9414         * stabsread.h (EXTERN): Never define.  Use "extern".
9415
9416 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9417
9418         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9419         history_value.
9420
9421 2019-01-21  Tom Tromey  <tom@tromey.com>
9422
9423         * ui-out.c: Fix includes.
9424         * tui/tui-source.c: Fix includes.
9425         * target.c: Fix includes.
9426         * remote.c: Fix includes.
9427         * regcache.c: Fix includes.
9428         * python/py-block.c: Fix includes.
9429         * printcmd.c: Fix includes.
9430         * or1k-tdep.c: Fix includes.
9431         * mi/mi-main.c: Fix includes.
9432         * m32r-tdep.c: Fix includes.
9433         * csky-tdep.c: Fix includes.
9434         * compile/compile-cplus-types.c: Fix includes.
9435         * cli/cli-interp.c: Fix includes.
9436
9437 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9438
9439         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9440         for padding.
9441
9442 2019-01-16  Tom Tromey  <tom@tromey.com>
9443
9444         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9445         earlier.
9446         (struct objfile) <msymbols_range>: Move from top level.
9447         <msymbols>: New method.
9448         (class objfile_msymbols): Remove.
9449         * symtab.c (default_collect_symbol_completion_matches_break_on):
9450         Update.
9451         * symmisc.c (dump_msymbols): Update.
9452         * stabsread.c (scan_file_globals): Update.
9453         * objc-lang.c (info_selectors_command, info_classes_command)
9454         (find_methods): Update.
9455         * minsyms.c (find_solib_trampoline_target): Update.
9456         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9457         * coffread.c (coff_symfile_read): Update.
9458         * ada-lang.c (ada_lookup_simple_minsym)
9459         (ada_collect_symbol_completion_matches): Update.
9460
9461 2019-01-16  Tom Tromey  <tom@tromey.com>
9462
9463         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9464         type.  Remove no-argument constructor.
9465         <iterator::operator++>: Simplify.
9466         <begin>: Update.
9467         <end>: Use minimal_symbol_count.
9468
9469 2019-01-16  Tom Tromey  <tom@tromey.com>
9470
9471         * objfiles.h (struct objfile) <psymtabs>: New method.
9472         (class objfile_psymtabs): Remove.
9473         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9474         typedef.
9475         <range>: New method.
9476         (require_partial_symbols): Change return type.
9477         * psymtab.c (require_partial_symbols)
9478         (psym_expand_symtabs_matching): Update.
9479         * mdebugread.c (parse_partial_symbols): Update.
9480         * dbxread.c (dbx_end_psymtab): Update.
9481
9482 2019-01-15  Tom Tromey  <tom@tromey.com>
9483
9484         * symtab.c (lookup_objfile_from_block)
9485         (lookup_symbol_in_objfile_symtabs)
9486         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9487         (find_line_symtab, info_sources_command)
9488         (default_collect_symbol_completion_matches_break_on)
9489         (make_source_files_completion_list): Update.
9490         * symmisc.c (print_objfile_statistics, dump_objfile)
9491         (maintenance_print_symbols, maintenance_info_symtabs)
9492         (maintenance_check_symtabs, maintenance_info_line_tables):
9493         Update.
9494         * source.c (select_source_symtab)
9495         (forget_cached_source_info_for_objfile): Update.
9496         * objfiles.h (class objfile_compunits): Remove.
9497         (struct objfile) <compunits_range>: New typedef.
9498         (compunits): New method.
9499         * objfiles.c (objfile_relocate1): Update.
9500         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9501         * maint.c (count_symtabs_and_blocks): Update.
9502         * linespec.c (iterate_over_all_matching_symtabs): Update.
9503         * cp-support.c (add_symbol_overload_list_qualified): Update.
9504         * coffread.c (coff_symtab_read): Update.
9505         * ada-lang.c (add_nonlocal_symbols)
9506         (ada_collect_symbol_completion_matches)
9507         (ada_add_global_exceptions): Update.
9508
9509 2019-01-15  Tom Tromey  <tom@tromey.com>
9510
9511         * progspace.h (program_space) <objfiles_safe_range>: New
9512         typedef.
9513         <objfiles_safe>: New method.
9514         * objfiles.h (class all_objfiles_safe): Remove.
9515         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9516         * jit.c (jit_inferior_exit_hook): Update.
9517
9518 2019-01-17  Tom Tromey  <tom@tromey.com>
9519
9520         * progspace.h (program_space) <objfiles_range>: New typedef.
9521         <objfiles>: New method.
9522         <objfiles_head>: Rename from objfiles.
9523         (object_files): Update.
9524         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9525         * guile/scm-pretty-print.c
9526         (ppscm_find_pretty_printer_from_objfiles): Update.
9527         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9528         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9529         Update.
9530         * python/py-progspace.c (pspy_get_objfiles): Update.
9531         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9532         Update.
9533         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9534         (objfpy_lookup_objfile_by_build_id): Update.
9535         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9536         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9537         Update.
9538         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9539         (expand_symtab_containing_pc, lookup_objfile_from_block)
9540         (lookup_static_symbol, basic_lookup_transparent_type)
9541         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9542         (find_line_symtab, info_sources_command)
9543         (default_collect_symbol_completion_matches_break_on)
9544         (make_source_files_completion_list, find_main_name): Update.
9545         * symmisc.c (print_symbol_bcache_statistics)
9546         (print_objfile_statistics, maintenance_print_symbols)
9547         (maintenance_print_msymbols, maintenance_print_objfiles)
9548         (maintenance_info_symtabs, maintenance_check_symtabs)
9549         (maintenance_expand_symtabs, maintenance_info_line_tables):
9550         Update.
9551         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9552         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9553         (map_overlay_command, unmap_overlay_command)
9554         (simple_overlay_update, expand_symtabs_matching)
9555         (map_symbol_filenames): Update.
9556         * symfile-debug.c (set_debug_symfile): Update.
9557         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9558         Update.
9559         * source.c (select_source_symtab, forget_cached_source_info):
9560         Update.
9561         * solib.c (solib_read_symbols): Update.
9562         * solib-spu.c (append_ocl_sos): Update.
9563         * psymtab.c (maintenance_print_psymbols)
9564         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9565         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9566         * printcmd.c (info_symbol_command): Update.
9567         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9568         Update.
9569         * objfiles.h (class all_objfiles): Remove.
9570         * objfiles.c (have_partial_symbols, have_full_symbols)
9571         (have_minimal_symbols, qsort_cmp, update_section_map)
9572         (shared_objfile_contains_address_p)
9573         (default_iterate_over_objfiles_in_search_order): Update.
9574         * objc-lang.c (info_selectors_command, info_classes_command)
9575         (find_methods): Update.
9576         * minsyms.c (find_solib_trampoline_target): Update.
9577         * maint.c (maintenance_info_sections)
9578         (maintenance_translate_address, count_symtabs_and_blocks):
9579         Update.
9580         * main.c (captured_main_1): Update.
9581         * linux-thread-db.c (try_thread_db_load_from_pdir)
9582         (has_libpthread): Update.
9583         * linespec.c (iterate_over_all_matching_symtabs)
9584         (search_minsyms_for_name): Update.
9585         * jit.c (jit_find_objf_with_entry_addr): Update.
9586         * hppa-tdep.c (find_unwind_entry)
9587         (hppa_lookup_stub_minimal_symbol): Update.
9588         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9589         Update.
9590         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9591         (elf_gnu_ifunc_resolve_by_got): Update.
9592         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9593         * dwarf-index-write.c (save_gdb_index_command): Update.
9594         * cp-support.c (add_symbol_overload_list_qualified): Update.
9595         * breakpoint.c (create_overlay_event_breakpoint)
9596         (create_longjmp_master_breakpoint)
9597         (create_std_terminate_master_breakpoint)
9598         (create_exception_master_breakpoint): Update.
9599         * blockframe.c (find_pc_partial_function): Update.
9600         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9601         (ada_collect_symbol_completion_matches)
9602         (ada_add_global_exceptions): Update.
9603
9604 2019-01-17  Tom Tromey  <tom@tromey.com>
9605
9606         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9607         declare VEC.
9608         (solib_target_parse_libraries): Change return type.
9609         (library_list_start_segment, library_list_start_section)
9610         (library_list_end_library, library_list_start_library); Update.
9611         (solib_target_free_library_list): Remove.
9612         (solib_target_parse_libraries): Remove cleanup.  Change return
9613         type.
9614         (solib_target_current_sos): Update.
9615
9616 2019-01-17  Tom Tromey  <tromey@bapiya>
9617
9618         * valprint.c: Replace "the the" with "the".
9619         * symtab.c: Replace "the the" with "the".
9620         * solib.c: Replace "the the" with "the".
9621         * solib-dsbt.c: Replace "the the" with "the".
9622         * linespec.c: Replace "the the" with "the".
9623         * dwarf2loc.h: Replace "the the" with "the".
9624         * amd64-windows-tdep.c: Replace "the the" with "the".
9625         * aarch64-tdep.c: Replace "the the" with "the".
9626
9627 2019-01-16  Keith Seitz  <keiths@redhat.com>
9628
9629         PR gdb/23773
9630         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9631         <builder>: Rename to ..
9632         <m_builder>: ... this and make private.
9633         (dwarf2_cu::get_builder): New method.  Change all users of
9634         `builder' to use this method.
9635         (dwarf2_start_symtab): Move to ...
9636         (dwarf2_cu::start_symtab): ... here.  Update all callers
9637         (setup_type_unit_groups): Move to ...
9638         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9639         callers.
9640         (dwarf2_cu::reset_builder): New method.
9641         (process_full_compunit, process_full_type_unit): Use
9642         dwarf2_cu::reset_builder.
9643         (follow_die_offset): Record the ancestor CU if it is different
9644         from the followed DIE's CU.
9645         (follow_die_sig_1): Likewise.
9646
9647 2019-01-15  Tom Tromey  <tom@tromey.com>
9648
9649         * remote.c (class remote_state) <buf>: Now a char_vector.
9650         <buf_size>: Remove.
9651         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9652         parameter.
9653         (remote_target::getpkt_or_notif_sane_1)
9654         (remote_target::getpkt_sane)
9655         (remote_target::getpkt_or_notif_sane): Likewise.
9656         (class remote_target) <putpkt>: New overload.
9657         (remote_target::read_frame): Change type of "buf_p".  Remove
9658         sizeof_p parameter.
9659         (packet_ok): New overload.
9660         (packet_check_result): New overload.
9661         Update all uses.
9662
9663 2019-01-14  Tom Tromey  <tom@tromey.com>
9664
9665         * remote-notif.c (handle_notification, remote_notif_ack)
9666         (remote_notif_parse): Make "buf" const.
9667         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9668         const.
9669         (remote_notif_parse, remote_notif_ack, handle_notification):
9670         Likewise.
9671         * remote.c (remote_notif_stop_parse): Make "buf" const.
9672         (remote_target::remote_parse_stop_reply): Make "buf" const.
9673         (remote_notif_stop_ack): Make "buf" const.
9674
9675 2019-01-14  Tom Tromey  <tom@tromey.com>
9676
9677         * remote.c (remote_console_output): Make parameter const.
9678
9679 2019-01-14  Tom Tromey  <tom@tromey.com>
9680
9681         * target-debug.h (target_debug_print_signals): Constify.
9682         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9683         * procfs.c (procfs_target::pass_signals): Update.
9684         * linux-nat.c (linux_nat_target::pass_signals): Update.
9685         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9686         * target-delegates.c: Rebuild.
9687         * remote.c (remote_target::program_signals): Update.
9688         (remote_target::pass_signals): Update.
9689         * target.c (target_pass_signals): Constify argument.
9690         (target_program_signals): Likewise.
9691         * target.h (struct target_ops) <pass_signals, program_signals>:
9692         Constify argument.
9693         (target_pass_signals, target_program_signals): Constify argument.
9694
9695 2019-01-14  Tom Tromey  <tom@tromey.com>
9696
9697         PR tui/28819:
9698         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9699
9700 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9701
9702         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9703         field.
9704         * rs6000-tdep.c: Include reggroups.h.
9705         (IS_V_ALIAS_PSEUDOREG): Define.
9706         (rs6000_register_name): Return names for the "vX" aliases.
9707         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9708         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9709         aliases.  Call default_register_reggroup_p for all other
9710         pseudo-registers.
9711         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9712         New functions.
9713         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9714         Handle "vX" aliases.
9715         (v_alias_pseudo_register_collect): New function.
9716         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9717         (rs6000_gdbarch_init): Initialize "vX" aliases as
9718         pseudo-registers.  Restore registration of
9719         rs6000_pseudo_register_reggroup_p with
9720         set_tdesc_pseudo_register_reggroup_p.
9721
9722 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9723
9724         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9725         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9726         set_gdbarch_num_pseudo_regs.
9727
9728 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9729
9730         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9731         Remove arg prefixname, add do_set and do_show.
9732         Add member functions set_list and show_list.
9733         * cli/cli-style.c (class cli_style_option): Update accordingly.
9734         (style_set_list): Move to file scope.
9735         (style_show_list): Likewise.
9736         (set_style): Call help_list.
9737         (show_style): Call cmd_show_list.
9738         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9739         Update to use the new macro.
9740
9741 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9742
9743         * ada-lang.c (_initialize_ada_language): Expand the help text
9744         for the "catch exception" command.
9745
9746 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9747
9748         * symtab.c (matching_obj_sections): Initialize obj,
9749         declare it closer to its usage.
9750
9751 2019-01-10  Tom Tromey  <tom@tromey.com>
9752
9753         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9754         (basic_inf_threads_range): Remove.
9755         (inf_threads_range, inf_non_exited_threads_range)
9756         (safe_inf_threads_range): Use next_adapter.
9757
9758 2019-01-10  Keith Seitz  <keiths@redhat.com>
9759
9760         PR gdb/23712
9761         PR symtab/23010
9762         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9763         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9764
9765 2019-01-10  Keith Seitz  <keiths@redhat.com>
9766
9767         PR gdb/23712
9768         PR symtab/23010
9769         * dictionary.c (pending_to_vector): Remove.
9770         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9771         Remove _1 suffix, replacing functions of the same name.  Update
9772         all callers.
9773         (dict_create_hashed, dict_create_hashed_expandable)
9774         (dict_create_linear, dict_create_linear_expandable, dict_free)
9775         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9776         Make functions static.
9777
9778 2019-01-10  Keith Seitz  <keiths@redhat.com>
9779
9780         PR gdb/23712
9781         PR symtab/23010
9782         * dictionary.h (struct dictionary): Replace declaration with
9783         multidictionary.
9784         (dict_create_hashed, dict_create_hashed_expandable)
9785         (dict_create_linear, dict_create_linear_expandable)
9786         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9787         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9788         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9789         taking multidictionary argument.
9790         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9791         * block.h (struct block) <dict>: Change to multidictionary
9792         and rename `multidict'.
9793         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9794         symmisc.c: Update all dictionary references to multidictionary.
9795
9796 2019-01-10  Keith Seitz  <keiths@redhat.com>
9797
9798         PR gdb/23712
9799         PR symtab/23010
9800         * dictionary.c: Include unordered_map.
9801         (pending_to_vector): New function.
9802         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9803         Rewrite the non-"_1" functions to take vector instead
9804         of linked list.
9805         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9806         "new" _1 versions of the same name.
9807         (multidictionary): Define.
9808         (std::hash<enum language): New definition.
9809         (collate_pending_symbols_by_language, mdict_create_hashed)
9810         (mdict_create_hashed_expandable, mdict_create_linear)
9811         (mdict_create_linear_expandable, mdict_free)
9812         (find_language_dictionary, create_new_language_dictionary)
9813         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9814         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9815         (mdict_size, mdict_empty): New functions.
9816         * dictionary.h (mdict_iterator): Define.
9817
9818 2019-01-10  Pedro Alves  <palves@redhat.com>
9819
9820         * breakpoint.c (read_uploaded_action)
9821         (create_tracepoint_from_upload): Adjust to use
9822         gdb::unique_xmalloc_ptr.
9823         * ctf.c (ctf_write_uploaded_tp):
9824         (SET_ARRAY_FIELD): Use emplace_back.
9825         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9826         * tracefile-tfile.c (tfile_write_uploaded_tp):
9827         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9828         gdb::unique_xmalloc_ptr.
9829         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9830         at_string, cond_string, cmd_strings>: Replace char pointers
9831         with gdb::unique_xmalloc_ptr.
9832
9833 2019-01-10  Pedro Alves  <palves@redhat.com>
9834
9835         * solib-target.c (library_list_start_library): Don't xstrdup name.
9836
9837 2019-01-10  Pedro Alves  <palves@redhat.com>
9838
9839         * mdebugread.c (parse_partial_symbols): Use
9840         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9841
9842 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9843
9844         * linux-fork.c (scoped_switch_fork_info)
9845         <~scoped_switch_fork_info>: Fix incorrect variable name.
9846
9847 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9848
9849         * linux-fork.c (scoped_switch_fork_info)
9850         <scoped_switch_fork_info>: Make explicit.
9851         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9852
9853 2019-01-10  Tom Tromey  <tom@tromey.com>
9854
9855         * objfiles.h (objfile::reset_psymtabs): Update.
9856         * objfiles.c (objfile::objfile): Update.
9857         * psymtab.h (psymtab_storage::obstack): Update.
9858         (psymtab_storage::m_obstack): Use gdb::optional.
9859         (class psymtab_storage): Update comment.  Remove objfile
9860         parameter.
9861         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9862
9863 2019-01-10  Tom Tromey  <tom@tromey.com>
9864
9865         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9866         <free_psymtabs>: Now private.
9867         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9868         (allocate_psymtab): Use new method.
9869
9870 2019-01-10  Tom Tromey  <tom@tromey.com>
9871
9872         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9873         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9874         * mdebugread.c (parse_partial_symbols): Use
9875         allocate_dependencies.
9876         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9877         allocate_dependencies.
9878         (process_psymtab_comp_unit_reader)
9879         (build_type_psymtab_dependencies): Likewise.
9880         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9881
9882 2019-01-10  Tom Tromey  <tom@tromey.com>
9883
9884         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9885         PSYMBOL_SET_LANGUAGE.
9886         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9887
9888 2019-01-10  Tom Tromey  <tom@tromey.com>
9889
9890         * psymtab.h (psymtab_storage::obstack): New method.
9891         <m_obstack>: Rename from obstack; now private.
9892         * psymtab.c (psymtab_storage): Update.
9893         * dwarf2read.c (create_addrmap_from_index)
9894         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9895         Update.
9896
9897 2019-01-10  Tom Tromey  <tom@tromey.com>
9898
9899         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9900         * objfiles.h (objfile::reset_psymtabs): New method.
9901
9902 2019-01-10  Tom Tromey  <tom@tromey.com>
9903
9904         * symmisc.c (print_symbol_bcache_statistics): Update.
9905         (print_objfile_statistics): Update.
9906         * symfile.c (reread_symbols): Update.
9907         * psymtab.h (class psymtab_storage): New.
9908         * psymtab.c (psymtab_storage): New constructor.
9909         (~psymtab_storage): New destructor.
9910         (require_partial_symbols): Update.
9911         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9912         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9913         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9914         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9915         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9916         (start_psymtab_common, end_psymtab_common)
9917         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9918         (allocate_psymtab): Update.
9919         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9920         Update.
9921         (dump_psymtab_addrmap, maintenance_print_psymbols)
9922         (maintenance_check_psymtabs): Update.
9923         (class objfile_psymtabs): Move to objfiles.h.
9924         * psympriv.h (discard_psymtab): Now inline.
9925         (psymtab_discarder::psymtab_discarder): Update.
9926         (psymtab_discarder::~psymtab_discarder): Update.
9927         (ALL_OBJFILE_PSYMTABS): Rewrite.
9928         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9929         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9930         Remove fields.
9931         <partial_symtabs>: New field.
9932         (class objfile_psymtabs): Move from psymtab.h.  Update.
9933         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9934         psymbol_cache.
9935         (objfile::~objfile): Don't destroy psymbol_cache.
9936         * mdebugread.c (parse_partial_symbols): Update.
9937         * dwarf2read.c (create_addrmap_from_index)
9938         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9939         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9940         (add_partial_subprogram, dwarf2_ranges_read): Update.
9941         * dwarf-index-write.c (write_address_map)
9942         (write_one_signatured_type, recursively_write_psymbols)
9943         (class debug_names, class debug_names, write_psymtabs_to_index):
9944         Update.
9945
9946 2019-01-10  Tom Tromey  <tom@tromey.com>
9947
9948         * symtab.h (SYMBOL_SET_NAMES): Update.
9949         (symbol_set_names): Update.
9950         (MSYMBOL_SET_NAMES): Update.
9951         * symtab.c (symbol_set_names): Change argument to be an
9952         objfile_per_bfd_storage.
9953         * psymtab.c (add_psymbol_to_bcache): Update.
9954         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9955
9956 2019-01-10  Tom Tromey  <tom@tromey.com>
9957
9958         * symtab.c (create_demangled_names_hash): Change argument to be an
9959         objfile_per_bfd_storage.
9960         (symbol_set_names): Update.
9961
9962 2019-01-10  Tom Tromey  <tom@tromey.com>
9963
9964         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9965         init_psymbol_list.
9966         * psymtab.c (init_psymbol_list): Do nothing if already called.
9967         * psympriv.h (init_psymbol_list): Add comment.
9968         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9969         init_psymbol_list.
9970         * dbxread.c (dbx_symfile_read): Unconditionally call
9971         init_psymbol_list.
9972
9973 2019-01-10  Tom Tromey  <tom@tromey.com>
9974
9975         * xcoffread.c (scan_xcoff_symtab): Update.
9976         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9977         "where".
9978         * mdebugread.c (parse_partial_symbols)
9979         (handle_psymbol_enumerators): Update.
9980         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9981         * dbxread.c (read_dbx_symtab): Update.
9982         * psympriv.h (psymbol_placement): New enum.
9983         (add_psymbol_to_list): Update.
9984
9985 2019-01-10  Tom Tromey  <tom@tromey.com>
9986
9987         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9988         static_psymbols parameters.
9989         (scan_xcoff_symtab): Update.
9990         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9991         static_psymbols parameters.
9992         * psympriv.h (start_psymtab_common): Update.
9993         * mdebugread.c (parse_partial_symbols): Update.
9994         * dwarf2read.c (create_partial_symtab): Update.
9995         * dbxread.c (read_dbx_symtab): Update.
9996         (start_psymtab): Remove global_psymbols and static_psymbols
9997         parameters.
9998
9999 2019-01-10  Tom Tromey  <tom@tromey.com>
10000
10001         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10002         * psymtab.c (allocate_psymtab): Add comment.
10003         * psympriv.h (allocate_psymtab): Add comment.
10004         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10005         initializations.
10006         * dbxread.c (dbx_end_psymtab): Remove some initializations.
10007
10008 2019-01-10  Tom Tromey  <tom@tromey.com>
10009
10010         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10011         Don't declare.
10012         * mipsread.c: Include mdebugread.h.
10013         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10014         Declare.
10015         * elfread.c: Include mdebugread.h.
10016
10017 2019-01-09  Tom Tromey  <tom@tromey.com>
10018
10019         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10020         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10021         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10022         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10023         (psym_lookup_symbol, psym_find_last_source_symtab)
10024         (psym_forget_cached_source_info, psym_print_stats)
10025         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10026         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10027         (psym_map_matching_symbols, psym_expand_symtabs_matching)
10028         (psym_find_compunit_symtab_by_address)
10029         (maintenance_print_psymbols, maintenance_info_psymtabs)
10030         (maintenance_check_psymtabs): Use ranged for.
10031         * psymtab.h (class objfile_psymtabs): New.
10032         (require_partial_symbols): Return objfile_psymtabs.
10033         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10034
10035 2019-01-09  Tom Tromey  <tom@tromey.com>
10036
10037         * symfile.c (overlay_invalidate_all, find_pc_overlay)
10038         (find_pc_mapped_section, list_overlays_command)
10039         (map_overlay_command, unmap_overlay_command)
10040         (simple_overlay_update): Use all_objfiles.
10041         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10042         * printcmd.c (info_symbol_command): Use all_objfiles.
10043         * objfiles.h (ALL_OBJSECTIONS): Remove.
10044         * maint.c (maintenance_translate_address): Use all_objfiles.
10045         * gcore.c (gcore_create_callback): Use all_objfiles.
10046         (objfile_find_memory_regions): Likewise.
10047
10048 2019-01-09  Tom Tromey  <tom@tromey.com>
10049
10050         * symtab.c (find_line_symtab, info_sources_command)
10051         (make_source_files_completion_list): Use objfile_compunits.
10052         * source.c (select_source_symtab): Use objfile_compunits.
10053         * objfiles.h (struct objfile): Update comment.
10054         (ALL_OBJFILES): Remove.
10055         (ALL_FILETABS): Remove.
10056         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10057         objfile_compunits.
10058
10059 2019-01-09  Tom Tromey  <tom@tromey.com>
10060
10061         * symmisc.c (print_objfile_statistics, dump_objfile)
10062         (maintenance_print_symbols): Use compunit_filetabs.
10063         * source.c (forget_cached_source_info_for_objfile): Use
10064         compunit_filetabs.
10065         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10066         (ALL_FILETABS): Use compunit_filetabs.
10067         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10068         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10069
10070 2019-01-09  Tom Tromey  <tom@tromey.com>
10071
10072         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10073         (compunit_filetabs): New.
10074         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10075         compunit_filetabs.
10076         (info_sources_command, make_source_files_completion_list): Remove
10077         declaration.
10078         * symmisc.c (print_objfile_statistics, dump_objfile)
10079         (maintenance_print_symbols): Remove declaration.
10080         (maintenance_info_symtabs): Use compunit_filetabs.
10081         (maintenance_info_line_tables): Likewise.
10082         * source.c (select_source_symtab): Change local variable name.
10083         (forget_cached_source_info_for_objfile): Remove declaration.
10084         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10085         * objfiles.c (objfile_relocate1): Remove declaration.
10086         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10087         declaration.
10088         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10089         * coffread.c (coff_symtab_read): Remove declaration.
10090         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10091         compunit_filetabs.
10092
10093 2019-01-09  Tom Tromey  <tom@tromey.com>
10094
10095         * symtab.c (lookup_objfile_from_block)
10096         (find_pc_sect_compunit_symtab, search_symbols)
10097         (default_collect_symbol_completion_matches_break_on): Use
10098         objfile_compunits.
10099         * objfiles.h (ALL_COMPUNITS): Remove.
10100         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10101         * cp-support.c (add_symbol_overload_list_qualified): Use
10102         objfile_compunits.
10103         * ada-lang.c (ada_collect_symbol_completion_matches)
10104         (ada_add_global_exceptions): Use objfile_compunits.
10105
10106 2019-01-09  Tom Tromey  <tom@tromey.com>
10107
10108         * source.c (select_source_symtab)
10109         (forget_cached_source_info_for_objfile): Remove declaration.
10110         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10111         declaration.
10112         * maint.c (count_symtabs_and_blocks): Remove declaration.
10113         * cp-support.c (add_symbol_overload_list_qualified): Remove
10114         declaration.
10115         * coffread.c (coff_symtab_read): Remove declaration.
10116         * symtab.c (lookup_symbol_in_objfile_symtabs)
10117         (basic_lookup_transparent_type_1): Use objfile_compunits.
10118         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10119         (info_sources_command, search_symbols)
10120         (default_collect_symbol_completion_matches_break_on)
10121         (make_source_files_completion_list): Remove declaration.
10122         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10123         (ada_collect_symbol_completion_matches)
10124         (ada_add_global_exceptions): Remove declaration.
10125         * linespec.c (iterate_over_all_matching_symtabs): Use
10126         objfile_compunits.
10127         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10128         (class objfile_compunits): New.
10129         (ALL_COMPUNITS): Use objfile_compunits.
10130         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10131         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10132         objfile_compunits.
10133         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10134
10135 2019-01-09  Tom Tromey  <tom@tromey.com>
10136
10137         * symtab.c (search_symbols)
10138         (default_collect_symbol_completion_matches_break_on): Use
10139         objfile_msymbols.
10140         * ada-lang.c (ada_lookup_simple_minsym)
10141         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10142         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10143         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10144         objfile_msymbols.
10145         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10146         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10147         * objc-lang.c (find_methods): Use objfile_msymbols.
10148         (info_selectors_command, info_classes_command): Likewise.
10149         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10150         * objfiles.h (class objfile_msymbols): New.
10151         (ALL_OBJFILE_MSYMBOLS): Remove.
10152         (ALL_MSYMBOLS): Remove.
10153
10154 2019-01-09  Tom Tromey  <tom@tromey.com>
10155
10156         * common/next-iterator.h (next_adapter): Add Iterator template
10157         parameter.
10158         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10159         (class all_objfiles_safe): New.
10160         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10161         * objfiles.c (put_objfile_before): Update comment.
10162         (add_separate_debug_objfile): Likewise.
10163         (free_all_objfiles): Use all_objfiles_safe.
10164         (objfile_purge_solibs): Likewise.
10165
10166 2019-01-09  Tom Tromey  <tom@tromey.com>
10167
10168         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10169         (expand_symtab_containing_pc, lookup_static_symbol)
10170         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10171         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10172         all_objfiles.
10173         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10174         * breakpoint.c (create_overlay_event_breakpoint)
10175         (create_longjmp_master_breakpoint)
10176         (create_std_terminate_master_breakpoint)
10177         (create_exception_master_breakpoint): Use all_objfiles.
10178         * linux-thread-db.c (try_thread_db_load_from_pdir)
10179         (has_libpthread): Use all_objfiles.
10180         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10181         * linespec.c (iterate_over_all_matching_symtabs)
10182         (search_minsyms_for_name): Use all_objfiles.
10183         * maint.c (maintenance_info_sections): Use all_objfiles.
10184         * main.c (captured_main_1): Use all_objfiles.
10185         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10186         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10187         * guile/scm-pretty-print.c
10188         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10189         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10190         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10191         (maintenance_print_msymbols): Use all_objfiles.
10192         * source.c (select_source_symtab): Use all_objfiles.
10193         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10194         * symfile.c (remove_symbol_file_command)
10195         (expand_symtabs_matching, map_symbol_filenames): Use
10196         all_objfiles.
10197         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10198         all_objfiles.
10199         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10200         * objc-lang.c (find_methods): Use all_objfiles.
10201         * objfiles.c (have_partial_symbols, have_full_symbols)
10202         (have_minimal_symbols, qsort_cmp)
10203         (default_iterate_over_objfiles_in_search_order): Use
10204         all_objfiles.
10205         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10206         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10207         (maintenance_check_psymtabs): Use all_objfiles.
10208         (ALL_PSYMTABS): Remove.
10209         * compile/compile-object-run.c (do_module_cleanup): Use
10210         all_objfiles.
10211         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10212         * cp-support.c (add_symbol_overload_list_qualified): Use
10213         all_objfiles.
10214         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10215         Use all_objfiles.
10216         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10217         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10218         all_objfiles.
10219         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10220         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10221         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10222         Uses all_objfiles.
10223         * solib.c (solib_read_symbols): Use all_objfiles
10224
10225 2019-01-09  Tom Tromey  <tom@tromey.com>
10226
10227         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10228         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10229         all_objfiles.
10230         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10231         * symmisc.c (print_symbol_bcache_statistics)
10232         (print_objfile_statistics, maintenance_print_objfiles)
10233         (maintenance_info_symtabs, maintenance_check_symtabs)
10234         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10235         all_objfiles.
10236         * source.c (forget_cached_source_info): Use all_objfiles.
10237         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10238         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10239         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10240         * objfiles.c (update_section_map): Use all_objfiles.
10241         (shared_objfile_contains_address_p): Likewise.
10242         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10243         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10244
10245 2019-01-09  Tom Tromey  <tom@tromey.com>
10246
10247         * common/next-iterator.h: New file.
10248         * objfiles.h (class all_objfiles): New.
10249         (struct objfile_iterator): New.
10250
10251 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10252
10253         * NEWS: Move the description of the changed "frame", "select-frame",
10254          and "info frame" commands to the Changed commands section.
10255
10256 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10257
10258         * gdbtypes.c (check_stub_method_group): Remove handling of old
10259         mangling schemes.
10260         * linespec.c (find_methods): Likewise.
10261         * stabsread.c (read_member_functions): Likewise.
10262         * valops.c (search_struct_method): Likewise.
10263         (value_struct_elt_for_reference): Likewise.
10264         * NEWS: Mention this change.
10265
10266 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10267
10268         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10269         print_source_lines.
10270         * source.c (print_source_lines_base): Update line number check.
10271         (print_source_lines): New function.
10272         (source_lines_range::source_lines_range): New function.
10273         * source.h (class source_lines_range): New class.
10274         (print_source_lines): New declaration.
10275
10276 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10277
10278         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10279
10280 2019-01-08  Tom Tromey  <tom@tromey.com>
10281             Simon Marchi  <simon.marchi@ericsson.com>
10282
10283         PR gdb/24060
10284         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10285         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10286         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10287         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10288         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10289         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10290
10291 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10292
10293         * source.c (select_source_symtab): Move header comment to
10294         declaration in source.h.
10295         (forget_cached_source_info_for_objfile): Likewise.
10296         (forget_cached_source_info): Likewise.
10297         (identify_source_line): Likewise.
10298         * source.h (identify_source_line): Move declaration from symtab.h
10299         and add comment from source.c
10300         (print_source_lines): Likewise.
10301         (forget_cached_source_info_for_objfile): Likewise.
10302         (forget_cached_source_info): Likewise.
10303         (select_source_symtab): Likewise.
10304         (enum print_source_lines_flag): Move definition from symtab.h.
10305         * symtab.h (identify_source_line): Move declaration to source.h.
10306         (print_source_lines): Likewise.
10307         (forget_cached_source_info_for_objfile): Likewise.
10308         (forget_cached_source_info): Likewise.
10309         (select_source_symtab): Likewise.
10310         (enum print_source_lines_flag): Move definition to source.h.
10311         * tui/tui-hooks.c: Add 'source.h' include.
10312
10313 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10314
10315         * source.c (print_source_lines_base): Handle requests to print
10316         reverse line number sequences, and guard against empty lines
10317         string.
10318
10319 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10320
10321         * source.c (print_source_lines_base): Fix skip of '\r' if next
10322         character is '\n'.
10323
10324 2019-01-06  Tom Tromey  <tom@tromey.com>
10325
10326         * c-exp.y (struct c_parse_state) <macro_original_text,
10327         expansion_obstack>: New member.
10328         (macro_original_text, expansion_obstack): Remove globals.
10329         (scan_macro_expansion, scanning_macro_expansion)
10330         (finished_macro_expansion): Update.
10331         (scan_macro_cleanup): Remove.
10332         (yylex, c_parse): Update.
10333
10334 2019-01-06  Tom Tromey  <tom@tromey.com>
10335
10336         * c-exp.y (struct c_parse_state) <strings>: New member.
10337         (operator_stoken): Update.
10338
10339 2019-01-06  Tom Tromey  <tom@tromey.com>
10340
10341         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10342         (union type_stack_elt) <typelist_val>: Now a pointer to
10343         std::vector.
10344         (type_stack_cleanup): Don't declare.
10345         (push_typelist): Update.
10346         * parse.c (pop_typelist): Return a std::vector.
10347         (push_typelist): Take a std::vector.
10348         (follow_types): Update.  Do not free args.
10349         (type_stack_cleanup): Remove.
10350         * c-exp.y (struct c_parse_state): New.
10351         (cpstate): New global.
10352         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10353         (nonempty_typelist): Update.
10354         (func_mod): Create a new vector.
10355         (c_parse): Create a c_parse_state.
10356         (check_parameter_typelist): Do not delete params.
10357         (function_method): Update.  Do not delete type_list.
10358
10359 2019-01-06  Tom Tromey  <tom@tromey.com>
10360
10361         PR gdb/28155:
10362         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10363         check_typedef.
10364         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10365         (print_return_value): Likewise.
10366
10367 2019-01-05  Tom Tromey  <tom@tromey.com>
10368
10369         * contrib/cleanup_check.py: Remove.
10370         * contrib/gcc-with-excheck: Remove.
10371         * contrib/exsummary.py: Remove.
10372         * contrib/excheck.py: Remove.
10373
10374 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10375
10376         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10377         NULL. Initialize tpprev to NULL instead of assigning it
10378         to NULL on the next statement.
10379         * windows-nat.c (windows_delete_thread): Remove check for
10380         main_thread_id before printing thread exit notifications.
10381         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10382         Remove thread ID check against main_thread_id.
10383         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10384         windows_delete_thread.
10385         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10386
10387 2019-01-04  Tom Tromey  <tom@tromey.com>
10388
10389         * compile/compile.c (_initialize_compile): Use upper case for
10390         metasyntactic variables.
10391         * symmisc.c (_initialize_symmisc): Use upper case for
10392         metasyntactic variables.
10393         * psymtab.c (_initialize_psymtab): Use upper case for
10394         metasyntactic variables.
10395         * demangle.c (demangle_command): Use upper case for metasyntactic
10396         variables.
10397         (_initialize_demangler): Likewise.
10398         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10399         variables.
10400
10401 2019-01-03  Tom Tromey  <tom@tromey.com>
10402
10403         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10404
10405 2019-01-03  Tom Tromey  <tom@tromey.com>
10406
10407         * python/py-symtab.c (salpy_str): Update.
10408         (struct salpy_sal_object) <symtab>: Now a PyObject.
10409         (salpy_dealloc): Update.
10410         (del_objfile_sal): Use gdbpy_ref.
10411
10412 2019-01-03  Tom Tromey  <tom@tromey.com>
10413
10414         * python/py-type.c (convert_field): Use new_reference.  Return
10415         gdbpy_ref.
10416         (make_fielditem): Return gdbpy_ref.
10417         (typy_fields): Update.
10418         (typy_getitem): Update.
10419         (field_name): Return gdbpy_ref.  Use new_reference.
10420         (typy_iterator_iternext): Update.
10421
10422 2019-01-03  Tom Tromey  <tom@tromey.com>
10423
10424         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10425
10426 2019-01-03  Tom Tromey  <tom@tromey.com>
10427
10428         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10429         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10430         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10431         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10432         (pspy_set_type_printers): Likewise.
10433         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10434         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10435         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10436         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10437         (objfpy_set_type_printers): Likewise.
10438
10439 2019-01-03  Tom Tromey  <tom@tromey.com>
10440
10441         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10442         (gdbpy_print_stack): Use gdbpy_err_fetch.
10443         * python/python-internal.h (class gdbpy_err_fetch): New class.
10444         (class gdbpy_enter) <m_error_type, m_error_value,
10445         m_error_traceback>: Remove.
10446         <m_error>: New member.
10447         (gdbpy_exception_to_string): Don't declare.
10448         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10449         * python/py-value.c (convert_value_from_python): Use
10450         gdbpy_err_fetch.
10451         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10452         gdbpy_exception_to_string.
10453         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10454         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10455         gdbpy_err_fetch.
10456
10457 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10458
10459         * linux-nat.c (delete_lwp_cleanup): Delete.
10460         (struct lwp_deleter): New struct.
10461         (lwp_info_up): New typedef.
10462         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10463         lwp_info_up.
10464
10465 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10466
10467         * linux-fork.c (class scoped_switch_fork_info): New class.
10468         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10469
10470 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10471
10472         * valops.c (find_overload_match): Remove use of null_cleanup, and
10473         calls to do_cleanups.
10474
10475 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10476
10477         * compile/compile-cplus-types.c
10478         (compile_cplus_instance::decl_name): Handle changes to
10479         cp_func_name.
10480         * cp-support.c (cp_func_name): Update header comment, update
10481         return type.
10482         * cp-support.h (cp_func_name): Update return type in declaration.
10483         * valops.c (find_overload_match): Move temp_func local to top
10484         level of function and change its type.  Use temp_func to hold and
10485         delete temporary string obtained from cp_func_name.
10486
10487 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10488
10489         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10490         gdb::char_vector, remove cleanup, and update uses of `msg`.
10491
10492 2019-01-03  Jim Wilson  <jimw@sifive.com>
10493
10494         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10495
10496 2019-01-02  Tom Tromey  <tom@tromey.com>
10497
10498         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10499         (tdesc_parse_xml): Remove cleanups.
10500         * target-descriptions.h (make_cleanup_free_target_description):
10501         Don't declare.
10502         (target_desc_deleter): New struct.
10503         (target_desc_up): New typedef.
10504         * target-descriptions.c (target_desc_deleter::operator()): Rename
10505         from free_target_description.
10506         (make_cleanup_free_target_description): Remove.
10507
10508 2019-01-02  Tom Tromey  <tom@tromey.com>
10509
10510         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10511         constructor, destructor.
10512         (linespec_parser): Remove typedef.
10513         (~linespec_parser): Rename from linespec_parser_delete.
10514         (linespec_lex_to_end, linespec_complete_label)
10515         (linespec_complete): Update.
10516         (decode_line_full): Remove cleanups.
10517         (decode_line_1): Update.
10518
10519 2019-01-02  Tom Tromey  <tom@tromey.com>
10520
10521         * python/python-internal.h (inferior_to_inferior_object): Change
10522         return type.
10523         * python/py-exitedevent.c (create_exited_event_object): Update.
10524         * python/py-inferior.c (inferior_to_inferior_object): Return
10525         gdbpy_ref.
10526         (python_new_inferior, python_inferior_deleted)
10527         (thread_to_thread_object, delete_thread_object)
10528         (build_inferior_list, gdbpy_selected_inferior): Update.
10529         * python/py-infthread.c (create_thread_object): Update.  Also fail
10530         if inferior_to_inferior_object fails.
10531
10532 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10533
10534         * inferior.h (class inferior) <displaced_step_state>: New field.
10535         * infrun.h (struct displaced_step_state): Move here from
10536         infrun.c.  Initialize fields, add constructor.
10537         <inf>: Remove field.
10538         <reset>: New method.
10539         * infrun.c (struct displaced_step_inferior_state): Move to
10540         infrun.h.
10541         (displaced_step_inferior_states): Remove.
10542         (get_displaced_stepping_state): Adust.
10543         (displaced_step_in_progress_any_inferior): Adjust.
10544         (displaced_step_in_progress_thread): Adjust.
10545         (displaced_step_in_progress): Adjust.
10546         (add_displaced_stepping_state): Remove.
10547         (get_displaced_step_closure_by_addr): Adjust.
10548         (remove_displaced_stepping_state): Remove.
10549         (infrun_inferior_exit): Call displaced_step_state.reset.
10550         (use_displaced_stepping): Don't check for NULL.
10551         (displaced_step_prepare_throw): Call
10552         get_displaced_stepping_state.
10553         (displaced_step_fixup): Don't check for NULL.
10554         (prepare_for_detach): Don't check for NULL.
10555
10556 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10557
10558         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10559          in case of call that did not complete.
10560
10561 2019-01-02  Andrey Utkin  <autkin@undo.io>
10562
10563         * symfile.c (find_separate_debug_file): Fix search of debug files for
10564         remote debuggee.
10565
10566 2019-01-02  Tom Tromey  <tom@tromey.com>
10567
10568         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10569         indentation.
10570         * python/py-frame.c (frapy_older): Remove cast.
10571         (frapy_newer): Likewise.
10572         * python/py-breakpoint.c (local_setattro): Remove cast.
10573         * python/py-arch.c (archpy_name): Remove local variable.
10574         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10575
10576 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10577
10578         * unittests/basic_string_view/element_access/char/empty.cc:
10579         Fix year range in copyright header.
10580
10581 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10582
10583         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10584         Delete.
10585         <operator==>: Update with for removed field.
10586         <hash>: Likewise.
10587         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10588         <isa_features>: ...this.
10589         <abi_features>: New field.
10590         (riscv_isa_flen): Update comment.
10591         (riscv_abi_xlen): New declaration.
10592         (riscv_abi_flen): New declaration.
10593         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10594         isa_features.
10595         (riscv_abi_xlen): New function.
10596         (riscv_isa_flen): Update to get answer from isa_features.
10597         (riscv_abi_flen): New function.
10598         (riscv_has_fp_abi): Update to get answer from abi_features.
10599         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10600         xlen and flen.
10601         (riscv_call_info) <xlen, flen>: Update comment.
10602         (riscv_call_arg_struct): Remove invalid assertions
10603         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10604         is removed.
10605         (riscv_gdbarch_init): Gather isa features and abi features
10606         separately, ensure both match on the gdbarch when reusing an old
10607         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10608         a target with 64-bit float hardware.
10609
10610 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10611
10612         * source.c (search_command_helper): Stop reverse search
10613         when line 1 has been searched.
10614
10615 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10616
10617         * record-full.c (record_full_base_target::close): Rewrite
10618         record_full_core_buf_list free logic.
10619
10620 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10621
10622         * break-catch-syscall.c (print_one_catch_syscall): xfree
10623         the last text.
10624
10625 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10626
10627         * top.c (print_gdb_version): Update Copyright year in version
10628         message.
10629
10630 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10631
10632         Update copyright year range in all GDB files.
10633
10634 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10635
10636         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10637
10638 For older changes see ChangeLog-2018.
10639 \f
10640 Local Variables:
10641 mode: change-log
10642 left-margin: 8
10643 fill-column: 74
10644 version-control: never
10645 coding: utf-8
10646 End:
10647