Use yy-remap.h in cp-name-parser.y
[external/binutils.git] / gdb / ChangeLog
1 2018-06-01  Tom Tromey  <tom@tromey.com>
2
3         * cp-name-parser.y (parser_fprintf): Declare.
4         (GDB_YY_REMAP_PREFIX): Define.
5         Include yy-remap.h.  Don't redefine yy* identifiers.
6
7 2018-06-01  Tom Tromey  <tom@tromey.com>
8
9         * python/py-type.c (typy_legacy_template_argument): Update.
10         * cp-support.h (cp_demangled_name_to_comp): Update.
11         * cp-name-parser.y (cp_demangled_name_to_comp): Change errmsg
12         parameter to be a "std::string *".
13         (main): Update.
14
15 2018-06-01  H.J. Lu  <hongjiu.lu@intel.com>
16
17         * ada-lex.l: Include "diagnostics.h" instead of
18         "common/diagnostics.h".
19         * unittests/environ-selftests.c: Likewise.
20         * common/diagnostics.h: Moved to ../include.
21
22 2018-06-01  Joel Brobecker  <brobecker@adacore.com>
23
24         * breakpoint.c (breakpoint_re_set): Temporarily force language_mode
25         to language_mode_manual while calling breakpoint_re_set_one.
26
27 2018-06-01  Tom Tromey  <tom@tromey.com>
28
29         * valops.c (value_cast_structs, destructor_name_p): Update.
30         * symtab.c (gdb_mangle_name): Update.
31         * stabsread.c (define_symbol, read_cpp_abbrev, read_baseclasses):
32         Update.
33         * p-valprint.c (pascal_object_is_vtbl_ptr_type)
34         (pascal_object_print_value_fields, pascal_object_print_value):
35         Update.
36         * p-typeprint.c (pascal_type_print_derivation_info): Update.
37         * linespec.c (find_methods): Update.
38         * gdbtypes.h (type_name_no_tag): Remove.
39         (type_name_or_error): Rename from type_name_no_tag_or_error.
40         * gdbtypes.c (type_name_no_tag): Remove.
41         (type_name_or_error): Rename from type_name_no_tag_or_error.
42         (lookup_struct_elt_type, check_typedef): Update.
43         * expprint.c (print_subexp_standard): Update.
44         * dwarf2read.c (dwarf2_add_field, load_partial_dies): Update.
45         * d-namespace.c (d_lookup_nested_symbol): Update.
46         * cp-valprint.c (cp_is_vtbl_ptr_type, cp_print_value_fields)
47         (cp_print_class_member): Update.
48         * cp-namespace.c (cp_lookup_nested_symbol): Update.
49         * completer.c (add_struct_fields): Update.
50         * c-typeprint.c (cp_type_print_derivation_info)
51         (c_type_print_varspec_prefix, c_type_print_base_struct_union):
52         Update.
53         * ada-lang.c (parse_old_style_renaming, xget_renaming_scope)
54         (ada_prefer_type, ada_is_exception_sym): Update.
55
56 2018-06-01  Tom Tromey  <tom@tromey.com>
57
58         * valops.c (enum_constant_from_type, value_namespace_elt)
59         (value_maybe_namespace_elt): Update.
60         * valarith.c (find_size_for_pointer_math): Update.
61         * target-descriptions.c (make_gdb_type): Update.
62         * symmisc.c (print_symbol): Update.
63         * stabsread.c (define_symbol, read_type)
64         (complain_about_struct_wipeout, add_undefined_type)
65         (cleanup_undefined_types_1): Update.
66         * rust-lang.c (rust_tuple_type_p, rust_slice_type_p)
67         (rust_range_type_p, val_print_struct, rust_print_struct_def)
68         (rust_internal_print_type, rust_composite_type)
69         (rust_evaluate_funcall, rust_evaluate_subexp)
70         (rust_inclusive_range_type_p): Update.
71         * python/py-type.c (typy_get_tag): Update.
72         * p-typeprint.c (pascal_type_print_base): Update.
73         * mdebugread.c (parse_symbol, parse_type): Update.
74         * m2-typeprint.c (m2_long_set, m2_record_fields, m2_enum):
75         Update.
76         * guile/scm-type.c (gdbscm_type_tag): Update.
77         * go-lang.c (sixg_string_p): Update.
78         * gnu-v3-abi.c (build_gdb_vtable_type, build_std_type_info_type):
79         Update.
80         * gdbtypes.h (struct main_type) <tag_name>: Remove.
81         (TYPE_TAG_NAME): Remove.
82         * gdbtypes.c (type_name_no_tag): Simplify.
83         (check_typedef, check_types_equal, recursive_dump_type)
84         (copy_type_recursive, arch_composite_type): Update.
85         * f-typeprint.c (f_type_print_base): Update.  Print "Type" prefix
86         in summary mode when needed.
87         * eval.c (evaluate_funcall): Update.
88         * dwarf2read.c (fixup_go_packaging, read_structure_type)
89         (process_structure_scope, read_enumeration_type)
90         (read_namespace_type, read_module_type, determine_prefix): Update.
91         * cp-support.c (inspect_type): Update.
92         * coffread.c (process_coff_symbol, decode_base_type): Update.
93         * c-varobj.c (c_is_path_expr_parent): Update.
94         * c-typeprint.c (c_type_print_base_struct_union): Update.
95         (c_type_print_base_1): Update.  Print struct/class/union/enum in
96         summary when using C language.
97         * ax-gdb.c (gen_struct_ref, gen_namespace_elt)
98         (gen_maybe_namespace_elt): Update.
99         * ada-lang.c (ada_type_name): Simplify.
100         (empty_record, ada_template_to_fixed_record_type_1)
101         (template_to_static_fixed_type)
102         (to_record_with_fixed_variant_part, ada_check_typedef): Update.
103
104 2018-06-01  Tom Tromey  <tom@tromey.com>
105
106         * dwarf2read.c (dwarf2_compute_name): Pass CU's language to
107         c_print_type.
108         * c-typeprint.c (c_print_type_1): Add "language" parameter.
109         (c_print_type): Update.
110         (c_print_type): New overload.
111         (c_type_print_varspec_prefix, c_type_print_args)
112         (c_type_print_varspec_suffix, c_print_type_no_offsets)
113         (c_type_print_base_struct_union, c_type_print_base_1)
114         (cp_type_print_method_args): Add "language" parameter.
115         (c_type_print_base): Update.
116         * c-lang.h (c_print_type): Add new overload.
117
118 2018-06-01  Tom Tromey  <tom@tromey.com>
119
120         * typeprint.h (c_type_print_varspec_suffix): Don't declare.
121         * c-typeprint.c (c_type_print_varspec_suffix): Now static.
122
123 2018-06-01  Alan Hayward  <alan.hayward@arm.com>
124
125         * aarch64-tdep.c (aarch64_sve_register_names): New const
126         var.
127         * arch/aarch64.h (enum aarch64_regnum): Add SVE entries.
128         (AARCH64_SVE_Z_REGS_NUM): New define.
129         (AARCH64_SVE_P_REGS_NUM): Likewise.
130         (AARCH64_SVE_NUM_REGS): Likewise.
131
132 2018-05-31  Uros Bizjak  <ubizjak@gmail.com>
133
134         * nat/linux-ptrace.h [__alpha__]
135         (GDB_ARCH_IS_TRAP_BRKPT, GDB_ARCH_IS_TRAP_HWBKPT): Remove
136         definitions.
137
138 2018-05-31  Maciej W. Rozycki  <macro@mips.com>
139
140         * arch-utils.c (gdbarch_info_fill): Set `default_byte_order' to
141         the endianness selected.
142         * NEWS: Document `set endian auto' mode operation update.
143
144 2018-05-31  Alan Hayward  <alan.hayward@arm.com>
145
146         * Makefile.in: Add new header.
147         * gdb/arch/aarch64.h (sve_vg_from_vl): New macro.
148         (sve_vl_from_vg): Likewise.
149         (sve_vq_from_vl): Likewise.
150         (sve_vl_from_vq): Likewise.
151         (sve_vq_from_vg): Likewise.
152         (sve_vg_from_vq): Likewise.
153         * configure.nat: Add new c file.
154         * nat/aarch64-sve-linux-ptrace.c: New file.
155         * nat/aarch64-sve-linux-ptrace.h: New file.
156
157 2018-05-31  Alan Hayward  <alan.hayward@arm.com>
158
159         * aarch64-linux-nat.c (aarch64_linux_read_description):
160         Add parmeter zero.
161         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
162         Likewise.
163         * aarch64-tdep.c (tdesc_aarch64_list): Add.
164         (aarch64_read_description): Use VQ to index tdesc_aarch64_list.
165         (aarch64_gdbarch_init): Add parmeter zero.
166         * aarch64-tdep.h (aarch64_read_description): Add VQ parmeter.
167         * arch/aarch64.c (aarch64_create_target_description): Check VQ.
168         * arch/aarch64.h (aarch64_create_target_description): Add VQ.
169         parmeter.
170         * doc/gdb.texinfo: Describe SVE feature
171         * features/aarch64-sve.c: New file.
172
173 2018-05-31  Omair Javaid  <omair.javaid@linaro.org>
174
175         PR gdb/23210
176         * gdbarch.sh (significant_addr_bit): Default to zero when
177         not set by target architecture.
178         * gdbarch.c: Re-generated.
179         * utils.c (address_significant): Update.
180
181 2018-05-30  Joel Brobecker  <brobecker@adacore.com>
182
183         * stack.c (func_command): Remove trailing newline in call to error.
184
185 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
186
187         * regcache.h (regcache_raw_collect): Remove, update callers to
188         use regcache::raw_collect.
189         * regcache.c (regcache_raw_collect): Remove.
190
191 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
192
193         * regcache.h (regcache_raw_supply): Remove, update callers to
194         use detached_regcache::raw_supply.
195         * regcache.c (regcache_raw_supply): Remove.
196
197 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
198
199         * regcache.h (regcache_cooked_write_part): Remove, update
200         callers to use regcache::cooked_write_part.
201         * regcache.c (regcache_cooked_write_part): Remove.
202
203 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
204
205         * regcache.h (regcache_cooked_read_part): Remove, update callers
206         to use readable_regcache::cooked_read_part.
207         * regcache.c (regcache_cooked_read_part): Remove.
208
209 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
210
211         * regcache.h (regcache_cooked_read_value): Remove, update
212         callers to use readable_regcache::cooked_read_value.
213         * regcache.c (regcache_cooked_read_value): Remove.
214
215 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
216
217         * regcache.h (regcache_cooked_write): Remove, update callers to
218         use regcache::cooked_write.
219         * regcache.c (regcache_cooked_write): Remove.
220
221 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
222
223         * regcache.h (regcache_invalidate): Remove, update callers to
224         use detached_regcache::invalidate instead.
225         * regcache.c (regcache_invalidate): Remove.
226
227 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
228
229         * regcache.h (regcache_raw_write_part): Remove, update callers
230         to use regcache::raw_write_part instead.
231         * regcache.c (regcache_raw_write_part): Remove.
232
233 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
234
235         * regcache.h (regcache_raw_read_part): Remove, update callers to
236         use readable_regcache::raw_read_part instead.
237         * regcache.c (regcache_raw_read_part): Remove.
238
239 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
240
241         * regcache.h (regcache_cooked_read): Remove, update callers to
242         use readable_regcache::cooked_read instead.
243         * regcache.c (regcache_cooked_read): Remove.
244
245 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
246
247         * regcache.h (regcache_raw_write): Remove, update callers to use
248         regcache::raw_write instead.
249         * regcache.c (regcache_raw_write): Remove.
250
251 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
252
253         * regcache.h (regcache_raw_read): Remove, update callers to use
254         readable_regcache::raw_read instead.
255         * regcache.c (regcache_raw_read): Remove.
256
257 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
258
259         * regcache.h (regcache_raw_update): Remove, update callers to
260         use readable_regcache::raw_update instead.
261         * regcache.c (regcache_raw_update): Remove.
262
263 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
264
265         * regcache.h (regcache_register_status): Remove, update callers
266         to use reg_buffer::get_register_status directly instead.
267         * regcache.c (regcache_register_status): Remove.
268
269 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
270
271         * regcache.h (regcache_get_ptid): Remove, update all callers to
272         call regcache::ptid instead.
273         * regcache.c (regcache_get_ptid): Remove.
274
275 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
276
277         * Makefile.in (ALL_TARGET_OBS): Add or1k-tdep.o.
278
279 2018-05-30  Pedro Alves  <palves@redhat.com>
280
281         * common/common-exceptions.h (exception_rethrow): Use
282         ATTRIBUTE_NORETURN.
283
284 2018-05-29  Simon Marchi  <simon.marchi@polymtl.ca>
285
286         * breakpoint.c (print_solib_event, check_status_catch_solib):
287         Remove struct keyword in range-based for loops.
288         * dbxread.c (find_corresponding_bincl_psymtab): Likewise.
289         * dwarf2read.c (compute_delayed_physnames, rust_union_quirks);
290         Likewise.
291         * linespec.c (find_superclass_methods, search_minsyms_for_name):
292         Likewise.
293         * symfile.c (addr_info_make_relative): Likewise.
294         * thread.c (value_in_thread_stack_temporaries): Likewise.
295
296 2018-05-29  Weimin Pan  <weimin.pan@oracle.com>
297
298         * minsyms.h (lookup_minimal_symbol_and_objfile): Remove declaration.
299         * minsyms.c (lookup_minimal_symbol_and_objfile): Remove definition.
300         * coff-pe-read.c (add_pe_forwarded_sym): Replace
301         lookup_minimal_symbol_and_objfile with lookup_bound_minimal_symbol.
302         * glibc-tdep.c (glibc_skip_solib_resolver): Likewise.
303         * jit.c (jit_breakpoint_re_set_internal): Likewise.
304         * printcmd.c (info_address_command): Likewise.
305
306 2018-05-29  Tom Tromey  <tom@tromey.com>
307
308         * windows-nat.c (handle_exception): Update fall-through comment.
309
310 2018-05-29  Tom Tromey  <tom@tromey.com>
311
312         * progspace.h (so_list_ptr): Remove typedef.  Don't declare VEC.
313         (struct program_space) <added_solibs>: Now a std::vector.
314         * breakpoint.c (print_solib_event): Update.
315         (check_status_catch_solib): Update.
316         * progspace.c (clear_program_space_solib_cache): Update.
317         * solib.c (update_solib_list): Update.
318
319 2018-05-29  Tom Tromey  <tom@tromey.com>
320
321         * python/py-type.c (typy_richcompare): Update.
322         * guile/scm-type.c (tyscm_equal_p_type_smob): Update.
323         * gdbtypes.h (types_deeply_equal): Return bool.
324         (types_equal): Likewise.
325         * gdbtypes.c (type_equality_entry_d): Remove typedef.  Don't
326         declare VEC.
327         (check_types_equal): Change worklist to std::vector.  Return
328         bool.
329         (struct type_equality_entry): Add constructor.
330         (compare_maybe_null_strings): Return bool.
331         (check_types_worklist): Return bool.  Change worklist to
332         std::vector.
333         (types_deeply_equal): Use std::vector.
334         (types_equal): Return bool.
335         (compare_maybe_null_strings): Simplify.
336
337 2018-05-29  Tom Tromey  <tom@tromey.com>
338
339         * record-btrace.c (tp_t): Remove typedef.  Don't declare VEC.
340
341 2018-05-29  Tom Tromey  <tom@tromey.com>
342
343         * objc-lang.h: Don't include cp-support.h.
344         * common/gdb_vecs.h (const_char_ptr): Remove typedef.  Don't
345         declare VEC.
346
347 2018-05-27  Tom Tromey  <tom@tromey.com>
348
349         * Makefile.in (DEPFILES): Don't reference REMOTE_OBS.
350
351 2018-05-25  Tom Tromey  <tom@tromey.com>
352
353         * value.c (value::location): Initialize.
354
355 2018-05-25  Tom Tromey  <tom@tromey.com>
356
357         * dbxread.c (init_bincl_list): Remove.
358         (bincl_list): Now a std::vector.
359         (bincls_allocated, next_bincl): Remove.
360         (free_bincl_list, do_free_bincl_list_cleanup)
361         (make_cleanup_free_bincl_list): Remove.
362         (dbx_read_symtab, elfstab_build_psymtabs): Use scoped_restore,
363         unique_xmalloc_ptr.
364         (find_corresponding_bincl_psymtab, read_dbx_symtab): Update.
365         (struct header_file_location): Add constructor.
366         (add_bincl_to_list): Remove.
367
368 2018-05-25  Tom Tromey  <tom@tromey.com>
369
370         * tui/tui.c (tui_enable): Update.
371         * mi/mi-interp.c (mi_interp::init): Update.
372         * interps.h (class interp) <name>: New method.
373         <m_name>: Rename from name.
374         (~scoped_restore_interp): Update.
375         * interps.c (interp::interp): Update.
376         (interp_add, interp_set, interp_lookup_existing)
377         (current_interp_named_p): Update.
378
379 2018-05-25  Tom Tromey  <tom@tromey.com>
380
381         * interps.c (interp_name): Remove.
382         * mi/mi-interp.c (mi_interp::init): Update.
383         * interps.h (interp_name): Remove.
384         (~scoped_restore_interp): Update.
385         * tui/tui.c (tui_enable): Update.
386
387 2018-05-25  Tom Tromey  <tom@tromey.com>
388
389         * utils.c (fputs_maybe_filtered): Update.
390         * linespec.c (decode_line_full): Update.
391         * mi/mi-interp.c (mi_on_normal_stop_1, mi_tsv_modified)
392         (mi_print_breakpoint_for_event, mi_solib_loaded)
393         (mi_solib_unloaded, mi_command_param_changed, mi_memory_changed)
394         (mi_user_selected_context_changed): Update.
395         * mi/mi-main.c (mi_execute_command): Update.
396         * cli/cli-script.c (execute_control_command): Update.
397         * python/python.c (execute_gdb_command): Update.
398         * solib.c (info_sharedlibrary_command): Update.
399         * interps.c (interp_ui_out): Remove.
400         * interps.h (interp_ui_out): Remove.
401
402 2018-05-25  Tom Tromey  <tom@tromey.com>
403
404         * tui/tui-interp.c (as_tui_interp): Use dynamic_cast.
405         * mi/mi-interp.c (as_mi_interp): Use dynamic_cast.
406         * cli/cli-interp.c (as_cli_interp): Use dynamic_cast.
407
408 2018-05-25  Tom Tromey  <tom@tromey.com>
409
410         * cli/cli-interp.c (safe_execute_command): Use scoped_restore.
411         * interps.c (interp_exec): Use scoped_restore.
412
413 2018-05-25  Tom Tromey  <tom@tromey.com>
414
415         * remote.c (remote_target::remote_file_get): Use
416         gdb::byte_vector.
417         (remote_target::remote_file_put): Likewise.
418
419 2018-05-25  Tom Tromey  <tom@tromey.com>
420
421         * coff-pe-read.c (struct read_pe_section_data) <section_name>: Now
422         a std::string.
423         (get_pe_section_index, add_pe_exported_sym): Update.
424         (read_pe_exported_syms): Use gdb::def_vector.
425
426 2018-05-25  Tom Tromey  <tom@tromey.com>
427
428         * frame.c (remove_prev_frame): Remove.
429         (get_prev_frame_if_no_cycle): Use TRY/CATCH.
430
431 2018-05-25  Maciej W. Rozycki  <macro@mips.com>
432
433         * mips-linux-tdep.h (mips_supply_fpregset, mips_fill_fpregset):
434         Remove prototypes.
435         * mips-linux-nat.c (supply_fpregset): Always call
436         `mips64_supply_fpregset' rather than `mips_supply_fpregset'.
437         (fill_fpregset): Always call `mips64_fill_fpregset' rather than
438         `mips_fill_fpregset'.
439         * mips-linux-tdep.c (mips_supply_fpregset)
440         (mips_supply_fpregset_wrapper, mips_fill_fpregset)
441         (mips_fill_fpregset_wrapper): Remove functions.
442         (mips64_supply_fpregset, mips64_fill_fpregset): Update comments.
443         (mips_linux_fpregset): Remove variable.
444         (mips_linux_iterate_over_regset_sections): Use
445         `mips64_linux_fpregset' in place of `mips_linux_fpregset'.
446         (mips_linux_o32_sigframe_init): Remove comment.
447
448 2018-05-25  Pedro Alves  <palves@redhat.com>
449
450         * remote.c (struct vCont_action_support, MAXTHREADLISTRESULTS)
451         (struct readahead_cache, struct packet_reg, struct
452         remote_arch_state, class remote_state): Move higher up in the
453         file.
454         (remote_target::m_remote_state): Now an object instead of a pointer.
455         (remote_target::get_remote_state): Adjust.
456
457 2018-05-24  Andrew Burgess  <andrew.burgess@embecosm.com>
458
459         * stack.c (select_and_print_frame): Delete.
460         (struct function_bounds): Move struct within function.
461         (func_command): Most content moved into new function
462         find_frame_for_function, use new function, print result, add
463         function comment.
464         (find_frame_for_function): New function, now returns a result.
465
466 2018-05-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
467
468         * stack.c (iterate_over_block_arg_vars): Fix comment.
469         (print_frame_arg_vars): Pass stream in cb_data, not gdb_stdout.
470
471 2018-05-24  Andrew Burgess  <andrew.burgess@embecosm.com>
472
473         PR gdb/23203
474         * frame.c
475         (scoped_restore_selected_frame::scoped_restore_selected_frame):
476         Define.
477         (scoped_restore_selected_frame::~scoped_restore_selected_frame):
478         Define.
479         * frame.h (class scoped_restore_selected_frame): New class.
480         * stack.c (print_frame_local_vars): Remove catching and rethrowing
481         of any exception, use scoped_restore_selected_frame to restore the
482         frame instead.
483
484 2018-05-24  Pedro Alves  <palves@redhat.com>
485
486         * darwin-nat.h (darwin_nat_target::create_inferior): Mark with
487         override.
488
489 2018-05-23  Tom Tromey  <tom@tromey.com>
490
491         * complaints.c (struct complaints): Remove.
492         (symfile_complaint_book): Remove.
493         (series): New global.
494         (complaint_internal): Update.
495         (clear_complaints): Update.
496
497 2018-05-23  Tom Tromey  <tom@tromey.com>
498
499         * complaints.c (counters): New global.
500         (struct complain): Remove.
501         (struct complaints) <root>: Remove.
502         (complaint_sentinel): Remove.
503         (symfile_complaint_book): Update.
504         (find_complaint) Remove.
505         (complaint_internal, clear_complaints): Update.
506
507 2018-05-23  Tom Tromey  <tom@tromey.com>
508
509         * complaints.c (struct complain) <file, line>: Remove.
510         (find_complaint): Remove file, line parameters.
511         (complaint_internal): Update.
512
513 2018-05-23  Tom Tromey  <tom@tromey.com>
514
515         * complaints.c (vcomplaint): Remove.
516         (complaint_internal) Merge in contents of vcomplaint.
517
518 2018-05-23  Tom Tromey  <tom@tromey.com>
519
520         * complaints.c (struct complaints) <explanation>: Remove.
521         (symfile_explanations): Remove.
522         (symfile_complaint_book): Update.
523         (vcomplaint): Update.
524         (struct explanation): Remove.
525
526 2018-05-23  Tom Tromey  <tom@tromey.com>
527
528         * complaints.c (symfile_complaints): Remove.
529         (complaint_internal): Remove "complaints" parameter.
530         (clear_complaints, vcomplaint): Remove "c" parameter.
531         (get_complaints): Remove.
532         * dwarf2read.c (dwarf2_statement_list_fits_in_line_number_section_complaint)
533         (dwarf2_debug_line_missing_file_complaint)
534         (dwarf2_debug_line_missing_end_sequence_complaint)
535         (dwarf2_complex_location_expr_complaint)
536         (dwarf2_const_value_length_mismatch_complaint)
537         (dwarf2_section_buffer_overflow_complaint)
538         (dwarf2_macro_malformed_definition_complaint)
539         (dwarf2_invalid_attrib_class_complaint)
540         (create_addrmap_from_index, dw2_symtab_iter_next)
541         (dw2_expand_marked_cus)
542         (dw2_debug_names_iterator::find_vec_in_debug_names)
543         (dw2_debug_names_iterator::next, dw2_debug_names_iterator::next)
544         (create_debug_type_hash_table, init_cutu_and_read_dies)
545         (partial_die_parent_scope, add_partial_enumeration)
546         (skip_one_die, fixup_go_packaging, quirk_rust_enum, process_die)
547         (dwarf2_compute_name, dwarf2_physname, read_namespace_alias)
548         (read_import_statement, read_file_scope, create_dwo_cu_reader)
549         (create_cus_hash_table, create_dwp_hash_table)
550         (inherit_abstract_dies, read_func_scope, read_call_site_scope)
551         (dwarf2_rnglists_process, dwarf2_ranges_process)
552         (dwarf2_add_type_defn, dwarf2_attach_fields_to_type)
553         (dwarf2_add_member_fn, get_alignment, maybe_set_alignment)
554         (handle_struct_member_die, process_structure_scope)
555         (read_array_type, read_common_block, read_module_type)
556         (read_tag_pointer_type, read_typedef, read_base_type)
557         (read_subrange_type, load_partial_dies, partial_die_info::read)
558         (partial_die_info::read, partial_die_info::read)
559         (partial_die_info::read, read_checked_initial_length_and_offset)
560         (dwarf2_string_attr, read_formatted_entries)
561         (dwarf_decode_line_header)
562         (lnp_state_machine::check_line_address, dwarf_decode_lines_1)
563         (new_symbol, dwarf2_const_value_attr, lookup_die_type)
564         (read_type_die_1, determine_prefix, dwarf2_get_ref_die_offset)
565         (dwarf2_get_attr_constant_value, dwarf2_fetch_constant_bytes)
566         (get_signatured_type, get_DW_AT_signature_type)
567         (decode_locdesc, file_file_name, consume_improper_spaces)
568         (skip_form_bytes, skip_unknown_opcode, dwarf_parse_macro_header)
569         (dwarf_decode_macro_bytes, dwarf_decode_macros)
570         (dwarf2_symbol_mark_computed, set_die_type)
571         (read_attribute_value): Update.
572         * stap-probe.c (handle_stap_probe, get_stap_base_address):
573         Update.
574         * dbxread.c (unknown_symtype_complaint)
575         (lbrac_mismatch_complaint, repeated_header_complaint)
576         (set_namestring, function_outside_compilation_unit_complaint)
577         (read_dbx_symtab, process_one_symbol): Update.
578         * gdbtypes.c (stub_noname_complaint): Update.
579         * windows-nat.c (handle_unload_dll): Update.
580         * coffread.c (coff_symtab_read, enter_linenos, decode_type)
581         (decode_base_type): Update.
582         * xcoffread.c (bf_notfound_complaint, ef_complaint)
583         (eb_complaint, record_include_begin, record_include_end)
584         (enter_line_range, xcoff_next_symbol_text, read_xcoff_symtab)
585         (process_xcoff_symbol, read_symbol)
586         (function_outside_compilation_unit_complaint)
587         (scan_xcoff_symtab): Update.
588         * machoread.c (macho_symtab_read, macho_add_oso_symfile): Update.
589         * buildsym.c (finish_block_internal, make_blockvector)
590         (end_symtab_get_static_block, augment_type_symtab): Update.
591         * dtrace-probe.c (dtrace_process_dof)
592         (dtrace_static_probe_ops::get_probes): Update.
593         * complaints.h (struct complaint): Don't declare.
594         (symfile_complaints): Remove.
595         (complaint_internal): Remove "complaints" parameter.
596         (complaint): Likewise.
597         (clear_complaints): Likewise.
598         * symfile.c (syms_from_objfile_1, finish_new_objfile)
599         (reread_symbols): Update.
600         * dwarf2-frame.c (dwarf2_restore_rule, execute_cfa_program)
601         (dwarf2_frame_cache, decode_frame_entry): Update.
602         * dwarf2loc.c (dwarf_reg_to_regnum): Update.
603         * objc-lang.c (lookup_objc_class, lookup_child_selector)
604         (info_selectors_command): Update.
605         * macrotab.c (macro_include, check_for_redefinition)
606         (macro_undef): Update.
607         * objfiles.c (filter_overlapping_sections): Update.
608         * stabsread.c (invalid_cpp_abbrev_complaint)
609         (reg_value_complaint, stabs_general_complaint, dbx_lookup_type)
610         (define_symbol, error_type, read_type, rs6000_builtin_type)
611         (stabs_method_name_from_physname, read_member_functions)
612         (read_cpp_abbrev, read_baseclasses, read_tilde_fields)
613         (attach_fields_to_type, complain_about_struct_wipeout)
614         (read_range_type, read_args, common_block_start)
615         (common_block_end, cleanup_undefined_types_1, scan_file_globals):
616         Update.
617         * mdebugread.c (index_complaint, unknown_ext_complaint)
618         (basic_type_complaint, bad_tag_guess_complaint)
619         (bad_rfd_entry_complaint, unexpected_type_code_complaint)
620         (reg_value_complaint, parse_symbol, parse_type, upgrade_type)
621         (parse_procedure, parse_lines)
622         (function_outside_compilation_unit_complaint)
623         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref)
624         (bad_tag_guess_complaint, reg_value_complaint): Update.
625         * cp-support.c (demangled_name_complaint): Update.
626         * macroscope.c (sal_macro_scope): Update.
627         * dwarf-index-write.c (class debug_names): Update.
628
629 2018-05-23  Tom Tromey  <tom@tromey.com>
630
631         * complaints.c (clear_complaints): Remove "noisy" parameter.
632         * complaints.h (clear_complaints): Update.
633         * symfile.c (syms_from_objfile_1, finish_new_objfile)
634         (reread_symbols): Update.
635
636 2018-05-23  Tom Tromey  <tom@tromey.com>
637
638         * complaints.c (enum complaint_series): Remove FIRST_MESSAGE,
639         SUBSEQUENT_MESSAGE.
640         (vcomplaint, clear_complaints): Update.
641         (symfile_explanations): Remove some messages.
642
643 2018-05-23  Tom Tromey  <tom@tromey.com>
644
645         * complaints.c (internal_complaint): Remove.
646         * complaints.h (internal_complaint): Remove.
647
648 2018-05-22  Maciej W. Rozycki  <macro@mips.com>
649
650         * i387-tdep.c (i387_collect_xsave): Make `i' unsigned.
651
652 2018-05-22  Pedro Alves  <palves@redhat.com>
653
654         * remote-fileio.c (remote_fileio_reply, remote_fileio_ioerror)
655         (remote_fileio_badfd, remote_fileio_return_errno)
656         (remote_fileio_return_success, remote_fileio_func_open)
657         (remote_fileio_func_open, remote_fileio_func_close)
658         (remote_fileio_func_read, remote_fileio_func_write)
659         (remote_fileio_func_lseek, remote_fileio_func_rename)
660         (remote_fileio_func_unlink, remote_fileio_func_stat)
661         (remote_fileio_func_fstat, remote_fileio_func_gettimeofday)
662         (remote_fileio_func_isatty, remote_fileio_func_system): Add
663         remote_target parameter.
664         (remote_fio_func_map) <func>: Add remote_target parameter.
665         (do_remote_fileio_request, remote_fileio_request):
666         * remote-fileio.h (remote_fileio_request):
667         * remote-notif.c (remote_notif_ack, remote_notif_parse, ): Add
668         remote_target parameter.
669         (remote_notif_process, handle_notification): Adjust to pass down
670         the remote.
671         (remote_notif_state_allocate): Add remote_target parameter.  Save
672         it.
673         * remote-notif.h (struct remote_target): Forward declare.
674         (struct notif_client) <parse, ack, can_get_pending_events>: Add
675         remote_target parameter.
676         (struct remote_notif_state) <remote>: New field.
677         (remote_notif_ack, remote_notif_parse): Add remote_target
678         parameter.
679         (remote_notif_state_allocate, remote_notif_state_allocate): Add
680         remote_target parameter.
681         * remote.c (OPAQUETHREADBYTES, threadref, gdb_ext_thread_info)
682         (threads_listing_context, rmt_thread_action, protocol_feature)
683         (packet_reg, stop_reply, stop_reply_p, enum packet_support)
684         (packet_result, struct threads_listing_context, remote_state):
685         Move definitions and declarations higher up.
686         (remote_target) <~remote_target>: Declare.
687         (remote_download_command_source, remote_file_put, remote_file_get)
688         (remote_file_delete, remote_hostio_pread, remote_hostio_pwrite)
689         (remote_hostio_pread_vFile, remote_hostio_send_command)
690         (remote_hostio_set_filesystem, remote_hostio_open)
691         (remote_hostio_close, remote_hostio_unlink, remote_state)
692         (get_remote_state, get_remote_packet_size, get_memory_packet_size)
693         (get_memory_write_packet_size, get_memory_read_packet_size)
694         (append_pending_thread_resumptions, remote_detach_1)
695         (append_resumption, remote_resume_with_vcont)
696         (add_current_inferior_and_thread, wait_ns, wait_as)
697         (process_stop_reply, remote_notice_new_inferior)
698         (process_initial_stop_replies, remote_add_thread)
699         (btrace_sync_conf, remote_btrace_maybe_reopen)
700         (remove_new_fork_children, kill_new_fork_children)
701         (discard_pending_stop_replies, stop_reply_queue_length)
702         (check_pending_events_prevent_wildcard_vcont)
703         (discard_pending_stop_replies_in_queue, stop_reply)
704         (remote_notif_remove_queued_reply, stop_reply *queued_stop_reply)
705         (peek_stop_reply, remote_parse_stop_reply, remote_stop_ns)
706         (remote_interrupt_as, remote_interrupt_ns)
707         (remote_get_noisy_reply, remote_query_attached)
708         (remote_add_inferior, remote_current_thread, get_current_thread)
709         (set_thread, set_general_thread, set_continue_thread)
710         (set_general_process, write_ptid)
711         (remote_unpack_thread_info_response, remote_get_threadinfo)
712         (parse_threadlist_response, remote_get_threadlist)
713         (remote_threadlist_iterator, remote_get_threads_with_ql)
714         (remote_get_threads_with_qxfer)
715         (remote_get_threads_with_qthreadinfo, extended_remote_restart)
716         (get_offsets, remote_check_symbols, remote_supported_packet)
717         (remote_query_supported, remote_packet_size)
718         (remote_serial_quit_handler, remote_detach_pid)
719         (remote_vcont_probe, remote_resume_with_hc)
720         (send_interrupt_sequence, interrupt_query)
721         (remote_notif_get_pending_events, fetch_register_using_p)
722         (send_g_packet, process_g_packet, fetch_registers_using_g)
723         (store_register_using_P, store_registers_using_G)
724         (set_remote_traceframe, check_binary_download)
725         (remote_write_bytes_aux, remote_write_bytes, remote_read_bytes_1)
726         (remote_xfer_live_readonly_partial, remote_read_bytes)
727         (remote_send_printf, remote_flash_write, readchar)
728         (remote_serial_write, putpkt, putpkt_binary, skip_frame)
729         (read_frame, getpkt, getpkt_or_notif_sane_1, getpkt_sane)
730         (getpkt_or_notif_sane, remote_vkill, remote_kill_k)
731         (extended_remote_disable_randomization, extended_remote_run)
732         (send_environment_packet, extended_remote_environment_support)
733         (extended_remote_set_inferior_cwd, remote_write_qxfer)
734         (remote_read_qxfer, push_stop_reply, vcont_r_supported)
735         (packet_command): Now methods of ...
736         (remote_target): ... this class.
737         (m_remote_state) <remote_target>: New field.
738         (struct remote_state) <stop_reply_queue,
739         remote_async_inferior_event_token, wait_forever_enabled_p>: New
740         fields.
741         (remote_state::remote_state): Allocate stop_reply_queue.
742         (remote_state): Delete global.
743         (get_remote_state_raw): Delete.
744         (remote_target::get_remote_state): Allocate m_remote_state on
745         demand.
746         (get_current_remote_target): New.
747         (remote_ops, extended_remote_ops): Delete.
748         (wait_forever_enabled_p, remote_async_inferior_event_token):
749         Delete, moved to struct remote_state.
750         (remote_target::close): Delete self.  Destruction bits split to
751         ...
752         (remote_target::~remote_target): ... this.
753         (show_memory_packet_size): Adjust to use
754         get_current_remote_target.
755         (struct protocol_feature) <func>: Add remote_target parameter.
756         All callers adjusted.
757         (curr_quit_handler_target): New.
758         (remote_serial_quit_handler): Reimplement.
759         (remote_target::open_1): Adjust to use get_current_remote_target.
760         Heap-allocate remote_target/extended_remote_target instances.
761         (vcont_builder::vcont_builder): Add remote_target parameter, and
762         save it in m_remote.  All callers adjusted.
763         (vcont_builder::m_remote): New field.
764         (vcont_builder::restart, vcont_builder::flush)
765         (vcont_builder::push_action): Use it.
766         (remote_target::commit_resume): Use it.
767         (struct queue_iter_param) <remote>: New field.
768         (remote_target::remove_new_fork_children): Fill in 'remote' field.
769         (check_pending_event_prevents_wildcard_vcont_callback_data): New.
770         (check_pending_event_prevents_wildcard_vcont_callback)
771         (remote_target::check_pending_events_prevent_wildcard_vcont)
772         (remote_target::discard_pending_stop_replies)
773         (remote_target::discard_pending_stop_replies_in_queue)
774         (remote_target::remote_notif_remove_queued_reply): Fill in
775         'remote' field.
776         (remote_notif_get_pending_events): New.
777         (remote_target::readchar, remote_target::remote_serial_write):
778         Save/restore curr_quit_handler_target.
779         (putpkt): New.
780         (kill_new_fork_children): Fill in 'remote' field.
781         (packet_command): Use get_current_remote_target, defer to
782         remote_target method of same name.
783         (scoped_remote_fd::scoped_remote_fd): Add 'remote_target'
784         parameter, and save it in m_remote.  All callers adjusted.
785         (scoped_remote_fd::release): Use m_remote.
786         (scoped_remote_fd::m_remote): New field.
787         (remote_file_put, remote_file_get, remote_file_delete): Use
788         get_current_remote_target, defer to remote_target method of same
789         name.
790         (remote_btrace_reset): Add remote_state paremeter.  Update all
791         callers.
792         (remote_async_inferior_event_handler). Pass down 'data'.
793         (remote_new_objfile): Use get_current_remote_target.
794         (remote_target::vcont_r_supported): New.
795         (set_range_stepping): Use get_current_remote_target and
796         remote_target::vcont_r_supported.
797         (_initialize_remote): Don't allocate 'remote_state' and
798         'stop_reply_queue' globals.
799         * remote.h (struct remote_target): Forward declare.
800         (getpkt, putpkt, remote_notif_get_pending_events): Add
801         'remote_target' parameter.
802
803 2018-05-22  Pedro Alves  <palves@redhat.com>
804
805         * remote.c (vcont_builder): Now a class.  Make all data members
806         private.
807         (vcont_builder) <vcont_builder, restart, flush, push_action>:
808         Declare methods.
809         (vcont_builder_restart): Rename to ...
810         (vcont_builder::restart): ... this.
811         (vcont_builder_flush): Rename to ...
812         (vcont_builder::flush): ... this.
813         (vcont_builder_push_action): Rename to ...
814         (vcont_builder::push_action): ... this.
815         (remote_target::commit_resume): Adjust.
816
817 2018-05-22  Pedro Alves  <palves@redhat.com>
818
819         * remote.c (DEFAULT_MAX_MEMORY_PACKET_SIZE): Rename to ...
820         (DEFAULT_MAX_MEMORY_PACKET_SIZE_FIXED): ... this.
821         (get_fixed_memory_packet_size): New.
822         (get_memory_packet_size): Use it.
823         (set_memory_packet_size): Don't override the config size with
824         DEFAULT_MAX_MEMORY_PACKET_SIZE.
825         (show_memory_packet_size): Use get_fixed_memory_packet_size.
826         Don't refer to get_memory_packet_size if not connected to a remote
827         target.  Show "(default)" if configured size is 0.
828
829 2018-05-22  Pedro Alves  <palves@redhat.com>
830
831         * remote.c (remote_target::mourn_inferior): Move
832         discard_pending_stop_replies call here from ...
833         (_initialize_remote): ... here.
834
835 2018-05-22  Pedro Alves  <palves@redhat.com>
836
837         * remote.c (compare_section_command): Remove set_general_process
838         call.
839
840 2018-05-22  Pedro Alves  <palves@redhat.com>
841
842         * remote.c (struct packet_reg, struct remote_arch_state):
843         Move higher up in the file.
844         (remote_state) <m_arch_states>: Store remote_arch_state values
845         instead of remote_arch_state pointers.
846         (remote_state::get_remote_arch_state): Adjust.
847
848 2018-05-22  Pedro Alves  <palves@redhat.com>
849
850         * remote.c: Include <unordered_map>.
851         (remote_state): Now a class.
852         (remote_state) <get_remote_arch_state>: Declare method.
853         <get_remote_arch_state>: New field.
854         (remote_arch_state) <remote_arch_state>: Declare ctor.
855         <regs>: Now a unique_ptr.
856         (remote_gdbarch_data_handle): Delete.
857         (get_remote_arch_state): Delete.
858         (remote_state::get_remote_arch_state): New.
859         (get_remote_state): Adjust to call remote_state's
860         get_remote_arch_state method.
861         (init_remote_state): Delete, bits factored out to ...
862         (remote_arch_state::remote_arch_state): ... this new method.
863         (get_remote_packet_size, get_memory_packet_size)
864         (process_g_packet, remote_target::fetch_registers)
865         (remote_target::prepare_to_store, store_registers_using_G)
866         (remote_target::store_registers, remote_target::get_trace_status):
867         Adjust to call remote_state's method.
868         (_initialize_remote): Remove reference to
869         remote_gdbarch_data_handle.
870
871 2018-05-22  Pedro Alves  <palves@redhat.com>
872
873         * remote.c (struct readahead_cache) <invalidate, invalidate_fd,
874         pread>: New method declarations.
875         (remote_target::open_1): Adjust.
876         (readahead_cache_invalidate): Rename to ...
877         (readahead_cache::invalidate): ... this, and adjust to be a class
878         method.
879         (readahead_cache_invalidate_fd): Rename to ...
880         (readahead_cache::invalidate_fd): ... this, and adjust to be a
881         class method.
882         (remote_hostio_pwrite): Adjust.
883         (remote_hostio_pread_from_cache): Rename to ...
884         (readahead_cache::pread): ... this, and adjust to be a class
885         method.
886         (remote_hostio_close): Adjust.
887
888 2018-05-22  Pedro Alves  <palves@redhat.com>
889
890         * remote.c (remote_hostio_close_cleanup): Delete.
891         (class scoped_remote_fd): New.
892         (remote_file_put, remote_file_get): Use it.
893
894 2018-05-22  Pedro Alves  <palves@redhat.com>
895
896         (struct vCont_action_support): Use bool and initialize all fields.
897         (struct readahead_cache): Initialize all fields.
898         (remote_state): Use bool and initialize all fields.
899         (remote_state::remote_state, remote_state::~remote_state): New.
900         (new_remote_state): Delete.
901         (_initialize_remote): Use new to allocate remote_state.
902
903 2018-05-22  Pedro Alves  <palves@redhat.com>
904             張俊芝  <zjz@zjz.name>
905
906         PR gdb/22973
907         * c-exp.y: Include "c-support.h".
908         (parse_number, c_parse_escape, lex_one_token): Use TOLOWER instead
909         of tolower.  Use c_ident_is_alpha to scan names.
910         * c-lang.c: Include "c-support.h".
911         (convert_ucn, convert_octal, convert_hex, convert_escape): Use
912         ISXDIGIT instead of isxdigit and ISDIGIT instead of isdigit.
913         * c-support.h: New file, with bits factored out from ...
914         * cp-name-parser.y: ... this file.
915         Include "c-support.h".
916         (cp_ident_is_alpha, cp_ident_is_alnum): Deleted, moved to
917         c-support.h and renamed.
918         (symbol_end, yylex): Adjust.
919
920 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
921
922         * arch/ppc-linux-common.c (ppc_linux_has_isa205): Change the
923         parameter type to CORE_ADDR.
924         * arch/ppc-linux-common.h (ppc_linux_has_isa205): Change the
925         parameter type in declaration to CORE_ADDR.
926         * ppc-linux-tdep.c (ppc_linux_core_read_description): Call
927         target_auxv_search to get AT_HWCAP and use the result to get the
928         target description.
929         * ppc-linux-nat.c (ppc_linux_get_hwcap): Change the return type
930         to CORE_ADDR. Remove the cast of the return value to unsigned
931         long. Fix error predicate of target_auxv_search.
932         (ppc_linux_nat_target::read_description): Change the type of the
933         hwcap variable to CORE_ADDR.
934
935 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
936
937         * rs6000-tdep.c (rs6000_gdbarch_init): Assign 1 to have_dfp only
938         if the size of fpscr is larger than 32 bits.
939
940 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
941
942         * ppc-linux-tdep.c (ppc_linux_vsxregset): New function.
943         (ppc32_linux_vsxregmap): New global.
944         (ppc32_linux_vsxregset): Initialize with ppc32_linux_vsxregmap,
945         regcache_supply_regset, and regcache_collect_regset.
946         * ppc-linux-tdep.h (ppc_linux_vsxregset): Declare.
947         * ppc-linux-nat.c (supply_vsxregset, fill_vsxregset): Remove.
948         (fetch_vsx_register, store_vsx_register): Remove.
949         (fetch_vsx_registers): Add regno parameter. Get regset using
950         ppc_linux_vsxregset. Use regset to supply registers.
951         (store_vsx_registers): Add regno parameter. Get regset using
952         ppc_linux_vsxregset. Use regset to collect registers.
953         (fetch_register): Call fetch_vsx_registers instead of
954         fetch_vsx_register.
955         (store_register): Call store_vsx_registers instead of
956         store_vsx_register.
957         (fetch_ppc_registers): Call fetch_vsx_registers with -1 for the
958         new regno parameter.
959         (store_ppc_registers): Call store_vsx_registers with -1 for the
960         new regno parameter.
961         * rs6000-tdep.c (ppc_vsx_support_p, ppc_supply_vsxreget)
962         (ppc_collect_vsxregset): Remove.
963
964 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
965
966         * ppc-tdep.h (struct ppc_reg_offsets): Remove vector register
967         offset fields.
968         * ppc-fbsd-tdep.c (ppc32_fbsd_reg_offsets): Remove initializers
969         for vector register offset fields.
970         (ppc64_fbsd_reg_offsets): Likewise.
971         * ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Remove assignment
972         to vector register offset fields.
973         * ppc-obsd-tdep.c (_initialize_ppcnbsd_tdep): Remove assignment
974         to vector register offset fields.
975         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Remove assignment to
976         vector register offset fields.
977         * rs6000-aix-tdep.c (rs6000_aix32_reg_offsets): Remove
978         initializers for vector register offset fields.
979         (rs6000_aix64_reg_offsets): Likewise.
980         * rs6000-tdep.c (ppc_vrreg_offset): Remove.
981         (ppc_supply_vrregset): Remove.
982         (ppc_collect_vrregset): Remove.
983         * ppc-linux-tdep.c (ppc_linux_collect_vrregset): New function.
984         (ppc_linux_vrregset) : New function.
985         (ppc32_le_linux_vrregmap, ppc32_be_linux_vrregmap)
986         (ppc32_le_linux_vrregset, ppc32_be_linux_vrregset): New globals.
987         (ppc32_linux_vrregset): Remove.
988         (ppc_linux_iterate_over_regset_sections): Call ppc_linux_vrregset
989         and use result instead of ppc32_linux_vrregset.
990         (ppc32_linux_reg_offsets): Remove initializers for vector register
991         offset fields.
992         (ppc64_linux_reg_offsets): Likewise.
993         * ppc-linux-tdep.h (ppc_linux_vrregset): New declaration.
994         * ppc-linux-nat.c: Include regset.h.
995         (gdb_vrregset_t): Adjust comment to account for little-endian
996         mode.
997         (supply_vrregset, fill_vrregset): Remove.
998         (fetch_altivec_register, store_altivec_register): Remove.
999         (fetch_altivec_registers): Add regno parameter. Get regset using
1000         ppc_linux_vrregset. Use regset to supply registers.
1001         (store_altivec_registers): Add regno parameter. Get regset using
1002         ppc_linux_vrregset. Use regset to collect registers.
1003         (fetch_register): Call fetch_altivec_registers instead of
1004         fetch_altivec_register.
1005         (store_register): Call store_altivec_registers instead of
1006         store_altivec_register.
1007         (fetch_ppc_registers): Call fetch_altivec_registers with -1 for
1008         the new regno parameter.
1009         (store_ppc_registers): Call store_altivec_registers with -1 for
1010         the new regno parameter.
1011
1012 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
1013
1014         * arch/ppc-linux-common.h (PPC_LINUX_SIZEOF_VRREGSET)
1015         (PPC_LINUX_SIZEOF_VSXREGSET): Define.
1016         * ppc-linux-nat.c (SIZEOF_VSXREGS, SIZEOF_VRREGS): Remove.
1017         (gdb_vrregset_t): Change array type size to
1018         PPC_LINUX_SIZEOF_VRREGSET.
1019         (gdb_vsxregset_t): Change array type size to
1020         PPC_LINUX_SIZEOF_VSXREGSET.
1021         * ppc-linux-tdep.c (ppc_linux_iterate_over_regset_sections):
1022         Change integer literals to PPC_LINUX_SIZEOF_VRREGSET and
1023         PPC_LINUX_SIZEOF_VSXREGSET.
1024
1025 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
1026
1027         * configure.nat <linux powerpc>: Add ppc-linux.o to NATDEPFILES.
1028         * ppc-linux-nat.c (ppc_linux_target_wordsize): Move to
1029         nat/ppc-linux.c.
1030         (ppc_linux_nat_target::auxv_parse): Get thread id tid. Call
1031         ppc_linux_target_wordsize with tid.
1032         (ppc_linux_nat_target::read_description): Call ppc_linux_target
1033         wordsize with tid.
1034         * nat/ppc-linux.c: Include nat/gdb_ptrace.h.
1035         (ppc64_64bit_inferior_p): Add static and inline specifiers.
1036         (ppc_linux_target_wordsize): Move here from ppc-linux-nat.c. Add
1037         tid parameter. Remove static specifier.
1038         * nat/ppc-linux.h (ppc64_64bit_inferior_p): Remove declaration.
1039         (ppc_linux_target_wordsize): New declaration.
1040
1041 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
1042
1043         * arch/ppc-linux-common.c: New file.
1044         * arch/ppc-linux-common.h: New file.
1045         * arch/ppc-linux-tdesc.h: New file.
1046         * configure.tgt (powerpc*-*-linux*): Add arch/ppc-linux-common.o.
1047         * Makefile.in (ALL_TARGET_OBS): Add arch/ppc-linux-common.o.
1048         (HFILES_NO_SRCDIR): Add arch/ppc-linux-common.h and
1049         arch/ppc-linux-tdesc.h.
1050         * ppc-linux-nat.c: Include arch/ppc-linux-common.h and
1051         arch/ppc-linux-tdesc.h.
1052         (ppc_linux_nat_target::read_description): Remove target
1053         description matching code. Fill a ppc_linux_features struct and
1054         call ppc_linux_match_description with it. Move comment about ISA
1055         2.05 to ppc-linux-common.c.
1056         * ppc-linux-tdep.c: Include arch/ppc-linux-common.h and
1057         arch/ppc-linux-tdesc.h.
1058         (ppc_linux_core_read_description): Remove target description
1059         matching code. Fill a ppc_linux_features struct and call
1060         ppc_linux_match_description with it.
1061         * ppc-linux-tdep.h (tdesc_powerpc_32l, tdesc_powerpc_64l)
1062         (tdesc_powerpc_altivec32l, tdesc_powerpc_altivec64l)
1063         (tdesc_powerpc_cell32l, tdesc_powerpc_cell64l)
1064         (tdesc_powerpc_vsx32l, tdesc_powerpc_vsx64l)
1065         (tdesc_powerpc_isa205_32l, tdesc_powerpc_isa205_64l)
1066         (tdesc_powerpc_isa205_altivec32l, tdesc_powerpc_isa205_altivec64l)
1067         (tdesc_powerpc_isa205_vsx32l, tdesc_powerpc_isa205_vsx64l)
1068         (tdesc_powerpc_e500l): Remove.
1069
1070 2018-05-22  Joel Brobecker  <brobecker@adacore.com>
1071
1072         * ada-lang.c (catch_assert_command): Pass empty string instead
1073         of NULL for excep_string argument.
1074
1075 2018-05-22  Maciej W. Rozycki  <macro@mips.com>
1076
1077         * mips-linux-nat.c (mips64_linux_register_addr): Return -1 if
1078         the width of the requested register exceeds the width of the
1079         `ptrace' data type.
1080
1081 2018-05-21  Tom Tromey  <tom@tromey.com>
1082
1083         * printcmd.c (output_command): Remove.
1084         (output_command_const): Rename to output_command.
1085         * valprint.h (output_command): Rename from output_command_const.
1086         * tracepoint.c (trace_dump_actions): Call output_command.
1087
1088 2018-05-21  Tom Tromey  <tom@tromey.com>
1089
1090         * mi/mi-cmd-catch.c (mi_cmd_catch_assert)
1091         (mi_cmd_catch_exception, mi_cmd_catch_handlers): Update.
1092         * ada-lang.h (create_ada_exception_catchpoint): Update.
1093         * ada-lang.c (struct ada_catchpoint) <excep_string>: Now a
1094         std::string.
1095         (create_excep_cond_exprs, ~ada_catchpoint)
1096         (should_stop_exception, print_one_exception)
1097         (print_mention_exception, print_recreate_exception): Update.
1098         (ada_get_next_arg): Remove.
1099         (catch_ada_exception_command_split): Use std::string.  Change type
1100         of "excep_string", "cond_string".
1101         (catch_ada_exception_command): Update.
1102         (create_ada_exception_catchpoint): Change type of excep_string.
1103         (ada_exception_sal): Remove excep_string parameter.
1104         (~ada_catchpoint): Remove.
1105
1106 2018-05-21  Tom Tromey  <tom@tromey.com>
1107
1108         * ada-lang.c (ada_collect_symbol_completion_matches): Remove
1109         cleanup.
1110
1111 2018-05-21  Tom Tromey  <tom@tromey.com>
1112
1113         * ada-lang.c (ada_exception_message_1, ada_exception_message):
1114         Return unique_xmalloc_ptr.
1115         (print_it_exception): Update.
1116
1117 2018-05-21  Tom Tromey  <tom@tromey.com>
1118
1119         * tracepoint.c (trace_dump_actions): Use std::string.
1120
1121 2018-05-21  Tom Tromey  <tom@tromey.com>
1122
1123         * symfile.c (reread_symbols): Use std::string for original_name.
1124
1125 2018-05-21  Tom Tromey  <tom@tromey.com>
1126
1127         * dwarf2read.c (dwarf2_read_debug_names): Use std::unique_ptr.
1128         (mapped_index_base): Use DISABLE_COPY_AND_ASSIGN.  Default
1129         constructor.
1130
1131 2018-05-20  Simon Marchi  <simon.marchi@polymtl.ca>
1132
1133         * common/traits.h (HAVE_IS_TRIVIALLY_COPYABLE): Rename the wrong
1134         instance to...
1135         (HAVE_IS_TRIVIALLY_CONSTRUCTIBLE): ... this.
1136         * objfiles.c (get_objfile_bfd_data): Allocate
1137         objfile_per_bfd_storage with obstack_new when allocating on
1138         obstack.
1139
1140 2018-05-20  Simon Marchi  <simon.marchi@ericsson.com>
1141
1142         * ada-lang.c (cache_symbol): Use XOBNEW and/or XOBNEWVEC and/or
1143         OBSTACK_ZALLOC.
1144         * dwarf2-frame.c (dwarf2_build_frame_info): Likewise.
1145         * hppa-tdep.c (hppa_init_objfile_priv_data): Likewise.
1146         * mdebugread.c (mdebug_build_psymtabs): Likewise.
1147         (add_pending): Likewise.
1148         (parse_symbol): Likewise.
1149         (parse_partial_symbols): Likewise.
1150         (psymtab_to_symtab_1): Likewise.
1151         (new_psymtab): Likewise.
1152         (elfmdebug_build_psymtabs): Likewise.
1153         * minsyms.c (terminate_minimal_symbol_table): Likewise.
1154         * objfiles.c (get_objfile_bfd_data): Likewise.
1155         (objfile_register_static_link): Likewise.
1156         * psymtab.c (allocate_psymtab): Likewise.
1157         * stabsread.c (read_member_functions): Likewise.
1158         * xcoffread.c (xcoff_end_psymtab): Likewise.
1159
1160 2018-05-20  Simon Marchi  <simon.marchi@ericsson.com>
1161
1162         * common/traits.h (HAVE_IS_TRIVIALLY_COPYABLE): Define if
1163         compiler supports std::is_trivially_constructible.
1164         * common/poison.h: Include obstack.h.
1165         (IsMallocable): Define to is_trivially_constructible if the
1166         compiler supports it, define to true_type otherwise.
1167         (xobnew): New.
1168         (XOBNEW): Redefine.
1169         (xobnewvec): New.
1170         (XOBNEWVEC): Redefine.
1171         * gdb_obstack.h (obstack_zalloc): New.
1172         (OBSTACK_ZALLOC): Redefine.
1173         (obstack_calloc): New.
1174         (OBSTACK_CALLOC): Redefine.
1175         (obstack_new): New.
1176         * gdbarch.sh: Include gdb_obstack in gdbarch.h.
1177         (gdbarch_obstack): New declaration in gdbarch.h, definition in
1178         gdbarch.c.
1179         (GDBARCH_OBSTACK_CALLOC, GDBARCH_OBSTACK_ZALLOC): Use
1180         obstack_calloc/obstack_zalloc.
1181         (gdbarch_obstack_zalloc): Remove.
1182         * target-descriptions.c (tdesc_data_init): Use obstack_new.
1183
1184 2018-05-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1185
1186         * stack.c (backtrace_command_1): Remove useless variable int i.
1187
1188 2018-05-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1189
1190         * stack.c (print_frame_info): Fix comment.
1191
1192 2018-05-18  Tom Tromey  <tom@tromey.com>
1193
1194         * dwarf2read.c (struct dwz_file): Add constructor, initializers.
1195         <dwz_bfd>: Now a gdb_bfd_ref_ptr.
1196         (~dwarf2_per_objfile): Update
1197         (dwarf2_get_dwz_file): Use new.
1198         * dwarf2read.h (struct dwarf2_per_objfile) <dwz_file>: Now a
1199         unique_ptr.
1200
1201 2018-05-18  Tom Tromey  <tom@tromey.com>
1202
1203         * dwarf2read.h (struct dwarf2_per_objfile) <dwp_file>: Now a
1204         unique_ptr.
1205         * dwarf2read.c (struct dwp_file): Add constructor and
1206         initializers.
1207         (open_and_init_dwp_file): Return a unique_ptr.
1208         (dwarf2_per_objfile, create_dwp_hash_table)
1209         (create_dwo_unit_in_dwp_v1, create_dwo_unit_in_dwp_v2)
1210         (lookup_dwo_unit_in_dwp): Update.
1211         (open_and_init_dwp_file, get_dwp_file): Update.
1212
1213 2018-05-18  Tom Tromey  <tom@tromey.com>
1214
1215         * dwarf2read.c (dwarf2_per_objfile): Update.
1216         (struct mapped_index): Add initializers.
1217         (dwarf2_read_index): Use new.
1218         (dw2_symtab_iter_init): Update.
1219         * dwarf2read.h (struct dwarf2_per_objfile) <index_table>: Now a
1220         unique_ptr.
1221
1222 2018-05-18  Simon Marchi  <simon.marchi@ericsson.com>
1223
1224         * dwarf2read.c (mapped_index) <total_size>: Remove.
1225
1226 2018-05-18  Simon Marchi  <simon.marchi@ericsson.com>
1227
1228         * unittests/format_pieces-selftests.c (test_format_specifier):
1229         Add ARI comments.
1230
1231 2018-05-18  Tom Tromey  <tom@tromey.com>
1232
1233         * c-typeprint.c (maybe_print_hole): New function.
1234         (c_print_type_struct_field_offset): Update.
1235         (c_type_print_base_struct_union): Call maybe_print_hole.
1236
1237 2018-05-17  Keith Seitz  <keiths@redhat.com>
1238
1239         * breakpoint.c (build_bpstat_chain): New function, moved from
1240         bpstat_stop_status.
1241         (bpstat_stop_status): Add optional parameter, `stop_chain'.
1242         If no stop chain is passed, call build_bpstat_chain to build it.
1243         * breakpoint.h (build_bpstat_chain): Declare.
1244         (bpstat_stop_status): Move documentation here from breakpoint.c.
1245         * infrun.c (handle_signal_stop): Before eliding inlined frames,
1246         build the stop chain and pass it to skip_inline_frames.
1247         Pass this stop chain to bpstat_stop_status.
1248         * inline-frame.c: Include breakpoint.h.
1249         (stopped_by_user_bp_inline_frame): New function.
1250         (skip_inline_frames): Add parameter `stop_chain'.
1251         Move documention to inline-frame.h.
1252         If non-NULL, use stopped_by_user_bp_inline_frame to determine
1253         whether the frame should be elided.
1254         * inline-frame.h (skip_inline_frames): Add parameter `stop_chain'.
1255         Add moved documentation and update for new parameter.
1256
1257 2018-05-17  Simon Marchi  <simon.marchi@ericsson.com>
1258
1259         PR cli/14975
1260         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1261         unittests/format_pieces-selftests.c.
1262         * common/format.h (format_piece) <operator==>: New.
1263         (format_pieces) <operator[]>: Remove.
1264         * common/format.c (format_pieces::format_pieces): Handle \e.
1265         * unittests/format_pieces-selftests.c: New.
1266
1267 2018-05-17  Tom Tromey  <tom@tromey.com>
1268
1269         PR symtab/23010:
1270         * dwarf2read.c (load_cu, dw2_do_instantiate_symtab)
1271         (dw2_instantiate_symtab): Add skip_partial parameter.
1272         (dw2_find_last_source_symtab, dw2_map_expand_apply)
1273         (dw2_lookup_symbol, dw2_expand_symtabs_for_function)
1274         (dw2_expand_all_symtabs, dw2_expand_symtabs_with_fullname)
1275         (dw2_expand_symtabs_matching_one)
1276         (dw2_find_pc_sect_compunit_symtab)
1277         (dw2_debug_names_lookup_symbol)
1278         (dw2_debug_names_expand_symtabs_for_function): Update.
1279         (init_cutu_and_read_dies): Add skip_partial parameter.
1280         (process_psymtab_comp_unit, build_type_psymtabs_1)
1281         (process_skeletonless_type_unit, load_partial_comp_unit)
1282         (psymtab_to_symtab_1): Update.
1283         (load_full_comp_unit): Add skip_partial parameter.
1284         (process_imported_unit_die, dwarf2_read_addr_index)
1285         (follow_die_offset, dwarf2_fetch_die_loc_sect_off)
1286         (dwarf2_fetch_constant_bytes, dwarf2_fetch_die_type_sect_off)
1287         (read_signatured_type): Update.
1288
1289 2018-05-17  Simon Marchi  <simon.marchi@ericsson.com>
1290
1291         * value.c (release_value): Remove unused variable.
1292         (record_latest_value): Likewise.
1293         (access_value_history): Likewise.
1294         (preserve_values): Likewise.
1295
1296 2018-05-17  Tom Tromey  <tom@tromey.com>
1297
1298         * extension.h (struct ext_lang_type_printers) <py_type_printers>:
1299         Initialize.
1300
1301 2018-05-16  Maciej W. Rozycki  <macro@mips.com>
1302
1303         PR gdb/22286
1304         * linux-nat-trad.c (linux_nat_trad_target::fetch_register):
1305         Also handle registers whose width is not a multiple of
1306         PTRACE_TYPE_RET.
1307         (linux_nat_trad_target::store_register): Likewise.
1308
1309 2018-05-16  Tom Tromey  <tom@tromey.com>
1310
1311         * gdbcore.h (core_bfd): Redefine.
1312         * corelow.c (core_target::close): Update.
1313         (core_target_open): Update.
1314         * progspace.h (struct program_space) <cbfd>: Now a
1315         gdb_bfd_ref_ptr.
1316
1317 2018-05-16  Tom Tromey  <tom@tromey.com>
1318
1319         PR cli/19551:
1320         * symfile-add-flags.h (enum symfile_add_flags)
1321         <SYMFILE_NOT_FILENAME>: New constant.
1322         * symfile.c (read_symbols): Use SYMFILE_NOT_FILENAME.  Get
1323         objfile name from BFD.
1324         (symbol_file_add_with_addrs): Check SYMFILE_NOT_FILENAME.
1325         * minidebug.c (find_separate_debug_file_in_section): Put
1326         ".gnu_debugdata" into BFD's file name.
1327
1328 2018-05-16  Simon Marchi  <simon.marchi@ericsson.com>
1329
1330         * regcache.c (regcache_read_ftype, regcache_write_ftype):
1331         Remove.
1332
1333 2018-05-15  Tamar Christina  <tamar.christina@arm.com>
1334
1335         PR binutils/21446
1336         * aarch64-tdep.c (aarch64_analyze_prologue,
1337         aarch64_software_single_step, aarch64_displaced_step_copy_insn):
1338         Indicate not interested in errors.
1339
1340 2018-05-15  Maciej W. Rozycki  <macro@mips.com>
1341
1342         * mips-linux-nat.c (mips_linux_nat_target::fetch_registers):
1343         Supply the MIPS_ZERO_REGNUM register.
1344
1345 2018-05-15  Maciej W. Rozycki  <macro@mips.com>
1346
1347         * mips-tdep.c (mask_address_var): Make variable static.
1348
1349 2018-05-14  Tom Tromey  <tom@tromey.com>
1350
1351         * dwarf2read.c (rust_union_quirks): Clear rust_unions.
1352
1353 2018-05-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1354
1355         * i387-tdep.c (i387_collect_xsave): Use FXSAVE_MXCSR_ADDR not
1356         FXSAVE_ADDR for the mxcsr register.
1357
1358 2018-05-11  Max Filippov  <jcmvbkbc@gmail.com>
1359
1360         * configure.tgt (xtensa*-*-linux*): Drop gdb_target definition.
1361
1362 2018-05-11  Pedro Alves  <palves@redhat.com>
1363
1364         * corelow.c (core_target) <core_target>: No longer inline.
1365         Initialize m_core_gdbarch, m_core_vec and build the section table
1366         here.
1367         <~core_target>: New.
1368         <core_gdbarch, get_core_register_section>: New methods.
1369         <m_core_section_table, m_core_vec, m_core_gdbarch>: New fields,
1370         factored out from ...
1371         <core_data, core_vec, core_gdbarch>: ... these deleted globals.
1372         (core_ops): Delete.
1373         (sniff_core_bfd): Add gdbarch parameter.
1374         (core_close): Delete, merged into ...
1375         (core_target::close): ... here.  Delete self.
1376         (core_close_cleanup): Delete.
1377         (core_target_open): Allocate a core_target on the heap.  Use a
1378         unique_ptr instead of a cleanup.  Bits moved into the core_target
1379         ctor.  Adjust to use core_target methods instead of globals.
1380         (get_core_register_section): Rename to ...
1381         (core_target::get_core_register_section): ... this and adjust.
1382         (struct get_core_registers_cb_data): New.
1383         (get_core_registers_cb): Use it.  Use bool.
1384         (core_target::fetch_registers, core_target::files_info)
1385         (core_target::xfer_partial, core_target::read_description)
1386         (core_target::pid_to, core_target::thread_name): Adjust to
1387         reference class fields instead of globals.
1388         * target.h (struct target_ops_deleter, target_ops_up): New.
1389
1390 2018-05-11  Pedro Alves  <palves@redhat.com>
1391
1392         * corefile.c (core_file_command): Move to corelow.c.
1393         * corelow.c (the_core_target): Delete.
1394         (core_file_command): Moved from corefile.c.  Check exec_bfd
1395         instead of the_core_target.  Use target_detach instead of calling
1396         into the_core_target directly.
1397         (maybe_say_no_core_file_now): New.
1398         (core_target::detach): Use it.
1399         (_initialize_corelow): Remove references to the_core_target.
1400         * gdbcore.h (the_core_target): Delete.
1401
1402 2018-05-11  Tom Tromey  <tromey@redhat.com>
1403             Pedro Alves  <palves@redhat.com>
1404
1405         * corefile.c (core_bfd): Remove.
1406         * gdbcore.h (core_bfd): Now a macro.
1407         * progspace.h (struct program_space) <cbfd>: New field.
1408
1409 2018-05-11  Tom Tromey  <tom@tromey.com>
1410
1411         * mdebugread.c (parse_partial_symbols, psymtab_to_symtab_1): Use
1412         gdb::def_vector.
1413
1414 2018-05-10  Tom Tromey  <tom@tromey.com>
1415
1416         * configure: Rebuild.
1417         * warning.m4 (AM_GDB_WARNINGS): Use -Wimplicit-fallthrough=3.
1418
1419 2018-05-10  Joel Brobecker  <brobecker@adacore.com>
1420
1421         PR server/23158:
1422         * regformats/regdat.sh: Adjust script, following the addition
1423         of the new expedite_regs parameter to init_target_desc.
1424
1425 2018-05-10  Omair Javaid  <omair.javaid@linaro.org>
1426     
1427         PR gdb/23127
1428         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Add call to
1429         set_gdbarch_significant_addr_bit.
1430         * aarch64-tdep.c (aarch64_gdbarch_init): Remove call to
1431         set_gdbarch_significant_addr_bit.
1432         * utils.c (address_significant): Update to sign extend addr.
1433
1434 2018-05-09  Max Filippov  <jcmvbkbc@gmail.com>
1435
1436         * xtensa-linux-tdep.c (xtensa-tdep.h): New include.
1437         (xtensa_linux_init_abi): Limit tdep->num_regs by
1438         tdep->num_nopriv_regs.
1439         * xtensa-tdep.c (xtensa_derive_tdep): Calculate
1440         tdep->num_nopriv_regs and only copy it to tdep->num_regs if it's
1441         not initialized.
1442
1443 2018-05-08  Simon Marchi  <simon.marchi@ericsson.com>
1444
1445         * unittests/string_view-selftests.c: Define GNULIB_NAMESPACE.
1446
1447 2018-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1448
1449         * common/x86-xstate.h (I387_FCTRL_INIT_VAL): New constant.
1450         (I387_MXCSR_INIT_VAL): New constant.
1451         * amd64-tdep.c (amd64_supply_xsave): Only read state from xsave
1452         buffer if it was supplied by the inferior.
1453         * i387-tdep.c (i387_supply_fsave): Use I387_MXCSR_INIT_VAL.
1454         (i387_xsave_get_clear_bv): New function.
1455         (i387_supply_xsave): Only read x87 control registers from the
1456         xsave buffer if the feature is enabled, and the state will have
1457         been written, otherwise, provide a suitable default.
1458         (i387_collect_xsave): Pre-clear all registers in xsave buffer,
1459         including x87 control registers.  Update control registers if they
1460         have changed from the default value, and mark features as enabled
1461         as required.
1462         * i387-tdep.h (i387_xsave_get_clear_bv): Declare.
1463
1464 2018-05-08  Ulrich Weigand  <uweigand@de.ibm.com>
1465
1466         * spu-tdep.c (info_spu_event_command): Fix output formatting.
1467
1468 2018-05-07  Tom Tromey  <tom@tromey.com>
1469
1470         * configure: Rebuild.
1471         * warning.m4 (AM_GDB_WARNINGS): Add -Wduplicated-cond.
1472
1473 2018-05-07  Tom Tromey  <tom@tromey.com>
1474
1475         PR tdep/20362:
1476         * arm-tdep.c (arm_record_vfp_data_proc_insn): Properly mask off D
1477         bit.  Use correct value for VDIV.
1478
1479 2018-05-04  Tom Tromey  <tom@tromey.com>
1480
1481         * configure: Rebuild.
1482         * warning.m4 (AM_GDB_WARNINGS): Add -Wimplicit-fallthrough.
1483
1484 2018-05-04  Tom Tromey  <tom@tromey.com>
1485
1486         * linux-record.c (record_linux_system_call) <case
1487         RECORD_SYS_RECVFROM>: Add "break".
1488
1489 2018-05-04  Tom Tromey  <tom@tromey.com>
1490
1491         * mi/mi-main.c (mi_cmd_trace_frame_collected) <REGISTERS_FORMAT>:
1492         Add missing "break".
1493         * mi/mi-cmd-stack.c (mi_cmd_stack_list_locals) <NO_FRAME_FILTERS>:
1494         Add missing "break".
1495
1496 2018-05-04  Tom Tromey  <tom@tromey.com>
1497
1498         * rs6000-tdep.c (ppc_process_record_op4)
1499         (ppc_process_record_op63): Add fall-through comment.
1500
1501 2018-05-04  Tom Tromey  <tom@tromey.com>
1502
1503         * i386-tdep.c (i386_process_record): Add fall-through comment.
1504
1505 2018-05-04  Tom Tromey  <tom@tromey.com>
1506
1507         * stabsread.c (define_symbol) <case 'p'>: Add fall-through
1508         comment.
1509
1510 2018-05-04  Tom Tromey  <tom@tromey.com>
1511
1512         * riscv-tdep.c (riscv_isa_xlen): Add fall-through comment.
1513         * utils.c (can_dump_core) <LIMIT_CUR>: Add fall-through comment.
1514         * eval.c (fetch_subexp_value) <MEMORY_ERROR>: Add fall-through
1515         comment.
1516         * d-valprint.c (d_val_print) <TYPE_CODE_STRUCT>: Add fall-through
1517         comment.
1518         * coffread.c (coff_symtab_read) <C_LABEL>: Add fall-through
1519         comment.
1520
1521 2018-05-04  Tom Tromey  <tom@tromey.com>
1522
1523         * dwarf2loc.c (unimplemented): Add ATTRIBUTE_NORETURN.
1524
1525 2018-05-04  Tom Tromey  <tom@tromey.com>
1526
1527         * s390-tdep.c (s390_process_record): Fix fall-through comments.
1528         * xcoffread.c (scan_xcoff_symtab): Move comment later.
1529         * symfile.c (section_is_mapped): Fix fall-through comment.
1530         * stabsread.c (define_symbol, read_member_functions): Fix
1531         fall-through comment.
1532         * s390-linux-tdep.c (s390_process_record): Fix fall-through
1533         comment.
1534         * remote.c (remote_wait_as): Fix fall-through comment.
1535         * p-exp.y (yylex): Fix fall-through comment.
1536         * nat/x86-dregs.c (x86_length_and_rw_bits): Fix fall-through
1537         comment.
1538         * msp430-tdep.c (msp430_gdbarch_init): Fix fall-through comment.
1539         * mdebugread.c (parse_partial_symbols): Fix fall-through comment.
1540         * jv-exp.y (yylex): Fix fall-through comment.
1541         * go-exp.y (lex_one_token): Fix fall-through comment.
1542         * gdbtypes.c (get_discrete_bounds, rank_one_type): Fix
1543         fall-through comment.
1544         * f-exp.y (yylex): Fix fall-through comment.
1545         * dwarf2read.c (process_die): Fix fall-through comments.
1546         * dbxread.c (process_one_symbol): Fix fall-through comment.
1547         * d-exp.y (lex_one_token): Fix fall-through comment.
1548         * cp-name-parser.y (yylex): Fix fall-through comment.
1549         * coffread.c (coff_symtab_read): Fix fall-through comment.
1550         * c-exp.y (lex_one_token): Fix fall-through comment.
1551         * arm-tdep.c (arm_decode_miscellaneous): Fix fall-through
1552         comment.
1553         * arch/arm.c (arm_instruction_changes_pc): Fix fall-through
1554         comment.
1555
1556 2018-05-04  Tom Tromey  <tom@tromey.com>
1557
1558         PR python/22730:
1559         * NEWS: Mention gdb.execute change.
1560         * gdbcmd.h (execute_control_command): Don't declare.
1561         * python/python.c (execute_gdb_command): Use read_command_lines_1,
1562         execute_control_commands, execute_control_commands_to_string.
1563         * cli/cli-script.h (execute_control_commands)
1564         (execute_control_commands_to_string): Declare.
1565         (execute_control_command): Add from_tty parameter.
1566         * cli/cli-script.c (execute_control_commands)
1567         (execute_control_commands_to_string): New functions.
1568         (execute_user_command): Use execute_control_commands.
1569         (execute_control_command_1): Add "from_tty" parameter.  Update.
1570         (execute_control_command): Likewise.
1571
1572 2018-05-04  Tom Tromey  <tom@tromey.com>
1573
1574         PR python/22731:
1575         * NEWS: Mention that breakpoint commands are writable.
1576         * python/py-breakpoint.c (bppy_set_commands): New function.
1577         (breakpoint_object_getset) <"commands">: Use it.
1578
1579 2018-05-04  Tom Tromey  <tom@tromey.com>
1580
1581         * tracepoint.c (actions_command): Update.
1582         * mi/mi-cmd-break.c (mi_command_line_array)
1583         (mi_command_line_array_cnt, mi_command_line_array_ptr)
1584         (mi_read_next_line): Remove.
1585         (mi_cmd_break_commands): Update.
1586         * cli/cli-script.h (read_command_lines, read_command_lines_1): Use
1587         function_view.
1588         * cli/cli-script.c (get_command_line): Update.
1589         (process_next_line): Use function_view.  Constify.
1590         (recurse_read_control_structure, read_command_lines)
1591         (read_command_lines_1): Change argument types to function_view.
1592         (do_define_command, document_command): Update.
1593         * breakpoint.h (check_tracepoint_command): Don't declare.
1594         * breakpoint.c (check_tracepoint_command): Remove.
1595         (commands_command_1, create_tracepoint_from_upload): Update.
1596
1597 2018-05-04  Tom Tromey  <tom@tromey.com>
1598
1599         PR gdb/11750:
1600         * cli/cli-script.h (enum command_control_type) <define_control>:
1601         New constant.
1602         * cli/cli-script.c (multi_line_command_p): Handle define_control.
1603         (build_command_line, execute_control_command_1)
1604         (process_next_line): Likewise.
1605         (do_define_command): New function, extracted from define_command.
1606         (define_command): Use it.
1607
1608 2018-05-04  Tom Tromey  <tom@tromey.com>
1609
1610         * tracepoint.c (actions_command): Update.
1611         * cli/cli-script.h (read_command_lines): Update.
1612         * cli/cli-script.c (read_command_lines): Constify prompt_arg.
1613         (MAX_TMPBUF): Remove define.
1614         (define_command): Use string_printf.
1615         (document_command): Likewise.
1616         * breakpoint.c (commands_command_1): Update.
1617
1618 2018-05-04  Tom Tromey  <tom@tromey.com>
1619
1620         * top.c (execute_command): Update.
1621         * cli/cli-script.h (print_command_lines): Now varargs.
1622         * cli/cli-script.c (print_command_lines): Now varargs.
1623         (execute_control_command_1) <case while_control, case if_control>:
1624         Update.
1625
1626 2018-05-04  Tom Tromey  <tom@tromey.com>
1627
1628         * tracepoint.c (all_tracepoint_actions): Rename from
1629         all_tracepoint_actions_and_cleanup.  Change return type.
1630         (actions_command, encode_actions_1, encode_actions)
1631         (trace_dump_actions, tdump_command): Update.
1632         * remote.c (remote_download_command_source): Update.
1633         * python/python.c (gdbpy_eval_from_control_command)
1634         (python_command, python_interactive_command): Update.
1635         * mi/mi-cmd-break.c (mi_cmd_break_commands): Update.
1636         * guile/guile.c (guile_command)
1637         (gdbscm_eval_from_control_command, guile_command): Update.
1638         * compile/compile.c (compile_code_command)
1639         (compile_print_command, compile_to_object): Update.
1640         * cli/cli-script.h (struct command_lines_deleter): New.
1641         (counted_command_line): New typedef.
1642         (struct command_line): Add constructor, destructor.
1643         <body_list>: Remove.
1644         <body_list_0, body_list_1>: New members.
1645         (command_line_up): Remove typedef.
1646         (read_command_lines, read_command_lines_1, get_command_line):
1647         Update.
1648         (copy_command_lines): Don't declare.
1649         * cli/cli-script.c (build_command_line): Use "new".
1650         (get_command_line): Return counted_command_line.
1651         (print_command_lines, execute_user_command)
1652         (execute_control_command_1, while_command, if_command): Update.
1653         (realloc_body_list): Remove.
1654         (process_next_line, recurse_read_control_structure): Update.
1655         (read_command_lines, read_command_lines_1): Return counted_command_line.
1656         (free_command_lines): Use "delete".
1657         (copy_command_lines): Remove.
1658         (define_command, document_command, show_user_1): Update.
1659         * cli/cli-decode.h (struct cmd_list_element) <user_commands>: Now
1660         a counted_command_line.
1661         * breakpoint.h (counted_command_line): Remove typedef.
1662         (breakpoint_set_commands): Update.
1663         * breakpoint.c (check_no_tracepoint_commands)
1664         (validate_commands_for_breakpoint): Update.
1665         (breakpoint_set_commands): Change commands to be a
1666         counted_command_line.
1667         (commands_command_1, update_dprintf_command_list)
1668         (create_tracepoint_from_upload): Update.
1669
1670 2018-05-04  Tom Tromey  <tom@tromey.com>
1671
1672         * cli/cli-decode.h (cmd_list_element): New constructor.
1673         (~cmd_list_element): New destructor.
1674         (struct cmd_list_element): Add initializers.
1675         * cli/cli-decode.c (do_add_cmd): Use "new".
1676         (delete_cmd): Use "delete".
1677
1678 2018-05-04  Jan Kratochvil  <jan.kratochvil@redhat.com>
1679             Pedro Alves <palves@redhat.com>
1680
1681         PR breakpoints/19806 and support for PR external/20207.
1682         * NEWS: Mention Aarch64 watchpoint improvements.
1683         * aarch64-linux-nat.c (aarch64_linux_stopped_data_address): Fix missed
1684         watchpoints and PR external/20207 watchpoints.
1685         * nat/aarch64-linux-hw-point.c
1686         (kernel_supports_any_contiguous_range): New.
1687         (aarch64_watchpoint_offset): New.
1688         (aarch64_watchpoint_length): Support PR external/20207 watchpoints.
1689         (aarch64_point_encode_ctrl_reg): New parameter offset, new asserts.
1690         (aarch64_point_is_aligned): Support PR external/20207 watchpoints.
1691         (aarch64_align_watchpoint): New parameters aligned_offset_p and
1692         next_addr_orig_p.  Support PR external/20207 watchpoints.
1693         (aarch64_downgrade_regs): New.
1694         (aarch64_dr_state_insert_one_point): New parameters offset and
1695         addr_orig.
1696         (aarch64_dr_state_remove_one_point): Likewise.
1697         (aarch64_handle_breakpoint): Update caller.
1698         (aarch64_handle_aligned_watchpoint): Likewise.
1699         (aarch64_handle_unaligned_watchpoint): Support addr_orig and
1700         aligned_offset.
1701         (aarch64_linux_set_debug_regs): Remove const from state.  Call
1702         aarch64_downgrade_regs.
1703         (aarch64_show_debug_reg_state): Print also dr_addr_orig_wp.
1704         * nat/aarch64-linux-hw-point.h (DR_CONTROL_LENGTH): Rename to ...
1705         (DR_CONTROL_MASK): ... this.
1706         (struct aarch64_debug_reg_state): New field dr_addr_orig_wp.
1707         (unsigned int aarch64_watchpoint_offset): New prototype.
1708         (aarch64_linux_set_debug_regs): Remove const from state.
1709         * utils.c (align_up, align_down): Move to ...
1710         * common/common-utils.c (align_up, align_down): ... here.
1711         * utils.h (align_up, align_down): Move to ...
1712         * common/common-utils.h (align_up, align_down): ... here.
1713
1714 2018-05-04  Joel Brobecker  <brobecker@adacore.com>
1715
1716         * sparc-tdep.c (sparc_structure_return_p): Re-implement to
1717         match the ABI as summarized in GCC's gcc/config/sparc/sparc.c.
1718         (sparc_arg_by_memory_p): Renamed from sparc_arg_on_registers_p.
1719         Re-implement to match the ABI as summarized in GCC's
1720         gcc/config/sparc/sparc.c.  All callers updated.
1721         (sparc32_store_arguments): Remove assertion.
1722
1723 2018-05-04  Tom Tromey  <tom@tromey.com>
1724
1725         * printcmd.c: Don't include tui.h.
1726         (decode_format): Use skip_spaces.
1727
1728 2018-05-04  Tom Tromey  <tom@tromey.com>
1729
1730         PR gdb/22619:
1731         * printcmd.c (last_count): New global.
1732         (x_command): Use saved count when repeating.
1733
1734 2018-05-04  Tom Tromey  <tom@tromey.com>
1735
1736         * nto-procfs.c (do_closedir_cleanup): Remove.
1737         (procfs_pidlist): Use gdb_dir_up.
1738         * procfs.c (do_closedir_cleanup): Remove.
1739         (proc_update_threads): Use gdb_dir_up.
1740         * common/filestuff.h (struct gdb_dir_deleter): New.
1741         (gdb_dir_up): New typedef.
1742
1743 2018-05-04  Tom Tromey  <tom@tromey.com>
1744
1745         * ada-lang.c (print_mention_exception): Use std::string.
1746
1747 2018-05-04  Tom Tromey  <tom@tromey.com>
1748
1749         * ada-lang.c (create_excep_cond_exprs): Update.
1750         (ada_exception_catchpoint_cond_string): Use std::string.
1751
1752 2018-05-04  Tom Tromey  <tom@tromey.com>
1753
1754         * ada-lang.c (xget_renaming_scope): Return std::string.
1755         (old_renaming_is_invisible): Update.
1756
1757 2018-05-04  Tom Tromey  <tom@tromey.com>
1758
1759         * bfd-target.c (target_bfd::m_bfd): Now a gdb_bfd_ref_ptr.
1760         (target_bfd::target_bfd, target_bfd::~target_bfd): Update.
1761
1762 2018-05-04  Ulrich Weigand  <uweigand@de.ibm.com>
1763
1764         * spu-linux-nat.c (spu_linux_nat_target::wait): Fix syntax error.
1765
1766 2018-05-04  Tom Tromey  <tom@tromey.com>
1767
1768         * remote.c (remote_query_supported_append): Change type.
1769         (remote_check_symbols): Update.
1770
1771 2018-05-04  Paul Pluzhnikov  <ppluzhnikov@google.com>
1772
1773         PR gdb/11420
1774         * configure.ac: Prepend libpython.
1775         * python/python-config.py: Likewise.
1776         * configure: Regenerate.
1777
1778 2018-05-03  Simon Marchi  <simon.marchi@ericsson.com>
1779
1780         * Makefile.in (%.c: %.l): Use -t instead of --stdout.
1781
1782 2018-05-03  Pedro Alves  <palves@redhat.com>
1783
1784         * s390-linux-nat.c
1785         (s390_linux_nat_target::have_continuable_watchpoint): Mark with
1786         override.  Write 'true' instead of '1'.
1787         (s390_linux_nat_target::watchpoint_addr_within_range): Remove
1788         declaration.
1789
1790 2018-05-02  Pedro Alves  <palves@redhat.com>
1791
1792         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Use
1793         add_inf_child_target.
1794         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Use
1795         add_inf_child_target.
1796         * aix-thread.c (aix_thread_target_info): New.
1797         (aix_thread_target) <shortname, longname, doc>: Delete.
1798         <info>: New.
1799         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Use
1800         add_inf_child_target.
1801         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Use
1802         add_inf_child_target.
1803         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Use
1804         add_inf_child_target.
1805         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Use
1806         add_inf_child_target.
1807         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Use
1808         add_inf_child_target.
1809         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Use
1810         add_inf_child_target.
1811         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Use
1812         add_inf_child_target.
1813         * arm-linux-nat.c (_initialize_arm_linux_nat): Use
1814         add_inf_child_target.
1815         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Use
1816         add_inf_child_target.
1817         * bfd-target.c (target_bfd_target_info): New.
1818         (target_bfd) <shortname, longname, doc>: Delete.
1819         <info>: New.
1820         * bsd-kvm.c (bsd_kvm_target_info): New.
1821         (bsd_kvm_target) <shortname, longname, doc>: Delete.
1822         <info>: New.
1823         (bsd_kvm_target::open): Rename to ...
1824         (bsd_kvm_target_open): ... this.  Adjust.
1825         * bsd-uthread.c (bsd_uthread_target_info): New.
1826         (bsd_uthread_target) <shortname, longname, doc>: Delete.
1827         <info>: New.
1828         * corefile.c (core_file_command): Adjust.
1829         * corelow.c (core_target_info): New.
1830         (core_target) <shortname, longname, doc>: Delete.
1831         <info>: New.
1832         (core_target::open): Rename to ...
1833         (core_target_open): ... this.  Adjust.
1834         * ctf.c (ctf_target_info): New.
1835         (ctf_target) <shortname, longname, doc>: Delete.
1836         <info>: New.
1837         (ctf_target::open): Rename to ...
1838         (ctf_target_open): ... this.
1839         (_initialize_ctf): Adjust.
1840         * exec.c (exec_target_info): New.
1841         (exec_target) <shortname, longname, doc>: Delete.
1842         <info>: New.
1843         (exec_target::open): Rename to ...
1844         (exec_target_open): ... this.
1845         * gdbcore.h (core_target_open): Declare.
1846         * go32-nat.c (_initialize_go32_nat): Use add_inf_child_target.
1847         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Use
1848         add_inf_child_target.
1849         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Use
1850         add_inf_child_target.
1851         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Use
1852         add_inf_child_target.
1853         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Use
1854         add_inf_child_target.
1855         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Use
1856         add_inf_child_target.
1857         * i386-gnu-nat.c (_initialize_i386gnu_nat): Use
1858         add_inf_child_target.
1859         * i386-linux-nat.c (_initialize_i386_linux_nat): Use
1860         add_inf_child_target.
1861         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Use
1862         add_inf_child_target.
1863         * i386-obsd-nat.c (_initialize_i386obsd_nat): Use
1864         add_inf_child_target.
1865         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Use
1866         add_inf_child_target.
1867         * inf-child.c (inf_child_target_info): New.
1868         (inf_child_target::info): New.
1869         (inf_child_open_target): Remove 'target' parameter.  Use
1870         get_native_target instead.
1871         (inf_child_target::open): Delete.
1872         (add_inf_child_target): New.
1873         * inf-child.h (inf_child_target) <shortname, longname, doc, open>:
1874         Delete.
1875         <info>: New.
1876         (add_inf_child_target): Declare.
1877         (inf_child_open_target): Declare.
1878         * linux-thread-db.c (thread_db_target_info): New.
1879         (thread_db_target) <shortname, longname, doc>: Delete.
1880         <info>: New.
1881         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Use
1882         add_inf_child_target.
1883         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Use
1884         add_inf_child_target.
1885         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Use
1886         add_inf_child_target.
1887         * m88k-bsd-nat.c (_initialize_m88kbsd_nat): Use
1888         add_inf_child_target.
1889         * make-target-delegates (print_class): Adjust.
1890         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Use
1891         add_inf_child_target.
1892         * mips-linux-nat.c (_initialize_mips_linux_nat): Use
1893         add_inf_child_target.
1894         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Use
1895         add_inf_child_target.
1896         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Use
1897         add_inf_child_target.
1898         * nto-procfs.c (nto_native_target_info): New.
1899         (nto_procfs_target_native) <shortname, longname, doc>:
1900         Delete.
1901         <info>: New.
1902         (nto_procfs_target_info): New.
1903         (nto_procfs_target_procfs) <shortname, longname, doc>:
1904         Delete.
1905         <info>: New.
1906         (init_procfs_targets): Adjust.
1907         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Use
1908         add_inf_child_target.
1909         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Use
1910         add_inf_child_target.
1911         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Use
1912         add_inf_child_target.
1913         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Use
1914         add_inf_child_target.
1915         * ravenscar-thread.c (ravenscar_target_info): New.
1916         (ravenscar_thread_target) <shortname, longname, doc>:
1917         Delete.
1918         <info>: New.
1919         * record-btrace.c (record_btrace_target_info):
1920         (record_btrace_target) <shortname, longname, doc>: Delete.
1921         <info>: New.
1922         (record_btrace_target::open): Rename to ...
1923         (record_btrace_target_open): ... this.  Adjust.
1924         * record-full.c (record_longname, record_doc): New.
1925         (record_full_base_target) <shortname, longname, doc>: Delete.
1926         <info>: New.
1927         (record_full_target_info): New.
1928         (record_full_target): <shortname>: Delete.
1929         <info>: New.
1930         (record_full_core_open_1, record_full_open_1): Update comments.
1931         (record_full_base_target::open): Rename to ...
1932         (record_full_open): ... this.
1933         (cmd_record_full_restore): Update.
1934         (_initialize_record_full): Update.
1935         * remote-sim.c (remote_sim_target_info): New.
1936         (gdbsim_target) <shortname, longname, doc>: Delete.
1937         <info>: New.
1938         (gdbsim_target::open): Rename to ...
1939         (gdbsim_target_open): ... this.
1940         (_initialize_remote_sim): Adjust.
1941         * remote.c (remote_doc): New.
1942         (remote_target_info): New.
1943         (remote_target) <shortname, longname, doc>: Delete.
1944         <info>: New.
1945         (extended_remote_target_info): New.
1946         (extended_remote_target) <shortname, longname, doc>: Delete.
1947         <info>: New.
1948         (remote_target::open_1): Make static.  Adjust.
1949         * rs6000-nat.c (_initialize_rs6000_nat): Use add_inf_child_target.
1950         * s390-linux-nat.c (_initialize_s390_nat): Use
1951         add_inf_child_target.
1952         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Use
1953         add_inf_child_target.
1954         * sol-thread.c (thread_db_target_info): New.
1955         (sol_thread_target) <shortname, longname, doc>: Delete.
1956         <info>: New.
1957         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Use
1958         add_inf_child_target.
1959         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Use
1960         add_inf_child_target.
1961         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Use
1962         add_inf_child_target.
1963         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Use
1964         add_inf_child_target.
1965         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Use
1966         add_inf_child_target.
1967         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Use
1968         add_inf_child_target.
1969         * spu-linux-nat.c (_initialize_spu_nat): Use
1970         add_inf_child_target.
1971         * spu-multiarch.c (spu_multiarch_target_info): New.
1972         (spu_multiarch_target) <shortname, longname, doc>: Delete.
1973         <info>: New.
1974         * target-delegates.c: Regenerate.
1975         * target.c: Include <unordered_map>.
1976         (target_ops_p): Delete.
1977         (DEF_VEC_P(target_ops_p)): Delete.
1978         (target_factories): New.
1979         (test_target_info): New.
1980         (test_target_ops::info): New.
1981         (open_target): Adjust to use target_factories.
1982         (add_target_with_completer): Rename to ...
1983         (add_target): ... this.  Change prototype.  Register target_info
1984         and open callback in target_factories.  Register target_info in
1985         command context instead of target_ops.
1986         (add_target): Delete old implementation.
1987         (add_deprecated_target_alias): Change prototype.  Adjust.
1988         (the_native_target): New.
1989         (set_native_target, get_native_target): New.
1990         (find_default_run_target): Use the_native_target.
1991         (find_attach_target, find_run_target): Simplify.
1992         (target_ops::open): Delete.
1993         (dummy_target_info): New.
1994         (dummy_target::shortname, dummy_target::longname)
1995         (dummy_target::doc): Delete.
1996         (dummy_target::info): New.
1997         (debug_target::shortname, debug_target::longname)
1998         (debug_target::doc): Delete.
1999         (debug_target::info): New.
2000         * target.h (struct target_info): New.
2001         (target_ops::~target_ops): Add comment.
2002         (target_ops::info): New.
2003         (target_ops::shortname, target_ops::longname, target_ops::doc): No
2004         longer virtual.  Implement in terms of target_info.
2005         (set_native_target, get_native_target): Declare.
2006         (target_open_ftype): New.
2007         (add_target, add_target_with_completer)
2008         (add_deprecated_target_alias): Change prototype.
2009         (test_target) <shortname, longname, doc>: Delete.
2010         <info>: New.
2011         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Use
2012         add_inf_child_target.
2013         * tracefile-tfile.c (tfile_target_info): New.
2014         (tfile_target) <shortname, longname, doc>: Delete.
2015         <info>: New.
2016         (tfile_target::open): Rename to ...
2017         (tfile_target_open): ... this.
2018         (_initialize_tracefile_tfile): Adjust.
2019         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Use
2020         add_inf_child_target.
2021         * windows-nat.c (_initialize_windows_nat): Use
2022         add_inf_child_target.
2023         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Use
2024         add_inf_child_target.
2025
2026 2018-05-02  Pedro Alves  <palves@redhat.com>
2027
2028         * linux-nat.h (linux_nat_target) <low_new_thread,
2029         low_delete_thread, low_new_fork, low_forget_process,
2030         low_prepare_to_resume, low_siginfo_fixup, low_status_is_event>:
2031         New virtual methods.
2032         (linux_nat_set_new_thread, linux_nat_set_delete_thread)
2033         (linux_nat_new_fork_ftype, linux_nat_set_new_fork)
2034         (linux_nat_forget_process_ftype, linux_nat_set_forget_process)
2035         (linux_nat_forget_process, linux_nat_set_siginfo_fixup)
2036         (linux_nat_set_prepare_to_resume, linux_nat_set_status_is_event):
2037         Delete.
2038         * linux-fork.c (delete_fork): Adjust to call low method.
2039         * linux-nat.c (linux_nat_new_thread, linux_nat_delete_thread)
2040         (linux_nat_new_fork, linux_nat_forget_process_hook)
2041         (linux_nat_prepare_to_resume, linux_nat_siginfo_fixup)
2042         (linux_nat_status_is_event):
2043         (linux_nat_target::follow_fork, lwp_free, add_lwp, detach_one_lwp)
2044         (linux_resume_one_lwp_throw, linux_handle_extended_wait): Adjust
2045         to call low method.
2046         (sigtrap_is_event): Rename to ...
2047         (linux_nat_target::low_status_is_event): ... this.
2048         (linux_nat_set_status_is_event): Delete.
2049         (save_stop_reason, linux_nat_wait_1)
2050         (linux_nat_target::mourn_inferior, siginfo_fixup): Adjust to call
2051         low methods.
2052         (linux_nat_set_new_thread, linux_nat_set_delete_thread)
2053         (linux_nat_set_new_fork, linux_nat_set_forget_process)
2054         (linux_nat_forget_process, linux_nat_set_siginfo_fixup)
2055         (linux_nat_set_prepare_to_resume): Delete.
2056         * aarch64-linux-nat.c: All linux_nat_set_* callbacks converted to
2057         low virtual methods.
2058         * amd64-linux-nat.c: Likewise.
2059         * arm-linux-nat.c: Likewise.
2060         * i386-linux-nat.c: Likewise.
2061         * ia64-linux-nat.c: Likewise.
2062         * mips-linux-nat.c: Likewise.
2063         * ppc-linux-nat.c: Likewise.
2064         * s390-linux-nat.c: Likewise.
2065         * sparc64-linux-nat.c: Likewise.
2066         * x86-linux-nat.c: Likewise.
2067         * x86-linux-nat.h: Include "nat/x86-linux.h".
2068         (x86_linux_nat_target) <low_new_fork, low_forget_process,
2069         low_prepare_to_resume, low_new_thread, low_delete_thread>:
2070         Override methods.
2071
2072 2018-05-02  Pedro Alves  <palves@redhat.com>
2073
2074         * target.h (target_ops)
2075         <stopped_by_sw_breakpoint, supports_stopped_by_sw_breakpoint,
2076         stopped_by_hw_breakpoint, supports_stopped_by_hw_breakpoint,
2077         stopped_by_watchpoint, have_continuable_watchpoint,
2078         stopped_data_address, watchpoint_addr_within_range,
2079         can_accel_watchpoint_condition, can_run, thread_alive,
2080         has_all_memory, has_memory, has_stack, has_registers,
2081         has_execution, can_async_p, is_async_p, supports_non_stop,
2082         always_non_stop_p, can_execute_reverse, supports_multi_process,
2083         supports_enable_disable_tracepoint,
2084         supports_disable_randomization, supports_string_tracing,
2085         supports_evaluation_of_breakpoint_conditions,
2086         can_run_breakpoint_commands, filesystem_is_local,
2087         can_download_tracepoint, get_trace_state_variable_value,
2088         set_trace_notes, get_tib_address, use_agent, can_use_agent,
2089         record_is_replaying, record_will_replay,
2090         augmented_libraries_svr4_read>: Adjust to return bool.
2091         * aarch64-linux-nat.c: All implementations adjusted.
2092         * aix-thread.c: All implementations adjusted.
2093         * arm-linux-nat.c: All implementations adjusted.
2094         * breakpoint.c: All implementations adjusted.
2095         * bsd-kvm.c: All implementations adjusted.
2096         * bsd-uthread.c: All implementations adjusted.
2097         * corelow.c: All implementations adjusted.
2098         * ctf.c: All implementations adjusted.
2099         * darwin-nat.c: All implementations adjusted.
2100         * darwin-nat.h: All implementations adjusted.
2101         * exec.c: All implementations adjusted.
2102         * fbsd-nat.c: All implementations adjusted.
2103         * fbsd-nat.h: All implementations adjusted.
2104         * gnu-nat.c: All implementations adjusted.
2105         * gnu-nat.h: All implementations adjusted.
2106         * go32-nat.c: All implementations adjusted.
2107         * ia64-linux-nat.c: All implementations adjusted.
2108         * inf-child.c: All implementations adjusted.
2109         * inf-child.h: All implementations adjusted.
2110         * inf-ptrace.c: All implementations adjusted.
2111         * inf-ptrace.h: All implementations adjusted.
2112         * linux-nat.c: All implementations adjusted.
2113         * linux-nat.h: All implementations adjusted.
2114         * mips-linux-nat.c: All implementations adjusted.
2115         * nto-procfs.c: All implementations adjusted.
2116         * ppc-linux-nat.c: All implementations adjusted.
2117         * procfs.c: All implementations adjusted.
2118         * ravenscar-thread.c: All implementations adjusted.
2119         * record-btrace.c: All implementations adjusted.
2120         * record-full.c: All implementations adjusted.
2121         * remote-sim.c: All implementations adjusted.
2122         * remote.c: All implementations adjusted.
2123         * s390-linux-nat.c: All implementations adjusted.
2124         * sol-thread.c: All implementations adjusted.
2125         * spu-multiarch.c: All implementations adjusted.
2126         * target-delegates.c: All implementations adjusted.
2127         * target.c: All implementations adjusted.
2128         * target.h: All implementations adjusted.
2129         * tracefile-tfile.c: All implementations adjusted.
2130         * tracefile.c: All implementations adjusted.
2131         * tracefile.h: All implementations adjusted.
2132         * windows-nat.c: All implementations adjusted.
2133         * x86-linux-nat.h: All implementations adjusted.
2134         * x86-nat.h: All implementations adjusted.
2135
2136 2018-05-02  Pedro Alves  <palves@redhat.com>
2137
2138         * make-target-delegates (scan_target_h): Don't trim lines here.
2139         Replace sequences of tabs and/or whitespace with a single
2140         whitespace.
2141         (top level, parsing methods): Trim each line before processing it
2142         here.
2143
2144 2018-05-02  Pedro Alves  <palves@redhat.com>
2145             John Baldwin  <jhb@freebsd.org>
2146
2147         * target.h (enum strata) <debug_stratum>: New.
2148         (struct target_ops) <all delegation methods>: Replace by C++
2149         virtual methods, and drop "to_" prefix.  All references updated
2150         throughout.
2151         <to_shortname, to_longname, to_doc, to_data,
2152         to_have_steppable_watchpoint, to_have_continuable_watchpoint,
2153         to_has_thread_control, to_attach_no_wait>: Delete, replaced by
2154         virtual methods.  All references updated throughout.
2155         <can_attach, supports_terminal_ours, can_create_inferior,
2156         get_thread_control_capabilities, attach_no_wait>: New
2157         virtual methods.
2158         <insert_breakpoint, remove_breakpoint>: Now
2159         TARGET_DEFAULT_NORETURN methods.
2160         <info_proc>: Now returns bool.
2161         <to_magic>: Delete.
2162         (OPS_MAGIC): Delete.
2163         (current_target): Delete.  All references replaced by references
2164         to ...
2165         (target_stack): ... this.  New.
2166         (target_shortname, target_longname): Adjust.
2167         (target_can_run): Now a function declaration.
2168         (default_child_has_all_memory, default_child_has_memory)
2169         (default_child_has_stack, default_child_has_registers)
2170         (default_child_has_execution): Remove target_ops parameter.
2171         (complete_target_initialization): Delete.
2172         (memory_breakpoint_target): New template class.
2173         (test_target_ops): Refactor as a C++ class with virtual methods.
2174         * make-target-delegates (NAME_PART): Tighten.
2175         (POINTER_PART, CP_SYMBOL): New.
2176         (SIMPLE_RETURN_PART): Reimplement.
2177         (VEC_RETURN_PART): Expect less.
2178         (RETURN_PART, VIRTUAL_PART): New.
2179         (METHOD): Adjust to C++ virtual methods.
2180         (scan_target_h): Remove reference to C99.
2181         (dname): Output "target_ops::" prefix.
2182         (write_function_header): Adjust to output a C++ class method.
2183         (write_declaration): New.
2184         (write_delegator): Adjust to output a C++ class method.
2185         (tdname): Output "dummy_target::" prefix.
2186         (write_tdefault, write_debugmethod): Adjust to output a C++ class
2187         method.
2188         (tdefault_names, debug_names): Delete.
2189         (return_types, tdefaults, styles, argtypes_array): New.
2190         (top level): All methods are delegators.
2191         (print_class): New.
2192         (top level): Print dummy_target and debug_target classes.
2193         * target-delegates.c: Regenerate.
2194         * target-debug.h (target_debug_print_enum_info_proc_what)
2195         (target_debug_print_thread_control_capabilities)
2196         (target_debug_print_thread_info_p): New.
2197         * target.c (dummy_target): Delete.
2198         (the_dummy_target, the_debug_target): New.
2199         (target_stack): Now extern.
2200         (set_targetdebug): Push/unpush debug target.
2201         (default_child_has_all_memory, default_child_has_memory)
2202         (default_child_has_stack, default_child_has_registers)
2203         (default_child_has_execution): Remove target_ops parameter.
2204         (complete_target_initialization): Delete.
2205         (add_target_with_completer): No longer call
2206         complete_target_initialization.
2207         (target_supports_terminal_ours): Use regular delegation.
2208         (update_current_target): Delete.
2209         (push_target): No longer check magic number.  Don't call
2210         update_current_target.
2211         (unpush_target): Don't call update_current_target.
2212         (target_is_pushed): No longer check magic number.
2213         (target_require_runnable): Skip for all stratums over
2214         process_stratum.
2215         (target_ops::info_proc): New.
2216         (target_info_proc): Use find_target_at and
2217         find_default_run_target.
2218         (target_supports_disable_randomization): Use regular delegation.
2219         (target_get_osdata): Use find_target_at.
2220         (target_ops::open, target_ops::close, target_ops::can_attach)
2221         (target_ops::attach, target_ops::can_create_inferior)
2222         (target_ops::create_inferior, target_ops::can_run)
2223         (target_can_run): New.
2224         (default_fileio_target): Use regular delegation.
2225         (target_ops::fileio_open, target_ops::fileio_pwrite)
2226         (target_ops::fileio_pread, target_ops::fileio_fstat)
2227         (target_ops::fileio_close, target_ops::fileio_unlink)
2228         (target_ops::fileio_readlink): New.
2229         (target_fileio_open_1, target_fileio_unlink)
2230         (target_fileio_readlink): Always call the target method.  Handle
2231         FILEIO_ENOSYS.
2232         (return_zero, return_zero_has_execution): Delete.
2233         (init_dummy_target): Delete.
2234         (dummy_target::dummy_target, dummy_target::shortname)
2235         (dummy_target::longname, dummy_target::doc)
2236         (debug_target::debug_target, debug_target::shortname)
2237         (debug_target::longname, debug_target::doc): New.
2238         (target_supports_delete_record): Use regular delegation.
2239         (setup_target_debug): Delete.
2240         (maintenance_print_target_stack): Skip debug_stratum.
2241         (initialize_targets): Instantiate the_dummy_target and
2242         the_debug_target.
2243         * auxv.c (target_auxv_parse): Remove 'ops' parameter.  Adjust to
2244         use target_stack.
2245         (target_auxv_search, fprint_target_auxv): Adjust.
2246         (info_auxv_command): Adjust to use target_stack.
2247         * auxv.h (target_auxv_parse): Remove 'ops' parameter.
2248         * exceptions.c (print_flush): Handle a NULL target_stack.
2249         * regcache.c (target_ops_no_register): Refactor as class with
2250         virtual methods.
2251
2252         * exec.c (exec_target): New class.
2253         (exec_ops): Now an exec_target.
2254         (exec_open, exec_close_1, exec_get_section_table)
2255         (exec_xfer_partial, exec_files_info, exec_has_memory)
2256         (exec_make_note_section): Refactor as exec_target methods.
2257         (exec_file_clear, ignore, exec_remove_breakpoint, init_exec_ops):
2258         Delete.
2259         (exec_target::find_memory_regions): New.
2260         (_initialize_exec): Don't call init_exec_ops.
2261         * gdbcore.h (exec_file_clear): Delete.
2262
2263         * corefile.c (core_target): Delete.
2264         (core_file_command): Adjust.
2265         * corelow.c (core_target): New class.
2266         (the_core_target): New.
2267         (core_close): Remove target_ops parameter.
2268         (core_close_cleanup): Adjust.
2269         (core_target::close): New.
2270         (core_open, core_detach, get_core_registers, core_files_info)
2271         (core_xfer_partial, core_thread_alive, core_read_description)
2272         (core_pid_to_str, core_thread_name, core_has_memory)
2273         (core_has_stack, core_has_registers, core_info_proc): Rework as
2274         core_target methods.
2275         (ignore, core_remove_breakpoint, init_core_ops): Delete.
2276         (_initialize_corelow): Initialize the_core_target.
2277         * gdbcore.h (core_target): Delete.
2278         (the_core_target): New.
2279
2280         * ctf.c: (ctf_target): New class.
2281         (ctf_ops): Now a ctf_target.
2282         (ctf_open, ctf_close, ctf_files_info, ctf_fetch_registers)
2283         (ctf_xfer_partial, ctf_get_trace_state_variable_value)
2284         (ctf_trace_find, ctf_traceframe_info): Refactor as ctf_target
2285         methods.
2286         (init_ctf_ops): Delete.
2287         (_initialize_ctf): Don't call it.
2288         * tracefile-tfile.c (tfile_target): New class.
2289         (tfile_ops): Now a tfile_target.
2290         (tfile_open, tfile_close, tfile_files_info)
2291         (tfile_get_tracepoint_status, tfile_trace_find)
2292         (tfile_fetch_registers, tfile_xfer_partial)
2293         (tfile_get_trace_state_variable_value, tfile_traceframe_info):
2294         Refactor as tfile_target methods.
2295         (tfile_xfer_partial_features): Remove target_ops parameter.
2296         (init_tfile_ops): Delete.
2297         (_initialize_tracefile_tfile): Don't call it.
2298         * tracefile.c (tracefile_has_all_memory, tracefile_has_memory)
2299         (tracefile_has_stack, tracefile_has_registers)
2300         (tracefile_thread_alive, tracefile_get_trace_status): Refactor as
2301         tracefile_target methods.
2302         (init_tracefile_ops): Delete.
2303         (tracefile_target::tracefile_target): New.
2304         * tracefile.h: Include "target.h".
2305         (tracefile_target): New class.
2306         (init_tracefile_ops): Delete.
2307
2308         * spu-multiarch.c (spu_multiarch_target): New class.
2309         (spu_ops): Now a spu_multiarch_target.
2310         (spu_thread_architecture, spu_region_ok_for_hw_watchpoint)
2311         (spu_fetch_registers, spu_store_registers, spu_xfer_partial)
2312         (spu_search_memory, spu_mourn_inferior): Refactor as
2313         spu_multiarch_target methods.
2314         (init_spu_ops): Delete.
2315         (_initialize_spu_multiarch): Remove references to init_spu_ops,
2316         complete_target_initialization.
2317
2318         * ravenscar-thread.c (ravenscar_thread_target): New class.
2319         (ravenscar_ops): Now a ravenscar_thread_target.
2320         (ravenscar_resume, ravenscar_wait, ravenscar_update_thread_list)
2321         (ravenscar_thread_alive, ravenscar_pid_to_str)
2322         (ravenscar_fetch_registers, ravenscar_store_registers)
2323         (ravenscar_prepare_to_store, ravenscar_stopped_by_sw_breakpoint)
2324         (ravenscar_stopped_by_hw_breakpoint)
2325         (ravenscar_stopped_by_watchpoint, ravenscar_stopped_data_address)
2326         (ravenscar_mourn_inferior, ravenscar_core_of_thread)
2327         (ravenscar_get_ada_task_ptid): Refactor as ravenscar_thread_target
2328         methods.
2329         (init_ravenscar_thread_ops): Delete.
2330         (_initialize_ravenscar): Remove references to
2331         init_ravenscar_thread_ops and complete_target_initialization.
2332
2333         * bsd-uthread.c (bsd_uthread_ops_hack): Delete.
2334         (bsd_uthread_target): New class.
2335         (bsd_uthread_ops): Now a bsd_uthread_target.
2336         (bsd_uthread_activate): Adjust to refer to bsd_uthread_ops.
2337         (bsd_uthread_close, bsd_uthread_mourn_inferior)
2338         (bsd_uthread_fetch_registers, bsd_uthread_store_registers)
2339         (bsd_uthread_wait, bsd_uthread_resume, bsd_uthread_thread_alive)
2340         (bsd_uthread_update_thread_list, bsd_uthread_extra_thread_info)
2341         (bsd_uthread_pid_to_str): Refactor as bsd_uthread_target methods.
2342         (bsd_uthread_target): Delete function.
2343         (_initialize_bsd_uthread): Remove reference to
2344         complete_target_initialization.
2345
2346         * bfd-target.c (target_bfd_data): Delete.  Fields folded into ...
2347         (target_bfd): ... this new class.
2348         (target_bfd_xfer_partial, target_bfd_get_section_table)
2349         (target_bfd_close): Refactor as target_bfd methods.
2350         (target_bfd::~target_bfd): New.
2351         (target_bfd_reopen): Adjust.
2352         (target_bfd::close): New.
2353
2354         * record-btrace.c (record_btrace_target): New class.
2355         (record_btrace_ops): Now a record_btrace_target.
2356         (record_btrace_open, record_btrace_stop_recording)
2357         (record_btrace_disconnect, record_btrace_close)
2358         (record_btrace_async, record_btrace_info)
2359         (record_btrace_insn_history, record_btrace_insn_history_range)
2360         (record_btrace_insn_history_from, record_btrace_call_history)
2361         (record_btrace_call_history_range)
2362         (record_btrace_call_history_from, record_btrace_record_method)
2363         (record_btrace_is_replaying, record_btrace_will_replay)
2364         (record_btrace_xfer_partial, record_btrace_insert_breakpoint)
2365         (record_btrace_remove_breakpoint, record_btrace_fetch_registers)
2366         (record_btrace_store_registers, record_btrace_prepare_to_store)
2367         (record_btrace_to_get_unwinder)
2368         (record_btrace_to_get_tailcall_unwinder, record_btrace_resume)
2369         (record_btrace_commit_resume, record_btrace_wait)
2370         (record_btrace_stop, record_btrace_can_execute_reverse)
2371         (record_btrace_stopped_by_sw_breakpoint)
2372         (record_btrace_supports_stopped_by_sw_breakpoint)
2373         (record_btrace_stopped_by_hw_breakpoint)
2374         (record_btrace_supports_stopped_by_hw_breakpoint)
2375         (record_btrace_update_thread_list, record_btrace_thread_alive)
2376         (record_btrace_goto_begin, record_btrace_goto_end)
2377         (record_btrace_goto, record_btrace_stop_replaying_all)
2378         (record_btrace_execution_direction)
2379         (record_btrace_prepare_to_generate_core)
2380         (record_btrace_done_generating_core): Refactor as
2381         record_btrace_target methods.
2382         (init_record_btrace_ops): Delete.
2383         (_initialize_record_btrace): Remove reference to
2384         init_record_btrace_ops.
2385         * record-full.c (RECORD_FULL_IS_REPLAY): Adjust to always refer to
2386         the execution_direction global.
2387         (record_full_base_target, record_full_target)
2388         (record_full_core_target): New classes.
2389         (record_full_ops): Now a record_full_target.
2390         (record_full_core_ops): Now a record_full_core_target.
2391         (record_full_target::detach, record_full_target::disconnect)
2392         (record_full_core_target::disconnect)
2393         (record_full_target::mourn_inferior, record_full_target::kill):
2394         New.
2395         (record_full_open, record_full_close, record_full_async): Refactor
2396         as methods of the record_full_base_target class.
2397         (record_full_resume, record_full_commit_resume): Refactor
2398         as methods of the record_full_target class.
2399         (record_full_wait, record_full_stopped_by_watchpoint)
2400         (record_full_stopped_data_address)
2401         (record_full_stopped_by_sw_breakpoint)
2402         (record_full_supports_stopped_by_sw_breakpoint)
2403         (record_full_stopped_by_hw_breakpoint)
2404         (record_full_supports_stopped_by_hw_breakpoint): Refactor as
2405         methods of the record_full_base_target class.
2406         (record_full_store_registers, record_full_xfer_partial)
2407         (record_full_insert_breakpoint, record_full_remove_breakpoint):
2408         Refactor as methods of the record_full_target class.
2409         (record_full_can_execute_reverse, record_full_get_bookmark)
2410         (record_full_goto_bookmark, record_full_execution_direction)
2411         (record_full_record_method, record_full_info, record_full_delete)
2412         (record_full_is_replaying, record_full_will_replay)
2413         (record_full_goto_begin, record_full_goto_end, record_full_goto)
2414         (record_full_stop_replaying): Refactor as methods of the
2415         record_full_base_target class.
2416         (record_full_core_resume, record_full_core_kill)
2417         (record_full_core_fetch_registers)
2418         (record_full_core_prepare_to_store)
2419         (record_full_core_store_registers, record_full_core_xfer_partial)
2420         (record_full_core_insert_breakpoint)
2421         (record_full_core_remove_breakpoint)
2422         (record_full_core_has_execution): Refactor
2423         as methods of the record_full_core_target class.
2424         (record_full_base_target::supports_delete_record): New.
2425         (init_record_full_ops): Delete.
2426         (init_record_full_core_ops): Delete.
2427         (record_full_save): Refactor as method of the
2428         record_full_base_target class.
2429         (_initialize_record_full): Remove references to
2430         init_record_full_ops and init_record_full_core_ops.
2431
2432         * remote.c (remote_target, extended_remote_target): New classes.
2433         (remote_ops): Now a remote_target.
2434         (extended_remote_ops): Now an extended_remote_target.
2435         (remote_insert_fork_catchpoint, remote_remove_fork_catchpoint)
2436         (remote_insert_vfork_catchpoint, remote_remove_vfork_catchpoint)
2437         (remote_insert_exec_catchpoint, remote_remove_exec_catchpoint)
2438         (remote_pass_signals, remote_set_syscall_catchpoint)
2439         (remote_program_signals, )
2440         (remote_thread_always_alive): Remove target_ops parameter.
2441         (remote_thread_alive, remote_thread_name)
2442         (remote_update_thread_list, remote_threads_extra_info)
2443         (remote_static_tracepoint_marker_at)
2444         (remote_static_tracepoint_markers_by_strid)
2445         (remote_get_ada_task_ptid, remote_close, remote_start_remote)
2446         (remote_open): Refactor as methods of remote_target.
2447         (extended_remote_open, extended_remote_detach)
2448         (extended_remote_attach, extended_remote_post_attach):
2449         (extended_remote_supports_disable_randomization)
2450         (extended_remote_create_inferior): : Refactor as method of
2451         extended_remote_target.
2452         (remote_set_permissions, remote_open_1, remote_detach)
2453         (remote_follow_fork, remote_follow_exec, remote_disconnect)
2454         (remote_resume, remote_commit_resume, remote_stop)
2455         (remote_interrupt, remote_pass_ctrlc, remote_terminal_inferior)
2456         (remote_terminal_ours, remote_wait, remote_fetch_registers)
2457         (remote_prepare_to_store, remote_store_registers)
2458         (remote_flash_erase, remote_flash_done, remote_files_info)
2459         (remote_kill, remote_mourn, remote_insert_breakpoint)
2460         (remote_remove_breakpoint, remote_insert_watchpoint)
2461         (remote_watchpoint_addr_within_range)
2462         (remote_remove_watchpoint, remote_region_ok_for_hw_watchpoint)
2463         (remote_check_watch_resources, remote_stopped_by_sw_breakpoint)
2464         (remote_supports_stopped_by_sw_breakpoint)
2465         (remote_stopped_by_hw_breakpoint)
2466         (remote_supports_stopped_by_hw_breakpoint)
2467         (remote_stopped_by_watchpoint, remote_stopped_data_address)
2468         (remote_insert_hw_breakpoint, remote_remove_hw_breakpoint)
2469         (remote_verify_memory): Refactor as methods of remote_target.
2470         (remote_write_qxfer, remote_read_qxfer): Remove target_ops
2471         parameter.
2472         (remote_xfer_partial, remote_get_memory_xfer_limit)
2473         (remote_search_memory, remote_rcmd, remote_memory_map)
2474         (remote_pid_to_str, remote_get_thread_local_address)
2475         (remote_get_tib_address, remote_read_description): Refactor as
2476         methods of remote_target.
2477         (remote_target::fileio_open, remote_target::fileio_pwrite)
2478         (remote_target::fileio_pread, remote_target::fileio_close): New.
2479         (remote_hostio_readlink, remote_hostio_fstat)
2480         (remote_filesystem_is_local, remote_can_execute_reverse)
2481         (remote_supports_non_stop, remote_supports_disable_randomization)
2482         (remote_supports_multi_process, remote_supports_cond_breakpoints)
2483         (remote_supports_enable_disable_tracepoint)
2484         (remote_supports_string_tracing)
2485         (remote_can_run_breakpoint_commands, remote_trace_init)
2486         (remote_download_tracepoint, remote_can_download_tracepoint)
2487         (remote_download_trace_state_variable, remote_enable_tracepoint)
2488         (remote_disable_tracepoint, remote_trace_set_readonly_regions)
2489         (remote_trace_start, remote_get_trace_status)
2490         (remote_get_tracepoint_status, remote_trace_stop)
2491         (remote_trace_find, remote_get_trace_state_variable_value)
2492         (remote_save_trace_data, remote_get_raw_trace_data)
2493         (remote_set_disconnected_tracing, remote_core_of_thread)
2494         (remote_set_circular_trace_buffer, remote_traceframe_info)
2495         (remote_get_min_fast_tracepoint_insn_len)
2496         (remote_set_trace_buffer_size, remote_set_trace_notes)
2497         (remote_use_agent, remote_can_use_agent, remote_enable_btrace)
2498         (remote_disable_btrace, remote_teardown_btrace)
2499         (remote_read_btrace, remote_btrace_conf)
2500         (remote_augmented_libraries_svr4_read, remote_load)
2501         (remote_pid_to_exec_file, remote_can_do_single_step)
2502         (remote_execution_direction, remote_thread_handle_to_thread_info):
2503         Refactor as methods of remote_target.
2504         (init_remote_ops, init_extended_remote_ops): Delete.
2505         (remote_can_async_p, remote_is_async_p, remote_async)
2506         (remote_thread_events, remote_upload_tracepoints)
2507         (remote_upload_trace_state_variables): Refactor as methods of
2508         remote_target.
2509         (_initialize_remote): Remove references to init_remote_ops and
2510         init_extended_remote_ops.
2511
2512         * remote-sim.c (gdbsim_target): New class.
2513         (gdbsim_fetch_register, gdbsim_store_register, gdbsim_kill)
2514         (gdbsim_load, gdbsim_create_inferior, gdbsim_open, gdbsim_close)
2515         (gdbsim_detach, gdbsim_resume, gdbsim_interrupt)
2516         (gdbsim_wait, gdbsim_prepare_to_store, gdbsim_xfer_partial)
2517         (gdbsim_files_info, gdbsim_mourn_inferior, gdbsim_thread_alive)
2518         (gdbsim_pid_to_str, gdbsim_has_all_memory, gdbsim_has_memory):
2519         Refactor as methods of gdbsim_target.
2520         (gdbsim_ops): Now a gdbsim_target.
2521         (init_gdbsim_ops): Delete.
2522         (gdbsim_cntrl_c): Adjust.
2523         (_initialize_remote_sim): Remove reference to init_gdbsim_ops.
2524
2525         * amd64-linux-nat.c (amd64_linux_nat_target): New class.
2526         (the_amd64_linux_nat_target): New.
2527         (amd64_linux_fetch_inferior_registers)
2528         (amd64_linux_store_inferior_registers): Refactor as methods of
2529         amd64_linux_nat_target.
2530         (_initialize_amd64_linux_nat): Adjust.  Set linux_target.
2531         * i386-linux-nat.c: Don't include "linux-nat.h".
2532         (i386_linux_nat_target): New class.
2533         (the_i386_linux_nat_target): New.
2534         (i386_linux_fetch_inferior_registers)
2535         (i386_linux_store_inferior_registers, i386_linux_resume): Refactor
2536         as methods of i386_linux_nat_target.
2537         (_initialize_i386_linux_nat): Adjust.  Set linux_target.
2538         * inf-child.c (inf_child_ops): Delete.
2539         (inf_child_fetch_inferior_registers)
2540         (inf_child_store_inferior_registers): Delete.
2541         (inf_child_post_attach, inf_child_prepare_to_store): Refactor as
2542         methods of inf_child_target.
2543         (inf_child_target::supports_terminal_ours)
2544         (inf_child_target::terminal_init)
2545         (inf_child_target::terminal_inferior)
2546         (inf_child_target::terminal_ours_for_output)
2547         (inf_child_target::terminal_ours, inf_child_target::interrupt)
2548         (inf_child_target::pass_ctrlc, inf_child_target::terminal_info):
2549         New.
2550         (inf_child_open, inf_child_disconnect, inf_child_close)
2551         (inf_child_mourn_inferior, inf_child_maybe_unpush_target)
2552         (inf_child_post_startup_inferior, inf_child_can_run)
2553         (inf_child_pid_to_exec_file): Refactor as methods of
2554         inf_child_target.
2555         (inf_child_follow_fork): Delete.
2556         (inf_child_target::can_create_inferior)
2557         (inf_child_target::can_attach): New.
2558         (inf_child_target::has_all_memory, inf_child_target::has_memory)
2559         (inf_child_target::has_stack, inf_child_target::has_registers)
2560         (inf_child_target::has_execution): New.
2561         (inf_child_fileio_open, inf_child_fileio_pwrite)
2562         (inf_child_fileio_pread, inf_child_fileio_fstat)
2563         (inf_child_fileio_close, inf_child_fileio_unlink)
2564         (inf_child_fileio_readlink, inf_child_use_agent)
2565         (inf_child_can_use_agent): Refactor as methods of
2566         inf_child_target.
2567         (return_zero, inf_child_target): Delete.
2568         (inf_child_target::inf_child_target): New.
2569         * inf-child.h: Include "target.h".
2570         (inf_child_target): Delete function prototype.
2571         (inf_child_target): New class.
2572         (inf_child_open_target, inf_child_mourn_inferior)
2573         (inf_child_maybe_unpush_target): Delete.
2574         * inf-ptrace.c (inf_ptrace_target::~inf_ptrace_target): New.
2575         (inf_ptrace_follow_fork, inf_ptrace_insert_fork_catchpoint)
2576         (inf_ptrace_remove_fork_catchpoint, inf_ptrace_create_inferior)
2577         (inf_ptrace_post_startup_inferior, inf_ptrace_mourn_inferior)
2578         (inf_ptrace_attach, inf_ptrace_post_attach, inf_ptrace_detach)
2579         (inf_ptrace_detach_success, inf_ptrace_kill, inf_ptrace_resume)
2580         (inf_ptrace_wait, inf_ptrace_xfer_partial)
2581         (inf_ptrace_thread_alive, inf_ptrace_files_info)
2582         (inf_ptrace_pid_to_str, inf_ptrace_auxv_parse): Refactor as
2583         methods of inf_ptrace_target.
2584         (inf_ptrace_target): Delete function.
2585         * inf-ptrace.h: Include "inf-child.h".
2586         (inf_ptrace_target): Delete function declaration.
2587         (inf_ptrace_target): New class.
2588         (inf_ptrace_trad_target, inf_ptrace_detach_success): Delete.
2589         * linux-nat.c (linux_target): New.
2590         (linux_ops, linux_ops_saved, super_xfer_partial): Delete.
2591         (linux_nat_target::~linux_nat_target): New.
2592         (linux_child_post_attach, linux_child_post_startup_inferior)
2593         (linux_child_follow_fork, linux_child_insert_fork_catchpoint)
2594         (linux_child_remove_fork_catchpoint)
2595         (linux_child_insert_vfork_catchpoint)
2596         (linux_child_remove_vfork_catchpoint)
2597         (linux_child_insert_exec_catchpoint)
2598         (linux_child_remove_exec_catchpoint)
2599         (linux_child_set_syscall_catchpoint, linux_nat_pass_signals)
2600         (linux_nat_create_inferior, linux_nat_attach, linux_nat_detach)
2601         (linux_nat_resume, linux_nat_stopped_by_watchpoint)
2602         (linux_nat_stopped_data_address)
2603         (linux_nat_stopped_by_sw_breakpoint)
2604         (linux_nat_supports_stopped_by_sw_breakpoint)
2605         (linux_nat_stopped_by_hw_breakpoint)
2606         (linux_nat_supports_stopped_by_hw_breakpoint, linux_nat_wait)
2607         (linux_nat_kill, linux_nat_mourn_inferior)
2608         (linux_nat_xfer_partial, linux_nat_thread_alive)
2609         (linux_nat_update_thread_list, linux_nat_pid_to_str)
2610         (linux_nat_thread_name, linux_child_pid_to_exec_file)
2611         (linux_child_static_tracepoint_markers_by_strid)
2612         (linux_nat_is_async_p, linux_nat_can_async_p)
2613         (linux_nat_supports_non_stop, linux_nat_always_non_stop_p)
2614         (linux_nat_supports_multi_process)
2615         (linux_nat_supports_disable_randomization, linux_nat_async)
2616         (linux_nat_stop, linux_nat_close, linux_nat_thread_address_space)
2617         (linux_nat_core_of_thread, linux_nat_filesystem_is_local)
2618         (linux_nat_fileio_open, linux_nat_fileio_readlink)
2619         (linux_nat_fileio_unlink, linux_nat_thread_events): Refactor as
2620         methods of linux_nat_target.
2621         (linux_nat_wait_1, linux_xfer_siginfo, linux_proc_xfer_partial)
2622         (linux_proc_xfer_spu, linux_nat_xfer_osdata): Remove target_ops
2623         parameter.
2624         (check_stopped_by_watchpoint): Adjust.
2625         (linux_xfer_partial): Delete.
2626         (linux_target_install_ops, linux_target, linux_nat_add_target):
2627         Delete.
2628         (linux_nat_target::linux_nat_target): New.
2629         * linux-nat.h: Include "inf-ptrace.h".
2630         (linux_nat_target): New.
2631         (linux_target, linux_target_install_ops, linux_nat_add_target):
2632         Delete function declarations.
2633         (linux_target): Declare global.
2634         * linux-thread-db.c (thread_db_target): New.
2635         (thread_db_target::thread_db_target): New.
2636         (thread_db_ops): Delete.
2637         (the_thread_db_target): New.
2638         (thread_db_detach, thread_db_wait, thread_db_mourn_inferior)
2639         (thread_db_update_thread_list, thread_db_pid_to_str)
2640         (thread_db_extra_thread_info)
2641         (thread_db_thread_handle_to_thread_info)
2642         (thread_db_get_thread_local_address, thread_db_get_ada_task_ptid)
2643         (thread_db_resume): Refactor as methods of thread_db_target.
2644         (init_thread_db_ops): Delete.
2645         (_initialize_thread_db): Remove reference to init_thread_db_ops.
2646         * x86-linux-nat.c: Don't include "linux-nat.h".
2647         (super_post_startup_inferior): Delete.
2648         (x86_linux_nat_target::~x86_linux_nat_target): New.
2649         (x86_linux_child_post_startup_inferior)
2650         (x86_linux_read_description, x86_linux_enable_btrace)
2651         (x86_linux_disable_btrace, x86_linux_teardown_btrace)
2652         (x86_linux_read_btrace, x86_linux_btrace_conf): Refactor as
2653         methods of x86_linux_nat_target.
2654         (x86_linux_create_target): Delete.  Bits folded ...
2655         (x86_linux_add_target): ... here.  Now takes a linux_nat_target
2656         pointer.
2657         * x86-linux-nat.h: Include "linux-nat.h" and "x86-nat.h".
2658         (x86_linux_nat_target): New class.
2659         (x86_linux_create_target): Delete.
2660         (x86_linux_add_target): Now takes a linux_nat_target pointer.
2661         * x86-nat.c (x86_insert_watchpoint, x86_remove_watchpoint)
2662         (x86_region_ok_for_watchpoint, x86_stopped_data_address)
2663         (x86_stopped_by_watchpoint, x86_insert_hw_breakpoint)
2664         (x86_remove_hw_breakpoint, x86_can_use_hw_breakpoint)
2665         (x86_stopped_by_hw_breakpoint): Remove target_ops parameter and
2666         make extern.
2667         (x86_use_watchpoints): Delete.
2668         * x86-nat.h: Include "breakpoint.h" and "target.h".
2669         (x86_use_watchpoints): Delete.
2670         (x86_can_use_hw_breakpoint, x86_region_ok_for_hw_watchpoint)
2671         (x86_stopped_by_watchpoint, x86_stopped_data_address)
2672         (x86_insert_watchpoint, x86_remove_watchpoint)
2673         (x86_insert_hw_breakpoint, x86_remove_hw_breakpoint)
2674         (x86_stopped_by_hw_breakpoint): New declarations.
2675         (x86_nat_target): New template class.
2676
2677         * ppc-linux-nat.c (ppc_linux_nat_target): New class.
2678         (the_ppc_linux_nat_target): New.
2679         (ppc_linux_fetch_inferior_registers)
2680         (ppc_linux_can_use_hw_breakpoint)
2681         (ppc_linux_region_ok_for_hw_watchpoint)
2682         (ppc_linux_ranged_break_num_registers)
2683         (ppc_linux_insert_hw_breakpoint, ppc_linux_remove_hw_breakpoint)
2684         (ppc_linux_insert_mask_watchpoint)
2685         (ppc_linux_remove_mask_watchpoint)
2686         (ppc_linux_can_accel_watchpoint_condition)
2687         (ppc_linux_insert_watchpoint, ppc_linux_remove_watchpoint)
2688         (ppc_linux_stopped_data_address, ppc_linux_stopped_by_watchpoint)
2689         (ppc_linux_watchpoint_addr_within_range)
2690         (ppc_linux_masked_watch_num_registers)
2691         (ppc_linux_store_inferior_registers, ppc_linux_auxv_parse)
2692         (ppc_linux_read_description): Refactor as methods of
2693         ppc_linux_nat_target.
2694         (_initialize_ppc_linux_nat): Adjust.  Set linux_target.
2695
2696         * procfs.c (procfs_xfer_partial): Delete forward declaration.
2697         (procfs_target): New class.
2698         (the_procfs_target): New.
2699         (procfs_target): Delete function.
2700         (procfs_auxv_parse, procfs_attach, procfs_detach)
2701         (procfs_fetch_registers, procfs_store_registers, procfs_wait)
2702         (procfs_xfer_partial, procfs_resume, procfs_pass_signals)
2703         (procfs_files_info, procfs_kill_inferior, procfs_mourn_inferior)
2704         (procfs_create_inferior, procfs_update_thread_list)
2705         (procfs_thread_alive, procfs_pid_to_str)
2706         (procfs_can_use_hw_breakpoint, procfs_stopped_by_watchpoint)
2707         (procfs_stopped_data_address, procfs_insert_watchpoint)
2708         (procfs_remove_watchpoint, procfs_region_ok_for_hw_watchpoint)
2709         (proc_find_memory_regions, procfs_info_proc)
2710         (procfs_make_note_section): Refactor as methods of procfs_target.
2711         (_initialize_procfs): Adjust.
2712         * sol-thread.c (sol_thread_target): New class.
2713         (sol_thread_ops): Now a sol_thread_target.
2714         (sol_thread_detach, sol_thread_resume, sol_thread_wait)
2715         (sol_thread_fetch_registers, sol_thread_store_registers)
2716         (sol_thread_xfer_partial, sol_thread_mourn_inferior)
2717         (sol_thread_alive, solaris_pid_to_str, sol_update_thread_list)
2718         (sol_get_ada_task_ptid): Refactor as methods of sol_thread_target.
2719         (init_sol_thread_ops): Delete.
2720         (_initialize_sol_thread): Adjust.  Remove references to
2721         init_sol_thread_ops and complete_target_initialization.
2722
2723         * windows-nat.c (windows_nat_target): New class.
2724         (windows_fetch_inferior_registers)
2725         (windows_store_inferior_registers, windows_resume, windows_wait)
2726         (windows_attach, windows_detach, windows_pid_to_exec_file)
2727         (windows_files_info, windows_create_inferior)
2728         (windows_mourn_inferior, windows_interrupt, windows_kill_inferior)
2729         (windows_close, windows_pid_to_str, windows_xfer_partial)
2730         (windows_get_tib_address, windows_get_ada_task_ptid)
2731         (windows_thread_name, windows_thread_alive): Refactor as
2732         windows_nat_target methods.
2733         (do_initial_windows_stuff): Adjust.
2734         (windows_target): Delete function.
2735         (_initialize_windows_nat): Adjust.
2736
2737         * darwin-nat.c (darwin_resume, darwin_wait_to, darwin_interrupt)
2738         (darwin_mourn_inferior, darwin_kill_inferior)
2739         (darwin_create_inferior, darwin_attach, darwin_detach)
2740         (darwin_pid_to_str, darwin_thread_alive, darwin_xfer_partial)
2741         (darwin_pid_to_exec_file, darwin_get_ada_task_ptid)
2742         (darwin_supports_multi_process): Refactor as darwin_nat_target
2743         methods.
2744         (darwin_resume_to, darwin_files_info): Delete.
2745         (_initialize_darwin_inferior): Rename to ...
2746         (_initialize_darwin_nat): ... this.  Adjust to C++ification.
2747         * darwin-nat.h: Include "inf-child.h".
2748         (darwin_nat_target): New class.
2749         (darwin_complete_target): Delete.
2750         * i386-darwin-nat.c (i386_darwin_nat_target): New class.
2751         (darwin_target): New.
2752         (i386_darwin_fetch_inferior_registers)
2753         (i386_darwin_store_inferior_registers): Refactor as methods of
2754         darwin_nat_target.
2755         (darwin_complete_target): Delete, with ...
2756         (_initialize_i386_darwin_nat): ... bits factored out here.
2757
2758         * alpha-linux-nat.c (alpha_linux_nat_target): New class.
2759         (the_alpha_linux_nat_target): New.
2760         (alpha_linux_register_u_offset): Refactor as
2761         alpha_linux_nat_target method.
2762         (_initialize_alpha_linux_nat): Adjust.
2763         * linux-nat-trad.c (inf_ptrace_register_u_offset): Delete.
2764         (inf_ptrace_fetch_register, inf_ptrace_fetch_registers)
2765         (inf_ptrace_store_register, inf_ptrace_store_registers): Refact as
2766         methods of linux_nat_trad_target.
2767         (linux_trad_target): Delete.
2768         * linux-nat-trad.h (linux_trad_target): Delete function.
2769         (linux_nat_trad_target): New class.
2770         * mips-linux-nat.c (mips_linux_nat_target): New class.
2771         (super_fetch_registers, super_store_registers, super_close):
2772         Delete.
2773         (the_mips_linux_nat_target): New.
2774         (mips64_linux_regsets_fetch_registers)
2775         (mips64_linux_regsets_store_registers)
2776         (mips64_linux_fetch_registers, mips64_linux_store_registers)
2777         (mips_linux_register_u_offset, mips_linux_read_description)
2778         (mips_linux_can_use_hw_breakpoint)
2779         (mips_linux_stopped_by_watchpoint)
2780         (mips_linux_stopped_data_address)
2781         (mips_linux_region_ok_for_hw_watchpoint)
2782         (mips_linux_insert_watchpoint, mips_linux_remove_watchpoint)
2783         (mips_linux_close): Refactor as methods of mips_linux_nat.
2784         (_initialize_mips_linux_nat): Adjust to C++ification.
2785
2786         * aix-thread.c (aix_thread_target): New class.
2787         (aix_thread_ops): Now an aix_thread_target.
2788         (aix_thread_detach, aix_thread_resume, aix_thread_wait)
2789         (aix_thread_fetch_registers, aix_thread_store_registers)
2790         (aix_thread_xfer_partial, aix_thread_mourn_inferior)
2791         (aix_thread_thread_alive, aix_thread_pid_to_str)
2792         (aix_thread_extra_thread_info, aix_thread_get_ada_task_ptid):
2793         Refactor as methods of aix_thread_target.
2794         (init_aix_thread_ops): Delete.
2795         (_initialize_aix_thread): Remove references to init_aix_thread_ops
2796         and complete_target_initialization.
2797         * rs6000-nat.c (rs6000_xfer_shared_libraries): Delete.
2798         (rs6000_nat_target): New class.
2799         (the_rs6000_nat_target): New.
2800         (rs6000_fetch_inferior_registers, rs6000_store_inferior_registers)
2801         (rs6000_xfer_partial, rs6000_wait, rs6000_create_inferior)
2802         (rs6000_xfer_shared_libraries): Refactor as rs6000_nat_target methods.
2803         (super_create_inferior): Delete.
2804         (_initialize_rs6000_nat): Adjust to C++ification.
2805
2806         * arm-linux-nat.c (arm_linux_nat_target): New class.
2807         (the_arm_linux_nat_target): New.
2808         (arm_linux_fetch_inferior_registers)
2809         (arm_linux_store_inferior_registers, arm_linux_read_description)
2810         (arm_linux_can_use_hw_breakpoint, arm_linux_insert_hw_breakpoint)
2811         (arm_linux_remove_hw_breakpoint)
2812         (arm_linux_region_ok_for_hw_watchpoint)
2813         (arm_linux_insert_watchpoint, arm_linux_remove_watchpoint)
2814         (arm_linux_stopped_data_address, arm_linux_stopped_by_watchpoint)
2815         (arm_linux_watchpoint_addr_within_range): Refactor as methods of
2816         arm_linux_nat_target.
2817         (_initialize_arm_linux_nat): Adjust to C++ification.
2818
2819         * aarch64-linux-nat.c (aarch64_linux_nat_target): New class.
2820         (the_aarch64_linux_nat_target): New.
2821         (aarch64_linux_fetch_inferior_registers)
2822         (aarch64_linux_store_inferior_registers)
2823         (aarch64_linux_child_post_startup_inferior)
2824         (aarch64_linux_read_description)
2825         (aarch64_linux_can_use_hw_breakpoint)
2826         (aarch64_linux_insert_hw_breakpoint)
2827         (aarch64_linux_remove_hw_breakpoint)
2828         (aarch64_linux_insert_watchpoint, aarch64_linux_remove_watchpoint)
2829         (aarch64_linux_region_ok_for_hw_watchpoint)
2830         (aarch64_linux_stopped_data_address)
2831         (aarch64_linux_stopped_by_watchpoint)
2832         (aarch64_linux_watchpoint_addr_within_range)
2833         (aarch64_linux_can_do_single_step): Refactor as methods of
2834         aarch64_linux_nat_target.
2835         (super_post_startup_inferior): Delete.
2836         (_initialize_aarch64_linux_nat): Adjust to C++ification.
2837
2838         * hppa-linux-nat.c (hppa_linux_nat_target): New class.
2839         (the_hppa_linux_nat_target): New.
2840         (hppa_linux_fetch_inferior_registers)
2841         (hppa_linux_store_inferior_registers): Refactor as methods of
2842         hppa_linux_nat_target.
2843         (_initialize_hppa_linux_nat): Adjust to C++ification.
2844
2845         * ia64-linux-nat.c (ia64_linux_nat_target): New class.
2846         (the_ia64_linux_nat_target): New.
2847         (ia64_linux_insert_watchpoint, ia64_linux_remove_watchpoint)
2848         (ia64_linux_stopped_data_address)
2849         (ia64_linux_stopped_by_watchpoint, ia64_linux_fetch_registers)
2850         (ia64_linux_store_registers, ia64_linux_xfer_partial): Refactor as
2851         ia64_linux_nat_target methods.
2852         (super_xfer_partial): Delete.
2853         (_initialize_ia64_linux_nat): Adjust to C++ification.
2854
2855         * m32r-linux-nat.c (m32r_linux_nat_target): New class.
2856         (the_m32r_linux_nat_target): New.
2857         (m32r_linux_fetch_inferior_registers)
2858         (m32r_linux_store_inferior_registers): Refactor as
2859         m32r_linux_nat_target methods.
2860         (_initialize_m32r_linux_nat): Adjust to C++ification.
2861
2862         * m68k-linux-nat.c (m68k_linux_nat_target): New class.
2863         (the_m68k_linux_nat_target): New.
2864         (m68k_linux_fetch_inferior_registers)
2865         (m68k_linux_store_inferior_registers): Refactor as
2866         m68k_linux_nat_target methods.
2867         (_initialize_m68k_linux_nat): Adjust to C++ification.
2868
2869         * s390-linux-nat.c (s390_linux_nat_target): New class.
2870         (the_s390_linux_nat_target): New.
2871         (s390_linux_fetch_inferior_registers)
2872         (s390_linux_store_inferior_registers, s390_stopped_by_watchpoint)
2873         (s390_insert_watchpoint, s390_remove_watchpoint)
2874         (s390_can_use_hw_breakpoint, s390_insert_hw_breakpoint)
2875         (s390_remove_hw_breakpoint, s390_region_ok_for_hw_watchpoint)
2876         (s390_auxv_parse, s390_read_description): Refactor as methods of
2877         s390_linux_nat_target.
2878         (_initialize_s390_nat): Adjust to C++ification.
2879
2880         * sparc-linux-nat.c (sparc_linux_nat_target): New class.
2881         (the_sparc_linux_nat_target): New.
2882         (_initialize_sparc_linux_nat): Adjust to C++ification.
2883         * sparc-nat.c (sparc_fetch_inferior_registers)
2884         (sparc_store_inferior_registers): Remove target_ops parameter.
2885         * sparc-nat.h (sparc_fetch_inferior_registers)
2886         (sparc_store_inferior_registers): Remove target_ops parameter.
2887         * sparc64-linux-nat.c (sparc64_linux_nat_target): New class.
2888         (the_sparc64_linux_nat_target): New.
2889         (_initialize_sparc64_linux_nat): Adjust to C++ification.
2890
2891         * spu-linux-nat.c (spu_linux_nat_target): New class.
2892         (the_spu_linux_nat_target): New.
2893         (spu_child_post_startup_inferior, spu_child_post_attach)
2894         (spu_child_wait, spu_fetch_inferior_registers)
2895         (spu_store_inferior_registers, spu_xfer_partial)
2896         (spu_can_use_hw_breakpoint): Refactor as spu_linux_nat_target
2897         methods.
2898         (_initialize_spu_nat): Adjust to C++ification.
2899
2900         * tilegx-linux-nat.c (tilegx_linux_nat_target): New class.
2901         (the_tilegx_linux_nat_target): New.
2902         (fetch_inferior_registers, store_inferior_registers):
2903         Refactor as methods.
2904         (_initialize_tile_linux_nat): Adjust to C++ification.
2905
2906         * xtensa-linux-nat.c (xtensa_linux_nat_target): New class.
2907         (the_xtensa_linux_nat_target): New.
2908         (xtensa_linux_fetch_inferior_registers)
2909         (xtensa_linux_store_inferior_registers): Refactor as
2910         xtensa_linux_nat_target methods.
2911         (_initialize_xtensa_linux_nat): Adjust to C++ification.
2912
2913         * fbsd-nat.c (USE_SIGTRAP_SIGINFO): Delete.
2914         (fbsd_pid_to_exec_file, fbsd_find_memory_regions)
2915         (fbsd_find_memory_regions, fbsd_info_proc, fbsd_xfer_partial)
2916         (fbsd_thread_alive, fbsd_pid_to_str, fbsd_thread_name)
2917         (fbsd_update_thread_list, fbsd_resume, fbsd_wait)
2918         (fbsd_stopped_by_sw_breakpoint)
2919         (fbsd_supports_stopped_by_sw_breakpoint, fbsd_follow_fork)
2920         (fbsd_insert_fork_catchpoint, fbsd_remove_fork_catchpoint)
2921         (fbsd_insert_vfork_catchpoint, fbsd_remove_vfork_catchpoint)
2922         (fbsd_post_startup_inferior, fbsd_post_attach)
2923         (fbsd_insert_exec_catchpoint, fbsd_remove_exec_catchpoint)
2924         (fbsd_set_syscall_catchpoint)
2925         (super_xfer_partial, super_resume, super_wait)
2926         (fbsd_supports_stopped_by_hw_breakpoint): Delete.
2927         (fbsd_handle_debug_trap): Remove target_ops parameter.
2928         (fbsd_nat_add_target): Delete.
2929         * fbsd-nat.h: Include "inf-ptrace.h".
2930         (fbsd_nat_add_target): Delete.
2931         (USE_SIGTRAP_SIGINFO): Define.
2932         (fbsd_nat_target): New class.
2933
2934         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers)
2935         (amd64bsd_store_inferior_registers): Remove target_ops parameter.
2936         (amd64bsd_target): Delete.
2937         * amd64-bsd-nat.h: New file.
2938         * amd64-fbsd-nat.c: Include "amd64-bsd-nat.h" instead of
2939         "x86-bsd-nat.h".
2940         (amd64_fbsd_nat_target): New class.
2941         (the_amd64_fbsd_nat_target): New.
2942         (amd64fbsd_read_description): Refactor as method of
2943         amd64_fbsd_nat_target.
2944         (amd64_fbsd_nat_target::supports_stopped_by_hw_breakpoint): New.
2945         (_initialize_amd64fbsd_nat): Adjust to C++ification.
2946         * amd64-nat.h (amd64bsd_target): Delete function declaration.
2947         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers)
2948         (i386bsd_store_inferior_registers): Remove target_ops parameter.
2949         (i386bsd_target): Delete.
2950         * i386-bsd-nat.h (i386bsd_target): Delete function declaration.
2951         (i386bsd_fetch_inferior_registers)
2952         (i386bsd_store_inferior_registers): Declare.
2953         (i386_bsd_nat_target): New class.
2954         * i386-fbsd-nat.c (i386_fbsd_nat_target): New class.
2955         (the_i386_fbsd_nat_target): New.
2956         (i386fbsd_resume, i386fbsd_read_description): Refactor as
2957         i386_fbsd_nat_target methods.
2958         (i386_fbsd_nat_target::supports_stopped_by_hw_breakpoint): New.
2959         (_initialize_i386fbsd_nat): Adjust to C++ification.
2960         * x86-bsd-nat.c (super_mourn_inferior): Delete.
2961         (x86bsd_mourn_inferior, x86bsd_target): Delete.
2962         (_initialize_x86_bsd_nat): Adjust to C++ification.
2963         * x86-bsd-nat.h: Include "x86-nat.h".
2964         (x86bsd_target): Delete declaration.
2965         (x86bsd_nat_target): New class.
2966
2967         * aarch64-fbsd-nat.c (aarch64_fbsd_nat_target): New class.
2968         (the_aarch64_fbsd_nat_target): New.
2969         (aarch64_fbsd_fetch_inferior_registers)
2970         (aarch64_fbsd_store_inferior_registers): Refactor as methods of
2971         aarch64_fbsd_nat_target.
2972         (_initialize_aarch64_fbsd_nat): Adjust to C++ification.
2973         * alpha-bsd-nat.c (alpha_bsd_nat_target): New class.
2974         (the_alpha_bsd_nat_target): New.
2975         (alphabsd_fetch_inferior_registers)
2976         (alphabsd_store_inferior_registers): Refactor as
2977         alpha_bsd_nat_target methods.
2978         (_initialize_alphabsd_nat): Refactor as methods of
2979         alpha_bsd_nat_target.
2980         * amd64-nbsd-nat.c: Include "amd64-bsd-nat.h".
2981         (the_amd64_nbsd_nat_target): New.
2982         (_initialize_amd64nbsd_nat): Adjust to C++ification.
2983         * amd64-obsd-nat.c: Include "amd64-bsd-nat.h".
2984         (the_amd64_obsd_nat_target): New.
2985         (_initialize_amd64obsd_nat): Adjust to C++ification.
2986         * arm-fbsd-nat.c (arm_fbsd_nat_target): New.
2987         (the_arm_fbsd_nat_target): New.
2988         (arm_fbsd_fetch_inferior_registers)
2989         (arm_fbsd_store_inferior_registers, arm_fbsd_read_description):
2990         (_initialize_arm_fbsd_nat): Refactor as methods of
2991         arm_fbsd_nat_target.
2992         (_initialize_arm_fbsd_nat): Adjust to C++ification.
2993         * arm-nbsd-nat.c (arm_netbsd_nat_target): New class.
2994         (the_arm_netbsd_nat_target): New.
2995         (armnbsd_fetch_registers, armnbsd_store_registers): Refactor as
2996         arm_netbsd_nat_target.
2997         (_initialize_arm_netbsd_nat): Adjust to C++ification.
2998         * hppa-nbsd-nat.c (hppa_nbsd_nat_target): New class.
2999         (the_hppa_nbsd_nat_target): New.
3000         (hppanbsd_fetch_registers, hppanbsd_store_registers): Refactor as
3001         hppa_nbsd_nat_target methods.
3002         (_initialize_hppanbsd_nat): Adjust to C++ification.
3003         * hppa-obsd-nat.c (hppa_obsd_nat_target): New class.
3004         (the_hppa_obsd_nat_target): New.
3005         (hppaobsd_fetch_registers, hppaobsd_store_registers): Refactor as
3006         methods of hppa_obsd_nat_target.
3007         (_initialize_hppaobsd_nat): Adjust to C++ification.  Use
3008         add_target.
3009         * i386-nbsd-nat.c (the_i386_nbsd_nat_target): New.
3010         (_initialize_i386nbsd_nat): Adjust to C++ification.  Use
3011         add_target.
3012         * i386-obsd-nat.c (the_i386_obsd_nat_target): New.
3013         (_initialize_i386obsd_nat): Use add_target.
3014         * m68k-bsd-nat.c (m68k_bsd_nat_target): New class.
3015         (the_m68k_bsd_nat_target): New.
3016         (m68kbsd_fetch_inferior_registers)
3017         (m68kbsd_store_inferior_registers): Refactor as methods of
3018         m68k_bsd_nat_target.
3019         (_initialize_m68kbsd_nat): Adjust to C++ification.
3020         * mips-fbsd-nat.c (mips_fbsd_nat_target): New class.
3021         (the_mips_fbsd_nat_target): New.
3022         (mips_fbsd_fetch_inferior_registers)
3023         (mips_fbsd_store_inferior_registers): Refactor as methods of
3024         mips_fbsd_nat_target.
3025         (_initialize_mips_fbsd_nat): Adjust to C++ification.  Use
3026         add_target.
3027         * mips-nbsd-nat.c (mips_nbsd_nat_target): New class.
3028         (the_mips_nbsd_nat_target): New.
3029         (mipsnbsd_fetch_inferior_registers)
3030         (mipsnbsd_store_inferior_registers): Refactor as methods of
3031         mips_nbsd_nat_target.
3032         (_initialize_mipsnbsd_nat): Adjust to C++ification.
3033         * mips64-obsd-nat.c (mips64_obsd_nat_target): New class.
3034         (the_mips64_obsd_nat_target): New.
3035         (mips64obsd_fetch_inferior_registers)
3036         (mips64obsd_store_inferior_registers): Refactor as methods of
3037         mips64_obsd_nat_target.
3038         (_initialize_mips64obsd_nat): Adjust to C++ification.  Use
3039         add_target.
3040         * nbsd-nat.c (nbsd_pid_to_exec_file): Refactor as method of
3041         nbsd_nat_target.
3042         * nbsd-nat.h: Include "inf-ptrace.h".
3043         (nbsd_nat_target): New class.
3044         * obsd-nat.c (obsd_pid_to_str, obsd_update_thread_list)
3045         (obsd_wait): Refactor as methods of obsd_nat_target.
3046         (obsd_add_target): Delete.
3047         * obsd-nat.h: Include "inf-ptrace.h".
3048         (obsd_nat_target): New class.
3049         * ppc-fbsd-nat.c (ppc_fbsd_nat_target): New class.
3050         (the_ppc_fbsd_nat_target): New.
3051         (ppcfbsd_fetch_inferior_registers)
3052         (ppcfbsd_store_inferior_registers): Refactor as methods of
3053         ppc_fbsd_nat_target.
3054         (_initialize_ppcfbsd_nat): Adjust to C++ification.  Use
3055         add_target.
3056         * ppc-nbsd-nat.c (ppc_nbsd_nat_target): New class.
3057         (the_ppc_nbsd_nat_target): New.
3058         (ppcnbsd_fetch_inferior_registers)
3059         (ppcnbsd_store_inferior_registers): Refactor as methods of
3060         ppc_nbsd_nat_target.
3061         (_initialize_ppcnbsd_nat): Adjust to C++ification.
3062         * ppc-obsd-nat.c (ppc_obsd_nat_target): New class.
3063         (the_ppc_obsd_nat_target): New.
3064         (ppcobsd_fetch_registers, ppcobsd_store_registers): Refactor as
3065         methods of ppc_obsd_nat_target.
3066         (_initialize_ppcobsd_nat): Adjust to C++ification.  Use
3067         add_target.
3068         * sh-nbsd-nat.c (sh_nbsd_nat_target): New class.
3069         (the_sh_nbsd_nat_target): New.
3070         (shnbsd_fetch_inferior_registers)
3071         (shnbsd_store_inferior_registers): Refactor as methods of
3072         sh_nbsd_nat_target.
3073         (_initialize_shnbsd_nat): Adjust to C++ification.
3074         * sparc-nat.c (sparc_xfer_wcookie): Make extern.
3075         (inf_ptrace_xfer_partial): Delete.
3076         (sparc_xfer_partial, sparc_target): Delete.
3077         * sparc-nat.h (sparc_fetch_inferior_registers)
3078         (sparc_store_inferior_registers, sparc_xfer_wcookie): Declare.
3079         (sparc_target): Delete function declaration.
3080         (sparc_target): New template class.
3081         * sparc-nbsd-nat.c (the_sparc_nbsd_nat_target): New.
3082         (_initialize_sparcnbsd_nat): Adjust to C++ification.
3083         * sparc64-fbsd-nat.c (the_sparc64_fbsd_nat_target): New.
3084         (_initialize_sparc64fbsd_nat): Adjust to C++ification.  Use
3085         add_target.
3086         * sparc64-nbsd-nat.c (the_sparc64_nbsd_nat_target): New.
3087         (_initialize_sparc64nbsd_nat): Adjust to C++ification.
3088         * sparc64-obsd-nat.c (the_sparc64_obsd_nat_target): New.
3089         (_initialize_sparc64obsd_nat): Adjust to C++ification.  Use
3090         add_target.
3091         * vax-bsd-nat.c (vax_bsd_nat_target): New class.
3092         (the_vax_bsd_nat_target): New.
3093         (vaxbsd_fetch_inferior_registers)
3094         (vaxbsd_store_inferior_registers): Refactor as vax_bsd_nat_target
3095         methods.
3096         (_initialize_vaxbsd_nat): Adjust to C++ification.
3097
3098         * bsd-kvm.c (bsd_kvm_target): New class.
3099         (bsd_kvm_ops): Now a bsd_kvm_target.
3100         (bsd_kvm_open, bsd_kvm_close, bsd_kvm_xfer_partial)
3101         (bsd_kvm_files_info, bsd_kvm_fetch_registers)
3102         (bsd_kvm_thread_alive, bsd_kvm_pid_to_str): Refactor as methods of
3103         bsd_kvm_target.
3104         (bsd_kvm_return_one): Delete.
3105         (bsd_kvm_add_target): Adjust to C++ification.
3106
3107         * nto-procfs.c (nto_procfs_target, nto_procfs_target_native)
3108         (nto_procfs_target_procfs): New classes.
3109         (procfs_open_1, procfs_thread_alive, procfs_update_thread_list)
3110         (procfs_files_info, procfs_pid_to_exec_file, procfs_attach)
3111         (procfs_post_attach, procfs_wait, procfs_fetch_registers)
3112         (procfs_xfer_partial, procfs_detach, procfs_insert_breakpoint)
3113         (procfs_remove_breakpoint, procfs_insert_hw_breakpoint)
3114         (procfs_remove_hw_breakpoint, procfs_resume)
3115         (procfs_mourn_inferior, procfs_create_inferior, procfs_interrupt)
3116         (procfs_kill_inferior, procfs_store_registers)
3117         (procfs_pass_signals, procfs_pid_to_str, procfs_can_run): Refactor
3118         as methods of nto_procfs_target.
3119         (nto_procfs_ops): Now an nto_procfs_target_procfs.
3120         (nto_native_ops): Delete.
3121         (procfs_open, procfs_native_open): Delete.
3122         (nto_native_ops): Now an nto_procfs_target_native.
3123         (init_procfs_targets): Adjust to C++ification.
3124         (procfs_can_use_hw_breakpoint, procfs_remove_hw_watchpoint)
3125         (procfs_insert_hw_watchpoint, procfs_stopped_by_watchpoint):
3126         Refactor as methods of nto_procfs_target.
3127
3128         * go32-nat.c (go32_nat_target): New class.
3129         (the_go32_nat_target): New.
3130         (go32_attach, go32_resume, go32_wait, go32_fetch_registers)
3131         (go32_store_registers, go32_xfer_partial, go32_files_info)
3132         (go32_kill_inferior, go32_create_inferior, go32_mourn_inferior)
3133         (go32_terminal_init, go32_terminal_info, go32_terminal_inferior)
3134         (go32_terminal_ours, go32_pass_ctrlc, go32_thread_alive)
3135         (go32_pid_to_str): Refactor as methods of go32_nat_target.
3136         (go32_target): Delete.
3137         (_initialize_go32_nat): Adjust to C++ification.
3138
3139         * gnu-nat.c (gnu_wait, gnu_resume, gnu_kill_inferior)
3140         (gnu_mourn_inferior, gnu_create_inferior, gnu_attach, gnu_detach)
3141         (gnu_stop, gnu_thread_alive, gnu_xfer_partial)
3142         (gnu_find_memory_regions, gnu_pid_to_str): Refactor as methods of
3143         gnu_nat_target.
3144         (gnu_target): Delete.
3145         * gnu-nat.h (gnu_target): Delete.
3146         (gnu_nat_target): New class.
3147         * i386-gnu-nat.c (gnu_base_target): New.
3148         (i386_gnu_nat_target): New class.
3149         (the_i386_gnu_nat_target): New.
3150         (_initialize_i386gnu_nat): Adjust to C++ification.
3151
3152 2018-05-02  Pedro Alves  <palves@redhat.com>
3153
3154         * bfd-target.c (target_bfd_xclose): Rename to ...
3155         (target_bfd_close): ... this.
3156         (target_bfd_reopen): Adjust.
3157         * target.c (target_close): Remove references to to_xclose.
3158         * target.h (target_ops::to_xclose): Delete.
3159         (target_ops::to_close): Update comments.
3160
3161 2018-05-02  Pedro Alves  <palves@redhat.com>
3162
3163         * alpha-linux-nat.c: Include "linux-nat-trad.h" instead of
3164         "linux-nat.h".
3165         * configure.nat (alpha-linux, linux-mips): Add linux-nat-trad.o.
3166         * inf-ptrace.c (inf_ptrace_register_u_offset)
3167         (inf_ptrace_fetch_register, inf_ptrace_fetch_registers)
3168         (inf_ptrace_store_register, inf_ptrace_store_registers)
3169         (inf_ptrace_trad_target): Move to ...
3170         * linux-nat-trad.c: ... this new file.
3171         * linux-nat-trad.h: New file.
3172         * linux-nat.c (linux_target_install_ops): Make extern.
3173         (linux_trad_target): Delete.
3174         * linux-nat.h (linux_trad_target): Delete declaration.
3175         (linux_target_install_ops): Declare.
3176         * mips-linux-nat.c: Include "linux-nat-trad.h" instead of
3177         "linux-nat.h".
3178
3179 2018-05-02  Pedro Alves  <palves@redhat.com>
3180
3181         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Don't call
3182         procfs_target/add_target here.
3183         * procfs.c (procfs_target): Make static.
3184         (_initialize_procfs): Call add_target here.
3185         * procfs.h (struct target_ops): Remove forward declaration.
3186         (procfs_target): Remove declaration.
3187         * sparc-sol2-nat.c (_initialize_sparc_sol2_nat): Delete.
3188
3189 2018-05-02  Pedro Alves  <palves@redhat.com>
3190
3191         * procfs.c (procfs_stopped_by_watchpoint)
3192         (procfs_insert_watchpoint, procfs_remove_watchpoint)
3193         (procfs_region_ok_for_hw_watchpoint, procfs_stopped_data_address):
3194         Forward declare.
3195         (procfs_use_watchpoints): Delete, move contents...
3196         (procfs_target): ... here.
3197         * procfs.h (procfs_use_watchpoints): Delete declaration.
3198         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Don't call
3199         procfs_use_watchpoints.
3200         * sparc-sol2-nat.c (_initialize_sparc_sol2_nat): Don't call
3201         procfs_use_watchpoints.
3202
3203 2018-05-02  Tom Tromey  <tom@tromey.com>
3204
3205         PR python/20084:
3206         * python/python.c (gdbpy_parameter_value): Handle var_zuinteger
3207         and var_zuinteger_unlimited.
3208         * python/py-param.c (struct parm_constant): Add PARAM_ZUINTEGER
3209         and PARAM_ZUINTEGER_UNLIMITED.
3210         (set_parameter_value): Handle var_zuinteger and
3211         var_zuinteger_unlimited.
3212         (add_setshow_generic): Likewise.
3213         (parmpy_init): Likewise.
3214
3215 2018-04-28  Dan Robertson  <danlrobertson89@gmail.com>
3216
3217         PR rust/23124
3218         * gdb/rust-exp.y (convert_params_to_types): Ensure that the params
3219         pointer is not null before dereferencing it.
3220
3221 2018-04-30  Tom Tromey  <tom@tromey.com>
3222
3223         * darwin-nat-info.c (darwin_debug_regions_recurse): Remove use of
3224         is_mi_like_p.
3225
3226 2018-04-30  Tom Tromey  <tom@tromey.com>
3227
3228         * breakpoint.c (mention): Remove use of is_mi_like_p.
3229         (print_mention_ranged_breakpoint): Likewise.
3230         * break-catch-throw.c (print_it_exception_catchpoint): Remove use
3231         of is_mi_like_p.
3232
3233 2018-04-30  Tom Tromey  <tom@tromey.com>
3234
3235         * tracepoint.c (tvariables_info_1): Remove use of is_mi_like_p.
3236
3237 2018-04-30  Tom Tromey  <tom@tromey.com>
3238
3239         * spu-tdep.c (info_spu_mailbox_list, info_spu_dma_cmdlist)
3240         (info_spu_event_command): Remove some uses of is_mi_like_p.
3241
3242 2018-04-30  Tom Tromey  <tom@tromey.com>
3243
3244         * python/py-framefilter.c (py_print_single_arg)
3245         (enumerate_locals, py_print_args, py_print_frame): Remove some
3246         uses of is_mi_like_p.
3247
3248 2018-04-30  Tom Tromey  <tom@tromey.com>
3249
3250         * ui-out.c: Update.
3251         * cli-out.h (cli_ui_out::do_is_mi_like_p): Update.
3252         * ui-out.h (ui_out::is_mi_like_p): Now const.
3253         (ui_out::do_is_mi_like_p): Now const.
3254         * mi/mi-out.h (mi_ui_out::do_is_mi_like_p): Update.
3255
3256 2018-04-30  Tom Tromey  <tom@tromey.com>
3257
3258         * varobj.c (varobj_set_visualizer): Use new_reference.
3259         * python/python.c (gdbpy_decode_line): Use new_reference.
3260         * python/py-cmd.c (cmdpy_function, cmdpy_completer_helper): Use
3261         new_reference.
3262
3263 2018-04-30  Tom Tromey  <tom@tromey.com>
3264
3265         * varobj.c (install_new_value): Use new_reference.
3266         * value.h (value_incref): Return void.  Swap intro comment with
3267         value_decref.
3268         * value.c (set_value_parent): Use new_reference.
3269         (value_incref): Return void.  Update intro comment.
3270         (release_value): Use new_reference.
3271         * dwarf2loc.c (dwarf2_evaluate_loc_desc_full): Use new_reference.
3272
3273 2018-04-30  Tom Tromey  <tom@tromey.com>
3274
3275         * symfile-mem.c (symbol_file_add_from_memory): Use new_reference.
3276         * gdb_bfd.h (new_bfd_ref): Remove.
3277         (gdb_bfd_open): Update comment.
3278         * gdb_bfd.c (gdb_bfd_open, gdb_bfd_fopen, gdb_bfd_openr)
3279         (gdb_bfd_openw, gdb_bfd_openr_iovec, gdb_bfd_record_inclusion)
3280         (gdb_bfd_fdopenr): Use new_reference.
3281         * exec.c (exec_file_attach): Use new_reference.
3282
3283 2018-04-30  Tom Tromey  <tom@tromey.com>
3284
3285         * common/gdb_ref_ptr.h (ref_ptr::new_reference): New static
3286         method.
3287
3288 2018-04-30  Tom Tromey  <tom@tromey.com>
3289
3290         * jit.c (jit_read_code_entry): Use type_align.
3291         * i386-tdep.c (i386_gdbarch_init): Don't call
3292         set_gdbarch_long_long_align_bit.
3293         * gdbarch.sh: Remove long_long_align_bit.
3294         * gdbarch.c, gdbarch.h: Rebuild.
3295         * arc-tdep.c (arc_type_align): New function.
3296         (arc_gdbarch_init): Use arc_type_align.  Don't call
3297         set_gdbarch_long_long_align_bit.
3298
3299 2018-04-30  Tom Tromey  <tom@tromey.com>
3300
3301         * rust-lang.c (rust_type_alignment): Remove.
3302         (rust_composite_type): Use type_align.
3303
3304 2018-04-30  Tom Tromey  <tom@tromey.com>
3305
3306         * NEWS: Mention Type.align.
3307         * python/py-type.c (typy_get_alignof): New function.
3308         (type_object_getset): Add "alignof".
3309
3310 2018-04-30  Tom Tromey  <tom@tromey.com>
3311
3312         PR exp/17095:
3313         * NEWS: Update.
3314         * std-operator.def (UNOP_ALIGNOF): New operator.
3315         * expprint.c (dump_subexp_body_standard) <case UNOP_ALIGNOF>:
3316         New.
3317         * eval.c (evaluate_subexp_standard) <case UNOP_ALIGNOF>: New.
3318         * c-lang.c (c_op_print_tab): Add alignof.
3319         * c-exp.y (ALIGNOF): New token.
3320         (exp): Add "ALIGNOF" production.
3321         (ident_tokens): Add _Alignof and alignof.
3322
3323 2018-04-30  Tom Tromey  <tom@tromey.com>
3324
3325         * i386-tdep.c (i386_type_align): New function.
3326         (i386_gdbarch_init): Update.
3327         * gdbarch.sh (type_align): New method.
3328         * gdbarch.c, gdbarch.h: Rebuild.
3329         * arch-utils.h (default_type_align): Declare.
3330         * arch-utils.c (default_type_align): New function.
3331         * gdbtypes.h (TYPE_ALIGN_BITS): New define.
3332         (struct type) <align_log2>: New field.
3333         <instance_flags>: Now a bitfield.
3334         (TYPE_RAW_ALIGN): New macro.
3335         (type_align, type_raw_align, set_type_align): Declare.
3336         * gdbtypes.c (type_align, type_raw_align, set_type_align): New
3337         functions.
3338         * dwarf2read.c (quirk_rust_enum): Set type alignment.
3339         (get_alignment, maybe_set_alignment): New functions.
3340         (read_structure_type, read_enumeration_type, read_array_type)
3341         (read_set_type, read_tag_pointer_type, read_tag_reference_type)
3342         (read_subrange_type, read_base_type): Set type alignment.
3343
3344 2018-04-30  Simon Marchi  <simon.marchi@ericsson.com>
3345
3346         * dwarf2read.c (read_index_from_section): Use bool.
3347
3348 2018-04-29  Fabian Groffen  <grobian@gentoo.org>
3349
3350         PR gdb/22950
3351         * proc-events.c (init_syscall_table): Guard usage os SYS_uuidsys
3352         with #ifdef.
3353
3354 2018-04-29  John Reiser  <jreiser@BitWagon.com>
3355
3356         PR build/22873
3357         * gdb/Makefile.in: (.c:.l, .c:.y): Write the target only in the
3358         last step, and do it atomically.
3359
3360 2018-04-27  Alexandre Oliva  <aoliva@redhat.com>
3361
3362         * compile/compile-c-types.c (convert_int, convert_float):
3363         Update for C FE v1.
3364
3365 2018-04-27  Tom Tromey  <tom@tromey.com>
3366
3367         PR rust/22545:
3368         * rust-lang.c (rust_inclusive_range_type_p): New function.
3369         (rust_range): Handle inclusive ranges.
3370         (rust_compute_range): Likewise.
3371         * rust-exp.y (struct rust_op) <inclusive>: New field.
3372         (DOTDOTEQ): New constant.
3373         (range_expr): Add "..=" productions.
3374         (operator_tokens): Add "..=" token.
3375         (ast_range): Add "inclusive" parameter.
3376         (convert_ast_to_expression) <case OP_RANGE>: Handle inclusive
3377         ranges.
3378         * parse.c (operator_length_standard) <case OP_RANGE>: Handle new
3379         bounds values.
3380         * expression.h (enum range_type) <NONE_BOUND_DEFAULT_EXCLUSIVE,
3381         LOW_BOUND_DEFAULT_EXCLUSIVE>: New constants.
3382         Update comments.
3383         * expprint.c (print_subexp_standard): Handle new bounds values.
3384         (dump_subexp_body_standard): Likewise.
3385
3386 2018-04-27  Tom Tromey  <tom@tromey.com>
3387
3388         * configure: Rebuild.
3389         * warning.m4 (AM_GDB_WARNINGS): Add -Wsuggest-override.
3390         * dwarf2loc.c (class dwarf_evaluate_loc_desc): Use "override", not
3391         "OVERRIDE".
3392         (class symbol_needs_eval_context): Likewise.
3393         * dwarf2read.c (mock_mapped_index::symbol_name_count)
3394         (mock_mapped_index::symbol_name_at): Use "override".  Remove
3395         "virtual".
3396         * dwarf2-frame.c (dwarf_expr_executor::get_addr_index): Use
3397         "override".
3398         (class dwarf_expr_executor): Use "override", not "OVERRIDE".
3399         * aarch64-tdep.c (instruction_reader::read): Use "override".
3400         (instruction_reader_test::read): Likewise.
3401         * arm-tdep.c (instruction_reader::read): Use "override".
3402         (instruction_reader_thumb::read): Likewise.
3403
3404 2018-04-26  Andrzej Kaczmarek  <andrzej.kaczmarek@codecoup.pl>
3405
3406         PR remote/9665
3407         * remote.c (send_g_packet): Use putpkt/getpkt/packet_check_result
3408         instead of remote_send.
3409         (remote_send): Remove.
3410
3411 2018-04-26  Pedro Alves  <palves@redhat.com>
3412
3413         * elfread.c (elf_gnu_ifunc_resolver_return_stop): Use
3414         find_function_start_sal instead of find_pc_line.
3415
3416 2018-04-26  Pedro Alves  <palves@redhat.com>
3417
3418         * breakpoint.c (set_breakpoint_location_function): Handle
3419         mst_data_gnu_ifunc.
3420         * c-exp.y (variable production): Handle mst_data_gnu_ifunc.
3421         * elfread.c (elf_symtab_read): Give data symbols with
3422         BSF_GNU_INDIRECT_FUNCTION set mst_data_gnu_ifunc type.
3423         (elf_rel_plt_read): Update comment.
3424         * linespec.c (convert_linespec_to_sals): Handle
3425         mst_data_gnu_ifunc.
3426         (minsym_found): Handle mst_data_gnu_ifunc.
3427         * minsyms.c (msymbol_is_function, minimal_symbol_reader::record)
3428         (find_solib_trampoline_target): Handle mst_data_gnu_ifunc.
3429         * parse.c (find_minsym_type_and_address): Handle
3430         mst_data_gnu_ifunc.
3431         * symmisc.c (dump_msymbols): Handle mst_data_gnu_ifunc.
3432         * symtab.c (find_gnu_ifunc): Handle mst_data_gnu_ifunc.
3433         * symtab.h (minimal_symbol_type) <mst_text_gnu_ifunc>: Update
3434         comment.
3435         <mst_data_gnu_ifunc>: New enumerator.
3436
3437 2018-04-26  Pedro Alves  <palves@redhat.com>
3438
3439         * minsyms.c (lookup_minimal_symbol_by_pc_section_1): Rename to ...
3440         (lookup_minimal_symbol_by_pc_section): ... this.  Replace
3441         'want_trampoline' parameter by a lookup_msym_prefer parameter.
3442         Handle it.
3443         (lookup_minimal_symbol_by_pc_section): Delete old implementation.
3444         (lookup_minimal_symbol_by_pc): Adjust.
3445         (in_gnu_ifunc_stub): Prefer GNU ifunc symbols.
3446         (lookup_solib_trampoline_symbol_by_pc): Adjust.
3447         * minsyms.h (lookup_msym_prefer): New enum.
3448         (lookup_minimal_symbol_by_pc_section): Replace 'want_trampoline'
3449         parameter by a lookup_msym_prefer parameter.
3450
3451 2018-04-26  Pedro Alves  <palves@redhat.com>
3452
3453         * elfread.c (elf_gnu_ifunc_record_cache): Check if the symbol name
3454         ends in "@plt" instead of looking at the symbol's section.
3455
3456 2018-04-26  Pedro Alves  <palves@redhat.com>
3457
3458         * blockframe.c (cache_pc_function_is_gnu_ifunc): Delete.  Remove
3459         all references.
3460         (find_pc_partial_function_gnu_ifunc): Rename to ...
3461         (find_pc_partial_function): ... this, and remove references to
3462         'is_gnu_ifunc_p'.
3463         (find_pc_partial_function): Delete old implementation.
3464         * symtab.h (find_pc_partial_function_gnu_ifunc): Delete.
3465
3466 2018-04-26  Pedro Alves  <palves@redhat.com>
3467
3468         * linespec.c (struct bound_minimal_symbol_search_key): New.
3469         (convert_linespec_to_sals): Sort minimal symbols earlier.  Don't
3470         skip first line if we found a GNU ifunc minimal symbol by name.
3471         (compare_msymbols): Change parameters to work with a destructured
3472         lhs minsym.
3473         (compare_msymbols_for_qsort, compare_msymbols_for_bsearch): New
3474         functions.
3475
3476 2018-04-26  Pedro Alves  <palves@redhat.com>
3477
3478         * breakpoint.c (set_breakpoint_location_function): Don't resolve
3479         ifunc targets here.  Instead, if we have an ifunc minsym, use its
3480         address/name.
3481         (add_location_to_breakpoint): Store the minsym and the objfile in
3482         the breakpoint location.
3483         * breakpoint.h (bp_location) <msymbol, objfile>: New fields.
3484         * linespec.c (minsym_found): Resolve GNU ifunc targets here.
3485         Record the minsym in the sal.
3486         * symtab.h (symtab_and_line) <msymbol>: New field.
3487
3488 2018-04-26  Pedro Alves  <palves@redhat.com>
3489
3490         * elfread.c (elf_gnu_ifunc_resolve_by_got): Don't write to *ADDR_P
3491         unless we actually resolved the ifunc.
3492
3493 2018-04-26  Pedro Alves  <palves@redhat.com>
3494
3495         * c-exp.y (variable production): Prefer ifunc minsyms over
3496         regular function symbols.
3497         * symtab.c (find_gnu_ifunc): New function.
3498         * minsyms.h (lookup_msym_prefer): New enum.
3499         (lookup_minimal_symbol_by_pc_section): Replace 'want_trampoline'
3500         parameter by a lookup_msym_prefer parameter.
3501         * symtab.h (find_gnu_ifunc): New declaration.
3502
3503 2018-04-26  Pedro Alves  <palves@redhat.com>
3504
3505         * blockframe.c (find_gnu_ifunc_target_type): New function.
3506         (find_function_type): New.
3507         * eval.c (evaluate_var_msym_value): For GNU ifunc types, always
3508         return a value with a memory address.
3509         (eval_call): For calls to GNU ifunc functions, try to find the
3510         type of the target function from the type that the resolver
3511         returns.
3512         * gdbtypes.c (objfile_type): Don't install a return type for ifunc
3513         symbols.
3514         * infcall.c (find_function_return_type): Delete.
3515         (find_function_addr): Add 'function_type' parameter.  For calls to
3516         GNU ifunc functions, try to find the type of the target function
3517         from the type that the resolver returns, and return it via
3518         FUNCTION_TYPE.
3519         (call_function_by_hand_dummy): Adjust to use the function type
3520         returned by find_function_addr.
3521         (find_function_addr): Add 'function_type' parameter and move
3522         description here.
3523         * symtab.h (find_function_type, find_gnu_ifunc_target_type): New
3524         declarations.
3525
3526 2018-04-26  Pedro Alves  <palves@redhat.com>
3527
3528         * c-exp.y (variable production): Skip finding an alias for ifunc
3529         symbols.
3530
3531 2018-04-26  Pedro Alves  <palves@redhat.com>
3532
3533         * elfread.c (elf_rel_plt_read): Look for relocations for .got.plt too.
3534
3535 2018-04-25  Pedro Alves  <palves@redhat.com>
3536
3537         * infcmd.c (kill_command): Print the pid as string, not the whole
3538         thread's ptid.  Add comment.  s/has been killed/killed/ in output
3539         message.
3540         * remote.c (remote_detach_1): Print the pid as string, not the
3541         whole thread's ptid.
3542
3543 2018-04-24  Jan Kratochvil  <jan.kratochvil@redhat.com>
3544             Sergio Durigan Junior  <sergiodj@redhat.com>
3545             Pedro Alves  <palves@redhat.com>
3546
3547         * infcmd.c (kill_command): Print message when inferior has
3548         been killed.
3549         * inferior.c (print_inferior_events): Remove 'static'.  Set as
3550         '1'.
3551         (add_inferior): Improve message printed when
3552         'print_inferior_events' is on.
3553         (exit_inferior): Remove message printed when
3554         'print_inferior_events' is on.
3555         (detach_inferior): Improve message printed when
3556         'print_inferior_events' is on.
3557         (initialize_inferiors): Use 'add_inferior_silent' to set
3558         'current_inferior_'.
3559         * inferior.h (print_inferior_events): Declare here as
3560         'extern'.
3561         * infrun.c (follow_fork_inferior): Print '[Attaching...]' or
3562         '[Detaching...]' messages when 'print_inferior_events' is on.
3563         Use 'add_thread_silent' instead of 'add_thread'.  Add '[' and ']'
3564         as prefix/suffix for messages.  Remove periods.  Fix erroneous
3565         'Detaching after fork from child...', replace it by '... from
3566         parent...'.
3567         (handle_vfork_child_exec_or_exit): Add '[' and ']' as
3568         prefix/suffix when printing 'Detaching...' messages.  Print
3569         them when 'print_inferior_events' is on.
3570         * remote.c (remote_detach_1): Print message when detaching
3571         from inferior and '!is_fork_parent'.
3572
3573 2018-04-24  Tom Tromey  <tom@tromey.com>
3574
3575         * cli-out.h: Reindent.
3576
3577 2018-04-24  Tom Tromey  <tom@tromey.com>
3578
3579         * cli-out.c (cli_ui_out::out_field_fmt): Remove.
3580         (cli_ui_out::do_field_string): Use fputs_filtered.
3581         * cli-out.h (class cli_ui_out) <out_field_fmt>: Remove.
3582
3583 2018-04-23  Tom Tromey  <tom@tromey.com>
3584
3585         * guile/scm-frame.c (gdbscm_frame_read_var): Use
3586         gdb::unique_xmalloc_ptr.
3587
3588 2018-04-23  Tom Tromey  <tom@tromey.com>
3589
3590         * configure: Rebuild.
3591
3592 2018-04-22  Rajendra SY  <rajendra.sy@gmail.com>
3593
3594         PR gdb/23095
3595         * gdb/testsuite/gdb.base/break-probes.exp: Pass shlib_load to
3596         prepare_for_testing.  Set normal_bp to r_debug_state if target
3597         is bsd.
3598
3599 2018-04-21  Pedro Alves  <palves@redhat.com>
3600             Rajendra SY  <rajendra.sy@gmail.com>
3601
3602         * inf-ptrace.c (inf_ptrace_attach): Mark the thread as executing.
3603         * remote.c (extended_remote_attach): In all-stop mode, mark the
3604         thread as executing.
3605
3606 2018-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3607
3608         * thread.c (thread_apply_all_command): Fix comment.
3609         (thread_command): Fix comment.
3610
3611 2018-04-10  Alan Hayward  <alan.hayward@arm.com>
3612
3613         * common/tdesc.h (tdesc_create_feature): Remove xml filename
3614         parameter.
3615         * features/aarch64-core.c (create_feature_aarch64_core):
3616         Regenerate.
3617         * features/aarch64-fpu.c (create_feature_aarch64_fpu):
3618         Likewise.
3619         * features/i386/32bit-avx.c (create_feature_i386_32bit_avx):
3620         Likewise.
3621         * features/i386/32bit-avx512.c
3622         (create_feature_i386_32bit_avx512): Likewise.
3623         * features/i386/32bit-core.c (create_feature_i386_32bit_core):
3624         Likewise.
3625         * features/i386/32bit-linux.c (create_feature_i386_32bit_linux):
3626         Likewise.
3627         * features/i386/32bit-mpx.c (create_feature_i386_32bit_mpx):
3628         Likewise.
3629         * features/i386/32bit-pkeys.c (create_feature_i386_32bit_pkeys):
3630         Likewise.
3631         * features/i386/32bit-sse.c (create_feature_i386_32bit_sse):
3632         Likewise.
3633         * features/i386/64bit-avx.c (create_feature_i386_64bit_avx):
3634         Likewise.
3635         * features/i386/64bit-avx512.c
3636         (create_feature_i386_64bit_avx512): Likewise.
3637         * features/i386/64bit-core.c (create_feature_i386_64bit_core):
3638         Likewise.
3639         * features/i386/64bit-linux.c (create_feature_i386_64bit_linux):
3640         Likewise.
3641         * features/i386/64bit-mpx.c (create_feature_i386_64bit_mpx):
3642         Likewise.
3643         * features/i386/64bit-pkeys.c (create_feature_i386_64bit_pkeys):
3644         Likewise.
3645         * features/i386/64bit-segments.c
3646         (create_feature_i386_64bit_segments): Likewise.
3647         * features/i386/64bit-sse.c (create_feature_i386_64bit_sse):
3648         Likewise.
3649         * features/i386/x32-core.c
3650         (create_feature_i386_x32_core): Likewise.
3651         * features/tic6x-c6xp.c (create_feature_tic6x_c6xp): Likewise.
3652         * features/tic6x-core.c (create_feature_tic6x_core): Likewise.
3653         * features/tic6x-gp.c (create_feature_tic6x_gp): Likewise.
3654         * target-descriptions.c: In generated code, don't pass xml
3655         filename.
3656
3657 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3658
3659         * common/tdesc.c (print_xml_feature::visit_pre): Add xml parsing.
3660         (print_xml_feature::visit_post): Likewise.
3661         (print_xml_feature::visit): Likewise.
3662         * common/tdesc.h (tdesc_get_features_xml): Use const tdesc.
3663         (print_xml_feature): Add new class.
3664         * regformats/regdat.sh: Null xmltarget on feature targets.
3665         * target-descriptions.c (struct target_desc): Add xmltarget.
3666         (maintenance_check_tdesc_xml_convert): Add unittest function.
3667         (tdesc_get_features_xml): Add function to get xml.
3668         (maintenance_check_xml_descriptions): Test xml generation.
3669         * xml-tdesc.c (string_read_description_xml): Add function.
3670         * xml-tdesc.h (string_read_description_xml): Add declaration.
3671
3672 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3673
3674         * features/Makefile: Add feature marker to targets with new style
3675         target descriptions.
3676         * regformats/aarch64.dat: Regenerate.
3677         * regformats/i386/amd64-avx-avx512-linux.dat: Likewise.
3678         * regformats/i386/amd64-avx-linux.dat: Likewise.
3679         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Likewise.
3680         * regformats/i386/amd64-avx-mpx-linux.dat: Likewise.
3681         * regformats/i386/amd64-linux.dat: Likewise.
3682         * regformats/i386/amd64-mpx-linux.dat: Likewise.
3683         * regformats/i386/amd64.dat: Likewise.
3684         * regformats/i386/i386-avx-avx512-linux.dat: Likewise.
3685         * regformats/i386/i386-avx-linux.dat: Likewise.
3686         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Likewise.
3687         * regformats/i386/i386-avx-mpx-linux.dat: Likewise.
3688         * regformats/i386/i386-linux.dat: Likewise.
3689         * regformats/i386/i386-mmx-linux.dat: Likewise.
3690         * regformats/i386/i386-mpx-linux.dat: Likewise.
3691         * regformats/i386/i386.dat: Likewise.
3692         * regformats/i386/x32-avx-avx512-linux.dat: Likewise.
3693         * regformats/i386/x32-avx-linux.dat: Likewise.
3694         * regformats/i386/x32-linux.dat: Likewise.
3695         * regformats/tic6x-c62x-linux.dat: Likewise.
3696         * regformats/tic6x-c64x-linux.dat: Likewise.
3697         * regformats/tic6x-c64xp-linux.dat: Likewise.
3698         * regformats/regdat.sh: Parse feature marker.
3699
3700 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3701
3702         * common/tdesc.h (tdesc_architecture_name): Add new declaration.
3703         (tdesc_osabi_name): Likewise.
3704         * target-descriptions.c (tdesc_architecture_name): Add new
3705         function.
3706         (tdesc_osabi_name): Likewise.
3707
3708 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3709
3710         * common/tdesc.c (tdesc_predefined_type): Move to here.
3711         (tdesc_named_type): Likewise.
3712         (tdesc_create_vector): Likewise.
3713         (tdesc_create_struct): Likewise.
3714         (tdesc_set_struct_size): Likewise.
3715         (tdesc_create_union): Likewise.
3716         (tdesc_create_flags): Likewise.
3717         (tdesc_create_enum): Likewise.
3718         (tdesc_add_field): Likewise.
3719         (tdesc_add_typed_bitfield): Likewise.
3720         (tdesc_add_bitfield): Likewise.
3721         (tdesc_add_flag): Likewise.
3722         (tdesc_add_enum_value): Likewise.
3723         * common/tdesc.h (struct tdesc_type_builtin): Likewise.
3724         (struct tdesc_type_vector): Likewise.
3725         (struct tdesc_type_field): Likewise.
3726         (struct tdesc_type_with_fields): Likewise.
3727         (tdesc_create_enum): Add declaration.
3728         (tdesc_add_typed_bitfield): Likewise.
3729         (tdesc_add_enum_value): Likewise.
3730         * target-descriptions.c (tdesc_type_field): Move from here.
3731         (tdesc_type_builtin): Likewise.
3732         (tdesc_type_vector): Likewise.
3733         (tdesc_type_with_fields): Likewise.
3734         (tdesc_predefined_types): Likewise.
3735         (tdesc_named_type): Likewise.
3736         (tdesc_create_vector): Likewise.
3737         (tdesc_create_struct): Likewise.
3738         (tdesc_set_struct_size): Likewise.
3739         (tdesc_create_union): Likewise.
3740         (tdesc_create_flags): Likewise.
3741         (tdesc_create_enum): Likewise.
3742         (tdesc_add_field): Likewise.
3743         (tdesc_add_typed_bitfield): Likewise.
3744         (tdesc_add_bitfield): Likewise.
3745         (tdesc_add_flag): Likewise.
3746         (tdesc_add_enum_value): Likewise.
3747         * gdb/target-descriptions.h (tdesc_create_enum): Likewise.
3748         (tdesc_add_typed_bitfield): Likewise.
3749         (tdesc_add_enum_value): Likewise.
3750
3751 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3752
3753         * common/tdesc.c (tdesc_feature::accept): Move to here.
3754         (tdesc_feature::operator==): Likewise.
3755         (tdesc_create_reg): Likewise.
3756         * common/tdesc.h (tdesc_type_kind): Likewise.
3757         (struct tdesc_type): Likewise.
3758         (struct tdesc_feature): Likewise.
3759         * regformats/regdat.sh: Create a feature.
3760         * target-descriptions.c (tdesc_type_kind): Move from here.
3761         (tdesc_type): Likewise.
3762         (tdesc_type_up): Likewise.
3763         (tdesc_feature): Likewise.
3764         (tdesc_create_reg): Likewise.
3765
3766 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3767
3768         * Makefile.in: Add arch/tdesc.c
3769         * common/tdesc.c: New file.
3770         * common/tdesc.h (tdesc_element_visitor): Move to here.
3771         (tdesc_element): Likewise.
3772         (tdesc_reg): Likewise.
3773         (tdesc_reg_up): Likewise.
3774         * regformats/regdef.h (reg): Add offset to constructors.
3775         * target-descriptions.c (tdesc_element_visitor): Move from here.
3776         (tdesc_element): Likewise.
3777         (tdesc_reg): Likewise.
3778         (tdesc_reg_up): Likewise.
3779
3780 2018-04-17  Tom Tromey  <tom@tromey.com>
3781
3782         * dwarf2read.c (quirk_rust_enum): Conditionally drop the
3783         discriminant field.
3784
3785 2018-04-17  Tom Tromey  <tom@tromey.com>
3786
3787         * dwarf2read.c (quirk_rust_enum): Handle unions correctly.
3788
3789 2018-04-17  Andreas Arnez  <arnez@linux.vnet.ibm.com>
3790
3791         * symtab.c (print_symbol_info): Skip printing filename and line
3792         number when `last' is NULL.
3793         (symtab_symbol_info): Use empty string instead of NULL for first
3794         invocation of print_symbol_info.
3795         (rbreak_command): Pass NULL to `last' parameter of
3796         print_symbol_info.
3797
3798 2018-04-16  Simon Marchi  <simon.marchi@ericsson.com>
3799
3800         * linux-tdep.c (linux_spu_make_corefile_notes): Return note_data
3801         instead of nullptr.
3802
3803 2018-04-16  Pedro Alves  <palves@redhat.com>
3804
3805         * MAINTAINERS (sh): Remove.
3806         * Makefile.in (ALL_TARGET_OBS): Remove sh64-tdep.o.
3807         (HFILES_NO_SRCDIR): Remove sh64-tdep.h.
3808         (ALLDEPFILES): Remove sh64-tdep.c.
3809         * NEWS: Mentions that support for SH-5/SH64 is removed.
3810         * configure.tgt (sh*-*-linux*): Remove reference to sh64-tdep.o.
3811         (sh*-*-openbsd*): Ditto.
3812         (sh64-*-elf*): Remove.
3813         (sh*): Remove.
3814         * regcache.c (cooked_write_test): Remove bfd_mach_sh5 case.
3815         * sh-linux-tdep.c: Remove reference to bfd_mach_sh5.
3816         * sh-tdep.c: No longer include "sh64-tdep.h".
3817         (sh_gdbarch_init): Remove reference to bfd_mach_sh5.
3818         * sh64-tdep.c, sh64-tdep.h: Remove files.
3819
3820 2018-04-16  Pedro Alves  <palves@redhat.com>
3821
3822         * MAINTAINERS: Remove m88k.
3823         * Makefile.in (ALL_TARGET_OBS): Remove m88k-tdep.o.
3824         (HFILES_NO_SRCDIR): Remove m88k-tdep.h.
3825         (ALLDEPFILES): Remove m88k-bsd-nat.c and m88k-tdep.c.
3826         * NEWS: Mention that support for m88k was removed.
3827         * configure.host (m88*-*-*): Remove support.
3828         * configure.nat (m88k-*-*): Remove support.
3829         * configure.tgt (m88*-*-openbsd*): Remove.
3830         * m88k-bsd-nat.c, m88k-tdep.c, m88k-tdep.h: Delete.
3831
3832 2018-04-15  Simon Marchi  <simon.marchi@polymtl.ca>
3833
3834         * configure.tgt (x86_tobjs): New variable.
3835         (amd64_tobjs, i386_tobjs): Use it.
3836
3837 2018-04-13  Andreas Arnez  <arnez@linux.vnet.ibm.com>
3838
3839         * symtab.c (print_symbol_info): Precede the symbol definition by
3840         the line number when available.
3841         * NEWS: Advertise this enhancement.
3842
3843 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
3844
3845         * NEWS (New options): announce set/show record btrace cpu.
3846         * btrace.c: Include record-btrace.h.
3847         (btrace_compute_ftrace_pt): Skip enabling errata workarounds if
3848         the vendor is unknown.
3849         (btrace_compute_ftrace_1): Add cpu parameter.  Update callers.
3850         Maybe overwrite the btrace configuration's cpu.
3851         (btrace_compute_ftrace): Add cpu parameter.  Update callers.
3852         (btrace_fetch): Add cpu parameter.  Update callers.
3853         (btrace_maint_update_pt_packets): Call record_btrace_get_cpu.
3854         Maybe overwrite the btrace configuration's cpu.  Skip enabling
3855         errata workarounds if the vendor is unknown.
3856         * python/py-record-btrace.c: Include record-btrace.h.
3857         (recpy_bt_begin, recpy_bt_end, recpy_bt_instruction_history)
3858         (recpy_bt_function_call_history): Call record_btrace_get_cpu.
3859         * record-btrace.c (record_btrace_cpu_state_kind): New.
3860         (record_btrace_cpu): New.
3861         (set_record_btrace_cpu_cmdlist): New.
3862         (record_btrace_get_cpu): New.
3863         (require_btrace_thread, record_btrace_info)
3864         (record_btrace_resume_thread): Call record_btrace_get_cpu.
3865         (cmd_set_record_btrace_cpu_none): New.
3866         (cmd_set_record_btrace_cpu_auto): New.
3867         (cmd_set_record_btrace_cpu): New.
3868         (cmd_show_record_btrace_cpu): New.
3869         (_initialize_record_btrace): Initialize set/show record btrace cpu
3870         commands.
3871         * record-btrace.h (record_btrace_get_cpu): New.
3872
3873 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
3874
3875         * record.c (set_record_command): Fix typo in message.
3876
3877 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
3878
3879         * record-btrace.c (cmd_set_record_btrace): Print sub-commands.
3880
3881 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
3882
3883         * infrun.c (process_event_stop_test): Call
3884         gdbarch_in_indirect_branch_thunk.
3885         * gdbarch.sh (in_indirect_branch_thunk): New.
3886         * gdbarch.c: Regenerated.
3887         * gdbarch.h: Regenerated.
3888         * x86-tdep.h: New.
3889         * x86-tdep.c: New.
3890         * Makefile.in (ALL_TARGET_OBS): Add x86-tdep.o.
3891         (HFILES_NO_SRCDIR): Add x86-tdep.h.
3892         (ALLDEPFILES): Add x86-tdep.c.
3893         * arch-utils.h (default_in_indirect_branch_thunk): New.
3894         * arch-utils.c (default_in_indirect_branch_thunk): New.
3895         * i386-tdep: Include x86-tdep.h.
3896         (i386_in_indirect_branch_thunk): New.
3897         (i386_elf_init_abi): Set in_indirect_branch_thunk gdbarch
3898         function.
3899         * amd64-tdep: Include x86-tdep.h.
3900         (amd64_in_indirect_branch_thunk): New.
3901         (amd64_init_abi): Set in_indirect_branch_thunk gdbarch function.
3902
3903 2018-04-12  Jan Kratochvil  <jan.kratochvil@redhat.com>
3904
3905         PR gdb/23053
3906         * dwarf-index-write.c (data_buf::grow) (write_one_signatured_type)
3907         (recursively_write_psymbols) (debug_names::recursively_write_psymbols)
3908         (debug_names::write_one_signatured_type): Fix -D_GLIBCXX_DEBUG
3909         regression.
3910
3911 2018-04-12  Tom Tromey  <tom@tromey.com>
3912
3913         * rust-lang.c (rust_print_struct_def): Remove univariant code.
3914         (rust_evaluate_subexp): Likewise.
3915
3916 2018-04-12  Pedro Alves  <palves@redhat.com>
3917
3918         * procfs.c (procfs_detach): Make forward declaration's prototype
3919         match definition's protototype.
3920         (proc_get_LDT_entry): Remove stale do_cleanups call.
3921
3922 2018-04-12  Pedro Alves  <palves@redhat.com>
3923
3924         * target.h (target_ops::to_has_exited): Delete.
3925         (target_has_exited): Delete.
3926         * target-delegates.c: Regenerate.
3927
3928 2018-04-11  Pedro Alves  <palves@redhat.com>
3929
3930         * target.c (fileio_fh_t::t): Add comment.
3931         (target_fileio_pwrite, target_fileio_pread, target_fileio_fstat)
3932         (target_fileio_close): Handle a NULL target.
3933         (invalidate_fileio_fh): New.
3934         (target_close): Call it.
3935         * remote.c (remote_hostio_send_command): No longer check whether
3936         remote_desc is open.
3937
3938 2018-04-11  Pedro Alves  <palves@redhat.com>
3939
3940         * target.c (fileio_fh_t): Make it a named struct instead of a
3941         typedef.
3942         (fileio_fh_t::is_closed): New method.
3943         (DEF_VEC_O (fileio_fh_t)): Remove.
3944         (fileio_fhandles): Now a std::vector.
3945         (is_closed_fileio_fh): Delete.
3946         (acquire_fileio_fd): Adjust.  Rename parameters.
3947         (release_fileio_fd): Adjust.
3948         (fileio_fd_to_fh): Reimplement as a function instead of a macro.
3949         (target_fileio_pwrite, target_fileio_pread, target_fileio_fstat)
3950         (target_fileio_close): Adjust.
3951
3952 2018-04-10  Simon Marchi  <simon.marchi@ericsson.com>
3953
3954         * auto-load.c (auto_load_safe_path_vec_update): Iterate by
3955         index.
3956
3957 2018-04-10  Pedro Alves  <palves@redhat.com>
3958
3959         * gdbthread.h (finish_thread_state_cleanup): Delete declaration.
3960         (scoped_finish_thread_state): New class.
3961         * infcmd.c (run_command_1): Use it instead of finish_thread_state
3962         cleanup.
3963         * infrun.c (proceed, prepare_for_detach, wait_for_inferior)
3964         (fetch_inferior_event, normal_stop): Likewise.
3965         * thread.c (finish_thread_state_cleanup): Delete.
3966
3967 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3968             Pedro Alves  <palves@redhat.com>
3969
3970         * value.c: Include "selftest.h" and "common/array-view.h".
3971         (struct range) <operator ==>: New.
3972         (test_ranges_contain): New.
3973         (check_ranges_vector): New.
3974         (test_insert_into_bit_range_vector): New.
3975         (_initialize_values): Register selftests.
3976         * common/array-view.h (operator==, operator!=): New.
3977
3978 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3979
3980         * common/gdb_vecs.h (unordered_remove): Add overload that takes
3981         an iterator.
3982         * inline-frame.c: Include <algorithm>.
3983         (struct inline_state): Add constructor.
3984         (inline_state_s): Remove.
3985         (DEF_VEC_O(inline_state_s)): Remove.
3986         (inline_states): Change type to std::vector.
3987         (find_inline_frame_state): Adjust to std::vector.
3988         (allocate_inline_frame_state): Remove.
3989         (clear_inline_frame_state): Adjust to std::vector.
3990         (skip_inline_frames): Adjust to std::vector.
3991
3992 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3993
3994         * tracepoint.h (struct trace_state_variable): Add constructor.
3995         <name>: Change type to std::string.
3996         * tracepoint.c (tsv_s): Remove.
3997         (DEF_VEC_O(tsv_s)): Remove.
3998         (tvariables): Change to std::vector.
3999         (create_trace_state_variable): Adjust to std::vector.
4000         (find_trace_state_variable): Likewise.
4001         (find_trace_state_variable_by_number): Likewise.
4002         (delete_trace_state_variable): Likewise.
4003         (trace_variable_command): Adjust to std::string.
4004         (delete_trace_variable_command): Likewise.
4005         (tvariables_info_1): Adjust to std::vector.
4006         (save_trace_state_variables): Likewise.
4007         (start_tracing): Likewise.
4008         (merge_uploaded_trace_state_variables): Adjust to std::vector
4009         and std::string.
4010         * target.h (struct target_ops)
4011         <to_download_trace_state_variable>: Pass reference to
4012         trace_state_variable.
4013         * target-debug.h (target_debug_print_const_trace_state_variable_r): New.
4014         * target-delegates.c: Re-generate.
4015         * mi/mi-interp.c (mi_tsv_created): Adjust to std::string.
4016         (mi_tsv_deleted): Likewise.
4017         * mi/mi-main.c (mi_cmd_trace_frame_collected): Likewise.
4018         * remote.c (remote_download_trace_state_variable): Change
4019         pointer to reference and adjust.
4020         * make-target-delegates (parse_argtypes): Handle references.
4021         (write_function_header): Likewise.
4022         (munge_type): Likewise.
4023
4024 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
4025
4026         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4027         string_view-selftests.c.
4028         * unittests/basic_string_view/capacity/1.cc: Adapt to GDB
4029         testsuite.
4030         * unittests/basic_string_view/cons/char/1.cc: Likewise.
4031         * unittests/basic_string_view/cons/char/2.cc: Likewise.
4032         * unittests/basic_string_view/cons/char/3.cc: Likewise.
4033         * unittests/basic_string_view/element_access/char/1.cc:
4034         Likewise.
4035         * unittests/basic_string_view/element_access/char/empty.cc:
4036         Likewise.
4037         * unittests/basic_string_view/element_access/char/front_back.cc:
4038         Likewise.
4039         * unittests/basic_string_view/inserters/char/2.cc: Likewise.
4040         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc:
4041         Likewise.
4042         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc:
4043         Likewise.
4044         * unittests/basic_string_view/modifiers/swap/char/1.cc:
4045         Likewise.
4046         * unittests/basic_string_view/operations/compare/char/1.cc:
4047         Likewise.
4048         * unittests/basic_string_view/operations/compare/char/13650.cc:
4049         Likewise.
4050         * unittests/basic_string_view/operations/copy/char/1.cc:
4051         Likewise.
4052         * unittests/basic_string_view/operations/data/char/1.cc:
4053         Likewise.
4054         * unittests/basic_string_view/operations/find/char/1.cc:
4055         Likewise.
4056         * unittests/basic_string_view/operations/find/char/2.cc:
4057         Likewise.
4058         * unittests/basic_string_view/operations/find/char/3.cc:
4059         Likewise.
4060         * unittests/basic_string_view/operations/find/char/4.cc:
4061         Likewise.
4062         * unittests/basic_string_view/operations/rfind/char/1.cc:
4063         Likewise.
4064         * unittests/basic_string_view/operations/rfind/char/2.cc:
4065         Likewise.
4066         * unittests/basic_string_view/operations/rfind/char/3.cc:
4067         Likewise.
4068         * unittests/basic_string_view/operations/substr/char/1.cc:
4069         Likewise.
4070         * unittests/basic_string_view/operators/char/2.cc: Likewise.
4071         * unittests/string_view-selftests.c: New file.
4072
4073 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
4074
4075         * unittests/basic_string_view/capacity/1.cc: New file.
4076         * unittests/basic_string_view/capacity/empty_neg.cc: New file.
4077         * unittests/basic_string_view/cons/char/1.cc: New file.
4078         * unittests/basic_string_view/cons/char/2.cc: New file.
4079         * unittests/basic_string_view/cons/char/3.cc: New file.
4080         * unittests/basic_string_view/cons/wchar_t/1.cc: New file.
4081         * unittests/basic_string_view/cons/wchar_t/2.cc: New file.
4082         * unittests/basic_string_view/cons/wchar_t/3.cc: New file.
4083         * unittests/basic_string_view/element_access/char/1.cc: New file.
4084         * unittests/basic_string_view/element_access/char/2.cc: New file.
4085         * unittests/basic_string_view/element_access/char/empty.cc: New file.
4086         * unittests/basic_string_view/element_access/char/front_back.cc: New file.
4087         * unittests/basic_string_view/element_access/wchar_t/1.cc: New file.
4088         * unittests/basic_string_view/element_access/wchar_t/2.cc: New file.
4089         * unittests/basic_string_view/element_access/wchar_t/empty.cc: New file.
4090         * unittests/basic_string_view/element_access/wchar_t/front_back.cc: New file.
4091         * unittests/basic_string_view/include.cc: New file.
4092         * unittests/basic_string_view/inserters/char/1.cc: New file.
4093         * unittests/basic_string_view/inserters/char/2.cc: New file.
4094         * unittests/basic_string_view/inserters/char/3.cc: New file.
4095         * unittests/basic_string_view/inserters/pod/10081-out.cc: New file.
4096         * unittests/basic_string_view/inserters/wchar_t/1.cc: New file.
4097         * unittests/basic_string_view/inserters/wchar_t/2.cc: New file.
4098         * unittests/basic_string_view/inserters/wchar_t/3.cc: New file.
4099         * unittests/basic_string_view/literals/types.cc: New file.
4100         * unittests/basic_string_view/literals/values.cc: New file.
4101         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc: New file.
4102         * unittests/basic_string_view/modifiers/remove_prefix/wchar_t/1.cc: New file.
4103         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc: New file.
4104         * unittests/basic_string_view/modifiers/remove_suffix/wchar_t/1.cc: New file.
4105         * unittests/basic_string_view/modifiers/swap/char/1.cc: New file.
4106         * unittests/basic_string_view/modifiers/swap/wchar_t/1.cc: New file.
4107         * unittests/basic_string_view/operations/compare/char/1.cc: New file.
4108         * unittests/basic_string_view/operations/compare/char/13650.cc: New file.
4109         * unittests/basic_string_view/operations/compare/char/2.cc: New file.
4110         * unittests/basic_string_view/operations/compare/char/70483.cc: New file.
4111         * unittests/basic_string_view/operations/compare/wchar_t/1.cc: New file.
4112         * unittests/basic_string_view/operations/compare/wchar_t/13650.cc: New file.
4113         * unittests/basic_string_view/operations/compare/wchar_t/2.cc: New file.
4114         * unittests/basic_string_view/operations/copy/char/1.cc: New file.
4115         * unittests/basic_string_view/operations/copy/wchar_t/1.cc: New file.
4116         * unittests/basic_string_view/operations/data/char/1.cc: New file.
4117         * unittests/basic_string_view/operations/data/wchar_t/1.cc: New file.
4118         * unittests/basic_string_view/operations/find/char/1.cc: New file.
4119         * unittests/basic_string_view/operations/find/char/2.cc: New file.
4120         * unittests/basic_string_view/operations/find/char/3.cc: New file.
4121         * unittests/basic_string_view/operations/find/char/4.cc: New file.
4122         * unittests/basic_string_view/operations/find/wchar_t/1.cc: New file.
4123         * unittests/basic_string_view/operations/find/wchar_t/2.cc: New file.
4124         * unittests/basic_string_view/operations/find/wchar_t/3.cc: New file.
4125         * unittests/basic_string_view/operations/find/wchar_t/4.cc: New file.
4126         * unittests/basic_string_view/operations/rfind/char/1.cc: New file.
4127         * unittests/basic_string_view/operations/rfind/char/2.cc: New file.
4128         * unittests/basic_string_view/operations/rfind/char/3.cc: New file.
4129         * unittests/basic_string_view/operations/rfind/wchar_t/1.cc: New file.
4130         * unittests/basic_string_view/operations/rfind/wchar_t/2.cc: New file.
4131         * unittests/basic_string_view/operations/rfind/wchar_t/3.cc: New file.
4132         * unittests/basic_string_view/operations/string_conversion/1.cc: New file.
4133         * unittests/basic_string_view/operations/substr/char/1.cc: New file.
4134         * unittests/basic_string_view/operations/substr/wchar_t/1.cc: New file.
4135         * unittests/basic_string_view/operators/char/2.cc: New file.
4136         * unittests/basic_string_view/operators/wchar_t/2.cc: New file.
4137         * unittests/basic_string_view/range_access/char/1.cc: New file.
4138         * unittests/basic_string_view/range_access/wchar_t/1.cc: New file.
4139         * unittests/basic_string_view/requirements/explicit_instantiation/1.cc: New file.
4140         * unittests/basic_string_view/requirements/explicit_instantiation/char/1.cc: New file.
4141         * unittests/basic_string_view/requirements/explicit_instantiation/char16_t/1.cc: New file.
4142         * unittests/basic_string_view/requirements/explicit_instantiation/char32_t/1.cc: New file.
4143         * unittests/basic_string_view/requirements/explicit_instantiation/wchar_t/1.cc: New file.
4144         * unittests/basic_string_view/requirements/typedefs.cc: New file.
4145         * unittests/basic_string_view/typedefs.cc: New file.
4146         * unittests/basic_string_view/types/1.cc: New file.
4147
4148 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
4149
4150         * common/gdb_string_view.h: Remove libstdc++ implementation
4151         details, adjust to gdb reality.
4152         * common/gdb_string_view.tcc: Likewise.
4153         * cli/cli-script.c (struct string_view): Remove.
4154         (user_args) <m_args>: Change element type to gdb::string_view.
4155         (user_args::insert_args): Adjust.
4156
4157 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
4158
4159         * common/gdb_string_view.h: New file.
4160         * common/gdb_string_view.tcc: New file.
4161
4162 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
4163
4164         * ax_cxx_compile_stdcxx.m4: Sync with upstream.
4165         * configure: Re-generate.
4166
4167 2018-04-09  Pedro Alves  <palves@redhat.com>
4168
4169         * gdbarch.sh: Include "observable.h" instead of "observer.h".
4170         (set_target_gdbarch): Call
4171         gdb::observers::architecture_changed.notify instead of
4172         observer_notify_architecture_changed.
4173
4174 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
4175
4176         * tracepoint.c (struct current_traceframe_cleanup): Remove.
4177         (do_restore_current_traceframe_cleanup): Remove.
4178         (restore_current_traceframe_cleanup_dtor): Remove.
4179         (make_cleanup_restore_current_traceframe): Remove.
4180         (scoped_restore_current_traceframe::scoped_restore_current_traceframe):
4181         New.
4182         * tracepoint.h (struct scoped_restore_current_traceframe): New.
4183         * infrun.c (fetch_inferior_event): Use
4184         scoped_restore_current_traceframe.
4185
4186 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
4187
4188         * dwarf2read.h (struct dwarf2_per_objfile) <n_type_units>:
4189         Remove.
4190         <n_allocated_type_units>: Remove.
4191         <all_type_units>: Change to std::vector.
4192         * dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile): Adjust
4193         to std::vector change.
4194         (dwarf2_per_objfile::get_cutu): Likewise.
4195         (dwarf2_per_objfile::get_tu): Likewise.
4196         (create_signatured_type_table_from_index): Likewise.
4197         (create_signatured_type_table_from_debug_names): Likewise.
4198         (dw2_symtab_iter_next): Likewise.
4199         (dw2_print_stats): Likewise.
4200         (dw2_expand_all_symtabs): Likewise.
4201         (dw2_expand_marked_cus): Likewise.
4202         (dw2_debug_names_iterator::next): Likewise.
4203         (dwarf2_initialize_objfile): Likewise.
4204         (add_signatured_type_cu_to_table): Likewise.
4205         (create_all_type_units): Likewise.
4206         (add_type_unit): Likewise.
4207         (struct tu_abbrev_offset): Add constructor.
4208         (build_type_psymtabs_1): Adjust to std::vector change.
4209         (print_tu_stats): Likewise.
4210         * dwarf-index-write.c (check_dwarf64_offsets): Likewise.
4211         (write_debug_names): Likewise.
4212
4213 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
4214
4215         * dwarf2read.h (struct dwarf2_per_objfile) <all_comp_units>: Likewise.
4216         Make an std::vector.
4217         <n_comp_units>: Remove.
4218         * dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile): Adjust
4219         to std::vector change.
4220         (dwarf2_per_objfile::get_cutu): Likewise.
4221         (dwarf2_per_objfile::get_cu): Likewise.
4222         (create_cus_from_index): Likewise.
4223         (create_addrmap_from_index): Likewise.
4224         (create_addrmap_from_aranges): Likewise.
4225         (dwarf2_read_index): Likewise.
4226         (dw2_find_last_source_symtab): Likewise.
4227         (dw2_map_symtabs_matching_filename): Likewise.
4228         (dw2_symtab_iter_next): Likewise.
4229         (dw2_print_stats): Likewise.
4230         (dw2_expand_all_symtabs): Likewise.
4231         (dw2_expand_symtabs_with_fullname): Likewise.
4232         (dw2_expand_marked_cus): Likewise.
4233         (dw2_map_symbol_filenames): Likewise.
4234         (create_cus_from_debug_names): Likewise.
4235         (dwarf2_read_debug_names): Likewise.
4236         (dw2_debug_names_iterator::next): Likewise.
4237         (dwarf2_initialize_objfile): Likewise.
4238         (set_partial_user): Likewise.
4239         (dwarf2_build_psymtabs_hard): Likewise.
4240         (read_comp_units_from_section): Remove arguments, adjust to
4241         std::vector change.
4242         (create_all_comp_units): Adjust to std::vector and
4243         read_comp_units_from_section changes.
4244         (dwarf2_find_containing_comp_unit): Adjust to std::vector
4245         change.
4246         * dwarf-index-write.c (check_dwarf64_offsets): Likewise.
4247         (psyms_seen_size): Likewise.
4248         (write_gdbindex): Likewise.
4249         (write_debug_names): Likewise.
4250
4251 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
4252
4253         * dwarf2read.c (create_cus_from_index_list): Replace objfile arg
4254         with dwarf2_per_objfile.
4255         (create_cus_from_index): Likewise.
4256         (create_signatured_type_table_from_index): Likewise.
4257         (dwarf2_read_index): Likewise.
4258         (dwarf2_initialize_objfile): Likewise.
4259         (dwarf2_fetch_die_loc_sect_off):  Get dwarf2_per_objfile from
4260         per_cu rather than get_dwarf2_per_objfile.
4261
4262 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
4263
4264         * dwarf2read.h (struct signatured_type): Forward declare.
4265         (struct dwarf2_per_objfile) <get_cutu, get_cu, get_tu>:
4266         New methods.
4267         * dwarf2read.c (dwarf2_per_objfile::get_cutu): Rename from...
4268         (dw2_get_cutu): ...this.
4269         (dwarf2_per_objfile::get_cu): Rename from...
4270         (dw2_get_cu): ...this.
4271         (dwarf2_per_objfile::get_tu): New.
4272         (create_addrmap_from_index): Adjust.
4273         (create_addrmap_from_aranges): Adjust.
4274         (dw2_find_last_source_symtab): Adjust.
4275         (dw2_map_symtabs_matching_filename): Adjust.
4276         (dw2_symtab_iter_next): Adjust.
4277         (dw2_print_stats): Adjust.
4278         (dw2_expand_all_symtabs): Adjust.
4279         (dw2_expand_symtabs_with_fullname): Adjust.
4280         (dw2_expand_marked_cus): Adjust.
4281         (dw_expand_symtabs_matching_file_matcher): Adjust.
4282         (dw2_map_symbol_filenames): Adjust.
4283         (dw2_debug_names_iterator::next): Adjust.
4284         (dwarf2_initialize_objfile): Adjust.
4285         (set_partial_user): Adjust.
4286         (dwarf2_build_psymtabs_hard): Adjust.
4287
4288 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
4289
4290         * dwarf2read.c (create_signatured_type_table_from_debug_names):
4291         Remove unused variables.
4292         (dw2_map_symtabs_matching_filename): Likewise.
4293         (dwarf2_record_block_ranges): Likewise.
4294         (dwarf2_read_addr_index): Likewise.
4295         (follow_die_offset): Likewise.
4296
4297 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
4298
4299         * progspace.c (clone_program_space): Pass SYMFILE_DEFER_BP_RESET
4300         to symbol_file_add_main.
4301
4302 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
4303
4304         PR mi/22299
4305         * mi/mi-console.c (do_fputc_async_safe): New.
4306         (mi_console_file::write_async_safe): New.
4307         (mi_console_file::flush): Adjust calls to fputstrn_unfiltered.
4308         * mi/mi-console.h (class mi_console_file) <write_async_safe>:
4309         New.
4310         * ui-file.c (ui_file::putstrn): Adjust call to
4311         fputstrn_unfiltered.
4312         * utils.c (printchar): Replace do_fputs and do_fprintf
4313         parameters by do_fputc.
4314         (fputstr_filtered): Adjust call to printchar.
4315         (fputstr_unfiltered): Likewise.
4316         (fputstrn_filtered): Likewise.
4317         (fputstrn_unfiltered): Add do_fputc parameter, pass to
4318         printchar.
4319         * utils.h (do_fputc_ftype): New typedef.
4320         (fputstrn_unfiltered): Add do_fputc parameter.
4321
4322 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
4323
4324         * regformats/i386/i386-avx.dat: Remove.
4325
4326 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
4327
4328         PR gdb/22979
4329         * amd64-tdep.c (amd64_none_init_abi): New function.
4330         (amd64_x32_none_init_abi): New function.
4331         (_initialize_amd64_tdep): Register handlers for x86-64 and
4332         x64_32 with GDB_OSABI_NONE.
4333         * osabi.c (gdbarch_init_osabi): Allow running handlers for the
4334         GDB_OSABI_NONE osabi.
4335
4336 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
4337
4338         PR gdb/22980
4339         * defs.h (enum gdb_osabi): Remove GDB_OSABI_UNINITIALIZED, add
4340         GDB_OSABI_NONE.
4341         * arch-utils.c (gdbarch_info_init): Don't set info->osabi.
4342         * osabi.c (gdb_osabi_names): Add "unknown" entry.
4343
4344 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
4345
4346         * common/byte-vector.h (char_vector): New type.
4347         * target.h (target_read_alloc): Return
4348         gdb::optional<byte_vector>.
4349         (target_read_stralloc): Return gdb::optional<char_vector>.
4350         (target_get_osdata): Return gdb::optional<char_vector>.
4351         * target.c (target_read_alloc_1): Templatize.  Replacement
4352         manual memory management with vector.
4353         (target_read_alloc): Change return type, adjust.
4354         (target_read_stralloc): Change return type, adjust.
4355         (target_get_osdata): Change return type, adjust.
4356         * auxv.c (struct auxv_info) <length>: Remove.
4357         <data>: Change type to gdb::optional<byte_vector>.
4358         (auxv_inferior_data_cleanup): Free auxv_info with delete.
4359         (get_auxv_inferior_data): Allocate auxv_info with new, adjust.
4360         (target_auxv_search): Adjust.
4361         (fprint_target_auxv): Adjust.
4362         * avr-tdep.c (avr_io_reg_read_command): Adjust.
4363         * linux-tdep.c (linux_spu_make_corefile_notes): Adjust.
4364         (linux_make_corefile_notes): Adjust.
4365         * osdata.c (get_osdata): Adjust.
4366         * remote.c (remote_get_threads_with_qxfer): Adjust.
4367         (remote_memory_map): Adjust.
4368         (remote_traceframe_info): Adjust.
4369         (btrace_read_config): Adjust.
4370         (remote_read_btrace): Adjust.
4371         (remote_pid_to_exec_file): Adjust.
4372         * solib-aix.c (solib_aix_get_library_list): Adjust.
4373         * solib-dsbt.c (decode_loadmap): Don't free buf.
4374         (dsbt_get_initial_loadmaps): Adjust.
4375         * solib-svr4.c (svr4_current_sos_via_xfer_libraries): Adjust.
4376         * solib-target.c (solib_target_current_sos): Adjust.
4377         * tracepoint.c (sdata_make_value): Adjust.
4378         * xml-support.c (xinclude_start_include): Adjust.
4379         (xml_fetch_content_from_file): Adjust.
4380         * xml-support.h (xml_fetch_another): Change return type.
4381         (xml_fetch_content_from_file): Change return type.
4382         * xml-syscall.c (xml_init_syscalls_info): Adjust.
4383         * xml-tdesc.c (file_read_description_xml): Adjust.
4384         (fetch_available_features_from_target): Change return type.
4385         (target_fetch_description_xml): Adjust.
4386         (target_read_description_xml): Adjust.
4387
4388 2018-04-06  Tom Tromey  <tom@tromey.com>
4389
4390         * value.c (~value): Update.
4391         (struct value) <contents>: Now unique_xmalloc_ptr.
4392         (value_contents_bits_eq, allocate_value_contents)
4393         (value_contents_raw, value_contents_all_raw)
4394         (value_contents_for_printing, value_contents_for_printing_const)
4395         (set_value_enclosing_type): Update.
4396
4397 2018-04-06  Tom Tromey  <tom@tromey.com>
4398
4399         * value.c (range_s): Remove typedef, VEC.
4400         (struct range): Add operator<.
4401         (range_lessthan): Remove.
4402         (ranges_contain): Change type.
4403         (~value): Update.
4404         (struct value) <unavailable, optimized_out>: Now std::vector.
4405         (value_entirely_available)
4406         (value_entirely_covered_by_range_vector)
4407         (value_entirely_unavailable, value_entirely_optimized_out):
4408         Update.
4409         (insert_into_bit_range_vector): Change argument type.
4410         (find_first_range_overlap): Likewise.
4411         (struct ranges_and_idx, value_contents_bits_eq)
4412         (require_not_optimized_out, require_available): Update.
4413         (ranges_copy_adjusted): Change argument types.
4414         (value_optimized_out, value_copy, value_fetch_lazy): Update.
4415
4416 2018-04-06  Tom Tromey  <tom@tromey.com>
4417
4418         * value.c (~value): Update.
4419         (struct value) <parent>: Now a value_ref_ptr.
4420         (value_parent, set_value_parent, value_address, value_copy):
4421         Update.
4422
4423 2018-04-06  Tom Tromey  <tom@tromey.com>
4424
4425         * value.c (struct value): Add constructor, destructor, and member
4426         initializers.
4427         (allocate_value_lazy, value_decref): Update.
4428
4429 2018-04-06  Tom Tromey  <tom@tromey.com>
4430
4431         * value.c (struct value) <released, next>: Remove.
4432         (all_values): Now a std::vector.
4433         (allocate_value_lazy): Update.
4434         (value_next): Remove.
4435         (value_mark, value_free_to_mark, release_value)
4436         (value_release_to_mark): Update.
4437
4438 2018-04-06  Tom Tromey  <tom@tromey.com>
4439
4440         * value.h (fetch_subexp_value, value_release_to_mark): Update.
4441         (free_value_chain): Remove.
4442         * value.c (free_value_chain): Remove.
4443         (value_release_to_mark): Return a std::vector.
4444         * ppc-linux-nat.c (num_memory_accesses): Change "chain" to a
4445         std::vector.
4446         (check_condition): Update.
4447         * eval.c (fetch_subexp_value): Change "val_chain" to a
4448         std::vector.
4449         * breakpoint.c (update_watchpoint): Update.
4450         (can_use_hardware_watchpoint): Change "vals" to a std::vector.
4451
4452 2018-04-06  Tom Tromey  <tom@tromey.com>
4453
4454         * value.h (free_all_values): Remove.
4455         * value.c (free_all_values): Remove.
4456
4457 2018-04-06  Tom Tromey  <tom@tromey.com>
4458
4459         * value.c (VALUE_HISTORY_CHUNK, struct value_history_chunk)
4460         (value_history_chain, value_history_count): Remove.
4461         (value_history): New global.
4462         (record_latest_value, access_value_history, show_values)
4463         (preserve_values): Update.
4464
4465 2018-04-06  Tom Tromey  <tom@tromey.com>
4466
4467         * varobj.h (struct varobj) <value>: Now a value_ref_ptr.
4468         * varobj.c (varobj_set_display_format, varobj_set_value)
4469         (install_default_visualizer, construct_visualizer)
4470         (install_new_value, ~varobj, varobj_get_value_type)
4471         (my_value_of_variable, varobj_editable_p): Update.
4472         * c-varobj.c (c_describe_child, c_value_of_variable)
4473         (cplus_number_of_children, cplus_describe_child): Update.
4474         * ada-varobj.c (ada_number_of_children, ada_name_of_child)
4475         (ada_path_expr_of_child, ada_value_of_child, ada_type_of_child)
4476         (ada_value_of_variable, ada_value_is_changeable_p): Update.
4477
4478 2018-04-06  Tom Tromey  <tom@tromey.com>
4479
4480         * printcmd.c (last_examine_address): Change type to
4481         value_ref_ptr.
4482         (do_examine, x_command): Update.
4483
4484 2018-04-06  Tom Tromey  <tom@tromey.com>
4485
4486         * value.c (release_value): Update.
4487         * breakpoint.h (struct watchpoint) <val>: Now a value_ref_ptr.
4488         (struct bpstats) <val>: Now a value_ref_ptr.
4489         * breakpoint.c (update_watchpoint, breakpoint_init_inferior)
4490         (~bpstats, bpstats, bpstat_clear_actions, watchpoint_check)
4491         (~watchpoint, print_it_watchpoint, watch_command_1)
4492         (invalidate_bp_value_on_memory_change): Update.
4493
4494 2018-04-06  Tom Tromey  <tom@tromey.com>
4495
4496         * varobj.c (varobj_clear_saved_item)
4497         (update_dynamic_varobj_children, install_new_value, ~varobj):
4498         Update.
4499         * value.h (value_incref): Move declaration earlier.
4500         (value_decref): Rename from value_free.
4501         (struct value_ref_policy): New.
4502         (value_ref_ptr): New typedef.
4503         (struct value_deleter): Remove.
4504         (gdb_value_up): Remove typedef.
4505         (release_value): Change return type.
4506         (release_value_or_incref): Remove.
4507         * value.c (set_value_parent): Update.
4508         (value_incref): Change return type.
4509         (value_decref): Rename from value_free.
4510         (value_free_to_mark, free_all_values, free_value_chain): Update.
4511         (release_value): Return value_ref_ptr.
4512         (release_value_or_incref): Remove.
4513         (record_latest_value, set_internalvar, clear_internalvar):
4514         Update.
4515         * stack.c (info_frame_command): Don't call value_free.
4516         * python/py-value.c (valpy_dealloc, valpy_new)
4517         (value_to_value_object): Update.
4518         * printcmd.c (do_examine): Update.
4519         * opencl-lang.c (lval_func_free_closure): Update.
4520         * mi/mi-main.c (register_changed_p): Don't call value_free.
4521         * mep-tdep.c (mep_frame_prev_register): Don't call value_free.
4522         * m88k-tdep.c (m88k_frame_prev_register): Don't call value_free.
4523         * m68hc11-tdep.c (m68hc11_frame_prev_register): Don't call
4524         value_free.
4525         * guile/scm-value.c (vlscm_free_value_smob)
4526         (vlscm_scm_from_value): Update.
4527         * frame.c (frame_register_unwind, frame_unwind_register_signed)
4528         (frame_unwind_register_unsigned, get_frame_register_bytes)
4529         (put_frame_register_bytes): Don't call value_free.
4530         * findvar.c (address_from_register): Don't call value_free.
4531         * dwarf2read.c (dwarf2_compute_name): Don't call value_free.
4532         * dwarf2loc.c (entry_data_value_free_closure)
4533         (value_of_dwarf_reg_entry, free_pieced_value_closure)
4534         (dwarf2_evaluate_loc_desc_full): Update.
4535         * breakpoint.c (update_watchpoint, breakpoint_init_inferior)
4536         (~bpstats, bpstats, bpstat_clear_actions, watchpoint_check)
4537         (~watchpoint, watch_command_1)
4538         (invalidate_bp_value_on_memory_change): Update.
4539         * alpha-tdep.c (alpha_register_to_value): Don't call value_free.
4540
4541 2018-04-06  Simon Marchi  <simon.marchi@polymtl.ca>
4542
4543         PR gdb/23022
4544         * warning.m4: Add -Wno-error=deprecated-register.
4545         * configure: Re-generate.
4546
4547 2018-04-05  Tom Tromey  <tom@tromey.com>
4548
4549         * linespec.h: Remove include of "vec.h".
4550
4551 2018-04-05  Tom Tromey  <tom@tromey.com>
4552
4553         * linespec.c (typep): Remove typedef.
4554         (find_methods, find_superclass_methods): Take a std::vector.
4555         (find_method): Use std::vector.
4556
4557 2018-04-05  Tom Tromey  <tom@tromey.com>
4558
4559         * utils.c (compare_strings): Remove.
4560         * utils.h (compare_strings): Remove.
4561         * objc-lang.h (find_imps): Update.
4562         * objc-lang.c (find_methods): Take a std::vector.
4563         (uniquify_strings, find_imps): Likewise.
4564         * linespec.c (find_methods): Take a std::vector.
4565         (decode_objc): Use std::vector.
4566         (add_all_symbol_names_from_pspace, find_superclass_methods): Take
4567         a std::vector.
4568         (find_method, find_function_symbols): Use std::vector.
4569
4570 2018-04-05  Tom Tromey  <tom@tromey.com>
4571
4572         * completer.c (completion_tracker::completion_tracker): Remove
4573         cast.
4574         (completion_tracker::discard_completions): Likewise.
4575         * breakpoint.c (ambiguous_names_p): Remove cast.
4576         * ada-lang.c (_initialize_ada_language): Remove cast.
4577         * utils.h (streq): Update.
4578         (streq_hash): Add new declaration.
4579         * utils.c (streq): Return bool.
4580         (streq_hash): New function.
4581
4582 2018-04-05  Tom Tromey  <tom@tromey.com>
4583
4584         * linespec.c (event_location_to_sals) <case ADDRESS_LOCATION>:
4585         Remove a string copy.
4586
4587 2018-04-05  Tom Tromey  <tom@tromey.com>
4588
4589         * linespec.c (filter_results): Use std::vector.
4590         (decode_line_2, decode_line_full): Update.
4591
4592 2018-04-05  Tom Tromey  <tom@tromey.com>
4593
4594         * linespec.c (canonical_to_fullform): Return std::string.
4595         (filter_results): Update.
4596         (struct decode_line_2_item): Add constructor.
4597         <fullform, displayform>: Now std::string.
4598         (decode_line_2_compare_items): Now a std::sort comparator.
4599         (decode_line_2): Update.
4600
4601 2018-04-05  Tom Tromey  <tom@tromey.com>
4602
4603         * linespec.c (copy_token_string): Return a unique_xmalloc_ptr.
4604         (unexpected_linespec_error): Update.
4605         (linespec_parse_basic, parse_linespec): Update.
4606
4607 2018-04-05  Tom Tromey  <tom@tromey.com>
4608
4609         * linespec.c (linespec_parse_basic): Reindent.
4610
4611 2018-04-05  Tom Tromey  <tom@tromey.com>
4612
4613         * minsyms.h (iterate_over_minimal_symbols): Update.
4614         * minsyms.c (iterate_over_minimal_symbols): Take a
4615         gdb::function_view.
4616         * linespec.c (struct collect_minsyms): Remove.
4617         (compare_msyms): Now a std::sort comparator.
4618         (add_minsym): Add parameters.
4619         (search_minsyms_for_name): Update.  Use std::vector.
4620
4621 2018-04-03  Tom Tromey  <tom@tromey.com>
4622
4623         * mipsread.c (read_alphacoff_dynamic_symtab): Use
4624         gdb::byte_vector.
4625
4626 2018-04-02  Weimin Pan  <weimin.pan@oracle.com>
4627
4628         * MAINTAINERS (Write After Approval): Add Weimin Pan.
4629
4630 2018-04-02  Weimin Pan  <weimin.pan@oracle.com>
4631
4632         PR gdb/16959
4633         * cp-valprint.c: (cp_print_static_field) Fix infinite recursion when 
4634         printing static type.
4635
4636 2018-04-01  Tom Tromey  <tom@tromey.com>
4637
4638         * rs6000-nat.c (rs6000_ptrace_ldinfo): Return a byte_vector.
4639         (rs6000_xfer_shared_libraries): Update.
4640
4641 2018-04-01  Simon Marchi  <simon.marchi@polymtl.ca>
4642
4643         * common/gdb_vecs.h (char_ptr): Remove.
4644         * tracepoint.c (encode_actions_1): Remove usage of char_ptr.
4645
4646 2018-03-30  Simon Marchi  <simon.marchi@polymtl.ca>
4647
4648         * guile/scm-utils.c (gdbscm_parse_function_args): Replace VEC
4649         with std::vector.
4650         * common/gdb_vecs.h (DEF_VEC_P (char_ptr)): Remove.
4651
4652 2018-03-30  Simon Marchi  <simon.marchi@polymtl.ca>
4653
4654         * tracepoint.h (struct uploaded_tp): Initialize fields.
4655         <actions, step_actions, cmd_strings>: Change type to
4656         std::vector<char *>.
4657         * tracepoint.c (get_uploaded_tp): Allocate with new.
4658         (free_uploaded_tps): Free with delete.
4659         (parse_tracepoint_definition): Adjust to std::vector change.
4660         * breakpoint.c (read_uploaded_action): Likewise.
4661         (create_tracepoint_from_upload): Likewise.
4662         * ctf.c (ctf_write_uploaded_tp): Likewise.
4663         (SET_ARRAY_FIELD): Likewise.
4664         * tracefile-tfile.c (tfile_write_uploaded_tp): Likewise.
4665
4666 2018-03-30  Tom Tromey  <tom@tromey.com>
4667
4668         * solib-svr4.c (lm_info_read): Use gdb::byte_vector.  Return
4669         std::unique_ptr.
4670         (svr4_keep_data_in_core): Update.
4671         (svr4_read_so_list): Update.
4672
4673 2018-03-30  Tom Tromey  <tom@tromey.com>
4674
4675         * windows-nat.c (handle_output_debug_string, handle_exception):
4676         Update.
4677         * target.h (target_read_string): Update.
4678         * target.c (target_read_string): Change "string" to
4679         unique_xmalloc_ptr.
4680         * solib-svr4.c (open_symbol_file_object, svr4_read_so_list):
4681         Update.
4682         * solib-frv.c (frv_current_sos): Update.
4683         * solib-dsbt.c (dsbt_current_sos): Update.
4684         * solib-darwin.c (darwin_current_sos): Update.
4685         * linux-thread-db.c (inferior_has_bug): Update.
4686         * expprint.c (print_subexp_standard) <case OP_OBJC_MSGCALL>:
4687         Update.  Remove alloca.
4688         * ada-lang.c (ada_main_name): Update.
4689
4690 2018-03-30  Tom Tromey  <tom@tromey.com>
4691
4692         * dwarf2read.c (struct free_dwo_file_cleanup_data): Remove.
4693         (struct dwo_file_deleter): New.
4694         (dwo_file_up): New typedef.
4695         (open_and_init_dwo_file): Use dwo_file_up.
4696         (free_dwo_file_cleanup): Remove.
4697
4698 2018-03-30  Tom Tromey  <tom@tromey.com>
4699
4700         * dwarf2read.c (free_dwo_file): Remove "objfile" parameter.
4701         (free_dwo_file_cleanup, free_dwo_file_from_slot): Update.
4702
4703 2018-03-30  Tom Tromey  <tom@tromey.com>
4704
4705         * dwarf2read.c (class free_cached_comp_units): New class.
4706         (dw2_instantiate_symtab, dwarf2_build_psymtabs_hard): Use it.
4707         (free_cached_comp_units): Remove function.
4708
4709 2018-03-30  Tom Tromey  <tom@tromey.com>
4710
4711         * utils.h (make_cleanup_unpush_target): Remove.
4712         * inf-ptrace.c (struct target_unpusher): New.
4713         (target_unpush_up) New typedef.
4714         (inf_ptrace_create_inferior, inf_ptrace_attach): Use
4715         target_unpush_up.
4716         * utils.c (do_unpush_target, make_cleanup_unpush_target): Remove.
4717
4718 2018-03-27  Tom Tromey  <tom@tromey.com>
4719
4720         * utils.c (prompt_for_continue): Use unique_xmalloc_ptr.
4721
4722 2018-03-27  Pedro Alves  <palves@redhat.com>
4723             Tom Tromey  <tom@tromey.com>
4724
4725         * top.c (class gdb_readline_wrapper_cleanup): Add constructor,
4726         destructor.  Now a class.
4727         (gdb_readline_wrapper_cleanup): Remove function.
4728         (gdb_readline_wrapper): Remove cleanups.
4729
4730 2018-03-27  Tom Tromey  <tom@tromey.com>
4731
4732         * typeprint.h (struct type_print_options) <local_typedefs,
4733         global_typedefs>: Remove "struct" keyword.
4734         (class typedef_hash_table): New class.
4735         (recursively_update_typedef_hash, add_template_parameters)
4736         (create_typedef_hash, free_typedef_hash, copy_typedef_hash)
4737         (find_typedef_in_hash): Don't declare.
4738         * typeprint.c (struct typedef_hash_table): Move to typeprint.h.
4739         (typedef_hash_table::recursively_update): Rename from
4740         recursively_update_typedef_hash.  Now a member.
4741         (typedef_hash_table::add_template_parameters): Rename from
4742         add_template_parameters.  Now a member.
4743         (typedef_hash_table::typedef_hash_table): Now a constructor;
4744         rename from create_typedef_hash.
4745         (typedef_hash_table::~typedef_hash_table): Now a destructor;
4746         rename from free_typedef_hash.
4747         (do_free_typedef_hash, make_cleanup_free_typedef_hash)
4748         (do_free_global_table): Remove.
4749         (typedef_hash_table::typedef_hash_table): New constructor; renamed
4750         from copy_type_recursive.
4751         (create_global_typedef_table): Remove.
4752         (typedef_hash_table::find_global_typedef): Now a member of
4753         typedef_hash_table.
4754         (typedef_hash_table::find_typedef): Rename from
4755         find_typedef_in_hash; now a member.
4756         (whatis_exp): Update.
4757         * extension.h (struct ext_lang_type_printers): Add constructor and
4758         destructor.
4759         (start_ext_lang_type_printers, free_ext_lang_type_printers): Don't
4760         declare.
4761         * extension.c (ext_lang_type_printers::ext_lang_type_printers):
4762         Now a constructor; rename from start_ext_lang_type_printers.
4763         (ext_lang_type_printers): Now a destructor; rename from
4764         free_ext_lang_type_printers.
4765         * c-typeprint.c (find_typedef_for_canonicalize, c_print_type_1):
4766         Update.
4767         (c_type_print_base_struct_union): Update.  Remove cleanups.
4768
4769 2018-03-27  Tom Tromey  <tom@tromey.com>
4770
4771         * dwarf-index-write.c: Include <cmath>.
4772
4773 2018-03-27  Joel Brobecker  <brobecker@adacore.com>
4774
4775         * NEWS: Add entry describing new "set|show varsize-limit" command.
4776         * ada-lang.c (_initialize_ada_language): Add "set/show varsize-limit"
4777         command.
4778         * printcmd.c (_initialize_printcmd): Add "set var" alias of
4779         "set variable".
4780
4781 2018-03-27  Simon Marchi  <simon.marchi@ericsson.com>
4782
4783         * Makefile.in (COMMON_SFILES): Add dwarf-index-common.c and
4784         dwarf-index-write.c
4785         (HFILES_NO_SRCDIR): Add dwarf-index-common.h and dwarf2read.h.
4786         * dwarf-index-common.c: New file.
4787         * dwarf-index-common.h: New file.
4788         * dwarf-index-write.c: New file.
4789         * dwarf2read.c: Include dwarf2read.h and dwarf-index-common.h.
4790         (struct dwarf2_section_info): Move from here.
4791         (dwarf2_section_info_def): Likewise.
4792         (DEF_VEC_O (dwarf2_section_info_def)): Likewise.
4793         (offset_type): Likewise.
4794         (DW2_GDB_INDEX_SYMBOL_STATIC_SET_VALUE): Likewise.
4795         (DW2_GDB_INDEX_SYMBOL_KIND_SET_VALUE): Likewise.
4796         (DW2_GDB_INDEX_CU_SET_VALUE): Likewise.
4797         (byte_swap): Likewise.
4798         (MAYBE_SWAP): Likewise.
4799         (dwarf2_per_cu_ptr): Likewise.
4800         (DEF_VEC_P (dwarf2_per_cu_ptr)): Likewise.
4801         (struct tu_stats): Likewise.
4802         (struct dwarf2_per_objfile): Likewise.
4803         (struct dwarf2_per_cu_data): Likewise.
4804         (struct signatured_type): Likewise.
4805         (sig_type_ptr): Likewise.
4806         (DEF_VEC_P (sig_type_ptr)): Likewise.
4807         (INDEX4_SUFFIX): Likewise.
4808         (INDEX5_SUFFIX): Likewise.
4809         (DEBUG_STR_SUFFIX): Likewise.
4810         (dwarf2_read_section): Make non-static.
4811         (mapped_index_string_hash): Move from here.
4812         (dwarf5_djb_hash): Likewise.
4813         (file_write): Likewise.
4814         (class data_buf): Likewise.
4815         (struct symtab_index_entry): Likewise.
4816         (struct mapped_symtab): Likewise.
4817         (find_slot): Likewise.
4818         (hash_expand): Likewise.
4819         (add_index_entry): Likewise.
4820         (uniquify_cu_indices): Likewise.
4821         (class c_str_view): Likewise.
4822         (class c_str_view_hasher): Likewise.
4823         (class vector_hasher): Likewise.
4824         (write_hash_table): Likewise.
4825         (psym_index_map): Likewise.
4826         (struct addrmap_index_data): Likewise.
4827         (add_address_entry): Likewise.
4828         (add_address_entry_worker): Likewise.
4829         (write_address_map): Likewise.
4830         (symbol_kind): Likewise.
4831         (write_psymbols): Likewise.
4832         (struct signatured_type_index_data): Likewise.
4833         (write_one_signatured_type): Likewise.
4834         (recursively_count_psymbols): Likewise.
4835         (recursively_write_psymbols): Likewise.
4836         (class debug_names): Likewise.
4837         (check_dwarf64_offsets): Likewise.
4838         (psyms_seen_size): Likewise.
4839         (write_gdbindex): Likewise.
4840         (write_debug_names): Likewise.
4841         (assert_file_size): Likewise.
4842         (write_psymtabs_to_index): Likewise.
4843         (save_gdb_index_command): Likewise.
4844         (_initialize_dwarf2_read): Don't register the "save gdb-index"
4845         command.
4846         * dwarf2read.h: New file.
4847
4848 2018-03-27  Joel Brobecker  <brobecker@adacore.com>
4849
4850         PR gdb/22670
4851         * dwarf2read.c (dwarf2_physname): Do not return the demangled
4852         symbol name if the CU's language stores symbol names in linkage
4853         format.
4854         * language.h (struct language_defn)
4855         <la_store_sym_names_in_linkage_form_p>: New field.  Adjust
4856         all instances of this struct.
4857
4858 2018-03-26  Tom Tromey  <tom@tromey.com>
4859
4860         * stack.c (backtrace_command_1): Remove verbose code.
4861
4862 2018-03-26  Tom Tromey  <tom@tromey.com>
4863
4864         * python/py-framefilter.c (py_print_type): Don't catch
4865         exceptions.  Return void.
4866         (py_print_value): Likewise.
4867         (py_print_single_arg): Likewise.
4868         (enumerate_args): Don't catch exceptions.
4869         (py_print_args): Likewise.
4870         (py_print_frame): Likewise.
4871         (gdbpy_apply_frame_filter): Catch exceptions here.
4872
4873 2018-03-26  Tom Tromey  <tom@tromey.com>
4874
4875         * stack.c (_initialize_stack): Remove trailing newlines from help
4876         text.  Add "Usage" line to "backtrace" help.
4877
4878 2018-03-26  Tom Tromey  <tom@tromey.com>
4879
4880         PR python/16486:
4881         * python/py-framefilter.c (py_print_args): Call wrap_hint.
4882
4883 2018-03-26  Tom Tromey  <tom@tromey.com>
4884
4885         * python/py-framefilter.c (py_print_single_arg): Return
4886         EXT_LANG_BT_ERROR from catch.
4887
4888 2018-03-26  Tom Tromey  <tom@tromey.com>
4889
4890         PR backtrace/15584:
4891         * stack.c (backtrace_command_1): Move some code into no-filters
4892         "if".
4893
4894 2018-03-26  Tom Tromey  <tom@tromey.com>
4895
4896         * python/py-framefilter.c (throw_quit_or_print_exception): New
4897         function.
4898         (gdbpy_apply_frame_filter): Use it.
4899
4900 2018-03-26  Tom Tromey  <tom@tromey.com>
4901
4902         PR cli/17716:
4903         * python/py-framefilter.c (py_print_type, py_print_value)
4904         (enumerate_args, py_print_args, gdbpy_apply_frame_filter): Use
4905         RETURN_MASK_ERROR.
4906
4907 2018-03-26  Tom Tromey  <tom@tromey.com>
4908
4909         * python/py-framefilter.c (enumerate_args): Use
4910         gdb::unique_xmalloc_ptr.
4911
4912 2018-03-26  Tom Tromey  <tom@tromey.com>
4913
4914         * python/py-framefilter.c (py_print_frame): Return
4915         EXT_LANG_BT_OK.
4916         (gdbpy_apply_frame_filter): Update comment.
4917         * extension.h (enum ext_lang_bt_status) <EXT_LANG_BT_COMPLETED>:
4918         Remove.
4919         <EXT_LANG_BT_NO_FILTERS>: Change value.
4920
4921 2018-03-26  Tom Tromey  <tom@tromey.com>
4922
4923         PR backtrace/15582:
4924         * stack.c (backtrace_command): Parse "hide" argument.
4925         * python/py-framefilter.c (py_print_frame): Handle PRINT_HIDE.
4926         * extension.h (enum frame_filter_flags) <PRINT_HIDE>: New
4927         constant.
4928
4929 2018-03-26  Tom Tromey  <tom@tromey.com>
4930
4931         * stack.c (backtrace_command_1): Remove "show_locals" parameter,
4932         add "flags".
4933         (backtrace_command): Remove "fulltrace", add "flags".
4934
4935 2018-03-26  Tom Tromey  <tom@tromey.com>
4936
4937         * stack.c (backtrace_command): Rewrite command line parsing.
4938
4939 2018-03-26  Simon Marchi  <simon.marchi@ericsson.com>
4940
4941         * dwarf2read.c (DEF_VEC_I(offset_type)): Remove.
4942
4943 2018-03-26  Simon Marchi  <simon.marchi@ericsson.com>
4944
4945         * filename-seen-cache.h: Add include guard.
4946
4947 2018-03-26  Keith Seitz  <keiths@redhat.com>
4948
4949         * symfile.c (place_section): Remove "struct" from section_addr_info
4950         in comment.
4951         * windows-nat.c (struct safe_symbol_file_add_args) <addrs>: Remove
4952         "struct" keyword from section_addr_info.
4953
4954 2018-03-26  Alan Hayward  <alan.hayward@arm.com>
4955
4956         * regformats/regdef.h (reg): Add constructors.
4957
4958 2018-03-25  Pedro Alves  <palves@redhat.com>
4959
4960         * eval.c (evaluate_funcall): Swap OP_VAR_MSYM_VALUE/OP_VAR_VALUE
4961         if then/else bodies in var_func_name extraction.
4962
4963 2018-03-23  Weimin Pan  <weimin.pan@oracle.com>
4964
4965         * minsyms.c (lookup_minimal_symbol_and_objfile): Use
4966         lookup_minimal_symbol() to find symbol entry.
4967         * minsyms.h (lookup_minimal_symbol_and_objfile): Update comment.
4968
4969 2018-03-23  Keith Seitz  <keiths@redhat.com>
4970
4971         PR c++/22968
4972         * dwarf2read.c (scan_partial_symbols): Scan structs/classes for
4973         nested type definitions for C++, too.
4974
4975 2018-03-23  Tom Tromey  <tom@tromey.com>
4976
4977         * machoread.c (struct oso_el): Add a constructor.  Don't define as
4978         a typedef.
4979         (macho_register_oso): Remove.
4980         (macho_symtab_read): Take a std::vector.
4981         (oso_el_compare_name): Now a std::sort comparator.
4982         (macho_symfile_read_all_oso): Take a std::vector.
4983         (macho_symfile_read): Use std::vector.  Remove cleanups.
4984
4985 2018-03-22  Tom Tromey  <tom@tromey.com>
4986
4987         * record-full.c (record_full_exec_insn): Use gdb::byte_vector.
4988         (record_full_goto_bookmark): Use std::string.
4989
4990 2018-03-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
4991
4992         PR tdep/18295
4993         * rs6000-tdep.c (skip_prologue): Match both stwux and stdux
4994         a single mask.
4995
4996 2018-03-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
4997
4998         * rs6000-tdep.c (store_insn_p): New function.
4999         (skip_prologue): New variable alloca_reg_offset. Set lr_reg
5000         and cr_reg to their unshifted values. Use store_insn_p to
5001         match LR saves using either R1 or fdata->alloca_reg. Use
5002         store_insn_p to match CR saves. Set alloca_reg_offset
5003         when alloca_reg and framep are set. Remove lr_reg shift
5004         when assigning to fdata->lr_register.
5005
5006 2018-03-22  Andreas Arnez  <arnez@linux.vnet.ibm.com>
5007
5008         * linux-tdep.c (linux_info_proc): For "info proc cmdline", print
5009         command line args instead of emitting a warning.
5010
5011 2018-03-22  Simon Marchi  <simon.marchi@polymtl.ca>
5012
5013         * tracepoint.h (struct static_tracepoint_marker): Initialize
5014         fields, define default constructor, move constructor and move
5015         assignment, disable the rest.
5016         <str_id, extra>: Make std::string.
5017         (release_static_tracepoint_marker): Remove.
5018         (free_current_marker): Remove.
5019         * tracepoint.c (free_current_marker): Remove.
5020         (parse_static_tracepoint_marker_definition): Adjust to
5021         std::string, use new hex2str overload.
5022         (release_static_tracepoint_marker): Remove.
5023         (print_one_static_tracepoint_marker): Get marker by reference
5024         and adjust to std::string.
5025         (info_static_tracepoint_markers_command): Adjust to std::vector
5026         changes
5027         * target.h (static_tracepoint_marker_p): Remove typedef.
5028         (DEF_VEC_P(static_tracepoint_marker_p)): Remove.
5029         (struct target_ops) <to_static_tracepoint_marker_at>: Return
5030         bool.
5031         <to_static_tracepoint_markers_by_strid>: Return std::vector.
5032         * target-debug.h
5033         (target_debug_print_VEC_static_tracepoint_marker_p_p): Remove.
5034         (target_debug_print_std_vector_static_tracepoint_marker): New.
5035         (target_debug_print_struct_static_tracepoint_marker_p): Rename
5036         to...
5037         (target_debug_print_static_tracepoint_marker_p): ... this.
5038         * target-delegates.c: Re-generate.
5039         * breakpoint.h (struct tracepoint) <static_trace_marker_id>:
5040         Make std::string.
5041         * breakpoint.c (init_breakpoint_sal): Adjust to std::string.
5042         (decode_static_tracepoint_spec): Adjust to std::vector.
5043         (tracepoint_print_one_detail): Adjust to std::string.
5044         (strace_marker_decode_location): Adjust to std::string.
5045         (update_static_tracepoint): Adjust to std::string, remove call
5046         to release_static_tracepoint_marker.
5047         * linux-nat.c (linux_child_static_tracepoint_markers_by_strid):
5048         Adjust to std::vector.
5049         * remote.c (remote_static_tracepoint_marker_at): Return bool.
5050         (remote_static_tracepoint_markers_by_strid): Adjust to
5051         std::vector.
5052         * common/rsp-low.h (hex2str): New overload with explicit count
5053         of bytes.
5054         * common/rsp-low.c (hex2str): New overload with explicit count
5055         of bytes.
5056         * unittests/rsp-low-selftests.c (test_hex2str): New function.
5057         (_initialize_rsp_low_selftests): Add test_hex2str test.
5058         * unittests/tracepoint-selftests.c
5059         (test_parse_static_tracepoint_marker_definition): Adjust to
5060         std::string.
5061
5062 2018-03-22  Simon Marchi  <simon.marchi@polymtl.ca>
5063
5064         * tracepoint.c (parse_static_tracepoint_marker_definition):
5065         Consider case where the definition is followed by more
5066         definitions.
5067         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5068         tracepoint-selftests.c.
5069         * unittests/tracepoint-selftests.c: New.
5070
5071 2018-03-21  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
5072
5073         * MAINTAINERS (Write After Approval): Add Pedro Franco de
5074         Carvalho.
5075
5076 2018-03-20  Stephen Roberts  <stephen.roberts@arm.com>
5077
5078         * symtab.c (find_pc_sect_line): fixed indentation.
5079
5080 2018-03-20  Stephen Roberts  <stephen.roberts@arm.com>
5081
5082         * symtab.c (find_pc_sect_line): now uses binary search.
5083
5084 2018-03-19  Tom Tromey  <tom@tromey.com>
5085
5086         * rust-exp.y (struct_expr_tail, struct_expr_list): Add plain
5087         "IDENT" production.
5088
5089 2018-03-19  Pedro Alves  <palves@redhat.com>
5090             Tom Tromey  <tom@tromey.com>
5091
5092         * unittests/observable-selftests.c: New file.
5093         * common/observable.h: New file.
5094         * observable.h: New file.
5095         * ada-lang.c, ada-tasks.c, agent.c, aix-thread.c, annotate.c,
5096         arm-tdep.c, auto-load.c, auxv.c, break-catch-syscall.c,
5097         breakpoint.c, bsd-uthread.c, cli/cli-interp.c, cli/cli-setshow.c,
5098         corefile.c, dummy-frame.c, event-loop.c, event-top.c, exec.c,
5099         extension.c, frame.c, gdbarch.c, guile/scm-breakpoint.c,
5100         infcall.c, infcmd.c, inferior.c, inflow.c, infrun.c, jit.c,
5101         linux-tdep.c, linux-thread-db.c, m68klinux-tdep.c,
5102         mi/mi-cmd-break.c, mi/mi-interp.c, mi/mi-main.c, objfiles.c,
5103         ppc-linux-nat.c, ppc-linux-tdep.c, printcmd.c, procfs.c,
5104         python/py-breakpoint.c, python/py-finishbreakpoint.c,
5105         python/py-inferior.c, python/py-unwind.c, ravenscar-thread.c,
5106         record-btrace.c, record-full.c, record.c, regcache.c, remote.c,
5107         riscv-tdep.c, sol-thread.c, solib-aix.c, solib-spu.c, solib.c,
5108         spu-multiarch.c, spu-tdep.c, stack.c, symfile-mem.c, symfile.c,
5109         symtab.c, thread.c, top.c, tracepoint.c, tui/tui-hooks.c,
5110         tui/tui-interp.c, valops.c: Update all users.
5111         * tui/tui-hooks.c (tui_bp_created_observer)
5112         (tui_bp_deleted_observer, tui_bp_modified_observer)
5113         (tui_inferior_exit_observer, tui_before_prompt_observer)
5114         (tui_normal_stop_observer, tui_register_changed_observer):
5115         Remove.
5116         (tui_observers_token): New global.
5117         (attach_or_detach, tui_attach_detach_observers): New functions.
5118         (tui_install_hooks, tui_remove_hooks): Use
5119         tui_attach_detach_observers.
5120         * record-btrace.c (record_btrace_thread_observer): Remove.
5121         (record_btrace_thread_observer_token): New global.
5122         * observer.sh: Remove.
5123         * observer.c: Rename to observable.c.
5124         * observable.c (namespace gdb_observers): Define new objects.
5125         (observer_debug): Move into gdb_observers namespace.
5126         (struct observer, struct observer_list, xalloc_observer_list_node)
5127         (xfree_observer_list_node, generic_observer_attach)
5128         (generic_observer_detach, generic_observer_notify): Remove.
5129         (_initialize_observer): Update.
5130         Don't include observer.inc.
5131         * Makefile.in (generated_files): Remove observer.h, observer.inc.
5132         (clean mostlyclean): Likewise.
5133         (observer.h, observer.inc): Remove targets.
5134         (SUBDIR_UNITTESTS_SRCS): Add observable-selftests.c.
5135         (COMMON_SFILES): Use observable.c, not observer.c.
5136         * .gitignore: Remove observer.h.
5137
5138 2018-03-18  Tom Tromey  <tom@tromey.com>
5139
5140         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Use
5141         gdb::def_vector.
5142         (bfd_lookup_symbol_from_dyn_symtab): Likewise.
5143
5144 2018-03-17  Tom Tromey  <tom@tromey.com>
5145
5146         * auto-load.c (auto_load_objfile_script_1): Use std::string.
5147
5148 2018-03-17  Tom Tromey  <tom@tromey.com>
5149
5150         * target.c (class scoped_target_fd): New.
5151         (target_fileio_close_cleanup): Remove.
5152         (target_fileio_read_alloc_1): Use scoped_target_fd.
5153
5154 2018-03-16  Simon Marchi  <simon.marchi@polymtl.ca>
5155
5156         * silent-rules.mk: New.
5157         * Makefile.in: Include silent-rules.mk
5158         (srcdir, VPATH, top_srcdir): Move up.
5159         (COMPILE): Add ECHO_CXX.
5160         (test-cp-name-parser$(EXEEXT)): Add ECHO_CXXLD.
5161         (init.c): Add ECHO_INIT_C.
5162         (gdb$(EXEEXT)): Add SILENCE and ECHO_CXXLD.
5163         (version.c): Add ECHO_GEN.
5164         (printcmd.o): Add ECHO_CXX.
5165         (target-float.o): Add ECHO_CXX.
5166         (ada-exp.o): Add ECHO_CXX.
5167         (stamp-xml): Add SILENCE and ECHO_GEN_XML_BUILTIN.
5168         (insight$(EXEEXT)): Add ECHO_CXXLD.
5169         * gnulib/configure.ac: Add AM_SILENT_RULES.
5170         * gnulib/aclocal.m4: Re-generate.
5171         * gnulib/configure: Re-generate.
5172         * gnulib/import/Makefile.in: Re-generate.
5173
5174 2018-03-16  Tom Tromey  <tom@tromey.com>
5175
5176         * xcoffread.c (xcoff_symfile_offsets): Change type of "addrs".
5177         * utils.h (make_cleanup_free_section_addr_info): Don't declare.
5178         * utils.c (do_free_section_addr_info)
5179         (make_cleanup_free_section_addr_info): Remove.
5180         * symfile.h (struct other_sections): Add constructor.
5181         (struct section_addr_info): Remove.
5182         (section_addr_info): New typedef.
5183         (struct sym_fns) <sym_offsets>: Change type of parameter.
5184         (build_section_addr_info_from_objfile)
5185         (relative_addr_info_to_section_offsets, addr_info_make_relative)
5186         (default_symfile_offsets, symbol_file_add)
5187         (symbol_file_add_from_bfd)
5188         (build_section_addr_info_from_section_table): Update.
5189         (alloc_section_addr_info, free_section_addr_info): Don't declare.
5190         * symfile.c (alloc_section_addr_info): Remove.
5191         (build_section_addr_info_from_section_table): Change return type.
5192         Update.
5193         (build_section_addr_info_from_bfd)
5194         (build_section_addr_info_from_objfile): Likewise.
5195         (free_section_addr_info): Remove.
5196         (relative_addr_info_to_section_offsets): Change type of "addrs".
5197         (addrs_section_compar): Now a std::sort comparator.
5198         (addrs_section_sort): Change return type.
5199         (addr_info_make_relative): Change type of "addrs".  Update.
5200         (default_symfile_offsets, syms_from_objfile_1)
5201         (syms_from_objfile, symbol_file_add_with_addrs): Likewise.
5202         (symbol_file_add_separate): Update.
5203         (symbol_file_add): Change type of "addrs".  Update.
5204         (add_symbol_file_command): Update.  Remove cleanups.
5205         * symfile-mem.c (symbol_file_add_from_memory): Update.  Remove
5206         cleanups.
5207         * symfile-debug.c (debug_sym_offsets): Change type of "info".
5208         * solib.c (solib_read_symbols): Update.
5209         * objfiles.c (objfile_relocate): Update.  Remove cleanups.
5210         * machoread.c (macho_symfile_offsets): Update.
5211         * jit.c (jit_bfd_try_read_symtab): Update.
5212
5213 2018-03-15  Simon Marchi  <simon.marchi@polymtl.ca>
5214
5215         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5216         unittests/utils-selftests.c.
5217         * unittests/utils-selftests.c: New file.
5218
5219 2018-03-14  Tom Tromey  <tom@tromey.com>
5220
5221         PR cli/14977:
5222         * printcmd.c (printf_c_string, printf_wide_c_string): Special case
5223         for NULL.
5224
5225 2018-03-14  Tom Tromey  <tom@tromey.com>
5226
5227         PR cli/19918:
5228         * printcmd.c (printf_pointer): Allow "-" in format.
5229
5230 2018-03-14  Tom Tromey  <tom@tromey.com>
5231
5232         * printcmd.c (_initialize_printcmd): Add usage to printf.
5233
5234 2018-03-14  Yao Qi  <qiyao@sourceware.org>
5235
5236         * MAINTAINERS: Update my email address.
5237
5238 2018-03-13  Tom Tromey  <tom@tromey.com>
5239
5240         * machoread.c (macho_check_dsym): Change filenamep to a
5241         std::string*.
5242         (macho_symfile_read): Update.
5243         * symfile.c (load_command): Use std::string.
5244
5245 2018-03-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5246
5247         * riscv-tdep.c (riscv_sw_breakpoint_from_kind): Add localization
5248         to error message string.
5249         (riscv_register_name): Use xsnprintf instead of sprintf.
5250         (riscv_insn::fetch_instruction): Use gdb_assert instead of
5251         internal_error.
5252         (riscv_print_arg_location): Use gdb_assert_not_reached instead of
5253         error.
5254         (riscv_push_dummy_call): Likewise.
5255
5256 2018-03-12  Tom Tromey  <tom@tromey.com>
5257
5258         * rs6000-aix-tdep.c (rs6000_aix_core_xfer_shared_libraries_aix):
5259         Use gdb::byte_vector.
5260         * arm-tdep.c (arm_exidx_new_objfile): Use gdb::byte_vector.
5261
5262 2018-03-12  Yao Qi  <yao.qi@linaro.org>
5263
5264         * ia64-libunwind-tdep.c (libunwind_get_reg_special): Change
5265         parameter type to readable_regcache.
5266         * ia64-libunwind-tdep.h (libunwind_get_reg_special): Update
5267         the declaration.
5268
5269 2018-03-11  Tom Tromey  <tom@tromey.com>
5270
5271         * dwarf2read.c (struct nextfield): Add initializers.
5272         (struct nextfnfield): Remove.
5273         (struct fnfieldlist): Add initializers.  Remove "length" and
5274         "head", use std::vector.
5275         (struct decl_field_list): Remove.
5276         (struct field_info): Add initializers.
5277         <fields, baseclasses>: Now std::vector.
5278         <nbaseclasses, nfnfields, typedef_field_list_count,
5279         nested_types_list_count>: Remove.
5280         (dwarf2_add_field, dwarf2_add_type_defn)
5281         (dwarf2_attach_fields_to_type, dwarf2_add_member_fn)
5282         (dwarf2_attach_fn_fields_to_type, handle_struct_member_die)
5283         (process_structure_scope): Update.
5284
5285 2018-03-11  Tom Tromey  <tom@tromey.com>
5286
5287         * dwarf2read.c (sort_tu_by_abbrev_offset): Change to be suitable
5288         for use by std::sort.
5289         (build_type_psymtabs_1): Use std::vector.
5290
5291 2018-03-09  Eli Zaretskii  <eliz@gnu.org>
5292
5293         * top.c (print_gdb_configuration): Reflect LIBIPT, LIBMEMCHECK,
5294         and LIBMPFR in the printed configuration.
5295
5296 2018-03-08  Tom Tromey  <tom@tromey.com>
5297
5298         * source.c (get_filename_and_charpos): Use scoped_fd.
5299         * nto-procfs.c (procfs_open_1): Use scoped_fd.
5300         (procfs_pidlist): Likewise.
5301         * procfs.c (proc_get_LDT_entry): Use scoped_fd.
5302         (iterate_over_mappings): Likewise.
5303
5304 2018-03-08  Tom Tromey  <tom@tromey.com>
5305
5306         * infcall.c (struct call_return_meta_info)
5307         <stack_temporaries_enabled>: Remove.
5308         (get_call_return_value, call_function_by_hand_dummy): Update.
5309         * thread.c (disable_thread_stack_temporaries): Remove.
5310         (enable_thread_stack_temporaries): Remove.
5311         (thread_stack_temporaries_enabled_p): Return bool.
5312         (push_thread_stack_temporary, value_in_thread_stack_temporaries)
5313         (get_last_thread_stack_temporary): Update.
5314         * eval.c (evaluate_subexp): Update.
5315         * gdbthread.h (class enable_thread_stack_temporaries): Now a
5316         class, not a function.
5317         (value_ptr, value_vec): Remove typedefs.
5318         (class thread_info) <stack_temporaries_enabled>: Now bool.
5319         <stack_temporaries>: Now a std::vector.
5320         (thread_stack_temporaries_enabled_p)
5321         (value_in_thread_stack_temporaries): Return bool.
5322
5323 2018-03-08  Simon Marchi  <simon.marchi@ericsson.com>
5324
5325         * remote.c (putpkt_binary): Fix omitted bytes reporting.
5326         (getpkt_or_notif_sane_1): Likewise.
5327
5328 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
5329
5330         * build-id.c (build_id_to_debug_bfd): Use std::string.
5331
5332 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
5333
5334         * build-id.c (find_separate_debug_file_by_buildid): Return
5335         std::string.
5336         * build-id.h (find_separate_debug_file_by_buildid): Return
5337         std::string.
5338         * coffread.c (coff_symfile_read): Adjust to std::string.
5339         * elfread.c (elf_symfile_read): Adjust to std::string.
5340         * symfile.c (separate_debug_file_exists): Change parameter to
5341         std::string.
5342         (find_separate_debug_file): Return std::string.
5343         (find_separate_debug_file_by_debuglink): Return std::string.
5344         * symfile.h (find_separate_debug_file_by_debuglink): Return
5345         std::string.
5346
5347 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
5348
5349         * common/xml-utils.c (xml_escape_text): Move code to...
5350         (xml_escape_text_append): ... this new function.
5351         * common/xml-utils.h (xml_escape_text_append): New declaration.
5352         * unittests/xml-utils-selftests.c (test_xml_escape_text_append):
5353         New function.
5354         (_initialize_xml_utils): register test_xml_escape_text_append as
5355         a selftest.
5356
5357 2018-03-07  Alan Hayward  <alan.hayward@arm.com>
5358
5359         * defs.h: Remove MAX_REGISTER_SIZE.
5360         * regcache.c (init_regcache_descr): Remove MAX_REGISTER_SIZE
5361         asserts.
5362         * python/py-unwind.c (pyuw_sniffer): Likewise.
5363
5364 2018-03-07  Tom Tromey  <tom@tromey.com>
5365
5366         * linux-tdep.c (linux_info_proc): Update.
5367         * target.h (struct target_ops) <to_fileio_readlink>: Return
5368         optional<string>.
5369         (target_fileio_readlink): Return optional<string>.
5370         * remote.c (remote_hostio_readlink): Return optional<string>.
5371         * inf-child.c (inf_child_fileio_readlink): Return
5372         optional<string>.
5373         * target.c (target_fileio_readlink): Return optional<string>.
5374
5375 2018-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5376
5377         * regcache.c (cooked_read_test): Add riscv to the list of
5378         architectures that have a save_reggroup.
5379
5380 2018-03-07  Andreas Arnez  <arnez@linux.vnet.ibm.com>
5381
5382         * gnu-v3-abi.c (gnuv3_rtti_type): Add early exit if the given
5383         value is not a dynamic class object.
5384
5385 2018-03-06  Tom Tromey  <tom@tromey.com>
5386
5387         * rust-exp.y: Formatting fixes.
5388
5389 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5390
5391         * riscv-tdep.c (riscv_register_name): Remove target description
5392         support.
5393         (riscv_gdbarch_init): Remove target description check.
5394
5395 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5396
5397         * riscv-tdep.c: Remove 'Contributed by ...' lines from header
5398         comment.
5399         * riscv-tdep.h: Likewise.
5400
5401 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5402
5403         * riscv-tdep.c (riscv_pseudo_register_read): Delete.
5404         (riscv_pseudo_register_write): Delete.
5405         (riscv_gdbarch_init): Remove all use of pseudo registers.
5406
5407 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
5408
5409         * record-btrace.c (btrace_print_lines): Replace cleanup
5410         parameter with RAII equivalents.
5411         (btrace_insn_history): Replace cleanup with RAII equivalents.
5412         * ui-out.h (make_cleanup_ui_out_list_begin_end,
5413         make_cleanup_ui_out_tuple_begin_end): Remove.
5414         * ui-out.c (struct ui_out_end_cleanup_data, do_cleanup_end,
5415         make_cleanup_ui_out_end, make_cleanup_ui_out_tuple_begin_end,
5416         make_cleanup_ui_out_list_begin_end): Remove.
5417
5418 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
5419
5420         * record-btrace.c (record_btrace_maybe_mark_async_event): Change
5421         parameter types to std::vector.  Use bool.
5422         (record_btrace_wait): Replace VEC(tp_t) with
5423         std::vector<thread_info *>.
5424         * common/gdb_vecs.h (unordered_remove, ordered_remove): New.
5425
5426 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
5427
5428         * record-btrace.c (record_btrace_disable_callback): Remove.
5429         (struct scoped_btrace_disable): New.
5430         (record_btrace_open): Use scoped_btrace_disable.
5431
5432 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5433
5434         * riscv-tdep.c (riscv_return_value): Change type to ULONGEST for
5435         reading values from registers.
5436
5437 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5438
5439         * riscv-tdep.c (riscv_push_dummy_call): Use core_addr_to_string_nz
5440         where appropriate.
5441
5442 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5443
5444         * riscv-tdep.c (riscv_print_arg_location): Add header comment,
5445         change parameter type.  Use GDB's print functions, and use
5446         core_addr_to_string where appropriate.
5447         (riscv_push_dummy_call): Use core_addr_to_string where
5448         appropriate, update call to riscv_print_arg_location, and reindent
5449         a few lines.
5450         (riscv_return_value): Update call to riscv_print_arg_location.
5451
5452 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5453             Tim Newsome <tim@sifive.com>
5454             Albert Ou <a0u@eecs.berkeley.edu>
5455             Darius Rad <darius@bluespec.com>
5456
5457         * Makefile.in (ALL_TARGET_OBS): Add riscv-tdep.o
5458         (HFILES_NO_SRCDIR): Add riscv-tdep.h.
5459         (ALLDEPFILES): Add riscv-tdep.c
5460         * configure.tgt: Add riscv support.
5461         * riscv-tdep.c: New file.
5462         * riscv-tdep.h: New file.
5463         * NEWS: Mention new target.
5464         * MAINTAINERS: Add entry for riscv.
5465
5466 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5467
5468         * amd64-tdep.c (amd64_classify_aggregate): Ignore zero sized
5469         fields within aggregates.
5470
5471 2018-03-04  Simon Marchi  <simon.marchi@polymtl.ca>
5472
5473         * record-btrace.c (btrace_print_lines): Change type of flags to
5474         gdb_disassembly_flags.
5475
5476 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
5477
5478         * fbsd-nat.c: Include "inf-ptrace.h".
5479         (USE_SIGTRAP_SIGINFO): Conditionally define.
5480         [USE_SIGTRAP_SIGINFO] (fbsd_handle_debug_trap): New function.
5481         (fbsd_wait) [USE_SIGTRAP_SIGINFO]: Call "fbsd_handle_debug_trap".
5482         [USE_SIGTRAP_SIGINFO] (fbsd_stopped_by_sw_breakpoint): New
5483         function.
5484         [USE_SIGTRAP_SIGINFO] (fbsd_supports_stopped_by_sw_breakpoint):
5485         Likewise.
5486         [USE_SIGTRAP_SIGINFO] (fbsd_supports_stopped_by_hw_breakpoint):
5487         Likewise.
5488         (fbsd_nat_add_target) [USE_SIGTRAP_SIGINFO]: Set
5489         "stopped_by_sw_breakpoint", "supports_stopped_by_sw_breakpoint",
5490         "supports_stopped_by_hw_breakpoint" target methods.
5491
5492 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
5493
5494         * NEWS (Changes since GDB 8.1): Add "set/show debug fbsd-nat".
5495         * fbsd-nat.c (debug_fbsd_nat): New variable.
5496         (show_fbsd_nat_debug): New function.
5497         (fbsd_wait): Log LWP info if "debug_fbsd_nat" is enabled.
5498         (_initialize_fbsd_nat): Add "fbsd-nat" debug boolean command.
5499
5500 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
5501
5502         * nat/x86-dregs.c (x86_dr_stopped_by_hw_breakpoint): New function.
5503         * nat/x86-dregs.h (x86_dr_stopped_by_hw_breakpoint): New
5504         prototype.
5505         * x86-nat.c (x86_stopped_by_hw_breakpoint): New function.
5506         (x86_use_watchpoints): Set "stopped_by_hw_breakpoint" target
5507         method.
5508
5509 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
5510
5511         * common/gdb_vecs.c (free_char_ptr_vec): Remove.
5512         * common/gdb_vecs.h (free_char_ptr_vec): Remove.
5513
5514 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
5515
5516         * charset.c (struct charset_vector): New.
5517         (charsets): Change type to charset_vector.
5518         (find_charset_names): Adjust.
5519         (add_one): Adjust.
5520         (_initialize_charset): Adjust.
5521
5522 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
5523
5524         * progspace.h (struct program_space) <deleted_solibs>: Change
5525         type to std::vector<std::string>.
5526         * progspace.c (clear_program_space_solib_cache): Adjust.
5527         * breakpoint.c (print_solib_event): Adjust.
5528         (check_status_catch_solib): Adjust.
5529         * solib.c (update_solib_list): Adjust.
5530         * ui-out.h (class ui_out) <field_string>: New overload.
5531         * ui-out.c (ui_out::field_string): New overload.
5532
5533 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
5534
5535         * progspace.h (struct program_space): Add constructor and
5536         destructor, initialize fields.
5537         (add_program_space): Remove.
5538         * progspace.c (add_program_space): Rename to...
5539         (program_space::program_space): ... this.
5540         (release_program_space): Rename to...
5541         (program_space::~program_space): ... this.
5542         (delete_program_space): Use delete to delete program_space.
5543         (initialize_progspace): Use new to allocate program_space.
5544         * inferior.c (add_inferior_with_spaces): Likewise.
5545         (clone_inferior_command): Likewise.
5546         * infrun.c (follow_fork_inferior): Likewise.
5547         (handle_vfork_child_exec_or_exit): Likewise.
5548
5549 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
5550
5551         * common/gdb_vecs.h (make_cleanup_free_char_ptr_vec): Remove.
5552         (delim_string_to_char_ptr_vec): Return std::vector of
5553         gdb::unique_xmalloc_ptr.
5554         (dirnames_to_char_ptr_vec_append): Take std::vector of
5555         gdb::unique_xmalloc_ptr.
5556         (dirnames_to_char_ptr_vec): Return std::vector of
5557         gdb::unique_xmalloc_ptr.
5558         * common/gdb_vecs.c (delim_string_to_char_ptr_vec_append):
5559         Take std::vector of gdb::unique_xmalloc_ptr, adjust the code.
5560         (delim_string_to_char_ptr_vec): Return an std::vector of
5561         gdb::unique_xmalloc_ptr, adjust the code.
5562         (dirnames_to_char_ptr_vec_append): Take an std::vector of
5563         gdb::unique_xmalloc_ptr, adjust the code.
5564         (dirnames_to_char_ptr_vec): Return an std::vector of
5565         gdb::unique_xmalloc_ptr, adjust the code.
5566         * auto-load.c (auto_load_safe_path_vec): Change type to
5567         std::vector of gdb::unique_xmalloc_ptr.
5568         (auto_load_expand_dir_vars): Return an std::vector of
5569         gdb::unique_xmalloc_ptr, adjust the code.
5570         (auto_load_safe_path_vec_update): Adjust.
5571         (filename_is_in_auto_load_safe_path_vec): Adjust.
5572         (auto_load_objfile_script_1): Adjust.
5573         * build-id.c (build_id_to_debug_bfd): Adjust.
5574         * linux-thread-db.c (thread_db_load_search): Adjust.
5575         * source.c (add_path): Adjust.
5576         (openp): Adjust.
5577         * symfile.c (find_separate_debug_file): Adjust.
5578         * utils.c (do_free_char_ptr_vec): Remove.
5579         (make_cleanup_free_char_ptr_vec): Remove.
5580
5581 2018-03-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5582
5583         PR gdb/22907
5584         * common/pathstuff.c: Conditionally include "<windows.h>".
5585
5586 2018-03-01  Georg Sauthoff  <mail@georg.so>
5587
5588         PR gdb/22888
5589         * gcore.in: Quote variables and switch interpreter to bash.
5590
5591 2018-03-01  Tom Tromey  <tom@tromey.com>
5592
5593         * dwarf2read.c (alloc_discriminant_info): Fix default_index
5594         assertion.  Add assertion for discriminant_index.
5595         (quirk_rust_enum): Use correct base type name in univariant case.
5596
5597 2018-03-01  Simon Marchi  <simon.marchi@ericsson.com>
5598
5599         * record.c (get_call_history_modifiers): Return a
5600         record_print_flags.
5601         (cmd_record_call_history): Adjust.
5602         * record-btrace.c (record_btrace_call_history): Adjust.
5603         (record_btrace_call_history_range): Adjust.
5604         (record_btrace_call_history_from): Adjust.
5605         * target-debug.h (target_debug_print_record_print_flags): New.
5606         * target-delegates.c: Re-generate.
5607         * target.c (target_call_history): Change flags type.
5608         (target_call_history_from): Likewise.
5609         (target_call_history_range): Likewise.
5610         * target.h (struct target_ops) <target_call_history>: Likewise.
5611         (target_call_history_from): Likewise.
5612         (target_call_history_range): Likewise.
5613
5614 2018-02-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5615             Simon Marchi  <simon.marchi@polymtl.ca>
5616
5617         * common/common-utils.c: Include "sys/stat.h".
5618         (is_regular_file): Move here from "source.c"; change return
5619         type to "bool".
5620         * common/common-utils.h (is_regular_file): New prototype.
5621         * common/pathstuff.c (contains_dir_separator): New function.
5622         * common/pathstuff.h (contains_dir_separator): New prototype.
5623         * source.c: Don't include "sys/stat.h".
5624         (is_regular_file): Move to "common/common-utils.c".
5625
5626 2018-02-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5627
5628         * Makefile.in (COMMON_SFILES): Add "common/pathstuff.c".
5629         (HFILES_NO_SRCDIR): Add "common/pathstuff.h".
5630         * auto-load.c: Include "common/pathstuff.h".
5631         * common/common-def.h (current_directory): Move here.
5632         * common/gdb_tilde_expand.c (gdb_tilde_expand_up): New
5633         function.
5634         * common/gdb_tilde_expand.h (gdb_tilde_expand_up): New
5635         prototype.
5636         * common/pathstuff.c: New file.
5637         * common/pathstuff.h: New file.
5638         * compile/compile.c: Include "common/pathstuff.h".
5639         * defs.h (current_directory): Move to "common/common-defs.h".
5640         * dwarf2read.c: Include "common/pathstuff.h".
5641         * exec.c: Likewise.
5642         * guile/scm-safe-call.c: Likewise.
5643         * linux-thread-db.c: Likewise.
5644         * main.c: Likewise.
5645         * nto-tdep.c: Likewise.
5646         * objfiles.c: Likewise.
5647         * source.c: Likewise.
5648         * symtab.c: Likewise.
5649         * utils.c: Include "common/pathstuff.h".
5650         (gdb_realpath): Move to "common/pathstuff.c".
5651         (gdb_realpath_keepfile): Likewise.
5652         (gdb_abspath): Likewise.
5653         * utils.h (gdb_realpath): Move to "common/pathstuff.h".
5654         (gdb_realpath_keepfile): Likewise.
5655         (gdb_abspath): Likewise.
5656
5657 2018-02-28  John Baldwin  <jhb@FreeBSD.org>
5658
5659         * fbsd-nat.c (fbsd_resume): Use PT_SETSTEP for stepping and a
5660         wildcard process pid for super_resume for kernels with a
5661         specific bug.
5662
5663 2018-02-27  Phil Muldoon  <pmuldoon@redhat.com>
5664
5665         * compile/compile.c (get_args): Add additional comments
5666         explaining function.
5667
5668 2018-02-27  Simon Marchi  <simon.marchi@polymtl.ca>
5669             Tom Tromey  <tom@tromey.com>
5670
5671         * target.h (memory_write_request_s): Remove typedef.  Don't define
5672         VEC.
5673         (target_write_memory_blocks): Change argument to std::vector.
5674         (struct memory_write_request): Add constructor.
5675         * target-memory.c (compare_block_starting_address): Return bool.
5676         Change argument types.
5677         (claim_memory): Change arguments to use std::vector.
5678         (split_regular_and_flash_blocks, blocks_to_erase)
5679         (compute_garbled_blocks): Likewise.
5680         (cleanup_request_data, cleanup_write_requests_vector): Remove.
5681         (target_write_memory_blocks): Change argument to std::vector.
5682         * symfile.c (struct load_section_data): Add constructor and
5683         destructor.  Use std::vector for "requests".
5684         (struct load_progress_data): Add initializers.
5685         (load_section_callback): Update.  Use "new".
5686         (clear_memory_write_data): Remove.
5687         (generic_load): Update.
5688
5689 2018-02-27  Alan Hayward  <alan.hayward@arm.com>
5690
5691         * arch/aarch64.h: Use common/tdesc.h.
5692
5693 2018-02-26  Maciej W. Rozycki  <macro@mips.com>
5694
5695         * mips-tdep.c (mips_gdbarch_init): Don't use a 32-bit BFD
5696         architecture with a 64-bit ABI.
5697
5698 2018-02-26  Maciej W. Rozycki  <macro@mips.com>
5699
5700         * gdb/mips-tdep.c (mips_gdbarch_init): Reorder ABI determination
5701         ahead of target description loading.
5702
5703 2018-02-26  Tom Tromey  <tom@tromey.com>
5704
5705         * stack.c (backtrace_command_1): Update.
5706         * python/python-internal.h (gdbpy_apply_frame_filter): Change type
5707         of "flags".
5708         * python/py-framefilter.c (py_print_frame)
5709         (gdbpy_apply_frame_filter): Change type of "flags".
5710         * mi/mi-cmd-stack.c (mi_apply_ext_lang_frame_filter): Change type
5711         of "flags".
5712         (mi_cmd_stack_list_frames, mi_cmd_stack_list_locals)
5713         (mi_cmd_stack_list_args, mi_cmd_stack_list_variables): Update.
5714         * extension.h (enum frame_filter_flag): Rename from
5715         frame_filter_flags.
5716         (frame_filter_flags): Define using DEF_ENUM_FLAGS_TYPE.
5717         (apply_ext_lang_frame_filter): Change type of "flags".
5718         * extension.c (apply_ext_lang_frame_filter): Change type of
5719         "flags".
5720         * extension-priv.h (struct extension_language_ops)
5721         <apply_frame_filter>: Change type of "flags".
5722
5723 2018-02-26  Tom Tromey  <tom@tromey.com>
5724
5725         PR python/16497:
5726         * stack.c (backtrace_command_1): Set PRINT_MORE_FRAMES flag.  Fix
5727         off-by-one in py_end computation.
5728         * python/py-framefilter.c (gdbpy_apply_frame_filter): Handle
5729         PRINT_MORE_FRAMES.
5730         * extension.h (enum frame_filter_flags) <PRINT_MORE_FRAMES>: New
5731         constant.
5732
5733 2018-02-26  Tom Tromey  <tom@tromey.com>
5734
5735         * dwarf2read.c (struct variant_field): New.
5736         (struct nextfield) <variant>: New field.
5737         (dwarf2_add_field): Handle DW_TAG_variant_part.
5738         (dwarf2_attach_fields_to_type): Attach a discriminant_info to a
5739         discriminated union.
5740         (read_structure_type): Handle DW_TAG_variant_part.
5741         (handle_struct_member_die): New function, extracted from
5742         process_structure_scope.  Handle DW_TAG_variant.
5743         (process_structure_scope): Handle discriminated unions.  Call
5744         handle_struct_member_die.
5745
5746 2018-02-26  Tom Tromey  <tom@tromey.com>
5747
5748         * rust-lang.h (rust_last_path_segment): Declare.
5749         * rust-lang.c (rust_last_path_segment): Now public.  Change
5750         contract.
5751         (struct disr_info): Remove.
5752         (RUST_ENUM_PREFIX, RUST_ENCODED_ENUM_REAL)
5753         (RUST_ENCODED_ENUM_HIDDEN, rust_union_is_untagged)
5754         (rust_get_disr_info, rust_tuple_variant_type_p): Remove.
5755         (rust_enum_p, rust_enum_variant): New function.
5756         (rust_underscore_fields): Remove "offset" parameter.
5757         (rust_print_enum): New function.
5758         (rust_val_print) <TYPE_CODE_UNION>: Remove enum code.
5759         <TYPE_CODE_STRUCT>: Call rust_print_enum when appropriate.
5760         (rust_print_struct_def): Add "for_rust_enum" parameter.  Handle
5761         enums.
5762         (rust_internal_print_type): New function, from rust_print_type.
5763         Remove enum code.
5764         (rust_print_type): Call rust_internal_print_type.
5765         (rust_evaluate_subexp) <STRUCTOP_ANONYMOUS, STRUCTOP_STRUCT>:
5766         Update enum handling.
5767         * dwarf2read.c (struct dwarf2_cu) <rust_unions>: New field.
5768         (rust_fully_qualify, alloc_discriminant_info, quirk_rust_enum)
5769         (rust_union_quirks): New functions.
5770         (process_full_comp_unit, process_full_type_unit): Call
5771         rust_union_quirks.
5772         (process_structure_scope): Update rust_unions if necessary.
5773
5774 2018-02-26  Tom Tromey  <tom@tromey.com>
5775
5776         * value.h (value_union_variant): Declare.
5777         * valops.c (value_union_variant): New function.
5778         * gdbtypes.h (TYPE_FLAG_DISCRIMINATED_UNION): New macro.
5779         (struct discriminant_info): New.
5780         (enum dynamic_prop_node_kind) <DYN_PROP_DISCRIMINATED>: New
5781         enumerator.
5782         (struct main_type) <flag_discriminated_union>: New field.
5783
5784 2018-02-26  Tom Tromey  <tom@tromey.com>
5785
5786         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5787         unittests/unpack-selftests.c.
5788         * unittests/unpack-selftests.c: New file.
5789         * value.c (unpack_bits_as_long): Fix bugs in non-bitfield cases.
5790
5791 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5792
5793         * dwarf2read.c (struct partial_die_info) <read>: New method.
5794         (read_partial_die): Remove the declaration.
5795         (load_partial_dies): Update.
5796         (partial_die_info::partial_die_info):
5797         (read_partial_die): Change it to partial_die_info::read.
5798
5799 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5800
5801         * dwarf2read.c (struct partial_die_info) <fixup>: New method.
5802         (fixup_partial_die): Remove declaration.
5803         (scan_partial_symbols): Update.
5804         (partial_die_parent_scope): Likewise.
5805         (partial_die_full_name): Likewise.
5806         (fixup_partial_die): Change it to partial_die_info::fixup.
5807
5808 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5809
5810         * dwarf2read.c (read_partial_die): Update the declaration.
5811         (load_partial_dies): Caller update.
5812         (read_partial_die): Remove one argument abbrev_len.
5813
5814 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5815
5816         * dwarf2read.c (struct partial_die_info): Add ctor, delete
5817         assignment operator.
5818         (load_partial_dies): Use ctor and copy ctor.
5819         (read_partial_die): Update.
5820         (dwarf2_cu::find_partial_die): Use ctor.
5821
5822 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5823
5824         * dwarf2read.c (struct dwarf2_cu) <find_partial_die>: New method.
5825         (find_partial_die_in_comp_unit): Change it to
5826         dwarf2_cu::find_partial_die.
5827         (find_partial_die): Update.
5828
5829 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5830
5831         * dwarf2read.c (read_partial_die): Remove the code checking abbrev
5832         is NULL.
5833
5834 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5835
5836         * dwarf2read.c (load_partial_dies): Move the location of XOBNEW.
5837
5838 2018-02-26  Alan Hayward  <alan.hayward@arm.com>
5839
5840         * arch/amd64.h: Use common/tdesc.h.
5841         * arch/i386.c: Likewise.
5842         * arch/i386.h: Likewise.
5843         * arch/tic6x.c: Likewise.
5844         * arch/tdesc.h: Move file from here...
5845         * common/tdesc.h: ...to here.
5846         * features/aarch64-core.c: Regenerate.
5847         * features/aarch64-fpu.c: Regenerate.
5848         * features/i386/32bit-avx.c: Regenerate.
5849         * features/i386/32bit-avx512.c: Regenerate.
5850         * features/i386/32bit-core.c: Regenerate.
5851         * features/i386/32bit-linux.c: Regenerate.
5852         * features/i386/32bit-mpx.c: Regenerate.
5853         * features/i386/32bit-pkeys.c: Regenerate.
5854         * features/i386/32bit-sse.c: Regenerate.
5855         * features/i386/64bit-avx.c: Regenerate.
5856         * features/i386/64bit-avx512.c: Regenerate.
5857         * features/i386/64bit-core.c: Regenerate.
5858         * features/i386/64bit-linux.c: Regenerate.
5859         * features/i386/64bit-mpx.c: Regenerate.
5860         * features/i386/64bit-pkeys.c: Regenerate.
5861         * features/i386/64bit-segments.c: Regenerate.
5862         * features/i386/64bit-sse.c: Regenerate.
5863         * features/i386/x32-core.c: Regenerate.
5864         * features/tic6x-c6xp.c: Regenerate.
5865         * features/tic6x-core.c: Regenerate.
5866         * features/tic6x-gp.c: Regenerate.
5867         * target-descriptions.c: Use common/tdesc.h.
5868         * target-descriptions.h: Likewise.
5869
5870 2018-02-24  Tom Tromey  <tom@tromey.com>
5871
5872         * linux-thread-db.c (try_thread_db_load_from_pdir_1)
5873         (try_thread_db_load_from_dir, thread_db_load_search): Use
5874         std::string.
5875         (info_auto_load_libthread_db_compare): Return bool.  Change
5876         argument types.
5877         (info_auto_load_libthread_db): Use std::vector, std::string.
5878         Remove cleanups.
5879
5880 2018-02-24  Tom Tromey  <tom@tromey.com>
5881
5882         * i386-tdep.c (i386_fast_tracepoint_valid_at): "msg" now a
5883         std::string.
5884         * gdbarch.sh (fast_tracepoint_valid_at): Change "msg" to a
5885         std::string*.
5886         * gdbarch.c: Rebuild.
5887         * gdbarch.h: Rebuild.
5888         * breakpoint.c (check_fast_tracepoint_sals): Use std::string.
5889         * arch-utils.h (default_fast_tracepoint_valid_at): Update.
5890         * arch-utils.c (default_fast_tracepoint_valid_at): "msg" now a
5891         std::string*.
5892
5893 2018-02-23  Simon Marchi  <simon.marchi@polymtl.ca>
5894
5895         * gdbtypes.h (sect_offset): Change type to uint64_t.
5896         (sect_offset_str): New function.
5897         * dwarf2read.c (create_addrmap_from_aranges): Use
5898         sect_offset_str.
5899         (error_check_comp_unit_head): Likewise.
5900         (create_debug_type_hash_table): Likewise.
5901         (read_cutu_die_from_dwo): Likewise.
5902         (init_cutu_and_read_dies): Likewise.
5903         (init_cutu_and_read_dies_no_follow): Likewise.
5904         (process_psymtab_comp_unit_reader): Likewise.
5905         (partial_die_parent_scope): Likewise.
5906         (peek_die_abbrev): Likewise.
5907         (process_queue): Likewise.
5908         (dwarf2_physname): Likewise.
5909         (read_namespace_alias): Likewise.
5910         (read_import_statement): Likewise.
5911         (create_dwo_cu_reader): Likewise.
5912         (create_cus_hash_table): Likewise.
5913         (lookup_dwo_cutu): Likewise.
5914         (inherit_abstract_dies): Likewise.
5915         (read_func_scope): Likewise.
5916         (read_call_site_scope): Likewise.
5917         (dwarf2_add_member_fn): Likewise.
5918         (read_common_block): Likewise.
5919         (read_module_type): Likewise.
5920         (read_typedef): Likewise.
5921         (read_subrange_type): Likewise.
5922         (load_partial_dies): Likewise.
5923         (read_partial_die): Likewise.
5924         (find_partial_die): Likewise.
5925         (read_str_index): Likewise.
5926         (dwarf2_string_attr): Likewise.
5927         (build_error_marker_type): Likewise.
5928         (lookup_die_type): Likewise.
5929         (dump_die_shallow): Likewise.
5930         (follow_die_ref): Likewise.
5931         (dwarf2_fetch_die_loc_sect_off): Likewise.
5932         (dwarf2_fetch_constant_bytes): Likewise.
5933         (follow_die_sig): Likewise.
5934         (get_signatured_type): Likewise.
5935         (get_DW_AT_signature_type): Likewise.
5936         (dwarf2_find_containing_comp_unit): Likewise.
5937         (set_die_type): Likewise.
5938
5939 2018-02-21  John Baldwin  <jhb@FreeBSD.org>
5940
5941         * arch/aarch64.c: Include "common-defs.h".
5942         * arch/amd64.c: Likewise.
5943         * arch/i386.c: Likewise.
5944
5945 2018-02-21  Tom Tromey  <tom@tromey.com>
5946
5947         * value.h: (extract_field_op): Update.
5948         * eval.c (extract_field_op): Return a const char *.
5949         * expression.h (parse_expression_for_completion): Update.
5950         * completer.c (complete_expression): Update.
5951         (add_struct_fields): Make fieldname const.
5952         * parse.c (expout_completion_name): Now a unique_xmalloc_ptr.
5953         (mark_completion_tag, parse_exp_in_context_1): Update.
5954         (parse_expression_for_completion): Change "name" to
5955         unique_xmalloc_ptr*.
5956
5957 2018-02-21  Tom Tromey  <tom@tromey.com>
5958
5959         * infcall.c (call_function_by_hand_dummy): Use std::vector.
5960
5961 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5962
5963         * avr-tdep.c (avr_read_pc): Change parameter type to
5964         readable_regcache.
5965         * gdbarch.sh (read_pc): Likewise.
5966         * gdbarch.c: Re-generated.
5967         * gdbarch.h: Re-generated.
5968         * hppa-tdep.c (hppa_read_pc): Change parameter type to
5969         readable_regcache.
5970         * ia64-tdep.c (ia64_read_pc): Likewise.
5971         * mips-tdep.c (mips_read_pc): Likewise.
5972         * spu-tdep.c (spu_read_pc): Likewise.
5973
5974 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5975
5976         * Makefile.in (COMMON_SFILES): Add regcache-dump.c
5977         * regcache-dump.c: New file.
5978         * regcache.c: Move register_dump to regcache-dump.c.
5979         (maintenance_print_registers): Likewise.
5980         (maintenance_print_raw_registers): Likewise.
5981         (maintenance_print_cooked_registers): Likewise.
5982         (maintenance_print_register_groups): Likewise.
5983         (maintenance_print_remote_registers): Likewise.
5984         (_initialize_regcache): Likewise.
5985         * regcache.h (register_dump): Moved from regcache.c.
5986
5987 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5988
5989         * regcache.c (regcache::regcache): Update.
5990         (regcache::invalidate): Move it to detached_regcache::invalidate.
5991         (get_thread_arch_aspace_regcache): Update.
5992         (regcache::raw_update): Update.
5993         (regcache::cooked_read): Remove some code.
5994         (regcache::cooked_read_value): Likewise.
5995         (regcache::raw_write): Remove assert on m_readonly_p.
5996         (regcache::raw_supply_integer): Move it to
5997         detached_regcache::raw_supply_integer.
5998         (regcache::raw_supply_zeroed): Likewise.
5999         * regcache.h (detached_regcache) <raw_supply_integer>: New
6000         declaration.
6001         <raw_supply_zeroed, invalidate>: Likewise.
6002         (regcache) <raw_supply_integer, raw_supply_zeroed>: Removed.
6003         <invalidate>: Likewise.
6004         <m_readonly_p>: Removed.
6005
6006 2018-02-21  Yao Qi  <yao.qi@linaro.org>
6007
6008         * infcmd.c (get_return_value): Let stop_regs point to
6009         get_current_regcache.
6010         * regcache.c (regcache::regcache): Remove.
6011         (register_dump_reg_buffer): New class.
6012         (regcache_print): Adjust.
6013         * regcache.h (regcache): Remove constructors.
6014
6015 2018-02-21  Yao Qi  <yao.qi@linaro.org>
6016
6017         * regcache.c (class register_dump): New class.
6018         (register_dump_regcache, register_dump_none): New class.
6019         (register_dump_remote, register_dump_groups): New class.
6020         (regcache_print): Update.
6021         * regcache.h (regcache_dump_what): Move it to regcache.c.
6022         (regcache) <dump>: Remove.
6023
6024 2018-02-21  Yao Qi  <yao.qi@linaro.org>
6025
6026         * jit.c (struct jit_unwind_private) <regcache>: Change its type to
6027          reg_buffer_rw *.
6028         (jit_unwind_reg_set_impl): Call raw_supply.
6029         (jit_frame_sniffer): Use reg_buffer_rw.
6030         * record-full.c (record_full_core_regbuf): Change its type.
6031         (record_full_core_open_1): Use reg_buffer_rw.
6032         (record_full_close): Likewise.
6033         (record_full_core_fetch_registers): Use regcache->raw_supply.
6034         (record_full_core_store_registers): Likewise.
6035         * regcache.c (regcache::get_register_status): Move it to
6036         reg_buffer.
6037         (regcache_raw_set_cached_value): Remove.
6038         (regcache::raw_set_cached_value): Remove.
6039         (regcache::raw_write): Call raw_supply.
6040         (regcache::raw_supply): Move it to reg_buffer_rw.
6041         * regcache.h (regcache_raw_set_cached_value): Remove.
6042         (reg_buffer_rw): New class.
6043
6044 2018-02-21  Yao Qi  <yao.qi@linaro.org>
6045
6046         * dummy-frame.c (dummy_frame_cache) <prev_regcache>: Use
6047         readonly_detached_regcache.
6048         (dummy_frame_prev_register): Use regcache->cooked_read.
6049         * frame.c (frame_save_as_regcache): Change return type.
6050         (frame_pop): Update.
6051         * frame.h (frame_save_as_regcache): Update declaration.
6052         * inferior.h (get_infcall_suspend_state_regcache): Update
6053         declaration.
6054         * infrun.c (infcall_suspend_state) <registers>: use
6055         readonly_detached_regcache.
6056         (save_infcall_suspend_state): Don't use regcache_dup.
6057         (get_infcall_suspend_state_regcache): Change return type.
6058         * linux-fork.c (struct fork_info) <savedregs>: Change to
6059         readonly_detached_regcache.
6060         <pc>: New field.
6061         (fork_save_infrun_state): Don't use regcache_dup.
6062         (info_checkpoints_command): Adjust.
6063         * mi/mi-main.c (register_changed_p): Update declaration.
6064         (mi_cmd_data_list_changed_registers): Use
6065         readonly_detached_regcache.
6066         (register_changed_p): Change parameter type to
6067         readonly_detached_regcache.
6068         * ppc-linux-tdep.c (ppu2spu_cache) <regcache>: Use
6069         readonly_detached_regcache.
6070         (ppu2spu_sniffer): Construct a new readonly_detached_regcache.
6071         * regcache.c (readonly_detached_regcache::readonly_detached_regcache):
6072         New.
6073         (regcache::save): Move it to reg_buffer.
6074         (regcache::restore): Change parameter type.
6075         (regcache_dup): Remove.
6076         * regcache.h (reg_buffer) <save>: New method.
6077         (readonly_detached_regcache): New class.
6078         * spu-tdep.c (spu2ppu_cache) <regcache>: Use
6079         readonly_detached_regcache.
6080         (spu2ppu_sniffer): Construct a new readonly_detached_regcache.
6081
6082 2018-02-21  Yao Qi  <yao.qi@linaro.org>
6083
6084         * frame.c (frame_save_as_regcache): Use regcache method save.
6085         (frame_pop): Use regcache method restore.
6086         * infrun.c (restore_infcall_suspend_state): Likewise.
6087         * linux-fork.c (fork_load_infrun_state): Likewise.
6088         * ppc-linux-tdep.c (ppu2spu_sniffer): User regcache method
6089         save.
6090         * regcache.c (regcache_save): Remove.
6091         (regcache::restore): More asserts.
6092         (regcache_cpy): Remove.
6093         * regcache.h (regcache_save): Remove the declaration.
6094         (regcache::restore): Move from private to public.
6095         Remove the friend declaration of regcache_cpy.
6096         (regcache_cpy): Remove declaration.
6097
6098 2018-02-21  Yao Qi  <yao.qi@linaro.org>
6099
6100         * aarch64-tdep.c (aarch64_pseudo_register_read_value): Change
6101         parameter type to 'readable_regcache *'.
6102         * amd64-tdep.c (amd64_pseudo_register_read_value): Likewise.
6103         * arm-tdep.c (arm_neon_quad_read): Likewise.
6104         (arm_pseudo_read): Likewise.
6105         * avr-tdep.c (avr_pseudo_register_read): Likewise.
6106         * bfin-tdep.c (bfin_pseudo_register_read): Likewise.
6107         * frv-tdep.c (frv_pseudo_register_read): Likewise.
6108         * gdbarch.c: Re-generated.
6109         * gdbarch.h: Re-generated.
6110         * gdbarch.sh (pseudo_register_read): Change parameter type to
6111         'readable_regcache *'.
6112         (pseudo_register_read_value): Likewise.
6113         * h8300-tdep.c (pseudo_from_raw_register): Likewise.
6114         (h8300_pseudo_register_read): Likewise.
6115         * hppa-tdep.c (hppa_pseudo_register_read): Likewise.
6116         * i386-tdep.c (i386_mmx_regnum_to_fp_regnum): Likewise.
6117         (i386_pseudo_register_read_into_value): Likewise.
6118         (i386_pseudo_register_read_value): Likewise.
6119         * i386-tdep.h (i386_pseudo_register_read_into_value): Update
6120         declaration.
6121         * ia64-tdep.c (ia64_pseudo_register_read): Likewise.
6122         * m32c-tdep.c (m32c_raw_read): Likewise.
6123         (m32c_read_flg): Likewise.
6124         (m32c_banked_register): Likewise.
6125         (m32c_banked_read): Likewise.
6126         (m32c_sb_read): Likewise.
6127         (m32c_part_read): Likewise.
6128         (m32c_cat_read): Likewise.
6129         (m32c_r3r2r1r0_read): Likewise.
6130         (m32c_pseudo_register_read): Likewise.
6131         * m68hc11-tdep.c (m68hc11_pseudo_register_read): Likewise.
6132         * mep-tdep.c (mep_pseudo_cr32_read): Likewise.
6133         (mep_pseudo_cr64_read): Likewise.
6134         (mep_pseudo_register_read): Likewise.
6135         * mips-tdep.c (mips_pseudo_register_read): Likewise.
6136         * msp430-tdep.c (msp430_pseudo_register_read): Likewise.
6137         * nds32-tdep.c (nds32_pseudo_register_read): Likewise.
6138         * regcache.c (regcache::raw_read): Move it to readable_regcache.
6139         (regcache::cooked_read): Likewise.
6140         (regcache::cooked_read_value): Likewise.
6141         (regcache_cooked_read_signed):
6142         (regcache::cooked_read): Likewise.
6143         * regcache.h (readable_regcache): New class.
6144         (regcache): Inherit readable_regcache.  Move some methods to
6145         readable_regcache.
6146         * rl78-tdep.c (rl78_pseudo_register_read): Change
6147         parameter type to 'readable_regcache *'.
6148         * rs6000-tdep.c (do_regcache_raw_read): Remove.
6149         (e500_pseudo_register_read): Change parameter type to
6150         'readable_regcache *'.
6151         (dfp_pseudo_register_read): Likewise.
6152         (vsx_pseudo_register_read): Likewise.
6153         (efpr_pseudo_register_read): Likewise.
6154         * s390-tdep.c (s390_pseudo_register_read): Likewise.
6155         * sh-tdep.c (sh_pseudo_register_read): Likewise.
6156         * sh64-tdep.c (pseudo_register_read_portions): Likewise.
6157         (sh64_pseudo_register_read): Likewise.
6158         * sparc-tdep.c (sparc32_pseudo_register_read): Likewise.
6159         * sparc64-tdep.c (sparc64_pseudo_register_read): Likewise.
6160         * spu-tdep.c (spu_pseudo_register_read_spu): Likewise.
6161         (spu_pseudo_register_read): Likewise.
6162         * xtensa-tdep.c (xtensa_register_read_masked): Likewise.
6163         (xtensa_pseudo_register_read): Likewise.
6164
6165 2018-02-21  Yao Qi  <yao.qi@linaro.org>
6166
6167         * regcache.c (regcache::regcache): Call reg_buffer ctor.
6168         (regcache::arch): Move it to reg_buffer::arch.
6169         (regcache::register_buffer): Likewise.
6170         (regcache::assert_regnum): Likewise.
6171         (regcache::num_raw_registers): Likewise.
6172         * regcache.h (reg_buffer): New class.
6173         (regcache): Inherit reg_buffer.
6174
6175 2018-02-20  Simon Marchi  <simon.marchi@ericsson.com>
6176
6177         * remote-sim.c (gdb_os_printf_filtered, gdb_os_vprintf_filtered,
6178         gdb_os_evprintf_filtered, gdb_os_error): Add ATTRIBUTE_PRINTF.
6179
6180 2018-02-20  Markus Metzger  <markus.t.metzger@intel.com>
6181
6182         * gnulib/update-gnulib.sh (IMPORTED_GNULIB_MODULES): Add mkstemp.
6183
6184 2018-02-19  Alan Hayward  <alan.hayward@arm.com>
6185
6186         * Makefile.in: (COMMON_SFILES): Add common/*.c files.
6187         (SFILES): Remove common/*.c files.
6188         (COMMON_OBS): Remove some *.o files built from common/*.c files.
6189         * common/common.host: Add common reference.
6190         * configure.ac: Likewise.
6191         * configure: Regenerate.
6192
6193 2018-02-16  Yao Qi  <yao.qi@linaro.org>
6194
6195         * block.c (block_namespace_info): Inherit allocate_on_obstack.
6196         (block_initialize_namespace): Use new.
6197         * dwarf2read.c (dwarf2_per_objfile): Inherit allocate_on_obstack.
6198         (dwarf2_free_objfile): Use delete.
6199         * gdbtypes.c (type_pair): Inherit allocate_on_obstack.
6200         (copy_type_recursive): Use new.
6201         * gdb_obstack.h (allocate_on_obstack): New.
6202
6203 2018-02-15  Yao Qi  <yao.qi@linaro.org>
6204
6205         PR gdb/22849
6206         * inferior.c (exit_inferior_1): Reset inf->control.
6207
6208 2018-02-15  Joel Brobecker  <brobecker@adacore.com>
6209
6210         * ada-lang.c (ada_to_fixed_value_create): Delete advance
6211         declaration.
6212
6213 2018-02-14  Pedro Alves  <palves@redhat.com>
6214
6215         * frame-unwind.c (frame_unwind_try_unwinder): Always call
6216         frame_cleanup_after_sniffer on exception.
6217
6218 2018-02-14  Tom Tromey  <tom@tromey.com>
6219
6220         * solist.h (struct target_so_ops) <bfd_open>: Make pathname
6221         const.
6222         (solib_bfd_open): Make pathname const.
6223         * solib.c (solib_bfd_open): Make pathname const.
6224         * solib-spu.c (spu_bfd_fopen): Make name const.
6225         (spu_bfd_open): Make pathname const.
6226         * solib-darwin.c (darwin_bfd_open): Make pathname const.
6227         * solib-aix.c (solib_aix_bfd_open): Make pathname const.
6228
6229 2018-02-14  Tom Tromey  <tom@tromey.com>
6230
6231         * symfile.c (symfile_bfd_open): Update.
6232         * source.h (openp, source_full_path_of, find_and_open_source):
6233         Change argument type to unique_xmalloc_ptr.
6234         * source.c (openp): Take a unique_xmalloc_ptr.
6235         (source_full_path_of, find_and_open_source): Likewise.
6236         (open_source_file, symtab_to_fullname): Update.
6237         * solist.h (struct target_so_ops) <find_and_open_solib>: Take a
6238         unique_xmalloc_ptr.
6239         * solib.c (solib_find_1): Use unique_xmalloc_ptr.
6240         (exec_file_find): Update.
6241         * psymtab.c (psymtab_to_fullname): Update.
6242         * nto-tdep.h (nto_find_and_open_solib): Update.
6243         * nto-tdep.c (nto_find_and_open_solib): Change temp_path to a
6244         unique_xmalloc_ptr.
6245         * exec.c (exec_file_attach): Update.
6246         * dwarf2read.c (try_open_dwop_file): Use unique_xmalloc_ptr.
6247         * cli/cli-cmds.c (find_and_open_script): Use unique_xmalloc_ptr.
6248
6249 2018-02-14  Tom Tromey  <tom@tromey.com>
6250
6251         * solib.c: Include source.h.
6252         * nto-tdep.c: Include source.h.
6253         * mi/mi-cmd-env.c: Include source.h.
6254         * infcmd.c: Include source.h.
6255         * exec.c: Include source.h.
6256         * defs.h (enum openp_flag, openp, source_full_path_of, mod_path)
6257         (add_path, directory_switch, source_path, init_source_path): Move
6258         declarations...
6259         * source.h (enum openp_flag, openp, source_full_path_of, mod_path)
6260         (add_path, directory_switch, source_path, init_source_path):
6261         ...here.
6262
6263 2018-02-14  Tom Tromey  <tom@tromey.com>
6264
6265         * solist.h (exec_file_find, solib_find): Return
6266         unique_xmalloc_ptr.
6267         (solib_bfd_fopen): Take a const char *.
6268         * solib.c (solib_find_1): Return unique_xmalloc_ptr.
6269         (exec_file_find, solib_find): Likewise.
6270         (solib_bfd_fopen): Do not take ownership of "pathname".
6271         (solib_bfd_open): Use unique_xmalloc_ptr.
6272         * solib-darwin.c (darwin_bfd_open): Use unique_xmalloc_ptr.
6273         * solib-aix.c (solib_aix_bfd_open): Use unique_xmalloc_ptr.
6274         * infrun.c (follow_exec): Use unique_xmalloc_ptr.
6275         * exec.c (exec_file_locate_attach): Use unique_xmalloc_ptr.
6276
6277 2018-02-14  Joel Brobecker  <brobecker@adacore.com>
6278
6279         * ada-lang.c (name_match_type_from_name): Remove reference to
6280         ada_name_for_lookup in function's documentation.
6281         * ada-lang.h (ada_name_for_lookup): Delete declaration.
6282
6283 2018-02-13  Simon Marchi  <simon.marchi@polymtl.ca>
6284
6285         * defs.h (enum openp_flags): New enum.
6286         (OPF_TRY_CWD_FIRST, OPF_SEARCH_IN_PATH, OPF_RETURN_REALPATH):
6287         Move to enum openp_flags.
6288         (openp_flags): New enum flags.
6289         (openp): Change parameter type to openp_flags.
6290         * source.c (openp): Change parameter type to openp_flags.
6291         * cli/cli-cmds.c (find_and_open_script): Use openp_flags.
6292         * dwarf2read.c (try_open_dwop_file): Use openp_flags.
6293
6294 2018-02-13  Simon Marchi  <simon.marchi@polymtl.ca>
6295
6296         * maint.c (_initialize_maint_cmds): Fix prefix of maint set/show
6297         per-command.
6298
6299 2018-02-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6300
6301         * dwarf2read.c (dwarf2_release_queue): Delete function, move body
6302         into...
6303         (class dwarf2_queue_guard): ...the destructor of this new class.
6304         (dw2_do_instantiate_symtab): Create instance of the new class
6305         dwarf2_queue_guard, remove cleanup.
6306
6307 2018-02-09  Tom Tromey  <tom@tromey.com>
6308
6309         * source.c (find_source_lines): Don't reference past the end of
6310         the vector.
6311
6312 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
6313
6314         * remote.c (remote_btrace_maybe_reopen): Change error message.
6315         * btrace.c (btrace_enable): Likewise.
6316         (parse_xml_btrace): Likewise.
6317         (parse_xml_btrace_conf): Likewise.
6318
6319 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
6320
6321         * nat/linux-btrace.c (diagnose_perf_event_open_fail): New.
6322         (linux_enable_pt, linux_enable_bts): Call
6323         diagnose_perf_event_open_fail.
6324
6325 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
6326
6327         * nat/linux-btrace.c (perf_event_pt_event_type): Improve error message.
6328         Remove parameter and change return type.  Update callers.  Move it.
6329         (linux_enable_bts, linux_enable_pt): Improve error message.
6330         (linux_enable_pt): Remove zero buffer size check.
6331         (linux_enable_btrace): Improve error messages.  Remove NULL return
6332         check.
6333
6334 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
6335
6336         * btrace.c (btrace_enable): Remove target_supports_btrace call.
6337         * nat/linux-btrace.c (perf_event_pt_event_type): Move.
6338         (kernel_supports_bts, kernel_supports_pt, linux_supports_bts)
6339         (linux_supports_pt, linux_supports_btrace): Remove.
6340         (linux_enable_bts): Call cpu_supports_bts.
6341         * nat/linux-btrace.h (linux_supports_btrace): Remove.
6342         * remote.c (remote_supports_btrace): Remove.
6343         (init_remote_ops): Remove remote_supports_btrace.
6344         * target-delegates.c: Regenerated.
6345         * target.c (target_supports_btrace): Remove.
6346         * target.h (target_ops) <to_supports_btrace>: Remove
6347         (target_supports_btrace): Remove.
6348         * x86-linux-nat.c (x86_linux_create_target): Remove
6349         linux_supports_btrace.
6350
6351 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
6352
6353         * nat/linux-btrace.c (linux_enable_btrace): Throw exception if enabling
6354         btrace failed.
6355         * x86-linux-nat.c (x86_linux_enable_btrace): Catch btrace enabling
6356         exception and use message in own exception.
6357
6358 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
6359
6360         * nat/linux-btrace.c: Include scoped_fd.h and scoped_mmap.h.
6361         (perf_event_pt_event_type): Use gdb_file_up.
6362         (linux_enable_bts, linux_enable_pt): Use gdb::unique_xmalloc_ptr,
6363         scoped_fd, and scoped_mmap.
6364
6365 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
6366
6367         * common/scoped_mmap.h: New.
6368         * unittests/scoped_mmap-selftest.c: New.
6369         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6370         unittests/scoped_mmap-selftest.c.
6371
6372 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
6373
6374         * common/scoped_fd.h: New.
6375         * unittests/scoped_fd-selftest.c: New.
6376         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6377         unittests/scoped_fd-selftest.c.
6378
6379 2018-02-09  Tom Tromey  <tom@tromey.com>
6380
6381         * auto-load.c (auto_load_section_scripts): Use
6382         gdb::unique_xmalloc_ptr.
6383
6384 2018-02-09  Tom Tromey  <tom@tromey.com>
6385
6386         * auto-load.c (execute_script_contents): Use std::string.
6387
6388 2018-02-09  Joel Brobecker  <brobecker@adacore.com>
6389
6390         * NEWS <Changes in GDB 8.1>: Clarify that "rbreak" is a new
6391         Python function, rather than a new command.
6392
6393 2018-02-08  Tom Tromey  <tom@tromey.com>
6394
6395         * solib.c (solib_find_1): Use std::string.
6396         (solib_bfd_fopen): Use unique_xmalloc_ptr.
6397
6398 2018-02-08  Tom Tromey  <tom@tromey.com>
6399
6400         * build-id.c (build_id_to_debug_bfd): Use unique_xmalloc_ptr.
6401
6402 2018-02-08  Tom Tromey  <tom@tromey.com>
6403
6404         * source.c (find_source_lines): Use gdb::def_vector.
6405
6406 2018-02-08  Tom Tromey  <tom@tromey.com>
6407
6408         * macrocmd.c (struct temporary_macro_definition): New.
6409         (macro_define_command): Use temporary_macro_definition.  Remove
6410         cleanups.
6411         (free_macro_definition_ptr): Remove.
6412
6413 2018-02-08  Tom Tromey  <tom@tromey.com>
6414
6415         * macroexp.c (maybe_expand): Use std::string.
6416
6417 2018-02-08  Tom Tromey  <tom@tromey.com>
6418
6419         * macroexp.c (struct macro_buffer): Add initializers for some
6420         members.
6421         (init_buffer, init_shared_buffer, free_buffer)
6422         (free_buffer_return_text): Remove.
6423         (macro_buffer): New constructors.
6424         (~macro_buffer): New destructor.
6425         (macro_buffer::set_shared): New method.
6426         (macro_buffer::resize_buffer, macro_buffer::appendc)
6427         (macro_buffer::appendmem): Now methods, not free functions.
6428         (set_token, append_tokens_without_splicing, stringify)
6429         (macro_stringify): Update.
6430         (gather_arguments): Change return type.  Remove argc_p argument,
6431         add args_ptr argument.  Use std::vector.
6432         (substitute_args): Remove argc argument.  Accept std::vector.
6433         (expand): Update.  Use std::vector.
6434         (scan, macro_expand, macro_expand_next): Update.
6435
6436 2018-02-08  Tom Tromey  <tom@tromey.com>
6437
6438         * symtab.c (default_collect_symbol_completion_matches_break_on):
6439         Use unique_xmalloc_ptr.
6440         * macroscope.h: (sal_macro_scope, user_macro_scope)
6441         (default_macro_scope): Return unique_xmalloc_ptr.
6442         * macroscope.c (sal_macro_scope, user_macro_scope)
6443         (default_macro_scope): Return unique_xmalloc_ptr.
6444         * macroexp.h (macro_expand, macro_expand_once): Return
6445         unique_xmalloc_ptr.
6446         * macroexp.c (macro_expand, macro_expand_once): Return
6447         unique_xmalloc_ptr.
6448         * macrocmd.c (macro_expand_command, macro_expand_once_command)
6449         (info_macro_command, info_macros_command): Use
6450         unique_xmalloc_ptr.
6451         * compile/compile-c-support.c (write_macro_definitions): Use
6452         unique_xmalloc_ptr.
6453         * c-exp.y (c_parse): Use unique_xmalloc_ptr.
6454
6455 2018-02-07  Simon Marchi  <simon.marchi@ericsson.com>
6456
6457         * value.c (value_static_field): Assign field type instead of
6458         containing type when returning an optimized out value.
6459
6460 2018-02-06  Yao Qi  <yao.qi@linaro.org>
6461
6462         * ft32-tdep.c (ft32_read_pc): Remove.
6463         (ft32_write_pc): Remove.
6464         (ft32_gdbarch_init): Update.
6465         * m32r-tdep.c (m32r_read_pc): Remove.
6466         (m32r_gdbarch_init): Update.
6467         * mep-tdep.c (mep_read_pc): Remove.
6468         (mep_gdbarch_init): Update.
6469         * microblaze-tdep.c (microblaze_write_pc): Remove.
6470         (microblaze_gdbarch_init): Update.
6471         * mn10300-tdep.c (mn10300_read_pc): Remove.
6472         (mn10300_write_pc): Remove.
6473         (mn10300_gdbarch_init): Update.
6474         * moxie-tdep.c (moxie_read_pc): Remove.
6475         (moxie_write_pc): Remove.
6476         (moxie_gdbarch_init): Update.
6477
6478 2018-02-06  Yao Qi  <yao.qi@linaro.org>
6479
6480         * expprint.c (print_subexp_standard): Handle
6481         OP_F77_UNDETERMINED_ARGLIST.
6482         (dump_subexp_body_standard): Likewise.
6483
6484 2018-02-05  Alan Hayward  <alan.hayward@arm.com>
6485
6486         * target-descriptions.c (tdesc_element_visitor) Add empty
6487         implementations.
6488         (tdesc_type): Move make_gdb_type from here.
6489         (tdesc_type_builtin): Likewise.
6490         (tdesc_type_vector): Likewise.
6491         (tdesc_type_with_fields): Move make_gdb_type_ functions from here.
6492         (make_gdb_type_struct): Move from tdesc_type_with_fields.
6493         (make_gdb_type_union): Likewise.
6494         (make_gdb_type_flags): Likewise.
6495         (make_gdb_type_enum): Likewise.
6496         (make_gdb_type): New function.
6497         (tdesc_register_type): Use static make_gdb_type.
6498
6499 2018-02-05  Ruslan Kabatsayev <b7.10110111@gmail.com>
6500
6501         * infcmd.c (default_print_one_register_info): Align natural-format
6502         column values consistently one under another.
6503         (pad_to_column): New function.
6504
6505 2018-02-05  Joel Brobecker  <brobecker@adacore.com>
6506
6507         * dwarf2read.c (dwarf2_physname): Move commment.
6508
6509 2018-02-01  Leszek Swirski  <leszeks@google.com>
6510
6511         * varobj.c (varobj_formatted_print_options): Allow recursive
6512         pretty printing if pretty printing is enabled.
6513
6514 2018-02-01  Leszek Swirski  <leszeks@google.com>
6515
6516         * c-exp.y (lex_one_token, classify_name, yylex): Don't classify
6517         names after a structop as a filename.
6518
6519 2018-02-01  Yao Qi  <yao.qi@linaro.org>
6520
6521         * arm-tdep.c (arm_record_data_proc_misc_ld_str): Rewrite it.
6522         (arm_record_coproc_data_proc): Likewise.
6523
6524 2018-02-01  Yao Qi  <yao.qi@linaro.org>
6525
6526         * arm-tdep.c (arm_record_extension_space): Change ret to signed.
6527
6528 2018-01-31  Nikola Prica  <nikola.prica@rt-rk.com>
6529
6530         * rs6000-tdep.c (skip_prologue): Remove shifting for lr_reg and
6531         assign shifted lr_reg to fdata->lr_register when lr_reg is set.
6532
6533 2018-01-31  Pedro Alves  <palves@redhat.com>
6534
6535         * darwin-nat.c (darwin_interrupt): Remove ptid_t parameter.
6536         * inflow.c (child_terminal_save_inferior): Wrap reference to
6537         tcgetpgrp in HAVE_TERMIOS_H.
6538         (child_interrupt, child_pass_ctrlc): Wrap references to signal in
6539         _WIN32.
6540         * remote-sim.c (gdbsim_interrupt): Remove ptid_t parameter and
6541         always iterate over all inferiors.
6542         (gdbsim_cntrl_c): Adjust.
6543         * windows-nat.c (windows_interrupt): Remove 'ptid_t' parameter.
6544
6545 2018-01-31  Joel Brobecker  <brobecker@adacore.com>
6546
6547         * gdbtypes.c (lookup_array_range_type): Make sure the array's
6548         index type is objfile-owned if the element type is as well.
6549
6550 2018-01-31  Joel Brobecker  <brobecker@adacore.com>
6551
6552         GDB 8.1 released.
6553
6554 2018-01-30  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6555
6556         * s390-linux-tdep.c: Remove includes "features/s390-linux32.c" and
6557         "features/s390x-linux64.c".
6558         (_initialize_s390_linux_tdep): Remove initialization of tdescs
6559         s390_linux32 and s390x_linux64.
6560         (s390_linux_init_abi_31, s390_linux_init_abi_64): Don't set
6561         default tdesc.
6562         * s390-tdep.c: Include "features/s390-linux32.c" and
6563         "features/s390x-linux64.c".
6564         (s390_tdesc_valid): Add check for tdesc_has_registers.
6565         (s390_gdbarch_init): Make sure there is always a valid tdesc.
6566         (_initialize_s390_tdep): Initialize tdesc_s390_linux32 and
6567         tdesc_s390x_linux64.
6568         * s390-linux-tdep.h: Move export of tdesc_s390_linux32 and
6569         tdesc_s390x_linux64 to...
6570         * s390-tdep.h: ...here.
6571
6572 2018-01-30  Pedro Alves  <palves@redhat.com>
6573
6574         PR gdb/13211
6575         * config.in, configure: Regenerate.
6576         * configure.ac: Check for getpgid.
6577         * go32-nat.c (go32_pass_ctrlc): New.
6578         (go32_target): Install it.
6579         * inf-child.c (inf_child_target): Install
6580         child_terminal_save_inferior, child_pass_ctrlc and
6581         child_interrupt.
6582         * inf-ptrace.c (inf_ptrace_interrupt): Delete.
6583         (inf_ptrace_target): No longer install it.
6584         * infcmd.c (interrupt_target_1): Adjust.
6585         * inferior.h (child_terminal_save_inferior, child_pass_ctrlc)
6586         (child_interrupt): Declare.
6587         (inferior::terminal_state): New.
6588         * inflow.c (struct terminal_info): Update comments.
6589         (inferior_process_group): Delete.
6590         (terminal_is_ours): Delete.
6591         (gdb_tty_state): New.
6592         (child_terminal_init): Adjust.
6593         (is_gdb_terminal, sharing_input_terminal_1)
6594         (sharing_input_terminal): New functions.
6595         (child_terminal_inferior): Adjust.  Use sharing_input_terminal.
6596         Set the process's actual process group in the foreground if
6597         possible.  Handle is_ours_for_output/is_ours distinction.  Don't
6598         mark terminal as the inferior's if not sharing GDB's terminal.
6599         Don't check attach_flag.
6600         (child_terminal_ours_for_output, child_terminal_ours): Adjust to
6601         pass down a target_terminal_state.
6602         (child_terminal_save_inferior): New, factored out from ...
6603         (child_terminal_ours_1): ... this.  Handle
6604         target_terminal_state::is_ours_for_output.
6605         (child_interrupt, child_pass_ctrlc): New.
6606         (inflow_inferior_exit): Clear the inferior's terminal_state.
6607         (copy_terminal_info): Copy the inferior's terminal state.
6608         (_initialize_inflow): Remove reference to terminal_is_ours.
6609         * inflow.h (inferior_process_group): Delete.
6610         * nto-procfs.c (nto_handle_sigint, procfs_interrupt): Adjust.
6611         * procfs.c (procfs_target): Don't install procfs_interrupt.
6612         (procfs_interrupt): Delete.
6613         * remote.c (remote_serial_quit_handler): Adjust.
6614         (remote_interrupt): Remove ptid parameter.  Adjust.
6615         * target-delegates.c: Regenerate.
6616         * target.c: Include "terminal.h".
6617         (target_terminal::terminal_state): Rename to ...
6618         (target_terminal::m_terminal_state): ... this.
6619         (target_terminal::init): Adjust.
6620         (target_terminal::inferior): Adjust to per-inferior
6621         terminal_state.
6622         (target_terminal::restore_inferior, target_terminal_is_ours_kind): New.
6623         (target_terminal::ours, target_terminal::ours_for_output): Use
6624         target_terminal_is_ours_kind.
6625         (target_interrupt): Remove ptid parameter.  Adjust.
6626         (default_target_pass_ctrlc): Adjust.
6627         * target.h (target_ops::to_terminal_save_inferior): New field.
6628         (target_ops::to_interrupt): Remove ptid_t parameter.
6629         (target_interrupt): Remove ptid_t parameter.  Update comment.
6630         (target_pass_ctrlc): Update comment.
6631         * target/target.h (target_terminal_state): New scoped enum,
6632         factored out of ...
6633         (target_terminal::terminal_state): ... here.
6634         (target_terminal::inferior): Update comments.
6635         (target_terminal::restore_inferior): New.
6636         (target_terminal::is_inferior, target_terminal::is_ours)
6637         (target_terminal::is_ours_for_output): Adjust.
6638         (target_terminal::scoped_restore_terminal_state): Adjust to
6639         rename, and call restore_inferior() instead of inferior().
6640         (target_terminal::scoped_restore_terminal_state::m_state): Change
6641         type.
6642         (target_terminal::terminal_state): Rename to ...
6643         (target_terminal::m_terminal_state): ... this and change type.
6644
6645 2018-01-30  Pedro Alves  <palves@redhat.com>
6646
6647         * linux-nat.c (wait_for_signal): New function.
6648         (wait_lwp, linux_nat_wait_1): Use it instead of calling sigsuspend
6649         directly.
6650         (async_terminal_is_ours)
6651         (linux_nat_terminal_inferior, linux_nat_terminal_ours): Delete.
6652         (linux_nat_add_target): Don't override
6653         to_terminal_inferior/to_terminal_ours.
6654
6655 2018-01-29  Sergio Durigan Junior  <sergiodj@redhat.com>
6656
6657         * remote.c (remote_follow_fork): Don't call "detach_inferior".
6658
6659 2018-01-28  Simon Marchi  <simon.marchi@ericsson.com>
6660
6661         * dwarf2read.c (free_dwo_files): Add forward-declaration.
6662         (dwarf2_per_objfile::~dwarf2_per_objfile): Move content from
6663         dwarf2_per_objfile_free here.
6664         (dwarf2_per_objfile_free): Remove.
6665         (_initialize_dwarf2_read): Don't register
6666         dwarf2_per_objfile_free as a registry cleanup.
6667
6668 2018-01-27  Eli Zaretskii  <eliz@gnu.org>
6669
6670         Avoid compilation errors in MinGW native builds
6671
6672         The error is triggered by including python-internal.h, and the
6673         error message is:
6674
6675              In file included from d:\usr\lib\gcc\mingw32\6.3.0\include\c++\math.h:36:0,
6676                       from build-gnulib/import/math.h:27,
6677                       from d:/usr/Python26/include/pyport.h:235,
6678                       from d:/usr/Python26/include/Python.h:58,
6679                       from python/python-internal.h:94,
6680                       from python/py-arch.c:24:
6681              d:\usr\lib\gcc\mingw32\6.3.0\include\c++\cmath:1157:11: error: '::hypot' has not been declared
6682         using ::hypot;
6683                 ^~~~~
6684
6685         This happens because Python headers define 'hypot' to expand t
6686         '_hypot' in the Windows builds.
6687         * python/python-internal.h (_hypot) [__MINGW32__]: Define back to
6688         'hypoth'.  This avoids a compilation error.
6689
6690 2018-01-26  Alan Hayward  <alan.hayward@arm.com>
6691
6692         * MAINTAINERS (Write After Approval): Fix ordering.
6693
6694 2018-01-26  Alan Hayward  <alan.hayward@arm.com>
6695
6696         * MAINTAINERS (Write After Approval): Add Alan Hayward.
6697
6698 2018-01-26  Alan Modra  <amodra@gmail.com>
6699
6700         * ppc-linux-tdep.c (powerpc32_plt_stub): Make const.
6701         (powerpc32_plt_stub_so_1): Rename from powerpc32_plt_stub_so.
6702         Remove nop.  Make const.  Comment.
6703         (powerpc32_plt_stub_so_2): New.
6704         (POWERPC32_PLT_CHECK_LEN): Rename from POWERPC32_PLT_STUB_LEN.
6705         Correct count.  Update uses.
6706         (ppc_skip_trampoline_code): Match powerpc32_plt_stub_so_2 too.
6707         Move common code reading PLT entry word.  Correct
6708         powerpc32_plt_stub PLT address calculation.
6709         * ppc64-tdep.c (ppc64_standard_linkage1): Make const.
6710         (ppc64_standard_linkage2, ppc64_standard_linkage3): Likewise.
6711         (ppc64_standard_linkage4, ppc64_standard_linkage5): Likewise.
6712         (ppc64_standard_linkage6, ppc64_standard_linkage7): Likewise.
6713         (ppc64_standard_linkage8): Likewise.
6714         * rs6000-tdep.c (ppc_insns_match_pattern): Make pattern const.
6715         Correct insns description.
6716         * ppc-tdep.h (ppc_insns_match_pattern): Update prototype.
6717
6718 2018-01-24  Pedro Alves  <palves@redhat.com>
6719
6720         GCC PR libstdc++/83906
6721         * gdbtypes.c (operator==(const dynamic_prop &,
6722         const dynamic_prop &)): New.
6723         (operator==(const range_bounds &, const range_bounds &)): New.
6724         (check_types_equal): Use them instead of memcmp.
6725         * gdbtypes.h (operator==(const dynamic_prop &,
6726         const dynamic_prop &)): Declare.
6727         (operator!=(const dynamic_prop &, const dynamic_prop &)): Declare.
6728         (operator==(const range_bounds &, const range_bounds &)): Declare.
6729         (operator!=(const range_bounds &, const range_bounds &)): Declare.
6730
6731 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6732
6733         * s390-linux-tdep.c (s390_record_address_mask)
6734         (s390_record_calc_disp_common, s390_record_calc_disp)
6735         (s390_record_calc_disp_vsce, s390_record_calc_rl, s390_popcnt)
6736         (s390_record_gpr_g, s390_record_gpr_h, s390_record_vr)
6737         (s390_process_record): Move to s390-tdep.c.
6738         (s390_linux_init_abi_any): Adjust.
6739         * s390-tdep.c (s390_record_address_mask)
6740         (s390_record_calc_disp_common, s390_record_calc_disp)
6741         (s390_record_calc_disp_vsce, s390_record_calc_rl, s390_popcnt)
6742         (s390_record_gpr_g, s390_record_gpr_h, s390_record_vr)
6743         (s390_process_record): Moved from s390-linux-tdep.c
6744         (s390_gdbarch_init): Adjust.
6745
6746 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6747
6748         * s390-linux-nat.c (s390-tdep.h): New include.
6749         * Makefile.in (ALL_TARGET_OBS): Add s390-tdep.o.
6750         (HFILES_NO_SRCDIR): Add s390-tdep.h.
6751         (ALLDEPFILES): Add s390-tdep.c.
6752         * configure.tgt (s390*-*-linux*): Add s390-tdep.o.
6753         * s390-linux-tdep.h (HWCAP_S390_*, S390_*_REGNUM): Move to...
6754         * s390-tdep.h: ...this.  New file.
6755         * s390-linux-tdep.c (s390-tdep.h): New include.
6756         (_initialize_s390_tdep): Rename to...
6757         (_initialize_s390_linux_tdep): ...this and adjust.
6758         (s390_abi_kind, s390_vector_abi_kind, gdbarch_tdep)
6759         (enum named opcodes, S390_NUM_GPRS, S390_NUM_FPRS): Move to
6760         s390-tdep.h.
6761         (s390_break_insn, s390_breakpoint, s390_readinstruction, is_ri)
6762         (is_ril, is_rr, is_rre, is_rs, is_rsy, is_rx, is_rxy)
6763         (s390_is_partial_instruction, s390_software_single_step)
6764         (is_non_branch_ril, s390_displaced_step_copy_insn)
6765         (s390_displaced_step_fixup, s390_displaced_step_hw_singlestep)
6766         (s390_prologue_data, s390_addr, s390_store, s390_load)
6767         (s390_check_for_saved, s390_analyze_prologue, s390_skip_prologue)
6768         (s390_register_call_saved, s390_guess_tracepoint_registers)
6769         (s390_register_name, s390_dwarf_regmap, s390_dwarf_reg_to_regnum)
6770         (regnum_is_gpr_full, regnum_is_vxr_full, s390_value_from_register)
6771         (s390_pseudo_register_name, s390_pseudo_register_type)
6772         (s390_pseudo_register_read, s390_pseudo_register_write)
6773         (s390_pseudo_register_reggroup_p, s390_ax_pseudo_register_collect)
6774         (s390_ax_pseudo_register_push_stack, s390_gen_return_address)
6775         (s390_addr_bits_remove, s390_address_class_type_flags)
6776         (s390_address_class_type_flags_to_name)
6777         (s390_address_class_name_to_type_flags, s390_effective_inner_type)
6778         (s390_function_arg_float, s390_function_arg_vector)
6779         (is_power_of_two, s390_function_arg_integer, s390_arg_state)
6780         (s390_handle_arg, s390_push_dummy_call, s390_dummy_id)
6781         (s390_frame_align, s390_register_return_value, s390_return_value)
6782         (s390_stack_frame_destroyed_p, s390_unwind_pc, s390_unwind_sp)
6783         (s390_unwind_pseudo_register, s390_adjust_frame_regnum)
6784         (s390_dwarf2_prev_register, s390_dwarf2_frame_init_reg)
6785         (s390_trad_frame_prev_register, s390_unwind_cache)
6786         (s390_prologue_frame_unwind_cache)
6787         (s390_backchain_frame_unwind_cache, s390_frame_unwind_cache)
6788         (s390_frame_this_id, s390_frame_prev_register, s390_frame_unwind)
6789         (s390_stub_unwind_cache, s390_stub_frame_unwind_cache)
6790         (s390_stub_frame_this_id, s390_stub_frame_prev_register)
6791         (s390_stub_frame_sniffer, s390_stub_frame_unwind)
6792         (s390_frame_base_address, s390_local_base_address)
6793         (s390_frame_base, s390_gcc_target_options)
6794         (s390_gnu_triplet_regexp, s390_stap_is_single_operand)
6795         (s390_validate_reg_range, s390_tdesc_valid)
6796         (s390_gdbarch_tdep_alloc, s390_gdbarch_init): Move to...
6797         * s390-tdep.c: ...this.  New file.
6798
6799 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6800
6801         * s390-linux-tdep.c (gdbarch_tdep.s390_syscall_record): New hook.
6802         (s390_process_record, s390_gdbarch_tdep_alloc)
6803         (s390_linux_init_abi_any): Use/set new hook.
6804
6805 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6806
6807         * s390-linux-tdep.c (osabi.h): New include.
6808         (s390_linux_init_abi_31, s390_linux_init_abi_64)
6809         (s390_linux_init_abi_any): New functions.
6810         (s390_gdbarch_init, _initialize_s390_tdep): Adjust.
6811
6812 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6813
6814         * s390-linux-tdep.c (s390_gdbarch_init): Use gdb_assert for
6815         tdesc_has_registers check
6816
6817 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6818
6819         * s390-linux-tdep.c (s390_tdesc_valid): New function.
6820         (s390_validate_reg_range): New macro.
6821         (s390_gdbarch_init): Adjust.
6822
6823 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6824
6825         * s390-linux-tdep.c (gdbarch_tdep) <tdesc>: New field.
6826         (s390_gdbarch_tdep_alloc): Adjust.
6827         (s390_gdbarch_init): Adjust.
6828
6829 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6830
6831         * s390-linux-tdep.c (gdbarch_tdep) <have_linux_v1, have_linux_v2>
6832         <have_tdb>: Change type to bool.
6833         (s390_gdbarch_tdep_alloc): Adjust.
6834         (s390_gdbarch_init): Adjust.
6835
6836 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6837
6838         * s390-linux-tdep (s390_abi_kind) <ABI_NONE>: New default field.
6839         (gdbarch_tdep) <have_upper, have_vx>: New fields.
6840         (s390_gdbarch_tdep_alloc): New function.
6841         (s390_gdbarch_init): Allocate tdep at start and use its fields
6842         instead of separate variables.
6843
6844 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6845
6846         * s390-linux-tdep.c (s390_gdbarch_init): Remove duplicate checks
6847         when looking for cached gdbarch and add comment for remaining.
6848
6849 2018-01-22  Pedro Alves  <palves@redhat.com>
6850             Sergio Durigan Junior  <sergiodj@redhat.com>
6851
6852         * typeprint.c (whatis_exp): Initialize "val" in the "whatis type"
6853         case.
6854
6855 2018-01-22  Maciej W. Rozycki  <macro@mips.com>
6856
6857         * MAINTAINERS: Update my company e-mail address.
6858
6859 2018-01-22  Yao Qi  <yao.qi@linaro.org>
6860
6861         * regcache.c (cooked_write_test): New function.
6862         (_initialize_regcache): Register the test.
6863
6864 2018-01-22  Yao Qi  <yao.qi@linaro.org>
6865
6866         * ia64-tdep.c (ia64_pseudo_register_read): Call
6867         regcache->cooked_read instead of regcache_cooked_read_unsigned.
6868         * m32c-tdep.c (m32c_cat_read): Likewise.
6869         (m32c_r3r2r1r0_read): Likewise.
6870         * m68hc11-tdep.c (m68hc11_pseudo_register_read): Likewise.
6871         * xtensa-tdep.c (xtensa_register_read_masked): Likewise.
6872
6873 2018-01-22  Yao Qi  <yao.qi@linaro.org>
6874
6875         * aarch64-tdep.c (aarch64_pseudo_read_value): Call regcache
6876         method raw_read instead of regcache_raw_read.
6877         * amd64-tdep.c (amd64_pseudo_register_read_value): Likewise.
6878         * arm-tdep.c (arm_neon_quad_read): Likewise.
6879         * avr-tdep.c (avr_pseudo_register_read): Likewise.
6880         * bfin-tdep.c (bfin_pseudo_register_read): Likewise.
6881         * frv-tdep.c (frv_pseudo_register_read): Likewise.
6882         * h8300-tdep.c (h8300_pseudo_register_read): Likewise.
6883         * i386-tdep.c (i386_mmx_regnum_to_fp_regnum): Likewise.
6884         (i386_pseudo_register_read_into_value): Likewise.
6885         * mep-tdep.c (mep_pseudo_cr32_read): Likewise.
6886         * msp430-tdep.c (msp430_pseudo_register_read): Likewise.
6887         * nds32-tdep.c (nds32_pseudo_register_read): Likewise.
6888         * rl78-tdep.c (rl78_pseudo_register_read): Likewise.
6889         * s390-linux-tdep.c (s390_pseudo_register_read): Likewise.
6890         * sparc-tdep.c (sparc32_pseudo_register_read):  Likewise.
6891         * sparc64-tdep.c (sparc64_pseudo_register_read): Likewise.
6892         * spu-tdep.c (spu_pseudo_register_read_spu):  Likewise.
6893         * xtensa-tdep.c (xtensa_pseudo_register_read): Likewise.
6894
6895 2018-01-22  Yao Qi  <yao.qi@linaro.org>
6896
6897         * Makefile.in (ALL_TARGET_OBS): Remove mt-tdep.o.
6898         * configure.tgt: Remove target mt.
6899         * mt-tdep.c: Remove.
6900         * regcache.c (cooked_read_test): Remove the check for mt.
6901
6902 2018-01-22  Yao Qi  <yao.qi@linaro.org>
6903
6904         * jit.c (jit_frame_prev_register): Call regcache::cooked_read
6905         instead of gdbarch_pseudo_register_read_value.
6906
6907 2018-01-22  Joel Brobecker  <brobecker@adacore.com>
6908
6909         * dwarf2read.c (need_gnat_info): Return nonzero if the cu's
6910         language is Ada.
6911
6912 2018-01-22  Joel Brobecker  <brobecker@adacore.com>
6913
6914         * linespec.c (create_sals_line_offset): Remove code that preserved
6915         the symtab_and_line's line number.
6916
6917 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6918
6919         * varobj.c (varobj_create): Don't set valid_block when creating a
6920         floating varobj.
6921
6922 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6923
6924         * varobj.c (varobj_create): Remove out of date comment.
6925
6926 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6927
6928         PR mi/20395
6929         * ada-exp.y (write_var_from_sym): Pass extra parameter when
6930         updating innermost block.
6931         * parse.c (innermost_block_tracker::update): Take extra type
6932         parameter, and check types match before updating innermost block.
6933         (write_dollar_variable): Update innermost block for registers.
6934         * parser-defs.h (enum innermost_block_tracker_type): New enum.
6935         (innermost_block_tracker::innermost_block_tracker): Initialise
6936         m_types member.
6937         (innermost_block_tracker::reset): Take type parameter.
6938         (innermost_block_tracker::update): Take type parameter, and pass
6939         type through as needed.
6940         (innermost_block_tracker::m_types): New member.
6941         * varobj.c (varobj_create): Pass type when reseting innermost
6942         block.
6943
6944 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6945
6946         * ada-exp.y (write_var_from_sym): Switch to innermost_block API.
6947         * ada-lang.c (resolve_subexp): Likewise.
6948         * breakpoint.c (set_breakpoint_condition) Likewise.
6949         (watch_command_1) Likewise.
6950         * c-exp.y (variable): Likewise.
6951         * d-exp.y (PrimaryExpression): Likewise.
6952         * f-exp.y (variable): Likewise.
6953         * go-exp.y (variable): Likewise.
6954         * m2-exp.y (variable): Likewise.
6955         * objfiles.c (objfile::~objfile): Likewise.
6956         * p-exp.y (variable): Likewise.
6957         * parse.c (innermost_block): Change type.
6958         * parser-defs.h (class innermost_block_tracker): New.
6959         (innermost_block): Change to innermost_block_tracker.
6960         * printcmd.c (display_command): Switch to innermost_block API.
6961         (do_one_display): Likewise.
6962         * rust-exp.y (do_one_display): Likewise.
6963         * symfile.c (clear_symtab_users): Likewise.
6964         * varobj.c (varobj_create): Switch to innermost_block API, replace
6965         use of innermost_block with block stored on varobj object.
6966
6967 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6968
6969         * expression.h (innermost_block): Remove declaration.
6970         * varobj.c: Add 'parser-defs.h' include.
6971
6972 2018-01-19  Tom Tromey  <tom@tromey.com>
6973
6974         * rust-lang.c (rust_lookup_symbol_nonlocal): Look up qualified
6975         symbols in the static and global blocks.
6976
6977 2018-01-19  James Clarke  <jrtc27@jrtc27.com>
6978
6979         * nat/linux-ptrace.c: Remove unnecessary reinclusion of
6980         gdb_ptrace.h, and move including gdb_wait.h ...
6981         * nat/linux-ptrace.h: ... to here.
6982
6983 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
6984
6985         * inf-ptrace.c (inf_ptrace_detach): Adjust call to
6986         inf_ptrace_detach_success.
6987         (inf_ptrace_detach_success): Add inferior parameter, use it
6988         instead of inferior_ptid, pass it to detach_inferior.
6989         * inf-ptrace.h (inf_ptrace_detach_success): Add inferior
6990         parameter.
6991         * inferior.c (detach_inferior): Add overload that takes an
6992         inferior object.
6993         * inferior.h (detach_inferior): Likewise.
6994         * linux-nat.c (linux_nat_detach): Use the inf parameter, don't
6995         use inferior_ptid, adjust call to inf_ptrace_detach_success.
6996         * linux-thread-db.c (thread_db_detach): Use inf parameter.
6997
6998 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
6999
7000         * target.h (struct target_ops) <to_detach>: Add inferior
7001         parameter.
7002         (target_detach): Likewise.
7003         * target.c (dispose_inferior): Pass inferior down.
7004         (target_detach): Pass inferior down.  Assert that it is equal to
7005         the current inferior.
7006         * aix-thread.c (aix_thread_detach): Pass inferior down.
7007         * corefile.c (core_file_command): Pass current_inferior() down.
7008         * corelow.c (core_detach): Add inferior parameter.
7009         * darwin-nat.c (darwin_detach): Likewise.
7010         * gnu-nat.c (gnu_detach): Likewise.
7011         * inf-ptrace.c (inf_ptrace_detach): Likewise.
7012         * infcmd.c (detach_command): Pass current_inferior() down to
7013         target_detach.
7014         * infrun.c (follow_fork_inferior): Pass parent_inf to
7015         target_detach.
7016         (handle_vfork_child_exec_or_exit): Pass inf->vfork_parent to
7017         target_detach.
7018         * linux-nat.c (linux_nat_detach): Add inferior parameter.
7019         * linux-thread-db.c (thread_db_detach): Likewise.
7020         * nto-procfs.c (procfs_detach): Likewise.
7021         * procfs.c (procfs_detach): Likewise.
7022         * record.c (record_detach): Likewise.
7023         * record.h (struct inferior): Forward-declare.
7024         (record_detach): Add inferior parameter.
7025         * remote-sim.c (gdbsim_detach): Likewise.
7026         * remote.c (remote_detach_1): Likewise.
7027         (remote_detach): Likewise.
7028         (extended_remote_detach): Likewise.
7029         * sol-thread.c (sol_thread_detach): Likewise.
7030         * target-debug.h (target_debug_print_inferior_p): New macro.
7031         * target-delegates.c: Re-generate.
7032         * top.c (kill_or_detach): Pass inferior down to target_detach.
7033         * windows-nat.c (windows_detach): Add inferior parameter.
7034
7035 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
7036
7037         * target.h (struct target_ops) <to_detach>: Remove args
7038         parameter.
7039         (target_detach): Likewise.
7040         * target.c (dispose_inferior): Adjust.
7041         (target_detach): Remove args parameter, adjust.
7042         * aix-thread.c (aix_thread_detach): Adjust.
7043         * corefile.c (core_file_command): Adjust.
7044         * corelow.c (core_detach): Adjust.
7045         * darwin-nat.c (darwin_detach): Adjust.
7046         * gnu-nat.c (gnu_detach): Adjust.
7047         * inf-ptrace.c (inf_ptrace_detach): Adjust.
7048         * infcmd.c (detach_command): Adjust
7049         * infrun.c (follow_fork_inferior): Adjust.
7050         (handle_vfork_child_exec_or_exit): Adjust.
7051         * linux-fork.c (linux_fork_detach): Remove args parameter.
7052         * linux-fork.h (linux_fork_detach): Likewise.
7053         * linux-nat.c (linux_nat_detach): Likewise, and adjust.
7054         * linux-thread-db.c (thread_db_detach): Likewise.
7055         * nto-procfs.c (procfs_detach): Likewise.
7056         * procfs.c (procfs_detach): Likewise.
7057         (do_detach): Remove signo parameter.
7058         * record.c (record_detach): Remove args parameter.
7059         * record.h (record_detach): Likewise.
7060         * remote-sim.c (gdbsim_detach): Likewise.
7061         * remote.c (remote_detach_1): Likewise.
7062         (remote_detach): Likewise.
7063         (extended_remote_detach): Likewise.
7064         * sol-thread.c (sol_thread_detach): Likewise.
7065         * target-delegates.c: Re-generate.
7066         * top.c (struct qt_args) <args>: Remove field.
7067         (kill_or_detach): Don't pass args.
7068         (quit_force): Don't set args.
7069         * windows-nat.c (windows_detach): Remove args parameter.
7070
7071 2018-01-19  Yao Qi  <yao.qi@linaro.org>
7072
7073         * arm-linux-tdep.c (arm_linux_gcc_target_options): New function.
7074         (arm_linux_init_abi): Install it.
7075
7076 2018-01-19  Yao Qi  <yao.qi@linaro.org>
7077
7078         * osabi.c (gdb_osabi_names): Extend the regexp for
7079         arm-linux-gnueabihf.
7080
7081 2018-01-18  Yao Qi  <yao.qi@linaro.org>
7082
7083         * dwarf2read.c (abbrev_table) <abbrevs>: Rename it to
7084         m_abbrevs.
7085         (abbrev_table::add_abbrev): Update.
7086         (abbrev_table::lookup_abbrev): Update.
7087
7088 2018-01-18  Yao Qi  <yao.qi@linaro.org>
7089
7090         * ppc-linux-tdep.c (ppu2spu_prev_register): Call cooked_read.
7091
7092 2018-01-17  Sergio Durigan Junior  <sergiodj@redhat.com>
7093
7094         * compile/compile.c (compile_to_object): Convert "triplet_rx"
7095         to "std::string".
7096
7097 2018-01-17  Tom Tromey  <tom@tromey.com>
7098
7099         * dwarf2read.c (symbolp): Remove typedef.  Don't instantiate VEC.
7100
7101 2018-01-17  Tom Tromey  <tom@tromey.com>
7102
7103         * gdbtypes.h (add_dyn_prop): Remove objfile parameter.
7104         * gdbtypes.c (add_dyn_prop): Remove objfile parameter.
7105         (create_array_type_with_stride): Update.
7106         * dwarf2read.c (set_die_type): Update.
7107
7108 2018-01-17  Tom Tromey  <tom@tromey.com>
7109
7110         * dwarf2read.c (delayed_method_info): Remove typedef.
7111         (dwarf2_cu::method_info): Now a std::vector.
7112         (add_to_method_list): Update.
7113         (free_delayed_list): Remove.
7114         (compute_delayed_physnames): Update.
7115         (process_full_comp_unit, process_full_type_unit): Clear the method
7116         list.  Remove cleanups.
7117         (psymtab_include_file_name): Add name_holder parameter.  Use
7118         unique_xmalloc_ptr.
7119         (dwarf_decode_lines): Update.
7120
7121 2018-01-17  Tom Tromey  <tom@tromey.com>
7122             Simon Marchi  <simon.marchi@ericsson.com>
7123
7124         * dwarf2read.c (struct dwarf2_cu): Add constructor, destructor.
7125         (dwarf2_per_objfile::free_cached_comp_units)
7126         (init_tu_and_read_dwo_dies, init_cutu_and_read_dies)
7127         (init_cutu_and_read_dies_no_follow): Update.
7128         (dwarf2_cu::dwarf2_cu): Rename from init_one_comp_unit.
7129         (dwarf2_cu::~dwarf2_cu): New.
7130         (free_heap_comp_unit, free_stack_comp_unit): Remove.
7131         (age_cached_comp_units, free_one_cached_comp_unit): Update.
7132
7133 2018-01-17  Tom Tromey  <tom@tromey.com>
7134             Simon Marchi  <simon.marchi@ericsson.com>
7135
7136         * dwarf2read.c (struct dwarf2_cu) <abbrev_table>: Remove.
7137         (struct die_reader_specs) <abbrev_table>: New member.
7138         (struct abbrev_table): Add constructor.
7139         <alloc_abbrev, add_abbrev, lookup_abbrev>: Declare.
7140         <abbrev_obstack>: Now an auto_obstack.
7141         (abbrev_table_up): New typedef.
7142         (init_cu_die_reader): Add abbrev_table parameter.
7143         (read_cutu_die_from_dwo): Remove abbrev_table_provided parameter.
7144         Add result_dwo_abbrev_table.
7145         (init_tu_and_read_dwo_dies, init_cutu_and_read_dies)
7146         (init_cutu_and_read_dies_no_follow, build_type_psymtabs_1):
7147         Update.
7148         (peek_die_abbrev): Take die_reader_specs, not dwarf_cu as
7149         parameter.
7150         (skip_children): Update.
7151         (abbrev_table::alloc_abbrev): Rename from
7152         abbrev_table_alloc_abbrev.
7153         (abbrev_table::add_abbrev): Rename from abbrev_table_add_abbrev.
7154         (abbrev_table::lookup_abbrev): Rename from
7155         abbrev_table_lookup_abbrev.
7156         (abbrev_table_read_table): Return abbrev_table_up.
7157         (abbrev_table_free, abbrev_table_free_cleanup)
7158         (dwarf2_read_abbrevs, dwarf2_free_abbrev_table): Remove.
7159         (load_partial_dies): Update.
7160
7161 2018-01-17  Tom Tromey  <tom@tromey.com>
7162
7163         * dwarf2read.c (dwarf2_compute_name): Update comment.
7164         (read_func_scope, read_variable): Update.
7165         (new_symbol): Remove.
7166         (new_symbol_full): Rename to new_symbol.
7167
7168 2018-01-17  Mike Gulick  <mgulick@mathworks.com>
7169
7170         PR gdb/16577
7171         * gdb_bfd.c (gdb_bfd_map_section): If unable to read object file, issue
7172         a warning instead of throwing an error, set section size to 0 and return
7173         NULL.
7174         * gdb_bfd.h (gdb_bfd_map_section): Update description.
7175
7176 2018-01-17  Simon Marchi  <simon.marchi@ericsson.com>
7177
7178         * nat/linux-ptrace.h (linux_ptrace_attach_fail_reason): Return
7179         std::string.
7180         (linux_ptrace_attach_fail_reason_string): Likewise.
7181         * nat/linux-ptrace.c (linux_ptrace_attach_fail_reason):
7182         Likewise.
7183         (linux_ptrace_attach_fail_reason_string): Likewise.
7184         * linux-nat.c (attach_proc_task_lwp_callback): Adjust.
7185
7186 2018-01-17  Simon Marchi  <simon.marchi@ericsson.com>
7187
7188         * linux-nat.c (linux_nat_attach): Remove xstrdup.
7189
7190 2018-01-17  Eldar Abusalimov  <eldar.abusalimov@jetbrains.com>
7191
7192         PR gdb/21559
7193         * configure.ac: Include <sys/types.h> prior to <sys/user.h> when
7194         checking for fs_base/gs_base fields in struct user_regs_struct.
7195         * configure: Regenerate.
7196
7197 2018-01-17  Yao Qi  <yao.qi@linaro.org>
7198
7199         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): New
7200         function.
7201         (aarch64_linux_init_abi): Install it to gdbarch hook
7202         gcc_target_options.
7203
7204 2018-01-15  Pedro Alves  <palves@redhat.com>
7205
7206         * common/signals-state-save-restore.c
7207         (save_original_signals_state): Fix typos.
7208
7209 2017-01-12  Tom Tromey  <tom@tromey.com>
7210             Sergio Durigan Junior  <sergiodj@redhat.com>
7211
7212         * Makefile.in (install-only): Install gdb-add-index.
7213
7214 2018-01-12  John Baldwin  <jhb@FreeBSD.org>
7215
7216         * fbsd-tdep.c (KVE_PROTECTION): Correct value.
7217
7218 2018-01-12  Andreas Arnez  <arnez@linux.vnet.ibm.com>
7219
7220         * infrun.c (keep_going_pass_signal): Clear step-over info when
7221         insert_breakpoints fails.
7222
7223 2018-01-11  Pedro Alves  <palves@redhat.com>
7224
7225         PR gdb/22583
7226         * infrun.c (resume): Rename to ...
7227         (resume_1): ... this.
7228         (resume): Reimplement as wrapper around resume_1.
7229
7230 2018-01-11  Pedro Alves  <palves@redhat.com>
7231
7232         PR remote/22597
7233         * remote.c (remote_parse_stop_reply): Default to the last-set
7234         general thread instead of to 'magic_null_ptid'.
7235
7236 2018-01-10  Pedro Alves  <palves@redhat.com>
7237
7238         * language.h (language_get_symbol_name_matcher): Rename ...
7239         (get_symbol_name_matcher): ... this.
7240         * language.c (language_get_symbol_name_matcher): Ditto.
7241         * dictionary.c, linespec.c, minsyms.c, psymtab.c, symtab.c: All
7242         callers adjusted.
7243
7244 2018-01-10  Pedro Alves  <palves@redhat.com>
7245
7246         PR gdb/22670
7247         * dwarf2read.c
7248         (gdb_index_symbol_name_matcher::gdb_index_symbol_name_matcher):
7249         Adjust to use language_get_symbol_name_matcher instead of
7250         language_defn::la_get_symbol_name_matcher.
7251         * language.c (language_get_symbol_name_matcher): If in Ada mode
7252         and the lookup name is a verbatim match, return Ada's matcher.
7253         * language.h (language_get_symbol_name_matcher): Adjust comment.
7254         (ada_lookup_name_info::verbatim_p):: New method.
7255
7256 2018-01-10  Pedro Alves  <palves@redhat.com>
7257
7258         PR gdb/22670
7259         * ada-lang.c (ada_collect_symbol_completion_matches): If the
7260         minsym's language is language_auto or language_cplus, pass down
7261         language_ada instead.
7262         * symtab.c (compare_symbol_name): Don't frob symbol language here.
7263
7264 2018-01-10  Pedro Alves  <palves@redhat.com>
7265
7266         PR gdb/22670
7267         * minsyms.c (linkage_name_str): New function.
7268         (iterate_over_minimal_symbols): Use it.
7269
7270 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
7271
7272         * NEWS: Document that 'info proc' now works on FreeBSD.
7273
7274 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
7275
7276         * configure.ac: Check for kinfo_getfile in libutil.
7277         * configure: Regenerate.
7278         * config.in: Regenerate.
7279         * fbsd-nat.c: Include "fbsd-tdep.h".
7280         (fbsd_fetch_cmdline): New.
7281         (fbsd_fetch_kinfo_proc): Move earlier and change to return a bool
7282         rather than calling error.
7283         (fbsd_info_proc): New.
7284         (fbsd_thread_name): Report error if fbsd_fetch_kinfo_proc fails.
7285         (fbsd_wait): Report warning if fbsd_fetch_kinfo_proc fails.
7286         (fbsd_nat_add_target): Set "to_info_proc" to "fbsd_info_proc".
7287
7288 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
7289
7290         * fbsd-nat.c (struct free_deleter): Remove.
7291         (fbsd_find_memory_regions): Use gdb::unique_xmalloc_ptr<>.
7292
7293 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
7294
7295         * fbsd-nat.c (fbsd_pid_to_exec_file) [KERN_PROC_PATHNAME]: Return
7296         NULL for an empty pathname.
7297
7298 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
7299
7300         * fbsd-tdep.c (KVE_STRUCTSIZE, KVE_START, KVE_END, KVE_OFFSET)
7301         (KVE_FLAGS, KVE_PROTECTION, KVE_PATH, KINFO_VME_PROT_READ)
7302         (KINFO_VME_PROT_WRITE, KINFO_VME_PROT_EXEC, KINFO_VME_FLAG_COW)
7303         (KINFO_VME_FLAG_NEEDS_COPY, KINFO_VME_FLAG_NOCOREDUMP)
7304         (KINFO_VME_FLAG_SUPER, KINFO_VME_FLAG_GROWS_UP)
7305         (KINFO_VME_FLAG_GROWS_DOWN, KF_STRUCTSIZE, KF_TYPE, KF_FD)
7306         (KF_PATH, KINFO_FILE_TYPE_VNODE, KINFO_FILE_FD_TYPE_CWD)
7307         (KINFO_FILE_FD_TYPE_TEXT, SIG_WORDS, struct kinfo_proc_layout)
7308         (kinfo_proc_layout_32, kinfo_proc_layout_i386)
7309         (kinfo_proc_layout_64, fbsd_vm_map_entry_flags)
7310         (fbsd_core_info_proc_mappings, fbsd_core_vnode_path)
7311         (fbsd_core_fetch_timeval, fbsd_print_sigset)
7312         (fbsd_core_info_proc_status, fbsd_core_info_proc): New.
7313         (fbsd_init_abi):  Install gdbarch "core_info_proc" method.
7314         * fbsd-tdep.h (fbsd_vm_map_entry_flags): New.
7315
7316 2018-01-08  Samuel Thibault  <samuel.thibault@ens-lyon.org>
7317
7318         * gdb/gnu-nat.c: Include <elf.h> and <link.h>.
7319         (gnu_xfer_auxv): New function.
7320         (gnu_xfer_partial): Call gnu_xfer_auxv when `object' is
7321         TARGET_OBJECT_AUXV.
7322
7323 2018-01-08  Yao Qi  <yao.qi@linaro.org>
7324             Simon Marchi  <simon.marchi@ericsson.com>
7325
7326         * Makefile.in (COMMON_SFILES): Remove selftest-arch.c and
7327         common/selftest.c.
7328         (COMMON_OBS): Remove selftest.o.
7329         * configure.ac: Append selftest-arch.c and common/selftest.c to
7330         CONFIG_SRCS.  Append selftest-arch.o and selftest.o to COMMON_OBS.
7331         * configure: Re-generated.
7332         * maint.c (maintenance_selftest): Wrap selftests::run_tests with
7333         GDB_SELF_TEST.
7334         (maintenance_info_selftests): Likewise.
7335
7336 2018-01-08  Xavier Roirand  <roirand@adacore.com>
7337
7338         * ada-valprint.c (val_print_packed_array_elements): Use
7339         proper number of elements when printing an array indexed
7340         by an enumeration type.
7341
7342 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
7343
7344         * dwarf2read.c (struct dwarf2_cu) <dwarf2_per_objfile>: Remove.
7345         (dw2_get_file_names_reader): Adjust.
7346         (lookup_dwo_signatured_type): Adjust.
7347         (lookup_dwp_signatured_type): Adjust.
7348         (lookup_signatured_type): Adjust.
7349         (create_type_unit_group): Adjust.
7350         (get_type_unit_group): Adjust.
7351         (process_psymtab_comp_unit_reader): Adjust.
7352         (build_type_psymtabs_reader): Adjust.
7353         (scan_partial_symbols): Adjust.
7354         (add_partial_symbol): Adjust.
7355         (add_partial_subprogram): Adjust.
7356         (peek_die_abbrev): Adjust.
7357         (fixup_go_packaging): Adjust.
7358         (process_imported_unit_die): Adjust.
7359         (dwarf2_compute_name): Adjust.
7360         (dwarf2_physname): Adjust.
7361         (read_import_statement): Adjust.
7362         (handle_DW_AT_stmt_list): Adjust.
7363         (read_file_scope): Adjust.
7364         (read_func_scope): Adjust.
7365         (read_lexical_block_scope): Adjust.
7366         (read_call_site_scope): Adjust.
7367         (read_variable): Adjust.
7368         (dwarf2_rnglists_process): Adjust.
7369         (dwarf2_ranges_process): Adjust.
7370         (dwarf2_ranges_read): Adjust.
7371         (dwarf2_get_pc_bounds): Adjust.
7372         (dwarf2_record_block_ranges): Adjust.
7373         (dwarf2_add_field): Adjust.
7374         (dwarf2_add_member_fn): Adjust.
7375         (read_structure_type): Adjust.
7376         (process_structure_scope): Adjust.
7377         (read_enumeration_type): Adjust.
7378         (read_array_type): Adjust.
7379         (mark_common_block_symbol_computed): Adjust.
7380         (read_common_block): Adjust.
7381         (read_namespace_type): Adjust.
7382         (read_namespace): Adjust.
7383         (read_module_type): Adjust.
7384         (read_tag_pointer_type): Adjust.
7385         (read_tag_ptr_to_member_type): Adjust.
7386         (read_tag_string_type): Adjust.
7387         (read_subroutine_type): Adjust.
7388         (read_typedef): Adjust.
7389         (read_base_type): Adjust.
7390         (attr_to_dynamic_prop): Adjust.
7391         (read_subrange_type): Adjust.
7392         (read_unspecified_type): Adjust.
7393         (dwarf2_read_abbrevs): Adjust.
7394         (load_partial_dies): Adjust.
7395         (read_partial_die): Adjust.
7396         (find_partial_die): Adjust.
7397         (guess_partial_die_structure_name): Adjust.
7398         (fixup_partial_die): Adjust.
7399         (read_attribute_value): Adjust.
7400         (read_addr_index): Adjust.
7401         (read_addr_index_from_leb128): Adjust.
7402         (read_str_index): Adjust.
7403         (dwarf2_string_attr): Adjust.
7404         (get_debug_line_section): Adjust.
7405         (dwarf_decode_line_header): Adjust.
7406         (lnp_state_machine::check_line_address): Adjust.
7407         (dwarf_decode_lines_1): Adjust.
7408         (dwarf_decode_lines): Adjust.
7409         (dwarf2_start_symtab): Adjust.
7410         (var_decode_location): Adjust.
7411         (new_symbol_full): Adjust.
7412         (dwarf2_const_value_data): Adjust.
7413         (dwarf2_const_value_attr): Adjust.
7414         (dwarf2_const_value): Adjust.
7415         (die_type): Adjust.
7416         (die_containing_type): Adjust.
7417         (build_error_marker_type): Adjust.
7418         (lookup_die_type): Adjust.
7419         (guess_full_die_structure_name): Adjust.
7420         (anonymous_struct_prefix): Adjust.
7421         (determine_prefix): Adjust.
7422         (dwarf2_name): Adjust.
7423         (follow_die_ref_or_sig): Adjust.
7424         (follow_die_offset): Adjust.
7425         (follow_die_ref): Adjust.
7426         (follow_die_sig_1): Adjust.
7427         (follow_die_sig): Adjust.
7428         (get_signatured_type): Adjust.
7429         (get_DW_AT_signature_type): Adjust.
7430         (decode_locdesc): Adjust.
7431         (dwarf_decode_macros): Adjust.
7432         (cu_debug_loc_section): Adjust.
7433         (fill_in_loclist_baton): Adjust.
7434         (dwarf2_symbol_mark_computed): Adjust.
7435         (init_one_comp_unit): Don't assign
7436         dwarf2_cu::dwarf2_per_objfile.
7437         (set_die_type): Adjust.
7438
7439 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
7440
7441         * dwarf2read.c (struct mapped_debug_names): Add constructor.
7442         <dwarf2_per_objfile>: New field.
7443         (dwarf2_per_objfile): Remove global.
7444         (get_dwarf2_per_objfile): New function.
7445         (set_dwarf2_per_objfile): New function.
7446         (dwarf2_build_psymtabs_hard): Change objfile parameter to
7447         dwarf2_per_objfile.
7448         (abbrev_table_read_table): Add dwarf2_per_objfile parameter.
7449         (read_abbrev_offset): Likewise.
7450         (read_indirect_string): Likewise.
7451         (read_indirect_line_string): Likewise.
7452         (read_indirect_string_at_offset): Likewise.
7453         (read_indirect_string_from_dwz): Likewise.
7454         (dwarf2_find_containing_comp_unit): Change objfile parameter to
7455         dwarf2_per_objfile.
7456         (age_cached_comp_units): Add dwarf2_per_objfile parameter.
7457         (create_all_comp_units): Change objfile parameter to
7458         dwarf2_per_objfile.
7459         (create_all_type_units): Likewise.
7460         (process_queue): Add dwarf2_per_objfile parameter.
7461         (read_and_check_comp_unit_head): Likewise.
7462         (lookup_dwo_unit_in_dwp): Likewise.
7463         (get_dwp_file): Likewise.
7464         (process_cu_includes): Likewise.
7465         (struct free_dwo_file_cleanup_data): New struct.
7466         (dwarf2_has_info): Use get_dwarf2_per_objfile and
7467         set_dwarf2_per_objfile.
7468         (dwarf2_get_dwz_file): Add dwarf2_per_objfile parameter.
7469         (dw2_do_instantiate_symtab): Get dwarf2_per_objfile from
7470         context, adjust calls.
7471         (dw2_instantiate_symtab): Likewise.
7472         (dw2_get_cutu): Add dwarf2_per_objfile parameter.
7473         (dw2_get_cu): Likewise.
7474         (create_cu_from_index_list): Change objfile parameter to
7475         dwarf2_per_objfile.
7476         (create_cus_from_index_list): Get dwarf2_per_objfile from
7477         context, adjust calls.
7478         (create_cus_from_index): Likewise.
7479         (create_signatured_type_table_from_index): Change objfile
7480         parameter to dwarf2_per_objfile.
7481         (create_signatured_type_table_from_debug_names): Change objfile
7482         parameter to dwarf2_per_objfile.
7483         (create_addrmap_from_index): Likewise.
7484         (create_addrmap_from_aranges): Likewise.
7485         (dwarf2_read_index): Use get_dwarf2_per_objfile, adjust calls.
7486         (dw2_setup): Remove.
7487         (dw2_get_file_names_reader): Get dwarf2_per_objfile from
7488         context.
7489         (dw2_find_last_source_symtab): Get dwarf2_per_objfile using
7490         get_dwarf2_per_objfile.
7491         (dw2_forget_cached_source_info): Likewise.
7492         (dw2_map_symtabs_matching_filename): Likewise.
7493         (struct dw2_symtab_iterator) <index>: Remove.
7494         <dwarf2_per_objfile>: New field.
7495         (dw2_symtab_iter_init): Replace index parameter with
7496         dwarf2_per_objfile.
7497         (dw2_symtab_iter_next): Use dwarf2_per_objfile from iter.
7498         (dw2_lookup_symbol): Use get_dwarf2_per_objfile and adjust.
7499         (dw2_print_stats): Likewise.
7500         (dw2_dump): Likewise.
7501         (dw2_expand_symtabs_for_function): Likewise.
7502         (dw2_expand_all_symtabs): Likewise.
7503         (dw2_expand_symtabs_with_fullname): Likewise.
7504         (dw2_expand_marked_cus): Replace index and objfile parameters
7505         with dwarf2_per_objfile.
7506         (dw_expand_symtabs_matching_file_matcher): Add
7507         dwarf2_per_objfile parameter and adjust calls.
7508         (dw2_expand_symtabs_matching): Use get_dwarf2_per_objfile and
7509         adjust calls.
7510         (dw2_find_pc_sect_compunit_symtab): Don't call dw2_setup.
7511         (dw2_map_symbol_filenames): Use get_dwarf2_per_objfile and
7512         adjust calls.
7513         (create_cus_from_debug_names_list): Replace objfile parameter
7514         with dwarf2_per_objfile and adjust calls.
7515         (create_cus_from_debug_names): Likewise.
7516         (dwarf2_read_debug_names): Likewise.
7517         (mapped_debug_names::namei_to_name): Adjust call.
7518         (dw2_debug_names_iterator::next): Likewise.
7519         (dw2_debug_names_iterator::find_vec_in_debug_names): Likewise.
7520         (dw2_debug_names_lookup_symbol): Use get_dwarf2_per_objfile.
7521         (dw2_debug_names_dump): Likewise.
7522         (dw2_debug_names_expand_symtabs_for_function): Likewise.
7523         (dw2_debug_names_expand_symtabs_matching): Likewise.
7524         (dwarf2_initialize_objfile): Likewise.
7525         (dwarf2_build_psymtabs): Likewise.
7526         (get_abbrev_section_for_cu): Get dwarf2_per_objfile from
7527         this_cu.
7528         (error_check_comp_unit_head): Add dwarf2_per_objfile parameter.
7529         (read_and_check_comp_unit_head): Likewise.
7530         (read_abbrev_offset): Likewise.
7531         (create_debug_type_hash_table): Likewise.
7532         (create_debug_types_hash_table): Likewise.
7533         (create_all_type_units): Replace objfile parameter with
7534         dwarf2_per_objfile.
7535         (add_type_unit): Add dwarf2_per_objfile parameter.
7536         (fill_in_sig_entry_from_dwo_entry): Replace objfile parameter
7537         with dwarf2_per_objfile.
7538         (lookup_dwo_signatured_type): Get dwarf2_per_objfile from cu.
7539         (lookup_dwp_signatured_type): Likewise.
7540         (lookup_signatured_type): Likewise.
7541         (read_cutu_die_from_dwo): Likewise.
7542         (init_tu_and_read_dwo_dies): Likewise.
7543         (init_cutu_and_read_dies): Likewise.
7544         (init_cutu_and_read_dies_no_follow): Likewise.
7545         (allocate_type_unit_groups_table): Add objfile parameter.
7546         (create_type_unit_group): Use dwarf2_per_objfile from cu.
7547         (get_type_unit_group): Likewise.
7548         (process_psymtab_comp_unit): Update call.
7549         (build_type_psymtabs_reader): Use dwarf2_per_objfile from cu.
7550         (build_type_psymtabs_1): Add dwarf2_per_objfile parameter.
7551         (print_tu_stats): Likewise.
7552         (build_type_psymtab_dependencies): Use dwarf2_per_objfile passed
7553         in void* parameter.
7554         (build_type_psymtabs): Change objfile parameter to
7555         dwarf2_per_objfile.
7556         (process_skeletonless_type_unit): Use dwarf2_per_objfile
7557         passed in void* parameter.
7558         (process_skeletonless_type_units): Change objfile parameter to
7559         dwarf2_per_objfile.
7560         (set_partial_user): Likewise.
7561         (dwarf2_build_psymtabs_hard): Likewise.
7562         (read_comp_units_from_section): Likewise.
7563         (create_all_comp_units): Likewise.
7564         (scan_partial_symbols): Update calls.
7565         (add_partial_symbol): Likewise.
7566         (dwarf2_read_symtab): Use get_dwarf2_per_objfile.
7567         (maybe_queue_comp_unit): Use dwarf2_read_symtab from cu.
7568         (process_queue): Add dwarf2_per_objfile parameter.
7569         (get_compunit_symtab): Use dwarf2_per_objfile from cu.
7570         (compute_compunit_symtab_includes): Likewise.
7571         (process_cu_includes): Add dwarf2_per_objfile parameter.
7572         (process_full_comp_unit): Use dwarf2_per_objfile from cu.
7573         (process_full_type_unit): Likewise.
7574         (process_imported_unit_die): Update call.
7575         (handle_DW_AT_stmt_list): Use dwarf2_per_objfile from cu.
7576         (read_file_scope): Likewise.
7577         (allocate_dwo_file_hash_table): Add objfile parameter.
7578         (lookup_dwo_file_slot): Add dwarf2_per_objfile parameter.
7579         (create_cus_hash_table): Likewise.
7580         (create_dwp_hash_table): Likewise.
7581         (create_dwo_unit_in_dwp_v1): Likewise.
7582         (create_dwp_v2_section): Likewise.
7583         (create_dwo_unit_in_dwp_v2): Likewise.
7584         (lookup_dwo_unit_in_dwp): Likewise.
7585         (try_open_dwop_file): Likewise.
7586         (open_dwo_file): Likewise. Use dwarf2_per_objfile from cu.
7587         (open_and_init_dwo_file): Use dwarf2_per_objfile from cu, update
7588         cleanup to include a reference to dwarf2_per_objfile.
7589         (open_dwp_file): Add dwarf2_per_objfile parameter.
7590         (open_and_init_dwp_file): Likewise.
7591         (get_dwp_file): Likewise.
7592         (lookup_dwo_cutu): Use dwarf2_per_objfile from cu.
7593         (queue_and_load_all_dwo_tus): Update call.
7594         (free_dwo_file_cleanup): Use dwarf2_per_objfile from cleanup
7595         data.
7596         (dwarf2_rnglists_process): Use dwarf2_per_objfile from cu.
7597         (dwarf2_ranges_process): Likewise.
7598         (dwarf2_get_pc_bounds): Likewise.
7599         (mark_common_block_symbol_computed): Likewise.
7600         (abbrev_table_read_table): Add dwarf2_per_objfile parameter.
7601         (dwarf2_read_abbrevs): Update call.
7602         (read_partial_die): Use dwarf2_per_objfile from cu.
7603         (find_partial_die): Likewise.
7604         (fixup_partial_die): Likewise.
7605         (read_attribute_value): Likewise.
7606         (read_indirect_string_at_offset_from): Add objfile parameter.
7607         (read_indirect_string_at_offset): Add dwarf2_per_objfile
7608         parameter.
7609         (read_indirect_string_from_dwz): Add objfile parameter.
7610         (read_indirect_string): Add objfile parameter.
7611         (read_addr_index_1): Add dwarf2_per_objfile parameter.
7612         (read_addr_index): Use dwarf2_per_objfile from cu.
7613         (dwarf2_read_addr_index): Use dwarf2_per_objfile from cu, don't
7614         call dw2_setup.
7615         (read_str_index): Use dwarf2_per_objfile from cu.
7616         (get_debug_line_section): Likewise.
7617         (read_formatted_entries): Add dwarf2_per_objfile parameter.
7618         (dwarf_decode_line_header): Use dwarf2_per_objfile from cu.
7619         (new_symbol_full): Use dwarf2_per_objfile from cu.
7620         (build_error_marker_type): Likewise.
7621         (lookup_die_type): Likewise.
7622         (determine_prefix): Likewise.
7623         (follow_die_offset): Likewise.
7624         (dwarf2_fetch_die_loc_sect_off): Use get_dwarf2_per_objfile.
7625         (dwarf2_fetch_constant_bytes): Don't call dw2_setup.
7626         (dwarf2_fetch_die_type_sect_off): Likewise.
7627         (dwarf2_get_die_type): Likewise.
7628         (follow_die_sig_1): Use dwarf2_per_objfile from cu.
7629         (get_signatured_type): Likewise.
7630         (get_DW_AT_signature_type): Likewise.
7631         (dwarf_decode_macro_bytes): Add dwarf2_per_objfile parameter.
7632         (dwarf_decode_macros): Use dwarf2_per_objfile from cu.
7633         (cu_debug_loc_section): Likewise.
7634         (fill_in_loclist_baton): Likewise.
7635         (dwarf2_symbol_mark_computed): Likewise.
7636         (dwarf2_find_containing_comp_unit): Change objfile parameter to
7637         dwarf2_per_objfile.
7638         (free_cached_comp_units): Use dwarf2_per_objfile passed in void*
7639         parameter.
7640         (age_cached_comp_units): Add dwarf2_per_objfile parameter.
7641         (free_one_cached_comp_unit): Use dwarf2_per_objfile from cu.
7642         (dwarf2_free_objfile): Use get_dwarf2_per_objfile.
7643         (set_die_type): Use dwarf2_free_objfile from cu.
7644         (get_die_type_at_offset): Likewise.
7645         (dwarf2_per_objfile_free): Don't assign global variable.
7646         (debug_names) <constructor>: Add dwarf2_per_objfile
7647         parameter, update m_debugstrlookup construction.
7648         (debug_names::debug_str_lookup): Add dwarf2_per_objfile
7649         parameter.
7650         <m_dwarf2_per_objfile>: New field.
7651         <lookup>: Use m_dwarf2_per_objfile.
7652         (check_dwarf64_offsets): Add dwarf2_per_objfile parameter.
7653         (psyms_seen_size): Likewise.
7654         (write_gdbindex): Replace objfile parameter with
7655         dwarf2_per_objfile.
7656         (write_debug_names): Likewise.
7657         (write_psymtabs_to_index): Likewise.
7658         (save_gdb_index_command): Use get_dwarf2_per_objfile, update
7659         calls.
7660
7661 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
7662
7663         * dwarf2read.c (struct dwarf2_cu) <objfile>: Remove.
7664         <dwarf2_per_objfile>: New field.
7665         (struct dwarf2_per_cu_data) <objfile>: Remove.
7666         <dwarf2_per_objfile>: New field.
7667         (create_cu_from_index_list): Assign dwarf2_per_objfile instead
7668         of objfile.
7669         (create_signatured_type_table_from_index): Likewise.
7670         (create_debug_type_hash_table): Likewise.
7671         (fill_in_sig_entry_from_dwo_entry): Likewise.
7672         (lookup_dwo_unit): Access objfile through dwarf2_per_objfile.
7673         (create_type_unit_group): Assign dwarf2_per_objfile instead of
7674         objfile.
7675         (create_partial_symtab): Access objfile through
7676         dwarf2_per_objfile.
7677         (process_psymtab_comp_unit_reader): Likewise.
7678         (read_comp_units_from_section): Likewise.
7679         (scan_partial_symbols): Likewise.
7680         (add_partial_symbol): Likewise.
7681         (add_partial_subprogram): Likewise.
7682         (peek_die_abbrev): Likewise.
7683         (fixup_go_packaging): Likewise.
7684         (process_full_comp_unit): Likewise.
7685         (process_full_type_unit): Likewise.
7686         (process_imported_unit_die): Likewise.
7687         (dwarf2_compute_name): Likewise.
7688         (dwarf2_physname): Likewise.
7689         (read_import_statement): Likewise.
7690         (create_cus_hash_table): Assign dwarf2_physname instead of
7691         objfile.
7692         (read_func_scope): Access objfile through dwarf2_per_objfile.
7693         (read_lexical_block_scope): Likewise.
7694         (read_call_site_scope): Likewise.
7695         (read_variable): Likewise.
7696         (dwarf2_rnglists_process): Likewise.
7697         (dwarf2_ranges_process): Likewise.
7698         (dwarf2_ranges_read): Likewise.
7699         (dwarf2_record_block_ranges): Likewise.
7700         (dwarf2_add_field): Likewise.
7701         (dwarf2_add_member_fn): Likewise.
7702         (read_structure_type): Likewise.
7703         (process_structure_scope): Likewise.
7704         (read_enumeration_type): Likewise.
7705         (read_array_type): Likewise.
7706         (read_common_block): Likewise.
7707         (read_namespace_type): Likewise.
7708         (read_namespace): Likewise.
7709         (read_module_type): Likewise.
7710         (read_tag_pointer_type): Likewise.
7711         (read_tag_ptr_to_member_type): Likewise.
7712         (read_tag_string_type): Likewise.
7713         (read_subroutine_type): Likewise.
7714         (read_typedef): Likewise.
7715         (read_base_type): Likewise.
7716         (attr_to_dynamic_prop): Likewise.
7717         (read_subrange_type): Likewise.
7718         (read_unspecified_type): Likewise.
7719         (load_partial_dies): Likewise.
7720         (read_partial_die): Likewise.
7721         (find_partial_die): Likewise.
7722         (guess_partial_die_structure_name): Likewise.
7723         (fixup_partial_die): Likewise.
7724         (read_attribute_value): Likewise.
7725         (read_addr_index_from_leb128): Likewise.
7726         (dwarf2_read_addr_index): Likewise.
7727         (dwarf2_string_attr): Likewise.
7728         (lnp_state_machine::check_line_address): Likewise.
7729         (dwarf_decode_lines_1): Likewise.
7730         (dwarf_decode_lines): Likewise.
7731         (dwarf2_start_symtab): Likewise.
7732         (var_decode_location): Likewise.
7733         (new_symbol_full): Likewise.
7734         (dwarf2_const_value_data): Likewise.
7735         (dwarf2_const_value_attr): Likewise.
7736         (dwarf2_const_value): Likewise.
7737         (die_type): Likewise.
7738         (die_containing_type): Likewise.
7739         (lookup_die_type): Likewise.
7740         (guess_full_die_structure_name): Likewise.
7741         (anonymous_struct_prefix): Likewise.
7742         (dwarf2_name): Likewise.
7743         (follow_die_ref_or_sig): Likewise.
7744         (follow_die_offset): Likewise.
7745         (follow_die_ref): Likewise.
7746         (dwarf2_fetch_die_loc_sect_off): Likewise.
7747         (dwarf2_fetch_constant_bytes): Likewise.
7748         (dwarf2_fetch_die_type_sect_off): Likewise.
7749         (dwarf2_get_die_type): Likewise.
7750         (follow_die_sig): Likewise.
7751         (decode_locdesc): Likewise.
7752         (dwarf2_per_cu_objfile): Likewise.
7753         (dwarf2_per_cu_text_offset): Likewise.
7754         (init_one_comp_unit): Assign dwarf2_per_objfile instead of
7755         objfile.
7756         (set_die_type): Access objfile through
7757         dwarf2_per_objfile.
7758
7759 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
7760
7761         * valprint.c (converted_character_d): Remove typedef.
7762         (DEF_VEC_O (converted_character_d)): Remove.
7763         (count_next_character): Use std::vector.
7764         (print_converted_chars_to_obstack): Likewise.
7765         (generic_printstr): Likewise.
7766
7767 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
7768
7769         * xml-support.h (struct gdb_xml_value): Add constructor.
7770         <value>: Change type to unique_xmalloc_ptr.
7771         (gdb_xml_value_s): Remove typedef.
7772         (DEF_VEC_O (gdb_xml_value_s)): Remove.
7773         (gdb_xml_element_start_handler): Change parameter type to
7774         std::vector.
7775         (xml_find_attribute): Likewise.
7776         * xml-support.c (xml_find_attribute): Change parameter type to
7777         std::vector and adjust.
7778         (gdb_xml_values_cleanup): Remove.
7779         (gdb_xml_parser::start_element): Adjust to std::vector.
7780         (xinclude_start_include): Change paraeter type to std::vector
7781         and adjust.
7782         * btrace.c (check_xml_btrace_version): Likewise.
7783         (parse_xml_btrace_block): Likewise.
7784         (parse_xml_btrace_pt_config_cpu): Likewise.
7785         (parse_xml_btrace_pt): Likewise.
7786         (parse_xml_btrace_conf_bts): Likewise.
7787         (parse_xml_btrace_conf_pt): Likewise.
7788         * memory-map.c (memory_map_start_memory): Likewise.
7789         (memory_map_start_property): Likewise.
7790         * osdata.c (osdata_start_osdata): Likewise.
7791         (osdata_start_item): Likewise.
7792         (osdata_start_column): Likewise.
7793         * remote.c (start_thread): Likewise.
7794         * solib-aix.c (library_list_start_library): Likewise.
7795         (library_list_start_list): Likewise.
7796         * solib-svr4.c (library_list_start_library): Likewise.
7797         (svr4_library_list_start_list): Likewise.
7798         * solib-target.c (library_list_start_segment): Likewise.
7799         (library_list_start_section): Likewise.
7800         (library_list_start_library): Likewise.
7801         (library_list_start_list): Likewise.
7802         * tracepoint.c (traceframe_info_start_memory): Likewise.
7803         (traceframe_info_start_tvar): Likewise.
7804         * xml-syscall.c (syscall_start_syscall): Likewise.
7805         * xml-tdesc.c (tdesc_start_target): Likewise.
7806         (tdesc_start_feature): Likewise.
7807         (tdesc_start_reg): Likewise.
7808         (tdesc_start_union): Likewise.
7809         (tdesc_start_struct): Likewise.
7810         (tdesc_start_flags): Likewise.
7811         (tdesc_start_enum): Likewise.
7812         (tdesc_start_field): Likewise.
7813         (tdesc_start_enum_value): Likewise.
7814         (tdesc_start_vector): Likewise.
7815
7816 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
7817
7818         * extension.h (struct xmethod_worker) <clone>: Remove.
7819         * python/py-xmethods.c (struct python_xmethod_worker) <clone>:
7820         Remove.
7821         (python_xmethod_worker::clone): Remove.
7822         * valops.c (find_overload_match): Use std::move instead of
7823         clone.
7824
7825 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
7826
7827         * extension-priv.h (enum ext_lang_rc): Remove, move to extension.h.
7828         (struct extension_language_ops) <clone_xmethod_worker_data>: Remove.
7829         <free_xmethod_worker_data>: Remove.
7830         <get_matching_xmethod_workers>: Chance VEC to std::vector.
7831         <get_xmethod_arg_types>: Remove.
7832         <get_xmethod_result_type>: Remove.
7833         <invoke_xmethod>: Remove.
7834         * extension.c (new_xmethod_worker): Remove.
7835         (clone_xmethod_worker): Remove.
7836         (get_matching_xmethod_workers): Return void, pass std::vector by
7837         pointer.
7838         (get_xmethod_arg_types): Rename to...
7839         (xmethod_worker::get_arg_types): ... this, and adjust.
7840         (get_xmethod_result_type): Rename to...
7841         (xmethod_worker::get_result_type): ... this, and adjust.
7842         (invoke_xmethod): Remove.
7843         (free_xmethod_worker): Remove.
7844         (free_xmethod_worker_vec): Remove.
7845         * extension.h (enum ext_lang_rc): Move here from
7846         extension-priv.h.
7847         (struct xmethod_worker): Add constructor and destructor.
7848         <data>: Remove.
7849         <value>: Remove.
7850         <invoke, clone, do_get_result_type, do_get_arg_types>: New
7851         virtual pure methods.
7852         <get_arg_types, get_result_type>: New methods.
7853         (xmethod_worker_ptr): Remove typedef.
7854         (DEF_VEC_P (xmethod_worker_ptr)): Remove.
7855         (xmethod_worker_vec): Remove typedef.
7856         (xmethod_worker_up): New typedef.
7857         (invoke_xmethod): Remove.
7858         (clone_xmethod_worker): Remove.
7859         (free_xmethod_worker): Remove.
7860         (free_xmethod_worker_vec): Remove.
7861         (get_xmethod_arg_types): Remove.
7862         (get_xmethod_result_type): Remove.
7863         * valops.c (find_method_list): Use std::vector, don't use
7864         intermediate vector.
7865         (value_find_oload_method_list): Use std::vector.
7866         (find_overload_match): Use std::vector.
7867         (find_oload_champ): Use std::vector.
7868         * value.c (value_free): Use operator delete.
7869         (value_of_xmethod): Rename to...
7870         (value_from_xmethod): ... this.  Don't assign
7871         xmethod_worker::value, take rvalue-reference.
7872         (result_type_of_xmethod): Adjust.
7873         (call_xmethod): Adjust.
7874         * value.h: Include extension.h.
7875         (struct xmethod_worker): Don't forward-declare.
7876         (value_of_xmethod): Rename to...
7877         (value_from_xmethod): ... this, take rvalue-reference.
7878         * python/py-xmethods.c (struct gdbpy_worker_data): Rename to...
7879         (struct python_xmethod_worker): ... this, add constructor and
7880         destructor.
7881         <invoke, clone, do_get_arg_types, do_get_result_type>: Implement.
7882         (gdbpy_free_xmethod_worker_data): Rename to...
7883         (python_xmethod_worker::~python_xmethod_worker): ... this and
7884         adjust.
7885         (gdbpy_clone_xmethod_worker_data): Rename to...
7886         (python_xmethod_worker::clone): ... this and adjust.
7887         (gdbpy_get_matching_xmethod_workers): Use std::vector, don't use
7888         temporary vector.
7889         (gdbpy_get_xmethod_arg_types): Rename to...
7890         (python_xmethod_worker::do_get_arg_types): ... this and adjust.
7891         (gdbpy_get_xmethod_result_type): Rename to...
7892         (python_xmethod_worker::do_get_result_type): ... this and
7893         adjust.
7894         (gdbpy_invoke_xmethod): Rename to...
7895         (python_xmethod_worker::invoke): ... this and adjust.
7896         (new_python_xmethod_worker): Rename to...
7897         (python_xmethod_worker::python_xmethod_worker): ... this and
7898         adjust.
7899         * python/python-internal.h (gdbpy_clone_xmethod_worker_data):
7900         Remove.
7901         (gdbpy_free_xmethod_worker_data): Remove.
7902         (gdbpy_get_matching_xmethod_workers): Use std::vector.
7903         (gdbpy_get_xmethod_arg_types): Remove.
7904         (gdbpy_get_xmethod_result_type): Remove.
7905         (gdbpy_invoke_xmethod): Remove.
7906         * python/python.c (python_extension_ops): Remove obsolete
7907         callbacks.
7908
7909 2018-01-05  Pedro Alves  <palves@redhat.com>
7910
7911         PR gdb/18653
7912         * common/signals-state-save-restore.c
7913         (save_original_signals_state): New parameter 'quiet'.  Warn if we
7914         find a custom handler preinstalled, instead of internal erroring.
7915         But only warn if !quiet.
7916         * common/signals-state-save-restore.h
7917         (save_original_signals_state): New parameter 'quiet'.
7918         * main.c (captured_main_1): Move save_original_signals_state call
7919         after option handling, and pass QUIET.
7920
7921 2018-01-05  Pedro Alves  <palves@redhat.com>
7922
7923         * spu-tdep.c (spu_catch_start): Pass
7924         symbol_name_match_type::SEARCH_NAME to block_lookup_symbol.
7925
7926 2018-01-05  Pedro Alves  <palves@redhat.com>
7927
7928         PR gdb/22670
7929         * ada-lang.c (literal_symbol_name_matcher): New function.
7930         (ada_get_symbol_name_matcher): Use it for
7931         symbol_name_match_type::SEARCH_NAME.
7932         * block.c (block_lookup_symbol): New parameter 'match_type'.  Pass
7933         it down instead of assuming symbol_name_match_type::FULL.
7934         * block.h (block_lookup_symbol): New parameter 'match_type'.
7935         * c-valprint.c (print_unpacked_pointer): Use
7936         lookup_symbol_search_name instead of lookup_symbol.
7937         * compile/compile-object-load.c (get_out_value_type): Pass down
7938         symbol_name_match_type::SEARCH_NAME.
7939         * cp-namespace.c (cp_basic_lookup_symbol): Pass down
7940         symbol_name_match_type::FULL.
7941         * cp-support.c (cp_get_symbol_name_matcher): Handle
7942         symbol_name_match_type::SEARCH_NAME.
7943         * infrun.c (insert_exception_resume_breakpoint): Use
7944         lookup_symbol_search_name.
7945         * p-valprint.c (pascal_val_print): Use lookup_symbol_search_name.
7946         * psymtab.c (maintenance_check_psymtabs): Use
7947         symbol_name_match_type::SEARCH_NAME and SYMBOL_SEARCH_NAME.
7948         * stack.c (print_frame_args): Use lookup_symbol_search_name and
7949         SYMBOL_SEARCH_NAME.
7950         * symtab.c (lookup_local_symbol): Don't demangle the lookup name
7951         if symbol_name_match_type::SEARCH_NAME.
7952         (lookup_symbol_in_language): Pass down
7953         symbol_name_match_type::FULL.
7954         (lookup_symbol_search_name): New.
7955         (lookup_language_this): Pass down
7956         symbol_name_match_type::SEARCH_NAME.
7957         (lookup_symbol_aux, lookup_local_symbol): New parameter
7958         'match_type'.  Pass it down.
7959         * symtab.h (symbol_name_match_type::SEARCH_NAME): New enumerator.
7960         (lookup_symbol_search_name): New declaration.
7961         (lookup_symbol_in_block): New 'match_type' parameter.
7962
7963 2018-01-05  Pedro Alves  <palves@redhat.com>
7964
7965         PR gdb/22670
7966         * ada-lang.c (ada_lookup_encoded_symbol): Reimplement in terms of
7967         ada_lookup_symbol.
7968         (ada_lookup_symbol): Reimplement in terms of
7969         ada_lookup_symbol_list, bits factored out from
7970         ada_lookup_encoded_symbol.
7971
7972 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
7973
7974         * ada-exp.y (write_object_renaming): When subscripting an array
7975         using a symbol as the index, pass the block in call to
7976         ada_lookup_encoded_symbol when looking that symbol up.
7977
7978 2018-01-05  Jerome Guitton  <guitton@adacore.com>
7979
7980         * ada-lang.c (ada_array_length): Use ada_index_type instead of
7981         TYPE_INDEX_TYPE.
7982
7983 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
7984
7985         * ada-lang.c (ada_to_fixed_value_create): Add handling of
7986         the case where VALUE_LVAL (val0) is not lval_memory.
7987
7988 2018-01-05  Xavier Roirand  <roirand@adacore.com>
7989
7990         * ada-valprint.c (print_optional_low_bound): Handle
7991         character-indexed array printing like boolean-indexed array
7992         printing.
7993
7994 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
7995
7996         * NEWS: Create a new section for the next release branch.
7997         Rename the section of the current branch, now that it has
7998         been cut.
7999
8000 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
8001
8002         GDB 8.1 branch created (5219ac6237c272b938c28517bf371429260c71e7):
8003         * version.in: Bump version to 8.1.50.DATE-git.
8004
8005 2018-01-03  Xavier Roirand  <roirand@adacore.com>
8006
8007         * ada-lang.h (ada_exception_catchpoint_kind) <ada_catch_handlers>:
8008         Add field.
8009         * ada-lang.c (struct exception_support_info) <catch_handlers_sym>:
8010         Add field.
8011         (default_exception_support_info) <catch_handlers_sym>: Add field.
8012         (exception_support_info_fallback) <catch_handlers_sym>: Add field.
8013         (ada_exception_name_addr_1): Add "catch handlers" handling.
8014         (ada_exception_catchpoint_cond_string) <ex>: New parameter.
8015         Update all callers.
8016         (create_excep_cond_exprs) <ex>: Add parameter.
8017         (re_set_exception): Update create_excep_cond_exprs call.
8018         (print_it_exception, print_one_exception, print_mention_exception)
8019         (print_recreate_exception): Add "catch handler" handling.
8020         (allocate_location_catch_handlers, re_set_catch_handlers)
8021         (check_status_catch_handlers, print_it_catch_handlers)
8022         (print_one_catch_handlers, print_mention_catch_handlers)
8023         (print_recreate_catch_handlers): New function.
8024         (catch_handlers_breakpoint_ops): New variable.
8025         (catch_ada_exception_command_split) <is_catch_handlers_cmd>:
8026         Add parameter.  Add "catch handler" handling.
8027         (ada_exception_sym_name, ada_exception_breakpoint_ops):
8028         Add "catch handler" handling.
8029         (ada_exception_catchpoint_cond_string): Add "catch handler"
8030         handling.
8031         (create_ada_exception_catchpoint): Update create_excep_cond_exprs
8032         call.
8033         (catch_ada_handlers_command): New function.
8034         (initialize_ada_catchpoint_ops): Initialize "catch handlers"
8035         operations structure.
8036         (_initialize_ada_language): Add "catch handlers" command entry.
8037         * NEWS: Document "catch handlers" feature.
8038
8039 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
8040
8041         * ada-lang.c (ada_value_slice_from_ptr): Take array stride into
8042         account when creating the array type of the slice.
8043         (ada_value_slice): Likewise.
8044
8045 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
8046
8047         * gdbtypes.h (enum dynamic_prop_node_kind) <DYN_PROP_BYTE_STRIDE>:
8048         New enum value.
8049         (create_array_type_with_stride): Add byte_stride_prop parameter.
8050         * gdbtypes.c (create_array_type_with_stride) <byte_stride_prop>:
8051         New parameter.  Update all callers in this file.
8052         (array_type_has_dynamic_stride): New function.
8053         (is_dynamic_type_internal, resolve_dynamic_array): Add handling
8054         of arrays with dynamic byte strides.
8055         * dwarf2read.c (read_array_type): Add support for dynamic
8056         DW_AT_byte_stride attributes.
8057
8058 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
8059
8060         * dwarf2read.c (read_unspecified_type): Treat
8061         DW_TAG_enumeration_type DIEs from Ada units as stubs.
8062
8063 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
8064
8065         Update copyright year range in all GDB files.
8066
8067 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
8068
8069         * copyright.py (BY_HAND): Remove gdb/testsuite/gdb.base/step-line.inp
8070         and gdb/testsuite/gdb.base/step-line.c.
8071
8072 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
8073
8074         * copyright.py (main): Dump the contents of
8075         MULTIPLE_COPYRIGHT_HEADERS (separately) from BY_HAND,
8076         even if BY_HAND is empty.
8077
8078 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
8079
8080         * top.c (print_gdb_version): Update Copyright year in version
8081         message.
8082
8083 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
8084
8085         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2017.
8086
8087 For older changes see ChangeLog-2017.
8088 \f
8089 Local Variables:
8090 mode: change-log
8091 left-margin: 8
8092 fill-column: 74
8093 version-control: never
8094 coding: utf-8
8095 End: