gdb/ChangeLog

   1 2019-07-02  Pedro Alves  <palves@redhat.com>
   2
   3         * NEWS (Completion improvements): Mention "info threads".
   4         * thread.c (struct info_threads_opts, info_threads_option_defs)
   5         (make_info_threads_options_def_group): New.
   6         (info_threads_command): Use gdb::option::process_options.
   7         (info_threads_command_completer): New.
   8         (_initialize_thread): Use gdb::option::build_help to build the
   9         help text for "info threads".
  10
  11 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
  12
  13         * defs.h (generic_load): Move from here...
  14         * symfile.h (generic_load): ... to here.  Rename name parameter
  15         to args.
  16         * symfile.c (generic_load): Add comment.
  17
  18 2019-07-01  Tom Tromey  <tromey@adacore.com>
  19
  20         * dwarf2read.c
  21         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
  22         declaration of without_params.  Fix formatting.
  23
  24 2019-07-01  Tom Tromey  <tromey@adacore.com>
  25
  26         * ada-exp.y (find_primitive_type): Update.
  27         * ada-lang.h (ada_lookup_symbol): Update.
  28         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
  29         parameter.
  30         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
  31
  32 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
  33
  34         PR breakpoints/24541
  35         * gdbarch.c: Regenerate.
  36         * gdbarch.h: Regenerate.
  37         * gdbarch.sh: Add 'stap_adjust_register'.
  38         * i386-tdep.c: Include '<unordered_set>'.
  39         (i386_stap_adjust_register): New function.
  40         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
  41         * stap-probe.c (stap_parse_register_operand): Call
  42         'gdbarch_stap_adjust_register'.
  43
  44 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
  45
  46         PR python/24742
  47         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
  48         * python/python.c (do_start_initialization): Use 'xmalloc'
  49         instead of 'PyMem_Malloc'.
  50
  51 2019-06-28  Tom Tromey  <tromey@adacore.com>
  52
  53         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
  54         for Ada.
  55
  56 2019-06-27  Tom Tromey  <tromey@adacore.com>
  57
  58         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
  59         objfile_key.
  60         (arm_find_mapping_symbol, arm_record_special_symbol)
  61         (_initialize_arm_tdep): Update.
  62         (arm_objfile_data_free): Remove.
  63
  64 2019-06-27  Tom Tromey  <tromey@adacore.com>
  65
  66         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
  67         to cp_print_static_field.
  68
  69 2019-06-26  Tom Tromey  <tromey@adacore.com>
  70
  71         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
  72         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
  73         declare.
  74
  75 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
  76
  77         * features/aarch64-core.c (create_feature_aarch64_core):
  78         Regenerate.
  79         * features/aarch64-core.xml: Add cpsr flags.
  80
  81 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
  82
  83         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
  84         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
  85
  86 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
  87
  88         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
  89         field.
  90         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
  91         use.
  92         (arm_record_special_symbol): Don't insert new symbol in sorted
  93         position, push it at the end.
  94
  95 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
  96
  97         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
  98         (arm_mapping_symbol_s): Remove.
  99         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
 100         (arm_mapping_symbol_vec): New typedef.
 101         (struct arm_per_objfile): Add constructor.
 102         <section_maps>: Change type to
 103         std::unique_ptr<arm_mapping_symbol_vec[]>.
 104         (arm_compare_mapping_symbols): Remove.
 105         (arm_find_mapping_symbol): Adjust to section_maps type change.
 106         (arm_objfile_data_free): Call delete on arm_per_objfile.
 107         (arm_record_special_symbol): Adjust to section_maps type change.
 108         Allocate arm_per_objfile with new.
 109
 110 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 111
 112         * cli/cli-cmds.c (alias_command): Compare the alias prefix
 113         with the command prefix.
 114
 115 2019-06-25  Tom Tromey  <tom@tromey.com>
 116
 117         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
 118         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
 119
 120 2019-06-25  Tom Tromey  <tom@tromey.com>
 121
 122         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
 123         type.
 124         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
 125         protected.
 126
 127 2019-06-25  Tom Tromey  <tom@tromey.com>
 128
 129         * tui/tui-winsource.c
 130         (tui_source_window_base::set_is_exec_point_at): Add check against
 131         LOA_ADDRESS.
 132
 133 2019-06-25  Tom Tromey  <tom@tromey.com>
 134
 135         * tui/tui-source.c (tui_set_source_content): Don't check before
 136         xfree.
 137         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
 138
 139 2019-06-25  Tom Tromey  <tom@tromey.com>
 140
 141         * tui/tui-winsource.h (tui_update_source_window_as_is)
 142         (tui_alloc_source_buffer, tui_line_is_displayed)
 143         (tui_addr_is_displayed): Change type of win_info.
 144         * tui/tui-winsource.c (tui_update_source_window_as_is)
 145         (tui_clear_source_content, tui_show_source_line)
 146         (tui_show_source_content, tui_source_window_base::refill)
 147         (tui_source_window_base::set_is_exec_point_at)
 148         (tui_source_window_base::set_is_exec_point_at)
 149         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
 150         (tui_alloc_source_buffer, tui_line_is_displayed)
 151         (tui_addr_is_displayed): Change type of win_info.  Update.
 152         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 153         (tui_source_window_base::do_make_visible_with_new_height):
 154         Update.
 155         * tui/tui-source.c (tui_set_source_content)
 156         (tui_set_source_content_nil)
 157         (tui_source_window::do_scroll_vertical): Update.
 158         * tui/tui-layout.c (show_layout): Update.
 159         * tui/tui-disasm.c (tui_set_disassem_content)
 160         (tui_disasm_window::do_scroll_vertical): Update.
 161         * tui/tui-data.h (tui_win_content): Remove.
 162         (struct tui_gen_win_info) <content, content_size>: Remove.
 163         (struct tui_source_element): Add initializers and destructor.
 164         (union tui_which_element, struct tui_win_element): Remove.
 165         (struct tui_source_window_base) <content>: New field.
 166         (struct tui_data_window): Remove destructor.
 167         (tui_alloc_content, tui_free_win_content)
 168         (tui_free_all_source_wins_content): Don't declare.
 169         * tui/tui-data.c (tui_initialize_static_data): Update.
 170         (init_content_element, tui_alloc_content): Remove.
 171         (~tui_gen_win_info): Update.
 172         (~tui_data_window, tui_free_all_source_wins_content)
 173         (tui_free_win_content, free_content, free_content_elements):
 174         Remove.
 175
 176 2019-06-25  Tom Tromey  <tom@tromey.com>
 177
 178         * tui/tui-winsource.h (tui_clear_source_content)
 179         (tui_erase_source_content, tui_show_source_content): Change type
 180         of win_info.
 181         * tui/tui-winsource.c (tui_clear_source_content)
 182         (tui_erase_source_content, tui_show_source_content): Change type
 183         of win_info.
 184         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 185         * tui/tui-source.h (tui_set_source_content_nil): Change type of
 186         win_info.
 187         * tui/tui-source.c (tui_set_source_content_nil): Change type of
 188         win_info.
 189         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
 190
 191 2019-06-25  Tom Tromey  <tom@tromey.com>
 192
 193         * tui/tui-winsource.c (tui_clear_source_content)
 194         (tui_source_window_base::set_is_exec_point_at): Update.
 195         * tui/tui-source.c (tui_set_source_content_nil): Update.
 196         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
 197         a bool.
 198         * tui/tui-data.c (init_content_element): Update.
 199
 200 2019-06-25  Tom Tromey  <tom@tromey.com>
 201
 202         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
 203         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
 204         * tui/tui-layout.c (init_and_make_win): Update.
 205         * tui/tui.h (enum tui_win_type): Update.
 206         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
 207         tui_win_is_auxillary.
 208         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
 209         tui_win_is_auxillary.
 210
 211 2019-06-25  Tom Tromey  <tom@tromey.com>
 212
 213         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
 214         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
 215         (tui_delete_data_content_windows, tui_display_all_data)
 216         (tui_data_window::do_scroll_vertical, tui_display_data_from):
 217         Update.
 218         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
 219         * tui/tui-regs.c (tui_last_regs_line_no)
 220         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 221         (tui_show_registers): Update.
 222         (tui_show_register_group): Return void.  Update.
 223         (tui_display_registers_from, tui_display_reg_element_at_line)
 224         (tui_display_registers_from_line, tui_check_register_values):
 225         Update.
 226         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
 227         member.
 228         (struct tui_data_window) <regs_content>: Now a std::vector.
 229         <regs_content_count>: Remove.
 230         (tui_add_content_elements, tui_free_data_content): Don't declare.
 231         * tui/tui-data.c (tui_data_window::clear_detail): Update.
 232         (init_content_element): Remove DATA_WIN case.  Add assert.
 233         (tui_add_content_elements): Remove.
 234         (tui_data_window): Update.
 235         (tui_free_data_content): Remove.
 236         (free_content_elements): Remove DATA_WIN case.
 237
 238 2019-06-25  Tom Tromey  <tom@tromey.com>
 239
 240         * tui/tui-data.c (tui_data_item_window): Update.
 241         * tui/tui-windata.h (tui_check_data_values): Don't declare.
 242         * tui/tui-windata.c (tui_display_all_data)
 243         (tui_display_data_from_line): Update.
 244         (tui_check_data_values): Remove.
 245         * tui/tui-regs.c (tui_show_register_group)
 246         (tui_display_reg_element_at_line): Update.
 247         * tui/tui-hooks.c (tui_register_changed)
 248         (tui_refresh_frame_and_register_information): Call
 249         tui_check_register_values.
 250         * tui/tui-data.h (struct tui_data_window) <data_content,
 251         data_content_count, data_type>: Remove.
 252         (enum tui_data_type): Remove.
 253
 254         * tui/tui-data.c (tui_data_window::clear_detail)
 255         (~tui_data_window): Update.
 256
 257 2019-06-25  Tom Tromey  <tom@tromey.com>
 258
 259         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
 260         declare.
 261         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
 262         Rename from tui_first_data_item_displayed.  Update.
 263         (tui_data_window::refresh_all)
 264         (tui_data_window::do_scroll_vertical): Update.
 265         * tui/tui-data.h (struct tui_data_window)
 266         <first_data_item_displayed>: Declare new method.
 267
 268 2019-06-25  Tom Tromey  <tom@tromey.com>
 269
 270         * tui/tui-data.h (tui_init_generic_part): Don't declare.
 271         * tui/tui-data.c (tui_init_generic_part): Remove, moving
 272         contents...
 273         (tui_initialize_static_data): ...here.
 274
 275 2019-06-25  Tom Tromey  <tom@tromey.com>
 276
 277         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 278         (tui_display_registers_from, tui_check_register_values): Update.
 279         (tui_display_register): Remove win_info parameter; update.
 280         (tui_get_register): Change type of parameters.
 281         * tui/tui-data.h (struct tui_data_element): Remove.
 282         (union tui_which_element) <data>: Remove.
 283         <data_window>: Change type.
 284         (struct tui_data_item_window): New.
 285         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
 286         case.  Add assert.
 287         (~tui_data_item_window): New destructor.
 288         (free_content_elements): Remove DATA_ITEM_WIN case.
 289
 290 2019-06-25  Tom Tromey  <tom@tromey.com>
 291
 292         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
 293         Remove.
 294
 295 2019-06-25  Tom Tromey  <tom@tromey.com>
 296
 297         * tui/tui-data.h (struct tui_command_element): Remove.
 298         (union tui_which_element) <command>: Remove.
 299         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
 300         assert.
 301         (free_content_elements): Remove CMD_WIN case.
 302
 303 2019-06-25  Tom Tromey  <tom@tromey.com>
 304
 305         * tui/tui-layout.c (tui_set_layout): Update.
 306         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
 307         * tui/tui-data.c (layout_def): Update.
 308
 309 2019-06-25  Tom Tromey  <tom@tromey.com>
 310
 311         * tui/tui-wingeneral.c (tui_refresh_all): Update.
 312         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 313         (tui_source_window_base::set_new_height): Update.
 314         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
 315         Update.
 316         (tui_set_locator_fullname, tui_set_locator_info)
 317         (tui_show_frame_info): Update.
 318         * tui/tui-source.c (tui_set_source_content)
 319         (tui_source_is_displayed): Update.
 320         * tui/tui-layout.c (show_source_disasm_command, show_data)
 321         (show_source_or_disasm_and_command): Update.
 322         * tui/tui-disasm.c (tui_set_disassem_content)
 323         (tui_get_begin_asm_address): Update.
 324         * tui/tui-data.h (struct tui_locator_element): Remove.
 325         (union tui_which_element) <locator>: Remove.
 326         (struct tui_locator_window): New.
 327         (tui_locator_win_info_ptr): Change return type.
 328         * tui/tui-data.c (_locator): Change type.
 329         (tui_locator_win_info_ptr): Change return type.
 330         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
 331         (tui_alloc_content): Add assert.
 332
 333 2019-06-25  Tom Tromey  <tom@tromey.com>
 334
 335         * tui/tui-winsource.c
 336         (tui_exec_info_window::maybe_allocate_content): New method.
 337         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
 338         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
 339         (make_source_or_disasm_window): Add cast.
 340         * tui/tui-data.h (union tui_which_element) <simple_string>:
 341         Remove.
 342         (struct tui_source_info): New.
 343         (struct tui_source_window_base) <execution_info>: Change type.
 344         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
 345         case, and add assert.
 346         (tui_alloc_content): Add assert.
 347
 348 2019-06-25  Tom Tromey  <tom@tromey.com>
 349
 350         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
 351         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
 352         * tui/tui-data.c (tui_alloc_win_info): Remove.
 353
 354 2019-06-25  Tom Tromey  <tom@tromey.com>
 355
 356         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
 357         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
 358         can_highlight.
 359
 360 2019-06-25  Tom Tromey  <tom@tromey.com>
 361
 362         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
 363         make_visible_with_new_height method.
 364         (tui_win_info::make_visible_with_new_height): New method.
 365         (tui_source_window_base::do_make_visible_with_new_height)
 366         (tui_data_window::do_make_visible_with_new_height)
 367         (tui_cmd_window::do_make_visible_with_new_height): New methods.
 368         (make_visible_with_new_height): Remove.
 369         (tui_resize_all, tui_adjust_win_heights): Use
 370         make_visible_with_new_height method.
 371         * tui/tui-data.h (struct tui_win_info)
 372         <do_make_visible_with_new_height, make_visible_with_new_height>:
 373         New methods.
 374         (struct tui_source_window_base, struct tui_data_window)
 375         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
 376         methods.
 377
 378 2019-06-25  Tom Tromey  <tom@tromey.com>
 379
 380         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
 381         method.
 382         (update_tab_width): Call update_tab_width method.
 383         * tui/tui-data.h (struct tui_win_info)
 384         (struct tui_source_window_base) <update_tab_width>: New methods.
 385
 386 2019-06-25  Tom Tromey  <tom@tromey.com>
 387
 388         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
 389         parameter.
 390         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
 391         parameter.
 392         (tui_gen_win_info::make_visible): Update.
 393         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
 394         parameter.
 395         * tui/tui-data.h (enum tui_box): New enum.
 396         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
 397
 398 2019-06-25  Tom Tromey  <tom@tromey.com>
 399
 400         * tui/tui-layout.c (make_source_or_disasm_window): Always use
 401         init_and_make_win for EXEC_INFO_WIN.
 402         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
 403         longer inline.
 404         (struct tui_win_info) <~tui_win_info>: Inline.
 405         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 406         Don't declare.
 407         * tui/tui-data.c (source_win, disasm_win): Remove globals.
 408         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 409         Remove.
 410         (tui_initialize_static_data): Update.
 411         (~tui_gen_win_info): Handle more cleanup here.
 412         (~tui_source_window_base): Delete "execution_info".
 413         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
 414
 415 2019-06-25  Tom Tromey  <tom@tromey.com>
 416
 417         * tui/tui-layout.c (make_command_window): Don't set
 418         can_highlight.
 419         (show_source_disasm_command): Call the reset method.
 420         (show_data): Don't set can_highlight.  Call the reset method.
 421         (tui_gen_win_info::reset): Rename from init_gen_win_info
 422         (init_and_make_win): Simplify.  Return tui_gen_win_info.
 423         (show_source_or_disasm_and_command): Call the reset method.
 424         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
 425         (struct tui_cmd_window): Set can_highlight.
 426
 427 2019-06-25  Tom Tromey  <tom@tromey.com>
 428
 429         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
 430         from make_visible.
 431         (tui_make_visible, tui_make_invisible): Rewrite.
 432         (tui_win_info::make_visible): Remove.
 433         (tui_source_window_base::make_visible): Update.
 434         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
 435         method.  Moved from...
 436         (struct tui_win_info) <make_visible>: ...here.
 437
 438 2019-06-25  Tom Tromey  <tom@tromey.com>
 439
 440         * tui/tui-winsource.c
 441         (tui_source_window_base::do_scroll_horizontal): Remove direction
 442         parameter.
 443         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
 444         direction parameter.
 445         * tui/tui-win.c (tui_win_info::forward_scroll)
 446         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 447         (tui_win_info::right_scroll): Update.
 448         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
 449         direction parameter.
 450         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
 451         direction parameter.
 452         * tui/tui-data.h (enum tui_scroll_direction): Remove.
 453         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
 454         Remove direction parameter.
 455         (struct tui_source_window_base, struct tui_source_window)
 456         (struct tui_disasm_window, struct tui_data_window)
 457         (struct tui_cmd_window): Update.
 458
 459 2019-06-25  Tom Tromey  <tom@tromey.com>
 460
 461         * tui/tui-winsource.h (tui_set_exec_info_content)
 462         (tui_show_exec_info_content, tui_erase_exec_info_content)
 463         (tui_clear_exec_info_content, tui_update_exec_info): Change
 464         argument to tui_source_window_base.
 465         * tui/tui-winsource.c (tui_set_exec_info_content)
 466         (tui_show_exec_info_content, tui_erase_exec_info_content)
 467         (tui_clear_exec_info_content, tui_update_exec_info): Change
 468         argument to tui_source_window_base.
 469
 470 2019-06-25  Tom Tromey  <tom@tromey.com>
 471
 472         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
 473         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
 474
 475 2019-06-25  Tom Tromey  <tom@tromey.com>
 476
 477         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
 478         check.
 479
 480 2019-06-25  Tom Tromey  <tom@tromey.com>
 481
 482         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
 483         type to void.
 484         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
 485         type to void.
 486         * tui/tui-source.c (tui_set_source_content): Update.
 487         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 488
 489 2019-06-25  Tom Tromey  <tom@tromey.com>
 490
 491         * tui/tui-win.c (window_name_completer, tui_set_focus)
 492         (tui_all_windows_info): Use name method.
 493         * tui/tui-data.h (struct tui_gen_win_info)
 494         (struct tui_source_window, struct tui_disasm_window)
 495         (struct tui_data_window, struct tui_cmd_window) <name>: New
 496         method.
 497         (tui_win_name): Don't declare.
 498         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
 499         (tui_win_name): Remove.
 500
 501 2019-06-25  Tom Tromey  <tom@tromey.com>
 502
 503         * tui/tui-winsource.h (tui_update_source_window)
 504         (tui_update_source_window_as_is): Change parameter type.
 505         * tui/tui-winsource.c (tui_update_source_window): Change win_info
 506         to be a tui_source_window_base.
 507         (tui_update_source_window_as_is): Likewise.
 508         * tui/tui-win.c (make_visible_with_new_height): Update.
 509
 510 2019-06-25  Tom Tromey  <tom@tromey.com>
 511
 512         * tui/tui-winsource.c (tui_erase_source_content)
 513         (tui_show_source_content, tui_show_exec_info_content)
 514         (tui_erase_exec_info_content): Use refresh_window method.
 515         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
 516         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
 517         from tui_refresh_win.
 518         (tui_data_window::refresh_window): New method.
 519         (tui_win_info::refresh, tui_source_window_base::refresh)
 520         (tui_refresh_all): Use refresh_window method.
 521         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
 522         method.
 523         * tui/tui-regs.c (tui_display_register): Call refresh_window
 524         method.
 525         * tui/tui-layout.c (show_source_disasm_command)
 526         (show_source_or_disasm_and_command): Call refresh_window method.
 527         * tui/tui-data.h (struct tui_gen_win_info)
 528         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
 529         New method.
 530
 531 2019-06-25  Tom Tromey  <tom@tromey.com>
 532
 533         * tui/tui.c (tui_rl_other_window, tui_enable)
 534         (tui_is_window_visible, tui_get_command_dimension): Update.
 535         * tui/tui-winsource.c (tui_update_source_window_as_is)
 536         (tui_clear_source_content, tui_erase_source_content)
 537         (tui_show_source_line, tui_source_window_base::refill)
 538         (tui_source_window_base::do_scroll_horizontal)
 539         (tui_source_window_base::set_is_exec_point_at)
 540         (tui_update_breakpoint_info, tui_set_exec_info_content)
 541         (tui_alloc_source_buffer, tui_line_is_displayed)
 542         (tui_addr_is_displayed): Update.
 543         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 544         (tui_check_and_display_highlight_if_needed)
 545         (tui_win_info::make_visible, tui_win_info::refresh)
 546         (tui_refresh_all): Update.
 547         * tui/tui-windata.c (tui_first_data_item_displayed)
 548         (tui_delete_data_content_windows, tui_erase_data_content)
 549         (tui_display_all_data, tui_data_window::refresh_all)
 550         (tui_check_data_values): Update.
 551         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
 552         (tui_set_win_focus_to, tui_win_info::forward_scroll)
 553         (tui_win_info::backward_scroll, tui_refresh_all_win)
 554         (tui_resize_all, tui_set_focus, tui_all_windows_info)
 555         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
 556         (tui_source_window_base::set_new_height)
 557         (tui_data_window::set_new_height)
 558         (make_invisible_and_set_new_height)
 559         (make_visible_with_new_height, new_height_ok)
 560         (parse_scrolling_args): Update.
 561         * tui/tui-stack.c (tui_show_frame_info): Update.
 562         * tui/tui-source.c (tui_set_source_content)
 563         (tui_set_source_content_nil, tui_source_is_displayed)
 564         (tui_source_window::do_scroll_vertical): Update.
 565         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 566         (tui_display_registers_from, tui_display_reg_element_at_line)
 567         (tui_check_register_values, tui_reg_command): Update.
 568         * tui/tui-layout.c (tui_default_win_height)
 569         (show_source_disasm_command, show_data, init_and_make_win)
 570         (show_source_or_disasm_and_command): Update.
 571         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 572         (tui_redisplay_readline, tui_mld_flush)
 573         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
 574         (tui_getc): Update.
 575         * tui/tui-disasm.c (tui_set_disassem_content)
 576         (tui_disasm_window::do_scroll_vertical): Update.
 577         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
 578         Now virtual.
 579         (struct tui_win_info): Derive from tui_gen_win_info.
 580         <~tui_win_info>: Mark as override.
 581         <generic>: Remove member.
 582         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
 583         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
 584         (~tui_data_window, ~tui_win_info)
 585         (tui_free_all_source_wins_content): Update.
 586         * tui/tui-command.c (tui_refresh_cmd_win): Update.
 587
 588 2019-06-25  Tom Tromey  <tom@tromey.com>
 589
 590         * tui/tui-layout.c (init_and_make_win): Use new.
 591         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
 592         destructor, initializers.
 593         (tui_alloc_generic_win_info): Don't declare.
 594         * tui/tui-data.c (_locator): Add argument to constructor.
 595         (source_win, disasm_win): New globals.
 596         (exec_info): Remove.
 597         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 598         Update.
 599         (tui_alloc_generic_win_info): Remove.
 600         (init_content_element): Use new.
 601         (tui_win_info::tui_win_info): Update.
 602         (free_content_elements) <case DATA_WIN>: Use delete.
 603
 604 2019-06-25  Tom Tromey  <tom@tromey.com>
 605
 606         * tui/tui-wingeneral.c (tui_refresh_win): Update.
 607         * tui/tui-windata.c (tui_first_data_item_displayed)
 608         (tui_delete_data_content_windows): Update.
 609         * tui/tui-win.c (tui_data_window::set_new_height): Update.
 610         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 611         (tui_display_registers_from, tui_check_register_values): Update.
 612         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
 613         pointer.
 614         * tui/tui-data.c (init_content_element): Update.  Allocate the new
 615         window.
 616         (tui_free_data_content): Update.
 617         (free_content_elements) <case DATA_WIN>: Free the window.
 618
 619 2019-06-25  Tom Tromey  <tom@tromey.com>
 620
 621         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
 622         Update.
 623         * tui/tui-layout.c (make_command_window)
 624         (show_source_disasm_command, show_data, init_and_make_win)
 625         (show_source_or_disasm_and_command): Update.
 626         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
 627         method.
 628         <can_highight, is_highlighted>: Now bool.
 629         (tui_set_win_highlight): Don't declare.
 630         * tui/tui-data.c (tui_set_win_highlight): Remove.
 631
 632 2019-06-25  Tom Tromey  <tom@tromey.com>
 633
 634         * tui/tui-wingeneral.c (make_visible): Remove check of window
 635         type.
 636
 637 2019-06-25  Tom Tromey  <tom@tromey.com>
 638
 639         * tui/tui-win.c (tui_win_info::max_height)
 640         (tui_cmd_window::max_height): New methods.
 641         (new_height_ok): Call max_height.
 642         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
 643         <max_height>: New method.
 644
 645 2019-06-25  Tom Tromey  <tom@tromey.com>
 646
 647         * tui/tui-win.c (tui_source_window_base::set_new_height)
 648         (tui_data_window::set_new_height): New methods.
 649         (make_invisible_and_set_new_height): Call set_new_height method.
 650         * tui/tui-data.h (struct tui_win_info)
 651         (struct tui_source_window_base, struct tui_data_window)
 652         <set_new_height>: New method.
 653
 654 2019-06-25  Tom Tromey  <tom@tromey.com>
 655
 656         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
 657         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
 658         tui_refresh_data_win.
 659         * tui/tui-win.c (tui_source_window_base::refresh_all): New
 660         method.
 661         (tui_refresh_all_win): Call the refresh_all method.
 662         (tui_set_focus): Likewise.
 663         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
 664         (struct tui_source_window_base, struct tui_data_window) <refresh>:
 665         Likewise.
 666
 667 2019-06-25  Tom Tromey  <tom@tromey.com>
 668
 669         * tui/tui-winsource.h (tui_refill_source_window)
 670         (tui_set_is_exec_point_at): Don't declare.
 671         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 672         (tui_source_window_base::refill): Rename from
 673         tui_refill_source_window.
 674         (tui_source_window_base::do_scroll_horizontal): Update.
 675         (tui_source_window_base::set_is_exec_point_at): Rename from
 676         tui_set_is_exec_point_at.
 677         (tui_update_all_breakpoint_info): Update.
 678         * tui/tui-stack.c (tui_show_frame_info): Update.
 679         * tui/tui-layout.c (show_data): Add cast.
 680         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
 681         * tui/tui-data.h (struct tui_source_window_base) <refill,
 682         set_is_exec_point_at>: New methods.
 683         (tui_source_windows, tui_add_to_source_windows): Update types.
 684         (tui_add_to_source_windows): Remove redundant declaration.
 685         * tui/tui-data.c (source_windows): Store tui_source_window_base.
 686         (tui_source_windows): Change return type.
 687         (tui_clear_source_windows_detail): Update.
 688         (tui_add_to_source_windows): Change type of parameter.
 689         (tui_free_all_source_wins_content): Update.
 690
 691 2019-06-25  Tom Tromey  <tom@tromey.com>
 692
 693         * tui/tui-wingeneral.c (tui_win_info::refresh)
 694         (tui_source_window_base::refresh): New methods.
 695         (tui_refresh_all): Call the refresh method.
 696         * tui/tui-data.h (struct tui_win_info)
 697         (struct tui_source_window_base) <refresh>: New method.
 698
 699 2019-06-25  Tom Tromey  <tom@tromey.com>
 700
 701         * tui/tui.h (tui_is_window_visible): Return bool.
 702         * tui/tui.c (tui_is_window_visible): Return bool.
 703         * tui/tui-wingeneral.c (tui_make_window, make_visible)
 704         (tui_make_visible, tui_make_invisible)
 705         (tui_win_info::make_visible)
 706         (tui_source_window_base::make_visible, make_all_visible)
 707         (tui_make_all_visible, tui_make_all_invisible): Update.
 708         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
 709         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
 710         bool.
 711         (struct tui_win_info, struct tui_source_window_base)
 712         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
 713         * tui/tui-data.c (tui_init_generic_part): Update.
 714
 715 2019-06-25  Tom Tromey  <tom@tromey.com>
 716
 717         * tui/tui-wingeneral.c (tui_win_info::make_visible)
 718         (tui_source_window_base::make_visible): New methods.
 719         (make_all_visible): Make method call.
 720         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
 721         (struct tui_source_window_base, struct tui_cmd_window): Override
 722         make_visible.
 723         (tui_win_is_source_type): Don't declare.
 724         * tui/tui-data.c (tui_win_is_source_type): Remove.
 725
 726 2019-06-25  Tom Tromey  <tom@tromey.com>
 727
 728         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
 729         NULL check.
 730
 731 2019-06-25  Tom Tromey  <tom@tromey.com>
 732
 733         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
 734         Inline constructor.  Add initializers for members.
 735         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
 736         constructors; now inline in class.
 737
 738 2019-06-25  Tom Tromey  <tom@tromey.com>
 739
 740         * tui/tui-regs.c (tui_show_registers): Update.
 741         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
 742         bool.
 743         * tui/tui-data.c (tui_data_window::clear_detail)
 744         (tui_data_window): Update.
 745
 746 2019-06-25  Tom Tromey  <tom@tromey.com>
 747
 748         * tui/tui-windata.c (tui_display_all_data)
 749         (tui_display_data_from_line, tui_display_data_from)
 750         (tui_check_data_values, tui_data_window::do_scroll_vertical):
 751         Update.
 752         * tui/tui-regs.c (tui_last_regs_line_no)
 753         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 754         (tui_show_registers, tui_show_register_group)
 755         (tui_display_registers_from, tui_display_reg_element_at_line)
 756         (tui_display_registers_from_line, tui_check_register_values)
 757         (tui_reg_next, tui_reg_prev): Update.
 758         * tui/tui-layout.c (tui_set_layout, show_data): Update.
 759         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
 760         tui_data_window.
 761         (struct tui_win_info) <detail>: Remove.  Add new fields from
 762         tui_data_info.
 763         (TUI_DATA_WIN): Add cast.
 764         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
 765         (~tui_data_window): Simplify.
 766
 767 2019-06-25  Tom Tromey  <tom@tromey.com>
 768
 769         * tui/tui-layout.c (show_source_disasm_command)
 770         (show_source_or_disasm_and_command): Update.
 771         * tui/tui-io.c (update_cmdwin_start_line)
 772         (tui_redisplay_readline): Update.
 773         * tui/tui-data.h (struct tui_command_info): Remove.
 774         (struct tui_win_info) <detail>: Remove command_info member.
 775         (struct tui_data_window) <start_line>: New member, from
 776         tui_command_info.
 777         (TUI_CMD_WIN): Add casts.
 778
 779 2019-06-25  Tom Tromey  <tom@tromey.com>
 780
 781         * tui/tui-winsource.c (tui_update_source_window)
 782         (tui_refill_source_window)
 783         (tui_source_window_base::do_scroll_horizontal)
 784         (tui_update_breakpoint_info, tui_set_exec_info_content)
 785         (tui_show_exec_info_content, tui_erase_exec_info_content)
 786         (tui_clear_exec_info_content): Update.
 787         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
 788         Update.
 789         * tui/tui-win.c (make_invisible_and_set_new_height)
 790         (make_visible_with_new_height): Update.
 791         * tui/tui-source.c (tui_set_source_content)
 792         (tui_show_symtab_source): Update.
 793         * tui/tui-layout.c (extract_display_start_addr)
 794         (show_source_disasm_command, show_data)
 795         (make_source_or_disasm_window)
 796         (show_source_or_disasm_and_command): Update.
 797         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
 798         (tui_disasm_window::do_scroll_vertical): Remove shadowing
 799         "gdbarch".
 800         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
 801         to tui_source_window_base.
 802         (struct tui_win_info) <detail>: Remove source_info member.
 803         (struct tui_source_window_base) <has_locator>: Inline.
 804         Move contents from tui_source_info; rename has_locator member to
 805         m_has_locator.
 806         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
 807         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
 808         header file.
 809         (tui_source_window_base::clear_detail, ~tui_source_window_base):
 810         Simplify.
 811         (tui_free_all_source_wins_content): Cast to
 812         tui_source_window_base.
 813
 814 2019-06-25  Tom Tromey  <tom@tromey.com>
 815
 816         * tui/tui-win.c (make_invisible_and_set_new_height)
 817         (make_visible_with_new_height): Call has_locator method.
 818         * tui/tui-layout.c (show_source_disasm_command, show_data)
 819         (show_source_or_disasm_and_command): Update for bool change.
 820         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
 821         (tui_win_info) <has_locator>: New method.
 822         (struct tui_source_window_base) <has_locator>: New method.
 823         (tui_win_has_locator): Don't declare.
 824         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
 825         from tui_win_has_locator.
 826         (tui_source_window_base): Use false, not FALSE.
 827
 828 2019-06-25  Tom Tromey  <tom@tromey.com>
 829
 830         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
 831         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
 832         clear_detail method directly.
 833         (tui_clear_win_detail): Remove.
 834
 835 2019-06-25  Tom Tromey  <tom@tromey.com>
 836
 837         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
 838         "this", not TUI_DISASM_WIN.
 839
 840 2019-06-25  Tom Tromey  <tom@tromey.com>
 841
 842         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
 843         declare.
 844         * tui/tui-winsource.c
 845         (tui_source_window_base::do_scroll_horizontal): Rename from
 846         tui_horizontal_source_scroll.
 847         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
 848         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
 849         from tui_vertical_data_scroll.
 850         * tui/tui-win.h (tui_scroll): Don't declare.
 851         * tui/tui-win.c (tui_win_info::forward_scroll)
 852         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 853         (tui_win_info::right_scroll): Rename and update.
 854         (tui_scroll_forward_command, tui_scroll_backward_command)
 855         (tui_scroll_left_command, tui_scroll_right_command): Update.
 856         (tui_scroll): Remove.
 857         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
 858         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
 859         from tui_vertical_source_scroll.
 860         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
 861         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
 862         from tui_vertical_disassem_scroll.
 863         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
 864         do_scroll_horizontal>: New methods.
 865         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
 866         Likewise.
 867         (struct tui_source_window_base): Add do_scroll_horizontal.
 868         (struct tui_source_window, struct tui_disasm_window): Add
 869         do_scroll_vertical.
 870         (struct tui_data_window, struct tui_cmd_window): Add
 871         do_scroll_horizontal and do_scroll_vertical.
 872         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
 873
 874 2019-06-25  Tom Tromey  <tom@tromey.com>
 875
 876         * tui/tui-data.h (struct tui_source_window_base): New struct.
 877         (struct tui_source_window): Derive from tui_source_window_base.
 878         (struct tui_disasm_window): New struct.
 879         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
 880         from tui_source_window::clear_detail.
 881         (tui_source_window_base): Rename from tui_source_window.
 882         (~tui_source_window_base): Rename from ~tui_source_window.
 883         (tui_alloc_win_info): Create a tui_disasm_window.
 884
 885 2019-06-25  Tom Tromey  <tom@tromey.com>
 886
 887         * tui/tui-data.h (struct tui_source_window)
 888         (struct tui_data_window): Declare destructors.
 889         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
 890         destructors.
 891         (tui_win_info): Simplify.
 892
 893 2019-06-25  Tom Tromey  <tom@tromey.com>
 894
 895         * tui/tui-winsource.c (tui_display_main)
 896         (tui_update_source_windows_with_addr)
 897         (tui_update_all_breakpoint_info): Update.
 898         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 899         (new_height_ok, parse_scrolling_args): Update.
 900         * tui/tui-stack.c (tui_show_frame_info): Update.
 901         * tui/tui-data.h (struct tui_list): Remove.
 902         (tui_source_windows): Return a reference to a std::vector.
 903         * tui/tui-data.c (source_windows): Now a std::vector.
 904         (tui_source_windows): Change return type.
 905         (tui_clear_source_windows): Rewrite.
 906         (tui_clear_source_windows_detail, tui_add_to_source_windows)
 907         (tui_free_all_source_wins_content): Rewrite.
 908
 909 2019-06-25  Tom Tromey  <tom@tromey.com>
 910
 911         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
 912         (struct tui_data_window, struct tui_cmd_window): Declare
 913         clear_detail method.
 914         * tui/tui-data.c (tui_source_window::clear_detail)
 915         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
 916         methods.
 917         (tui_clear_win_detail): Simplify.
 918
 919 2019-06-25  Tom Tromey  <tom@tromey.com>
 920
 921         * tui/tui-layout.c (make_source_window, make_disasm_window)
 922         (make_source_or_disasm_window): Remove win_info_ptr parameter.
 923         Return the new window.
 924         (show_source_disasm_command, show_data)
 925         (show_source_or_disasm_and_command): Update.
 926
 927 2019-06-25  Tom Tromey  <tom@tromey.com>
 928
 929         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
 930         parameter.  Return the new window.
 931         (show_source_disasm_command): Update and remove NULL check.
 932         (show_source_or_disasm_and_command): Update.
 933
 934 2019-06-25  Tom Tromey  <tom@tromey.com>
 935
 936         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
 937
 938 2019-06-25  Tom Tromey  <tom@tromey.com>
 939
 940         * tui/tui-data.h (struct tui_win_info): Make constructor
 941         protected.  Make destructor virtual.  Add initializers.
 942         (tui_source_window, tui_data_window, tui_cmd_window): New
 943         classes.
 944         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
 945         constructor.  Add "type" parameter.
 946         (tui_source_window, tui_data_window, tui_cmd_window): New
 947         constructors.
 948         (tui_alloc_win_info): Instantiate the appropriate subclass.
 949
 950 2019-06-25  Tom Tromey  <tom@tromey.com>
 951
 952         * tui/tui-win.c (tui_resize_all): Use delete.
 953         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
 954         destructor.
 955         (tui_free_window): Don't declare.
 956         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
 957         Update.
 958
 959 2019-06-25  Tom Tromey  <tom@tromey.com>
 960
 961         * tui/tui-data.h (struct tui_win_info): Add constructor.
 962         * tui/tui-data.c (tui_alloc_win_info): Use new.
 963         (tui_free_window): Use delete.
 964
 965 2019-06-22  Tom Tromey  <tom@tromey.com>
 966
 967         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
 968         declare.
 969         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
 970
 971 2019-06-22  Tom Tromey  <tom@tromey.com>
 972
 973         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
 974         declare.
 975         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
 976
 977 2019-06-22  Tom de Vries  <tdevries@suse.de>
 978
 979         * dwarf2read.c (create_addrmap_from_aranges)
 980         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
 981         instead of '%zu'.
 982
 983 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
 984
 985         * dwarf2read.h (dwarf2_section_info_def): Remove.
 986         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
 987         * dwarf2read.c (struct dwo_sections) <types>: Change type to
 988         std::vector<dwarf2_section_info>.
 989         (struct dwo_file) <~dwo_file>: Remove.
 990         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
 991         types field.
 992         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
 993         (dwarf2_read_debug_names): Likewise.
 994         (create_debug_types_hash_table): Change parameter type to
 995         array_view, adjust code accordingly.
 996         (dwarf2_locate_dwo_sections): Adjust to std::vector.
 997         (partial_die_info::fixup): Likewise.
 998         (determine_prefix): Likewise.
 999         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
1000
1001 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1002
1003         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
1004         gdb_bfd_ref_ptr.
1005         <~dwo_file>: Remove call to gdb_bfd_unref.
1006         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
1007         gdb_bfd_ref_ptr::get.
1008
1009 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1010
1011         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
1012         type to htab_up.
1013         * dwarf2read.c (struct dwo_file): Initialize fields.
1014         <~dwo_file>: New.
1015         (free_dwo_file): Remove, move content to ~dwo_file.
1016         (struct dwo_file_deleter): Remove.
1017         (dwo_file_up>: Remove custom deleter.
1018         (free_dwo_files): Remove.
1019         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
1020         dwo_files.
1021         (process_skeletonless_type_units): Call unique_ptr::get.
1022         (allocate_dwo_file_hash_table): Add deleter to created hash
1023         table.  Change return type to htab_up.
1024         (lookup_dwo_file_slot): Don't memset dwo_file, call
1025         unique_ptr::get.
1026         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
1027         (create_dwo_unit_in_dwp_v2): Likewise.
1028         (open_and_init_dwo_file): Likewise.
1029         (free_dwo_file_from_slot): Remove.
1030
1031 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1032
1033         * dwarf2read.h (struct dwarf2_section_info) <readin,
1034         is_virtual>: Change type to bool.
1035         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
1036         true instead of 1.
1037
1038 2019-06-19  Tom Tromey  <tom@tromey.com>
1039
1040         * tui/tui-data.h (tui_init_content_element): Don't declare.
1041
1042 2019-06-19  Tom Tromey  <tom@tromey.com>
1043
1044         * tui/tui-data.h (tui_init_win_info): Don't declare.
1045
1046 2019-06-19  Tom de Vries  <tdevries@suse.de>
1047
1048         * dwarf2read.h (abstract_to_concrete): Change type to
1049         std::unordered_map<sect_offset, std::vector<sect_offset>,
1050         gdb::hash_enum<sect_offset>>.
1051
1052 2019-06-19  Tom Tromey  <tromey@adacore.com>
1053
1054         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
1055         EVAL_AVOID_SIDE_EFFECTS specially.
1056
1057 2019-06-19  Tom Tromey  <tromey@adacore.com>
1058
1059         * source-cache.c (highlighter): New global.
1060         (source_cache::get_source_lines): Create a highlighter on demand.
1061
1062 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1063
1064         * defs.h (deprecated_interactive_hook): Delete declaration.
1065         * interps.c (clear_interpreter_hooks): Remove use of
1066         deprecated_interactive_hook.
1067         * top.c (deprecated_interactive_hook): Delete definition.
1068         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
1069
1070 2019-06-18  Tom de Vries  <tdevries@suse.de>
1071
1072         PR gdb/24515
1073         * dwarf2read.h (abstract_to_concrete): Change type from
1074         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
1075         std::unordered_map<sect_offset, std::vector<sect_offset>>.
1076         * dwarf2read.c (read_variable): Update.
1077         (dwarf2_fetch_die_loc_sect_off): Update.
1078
1079 2019-06-17  Tom de Vries  <tdevries@suse.de>
1080
1081         PR gdb/24617
1082         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
1083         accessing parent[parent_len - 1].
1084
1085 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
1086
1087         PR gdb/24364
1088         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
1089         call dtrace_process_dof with NULL dof.
1090
1091 2019-06-16  Tom de Vries  <tdevries@suse.de>
1092
1093         PR gdb/24445
1094         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
1095
1096 2019-06-16  Tom Tromey  <tom@tromey.com>
1097
1098         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1099         (make_all_visible): Use address of member.
1100
1101 2019-06-16  Tom Tromey  <tom@tromey.com>
1102
1103         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
1104         (tui_free_window, free_content, free_content_elements): Remove
1105         unnecessary cast.
1106         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
1107         cast.
1108         * tui/tui-regs.c (tui_show_register_group)
1109         (tui_display_registers_from, tui_display_reg_element_at_line):
1110         Remove unnecessary cast.
1111
1112 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
1113
1114         * linux-nat.c (normal_mask): Delete.
1115         (_initialize_linux_nat): Don't initialise normal_mask.
1116
1117 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
1118
1119         PR gdb/24445
1120         * dwarf-index-write.h (write_psymtabs_to_index): Add
1121         dwz_basename parameter.
1122         * dwarf-index-write.c (write_gdbindex): Move file writing to
1123         write_gdbindex_1.  Change return type void.
1124         (assert_file_size): Move up, remove filename parameter.
1125         (write_gdbindex_1): New function.
1126         (write_debug_names): Change return type to void, call
1127         assert_file_size.
1128         (struct index_wip_file): New struct.
1129         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
1130         file logic to index_wip_file.  Write index for dwz file if
1131         needed.
1132         (save_gdb_index_command): Pass basename of dwz file, if present.
1133         * dwarf-index-cache.c (index_cache::store): Obtain and pass
1134         build-id of dwz file, if present.
1135         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1136         (dwarf2_get_dwz_file): Likewise.
1137         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1138         (dwarf2_get_dwz_file): Likewise.
1139
1140 2019-06-16  Tom Tromey  <tom@tromey.com>
1141
1142         * coffread.c (process_coff_symbol): Use xstrdup.
1143         * value.c (create_internalvar): Use xstrdup.
1144
1145 2019-06-16  Tom Tromey  <tom@tromey.com>
1146
1147         * valops.c (value_cast, value_slice): Remove unnecessary cast.
1148         * breakpoint.c (stopin_command, stopat_command)
1149         (until_break_command, decode_location_default): Remove unnecessary
1150         cast.
1151         * utils.c (subset_compare): Remove unnecessary cast.
1152         * ada-lang.c (ada_update_initial_language): Remove unnecessary
1153         cast.
1154         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1155         cast.
1156         * infcmd.c (path_command): Remove unnecessary cast.
1157         * coffread.c (decode_type): Remove unnecessary cast.
1158         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1159         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1160         * tui/tui-stack.c (tui_show_locator_content)
1161         (tui_show_frame_info): Remove unnecessary cast.
1162         * tui/tui-win.c (tui_scroll_forward_command)
1163         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1164         (parse_scrolling_args): Remove unnecessary cast.
1165         * tui/tui-data.c (init_win_info, tui_del_window)
1166         (tui_free_window, tui_del_data_windows, tui_free_data_content)
1167         (free_content_elements): Remove unnecessary cast.
1168         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1169         unnecessary cast.
1170         * tui/tui-source.c (tui_set_source_content)
1171         (tui_vertical_source_scroll): Remove unnecessary cast.
1172         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1173         cast.
1174         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1175         * tui/tui-regs.c (tui_display_registers_from)
1176         (tui_display_register): Remove unnecessary cast.
1177         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1178         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1179         (make_visible): Remove unnecessary cast.
1180         * tui/tui-winsource.c (tui_erase_source_content)
1181         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1182         unnecessary cast.
1183         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1184         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1185         * stabsread.c (read_type, read_array_type, read_range_type):
1186         Remove unnecessary cast.
1187         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1188         (parse_symbol, parse_type, upgrade_type, parse_external)
1189         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
1190         unnecessary cast.
1191         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
1192
1193 2019-06-16  Tom Tromey  <tom@tromey.com>
1194
1195         * tui/tui-data.c (tui_alloc_generic_win_info)
1196         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
1197         checks.
1198
1199 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
1200             Andrew Burgess  <andrew.burgess@embecosm.com>
1201
1202         * f-typeprint.c (f_print_type): Don't return early for not
1203         associated or not allocated types.
1204         (f_type_print_varspec_suffix): Add print_rank parameter and print
1205         ranks of array types in case they dangling.
1206         (f_type_print_base): Add print_rank parameter.
1207
1208 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1209
1210         * NEWS: Mention new MI commands.
1211         * break-catch-throw.c (enum exception_event_kind): Move to
1212         breakpoint.h.
1213         (print_mention_exception_catchpoint): Output text as a single
1214         message.
1215         (catch_exception_command_1): Rename to...
1216         (catch_exception_event): ...this, make non-static, update header
1217         command, and change some parameter types.
1218         (catch_catch_command): Update for changes to
1219         catch_exception_command_1.
1220         (catch_throw_command): Likewise.
1221         (catch_rethrow_command): Likewise.
1222         * breakpoint.c (enum exception_event_kind): Delete.
1223         * breakpoint.h (enum exception_event_kind): Moved here from
1224         break-catch-throw.c.
1225         (catch_exception_event): Declare.
1226         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
1227         (mi_cmd_catch_throw): New function.
1228         (mi_cmd_catch_rethrow): New function.
1229         (mi_cmd_catch_catch): New function.
1230         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
1231         'catch-catch' entries.
1232         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
1233         (mi_cmd_catch_rethrow): Declare.
1234         (mi_cmd_catch_catch): Declare.
1235
1236 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1237
1238         * annotate.c (annotate_source_line): Change return type to void,
1239         update implementation to match.
1240         * annotate.h (annotate_source_line): Change return type to void,
1241         update header comment.
1242         * stack.c (print_frame_info): Don't change what frame information
1243         is printed based on whether annotations are on or not.
1244
1245 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1246
1247         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
1248         (annotate_source): Make static.
1249         (annotate_source_line): Moved from source.c and renamed from
1250         identify_source_line.  Update the return type.
1251         * annotate.h (annotate_source): Delete declaration.
1252         (annotate_source_line): Declaration moved from source.h, and
1253         renamed from identify_source_line.  Return type updated.
1254         * source.c (identify_source_line): Moved to annotate.c and renamed
1255         to annotate_source_line.
1256         (info_line_command): Remove check of annotation_level.
1257         * source.h (identify_source_line): Move declaration to annotate.h
1258         and rename to annotate_source_line.
1259         * stack.c: Add 'annotate.h' include.
1260         (print_frame_info): Remove check of annotation_level before
1261         calling annotate_source_line.
1262
1263 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1264
1265         * source-cache.c (source_cache::get_plain_source_lines): Use
1266         open_source_file_with_line_charpos instead of just
1267         open_source_file, remove call to find_source_lines.
1268         (source_cache::get_source_lines): Likewise.
1269         * source.c (find_source_lines): Make static.
1270         (get_filename_and_charpos): Renamed into...
1271         (open_source_file_with_line_charpos): ..this along with changes to
1272         return a scoped_fd, and some other minor clean ups.
1273         (identify_source_line): Use open_source_file_with_line_charpos.
1274         (search_command_helper): Use open_source_file_with_line_charpos
1275         instead of just open_source_file, remove call to
1276         find_source_lines.
1277         * source.h (open_source_file_with_line_charpos): Declare new
1278         function.
1279         (find_source_lines): Delete declaration.
1280
1281 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1282
1283         * source.c (get_filename_and_charpos): Remove fullname
1284         parameter.
1285         (identify_source_line): Update call to get_filename_and_charpos.
1286
1287 2019-06-14  Tom Tromey  <tromey@adacore.com>
1288
1289         PR gdb/24502:
1290         * ui-style.h (skip_ansi_escape): Update comment.
1291         * ui-file.h (class no_terminal_escape_file): New class.
1292         * ui-file.c (no_terminal_escape_file::write)
1293         (no_terminal_escape_file::puts): New methods.
1294         * cli/cli-logging.c (handle_redirections): Use
1295         no_terminal_escape_file.
1296
1297 2019-06-14  Tom Tromey  <tromey@adacore.com>
1298
1299         * NEWS: Move convenience variable news above Python news.
1300
1301 2019-06-14  Tom Tromey  <tom@tromey.com>
1302
1303         * gnulib: Move directory to top-level.
1304         * configure.ac: Don't configure gnulib.
1305         * configure: Rebuild.
1306         * common/common-defs.h: Use new path to gnulib.
1307         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
1308         (GNULIB_H): Remove.
1309         (INCGNU): Look in new gnulib location.
1310         (HFILES_NO_SRCDIR): Remove gnulib files.
1311         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
1312         (generated_files): Remove GNULIB_H.
1313         ($(LIBGNU), all-lib): Remove targets.
1314         (distclean): Don't mention GNULIB_BUILDDIR.
1315         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
1316
1317 2019-06-14  Tom Tromey  <tromey@adacore.com>
1318
1319         * symfile.c (add_symbol_file_command): Remove obsolete comment.
1320         Warn if symbol file does not provide any symbols.
1321
1322 2019-06-14  Tom Tromey  <tromey@adacore.com>
1323
1324         * source.c (find_and_open_source): Respect basenames_may_differ.
1325
1326 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
1327
1328         * annotate.c (annotate_breakpoints_invalid): Make use of
1329         scoped_restore_terminal_state.
1330         (annotate_frames_invalid): Likewise.
1331
1332 2019-06-14  Tom Tromey  <tromey@adacore.com>
1333
1334         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
1335         allow assignment to an internalvar.
1336
1337 2019-06-14  Tom Tromey  <tromey@adacore.com>
1338
1339         * ada-lex.l: Allow "_" in attribute names.
1340
1341 2019-06-14  Tom Tromey  <tromey@adacore.com>
1342
1343         PR gdb/24653:
1344         * regcache.c (registers_changed): Don't call alloca.
1345         * top.c (execute_command): Don't call alloca.
1346
1347 2019-06-13  Pedro Alves  <palves@redhat.com>
1348
1349         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
1350         'expression'.  When parsing an expression, error out if there's
1351         junk after "unlimited".
1352         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1353         (do_set_command): Adjust calls to is_unlimited_literal.
1354
1355 2019-06-13  Pedro Alves  <palves@redhat.com>
1356
1357         * compile/compile.c (make_compile_options_def_group): Add braces
1358         around array_view initializer.
1359         * thread.c (make_thread_apply_all_options_def_group)
1360         (make_thread_apply_all_options_def_group): Likewise.
1361
1362 2019-06-13  Pedro Alves  <palves@redhat.com>
1363
1364         * NEWS (New commands): Mention "maint test-options
1365         require-delimiter", "maint test-options unknown-is-error", "maint
1366         test-options unknown-is-operand" and "maint show
1367         test-options-completion-result".
1368         (New command options, command completion): New section.
1369         (Completion improvements): New section.
1370         Mention that you can abbreviate "unlimited".
1371
1372 2019-06-13  Pedro Alves  <palves@redhat.com>
1373
1374         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
1375         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
1376         * unittests/cli-utils-selftests.c (test_parse_flags)
1377         (test_parse_flags_qcs): Delete.
1378         (test_cli_utils): Don't call deleted functions.
1379
1380 2019-06-13  Pedro Alves  <palves@redhat.com>
1381
1382         * thread.c: Include "cli/cli-option.h".
1383         (tp_array_compar_ascending): Global.
1384         (tp_array_compar): Delete function.
1385         (tp_array_compar_ascending, tp_array_compar_descending): New
1386         functions.
1387         (ascending_option_def, qcs_flag_option_def)
1388         (thr_qcs_flags_option_defs)
1389         (make_thread_apply_all_options_def_group)
1390         (make_thread_apply_options_def_group): New.
1391         (thread_apply_all_command): Use gdb::option::process_options.
1392         (thread_apply_command_completer)
1393         (thread_apply_all_command_completer): New.
1394         (thread_apply_command): Use gdb::option::process_options.
1395         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
1396         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
1397         to generate help text of "thread apply".  Adjust "taas"'s help.
1398         * tid-parse.c (tid_range_parser::in_thread_range): New method.
1399         * tid-parse.h (tid_range_parser::in_thread_range): New method.
1400
1401 2019-06-13  Pedro Alves  <palves@redhat.com>
1402
1403         * thread.c (thread_apply_command): Check for invalid TID with
1404         isdigit instead of !isalpha.
1405
1406 2019-06-13  Pedro Alves  <palves@redhat.com>
1407
1408         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
1409         (validate_flags_qcs): New.
1410         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
1411         (validate_flags_qcs): Declare.
1412         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
1413         (make_frame_apply_options_def_group): New.
1414         (frame_apply_command_count): Process options with
1415         gdb::option::process_options.
1416         (frame_apply_completer): New.
1417         (frame_apply_level_completer, frame_apply_all_completer)
1418         (frame_apply_completer): New.
1419         (_initialize_stack): Update help of "frame apply", "frame apply
1420         level", "frame apply all" and "faas" to mention supported options
1421         and install command completers.
1422         * stack.h (frame_apply_all_completer): Declare.
1423         * thread.c: Include "stack.h".
1424         (tfaas_command): Add "--".
1425         (_initialize_thread): Update help "tfaas" to mention supported
1426         options and install command completer.
1427
1428 2019-06-13  Pedro Alves  <palves@redhat.com>
1429
1430         * completer.c (complete_nested_command_line): New.
1431         (gdb_completion_word_break_characters_throw): Add assertion.
1432         * completer.h (complete_nested_command_line): Declare.
1433
1434 2019-06-13  Pedro Alves  <palves@redhat.com>
1435
1436         * stack.c (parse_backtrace_qualifiers): New.
1437         (backtrace_command): Use it.
1438         (backtrace_command_completer): Complete on qualifiers.
1439
1440 2019-06-13  Pedro Alves  <palves@redhat.com>
1441
1442         * frame.c: Include "cli/cli-option.h.
1443         (user_set_backtrace_options): New.
1444         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
1445         Delete.
1446         (get_prev_frame): Adjust.
1447         (boolean_option_def, uinteger_option_def)
1448         (set_backtrace_option_defs): New.
1449         (_initialize_frame): Adjust and use
1450         gdb::option::add_setshow_cmds_for_options to install "set
1451         backtrace past-main" and "set backtrace past-entry".
1452         * frame.h: Include "cli/cli-option.h".
1453         (struct frame_print_options): Forward declare.
1454         (print_frame_arguments_all, print_frame_arguments_scalars)
1455         (print_frame_arguments_none): Declare.
1456         (print_entry_values): Delete declaration.
1457         (struct frame_print_options, user_frame_print_options): New.
1458         (struct set_backtrace_options): New.
1459         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
1460         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
1461         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
1462         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
1463         (list_args_or_locals): Add frame_print_options parameter.
1464         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1465         * python/py-framefilter.c (enumerate_args): Pass down
1466         USER_FRAME_PRINT_OPTIONS.
1467         * stack.c: Include "cli/cli-option.h".
1468         (print_frame_arguments_all, print_frame_arguments_scalars)
1469         (print_frame_arguments_none): Declare.
1470         (print_raw_frame_arguments, print_entry_values): Delete.
1471         (user_frame_print_options): New.
1472         (boolean_option_def, enum_option_def, frame_print_option_defs):
1473         New.
1474         (struct backtrace_cmd_options): New.
1475         (bt_flag_option_def): New.
1476         (backtrace_command_option_defs): New.
1477         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1478         (print_frame_arg, read_frame_arg, print_frame_args)
1479         (print_frame_info, print_frame): Add frame_print_options parameter
1480         and use it.
1481         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
1482         (backtrace_command_1): Add frame_print_options and
1483         backtrace_cmd_options parameters and use them.
1484         (make_backtrace_options_def_group): New.
1485         (backtrace_command): Process command options with
1486         gdb::option::process_options.
1487         (backtrace_command_completer): New.
1488         (_initialize_stack): Extend "backtrace"'s help to mention
1489         supported options.  Install completer for "backtrace".
1490         Install some settings commands with add_setshow_cmds_for_options.
1491
1492 2019-06-13  Pedro Alves  <palves@redhat.com>
1493
1494         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
1495         and that "set/show print raw frame-arguments" are now deprecated.
1496
1497         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
1498         command.
1499         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
1500         * stack.c (_initialize_stack): Install "set/show print
1501         raw-frame-arguments", and deprecate "set/show print raw
1502         frame-arguments".
1503         * valprint.c (_initialize_valprint): Deprecate "set/show print
1504         raw".
1505
1506 2019-06-13  Pedro Alves  <palves@redhat.com>
1507
1508         * compile/compile.c (struct compile_options): New.
1509         (compile_flag_option_def, compile_command_option_defs)
1510         (make_compile_options_def_group): New.
1511         (compile_file_command): Handle options with
1512         gdb::option::process_options.
1513         (compile_file_command_completer): New function.
1514         (compile_code_command): Handle options with
1515         gdb::option::process_options.
1516         (compile_code_command_completer): New function.
1517         (_initialize_compiler): Install completers for "compile code" and
1518         "compile file".  Mention available options in "compile code" and
1519         "compile code"'s help.
1520         * completer.c (advance_to_completion_word): New, factored out from
1521         ...
1522         (advance_to_expression_complete_word_point): ... this.
1523         (advance_to_filename_complete_word_point): New.
1524         * completer.h (advance_to_filename_complete_word_point): New
1525         declaration.
1526
1527 2019-06-13  Pedro Alves  <palves@redhat.com>
1528
1529         * compile/compile.c: Include "cli/cli-option.h".
1530         (compile_print_value): Scope data pointer is now a
1531         value_print_options pointer; adjust.
1532         (compile_print_command): Process options.  Scope data pointer is
1533         now a value_print_options pointer; adjust.
1534         (_initialize_compile): Update "compile print"'s help to include
1535         supported options.  Install a completer for "compile print".
1536         * cp-valprint.c (show_vtblprint, show_objectprint)
1537         (show_static_field_print): Delete.
1538         (_initialize_cp_valprint): Don't install "set print
1539         static-members", "set print vtbl", "set print object" here.
1540         * printcmd.c: Include "cli/cli-option.h" and
1541         "common/gdb_optional.h".
1542         (print_command_parse_format): Rework to fill in a
1543         value_print_options instead of a format_data.
1544         (print_value): Change parameter type from format_data pointer to
1545         value_print_options reference.  Adjust.
1546         (print_command_1): Process options.  Adjust to pass down a
1547         value_print_options.
1548         (print_command_completer): New.
1549         (_initialize_printcmd): Install print_command_completer as
1550         handle_brkchars completer for the "print" command.  Update
1551         "print"'s help to include supported options.
1552         * valprint.c: Include "cli/cli-option.h".
1553         (show_vtblprint, show_objectprint, show_static_field_print): Moved
1554         here from cp-valprint.c.
1555         (boolean_option_def, uinteger_option_def)
1556         (value_print_option_defs, make_value_print_options_def_group):
1557         New.  Use gdb::option::add_setshow_cmds_for_options to install
1558         "set print elements", "set print null-stop", "set print repeats",
1559         "set print pretty", "set print union", "set print array", "set
1560         print address", "set print symbol", "set print array-indexes".
1561         * valprint.h: Include <string> and "cli/cli-option.h".
1562         (make_value_print_options_def_group): Declare.
1563         (print_value): Change parameter type from format_data pointer to
1564         value_print_options reference.
1565         (print_command_completer): Declare.
1566
1567 2019-06-13  Pedro Alves  <palves@redhat.com>
1568
1569         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
1570         (COMMON_SFILES): Add maint-test-settings.c.
1571         * cli/cli-decode.c (boolean_enums): New global, factored out from
1572         ...
1573         (add_setshow_boolean_cmd): ... here.
1574         * cli/cli-decode.h (boolean_enums): Declare.
1575         * cli/cli-option.c: New file.
1576         * cli/cli-option.h: New file.
1577         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
1578         factored out from ...
1579         (parse_cli_boolean_value(const char *)): ... this.
1580         (is_unlimited_literal): Change parameter type to pointer to
1581         pointer.  Adjust and advance ARG pointer.
1582         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1583         (parse_cli_var_enum): New, factored out from ...
1584         (do_set_command): ... this.  Adjust.
1585         * cli/cli-setshow.h (parse_cli_boolean_value)
1586         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1587         (parse_cli_var_enum): Declare.
1588         * cli/cli-utils.c: Include "cli/cli-option.h".
1589         (get_ulongest): New.
1590         * cli/cli-utils.h (get_ulongest): Declare.
1591         (check_for_argument): New overloads.
1592         * maint-test-options.c: New file.
1593
1594 2019-06-13  Pedro Alves  <palves@redhat.com>
1595
1596         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
1597         parse a range if "-" is at the end of the string.
1598
1599 2019-06-13  Pedro Alves  <palves@redhat.com>
1600
1601         * cli/cli-setshow.c (parse_auto_binary_operation)
1602         (parse_cli_boolean_value): Don't allow "o".
1603
1604 2019-06-13  Pedro Alves  <palves@redhat.com>
1605
1606         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
1607         * NEWS: Mention maint test-settings KIND.
1608         * maint-test-settings.c: New file.
1609
1610 2019-06-13  Pedro Alves  <palves@redhat.com>
1611
1612         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
1613         completer.
1614         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
1615         "set" completers.
1616
1617 2019-06-13  Pedro Alves  <palves@redhat.com>
1618
1619         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
1620         after item.
1621
1622 2019-06-13  Pedro Alves  <palves@redhat.com>
1623
1624         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
1625
1626 2019-06-13  Pedro Alves <palves@redhat.com>
1627
1628         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
1629         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
1630         call.
1631         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
1632         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
1633         calls.
1634         (check_for_argument): Skip spaces after argument.
1635
1636 2019-06-13  Pedro Alves  <palves@redhat.com>
1637
1638         * thread.c (thread_apply_command): Adjust TID parsing.
1639         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
1640         detected before end of string.
1641         (tid_is_in_list): Error out if LIST is invalid.
1642
1643 2019-06-13  Pedro Alves  <palves@redhat.com>
1644
1645         * completer.c (complete_line_internal_1): Rewind completion word
1646         point.
1647         (completion_tracker::advance_custom_word_point_by): Change
1648         parameter type to int.
1649         * completer.h (completion_tracker::advance_custom_word_point_by):
1650         Likewise.
1651
1652 2019-06-13  Pedro Alves  <palves@redhat.com>
1653
1654         * completer.c (advance_to_completion_word): Handle delimiters.
1655
1656 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
1657
1658         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
1659
1660 2019-06-11  Tom Tromey  <tom@tromey.com>
1661
1662         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
1663         (xmalloc_failed): Move to alloc.c.
1664         * alloc.c: New file.
1665         * Makefile.in (COMMON_SFILES): Add alloc.c.
1666
1667 2019-06-11  Tom Tromey  <tom@tromey.com>
1668
1669         * nat/linux-waitpid.c: Don't include server.h.
1670         (linux_debug): Remove.
1671         (my_waitpid): Update.
1672
1673 2019-06-11  Tom Tromey  <tromey@adacore.com>
1674
1675         * infcall.c (_initialize_infcall): Remove trailing newline from
1676         help.
1677         * user-regs.c (_initialize_user_regs): Remove trailing newline
1678         from help.
1679         * typeprint.c (_initialize_typeprint): Remove trailing newline
1680         from help.
1681         * reverse.c (_initialize_reverse): Remove trailing newlines from
1682         help.
1683         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
1684         from help.
1685         * language.c (add_set_language_command): Remove trailing newline
1686         from help.
1687         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
1688         help.
1689         * disasm.c (_initialize_disasm): Remove trailing newline from
1690         help.
1691         * top.c (init_main): Remove trailing newline from help.
1692         * interps.c (_initialize_interpreter): Remove trailing newline
1693         from help.
1694         * btrace.c (_initialize_btrace): Remove trailing newlines from
1695         help.
1696         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
1697         from help.
1698         * python/python.c (_initialize_python): Remove trailing newline
1699         from help.
1700         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
1701         help.
1702         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
1703         from help.  Reformat some text.
1704         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
1705         from help.
1706         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
1707         newline from help.
1708
1709 2019-06-11  Tom Tromey  <tromey@adacore.com>
1710
1711         * darwin-nat.c (darwin_decode_exception_message)
1712         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
1713
1714 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1715
1716         * valops.c (value_slice): Check for not allocated or not
1717         associated values.
1718
1719 2019-06-10  Tom de Vries  <tdevries@suse.de>
1720
1721         PR gdb/24618
1722         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
1723         sure an empty slot (defined by a 32-bit zero pair) is recognized as
1724         invalid.
1725
1726 2019-06-10  Tom de Vries  <tdevries@suse.de>
1727
1728         PR gdb/24611
1729         * linespec.c (linespec_lexer_lex_string): Remove incorrect
1730         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
1731
1732 2019-06-10  Tom de Vries  <tdevries@suse.de>
1733
1734         PR symtab/24545
1735         * symtab.c (struct demangled_name_entry): Add language field.
1736         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
1737         static minimal symbol".  Set and use language field.
1738
1739 2019-06-10  Tom Tromey  <tromey@adacore.com>
1740
1741         * ada-lang.c (_initialize_ada_language): Update help text.
1742
1743 2019-06-10  Tom Tromey  <tromey@adacore.com>
1744
1745         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
1746         with a newline.
1747         * guile/guile.c (handle_boot_error): Don't end warning with a
1748         newline.
1749         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
1750         warning with a newline.
1751         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
1752         newline.
1753         (s12z_frame_cache): Likewise.
1754         * dwarf-index-cache.c (index_cache::store): Don't end warning with
1755         a newline.
1756         * solib-svr4.c (disable_probes_interface): Don't end warning with
1757         a newline.
1758         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
1759         newline.
1760         * python/python.c (do_finish_initialization): Don't end warning
1761         with a newline.
1762
1763 2019-06-10  Tom Tromey  <tom@tromey.com>
1764
1765         * python/py-breakpoint.c (gdbpy_breakpoint_created)
1766         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
1767         gdbpy_enter.
1768
1769 2019-06-10  Tom Tromey  <tromey@adacore.com>
1770
1771         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
1772         data.
1773         (elf_new_init): Don't call stabsread_new_init.
1774         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
1775         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
1776         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
1777
1778 2019-06-10  Tom de Vries  <tdevries@suse.de>
1779
1780         PR symtab/16264
1781         PR symtab/24517
1782         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
1783
1784 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
1785
1786         * source.c (find_and_open_source): Also rewrite relative file
1787         names.
1788
1789 2019-04-26  Amos Bird  <amosbird@gmail.com>
1790
1791         * annotate.c (annotate_thread_exited): Add "thread-exited"
1792         annotation.
1793
1794 2019-06-06  Tom Tromey  <tromey@adacore.com>
1795
1796         * maint.h (class scoped_command_stats): Use
1797         DISABLE_COPY_AND_ASSIGN.
1798         <print_time>: New method.
1799         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
1800         print_time.
1801         (scoped_command_stats::print_time): New method.
1802
1803 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1804
1805         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
1806         instructions of lengths 6 or 8 bytes.
1807
1808 2019-06-04  Pedro Alves  <palves@redhat.com>
1809
1810         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
1811
1812         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
1813         * breakpoint.c (condition_completer): Likewise.
1814         * cli/cli-dump.c (scan_expression): Likewise.
1815         * common/filestuff.c (mkdir_recursive): Likewise.
1816         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
1817         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
1818         (gdb_abspath): Likewise.
1819         * compile/compile-cplus-types.c
1820         (compile_cplus_instance::decl_name): Likewise.
1821         * completer.c (complete_explicit_location):
1822         (signal_completer, reg_or_group_completer_1): Likewise.
1823         * cp-support.c (cp_remove_params_if_any): Likewise.
1824         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
1825         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
1826         * infcmd.c (strip_bg_char): Likewise.
1827         * linespec.c (copy_token_string): Likewise.
1828         * mi/mi-main.c (output_cores): Likewise.
1829         * psymtab.c (psymtab_search_name):
1830         * symfile.c (test_set_ext_lang_command): Likewise.
1831         * target.c (target_fileio_read_stralloc): Likewise.
1832         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
1833         * value.c (complete_internalvar): Likewise.
1834
1835 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
1836
1837         Add objfile property to gdb.Type.
1838         * NEWS: Mention Python API addition.
1839         * python/py-type.c (typy_get_objfile): New method.
1840
1841 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1842
1843         * NEWS: Mention the new set|show style [title|highlight].
1844         Mention changes to "show style", "help" and "apropos".
1845
1846 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1847
1848         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
1849         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
1850         instead of print_help_for_command.
1851         (print_doc_of_command): New function.
1852         (help_list): Add 'apropos -v word' suggestion.
1853         (print_help_for_command): Style the command name using title style.
1854         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
1855         (_initialize_cli_cmds): Describe -v in apropos_command help.
1856
1857 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1858
1859         * cli/cli-style.h (cli_style_option): Add name in constructor,
1860         add m_name class member, add constructor with intensity,
1861         add name class function.
1862         (cli_style_option::add_setshow_commands): Remove name argument.
1863         (highlight_style, title_style): New styles.
1864         * cli/cli-style.c (do_show): New function that shows a style
1865         characteristic styling the style name with itself.
1866         (set_style_name): New function.
1867         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
1868         Update all callers according to the changes in cli/cli-style.h.
1869         * utils.h (fputs_highlighted): New function.
1870         * utils.c (fputs_highlighted): Likewise.
1871
1872 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1873
1874         * NEWS: Mention new pipe command and new convenience variables.
1875
1876 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1877
1878         * cli/cli-cmds.c (pipe_command): New function.
1879         (_initialize_cli_cmds): Call add_com for pipe_command.
1880         Define | as an alias for pipe.
1881         (exit_status_set_internal_vars): New function.
1882         (shell_escape): Call exit_status_set_internal_vars.
1883         cli/cli-decode.c (find_command_name_length): Recognize | as
1884         a single character command.
1885
1886 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1887
1888         * gdbcmd.h (execute_command_to_ui_file): New declaration.
1889         top.c (execute_command_to_ui_file): New function, mostly a copy
1890         of execute_command_to_string.
1891         (execute_command_to_string): Implement by calling
1892         execute_command_to_ui_file.
1893
1894 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1895
1896         * top.h (saved_command_line): Remove declaration.
1897         * top.c (previous_saved_command_line, previous_repeat_arguments):
1898         New variables.
1899         (saved_command_line): Make static, define together with other
1900         'repeat variables'.
1901         (dont_repeat): Clear repeat_arguments.
1902         (repeat_previous, get_saved_command_line, save_command_line):
1903         New functions.
1904         (gdb_init): Initialize saved_command_line
1905         and previous_saved_command_line.
1906         * main.c (captured_main_1): Remove saved_command_line initialization.
1907         * event-top.c (handle_line_of_input): Update to use
1908         the new 'repeat' related functions instead of direct access to
1909         saved_command_line.
1910         * command.h (repeat_previous, get_saved_command_line,
1911         save_command_line): New declarations.
1912         (dont_repeat): Add comment.
1913
1914 2019-05-30  Tom Tromey  <tromey@adacore.com>
1915
1916         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
1917         Fix comment.
1918         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
1919
1920 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
1921
1922         PR cli/24587
1923         * completer.c (complete): Initialize variable word.
1924
1925 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
1926
1927         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1928         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
1929         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
1930         'body' is NULL to the outter 'if', protecting the '!is_define'
1931         situation as well.
1932
1933 2019-05-29  Tom Tromey  <tromey@adacore.com>
1934
1935         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
1936         (dwarf_unknown): New function.
1937         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
1938         (dwarf_type_encoding_name): Use dwarf_unknown.
1939
1940 2019-05-29  Tom Tromey  <tromey@adacore.com>
1941
1942         PR c++/20020:
1943         * cp-valprint.c (cp_print_value_fields): Call
1944         cp_print_static_field inside "try".
1945
1946 2019-05-29  Tom Tromey  <tromey@adacore.com>
1947
1948         * inflow.c (struct terminal_info): Add default operator=.
1949         * configure: Rebuild.
1950         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
1951         -Wdeprecated-copy-dtor, -Wredundant-move.
1952
1953 2019-05-29  Tom Tromey  <tromey@adacore.com>
1954
1955         * NEWS: Add entry.
1956         * infcmd.c (print_return_value_1): Handle finish_print
1957         option.
1958         (show_print_finish): New function.
1959         (_initialize_infcmd): Add "set/show print finish" commands.
1960         * valprint.c (user_print_options): Initialize new member.
1961         * valprint.h (struct value_print_options) <finish_print>: New
1962         member.
1963
1964 2019-05-28  Tom Tromey  <tromey@adacore.com>
1965
1966         * ada-lang.c (ada_remove_Xbn_suffix)
1967         (find_old_style_renaming_symbol)
1968         (parse_old_style_renaming): Remove.
1969         (ada_find_renaming_symbol): Don't call
1970         find_old_style_renaming_symbol.
1971         (ada_is_renaming_symbol): Rename from
1972         ada_find_renaming_symbol.  Remove "block" parameter.  Return
1973         bool.  Now static.
1974         (ada_read_var_value): Update and simplify.
1975         * ada-exp.y (write_var_or_type): Remove old code.
1976
1977 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
1978
1979         * event-top.c: Remove include comment.
1980         * inflow.c (class scoped_ignore_sigttou): Move from here...
1981         * inflow.h (class scoped_ignore_sigttou): ...to here.
1982         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
1983         * top.c:  Remove include comment.
1984
1985 2019-05-27  Tom Tromey  <tom@tromey.com>
1986
1987         * NEWS: Fix typo.
1988
1989 2019-05-22  Tom Tromey  <tromey@adacore.com>
1990
1991         * target.c (target_follow_exec): Constify parameter.
1992         * target-delegates.c: Rebuild.
1993         * remote.c (remote_target::follow_exec): Constify parameter.
1994         * infrun.c (follow_exec): Constify parameter.
1995         * target.h (struct target_ops) <follow_exec>: Constify parameter.
1996         (target_follow_exec): Likewise.
1997
1998 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1999
2000         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
2001         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
2002
2003 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2004
2005         * NEWS: Add debugredirect and testsuite sections.
2006
2007 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
2008
2009         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
2010         target descriptions using exclusively floating point register name
2011         aliases.
2012
2013 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2014
2015         PR gdb/18644:
2016         * f-lang.c (build_fortran_types): Handle the case where
2017         gdbarch_floatformat_for_type returns a nullptr.
2018
2019 2019-05-21  Tom de Vries  <tdevries@suse.de>
2020
2021         PR cli/24587
2022         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
2023
2024 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2025
2026         PR gdb/18644:
2027         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
2028         16-byte floats.
2029         * i386-tdep.c (i386_floatformat_for_type): Use
2030         floatformats_ia64_quad for the 16-byte floating point component
2031         within a fortran 32-byte complex number.
2032
2033 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2034
2035         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
2036         delete default constructor.
2037         (find_partial_die): Update to return const struct.
2038         (partial_die_parent_scope): Move variable declaration into scope
2039         of its use and change its type to auto.
2040         (guess_partial_die_structure_name): Likewise.
2041         (partial_die_info::fixup): Likewise.
2042
2043 2019-05-17  Tom Tromey  <tromey@adacore.com>
2044
2045         * source.c (find_and_open_source): Remove cast.
2046
2047 2019-05-17  Tom Tromey  <tromey@adacore.com>
2048
2049         * annotate.c (annotate_source): Make "filename" const.
2050         * annotate.h (annotate_source): Use const.
2051
2052 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2053
2054         * disasm.c (set_disassembler_options): Send errors to stderr.
2055
2056 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2057
2058         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
2059         (cli_interp_base::set_logging): Check debug_redirect.
2060         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
2061         * cli/cli-logging.c (debug_redirect): Add static variable.
2062         (pop_output_files): Add default param.
2063         (handle_redirections): Print debug setting.
2064         (show_logging_command): Likewise.
2065         (_initialize_cli_logging): Add debugredirect command.
2066         * interps.c (current_interp_set_logging): Add debug_redirect
2067         parameter.
2068         * interps.h (set_logging): Add debug_redirect parameter.
2069         (current_interp_set_logging): Likewise.
2070         * mi/mi-common.h: Likewise.
2071         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
2072
2073 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2074             Tom Tromey  <tromey@adacore.com>
2075
2076         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
2077         directly.
2078         * cli/cli-interp.h (make_logging_output): Remove declaration.
2079         * cli/cli-logging.c (make_logging_output): Remove function.
2080         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
2081         directly.
2082         * ui-file.c (tee_file::tee_file): Remove bools.
2083         (tee_file::~tee_file): Remove deletes.
2084         * ui-file.h (tee_file): Remove bools.
2085
2086 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
2087
2088         * mi/mi-cmds.h (mi_cmd_complete): New function.
2089         * mi/mi-main.c (mi_cmd_complete): Likewise.
2090         * mi/mi-cmds.c: Define new MI command -complete.
2091         * NEWS: Mention new -complete command.
2092
2093 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
2094
2095         * completer.h (complete): New function.
2096         * completer.c (complete): Likewise.
2097         * cli/cli-cmds.c: (complete_command): Update to use new complete()
2098         function defined in completer.h.
2099
2100 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
2101
2102         * MAINTAINERS (Write After Approval): Add myself.
2103
2104 2019-05-17  Tom de Vries  <tdevries@suse.de>
2105
2106         PR gdb/24094
2107         * dwarf2read.c (struct cu_partial_die_info): New struct.
2108         (find_partial_die): Return cu_partial_die_info.
2109         (partial_die_parent_scope, guess_partial_die_structure_name)
2110         (partial_die_info::fixup): Handle new return type of find_partial_die.
2111
2112 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2113
2114         * stap-probe.c (stap_parse_register_operand): Make "regname" an
2115         "std::string", simplifying the algorithm.
2116
2117 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2118
2119         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2120         (stap_static_probe_ops::get_probes): Likewise.
2121
2122 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2123
2124         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2125         '-')" and "else if".
2126         (stap_parse_single_operand): Join checks for
2127         "gdbarch_stap_parse_special_token_p" and
2128         "gdbarch_stap_parse_special_token" in the same "if" statement.
2129         Invert check when verifying for operation on register
2130         displacement.
2131
2132 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2133
2134         * stap-probe.c (stap_get_opcode): Update comment.
2135         (stap_get_expected_argument_type): Likewise.
2136         (handle_stap_probe): Likewise.
2137
2138 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2139
2140         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2141         return type to 'bool'.  Adjust comment.  Use 'bool' when
2142         appropriate.
2143         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2144         * stap-probe.c (stap_parse_argument_1): Likewise.
2145         (stap_is_operator): Likewise.
2146         (stap_is_generic_prefix): Likewise.
2147         (stap_is_register_prefix): Likewise.
2148         (stap_is_register_indirection_prefix): Likewise.
2149         (stap_is_integer_prefix): Likewise.
2150         (stap_generic_check_suffix): Likewise.
2151         (stap_check_integer_suffix): Likewise.
2152         (stap_check_register_suffix): Likewise.
2153         (stap_check_register_indirection_suffix): Likewise.
2154         (stap_parse_register_operand): Likewise.
2155         (stap_parse_single_operand): Likewise.
2156         (stap_parse_argument_1): Likewise.
2157         (stap_probe::get_argument_count): Likewise.
2158         (stap_is_operator): Likewise.
2159
2160 2019-05-16  Tom Tromey  <tromey@adacore.com>
2161
2162         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2163         keyword to foreach.
2164
2165 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
2166
2167         * linux-thread-db.c (try_thread_db_load_1): Change return type
2168         to bool.
2169         (try_thread_db_load): Likewise.
2170         (try_thread_db_load_from_pdir_1): Likewise.
2171         (try_thread_db_load_from_pdir): Likewise.
2172         (try_thread_db_load_from_sdir): Likewise.
2173         (try_thread_db_load_from_dir): Likewise.
2174         (thread_db_load_search): Likewise.
2175         (has_libpthread): Likewise.
2176         (thread_db_load): Likewise.
2177
2178 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
2179
2180         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2181         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2182         NULL, and complain/return if that's the case.
2183
2184 2019-05-15  John Darrington <john@darrington.wattle.id.au>
2185
2186         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2187         (advance, posn, abstract_read_memory): New functions.
2188         [struct mem_read_abstraction]: New struct.
2189         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
2190
2191 2019-05-14  Tom Tromey  <tromey@adacore.com>
2192
2193         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
2194         value is not lval_memory.
2195
2196 2019-05-14  Tom Tromey  <tromey@adacore.com>
2197
2198         * solib.c (info_sharedlibrary_command): Style the file name.
2199
2200 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
2201
2202         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
2203         (aarch64_vnv_type): Likewise.
2204         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
2205         * common/tdesc.c: Likewise.
2206         * common/tdesc.h (enum tdesc_type_kind): Likewise.
2207         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
2208         * features/aarch64-fpu.xml: Add ieee half view.
2209         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
2210         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
2211         * gdbtypes.h (struct builtin_type): Likewise.
2212         (struct objfile_type): Likewise.
2213
2214 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
2215
2216         * language.c (language_sniff_from_mangled_name): Fix "langauge"
2217         typo.
2218         * location.h (string_to_event_location): Likewise.
2219
2220 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
2221
2222         GDB 8.3 released.
2223
2224 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2225
2226         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
2227         New variable declaration.
2228         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
2229         New variable.
2230         (print_one_breakpoint): Use ui_out::test_flags and new global
2231         variable to compute use_fixed_output.
2232         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
2233         Remove.
2234         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
2235         (mi_multi_location_breakpoint_output_fixed): Remove.
2236         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
2237         new variable.
2238         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
2239         fix_multi_location_breakpoint_output flag if version >= 3.
2240         * ui-out.h (enum ui_out_flag)
2241         <fix_multi_location_breakpoint_output>: New enumerator.
2242
2243 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2244
2245         * contrib/cc-with-tweaks.sh: Validate dwz's work.
2246
2247 2019-05-10  Tom Tromey  <tromey@adacore.com>
2248
2249         * ada-lang.c (catch_ada_completer): New function.
2250         (_initialize_ada_language): Use it.
2251
2252 2019-05-10  Tom Tromey  <tromey@adacore.com>
2253
2254         * thread.c (print_thread_info): Make "requested_threads" const.
2255         * gdbthread.h (print_thread_info): Make "requested_threads"
2256         const.
2257         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
2258         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
2259
2260 2019-05-08  Tom Tromey  <tom@tromey.com>
2261
2262         * gdbtypes.c (objfile_type_data): Change type.
2263         (objfile_type, _initialize_gdbtypes): Update.
2264
2265 2019-05-08  Tom Tromey  <tom@tromey.com>
2266
2267         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
2268         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
2269         (_initialize_dwarf2_frame): Update.
2270
2271 2019-05-08  Tom Tromey  <tom@tromey.com>
2272
2273         * objc-lang.c (objc_objfile_data): Change type.
2274         (find_methods): Update.
2275         (_initialize_objc_lang): Remove.
2276
2277 2019-05-08  Tom Tromey  <tom@tromey.com>
2278
2279         * stabsread.c (rs6000_builtin_type_data): Change type.
2280         (rs6000_builtin_type, _initialize_stabsread): Update.
2281
2282 2019-05-08  Tom Tromey  <tom@tromey.com>
2283
2284         * mips-tdep.c (mips_pdr_data): Remove.
2285         (_initialize_mips_tdep): Update.
2286
2287 2019-05-08  Tom Tromey  <tom@tromey.com>
2288
2289         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
2290         (hppa_init_objfile_priv_data, read_unwind_info)
2291         (find_unwind_entry, _initialize_hppa_tdep): Update.
2292
2293 2019-05-08  Tom Tromey  <tom@tromey.com>
2294
2295         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
2296         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
2297         on obstack.
2298         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
2299
2300 2019-05-08  Tom Tromey  <tom@tromey.com>
2301
2302         * mdebugread.c (basic_type_data): Change type.
2303         (basic_type, _initialize_mdebugread): Update.
2304
2305 2019-05-08  Tom Tromey  <tom@tromey.com>
2306
2307         * common/gdb_unique_ptr.h (struct noop_deleter): New.
2308
2309 2019-05-08  Tom Tromey  <tom@tromey.com>
2310
2311         * nto-tdep.c (nto_inferior_data_reg): Change type.
2312         (nto_inferior_data): Update.
2313         (nto_inferior_data_cleanup, nto_new_inferior_data)
2314         (_initialize_nto_tdep): Remove.
2315         * nto-tdep.h (struct nto_inferior_data): Add initializers.
2316
2317 2019-05-08  Tom Tromey  <tom@tromey.com>
2318
2319         * ada-lang.c (struct ada_inferior_data): Add initializers.
2320         (ada_inferior_data): Change type.
2321         (ada_inferior_data_cleanup): Remove.
2322         (get_ada_inferior_data, ada_inferior_exit)
2323         (struct ada_pspace_data): Add initializers, destructor.
2324         (ada_pspace_data_handle): Change type.
2325         (get_ada_pspace_data): Update.
2326         (ada_pspace_data_cleanup): Remove.
2327
2328 2019-05-08  Tom Tromey  <tom@tromey.com>
2329
2330         * coffread.c (struct coff_symfile_info): Add initializers.
2331         (coff_objfile_data_key): Move lower.  Change type.
2332         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
2333         Update.
2334         (coff_free_info): Remove.
2335
2336 2019-05-08  Tom Tromey  <tom@tromey.com>
2337
2338         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
2339         (fbsd_pspace_data_handle): Move lower.  Change type.
2340         (get_fbsd_pspace_data): Update.
2341         (fbsd_pspace_data_cleanup): Remove.
2342         (_initialize_fbsd_tdep): Update.
2343
2344 2019-05-08  Tom Tromey  <tom@tromey.com>
2345
2346         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
2347         (get_ada_tasks_pspace_data): Update.
2348         (ada_tasks_pspace_data_cleanup): Remove.
2349         (_initialize_tasks): Update.
2350         (ada_tasks_inferior_data_handle): Change type.
2351         (get_ada_tasks_inferior_data): Update.
2352         (ada_tasks_inferior_data_cleanup): Remove.
2353         (struct ada_tasks_pspace_data): Add initializers.
2354
2355 2019-05-08  Tom Tromey  <tom@tromey.com>
2356
2357         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
2358         * symfile-debug.c (debug_sym_get_probes): Change type.
2359         * stap-probe.c (handle_stap_probe):
2360         (stap_static_probe_ops::get_probes): Change type.
2361         * probe.h (class static_probe_ops) <get_probes>: Change type.
2362         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
2363         (parse_probes_in_pspace): Update.
2364         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
2365         Update.
2366         (any_static_probe_ops::get_probes): Change type.
2367         * elfread.c (elfread_data): New typedef.
2368         (probe_key): Change type.
2369         (elf_get_probes): Likewise.  Update.
2370         (probe_key_free): Remove.
2371         (_initialize_elfread): Update.
2372         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
2373         Change type.
2374         (dtrace_process_dof_probe, dtrace_process_dof)
2375         (dtrace_static_probe_ops::get_probe): Change type.
2376
2377 2019-05-08  Tom Tromey  <tom@tromey.com>
2378
2379         * xcoffread.c (struct xcoff_symfile_info): Rename from
2380         coff_symfile_info.  Add initializers.
2381         (xcoff_objfile_data_key): Move lower.  Change type.
2382         (XCOFF_DATA): Rewrite.
2383         (xcoff_free_info): Remove.
2384         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
2385         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
2386         (xcoff_initial_scan): Update.
2387
2388 2019-05-08  Tom Tromey  <tom@tromey.com>
2389
2390         * solib-svr4.c (struct svr4_info): Add initializers and
2391         destructor.
2392         <probes_table>: Now an htab_up.
2393         (solib_svr4_pspace_data): Change type.
2394         (free_probes_table): Simplify.
2395         (~svr4_info): Rename from svr4_pspace_data_cleanup.
2396         (get_svr4_info, probes_table_htab_remove_objfile_probes)
2397         (probes_table_remove_objfile_probes, register_solib_event_probe)
2398         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
2399         (_initialize_svr4_solib): Update.
2400
2401 2019-05-08  Tom Tromey  <tom@tromey.com>
2402
2403         * remote.c (remote_pspace_data): Change type.
2404         (remote_pspace_data_cleanup): Remove.
2405         (get_remote_exec_file, set_pspace_remote_exec_file)
2406         (_initialize_remote): Update.
2407
2408 2019-05-08  Tom Tromey  <tom@tromey.com>
2409
2410         * breakpoint.c (breakpoint_objfile_key): Change type.
2411         (get_breakpoint_objfile_data): Update.
2412         (free_breakpoint_objfile_data): Remove.
2413         (_initialize_breakpoint): Update.
2414
2415 2019-05-08  Tom Tromey  <tom@tromey.com>
2416
2417         * linux-tdep.c (struct linux_info): Add initializers.
2418         (linux_inferior_data): Move.  Change type.
2419         (invalidate_linux_cache_inf): Update.
2420         (linux_inferior_data_cleanup): Remove.
2421         (get_linux_inferior_data, _initialize_linux_tdep): Update.
2422
2423 2019-05-08  Tom Tromey  <tom@tromey.com>
2424
2425         * auxv.c (auxv_inferior_data): Move.  Change type.
2426         (auxv_inferior_data_cleanup): Remove.
2427         (invalidate_auxv_cache_inf): Rewrite.
2428         (get_auxv_inferior_data, _initialize_auxv): Update.
2429
2430 2019-05-08  Tom Tromey  <tom@tromey.com>
2431
2432         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
2433         (symfile_debug_objfile_data_key): Change type.
2434         (symfile_debug_installed, debug_qf_has_symbols)
2435         (debug_qf_find_last_source_symtab)
2436         (debug_qf_forget_cached_source_info)
2437         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
2438         (debug_qf_print_stats, debug_qf_dump)
2439         (debug_qf_expand_symtabs_for_function)
2440         (debug_qf_expand_all_symtabs)
2441         (debug_qf_expand_symtabs_with_fullname)
2442         (debug_qf_map_matching_symbols)
2443         (debug_qf_expand_symtabs_matching)
2444         (debug_qf_find_pc_sect_compunit_symtab)
2445         (debug_qf_map_symbol_filenames)
2446         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
2447         (debug_sym_new_init, debug_sym_init, debug_sym_read)
2448         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
2449         (debug_sym_read_linetable, debug_sym_relocate): Update.
2450         (symfile_debug_free_objfile): Remove.
2451         (install_symfile_debug_logging, _initialize_symfile_debug):
2452         Update.
2453
2454 2019-05-08  Tom Tromey  <tom@tromey.com>
2455
2456         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
2457         allocate_on_obstack.
2458         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
2459         (get_dwarf2_per_objfile): Update.
2460         (set_dwarf2_per_objfile): Remove.
2461         (dwarf2_has_info, dwarf2_get_section_info): Update.
2462         (dwarf2_free_objfile): Remove.
2463         (_initialize_dwarf2_read): Update.
2464
2465 2019-05-08  Tom Tromey  <tom@tromey.com>
2466
2467         * auto-load.c (struct auto_load_pspace_info): Add destructor and
2468         initializers.
2469         <unsupported_script_warning_printed,
2470         script_not_found_warning_printed>: Now bool.
2471         (auto_load_pspace_data): Change type.
2472         (~auto_load_pspace_info): Rename from
2473         auto_load_pspace_data_cleanup.
2474         (get_auto_load_pspace_data, init_loaded_scripts_info)
2475         (clear_section_scripts, maybe_print_unsupported_script_warning)
2476         (maybe_print_script_not_found_warning, _initialize_auto_load):
2477         Update.
2478
2479 2019-05-08  Tom Tromey  <tom@tromey.com>
2480
2481         * objfiles.c (objfile_pspace_info): Add destructor and
2482         initializers.
2483         (objfiles_pspace_data): Change type.
2484         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
2485         (get_objfile_pspace_data): Update.
2486         (objfiles_bfd_data): Change type.
2487         (get_objfile_bfd_data): Update.
2488         (objfile_bfd_data_free, _initialize_objfiles): Remove.
2489
2490 2019-05-08  Tom Tromey  <tom@tromey.com>
2491
2492         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
2493         Change type.
2494         (get_catch_syscall_inferior_data): Update.
2495         (catch_syscall_inferior_data_cleanup): Remove.
2496         (_initialize_break_catch_syscall): Update.
2497
2498 2019-05-08  Tom Tromey  <tom@tromey.com>
2499
2500         * inflow.c (struct terminal_info): Add destructor and
2501         initializers.
2502         (inflow_inferior_data): Change type.
2503         (~terminal_info): Rename from inflow_inferior_data_cleanup.
2504         (get_inflow_inferior_data, inflow_inferior_exit)
2505         (swap_terminal_info, _initialize_inflow): Update.
2506
2507 2019-05-08  Tom Tromey  <tom@tromey.com>
2508
2509         * target-dcache.c (target_dcache_cleanup): Remove.
2510         (target_dcache_aspace_key): Change type.
2511         (target_dcache_init_p, target_dcache_invalidate)
2512         (target_dcache_get, target_dcache_get_or_init)
2513         (_initialize_target_dcache): Update.
2514         * dcache.h (struct dcache_deleter): New.
2515
2516 2019-05-08  Tom Tromey  <tom@tromey.com>
2517
2518         * symtab.c (struct symbol_cache): Add destructor and
2519         initializers.
2520         (symbol_cache_key): Move.  Change type.
2521         (make_symbol_cache, free_symbol_cache): Remove.
2522         (get_symbol_cache): Update.
2523         (symbol_cache_cleanup): Remove.
2524         (ALL_PSPACES, symbol_cache_flush)
2525         (maintenance_print_symbol_cache)
2526         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
2527         Update.
2528
2529 2019-05-08  Tom Tromey  <tom@tromey.com>
2530
2531         * symtab.c (struct main_info): Add destructor and initializers.
2532         (main_progspace_key): Move.  Change type.
2533         (get_main_info): Update.
2534         (main_info_cleanup): Remove.
2535         (_initialize_symtab): Update.
2536
2537 2019-05-08  Tom Tromey  <tom@tromey.com>
2538
2539         * registry.h (DECLARE_REGISTRY): Define the _key class.
2540
2541 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2542
2543         * NEWS: Merge two 'New commands' sections.
2544
2545 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
2546
2547         * ada-valprint.c (ada_val_print_gnat_array): Remove language
2548         parameter and use Ada language definition instead.
2549         (ada_val_print_ptr): Remove unused language parameter.
2550         (ada_val_print_num): Remove language parameter and use Ada language
2551         definition instead.
2552         (ada_val_print_enum, ada_val_print_flt): Remove unused language
2553         parameter.
2554         (ada_val_print_struct_union, ada_val_print_ref): Remove language
2555         parameter and use Ada language definition instead.
2556         (ada_val_print_1): Update all ada_val_print_xxx calls.
2557         Remove language parameter.
2558         (ada_val_print): Update ada_val_print_1 call.
2559
2560 2019-05-08  Tom Tromey  <tromey@adacore.com>
2561
2562         * remote.c (remote_hw_watchpoint_limit)
2563         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
2564         Now static.
2565
2566 2019-05-08  Tom Tromey  <tromey@adacore.com>
2567
2568         * maint.c (_initialize_maint_cmds): Move initialization code to
2569         remote.c.
2570         (watchdog, show_watchdog): Move to remote.c.
2571         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
2572         "watchdog" static.
2573         (_initialize_remote): Move initialization code from maint.c.
2574         * defs.h (watchdog): Don't declare.
2575
2576 2019-05-08  Tom Tromey  <tromey@adacore.com>
2577
2578         * tui/tui-interp.c: Include main.h.
2579         * interps.c: Include main.h.
2580         * main.h (interpreter_p): Declare.
2581         * defs.h (interpreter_p): Don't declare.
2582
2583 2019-05-08  Tom Tromey  <tromey@adacore.com>
2584
2585         * dwarf2loc.c: Include dwarf2read.h.
2586         * defs.h (read_unsigned_leb128): Don't declare.
2587         * dwarf2read.h (read_unsigned_leb128): Declare.
2588
2589 2019-05-08  Tom Tromey  <tromey@adacore.com>
2590
2591         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
2592         method.
2593
2594 2019-05-08  Tom Tromey  <tromey@adacore.com>
2595
2596         * utils.c (fputs_maybe_filtered): Reset style after paging, even
2597         when no wrap column is set.
2598
2599 2019-05-08  Tom Tromey  <tromey@adacore.com>
2600
2601         * c-lang.c (c_get_string): Handle non-C-style arrays.
2602
2603 2019-05-08  Tom Tromey  <tromey@adacore.com>
2604
2605         * typeprint.c (print_offset_data::update): Print the bit offset,
2606         not the number of bits remaining.
2607
2608 2019-05-08  Tom Tromey  <tromey@adacore.com>
2609
2610         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
2611         padding at end of comment.
2612
2613 2019-05-08  Tom Tromey  <tromey@adacore.com>
2614
2615         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
2616         Compare main types.
2617
2618 2019-05-06  Tom Tromey  <tom@tromey.com>
2619
2620         * common/scoped_mmap.c: Include common-defs.h.
2621         * common/scoped_mmap.h: Don't include config.h.
2622
2623 2019-05-04  Tom Tromey  <tom@tromey.com>
2624
2625         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
2626         (struct aarch64_call_info): Add initializers.
2627         <si>: Now a std::vector.
2628         (pass_on_stack, aarch64_push_dummy_call): Update.
2629
2630 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
2631             Tom Tromey  <tom@tromey.com>
2632
2633         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
2634         (ppc_threads): Now a std::vector.  Now static.
2635         (hwdebug_find_thread_points_by_tid)
2636         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
2637         Update.
2638
2639 2019-05-04  Tom Tromey  <tom@tromey.com>
2640
2641         * arc-tdep.c (arc_tdesc_init): Return bool.
2642
2643 2019-05-04  Tom Tromey  <tom@tromey.com>
2644
2645         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
2646         Use gdb_assert_not_reached.
2647
2648 2019-05-04  Tom Tromey  <tom@tromey.com>
2649
2650         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
2651         "false".
2652
2653 2019-05-04  Tom Tromey  <tom@tromey.com>
2654
2655         * arc-tdep.c (arc_tdesc_init): Use bool.
2656
2657 2019-05-04  Tom Tromey  <tom@tromey.com>
2658
2659         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
2660
2661 2019-05-04  Tom Tromey  <tom@tromey.com>
2662
2663         * cli/cli-cmds.c (valid_command_p): Return bool.
2664
2665 2019-05-04  Tom Tromey  <tom@tromey.com>
2666
2667         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
2668         * command.h (valid_user_defined_cmd_name_p): Channge return type.
2669
2670 2019-05-04  Raul Tambre  <raul@tambre.ee>
2671
2672         * python/lib/gdb/prompt.py (_ExtendedPrompt)
2673         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
2674         operator for comparison.
2675
2676 2019-05-04  Tom Tromey  <tom@tromey.com>
2677
2678         * psymtab.c (psymbol_name_matches, match_partial_symbol)
2679         (lookup_partial_symbol, print_partial_symbols)
2680         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
2681         (psymbol_compare): Update.
2682         (add_psymbol_to_bcache): Clear the entire psymbol.
2683         (maintenance_check_psymtabs): Update.
2684         * psympriv.h (struct partial_symbol): Don't derive from
2685         general_symbol_info.
2686         <obj_section, unrelocated_address, address,
2687         set_unrelocated_address>: Update.
2688         <ginfo>: New member.
2689         * dwarf-index-write.c (write_psymbols, debug_names::insert)
2690         (debug_names::write_psymbols): Update.
2691
2692 2019-05-04  Tom de Vries  <tdevries@suse.de>
2693
2694         * contrib/cc-with-tweaks.sh: Support -n arg.
2695
2696 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2697
2698         * corelow.c (core_target::detach): Ensure frame cache and
2699         register caches are cleared.
2700         inferior.c (exit_inferior_1): Likewise.
2701
2702 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
2703             Tom Tromey  <tom@tromey.com>
2704
2705         * dictionary.c (collate_pending_symbols_by_language): Remove
2706         "struct" from foreach.
2707         * symtab.c (lookup_global_symbol_from_objfile)
2708         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
2709         foreach.
2710         * ser-tcp.c (net_open): Remove "struct" from foreach.
2711         * objfiles.c (objfile_relocate, objfile_rebase)
2712         (objfile_has_symbols): Remove "struct" from foreach.
2713         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
2714         from foreach.
2715         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
2716         foreach.
2717         * darwin-nat.c (thread_info_from_private_thread_info): Remove
2718         "struct" from foreach.
2719         * ada-lang.c (create_excep_cond_exprs)
2720         (ada_exception_catchpoint_cond_string): Remove "struct" from
2721         foreach.
2722
2723 2019-05-03  Tom Tromey  <tromey@adacore.com>
2724
2725         * ada-exp.y (convert_char_literal): Check suffix of each
2726         enumerator.
2727
2728 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
2729
2730         PR ada/21406:
2731         * ada-exp.y (yywrap): Don't define.
2732         * ada-lex.l (%option): Add noyywrap
2733         (yywrap): Remove.
2734
2735 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
2736
2737         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
2738         _WIN32_WINNT to the XP level, unless already defined to a higher
2739         level.
2740
2741         * unittests/parse-connection-spec-selftests.c:
2742         * ser-tcp.c:
2743         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
2744         override.
2745
2746         * symfile.c (find_separate_debug_file): Remove colon from the
2747         drive spec of DOS/Windows file names of the target, so that the
2748         file name produced from DEBUGDIR and the target's directory will
2749         be valid on DOS/Windows systems.
2750
2751 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2752
2753         * rust-lang.c (val_print_struct): Handle printing structures
2754         containing strings.
2755
2756 2019-05-02  Tom Tromey  <tromey@adacore.com>
2757
2758         * valarith.c (_initialize_valarith): Remove.
2759
2760 2019-05-01  Tom Tromey  <tromey@adacore.com>
2761
2762         * ada-lang.c (ada_value_primitive_field): Treat more fields as
2763         bitfields.
2764
2765 2019-05-01  Tom Tromey  <tromey@adacore.com>
2766
2767         * ada-lang.c (ada_value_assign): Correctly compute starting offset
2768         for big-endian copies.
2769
2770 2019-04-30  Ali Tamur  <tamur@google.com>
2771         * gdb/dwarf2read.c (read_3_bytes): New declaration.
2772         (read_attribute_value): Added DW_FORM_strx1-4 cases.
2773         (read_3_bytes): New function.
2774
2775 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2776
2777         * windows-nat.c (main_thread_id): Delete.
2778         (handle_output_debug_string): Replace main_thread_id by
2779         current_event.dwThreadId.
2780         (fake_create_process): Likewise.
2781         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
2782         Do not set main_thread_id.
2783         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
2784         current_event.dwThreadId.
2785         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
2786
2787 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2788
2789         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
2790         Use current_event.dwThreadId instead of main_thread_id.
2791
2792 2019-04-30  Tom Tromey  <tromey@adacore.com>
2793
2794         * ada-lang.c (ada_lookup_simple_minsyms): New function.
2795         (create_excep_cond_exprs): Iterate over program spaces.
2796         (ada_exception_catchpoint_cond_string): Examine all minimal
2797         symbols for exception types.
2798
2799 2019-04-30  Tom Tromey  <tromey@adacore.com>
2800
2801         PR c++/24470:
2802         * dwarf2read.c (process_structure_scope): Handle case where type
2803         has template parameters but no symbol was created.
2804
2805 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2806             Chris January  <chris.january@arm.com>
2807
2808         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
2809         qualifier.
2810         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
2811
2812 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2813
2814         * f-typeprint.c (f_print_type): Update rules for printing
2815         whitespace.
2816         (f_type_print_varspec_suffix): Likewise.
2817
2818 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2819             Chris January  <chris.january@arm.com>
2820
2821         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
2822         function arguments.
2823
2824 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2825
2826         * f-lang.c (build_fortran_types): Change name of void type to
2827         lower case.
2828         * f-typeprint.c (f_type_print_base): Print the name of the void
2829         type, rather than a fixed string.
2830         * f-valprint.c (f_decorations): Use lower case void string.
2831
2832 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2833             Chris January  <chris.january@arm.com>
2834
2835         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
2836         types for Fortran.
2837
2838 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2839             Chris January  <chris.january@arm.com>
2840             David Lecomber  <david.lecomber@arm.com>
2841
2842         * f-exp.y (BINOP_INTRINSIC): New token.
2843         (exp): New parser rule handling BINOP_INTRINSIC.
2844         (f77_keywords): Add new builtin procedures.
2845         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
2846         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2847         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
2848         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2849         (print_unop_subexp_f): New function.
2850         (print_binop_subexp_f): New function.
2851         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2852         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2853         (dump_subexp_body_f): Likewise.
2854         (operator_check_f): Likewise.
2855         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2856         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
2857
2858 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2859
2860         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
2861         UNOP_KIND.
2862         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
2863         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
2864         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
2865         (operator_length_f): New fuction.
2866         (print_subexp_f): New function.
2867         (op_name_f): New function.
2868         (dump_subexp_body_f): New function.
2869         (operator_check_f): New function.
2870         (exp_descriptor_f): Replace standard expression handling functions
2871         with new functions.
2872         * gdb/fortran-operator.def: New file.
2873         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
2874         * gdb/std-operator.def: Remove UNOP_KIND.
2875
2876 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2877
2878         * std-operator.def: Remove unbalanced, stray double quote
2879         character.
2880
2881 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2882             Chris January  <chris.january@arm.com>
2883             Daniel Everett  <daniel.everett@arm.com>
2884             Nick Forrington  <nick.forrington@arm.com>
2885             Richard Bunt  <richard.bunt@arm.com>
2886
2887         * cp-valprint.c (cp_print_value_fields): Allow an additional level
2888         of depth when printing anonymous structs or unions.
2889         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
2890         Don't print either the top-level value, or the children if the
2891         max-depth is exceeded.
2892         (ppscm_print_children): When printing the key of a map, allow one
2893         extra level of depth.
2894         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
2895         print either the top-level value, or the children if the max-depth
2896         is exceeded.
2897         (print_children): When printing the key of a map, allow one extra
2898         level of depth.
2899         * python/py-value.c (valpy_format_string): Add max_depth keyword.
2900         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
2901         (user_print_options): Initialise max_depth field.
2902         (val_print_scalar_or_string_type_p): New function.
2903         (val_print): Check to see if the max depth has been reached.
2904         (val_print_check_max_depth): Define new function.
2905         (show_print_max_depth): New function.
2906         (_initialize_valprint): Add 'print max-depth' option.
2907         * valprint.h (struct value_print_options) <max_depth>: New field.
2908         (val_print_check_max_depth): Declare new function.
2909         * NEWS: Document new feature.
2910
2911 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2912
2913         * ada-lang.c (ada_language_defn): Initialise new field.
2914         * c-lang.c (c_is_string_type_p): New function.
2915         (c_language_defn): Initialise new field.
2916         (cplus_language_defn): Initialise new field.
2917         (asm_language_defn): Initialise new field.
2918         (minimal_language_defn): Initialise new field.
2919         * c-lang.h (c_is_string_type_p): Declare new function.
2920         * d-lang.c (d_language_defn): Initialise new field.
2921         * f-lang.c (f_is_string_type_p): New function.
2922         (f_language_defn): Initialise new field.
2923         * go-lang.c (go_is_string_type_p): New function.
2924         (go_language_defn): Initialise new field.
2925         * language.c (default_is_string_type_p): New function.
2926         (unknown_language_defn): Initialise new field.
2927         (auto_language_defn): Initialise new field.
2928         * language.h (struct language_defn) <la_is_string_type_p>: New
2929         member variable.
2930         (default_is_string_type_p): Declare new function.
2931         * m2-lang.c (m2_language_defn): Initialise new field.
2932         * objc-lang.c (objc_language_defn): Initialise new field.
2933         * opencl-lang.c (opencl_language_defn): Initialise new field.
2934         * p-lang.c (pascal_is_string_type_p): New function.
2935         (pascal_language_defn): Initialise new field.
2936         * rust-lang.c (rust_is_string_type_p): New function.
2937         (rust_language_defn): Initialise new field.
2938
2939 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2940
2941         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
2942         New field.
2943         * ada-lang.c (ada_language_defn): Initialise new field.
2944         * c-lang.c (c_language_defn): Likewise.
2945         (cplus_language_defn): Likewise.
2946         (asm_language_defn): Likewise.
2947         (minimal_language_defn): Likewise.
2948         * d-lang.c (d_language_defn): Likewise.
2949         * f-lang.c (f_language_defn): Likewise.
2950         * go-lang.c (go_language_defn): Likewise.
2951         * language.c (unknown_language_defn): Likewise.
2952         (auto_language_defn): Likewise.
2953         * m2-lang.c (m2_language_defn): Likewise.
2954         * objc-lang.c (objc_language_defn): Likewise.
2955         * opencl-lang.c (opencl_language_defn): Likewise.
2956         * p-lang.c (pascal_language_defn): Likewise.
2957         * rust-lang.c (rust_language_defn): Likewise.
2958
2959 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2960
2961         * ada-lang.c (ada_is_character_type): Change return type to bool.
2962         (ada_is_string_type): Likewise.
2963         * ada-lang.h (ada_is_character_type): Update declaration
2964         (ada_is_string_type): Likewise.
2965
2966 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2967
2968         Support style in 'frame|thread apply'
2969
2970         * gdbcmd.h (execute_command_to_string): New term_out parameter.
2971         * record.c (record_start, record_stop): Update callers of
2972         execute_command_to_string with false.
2973         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
2974         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
2975         methods.
2976         (class string_file): New constructor with term_out parameter.
2977         Override methods term_out and can_emit_style_escape.  New member
2978         term_out.
2979         (class stdio_file): Override can_emit_style_escape.
2980         (class tee_file): Override term_out and can_emit_style_escape.
2981         * utils.h (can_emit_style_escape): Remove.
2982         * utils.c (can_emit_style_escape): Likewise.
2983         Update all callers of can_emit_style_escape (SOMESTREAM) to
2984         SOMESTREAM->can_emit_style_escape.
2985         * source-cache.c (source_cache::get_source_lines): Likewise.
2986         * stack.c (frame_apply_command_count): Call execute_command_to_string
2987         passing the term_out characteristic of the current gdb_stdout.
2988         * thread.c (thr_try_catch_cmd): Likewise.
2989         * top.c (execute_command_to_string): pass term_out parameter
2990         to construct the string_file for the command output.
2991         * ui-file.c (term_cli_styling): New function (most code moved
2992         from utils.c can_emit_style_escape).
2993         (string_file::string_file, string_file::can_emit_style_escape,
2994         stdio_file::can_emit_style_escape, tee_file::term_out,
2995         tee_file::can_emit_style_escape): New functions.
2996
2997 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2998
2999         * NEWS: Mention the new set|show may-call-functions.
3000         * infcall.c (may_call_functions_p): New variable.
3001         (show_may_call_functions_p): New function.
3002         (call_function_by_hand_dummy): Throws an error if not
3003         may-call-functions.
3004         (_initialize_infcall): Call add_setshow_boolean_cmd for
3005         may-call-functions.
3006
3007 2019-04-25  Keith Seitz  <keiths@redhat.com>
3008
3009         PR c++/24367
3010         * cp-support.c (inspect_type): Don't attempt substitutions
3011         of symbol with the same name.
3012
3013 2019-04-25  Tom Tromey  <tromey@adacore.com>
3014
3015         PR gdb/24475:
3016         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
3017         static.
3018
3019 2019-04-25  Tom Tromey  <tromey@adacore.com>
3020
3021         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
3022         rvalue reference.
3023         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
3024         (gdb_xml_parser::parse): Use std::move.
3025         * python/python-internal.h (gdbpy_convert_exception): Take a const
3026         reference.
3027         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
3028         std::move.
3029         * python/py-utils.c (gdbpy_convert_exception): Take a const
3030         reference.
3031         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3032         Use std::move.
3033         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3034         Use std::move.
3035         * mi/mi-main.c (mi_print_exception): Take a const reference.
3036         * main.c (handle_command_errors): Take a const reference.
3037         * linespec.c (parse_linespec): Use std::move.
3038         * infcall.c (run_inferior_call): Use std::move.
3039         (call_function_by_hand_dummy): Use std::move.
3040         * exec.c (try_open_exec_file): Use std::move.
3041         * exceptions.h (exception_print, exception_fprintf)
3042         (exception_print_same): Update.
3043         * exceptions.c (print_exception, exception_print)
3044         (exception_fprintf, exception_print_same): Change parameters to
3045         const reference.
3046         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
3047         * common/new-op.c: Use std::move.
3048         * common/common-exceptions.h (struct gdb_exception): Add move
3049         constructor.
3050         (struct gdb_exception_error, struct gdb_exception_quit, struct
3051         gdb_quit_bad_alloc): Change constructor to move constructor.
3052         (throw_exception): Change parameter to rvalue reference.
3053         * common/common-exceptions.c (throw_exception): Take rvalue
3054         reference.
3055         * cli/cli-interp.c (safe_execute_command): Use std::move.
3056         * breakpoint.c (insert_bp_location, location_to_sals): Use
3057         std::move.
3058
3059 2019-04-25  Tom Tromey  <tromey@adacore.com>
3060
3061         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
3062         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
3063         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
3064         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
3065         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
3066         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
3067         guile/scm-value.c: Use unpack.
3068         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
3069         gdbscm_gdb_exception.
3070         (gdbscm_throw_gdb_exception): Likewise.
3071         (struct gdbscm_gdb_exception): New.
3072         (unpack): New function.
3073         (gdbscm_wrap): Use unpack.
3074
3075 2019-04-25  Tom Tromey  <tromey@adacore.com>
3076
3077         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3078         (gdb_rl_callback_handler): Use std::move.
3079         * common/common-exceptions.h (struct gdb_exception): Add move
3080         assignment operator.
3081         (throw_exception_sjlj): Change "exception" to const reference.
3082         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
3083         (throw_exception_sjlj): Change "exception" to const reference.
3084
3085 2019-04-25  Tom Tromey  <tromey@adacore.com>
3086
3087         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
3088         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
3089         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3090         Update.
3091         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3092         Update.
3093         * mi/mi-interp.c (mi_interp::exec): Update.
3094         * linespec.c (parse_linespec): Update.
3095         * infcall.c (run_inferior_call): Update.
3096         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
3097         * guile/scm-symbol.c (gdbscm_lookup_symbol)
3098         (gdbscm_lookup_global_symbol): Update.
3099         * guile/scm-param.c (gdbscm_parameter_value): Update.
3100         * guile/scm-frame.c (gdbscm_frame_read_register)
3101         (gdbscm_frame_read_var): Update.
3102         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
3103         * exec.c (try_open_exec_file): Update.
3104         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3105         (gdb_rl_callback_handler): Update.
3106         * common/common-exceptions.h (exception_none): Don't declare.
3107         * common/common-exceptions.c (exception_none): Don't define.
3108         (struct catcher) <exception>: Update.
3109         * cli/cli-interp.c (safe_execute_command): Update.
3110         * breakpoint.c (insert_bp_location, location_to_sals): Update.
3111
3112 2019-04-25  Ali Tamur  <tamur@google.com>
3113
3114         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
3115         (read_attribute_value): Likewise.
3116         (dwarf2_read_addr_index): Update comment.
3117         (read_str_index): Add DW_FORM_strx.
3118         (dwarf2_string_attr): Likewise.
3119         (dwarf2_const_value_attr): Likewise.
3120         (dump_die_shallow): Likewise.
3121         (dwarf2_fetch_constant_bytes): Likewise.
3122         (skip_form_bytes): Likewise.
3123         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3124
3125 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
3126
3127         PR corefiles/11608
3128         PR corefiles/18187
3129         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3130         OFFSET.  Verify if current mapping contains an ELF header.
3131         (linux_find_memory_regions_full): Adjust call to
3132         dump_mapping_p.
3133
3134 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
3135             Kang Li <kanglictf@gmail.com>
3136
3137         PR gdb/21600
3138
3139         * dwarf2-frame.c (read_initial_length): Be consistent about using
3140         unsigned representation of length.
3141         (decode_frame_entry_1): Likewise.  Check for wraparound of
3142         end pointer as well as buffer overflow.
3143
3144 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3145
3146         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3147         "vq".
3148
3149 2019-04-24  Tom Tromey  <tromey@adacore.com>
3150
3151         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3152
3153 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3154
3155         * s12z-tdep.c (s12z_unwind_pc): Delete.
3156         (s12z_unwind_sp): Delete.
3157         (s12z_gdbarch_init): Don't register deleted functions with
3158         gdbarch.
3159
3160 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3161
3162         * rl78-tdep.c (rl78_unwind_sp): Delete.
3163         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3164
3165 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3166
3167         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3168         (xstormy16_unwind_pc): Delete.
3169         (xstormy16_dummy_id): Delete.
3170         (xstormy16_gdbarch_init): Don't register deleted functions with
3171         gdbarch.
3172
3173 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3174
3175         * vax-tdep.c (vax_unwind_pc): Delete.
3176         (vax_gdbarch_init): Don't register deleted function with gdbarch.
3177
3178 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3179
3180         * v850-tdep.c (v850_unwind_sp): Delete.
3181         (v850_unwind_pc): Delete.
3182         (v850_dummy_id): Delete.
3183         (v850_gdbarch_init): Don't register deleted functions with
3184         gdbarch.
3185
3186 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3187
3188         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
3189         (tilegx_unwind_pc): Delete.
3190         (tilegx_unwind_dummy_id): Delete.
3191         (tilegx_gdbarch_init): Don't register deleted functions with
3192         gdbarch.
3193
3194 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3195
3196         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
3197         (tic6x_dummy_id): Delete.
3198         (tic6x_gdbarch_init): Don't register deleted functions with
3199         gdbarch.
3200
3201 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3202
3203         * sparc-tdep.c (sparc_unwind_pc): Delete.
3204         (sparc32_gdbarch_init): Don't register deleted function with
3205         gdbarch.
3206
3207 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3208
3209         * sh-tdep.c (sh_unwind_sp): Delete.
3210         (sh_unwind_pc): Delete.
3211         (sh_dummy_id): Delete.
3212         (sh_gdbarch_init): Don't register deleted functions with
3213         gdbarch.
3214
3215 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3216
3217         * score-tdep.c (score_unwind_sp): Delete.
3218         (score_unwind_pc): Delete.
3219         (score_dummy_id): Delete.
3220         (score_gdbarch_init): Don't register deleted functions with
3221         gdbarch.
3222
3223 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3224
3225         * rx-tdep.c (rx_unwind_pc): Delete.
3226         (rx_unwind_sp): Delete.
3227         (rx_dummy_id): Delete.
3228         (rx_gdbarch_init): Don't register deleted functions with
3229         gdbarch.  Update comment.
3230
3231 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3232
3233         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
3234         (rs6000_dummy_id): Delete.
3235         (rs6000_gdbarch_init): Don't register deleted functions with
3236         gdbarch.
3237
3238 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3239
3240         * or1k-tdep.c (or1k_dummy_id): Delete.
3241         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
3242
3243 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3244
3245         * nios2-tdep.c (nios2_dummy_id): Delete.
3246         (nios2_unwind_sp): Delete.
3247         (nios2_gdbarch_init): Don't register deleted functions with
3248         gdbarch.
3249
3250 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3251
3252         * nds32-tdep.c (nds32_dummy_id): Delete.
3253         (nds32_unwind_pc): Delete.
3254         (nds32_unwind_sp): Delete.
3255         (nds32_gdbarch_init): Don't register deleted functions with
3256         gdbarch.
3257
3258 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3259
3260         * msp430-tdep.c (msp430_unwind_pc): Delete.
3261         (msp430_unwind_sp): Delete.
3262         (msp430_dummy_id): Delete.
3263         (msp430_gdbarch_init): Don't register deleted functions with
3264         gdbarch.
3265
3266 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3267
3268         * moxie-tdep.c (moxie_unwind_sp): Delete.
3269         (moxie_unwind_pc): Delete.
3270         (moxie_dummy_id): Delete.
3271         (moxie_gdbarch_init): Don't register deleted functions with
3272         gdbarch.
3273
3274 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3275
3276         * mn10300-tdep.c (mn10300_dummy_id): Delete.
3277         (mn10300_unwind_pc): Delete.
3278         (mn10300_unwind_sp): Delete.
3279         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
3280         mn10300_unwind_sp.
3281         (mn10300_frame_unwind_init): Don't register deleted functions with
3282         gdbarch.
3283
3284 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3285
3286         * mep-tdep.c (mep_unwind_pc): Delete.
3287         (mep_unwind_sp): Delete.
3288         (mep_dummy_id): Delete.
3289         (mep_gdbarch_init): Don't register deleted functions with
3290         gdbarch.
3291
3292 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3293
3294         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
3295         (m68hc11_unwind_sp): Delete.
3296         (m68hc11_gdbarch_init): Don't register deleted functions with
3297         gdbarch.
3298
3299 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3300
3301         * m32r-tdep.c (m32r_unwind_sp): Delete.
3302         (m32r_unwind_pc): Delete.
3303         (m32r_dummy_id): Delete.
3304         (m32r_gdbarch_init): Don't register deleted functions with
3305         gdbarch.
3306
3307 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3308
3309         * m32c-tdep.c (m32c_unwind_pc): Delete.
3310         (m32c_unwind_sp): Delete.
3311         (m32c_dummy_id): Delete.
3312         (m32c_gdbarch_init): Don't register deleted functions with
3313         gdbarch.
3314
3315 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3316
3317         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
3318         (lm32_unwind_pc): Delete.
3319         (lm32_dummy_id): Delete.
3320         (lm32_gdbarch_init): Don't register deleted functions with
3321         gdbarch.
3322
3323 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3324
3325         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
3326         (iq2000_unwind_pc): Delete.
3327         (iq2000_dummy_id): Delete.
3328         (iq2000_gdbarch_init): Don't register deleted functions with
3329         gdbarch.
3330
3331 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3332
3333         * nds32-tdep.c (nds32_type_align): Delete.
3334         (nds32_push_dummy_call): Use type_align instead.
3335
3336 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3337
3338         * arm-tdep.c (arm_type_align): Only handle vector override case.
3339         (arm_push_dummy_call): Use type_align.
3340         (arm_gdbarch_init): Register arm_type_align gdbarch function.
3341
3342 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3343
3344         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
3345         case.
3346         (pass_on_stack): Use type_align.
3347         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
3348         function.
3349
3350 2019-04-23  Tom Tromey  <tromey@adacore.com>
3351
3352         * dwarf2read.c (line_header::file_name_at): Remove unused
3353         overload.
3354
3355 2019-04-23  Tom de Vries  <tdevries@suse.de>
3356
3357         PR gdb/24438
3358         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
3359         invocation.
3360
3361
3362 2019-03-27  Ali Tamur  <tamur@google.com>
3363
3364         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
3365         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
3366         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
3367         (dwarf_expr_context::get_addr_index): Likewise
3368         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
3369         (symbol_needs_eval_context::get_addr_index): Likewise
3370         (disassemble_dwarf_expression): Add DW_OP_addrx
3371         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
3372         (read_cutu_die_from_dwo): Update comment
3373         (skip_one_die): Add DW_FORM_addrx
3374         (read_attribute_value): Likewise
3375         (var_decode_location): Add DW_OP_addrx
3376         (dwarf2_const_value_attr): Add DW_FORM_addrx
3377         (dump_die_shallow): Likewise
3378         (dwarf2_fetch_constant_bytes): Likewise
3379         (decode_locdesc): Add DW_OP_addrx
3380         (skip_form_bytes): Add DW_FORM_addrx
3381
3382 2019-04-22  Ali Tamur  <tamur@google.com>
3383
3384         * MAINTAINERS (Write After Approval): Add self.
3385
3386 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
3387
3388         * solib-svr4.c (get_svr4_info): Add pspace parameter.
3389         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
3390         (open_symbol_file_object): Likewise.
3391         (svr4_default_sos): Add info parameter.
3392         (svr4_read_so_list): Likewise.
3393         (svr4_current_sos_direct): Adjust functions calls to pass down
3394         info.
3395         (svr4_current_sos_1): Add info parameter.
3396         (svr4_current_sos): Call get_svr4_info, pass info down to
3397         svr4_current_sos_1.
3398         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
3399         get_svr4_info.
3400         (svr4_in_dynsym_resolve_code): Pass current_program_space to
3401         get_svr4_info.
3402         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
3403         to get_svr4_info.
3404         (probes_table_remove_objfile_probes): Likewise.
3405         (register_solib_event_probe): Add info parameter.
3406         (solist_update_incremental): Pass info parameter down to
3407         svr4_read_so_list.
3408         (disable_probes_interface): Add info parameter.
3409         (svr4_handle_solib_event): Pass current_program_space to
3410         get_svr4_info.  Adjust disable_probes_interface cleanup.
3411         (svr4_create_probe_breakpoints): Add info parameter, pass it
3412         down to register_solib_event_probe.
3413         (svr4_create_solib_event_breakpoints): Add info parameter,
3414         pass it down to svr4_create_probe_breakpoints.
3415         (enable_break): Pass info down to
3416         svr4_create_solib_event_breakpoints.
3417         (svr4_solib_create_inferior_hook): Pass current_program_space to
3418         get_svr4_info.
3419         (svr4_clear_solib): Likewise.
3420
3421 2019-04-22  Pedro Alves  <palves@redhat.com>
3422
3423         * solib-svr4.c (svr4_free_objfile_observer): New.
3424         (probe_and_action::objfile): New field.
3425         (probes_table_htab_remove_objfile_probes)
3426         (probes_table_remove_objfile_probes): New functions.
3427         (register_solib_event_probe): Add 'objfile' parameter.  Store it
3428         in the new probe_and_action.  Don't store the probe in 'lookup'.
3429         (svr4_create_probe_breakpoints): Pass objfile to
3430         register_solib_event_probe.
3431         (_initialize_svr4_solib): Register a free_objfile observer.
3432
3433 2019-04-19  Tom Tromey  <tom@tromey.com>
3434
3435         * common/queue.h: Remove.
3436
3437 2019-04-19  Tom Tromey  <tom@tromey.com>
3438
3439         * event-loop.c: Don't include "common/queue.h".
3440
3441 2019-04-19  Tom Tromey  <tom@tromey.com>
3442
3443         * remote.c (remote_target): Use delete.
3444         * remote-notif.h: Include <list>, not "common/queue.h".
3445         (notif_client_p): Remove typedef.
3446         (remote_notif_state): Add constructor, destructor, initializer.
3447         <notif_queue>: Now a std::list.
3448         (remote_notif_state_xfree): Don't declare.
3449         * remote-notif.c (remote_notif_process, handle_notification)
3450         (remote_notif_state_allocate): Update.
3451         (~remote_notif_state): Rename from remote_notif_state_xfree.
3452
3453 2019-04-19  Tom Tromey  <tom@tromey.com>
3454
3455         * symfile.c (reread_symbols): Update.
3456         * objfiles.c (objfile_register_static_link)
3457         (objfile_lookup_static_link): Update
3458         (~objfile) Don't delete static_links.
3459         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
3460
3461 2019-04-19  Tom Tromey  <tom@tromey.com>
3462
3463         * type-stack.h (struct type_stack) <insert>: Constify string.
3464         * type-stack.c (type_stack::insert): Constify string.
3465         * gdbtypes.h (lookup_template_type): Update.
3466         (address_space_name_to_int): Update.
3467         * gdbtypes.c (address_space_name_to_int): Make space_identifier
3468         const.
3469         (lookup_template_type): Make name const.
3470         * c-exp.y: Update rules.
3471         (lex_one_token, classify_name, classify_inner_name)
3472         (c_print_token): Update.
3473         * p-exp.y: Update rules.
3474         (yylex): Update.
3475         * f-exp.y: Update rules.
3476         (yylex): Update.
3477         * d-exp.y: Update rules.
3478         (lex_one_token, classify_name, classify_inner_name): Update.
3479         * parse.c (write_dollar_variable, copy_name): Return std::string.
3480         * parser-defs.h (copy_name): Change return type.
3481         * m2-exp.y: Update rules.
3482         (yylex): Update.
3483         * go-exp.y (lex_one_token): Update.
3484         Update rules.
3485         (classify_unsafe_function, classify_packaged_name)
3486         (classify_name, yylex): Update.
3487
3488 2019-04-19  Sergei Trofimovich <siarheit@google.com>
3489
3490         * configure.ac: add --enable-source-highlight switch.
3491         * configure: Regenerate.
3492         * top.c (print_gdb_version): plumb --enable-source-highlight
3493         status to "show configuration".
3494
3495 2019-04-19  Tom Tromey  <tromey@adacore.com>
3496
3497         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
3498         Check ADA_TYPE_P.
3499         (empty_record, ada_template_to_fixed_record_type_1)
3500         (template_to_static_fixed_type)
3501         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
3502         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
3503         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
3504         macros.
3505
3506 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
3507
3508         PR symtab/24423:
3509         * source.c (print_source_lines_base): Advance "iter" when a
3510         control character is seen.
3511
3512 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3513
3514         * inferior.h (struct infcall_suspend_state_deleter):
3515         Catch exception in destructor to avoid crash.
3516
3517 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3518
3519         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
3520         close to the add_com "shell".
3521
3522 2019-04-18  Tom Tromey  <tromey@adacore.com>
3523
3524         * process-stratum-target.h (class process_stratum_target)
3525         <stratum>: Add "final".
3526
3527 2019-04-17  Tom Tromey  <tromey@adacore.com>
3528
3529         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
3530         against nullptr before use.
3531
3532 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
3533
3534         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
3535
3536 2019-04-17  Jim Wilson  <jimw@sifive.com>
3537             Andrew Burgess  <andrew.burgess@embecosm.com>
3538
3539         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
3540         code read might fail, assume 4-byte breakpoint in that case.
3541
3542 2019-04-15  Leszek Swirski  <leszeks@google.com>
3543
3544         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
3545         rather than a hand-rolled POD check when checking for forced MEMORY
3546         classification.
3547
3548 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3549
3550         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
3551         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
3552         function.
3553         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
3554         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
3555         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
3556         declaration.
3557
3558 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3559
3560         * aarch64-linux-nat.c
3561         (aarch64_linux_nat_target::thread_architecture): Add override.
3562         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
3563         each VQ.
3564
3565 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3566
3567         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
3568
3569 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
3570
3571         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
3572         target types of size 96-bits, add some additional comments, and
3573         check that the builtin type we found was the correct size.
3574
3575 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
3576
3577         * utils.c (prompt_for_continue): Don't restore the styling at the
3578         end, as applied_style has the wrong value.  This fixes styling in
3579         long lists of file names that are interrupted by the "Continue?"
3580         prompt.
3581
3582 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3583
3584         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
3585         * c-lang.c (c_language_defn): Likewise.
3586         (cplus_language_defn): Likewise.
3587         (asm_language_defn): Likewise.
3588         (minimal_language_defn): Likewise.
3589         * d-lang.c (d_language_defn): Likewise.
3590         * f-lang.c (f_language_defn): Likewise.
3591         * go-lang.c (go_language_defn): Likewise.
3592         * language.c (unknown_language_defn): Likewise.
3593         (auto_language_defn): Likewise.
3594         * language.h (struct language_defn): Remove la_magic field.
3595         (LANG_MAGIC): Delete.
3596         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
3597         * objc-lang.c (objc_language_defn): Likewise.
3598         * opencl-lang.c (opencl_language_defn): Likewise.
3599         * p-lang.c (pascal_language_defn): Likewise.
3600         * rust-lang.c (rust_language_defn): Likewise.
3601
3602 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3603
3604         * riscv-tdep.c (riscv_type_align): New function.
3605         (riscv_type_alignment): Delete.
3606         (riscv_arg_location): Use 'type_align'.
3607         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
3608
3609 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3610
3611         * gdbtypes.c (type_align): A struct with no non-static fields also
3612         has alignment of 1.
3613
3614 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3615
3616         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
3617         component to 0.
3618         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
3619         member.
3620         (riscv_struct_info::analyse): New implementation using new
3621         analyse_inner member function.
3622         (riscv_struct_info::field_offset): New member function.
3623         (riscv_struct_info::m_offsets): New member variable.
3624         (riscv_struct_info::analyse_inner): New private member function,
3625         takes the old implementation of riscv_struct_info::analyse but
3626         extended to track field offsets.
3627         (riscv_call_arg_struct): Update the struct folding special cases
3628         to handle cases where empty C++ structs, which are non-zero
3629         length, are found.
3630         (riscv_arg_location): Initialise the length of each location, a
3631         non-zero length now indicates the location is in use.
3632         (riscv_push_dummy_call): Allow for the first location having a
3633         non-zero offset when setting up arguments.
3634         (riscv_return_value): Likewise, but for return values.
3635
3636 2019-04-11  Tom Tromey  <tromey@adacore.com>
3637
3638         * utils.c (internal_vproblem): Make "msg" const.
3639
3640 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
3641
3642         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
3643         * trad-frame.c (trad_frame_reset_saved_regs): New function.
3644         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
3645         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
3646
3647 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
3648
3649         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
3650         function.
3651         (fill_gregset): Call amd64_linux_collect_native_gregset instead
3652         of amd64_collect_native_gregset.
3653         (amd64_linux_nat_target::store_registers): Likewise.
3654
3655 2019-04-10  Tom Tromey  <tom@tromey.com>
3656
3657         * symtab.c (lookup_global_symbol_from_objfile)
3658         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
3659         * objfiles.h (class separate_debug_iterator): New.
3660         (class separate_debug_range): New.
3661         (struct objfile) <separate_debug_objfiles>: New method.
3662         (objfile_separate_debug_iterate): Don't declare.
3663         * objfiles.c (separate_debug_iterator::operator++): Rename from
3664         objfile_separate_debug_iterate.
3665         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
3666         iterator.
3667         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
3668         iterator.
3669
3670 2019-04-10  Tom Tromey  <tom@tromey.com>
3671
3672         * symfile.c (reread_symbols): Remove old comment.
3673         * objfiles.c (free_all_objfiles): Fix a typo.
3674
3675 2019-04-10  Tom Tromey  <tom@tromey.com>
3676
3677         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
3678         * minsyms.c (lookup_minimal_symbol): Use foreach.
3679         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
3680         (lookup_minimal_symbol_solib_trampoline): Likewise.
3681         * symfile.c (reread_symbols): Use foreach.
3682
3683 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
3684             Tom Tromey  <tromey@adacore.com>
3685
3686         PR rust/24414:
3687         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
3688         (rust_lex_int_test): Change "value" to be LONGEST.
3689         (rust_lex_tests): Add test for long integer literal.
3690
3691 2019-04-09  Tom Tromey  <tromey@adacore.com>
3692
3693         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
3694         to bool.
3695         (extended_remote_target::attach): Update.
3696         (remote_target::remote_notice_new_inferior): Update.
3697         (remote_target::add_current_inferior_and_thread): Update.
3698         * inferior.c (exit_inferior_1): Use "false".
3699         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
3700
3701 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
3702
3703         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
3704         the "start" command.
3705
3706 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3707
3708         * python/py-inferior.c (infpy_thread_from_thread_handle):
3709         Adjust comments to reflect renaming of thread_from_thread_handle
3710         to thread_from_handle.  Adjust keywords.  Fix type error message.
3711         (inferior_object_methods): Add thread_from_handle.  Retain
3712         thread_from_thread_handle, but mark it as deprecated.
3713
3714 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3715
3716         * gdbthread.h (find_thread_by_handle): Revise declaration.
3717         * thread.c (find_thread_by_handle): Likewise.  Adjust
3718         implementation too.
3719         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
3720         support for buffer objects as handles.
3721
3722 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3723
3724         * python/py-infthread.c (thpy_thread_handle): New function.
3725         (thread_object_methods): Register thpy_thread_handle.
3726
3727 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3728
3729         * gdbthread.h (thread_to_thread_handle): Declare.
3730         * thread.c (gdbtypes.h): Include.
3731         (thread_to_thread_handle): New function.
3732
3733         * target.h (struct target_ops): Add thread_info_to_thread_handle.
3734         (target_thread_info_to_thread_handle): Declare.
3735         * target.c (target_thread_info_to_thread_handle): New function.
3736         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
3737         * target-delegates.c: Regenerate.
3738
3739         * linux-thread-db.c (class thread_db_target): Add method
3740         thread_info_to_thread_handle.
3741         (thread_db_target::thread_info_to_thread_handle): Define.
3742         * remote.c (class remote_target): Add new method
3743         thread_info_to_thread_handle.
3744         (remote_target::thread_info_to_thread_handle): Define.
3745
3746 2019-04-08  Pedro Alves  <palves@redhat.com>
3747
3748         * common/common-exceptions.c (throw_exception): Don't create
3749         named object to throw; throw directly.
3750         (throw_it): Likewise.  Don't initialize gdb_exception::message
3751         here, with new; pass FMT and AP to the ctor instead.
3752         * common/common-exceptions.h: Include <string>.
3753         (gdb_exception::gdb_exception(enum return_reason, enum errors,
3754         const char *, va_list)): New ctor.  Use std::make_shared.
3755         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
3756         errors)): Delete.
3757         (gdb_exception_error::gdb_exception_error(enum errors, const char
3758         *, va_list)): New.
3759         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
3760         Add assertion.
3761         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
3762         errors)): Delete.
3763         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
3764         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
3765         Add assertion.
3766
3767 2019-04-08  Tom Tromey  <tom@tromey.com>
3768
3769         * valops.c (value_rtti_indirect_type): Replace throw_exception
3770         with throw.
3771         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
3772         with throw.
3773         * thread.c (thr_try_catch_cmd): Replace throw_exception with
3774         throw.
3775         * target.c (target_translate_tls_address): Replace throw_exception
3776         with throw.
3777         * stack.c (frame_apply_command_count): Replace throw_exception
3778         with throw.
3779         * solib-spu.c (append_ocl_sos): Replace throw_exception with
3780         throw.
3781         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
3782         with throw.
3783         * rs6000-tdep.c (rs6000_frame_cache)
3784         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
3785         * remote.c: Replace throw_exception with throw.
3786         * record-full.c (record_full_message, record_full_wait_1)
3787         (record_full_restore): Replace throw_exception with throw.
3788         * record-btrace.c:
3789         (get_thread_current_frame_id, record_btrace_start_replaying)
3790         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
3791         (cmd_record_btrace_start): Replace throw_exception with throw.
3792         * parse.c (parse_exp_in_context_1): Replace throw_exception with
3793         throw.
3794         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
3795         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
3796         * linespec.c:
3797         (find_linespec_symbols): Replace throw_exception with throw.
3798         * infrun.c (displaced_step_prepare, resume): Replace
3799         throw_exception with throw.
3800         * infcmd.c (post_create_inferior): Replace throw_exception with
3801         throw.
3802         * inf-loop.c (inferior_event_handler): Replace throw_exception
3803         with throw.
3804         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
3805         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
3806         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
3807         (get_prev_frame_always, get_frame_pc_if_available)
3808         (get_frame_address_in_block_if_available, get_frame_language):
3809         Replace throw_exception with throw.
3810         * frame-unwind.c (frame_unwind_try_unwinder): Replace
3811         throw_exception with throw.
3812         * eval.c (fetch_subexp_value, evaluate_var_value)
3813         (evaluate_funcall, evaluate_subexp_standard): Replace
3814         throw_exception with throw.
3815         * dwarf2loc.c (call_site_find_chain)
3816         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
3817         Replace throw_exception with throw.
3818         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
3819         with throw.
3820         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
3821         throw.
3822         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
3823         * completer.c (complete_line_internal): Replace throw_exception
3824         with throw.
3825         * compile/compile-object-run.c (compile_object_run): Replace
3826         throw_exception with throw.
3827         * cli/cli-script.c (process_next_line): Replace throw_exception
3828         with throw.
3829         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
3830         (btrace_enable, btrace_maint_update_pt_packets): Replace
3831         throw_exception with throw.
3832         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
3833         throw_exception with throw.
3834         * break-catch-throw.c (re_set_exception_catchpoint): Replace
3835         throw_exception with throw.
3836         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
3837         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
3838         * aarch64-tdep.c (aarch64_make_prologue_cache)
3839         (aarch64_make_stub_cache): Replace throw_exception with throw.
3840
3841 2019-04-08  Tom Tromey  <tom@tromey.com>
3842
3843         * common/common-exceptions.c (throw_exception): Rename from
3844         throw_exception_cxx.  Remove old copy.  Make argument const.
3845         (throw_it): Create and throw exception objects directly.
3846         * common/common-exceptions.h (throw_exception): Make argument
3847         const.
3848         (struct gdb_exception_error): Add constructor.
3849         (struct gdb_exception_quit): Add constructor.
3850
3851 2019-04-08  Tom Tromey  <tom@tromey.com>
3852
3853         * common/common-exceptions.h (exception_rethrow): Don't declare.
3854         (TRY_SJLJ): Update comment.
3855         (TRY, CATCH, END_CATCH): Remove.
3856         * common/common-exceptions.c (exception_rethrow): Remove.
3857
3858 2019-04-08  Tom Tromey  <tom@tromey.com>
3859
3860         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
3861         Remove.
3862         (gdb_exception_error): Rename from
3863         gdb_exception_RETURN_MASK_ERROR.
3864         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
3865         (gdb_quit_bad_alloc): Update.
3866         * aarch64-tdep.c: Update.
3867         * ada-lang.c: Update.
3868         * ada-typeprint.c: Update.
3869         * ada-valprint.c: Update.
3870         * amd64-tdep.c: Update.
3871         * arch-utils.c: Update.
3872         * break-catch-throw.c: Update.
3873         * breakpoint.c: Update.
3874         * btrace.c: Update.
3875         * c-varobj.c: Update.
3876         * cli/cli-cmds.c: Update.
3877         * cli/cli-interp.c: Update.
3878         * cli/cli-script.c: Update.
3879         * common/common-exceptions.c: Update.
3880         * common/new-op.c: Update.
3881         * common/selftest.c: Update.
3882         * compile/compile-c-symbols.c: Update.
3883         * compile/compile-cplus-symbols.c: Update.
3884         * compile/compile-object-load.c: Update.
3885         * compile/compile-object-run.c: Update.
3886         * completer.c: Update.
3887         * corelow.c: Update.
3888         * cp-abi.c: Update.
3889         * cp-support.c: Update.
3890         * cp-valprint.c: Update.
3891         * darwin-nat.c: Update.
3892         * disasm-selftests.c: Update.
3893         * dtrace-probe.c: Update.
3894         * dwarf-index-cache.c: Update.
3895         * dwarf-index-write.c: Update.
3896         * dwarf2-frame-tailcall.c: Update.
3897         * dwarf2-frame.c: Update.
3898         * dwarf2loc.c: Update.
3899         * dwarf2read.c: Update.
3900         * eval.c: Update.
3901         * event-loop.c: Update.
3902         * event-top.c: Update.
3903         * exec.c: Update.
3904         * f-valprint.c: Update.
3905         * fbsd-tdep.c: Update.
3906         * frame-unwind.c: Update.
3907         * frame.c: Update.
3908         * gdbtypes.c: Update.
3909         * gnu-v3-abi.c: Update.
3910         * guile/guile-internal.h: Update.
3911         * guile/scm-block.c: Update.
3912         * guile/scm-breakpoint.c: Update.
3913         * guile/scm-cmd.c: Update.
3914         * guile/scm-disasm.c: Update.
3915         * guile/scm-frame.c: Update.
3916         * guile/scm-lazy-string.c: Update.
3917         * guile/scm-math.c: Update.
3918         * guile/scm-param.c: Update.
3919         * guile/scm-ports.c: Update.
3920         * guile/scm-pretty-print.c: Update.
3921         * guile/scm-symbol.c: Update.
3922         * guile/scm-symtab.c: Update.
3923         * guile/scm-type.c: Update.
3924         * guile/scm-value.c: Update.
3925         * i386-linux-tdep.c: Update.
3926         * i386-tdep.c: Update.
3927         * inf-loop.c: Update.
3928         * infcall.c: Update.
3929         * infcmd.c: Update.
3930         * infrun.c: Update.
3931         * jit.c: Update.
3932         * language.c: Update.
3933         * linespec.c: Update.
3934         * linux-fork.c: Update.
3935         * linux-nat.c: Update.
3936         * linux-tdep.c: Update.
3937         * linux-thread-db.c: Update.
3938         * main.c: Update.
3939         * mi/mi-cmd-break.c: Update.
3940         * mi/mi-cmd-stack.c: Update.
3941         * mi/mi-interp.c: Update.
3942         * mi/mi-main.c: Update.
3943         * objc-lang.c: Update.
3944         * p-valprint.c: Update.
3945         * parse.c: Update.
3946         * ppc-linux-tdep.c: Update.
3947         * printcmd.c: Update.
3948         * python/py-arch.c: Update.
3949         * python/py-breakpoint.c: Update.
3950         * python/py-cmd.c: Update.
3951         * python/py-finishbreakpoint.c: Update.
3952         * python/py-frame.c: Update.
3953         * python/py-framefilter.c: Update.
3954         * python/py-gdb-readline.c: Update.
3955         * python/py-inferior.c: Update.
3956         * python/py-infthread.c: Update.
3957         * python/py-lazy-string.c: Update.
3958         * python/py-linetable.c: Update.
3959         * python/py-objfile.c: Update.
3960         * python/py-param.c: Update.
3961         * python/py-prettyprint.c: Update.
3962         * python/py-progspace.c: Update.
3963         * python/py-record-btrace.c: Update.
3964         * python/py-record.c: Update.
3965         * python/py-symbol.c: Update.
3966         * python/py-type.c: Update.
3967         * python/py-unwind.c: Update.
3968         * python/py-utils.c: Update.
3969         * python/py-value.c: Update.
3970         * python/python.c: Update.
3971         * record-btrace.c: Update.
3972         * record-full.c: Update.
3973         * remote-fileio.c: Update.
3974         * remote.c: Update.
3975         * riscv-tdep.c: Update.
3976         * rs6000-aix-tdep.c: Update.
3977         * rs6000-tdep.c: Update.
3978         * rust-exp.y: Update.
3979         * rust-lang.c: Update.
3980         * s390-tdep.c: Update.
3981         * selftest-arch.c: Update.
3982         * solib-dsbt.c: Update.
3983         * solib-frv.c: Update.
3984         * solib-spu.c: Update.
3985         * solib-svr4.c: Update.
3986         * solib.c: Update.
3987         * sparc64-linux-tdep.c: Update.
3988         * stack.c: Update.
3989         * symfile-mem.c: Update.
3990         * symmisc.c: Update.
3991         * target.c: Update.
3992         * thread.c: Update.
3993         * top.c: Update.
3994         * tracefile-tfile.c: Update.
3995         * tui/tui.c: Update.
3996         * typeprint.c: Update.
3997         * unittests/cli-utils-selftests.c: Update.
3998         * unittests/parse-connection-spec-selftests.c: Update.
3999         * valops.c: Update.
4000         * valprint.c: Update.
4001         * value.c: Update.
4002         * varobj.c: Update.
4003         * windows-nat.c: Update.
4004         * x86-linux-nat.c: Update.
4005         * xml-support.c: Update.
4006
4007 2019-04-08  Tom Tromey  <tom@tromey.com>
4008
4009         * xml-support.c: Use C++ exception handling.
4010         * x86-linux-nat.c: Use C++ exception handling.
4011         * windows-nat.c: Use C++ exception handling.
4012         * varobj.c: Use C++ exception handling.
4013         * value.c: Use C++ exception handling.
4014         * valprint.c: Use C++ exception handling.
4015         * valops.c: Use C++ exception handling.
4016         * unittests/parse-connection-spec-selftests.c: Use C++ exception
4017         handling.
4018         * unittests/cli-utils-selftests.c: Use C++ exception handling.
4019         * typeprint.c: Use C++ exception handling.
4020         * tui/tui.c: Use C++ exception handling.
4021         * tracefile-tfile.c: Use C++ exception handling.
4022         * top.c: Use C++ exception handling.
4023         * thread.c: Use C++ exception handling.
4024         * target.c: Use C++ exception handling.
4025         * symmisc.c: Use C++ exception handling.
4026         * symfile-mem.c: Use C++ exception handling.
4027         * stack.c: Use C++ exception handling.
4028         * sparc64-linux-tdep.c: Use C++ exception handling.
4029         * solib.c: Use C++ exception handling.
4030         * solib-svr4.c: Use C++ exception handling.
4031         * solib-spu.c: Use C++ exception handling.
4032         * solib-frv.c: Use C++ exception handling.
4033         * solib-dsbt.c: Use C++ exception handling.
4034         * selftest-arch.c: Use C++ exception handling.
4035         * s390-tdep.c: Use C++ exception handling.
4036         * rust-lang.c: Use C++ exception handling.
4037         * rust-exp.y: Use C++ exception handling.
4038         * rs6000-tdep.c: Use C++ exception handling.
4039         * rs6000-aix-tdep.c: Use C++ exception handling.
4040         * riscv-tdep.c: Use C++ exception handling.
4041         * remote.c: Use C++ exception handling.
4042         * remote-fileio.c: Use C++ exception handling.
4043         * record-full.c: Use C++ exception handling.
4044         * record-btrace.c: Use C++ exception handling.
4045         * python/python.c: Use C++ exception handling.
4046         * python/py-value.c: Use C++ exception handling.
4047         * python/py-utils.c: Use C++ exception handling.
4048         * python/py-unwind.c: Use C++ exception handling.
4049         * python/py-type.c: Use C++ exception handling.
4050         * python/py-symbol.c: Use C++ exception handling.
4051         * python/py-record.c: Use C++ exception handling.
4052         * python/py-record-btrace.c: Use C++ exception handling.
4053         * python/py-progspace.c: Use C++ exception handling.
4054         * python/py-prettyprint.c: Use C++ exception handling.
4055         * python/py-param.c: Use C++ exception handling.
4056         * python/py-objfile.c: Use C++ exception handling.
4057         * python/py-linetable.c: Use C++ exception handling.
4058         * python/py-lazy-string.c: Use C++ exception handling.
4059         * python/py-infthread.c: Use C++ exception handling.
4060         * python/py-inferior.c: Use C++ exception handling.
4061         * python/py-gdb-readline.c: Use C++ exception handling.
4062         * python/py-framefilter.c: Use C++ exception handling.
4063         * python/py-frame.c: Use C++ exception handling.
4064         * python/py-finishbreakpoint.c: Use C++ exception handling.
4065         * python/py-cmd.c: Use C++ exception handling.
4066         * python/py-breakpoint.c: Use C++ exception handling.
4067         * python/py-arch.c: Use C++ exception handling.
4068         * printcmd.c: Use C++ exception handling.
4069         * ppc-linux-tdep.c: Use C++ exception handling.
4070         * parse.c: Use C++ exception handling.
4071         * p-valprint.c: Use C++ exception handling.
4072         * objc-lang.c: Use C++ exception handling.
4073         * mi/mi-main.c: Use C++ exception handling.
4074         * mi/mi-interp.c: Use C++ exception handling.
4075         * mi/mi-cmd-stack.c: Use C++ exception handling.
4076         * mi/mi-cmd-break.c: Use C++ exception handling.
4077         * main.c: Use C++ exception handling.
4078         * linux-thread-db.c: Use C++ exception handling.
4079         * linux-tdep.c: Use C++ exception handling.
4080         * linux-nat.c: Use C++ exception handling.
4081         * linux-fork.c: Use C++ exception handling.
4082         * linespec.c: Use C++ exception handling.
4083         * language.c: Use C++ exception handling.
4084         * jit.c: Use C++ exception handling.
4085         * infrun.c: Use C++ exception handling.
4086         * infcmd.c: Use C++ exception handling.
4087         * infcall.c: Use C++ exception handling.
4088         * inf-loop.c: Use C++ exception handling.
4089         * i386-tdep.c: Use C++ exception handling.
4090         * i386-linux-tdep.c: Use C++ exception handling.
4091         * guile/scm-value.c: Use C++ exception handling.
4092         * guile/scm-type.c: Use C++ exception handling.
4093         * guile/scm-symtab.c: Use C++ exception handling.
4094         * guile/scm-symbol.c: Use C++ exception handling.
4095         * guile/scm-pretty-print.c: Use C++ exception handling.
4096         * guile/scm-ports.c: Use C++ exception handling.
4097         * guile/scm-param.c: Use C++ exception handling.
4098         * guile/scm-math.c: Use C++ exception handling.
4099         * guile/scm-lazy-string.c: Use C++ exception handling.
4100         * guile/scm-frame.c: Use C++ exception handling.
4101         * guile/scm-disasm.c: Use C++ exception handling.
4102         * guile/scm-cmd.c: Use C++ exception handling.
4103         * guile/scm-breakpoint.c: Use C++ exception handling.
4104         * guile/scm-block.c: Use C++ exception handling.
4105         * guile/guile-internal.h: Use C++ exception handling.
4106         * gnu-v3-abi.c: Use C++ exception handling.
4107         * gdbtypes.c: Use C++ exception handling.
4108         * frame.c: Use C++ exception handling.
4109         * frame-unwind.c: Use C++ exception handling.
4110         * fbsd-tdep.c: Use C++ exception handling.
4111         * f-valprint.c: Use C++ exception handling.
4112         * exec.c: Use C++ exception handling.
4113         * event-top.c: Use C++ exception handling.
4114         * event-loop.c: Use C++ exception handling.
4115         * eval.c: Use C++ exception handling.
4116         * dwarf2read.c: Use C++ exception handling.
4117         * dwarf2loc.c: Use C++ exception handling.
4118         * dwarf2-frame.c: Use C++ exception handling.
4119         * dwarf2-frame-tailcall.c: Use C++ exception handling.
4120         * dwarf-index-write.c: Use C++ exception handling.
4121         * dwarf-index-cache.c: Use C++ exception handling.
4122         * dtrace-probe.c: Use C++ exception handling.
4123         * disasm-selftests.c: Use C++ exception handling.
4124         * darwin-nat.c: Use C++ exception handling.
4125         * cp-valprint.c: Use C++ exception handling.
4126         * cp-support.c: Use C++ exception handling.
4127         * cp-abi.c: Use C++ exception handling.
4128         * corelow.c: Use C++ exception handling.
4129         * completer.c: Use C++ exception handling.
4130         * compile/compile-object-run.c: Use C++ exception handling.
4131         * compile/compile-object-load.c: Use C++ exception handling.
4132         * compile/compile-cplus-symbols.c: Use C++ exception handling.
4133         * compile/compile-c-symbols.c: Use C++ exception handling.
4134         * common/selftest.c: Use C++ exception handling.
4135         * common/new-op.c: Use C++ exception handling.
4136         * cli/cli-script.c: Use C++ exception handling.
4137         * cli/cli-interp.c: Use C++ exception handling.
4138         * cli/cli-cmds.c: Use C++ exception handling.
4139         * c-varobj.c: Use C++ exception handling.
4140         * btrace.c: Use C++ exception handling.
4141         * breakpoint.c: Use C++ exception handling.
4142         * break-catch-throw.c: Use C++ exception handling.
4143         * arch-utils.c: Use C++ exception handling.
4144         * amd64-tdep.c: Use C++ exception handling.
4145         * ada-valprint.c: Use C++ exception handling.
4146         * ada-typeprint.c: Use C++ exception handling.
4147         * ada-lang.c: Use C++ exception handling.
4148         * aarch64-tdep.c: Use C++ exception handling.
4149
4150 2019-04-08  Tom Tromey  <tom@tromey.com>
4151
4152         * xml-support.c (gdb_xml_parser::parse): Update.
4153         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4154         * value.c (show_convenience): Update.
4155         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4156         (test_parse_flags_qcs): Update.
4157         * thread.c (thr_try_catch_cmd): Update.
4158         * target.c (target_translate_tls_address): Update.
4159         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4160         (info_frame_command_core, frame_apply_command_count): Update.
4161         * rust-exp.y (rust_lex_exception_test): Update.
4162         * riscv-tdep.c (riscv_print_one_register_info): Update.
4163         * remote.c (remote_target::enable_btrace): Update.
4164         * record-btrace.c (record_btrace_enable_warn): Update.
4165         * python/py-utils.c (gdbpy_convert_exception): Update.
4166         * printcmd.c (do_one_display, print_variable_and_value): Update.
4167         * mi/mi-main.c (mi_print_exception): Update.
4168         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4169         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4170         * linux-nat.c (linux_nat_target::attach): Update.
4171         * linux-fork.c (class scoped_switch_fork_info): Update.
4172         * infrun.c (displaced_step_prepare): Update.
4173         * infcall.c (call_function_by_hand_dummy): Update.
4174         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4175         * gnu-v3-abi.c (print_one_vtable): Update.
4176         * frame.c (get_prev_frame_always): Update.
4177         * f-valprint.c (info_common_command_for_block): Update.
4178         * exec.c (try_open_exec_file): Update.
4179         * exceptions.c (print_exception, exception_print)
4180         (exception_fprintf, exception_print_same): Update.
4181         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4182         * dwarf-index-cache.c (index_cache::store)
4183         (index_cache::lookup_gdb_index): Update.
4184         * darwin-nat.c (maybe_cache_shell): Update.
4185         * cp-valprint.c (cp_print_value_fields): Update.
4186         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4187         (gcc_cplus_symbol_address): Update.
4188         * compile/compile-c-symbols.c (gcc_convert_symbol)
4189         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
4190         * common/selftest.c: Update.
4191         * common/common-exceptions.h (struct gdb_exception) <message>: Now
4192         a std::string.
4193         (exception_try_scope_entry, exception_try_scope_exit): Don't
4194         declare.
4195         (struct exception_try_scope): Remove.
4196         (TRY): Don't use exception_try_scope.
4197         (struct gdb_exception): Add constructor, operator=.
4198         <what>: New method.
4199         (struct gdb_exception_RETURN_MASK_ALL)
4200         (struct gdb_exception_RETURN_MASK_ERROR)
4201         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
4202         (struct gdb_quit_bad_alloc): Update.
4203         * common/common-exceptions.c (exception_none): Change
4204         initializer.
4205         (struct catcher) <state, exception>: Initialize inline.
4206         <prev>: Remove member.
4207         (current_catcher): Remove.
4208         (catchers): New global.
4209         (exceptions_state_mc_init): Simplify.
4210         (catcher_pop): Remove.
4211         (exceptions_state_mc, exceptions_state_mc_catch): Update.
4212         (try_scope_depth, exception_try_scope_entry)
4213         (exception_try_scope_exit): Remove.
4214         (throw_exception_sjlj): Update.
4215         (exception_messages, exception_messages_size): Remove.
4216         (throw_it): Simplify.
4217         (gdb_exception_sliced_copy): Remove.
4218         (throw_exception_cxx): Update.
4219         * cli/cli-script.c (script_from_file): Update.
4220         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
4221         Update.
4222         * ada-valprint.c (ada_val_print): Update.
4223         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
4224         (create_excep_cond_exprs): Update.
4225
4226 2019-04-08  Tom Tromey  <tom@tromey.com>
4227
4228         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
4229         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
4230         (TRY, CATCH, END_CATCH): Remove some definitions.
4231         * common/common-exceptions.c: Don't use GDB_XCPT.
4232         (catcher_list_size): Remove.
4233         (throw_exception, throw_it): Simplify.
4234
4235 2019-04-05  Tom Tromey  <tom@tromey.com>
4236
4237         Revert the header-sorting patch.
4238         * ft32-tdep.c: Revert.
4239         * frv-tdep.c: Revert.
4240         * frv-linux-tdep.c: Revert.
4241         * frame.c: Revert.
4242         * frame-unwind.c: Revert.
4243         * frame-base.c: Revert.
4244         * fork-child.c: Revert.
4245         * findvar.c: Revert.
4246         * findcmd.c: Revert.
4247         * filesystem.c: Revert.
4248         * filename-seen-cache.h: Revert.
4249         * filename-seen-cache.c: Revert.
4250         * fbsd-tdep.c: Revert.
4251         * fbsd-nat.h: Revert.
4252         * fbsd-nat.c: Revert.
4253         * f-valprint.c: Revert.
4254         * f-typeprint.c: Revert.
4255         * f-lang.c: Revert.
4256         * extension.h: Revert.
4257         * extension.c: Revert.
4258         * extension-priv.h: Revert.
4259         * expprint.c: Revert.
4260         * exec.h: Revert.
4261         * exec.c: Revert.
4262         * exceptions.c: Revert.
4263         * event-top.c: Revert.
4264         * event-loop.c: Revert.
4265         * eval.c: Revert.
4266         * elfread.c: Revert.
4267         * dwarf2read.h: Revert.
4268         * dwarf2read.c: Revert.
4269         * dwarf2loc.c: Revert.
4270         * dwarf2expr.h: Revert.
4271         * dwarf2expr.c: Revert.
4272         * dwarf2-frame.c: Revert.
4273         * dwarf2-frame-tailcall.c: Revert.
4274         * dwarf-index-write.h: Revert.
4275         * dwarf-index-write.c: Revert.
4276         * dwarf-index-common.c: Revert.
4277         * dwarf-index-cache.h: Revert.
4278         * dwarf-index-cache.c: Revert.
4279         * dummy-frame.c: Revert.
4280         * dtrace-probe.c: Revert.
4281         * disasm.h: Revert.
4282         * disasm.c: Revert.
4283         * disasm-selftests.c: Revert.
4284         * dictionary.c: Revert.
4285         * dicos-tdep.c: Revert.
4286         * demangle.c: Revert.
4287         * dcache.h: Revert.
4288         * dcache.c: Revert.
4289         * darwin-nat.h: Revert.
4290         * darwin-nat.c: Revert.
4291         * darwin-nat-info.c: Revert.
4292         * d-valprint.c: Revert.
4293         * d-namespace.c: Revert.
4294         * d-lang.c: Revert.
4295         * ctf.c: Revert.
4296         * csky-tdep.c: Revert.
4297         * csky-linux-tdep.c: Revert.
4298         * cris-tdep.c: Revert.
4299         * cris-linux-tdep.c: Revert.
4300         * cp-valprint.c: Revert.
4301         * cp-support.c: Revert.
4302         * cp-namespace.c: Revert.
4303         * cp-abi.c: Revert.
4304         * corelow.c: Revert.
4305         * corefile.c: Revert.
4306         * continuations.c: Revert.
4307         * completer.h: Revert.
4308         * completer.c: Revert.
4309         * complaints.c: Revert.
4310         * coffread.c: Revert.
4311         * coff-pe-read.c: Revert.
4312         * cli-out.h: Revert.
4313         * cli-out.c: Revert.
4314         * charset.c: Revert.
4315         * c-varobj.c: Revert.
4316         * c-valprint.c: Revert.
4317         * c-typeprint.c: Revert.
4318         * c-lang.c: Revert.
4319         * buildsym.c: Revert.
4320         * buildsym-legacy.c: Revert.
4321         * build-id.h: Revert.
4322         * build-id.c: Revert.
4323         * btrace.c: Revert.
4324         * bsd-uthread.c: Revert.
4325         * breakpoint.h: Revert.
4326         * breakpoint.c: Revert.
4327         * break-catch-throw.c: Revert.
4328         * break-catch-syscall.c: Revert.
4329         * break-catch-sig.c: Revert.
4330         * blockframe.c: Revert.
4331         * block.c: Revert.
4332         * bfin-tdep.c: Revert.
4333         * bfin-linux-tdep.c: Revert.
4334         * bfd-target.c: Revert.
4335         * bcache.c: Revert.
4336         * ax-general.c: Revert.
4337         * ax-gdb.h: Revert.
4338         * ax-gdb.c: Revert.
4339         * avr-tdep.c: Revert.
4340         * auxv.c: Revert.
4341         * auto-load.c: Revert.
4342         * arm-wince-tdep.c: Revert.
4343         * arm-tdep.c: Revert.
4344         * arm-symbian-tdep.c: Revert.
4345         * arm-pikeos-tdep.c: Revert.
4346         * arm-obsd-tdep.c: Revert.
4347         * arm-nbsd-tdep.c: Revert.
4348         * arm-nbsd-nat.c: Revert.
4349         * arm-linux-tdep.c: Revert.
4350         * arm-linux-nat.c: Revert.
4351         * arm-fbsd-tdep.c: Revert.
4352         * arm-fbsd-nat.c: Revert.
4353         * arm-bsd-tdep.c: Revert.
4354         * arch-utils.c: Revert.
4355         * arc-tdep.c: Revert.
4356         * arc-newlib-tdep.c: Revert.
4357         * annotate.h: Revert.
4358         * annotate.c: Revert.
4359         * amd64-windows-tdep.c: Revert.
4360         * amd64-windows-nat.c: Revert.
4361         * amd64-tdep.c: Revert.
4362         * amd64-sol2-tdep.c: Revert.
4363         * amd64-obsd-tdep.c: Revert.
4364         * amd64-obsd-nat.c: Revert.
4365         * amd64-nbsd-tdep.c: Revert.
4366         * amd64-nbsd-nat.c: Revert.
4367         * amd64-nat.c: Revert.
4368         * amd64-linux-tdep.c: Revert.
4369         * amd64-linux-nat.c: Revert.
4370         * amd64-fbsd-tdep.c: Revert.
4371         * amd64-fbsd-nat.c: Revert.
4372         * amd64-dicos-tdep.c: Revert.
4373         * amd64-darwin-tdep.c: Revert.
4374         * amd64-bsd-nat.c: Revert.
4375         * alpha-tdep.c: Revert.
4376         * alpha-obsd-tdep.c: Revert.
4377         * alpha-nbsd-tdep.c: Revert.
4378         * alpha-mdebug-tdep.c: Revert.
4379         * alpha-linux-tdep.c: Revert.
4380         * alpha-linux-nat.c: Revert.
4381         * alpha-bsd-tdep.c: Revert.
4382         * alpha-bsd-nat.c: Revert.
4383         * aix-thread.c: Revert.
4384         * agent.c: Revert.
4385         * addrmap.c: Revert.
4386         * ada-varobj.c: Revert.
4387         * ada-valprint.c: Revert.
4388         * ada-typeprint.c: Revert.
4389         * ada-tasks.c: Revert.
4390         * ada-lang.c: Revert.
4391         * aarch64-tdep.c: Revert.
4392         * aarch64-ravenscar-thread.c: Revert.
4393         * aarch64-newlib-tdep.c: Revert.
4394         * aarch64-linux-tdep.c: Revert.
4395         * aarch64-linux-nat.c: Revert.
4396         * aarch64-fbsd-tdep.c: Revert.
4397         * aarch64-fbsd-nat.c: Revert.
4398         * aarch32-linux-nat.c: Revert.
4399
4400 2019-04-05  Tom Tromey  <tom@tromey.com>
4401
4402         * ft32-tdep.c: Sort headers.
4403         * frv-tdep.c: Sort headers.
4404         * frv-linux-tdep.c: Sort headers.
4405         * frame.c: Sort headers.
4406         * frame-unwind.c: Sort headers.
4407         * frame-base.c: Sort headers.
4408         * fork-child.c: Sort headers.
4409         * findvar.c: Sort headers.
4410         * findcmd.c: Sort headers.
4411         * filesystem.c: Sort headers.
4412         * filename-seen-cache.h: Sort headers.
4413         * filename-seen-cache.c: Sort headers.
4414         * fbsd-tdep.c: Sort headers.
4415         * fbsd-nat.h: Sort headers.
4416         * fbsd-nat.c: Sort headers.
4417         * f-valprint.c: Sort headers.
4418         * f-typeprint.c: Sort headers.
4419         * f-lang.c: Sort headers.
4420         * extension.h: Sort headers.
4421         * extension.c: Sort headers.
4422         * extension-priv.h: Sort headers.
4423         * expprint.c: Sort headers.
4424         * exec.h: Sort headers.
4425         * exec.c: Sort headers.
4426         * exceptions.c: Sort headers.
4427         * event-top.c: Sort headers.
4428         * event-loop.c: Sort headers.
4429         * eval.c: Sort headers.
4430         * elfread.c: Sort headers.
4431         * dwarf2read.h: Sort headers.
4432         * dwarf2read.c: Sort headers.
4433         * dwarf2loc.c: Sort headers.
4434         * dwarf2expr.h: Sort headers.
4435         * dwarf2expr.c: Sort headers.
4436         * dwarf2-frame.c: Sort headers.
4437         * dwarf2-frame-tailcall.c: Sort headers.
4438         * dwarf-index-write.h: Sort headers.
4439         * dwarf-index-write.c: Sort headers.
4440         * dwarf-index-common.c: Sort headers.
4441         * dwarf-index-cache.h: Sort headers.
4442         * dwarf-index-cache.c: Sort headers.
4443         * dummy-frame.c: Sort headers.
4444         * dtrace-probe.c: Sort headers.
4445         * disasm.h: Sort headers.
4446         * disasm.c: Sort headers.
4447         * disasm-selftests.c: Sort headers.
4448         * dictionary.c: Sort headers.
4449         * dicos-tdep.c: Sort headers.
4450         * demangle.c: Sort headers.
4451         * dcache.h: Sort headers.
4452         * dcache.c: Sort headers.
4453         * darwin-nat.h: Sort headers.
4454         * darwin-nat.c: Sort headers.
4455         * darwin-nat-info.c: Sort headers.
4456         * d-valprint.c: Sort headers.
4457         * d-namespace.c: Sort headers.
4458         * d-lang.c: Sort headers.
4459         * ctf.c: Sort headers.
4460         * csky-tdep.c: Sort headers.
4461         * csky-linux-tdep.c: Sort headers.
4462         * cris-tdep.c: Sort headers.
4463         * cris-linux-tdep.c: Sort headers.
4464         * cp-valprint.c: Sort headers.
4465         * cp-support.c: Sort headers.
4466         * cp-namespace.c: Sort headers.
4467         * cp-abi.c: Sort headers.
4468         * corelow.c: Sort headers.
4469         * corefile.c: Sort headers.
4470         * continuations.c: Sort headers.
4471         * completer.h: Sort headers.
4472         * completer.c: Sort headers.
4473         * complaints.c: Sort headers.
4474         * coffread.c: Sort headers.
4475         * coff-pe-read.c: Sort headers.
4476         * cli-out.h: Sort headers.
4477         * cli-out.c: Sort headers.
4478         * charset.c: Sort headers.
4479         * c-varobj.c: Sort headers.
4480         * c-valprint.c: Sort headers.
4481         * c-typeprint.c: Sort headers.
4482         * c-lang.c: Sort headers.
4483         * buildsym.c: Sort headers.
4484         * buildsym-legacy.c: Sort headers.
4485         * build-id.h: Sort headers.
4486         * build-id.c: Sort headers.
4487         * btrace.c: Sort headers.
4488         * bsd-uthread.c: Sort headers.
4489         * breakpoint.h: Sort headers.
4490         * breakpoint.c: Sort headers.
4491         * break-catch-throw.c: Sort headers.
4492         * break-catch-syscall.c: Sort headers.
4493         * break-catch-sig.c: Sort headers.
4494         * blockframe.c: Sort headers.
4495         * block.c: Sort headers.
4496         * bfin-tdep.c: Sort headers.
4497         * bfin-linux-tdep.c: Sort headers.
4498         * bfd-target.c: Sort headers.
4499         * bcache.c: Sort headers.
4500         * ax-general.c: Sort headers.
4501         * ax-gdb.h: Sort headers.
4502         * ax-gdb.c: Sort headers.
4503         * avr-tdep.c: Sort headers.
4504         * auxv.c: Sort headers.
4505         * auto-load.c: Sort headers.
4506         * arm-wince-tdep.c: Sort headers.
4507         * arm-tdep.c: Sort headers.
4508         * arm-symbian-tdep.c: Sort headers.
4509         * arm-pikeos-tdep.c: Sort headers.
4510         * arm-obsd-tdep.c: Sort headers.
4511         * arm-nbsd-tdep.c: Sort headers.
4512         * arm-nbsd-nat.c: Sort headers.
4513         * arm-linux-tdep.c: Sort headers.
4514         * arm-linux-nat.c: Sort headers.
4515         * arm-fbsd-tdep.c: Sort headers.
4516         * arm-fbsd-nat.c: Sort headers.
4517         * arm-bsd-tdep.c: Sort headers.
4518         * arch-utils.c: Sort headers.
4519         * arc-tdep.c: Sort headers.
4520         * arc-newlib-tdep.c: Sort headers.
4521         * annotate.h: Sort headers.
4522         * annotate.c: Sort headers.
4523         * amd64-windows-tdep.c: Sort headers.
4524         * amd64-windows-nat.c: Sort headers.
4525         * amd64-tdep.c: Sort headers.
4526         * amd64-sol2-tdep.c: Sort headers.
4527         * amd64-obsd-tdep.c: Sort headers.
4528         * amd64-obsd-nat.c: Sort headers.
4529         * amd64-nbsd-tdep.c: Sort headers.
4530         * amd64-nbsd-nat.c: Sort headers.
4531         * amd64-nat.c: Sort headers.
4532         * amd64-linux-tdep.c: Sort headers.
4533         * amd64-linux-nat.c: Sort headers.
4534         * amd64-fbsd-tdep.c: Sort headers.
4535         * amd64-fbsd-nat.c: Sort headers.
4536         * amd64-dicos-tdep.c: Sort headers.
4537         * amd64-darwin-tdep.c: Sort headers.
4538         * amd64-bsd-nat.c: Sort headers.
4539         * alpha-tdep.c: Sort headers.
4540         * alpha-obsd-tdep.c: Sort headers.
4541         * alpha-nbsd-tdep.c: Sort headers.
4542         * alpha-mdebug-tdep.c: Sort headers.
4543         * alpha-linux-tdep.c: Sort headers.
4544         * alpha-linux-nat.c: Sort headers.
4545         * alpha-bsd-tdep.c: Sort headers.
4546         * alpha-bsd-nat.c: Sort headers.
4547         * aix-thread.c: Sort headers.
4548         * agent.c: Sort headers.
4549         * addrmap.c: Sort headers.
4550         * ada-varobj.c: Sort headers.
4551         * ada-valprint.c: Sort headers.
4552         * ada-typeprint.c: Sort headers.
4553         * ada-tasks.c: Sort headers.
4554         * ada-lang.c: Sort headers.
4555         * aarch64-tdep.c: Sort headers.
4556         * aarch64-ravenscar-thread.c: Sort headers.
4557         * aarch64-newlib-tdep.c: Sort headers.
4558         * aarch64-linux-tdep.c: Sort headers.
4559         * aarch64-linux-nat.c: Sort headers.
4560         * aarch64-fbsd-tdep.c: Sort headers.
4561         * aarch64-fbsd-nat.c: Sort headers.
4562         * aarch32-linux-nat.c: Sort headers.
4563
4564 2019-04-04  Tom Tromey  <tom@tromey.com>
4565
4566         * varobj.c (varobj_create): Update.
4567         * rust-exp.y (struct rust_parser) <update_innermost_block,
4568         lookup_symbol>: New methods.
4569         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
4570         Rename.
4571         (rust_parser::rust_lookup_type)
4572         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4573         * printcmd.c (display_command, do_one_display): Update.
4574         * parser-defs.h (struct parser_state) <parser_state>: Add
4575         "tracker" parameter.
4576         (block_tracker): New member.
4577         (class innermost_block_tracker) <innermost_block_tracker>: Add
4578         "types" parameter.
4579         <reset>: Remove method.
4580         (innermost_block): Don't declare.
4581         (null_post_parser): Update.
4582         * parse.c (innermost_block): Remove global.
4583         (write_dollar_variable): Update.
4584         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
4585         Remove "tracker_types" parameter.
4586         (parse_expression): Add "tracker" parameter.
4587         (parse_expression_for_completion): Update.
4588         (null_post_parser): Add "tracker" parameter.
4589         * p-exp.y: Update rules.
4590         * m2-exp.y: Update rules.
4591         * language.h (struct language_defn) <la_post_parser>: Add
4592         "tracker" parameter.
4593         * go-exp.y: Update rules.
4594         * f-exp.y: Update rules.
4595         * expression.h (parse_expression, parse_exp_1): Add "tracker"
4596         parameter.
4597         * d-exp.y: Update rules.
4598         * c-exp.y: Update rules.
4599         * breakpoint.c (set_breakpoint_condition): Create an
4600         innermost_block_tracker.
4601         (watch_command_1): Likewise.
4602         * ada-lang.c (resolve): Add "tracker" parameter.
4603         (resolve_subexp): Likewise.
4604         * ada-exp.y (write_var_from_sym): Update.
4605
4606 2019-04-04  Tom Tromey  <tom@tromey.com>
4607
4608         * type-stack.h: New file.
4609         * type-stack.c: New file.
4610         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
4611         type-stack.h.
4612         (insert_into_type_stack, insert_type, push_type, push_type_int)
4613         (insert_type_address_space, pop_type, pop_type_int)
4614         (pop_typelist, pop_type_stack, append_type_stack)
4615         (push_type_stack, get_type_stack, push_typelist)
4616         (follow_type_instance_flags, follow_types): Don't declare.
4617         * parse.c (type_stack): Remove global.
4618         (parse_exp_in_context): Update.
4619         (insert_into_type_stack, insert_type, push_type, push_type_int)
4620         (insert_type_address_space, pop_type, pop_type_int)
4621         (pop_typelist, pop_type_stack, append_type_stack)
4622         (push_type_stack, get_type_stack, push_typelist)
4623         (follow_type_instance_flags, follow_types): Remove (moved to
4624         type-stack.c).
4625         * f-exp.y (type_stack): New global.
4626         Update rules.
4627         (push_kind_type, f_parse): Update.
4628         * d-exp.y (type_stack): New global.
4629         Update rules.
4630         (d_parse): Update.
4631         * c-exp.y (struct c_parse_state) <type_stack>: New member.
4632         Update rules.
4633         * Makefile.in (COMMON_SFILES): Add type-stack.c.
4634         (HFILES_NO_SRCDIR): Add type-stack.h.
4635
4636 2019-04-04  Tom Tromey  <tom@tromey.com>
4637
4638         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
4639         (rust_parser::convert_ast_to_expression, rust_parse)
4640         (rust_lex_test_completion, rust_lex_tests): Update.
4641         * parser-defs.h (struct expr_completion_state): New.
4642         (struct parser_state) <parser_state>: Add completion parameter.
4643         <mark_struct_expression, mark_completion_tag>: New methods.
4644         <parse_completion, m_completion_state>: New members.
4645         (prefixify_expression, null_post_parser): Update.
4646         (mark_struct_expression, mark_completion_tag): Don't declare.
4647         * parse.c (parse_completion, expout_last_struct)
4648         (expout_tag_completion_type, expout_completion_name): Remove
4649         globals.
4650         (parser_state::mark_struct_expression)
4651         (parser_state::mark_completion_tag): Now methods.
4652         (prefixify_expression): Add last_struct parameter.
4653         (prefixify_subexp): Likewise.
4654         (parse_exp_1): Update.
4655         (parse_exp_in_context): Add cstate parameter.  Update.
4656         (parse_expression_for_completion): Create an
4657         expr_completion_state.
4658         (null_post_parser): Add "completion" parameter.
4659         * p-exp.y: Update rules.
4660         (yylex): Update.
4661         * language.h (struct language_defn) <la_post_parser>: Add
4662         "completing" parameter.
4663         * go-exp.y: Update rules.
4664         (lex_one_token): Update.
4665         * expression.h (parse_completion): Don't declare.
4666         * d-exp.y: Update rules.
4667         (lex_one_token): Update rules.
4668         * c-exp.y: Update rules.
4669         (lex_one_token): Update.
4670         * ada-lang.c (resolve): Add "parse_completion" parameter.
4671         (resolve_subexp): Likewise.
4672         (ada_resolve_function): Likewise.
4673
4674 2019-04-04  Tom Tromey  <tom@tromey.com>
4675
4676         * parser-defs.h (struct parser_state) <start_arglist,
4677         end_arglist>: New methods.
4678         <arglist_len, m_funcall_chain>: New members.
4679         (arglist_len, start_arglist, end_arglist): Don't declare.
4680         * parse.c (arglist_len, funcall_chain): Remove global.
4681         (start_arglist, end_arglist): Remove functions.
4682         (parse_exp_in_context): Update.
4683         * p-exp.y: Update rules.
4684         * m2-exp.y: Update rules.
4685         * go-exp.y: Update rules.
4686         * f-exp.y: Update rules.
4687         * d-exp.y: Update rules.
4688         * c-exp.y: Update rules.
4689
4690 2019-04-04  Tom Tromey  <tom@tromey.com>
4691
4692         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
4693         lex_operator, push_back>: New methods.
4694         Update all rules.
4695         (rust_parser::lex_hex, lex_escape): Rename and update.
4696         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
4697         (rust_parser::lex_operator): Rename and update.
4698         (rust_parser::lex_number, rustyylex, rustyyerror)
4699         (rust_lex_test_init, rust_lex_test_sequence)
4700         (rust_lex_test_push_back, rust_lex_tests): Update.
4701         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
4702         parameter.
4703         <lexptr, prev_lexptr>: New members.
4704         (lexptr, prev_lexptr): Don't declare.
4705         * parse.c (lexptr, prev_lexptr): Remove globals.
4706         (parse_exp_in_context): Update.
4707         * p-exp.y (yylex, yyerror): Update.
4708         * m2-exp.y (parse_number, yylex, yyerror): Update.
4709         * go-exp.y (lex_one_token, yyerror): Update.
4710         * f-exp.y (match_string_literal, yylex, yyerror): Update.
4711         * d-exp.y (lex_one_token, yyerror): Update.
4712         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
4713         (lex_one_token, yyerror): Update.
4714         * ada-lex.l (YY_INPUT): Update.
4715         (rewind_to_char): Update.
4716         * ada-exp.y (yyerror): Update.
4717
4718 2019-04-04  Tom Tromey  <tom@tromey.com>
4719
4720         * rust-exp.y (rustyylex, rust_lex_tests): Update.
4721         * parser-defs.h (struct parser_state) <parser_state>: Add new
4722         parameter.
4723         <comma_terminates>: New member.
4724         (comma_terminates): Don't declare global.
4725         * parse.c (comma_terminates): Remove global.
4726         (parse_exp_in_context): Update.
4727         * p-exp.y (yylex): Update.
4728         * m2-exp.y (yylex): Update.
4729         * go-exp.y (lex_one_token): Update.
4730         * f-exp.y (yylex): Update.
4731         * d-exp.y (lex_one_token): Update.
4732         * c-exp.y (lex_one_token): Update.
4733         * ada-lex.l: Update.
4734
4735 2019-04-04  Tom Tromey  <tom@tromey.com>
4736
4737         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
4738         (rustyylex, rust_lex_test_init, rust_lex_test_one)
4739         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
4740         * parser-defs.h (paren_depth): Don't declare.
4741         * parse.c (paren_depth): Remove global.
4742         (parse_exp_in_context): Update.
4743         * p-exp.y (paren_depth): New global.
4744         (pascal_parse): Initialize it.
4745         * m2-exp.y (paren_depth): New global.
4746         (m2_parse): Initialize it.
4747         * go-exp.y (paren_depth): New global.
4748         (go_parse): Initialize it.
4749         * f-exp.y (paren_depth): New global.
4750         (f_parse): Initialize it.
4751         * d-exp.y (paren_depth): New global.
4752         (d_parse): Initialize it.
4753         * c-exp.y (paren_depth): New global.
4754         (c_parse): Initialize it.
4755         * ada-lex.l (paren_depth): New global.
4756         (lexer_init): Initialize it.
4757
4758 2019-04-04  Tom Tromey  <tom@tromey.com>
4759
4760         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
4761         (rust_parser::convert_ast_to_type)
4762         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4763         * parser-defs.h (struct parser_state) <parser_state>: Add
4764         parameters.  Initialize new members.
4765         <expression_context_block, expression_context_pc>: New members.
4766         * parse.c (expression_context_block, expression_context_pc):
4767         Remove globals.
4768         (parse_exp_in_context): Update.
4769         * p-exp.y: Update all rules.
4770         (yylex): Update.
4771         * m2-exp.y: Update all rules.
4772         (yylex): Update.
4773         * go-exp.y (yylex): Update.
4774         * f-exp.y (yylex): Update.
4775         * d-exp.y: Update all rules.
4776         (yylex): Update.
4777         * c-exp.y: Update all rules.
4778         (lex_one_token, classify_name, yylex, c_parse): Update.
4779         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
4780
4781 2019-04-04  Tom Tromey  <tom@tromey.com>
4782
4783         * gdbarch.h, gdbarch.c: Rebuild.
4784         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
4785         * stap-probe.h:
4786         (struct stap_parse_info): Replace "parser_state" with
4787         "expr_builder".
4788         * parser-defs.h (struct expr_builder): Rename from "parser_state".
4789         (parser_state): New class.
4790         * parse.c (expr_builder): Rename.
4791         (expr_builder::release): Rename.
4792         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
4793         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
4794         (write_exp_elt_longcst, write_exp_elt_floatcst)
4795         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
4796         (write_exp_string_vector, write_exp_bitstring)
4797         (write_exp_msymbol, mark_struct_expression)
4798         (write_dollar_variable)
4799         (insert_type_address_space, increase_expout_size): Replace
4800         "parser_state" with "expr_builder".
4801         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
4802         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
4803         "parser_state" with "expr_builder".
4804
4805 2019-04-04  Tom Tromey  <tom@tromey.com>
4806
4807         * rust-exp.y: Replace "parse_language" with method call.
4808         * p-exp.y:
4809         (yylex): Replace "parse_language" with method call.
4810         * m2-exp.y:
4811         (yylex): Replace "parse_language" with method call.
4812         * go-exp.y (classify_name): Replace "parse_language" with method
4813         call.
4814         * f-exp.y (yylex): Replace "parse_language" with method call.
4815         * d-exp.y (lex_one_token): Replace "parse_language" with method
4816         call.
4817         * c-exp.y:
4818         (lex_one_token, classify_name, yylex): Replace "parse_language"
4819         with method call.
4820         * ada-exp.y (find_primitive_type, type_char)
4821         (type_system_address): Replace "parse_language" with method call.
4822
4823 2019-04-04  Tom Tromey  <tom@tromey.com>
4824
4825         * rust-exp.y: Replace "parse_gdbarch" with method call.
4826         * parse.c (write_dollar_variable, insert_type_address_space):
4827         Replace "parse_gdbarch" with method call.
4828         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
4829         call.
4830         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
4831         call.
4832         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
4833         "parse_gdbarch" with method call.
4834         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
4835         with method call.
4836         * f-exp.y (parse_type, parse_f_type, yylex): Replace
4837         "parse_gdbarch" with method call.
4838         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
4839         "parse_gdbarch" with method call.
4840         * c-exp.y (parse_type, parse_number, classify_name): Replace
4841         "parse_gdbarch" with method call.
4842         * ada-lex.l: Replace "parse_gdbarch" with method call.
4843         * ada-exp.y (parse_type, find_primitive_type, type_char)
4844         (type_system_address): Replace "parse_gdbarch" with method call.
4845
4846 2019-04-04  Tom Tromey  <tom@tromey.com>
4847
4848         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
4849         * stap-probe.c (stap_parse_argument): Update.
4850         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
4851         initial_size parameter.
4852         * rust-exp.y (rust_lex_tests): Update.
4853         * parse.c (parser_state): Update.
4854         (parse_exp_in_context): Update.
4855         * parser-defs.h (struct parser_state) <parser_state>: Remove
4856         "initial_size" parameter.
4857
4858 2019-04-04  Tom Tromey  <tom@tromey.com>
4859
4860         * parser-defs.h (increase_expout_size): Don't declare.
4861         * parse.c (increase_expout_size): Now static.
4862
4863 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
4864
4865         * gnu-nat.c (gnu_nat_target::wait): Fix
4866         target_waitstatus_to_string call.
4867
4868 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4869
4870         * eval.c (evaluate_subexp_standard): Handle internal functions
4871         during Fortran function call handling.
4872
4873 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4874
4875         * NEWS: Mention new internal functions.
4876         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
4877         (read_base_type): Use dwarf2_init_complex_target_type.
4878         * value.c (creal_internal_fn): New function.
4879         (cimag_internal_fn): New function.
4880         (_initialize_values): Register new internal functions.
4881
4882 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4883
4884         * infrun.c (stop_all_threads): If debug_infrun, always
4885         trace the wait status after wait_one, using
4886         target_waitstatus_to_string and target_pid_to_str.
4887         (handle_inferior_event): Replace various trace of
4888         wait status kind by a single trace.
4889         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
4890         wait status kind image by target_waitstatus_to_string.
4891         * target/waitstatus.c (target_waitstatus_to_string): Fix
4892         obsolete comment.
4893
4894 2019-04-01  Tom Tromey  <tromey@adacore.com>
4895
4896         PR symtab/23331:
4897         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
4898
4899 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
4900             Pedro Alves  <palves@redhat.com>
4901
4902         * top.c (quit_force): Call 'finalize_values'.
4903         * value.c (finalize_values): New function.
4904         * value.h (finalize_values): Declare.
4905
4906 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
4907
4908         * NEWS: Announce $_gdb_major and $_gdb_minor.
4909
4910         * top.c (init_gdb_version_vars): New function.
4911         (gdb_init): Call init_gdb_version_vars.
4912
4913 2019-03-29  Tom Tromey  <tromey@adacore.com>
4914
4915         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
4916         help text.  Remove dead code.
4917
4918 2019-03-29  Keith Seitz  <keiths@redhat.com>
4919
4920         From Siddhesh Poyarekar:
4921         * f-lang.h (f77_get_upperbound): Return LONGEST.
4922         (f77_get_lowerbound): Likewise.
4923         * f-typeprint.c (f_type_print_varspec_suffix): Expand
4924         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
4925         print them.
4926         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
4927         plongest to format print it.
4928         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
4929         (f77_get_upperbound): Likewise.
4930         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
4931         LOWER_BOUND to LONGEST.
4932         (f77_create_arrayprint_offset_tbl): Likewise.
4933
4934 2019-03-29  Keith Seitz  <keiths@redhat.com>
4935
4936         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
4937         %s/pulongest for TYPE_LENGTH instead of %d in format
4938         strings.
4939         * ada-typerint.c (ada_print_type): Likewise.
4940         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
4941         * compile/compile-c-support.c (generate_register_struct): Likewise.
4942         * gdbtypes.c (recursive_dump_type): Likewise.
4943         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
4944         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
4945         instead of %d in format strings.
4946         * riscv-tdep.c (riscv_type_alignment): Cast second argument
4947         to std::min to ULONGEST.
4948         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
4949         instead of %d in format strings.
4950         * tracepoint.c (info_scope_command): Likewise.
4951         * typeprint.c (print_offset_data::update)
4952         (print_offset_data::finish): Likewise.
4953         * xtensa-tdep.c (xtensa_store_return_value)
4954         (xtensa_push_dummy_call): Likewise.
4955
4956 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
4957
4958         * windows-nat.c (display_selector): Fixed format specifications
4959         for 64-bit Cygwin.
4960
4961 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4962
4963         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
4964
4965 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
4966
4967         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
4968         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
4969         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
4970         (nios2_linux_init_abi): Install it.
4971
4972 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4973
4974         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
4975
4976 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4977
4978         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
4979
4980 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4981             Tom Tromey  <tromey@adacore.com>
4982
4983         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
4984
4985 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
4986
4987         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
4988         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
4989         method to compute the bounds of range types. Also print "[evaluated]"
4990         if the bounds' values come from a dynamic evaluation.
4991
4992 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4993
4994         * cp-valprint.c (cp_print_value_fields): Don't print trailing
4995         whitespace when pretty printing is on.
4996
4997 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4998
4999         * ppc-linux-nat.c: Add include.
5000
5001 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5002
5003         * NEWS: Mention AArch64 Pointer Authentication.
5004
5005 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5006
5007         * arm-linux-nat.c: Add include.
5008
5009 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
5010
5011         * source-cache.c (source_cache::get_source_lines): Re-read
5012         fullname after calling open_source_file.
5013
5014 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
5015
5016         * NEWS: Mention TLS support for FreeBSD.
5017
5018 2019-03-25  Tom Tromey  <tromey@adacore.com>
5019
5020         * minsyms.c (BUNCH_SIZE): Update comment.
5021         (~minimal_symbol_reader): Remove old comment.
5022         (compact_minimal_symbols): Update comment.
5023         (minimal_symbol_reader::install): Remove old comment.  Update
5024         other comments.
5025
5026 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5027
5028         * s390-linux-nat.c: Add include.
5029
5030 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5031
5032         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5033         Call linux_get_hwcap.
5034         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
5035         Likewise.
5036         (aarch64_linux_get_hwcap): Remove function.
5037         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
5038         declaration.
5039         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
5040         linux_get_hwcap.
5041         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5042         * linux-tdep.c (linux_get_hwcap): Add function.
5043         (linux_get_hwcap2): Likewise.
5044         * linux-tdep.h (linux_get_hwcap): Add declaration.
5045         (linux_get_hwcap2): Likewise.
5046         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
5047         (ppc_linux_get_hwcap2): Likewise.
5048         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
5049         linux_get_hwcap.
5050         (ppc_linux_nat_target::insert_watchpoint): Likewise.
5051         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
5052         (ppc_linux_nat_target::read_description): Likewise.
5053         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
5054         * s390-linux-nat.c: Likewise.
5055         * s390-linux-tdep.c (s390_core_read_description): Likewise.
5056
5057 2019-03-24  Tom Tromey  <tom@tromey.com>
5058
5059         * ada-lang.c (standard_lookup): Simplify initialization.
5060         (ada_lookup_symbol_nonlocal): Simplify return.
5061         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
5062         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
5063         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
5064         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
5065         initialization.
5066         * solib.c (solib_global_lookup): Simplify.
5067         * symtab.c (null_block_symbol): Remove.
5068         (symbol_cache_lookup): Simplify returns.
5069         (lookup_language_this): Simplify returns.
5070         (lookup_symbol_aux): Simplify return.
5071         (lookup_local_symbol): Simplify returns.
5072         (lookup_global_symbol_from_objfile): Simplify return.
5073         (lookup_symbol_in_objfile_symtabs)
5074         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
5075         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
5076         (lookup_static_symbol, lookup_global_symbol): Simplify return.
5077         * cp-namespace.c (cp_lookup_bare_symbol)
5078         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
5079         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
5080         (cp_lookup_nested_symbol): Don't use null_block_symbol.
5081         (cp_lookup_symbol_via_imports): Simplify initialization.
5082         (find_symbol_in_baseclass): Likewise.
5083         * symtab.h (null_block_symbol): Remove.
5084         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
5085         (d_lookup_nested_symbol, d_lookup_symbol_imports)
5086         (d_lookup_symbol_module): Likewise.
5087         (find_symbol_in_baseclass): Simplify initialization.
5088
5089 2019-03-24  Tom Tromey  <tom@tromey.com>
5090
5091         * expression.h: Don't include symtab.h.
5092         (struct block): Forward declare.
5093
5094 2019-03-24  Tom Tromey  <tom@tromey.com>
5095
5096         * c-exp.y (typebase): Remove casts.
5097         * gdbtypes.c (lookup_unsigned_typename, )
5098         (lookup_signed_typename): Remove cast.
5099         * eval.c (parse_to_comma_and_eval): Remove cast.
5100         * parse.c (write_dollar_variable): Remove cast.
5101         * block.h (struct block) <superblock>: Now const.
5102         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
5103         * psymtab.c (psym_map_matching_symbols): Make "block" const.
5104         (map_block): Make "block" const.
5105         * symfile.h (struct quick_symbol_functions)
5106         <map_matching_symbols>: Constify block argument to "callback".
5107         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
5108         const.
5109         (find_pc_sect_compunit_symtab): Make "b" const.
5110         (find_symbol_at_address): Likewise.
5111         (search_symbols): Likewise.
5112         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
5113         (dw2_debug_names_lookup_symbol): Likewise.
5114         (dw2_map_matching_symbols): Update.
5115         * p-valprint.c (pascal_val_print): Remove "block".
5116         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
5117         (aux_add_nonlocal_symbols): Make "block" const.
5118         (resolve_subexp): Remove cast.
5119         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5120         const.
5121         (iterate_over_file_blocks): Likewise.
5122         * f-exp.y (%union) <bval>: Remove.
5123         * coffread.c (patch_opaque_types): Make "b" const.
5124         * spu-tdep.c (spu_catch_start): Make "block" const.
5125         * c-valprint.c (print_unpacked_pointer): Remove "block".
5126         * symmisc.c (dump_symtab_1): Make "b" const.
5127         (block_depth): Make "block" const.
5128         * d-exp.y (%union) <bval>: Remove.
5129         * cp-support.h (cp_lookup_rtti_type): Update.
5130         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5131         * psymtab.c (psym_lookup_symbol): Make "block" const.
5132         (maintenance_check_psymtabs): Make "b" const.
5133         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5134         (enumerate_locals, enumerate_args): Update.
5135         * python/py-symtab.c (stpy_global_block): Make "block" const.
5136         (stpy_static_block): Likewise.
5137         * inline-frame.c (block_starting_point_at): Make "new_block"
5138         const.
5139         * block.c (find_block_in_blockvector): Make return type const.
5140         (blockvector_for_pc_sect): Make "b" const.
5141         (find_block_in_blockvector): Make "b" const.
5142
5143 2019-03-23  Tom Tromey  <tom@tromey.com>
5144
5145         * varobj.c (varobj_create): Update.
5146         * symfile.c (clear_symtab_users): Don't reset innermost_block.
5147         * printcmd.c (display_command, do_one_display): Don't reset
5148         innermost_block.
5149         * parser-defs.h (enum innermost_block_tracker_type): Move to
5150         expression.h.
5151         (innermost_block): Update comment.
5152         * parse.c (parse_exp_1): Add tracker_types parameter.
5153         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
5154         tracker_types parameter.  Reset innermost_block.
5155         (parse_exp_in_context): Remove.
5156         (parse_expression_for_completion): Update.
5157         * objfiles.c (~objfile): Don't reset expression_context_block or
5158         innermost_block.
5159         * expression.h (enum innermost_block_tracker_type): Move from
5160         parser-defs.h.
5161         (parse_exp_1): Add tracker_types parameter.
5162         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5163         reset innermost_block.
5164
5165 2019-03-23  Tom Tromey  <tom@tromey.com>
5166
5167         * objfiles.h: Include bcache.h.
5168
5169 2019-03-23  Tom Tromey  <tom@tromey.com>
5170
5171         * linespec.c (get_current_search_block): Use
5172         scoped_restore_current_language.
5173         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5174
5175 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5176             Jiong Wang  <jiong.wang@arm.com>
5177
5178         * aarch64-linux-tdep.c
5179         (aarch64_linux_iterate_over_regset_sections): Check for pauth
5180         section.
5181         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5182
5183 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5184             Jiong Wang  <jiong.wang@arm.com>
5185
5186         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5187         instructions.
5188         (aarch64_analyze_prologue_test): Add PACIASP test.
5189         (aarch64_prologue_prev_register): Unmask PC value.
5190
5191 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5192             Jiong Wang  <jiong.wang@arm.com>
5193
5194         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
5195         (aarch64_dwarf2_prev_register): Unmask PC value.
5196         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
5197         (aarch64_execute_dwarf_cfa_vendor_op): Check for
5198         DW_CFA_AARCH64_negate_ra_state.
5199         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
5200
5201 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5202             Jiong Wang  <jiong.wang@arm.com>
5203
5204         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
5205         registers.
5206         (aarch64_pseudo_register_name): Likewise.
5207         (aarch64_pseudo_register_type): Likewise.
5208         (aarch64_pseudo_register_reggroup_p): Likewise.
5209         (aarch64_gdbarch_init): Add pauth registers.
5210         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
5211         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
5212         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
5213         (struct gdbarch_tdep): Add regnum for ra_state.
5214
5215 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5216             Jiong Wang  <jiong.wang@arm.com>
5217
5218         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
5219
5220 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5221             Jiong Wang  <jiong.wang@arm.com>
5222
5223         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
5224         function.
5225         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
5226         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
5227         (aarch64_gdbarch_init): Add puth registers.
5228         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
5229         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
5230         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
5231
5232 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5233             Jiong Wang  <jiong.wang@arm.com>
5234
5235         * aarch64-linux-nat.c
5236         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
5237         * aarch64-linux-tdep.c
5238         (aarch64_linux_core_read_description): Likewise.
5239         (aarch64_linux_get_hwcap): New function.
5240         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
5241         (aarch64_linux_get_hwcap): New declaration.
5242
5243 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5244             Jiong Wang  <jiong.wang@arm.com>
5245
5246         * aarch64-linux-nat.c
5247         (aarch64_linux_nat_target::read_description): Add pauth param.
5248         * aarch64-linux-tdep.c
5249         (aarch64_linux_core_read_description): Likewise.
5250         * aarch64-tdep.c (struct target_desc): Add in pauth.
5251         (aarch64_read_description): Add pauth param.
5252         (aarch64_gdbarch_init): Likewise.
5253         * aarch64-tdep.h (aarch64_read_description): Likewise.
5254         * arch/aarch64.c (aarch64_create_target_description): Likewise.
5255         * arch/aarch64.h (aarch64_create_target_description): Likewise.
5256         * features/Makefile: Add new files.
5257         * features/aarch64-pauth.c: New file.
5258         * features/aarch64-pauth.xml: New file.
5259
5260 2019-03-20  Tom Tromey  <tromey@adacore.com>
5261
5262         * infrun.c (handle_inferior_event): Rename from
5263         handle_inferior_event_1.  Create a scoped_value_mark.
5264         (handle_inferior_event): Remove.
5265
5266 2019-03-19  Tom Tromey  <tromey@adacore.com>
5267
5268         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
5269         * infrun.h (print_stop_event): Add "displays" parameter.
5270         * infrun.c (print_stop_event): Add "displays" parameter.
5271
5272 2019-03-19  Pedro Alves  <palves@redhat.com>
5273
5274         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
5275         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
5276         to -1.  Fix TABs vs spaces.
5277         (tui_ui_out::tui_ui_out): Don't initialize fields here.
5278         * tui/tui-out.h (tui_ui_out) Add intro comments.
5279         <m_line, m_start_of_line>: In-class initialize, and add describing
5280         comment.
5281
5282 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
5283
5284         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
5285         variable names.
5286         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
5287
5288 2019-03-18  Pedro Alves  <palves@redhat.com>
5289             Eli Zaretskii <eliz@gnu.org>
5290
5291         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
5292         m_line and m_start_of_line.
5293
5294 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
5295
5296         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
5297         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
5298         it returns a newline.  This fixes a regression in TU mode, whereby
5299         the next line is output on the same screen line as the user input.
5300
5301 2019-03-18  Tom Tromey  <tromey@adacore.com>
5302
5303         * minsyms.c (minimal_symbol_reader::install): Remove call to
5304         obstack_blank.
5305
5306 2019-03-18  Pedro Alves  <palves@redhat.com>
5307
5308         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
5309         New globals.
5310         (apply_style): New, factored out from ...
5311         (apply_ansi_escape): ... this.  Handle reverse video mode.
5312         (tui_set_reverse_mode): New function.
5313         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
5314         * tui/tui-winsource.c (tui_show_source_line): Use
5315         tui_set_reverse_mode instead of setting A_STANDOUT.
5316         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
5317         New setter methods.
5318
5319 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
5320
5321         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
5322         Handle tabs.
5323
5324 2019-03-18  Tom Tromey  <tromey@adacore.com>
5325
5326         * ada-lang.c (empty_array): Add "high" parameter.
5327         (ada_evaluate_subexp): Update.
5328
5329 2019-03-17  Sergei Trofimovich <siarheit@google.com>
5330
5331         * unittests/string_view-selftests.c: Define
5332         _initialize_string_view_selftests unconditionally.
5333
5334 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5335
5336         PR gdb/24350
5337         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
5338
5339 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5340
5341         PR gdb/24351
5342         * windows-nat.c (display_selector): Fix format specifiers.
5343
5344 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
5345
5346         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
5347         tui_refill_source_window instead of tui_refresh_win, to update the
5348         current execution line.  This fixes redisplay of the current line
5349         when stepping through the code with "next" or "step".
5350
5351 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5352
5353         * source-cache.c (source_cache::get_source_lines): Call
5354         find_source_lines to initialize s->nlines.  This fixes vertical
5355         scrolling of TUI source window when the DOWN arrow is pressed.
5356
5357 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5358
5359         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
5360         linux-thread-db.c (_initialize_thread_db): Likewise.
5361
5362 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5363
5364         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
5365         wclrtoeol in tui_show_source_line".  This reverts changes made in
5366         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
5367
5368 2019-03-15  Tom Tromey  <tom@tromey.com>
5369
5370         * symtab.h (struct minimal_symbol): Derive from
5371         general_symbol_info.
5372         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
5373         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
5374         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
5375         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
5376         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
5377         (MSYMBOL_SEARCH_NAME): Update.
5378         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
5379         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
5380         * minsyms.c (minimal_symbol_reader::record_full): Update.
5381
5382 2019-03-15  Tom Tromey  <tom@tromey.com>
5383
5384         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
5385
5386 2019-03-15  Tom Tromey  <tom@tromey.com>
5387
5388         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
5389         unique_xmalloc_ptr.
5390         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
5391         Update.
5392         * minsyms.c (lookup_minimal_symbol_by_pc_section)
5393         (build_minimal_symbol_hash_tables)
5394         (minimal_symbol_reader::install): Update.
5395
5396 2019-03-15  Tom Tromey  <tom@tromey.com>
5397
5398         * symtab.c (create_demangled_names_hash): Update.
5399         (symbol_set_names): Update.
5400         * objfiles.h (struct objfile_per_bfd_storage)
5401         <demangled_names_hash>: Now an htab_up.
5402         * objfiles.c (objfile_per_bfd_storage): Simplify.
5403
5404 2019-03-15  Tom Tromey  <tom@tromey.com>
5405
5406         * objfiles.h (struct objfile_per_bfd_storage): Declare
5407         destructor.
5408         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
5409         New.
5410         (get_objfile_bfd_data): Use new.  Don't initialize
5411         language_of_main.
5412         (free_objfile_per_bfd_storage): Remove.
5413         (objfile_bfd_data_free, objfile::~objfile): Use delete.
5414
5415 2019-03-15  Tom Tromey  <tom@tromey.com>
5416
5417         * symfile.c (reread_symbols): Update.
5418         * objfiles.c (objfile::objfile): Update.
5419         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
5420         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
5421         comment.
5422         (minimal_symbol_reader::install): Update.
5423         (terminate_minimal_symbol_table): Remove.
5424         * jit.c (jit_object_close_impl): Update.
5425
5426 2019-03-15  Tom Tromey  <tom@tromey.com>
5427
5428         * minsyms.c (minimal_symbol_reader::record_full): Remove some
5429         initializations.
5430
5431 2019-03-15  Tom Tromey  <tom@tromey.com>
5432
5433         * objfiles.h (struct objfile_per_bfd_storage)
5434         <demangled_hash_languages>: Now a bitset.
5435         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
5436         (lookup_minimal_symbol): Update.
5437
5438 2019-03-15  Tom Tromey  <tom@tromey.com>
5439
5440         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
5441         Don't return the symbol.
5442         * coffread.c (record_minimal_symbol): Use record_full.
5443
5444 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
5445
5446         The MS-Windows port of ncurses fails to switch to a color pair if
5447         one or both of the colors are the implicit default colors.  This
5448         change records the default colors when TUI is initialized, and
5449         then specifies them explicitly when a color pair uses the default
5450         colors.  This allows color styling in TUI mode on MS-Windows.
5451
5452         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
5453         ncurses_norm_attr.
5454         (tui_initialize_io) [__MINGW32__]: Record the default terminal
5455         colors in ncurses_norm_attr.
5456         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
5457         "none", replace it with the default color recorded in
5458         ncurses_norm_attr.
5459
5460 2019-03-14  Tom Tromey  <tromey@adacore.com>
5461
5462         * source-cache.h (class source_cache) <get_source_lines>: Return
5463         std::string.
5464         * source-cache.c (source_cache::extract_lines): Handle case where
5465         first_pos==npos.  Return std::string.
5466         (source_cache::get_source_lines): Update.
5467
5468 2019-03-14  Tom Tromey  <tromey@adacore.com>
5469
5470         * NEWS: Add item for "style sources" commands.
5471         * source-cache.c (source_cache::get_source_lines): Check
5472         source_styling.
5473         * cli/cli-style.c (source_styling): New global.
5474         (_initialize_cli_style): Add "style sources" commands.
5475         (show_style_sources): New function.
5476         * cli/cli-style.h (source_styling): Declare.
5477
5478 2019-03-14  Pedro Alves  <palves@redhat.com>
5479             Tom Tromey  <tromey@adacore.com>
5480
5481         * tui/tui-winsource.h (tui_refill_source_window): Declare.
5482         * tui/tui-winsource.c (tui_refill_source_window): New function,
5483         from...
5484         (tui_horizontal_source_scroll): ... here.  Move some logic.
5485         * cli/cli-style.c (set_style_enabled): Notify new observable.
5486         * tui/tui-hooks.c (tui_redisplay_source): New function.
5487         (tui_attach_detach_observers): Attach or detach
5488         tui_redisplay_source.
5489         * observable.h (source_styling_changed): New observable.
5490         * observable.c: Define source_styling_changed observable.
5491
5492 2019-03-13  Tom Tromey  <tromey@adacore.com>
5493
5494         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
5495         (i386_gnu_nat_target::store_registers): Update.
5496         * target-debug.h (target_debug_print_std_string): New macro.
5497         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5498         * windows-tdep.c (display_one_tib): Update.
5499         * tui/tui-stack.c (tui_make_status_line): Update.
5500         * top.c (print_inferior_quit_action): Update.
5501         * thread.c (thr_try_catch_cmd): Update.
5502         (add_thread_with_info): Update.
5503         (thread_target_id_str): Update.
5504         (thr_try_catch_cmd): Update.
5505         (thread_command): Update.
5506         (thread_find_command): Update.
5507         * record-btrace.c (record_btrace_target::info_record)
5508         (record_btrace_resume_thread, record_btrace_target::resume)
5509         (record_btrace_cancel_resume, record_btrace_step_thread)
5510         (record_btrace_target::wait, record_btrace_target::wait)
5511         (record_btrace_target::wait, record_btrace_target::stop): Update.
5512         * progspace.c (print_program_space): Update.
5513         * process-stratum-target.c
5514         (process_stratum_target::thread_address_space): Update.
5515         * linux-fork.c (linux_fork_mourn_inferior)
5516         (detach_checkpoint_command, info_checkpoints_command)
5517         (linux_fork_context): Update.
5518         (linux_fork_detach): Update.
5519         (class scoped_switch_fork_info): Update.
5520         (delete_checkpoint_command): Update.
5521         * infrun.c (follow_fork_inferior): Update.
5522         (follow_fork_inferior): Update.
5523         (proceed_after_vfork_done): Update.
5524         (handle_vfork_child_exec_or_exit): Update.
5525         (follow_exec): Update.
5526         (displaced_step_prepare_throw): Update.
5527         (displaced_step_restore): Update.
5528         (start_step_over): Update.
5529         (resume_1): Update.
5530         (clear_proceed_status_thread): Update.
5531         (proceed): Update.
5532         (print_target_wait_results): Update.
5533         (do_target_wait): Update.
5534         (context_switch): Update.
5535         (stop_all_threads): Update.
5536         (restart_threads): Update.
5537         (finish_step_over): Update.
5538         (handle_signal_stop): Update.
5539         (switch_back_to_stepped_thread): Update.
5540         (keep_going_pass_signal): Update.
5541         (print_exited_reason): Update.
5542         (normal_stop): Update.
5543         * inferior.c (inferior_pid_to_str): Change return type.
5544         (print_selected_inferior): Update.
5545         (add_inferior): Update.
5546         (detach_inferior): Update.
5547         * dummy-frame.c (fprint_dummy_frames): Update.
5548         * dcache.c (dcache_info_1): Update.
5549         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
5550         (btrace_fetch, btrace_clear): Update.
5551         * linux-tdep.c (linux_core_pid_to_str): Change return type.
5552         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
5553         type.
5554         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
5555         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
5556         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
5557         * gdbarch.c, gdbarch.h: Rebuild.
5558         * gdbarch.sh (core_pid_to_str): Change return type.
5559         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
5560         return type.
5561         (windows_nat_target::pid_to_str): Change return type.
5562         (windows_delete_thread): Update.
5563         (windows_nat_target::attach): Update.
5564         (windows_nat_target::files_info): Update.
5565         * target-delegates.c: Rebuild.
5566         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
5567         return type.
5568         (sol_thread_target::pid_to_str): Change return type.
5569         * remote.c (class remote_target) <pid_to_str>: Change return
5570         type.
5571         (remote_target::pid_to_str): Change return type.
5572         (extended_remote_target::attach, remote_target::remote_stop_ns)
5573         (remote_target::remote_notif_remove_queued_reply)
5574         (remote_target::push_stop_reply, remote_target::disable_btrace):
5575         Update.
5576         (extended_remote_target::attach): Update.
5577         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
5578         type.
5579         (gdbsim_target::pid_to_str): Change return type.
5580         * ravenscar-thread.c (struct ravenscar_thread_target)
5581         <pid_to_str>: Change return type.
5582         (ravenscar_thread_target::pid_to_str): Change return type.
5583         * procfs.c (class procfs_target) <pid_to_str>: Change return
5584         type.
5585         (procfs_target::pid_to_str): Change return type.
5586         (procfs_target::attach): Update.
5587         (procfs_target::detach): Update.
5588         (procfs_target::fetch_registers): Update.
5589         (procfs_target::store_registers): Update.
5590         (procfs_target::wait): Update.
5591         (procfs_target::files_info): Update.
5592         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
5593         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
5594         return type.
5595         (nto_procfs_target::pid_to_str): Change return type.
5596         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
5597         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
5598         return type.
5599         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
5600         (exit_lwp): Update.
5601         (attach_proc_task_lwp_callback, get_detach_signal)
5602         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
5603         (linux_nat_target::resume, wait_lwp, stop_callback)
5604         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
5605         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
5606         (linux_nat_wait_1, resume_stopped_resumed_lwps)
5607         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
5608         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
5609         type.
5610         (inf_ptrace_target::attach): Update.
5611         (inf_ptrace_target::files_info): Update.
5612         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
5613         type.
5614         (go32_nat_target::pid_to_str): Change return type.
5615         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
5616         (gnu_nat_target::wait): Update.
5617         (gnu_nat_target::wait): Update.
5618         (gnu_nat_target::resume): Update.
5619         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
5620         (fbsd_nat_target::wait): Update.
5621         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
5622         type.
5623         (darwin_nat_target::attach): Update.
5624         * corelow.c (class core_target) <pid_to_str>: Change return type.
5625         (core_target::pid_to_str): Change return type.
5626         * target.c (normal_pid_to_str): Change return type.
5627         (default_pid_to_str): Likewise.
5628         (target_pid_to_str): Change return type.
5629         (target_translate_tls_address): Update.
5630         (target_announce_detach): Update.
5631         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
5632         return type.
5633         (bsd_uthread_target::pid_to_str): Change return type.
5634         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
5635         type.
5636         (bsd_kvm_target::pid_to_str): Change return type.
5637         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
5638         return type.
5639         (aix_thread_target::pid_to_str): Change return type.
5640         * target.h (struct target_ops) <pid_to_str>: Change return type.
5641         (target_pid_to_str, normal_pid_to_str): Likewise.
5642         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
5643         type.
5644         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
5645         type.
5646         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
5647         return type.
5648         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
5649         type.
5650         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
5651         type.
5652         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
5653         return type.
5654
5655 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
5656
5657         * NEWS: Mention that the new default MI version is 3.  Mention
5658         changes to the output of commands and events that deal with
5659         multi-location breakpoints.
5660         * breakpoint.c: Include "mi/mi-out.h".
5661         (print_one_breakpoint): Change output syntax if using MI version
5662         >= 3.
5663         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
5664         New.
5665         (mi_multi_location_breakpoint_output_fixed): New.
5666         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
5667         (mi_cmd_fix_multi_location_breakpoint_output): New.
5668         (mi_multi_location_breakpoint_output_fixed): New.
5669         * mi/mi-cmds.c (mi_cmds): Register command
5670         -fix-multi-location-breakpoint-output.
5671         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
5672         interpreter "mi".
5673
5674 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
5675
5676         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
5677         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
5678         instantiate mi_ui_out based on interpreter name.
5679         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
5680         * mi/mi-main.c (mi_load_progress): Likewise.
5681
5682 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5683
5684         * NEWS: Combine separate "New targets" sections for 8.3.
5685
5686 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5687
5688         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
5689         (ppcfbsd_init_abi): Install gdbarch
5690         "fetch_tls_load_module_address" and "get_thread_local_address"
5691         methods.
5692
5693 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5694
5695         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
5696         (riscv_fbsd_init_abi): Install gdbarch
5697         "fetch_tls_load_module_address" and "get_thread_local_address"
5698         methods.
5699
5700 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5701
5702         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
5703         (i386fbsd_init_abi): Install gdbarch
5704         "fetch_tls_load_module_address" and "get_thread_local_address"
5705         methods.
5706
5707 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5708
5709         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
5710         (amd64fbsd_init_abi): Install gdbarch
5711         "fetch_tls_load_module_address" and "get_thread_local_address"
5712         methods.
5713
5714 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5715
5716         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
5717         (struct fbsd_pspace_data): New type.
5718         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
5719         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
5720         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
5721         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
5722         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
5723
5724 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5725
5726         * gdbtypes.c (lookup_struct_elt): New function.
5727         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
5728         * gdbtypes.h (struct struct_elt): New type.
5729         (lookup_struct_elt): New prototype.
5730
5731 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5732
5733         * gdbtypes.c (lookup_struct_elt_type): Update comment and
5734         remove disabled code block.
5735
5736 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5737
5738         * gdbarch.sh (get_thread_local_address): New method.
5739         * gdbarch.h, gdbarch.c: Regenerate.
5740         * target.c (target_translate_tls_address): Use
5741         gdbarch_get_thread_local_address if present instead of
5742         target::get_thread_local_address.
5743
5744 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5745
5746         * target.h (target::get_thread_local_address): Update comment.
5747
5748 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5749
5750         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
5751         objfile->separate_debug_objfile_backlink if not NULL.
5752
5753 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5754
5755         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
5756         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
5757         (amd64bsd_store_inferior_registers): Likewise.
5758         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5759         Enable segment base registers.
5760         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
5761         PT_GETFSBASE and PT_GETGSBASE.
5762         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
5763         PT_SETGSBASE.
5764         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
5765         segment base registers.
5766         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5767
5768 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5769
5770         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5771         Update calls to i386_target_description to add 'segments'
5772         parameter.
5773         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
5774         add segment base registers.
5775         * arch/i386.c (i386_create_target_description): Add 'segments'
5776         parameter to enable segment base registers.
5777         * arch/i386.h (i386_create_target_description): Likewise.
5778         * features/i386/32bit-segments.xml: New file.
5779         * features/i386/32bit-segments.c: Generate.
5780         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
5781         call to i386_target_description to add 'segments' parameter.
5782         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5783         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
5784         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
5785         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
5786         if feature is present.
5787         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
5788         Add 'segments' parameter to call to i386_target_description.
5789         (i386_target_description): Add 'segments' parameter to enable
5790         segment base registers.
5791         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
5792         to call to i386_target_description.
5793         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
5794         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
5795         Define I386_NUM_REGS.
5796         (i386_target_description): Add 'segments' parameter to enable
5797         segment base registers.
5798
5799 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
5800
5801         PR/24325
5802         * source-cache.c: #undef open and close, to avoid unresolved
5803         externals during linking.
5804
5805 2019-03-12  Tom Tromey  <tromey@adacore.com>
5806
5807         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
5808         const.  Add initializers.
5809         (_initialize_remote): Don't initialize ptid globals.
5810
5811 2019-03-12  Pedro Alves  <palves@redhat.com>
5812
5813         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
5814
5815 2019-03-12  Pedro Alves  <palves@redhat.com>
5816
5817         * cp-name-parser.y (main): Remove unused 'len' variable.
5818
5819 2019-03-12  Tom Tromey  <tromey@adacore.com>
5820
5821         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
5822         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
5823
5824 2019-03-12  Tom Tromey  <tromey@adacore.com>
5825
5826         * linux-nat.c (iterate_over_lwps): Update.
5827         (stop_callback): Remove parameter.
5828         (stop_wait_callback, detach_callback, resume_set_callback)
5829         (select_singlestep_lwp_callback, set_ignore_sigint)
5830         (status_callback, resumed_callback, resume_clear_callback)
5831         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
5832         data parameter.
5833         (linux_nat_target::detach, linux_nat_target::resume)
5834         (linux_stop_and_wait_all_lwps, select_event_lwp)
5835         (linux_nat_filter_event, linux_nat_wait_1)
5836         (linux_nat_target::kill, linux_nat_target::stop)
5837         (linux_nat_target::stop): Update.
5838         (linux_nat_resume_callback): Change type.
5839         (resume_stopped_resumed_lwps, count_events_callback)
5840         (select_event_lwp_callback): Likewise.
5841         (linux_stop_lwp, linux_nat_stop_lwp): Update.
5842         * arm-linux-nat.c (struct update_registers_data): Remove.
5843         (update_registers_callback): Change type.
5844         (arm_linux_insert_hw_breakpoint1): Update.
5845         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
5846         parameter.
5847         (x86_linux_dr_set_addr): Update.
5848         (x86_linux_dr_set_control): Update.
5849         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
5850         (iterate_over_lwps): Use gdb::function_view.
5851         * nat/aarch64-linux-hw-point.c (struct
5852         aarch64_dr_update_callback_param): Remove.
5853         (debug_reg_change_callback): Change type.
5854         (aarch64_notify_debug_reg_change): Update.
5855         * s390-linux-nat.c (s390_refresh_per_info): Update.
5856
5857 2019-03-11  Tom Tromey  <tromey@adacore.com>
5858
5859         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
5860         redundant assignment to "this_cu".
5861
5862 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5863
5864         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
5865
5866 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5867
5868         * gdbtypes.c (rank_one_type_parm_set): New function extracted
5869         from...
5870         (rank_one_type): ... this.
5871
5872 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5873
5874         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
5875         from...
5876         (rank_one_type): ... this.
5877
5878 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5879
5880         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
5881         from...
5882         (rank_one_type): ... this.
5883
5884 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5885
5886         * gdbtypes.c (rank_one_type_parm_float): New function extracted
5887         from...
5888         (rank_one_type): ... this.
5889
5890 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5891
5892         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
5893         from...
5894         (rank_one_type): ... this.
5895
5896 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5897
5898         * gdbtypes.c (rank_one_type_parm_range): New function extracted
5899         from...
5900         (rank_one_type): ... this.
5901
5902 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5903
5904         * gdbtypes.c (rank_one_type_parm_char): New function extracted
5905         from...
5906         (rank_one_type): ... this.
5907
5908 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5909
5910         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
5911         from...
5912         (rank_one_type): ... this.
5913
5914 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5915
5916         * gdbtypes.c (rank_one_type_parm_int): New function extracted
5917         from...
5918         (rank_one_type): ... this.
5919
5920 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5921
5922         * gdbtypes.c (rank_one_type_parm_func): New function extracted
5923         from...
5924         (rank_one_type): ... this.
5925
5926 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5927
5928         * gdbtypes.c (rank_one_type_parm_array): New function extracted
5929         from...
5930         (rank_one_type): ... this.
5931
5932 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5933
5934         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
5935         from...
5936         (rank_one_type): ... this.
5937
5938 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5939
5940         * inferior.c (initialize_inferiors): Ensure 'help set/show print
5941         inferior-events' shows the example events.
5942
5943 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
5944
5945         Support styling on native MS-Windows console
5946
5947         PR/24315
5948         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
5949         on MS-Windows if $TERM is not defined.
5950
5951         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
5952
5953         * posix-hdep.c (gdb_console_fputs):
5954         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
5955         functions.
5956         * ui-file.h (gdb_console_fputs): Add prototype.
5957
5958         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
5959         back to fputs only if the former returns zero.
5960
5961 2019-03-07  Tom Tromey  <tom@tromey.com>
5962
5963         * symmisc.c (print_symbol_bcache_statistics): Update.
5964         (print_objfile_statistics): Update.
5965         * symfile.c (allocate_symtab): Update.
5966         * stabsread.c: Don't include bcache.h.
5967         * psymtab.h (struct psymbol_bcache): Don't declare.
5968         (class psymtab_storage) <psymbol_cache>: Now a bcache.
5969         (psymbol_bcache_init, psymbol_bcache_free)
5970         (psymbol_bcache_get_bcache): Don't declare.
5971         * psymtab.c (struct psymbol_bcache): Remove.
5972         (psymtab_storage::psymtab_storage): Update.
5973         (psymtab_storage::~psymtab_storage): Update.
5974         (psymbol_bcache_init, psymbol_bcache_free)
5975         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
5976         (add_psymbol_to_bcache): Update.
5977         (allocate_psymtab): Update.
5978         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
5979         macro_cache>: No longer pointers.
5980         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
5981         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
5982         * macrotab.c (macro_bcache): Update.
5983         * macroexp.c: Don't include bcache.h.
5984         * gdbtypes.c (check_types_worklist): Update.
5985         (types_deeply_equal): Remove TRY/CATCH.  Update.
5986         * elfread.c (elf_symtab_read): Update.
5987         * dwarf2read.c: Don't include bcache.h.
5988         * buildsym.c (buildsym_compunit::get_macro_table): Update.
5989         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
5990         (print_bcache_statistics, bcache_memory_used): Don't declare.
5991         (struct bcache): Move from bcache.c.  Add constructor, destructor,
5992         methods.  Rename all data members.
5993         * bcache.c (struct bcache): Move to bcache.h.
5994         (bcache::expand_hash_table): Rename from expand_hash_table.
5995         (bcache): Remove.
5996         (bcache::insert): Rename from bcache_full.
5997         (bcache::compare): Rename from bcache_compare.
5998         (bcache_xmalloc): Remove.
5999         (bcache::~bcache): Rename from bcache_xfree.
6000         (bcache::print_statistics): Rename from print_bcache_statistics.
6001         (bcache::memory_used): Rename from bcache_memory_used.
6002
6003 2019-03-07  Pedro Alves  <palves@redhat.com>
6004
6005         * infrun.c (normal_stop): Also check for
6006         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
6007
6008 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
6009
6010         * f-lang.c (value_from_host_double): Moved to...
6011         * value.c (value_from_host_double): ...here.
6012         * value.h (value_from_host_double): Declare.
6013         * guile/scm-math.c (vlscm_convert_typed_number): Use
6014         value_from_host_double.
6015         (vlscm_convert_number): Likewise.
6016         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
6017         * python/py-value.c (convert_value_from_python): Likewise.
6018
6019 2019-03-06  Tom Tromey  <tom@tromey.com>
6020
6021         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
6022
6023 2019-03-06  Tom Tromey  <tom@tromey.com>
6024
6025         * utils.h (free_current_contents): Don't declare.
6026         * utils.c (free_current_contents): Remove.
6027
6028 2019-03-06  Tom Tromey  <tom@tromey.com>
6029
6030         * top.c (quit_force): Update.
6031         * main.c (captured_command_loop): Update.
6032         * common/new-op.c (operator new): Update.
6033         * common/common-exceptions.c (struct catcher)
6034         <save_cleanup_chain>: Remove member.
6035         (exceptions_state_mc_init): Update.
6036         (exception_try_scope_entry): Return nullptr.
6037         (exception_try_scope_exit, exception_rethrow)
6038         (throw_exception_sjlj, throw_exception_cxx): Update.
6039         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
6040         (all_cleanups, do_cleanups, discard_cleanups)
6041         (discard_final_cleanups, save_cleanups, save_final_cleanups)
6042         (restore_cleanups, restore_final_cleanups): Don't declare.
6043         (do_final_cleanups): Remove parameter.
6044         * common/cleanups.c (cleanup_chain, make_cleanup)
6045         (make_cleanup_dtor, all_cleanups, do_cleanups)
6046         (discard_my_cleanups, discard_cleanups)
6047         (discard_final_cleanups, save_my_cleanups, save_cleanups)
6048         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
6049         (null_cleanup): Remove.
6050         (do_final_cleanups): Remove parameter.
6051
6052 2019-03-06  Tom Tromey  <tom@tromey.com>
6053
6054         * remote.c (remote_target::remote_parse_stop_reply): Use
6055         unique_xmalloc_ptr.
6056
6057 2019-03-06  Tom Tromey  <tom@tromey.com>
6058
6059         * stabsread.c (struct stabs_field_info): Rename from field_info.
6060         <list, fnlist>: Add initializers.
6061         <obstack>: New member.
6062         (read_member_functions, read_struct_fields, read_baseclasses):
6063         Allocate on obstack.  Don't use cleanups.
6064         (read_one_struct_field, read_member_functions, read_struct_fields)
6065         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
6066         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
6067         (read_struct_type): Update.
6068
6069 2019-03-06  Tom Tromey  <tom@tromey.com>
6070
6071         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
6072         * common/filestuff.h (make_cleanup_close): Don't declare.
6073         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
6074         Remove.
6075
6076 2019-03-06  Tom Tromey  <tom@tromey.com>
6077
6078         * solib-aix.c: Use make_scope_exit.
6079
6080 2019-03-06  Tom Tromey  <tom@tromey.com>
6081
6082         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
6083         Use make_scope_exit.
6084
6085 2019-03-06  Tom Tromey  <tom@tromey.com>
6086
6087         * solib-svr4.c (disable_probes_interface): Remove parameter.
6088         (svr4_handle_solib_event): Use make_scope_exit.
6089
6090 2019-03-06  Tom Tromey  <tom@tromey.com>
6091
6092         * remote.c (struct stop_reply_deleter): Remove.
6093         (stop_reply_up): Update.
6094         (struct stop_reply): Derive from notif_event.  Don't typedef.
6095         <regcache>: Now a std::vector.
6096         (stop_reply_xfree): Remove.
6097         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
6098         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
6099         (remote_target::discard_pending_stop_replies): Use delete.
6100         (remote_target::remote_parse_stop_reply): Update.
6101         (remote_target::process_stop_reply): Update.
6102         * remote-notif.h (struct notif_event): Add virtual destructor.
6103         Remove "dtr" member.
6104         (struct notif_client) <alloc_event>: Return a unique_ptr.
6105         (notif_event_xfree): Don't declare.
6106         (notif_event_up): New typedef.
6107         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
6108         (notif_event_xfree, do_notif_event_xfree): Remove.
6109         (remote_notif_state_xfree): Update.
6110
6111 2019-03-06  Tom Tromey  <tom@tromey.com>
6112
6113         * infrun.c (displaced_step_clear_cleanup): Now a
6114         forward_scope_exit type.
6115         (displaced_step_prepare_throw): Update.
6116         (displaced_step_fixup): Update.
6117
6118 2019-03-06  Tom Tromey  <tom@tromey.com>
6119
6120         * inferior.h (class inferior): Update comment.
6121         * gdbthread.h (class thread_info): Update comment.
6122
6123 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
6124             Tom Tromey  <tom@tromey.com>
6125
6126         * stabsread.h (struct stab_section_list): Remove.
6127         (coffstab_build_psymtabs): Update.
6128         * dbxread.c (symbuf_sections): Now a std::vector.
6129         (sect_idx): New global.
6130         (fill_symbuf): Update.
6131         (coffstab_build_psymtabs): Change type of stabsects parameter.
6132         Update.
6133         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6134         std::vector.
6135         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6136         (coff_locate_sections): Update.
6137         (coff_symfile_read): Remove cleanups.  Update.
6138         (init_stringtab): Add storage parameter.
6139         (free_stringtab, free_stringtab_cleanup): Remove.
6140         (init_lineno): Add storage parameter.
6141         (free_linetab, free_linetab_cleanup): Remove.
6142
6143 2019-03-06  Pedro Alves  <palves@redhat.com>
6144
6145         * linux-fork.c (fork_info::clobber_regs): Delete.
6146         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6147         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
6148         comment.  Adjust.
6149         (scoped_switch_fork_info::scoped_switch_fork_info)
6150         (checkpoint_command, linux_fork_context): Adjust
6151         fork_save_infrun_state calls.
6152
6153 2019-03-06  Pedro Alves  <palves@redhat.com>
6154
6155         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6156         (inf_has_multiple_threads): Return 'bool' and rewrite using
6157         inferior_info::threads().
6158
6159 2019-03-06  Pedro Alves  <palves@redhat.com>
6160
6161         * linux-fork.c: Include <list>.
6162         (fork_list): Now a std::list instance.
6163         (fork_info): Add ctor, dtor, and in-class initialize all fields.
6164         (forks_exist_p, find_last_fork): Adjust.
6165         (new_fork): Delete.
6166         (one_fork_p): New.
6167         (add_fork): Adjust.
6168         (free_fork): Delete, folded into fork_info::~fork_info().
6169         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6170         Adjust.
6171         (init_fork_list): Delete.
6172         (linux_fork_killall, linux_fork_mourn_inferior)
6173         (linux_fork_detach, info_checkpoints_command): Adjust.
6174         (_initialize_linux_fork): No longer call init_fork_list.
6175
6176 2019-03-06  Pedro Alves  <palves@redhat.com>
6177
6178         * linux-fork.c (new_fork): New, split out of ...
6179         (add_fork): ... this.  Return void.  Move "first fork" special
6180         case from here, to ...
6181         (checkpoint_command): ... here.
6182         * linux-linux.h (add_fork): Return void.
6183
6184 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6185
6186         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6187
6188 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6189             Chris January  <chris.january@arm.com>
6190             David Lecomber  <david.lecomber@arm.com>
6191
6192         * f-exp.y: New token, UNOP_INTRINSIC.
6193         (exp): New pattern using UNOP_INTRINSIC token.
6194         (f77_keywords): Add 'abs' keyword.
6195         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
6196         (value_from_host_double): New function.
6197         (evaluate_subexp_f): Support UNOP_ABS.
6198
6199 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6200
6201         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
6202         types.
6203
6204 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6205
6206         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
6207         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
6208         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
6209
6210 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6211
6212         * f-exp.y (convert_to_kind_type): Handle more type kinds.
6213
6214 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6215             Chris January  <chris.january@arm.com>
6216
6217         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
6218         * f-exp.y: Define 'KIND' token.
6219         (exp): New pattern for KIND expressions.
6220         (ptype): Handle types with a kind extension.
6221         (direct_abs_decl): Extend to spot kind extensions.
6222         (f77_keywords): Add 'kind' to the list.
6223         (push_kind_type): New function.
6224         (convert_to_kind_type): New function.
6225         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
6226         * parse.c (operator_length_standard): Likewise.
6227         * parser-defs.h (enum type_pieces): Add tp_kind.
6228         * std-operator.def: Add UNOP_KIND.
6229
6230 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6231
6232         * f-exp.y (f_parse): Set yydebug.
6233
6234 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6235
6236         * f-lang.c (evaluate_subexp_f): New function.
6237         (exp_descriptor_f): New global.
6238         (f_language_defn): Use exp_descriptor_f instead of
6239         exp_descriptor_standard.
6240
6241 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6242
6243         * f-exp.y (struct token): Add comments.
6244         (dot_ops): Remove uppercase versions and the end marker.
6245         (f77_keywords): Likewise.
6246         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
6247         entries in the dot_ops array are case insensitive, and use
6248         strncasecmp to compare strings.  Also some whitespace cleanup in
6249         this area.  Similar for the f77_keywords array, except entries in
6250         this list might be case sensitive.
6251
6252 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6253
6254         * f-exp.y (struct f77_boolean_val): Add comments.
6255         (boolean_values): Remove uppercase versions, and end marker.
6256         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
6257         and use strncasecmp to achieve case insensitivity.  Additionally,
6258         perform whitespace cleanup around this code.
6259
6260 2019-03-06  Tom Tromey  <tromey@adacore.com>
6261
6262         * remote-sim.c (gdbsim_target_open): Use result of
6263         gdb_argv::release.
6264
6265 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
6266         Dirk Schubert  <dirk.schubert@arm.com>
6267         Chris January  <chris.january@arm.com>
6268
6269         * eval.c (evaluate_subexp_standard): Call Fortran argument
6270         wrapping logic.
6271         * f-lang.c (struct value): A value which can be passed into a
6272         Fortran function call.
6273         (fortran_argument_convert): Wrap Fortran arguments in a pointer
6274         where appropriate.
6275         (struct type): Value ready for a Fortran function call.
6276         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
6277         is needed.
6278         * f-lang.h (fortran_argument_convert): Declaration.
6279         (fortran_preserve_arg_pointer): Declaration.
6280         * infcall.c (value_arg_coerce): Call Fortran argument logic.
6281
6282 2019-03-05  Tom Tromey  <tromey@adacore.com>
6283
6284         * python/py-prettyprint.c (print_string_repr): Remove #if.
6285         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
6286
6287 2019-03-05  Tom Tromey  <tromey@adacore.com>
6288
6289         * target.c (the_dummy_target): Move later.  Change type to
6290         "dummy_target".
6291         (initialize_targets): Don't initialize the_dummy_target.
6292
6293 2019-03-05  Tom Tromey  <tromey@adacore.com>
6294
6295         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
6296         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
6297
6298 2019-03-05  Tom Tromey  <tromey@adacore.com>
6299
6300         * windows-nat.c (windows_nat_target::attach)
6301         (windows_nat_target::detach): Don't call gdb_flush.
6302         * valprint.c (generic_val_print, val_print, val_print_string):
6303         Don't call gdb_flush.
6304         * utils.c (defaulted_query): Don't call gdb_flush.
6305         * typeprint.c (print_type_scalar): Don't call gdb_flush.
6306         * target.c (target_announce_detach): Don't call gdb_flush.
6307         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
6308         * remote.c (extended_remote_target::attach): Don't call
6309         gdb_flush.
6310         * procfs.c (procfs_target::detach): Don't call gdb_flush.
6311         * printcmd.c (do_examine): Don't call gdb_flush.
6312         (info_display_command): Don't call gdb_flush.
6313         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
6314         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
6315         * memattr.c (info_mem_command): Don't call gdb_flush.
6316         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
6317         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
6318         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
6319         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
6320         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
6321         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
6322         (gnu_nat_target::detach): Don't call gdb_flush.
6323         * f-valprint.c (f_val_print): Don't call gdb_flush.
6324         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
6325         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
6326         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
6327         gdb_flush.
6328         * c-valprint.c (c_val_print): Don't call gdb_flush.
6329         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
6330
6331 2019-03-05  Tom Tromey  <tromey@adacore.com>
6332
6333         * varobj.c (update_dynamic_varobj_children): Update.
6334         (install_default_visualizer): Use reset, not release.
6335         * value.c (set_internalvar): Update.
6336         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
6337         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
6338         ATTRIBUTE_UNUSED_RESULT.
6339
6340 2019-03-05  Tom Tromey  <tromey@adacore.com>
6341
6342         * remote.c (class scoped_remote_fd) <release>: Add
6343         ATTRIBUTE_UNUSED_RESULT.
6344
6345 2019-03-05  Tom Tromey  <tromey@adacore.com>
6346
6347         * macroexp.c (struct macro_buffer) <release>: Add
6348         ATTRIBUTE_UNUSED_RESULT.
6349
6350 2019-03-05  Tom Tromey  <tromey@adacore.com>
6351
6352         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
6353         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
6354         ATTRIBUTE_UNUSED_RESULT.
6355
6356 2019-03-05  Tom Tromey  <tromey@adacore.com>
6357
6358         * common/scoped_fd.h (class scoped_fd) <release>: Add
6359         ATTRIBUTE_UNUSED_RESULT.
6360
6361 2019-03-05  Tom Tromey  <tromey@adacore.com>
6362
6363         * parser-defs.h (struct parser_state) <release>: Add
6364         ATTRIBUTE_UNUSED_RESULT.
6365
6366 2019-03-05  Tom Tromey  <tromey@adacore.com>
6367
6368         * utils.h (class gdb_argv) <release>: Add
6369         ATTRIBUTE_UNUSED_RESULT.
6370         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
6371
6372 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
6373
6374         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
6375         for-loop range, to avoid compiler warnings.
6376
6377         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
6378         avoid compiler warnings about unused variables.
6379
6380         * NEWS: Mention end of support for native debugging on MS-Windows
6381         before XP.
6382
6383         PR gdb/24292
6384         * common/netstuff.c:
6385         * gdbserver/gdbreplay.c
6386         * gdbserver/remote-utils.c:
6387         * ser-tcp.c:
6388         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
6389         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
6390         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
6391         'getaddrinfo' and 'freeaddrinfo' were not available before
6392         Windows XP, and mingw.org's MinGW headers by default define
6393         _WIN32_WINNT to 0x500.
6394
6395 2019-03-01  Gary Benson <gbenson@redhat.com>
6396
6397         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
6398
6399 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
6400             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
6401
6402         PR gdb/8527
6403         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
6404         set_sigint_trap, clear_sigint_trap.
6405
6406 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6407
6408         * target.c (target_detach): Clear the regcache and the
6409         frame cache.
6410
6411 2019-02-27  Pedro Alves  <palves@redhat.com>
6412
6413         * utils.c (set_screen_size): When we cap the height/width sizes,
6414         tweak the corresponding command variable to show "unlimited":
6415
6416 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
6417             Pedro Alves  <palves@redhat.com>
6418
6419         * utils.c (set_screen_size): Reduce "infinite" rows and columns
6420         before calling rl_set_screen_size.
6421
6422 2019-02-27  Tom Tromey  <tromey@adacore.com>
6423
6424         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
6425         define.
6426         * python/py-value.c: Remove Python 2.4 workaround.
6427         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
6428         workaround.
6429         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
6430         Python 2.4 workaround.
6431         * python/python-internal.h: Remove Python 2.4 comment.
6432         (Py_ssize_t): Don't define.
6433         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
6434         (gdb_Py_DECREF): Remove Python 2.4 workaround.
6435         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
6436         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
6437         * python/python.c (do_start_initialization): Remove Python 2.4
6438         workaround.
6439         * python/py-prettyprint.c (class dummy_python_frame): Remove.
6440         (print_children): Remove Python 2.4 workaround.
6441         * python/py-inferior.c (buffer_procs): Remove Python 2.4
6442         workaround.
6443         (CHARBUFFERPROC_NAME): Remove.
6444         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
6445         Python 2.4 workaround.
6446
6447 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6448
6449         * NEWS: Note minimum Python version.
6450
6451 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6452
6453         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
6454         code from these functions.  Remove corresponding ifdefs.  Use
6455         Py_buffer_up instead of explicit calls to PyBuffer_Release.
6456         Remove gotos and target of gotos.
6457         (infpy_search_memory): Likewise.
6458
6459 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6460
6461         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
6462         (hppa_gdbarch_init): Don't register deleted functions with
6463         gdbarch.
6464
6465 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6466
6467         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
6468         (h8300_unwind_sp): Delete.
6469         (h8300_dummy_id): Delete.
6470         (h8300_gdbarch_init): Don't register deleted functions with
6471         gdbarch.
6472
6473 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6474
6475         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
6476         (ft32_unwind_pc): Delete.
6477         (ft32_unwind_sp): Delete.
6478         (ft32_gdbarch_init): Don't register deleted functions with
6479         gdbarch.
6480
6481 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6482
6483         * gdb/frv-tdep.c (frv_dummy_id): Delete.
6484         (frv_unwind_pc): Delete.
6485         (frv_unwind_sp): Delete.
6486         (frv_gdbarch_init): Don't register deleted functions with
6487         gdbarch.
6488
6489 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6490
6491         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
6492         (riscv_unwind_pc): Delete.
6493         (riscv_unwind_sp): Delete.
6494         (riscv_gdbarch_init): Don't register deleted functions with
6495         gdbarch.
6496
6497 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6498
6499         * gdb/csky-tdep.c (csky_dummy_id): Delete.
6500         (csky_unwind_pc): Delete.
6501         (csky_unwind_sp): Delete.
6502         (csky_gdbarch_init): Don't register deleted functions with
6503         gdbarch.
6504
6505 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6506
6507         * gdb/cris-tdep.c (cris_dummy_id): Delete.
6508         (cris_unwind_pc): Delete.
6509         (cris_unwind_sp): Delete.
6510         (cris_gdbarch_init): Don't register deleted functions with
6511         gdbarch.
6512
6513 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6514
6515         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
6516         (bfin_unwind_pc): Delete.
6517         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
6518
6519 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6520
6521         * gdb/arm-tdep.c (arm_dummy_id): Delete.
6522         (arm_unwind_pc): Delete.
6523         (arm_unwind_sp): Delete.
6524         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
6525
6526 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6527
6528         * gdb/arc-tdep.c (arc_dummy_id): Delete.
6529         (arc_unwind_pc): Delete.
6530         (arc_unwind_sp): Delete.
6531         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
6532
6533 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6534
6535         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
6536         (alpha_unwind_pc): Delete.
6537         (alpha_gdbarch_init): Don't register deleted functions with
6538         gdbarch.
6539
6540 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6541
6542         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
6543         (aarch64_unwind_pc): Delete.
6544         (aarch64_unwind_sp): Delete.
6545         (aarch64_gdbarch_init): Don't register deleted functions with
6546         gdbarch.
6547
6548 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6549
6550         * gdbtypes.c (type_align): Don't consider static members when
6551         computing structure alignment.
6552
6553 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6554
6555         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
6556         return 0 for other types.
6557         * arch-utils.c (default_type_align): Always return 0.
6558         * gdbarch.h: Regenerate.
6559         * gdbarch.sh (type_align): Extend comment.
6560         * gdbtypes.c (type_align): Add additional comments, always call
6561         gdbarch_type_align before applying the default rules.
6562         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
6563         generic code will then apply a suitable default.
6564         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
6565         types, return 0 for other types.
6566
6567 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6568
6569         * NEWS: Create a new section for the next release branch.
6570         Rename the section of the current branch, now that it has
6571         been cut.
6572
6573 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6574
6575         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
6576         * version.in: Bump version to 8.3.50.DATE-git.
6577
6578 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
6579
6580         * aix-thread.c (ptid_cmp): Remove unused variable.
6581         (get_signaled_thread): Likewise.
6582         (store_regs_user_thread): Likewise.
6583         (store_regs_kernel_thread): Likewise.
6584         (fetch_regs_kernel_thread): Remove shadowed variable.
6585
6586 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6587
6588         * features/riscv/32bit-cpu.xml: Add register numbers.
6589         * features/riscv/32bit-fpu.c: Regenerate.
6590         * features/riscv/32bit-fpu.xml: Add register numbers.
6591         * features/riscv/64bit-cpu.xml: Add register numbers.
6592         * features/riscv/64bit-fpu.c: Regenerate.
6593         * features/riscv/64bit-fpu.xml: Add register numbers.
6594
6595 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
6596
6597         * NEWS: Mention two argument form of gdb.Value constructor.
6598         * python/py-value.c (convert_buffer_and_type_to_value): New
6599         function.
6600         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
6601         Add support for handling an optional second argument.  Call
6602         convert_buffer_and_type_to_value as appropriate.
6603         * python/python-internal.h (Py_buffer_deleter): New struct.
6604         (Py_buffer_up): New typedef.
6605
6606 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
6607
6608         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
6609         instead of releasing ownership.
6610
6611 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
6612
6613         * dwarf2read.c (open_and_init_dwp_file): Call
6614         elf_numsections instead of bfd_count_sections to initialize
6615         dwp_file->num_sections.
6616
6617 2019-02-25  Tom Tromey  <tromey@adacore.com>
6618
6619         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
6620
6621 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
6622
6623         * gcore.in: Add '--readnever' option when invoking GDB.
6624
6625 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6626
6627         * MAINTAINERS: Update my email address.
6628
6629 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6630
6631         * build-id.c (build_id_to_debug_bfd_1): New function.
6632         (build_id_to_debug_bfd): Look for separate debug file in
6633         sysroot.
6634
6635 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6636
6637         * gdbarch.sh: Update the copyright year range that is placed into
6638         generated files.
6639
6640 2019-02-22  Keith Seitz  <keiths@redhat.com>
6641
6642         PR symtab/23853
6643         * linespec.c (create_sals_line_offset): Search for the default
6644         symtab's filename instead of its fullname.
6645
6646 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6647
6648         * NEWS: Update style defaults.
6649
6650 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6651
6652         * main.c (captured_main_1): Disable styling in batch mode.
6653
6654 2019-02-20  Tom Tromey  <tom@tromey.com>
6655
6656         * symtab.c (symtab_symbol_info): Fix typos.
6657
6658 2019-02-20  Tom Tromey  <tromey@adacore.com>
6659
6660         * findcmd.c (_initialize_mem_search): Use upper case for
6661         metasyntactic variables.
6662
6663 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
6664
6665         * aarch64-tdep.c (aarch64_add_reggroups): New function.
6666         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
6667
6668 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
6669
6670         * top.h (source_file_name): Change to std::string.
6671         * top.c (source_file_name): Likewise.
6672         (command_line_input): Adjust.
6673         * cli/cli-script.c (script_from_file): Adjust.
6674
6675 2019-02-19  Tom Tromey  <tromey@adacore.com>
6676
6677         * ravenscar-thread.c
6678         (ravenscar_thread_target::update_thread_list): Don't call
6679         ada_build_task_list.
6680         * ada-lang.h (ada_build_task_list): Don't declare.
6681         * ada-tasks.c (struct ada_tasks_inferior_data)
6682         <task_list_valid_p>: Now bool.
6683         (read_known_tasks, ada_task_list_changed)
6684         (ada_tasks_invalidate_inferior_data): Update.
6685         (read_known_tasks_array): Return bool.
6686         (read_known_tasks_list): Likewise.
6687         (read_known_tasks): Return void.
6688         (ada_build_task_list): Now static.
6689
6690 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6691
6692         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
6693         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
6694
6695 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6696
6697         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
6698         variant for ada_tasks_pspace_data_handle and
6699         ada_tasks_inferior_data_handle.
6700         (ada_tasks_pspace_data_cleanup): New function.
6701         (ada_tasks_inferior_data_cleanup): New function.
6702
6703 2019-02-17  Tom Tromey  <tom@tromey.com>
6704
6705         * macrotab.h (macro_source_fullname): Return a std::string.
6706         * macrotab.c (macro_include, check_for_redefinition)
6707         (macro_undef, macro_lookup_definition, foreach_macro)
6708         (foreach_macro_in_scope): Update.
6709         (macro_source_fullname): Return a std::string.
6710         * macrocmd.c (show_pp_source_pos): Update.
6711
6712 2019-02-17  Tom Tromey  <tom@tromey.com>
6713
6714         * macrocmd.c (show_pp_source_pos): Style the file names.
6715
6716 2019-02-17  Tom Tromey  <tom@tromey.com>
6717
6718         PR tui/24197:
6719         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
6720
6721 2019-02-17  Tom Tromey  <tom@tromey.com>
6722
6723         * ada-lang.c (user_select_syms): Use filtered printing.
6724         * utils.c (wrap_style): New global.
6725         (desired_style): Remove.
6726         (emit_style_escape): Add stream parameter.
6727         (set_output_style, reset_terminal_style, prompt_for_continue):
6728         Update.
6729         (flush_wrap_buffer): Only flush gdb_stdout.
6730         (wrap_here): Set wrap_style.
6731         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
6732         treat escape sequences as a character.  Change when wrap buffer is
6733         flushed.
6734         (fputs_styled): Do not set the output style when the default is
6735         requested.
6736         * ui-style.h (struct ui_file_style) <is_default>: New method.
6737         * source.c (print_source_lines_base): Emit escape sequences in one
6738         piece.
6739
6740 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6741
6742         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
6743         integers and enumeration types.
6744
6745 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6746
6747         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
6748         instead of lookup_symbol_in_language
6749         (do_exact_match): New function.
6750         (ada_get_symbol_name_matcher): Return do_exact_match when
6751         doing a verbatim match.
6752
6753 2019-02-15  Tom Tromey  <tromey@adacore.com>
6754
6755         * ravenscar-thread.c (ravenscar_thread_target::resume)
6756         (ravenscar_thread_target::wait): Special case wildcard requests.
6757
6758 2019-02-15  Tom Tromey  <tromey@adacore.com>
6759
6760         * ravenscar-thread.c (base_ptid): Remove.
6761         (struct ravenscar_thread_target) <close>: New method.
6762         <m_base_ptid>: New member.
6763         <update_inferior_ptid, active_task, task_is_currently_active,
6764         runtime_initialized>: Declare methods.
6765         <ravenscar_thread_target>: Add constructor.
6766         (ravenscar_thread_target::task_is_currently_active)
6767         (ravenscar_thread_target::update_inferior_ptid)
6768         (ravenscar_runtime_initialized): Rename.  Now methods.
6769         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
6770         (ravenscar_thread_target::update_thread_list): Update.
6771         (ravenscar_thread_target::active_task): Now method.
6772         (ravenscar_thread_target::store_registers)
6773         (ravenscar_thread_target::prepare_to_store)
6774         (ravenscar_thread_target::prepare_to_store)
6775         (ravenscar_thread_target::mourn_inferior): Update.
6776         (ravenscar_inferior_created): Use "new" to create target.
6777         (ravenscar_thread_target::get_ada_task_ptid): Update.
6778         (_initialize_ravenscar): Don't initialize base_ptid.
6779         (ravenscar_ops): Remove global.
6780
6781 2019-02-15  Tom Tromey  <tromey@adacore.com>
6782
6783         * target.h (push_target): Declare new overload.
6784         * target.c (push_target): New overload, taking an rvalue reference.
6785         * remote.c (remote_target::open_1): Use push_target overload.
6786         * corelow.c (core_target_open): Use push_target overload.
6787
6788 2019-02-15  Tom Tromey  <tromey@adacore.com>
6789
6790         * ravenscar-thread.c (is_ravenscar_task)
6791         (ravenscar_task_is_currently_active): Return bool.
6792         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
6793         (_initialize_ravenscar): Remove "(void)".
6794         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
6795         Return bool.
6796
6797 2019-02-15  Tom Tromey  <tromey@adacore.com>
6798
6799         * ravenscar-thread.c (ravenscar_runtime_initializer)
6800         (has_ravenscar_runtime, get_running_thread_id)
6801         (ravenscar_thread_target::resume): Fix indentation.
6802
6803 2019-02-15  Tom Tromey  <tromey@adacore.com>
6804
6805         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
6806         from ravenscar_arch_ops.
6807         (sparc_ravenscar_ops::fetch_registers)
6808         (sparc_ravenscar_ops::store_registers): Now methods.
6809         (sparc_ravenscar_prepare_to_store): Remove.
6810         (sparc_ravenscar_ops): Redefine.
6811         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
6812         methods and destructor.  Remove members.
6813         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
6814         (ravenscar_thread_target::store_registers)
6815         (ravenscar_thread_target::prepare_to_store): Update.
6816         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
6817         Remove.
6818         (struct ppc_ravenscar_powerpc_ops): Derive from
6819         ravenscar_arch_ops.
6820         (ppc_ravenscar_powerpc_ops::fetch_registers)
6821         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
6822         (ppc_ravenscar_powerpc_ops): Redefine.
6823         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
6824         (ppc_ravenscar_e500_ops::fetch_registers)
6825         (ppc_ravenscar_e500_ops::store_registers): Now methods.
6826         (ppc_ravenscar_e500_ops): Redefine.
6827         * aarch64-ravenscar-thread.c
6828         (aarch64_ravenscar_generic_prepare_to_store): Remove.
6829         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
6830         (aarch64_ravenscar_fetch_registers)
6831         (aarch64_ravenscar_store_registers): Now methods.
6832         (aarch64_ravenscar_ops): Redefine.
6833
6834 2019-02-15  Tom Tromey  <tromey@adacore.com>
6835
6836         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
6837         (ravenscar_thread_target::stopped_by_hw_breakpoint)
6838         (ravenscar_thread_target::stopped_by_watchpoint)
6839         (ravenscar_thread_target::stopped_data_address)
6840         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
6841
6842 2019-02-15  Tom Tromey  <tromey@adacore.com>
6843
6844         * ravenscar-thread.c: Fix some typos.
6845
6846 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6847             Tom Tromey  <tromey@adacore.com>
6848
6849         * ada-lang.c (ada_exception_sal): Change addr_string to a
6850         std::string.
6851         (create_ada_exception_catchpoint): Update.
6852
6853 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6854             Tom Tromey  <tromey@adacore.com>
6855
6856         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
6857         (bp_location_ops): Remove.
6858         (base_breakpoint_allocate_location): Update.
6859         (free_bp_location): Update.
6860         * ada-lang.c (class ada_catchpoint_location)
6861         <ada_catchpoint_location>: Remove ops parameter.
6862         (ada_catchpoint_location_dtor): Remove.
6863         (ada_catchpoint_location_ops): Remove.
6864         (allocate_location_exception): Update.
6865         * breakpoint.h (struct bp_location_ops): Remove.
6866         (class bp_location) <bp_location>: Remove bp_location_ops
6867         parameter.
6868         <~bp_location>: Add destructor.
6869         <ops>: Remove.
6870
6871 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6872             Pedro Alves  <palves@redhat.com>
6873
6874         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
6875         'PATH_MAX'.
6876
6877 2019-02-14  David Michael  <fedora.dm0@gmail.com>
6878             Samuel Thibault  <samuel.thibault@gnu.org>
6879             Thomas Schwinge  <thomas@codesourcery.com>
6880
6881         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
6882         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
6883
6884 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6885
6886         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
6887         (check_empty): Use "const char *".
6888
6889         * gnu-nat.c (gnu_nat_target::detach): Instead of
6890         'detach_inferior (pid)' call
6891         'detach_inferior (find_inferior_pid (pid))'.
6892
6893         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
6894         'nat/fork-inferior.o'.
6895         * gnu-nat.c: #include "nat/fork-inferior.h".
6896
6897         * gnu-nat.c (gnu_nat_target::detach): Instead of
6898         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
6899         * gnu-nat.h: #include "inf-child.h".
6900         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
6901         'i386_gnu_nat_target::fetch_registers'.
6902         (gnu_store_registers): Rename/move to
6903         'i386_gnu_nat_target::store_registers'.
6904
6905         * config/i386/nm-i386gnu.h: Don't "#include" any files.
6906         * gnu-nat.h (mach_thread_info): New function.
6907         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
6908
6909         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
6910
6911 2019-02-14  Frederic Konrad  <konrad@adacore.com>
6912
6913         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
6914
6915 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
6916
6917         * windows-nat.c (windows_add_thread): Add new parameter
6918         "main_thread_p" with default value set to false.  Update
6919         function documentation as well as all callers.
6920         (windows_delete_thread): Likewise.
6921         (fake_create_process): Update call to windows_add_thread.
6922         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
6923         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
6924         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
6925         call to windows_delete_thread.
6926
6927 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
6928
6929         * MAINTAINERS: Add Andrew Burgess as global maintainer.
6930
6931 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6932
6933         * symfile.c (find_separate_debug_file): Use canonical path of
6934         sysroot with child_path instead of gdb_sysroot if it is valid.
6935
6936 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6937
6938         * symfile.c (find_separate_debug_file): Use child_path to
6939         determine if an object file is under a sysroot.
6940
6941 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6942
6943         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6944         unittests/child-path-selftests.c.
6945         * common/pathstuff.c (child_path): New function.
6946         * common/pathstuff.h (child_path): New prototype.
6947         * unittests/child-path-selftests.c: New file.
6948
6949 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6950
6951         * symfile.c (find_separate_debug_file): Look for separate debug
6952         files in debug directories under the sysroot.
6953
6954 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6955
6956         * symtab.h (struct minimal_symbol data_p): New const method.
6957         (struct minimal_symbol text_p): Likewise.
6958         * symtab.c (output_source_filename): Use file name style
6959         to print file name.
6960         (print_symbol_info): Likewise.
6961         (print_msymbol_info): Use address style to print addresses.
6962         Use function name style to print executable text symbols.
6963         (expand_symtab_containing_pc): Use data_p.
6964         (find_pc_sect_compunit_symtab): Likewise.
6965
6966 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6967
6968         * breakpoint.c (describe_other_breakpoints): Use address style
6969         to print addresses.
6970         (say_where): Likewise.
6971
6972 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6973
6974         * ada-typeprint.c (print_func_type): Print function name
6975         style to print function name.
6976         * c-typeprint.c (c_print_type_1): Likewise.
6977
6978 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
6979
6980         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
6981         for execve.
6982
6983 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6984
6985         * c-exp.y (direct_abs_decl): Use emplace_back to record the
6986         type_stack.
6987
6988 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
6989
6990         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
6991         TYPE_CODE_REF types.
6992
6993 2019-02-08  Jim Wilson  <jimw@sifive.com>
6994
6995         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
6996         (riscv_linux_fregset): New.
6997         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
6998
6999 2019-02-07  Tom Tromey  <tom@tromey.com>
7000
7001         * thread.c (thread_cancel_execution_command): Update.
7002         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
7003         methods.
7004         (struct thread_fsm_ops): Remove.
7005         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
7006         (thread_fsm_should_stop, thread_fsm_return_value)
7007         (thread_fsm_set_finished, thread_fsm_finished_p)
7008         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
7009         Don't declare.
7010         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
7011         * infrun.c (clear_proceed_status_thread)
7012         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
7013         (print_stop_event): Update.
7014         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
7015         Add constructor.
7016         (step_command_fsm_ops): Remove.
7017         (new_step_command_fsm): Remove.
7018         (step_1): Update.
7019         (step_command_fsm::should_stop): Rename from
7020         step_command_fsm_should_stop.
7021         (step_command_fsm::clean_up): Rename from
7022         step_command_fsm_clean_up.
7023         (step_command_fsm::do_async_reply_reason): Rename from
7024         step_command_fsm_async_reply_reason.
7025         (struct until_next_fsm): Inherit from thread_fsm.  Add
7026         constructor.
7027         (until_next_fsm_ops): Remove.
7028         (new_until_next_fsm): Remove.
7029         (until_next_fsm::should_stop): Rename from
7030         until_next_fsm_should_stop.
7031         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
7032         (until_next_fsm::do_async_reply_reason): Rename from
7033         until_next_fsm_async_reply_reason.
7034         (struct finish_command_fsm): Inherit from thread_fsm.  Add
7035         constructor.  Change type of breakpoint.
7036         (finish_command_fsm_ops): Remove.
7037         (new_finish_command_fsm): Remove.
7038         (finish_command_fsm::should_stop): Rename from
7039         finish_command_fsm_should_stop.
7040         (finish_command_fsm::clean_up): Rename from
7041         finish_command_fsm_clean_up.
7042         (finish_command_fsm::return_value): Rename from
7043         finish_command_fsm_return_value.
7044         (finish_command_fsm::do_async_reply_reason): Rename from
7045         finish_command_fsm_async_reply_reason.
7046         (finish_command): Update.
7047         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
7048         Add constructor.
7049         (call_thread_fsm_ops): Remove.
7050         (call_thread_fsm::call_thread_fsm): Rename from
7051         new_call_thread_fsm.
7052         (call_thread_fsm::should_stop): Rename from
7053         call_thread_fsm_should_stop.
7054         (call_thread_fsm::should_notify_stop): Rename from
7055         call_thread_fsm_should_notify_stop.
7056         (run_inferior_call, call_function_by_hand_dummy): Update.
7057         * cli/cli-interp.c (should_print_stop_to_console): Update.
7058         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
7059         Add constructor.  Change type of location_breakpoint,
7060         caller_breakpoint.
7061         (until_break_fsm_ops): Remove.
7062         (new_until_break_fsm): Remove.
7063         (until_break_fsm::should_stop): Rename from
7064         until_break_fsm_should_stop.
7065         (until_break_fsm::clean_up): Rename from
7066         until_break_fsm_clean_up.
7067         (until_break_fsm::do_async_reply_reason): Rename from
7068         until_break_fsm_async_reply_reason.
7069         (until_break_command): Update.
7070         * thread-fsm.c: Remove.
7071         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
7072
7073 2019-02-07  Tom Tromey  <tom@tromey.com>
7074
7075         * yy-remap.h: Add include guard.
7076         * xtensa-tdep.h: Add include guard.
7077         * xcoffread.h: Rename include guard.
7078         * varobj-iter.h: Add include guard.
7079         * tui/tui.h: Rename include guard.
7080         * tui/tui-winsource.h: Rename include guard.
7081         * tui/tui-wingeneral.h: Rename include guard.
7082         * tui/tui-windata.h: Rename include guard.
7083         * tui/tui-win.h: Rename include guard.
7084         * tui/tui-stack.h: Rename include guard.
7085         * tui/tui-source.h: Rename include guard.
7086         * tui/tui-regs.h: Rename include guard.
7087         * tui/tui-out.h: Rename include guard.
7088         * tui/tui-layout.h: Rename include guard.
7089         * tui/tui-io.h: Rename include guard.
7090         * tui/tui-hooks.h: Rename include guard.
7091         * tui/tui-file.h: Rename include guard.
7092         * tui/tui-disasm.h: Rename include guard.
7093         * tui/tui-data.h: Rename include guard.
7094         * tui/tui-command.h: Rename include guard.
7095         * tic6x-tdep.h: Add include guard.
7096         * target/waitstatus.h: Rename include guard.
7097         * target/wait.h: Rename include guard.
7098         * target/target.h: Rename include guard.
7099         * target/resume.h: Rename include guard.
7100         * target-float.h: Rename include guard.
7101         * stabsread.h: Add include guard.
7102         * rs6000-tdep.h: Add include guard.
7103         * riscv-fbsd-tdep.h: Add include guard.
7104         * regformats/regdef.h: Rename include guard.
7105         * record.h: Rename include guard.
7106         * python/python.h: Rename include guard.
7107         * python/python-internal.h: Rename include guard.
7108         * python/py-stopevent.h: Rename include guard.
7109         * python/py-ref.h: Rename include guard.
7110         * python/py-record.h: Rename include guard.
7111         * python/py-record-full.h: Rename include guard.
7112         * python/py-record-btrace.h: Rename include guard.
7113         * python/py-instruction.h: Rename include guard.
7114         * python/py-events.h: Rename include guard.
7115         * python/py-event.h: Rename include guard.
7116         * procfs.h: Add include guard.
7117         * proc-utils.h: Add include guard.
7118         * p-lang.h: Add include guard.
7119         * or1k-tdep.h: Rename include guard.
7120         * observable.h: Rename include guard.
7121         * nto-tdep.h: Rename include guard.
7122         * nat/x86-linux.h: Rename include guard.
7123         * nat/x86-linux-dregs.h: Rename include guard.
7124         * nat/x86-gcc-cpuid.h: Add include guard.
7125         * nat/x86-dregs.h: Rename include guard.
7126         * nat/x86-cpuid.h: Rename include guard.
7127         * nat/ppc-linux.h: Rename include guard.
7128         * nat/mips-linux-watch.h: Rename include guard.
7129         * nat/linux-waitpid.h: Rename include guard.
7130         * nat/linux-ptrace.h: Rename include guard.
7131         * nat/linux-procfs.h: Rename include guard.
7132         * nat/linux-osdata.h: Rename include guard.
7133         * nat/linux-nat.h: Rename include guard.
7134         * nat/linux-namespaces.h: Rename include guard.
7135         * nat/linux-btrace.h: Rename include guard.
7136         * nat/glibc_thread_db.h: Rename include guard.
7137         * nat/gdb_thread_db.h: Rename include guard.
7138         * nat/gdb_ptrace.h: Rename include guard.
7139         * nat/fork-inferior.h: Rename include guard.
7140         * nat/amd64-linux-siginfo.h: Rename include guard.
7141         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7142         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7143         * nat/aarch64-linux.h: Rename include guard.
7144         * nat/aarch64-linux-hw-point.h: Rename include guard.
7145         * mn10300-tdep.h: Add include guard.
7146         * mips-linux-tdep.h: Add include guard.
7147         * mi/mi-parse.h: Rename include guard.
7148         * mi/mi-out.h: Rename include guard.
7149         * mi/mi-main.h: Rename include guard.
7150         * mi/mi-interp.h: Rename include guard.
7151         * mi/mi-getopt.h: Rename include guard.
7152         * mi/mi-console.h: Rename include guard.
7153         * mi/mi-common.h: Rename include guard.
7154         * mi/mi-cmds.h: Rename include guard.
7155         * mi/mi-cmd-break.h: Rename include guard.
7156         * m2-lang.h: Add include guard.
7157         * location.h: Rename include guard.
7158         * linux-record.h: Rename include guard.
7159         * linux-nat.h: Add include guard.
7160         * linux-fork.h: Add include guard.
7161         * i386-darwin-tdep.h: Rename include guard.
7162         * hppa-linux-offsets.h: Add include guard.
7163         * guile/guile.h: Rename include guard.
7164         * guile/guile-internal.h: Rename include guard.
7165         * gnu-nat.h: Rename include guard.
7166         * gdb-stabs.h: Rename include guard.
7167         * frv-tdep.h: Add include guard.
7168         * f-lang.h: Add include guard.
7169         * event-loop.h: Add include guard.
7170         * darwin-nat.h: Rename include guard.
7171         * cp-abi.h: Rename include guard.
7172         * config/sparc/nm-sol2.h: Rename include guard.
7173         * config/nm-nto.h: Rename include guard.
7174         * config/nm-linux.h: Add include guard.
7175         * config/i386/nm-i386gnu.h: Rename include guard.
7176         * config/djgpp/nl_types.h: Rename include guard.
7177         * config/djgpp/langinfo.h: Rename include guard.
7178         * compile/gcc-cp-plugin.h: Add include guard.
7179         * compile/gcc-c-plugin.h: Add include guard.
7180         * compile/compile.h: Rename include guard.
7181         * compile/compile-object-run.h: Rename include guard.
7182         * compile/compile-object-load.h: Rename include guard.
7183         * compile/compile-internal.h: Rename include guard.
7184         * compile/compile-cplus.h: Rename include guard.
7185         * compile/compile-c.h: Rename include guard.
7186         * common/xml-utils.h: Rename include guard.
7187         * common/x86-xstate.h: Rename include guard.
7188         * common/version.h: Rename include guard.
7189         * common/vec.h: Rename include guard.
7190         * common/tdesc.h: Rename include guard.
7191         * common/selftest.h: Rename include guard.
7192         * common/scoped_restore.h: Rename include guard.
7193         * common/scoped_mmap.h: Rename include guard.
7194         * common/scoped_fd.h: Rename include guard.
7195         * common/safe-iterator.h: Rename include guard.
7196         * common/run-time-clock.h: Rename include guard.
7197         * common/refcounted-object.h: Rename include guard.
7198         * common/queue.h: Rename include guard.
7199         * common/ptid.h: Rename include guard.
7200         * common/print-utils.h: Rename include guard.
7201         * common/preprocessor.h: Rename include guard.
7202         * common/pathstuff.h: Rename include guard.
7203         * common/observable.h: Rename include guard.
7204         * common/netstuff.h: Rename include guard.
7205         * common/job-control.h: Rename include guard.
7206         * common/host-defs.h: Rename include guard.
7207         * common/gdb_wait.h: Rename include guard.
7208         * common/gdb_vecs.h: Rename include guard.
7209         * common/gdb_unlinker.h: Rename include guard.
7210         * common/gdb_unique_ptr.h: Rename include guard.
7211         * common/gdb_tilde_expand.h: Rename include guard.
7212         * common/gdb_sys_time.h: Rename include guard.
7213         * common/gdb_string_view.h: Rename include guard.
7214         * common/gdb_splay_tree.h: Rename include guard.
7215         * common/gdb_setjmp.h: Rename include guard.
7216         * common/gdb_ref_ptr.h: Rename include guard.
7217         * common/gdb_optional.h: Rename include guard.
7218         * common/gdb_locale.h: Rename include guard.
7219         * common/gdb_assert.h: Rename include guard.
7220         * common/filtered-iterator.h: Rename include guard.
7221         * common/filestuff.h: Rename include guard.
7222         * common/fileio.h: Rename include guard.
7223         * common/environ.h: Rename include guard.
7224         * common/common-utils.h: Rename include guard.
7225         * common/common-types.h: Rename include guard.
7226         * common/common-regcache.h: Rename include guard.
7227         * common/common-inferior.h: Rename include guard.
7228         * common/common-gdbthread.h: Rename include guard.
7229         * common/common-exceptions.h: Rename include guard.
7230         * common/common-defs.h: Rename include guard.
7231         * common/common-debug.h: Rename include guard.
7232         * common/cleanups.h: Rename include guard.
7233         * common/buffer.h: Rename include guard.
7234         * common/btrace-common.h: Rename include guard.
7235         * common/break-common.h: Rename include guard.
7236         * cli/cli-utils.h: Rename include guard.
7237         * cli/cli-style.h: Rename include guard.
7238         * cli/cli-setshow.h: Rename include guard.
7239         * cli/cli-script.h: Rename include guard.
7240         * cli/cli-interp.h: Rename include guard.
7241         * cli/cli-decode.h: Rename include guard.
7242         * cli/cli-cmds.h: Rename include guard.
7243         * charset-list.h: Add include guard.
7244         * buildsym-legacy.h: Rename include guard.
7245         * bfin-tdep.h: Add include guard.
7246         * ax.h: Rename include guard.
7247         * arm-linux-tdep.h: Add include guard.
7248         * arm-fbsd-tdep.h: Add include guard.
7249         * arch/xtensa.h: Rename include guard.
7250         * arch/tic6x.h: Add include guard.
7251         * arch/i386.h: Add include guard.
7252         * arch/arm.h: Rename include guard.
7253         * arch/arm-linux.h: Rename include guard.
7254         * arch/arm-get-next-pcs.h: Rename include guard.
7255         * arch/amd64.h: Add include guard.
7256         * arch/aarch64-insn.h: Rename include guard.
7257         * arch-utils.h: Rename include guard.
7258         * annotate.h: Add include guard.
7259         * amd64-darwin-tdep.h: Rename include guard.
7260         * aarch64-linux-tdep.h: Add include guard.
7261         * aarch64-fbsd-tdep.h: Add include guard.
7262         * aarch32-linux-nat.h: Add include guard.
7263
7264 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7265
7266         * macrotab.c (macro_define_internal): New function that
7267         factorizes macro_define_object_internal and macro_define_function
7268         code.
7269         (macro_define_object_internal): Use macro_define_internal.
7270         (macro_define_function): Likewise.
7271
7272 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7273
7274         * macrocmd.c (extract_identifier): Return
7275         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
7276         callers.
7277
7278 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
7279
7280         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
7281
7282 2019-02-05  Tom Tromey  <tom@tromey.com>
7283
7284         * target.c (target_stack::unpush): Move assertion earlier.
7285
7286 2019-01-30  Tom Tromey  <tom@tromey.com>
7287
7288         PR python/23615:
7289         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
7290         (gdbpy_parse_and_eval): Likewise.
7291         * python/python-internal.h (gdbpy_allow_threads): New class.
7292
7293 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
7294
7295         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
7296         (aarch64_fbsd_fpregmap): Move earlier.
7297         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
7298         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7299         instead of individual calls to trad_frame_set_reg_addr.
7300         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
7301         earlier.
7302         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
7303         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7304         instead of individual calls to trad_frame_set_reg_addr.
7305
7306 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
7307
7308         * CONTRIBUTE: Replace contribution list with wiki link.
7309
7310 2019-01-25  Tom Tromey  <tom@tromey.com>
7311
7312         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
7313
7314 2019-01-25  Tom Tromey  <tom@tromey.com>
7315
7316         * xtensa-linux-nat.c: Fix common/ includes.
7317         * xml-support.h: Fix common/ includes.
7318         * xml-support.c: Fix common/ includes.
7319         * x86-linux-nat.c: Fix common/ includes.
7320         * windows-nat.c: Fix common/ includes.
7321         * varobj.h: Fix common/ includes.
7322         * varobj.c: Fix common/ includes.
7323         * value.c: Fix common/ includes.
7324         * valops.c: Fix common/ includes.
7325         * utils.c: Fix common/ includes.
7326         * unittests/xml-utils-selftests.c: Fix common/ includes.
7327         * unittests/utils-selftests.c: Fix common/ includes.
7328         * unittests/unpack-selftests.c: Fix common/ includes.
7329         * unittests/tracepoint-selftests.c: Fix common/ includes.
7330         * unittests/style-selftests.c: Fix common/ includes.
7331         * unittests/string_view-selftests.c: Fix common/ includes.
7332         * unittests/scoped_restore-selftests.c: Fix common/ includes.
7333         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
7334         * unittests/scoped_fd-selftests.c: Fix common/ includes.
7335         * unittests/rsp-low-selftests.c: Fix common/ includes.
7336         * unittests/parse-connection-spec-selftests.c: Fix common/
7337         includes.
7338         * unittests/optional-selftests.c: Fix common/ includes.
7339         * unittests/offset-type-selftests.c: Fix common/ includes.
7340         * unittests/observable-selftests.c: Fix common/ includes.
7341         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
7342         * unittests/memrange-selftests.c: Fix common/ includes.
7343         * unittests/memory-map-selftests.c: Fix common/ includes.
7344         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
7345         * unittests/function-view-selftests.c: Fix common/ includes.
7346         * unittests/environ-selftests.c: Fix common/ includes.
7347         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
7348         * unittests/common-utils-selftests.c: Fix common/ includes.
7349         * unittests/cli-utils-selftests.c: Fix common/ includes.
7350         * unittests/array-view-selftests.c: Fix common/ includes.
7351         * ui-file.c: Fix common/ includes.
7352         * tui/tui-io.c: Fix common/ includes.
7353         * tracepoint.h: Fix common/ includes.
7354         * tracepoint.c: Fix common/ includes.
7355         * tracefile-tfile.c: Fix common/ includes.
7356         * top.h: Fix common/ includes.
7357         * top.c: Fix common/ includes.
7358         * thread.c: Fix common/ includes.
7359         * target/waitstatus.h: Fix common/ includes.
7360         * target/waitstatus.c: Fix common/ includes.
7361         * target.h: Fix common/ includes.
7362         * target.c: Fix common/ includes.
7363         * target-memory.c: Fix common/ includes.
7364         * target-descriptions.c: Fix common/ includes.
7365         * symtab.h: Fix common/ includes.
7366         * symfile.c: Fix common/ includes.
7367         * stap-probe.c: Fix common/ includes.
7368         * spu-linux-nat.c: Fix common/ includes.
7369         * sparc-nat.c: Fix common/ includes.
7370         * source.c: Fix common/ includes.
7371         * solib.c: Fix common/ includes.
7372         * solib-target.c: Fix common/ includes.
7373         * ser-unix.c: Fix common/ includes.
7374         * ser-tcp.c: Fix common/ includes.
7375         * ser-pipe.c: Fix common/ includes.
7376         * ser-base.c: Fix common/ includes.
7377         * selftest-arch.c: Fix common/ includes.
7378         * s12z-tdep.c: Fix common/ includes.
7379         * rust-exp.y: Fix common/ includes.
7380         * rs6000-aix-tdep.c: Fix common/ includes.
7381         * riscv-tdep.c: Fix common/ includes.
7382         * remote.c: Fix common/ includes.
7383         * remote-notif.h: Fix common/ includes.
7384         * remote-fileio.h: Fix common/ includes.
7385         * remote-fileio.c: Fix common/ includes.
7386         * regcache.h: Fix common/ includes.
7387         * regcache.c: Fix common/ includes.
7388         * record-btrace.c: Fix common/ includes.
7389         * python/python.c: Fix common/ includes.
7390         * python/py-type.c: Fix common/ includes.
7391         * python/py-inferior.c: Fix common/ includes.
7392         * progspace.h: Fix common/ includes.
7393         * producer.c: Fix common/ includes.
7394         * procfs.c: Fix common/ includes.
7395         * proc-api.c: Fix common/ includes.
7396         * printcmd.c: Fix common/ includes.
7397         * ppc-linux-nat.c: Fix common/ includes.
7398         * parser-defs.h: Fix common/ includes.
7399         * osdata.c: Fix common/ includes.
7400         * obsd-nat.c: Fix common/ includes.
7401         * nat/x86-linux.c: Fix common/ includes.
7402         * nat/x86-linux-dregs.c: Fix common/ includes.
7403         * nat/x86-dregs.h: Fix common/ includes.
7404         * nat/x86-dregs.c: Fix common/ includes.
7405         * nat/ppc-linux.c: Fix common/ includes.
7406         * nat/mips-linux-watch.h: Fix common/ includes.
7407         * nat/mips-linux-watch.c: Fix common/ includes.
7408         * nat/linux-waitpid.c: Fix common/ includes.
7409         * nat/linux-ptrace.h: Fix common/ includes.
7410         * nat/linux-ptrace.c: Fix common/ includes.
7411         * nat/linux-procfs.c: Fix common/ includes.
7412         * nat/linux-personality.c: Fix common/ includes.
7413         * nat/linux-osdata.c: Fix common/ includes.
7414         * nat/linux-namespaces.c: Fix common/ includes.
7415         * nat/linux-btrace.h: Fix common/ includes.
7416         * nat/linux-btrace.c: Fix common/ includes.
7417         * nat/fork-inferior.c: Fix common/ includes.
7418         * nat/amd64-linux-siginfo.c: Fix common/ includes.
7419         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
7420         * nat/aarch64-linux.c: Fix common/ includes.
7421         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
7422         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
7423         * namespace.h: Fix common/ includes.
7424         * mips-linux-tdep.c: Fix common/ includes.
7425         * minsyms.c: Fix common/ includes.
7426         * mi/mi-parse.h: Fix common/ includes.
7427         * mi/mi-main.c: Fix common/ includes.
7428         * mi/mi-cmd-env.c: Fix common/ includes.
7429         * memrange.h: Fix common/ includes.
7430         * memattr.c: Fix common/ includes.
7431         * maint.h: Fix common/ includes.
7432         * maint.c: Fix common/ includes.
7433         * main.c: Fix common/ includes.
7434         * machoread.c: Fix common/ includes.
7435         * location.c: Fix common/ includes.
7436         * linux-thread-db.c: Fix common/ includes.
7437         * linux-nat.c: Fix common/ includes.
7438         * linux-fork.c: Fix common/ includes.
7439         * inline-frame.c: Fix common/ includes.
7440         * infrun.c: Fix common/ includes.
7441         * inflow.c: Fix common/ includes.
7442         * inferior.h: Fix common/ includes.
7443         * inferior.c: Fix common/ includes.
7444         * infcmd.c: Fix common/ includes.
7445         * inf-ptrace.c: Fix common/ includes.
7446         * inf-child.c: Fix common/ includes.
7447         * ia64-linux-nat.c: Fix common/ includes.
7448         * i387-tdep.c: Fix common/ includes.
7449         * i386-tdep.c: Fix common/ includes.
7450         * i386-linux-tdep.c: Fix common/ includes.
7451         * i386-linux-nat.c: Fix common/ includes.
7452         * i386-go32-tdep.c: Fix common/ includes.
7453         * i386-fbsd-tdep.c: Fix common/ includes.
7454         * i386-fbsd-nat.c: Fix common/ includes.
7455         * guile/scm-type.c: Fix common/ includes.
7456         * guile/guile.c: Fix common/ includes.
7457         * go32-nat.c: Fix common/ includes.
7458         * gnu-nat.c: Fix common/ includes.
7459         * gdbthread.h: Fix common/ includes.
7460         * gdbarch-selftests.c: Fix common/ includes.
7461         * gdb_usleep.c: Fix common/ includes.
7462         * gdb_select.h: Fix common/ includes.
7463         * gdb_bfd.c: Fix common/ includes.
7464         * gcore.c: Fix common/ includes.
7465         * fork-child.c: Fix common/ includes.
7466         * findvar.c: Fix common/ includes.
7467         * fbsd-nat.c: Fix common/ includes.
7468         * event-top.c: Fix common/ includes.
7469         * event-loop.c: Fix common/ includes.
7470         * dwarf2read.c: Fix common/ includes.
7471         * dwarf2loc.c: Fix common/ includes.
7472         * dwarf2-frame.c: Fix common/ includes.
7473         * dwarf-index-cache.c: Fix common/ includes.
7474         * dtrace-probe.c: Fix common/ includes.
7475         * disasm-selftests.c: Fix common/ includes.
7476         * defs.h: Fix common/ includes.
7477         * csky-tdep.c: Fix common/ includes.
7478         * cp-valprint.c: Fix common/ includes.
7479         * cp-support.h: Fix common/ includes.
7480         * cp-support.c: Fix common/ includes.
7481         * corelow.c: Fix common/ includes.
7482         * completer.h: Fix common/ includes.
7483         * completer.c: Fix common/ includes.
7484         * compile/compile.c: Fix common/ includes.
7485         * compile/compile-loc2c.c: Fix common/ includes.
7486         * compile/compile-cplus-types.c: Fix common/ includes.
7487         * compile/compile-cplus-symbols.c: Fix common/ includes.
7488         * command.h: Fix common/ includes.
7489         * cli/cli-dump.c: Fix common/ includes.
7490         * cli/cli-cmds.c: Fix common/ includes.
7491         * charset.c: Fix common/ includes.
7492         * build-id.c: Fix common/ includes.
7493         * btrace.h: Fix common/ includes.
7494         * btrace.c: Fix common/ includes.
7495         * breakpoint.h: Fix common/ includes.
7496         * breakpoint.c: Fix common/ includes.
7497         * ax.h:
7498         (enum agent_op): Fix common/ includes.
7499         * ax-general.c (struct aop_map): Fix common/ includes.
7500         * ax-gdb.c: Fix common/ includes.
7501         * auxv.c: Fix common/ includes.
7502         * auto-load.c: Fix common/ includes.
7503         * arm-tdep.c: Fix common/ includes.
7504         * arch/riscv.c: Fix common/ includes.
7505         * arch/ppc-linux-common.c: Fix common/ includes.
7506         * arch/i386.c: Fix common/ includes.
7507         * arch/arm.c: Fix common/ includes.
7508         * arch/arm-linux.c: Fix common/ includes.
7509         * arch/arm-get-next-pcs.c: Fix common/ includes.
7510         * arch/amd64.c: Fix common/ includes.
7511         * arch/aarch64.c: Fix common/ includes.
7512         * arch/aarch64-insn.c: Fix common/ includes.
7513         * arch-utils.c: Fix common/ includes.
7514         * amd64-windows-tdep.c: Fix common/ includes.
7515         * amd64-tdep.c: Fix common/ includes.
7516         * amd64-sol2-tdep.c: Fix common/ includes.
7517         * amd64-obsd-tdep.c: Fix common/ includes.
7518         * amd64-nbsd-tdep.c: Fix common/ includes.
7519         * amd64-linux-tdep.c: Fix common/ includes.
7520         * amd64-linux-nat.c: Fix common/ includes.
7521         * amd64-fbsd-tdep.c: Fix common/ includes.
7522         * amd64-fbsd-nat.c: Fix common/ includes.
7523         * amd64-dicos-tdep.c: Fix common/ includes.
7524         * amd64-darwin-tdep.c: Fix common/ includes.
7525         * agent.c: Fix common/ includes.
7526         * ada-lang.h: Fix common/ includes.
7527         * ada-lang.c: Fix common/ includes.
7528         * aarch64-tdep.c: Fix common/ includes.
7529
7530 2019-01-25  Tom Tromey  <tom@tromey.com>
7531
7532         * common/create-version.sh: Use common/version.h.
7533
7534 2019-01-24  Pedro Alves  <palves@redhat.com>
7535
7536         * infrun.c (signal_stop, signal_print, signal_program)
7537         (signal_catch, signal_pass): Now arrays instead of pointers.
7538         (update_signals_program_target, do_target_resume)
7539         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
7540         * linux-nat.c (linux_nat_target::pass_signals)
7541         (linux_nat_target::create_inferior, linux_nat_target::attach):
7542         Adjust.
7543         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
7544         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
7545         * procfs.c (procfs_target::pass_signals): Adjust.
7546         * record-full.c (record_full_target::resume): Adjust.
7547         * remote.c (remote_target::pass_signals)
7548         (remote_target::program_signals): Adjust.
7549         * target-debug.h (target_debug_print_signals): Now takes a
7550         gdb::array_view as parameter.  Adjust.
7551         * target.h (target_ops) <pass_signals, program_signals>: Replace
7552         pointer and length parameters with gdb::array_view.
7553         (target_pass_signals, target_program_signals): Likewise.
7554         * target-delegates.c: Regenerate.
7555
7556 2019-01-24  Pedro Alves  <palves@redhat.com>
7557
7558         * common/forward-scope-exit.h
7559         (forward_scope_exit::forward_scope_exit): Pass arguments to
7560         m_bind_function directly, instead of creating a std::bind and
7561         copying that.
7562
7563 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
7564
7565         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7566         for static members.
7567         (pass_in_v_vfp_candidate): Likewise.
7568
7569 2019-01-23  Tom Tromey  <tom@tromey.com>
7570             Pedro Alves  <palves@redhat.com>
7571
7572         * regcache.c (class regcache_invalidator): Remove.
7573         (regcache::raw_write): Use make_scope_exit.
7574
7575 2019-01-23  Tom Tromey  <tom@tromey.com>
7576
7577         * ui-out.h (class ui_out_emit_type): Update comment.
7578
7579 2019-01-23  Tom Tromey  <tom@tromey.com>
7580
7581         * infrun.c (fetch_inferior_event): Update comment.
7582
7583 2019-01-23  Tom Tromey  <tom@tromey.com>
7584             Pedro Alves  <palves@redhat.com>
7585
7586         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
7587         parameter.
7588         (fetch_inferior_event): Use SCOPE_EXIT.
7589
7590
7591 2019-01-23  Tom Tromey  <tom@tromey.com>
7592             Pedro Alves  <palves@redhat.com>
7593
7594         * infrun.c (disable_thread_events): Delete.
7595         (stop_all_threads): Use SCOPE_EXIT.
7596
7597 2019-01-23  Tom Tromey  <tom@tromey.com>
7598             Pedro Alves  <palves@redhat.com>
7599
7600         * symfile.c: Include forward-scope-exit.h.
7601         (clear_symtab_users_cleanup): Replace forward declaration with
7602         a FORWARD_SCOPE_EXIT.
7603         (syms_from_objfile_1): Use the forward_scope_exit and
7604         gdb::optional instead of cleanup_function.
7605         (reread_symbols): Use the forward_scope_exit instead of
7606         cleanup_function.
7607         (clear_symtab_users_cleanup): Remove function.
7608
7609 2019-01-23  Tom Tromey  <tom@tromey.com>
7610             Pedro Alves  <palves@redhat.com>
7611
7612         * linux-nat.c: Include scope-exit.h.
7613         (cleanup_target_stop): Remove.
7614         (linux_nat_target::static_tracepoint_markers_by_strid): Use
7615         SCOPE_EXIT.
7616
7617 2019-01-23  Tom Tromey  <tom@tromey.com>
7618             Pedro Alves  <palves@redhat.com>
7619
7620         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
7621         (call_function_by_hand_dummy): Use SCOPE_EXIT.
7622
7623 2019-01-23  Tom Tromey  <tom@tromey.com>
7624             Andrew Burgess  <andrew.burgess@embecosm.com>
7625             Pedro Alves  <palves@redhat.com>
7626
7627         * infrun.c (fetch_inferior_event): Use scope_exit.
7628         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
7629         * top.c (execute_command): Use scope_exit.
7630         * breakpoint.c (bpstat_do_actions): Use scope_exit.
7631         * utils.c (do_bpstat_clear_actions_cleanup)
7632         (make_bpstat_clear_actions_cleanup): Remove.
7633
7634 2019-01-23  Tom Tromey  <tom@tromey.com>
7635             Pedro Alves  <palves@redhat.com>
7636
7637         * infrun.c: Include "common/scope-exit.h"
7638         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
7639         (wait_for_inferior): Use SCOPE_EXIT.
7640         (fetch_inferior_event): Use scope_exit.
7641
7642 2019-01-23  Tom Tromey  <tom@tromey.com>
7643             Pedro Alves  <palves@redhat.com>
7644
7645         * breakpoint.c (create_breakpoint): Remove cleanup.
7646
7647 2019-01-23  Tom Tromey  <tom@tromey.com>
7648             Andrew Burgess  <andrew.burgess@embecosm.com>
7649             Pedro Alves  <palves@redhat.com>
7650
7651 2019-01-23  Pedro Alves  <palves@redhat.com>
7652
7653         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
7654
7655 2019-01-23  Pedro Alves  <palves@redhat.com>
7656             Andrew Burgess  <andrew.burgess@embecosm.com>
7657
7658         * gdbthread.h: Include "common/forward-scope-exit.h".
7659         (scoped_finish_thread_state): Redefine custom class in terms of
7660         forward_scope_exit.
7661
7662 2019-01-23  Pedro Alves  <palves@redhat.com>
7663             Andrew Burgess  <andrew.burgess@embecosm.com>
7664
7665         * common/forward-scope-exit.h: New file.
7666
7667 2019-01-23  Pedro Alves  <palves@redhat.com>
7668             Andrew Burgess  <andrew.burgess@embecosm.com>
7669             Tom Tromey  <tom@tromey.com>
7670
7671         * common/scope-exit.h: New file.
7672
7673 2019-01-23  Pedro Alves  <palves@redhat.com>
7674
7675         * common/preprocessor.h (ESC): Rename to ...
7676         (ESC_PARENS): ... this.
7677         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
7678         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
7679
7680 2019-01-23  Tom Tromey  <tom@tromey.com>
7681
7682         * language.h (class scoped_switch_to_sym_language_if_auto):
7683         Initialize m_lang in both cases.
7684
7685 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
7686
7687         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
7688         with XCNEW.
7689
7690 2019-01-22  Tom Tromey  <tom@tromey.com>
7691
7692         * corelow.c: Do not include sys/file.h.
7693
7694 2019-01-22  Tom Tromey  <tom@tromey.com>
7695
7696         * tui/tui-wingeneral.h: Include gdb_curses.h.
7697
7698 2019-01-22  Tom Tromey  <tom@tromey.com>
7699
7700         * source-cache.h (class source_cache) <get_source_lines,
7701         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
7702
7703 2019-01-22  Tom Tromey  <tom@tromey.com>
7704
7705         * remote-fileio.h (struct remote_target): Declare.
7706
7707 2019-01-22  Tom Tromey  <tom@tromey.com>
7708
7709         * python/py-arch.c: Do not include py-ref.h.
7710         * python/py-bpevent.c: Do not include py-ref.h.
7711         * python/py-cmd.c: Do not include py-ref.h.
7712         * python/py-continueevent.c: Do not include py-ref.h.
7713         * python/py-event.h: Do not include py-ref.h.
7714         * python/py-evtregistry.c: Do not include py-ref.h.
7715         * python/py-finishbreakpoint.c: Do not include py-ref.h.
7716         * python/py-frame.c: Do not include py-ref.h.
7717         * python/py-framefilter.c: Do not include py-ref.h.
7718         * python/py-function.c: Do not include py-ref.h.
7719         * python/py-infevents.c: Do not include py-ref.h.
7720         * python/py-linetable.c: Do not include py-ref.h.
7721         * python/py-objfile.c: Do not include py-ref.h.
7722         * python/py-param.c: Do not include py-ref.h.
7723         * python/py-prettyprint.c: Do not include py-ref.h.
7724         * python/py-progspace.c: Do not include py-ref.h.
7725         * python/py-symbol.c: Do not include py-ref.h.
7726         * python/py-symtab.c: Do not include py-ref.h.
7727         * python/py-type.c: Do not include py-ref.h.
7728         * python/py-unwind.c: Do not include py-ref.h.
7729         * python/py-utils.c: Do not include py-ref.h.
7730         * python/py-value.c: Do not include py-ref.h.
7731         * python/py-varobj.c: Do not include py-ref.h.
7732         * python/py-xmethods.c: Do not include py-ref.h.
7733         * python/python.c: Do not include py-ref.h.
7734         * varobj.c: Do not include py-ref.h.
7735
7736 2019-01-22  Tom Tromey  <tom@tromey.com>
7737
7738         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
7739         keyword for bcache.
7740
7741 2019-01-22  Tom Tromey  <tom@tromey.com>
7742
7743         * compile/compile-cplus-types.c: Remove a comment by #include.
7744
7745 2019-01-22  Tom Tromey  <tom@tromey.com>
7746
7747         * compile/gcc-c-plugin.h: Include compile-internal.h.
7748
7749 2019-01-22  Tom Tromey  <tom@tromey.com>
7750
7751         * stabsread.c (EXTERN): Do not define.
7752         (symnum, next_symbol_text_func, processing_gcc_compilation)
7753         (within_function, global_sym_chain, global_stabs)
7754         (previous_stab_code, this_object_header_files)
7755         (n_this_object_header_files)
7756         (n_allocated_this_object_header_files): Define.
7757         * stabsread.h (EXTERN): Never define.  Use "extern".
7758
7759 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7760
7761         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
7762         history_value.
7763
7764 2019-01-21  Tom Tromey  <tom@tromey.com>
7765
7766         * ui-out.c: Fix includes.
7767         * tui/tui-source.c: Fix includes.
7768         * target.c: Fix includes.
7769         * remote.c: Fix includes.
7770         * regcache.c: Fix includes.
7771         * python/py-block.c: Fix includes.
7772         * printcmd.c: Fix includes.
7773         * or1k-tdep.c: Fix includes.
7774         * mi/mi-main.c: Fix includes.
7775         * m32r-tdep.c: Fix includes.
7776         * csky-tdep.c: Fix includes.
7777         * compile/compile-cplus-types.c: Fix includes.
7778         * cli/cli-interp.c: Fix includes.
7779
7780 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
7781
7782         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7783         for padding.
7784
7785 2019-01-16  Tom Tromey  <tom@tromey.com>
7786
7787         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
7788         earlier.
7789         (struct objfile) <msymbols_range>: Move from top level.
7790         <msymbols>: New method.
7791         (class objfile_msymbols): Remove.
7792         * symtab.c (default_collect_symbol_completion_matches_break_on):
7793         Update.
7794         * symmisc.c (dump_msymbols): Update.
7795         * stabsread.c (scan_file_globals): Update.
7796         * objc-lang.c (info_selectors_command, info_classes_command)
7797         (find_methods): Update.
7798         * minsyms.c (find_solib_trampoline_target): Update.
7799         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
7800         * coffread.c (coff_symfile_read): Update.
7801         * ada-lang.c (ada_lookup_simple_minsym)
7802         (ada_collect_symbol_completion_matches): Update.
7803
7804 2019-01-16  Tom Tromey  <tom@tromey.com>
7805
7806         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
7807         type.  Remove no-argument constructor.
7808         <iterator::operator++>: Simplify.
7809         <begin>: Update.
7810         <end>: Use minimal_symbol_count.
7811
7812 2019-01-16  Tom Tromey  <tom@tromey.com>
7813
7814         * objfiles.h (struct objfile) <psymtabs>: New method.
7815         (class objfile_psymtabs): Remove.
7816         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
7817         typedef.
7818         <range>: New method.
7819         (require_partial_symbols): Change return type.
7820         * psymtab.c (require_partial_symbols)
7821         (psym_expand_symtabs_matching): Update.
7822         * mdebugread.c (parse_partial_symbols): Update.
7823         * dbxread.c (dbx_end_psymtab): Update.
7824
7825 2019-01-15  Tom Tromey  <tom@tromey.com>
7826
7827         * symtab.c (lookup_objfile_from_block)
7828         (lookup_symbol_in_objfile_symtabs)
7829         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
7830         (find_line_symtab, info_sources_command)
7831         (default_collect_symbol_completion_matches_break_on)
7832         (make_source_files_completion_list): Update.
7833         * symmisc.c (print_objfile_statistics, dump_objfile)
7834         (maintenance_print_symbols, maintenance_info_symtabs)
7835         (maintenance_check_symtabs, maintenance_info_line_tables):
7836         Update.
7837         * source.c (select_source_symtab)
7838         (forget_cached_source_info_for_objfile): Update.
7839         * objfiles.h (class objfile_compunits): Remove.
7840         (struct objfile) <compunits_range>: New typedef.
7841         (compunits): New method.
7842         * objfiles.c (objfile_relocate1): Update.
7843         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7844         * maint.c (count_symtabs_and_blocks): Update.
7845         * linespec.c (iterate_over_all_matching_symtabs): Update.
7846         * cp-support.c (add_symbol_overload_list_qualified): Update.
7847         * coffread.c (coff_symtab_read): Update.
7848         * ada-lang.c (add_nonlocal_symbols)
7849         (ada_collect_symbol_completion_matches)
7850         (ada_add_global_exceptions): Update.
7851
7852 2019-01-15  Tom Tromey  <tom@tromey.com>
7853
7854         * progspace.h (program_space) <objfiles_safe_range>: New
7855         typedef.
7856         <objfiles_safe>: New method.
7857         * objfiles.h (class all_objfiles_safe): Remove.
7858         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
7859         * jit.c (jit_inferior_exit_hook): Update.
7860
7861 2019-01-17  Tom Tromey  <tom@tromey.com>
7862
7863         * progspace.h (program_space) <objfiles_range>: New typedef.
7864         <objfiles>: New method.
7865         <objfiles_head>: Rename from objfiles.
7866         (object_files): Update.
7867         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
7868         * guile/scm-pretty-print.c
7869         (ppscm_find_pretty_printer_from_objfiles): Update.
7870         * guile/scm-objfile.c (gdbscm_objfiles): Update.
7871         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
7872         Update.
7873         * python/py-progspace.c (pspy_get_objfiles): Update.
7874         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7875         Update.
7876         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7877         (objfpy_lookup_objfile_by_build_id): Update.
7878         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7879         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7880         Update.
7881         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7882         (expand_symtab_containing_pc, lookup_objfile_from_block)
7883         (lookup_static_symbol, basic_lookup_transparent_type)
7884         (find_pc_sect_compunit_symtab, find_symbol_at_address)
7885         (find_line_symtab, info_sources_command)
7886         (default_collect_symbol_completion_matches_break_on)
7887         (make_source_files_completion_list, find_main_name): Update.
7888         * symmisc.c (print_symbol_bcache_statistics)
7889         (print_objfile_statistics, maintenance_print_symbols)
7890         (maintenance_print_msymbols, maintenance_print_objfiles)
7891         (maintenance_info_symtabs, maintenance_check_symtabs)
7892         (maintenance_expand_symtabs, maintenance_info_line_tables):
7893         Update.
7894         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
7895         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
7896         (map_overlay_command, unmap_overlay_command)
7897         (simple_overlay_update, expand_symtabs_matching)
7898         (map_symbol_filenames): Update.
7899         * symfile-debug.c (set_debug_symfile): Update.
7900         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
7901         Update.
7902         * source.c (select_source_symtab, forget_cached_source_info):
7903         Update.
7904         * solib.c (solib_read_symbols): Update.
7905         * solib-spu.c (append_ocl_sos): Update.
7906         * psymtab.c (maintenance_print_psymbols)
7907         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
7908         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
7909         * printcmd.c (info_symbol_command): Update.
7910         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
7911         Update.
7912         * objfiles.h (class all_objfiles): Remove.
7913         * objfiles.c (have_partial_symbols, have_full_symbols)
7914         (have_minimal_symbols, qsort_cmp, update_section_map)
7915         (shared_objfile_contains_address_p)
7916         (default_iterate_over_objfiles_in_search_order): Update.
7917         * objc-lang.c (info_selectors_command, info_classes_command)
7918         (find_methods): Update.
7919         * minsyms.c (find_solib_trampoline_target): Update.
7920         * maint.c (maintenance_info_sections)
7921         (maintenance_translate_address, count_symtabs_and_blocks):
7922         Update.
7923         * main.c (captured_main_1): Update.
7924         * linux-thread-db.c (try_thread_db_load_from_pdir)
7925         (has_libpthread): Update.
7926         * linespec.c (iterate_over_all_matching_symtabs)
7927         (search_minsyms_for_name): Update.
7928         * jit.c (jit_find_objf_with_entry_addr): Update.
7929         * hppa-tdep.c (find_unwind_entry)
7930         (hppa_lookup_stub_minimal_symbol): Update.
7931         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
7932         Update.
7933         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7934         (elf_gnu_ifunc_resolve_by_got): Update.
7935         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
7936         * dwarf-index-write.c (save_gdb_index_command): Update.
7937         * cp-support.c (add_symbol_overload_list_qualified): Update.
7938         * breakpoint.c (create_overlay_event_breakpoint)
7939         (create_longjmp_master_breakpoint)
7940         (create_std_terminate_master_breakpoint)
7941         (create_exception_master_breakpoint): Update.
7942         * blockframe.c (find_pc_partial_function): Update.
7943         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
7944         (ada_collect_symbol_completion_matches)
7945         (ada_add_global_exceptions): Update.
7946
7947 2019-01-17  Tom Tromey  <tom@tromey.com>
7948
7949         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
7950         declare VEC.
7951         (solib_target_parse_libraries): Change return type.
7952         (library_list_start_segment, library_list_start_section)
7953         (library_list_end_library, library_list_start_library); Update.
7954         (solib_target_free_library_list): Remove.
7955         (solib_target_parse_libraries): Remove cleanup.  Change return
7956         type.
7957         (solib_target_current_sos): Update.
7958
7959 2019-01-17  Tom Tromey  <tromey@bapiya>
7960
7961         * valprint.c: Replace "the the" with "the".
7962         * symtab.c: Replace "the the" with "the".
7963         * solib.c: Replace "the the" with "the".
7964         * solib-dsbt.c: Replace "the the" with "the".
7965         * linespec.c: Replace "the the" with "the".
7966         * dwarf2loc.h: Replace "the the" with "the".
7967         * amd64-windows-tdep.c: Replace "the the" with "the".
7968         * aarch64-tdep.c: Replace "the the" with "the".
7969
7970 2019-01-16  Keith Seitz  <keiths@redhat.com>
7971
7972         PR gdb/23773
7973         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
7974         <builder>: Rename to ..
7975         <m_builder>: ... this and make private.
7976         (dwarf2_cu::get_builder): New method.  Change all users of
7977         `builder' to use this method.
7978         (dwarf2_start_symtab): Move to ...
7979         (dwarf2_cu::start_symtab): ... here.  Update all callers
7980         (setup_type_unit_groups): Move to ...
7981         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
7982         callers.
7983         (dwarf2_cu::reset_builder): New method.
7984         (process_full_compunit, process_full_type_unit): Use
7985         dwarf2_cu::reset_builder.
7986         (follow_die_offset): Record the ancestor CU if it is different
7987         from the followed DIE's CU.
7988         (follow_die_sig_1): Likewise.
7989
7990 2019-01-15  Tom Tromey  <tom@tromey.com>
7991
7992         * remote.c (class remote_state) <buf>: Now a char_vector.
7993         <buf_size>: Remove.
7994         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
7995         parameter.
7996         (remote_target::getpkt_or_notif_sane_1)
7997         (remote_target::getpkt_sane)
7998         (remote_target::getpkt_or_notif_sane): Likewise.
7999         (class remote_target) <putpkt>: New overload.
8000         (remote_target::read_frame): Change type of "buf_p".  Remove
8001         sizeof_p parameter.
8002         (packet_ok): New overload.
8003         (packet_check_result): New overload.
8004         Update all uses.
8005
8006 2019-01-14  Tom Tromey  <tom@tromey.com>
8007
8008         * remote-notif.c (handle_notification, remote_notif_ack)
8009         (remote_notif_parse): Make "buf" const.
8010         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
8011         const.
8012         (remote_notif_parse, remote_notif_ack, handle_notification):
8013         Likewise.
8014         * remote.c (remote_notif_stop_parse): Make "buf" const.
8015         (remote_target::remote_parse_stop_reply): Make "buf" const.
8016         (remote_notif_stop_ack): Make "buf" const.
8017
8018 2019-01-14  Tom Tromey  <tom@tromey.com>
8019
8020         * remote.c (remote_console_output): Make parameter const.
8021
8022 2019-01-14  Tom Tromey  <tom@tromey.com>
8023
8024         * target-debug.h (target_debug_print_signals): Constify.
8025         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
8026         * procfs.c (procfs_target::pass_signals): Update.
8027         * linux-nat.c (linux_nat_target::pass_signals): Update.
8028         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
8029         * target-delegates.c: Rebuild.
8030         * remote.c (remote_target::program_signals): Update.
8031         (remote_target::pass_signals): Update.
8032         * target.c (target_pass_signals): Constify argument.
8033         (target_program_signals): Likewise.
8034         * target.h (struct target_ops) <pass_signals, program_signals>:
8035         Constify argument.
8036         (target_pass_signals, target_program_signals): Constify argument.
8037
8038 2019-01-14  Tom Tromey  <tom@tromey.com>
8039
8040         PR tui/28819:
8041         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
8042
8043 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
8044
8045         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
8046         field.
8047         * rs6000-tdep.c: Include reggroups.h.
8048         (IS_V_ALIAS_PSEUDOREG): Define.
8049         (rs6000_register_name): Return names for the "vX" aliases.
8050         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
8051         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
8052         aliases.  Call default_register_reggroup_p for all other
8053         pseudo-registers.
8054         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
8055         New functions.
8056         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
8057         Handle "vX" aliases.
8058         (v_alias_pseudo_register_collect): New function.
8059         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
8060         (rs6000_gdbarch_init): Initialize "vX" aliases as
8061         pseudo-registers.  Restore registration of
8062         rs6000_pseudo_register_reggroup_p with
8063         set_tdesc_pseudo_register_reggroup_p.
8064
8065 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
8066
8067         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
8068         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
8069         set_gdbarch_num_pseudo_regs.
8070
8071 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8072
8073         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
8074         Remove arg prefixname, add do_set and do_show.
8075         Add member functions set_list and show_list.
8076         * cli/cli-style.c (class cli_style_option): Update accordingly.
8077         (style_set_list): Move to file scope.
8078         (style_show_list): Likewise.
8079         (set_style): Call help_list.
8080         (show_style): Call cmd_show_list.
8081         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
8082         Update to use the new macro.
8083
8084 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
8085
8086         * ada-lang.c (_initialize_ada_language): Expand the help text
8087         for the "catch exception" command.
8088
8089 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8090
8091         * symtab.c (matching_obj_sections): Initialize obj,
8092         declare it closer to its usage.
8093
8094 2019-01-10  Tom Tromey  <tom@tromey.com>
8095
8096         * thread-iter.h (inf_threads_iterator): Use next_iterator.
8097         (basic_inf_threads_range): Remove.
8098         (inf_threads_range, inf_non_exited_threads_range)
8099         (safe_inf_threads_range): Use next_adapter.
8100
8101 2019-01-10  Keith Seitz  <keiths@redhat.com>
8102
8103         PR gdb/23712
8104         PR symtab/23010
8105         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
8106         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
8107
8108 2019-01-10  Keith Seitz  <keiths@redhat.com>
8109
8110         PR gdb/23712
8111         PR symtab/23010
8112         * dictionary.c (pending_to_vector): Remove.
8113         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8114         Remove _1 suffix, replacing functions of the same name.  Update
8115         all callers.
8116         (dict_create_hashed, dict_create_hashed_expandable)
8117         (dict_create_linear, dict_create_linear_expandable, dict_free)
8118         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8119         Make functions static.
8120
8121 2019-01-10  Keith Seitz  <keiths@redhat.com>
8122
8123         PR gdb/23712
8124         PR symtab/23010
8125         * dictionary.h (struct dictionary): Replace declaration with
8126         multidictionary.
8127         (dict_create_hashed, dict_create_hashed_expandable)
8128         (dict_create_linear, dict_create_linear_expandable)
8129         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8130         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8131         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8132         taking multidictionary argument.
8133         [ALL_DICT_SYMBOLS]: Update for multidictionary.
8134         * block.h (struct block) <dict>: Change to multidictionary
8135         and rename `multidict'.
8136         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8137         symmisc.c: Update all dictionary references to multidictionary.
8138
8139 2019-01-10  Keith Seitz  <keiths@redhat.com>
8140
8141         PR gdb/23712
8142         PR symtab/23010
8143         * dictionary.c: Include unordered_map.
8144         (pending_to_vector): New function.
8145         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8146         Rewrite the non-"_1" functions to take vector instead
8147         of linked list.
8148         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8149         "new" _1 versions of the same name.
8150         (multidictionary): Define.
8151         (std::hash<enum language): New definition.
8152         (collate_pending_symbols_by_language, mdict_create_hashed)
8153         (mdict_create_hashed_expandable, mdict_create_linear)
8154         (mdict_create_linear_expandable, mdict_free)
8155         (find_language_dictionary, create_new_language_dictionary)
8156         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8157         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8158         (mdict_size, mdict_empty): New functions.
8159         * dictionary.h (mdict_iterator): Define.
8160
8161 2019-01-10  Pedro Alves  <palves@redhat.com>
8162
8163         * breakpoint.c (read_uploaded_action)
8164         (create_tracepoint_from_upload): Adjust to use
8165         gdb::unique_xmalloc_ptr.
8166         * ctf.c (ctf_write_uploaded_tp):
8167         (SET_ARRAY_FIELD): Use emplace_back.
8168         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8169         * tracefile-tfile.c (tfile_write_uploaded_tp):
8170         * tracepoint.c (parse_tracepoint_definition): Adjust to use
8171         gdb::unique_xmalloc_ptr.
8172         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8173         at_string, cond_string, cmd_strings>: Replace char pointers
8174         with gdb::unique_xmalloc_ptr.
8175
8176 2019-01-10  Pedro Alves  <palves@redhat.com>
8177
8178         * solib-target.c (library_list_start_library): Don't xstrdup name.
8179
8180 2019-01-10  Pedro Alves  <palves@redhat.com>
8181
8182         * mdebugread.c (parse_partial_symbols): Use
8183         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8184
8185 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8186
8187         * linux-fork.c (scoped_switch_fork_info)
8188         <~scoped_switch_fork_info>: Fix incorrect variable name.
8189
8190 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8191
8192         * linux-fork.c (scoped_switch_fork_info)
8193         <scoped_switch_fork_info>: Make explicit.
8194         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
8195
8196 2019-01-10  Tom Tromey  <tom@tromey.com>
8197
8198         * objfiles.h (objfile::reset_psymtabs): Update.
8199         * objfiles.c (objfile::objfile): Update.
8200         * psymtab.h (psymtab_storage::obstack): Update.
8201         (psymtab_storage::m_obstack): Use gdb::optional.
8202         (class psymtab_storage): Update comment.  Remove objfile
8203         parameter.
8204         * psymtab.c (psymtab_storage::psymtab_storage): Update.
8205
8206 2019-01-10  Tom Tromey  <tom@tromey.com>
8207
8208         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
8209         <free_psymtabs>: Now private.
8210         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
8211         (allocate_psymtab): Use new method.
8212
8213 2019-01-10  Tom Tromey  <tom@tromey.com>
8214
8215         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
8216         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
8217         * mdebugread.c (parse_partial_symbols): Use
8218         allocate_dependencies.
8219         * dwarf2read.c (dwarf2_create_include_psymtab): Use
8220         allocate_dependencies.
8221         (process_psymtab_comp_unit_reader)
8222         (build_type_psymtab_dependencies): Likewise.
8223         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
8224
8225 2019-01-10  Tom Tromey  <tom@tromey.com>
8226
8227         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
8228         PSYMBOL_SET_LANGUAGE.
8229         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
8230
8231 2019-01-10  Tom Tromey  <tom@tromey.com>
8232
8233         * psymtab.h (psymtab_storage::obstack): New method.
8234         <m_obstack>: Rename from obstack; now private.
8235         * psymtab.c (psymtab_storage): Update.
8236         * dwarf2read.c (create_addrmap_from_index)
8237         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
8238         Update.
8239
8240 2019-01-10  Tom Tromey  <tom@tromey.com>
8241
8242         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
8243         * objfiles.h (objfile::reset_psymtabs): New method.
8244
8245 2019-01-10  Tom Tromey  <tom@tromey.com>
8246
8247         * symmisc.c (print_symbol_bcache_statistics): Update.
8248         (print_objfile_statistics): Update.
8249         * symfile.c (reread_symbols): Update.
8250         * psymtab.h (class psymtab_storage): New.
8251         * psymtab.c (psymtab_storage): New constructor.
8252         (~psymtab_storage): New destructor.
8253         (require_partial_symbols): Update.
8254         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
8255         (find_pc_sect_psymtab, find_pc_sect_psymbol)
8256         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
8257         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
8258         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
8259         (start_psymtab_common, end_psymtab_common)
8260         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
8261         (allocate_psymtab): Update.
8262         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
8263         Update.
8264         (dump_psymtab_addrmap, maintenance_print_psymbols)
8265         (maintenance_check_psymtabs): Update.
8266         (class objfile_psymtabs): Move to objfiles.h.
8267         * psympriv.h (discard_psymtab): Now inline.
8268         (psymtab_discarder::psymtab_discarder): Update.
8269         (psymtab_discarder::~psymtab_discarder): Update.
8270         (ALL_OBJFILE_PSYMTABS): Rewrite.
8271         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
8272         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
8273         Remove fields.
8274         <partial_symtabs>: New field.
8275         (class objfile_psymtabs): Move from psymtab.h.  Update.
8276         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
8277         psymbol_cache.
8278         (objfile::~objfile): Don't destroy psymbol_cache.
8279         * mdebugread.c (parse_partial_symbols): Update.
8280         * dwarf2read.c (create_addrmap_from_index)
8281         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
8282         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
8283         (add_partial_subprogram, dwarf2_ranges_read): Update.
8284         * dwarf-index-write.c (write_address_map)
8285         (write_one_signatured_type, recursively_write_psymbols)
8286         (class debug_names, class debug_names, write_psymtabs_to_index):
8287         Update.
8288
8289 2019-01-10  Tom Tromey  <tom@tromey.com>
8290
8291         * symtab.h (SYMBOL_SET_NAMES): Update.
8292         (symbol_set_names): Update.
8293         (MSYMBOL_SET_NAMES): Update.
8294         * symtab.c (symbol_set_names): Change argument to be an
8295         objfile_per_bfd_storage.
8296         * psymtab.c (add_psymbol_to_bcache): Update.
8297         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
8298
8299 2019-01-10  Tom Tromey  <tom@tromey.com>
8300
8301         * symtab.c (create_demangled_names_hash): Change argument to be an
8302         objfile_per_bfd_storage.
8303         (symbol_set_names): Update.
8304
8305 2019-01-10  Tom Tromey  <tom@tromey.com>
8306
8307         * xcoffread.c (xcoff_initial_scan): Unconditionally call
8308         init_psymbol_list.
8309         * psymtab.c (init_psymbol_list): Do nothing if already called.
8310         * psympriv.h (init_psymbol_list): Add comment.
8311         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
8312         init_psymbol_list.
8313         * dbxread.c (dbx_symfile_read): Unconditionally call
8314         init_psymbol_list.
8315
8316 2019-01-10  Tom Tromey  <tom@tromey.com>
8317
8318         * xcoffread.c (scan_xcoff_symtab): Update.
8319         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
8320         "where".
8321         * mdebugread.c (parse_partial_symbols)
8322         (handle_psymbol_enumerators): Update.
8323         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
8324         * dbxread.c (read_dbx_symtab): Update.
8325         * psympriv.h (psymbol_placement): New enum.
8326         (add_psymbol_to_list): Update.
8327
8328 2019-01-10  Tom Tromey  <tom@tromey.com>
8329
8330         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
8331         static_psymbols parameters.
8332         (scan_xcoff_symtab): Update.
8333         * psymtab.c (start_psymtab_common): Remove global_psymbols and
8334         static_psymbols parameters.
8335         * psympriv.h (start_psymtab_common): Update.
8336         * mdebugread.c (parse_partial_symbols): Update.
8337         * dwarf2read.c (create_partial_symtab): Update.
8338         * dbxread.c (read_dbx_symtab): Update.
8339         (start_psymtab): Remove global_psymbols and static_psymbols
8340         parameters.
8341
8342 2019-01-10  Tom Tromey  <tom@tromey.com>
8343
8344         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
8345         * psymtab.c (allocate_psymtab): Add comment.
8346         * psympriv.h (allocate_psymtab): Add comment.
8347         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
8348         initializations.
8349         * dbxread.c (dbx_end_psymtab): Remove some initializations.
8350
8351 2019-01-10  Tom Tromey  <tom@tromey.com>
8352
8353         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8354         Don't declare.
8355         * mipsread.c: Include mdebugread.h.
8356         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8357         Declare.
8358         * elfread.c: Include mdebugread.h.
8359
8360 2019-01-09  Tom Tromey  <tom@tromey.com>
8361
8362         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
8363         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
8364         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
8365         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
8366         (psym_lookup_symbol, psym_find_last_source_symtab)
8367         (psym_forget_cached_source_info, psym_print_stats)
8368         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
8369         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
8370         (psym_map_matching_symbols, psym_expand_symtabs_matching)
8371         (psym_find_compunit_symtab_by_address)
8372         (maintenance_print_psymbols, maintenance_info_psymtabs)
8373         (maintenance_check_psymtabs): Use ranged for.
8374         * psymtab.h (class objfile_psymtabs): New.
8375         (require_partial_symbols): Return objfile_psymtabs.
8376         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
8377
8378 2019-01-09  Tom Tromey  <tom@tromey.com>
8379
8380         * symfile.c (overlay_invalidate_all, find_pc_overlay)
8381         (find_pc_mapped_section, list_overlays_command)
8382         (map_overlay_command, unmap_overlay_command)
8383         (simple_overlay_update): Use all_objfiles.
8384         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
8385         * printcmd.c (info_symbol_command): Use all_objfiles.
8386         * objfiles.h (ALL_OBJSECTIONS): Remove.
8387         * maint.c (maintenance_translate_address): Use all_objfiles.
8388         * gcore.c (gcore_create_callback): Use all_objfiles.
8389         (objfile_find_memory_regions): Likewise.
8390
8391 2019-01-09  Tom Tromey  <tom@tromey.com>
8392
8393         * symtab.c (find_line_symtab, info_sources_command)
8394         (make_source_files_completion_list): Use objfile_compunits.
8395         * source.c (select_source_symtab): Use objfile_compunits.
8396         * objfiles.h (struct objfile): Update comment.
8397         (ALL_OBJFILES): Remove.
8398         (ALL_FILETABS): Remove.
8399         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
8400         objfile_compunits.
8401
8402 2019-01-09  Tom Tromey  <tom@tromey.com>
8403
8404         * symmisc.c (print_objfile_statistics, dump_objfile)
8405         (maintenance_print_symbols): Use compunit_filetabs.
8406         * source.c (forget_cached_source_info_for_objfile): Use
8407         compunit_filetabs.
8408         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
8409         (ALL_FILETABS): Use compunit_filetabs.
8410         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
8411         * coffread.c (coff_symtab_read): Use compunit_filetabs.
8412
8413 2019-01-09  Tom Tromey  <tom@tromey.com>
8414
8415         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
8416         (compunit_filetabs): New.
8417         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
8418         compunit_filetabs.
8419         (info_sources_command, make_source_files_completion_list): Remove
8420         declaration.
8421         * symmisc.c (print_objfile_statistics, dump_objfile)
8422         (maintenance_print_symbols): Remove declaration.
8423         (maintenance_info_symtabs): Use compunit_filetabs.
8424         (maintenance_info_line_tables): Likewise.
8425         * source.c (select_source_symtab): Change local variable name.
8426         (forget_cached_source_info_for_objfile): Remove declaration.
8427         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
8428         * objfiles.c (objfile_relocate1): Remove declaration.
8429         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8430         declaration.
8431         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
8432         * coffread.c (coff_symtab_read): Remove declaration.
8433         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
8434         compunit_filetabs.
8435
8436 2019-01-09  Tom Tromey  <tom@tromey.com>
8437
8438         * symtab.c (lookup_objfile_from_block)
8439         (find_pc_sect_compunit_symtab, search_symbols)
8440         (default_collect_symbol_completion_matches_break_on): Use
8441         objfile_compunits.
8442         * objfiles.h (ALL_COMPUNITS): Remove.
8443         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
8444         * cp-support.c (add_symbol_overload_list_qualified): Use
8445         objfile_compunits.
8446         * ada-lang.c (ada_collect_symbol_completion_matches)
8447         (ada_add_global_exceptions): Use objfile_compunits.
8448
8449 2019-01-09  Tom Tromey  <tom@tromey.com>
8450
8451         * source.c (select_source_symtab)
8452         (forget_cached_source_info_for_objfile): Remove declaration.
8453         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8454         declaration.
8455         * maint.c (count_symtabs_and_blocks): Remove declaration.
8456         * cp-support.c (add_symbol_overload_list_qualified): Remove
8457         declaration.
8458         * coffread.c (coff_symtab_read): Remove declaration.
8459         * symtab.c (lookup_symbol_in_objfile_symtabs)
8460         (basic_lookup_transparent_type_1): Use objfile_compunits.
8461         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
8462         (info_sources_command, search_symbols)
8463         (default_collect_symbol_completion_matches_break_on)
8464         (make_source_files_completion_list): Remove declaration.
8465         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
8466         (ada_collect_symbol_completion_matches)
8467         (ada_add_global_exceptions): Remove declaration.
8468         * linespec.c (iterate_over_all_matching_symtabs): Use
8469         objfile_compunits.
8470         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
8471         (class objfile_compunits): New.
8472         (ALL_COMPUNITS): Use objfile_compunits.
8473         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
8474         (maintenance_check_symtabs, maintenance_info_line_tables): Use
8475         objfile_compunits.
8476         * objfiles.c (objfile_relocate1): Use objfile_compunits.
8477
8478 2019-01-09  Tom Tromey  <tom@tromey.com>
8479
8480         * symtab.c (search_symbols)
8481         (default_collect_symbol_completion_matches_break_on): Use
8482         objfile_msymbols.
8483         * ada-lang.c (ada_lookup_simple_minsym)
8484         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
8485         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
8486         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
8487         objfile_msymbols.
8488         * coffread.c (coff_symfile_read): Use objfile_msymbols.
8489         * symmisc.c (dump_msymbols): Use objfile_msymbols.
8490         * objc-lang.c (find_methods): Use objfile_msymbols.
8491         (info_selectors_command, info_classes_command): Likewise.
8492         * stabsread.c (scan_file_globals): Use objfile_msymbols.
8493         * objfiles.h (class objfile_msymbols): New.
8494         (ALL_OBJFILE_MSYMBOLS): Remove.
8495         (ALL_MSYMBOLS): Remove.
8496
8497 2019-01-09  Tom Tromey  <tom@tromey.com>
8498
8499         * common/next-iterator.h (next_adapter): Add Iterator template
8500         parameter.
8501         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
8502         (class all_objfiles_safe): New.
8503         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
8504         * objfiles.c (put_objfile_before): Update comment.
8505         (add_separate_debug_objfile): Likewise.
8506         (free_all_objfiles): Use all_objfiles_safe.
8507         (objfile_purge_solibs): Likewise.
8508
8509 2019-01-09  Tom Tromey  <tom@tromey.com>
8510
8511         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8512         (expand_symtab_containing_pc, lookup_static_symbol)
8513         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
8514         (find_symbol_at_address, find_line_symtab, find_main_name): Use
8515         all_objfiles.
8516         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
8517         * breakpoint.c (create_overlay_event_breakpoint)
8518         (create_longjmp_master_breakpoint)
8519         (create_std_terminate_master_breakpoint)
8520         (create_exception_master_breakpoint): Use all_objfiles.
8521         * linux-thread-db.c (try_thread_db_load_from_pdir)
8522         (has_libpthread): Use all_objfiles.
8523         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
8524         * linespec.c (iterate_over_all_matching_symtabs)
8525         (search_minsyms_for_name): Use all_objfiles.
8526         * maint.c (maintenance_info_sections): Use all_objfiles.
8527         * main.c (captured_main_1): Use all_objfiles.
8528         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
8529         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
8530         * guile/scm-pretty-print.c
8531         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
8532         * solib-spu.c (append_ocl_sos): Use all_objfiles.
8533         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
8534         (maintenance_print_msymbols): Use all_objfiles.
8535         * source.c (select_source_symtab): Use all_objfiles.
8536         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
8537         * symfile.c (remove_symbol_file_command)
8538         (expand_symtabs_matching, map_symbol_filenames): Use
8539         all_objfiles.
8540         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
8541         all_objfiles.
8542         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
8543         * objc-lang.c (find_methods): Use all_objfiles.
8544         * objfiles.c (have_partial_symbols, have_full_symbols)
8545         (have_minimal_symbols, qsort_cmp)
8546         (default_iterate_over_objfiles_in_search_order): Use
8547         all_objfiles.
8548         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
8549         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
8550         (maintenance_check_psymtabs): Use all_objfiles.
8551         (ALL_PSYMTABS): Remove.
8552         * compile/compile-object-run.c (do_module_cleanup): Use
8553         all_objfiles.
8554         * blockframe.c (find_pc_partial_function): Use all_objfiles.
8555         * cp-support.c (add_symbol_overload_list_qualified): Use
8556         all_objfiles.
8557         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8558         Use all_objfiles.
8559         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
8560         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
8561         all_objfiles.
8562         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8563         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
8564         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8565         Uses all_objfiles.
8566         * solib.c (solib_read_symbols): Use all_objfiles
8567
8568 2019-01-09  Tom Tromey  <tom@tromey.com>
8569
8570         * probe.c (parse_probes_in_pspace): Use all_objfiles.
8571         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
8572         all_objfiles.
8573         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
8574         * symmisc.c (print_symbol_bcache_statistics)
8575         (print_objfile_statistics, maintenance_print_objfiles)
8576         (maintenance_info_symtabs, maintenance_check_symtabs)
8577         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
8578         all_objfiles.
8579         * source.c (forget_cached_source_info): Use all_objfiles.
8580         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
8581         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8582         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
8583         * objfiles.c (update_section_map): Use all_objfiles.
8584         (shared_objfile_contains_address_p): Likewise.
8585         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
8586         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
8587
8588 2019-01-09  Tom Tromey  <tom@tromey.com>
8589
8590         * common/next-iterator.h: New file.
8591         * objfiles.h (class all_objfiles): New.
8592         (struct objfile_iterator): New.
8593
8594 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8595
8596         * NEWS: Move the description of the changed "frame", "select-frame",
8597          and "info frame" commands to the Changed commands section.
8598
8599 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
8600
8601         * gdbtypes.c (check_stub_method_group): Remove handling of old
8602         mangling schemes.
8603         * linespec.c (find_methods): Likewise.
8604         * stabsread.c (read_member_functions): Likewise.
8605         * valops.c (search_struct_method): Likewise.
8606         (value_struct_elt_for_reference): Likewise.
8607         * NEWS: Mention this change.
8608
8609 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
8610
8611         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
8612         print_source_lines.
8613         * source.c (print_source_lines_base): Update line number check.
8614         (print_source_lines): New function.
8615         (source_lines_range::source_lines_range): New function.
8616         * source.h (class source_lines_range): New class.
8617         (print_source_lines): New declaration.
8618
8619 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8620
8621         * linespec.c (linespec_state_destructor): Free self->canonical_names.
8622
8623 2019-01-08  Tom Tromey  <tom@tromey.com>
8624             Simon Marchi  <simon.marchi@ericsson.com>
8625
8626         PR gdb/24060
8627         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
8628         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
8629         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8630         * f-exp.y (DOLLAR_VARIABLE): Likewise.
8631         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
8632         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8633
8634 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8635
8636         * source.c (select_source_symtab): Move header comment to
8637         declaration in source.h.
8638         (forget_cached_source_info_for_objfile): Likewise.
8639         (forget_cached_source_info): Likewise.
8640         (identify_source_line): Likewise.
8641         * source.h (identify_source_line): Move declaration from symtab.h
8642         and add comment from source.c
8643         (print_source_lines): Likewise.
8644         (forget_cached_source_info_for_objfile): Likewise.
8645         (forget_cached_source_info): Likewise.
8646         (select_source_symtab): Likewise.
8647         (enum print_source_lines_flag): Move definition from symtab.h.
8648         * symtab.h (identify_source_line): Move declaration to source.h.
8649         (print_source_lines): Likewise.
8650         (forget_cached_source_info_for_objfile): Likewise.
8651         (forget_cached_source_info): Likewise.
8652         (select_source_symtab): Likewise.
8653         (enum print_source_lines_flag): Move definition to source.h.
8654         * tui/tui-hooks.c: Add 'source.h' include.
8655
8656 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8657
8658         * source.c (print_source_lines_base): Handle requests to print
8659         reverse line number sequences, and guard against empty lines
8660         string.
8661
8662 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8663
8664         * source.c (print_source_lines_base): Fix skip of '\r' if next
8665         character is '\n'.
8666
8667 2019-01-06  Tom Tromey  <tom@tromey.com>
8668
8669         * c-exp.y (struct c_parse_state) <macro_original_text,
8670         expansion_obstack>: New member.
8671         (macro_original_text, expansion_obstack): Remove globals.
8672         (scan_macro_expansion, scanning_macro_expansion)
8673         (finished_macro_expansion): Update.
8674         (scan_macro_cleanup): Remove.
8675         (yylex, c_parse): Update.
8676
8677 2019-01-06  Tom Tromey  <tom@tromey.com>
8678
8679         * c-exp.y (struct c_parse_state) <strings>: New member.
8680         (operator_stoken): Update.
8681
8682 2019-01-06  Tom Tromey  <tom@tromey.com>
8683
8684         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
8685         (union type_stack_elt) <typelist_val>: Now a pointer to
8686         std::vector.
8687         (type_stack_cleanup): Don't declare.
8688         (push_typelist): Update.
8689         * parse.c (pop_typelist): Return a std::vector.
8690         (push_typelist): Take a std::vector.
8691         (follow_types): Update.  Do not free args.
8692         (type_stack_cleanup): Remove.
8693         * c-exp.y (struct c_parse_state): New.
8694         (cpstate): New global.
8695         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
8696         (nonempty_typelist): Update.
8697         (func_mod): Create a new vector.
8698         (c_parse): Create a c_parse_state.
8699         (check_parameter_typelist): Do not delete params.
8700         (function_method): Update.  Do not delete type_list.
8701
8702 2019-01-06  Tom Tromey  <tom@tromey.com>
8703
8704         PR gdb/28155:
8705         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
8706         check_typedef.
8707         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
8708         (print_return_value): Likewise.
8709
8710 2019-01-05  Tom Tromey  <tom@tromey.com>
8711
8712         * contrib/cleanup_check.py: Remove.
8713         * contrib/gcc-with-excheck: Remove.
8714         * contrib/exsummary.py: Remove.
8715         * contrib/excheck.py: Remove.
8716
8717 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
8718
8719         * thread.c (delete_thread_1): Add gdb_assert that THR is not
8720         NULL. Initialize tpprev to NULL instead of assigning it
8721         to NULL on the next statement.
8722         * windows-nat.c (windows_delete_thread): Remove check for
8723         main_thread_id before printing thread exit notifications.
8724         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
8725         Remove thread ID check against main_thread_id.
8726         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
8727         windows_delete_thread.
8728         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
8729
8730 2019-01-04  Tom Tromey  <tom@tromey.com>
8731
8732         * compile/compile.c (_initialize_compile): Use upper case for
8733         metasyntactic variables.
8734         * symmisc.c (_initialize_symmisc): Use upper case for
8735         metasyntactic variables.
8736         * psymtab.c (_initialize_psymtab): Use upper case for
8737         metasyntactic variables.
8738         * demangle.c (demangle_command): Use upper case for metasyntactic
8739         variables.
8740         (_initialize_demangler): Likewise.
8741         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
8742         variables.
8743
8744 2019-01-03  Tom Tromey  <tom@tromey.com>
8745
8746         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
8747
8748 2019-01-03  Tom Tromey  <tom@tromey.com>
8749
8750         * python/py-symtab.c (salpy_str): Update.
8751         (struct salpy_sal_object) <symtab>: Now a PyObject.
8752         (salpy_dealloc): Update.
8753         (del_objfile_sal): Use gdbpy_ref.
8754
8755 2019-01-03  Tom Tromey  <tom@tromey.com>
8756
8757         * python/py-type.c (convert_field): Use new_reference.  Return
8758         gdbpy_ref.
8759         (make_fielditem): Return gdbpy_ref.
8760         (typy_fields): Update.
8761         (typy_getitem): Update.
8762         (field_name): Return gdbpy_ref.  Use new_reference.
8763         (typy_iterator_iternext): Update.
8764
8765 2019-01-03  Tom Tromey  <tom@tromey.com>
8766
8767         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
8768
8769 2019-01-03  Tom Tromey  <tom@tromey.com>
8770
8771         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
8772         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
8773         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
8774         (pspy_set_frame_filters, pspy_set_frame_unwinders)
8775         (pspy_set_type_printers): Likewise.
8776         * python/py-function.c (fnpy_init): Use gdbpy_ref.
8777         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
8778         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
8779         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
8780         (objfpy_set_type_printers): Likewise.
8781
8782 2019-01-03  Tom Tromey  <tom@tromey.com>
8783
8784         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
8785         (gdbpy_print_stack): Use gdbpy_err_fetch.
8786         * python/python-internal.h (class gdbpy_err_fetch): New class.
8787         (class gdbpy_enter) <m_error_type, m_error_value,
8788         m_error_traceback>: Remove.
8789         <m_error>: New member.
8790         (gdbpy_exception_to_string): Don't declare.
8791         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
8792         * python/py-value.c (convert_value_from_python): Use
8793         gdbpy_err_fetch.
8794         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
8795         gdbpy_exception_to_string.
8796         (gdbpy_handle_exception): Use gdbpy_err_fetch.
8797         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
8798         gdbpy_err_fetch.
8799
8800 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8801
8802         * linux-nat.c (delete_lwp_cleanup): Delete.
8803         (struct lwp_deleter): New struct.
8804         (lwp_info_up): New typedef.
8805         (linux_nat_target::follow_fork): Delete cleanup, and make use of
8806         lwp_info_up.
8807
8808 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8809
8810         * linux-fork.c (class scoped_switch_fork_info): New class.
8811         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
8812
8813 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8814
8815         * valops.c (find_overload_match): Remove use of null_cleanup, and
8816         calls to do_cleanups.
8817
8818 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8819
8820         * compile/compile-cplus-types.c
8821         (compile_cplus_instance::decl_name): Handle changes to
8822         cp_func_name.
8823         * cp-support.c (cp_func_name): Update header comment, update
8824         return type.
8825         * cp-support.h (cp_func_name): Update return type in declaration.
8826         * valops.c (find_overload_match): Move temp_func local to top
8827         level of function and change its type.  Use temp_func to hold and
8828         delete temporary string obtained from cp_func_name.
8829
8830 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8831
8832         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
8833         gdb::char_vector, remove cleanup, and update uses of `msg`.
8834
8835 2019-01-03  Jim Wilson  <jimw@sifive.com>
8836
8837         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
8838
8839 2019-01-02  Tom Tromey  <tom@tromey.com>
8840
8841         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
8842         (tdesc_parse_xml): Remove cleanups.
8843         * target-descriptions.h (make_cleanup_free_target_description):
8844         Don't declare.
8845         (target_desc_deleter): New struct.
8846         (target_desc_up): New typedef.
8847         * target-descriptions.c (target_desc_deleter::operator()): Rename
8848         from free_target_description.
8849         (make_cleanup_free_target_description): Remove.
8850
8851 2019-01-02  Tom Tromey  <tom@tromey.com>
8852
8853         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
8854         constructor, destructor.
8855         (linespec_parser): Remove typedef.
8856         (~linespec_parser): Rename from linespec_parser_delete.
8857         (linespec_lex_to_end, linespec_complete_label)
8858         (linespec_complete): Update.
8859         (decode_line_full): Remove cleanups.
8860         (decode_line_1): Update.
8861
8862 2019-01-02  Tom Tromey  <tom@tromey.com>
8863
8864         * python/python-internal.h (inferior_to_inferior_object): Change
8865         return type.
8866         * python/py-exitedevent.c (create_exited_event_object): Update.
8867         * python/py-inferior.c (inferior_to_inferior_object): Return
8868         gdbpy_ref.
8869         (python_new_inferior, python_inferior_deleted)
8870         (thread_to_thread_object, delete_thread_object)
8871         (build_inferior_list, gdbpy_selected_inferior): Update.
8872         * python/py-infthread.c (create_thread_object): Update.  Also fail
8873         if inferior_to_inferior_object fails.
8874
8875 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
8876
8877         * inferior.h (class inferior) <displaced_step_state>: New field.
8878         * infrun.h (struct displaced_step_state): Move here from
8879         infrun.c.  Initialize fields, add constructor.
8880         <inf>: Remove field.
8881         <reset>: New method.
8882         * infrun.c (struct displaced_step_inferior_state): Move to
8883         infrun.h.
8884         (displaced_step_inferior_states): Remove.
8885         (get_displaced_stepping_state): Adust.
8886         (displaced_step_in_progress_any_inferior): Adjust.
8887         (displaced_step_in_progress_thread): Adjust.
8888         (displaced_step_in_progress): Adjust.
8889         (add_displaced_stepping_state): Remove.
8890         (get_displaced_step_closure_by_addr): Adjust.
8891         (remove_displaced_stepping_state): Remove.
8892         (infrun_inferior_exit): Call displaced_step_state.reset.
8893         (use_displaced_stepping): Don't check for NULL.
8894         (displaced_step_prepare_throw): Call
8895         get_displaced_stepping_state.
8896         (displaced_step_fixup): Don't check for NULL.
8897         (prepare_for_detach): Don't check for NULL.
8898
8899 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8900
8901         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
8902          in case of call that did not complete.
8903
8904 2019-01-02  Andrey Utkin  <autkin@undo.io>
8905
8906         * symfile.c (find_separate_debug_file): Fix search of debug files for
8907         remote debuggee.
8908
8909 2019-01-02  Tom Tromey  <tom@tromey.com>
8910
8911         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
8912         indentation.
8913         * python/py-frame.c (frapy_older): Remove cast.
8914         (frapy_newer): Likewise.
8915         * python/py-breakpoint.c (local_setattro): Remove cast.
8916         * python/py-arch.c (archpy_name): Remove local variable.
8917         * python/py-type.c (gdbpy_lookup_type): Remove cast.
8918
8919 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
8920
8921         * unittests/basic_string_view/element_access/char/empty.cc:
8922         Fix year range in copyright header.
8923
8924 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8925
8926         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
8927         Delete.
8928         <operator==>: Update with for removed field.
8929         <hash>: Likewise.
8930         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
8931         <isa_features>: ...this.
8932         <abi_features>: New field.
8933         (riscv_isa_flen): Update comment.
8934         (riscv_abi_xlen): New declaration.
8935         (riscv_abi_flen): New declaration.
8936         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
8937         isa_features.
8938         (riscv_abi_xlen): New function.
8939         (riscv_isa_flen): Update to get answer from isa_features.
8940         (riscv_abi_flen): New function.
8941         (riscv_has_fp_abi): Update to get answer from abi_features.
8942         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
8943         xlen and flen.
8944         (riscv_call_info) <xlen, flen>: Update comment.
8945         (riscv_call_arg_struct): Remove invalid assertions
8946         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
8947         is removed.
8948         (riscv_gdbarch_init): Gather isa features and abi features
8949         separately, ensure both match on the gdbarch when reusing an old
8950         gdbarch.  Relax an error check to allow 32-bit abi float to run on
8951         a target with 64-bit float hardware.
8952
8953 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8954
8955         * source.c (search_command_helper): Stop reverse search
8956         when line 1 has been searched.
8957
8958 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8959
8960         * record-full.c (record_full_base_target::close): Rewrite
8961         record_full_core_buf_list free logic.
8962
8963 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8964
8965         * break-catch-syscall.c (print_one_catch_syscall): xfree
8966         the last text.
8967
8968 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8969
8970         * top.c (print_gdb_version): Update Copyright year in version
8971         message.
8972
8973 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8974
8975         Update copyright year range in all GDB files.
8976
8977 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
8978
8979         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
8980
8981 For older changes see ChangeLog-2018.
8982 \f
8983 Local Variables:
8984 mode: change-log
8985 left-margin: 8
8986 fill-column: 74
8987 version-control: never
8988 coding: utf-8
8989 End:
8990