gdb/ChangeLog

   1 2019-01-23  Tom Tromey  <tom@tromey.com>
   2             Andrew Burgess  <andrew.burgess@embecosm.com>
   3             Pedro Alves  <palves@redhat.com>
   4
   5 2019-01-23  Pedro Alves  <palves@redhat.com>
   6
   7         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
   8
   9 2019-01-23  Pedro Alves  <palves@redhat.com>
  10             Andrew Burgess  <andrew.burgess@embecosm.com>
  11
  12         * gdbthread.h: Include "common/forward-scope-exit.h".
  13         (scoped_finish_thread_state): Redefine custom class in terms of
  14         forward_scope_exit.
  15
  16 2019-01-23  Pedro Alves  <palves@redhat.com>
  17             Andrew Burgess  <andrew.burgess@embecosm.com>
  18
  19         * common/forward-scope-exit.h: New file.
  20
  21 2019-01-23  Pedro Alves  <palves@redhat.com>
  22             Andrew Burgess  <andrew.burgess@embecosm.com>
  23             Tom Tromey  <tom@tromey.com>
  24
  25         * common/scope-exit.h: New file.
  26
  27 2019-01-23  Pedro Alves  <palves@redhat.com>
  28
  29         * common/preprocessor.h (ESC): Rename to ...
  30         (ESC_PARENS): ... this.
  31         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
  32         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
  33
  34 2019-01-23  Tom Tromey  <tom@tromey.com>
  35
  36         * language.h (class scoped_switch_to_sym_language_if_auto):
  37         Initialize m_lang in both cases.
  38
  39 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
  40
  41         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
  42         with XCNEW.
  43
  44 2019-01-22  Tom Tromey  <tom@tromey.com>
  45
  46         * corelow.c: Do not include sys/file.h.
  47
  48 2019-01-22  Tom Tromey  <tom@tromey.com>
  49
  50         * tui/tui-wingeneral.h: Include gdb_curses.h.
  51
  52 2019-01-22  Tom Tromey  <tom@tromey.com>
  53
  54         * source-cache.h (class source_cache) <get_source_lines,
  55         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
  56
  57 2019-01-22  Tom Tromey  <tom@tromey.com>
  58
  59         * remote-fileio.h (struct remote_target): Declare.
  60
  61 2019-01-22  Tom Tromey  <tom@tromey.com>
  62
  63         * python/py-arch.c: Do not include py-ref.h.
  64         * python/py-bpevent.c: Do not include py-ref.h.
  65         * python/py-cmd.c: Do not include py-ref.h.
  66         * python/py-continueevent.c: Do not include py-ref.h.
  67         * python/py-event.h: Do not include py-ref.h.
  68         * python/py-evtregistry.c: Do not include py-ref.h.
  69         * python/py-finishbreakpoint.c: Do not include py-ref.h.
  70         * python/py-frame.c: Do not include py-ref.h.
  71         * python/py-framefilter.c: Do not include py-ref.h.
  72         * python/py-function.c: Do not include py-ref.h.
  73         * python/py-infevents.c: Do not include py-ref.h.
  74         * python/py-linetable.c: Do not include py-ref.h.
  75         * python/py-objfile.c: Do not include py-ref.h.
  76         * python/py-param.c: Do not include py-ref.h.
  77         * python/py-prettyprint.c: Do not include py-ref.h.
  78         * python/py-progspace.c: Do not include py-ref.h.
  79         * python/py-symbol.c: Do not include py-ref.h.
  80         * python/py-symtab.c: Do not include py-ref.h.
  81         * python/py-type.c: Do not include py-ref.h.
  82         * python/py-unwind.c: Do not include py-ref.h.
  83         * python/py-utils.c: Do not include py-ref.h.
  84         * python/py-value.c: Do not include py-ref.h.
  85         * python/py-varobj.c: Do not include py-ref.h.
  86         * python/py-xmethods.c: Do not include py-ref.h.
  87         * python/python.c: Do not include py-ref.h.
  88         * varobj.c: Do not include py-ref.h.
  89
  90 2019-01-22  Tom Tromey  <tom@tromey.com>
  91
  92         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
  93         keyword for bcache.
  94
  95 2019-01-22  Tom Tromey  <tom@tromey.com>
  96
  97         * compile/compile-cplus-types.c: Remove a comment by #include.
  98
  99 2019-01-22  Tom Tromey  <tom@tromey.com>
 100
 101         * compile/gcc-c-plugin.h: Include compile-internal.h.
 102
 103 2019-01-22  Tom Tromey  <tom@tromey.com>
 104
 105         * stabsread.c (EXTERN): Do not define.
 106         (symnum, next_symbol_text_func, processing_gcc_compilation)
 107         (within_function, global_sym_chain, global_stabs)
 108         (previous_stab_code, this_object_header_files)
 109         (n_this_object_header_files)
 110         (n_allocated_this_object_header_files): Define.
 111         * stabsread.h (EXTERN): Never define.  Use "extern".
 112
 113 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 114
 115         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
 116         history_value.
 117
 118 2019-01-21  Tom Tromey  <tom@tromey.com>
 119
 120         * ui-out.c: Fix includes.
 121         * tui/tui-source.c: Fix includes.
 122         * target.c: Fix includes.
 123         * remote.c: Fix includes.
 124         * regcache.c: Fix includes.
 125         * python/py-block.c: Fix includes.
 126         * printcmd.c: Fix includes.
 127         * or1k-tdep.c: Fix includes.
 128         * mi/mi-main.c: Fix includes.
 129         * m32r-tdep.c: Fix includes.
 130         * csky-tdep.c: Fix includes.
 131         * compile/compile-cplus-types.c: Fix includes.
 132         * cli/cli-interp.c: Fix includes.
 133
 134 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
 135
 136         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 137         for padding.
 138
 139 2019-01-16  Tom Tromey  <tom@tromey.com>
 140
 141         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
 142         earlier.
 143         (struct objfile) <msymbols_range>: Move from top level.
 144         <msymbols>: New method.
 145         (class objfile_msymbols): Remove.
 146         * symtab.c (default_collect_symbol_completion_matches_break_on):
 147         Update.
 148         * symmisc.c (dump_msymbols): Update.
 149         * stabsread.c (scan_file_globals): Update.
 150         * objc-lang.c (info_selectors_command, info_classes_command)
 151         (find_methods): Update.
 152         * minsyms.c (find_solib_trampoline_target): Update.
 153         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
 154         * coffread.c (coff_symfile_read): Update.
 155         * ada-lang.c (ada_lookup_simple_minsym)
 156         (ada_collect_symbol_completion_matches): Update.
 157
 158 2019-01-16  Tom Tromey  <tom@tromey.com>
 159
 160         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
 161         type.  Remove no-argument constructor.
 162         <iterator::operator++>: Simplify.
 163         <begin>: Update.
 164         <end>: Use minimal_symbol_count.
 165
 166 2019-01-16  Tom Tromey  <tom@tromey.com>
 167
 168         * objfiles.h (struct objfile) <psymtabs>: New method.
 169         (class objfile_psymtabs): Remove.
 170         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
 171         typedef.
 172         <range>: New method.
 173         (require_partial_symbols): Change return type.
 174         * psymtab.c (require_partial_symbols)
 175         (psym_expand_symtabs_matching): Update.
 176         * mdebugread.c (parse_partial_symbols): Update.
 177         * dbxread.c (dbx_end_psymtab): Update.
 178
 179 2019-01-15  Tom Tromey  <tom@tromey.com>
 180
 181         * symtab.c (lookup_objfile_from_block)
 182         (lookup_symbol_in_objfile_symtabs)
 183         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
 184         (find_line_symtab, info_sources_command)
 185         (default_collect_symbol_completion_matches_break_on)
 186         (make_source_files_completion_list): Update.
 187         * symmisc.c (print_objfile_statistics, dump_objfile)
 188         (maintenance_print_symbols, maintenance_info_symtabs)
 189         (maintenance_check_symtabs, maintenance_info_line_tables):
 190         Update.
 191         * source.c (select_source_symtab)
 192         (forget_cached_source_info_for_objfile): Update.
 193         * objfiles.h (class objfile_compunits): Remove.
 194         (struct objfile) <compunits_range>: New typedef.
 195         (compunits): New method.
 196         * objfiles.c (objfile_relocate1): Update.
 197         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 198         * maint.c (count_symtabs_and_blocks): Update.
 199         * linespec.c (iterate_over_all_matching_symtabs): Update.
 200         * cp-support.c (add_symbol_overload_list_qualified): Update.
 201         * coffread.c (coff_symtab_read): Update.
 202         * ada-lang.c (add_nonlocal_symbols)
 203         (ada_collect_symbol_completion_matches)
 204         (ada_add_global_exceptions): Update.
 205
 206 2019-01-15  Tom Tromey  <tom@tromey.com>
 207
 208         * progspace.h (program_space) <objfiles_safe_range>: New
 209         typedef.
 210         <objfiles_safe>: New method.
 211         * objfiles.h (class all_objfiles_safe): Remove.
 212         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
 213         * jit.c (jit_inferior_exit_hook): Update.
 214
 215 2019-01-17  Tom Tromey  <tom@tromey.com>
 216
 217         * progspace.h (program_space) <objfiles_range>: New typedef.
 218         <objfiles>: New method.
 219         <objfiles_head>: Rename from objfiles.
 220         (object_files): Update.
 221         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
 222         * guile/scm-pretty-print.c
 223         (ppscm_find_pretty_printer_from_objfiles): Update.
 224         * guile/scm-objfile.c (gdbscm_objfiles): Update.
 225         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
 226         Update.
 227         * python/py-progspace.c (pspy_get_objfiles): Update.
 228         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 229         Update.
 230         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 231         (objfpy_lookup_objfile_by_build_id): Update.
 232         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 233         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 234         Update.
 235         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 236         (expand_symtab_containing_pc, lookup_objfile_from_block)
 237         (lookup_static_symbol, basic_lookup_transparent_type)
 238         (find_pc_sect_compunit_symtab, find_symbol_at_address)
 239         (find_line_symtab, info_sources_command)
 240         (default_collect_symbol_completion_matches_break_on)
 241         (make_source_files_completion_list, find_main_name): Update.
 242         * symmisc.c (print_symbol_bcache_statistics)
 243         (print_objfile_statistics, maintenance_print_symbols)
 244         (maintenance_print_msymbols, maintenance_print_objfiles)
 245         (maintenance_info_symtabs, maintenance_check_symtabs)
 246         (maintenance_expand_symtabs, maintenance_info_line_tables):
 247         Update.
 248         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
 249         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
 250         (map_overlay_command, unmap_overlay_command)
 251         (simple_overlay_update, expand_symtabs_matching)
 252         (map_symbol_filenames): Update.
 253         * symfile-debug.c (set_debug_symfile): Update.
 254         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
 255         Update.
 256         * source.c (select_source_symtab, forget_cached_source_info):
 257         Update.
 258         * solib.c (solib_read_symbols): Update.
 259         * solib-spu.c (append_ocl_sos): Update.
 260         * psymtab.c (maintenance_print_psymbols)
 261         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
 262         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
 263         * printcmd.c (info_symbol_command): Update.
 264         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
 265         Update.
 266         * objfiles.h (class all_objfiles): Remove.
 267         * objfiles.c (have_partial_symbols, have_full_symbols)
 268         (have_minimal_symbols, qsort_cmp, update_section_map)
 269         (shared_objfile_contains_address_p)
 270         (default_iterate_over_objfiles_in_search_order): Update.
 271         * objc-lang.c (info_selectors_command, info_classes_command)
 272         (find_methods): Update.
 273         * minsyms.c (find_solib_trampoline_target): Update.
 274         * maint.c (maintenance_info_sections)
 275         (maintenance_translate_address, count_symtabs_and_blocks):
 276         Update.
 277         * main.c (captured_main_1): Update.
 278         * linux-thread-db.c (try_thread_db_load_from_pdir)
 279         (has_libpthread): Update.
 280         * linespec.c (iterate_over_all_matching_symtabs)
 281         (search_minsyms_for_name): Update.
 282         * jit.c (jit_find_objf_with_entry_addr): Update.
 283         * hppa-tdep.c (find_unwind_entry)
 284         (hppa_lookup_stub_minimal_symbol): Update.
 285         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
 286         Update.
 287         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 288         (elf_gnu_ifunc_resolve_by_got): Update.
 289         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
 290         * dwarf-index-write.c (save_gdb_index_command): Update.
 291         * cp-support.c (add_symbol_overload_list_qualified): Update.
 292         * breakpoint.c (create_overlay_event_breakpoint)
 293         (create_longjmp_master_breakpoint)
 294         (create_std_terminate_master_breakpoint)
 295         (create_exception_master_breakpoint): Update.
 296         * blockframe.c (find_pc_partial_function): Update.
 297         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
 298         (ada_collect_symbol_completion_matches)
 299         (ada_add_global_exceptions): Update.
 300
 301 2019-01-17  Tom Tromey  <tom@tromey.com>
 302
 303         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
 304         declare VEC.
 305         (solib_target_parse_libraries): Change return type.
 306         (library_list_start_segment, library_list_start_section)
 307         (library_list_end_library, library_list_start_library); Update.
 308         (solib_target_free_library_list): Remove.
 309         (solib_target_parse_libraries): Remove cleanup.  Change return
 310         type.
 311         (solib_target_current_sos): Update.
 312
 313 2019-01-17  Tom Tromey  <tromey@bapiya>
 314
 315         * valprint.c: Replace "the the" with "the".
 316         * symtab.c: Replace "the the" with "the".
 317         * solib.c: Replace "the the" with "the".
 318         * solib-dsbt.c: Replace "the the" with "the".
 319         * linespec.c: Replace "the the" with "the".
 320         * dwarf2loc.h: Replace "the the" with "the".
 321         * amd64-windows-tdep.c: Replace "the the" with "the".
 322         * aarch64-tdep.c: Replace "the the" with "the".
 323
 324 2019-01-16  Keith Seitz  <keiths@redhat.com>
 325
 326         PR gdb/23773
 327         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
 328         <builder>: Rename to ..
 329         <m_builder>: ... this and make private.
 330         (dwarf2_cu::get_builder): New method.  Change all users of
 331         `builder' to use this method.
 332         (dwarf2_start_symtab): Move to ...
 333         (dwarf2_cu::start_symtab): ... here.  Update all callers
 334         (setup_type_unit_groups): Move to ...
 335         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
 336         callers.
 337         (dwarf2_cu::reset_builder): New method.
 338         (process_full_compunit, process_full_type_unit): Use
 339         dwarf2_cu::reset_builder.
 340         (follow_die_offset): Record the ancestor CU if it is different
 341         from the followed DIE's CU.
 342         (follow_die_sig_1): Likewise.
 343
 344 2019-01-15  Tom Tromey  <tom@tromey.com>
 345
 346         * remote.c (class remote_state) <buf>: Now a char_vector.
 347         <buf_size>: Remove.
 348         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
 349         parameter.
 350         (remote_target::getpkt_or_notif_sane_1)
 351         (remote_target::getpkt_sane)
 352         (remote_target::getpkt_or_notif_sane): Likewise.
 353         (class remote_target) <putpkt>: New overload.
 354         (remote_target::read_frame): Change type of "buf_p".  Remove
 355         sizeof_p parameter.
 356         (packet_ok): New overload.
 357         (packet_check_result): New overload.
 358         Update all uses.
 359
 360 2019-01-14  Tom Tromey  <tom@tromey.com>
 361
 362         * remote-notif.c (handle_notification, remote_notif_ack)
 363         (remote_notif_parse): Make "buf" const.
 364         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
 365         const.
 366         (remote_notif_parse, remote_notif_ack, handle_notification):
 367         Likewise.
 368         * remote.c (remote_notif_stop_parse): Make "buf" const.
 369         (remote_target::remote_parse_stop_reply): Make "buf" const.
 370         (remote_notif_stop_ack): Make "buf" const.
 371
 372 2019-01-14  Tom Tromey  <tom@tromey.com>
 373
 374         * remote.c (remote_console_output): Make parameter const.
 375
 376 2019-01-14  Tom Tromey  <tom@tromey.com>
 377
 378         * target-debug.h (target_debug_print_signals): Constify.
 379         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
 380         * procfs.c (procfs_target::pass_signals): Update.
 381         * linux-nat.c (linux_nat_target::pass_signals): Update.
 382         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
 383         * target-delegates.c: Rebuild.
 384         * remote.c (remote_target::program_signals): Update.
 385         (remote_target::pass_signals): Update.
 386         * target.c (target_pass_signals): Constify argument.
 387         (target_program_signals): Likewise.
 388         * target.h (struct target_ops) <pass_signals, program_signals>:
 389         Constify argument.
 390         (target_pass_signals, target_program_signals): Constify argument.
 391
 392 2019-01-14  Tom Tromey  <tom@tromey.com>
 393
 394         PR tui/28819:
 395         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
 396
 397 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 398
 399         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
 400         field.
 401         * rs6000-tdep.c: Include reggroups.h.
 402         (IS_V_ALIAS_PSEUDOREG): Define.
 403         (rs6000_register_name): Return names for the "vX" aliases.
 404         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
 405         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
 406         aliases.  Call default_register_reggroup_p for all other
 407         pseudo-registers.
 408         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
 409         New functions.
 410         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
 411         Handle "vX" aliases.
 412         (v_alias_pseudo_register_collect): New function.
 413         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
 414         (rs6000_gdbarch_init): Initialize "vX" aliases as
 415         pseudo-registers.  Restore registration of
 416         rs6000_pseudo_register_reggroup_p with
 417         set_tdesc_pseudo_register_reggroup_p.
 418
 419 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
 420
 421         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
 422         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
 423         set_gdbarch_num_pseudo_regs.
 424
 425 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 426
 427         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
 428         Remove arg prefixname, add do_set and do_show.
 429         Add member functions set_list and show_list.
 430         * cli/cli-style.c (class cli_style_option): Update accordingly.
 431         (style_set_list): Move to file scope.
 432         (style_show_list): Likewise.
 433         (set_style): Call help_list.
 434         (show_style): Call cmd_show_list.
 435         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
 436         Update to use the new macro.
 437
 438 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
 439
 440         * ada-lang.c (_initialize_ada_language): Expand the help text
 441         for the "catch exception" command.
 442
 443 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 444
 445         * symtab.c (matching_obj_sections): Initialize obj,
 446         declare it closer to its usage.
 447
 448 2019-01-10  Tom Tromey  <tom@tromey.com>
 449
 450         * thread-iter.h (inf_threads_iterator): Use next_iterator.
 451         (basic_inf_threads_range): Remove.
 452         (inf_threads_range, inf_non_exited_threads_range)
 453         (safe_inf_threads_range): Use next_adapter.
 454
 455 2019-01-10  Keith Seitz  <keiths@redhat.com>
 456
 457         PR gdb/23712
 458         PR symtab/23010
 459         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
 460         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
 461
 462 2019-01-10  Keith Seitz  <keiths@redhat.com>
 463
 464         PR gdb/23712
 465         PR symtab/23010
 466         * dictionary.c (pending_to_vector): Remove.
 467         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 468         Remove _1 suffix, replacing functions of the same name.  Update
 469         all callers.
 470         (dict_create_hashed, dict_create_hashed_expandable)
 471         (dict_create_linear, dict_create_linear_expandable, dict_free)
 472         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
 473         Make functions static.
 474
 475 2019-01-10  Keith Seitz  <keiths@redhat.com>
 476
 477         PR gdb/23712
 478         PR symtab/23010
 479         * dictionary.h (struct dictionary): Replace declaration with
 480         multidictionary.
 481         (dict_create_hashed, dict_create_hashed_expandable)
 482         (dict_create_linear, dict_create_linear_expandable)
 483         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
 484         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
 485         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
 486         taking multidictionary argument.
 487         [ALL_DICT_SYMBOLS]: Update for multidictionary.
 488         * block.h (struct block) <dict>: Change to multidictionary
 489         and rename `multidict'.
 490         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
 491         symmisc.c: Update all dictionary references to multidictionary.
 492
 493 2019-01-10  Keith Seitz  <keiths@redhat.com>
 494
 495         PR gdb/23712
 496         PR symtab/23010
 497         * dictionary.c: Include unordered_map.
 498         (pending_to_vector): New function.
 499         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 500         Rewrite the non-"_1" functions to take vector instead
 501         of linked list.
 502         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
 503         "new" _1 versions of the same name.
 504         (multidictionary): Define.
 505         (std::hash<enum language): New definition.
 506         (collate_pending_symbols_by_language, mdict_create_hashed)
 507         (mdict_create_hashed_expandable, mdict_create_linear)
 508         (mdict_create_linear_expandable, mdict_free)
 509         (find_language_dictionary, create_new_language_dictionary)
 510         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
 511         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
 512         (mdict_size, mdict_empty): New functions.
 513         * dictionary.h (mdict_iterator): Define.
 514
 515 2019-01-10  Pedro Alves  <palves@redhat.com>
 516
 517         * breakpoint.c (read_uploaded_action)
 518         (create_tracepoint_from_upload): Adjust to use
 519         gdb::unique_xmalloc_ptr.
 520         * ctf.c (ctf_write_uploaded_tp):
 521         (SET_ARRAY_FIELD): Use emplace_back.
 522         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
 523         * tracefile-tfile.c (tfile_write_uploaded_tp):
 524         * tracepoint.c (parse_tracepoint_definition): Adjust to use
 525         gdb::unique_xmalloc_ptr.
 526         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
 527         at_string, cond_string, cmd_strings>: Replace char pointers
 528         with gdb::unique_xmalloc_ptr.
 529
 530 2019-01-10  Pedro Alves  <palves@redhat.com>
 531
 532         * solib-target.c (library_list_start_library): Don't xstrdup name.
 533
 534 2019-01-10  Pedro Alves  <palves@redhat.com>
 535
 536         * mdebugread.c (parse_partial_symbols): Use
 537         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
 538
 539 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 540
 541         * linux-fork.c (scoped_switch_fork_info)
 542         <~scoped_switch_fork_info>: Fix incorrect variable name.
 543
 544 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 545
 546         * linux-fork.c (scoped_switch_fork_info)
 547         <scoped_switch_fork_info>: Make explicit.
 548         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
 549
 550 2019-01-10  Tom Tromey  <tom@tromey.com>
 551
 552         * objfiles.h (objfile::reset_psymtabs): Update.
 553         * objfiles.c (objfile::objfile): Update.
 554         * psymtab.h (psymtab_storage::obstack): Update.
 555         (psymtab_storage::m_obstack): Use gdb::optional.
 556         (class psymtab_storage): Update comment.  Remove objfile
 557         parameter.
 558         * psymtab.c (psymtab_storage::psymtab_storage): Update.
 559
 560 2019-01-10  Tom Tromey  <tom@tromey.com>
 561
 562         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
 563         <free_psymtabs>: Now private.
 564         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
 565         (allocate_psymtab): Use new method.
 566
 567 2019-01-10  Tom Tromey  <tom@tromey.com>
 568
 569         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
 570         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
 571         * mdebugread.c (parse_partial_symbols): Use
 572         allocate_dependencies.
 573         * dwarf2read.c (dwarf2_create_include_psymtab): Use
 574         allocate_dependencies.
 575         (process_psymtab_comp_unit_reader)
 576         (build_type_psymtab_dependencies): Likewise.
 577         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
 578
 579 2019-01-10  Tom Tromey  <tom@tromey.com>
 580
 581         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
 582         PSYMBOL_SET_LANGUAGE.
 583         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
 584
 585 2019-01-10  Tom Tromey  <tom@tromey.com>
 586
 587         * psymtab.h (psymtab_storage::obstack): New method.
 588         <m_obstack>: Rename from obstack; now private.
 589         * psymtab.c (psymtab_storage): Update.
 590         * dwarf2read.c (create_addrmap_from_index)
 591         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
 592         Update.
 593
 594 2019-01-10  Tom Tromey  <tom@tromey.com>
 595
 596         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
 597         * objfiles.h (objfile::reset_psymtabs): New method.
 598
 599 2019-01-10  Tom Tromey  <tom@tromey.com>
 600
 601         * symmisc.c (print_symbol_bcache_statistics): Update.
 602         (print_objfile_statistics): Update.
 603         * symfile.c (reread_symbols): Update.
 604         * psymtab.h (class psymtab_storage): New.
 605         * psymtab.c (psymtab_storage): New constructor.
 606         (~psymtab_storage): New destructor.
 607         (require_partial_symbols): Update.
 608         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
 609         (find_pc_sect_psymtab, find_pc_sect_psymbol)
 610         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
 611         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
 612         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
 613         (start_psymtab_common, end_psymtab_common)
 614         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
 615         (allocate_psymtab): Update.
 616         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
 617         Update.
 618         (dump_psymtab_addrmap, maintenance_print_psymbols)
 619         (maintenance_check_psymtabs): Update.
 620         (class objfile_psymtabs): Move to objfiles.h.
 621         * psympriv.h (discard_psymtab): Now inline.
 622         (psymtab_discarder::psymtab_discarder): Update.
 623         (psymtab_discarder::~psymtab_discarder): Update.
 624         (ALL_OBJFILE_PSYMTABS): Rewrite.
 625         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
 626         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
 627         Remove fields.
 628         <partial_symtabs>: New field.
 629         (class objfile_psymtabs): Move from psymtab.h.  Update.
 630         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
 631         psymbol_cache.
 632         (objfile::~objfile): Don't destroy psymbol_cache.
 633         * mdebugread.c (parse_partial_symbols): Update.
 634         * dwarf2read.c (create_addrmap_from_index)
 635         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
 636         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
 637         (add_partial_subprogram, dwarf2_ranges_read): Update.
 638         * dwarf-index-write.c (write_address_map)
 639         (write_one_signatured_type, recursively_write_psymbols)
 640         (class debug_names, class debug_names, write_psymtabs_to_index):
 641         Update.
 642
 643 2019-01-10  Tom Tromey  <tom@tromey.com>
 644
 645         * symtab.h (SYMBOL_SET_NAMES): Update.
 646         (symbol_set_names): Update.
 647         (MSYMBOL_SET_NAMES): Update.
 648         * symtab.c (symbol_set_names): Change argument to be an
 649         objfile_per_bfd_storage.
 650         * psymtab.c (add_psymbol_to_bcache): Update.
 651         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
 652
 653 2019-01-10  Tom Tromey  <tom@tromey.com>
 654
 655         * symtab.c (create_demangled_names_hash): Change argument to be an
 656         objfile_per_bfd_storage.
 657         (symbol_set_names): Update.
 658
 659 2019-01-10  Tom Tromey  <tom@tromey.com>
 660
 661         * xcoffread.c (xcoff_initial_scan): Unconditionally call
 662         init_psymbol_list.
 663         * psymtab.c (init_psymbol_list): Do nothing if already called.
 664         * psympriv.h (init_psymbol_list): Add comment.
 665         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
 666         init_psymbol_list.
 667         * dbxread.c (dbx_symfile_read): Unconditionally call
 668         init_psymbol_list.
 669
 670 2019-01-10  Tom Tromey  <tom@tromey.com>
 671
 672         * xcoffread.c (scan_xcoff_symtab): Update.
 673         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
 674         "where".
 675         * mdebugread.c (parse_partial_symbols)
 676         (handle_psymbol_enumerators): Update.
 677         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
 678         * dbxread.c (read_dbx_symtab): Update.
 679         * psympriv.h (psymbol_placement): New enum.
 680         (add_psymbol_to_list): Update.
 681
 682 2019-01-10  Tom Tromey  <tom@tromey.com>
 683
 684         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
 685         static_psymbols parameters.
 686         (scan_xcoff_symtab): Update.
 687         * psymtab.c (start_psymtab_common): Remove global_psymbols and
 688         static_psymbols parameters.
 689         * psympriv.h (start_psymtab_common): Update.
 690         * mdebugread.c (parse_partial_symbols): Update.
 691         * dwarf2read.c (create_partial_symtab): Update.
 692         * dbxread.c (read_dbx_symtab): Update.
 693         (start_psymtab): Remove global_psymbols and static_psymbols
 694         parameters.
 695
 696 2019-01-10  Tom Tromey  <tom@tromey.com>
 697
 698         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
 699         * psymtab.c (allocate_psymtab): Add comment.
 700         * psympriv.h (allocate_psymtab): Add comment.
 701         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
 702         initializations.
 703         * dbxread.c (dbx_end_psymtab): Remove some initializations.
 704
 705 2019-01-10  Tom Tromey  <tom@tromey.com>
 706
 707         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 708         Don't declare.
 709         * mipsread.c: Include mdebugread.h.
 710         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 711         Declare.
 712         * elfread.c: Include mdebugread.h.
 713
 714 2019-01-09  Tom Tromey  <tom@tromey.com>
 715
 716         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
 717         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
 718         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
 719         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
 720         (psym_lookup_symbol, psym_find_last_source_symtab)
 721         (psym_forget_cached_source_info, psym_print_stats)
 722         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
 723         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
 724         (psym_map_matching_symbols, psym_expand_symtabs_matching)
 725         (psym_find_compunit_symtab_by_address)
 726         (maintenance_print_psymbols, maintenance_info_psymtabs)
 727         (maintenance_check_psymtabs): Use ranged for.
 728         * psymtab.h (class objfile_psymtabs): New.
 729         (require_partial_symbols): Return objfile_psymtabs.
 730         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
 731
 732 2019-01-09  Tom Tromey  <tom@tromey.com>
 733
 734         * symfile.c (overlay_invalidate_all, find_pc_overlay)
 735         (find_pc_mapped_section, list_overlays_command)
 736         (map_overlay_command, unmap_overlay_command)
 737         (simple_overlay_update): Use all_objfiles.
 738         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
 739         * printcmd.c (info_symbol_command): Use all_objfiles.
 740         * objfiles.h (ALL_OBJSECTIONS): Remove.
 741         * maint.c (maintenance_translate_address): Use all_objfiles.
 742         * gcore.c (gcore_create_callback): Use all_objfiles.
 743         (objfile_find_memory_regions): Likewise.
 744
 745 2019-01-09  Tom Tromey  <tom@tromey.com>
 746
 747         * symtab.c (find_line_symtab, info_sources_command)
 748         (make_source_files_completion_list): Use objfile_compunits.
 749         * source.c (select_source_symtab): Use objfile_compunits.
 750         * objfiles.h (struct objfile): Update comment.
 751         (ALL_OBJFILES): Remove.
 752         (ALL_FILETABS): Remove.
 753         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
 754         objfile_compunits.
 755
 756 2019-01-09  Tom Tromey  <tom@tromey.com>
 757
 758         * symmisc.c (print_objfile_statistics, dump_objfile)
 759         (maintenance_print_symbols): Use compunit_filetabs.
 760         * source.c (forget_cached_source_info_for_objfile): Use
 761         compunit_filetabs.
 762         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
 763         (ALL_FILETABS): Use compunit_filetabs.
 764         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
 765         * coffread.c (coff_symtab_read): Use compunit_filetabs.
 766
 767 2019-01-09  Tom Tromey  <tom@tromey.com>
 768
 769         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
 770         (compunit_filetabs): New.
 771         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
 772         compunit_filetabs.
 773         (info_sources_command, make_source_files_completion_list): Remove
 774         declaration.
 775         * symmisc.c (print_objfile_statistics, dump_objfile)
 776         (maintenance_print_symbols): Remove declaration.
 777         (maintenance_info_symtabs): Use compunit_filetabs.
 778         (maintenance_info_line_tables): Likewise.
 779         * source.c (select_source_symtab): Change local variable name.
 780         (forget_cached_source_info_for_objfile): Remove declaration.
 781         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
 782         * objfiles.c (objfile_relocate1): Remove declaration.
 783         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 784         declaration.
 785         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
 786         * coffread.c (coff_symtab_read): Remove declaration.
 787         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 788         compunit_filetabs.
 789
 790 2019-01-09  Tom Tromey  <tom@tromey.com>
 791
 792         * symtab.c (lookup_objfile_from_block)
 793         (find_pc_sect_compunit_symtab, search_symbols)
 794         (default_collect_symbol_completion_matches_break_on): Use
 795         objfile_compunits.
 796         * objfiles.h (ALL_COMPUNITS): Remove.
 797         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
 798         * cp-support.c (add_symbol_overload_list_qualified): Use
 799         objfile_compunits.
 800         * ada-lang.c (ada_collect_symbol_completion_matches)
 801         (ada_add_global_exceptions): Use objfile_compunits.
 802
 803 2019-01-09  Tom Tromey  <tom@tromey.com>
 804
 805         * source.c (select_source_symtab)
 806         (forget_cached_source_info_for_objfile): Remove declaration.
 807         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 808         declaration.
 809         * maint.c (count_symtabs_and_blocks): Remove declaration.
 810         * cp-support.c (add_symbol_overload_list_qualified): Remove
 811         declaration.
 812         * coffread.c (coff_symtab_read): Remove declaration.
 813         * symtab.c (lookup_symbol_in_objfile_symtabs)
 814         (basic_lookup_transparent_type_1): Use objfile_compunits.
 815         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
 816         (info_sources_command, search_symbols)
 817         (default_collect_symbol_completion_matches_break_on)
 818         (make_source_files_completion_list): Remove declaration.
 819         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
 820         (ada_collect_symbol_completion_matches)
 821         (ada_add_global_exceptions): Remove declaration.
 822         * linespec.c (iterate_over_all_matching_symtabs): Use
 823         objfile_compunits.
 824         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
 825         (class objfile_compunits): New.
 826         (ALL_COMPUNITS): Use objfile_compunits.
 827         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
 828         (maintenance_check_symtabs, maintenance_info_line_tables): Use
 829         objfile_compunits.
 830         * objfiles.c (objfile_relocate1): Use objfile_compunits.
 831
 832 2019-01-09  Tom Tromey  <tom@tromey.com>
 833
 834         * symtab.c (search_symbols)
 835         (default_collect_symbol_completion_matches_break_on): Use
 836         objfile_msymbols.
 837         * ada-lang.c (ada_lookup_simple_minsym)
 838         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
 839         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
 840         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
 841         objfile_msymbols.
 842         * coffread.c (coff_symfile_read): Use objfile_msymbols.
 843         * symmisc.c (dump_msymbols): Use objfile_msymbols.
 844         * objc-lang.c (find_methods): Use objfile_msymbols.
 845         (info_selectors_command, info_classes_command): Likewise.
 846         * stabsread.c (scan_file_globals): Use objfile_msymbols.
 847         * objfiles.h (class objfile_msymbols): New.
 848         (ALL_OBJFILE_MSYMBOLS): Remove.
 849         (ALL_MSYMBOLS): Remove.
 850
 851 2019-01-09  Tom Tromey  <tom@tromey.com>
 852
 853         * common/next-iterator.h (next_adapter): Add Iterator template
 854         parameter.
 855         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
 856         (class all_objfiles_safe): New.
 857         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
 858         * objfiles.c (put_objfile_before): Update comment.
 859         (add_separate_debug_objfile): Likewise.
 860         (free_all_objfiles): Use all_objfiles_safe.
 861         (objfile_purge_solibs): Likewise.
 862
 863 2019-01-09  Tom Tromey  <tom@tromey.com>
 864
 865         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 866         (expand_symtab_containing_pc, lookup_static_symbol)
 867         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
 868         (find_symbol_at_address, find_line_symtab, find_main_name): Use
 869         all_objfiles.
 870         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
 871         * breakpoint.c (create_overlay_event_breakpoint)
 872         (create_longjmp_master_breakpoint)
 873         (create_std_terminate_master_breakpoint)
 874         (create_exception_master_breakpoint): Use all_objfiles.
 875         * linux-thread-db.c (try_thread_db_load_from_pdir)
 876         (has_libpthread): Use all_objfiles.
 877         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
 878         * linespec.c (iterate_over_all_matching_symtabs)
 879         (search_minsyms_for_name): Use all_objfiles.
 880         * maint.c (maintenance_info_sections): Use all_objfiles.
 881         * main.c (captured_main_1): Use all_objfiles.
 882         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
 883         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
 884         * guile/scm-pretty-print.c
 885         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
 886         * solib-spu.c (append_ocl_sos): Use all_objfiles.
 887         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
 888         (maintenance_print_msymbols): Use all_objfiles.
 889         * source.c (select_source_symtab): Use all_objfiles.
 890         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
 891         * symfile.c (remove_symbol_file_command)
 892         (expand_symtabs_matching, map_symbol_filenames): Use
 893         all_objfiles.
 894         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
 895         all_objfiles.
 896         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
 897         * objc-lang.c (find_methods): Use all_objfiles.
 898         * objfiles.c (have_partial_symbols, have_full_symbols)
 899         (have_minimal_symbols, qsort_cmp)
 900         (default_iterate_over_objfiles_in_search_order): Use
 901         all_objfiles.
 902         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
 903         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
 904         (maintenance_check_psymtabs): Use all_objfiles.
 905         (ALL_PSYMTABS): Remove.
 906         * compile/compile-object-run.c (do_module_cleanup): Use
 907         all_objfiles.
 908         * blockframe.c (find_pc_partial_function): Use all_objfiles.
 909         * cp-support.c (add_symbol_overload_list_qualified): Use
 910         all_objfiles.
 911         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 912         Use all_objfiles.
 913         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
 914         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
 915         all_objfiles.
 916         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 917         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
 918         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 919         Uses all_objfiles.
 920         * solib.c (solib_read_symbols): Use all_objfiles
 921
 922 2019-01-09  Tom Tromey  <tom@tromey.com>
 923
 924         * probe.c (parse_probes_in_pspace): Use all_objfiles.
 925         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
 926         all_objfiles.
 927         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
 928         * symmisc.c (print_symbol_bcache_statistics)
 929         (print_objfile_statistics, maintenance_print_objfiles)
 930         (maintenance_info_symtabs, maintenance_check_symtabs)
 931         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
 932         all_objfiles.
 933         * source.c (forget_cached_source_info): Use all_objfiles.
 934         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
 935         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 936         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
 937         * objfiles.c (update_section_map): Use all_objfiles.
 938         (shared_objfile_contains_address_p): Likewise.
 939         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
 940         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
 941
 942 2019-01-09  Tom Tromey  <tom@tromey.com>
 943
 944         * common/next-iterator.h: New file.
 945         * objfiles.h (class all_objfiles): New.
 946         (struct objfile_iterator): New.
 947
 948 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 949
 950         * NEWS: Move the description of the changed "frame", "select-frame",
 951          and "info frame" commands to the Changed commands section.
 952
 953 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
 954
 955         * gdbtypes.c (check_stub_method_group): Remove handling of old
 956         mangling schemes.
 957         * linespec.c (find_methods): Likewise.
 958         * stabsread.c (read_member_functions): Likewise.
 959         * valops.c (search_struct_method): Likewise.
 960         (value_struct_elt_for_reference): Likewise.
 961         * NEWS: Mention this change.
 962
 963 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 964
 965         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
 966         print_source_lines.
 967         * source.c (print_source_lines_base): Update line number check.
 968         (print_source_lines): New function.
 969         (source_lines_range::source_lines_range): New function.
 970         * source.h (class source_lines_range): New class.
 971         (print_source_lines): New declaration.
 972
 973 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 974
 975         * linespec.c (linespec_state_destructor): Free self->canonical_names.
 976
 977 2019-01-08  Tom Tromey  <tom@tromey.com>
 978             Simon Marchi  <simon.marchi@ericsson.com>
 979
 980         PR gdb/24060
 981         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
 982         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
 983         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
 984         * f-exp.y (DOLLAR_VARIABLE): Likewise.
 985         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
 986         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
 987
 988 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 989
 990         * source.c (select_source_symtab): Move header comment to
 991         declaration in source.h.
 992         (forget_cached_source_info_for_objfile): Likewise.
 993         (forget_cached_source_info): Likewise.
 994         (identify_source_line): Likewise.
 995         * source.h (identify_source_line): Move declaration from symtab.h
 996         and add comment from source.c
 997         (print_source_lines): Likewise.
 998         (forget_cached_source_info_for_objfile): Likewise.
 999         (forget_cached_source_info): Likewise.
1000         (select_source_symtab): Likewise.
1001         (enum print_source_lines_flag): Move definition from symtab.h.
1002         * symtab.h (identify_source_line): Move declaration to source.h.
1003         (print_source_lines): Likewise.
1004         (forget_cached_source_info_for_objfile): Likewise.
1005         (forget_cached_source_info): Likewise.
1006         (select_source_symtab): Likewise.
1007         (enum print_source_lines_flag): Move definition to source.h.
1008         * tui/tui-hooks.c: Add 'source.h' include.
1009
1010 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1011
1012         * source.c (print_source_lines_base): Handle requests to print
1013         reverse line number sequences, and guard against empty lines
1014         string.
1015
1016 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1017
1018         * source.c (print_source_lines_base): Fix skip of '\r' if next
1019         character is '\n'.
1020
1021 2019-01-06  Tom Tromey  <tom@tromey.com>
1022
1023         * c-exp.y (struct c_parse_state) <macro_original_text,
1024         expansion_obstack>: New member.
1025         (macro_original_text, expansion_obstack): Remove globals.
1026         (scan_macro_expansion, scanning_macro_expansion)
1027         (finished_macro_expansion): Update.
1028         (scan_macro_cleanup): Remove.
1029         (yylex, c_parse): Update.
1030
1031 2019-01-06  Tom Tromey  <tom@tromey.com>
1032
1033         * c-exp.y (struct c_parse_state) <strings>: New member.
1034         (operator_stoken): Update.
1035
1036 2019-01-06  Tom Tromey  <tom@tromey.com>
1037
1038         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
1039         (union type_stack_elt) <typelist_val>: Now a pointer to
1040         std::vector.
1041         (type_stack_cleanup): Don't declare.
1042         (push_typelist): Update.
1043         * parse.c (pop_typelist): Return a std::vector.
1044         (push_typelist): Take a std::vector.
1045         (follow_types): Update.  Do not free args.
1046         (type_stack_cleanup): Remove.
1047         * c-exp.y (struct c_parse_state): New.
1048         (cpstate): New global.
1049         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
1050         (nonempty_typelist): Update.
1051         (func_mod): Create a new vector.
1052         (c_parse): Create a c_parse_state.
1053         (check_parameter_typelist): Do not delete params.
1054         (function_method): Update.  Do not delete type_list.
1055
1056 2019-01-06  Tom Tromey  <tom@tromey.com>
1057
1058         PR gdb/28155:
1059         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
1060         check_typedef.
1061         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
1062         (print_return_value): Likewise.
1063
1064 2019-01-05  Tom Tromey  <tom@tromey.com>
1065
1066         * contrib/cleanup_check.py: Remove.
1067         * contrib/gcc-with-excheck: Remove.
1068         * contrib/exsummary.py: Remove.
1069         * contrib/excheck.py: Remove.
1070
1071 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
1072
1073         * thread.c (delete_thread_1): Add gdb_assert that THR is not
1074         NULL. Initialize tpprev to NULL instead of assigning it
1075         to NULL on the next statement.
1076         * windows-nat.c (windows_delete_thread): Remove check for
1077         main_thread_id before printing thread exit notifications.
1078         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
1079         Remove thread ID check against main_thread_id.
1080         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
1081         windows_delete_thread.
1082         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
1083
1084 2019-01-04  Tom Tromey  <tom@tromey.com>
1085
1086         * compile/compile.c (_initialize_compile): Use upper case for
1087         metasyntactic variables.
1088         * symmisc.c (_initialize_symmisc): Use upper case for
1089         metasyntactic variables.
1090         * psymtab.c (_initialize_psymtab): Use upper case for
1091         metasyntactic variables.
1092         * demangle.c (demangle_command): Use upper case for metasyntactic
1093         variables.
1094         (_initialize_demangler): Likewise.
1095         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
1096         variables.
1097
1098 2019-01-03  Tom Tromey  <tom@tromey.com>
1099
1100         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
1101
1102 2019-01-03  Tom Tromey  <tom@tromey.com>
1103
1104         * python/py-symtab.c (salpy_str): Update.
1105         (struct salpy_sal_object) <symtab>: Now a PyObject.
1106         (salpy_dealloc): Update.
1107         (del_objfile_sal): Use gdbpy_ref.
1108
1109 2019-01-03  Tom Tromey  <tom@tromey.com>
1110
1111         * python/py-type.c (convert_field): Use new_reference.  Return
1112         gdbpy_ref.
1113         (make_fielditem): Return gdbpy_ref.
1114         (typy_fields): Update.
1115         (typy_getitem): Update.
1116         (field_name): Return gdbpy_ref.  Use new_reference.
1117         (typy_iterator_iternext): Update.
1118
1119 2019-01-03  Tom Tromey  <tom@tromey.com>
1120
1121         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
1122
1123 2019-01-03  Tom Tromey  <tom@tromey.com>
1124
1125         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
1126         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
1127         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
1128         (pspy_set_frame_filters, pspy_set_frame_unwinders)
1129         (pspy_set_type_printers): Likewise.
1130         * python/py-function.c (fnpy_init): Use gdbpy_ref.
1131         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
1132         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
1133         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
1134         (objfpy_set_type_printers): Likewise.
1135
1136 2019-01-03  Tom Tromey  <tom@tromey.com>
1137
1138         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
1139         (gdbpy_print_stack): Use gdbpy_err_fetch.
1140         * python/python-internal.h (class gdbpy_err_fetch): New class.
1141         (class gdbpy_enter) <m_error_type, m_error_value,
1142         m_error_traceback>: Remove.
1143         <m_error>: New member.
1144         (gdbpy_exception_to_string): Don't declare.
1145         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
1146         * python/py-value.c (convert_value_from_python): Use
1147         gdbpy_err_fetch.
1148         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
1149         gdbpy_exception_to_string.
1150         (gdbpy_handle_exception): Use gdbpy_err_fetch.
1151         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1152         gdbpy_err_fetch.
1153
1154 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1155
1156         * linux-nat.c (delete_lwp_cleanup): Delete.
1157         (struct lwp_deleter): New struct.
1158         (lwp_info_up): New typedef.
1159         (linux_nat_target::follow_fork): Delete cleanup, and make use of
1160         lwp_info_up.
1161
1162 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1163
1164         * linux-fork.c (class scoped_switch_fork_info): New class.
1165         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
1166
1167 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1168
1169         * valops.c (find_overload_match): Remove use of null_cleanup, and
1170         calls to do_cleanups.
1171
1172 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1173
1174         * compile/compile-cplus-types.c
1175         (compile_cplus_instance::decl_name): Handle changes to
1176         cp_func_name.
1177         * cp-support.c (cp_func_name): Update header comment, update
1178         return type.
1179         * cp-support.h (cp_func_name): Update return type in declaration.
1180         * valops.c (find_overload_match): Move temp_func local to top
1181         level of function and change its type.  Use temp_func to hold and
1182         delete temporary string obtained from cp_func_name.
1183
1184 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1185
1186         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
1187         gdb::char_vector, remove cleanup, and update uses of `msg`.
1188
1189 2019-01-03  Jim Wilson  <jimw@sifive.com>
1190
1191         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
1192
1193 2019-01-02  Tom Tromey  <tom@tromey.com>
1194
1195         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
1196         (tdesc_parse_xml): Remove cleanups.
1197         * target-descriptions.h (make_cleanup_free_target_description):
1198         Don't declare.
1199         (target_desc_deleter): New struct.
1200         (target_desc_up): New typedef.
1201         * target-descriptions.c (target_desc_deleter::operator()): Rename
1202         from free_target_description.
1203         (make_cleanup_free_target_description): Remove.
1204
1205 2019-01-02  Tom Tromey  <tom@tromey.com>
1206
1207         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
1208         constructor, destructor.
1209         (linespec_parser): Remove typedef.
1210         (~linespec_parser): Rename from linespec_parser_delete.
1211         (linespec_lex_to_end, linespec_complete_label)
1212         (linespec_complete): Update.
1213         (decode_line_full): Remove cleanups.
1214         (decode_line_1): Update.
1215
1216 2019-01-02  Tom Tromey  <tom@tromey.com>
1217
1218         * python/python-internal.h (inferior_to_inferior_object): Change
1219         return type.
1220         * python/py-exitedevent.c (create_exited_event_object): Update.
1221         * python/py-inferior.c (inferior_to_inferior_object): Return
1222         gdbpy_ref.
1223         (python_new_inferior, python_inferior_deleted)
1224         (thread_to_thread_object, delete_thread_object)
1225         (build_inferior_list, gdbpy_selected_inferior): Update.
1226         * python/py-infthread.c (create_thread_object): Update.  Also fail
1227         if inferior_to_inferior_object fails.
1228
1229 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
1230
1231         * inferior.h (class inferior) <displaced_step_state>: New field.
1232         * infrun.h (struct displaced_step_state): Move here from
1233         infrun.c.  Initialize fields, add constructor.
1234         <inf>: Remove field.
1235         <reset>: New method.
1236         * infrun.c (struct displaced_step_inferior_state): Move to
1237         infrun.h.
1238         (displaced_step_inferior_states): Remove.
1239         (get_displaced_stepping_state): Adust.
1240         (displaced_step_in_progress_any_inferior): Adjust.
1241         (displaced_step_in_progress_thread): Adjust.
1242         (displaced_step_in_progress): Adjust.
1243         (add_displaced_stepping_state): Remove.
1244         (get_displaced_step_closure_by_addr): Adjust.
1245         (remove_displaced_stepping_state): Remove.
1246         (infrun_inferior_exit): Call displaced_step_state.reset.
1247         (use_displaced_stepping): Don't check for NULL.
1248         (displaced_step_prepare_throw): Call
1249         get_displaced_stepping_state.
1250         (displaced_step_fixup): Don't check for NULL.
1251         (prepare_for_detach): Don't check for NULL.
1252
1253 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1254
1255         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
1256          in case of call that did not complete.
1257
1258 2019-01-02  Andrey Utkin  <autkin@undo.io>
1259
1260         * symfile.c (find_separate_debug_file): Fix search of debug files for
1261         remote debuggee.
1262
1263 2019-01-02  Tom Tromey  <tom@tromey.com>
1264
1265         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
1266         indentation.
1267         * python/py-frame.c (frapy_older): Remove cast.
1268         (frapy_newer): Likewise.
1269         * python/py-breakpoint.c (local_setattro): Remove cast.
1270         * python/py-arch.c (archpy_name): Remove local variable.
1271         * python/py-type.c (gdbpy_lookup_type): Remove cast.
1272
1273 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
1274
1275         * unittests/basic_string_view/element_access/char/empty.cc:
1276         Fix year range in copyright header.
1277
1278 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1279
1280         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
1281         Delete.
1282         <operator==>: Update with for removed field.
1283         <hash>: Likewise.
1284         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
1285         <isa_features>: ...this.
1286         <abi_features>: New field.
1287         (riscv_isa_flen): Update comment.
1288         (riscv_abi_xlen): New declaration.
1289         (riscv_abi_flen): New declaration.
1290         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
1291         isa_features.
1292         (riscv_abi_xlen): New function.
1293         (riscv_isa_flen): Update to get answer from isa_features.
1294         (riscv_abi_flen): New function.
1295         (riscv_has_fp_abi): Update to get answer from abi_features.
1296         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
1297         xlen and flen.
1298         (riscv_call_info) <xlen, flen>: Update comment.
1299         (riscv_call_arg_struct): Remove invalid assertions
1300         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
1301         is removed.
1302         (riscv_gdbarch_init): Gather isa features and abi features
1303         separately, ensure both match on the gdbarch when reusing an old
1304         gdbarch.  Relax an error check to allow 32-bit abi float to run on
1305         a target with 64-bit float hardware.
1306
1307 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1308
1309         * source.c (search_command_helper): Stop reverse search
1310         when line 1 has been searched.
1311
1312 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1313
1314         * record-full.c (record_full_base_target::close): Rewrite
1315         record_full_core_buf_list free logic.
1316
1317 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1318
1319         * break-catch-syscall.c (print_one_catch_syscall): xfree
1320         the last text.
1321
1322 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1323
1324         * top.c (print_gdb_version): Update Copyright year in version
1325         message.
1326
1327 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1328
1329         Update copyright year range in all GDB files.
1330
1331 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
1332
1333         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
1334
1335 For older changes see ChangeLog-2018.
1336 \f
1337 Local Variables:
1338 mode: change-log
1339 left-margin: 8
1340 fill-column: 74
1341 version-control: never
1342 coding: utf-8
1343 End:
1344