gdb/ChangeLog

   1 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
   2
   3         * ppc-linux-nat.c: Add include.
   4
   5 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
   6
   7         * NEWS: Mention AArch64 Pointer Authentication.
   8
   9 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
  10
  11         * arm-linux-nat.c: Add include.
  12
  13 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
  14
  15         * source-cache.c (source_cache::get_source_lines): Re-read
  16         fullname after calling open_source_file.
  17
  18 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
  19
  20         * NEWS: Mention TLS support for FreeBSD.
  21
  22 2019-03-25  Tom Tromey  <tromey@adacore.com>
  23
  24         * minsyms.c (BUNCH_SIZE): Update comment.
  25         (~minimal_symbol_reader): Remove old comment.
  26         (compact_minimal_symbols): Update comment.
  27         (minimal_symbol_reader::install): Remove old comment.  Update
  28         other comments.
  29
  30 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
  31
  32         * s390-linux-nat.c: Add include.
  33
  34 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
  35
  36         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
  37         Call linux_get_hwcap.
  38         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
  39         Likewise.
  40         (aarch64_linux_get_hwcap): Remove function.
  41         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
  42         declaration.
  43         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
  44         linux_get_hwcap.
  45         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
  46         * linux-tdep.c (linux_get_hwcap): Add function.
  47         (linux_get_hwcap2): Likewise.
  48         * linux-tdep.h (linux_get_hwcap): Add declaration.
  49         (linux_get_hwcap2): Likewise.
  50         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
  51         (ppc_linux_get_hwcap2): Likewise.
  52         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
  53         linux_get_hwcap.
  54         (ppc_linux_nat_target::insert_watchpoint): Likewise.
  55         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
  56         (ppc_linux_nat_target::read_description): Likewise.
  57         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
  58         * s390-linux-nat.c: Likewise.
  59         * s390-linux-tdep.c (s390_core_read_description): Likewise.
  60
  61 2019-03-24  Tom Tromey  <tom@tromey.com>
  62
  63         * ada-lang.c (standard_lookup): Simplify initialization.
  64         (ada_lookup_symbol_nonlocal): Simplify return.
  65         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
  66         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
  67         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
  68         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
  69         initialization.
  70         * solib.c (solib_global_lookup): Simplify.
  71         * symtab.c (null_block_symbol): Remove.
  72         (symbol_cache_lookup): Simplify returns.
  73         (lookup_language_this): Simplify returns.
  74         (lookup_symbol_aux): Simplify return.
  75         (lookup_local_symbol): Simplify returns.
  76         (lookup_global_symbol_from_objfile): Simplify return.
  77         (lookup_symbol_in_objfile_symtabs)
  78         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
  79         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
  80         (lookup_static_symbol, lookup_global_symbol): Simplify return.
  81         * cp-namespace.c (cp_lookup_bare_symbol)
  82         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
  83         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
  84         (cp_lookup_nested_symbol): Don't use null_block_symbol.
  85         (cp_lookup_symbol_via_imports): Simplify initialization.
  86         (find_symbol_in_baseclass): Likewise.
  87         * symtab.h (null_block_symbol): Remove.
  88         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
  89         (d_lookup_nested_symbol, d_lookup_symbol_imports)
  90         (d_lookup_symbol_module): Likewise.
  91         (find_symbol_in_baseclass): Simplify initialization.
  92
  93 2019-03-24  Tom Tromey  <tom@tromey.com>
  94
  95         * expression.h: Don't include symtab.h.
  96         (struct block): Forward declare.
  97
  98 2019-03-24  Tom Tromey  <tom@tromey.com>
  99
 100         * c-exp.y (typebase): Remove casts.
 101         * gdbtypes.c (lookup_unsigned_typename, )
 102         (lookup_signed_typename): Remove cast.
 103         * eval.c (parse_to_comma_and_eval): Remove cast.
 104         * parse.c (write_dollar_variable): Remove cast.
 105         * block.h (struct block) <superblock>: Now const.
 106         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
 107         * psymtab.c (psym_map_matching_symbols): Make "block" const.
 108         (map_block): Make "block" const.
 109         * symfile.h (struct quick_symbol_functions)
 110         <map_matching_symbols>: Constify block argument to "callback".
 111         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
 112         const.
 113         (find_pc_sect_compunit_symtab): Make "b" const.
 114         (find_symbol_at_address): Likewise.
 115         (search_symbols): Likewise.
 116         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
 117         (dw2_debug_names_lookup_symbol): Likewise.
 118         (dw2_map_matching_symbols): Update.
 119         * p-valprint.c (pascal_val_print): Remove "block".
 120         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
 121         (aux_add_nonlocal_symbols): Make "block" const.
 122         (resolve_subexp): Remove cast.
 123         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
 124         const.
 125         (iterate_over_file_blocks): Likewise.
 126         * f-exp.y (%union) <bval>: Remove.
 127         * coffread.c (patch_opaque_types): Make "b" const.
 128         * spu-tdep.c (spu_catch_start): Make "block" const.
 129         * c-valprint.c (print_unpacked_pointer): Remove "block".
 130         * symmisc.c (dump_symtab_1): Make "b" const.
 131         (block_depth): Make "block" const.
 132         * d-exp.y (%union) <bval>: Remove.
 133         * cp-support.h (cp_lookup_rtti_type): Update.
 134         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
 135         * psymtab.c (psym_lookup_symbol): Make "block" const.
 136         (maintenance_check_psymtabs): Make "b" const.
 137         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
 138         (enumerate_locals, enumerate_args): Update.
 139         * python/py-symtab.c (stpy_global_block): Make "block" const.
 140         (stpy_static_block): Likewise.
 141         * inline-frame.c (block_starting_point_at): Make "new_block"
 142         const.
 143         * block.c (find_block_in_blockvector): Make return type const.
 144         (blockvector_for_pc_sect): Make "b" const.
 145         (find_block_in_blockvector): Make "b" const.
 146
 147 2019-03-23  Tom Tromey  <tom@tromey.com>
 148
 149         * varobj.c (varobj_create): Update.
 150         * symfile.c (clear_symtab_users): Don't reset innermost_block.
 151         * printcmd.c (display_command, do_one_display): Don't reset
 152         innermost_block.
 153         * parser-defs.h (enum innermost_block_tracker_type): Move to
 154         expression.h.
 155         (innermost_block): Update comment.
 156         * parse.c (parse_exp_1): Add tracker_types parameter.
 157         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
 158         tracker_types parameter.  Reset innermost_block.
 159         (parse_exp_in_context): Remove.
 160         (parse_expression_for_completion): Update.
 161         * objfiles.c (~objfile): Don't reset expression_context_block or
 162         innermost_block.
 163         * expression.h (enum innermost_block_tracker_type): Move from
 164         parser-defs.h.
 165         (parse_exp_1): Add tracker_types parameter.
 166         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
 167         reset innermost_block.
 168
 169 2019-03-23  Tom Tromey  <tom@tromey.com>
 170
 171         * objfiles.h: Include bcache.h.
 172
 173 2019-03-23  Tom Tromey  <tom@tromey.com>
 174
 175         * linespec.c (get_current_search_block): Use
 176         scoped_restore_current_language.
 177         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
 178
 179 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 180             Jiong Wang  <jiong.wang@arm.com>
 181
 182         * aarch64-linux-tdep.c
 183         (aarch64_linux_iterate_over_regset_sections): Check for pauth
 184         section.
 185         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
 186
 187 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 188             Jiong Wang  <jiong.wang@arm.com>
 189
 190         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
 191         instructions.
 192         (aarch64_analyze_prologue_test): Add PACIASP test.
 193         (aarch64_prologue_prev_register): Unmask PC value.
 194
 195 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 196             Jiong Wang  <jiong.wang@arm.com>
 197
 198         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
 199         (aarch64_dwarf2_prev_register): Unmask PC value.
 200         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
 201         (aarch64_execute_dwarf_cfa_vendor_op): Check for
 202         DW_CFA_AARCH64_negate_ra_state.
 203         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
 204
 205 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 206             Jiong Wang  <jiong.wang@arm.com>
 207
 208         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
 209         registers.
 210         (aarch64_pseudo_register_name): Likewise.
 211         (aarch64_pseudo_register_type): Likewise.
 212         (aarch64_pseudo_register_reggroup_p): Likewise.
 213         (aarch64_gdbarch_init): Add pauth registers.
 214         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
 215         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
 216         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
 217         (struct gdbarch_tdep): Add regnum for ra_state.
 218
 219 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 220             Jiong Wang  <jiong.wang@arm.com>
 221
 222         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
 223
 224 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 225             Jiong Wang  <jiong.wang@arm.com>
 226
 227         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
 228         function.
 229         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
 230         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
 231         (aarch64_gdbarch_init): Add puth registers.
 232         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
 233         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
 234         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
 235
 236 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 237             Jiong Wang  <jiong.wang@arm.com>
 238
 239         * aarch64-linux-nat.c
 240         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
 241         * aarch64-linux-tdep.c
 242         (aarch64_linux_core_read_description): Likewise.
 243         (aarch64_linux_get_hwcap): New function.
 244         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
 245         (aarch64_linux_get_hwcap): New declaration.
 246
 247 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 248             Jiong Wang  <jiong.wang@arm.com>
 249
 250         * aarch64-linux-nat.c
 251         (aarch64_linux_nat_target::read_description): Add pauth param.
 252         * aarch64-linux-tdep.c
 253         (aarch64_linux_core_read_description): Likewise.
 254         * aarch64-tdep.c (struct target_desc): Add in pauth.
 255         (aarch64_read_description): Add pauth param.
 256         (aarch64_gdbarch_init): Likewise.
 257         * aarch64-tdep.h (aarch64_read_description): Likewise.
 258         * arch/aarch64.c (aarch64_create_target_description): Likewise.
 259         * arch/aarch64.h (aarch64_create_target_description): Likewise.
 260         * features/Makefile: Add new files.
 261         * features/aarch64-pauth.c: New file.
 262         * features/aarch64-pauth.xml: New file.
 263
 264 2019-03-20  Tom Tromey  <tromey@adacore.com>
 265
 266         * infrun.c (handle_inferior_event): Rename from
 267         handle_inferior_event_1.  Create a scoped_value_mark.
 268         (handle_inferior_event): Remove.
 269
 270 2019-03-19  Tom Tromey  <tromey@adacore.com>
 271
 272         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
 273         * infrun.h (print_stop_event): Add "displays" parameter.
 274         * infrun.c (print_stop_event): Add "displays" parameter.
 275
 276 2019-03-19  Pedro Alves  <palves@redhat.com>
 277
 278         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
 279         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
 280         to -1.  Fix TABs vs spaces.
 281         (tui_ui_out::tui_ui_out): Don't initialize fields here.
 282         * tui/tui-out.h (tui_ui_out) Add intro comments.
 283         <m_line, m_start_of_line>: In-class initialize, and add describing
 284         comment.
 285
 286 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
 287
 288         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
 289         variable names.
 290         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
 291
 292 2019-03-18  Pedro Alves  <palves@redhat.com>
 293             Eli Zaretskii <eliz@gnu.org>
 294
 295         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
 296         m_line and m_start_of_line.
 297
 298 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
 299
 300         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
 301         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
 302         it returns a newline.  This fixes a regression in TU mode, whereby
 303         the next line is output on the same screen line as the user input.
 304
 305 2019-03-18  Tom Tromey  <tromey@adacore.com>
 306
 307         * minsyms.c (minimal_symbol_reader::install): Remove call to
 308         obstack_blank.
 309
 310 2019-03-18  Pedro Alves  <palves@redhat.com>
 311
 312         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
 313         New globals.
 314         (apply_style): New, factored out from ...
 315         (apply_ansi_escape): ... this.  Handle reverse video mode.
 316         (tui_set_reverse_mode): New function.
 317         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
 318         * tui/tui-winsource.c (tui_show_source_line): Use
 319         tui_set_reverse_mode instead of setting A_STANDOUT.
 320         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
 321         New setter methods.
 322
 323 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
 324
 325         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
 326         Handle tabs.
 327
 328 2019-03-18  Tom Tromey  <tromey@adacore.com>
 329
 330         * ada-lang.c (empty_array): Add "high" parameter.
 331         (ada_evaluate_subexp): Update.
 332
 333 2019-03-17  Sergei Trofimovich <siarheit@google.com>
 334
 335         * unittests/string_view-selftests.c: Define
 336         _initialize_string_view_selftests unconditionally.
 337
 338 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 339
 340         PR gdb/24350
 341         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
 342
 343 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 344
 345         PR gdb/24351
 346         * windows-nat.c (display_selector): Fix format specifiers.
 347
 348 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
 349
 350         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
 351         tui_refill_source_window instead of tui_refresh_win, to update the
 352         current execution line.  This fixes redisplay of the current line
 353         when stepping through the code with "next" or "step".
 354
 355 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 356
 357         * source-cache.c (source_cache::get_source_lines): Call
 358         find_source_lines to initialize s->nlines.  This fixes vertical
 359         scrolling of TUI source window when the DOWN arrow is pressed.
 360
 361 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 362
 363         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
 364         linux-thread-db.c (_initialize_thread_db): Likewise.
 365
 366 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 367
 368         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
 369         wclrtoeol in tui_show_source_line".  This reverts changes made in
 370         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
 371
 372 2019-03-15  Tom Tromey  <tom@tromey.com>
 373
 374         * symtab.h (struct minimal_symbol): Derive from
 375         general_symbol_info.
 376         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
 377         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
 378         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
 379         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
 380         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
 381         (MSYMBOL_SEARCH_NAME): Update.
 382         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
 383         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
 384         * minsyms.c (minimal_symbol_reader::record_full): Update.
 385
 386 2019-03-15  Tom Tromey  <tom@tromey.com>
 387
 388         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
 389
 390 2019-03-15  Tom Tromey  <tom@tromey.com>
 391
 392         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
 393         unique_xmalloc_ptr.
 394         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
 395         Update.
 396         * minsyms.c (lookup_minimal_symbol_by_pc_section)
 397         (build_minimal_symbol_hash_tables)
 398         (minimal_symbol_reader::install): Update.
 399
 400 2019-03-15  Tom Tromey  <tom@tromey.com>
 401
 402         * symtab.c (create_demangled_names_hash): Update.
 403         (symbol_set_names): Update.
 404         * objfiles.h (struct objfile_per_bfd_storage)
 405         <demangled_names_hash>: Now an htab_up.
 406         * objfiles.c (objfile_per_bfd_storage): Simplify.
 407
 408 2019-03-15  Tom Tromey  <tom@tromey.com>
 409
 410         * objfiles.h (struct objfile_per_bfd_storage): Declare
 411         destructor.
 412         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
 413         New.
 414         (get_objfile_bfd_data): Use new.  Don't initialize
 415         language_of_main.
 416         (free_objfile_per_bfd_storage): Remove.
 417         (objfile_bfd_data_free, objfile::~objfile): Use delete.
 418
 419 2019-03-15  Tom Tromey  <tom@tromey.com>
 420
 421         * symfile.c (reread_symbols): Update.
 422         * objfiles.c (objfile::objfile): Update.
 423         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
 424         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
 425         comment.
 426         (minimal_symbol_reader::install): Update.
 427         (terminate_minimal_symbol_table): Remove.
 428         * jit.c (jit_object_close_impl): Update.
 429
 430 2019-03-15  Tom Tromey  <tom@tromey.com>
 431
 432         * minsyms.c (minimal_symbol_reader::record_full): Remove some
 433         initializations.
 434
 435 2019-03-15  Tom Tromey  <tom@tromey.com>
 436
 437         * objfiles.h (struct objfile_per_bfd_storage)
 438         <demangled_hash_languages>: Now a bitset.
 439         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 440         (lookup_minimal_symbol): Update.
 441
 442 2019-03-15  Tom Tromey  <tom@tromey.com>
 443
 444         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
 445         Don't return the symbol.
 446         * coffread.c (record_minimal_symbol): Use record_full.
 447
 448 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
 449
 450         The MS-Windows port of ncurses fails to switch to a color pair if
 451         one or both of the colors are the implicit default colors.  This
 452         change records the default colors when TUI is initialized, and
 453         then specifies them explicitly when a color pair uses the default
 454         colors.  This allows color styling in TUI mode on MS-Windows.
 455
 456         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
 457         ncurses_norm_attr.
 458         (tui_initialize_io) [__MINGW32__]: Record the default terminal
 459         colors in ncurses_norm_attr.
 460         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
 461         "none", replace it with the default color recorded in
 462         ncurses_norm_attr.
 463
 464 2019-03-14  Tom Tromey  <tromey@adacore.com>
 465
 466         * source-cache.h (class source_cache) <get_source_lines>: Return
 467         std::string.
 468         * source-cache.c (source_cache::extract_lines): Handle case where
 469         first_pos==npos.  Return std::string.
 470         (source_cache::get_source_lines): Update.
 471
 472 2019-03-14  Tom Tromey  <tromey@adacore.com>
 473
 474         * NEWS: Add item for "style sources" commands.
 475         * source-cache.c (source_cache::get_source_lines): Check
 476         source_styling.
 477         * cli/cli-style.c (source_styling): New global.
 478         (_initialize_cli_style): Add "style sources" commands.
 479         (show_style_sources): New function.
 480         * cli/cli-style.h (source_styling): Declare.
 481
 482 2019-03-14  Pedro Alves  <palves@redhat.com>
 483             Tom Tromey  <tromey@adacore.com>
 484
 485         * tui/tui-winsource.h (tui_refill_source_window): Declare.
 486         * tui/tui-winsource.c (tui_refill_source_window): New function,
 487         from...
 488         (tui_horizontal_source_scroll): ... here.  Move some logic.
 489         * cli/cli-style.c (set_style_enabled): Notify new observable.
 490         * tui/tui-hooks.c (tui_redisplay_source): New function.
 491         (tui_attach_detach_observers): Attach or detach
 492         tui_redisplay_source.
 493         * observable.h (source_styling_changed): New observable.
 494         * observable.c: Define source_styling_changed observable.
 495
 496 2019-03-13  Tom Tromey  <tromey@adacore.com>
 497
 498         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
 499         (i386_gnu_nat_target::store_registers): Update.
 500         * target-debug.h (target_debug_print_std_string): New macro.
 501         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
 502         * windows-tdep.c (display_one_tib): Update.
 503         * tui/tui-stack.c (tui_make_status_line): Update.
 504         * top.c (print_inferior_quit_action): Update.
 505         * thread.c (thr_try_catch_cmd): Update.
 506         (add_thread_with_info): Update.
 507         (thread_target_id_str): Update.
 508         (thr_try_catch_cmd): Update.
 509         (thread_command): Update.
 510         (thread_find_command): Update.
 511         * record-btrace.c (record_btrace_target::info_record)
 512         (record_btrace_resume_thread, record_btrace_target::resume)
 513         (record_btrace_cancel_resume, record_btrace_step_thread)
 514         (record_btrace_target::wait, record_btrace_target::wait)
 515         (record_btrace_target::wait, record_btrace_target::stop): Update.
 516         * progspace.c (print_program_space): Update.
 517         * process-stratum-target.c
 518         (process_stratum_target::thread_address_space): Update.
 519         * linux-fork.c (linux_fork_mourn_inferior)
 520         (detach_checkpoint_command, info_checkpoints_command)
 521         (linux_fork_context): Update.
 522         (linux_fork_detach): Update.
 523         (class scoped_switch_fork_info): Update.
 524         (delete_checkpoint_command): Update.
 525         * infrun.c (follow_fork_inferior): Update.
 526         (follow_fork_inferior): Update.
 527         (proceed_after_vfork_done): Update.
 528         (handle_vfork_child_exec_or_exit): Update.
 529         (follow_exec): Update.
 530         (displaced_step_prepare_throw): Update.
 531         (displaced_step_restore): Update.
 532         (start_step_over): Update.
 533         (resume_1): Update.
 534         (clear_proceed_status_thread): Update.
 535         (proceed): Update.
 536         (print_target_wait_results): Update.
 537         (do_target_wait): Update.
 538         (context_switch): Update.
 539         (stop_all_threads): Update.
 540         (restart_threads): Update.
 541         (finish_step_over): Update.
 542         (handle_signal_stop): Update.
 543         (switch_back_to_stepped_thread): Update.
 544         (keep_going_pass_signal): Update.
 545         (print_exited_reason): Update.
 546         (normal_stop): Update.
 547         * inferior.c (inferior_pid_to_str): Change return type.
 548         (print_selected_inferior): Update.
 549         (add_inferior): Update.
 550         (detach_inferior): Update.
 551         * dummy-frame.c (fprint_dummy_frames): Update.
 552         * dcache.c (dcache_info_1): Update.
 553         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
 554         (btrace_fetch, btrace_clear): Update.
 555         * linux-tdep.c (linux_core_pid_to_str): Change return type.
 556         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
 557         type.
 558         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
 559         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
 560         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
 561         * gdbarch.c, gdbarch.h: Rebuild.
 562         * gdbarch.sh (core_pid_to_str): Change return type.
 563         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
 564         return type.
 565         (windows_nat_target::pid_to_str): Change return type.
 566         (windows_delete_thread): Update.
 567         (windows_nat_target::attach): Update.
 568         (windows_nat_target::files_info): Update.
 569         * target-delegates.c: Rebuild.
 570         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
 571         return type.
 572         (sol_thread_target::pid_to_str): Change return type.
 573         * remote.c (class remote_target) <pid_to_str>: Change return
 574         type.
 575         (remote_target::pid_to_str): Change return type.
 576         (extended_remote_target::attach, remote_target::remote_stop_ns)
 577         (remote_target::remote_notif_remove_queued_reply)
 578         (remote_target::push_stop_reply, remote_target::disable_btrace):
 579         Update.
 580         (extended_remote_target::attach): Update.
 581         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
 582         type.
 583         (gdbsim_target::pid_to_str): Change return type.
 584         * ravenscar-thread.c (struct ravenscar_thread_target)
 585         <pid_to_str>: Change return type.
 586         (ravenscar_thread_target::pid_to_str): Change return type.
 587         * procfs.c (class procfs_target) <pid_to_str>: Change return
 588         type.
 589         (procfs_target::pid_to_str): Change return type.
 590         (procfs_target::attach): Update.
 591         (procfs_target::detach): Update.
 592         (procfs_target::fetch_registers): Update.
 593         (procfs_target::store_registers): Update.
 594         (procfs_target::wait): Update.
 595         (procfs_target::files_info): Update.
 596         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
 597         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
 598         return type.
 599         (nto_procfs_target::pid_to_str): Change return type.
 600         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
 601         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
 602         return type.
 603         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
 604         (exit_lwp): Update.
 605         (attach_proc_task_lwp_callback, get_detach_signal)
 606         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
 607         (linux_nat_target::resume, wait_lwp, stop_callback)
 608         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
 609         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
 610         (linux_nat_wait_1, resume_stopped_resumed_lwps)
 611         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
 612         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
 613         type.
 614         (inf_ptrace_target::attach): Update.
 615         (inf_ptrace_target::files_info): Update.
 616         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
 617         type.
 618         (go32_nat_target::pid_to_str): Change return type.
 619         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
 620         (gnu_nat_target::wait): Update.
 621         (gnu_nat_target::wait): Update.
 622         (gnu_nat_target::resume): Update.
 623         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
 624         (fbsd_nat_target::wait): Update.
 625         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
 626         type.
 627         (darwin_nat_target::attach): Update.
 628         * corelow.c (class core_target) <pid_to_str>: Change return type.
 629         (core_target::pid_to_str): Change return type.
 630         * target.c (normal_pid_to_str): Change return type.
 631         (default_pid_to_str): Likewise.
 632         (target_pid_to_str): Change return type.
 633         (target_translate_tls_address): Update.
 634         (target_announce_detach): Update.
 635         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
 636         return type.
 637         (bsd_uthread_target::pid_to_str): Change return type.
 638         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
 639         type.
 640         (bsd_kvm_target::pid_to_str): Change return type.
 641         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
 642         return type.
 643         (aix_thread_target::pid_to_str): Change return type.
 644         * target.h (struct target_ops) <pid_to_str>: Change return type.
 645         (target_pid_to_str, normal_pid_to_str): Likewise.
 646         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
 647         type.
 648         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
 649         type.
 650         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
 651         return type.
 652         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
 653         type.
 654         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
 655         type.
 656         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
 657         return type.
 658
 659 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
 660
 661         * NEWS: Mention that the new default MI version is 3.  Mention
 662         changes to the output of commands and events that deal with
 663         multi-location breakpoints.
 664         * breakpoint.c: Include "mi/mi-out.h".
 665         (print_one_breakpoint): Change output syntax if using MI version
 666         >= 3.
 667         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
 668         New.
 669         (mi_multi_location_breakpoint_output_fixed): New.
 670         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
 671         (mi_cmd_fix_multi_location_breakpoint_output): New.
 672         (mi_multi_location_breakpoint_output_fixed): New.
 673         * mi/mi-cmds.c (mi_cmds): Register command
 674         -fix-multi-location-breakpoint-output.
 675         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
 676         interpreter "mi".
 677
 678 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
 679
 680         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
 681         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
 682         instantiate mi_ui_out based on interpreter name.
 683         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
 684         * mi/mi-main.c (mi_load_progress): Likewise.
 685
 686 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 687
 688         * NEWS: Combine separate "New targets" sections for 8.3.
 689
 690 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 691
 692         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
 693         (ppcfbsd_init_abi): Install gdbarch
 694         "fetch_tls_load_module_address" and "get_thread_local_address"
 695         methods.
 696
 697 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 698
 699         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
 700         (riscv_fbsd_init_abi): Install gdbarch
 701         "fetch_tls_load_module_address" and "get_thread_local_address"
 702         methods.
 703
 704 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 705
 706         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
 707         (i386fbsd_init_abi): Install gdbarch
 708         "fetch_tls_load_module_address" and "get_thread_local_address"
 709         methods.
 710
 711 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 712
 713         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
 714         (amd64fbsd_init_abi): Install gdbarch
 715         "fetch_tls_load_module_address" and "get_thread_local_address"
 716         methods.
 717
 718 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 719
 720         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
 721         (struct fbsd_pspace_data): New type.
 722         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
 723         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
 724         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
 725         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
 726         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
 727
 728 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 729
 730         * gdbtypes.c (lookup_struct_elt): New function.
 731         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
 732         * gdbtypes.h (struct struct_elt): New type.
 733         (lookup_struct_elt): New prototype.
 734
 735 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 736
 737         * gdbtypes.c (lookup_struct_elt_type): Update comment and
 738         remove disabled code block.
 739
 740 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 741
 742         * gdbarch.sh (get_thread_local_address): New method.
 743         * gdbarch.h, gdbarch.c: Regenerate.
 744         * target.c (target_translate_tls_address): Use
 745         gdbarch_get_thread_local_address if present instead of
 746         target::get_thread_local_address.
 747
 748 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 749
 750         * target.h (target::get_thread_local_address): Update comment.
 751
 752 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 753
 754         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
 755         objfile->separate_debug_objfile_backlink if not NULL.
 756
 757 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 758
 759         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
 760         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
 761         (amd64bsd_store_inferior_registers): Likewise.
 762         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 763         Enable segment base registers.
 764         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
 765         PT_GETFSBASE and PT_GETGSBASE.
 766         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
 767         PT_SETGSBASE.
 768         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
 769         segment base registers.
 770         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 771
 772 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 773
 774         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 775         Update calls to i386_target_description to add 'segments'
 776         parameter.
 777         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
 778         add segment base registers.
 779         * arch/i386.c (i386_create_target_description): Add 'segments'
 780         parameter to enable segment base registers.
 781         * arch/i386.h (i386_create_target_description): Likewise.
 782         * features/i386/32bit-segments.xml: New file.
 783         * features/i386/32bit-segments.c: Generate.
 784         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
 785         call to i386_target_description to add 'segments' parameter.
 786         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 787         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
 788         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
 789         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
 790         if feature is present.
 791         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
 792         Add 'segments' parameter to call to i386_target_description.
 793         (i386_target_description): Add 'segments' parameter to enable
 794         segment base registers.
 795         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
 796         to call to i386_target_description.
 797         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
 798         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
 799         Define I386_NUM_REGS.
 800         (i386_target_description): Add 'segments' parameter to enable
 801         segment base registers.
 802
 803 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 804
 805         PR/24325
 806         * source-cache.c: #undef open and close, to avoid unresolved
 807         externals during linking.
 808
 809 2019-03-12  Tom Tromey  <tromey@adacore.com>
 810
 811         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
 812         const.  Add initializers.
 813         (_initialize_remote): Don't initialize ptid globals.
 814
 815 2019-03-12  Pedro Alves  <palves@redhat.com>
 816
 817         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
 818
 819 2019-03-12  Pedro Alves  <palves@redhat.com>
 820
 821         * cp-name-parser.y (main): Remove unused 'len' variable.
 822
 823 2019-03-12  Tom Tromey  <tromey@adacore.com>
 824
 825         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
 826         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
 827
 828 2019-03-12  Tom Tromey  <tromey@adacore.com>
 829
 830         * linux-nat.c (iterate_over_lwps): Update.
 831         (stop_callback): Remove parameter.
 832         (stop_wait_callback, detach_callback, resume_set_callback)
 833         (select_singlestep_lwp_callback, set_ignore_sigint)
 834         (status_callback, resumed_callback, resume_clear_callback)
 835         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
 836         data parameter.
 837         (linux_nat_target::detach, linux_nat_target::resume)
 838         (linux_stop_and_wait_all_lwps, select_event_lwp)
 839         (linux_nat_filter_event, linux_nat_wait_1)
 840         (linux_nat_target::kill, linux_nat_target::stop)
 841         (linux_nat_target::stop): Update.
 842         (linux_nat_resume_callback): Change type.
 843         (resume_stopped_resumed_lwps, count_events_callback)
 844         (select_event_lwp_callback): Likewise.
 845         (linux_stop_lwp, linux_nat_stop_lwp): Update.
 846         * arm-linux-nat.c (struct update_registers_data): Remove.
 847         (update_registers_callback): Change type.
 848         (arm_linux_insert_hw_breakpoint1): Update.
 849         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
 850         parameter.
 851         (x86_linux_dr_set_addr): Update.
 852         (x86_linux_dr_set_control): Update.
 853         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
 854         (iterate_over_lwps): Use gdb::function_view.
 855         * nat/aarch64-linux-hw-point.c (struct
 856         aarch64_dr_update_callback_param): Remove.
 857         (debug_reg_change_callback): Change type.
 858         (aarch64_notify_debug_reg_change): Update.
 859         * s390-linux-nat.c (s390_refresh_per_info): Update.
 860
 861 2019-03-11  Tom Tromey  <tromey@adacore.com>
 862
 863         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
 864         redundant assignment to "this_cu".
 865
 866 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 867
 868         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
 869
 870 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 871
 872         * gdbtypes.c (rank_one_type_parm_set): New function extracted
 873         from...
 874         (rank_one_type): ... this.
 875
 876 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 877
 878         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
 879         from...
 880         (rank_one_type): ... this.
 881
 882 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 883
 884         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
 885         from...
 886         (rank_one_type): ... this.
 887
 888 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 889
 890         * gdbtypes.c (rank_one_type_parm_float): New function extracted
 891         from...
 892         (rank_one_type): ... this.
 893
 894 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 895
 896         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
 897         from...
 898         (rank_one_type): ... this.
 899
 900 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 901
 902         * gdbtypes.c (rank_one_type_parm_range): New function extracted
 903         from...
 904         (rank_one_type): ... this.
 905
 906 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 907
 908         * gdbtypes.c (rank_one_type_parm_char): New function extracted
 909         from...
 910         (rank_one_type): ... this.
 911
 912 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 913
 914         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
 915         from...
 916         (rank_one_type): ... this.
 917
 918 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 919
 920         * gdbtypes.c (rank_one_type_parm_int): New function extracted
 921         from...
 922         (rank_one_type): ... this.
 923
 924 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 925
 926         * gdbtypes.c (rank_one_type_parm_func): New function extracted
 927         from...
 928         (rank_one_type): ... this.
 929
 930 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 931
 932         * gdbtypes.c (rank_one_type_parm_array): New function extracted
 933         from...
 934         (rank_one_type): ... this.
 935
 936 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 937
 938         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
 939         from...
 940         (rank_one_type): ... this.
 941
 942 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 943
 944         * inferior.c (initialize_inferiors): Ensure 'help set/show print
 945         inferior-events' shows the example events.
 946
 947 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
 948
 949         Support styling on native MS-Windows console
 950
 951         PR/24315
 952         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
 953         on MS-Windows if $TERM is not defined.
 954
 955         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
 956
 957         * posix-hdep.c (gdb_console_fputs):
 958         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
 959         functions.
 960         * ui-file.h (gdb_console_fputs): Add prototype.
 961
 962         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
 963         back to fputs only if the former returns zero.
 964
 965 2019-03-07  Tom Tromey  <tom@tromey.com>
 966
 967         * symmisc.c (print_symbol_bcache_statistics): Update.
 968         (print_objfile_statistics): Update.
 969         * symfile.c (allocate_symtab): Update.
 970         * stabsread.c: Don't include bcache.h.
 971         * psymtab.h (struct psymbol_bcache): Don't declare.
 972         (class psymtab_storage) <psymbol_cache>: Now a bcache.
 973         (psymbol_bcache_init, psymbol_bcache_free)
 974         (psymbol_bcache_get_bcache): Don't declare.
 975         * psymtab.c (struct psymbol_bcache): Remove.
 976         (psymtab_storage::psymtab_storage): Update.
 977         (psymtab_storage::~psymtab_storage): Update.
 978         (psymbol_bcache_init, psymbol_bcache_free)
 979         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
 980         (add_psymbol_to_bcache): Update.
 981         (allocate_psymtab): Update.
 982         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
 983         macro_cache>: No longer pointers.
 984         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
 985         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
 986         * macrotab.c (macro_bcache): Update.
 987         * macroexp.c: Don't include bcache.h.
 988         * gdbtypes.c (check_types_worklist): Update.
 989         (types_deeply_equal): Remove TRY/CATCH.  Update.
 990         * elfread.c (elf_symtab_read): Update.
 991         * dwarf2read.c: Don't include bcache.h.
 992         * buildsym.c (buildsym_compunit::get_macro_table): Update.
 993         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
 994         (print_bcache_statistics, bcache_memory_used): Don't declare.
 995         (struct bcache): Move from bcache.c.  Add constructor, destructor,
 996         methods.  Rename all data members.
 997         * bcache.c (struct bcache): Move to bcache.h.
 998         (bcache::expand_hash_table): Rename from expand_hash_table.
 999         (bcache): Remove.
1000         (bcache::insert): Rename from bcache_full.
1001         (bcache::compare): Rename from bcache_compare.
1002         (bcache_xmalloc): Remove.
1003         (bcache::~bcache): Rename from bcache_xfree.
1004         (bcache::print_statistics): Rename from print_bcache_statistics.
1005         (bcache::memory_used): Rename from bcache_memory_used.
1006
1007 2019-03-07  Pedro Alves  <palves@redhat.com>
1008
1009         * infrun.c (normal_stop): Also check for
1010         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
1011
1012 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
1013
1014         * f-lang.c (value_from_host_double): Moved to...
1015         * value.c (value_from_host_double): ...here.
1016         * value.h (value_from_host_double): Declare.
1017         * guile/scm-math.c (vlscm_convert_typed_number): Use
1018         value_from_host_double.
1019         (vlscm_convert_number): Likewise.
1020         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
1021         * python/py-value.c (convert_value_from_python): Likewise.
1022
1023 2019-03-06  Tom Tromey  <tom@tromey.com>
1024
1025         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
1026
1027 2019-03-06  Tom Tromey  <tom@tromey.com>
1028
1029         * utils.h (free_current_contents): Don't declare.
1030         * utils.c (free_current_contents): Remove.
1031
1032 2019-03-06  Tom Tromey  <tom@tromey.com>
1033
1034         * top.c (quit_force): Update.
1035         * main.c (captured_command_loop): Update.
1036         * common/new-op.c (operator new): Update.
1037         * common/common-exceptions.c (struct catcher)
1038         <save_cleanup_chain>: Remove member.
1039         (exceptions_state_mc_init): Update.
1040         (exception_try_scope_entry): Return nullptr.
1041         (exception_try_scope_exit, exception_rethrow)
1042         (throw_exception_sjlj, throw_exception_cxx): Update.
1043         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
1044         (all_cleanups, do_cleanups, discard_cleanups)
1045         (discard_final_cleanups, save_cleanups, save_final_cleanups)
1046         (restore_cleanups, restore_final_cleanups): Don't declare.
1047         (do_final_cleanups): Remove parameter.
1048         * common/cleanups.c (cleanup_chain, make_cleanup)
1049         (make_cleanup_dtor, all_cleanups, do_cleanups)
1050         (discard_my_cleanups, discard_cleanups)
1051         (discard_final_cleanups, save_my_cleanups, save_cleanups)
1052         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
1053         (null_cleanup): Remove.
1054         (do_final_cleanups): Remove parameter.
1055
1056 2019-03-06  Tom Tromey  <tom@tromey.com>
1057
1058         * remote.c (remote_target::remote_parse_stop_reply): Use
1059         unique_xmalloc_ptr.
1060
1061 2019-03-06  Tom Tromey  <tom@tromey.com>
1062
1063         * stabsread.c (struct stabs_field_info): Rename from field_info.
1064         <list, fnlist>: Add initializers.
1065         <obstack>: New member.
1066         (read_member_functions, read_struct_fields, read_baseclasses):
1067         Allocate on obstack.  Don't use cleanups.
1068         (read_one_struct_field, read_member_functions, read_struct_fields)
1069         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
1070         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
1071         (read_struct_type): Update.
1072
1073 2019-03-06  Tom Tromey  <tom@tromey.com>
1074
1075         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
1076         * common/filestuff.h (make_cleanup_close): Don't declare.
1077         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
1078         Remove.
1079
1080 2019-03-06  Tom Tromey  <tom@tromey.com>
1081
1082         * solib-aix.c: Use make_scope_exit.
1083
1084 2019-03-06  Tom Tromey  <tom@tromey.com>
1085
1086         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
1087         Use make_scope_exit.
1088
1089 2019-03-06  Tom Tromey  <tom@tromey.com>
1090
1091         * solib-svr4.c (disable_probes_interface): Remove parameter.
1092         (svr4_handle_solib_event): Use make_scope_exit.
1093
1094 2019-03-06  Tom Tromey  <tom@tromey.com>
1095
1096         * remote.c (struct stop_reply_deleter): Remove.
1097         (stop_reply_up): Update.
1098         (struct stop_reply): Derive from notif_event.  Don't typedef.
1099         <regcache>: Now a std::vector.
1100         (stop_reply_xfree): Remove.
1101         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
1102         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
1103         (remote_target::discard_pending_stop_replies): Use delete.
1104         (remote_target::remote_parse_stop_reply): Update.
1105         (remote_target::process_stop_reply): Update.
1106         * remote-notif.h (struct notif_event): Add virtual destructor.
1107         Remove "dtr" member.
1108         (struct notif_client) <alloc_event>: Return a unique_ptr.
1109         (notif_event_xfree): Don't declare.
1110         (notif_event_up): New typedef.
1111         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
1112         (notif_event_xfree, do_notif_event_xfree): Remove.
1113         (remote_notif_state_xfree): Update.
1114
1115 2019-03-06  Tom Tromey  <tom@tromey.com>
1116
1117         * infrun.c (displaced_step_clear_cleanup): Now a
1118         forward_scope_exit type.
1119         (displaced_step_prepare_throw): Update.
1120         (displaced_step_fixup): Update.
1121
1122 2019-03-06  Tom Tromey  <tom@tromey.com>
1123
1124         * inferior.h (class inferior): Update comment.
1125         * gdbthread.h (class thread_info): Update comment.
1126
1127 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
1128             Tom Tromey  <tom@tromey.com>
1129
1130         * stabsread.h (struct stab_section_list): Remove.
1131         (coffstab_build_psymtabs): Update.
1132         * dbxread.c (symbuf_sections): Now a std::vector.
1133         (sect_idx): New global.
1134         (fill_symbuf): Update.
1135         (coffstab_build_psymtabs): Change type of stabsects parameter.
1136         Update.
1137         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
1138         std::vector.
1139         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
1140         (coff_locate_sections): Update.
1141         (coff_symfile_read): Remove cleanups.  Update.
1142         (init_stringtab): Add storage parameter.
1143         (free_stringtab, free_stringtab_cleanup): Remove.
1144         (init_lineno): Add storage parameter.
1145         (free_linetab, free_linetab_cleanup): Remove.
1146
1147 2019-03-06  Pedro Alves  <palves@redhat.com>
1148
1149         * linux-fork.c (fork_info::clobber_regs): Delete.
1150         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
1151         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
1152         comment.  Adjust.
1153         (scoped_switch_fork_info::scoped_switch_fork_info)
1154         (checkpoint_command, linux_fork_context): Adjust
1155         fork_save_infrun_state calls.
1156
1157 2019-03-06  Pedro Alves  <palves@redhat.com>
1158
1159         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
1160         (inf_has_multiple_threads): Return 'bool' and rewrite using
1161         inferior_info::threads().
1162
1163 2019-03-06  Pedro Alves  <palves@redhat.com>
1164
1165         * linux-fork.c: Include <list>.
1166         (fork_list): Now a std::list instance.
1167         (fork_info): Add ctor, dtor, and in-class initialize all fields.
1168         (forks_exist_p, find_last_fork): Adjust.
1169         (new_fork): Delete.
1170         (one_fork_p): New.
1171         (add_fork): Adjust.
1172         (free_fork): Delete, folded into fork_info::~fork_info().
1173         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
1174         Adjust.
1175         (init_fork_list): Delete.
1176         (linux_fork_killall, linux_fork_mourn_inferior)
1177         (linux_fork_detach, info_checkpoints_command): Adjust.
1178         (_initialize_linux_fork): No longer call init_fork_list.
1179
1180 2019-03-06  Pedro Alves  <palves@redhat.com>
1181
1182         * linux-fork.c (new_fork): New, split out of ...
1183         (add_fork): ... this.  Return void.  Move "first fork" special
1184         case from here, to ...
1185         (checkpoint_command): ... here.
1186         * linux-linux.h (add_fork): Return void.
1187
1188 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1189
1190         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
1191
1192 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1193             Chris January  <chris.january@arm.com>
1194             David Lecomber  <david.lecomber@arm.com>
1195
1196         * f-exp.y: New token, UNOP_INTRINSIC.
1197         (exp): New pattern using UNOP_INTRINSIC token.
1198         (f77_keywords): Add 'abs' keyword.
1199         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
1200         (value_from_host_double): New function.
1201         (evaluate_subexp_f): Support UNOP_ABS.
1202
1203 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1204
1205         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
1206         types.
1207
1208 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1209
1210         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
1211         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
1212         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
1213
1214 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1215
1216         * f-exp.y (convert_to_kind_type): Handle more type kinds.
1217
1218 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1219             Chris January  <chris.january@arm.com>
1220
1221         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
1222         * f-exp.y: Define 'KIND' token.
1223         (exp): New pattern for KIND expressions.
1224         (ptype): Handle types with a kind extension.
1225         (direct_abs_decl): Extend to spot kind extensions.
1226         (f77_keywords): Add 'kind' to the list.
1227         (push_kind_type): New function.
1228         (convert_to_kind_type): New function.
1229         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
1230         * parse.c (operator_length_standard): Likewise.
1231         * parser-defs.h (enum type_pieces): Add tp_kind.
1232         * std-operator.def: Add UNOP_KIND.
1233
1234 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1235
1236         * f-exp.y (f_parse): Set yydebug.
1237
1238 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1239
1240         * f-lang.c (evaluate_subexp_f): New function.
1241         (exp_descriptor_f): New global.
1242         (f_language_defn): Use exp_descriptor_f instead of
1243         exp_descriptor_standard.
1244
1245 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1246
1247         * f-exp.y (struct token): Add comments.
1248         (dot_ops): Remove uppercase versions and the end marker.
1249         (f77_keywords): Likewise.
1250         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
1251         entries in the dot_ops array are case insensitive, and use
1252         strncasecmp to compare strings.  Also some whitespace cleanup in
1253         this area.  Similar for the f77_keywords array, except entries in
1254         this list might be case sensitive.
1255
1256 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1257
1258         * f-exp.y (struct f77_boolean_val): Add comments.
1259         (boolean_values): Remove uppercase versions, and end marker.
1260         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
1261         and use strncasecmp to achieve case insensitivity.  Additionally,
1262         perform whitespace cleanup around this code.
1263
1264 2019-03-06  Tom Tromey  <tromey@adacore.com>
1265
1266         * remote-sim.c (gdbsim_target_open): Use result of
1267         gdb_argv::release.
1268
1269 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
1270         Dirk Schubert  <dirk.schubert@arm.com>
1271         Chris January  <chris.january@arm.com>
1272
1273         * eval.c (evaluate_subexp_standard): Call Fortran argument
1274         wrapping logic.
1275         * f-lang.c (struct value): A value which can be passed into a
1276         Fortran function call.
1277         (fortran_argument_convert): Wrap Fortran arguments in a pointer
1278         where appropriate.
1279         (struct type): Value ready for a Fortran function call.
1280         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
1281         is needed.
1282         * f-lang.h (fortran_argument_convert): Declaration.
1283         (fortran_preserve_arg_pointer): Declaration.
1284         * infcall.c (value_arg_coerce): Call Fortran argument logic.
1285
1286 2019-03-05  Tom Tromey  <tromey@adacore.com>
1287
1288         * python/py-prettyprint.c (print_string_repr): Remove #if.
1289         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
1290
1291 2019-03-05  Tom Tromey  <tromey@adacore.com>
1292
1293         * target.c (the_dummy_target): Move later.  Change type to
1294         "dummy_target".
1295         (initialize_targets): Don't initialize the_dummy_target.
1296
1297 2019-03-05  Tom Tromey  <tromey@adacore.com>
1298
1299         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
1300         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
1301
1302 2019-03-05  Tom Tromey  <tromey@adacore.com>
1303
1304         * windows-nat.c (windows_nat_target::attach)
1305         (windows_nat_target::detach): Don't call gdb_flush.
1306         * valprint.c (generic_val_print, val_print, val_print_string):
1307         Don't call gdb_flush.
1308         * utils.c (defaulted_query): Don't call gdb_flush.
1309         * typeprint.c (print_type_scalar): Don't call gdb_flush.
1310         * target.c (target_announce_detach): Don't call gdb_flush.
1311         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
1312         * remote.c (extended_remote_target::attach): Don't call
1313         gdb_flush.
1314         * procfs.c (procfs_target::detach): Don't call gdb_flush.
1315         * printcmd.c (do_examine): Don't call gdb_flush.
1316         (info_display_command): Don't call gdb_flush.
1317         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
1318         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
1319         * memattr.c (info_mem_command): Don't call gdb_flush.
1320         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
1321         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
1322         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
1323         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
1324         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
1325         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
1326         (gnu_nat_target::detach): Don't call gdb_flush.
1327         * f-valprint.c (f_val_print): Don't call gdb_flush.
1328         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
1329         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
1330         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
1331         gdb_flush.
1332         * c-valprint.c (c_val_print): Don't call gdb_flush.
1333         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
1334
1335 2019-03-05  Tom Tromey  <tromey@adacore.com>
1336
1337         * varobj.c (update_dynamic_varobj_children): Update.
1338         (install_default_visualizer): Use reset, not release.
1339         * value.c (set_internalvar): Update.
1340         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
1341         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
1342         ATTRIBUTE_UNUSED_RESULT.
1343
1344 2019-03-05  Tom Tromey  <tromey@adacore.com>
1345
1346         * remote.c (class scoped_remote_fd) <release>: Add
1347         ATTRIBUTE_UNUSED_RESULT.
1348
1349 2019-03-05  Tom Tromey  <tromey@adacore.com>
1350
1351         * macroexp.c (struct macro_buffer) <release>: Add
1352         ATTRIBUTE_UNUSED_RESULT.
1353
1354 2019-03-05  Tom Tromey  <tromey@adacore.com>
1355
1356         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
1357         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
1358         ATTRIBUTE_UNUSED_RESULT.
1359
1360 2019-03-05  Tom Tromey  <tromey@adacore.com>
1361
1362         * common/scoped_fd.h (class scoped_fd) <release>: Add
1363         ATTRIBUTE_UNUSED_RESULT.
1364
1365 2019-03-05  Tom Tromey  <tromey@adacore.com>
1366
1367         * parser-defs.h (struct parser_state) <release>: Add
1368         ATTRIBUTE_UNUSED_RESULT.
1369
1370 2019-03-05  Tom Tromey  <tromey@adacore.com>
1371
1372         * utils.h (class gdb_argv) <release>: Add
1373         ATTRIBUTE_UNUSED_RESULT.
1374         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
1375
1376 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
1377
1378         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
1379         for-loop range, to avoid compiler warnings.
1380
1381         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
1382         avoid compiler warnings about unused variables.
1383
1384         * NEWS: Mention end of support for native debugging on MS-Windows
1385         before XP.
1386
1387         PR gdb/24292
1388         * common/netstuff.c:
1389         * gdbserver/gdbreplay.c
1390         * gdbserver/remote-utils.c:
1391         * ser-tcp.c:
1392         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
1393         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
1394         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
1395         'getaddrinfo' and 'freeaddrinfo' were not available before
1396         Windows XP, and mingw.org's MinGW headers by default define
1397         _WIN32_WINNT to 0x500.
1398
1399 2019-03-01  Gary Benson <gbenson@redhat.com>
1400
1401         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
1402
1403 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
1404             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1405
1406         PR gdb/8527
1407         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
1408         set_sigint_trap, clear_sigint_trap.
1409
1410 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1411
1412         * target.c (target_detach): Clear the regcache and the
1413         frame cache.
1414
1415 2019-02-27  Pedro Alves  <palves@redhat.com>
1416
1417         * utils.c (set_screen_size): When we cap the height/width sizes,
1418         tweak the corresponding command variable to show "unlimited":
1419
1420 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
1421             Pedro Alves  <palves@redhat.com>
1422
1423         * utils.c (set_screen_size): Reduce "infinite" rows and columns
1424         before calling rl_set_screen_size.
1425
1426 2019-02-27  Tom Tromey  <tromey@adacore.com>
1427
1428         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
1429         define.
1430         * python/py-value.c: Remove Python 2.4 workaround.
1431         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
1432         workaround.
1433         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
1434         Python 2.4 workaround.
1435         * python/python-internal.h: Remove Python 2.4 comment.
1436         (Py_ssize_t): Don't define.
1437         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
1438         (gdb_Py_DECREF): Remove Python 2.4 workaround.
1439         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
1440         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
1441         * python/python.c (do_start_initialization): Remove Python 2.4
1442         workaround.
1443         * python/py-prettyprint.c (class dummy_python_frame): Remove.
1444         (print_children): Remove Python 2.4 workaround.
1445         * python/py-inferior.c (buffer_procs): Remove Python 2.4
1446         workaround.
1447         (CHARBUFFERPROC_NAME): Remove.
1448         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
1449         Python 2.4 workaround.
1450
1451 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1452
1453         * NEWS: Note minimum Python version.
1454
1455 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1456
1457         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
1458         code from these functions.  Remove corresponding ifdefs.  Use
1459         Py_buffer_up instead of explicit calls to PyBuffer_Release.
1460         Remove gotos and target of gotos.
1461         (infpy_search_memory): Likewise.
1462
1463 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1464
1465         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
1466         (hppa_gdbarch_init): Don't register deleted functions with
1467         gdbarch.
1468
1469 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1470
1471         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
1472         (h8300_unwind_sp): Delete.
1473         (h8300_dummy_id): Delete.
1474         (h8300_gdbarch_init): Don't register deleted functions with
1475         gdbarch.
1476
1477 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1478
1479         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
1480         (ft32_unwind_pc): Delete.
1481         (ft32_unwind_sp): Delete.
1482         (ft32_gdbarch_init): Don't register deleted functions with
1483         gdbarch.
1484
1485 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1486
1487         * gdb/frv-tdep.c (frv_dummy_id): Delete.
1488         (frv_unwind_pc): Delete.
1489         (frv_unwind_sp): Delete.
1490         (frv_gdbarch_init): Don't register deleted functions with
1491         gdbarch.
1492
1493 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1494
1495         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1496         (riscv_unwind_pc): Delete.
1497         (riscv_unwind_sp): Delete.
1498         (riscv_gdbarch_init): Don't register deleted functions with
1499         gdbarch.
1500
1501 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1502
1503         * gdb/csky-tdep.c (csky_dummy_id): Delete.
1504         (csky_unwind_pc): Delete.
1505         (csky_unwind_sp): Delete.
1506         (csky_gdbarch_init): Don't register deleted functions with
1507         gdbarch.
1508
1509 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1510
1511         * gdb/cris-tdep.c (cris_dummy_id): Delete.
1512         (cris_unwind_pc): Delete.
1513         (cris_unwind_sp): Delete.
1514         (cris_gdbarch_init): Don't register deleted functions with
1515         gdbarch.
1516
1517 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1518
1519         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1520         (bfin_unwind_pc): Delete.
1521         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1522
1523 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1524
1525         * gdb/arm-tdep.c (arm_dummy_id): Delete.
1526         (arm_unwind_pc): Delete.
1527         (arm_unwind_sp): Delete.
1528         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1529
1530 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1531
1532         * gdb/arc-tdep.c (arc_dummy_id): Delete.
1533         (arc_unwind_pc): Delete.
1534         (arc_unwind_sp): Delete.
1535         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1536
1537 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1538
1539         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1540         (alpha_unwind_pc): Delete.
1541         (alpha_gdbarch_init): Don't register deleted functions with
1542         gdbarch.
1543
1544 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1545
1546         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1547         (aarch64_unwind_pc): Delete.
1548         (aarch64_unwind_sp): Delete.
1549         (aarch64_gdbarch_init): Don't register deleted functions with
1550         gdbarch.
1551
1552 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1553
1554         * gdbtypes.c (type_align): Don't consider static members when
1555         computing structure alignment.
1556
1557 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1558
1559         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1560         return 0 for other types.
1561         * arch-utils.c (default_type_align): Always return 0.
1562         * gdbarch.h: Regenerate.
1563         * gdbarch.sh (type_align): Extend comment.
1564         * gdbtypes.c (type_align): Add additional comments, always call
1565         gdbarch_type_align before applying the default rules.
1566         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
1567         generic code will then apply a suitable default.
1568         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
1569         types, return 0 for other types.
1570
1571 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1572
1573         * NEWS: Create a new section for the next release branch.
1574         Rename the section of the current branch, now that it has
1575         been cut.
1576
1577 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1578
1579         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
1580         * version.in: Bump version to 8.3.50.DATE-git.
1581
1582 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
1583
1584         * aix-thread.c (ptid_cmp): Remove unused variable.
1585         (get_signaled_thread): Likewise.
1586         (store_regs_user_thread): Likewise.
1587         (store_regs_kernel_thread): Likewise.
1588         (fetch_regs_kernel_thread): Remove shadowed variable.
1589
1590 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1591
1592         * features/riscv/32bit-cpu.xml: Add register numbers.
1593         * features/riscv/32bit-fpu.c: Regenerate.
1594         * features/riscv/32bit-fpu.xml: Add register numbers.
1595         * features/riscv/64bit-cpu.xml: Add register numbers.
1596         * features/riscv/64bit-fpu.c: Regenerate.
1597         * features/riscv/64bit-fpu.xml: Add register numbers.
1598
1599 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
1600
1601         * NEWS: Mention two argument form of gdb.Value constructor.
1602         * python/py-value.c (convert_buffer_and_type_to_value): New
1603         function.
1604         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
1605         Add support for handling an optional second argument.  Call
1606         convert_buffer_and_type_to_value as appropriate.
1607         * python/python-internal.h (Py_buffer_deleter): New struct.
1608         (Py_buffer_up): New typedef.
1609
1610 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
1611
1612         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
1613         instead of releasing ownership.
1614
1615 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
1616
1617         * dwarf2read.c (open_and_init_dwp_file): Call
1618         elf_numsections instead of bfd_count_sections to initialize
1619         dwp_file->num_sections.
1620
1621 2019-02-25  Tom Tromey  <tromey@adacore.com>
1622
1623         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
1624
1625 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1626
1627         * gcore.in: Add '--readnever' option when invoking GDB.
1628
1629 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1630
1631         * MAINTAINERS: Update my email address.
1632
1633 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1634
1635         * build-id.c (build_id_to_debug_bfd_1): New function.
1636         (build_id_to_debug_bfd): Look for separate debug file in
1637         sysroot.
1638
1639 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1640
1641         * gdbarch.sh: Update the copyright year range that is placed into
1642         generated files.
1643
1644 2019-02-22  Keith Seitz  <keiths@redhat.com>
1645
1646         PR symtab/23853
1647         * linespec.c (create_sals_line_offset): Search for the default
1648         symtab's filename instead of its fullname.
1649
1650 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1651
1652         * NEWS: Update style defaults.
1653
1654 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1655
1656         * main.c (captured_main_1): Disable styling in batch mode.
1657
1658 2019-02-20  Tom Tromey  <tom@tromey.com>
1659
1660         * symtab.c (symtab_symbol_info): Fix typos.
1661
1662 2019-02-20  Tom Tromey  <tromey@adacore.com>
1663
1664         * findcmd.c (_initialize_mem_search): Use upper case for
1665         metasyntactic variables.
1666
1667 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
1668
1669         * aarch64-tdep.c (aarch64_add_reggroups): New function.
1670         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
1671
1672 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
1673
1674         * top.h (source_file_name): Change to std::string.
1675         * top.c (source_file_name): Likewise.
1676         (command_line_input): Adjust.
1677         * cli/cli-script.c (script_from_file): Adjust.
1678
1679 2019-02-19  Tom Tromey  <tromey@adacore.com>
1680
1681         * ravenscar-thread.c
1682         (ravenscar_thread_target::update_thread_list): Don't call
1683         ada_build_task_list.
1684         * ada-lang.h (ada_build_task_list): Don't declare.
1685         * ada-tasks.c (struct ada_tasks_inferior_data)
1686         <task_list_valid_p>: Now bool.
1687         (read_known_tasks, ada_task_list_changed)
1688         (ada_tasks_invalidate_inferior_data): Update.
1689         (read_known_tasks_array): Return bool.
1690         (read_known_tasks_list): Likewise.
1691         (read_known_tasks): Return void.
1692         (ada_build_task_list): Now static.
1693
1694 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1695
1696         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
1697         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
1698
1699 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1700
1701         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
1702         variant for ada_tasks_pspace_data_handle and
1703         ada_tasks_inferior_data_handle.
1704         (ada_tasks_pspace_data_cleanup): New function.
1705         (ada_tasks_inferior_data_cleanup): New function.
1706
1707 2019-02-17  Tom Tromey  <tom@tromey.com>
1708
1709         * macrotab.h (macro_source_fullname): Return a std::string.
1710         * macrotab.c (macro_include, check_for_redefinition)
1711         (macro_undef, macro_lookup_definition, foreach_macro)
1712         (foreach_macro_in_scope): Update.
1713         (macro_source_fullname): Return a std::string.
1714         * macrocmd.c (show_pp_source_pos): Update.
1715
1716 2019-02-17  Tom Tromey  <tom@tromey.com>
1717
1718         * macrocmd.c (show_pp_source_pos): Style the file names.
1719
1720 2019-02-17  Tom Tromey  <tom@tromey.com>
1721
1722         PR tui/24197:
1723         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
1724
1725 2019-02-17  Tom Tromey  <tom@tromey.com>
1726
1727         * ada-lang.c (user_select_syms): Use filtered printing.
1728         * utils.c (wrap_style): New global.
1729         (desired_style): Remove.
1730         (emit_style_escape): Add stream parameter.
1731         (set_output_style, reset_terminal_style, prompt_for_continue):
1732         Update.
1733         (flush_wrap_buffer): Only flush gdb_stdout.
1734         (wrap_here): Set wrap_style.
1735         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
1736         treat escape sequences as a character.  Change when wrap buffer is
1737         flushed.
1738         (fputs_styled): Do not set the output style when the default is
1739         requested.
1740         * ui-style.h (struct ui_file_style) <is_default>: New method.
1741         * source.c (print_source_lines_base): Emit escape sequences in one
1742         piece.
1743
1744 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1745
1746         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1747         integers and enumeration types.
1748
1749 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1750
1751         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1752         instead of lookup_symbol_in_language
1753         (do_exact_match): New function.
1754         (ada_get_symbol_name_matcher): Return do_exact_match when
1755         doing a verbatim match.
1756
1757 2019-02-15  Tom Tromey  <tromey@adacore.com>
1758
1759         * ravenscar-thread.c (ravenscar_thread_target::resume)
1760         (ravenscar_thread_target::wait): Special case wildcard requests.
1761
1762 2019-02-15  Tom Tromey  <tromey@adacore.com>
1763
1764         * ravenscar-thread.c (base_ptid): Remove.
1765         (struct ravenscar_thread_target) <close>: New method.
1766         <m_base_ptid>: New member.
1767         <update_inferior_ptid, active_task, task_is_currently_active,
1768         runtime_initialized>: Declare methods.
1769         <ravenscar_thread_target>: Add constructor.
1770         (ravenscar_thread_target::task_is_currently_active)
1771         (ravenscar_thread_target::update_inferior_ptid)
1772         (ravenscar_runtime_initialized): Rename.  Now methods.
1773         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1774         (ravenscar_thread_target::update_thread_list): Update.
1775         (ravenscar_thread_target::active_task): Now method.
1776         (ravenscar_thread_target::store_registers)
1777         (ravenscar_thread_target::prepare_to_store)
1778         (ravenscar_thread_target::prepare_to_store)
1779         (ravenscar_thread_target::mourn_inferior): Update.
1780         (ravenscar_inferior_created): Use "new" to create target.
1781         (ravenscar_thread_target::get_ada_task_ptid): Update.
1782         (_initialize_ravenscar): Don't initialize base_ptid.
1783         (ravenscar_ops): Remove global.
1784
1785 2019-02-15  Tom Tromey  <tromey@adacore.com>
1786
1787         * target.h (push_target): Declare new overload.
1788         * target.c (push_target): New overload, taking an rvalue reference.
1789         * remote.c (remote_target::open_1): Use push_target overload.
1790         * corelow.c (core_target_open): Use push_target overload.
1791
1792 2019-02-15  Tom Tromey  <tromey@adacore.com>
1793
1794         * ravenscar-thread.c (is_ravenscar_task)
1795         (ravenscar_task_is_currently_active): Return bool.
1796         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
1797         (_initialize_ravenscar): Remove "(void)".
1798         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
1799         Return bool.
1800
1801 2019-02-15  Tom Tromey  <tromey@adacore.com>
1802
1803         * ravenscar-thread.c (ravenscar_runtime_initializer)
1804         (has_ravenscar_runtime, get_running_thread_id)
1805         (ravenscar_thread_target::resume): Fix indentation.
1806
1807 2019-02-15  Tom Tromey  <tromey@adacore.com>
1808
1809         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
1810         from ravenscar_arch_ops.
1811         (sparc_ravenscar_ops::fetch_registers)
1812         (sparc_ravenscar_ops::store_registers): Now methods.
1813         (sparc_ravenscar_prepare_to_store): Remove.
1814         (sparc_ravenscar_ops): Redefine.
1815         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1816         methods and destructor.  Remove members.
1817         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1818         (ravenscar_thread_target::store_registers)
1819         (ravenscar_thread_target::prepare_to_store): Update.
1820         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1821         Remove.
1822         (struct ppc_ravenscar_powerpc_ops): Derive from
1823         ravenscar_arch_ops.
1824         (ppc_ravenscar_powerpc_ops::fetch_registers)
1825         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1826         (ppc_ravenscar_powerpc_ops): Redefine.
1827         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1828         (ppc_ravenscar_e500_ops::fetch_registers)
1829         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1830         (ppc_ravenscar_e500_ops): Redefine.
1831         * aarch64-ravenscar-thread.c
1832         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1833         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1834         (aarch64_ravenscar_fetch_registers)
1835         (aarch64_ravenscar_store_registers): Now methods.
1836         (aarch64_ravenscar_ops): Redefine.
1837
1838 2019-02-15  Tom Tromey  <tromey@adacore.com>
1839
1840         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1841         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1842         (ravenscar_thread_target::stopped_by_watchpoint)
1843         (ravenscar_thread_target::stopped_data_address)
1844         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1845
1846 2019-02-15  Tom Tromey  <tromey@adacore.com>
1847
1848         * ravenscar-thread.c: Fix some typos.
1849
1850 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1851             Tom Tromey  <tromey@adacore.com>
1852
1853         * ada-lang.c (ada_exception_sal): Change addr_string to a
1854         std::string.
1855         (create_ada_exception_catchpoint): Update.
1856
1857 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1858             Tom Tromey  <tromey@adacore.com>
1859
1860         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
1861         (bp_location_ops): Remove.
1862         (base_breakpoint_allocate_location): Update.
1863         (free_bp_location): Update.
1864         * ada-lang.c (class ada_catchpoint_location)
1865         <ada_catchpoint_location>: Remove ops parameter.
1866         (ada_catchpoint_location_dtor): Remove.
1867         (ada_catchpoint_location_ops): Remove.
1868         (allocate_location_exception): Update.
1869         * breakpoint.h (struct bp_location_ops): Remove.
1870         (class bp_location) <bp_location>: Remove bp_location_ops
1871         parameter.
1872         <~bp_location>: Add destructor.
1873         <ops>: Remove.
1874
1875 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1876             Pedro Alves  <palves@redhat.com>
1877
1878         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
1879         'PATH_MAX'.
1880
1881 2019-02-14  David Michael  <fedora.dm0@gmail.com>
1882             Samuel Thibault  <samuel.thibault@gnu.org>
1883             Thomas Schwinge  <thomas@codesourcery.com>
1884
1885         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
1886         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
1887
1888 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1889
1890         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
1891         (check_empty): Use "const char *".
1892
1893         * gnu-nat.c (gnu_nat_target::detach): Instead of
1894         'detach_inferior (pid)' call
1895         'detach_inferior (find_inferior_pid (pid))'.
1896
1897         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
1898         'nat/fork-inferior.o'.
1899         * gnu-nat.c: #include "nat/fork-inferior.h".
1900
1901         * gnu-nat.c (gnu_nat_target::detach): Instead of
1902         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
1903         * gnu-nat.h: #include "inf-child.h".
1904         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
1905         'i386_gnu_nat_target::fetch_registers'.
1906         (gnu_store_registers): Rename/move to
1907         'i386_gnu_nat_target::store_registers'.
1908
1909         * config/i386/nm-i386gnu.h: Don't "#include" any files.
1910         * gnu-nat.h (mach_thread_info): New function.
1911         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
1912
1913         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
1914
1915 2019-02-14  Frederic Konrad  <konrad@adacore.com>
1916
1917         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
1918
1919 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
1920
1921         * windows-nat.c (windows_add_thread): Add new parameter
1922         "main_thread_p" with default value set to false.  Update
1923         function documentation as well as all callers.
1924         (windows_delete_thread): Likewise.
1925         (fake_create_process): Update call to windows_add_thread.
1926         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
1927         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
1928         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
1929         call to windows_delete_thread.
1930
1931 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
1932
1933         * MAINTAINERS: Add Andrew Burgess as global maintainer.
1934
1935 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1936
1937         * symfile.c (find_separate_debug_file): Use canonical path of
1938         sysroot with child_path instead of gdb_sysroot if it is valid.
1939
1940 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1941
1942         * symfile.c (find_separate_debug_file): Use child_path to
1943         determine if an object file is under a sysroot.
1944
1945 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1946
1947         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1948         unittests/child-path-selftests.c.
1949         * common/pathstuff.c (child_path): New function.
1950         * common/pathstuff.h (child_path): New prototype.
1951         * unittests/child-path-selftests.c: New file.
1952
1953 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1954
1955         * symfile.c (find_separate_debug_file): Look for separate debug
1956         files in debug directories under the sysroot.
1957
1958 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1959
1960         * symtab.h (struct minimal_symbol data_p): New const method.
1961         (struct minimal_symbol text_p): Likewise.
1962         * symtab.c (output_source_filename): Use file name style
1963         to print file name.
1964         (print_symbol_info): Likewise.
1965         (print_msymbol_info): Use address style to print addresses.
1966         Use function name style to print executable text symbols.
1967         (expand_symtab_containing_pc): Use data_p.
1968         (find_pc_sect_compunit_symtab): Likewise.
1969
1970 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1971
1972         * breakpoint.c (describe_other_breakpoints): Use address style
1973         to print addresses.
1974         (say_where): Likewise.
1975
1976 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1977
1978         * ada-typeprint.c (print_func_type): Print function name
1979         style to print function name.
1980         * c-typeprint.c (c_print_type_1): Likewise.
1981
1982 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
1983
1984         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
1985         for execve.
1986
1987 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1988
1989         * c-exp.y (direct_abs_decl): Use emplace_back to record the
1990         type_stack.
1991
1992 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
1993
1994         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
1995         TYPE_CODE_REF types.
1996
1997 2019-02-08  Jim Wilson  <jimw@sifive.com>
1998
1999         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
2000         (riscv_linux_fregset): New.
2001         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
2002
2003 2019-02-07  Tom Tromey  <tom@tromey.com>
2004
2005         * thread.c (thread_cancel_execution_command): Update.
2006         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
2007         methods.
2008         (struct thread_fsm_ops): Remove.
2009         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
2010         (thread_fsm_should_stop, thread_fsm_return_value)
2011         (thread_fsm_set_finished, thread_fsm_finished_p)
2012         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
2013         Don't declare.
2014         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
2015         * infrun.c (clear_proceed_status_thread)
2016         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
2017         (print_stop_event): Update.
2018         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
2019         Add constructor.
2020         (step_command_fsm_ops): Remove.
2021         (new_step_command_fsm): Remove.
2022         (step_1): Update.
2023         (step_command_fsm::should_stop): Rename from
2024         step_command_fsm_should_stop.
2025         (step_command_fsm::clean_up): Rename from
2026         step_command_fsm_clean_up.
2027         (step_command_fsm::do_async_reply_reason): Rename from
2028         step_command_fsm_async_reply_reason.
2029         (struct until_next_fsm): Inherit from thread_fsm.  Add
2030         constructor.
2031         (until_next_fsm_ops): Remove.
2032         (new_until_next_fsm): Remove.
2033         (until_next_fsm::should_stop): Rename from
2034         until_next_fsm_should_stop.
2035         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
2036         (until_next_fsm::do_async_reply_reason): Rename from
2037         until_next_fsm_async_reply_reason.
2038         (struct finish_command_fsm): Inherit from thread_fsm.  Add
2039         constructor.  Change type of breakpoint.
2040         (finish_command_fsm_ops): Remove.
2041         (new_finish_command_fsm): Remove.
2042         (finish_command_fsm::should_stop): Rename from
2043         finish_command_fsm_should_stop.
2044         (finish_command_fsm::clean_up): Rename from
2045         finish_command_fsm_clean_up.
2046         (finish_command_fsm::return_value): Rename from
2047         finish_command_fsm_return_value.
2048         (finish_command_fsm::do_async_reply_reason): Rename from
2049         finish_command_fsm_async_reply_reason.
2050         (finish_command): Update.
2051         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
2052         Add constructor.
2053         (call_thread_fsm_ops): Remove.
2054         (call_thread_fsm::call_thread_fsm): Rename from
2055         new_call_thread_fsm.
2056         (call_thread_fsm::should_stop): Rename from
2057         call_thread_fsm_should_stop.
2058         (call_thread_fsm::should_notify_stop): Rename from
2059         call_thread_fsm_should_notify_stop.
2060         (run_inferior_call, call_function_by_hand_dummy): Update.
2061         * cli/cli-interp.c (should_print_stop_to_console): Update.
2062         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
2063         Add constructor.  Change type of location_breakpoint,
2064         caller_breakpoint.
2065         (until_break_fsm_ops): Remove.
2066         (new_until_break_fsm): Remove.
2067         (until_break_fsm::should_stop): Rename from
2068         until_break_fsm_should_stop.
2069         (until_break_fsm::clean_up): Rename from
2070         until_break_fsm_clean_up.
2071         (until_break_fsm::do_async_reply_reason): Rename from
2072         until_break_fsm_async_reply_reason.
2073         (until_break_command): Update.
2074         * thread-fsm.c: Remove.
2075         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
2076
2077 2019-02-07  Tom Tromey  <tom@tromey.com>
2078
2079         * yy-remap.h: Add include guard.
2080         * xtensa-tdep.h: Add include guard.
2081         * xcoffread.h: Rename include guard.
2082         * varobj-iter.h: Add include guard.
2083         * tui/tui.h: Rename include guard.
2084         * tui/tui-winsource.h: Rename include guard.
2085         * tui/tui-wingeneral.h: Rename include guard.
2086         * tui/tui-windata.h: Rename include guard.
2087         * tui/tui-win.h: Rename include guard.
2088         * tui/tui-stack.h: Rename include guard.
2089         * tui/tui-source.h: Rename include guard.
2090         * tui/tui-regs.h: Rename include guard.
2091         * tui/tui-out.h: Rename include guard.
2092         * tui/tui-layout.h: Rename include guard.
2093         * tui/tui-io.h: Rename include guard.
2094         * tui/tui-hooks.h: Rename include guard.
2095         * tui/tui-file.h: Rename include guard.
2096         * tui/tui-disasm.h: Rename include guard.
2097         * tui/tui-data.h: Rename include guard.
2098         * tui/tui-command.h: Rename include guard.
2099         * tic6x-tdep.h: Add include guard.
2100         * target/waitstatus.h: Rename include guard.
2101         * target/wait.h: Rename include guard.
2102         * target/target.h: Rename include guard.
2103         * target/resume.h: Rename include guard.
2104         * target-float.h: Rename include guard.
2105         * stabsread.h: Add include guard.
2106         * rs6000-tdep.h: Add include guard.
2107         * riscv-fbsd-tdep.h: Add include guard.
2108         * regformats/regdef.h: Rename include guard.
2109         * record.h: Rename include guard.
2110         * python/python.h: Rename include guard.
2111         * python/python-internal.h: Rename include guard.
2112         * python/py-stopevent.h: Rename include guard.
2113         * python/py-ref.h: Rename include guard.
2114         * python/py-record.h: Rename include guard.
2115         * python/py-record-full.h: Rename include guard.
2116         * python/py-record-btrace.h: Rename include guard.
2117         * python/py-instruction.h: Rename include guard.
2118         * python/py-events.h: Rename include guard.
2119         * python/py-event.h: Rename include guard.
2120         * procfs.h: Add include guard.
2121         * proc-utils.h: Add include guard.
2122         * p-lang.h: Add include guard.
2123         * or1k-tdep.h: Rename include guard.
2124         * observable.h: Rename include guard.
2125         * nto-tdep.h: Rename include guard.
2126         * nat/x86-linux.h: Rename include guard.
2127         * nat/x86-linux-dregs.h: Rename include guard.
2128         * nat/x86-gcc-cpuid.h: Add include guard.
2129         * nat/x86-dregs.h: Rename include guard.
2130         * nat/x86-cpuid.h: Rename include guard.
2131         * nat/ppc-linux.h: Rename include guard.
2132         * nat/mips-linux-watch.h: Rename include guard.
2133         * nat/linux-waitpid.h: Rename include guard.
2134         * nat/linux-ptrace.h: Rename include guard.
2135         * nat/linux-procfs.h: Rename include guard.
2136         * nat/linux-osdata.h: Rename include guard.
2137         * nat/linux-nat.h: Rename include guard.
2138         * nat/linux-namespaces.h: Rename include guard.
2139         * nat/linux-btrace.h: Rename include guard.
2140         * nat/glibc_thread_db.h: Rename include guard.
2141         * nat/gdb_thread_db.h: Rename include guard.
2142         * nat/gdb_ptrace.h: Rename include guard.
2143         * nat/fork-inferior.h: Rename include guard.
2144         * nat/amd64-linux-siginfo.h: Rename include guard.
2145         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
2146         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
2147         * nat/aarch64-linux.h: Rename include guard.
2148         * nat/aarch64-linux-hw-point.h: Rename include guard.
2149         * mn10300-tdep.h: Add include guard.
2150         * mips-linux-tdep.h: Add include guard.
2151         * mi/mi-parse.h: Rename include guard.
2152         * mi/mi-out.h: Rename include guard.
2153         * mi/mi-main.h: Rename include guard.
2154         * mi/mi-interp.h: Rename include guard.
2155         * mi/mi-getopt.h: Rename include guard.
2156         * mi/mi-console.h: Rename include guard.
2157         * mi/mi-common.h: Rename include guard.
2158         * mi/mi-cmds.h: Rename include guard.
2159         * mi/mi-cmd-break.h: Rename include guard.
2160         * m2-lang.h: Add include guard.
2161         * location.h: Rename include guard.
2162         * linux-record.h: Rename include guard.
2163         * linux-nat.h: Add include guard.
2164         * linux-fork.h: Add include guard.
2165         * i386-darwin-tdep.h: Rename include guard.
2166         * hppa-linux-offsets.h: Add include guard.
2167         * guile/guile.h: Rename include guard.
2168         * guile/guile-internal.h: Rename include guard.
2169         * gnu-nat.h: Rename include guard.
2170         * gdb-stabs.h: Rename include guard.
2171         * frv-tdep.h: Add include guard.
2172         * f-lang.h: Add include guard.
2173         * event-loop.h: Add include guard.
2174         * darwin-nat.h: Rename include guard.
2175         * cp-abi.h: Rename include guard.
2176         * config/sparc/nm-sol2.h: Rename include guard.
2177         * config/nm-nto.h: Rename include guard.
2178         * config/nm-linux.h: Add include guard.
2179         * config/i386/nm-i386gnu.h: Rename include guard.
2180         * config/djgpp/nl_types.h: Rename include guard.
2181         * config/djgpp/langinfo.h: Rename include guard.
2182         * compile/gcc-cp-plugin.h: Add include guard.
2183         * compile/gcc-c-plugin.h: Add include guard.
2184         * compile/compile.h: Rename include guard.
2185         * compile/compile-object-run.h: Rename include guard.
2186         * compile/compile-object-load.h: Rename include guard.
2187         * compile/compile-internal.h: Rename include guard.
2188         * compile/compile-cplus.h: Rename include guard.
2189         * compile/compile-c.h: Rename include guard.
2190         * common/xml-utils.h: Rename include guard.
2191         * common/x86-xstate.h: Rename include guard.
2192         * common/version.h: Rename include guard.
2193         * common/vec.h: Rename include guard.
2194         * common/tdesc.h: Rename include guard.
2195         * common/selftest.h: Rename include guard.
2196         * common/scoped_restore.h: Rename include guard.
2197         * common/scoped_mmap.h: Rename include guard.
2198         * common/scoped_fd.h: Rename include guard.
2199         * common/safe-iterator.h: Rename include guard.
2200         * common/run-time-clock.h: Rename include guard.
2201         * common/refcounted-object.h: Rename include guard.
2202         * common/queue.h: Rename include guard.
2203         * common/ptid.h: Rename include guard.
2204         * common/print-utils.h: Rename include guard.
2205         * common/preprocessor.h: Rename include guard.
2206         * common/pathstuff.h: Rename include guard.
2207         * common/observable.h: Rename include guard.
2208         * common/netstuff.h: Rename include guard.
2209         * common/job-control.h: Rename include guard.
2210         * common/host-defs.h: Rename include guard.
2211         * common/gdb_wait.h: Rename include guard.
2212         * common/gdb_vecs.h: Rename include guard.
2213         * common/gdb_unlinker.h: Rename include guard.
2214         * common/gdb_unique_ptr.h: Rename include guard.
2215         * common/gdb_tilde_expand.h: Rename include guard.
2216         * common/gdb_sys_time.h: Rename include guard.
2217         * common/gdb_string_view.h: Rename include guard.
2218         * common/gdb_splay_tree.h: Rename include guard.
2219         * common/gdb_setjmp.h: Rename include guard.
2220         * common/gdb_ref_ptr.h: Rename include guard.
2221         * common/gdb_optional.h: Rename include guard.
2222         * common/gdb_locale.h: Rename include guard.
2223         * common/gdb_assert.h: Rename include guard.
2224         * common/filtered-iterator.h: Rename include guard.
2225         * common/filestuff.h: Rename include guard.
2226         * common/fileio.h: Rename include guard.
2227         * common/environ.h: Rename include guard.
2228         * common/common-utils.h: Rename include guard.
2229         * common/common-types.h: Rename include guard.
2230         * common/common-regcache.h: Rename include guard.
2231         * common/common-inferior.h: Rename include guard.
2232         * common/common-gdbthread.h: Rename include guard.
2233         * common/common-exceptions.h: Rename include guard.
2234         * common/common-defs.h: Rename include guard.
2235         * common/common-debug.h: Rename include guard.
2236         * common/cleanups.h: Rename include guard.
2237         * common/buffer.h: Rename include guard.
2238         * common/btrace-common.h: Rename include guard.
2239         * common/break-common.h: Rename include guard.
2240         * cli/cli-utils.h: Rename include guard.
2241         * cli/cli-style.h: Rename include guard.
2242         * cli/cli-setshow.h: Rename include guard.
2243         * cli/cli-script.h: Rename include guard.
2244         * cli/cli-interp.h: Rename include guard.
2245         * cli/cli-decode.h: Rename include guard.
2246         * cli/cli-cmds.h: Rename include guard.
2247         * charset-list.h: Add include guard.
2248         * buildsym-legacy.h: Rename include guard.
2249         * bfin-tdep.h: Add include guard.
2250         * ax.h: Rename include guard.
2251         * arm-linux-tdep.h: Add include guard.
2252         * arm-fbsd-tdep.h: Add include guard.
2253         * arch/xtensa.h: Rename include guard.
2254         * arch/tic6x.h: Add include guard.
2255         * arch/i386.h: Add include guard.
2256         * arch/arm.h: Rename include guard.
2257         * arch/arm-linux.h: Rename include guard.
2258         * arch/arm-get-next-pcs.h: Rename include guard.
2259         * arch/amd64.h: Add include guard.
2260         * arch/aarch64-insn.h: Rename include guard.
2261         * arch-utils.h: Rename include guard.
2262         * annotate.h: Add include guard.
2263         * amd64-darwin-tdep.h: Rename include guard.
2264         * aarch64-linux-tdep.h: Add include guard.
2265         * aarch64-fbsd-tdep.h: Add include guard.
2266         * aarch32-linux-nat.h: Add include guard.
2267
2268 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2269
2270         * macrotab.c (macro_define_internal): New function that
2271         factorizes macro_define_object_internal and macro_define_function
2272         code.
2273         (macro_define_object_internal): Use macro_define_internal.
2274         (macro_define_function): Likewise.
2275
2276 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2277
2278         * macrocmd.c (extract_identifier): Return
2279         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
2280         callers.
2281
2282 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
2283
2284         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
2285
2286 2019-02-05  Tom Tromey  <tom@tromey.com>
2287
2288         * target.c (target_stack::unpush): Move assertion earlier.
2289
2290 2019-01-30  Tom Tromey  <tom@tromey.com>
2291
2292         PR python/23615:
2293         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
2294         (gdbpy_parse_and_eval): Likewise.
2295         * python/python-internal.h (gdbpy_allow_threads): New class.
2296
2297 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
2298
2299         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
2300         (aarch64_fbsd_fpregmap): Move earlier.
2301         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
2302         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2303         instead of individual calls to trad_frame_set_reg_addr.
2304         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
2305         earlier.
2306         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
2307         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2308         instead of individual calls to trad_frame_set_reg_addr.
2309
2310 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
2311
2312         * CONTRIBUTE: Replace contribution list with wiki link.
2313
2314 2019-01-25  Tom Tromey  <tom@tromey.com>
2315
2316         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
2317
2318 2019-01-25  Tom Tromey  <tom@tromey.com>
2319
2320         * xtensa-linux-nat.c: Fix common/ includes.
2321         * xml-support.h: Fix common/ includes.
2322         * xml-support.c: Fix common/ includes.
2323         * x86-linux-nat.c: Fix common/ includes.
2324         * windows-nat.c: Fix common/ includes.
2325         * varobj.h: Fix common/ includes.
2326         * varobj.c: Fix common/ includes.
2327         * value.c: Fix common/ includes.
2328         * valops.c: Fix common/ includes.
2329         * utils.c: Fix common/ includes.
2330         * unittests/xml-utils-selftests.c: Fix common/ includes.
2331         * unittests/utils-selftests.c: Fix common/ includes.
2332         * unittests/unpack-selftests.c: Fix common/ includes.
2333         * unittests/tracepoint-selftests.c: Fix common/ includes.
2334         * unittests/style-selftests.c: Fix common/ includes.
2335         * unittests/string_view-selftests.c: Fix common/ includes.
2336         * unittests/scoped_restore-selftests.c: Fix common/ includes.
2337         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
2338         * unittests/scoped_fd-selftests.c: Fix common/ includes.
2339         * unittests/rsp-low-selftests.c: Fix common/ includes.
2340         * unittests/parse-connection-spec-selftests.c: Fix common/
2341         includes.
2342         * unittests/optional-selftests.c: Fix common/ includes.
2343         * unittests/offset-type-selftests.c: Fix common/ includes.
2344         * unittests/observable-selftests.c: Fix common/ includes.
2345         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
2346         * unittests/memrange-selftests.c: Fix common/ includes.
2347         * unittests/memory-map-selftests.c: Fix common/ includes.
2348         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
2349         * unittests/function-view-selftests.c: Fix common/ includes.
2350         * unittests/environ-selftests.c: Fix common/ includes.
2351         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
2352         * unittests/common-utils-selftests.c: Fix common/ includes.
2353         * unittests/cli-utils-selftests.c: Fix common/ includes.
2354         * unittests/array-view-selftests.c: Fix common/ includes.
2355         * ui-file.c: Fix common/ includes.
2356         * tui/tui-io.c: Fix common/ includes.
2357         * tracepoint.h: Fix common/ includes.
2358         * tracepoint.c: Fix common/ includes.
2359         * tracefile-tfile.c: Fix common/ includes.
2360         * top.h: Fix common/ includes.
2361         * top.c: Fix common/ includes.
2362         * thread.c: Fix common/ includes.
2363         * target/waitstatus.h: Fix common/ includes.
2364         * target/waitstatus.c: Fix common/ includes.
2365         * target.h: Fix common/ includes.
2366         * target.c: Fix common/ includes.
2367         * target-memory.c: Fix common/ includes.
2368         * target-descriptions.c: Fix common/ includes.
2369         * symtab.h: Fix common/ includes.
2370         * symfile.c: Fix common/ includes.
2371         * stap-probe.c: Fix common/ includes.
2372         * spu-linux-nat.c: Fix common/ includes.
2373         * sparc-nat.c: Fix common/ includes.
2374         * source.c: Fix common/ includes.
2375         * solib.c: Fix common/ includes.
2376         * solib-target.c: Fix common/ includes.
2377         * ser-unix.c: Fix common/ includes.
2378         * ser-tcp.c: Fix common/ includes.
2379         * ser-pipe.c: Fix common/ includes.
2380         * ser-base.c: Fix common/ includes.
2381         * selftest-arch.c: Fix common/ includes.
2382         * s12z-tdep.c: Fix common/ includes.
2383         * rust-exp.y: Fix common/ includes.
2384         * rs6000-aix-tdep.c: Fix common/ includes.
2385         * riscv-tdep.c: Fix common/ includes.
2386         * remote.c: Fix common/ includes.
2387         * remote-notif.h: Fix common/ includes.
2388         * remote-fileio.h: Fix common/ includes.
2389         * remote-fileio.c: Fix common/ includes.
2390         * regcache.h: Fix common/ includes.
2391         * regcache.c: Fix common/ includes.
2392         * record-btrace.c: Fix common/ includes.
2393         * python/python.c: Fix common/ includes.
2394         * python/py-type.c: Fix common/ includes.
2395         * python/py-inferior.c: Fix common/ includes.
2396         * progspace.h: Fix common/ includes.
2397         * producer.c: Fix common/ includes.
2398         * procfs.c: Fix common/ includes.
2399         * proc-api.c: Fix common/ includes.
2400         * printcmd.c: Fix common/ includes.
2401         * ppc-linux-nat.c: Fix common/ includes.
2402         * parser-defs.h: Fix common/ includes.
2403         * osdata.c: Fix common/ includes.
2404         * obsd-nat.c: Fix common/ includes.
2405         * nat/x86-linux.c: Fix common/ includes.
2406         * nat/x86-linux-dregs.c: Fix common/ includes.
2407         * nat/x86-dregs.h: Fix common/ includes.
2408         * nat/x86-dregs.c: Fix common/ includes.
2409         * nat/ppc-linux.c: Fix common/ includes.
2410         * nat/mips-linux-watch.h: Fix common/ includes.
2411         * nat/mips-linux-watch.c: Fix common/ includes.
2412         * nat/linux-waitpid.c: Fix common/ includes.
2413         * nat/linux-ptrace.h: Fix common/ includes.
2414         * nat/linux-ptrace.c: Fix common/ includes.
2415         * nat/linux-procfs.c: Fix common/ includes.
2416         * nat/linux-personality.c: Fix common/ includes.
2417         * nat/linux-osdata.c: Fix common/ includes.
2418         * nat/linux-namespaces.c: Fix common/ includes.
2419         * nat/linux-btrace.h: Fix common/ includes.
2420         * nat/linux-btrace.c: Fix common/ includes.
2421         * nat/fork-inferior.c: Fix common/ includes.
2422         * nat/amd64-linux-siginfo.c: Fix common/ includes.
2423         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
2424         * nat/aarch64-linux.c: Fix common/ includes.
2425         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
2426         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
2427         * namespace.h: Fix common/ includes.
2428         * mips-linux-tdep.c: Fix common/ includes.
2429         * minsyms.c: Fix common/ includes.
2430         * mi/mi-parse.h: Fix common/ includes.
2431         * mi/mi-main.c: Fix common/ includes.
2432         * mi/mi-cmd-env.c: Fix common/ includes.
2433         * memrange.h: Fix common/ includes.
2434         * memattr.c: Fix common/ includes.
2435         * maint.h: Fix common/ includes.
2436         * maint.c: Fix common/ includes.
2437         * main.c: Fix common/ includes.
2438         * machoread.c: Fix common/ includes.
2439         * location.c: Fix common/ includes.
2440         * linux-thread-db.c: Fix common/ includes.
2441         * linux-nat.c: Fix common/ includes.
2442         * linux-fork.c: Fix common/ includes.
2443         * inline-frame.c: Fix common/ includes.
2444         * infrun.c: Fix common/ includes.
2445         * inflow.c: Fix common/ includes.
2446         * inferior.h: Fix common/ includes.
2447         * inferior.c: Fix common/ includes.
2448         * infcmd.c: Fix common/ includes.
2449         * inf-ptrace.c: Fix common/ includes.
2450         * inf-child.c: Fix common/ includes.
2451         * ia64-linux-nat.c: Fix common/ includes.
2452         * i387-tdep.c: Fix common/ includes.
2453         * i386-tdep.c: Fix common/ includes.
2454         * i386-linux-tdep.c: Fix common/ includes.
2455         * i386-linux-nat.c: Fix common/ includes.
2456         * i386-go32-tdep.c: Fix common/ includes.
2457         * i386-fbsd-tdep.c: Fix common/ includes.
2458         * i386-fbsd-nat.c: Fix common/ includes.
2459         * guile/scm-type.c: Fix common/ includes.
2460         * guile/guile.c: Fix common/ includes.
2461         * go32-nat.c: Fix common/ includes.
2462         * gnu-nat.c: Fix common/ includes.
2463         * gdbthread.h: Fix common/ includes.
2464         * gdbarch-selftests.c: Fix common/ includes.
2465         * gdb_usleep.c: Fix common/ includes.
2466         * gdb_select.h: Fix common/ includes.
2467         * gdb_bfd.c: Fix common/ includes.
2468         * gcore.c: Fix common/ includes.
2469         * fork-child.c: Fix common/ includes.
2470         * findvar.c: Fix common/ includes.
2471         * fbsd-nat.c: Fix common/ includes.
2472         * event-top.c: Fix common/ includes.
2473         * event-loop.c: Fix common/ includes.
2474         * dwarf2read.c: Fix common/ includes.
2475         * dwarf2loc.c: Fix common/ includes.
2476         * dwarf2-frame.c: Fix common/ includes.
2477         * dwarf-index-cache.c: Fix common/ includes.
2478         * dtrace-probe.c: Fix common/ includes.
2479         * disasm-selftests.c: Fix common/ includes.
2480         * defs.h: Fix common/ includes.
2481         * csky-tdep.c: Fix common/ includes.
2482         * cp-valprint.c: Fix common/ includes.
2483         * cp-support.h: Fix common/ includes.
2484         * cp-support.c: Fix common/ includes.
2485         * corelow.c: Fix common/ includes.
2486         * completer.h: Fix common/ includes.
2487         * completer.c: Fix common/ includes.
2488         * compile/compile.c: Fix common/ includes.
2489         * compile/compile-loc2c.c: Fix common/ includes.
2490         * compile/compile-cplus-types.c: Fix common/ includes.
2491         * compile/compile-cplus-symbols.c: Fix common/ includes.
2492         * command.h: Fix common/ includes.
2493         * cli/cli-dump.c: Fix common/ includes.
2494         * cli/cli-cmds.c: Fix common/ includes.
2495         * charset.c: Fix common/ includes.
2496         * build-id.c: Fix common/ includes.
2497         * btrace.h: Fix common/ includes.
2498         * btrace.c: Fix common/ includes.
2499         * breakpoint.h: Fix common/ includes.
2500         * breakpoint.c: Fix common/ includes.
2501         * ax.h:
2502         (enum agent_op): Fix common/ includes.
2503         * ax-general.c (struct aop_map): Fix common/ includes.
2504         * ax-gdb.c: Fix common/ includes.
2505         * auxv.c: Fix common/ includes.
2506         * auto-load.c: Fix common/ includes.
2507         * arm-tdep.c: Fix common/ includes.
2508         * arch/riscv.c: Fix common/ includes.
2509         * arch/ppc-linux-common.c: Fix common/ includes.
2510         * arch/i386.c: Fix common/ includes.
2511         * arch/arm.c: Fix common/ includes.
2512         * arch/arm-linux.c: Fix common/ includes.
2513         * arch/arm-get-next-pcs.c: Fix common/ includes.
2514         * arch/amd64.c: Fix common/ includes.
2515         * arch/aarch64.c: Fix common/ includes.
2516         * arch/aarch64-insn.c: Fix common/ includes.
2517         * arch-utils.c: Fix common/ includes.
2518         * amd64-windows-tdep.c: Fix common/ includes.
2519         * amd64-tdep.c: Fix common/ includes.
2520         * amd64-sol2-tdep.c: Fix common/ includes.
2521         * amd64-obsd-tdep.c: Fix common/ includes.
2522         * amd64-nbsd-tdep.c: Fix common/ includes.
2523         * amd64-linux-tdep.c: Fix common/ includes.
2524         * amd64-linux-nat.c: Fix common/ includes.
2525         * amd64-fbsd-tdep.c: Fix common/ includes.
2526         * amd64-fbsd-nat.c: Fix common/ includes.
2527         * amd64-dicos-tdep.c: Fix common/ includes.
2528         * amd64-darwin-tdep.c: Fix common/ includes.
2529         * agent.c: Fix common/ includes.
2530         * ada-lang.h: Fix common/ includes.
2531         * ada-lang.c: Fix common/ includes.
2532         * aarch64-tdep.c: Fix common/ includes.
2533
2534 2019-01-25  Tom Tromey  <tom@tromey.com>
2535
2536         * common/create-version.sh: Use common/version.h.
2537
2538 2019-01-24  Pedro Alves  <palves@redhat.com>
2539
2540         * infrun.c (signal_stop, signal_print, signal_program)
2541         (signal_catch, signal_pass): Now arrays instead of pointers.
2542         (update_signals_program_target, do_target_resume)
2543         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2544         * linux-nat.c (linux_nat_target::pass_signals)
2545         (linux_nat_target::create_inferior, linux_nat_target::attach):
2546         Adjust.
2547         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2548         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2549         * procfs.c (procfs_target::pass_signals): Adjust.
2550         * record-full.c (record_full_target::resume): Adjust.
2551         * remote.c (remote_target::pass_signals)
2552         (remote_target::program_signals): Adjust.
2553         * target-debug.h (target_debug_print_signals): Now takes a
2554         gdb::array_view as parameter.  Adjust.
2555         * target.h (target_ops) <pass_signals, program_signals>: Replace
2556         pointer and length parameters with gdb::array_view.
2557         (target_pass_signals, target_program_signals): Likewise.
2558         * target-delegates.c: Regenerate.
2559
2560 2019-01-24  Pedro Alves  <palves@redhat.com>
2561
2562         * common/forward-scope-exit.h
2563         (forward_scope_exit::forward_scope_exit): Pass arguments to
2564         m_bind_function directly, instead of creating a std::bind and
2565         copying that.
2566
2567 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
2568
2569         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2570         for static members.
2571         (pass_in_v_vfp_candidate): Likewise.
2572
2573 2019-01-23  Tom Tromey  <tom@tromey.com>
2574             Pedro Alves  <palves@redhat.com>
2575
2576         * regcache.c (class regcache_invalidator): Remove.
2577         (regcache::raw_write): Use make_scope_exit.
2578
2579 2019-01-23  Tom Tromey  <tom@tromey.com>
2580
2581         * ui-out.h (class ui_out_emit_type): Update comment.
2582
2583 2019-01-23  Tom Tromey  <tom@tromey.com>
2584
2585         * infrun.c (fetch_inferior_event): Update comment.
2586
2587 2019-01-23  Tom Tromey  <tom@tromey.com>
2588             Pedro Alves  <palves@redhat.com>
2589
2590         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
2591         parameter.
2592         (fetch_inferior_event): Use SCOPE_EXIT.
2593
2594
2595 2019-01-23  Tom Tromey  <tom@tromey.com>
2596             Pedro Alves  <palves@redhat.com>
2597
2598         * infrun.c (disable_thread_events): Delete.
2599         (stop_all_threads): Use SCOPE_EXIT.
2600
2601 2019-01-23  Tom Tromey  <tom@tromey.com>
2602             Pedro Alves  <palves@redhat.com>
2603
2604         * symfile.c: Include forward-scope-exit.h.
2605         (clear_symtab_users_cleanup): Replace forward declaration with
2606         a FORWARD_SCOPE_EXIT.
2607         (syms_from_objfile_1): Use the forward_scope_exit and
2608         gdb::optional instead of cleanup_function.
2609         (reread_symbols): Use the forward_scope_exit instead of
2610         cleanup_function.
2611         (clear_symtab_users_cleanup): Remove function.
2612
2613 2019-01-23  Tom Tromey  <tom@tromey.com>
2614             Pedro Alves  <palves@redhat.com>
2615
2616         * linux-nat.c: Include scope-exit.h.
2617         (cleanup_target_stop): Remove.
2618         (linux_nat_target::static_tracepoint_markers_by_strid): Use
2619         SCOPE_EXIT.
2620
2621 2019-01-23  Tom Tromey  <tom@tromey.com>
2622             Pedro Alves  <palves@redhat.com>
2623
2624         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
2625         (call_function_by_hand_dummy): Use SCOPE_EXIT.
2626
2627 2019-01-23  Tom Tromey  <tom@tromey.com>
2628             Andrew Burgess  <andrew.burgess@embecosm.com>
2629             Pedro Alves  <palves@redhat.com>
2630
2631         * infrun.c (fetch_inferior_event): Use scope_exit.
2632         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
2633         * top.c (execute_command): Use scope_exit.
2634         * breakpoint.c (bpstat_do_actions): Use scope_exit.
2635         * utils.c (do_bpstat_clear_actions_cleanup)
2636         (make_bpstat_clear_actions_cleanup): Remove.
2637
2638 2019-01-23  Tom Tromey  <tom@tromey.com>
2639             Pedro Alves  <palves@redhat.com>
2640
2641         * infrun.c: Include "common/scope-exit.h"
2642         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
2643         (wait_for_inferior): Use SCOPE_EXIT.
2644         (fetch_inferior_event): Use scope_exit.
2645
2646 2019-01-23  Tom Tromey  <tom@tromey.com>
2647             Pedro Alves  <palves@redhat.com>
2648
2649         * breakpoint.c (create_breakpoint): Remove cleanup.
2650
2651 2019-01-23  Tom Tromey  <tom@tromey.com>
2652             Andrew Burgess  <andrew.burgess@embecosm.com>
2653             Pedro Alves  <palves@redhat.com>
2654
2655 2019-01-23  Pedro Alves  <palves@redhat.com>
2656
2657         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
2658
2659 2019-01-23  Pedro Alves  <palves@redhat.com>
2660             Andrew Burgess  <andrew.burgess@embecosm.com>
2661
2662         * gdbthread.h: Include "common/forward-scope-exit.h".
2663         (scoped_finish_thread_state): Redefine custom class in terms of
2664         forward_scope_exit.
2665
2666 2019-01-23  Pedro Alves  <palves@redhat.com>
2667             Andrew Burgess  <andrew.burgess@embecosm.com>
2668
2669         * common/forward-scope-exit.h: New file.
2670
2671 2019-01-23  Pedro Alves  <palves@redhat.com>
2672             Andrew Burgess  <andrew.burgess@embecosm.com>
2673             Tom Tromey  <tom@tromey.com>
2674
2675         * common/scope-exit.h: New file.
2676
2677 2019-01-23  Pedro Alves  <palves@redhat.com>
2678
2679         * common/preprocessor.h (ESC): Rename to ...
2680         (ESC_PARENS): ... this.
2681         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
2682         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
2683
2684 2019-01-23  Tom Tromey  <tom@tromey.com>
2685
2686         * language.h (class scoped_switch_to_sym_language_if_auto):
2687         Initialize m_lang in both cases.
2688
2689 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
2690
2691         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
2692         with XCNEW.
2693
2694 2019-01-22  Tom Tromey  <tom@tromey.com>
2695
2696         * corelow.c: Do not include sys/file.h.
2697
2698 2019-01-22  Tom Tromey  <tom@tromey.com>
2699
2700         * tui/tui-wingeneral.h: Include gdb_curses.h.
2701
2702 2019-01-22  Tom Tromey  <tom@tromey.com>
2703
2704         * source-cache.h (class source_cache) <get_source_lines,
2705         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
2706
2707 2019-01-22  Tom Tromey  <tom@tromey.com>
2708
2709         * remote-fileio.h (struct remote_target): Declare.
2710
2711 2019-01-22  Tom Tromey  <tom@tromey.com>
2712
2713         * python/py-arch.c: Do not include py-ref.h.
2714         * python/py-bpevent.c: Do not include py-ref.h.
2715         * python/py-cmd.c: Do not include py-ref.h.
2716         * python/py-continueevent.c: Do not include py-ref.h.
2717         * python/py-event.h: Do not include py-ref.h.
2718         * python/py-evtregistry.c: Do not include py-ref.h.
2719         * python/py-finishbreakpoint.c: Do not include py-ref.h.
2720         * python/py-frame.c: Do not include py-ref.h.
2721         * python/py-framefilter.c: Do not include py-ref.h.
2722         * python/py-function.c: Do not include py-ref.h.
2723         * python/py-infevents.c: Do not include py-ref.h.
2724         * python/py-linetable.c: Do not include py-ref.h.
2725         * python/py-objfile.c: Do not include py-ref.h.
2726         * python/py-param.c: Do not include py-ref.h.
2727         * python/py-prettyprint.c: Do not include py-ref.h.
2728         * python/py-progspace.c: Do not include py-ref.h.
2729         * python/py-symbol.c: Do not include py-ref.h.
2730         * python/py-symtab.c: Do not include py-ref.h.
2731         * python/py-type.c: Do not include py-ref.h.
2732         * python/py-unwind.c: Do not include py-ref.h.
2733         * python/py-utils.c: Do not include py-ref.h.
2734         * python/py-value.c: Do not include py-ref.h.
2735         * python/py-varobj.c: Do not include py-ref.h.
2736         * python/py-xmethods.c: Do not include py-ref.h.
2737         * python/python.c: Do not include py-ref.h.
2738         * varobj.c: Do not include py-ref.h.
2739
2740 2019-01-22  Tom Tromey  <tom@tromey.com>
2741
2742         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2743         keyword for bcache.
2744
2745 2019-01-22  Tom Tromey  <tom@tromey.com>
2746
2747         * compile/compile-cplus-types.c: Remove a comment by #include.
2748
2749 2019-01-22  Tom Tromey  <tom@tromey.com>
2750
2751         * compile/gcc-c-plugin.h: Include compile-internal.h.
2752
2753 2019-01-22  Tom Tromey  <tom@tromey.com>
2754
2755         * stabsread.c (EXTERN): Do not define.
2756         (symnum, next_symbol_text_func, processing_gcc_compilation)
2757         (within_function, global_sym_chain, global_stabs)
2758         (previous_stab_code, this_object_header_files)
2759         (n_this_object_header_files)
2760         (n_allocated_this_object_header_files): Define.
2761         * stabsread.h (EXTERN): Never define.  Use "extern".
2762
2763 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2764
2765         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2766         history_value.
2767
2768 2019-01-21  Tom Tromey  <tom@tromey.com>
2769
2770         * ui-out.c: Fix includes.
2771         * tui/tui-source.c: Fix includes.
2772         * target.c: Fix includes.
2773         * remote.c: Fix includes.
2774         * regcache.c: Fix includes.
2775         * python/py-block.c: Fix includes.
2776         * printcmd.c: Fix includes.
2777         * or1k-tdep.c: Fix includes.
2778         * mi/mi-main.c: Fix includes.
2779         * m32r-tdep.c: Fix includes.
2780         * csky-tdep.c: Fix includes.
2781         * compile/compile-cplus-types.c: Fix includes.
2782         * cli/cli-interp.c: Fix includes.
2783
2784 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
2785
2786         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2787         for padding.
2788
2789 2019-01-16  Tom Tromey  <tom@tromey.com>
2790
2791         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
2792         earlier.
2793         (struct objfile) <msymbols_range>: Move from top level.
2794         <msymbols>: New method.
2795         (class objfile_msymbols): Remove.
2796         * symtab.c (default_collect_symbol_completion_matches_break_on):
2797         Update.
2798         * symmisc.c (dump_msymbols): Update.
2799         * stabsread.c (scan_file_globals): Update.
2800         * objc-lang.c (info_selectors_command, info_classes_command)
2801         (find_methods): Update.
2802         * minsyms.c (find_solib_trampoline_target): Update.
2803         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2804         * coffread.c (coff_symfile_read): Update.
2805         * ada-lang.c (ada_lookup_simple_minsym)
2806         (ada_collect_symbol_completion_matches): Update.
2807
2808 2019-01-16  Tom Tromey  <tom@tromey.com>
2809
2810         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
2811         type.  Remove no-argument constructor.
2812         <iterator::operator++>: Simplify.
2813         <begin>: Update.
2814         <end>: Use minimal_symbol_count.
2815
2816 2019-01-16  Tom Tromey  <tom@tromey.com>
2817
2818         * objfiles.h (struct objfile) <psymtabs>: New method.
2819         (class objfile_psymtabs): Remove.
2820         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2821         typedef.
2822         <range>: New method.
2823         (require_partial_symbols): Change return type.
2824         * psymtab.c (require_partial_symbols)
2825         (psym_expand_symtabs_matching): Update.
2826         * mdebugread.c (parse_partial_symbols): Update.
2827         * dbxread.c (dbx_end_psymtab): Update.
2828
2829 2019-01-15  Tom Tromey  <tom@tromey.com>
2830
2831         * symtab.c (lookup_objfile_from_block)
2832         (lookup_symbol_in_objfile_symtabs)
2833         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2834         (find_line_symtab, info_sources_command)
2835         (default_collect_symbol_completion_matches_break_on)
2836         (make_source_files_completion_list): Update.
2837         * symmisc.c (print_objfile_statistics, dump_objfile)
2838         (maintenance_print_symbols, maintenance_info_symtabs)
2839         (maintenance_check_symtabs, maintenance_info_line_tables):
2840         Update.
2841         * source.c (select_source_symtab)
2842         (forget_cached_source_info_for_objfile): Update.
2843         * objfiles.h (class objfile_compunits): Remove.
2844         (struct objfile) <compunits_range>: New typedef.
2845         (compunits): New method.
2846         * objfiles.c (objfile_relocate1): Update.
2847         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2848         * maint.c (count_symtabs_and_blocks): Update.
2849         * linespec.c (iterate_over_all_matching_symtabs): Update.
2850         * cp-support.c (add_symbol_overload_list_qualified): Update.
2851         * coffread.c (coff_symtab_read): Update.
2852         * ada-lang.c (add_nonlocal_symbols)
2853         (ada_collect_symbol_completion_matches)
2854         (ada_add_global_exceptions): Update.
2855
2856 2019-01-15  Tom Tromey  <tom@tromey.com>
2857
2858         * progspace.h (program_space) <objfiles_safe_range>: New
2859         typedef.
2860         <objfiles_safe>: New method.
2861         * objfiles.h (class all_objfiles_safe): Remove.
2862         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
2863         * jit.c (jit_inferior_exit_hook): Update.
2864
2865 2019-01-17  Tom Tromey  <tom@tromey.com>
2866
2867         * progspace.h (program_space) <objfiles_range>: New typedef.
2868         <objfiles>: New method.
2869         <objfiles_head>: Rename from objfiles.
2870         (object_files): Update.
2871         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
2872         * guile/scm-pretty-print.c
2873         (ppscm_find_pretty_printer_from_objfiles): Update.
2874         * guile/scm-objfile.c (gdbscm_objfiles): Update.
2875         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
2876         Update.
2877         * python/py-progspace.c (pspy_get_objfiles): Update.
2878         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2879         Update.
2880         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2881         (objfpy_lookup_objfile_by_build_id): Update.
2882         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2883         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2884         Update.
2885         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2886         (expand_symtab_containing_pc, lookup_objfile_from_block)
2887         (lookup_static_symbol, basic_lookup_transparent_type)
2888         (find_pc_sect_compunit_symtab, find_symbol_at_address)
2889         (find_line_symtab, info_sources_command)
2890         (default_collect_symbol_completion_matches_break_on)
2891         (make_source_files_completion_list, find_main_name): Update.
2892         * symmisc.c (print_symbol_bcache_statistics)
2893         (print_objfile_statistics, maintenance_print_symbols)
2894         (maintenance_print_msymbols, maintenance_print_objfiles)
2895         (maintenance_info_symtabs, maintenance_check_symtabs)
2896         (maintenance_expand_symtabs, maintenance_info_line_tables):
2897         Update.
2898         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
2899         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
2900         (map_overlay_command, unmap_overlay_command)
2901         (simple_overlay_update, expand_symtabs_matching)
2902         (map_symbol_filenames): Update.
2903         * symfile-debug.c (set_debug_symfile): Update.
2904         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
2905         Update.
2906         * source.c (select_source_symtab, forget_cached_source_info):
2907         Update.
2908         * solib.c (solib_read_symbols): Update.
2909         * solib-spu.c (append_ocl_sos): Update.
2910         * psymtab.c (maintenance_print_psymbols)
2911         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
2912         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
2913         * printcmd.c (info_symbol_command): Update.
2914         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
2915         Update.
2916         * objfiles.h (class all_objfiles): Remove.
2917         * objfiles.c (have_partial_symbols, have_full_symbols)
2918         (have_minimal_symbols, qsort_cmp, update_section_map)
2919         (shared_objfile_contains_address_p)
2920         (default_iterate_over_objfiles_in_search_order): Update.
2921         * objc-lang.c (info_selectors_command, info_classes_command)
2922         (find_methods): Update.
2923         * minsyms.c (find_solib_trampoline_target): Update.
2924         * maint.c (maintenance_info_sections)
2925         (maintenance_translate_address, count_symtabs_and_blocks):
2926         Update.
2927         * main.c (captured_main_1): Update.
2928         * linux-thread-db.c (try_thread_db_load_from_pdir)
2929         (has_libpthread): Update.
2930         * linespec.c (iterate_over_all_matching_symtabs)
2931         (search_minsyms_for_name): Update.
2932         * jit.c (jit_find_objf_with_entry_addr): Update.
2933         * hppa-tdep.c (find_unwind_entry)
2934         (hppa_lookup_stub_minimal_symbol): Update.
2935         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
2936         Update.
2937         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2938         (elf_gnu_ifunc_resolve_by_got): Update.
2939         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
2940         * dwarf-index-write.c (save_gdb_index_command): Update.
2941         * cp-support.c (add_symbol_overload_list_qualified): Update.
2942         * breakpoint.c (create_overlay_event_breakpoint)
2943         (create_longjmp_master_breakpoint)
2944         (create_std_terminate_master_breakpoint)
2945         (create_exception_master_breakpoint): Update.
2946         * blockframe.c (find_pc_partial_function): Update.
2947         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
2948         (ada_collect_symbol_completion_matches)
2949         (ada_add_global_exceptions): Update.
2950
2951 2019-01-17  Tom Tromey  <tom@tromey.com>
2952
2953         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
2954         declare VEC.
2955         (solib_target_parse_libraries): Change return type.
2956         (library_list_start_segment, library_list_start_section)
2957         (library_list_end_library, library_list_start_library); Update.
2958         (solib_target_free_library_list): Remove.
2959         (solib_target_parse_libraries): Remove cleanup.  Change return
2960         type.
2961         (solib_target_current_sos): Update.
2962
2963 2019-01-17  Tom Tromey  <tromey@bapiya>
2964
2965         * valprint.c: Replace "the the" with "the".
2966         * symtab.c: Replace "the the" with "the".
2967         * solib.c: Replace "the the" with "the".
2968         * solib-dsbt.c: Replace "the the" with "the".
2969         * linespec.c: Replace "the the" with "the".
2970         * dwarf2loc.h: Replace "the the" with "the".
2971         * amd64-windows-tdep.c: Replace "the the" with "the".
2972         * aarch64-tdep.c: Replace "the the" with "the".
2973
2974 2019-01-16  Keith Seitz  <keiths@redhat.com>
2975
2976         PR gdb/23773
2977         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
2978         <builder>: Rename to ..
2979         <m_builder>: ... this and make private.
2980         (dwarf2_cu::get_builder): New method.  Change all users of
2981         `builder' to use this method.
2982         (dwarf2_start_symtab): Move to ...
2983         (dwarf2_cu::start_symtab): ... here.  Update all callers
2984         (setup_type_unit_groups): Move to ...
2985         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
2986         callers.
2987         (dwarf2_cu::reset_builder): New method.
2988         (process_full_compunit, process_full_type_unit): Use
2989         dwarf2_cu::reset_builder.
2990         (follow_die_offset): Record the ancestor CU if it is different
2991         from the followed DIE's CU.
2992         (follow_die_sig_1): Likewise.
2993
2994 2019-01-15  Tom Tromey  <tom@tromey.com>
2995
2996         * remote.c (class remote_state) <buf>: Now a char_vector.
2997         <buf_size>: Remove.
2998         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
2999         parameter.
3000         (remote_target::getpkt_or_notif_sane_1)
3001         (remote_target::getpkt_sane)
3002         (remote_target::getpkt_or_notif_sane): Likewise.
3003         (class remote_target) <putpkt>: New overload.
3004         (remote_target::read_frame): Change type of "buf_p".  Remove
3005         sizeof_p parameter.
3006         (packet_ok): New overload.
3007         (packet_check_result): New overload.
3008         Update all uses.
3009
3010 2019-01-14  Tom Tromey  <tom@tromey.com>
3011
3012         * remote-notif.c (handle_notification, remote_notif_ack)
3013         (remote_notif_parse): Make "buf" const.
3014         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
3015         const.
3016         (remote_notif_parse, remote_notif_ack, handle_notification):
3017         Likewise.
3018         * remote.c (remote_notif_stop_parse): Make "buf" const.
3019         (remote_target::remote_parse_stop_reply): Make "buf" const.
3020         (remote_notif_stop_ack): Make "buf" const.
3021
3022 2019-01-14  Tom Tromey  <tom@tromey.com>
3023
3024         * remote.c (remote_console_output): Make parameter const.
3025
3026 2019-01-14  Tom Tromey  <tom@tromey.com>
3027
3028         * target-debug.h (target_debug_print_signals): Constify.
3029         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
3030         * procfs.c (procfs_target::pass_signals): Update.
3031         * linux-nat.c (linux_nat_target::pass_signals): Update.
3032         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
3033         * target-delegates.c: Rebuild.
3034         * remote.c (remote_target::program_signals): Update.
3035         (remote_target::pass_signals): Update.
3036         * target.c (target_pass_signals): Constify argument.
3037         (target_program_signals): Likewise.
3038         * target.h (struct target_ops) <pass_signals, program_signals>:
3039         Constify argument.
3040         (target_pass_signals, target_program_signals): Constify argument.
3041
3042 2019-01-14  Tom Tromey  <tom@tromey.com>
3043
3044         PR tui/28819:
3045         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
3046
3047 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3048
3049         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
3050         field.
3051         * rs6000-tdep.c: Include reggroups.h.
3052         (IS_V_ALIAS_PSEUDOREG): Define.
3053         (rs6000_register_name): Return names for the "vX" aliases.
3054         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
3055         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
3056         aliases.  Call default_register_reggroup_p for all other
3057         pseudo-registers.
3058         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
3059         New functions.
3060         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
3061         Handle "vX" aliases.
3062         (v_alias_pseudo_register_collect): New function.
3063         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
3064         (rs6000_gdbarch_init): Initialize "vX" aliases as
3065         pseudo-registers.  Restore registration of
3066         rs6000_pseudo_register_reggroup_p with
3067         set_tdesc_pseudo_register_reggroup_p.
3068
3069 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
3070
3071         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
3072         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
3073         set_gdbarch_num_pseudo_regs.
3074
3075 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3076
3077         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
3078         Remove arg prefixname, add do_set and do_show.
3079         Add member functions set_list and show_list.
3080         * cli/cli-style.c (class cli_style_option): Update accordingly.
3081         (style_set_list): Move to file scope.
3082         (style_show_list): Likewise.
3083         (set_style): Call help_list.
3084         (show_style): Call cmd_show_list.
3085         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
3086         Update to use the new macro.
3087
3088 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
3089
3090         * ada-lang.c (_initialize_ada_language): Expand the help text
3091         for the "catch exception" command.
3092
3093 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3094
3095         * symtab.c (matching_obj_sections): Initialize obj,
3096         declare it closer to its usage.
3097
3098 2019-01-10  Tom Tromey  <tom@tromey.com>
3099
3100         * thread-iter.h (inf_threads_iterator): Use next_iterator.
3101         (basic_inf_threads_range): Remove.
3102         (inf_threads_range, inf_non_exited_threads_range)
3103         (safe_inf_threads_range): Use next_adapter.
3104
3105 2019-01-10  Keith Seitz  <keiths@redhat.com>
3106
3107         PR gdb/23712
3108         PR symtab/23010
3109         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
3110         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
3111
3112 2019-01-10  Keith Seitz  <keiths@redhat.com>
3113
3114         PR gdb/23712
3115         PR symtab/23010
3116         * dictionary.c (pending_to_vector): Remove.
3117         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3118         Remove _1 suffix, replacing functions of the same name.  Update
3119         all callers.
3120         (dict_create_hashed, dict_create_hashed_expandable)
3121         (dict_create_linear, dict_create_linear_expandable, dict_free)
3122         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
3123         Make functions static.
3124
3125 2019-01-10  Keith Seitz  <keiths@redhat.com>
3126
3127         PR gdb/23712
3128         PR symtab/23010
3129         * dictionary.h (struct dictionary): Replace declaration with
3130         multidictionary.
3131         (dict_create_hashed, dict_create_hashed_expandable)
3132         (dict_create_linear, dict_create_linear_expandable)
3133         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
3134         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
3135         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
3136         taking multidictionary argument.
3137         [ALL_DICT_SYMBOLS]: Update for multidictionary.
3138         * block.h (struct block) <dict>: Change to multidictionary
3139         and rename `multidict'.
3140         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
3141         symmisc.c: Update all dictionary references to multidictionary.
3142
3143 2019-01-10  Keith Seitz  <keiths@redhat.com>
3144
3145         PR gdb/23712
3146         PR symtab/23010
3147         * dictionary.c: Include unordered_map.
3148         (pending_to_vector): New function.
3149         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3150         Rewrite the non-"_1" functions to take vector instead
3151         of linked list.
3152         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
3153         "new" _1 versions of the same name.
3154         (multidictionary): Define.
3155         (std::hash<enum language): New definition.
3156         (collate_pending_symbols_by_language, mdict_create_hashed)
3157         (mdict_create_hashed_expandable, mdict_create_linear)
3158         (mdict_create_linear_expandable, mdict_free)
3159         (find_language_dictionary, create_new_language_dictionary)
3160         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
3161         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
3162         (mdict_size, mdict_empty): New functions.
3163         * dictionary.h (mdict_iterator): Define.
3164
3165 2019-01-10  Pedro Alves  <palves@redhat.com>
3166
3167         * breakpoint.c (read_uploaded_action)
3168         (create_tracepoint_from_upload): Adjust to use
3169         gdb::unique_xmalloc_ptr.
3170         * ctf.c (ctf_write_uploaded_tp):
3171         (SET_ARRAY_FIELD): Use emplace_back.
3172         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
3173         * tracefile-tfile.c (tfile_write_uploaded_tp):
3174         * tracepoint.c (parse_tracepoint_definition): Adjust to use
3175         gdb::unique_xmalloc_ptr.
3176         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
3177         at_string, cond_string, cmd_strings>: Replace char pointers
3178         with gdb::unique_xmalloc_ptr.
3179
3180 2019-01-10  Pedro Alves  <palves@redhat.com>
3181
3182         * solib-target.c (library_list_start_library): Don't xstrdup name.
3183
3184 2019-01-10  Pedro Alves  <palves@redhat.com>
3185
3186         * mdebugread.c (parse_partial_symbols): Use
3187         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
3188
3189 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3190
3191         * linux-fork.c (scoped_switch_fork_info)
3192         <~scoped_switch_fork_info>: Fix incorrect variable name.
3193
3194 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3195
3196         * linux-fork.c (scoped_switch_fork_info)
3197         <scoped_switch_fork_info>: Make explicit.
3198         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
3199
3200 2019-01-10  Tom Tromey  <tom@tromey.com>
3201
3202         * objfiles.h (objfile::reset_psymtabs): Update.
3203         * objfiles.c (objfile::objfile): Update.
3204         * psymtab.h (psymtab_storage::obstack): Update.
3205         (psymtab_storage::m_obstack): Use gdb::optional.
3206         (class psymtab_storage): Update comment.  Remove objfile
3207         parameter.
3208         * psymtab.c (psymtab_storage::psymtab_storage): Update.
3209
3210 2019-01-10  Tom Tromey  <tom@tromey.com>
3211
3212         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
3213         <free_psymtabs>: Now private.
3214         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
3215         (allocate_psymtab): Use new method.
3216
3217 2019-01-10  Tom Tromey  <tom@tromey.com>
3218
3219         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
3220         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
3221         * mdebugread.c (parse_partial_symbols): Use
3222         allocate_dependencies.
3223         * dwarf2read.c (dwarf2_create_include_psymtab): Use
3224         allocate_dependencies.
3225         (process_psymtab_comp_unit_reader)
3226         (build_type_psymtab_dependencies): Likewise.
3227         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
3228
3229 2019-01-10  Tom Tromey  <tom@tromey.com>
3230
3231         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
3232         PSYMBOL_SET_LANGUAGE.
3233         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
3234
3235 2019-01-10  Tom Tromey  <tom@tromey.com>
3236
3237         * psymtab.h (psymtab_storage::obstack): New method.
3238         <m_obstack>: Rename from obstack; now private.
3239         * psymtab.c (psymtab_storage): Update.
3240         * dwarf2read.c (create_addrmap_from_index)
3241         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
3242         Update.
3243
3244 2019-01-10  Tom Tromey  <tom@tromey.com>
3245
3246         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
3247         * objfiles.h (objfile::reset_psymtabs): New method.
3248
3249 2019-01-10  Tom Tromey  <tom@tromey.com>
3250
3251         * symmisc.c (print_symbol_bcache_statistics): Update.
3252         (print_objfile_statistics): Update.
3253         * symfile.c (reread_symbols): Update.
3254         * psymtab.h (class psymtab_storage): New.
3255         * psymtab.c (psymtab_storage): New constructor.
3256         (~psymtab_storage): New destructor.
3257         (require_partial_symbols): Update.
3258         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
3259         (find_pc_sect_psymtab, find_pc_sect_psymbol)
3260         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
3261         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
3262         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
3263         (start_psymtab_common, end_psymtab_common)
3264         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
3265         (allocate_psymtab): Update.
3266         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
3267         Update.
3268         (dump_psymtab_addrmap, maintenance_print_psymbols)
3269         (maintenance_check_psymtabs): Update.
3270         (class objfile_psymtabs): Move to objfiles.h.
3271         * psympriv.h (discard_psymtab): Now inline.
3272         (psymtab_discarder::psymtab_discarder): Update.
3273         (psymtab_discarder::~psymtab_discarder): Update.
3274         (ALL_OBJFILE_PSYMTABS): Rewrite.
3275         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
3276         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
3277         Remove fields.
3278         <partial_symtabs>: New field.
3279         (class objfile_psymtabs): Move from psymtab.h.  Update.
3280         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
3281         psymbol_cache.
3282         (objfile::~objfile): Don't destroy psymbol_cache.
3283         * mdebugread.c (parse_partial_symbols): Update.
3284         * dwarf2read.c (create_addrmap_from_index)
3285         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
3286         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
3287         (add_partial_subprogram, dwarf2_ranges_read): Update.
3288         * dwarf-index-write.c (write_address_map)
3289         (write_one_signatured_type, recursively_write_psymbols)
3290         (class debug_names, class debug_names, write_psymtabs_to_index):
3291         Update.
3292
3293 2019-01-10  Tom Tromey  <tom@tromey.com>
3294
3295         * symtab.h (SYMBOL_SET_NAMES): Update.
3296         (symbol_set_names): Update.
3297         (MSYMBOL_SET_NAMES): Update.
3298         * symtab.c (symbol_set_names): Change argument to be an
3299         objfile_per_bfd_storage.
3300         * psymtab.c (add_psymbol_to_bcache): Update.
3301         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
3302
3303 2019-01-10  Tom Tromey  <tom@tromey.com>
3304
3305         * symtab.c (create_demangled_names_hash): Change argument to be an
3306         objfile_per_bfd_storage.
3307         (symbol_set_names): Update.
3308
3309 2019-01-10  Tom Tromey  <tom@tromey.com>
3310
3311         * xcoffread.c (xcoff_initial_scan): Unconditionally call
3312         init_psymbol_list.
3313         * psymtab.c (init_psymbol_list): Do nothing if already called.
3314         * psympriv.h (init_psymbol_list): Add comment.
3315         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
3316         init_psymbol_list.
3317         * dbxread.c (dbx_symfile_read): Unconditionally call
3318         init_psymbol_list.
3319
3320 2019-01-10  Tom Tromey  <tom@tromey.com>
3321
3322         * xcoffread.c (scan_xcoff_symtab): Update.
3323         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
3324         "where".
3325         * mdebugread.c (parse_partial_symbols)
3326         (handle_psymbol_enumerators): Update.
3327         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
3328         * dbxread.c (read_dbx_symtab): Update.
3329         * psympriv.h (psymbol_placement): New enum.
3330         (add_psymbol_to_list): Update.
3331
3332 2019-01-10  Tom Tromey  <tom@tromey.com>
3333
3334         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
3335         static_psymbols parameters.
3336         (scan_xcoff_symtab): Update.
3337         * psymtab.c (start_psymtab_common): Remove global_psymbols and
3338         static_psymbols parameters.
3339         * psympriv.h (start_psymtab_common): Update.
3340         * mdebugread.c (parse_partial_symbols): Update.
3341         * dwarf2read.c (create_partial_symtab): Update.
3342         * dbxread.c (read_dbx_symtab): Update.
3343         (start_psymtab): Remove global_psymbols and static_psymbols
3344         parameters.
3345
3346 2019-01-10  Tom Tromey  <tom@tromey.com>
3347
3348         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
3349         * psymtab.c (allocate_psymtab): Add comment.
3350         * psympriv.h (allocate_psymtab): Add comment.
3351         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
3352         initializations.
3353         * dbxread.c (dbx_end_psymtab): Remove some initializations.
3354
3355 2019-01-10  Tom Tromey  <tom@tromey.com>
3356
3357         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3358         Don't declare.
3359         * mipsread.c: Include mdebugread.h.
3360         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3361         Declare.
3362         * elfread.c: Include mdebugread.h.
3363
3364 2019-01-09  Tom Tromey  <tom@tromey.com>
3365
3366         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
3367         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
3368         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
3369         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
3370         (psym_lookup_symbol, psym_find_last_source_symtab)
3371         (psym_forget_cached_source_info, psym_print_stats)
3372         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
3373         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
3374         (psym_map_matching_symbols, psym_expand_symtabs_matching)
3375         (psym_find_compunit_symtab_by_address)
3376         (maintenance_print_psymbols, maintenance_info_psymtabs)
3377         (maintenance_check_psymtabs): Use ranged for.
3378         * psymtab.h (class objfile_psymtabs): New.
3379         (require_partial_symbols): Return objfile_psymtabs.
3380         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
3381
3382 2019-01-09  Tom Tromey  <tom@tromey.com>
3383
3384         * symfile.c (overlay_invalidate_all, find_pc_overlay)
3385         (find_pc_mapped_section, list_overlays_command)
3386         (map_overlay_command, unmap_overlay_command)
3387         (simple_overlay_update): Use all_objfiles.
3388         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
3389         * printcmd.c (info_symbol_command): Use all_objfiles.
3390         * objfiles.h (ALL_OBJSECTIONS): Remove.
3391         * maint.c (maintenance_translate_address): Use all_objfiles.
3392         * gcore.c (gcore_create_callback): Use all_objfiles.
3393         (objfile_find_memory_regions): Likewise.
3394
3395 2019-01-09  Tom Tromey  <tom@tromey.com>
3396
3397         * symtab.c (find_line_symtab, info_sources_command)
3398         (make_source_files_completion_list): Use objfile_compunits.
3399         * source.c (select_source_symtab): Use objfile_compunits.
3400         * objfiles.h (struct objfile): Update comment.
3401         (ALL_OBJFILES): Remove.
3402         (ALL_FILETABS): Remove.
3403         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
3404         objfile_compunits.
3405
3406 2019-01-09  Tom Tromey  <tom@tromey.com>
3407
3408         * symmisc.c (print_objfile_statistics, dump_objfile)
3409         (maintenance_print_symbols): Use compunit_filetabs.
3410         * source.c (forget_cached_source_info_for_objfile): Use
3411         compunit_filetabs.
3412         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
3413         (ALL_FILETABS): Use compunit_filetabs.
3414         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
3415         * coffread.c (coff_symtab_read): Use compunit_filetabs.
3416
3417 2019-01-09  Tom Tromey  <tom@tromey.com>
3418
3419         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
3420         (compunit_filetabs): New.
3421         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
3422         compunit_filetabs.
3423         (info_sources_command, make_source_files_completion_list): Remove
3424         declaration.
3425         * symmisc.c (print_objfile_statistics, dump_objfile)
3426         (maintenance_print_symbols): Remove declaration.
3427         (maintenance_info_symtabs): Use compunit_filetabs.
3428         (maintenance_info_line_tables): Likewise.
3429         * source.c (select_source_symtab): Change local variable name.
3430         (forget_cached_source_info_for_objfile): Remove declaration.
3431         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
3432         * objfiles.c (objfile_relocate1): Remove declaration.
3433         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3434         declaration.
3435         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
3436         * coffread.c (coff_symtab_read): Remove declaration.
3437         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3438         compunit_filetabs.
3439
3440 2019-01-09  Tom Tromey  <tom@tromey.com>
3441
3442         * symtab.c (lookup_objfile_from_block)
3443         (find_pc_sect_compunit_symtab, search_symbols)
3444         (default_collect_symbol_completion_matches_break_on): Use
3445         objfile_compunits.
3446         * objfiles.h (ALL_COMPUNITS): Remove.
3447         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
3448         * cp-support.c (add_symbol_overload_list_qualified): Use
3449         objfile_compunits.
3450         * ada-lang.c (ada_collect_symbol_completion_matches)
3451         (ada_add_global_exceptions): Use objfile_compunits.
3452
3453 2019-01-09  Tom Tromey  <tom@tromey.com>
3454
3455         * source.c (select_source_symtab)
3456         (forget_cached_source_info_for_objfile): Remove declaration.
3457         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3458         declaration.
3459         * maint.c (count_symtabs_and_blocks): Remove declaration.
3460         * cp-support.c (add_symbol_overload_list_qualified): Remove
3461         declaration.
3462         * coffread.c (coff_symtab_read): Remove declaration.
3463         * symtab.c (lookup_symbol_in_objfile_symtabs)
3464         (basic_lookup_transparent_type_1): Use objfile_compunits.
3465         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
3466         (info_sources_command, search_symbols)
3467         (default_collect_symbol_completion_matches_break_on)
3468         (make_source_files_completion_list): Remove declaration.
3469         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
3470         (ada_collect_symbol_completion_matches)
3471         (ada_add_global_exceptions): Remove declaration.
3472         * linespec.c (iterate_over_all_matching_symtabs): Use
3473         objfile_compunits.
3474         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
3475         (class objfile_compunits): New.
3476         (ALL_COMPUNITS): Use objfile_compunits.
3477         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
3478         (maintenance_check_symtabs, maintenance_info_line_tables): Use
3479         objfile_compunits.
3480         * objfiles.c (objfile_relocate1): Use objfile_compunits.
3481
3482 2019-01-09  Tom Tromey  <tom@tromey.com>
3483
3484         * symtab.c (search_symbols)
3485         (default_collect_symbol_completion_matches_break_on): Use
3486         objfile_msymbols.
3487         * ada-lang.c (ada_lookup_simple_minsym)
3488         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
3489         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
3490         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
3491         objfile_msymbols.
3492         * coffread.c (coff_symfile_read): Use objfile_msymbols.
3493         * symmisc.c (dump_msymbols): Use objfile_msymbols.
3494         * objc-lang.c (find_methods): Use objfile_msymbols.
3495         (info_selectors_command, info_classes_command): Likewise.
3496         * stabsread.c (scan_file_globals): Use objfile_msymbols.
3497         * objfiles.h (class objfile_msymbols): New.
3498         (ALL_OBJFILE_MSYMBOLS): Remove.
3499         (ALL_MSYMBOLS): Remove.
3500
3501 2019-01-09  Tom Tromey  <tom@tromey.com>
3502
3503         * common/next-iterator.h (next_adapter): Add Iterator template
3504         parameter.
3505         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3506         (class all_objfiles_safe): New.
3507         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3508         * objfiles.c (put_objfile_before): Update comment.
3509         (add_separate_debug_objfile): Likewise.
3510         (free_all_objfiles): Use all_objfiles_safe.
3511         (objfile_purge_solibs): Likewise.
3512
3513 2019-01-09  Tom Tromey  <tom@tromey.com>
3514
3515         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3516         (expand_symtab_containing_pc, lookup_static_symbol)
3517         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3518         (find_symbol_at_address, find_line_symtab, find_main_name): Use
3519         all_objfiles.
3520         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3521         * breakpoint.c (create_overlay_event_breakpoint)
3522         (create_longjmp_master_breakpoint)
3523         (create_std_terminate_master_breakpoint)
3524         (create_exception_master_breakpoint): Use all_objfiles.
3525         * linux-thread-db.c (try_thread_db_load_from_pdir)
3526         (has_libpthread): Use all_objfiles.
3527         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3528         * linespec.c (iterate_over_all_matching_symtabs)
3529         (search_minsyms_for_name): Use all_objfiles.
3530         * maint.c (maintenance_info_sections): Use all_objfiles.
3531         * main.c (captured_main_1): Use all_objfiles.
3532         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3533         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3534         * guile/scm-pretty-print.c
3535         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3536         * solib-spu.c (append_ocl_sos): Use all_objfiles.
3537         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3538         (maintenance_print_msymbols): Use all_objfiles.
3539         * source.c (select_source_symtab): Use all_objfiles.
3540         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3541         * symfile.c (remove_symbol_file_command)
3542         (expand_symtabs_matching, map_symbol_filenames): Use
3543         all_objfiles.
3544         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3545         all_objfiles.
3546         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3547         * objc-lang.c (find_methods): Use all_objfiles.
3548         * objfiles.c (have_partial_symbols, have_full_symbols)
3549         (have_minimal_symbols, qsort_cmp)
3550         (default_iterate_over_objfiles_in_search_order): Use
3551         all_objfiles.
3552         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3553         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3554         (maintenance_check_psymtabs): Use all_objfiles.
3555         (ALL_PSYMTABS): Remove.
3556         * compile/compile-object-run.c (do_module_cleanup): Use
3557         all_objfiles.
3558         * blockframe.c (find_pc_partial_function): Use all_objfiles.
3559         * cp-support.c (add_symbol_overload_list_qualified): Use
3560         all_objfiles.
3561         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3562         Use all_objfiles.
3563         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3564         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3565         all_objfiles.
3566         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3567         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
3568         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3569         Uses all_objfiles.
3570         * solib.c (solib_read_symbols): Use all_objfiles
3571
3572 2019-01-09  Tom Tromey  <tom@tromey.com>
3573
3574         * probe.c (parse_probes_in_pspace): Use all_objfiles.
3575         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
3576         all_objfiles.
3577         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
3578         * symmisc.c (print_symbol_bcache_statistics)
3579         (print_objfile_statistics, maintenance_print_objfiles)
3580         (maintenance_info_symtabs, maintenance_check_symtabs)
3581         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
3582         all_objfiles.
3583         * source.c (forget_cached_source_info): Use all_objfiles.
3584         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
3585         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3586         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
3587         * objfiles.c (update_section_map): Use all_objfiles.
3588         (shared_objfile_contains_address_p): Likewise.
3589         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
3590         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
3591
3592 2019-01-09  Tom Tromey  <tom@tromey.com>
3593
3594         * common/next-iterator.h: New file.
3595         * objfiles.h (class all_objfiles): New.
3596         (struct objfile_iterator): New.
3597
3598 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3599
3600         * NEWS: Move the description of the changed "frame", "select-frame",
3601          and "info frame" commands to the Changed commands section.
3602
3603 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
3604
3605         * gdbtypes.c (check_stub_method_group): Remove handling of old
3606         mangling schemes.
3607         * linespec.c (find_methods): Likewise.
3608         * stabsread.c (read_member_functions): Likewise.
3609         * valops.c (search_struct_method): Likewise.
3610         (value_struct_elt_for_reference): Likewise.
3611         * NEWS: Mention this change.
3612
3613 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3614
3615         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
3616         print_source_lines.
3617         * source.c (print_source_lines_base): Update line number check.
3618         (print_source_lines): New function.
3619         (source_lines_range::source_lines_range): New function.
3620         * source.h (class source_lines_range): New class.
3621         (print_source_lines): New declaration.
3622
3623 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3624
3625         * linespec.c (linespec_state_destructor): Free self->canonical_names.
3626
3627 2019-01-08  Tom Tromey  <tom@tromey.com>
3628             Simon Marchi  <simon.marchi@ericsson.com>
3629
3630         PR gdb/24060
3631         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
3632         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
3633         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3634         * f-exp.y (DOLLAR_VARIABLE): Likewise.
3635         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
3636         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3637
3638 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3639
3640         * source.c (select_source_symtab): Move header comment to
3641         declaration in source.h.
3642         (forget_cached_source_info_for_objfile): Likewise.
3643         (forget_cached_source_info): Likewise.
3644         (identify_source_line): Likewise.
3645         * source.h (identify_source_line): Move declaration from symtab.h
3646         and add comment from source.c
3647         (print_source_lines): Likewise.
3648         (forget_cached_source_info_for_objfile): Likewise.
3649         (forget_cached_source_info): Likewise.
3650         (select_source_symtab): Likewise.
3651         (enum print_source_lines_flag): Move definition from symtab.h.
3652         * symtab.h (identify_source_line): Move declaration to source.h.
3653         (print_source_lines): Likewise.
3654         (forget_cached_source_info_for_objfile): Likewise.
3655         (forget_cached_source_info): Likewise.
3656         (select_source_symtab): Likewise.
3657         (enum print_source_lines_flag): Move definition to source.h.
3658         * tui/tui-hooks.c: Add 'source.h' include.
3659
3660 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3661
3662         * source.c (print_source_lines_base): Handle requests to print
3663         reverse line number sequences, and guard against empty lines
3664         string.
3665
3666 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3667
3668         * source.c (print_source_lines_base): Fix skip of '\r' if next
3669         character is '\n'.
3670
3671 2019-01-06  Tom Tromey  <tom@tromey.com>
3672
3673         * c-exp.y (struct c_parse_state) <macro_original_text,
3674         expansion_obstack>: New member.
3675         (macro_original_text, expansion_obstack): Remove globals.
3676         (scan_macro_expansion, scanning_macro_expansion)
3677         (finished_macro_expansion): Update.
3678         (scan_macro_cleanup): Remove.
3679         (yylex, c_parse): Update.
3680
3681 2019-01-06  Tom Tromey  <tom@tromey.com>
3682
3683         * c-exp.y (struct c_parse_state) <strings>: New member.
3684         (operator_stoken): Update.
3685
3686 2019-01-06  Tom Tromey  <tom@tromey.com>
3687
3688         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
3689         (union type_stack_elt) <typelist_val>: Now a pointer to
3690         std::vector.
3691         (type_stack_cleanup): Don't declare.
3692         (push_typelist): Update.
3693         * parse.c (pop_typelist): Return a std::vector.
3694         (push_typelist): Take a std::vector.
3695         (follow_types): Update.  Do not free args.
3696         (type_stack_cleanup): Remove.
3697         * c-exp.y (struct c_parse_state): New.
3698         (cpstate): New global.
3699         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
3700         (nonempty_typelist): Update.
3701         (func_mod): Create a new vector.
3702         (c_parse): Create a c_parse_state.
3703         (check_parameter_typelist): Do not delete params.
3704         (function_method): Update.  Do not delete type_list.
3705
3706 2019-01-06  Tom Tromey  <tom@tromey.com>
3707
3708         PR gdb/28155:
3709         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
3710         check_typedef.
3711         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
3712         (print_return_value): Likewise.
3713
3714 2019-01-05  Tom Tromey  <tom@tromey.com>
3715
3716         * contrib/cleanup_check.py: Remove.
3717         * contrib/gcc-with-excheck: Remove.
3718         * contrib/exsummary.py: Remove.
3719         * contrib/excheck.py: Remove.
3720
3721 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
3722
3723         * thread.c (delete_thread_1): Add gdb_assert that THR is not
3724         NULL. Initialize tpprev to NULL instead of assigning it
3725         to NULL on the next statement.
3726         * windows-nat.c (windows_delete_thread): Remove check for
3727         main_thread_id before printing thread exit notifications.
3728         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
3729         Remove thread ID check against main_thread_id.
3730         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
3731         windows_delete_thread.
3732         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
3733
3734 2019-01-04  Tom Tromey  <tom@tromey.com>
3735
3736         * compile/compile.c (_initialize_compile): Use upper case for
3737         metasyntactic variables.
3738         * symmisc.c (_initialize_symmisc): Use upper case for
3739         metasyntactic variables.
3740         * psymtab.c (_initialize_psymtab): Use upper case for
3741         metasyntactic variables.
3742         * demangle.c (demangle_command): Use upper case for metasyntactic
3743         variables.
3744         (_initialize_demangler): Likewise.
3745         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3746         variables.
3747
3748 2019-01-03  Tom Tromey  <tom@tromey.com>
3749
3750         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3751
3752 2019-01-03  Tom Tromey  <tom@tromey.com>
3753
3754         * python/py-symtab.c (salpy_str): Update.
3755         (struct salpy_sal_object) <symtab>: Now a PyObject.
3756         (salpy_dealloc): Update.
3757         (del_objfile_sal): Use gdbpy_ref.
3758
3759 2019-01-03  Tom Tromey  <tom@tromey.com>
3760
3761         * python/py-type.c (convert_field): Use new_reference.  Return
3762         gdbpy_ref.
3763         (make_fielditem): Return gdbpy_ref.
3764         (typy_fields): Update.
3765         (typy_getitem): Update.
3766         (field_name): Return gdbpy_ref.  Use new_reference.
3767         (typy_iterator_iternext): Update.
3768
3769 2019-01-03  Tom Tromey  <tom@tromey.com>
3770
3771         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3772
3773 2019-01-03  Tom Tromey  <tom@tromey.com>
3774
3775         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3776         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3777         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3778         (pspy_set_frame_filters, pspy_set_frame_unwinders)
3779         (pspy_set_type_printers): Likewise.
3780         * python/py-function.c (fnpy_init): Use gdbpy_ref.
3781         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3782         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3783         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
3784         (objfpy_set_type_printers): Likewise.
3785
3786 2019-01-03  Tom Tromey  <tom@tromey.com>
3787
3788         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
3789         (gdbpy_print_stack): Use gdbpy_err_fetch.
3790         * python/python-internal.h (class gdbpy_err_fetch): New class.
3791         (class gdbpy_enter) <m_error_type, m_error_value,
3792         m_error_traceback>: Remove.
3793         <m_error>: New member.
3794         (gdbpy_exception_to_string): Don't declare.
3795         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
3796         * python/py-value.c (convert_value_from_python): Use
3797         gdbpy_err_fetch.
3798         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
3799         gdbpy_exception_to_string.
3800         (gdbpy_handle_exception): Use gdbpy_err_fetch.
3801         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3802         gdbpy_err_fetch.
3803
3804 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3805
3806         * linux-nat.c (delete_lwp_cleanup): Delete.
3807         (struct lwp_deleter): New struct.
3808         (lwp_info_up): New typedef.
3809         (linux_nat_target::follow_fork): Delete cleanup, and make use of
3810         lwp_info_up.
3811
3812 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3813
3814         * linux-fork.c (class scoped_switch_fork_info): New class.
3815         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3816
3817 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3818
3819         * valops.c (find_overload_match): Remove use of null_cleanup, and
3820         calls to do_cleanups.
3821
3822 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3823
3824         * compile/compile-cplus-types.c
3825         (compile_cplus_instance::decl_name): Handle changes to
3826         cp_func_name.
3827         * cp-support.c (cp_func_name): Update header comment, update
3828         return type.
3829         * cp-support.h (cp_func_name): Update return type in declaration.
3830         * valops.c (find_overload_match): Move temp_func local to top
3831         level of function and change its type.  Use temp_func to hold and
3832         delete temporary string obtained from cp_func_name.
3833
3834 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3835
3836         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3837         gdb::char_vector, remove cleanup, and update uses of `msg`.
3838
3839 2019-01-03  Jim Wilson  <jimw@sifive.com>
3840
3841         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3842
3843 2019-01-02  Tom Tromey  <tom@tromey.com>
3844
3845         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3846         (tdesc_parse_xml): Remove cleanups.
3847         * target-descriptions.h (make_cleanup_free_target_description):
3848         Don't declare.
3849         (target_desc_deleter): New struct.
3850         (target_desc_up): New typedef.
3851         * target-descriptions.c (target_desc_deleter::operator()): Rename
3852         from free_target_description.
3853         (make_cleanup_free_target_description): Remove.
3854
3855 2019-01-02  Tom Tromey  <tom@tromey.com>
3856
3857         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
3858         constructor, destructor.
3859         (linespec_parser): Remove typedef.
3860         (~linespec_parser): Rename from linespec_parser_delete.
3861         (linespec_lex_to_end, linespec_complete_label)
3862         (linespec_complete): Update.
3863         (decode_line_full): Remove cleanups.
3864         (decode_line_1): Update.
3865
3866 2019-01-02  Tom Tromey  <tom@tromey.com>
3867
3868         * python/python-internal.h (inferior_to_inferior_object): Change
3869         return type.
3870         * python/py-exitedevent.c (create_exited_event_object): Update.
3871         * python/py-inferior.c (inferior_to_inferior_object): Return
3872         gdbpy_ref.
3873         (python_new_inferior, python_inferior_deleted)
3874         (thread_to_thread_object, delete_thread_object)
3875         (build_inferior_list, gdbpy_selected_inferior): Update.
3876         * python/py-infthread.c (create_thread_object): Update.  Also fail
3877         if inferior_to_inferior_object fails.
3878
3879 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
3880
3881         * inferior.h (class inferior) <displaced_step_state>: New field.
3882         * infrun.h (struct displaced_step_state): Move here from
3883         infrun.c.  Initialize fields, add constructor.
3884         <inf>: Remove field.
3885         <reset>: New method.
3886         * infrun.c (struct displaced_step_inferior_state): Move to
3887         infrun.h.
3888         (displaced_step_inferior_states): Remove.
3889         (get_displaced_stepping_state): Adust.
3890         (displaced_step_in_progress_any_inferior): Adjust.
3891         (displaced_step_in_progress_thread): Adjust.
3892         (displaced_step_in_progress): Adjust.
3893         (add_displaced_stepping_state): Remove.
3894         (get_displaced_step_closure_by_addr): Adjust.
3895         (remove_displaced_stepping_state): Remove.
3896         (infrun_inferior_exit): Call displaced_step_state.reset.
3897         (use_displaced_stepping): Don't check for NULL.
3898         (displaced_step_prepare_throw): Call
3899         get_displaced_stepping_state.
3900         (displaced_step_fixup): Don't check for NULL.
3901         (prepare_for_detach): Don't check for NULL.
3902
3903 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3904
3905         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
3906          in case of call that did not complete.
3907
3908 2019-01-02  Andrey Utkin  <autkin@undo.io>
3909
3910         * symfile.c (find_separate_debug_file): Fix search of debug files for
3911         remote debuggee.
3912
3913 2019-01-02  Tom Tromey  <tom@tromey.com>
3914
3915         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
3916         indentation.
3917         * python/py-frame.c (frapy_older): Remove cast.
3918         (frapy_newer): Likewise.
3919         * python/py-breakpoint.c (local_setattro): Remove cast.
3920         * python/py-arch.c (archpy_name): Remove local variable.
3921         * python/py-type.c (gdbpy_lookup_type): Remove cast.
3922
3923 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
3924
3925         * unittests/basic_string_view/element_access/char/empty.cc:
3926         Fix year range in copyright header.
3927
3928 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3929
3930         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
3931         Delete.
3932         <operator==>: Update with for removed field.
3933         <hash>: Likewise.
3934         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
3935         <isa_features>: ...this.
3936         <abi_features>: New field.
3937         (riscv_isa_flen): Update comment.
3938         (riscv_abi_xlen): New declaration.
3939         (riscv_abi_flen): New declaration.
3940         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
3941         isa_features.
3942         (riscv_abi_xlen): New function.
3943         (riscv_isa_flen): Update to get answer from isa_features.
3944         (riscv_abi_flen): New function.
3945         (riscv_has_fp_abi): Update to get answer from abi_features.
3946         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
3947         xlen and flen.
3948         (riscv_call_info) <xlen, flen>: Update comment.
3949         (riscv_call_arg_struct): Remove invalid assertions
3950         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
3951         is removed.
3952         (riscv_gdbarch_init): Gather isa features and abi features
3953         separately, ensure both match on the gdbarch when reusing an old
3954         gdbarch.  Relax an error check to allow 32-bit abi float to run on
3955         a target with 64-bit float hardware.
3956
3957 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3958
3959         * source.c (search_command_helper): Stop reverse search
3960         when line 1 has been searched.
3961
3962 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3963
3964         * record-full.c (record_full_base_target::close): Rewrite
3965         record_full_core_buf_list free logic.
3966
3967 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3968
3969         * break-catch-syscall.c (print_one_catch_syscall): xfree
3970         the last text.
3971
3972 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3973
3974         * top.c (print_gdb_version): Update Copyright year in version
3975         message.
3976
3977 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3978
3979         Update copyright year range in all GDB files.
3980
3981 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
3982
3983         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
3984
3985 For older changes see ChangeLog-2018.
3986 \f
3987 Local Variables:
3988 mode: change-log
3989 left-margin: 8
3990 fill-column: 74
3991 version-control: never
3992 coding: utf-8
3993 End:
3994