gdb/ChangeLog

   1 2019-03-18  Pedro Alves  <palves@redhat.com>
   2             Eli Zaretskii <eliz@gnu.org>
   3
   4         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
   5         m_line and m_start_of_line.
   6
   7 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
   8
   9         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
  10         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
  11         it returns a newline.  This fixes a regression in TU mode, whereby
  12         the next line is output on the same screen line as the user input.
  13
  14 2019-03-18  Tom Tromey  <tromey@adacore.com>
  15
  16         * minsyms.c (minimal_symbol_reader::install): Remove call to
  17         obstack_blank.
  18
  19 2019-03-18  Pedro Alves  <palves@redhat.com>
  20
  21         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
  22         New globals.
  23         (apply_style): New, factored out from ...
  24         (apply_ansi_escape): ... this.  Handle reverse video mode.
  25         (tui_set_reverse_mode): New function.
  26         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
  27         * tui/tui-winsource.c (tui_show_source_line): Use
  28         tui_set_reverse_mode instead of setting A_STANDOUT.
  29         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
  30         New setter methods.
  31
  32 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
  33
  34         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
  35         Handle tabs.
  36
  37 2019-03-18  Tom Tromey  <tromey@adacore.com>
  38
  39         * ada-lang.c (empty_array): Add "high" parameter.
  40         (ada_evaluate_subexp): Update.
  41
  42 2019-03-17  Sergei Trofimovich <siarheit@google.com>
  43
  44         * unittests/string_view-selftests.c: Define
  45         _initialize_string_view_selftests unconditionally.
  46
  47 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
  48
  49         PR gdb/24350
  50         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
  51
  52 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
  53
  54         PR gdb/24351
  55         * windows-nat.c (display_selector): Fix format specifiers.
  56
  57 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
  58
  59         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
  60         tui_refill_source_window instead of tui_refresh_win, to update the
  61         current execution line.  This fixes redisplay of the current line
  62         when stepping through the code with "next" or "step".
  63
  64 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
  65
  66         * source-cache.c (source_cache::get_source_lines): Call
  67         find_source_lines to initialize s->nlines.  This fixes vertical
  68         scrolling of TUI source window when the DOWN arrow is pressed.
  69
  70 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  71
  72         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
  73         linux-thread-db.c (_initialize_thread_db): Likewise.
  74
  75 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
  76
  77         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
  78         wclrtoeol in tui_show_source_line".  This reverts changes made in
  79         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
  80
  81 2019-03-15  Tom Tromey  <tom@tromey.com>
  82
  83         * symtab.h (struct minimal_symbol): Derive from
  84         general_symbol_info.
  85         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
  86         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
  87         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
  88         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
  89         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
  90         (MSYMBOL_SEARCH_NAME): Update.
  91         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
  92         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
  93         * minsyms.c (minimal_symbol_reader::record_full): Update.
  94
  95 2019-03-15  Tom Tromey  <tom@tromey.com>
  96
  97         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
  98
  99 2019-03-15  Tom Tromey  <tom@tromey.com>
 100
 101         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
 102         unique_xmalloc_ptr.
 103         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
 104         Update.
 105         * minsyms.c (lookup_minimal_symbol_by_pc_section)
 106         (build_minimal_symbol_hash_tables)
 107         (minimal_symbol_reader::install): Update.
 108
 109 2019-03-15  Tom Tromey  <tom@tromey.com>
 110
 111         * symtab.c (create_demangled_names_hash): Update.
 112         (symbol_set_names): Update.
 113         * objfiles.h (struct objfile_per_bfd_storage)
 114         <demangled_names_hash>: Now an htab_up.
 115         * objfiles.c (objfile_per_bfd_storage): Simplify.
 116
 117 2019-03-15  Tom Tromey  <tom@tromey.com>
 118
 119         * objfiles.h (struct objfile_per_bfd_storage): Declare
 120         destructor.
 121         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
 122         New.
 123         (get_objfile_bfd_data): Use new.  Don't initialize
 124         language_of_main.
 125         (free_objfile_per_bfd_storage): Remove.
 126         (objfile_bfd_data_free, objfile::~objfile): Use delete.
 127
 128 2019-03-15  Tom Tromey  <tom@tromey.com>
 129
 130         * symfile.c (reread_symbols): Update.
 131         * objfiles.c (objfile::objfile): Update.
 132         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
 133         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
 134         comment.
 135         (minimal_symbol_reader::install): Update.
 136         (terminate_minimal_symbol_table): Remove.
 137         * jit.c (jit_object_close_impl): Update.
 138
 139 2019-03-15  Tom Tromey  <tom@tromey.com>
 140
 141         * minsyms.c (minimal_symbol_reader::record_full): Remove some
 142         initializations.
 143
 144 2019-03-15  Tom Tromey  <tom@tromey.com>
 145
 146         * objfiles.h (struct objfile_per_bfd_storage)
 147         <demangled_hash_languages>: Now a bitset.
 148         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 149         (lookup_minimal_symbol): Update.
 150
 151 2019-03-15  Tom Tromey  <tom@tromey.com>
 152
 153         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
 154         Don't return the symbol.
 155         * coffread.c (record_minimal_symbol): Use record_full.
 156
 157 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
 158
 159         The MS-Windows port of ncurses fails to switch to a color pair if
 160         one or both of the colors are the implicit default colors.  This
 161         change records the default colors when TUI is initialized, and
 162         then specifies them explicitly when a color pair uses the default
 163         colors.  This allows color styling in TUI mode on MS-Windows.
 164
 165         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
 166         ncurses_norm_attr.
 167         (tui_initialize_io) [__MINGW32__]: Record the default terminal
 168         colors in ncurses_norm_attr.
 169         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
 170         "none", replace it with the default color recorded in
 171         ncurses_norm_attr.
 172
 173 2019-03-14  Tom Tromey  <tromey@adacore.com>
 174
 175         * source-cache.h (class source_cache) <get_source_lines>: Return
 176         std::string.
 177         * source-cache.c (source_cache::extract_lines): Handle case where
 178         first_pos==npos.  Return std::string.
 179         (source_cache::get_source_lines): Update.
 180
 181 2019-03-14  Tom Tromey  <tromey@adacore.com>
 182
 183         * NEWS: Add item for "style sources" commands.
 184         * source-cache.c (source_cache::get_source_lines): Check
 185         source_styling.
 186         * cli/cli-style.c (source_styling): New global.
 187         (_initialize_cli_style): Add "style sources" commands.
 188         (show_style_sources): New function.
 189         * cli/cli-style.h (source_styling): Declare.
 190
 191 2019-03-14  Pedro Alves  <palves@redhat.com>
 192             Tom Tromey  <tromey@adacore.com>
 193
 194         * tui/tui-winsource.h (tui_refill_source_window): Declare.
 195         * tui/tui-winsource.c (tui_refill_source_window): New function,
 196         from...
 197         (tui_horizontal_source_scroll): ... here.  Move some logic.
 198         * cli/cli-style.c (set_style_enabled): Notify new observable.
 199         * tui/tui-hooks.c (tui_redisplay_source): New function.
 200         (tui_attach_detach_observers): Attach or detach
 201         tui_redisplay_source.
 202         * observable.h (source_styling_changed): New observable.
 203         * observable.c: Define source_styling_changed observable.
 204
 205 2019-03-13  Tom Tromey  <tromey@adacore.com>
 206
 207         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
 208         (i386_gnu_nat_target::store_registers): Update.
 209         * target-debug.h (target_debug_print_std_string): New macro.
 210         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
 211         * windows-tdep.c (display_one_tib): Update.
 212         * tui/tui-stack.c (tui_make_status_line): Update.
 213         * top.c (print_inferior_quit_action): Update.
 214         * thread.c (thr_try_catch_cmd): Update.
 215         (add_thread_with_info): Update.
 216         (thread_target_id_str): Update.
 217         (thr_try_catch_cmd): Update.
 218         (thread_command): Update.
 219         (thread_find_command): Update.
 220         * record-btrace.c (record_btrace_target::info_record)
 221         (record_btrace_resume_thread, record_btrace_target::resume)
 222         (record_btrace_cancel_resume, record_btrace_step_thread)
 223         (record_btrace_target::wait, record_btrace_target::wait)
 224         (record_btrace_target::wait, record_btrace_target::stop): Update.
 225         * progspace.c (print_program_space): Update.
 226         * process-stratum-target.c
 227         (process_stratum_target::thread_address_space): Update.
 228         * linux-fork.c (linux_fork_mourn_inferior)
 229         (detach_checkpoint_command, info_checkpoints_command)
 230         (linux_fork_context): Update.
 231         (linux_fork_detach): Update.
 232         (class scoped_switch_fork_info): Update.
 233         (delete_checkpoint_command): Update.
 234         * infrun.c (follow_fork_inferior): Update.
 235         (follow_fork_inferior): Update.
 236         (proceed_after_vfork_done): Update.
 237         (handle_vfork_child_exec_or_exit): Update.
 238         (follow_exec): Update.
 239         (displaced_step_prepare_throw): Update.
 240         (displaced_step_restore): Update.
 241         (start_step_over): Update.
 242         (resume_1): Update.
 243         (clear_proceed_status_thread): Update.
 244         (proceed): Update.
 245         (print_target_wait_results): Update.
 246         (do_target_wait): Update.
 247         (context_switch): Update.
 248         (stop_all_threads): Update.
 249         (restart_threads): Update.
 250         (finish_step_over): Update.
 251         (handle_signal_stop): Update.
 252         (switch_back_to_stepped_thread): Update.
 253         (keep_going_pass_signal): Update.
 254         (print_exited_reason): Update.
 255         (normal_stop): Update.
 256         * inferior.c (inferior_pid_to_str): Change return type.
 257         (print_selected_inferior): Update.
 258         (add_inferior): Update.
 259         (detach_inferior): Update.
 260         * dummy-frame.c (fprint_dummy_frames): Update.
 261         * dcache.c (dcache_info_1): Update.
 262         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
 263         (btrace_fetch, btrace_clear): Update.
 264         * linux-tdep.c (linux_core_pid_to_str): Change return type.
 265         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
 266         type.
 267         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
 268         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
 269         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
 270         * gdbarch.c, gdbarch.h: Rebuild.
 271         * gdbarch.sh (core_pid_to_str): Change return type.
 272         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
 273         return type.
 274         (windows_nat_target::pid_to_str): Change return type.
 275         (windows_delete_thread): Update.
 276         (windows_nat_target::attach): Update.
 277         (windows_nat_target::files_info): Update.
 278         * target-delegates.c: Rebuild.
 279         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
 280         return type.
 281         (sol_thread_target::pid_to_str): Change return type.
 282         * remote.c (class remote_target) <pid_to_str>: Change return
 283         type.
 284         (remote_target::pid_to_str): Change return type.
 285         (extended_remote_target::attach, remote_target::remote_stop_ns)
 286         (remote_target::remote_notif_remove_queued_reply)
 287         (remote_target::push_stop_reply, remote_target::disable_btrace):
 288         Update.
 289         (extended_remote_target::attach): Update.
 290         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
 291         type.
 292         (gdbsim_target::pid_to_str): Change return type.
 293         * ravenscar-thread.c (struct ravenscar_thread_target)
 294         <pid_to_str>: Change return type.
 295         (ravenscar_thread_target::pid_to_str): Change return type.
 296         * procfs.c (class procfs_target) <pid_to_str>: Change return
 297         type.
 298         (procfs_target::pid_to_str): Change return type.
 299         (procfs_target::attach): Update.
 300         (procfs_target::detach): Update.
 301         (procfs_target::fetch_registers): Update.
 302         (procfs_target::store_registers): Update.
 303         (procfs_target::wait): Update.
 304         (procfs_target::files_info): Update.
 305         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
 306         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
 307         return type.
 308         (nto_procfs_target::pid_to_str): Change return type.
 309         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
 310         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
 311         return type.
 312         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
 313         (exit_lwp): Update.
 314         (attach_proc_task_lwp_callback, get_detach_signal)
 315         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
 316         (linux_nat_target::resume, wait_lwp, stop_callback)
 317         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
 318         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
 319         (linux_nat_wait_1, resume_stopped_resumed_lwps)
 320         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
 321         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
 322         type.
 323         (inf_ptrace_target::attach): Update.
 324         (inf_ptrace_target::files_info): Update.
 325         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
 326         type.
 327         (go32_nat_target::pid_to_str): Change return type.
 328         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
 329         (gnu_nat_target::wait): Update.
 330         (gnu_nat_target::wait): Update.
 331         (gnu_nat_target::resume): Update.
 332         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
 333         (fbsd_nat_target::wait): Update.
 334         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
 335         type.
 336         (darwin_nat_target::attach): Update.
 337         * corelow.c (class core_target) <pid_to_str>: Change return type.
 338         (core_target::pid_to_str): Change return type.
 339         * target.c (normal_pid_to_str): Change return type.
 340         (default_pid_to_str): Likewise.
 341         (target_pid_to_str): Change return type.
 342         (target_translate_tls_address): Update.
 343         (target_announce_detach): Update.
 344         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
 345         return type.
 346         (bsd_uthread_target::pid_to_str): Change return type.
 347         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
 348         type.
 349         (bsd_kvm_target::pid_to_str): Change return type.
 350         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
 351         return type.
 352         (aix_thread_target::pid_to_str): Change return type.
 353         * target.h (struct target_ops) <pid_to_str>: Change return type.
 354         (target_pid_to_str, normal_pid_to_str): Likewise.
 355         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
 356         type.
 357         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
 358         type.
 359         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
 360         return type.
 361         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
 362         type.
 363         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
 364         type.
 365         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
 366         return type.
 367
 368 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
 369
 370         * NEWS: Mention that the new default MI version is 3.  Mention
 371         changes to the output of commands and events that deal with
 372         multi-location breakpoints.
 373         * breakpoint.c: Include "mi/mi-out.h".
 374         (print_one_breakpoint): Change output syntax if using MI version
 375         >= 3.
 376         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
 377         New.
 378         (mi_multi_location_breakpoint_output_fixed): New.
 379         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
 380         (mi_cmd_fix_multi_location_breakpoint_output): New.
 381         (mi_multi_location_breakpoint_output_fixed): New.
 382         * mi/mi-cmds.c (mi_cmds): Register command
 383         -fix-multi-location-breakpoint-output.
 384         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
 385         interpreter "mi".
 386
 387 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
 388
 389         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
 390         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
 391         instantiate mi_ui_out based on interpreter name.
 392         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
 393         * mi/mi-main.c (mi_load_progress): Likewise.
 394
 395 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 396
 397         * NEWS: Combine separate "New targets" sections for 8.3.
 398
 399 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 400
 401         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
 402         (ppcfbsd_init_abi): Install gdbarch
 403         "fetch_tls_load_module_address" and "get_thread_local_address"
 404         methods.
 405
 406 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 407
 408         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
 409         (riscv_fbsd_init_abi): Install gdbarch
 410         "fetch_tls_load_module_address" and "get_thread_local_address"
 411         methods.
 412
 413 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 414
 415         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
 416         (i386fbsd_init_abi): Install gdbarch
 417         "fetch_tls_load_module_address" and "get_thread_local_address"
 418         methods.
 419
 420 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 421
 422         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
 423         (amd64fbsd_init_abi): Install gdbarch
 424         "fetch_tls_load_module_address" and "get_thread_local_address"
 425         methods.
 426
 427 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 428
 429         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
 430         (struct fbsd_pspace_data): New type.
 431         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
 432         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
 433         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
 434         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
 435         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
 436
 437 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 438
 439         * gdbtypes.c (lookup_struct_elt): New function.
 440         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
 441         * gdbtypes.h (struct struct_elt): New type.
 442         (lookup_struct_elt): New prototype.
 443
 444 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 445
 446         * gdbtypes.c (lookup_struct_elt_type): Update comment and
 447         remove disabled code block.
 448
 449 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 450
 451         * gdbarch.sh (get_thread_local_address): New method.
 452         * gdbarch.h, gdbarch.c: Regenerate.
 453         * target.c (target_translate_tls_address): Use
 454         gdbarch_get_thread_local_address if present instead of
 455         target::get_thread_local_address.
 456
 457 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 458
 459         * target.h (target::get_thread_local_address): Update comment.
 460
 461 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 462
 463         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
 464         objfile->separate_debug_objfile_backlink if not NULL.
 465
 466 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 467
 468         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
 469         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
 470         (amd64bsd_store_inferior_registers): Likewise.
 471         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 472         Enable segment base registers.
 473         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
 474         PT_GETFSBASE and PT_GETGSBASE.
 475         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
 476         PT_SETGSBASE.
 477         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
 478         segment base registers.
 479         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 480
 481 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 482
 483         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 484         Update calls to i386_target_description to add 'segments'
 485         parameter.
 486         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
 487         add segment base registers.
 488         * arch/i386.c (i386_create_target_description): Add 'segments'
 489         parameter to enable segment base registers.
 490         * arch/i386.h (i386_create_target_description): Likewise.
 491         * features/i386/32bit-segments.xml: New file.
 492         * features/i386/32bit-segments.c: Generate.
 493         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
 494         call to i386_target_description to add 'segments' parameter.
 495         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 496         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
 497         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
 498         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
 499         if feature is present.
 500         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
 501         Add 'segments' parameter to call to i386_target_description.
 502         (i386_target_description): Add 'segments' parameter to enable
 503         segment base registers.
 504         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
 505         to call to i386_target_description.
 506         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
 507         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
 508         Define I386_NUM_REGS.
 509         (i386_target_description): Add 'segments' parameter to enable
 510         segment base registers.
 511
 512 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 513
 514         PR/24325
 515         * source-cache.c: #undef open and close, to avoid unresolved
 516         externals during linking.
 517
 518 2019-03-12  Tom Tromey  <tromey@adacore.com>
 519
 520         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
 521         const.  Add initializers.
 522         (_initialize_remote): Don't initialize ptid globals.
 523
 524 2019-03-12  Pedro Alves  <palves@redhat.com>
 525
 526         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
 527
 528 2019-03-12  Pedro Alves  <palves@redhat.com>
 529
 530         * cp-name-parser.y (main): Remove unused 'len' variable.
 531
 532 2019-03-12  Tom Tromey  <tromey@adacore.com>
 533
 534         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
 535         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
 536
 537 2019-03-12  Tom Tromey  <tromey@adacore.com>
 538
 539         * linux-nat.c (iterate_over_lwps): Update.
 540         (stop_callback): Remove parameter.
 541         (stop_wait_callback, detach_callback, resume_set_callback)
 542         (select_singlestep_lwp_callback, set_ignore_sigint)
 543         (status_callback, resumed_callback, resume_clear_callback)
 544         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
 545         data parameter.
 546         (linux_nat_target::detach, linux_nat_target::resume)
 547         (linux_stop_and_wait_all_lwps, select_event_lwp)
 548         (linux_nat_filter_event, linux_nat_wait_1)
 549         (linux_nat_target::kill, linux_nat_target::stop)
 550         (linux_nat_target::stop): Update.
 551         (linux_nat_resume_callback): Change type.
 552         (resume_stopped_resumed_lwps, count_events_callback)
 553         (select_event_lwp_callback): Likewise.
 554         (linux_stop_lwp, linux_nat_stop_lwp): Update.
 555         * arm-linux-nat.c (struct update_registers_data): Remove.
 556         (update_registers_callback): Change type.
 557         (arm_linux_insert_hw_breakpoint1): Update.
 558         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
 559         parameter.
 560         (x86_linux_dr_set_addr): Update.
 561         (x86_linux_dr_set_control): Update.
 562         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
 563         (iterate_over_lwps): Use gdb::function_view.
 564         * nat/aarch64-linux-hw-point.c (struct
 565         aarch64_dr_update_callback_param): Remove.
 566         (debug_reg_change_callback): Change type.
 567         (aarch64_notify_debug_reg_change): Update.
 568         * s390-linux-nat.c (s390_refresh_per_info): Update.
 569
 570 2019-03-11  Tom Tromey  <tromey@adacore.com>
 571
 572         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
 573         redundant assignment to "this_cu".
 574
 575 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 576
 577         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
 578
 579 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 580
 581         * gdbtypes.c (rank_one_type_parm_set): New function extracted
 582         from...
 583         (rank_one_type): ... this.
 584
 585 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 586
 587         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
 588         from...
 589         (rank_one_type): ... this.
 590
 591 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 592
 593         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
 594         from...
 595         (rank_one_type): ... this.
 596
 597 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 598
 599         * gdbtypes.c (rank_one_type_parm_float): New function extracted
 600         from...
 601         (rank_one_type): ... this.
 602
 603 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 604
 605         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
 606         from...
 607         (rank_one_type): ... this.
 608
 609 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 610
 611         * gdbtypes.c (rank_one_type_parm_range): New function extracted
 612         from...
 613         (rank_one_type): ... this.
 614
 615 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 616
 617         * gdbtypes.c (rank_one_type_parm_char): New function extracted
 618         from...
 619         (rank_one_type): ... this.
 620
 621 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 622
 623         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
 624         from...
 625         (rank_one_type): ... this.
 626
 627 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 628
 629         * gdbtypes.c (rank_one_type_parm_int): New function extracted
 630         from...
 631         (rank_one_type): ... this.
 632
 633 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 634
 635         * gdbtypes.c (rank_one_type_parm_func): New function extracted
 636         from...
 637         (rank_one_type): ... this.
 638
 639 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 640
 641         * gdbtypes.c (rank_one_type_parm_array): New function extracted
 642         from...
 643         (rank_one_type): ... this.
 644
 645 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 646
 647         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
 648         from...
 649         (rank_one_type): ... this.
 650
 651 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 652
 653         * inferior.c (initialize_inferiors): Ensure 'help set/show print
 654         inferior-events' shows the example events.
 655
 656 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
 657
 658         Support styling on native MS-Windows console
 659
 660         PR/24315
 661         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
 662         on MS-Windows if $TERM is not defined.
 663
 664         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
 665
 666         * posix-hdep.c (gdb_console_fputs):
 667         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
 668         functions.
 669         * ui-file.h (gdb_console_fputs): Add prototype.
 670
 671         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
 672         back to fputs only if the former returns zero.
 673
 674 2019-03-07  Tom Tromey  <tom@tromey.com>
 675
 676         * symmisc.c (print_symbol_bcache_statistics): Update.
 677         (print_objfile_statistics): Update.
 678         * symfile.c (allocate_symtab): Update.
 679         * stabsread.c: Don't include bcache.h.
 680         * psymtab.h (struct psymbol_bcache): Don't declare.
 681         (class psymtab_storage) <psymbol_cache>: Now a bcache.
 682         (psymbol_bcache_init, psymbol_bcache_free)
 683         (psymbol_bcache_get_bcache): Don't declare.
 684         * psymtab.c (struct psymbol_bcache): Remove.
 685         (psymtab_storage::psymtab_storage): Update.
 686         (psymtab_storage::~psymtab_storage): Update.
 687         (psymbol_bcache_init, psymbol_bcache_free)
 688         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
 689         (add_psymbol_to_bcache): Update.
 690         (allocate_psymtab): Update.
 691         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
 692         macro_cache>: No longer pointers.
 693         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
 694         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
 695         * macrotab.c (macro_bcache): Update.
 696         * macroexp.c: Don't include bcache.h.
 697         * gdbtypes.c (check_types_worklist): Update.
 698         (types_deeply_equal): Remove TRY/CATCH.  Update.
 699         * elfread.c (elf_symtab_read): Update.
 700         * dwarf2read.c: Don't include bcache.h.
 701         * buildsym.c (buildsym_compunit::get_macro_table): Update.
 702         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
 703         (print_bcache_statistics, bcache_memory_used): Don't declare.
 704         (struct bcache): Move from bcache.c.  Add constructor, destructor,
 705         methods.  Rename all data members.
 706         * bcache.c (struct bcache): Move to bcache.h.
 707         (bcache::expand_hash_table): Rename from expand_hash_table.
 708         (bcache): Remove.
 709         (bcache::insert): Rename from bcache_full.
 710         (bcache::compare): Rename from bcache_compare.
 711         (bcache_xmalloc): Remove.
 712         (bcache::~bcache): Rename from bcache_xfree.
 713         (bcache::print_statistics): Rename from print_bcache_statistics.
 714         (bcache::memory_used): Rename from bcache_memory_used.
 715
 716 2019-03-07  Pedro Alves  <palves@redhat.com>
 717
 718         * infrun.c (normal_stop): Also check for
 719         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
 720
 721 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 722
 723         * f-lang.c (value_from_host_double): Moved to...
 724         * value.c (value_from_host_double): ...here.
 725         * value.h (value_from_host_double): Declare.
 726         * guile/scm-math.c (vlscm_convert_typed_number): Use
 727         value_from_host_double.
 728         (vlscm_convert_number): Likewise.
 729         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
 730         * python/py-value.c (convert_value_from_python): Likewise.
 731
 732 2019-03-06  Tom Tromey  <tom@tromey.com>
 733
 734         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
 735
 736 2019-03-06  Tom Tromey  <tom@tromey.com>
 737
 738         * utils.h (free_current_contents): Don't declare.
 739         * utils.c (free_current_contents): Remove.
 740
 741 2019-03-06  Tom Tromey  <tom@tromey.com>
 742
 743         * top.c (quit_force): Update.
 744         * main.c (captured_command_loop): Update.
 745         * common/new-op.c (operator new): Update.
 746         * common/common-exceptions.c (struct catcher)
 747         <save_cleanup_chain>: Remove member.
 748         (exceptions_state_mc_init): Update.
 749         (exception_try_scope_entry): Return nullptr.
 750         (exception_try_scope_exit, exception_rethrow)
 751         (throw_exception_sjlj, throw_exception_cxx): Update.
 752         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
 753         (all_cleanups, do_cleanups, discard_cleanups)
 754         (discard_final_cleanups, save_cleanups, save_final_cleanups)
 755         (restore_cleanups, restore_final_cleanups): Don't declare.
 756         (do_final_cleanups): Remove parameter.
 757         * common/cleanups.c (cleanup_chain, make_cleanup)
 758         (make_cleanup_dtor, all_cleanups, do_cleanups)
 759         (discard_my_cleanups, discard_cleanups)
 760         (discard_final_cleanups, save_my_cleanups, save_cleanups)
 761         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
 762         (null_cleanup): Remove.
 763         (do_final_cleanups): Remove parameter.
 764
 765 2019-03-06  Tom Tromey  <tom@tromey.com>
 766
 767         * remote.c (remote_target::remote_parse_stop_reply): Use
 768         unique_xmalloc_ptr.
 769
 770 2019-03-06  Tom Tromey  <tom@tromey.com>
 771
 772         * stabsread.c (struct stabs_field_info): Rename from field_info.
 773         <list, fnlist>: Add initializers.
 774         <obstack>: New member.
 775         (read_member_functions, read_struct_fields, read_baseclasses):
 776         Allocate on obstack.  Don't use cleanups.
 777         (read_one_struct_field, read_member_functions, read_struct_fields)
 778         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
 779         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
 780         (read_struct_type): Update.
 781
 782 2019-03-06  Tom Tromey  <tom@tromey.com>
 783
 784         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
 785         * common/filestuff.h (make_cleanup_close): Don't declare.
 786         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
 787         Remove.
 788
 789 2019-03-06  Tom Tromey  <tom@tromey.com>
 790
 791         * solib-aix.c: Use make_scope_exit.
 792
 793 2019-03-06  Tom Tromey  <tom@tromey.com>
 794
 795         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
 796         Use make_scope_exit.
 797
 798 2019-03-06  Tom Tromey  <tom@tromey.com>
 799
 800         * solib-svr4.c (disable_probes_interface): Remove parameter.
 801         (svr4_handle_solib_event): Use make_scope_exit.
 802
 803 2019-03-06  Tom Tromey  <tom@tromey.com>
 804
 805         * remote.c (struct stop_reply_deleter): Remove.
 806         (stop_reply_up): Update.
 807         (struct stop_reply): Derive from notif_event.  Don't typedef.
 808         <regcache>: Now a std::vector.
 809         (stop_reply_xfree): Remove.
 810         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
 811         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
 812         (remote_target::discard_pending_stop_replies): Use delete.
 813         (remote_target::remote_parse_stop_reply): Update.
 814         (remote_target::process_stop_reply): Update.
 815         * remote-notif.h (struct notif_event): Add virtual destructor.
 816         Remove "dtr" member.
 817         (struct notif_client) <alloc_event>: Return a unique_ptr.
 818         (notif_event_xfree): Don't declare.
 819         (notif_event_up): New typedef.
 820         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
 821         (notif_event_xfree, do_notif_event_xfree): Remove.
 822         (remote_notif_state_xfree): Update.
 823
 824 2019-03-06  Tom Tromey  <tom@tromey.com>
 825
 826         * infrun.c (displaced_step_clear_cleanup): Now a
 827         forward_scope_exit type.
 828         (displaced_step_prepare_throw): Update.
 829         (displaced_step_fixup): Update.
 830
 831 2019-03-06  Tom Tromey  <tom@tromey.com>
 832
 833         * inferior.h (class inferior): Update comment.
 834         * gdbthread.h (class thread_info): Update comment.
 835
 836 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
 837             Tom Tromey  <tom@tromey.com>
 838
 839         * stabsread.h (struct stab_section_list): Remove.
 840         (coffstab_build_psymtabs): Update.
 841         * dbxread.c (symbuf_sections): Now a std::vector.
 842         (sect_idx): New global.
 843         (fill_symbuf): Update.
 844         (coffstab_build_psymtabs): Change type of stabsects parameter.
 845         Update.
 846         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
 847         std::vector.
 848         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
 849         (coff_locate_sections): Update.
 850         (coff_symfile_read): Remove cleanups.  Update.
 851         (init_stringtab): Add storage parameter.
 852         (free_stringtab, free_stringtab_cleanup): Remove.
 853         (init_lineno): Add storage parameter.
 854         (free_linetab, free_linetab_cleanup): Remove.
 855
 856 2019-03-06  Pedro Alves  <palves@redhat.com>
 857
 858         * linux-fork.c (fork_info::clobber_regs): Delete.
 859         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
 860         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
 861         comment.  Adjust.
 862         (scoped_switch_fork_info::scoped_switch_fork_info)
 863         (checkpoint_command, linux_fork_context): Adjust
 864         fork_save_infrun_state calls.
 865
 866 2019-03-06  Pedro Alves  <palves@redhat.com>
 867
 868         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
 869         (inf_has_multiple_threads): Return 'bool' and rewrite using
 870         inferior_info::threads().
 871
 872 2019-03-06  Pedro Alves  <palves@redhat.com>
 873
 874         * linux-fork.c: Include <list>.
 875         (fork_list): Now a std::list instance.
 876         (fork_info): Add ctor, dtor, and in-class initialize all fields.
 877         (forks_exist_p, find_last_fork): Adjust.
 878         (new_fork): Delete.
 879         (one_fork_p): New.
 880         (add_fork): Adjust.
 881         (free_fork): Delete, folded into fork_info::~fork_info().
 882         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
 883         Adjust.
 884         (init_fork_list): Delete.
 885         (linux_fork_killall, linux_fork_mourn_inferior)
 886         (linux_fork_detach, info_checkpoints_command): Adjust.
 887         (_initialize_linux_fork): No longer call init_fork_list.
 888
 889 2019-03-06  Pedro Alves  <palves@redhat.com>
 890
 891         * linux-fork.c (new_fork): New, split out of ...
 892         (add_fork): ... this.  Return void.  Move "first fork" special
 893         case from here, to ...
 894         (checkpoint_command): ... here.
 895         * linux-linux.h (add_fork): Return void.
 896
 897 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 898
 899         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
 900
 901 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 902             Chris January  <chris.january@arm.com>
 903             David Lecomber  <david.lecomber@arm.com>
 904
 905         * f-exp.y: New token, UNOP_INTRINSIC.
 906         (exp): New pattern using UNOP_INTRINSIC token.
 907         (f77_keywords): Add 'abs' keyword.
 908         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
 909         (value_from_host_double): New function.
 910         (evaluate_subexp_f): Support UNOP_ABS.
 911
 912 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 913
 914         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
 915         types.
 916
 917 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 918
 919         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
 920         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
 921         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
 922
 923 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 924
 925         * f-exp.y (convert_to_kind_type): Handle more type kinds.
 926
 927 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 928             Chris January  <chris.january@arm.com>
 929
 930         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
 931         * f-exp.y: Define 'KIND' token.
 932         (exp): New pattern for KIND expressions.
 933         (ptype): Handle types with a kind extension.
 934         (direct_abs_decl): Extend to spot kind extensions.
 935         (f77_keywords): Add 'kind' to the list.
 936         (push_kind_type): New function.
 937         (convert_to_kind_type): New function.
 938         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
 939         * parse.c (operator_length_standard): Likewise.
 940         * parser-defs.h (enum type_pieces): Add tp_kind.
 941         * std-operator.def: Add UNOP_KIND.
 942
 943 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 944
 945         * f-exp.y (f_parse): Set yydebug.
 946
 947 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 948
 949         * f-lang.c (evaluate_subexp_f): New function.
 950         (exp_descriptor_f): New global.
 951         (f_language_defn): Use exp_descriptor_f instead of
 952         exp_descriptor_standard.
 953
 954 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 955
 956         * f-exp.y (struct token): Add comments.
 957         (dot_ops): Remove uppercase versions and the end marker.
 958         (f77_keywords): Likewise.
 959         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
 960         entries in the dot_ops array are case insensitive, and use
 961         strncasecmp to compare strings.  Also some whitespace cleanup in
 962         this area.  Similar for the f77_keywords array, except entries in
 963         this list might be case sensitive.
 964
 965 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 966
 967         * f-exp.y (struct f77_boolean_val): Add comments.
 968         (boolean_values): Remove uppercase versions, and end marker.
 969         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
 970         and use strncasecmp to achieve case insensitivity.  Additionally,
 971         perform whitespace cleanup around this code.
 972
 973 2019-03-06  Tom Tromey  <tromey@adacore.com>
 974
 975         * remote-sim.c (gdbsim_target_open): Use result of
 976         gdb_argv::release.
 977
 978 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
 979         Dirk Schubert  <dirk.schubert@arm.com>
 980         Chris January  <chris.january@arm.com>
 981
 982         * eval.c (evaluate_subexp_standard): Call Fortran argument
 983         wrapping logic.
 984         * f-lang.c (struct value): A value which can be passed into a
 985         Fortran function call.
 986         (fortran_argument_convert): Wrap Fortran arguments in a pointer
 987         where appropriate.
 988         (struct type): Value ready for a Fortran function call.
 989         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
 990         is needed.
 991         * f-lang.h (fortran_argument_convert): Declaration.
 992         (fortran_preserve_arg_pointer): Declaration.
 993         * infcall.c (value_arg_coerce): Call Fortran argument logic.
 994
 995 2019-03-05  Tom Tromey  <tromey@adacore.com>
 996
 997         * python/py-prettyprint.c (print_string_repr): Remove #if.
 998         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
 999
1000 2019-03-05  Tom Tromey  <tromey@adacore.com>
1001
1002         * target.c (the_dummy_target): Move later.  Change type to
1003         "dummy_target".
1004         (initialize_targets): Don't initialize the_dummy_target.
1005
1006 2019-03-05  Tom Tromey  <tromey@adacore.com>
1007
1008         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
1009         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
1010
1011 2019-03-05  Tom Tromey  <tromey@adacore.com>
1012
1013         * windows-nat.c (windows_nat_target::attach)
1014         (windows_nat_target::detach): Don't call gdb_flush.
1015         * valprint.c (generic_val_print, val_print, val_print_string):
1016         Don't call gdb_flush.
1017         * utils.c (defaulted_query): Don't call gdb_flush.
1018         * typeprint.c (print_type_scalar): Don't call gdb_flush.
1019         * target.c (target_announce_detach): Don't call gdb_flush.
1020         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
1021         * remote.c (extended_remote_target::attach): Don't call
1022         gdb_flush.
1023         * procfs.c (procfs_target::detach): Don't call gdb_flush.
1024         * printcmd.c (do_examine): Don't call gdb_flush.
1025         (info_display_command): Don't call gdb_flush.
1026         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
1027         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
1028         * memattr.c (info_mem_command): Don't call gdb_flush.
1029         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
1030         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
1031         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
1032         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
1033         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
1034         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
1035         (gnu_nat_target::detach): Don't call gdb_flush.
1036         * f-valprint.c (f_val_print): Don't call gdb_flush.
1037         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
1038         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
1039         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
1040         gdb_flush.
1041         * c-valprint.c (c_val_print): Don't call gdb_flush.
1042         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
1043
1044 2019-03-05  Tom Tromey  <tromey@adacore.com>
1045
1046         * varobj.c (update_dynamic_varobj_children): Update.
1047         (install_default_visualizer): Use reset, not release.
1048         * value.c (set_internalvar): Update.
1049         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
1050         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
1051         ATTRIBUTE_UNUSED_RESULT.
1052
1053 2019-03-05  Tom Tromey  <tromey@adacore.com>
1054
1055         * remote.c (class scoped_remote_fd) <release>: Add
1056         ATTRIBUTE_UNUSED_RESULT.
1057
1058 2019-03-05  Tom Tromey  <tromey@adacore.com>
1059
1060         * macroexp.c (struct macro_buffer) <release>: Add
1061         ATTRIBUTE_UNUSED_RESULT.
1062
1063 2019-03-05  Tom Tromey  <tromey@adacore.com>
1064
1065         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
1066         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
1067         ATTRIBUTE_UNUSED_RESULT.
1068
1069 2019-03-05  Tom Tromey  <tromey@adacore.com>
1070
1071         * common/scoped_fd.h (class scoped_fd) <release>: Add
1072         ATTRIBUTE_UNUSED_RESULT.
1073
1074 2019-03-05  Tom Tromey  <tromey@adacore.com>
1075
1076         * parser-defs.h (struct parser_state) <release>: Add
1077         ATTRIBUTE_UNUSED_RESULT.
1078
1079 2019-03-05  Tom Tromey  <tromey@adacore.com>
1080
1081         * utils.h (class gdb_argv) <release>: Add
1082         ATTRIBUTE_UNUSED_RESULT.
1083         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
1084
1085 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
1086
1087         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
1088         for-loop range, to avoid compiler warnings.
1089
1090         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
1091         avoid compiler warnings about unused variables.
1092
1093         * NEWS: Mention end of support for native debugging on MS-Windows
1094         before XP.
1095
1096         PR gdb/24292
1097         * common/netstuff.c:
1098         * gdbserver/gdbreplay.c
1099         * gdbserver/remote-utils.c:
1100         * ser-tcp.c:
1101         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
1102         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
1103         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
1104         'getaddrinfo' and 'freeaddrinfo' were not available before
1105         Windows XP, and mingw.org's MinGW headers by default define
1106         _WIN32_WINNT to 0x500.
1107
1108 2019-03-01  Gary Benson <gbenson@redhat.com>
1109
1110         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
1111
1112 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
1113             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1114
1115         PR gdb/8527
1116         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
1117         set_sigint_trap, clear_sigint_trap.
1118
1119 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1120
1121         * target.c (target_detach): Clear the regcache and the
1122         frame cache.
1123
1124 2019-02-27  Pedro Alves  <palves@redhat.com>
1125
1126         * utils.c (set_screen_size): When we cap the height/width sizes,
1127         tweak the corresponding command variable to show "unlimited":
1128
1129 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
1130             Pedro Alves  <palves@redhat.com>
1131
1132         * utils.c (set_screen_size): Reduce "infinite" rows and columns
1133         before calling rl_set_screen_size.
1134
1135 2019-02-27  Tom Tromey  <tromey@adacore.com>
1136
1137         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
1138         define.
1139         * python/py-value.c: Remove Python 2.4 workaround.
1140         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
1141         workaround.
1142         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
1143         Python 2.4 workaround.
1144         * python/python-internal.h: Remove Python 2.4 comment.
1145         (Py_ssize_t): Don't define.
1146         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
1147         (gdb_Py_DECREF): Remove Python 2.4 workaround.
1148         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
1149         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
1150         * python/python.c (do_start_initialization): Remove Python 2.4
1151         workaround.
1152         * python/py-prettyprint.c (class dummy_python_frame): Remove.
1153         (print_children): Remove Python 2.4 workaround.
1154         * python/py-inferior.c (buffer_procs): Remove Python 2.4
1155         workaround.
1156         (CHARBUFFERPROC_NAME): Remove.
1157         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
1158         Python 2.4 workaround.
1159
1160 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1161
1162         * NEWS: Note minimum Python version.
1163
1164 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1165
1166         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
1167         code from these functions.  Remove corresponding ifdefs.  Use
1168         Py_buffer_up instead of explicit calls to PyBuffer_Release.
1169         Remove gotos and target of gotos.
1170         (infpy_search_memory): Likewise.
1171
1172 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1173
1174         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
1175         (hppa_gdbarch_init): Don't register deleted functions with
1176         gdbarch.
1177
1178 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1179
1180         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
1181         (h8300_unwind_sp): Delete.
1182         (h8300_dummy_id): Delete.
1183         (h8300_gdbarch_init): Don't register deleted functions with
1184         gdbarch.
1185
1186 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1187
1188         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
1189         (ft32_unwind_pc): Delete.
1190         (ft32_unwind_sp): Delete.
1191         (ft32_gdbarch_init): Don't register deleted functions with
1192         gdbarch.
1193
1194 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1195
1196         * gdb/frv-tdep.c (frv_dummy_id): Delete.
1197         (frv_unwind_pc): Delete.
1198         (frv_unwind_sp): Delete.
1199         (frv_gdbarch_init): Don't register deleted functions with
1200         gdbarch.
1201
1202 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1203
1204         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1205         (riscv_unwind_pc): Delete.
1206         (riscv_unwind_sp): Delete.
1207         (riscv_gdbarch_init): Don't register deleted functions with
1208         gdbarch.
1209
1210 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1211
1212         * gdb/csky-tdep.c (csky_dummy_id): Delete.
1213         (csky_unwind_pc): Delete.
1214         (csky_unwind_sp): Delete.
1215         (csky_gdbarch_init): Don't register deleted functions with
1216         gdbarch.
1217
1218 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1219
1220         * gdb/cris-tdep.c (cris_dummy_id): Delete.
1221         (cris_unwind_pc): Delete.
1222         (cris_unwind_sp): Delete.
1223         (cris_gdbarch_init): Don't register deleted functions with
1224         gdbarch.
1225
1226 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1227
1228         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1229         (bfin_unwind_pc): Delete.
1230         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1231
1232 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1233
1234         * gdb/arm-tdep.c (arm_dummy_id): Delete.
1235         (arm_unwind_pc): Delete.
1236         (arm_unwind_sp): Delete.
1237         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1238
1239 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1240
1241         * gdb/arc-tdep.c (arc_dummy_id): Delete.
1242         (arc_unwind_pc): Delete.
1243         (arc_unwind_sp): Delete.
1244         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1245
1246 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1247
1248         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1249         (alpha_unwind_pc): Delete.
1250         (alpha_gdbarch_init): Don't register deleted functions with
1251         gdbarch.
1252
1253 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1254
1255         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1256         (aarch64_unwind_pc): Delete.
1257         (aarch64_unwind_sp): Delete.
1258         (aarch64_gdbarch_init): Don't register deleted functions with
1259         gdbarch.
1260
1261 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1262
1263         * gdbtypes.c (type_align): Don't consider static members when
1264         computing structure alignment.
1265
1266 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1267
1268         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1269         return 0 for other types.
1270         * arch-utils.c (default_type_align): Always return 0.
1271         * gdbarch.h: Regenerate.
1272         * gdbarch.sh (type_align): Extend comment.
1273         * gdbtypes.c (type_align): Add additional comments, always call
1274         gdbarch_type_align before applying the default rules.
1275         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
1276         generic code will then apply a suitable default.
1277         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
1278         types, return 0 for other types.
1279
1280 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1281
1282         * NEWS: Create a new section for the next release branch.
1283         Rename the section of the current branch, now that it has
1284         been cut.
1285
1286 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1287
1288         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
1289         * version.in: Bump version to 8.3.50.DATE-git.
1290
1291 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
1292
1293         * aix-thread.c (ptid_cmp): Remove unused variable.
1294         (get_signaled_thread): Likewise.
1295         (store_regs_user_thread): Likewise.
1296         (store_regs_kernel_thread): Likewise.
1297         (fetch_regs_kernel_thread): Remove shadowed variable.
1298
1299 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1300
1301         * features/riscv/32bit-cpu.xml: Add register numbers.
1302         * features/riscv/32bit-fpu.c: Regenerate.
1303         * features/riscv/32bit-fpu.xml: Add register numbers.
1304         * features/riscv/64bit-cpu.xml: Add register numbers.
1305         * features/riscv/64bit-fpu.c: Regenerate.
1306         * features/riscv/64bit-fpu.xml: Add register numbers.
1307
1308 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
1309
1310         * NEWS: Mention two argument form of gdb.Value constructor.
1311         * python/py-value.c (convert_buffer_and_type_to_value): New
1312         function.
1313         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
1314         Add support for handling an optional second argument.  Call
1315         convert_buffer_and_type_to_value as appropriate.
1316         * python/python-internal.h (Py_buffer_deleter): New struct.
1317         (Py_buffer_up): New typedef.
1318
1319 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
1320
1321         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
1322         instead of releasing ownership.
1323
1324 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
1325
1326         * dwarf2read.c (open_and_init_dwp_file): Call
1327         elf_numsections instead of bfd_count_sections to initialize
1328         dwp_file->num_sections.
1329
1330 2019-02-25  Tom Tromey  <tromey@adacore.com>
1331
1332         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
1333
1334 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1335
1336         * gcore.in: Add '--readnever' option when invoking GDB.
1337
1338 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1339
1340         * MAINTAINERS: Update my email address.
1341
1342 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1343
1344         * build-id.c (build_id_to_debug_bfd_1): New function.
1345         (build_id_to_debug_bfd): Look for separate debug file in
1346         sysroot.
1347
1348 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1349
1350         * gdbarch.sh: Update the copyright year range that is placed into
1351         generated files.
1352
1353 2019-02-22  Keith Seitz  <keiths@redhat.com>
1354
1355         PR symtab/23853
1356         * linespec.c (create_sals_line_offset): Search for the default
1357         symtab's filename instead of its fullname.
1358
1359 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1360
1361         * NEWS: Update style defaults.
1362
1363 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1364
1365         * main.c (captured_main_1): Disable styling in batch mode.
1366
1367 2019-02-20  Tom Tromey  <tom@tromey.com>
1368
1369         * symtab.c (symtab_symbol_info): Fix typos.
1370
1371 2019-02-20  Tom Tromey  <tromey@adacore.com>
1372
1373         * findcmd.c (_initialize_mem_search): Use upper case for
1374         metasyntactic variables.
1375
1376 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
1377
1378         * aarch64-tdep.c (aarch64_add_reggroups): New function.
1379         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
1380
1381 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
1382
1383         * top.h (source_file_name): Change to std::string.
1384         * top.c (source_file_name): Likewise.
1385         (command_line_input): Adjust.
1386         * cli/cli-script.c (script_from_file): Adjust.
1387
1388 2019-02-19  Tom Tromey  <tromey@adacore.com>
1389
1390         * ravenscar-thread.c
1391         (ravenscar_thread_target::update_thread_list): Don't call
1392         ada_build_task_list.
1393         * ada-lang.h (ada_build_task_list): Don't declare.
1394         * ada-tasks.c (struct ada_tasks_inferior_data)
1395         <task_list_valid_p>: Now bool.
1396         (read_known_tasks, ada_task_list_changed)
1397         (ada_tasks_invalidate_inferior_data): Update.
1398         (read_known_tasks_array): Return bool.
1399         (read_known_tasks_list): Likewise.
1400         (read_known_tasks): Return void.
1401         (ada_build_task_list): Now static.
1402
1403 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1404
1405         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
1406         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
1407
1408 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1409
1410         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
1411         variant for ada_tasks_pspace_data_handle and
1412         ada_tasks_inferior_data_handle.
1413         (ada_tasks_pspace_data_cleanup): New function.
1414         (ada_tasks_inferior_data_cleanup): New function.
1415
1416 2019-02-17  Tom Tromey  <tom@tromey.com>
1417
1418         * macrotab.h (macro_source_fullname): Return a std::string.
1419         * macrotab.c (macro_include, check_for_redefinition)
1420         (macro_undef, macro_lookup_definition, foreach_macro)
1421         (foreach_macro_in_scope): Update.
1422         (macro_source_fullname): Return a std::string.
1423         * macrocmd.c (show_pp_source_pos): Update.
1424
1425 2019-02-17  Tom Tromey  <tom@tromey.com>
1426
1427         * macrocmd.c (show_pp_source_pos): Style the file names.
1428
1429 2019-02-17  Tom Tromey  <tom@tromey.com>
1430
1431         PR tui/24197:
1432         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
1433
1434 2019-02-17  Tom Tromey  <tom@tromey.com>
1435
1436         * ada-lang.c (user_select_syms): Use filtered printing.
1437         * utils.c (wrap_style): New global.
1438         (desired_style): Remove.
1439         (emit_style_escape): Add stream parameter.
1440         (set_output_style, reset_terminal_style, prompt_for_continue):
1441         Update.
1442         (flush_wrap_buffer): Only flush gdb_stdout.
1443         (wrap_here): Set wrap_style.
1444         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
1445         treat escape sequences as a character.  Change when wrap buffer is
1446         flushed.
1447         (fputs_styled): Do not set the output style when the default is
1448         requested.
1449         * ui-style.h (struct ui_file_style) <is_default>: New method.
1450         * source.c (print_source_lines_base): Emit escape sequences in one
1451         piece.
1452
1453 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1454
1455         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1456         integers and enumeration types.
1457
1458 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1459
1460         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1461         instead of lookup_symbol_in_language
1462         (do_exact_match): New function.
1463         (ada_get_symbol_name_matcher): Return do_exact_match when
1464         doing a verbatim match.
1465
1466 2019-02-15  Tom Tromey  <tromey@adacore.com>
1467
1468         * ravenscar-thread.c (ravenscar_thread_target::resume)
1469         (ravenscar_thread_target::wait): Special case wildcard requests.
1470
1471 2019-02-15  Tom Tromey  <tromey@adacore.com>
1472
1473         * ravenscar-thread.c (base_ptid): Remove.
1474         (struct ravenscar_thread_target) <close>: New method.
1475         <m_base_ptid>: New member.
1476         <update_inferior_ptid, active_task, task_is_currently_active,
1477         runtime_initialized>: Declare methods.
1478         <ravenscar_thread_target>: Add constructor.
1479         (ravenscar_thread_target::task_is_currently_active)
1480         (ravenscar_thread_target::update_inferior_ptid)
1481         (ravenscar_runtime_initialized): Rename.  Now methods.
1482         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1483         (ravenscar_thread_target::update_thread_list): Update.
1484         (ravenscar_thread_target::active_task): Now method.
1485         (ravenscar_thread_target::store_registers)
1486         (ravenscar_thread_target::prepare_to_store)
1487         (ravenscar_thread_target::prepare_to_store)
1488         (ravenscar_thread_target::mourn_inferior): Update.
1489         (ravenscar_inferior_created): Use "new" to create target.
1490         (ravenscar_thread_target::get_ada_task_ptid): Update.
1491         (_initialize_ravenscar): Don't initialize base_ptid.
1492         (ravenscar_ops): Remove global.
1493
1494 2019-02-15  Tom Tromey  <tromey@adacore.com>
1495
1496         * target.h (push_target): Declare new overload.
1497         * target.c (push_target): New overload, taking an rvalue reference.
1498         * remote.c (remote_target::open_1): Use push_target overload.
1499         * corelow.c (core_target_open): Use push_target overload.
1500
1501 2019-02-15  Tom Tromey  <tromey@adacore.com>
1502
1503         * ravenscar-thread.c (is_ravenscar_task)
1504         (ravenscar_task_is_currently_active): Return bool.
1505         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
1506         (_initialize_ravenscar): Remove "(void)".
1507         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
1508         Return bool.
1509
1510 2019-02-15  Tom Tromey  <tromey@adacore.com>
1511
1512         * ravenscar-thread.c (ravenscar_runtime_initializer)
1513         (has_ravenscar_runtime, get_running_thread_id)
1514         (ravenscar_thread_target::resume): Fix indentation.
1515
1516 2019-02-15  Tom Tromey  <tromey@adacore.com>
1517
1518         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
1519         from ravenscar_arch_ops.
1520         (sparc_ravenscar_ops::fetch_registers)
1521         (sparc_ravenscar_ops::store_registers): Now methods.
1522         (sparc_ravenscar_prepare_to_store): Remove.
1523         (sparc_ravenscar_ops): Redefine.
1524         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1525         methods and destructor.  Remove members.
1526         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1527         (ravenscar_thread_target::store_registers)
1528         (ravenscar_thread_target::prepare_to_store): Update.
1529         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1530         Remove.
1531         (struct ppc_ravenscar_powerpc_ops): Derive from
1532         ravenscar_arch_ops.
1533         (ppc_ravenscar_powerpc_ops::fetch_registers)
1534         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1535         (ppc_ravenscar_powerpc_ops): Redefine.
1536         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1537         (ppc_ravenscar_e500_ops::fetch_registers)
1538         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1539         (ppc_ravenscar_e500_ops): Redefine.
1540         * aarch64-ravenscar-thread.c
1541         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1542         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1543         (aarch64_ravenscar_fetch_registers)
1544         (aarch64_ravenscar_store_registers): Now methods.
1545         (aarch64_ravenscar_ops): Redefine.
1546
1547 2019-02-15  Tom Tromey  <tromey@adacore.com>
1548
1549         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1550         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1551         (ravenscar_thread_target::stopped_by_watchpoint)
1552         (ravenscar_thread_target::stopped_data_address)
1553         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1554
1555 2019-02-15  Tom Tromey  <tromey@adacore.com>
1556
1557         * ravenscar-thread.c: Fix some typos.
1558
1559 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1560             Tom Tromey  <tromey@adacore.com>
1561
1562         * ada-lang.c (ada_exception_sal): Change addr_string to a
1563         std::string.
1564         (create_ada_exception_catchpoint): Update.
1565
1566 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1567             Tom Tromey  <tromey@adacore.com>
1568
1569         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
1570         (bp_location_ops): Remove.
1571         (base_breakpoint_allocate_location): Update.
1572         (free_bp_location): Update.
1573         * ada-lang.c (class ada_catchpoint_location)
1574         <ada_catchpoint_location>: Remove ops parameter.
1575         (ada_catchpoint_location_dtor): Remove.
1576         (ada_catchpoint_location_ops): Remove.
1577         (allocate_location_exception): Update.
1578         * breakpoint.h (struct bp_location_ops): Remove.
1579         (class bp_location) <bp_location>: Remove bp_location_ops
1580         parameter.
1581         <~bp_location>: Add destructor.
1582         <ops>: Remove.
1583
1584 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1585             Pedro Alves  <palves@redhat.com>
1586
1587         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
1588         'PATH_MAX'.
1589
1590 2019-02-14  David Michael  <fedora.dm0@gmail.com>
1591             Samuel Thibault  <samuel.thibault@gnu.org>
1592             Thomas Schwinge  <thomas@codesourcery.com>
1593
1594         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
1595         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
1596
1597 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1598
1599         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
1600         (check_empty): Use "const char *".
1601
1602         * gnu-nat.c (gnu_nat_target::detach): Instead of
1603         'detach_inferior (pid)' call
1604         'detach_inferior (find_inferior_pid (pid))'.
1605
1606         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
1607         'nat/fork-inferior.o'.
1608         * gnu-nat.c: #include "nat/fork-inferior.h".
1609
1610         * gnu-nat.c (gnu_nat_target::detach): Instead of
1611         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
1612         * gnu-nat.h: #include "inf-child.h".
1613         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
1614         'i386_gnu_nat_target::fetch_registers'.
1615         (gnu_store_registers): Rename/move to
1616         'i386_gnu_nat_target::store_registers'.
1617
1618         * config/i386/nm-i386gnu.h: Don't "#include" any files.
1619         * gnu-nat.h (mach_thread_info): New function.
1620         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
1621
1622         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
1623
1624 2019-02-14  Frederic Konrad  <konrad@adacore.com>
1625
1626         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
1627
1628 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
1629
1630         * windows-nat.c (windows_add_thread): Add new parameter
1631         "main_thread_p" with default value set to false.  Update
1632         function documentation as well as all callers.
1633         (windows_delete_thread): Likewise.
1634         (fake_create_process): Update call to windows_add_thread.
1635         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
1636         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
1637         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
1638         call to windows_delete_thread.
1639
1640 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
1641
1642         * MAINTAINERS: Add Andrew Burgess as global maintainer.
1643
1644 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1645
1646         * symfile.c (find_separate_debug_file): Use canonical path of
1647         sysroot with child_path instead of gdb_sysroot if it is valid.
1648
1649 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1650
1651         * symfile.c (find_separate_debug_file): Use child_path to
1652         determine if an object file is under a sysroot.
1653
1654 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1655
1656         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1657         unittests/child-path-selftests.c.
1658         * common/pathstuff.c (child_path): New function.
1659         * common/pathstuff.h (child_path): New prototype.
1660         * unittests/child-path-selftests.c: New file.
1661
1662 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1663
1664         * symfile.c (find_separate_debug_file): Look for separate debug
1665         files in debug directories under the sysroot.
1666
1667 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1668
1669         * symtab.h (struct minimal_symbol data_p): New const method.
1670         (struct minimal_symbol text_p): Likewise.
1671         * symtab.c (output_source_filename): Use file name style
1672         to print file name.
1673         (print_symbol_info): Likewise.
1674         (print_msymbol_info): Use address style to print addresses.
1675         Use function name style to print executable text symbols.
1676         (expand_symtab_containing_pc): Use data_p.
1677         (find_pc_sect_compunit_symtab): Likewise.
1678
1679 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1680
1681         * breakpoint.c (describe_other_breakpoints): Use address style
1682         to print addresses.
1683         (say_where): Likewise.
1684
1685 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1686
1687         * ada-typeprint.c (print_func_type): Print function name
1688         style to print function name.
1689         * c-typeprint.c (c_print_type_1): Likewise.
1690
1691 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
1692
1693         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
1694         for execve.
1695
1696 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1697
1698         * c-exp.y (direct_abs_decl): Use emplace_back to record the
1699         type_stack.
1700
1701 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
1702
1703         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
1704         TYPE_CODE_REF types.
1705
1706 2019-02-08  Jim Wilson  <jimw@sifive.com>
1707
1708         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
1709         (riscv_linux_fregset): New.
1710         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
1711
1712 2019-02-07  Tom Tromey  <tom@tromey.com>
1713
1714         * thread.c (thread_cancel_execution_command): Update.
1715         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
1716         methods.
1717         (struct thread_fsm_ops): Remove.
1718         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
1719         (thread_fsm_should_stop, thread_fsm_return_value)
1720         (thread_fsm_set_finished, thread_fsm_finished_p)
1721         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
1722         Don't declare.
1723         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
1724         * infrun.c (clear_proceed_status_thread)
1725         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
1726         (print_stop_event): Update.
1727         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
1728         Add constructor.
1729         (step_command_fsm_ops): Remove.
1730         (new_step_command_fsm): Remove.
1731         (step_1): Update.
1732         (step_command_fsm::should_stop): Rename from
1733         step_command_fsm_should_stop.
1734         (step_command_fsm::clean_up): Rename from
1735         step_command_fsm_clean_up.
1736         (step_command_fsm::do_async_reply_reason): Rename from
1737         step_command_fsm_async_reply_reason.
1738         (struct until_next_fsm): Inherit from thread_fsm.  Add
1739         constructor.
1740         (until_next_fsm_ops): Remove.
1741         (new_until_next_fsm): Remove.
1742         (until_next_fsm::should_stop): Rename from
1743         until_next_fsm_should_stop.
1744         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
1745         (until_next_fsm::do_async_reply_reason): Rename from
1746         until_next_fsm_async_reply_reason.
1747         (struct finish_command_fsm): Inherit from thread_fsm.  Add
1748         constructor.  Change type of breakpoint.
1749         (finish_command_fsm_ops): Remove.
1750         (new_finish_command_fsm): Remove.
1751         (finish_command_fsm::should_stop): Rename from
1752         finish_command_fsm_should_stop.
1753         (finish_command_fsm::clean_up): Rename from
1754         finish_command_fsm_clean_up.
1755         (finish_command_fsm::return_value): Rename from
1756         finish_command_fsm_return_value.
1757         (finish_command_fsm::do_async_reply_reason): Rename from
1758         finish_command_fsm_async_reply_reason.
1759         (finish_command): Update.
1760         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
1761         Add constructor.
1762         (call_thread_fsm_ops): Remove.
1763         (call_thread_fsm::call_thread_fsm): Rename from
1764         new_call_thread_fsm.
1765         (call_thread_fsm::should_stop): Rename from
1766         call_thread_fsm_should_stop.
1767         (call_thread_fsm::should_notify_stop): Rename from
1768         call_thread_fsm_should_notify_stop.
1769         (run_inferior_call, call_function_by_hand_dummy): Update.
1770         * cli/cli-interp.c (should_print_stop_to_console): Update.
1771         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
1772         Add constructor.  Change type of location_breakpoint,
1773         caller_breakpoint.
1774         (until_break_fsm_ops): Remove.
1775         (new_until_break_fsm): Remove.
1776         (until_break_fsm::should_stop): Rename from
1777         until_break_fsm_should_stop.
1778         (until_break_fsm::clean_up): Rename from
1779         until_break_fsm_clean_up.
1780         (until_break_fsm::do_async_reply_reason): Rename from
1781         until_break_fsm_async_reply_reason.
1782         (until_break_command): Update.
1783         * thread-fsm.c: Remove.
1784         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
1785
1786 2019-02-07  Tom Tromey  <tom@tromey.com>
1787
1788         * yy-remap.h: Add include guard.
1789         * xtensa-tdep.h: Add include guard.
1790         * xcoffread.h: Rename include guard.
1791         * varobj-iter.h: Add include guard.
1792         * tui/tui.h: Rename include guard.
1793         * tui/tui-winsource.h: Rename include guard.
1794         * tui/tui-wingeneral.h: Rename include guard.
1795         * tui/tui-windata.h: Rename include guard.
1796         * tui/tui-win.h: Rename include guard.
1797         * tui/tui-stack.h: Rename include guard.
1798         * tui/tui-source.h: Rename include guard.
1799         * tui/tui-regs.h: Rename include guard.
1800         * tui/tui-out.h: Rename include guard.
1801         * tui/tui-layout.h: Rename include guard.
1802         * tui/tui-io.h: Rename include guard.
1803         * tui/tui-hooks.h: Rename include guard.
1804         * tui/tui-file.h: Rename include guard.
1805         * tui/tui-disasm.h: Rename include guard.
1806         * tui/tui-data.h: Rename include guard.
1807         * tui/tui-command.h: Rename include guard.
1808         * tic6x-tdep.h: Add include guard.
1809         * target/waitstatus.h: Rename include guard.
1810         * target/wait.h: Rename include guard.
1811         * target/target.h: Rename include guard.
1812         * target/resume.h: Rename include guard.
1813         * target-float.h: Rename include guard.
1814         * stabsread.h: Add include guard.
1815         * rs6000-tdep.h: Add include guard.
1816         * riscv-fbsd-tdep.h: Add include guard.
1817         * regformats/regdef.h: Rename include guard.
1818         * record.h: Rename include guard.
1819         * python/python.h: Rename include guard.
1820         * python/python-internal.h: Rename include guard.
1821         * python/py-stopevent.h: Rename include guard.
1822         * python/py-ref.h: Rename include guard.
1823         * python/py-record.h: Rename include guard.
1824         * python/py-record-full.h: Rename include guard.
1825         * python/py-record-btrace.h: Rename include guard.
1826         * python/py-instruction.h: Rename include guard.
1827         * python/py-events.h: Rename include guard.
1828         * python/py-event.h: Rename include guard.
1829         * procfs.h: Add include guard.
1830         * proc-utils.h: Add include guard.
1831         * p-lang.h: Add include guard.
1832         * or1k-tdep.h: Rename include guard.
1833         * observable.h: Rename include guard.
1834         * nto-tdep.h: Rename include guard.
1835         * nat/x86-linux.h: Rename include guard.
1836         * nat/x86-linux-dregs.h: Rename include guard.
1837         * nat/x86-gcc-cpuid.h: Add include guard.
1838         * nat/x86-dregs.h: Rename include guard.
1839         * nat/x86-cpuid.h: Rename include guard.
1840         * nat/ppc-linux.h: Rename include guard.
1841         * nat/mips-linux-watch.h: Rename include guard.
1842         * nat/linux-waitpid.h: Rename include guard.
1843         * nat/linux-ptrace.h: Rename include guard.
1844         * nat/linux-procfs.h: Rename include guard.
1845         * nat/linux-osdata.h: Rename include guard.
1846         * nat/linux-nat.h: Rename include guard.
1847         * nat/linux-namespaces.h: Rename include guard.
1848         * nat/linux-btrace.h: Rename include guard.
1849         * nat/glibc_thread_db.h: Rename include guard.
1850         * nat/gdb_thread_db.h: Rename include guard.
1851         * nat/gdb_ptrace.h: Rename include guard.
1852         * nat/fork-inferior.h: Rename include guard.
1853         * nat/amd64-linux-siginfo.h: Rename include guard.
1854         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
1855         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
1856         * nat/aarch64-linux.h: Rename include guard.
1857         * nat/aarch64-linux-hw-point.h: Rename include guard.
1858         * mn10300-tdep.h: Add include guard.
1859         * mips-linux-tdep.h: Add include guard.
1860         * mi/mi-parse.h: Rename include guard.
1861         * mi/mi-out.h: Rename include guard.
1862         * mi/mi-main.h: Rename include guard.
1863         * mi/mi-interp.h: Rename include guard.
1864         * mi/mi-getopt.h: Rename include guard.
1865         * mi/mi-console.h: Rename include guard.
1866         * mi/mi-common.h: Rename include guard.
1867         * mi/mi-cmds.h: Rename include guard.
1868         * mi/mi-cmd-break.h: Rename include guard.
1869         * m2-lang.h: Add include guard.
1870         * location.h: Rename include guard.
1871         * linux-record.h: Rename include guard.
1872         * linux-nat.h: Add include guard.
1873         * linux-fork.h: Add include guard.
1874         * i386-darwin-tdep.h: Rename include guard.
1875         * hppa-linux-offsets.h: Add include guard.
1876         * guile/guile.h: Rename include guard.
1877         * guile/guile-internal.h: Rename include guard.
1878         * gnu-nat.h: Rename include guard.
1879         * gdb-stabs.h: Rename include guard.
1880         * frv-tdep.h: Add include guard.
1881         * f-lang.h: Add include guard.
1882         * event-loop.h: Add include guard.
1883         * darwin-nat.h: Rename include guard.
1884         * cp-abi.h: Rename include guard.
1885         * config/sparc/nm-sol2.h: Rename include guard.
1886         * config/nm-nto.h: Rename include guard.
1887         * config/nm-linux.h: Add include guard.
1888         * config/i386/nm-i386gnu.h: Rename include guard.
1889         * config/djgpp/nl_types.h: Rename include guard.
1890         * config/djgpp/langinfo.h: Rename include guard.
1891         * compile/gcc-cp-plugin.h: Add include guard.
1892         * compile/gcc-c-plugin.h: Add include guard.
1893         * compile/compile.h: Rename include guard.
1894         * compile/compile-object-run.h: Rename include guard.
1895         * compile/compile-object-load.h: Rename include guard.
1896         * compile/compile-internal.h: Rename include guard.
1897         * compile/compile-cplus.h: Rename include guard.
1898         * compile/compile-c.h: Rename include guard.
1899         * common/xml-utils.h: Rename include guard.
1900         * common/x86-xstate.h: Rename include guard.
1901         * common/version.h: Rename include guard.
1902         * common/vec.h: Rename include guard.
1903         * common/tdesc.h: Rename include guard.
1904         * common/selftest.h: Rename include guard.
1905         * common/scoped_restore.h: Rename include guard.
1906         * common/scoped_mmap.h: Rename include guard.
1907         * common/scoped_fd.h: Rename include guard.
1908         * common/safe-iterator.h: Rename include guard.
1909         * common/run-time-clock.h: Rename include guard.
1910         * common/refcounted-object.h: Rename include guard.
1911         * common/queue.h: Rename include guard.
1912         * common/ptid.h: Rename include guard.
1913         * common/print-utils.h: Rename include guard.
1914         * common/preprocessor.h: Rename include guard.
1915         * common/pathstuff.h: Rename include guard.
1916         * common/observable.h: Rename include guard.
1917         * common/netstuff.h: Rename include guard.
1918         * common/job-control.h: Rename include guard.
1919         * common/host-defs.h: Rename include guard.
1920         * common/gdb_wait.h: Rename include guard.
1921         * common/gdb_vecs.h: Rename include guard.
1922         * common/gdb_unlinker.h: Rename include guard.
1923         * common/gdb_unique_ptr.h: Rename include guard.
1924         * common/gdb_tilde_expand.h: Rename include guard.
1925         * common/gdb_sys_time.h: Rename include guard.
1926         * common/gdb_string_view.h: Rename include guard.
1927         * common/gdb_splay_tree.h: Rename include guard.
1928         * common/gdb_setjmp.h: Rename include guard.
1929         * common/gdb_ref_ptr.h: Rename include guard.
1930         * common/gdb_optional.h: Rename include guard.
1931         * common/gdb_locale.h: Rename include guard.
1932         * common/gdb_assert.h: Rename include guard.
1933         * common/filtered-iterator.h: Rename include guard.
1934         * common/filestuff.h: Rename include guard.
1935         * common/fileio.h: Rename include guard.
1936         * common/environ.h: Rename include guard.
1937         * common/common-utils.h: Rename include guard.
1938         * common/common-types.h: Rename include guard.
1939         * common/common-regcache.h: Rename include guard.
1940         * common/common-inferior.h: Rename include guard.
1941         * common/common-gdbthread.h: Rename include guard.
1942         * common/common-exceptions.h: Rename include guard.
1943         * common/common-defs.h: Rename include guard.
1944         * common/common-debug.h: Rename include guard.
1945         * common/cleanups.h: Rename include guard.
1946         * common/buffer.h: Rename include guard.
1947         * common/btrace-common.h: Rename include guard.
1948         * common/break-common.h: Rename include guard.
1949         * cli/cli-utils.h: Rename include guard.
1950         * cli/cli-style.h: Rename include guard.
1951         * cli/cli-setshow.h: Rename include guard.
1952         * cli/cli-script.h: Rename include guard.
1953         * cli/cli-interp.h: Rename include guard.
1954         * cli/cli-decode.h: Rename include guard.
1955         * cli/cli-cmds.h: Rename include guard.
1956         * charset-list.h: Add include guard.
1957         * buildsym-legacy.h: Rename include guard.
1958         * bfin-tdep.h: Add include guard.
1959         * ax.h: Rename include guard.
1960         * arm-linux-tdep.h: Add include guard.
1961         * arm-fbsd-tdep.h: Add include guard.
1962         * arch/xtensa.h: Rename include guard.
1963         * arch/tic6x.h: Add include guard.
1964         * arch/i386.h: Add include guard.
1965         * arch/arm.h: Rename include guard.
1966         * arch/arm-linux.h: Rename include guard.
1967         * arch/arm-get-next-pcs.h: Rename include guard.
1968         * arch/amd64.h: Add include guard.
1969         * arch/aarch64-insn.h: Rename include guard.
1970         * arch-utils.h: Rename include guard.
1971         * annotate.h: Add include guard.
1972         * amd64-darwin-tdep.h: Rename include guard.
1973         * aarch64-linux-tdep.h: Add include guard.
1974         * aarch64-fbsd-tdep.h: Add include guard.
1975         * aarch32-linux-nat.h: Add include guard.
1976
1977 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1978
1979         * macrotab.c (macro_define_internal): New function that
1980         factorizes macro_define_object_internal and macro_define_function
1981         code.
1982         (macro_define_object_internal): Use macro_define_internal.
1983         (macro_define_function): Likewise.
1984
1985 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1986
1987         * macrocmd.c (extract_identifier): Return
1988         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
1989         callers.
1990
1991 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
1992
1993         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
1994
1995 2019-02-05  Tom Tromey  <tom@tromey.com>
1996
1997         * target.c (target_stack::unpush): Move assertion earlier.
1998
1999 2019-01-30  Tom Tromey  <tom@tromey.com>
2000
2001         PR python/23615:
2002         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
2003         (gdbpy_parse_and_eval): Likewise.
2004         * python/python-internal.h (gdbpy_allow_threads): New class.
2005
2006 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
2007
2008         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
2009         (aarch64_fbsd_fpregmap): Move earlier.
2010         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
2011         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2012         instead of individual calls to trad_frame_set_reg_addr.
2013         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
2014         earlier.
2015         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
2016         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2017         instead of individual calls to trad_frame_set_reg_addr.
2018
2019 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
2020
2021         * CONTRIBUTE: Replace contribution list with wiki link.
2022
2023 2019-01-25  Tom Tromey  <tom@tromey.com>
2024
2025         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
2026
2027 2019-01-25  Tom Tromey  <tom@tromey.com>
2028
2029         * xtensa-linux-nat.c: Fix common/ includes.
2030         * xml-support.h: Fix common/ includes.
2031         * xml-support.c: Fix common/ includes.
2032         * x86-linux-nat.c: Fix common/ includes.
2033         * windows-nat.c: Fix common/ includes.
2034         * varobj.h: Fix common/ includes.
2035         * varobj.c: Fix common/ includes.
2036         * value.c: Fix common/ includes.
2037         * valops.c: Fix common/ includes.
2038         * utils.c: Fix common/ includes.
2039         * unittests/xml-utils-selftests.c: Fix common/ includes.
2040         * unittests/utils-selftests.c: Fix common/ includes.
2041         * unittests/unpack-selftests.c: Fix common/ includes.
2042         * unittests/tracepoint-selftests.c: Fix common/ includes.
2043         * unittests/style-selftests.c: Fix common/ includes.
2044         * unittests/string_view-selftests.c: Fix common/ includes.
2045         * unittests/scoped_restore-selftests.c: Fix common/ includes.
2046         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
2047         * unittests/scoped_fd-selftests.c: Fix common/ includes.
2048         * unittests/rsp-low-selftests.c: Fix common/ includes.
2049         * unittests/parse-connection-spec-selftests.c: Fix common/
2050         includes.
2051         * unittests/optional-selftests.c: Fix common/ includes.
2052         * unittests/offset-type-selftests.c: Fix common/ includes.
2053         * unittests/observable-selftests.c: Fix common/ includes.
2054         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
2055         * unittests/memrange-selftests.c: Fix common/ includes.
2056         * unittests/memory-map-selftests.c: Fix common/ includes.
2057         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
2058         * unittests/function-view-selftests.c: Fix common/ includes.
2059         * unittests/environ-selftests.c: Fix common/ includes.
2060         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
2061         * unittests/common-utils-selftests.c: Fix common/ includes.
2062         * unittests/cli-utils-selftests.c: Fix common/ includes.
2063         * unittests/array-view-selftests.c: Fix common/ includes.
2064         * ui-file.c: Fix common/ includes.
2065         * tui/tui-io.c: Fix common/ includes.
2066         * tracepoint.h: Fix common/ includes.
2067         * tracepoint.c: Fix common/ includes.
2068         * tracefile-tfile.c: Fix common/ includes.
2069         * top.h: Fix common/ includes.
2070         * top.c: Fix common/ includes.
2071         * thread.c: Fix common/ includes.
2072         * target/waitstatus.h: Fix common/ includes.
2073         * target/waitstatus.c: Fix common/ includes.
2074         * target.h: Fix common/ includes.
2075         * target.c: Fix common/ includes.
2076         * target-memory.c: Fix common/ includes.
2077         * target-descriptions.c: Fix common/ includes.
2078         * symtab.h: Fix common/ includes.
2079         * symfile.c: Fix common/ includes.
2080         * stap-probe.c: Fix common/ includes.
2081         * spu-linux-nat.c: Fix common/ includes.
2082         * sparc-nat.c: Fix common/ includes.
2083         * source.c: Fix common/ includes.
2084         * solib.c: Fix common/ includes.
2085         * solib-target.c: Fix common/ includes.
2086         * ser-unix.c: Fix common/ includes.
2087         * ser-tcp.c: Fix common/ includes.
2088         * ser-pipe.c: Fix common/ includes.
2089         * ser-base.c: Fix common/ includes.
2090         * selftest-arch.c: Fix common/ includes.
2091         * s12z-tdep.c: Fix common/ includes.
2092         * rust-exp.y: Fix common/ includes.
2093         * rs6000-aix-tdep.c: Fix common/ includes.
2094         * riscv-tdep.c: Fix common/ includes.
2095         * remote.c: Fix common/ includes.
2096         * remote-notif.h: Fix common/ includes.
2097         * remote-fileio.h: Fix common/ includes.
2098         * remote-fileio.c: Fix common/ includes.
2099         * regcache.h: Fix common/ includes.
2100         * regcache.c: Fix common/ includes.
2101         * record-btrace.c: Fix common/ includes.
2102         * python/python.c: Fix common/ includes.
2103         * python/py-type.c: Fix common/ includes.
2104         * python/py-inferior.c: Fix common/ includes.
2105         * progspace.h: Fix common/ includes.
2106         * producer.c: Fix common/ includes.
2107         * procfs.c: Fix common/ includes.
2108         * proc-api.c: Fix common/ includes.
2109         * printcmd.c: Fix common/ includes.
2110         * ppc-linux-nat.c: Fix common/ includes.
2111         * parser-defs.h: Fix common/ includes.
2112         * osdata.c: Fix common/ includes.
2113         * obsd-nat.c: Fix common/ includes.
2114         * nat/x86-linux.c: Fix common/ includes.
2115         * nat/x86-linux-dregs.c: Fix common/ includes.
2116         * nat/x86-dregs.h: Fix common/ includes.
2117         * nat/x86-dregs.c: Fix common/ includes.
2118         * nat/ppc-linux.c: Fix common/ includes.
2119         * nat/mips-linux-watch.h: Fix common/ includes.
2120         * nat/mips-linux-watch.c: Fix common/ includes.
2121         * nat/linux-waitpid.c: Fix common/ includes.
2122         * nat/linux-ptrace.h: Fix common/ includes.
2123         * nat/linux-ptrace.c: Fix common/ includes.
2124         * nat/linux-procfs.c: Fix common/ includes.
2125         * nat/linux-personality.c: Fix common/ includes.
2126         * nat/linux-osdata.c: Fix common/ includes.
2127         * nat/linux-namespaces.c: Fix common/ includes.
2128         * nat/linux-btrace.h: Fix common/ includes.
2129         * nat/linux-btrace.c: Fix common/ includes.
2130         * nat/fork-inferior.c: Fix common/ includes.
2131         * nat/amd64-linux-siginfo.c: Fix common/ includes.
2132         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
2133         * nat/aarch64-linux.c: Fix common/ includes.
2134         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
2135         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
2136         * namespace.h: Fix common/ includes.
2137         * mips-linux-tdep.c: Fix common/ includes.
2138         * minsyms.c: Fix common/ includes.
2139         * mi/mi-parse.h: Fix common/ includes.
2140         * mi/mi-main.c: Fix common/ includes.
2141         * mi/mi-cmd-env.c: Fix common/ includes.
2142         * memrange.h: Fix common/ includes.
2143         * memattr.c: Fix common/ includes.
2144         * maint.h: Fix common/ includes.
2145         * maint.c: Fix common/ includes.
2146         * main.c: Fix common/ includes.
2147         * machoread.c: Fix common/ includes.
2148         * location.c: Fix common/ includes.
2149         * linux-thread-db.c: Fix common/ includes.
2150         * linux-nat.c: Fix common/ includes.
2151         * linux-fork.c: Fix common/ includes.
2152         * inline-frame.c: Fix common/ includes.
2153         * infrun.c: Fix common/ includes.
2154         * inflow.c: Fix common/ includes.
2155         * inferior.h: Fix common/ includes.
2156         * inferior.c: Fix common/ includes.
2157         * infcmd.c: Fix common/ includes.
2158         * inf-ptrace.c: Fix common/ includes.
2159         * inf-child.c: Fix common/ includes.
2160         * ia64-linux-nat.c: Fix common/ includes.
2161         * i387-tdep.c: Fix common/ includes.
2162         * i386-tdep.c: Fix common/ includes.
2163         * i386-linux-tdep.c: Fix common/ includes.
2164         * i386-linux-nat.c: Fix common/ includes.
2165         * i386-go32-tdep.c: Fix common/ includes.
2166         * i386-fbsd-tdep.c: Fix common/ includes.
2167         * i386-fbsd-nat.c: Fix common/ includes.
2168         * guile/scm-type.c: Fix common/ includes.
2169         * guile/guile.c: Fix common/ includes.
2170         * go32-nat.c: Fix common/ includes.
2171         * gnu-nat.c: Fix common/ includes.
2172         * gdbthread.h: Fix common/ includes.
2173         * gdbarch-selftests.c: Fix common/ includes.
2174         * gdb_usleep.c: Fix common/ includes.
2175         * gdb_select.h: Fix common/ includes.
2176         * gdb_bfd.c: Fix common/ includes.
2177         * gcore.c: Fix common/ includes.
2178         * fork-child.c: Fix common/ includes.
2179         * findvar.c: Fix common/ includes.
2180         * fbsd-nat.c: Fix common/ includes.
2181         * event-top.c: Fix common/ includes.
2182         * event-loop.c: Fix common/ includes.
2183         * dwarf2read.c: Fix common/ includes.
2184         * dwarf2loc.c: Fix common/ includes.
2185         * dwarf2-frame.c: Fix common/ includes.
2186         * dwarf-index-cache.c: Fix common/ includes.
2187         * dtrace-probe.c: Fix common/ includes.
2188         * disasm-selftests.c: Fix common/ includes.
2189         * defs.h: Fix common/ includes.
2190         * csky-tdep.c: Fix common/ includes.
2191         * cp-valprint.c: Fix common/ includes.
2192         * cp-support.h: Fix common/ includes.
2193         * cp-support.c: Fix common/ includes.
2194         * corelow.c: Fix common/ includes.
2195         * completer.h: Fix common/ includes.
2196         * completer.c: Fix common/ includes.
2197         * compile/compile.c: Fix common/ includes.
2198         * compile/compile-loc2c.c: Fix common/ includes.
2199         * compile/compile-cplus-types.c: Fix common/ includes.
2200         * compile/compile-cplus-symbols.c: Fix common/ includes.
2201         * command.h: Fix common/ includes.
2202         * cli/cli-dump.c: Fix common/ includes.
2203         * cli/cli-cmds.c: Fix common/ includes.
2204         * charset.c: Fix common/ includes.
2205         * build-id.c: Fix common/ includes.
2206         * btrace.h: Fix common/ includes.
2207         * btrace.c: Fix common/ includes.
2208         * breakpoint.h: Fix common/ includes.
2209         * breakpoint.c: Fix common/ includes.
2210         * ax.h:
2211         (enum agent_op): Fix common/ includes.
2212         * ax-general.c (struct aop_map): Fix common/ includes.
2213         * ax-gdb.c: Fix common/ includes.
2214         * auxv.c: Fix common/ includes.
2215         * auto-load.c: Fix common/ includes.
2216         * arm-tdep.c: Fix common/ includes.
2217         * arch/riscv.c: Fix common/ includes.
2218         * arch/ppc-linux-common.c: Fix common/ includes.
2219         * arch/i386.c: Fix common/ includes.
2220         * arch/arm.c: Fix common/ includes.
2221         * arch/arm-linux.c: Fix common/ includes.
2222         * arch/arm-get-next-pcs.c: Fix common/ includes.
2223         * arch/amd64.c: Fix common/ includes.
2224         * arch/aarch64.c: Fix common/ includes.
2225         * arch/aarch64-insn.c: Fix common/ includes.
2226         * arch-utils.c: Fix common/ includes.
2227         * amd64-windows-tdep.c: Fix common/ includes.
2228         * amd64-tdep.c: Fix common/ includes.
2229         * amd64-sol2-tdep.c: Fix common/ includes.
2230         * amd64-obsd-tdep.c: Fix common/ includes.
2231         * amd64-nbsd-tdep.c: Fix common/ includes.
2232         * amd64-linux-tdep.c: Fix common/ includes.
2233         * amd64-linux-nat.c: Fix common/ includes.
2234         * amd64-fbsd-tdep.c: Fix common/ includes.
2235         * amd64-fbsd-nat.c: Fix common/ includes.
2236         * amd64-dicos-tdep.c: Fix common/ includes.
2237         * amd64-darwin-tdep.c: Fix common/ includes.
2238         * agent.c: Fix common/ includes.
2239         * ada-lang.h: Fix common/ includes.
2240         * ada-lang.c: Fix common/ includes.
2241         * aarch64-tdep.c: Fix common/ includes.
2242
2243 2019-01-25  Tom Tromey  <tom@tromey.com>
2244
2245         * common/create-version.sh: Use common/version.h.
2246
2247 2019-01-24  Pedro Alves  <palves@redhat.com>
2248
2249         * infrun.c (signal_stop, signal_print, signal_program)
2250         (signal_catch, signal_pass): Now arrays instead of pointers.
2251         (update_signals_program_target, do_target_resume)
2252         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2253         * linux-nat.c (linux_nat_target::pass_signals)
2254         (linux_nat_target::create_inferior, linux_nat_target::attach):
2255         Adjust.
2256         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2257         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2258         * procfs.c (procfs_target::pass_signals): Adjust.
2259         * record-full.c (record_full_target::resume): Adjust.
2260         * remote.c (remote_target::pass_signals)
2261         (remote_target::program_signals): Adjust.
2262         * target-debug.h (target_debug_print_signals): Now takes a
2263         gdb::array_view as parameter.  Adjust.
2264         * target.h (target_ops) <pass_signals, program_signals>: Replace
2265         pointer and length parameters with gdb::array_view.
2266         (target_pass_signals, target_program_signals): Likewise.
2267         * target-delegates.c: Regenerate.
2268
2269 2019-01-24  Pedro Alves  <palves@redhat.com>
2270
2271         * common/forward-scope-exit.h
2272         (forward_scope_exit::forward_scope_exit): Pass arguments to
2273         m_bind_function directly, instead of creating a std::bind and
2274         copying that.
2275
2276 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
2277
2278         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2279         for static members.
2280         (pass_in_v_vfp_candidate): Likewise.
2281
2282 2019-01-23  Tom Tromey  <tom@tromey.com>
2283             Pedro Alves  <palves@redhat.com>
2284
2285         * regcache.c (class regcache_invalidator): Remove.
2286         (regcache::raw_write): Use make_scope_exit.
2287
2288 2019-01-23  Tom Tromey  <tom@tromey.com>
2289
2290         * ui-out.h (class ui_out_emit_type): Update comment.
2291
2292 2019-01-23  Tom Tromey  <tom@tromey.com>
2293
2294         * infrun.c (fetch_inferior_event): Update comment.
2295
2296 2019-01-23  Tom Tromey  <tom@tromey.com>
2297             Pedro Alves  <palves@redhat.com>
2298
2299         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
2300         parameter.
2301         (fetch_inferior_event): Use SCOPE_EXIT.
2302
2303
2304 2019-01-23  Tom Tromey  <tom@tromey.com>
2305             Pedro Alves  <palves@redhat.com>
2306
2307         * infrun.c (disable_thread_events): Delete.
2308         (stop_all_threads): Use SCOPE_EXIT.
2309
2310 2019-01-23  Tom Tromey  <tom@tromey.com>
2311             Pedro Alves  <palves@redhat.com>
2312
2313         * symfile.c: Include forward-scope-exit.h.
2314         (clear_symtab_users_cleanup): Replace forward declaration with
2315         a FORWARD_SCOPE_EXIT.
2316         (syms_from_objfile_1): Use the forward_scope_exit and
2317         gdb::optional instead of cleanup_function.
2318         (reread_symbols): Use the forward_scope_exit instead of
2319         cleanup_function.
2320         (clear_symtab_users_cleanup): Remove function.
2321
2322 2019-01-23  Tom Tromey  <tom@tromey.com>
2323             Pedro Alves  <palves@redhat.com>
2324
2325         * linux-nat.c: Include scope-exit.h.
2326         (cleanup_target_stop): Remove.
2327         (linux_nat_target::static_tracepoint_markers_by_strid): Use
2328         SCOPE_EXIT.
2329
2330 2019-01-23  Tom Tromey  <tom@tromey.com>
2331             Pedro Alves  <palves@redhat.com>
2332
2333         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
2334         (call_function_by_hand_dummy): Use SCOPE_EXIT.
2335
2336 2019-01-23  Tom Tromey  <tom@tromey.com>
2337             Andrew Burgess  <andrew.burgess@embecosm.com>
2338             Pedro Alves  <palves@redhat.com>
2339
2340         * infrun.c (fetch_inferior_event): Use scope_exit.
2341         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
2342         * top.c (execute_command): Use scope_exit.
2343         * breakpoint.c (bpstat_do_actions): Use scope_exit.
2344         * utils.c (do_bpstat_clear_actions_cleanup)
2345         (make_bpstat_clear_actions_cleanup): Remove.
2346
2347 2019-01-23  Tom Tromey  <tom@tromey.com>
2348             Pedro Alves  <palves@redhat.com>
2349
2350         * infrun.c: Include "common/scope-exit.h"
2351         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
2352         (wait_for_inferior): Use SCOPE_EXIT.
2353         (fetch_inferior_event): Use scope_exit.
2354
2355 2019-01-23  Tom Tromey  <tom@tromey.com>
2356             Pedro Alves  <palves@redhat.com>
2357
2358         * breakpoint.c (create_breakpoint): Remove cleanup.
2359
2360 2019-01-23  Tom Tromey  <tom@tromey.com>
2361             Andrew Burgess  <andrew.burgess@embecosm.com>
2362             Pedro Alves  <palves@redhat.com>
2363
2364 2019-01-23  Pedro Alves  <palves@redhat.com>
2365
2366         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
2367
2368 2019-01-23  Pedro Alves  <palves@redhat.com>
2369             Andrew Burgess  <andrew.burgess@embecosm.com>
2370
2371         * gdbthread.h: Include "common/forward-scope-exit.h".
2372         (scoped_finish_thread_state): Redefine custom class in terms of
2373         forward_scope_exit.
2374
2375 2019-01-23  Pedro Alves  <palves@redhat.com>
2376             Andrew Burgess  <andrew.burgess@embecosm.com>
2377
2378         * common/forward-scope-exit.h: New file.
2379
2380 2019-01-23  Pedro Alves  <palves@redhat.com>
2381             Andrew Burgess  <andrew.burgess@embecosm.com>
2382             Tom Tromey  <tom@tromey.com>
2383
2384         * common/scope-exit.h: New file.
2385
2386 2019-01-23  Pedro Alves  <palves@redhat.com>
2387
2388         * common/preprocessor.h (ESC): Rename to ...
2389         (ESC_PARENS): ... this.
2390         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
2391         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
2392
2393 2019-01-23  Tom Tromey  <tom@tromey.com>
2394
2395         * language.h (class scoped_switch_to_sym_language_if_auto):
2396         Initialize m_lang in both cases.
2397
2398 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
2399
2400         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
2401         with XCNEW.
2402
2403 2019-01-22  Tom Tromey  <tom@tromey.com>
2404
2405         * corelow.c: Do not include sys/file.h.
2406
2407 2019-01-22  Tom Tromey  <tom@tromey.com>
2408
2409         * tui/tui-wingeneral.h: Include gdb_curses.h.
2410
2411 2019-01-22  Tom Tromey  <tom@tromey.com>
2412
2413         * source-cache.h (class source_cache) <get_source_lines,
2414         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
2415
2416 2019-01-22  Tom Tromey  <tom@tromey.com>
2417
2418         * remote-fileio.h (struct remote_target): Declare.
2419
2420 2019-01-22  Tom Tromey  <tom@tromey.com>
2421
2422         * python/py-arch.c: Do not include py-ref.h.
2423         * python/py-bpevent.c: Do not include py-ref.h.
2424         * python/py-cmd.c: Do not include py-ref.h.
2425         * python/py-continueevent.c: Do not include py-ref.h.
2426         * python/py-event.h: Do not include py-ref.h.
2427         * python/py-evtregistry.c: Do not include py-ref.h.
2428         * python/py-finishbreakpoint.c: Do not include py-ref.h.
2429         * python/py-frame.c: Do not include py-ref.h.
2430         * python/py-framefilter.c: Do not include py-ref.h.
2431         * python/py-function.c: Do not include py-ref.h.
2432         * python/py-infevents.c: Do not include py-ref.h.
2433         * python/py-linetable.c: Do not include py-ref.h.
2434         * python/py-objfile.c: Do not include py-ref.h.
2435         * python/py-param.c: Do not include py-ref.h.
2436         * python/py-prettyprint.c: Do not include py-ref.h.
2437         * python/py-progspace.c: Do not include py-ref.h.
2438         * python/py-symbol.c: Do not include py-ref.h.
2439         * python/py-symtab.c: Do not include py-ref.h.
2440         * python/py-type.c: Do not include py-ref.h.
2441         * python/py-unwind.c: Do not include py-ref.h.
2442         * python/py-utils.c: Do not include py-ref.h.
2443         * python/py-value.c: Do not include py-ref.h.
2444         * python/py-varobj.c: Do not include py-ref.h.
2445         * python/py-xmethods.c: Do not include py-ref.h.
2446         * python/python.c: Do not include py-ref.h.
2447         * varobj.c: Do not include py-ref.h.
2448
2449 2019-01-22  Tom Tromey  <tom@tromey.com>
2450
2451         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2452         keyword for bcache.
2453
2454 2019-01-22  Tom Tromey  <tom@tromey.com>
2455
2456         * compile/compile-cplus-types.c: Remove a comment by #include.
2457
2458 2019-01-22  Tom Tromey  <tom@tromey.com>
2459
2460         * compile/gcc-c-plugin.h: Include compile-internal.h.
2461
2462 2019-01-22  Tom Tromey  <tom@tromey.com>
2463
2464         * stabsread.c (EXTERN): Do not define.
2465         (symnum, next_symbol_text_func, processing_gcc_compilation)
2466         (within_function, global_sym_chain, global_stabs)
2467         (previous_stab_code, this_object_header_files)
2468         (n_this_object_header_files)
2469         (n_allocated_this_object_header_files): Define.
2470         * stabsread.h (EXTERN): Never define.  Use "extern".
2471
2472 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2473
2474         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2475         history_value.
2476
2477 2019-01-21  Tom Tromey  <tom@tromey.com>
2478
2479         * ui-out.c: Fix includes.
2480         * tui/tui-source.c: Fix includes.
2481         * target.c: Fix includes.
2482         * remote.c: Fix includes.
2483         * regcache.c: Fix includes.
2484         * python/py-block.c: Fix includes.
2485         * printcmd.c: Fix includes.
2486         * or1k-tdep.c: Fix includes.
2487         * mi/mi-main.c: Fix includes.
2488         * m32r-tdep.c: Fix includes.
2489         * csky-tdep.c: Fix includes.
2490         * compile/compile-cplus-types.c: Fix includes.
2491         * cli/cli-interp.c: Fix includes.
2492
2493 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
2494
2495         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2496         for padding.
2497
2498 2019-01-16  Tom Tromey  <tom@tromey.com>
2499
2500         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
2501         earlier.
2502         (struct objfile) <msymbols_range>: Move from top level.
2503         <msymbols>: New method.
2504         (class objfile_msymbols): Remove.
2505         * symtab.c (default_collect_symbol_completion_matches_break_on):
2506         Update.
2507         * symmisc.c (dump_msymbols): Update.
2508         * stabsread.c (scan_file_globals): Update.
2509         * objc-lang.c (info_selectors_command, info_classes_command)
2510         (find_methods): Update.
2511         * minsyms.c (find_solib_trampoline_target): Update.
2512         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2513         * coffread.c (coff_symfile_read): Update.
2514         * ada-lang.c (ada_lookup_simple_minsym)
2515         (ada_collect_symbol_completion_matches): Update.
2516
2517 2019-01-16  Tom Tromey  <tom@tromey.com>
2518
2519         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
2520         type.  Remove no-argument constructor.
2521         <iterator::operator++>: Simplify.
2522         <begin>: Update.
2523         <end>: Use minimal_symbol_count.
2524
2525 2019-01-16  Tom Tromey  <tom@tromey.com>
2526
2527         * objfiles.h (struct objfile) <psymtabs>: New method.
2528         (class objfile_psymtabs): Remove.
2529         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2530         typedef.
2531         <range>: New method.
2532         (require_partial_symbols): Change return type.
2533         * psymtab.c (require_partial_symbols)
2534         (psym_expand_symtabs_matching): Update.
2535         * mdebugread.c (parse_partial_symbols): Update.
2536         * dbxread.c (dbx_end_psymtab): Update.
2537
2538 2019-01-15  Tom Tromey  <tom@tromey.com>
2539
2540         * symtab.c (lookup_objfile_from_block)
2541         (lookup_symbol_in_objfile_symtabs)
2542         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2543         (find_line_symtab, info_sources_command)
2544         (default_collect_symbol_completion_matches_break_on)
2545         (make_source_files_completion_list): Update.
2546         * symmisc.c (print_objfile_statistics, dump_objfile)
2547         (maintenance_print_symbols, maintenance_info_symtabs)
2548         (maintenance_check_symtabs, maintenance_info_line_tables):
2549         Update.
2550         * source.c (select_source_symtab)
2551         (forget_cached_source_info_for_objfile): Update.
2552         * objfiles.h (class objfile_compunits): Remove.
2553         (struct objfile) <compunits_range>: New typedef.
2554         (compunits): New method.
2555         * objfiles.c (objfile_relocate1): Update.
2556         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2557         * maint.c (count_symtabs_and_blocks): Update.
2558         * linespec.c (iterate_over_all_matching_symtabs): Update.
2559         * cp-support.c (add_symbol_overload_list_qualified): Update.
2560         * coffread.c (coff_symtab_read): Update.
2561         * ada-lang.c (add_nonlocal_symbols)
2562         (ada_collect_symbol_completion_matches)
2563         (ada_add_global_exceptions): Update.
2564
2565 2019-01-15  Tom Tromey  <tom@tromey.com>
2566
2567         * progspace.h (program_space) <objfiles_safe_range>: New
2568         typedef.
2569         <objfiles_safe>: New method.
2570         * objfiles.h (class all_objfiles_safe): Remove.
2571         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
2572         * jit.c (jit_inferior_exit_hook): Update.
2573
2574 2019-01-17  Tom Tromey  <tom@tromey.com>
2575
2576         * progspace.h (program_space) <objfiles_range>: New typedef.
2577         <objfiles>: New method.
2578         <objfiles_head>: Rename from objfiles.
2579         (object_files): Update.
2580         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
2581         * guile/scm-pretty-print.c
2582         (ppscm_find_pretty_printer_from_objfiles): Update.
2583         * guile/scm-objfile.c (gdbscm_objfiles): Update.
2584         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
2585         Update.
2586         * python/py-progspace.c (pspy_get_objfiles): Update.
2587         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2588         Update.
2589         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2590         (objfpy_lookup_objfile_by_build_id): Update.
2591         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2592         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2593         Update.
2594         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2595         (expand_symtab_containing_pc, lookup_objfile_from_block)
2596         (lookup_static_symbol, basic_lookup_transparent_type)
2597         (find_pc_sect_compunit_symtab, find_symbol_at_address)
2598         (find_line_symtab, info_sources_command)
2599         (default_collect_symbol_completion_matches_break_on)
2600         (make_source_files_completion_list, find_main_name): Update.
2601         * symmisc.c (print_symbol_bcache_statistics)
2602         (print_objfile_statistics, maintenance_print_symbols)
2603         (maintenance_print_msymbols, maintenance_print_objfiles)
2604         (maintenance_info_symtabs, maintenance_check_symtabs)
2605         (maintenance_expand_symtabs, maintenance_info_line_tables):
2606         Update.
2607         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
2608         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
2609         (map_overlay_command, unmap_overlay_command)
2610         (simple_overlay_update, expand_symtabs_matching)
2611         (map_symbol_filenames): Update.
2612         * symfile-debug.c (set_debug_symfile): Update.
2613         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
2614         Update.
2615         * source.c (select_source_symtab, forget_cached_source_info):
2616         Update.
2617         * solib.c (solib_read_symbols): Update.
2618         * solib-spu.c (append_ocl_sos): Update.
2619         * psymtab.c (maintenance_print_psymbols)
2620         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
2621         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
2622         * printcmd.c (info_symbol_command): Update.
2623         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
2624         Update.
2625         * objfiles.h (class all_objfiles): Remove.
2626         * objfiles.c (have_partial_symbols, have_full_symbols)
2627         (have_minimal_symbols, qsort_cmp, update_section_map)
2628         (shared_objfile_contains_address_p)
2629         (default_iterate_over_objfiles_in_search_order): Update.
2630         * objc-lang.c (info_selectors_command, info_classes_command)
2631         (find_methods): Update.
2632         * minsyms.c (find_solib_trampoline_target): Update.
2633         * maint.c (maintenance_info_sections)
2634         (maintenance_translate_address, count_symtabs_and_blocks):
2635         Update.
2636         * main.c (captured_main_1): Update.
2637         * linux-thread-db.c (try_thread_db_load_from_pdir)
2638         (has_libpthread): Update.
2639         * linespec.c (iterate_over_all_matching_symtabs)
2640         (search_minsyms_for_name): Update.
2641         * jit.c (jit_find_objf_with_entry_addr): Update.
2642         * hppa-tdep.c (find_unwind_entry)
2643         (hppa_lookup_stub_minimal_symbol): Update.
2644         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
2645         Update.
2646         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2647         (elf_gnu_ifunc_resolve_by_got): Update.
2648         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
2649         * dwarf-index-write.c (save_gdb_index_command): Update.
2650         * cp-support.c (add_symbol_overload_list_qualified): Update.
2651         * breakpoint.c (create_overlay_event_breakpoint)
2652         (create_longjmp_master_breakpoint)
2653         (create_std_terminate_master_breakpoint)
2654         (create_exception_master_breakpoint): Update.
2655         * blockframe.c (find_pc_partial_function): Update.
2656         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
2657         (ada_collect_symbol_completion_matches)
2658         (ada_add_global_exceptions): Update.
2659
2660 2019-01-17  Tom Tromey  <tom@tromey.com>
2661
2662         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
2663         declare VEC.
2664         (solib_target_parse_libraries): Change return type.
2665         (library_list_start_segment, library_list_start_section)
2666         (library_list_end_library, library_list_start_library); Update.
2667         (solib_target_free_library_list): Remove.
2668         (solib_target_parse_libraries): Remove cleanup.  Change return
2669         type.
2670         (solib_target_current_sos): Update.
2671
2672 2019-01-17  Tom Tromey  <tromey@bapiya>
2673
2674         * valprint.c: Replace "the the" with "the".
2675         * symtab.c: Replace "the the" with "the".
2676         * solib.c: Replace "the the" with "the".
2677         * solib-dsbt.c: Replace "the the" with "the".
2678         * linespec.c: Replace "the the" with "the".
2679         * dwarf2loc.h: Replace "the the" with "the".
2680         * amd64-windows-tdep.c: Replace "the the" with "the".
2681         * aarch64-tdep.c: Replace "the the" with "the".
2682
2683 2019-01-16  Keith Seitz  <keiths@redhat.com>
2684
2685         PR gdb/23773
2686         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
2687         <builder>: Rename to ..
2688         <m_builder>: ... this and make private.
2689         (dwarf2_cu::get_builder): New method.  Change all users of
2690         `builder' to use this method.
2691         (dwarf2_start_symtab): Move to ...
2692         (dwarf2_cu::start_symtab): ... here.  Update all callers
2693         (setup_type_unit_groups): Move to ...
2694         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
2695         callers.
2696         (dwarf2_cu::reset_builder): New method.
2697         (process_full_compunit, process_full_type_unit): Use
2698         dwarf2_cu::reset_builder.
2699         (follow_die_offset): Record the ancestor CU if it is different
2700         from the followed DIE's CU.
2701         (follow_die_sig_1): Likewise.
2702
2703 2019-01-15  Tom Tromey  <tom@tromey.com>
2704
2705         * remote.c (class remote_state) <buf>: Now a char_vector.
2706         <buf_size>: Remove.
2707         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
2708         parameter.
2709         (remote_target::getpkt_or_notif_sane_1)
2710         (remote_target::getpkt_sane)
2711         (remote_target::getpkt_or_notif_sane): Likewise.
2712         (class remote_target) <putpkt>: New overload.
2713         (remote_target::read_frame): Change type of "buf_p".  Remove
2714         sizeof_p parameter.
2715         (packet_ok): New overload.
2716         (packet_check_result): New overload.
2717         Update all uses.
2718
2719 2019-01-14  Tom Tromey  <tom@tromey.com>
2720
2721         * remote-notif.c (handle_notification, remote_notif_ack)
2722         (remote_notif_parse): Make "buf" const.
2723         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
2724         const.
2725         (remote_notif_parse, remote_notif_ack, handle_notification):
2726         Likewise.
2727         * remote.c (remote_notif_stop_parse): Make "buf" const.
2728         (remote_target::remote_parse_stop_reply): Make "buf" const.
2729         (remote_notif_stop_ack): Make "buf" const.
2730
2731 2019-01-14  Tom Tromey  <tom@tromey.com>
2732
2733         * remote.c (remote_console_output): Make parameter const.
2734
2735 2019-01-14  Tom Tromey  <tom@tromey.com>
2736
2737         * target-debug.h (target_debug_print_signals): Constify.
2738         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
2739         * procfs.c (procfs_target::pass_signals): Update.
2740         * linux-nat.c (linux_nat_target::pass_signals): Update.
2741         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
2742         * target-delegates.c: Rebuild.
2743         * remote.c (remote_target::program_signals): Update.
2744         (remote_target::pass_signals): Update.
2745         * target.c (target_pass_signals): Constify argument.
2746         (target_program_signals): Likewise.
2747         * target.h (struct target_ops) <pass_signals, program_signals>:
2748         Constify argument.
2749         (target_pass_signals, target_program_signals): Constify argument.
2750
2751 2019-01-14  Tom Tromey  <tom@tromey.com>
2752
2753         PR tui/28819:
2754         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
2755
2756 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2757
2758         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
2759         field.
2760         * rs6000-tdep.c: Include reggroups.h.
2761         (IS_V_ALIAS_PSEUDOREG): Define.
2762         (rs6000_register_name): Return names for the "vX" aliases.
2763         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
2764         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
2765         aliases.  Call default_register_reggroup_p for all other
2766         pseudo-registers.
2767         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
2768         New functions.
2769         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
2770         Handle "vX" aliases.
2771         (v_alias_pseudo_register_collect): New function.
2772         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
2773         (rs6000_gdbarch_init): Initialize "vX" aliases as
2774         pseudo-registers.  Restore registration of
2775         rs6000_pseudo_register_reggroup_p with
2776         set_tdesc_pseudo_register_reggroup_p.
2777
2778 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
2779
2780         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
2781         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
2782         set_gdbarch_num_pseudo_regs.
2783
2784 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2785
2786         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
2787         Remove arg prefixname, add do_set and do_show.
2788         Add member functions set_list and show_list.
2789         * cli/cli-style.c (class cli_style_option): Update accordingly.
2790         (style_set_list): Move to file scope.
2791         (style_show_list): Likewise.
2792         (set_style): Call help_list.
2793         (show_style): Call cmd_show_list.
2794         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
2795         Update to use the new macro.
2796
2797 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
2798
2799         * ada-lang.c (_initialize_ada_language): Expand the help text
2800         for the "catch exception" command.
2801
2802 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2803
2804         * symtab.c (matching_obj_sections): Initialize obj,
2805         declare it closer to its usage.
2806
2807 2019-01-10  Tom Tromey  <tom@tromey.com>
2808
2809         * thread-iter.h (inf_threads_iterator): Use next_iterator.
2810         (basic_inf_threads_range): Remove.
2811         (inf_threads_range, inf_non_exited_threads_range)
2812         (safe_inf_threads_range): Use next_adapter.
2813
2814 2019-01-10  Keith Seitz  <keiths@redhat.com>
2815
2816         PR gdb/23712
2817         PR symtab/23010
2818         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
2819         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
2820
2821 2019-01-10  Keith Seitz  <keiths@redhat.com>
2822
2823         PR gdb/23712
2824         PR symtab/23010
2825         * dictionary.c (pending_to_vector): Remove.
2826         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2827         Remove _1 suffix, replacing functions of the same name.  Update
2828         all callers.
2829         (dict_create_hashed, dict_create_hashed_expandable)
2830         (dict_create_linear, dict_create_linear_expandable, dict_free)
2831         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
2832         Make functions static.
2833
2834 2019-01-10  Keith Seitz  <keiths@redhat.com>
2835
2836         PR gdb/23712
2837         PR symtab/23010
2838         * dictionary.h (struct dictionary): Replace declaration with
2839         multidictionary.
2840         (dict_create_hashed, dict_create_hashed_expandable)
2841         (dict_create_linear, dict_create_linear_expandable)
2842         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
2843         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
2844         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
2845         taking multidictionary argument.
2846         [ALL_DICT_SYMBOLS]: Update for multidictionary.
2847         * block.h (struct block) <dict>: Change to multidictionary
2848         and rename `multidict'.
2849         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
2850         symmisc.c: Update all dictionary references to multidictionary.
2851
2852 2019-01-10  Keith Seitz  <keiths@redhat.com>
2853
2854         PR gdb/23712
2855         PR symtab/23010
2856         * dictionary.c: Include unordered_map.
2857         (pending_to_vector): New function.
2858         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2859         Rewrite the non-"_1" functions to take vector instead
2860         of linked list.
2861         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
2862         "new" _1 versions of the same name.
2863         (multidictionary): Define.
2864         (std::hash<enum language): New definition.
2865         (collate_pending_symbols_by_language, mdict_create_hashed)
2866         (mdict_create_hashed_expandable, mdict_create_linear)
2867         (mdict_create_linear_expandable, mdict_free)
2868         (find_language_dictionary, create_new_language_dictionary)
2869         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
2870         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
2871         (mdict_size, mdict_empty): New functions.
2872         * dictionary.h (mdict_iterator): Define.
2873
2874 2019-01-10  Pedro Alves  <palves@redhat.com>
2875
2876         * breakpoint.c (read_uploaded_action)
2877         (create_tracepoint_from_upload): Adjust to use
2878         gdb::unique_xmalloc_ptr.
2879         * ctf.c (ctf_write_uploaded_tp):
2880         (SET_ARRAY_FIELD): Use emplace_back.
2881         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
2882         * tracefile-tfile.c (tfile_write_uploaded_tp):
2883         * tracepoint.c (parse_tracepoint_definition): Adjust to use
2884         gdb::unique_xmalloc_ptr.
2885         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
2886         at_string, cond_string, cmd_strings>: Replace char pointers
2887         with gdb::unique_xmalloc_ptr.
2888
2889 2019-01-10  Pedro Alves  <palves@redhat.com>
2890
2891         * solib-target.c (library_list_start_library): Don't xstrdup name.
2892
2893 2019-01-10  Pedro Alves  <palves@redhat.com>
2894
2895         * mdebugread.c (parse_partial_symbols): Use
2896         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
2897
2898 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2899
2900         * linux-fork.c (scoped_switch_fork_info)
2901         <~scoped_switch_fork_info>: Fix incorrect variable name.
2902
2903 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2904
2905         * linux-fork.c (scoped_switch_fork_info)
2906         <scoped_switch_fork_info>: Make explicit.
2907         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
2908
2909 2019-01-10  Tom Tromey  <tom@tromey.com>
2910
2911         * objfiles.h (objfile::reset_psymtabs): Update.
2912         * objfiles.c (objfile::objfile): Update.
2913         * psymtab.h (psymtab_storage::obstack): Update.
2914         (psymtab_storage::m_obstack): Use gdb::optional.
2915         (class psymtab_storage): Update comment.  Remove objfile
2916         parameter.
2917         * psymtab.c (psymtab_storage::psymtab_storage): Update.
2918
2919 2019-01-10  Tom Tromey  <tom@tromey.com>
2920
2921         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
2922         <free_psymtabs>: Now private.
2923         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
2924         (allocate_psymtab): Use new method.
2925
2926 2019-01-10  Tom Tromey  <tom@tromey.com>
2927
2928         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
2929         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
2930         * mdebugread.c (parse_partial_symbols): Use
2931         allocate_dependencies.
2932         * dwarf2read.c (dwarf2_create_include_psymtab): Use
2933         allocate_dependencies.
2934         (process_psymtab_comp_unit_reader)
2935         (build_type_psymtab_dependencies): Likewise.
2936         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
2937
2938 2019-01-10  Tom Tromey  <tom@tromey.com>
2939
2940         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
2941         PSYMBOL_SET_LANGUAGE.
2942         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
2943
2944 2019-01-10  Tom Tromey  <tom@tromey.com>
2945
2946         * psymtab.h (psymtab_storage::obstack): New method.
2947         <m_obstack>: Rename from obstack; now private.
2948         * psymtab.c (psymtab_storage): Update.
2949         * dwarf2read.c (create_addrmap_from_index)
2950         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
2951         Update.
2952
2953 2019-01-10  Tom Tromey  <tom@tromey.com>
2954
2955         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
2956         * objfiles.h (objfile::reset_psymtabs): New method.
2957
2958 2019-01-10  Tom Tromey  <tom@tromey.com>
2959
2960         * symmisc.c (print_symbol_bcache_statistics): Update.
2961         (print_objfile_statistics): Update.
2962         * symfile.c (reread_symbols): Update.
2963         * psymtab.h (class psymtab_storage): New.
2964         * psymtab.c (psymtab_storage): New constructor.
2965         (~psymtab_storage): New destructor.
2966         (require_partial_symbols): Update.
2967         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
2968         (find_pc_sect_psymtab, find_pc_sect_psymbol)
2969         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
2970         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
2971         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
2972         (start_psymtab_common, end_psymtab_common)
2973         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
2974         (allocate_psymtab): Update.
2975         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
2976         Update.
2977         (dump_psymtab_addrmap, maintenance_print_psymbols)
2978         (maintenance_check_psymtabs): Update.
2979         (class objfile_psymtabs): Move to objfiles.h.
2980         * psympriv.h (discard_psymtab): Now inline.
2981         (psymtab_discarder::psymtab_discarder): Update.
2982         (psymtab_discarder::~psymtab_discarder): Update.
2983         (ALL_OBJFILE_PSYMTABS): Rewrite.
2984         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
2985         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
2986         Remove fields.
2987         <partial_symtabs>: New field.
2988         (class objfile_psymtabs): Move from psymtab.h.  Update.
2989         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
2990         psymbol_cache.
2991         (objfile::~objfile): Don't destroy psymbol_cache.
2992         * mdebugread.c (parse_partial_symbols): Update.
2993         * dwarf2read.c (create_addrmap_from_index)
2994         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
2995         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
2996         (add_partial_subprogram, dwarf2_ranges_read): Update.
2997         * dwarf-index-write.c (write_address_map)
2998         (write_one_signatured_type, recursively_write_psymbols)
2999         (class debug_names, class debug_names, write_psymtabs_to_index):
3000         Update.
3001
3002 2019-01-10  Tom Tromey  <tom@tromey.com>
3003
3004         * symtab.h (SYMBOL_SET_NAMES): Update.
3005         (symbol_set_names): Update.
3006         (MSYMBOL_SET_NAMES): Update.
3007         * symtab.c (symbol_set_names): Change argument to be an
3008         objfile_per_bfd_storage.
3009         * psymtab.c (add_psymbol_to_bcache): Update.
3010         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
3011
3012 2019-01-10  Tom Tromey  <tom@tromey.com>
3013
3014         * symtab.c (create_demangled_names_hash): Change argument to be an
3015         objfile_per_bfd_storage.
3016         (symbol_set_names): Update.
3017
3018 2019-01-10  Tom Tromey  <tom@tromey.com>
3019
3020         * xcoffread.c (xcoff_initial_scan): Unconditionally call
3021         init_psymbol_list.
3022         * psymtab.c (init_psymbol_list): Do nothing if already called.
3023         * psympriv.h (init_psymbol_list): Add comment.
3024         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
3025         init_psymbol_list.
3026         * dbxread.c (dbx_symfile_read): Unconditionally call
3027         init_psymbol_list.
3028
3029 2019-01-10  Tom Tromey  <tom@tromey.com>
3030
3031         * xcoffread.c (scan_xcoff_symtab): Update.
3032         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
3033         "where".
3034         * mdebugread.c (parse_partial_symbols)
3035         (handle_psymbol_enumerators): Update.
3036         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
3037         * dbxread.c (read_dbx_symtab): Update.
3038         * psympriv.h (psymbol_placement): New enum.
3039         (add_psymbol_to_list): Update.
3040
3041 2019-01-10  Tom Tromey  <tom@tromey.com>
3042
3043         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
3044         static_psymbols parameters.
3045         (scan_xcoff_symtab): Update.
3046         * psymtab.c (start_psymtab_common): Remove global_psymbols and
3047         static_psymbols parameters.
3048         * psympriv.h (start_psymtab_common): Update.
3049         * mdebugread.c (parse_partial_symbols): Update.
3050         * dwarf2read.c (create_partial_symtab): Update.
3051         * dbxread.c (read_dbx_symtab): Update.
3052         (start_psymtab): Remove global_psymbols and static_psymbols
3053         parameters.
3054
3055 2019-01-10  Tom Tromey  <tom@tromey.com>
3056
3057         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
3058         * psymtab.c (allocate_psymtab): Add comment.
3059         * psympriv.h (allocate_psymtab): Add comment.
3060         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
3061         initializations.
3062         * dbxread.c (dbx_end_psymtab): Remove some initializations.
3063
3064 2019-01-10  Tom Tromey  <tom@tromey.com>
3065
3066         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3067         Don't declare.
3068         * mipsread.c: Include mdebugread.h.
3069         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3070         Declare.
3071         * elfread.c: Include mdebugread.h.
3072
3073 2019-01-09  Tom Tromey  <tom@tromey.com>
3074
3075         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
3076         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
3077         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
3078         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
3079         (psym_lookup_symbol, psym_find_last_source_symtab)
3080         (psym_forget_cached_source_info, psym_print_stats)
3081         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
3082         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
3083         (psym_map_matching_symbols, psym_expand_symtabs_matching)
3084         (psym_find_compunit_symtab_by_address)
3085         (maintenance_print_psymbols, maintenance_info_psymtabs)
3086         (maintenance_check_psymtabs): Use ranged for.
3087         * psymtab.h (class objfile_psymtabs): New.
3088         (require_partial_symbols): Return objfile_psymtabs.
3089         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
3090
3091 2019-01-09  Tom Tromey  <tom@tromey.com>
3092
3093         * symfile.c (overlay_invalidate_all, find_pc_overlay)
3094         (find_pc_mapped_section, list_overlays_command)
3095         (map_overlay_command, unmap_overlay_command)
3096         (simple_overlay_update): Use all_objfiles.
3097         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
3098         * printcmd.c (info_symbol_command): Use all_objfiles.
3099         * objfiles.h (ALL_OBJSECTIONS): Remove.
3100         * maint.c (maintenance_translate_address): Use all_objfiles.
3101         * gcore.c (gcore_create_callback): Use all_objfiles.
3102         (objfile_find_memory_regions): Likewise.
3103
3104 2019-01-09  Tom Tromey  <tom@tromey.com>
3105
3106         * symtab.c (find_line_symtab, info_sources_command)
3107         (make_source_files_completion_list): Use objfile_compunits.
3108         * source.c (select_source_symtab): Use objfile_compunits.
3109         * objfiles.h (struct objfile): Update comment.
3110         (ALL_OBJFILES): Remove.
3111         (ALL_FILETABS): Remove.
3112         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
3113         objfile_compunits.
3114
3115 2019-01-09  Tom Tromey  <tom@tromey.com>
3116
3117         * symmisc.c (print_objfile_statistics, dump_objfile)
3118         (maintenance_print_symbols): Use compunit_filetabs.
3119         * source.c (forget_cached_source_info_for_objfile): Use
3120         compunit_filetabs.
3121         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
3122         (ALL_FILETABS): Use compunit_filetabs.
3123         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
3124         * coffread.c (coff_symtab_read): Use compunit_filetabs.
3125
3126 2019-01-09  Tom Tromey  <tom@tromey.com>
3127
3128         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
3129         (compunit_filetabs): New.
3130         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
3131         compunit_filetabs.
3132         (info_sources_command, make_source_files_completion_list): Remove
3133         declaration.
3134         * symmisc.c (print_objfile_statistics, dump_objfile)
3135         (maintenance_print_symbols): Remove declaration.
3136         (maintenance_info_symtabs): Use compunit_filetabs.
3137         (maintenance_info_line_tables): Likewise.
3138         * source.c (select_source_symtab): Change local variable name.
3139         (forget_cached_source_info_for_objfile): Remove declaration.
3140         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
3141         * objfiles.c (objfile_relocate1): Remove declaration.
3142         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3143         declaration.
3144         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
3145         * coffread.c (coff_symtab_read): Remove declaration.
3146         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3147         compunit_filetabs.
3148
3149 2019-01-09  Tom Tromey  <tom@tromey.com>
3150
3151         * symtab.c (lookup_objfile_from_block)
3152         (find_pc_sect_compunit_symtab, search_symbols)
3153         (default_collect_symbol_completion_matches_break_on): Use
3154         objfile_compunits.
3155         * objfiles.h (ALL_COMPUNITS): Remove.
3156         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
3157         * cp-support.c (add_symbol_overload_list_qualified): Use
3158         objfile_compunits.
3159         * ada-lang.c (ada_collect_symbol_completion_matches)
3160         (ada_add_global_exceptions): Use objfile_compunits.
3161
3162 2019-01-09  Tom Tromey  <tom@tromey.com>
3163
3164         * source.c (select_source_symtab)
3165         (forget_cached_source_info_for_objfile): Remove declaration.
3166         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3167         declaration.
3168         * maint.c (count_symtabs_and_blocks): Remove declaration.
3169         * cp-support.c (add_symbol_overload_list_qualified): Remove
3170         declaration.
3171         * coffread.c (coff_symtab_read): Remove declaration.
3172         * symtab.c (lookup_symbol_in_objfile_symtabs)
3173         (basic_lookup_transparent_type_1): Use objfile_compunits.
3174         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
3175         (info_sources_command, search_symbols)
3176         (default_collect_symbol_completion_matches_break_on)
3177         (make_source_files_completion_list): Remove declaration.
3178         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
3179         (ada_collect_symbol_completion_matches)
3180         (ada_add_global_exceptions): Remove declaration.
3181         * linespec.c (iterate_over_all_matching_symtabs): Use
3182         objfile_compunits.
3183         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
3184         (class objfile_compunits): New.
3185         (ALL_COMPUNITS): Use objfile_compunits.
3186         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
3187         (maintenance_check_symtabs, maintenance_info_line_tables): Use
3188         objfile_compunits.
3189         * objfiles.c (objfile_relocate1): Use objfile_compunits.
3190
3191 2019-01-09  Tom Tromey  <tom@tromey.com>
3192
3193         * symtab.c (search_symbols)
3194         (default_collect_symbol_completion_matches_break_on): Use
3195         objfile_msymbols.
3196         * ada-lang.c (ada_lookup_simple_minsym)
3197         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
3198         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
3199         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
3200         objfile_msymbols.
3201         * coffread.c (coff_symfile_read): Use objfile_msymbols.
3202         * symmisc.c (dump_msymbols): Use objfile_msymbols.
3203         * objc-lang.c (find_methods): Use objfile_msymbols.
3204         (info_selectors_command, info_classes_command): Likewise.
3205         * stabsread.c (scan_file_globals): Use objfile_msymbols.
3206         * objfiles.h (class objfile_msymbols): New.
3207         (ALL_OBJFILE_MSYMBOLS): Remove.
3208         (ALL_MSYMBOLS): Remove.
3209
3210 2019-01-09  Tom Tromey  <tom@tromey.com>
3211
3212         * common/next-iterator.h (next_adapter): Add Iterator template
3213         parameter.
3214         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3215         (class all_objfiles_safe): New.
3216         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3217         * objfiles.c (put_objfile_before): Update comment.
3218         (add_separate_debug_objfile): Likewise.
3219         (free_all_objfiles): Use all_objfiles_safe.
3220         (objfile_purge_solibs): Likewise.
3221
3222 2019-01-09  Tom Tromey  <tom@tromey.com>
3223
3224         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3225         (expand_symtab_containing_pc, lookup_static_symbol)
3226         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3227         (find_symbol_at_address, find_line_symtab, find_main_name): Use
3228         all_objfiles.
3229         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3230         * breakpoint.c (create_overlay_event_breakpoint)
3231         (create_longjmp_master_breakpoint)
3232         (create_std_terminate_master_breakpoint)
3233         (create_exception_master_breakpoint): Use all_objfiles.
3234         * linux-thread-db.c (try_thread_db_load_from_pdir)
3235         (has_libpthread): Use all_objfiles.
3236         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3237         * linespec.c (iterate_over_all_matching_symtabs)
3238         (search_minsyms_for_name): Use all_objfiles.
3239         * maint.c (maintenance_info_sections): Use all_objfiles.
3240         * main.c (captured_main_1): Use all_objfiles.
3241         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3242         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3243         * guile/scm-pretty-print.c
3244         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3245         * solib-spu.c (append_ocl_sos): Use all_objfiles.
3246         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3247         (maintenance_print_msymbols): Use all_objfiles.
3248         * source.c (select_source_symtab): Use all_objfiles.
3249         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3250         * symfile.c (remove_symbol_file_command)
3251         (expand_symtabs_matching, map_symbol_filenames): Use
3252         all_objfiles.
3253         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3254         all_objfiles.
3255         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3256         * objc-lang.c (find_methods): Use all_objfiles.
3257         * objfiles.c (have_partial_symbols, have_full_symbols)
3258         (have_minimal_symbols, qsort_cmp)
3259         (default_iterate_over_objfiles_in_search_order): Use
3260         all_objfiles.
3261         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3262         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3263         (maintenance_check_psymtabs): Use all_objfiles.
3264         (ALL_PSYMTABS): Remove.
3265         * compile/compile-object-run.c (do_module_cleanup): Use
3266         all_objfiles.
3267         * blockframe.c (find_pc_partial_function): Use all_objfiles.
3268         * cp-support.c (add_symbol_overload_list_qualified): Use
3269         all_objfiles.
3270         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3271         Use all_objfiles.
3272         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3273         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3274         all_objfiles.
3275         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3276         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
3277         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3278         Uses all_objfiles.
3279         * solib.c (solib_read_symbols): Use all_objfiles
3280
3281 2019-01-09  Tom Tromey  <tom@tromey.com>
3282
3283         * probe.c (parse_probes_in_pspace): Use all_objfiles.
3284         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
3285         all_objfiles.
3286         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
3287         * symmisc.c (print_symbol_bcache_statistics)
3288         (print_objfile_statistics, maintenance_print_objfiles)
3289         (maintenance_info_symtabs, maintenance_check_symtabs)
3290         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
3291         all_objfiles.
3292         * source.c (forget_cached_source_info): Use all_objfiles.
3293         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
3294         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3295         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
3296         * objfiles.c (update_section_map): Use all_objfiles.
3297         (shared_objfile_contains_address_p): Likewise.
3298         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
3299         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
3300
3301 2019-01-09  Tom Tromey  <tom@tromey.com>
3302
3303         * common/next-iterator.h: New file.
3304         * objfiles.h (class all_objfiles): New.
3305         (struct objfile_iterator): New.
3306
3307 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3308
3309         * NEWS: Move the description of the changed "frame", "select-frame",
3310          and "info frame" commands to the Changed commands section.
3311
3312 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
3313
3314         * gdbtypes.c (check_stub_method_group): Remove handling of old
3315         mangling schemes.
3316         * linespec.c (find_methods): Likewise.
3317         * stabsread.c (read_member_functions): Likewise.
3318         * valops.c (search_struct_method): Likewise.
3319         (value_struct_elt_for_reference): Likewise.
3320         * NEWS: Mention this change.
3321
3322 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3323
3324         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
3325         print_source_lines.
3326         * source.c (print_source_lines_base): Update line number check.
3327         (print_source_lines): New function.
3328         (source_lines_range::source_lines_range): New function.
3329         * source.h (class source_lines_range): New class.
3330         (print_source_lines): New declaration.
3331
3332 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3333
3334         * linespec.c (linespec_state_destructor): Free self->canonical_names.
3335
3336 2019-01-08  Tom Tromey  <tom@tromey.com>
3337             Simon Marchi  <simon.marchi@ericsson.com>
3338
3339         PR gdb/24060
3340         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
3341         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
3342         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3343         * f-exp.y (DOLLAR_VARIABLE): Likewise.
3344         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
3345         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3346
3347 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3348
3349         * source.c (select_source_symtab): Move header comment to
3350         declaration in source.h.
3351         (forget_cached_source_info_for_objfile): Likewise.
3352         (forget_cached_source_info): Likewise.
3353         (identify_source_line): Likewise.
3354         * source.h (identify_source_line): Move declaration from symtab.h
3355         and add comment from source.c
3356         (print_source_lines): Likewise.
3357         (forget_cached_source_info_for_objfile): Likewise.
3358         (forget_cached_source_info): Likewise.
3359         (select_source_symtab): Likewise.
3360         (enum print_source_lines_flag): Move definition from symtab.h.
3361         * symtab.h (identify_source_line): Move declaration to source.h.
3362         (print_source_lines): Likewise.
3363         (forget_cached_source_info_for_objfile): Likewise.
3364         (forget_cached_source_info): Likewise.
3365         (select_source_symtab): Likewise.
3366         (enum print_source_lines_flag): Move definition to source.h.
3367         * tui/tui-hooks.c: Add 'source.h' include.
3368
3369 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3370
3371         * source.c (print_source_lines_base): Handle requests to print
3372         reverse line number sequences, and guard against empty lines
3373         string.
3374
3375 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3376
3377         * source.c (print_source_lines_base): Fix skip of '\r' if next
3378         character is '\n'.
3379
3380 2019-01-06  Tom Tromey  <tom@tromey.com>
3381
3382         * c-exp.y (struct c_parse_state) <macro_original_text,
3383         expansion_obstack>: New member.
3384         (macro_original_text, expansion_obstack): Remove globals.
3385         (scan_macro_expansion, scanning_macro_expansion)
3386         (finished_macro_expansion): Update.
3387         (scan_macro_cleanup): Remove.
3388         (yylex, c_parse): Update.
3389
3390 2019-01-06  Tom Tromey  <tom@tromey.com>
3391
3392         * c-exp.y (struct c_parse_state) <strings>: New member.
3393         (operator_stoken): Update.
3394
3395 2019-01-06  Tom Tromey  <tom@tromey.com>
3396
3397         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
3398         (union type_stack_elt) <typelist_val>: Now a pointer to
3399         std::vector.
3400         (type_stack_cleanup): Don't declare.
3401         (push_typelist): Update.
3402         * parse.c (pop_typelist): Return a std::vector.
3403         (push_typelist): Take a std::vector.
3404         (follow_types): Update.  Do not free args.
3405         (type_stack_cleanup): Remove.
3406         * c-exp.y (struct c_parse_state): New.
3407         (cpstate): New global.
3408         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
3409         (nonempty_typelist): Update.
3410         (func_mod): Create a new vector.
3411         (c_parse): Create a c_parse_state.
3412         (check_parameter_typelist): Do not delete params.
3413         (function_method): Update.  Do not delete type_list.
3414
3415 2019-01-06  Tom Tromey  <tom@tromey.com>
3416
3417         PR gdb/28155:
3418         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
3419         check_typedef.
3420         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
3421         (print_return_value): Likewise.
3422
3423 2019-01-05  Tom Tromey  <tom@tromey.com>
3424
3425         * contrib/cleanup_check.py: Remove.
3426         * contrib/gcc-with-excheck: Remove.
3427         * contrib/exsummary.py: Remove.
3428         * contrib/excheck.py: Remove.
3429
3430 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
3431
3432         * thread.c (delete_thread_1): Add gdb_assert that THR is not
3433         NULL. Initialize tpprev to NULL instead of assigning it
3434         to NULL on the next statement.
3435         * windows-nat.c (windows_delete_thread): Remove check for
3436         main_thread_id before printing thread exit notifications.
3437         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
3438         Remove thread ID check against main_thread_id.
3439         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
3440         windows_delete_thread.
3441         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
3442
3443 2019-01-04  Tom Tromey  <tom@tromey.com>
3444
3445         * compile/compile.c (_initialize_compile): Use upper case for
3446         metasyntactic variables.
3447         * symmisc.c (_initialize_symmisc): Use upper case for
3448         metasyntactic variables.
3449         * psymtab.c (_initialize_psymtab): Use upper case for
3450         metasyntactic variables.
3451         * demangle.c (demangle_command): Use upper case for metasyntactic
3452         variables.
3453         (_initialize_demangler): Likewise.
3454         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3455         variables.
3456
3457 2019-01-03  Tom Tromey  <tom@tromey.com>
3458
3459         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3460
3461 2019-01-03  Tom Tromey  <tom@tromey.com>
3462
3463         * python/py-symtab.c (salpy_str): Update.
3464         (struct salpy_sal_object) <symtab>: Now a PyObject.
3465         (salpy_dealloc): Update.
3466         (del_objfile_sal): Use gdbpy_ref.
3467
3468 2019-01-03  Tom Tromey  <tom@tromey.com>
3469
3470         * python/py-type.c (convert_field): Use new_reference.  Return
3471         gdbpy_ref.
3472         (make_fielditem): Return gdbpy_ref.
3473         (typy_fields): Update.
3474         (typy_getitem): Update.
3475         (field_name): Return gdbpy_ref.  Use new_reference.
3476         (typy_iterator_iternext): Update.
3477
3478 2019-01-03  Tom Tromey  <tom@tromey.com>
3479
3480         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3481
3482 2019-01-03  Tom Tromey  <tom@tromey.com>
3483
3484         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3485         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3486         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3487         (pspy_set_frame_filters, pspy_set_frame_unwinders)
3488         (pspy_set_type_printers): Likewise.
3489         * python/py-function.c (fnpy_init): Use gdbpy_ref.
3490         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3491         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3492         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
3493         (objfpy_set_type_printers): Likewise.
3494
3495 2019-01-03  Tom Tromey  <tom@tromey.com>
3496
3497         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
3498         (gdbpy_print_stack): Use gdbpy_err_fetch.
3499         * python/python-internal.h (class gdbpy_err_fetch): New class.
3500         (class gdbpy_enter) <m_error_type, m_error_value,
3501         m_error_traceback>: Remove.
3502         <m_error>: New member.
3503         (gdbpy_exception_to_string): Don't declare.
3504         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
3505         * python/py-value.c (convert_value_from_python): Use
3506         gdbpy_err_fetch.
3507         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
3508         gdbpy_exception_to_string.
3509         (gdbpy_handle_exception): Use gdbpy_err_fetch.
3510         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3511         gdbpy_err_fetch.
3512
3513 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3514
3515         * linux-nat.c (delete_lwp_cleanup): Delete.
3516         (struct lwp_deleter): New struct.
3517         (lwp_info_up): New typedef.
3518         (linux_nat_target::follow_fork): Delete cleanup, and make use of
3519         lwp_info_up.
3520
3521 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3522
3523         * linux-fork.c (class scoped_switch_fork_info): New class.
3524         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3525
3526 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3527
3528         * valops.c (find_overload_match): Remove use of null_cleanup, and
3529         calls to do_cleanups.
3530
3531 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3532
3533         * compile/compile-cplus-types.c
3534         (compile_cplus_instance::decl_name): Handle changes to
3535         cp_func_name.
3536         * cp-support.c (cp_func_name): Update header comment, update
3537         return type.
3538         * cp-support.h (cp_func_name): Update return type in declaration.
3539         * valops.c (find_overload_match): Move temp_func local to top
3540         level of function and change its type.  Use temp_func to hold and
3541         delete temporary string obtained from cp_func_name.
3542
3543 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3544
3545         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3546         gdb::char_vector, remove cleanup, and update uses of `msg`.
3547
3548 2019-01-03  Jim Wilson  <jimw@sifive.com>
3549
3550         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3551
3552 2019-01-02  Tom Tromey  <tom@tromey.com>
3553
3554         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3555         (tdesc_parse_xml): Remove cleanups.
3556         * target-descriptions.h (make_cleanup_free_target_description):
3557         Don't declare.
3558         (target_desc_deleter): New struct.
3559         (target_desc_up): New typedef.
3560         * target-descriptions.c (target_desc_deleter::operator()): Rename
3561         from free_target_description.
3562         (make_cleanup_free_target_description): Remove.
3563
3564 2019-01-02  Tom Tromey  <tom@tromey.com>
3565
3566         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
3567         constructor, destructor.
3568         (linespec_parser): Remove typedef.
3569         (~linespec_parser): Rename from linespec_parser_delete.
3570         (linespec_lex_to_end, linespec_complete_label)
3571         (linespec_complete): Update.
3572         (decode_line_full): Remove cleanups.
3573         (decode_line_1): Update.
3574
3575 2019-01-02  Tom Tromey  <tom@tromey.com>
3576
3577         * python/python-internal.h (inferior_to_inferior_object): Change
3578         return type.
3579         * python/py-exitedevent.c (create_exited_event_object): Update.
3580         * python/py-inferior.c (inferior_to_inferior_object): Return
3581         gdbpy_ref.
3582         (python_new_inferior, python_inferior_deleted)
3583         (thread_to_thread_object, delete_thread_object)
3584         (build_inferior_list, gdbpy_selected_inferior): Update.
3585         * python/py-infthread.c (create_thread_object): Update.  Also fail
3586         if inferior_to_inferior_object fails.
3587
3588 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
3589
3590         * inferior.h (class inferior) <displaced_step_state>: New field.
3591         * infrun.h (struct displaced_step_state): Move here from
3592         infrun.c.  Initialize fields, add constructor.
3593         <inf>: Remove field.
3594         <reset>: New method.
3595         * infrun.c (struct displaced_step_inferior_state): Move to
3596         infrun.h.
3597         (displaced_step_inferior_states): Remove.
3598         (get_displaced_stepping_state): Adust.
3599         (displaced_step_in_progress_any_inferior): Adjust.
3600         (displaced_step_in_progress_thread): Adjust.
3601         (displaced_step_in_progress): Adjust.
3602         (add_displaced_stepping_state): Remove.
3603         (get_displaced_step_closure_by_addr): Adjust.
3604         (remove_displaced_stepping_state): Remove.
3605         (infrun_inferior_exit): Call displaced_step_state.reset.
3606         (use_displaced_stepping): Don't check for NULL.
3607         (displaced_step_prepare_throw): Call
3608         get_displaced_stepping_state.
3609         (displaced_step_fixup): Don't check for NULL.
3610         (prepare_for_detach): Don't check for NULL.
3611
3612 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3613
3614         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
3615          in case of call that did not complete.
3616
3617 2019-01-02  Andrey Utkin  <autkin@undo.io>
3618
3619         * symfile.c (find_separate_debug_file): Fix search of debug files for
3620         remote debuggee.
3621
3622 2019-01-02  Tom Tromey  <tom@tromey.com>
3623
3624         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
3625         indentation.
3626         * python/py-frame.c (frapy_older): Remove cast.
3627         (frapy_newer): Likewise.
3628         * python/py-breakpoint.c (local_setattro): Remove cast.
3629         * python/py-arch.c (archpy_name): Remove local variable.
3630         * python/py-type.c (gdbpy_lookup_type): Remove cast.
3631
3632 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
3633
3634         * unittests/basic_string_view/element_access/char/empty.cc:
3635         Fix year range in copyright header.
3636
3637 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3638
3639         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
3640         Delete.
3641         <operator==>: Update with for removed field.
3642         <hash>: Likewise.
3643         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
3644         <isa_features>: ...this.
3645         <abi_features>: New field.
3646         (riscv_isa_flen): Update comment.
3647         (riscv_abi_xlen): New declaration.
3648         (riscv_abi_flen): New declaration.
3649         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
3650         isa_features.
3651         (riscv_abi_xlen): New function.
3652         (riscv_isa_flen): Update to get answer from isa_features.
3653         (riscv_abi_flen): New function.
3654         (riscv_has_fp_abi): Update to get answer from abi_features.
3655         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
3656         xlen and flen.
3657         (riscv_call_info) <xlen, flen>: Update comment.
3658         (riscv_call_arg_struct): Remove invalid assertions
3659         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
3660         is removed.
3661         (riscv_gdbarch_init): Gather isa features and abi features
3662         separately, ensure both match on the gdbarch when reusing an old
3663         gdbarch.  Relax an error check to allow 32-bit abi float to run on
3664         a target with 64-bit float hardware.
3665
3666 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3667
3668         * source.c (search_command_helper): Stop reverse search
3669         when line 1 has been searched.
3670
3671 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3672
3673         * record-full.c (record_full_base_target::close): Rewrite
3674         record_full_core_buf_list free logic.
3675
3676 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3677
3678         * break-catch-syscall.c (print_one_catch_syscall): xfree
3679         the last text.
3680
3681 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3682
3683         * top.c (print_gdb_version): Update Copyright year in version
3684         message.
3685
3686 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3687
3688         Update copyright year range in all GDB files.
3689
3690 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
3691
3692         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
3693
3694 For older changes see ChangeLog-2018.
3695 \f
3696 Local Variables:
3697 mode: change-log
3698 left-margin: 8
3699 fill-column: 74
3700 version-control: never
3701 coding: utf-8
3702 End:
3703