gdb/ChangeLog

   1 2019-07-10  Tom Tromey  <tromey@adacore.com>
   2
   3         * solib-darwin.c (struct darwin_info): Add initializers.
   4         (solib_darwin_pspace_data): Change type.
   5         (darwin_pspace_data_cleanup): Remove.
   6         (get_darwin_info, _initialize_darwin_solib): Update.
   7
   8 2019-07-10  Tom Tromey  <tromey@adacore.com>
   9
  10         * remote-sim.c (struct sim_inferior_data): Add initializers,
  11         constructor, and destructor.
  12         (sim_inferior_data_key): Change type.  Move lower.
  13         (check_for_duplicate_sim_descriptor): Update.
  14         (get_sim_inferior_data): Use new.  Update.
  15         (~sim_inferior_data_cleanup): Rename from
  16         sim_inferior_data_cleanup.  Simplify.
  17         (gdbsim_close_inferior, simulator_command)
  18         (sim_command_completer, _initialize_remote_sim): Update.
  19         (next_pid, INITIAL_PID): Move earlier.
  20
  21 2019-07-10  Tom Tromey  <tromey@adacore.com>
  22
  23         * python/python-internal.h (create_thread_object): Return
  24         gdbpy_ref.
  25         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
  26         * python/py-inferior.c (struct threadlist_entry): Add
  27         constructor.
  28         <thread_obj>: Now a gdbpy_ref.
  29         (thread_to_thread_object): Update.
  30         (add_thread_object): Use new.
  31         (delete_thread_object): Use delete.
  32         (infpy_threads): Update.
  33         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
  34         GIL.
  35
  36 2019-07-10  Tom Tromey  <tromey@adacore.com>
  37
  38         * valops.c (value_cast): Specialize error message for Ada.
  39
  40 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
  41
  42         * breakpoint.c (breakpoint_1): Update doc and parameter names.
  43
  44 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
  45
  46         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
  47         bpstat_should_step): Return bool, adjust comments.
  48         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
  49         bpstat_should_step): Likewise.
  50
  51 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
  52
  53         * features/Makefile: Use feature target descriptions for Arm.
  54         * features/arm/arm-core.c: Generate new file.
  55         * features/arm/arm-fpa.c: Likewise.
  56         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
  57         * features/arm/arm-m-profile.c: Likewise.
  58         * features/arm/arm-vfpv2.c: Likewise.
  59         * features/arm/arm-vfpv3.c: Likewise.
  60         * features/arm/xscale-iwmmxt.c: Likewise.
  61         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
  62
  63 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
  64
  65         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
  66         ptrace earlier.
  67
  68 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
  69
  70         * features/aarch64-pauth.c: Regenerate.
  71
  72 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
  73
  74         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
  75         bool.
  76         (bpstat_what): Use false instead of 0.
  77
  78 2019-07-09  Pedro Alves  <palves@redhat.com>
  79
  80         * break-catch-throw.c (is_exception_catchpoint): New.
  81         * breakpoint.c (print_one_breakpoint_location): New parameter
  82         'raw_loc'.  Handle it.  Use
  83         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
  84         looking at the breakpoint's type.
  85         (print_one_breakpoint): If handling "maint info breakpoints", also
  86         print locations of exception catchpoints.
  87         * breakpoint.h (is_exception_catchpoint): Declare.
  88
  89 2019-07-09  Pedro Alves  <palves@redhat.com>
  90
  91         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
  92         "addr" field.
  93         (allocate_location_exception_catchpoint): New.
  94         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
  95         (initialize_throw_catchpoint_ops): Install
  96         allocate_location_exception_catchpoint as allocate_location
  97         method.
  98         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
  99         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 100         bp_loc_other.
 101         (breakpoint_address_is_meaningful): Delete.
 102         (bl_address_is_meaningful): New.
 103         (breakpoint_locations_match): Adjust comment.
 104         (bp_location_from_bp_type): New, factored out of...
 105         (bp_location::bp_location(breakpoint *)): ... this.
 106         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 107         factored out of...
 108         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 109         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 110         breakpoint_address_is_meaningful.
 111         (bp_locations_compare): Adjust comment.
 112         (update_global_location_list): Use bl_address_is_meaningful
 113         instead of breakpoint_address_is_meaningful.
 114         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 115         explicit.
 116         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 117         * python/py-breakpoint.c (bppy_get_location): No longer check
 118         whether location is null.
 119
 120 2019-07-09  Pedro Alves  <palves@redhat.com>
 121
 122         PR c++/15468
 123         * breakpoint.c (print_one_breakpoint_location): Remove
 124         single-location assert.
 125
 126 2019-07-09  Tom Tromey  <tom@tromey.com>
 127
 128         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 129         * configure: Rebuild.
 130         * configure.ac: Change common to gdbsupport.
 131         * gdbsupport: Rename from common.
 132         * acinclude.m4: Change common to gdbsupport.
 133         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 134         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 135         gdbsupport.
 136         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 137         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 138         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 139         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 140         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 141         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 142         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 143         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 144         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 145         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 146         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 147         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 148         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 149         coff-pe-read.c, command.h, compile/compile-c-support.c,
 150         compile/compile-c.h, compile/compile-cplus-symbols.c,
 151         compile/compile-cplus-types.c, compile/compile-cplus.h,
 152         compile/compile-loc2c.c, compile/compile.c, completer.c,
 153         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 154         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 155         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 156         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 157         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 158         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 159         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 160         features/aarch64-core.c, features/aarch64-fpu.c,
 161         features/aarch64-pauth.c, features/aarch64-sve.c,
 162         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 163         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 164         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 165         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 166         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 167         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 168         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 169         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 170         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 171         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 172         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 173         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 174         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 175         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 176         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 177         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 178         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 179         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 180         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 181         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 182         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 183         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 184         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 185         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 186         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 187         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 188         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 189         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 190         minsyms.c, mips-linux-tdep.c, namespace.h,
 191         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 192         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 193         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 194         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 195         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 196         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 197         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 198         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 199         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 200         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 201         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 202         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 203         procfs.c, producer.c, progspace.h, psymtab.h,
 204         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 205         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 206         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 207         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 208         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 209         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 210         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 211         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 212         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 213         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 214         target-memory.c, target.c, target.h, target/waitstatus.c,
 215         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 216         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 217         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 218         unittests/array-view-selftests.c,
 219         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 220         unittests/common-utils-selftests.c,
 221         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 222         unittests/format_pieces-selftests.c,
 223         unittests/function-view-selftests.c,
 224         unittests/lookup_name_info-selftests.c,
 225         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 226         unittests/mkdir-recursive-selftests.c,
 227         unittests/observable-selftests.c,
 228         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 229         unittests/parse-connection-spec-selftests.c,
 230         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 231         unittests/scoped_fd-selftests.c,
 232         unittests/scoped_mmap-selftests.c,
 233         unittests/scoped_restore-selftests.c,
 234         unittests/string_view-selftests.c, unittests/style-selftests.c,
 235         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 236         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 237         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 238         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 239         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 240         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 241
 242 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 243
 244         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 245         bool value.
 246         (decode_digits_ordinary): Set explicit_line field in sal.
 247         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 248         symtab_and_line that was set on an explicit line number in
 249         assembler code.  Do always update the recorded symtab and line if
 250         we do skip the prologue.
 251
 252 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 253
 254         * breakpoint.c (set_breakpoint_location_function): Remove
 255         explicit_loc parameter.
 256         (momentary_breakpoint_from_master): Update call to
 257         set_breakpoint_location_function.
 258         (add_location_to_breakpoint): Likewise.
 259
 260 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 261
 262         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 263         required features based on default bfd type when no specific bfd
 264         is present.
 265
 266 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 267
 268         * NEWS: Mention that GDB printf and eval commands can now print
 269         C-style and Ada-style convenience var strings without
 270         calling the inferior.
 271         * printcmd.c (printf_c_string): Locally print GDB internal var
 272         instead of transiting via the inferior.
 273         (printf_wide_c_string): Likewise.
 274
 275 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 276
 277         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
 278
 279 2019-07-04  Tom Tromey  <tom@tromey.com>
 280
 281         PR tui/24724:
 282         * tui/tui-winsource.c (tui_clear_source_content): Update.
 283         (tui_source_window_base::set_is_exec_point_at): Fix comment.
 284         (tui_update_breakpoint_info): Update.
 285         (tui_set_exec_info_content): Update.
 286         * tui/tui-source.c (tui_set_source_content_nil): Update.
 287         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
 288         has_break.
 289         * tui/tui-data.h (enum tui_bp_flag): New.
 290         (tui_bp_flags): New enum flags type.
 291         (struct tui_source_element) <break_mode>: Change type.  Rename
 292         from has_break.
 293         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
 294         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
 295         constants.
 296         * tui/tui-winsource.h: Fix comment.
 297
 298 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 299
 300         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
 301         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
 302         (store_fpregs_to_thread)
 303         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 304         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
 305         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
 306         (IWMMXT_REGS_SIZE): Add define.
 307         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
 308         (fetch_vfp_regs, store_vfp_regs)
 309         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 310         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
 311
 312 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 313
 314         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
 315         defines.
 316         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
 317         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
 318         (ARM_INT_REGISTER_SIZE): ...to this.
 319         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
 320         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
 321         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
 322         (arm_linux_collect_gregset, supply_nwfpe_register)
 323         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
 324         defines.
 325         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
 326         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
 327         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
 328         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
 329         (arm_return_in_memory, arm_store_return_value)
 330         (arm_get_longjmp_target, arm_register_g_packet_guesses)
 331         (arm_record_ld_st_multiple): Likewise.
 332         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
 333         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
 334
 335 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 336
 337         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
 338         AARCH64_DISPLACED_MODIFIED_INSNS.
 339         * aarch64-tdep.c (struct aarch64_displaced_step_data)
 340         (aarch64_displaced_step_copy_insn): Likewise.
 341         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 342         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
 343         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
 344         ARM_DISPLACED_MODIFIED_INSNS.
 345         * arm-tdep.c (arm_gdbarch_init): Likewise.
 346         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 347         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
 348         (struct arm_displaced_step_closure): Use
 349         ARM_DISPLACED_MODIFIED_INSNS.
 350
 351 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 352
 353         * features/Makefile: Remove unused xml files.
 354         * features/aarch64.xml: Remove.
 355         * features/i386/amd64-avx-avx512-linux.xml: Remove.
 356         * features/i386/amd64-avx-avx512.xml: Remove.
 357         * features/i386/amd64-avx-linux.xml: Remove.
 358         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
 359         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
 360         * features/i386/amd64-avx-mpx-linux.xml: Remove.
 361         * features/i386/amd64-avx-mpx.xml: Remove.
 362         * features/i386/amd64-avx.xml: Remove.
 363         * features/i386/amd64-linux.xml: Remove.
 364         * features/i386/amd64-mpx-linux.xml: Remove.
 365         * features/i386/amd64-mpx.xml: Remove.
 366         * features/i386/amd64.xml: Remove.
 367         * features/i386/i386-avx-avx512-linux.xml: Remove.
 368         * features/i386/i386-avx-avx512.xml: Remove.
 369         * features/i386/i386-avx-linux.xml: Remove.
 370         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
 371         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
 372         * features/i386/i386-avx-mpx-linux.xml: Remove.
 373         * features/i386/i386-avx-mpx.xml: Remove.
 374         * features/i386/i386-avx.xml: Remove.
 375         * features/i386/i386-linux.xml: Remove.
 376         * features/i386/i386-mmx-linux.xml: Remove.
 377         * features/i386/i386-mmx.xml: Remove.
 378         * features/i386/i386-mpx-linux.xml: Remove.
 379         * features/i386/i386-mpx.xml: Remove.
 380         * features/i386/i386.xml: Remove.
 381         * features/i386/x32-avx-avx512-linux.xml: Remove.
 382         * features/i386/x32-avx-linux.xml: Remove.
 383         * features/i386/x32-linux.xml: Remove.
 384
 385 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 386
 387         * regformats/aarch64.dat: Remove.
 388         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
 389         * regformats/i386/amd64-avx-linux.dat: Remove.
 390         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
 391         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
 392         * regformats/i386/amd64-linux.dat: Remove.
 393         * regformats/i386/amd64-mpx-linux.dat: Remove.
 394         * regformats/i386/amd64.dat: Remove.
 395         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
 396         * regformats/i386/i386-avx-linux.dat: Remove.
 397         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
 398         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
 399         * regformats/i386/i386-linux.dat: Remove.
 400         * regformats/i386/i386-mmx-linux.dat: Remove.
 401         * regformats/i386/i386-mpx-linux.dat: Remove.
 402         * regformats/i386/i386.dat: Remove.
 403         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
 404         * regformats/i386/x32-avx-linux.dat: Remove.
 405         * regformats/i386/x32-linux.dat: Remove.
 406
 407 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 408
 409         * aarch64-tdep.c: Remove xml self tests.
 410         * amd64-linux-tdep.c: Likewise.
 411         * amd64-tdep.c: Likewise.
 412         * i386-linux-tdep.c: Likewise.
 413         * i386-tdep.c: Likewise.
 414
 415 2019-07-03  Pedro Alves  <palves@redhat.com>
 416
 417         PR cli/24732
 418         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
 419         (pipe_cmd_option_defs): New.
 420         (make_pipe_cmd_options_def_group): New.
 421         (pipe_command): Use gdb::option::process_options.
 422         (pipe_command_completer): New function.
 423         (_initialize_cli_cmds): Install completer for "pipe" command.
 424
 425 2019-07-03  Pedro Alves  <palves@redhat.com>
 426
 427         * cli/cli-option.c (union option_value) <string>: New field.
 428         (struct option_def_and_value): Add ctor, move ctor, dtor and
 429         use DISABLE_COPY_AND_ASSIGN.
 430         (option_def_and_value::clear_value): New.
 431         (parse_option, save_option_value_in_ctx, get_val_type_str)
 432         (add_setshow_cmds_for_options): Handle var_string.
 433         * cli-option.h (union option_def::var_address) <string>: New
 434         field.
 435         (struct string_option_def): New.
 436         * maint-test-options.c (struct test_options_opts): Add default
 437         ctor and use DISABLE_COPY_AND_ASSIGN.
 438         <string_opt>: New field.
 439         (test_options_opts::~test_options_opts): New.
 440         (test_options_opts::dump): Also dump "-string".
 441         (test_options_option_defs): Install "string.
 442
 443 2019-07-03  Pedro Alves  <palves@redhat.com>
 444
 445         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
 446         option_value with a null enumeration.
 447         (complete_options): Save the option values in the context.
 448         (save_option_value_in_ctx): New, factored out from ...
 449         (process_options): ... here.
 450         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
 451         of the function.
 452         * maint-test-options.c (test_options_opts::dump): New, factored
 453         out from ...
 454         (maintenance_test_options_command_mode): ... here.
 455         (maintenance_test_options_command_completion_result): Delete.
 456         (maintenance_test_options_command_completion_text): Update
 457         comment.
 458         (maintenance_show_test_options_completion_result): Change
 459         prototype.  Just print
 460         maintenance_test_options_command_completion_text.
 461         (save_completion_result): New.
 462         (maintenance_test_options_completer_mode): Pass options context to
 463         complete_options, and then save a dump.
 464         (_initialize_maint_test_options): Use add_cmd to install "maint
 465         show test-options-completion-result".
 466
 467 2019-07-03  Pedro Alves  <palves@redhat.com>
 468
 469         * NEWS (New commands): Mention "with" and "maint with".
 470         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
 471         (with_command, with_command_completer): New.
 472         (pipe_command): Adjust to new repeat_previous
 473         interface.
 474         (_initialize_cli_cmds): Install the "with" command and its "w"
 475         alias.
 476         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
 477         declarations.
 478         * cli/cli-setshow.c (parse_cli_var_uinteger)
 479         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
 480         argument strings for all var_types.
 481         (get_setshow_command_value_string): New, factored out from ...
 482         (do_show_command): ... this.
 483         * cli/cli-setshow.h: Include <string>.
 484         (get_setshow_command_value_string): Declare.
 485         * command.h (repeat_previous): Now returns const char *.  Adjust
 486         comment.
 487         * maint.c: Include "cli/cli-cmds.h".
 488         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
 489         (_initialize_maint_cmds): Register the "maintenance with" command.
 490         * top.c (repeat_previous): Move bits from pipe_command here:
 491         Return the saved command line, if any; error out if there's no
 492         command to relaunch.
 493
 494 2019-07-03  Pedro Alves  <palves@redhat.com>
 495
 496         * NEWS (New commands): Mention "maint set/show test-settings"
 497         instead of "maint test-settings".
 498         * maint-test-settings.c (maintenance_test_settings_list): Delete.
 499         (maintenance_test_settings_set_list): Rename to ...
 500         (maintenance_set_test_settings_list): ... this.
 501         (maintenance_test_settings_show_list): Rename to  ...
 502         (maintenance_show_test_settings_list): ... this.
 503         (maintenance_test_settings_cmd): Delete.
 504         (maintenance_test_settings_set_cmd): ...
 505         (maintenance_set_test_settings_cmd): ... this.
 506         (maintenance_test_settings_show_cmd): ...
 507         (maintenance_show_test_settings_cmd): ... this.
 508         (maintenance_test_settings_show_value_cmd):
 509         (maintenance_show_test_settings_value_cmd): ... this.
 510         (_initialize_maint_test_settings): No longer install the "maint
 511         test-settings" prefix command.  Rename "maint test-settings set"
 512         to "maint set test-settings", and "maint test-settings show" to
 513         "maint show test-settings".  Adjust all subcommands.
 514
 515 2019-07-03  Pedro Alves  <palves@redhat.com>
 516
 517         * maint-test-settings.c: Fix file's intro comment.  Replace all
 518         references to "test-options" with references to "test-settings",
 519         in comments.
 520
 521 2019-07-03  Pedro Alves  <palves@redhat.com>
 522
 523         * maint-test-settings.c (maintenance_test_settings_xxx)
 524         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
 525         New.
 526         (maintenance_test_settings_enums): Use them.
 527         (maintenance_test_settings_enum): Default to
 528         maintenance_test_settings_xxx.
 529         (_initialize_maint_test_settings): Initialize
 530         MAINTENANCE_TEST_SETTINGS_FILENAME.
 531
 532 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 533
 534         * breakpoint.h (remove_breakpoints_inf): Change return type to
 535         void, move function documentation here.
 536         * breakpoint.c (remove_breakpoints_inf): Change return type to
 537         void, move function documentation to header.
 538
 539 2019-07-02  Pedro Alves  <palves@redhat.com>
 540
 541         * NEWS (Completion improvements): Mention "info threads".
 542         * thread.c (struct info_threads_opts, info_threads_option_defs)
 543         (make_info_threads_options_def_group): New.
 544         (info_threads_command): Use gdb::option::process_options.
 545         (info_threads_command_completer): New.
 546         (_initialize_thread): Use gdb::option::build_help to build the
 547         help text for "info threads".
 548
 549 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 550
 551         * defs.h (generic_load): Move from here...
 552         * symfile.h (generic_load): ... to here.  Rename name parameter
 553         to args.
 554         * symfile.c (generic_load): Add comment.
 555
 556 2019-07-01  Tom Tromey  <tromey@adacore.com>
 557
 558         * dwarf2read.c
 559         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
 560         declaration of without_params.  Fix formatting.
 561
 562 2019-07-01  Tom Tromey  <tromey@adacore.com>
 563
 564         * ada-exp.y (find_primitive_type): Update.
 565         * ada-lang.h (ada_lookup_symbol): Update.
 566         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
 567         parameter.
 568         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
 569
 570 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 571
 572         PR breakpoints/24541
 573         * gdbarch.c: Regenerate.
 574         * gdbarch.h: Regenerate.
 575         * gdbarch.sh: Add 'stap_adjust_register'.
 576         * i386-tdep.c: Include '<unordered_set>'.
 577         (i386_stap_adjust_register): New function.
 578         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
 579         * stap-probe.c (stap_parse_register_operand): Call
 580         'gdbarch_stap_adjust_register'.
 581
 582 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 583
 584         PR python/24742
 585         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
 586         * python/python.c (do_start_initialization): Use 'xmalloc'
 587         instead of 'PyMem_Malloc'.
 588
 589 2019-06-28  Tom Tromey  <tromey@adacore.com>
 590
 591         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
 592         for Ada.
 593
 594 2019-06-27  Tom Tromey  <tromey@adacore.com>
 595
 596         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
 597         objfile_key.
 598         (arm_find_mapping_symbol, arm_record_special_symbol)
 599         (_initialize_arm_tdep): Update.
 600         (arm_objfile_data_free): Remove.
 601
 602 2019-06-27  Tom Tromey  <tromey@adacore.com>
 603
 604         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
 605         to cp_print_static_field.
 606
 607 2019-06-26  Tom Tromey  <tromey@adacore.com>
 608
 609         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
 610         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
 611         declare.
 612
 613 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 614
 615         * features/aarch64-core.c (create_feature_aarch64_core):
 616         Regenerate.
 617         * features/aarch64-core.xml: Add cpsr flags.
 618
 619 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 620
 621         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
 622         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
 623
 624 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 625
 626         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
 627         field.
 628         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
 629         use.
 630         (arm_record_special_symbol): Don't insert new symbol in sorted
 631         position, push it at the end.
 632
 633 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 634
 635         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
 636         (arm_mapping_symbol_s): Remove.
 637         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
 638         (arm_mapping_symbol_vec): New typedef.
 639         (struct arm_per_objfile): Add constructor.
 640         <section_maps>: Change type to
 641         std::unique_ptr<arm_mapping_symbol_vec[]>.
 642         (arm_compare_mapping_symbols): Remove.
 643         (arm_find_mapping_symbol): Adjust to section_maps type change.
 644         (arm_objfile_data_free): Call delete on arm_per_objfile.
 645         (arm_record_special_symbol): Adjust to section_maps type change.
 646         Allocate arm_per_objfile with new.
 647
 648 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 649
 650         * cli/cli-cmds.c (alias_command): Compare the alias prefix
 651         with the command prefix.
 652
 653 2019-06-25  Tom Tromey  <tom@tromey.com>
 654
 655         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
 656         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
 657
 658 2019-06-25  Tom Tromey  <tom@tromey.com>
 659
 660         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
 661         type.
 662         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
 663         protected.
 664
 665 2019-06-25  Tom Tromey  <tom@tromey.com>
 666
 667         * tui/tui-winsource.c
 668         (tui_source_window_base::set_is_exec_point_at): Add check against
 669         LOA_ADDRESS.
 670
 671 2019-06-25  Tom Tromey  <tom@tromey.com>
 672
 673         * tui/tui-source.c (tui_set_source_content): Don't check before
 674         xfree.
 675         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
 676
 677 2019-06-25  Tom Tromey  <tom@tromey.com>
 678
 679         * tui/tui-winsource.h (tui_update_source_window_as_is)
 680         (tui_alloc_source_buffer, tui_line_is_displayed)
 681         (tui_addr_is_displayed): Change type of win_info.
 682         * tui/tui-winsource.c (tui_update_source_window_as_is)
 683         (tui_clear_source_content, tui_show_source_line)
 684         (tui_show_source_content, tui_source_window_base::refill)
 685         (tui_source_window_base::set_is_exec_point_at)
 686         (tui_source_window_base::set_is_exec_point_at)
 687         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
 688         (tui_alloc_source_buffer, tui_line_is_displayed)
 689         (tui_addr_is_displayed): Change type of win_info.  Update.
 690         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 691         (tui_source_window_base::do_make_visible_with_new_height):
 692         Update.
 693         * tui/tui-source.c (tui_set_source_content)
 694         (tui_set_source_content_nil)
 695         (tui_source_window::do_scroll_vertical): Update.
 696         * tui/tui-layout.c (show_layout): Update.
 697         * tui/tui-disasm.c (tui_set_disassem_content)
 698         (tui_disasm_window::do_scroll_vertical): Update.
 699         * tui/tui-data.h (tui_win_content): Remove.
 700         (struct tui_gen_win_info) <content, content_size>: Remove.
 701         (struct tui_source_element): Add initializers and destructor.
 702         (union tui_which_element, struct tui_win_element): Remove.
 703         (struct tui_source_window_base) <content>: New field.
 704         (struct tui_data_window): Remove destructor.
 705         (tui_alloc_content, tui_free_win_content)
 706         (tui_free_all_source_wins_content): Don't declare.
 707         * tui/tui-data.c (tui_initialize_static_data): Update.
 708         (init_content_element, tui_alloc_content): Remove.
 709         (~tui_gen_win_info): Update.
 710         (~tui_data_window, tui_free_all_source_wins_content)
 711         (tui_free_win_content, free_content, free_content_elements):
 712         Remove.
 713
 714 2019-06-25  Tom Tromey  <tom@tromey.com>
 715
 716         * tui/tui-winsource.h (tui_clear_source_content)
 717         (tui_erase_source_content, tui_show_source_content): Change type
 718         of win_info.
 719         * tui/tui-winsource.c (tui_clear_source_content)
 720         (tui_erase_source_content, tui_show_source_content): Change type
 721         of win_info.
 722         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 723         * tui/tui-source.h (tui_set_source_content_nil): Change type of
 724         win_info.
 725         * tui/tui-source.c (tui_set_source_content_nil): Change type of
 726         win_info.
 727         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
 728
 729 2019-06-25  Tom Tromey  <tom@tromey.com>
 730
 731         * tui/tui-winsource.c (tui_clear_source_content)
 732         (tui_source_window_base::set_is_exec_point_at): Update.
 733         * tui/tui-source.c (tui_set_source_content_nil): Update.
 734         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
 735         a bool.
 736         * tui/tui-data.c (init_content_element): Update.
 737
 738 2019-06-25  Tom Tromey  <tom@tromey.com>
 739
 740         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
 741         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
 742         * tui/tui-layout.c (init_and_make_win): Update.
 743         * tui/tui.h (enum tui_win_type): Update.
 744         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
 745         tui_win_is_auxillary.
 746         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
 747         tui_win_is_auxillary.
 748
 749 2019-06-25  Tom Tromey  <tom@tromey.com>
 750
 751         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
 752         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
 753         (tui_delete_data_content_windows, tui_display_all_data)
 754         (tui_data_window::do_scroll_vertical, tui_display_data_from):
 755         Update.
 756         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
 757         * tui/tui-regs.c (tui_last_regs_line_no)
 758         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 759         (tui_show_registers): Update.
 760         (tui_show_register_group): Return void.  Update.
 761         (tui_display_registers_from, tui_display_reg_element_at_line)
 762         (tui_display_registers_from_line, tui_check_register_values):
 763         Update.
 764         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
 765         member.
 766         (struct tui_data_window) <regs_content>: Now a std::vector.
 767         <regs_content_count>: Remove.
 768         (tui_add_content_elements, tui_free_data_content): Don't declare.
 769         * tui/tui-data.c (tui_data_window::clear_detail): Update.
 770         (init_content_element): Remove DATA_WIN case.  Add assert.
 771         (tui_add_content_elements): Remove.
 772         (tui_data_window): Update.
 773         (tui_free_data_content): Remove.
 774         (free_content_elements): Remove DATA_WIN case.
 775
 776 2019-06-25  Tom Tromey  <tom@tromey.com>
 777
 778         * tui/tui-data.c (tui_data_item_window): Update.
 779         * tui/tui-windata.h (tui_check_data_values): Don't declare.
 780         * tui/tui-windata.c (tui_display_all_data)
 781         (tui_display_data_from_line): Update.
 782         (tui_check_data_values): Remove.
 783         * tui/tui-regs.c (tui_show_register_group)
 784         (tui_display_reg_element_at_line): Update.
 785         * tui/tui-hooks.c (tui_register_changed)
 786         (tui_refresh_frame_and_register_information): Call
 787         tui_check_register_values.
 788         * tui/tui-data.h (struct tui_data_window) <data_content,
 789         data_content_count, data_type>: Remove.
 790         (enum tui_data_type): Remove.
 791
 792         * tui/tui-data.c (tui_data_window::clear_detail)
 793         (~tui_data_window): Update.
 794
 795 2019-06-25  Tom Tromey  <tom@tromey.com>
 796
 797         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
 798         declare.
 799         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
 800         Rename from tui_first_data_item_displayed.  Update.
 801         (tui_data_window::refresh_all)
 802         (tui_data_window::do_scroll_vertical): Update.
 803         * tui/tui-data.h (struct tui_data_window)
 804         <first_data_item_displayed>: Declare new method.
 805
 806 2019-06-25  Tom Tromey  <tom@tromey.com>
 807
 808         * tui/tui-data.h (tui_init_generic_part): Don't declare.
 809         * tui/tui-data.c (tui_init_generic_part): Remove, moving
 810         contents...
 811         (tui_initialize_static_data): ...here.
 812
 813 2019-06-25  Tom Tromey  <tom@tromey.com>
 814
 815         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 816         (tui_display_registers_from, tui_check_register_values): Update.
 817         (tui_display_register): Remove win_info parameter; update.
 818         (tui_get_register): Change type of parameters.
 819         * tui/tui-data.h (struct tui_data_element): Remove.
 820         (union tui_which_element) <data>: Remove.
 821         <data_window>: Change type.
 822         (struct tui_data_item_window): New.
 823         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
 824         case.  Add assert.
 825         (~tui_data_item_window): New destructor.
 826         (free_content_elements): Remove DATA_ITEM_WIN case.
 827
 828 2019-06-25  Tom Tromey  <tom@tromey.com>
 829
 830         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
 831         Remove.
 832
 833 2019-06-25  Tom Tromey  <tom@tromey.com>
 834
 835         * tui/tui-data.h (struct tui_command_element): Remove.
 836         (union tui_which_element) <command>: Remove.
 837         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
 838         assert.
 839         (free_content_elements): Remove CMD_WIN case.
 840
 841 2019-06-25  Tom Tromey  <tom@tromey.com>
 842
 843         * tui/tui-layout.c (tui_set_layout): Update.
 844         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
 845         * tui/tui-data.c (layout_def): Update.
 846
 847 2019-06-25  Tom Tromey  <tom@tromey.com>
 848
 849         * tui/tui-wingeneral.c (tui_refresh_all): Update.
 850         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 851         (tui_source_window_base::set_new_height): Update.
 852         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
 853         Update.
 854         (tui_set_locator_fullname, tui_set_locator_info)
 855         (tui_show_frame_info): Update.
 856         * tui/tui-source.c (tui_set_source_content)
 857         (tui_source_is_displayed): Update.
 858         * tui/tui-layout.c (show_source_disasm_command, show_data)
 859         (show_source_or_disasm_and_command): Update.
 860         * tui/tui-disasm.c (tui_set_disassem_content)
 861         (tui_get_begin_asm_address): Update.
 862         * tui/tui-data.h (struct tui_locator_element): Remove.
 863         (union tui_which_element) <locator>: Remove.
 864         (struct tui_locator_window): New.
 865         (tui_locator_win_info_ptr): Change return type.
 866         * tui/tui-data.c (_locator): Change type.
 867         (tui_locator_win_info_ptr): Change return type.
 868         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
 869         (tui_alloc_content): Add assert.
 870
 871 2019-06-25  Tom Tromey  <tom@tromey.com>
 872
 873         * tui/tui-winsource.c
 874         (tui_exec_info_window::maybe_allocate_content): New method.
 875         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
 876         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
 877         (make_source_or_disasm_window): Add cast.
 878         * tui/tui-data.h (union tui_which_element) <simple_string>:
 879         Remove.
 880         (struct tui_source_info): New.
 881         (struct tui_source_window_base) <execution_info>: Change type.
 882         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
 883         case, and add assert.
 884         (tui_alloc_content): Add assert.
 885
 886 2019-06-25  Tom Tromey  <tom@tromey.com>
 887
 888         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
 889         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
 890         * tui/tui-data.c (tui_alloc_win_info): Remove.
 891
 892 2019-06-25  Tom Tromey  <tom@tromey.com>
 893
 894         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
 895         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
 896         can_highlight.
 897
 898 2019-06-25  Tom Tromey  <tom@tromey.com>
 899
 900         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
 901         make_visible_with_new_height method.
 902         (tui_win_info::make_visible_with_new_height): New method.
 903         (tui_source_window_base::do_make_visible_with_new_height)
 904         (tui_data_window::do_make_visible_with_new_height)
 905         (tui_cmd_window::do_make_visible_with_new_height): New methods.
 906         (make_visible_with_new_height): Remove.
 907         (tui_resize_all, tui_adjust_win_heights): Use
 908         make_visible_with_new_height method.
 909         * tui/tui-data.h (struct tui_win_info)
 910         <do_make_visible_with_new_height, make_visible_with_new_height>:
 911         New methods.
 912         (struct tui_source_window_base, struct tui_data_window)
 913         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
 914         methods.
 915
 916 2019-06-25  Tom Tromey  <tom@tromey.com>
 917
 918         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
 919         method.
 920         (update_tab_width): Call update_tab_width method.
 921         * tui/tui-data.h (struct tui_win_info)
 922         (struct tui_source_window_base) <update_tab_width>: New methods.
 923
 924 2019-06-25  Tom Tromey  <tom@tromey.com>
 925
 926         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
 927         parameter.
 928         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
 929         parameter.
 930         (tui_gen_win_info::make_visible): Update.
 931         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
 932         parameter.
 933         * tui/tui-data.h (enum tui_box): New enum.
 934         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
 935
 936 2019-06-25  Tom Tromey  <tom@tromey.com>
 937
 938         * tui/tui-layout.c (make_source_or_disasm_window): Always use
 939         init_and_make_win for EXEC_INFO_WIN.
 940         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
 941         longer inline.
 942         (struct tui_win_info) <~tui_win_info>: Inline.
 943         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 944         Don't declare.
 945         * tui/tui-data.c (source_win, disasm_win): Remove globals.
 946         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 947         Remove.
 948         (tui_initialize_static_data): Update.
 949         (~tui_gen_win_info): Handle more cleanup here.
 950         (~tui_source_window_base): Delete "execution_info".
 951         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
 952
 953 2019-06-25  Tom Tromey  <tom@tromey.com>
 954
 955         * tui/tui-layout.c (make_command_window): Don't set
 956         can_highlight.
 957         (show_source_disasm_command): Call the reset method.
 958         (show_data): Don't set can_highlight.  Call the reset method.
 959         (tui_gen_win_info::reset): Rename from init_gen_win_info
 960         (init_and_make_win): Simplify.  Return tui_gen_win_info.
 961         (show_source_or_disasm_and_command): Call the reset method.
 962         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
 963         (struct tui_cmd_window): Set can_highlight.
 964
 965 2019-06-25  Tom Tromey  <tom@tromey.com>
 966
 967         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
 968         from make_visible.
 969         (tui_make_visible, tui_make_invisible): Rewrite.
 970         (tui_win_info::make_visible): Remove.
 971         (tui_source_window_base::make_visible): Update.
 972         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
 973         method.  Moved from...
 974         (struct tui_win_info) <make_visible>: ...here.
 975
 976 2019-06-25  Tom Tromey  <tom@tromey.com>
 977
 978         * tui/tui-winsource.c
 979         (tui_source_window_base::do_scroll_horizontal): Remove direction
 980         parameter.
 981         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
 982         direction parameter.
 983         * tui/tui-win.c (tui_win_info::forward_scroll)
 984         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 985         (tui_win_info::right_scroll): Update.
 986         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
 987         direction parameter.
 988         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
 989         direction parameter.
 990         * tui/tui-data.h (enum tui_scroll_direction): Remove.
 991         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
 992         Remove direction parameter.
 993         (struct tui_source_window_base, struct tui_source_window)
 994         (struct tui_disasm_window, struct tui_data_window)
 995         (struct tui_cmd_window): Update.
 996
 997 2019-06-25  Tom Tromey  <tom@tromey.com>
 998
 999         * tui/tui-winsource.h (tui_set_exec_info_content)
1000         (tui_show_exec_info_content, tui_erase_exec_info_content)
1001         (tui_clear_exec_info_content, tui_update_exec_info): Change
1002         argument to tui_source_window_base.
1003         * tui/tui-winsource.c (tui_set_exec_info_content)
1004         (tui_show_exec_info_content, tui_erase_exec_info_content)
1005         (tui_clear_exec_info_content, tui_update_exec_info): Change
1006         argument to tui_source_window_base.
1007
1008 2019-06-25  Tom Tromey  <tom@tromey.com>
1009
1010         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1011         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1012
1013 2019-06-25  Tom Tromey  <tom@tromey.com>
1014
1015         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1016         check.
1017
1018 2019-06-25  Tom Tromey  <tom@tromey.com>
1019
1020         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1021         type to void.
1022         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1023         type to void.
1024         * tui/tui-source.c (tui_set_source_content): Update.
1025         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1026
1027 2019-06-25  Tom Tromey  <tom@tromey.com>
1028
1029         * tui/tui-win.c (window_name_completer, tui_set_focus)
1030         (tui_all_windows_info): Use name method.
1031         * tui/tui-data.h (struct tui_gen_win_info)
1032         (struct tui_source_window, struct tui_disasm_window)
1033         (struct tui_data_window, struct tui_cmd_window) <name>: New
1034         method.
1035         (tui_win_name): Don't declare.
1036         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1037         (tui_win_name): Remove.
1038
1039 2019-06-25  Tom Tromey  <tom@tromey.com>
1040
1041         * tui/tui-winsource.h (tui_update_source_window)
1042         (tui_update_source_window_as_is): Change parameter type.
1043         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1044         to be a tui_source_window_base.
1045         (tui_update_source_window_as_is): Likewise.
1046         * tui/tui-win.c (make_visible_with_new_height): Update.
1047
1048 2019-06-25  Tom Tromey  <tom@tromey.com>
1049
1050         * tui/tui-winsource.c (tui_erase_source_content)
1051         (tui_show_source_content, tui_show_exec_info_content)
1052         (tui_erase_exec_info_content): Use refresh_window method.
1053         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1054         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1055         from tui_refresh_win.
1056         (tui_data_window::refresh_window): New method.
1057         (tui_win_info::refresh, tui_source_window_base::refresh)
1058         (tui_refresh_all): Use refresh_window method.
1059         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1060         method.
1061         * tui/tui-regs.c (tui_display_register): Call refresh_window
1062         method.
1063         * tui/tui-layout.c (show_source_disasm_command)
1064         (show_source_or_disasm_and_command): Call refresh_window method.
1065         * tui/tui-data.h (struct tui_gen_win_info)
1066         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1067         New method.
1068
1069 2019-06-25  Tom Tromey  <tom@tromey.com>
1070
1071         * tui/tui.c (tui_rl_other_window, tui_enable)
1072         (tui_is_window_visible, tui_get_command_dimension): Update.
1073         * tui/tui-winsource.c (tui_update_source_window_as_is)
1074         (tui_clear_source_content, tui_erase_source_content)
1075         (tui_show_source_line, tui_source_window_base::refill)
1076         (tui_source_window_base::do_scroll_horizontal)
1077         (tui_source_window_base::set_is_exec_point_at)
1078         (tui_update_breakpoint_info, tui_set_exec_info_content)
1079         (tui_alloc_source_buffer, tui_line_is_displayed)
1080         (tui_addr_is_displayed): Update.
1081         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1082         (tui_check_and_display_highlight_if_needed)
1083         (tui_win_info::make_visible, tui_win_info::refresh)
1084         (tui_refresh_all): Update.
1085         * tui/tui-windata.c (tui_first_data_item_displayed)
1086         (tui_delete_data_content_windows, tui_erase_data_content)
1087         (tui_display_all_data, tui_data_window::refresh_all)
1088         (tui_check_data_values): Update.
1089         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1090         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1091         (tui_win_info::backward_scroll, tui_refresh_all_win)
1092         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1093         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1094         (tui_source_window_base::set_new_height)
1095         (tui_data_window::set_new_height)
1096         (make_invisible_and_set_new_height)
1097         (make_visible_with_new_height, new_height_ok)
1098         (parse_scrolling_args): Update.
1099         * tui/tui-stack.c (tui_show_frame_info): Update.
1100         * tui/tui-source.c (tui_set_source_content)
1101         (tui_set_source_content_nil, tui_source_is_displayed)
1102         (tui_source_window::do_scroll_vertical): Update.
1103         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1104         (tui_display_registers_from, tui_display_reg_element_at_line)
1105         (tui_check_register_values, tui_reg_command): Update.
1106         * tui/tui-layout.c (tui_default_win_height)
1107         (show_source_disasm_command, show_data, init_and_make_win)
1108         (show_source_or_disasm_and_command): Update.
1109         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1110         (tui_redisplay_readline, tui_mld_flush)
1111         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1112         (tui_getc): Update.
1113         * tui/tui-disasm.c (tui_set_disassem_content)
1114         (tui_disasm_window::do_scroll_vertical): Update.
1115         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1116         Now virtual.
1117         (struct tui_win_info): Derive from tui_gen_win_info.
1118         <~tui_win_info>: Mark as override.
1119         <generic>: Remove member.
1120         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1121         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1122         (~tui_data_window, ~tui_win_info)
1123         (tui_free_all_source_wins_content): Update.
1124         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1125
1126 2019-06-25  Tom Tromey  <tom@tromey.com>
1127
1128         * tui/tui-layout.c (init_and_make_win): Use new.
1129         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1130         destructor, initializers.
1131         (tui_alloc_generic_win_info): Don't declare.
1132         * tui/tui-data.c (_locator): Add argument to constructor.
1133         (source_win, disasm_win): New globals.
1134         (exec_info): Remove.
1135         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1136         Update.
1137         (tui_alloc_generic_win_info): Remove.
1138         (init_content_element): Use new.
1139         (tui_win_info::tui_win_info): Update.
1140         (free_content_elements) <case DATA_WIN>: Use delete.
1141
1142 2019-06-25  Tom Tromey  <tom@tromey.com>
1143
1144         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1145         * tui/tui-windata.c (tui_first_data_item_displayed)
1146         (tui_delete_data_content_windows): Update.
1147         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1148         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1149         (tui_display_registers_from, tui_check_register_values): Update.
1150         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1151         pointer.
1152         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1153         window.
1154         (tui_free_data_content): Update.
1155         (free_content_elements) <case DATA_WIN>: Free the window.
1156
1157 2019-06-25  Tom Tromey  <tom@tromey.com>
1158
1159         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1160         Update.
1161         * tui/tui-layout.c (make_command_window)
1162         (show_source_disasm_command, show_data, init_and_make_win)
1163         (show_source_or_disasm_and_command): Update.
1164         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1165         method.
1166         <can_highight, is_highlighted>: Now bool.
1167         (tui_set_win_highlight): Don't declare.
1168         * tui/tui-data.c (tui_set_win_highlight): Remove.
1169
1170 2019-06-25  Tom Tromey  <tom@tromey.com>
1171
1172         * tui/tui-wingeneral.c (make_visible): Remove check of window
1173         type.
1174
1175 2019-06-25  Tom Tromey  <tom@tromey.com>
1176
1177         * tui/tui-win.c (tui_win_info::max_height)
1178         (tui_cmd_window::max_height): New methods.
1179         (new_height_ok): Call max_height.
1180         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1181         <max_height>: New method.
1182
1183 2019-06-25  Tom Tromey  <tom@tromey.com>
1184
1185         * tui/tui-win.c (tui_source_window_base::set_new_height)
1186         (tui_data_window::set_new_height): New methods.
1187         (make_invisible_and_set_new_height): Call set_new_height method.
1188         * tui/tui-data.h (struct tui_win_info)
1189         (struct tui_source_window_base, struct tui_data_window)
1190         <set_new_height>: New method.
1191
1192 2019-06-25  Tom Tromey  <tom@tromey.com>
1193
1194         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1195         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1196         tui_refresh_data_win.
1197         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1198         method.
1199         (tui_refresh_all_win): Call the refresh_all method.
1200         (tui_set_focus): Likewise.
1201         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1202         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1203         Likewise.
1204
1205 2019-06-25  Tom Tromey  <tom@tromey.com>
1206
1207         * tui/tui-winsource.h (tui_refill_source_window)
1208         (tui_set_is_exec_point_at): Don't declare.
1209         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1210         (tui_source_window_base::refill): Rename from
1211         tui_refill_source_window.
1212         (tui_source_window_base::do_scroll_horizontal): Update.
1213         (tui_source_window_base::set_is_exec_point_at): Rename from
1214         tui_set_is_exec_point_at.
1215         (tui_update_all_breakpoint_info): Update.
1216         * tui/tui-stack.c (tui_show_frame_info): Update.
1217         * tui/tui-layout.c (show_data): Add cast.
1218         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1219         * tui/tui-data.h (struct tui_source_window_base) <refill,
1220         set_is_exec_point_at>: New methods.
1221         (tui_source_windows, tui_add_to_source_windows): Update types.
1222         (tui_add_to_source_windows): Remove redundant declaration.
1223         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1224         (tui_source_windows): Change return type.
1225         (tui_clear_source_windows_detail): Update.
1226         (tui_add_to_source_windows): Change type of parameter.
1227         (tui_free_all_source_wins_content): Update.
1228
1229 2019-06-25  Tom Tromey  <tom@tromey.com>
1230
1231         * tui/tui-wingeneral.c (tui_win_info::refresh)
1232         (tui_source_window_base::refresh): New methods.
1233         (tui_refresh_all): Call the refresh method.
1234         * tui/tui-data.h (struct tui_win_info)
1235         (struct tui_source_window_base) <refresh>: New method.
1236
1237 2019-06-25  Tom Tromey  <tom@tromey.com>
1238
1239         * tui/tui.h (tui_is_window_visible): Return bool.
1240         * tui/tui.c (tui_is_window_visible): Return bool.
1241         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1242         (tui_make_visible, tui_make_invisible)
1243         (tui_win_info::make_visible)
1244         (tui_source_window_base::make_visible, make_all_visible)
1245         (tui_make_all_visible, tui_make_all_invisible): Update.
1246         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1247         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1248         bool.
1249         (struct tui_win_info, struct tui_source_window_base)
1250         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1251         * tui/tui-data.c (tui_init_generic_part): Update.
1252
1253 2019-06-25  Tom Tromey  <tom@tromey.com>
1254
1255         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1256         (tui_source_window_base::make_visible): New methods.
1257         (make_all_visible): Make method call.
1258         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1259         (struct tui_source_window_base, struct tui_cmd_window): Override
1260         make_visible.
1261         (tui_win_is_source_type): Don't declare.
1262         * tui/tui-data.c (tui_win_is_source_type): Remove.
1263
1264 2019-06-25  Tom Tromey  <tom@tromey.com>
1265
1266         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1267         NULL check.
1268
1269 2019-06-25  Tom Tromey  <tom@tromey.com>
1270
1271         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1272         Inline constructor.  Add initializers for members.
1273         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1274         constructors; now inline in class.
1275
1276 2019-06-25  Tom Tromey  <tom@tromey.com>
1277
1278         * tui/tui-regs.c (tui_show_registers): Update.
1279         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1280         bool.
1281         * tui/tui-data.c (tui_data_window::clear_detail)
1282         (tui_data_window): Update.
1283
1284 2019-06-25  Tom Tromey  <tom@tromey.com>
1285
1286         * tui/tui-windata.c (tui_display_all_data)
1287         (tui_display_data_from_line, tui_display_data_from)
1288         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1289         Update.
1290         * tui/tui-regs.c (tui_last_regs_line_no)
1291         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1292         (tui_show_registers, tui_show_register_group)
1293         (tui_display_registers_from, tui_display_reg_element_at_line)
1294         (tui_display_registers_from_line, tui_check_register_values)
1295         (tui_reg_next, tui_reg_prev): Update.
1296         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1297         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1298         tui_data_window.
1299         (struct tui_win_info) <detail>: Remove.  Add new fields from
1300         tui_data_info.
1301         (TUI_DATA_WIN): Add cast.
1302         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1303         (~tui_data_window): Simplify.
1304
1305 2019-06-25  Tom Tromey  <tom@tromey.com>
1306
1307         * tui/tui-layout.c (show_source_disasm_command)
1308         (show_source_or_disasm_and_command): Update.
1309         * tui/tui-io.c (update_cmdwin_start_line)
1310         (tui_redisplay_readline): Update.
1311         * tui/tui-data.h (struct tui_command_info): Remove.
1312         (struct tui_win_info) <detail>: Remove command_info member.
1313         (struct tui_data_window) <start_line>: New member, from
1314         tui_command_info.
1315         (TUI_CMD_WIN): Add casts.
1316
1317 2019-06-25  Tom Tromey  <tom@tromey.com>
1318
1319         * tui/tui-winsource.c (tui_update_source_window)
1320         (tui_refill_source_window)
1321         (tui_source_window_base::do_scroll_horizontal)
1322         (tui_update_breakpoint_info, tui_set_exec_info_content)
1323         (tui_show_exec_info_content, tui_erase_exec_info_content)
1324         (tui_clear_exec_info_content): Update.
1325         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1326         Update.
1327         * tui/tui-win.c (make_invisible_and_set_new_height)
1328         (make_visible_with_new_height): Update.
1329         * tui/tui-source.c (tui_set_source_content)
1330         (tui_show_symtab_source): Update.
1331         * tui/tui-layout.c (extract_display_start_addr)
1332         (show_source_disasm_command, show_data)
1333         (make_source_or_disasm_window)
1334         (show_source_or_disasm_and_command): Update.
1335         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1336         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1337         "gdbarch".
1338         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1339         to tui_source_window_base.
1340         (struct tui_win_info) <detail>: Remove source_info member.
1341         (struct tui_source_window_base) <has_locator>: Inline.
1342         Move contents from tui_source_info; rename has_locator member to
1343         m_has_locator.
1344         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1345         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1346         header file.
1347         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1348         Simplify.
1349         (tui_free_all_source_wins_content): Cast to
1350         tui_source_window_base.
1351
1352 2019-06-25  Tom Tromey  <tom@tromey.com>
1353
1354         * tui/tui-win.c (make_invisible_and_set_new_height)
1355         (make_visible_with_new_height): Call has_locator method.
1356         * tui/tui-layout.c (show_source_disasm_command, show_data)
1357         (show_source_or_disasm_and_command): Update for bool change.
1358         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1359         (tui_win_info) <has_locator>: New method.
1360         (struct tui_source_window_base) <has_locator>: New method.
1361         (tui_win_has_locator): Don't declare.
1362         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1363         from tui_win_has_locator.
1364         (tui_source_window_base): Use false, not FALSE.
1365
1366 2019-06-25  Tom Tromey  <tom@tromey.com>
1367
1368         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1369         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1370         clear_detail method directly.
1371         (tui_clear_win_detail): Remove.
1372
1373 2019-06-25  Tom Tromey  <tom@tromey.com>
1374
1375         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1376         "this", not TUI_DISASM_WIN.
1377
1378 2019-06-25  Tom Tromey  <tom@tromey.com>
1379
1380         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1381         declare.
1382         * tui/tui-winsource.c
1383         (tui_source_window_base::do_scroll_horizontal): Rename from
1384         tui_horizontal_source_scroll.
1385         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1386         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1387         from tui_vertical_data_scroll.
1388         * tui/tui-win.h (tui_scroll): Don't declare.
1389         * tui/tui-win.c (tui_win_info::forward_scroll)
1390         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1391         (tui_win_info::right_scroll): Rename and update.
1392         (tui_scroll_forward_command, tui_scroll_backward_command)
1393         (tui_scroll_left_command, tui_scroll_right_command): Update.
1394         (tui_scroll): Remove.
1395         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1396         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1397         from tui_vertical_source_scroll.
1398         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1399         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1400         from tui_vertical_disassem_scroll.
1401         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1402         do_scroll_horizontal>: New methods.
1403         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1404         Likewise.
1405         (struct tui_source_window_base): Add do_scroll_horizontal.
1406         (struct tui_source_window, struct tui_disasm_window): Add
1407         do_scroll_vertical.
1408         (struct tui_data_window, struct tui_cmd_window): Add
1409         do_scroll_horizontal and do_scroll_vertical.
1410         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1411
1412 2019-06-25  Tom Tromey  <tom@tromey.com>
1413
1414         * tui/tui-data.h (struct tui_source_window_base): New struct.
1415         (struct tui_source_window): Derive from tui_source_window_base.
1416         (struct tui_disasm_window): New struct.
1417         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1418         from tui_source_window::clear_detail.
1419         (tui_source_window_base): Rename from tui_source_window.
1420         (~tui_source_window_base): Rename from ~tui_source_window.
1421         (tui_alloc_win_info): Create a tui_disasm_window.
1422
1423 2019-06-25  Tom Tromey  <tom@tromey.com>
1424
1425         * tui/tui-data.h (struct tui_source_window)
1426         (struct tui_data_window): Declare destructors.
1427         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1428         destructors.
1429         (tui_win_info): Simplify.
1430
1431 2019-06-25  Tom Tromey  <tom@tromey.com>
1432
1433         * tui/tui-winsource.c (tui_display_main)
1434         (tui_update_source_windows_with_addr)
1435         (tui_update_all_breakpoint_info): Update.
1436         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1437         (new_height_ok, parse_scrolling_args): Update.
1438         * tui/tui-stack.c (tui_show_frame_info): Update.
1439         * tui/tui-data.h (struct tui_list): Remove.
1440         (tui_source_windows): Return a reference to a std::vector.
1441         * tui/tui-data.c (source_windows): Now a std::vector.
1442         (tui_source_windows): Change return type.
1443         (tui_clear_source_windows): Rewrite.
1444         (tui_clear_source_windows_detail, tui_add_to_source_windows)
1445         (tui_free_all_source_wins_content): Rewrite.
1446
1447 2019-06-25  Tom Tromey  <tom@tromey.com>
1448
1449         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
1450         (struct tui_data_window, struct tui_cmd_window): Declare
1451         clear_detail method.
1452         * tui/tui-data.c (tui_source_window::clear_detail)
1453         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
1454         methods.
1455         (tui_clear_win_detail): Simplify.
1456
1457 2019-06-25  Tom Tromey  <tom@tromey.com>
1458
1459         * tui/tui-layout.c (make_source_window, make_disasm_window)
1460         (make_source_or_disasm_window): Remove win_info_ptr parameter.
1461         Return the new window.
1462         (show_source_disasm_command, show_data)
1463         (show_source_or_disasm_and_command): Update.
1464
1465 2019-06-25  Tom Tromey  <tom@tromey.com>
1466
1467         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
1468         parameter.  Return the new window.
1469         (show_source_disasm_command): Update and remove NULL check.
1470         (show_source_or_disasm_and_command): Update.
1471
1472 2019-06-25  Tom Tromey  <tom@tromey.com>
1473
1474         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
1475
1476 2019-06-25  Tom Tromey  <tom@tromey.com>
1477
1478         * tui/tui-data.h (struct tui_win_info): Make constructor
1479         protected.  Make destructor virtual.  Add initializers.
1480         (tui_source_window, tui_data_window, tui_cmd_window): New
1481         classes.
1482         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
1483         constructor.  Add "type" parameter.
1484         (tui_source_window, tui_data_window, tui_cmd_window): New
1485         constructors.
1486         (tui_alloc_win_info): Instantiate the appropriate subclass.
1487
1488 2019-06-25  Tom Tromey  <tom@tromey.com>
1489
1490         * tui/tui-win.c (tui_resize_all): Use delete.
1491         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
1492         destructor.
1493         (tui_free_window): Don't declare.
1494         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
1495         Update.
1496
1497 2019-06-25  Tom Tromey  <tom@tromey.com>
1498
1499         * tui/tui-data.h (struct tui_win_info): Add constructor.
1500         * tui/tui-data.c (tui_alloc_win_info): Use new.
1501         (tui_free_window): Use delete.
1502
1503 2019-06-22  Tom Tromey  <tom@tromey.com>
1504
1505         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
1506         declare.
1507         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
1508
1509 2019-06-22  Tom Tromey  <tom@tromey.com>
1510
1511         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
1512         declare.
1513         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
1514
1515 2019-06-22  Tom de Vries  <tdevries@suse.de>
1516
1517         * dwarf2read.c (create_addrmap_from_aranges)
1518         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
1519         instead of '%zu'.
1520
1521 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
1522
1523         * dwarf2read.h (dwarf2_section_info_def): Remove.
1524         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
1525         * dwarf2read.c (struct dwo_sections) <types>: Change type to
1526         std::vector<dwarf2_section_info>.
1527         (struct dwo_file) <~dwo_file>: Remove.
1528         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
1529         types field.
1530         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
1531         (dwarf2_read_debug_names): Likewise.
1532         (create_debug_types_hash_table): Change parameter type to
1533         array_view, adjust code accordingly.
1534         (dwarf2_locate_dwo_sections): Adjust to std::vector.
1535         (partial_die_info::fixup): Likewise.
1536         (determine_prefix): Likewise.
1537         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
1538
1539 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1540
1541         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
1542         gdb_bfd_ref_ptr.
1543         <~dwo_file>: Remove call to gdb_bfd_unref.
1544         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
1545         gdb_bfd_ref_ptr::get.
1546
1547 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1548
1549         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
1550         type to htab_up.
1551         * dwarf2read.c (struct dwo_file): Initialize fields.
1552         <~dwo_file>: New.
1553         (free_dwo_file): Remove, move content to ~dwo_file.
1554         (struct dwo_file_deleter): Remove.
1555         (dwo_file_up>: Remove custom deleter.
1556         (free_dwo_files): Remove.
1557         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
1558         dwo_files.
1559         (process_skeletonless_type_units): Call unique_ptr::get.
1560         (allocate_dwo_file_hash_table): Add deleter to created hash
1561         table.  Change return type to htab_up.
1562         (lookup_dwo_file_slot): Don't memset dwo_file, call
1563         unique_ptr::get.
1564         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
1565         (create_dwo_unit_in_dwp_v2): Likewise.
1566         (open_and_init_dwo_file): Likewise.
1567         (free_dwo_file_from_slot): Remove.
1568
1569 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1570
1571         * dwarf2read.h (struct dwarf2_section_info) <readin,
1572         is_virtual>: Change type to bool.
1573         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
1574         true instead of 1.
1575
1576 2019-06-19  Tom Tromey  <tom@tromey.com>
1577
1578         * tui/tui-data.h (tui_init_content_element): Don't declare.
1579
1580 2019-06-19  Tom Tromey  <tom@tromey.com>
1581
1582         * tui/tui-data.h (tui_init_win_info): Don't declare.
1583
1584 2019-06-19  Tom de Vries  <tdevries@suse.de>
1585
1586         * dwarf2read.h (abstract_to_concrete): Change type to
1587         std::unordered_map<sect_offset, std::vector<sect_offset>,
1588         gdb::hash_enum<sect_offset>>.
1589
1590 2019-06-19  Tom Tromey  <tromey@adacore.com>
1591
1592         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
1593         EVAL_AVOID_SIDE_EFFECTS specially.
1594
1595 2019-06-19  Tom Tromey  <tromey@adacore.com>
1596
1597         * source-cache.c (highlighter): New global.
1598         (source_cache::get_source_lines): Create a highlighter on demand.
1599
1600 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1601
1602         * defs.h (deprecated_interactive_hook): Delete declaration.
1603         * interps.c (clear_interpreter_hooks): Remove use of
1604         deprecated_interactive_hook.
1605         * top.c (deprecated_interactive_hook): Delete definition.
1606         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
1607
1608 2019-06-18  Tom de Vries  <tdevries@suse.de>
1609
1610         PR gdb/24515
1611         * dwarf2read.h (abstract_to_concrete): Change type from
1612         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
1613         std::unordered_map<sect_offset, std::vector<sect_offset>>.
1614         * dwarf2read.c (read_variable): Update.
1615         (dwarf2_fetch_die_loc_sect_off): Update.
1616
1617 2019-06-17  Tom de Vries  <tdevries@suse.de>
1618
1619         PR gdb/24617
1620         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
1621         accessing parent[parent_len - 1].
1622
1623 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
1624
1625         PR gdb/24364
1626         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
1627         call dtrace_process_dof with NULL dof.
1628
1629 2019-06-16  Tom de Vries  <tdevries@suse.de>
1630
1631         PR gdb/24445
1632         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
1633
1634 2019-06-16  Tom Tromey  <tom@tromey.com>
1635
1636         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1637         (make_all_visible): Use address of member.
1638
1639 2019-06-16  Tom Tromey  <tom@tromey.com>
1640
1641         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
1642         (tui_free_window, free_content, free_content_elements): Remove
1643         unnecessary cast.
1644         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
1645         cast.
1646         * tui/tui-regs.c (tui_show_register_group)
1647         (tui_display_registers_from, tui_display_reg_element_at_line):
1648         Remove unnecessary cast.
1649
1650 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
1651
1652         * linux-nat.c (normal_mask): Delete.
1653         (_initialize_linux_nat): Don't initialise normal_mask.
1654
1655 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
1656
1657         PR gdb/24445
1658         * dwarf-index-write.h (write_psymtabs_to_index): Add
1659         dwz_basename parameter.
1660         * dwarf-index-write.c (write_gdbindex): Move file writing to
1661         write_gdbindex_1.  Change return type void.
1662         (assert_file_size): Move up, remove filename parameter.
1663         (write_gdbindex_1): New function.
1664         (write_debug_names): Change return type to void, call
1665         assert_file_size.
1666         (struct index_wip_file): New struct.
1667         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
1668         file logic to index_wip_file.  Write index for dwz file if
1669         needed.
1670         (save_gdb_index_command): Pass basename of dwz file, if present.
1671         * dwarf-index-cache.c (index_cache::store): Obtain and pass
1672         build-id of dwz file, if present.
1673         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1674         (dwarf2_get_dwz_file): Likewise.
1675         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1676         (dwarf2_get_dwz_file): Likewise.
1677
1678 2019-06-16  Tom Tromey  <tom@tromey.com>
1679
1680         * coffread.c (process_coff_symbol): Use xstrdup.
1681         * value.c (create_internalvar): Use xstrdup.
1682
1683 2019-06-16  Tom Tromey  <tom@tromey.com>
1684
1685         * valops.c (value_cast, value_slice): Remove unnecessary cast.
1686         * breakpoint.c (stopin_command, stopat_command)
1687         (until_break_command, decode_location_default): Remove unnecessary
1688         cast.
1689         * utils.c (subset_compare): Remove unnecessary cast.
1690         * ada-lang.c (ada_update_initial_language): Remove unnecessary
1691         cast.
1692         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1693         cast.
1694         * infcmd.c (path_command): Remove unnecessary cast.
1695         * coffread.c (decode_type): Remove unnecessary cast.
1696         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1697         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1698         * tui/tui-stack.c (tui_show_locator_content)
1699         (tui_show_frame_info): Remove unnecessary cast.
1700         * tui/tui-win.c (tui_scroll_forward_command)
1701         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1702         (parse_scrolling_args): Remove unnecessary cast.
1703         * tui/tui-data.c (init_win_info, tui_del_window)
1704         (tui_free_window, tui_del_data_windows, tui_free_data_content)
1705         (free_content_elements): Remove unnecessary cast.
1706         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1707         unnecessary cast.
1708         * tui/tui-source.c (tui_set_source_content)
1709         (tui_vertical_source_scroll): Remove unnecessary cast.
1710         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1711         cast.
1712         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1713         * tui/tui-regs.c (tui_display_registers_from)
1714         (tui_display_register): Remove unnecessary cast.
1715         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1716         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1717         (make_visible): Remove unnecessary cast.
1718         * tui/tui-winsource.c (tui_erase_source_content)
1719         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1720         unnecessary cast.
1721         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1722         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1723         * stabsread.c (read_type, read_array_type, read_range_type):
1724         Remove unnecessary cast.
1725         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1726         (parse_symbol, parse_type, upgrade_type, parse_external)
1727         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
1728         unnecessary cast.
1729         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
1730
1731 2019-06-16  Tom Tromey  <tom@tromey.com>
1732
1733         * tui/tui-data.c (tui_alloc_generic_win_info)
1734         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
1735         checks.
1736
1737 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
1738             Andrew Burgess  <andrew.burgess@embecosm.com>
1739
1740         * f-typeprint.c (f_print_type): Don't return early for not
1741         associated or not allocated types.
1742         (f_type_print_varspec_suffix): Add print_rank parameter and print
1743         ranks of array types in case they dangling.
1744         (f_type_print_base): Add print_rank parameter.
1745
1746 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1747
1748         * NEWS: Mention new MI commands.
1749         * break-catch-throw.c (enum exception_event_kind): Move to
1750         breakpoint.h.
1751         (print_mention_exception_catchpoint): Output text as a single
1752         message.
1753         (catch_exception_command_1): Rename to...
1754         (catch_exception_event): ...this, make non-static, update header
1755         command, and change some parameter types.
1756         (catch_catch_command): Update for changes to
1757         catch_exception_command_1.
1758         (catch_throw_command): Likewise.
1759         (catch_rethrow_command): Likewise.
1760         * breakpoint.c (enum exception_event_kind): Delete.
1761         * breakpoint.h (enum exception_event_kind): Moved here from
1762         break-catch-throw.c.
1763         (catch_exception_event): Declare.
1764         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
1765         (mi_cmd_catch_throw): New function.
1766         (mi_cmd_catch_rethrow): New function.
1767         (mi_cmd_catch_catch): New function.
1768         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
1769         'catch-catch' entries.
1770         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
1771         (mi_cmd_catch_rethrow): Declare.
1772         (mi_cmd_catch_catch): Declare.
1773
1774 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1775
1776         * annotate.c (annotate_source_line): Change return type to void,
1777         update implementation to match.
1778         * annotate.h (annotate_source_line): Change return type to void,
1779         update header comment.
1780         * stack.c (print_frame_info): Don't change what frame information
1781         is printed based on whether annotations are on or not.
1782
1783 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1784
1785         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
1786         (annotate_source): Make static.
1787         (annotate_source_line): Moved from source.c and renamed from
1788         identify_source_line.  Update the return type.
1789         * annotate.h (annotate_source): Delete declaration.
1790         (annotate_source_line): Declaration moved from source.h, and
1791         renamed from identify_source_line.  Return type updated.
1792         * source.c (identify_source_line): Moved to annotate.c and renamed
1793         to annotate_source_line.
1794         (info_line_command): Remove check of annotation_level.
1795         * source.h (identify_source_line): Move declaration to annotate.h
1796         and rename to annotate_source_line.
1797         * stack.c: Add 'annotate.h' include.
1798         (print_frame_info): Remove check of annotation_level before
1799         calling annotate_source_line.
1800
1801 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1802
1803         * source-cache.c (source_cache::get_plain_source_lines): Use
1804         open_source_file_with_line_charpos instead of just
1805         open_source_file, remove call to find_source_lines.
1806         (source_cache::get_source_lines): Likewise.
1807         * source.c (find_source_lines): Make static.
1808         (get_filename_and_charpos): Renamed into...
1809         (open_source_file_with_line_charpos): ..this along with changes to
1810         return a scoped_fd, and some other minor clean ups.
1811         (identify_source_line): Use open_source_file_with_line_charpos.
1812         (search_command_helper): Use open_source_file_with_line_charpos
1813         instead of just open_source_file, remove call to
1814         find_source_lines.
1815         * source.h (open_source_file_with_line_charpos): Declare new
1816         function.
1817         (find_source_lines): Delete declaration.
1818
1819 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1820
1821         * source.c (get_filename_and_charpos): Remove fullname
1822         parameter.
1823         (identify_source_line): Update call to get_filename_and_charpos.
1824
1825 2019-06-14  Tom Tromey  <tromey@adacore.com>
1826
1827         PR gdb/24502:
1828         * ui-style.h (skip_ansi_escape): Update comment.
1829         * ui-file.h (class no_terminal_escape_file): New class.
1830         * ui-file.c (no_terminal_escape_file::write)
1831         (no_terminal_escape_file::puts): New methods.
1832         * cli/cli-logging.c (handle_redirections): Use
1833         no_terminal_escape_file.
1834
1835 2019-06-14  Tom Tromey  <tromey@adacore.com>
1836
1837         * NEWS: Move convenience variable news above Python news.
1838
1839 2019-06-14  Tom Tromey  <tom@tromey.com>
1840
1841         * gnulib: Move directory to top-level.
1842         * configure.ac: Don't configure gnulib.
1843         * configure: Rebuild.
1844         * common/common-defs.h: Use new path to gnulib.
1845         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
1846         (GNULIB_H): Remove.
1847         (INCGNU): Look in new gnulib location.
1848         (HFILES_NO_SRCDIR): Remove gnulib files.
1849         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
1850         (generated_files): Remove GNULIB_H.
1851         ($(LIBGNU), all-lib): Remove targets.
1852         (distclean): Don't mention GNULIB_BUILDDIR.
1853         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
1854
1855 2019-06-14  Tom Tromey  <tromey@adacore.com>
1856
1857         * symfile.c (add_symbol_file_command): Remove obsolete comment.
1858         Warn if symbol file does not provide any symbols.
1859
1860 2019-06-14  Tom Tromey  <tromey@adacore.com>
1861
1862         * source.c (find_and_open_source): Respect basenames_may_differ.
1863
1864 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
1865
1866         * annotate.c (annotate_breakpoints_invalid): Make use of
1867         scoped_restore_terminal_state.
1868         (annotate_frames_invalid): Likewise.
1869
1870 2019-06-14  Tom Tromey  <tromey@adacore.com>
1871
1872         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
1873         allow assignment to an internalvar.
1874
1875 2019-06-14  Tom Tromey  <tromey@adacore.com>
1876
1877         * ada-lex.l: Allow "_" in attribute names.
1878
1879 2019-06-14  Tom Tromey  <tromey@adacore.com>
1880
1881         PR gdb/24653:
1882         * regcache.c (registers_changed): Don't call alloca.
1883         * top.c (execute_command): Don't call alloca.
1884
1885 2019-06-13  Pedro Alves  <palves@redhat.com>
1886
1887         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
1888         'expression'.  When parsing an expression, error out if there's
1889         junk after "unlimited".
1890         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1891         (do_set_command): Adjust calls to is_unlimited_literal.
1892
1893 2019-06-13  Pedro Alves  <palves@redhat.com>
1894
1895         * compile/compile.c (make_compile_options_def_group): Add braces
1896         around array_view initializer.
1897         * thread.c (make_thread_apply_all_options_def_group)
1898         (make_thread_apply_all_options_def_group): Likewise.
1899
1900 2019-06-13  Pedro Alves  <palves@redhat.com>
1901
1902         * NEWS (New commands): Mention "maint test-options
1903         require-delimiter", "maint test-options unknown-is-error", "maint
1904         test-options unknown-is-operand" and "maint show
1905         test-options-completion-result".
1906         (New command options, command completion): New section.
1907         (Completion improvements): New section.
1908         Mention that you can abbreviate "unlimited".
1909
1910 2019-06-13  Pedro Alves  <palves@redhat.com>
1911
1912         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
1913         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
1914         * unittests/cli-utils-selftests.c (test_parse_flags)
1915         (test_parse_flags_qcs): Delete.
1916         (test_cli_utils): Don't call deleted functions.
1917
1918 2019-06-13  Pedro Alves  <palves@redhat.com>
1919
1920         * thread.c: Include "cli/cli-option.h".
1921         (tp_array_compar_ascending): Global.
1922         (tp_array_compar): Delete function.
1923         (tp_array_compar_ascending, tp_array_compar_descending): New
1924         functions.
1925         (ascending_option_def, qcs_flag_option_def)
1926         (thr_qcs_flags_option_defs)
1927         (make_thread_apply_all_options_def_group)
1928         (make_thread_apply_options_def_group): New.
1929         (thread_apply_all_command): Use gdb::option::process_options.
1930         (thread_apply_command_completer)
1931         (thread_apply_all_command_completer): New.
1932         (thread_apply_command): Use gdb::option::process_options.
1933         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
1934         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
1935         to generate help text of "thread apply".  Adjust "taas"'s help.
1936         * tid-parse.c (tid_range_parser::in_thread_range): New method.
1937         * tid-parse.h (tid_range_parser::in_thread_range): New method.
1938
1939 2019-06-13  Pedro Alves  <palves@redhat.com>
1940
1941         * thread.c (thread_apply_command): Check for invalid TID with
1942         isdigit instead of !isalpha.
1943
1944 2019-06-13  Pedro Alves  <palves@redhat.com>
1945
1946         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
1947         (validate_flags_qcs): New.
1948         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
1949         (validate_flags_qcs): Declare.
1950         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
1951         (make_frame_apply_options_def_group): New.
1952         (frame_apply_command_count): Process options with
1953         gdb::option::process_options.
1954         (frame_apply_completer): New.
1955         (frame_apply_level_completer, frame_apply_all_completer)
1956         (frame_apply_completer): New.
1957         (_initialize_stack): Update help of "frame apply", "frame apply
1958         level", "frame apply all" and "faas" to mention supported options
1959         and install command completers.
1960         * stack.h (frame_apply_all_completer): Declare.
1961         * thread.c: Include "stack.h".
1962         (tfaas_command): Add "--".
1963         (_initialize_thread): Update help "tfaas" to mention supported
1964         options and install command completer.
1965
1966 2019-06-13  Pedro Alves  <palves@redhat.com>
1967
1968         * completer.c (complete_nested_command_line): New.
1969         (gdb_completion_word_break_characters_throw): Add assertion.
1970         * completer.h (complete_nested_command_line): Declare.
1971
1972 2019-06-13  Pedro Alves  <palves@redhat.com>
1973
1974         * stack.c (parse_backtrace_qualifiers): New.
1975         (backtrace_command): Use it.
1976         (backtrace_command_completer): Complete on qualifiers.
1977
1978 2019-06-13  Pedro Alves  <palves@redhat.com>
1979
1980         * frame.c: Include "cli/cli-option.h.
1981         (user_set_backtrace_options): New.
1982         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
1983         Delete.
1984         (get_prev_frame): Adjust.
1985         (boolean_option_def, uinteger_option_def)
1986         (set_backtrace_option_defs): New.
1987         (_initialize_frame): Adjust and use
1988         gdb::option::add_setshow_cmds_for_options to install "set
1989         backtrace past-main" and "set backtrace past-entry".
1990         * frame.h: Include "cli/cli-option.h".
1991         (struct frame_print_options): Forward declare.
1992         (print_frame_arguments_all, print_frame_arguments_scalars)
1993         (print_frame_arguments_none): Declare.
1994         (print_entry_values): Delete declaration.
1995         (struct frame_print_options, user_frame_print_options): New.
1996         (struct set_backtrace_options): New.
1997         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
1998         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
1999         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2000         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2001         (list_args_or_locals): Add frame_print_options parameter.
2002         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2003         * python/py-framefilter.c (enumerate_args): Pass down
2004         USER_FRAME_PRINT_OPTIONS.
2005         * stack.c: Include "cli/cli-option.h".
2006         (print_frame_arguments_all, print_frame_arguments_scalars)
2007         (print_frame_arguments_none): Declare.
2008         (print_raw_frame_arguments, print_entry_values): Delete.
2009         (user_frame_print_options): New.
2010         (boolean_option_def, enum_option_def, frame_print_option_defs):
2011         New.
2012         (struct backtrace_cmd_options): New.
2013         (bt_flag_option_def): New.
2014         (backtrace_command_option_defs): New.
2015         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2016         (print_frame_arg, read_frame_arg, print_frame_args)
2017         (print_frame_info, print_frame): Add frame_print_options parameter
2018         and use it.
2019         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2020         (backtrace_command_1): Add frame_print_options and
2021         backtrace_cmd_options parameters and use them.
2022         (make_backtrace_options_def_group): New.
2023         (backtrace_command): Process command options with
2024         gdb::option::process_options.
2025         (backtrace_command_completer): New.
2026         (_initialize_stack): Extend "backtrace"'s help to mention
2027         supported options.  Install completer for "backtrace".
2028         Install some settings commands with add_setshow_cmds_for_options.
2029
2030 2019-06-13  Pedro Alves  <palves@redhat.com>
2031
2032         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2033         and that "set/show print raw frame-arguments" are now deprecated.
2034
2035         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2036         command.
2037         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2038         * stack.c (_initialize_stack): Install "set/show print
2039         raw-frame-arguments", and deprecate "set/show print raw
2040         frame-arguments".
2041         * valprint.c (_initialize_valprint): Deprecate "set/show print
2042         raw".
2043
2044 2019-06-13  Pedro Alves  <palves@redhat.com>
2045
2046         * compile/compile.c (struct compile_options): New.
2047         (compile_flag_option_def, compile_command_option_defs)
2048         (make_compile_options_def_group): New.
2049         (compile_file_command): Handle options with
2050         gdb::option::process_options.
2051         (compile_file_command_completer): New function.
2052         (compile_code_command): Handle options with
2053         gdb::option::process_options.
2054         (compile_code_command_completer): New function.
2055         (_initialize_compiler): Install completers for "compile code" and
2056         "compile file".  Mention available options in "compile code" and
2057         "compile code"'s help.
2058         * completer.c (advance_to_completion_word): New, factored out from
2059         ...
2060         (advance_to_expression_complete_word_point): ... this.
2061         (advance_to_filename_complete_word_point): New.
2062         * completer.h (advance_to_filename_complete_word_point): New
2063         declaration.
2064
2065 2019-06-13  Pedro Alves  <palves@redhat.com>
2066
2067         * compile/compile.c: Include "cli/cli-option.h".
2068         (compile_print_value): Scope data pointer is now a
2069         value_print_options pointer; adjust.
2070         (compile_print_command): Process options.  Scope data pointer is
2071         now a value_print_options pointer; adjust.
2072         (_initialize_compile): Update "compile print"'s help to include
2073         supported options.  Install a completer for "compile print".
2074         * cp-valprint.c (show_vtblprint, show_objectprint)
2075         (show_static_field_print): Delete.
2076         (_initialize_cp_valprint): Don't install "set print
2077         static-members", "set print vtbl", "set print object" here.
2078         * printcmd.c: Include "cli/cli-option.h" and
2079         "common/gdb_optional.h".
2080         (print_command_parse_format): Rework to fill in a
2081         value_print_options instead of a format_data.
2082         (print_value): Change parameter type from format_data pointer to
2083         value_print_options reference.  Adjust.
2084         (print_command_1): Process options.  Adjust to pass down a
2085         value_print_options.
2086         (print_command_completer): New.
2087         (_initialize_printcmd): Install print_command_completer as
2088         handle_brkchars completer for the "print" command.  Update
2089         "print"'s help to include supported options.
2090         * valprint.c: Include "cli/cli-option.h".
2091         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2092         here from cp-valprint.c.
2093         (boolean_option_def, uinteger_option_def)
2094         (value_print_option_defs, make_value_print_options_def_group):
2095         New.  Use gdb::option::add_setshow_cmds_for_options to install
2096         "set print elements", "set print null-stop", "set print repeats",
2097         "set print pretty", "set print union", "set print array", "set
2098         print address", "set print symbol", "set print array-indexes".
2099         * valprint.h: Include <string> and "cli/cli-option.h".
2100         (make_value_print_options_def_group): Declare.
2101         (print_value): Change parameter type from format_data pointer to
2102         value_print_options reference.
2103         (print_command_completer): Declare.
2104
2105 2019-06-13  Pedro Alves  <palves@redhat.com>
2106
2107         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2108         (COMMON_SFILES): Add maint-test-settings.c.
2109         * cli/cli-decode.c (boolean_enums): New global, factored out from
2110         ...
2111         (add_setshow_boolean_cmd): ... here.
2112         * cli/cli-decode.h (boolean_enums): Declare.
2113         * cli/cli-option.c: New file.
2114         * cli/cli-option.h: New file.
2115         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2116         factored out from ...
2117         (parse_cli_boolean_value(const char *)): ... this.
2118         (is_unlimited_literal): Change parameter type to pointer to
2119         pointer.  Adjust and advance ARG pointer.
2120         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2121         (parse_cli_var_enum): New, factored out from ...
2122         (do_set_command): ... this.  Adjust.
2123         * cli/cli-setshow.h (parse_cli_boolean_value)
2124         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2125         (parse_cli_var_enum): Declare.
2126         * cli/cli-utils.c: Include "cli/cli-option.h".
2127         (get_ulongest): New.
2128         * cli/cli-utils.h (get_ulongest): Declare.
2129         (check_for_argument): New overloads.
2130         * maint-test-options.c: New file.
2131
2132 2019-06-13  Pedro Alves  <palves@redhat.com>
2133
2134         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2135         parse a range if "-" is at the end of the string.
2136
2137 2019-06-13  Pedro Alves  <palves@redhat.com>
2138
2139         * cli/cli-setshow.c (parse_auto_binary_operation)
2140         (parse_cli_boolean_value): Don't allow "o".
2141
2142 2019-06-13  Pedro Alves  <palves@redhat.com>
2143
2144         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2145         * NEWS: Mention maint test-settings KIND.
2146         * maint-test-settings.c: New file.
2147
2148 2019-06-13  Pedro Alves  <palves@redhat.com>
2149
2150         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2151         completer.
2152         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2153         "set" completers.
2154
2155 2019-06-13  Pedro Alves  <palves@redhat.com>
2156
2157         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2158         after item.
2159
2160 2019-06-13  Pedro Alves  <palves@redhat.com>
2161
2162         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2163
2164 2019-06-13  Pedro Alves <palves@redhat.com>
2165
2166         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2167         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2168         call.
2169         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2170         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2171         calls.
2172         (check_for_argument): Skip spaces after argument.
2173
2174 2019-06-13  Pedro Alves  <palves@redhat.com>
2175
2176         * thread.c (thread_apply_command): Adjust TID parsing.
2177         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2178         detected before end of string.
2179         (tid_is_in_list): Error out if LIST is invalid.
2180
2181 2019-06-13  Pedro Alves  <palves@redhat.com>
2182
2183         * completer.c (complete_line_internal_1): Rewind completion word
2184         point.
2185         (completion_tracker::advance_custom_word_point_by): Change
2186         parameter type to int.
2187         * completer.h (completion_tracker::advance_custom_word_point_by):
2188         Likewise.
2189
2190 2019-06-13  Pedro Alves  <palves@redhat.com>
2191
2192         * completer.c (advance_to_completion_word): Handle delimiters.
2193
2194 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2195
2196         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2197
2198 2019-06-11  Tom Tromey  <tom@tromey.com>
2199
2200         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2201         (xmalloc_failed): Move to alloc.c.
2202         * alloc.c: New file.
2203         * Makefile.in (COMMON_SFILES): Add alloc.c.
2204
2205 2019-06-11  Tom Tromey  <tom@tromey.com>
2206
2207         * nat/linux-waitpid.c: Don't include server.h.
2208         (linux_debug): Remove.
2209         (my_waitpid): Update.
2210
2211 2019-06-11  Tom Tromey  <tromey@adacore.com>
2212
2213         * infcall.c (_initialize_infcall): Remove trailing newline from
2214         help.
2215         * user-regs.c (_initialize_user_regs): Remove trailing newline
2216         from help.
2217         * typeprint.c (_initialize_typeprint): Remove trailing newline
2218         from help.
2219         * reverse.c (_initialize_reverse): Remove trailing newlines from
2220         help.
2221         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2222         from help.
2223         * language.c (add_set_language_command): Remove trailing newline
2224         from help.
2225         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2226         help.
2227         * disasm.c (_initialize_disasm): Remove trailing newline from
2228         help.
2229         * top.c (init_main): Remove trailing newline from help.
2230         * interps.c (_initialize_interpreter): Remove trailing newline
2231         from help.
2232         * btrace.c (_initialize_btrace): Remove trailing newlines from
2233         help.
2234         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2235         from help.
2236         * python/python.c (_initialize_python): Remove trailing newline
2237         from help.
2238         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2239         help.
2240         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2241         from help.  Reformat some text.
2242         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2243         from help.
2244         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2245         newline from help.
2246
2247 2019-06-11  Tom Tromey  <tromey@adacore.com>
2248
2249         * darwin-nat.c (darwin_decode_exception_message)
2250         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2251
2252 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2253
2254         * valops.c (value_slice): Check for not allocated or not
2255         associated values.
2256
2257 2019-06-10  Tom de Vries  <tdevries@suse.de>
2258
2259         PR gdb/24618
2260         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2261         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2262         invalid.
2263
2264 2019-06-10  Tom de Vries  <tdevries@suse.de>
2265
2266         PR gdb/24611
2267         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2268         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2269
2270 2019-06-10  Tom de Vries  <tdevries@suse.de>
2271
2272         PR symtab/24545
2273         * symtab.c (struct demangled_name_entry): Add language field.
2274         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2275         static minimal symbol".  Set and use language field.
2276
2277 2019-06-10  Tom Tromey  <tromey@adacore.com>
2278
2279         * ada-lang.c (_initialize_ada_language): Update help text.
2280
2281 2019-06-10  Tom Tromey  <tromey@adacore.com>
2282
2283         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2284         with a newline.
2285         * guile/guile.c (handle_boot_error): Don't end warning with a
2286         newline.
2287         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2288         warning with a newline.
2289         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2290         newline.
2291         (s12z_frame_cache): Likewise.
2292         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2293         a newline.
2294         * solib-svr4.c (disable_probes_interface): Don't end warning with
2295         a newline.
2296         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2297         newline.
2298         * python/python.c (do_finish_initialization): Don't end warning
2299         with a newline.
2300
2301 2019-06-10  Tom Tromey  <tom@tromey.com>
2302
2303         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2304         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2305         gdbpy_enter.
2306
2307 2019-06-10  Tom Tromey  <tromey@adacore.com>
2308
2309         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2310         data.
2311         (elf_new_init): Don't call stabsread_new_init.
2312         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2313         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2314         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2315
2316 2019-06-10  Tom de Vries  <tdevries@suse.de>
2317
2318         PR symtab/16264
2319         PR symtab/24517
2320         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2321
2322 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2323
2324         * source.c (find_and_open_source): Also rewrite relative file
2325         names.
2326
2327 2019-04-26  Amos Bird  <amosbird@gmail.com>
2328
2329         * annotate.c (annotate_thread_exited): Add "thread-exited"
2330         annotation.
2331
2332 2019-06-06  Tom Tromey  <tromey@adacore.com>
2333
2334         * maint.h (class scoped_command_stats): Use
2335         DISABLE_COPY_AND_ASSIGN.
2336         <print_time>: New method.
2337         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2338         print_time.
2339         (scoped_command_stats::print_time): New method.
2340
2341 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2342
2343         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2344         instructions of lengths 6 or 8 bytes.
2345
2346 2019-06-04  Pedro Alves  <palves@redhat.com>
2347
2348         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2349
2350         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2351         * breakpoint.c (condition_completer): Likewise.
2352         * cli/cli-dump.c (scan_expression): Likewise.
2353         * common/filestuff.c (mkdir_recursive): Likewise.
2354         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2355         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2356         (gdb_abspath): Likewise.
2357         * compile/compile-cplus-types.c
2358         (compile_cplus_instance::decl_name): Likewise.
2359         * completer.c (complete_explicit_location):
2360         (signal_completer, reg_or_group_completer_1): Likewise.
2361         * cp-support.c (cp_remove_params_if_any): Likewise.
2362         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2363         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2364         * infcmd.c (strip_bg_char): Likewise.
2365         * linespec.c (copy_token_string): Likewise.
2366         * mi/mi-main.c (output_cores): Likewise.
2367         * psymtab.c (psymtab_search_name):
2368         * symfile.c (test_set_ext_lang_command): Likewise.
2369         * target.c (target_fileio_read_stralloc): Likewise.
2370         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2371         * value.c (complete_internalvar): Likewise.
2372
2373 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2374
2375         Add objfile property to gdb.Type.
2376         * NEWS: Mention Python API addition.
2377         * python/py-type.c (typy_get_objfile): New method.
2378
2379 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2380
2381         * NEWS: Mention the new set|show style [title|highlight].
2382         Mention changes to "show style", "help" and "apropos".
2383
2384 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2385
2386         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2387         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2388         instead of print_help_for_command.
2389         (print_doc_of_command): New function.
2390         (help_list): Add 'apropos -v word' suggestion.
2391         (print_help_for_command): Style the command name using title style.
2392         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2393         (_initialize_cli_cmds): Describe -v in apropos_command help.
2394
2395 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2396
2397         * cli/cli-style.h (cli_style_option): Add name in constructor,
2398         add m_name class member, add constructor with intensity,
2399         add name class function.
2400         (cli_style_option::add_setshow_commands): Remove name argument.
2401         (highlight_style, title_style): New styles.
2402         * cli/cli-style.c (do_show): New function that shows a style
2403         characteristic styling the style name with itself.
2404         (set_style_name): New function.
2405         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2406         Update all callers according to the changes in cli/cli-style.h.
2407         * utils.h (fputs_highlighted): New function.
2408         * utils.c (fputs_highlighted): Likewise.
2409
2410 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2411
2412         * NEWS: Mention new pipe command and new convenience variables.
2413
2414 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2415
2416         * cli/cli-cmds.c (pipe_command): New function.
2417         (_initialize_cli_cmds): Call add_com for pipe_command.
2418         Define | as an alias for pipe.
2419         (exit_status_set_internal_vars): New function.
2420         (shell_escape): Call exit_status_set_internal_vars.
2421         cli/cli-decode.c (find_command_name_length): Recognize | as
2422         a single character command.
2423
2424 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2425
2426         * gdbcmd.h (execute_command_to_ui_file): New declaration.
2427         top.c (execute_command_to_ui_file): New function, mostly a copy
2428         of execute_command_to_string.
2429         (execute_command_to_string): Implement by calling
2430         execute_command_to_ui_file.
2431
2432 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2433
2434         * top.h (saved_command_line): Remove declaration.
2435         * top.c (previous_saved_command_line, previous_repeat_arguments):
2436         New variables.
2437         (saved_command_line): Make static, define together with other
2438         'repeat variables'.
2439         (dont_repeat): Clear repeat_arguments.
2440         (repeat_previous, get_saved_command_line, save_command_line):
2441         New functions.
2442         (gdb_init): Initialize saved_command_line
2443         and previous_saved_command_line.
2444         * main.c (captured_main_1): Remove saved_command_line initialization.
2445         * event-top.c (handle_line_of_input): Update to use
2446         the new 'repeat' related functions instead of direct access to
2447         saved_command_line.
2448         * command.h (repeat_previous, get_saved_command_line,
2449         save_command_line): New declarations.
2450         (dont_repeat): Add comment.
2451
2452 2019-05-30  Tom Tromey  <tromey@adacore.com>
2453
2454         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
2455         Fix comment.
2456         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
2457
2458 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
2459
2460         PR cli/24587
2461         * completer.c (complete): Initialize variable word.
2462
2463 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
2464
2465         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2466         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
2467         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
2468         'body' is NULL to the outter 'if', protecting the '!is_define'
2469         situation as well.
2470
2471 2019-05-29  Tom Tromey  <tromey@adacore.com>
2472
2473         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
2474         (dwarf_unknown): New function.
2475         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
2476         (dwarf_type_encoding_name): Use dwarf_unknown.
2477
2478 2019-05-29  Tom Tromey  <tromey@adacore.com>
2479
2480         PR c++/20020:
2481         * cp-valprint.c (cp_print_value_fields): Call
2482         cp_print_static_field inside "try".
2483
2484 2019-05-29  Tom Tromey  <tromey@adacore.com>
2485
2486         * inflow.c (struct terminal_info): Add default operator=.
2487         * configure: Rebuild.
2488         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
2489         -Wdeprecated-copy-dtor, -Wredundant-move.
2490
2491 2019-05-29  Tom Tromey  <tromey@adacore.com>
2492
2493         * NEWS: Add entry.
2494         * infcmd.c (print_return_value_1): Handle finish_print
2495         option.
2496         (show_print_finish): New function.
2497         (_initialize_infcmd): Add "set/show print finish" commands.
2498         * valprint.c (user_print_options): Initialize new member.
2499         * valprint.h (struct value_print_options) <finish_print>: New
2500         member.
2501
2502 2019-05-28  Tom Tromey  <tromey@adacore.com>
2503
2504         * ada-lang.c (ada_remove_Xbn_suffix)
2505         (find_old_style_renaming_symbol)
2506         (parse_old_style_renaming): Remove.
2507         (ada_find_renaming_symbol): Don't call
2508         find_old_style_renaming_symbol.
2509         (ada_is_renaming_symbol): Rename from
2510         ada_find_renaming_symbol.  Remove "block" parameter.  Return
2511         bool.  Now static.
2512         (ada_read_var_value): Update and simplify.
2513         * ada-exp.y (write_var_or_type): Remove old code.
2514
2515 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
2516
2517         * event-top.c: Remove include comment.
2518         * inflow.c (class scoped_ignore_sigttou): Move from here...
2519         * inflow.h (class scoped_ignore_sigttou): ...to here.
2520         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
2521         * top.c:  Remove include comment.
2522
2523 2019-05-27  Tom Tromey  <tom@tromey.com>
2524
2525         * NEWS: Fix typo.
2526
2527 2019-05-22  Tom Tromey  <tromey@adacore.com>
2528
2529         * target.c (target_follow_exec): Constify parameter.
2530         * target-delegates.c: Rebuild.
2531         * remote.c (remote_target::follow_exec): Constify parameter.
2532         * infrun.c (follow_exec): Constify parameter.
2533         * target.h (struct target_ops) <follow_exec>: Constify parameter.
2534         (target_follow_exec): Likewise.
2535
2536 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2537
2538         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
2539         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
2540
2541 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2542
2543         * NEWS: Add debugredirect and testsuite sections.
2544
2545 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
2546
2547         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
2548         target descriptions using exclusively floating point register name
2549         aliases.
2550
2551 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2552
2553         PR gdb/18644:
2554         * f-lang.c (build_fortran_types): Handle the case where
2555         gdbarch_floatformat_for_type returns a nullptr.
2556
2557 2019-05-21  Tom de Vries  <tdevries@suse.de>
2558
2559         PR cli/24587
2560         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
2561
2562 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2563
2564         PR gdb/18644:
2565         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
2566         16-byte floats.
2567         * i386-tdep.c (i386_floatformat_for_type): Use
2568         floatformats_ia64_quad for the 16-byte floating point component
2569         within a fortran 32-byte complex number.
2570
2571 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2572
2573         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
2574         delete default constructor.
2575         (find_partial_die): Update to return const struct.
2576         (partial_die_parent_scope): Move variable declaration into scope
2577         of its use and change its type to auto.
2578         (guess_partial_die_structure_name): Likewise.
2579         (partial_die_info::fixup): Likewise.
2580
2581 2019-05-17  Tom Tromey  <tromey@adacore.com>
2582
2583         * source.c (find_and_open_source): Remove cast.
2584
2585 2019-05-17  Tom Tromey  <tromey@adacore.com>
2586
2587         * annotate.c (annotate_source): Make "filename" const.
2588         * annotate.h (annotate_source): Use const.
2589
2590 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2591
2592         * disasm.c (set_disassembler_options): Send errors to stderr.
2593
2594 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2595
2596         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
2597         (cli_interp_base::set_logging): Check debug_redirect.
2598         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
2599         * cli/cli-logging.c (debug_redirect): Add static variable.
2600         (pop_output_files): Add default param.
2601         (handle_redirections): Print debug setting.
2602         (show_logging_command): Likewise.
2603         (_initialize_cli_logging): Add debugredirect command.
2604         * interps.c (current_interp_set_logging): Add debug_redirect
2605         parameter.
2606         * interps.h (set_logging): Add debug_redirect parameter.
2607         (current_interp_set_logging): Likewise.
2608         * mi/mi-common.h: Likewise.
2609         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
2610
2611 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2612             Tom Tromey  <tromey@adacore.com>
2613
2614         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
2615         directly.
2616         * cli/cli-interp.h (make_logging_output): Remove declaration.
2617         * cli/cli-logging.c (make_logging_output): Remove function.
2618         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
2619         directly.
2620         * ui-file.c (tee_file::tee_file): Remove bools.
2621         (tee_file::~tee_file): Remove deletes.
2622         * ui-file.h (tee_file): Remove bools.
2623
2624 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
2625
2626         * mi/mi-cmds.h (mi_cmd_complete): New function.
2627         * mi/mi-main.c (mi_cmd_complete): Likewise.
2628         * mi/mi-cmds.c: Define new MI command -complete.
2629         * NEWS: Mention new -complete command.
2630
2631 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
2632
2633         * completer.h (complete): New function.
2634         * completer.c (complete): Likewise.
2635         * cli/cli-cmds.c: (complete_command): Update to use new complete()
2636         function defined in completer.h.
2637
2638 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
2639
2640         * MAINTAINERS (Write After Approval): Add myself.
2641
2642 2019-05-17  Tom de Vries  <tdevries@suse.de>
2643
2644         PR gdb/24094
2645         * dwarf2read.c (struct cu_partial_die_info): New struct.
2646         (find_partial_die): Return cu_partial_die_info.
2647         (partial_die_parent_scope, guess_partial_die_structure_name)
2648         (partial_die_info::fixup): Handle new return type of find_partial_die.
2649
2650 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2651
2652         * stap-probe.c (stap_parse_register_operand): Make "regname" an
2653         "std::string", simplifying the algorithm.
2654
2655 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2656
2657         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2658         (stap_static_probe_ops::get_probes): Likewise.
2659
2660 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2661
2662         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2663         '-')" and "else if".
2664         (stap_parse_single_operand): Join checks for
2665         "gdbarch_stap_parse_special_token_p" and
2666         "gdbarch_stap_parse_special_token" in the same "if" statement.
2667         Invert check when verifying for operation on register
2668         displacement.
2669
2670 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2671
2672         * stap-probe.c (stap_get_opcode): Update comment.
2673         (stap_get_expected_argument_type): Likewise.
2674         (handle_stap_probe): Likewise.
2675
2676 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2677
2678         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2679         return type to 'bool'.  Adjust comment.  Use 'bool' when
2680         appropriate.
2681         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2682         * stap-probe.c (stap_parse_argument_1): Likewise.
2683         (stap_is_operator): Likewise.
2684         (stap_is_generic_prefix): Likewise.
2685         (stap_is_register_prefix): Likewise.
2686         (stap_is_register_indirection_prefix): Likewise.
2687         (stap_is_integer_prefix): Likewise.
2688         (stap_generic_check_suffix): Likewise.
2689         (stap_check_integer_suffix): Likewise.
2690         (stap_check_register_suffix): Likewise.
2691         (stap_check_register_indirection_suffix): Likewise.
2692         (stap_parse_register_operand): Likewise.
2693         (stap_parse_single_operand): Likewise.
2694         (stap_parse_argument_1): Likewise.
2695         (stap_probe::get_argument_count): Likewise.
2696         (stap_is_operator): Likewise.
2697
2698 2019-05-16  Tom Tromey  <tromey@adacore.com>
2699
2700         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2701         keyword to foreach.
2702
2703 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
2704
2705         * linux-thread-db.c (try_thread_db_load_1): Change return type
2706         to bool.
2707         (try_thread_db_load): Likewise.
2708         (try_thread_db_load_from_pdir_1): Likewise.
2709         (try_thread_db_load_from_pdir): Likewise.
2710         (try_thread_db_load_from_sdir): Likewise.
2711         (try_thread_db_load_from_dir): Likewise.
2712         (thread_db_load_search): Likewise.
2713         (has_libpthread): Likewise.
2714         (thread_db_load): Likewise.
2715
2716 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
2717
2718         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2719         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2720         NULL, and complain/return if that's the case.
2721
2722 2019-05-15  John Darrington <john@darrington.wattle.id.au>
2723
2724         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2725         (advance, posn, abstract_read_memory): New functions.
2726         [struct mem_read_abstraction]: New struct.
2727         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
2728
2729 2019-05-14  Tom Tromey  <tromey@adacore.com>
2730
2731         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
2732         value is not lval_memory.
2733
2734 2019-05-14  Tom Tromey  <tromey@adacore.com>
2735
2736         * solib.c (info_sharedlibrary_command): Style the file name.
2737
2738 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
2739
2740         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
2741         (aarch64_vnv_type): Likewise.
2742         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
2743         * common/tdesc.c: Likewise.
2744         * common/tdesc.h (enum tdesc_type_kind): Likewise.
2745         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
2746         * features/aarch64-fpu.xml: Add ieee half view.
2747         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
2748         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
2749         * gdbtypes.h (struct builtin_type): Likewise.
2750         (struct objfile_type): Likewise.
2751
2752 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
2753
2754         * language.c (language_sniff_from_mangled_name): Fix "langauge"
2755         typo.
2756         * location.h (string_to_event_location): Likewise.
2757
2758 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
2759
2760         GDB 8.3 released.
2761
2762 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2763
2764         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
2765         New variable declaration.
2766         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
2767         New variable.
2768         (print_one_breakpoint): Use ui_out::test_flags and new global
2769         variable to compute use_fixed_output.
2770         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
2771         Remove.
2772         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
2773         (mi_multi_location_breakpoint_output_fixed): Remove.
2774         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
2775         new variable.
2776         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
2777         fix_multi_location_breakpoint_output flag if version >= 3.
2778         * ui-out.h (enum ui_out_flag)
2779         <fix_multi_location_breakpoint_output>: New enumerator.
2780
2781 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2782
2783         * contrib/cc-with-tweaks.sh: Validate dwz's work.
2784
2785 2019-05-10  Tom Tromey  <tromey@adacore.com>
2786
2787         * ada-lang.c (catch_ada_completer): New function.
2788         (_initialize_ada_language): Use it.
2789
2790 2019-05-10  Tom Tromey  <tromey@adacore.com>
2791
2792         * thread.c (print_thread_info): Make "requested_threads" const.
2793         * gdbthread.h (print_thread_info): Make "requested_threads"
2794         const.
2795         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
2796         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
2797
2798 2019-05-08  Tom Tromey  <tom@tromey.com>
2799
2800         * gdbtypes.c (objfile_type_data): Change type.
2801         (objfile_type, _initialize_gdbtypes): Update.
2802
2803 2019-05-08  Tom Tromey  <tom@tromey.com>
2804
2805         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
2806         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
2807         (_initialize_dwarf2_frame): Update.
2808
2809 2019-05-08  Tom Tromey  <tom@tromey.com>
2810
2811         * objc-lang.c (objc_objfile_data): Change type.
2812         (find_methods): Update.
2813         (_initialize_objc_lang): Remove.
2814
2815 2019-05-08  Tom Tromey  <tom@tromey.com>
2816
2817         * stabsread.c (rs6000_builtin_type_data): Change type.
2818         (rs6000_builtin_type, _initialize_stabsread): Update.
2819
2820 2019-05-08  Tom Tromey  <tom@tromey.com>
2821
2822         * mips-tdep.c (mips_pdr_data): Remove.
2823         (_initialize_mips_tdep): Update.
2824
2825 2019-05-08  Tom Tromey  <tom@tromey.com>
2826
2827         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
2828         (hppa_init_objfile_priv_data, read_unwind_info)
2829         (find_unwind_entry, _initialize_hppa_tdep): Update.
2830
2831 2019-05-08  Tom Tromey  <tom@tromey.com>
2832
2833         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
2834         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
2835         on obstack.
2836         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
2837
2838 2019-05-08  Tom Tromey  <tom@tromey.com>
2839
2840         * mdebugread.c (basic_type_data): Change type.
2841         (basic_type, _initialize_mdebugread): Update.
2842
2843 2019-05-08  Tom Tromey  <tom@tromey.com>
2844
2845         * common/gdb_unique_ptr.h (struct noop_deleter): New.
2846
2847 2019-05-08  Tom Tromey  <tom@tromey.com>
2848
2849         * nto-tdep.c (nto_inferior_data_reg): Change type.
2850         (nto_inferior_data): Update.
2851         (nto_inferior_data_cleanup, nto_new_inferior_data)
2852         (_initialize_nto_tdep): Remove.
2853         * nto-tdep.h (struct nto_inferior_data): Add initializers.
2854
2855 2019-05-08  Tom Tromey  <tom@tromey.com>
2856
2857         * ada-lang.c (struct ada_inferior_data): Add initializers.
2858         (ada_inferior_data): Change type.
2859         (ada_inferior_data_cleanup): Remove.
2860         (get_ada_inferior_data, ada_inferior_exit)
2861         (struct ada_pspace_data): Add initializers, destructor.
2862         (ada_pspace_data_handle): Change type.
2863         (get_ada_pspace_data): Update.
2864         (ada_pspace_data_cleanup): Remove.
2865
2866 2019-05-08  Tom Tromey  <tom@tromey.com>
2867
2868         * coffread.c (struct coff_symfile_info): Add initializers.
2869         (coff_objfile_data_key): Move lower.  Change type.
2870         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
2871         Update.
2872         (coff_free_info): Remove.
2873
2874 2019-05-08  Tom Tromey  <tom@tromey.com>
2875
2876         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
2877         (fbsd_pspace_data_handle): Move lower.  Change type.
2878         (get_fbsd_pspace_data): Update.
2879         (fbsd_pspace_data_cleanup): Remove.
2880         (_initialize_fbsd_tdep): Update.
2881
2882 2019-05-08  Tom Tromey  <tom@tromey.com>
2883
2884         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
2885         (get_ada_tasks_pspace_data): Update.
2886         (ada_tasks_pspace_data_cleanup): Remove.
2887         (_initialize_tasks): Update.
2888         (ada_tasks_inferior_data_handle): Change type.
2889         (get_ada_tasks_inferior_data): Update.
2890         (ada_tasks_inferior_data_cleanup): Remove.
2891         (struct ada_tasks_pspace_data): Add initializers.
2892
2893 2019-05-08  Tom Tromey  <tom@tromey.com>
2894
2895         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
2896         * symfile-debug.c (debug_sym_get_probes): Change type.
2897         * stap-probe.c (handle_stap_probe):
2898         (stap_static_probe_ops::get_probes): Change type.
2899         * probe.h (class static_probe_ops) <get_probes>: Change type.
2900         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
2901         (parse_probes_in_pspace): Update.
2902         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
2903         Update.
2904         (any_static_probe_ops::get_probes): Change type.
2905         * elfread.c (elfread_data): New typedef.
2906         (probe_key): Change type.
2907         (elf_get_probes): Likewise.  Update.
2908         (probe_key_free): Remove.
2909         (_initialize_elfread): Update.
2910         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
2911         Change type.
2912         (dtrace_process_dof_probe, dtrace_process_dof)
2913         (dtrace_static_probe_ops::get_probe): Change type.
2914
2915 2019-05-08  Tom Tromey  <tom@tromey.com>
2916
2917         * xcoffread.c (struct xcoff_symfile_info): Rename from
2918         coff_symfile_info.  Add initializers.
2919         (xcoff_objfile_data_key): Move lower.  Change type.
2920         (XCOFF_DATA): Rewrite.
2921         (xcoff_free_info): Remove.
2922         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
2923         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
2924         (xcoff_initial_scan): Update.
2925
2926 2019-05-08  Tom Tromey  <tom@tromey.com>
2927
2928         * solib-svr4.c (struct svr4_info): Add initializers and
2929         destructor.
2930         <probes_table>: Now an htab_up.
2931         (solib_svr4_pspace_data): Change type.
2932         (free_probes_table): Simplify.
2933         (~svr4_info): Rename from svr4_pspace_data_cleanup.
2934         (get_svr4_info, probes_table_htab_remove_objfile_probes)
2935         (probes_table_remove_objfile_probes, register_solib_event_probe)
2936         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
2937         (_initialize_svr4_solib): Update.
2938
2939 2019-05-08  Tom Tromey  <tom@tromey.com>
2940
2941         * remote.c (remote_pspace_data): Change type.
2942         (remote_pspace_data_cleanup): Remove.
2943         (get_remote_exec_file, set_pspace_remote_exec_file)
2944         (_initialize_remote): Update.
2945
2946 2019-05-08  Tom Tromey  <tom@tromey.com>
2947
2948         * breakpoint.c (breakpoint_objfile_key): Change type.
2949         (get_breakpoint_objfile_data): Update.
2950         (free_breakpoint_objfile_data): Remove.
2951         (_initialize_breakpoint): Update.
2952
2953 2019-05-08  Tom Tromey  <tom@tromey.com>
2954
2955         * linux-tdep.c (struct linux_info): Add initializers.
2956         (linux_inferior_data): Move.  Change type.
2957         (invalidate_linux_cache_inf): Update.
2958         (linux_inferior_data_cleanup): Remove.
2959         (get_linux_inferior_data, _initialize_linux_tdep): Update.
2960
2961 2019-05-08  Tom Tromey  <tom@tromey.com>
2962
2963         * auxv.c (auxv_inferior_data): Move.  Change type.
2964         (auxv_inferior_data_cleanup): Remove.
2965         (invalidate_auxv_cache_inf): Rewrite.
2966         (get_auxv_inferior_data, _initialize_auxv): Update.
2967
2968 2019-05-08  Tom Tromey  <tom@tromey.com>
2969
2970         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
2971         (symfile_debug_objfile_data_key): Change type.
2972         (symfile_debug_installed, debug_qf_has_symbols)
2973         (debug_qf_find_last_source_symtab)
2974         (debug_qf_forget_cached_source_info)
2975         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
2976         (debug_qf_print_stats, debug_qf_dump)
2977         (debug_qf_expand_symtabs_for_function)
2978         (debug_qf_expand_all_symtabs)
2979         (debug_qf_expand_symtabs_with_fullname)
2980         (debug_qf_map_matching_symbols)
2981         (debug_qf_expand_symtabs_matching)
2982         (debug_qf_find_pc_sect_compunit_symtab)
2983         (debug_qf_map_symbol_filenames)
2984         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
2985         (debug_sym_new_init, debug_sym_init, debug_sym_read)
2986         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
2987         (debug_sym_read_linetable, debug_sym_relocate): Update.
2988         (symfile_debug_free_objfile): Remove.
2989         (install_symfile_debug_logging, _initialize_symfile_debug):
2990         Update.
2991
2992 2019-05-08  Tom Tromey  <tom@tromey.com>
2993
2994         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
2995         allocate_on_obstack.
2996         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
2997         (get_dwarf2_per_objfile): Update.
2998         (set_dwarf2_per_objfile): Remove.
2999         (dwarf2_has_info, dwarf2_get_section_info): Update.
3000         (dwarf2_free_objfile): Remove.
3001         (_initialize_dwarf2_read): Update.
3002
3003 2019-05-08  Tom Tromey  <tom@tromey.com>
3004
3005         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3006         initializers.
3007         <unsupported_script_warning_printed,
3008         script_not_found_warning_printed>: Now bool.
3009         (auto_load_pspace_data): Change type.
3010         (~auto_load_pspace_info): Rename from
3011         auto_load_pspace_data_cleanup.
3012         (get_auto_load_pspace_data, init_loaded_scripts_info)
3013         (clear_section_scripts, maybe_print_unsupported_script_warning)
3014         (maybe_print_script_not_found_warning, _initialize_auto_load):
3015         Update.
3016
3017 2019-05-08  Tom Tromey  <tom@tromey.com>
3018
3019         * objfiles.c (objfile_pspace_info): Add destructor and
3020         initializers.
3021         (objfiles_pspace_data): Change type.
3022         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3023         (get_objfile_pspace_data): Update.
3024         (objfiles_bfd_data): Change type.
3025         (get_objfile_bfd_data): Update.
3026         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3027
3028 2019-05-08  Tom Tromey  <tom@tromey.com>
3029
3030         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3031         Change type.
3032         (get_catch_syscall_inferior_data): Update.
3033         (catch_syscall_inferior_data_cleanup): Remove.
3034         (_initialize_break_catch_syscall): Update.
3035
3036 2019-05-08  Tom Tromey  <tom@tromey.com>
3037
3038         * inflow.c (struct terminal_info): Add destructor and
3039         initializers.
3040         (inflow_inferior_data): Change type.
3041         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3042         (get_inflow_inferior_data, inflow_inferior_exit)
3043         (swap_terminal_info, _initialize_inflow): Update.
3044
3045 2019-05-08  Tom Tromey  <tom@tromey.com>
3046
3047         * target-dcache.c (target_dcache_cleanup): Remove.
3048         (target_dcache_aspace_key): Change type.
3049         (target_dcache_init_p, target_dcache_invalidate)
3050         (target_dcache_get, target_dcache_get_or_init)
3051         (_initialize_target_dcache): Update.
3052         * dcache.h (struct dcache_deleter): New.
3053
3054 2019-05-08  Tom Tromey  <tom@tromey.com>
3055
3056         * symtab.c (struct symbol_cache): Add destructor and
3057         initializers.
3058         (symbol_cache_key): Move.  Change type.
3059         (make_symbol_cache, free_symbol_cache): Remove.
3060         (get_symbol_cache): Update.
3061         (symbol_cache_cleanup): Remove.
3062         (ALL_PSPACES, symbol_cache_flush)
3063         (maintenance_print_symbol_cache)
3064         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3065         Update.
3066
3067 2019-05-08  Tom Tromey  <tom@tromey.com>
3068
3069         * symtab.c (struct main_info): Add destructor and initializers.
3070         (main_progspace_key): Move.  Change type.
3071         (get_main_info): Update.
3072         (main_info_cleanup): Remove.
3073         (_initialize_symtab): Update.
3074
3075 2019-05-08  Tom Tromey  <tom@tromey.com>
3076
3077         * registry.h (DECLARE_REGISTRY): Define the _key class.
3078
3079 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3080
3081         * NEWS: Merge two 'New commands' sections.
3082
3083 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3084
3085         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3086         parameter and use Ada language definition instead.
3087         (ada_val_print_ptr): Remove unused language parameter.
3088         (ada_val_print_num): Remove language parameter and use Ada language
3089         definition instead.
3090         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3091         parameter.
3092         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3093         parameter and use Ada language definition instead.
3094         (ada_val_print_1): Update all ada_val_print_xxx calls.
3095         Remove language parameter.
3096         (ada_val_print): Update ada_val_print_1 call.
3097
3098 2019-05-08  Tom Tromey  <tromey@adacore.com>
3099
3100         * remote.c (remote_hw_watchpoint_limit)
3101         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3102         Now static.
3103
3104 2019-05-08  Tom Tromey  <tromey@adacore.com>
3105
3106         * maint.c (_initialize_maint_cmds): Move initialization code to
3107         remote.c.
3108         (watchdog, show_watchdog): Move to remote.c.
3109         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3110         "watchdog" static.
3111         (_initialize_remote): Move initialization code from maint.c.
3112         * defs.h (watchdog): Don't declare.
3113
3114 2019-05-08  Tom Tromey  <tromey@adacore.com>
3115
3116         * tui/tui-interp.c: Include main.h.
3117         * interps.c: Include main.h.
3118         * main.h (interpreter_p): Declare.
3119         * defs.h (interpreter_p): Don't declare.
3120
3121 2019-05-08  Tom Tromey  <tromey@adacore.com>
3122
3123         * dwarf2loc.c: Include dwarf2read.h.
3124         * defs.h (read_unsigned_leb128): Don't declare.
3125         * dwarf2read.h (read_unsigned_leb128): Declare.
3126
3127 2019-05-08  Tom Tromey  <tromey@adacore.com>
3128
3129         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3130         method.
3131
3132 2019-05-08  Tom Tromey  <tromey@adacore.com>
3133
3134         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3135         when no wrap column is set.
3136
3137 2019-05-08  Tom Tromey  <tromey@adacore.com>
3138
3139         * c-lang.c (c_get_string): Handle non-C-style arrays.
3140
3141 2019-05-08  Tom Tromey  <tromey@adacore.com>
3142
3143         * typeprint.c (print_offset_data::update): Print the bit offset,
3144         not the number of bits remaining.
3145
3146 2019-05-08  Tom Tromey  <tromey@adacore.com>
3147
3148         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3149         padding at end of comment.
3150
3151 2019-05-08  Tom Tromey  <tromey@adacore.com>
3152
3153         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3154         Compare main types.
3155
3156 2019-05-06  Tom Tromey  <tom@tromey.com>
3157
3158         * common/scoped_mmap.c: Include common-defs.h.
3159         * common/scoped_mmap.h: Don't include config.h.
3160
3161 2019-05-04  Tom Tromey  <tom@tromey.com>
3162
3163         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3164         (struct aarch64_call_info): Add initializers.
3165         <si>: Now a std::vector.
3166         (pass_on_stack, aarch64_push_dummy_call): Update.
3167
3168 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3169             Tom Tromey  <tom@tromey.com>
3170
3171         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3172         (ppc_threads): Now a std::vector.  Now static.
3173         (hwdebug_find_thread_points_by_tid)
3174         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3175         Update.
3176
3177 2019-05-04  Tom Tromey  <tom@tromey.com>
3178
3179         * arc-tdep.c (arc_tdesc_init): Return bool.
3180
3181 2019-05-04  Tom Tromey  <tom@tromey.com>
3182
3183         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3184         Use gdb_assert_not_reached.
3185
3186 2019-05-04  Tom Tromey  <tom@tromey.com>
3187
3188         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3189         "false".
3190
3191 2019-05-04  Tom Tromey  <tom@tromey.com>
3192
3193         * arc-tdep.c (arc_tdesc_init): Use bool.
3194
3195 2019-05-04  Tom Tromey  <tom@tromey.com>
3196
3197         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3198
3199 2019-05-04  Tom Tromey  <tom@tromey.com>
3200
3201         * cli/cli-cmds.c (valid_command_p): Return bool.
3202
3203 2019-05-04  Tom Tromey  <tom@tromey.com>
3204
3205         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3206         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3207
3208 2019-05-04  Raul Tambre  <raul@tambre.ee>
3209
3210         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3211         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3212         operator for comparison.
3213
3214 2019-05-04  Tom Tromey  <tom@tromey.com>
3215
3216         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3217         (lookup_partial_symbol, print_partial_symbols)
3218         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3219         (psymbol_compare): Update.
3220         (add_psymbol_to_bcache): Clear the entire psymbol.
3221         (maintenance_check_psymtabs): Update.
3222         * psympriv.h (struct partial_symbol): Don't derive from
3223         general_symbol_info.
3224         <obj_section, unrelocated_address, address,
3225         set_unrelocated_address>: Update.
3226         <ginfo>: New member.
3227         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3228         (debug_names::write_psymbols): Update.
3229
3230 2019-05-04  Tom de Vries  <tdevries@suse.de>
3231
3232         * contrib/cc-with-tweaks.sh: Support -n arg.
3233
3234 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3235
3236         * corelow.c (core_target::detach): Ensure frame cache and
3237         register caches are cleared.
3238         inferior.c (exit_inferior_1): Likewise.
3239
3240 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3241             Tom Tromey  <tom@tromey.com>
3242
3243         * dictionary.c (collate_pending_symbols_by_language): Remove
3244         "struct" from foreach.
3245         * symtab.c (lookup_global_symbol_from_objfile)
3246         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3247         foreach.
3248         * ser-tcp.c (net_open): Remove "struct" from foreach.
3249         * objfiles.c (objfile_relocate, objfile_rebase)
3250         (objfile_has_symbols): Remove "struct" from foreach.
3251         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3252         from foreach.
3253         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3254         foreach.
3255         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3256         "struct" from foreach.
3257         * ada-lang.c (create_excep_cond_exprs)
3258         (ada_exception_catchpoint_cond_string): Remove "struct" from
3259         foreach.
3260
3261 2019-05-03  Tom Tromey  <tromey@adacore.com>
3262
3263         * ada-exp.y (convert_char_literal): Check suffix of each
3264         enumerator.
3265
3266 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3267
3268         PR ada/21406:
3269         * ada-exp.y (yywrap): Don't define.
3270         * ada-lex.l (%option): Add noyywrap
3271         (yywrap): Remove.
3272
3273 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3274
3275         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3276         _WIN32_WINNT to the XP level, unless already defined to a higher
3277         level.
3278
3279         * unittests/parse-connection-spec-selftests.c:
3280         * ser-tcp.c:
3281         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3282         override.
3283
3284         * symfile.c (find_separate_debug_file): Remove colon from the
3285         drive spec of DOS/Windows file names of the target, so that the
3286         file name produced from DEBUGDIR and the target's directory will
3287         be valid on DOS/Windows systems.
3288
3289 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3290
3291         * rust-lang.c (val_print_struct): Handle printing structures
3292         containing strings.
3293
3294 2019-05-02  Tom Tromey  <tromey@adacore.com>
3295
3296         * valarith.c (_initialize_valarith): Remove.
3297
3298 2019-05-01  Tom Tromey  <tromey@adacore.com>
3299
3300         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3301         bitfields.
3302
3303 2019-05-01  Tom Tromey  <tromey@adacore.com>
3304
3305         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3306         for big-endian copies.
3307
3308 2019-04-30  Ali Tamur  <tamur@google.com>
3309         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3310         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3311         (read_3_bytes): New function.
3312
3313 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3314
3315         * windows-nat.c (main_thread_id): Delete.
3316         (handle_output_debug_string): Replace main_thread_id by
3317         current_event.dwThreadId.
3318         (fake_create_process): Likewise.
3319         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3320         Do not set main_thread_id.
3321         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3322         current_event.dwThreadId.
3323         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3324
3325 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3326
3327         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3328         Use current_event.dwThreadId instead of main_thread_id.
3329
3330 2019-04-30  Tom Tromey  <tromey@adacore.com>
3331
3332         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3333         (create_excep_cond_exprs): Iterate over program spaces.
3334         (ada_exception_catchpoint_cond_string): Examine all minimal
3335         symbols for exception types.
3336
3337 2019-04-30  Tom Tromey  <tromey@adacore.com>
3338
3339         PR c++/24470:
3340         * dwarf2read.c (process_structure_scope): Handle case where type
3341         has template parameters but no symbol was created.
3342
3343 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3344             Chris January  <chris.january@arm.com>
3345
3346         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3347         qualifier.
3348         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3349
3350 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3351
3352         * f-typeprint.c (f_print_type): Update rules for printing
3353         whitespace.
3354         (f_type_print_varspec_suffix): Likewise.
3355
3356 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3357             Chris January  <chris.january@arm.com>
3358
3359         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3360         function arguments.
3361
3362 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3363
3364         * f-lang.c (build_fortran_types): Change name of void type to
3365         lower case.
3366         * f-typeprint.c (f_type_print_base): Print the name of the void
3367         type, rather than a fixed string.
3368         * f-valprint.c (f_decorations): Use lower case void string.
3369
3370 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3371             Chris January  <chris.january@arm.com>
3372
3373         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3374         types for Fortran.
3375
3376 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3377             Chris January  <chris.january@arm.com>
3378             David Lecomber  <david.lecomber@arm.com>
3379
3380         * f-exp.y (BINOP_INTRINSIC): New token.
3381         (exp): New parser rule handling BINOP_INTRINSIC.
3382         (f77_keywords): Add new builtin procedures.
3383         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3384         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3385         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3386         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3387         (print_unop_subexp_f): New function.
3388         (print_binop_subexp_f): New function.
3389         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3390         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3391         (dump_subexp_body_f): Likewise.
3392         (operator_check_f): Likewise.
3393         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3394         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3395
3396 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3397
3398         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3399         UNOP_KIND.
3400         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3401         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3402         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3403         (operator_length_f): New fuction.
3404         (print_subexp_f): New function.
3405         (op_name_f): New function.
3406         (dump_subexp_body_f): New function.
3407         (operator_check_f): New function.
3408         (exp_descriptor_f): Replace standard expression handling functions
3409         with new functions.
3410         * gdb/fortran-operator.def: New file.
3411         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3412         * gdb/std-operator.def: Remove UNOP_KIND.
3413
3414 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3415
3416         * std-operator.def: Remove unbalanced, stray double quote
3417         character.
3418
3419 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3420             Chris January  <chris.january@arm.com>
3421             Daniel Everett  <daniel.everett@arm.com>
3422             Nick Forrington  <nick.forrington@arm.com>
3423             Richard Bunt  <richard.bunt@arm.com>
3424
3425         * cp-valprint.c (cp_print_value_fields): Allow an additional level
3426         of depth when printing anonymous structs or unions.
3427         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3428         Don't print either the top-level value, or the children if the
3429         max-depth is exceeded.
3430         (ppscm_print_children): When printing the key of a map, allow one
3431         extra level of depth.
3432         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3433         print either the top-level value, or the children if the max-depth
3434         is exceeded.
3435         (print_children): When printing the key of a map, allow one extra
3436         level of depth.
3437         * python/py-value.c (valpy_format_string): Add max_depth keyword.
3438         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
3439         (user_print_options): Initialise max_depth field.
3440         (val_print_scalar_or_string_type_p): New function.
3441         (val_print): Check to see if the max depth has been reached.
3442         (val_print_check_max_depth): Define new function.
3443         (show_print_max_depth): New function.
3444         (_initialize_valprint): Add 'print max-depth' option.
3445         * valprint.h (struct value_print_options) <max_depth>: New field.
3446         (val_print_check_max_depth): Declare new function.
3447         * NEWS: Document new feature.
3448
3449 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3450
3451         * ada-lang.c (ada_language_defn): Initialise new field.
3452         * c-lang.c (c_is_string_type_p): New function.
3453         (c_language_defn): Initialise new field.
3454         (cplus_language_defn): Initialise new field.
3455         (asm_language_defn): Initialise new field.
3456         (minimal_language_defn): Initialise new field.
3457         * c-lang.h (c_is_string_type_p): Declare new function.
3458         * d-lang.c (d_language_defn): Initialise new field.
3459         * f-lang.c (f_is_string_type_p): New function.
3460         (f_language_defn): Initialise new field.
3461         * go-lang.c (go_is_string_type_p): New function.
3462         (go_language_defn): Initialise new field.
3463         * language.c (default_is_string_type_p): New function.
3464         (unknown_language_defn): Initialise new field.
3465         (auto_language_defn): Initialise new field.
3466         * language.h (struct language_defn) <la_is_string_type_p>: New
3467         member variable.
3468         (default_is_string_type_p): Declare new function.
3469         * m2-lang.c (m2_language_defn): Initialise new field.
3470         * objc-lang.c (objc_language_defn): Initialise new field.
3471         * opencl-lang.c (opencl_language_defn): Initialise new field.
3472         * p-lang.c (pascal_is_string_type_p): New function.
3473         (pascal_language_defn): Initialise new field.
3474         * rust-lang.c (rust_is_string_type_p): New function.
3475         (rust_language_defn): Initialise new field.
3476
3477 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3478
3479         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
3480         New field.
3481         * ada-lang.c (ada_language_defn): Initialise new field.
3482         * c-lang.c (c_language_defn): Likewise.
3483         (cplus_language_defn): Likewise.
3484         (asm_language_defn): Likewise.
3485         (minimal_language_defn): Likewise.
3486         * d-lang.c (d_language_defn): Likewise.
3487         * f-lang.c (f_language_defn): Likewise.
3488         * go-lang.c (go_language_defn): Likewise.
3489         * language.c (unknown_language_defn): Likewise.
3490         (auto_language_defn): Likewise.
3491         * m2-lang.c (m2_language_defn): Likewise.
3492         * objc-lang.c (objc_language_defn): Likewise.
3493         * opencl-lang.c (opencl_language_defn): Likewise.
3494         * p-lang.c (pascal_language_defn): Likewise.
3495         * rust-lang.c (rust_language_defn): Likewise.
3496
3497 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3498
3499         * ada-lang.c (ada_is_character_type): Change return type to bool.
3500         (ada_is_string_type): Likewise.
3501         * ada-lang.h (ada_is_character_type): Update declaration
3502         (ada_is_string_type): Likewise.
3503
3504 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3505
3506         Support style in 'frame|thread apply'
3507
3508         * gdbcmd.h (execute_command_to_string): New term_out parameter.
3509         * record.c (record_start, record_stop): Update callers of
3510         execute_command_to_string with false.
3511         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
3512         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
3513         methods.
3514         (class string_file): New constructor with term_out parameter.
3515         Override methods term_out and can_emit_style_escape.  New member
3516         term_out.
3517         (class stdio_file): Override can_emit_style_escape.
3518         (class tee_file): Override term_out and can_emit_style_escape.
3519         * utils.h (can_emit_style_escape): Remove.
3520         * utils.c (can_emit_style_escape): Likewise.
3521         Update all callers of can_emit_style_escape (SOMESTREAM) to
3522         SOMESTREAM->can_emit_style_escape.
3523         * source-cache.c (source_cache::get_source_lines): Likewise.
3524         * stack.c (frame_apply_command_count): Call execute_command_to_string
3525         passing the term_out characteristic of the current gdb_stdout.
3526         * thread.c (thr_try_catch_cmd): Likewise.
3527         * top.c (execute_command_to_string): pass term_out parameter
3528         to construct the string_file for the command output.
3529         * ui-file.c (term_cli_styling): New function (most code moved
3530         from utils.c can_emit_style_escape).
3531         (string_file::string_file, string_file::can_emit_style_escape,
3532         stdio_file::can_emit_style_escape, tee_file::term_out,
3533         tee_file::can_emit_style_escape): New functions.
3534
3535 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3536
3537         * NEWS: Mention the new set|show may-call-functions.
3538         * infcall.c (may_call_functions_p): New variable.
3539         (show_may_call_functions_p): New function.
3540         (call_function_by_hand_dummy): Throws an error if not
3541         may-call-functions.
3542         (_initialize_infcall): Call add_setshow_boolean_cmd for
3543         may-call-functions.
3544
3545 2019-04-25  Keith Seitz  <keiths@redhat.com>
3546
3547         PR c++/24367
3548         * cp-support.c (inspect_type): Don't attempt substitutions
3549         of symbol with the same name.
3550
3551 2019-04-25  Tom Tromey  <tromey@adacore.com>
3552
3553         PR gdb/24475:
3554         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
3555         static.
3556
3557 2019-04-25  Tom Tromey  <tromey@adacore.com>
3558
3559         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
3560         rvalue reference.
3561         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
3562         (gdb_xml_parser::parse): Use std::move.
3563         * python/python-internal.h (gdbpy_convert_exception): Take a const
3564         reference.
3565         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
3566         std::move.
3567         * python/py-utils.c (gdbpy_convert_exception): Take a const
3568         reference.
3569         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3570         Use std::move.
3571         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3572         Use std::move.
3573         * mi/mi-main.c (mi_print_exception): Take a const reference.
3574         * main.c (handle_command_errors): Take a const reference.
3575         * linespec.c (parse_linespec): Use std::move.
3576         * infcall.c (run_inferior_call): Use std::move.
3577         (call_function_by_hand_dummy): Use std::move.
3578         * exec.c (try_open_exec_file): Use std::move.
3579         * exceptions.h (exception_print, exception_fprintf)
3580         (exception_print_same): Update.
3581         * exceptions.c (print_exception, exception_print)
3582         (exception_fprintf, exception_print_same): Change parameters to
3583         const reference.
3584         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
3585         * common/new-op.c: Use std::move.
3586         * common/common-exceptions.h (struct gdb_exception): Add move
3587         constructor.
3588         (struct gdb_exception_error, struct gdb_exception_quit, struct
3589         gdb_quit_bad_alloc): Change constructor to move constructor.
3590         (throw_exception): Change parameter to rvalue reference.
3591         * common/common-exceptions.c (throw_exception): Take rvalue
3592         reference.
3593         * cli/cli-interp.c (safe_execute_command): Use std::move.
3594         * breakpoint.c (insert_bp_location, location_to_sals): Use
3595         std::move.
3596
3597 2019-04-25  Tom Tromey  <tromey@adacore.com>
3598
3599         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
3600         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
3601         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
3602         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
3603         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
3604         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
3605         guile/scm-value.c: Use unpack.
3606         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
3607         gdbscm_gdb_exception.
3608         (gdbscm_throw_gdb_exception): Likewise.
3609         (struct gdbscm_gdb_exception): New.
3610         (unpack): New function.
3611         (gdbscm_wrap): Use unpack.
3612
3613 2019-04-25  Tom Tromey  <tromey@adacore.com>
3614
3615         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3616         (gdb_rl_callback_handler): Use std::move.
3617         * common/common-exceptions.h (struct gdb_exception): Add move
3618         assignment operator.
3619         (throw_exception_sjlj): Change "exception" to const reference.
3620         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
3621         (throw_exception_sjlj): Change "exception" to const reference.
3622
3623 2019-04-25  Tom Tromey  <tromey@adacore.com>
3624
3625         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
3626         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
3627         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3628         Update.
3629         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3630         Update.
3631         * mi/mi-interp.c (mi_interp::exec): Update.
3632         * linespec.c (parse_linespec): Update.
3633         * infcall.c (run_inferior_call): Update.
3634         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
3635         * guile/scm-symbol.c (gdbscm_lookup_symbol)
3636         (gdbscm_lookup_global_symbol): Update.
3637         * guile/scm-param.c (gdbscm_parameter_value): Update.
3638         * guile/scm-frame.c (gdbscm_frame_read_register)
3639         (gdbscm_frame_read_var): Update.
3640         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
3641         * exec.c (try_open_exec_file): Update.
3642         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3643         (gdb_rl_callback_handler): Update.
3644         * common/common-exceptions.h (exception_none): Don't declare.
3645         * common/common-exceptions.c (exception_none): Don't define.
3646         (struct catcher) <exception>: Update.
3647         * cli/cli-interp.c (safe_execute_command): Update.
3648         * breakpoint.c (insert_bp_location, location_to_sals): Update.
3649
3650 2019-04-25  Ali Tamur  <tamur@google.com>
3651
3652         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
3653         (read_attribute_value): Likewise.
3654         (dwarf2_read_addr_index): Update comment.
3655         (read_str_index): Add DW_FORM_strx.
3656         (dwarf2_string_attr): Likewise.
3657         (dwarf2_const_value_attr): Likewise.
3658         (dump_die_shallow): Likewise.
3659         (dwarf2_fetch_constant_bytes): Likewise.
3660         (skip_form_bytes): Likewise.
3661         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3662
3663 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
3664
3665         PR corefiles/11608
3666         PR corefiles/18187
3667         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3668         OFFSET.  Verify if current mapping contains an ELF header.
3669         (linux_find_memory_regions_full): Adjust call to
3670         dump_mapping_p.
3671
3672 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
3673             Kang Li <kanglictf@gmail.com>
3674
3675         PR gdb/21600
3676
3677         * dwarf2-frame.c (read_initial_length): Be consistent about using
3678         unsigned representation of length.
3679         (decode_frame_entry_1): Likewise.  Check for wraparound of
3680         end pointer as well as buffer overflow.
3681
3682 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3683
3684         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3685         "vq".
3686
3687 2019-04-24  Tom Tromey  <tromey@adacore.com>
3688
3689         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3690
3691 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3692
3693         * s12z-tdep.c (s12z_unwind_pc): Delete.
3694         (s12z_unwind_sp): Delete.
3695         (s12z_gdbarch_init): Don't register deleted functions with
3696         gdbarch.
3697
3698 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3699
3700         * rl78-tdep.c (rl78_unwind_sp): Delete.
3701         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3702
3703 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3704
3705         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3706         (xstormy16_unwind_pc): Delete.
3707         (xstormy16_dummy_id): Delete.
3708         (xstormy16_gdbarch_init): Don't register deleted functions with
3709         gdbarch.
3710
3711 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3712
3713         * vax-tdep.c (vax_unwind_pc): Delete.
3714         (vax_gdbarch_init): Don't register deleted function with gdbarch.
3715
3716 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3717
3718         * v850-tdep.c (v850_unwind_sp): Delete.
3719         (v850_unwind_pc): Delete.
3720         (v850_dummy_id): Delete.
3721         (v850_gdbarch_init): Don't register deleted functions with
3722         gdbarch.
3723
3724 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3725
3726         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
3727         (tilegx_unwind_pc): Delete.
3728         (tilegx_unwind_dummy_id): Delete.
3729         (tilegx_gdbarch_init): Don't register deleted functions with
3730         gdbarch.
3731
3732 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3733
3734         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
3735         (tic6x_dummy_id): Delete.
3736         (tic6x_gdbarch_init): Don't register deleted functions with
3737         gdbarch.
3738
3739 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3740
3741         * sparc-tdep.c (sparc_unwind_pc): Delete.
3742         (sparc32_gdbarch_init): Don't register deleted function with
3743         gdbarch.
3744
3745 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3746
3747         * sh-tdep.c (sh_unwind_sp): Delete.
3748         (sh_unwind_pc): Delete.
3749         (sh_dummy_id): Delete.
3750         (sh_gdbarch_init): Don't register deleted functions with
3751         gdbarch.
3752
3753 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3754
3755         * score-tdep.c (score_unwind_sp): Delete.
3756         (score_unwind_pc): Delete.
3757         (score_dummy_id): Delete.
3758         (score_gdbarch_init): Don't register deleted functions with
3759         gdbarch.
3760
3761 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3762
3763         * rx-tdep.c (rx_unwind_pc): Delete.
3764         (rx_unwind_sp): Delete.
3765         (rx_dummy_id): Delete.
3766         (rx_gdbarch_init): Don't register deleted functions with
3767         gdbarch.  Update comment.
3768
3769 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3770
3771         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
3772         (rs6000_dummy_id): Delete.
3773         (rs6000_gdbarch_init): Don't register deleted functions with
3774         gdbarch.
3775
3776 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3777
3778         * or1k-tdep.c (or1k_dummy_id): Delete.
3779         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
3780
3781 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3782
3783         * nios2-tdep.c (nios2_dummy_id): Delete.
3784         (nios2_unwind_sp): Delete.
3785         (nios2_gdbarch_init): Don't register deleted functions with
3786         gdbarch.
3787
3788 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3789
3790         * nds32-tdep.c (nds32_dummy_id): Delete.
3791         (nds32_unwind_pc): Delete.
3792         (nds32_unwind_sp): Delete.
3793         (nds32_gdbarch_init): Don't register deleted functions with
3794         gdbarch.
3795
3796 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3797
3798         * msp430-tdep.c (msp430_unwind_pc): Delete.
3799         (msp430_unwind_sp): Delete.
3800         (msp430_dummy_id): Delete.
3801         (msp430_gdbarch_init): Don't register deleted functions with
3802         gdbarch.
3803
3804 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3805
3806         * moxie-tdep.c (moxie_unwind_sp): Delete.
3807         (moxie_unwind_pc): Delete.
3808         (moxie_dummy_id): Delete.
3809         (moxie_gdbarch_init): Don't register deleted functions with
3810         gdbarch.
3811
3812 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3813
3814         * mn10300-tdep.c (mn10300_dummy_id): Delete.
3815         (mn10300_unwind_pc): Delete.
3816         (mn10300_unwind_sp): Delete.
3817         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
3818         mn10300_unwind_sp.
3819         (mn10300_frame_unwind_init): Don't register deleted functions with
3820         gdbarch.
3821
3822 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3823
3824         * mep-tdep.c (mep_unwind_pc): Delete.
3825         (mep_unwind_sp): Delete.
3826         (mep_dummy_id): Delete.
3827         (mep_gdbarch_init): Don't register deleted functions with
3828         gdbarch.
3829
3830 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3831
3832         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
3833         (m68hc11_unwind_sp): Delete.
3834         (m68hc11_gdbarch_init): Don't register deleted functions with
3835         gdbarch.
3836
3837 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3838
3839         * m32r-tdep.c (m32r_unwind_sp): Delete.
3840         (m32r_unwind_pc): Delete.
3841         (m32r_dummy_id): Delete.
3842         (m32r_gdbarch_init): Don't register deleted functions with
3843         gdbarch.
3844
3845 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3846
3847         * m32c-tdep.c (m32c_unwind_pc): Delete.
3848         (m32c_unwind_sp): Delete.
3849         (m32c_dummy_id): Delete.
3850         (m32c_gdbarch_init): Don't register deleted functions with
3851         gdbarch.
3852
3853 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3854
3855         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
3856         (lm32_unwind_pc): Delete.
3857         (lm32_dummy_id): Delete.
3858         (lm32_gdbarch_init): Don't register deleted functions with
3859         gdbarch.
3860
3861 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3862
3863         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
3864         (iq2000_unwind_pc): Delete.
3865         (iq2000_dummy_id): Delete.
3866         (iq2000_gdbarch_init): Don't register deleted functions with
3867         gdbarch.
3868
3869 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3870
3871         * nds32-tdep.c (nds32_type_align): Delete.
3872         (nds32_push_dummy_call): Use type_align instead.
3873
3874 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3875
3876         * arm-tdep.c (arm_type_align): Only handle vector override case.
3877         (arm_push_dummy_call): Use type_align.
3878         (arm_gdbarch_init): Register arm_type_align gdbarch function.
3879
3880 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3881
3882         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
3883         case.
3884         (pass_on_stack): Use type_align.
3885         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
3886         function.
3887
3888 2019-04-23  Tom Tromey  <tromey@adacore.com>
3889
3890         * dwarf2read.c (line_header::file_name_at): Remove unused
3891         overload.
3892
3893 2019-04-23  Tom de Vries  <tdevries@suse.de>
3894
3895         PR gdb/24438
3896         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
3897         invocation.
3898
3899
3900 2019-03-27  Ali Tamur  <tamur@google.com>
3901
3902         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
3903         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
3904         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
3905         (dwarf_expr_context::get_addr_index): Likewise
3906         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
3907         (symbol_needs_eval_context::get_addr_index): Likewise
3908         (disassemble_dwarf_expression): Add DW_OP_addrx
3909         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
3910         (read_cutu_die_from_dwo): Update comment
3911         (skip_one_die): Add DW_FORM_addrx
3912         (read_attribute_value): Likewise
3913         (var_decode_location): Add DW_OP_addrx
3914         (dwarf2_const_value_attr): Add DW_FORM_addrx
3915         (dump_die_shallow): Likewise
3916         (dwarf2_fetch_constant_bytes): Likewise
3917         (decode_locdesc): Add DW_OP_addrx
3918         (skip_form_bytes): Add DW_FORM_addrx
3919
3920 2019-04-22  Ali Tamur  <tamur@google.com>
3921
3922         * MAINTAINERS (Write After Approval): Add self.
3923
3924 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
3925
3926         * solib-svr4.c (get_svr4_info): Add pspace parameter.
3927         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
3928         (open_symbol_file_object): Likewise.
3929         (svr4_default_sos): Add info parameter.
3930         (svr4_read_so_list): Likewise.
3931         (svr4_current_sos_direct): Adjust functions calls to pass down
3932         info.
3933         (svr4_current_sos_1): Add info parameter.
3934         (svr4_current_sos): Call get_svr4_info, pass info down to
3935         svr4_current_sos_1.
3936         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
3937         get_svr4_info.
3938         (svr4_in_dynsym_resolve_code): Pass current_program_space to
3939         get_svr4_info.
3940         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
3941         to get_svr4_info.
3942         (probes_table_remove_objfile_probes): Likewise.
3943         (register_solib_event_probe): Add info parameter.
3944         (solist_update_incremental): Pass info parameter down to
3945         svr4_read_so_list.
3946         (disable_probes_interface): Add info parameter.
3947         (svr4_handle_solib_event): Pass current_program_space to
3948         get_svr4_info.  Adjust disable_probes_interface cleanup.
3949         (svr4_create_probe_breakpoints): Add info parameter, pass it
3950         down to register_solib_event_probe.
3951         (svr4_create_solib_event_breakpoints): Add info parameter,
3952         pass it down to svr4_create_probe_breakpoints.
3953         (enable_break): Pass info down to
3954         svr4_create_solib_event_breakpoints.
3955         (svr4_solib_create_inferior_hook): Pass current_program_space to
3956         get_svr4_info.
3957         (svr4_clear_solib): Likewise.
3958
3959 2019-04-22  Pedro Alves  <palves@redhat.com>
3960
3961         * solib-svr4.c (svr4_free_objfile_observer): New.
3962         (probe_and_action::objfile): New field.
3963         (probes_table_htab_remove_objfile_probes)
3964         (probes_table_remove_objfile_probes): New functions.
3965         (register_solib_event_probe): Add 'objfile' parameter.  Store it
3966         in the new probe_and_action.  Don't store the probe in 'lookup'.
3967         (svr4_create_probe_breakpoints): Pass objfile to
3968         register_solib_event_probe.
3969         (_initialize_svr4_solib): Register a free_objfile observer.
3970
3971 2019-04-19  Tom Tromey  <tom@tromey.com>
3972
3973         * common/queue.h: Remove.
3974
3975 2019-04-19  Tom Tromey  <tom@tromey.com>
3976
3977         * event-loop.c: Don't include "common/queue.h".
3978
3979 2019-04-19  Tom Tromey  <tom@tromey.com>
3980
3981         * remote.c (remote_target): Use delete.
3982         * remote-notif.h: Include <list>, not "common/queue.h".
3983         (notif_client_p): Remove typedef.
3984         (remote_notif_state): Add constructor, destructor, initializer.
3985         <notif_queue>: Now a std::list.
3986         (remote_notif_state_xfree): Don't declare.
3987         * remote-notif.c (remote_notif_process, handle_notification)
3988         (remote_notif_state_allocate): Update.
3989         (~remote_notif_state): Rename from remote_notif_state_xfree.
3990
3991 2019-04-19  Tom Tromey  <tom@tromey.com>
3992
3993         * symfile.c (reread_symbols): Update.
3994         * objfiles.c (objfile_register_static_link)
3995         (objfile_lookup_static_link): Update
3996         (~objfile) Don't delete static_links.
3997         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
3998
3999 2019-04-19  Tom Tromey  <tom@tromey.com>
4000
4001         * type-stack.h (struct type_stack) <insert>: Constify string.
4002         * type-stack.c (type_stack::insert): Constify string.
4003         * gdbtypes.h (lookup_template_type): Update.
4004         (address_space_name_to_int): Update.
4005         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4006         const.
4007         (lookup_template_type): Make name const.
4008         * c-exp.y: Update rules.
4009         (lex_one_token, classify_name, classify_inner_name)
4010         (c_print_token): Update.
4011         * p-exp.y: Update rules.
4012         (yylex): Update.
4013         * f-exp.y: Update rules.
4014         (yylex): Update.
4015         * d-exp.y: Update rules.
4016         (lex_one_token, classify_name, classify_inner_name): Update.
4017         * parse.c (write_dollar_variable, copy_name): Return std::string.
4018         * parser-defs.h (copy_name): Change return type.
4019         * m2-exp.y: Update rules.
4020         (yylex): Update.
4021         * go-exp.y (lex_one_token): Update.
4022         Update rules.
4023         (classify_unsafe_function, classify_packaged_name)
4024         (classify_name, yylex): Update.
4025
4026 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4027
4028         * configure.ac: add --enable-source-highlight switch.
4029         * configure: Regenerate.
4030         * top.c (print_gdb_version): plumb --enable-source-highlight
4031         status to "show configuration".
4032
4033 2019-04-19  Tom Tromey  <tromey@adacore.com>
4034
4035         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4036         Check ADA_TYPE_P.
4037         (empty_record, ada_template_to_fixed_record_type_1)
4038         (template_to_static_fixed_type)
4039         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4040         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4041         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4042         macros.
4043
4044 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4045
4046         PR symtab/24423:
4047         * source.c (print_source_lines_base): Advance "iter" when a
4048         control character is seen.
4049
4050 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4051
4052         * inferior.h (struct infcall_suspend_state_deleter):
4053         Catch exception in destructor to avoid crash.
4054
4055 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4056
4057         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4058         close to the add_com "shell".
4059
4060 2019-04-18  Tom Tromey  <tromey@adacore.com>
4061
4062         * process-stratum-target.h (class process_stratum_target)
4063         <stratum>: Add "final".
4064
4065 2019-04-17  Tom Tromey  <tromey@adacore.com>
4066
4067         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4068         against nullptr before use.
4069
4070 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4071
4072         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4073
4074 2019-04-17  Jim Wilson  <jimw@sifive.com>
4075             Andrew Burgess  <andrew.burgess@embecosm.com>
4076
4077         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4078         code read might fail, assume 4-byte breakpoint in that case.
4079
4080 2019-04-15  Leszek Swirski  <leszeks@google.com>
4081
4082         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4083         rather than a hand-rolled POD check when checking for forced MEMORY
4084         classification.
4085
4086 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4087
4088         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4089         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4090         function.
4091         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4092         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4093         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4094         declaration.
4095
4096 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4097
4098         * aarch64-linux-nat.c
4099         (aarch64_linux_nat_target::thread_architecture): Add override.
4100         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4101         each VQ.
4102
4103 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4104
4105         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4106
4107 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4108
4109         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4110         target types of size 96-bits, add some additional comments, and
4111         check that the builtin type we found was the correct size.
4112
4113 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4114
4115         * utils.c (prompt_for_continue): Don't restore the styling at the
4116         end, as applied_style has the wrong value.  This fixes styling in
4117         long lists of file names that are interrupted by the "Continue?"
4118         prompt.
4119
4120 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4121
4122         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4123         * c-lang.c (c_language_defn): Likewise.
4124         (cplus_language_defn): Likewise.
4125         (asm_language_defn): Likewise.
4126         (minimal_language_defn): Likewise.
4127         * d-lang.c (d_language_defn): Likewise.
4128         * f-lang.c (f_language_defn): Likewise.
4129         * go-lang.c (go_language_defn): Likewise.
4130         * language.c (unknown_language_defn): Likewise.
4131         (auto_language_defn): Likewise.
4132         * language.h (struct language_defn): Remove la_magic field.
4133         (LANG_MAGIC): Delete.
4134         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4135         * objc-lang.c (objc_language_defn): Likewise.
4136         * opencl-lang.c (opencl_language_defn): Likewise.
4137         * p-lang.c (pascal_language_defn): Likewise.
4138         * rust-lang.c (rust_language_defn): Likewise.
4139
4140 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4141
4142         * riscv-tdep.c (riscv_type_align): New function.
4143         (riscv_type_alignment): Delete.
4144         (riscv_arg_location): Use 'type_align'.
4145         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4146
4147 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4148
4149         * gdbtypes.c (type_align): A struct with no non-static fields also
4150         has alignment of 1.
4151
4152 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4153
4154         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4155         component to 0.
4156         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4157         member.
4158         (riscv_struct_info::analyse): New implementation using new
4159         analyse_inner member function.
4160         (riscv_struct_info::field_offset): New member function.
4161         (riscv_struct_info::m_offsets): New member variable.
4162         (riscv_struct_info::analyse_inner): New private member function,
4163         takes the old implementation of riscv_struct_info::analyse but
4164         extended to track field offsets.
4165         (riscv_call_arg_struct): Update the struct folding special cases
4166         to handle cases where empty C++ structs, which are non-zero
4167         length, are found.
4168         (riscv_arg_location): Initialise the length of each location, a
4169         non-zero length now indicates the location is in use.
4170         (riscv_push_dummy_call): Allow for the first location having a
4171         non-zero offset when setting up arguments.
4172         (riscv_return_value): Likewise, but for return values.
4173
4174 2019-04-11  Tom Tromey  <tromey@adacore.com>
4175
4176         * utils.c (internal_vproblem): Make "msg" const.
4177
4178 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4179
4180         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4181         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4182         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4183         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4184
4185 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4186
4187         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4188         function.
4189         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4190         of amd64_collect_native_gregset.
4191         (amd64_linux_nat_target::store_registers): Likewise.
4192
4193 2019-04-10  Tom Tromey  <tom@tromey.com>
4194
4195         * symtab.c (lookup_global_symbol_from_objfile)
4196         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4197         * objfiles.h (class separate_debug_iterator): New.
4198         (class separate_debug_range): New.
4199         (struct objfile) <separate_debug_objfiles>: New method.
4200         (objfile_separate_debug_iterate): Don't declare.
4201         * objfiles.c (separate_debug_iterator::operator++): Rename from
4202         objfile_separate_debug_iterate.
4203         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4204         iterator.
4205         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4206         iterator.
4207
4208 2019-04-10  Tom Tromey  <tom@tromey.com>
4209
4210         * symfile.c (reread_symbols): Remove old comment.
4211         * objfiles.c (free_all_objfiles): Fix a typo.
4212
4213 2019-04-10  Tom Tromey  <tom@tromey.com>
4214
4215         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4216         * minsyms.c (lookup_minimal_symbol): Use foreach.
4217         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4218         (lookup_minimal_symbol_solib_trampoline): Likewise.
4219         * symfile.c (reread_symbols): Use foreach.
4220
4221 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4222             Tom Tromey  <tromey@adacore.com>
4223
4224         PR rust/24414:
4225         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4226         (rust_lex_int_test): Change "value" to be LONGEST.
4227         (rust_lex_tests): Add test for long integer literal.
4228
4229 2019-04-09  Tom Tromey  <tromey@adacore.com>
4230
4231         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4232         to bool.
4233         (extended_remote_target::attach): Update.
4234         (remote_target::remote_notice_new_inferior): Update.
4235         (remote_target::add_current_inferior_and_thread): Update.
4236         * inferior.c (exit_inferior_1): Use "false".
4237         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4238
4239 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4240
4241         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4242         the "start" command.
4243
4244 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4245
4246         * python/py-inferior.c (infpy_thread_from_thread_handle):
4247         Adjust comments to reflect renaming of thread_from_thread_handle
4248         to thread_from_handle.  Adjust keywords.  Fix type error message.
4249         (inferior_object_methods): Add thread_from_handle.  Retain
4250         thread_from_thread_handle, but mark it as deprecated.
4251
4252 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4253
4254         * gdbthread.h (find_thread_by_handle): Revise declaration.
4255         * thread.c (find_thread_by_handle): Likewise.  Adjust
4256         implementation too.
4257         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4258         support for buffer objects as handles.
4259
4260 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4261
4262         * python/py-infthread.c (thpy_thread_handle): New function.
4263         (thread_object_methods): Register thpy_thread_handle.
4264
4265 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4266
4267         * gdbthread.h (thread_to_thread_handle): Declare.
4268         * thread.c (gdbtypes.h): Include.
4269         (thread_to_thread_handle): New function.
4270
4271         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4272         (target_thread_info_to_thread_handle): Declare.
4273         * target.c (target_thread_info_to_thread_handle): New function.
4274         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4275         * target-delegates.c: Regenerate.
4276
4277         * linux-thread-db.c (class thread_db_target): Add method
4278         thread_info_to_thread_handle.
4279         (thread_db_target::thread_info_to_thread_handle): Define.
4280         * remote.c (class remote_target): Add new method
4281         thread_info_to_thread_handle.
4282         (remote_target::thread_info_to_thread_handle): Define.
4283
4284 2019-04-08  Pedro Alves  <palves@redhat.com>
4285
4286         * common/common-exceptions.c (throw_exception): Don't create
4287         named object to throw; throw directly.
4288         (throw_it): Likewise.  Don't initialize gdb_exception::message
4289         here, with new; pass FMT and AP to the ctor instead.
4290         * common/common-exceptions.h: Include <string>.
4291         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4292         const char *, va_list)): New ctor.  Use std::make_shared.
4293         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4294         errors)): Delete.
4295         (gdb_exception_error::gdb_exception_error(enum errors, const char
4296         *, va_list)): New.
4297         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4298         Add assertion.
4299         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4300         errors)): Delete.
4301         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4302         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4303         Add assertion.
4304
4305 2019-04-08  Tom Tromey  <tom@tromey.com>
4306
4307         * valops.c (value_rtti_indirect_type): Replace throw_exception
4308         with throw.
4309         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4310         with throw.
4311         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4312         throw.
4313         * target.c (target_translate_tls_address): Replace throw_exception
4314         with throw.
4315         * stack.c (frame_apply_command_count): Replace throw_exception
4316         with throw.
4317         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4318         throw.
4319         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4320         with throw.
4321         * rs6000-tdep.c (rs6000_frame_cache)
4322         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4323         * remote.c: Replace throw_exception with throw.
4324         * record-full.c (record_full_message, record_full_wait_1)
4325         (record_full_restore): Replace throw_exception with throw.
4326         * record-btrace.c:
4327         (get_thread_current_frame_id, record_btrace_start_replaying)
4328         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4329         (cmd_record_btrace_start): Replace throw_exception with throw.
4330         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4331         throw.
4332         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4333         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4334         * linespec.c:
4335         (find_linespec_symbols): Replace throw_exception with throw.
4336         * infrun.c (displaced_step_prepare, resume): Replace
4337         throw_exception with throw.
4338         * infcmd.c (post_create_inferior): Replace throw_exception with
4339         throw.
4340         * inf-loop.c (inferior_event_handler): Replace throw_exception
4341         with throw.
4342         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4343         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4344         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4345         (get_prev_frame_always, get_frame_pc_if_available)
4346         (get_frame_address_in_block_if_available, get_frame_language):
4347         Replace throw_exception with throw.
4348         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4349         throw_exception with throw.
4350         * eval.c (fetch_subexp_value, evaluate_var_value)
4351         (evaluate_funcall, evaluate_subexp_standard): Replace
4352         throw_exception with throw.
4353         * dwarf2loc.c (call_site_find_chain)
4354         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4355         Replace throw_exception with throw.
4356         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4357         with throw.
4358         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4359         throw.
4360         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4361         * completer.c (complete_line_internal): Replace throw_exception
4362         with throw.
4363         * compile/compile-object-run.c (compile_object_run): Replace
4364         throw_exception with throw.
4365         * cli/cli-script.c (process_next_line): Replace throw_exception
4366         with throw.
4367         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4368         (btrace_enable, btrace_maint_update_pt_packets): Replace
4369         throw_exception with throw.
4370         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4371         throw_exception with throw.
4372         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4373         throw_exception with throw.
4374         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4375         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4376         * aarch64-tdep.c (aarch64_make_prologue_cache)
4377         (aarch64_make_stub_cache): Replace throw_exception with throw.
4378
4379 2019-04-08  Tom Tromey  <tom@tromey.com>
4380
4381         * common/common-exceptions.c (throw_exception): Rename from
4382         throw_exception_cxx.  Remove old copy.  Make argument const.
4383         (throw_it): Create and throw exception objects directly.
4384         * common/common-exceptions.h (throw_exception): Make argument
4385         const.
4386         (struct gdb_exception_error): Add constructor.
4387         (struct gdb_exception_quit): Add constructor.
4388
4389 2019-04-08  Tom Tromey  <tom@tromey.com>
4390
4391         * common/common-exceptions.h (exception_rethrow): Don't declare.
4392         (TRY_SJLJ): Update comment.
4393         (TRY, CATCH, END_CATCH): Remove.
4394         * common/common-exceptions.c (exception_rethrow): Remove.
4395
4396 2019-04-08  Tom Tromey  <tom@tromey.com>
4397
4398         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4399         Remove.
4400         (gdb_exception_error): Rename from
4401         gdb_exception_RETURN_MASK_ERROR.
4402         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4403         (gdb_quit_bad_alloc): Update.
4404         * aarch64-tdep.c: Update.
4405         * ada-lang.c: Update.
4406         * ada-typeprint.c: Update.
4407         * ada-valprint.c: Update.
4408         * amd64-tdep.c: Update.
4409         * arch-utils.c: Update.
4410         * break-catch-throw.c: Update.
4411         * breakpoint.c: Update.
4412         * btrace.c: Update.
4413         * c-varobj.c: Update.
4414         * cli/cli-cmds.c: Update.
4415         * cli/cli-interp.c: Update.
4416         * cli/cli-script.c: Update.
4417         * common/common-exceptions.c: Update.
4418         * common/new-op.c: Update.
4419         * common/selftest.c: Update.
4420         * compile/compile-c-symbols.c: Update.
4421         * compile/compile-cplus-symbols.c: Update.
4422         * compile/compile-object-load.c: Update.
4423         * compile/compile-object-run.c: Update.
4424         * completer.c: Update.
4425         * corelow.c: Update.
4426         * cp-abi.c: Update.
4427         * cp-support.c: Update.
4428         * cp-valprint.c: Update.
4429         * darwin-nat.c: Update.
4430         * disasm-selftests.c: Update.
4431         * dtrace-probe.c: Update.
4432         * dwarf-index-cache.c: Update.
4433         * dwarf-index-write.c: Update.
4434         * dwarf2-frame-tailcall.c: Update.
4435         * dwarf2-frame.c: Update.
4436         * dwarf2loc.c: Update.
4437         * dwarf2read.c: Update.
4438         * eval.c: Update.
4439         * event-loop.c: Update.
4440         * event-top.c: Update.
4441         * exec.c: Update.
4442         * f-valprint.c: Update.
4443         * fbsd-tdep.c: Update.
4444         * frame-unwind.c: Update.
4445         * frame.c: Update.
4446         * gdbtypes.c: Update.
4447         * gnu-v3-abi.c: Update.
4448         * guile/guile-internal.h: Update.
4449         * guile/scm-block.c: Update.
4450         * guile/scm-breakpoint.c: Update.
4451         * guile/scm-cmd.c: Update.
4452         * guile/scm-disasm.c: Update.
4453         * guile/scm-frame.c: Update.
4454         * guile/scm-lazy-string.c: Update.
4455         * guile/scm-math.c: Update.
4456         * guile/scm-param.c: Update.
4457         * guile/scm-ports.c: Update.
4458         * guile/scm-pretty-print.c: Update.
4459         * guile/scm-symbol.c: Update.
4460         * guile/scm-symtab.c: Update.
4461         * guile/scm-type.c: Update.
4462         * guile/scm-value.c: Update.
4463         * i386-linux-tdep.c: Update.
4464         * i386-tdep.c: Update.
4465         * inf-loop.c: Update.
4466         * infcall.c: Update.
4467         * infcmd.c: Update.
4468         * infrun.c: Update.
4469         * jit.c: Update.
4470         * language.c: Update.
4471         * linespec.c: Update.
4472         * linux-fork.c: Update.
4473         * linux-nat.c: Update.
4474         * linux-tdep.c: Update.
4475         * linux-thread-db.c: Update.
4476         * main.c: Update.
4477         * mi/mi-cmd-break.c: Update.
4478         * mi/mi-cmd-stack.c: Update.
4479         * mi/mi-interp.c: Update.
4480         * mi/mi-main.c: Update.
4481         * objc-lang.c: Update.
4482         * p-valprint.c: Update.
4483         * parse.c: Update.
4484         * ppc-linux-tdep.c: Update.
4485         * printcmd.c: Update.
4486         * python/py-arch.c: Update.
4487         * python/py-breakpoint.c: Update.
4488         * python/py-cmd.c: Update.
4489         * python/py-finishbreakpoint.c: Update.
4490         * python/py-frame.c: Update.
4491         * python/py-framefilter.c: Update.
4492         * python/py-gdb-readline.c: Update.
4493         * python/py-inferior.c: Update.
4494         * python/py-infthread.c: Update.
4495         * python/py-lazy-string.c: Update.
4496         * python/py-linetable.c: Update.
4497         * python/py-objfile.c: Update.
4498         * python/py-param.c: Update.
4499         * python/py-prettyprint.c: Update.
4500         * python/py-progspace.c: Update.
4501         * python/py-record-btrace.c: Update.
4502         * python/py-record.c: Update.
4503         * python/py-symbol.c: Update.
4504         * python/py-type.c: Update.
4505         * python/py-unwind.c: Update.
4506         * python/py-utils.c: Update.
4507         * python/py-value.c: Update.
4508         * python/python.c: Update.
4509         * record-btrace.c: Update.
4510         * record-full.c: Update.
4511         * remote-fileio.c: Update.
4512         * remote.c: Update.
4513         * riscv-tdep.c: Update.
4514         * rs6000-aix-tdep.c: Update.
4515         * rs6000-tdep.c: Update.
4516         * rust-exp.y: Update.
4517         * rust-lang.c: Update.
4518         * s390-tdep.c: Update.
4519         * selftest-arch.c: Update.
4520         * solib-dsbt.c: Update.
4521         * solib-frv.c: Update.
4522         * solib-spu.c: Update.
4523         * solib-svr4.c: Update.
4524         * solib.c: Update.
4525         * sparc64-linux-tdep.c: Update.
4526         * stack.c: Update.
4527         * symfile-mem.c: Update.
4528         * symmisc.c: Update.
4529         * target.c: Update.
4530         * thread.c: Update.
4531         * top.c: Update.
4532         * tracefile-tfile.c: Update.
4533         * tui/tui.c: Update.
4534         * typeprint.c: Update.
4535         * unittests/cli-utils-selftests.c: Update.
4536         * unittests/parse-connection-spec-selftests.c: Update.
4537         * valops.c: Update.
4538         * valprint.c: Update.
4539         * value.c: Update.
4540         * varobj.c: Update.
4541         * windows-nat.c: Update.
4542         * x86-linux-nat.c: Update.
4543         * xml-support.c: Update.
4544
4545 2019-04-08  Tom Tromey  <tom@tromey.com>
4546
4547         * xml-support.c: Use C++ exception handling.
4548         * x86-linux-nat.c: Use C++ exception handling.
4549         * windows-nat.c: Use C++ exception handling.
4550         * varobj.c: Use C++ exception handling.
4551         * value.c: Use C++ exception handling.
4552         * valprint.c: Use C++ exception handling.
4553         * valops.c: Use C++ exception handling.
4554         * unittests/parse-connection-spec-selftests.c: Use C++ exception
4555         handling.
4556         * unittests/cli-utils-selftests.c: Use C++ exception handling.
4557         * typeprint.c: Use C++ exception handling.
4558         * tui/tui.c: Use C++ exception handling.
4559         * tracefile-tfile.c: Use C++ exception handling.
4560         * top.c: Use C++ exception handling.
4561         * thread.c: Use C++ exception handling.
4562         * target.c: Use C++ exception handling.
4563         * symmisc.c: Use C++ exception handling.
4564         * symfile-mem.c: Use C++ exception handling.
4565         * stack.c: Use C++ exception handling.
4566         * sparc64-linux-tdep.c: Use C++ exception handling.
4567         * solib.c: Use C++ exception handling.
4568         * solib-svr4.c: Use C++ exception handling.
4569         * solib-spu.c: Use C++ exception handling.
4570         * solib-frv.c: Use C++ exception handling.
4571         * solib-dsbt.c: Use C++ exception handling.
4572         * selftest-arch.c: Use C++ exception handling.
4573         * s390-tdep.c: Use C++ exception handling.
4574         * rust-lang.c: Use C++ exception handling.
4575         * rust-exp.y: Use C++ exception handling.
4576         * rs6000-tdep.c: Use C++ exception handling.
4577         * rs6000-aix-tdep.c: Use C++ exception handling.
4578         * riscv-tdep.c: Use C++ exception handling.
4579         * remote.c: Use C++ exception handling.
4580         * remote-fileio.c: Use C++ exception handling.
4581         * record-full.c: Use C++ exception handling.
4582         * record-btrace.c: Use C++ exception handling.
4583         * python/python.c: Use C++ exception handling.
4584         * python/py-value.c: Use C++ exception handling.
4585         * python/py-utils.c: Use C++ exception handling.
4586         * python/py-unwind.c: Use C++ exception handling.
4587         * python/py-type.c: Use C++ exception handling.
4588         * python/py-symbol.c: Use C++ exception handling.
4589         * python/py-record.c: Use C++ exception handling.
4590         * python/py-record-btrace.c: Use C++ exception handling.
4591         * python/py-progspace.c: Use C++ exception handling.
4592         * python/py-prettyprint.c: Use C++ exception handling.
4593         * python/py-param.c: Use C++ exception handling.
4594         * python/py-objfile.c: Use C++ exception handling.
4595         * python/py-linetable.c: Use C++ exception handling.
4596         * python/py-lazy-string.c: Use C++ exception handling.
4597         * python/py-infthread.c: Use C++ exception handling.
4598         * python/py-inferior.c: Use C++ exception handling.
4599         * python/py-gdb-readline.c: Use C++ exception handling.
4600         * python/py-framefilter.c: Use C++ exception handling.
4601         * python/py-frame.c: Use C++ exception handling.
4602         * python/py-finishbreakpoint.c: Use C++ exception handling.
4603         * python/py-cmd.c: Use C++ exception handling.
4604         * python/py-breakpoint.c: Use C++ exception handling.
4605         * python/py-arch.c: Use C++ exception handling.
4606         * printcmd.c: Use C++ exception handling.
4607         * ppc-linux-tdep.c: Use C++ exception handling.
4608         * parse.c: Use C++ exception handling.
4609         * p-valprint.c: Use C++ exception handling.
4610         * objc-lang.c: Use C++ exception handling.
4611         * mi/mi-main.c: Use C++ exception handling.
4612         * mi/mi-interp.c: Use C++ exception handling.
4613         * mi/mi-cmd-stack.c: Use C++ exception handling.
4614         * mi/mi-cmd-break.c: Use C++ exception handling.
4615         * main.c: Use C++ exception handling.
4616         * linux-thread-db.c: Use C++ exception handling.
4617         * linux-tdep.c: Use C++ exception handling.
4618         * linux-nat.c: Use C++ exception handling.
4619         * linux-fork.c: Use C++ exception handling.
4620         * linespec.c: Use C++ exception handling.
4621         * language.c: Use C++ exception handling.
4622         * jit.c: Use C++ exception handling.
4623         * infrun.c: Use C++ exception handling.
4624         * infcmd.c: Use C++ exception handling.
4625         * infcall.c: Use C++ exception handling.
4626         * inf-loop.c: Use C++ exception handling.
4627         * i386-tdep.c: Use C++ exception handling.
4628         * i386-linux-tdep.c: Use C++ exception handling.
4629         * guile/scm-value.c: Use C++ exception handling.
4630         * guile/scm-type.c: Use C++ exception handling.
4631         * guile/scm-symtab.c: Use C++ exception handling.
4632         * guile/scm-symbol.c: Use C++ exception handling.
4633         * guile/scm-pretty-print.c: Use C++ exception handling.
4634         * guile/scm-ports.c: Use C++ exception handling.
4635         * guile/scm-param.c: Use C++ exception handling.
4636         * guile/scm-math.c: Use C++ exception handling.
4637         * guile/scm-lazy-string.c: Use C++ exception handling.
4638         * guile/scm-frame.c: Use C++ exception handling.
4639         * guile/scm-disasm.c: Use C++ exception handling.
4640         * guile/scm-cmd.c: Use C++ exception handling.
4641         * guile/scm-breakpoint.c: Use C++ exception handling.
4642         * guile/scm-block.c: Use C++ exception handling.
4643         * guile/guile-internal.h: Use C++ exception handling.
4644         * gnu-v3-abi.c: Use C++ exception handling.
4645         * gdbtypes.c: Use C++ exception handling.
4646         * frame.c: Use C++ exception handling.
4647         * frame-unwind.c: Use C++ exception handling.
4648         * fbsd-tdep.c: Use C++ exception handling.
4649         * f-valprint.c: Use C++ exception handling.
4650         * exec.c: Use C++ exception handling.
4651         * event-top.c: Use C++ exception handling.
4652         * event-loop.c: Use C++ exception handling.
4653         * eval.c: Use C++ exception handling.
4654         * dwarf2read.c: Use C++ exception handling.
4655         * dwarf2loc.c: Use C++ exception handling.
4656         * dwarf2-frame.c: Use C++ exception handling.
4657         * dwarf2-frame-tailcall.c: Use C++ exception handling.
4658         * dwarf-index-write.c: Use C++ exception handling.
4659         * dwarf-index-cache.c: Use C++ exception handling.
4660         * dtrace-probe.c: Use C++ exception handling.
4661         * disasm-selftests.c: Use C++ exception handling.
4662         * darwin-nat.c: Use C++ exception handling.
4663         * cp-valprint.c: Use C++ exception handling.
4664         * cp-support.c: Use C++ exception handling.
4665         * cp-abi.c: Use C++ exception handling.
4666         * corelow.c: Use C++ exception handling.
4667         * completer.c: Use C++ exception handling.
4668         * compile/compile-object-run.c: Use C++ exception handling.
4669         * compile/compile-object-load.c: Use C++ exception handling.
4670         * compile/compile-cplus-symbols.c: Use C++ exception handling.
4671         * compile/compile-c-symbols.c: Use C++ exception handling.
4672         * common/selftest.c: Use C++ exception handling.
4673         * common/new-op.c: Use C++ exception handling.
4674         * cli/cli-script.c: Use C++ exception handling.
4675         * cli/cli-interp.c: Use C++ exception handling.
4676         * cli/cli-cmds.c: Use C++ exception handling.
4677         * c-varobj.c: Use C++ exception handling.
4678         * btrace.c: Use C++ exception handling.
4679         * breakpoint.c: Use C++ exception handling.
4680         * break-catch-throw.c: Use C++ exception handling.
4681         * arch-utils.c: Use C++ exception handling.
4682         * amd64-tdep.c: Use C++ exception handling.
4683         * ada-valprint.c: Use C++ exception handling.
4684         * ada-typeprint.c: Use C++ exception handling.
4685         * ada-lang.c: Use C++ exception handling.
4686         * aarch64-tdep.c: Use C++ exception handling.
4687
4688 2019-04-08  Tom Tromey  <tom@tromey.com>
4689
4690         * xml-support.c (gdb_xml_parser::parse): Update.
4691         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4692         * value.c (show_convenience): Update.
4693         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4694         (test_parse_flags_qcs): Update.
4695         * thread.c (thr_try_catch_cmd): Update.
4696         * target.c (target_translate_tls_address): Update.
4697         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4698         (info_frame_command_core, frame_apply_command_count): Update.
4699         * rust-exp.y (rust_lex_exception_test): Update.
4700         * riscv-tdep.c (riscv_print_one_register_info): Update.
4701         * remote.c (remote_target::enable_btrace): Update.
4702         * record-btrace.c (record_btrace_enable_warn): Update.
4703         * python/py-utils.c (gdbpy_convert_exception): Update.
4704         * printcmd.c (do_one_display, print_variable_and_value): Update.
4705         * mi/mi-main.c (mi_print_exception): Update.
4706         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4707         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4708         * linux-nat.c (linux_nat_target::attach): Update.
4709         * linux-fork.c (class scoped_switch_fork_info): Update.
4710         * infrun.c (displaced_step_prepare): Update.
4711         * infcall.c (call_function_by_hand_dummy): Update.
4712         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4713         * gnu-v3-abi.c (print_one_vtable): Update.
4714         * frame.c (get_prev_frame_always): Update.
4715         * f-valprint.c (info_common_command_for_block): Update.
4716         * exec.c (try_open_exec_file): Update.
4717         * exceptions.c (print_exception, exception_print)
4718         (exception_fprintf, exception_print_same): Update.
4719         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4720         * dwarf-index-cache.c (index_cache::store)
4721         (index_cache::lookup_gdb_index): Update.
4722         * darwin-nat.c (maybe_cache_shell): Update.
4723         * cp-valprint.c (cp_print_value_fields): Update.
4724         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4725         (gcc_cplus_symbol_address): Update.
4726         * compile/compile-c-symbols.c (gcc_convert_symbol)
4727         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
4728         * common/selftest.c: Update.
4729         * common/common-exceptions.h (struct gdb_exception) <message>: Now
4730         a std::string.
4731         (exception_try_scope_entry, exception_try_scope_exit): Don't
4732         declare.
4733         (struct exception_try_scope): Remove.
4734         (TRY): Don't use exception_try_scope.
4735         (struct gdb_exception): Add constructor, operator=.
4736         <what>: New method.
4737         (struct gdb_exception_RETURN_MASK_ALL)
4738         (struct gdb_exception_RETURN_MASK_ERROR)
4739         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
4740         (struct gdb_quit_bad_alloc): Update.
4741         * common/common-exceptions.c (exception_none): Change
4742         initializer.
4743         (struct catcher) <state, exception>: Initialize inline.
4744         <prev>: Remove member.
4745         (current_catcher): Remove.
4746         (catchers): New global.
4747         (exceptions_state_mc_init): Simplify.
4748         (catcher_pop): Remove.
4749         (exceptions_state_mc, exceptions_state_mc_catch): Update.
4750         (try_scope_depth, exception_try_scope_entry)
4751         (exception_try_scope_exit): Remove.
4752         (throw_exception_sjlj): Update.
4753         (exception_messages, exception_messages_size): Remove.
4754         (throw_it): Simplify.
4755         (gdb_exception_sliced_copy): Remove.
4756         (throw_exception_cxx): Update.
4757         * cli/cli-script.c (script_from_file): Update.
4758         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
4759         Update.
4760         * ada-valprint.c (ada_val_print): Update.
4761         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
4762         (create_excep_cond_exprs): Update.
4763
4764 2019-04-08  Tom Tromey  <tom@tromey.com>
4765
4766         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
4767         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
4768         (TRY, CATCH, END_CATCH): Remove some definitions.
4769         * common/common-exceptions.c: Don't use GDB_XCPT.
4770         (catcher_list_size): Remove.
4771         (throw_exception, throw_it): Simplify.
4772
4773 2019-04-05  Tom Tromey  <tom@tromey.com>
4774
4775         Revert the header-sorting patch.
4776         * ft32-tdep.c: Revert.
4777         * frv-tdep.c: Revert.
4778         * frv-linux-tdep.c: Revert.
4779         * frame.c: Revert.
4780         * frame-unwind.c: Revert.
4781         * frame-base.c: Revert.
4782         * fork-child.c: Revert.
4783         * findvar.c: Revert.
4784         * findcmd.c: Revert.
4785         * filesystem.c: Revert.
4786         * filename-seen-cache.h: Revert.
4787         * filename-seen-cache.c: Revert.
4788         * fbsd-tdep.c: Revert.
4789         * fbsd-nat.h: Revert.
4790         * fbsd-nat.c: Revert.
4791         * f-valprint.c: Revert.
4792         * f-typeprint.c: Revert.
4793         * f-lang.c: Revert.
4794         * extension.h: Revert.
4795         * extension.c: Revert.
4796         * extension-priv.h: Revert.
4797         * expprint.c: Revert.
4798         * exec.h: Revert.
4799         * exec.c: Revert.
4800         * exceptions.c: Revert.
4801         * event-top.c: Revert.
4802         * event-loop.c: Revert.
4803         * eval.c: Revert.
4804         * elfread.c: Revert.
4805         * dwarf2read.h: Revert.
4806         * dwarf2read.c: Revert.
4807         * dwarf2loc.c: Revert.
4808         * dwarf2expr.h: Revert.
4809         * dwarf2expr.c: Revert.
4810         * dwarf2-frame.c: Revert.
4811         * dwarf2-frame-tailcall.c: Revert.
4812         * dwarf-index-write.h: Revert.
4813         * dwarf-index-write.c: Revert.
4814         * dwarf-index-common.c: Revert.
4815         * dwarf-index-cache.h: Revert.
4816         * dwarf-index-cache.c: Revert.
4817         * dummy-frame.c: Revert.
4818         * dtrace-probe.c: Revert.
4819         * disasm.h: Revert.
4820         * disasm.c: Revert.
4821         * disasm-selftests.c: Revert.
4822         * dictionary.c: Revert.
4823         * dicos-tdep.c: Revert.
4824         * demangle.c: Revert.
4825         * dcache.h: Revert.
4826         * dcache.c: Revert.
4827         * darwin-nat.h: Revert.
4828         * darwin-nat.c: Revert.
4829         * darwin-nat-info.c: Revert.
4830         * d-valprint.c: Revert.
4831         * d-namespace.c: Revert.
4832         * d-lang.c: Revert.
4833         * ctf.c: Revert.
4834         * csky-tdep.c: Revert.
4835         * csky-linux-tdep.c: Revert.
4836         * cris-tdep.c: Revert.
4837         * cris-linux-tdep.c: Revert.
4838         * cp-valprint.c: Revert.
4839         * cp-support.c: Revert.
4840         * cp-namespace.c: Revert.
4841         * cp-abi.c: Revert.
4842         * corelow.c: Revert.
4843         * corefile.c: Revert.
4844         * continuations.c: Revert.
4845         * completer.h: Revert.
4846         * completer.c: Revert.
4847         * complaints.c: Revert.
4848         * coffread.c: Revert.
4849         * coff-pe-read.c: Revert.
4850         * cli-out.h: Revert.
4851         * cli-out.c: Revert.
4852         * charset.c: Revert.
4853         * c-varobj.c: Revert.
4854         * c-valprint.c: Revert.
4855         * c-typeprint.c: Revert.
4856         * c-lang.c: Revert.
4857         * buildsym.c: Revert.
4858         * buildsym-legacy.c: Revert.
4859         * build-id.h: Revert.
4860         * build-id.c: Revert.
4861         * btrace.c: Revert.
4862         * bsd-uthread.c: Revert.
4863         * breakpoint.h: Revert.
4864         * breakpoint.c: Revert.
4865         * break-catch-throw.c: Revert.
4866         * break-catch-syscall.c: Revert.
4867         * break-catch-sig.c: Revert.
4868         * blockframe.c: Revert.
4869         * block.c: Revert.
4870         * bfin-tdep.c: Revert.
4871         * bfin-linux-tdep.c: Revert.
4872         * bfd-target.c: Revert.
4873         * bcache.c: Revert.
4874         * ax-general.c: Revert.
4875         * ax-gdb.h: Revert.
4876         * ax-gdb.c: Revert.
4877         * avr-tdep.c: Revert.
4878         * auxv.c: Revert.
4879         * auto-load.c: Revert.
4880         * arm-wince-tdep.c: Revert.
4881         * arm-tdep.c: Revert.
4882         * arm-symbian-tdep.c: Revert.
4883         * arm-pikeos-tdep.c: Revert.
4884         * arm-obsd-tdep.c: Revert.
4885         * arm-nbsd-tdep.c: Revert.
4886         * arm-nbsd-nat.c: Revert.
4887         * arm-linux-tdep.c: Revert.
4888         * arm-linux-nat.c: Revert.
4889         * arm-fbsd-tdep.c: Revert.
4890         * arm-fbsd-nat.c: Revert.
4891         * arm-bsd-tdep.c: Revert.
4892         * arch-utils.c: Revert.
4893         * arc-tdep.c: Revert.
4894         * arc-newlib-tdep.c: Revert.
4895         * annotate.h: Revert.
4896         * annotate.c: Revert.
4897         * amd64-windows-tdep.c: Revert.
4898         * amd64-windows-nat.c: Revert.
4899         * amd64-tdep.c: Revert.
4900         * amd64-sol2-tdep.c: Revert.
4901         * amd64-obsd-tdep.c: Revert.
4902         * amd64-obsd-nat.c: Revert.
4903         * amd64-nbsd-tdep.c: Revert.
4904         * amd64-nbsd-nat.c: Revert.
4905         * amd64-nat.c: Revert.
4906         * amd64-linux-tdep.c: Revert.
4907         * amd64-linux-nat.c: Revert.
4908         * amd64-fbsd-tdep.c: Revert.
4909         * amd64-fbsd-nat.c: Revert.
4910         * amd64-dicos-tdep.c: Revert.
4911         * amd64-darwin-tdep.c: Revert.
4912         * amd64-bsd-nat.c: Revert.
4913         * alpha-tdep.c: Revert.
4914         * alpha-obsd-tdep.c: Revert.
4915         * alpha-nbsd-tdep.c: Revert.
4916         * alpha-mdebug-tdep.c: Revert.
4917         * alpha-linux-tdep.c: Revert.
4918         * alpha-linux-nat.c: Revert.
4919         * alpha-bsd-tdep.c: Revert.
4920         * alpha-bsd-nat.c: Revert.
4921         * aix-thread.c: Revert.
4922         * agent.c: Revert.
4923         * addrmap.c: Revert.
4924         * ada-varobj.c: Revert.
4925         * ada-valprint.c: Revert.
4926         * ada-typeprint.c: Revert.
4927         * ada-tasks.c: Revert.
4928         * ada-lang.c: Revert.
4929         * aarch64-tdep.c: Revert.
4930         * aarch64-ravenscar-thread.c: Revert.
4931         * aarch64-newlib-tdep.c: Revert.
4932         * aarch64-linux-tdep.c: Revert.
4933         * aarch64-linux-nat.c: Revert.
4934         * aarch64-fbsd-tdep.c: Revert.
4935         * aarch64-fbsd-nat.c: Revert.
4936         * aarch32-linux-nat.c: Revert.
4937
4938 2019-04-05  Tom Tromey  <tom@tromey.com>
4939
4940         * ft32-tdep.c: Sort headers.
4941         * frv-tdep.c: Sort headers.
4942         * frv-linux-tdep.c: Sort headers.
4943         * frame.c: Sort headers.
4944         * frame-unwind.c: Sort headers.
4945         * frame-base.c: Sort headers.
4946         * fork-child.c: Sort headers.
4947         * findvar.c: Sort headers.
4948         * findcmd.c: Sort headers.
4949         * filesystem.c: Sort headers.
4950         * filename-seen-cache.h: Sort headers.
4951         * filename-seen-cache.c: Sort headers.
4952         * fbsd-tdep.c: Sort headers.
4953         * fbsd-nat.h: Sort headers.
4954         * fbsd-nat.c: Sort headers.
4955         * f-valprint.c: Sort headers.
4956         * f-typeprint.c: Sort headers.
4957         * f-lang.c: Sort headers.
4958         * extension.h: Sort headers.
4959         * extension.c: Sort headers.
4960         * extension-priv.h: Sort headers.
4961         * expprint.c: Sort headers.
4962         * exec.h: Sort headers.
4963         * exec.c: Sort headers.
4964         * exceptions.c: Sort headers.
4965         * event-top.c: Sort headers.
4966         * event-loop.c: Sort headers.
4967         * eval.c: Sort headers.
4968         * elfread.c: Sort headers.
4969         * dwarf2read.h: Sort headers.
4970         * dwarf2read.c: Sort headers.
4971         * dwarf2loc.c: Sort headers.
4972         * dwarf2expr.h: Sort headers.
4973         * dwarf2expr.c: Sort headers.
4974         * dwarf2-frame.c: Sort headers.
4975         * dwarf2-frame-tailcall.c: Sort headers.
4976         * dwarf-index-write.h: Sort headers.
4977         * dwarf-index-write.c: Sort headers.
4978         * dwarf-index-common.c: Sort headers.
4979         * dwarf-index-cache.h: Sort headers.
4980         * dwarf-index-cache.c: Sort headers.
4981         * dummy-frame.c: Sort headers.
4982         * dtrace-probe.c: Sort headers.
4983         * disasm.h: Sort headers.
4984         * disasm.c: Sort headers.
4985         * disasm-selftests.c: Sort headers.
4986         * dictionary.c: Sort headers.
4987         * dicos-tdep.c: Sort headers.
4988         * demangle.c: Sort headers.
4989         * dcache.h: Sort headers.
4990         * dcache.c: Sort headers.
4991         * darwin-nat.h: Sort headers.
4992         * darwin-nat.c: Sort headers.
4993         * darwin-nat-info.c: Sort headers.
4994         * d-valprint.c: Sort headers.
4995         * d-namespace.c: Sort headers.
4996         * d-lang.c: Sort headers.
4997         * ctf.c: Sort headers.
4998         * csky-tdep.c: Sort headers.
4999         * csky-linux-tdep.c: Sort headers.
5000         * cris-tdep.c: Sort headers.
5001         * cris-linux-tdep.c: Sort headers.
5002         * cp-valprint.c: Sort headers.
5003         * cp-support.c: Sort headers.
5004         * cp-namespace.c: Sort headers.
5005         * cp-abi.c: Sort headers.
5006         * corelow.c: Sort headers.
5007         * corefile.c: Sort headers.
5008         * continuations.c: Sort headers.
5009         * completer.h: Sort headers.
5010         * completer.c: Sort headers.
5011         * complaints.c: Sort headers.
5012         * coffread.c: Sort headers.
5013         * coff-pe-read.c: Sort headers.
5014         * cli-out.h: Sort headers.
5015         * cli-out.c: Sort headers.
5016         * charset.c: Sort headers.
5017         * c-varobj.c: Sort headers.
5018         * c-valprint.c: Sort headers.
5019         * c-typeprint.c: Sort headers.
5020         * c-lang.c: Sort headers.
5021         * buildsym.c: Sort headers.
5022         * buildsym-legacy.c: Sort headers.
5023         * build-id.h: Sort headers.
5024         * build-id.c: Sort headers.
5025         * btrace.c: Sort headers.
5026         * bsd-uthread.c: Sort headers.
5027         * breakpoint.h: Sort headers.
5028         * breakpoint.c: Sort headers.
5029         * break-catch-throw.c: Sort headers.
5030         * break-catch-syscall.c: Sort headers.
5031         * break-catch-sig.c: Sort headers.
5032         * blockframe.c: Sort headers.
5033         * block.c: Sort headers.
5034         * bfin-tdep.c: Sort headers.
5035         * bfin-linux-tdep.c: Sort headers.
5036         * bfd-target.c: Sort headers.
5037         * bcache.c: Sort headers.
5038         * ax-general.c: Sort headers.
5039         * ax-gdb.h: Sort headers.
5040         * ax-gdb.c: Sort headers.
5041         * avr-tdep.c: Sort headers.
5042         * auxv.c: Sort headers.
5043         * auto-load.c: Sort headers.
5044         * arm-wince-tdep.c: Sort headers.
5045         * arm-tdep.c: Sort headers.
5046         * arm-symbian-tdep.c: Sort headers.
5047         * arm-pikeos-tdep.c: Sort headers.
5048         * arm-obsd-tdep.c: Sort headers.
5049         * arm-nbsd-tdep.c: Sort headers.
5050         * arm-nbsd-nat.c: Sort headers.
5051         * arm-linux-tdep.c: Sort headers.
5052         * arm-linux-nat.c: Sort headers.
5053         * arm-fbsd-tdep.c: Sort headers.
5054         * arm-fbsd-nat.c: Sort headers.
5055         * arm-bsd-tdep.c: Sort headers.
5056         * arch-utils.c: Sort headers.
5057         * arc-tdep.c: Sort headers.
5058         * arc-newlib-tdep.c: Sort headers.
5059         * annotate.h: Sort headers.
5060         * annotate.c: Sort headers.
5061         * amd64-windows-tdep.c: Sort headers.
5062         * amd64-windows-nat.c: Sort headers.
5063         * amd64-tdep.c: Sort headers.
5064         * amd64-sol2-tdep.c: Sort headers.
5065         * amd64-obsd-tdep.c: Sort headers.
5066         * amd64-obsd-nat.c: Sort headers.
5067         * amd64-nbsd-tdep.c: Sort headers.
5068         * amd64-nbsd-nat.c: Sort headers.
5069         * amd64-nat.c: Sort headers.
5070         * amd64-linux-tdep.c: Sort headers.
5071         * amd64-linux-nat.c: Sort headers.
5072         * amd64-fbsd-tdep.c: Sort headers.
5073         * amd64-fbsd-nat.c: Sort headers.
5074         * amd64-dicos-tdep.c: Sort headers.
5075         * amd64-darwin-tdep.c: Sort headers.
5076         * amd64-bsd-nat.c: Sort headers.
5077         * alpha-tdep.c: Sort headers.
5078         * alpha-obsd-tdep.c: Sort headers.
5079         * alpha-nbsd-tdep.c: Sort headers.
5080         * alpha-mdebug-tdep.c: Sort headers.
5081         * alpha-linux-tdep.c: Sort headers.
5082         * alpha-linux-nat.c: Sort headers.
5083         * alpha-bsd-tdep.c: Sort headers.
5084         * alpha-bsd-nat.c: Sort headers.
5085         * aix-thread.c: Sort headers.
5086         * agent.c: Sort headers.
5087         * addrmap.c: Sort headers.
5088         * ada-varobj.c: Sort headers.
5089         * ada-valprint.c: Sort headers.
5090         * ada-typeprint.c: Sort headers.
5091         * ada-tasks.c: Sort headers.
5092         * ada-lang.c: Sort headers.
5093         * aarch64-tdep.c: Sort headers.
5094         * aarch64-ravenscar-thread.c: Sort headers.
5095         * aarch64-newlib-tdep.c: Sort headers.
5096         * aarch64-linux-tdep.c: Sort headers.
5097         * aarch64-linux-nat.c: Sort headers.
5098         * aarch64-fbsd-tdep.c: Sort headers.
5099         * aarch64-fbsd-nat.c: Sort headers.
5100         * aarch32-linux-nat.c: Sort headers.
5101
5102 2019-04-04  Tom Tromey  <tom@tromey.com>
5103
5104         * varobj.c (varobj_create): Update.
5105         * rust-exp.y (struct rust_parser) <update_innermost_block,
5106         lookup_symbol>: New methods.
5107         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5108         Rename.
5109         (rust_parser::rust_lookup_type)
5110         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5111         * printcmd.c (display_command, do_one_display): Update.
5112         * parser-defs.h (struct parser_state) <parser_state>: Add
5113         "tracker" parameter.
5114         (block_tracker): New member.
5115         (class innermost_block_tracker) <innermost_block_tracker>: Add
5116         "types" parameter.
5117         <reset>: Remove method.
5118         (innermost_block): Don't declare.
5119         (null_post_parser): Update.
5120         * parse.c (innermost_block): Remove global.
5121         (write_dollar_variable): Update.
5122         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5123         Remove "tracker_types" parameter.
5124         (parse_expression): Add "tracker" parameter.
5125         (parse_expression_for_completion): Update.
5126         (null_post_parser): Add "tracker" parameter.
5127         * p-exp.y: Update rules.
5128         * m2-exp.y: Update rules.
5129         * language.h (struct language_defn) <la_post_parser>: Add
5130         "tracker" parameter.
5131         * go-exp.y: Update rules.
5132         * f-exp.y: Update rules.
5133         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5134         parameter.
5135         * d-exp.y: Update rules.
5136         * c-exp.y: Update rules.
5137         * breakpoint.c (set_breakpoint_condition): Create an
5138         innermost_block_tracker.
5139         (watch_command_1): Likewise.
5140         * ada-lang.c (resolve): Add "tracker" parameter.
5141         (resolve_subexp): Likewise.
5142         * ada-exp.y (write_var_from_sym): Update.
5143
5144 2019-04-04  Tom Tromey  <tom@tromey.com>
5145
5146         * type-stack.h: New file.
5147         * type-stack.c: New file.
5148         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5149         type-stack.h.
5150         (insert_into_type_stack, insert_type, push_type, push_type_int)
5151         (insert_type_address_space, pop_type, pop_type_int)
5152         (pop_typelist, pop_type_stack, append_type_stack)
5153         (push_type_stack, get_type_stack, push_typelist)
5154         (follow_type_instance_flags, follow_types): Don't declare.
5155         * parse.c (type_stack): Remove global.
5156         (parse_exp_in_context): Update.
5157         (insert_into_type_stack, insert_type, push_type, push_type_int)
5158         (insert_type_address_space, pop_type, pop_type_int)
5159         (pop_typelist, pop_type_stack, append_type_stack)
5160         (push_type_stack, get_type_stack, push_typelist)
5161         (follow_type_instance_flags, follow_types): Remove (moved to
5162         type-stack.c).
5163         * f-exp.y (type_stack): New global.
5164         Update rules.
5165         (push_kind_type, f_parse): Update.
5166         * d-exp.y (type_stack): New global.
5167         Update rules.
5168         (d_parse): Update.
5169         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5170         Update rules.
5171         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5172         (HFILES_NO_SRCDIR): Add type-stack.h.
5173
5174 2019-04-04  Tom Tromey  <tom@tromey.com>
5175
5176         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5177         (rust_parser::convert_ast_to_expression, rust_parse)
5178         (rust_lex_test_completion, rust_lex_tests): Update.
5179         * parser-defs.h (struct expr_completion_state): New.
5180         (struct parser_state) <parser_state>: Add completion parameter.
5181         <mark_struct_expression, mark_completion_tag>: New methods.
5182         <parse_completion, m_completion_state>: New members.
5183         (prefixify_expression, null_post_parser): Update.
5184         (mark_struct_expression, mark_completion_tag): Don't declare.
5185         * parse.c (parse_completion, expout_last_struct)
5186         (expout_tag_completion_type, expout_completion_name): Remove
5187         globals.
5188         (parser_state::mark_struct_expression)
5189         (parser_state::mark_completion_tag): Now methods.
5190         (prefixify_expression): Add last_struct parameter.
5191         (prefixify_subexp): Likewise.
5192         (parse_exp_1): Update.
5193         (parse_exp_in_context): Add cstate parameter.  Update.
5194         (parse_expression_for_completion): Create an
5195         expr_completion_state.
5196         (null_post_parser): Add "completion" parameter.
5197         * p-exp.y: Update rules.
5198         (yylex): Update.
5199         * language.h (struct language_defn) <la_post_parser>: Add
5200         "completing" parameter.
5201         * go-exp.y: Update rules.
5202         (lex_one_token): Update.
5203         * expression.h (parse_completion): Don't declare.
5204         * d-exp.y: Update rules.
5205         (lex_one_token): Update rules.
5206         * c-exp.y: Update rules.
5207         (lex_one_token): Update.
5208         * ada-lang.c (resolve): Add "parse_completion" parameter.
5209         (resolve_subexp): Likewise.
5210         (ada_resolve_function): Likewise.
5211
5212 2019-04-04  Tom Tromey  <tom@tromey.com>
5213
5214         * parser-defs.h (struct parser_state) <start_arglist,
5215         end_arglist>: New methods.
5216         <arglist_len, m_funcall_chain>: New members.
5217         (arglist_len, start_arglist, end_arglist): Don't declare.
5218         * parse.c (arglist_len, funcall_chain): Remove global.
5219         (start_arglist, end_arglist): Remove functions.
5220         (parse_exp_in_context): Update.
5221         * p-exp.y: Update rules.
5222         * m2-exp.y: Update rules.
5223         * go-exp.y: Update rules.
5224         * f-exp.y: Update rules.
5225         * d-exp.y: Update rules.
5226         * c-exp.y: Update rules.
5227
5228 2019-04-04  Tom Tromey  <tom@tromey.com>
5229
5230         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5231         lex_operator, push_back>: New methods.
5232         Update all rules.
5233         (rust_parser::lex_hex, lex_escape): Rename and update.
5234         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5235         (rust_parser::lex_operator): Rename and update.
5236         (rust_parser::lex_number, rustyylex, rustyyerror)
5237         (rust_lex_test_init, rust_lex_test_sequence)
5238         (rust_lex_test_push_back, rust_lex_tests): Update.
5239         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5240         parameter.
5241         <lexptr, prev_lexptr>: New members.
5242         (lexptr, prev_lexptr): Don't declare.
5243         * parse.c (lexptr, prev_lexptr): Remove globals.
5244         (parse_exp_in_context): Update.
5245         * p-exp.y (yylex, yyerror): Update.
5246         * m2-exp.y (parse_number, yylex, yyerror): Update.
5247         * go-exp.y (lex_one_token, yyerror): Update.
5248         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5249         * d-exp.y (lex_one_token, yyerror): Update.
5250         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5251         (lex_one_token, yyerror): Update.
5252         * ada-lex.l (YY_INPUT): Update.
5253         (rewind_to_char): Update.
5254         * ada-exp.y (yyerror): Update.
5255
5256 2019-04-04  Tom Tromey  <tom@tromey.com>
5257
5258         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5259         * parser-defs.h (struct parser_state) <parser_state>: Add new
5260         parameter.
5261         <comma_terminates>: New member.
5262         (comma_terminates): Don't declare global.
5263         * parse.c (comma_terminates): Remove global.
5264         (parse_exp_in_context): Update.
5265         * p-exp.y (yylex): Update.
5266         * m2-exp.y (yylex): Update.
5267         * go-exp.y (lex_one_token): Update.
5268         * f-exp.y (yylex): Update.
5269         * d-exp.y (lex_one_token): Update.
5270         * c-exp.y (lex_one_token): Update.
5271         * ada-lex.l: Update.
5272
5273 2019-04-04  Tom Tromey  <tom@tromey.com>
5274
5275         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5276         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5277         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5278         * parser-defs.h (paren_depth): Don't declare.
5279         * parse.c (paren_depth): Remove global.
5280         (parse_exp_in_context): Update.
5281         * p-exp.y (paren_depth): New global.
5282         (pascal_parse): Initialize it.
5283         * m2-exp.y (paren_depth): New global.
5284         (m2_parse): Initialize it.
5285         * go-exp.y (paren_depth): New global.
5286         (go_parse): Initialize it.
5287         * f-exp.y (paren_depth): New global.
5288         (f_parse): Initialize it.
5289         * d-exp.y (paren_depth): New global.
5290         (d_parse): Initialize it.
5291         * c-exp.y (paren_depth): New global.
5292         (c_parse): Initialize it.
5293         * ada-lex.l (paren_depth): New global.
5294         (lexer_init): Initialize it.
5295
5296 2019-04-04  Tom Tromey  <tom@tromey.com>
5297
5298         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5299         (rust_parser::convert_ast_to_type)
5300         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5301         * parser-defs.h (struct parser_state) <parser_state>: Add
5302         parameters.  Initialize new members.
5303         <expression_context_block, expression_context_pc>: New members.
5304         * parse.c (expression_context_block, expression_context_pc):
5305         Remove globals.
5306         (parse_exp_in_context): Update.
5307         * p-exp.y: Update all rules.
5308         (yylex): Update.
5309         * m2-exp.y: Update all rules.
5310         (yylex): Update.
5311         * go-exp.y (yylex): Update.
5312         * f-exp.y (yylex): Update.
5313         * d-exp.y: Update all rules.
5314         (yylex): Update.
5315         * c-exp.y: Update all rules.
5316         (lex_one_token, classify_name, yylex, c_parse): Update.
5317         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5318
5319 2019-04-04  Tom Tromey  <tom@tromey.com>
5320
5321         * gdbarch.h, gdbarch.c: Rebuild.
5322         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5323         * stap-probe.h:
5324         (struct stap_parse_info): Replace "parser_state" with
5325         "expr_builder".
5326         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5327         (parser_state): New class.
5328         * parse.c (expr_builder): Rename.
5329         (expr_builder::release): Rename.
5330         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5331         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5332         (write_exp_elt_longcst, write_exp_elt_floatcst)
5333         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5334         (write_exp_string_vector, write_exp_bitstring)
5335         (write_exp_msymbol, mark_struct_expression)
5336         (write_dollar_variable)
5337         (insert_type_address_space, increase_expout_size): Replace
5338         "parser_state" with "expr_builder".
5339         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5340         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5341         "parser_state" with "expr_builder".
5342
5343 2019-04-04  Tom Tromey  <tom@tromey.com>
5344
5345         * rust-exp.y: Replace "parse_language" with method call.
5346         * p-exp.y:
5347         (yylex): Replace "parse_language" with method call.
5348         * m2-exp.y:
5349         (yylex): Replace "parse_language" with method call.
5350         * go-exp.y (classify_name): Replace "parse_language" with method
5351         call.
5352         * f-exp.y (yylex): Replace "parse_language" with method call.
5353         * d-exp.y (lex_one_token): Replace "parse_language" with method
5354         call.
5355         * c-exp.y:
5356         (lex_one_token, classify_name, yylex): Replace "parse_language"
5357         with method call.
5358         * ada-exp.y (find_primitive_type, type_char)
5359         (type_system_address): Replace "parse_language" with method call.
5360
5361 2019-04-04  Tom Tromey  <tom@tromey.com>
5362
5363         * rust-exp.y: Replace "parse_gdbarch" with method call.
5364         * parse.c (write_dollar_variable, insert_type_address_space):
5365         Replace "parse_gdbarch" with method call.
5366         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5367         call.
5368         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5369         call.
5370         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5371         "parse_gdbarch" with method call.
5372         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5373         with method call.
5374         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5375         "parse_gdbarch" with method call.
5376         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5377         "parse_gdbarch" with method call.
5378         * c-exp.y (parse_type, parse_number, classify_name): Replace
5379         "parse_gdbarch" with method call.
5380         * ada-lex.l: Replace "parse_gdbarch" with method call.
5381         * ada-exp.y (parse_type, find_primitive_type, type_char)
5382         (type_system_address): Replace "parse_gdbarch" with method call.
5383
5384 2019-04-04  Tom Tromey  <tom@tromey.com>
5385
5386         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5387         * stap-probe.c (stap_parse_argument): Update.
5388         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5389         initial_size parameter.
5390         * rust-exp.y (rust_lex_tests): Update.
5391         * parse.c (parser_state): Update.
5392         (parse_exp_in_context): Update.
5393         * parser-defs.h (struct parser_state) <parser_state>: Remove
5394         "initial_size" parameter.
5395
5396 2019-04-04  Tom Tromey  <tom@tromey.com>
5397
5398         * parser-defs.h (increase_expout_size): Don't declare.
5399         * parse.c (increase_expout_size): Now static.
5400
5401 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
5402
5403         * gnu-nat.c (gnu_nat_target::wait): Fix
5404         target_waitstatus_to_string call.
5405
5406 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5407
5408         * eval.c (evaluate_subexp_standard): Handle internal functions
5409         during Fortran function call handling.
5410
5411 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5412
5413         * NEWS: Mention new internal functions.
5414         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5415         (read_base_type): Use dwarf2_init_complex_target_type.
5416         * value.c (creal_internal_fn): New function.
5417         (cimag_internal_fn): New function.
5418         (_initialize_values): Register new internal functions.
5419
5420 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5421
5422         * infrun.c (stop_all_threads): If debug_infrun, always
5423         trace the wait status after wait_one, using
5424         target_waitstatus_to_string and target_pid_to_str.
5425         (handle_inferior_event): Replace various trace of
5426         wait status kind by a single trace.
5427         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5428         wait status kind image by target_waitstatus_to_string.
5429         * target/waitstatus.c (target_waitstatus_to_string): Fix
5430         obsolete comment.
5431
5432 2019-04-01  Tom Tromey  <tromey@adacore.com>
5433
5434         PR symtab/23331:
5435         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
5436
5437 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5438             Pedro Alves  <palves@redhat.com>
5439
5440         * top.c (quit_force): Call 'finalize_values'.
5441         * value.c (finalize_values): New function.
5442         * value.h (finalize_values): Declare.
5443
5444 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
5445
5446         * NEWS: Announce $_gdb_major and $_gdb_minor.
5447
5448         * top.c (init_gdb_version_vars): New function.
5449         (gdb_init): Call init_gdb_version_vars.
5450
5451 2019-03-29  Tom Tromey  <tromey@adacore.com>
5452
5453         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
5454         help text.  Remove dead code.
5455
5456 2019-03-29  Keith Seitz  <keiths@redhat.com>
5457
5458         From Siddhesh Poyarekar:
5459         * f-lang.h (f77_get_upperbound): Return LONGEST.
5460         (f77_get_lowerbound): Likewise.
5461         * f-typeprint.c (f_type_print_varspec_suffix): Expand
5462         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
5463         print them.
5464         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
5465         plongest to format print it.
5466         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
5467         (f77_get_upperbound): Likewise.
5468         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
5469         LOWER_BOUND to LONGEST.
5470         (f77_create_arrayprint_offset_tbl): Likewise.
5471
5472 2019-03-29  Keith Seitz  <keiths@redhat.com>
5473
5474         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
5475         %s/pulongest for TYPE_LENGTH instead of %d in format
5476         strings.
5477         * ada-typerint.c (ada_print_type): Likewise.
5478         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
5479         * compile/compile-c-support.c (generate_register_struct): Likewise.
5480         * gdbtypes.c (recursive_dump_type): Likewise.
5481         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
5482         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
5483         instead of %d in format strings.
5484         * riscv-tdep.c (riscv_type_alignment): Cast second argument
5485         to std::min to ULONGEST.
5486         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
5487         instead of %d in format strings.
5488         * tracepoint.c (info_scope_command): Likewise.
5489         * typeprint.c (print_offset_data::update)
5490         (print_offset_data::finish): Likewise.
5491         * xtensa-tdep.c (xtensa_store_return_value)
5492         (xtensa_push_dummy_call): Likewise.
5493
5494 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
5495
5496         * windows-nat.c (display_selector): Fixed format specifications
5497         for 64-bit Cygwin.
5498
5499 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5500
5501         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
5502
5503 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
5504
5505         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
5506         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
5507         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
5508         (nios2_linux_init_abi): Install it.
5509
5510 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5511
5512         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
5513
5514 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5515
5516         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
5517
5518 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5519             Tom Tromey  <tromey@adacore.com>
5520
5521         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
5522
5523 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
5524
5525         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
5526         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
5527         method to compute the bounds of range types. Also print "[evaluated]"
5528         if the bounds' values come from a dynamic evaluation.
5529
5530 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5531
5532         * cp-valprint.c (cp_print_value_fields): Don't print trailing
5533         whitespace when pretty printing is on.
5534
5535 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5536
5537         * ppc-linux-nat.c: Add include.
5538
5539 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5540
5541         * NEWS: Mention AArch64 Pointer Authentication.
5542
5543 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5544
5545         * arm-linux-nat.c: Add include.
5546
5547 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
5548
5549         * source-cache.c (source_cache::get_source_lines): Re-read
5550         fullname after calling open_source_file.
5551
5552 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
5553
5554         * NEWS: Mention TLS support for FreeBSD.
5555
5556 2019-03-25  Tom Tromey  <tromey@adacore.com>
5557
5558         * minsyms.c (BUNCH_SIZE): Update comment.
5559         (~minimal_symbol_reader): Remove old comment.
5560         (compact_minimal_symbols): Update comment.
5561         (minimal_symbol_reader::install): Remove old comment.  Update
5562         other comments.
5563
5564 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5565
5566         * s390-linux-nat.c: Add include.
5567
5568 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5569
5570         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5571         Call linux_get_hwcap.
5572         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
5573         Likewise.
5574         (aarch64_linux_get_hwcap): Remove function.
5575         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
5576         declaration.
5577         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
5578         linux_get_hwcap.
5579         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5580         * linux-tdep.c (linux_get_hwcap): Add function.
5581         (linux_get_hwcap2): Likewise.
5582         * linux-tdep.h (linux_get_hwcap): Add declaration.
5583         (linux_get_hwcap2): Likewise.
5584         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
5585         (ppc_linux_get_hwcap2): Likewise.
5586         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
5587         linux_get_hwcap.
5588         (ppc_linux_nat_target::insert_watchpoint): Likewise.
5589         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
5590         (ppc_linux_nat_target::read_description): Likewise.
5591         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
5592         * s390-linux-nat.c: Likewise.
5593         * s390-linux-tdep.c (s390_core_read_description): Likewise.
5594
5595 2019-03-24  Tom Tromey  <tom@tromey.com>
5596
5597         * ada-lang.c (standard_lookup): Simplify initialization.
5598         (ada_lookup_symbol_nonlocal): Simplify return.
5599         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
5600         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
5601         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
5602         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
5603         initialization.
5604         * solib.c (solib_global_lookup): Simplify.
5605         * symtab.c (null_block_symbol): Remove.
5606         (symbol_cache_lookup): Simplify returns.
5607         (lookup_language_this): Simplify returns.
5608         (lookup_symbol_aux): Simplify return.
5609         (lookup_local_symbol): Simplify returns.
5610         (lookup_global_symbol_from_objfile): Simplify return.
5611         (lookup_symbol_in_objfile_symtabs)
5612         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
5613         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
5614         (lookup_static_symbol, lookup_global_symbol): Simplify return.
5615         * cp-namespace.c (cp_lookup_bare_symbol)
5616         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
5617         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
5618         (cp_lookup_nested_symbol): Don't use null_block_symbol.
5619         (cp_lookup_symbol_via_imports): Simplify initialization.
5620         (find_symbol_in_baseclass): Likewise.
5621         * symtab.h (null_block_symbol): Remove.
5622         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
5623         (d_lookup_nested_symbol, d_lookup_symbol_imports)
5624         (d_lookup_symbol_module): Likewise.
5625         (find_symbol_in_baseclass): Simplify initialization.
5626
5627 2019-03-24  Tom Tromey  <tom@tromey.com>
5628
5629         * expression.h: Don't include symtab.h.
5630         (struct block): Forward declare.
5631
5632 2019-03-24  Tom Tromey  <tom@tromey.com>
5633
5634         * c-exp.y (typebase): Remove casts.
5635         * gdbtypes.c (lookup_unsigned_typename, )
5636         (lookup_signed_typename): Remove cast.
5637         * eval.c (parse_to_comma_and_eval): Remove cast.
5638         * parse.c (write_dollar_variable): Remove cast.
5639         * block.h (struct block) <superblock>: Now const.
5640         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
5641         * psymtab.c (psym_map_matching_symbols): Make "block" const.
5642         (map_block): Make "block" const.
5643         * symfile.h (struct quick_symbol_functions)
5644         <map_matching_symbols>: Constify block argument to "callback".
5645         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
5646         const.
5647         (find_pc_sect_compunit_symtab): Make "b" const.
5648         (find_symbol_at_address): Likewise.
5649         (search_symbols): Likewise.
5650         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
5651         (dw2_debug_names_lookup_symbol): Likewise.
5652         (dw2_map_matching_symbols): Update.
5653         * p-valprint.c (pascal_val_print): Remove "block".
5654         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
5655         (aux_add_nonlocal_symbols): Make "block" const.
5656         (resolve_subexp): Remove cast.
5657         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5658         const.
5659         (iterate_over_file_blocks): Likewise.
5660         * f-exp.y (%union) <bval>: Remove.
5661         * coffread.c (patch_opaque_types): Make "b" const.
5662         * spu-tdep.c (spu_catch_start): Make "block" const.
5663         * c-valprint.c (print_unpacked_pointer): Remove "block".
5664         * symmisc.c (dump_symtab_1): Make "b" const.
5665         (block_depth): Make "block" const.
5666         * d-exp.y (%union) <bval>: Remove.
5667         * cp-support.h (cp_lookup_rtti_type): Update.
5668         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5669         * psymtab.c (psym_lookup_symbol): Make "block" const.
5670         (maintenance_check_psymtabs): Make "b" const.
5671         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5672         (enumerate_locals, enumerate_args): Update.
5673         * python/py-symtab.c (stpy_global_block): Make "block" const.
5674         (stpy_static_block): Likewise.
5675         * inline-frame.c (block_starting_point_at): Make "new_block"
5676         const.
5677         * block.c (find_block_in_blockvector): Make return type const.
5678         (blockvector_for_pc_sect): Make "b" const.
5679         (find_block_in_blockvector): Make "b" const.
5680
5681 2019-03-23  Tom Tromey  <tom@tromey.com>
5682
5683         * varobj.c (varobj_create): Update.
5684         * symfile.c (clear_symtab_users): Don't reset innermost_block.
5685         * printcmd.c (display_command, do_one_display): Don't reset
5686         innermost_block.
5687         * parser-defs.h (enum innermost_block_tracker_type): Move to
5688         expression.h.
5689         (innermost_block): Update comment.
5690         * parse.c (parse_exp_1): Add tracker_types parameter.
5691         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
5692         tracker_types parameter.  Reset innermost_block.
5693         (parse_exp_in_context): Remove.
5694         (parse_expression_for_completion): Update.
5695         * objfiles.c (~objfile): Don't reset expression_context_block or
5696         innermost_block.
5697         * expression.h (enum innermost_block_tracker_type): Move from
5698         parser-defs.h.
5699         (parse_exp_1): Add tracker_types parameter.
5700         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5701         reset innermost_block.
5702
5703 2019-03-23  Tom Tromey  <tom@tromey.com>
5704
5705         * objfiles.h: Include bcache.h.
5706
5707 2019-03-23  Tom Tromey  <tom@tromey.com>
5708
5709         * linespec.c (get_current_search_block): Use
5710         scoped_restore_current_language.
5711         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5712
5713 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5714             Jiong Wang  <jiong.wang@arm.com>
5715
5716         * aarch64-linux-tdep.c
5717         (aarch64_linux_iterate_over_regset_sections): Check for pauth
5718         section.
5719         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5720
5721 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5722             Jiong Wang  <jiong.wang@arm.com>
5723
5724         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5725         instructions.
5726         (aarch64_analyze_prologue_test): Add PACIASP test.
5727         (aarch64_prologue_prev_register): Unmask PC value.
5728
5729 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5730             Jiong Wang  <jiong.wang@arm.com>
5731
5732         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
5733         (aarch64_dwarf2_prev_register): Unmask PC value.
5734         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
5735         (aarch64_execute_dwarf_cfa_vendor_op): Check for
5736         DW_CFA_AARCH64_negate_ra_state.
5737         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
5738
5739 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5740             Jiong Wang  <jiong.wang@arm.com>
5741
5742         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
5743         registers.
5744         (aarch64_pseudo_register_name): Likewise.
5745         (aarch64_pseudo_register_type): Likewise.
5746         (aarch64_pseudo_register_reggroup_p): Likewise.
5747         (aarch64_gdbarch_init): Add pauth registers.
5748         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
5749         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
5750         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
5751         (struct gdbarch_tdep): Add regnum for ra_state.
5752
5753 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5754             Jiong Wang  <jiong.wang@arm.com>
5755
5756         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
5757
5758 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5759             Jiong Wang  <jiong.wang@arm.com>
5760
5761         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
5762         function.
5763         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
5764         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
5765         (aarch64_gdbarch_init): Add puth registers.
5766         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
5767         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
5768         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
5769
5770 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5771             Jiong Wang  <jiong.wang@arm.com>
5772
5773         * aarch64-linux-nat.c
5774         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
5775         * aarch64-linux-tdep.c
5776         (aarch64_linux_core_read_description): Likewise.
5777         (aarch64_linux_get_hwcap): New function.
5778         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
5779         (aarch64_linux_get_hwcap): New declaration.
5780
5781 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5782             Jiong Wang  <jiong.wang@arm.com>
5783
5784         * aarch64-linux-nat.c
5785         (aarch64_linux_nat_target::read_description): Add pauth param.
5786         * aarch64-linux-tdep.c
5787         (aarch64_linux_core_read_description): Likewise.
5788         * aarch64-tdep.c (struct target_desc): Add in pauth.
5789         (aarch64_read_description): Add pauth param.
5790         (aarch64_gdbarch_init): Likewise.
5791         * aarch64-tdep.h (aarch64_read_description): Likewise.
5792         * arch/aarch64.c (aarch64_create_target_description): Likewise.
5793         * arch/aarch64.h (aarch64_create_target_description): Likewise.
5794         * features/Makefile: Add new files.
5795         * features/aarch64-pauth.c: New file.
5796         * features/aarch64-pauth.xml: New file.
5797
5798 2019-03-20  Tom Tromey  <tromey@adacore.com>
5799
5800         * infrun.c (handle_inferior_event): Rename from
5801         handle_inferior_event_1.  Create a scoped_value_mark.
5802         (handle_inferior_event): Remove.
5803
5804 2019-03-19  Tom Tromey  <tromey@adacore.com>
5805
5806         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
5807         * infrun.h (print_stop_event): Add "displays" parameter.
5808         * infrun.c (print_stop_event): Add "displays" parameter.
5809
5810 2019-03-19  Pedro Alves  <palves@redhat.com>
5811
5812         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
5813         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
5814         to -1.  Fix TABs vs spaces.
5815         (tui_ui_out::tui_ui_out): Don't initialize fields here.
5816         * tui/tui-out.h (tui_ui_out) Add intro comments.
5817         <m_line, m_start_of_line>: In-class initialize, and add describing
5818         comment.
5819
5820 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
5821
5822         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
5823         variable names.
5824         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
5825
5826 2019-03-18  Pedro Alves  <palves@redhat.com>
5827             Eli Zaretskii <eliz@gnu.org>
5828
5829         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
5830         m_line and m_start_of_line.
5831
5832 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
5833
5834         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
5835         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
5836         it returns a newline.  This fixes a regression in TU mode, whereby
5837         the next line is output on the same screen line as the user input.
5838
5839 2019-03-18  Tom Tromey  <tromey@adacore.com>
5840
5841         * minsyms.c (minimal_symbol_reader::install): Remove call to
5842         obstack_blank.
5843
5844 2019-03-18  Pedro Alves  <palves@redhat.com>
5845
5846         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
5847         New globals.
5848         (apply_style): New, factored out from ...
5849         (apply_ansi_escape): ... this.  Handle reverse video mode.
5850         (tui_set_reverse_mode): New function.
5851         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
5852         * tui/tui-winsource.c (tui_show_source_line): Use
5853         tui_set_reverse_mode instead of setting A_STANDOUT.
5854         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
5855         New setter methods.
5856
5857 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
5858
5859         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
5860         Handle tabs.
5861
5862 2019-03-18  Tom Tromey  <tromey@adacore.com>
5863
5864         * ada-lang.c (empty_array): Add "high" parameter.
5865         (ada_evaluate_subexp): Update.
5866
5867 2019-03-17  Sergei Trofimovich <siarheit@google.com>
5868
5869         * unittests/string_view-selftests.c: Define
5870         _initialize_string_view_selftests unconditionally.
5871
5872 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5873
5874         PR gdb/24350
5875         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
5876
5877 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5878
5879         PR gdb/24351
5880         * windows-nat.c (display_selector): Fix format specifiers.
5881
5882 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
5883
5884         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
5885         tui_refill_source_window instead of tui_refresh_win, to update the
5886         current execution line.  This fixes redisplay of the current line
5887         when stepping through the code with "next" or "step".
5888
5889 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5890
5891         * source-cache.c (source_cache::get_source_lines): Call
5892         find_source_lines to initialize s->nlines.  This fixes vertical
5893         scrolling of TUI source window when the DOWN arrow is pressed.
5894
5895 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5896
5897         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
5898         linux-thread-db.c (_initialize_thread_db): Likewise.
5899
5900 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5901
5902         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
5903         wclrtoeol in tui_show_source_line".  This reverts changes made in
5904         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
5905
5906 2019-03-15  Tom Tromey  <tom@tromey.com>
5907
5908         * symtab.h (struct minimal_symbol): Derive from
5909         general_symbol_info.
5910         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
5911         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
5912         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
5913         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
5914         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
5915         (MSYMBOL_SEARCH_NAME): Update.
5916         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
5917         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
5918         * minsyms.c (minimal_symbol_reader::record_full): Update.
5919
5920 2019-03-15  Tom Tromey  <tom@tromey.com>
5921
5922         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
5923
5924 2019-03-15  Tom Tromey  <tom@tromey.com>
5925
5926         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
5927         unique_xmalloc_ptr.
5928         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
5929         Update.
5930         * minsyms.c (lookup_minimal_symbol_by_pc_section)
5931         (build_minimal_symbol_hash_tables)
5932         (minimal_symbol_reader::install): Update.
5933
5934 2019-03-15  Tom Tromey  <tom@tromey.com>
5935
5936         * symtab.c (create_demangled_names_hash): Update.
5937         (symbol_set_names): Update.
5938         * objfiles.h (struct objfile_per_bfd_storage)
5939         <demangled_names_hash>: Now an htab_up.
5940         * objfiles.c (objfile_per_bfd_storage): Simplify.
5941
5942 2019-03-15  Tom Tromey  <tom@tromey.com>
5943
5944         * objfiles.h (struct objfile_per_bfd_storage): Declare
5945         destructor.
5946         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
5947         New.
5948         (get_objfile_bfd_data): Use new.  Don't initialize
5949         language_of_main.
5950         (free_objfile_per_bfd_storage): Remove.
5951         (objfile_bfd_data_free, objfile::~objfile): Use delete.
5952
5953 2019-03-15  Tom Tromey  <tom@tromey.com>
5954
5955         * symfile.c (reread_symbols): Update.
5956         * objfiles.c (objfile::objfile): Update.
5957         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
5958         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
5959         comment.
5960         (minimal_symbol_reader::install): Update.
5961         (terminate_minimal_symbol_table): Remove.
5962         * jit.c (jit_object_close_impl): Update.
5963
5964 2019-03-15  Tom Tromey  <tom@tromey.com>
5965
5966         * minsyms.c (minimal_symbol_reader::record_full): Remove some
5967         initializations.
5968
5969 2019-03-15  Tom Tromey  <tom@tromey.com>
5970
5971         * objfiles.h (struct objfile_per_bfd_storage)
5972         <demangled_hash_languages>: Now a bitset.
5973         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
5974         (lookup_minimal_symbol): Update.
5975
5976 2019-03-15  Tom Tromey  <tom@tromey.com>
5977
5978         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
5979         Don't return the symbol.
5980         * coffread.c (record_minimal_symbol): Use record_full.
5981
5982 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
5983
5984         The MS-Windows port of ncurses fails to switch to a color pair if
5985         one or both of the colors are the implicit default colors.  This
5986         change records the default colors when TUI is initialized, and
5987         then specifies them explicitly when a color pair uses the default
5988         colors.  This allows color styling in TUI mode on MS-Windows.
5989
5990         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
5991         ncurses_norm_attr.
5992         (tui_initialize_io) [__MINGW32__]: Record the default terminal
5993         colors in ncurses_norm_attr.
5994         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
5995         "none", replace it with the default color recorded in
5996         ncurses_norm_attr.
5997
5998 2019-03-14  Tom Tromey  <tromey@adacore.com>
5999
6000         * source-cache.h (class source_cache) <get_source_lines>: Return
6001         std::string.
6002         * source-cache.c (source_cache::extract_lines): Handle case where
6003         first_pos==npos.  Return std::string.
6004         (source_cache::get_source_lines): Update.
6005
6006 2019-03-14  Tom Tromey  <tromey@adacore.com>
6007
6008         * NEWS: Add item for "style sources" commands.
6009         * source-cache.c (source_cache::get_source_lines): Check
6010         source_styling.
6011         * cli/cli-style.c (source_styling): New global.
6012         (_initialize_cli_style): Add "style sources" commands.
6013         (show_style_sources): New function.
6014         * cli/cli-style.h (source_styling): Declare.
6015
6016 2019-03-14  Pedro Alves  <palves@redhat.com>
6017             Tom Tromey  <tromey@adacore.com>
6018
6019         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6020         * tui/tui-winsource.c (tui_refill_source_window): New function,
6021         from...
6022         (tui_horizontal_source_scroll): ... here.  Move some logic.
6023         * cli/cli-style.c (set_style_enabled): Notify new observable.
6024         * tui/tui-hooks.c (tui_redisplay_source): New function.
6025         (tui_attach_detach_observers): Attach or detach
6026         tui_redisplay_source.
6027         * observable.h (source_styling_changed): New observable.
6028         * observable.c: Define source_styling_changed observable.
6029
6030 2019-03-13  Tom Tromey  <tromey@adacore.com>
6031
6032         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6033         (i386_gnu_nat_target::store_registers): Update.
6034         * target-debug.h (target_debug_print_std_string): New macro.
6035         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6036         * windows-tdep.c (display_one_tib): Update.
6037         * tui/tui-stack.c (tui_make_status_line): Update.
6038         * top.c (print_inferior_quit_action): Update.
6039         * thread.c (thr_try_catch_cmd): Update.
6040         (add_thread_with_info): Update.
6041         (thread_target_id_str): Update.
6042         (thr_try_catch_cmd): Update.
6043         (thread_command): Update.
6044         (thread_find_command): Update.
6045         * record-btrace.c (record_btrace_target::info_record)
6046         (record_btrace_resume_thread, record_btrace_target::resume)
6047         (record_btrace_cancel_resume, record_btrace_step_thread)
6048         (record_btrace_target::wait, record_btrace_target::wait)
6049         (record_btrace_target::wait, record_btrace_target::stop): Update.
6050         * progspace.c (print_program_space): Update.
6051         * process-stratum-target.c
6052         (process_stratum_target::thread_address_space): Update.
6053         * linux-fork.c (linux_fork_mourn_inferior)
6054         (detach_checkpoint_command, info_checkpoints_command)
6055         (linux_fork_context): Update.
6056         (linux_fork_detach): Update.
6057         (class scoped_switch_fork_info): Update.
6058         (delete_checkpoint_command): Update.
6059         * infrun.c (follow_fork_inferior): Update.
6060         (follow_fork_inferior): Update.
6061         (proceed_after_vfork_done): Update.
6062         (handle_vfork_child_exec_or_exit): Update.
6063         (follow_exec): Update.
6064         (displaced_step_prepare_throw): Update.
6065         (displaced_step_restore): Update.
6066         (start_step_over): Update.
6067         (resume_1): Update.
6068         (clear_proceed_status_thread): Update.
6069         (proceed): Update.
6070         (print_target_wait_results): Update.
6071         (do_target_wait): Update.
6072         (context_switch): Update.
6073         (stop_all_threads): Update.
6074         (restart_threads): Update.
6075         (finish_step_over): Update.
6076         (handle_signal_stop): Update.
6077         (switch_back_to_stepped_thread): Update.
6078         (keep_going_pass_signal): Update.
6079         (print_exited_reason): Update.
6080         (normal_stop): Update.
6081         * inferior.c (inferior_pid_to_str): Change return type.
6082         (print_selected_inferior): Update.
6083         (add_inferior): Update.
6084         (detach_inferior): Update.
6085         * dummy-frame.c (fprint_dummy_frames): Update.
6086         * dcache.c (dcache_info_1): Update.
6087         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6088         (btrace_fetch, btrace_clear): Update.
6089         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6090         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6091         type.
6092         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6093         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6094         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6095         * gdbarch.c, gdbarch.h: Rebuild.
6096         * gdbarch.sh (core_pid_to_str): Change return type.
6097         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6098         return type.
6099         (windows_nat_target::pid_to_str): Change return type.
6100         (windows_delete_thread): Update.
6101         (windows_nat_target::attach): Update.
6102         (windows_nat_target::files_info): Update.
6103         * target-delegates.c: Rebuild.
6104         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6105         return type.
6106         (sol_thread_target::pid_to_str): Change return type.
6107         * remote.c (class remote_target) <pid_to_str>: Change return
6108         type.
6109         (remote_target::pid_to_str): Change return type.
6110         (extended_remote_target::attach, remote_target::remote_stop_ns)
6111         (remote_target::remote_notif_remove_queued_reply)
6112         (remote_target::push_stop_reply, remote_target::disable_btrace):
6113         Update.
6114         (extended_remote_target::attach): Update.
6115         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6116         type.
6117         (gdbsim_target::pid_to_str): Change return type.
6118         * ravenscar-thread.c (struct ravenscar_thread_target)
6119         <pid_to_str>: Change return type.
6120         (ravenscar_thread_target::pid_to_str): Change return type.
6121         * procfs.c (class procfs_target) <pid_to_str>: Change return
6122         type.
6123         (procfs_target::pid_to_str): Change return type.
6124         (procfs_target::attach): Update.
6125         (procfs_target::detach): Update.
6126         (procfs_target::fetch_registers): Update.
6127         (procfs_target::store_registers): Update.
6128         (procfs_target::wait): Update.
6129         (procfs_target::files_info): Update.
6130         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6131         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6132         return type.
6133         (nto_procfs_target::pid_to_str): Change return type.
6134         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6135         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6136         return type.
6137         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6138         (exit_lwp): Update.
6139         (attach_proc_task_lwp_callback, get_detach_signal)
6140         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6141         (linux_nat_target::resume, wait_lwp, stop_callback)
6142         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6143         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6144         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6145         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6146         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6147         type.
6148         (inf_ptrace_target::attach): Update.
6149         (inf_ptrace_target::files_info): Update.
6150         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6151         type.
6152         (go32_nat_target::pid_to_str): Change return type.
6153         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6154         (gnu_nat_target::wait): Update.
6155         (gnu_nat_target::wait): Update.
6156         (gnu_nat_target::resume): Update.
6157         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6158         (fbsd_nat_target::wait): Update.
6159         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6160         type.
6161         (darwin_nat_target::attach): Update.
6162         * corelow.c (class core_target) <pid_to_str>: Change return type.
6163         (core_target::pid_to_str): Change return type.
6164         * target.c (normal_pid_to_str): Change return type.
6165         (default_pid_to_str): Likewise.
6166         (target_pid_to_str): Change return type.
6167         (target_translate_tls_address): Update.
6168         (target_announce_detach): Update.
6169         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6170         return type.
6171         (bsd_uthread_target::pid_to_str): Change return type.
6172         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6173         type.
6174         (bsd_kvm_target::pid_to_str): Change return type.
6175         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6176         return type.
6177         (aix_thread_target::pid_to_str): Change return type.
6178         * target.h (struct target_ops) <pid_to_str>: Change return type.
6179         (target_pid_to_str, normal_pid_to_str): Likewise.
6180         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6181         type.
6182         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6183         type.
6184         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6185         return type.
6186         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6187         type.
6188         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6189         type.
6190         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6191         return type.
6192
6193 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6194
6195         * NEWS: Mention that the new default MI version is 3.  Mention
6196         changes to the output of commands and events that deal with
6197         multi-location breakpoints.
6198         * breakpoint.c: Include "mi/mi-out.h".
6199         (print_one_breakpoint): Change output syntax if using MI version
6200         >= 3.
6201         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6202         New.
6203         (mi_multi_location_breakpoint_output_fixed): New.
6204         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6205         (mi_cmd_fix_multi_location_breakpoint_output): New.
6206         (mi_multi_location_breakpoint_output_fixed): New.
6207         * mi/mi-cmds.c (mi_cmds): Register command
6208         -fix-multi-location-breakpoint-output.
6209         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6210         interpreter "mi".
6211
6212 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6213
6214         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6215         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6216         instantiate mi_ui_out based on interpreter name.
6217         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6218         * mi/mi-main.c (mi_load_progress): Likewise.
6219
6220 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6221
6222         * NEWS: Combine separate "New targets" sections for 8.3.
6223
6224 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6225
6226         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6227         (ppcfbsd_init_abi): Install gdbarch
6228         "fetch_tls_load_module_address" and "get_thread_local_address"
6229         methods.
6230
6231 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6232
6233         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6234         (riscv_fbsd_init_abi): Install gdbarch
6235         "fetch_tls_load_module_address" and "get_thread_local_address"
6236         methods.
6237
6238 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6239
6240         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6241         (i386fbsd_init_abi): Install gdbarch
6242         "fetch_tls_load_module_address" and "get_thread_local_address"
6243         methods.
6244
6245 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6246
6247         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6248         (amd64fbsd_init_abi): Install gdbarch
6249         "fetch_tls_load_module_address" and "get_thread_local_address"
6250         methods.
6251
6252 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6253
6254         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6255         (struct fbsd_pspace_data): New type.
6256         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6257         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6258         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6259         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6260         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6261
6262 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6263
6264         * gdbtypes.c (lookup_struct_elt): New function.
6265         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6266         * gdbtypes.h (struct struct_elt): New type.
6267         (lookup_struct_elt): New prototype.
6268
6269 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6270
6271         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6272         remove disabled code block.
6273
6274 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6275
6276         * gdbarch.sh (get_thread_local_address): New method.
6277         * gdbarch.h, gdbarch.c: Regenerate.
6278         * target.c (target_translate_tls_address): Use
6279         gdbarch_get_thread_local_address if present instead of
6280         target::get_thread_local_address.
6281
6282 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6283
6284         * target.h (target::get_thread_local_address): Update comment.
6285
6286 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6287
6288         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6289         objfile->separate_debug_objfile_backlink if not NULL.
6290
6291 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6292
6293         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6294         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6295         (amd64bsd_store_inferior_registers): Likewise.
6296         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6297         Enable segment base registers.
6298         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6299         PT_GETFSBASE and PT_GETGSBASE.
6300         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6301         PT_SETGSBASE.
6302         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6303         segment base registers.
6304         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6305
6306 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6307
6308         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6309         Update calls to i386_target_description to add 'segments'
6310         parameter.
6311         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6312         add segment base registers.
6313         * arch/i386.c (i386_create_target_description): Add 'segments'
6314         parameter to enable segment base registers.
6315         * arch/i386.h (i386_create_target_description): Likewise.
6316         * features/i386/32bit-segments.xml: New file.
6317         * features/i386/32bit-segments.c: Generate.
6318         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6319         call to i386_target_description to add 'segments' parameter.
6320         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6321         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6322         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6323         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6324         if feature is present.
6325         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6326         Add 'segments' parameter to call to i386_target_description.
6327         (i386_target_description): Add 'segments' parameter to enable
6328         segment base registers.
6329         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6330         to call to i386_target_description.
6331         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6332         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6333         Define I386_NUM_REGS.
6334         (i386_target_description): Add 'segments' parameter to enable
6335         segment base registers.
6336
6337 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6338
6339         PR/24325
6340         * source-cache.c: #undef open and close, to avoid unresolved
6341         externals during linking.
6342
6343 2019-03-12  Tom Tromey  <tromey@adacore.com>
6344
6345         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6346         const.  Add initializers.
6347         (_initialize_remote): Don't initialize ptid globals.
6348
6349 2019-03-12  Pedro Alves  <palves@redhat.com>
6350
6351         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6352
6353 2019-03-12  Pedro Alves  <palves@redhat.com>
6354
6355         * cp-name-parser.y (main): Remove unused 'len' variable.
6356
6357 2019-03-12  Tom Tromey  <tromey@adacore.com>
6358
6359         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6360         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6361
6362 2019-03-12  Tom Tromey  <tromey@adacore.com>
6363
6364         * linux-nat.c (iterate_over_lwps): Update.
6365         (stop_callback): Remove parameter.
6366         (stop_wait_callback, detach_callback, resume_set_callback)
6367         (select_singlestep_lwp_callback, set_ignore_sigint)
6368         (status_callback, resumed_callback, resume_clear_callback)
6369         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6370         data parameter.
6371         (linux_nat_target::detach, linux_nat_target::resume)
6372         (linux_stop_and_wait_all_lwps, select_event_lwp)
6373         (linux_nat_filter_event, linux_nat_wait_1)
6374         (linux_nat_target::kill, linux_nat_target::stop)
6375         (linux_nat_target::stop): Update.
6376         (linux_nat_resume_callback): Change type.
6377         (resume_stopped_resumed_lwps, count_events_callback)
6378         (select_event_lwp_callback): Likewise.
6379         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6380         * arm-linux-nat.c (struct update_registers_data): Remove.
6381         (update_registers_callback): Change type.
6382         (arm_linux_insert_hw_breakpoint1): Update.
6383         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6384         parameter.
6385         (x86_linux_dr_set_addr): Update.
6386         (x86_linux_dr_set_control): Update.
6387         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6388         (iterate_over_lwps): Use gdb::function_view.
6389         * nat/aarch64-linux-hw-point.c (struct
6390         aarch64_dr_update_callback_param): Remove.
6391         (debug_reg_change_callback): Change type.
6392         (aarch64_notify_debug_reg_change): Update.
6393         * s390-linux-nat.c (s390_refresh_per_info): Update.
6394
6395 2019-03-11  Tom Tromey  <tromey@adacore.com>
6396
6397         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6398         redundant assignment to "this_cu".
6399
6400 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6401
6402         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6403
6404 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6405
6406         * gdbtypes.c (rank_one_type_parm_set): New function extracted
6407         from...
6408         (rank_one_type): ... this.
6409
6410 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6411
6412         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6413         from...
6414         (rank_one_type): ... this.
6415
6416 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6417
6418         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6419         from...
6420         (rank_one_type): ... this.
6421
6422 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6423
6424         * gdbtypes.c (rank_one_type_parm_float): New function extracted
6425         from...
6426         (rank_one_type): ... this.
6427
6428 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6429
6430         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6431         from...
6432         (rank_one_type): ... this.
6433
6434 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6435
6436         * gdbtypes.c (rank_one_type_parm_range): New function extracted
6437         from...
6438         (rank_one_type): ... this.
6439
6440 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6441
6442         * gdbtypes.c (rank_one_type_parm_char): New function extracted
6443         from...
6444         (rank_one_type): ... this.
6445
6446 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6447
6448         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
6449         from...
6450         (rank_one_type): ... this.
6451
6452 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6453
6454         * gdbtypes.c (rank_one_type_parm_int): New function extracted
6455         from...
6456         (rank_one_type): ... this.
6457
6458 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6459
6460         * gdbtypes.c (rank_one_type_parm_func): New function extracted
6461         from...
6462         (rank_one_type): ... this.
6463
6464 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6465
6466         * gdbtypes.c (rank_one_type_parm_array): New function extracted
6467         from...
6468         (rank_one_type): ... this.
6469
6470 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6471
6472         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
6473         from...
6474         (rank_one_type): ... this.
6475
6476 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6477
6478         * inferior.c (initialize_inferiors): Ensure 'help set/show print
6479         inferior-events' shows the example events.
6480
6481 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
6482
6483         Support styling on native MS-Windows console
6484
6485         PR/24315
6486         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
6487         on MS-Windows if $TERM is not defined.
6488
6489         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
6490
6491         * posix-hdep.c (gdb_console_fputs):
6492         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
6493         functions.
6494         * ui-file.h (gdb_console_fputs): Add prototype.
6495
6496         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
6497         back to fputs only if the former returns zero.
6498
6499 2019-03-07  Tom Tromey  <tom@tromey.com>
6500
6501         * symmisc.c (print_symbol_bcache_statistics): Update.
6502         (print_objfile_statistics): Update.
6503         * symfile.c (allocate_symtab): Update.
6504         * stabsread.c: Don't include bcache.h.
6505         * psymtab.h (struct psymbol_bcache): Don't declare.
6506         (class psymtab_storage) <psymbol_cache>: Now a bcache.
6507         (psymbol_bcache_init, psymbol_bcache_free)
6508         (psymbol_bcache_get_bcache): Don't declare.
6509         * psymtab.c (struct psymbol_bcache): Remove.
6510         (psymtab_storage::psymtab_storage): Update.
6511         (psymtab_storage::~psymtab_storage): Update.
6512         (psymbol_bcache_init, psymbol_bcache_free)
6513         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
6514         (add_psymbol_to_bcache): Update.
6515         (allocate_psymtab): Update.
6516         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6517         macro_cache>: No longer pointers.
6518         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
6519         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
6520         * macrotab.c (macro_bcache): Update.
6521         * macroexp.c: Don't include bcache.h.
6522         * gdbtypes.c (check_types_worklist): Update.
6523         (types_deeply_equal): Remove TRY/CATCH.  Update.
6524         * elfread.c (elf_symtab_read): Update.
6525         * dwarf2read.c: Don't include bcache.h.
6526         * buildsym.c (buildsym_compunit::get_macro_table): Update.
6527         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
6528         (print_bcache_statistics, bcache_memory_used): Don't declare.
6529         (struct bcache): Move from bcache.c.  Add constructor, destructor,
6530         methods.  Rename all data members.
6531         * bcache.c (struct bcache): Move to bcache.h.
6532         (bcache::expand_hash_table): Rename from expand_hash_table.
6533         (bcache): Remove.
6534         (bcache::insert): Rename from bcache_full.
6535         (bcache::compare): Rename from bcache_compare.
6536         (bcache_xmalloc): Remove.
6537         (bcache::~bcache): Rename from bcache_xfree.
6538         (bcache::print_statistics): Rename from print_bcache_statistics.
6539         (bcache::memory_used): Rename from bcache_memory_used.
6540
6541 2019-03-07  Pedro Alves  <palves@redhat.com>
6542
6543         * infrun.c (normal_stop): Also check for
6544         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
6545
6546 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
6547
6548         * f-lang.c (value_from_host_double): Moved to...
6549         * value.c (value_from_host_double): ...here.
6550         * value.h (value_from_host_double): Declare.
6551         * guile/scm-math.c (vlscm_convert_typed_number): Use
6552         value_from_host_double.
6553         (vlscm_convert_number): Likewise.
6554         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
6555         * python/py-value.c (convert_value_from_python): Likewise.
6556
6557 2019-03-06  Tom Tromey  <tom@tromey.com>
6558
6559         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
6560
6561 2019-03-06  Tom Tromey  <tom@tromey.com>
6562
6563         * utils.h (free_current_contents): Don't declare.
6564         * utils.c (free_current_contents): Remove.
6565
6566 2019-03-06  Tom Tromey  <tom@tromey.com>
6567
6568         * top.c (quit_force): Update.
6569         * main.c (captured_command_loop): Update.
6570         * common/new-op.c (operator new): Update.
6571         * common/common-exceptions.c (struct catcher)
6572         <save_cleanup_chain>: Remove member.
6573         (exceptions_state_mc_init): Update.
6574         (exception_try_scope_entry): Return nullptr.
6575         (exception_try_scope_exit, exception_rethrow)
6576         (throw_exception_sjlj, throw_exception_cxx): Update.
6577         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
6578         (all_cleanups, do_cleanups, discard_cleanups)
6579         (discard_final_cleanups, save_cleanups, save_final_cleanups)
6580         (restore_cleanups, restore_final_cleanups): Don't declare.
6581         (do_final_cleanups): Remove parameter.
6582         * common/cleanups.c (cleanup_chain, make_cleanup)
6583         (make_cleanup_dtor, all_cleanups, do_cleanups)
6584         (discard_my_cleanups, discard_cleanups)
6585         (discard_final_cleanups, save_my_cleanups, save_cleanups)
6586         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
6587         (null_cleanup): Remove.
6588         (do_final_cleanups): Remove parameter.
6589
6590 2019-03-06  Tom Tromey  <tom@tromey.com>
6591
6592         * remote.c (remote_target::remote_parse_stop_reply): Use
6593         unique_xmalloc_ptr.
6594
6595 2019-03-06  Tom Tromey  <tom@tromey.com>
6596
6597         * stabsread.c (struct stabs_field_info): Rename from field_info.
6598         <list, fnlist>: Add initializers.
6599         <obstack>: New member.
6600         (read_member_functions, read_struct_fields, read_baseclasses):
6601         Allocate on obstack.  Don't use cleanups.
6602         (read_one_struct_field, read_member_functions, read_struct_fields)
6603         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
6604         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
6605         (read_struct_type): Update.
6606
6607 2019-03-06  Tom Tromey  <tom@tromey.com>
6608
6609         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
6610         * common/filestuff.h (make_cleanup_close): Don't declare.
6611         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
6612         Remove.
6613
6614 2019-03-06  Tom Tromey  <tom@tromey.com>
6615
6616         * solib-aix.c: Use make_scope_exit.
6617
6618 2019-03-06  Tom Tromey  <tom@tromey.com>
6619
6620         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
6621         Use make_scope_exit.
6622
6623 2019-03-06  Tom Tromey  <tom@tromey.com>
6624
6625         * solib-svr4.c (disable_probes_interface): Remove parameter.
6626         (svr4_handle_solib_event): Use make_scope_exit.
6627
6628 2019-03-06  Tom Tromey  <tom@tromey.com>
6629
6630         * remote.c (struct stop_reply_deleter): Remove.
6631         (stop_reply_up): Update.
6632         (struct stop_reply): Derive from notif_event.  Don't typedef.
6633         <regcache>: Now a std::vector.
6634         (stop_reply_xfree): Remove.
6635         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
6636         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
6637         (remote_target::discard_pending_stop_replies): Use delete.
6638         (remote_target::remote_parse_stop_reply): Update.
6639         (remote_target::process_stop_reply): Update.
6640         * remote-notif.h (struct notif_event): Add virtual destructor.
6641         Remove "dtr" member.
6642         (struct notif_client) <alloc_event>: Return a unique_ptr.
6643         (notif_event_xfree): Don't declare.
6644         (notif_event_up): New typedef.
6645         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
6646         (notif_event_xfree, do_notif_event_xfree): Remove.
6647         (remote_notif_state_xfree): Update.
6648
6649 2019-03-06  Tom Tromey  <tom@tromey.com>
6650
6651         * infrun.c (displaced_step_clear_cleanup): Now a
6652         forward_scope_exit type.
6653         (displaced_step_prepare_throw): Update.
6654         (displaced_step_fixup): Update.
6655
6656 2019-03-06  Tom Tromey  <tom@tromey.com>
6657
6658         * inferior.h (class inferior): Update comment.
6659         * gdbthread.h (class thread_info): Update comment.
6660
6661 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
6662             Tom Tromey  <tom@tromey.com>
6663
6664         * stabsread.h (struct stab_section_list): Remove.
6665         (coffstab_build_psymtabs): Update.
6666         * dbxread.c (symbuf_sections): Now a std::vector.
6667         (sect_idx): New global.
6668         (fill_symbuf): Update.
6669         (coffstab_build_psymtabs): Change type of stabsects parameter.
6670         Update.
6671         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6672         std::vector.
6673         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6674         (coff_locate_sections): Update.
6675         (coff_symfile_read): Remove cleanups.  Update.
6676         (init_stringtab): Add storage parameter.
6677         (free_stringtab, free_stringtab_cleanup): Remove.
6678         (init_lineno): Add storage parameter.
6679         (free_linetab, free_linetab_cleanup): Remove.
6680
6681 2019-03-06  Pedro Alves  <palves@redhat.com>
6682
6683         * linux-fork.c (fork_info::clobber_regs): Delete.
6684         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6685         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
6686         comment.  Adjust.
6687         (scoped_switch_fork_info::scoped_switch_fork_info)
6688         (checkpoint_command, linux_fork_context): Adjust
6689         fork_save_infrun_state calls.
6690
6691 2019-03-06  Pedro Alves  <palves@redhat.com>
6692
6693         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6694         (inf_has_multiple_threads): Return 'bool' and rewrite using
6695         inferior_info::threads().
6696
6697 2019-03-06  Pedro Alves  <palves@redhat.com>
6698
6699         * linux-fork.c: Include <list>.
6700         (fork_list): Now a std::list instance.
6701         (fork_info): Add ctor, dtor, and in-class initialize all fields.
6702         (forks_exist_p, find_last_fork): Adjust.
6703         (new_fork): Delete.
6704         (one_fork_p): New.
6705         (add_fork): Adjust.
6706         (free_fork): Delete, folded into fork_info::~fork_info().
6707         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6708         Adjust.
6709         (init_fork_list): Delete.
6710         (linux_fork_killall, linux_fork_mourn_inferior)
6711         (linux_fork_detach, info_checkpoints_command): Adjust.
6712         (_initialize_linux_fork): No longer call init_fork_list.
6713
6714 2019-03-06  Pedro Alves  <palves@redhat.com>
6715
6716         * linux-fork.c (new_fork): New, split out of ...
6717         (add_fork): ... this.  Return void.  Move "first fork" special
6718         case from here, to ...
6719         (checkpoint_command): ... here.
6720         * linux-linux.h (add_fork): Return void.
6721
6722 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6723
6724         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6725
6726 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6727             Chris January  <chris.january@arm.com>
6728             David Lecomber  <david.lecomber@arm.com>
6729
6730         * f-exp.y: New token, UNOP_INTRINSIC.
6731         (exp): New pattern using UNOP_INTRINSIC token.
6732         (f77_keywords): Add 'abs' keyword.
6733         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
6734         (value_from_host_double): New function.
6735         (evaluate_subexp_f): Support UNOP_ABS.
6736
6737 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6738
6739         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
6740         types.
6741
6742 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6743
6744         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
6745         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
6746         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
6747
6748 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6749
6750         * f-exp.y (convert_to_kind_type): Handle more type kinds.
6751
6752 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6753             Chris January  <chris.january@arm.com>
6754
6755         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
6756         * f-exp.y: Define 'KIND' token.
6757         (exp): New pattern for KIND expressions.
6758         (ptype): Handle types with a kind extension.
6759         (direct_abs_decl): Extend to spot kind extensions.
6760         (f77_keywords): Add 'kind' to the list.
6761         (push_kind_type): New function.
6762         (convert_to_kind_type): New function.
6763         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
6764         * parse.c (operator_length_standard): Likewise.
6765         * parser-defs.h (enum type_pieces): Add tp_kind.
6766         * std-operator.def: Add UNOP_KIND.
6767
6768 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6769
6770         * f-exp.y (f_parse): Set yydebug.
6771
6772 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6773
6774         * f-lang.c (evaluate_subexp_f): New function.
6775         (exp_descriptor_f): New global.
6776         (f_language_defn): Use exp_descriptor_f instead of
6777         exp_descriptor_standard.
6778
6779 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6780
6781         * f-exp.y (struct token): Add comments.
6782         (dot_ops): Remove uppercase versions and the end marker.
6783         (f77_keywords): Likewise.
6784         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
6785         entries in the dot_ops array are case insensitive, and use
6786         strncasecmp to compare strings.  Also some whitespace cleanup in
6787         this area.  Similar for the f77_keywords array, except entries in
6788         this list might be case sensitive.
6789
6790 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6791
6792         * f-exp.y (struct f77_boolean_val): Add comments.
6793         (boolean_values): Remove uppercase versions, and end marker.
6794         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
6795         and use strncasecmp to achieve case insensitivity.  Additionally,
6796         perform whitespace cleanup around this code.
6797
6798 2019-03-06  Tom Tromey  <tromey@adacore.com>
6799
6800         * remote-sim.c (gdbsim_target_open): Use result of
6801         gdb_argv::release.
6802
6803 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
6804         Dirk Schubert  <dirk.schubert@arm.com>
6805         Chris January  <chris.january@arm.com>
6806
6807         * eval.c (evaluate_subexp_standard): Call Fortran argument
6808         wrapping logic.
6809         * f-lang.c (struct value): A value which can be passed into a
6810         Fortran function call.
6811         (fortran_argument_convert): Wrap Fortran arguments in a pointer
6812         where appropriate.
6813         (struct type): Value ready for a Fortran function call.
6814         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
6815         is needed.
6816         * f-lang.h (fortran_argument_convert): Declaration.
6817         (fortran_preserve_arg_pointer): Declaration.
6818         * infcall.c (value_arg_coerce): Call Fortran argument logic.
6819
6820 2019-03-05  Tom Tromey  <tromey@adacore.com>
6821
6822         * python/py-prettyprint.c (print_string_repr): Remove #if.
6823         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
6824
6825 2019-03-05  Tom Tromey  <tromey@adacore.com>
6826
6827         * target.c (the_dummy_target): Move later.  Change type to
6828         "dummy_target".
6829         (initialize_targets): Don't initialize the_dummy_target.
6830
6831 2019-03-05  Tom Tromey  <tromey@adacore.com>
6832
6833         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
6834         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
6835
6836 2019-03-05  Tom Tromey  <tromey@adacore.com>
6837
6838         * windows-nat.c (windows_nat_target::attach)
6839         (windows_nat_target::detach): Don't call gdb_flush.
6840         * valprint.c (generic_val_print, val_print, val_print_string):
6841         Don't call gdb_flush.
6842         * utils.c (defaulted_query): Don't call gdb_flush.
6843         * typeprint.c (print_type_scalar): Don't call gdb_flush.
6844         * target.c (target_announce_detach): Don't call gdb_flush.
6845         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
6846         * remote.c (extended_remote_target::attach): Don't call
6847         gdb_flush.
6848         * procfs.c (procfs_target::detach): Don't call gdb_flush.
6849         * printcmd.c (do_examine): Don't call gdb_flush.
6850         (info_display_command): Don't call gdb_flush.
6851         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
6852         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
6853         * memattr.c (info_mem_command): Don't call gdb_flush.
6854         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
6855         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
6856         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
6857         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
6858         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
6859         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
6860         (gnu_nat_target::detach): Don't call gdb_flush.
6861         * f-valprint.c (f_val_print): Don't call gdb_flush.
6862         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
6863         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
6864         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
6865         gdb_flush.
6866         * c-valprint.c (c_val_print): Don't call gdb_flush.
6867         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
6868
6869 2019-03-05  Tom Tromey  <tromey@adacore.com>
6870
6871         * varobj.c (update_dynamic_varobj_children): Update.
6872         (install_default_visualizer): Use reset, not release.
6873         * value.c (set_internalvar): Update.
6874         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
6875         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
6876         ATTRIBUTE_UNUSED_RESULT.
6877
6878 2019-03-05  Tom Tromey  <tromey@adacore.com>
6879
6880         * remote.c (class scoped_remote_fd) <release>: Add
6881         ATTRIBUTE_UNUSED_RESULT.
6882
6883 2019-03-05  Tom Tromey  <tromey@adacore.com>
6884
6885         * macroexp.c (struct macro_buffer) <release>: Add
6886         ATTRIBUTE_UNUSED_RESULT.
6887
6888 2019-03-05  Tom Tromey  <tromey@adacore.com>
6889
6890         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
6891         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
6892         ATTRIBUTE_UNUSED_RESULT.
6893
6894 2019-03-05  Tom Tromey  <tromey@adacore.com>
6895
6896         * common/scoped_fd.h (class scoped_fd) <release>: Add
6897         ATTRIBUTE_UNUSED_RESULT.
6898
6899 2019-03-05  Tom Tromey  <tromey@adacore.com>
6900
6901         * parser-defs.h (struct parser_state) <release>: Add
6902         ATTRIBUTE_UNUSED_RESULT.
6903
6904 2019-03-05  Tom Tromey  <tromey@adacore.com>
6905
6906         * utils.h (class gdb_argv) <release>: Add
6907         ATTRIBUTE_UNUSED_RESULT.
6908         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
6909
6910 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
6911
6912         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
6913         for-loop range, to avoid compiler warnings.
6914
6915         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
6916         avoid compiler warnings about unused variables.
6917
6918         * NEWS: Mention end of support for native debugging on MS-Windows
6919         before XP.
6920
6921         PR gdb/24292
6922         * common/netstuff.c:
6923         * gdbserver/gdbreplay.c
6924         * gdbserver/remote-utils.c:
6925         * ser-tcp.c:
6926         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
6927         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
6928         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
6929         'getaddrinfo' and 'freeaddrinfo' were not available before
6930         Windows XP, and mingw.org's MinGW headers by default define
6931         _WIN32_WINNT to 0x500.
6932
6933 2019-03-01  Gary Benson <gbenson@redhat.com>
6934
6935         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
6936
6937 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
6938             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
6939
6940         PR gdb/8527
6941         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
6942         set_sigint_trap, clear_sigint_trap.
6943
6944 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6945
6946         * target.c (target_detach): Clear the regcache and the
6947         frame cache.
6948
6949 2019-02-27  Pedro Alves  <palves@redhat.com>
6950
6951         * utils.c (set_screen_size): When we cap the height/width sizes,
6952         tweak the corresponding command variable to show "unlimited":
6953
6954 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
6955             Pedro Alves  <palves@redhat.com>
6956
6957         * utils.c (set_screen_size): Reduce "infinite" rows and columns
6958         before calling rl_set_screen_size.
6959
6960 2019-02-27  Tom Tromey  <tromey@adacore.com>
6961
6962         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
6963         define.
6964         * python/py-value.c: Remove Python 2.4 workaround.
6965         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
6966         workaround.
6967         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
6968         Python 2.4 workaround.
6969         * python/python-internal.h: Remove Python 2.4 comment.
6970         (Py_ssize_t): Don't define.
6971         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
6972         (gdb_Py_DECREF): Remove Python 2.4 workaround.
6973         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
6974         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
6975         * python/python.c (do_start_initialization): Remove Python 2.4
6976         workaround.
6977         * python/py-prettyprint.c (class dummy_python_frame): Remove.
6978         (print_children): Remove Python 2.4 workaround.
6979         * python/py-inferior.c (buffer_procs): Remove Python 2.4
6980         workaround.
6981         (CHARBUFFERPROC_NAME): Remove.
6982         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
6983         Python 2.4 workaround.
6984
6985 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6986
6987         * NEWS: Note minimum Python version.
6988
6989 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6990
6991         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
6992         code from these functions.  Remove corresponding ifdefs.  Use
6993         Py_buffer_up instead of explicit calls to PyBuffer_Release.
6994         Remove gotos and target of gotos.
6995         (infpy_search_memory): Likewise.
6996
6997 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6998
6999         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7000         (hppa_gdbarch_init): Don't register deleted functions with
7001         gdbarch.
7002
7003 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7004
7005         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7006         (h8300_unwind_sp): Delete.
7007         (h8300_dummy_id): Delete.
7008         (h8300_gdbarch_init): Don't register deleted functions with
7009         gdbarch.
7010
7011 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7012
7013         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7014         (ft32_unwind_pc): Delete.
7015         (ft32_unwind_sp): Delete.
7016         (ft32_gdbarch_init): Don't register deleted functions with
7017         gdbarch.
7018
7019 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7020
7021         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7022         (frv_unwind_pc): Delete.
7023         (frv_unwind_sp): Delete.
7024         (frv_gdbarch_init): Don't register deleted functions with
7025         gdbarch.
7026
7027 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7028
7029         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7030         (riscv_unwind_pc): Delete.
7031         (riscv_unwind_sp): Delete.
7032         (riscv_gdbarch_init): Don't register deleted functions with
7033         gdbarch.
7034
7035 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7036
7037         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7038         (csky_unwind_pc): Delete.
7039         (csky_unwind_sp): Delete.
7040         (csky_gdbarch_init): Don't register deleted functions with
7041         gdbarch.
7042
7043 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7044
7045         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7046         (cris_unwind_pc): Delete.
7047         (cris_unwind_sp): Delete.
7048         (cris_gdbarch_init): Don't register deleted functions with
7049         gdbarch.
7050
7051 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7052
7053         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7054         (bfin_unwind_pc): Delete.
7055         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7056
7057 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7058
7059         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7060         (arm_unwind_pc): Delete.
7061         (arm_unwind_sp): Delete.
7062         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7063
7064 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7065
7066         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7067         (arc_unwind_pc): Delete.
7068         (arc_unwind_sp): Delete.
7069         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7070
7071 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7072
7073         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7074         (alpha_unwind_pc): Delete.
7075         (alpha_gdbarch_init): Don't register deleted functions with
7076         gdbarch.
7077
7078 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7079
7080         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7081         (aarch64_unwind_pc): Delete.
7082         (aarch64_unwind_sp): Delete.
7083         (aarch64_gdbarch_init): Don't register deleted functions with
7084         gdbarch.
7085
7086 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7087
7088         * gdbtypes.c (type_align): Don't consider static members when
7089         computing structure alignment.
7090
7091 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7092
7093         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7094         return 0 for other types.
7095         * arch-utils.c (default_type_align): Always return 0.
7096         * gdbarch.h: Regenerate.
7097         * gdbarch.sh (type_align): Extend comment.
7098         * gdbtypes.c (type_align): Add additional comments, always call
7099         gdbarch_type_align before applying the default rules.
7100         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7101         generic code will then apply a suitable default.
7102         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7103         types, return 0 for other types.
7104
7105 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7106
7107         * NEWS: Create a new section for the next release branch.
7108         Rename the section of the current branch, now that it has
7109         been cut.
7110
7111 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7112
7113         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7114         * version.in: Bump version to 8.3.50.DATE-git.
7115
7116 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7117
7118         * aix-thread.c (ptid_cmp): Remove unused variable.
7119         (get_signaled_thread): Likewise.
7120         (store_regs_user_thread): Likewise.
7121         (store_regs_kernel_thread): Likewise.
7122         (fetch_regs_kernel_thread): Remove shadowed variable.
7123
7124 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7125
7126         * features/riscv/32bit-cpu.xml: Add register numbers.
7127         * features/riscv/32bit-fpu.c: Regenerate.
7128         * features/riscv/32bit-fpu.xml: Add register numbers.
7129         * features/riscv/64bit-cpu.xml: Add register numbers.
7130         * features/riscv/64bit-fpu.c: Regenerate.
7131         * features/riscv/64bit-fpu.xml: Add register numbers.
7132
7133 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7134
7135         * NEWS: Mention two argument form of gdb.Value constructor.
7136         * python/py-value.c (convert_buffer_and_type_to_value): New
7137         function.
7138         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7139         Add support for handling an optional second argument.  Call
7140         convert_buffer_and_type_to_value as appropriate.
7141         * python/python-internal.h (Py_buffer_deleter): New struct.
7142         (Py_buffer_up): New typedef.
7143
7144 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7145
7146         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7147         instead of releasing ownership.
7148
7149 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7150
7151         * dwarf2read.c (open_and_init_dwp_file): Call
7152         elf_numsections instead of bfd_count_sections to initialize
7153         dwp_file->num_sections.
7154
7155 2019-02-25  Tom Tromey  <tromey@adacore.com>
7156
7157         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7158
7159 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7160
7161         * gcore.in: Add '--readnever' option when invoking GDB.
7162
7163 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7164
7165         * MAINTAINERS: Update my email address.
7166
7167 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7168
7169         * build-id.c (build_id_to_debug_bfd_1): New function.
7170         (build_id_to_debug_bfd): Look for separate debug file in
7171         sysroot.
7172
7173 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7174
7175         * gdbarch.sh: Update the copyright year range that is placed into
7176         generated files.
7177
7178 2019-02-22  Keith Seitz  <keiths@redhat.com>
7179
7180         PR symtab/23853
7181         * linespec.c (create_sals_line_offset): Search for the default
7182         symtab's filename instead of its fullname.
7183
7184 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7185
7186         * NEWS: Update style defaults.
7187
7188 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7189
7190         * main.c (captured_main_1): Disable styling in batch mode.
7191
7192 2019-02-20  Tom Tromey  <tom@tromey.com>
7193
7194         * symtab.c (symtab_symbol_info): Fix typos.
7195
7196 2019-02-20  Tom Tromey  <tromey@adacore.com>
7197
7198         * findcmd.c (_initialize_mem_search): Use upper case for
7199         metasyntactic variables.
7200
7201 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7202
7203         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7204         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7205
7206 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7207
7208         * top.h (source_file_name): Change to std::string.
7209         * top.c (source_file_name): Likewise.
7210         (command_line_input): Adjust.
7211         * cli/cli-script.c (script_from_file): Adjust.
7212
7213 2019-02-19  Tom Tromey  <tromey@adacore.com>
7214
7215         * ravenscar-thread.c
7216         (ravenscar_thread_target::update_thread_list): Don't call
7217         ada_build_task_list.
7218         * ada-lang.h (ada_build_task_list): Don't declare.
7219         * ada-tasks.c (struct ada_tasks_inferior_data)
7220         <task_list_valid_p>: Now bool.
7221         (read_known_tasks, ada_task_list_changed)
7222         (ada_tasks_invalidate_inferior_data): Update.
7223         (read_known_tasks_array): Return bool.
7224         (read_known_tasks_list): Likewise.
7225         (read_known_tasks): Return void.
7226         (ada_build_task_list): Now static.
7227
7228 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7229
7230         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7231         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7232
7233 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7234
7235         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7236         variant for ada_tasks_pspace_data_handle and
7237         ada_tasks_inferior_data_handle.
7238         (ada_tasks_pspace_data_cleanup): New function.
7239         (ada_tasks_inferior_data_cleanup): New function.
7240
7241 2019-02-17  Tom Tromey  <tom@tromey.com>
7242
7243         * macrotab.h (macro_source_fullname): Return a std::string.
7244         * macrotab.c (macro_include, check_for_redefinition)
7245         (macro_undef, macro_lookup_definition, foreach_macro)
7246         (foreach_macro_in_scope): Update.
7247         (macro_source_fullname): Return a std::string.
7248         * macrocmd.c (show_pp_source_pos): Update.
7249
7250 2019-02-17  Tom Tromey  <tom@tromey.com>
7251
7252         * macrocmd.c (show_pp_source_pos): Style the file names.
7253
7254 2019-02-17  Tom Tromey  <tom@tromey.com>
7255
7256         PR tui/24197:
7257         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7258
7259 2019-02-17  Tom Tromey  <tom@tromey.com>
7260
7261         * ada-lang.c (user_select_syms): Use filtered printing.
7262         * utils.c (wrap_style): New global.
7263         (desired_style): Remove.
7264         (emit_style_escape): Add stream parameter.
7265         (set_output_style, reset_terminal_style, prompt_for_continue):
7266         Update.
7267         (flush_wrap_buffer): Only flush gdb_stdout.
7268         (wrap_here): Set wrap_style.
7269         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7270         treat escape sequences as a character.  Change when wrap buffer is
7271         flushed.
7272         (fputs_styled): Do not set the output style when the default is
7273         requested.
7274         * ui-style.h (struct ui_file_style) <is_default>: New method.
7275         * source.c (print_source_lines_base): Emit escape sequences in one
7276         piece.
7277
7278 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7279
7280         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7281         integers and enumeration types.
7282
7283 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7284
7285         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7286         instead of lookup_symbol_in_language
7287         (do_exact_match): New function.
7288         (ada_get_symbol_name_matcher): Return do_exact_match when
7289         doing a verbatim match.
7290
7291 2019-02-15  Tom Tromey  <tromey@adacore.com>
7292
7293         * ravenscar-thread.c (ravenscar_thread_target::resume)
7294         (ravenscar_thread_target::wait): Special case wildcard requests.
7295
7296 2019-02-15  Tom Tromey  <tromey@adacore.com>
7297
7298         * ravenscar-thread.c (base_ptid): Remove.
7299         (struct ravenscar_thread_target) <close>: New method.
7300         <m_base_ptid>: New member.
7301         <update_inferior_ptid, active_task, task_is_currently_active,
7302         runtime_initialized>: Declare methods.
7303         <ravenscar_thread_target>: Add constructor.
7304         (ravenscar_thread_target::task_is_currently_active)
7305         (ravenscar_thread_target::update_inferior_ptid)
7306         (ravenscar_runtime_initialized): Rename.  Now methods.
7307         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7308         (ravenscar_thread_target::update_thread_list): Update.
7309         (ravenscar_thread_target::active_task): Now method.
7310         (ravenscar_thread_target::store_registers)
7311         (ravenscar_thread_target::prepare_to_store)
7312         (ravenscar_thread_target::prepare_to_store)
7313         (ravenscar_thread_target::mourn_inferior): Update.
7314         (ravenscar_inferior_created): Use "new" to create target.
7315         (ravenscar_thread_target::get_ada_task_ptid): Update.
7316         (_initialize_ravenscar): Don't initialize base_ptid.
7317         (ravenscar_ops): Remove global.
7318
7319 2019-02-15  Tom Tromey  <tromey@adacore.com>
7320
7321         * target.h (push_target): Declare new overload.
7322         * target.c (push_target): New overload, taking an rvalue reference.
7323         * remote.c (remote_target::open_1): Use push_target overload.
7324         * corelow.c (core_target_open): Use push_target overload.
7325
7326 2019-02-15  Tom Tromey  <tromey@adacore.com>
7327
7328         * ravenscar-thread.c (is_ravenscar_task)
7329         (ravenscar_task_is_currently_active): Return bool.
7330         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7331         (_initialize_ravenscar): Remove "(void)".
7332         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7333         Return bool.
7334
7335 2019-02-15  Tom Tromey  <tromey@adacore.com>
7336
7337         * ravenscar-thread.c (ravenscar_runtime_initializer)
7338         (has_ravenscar_runtime, get_running_thread_id)
7339         (ravenscar_thread_target::resume): Fix indentation.
7340
7341 2019-02-15  Tom Tromey  <tromey@adacore.com>
7342
7343         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7344         from ravenscar_arch_ops.
7345         (sparc_ravenscar_ops::fetch_registers)
7346         (sparc_ravenscar_ops::store_registers): Now methods.
7347         (sparc_ravenscar_prepare_to_store): Remove.
7348         (sparc_ravenscar_ops): Redefine.
7349         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7350         methods and destructor.  Remove members.
7351         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7352         (ravenscar_thread_target::store_registers)
7353         (ravenscar_thread_target::prepare_to_store): Update.
7354         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7355         Remove.
7356         (struct ppc_ravenscar_powerpc_ops): Derive from
7357         ravenscar_arch_ops.
7358         (ppc_ravenscar_powerpc_ops::fetch_registers)
7359         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7360         (ppc_ravenscar_powerpc_ops): Redefine.
7361         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7362         (ppc_ravenscar_e500_ops::fetch_registers)
7363         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7364         (ppc_ravenscar_e500_ops): Redefine.
7365         * aarch64-ravenscar-thread.c
7366         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7367         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7368         (aarch64_ravenscar_fetch_registers)
7369         (aarch64_ravenscar_store_registers): Now methods.
7370         (aarch64_ravenscar_ops): Redefine.
7371
7372 2019-02-15  Tom Tromey  <tromey@adacore.com>
7373
7374         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7375         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7376         (ravenscar_thread_target::stopped_by_watchpoint)
7377         (ravenscar_thread_target::stopped_data_address)
7378         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7379
7380 2019-02-15  Tom Tromey  <tromey@adacore.com>
7381
7382         * ravenscar-thread.c: Fix some typos.
7383
7384 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7385             Tom Tromey  <tromey@adacore.com>
7386
7387         * ada-lang.c (ada_exception_sal): Change addr_string to a
7388         std::string.
7389         (create_ada_exception_catchpoint): Update.
7390
7391 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7392             Tom Tromey  <tromey@adacore.com>
7393
7394         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7395         (bp_location_ops): Remove.
7396         (base_breakpoint_allocate_location): Update.
7397         (free_bp_location): Update.
7398         * ada-lang.c (class ada_catchpoint_location)
7399         <ada_catchpoint_location>: Remove ops parameter.
7400         (ada_catchpoint_location_dtor): Remove.
7401         (ada_catchpoint_location_ops): Remove.
7402         (allocate_location_exception): Update.
7403         * breakpoint.h (struct bp_location_ops): Remove.
7404         (class bp_location) <bp_location>: Remove bp_location_ops
7405         parameter.
7406         <~bp_location>: Add destructor.
7407         <ops>: Remove.
7408
7409 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7410             Pedro Alves  <palves@redhat.com>
7411
7412         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7413         'PATH_MAX'.
7414
7415 2019-02-14  David Michael  <fedora.dm0@gmail.com>
7416             Samuel Thibault  <samuel.thibault@gnu.org>
7417             Thomas Schwinge  <thomas@codesourcery.com>
7418
7419         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7420         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
7421
7422 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7423
7424         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7425         (check_empty): Use "const char *".
7426
7427         * gnu-nat.c (gnu_nat_target::detach): Instead of
7428         'detach_inferior (pid)' call
7429         'detach_inferior (find_inferior_pid (pid))'.
7430
7431         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7432         'nat/fork-inferior.o'.
7433         * gnu-nat.c: #include "nat/fork-inferior.h".
7434
7435         * gnu-nat.c (gnu_nat_target::detach): Instead of
7436         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
7437         * gnu-nat.h: #include "inf-child.h".
7438         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
7439         'i386_gnu_nat_target::fetch_registers'.
7440         (gnu_store_registers): Rename/move to
7441         'i386_gnu_nat_target::store_registers'.
7442
7443         * config/i386/nm-i386gnu.h: Don't "#include" any files.
7444         * gnu-nat.h (mach_thread_info): New function.
7445         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
7446
7447         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
7448
7449 2019-02-14  Frederic Konrad  <konrad@adacore.com>
7450
7451         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
7452
7453 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
7454
7455         * windows-nat.c (windows_add_thread): Add new parameter
7456         "main_thread_p" with default value set to false.  Update
7457         function documentation as well as all callers.
7458         (windows_delete_thread): Likewise.
7459         (fake_create_process): Update call to windows_add_thread.
7460         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
7461         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
7462         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
7463         call to windows_delete_thread.
7464
7465 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
7466
7467         * MAINTAINERS: Add Andrew Burgess as global maintainer.
7468
7469 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7470
7471         * symfile.c (find_separate_debug_file): Use canonical path of
7472         sysroot with child_path instead of gdb_sysroot if it is valid.
7473
7474 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7475
7476         * symfile.c (find_separate_debug_file): Use child_path to
7477         determine if an object file is under a sysroot.
7478
7479 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7480
7481         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
7482         unittests/child-path-selftests.c.
7483         * common/pathstuff.c (child_path): New function.
7484         * common/pathstuff.h (child_path): New prototype.
7485         * unittests/child-path-selftests.c: New file.
7486
7487 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7488
7489         * symfile.c (find_separate_debug_file): Look for separate debug
7490         files in debug directories under the sysroot.
7491
7492 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7493
7494         * symtab.h (struct minimal_symbol data_p): New const method.
7495         (struct minimal_symbol text_p): Likewise.
7496         * symtab.c (output_source_filename): Use file name style
7497         to print file name.
7498         (print_symbol_info): Likewise.
7499         (print_msymbol_info): Use address style to print addresses.
7500         Use function name style to print executable text symbols.
7501         (expand_symtab_containing_pc): Use data_p.
7502         (find_pc_sect_compunit_symtab): Likewise.
7503
7504 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7505
7506         * breakpoint.c (describe_other_breakpoints): Use address style
7507         to print addresses.
7508         (say_where): Likewise.
7509
7510 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7511
7512         * ada-typeprint.c (print_func_type): Print function name
7513         style to print function name.
7514         * c-typeprint.c (c_print_type_1): Likewise.
7515
7516 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
7517
7518         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
7519         for execve.
7520
7521 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7522
7523         * c-exp.y (direct_abs_decl): Use emplace_back to record the
7524         type_stack.
7525
7526 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
7527
7528         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
7529         TYPE_CODE_REF types.
7530
7531 2019-02-08  Jim Wilson  <jimw@sifive.com>
7532
7533         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
7534         (riscv_linux_fregset): New.
7535         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
7536
7537 2019-02-07  Tom Tromey  <tom@tromey.com>
7538
7539         * thread.c (thread_cancel_execution_command): Update.
7540         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
7541         methods.
7542         (struct thread_fsm_ops): Remove.
7543         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
7544         (thread_fsm_should_stop, thread_fsm_return_value)
7545         (thread_fsm_set_finished, thread_fsm_finished_p)
7546         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
7547         Don't declare.
7548         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
7549         * infrun.c (clear_proceed_status_thread)
7550         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
7551         (print_stop_event): Update.
7552         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
7553         Add constructor.
7554         (step_command_fsm_ops): Remove.
7555         (new_step_command_fsm): Remove.
7556         (step_1): Update.
7557         (step_command_fsm::should_stop): Rename from
7558         step_command_fsm_should_stop.
7559         (step_command_fsm::clean_up): Rename from
7560         step_command_fsm_clean_up.
7561         (step_command_fsm::do_async_reply_reason): Rename from
7562         step_command_fsm_async_reply_reason.
7563         (struct until_next_fsm): Inherit from thread_fsm.  Add
7564         constructor.
7565         (until_next_fsm_ops): Remove.
7566         (new_until_next_fsm): Remove.
7567         (until_next_fsm::should_stop): Rename from
7568         until_next_fsm_should_stop.
7569         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
7570         (until_next_fsm::do_async_reply_reason): Rename from
7571         until_next_fsm_async_reply_reason.
7572         (struct finish_command_fsm): Inherit from thread_fsm.  Add
7573         constructor.  Change type of breakpoint.
7574         (finish_command_fsm_ops): Remove.
7575         (new_finish_command_fsm): Remove.
7576         (finish_command_fsm::should_stop): Rename from
7577         finish_command_fsm_should_stop.
7578         (finish_command_fsm::clean_up): Rename from
7579         finish_command_fsm_clean_up.
7580         (finish_command_fsm::return_value): Rename from
7581         finish_command_fsm_return_value.
7582         (finish_command_fsm::do_async_reply_reason): Rename from
7583         finish_command_fsm_async_reply_reason.
7584         (finish_command): Update.
7585         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
7586         Add constructor.
7587         (call_thread_fsm_ops): Remove.
7588         (call_thread_fsm::call_thread_fsm): Rename from
7589         new_call_thread_fsm.
7590         (call_thread_fsm::should_stop): Rename from
7591         call_thread_fsm_should_stop.
7592         (call_thread_fsm::should_notify_stop): Rename from
7593         call_thread_fsm_should_notify_stop.
7594         (run_inferior_call, call_function_by_hand_dummy): Update.
7595         * cli/cli-interp.c (should_print_stop_to_console): Update.
7596         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
7597         Add constructor.  Change type of location_breakpoint,
7598         caller_breakpoint.
7599         (until_break_fsm_ops): Remove.
7600         (new_until_break_fsm): Remove.
7601         (until_break_fsm::should_stop): Rename from
7602         until_break_fsm_should_stop.
7603         (until_break_fsm::clean_up): Rename from
7604         until_break_fsm_clean_up.
7605         (until_break_fsm::do_async_reply_reason): Rename from
7606         until_break_fsm_async_reply_reason.
7607         (until_break_command): Update.
7608         * thread-fsm.c: Remove.
7609         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
7610
7611 2019-02-07  Tom Tromey  <tom@tromey.com>
7612
7613         * yy-remap.h: Add include guard.
7614         * xtensa-tdep.h: Add include guard.
7615         * xcoffread.h: Rename include guard.
7616         * varobj-iter.h: Add include guard.
7617         * tui/tui.h: Rename include guard.
7618         * tui/tui-winsource.h: Rename include guard.
7619         * tui/tui-wingeneral.h: Rename include guard.
7620         * tui/tui-windata.h: Rename include guard.
7621         * tui/tui-win.h: Rename include guard.
7622         * tui/tui-stack.h: Rename include guard.
7623         * tui/tui-source.h: Rename include guard.
7624         * tui/tui-regs.h: Rename include guard.
7625         * tui/tui-out.h: Rename include guard.
7626         * tui/tui-layout.h: Rename include guard.
7627         * tui/tui-io.h: Rename include guard.
7628         * tui/tui-hooks.h: Rename include guard.
7629         * tui/tui-file.h: Rename include guard.
7630         * tui/tui-disasm.h: Rename include guard.
7631         * tui/tui-data.h: Rename include guard.
7632         * tui/tui-command.h: Rename include guard.
7633         * tic6x-tdep.h: Add include guard.
7634         * target/waitstatus.h: Rename include guard.
7635         * target/wait.h: Rename include guard.
7636         * target/target.h: Rename include guard.
7637         * target/resume.h: Rename include guard.
7638         * target-float.h: Rename include guard.
7639         * stabsread.h: Add include guard.
7640         * rs6000-tdep.h: Add include guard.
7641         * riscv-fbsd-tdep.h: Add include guard.
7642         * regformats/regdef.h: Rename include guard.
7643         * record.h: Rename include guard.
7644         * python/python.h: Rename include guard.
7645         * python/python-internal.h: Rename include guard.
7646         * python/py-stopevent.h: Rename include guard.
7647         * python/py-ref.h: Rename include guard.
7648         * python/py-record.h: Rename include guard.
7649         * python/py-record-full.h: Rename include guard.
7650         * python/py-record-btrace.h: Rename include guard.
7651         * python/py-instruction.h: Rename include guard.
7652         * python/py-events.h: Rename include guard.
7653         * python/py-event.h: Rename include guard.
7654         * procfs.h: Add include guard.
7655         * proc-utils.h: Add include guard.
7656         * p-lang.h: Add include guard.
7657         * or1k-tdep.h: Rename include guard.
7658         * observable.h: Rename include guard.
7659         * nto-tdep.h: Rename include guard.
7660         * nat/x86-linux.h: Rename include guard.
7661         * nat/x86-linux-dregs.h: Rename include guard.
7662         * nat/x86-gcc-cpuid.h: Add include guard.
7663         * nat/x86-dregs.h: Rename include guard.
7664         * nat/x86-cpuid.h: Rename include guard.
7665         * nat/ppc-linux.h: Rename include guard.
7666         * nat/mips-linux-watch.h: Rename include guard.
7667         * nat/linux-waitpid.h: Rename include guard.
7668         * nat/linux-ptrace.h: Rename include guard.
7669         * nat/linux-procfs.h: Rename include guard.
7670         * nat/linux-osdata.h: Rename include guard.
7671         * nat/linux-nat.h: Rename include guard.
7672         * nat/linux-namespaces.h: Rename include guard.
7673         * nat/linux-btrace.h: Rename include guard.
7674         * nat/glibc_thread_db.h: Rename include guard.
7675         * nat/gdb_thread_db.h: Rename include guard.
7676         * nat/gdb_ptrace.h: Rename include guard.
7677         * nat/fork-inferior.h: Rename include guard.
7678         * nat/amd64-linux-siginfo.h: Rename include guard.
7679         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7680         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7681         * nat/aarch64-linux.h: Rename include guard.
7682         * nat/aarch64-linux-hw-point.h: Rename include guard.
7683         * mn10300-tdep.h: Add include guard.
7684         * mips-linux-tdep.h: Add include guard.
7685         * mi/mi-parse.h: Rename include guard.
7686         * mi/mi-out.h: Rename include guard.
7687         * mi/mi-main.h: Rename include guard.
7688         * mi/mi-interp.h: Rename include guard.
7689         * mi/mi-getopt.h: Rename include guard.
7690         * mi/mi-console.h: Rename include guard.
7691         * mi/mi-common.h: Rename include guard.
7692         * mi/mi-cmds.h: Rename include guard.
7693         * mi/mi-cmd-break.h: Rename include guard.
7694         * m2-lang.h: Add include guard.
7695         * location.h: Rename include guard.
7696         * linux-record.h: Rename include guard.
7697         * linux-nat.h: Add include guard.
7698         * linux-fork.h: Add include guard.
7699         * i386-darwin-tdep.h: Rename include guard.
7700         * hppa-linux-offsets.h: Add include guard.
7701         * guile/guile.h: Rename include guard.
7702         * guile/guile-internal.h: Rename include guard.
7703         * gnu-nat.h: Rename include guard.
7704         * gdb-stabs.h: Rename include guard.
7705         * frv-tdep.h: Add include guard.
7706         * f-lang.h: Add include guard.
7707         * event-loop.h: Add include guard.
7708         * darwin-nat.h: Rename include guard.
7709         * cp-abi.h: Rename include guard.
7710         * config/sparc/nm-sol2.h: Rename include guard.
7711         * config/nm-nto.h: Rename include guard.
7712         * config/nm-linux.h: Add include guard.
7713         * config/i386/nm-i386gnu.h: Rename include guard.
7714         * config/djgpp/nl_types.h: Rename include guard.
7715         * config/djgpp/langinfo.h: Rename include guard.
7716         * compile/gcc-cp-plugin.h: Add include guard.
7717         * compile/gcc-c-plugin.h: Add include guard.
7718         * compile/compile.h: Rename include guard.
7719         * compile/compile-object-run.h: Rename include guard.
7720         * compile/compile-object-load.h: Rename include guard.
7721         * compile/compile-internal.h: Rename include guard.
7722         * compile/compile-cplus.h: Rename include guard.
7723         * compile/compile-c.h: Rename include guard.
7724         * common/xml-utils.h: Rename include guard.
7725         * common/x86-xstate.h: Rename include guard.
7726         * common/version.h: Rename include guard.
7727         * common/vec.h: Rename include guard.
7728         * common/tdesc.h: Rename include guard.
7729         * common/selftest.h: Rename include guard.
7730         * common/scoped_restore.h: Rename include guard.
7731         * common/scoped_mmap.h: Rename include guard.
7732         * common/scoped_fd.h: Rename include guard.
7733         * common/safe-iterator.h: Rename include guard.
7734         * common/run-time-clock.h: Rename include guard.
7735         * common/refcounted-object.h: Rename include guard.
7736         * common/queue.h: Rename include guard.
7737         * common/ptid.h: Rename include guard.
7738         * common/print-utils.h: Rename include guard.
7739         * common/preprocessor.h: Rename include guard.
7740         * common/pathstuff.h: Rename include guard.
7741         * common/observable.h: Rename include guard.
7742         * common/netstuff.h: Rename include guard.
7743         * common/job-control.h: Rename include guard.
7744         * common/host-defs.h: Rename include guard.
7745         * common/gdb_wait.h: Rename include guard.
7746         * common/gdb_vecs.h: Rename include guard.
7747         * common/gdb_unlinker.h: Rename include guard.
7748         * common/gdb_unique_ptr.h: Rename include guard.
7749         * common/gdb_tilde_expand.h: Rename include guard.
7750         * common/gdb_sys_time.h: Rename include guard.
7751         * common/gdb_string_view.h: Rename include guard.
7752         * common/gdb_splay_tree.h: Rename include guard.
7753         * common/gdb_setjmp.h: Rename include guard.
7754         * common/gdb_ref_ptr.h: Rename include guard.
7755         * common/gdb_optional.h: Rename include guard.
7756         * common/gdb_locale.h: Rename include guard.
7757         * common/gdb_assert.h: Rename include guard.
7758         * common/filtered-iterator.h: Rename include guard.
7759         * common/filestuff.h: Rename include guard.
7760         * common/fileio.h: Rename include guard.
7761         * common/environ.h: Rename include guard.
7762         * common/common-utils.h: Rename include guard.
7763         * common/common-types.h: Rename include guard.
7764         * common/common-regcache.h: Rename include guard.
7765         * common/common-inferior.h: Rename include guard.
7766         * common/common-gdbthread.h: Rename include guard.
7767         * common/common-exceptions.h: Rename include guard.
7768         * common/common-defs.h: Rename include guard.
7769         * common/common-debug.h: Rename include guard.
7770         * common/cleanups.h: Rename include guard.
7771         * common/buffer.h: Rename include guard.
7772         * common/btrace-common.h: Rename include guard.
7773         * common/break-common.h: Rename include guard.
7774         * cli/cli-utils.h: Rename include guard.
7775         * cli/cli-style.h: Rename include guard.
7776         * cli/cli-setshow.h: Rename include guard.
7777         * cli/cli-script.h: Rename include guard.
7778         * cli/cli-interp.h: Rename include guard.
7779         * cli/cli-decode.h: Rename include guard.
7780         * cli/cli-cmds.h: Rename include guard.
7781         * charset-list.h: Add include guard.
7782         * buildsym-legacy.h: Rename include guard.
7783         * bfin-tdep.h: Add include guard.
7784         * ax.h: Rename include guard.
7785         * arm-linux-tdep.h: Add include guard.
7786         * arm-fbsd-tdep.h: Add include guard.
7787         * arch/xtensa.h: Rename include guard.
7788         * arch/tic6x.h: Add include guard.
7789         * arch/i386.h: Add include guard.
7790         * arch/arm.h: Rename include guard.
7791         * arch/arm-linux.h: Rename include guard.
7792         * arch/arm-get-next-pcs.h: Rename include guard.
7793         * arch/amd64.h: Add include guard.
7794         * arch/aarch64-insn.h: Rename include guard.
7795         * arch-utils.h: Rename include guard.
7796         * annotate.h: Add include guard.
7797         * amd64-darwin-tdep.h: Rename include guard.
7798         * aarch64-linux-tdep.h: Add include guard.
7799         * aarch64-fbsd-tdep.h: Add include guard.
7800         * aarch32-linux-nat.h: Add include guard.
7801
7802 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7803
7804         * macrotab.c (macro_define_internal): New function that
7805         factorizes macro_define_object_internal and macro_define_function
7806         code.
7807         (macro_define_object_internal): Use macro_define_internal.
7808         (macro_define_function): Likewise.
7809
7810 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7811
7812         * macrocmd.c (extract_identifier): Return
7813         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
7814         callers.
7815
7816 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
7817
7818         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
7819
7820 2019-02-05  Tom Tromey  <tom@tromey.com>
7821
7822         * target.c (target_stack::unpush): Move assertion earlier.
7823
7824 2019-01-30  Tom Tromey  <tom@tromey.com>
7825
7826         PR python/23615:
7827         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
7828         (gdbpy_parse_and_eval): Likewise.
7829         * python/python-internal.h (gdbpy_allow_threads): New class.
7830
7831 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
7832
7833         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
7834         (aarch64_fbsd_fpregmap): Move earlier.
7835         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
7836         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7837         instead of individual calls to trad_frame_set_reg_addr.
7838         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
7839         earlier.
7840         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
7841         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7842         instead of individual calls to trad_frame_set_reg_addr.
7843
7844 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
7845
7846         * CONTRIBUTE: Replace contribution list with wiki link.
7847
7848 2019-01-25  Tom Tromey  <tom@tromey.com>
7849
7850         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
7851
7852 2019-01-25  Tom Tromey  <tom@tromey.com>
7853
7854         * xtensa-linux-nat.c: Fix common/ includes.
7855         * xml-support.h: Fix common/ includes.
7856         * xml-support.c: Fix common/ includes.
7857         * x86-linux-nat.c: Fix common/ includes.
7858         * windows-nat.c: Fix common/ includes.
7859         * varobj.h: Fix common/ includes.
7860         * varobj.c: Fix common/ includes.
7861         * value.c: Fix common/ includes.
7862         * valops.c: Fix common/ includes.
7863         * utils.c: Fix common/ includes.
7864         * unittests/xml-utils-selftests.c: Fix common/ includes.
7865         * unittests/utils-selftests.c: Fix common/ includes.
7866         * unittests/unpack-selftests.c: Fix common/ includes.
7867         * unittests/tracepoint-selftests.c: Fix common/ includes.
7868         * unittests/style-selftests.c: Fix common/ includes.
7869         * unittests/string_view-selftests.c: Fix common/ includes.
7870         * unittests/scoped_restore-selftests.c: Fix common/ includes.
7871         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
7872         * unittests/scoped_fd-selftests.c: Fix common/ includes.
7873         * unittests/rsp-low-selftests.c: Fix common/ includes.
7874         * unittests/parse-connection-spec-selftests.c: Fix common/
7875         includes.
7876         * unittests/optional-selftests.c: Fix common/ includes.
7877         * unittests/offset-type-selftests.c: Fix common/ includes.
7878         * unittests/observable-selftests.c: Fix common/ includes.
7879         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
7880         * unittests/memrange-selftests.c: Fix common/ includes.
7881         * unittests/memory-map-selftests.c: Fix common/ includes.
7882         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
7883         * unittests/function-view-selftests.c: Fix common/ includes.
7884         * unittests/environ-selftests.c: Fix common/ includes.
7885         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
7886         * unittests/common-utils-selftests.c: Fix common/ includes.
7887         * unittests/cli-utils-selftests.c: Fix common/ includes.
7888         * unittests/array-view-selftests.c: Fix common/ includes.
7889         * ui-file.c: Fix common/ includes.
7890         * tui/tui-io.c: Fix common/ includes.
7891         * tracepoint.h: Fix common/ includes.
7892         * tracepoint.c: Fix common/ includes.
7893         * tracefile-tfile.c: Fix common/ includes.
7894         * top.h: Fix common/ includes.
7895         * top.c: Fix common/ includes.
7896         * thread.c: Fix common/ includes.
7897         * target/waitstatus.h: Fix common/ includes.
7898         * target/waitstatus.c: Fix common/ includes.
7899         * target.h: Fix common/ includes.
7900         * target.c: Fix common/ includes.
7901         * target-memory.c: Fix common/ includes.
7902         * target-descriptions.c: Fix common/ includes.
7903         * symtab.h: Fix common/ includes.
7904         * symfile.c: Fix common/ includes.
7905         * stap-probe.c: Fix common/ includes.
7906         * spu-linux-nat.c: Fix common/ includes.
7907         * sparc-nat.c: Fix common/ includes.
7908         * source.c: Fix common/ includes.
7909         * solib.c: Fix common/ includes.
7910         * solib-target.c: Fix common/ includes.
7911         * ser-unix.c: Fix common/ includes.
7912         * ser-tcp.c: Fix common/ includes.
7913         * ser-pipe.c: Fix common/ includes.
7914         * ser-base.c: Fix common/ includes.
7915         * selftest-arch.c: Fix common/ includes.
7916         * s12z-tdep.c: Fix common/ includes.
7917         * rust-exp.y: Fix common/ includes.
7918         * rs6000-aix-tdep.c: Fix common/ includes.
7919         * riscv-tdep.c: Fix common/ includes.
7920         * remote.c: Fix common/ includes.
7921         * remote-notif.h: Fix common/ includes.
7922         * remote-fileio.h: Fix common/ includes.
7923         * remote-fileio.c: Fix common/ includes.
7924         * regcache.h: Fix common/ includes.
7925         * regcache.c: Fix common/ includes.
7926         * record-btrace.c: Fix common/ includes.
7927         * python/python.c: Fix common/ includes.
7928         * python/py-type.c: Fix common/ includes.
7929         * python/py-inferior.c: Fix common/ includes.
7930         * progspace.h: Fix common/ includes.
7931         * producer.c: Fix common/ includes.
7932         * procfs.c: Fix common/ includes.
7933         * proc-api.c: Fix common/ includes.
7934         * printcmd.c: Fix common/ includes.
7935         * ppc-linux-nat.c: Fix common/ includes.
7936         * parser-defs.h: Fix common/ includes.
7937         * osdata.c: Fix common/ includes.
7938         * obsd-nat.c: Fix common/ includes.
7939         * nat/x86-linux.c: Fix common/ includes.
7940         * nat/x86-linux-dregs.c: Fix common/ includes.
7941         * nat/x86-dregs.h: Fix common/ includes.
7942         * nat/x86-dregs.c: Fix common/ includes.
7943         * nat/ppc-linux.c: Fix common/ includes.
7944         * nat/mips-linux-watch.h: Fix common/ includes.
7945         * nat/mips-linux-watch.c: Fix common/ includes.
7946         * nat/linux-waitpid.c: Fix common/ includes.
7947         * nat/linux-ptrace.h: Fix common/ includes.
7948         * nat/linux-ptrace.c: Fix common/ includes.
7949         * nat/linux-procfs.c: Fix common/ includes.
7950         * nat/linux-personality.c: Fix common/ includes.
7951         * nat/linux-osdata.c: Fix common/ includes.
7952         * nat/linux-namespaces.c: Fix common/ includes.
7953         * nat/linux-btrace.h: Fix common/ includes.
7954         * nat/linux-btrace.c: Fix common/ includes.
7955         * nat/fork-inferior.c: Fix common/ includes.
7956         * nat/amd64-linux-siginfo.c: Fix common/ includes.
7957         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
7958         * nat/aarch64-linux.c: Fix common/ includes.
7959         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
7960         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
7961         * namespace.h: Fix common/ includes.
7962         * mips-linux-tdep.c: Fix common/ includes.
7963         * minsyms.c: Fix common/ includes.
7964         * mi/mi-parse.h: Fix common/ includes.
7965         * mi/mi-main.c: Fix common/ includes.
7966         * mi/mi-cmd-env.c: Fix common/ includes.
7967         * memrange.h: Fix common/ includes.
7968         * memattr.c: Fix common/ includes.
7969         * maint.h: Fix common/ includes.
7970         * maint.c: Fix common/ includes.
7971         * main.c: Fix common/ includes.
7972         * machoread.c: Fix common/ includes.
7973         * location.c: Fix common/ includes.
7974         * linux-thread-db.c: Fix common/ includes.
7975         * linux-nat.c: Fix common/ includes.
7976         * linux-fork.c: Fix common/ includes.
7977         * inline-frame.c: Fix common/ includes.
7978         * infrun.c: Fix common/ includes.
7979         * inflow.c: Fix common/ includes.
7980         * inferior.h: Fix common/ includes.
7981         * inferior.c: Fix common/ includes.
7982         * infcmd.c: Fix common/ includes.
7983         * inf-ptrace.c: Fix common/ includes.
7984         * inf-child.c: Fix common/ includes.
7985         * ia64-linux-nat.c: Fix common/ includes.
7986         * i387-tdep.c: Fix common/ includes.
7987         * i386-tdep.c: Fix common/ includes.
7988         * i386-linux-tdep.c: Fix common/ includes.
7989         * i386-linux-nat.c: Fix common/ includes.
7990         * i386-go32-tdep.c: Fix common/ includes.
7991         * i386-fbsd-tdep.c: Fix common/ includes.
7992         * i386-fbsd-nat.c: Fix common/ includes.
7993         * guile/scm-type.c: Fix common/ includes.
7994         * guile/guile.c: Fix common/ includes.
7995         * go32-nat.c: Fix common/ includes.
7996         * gnu-nat.c: Fix common/ includes.
7997         * gdbthread.h: Fix common/ includes.
7998         * gdbarch-selftests.c: Fix common/ includes.
7999         * gdb_usleep.c: Fix common/ includes.
8000         * gdb_select.h: Fix common/ includes.
8001         * gdb_bfd.c: Fix common/ includes.
8002         * gcore.c: Fix common/ includes.
8003         * fork-child.c: Fix common/ includes.
8004         * findvar.c: Fix common/ includes.
8005         * fbsd-nat.c: Fix common/ includes.
8006         * event-top.c: Fix common/ includes.
8007         * event-loop.c: Fix common/ includes.
8008         * dwarf2read.c: Fix common/ includes.
8009         * dwarf2loc.c: Fix common/ includes.
8010         * dwarf2-frame.c: Fix common/ includes.
8011         * dwarf-index-cache.c: Fix common/ includes.
8012         * dtrace-probe.c: Fix common/ includes.
8013         * disasm-selftests.c: Fix common/ includes.
8014         * defs.h: Fix common/ includes.
8015         * csky-tdep.c: Fix common/ includes.
8016         * cp-valprint.c: Fix common/ includes.
8017         * cp-support.h: Fix common/ includes.
8018         * cp-support.c: Fix common/ includes.
8019         * corelow.c: Fix common/ includes.
8020         * completer.h: Fix common/ includes.
8021         * completer.c: Fix common/ includes.
8022         * compile/compile.c: Fix common/ includes.
8023         * compile/compile-loc2c.c: Fix common/ includes.
8024         * compile/compile-cplus-types.c: Fix common/ includes.
8025         * compile/compile-cplus-symbols.c: Fix common/ includes.
8026         * command.h: Fix common/ includes.
8027         * cli/cli-dump.c: Fix common/ includes.
8028         * cli/cli-cmds.c: Fix common/ includes.
8029         * charset.c: Fix common/ includes.
8030         * build-id.c: Fix common/ includes.
8031         * btrace.h: Fix common/ includes.
8032         * btrace.c: Fix common/ includes.
8033         * breakpoint.h: Fix common/ includes.
8034         * breakpoint.c: Fix common/ includes.
8035         * ax.h:
8036         (enum agent_op): Fix common/ includes.
8037         * ax-general.c (struct aop_map): Fix common/ includes.
8038         * ax-gdb.c: Fix common/ includes.
8039         * auxv.c: Fix common/ includes.
8040         * auto-load.c: Fix common/ includes.
8041         * arm-tdep.c: Fix common/ includes.
8042         * arch/riscv.c: Fix common/ includes.
8043         * arch/ppc-linux-common.c: Fix common/ includes.
8044         * arch/i386.c: Fix common/ includes.
8045         * arch/arm.c: Fix common/ includes.
8046         * arch/arm-linux.c: Fix common/ includes.
8047         * arch/arm-get-next-pcs.c: Fix common/ includes.
8048         * arch/amd64.c: Fix common/ includes.
8049         * arch/aarch64.c: Fix common/ includes.
8050         * arch/aarch64-insn.c: Fix common/ includes.
8051         * arch-utils.c: Fix common/ includes.
8052         * amd64-windows-tdep.c: Fix common/ includes.
8053         * amd64-tdep.c: Fix common/ includes.
8054         * amd64-sol2-tdep.c: Fix common/ includes.
8055         * amd64-obsd-tdep.c: Fix common/ includes.
8056         * amd64-nbsd-tdep.c: Fix common/ includes.
8057         * amd64-linux-tdep.c: Fix common/ includes.
8058         * amd64-linux-nat.c: Fix common/ includes.
8059         * amd64-fbsd-tdep.c: Fix common/ includes.
8060         * amd64-fbsd-nat.c: Fix common/ includes.
8061         * amd64-dicos-tdep.c: Fix common/ includes.
8062         * amd64-darwin-tdep.c: Fix common/ includes.
8063         * agent.c: Fix common/ includes.
8064         * ada-lang.h: Fix common/ includes.
8065         * ada-lang.c: Fix common/ includes.
8066         * aarch64-tdep.c: Fix common/ includes.
8067
8068 2019-01-25  Tom Tromey  <tom@tromey.com>
8069
8070         * common/create-version.sh: Use common/version.h.
8071
8072 2019-01-24  Pedro Alves  <palves@redhat.com>
8073
8074         * infrun.c (signal_stop, signal_print, signal_program)
8075         (signal_catch, signal_pass): Now arrays instead of pointers.
8076         (update_signals_program_target, do_target_resume)
8077         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8078         * linux-nat.c (linux_nat_target::pass_signals)
8079         (linux_nat_target::create_inferior, linux_nat_target::attach):
8080         Adjust.
8081         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8082         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8083         * procfs.c (procfs_target::pass_signals): Adjust.
8084         * record-full.c (record_full_target::resume): Adjust.
8085         * remote.c (remote_target::pass_signals)
8086         (remote_target::program_signals): Adjust.
8087         * target-debug.h (target_debug_print_signals): Now takes a
8088         gdb::array_view as parameter.  Adjust.
8089         * target.h (target_ops) <pass_signals, program_signals>: Replace
8090         pointer and length parameters with gdb::array_view.
8091         (target_pass_signals, target_program_signals): Likewise.
8092         * target-delegates.c: Regenerate.
8093
8094 2019-01-24  Pedro Alves  <palves@redhat.com>
8095
8096         * common/forward-scope-exit.h
8097         (forward_scope_exit::forward_scope_exit): Pass arguments to
8098         m_bind_function directly, instead of creating a std::bind and
8099         copying that.
8100
8101 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8102
8103         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8104         for static members.
8105         (pass_in_v_vfp_candidate): Likewise.
8106
8107 2019-01-23  Tom Tromey  <tom@tromey.com>
8108             Pedro Alves  <palves@redhat.com>
8109
8110         * regcache.c (class regcache_invalidator): Remove.
8111         (regcache::raw_write): Use make_scope_exit.
8112
8113 2019-01-23  Tom Tromey  <tom@tromey.com>
8114
8115         * ui-out.h (class ui_out_emit_type): Update comment.
8116
8117 2019-01-23  Tom Tromey  <tom@tromey.com>
8118
8119         * infrun.c (fetch_inferior_event): Update comment.
8120
8121 2019-01-23  Tom Tromey  <tom@tromey.com>
8122             Pedro Alves  <palves@redhat.com>
8123
8124         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8125         parameter.
8126         (fetch_inferior_event): Use SCOPE_EXIT.
8127
8128
8129 2019-01-23  Tom Tromey  <tom@tromey.com>
8130             Pedro Alves  <palves@redhat.com>
8131
8132         * infrun.c (disable_thread_events): Delete.
8133         (stop_all_threads): Use SCOPE_EXIT.
8134
8135 2019-01-23  Tom Tromey  <tom@tromey.com>
8136             Pedro Alves  <palves@redhat.com>
8137
8138         * symfile.c: Include forward-scope-exit.h.
8139         (clear_symtab_users_cleanup): Replace forward declaration with
8140         a FORWARD_SCOPE_EXIT.
8141         (syms_from_objfile_1): Use the forward_scope_exit and
8142         gdb::optional instead of cleanup_function.
8143         (reread_symbols): Use the forward_scope_exit instead of
8144         cleanup_function.
8145         (clear_symtab_users_cleanup): Remove function.
8146
8147 2019-01-23  Tom Tromey  <tom@tromey.com>
8148             Pedro Alves  <palves@redhat.com>
8149
8150         * linux-nat.c: Include scope-exit.h.
8151         (cleanup_target_stop): Remove.
8152         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8153         SCOPE_EXIT.
8154
8155 2019-01-23  Tom Tromey  <tom@tromey.com>
8156             Pedro Alves  <palves@redhat.com>
8157
8158         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8159         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8160
8161 2019-01-23  Tom Tromey  <tom@tromey.com>
8162             Andrew Burgess  <andrew.burgess@embecosm.com>
8163             Pedro Alves  <palves@redhat.com>
8164
8165         * infrun.c (fetch_inferior_event): Use scope_exit.
8166         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8167         * top.c (execute_command): Use scope_exit.
8168         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8169         * utils.c (do_bpstat_clear_actions_cleanup)
8170         (make_bpstat_clear_actions_cleanup): Remove.
8171
8172 2019-01-23  Tom Tromey  <tom@tromey.com>
8173             Pedro Alves  <palves@redhat.com>
8174
8175         * infrun.c: Include "common/scope-exit.h"
8176         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8177         (wait_for_inferior): Use SCOPE_EXIT.
8178         (fetch_inferior_event): Use scope_exit.
8179
8180 2019-01-23  Tom Tromey  <tom@tromey.com>
8181             Pedro Alves  <palves@redhat.com>
8182
8183         * breakpoint.c (create_breakpoint): Remove cleanup.
8184
8185 2019-01-23  Tom Tromey  <tom@tromey.com>
8186             Andrew Burgess  <andrew.burgess@embecosm.com>
8187             Pedro Alves  <palves@redhat.com>
8188
8189 2019-01-23  Pedro Alves  <palves@redhat.com>
8190
8191         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8192
8193 2019-01-23  Pedro Alves  <palves@redhat.com>
8194             Andrew Burgess  <andrew.burgess@embecosm.com>
8195
8196         * gdbthread.h: Include "common/forward-scope-exit.h".
8197         (scoped_finish_thread_state): Redefine custom class in terms of
8198         forward_scope_exit.
8199
8200 2019-01-23  Pedro Alves  <palves@redhat.com>
8201             Andrew Burgess  <andrew.burgess@embecosm.com>
8202
8203         * common/forward-scope-exit.h: New file.
8204
8205 2019-01-23  Pedro Alves  <palves@redhat.com>
8206             Andrew Burgess  <andrew.burgess@embecosm.com>
8207             Tom Tromey  <tom@tromey.com>
8208
8209         * common/scope-exit.h: New file.
8210
8211 2019-01-23  Pedro Alves  <palves@redhat.com>
8212
8213         * common/preprocessor.h (ESC): Rename to ...
8214         (ESC_PARENS): ... this.
8215         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8216         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8217
8218 2019-01-23  Tom Tromey  <tom@tromey.com>
8219
8220         * language.h (class scoped_switch_to_sym_language_if_auto):
8221         Initialize m_lang in both cases.
8222
8223 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8224
8225         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8226         with XCNEW.
8227
8228 2019-01-22  Tom Tromey  <tom@tromey.com>
8229
8230         * corelow.c: Do not include sys/file.h.
8231
8232 2019-01-22  Tom Tromey  <tom@tromey.com>
8233
8234         * tui/tui-wingeneral.h: Include gdb_curses.h.
8235
8236 2019-01-22  Tom Tromey  <tom@tromey.com>
8237
8238         * source-cache.h (class source_cache) <get_source_lines,
8239         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8240
8241 2019-01-22  Tom Tromey  <tom@tromey.com>
8242
8243         * remote-fileio.h (struct remote_target): Declare.
8244
8245 2019-01-22  Tom Tromey  <tom@tromey.com>
8246
8247         * python/py-arch.c: Do not include py-ref.h.
8248         * python/py-bpevent.c: Do not include py-ref.h.
8249         * python/py-cmd.c: Do not include py-ref.h.
8250         * python/py-continueevent.c: Do not include py-ref.h.
8251         * python/py-event.h: Do not include py-ref.h.
8252         * python/py-evtregistry.c: Do not include py-ref.h.
8253         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8254         * python/py-frame.c: Do not include py-ref.h.
8255         * python/py-framefilter.c: Do not include py-ref.h.
8256         * python/py-function.c: Do not include py-ref.h.
8257         * python/py-infevents.c: Do not include py-ref.h.
8258         * python/py-linetable.c: Do not include py-ref.h.
8259         * python/py-objfile.c: Do not include py-ref.h.
8260         * python/py-param.c: Do not include py-ref.h.
8261         * python/py-prettyprint.c: Do not include py-ref.h.
8262         * python/py-progspace.c: Do not include py-ref.h.
8263         * python/py-symbol.c: Do not include py-ref.h.
8264         * python/py-symtab.c: Do not include py-ref.h.
8265         * python/py-type.c: Do not include py-ref.h.
8266         * python/py-unwind.c: Do not include py-ref.h.
8267         * python/py-utils.c: Do not include py-ref.h.
8268         * python/py-value.c: Do not include py-ref.h.
8269         * python/py-varobj.c: Do not include py-ref.h.
8270         * python/py-xmethods.c: Do not include py-ref.h.
8271         * python/python.c: Do not include py-ref.h.
8272         * varobj.c: Do not include py-ref.h.
8273
8274 2019-01-22  Tom Tromey  <tom@tromey.com>
8275
8276         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8277         keyword for bcache.
8278
8279 2019-01-22  Tom Tromey  <tom@tromey.com>
8280
8281         * compile/compile-cplus-types.c: Remove a comment by #include.
8282
8283 2019-01-22  Tom Tromey  <tom@tromey.com>
8284
8285         * compile/gcc-c-plugin.h: Include compile-internal.h.
8286
8287 2019-01-22  Tom Tromey  <tom@tromey.com>
8288
8289         * stabsread.c (EXTERN): Do not define.
8290         (symnum, next_symbol_text_func, processing_gcc_compilation)
8291         (within_function, global_sym_chain, global_stabs)
8292         (previous_stab_code, this_object_header_files)
8293         (n_this_object_header_files)
8294         (n_allocated_this_object_header_files): Define.
8295         * stabsread.h (EXTERN): Never define.  Use "extern".
8296
8297 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8298
8299         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8300         history_value.
8301
8302 2019-01-21  Tom Tromey  <tom@tromey.com>
8303
8304         * ui-out.c: Fix includes.
8305         * tui/tui-source.c: Fix includes.
8306         * target.c: Fix includes.
8307         * remote.c: Fix includes.
8308         * regcache.c: Fix includes.
8309         * python/py-block.c: Fix includes.
8310         * printcmd.c: Fix includes.
8311         * or1k-tdep.c: Fix includes.
8312         * mi/mi-main.c: Fix includes.
8313         * m32r-tdep.c: Fix includes.
8314         * csky-tdep.c: Fix includes.
8315         * compile/compile-cplus-types.c: Fix includes.
8316         * cli/cli-interp.c: Fix includes.
8317
8318 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8319
8320         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8321         for padding.
8322
8323 2019-01-16  Tom Tromey  <tom@tromey.com>
8324
8325         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8326         earlier.
8327         (struct objfile) <msymbols_range>: Move from top level.
8328         <msymbols>: New method.
8329         (class objfile_msymbols): Remove.
8330         * symtab.c (default_collect_symbol_completion_matches_break_on):
8331         Update.
8332         * symmisc.c (dump_msymbols): Update.
8333         * stabsread.c (scan_file_globals): Update.
8334         * objc-lang.c (info_selectors_command, info_classes_command)
8335         (find_methods): Update.
8336         * minsyms.c (find_solib_trampoline_target): Update.
8337         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8338         * coffread.c (coff_symfile_read): Update.
8339         * ada-lang.c (ada_lookup_simple_minsym)
8340         (ada_collect_symbol_completion_matches): Update.
8341
8342 2019-01-16  Tom Tromey  <tom@tromey.com>
8343
8344         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8345         type.  Remove no-argument constructor.
8346         <iterator::operator++>: Simplify.
8347         <begin>: Update.
8348         <end>: Use minimal_symbol_count.
8349
8350 2019-01-16  Tom Tromey  <tom@tromey.com>
8351
8352         * objfiles.h (struct objfile) <psymtabs>: New method.
8353         (class objfile_psymtabs): Remove.
8354         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8355         typedef.
8356         <range>: New method.
8357         (require_partial_symbols): Change return type.
8358         * psymtab.c (require_partial_symbols)
8359         (psym_expand_symtabs_matching): Update.
8360         * mdebugread.c (parse_partial_symbols): Update.
8361         * dbxread.c (dbx_end_psymtab): Update.
8362
8363 2019-01-15  Tom Tromey  <tom@tromey.com>
8364
8365         * symtab.c (lookup_objfile_from_block)
8366         (lookup_symbol_in_objfile_symtabs)
8367         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8368         (find_line_symtab, info_sources_command)
8369         (default_collect_symbol_completion_matches_break_on)
8370         (make_source_files_completion_list): Update.
8371         * symmisc.c (print_objfile_statistics, dump_objfile)
8372         (maintenance_print_symbols, maintenance_info_symtabs)
8373         (maintenance_check_symtabs, maintenance_info_line_tables):
8374         Update.
8375         * source.c (select_source_symtab)
8376         (forget_cached_source_info_for_objfile): Update.
8377         * objfiles.h (class objfile_compunits): Remove.
8378         (struct objfile) <compunits_range>: New typedef.
8379         (compunits): New method.
8380         * objfiles.c (objfile_relocate1): Update.
8381         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8382         * maint.c (count_symtabs_and_blocks): Update.
8383         * linespec.c (iterate_over_all_matching_symtabs): Update.
8384         * cp-support.c (add_symbol_overload_list_qualified): Update.
8385         * coffread.c (coff_symtab_read): Update.
8386         * ada-lang.c (add_nonlocal_symbols)
8387         (ada_collect_symbol_completion_matches)
8388         (ada_add_global_exceptions): Update.
8389
8390 2019-01-15  Tom Tromey  <tom@tromey.com>
8391
8392         * progspace.h (program_space) <objfiles_safe_range>: New
8393         typedef.
8394         <objfiles_safe>: New method.
8395         * objfiles.h (class all_objfiles_safe): Remove.
8396         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8397         * jit.c (jit_inferior_exit_hook): Update.
8398
8399 2019-01-17  Tom Tromey  <tom@tromey.com>
8400
8401         * progspace.h (program_space) <objfiles_range>: New typedef.
8402         <objfiles>: New method.
8403         <objfiles_head>: Rename from objfiles.
8404         (object_files): Update.
8405         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8406         * guile/scm-pretty-print.c
8407         (ppscm_find_pretty_printer_from_objfiles): Update.
8408         * guile/scm-objfile.c (gdbscm_objfiles): Update.
8409         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8410         Update.
8411         * python/py-progspace.c (pspy_get_objfiles): Update.
8412         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8413         Update.
8414         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8415         (objfpy_lookup_objfile_by_build_id): Update.
8416         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8417         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8418         Update.
8419         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8420         (expand_symtab_containing_pc, lookup_objfile_from_block)
8421         (lookup_static_symbol, basic_lookup_transparent_type)
8422         (find_pc_sect_compunit_symtab, find_symbol_at_address)
8423         (find_line_symtab, info_sources_command)
8424         (default_collect_symbol_completion_matches_break_on)
8425         (make_source_files_completion_list, find_main_name): Update.
8426         * symmisc.c (print_symbol_bcache_statistics)
8427         (print_objfile_statistics, maintenance_print_symbols)
8428         (maintenance_print_msymbols, maintenance_print_objfiles)
8429         (maintenance_info_symtabs, maintenance_check_symtabs)
8430         (maintenance_expand_symtabs, maintenance_info_line_tables):
8431         Update.
8432         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8433         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
8434         (map_overlay_command, unmap_overlay_command)
8435         (simple_overlay_update, expand_symtabs_matching)
8436         (map_symbol_filenames): Update.
8437         * symfile-debug.c (set_debug_symfile): Update.
8438         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
8439         Update.
8440         * source.c (select_source_symtab, forget_cached_source_info):
8441         Update.
8442         * solib.c (solib_read_symbols): Update.
8443         * solib-spu.c (append_ocl_sos): Update.
8444         * psymtab.c (maintenance_print_psymbols)
8445         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
8446         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
8447         * printcmd.c (info_symbol_command): Update.
8448         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
8449         Update.
8450         * objfiles.h (class all_objfiles): Remove.
8451         * objfiles.c (have_partial_symbols, have_full_symbols)
8452         (have_minimal_symbols, qsort_cmp, update_section_map)
8453         (shared_objfile_contains_address_p)
8454         (default_iterate_over_objfiles_in_search_order): Update.
8455         * objc-lang.c (info_selectors_command, info_classes_command)
8456         (find_methods): Update.
8457         * minsyms.c (find_solib_trampoline_target): Update.
8458         * maint.c (maintenance_info_sections)
8459         (maintenance_translate_address, count_symtabs_and_blocks):
8460         Update.
8461         * main.c (captured_main_1): Update.
8462         * linux-thread-db.c (try_thread_db_load_from_pdir)
8463         (has_libpthread): Update.
8464         * linespec.c (iterate_over_all_matching_symtabs)
8465         (search_minsyms_for_name): Update.
8466         * jit.c (jit_find_objf_with_entry_addr): Update.
8467         * hppa-tdep.c (find_unwind_entry)
8468         (hppa_lookup_stub_minimal_symbol): Update.
8469         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
8470         Update.
8471         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8472         (elf_gnu_ifunc_resolve_by_got): Update.
8473         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
8474         * dwarf-index-write.c (save_gdb_index_command): Update.
8475         * cp-support.c (add_symbol_overload_list_qualified): Update.
8476         * breakpoint.c (create_overlay_event_breakpoint)
8477         (create_longjmp_master_breakpoint)
8478         (create_std_terminate_master_breakpoint)
8479         (create_exception_master_breakpoint): Update.
8480         * blockframe.c (find_pc_partial_function): Update.
8481         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
8482         (ada_collect_symbol_completion_matches)
8483         (ada_add_global_exceptions): Update.
8484
8485 2019-01-17  Tom Tromey  <tom@tromey.com>
8486
8487         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
8488         declare VEC.
8489         (solib_target_parse_libraries): Change return type.
8490         (library_list_start_segment, library_list_start_section)
8491         (library_list_end_library, library_list_start_library); Update.
8492         (solib_target_free_library_list): Remove.
8493         (solib_target_parse_libraries): Remove cleanup.  Change return
8494         type.
8495         (solib_target_current_sos): Update.
8496
8497 2019-01-17  Tom Tromey  <tromey@bapiya>
8498
8499         * valprint.c: Replace "the the" with "the".
8500         * symtab.c: Replace "the the" with "the".
8501         * solib.c: Replace "the the" with "the".
8502         * solib-dsbt.c: Replace "the the" with "the".
8503         * linespec.c: Replace "the the" with "the".
8504         * dwarf2loc.h: Replace "the the" with "the".
8505         * amd64-windows-tdep.c: Replace "the the" with "the".
8506         * aarch64-tdep.c: Replace "the the" with "the".
8507
8508 2019-01-16  Keith Seitz  <keiths@redhat.com>
8509
8510         PR gdb/23773
8511         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
8512         <builder>: Rename to ..
8513         <m_builder>: ... this and make private.
8514         (dwarf2_cu::get_builder): New method.  Change all users of
8515         `builder' to use this method.
8516         (dwarf2_start_symtab): Move to ...
8517         (dwarf2_cu::start_symtab): ... here.  Update all callers
8518         (setup_type_unit_groups): Move to ...
8519         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
8520         callers.
8521         (dwarf2_cu::reset_builder): New method.
8522         (process_full_compunit, process_full_type_unit): Use
8523         dwarf2_cu::reset_builder.
8524         (follow_die_offset): Record the ancestor CU if it is different
8525         from the followed DIE's CU.
8526         (follow_die_sig_1): Likewise.
8527
8528 2019-01-15  Tom Tromey  <tom@tromey.com>
8529
8530         * remote.c (class remote_state) <buf>: Now a char_vector.
8531         <buf_size>: Remove.
8532         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
8533         parameter.
8534         (remote_target::getpkt_or_notif_sane_1)
8535         (remote_target::getpkt_sane)
8536         (remote_target::getpkt_or_notif_sane): Likewise.
8537         (class remote_target) <putpkt>: New overload.
8538         (remote_target::read_frame): Change type of "buf_p".  Remove
8539         sizeof_p parameter.
8540         (packet_ok): New overload.
8541         (packet_check_result): New overload.
8542         Update all uses.
8543
8544 2019-01-14  Tom Tromey  <tom@tromey.com>
8545
8546         * remote-notif.c (handle_notification, remote_notif_ack)
8547         (remote_notif_parse): Make "buf" const.
8548         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
8549         const.
8550         (remote_notif_parse, remote_notif_ack, handle_notification):
8551         Likewise.
8552         * remote.c (remote_notif_stop_parse): Make "buf" const.
8553         (remote_target::remote_parse_stop_reply): Make "buf" const.
8554         (remote_notif_stop_ack): Make "buf" const.
8555
8556 2019-01-14  Tom Tromey  <tom@tromey.com>
8557
8558         * remote.c (remote_console_output): Make parameter const.
8559
8560 2019-01-14  Tom Tromey  <tom@tromey.com>
8561
8562         * target-debug.h (target_debug_print_signals): Constify.
8563         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
8564         * procfs.c (procfs_target::pass_signals): Update.
8565         * linux-nat.c (linux_nat_target::pass_signals): Update.
8566         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
8567         * target-delegates.c: Rebuild.
8568         * remote.c (remote_target::program_signals): Update.
8569         (remote_target::pass_signals): Update.
8570         * target.c (target_pass_signals): Constify argument.
8571         (target_program_signals): Likewise.
8572         * target.h (struct target_ops) <pass_signals, program_signals>:
8573         Constify argument.
8574         (target_pass_signals, target_program_signals): Constify argument.
8575
8576 2019-01-14  Tom Tromey  <tom@tromey.com>
8577
8578         PR tui/28819:
8579         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
8580
8581 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
8582
8583         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
8584         field.
8585         * rs6000-tdep.c: Include reggroups.h.
8586         (IS_V_ALIAS_PSEUDOREG): Define.
8587         (rs6000_register_name): Return names for the "vX" aliases.
8588         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
8589         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
8590         aliases.  Call default_register_reggroup_p for all other
8591         pseudo-registers.
8592         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
8593         New functions.
8594         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
8595         Handle "vX" aliases.
8596         (v_alias_pseudo_register_collect): New function.
8597         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
8598         (rs6000_gdbarch_init): Initialize "vX" aliases as
8599         pseudo-registers.  Restore registration of
8600         rs6000_pseudo_register_reggroup_p with
8601         set_tdesc_pseudo_register_reggroup_p.
8602
8603 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
8604
8605         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
8606         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
8607         set_gdbarch_num_pseudo_regs.
8608
8609 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8610
8611         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
8612         Remove arg prefixname, add do_set and do_show.
8613         Add member functions set_list and show_list.
8614         * cli/cli-style.c (class cli_style_option): Update accordingly.
8615         (style_set_list): Move to file scope.
8616         (style_show_list): Likewise.
8617         (set_style): Call help_list.
8618         (show_style): Call cmd_show_list.
8619         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
8620         Update to use the new macro.
8621
8622 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
8623
8624         * ada-lang.c (_initialize_ada_language): Expand the help text
8625         for the "catch exception" command.
8626
8627 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8628
8629         * symtab.c (matching_obj_sections): Initialize obj,
8630         declare it closer to its usage.
8631
8632 2019-01-10  Tom Tromey  <tom@tromey.com>
8633
8634         * thread-iter.h (inf_threads_iterator): Use next_iterator.
8635         (basic_inf_threads_range): Remove.
8636         (inf_threads_range, inf_non_exited_threads_range)
8637         (safe_inf_threads_range): Use next_adapter.
8638
8639 2019-01-10  Keith Seitz  <keiths@redhat.com>
8640
8641         PR gdb/23712
8642         PR symtab/23010
8643         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
8644         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
8645
8646 2019-01-10  Keith Seitz  <keiths@redhat.com>
8647
8648         PR gdb/23712
8649         PR symtab/23010
8650         * dictionary.c (pending_to_vector): Remove.
8651         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8652         Remove _1 suffix, replacing functions of the same name.  Update
8653         all callers.
8654         (dict_create_hashed, dict_create_hashed_expandable)
8655         (dict_create_linear, dict_create_linear_expandable, dict_free)
8656         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8657         Make functions static.
8658
8659 2019-01-10  Keith Seitz  <keiths@redhat.com>
8660
8661         PR gdb/23712
8662         PR symtab/23010
8663         * dictionary.h (struct dictionary): Replace declaration with
8664         multidictionary.
8665         (dict_create_hashed, dict_create_hashed_expandable)
8666         (dict_create_linear, dict_create_linear_expandable)
8667         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8668         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8669         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8670         taking multidictionary argument.
8671         [ALL_DICT_SYMBOLS]: Update for multidictionary.
8672         * block.h (struct block) <dict>: Change to multidictionary
8673         and rename `multidict'.
8674         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8675         symmisc.c: Update all dictionary references to multidictionary.
8676
8677 2019-01-10  Keith Seitz  <keiths@redhat.com>
8678
8679         PR gdb/23712
8680         PR symtab/23010
8681         * dictionary.c: Include unordered_map.
8682         (pending_to_vector): New function.
8683         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8684         Rewrite the non-"_1" functions to take vector instead
8685         of linked list.
8686         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8687         "new" _1 versions of the same name.
8688         (multidictionary): Define.
8689         (std::hash<enum language): New definition.
8690         (collate_pending_symbols_by_language, mdict_create_hashed)
8691         (mdict_create_hashed_expandable, mdict_create_linear)
8692         (mdict_create_linear_expandable, mdict_free)
8693         (find_language_dictionary, create_new_language_dictionary)
8694         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8695         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8696         (mdict_size, mdict_empty): New functions.
8697         * dictionary.h (mdict_iterator): Define.
8698
8699 2019-01-10  Pedro Alves  <palves@redhat.com>
8700
8701         * breakpoint.c (read_uploaded_action)
8702         (create_tracepoint_from_upload): Adjust to use
8703         gdb::unique_xmalloc_ptr.
8704         * ctf.c (ctf_write_uploaded_tp):
8705         (SET_ARRAY_FIELD): Use emplace_back.
8706         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8707         * tracefile-tfile.c (tfile_write_uploaded_tp):
8708         * tracepoint.c (parse_tracepoint_definition): Adjust to use
8709         gdb::unique_xmalloc_ptr.
8710         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8711         at_string, cond_string, cmd_strings>: Replace char pointers
8712         with gdb::unique_xmalloc_ptr.
8713
8714 2019-01-10  Pedro Alves  <palves@redhat.com>
8715
8716         * solib-target.c (library_list_start_library): Don't xstrdup name.
8717
8718 2019-01-10  Pedro Alves  <palves@redhat.com>
8719
8720         * mdebugread.c (parse_partial_symbols): Use
8721         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8722
8723 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8724
8725         * linux-fork.c (scoped_switch_fork_info)
8726         <~scoped_switch_fork_info>: Fix incorrect variable name.
8727
8728 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8729
8730         * linux-fork.c (scoped_switch_fork_info)
8731         <scoped_switch_fork_info>: Make explicit.
8732         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
8733
8734 2019-01-10  Tom Tromey  <tom@tromey.com>
8735
8736         * objfiles.h (objfile::reset_psymtabs): Update.
8737         * objfiles.c (objfile::objfile): Update.
8738         * psymtab.h (psymtab_storage::obstack): Update.
8739         (psymtab_storage::m_obstack): Use gdb::optional.
8740         (class psymtab_storage): Update comment.  Remove objfile
8741         parameter.
8742         * psymtab.c (psymtab_storage::psymtab_storage): Update.
8743
8744 2019-01-10  Tom Tromey  <tom@tromey.com>
8745
8746         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
8747         <free_psymtabs>: Now private.
8748         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
8749         (allocate_psymtab): Use new method.
8750
8751 2019-01-10  Tom Tromey  <tom@tromey.com>
8752
8753         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
8754         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
8755         * mdebugread.c (parse_partial_symbols): Use
8756         allocate_dependencies.
8757         * dwarf2read.c (dwarf2_create_include_psymtab): Use
8758         allocate_dependencies.
8759         (process_psymtab_comp_unit_reader)
8760         (build_type_psymtab_dependencies): Likewise.
8761         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
8762
8763 2019-01-10  Tom Tromey  <tom@tromey.com>
8764
8765         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
8766         PSYMBOL_SET_LANGUAGE.
8767         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
8768
8769 2019-01-10  Tom Tromey  <tom@tromey.com>
8770
8771         * psymtab.h (psymtab_storage::obstack): New method.
8772         <m_obstack>: Rename from obstack; now private.
8773         * psymtab.c (psymtab_storage): Update.
8774         * dwarf2read.c (create_addrmap_from_index)
8775         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
8776         Update.
8777
8778 2019-01-10  Tom Tromey  <tom@tromey.com>
8779
8780         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
8781         * objfiles.h (objfile::reset_psymtabs): New method.
8782
8783 2019-01-10  Tom Tromey  <tom@tromey.com>
8784
8785         * symmisc.c (print_symbol_bcache_statistics): Update.
8786         (print_objfile_statistics): Update.
8787         * symfile.c (reread_symbols): Update.
8788         * psymtab.h (class psymtab_storage): New.
8789         * psymtab.c (psymtab_storage): New constructor.
8790         (~psymtab_storage): New destructor.
8791         (require_partial_symbols): Update.
8792         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
8793         (find_pc_sect_psymtab, find_pc_sect_psymbol)
8794         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
8795         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
8796         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
8797         (start_psymtab_common, end_psymtab_common)
8798         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
8799         (allocate_psymtab): Update.
8800         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
8801         Update.
8802         (dump_psymtab_addrmap, maintenance_print_psymbols)
8803         (maintenance_check_psymtabs): Update.
8804         (class objfile_psymtabs): Move to objfiles.h.
8805         * psympriv.h (discard_psymtab): Now inline.
8806         (psymtab_discarder::psymtab_discarder): Update.
8807         (psymtab_discarder::~psymtab_discarder): Update.
8808         (ALL_OBJFILE_PSYMTABS): Rewrite.
8809         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
8810         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
8811         Remove fields.
8812         <partial_symtabs>: New field.
8813         (class objfile_psymtabs): Move from psymtab.h.  Update.
8814         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
8815         psymbol_cache.
8816         (objfile::~objfile): Don't destroy psymbol_cache.
8817         * mdebugread.c (parse_partial_symbols): Update.
8818         * dwarf2read.c (create_addrmap_from_index)
8819         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
8820         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
8821         (add_partial_subprogram, dwarf2_ranges_read): Update.
8822         * dwarf-index-write.c (write_address_map)
8823         (write_one_signatured_type, recursively_write_psymbols)
8824         (class debug_names, class debug_names, write_psymtabs_to_index):
8825         Update.
8826
8827 2019-01-10  Tom Tromey  <tom@tromey.com>
8828
8829         * symtab.h (SYMBOL_SET_NAMES): Update.
8830         (symbol_set_names): Update.
8831         (MSYMBOL_SET_NAMES): Update.
8832         * symtab.c (symbol_set_names): Change argument to be an
8833         objfile_per_bfd_storage.
8834         * psymtab.c (add_psymbol_to_bcache): Update.
8835         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
8836
8837 2019-01-10  Tom Tromey  <tom@tromey.com>
8838
8839         * symtab.c (create_demangled_names_hash): Change argument to be an
8840         objfile_per_bfd_storage.
8841         (symbol_set_names): Update.
8842
8843 2019-01-10  Tom Tromey  <tom@tromey.com>
8844
8845         * xcoffread.c (xcoff_initial_scan): Unconditionally call
8846         init_psymbol_list.
8847         * psymtab.c (init_psymbol_list): Do nothing if already called.
8848         * psympriv.h (init_psymbol_list): Add comment.
8849         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
8850         init_psymbol_list.
8851         * dbxread.c (dbx_symfile_read): Unconditionally call
8852         init_psymbol_list.
8853
8854 2019-01-10  Tom Tromey  <tom@tromey.com>
8855
8856         * xcoffread.c (scan_xcoff_symtab): Update.
8857         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
8858         "where".
8859         * mdebugread.c (parse_partial_symbols)
8860         (handle_psymbol_enumerators): Update.
8861         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
8862         * dbxread.c (read_dbx_symtab): Update.
8863         * psympriv.h (psymbol_placement): New enum.
8864         (add_psymbol_to_list): Update.
8865
8866 2019-01-10  Tom Tromey  <tom@tromey.com>
8867
8868         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
8869         static_psymbols parameters.
8870         (scan_xcoff_symtab): Update.
8871         * psymtab.c (start_psymtab_common): Remove global_psymbols and
8872         static_psymbols parameters.
8873         * psympriv.h (start_psymtab_common): Update.
8874         * mdebugread.c (parse_partial_symbols): Update.
8875         * dwarf2read.c (create_partial_symtab): Update.
8876         * dbxread.c (read_dbx_symtab): Update.
8877         (start_psymtab): Remove global_psymbols and static_psymbols
8878         parameters.
8879
8880 2019-01-10  Tom Tromey  <tom@tromey.com>
8881
8882         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
8883         * psymtab.c (allocate_psymtab): Add comment.
8884         * psympriv.h (allocate_psymtab): Add comment.
8885         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
8886         initializations.
8887         * dbxread.c (dbx_end_psymtab): Remove some initializations.
8888
8889 2019-01-10  Tom Tromey  <tom@tromey.com>
8890
8891         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8892         Don't declare.
8893         * mipsread.c: Include mdebugread.h.
8894         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8895         Declare.
8896         * elfread.c: Include mdebugread.h.
8897
8898 2019-01-09  Tom Tromey  <tom@tromey.com>
8899
8900         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
8901         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
8902         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
8903         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
8904         (psym_lookup_symbol, psym_find_last_source_symtab)
8905         (psym_forget_cached_source_info, psym_print_stats)
8906         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
8907         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
8908         (psym_map_matching_symbols, psym_expand_symtabs_matching)
8909         (psym_find_compunit_symtab_by_address)
8910         (maintenance_print_psymbols, maintenance_info_psymtabs)
8911         (maintenance_check_psymtabs): Use ranged for.
8912         * psymtab.h (class objfile_psymtabs): New.
8913         (require_partial_symbols): Return objfile_psymtabs.
8914         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
8915
8916 2019-01-09  Tom Tromey  <tom@tromey.com>
8917
8918         * symfile.c (overlay_invalidate_all, find_pc_overlay)
8919         (find_pc_mapped_section, list_overlays_command)
8920         (map_overlay_command, unmap_overlay_command)
8921         (simple_overlay_update): Use all_objfiles.
8922         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
8923         * printcmd.c (info_symbol_command): Use all_objfiles.
8924         * objfiles.h (ALL_OBJSECTIONS): Remove.
8925         * maint.c (maintenance_translate_address): Use all_objfiles.
8926         * gcore.c (gcore_create_callback): Use all_objfiles.
8927         (objfile_find_memory_regions): Likewise.
8928
8929 2019-01-09  Tom Tromey  <tom@tromey.com>
8930
8931         * symtab.c (find_line_symtab, info_sources_command)
8932         (make_source_files_completion_list): Use objfile_compunits.
8933         * source.c (select_source_symtab): Use objfile_compunits.
8934         * objfiles.h (struct objfile): Update comment.
8935         (ALL_OBJFILES): Remove.
8936         (ALL_FILETABS): Remove.
8937         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
8938         objfile_compunits.
8939
8940 2019-01-09  Tom Tromey  <tom@tromey.com>
8941
8942         * symmisc.c (print_objfile_statistics, dump_objfile)
8943         (maintenance_print_symbols): Use compunit_filetabs.
8944         * source.c (forget_cached_source_info_for_objfile): Use
8945         compunit_filetabs.
8946         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
8947         (ALL_FILETABS): Use compunit_filetabs.
8948         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
8949         * coffread.c (coff_symtab_read): Use compunit_filetabs.
8950
8951 2019-01-09  Tom Tromey  <tom@tromey.com>
8952
8953         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
8954         (compunit_filetabs): New.
8955         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
8956         compunit_filetabs.
8957         (info_sources_command, make_source_files_completion_list): Remove
8958         declaration.
8959         * symmisc.c (print_objfile_statistics, dump_objfile)
8960         (maintenance_print_symbols): Remove declaration.
8961         (maintenance_info_symtabs): Use compunit_filetabs.
8962         (maintenance_info_line_tables): Likewise.
8963         * source.c (select_source_symtab): Change local variable name.
8964         (forget_cached_source_info_for_objfile): Remove declaration.
8965         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
8966         * objfiles.c (objfile_relocate1): Remove declaration.
8967         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8968         declaration.
8969         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
8970         * coffread.c (coff_symtab_read): Remove declaration.
8971         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
8972         compunit_filetabs.
8973
8974 2019-01-09  Tom Tromey  <tom@tromey.com>
8975
8976         * symtab.c (lookup_objfile_from_block)
8977         (find_pc_sect_compunit_symtab, search_symbols)
8978         (default_collect_symbol_completion_matches_break_on): Use
8979         objfile_compunits.
8980         * objfiles.h (ALL_COMPUNITS): Remove.
8981         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
8982         * cp-support.c (add_symbol_overload_list_qualified): Use
8983         objfile_compunits.
8984         * ada-lang.c (ada_collect_symbol_completion_matches)
8985         (ada_add_global_exceptions): Use objfile_compunits.
8986
8987 2019-01-09  Tom Tromey  <tom@tromey.com>
8988
8989         * source.c (select_source_symtab)
8990         (forget_cached_source_info_for_objfile): Remove declaration.
8991         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8992         declaration.
8993         * maint.c (count_symtabs_and_blocks): Remove declaration.
8994         * cp-support.c (add_symbol_overload_list_qualified): Remove
8995         declaration.
8996         * coffread.c (coff_symtab_read): Remove declaration.
8997         * symtab.c (lookup_symbol_in_objfile_symtabs)
8998         (basic_lookup_transparent_type_1): Use objfile_compunits.
8999         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9000         (info_sources_command, search_symbols)
9001         (default_collect_symbol_completion_matches_break_on)
9002         (make_source_files_completion_list): Remove declaration.
9003         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9004         (ada_collect_symbol_completion_matches)
9005         (ada_add_global_exceptions): Remove declaration.
9006         * linespec.c (iterate_over_all_matching_symtabs): Use
9007         objfile_compunits.
9008         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9009         (class objfile_compunits): New.
9010         (ALL_COMPUNITS): Use objfile_compunits.
9011         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9012         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9013         objfile_compunits.
9014         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9015
9016 2019-01-09  Tom Tromey  <tom@tromey.com>
9017
9018         * symtab.c (search_symbols)
9019         (default_collect_symbol_completion_matches_break_on): Use
9020         objfile_msymbols.
9021         * ada-lang.c (ada_lookup_simple_minsym)
9022         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9023         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9024         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9025         objfile_msymbols.
9026         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9027         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9028         * objc-lang.c (find_methods): Use objfile_msymbols.
9029         (info_selectors_command, info_classes_command): Likewise.
9030         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9031         * objfiles.h (class objfile_msymbols): New.
9032         (ALL_OBJFILE_MSYMBOLS): Remove.
9033         (ALL_MSYMBOLS): Remove.
9034
9035 2019-01-09  Tom Tromey  <tom@tromey.com>
9036
9037         * common/next-iterator.h (next_adapter): Add Iterator template
9038         parameter.
9039         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9040         (class all_objfiles_safe): New.
9041         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9042         * objfiles.c (put_objfile_before): Update comment.
9043         (add_separate_debug_objfile): Likewise.
9044         (free_all_objfiles): Use all_objfiles_safe.
9045         (objfile_purge_solibs): Likewise.
9046
9047 2019-01-09  Tom Tromey  <tom@tromey.com>
9048
9049         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9050         (expand_symtab_containing_pc, lookup_static_symbol)
9051         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9052         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9053         all_objfiles.
9054         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9055         * breakpoint.c (create_overlay_event_breakpoint)
9056         (create_longjmp_master_breakpoint)
9057         (create_std_terminate_master_breakpoint)
9058         (create_exception_master_breakpoint): Use all_objfiles.
9059         * linux-thread-db.c (try_thread_db_load_from_pdir)
9060         (has_libpthread): Use all_objfiles.
9061         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9062         * linespec.c (iterate_over_all_matching_symtabs)
9063         (search_minsyms_for_name): Use all_objfiles.
9064         * maint.c (maintenance_info_sections): Use all_objfiles.
9065         * main.c (captured_main_1): Use all_objfiles.
9066         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9067         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9068         * guile/scm-pretty-print.c
9069         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9070         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9071         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9072         (maintenance_print_msymbols): Use all_objfiles.
9073         * source.c (select_source_symtab): Use all_objfiles.
9074         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9075         * symfile.c (remove_symbol_file_command)
9076         (expand_symtabs_matching, map_symbol_filenames): Use
9077         all_objfiles.
9078         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9079         all_objfiles.
9080         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9081         * objc-lang.c (find_methods): Use all_objfiles.
9082         * objfiles.c (have_partial_symbols, have_full_symbols)
9083         (have_minimal_symbols, qsort_cmp)
9084         (default_iterate_over_objfiles_in_search_order): Use
9085         all_objfiles.
9086         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9087         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9088         (maintenance_check_psymtabs): Use all_objfiles.
9089         (ALL_PSYMTABS): Remove.
9090         * compile/compile-object-run.c (do_module_cleanup): Use
9091         all_objfiles.
9092         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9093         * cp-support.c (add_symbol_overload_list_qualified): Use
9094         all_objfiles.
9095         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9096         Use all_objfiles.
9097         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9098         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9099         all_objfiles.
9100         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9101         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9102         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9103         Uses all_objfiles.
9104         * solib.c (solib_read_symbols): Use all_objfiles
9105
9106 2019-01-09  Tom Tromey  <tom@tromey.com>
9107
9108         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9109         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9110         all_objfiles.
9111         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9112         * symmisc.c (print_symbol_bcache_statistics)
9113         (print_objfile_statistics, maintenance_print_objfiles)
9114         (maintenance_info_symtabs, maintenance_check_symtabs)
9115         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9116         all_objfiles.
9117         * source.c (forget_cached_source_info): Use all_objfiles.
9118         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9119         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9120         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9121         * objfiles.c (update_section_map): Use all_objfiles.
9122         (shared_objfile_contains_address_p): Likewise.
9123         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9124         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9125
9126 2019-01-09  Tom Tromey  <tom@tromey.com>
9127
9128         * common/next-iterator.h: New file.
9129         * objfiles.h (class all_objfiles): New.
9130         (struct objfile_iterator): New.
9131
9132 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9133
9134         * NEWS: Move the description of the changed "frame", "select-frame",
9135          and "info frame" commands to the Changed commands section.
9136
9137 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9138
9139         * gdbtypes.c (check_stub_method_group): Remove handling of old
9140         mangling schemes.
9141         * linespec.c (find_methods): Likewise.
9142         * stabsread.c (read_member_functions): Likewise.
9143         * valops.c (search_struct_method): Likewise.
9144         (value_struct_elt_for_reference): Likewise.
9145         * NEWS: Mention this change.
9146
9147 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9148
9149         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9150         print_source_lines.
9151         * source.c (print_source_lines_base): Update line number check.
9152         (print_source_lines): New function.
9153         (source_lines_range::source_lines_range): New function.
9154         * source.h (class source_lines_range): New class.
9155         (print_source_lines): New declaration.
9156
9157 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9158
9159         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9160
9161 2019-01-08  Tom Tromey  <tom@tromey.com>
9162             Simon Marchi  <simon.marchi@ericsson.com>
9163
9164         PR gdb/24060
9165         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9166         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9167         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9168         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9169         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9170         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9171
9172 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9173
9174         * source.c (select_source_symtab): Move header comment to
9175         declaration in source.h.
9176         (forget_cached_source_info_for_objfile): Likewise.
9177         (forget_cached_source_info): Likewise.
9178         (identify_source_line): Likewise.
9179         * source.h (identify_source_line): Move declaration from symtab.h
9180         and add comment from source.c
9181         (print_source_lines): Likewise.
9182         (forget_cached_source_info_for_objfile): Likewise.
9183         (forget_cached_source_info): Likewise.
9184         (select_source_symtab): Likewise.
9185         (enum print_source_lines_flag): Move definition from symtab.h.
9186         * symtab.h (identify_source_line): Move declaration to source.h.
9187         (print_source_lines): Likewise.
9188         (forget_cached_source_info_for_objfile): Likewise.
9189         (forget_cached_source_info): Likewise.
9190         (select_source_symtab): Likewise.
9191         (enum print_source_lines_flag): Move definition to source.h.
9192         * tui/tui-hooks.c: Add 'source.h' include.
9193
9194 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9195
9196         * source.c (print_source_lines_base): Handle requests to print
9197         reverse line number sequences, and guard against empty lines
9198         string.
9199
9200 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9201
9202         * source.c (print_source_lines_base): Fix skip of '\r' if next
9203         character is '\n'.
9204
9205 2019-01-06  Tom Tromey  <tom@tromey.com>
9206
9207         * c-exp.y (struct c_parse_state) <macro_original_text,
9208         expansion_obstack>: New member.
9209         (macro_original_text, expansion_obstack): Remove globals.
9210         (scan_macro_expansion, scanning_macro_expansion)
9211         (finished_macro_expansion): Update.
9212         (scan_macro_cleanup): Remove.
9213         (yylex, c_parse): Update.
9214
9215 2019-01-06  Tom Tromey  <tom@tromey.com>
9216
9217         * c-exp.y (struct c_parse_state) <strings>: New member.
9218         (operator_stoken): Update.
9219
9220 2019-01-06  Tom Tromey  <tom@tromey.com>
9221
9222         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9223         (union type_stack_elt) <typelist_val>: Now a pointer to
9224         std::vector.
9225         (type_stack_cleanup): Don't declare.
9226         (push_typelist): Update.
9227         * parse.c (pop_typelist): Return a std::vector.
9228         (push_typelist): Take a std::vector.
9229         (follow_types): Update.  Do not free args.
9230         (type_stack_cleanup): Remove.
9231         * c-exp.y (struct c_parse_state): New.
9232         (cpstate): New global.
9233         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9234         (nonempty_typelist): Update.
9235         (func_mod): Create a new vector.
9236         (c_parse): Create a c_parse_state.
9237         (check_parameter_typelist): Do not delete params.
9238         (function_method): Update.  Do not delete type_list.
9239
9240 2019-01-06  Tom Tromey  <tom@tromey.com>
9241
9242         PR gdb/28155:
9243         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9244         check_typedef.
9245         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9246         (print_return_value): Likewise.
9247
9248 2019-01-05  Tom Tromey  <tom@tromey.com>
9249
9250         * contrib/cleanup_check.py: Remove.
9251         * contrib/gcc-with-excheck: Remove.
9252         * contrib/exsummary.py: Remove.
9253         * contrib/excheck.py: Remove.
9254
9255 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9256
9257         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9258         NULL. Initialize tpprev to NULL instead of assigning it
9259         to NULL on the next statement.
9260         * windows-nat.c (windows_delete_thread): Remove check for
9261         main_thread_id before printing thread exit notifications.
9262         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9263         Remove thread ID check against main_thread_id.
9264         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9265         windows_delete_thread.
9266         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9267
9268 2019-01-04  Tom Tromey  <tom@tromey.com>
9269
9270         * compile/compile.c (_initialize_compile): Use upper case for
9271         metasyntactic variables.
9272         * symmisc.c (_initialize_symmisc): Use upper case for
9273         metasyntactic variables.
9274         * psymtab.c (_initialize_psymtab): Use upper case for
9275         metasyntactic variables.
9276         * demangle.c (demangle_command): Use upper case for metasyntactic
9277         variables.
9278         (_initialize_demangler): Likewise.
9279         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9280         variables.
9281
9282 2019-01-03  Tom Tromey  <tom@tromey.com>
9283
9284         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9285
9286 2019-01-03  Tom Tromey  <tom@tromey.com>
9287
9288         * python/py-symtab.c (salpy_str): Update.
9289         (struct salpy_sal_object) <symtab>: Now a PyObject.
9290         (salpy_dealloc): Update.
9291         (del_objfile_sal): Use gdbpy_ref.
9292
9293 2019-01-03  Tom Tromey  <tom@tromey.com>
9294
9295         * python/py-type.c (convert_field): Use new_reference.  Return
9296         gdbpy_ref.
9297         (make_fielditem): Return gdbpy_ref.
9298         (typy_fields): Update.
9299         (typy_getitem): Update.
9300         (field_name): Return gdbpy_ref.  Use new_reference.
9301         (typy_iterator_iternext): Update.
9302
9303 2019-01-03  Tom Tromey  <tom@tromey.com>
9304
9305         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9306
9307 2019-01-03  Tom Tromey  <tom@tromey.com>
9308
9309         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9310         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9311         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9312         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9313         (pspy_set_type_printers): Likewise.
9314         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9315         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9316         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9317         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9318         (objfpy_set_type_printers): Likewise.
9319
9320 2019-01-03  Tom Tromey  <tom@tromey.com>
9321
9322         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9323         (gdbpy_print_stack): Use gdbpy_err_fetch.
9324         * python/python-internal.h (class gdbpy_err_fetch): New class.
9325         (class gdbpy_enter) <m_error_type, m_error_value,
9326         m_error_traceback>: Remove.
9327         <m_error>: New member.
9328         (gdbpy_exception_to_string): Don't declare.
9329         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9330         * python/py-value.c (convert_value_from_python): Use
9331         gdbpy_err_fetch.
9332         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9333         gdbpy_exception_to_string.
9334         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9335         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9336         gdbpy_err_fetch.
9337
9338 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9339
9340         * linux-nat.c (delete_lwp_cleanup): Delete.
9341         (struct lwp_deleter): New struct.
9342         (lwp_info_up): New typedef.
9343         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9344         lwp_info_up.
9345
9346 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9347
9348         * linux-fork.c (class scoped_switch_fork_info): New class.
9349         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9350
9351 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9352
9353         * valops.c (find_overload_match): Remove use of null_cleanup, and
9354         calls to do_cleanups.
9355
9356 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9357
9358         * compile/compile-cplus-types.c
9359         (compile_cplus_instance::decl_name): Handle changes to
9360         cp_func_name.
9361         * cp-support.c (cp_func_name): Update header comment, update
9362         return type.
9363         * cp-support.h (cp_func_name): Update return type in declaration.
9364         * valops.c (find_overload_match): Move temp_func local to top
9365         level of function and change its type.  Use temp_func to hold and
9366         delete temporary string obtained from cp_func_name.
9367
9368 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9369
9370         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9371         gdb::char_vector, remove cleanup, and update uses of `msg`.
9372
9373 2019-01-03  Jim Wilson  <jimw@sifive.com>
9374
9375         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9376
9377 2019-01-02  Tom Tromey  <tom@tromey.com>
9378
9379         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9380         (tdesc_parse_xml): Remove cleanups.
9381         * target-descriptions.h (make_cleanup_free_target_description):
9382         Don't declare.
9383         (target_desc_deleter): New struct.
9384         (target_desc_up): New typedef.
9385         * target-descriptions.c (target_desc_deleter::operator()): Rename
9386         from free_target_description.
9387         (make_cleanup_free_target_description): Remove.
9388
9389 2019-01-02  Tom Tromey  <tom@tromey.com>
9390
9391         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9392         constructor, destructor.
9393         (linespec_parser): Remove typedef.
9394         (~linespec_parser): Rename from linespec_parser_delete.
9395         (linespec_lex_to_end, linespec_complete_label)
9396         (linespec_complete): Update.
9397         (decode_line_full): Remove cleanups.
9398         (decode_line_1): Update.
9399
9400 2019-01-02  Tom Tromey  <tom@tromey.com>
9401
9402         * python/python-internal.h (inferior_to_inferior_object): Change
9403         return type.
9404         * python/py-exitedevent.c (create_exited_event_object): Update.
9405         * python/py-inferior.c (inferior_to_inferior_object): Return
9406         gdbpy_ref.
9407         (python_new_inferior, python_inferior_deleted)
9408         (thread_to_thread_object, delete_thread_object)
9409         (build_inferior_list, gdbpy_selected_inferior): Update.
9410         * python/py-infthread.c (create_thread_object): Update.  Also fail
9411         if inferior_to_inferior_object fails.
9412
9413 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9414
9415         * inferior.h (class inferior) <displaced_step_state>: New field.
9416         * infrun.h (struct displaced_step_state): Move here from
9417         infrun.c.  Initialize fields, add constructor.
9418         <inf>: Remove field.
9419         <reset>: New method.
9420         * infrun.c (struct displaced_step_inferior_state): Move to
9421         infrun.h.
9422         (displaced_step_inferior_states): Remove.
9423         (get_displaced_stepping_state): Adust.
9424         (displaced_step_in_progress_any_inferior): Adjust.
9425         (displaced_step_in_progress_thread): Adjust.
9426         (displaced_step_in_progress): Adjust.
9427         (add_displaced_stepping_state): Remove.
9428         (get_displaced_step_closure_by_addr): Adjust.
9429         (remove_displaced_stepping_state): Remove.
9430         (infrun_inferior_exit): Call displaced_step_state.reset.
9431         (use_displaced_stepping): Don't check for NULL.
9432         (displaced_step_prepare_throw): Call
9433         get_displaced_stepping_state.
9434         (displaced_step_fixup): Don't check for NULL.
9435         (prepare_for_detach): Don't check for NULL.
9436
9437 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9438
9439         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
9440          in case of call that did not complete.
9441
9442 2019-01-02  Andrey Utkin  <autkin@undo.io>
9443
9444         * symfile.c (find_separate_debug_file): Fix search of debug files for
9445         remote debuggee.
9446
9447 2019-01-02  Tom Tromey  <tom@tromey.com>
9448
9449         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
9450         indentation.
9451         * python/py-frame.c (frapy_older): Remove cast.
9452         (frapy_newer): Likewise.
9453         * python/py-breakpoint.c (local_setattro): Remove cast.
9454         * python/py-arch.c (archpy_name): Remove local variable.
9455         * python/py-type.c (gdbpy_lookup_type): Remove cast.
9456
9457 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
9458
9459         * unittests/basic_string_view/element_access/char/empty.cc:
9460         Fix year range in copyright header.
9461
9462 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9463
9464         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
9465         Delete.
9466         <operator==>: Update with for removed field.
9467         <hash>: Likewise.
9468         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
9469         <isa_features>: ...this.
9470         <abi_features>: New field.
9471         (riscv_isa_flen): Update comment.
9472         (riscv_abi_xlen): New declaration.
9473         (riscv_abi_flen): New declaration.
9474         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
9475         isa_features.
9476         (riscv_abi_xlen): New function.
9477         (riscv_isa_flen): Update to get answer from isa_features.
9478         (riscv_abi_flen): New function.
9479         (riscv_has_fp_abi): Update to get answer from abi_features.
9480         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
9481         xlen and flen.
9482         (riscv_call_info) <xlen, flen>: Update comment.
9483         (riscv_call_arg_struct): Remove invalid assertions
9484         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
9485         is removed.
9486         (riscv_gdbarch_init): Gather isa features and abi features
9487         separately, ensure both match on the gdbarch when reusing an old
9488         gdbarch.  Relax an error check to allow 32-bit abi float to run on
9489         a target with 64-bit float hardware.
9490
9491 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9492
9493         * source.c (search_command_helper): Stop reverse search
9494         when line 1 has been searched.
9495
9496 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9497
9498         * record-full.c (record_full_base_target::close): Rewrite
9499         record_full_core_buf_list free logic.
9500
9501 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9502
9503         * break-catch-syscall.c (print_one_catch_syscall): xfree
9504         the last text.
9505
9506 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9507
9508         * top.c (print_gdb_version): Update Copyright year in version
9509         message.
9510
9511 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9512
9513         Update copyright year range in all GDB files.
9514
9515 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
9516
9517         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
9518
9519 For older changes see ChangeLog-2018.
9520 \f
9521 Local Variables:
9522 mode: change-log
9523 left-margin: 8
9524 fill-column: 74
9525 version-control: never
9526 coding: utf-8
9527 End:
9528