Another fix for GDB styling
[external/binutils.git] / gdb / ChangeLog
1 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
2
3         * utils.c (prompt_for_continue): Don't restore the styling at the
4         end, as applied_style has the wrong value.  This fixes styling in
5         long lists of file names that are interrupted by the "Continue?"
6         prompt.
7
8 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
9
10         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11         * c-lang.c (c_language_defn): Likewise.
12         (cplus_language_defn): Likewise.
13         (asm_language_defn): Likewise.
14         (minimal_language_defn): Likewise.
15         * d-lang.c (d_language_defn): Likewise.
16         * f-lang.c (f_language_defn): Likewise.
17         * go-lang.c (go_language_defn): Likewise.
18         * language.c (unknown_language_defn): Likewise.
19         (auto_language_defn): Likewise.
20         * language.h (struct language_defn): Remove la_magic field.
21         (LANG_MAGIC): Delete.
22         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
23         * objc-lang.c (objc_language_defn): Likewise.
24         * opencl-lang.c (opencl_language_defn): Likewise.
25         * p-lang.c (pascal_language_defn): Likewise.
26         * rust-lang.c (rust_language_defn): Likewise.
27
28 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
29
30         * riscv-tdep.c (riscv_type_align): New function.
31         (riscv_type_alignment): Delete.
32         (riscv_arg_location): Use 'type_align'.
33         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
34
35 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
36
37         * gdbtypes.c (type_align): A struct with no non-static fields also
38         has alignment of 1.
39
40 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
41
42         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
43         component to 0.
44         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
45         member.
46         (riscv_struct_info::analyse): New implementation using new
47         analyse_inner member function.
48         (riscv_struct_info::field_offset): New member function.
49         (riscv_struct_info::m_offsets): New member variable.
50         (riscv_struct_info::analyse_inner): New private member function,
51         takes the old implementation of riscv_struct_info::analyse but
52         extended to track field offsets.
53         (riscv_call_arg_struct): Update the struct folding special cases
54         to handle cases where empty C++ structs, which are non-zero
55         length, are found.
56         (riscv_arg_location): Initialise the length of each location, a
57         non-zero length now indicates the location is in use.
58         (riscv_push_dummy_call): Allow for the first location having a
59         non-zero offset when setting up arguments.
60         (riscv_return_value): Likewise, but for return values.
61
62 2019-04-11  Tom Tromey  <tromey@adacore.com>
63
64         * utils.c (internal_vproblem): Make "msg" const.
65
66 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
67
68         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
69         * trad-frame.c (trad_frame_reset_saved_regs): New function.
70         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
71         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
72
73 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
74
75         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
76         function.
77         (fill_gregset): Call amd64_linux_collect_native_gregset instead
78         of amd64_collect_native_gregset.
79         (amd64_linux_nat_target::store_registers): Likewise.
80
81 2019-04-10  Tom Tromey  <tom@tromey.com>
82
83         * symtab.c (lookup_global_symbol_from_objfile)
84         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
85         * objfiles.h (class separate_debug_iterator): New.
86         (class separate_debug_range): New.
87         (struct objfile) <separate_debug_objfiles>: New method.
88         (objfile_separate_debug_iterate): Don't declare.
89         * objfiles.c (separate_debug_iterator::operator++): Rename from
90         objfile_separate_debug_iterate.
91         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
92         iterator.
93         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
94         iterator.
95
96 2019-04-10  Tom Tromey  <tom@tromey.com>
97
98         * symfile.c (reread_symbols): Remove old comment.
99         * objfiles.c (free_all_objfiles): Fix a typo.
100
101 2019-04-10  Tom Tromey  <tom@tromey.com>
102
103         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
104         * minsyms.c (lookup_minimal_symbol): Use foreach.
105         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
106         (lookup_minimal_symbol_solib_trampoline): Likewise.
107         * symfile.c (reread_symbols): Use foreach.
108
109 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
110             Tom Tromey  <tromey@adacore.com>
111
112         PR rust/24414:
113         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
114         (rust_lex_int_test): Change "value" to be LONGEST.
115         (rust_lex_tests): Add test for long integer literal.
116
117 2019-04-09  Tom Tromey  <tromey@adacore.com>
118
119         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
120         to bool.
121         (extended_remote_target::attach): Update.
122         (remote_target::remote_notice_new_inferior): Update.
123         (remote_target::add_current_inferior_and_thread): Update.
124         * inferior.c (exit_inferior_1): Use "false".
125         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
126
127 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
128
129         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
130         the "start" command.
131
132 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
133
134         * python/py-inferior.c (infpy_thread_from_thread_handle):
135         Adjust comments to reflect renaming of thread_from_thread_handle
136         to thread_from_handle.  Adjust keywords.  Fix type error message.
137         (inferior_object_methods): Add thread_from_handle.  Retain
138         thread_from_thread_handle, but mark it as deprecated.
139
140 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
141
142         * gdbthread.h (find_thread_by_handle): Revise declaration.
143         * thread.c (find_thread_by_handle): Likewise.  Adjust
144         implementation too.
145         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
146         support for buffer objects as handles.
147
148 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
149
150         * python/py-infthread.c (thpy_thread_handle): New function.
151         (thread_object_methods): Register thpy_thread_handle.
152
153 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
154
155         * gdbthread.h (thread_to_thread_handle): Declare.
156         * thread.c (gdbtypes.h): Include.
157         (thread_to_thread_handle): New function.
158
159         * target.h (struct target_ops): Add thread_info_to_thread_handle.
160         (target_thread_info_to_thread_handle): Declare.
161         * target.c (target_thread_info_to_thread_handle): New function.
162         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
163         * target-delegates.c: Regenerate.
164
165         * linux-thread-db.c (class thread_db_target): Add method
166         thread_info_to_thread_handle.
167         (thread_db_target::thread_info_to_thread_handle): Define.
168         * remote.c (class remote_target): Add new method
169         thread_info_to_thread_handle.
170         (remote_target::thread_info_to_thread_handle): Define.
171
172 2019-04-08  Pedro Alves  <palves@redhat.com>
173
174         * common/common-exceptions.c (throw_exception): Don't create
175         named object to throw; throw directly.
176         (throw_it): Likewise.  Don't initialize gdb_exception::message
177         here, with new; pass FMT and AP to the ctor instead.
178         * common/common-exceptions.h: Include <string>.
179         (gdb_exception::gdb_exception(enum return_reason, enum errors,
180         const char *, va_list)): New ctor.  Use std::make_shared.
181         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
182         errors)): Delete.
183         (gdb_exception_error::gdb_exception_error(enum errors, const char
184         *, va_list)): New.
185         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
186         Add assertion.
187         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
188         errors)): Delete.
189         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
190         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
191         Add assertion.
192
193 2019-04-08  Tom Tromey  <tom@tromey.com>
194
195         * valops.c (value_rtti_indirect_type): Replace throw_exception
196         with throw.
197         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
198         with throw.
199         * thread.c (thr_try_catch_cmd): Replace throw_exception with
200         throw.
201         * target.c (target_translate_tls_address): Replace throw_exception
202         with throw.
203         * stack.c (frame_apply_command_count): Replace throw_exception
204         with throw.
205         * solib-spu.c (append_ocl_sos): Replace throw_exception with
206         throw.
207         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
208         with throw.
209         * rs6000-tdep.c (rs6000_frame_cache)
210         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
211         * remote.c: Replace throw_exception with throw.
212         * record-full.c (record_full_message, record_full_wait_1)
213         (record_full_restore): Replace throw_exception with throw.
214         * record-btrace.c:
215         (get_thread_current_frame_id, record_btrace_start_replaying)
216         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
217         (cmd_record_btrace_start): Replace throw_exception with throw.
218         * parse.c (parse_exp_in_context_1): Replace throw_exception with
219         throw.
220         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
221         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
222         * linespec.c:
223         (find_linespec_symbols): Replace throw_exception with throw.
224         * infrun.c (displaced_step_prepare, resume): Replace
225         throw_exception with throw.
226         * infcmd.c (post_create_inferior): Replace throw_exception with
227         throw.
228         * inf-loop.c (inferior_event_handler): Replace throw_exception
229         with throw.
230         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
231         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
232         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
233         (get_prev_frame_always, get_frame_pc_if_available)
234         (get_frame_address_in_block_if_available, get_frame_language):
235         Replace throw_exception with throw.
236         * frame-unwind.c (frame_unwind_try_unwinder): Replace
237         throw_exception with throw.
238         * eval.c (fetch_subexp_value, evaluate_var_value)
239         (evaluate_funcall, evaluate_subexp_standard): Replace
240         throw_exception with throw.
241         * dwarf2loc.c (call_site_find_chain)
242         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
243         Replace throw_exception with throw.
244         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
245         with throw.
246         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
247         throw.
248         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
249         * completer.c (complete_line_internal): Replace throw_exception
250         with throw.
251         * compile/compile-object-run.c (compile_object_run): Replace
252         throw_exception with throw.
253         * cli/cli-script.c (process_next_line): Replace throw_exception
254         with throw.
255         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
256         (btrace_enable, btrace_maint_update_pt_packets): Replace
257         throw_exception with throw.
258         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
259         throw_exception with throw.
260         * break-catch-throw.c (re_set_exception_catchpoint): Replace
261         throw_exception with throw.
262         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
263         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
264         * aarch64-tdep.c (aarch64_make_prologue_cache)
265         (aarch64_make_stub_cache): Replace throw_exception with throw.
266
267 2019-04-08  Tom Tromey  <tom@tromey.com>
268
269         * common/common-exceptions.c (throw_exception): Rename from
270         throw_exception_cxx.  Remove old copy.  Make argument const.
271         (throw_it): Create and throw exception objects directly.
272         * common/common-exceptions.h (throw_exception): Make argument
273         const.
274         (struct gdb_exception_error): Add constructor.
275         (struct gdb_exception_quit): Add constructor.
276
277 2019-04-08  Tom Tromey  <tom@tromey.com>
278
279         * common/common-exceptions.h (exception_rethrow): Don't declare.
280         (TRY_SJLJ): Update comment.
281         (TRY, CATCH, END_CATCH): Remove.
282         * common/common-exceptions.c (exception_rethrow): Remove.
283
284 2019-04-08  Tom Tromey  <tom@tromey.com>
285
286         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
287         Remove.
288         (gdb_exception_error): Rename from
289         gdb_exception_RETURN_MASK_ERROR.
290         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
291         (gdb_quit_bad_alloc): Update.
292         * aarch64-tdep.c: Update.
293         * ada-lang.c: Update.
294         * ada-typeprint.c: Update.
295         * ada-valprint.c: Update.
296         * amd64-tdep.c: Update.
297         * arch-utils.c: Update.
298         * break-catch-throw.c: Update.
299         * breakpoint.c: Update.
300         * btrace.c: Update.
301         * c-varobj.c: Update.
302         * cli/cli-cmds.c: Update.
303         * cli/cli-interp.c: Update.
304         * cli/cli-script.c: Update.
305         * common/common-exceptions.c: Update.
306         * common/new-op.c: Update.
307         * common/selftest.c: Update.
308         * compile/compile-c-symbols.c: Update.
309         * compile/compile-cplus-symbols.c: Update.
310         * compile/compile-object-load.c: Update.
311         * compile/compile-object-run.c: Update.
312         * completer.c: Update.
313         * corelow.c: Update.
314         * cp-abi.c: Update.
315         * cp-support.c: Update.
316         * cp-valprint.c: Update.
317         * darwin-nat.c: Update.
318         * disasm-selftests.c: Update.
319         * dtrace-probe.c: Update.
320         * dwarf-index-cache.c: Update.
321         * dwarf-index-write.c: Update.
322         * dwarf2-frame-tailcall.c: Update.
323         * dwarf2-frame.c: Update.
324         * dwarf2loc.c: Update.
325         * dwarf2read.c: Update.
326         * eval.c: Update.
327         * event-loop.c: Update.
328         * event-top.c: Update.
329         * exec.c: Update.
330         * f-valprint.c: Update.
331         * fbsd-tdep.c: Update.
332         * frame-unwind.c: Update.
333         * frame.c: Update.
334         * gdbtypes.c: Update.
335         * gnu-v3-abi.c: Update.
336         * guile/guile-internal.h: Update.
337         * guile/scm-block.c: Update.
338         * guile/scm-breakpoint.c: Update.
339         * guile/scm-cmd.c: Update.
340         * guile/scm-disasm.c: Update.
341         * guile/scm-frame.c: Update.
342         * guile/scm-lazy-string.c: Update.
343         * guile/scm-math.c: Update.
344         * guile/scm-param.c: Update.
345         * guile/scm-ports.c: Update.
346         * guile/scm-pretty-print.c: Update.
347         * guile/scm-symbol.c: Update.
348         * guile/scm-symtab.c: Update.
349         * guile/scm-type.c: Update.
350         * guile/scm-value.c: Update.
351         * i386-linux-tdep.c: Update.
352         * i386-tdep.c: Update.
353         * inf-loop.c: Update.
354         * infcall.c: Update.
355         * infcmd.c: Update.
356         * infrun.c: Update.
357         * jit.c: Update.
358         * language.c: Update.
359         * linespec.c: Update.
360         * linux-fork.c: Update.
361         * linux-nat.c: Update.
362         * linux-tdep.c: Update.
363         * linux-thread-db.c: Update.
364         * main.c: Update.
365         * mi/mi-cmd-break.c: Update.
366         * mi/mi-cmd-stack.c: Update.
367         * mi/mi-interp.c: Update.
368         * mi/mi-main.c: Update.
369         * objc-lang.c: Update.
370         * p-valprint.c: Update.
371         * parse.c: Update.
372         * ppc-linux-tdep.c: Update.
373         * printcmd.c: Update.
374         * python/py-arch.c: Update.
375         * python/py-breakpoint.c: Update.
376         * python/py-cmd.c: Update.
377         * python/py-finishbreakpoint.c: Update.
378         * python/py-frame.c: Update.
379         * python/py-framefilter.c: Update.
380         * python/py-gdb-readline.c: Update.
381         * python/py-inferior.c: Update.
382         * python/py-infthread.c: Update.
383         * python/py-lazy-string.c: Update.
384         * python/py-linetable.c: Update.
385         * python/py-objfile.c: Update.
386         * python/py-param.c: Update.
387         * python/py-prettyprint.c: Update.
388         * python/py-progspace.c: Update.
389         * python/py-record-btrace.c: Update.
390         * python/py-record.c: Update.
391         * python/py-symbol.c: Update.
392         * python/py-type.c: Update.
393         * python/py-unwind.c: Update.
394         * python/py-utils.c: Update.
395         * python/py-value.c: Update.
396         * python/python.c: Update.
397         * record-btrace.c: Update.
398         * record-full.c: Update.
399         * remote-fileio.c: Update.
400         * remote.c: Update.
401         * riscv-tdep.c: Update.
402         * rs6000-aix-tdep.c: Update.
403         * rs6000-tdep.c: Update.
404         * rust-exp.y: Update.
405         * rust-lang.c: Update.
406         * s390-tdep.c: Update.
407         * selftest-arch.c: Update.
408         * solib-dsbt.c: Update.
409         * solib-frv.c: Update.
410         * solib-spu.c: Update.
411         * solib-svr4.c: Update.
412         * solib.c: Update.
413         * sparc64-linux-tdep.c: Update.
414         * stack.c: Update.
415         * symfile-mem.c: Update.
416         * symmisc.c: Update.
417         * target.c: Update.
418         * thread.c: Update.
419         * top.c: Update.
420         * tracefile-tfile.c: Update.
421         * tui/tui.c: Update.
422         * typeprint.c: Update.
423         * unittests/cli-utils-selftests.c: Update.
424         * unittests/parse-connection-spec-selftests.c: Update.
425         * valops.c: Update.
426         * valprint.c: Update.
427         * value.c: Update.
428         * varobj.c: Update.
429         * windows-nat.c: Update.
430         * x86-linux-nat.c: Update.
431         * xml-support.c: Update.
432
433 2019-04-08  Tom Tromey  <tom@tromey.com>
434
435         * xml-support.c: Use C++ exception handling.
436         * x86-linux-nat.c: Use C++ exception handling.
437         * windows-nat.c: Use C++ exception handling.
438         * varobj.c: Use C++ exception handling.
439         * value.c: Use C++ exception handling.
440         * valprint.c: Use C++ exception handling.
441         * valops.c: Use C++ exception handling.
442         * unittests/parse-connection-spec-selftests.c: Use C++ exception
443         handling.
444         * unittests/cli-utils-selftests.c: Use C++ exception handling.
445         * typeprint.c: Use C++ exception handling.
446         * tui/tui.c: Use C++ exception handling.
447         * tracefile-tfile.c: Use C++ exception handling.
448         * top.c: Use C++ exception handling.
449         * thread.c: Use C++ exception handling.
450         * target.c: Use C++ exception handling.
451         * symmisc.c: Use C++ exception handling.
452         * symfile-mem.c: Use C++ exception handling.
453         * stack.c: Use C++ exception handling.
454         * sparc64-linux-tdep.c: Use C++ exception handling.
455         * solib.c: Use C++ exception handling.
456         * solib-svr4.c: Use C++ exception handling.
457         * solib-spu.c: Use C++ exception handling.
458         * solib-frv.c: Use C++ exception handling.
459         * solib-dsbt.c: Use C++ exception handling.
460         * selftest-arch.c: Use C++ exception handling.
461         * s390-tdep.c: Use C++ exception handling.
462         * rust-lang.c: Use C++ exception handling.
463         * rust-exp.y: Use C++ exception handling.
464         * rs6000-tdep.c: Use C++ exception handling.
465         * rs6000-aix-tdep.c: Use C++ exception handling.
466         * riscv-tdep.c: Use C++ exception handling.
467         * remote.c: Use C++ exception handling.
468         * remote-fileio.c: Use C++ exception handling.
469         * record-full.c: Use C++ exception handling.
470         * record-btrace.c: Use C++ exception handling.
471         * python/python.c: Use C++ exception handling.
472         * python/py-value.c: Use C++ exception handling.
473         * python/py-utils.c: Use C++ exception handling.
474         * python/py-unwind.c: Use C++ exception handling.
475         * python/py-type.c: Use C++ exception handling.
476         * python/py-symbol.c: Use C++ exception handling.
477         * python/py-record.c: Use C++ exception handling.
478         * python/py-record-btrace.c: Use C++ exception handling.
479         * python/py-progspace.c: Use C++ exception handling.
480         * python/py-prettyprint.c: Use C++ exception handling.
481         * python/py-param.c: Use C++ exception handling.
482         * python/py-objfile.c: Use C++ exception handling.
483         * python/py-linetable.c: Use C++ exception handling.
484         * python/py-lazy-string.c: Use C++ exception handling.
485         * python/py-infthread.c: Use C++ exception handling.
486         * python/py-inferior.c: Use C++ exception handling.
487         * python/py-gdb-readline.c: Use C++ exception handling.
488         * python/py-framefilter.c: Use C++ exception handling.
489         * python/py-frame.c: Use C++ exception handling.
490         * python/py-finishbreakpoint.c: Use C++ exception handling.
491         * python/py-cmd.c: Use C++ exception handling.
492         * python/py-breakpoint.c: Use C++ exception handling.
493         * python/py-arch.c: Use C++ exception handling.
494         * printcmd.c: Use C++ exception handling.
495         * ppc-linux-tdep.c: Use C++ exception handling.
496         * parse.c: Use C++ exception handling.
497         * p-valprint.c: Use C++ exception handling.
498         * objc-lang.c: Use C++ exception handling.
499         * mi/mi-main.c: Use C++ exception handling.
500         * mi/mi-interp.c: Use C++ exception handling.
501         * mi/mi-cmd-stack.c: Use C++ exception handling.
502         * mi/mi-cmd-break.c: Use C++ exception handling.
503         * main.c: Use C++ exception handling.
504         * linux-thread-db.c: Use C++ exception handling.
505         * linux-tdep.c: Use C++ exception handling.
506         * linux-nat.c: Use C++ exception handling.
507         * linux-fork.c: Use C++ exception handling.
508         * linespec.c: Use C++ exception handling.
509         * language.c: Use C++ exception handling.
510         * jit.c: Use C++ exception handling.
511         * infrun.c: Use C++ exception handling.
512         * infcmd.c: Use C++ exception handling.
513         * infcall.c: Use C++ exception handling.
514         * inf-loop.c: Use C++ exception handling.
515         * i386-tdep.c: Use C++ exception handling.
516         * i386-linux-tdep.c: Use C++ exception handling.
517         * guile/scm-value.c: Use C++ exception handling.
518         * guile/scm-type.c: Use C++ exception handling.
519         * guile/scm-symtab.c: Use C++ exception handling.
520         * guile/scm-symbol.c: Use C++ exception handling.
521         * guile/scm-pretty-print.c: Use C++ exception handling.
522         * guile/scm-ports.c: Use C++ exception handling.
523         * guile/scm-param.c: Use C++ exception handling.
524         * guile/scm-math.c: Use C++ exception handling.
525         * guile/scm-lazy-string.c: Use C++ exception handling.
526         * guile/scm-frame.c: Use C++ exception handling.
527         * guile/scm-disasm.c: Use C++ exception handling.
528         * guile/scm-cmd.c: Use C++ exception handling.
529         * guile/scm-breakpoint.c: Use C++ exception handling.
530         * guile/scm-block.c: Use C++ exception handling.
531         * guile/guile-internal.h: Use C++ exception handling.
532         * gnu-v3-abi.c: Use C++ exception handling.
533         * gdbtypes.c: Use C++ exception handling.
534         * frame.c: Use C++ exception handling.
535         * frame-unwind.c: Use C++ exception handling.
536         * fbsd-tdep.c: Use C++ exception handling.
537         * f-valprint.c: Use C++ exception handling.
538         * exec.c: Use C++ exception handling.
539         * event-top.c: Use C++ exception handling.
540         * event-loop.c: Use C++ exception handling.
541         * eval.c: Use C++ exception handling.
542         * dwarf2read.c: Use C++ exception handling.
543         * dwarf2loc.c: Use C++ exception handling.
544         * dwarf2-frame.c: Use C++ exception handling.
545         * dwarf2-frame-tailcall.c: Use C++ exception handling.
546         * dwarf-index-write.c: Use C++ exception handling.
547         * dwarf-index-cache.c: Use C++ exception handling.
548         * dtrace-probe.c: Use C++ exception handling.
549         * disasm-selftests.c: Use C++ exception handling.
550         * darwin-nat.c: Use C++ exception handling.
551         * cp-valprint.c: Use C++ exception handling.
552         * cp-support.c: Use C++ exception handling.
553         * cp-abi.c: Use C++ exception handling.
554         * corelow.c: Use C++ exception handling.
555         * completer.c: Use C++ exception handling.
556         * compile/compile-object-run.c: Use C++ exception handling.
557         * compile/compile-object-load.c: Use C++ exception handling.
558         * compile/compile-cplus-symbols.c: Use C++ exception handling.
559         * compile/compile-c-symbols.c: Use C++ exception handling.
560         * common/selftest.c: Use C++ exception handling.
561         * common/new-op.c: Use C++ exception handling.
562         * cli/cli-script.c: Use C++ exception handling.
563         * cli/cli-interp.c: Use C++ exception handling.
564         * cli/cli-cmds.c: Use C++ exception handling.
565         * c-varobj.c: Use C++ exception handling.
566         * btrace.c: Use C++ exception handling.
567         * breakpoint.c: Use C++ exception handling.
568         * break-catch-throw.c: Use C++ exception handling.
569         * arch-utils.c: Use C++ exception handling.
570         * amd64-tdep.c: Use C++ exception handling.
571         * ada-valprint.c: Use C++ exception handling.
572         * ada-typeprint.c: Use C++ exception handling.
573         * ada-lang.c: Use C++ exception handling.
574         * aarch64-tdep.c: Use C++ exception handling.
575
576 2019-04-08  Tom Tromey  <tom@tromey.com>
577
578         * xml-support.c (gdb_xml_parser::parse): Update.
579         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
580         * value.c (show_convenience): Update.
581         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
582         (test_parse_flags_qcs): Update.
583         * thread.c (thr_try_catch_cmd): Update.
584         * target.c (target_translate_tls_address): Update.
585         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
586         (info_frame_command_core, frame_apply_command_count): Update.
587         * rust-exp.y (rust_lex_exception_test): Update.
588         * riscv-tdep.c (riscv_print_one_register_info): Update.
589         * remote.c (remote_target::enable_btrace): Update.
590         * record-btrace.c (record_btrace_enable_warn): Update.
591         * python/py-utils.c (gdbpy_convert_exception): Update.
592         * printcmd.c (do_one_display, print_variable_and_value): Update.
593         * mi/mi-main.c (mi_print_exception): Update.
594         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
595         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
596         * linux-nat.c (linux_nat_target::attach): Update.
597         * linux-fork.c (class scoped_switch_fork_info): Update.
598         * infrun.c (displaced_step_prepare): Update.
599         * infcall.c (call_function_by_hand_dummy): Update.
600         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
601         * gnu-v3-abi.c (print_one_vtable): Update.
602         * frame.c (get_prev_frame_always): Update.
603         * f-valprint.c (info_common_command_for_block): Update.
604         * exec.c (try_open_exec_file): Update.
605         * exceptions.c (print_exception, exception_print)
606         (exception_fprintf, exception_print_same): Update.
607         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
608         * dwarf-index-cache.c (index_cache::store)
609         (index_cache::lookup_gdb_index): Update.
610         * darwin-nat.c (maybe_cache_shell): Update.
611         * cp-valprint.c (cp_print_value_fields): Update.
612         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
613         (gcc_cplus_symbol_address): Update.
614         * compile/compile-c-symbols.c (gcc_convert_symbol)
615         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
616         * common/selftest.c: Update.
617         * common/common-exceptions.h (struct gdb_exception) <message>: Now
618         a std::string.
619         (exception_try_scope_entry, exception_try_scope_exit): Don't
620         declare.
621         (struct exception_try_scope): Remove.
622         (TRY): Don't use exception_try_scope.
623         (struct gdb_exception): Add constructor, operator=.
624         <what>: New method.
625         (struct gdb_exception_RETURN_MASK_ALL)
626         (struct gdb_exception_RETURN_MASK_ERROR)
627         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
628         (struct gdb_quit_bad_alloc): Update.
629         * common/common-exceptions.c (exception_none): Change
630         initializer.
631         (struct catcher) <state, exception>: Initialize inline.
632         <prev>: Remove member.
633         (current_catcher): Remove.
634         (catchers): New global.
635         (exceptions_state_mc_init): Simplify.
636         (catcher_pop): Remove.
637         (exceptions_state_mc, exceptions_state_mc_catch): Update.
638         (try_scope_depth, exception_try_scope_entry)
639         (exception_try_scope_exit): Remove.
640         (throw_exception_sjlj): Update.
641         (exception_messages, exception_messages_size): Remove.
642         (throw_it): Simplify.
643         (gdb_exception_sliced_copy): Remove.
644         (throw_exception_cxx): Update.
645         * cli/cli-script.c (script_from_file): Update.
646         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
647         Update.
648         * ada-valprint.c (ada_val_print): Update.
649         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
650         (create_excep_cond_exprs): Update.
651
652 2019-04-08  Tom Tromey  <tom@tromey.com>
653
654         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
655         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
656         (TRY, CATCH, END_CATCH): Remove some definitions.
657         * common/common-exceptions.c: Don't use GDB_XCPT.
658         (catcher_list_size): Remove.
659         (throw_exception, throw_it): Simplify.
660
661 2019-04-05  Tom Tromey  <tom@tromey.com>
662
663         Revert the header-sorting patch.
664         * ft32-tdep.c: Revert.
665         * frv-tdep.c: Revert.
666         * frv-linux-tdep.c: Revert.
667         * frame.c: Revert.
668         * frame-unwind.c: Revert.
669         * frame-base.c: Revert.
670         * fork-child.c: Revert.
671         * findvar.c: Revert.
672         * findcmd.c: Revert.
673         * filesystem.c: Revert.
674         * filename-seen-cache.h: Revert.
675         * filename-seen-cache.c: Revert.
676         * fbsd-tdep.c: Revert.
677         * fbsd-nat.h: Revert.
678         * fbsd-nat.c: Revert.
679         * f-valprint.c: Revert.
680         * f-typeprint.c: Revert.
681         * f-lang.c: Revert.
682         * extension.h: Revert.
683         * extension.c: Revert.
684         * extension-priv.h: Revert.
685         * expprint.c: Revert.
686         * exec.h: Revert.
687         * exec.c: Revert.
688         * exceptions.c: Revert.
689         * event-top.c: Revert.
690         * event-loop.c: Revert.
691         * eval.c: Revert.
692         * elfread.c: Revert.
693         * dwarf2read.h: Revert.
694         * dwarf2read.c: Revert.
695         * dwarf2loc.c: Revert.
696         * dwarf2expr.h: Revert.
697         * dwarf2expr.c: Revert.
698         * dwarf2-frame.c: Revert.
699         * dwarf2-frame-tailcall.c: Revert.
700         * dwarf-index-write.h: Revert.
701         * dwarf-index-write.c: Revert.
702         * dwarf-index-common.c: Revert.
703         * dwarf-index-cache.h: Revert.
704         * dwarf-index-cache.c: Revert.
705         * dummy-frame.c: Revert.
706         * dtrace-probe.c: Revert.
707         * disasm.h: Revert.
708         * disasm.c: Revert.
709         * disasm-selftests.c: Revert.
710         * dictionary.c: Revert.
711         * dicos-tdep.c: Revert.
712         * demangle.c: Revert.
713         * dcache.h: Revert.
714         * dcache.c: Revert.
715         * darwin-nat.h: Revert.
716         * darwin-nat.c: Revert.
717         * darwin-nat-info.c: Revert.
718         * d-valprint.c: Revert.
719         * d-namespace.c: Revert.
720         * d-lang.c: Revert.
721         * ctf.c: Revert.
722         * csky-tdep.c: Revert.
723         * csky-linux-tdep.c: Revert.
724         * cris-tdep.c: Revert.
725         * cris-linux-tdep.c: Revert.
726         * cp-valprint.c: Revert.
727         * cp-support.c: Revert.
728         * cp-namespace.c: Revert.
729         * cp-abi.c: Revert.
730         * corelow.c: Revert.
731         * corefile.c: Revert.
732         * continuations.c: Revert.
733         * completer.h: Revert.
734         * completer.c: Revert.
735         * complaints.c: Revert.
736         * coffread.c: Revert.
737         * coff-pe-read.c: Revert.
738         * cli-out.h: Revert.
739         * cli-out.c: Revert.
740         * charset.c: Revert.
741         * c-varobj.c: Revert.
742         * c-valprint.c: Revert.
743         * c-typeprint.c: Revert.
744         * c-lang.c: Revert.
745         * buildsym.c: Revert.
746         * buildsym-legacy.c: Revert.
747         * build-id.h: Revert.
748         * build-id.c: Revert.
749         * btrace.c: Revert.
750         * bsd-uthread.c: Revert.
751         * breakpoint.h: Revert.
752         * breakpoint.c: Revert.
753         * break-catch-throw.c: Revert.
754         * break-catch-syscall.c: Revert.
755         * break-catch-sig.c: Revert.
756         * blockframe.c: Revert.
757         * block.c: Revert.
758         * bfin-tdep.c: Revert.
759         * bfin-linux-tdep.c: Revert.
760         * bfd-target.c: Revert.
761         * bcache.c: Revert.
762         * ax-general.c: Revert.
763         * ax-gdb.h: Revert.
764         * ax-gdb.c: Revert.
765         * avr-tdep.c: Revert.
766         * auxv.c: Revert.
767         * auto-load.c: Revert.
768         * arm-wince-tdep.c: Revert.
769         * arm-tdep.c: Revert.
770         * arm-symbian-tdep.c: Revert.
771         * arm-pikeos-tdep.c: Revert.
772         * arm-obsd-tdep.c: Revert.
773         * arm-nbsd-tdep.c: Revert.
774         * arm-nbsd-nat.c: Revert.
775         * arm-linux-tdep.c: Revert.
776         * arm-linux-nat.c: Revert.
777         * arm-fbsd-tdep.c: Revert.
778         * arm-fbsd-nat.c: Revert.
779         * arm-bsd-tdep.c: Revert.
780         * arch-utils.c: Revert.
781         * arc-tdep.c: Revert.
782         * arc-newlib-tdep.c: Revert.
783         * annotate.h: Revert.
784         * annotate.c: Revert.
785         * amd64-windows-tdep.c: Revert.
786         * amd64-windows-nat.c: Revert.
787         * amd64-tdep.c: Revert.
788         * amd64-sol2-tdep.c: Revert.
789         * amd64-obsd-tdep.c: Revert.
790         * amd64-obsd-nat.c: Revert.
791         * amd64-nbsd-tdep.c: Revert.
792         * amd64-nbsd-nat.c: Revert.
793         * amd64-nat.c: Revert.
794         * amd64-linux-tdep.c: Revert.
795         * amd64-linux-nat.c: Revert.
796         * amd64-fbsd-tdep.c: Revert.
797         * amd64-fbsd-nat.c: Revert.
798         * amd64-dicos-tdep.c: Revert.
799         * amd64-darwin-tdep.c: Revert.
800         * amd64-bsd-nat.c: Revert.
801         * alpha-tdep.c: Revert.
802         * alpha-obsd-tdep.c: Revert.
803         * alpha-nbsd-tdep.c: Revert.
804         * alpha-mdebug-tdep.c: Revert.
805         * alpha-linux-tdep.c: Revert.
806         * alpha-linux-nat.c: Revert.
807         * alpha-bsd-tdep.c: Revert.
808         * alpha-bsd-nat.c: Revert.
809         * aix-thread.c: Revert.
810         * agent.c: Revert.
811         * addrmap.c: Revert.
812         * ada-varobj.c: Revert.
813         * ada-valprint.c: Revert.
814         * ada-typeprint.c: Revert.
815         * ada-tasks.c: Revert.
816         * ada-lang.c: Revert.
817         * aarch64-tdep.c: Revert.
818         * aarch64-ravenscar-thread.c: Revert.
819         * aarch64-newlib-tdep.c: Revert.
820         * aarch64-linux-tdep.c: Revert.
821         * aarch64-linux-nat.c: Revert.
822         * aarch64-fbsd-tdep.c: Revert.
823         * aarch64-fbsd-nat.c: Revert.
824         * aarch32-linux-nat.c: Revert.
825
826 2019-04-05  Tom Tromey  <tom@tromey.com>
827
828         * ft32-tdep.c: Sort headers.
829         * frv-tdep.c: Sort headers.
830         * frv-linux-tdep.c: Sort headers.
831         * frame.c: Sort headers.
832         * frame-unwind.c: Sort headers.
833         * frame-base.c: Sort headers.
834         * fork-child.c: Sort headers.
835         * findvar.c: Sort headers.
836         * findcmd.c: Sort headers.
837         * filesystem.c: Sort headers.
838         * filename-seen-cache.h: Sort headers.
839         * filename-seen-cache.c: Sort headers.
840         * fbsd-tdep.c: Sort headers.
841         * fbsd-nat.h: Sort headers.
842         * fbsd-nat.c: Sort headers.
843         * f-valprint.c: Sort headers.
844         * f-typeprint.c: Sort headers.
845         * f-lang.c: Sort headers.
846         * extension.h: Sort headers.
847         * extension.c: Sort headers.
848         * extension-priv.h: Sort headers.
849         * expprint.c: Sort headers.
850         * exec.h: Sort headers.
851         * exec.c: Sort headers.
852         * exceptions.c: Sort headers.
853         * event-top.c: Sort headers.
854         * event-loop.c: Sort headers.
855         * eval.c: Sort headers.
856         * elfread.c: Sort headers.
857         * dwarf2read.h: Sort headers.
858         * dwarf2read.c: Sort headers.
859         * dwarf2loc.c: Sort headers.
860         * dwarf2expr.h: Sort headers.
861         * dwarf2expr.c: Sort headers.
862         * dwarf2-frame.c: Sort headers.
863         * dwarf2-frame-tailcall.c: Sort headers.
864         * dwarf-index-write.h: Sort headers.
865         * dwarf-index-write.c: Sort headers.
866         * dwarf-index-common.c: Sort headers.
867         * dwarf-index-cache.h: Sort headers.
868         * dwarf-index-cache.c: Sort headers.
869         * dummy-frame.c: Sort headers.
870         * dtrace-probe.c: Sort headers.
871         * disasm.h: Sort headers.
872         * disasm.c: Sort headers.
873         * disasm-selftests.c: Sort headers.
874         * dictionary.c: Sort headers.
875         * dicos-tdep.c: Sort headers.
876         * demangle.c: Sort headers.
877         * dcache.h: Sort headers.
878         * dcache.c: Sort headers.
879         * darwin-nat.h: Sort headers.
880         * darwin-nat.c: Sort headers.
881         * darwin-nat-info.c: Sort headers.
882         * d-valprint.c: Sort headers.
883         * d-namespace.c: Sort headers.
884         * d-lang.c: Sort headers.
885         * ctf.c: Sort headers.
886         * csky-tdep.c: Sort headers.
887         * csky-linux-tdep.c: Sort headers.
888         * cris-tdep.c: Sort headers.
889         * cris-linux-tdep.c: Sort headers.
890         * cp-valprint.c: Sort headers.
891         * cp-support.c: Sort headers.
892         * cp-namespace.c: Sort headers.
893         * cp-abi.c: Sort headers.
894         * corelow.c: Sort headers.
895         * corefile.c: Sort headers.
896         * continuations.c: Sort headers.
897         * completer.h: Sort headers.
898         * completer.c: Sort headers.
899         * complaints.c: Sort headers.
900         * coffread.c: Sort headers.
901         * coff-pe-read.c: Sort headers.
902         * cli-out.h: Sort headers.
903         * cli-out.c: Sort headers.
904         * charset.c: Sort headers.
905         * c-varobj.c: Sort headers.
906         * c-valprint.c: Sort headers.
907         * c-typeprint.c: Sort headers.
908         * c-lang.c: Sort headers.
909         * buildsym.c: Sort headers.
910         * buildsym-legacy.c: Sort headers.
911         * build-id.h: Sort headers.
912         * build-id.c: Sort headers.
913         * btrace.c: Sort headers.
914         * bsd-uthread.c: Sort headers.
915         * breakpoint.h: Sort headers.
916         * breakpoint.c: Sort headers.
917         * break-catch-throw.c: Sort headers.
918         * break-catch-syscall.c: Sort headers.
919         * break-catch-sig.c: Sort headers.
920         * blockframe.c: Sort headers.
921         * block.c: Sort headers.
922         * bfin-tdep.c: Sort headers.
923         * bfin-linux-tdep.c: Sort headers.
924         * bfd-target.c: Sort headers.
925         * bcache.c: Sort headers.
926         * ax-general.c: Sort headers.
927         * ax-gdb.h: Sort headers.
928         * ax-gdb.c: Sort headers.
929         * avr-tdep.c: Sort headers.
930         * auxv.c: Sort headers.
931         * auto-load.c: Sort headers.
932         * arm-wince-tdep.c: Sort headers.
933         * arm-tdep.c: Sort headers.
934         * arm-symbian-tdep.c: Sort headers.
935         * arm-pikeos-tdep.c: Sort headers.
936         * arm-obsd-tdep.c: Sort headers.
937         * arm-nbsd-tdep.c: Sort headers.
938         * arm-nbsd-nat.c: Sort headers.
939         * arm-linux-tdep.c: Sort headers.
940         * arm-linux-nat.c: Sort headers.
941         * arm-fbsd-tdep.c: Sort headers.
942         * arm-fbsd-nat.c: Sort headers.
943         * arm-bsd-tdep.c: Sort headers.
944         * arch-utils.c: Sort headers.
945         * arc-tdep.c: Sort headers.
946         * arc-newlib-tdep.c: Sort headers.
947         * annotate.h: Sort headers.
948         * annotate.c: Sort headers.
949         * amd64-windows-tdep.c: Sort headers.
950         * amd64-windows-nat.c: Sort headers.
951         * amd64-tdep.c: Sort headers.
952         * amd64-sol2-tdep.c: Sort headers.
953         * amd64-obsd-tdep.c: Sort headers.
954         * amd64-obsd-nat.c: Sort headers.
955         * amd64-nbsd-tdep.c: Sort headers.
956         * amd64-nbsd-nat.c: Sort headers.
957         * amd64-nat.c: Sort headers.
958         * amd64-linux-tdep.c: Sort headers.
959         * amd64-linux-nat.c: Sort headers.
960         * amd64-fbsd-tdep.c: Sort headers.
961         * amd64-fbsd-nat.c: Sort headers.
962         * amd64-dicos-tdep.c: Sort headers.
963         * amd64-darwin-tdep.c: Sort headers.
964         * amd64-bsd-nat.c: Sort headers.
965         * alpha-tdep.c: Sort headers.
966         * alpha-obsd-tdep.c: Sort headers.
967         * alpha-nbsd-tdep.c: Sort headers.
968         * alpha-mdebug-tdep.c: Sort headers.
969         * alpha-linux-tdep.c: Sort headers.
970         * alpha-linux-nat.c: Sort headers.
971         * alpha-bsd-tdep.c: Sort headers.
972         * alpha-bsd-nat.c: Sort headers.
973         * aix-thread.c: Sort headers.
974         * agent.c: Sort headers.
975         * addrmap.c: Sort headers.
976         * ada-varobj.c: Sort headers.
977         * ada-valprint.c: Sort headers.
978         * ada-typeprint.c: Sort headers.
979         * ada-tasks.c: Sort headers.
980         * ada-lang.c: Sort headers.
981         * aarch64-tdep.c: Sort headers.
982         * aarch64-ravenscar-thread.c: Sort headers.
983         * aarch64-newlib-tdep.c: Sort headers.
984         * aarch64-linux-tdep.c: Sort headers.
985         * aarch64-linux-nat.c: Sort headers.
986         * aarch64-fbsd-tdep.c: Sort headers.
987         * aarch64-fbsd-nat.c: Sort headers.
988         * aarch32-linux-nat.c: Sort headers.
989
990 2019-04-04  Tom Tromey  <tom@tromey.com>
991
992         * varobj.c (varobj_create): Update.
993         * rust-exp.y (struct rust_parser) <update_innermost_block,
994         lookup_symbol>: New methods.
995         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
996         Rename.
997         (rust_parser::rust_lookup_type)
998         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
999         * printcmd.c (display_command, do_one_display): Update.
1000         * parser-defs.h (struct parser_state) <parser_state>: Add
1001         "tracker" parameter.
1002         (block_tracker): New member.
1003         (class innermost_block_tracker) <innermost_block_tracker>: Add
1004         "types" parameter.
1005         <reset>: Remove method.
1006         (innermost_block): Don't declare.
1007         (null_post_parser): Update.
1008         * parse.c (innermost_block): Remove global.
1009         (write_dollar_variable): Update.
1010         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
1011         Remove "tracker_types" parameter.
1012         (parse_expression): Add "tracker" parameter.
1013         (parse_expression_for_completion): Update.
1014         (null_post_parser): Add "tracker" parameter.
1015         * p-exp.y: Update rules.
1016         * m2-exp.y: Update rules.
1017         * language.h (struct language_defn) <la_post_parser>: Add
1018         "tracker" parameter.
1019         * go-exp.y: Update rules.
1020         * f-exp.y: Update rules.
1021         * expression.h (parse_expression, parse_exp_1): Add "tracker"
1022         parameter.
1023         * d-exp.y: Update rules.
1024         * c-exp.y: Update rules.
1025         * breakpoint.c (set_breakpoint_condition): Create an
1026         innermost_block_tracker.
1027         (watch_command_1): Likewise.
1028         * ada-lang.c (resolve): Add "tracker" parameter.
1029         (resolve_subexp): Likewise.
1030         * ada-exp.y (write_var_from_sym): Update.
1031
1032 2019-04-04  Tom Tromey  <tom@tromey.com>
1033
1034         * type-stack.h: New file.
1035         * type-stack.c: New file.
1036         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
1037         type-stack.h.
1038         (insert_into_type_stack, insert_type, push_type, push_type_int)
1039         (insert_type_address_space, pop_type, pop_type_int)
1040         (pop_typelist, pop_type_stack, append_type_stack)
1041         (push_type_stack, get_type_stack, push_typelist)
1042         (follow_type_instance_flags, follow_types): Don't declare.
1043         * parse.c (type_stack): Remove global.
1044         (parse_exp_in_context): Update.
1045         (insert_into_type_stack, insert_type, push_type, push_type_int)
1046         (insert_type_address_space, pop_type, pop_type_int)
1047         (pop_typelist, pop_type_stack, append_type_stack)
1048         (push_type_stack, get_type_stack, push_typelist)
1049         (follow_type_instance_flags, follow_types): Remove (moved to
1050         type-stack.c).
1051         * f-exp.y (type_stack): New global.
1052         Update rules.
1053         (push_kind_type, f_parse): Update.
1054         * d-exp.y (type_stack): New global.
1055         Update rules.
1056         (d_parse): Update.
1057         * c-exp.y (struct c_parse_state) <type_stack>: New member.
1058         Update rules.
1059         * Makefile.in (COMMON_SFILES): Add type-stack.c.
1060         (HFILES_NO_SRCDIR): Add type-stack.h.
1061
1062 2019-04-04  Tom Tromey  <tom@tromey.com>
1063
1064         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
1065         (rust_parser::convert_ast_to_expression, rust_parse)
1066         (rust_lex_test_completion, rust_lex_tests): Update.
1067         * parser-defs.h (struct expr_completion_state): New.
1068         (struct parser_state) <parser_state>: Add completion parameter.
1069         <mark_struct_expression, mark_completion_tag>: New methods.
1070         <parse_completion, m_completion_state>: New members.
1071         (prefixify_expression, null_post_parser): Update.
1072         (mark_struct_expression, mark_completion_tag): Don't declare.
1073         * parse.c (parse_completion, expout_last_struct)
1074         (expout_tag_completion_type, expout_completion_name): Remove
1075         globals.
1076         (parser_state::mark_struct_expression)
1077         (parser_state::mark_completion_tag): Now methods.
1078         (prefixify_expression): Add last_struct parameter.
1079         (prefixify_subexp): Likewise.
1080         (parse_exp_1): Update.
1081         (parse_exp_in_context): Add cstate parameter.  Update.
1082         (parse_expression_for_completion): Create an
1083         expr_completion_state.
1084         (null_post_parser): Add "completion" parameter.
1085         * p-exp.y: Update rules.
1086         (yylex): Update.
1087         * language.h (struct language_defn) <la_post_parser>: Add
1088         "completing" parameter.
1089         * go-exp.y: Update rules.
1090         (lex_one_token): Update.
1091         * expression.h (parse_completion): Don't declare.
1092         * d-exp.y: Update rules.
1093         (lex_one_token): Update rules.
1094         * c-exp.y: Update rules.
1095         (lex_one_token): Update.
1096         * ada-lang.c (resolve): Add "parse_completion" parameter.
1097         (resolve_subexp): Likewise.
1098         (ada_resolve_function): Likewise.
1099
1100 2019-04-04  Tom Tromey  <tom@tromey.com>
1101
1102         * parser-defs.h (struct parser_state) <start_arglist,
1103         end_arglist>: New methods.
1104         <arglist_len, m_funcall_chain>: New members.
1105         (arglist_len, start_arglist, end_arglist): Don't declare.
1106         * parse.c (arglist_len, funcall_chain): Remove global.
1107         (start_arglist, end_arglist): Remove functions.
1108         (parse_exp_in_context): Update.
1109         * p-exp.y: Update rules.
1110         * m2-exp.y: Update rules.
1111         * go-exp.y: Update rules.
1112         * f-exp.y: Update rules.
1113         * d-exp.y: Update rules.
1114         * c-exp.y: Update rules.
1115
1116 2019-04-04  Tom Tromey  <tom@tromey.com>
1117
1118         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
1119         lex_operator, push_back>: New methods.
1120         Update all rules.
1121         (rust_parser::lex_hex, lex_escape): Rename and update.
1122         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
1123         (rust_parser::lex_operator): Rename and update.
1124         (rust_parser::lex_number, rustyylex, rustyyerror)
1125         (rust_lex_test_init, rust_lex_test_sequence)
1126         (rust_lex_test_push_back, rust_lex_tests): Update.
1127         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
1128         parameter.
1129         <lexptr, prev_lexptr>: New members.
1130         (lexptr, prev_lexptr): Don't declare.
1131         * parse.c (lexptr, prev_lexptr): Remove globals.
1132         (parse_exp_in_context): Update.
1133         * p-exp.y (yylex, yyerror): Update.
1134         * m2-exp.y (parse_number, yylex, yyerror): Update.
1135         * go-exp.y (lex_one_token, yyerror): Update.
1136         * f-exp.y (match_string_literal, yylex, yyerror): Update.
1137         * d-exp.y (lex_one_token, yyerror): Update.
1138         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
1139         (lex_one_token, yyerror): Update.
1140         * ada-lex.l (YY_INPUT): Update.
1141         (rewind_to_char): Update.
1142         * ada-exp.y (yyerror): Update.
1143
1144 2019-04-04  Tom Tromey  <tom@tromey.com>
1145
1146         * rust-exp.y (rustyylex, rust_lex_tests): Update.
1147         * parser-defs.h (struct parser_state) <parser_state>: Add new
1148         parameter.
1149         <comma_terminates>: New member.
1150         (comma_terminates): Don't declare global.
1151         * parse.c (comma_terminates): Remove global.
1152         (parse_exp_in_context): Update.
1153         * p-exp.y (yylex): Update.
1154         * m2-exp.y (yylex): Update.
1155         * go-exp.y (lex_one_token): Update.
1156         * f-exp.y (yylex): Update.
1157         * d-exp.y (lex_one_token): Update.
1158         * c-exp.y (lex_one_token): Update.
1159         * ada-lex.l: Update.
1160
1161 2019-04-04  Tom Tromey  <tom@tromey.com>
1162
1163         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
1164         (rustyylex, rust_lex_test_init, rust_lex_test_one)
1165         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
1166         * parser-defs.h (paren_depth): Don't declare.
1167         * parse.c (paren_depth): Remove global.
1168         (parse_exp_in_context): Update.
1169         * p-exp.y (paren_depth): New global.
1170         (pascal_parse): Initialize it.
1171         * m2-exp.y (paren_depth): New global.
1172         (m2_parse): Initialize it.
1173         * go-exp.y (paren_depth): New global.
1174         (go_parse): Initialize it.
1175         * f-exp.y (paren_depth): New global.
1176         (f_parse): Initialize it.
1177         * d-exp.y (paren_depth): New global.
1178         (d_parse): Initialize it.
1179         * c-exp.y (paren_depth): New global.
1180         (c_parse): Initialize it.
1181         * ada-lex.l (paren_depth): New global.
1182         (lexer_init): Initialize it.
1183
1184 2019-04-04  Tom Tromey  <tom@tromey.com>
1185
1186         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
1187         (rust_parser::convert_ast_to_type)
1188         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1189         * parser-defs.h (struct parser_state) <parser_state>: Add
1190         parameters.  Initialize new members.
1191         <expression_context_block, expression_context_pc>: New members.
1192         * parse.c (expression_context_block, expression_context_pc):
1193         Remove globals.
1194         (parse_exp_in_context): Update.
1195         * p-exp.y: Update all rules.
1196         (yylex): Update.
1197         * m2-exp.y: Update all rules.
1198         (yylex): Update.
1199         * go-exp.y (yylex): Update.
1200         * f-exp.y (yylex): Update.
1201         * d-exp.y: Update all rules.
1202         (yylex): Update.
1203         * c-exp.y: Update all rules.
1204         (lex_one_token, classify_name, yylex, c_parse): Update.
1205         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
1206
1207 2019-04-04  Tom Tromey  <tom@tromey.com>
1208
1209         * gdbarch.h, gdbarch.c: Rebuild.
1210         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
1211         * stap-probe.h: 
1212         (struct stap_parse_info): Replace "parser_state" with
1213         "expr_builder".
1214         * parser-defs.h (struct expr_builder): Rename from "parser_state".
1215         (parser_state): New class.
1216         * parse.c (expr_builder): Rename.
1217         (expr_builder::release): Rename.
1218         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
1219         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
1220         (write_exp_elt_longcst, write_exp_elt_floatcst)
1221         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
1222         (write_exp_string_vector, write_exp_bitstring)
1223         (write_exp_msymbol, mark_struct_expression)
1224         (write_dollar_variable)
1225         (insert_type_address_space, increase_expout_size): Replace
1226         "parser_state" with "expr_builder".
1227         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
1228         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
1229         "parser_state" with "expr_builder".
1230
1231 2019-04-04  Tom Tromey  <tom@tromey.com>
1232
1233         * rust-exp.y: Replace "parse_language" with method call.
1234         * p-exp.y: 
1235         (yylex): Replace "parse_language" with method call.
1236         * m2-exp.y: 
1237         (yylex): Replace "parse_language" with method call.
1238         * go-exp.y (classify_name): Replace "parse_language" with method
1239         call.
1240         * f-exp.y (yylex): Replace "parse_language" with method call.
1241         * d-exp.y (lex_one_token): Replace "parse_language" with method
1242         call.
1243         * c-exp.y: 
1244         (lex_one_token, classify_name, yylex): Replace "parse_language"
1245         with method call.
1246         * ada-exp.y (find_primitive_type, type_char)
1247         (type_system_address): Replace "parse_language" with method call.
1248
1249 2019-04-04  Tom Tromey  <tom@tromey.com>
1250
1251         * rust-exp.y: Replace "parse_gdbarch" with method call.
1252         * parse.c (write_dollar_variable, insert_type_address_space):
1253         Replace "parse_gdbarch" with method call.
1254         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
1255         call.
1256         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
1257         call.
1258         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
1259         "parse_gdbarch" with method call.
1260         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
1261         with method call.
1262         * f-exp.y (parse_type, parse_f_type, yylex): Replace
1263         "parse_gdbarch" with method call.
1264         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
1265         "parse_gdbarch" with method call.
1266         * c-exp.y (parse_type, parse_number, classify_name): Replace
1267         "parse_gdbarch" with method call.
1268         * ada-lex.l: Replace "parse_gdbarch" with method call.
1269         * ada-exp.y (parse_type, find_primitive_type, type_char)
1270         (type_system_address): Replace "parse_gdbarch" with method call.
1271
1272 2019-04-04  Tom Tromey  <tom@tromey.com>
1273
1274         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
1275         * stap-probe.c (stap_parse_argument): Update.
1276         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
1277         initial_size parameter.
1278         * rust-exp.y (rust_lex_tests): Update.
1279         * parse.c (parser_state): Update.
1280         (parse_exp_in_context): Update.
1281         * parser-defs.h (struct parser_state) <parser_state>: Remove
1282         "initial_size" parameter.
1283
1284 2019-04-04  Tom Tromey  <tom@tromey.com>
1285
1286         * parser-defs.h (increase_expout_size): Don't declare.
1287         * parse.c (increase_expout_size): Now static.
1288
1289 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
1290
1291         * gnu-nat.c (gnu_nat_target::wait): Fix
1292         target_waitstatus_to_string call.
1293
1294 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1295
1296         * eval.c (evaluate_subexp_standard): Handle internal functions
1297         during Fortran function call handling.
1298
1299 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1300
1301         * NEWS: Mention new internal functions.
1302         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
1303         (read_base_type): Use dwarf2_init_complex_target_type.
1304         * value.c (creal_internal_fn): New function.
1305         (cimag_internal_fn): New function.
1306         (_initialize_values): Register new internal functions.
1307
1308 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1309
1310         * infrun.c (stop_all_threads): If debug_infrun, always
1311         trace the wait status after wait_one, using
1312         target_waitstatus_to_string and target_pid_to_str.
1313         (handle_inferior_event): Replace various trace of
1314         wait status kind by a single trace.
1315         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
1316         wait status kind image by target_waitstatus_to_string.
1317         * target/waitstatus.c (target_waitstatus_to_string): Fix
1318         obsolete comment.
1319
1320 2019-04-01  Tom Tromey  <tromey@adacore.com>
1321
1322         PR symtab/23331:
1323         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
1324
1325 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
1326             Pedro Alves  <palves@redhat.com>
1327
1328         * top.c (quit_force): Call 'finalize_values'.
1329         * value.c (finalize_values): New function.
1330         * value.h (finalize_values): Declare.
1331
1332 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
1333
1334         * NEWS: Announce $_gdb_major and $_gdb_minor.
1335
1336         * top.c (init_gdb_version_vars): New function.
1337         (gdb_init): Call init_gdb_version_vars.
1338
1339 2019-03-29  Tom Tromey  <tromey@adacore.com>
1340
1341         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
1342         help text.  Remove dead code.
1343
1344 2019-03-29  Keith Seitz  <keiths@redhat.com>
1345
1346         From Siddhesh Poyarekar:
1347         * f-lang.h (f77_get_upperbound): Return LONGEST.
1348         (f77_get_lowerbound): Likewise.
1349         * f-typeprint.c (f_type_print_varspec_suffix): Expand
1350         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
1351         print them.
1352         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
1353         plongest to format print it.
1354         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
1355         (f77_get_upperbound): Likewise.
1356         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
1357         LOWER_BOUND to LONGEST.
1358         (f77_create_arrayprint_offset_tbl): Likewise.
1359
1360 2019-03-29  Keith Seitz  <keiths@redhat.com>
1361
1362         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
1363         %s/pulongest for TYPE_LENGTH instead of %d in format
1364         strings.
1365         * ada-typerint.c (ada_print_type): Likewise.
1366         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
1367         * compile/compile-c-support.c (generate_register_struct): Likewise.
1368         * gdbtypes.c (recursive_dump_type): Likewise.
1369         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
1370         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
1371         instead of %d in format strings.
1372         * riscv-tdep.c (riscv_type_alignment): Cast second argument
1373         to std::min to ULONGEST.
1374         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
1375         instead of %d in format strings.
1376         * tracepoint.c (info_scope_command): Likewise.
1377         * typeprint.c (print_offset_data::update)
1378         (print_offset_data::finish): Likewise.
1379         * xtensa-tdep.c (xtensa_store_return_value)
1380         (xtensa_push_dummy_call): Likewise.
1381
1382 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
1383
1384         * windows-nat.c (display_selector): Fixed format specifications
1385         for 64-bit Cygwin.
1386
1387 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1388
1389         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
1390
1391 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
1392
1393         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
1394         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
1395         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
1396         (nios2_linux_init_abi): Install it.
1397
1398 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1399
1400         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
1401
1402 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1403
1404         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
1405
1406 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1407             Tom Tromey  <tromey@adacore.com>
1408
1409         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
1410
1411 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
1412
1413         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
1414         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
1415         method to compute the bounds of range types. Also print "[evaluated]"
1416         if the bounds' values come from a dynamic evaluation.
1417
1418 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1419
1420         * cp-valprint.c (cp_print_value_fields): Don't print trailing
1421         whitespace when pretty printing is on.
1422
1423 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1424
1425         * ppc-linux-nat.c: Add include.
1426
1427 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1428
1429         * NEWS: Mention AArch64 Pointer Authentication.
1430
1431 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1432
1433         * arm-linux-nat.c: Add include.
1434
1435 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
1436
1437         * source-cache.c (source_cache::get_source_lines): Re-read
1438         fullname after calling open_source_file.
1439
1440 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
1441
1442         * NEWS: Mention TLS support for FreeBSD.
1443
1444 2019-03-25  Tom Tromey  <tromey@adacore.com>
1445
1446         * minsyms.c (BUNCH_SIZE): Update comment.
1447         (~minimal_symbol_reader): Remove old comment.
1448         (compact_minimal_symbols): Update comment.
1449         (minimal_symbol_reader::install): Remove old comment.  Update
1450         other comments.
1451
1452 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1453
1454         * s390-linux-nat.c: Add include.
1455
1456 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1457
1458         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1459         Call linux_get_hwcap.
1460         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
1461         Likewise.
1462         (aarch64_linux_get_hwcap): Remove function.
1463         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
1464         declaration.
1465         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
1466         linux_get_hwcap.
1467         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1468         * linux-tdep.c (linux_get_hwcap): Add function.
1469         (linux_get_hwcap2): Likewise.
1470         * linux-tdep.h (linux_get_hwcap): Add declaration.
1471         (linux_get_hwcap2): Likewise.
1472         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
1473         (ppc_linux_get_hwcap2): Likewise.
1474         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
1475         linux_get_hwcap.
1476         (ppc_linux_nat_target::insert_watchpoint): Likewise.
1477         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
1478         (ppc_linux_nat_target::read_description): Likewise.
1479         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
1480         * s390-linux-nat.c: Likewise.
1481         * s390-linux-tdep.c (s390_core_read_description): Likewise.
1482
1483 2019-03-24  Tom Tromey  <tom@tromey.com>
1484
1485         * ada-lang.c (standard_lookup): Simplify initialization.
1486         (ada_lookup_symbol_nonlocal): Simplify return.
1487         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
1488         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
1489         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
1490         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
1491         initialization.
1492         * solib.c (solib_global_lookup): Simplify.
1493         * symtab.c (null_block_symbol): Remove.
1494         (symbol_cache_lookup): Simplify returns.
1495         (lookup_language_this): Simplify returns.
1496         (lookup_symbol_aux): Simplify return.
1497         (lookup_local_symbol): Simplify returns.
1498         (lookup_global_symbol_from_objfile): Simplify return.
1499         (lookup_symbol_in_objfile_symtabs)
1500         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
1501         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
1502         (lookup_static_symbol, lookup_global_symbol): Simplify return.
1503         * cp-namespace.c (cp_lookup_bare_symbol)
1504         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
1505         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
1506         (cp_lookup_nested_symbol): Don't use null_block_symbol.
1507         (cp_lookup_symbol_via_imports): Simplify initialization.
1508         (find_symbol_in_baseclass): Likewise.
1509         * symtab.h (null_block_symbol): Remove.
1510         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
1511         (d_lookup_nested_symbol, d_lookup_symbol_imports)
1512         (d_lookup_symbol_module): Likewise.
1513         (find_symbol_in_baseclass): Simplify initialization.
1514
1515 2019-03-24  Tom Tromey  <tom@tromey.com>
1516
1517         * expression.h: Don't include symtab.h.
1518         (struct block): Forward declare.
1519
1520 2019-03-24  Tom Tromey  <tom@tromey.com>
1521
1522         * c-exp.y (typebase): Remove casts.
1523         * gdbtypes.c (lookup_unsigned_typename, )
1524         (lookup_signed_typename): Remove cast.
1525         * eval.c (parse_to_comma_and_eval): Remove cast.
1526         * parse.c (write_dollar_variable): Remove cast.
1527         * block.h (struct block) <superblock>: Now const.
1528         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
1529         * psymtab.c (psym_map_matching_symbols): Make "block" const.
1530         (map_block): Make "block" const.
1531         * symfile.h (struct quick_symbol_functions)
1532         <map_matching_symbols>: Constify block argument to "callback".
1533         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
1534         const.
1535         (find_pc_sect_compunit_symtab): Make "b" const.
1536         (find_symbol_at_address): Likewise.
1537         (search_symbols): Likewise.
1538         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
1539         (dw2_debug_names_lookup_symbol): Likewise.
1540         (dw2_map_matching_symbols): Update.
1541         * p-valprint.c (pascal_val_print): Remove "block".
1542         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
1543         (aux_add_nonlocal_symbols): Make "block" const.
1544         (resolve_subexp): Remove cast.
1545         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
1546         const.
1547         (iterate_over_file_blocks): Likewise.
1548         * f-exp.y (%union) <bval>: Remove.
1549         * coffread.c (patch_opaque_types): Make "b" const.
1550         * spu-tdep.c (spu_catch_start): Make "block" const.
1551         * c-valprint.c (print_unpacked_pointer): Remove "block".
1552         * symmisc.c (dump_symtab_1): Make "b" const.
1553         (block_depth): Make "block" const.
1554         * d-exp.y (%union) <bval>: Remove.
1555         * cp-support.h (cp_lookup_rtti_type): Update.
1556         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
1557         * psymtab.c (psym_lookup_symbol): Make "block" const.
1558         (maintenance_check_psymtabs): Make "b" const.
1559         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
1560         (enumerate_locals, enumerate_args): Update.
1561         * python/py-symtab.c (stpy_global_block): Make "block" const.
1562         (stpy_static_block): Likewise.
1563         * inline-frame.c (block_starting_point_at): Make "new_block"
1564         const.
1565         * block.c (find_block_in_blockvector): Make return type const.
1566         (blockvector_for_pc_sect): Make "b" const.
1567         (find_block_in_blockvector): Make "b" const.
1568
1569 2019-03-23  Tom Tromey  <tom@tromey.com>
1570
1571         * varobj.c (varobj_create): Update.
1572         * symfile.c (clear_symtab_users): Don't reset innermost_block.
1573         * printcmd.c (display_command, do_one_display): Don't reset
1574         innermost_block.
1575         * parser-defs.h (enum innermost_block_tracker_type): Move to
1576         expression.h.
1577         (innermost_block): Update comment.
1578         * parse.c (parse_exp_1): Add tracker_types parameter.
1579         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
1580         tracker_types parameter.  Reset innermost_block.
1581         (parse_exp_in_context): Remove.
1582         (parse_expression_for_completion): Update.
1583         * objfiles.c (~objfile): Don't reset expression_context_block or
1584         innermost_block.
1585         * expression.h (enum innermost_block_tracker_type): Move from
1586         parser-defs.h.
1587         (parse_exp_1): Add tracker_types parameter.
1588         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
1589         reset innermost_block.
1590
1591 2019-03-23  Tom Tromey  <tom@tromey.com>
1592
1593         * objfiles.h: Include bcache.h.
1594
1595 2019-03-23  Tom Tromey  <tom@tromey.com>
1596
1597         * linespec.c (get_current_search_block): Use
1598         scoped_restore_current_language.
1599         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
1600
1601 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1602             Jiong Wang  <jiong.wang@arm.com>
1603
1604         * aarch64-linux-tdep.c
1605         (aarch64_linux_iterate_over_regset_sections): Check for pauth
1606         section.
1607         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
1608
1609 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1610             Jiong Wang  <jiong.wang@arm.com>
1611
1612         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
1613         instructions.
1614         (aarch64_analyze_prologue_test): Add PACIASP test.
1615         (aarch64_prologue_prev_register): Unmask PC value.
1616
1617 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1618             Jiong Wang  <jiong.wang@arm.com>
1619
1620         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
1621         (aarch64_dwarf2_prev_register): Unmask PC value.
1622         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
1623         (aarch64_execute_dwarf_cfa_vendor_op): Check for
1624         DW_CFA_AARCH64_negate_ra_state.
1625         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
1626
1627 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1628             Jiong Wang  <jiong.wang@arm.com>
1629
1630         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
1631         registers.
1632         (aarch64_pseudo_register_name): Likewise.
1633         (aarch64_pseudo_register_type): Likewise.
1634         (aarch64_pseudo_register_reggroup_p): Likewise.
1635         (aarch64_gdbarch_init): Add pauth registers.
1636         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
1637         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
1638         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
1639         (struct gdbarch_tdep): Add regnum for ra_state.
1640
1641 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1642             Jiong Wang  <jiong.wang@arm.com>
1643
1644         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
1645
1646 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1647             Jiong Wang  <jiong.wang@arm.com>
1648
1649         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
1650         function.
1651         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
1652         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
1653         (aarch64_gdbarch_init): Add puth registers.
1654         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
1655         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
1656         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
1657
1658 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1659             Jiong Wang  <jiong.wang@arm.com>
1660
1661         * aarch64-linux-nat.c
1662         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
1663         * aarch64-linux-tdep.c
1664         (aarch64_linux_core_read_description): Likewise.
1665         (aarch64_linux_get_hwcap): New function.
1666         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
1667         (aarch64_linux_get_hwcap): New declaration.
1668
1669 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1670             Jiong Wang  <jiong.wang@arm.com>
1671
1672         * aarch64-linux-nat.c
1673         (aarch64_linux_nat_target::read_description): Add pauth param.
1674         * aarch64-linux-tdep.c
1675         (aarch64_linux_core_read_description): Likewise.
1676         * aarch64-tdep.c (struct target_desc): Add in pauth.
1677         (aarch64_read_description): Add pauth param.
1678         (aarch64_gdbarch_init): Likewise.
1679         * aarch64-tdep.h (aarch64_read_description): Likewise.
1680         * arch/aarch64.c (aarch64_create_target_description): Likewise.
1681         * arch/aarch64.h (aarch64_create_target_description): Likewise.
1682         * features/Makefile: Add new files.
1683         * features/aarch64-pauth.c: New file.
1684         * features/aarch64-pauth.xml: New file.
1685
1686 2019-03-20  Tom Tromey  <tromey@adacore.com>
1687
1688         * infrun.c (handle_inferior_event): Rename from
1689         handle_inferior_event_1.  Create a scoped_value_mark.
1690         (handle_inferior_event): Remove.
1691
1692 2019-03-19  Tom Tromey  <tromey@adacore.com>
1693
1694         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
1695         * infrun.h (print_stop_event): Add "displays" parameter.
1696         * infrun.c (print_stop_event): Add "displays" parameter.
1697
1698 2019-03-19  Pedro Alves  <palves@redhat.com>
1699
1700         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
1701         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
1702         to -1.  Fix TABs vs spaces.
1703         (tui_ui_out::tui_ui_out): Don't initialize fields here.
1704         * tui/tui-out.h (tui_ui_out) Add intro comments.
1705         <m_line, m_start_of_line>: In-class initialize, and add describing
1706         comment.
1707
1708 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
1709
1710         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
1711         variable names.
1712         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
1713
1714 2019-03-18  Pedro Alves  <palves@redhat.com>
1715             Eli Zaretskii <eliz@gnu.org>
1716
1717         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
1718         m_line and m_start_of_line.
1719
1720 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
1721
1722         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
1723         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
1724         it returns a newline.  This fixes a regression in TU mode, whereby
1725         the next line is output on the same screen line as the user input.
1726
1727 2019-03-18  Tom Tromey  <tromey@adacore.com>
1728
1729         * minsyms.c (minimal_symbol_reader::install): Remove call to
1730         obstack_blank.
1731
1732 2019-03-18  Pedro Alves  <palves@redhat.com>
1733
1734         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
1735         New globals.
1736         (apply_style): New, factored out from ...
1737         (apply_ansi_escape): ... this.  Handle reverse video mode.
1738         (tui_set_reverse_mode): New function.
1739         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
1740         * tui/tui-winsource.c (tui_show_source_line): Use
1741         tui_set_reverse_mode instead of setting A_STANDOUT.
1742         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
1743         New setter methods.
1744
1745 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
1746
1747         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
1748         Handle tabs.
1749
1750 2019-03-18  Tom Tromey  <tromey@adacore.com>
1751
1752         * ada-lang.c (empty_array): Add "high" parameter.
1753         (ada_evaluate_subexp): Update.
1754
1755 2019-03-17  Sergei Trofimovich <siarheit@google.com>
1756
1757         * unittests/string_view-selftests.c: Define
1758         _initialize_string_view_selftests unconditionally.
1759
1760 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1761
1762         PR gdb/24350
1763         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
1764
1765 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1766
1767         PR gdb/24351
1768         * windows-nat.c (display_selector): Fix format specifiers.
1769
1770 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
1771
1772         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
1773         tui_refill_source_window instead of tui_refresh_win, to update the
1774         current execution line.  This fixes redisplay of the current line
1775         when stepping through the code with "next" or "step".
1776
1777 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1778
1779         * source-cache.c (source_cache::get_source_lines): Call
1780         find_source_lines to initialize s->nlines.  This fixes vertical
1781         scrolling of TUI source window when the DOWN arrow is pressed.
1782
1783 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1784
1785         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
1786         linux-thread-db.c (_initialize_thread_db): Likewise.
1787
1788 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1789
1790         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
1791         wclrtoeol in tui_show_source_line".  This reverts changes made in
1792         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
1793
1794 2019-03-15  Tom Tromey  <tom@tromey.com>
1795
1796         * symtab.h (struct minimal_symbol): Derive from
1797         general_symbol_info.
1798         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
1799         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
1800         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
1801         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
1802         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
1803         (MSYMBOL_SEARCH_NAME): Update.
1804         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
1805         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
1806         * minsyms.c (minimal_symbol_reader::record_full): Update.
1807
1808 2019-03-15  Tom Tromey  <tom@tromey.com>
1809
1810         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
1811
1812 2019-03-15  Tom Tromey  <tom@tromey.com>
1813
1814         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
1815         unique_xmalloc_ptr.
1816         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
1817         Update.
1818         * minsyms.c (lookup_minimal_symbol_by_pc_section)
1819         (build_minimal_symbol_hash_tables)
1820         (minimal_symbol_reader::install): Update.
1821
1822 2019-03-15  Tom Tromey  <tom@tromey.com>
1823
1824         * symtab.c (create_demangled_names_hash): Update.
1825         (symbol_set_names): Update.
1826         * objfiles.h (struct objfile_per_bfd_storage)
1827         <demangled_names_hash>: Now an htab_up.
1828         * objfiles.c (objfile_per_bfd_storage): Simplify.
1829
1830 2019-03-15  Tom Tromey  <tom@tromey.com>
1831
1832         * objfiles.h (struct objfile_per_bfd_storage): Declare
1833         destructor.
1834         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
1835         New.
1836         (get_objfile_bfd_data): Use new.  Don't initialize
1837         language_of_main.
1838         (free_objfile_per_bfd_storage): Remove.
1839         (objfile_bfd_data_free, objfile::~objfile): Use delete.
1840
1841 2019-03-15  Tom Tromey  <tom@tromey.com>
1842
1843         * symfile.c (reread_symbols): Update.
1844         * objfiles.c (objfile::objfile): Update.
1845         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
1846         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
1847         comment.
1848         (minimal_symbol_reader::install): Update.
1849         (terminate_minimal_symbol_table): Remove.
1850         * jit.c (jit_object_close_impl): Update.
1851
1852 2019-03-15  Tom Tromey  <tom@tromey.com>
1853
1854         * minsyms.c (minimal_symbol_reader::record_full): Remove some
1855         initializations.
1856
1857 2019-03-15  Tom Tromey  <tom@tromey.com>
1858
1859         * objfiles.h (struct objfile_per_bfd_storage)
1860         <demangled_hash_languages>: Now a bitset.
1861         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
1862         (lookup_minimal_symbol): Update.
1863
1864 2019-03-15  Tom Tromey  <tom@tromey.com>
1865
1866         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
1867         Don't return the symbol.
1868         * coffread.c (record_minimal_symbol): Use record_full.
1869
1870 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
1871
1872         The MS-Windows port of ncurses fails to switch to a color pair if
1873         one or both of the colors are the implicit default colors.  This
1874         change records the default colors when TUI is initialized, and
1875         then specifies them explicitly when a color pair uses the default
1876         colors.  This allows color styling in TUI mode on MS-Windows.
1877
1878         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
1879         ncurses_norm_attr.
1880         (tui_initialize_io) [__MINGW32__]: Record the default terminal
1881         colors in ncurses_norm_attr.
1882         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
1883         "none", replace it with the default color recorded in
1884         ncurses_norm_attr.
1885
1886 2019-03-14  Tom Tromey  <tromey@adacore.com>
1887
1888         * source-cache.h (class source_cache) <get_source_lines>: Return
1889         std::string.
1890         * source-cache.c (source_cache::extract_lines): Handle case where
1891         first_pos==npos.  Return std::string.
1892         (source_cache::get_source_lines): Update.
1893
1894 2019-03-14  Tom Tromey  <tromey@adacore.com>
1895
1896         * NEWS: Add item for "style sources" commands.
1897         * source-cache.c (source_cache::get_source_lines): Check
1898         source_styling.
1899         * cli/cli-style.c (source_styling): New global.
1900         (_initialize_cli_style): Add "style sources" commands.
1901         (show_style_sources): New function.
1902         * cli/cli-style.h (source_styling): Declare.
1903
1904 2019-03-14  Pedro Alves  <palves@redhat.com>
1905             Tom Tromey  <tromey@adacore.com>
1906
1907         * tui/tui-winsource.h (tui_refill_source_window): Declare.
1908         * tui/tui-winsource.c (tui_refill_source_window): New function,
1909         from...
1910         (tui_horizontal_source_scroll): ... here.  Move some logic.
1911         * cli/cli-style.c (set_style_enabled): Notify new observable.
1912         * tui/tui-hooks.c (tui_redisplay_source): New function.
1913         (tui_attach_detach_observers): Attach or detach
1914         tui_redisplay_source.
1915         * observable.h (source_styling_changed): New observable.
1916         * observable.c: Define source_styling_changed observable.
1917
1918 2019-03-13  Tom Tromey  <tromey@adacore.com>
1919
1920         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
1921         (i386_gnu_nat_target::store_registers): Update.
1922         * target-debug.h (target_debug_print_std_string): New macro.
1923         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1924         * windows-tdep.c (display_one_tib): Update.
1925         * tui/tui-stack.c (tui_make_status_line): Update.
1926         * top.c (print_inferior_quit_action): Update.
1927         * thread.c (thr_try_catch_cmd): Update.
1928         (add_thread_with_info): Update.
1929         (thread_target_id_str): Update.
1930         (thr_try_catch_cmd): Update.
1931         (thread_command): Update.
1932         (thread_find_command): Update.
1933         * record-btrace.c (record_btrace_target::info_record)
1934         (record_btrace_resume_thread, record_btrace_target::resume)
1935         (record_btrace_cancel_resume, record_btrace_step_thread)
1936         (record_btrace_target::wait, record_btrace_target::wait)
1937         (record_btrace_target::wait, record_btrace_target::stop): Update.
1938         * progspace.c (print_program_space): Update.
1939         * process-stratum-target.c
1940         (process_stratum_target::thread_address_space): Update.
1941         * linux-fork.c (linux_fork_mourn_inferior)
1942         (detach_checkpoint_command, info_checkpoints_command)
1943         (linux_fork_context): Update.
1944         (linux_fork_detach): Update.
1945         (class scoped_switch_fork_info): Update.
1946         (delete_checkpoint_command): Update.
1947         * infrun.c (follow_fork_inferior): Update.
1948         (follow_fork_inferior): Update.
1949         (proceed_after_vfork_done): Update.
1950         (handle_vfork_child_exec_or_exit): Update.
1951         (follow_exec): Update.
1952         (displaced_step_prepare_throw): Update.
1953         (displaced_step_restore): Update.
1954         (start_step_over): Update.
1955         (resume_1): Update.
1956         (clear_proceed_status_thread): Update.
1957         (proceed): Update.
1958         (print_target_wait_results): Update.
1959         (do_target_wait): Update.
1960         (context_switch): Update.
1961         (stop_all_threads): Update.
1962         (restart_threads): Update.
1963         (finish_step_over): Update.
1964         (handle_signal_stop): Update.
1965         (switch_back_to_stepped_thread): Update.
1966         (keep_going_pass_signal): Update.
1967         (print_exited_reason): Update.
1968         (normal_stop): Update.
1969         * inferior.c (inferior_pid_to_str): Change return type.
1970         (print_selected_inferior): Update.
1971         (add_inferior): Update.
1972         (detach_inferior): Update.
1973         * dummy-frame.c (fprint_dummy_frames): Update.
1974         * dcache.c (dcache_info_1): Update.
1975         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
1976         (btrace_fetch, btrace_clear): Update.
1977         * linux-tdep.c (linux_core_pid_to_str): Change return type.
1978         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
1979         type.
1980         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
1981         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
1982         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
1983         * gdbarch.c, gdbarch.h: Rebuild.
1984         * gdbarch.sh (core_pid_to_str): Change return type.
1985         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
1986         return type.
1987         (windows_nat_target::pid_to_str): Change return type.
1988         (windows_delete_thread): Update.
1989         (windows_nat_target::attach): Update.
1990         (windows_nat_target::files_info): Update.
1991         * target-delegates.c: Rebuild.
1992         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
1993         return type.
1994         (sol_thread_target::pid_to_str): Change return type.
1995         * remote.c (class remote_target) <pid_to_str>: Change return
1996         type.
1997         (remote_target::pid_to_str): Change return type.
1998         (extended_remote_target::attach, remote_target::remote_stop_ns)
1999         (remote_target::remote_notif_remove_queued_reply)
2000         (remote_target::push_stop_reply, remote_target::disable_btrace):
2001         Update.
2002         (extended_remote_target::attach): Update.
2003         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
2004         type.
2005         (gdbsim_target::pid_to_str): Change return type.
2006         * ravenscar-thread.c (struct ravenscar_thread_target)
2007         <pid_to_str>: Change return type.
2008         (ravenscar_thread_target::pid_to_str): Change return type.
2009         * procfs.c (class procfs_target) <pid_to_str>: Change return
2010         type.
2011         (procfs_target::pid_to_str): Change return type.
2012         (procfs_target::attach): Update.
2013         (procfs_target::detach): Update.
2014         (procfs_target::fetch_registers): Update.
2015         (procfs_target::store_registers): Update.
2016         (procfs_target::wait): Update.
2017         (procfs_target::files_info): Update.
2018         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
2019         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
2020         return type.
2021         (nto_procfs_target::pid_to_str): Change return type.
2022         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
2023         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
2024         return type.
2025         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
2026         (exit_lwp): Update.
2027         (attach_proc_task_lwp_callback, get_detach_signal)
2028         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
2029         (linux_nat_target::resume, wait_lwp, stop_callback)
2030         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
2031         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
2032         (linux_nat_wait_1, resume_stopped_resumed_lwps)
2033         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
2034         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
2035         type.
2036         (inf_ptrace_target::attach): Update.
2037         (inf_ptrace_target::files_info): Update.
2038         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
2039         type.
2040         (go32_nat_target::pid_to_str): Change return type.
2041         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
2042         (gnu_nat_target::wait): Update.
2043         (gnu_nat_target::wait): Update.
2044         (gnu_nat_target::resume): Update.
2045         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
2046         (fbsd_nat_target::wait): Update.
2047         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
2048         type.
2049         (darwin_nat_target::attach): Update.
2050         * corelow.c (class core_target) <pid_to_str>: Change return type.
2051         (core_target::pid_to_str): Change return type.
2052         * target.c (normal_pid_to_str): Change return type.
2053         (default_pid_to_str): Likewise.
2054         (target_pid_to_str): Change return type.
2055         (target_translate_tls_address): Update.
2056         (target_announce_detach): Update.
2057         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
2058         return type.
2059         (bsd_uthread_target::pid_to_str): Change return type.
2060         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
2061         type.
2062         (bsd_kvm_target::pid_to_str): Change return type.
2063         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
2064         return type.
2065         (aix_thread_target::pid_to_str): Change return type.
2066         * target.h (struct target_ops) <pid_to_str>: Change return type.
2067         (target_pid_to_str, normal_pid_to_str): Likewise.
2068         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
2069         type.
2070         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
2071         type.
2072         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
2073         return type.
2074         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
2075         type.
2076         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
2077         type.
2078         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
2079         return type.
2080
2081 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
2082
2083         * NEWS: Mention that the new default MI version is 3.  Mention
2084         changes to the output of commands and events that deal with
2085         multi-location breakpoints.
2086         * breakpoint.c: Include "mi/mi-out.h".
2087         (print_one_breakpoint): Change output syntax if using MI version
2088         >= 3.
2089         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
2090         New.
2091         (mi_multi_location_breakpoint_output_fixed): New.
2092         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
2093         (mi_cmd_fix_multi_location_breakpoint_output): New.
2094         (mi_multi_location_breakpoint_output_fixed): New.
2095         * mi/mi-cmds.c (mi_cmds): Register command
2096         -fix-multi-location-breakpoint-output.
2097         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
2098         interpreter "mi".
2099
2100 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
2101
2102         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
2103         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
2104         instantiate mi_ui_out based on interpreter name.
2105         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
2106         * mi/mi-main.c (mi_load_progress): Likewise.
2107
2108 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2109
2110         * NEWS: Combine separate "New targets" sections for 8.3.
2111
2112 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2113
2114         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
2115         (ppcfbsd_init_abi): Install gdbarch
2116         "fetch_tls_load_module_address" and "get_thread_local_address"
2117         methods.
2118
2119 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2120
2121         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
2122         (riscv_fbsd_init_abi): Install gdbarch
2123         "fetch_tls_load_module_address" and "get_thread_local_address"
2124         methods.
2125
2126 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2127
2128         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
2129         (i386fbsd_init_abi): Install gdbarch
2130         "fetch_tls_load_module_address" and "get_thread_local_address"
2131         methods.
2132
2133 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2134
2135         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
2136         (amd64fbsd_init_abi): Install gdbarch
2137         "fetch_tls_load_module_address" and "get_thread_local_address"
2138         methods.
2139
2140 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2141
2142         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
2143         (struct fbsd_pspace_data): New type.
2144         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
2145         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
2146         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
2147         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
2148         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
2149
2150 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2151
2152         * gdbtypes.c (lookup_struct_elt): New function.
2153         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
2154         * gdbtypes.h (struct struct_elt): New type.
2155         (lookup_struct_elt): New prototype.
2156
2157 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2158
2159         * gdbtypes.c (lookup_struct_elt_type): Update comment and
2160         remove disabled code block.
2161
2162 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2163
2164         * gdbarch.sh (get_thread_local_address): New method.
2165         * gdbarch.h, gdbarch.c: Regenerate.
2166         * target.c (target_translate_tls_address): Use
2167         gdbarch_get_thread_local_address if present instead of
2168         target::get_thread_local_address.
2169
2170 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2171
2172         * target.h (target::get_thread_local_address): Update comment.
2173
2174 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2175
2176         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
2177         objfile->separate_debug_objfile_backlink if not NULL.
2178
2179 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2180
2181         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
2182         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
2183         (amd64bsd_store_inferior_registers): Likewise.
2184         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2185         Enable segment base registers.
2186         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
2187         PT_GETFSBASE and PT_GETGSBASE.
2188         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
2189         PT_SETGSBASE.
2190         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
2191         segment base registers.
2192         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2193
2194 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2195
2196         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2197         Update calls to i386_target_description to add 'segments'
2198         parameter.
2199         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
2200         add segment base registers.
2201         * arch/i386.c (i386_create_target_description): Add 'segments'
2202         parameter to enable segment base registers.
2203         * arch/i386.h (i386_create_target_description): Likewise.
2204         * features/i386/32bit-segments.xml: New file.
2205         * features/i386/32bit-segments.c: Generate.
2206         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
2207         call to i386_target_description to add 'segments' parameter.
2208         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2209         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
2210         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
2211         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
2212         if feature is present.
2213         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
2214         Add 'segments' parameter to call to i386_target_description.
2215         (i386_target_description): Add 'segments' parameter to enable
2216         segment base registers.
2217         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
2218         to call to i386_target_description.
2219         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
2220         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
2221         Define I386_NUM_REGS.
2222         (i386_target_description): Add 'segments' parameter to enable
2223         segment base registers.
2224
2225 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
2226
2227         PR/24325
2228         * source-cache.c: #undef open and close, to avoid unresolved
2229         externals during linking.
2230
2231 2019-03-12  Tom Tromey  <tromey@adacore.com>
2232
2233         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
2234         const.  Add initializers.
2235         (_initialize_remote): Don't initialize ptid globals.
2236
2237 2019-03-12  Pedro Alves  <palves@redhat.com>
2238
2239         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
2240
2241 2019-03-12  Pedro Alves  <palves@redhat.com>
2242
2243         * cp-name-parser.y (main): Remove unused 'len' variable.
2244
2245 2019-03-12  Tom Tromey  <tromey@adacore.com>
2246
2247         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
2248         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
2249
2250 2019-03-12  Tom Tromey  <tromey@adacore.com>
2251
2252         * linux-nat.c (iterate_over_lwps): Update.
2253         (stop_callback): Remove parameter.
2254         (stop_wait_callback, detach_callback, resume_set_callback)
2255         (select_singlestep_lwp_callback, set_ignore_sigint)
2256         (status_callback, resumed_callback, resume_clear_callback)
2257         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
2258         data parameter.
2259         (linux_nat_target::detach, linux_nat_target::resume)
2260         (linux_stop_and_wait_all_lwps, select_event_lwp)
2261         (linux_nat_filter_event, linux_nat_wait_1)
2262         (linux_nat_target::kill, linux_nat_target::stop)
2263         (linux_nat_target::stop): Update.
2264         (linux_nat_resume_callback): Change type.
2265         (resume_stopped_resumed_lwps, count_events_callback)
2266         (select_event_lwp_callback): Likewise.
2267         (linux_stop_lwp, linux_nat_stop_lwp): Update.
2268         * arm-linux-nat.c (struct update_registers_data): Remove.
2269         (update_registers_callback): Change type.
2270         (arm_linux_insert_hw_breakpoint1): Update.
2271         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
2272         parameter.
2273         (x86_linux_dr_set_addr): Update.
2274         (x86_linux_dr_set_control): Update.
2275         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
2276         (iterate_over_lwps): Use gdb::function_view.
2277         * nat/aarch64-linux-hw-point.c (struct
2278         aarch64_dr_update_callback_param): Remove.
2279         (debug_reg_change_callback): Change type.
2280         (aarch64_notify_debug_reg_change): Update.
2281         * s390-linux-nat.c (s390_refresh_per_info): Update.
2282
2283 2019-03-11  Tom Tromey  <tromey@adacore.com>
2284
2285         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
2286         redundant assignment to "this_cu".
2287
2288 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2289
2290         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
2291
2292 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2293
2294         * gdbtypes.c (rank_one_type_parm_set): New function extracted
2295         from...
2296         (rank_one_type): ... this.
2297
2298 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2299
2300         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
2301         from...
2302         (rank_one_type): ... this.
2303
2304 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2305
2306         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
2307         from...
2308         (rank_one_type): ... this.
2309
2310 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2311
2312         * gdbtypes.c (rank_one_type_parm_float): New function extracted
2313         from...
2314         (rank_one_type): ... this.
2315
2316 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2317
2318         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
2319         from...
2320         (rank_one_type): ... this.
2321
2322 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2323
2324         * gdbtypes.c (rank_one_type_parm_range): New function extracted
2325         from...
2326         (rank_one_type): ... this.
2327
2328 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2329
2330         * gdbtypes.c (rank_one_type_parm_char): New function extracted
2331         from...
2332         (rank_one_type): ... this.
2333
2334 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2335
2336         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
2337         from...
2338         (rank_one_type): ... this.
2339
2340 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2341
2342         * gdbtypes.c (rank_one_type_parm_int): New function extracted
2343         from...
2344         (rank_one_type): ... this.
2345
2346 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2347
2348         * gdbtypes.c (rank_one_type_parm_func): New function extracted
2349         from...
2350         (rank_one_type): ... this.
2351
2352 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2353
2354         * gdbtypes.c (rank_one_type_parm_array): New function extracted
2355         from...
2356         (rank_one_type): ... this.
2357
2358 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2359
2360         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
2361         from...
2362         (rank_one_type): ... this.
2363
2364 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2365
2366         * inferior.c (initialize_inferiors): Ensure 'help set/show print
2367         inferior-events' shows the example events.
2368
2369 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
2370
2371         Support styling on native MS-Windows console
2372
2373         PR/24315
2374         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
2375         on MS-Windows if $TERM is not defined.
2376
2377         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
2378
2379         * posix-hdep.c (gdb_console_fputs):
2380         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
2381         functions.
2382         * ui-file.h (gdb_console_fputs): Add prototype.
2383
2384         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
2385         back to fputs only if the former returns zero.
2386
2387 2019-03-07  Tom Tromey  <tom@tromey.com>
2388
2389         * symmisc.c (print_symbol_bcache_statistics): Update.
2390         (print_objfile_statistics): Update.
2391         * symfile.c (allocate_symtab): Update.
2392         * stabsread.c: Don't include bcache.h.
2393         * psymtab.h (struct psymbol_bcache): Don't declare.
2394         (class psymtab_storage) <psymbol_cache>: Now a bcache.
2395         (psymbol_bcache_init, psymbol_bcache_free)
2396         (psymbol_bcache_get_bcache): Don't declare.
2397         * psymtab.c (struct psymbol_bcache): Remove.
2398         (psymtab_storage::psymtab_storage): Update.
2399         (psymtab_storage::~psymtab_storage): Update.
2400         (psymbol_bcache_init, psymbol_bcache_free)
2401         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
2402         (add_psymbol_to_bcache): Update.
2403         (allocate_psymtab): Update.
2404         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
2405         macro_cache>: No longer pointers.
2406         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
2407         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
2408         * macrotab.c (macro_bcache): Update.
2409         * macroexp.c: Don't include bcache.h.
2410         * gdbtypes.c (check_types_worklist): Update.
2411         (types_deeply_equal): Remove TRY/CATCH.  Update.
2412         * elfread.c (elf_symtab_read): Update.
2413         * dwarf2read.c: Don't include bcache.h.
2414         * buildsym.c (buildsym_compunit::get_macro_table): Update.
2415         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
2416         (print_bcache_statistics, bcache_memory_used): Don't declare.
2417         (struct bcache): Move from bcache.c.  Add constructor, destructor,
2418         methods.  Rename all data members.
2419         * bcache.c (struct bcache): Move to bcache.h.
2420         (bcache::expand_hash_table): Rename from expand_hash_table.
2421         (bcache): Remove.
2422         (bcache::insert): Rename from bcache_full.
2423         (bcache::compare): Rename from bcache_compare.
2424         (bcache_xmalloc): Remove.
2425         (bcache::~bcache): Rename from bcache_xfree.
2426         (bcache::print_statistics): Rename from print_bcache_statistics.
2427         (bcache::memory_used): Rename from bcache_memory_used.
2428
2429 2019-03-07  Pedro Alves  <palves@redhat.com>
2430
2431         * infrun.c (normal_stop): Also check for
2432         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
2433
2434 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
2435
2436         * f-lang.c (value_from_host_double): Moved to...
2437         * value.c (value_from_host_double): ...here.
2438         * value.h (value_from_host_double): Declare.
2439         * guile/scm-math.c (vlscm_convert_typed_number): Use
2440         value_from_host_double.
2441         (vlscm_convert_number): Likewise.
2442         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
2443         * python/py-value.c (convert_value_from_python): Likewise.
2444
2445 2019-03-06  Tom Tromey  <tom@tromey.com>
2446
2447         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
2448
2449 2019-03-06  Tom Tromey  <tom@tromey.com>
2450
2451         * utils.h (free_current_contents): Don't declare.
2452         * utils.c (free_current_contents): Remove.
2453
2454 2019-03-06  Tom Tromey  <tom@tromey.com>
2455
2456         * top.c (quit_force): Update.
2457         * main.c (captured_command_loop): Update.
2458         * common/new-op.c (operator new): Update.
2459         * common/common-exceptions.c (struct catcher)
2460         <save_cleanup_chain>: Remove member.
2461         (exceptions_state_mc_init): Update.
2462         (exception_try_scope_entry): Return nullptr.
2463         (exception_try_scope_exit, exception_rethrow)
2464         (throw_exception_sjlj, throw_exception_cxx): Update.
2465         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
2466         (all_cleanups, do_cleanups, discard_cleanups)
2467         (discard_final_cleanups, save_cleanups, save_final_cleanups)
2468         (restore_cleanups, restore_final_cleanups): Don't declare.
2469         (do_final_cleanups): Remove parameter.
2470         * common/cleanups.c (cleanup_chain, make_cleanup)
2471         (make_cleanup_dtor, all_cleanups, do_cleanups)
2472         (discard_my_cleanups, discard_cleanups)
2473         (discard_final_cleanups, save_my_cleanups, save_cleanups)
2474         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
2475         (null_cleanup): Remove.
2476         (do_final_cleanups): Remove parameter.
2477
2478 2019-03-06  Tom Tromey  <tom@tromey.com>
2479
2480         * remote.c (remote_target::remote_parse_stop_reply): Use
2481         unique_xmalloc_ptr.
2482
2483 2019-03-06  Tom Tromey  <tom@tromey.com>
2484
2485         * stabsread.c (struct stabs_field_info): Rename from field_info.
2486         <list, fnlist>: Add initializers.
2487         <obstack>: New member.
2488         (read_member_functions, read_struct_fields, read_baseclasses):
2489         Allocate on obstack.  Don't use cleanups.
2490         (read_one_struct_field, read_member_functions, read_struct_fields)
2491         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
2492         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
2493         (read_struct_type): Update.
2494
2495 2019-03-06  Tom Tromey  <tom@tromey.com>
2496
2497         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
2498         * common/filestuff.h (make_cleanup_close): Don't declare.
2499         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
2500         Remove.
2501
2502 2019-03-06  Tom Tromey  <tom@tromey.com>
2503
2504         * solib-aix.c: Use make_scope_exit.
2505
2506 2019-03-06  Tom Tromey  <tom@tromey.com>
2507
2508         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
2509         Use make_scope_exit.
2510
2511 2019-03-06  Tom Tromey  <tom@tromey.com>
2512
2513         * solib-svr4.c (disable_probes_interface): Remove parameter.
2514         (svr4_handle_solib_event): Use make_scope_exit.
2515
2516 2019-03-06  Tom Tromey  <tom@tromey.com>
2517
2518         * remote.c (struct stop_reply_deleter): Remove.
2519         (stop_reply_up): Update.
2520         (struct stop_reply): Derive from notif_event.  Don't typedef.
2521         <regcache>: Now a std::vector.
2522         (stop_reply_xfree): Remove.
2523         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
2524         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
2525         (remote_target::discard_pending_stop_replies): Use delete.
2526         (remote_target::remote_parse_stop_reply): Update.
2527         (remote_target::process_stop_reply): Update.
2528         * remote-notif.h (struct notif_event): Add virtual destructor.
2529         Remove "dtr" member.
2530         (struct notif_client) <alloc_event>: Return a unique_ptr.
2531         (notif_event_xfree): Don't declare.
2532         (notif_event_up): New typedef.
2533         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
2534         (notif_event_xfree, do_notif_event_xfree): Remove.
2535         (remote_notif_state_xfree): Update.
2536
2537 2019-03-06  Tom Tromey  <tom@tromey.com>
2538
2539         * infrun.c (displaced_step_clear_cleanup): Now a
2540         forward_scope_exit type.
2541         (displaced_step_prepare_throw): Update.
2542         (displaced_step_fixup): Update.
2543
2544 2019-03-06  Tom Tromey  <tom@tromey.com>
2545
2546         * inferior.h (class inferior): Update comment.
2547         * gdbthread.h (class thread_info): Update comment.
2548
2549 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
2550             Tom Tromey  <tom@tromey.com>
2551
2552         * stabsread.h (struct stab_section_list): Remove.
2553         (coffstab_build_psymtabs): Update.
2554         * dbxread.c (symbuf_sections): Now a std::vector.
2555         (sect_idx): New global.
2556         (fill_symbuf): Update.
2557         (coffstab_build_psymtabs): Change type of stabsects parameter.
2558         Update.
2559         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
2560         std::vector.
2561         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
2562         (coff_locate_sections): Update.
2563         (coff_symfile_read): Remove cleanups.  Update.
2564         (init_stringtab): Add storage parameter.
2565         (free_stringtab, free_stringtab_cleanup): Remove.
2566         (init_lineno): Add storage parameter.
2567         (free_linetab, free_linetab_cleanup): Remove.
2568
2569 2019-03-06  Pedro Alves  <palves@redhat.com>
2570
2571         * linux-fork.c (fork_info::clobber_regs): Delete.
2572         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
2573         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
2574         comment.  Adjust.
2575         (scoped_switch_fork_info::scoped_switch_fork_info)
2576         (checkpoint_command, linux_fork_context): Adjust
2577         fork_save_infrun_state calls.
2578
2579 2019-03-06  Pedro Alves  <palves@redhat.com>
2580
2581         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
2582         (inf_has_multiple_threads): Return 'bool' and rewrite using
2583         inferior_info::threads().
2584
2585 2019-03-06  Pedro Alves  <palves@redhat.com>
2586
2587         * linux-fork.c: Include <list>.
2588         (fork_list): Now a std::list instance.
2589         (fork_info): Add ctor, dtor, and in-class initialize all fields.
2590         (forks_exist_p, find_last_fork): Adjust.
2591         (new_fork): Delete.
2592         (one_fork_p): New.
2593         (add_fork): Adjust.
2594         (free_fork): Delete, folded into fork_info::~fork_info().
2595         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
2596         Adjust.
2597         (init_fork_list): Delete.
2598         (linux_fork_killall, linux_fork_mourn_inferior)
2599         (linux_fork_detach, info_checkpoints_command): Adjust.
2600         (_initialize_linux_fork): No longer call init_fork_list.
2601
2602 2019-03-06  Pedro Alves  <palves@redhat.com>
2603
2604         * linux-fork.c (new_fork): New, split out of ...
2605         (add_fork): ... this.  Return void.  Move "first fork" special
2606         case from here, to ...
2607         (checkpoint_command): ... here.
2608         * linux-linux.h (add_fork): Return void.
2609
2610 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2611
2612         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
2613
2614 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2615             Chris January  <chris.january@arm.com>
2616             David Lecomber  <david.lecomber@arm.com>
2617
2618         * f-exp.y: New token, UNOP_INTRINSIC.
2619         (exp): New pattern using UNOP_INTRINSIC token.
2620         (f77_keywords): Add 'abs' keyword.
2621         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
2622         (value_from_host_double): New function.
2623         (evaluate_subexp_f): Support UNOP_ABS.
2624
2625 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2626
2627         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
2628         types.
2629
2630 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2631
2632         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
2633         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
2634         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
2635
2636 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2637
2638         * f-exp.y (convert_to_kind_type): Handle more type kinds.
2639
2640 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2641             Chris January  <chris.january@arm.com>
2642
2643         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
2644         * f-exp.y: Define 'KIND' token.
2645         (exp): New pattern for KIND expressions.
2646         (ptype): Handle types with a kind extension.
2647         (direct_abs_decl): Extend to spot kind extensions.
2648         (f77_keywords): Add 'kind' to the list.
2649         (push_kind_type): New function.
2650         (convert_to_kind_type): New function.
2651         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
2652         * parse.c (operator_length_standard): Likewise.
2653         * parser-defs.h (enum type_pieces): Add tp_kind.
2654         * std-operator.def: Add UNOP_KIND.
2655
2656 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2657
2658         * f-exp.y (f_parse): Set yydebug.
2659
2660 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2661
2662         * f-lang.c (evaluate_subexp_f): New function.
2663         (exp_descriptor_f): New global.
2664         (f_language_defn): Use exp_descriptor_f instead of
2665         exp_descriptor_standard.
2666
2667 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2668
2669         * f-exp.y (struct token): Add comments.
2670         (dot_ops): Remove uppercase versions and the end marker.
2671         (f77_keywords): Likewise.
2672         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
2673         entries in the dot_ops array are case insensitive, and use
2674         strncasecmp to compare strings.  Also some whitespace cleanup in
2675         this area.  Similar for the f77_keywords array, except entries in
2676         this list might be case sensitive.
2677
2678 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2679
2680         * f-exp.y (struct f77_boolean_val): Add comments.
2681         (boolean_values): Remove uppercase versions, and end marker.
2682         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
2683         and use strncasecmp to achieve case insensitivity.  Additionally,
2684         perform whitespace cleanup around this code.
2685
2686 2019-03-06  Tom Tromey  <tromey@adacore.com>
2687
2688         * remote-sim.c (gdbsim_target_open): Use result of
2689         gdb_argv::release.
2690
2691 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
2692         Dirk Schubert  <dirk.schubert@arm.com>
2693         Chris January  <chris.january@arm.com>
2694
2695         * eval.c (evaluate_subexp_standard): Call Fortran argument
2696         wrapping logic.
2697         * f-lang.c (struct value): A value which can be passed into a
2698         Fortran function call.
2699         (fortran_argument_convert): Wrap Fortran arguments in a pointer
2700         where appropriate.
2701         (struct type): Value ready for a Fortran function call.
2702         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
2703         is needed.
2704         * f-lang.h (fortran_argument_convert): Declaration.
2705         (fortran_preserve_arg_pointer): Declaration.
2706         * infcall.c (value_arg_coerce): Call Fortran argument logic.
2707
2708 2019-03-05  Tom Tromey  <tromey@adacore.com>
2709
2710         * python/py-prettyprint.c (print_string_repr): Remove #if.
2711         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
2712
2713 2019-03-05  Tom Tromey  <tromey@adacore.com>
2714
2715         * target.c (the_dummy_target): Move later.  Change type to
2716         "dummy_target".
2717         (initialize_targets): Don't initialize the_dummy_target.
2718
2719 2019-03-05  Tom Tromey  <tromey@adacore.com>
2720
2721         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
2722         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
2723
2724 2019-03-05  Tom Tromey  <tromey@adacore.com>
2725
2726         * windows-nat.c (windows_nat_target::attach)
2727         (windows_nat_target::detach): Don't call gdb_flush.
2728         * valprint.c (generic_val_print, val_print, val_print_string):
2729         Don't call gdb_flush.
2730         * utils.c (defaulted_query): Don't call gdb_flush.
2731         * typeprint.c (print_type_scalar): Don't call gdb_flush.
2732         * target.c (target_announce_detach): Don't call gdb_flush.
2733         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
2734         * remote.c (extended_remote_target::attach): Don't call
2735         gdb_flush.
2736         * procfs.c (procfs_target::detach): Don't call gdb_flush.
2737         * printcmd.c (do_examine): Don't call gdb_flush.
2738         (info_display_command): Don't call gdb_flush.
2739         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
2740         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
2741         * memattr.c (info_mem_command): Don't call gdb_flush.
2742         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
2743         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
2744         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
2745         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
2746         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
2747         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
2748         (gnu_nat_target::detach): Don't call gdb_flush.
2749         * f-valprint.c (f_val_print): Don't call gdb_flush.
2750         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
2751         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
2752         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
2753         gdb_flush.
2754         * c-valprint.c (c_val_print): Don't call gdb_flush.
2755         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
2756
2757 2019-03-05  Tom Tromey  <tromey@adacore.com>
2758
2759         * varobj.c (update_dynamic_varobj_children): Update.
2760         (install_default_visualizer): Use reset, not release.
2761         * value.c (set_internalvar): Update.
2762         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
2763         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
2764         ATTRIBUTE_UNUSED_RESULT.
2765
2766 2019-03-05  Tom Tromey  <tromey@adacore.com>
2767
2768         * remote.c (class scoped_remote_fd) <release>: Add
2769         ATTRIBUTE_UNUSED_RESULT.
2770
2771 2019-03-05  Tom Tromey  <tromey@adacore.com>
2772
2773         * macroexp.c (struct macro_buffer) <release>: Add
2774         ATTRIBUTE_UNUSED_RESULT.
2775
2776 2019-03-05  Tom Tromey  <tromey@adacore.com>
2777
2778         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
2779         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
2780         ATTRIBUTE_UNUSED_RESULT.
2781
2782 2019-03-05  Tom Tromey  <tromey@adacore.com>
2783
2784         * common/scoped_fd.h (class scoped_fd) <release>: Add
2785         ATTRIBUTE_UNUSED_RESULT.
2786
2787 2019-03-05  Tom Tromey  <tromey@adacore.com>
2788
2789         * parser-defs.h (struct parser_state) <release>: Add
2790         ATTRIBUTE_UNUSED_RESULT.
2791
2792 2019-03-05  Tom Tromey  <tromey@adacore.com>
2793
2794         * utils.h (class gdb_argv) <release>: Add
2795         ATTRIBUTE_UNUSED_RESULT.
2796         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
2797
2798 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
2799
2800         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
2801         for-loop range, to avoid compiler warnings.
2802
2803         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
2804         avoid compiler warnings about unused variables.
2805
2806         * NEWS: Mention end of support for native debugging on MS-Windows
2807         before XP.
2808
2809         PR gdb/24292
2810         * common/netstuff.c:
2811         * gdbserver/gdbreplay.c
2812         * gdbserver/remote-utils.c:
2813         * ser-tcp.c:
2814         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
2815         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
2816         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
2817         'getaddrinfo' and 'freeaddrinfo' were not available before
2818         Windows XP, and mingw.org's MinGW headers by default define
2819         _WIN32_WINNT to 0x500.
2820
2821 2019-03-01  Gary Benson <gbenson@redhat.com>
2822
2823         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
2824
2825 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
2826             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2827
2828         PR gdb/8527
2829         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
2830         set_sigint_trap, clear_sigint_trap.
2831
2832 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2833
2834         * target.c (target_detach): Clear the regcache and the
2835         frame cache.
2836
2837 2019-02-27  Pedro Alves  <palves@redhat.com>
2838
2839         * utils.c (set_screen_size): When we cap the height/width sizes,
2840         tweak the corresponding command variable to show "unlimited":
2841
2842 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
2843             Pedro Alves  <palves@redhat.com>
2844
2845         * utils.c (set_screen_size): Reduce "infinite" rows and columns
2846         before calling rl_set_screen_size.
2847
2848 2019-02-27  Tom Tromey  <tromey@adacore.com>
2849
2850         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
2851         define.
2852         * python/py-value.c: Remove Python 2.4 workaround.
2853         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
2854         workaround.
2855         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
2856         Python 2.4 workaround.
2857         * python/python-internal.h: Remove Python 2.4 comment.
2858         (Py_ssize_t): Don't define.
2859         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
2860         (gdb_Py_DECREF): Remove Python 2.4 workaround.
2861         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
2862         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
2863         * python/python.c (do_start_initialization): Remove Python 2.4
2864         workaround.
2865         * python/py-prettyprint.c (class dummy_python_frame): Remove.
2866         (print_children): Remove Python 2.4 workaround.
2867         * python/py-inferior.c (buffer_procs): Remove Python 2.4
2868         workaround.
2869         (CHARBUFFERPROC_NAME): Remove.
2870         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
2871         Python 2.4 workaround.
2872
2873 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
2874
2875         * NEWS: Note minimum Python version.
2876
2877 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
2878
2879         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
2880         code from these functions.  Remove corresponding ifdefs.  Use
2881         Py_buffer_up instead of explicit calls to PyBuffer_Release.
2882         Remove gotos and target of gotos.
2883         (infpy_search_memory): Likewise.
2884
2885 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2886
2887         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
2888         (hppa_gdbarch_init): Don't register deleted functions with
2889         gdbarch.
2890
2891 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2892
2893         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
2894         (h8300_unwind_sp): Delete.
2895         (h8300_dummy_id): Delete.
2896         (h8300_gdbarch_init): Don't register deleted functions with
2897         gdbarch.
2898
2899 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2900
2901         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
2902         (ft32_unwind_pc): Delete.
2903         (ft32_unwind_sp): Delete.
2904         (ft32_gdbarch_init): Don't register deleted functions with
2905         gdbarch.
2906
2907 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2908
2909         * gdb/frv-tdep.c (frv_dummy_id): Delete.
2910         (frv_unwind_pc): Delete.
2911         (frv_unwind_sp): Delete.
2912         (frv_gdbarch_init): Don't register deleted functions with
2913         gdbarch.
2914
2915 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2916
2917         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
2918         (riscv_unwind_pc): Delete.
2919         (riscv_unwind_sp): Delete.
2920         (riscv_gdbarch_init): Don't register deleted functions with
2921         gdbarch.
2922
2923 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2924
2925         * gdb/csky-tdep.c (csky_dummy_id): Delete.
2926         (csky_unwind_pc): Delete.
2927         (csky_unwind_sp): Delete.
2928         (csky_gdbarch_init): Don't register deleted functions with
2929         gdbarch.
2930
2931 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2932
2933         * gdb/cris-tdep.c (cris_dummy_id): Delete.
2934         (cris_unwind_pc): Delete.
2935         (cris_unwind_sp): Delete.
2936         (cris_gdbarch_init): Don't register deleted functions with
2937         gdbarch.
2938
2939 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2940
2941         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
2942         (bfin_unwind_pc): Delete.
2943         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
2944
2945 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2946
2947         * gdb/arm-tdep.c (arm_dummy_id): Delete.
2948         (arm_unwind_pc): Delete.
2949         (arm_unwind_sp): Delete.
2950         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
2951
2952 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2953
2954         * gdb/arc-tdep.c (arc_dummy_id): Delete.
2955         (arc_unwind_pc): Delete.
2956         (arc_unwind_sp): Delete.
2957         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
2958
2959 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2960
2961         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
2962         (alpha_unwind_pc): Delete.
2963         (alpha_gdbarch_init): Don't register deleted functions with
2964         gdbarch.
2965
2966 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2967
2968         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
2969         (aarch64_unwind_pc): Delete.
2970         (aarch64_unwind_sp): Delete.
2971         (aarch64_gdbarch_init): Don't register deleted functions with
2972         gdbarch.
2973
2974 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2975
2976         * gdbtypes.c (type_align): Don't consider static members when
2977         computing structure alignment.
2978
2979 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2980
2981         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
2982         return 0 for other types.
2983         * arch-utils.c (default_type_align): Always return 0.
2984         * gdbarch.h: Regenerate.
2985         * gdbarch.sh (type_align): Extend comment.
2986         * gdbtypes.c (type_align): Add additional comments, always call
2987         gdbarch_type_align before applying the default rules.
2988         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
2989         generic code will then apply a suitable default.
2990         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
2991         types, return 0 for other types.
2992
2993 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
2994
2995         * NEWS: Create a new section for the next release branch.
2996         Rename the section of the current branch, now that it has
2997         been cut.
2998
2999 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3000
3001         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
3002         * version.in: Bump version to 8.3.50.DATE-git.
3003
3004 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
3005
3006         * aix-thread.c (ptid_cmp): Remove unused variable.
3007         (get_signaled_thread): Likewise.
3008         (store_regs_user_thread): Likewise.
3009         (store_regs_kernel_thread): Likewise.
3010         (fetch_regs_kernel_thread): Remove shadowed variable.
3011
3012 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3013
3014         * features/riscv/32bit-cpu.xml: Add register numbers.
3015         * features/riscv/32bit-fpu.c: Regenerate.
3016         * features/riscv/32bit-fpu.xml: Add register numbers.
3017         * features/riscv/64bit-cpu.xml: Add register numbers.
3018         * features/riscv/64bit-fpu.c: Regenerate.
3019         * features/riscv/64bit-fpu.xml: Add register numbers.
3020
3021 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
3022
3023         * NEWS: Mention two argument form of gdb.Value constructor.
3024         * python/py-value.c (convert_buffer_and_type_to_value): New
3025         function.
3026         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
3027         Add support for handling an optional second argument.  Call
3028         convert_buffer_and_type_to_value as appropriate.
3029         * python/python-internal.h (Py_buffer_deleter): New struct.
3030         (Py_buffer_up): New typedef.
3031
3032 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
3033
3034         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
3035         instead of releasing ownership.
3036
3037 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
3038
3039         * dwarf2read.c (open_and_init_dwp_file): Call
3040         elf_numsections instead of bfd_count_sections to initialize
3041         dwp_file->num_sections.
3042
3043 2019-02-25  Tom Tromey  <tromey@adacore.com>
3044
3045         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
3046
3047 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3048
3049         * gcore.in: Add '--readnever' option when invoking GDB.
3050
3051 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3052
3053         * MAINTAINERS: Update my email address.
3054
3055 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3056
3057         * build-id.c (build_id_to_debug_bfd_1): New function.
3058         (build_id_to_debug_bfd): Look for separate debug file in
3059         sysroot.
3060
3061 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3062
3063         * gdbarch.sh: Update the copyright year range that is placed into
3064         generated files.
3065
3066 2019-02-22  Keith Seitz  <keiths@redhat.com>
3067
3068         PR symtab/23853
3069         * linespec.c (create_sals_line_offset): Search for the default
3070         symtab's filename instead of its fullname.
3071
3072 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3073
3074         * NEWS: Update style defaults.
3075
3076 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3077
3078         * main.c (captured_main_1): Disable styling in batch mode.
3079
3080 2019-02-20  Tom Tromey  <tom@tromey.com>
3081
3082         * symtab.c (symtab_symbol_info): Fix typos.
3083
3084 2019-02-20  Tom Tromey  <tromey@adacore.com>
3085
3086         * findcmd.c (_initialize_mem_search): Use upper case for
3087         metasyntactic variables.
3088
3089 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
3090
3091         * aarch64-tdep.c (aarch64_add_reggroups): New function.
3092         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
3093
3094 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
3095
3096         * top.h (source_file_name): Change to std::string.
3097         * top.c (source_file_name): Likewise.
3098         (command_line_input): Adjust.
3099         * cli/cli-script.c (script_from_file): Adjust.
3100
3101 2019-02-19  Tom Tromey  <tromey@adacore.com>
3102
3103         * ravenscar-thread.c
3104         (ravenscar_thread_target::update_thread_list): Don't call
3105         ada_build_task_list.
3106         * ada-lang.h (ada_build_task_list): Don't declare.
3107         * ada-tasks.c (struct ada_tasks_inferior_data)
3108         <task_list_valid_p>: Now bool.
3109         (read_known_tasks, ada_task_list_changed)
3110         (ada_tasks_invalidate_inferior_data): Update.
3111         (read_known_tasks_array): Return bool.
3112         (read_known_tasks_list): Likewise.
3113         (read_known_tasks): Return void.
3114         (ada_build_task_list): Now static.
3115
3116 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3117
3118         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
3119         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
3120
3121 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3122
3123         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
3124         variant for ada_tasks_pspace_data_handle and
3125         ada_tasks_inferior_data_handle.
3126         (ada_tasks_pspace_data_cleanup): New function.
3127         (ada_tasks_inferior_data_cleanup): New function.
3128
3129 2019-02-17  Tom Tromey  <tom@tromey.com>
3130
3131         * macrotab.h (macro_source_fullname): Return a std::string.
3132         * macrotab.c (macro_include, check_for_redefinition)
3133         (macro_undef, macro_lookup_definition, foreach_macro)
3134         (foreach_macro_in_scope): Update.
3135         (macro_source_fullname): Return a std::string.
3136         * macrocmd.c (show_pp_source_pos): Update.
3137
3138 2019-02-17  Tom Tromey  <tom@tromey.com>
3139
3140         * macrocmd.c (show_pp_source_pos): Style the file names.
3141
3142 2019-02-17  Tom Tromey  <tom@tromey.com>
3143
3144         PR tui/24197:
3145         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
3146
3147 2019-02-17  Tom Tromey  <tom@tromey.com>
3148
3149         * ada-lang.c (user_select_syms): Use filtered printing.
3150         * utils.c (wrap_style): New global.
3151         (desired_style): Remove.
3152         (emit_style_escape): Add stream parameter.
3153         (set_output_style, reset_terminal_style, prompt_for_continue):
3154         Update.
3155         (flush_wrap_buffer): Only flush gdb_stdout.
3156         (wrap_here): Set wrap_style.
3157         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
3158         treat escape sequences as a character.  Change when wrap buffer is
3159         flushed.
3160         (fputs_styled): Do not set the output style when the default is
3161         requested.
3162         * ui-style.h (struct ui_file_style) <is_default>: New method.
3163         * source.c (print_source_lines_base): Emit escape sequences in one
3164         piece.
3165
3166 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3167
3168         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
3169         integers and enumeration types.
3170
3171 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3172
3173         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
3174         instead of lookup_symbol_in_language
3175         (do_exact_match): New function.
3176         (ada_get_symbol_name_matcher): Return do_exact_match when
3177         doing a verbatim match.
3178
3179 2019-02-15  Tom Tromey  <tromey@adacore.com>
3180
3181         * ravenscar-thread.c (ravenscar_thread_target::resume)
3182         (ravenscar_thread_target::wait): Special case wildcard requests.
3183
3184 2019-02-15  Tom Tromey  <tromey@adacore.com>
3185
3186         * ravenscar-thread.c (base_ptid): Remove.
3187         (struct ravenscar_thread_target) <close>: New method.
3188         <m_base_ptid>: New member.
3189         <update_inferior_ptid, active_task, task_is_currently_active,
3190         runtime_initialized>: Declare methods.
3191         <ravenscar_thread_target>: Add constructor.
3192         (ravenscar_thread_target::task_is_currently_active)
3193         (ravenscar_thread_target::update_inferior_ptid)
3194         (ravenscar_runtime_initialized): Rename.  Now methods.
3195         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
3196         (ravenscar_thread_target::update_thread_list): Update.
3197         (ravenscar_thread_target::active_task): Now method.
3198         (ravenscar_thread_target::store_registers)
3199         (ravenscar_thread_target::prepare_to_store)
3200         (ravenscar_thread_target::prepare_to_store)
3201         (ravenscar_thread_target::mourn_inferior): Update.
3202         (ravenscar_inferior_created): Use "new" to create target.
3203         (ravenscar_thread_target::get_ada_task_ptid): Update.
3204         (_initialize_ravenscar): Don't initialize base_ptid.
3205         (ravenscar_ops): Remove global.
3206
3207 2019-02-15  Tom Tromey  <tromey@adacore.com>
3208
3209         * target.h (push_target): Declare new overload.
3210         * target.c (push_target): New overload, taking an rvalue reference.
3211         * remote.c (remote_target::open_1): Use push_target overload.
3212         * corelow.c (core_target_open): Use push_target overload.
3213
3214 2019-02-15  Tom Tromey  <tromey@adacore.com>
3215
3216         * ravenscar-thread.c (is_ravenscar_task)
3217         (ravenscar_task_is_currently_active): Return bool.
3218         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
3219         (_initialize_ravenscar): Remove "(void)".
3220         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
3221         Return bool.
3222
3223 2019-02-15  Tom Tromey  <tromey@adacore.com>
3224
3225         * ravenscar-thread.c (ravenscar_runtime_initializer)
3226         (has_ravenscar_runtime, get_running_thread_id)
3227         (ravenscar_thread_target::resume): Fix indentation.
3228
3229 2019-02-15  Tom Tromey  <tromey@adacore.com>
3230
3231         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
3232         from ravenscar_arch_ops.
3233         (sparc_ravenscar_ops::fetch_registers)
3234         (sparc_ravenscar_ops::store_registers): Now methods.
3235         (sparc_ravenscar_prepare_to_store): Remove.
3236         (sparc_ravenscar_ops): Redefine.
3237         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
3238         methods and destructor.  Remove members.
3239         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
3240         (ravenscar_thread_target::store_registers)
3241         (ravenscar_thread_target::prepare_to_store): Update.
3242         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
3243         Remove.
3244         (struct ppc_ravenscar_powerpc_ops): Derive from
3245         ravenscar_arch_ops.
3246         (ppc_ravenscar_powerpc_ops::fetch_registers)
3247         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
3248         (ppc_ravenscar_powerpc_ops): Redefine.
3249         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
3250         (ppc_ravenscar_e500_ops::fetch_registers)
3251         (ppc_ravenscar_e500_ops::store_registers): Now methods.
3252         (ppc_ravenscar_e500_ops): Redefine.
3253         * aarch64-ravenscar-thread.c
3254         (aarch64_ravenscar_generic_prepare_to_store): Remove.
3255         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
3256         (aarch64_ravenscar_fetch_registers)
3257         (aarch64_ravenscar_store_registers): Now methods.
3258         (aarch64_ravenscar_ops): Redefine.
3259
3260 2019-02-15  Tom Tromey  <tromey@adacore.com>
3261
3262         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
3263         (ravenscar_thread_target::stopped_by_hw_breakpoint)
3264         (ravenscar_thread_target::stopped_by_watchpoint)
3265         (ravenscar_thread_target::stopped_data_address)
3266         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
3267
3268 2019-02-15  Tom Tromey  <tromey@adacore.com>
3269
3270         * ravenscar-thread.c: Fix some typos.
3271
3272 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3273             Tom Tromey  <tromey@adacore.com>
3274
3275         * ada-lang.c (ada_exception_sal): Change addr_string to a
3276         std::string.
3277         (create_ada_exception_catchpoint): Update.
3278
3279 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3280             Tom Tromey  <tromey@adacore.com>
3281
3282         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
3283         (bp_location_ops): Remove.
3284         (base_breakpoint_allocate_location): Update.
3285         (free_bp_location): Update.
3286         * ada-lang.c (class ada_catchpoint_location)
3287         <ada_catchpoint_location>: Remove ops parameter.
3288         (ada_catchpoint_location_dtor): Remove.
3289         (ada_catchpoint_location_ops): Remove.
3290         (allocate_location_exception): Update.
3291         * breakpoint.h (struct bp_location_ops): Remove.
3292         (class bp_location) <bp_location>: Remove bp_location_ops
3293         parameter.
3294         <~bp_location>: Add destructor.
3295         <ops>: Remove.
3296
3297 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3298             Pedro Alves  <palves@redhat.com>
3299
3300         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
3301         'PATH_MAX'.
3302
3303 2019-02-14  David Michael  <fedora.dm0@gmail.com>
3304             Samuel Thibault  <samuel.thibault@gnu.org>
3305             Thomas Schwinge  <thomas@codesourcery.com>
3306
3307         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
3308         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
3309
3310 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3311
3312         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
3313         (check_empty): Use "const char *".
3314
3315         * gnu-nat.c (gnu_nat_target::detach): Instead of
3316         'detach_inferior (pid)' call
3317         'detach_inferior (find_inferior_pid (pid))'.
3318
3319         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
3320         'nat/fork-inferior.o'.
3321         * gnu-nat.c: #include "nat/fork-inferior.h".
3322
3323         * gnu-nat.c (gnu_nat_target::detach): Instead of
3324         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
3325         * gnu-nat.h: #include "inf-child.h".
3326         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
3327         'i386_gnu_nat_target::fetch_registers'.
3328         (gnu_store_registers): Rename/move to
3329         'i386_gnu_nat_target::store_registers'.
3330
3331         * config/i386/nm-i386gnu.h: Don't "#include" any files.
3332         * gnu-nat.h (mach_thread_info): New function.
3333         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
3334
3335         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
3336
3337 2019-02-14  Frederic Konrad  <konrad@adacore.com>
3338
3339         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
3340
3341 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
3342
3343         * windows-nat.c (windows_add_thread): Add new parameter
3344         "main_thread_p" with default value set to false.  Update
3345         function documentation as well as all callers.
3346         (windows_delete_thread): Likewise.
3347         (fake_create_process): Update call to windows_add_thread.
3348         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
3349         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
3350         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
3351         call to windows_delete_thread.
3352
3353 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
3354
3355         * MAINTAINERS: Add Andrew Burgess as global maintainer.
3356
3357 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3358
3359         * symfile.c (find_separate_debug_file): Use canonical path of
3360         sysroot with child_path instead of gdb_sysroot if it is valid.
3361
3362 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3363
3364         * symfile.c (find_separate_debug_file): Use child_path to
3365         determine if an object file is under a sysroot.
3366
3367 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3368
3369         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
3370         unittests/child-path-selftests.c.
3371         * common/pathstuff.c (child_path): New function.
3372         * common/pathstuff.h (child_path): New prototype.
3373         * unittests/child-path-selftests.c: New file.
3374
3375 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3376
3377         * symfile.c (find_separate_debug_file): Look for separate debug
3378         files in debug directories under the sysroot.
3379
3380 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3381
3382         * symtab.h (struct minimal_symbol data_p): New const method.
3383         (struct minimal_symbol text_p): Likewise.
3384         * symtab.c (output_source_filename): Use file name style
3385         to print file name.
3386         (print_symbol_info): Likewise.
3387         (print_msymbol_info): Use address style to print addresses.
3388         Use function name style to print executable text symbols.
3389         (expand_symtab_containing_pc): Use data_p.
3390         (find_pc_sect_compunit_symtab): Likewise.
3391
3392 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3393
3394         * breakpoint.c (describe_other_breakpoints): Use address style
3395         to print addresses.
3396         (say_where): Likewise.
3397
3398 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3399
3400         * ada-typeprint.c (print_func_type): Print function name
3401         style to print function name.
3402         * c-typeprint.c (c_print_type_1): Likewise.
3403
3404 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
3405
3406         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
3407         for execve.
3408
3409 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3410
3411         * c-exp.y (direct_abs_decl): Use emplace_back to record the
3412         type_stack.
3413
3414 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
3415
3416         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
3417         TYPE_CODE_REF types.
3418
3419 2019-02-08  Jim Wilson  <jimw@sifive.com>
3420
3421         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
3422         (riscv_linux_fregset): New.
3423         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
3424
3425 2019-02-07  Tom Tromey  <tom@tromey.com>
3426
3427         * thread.c (thread_cancel_execution_command): Update.
3428         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
3429         methods.
3430         (struct thread_fsm_ops): Remove.
3431         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
3432         (thread_fsm_should_stop, thread_fsm_return_value)
3433         (thread_fsm_set_finished, thread_fsm_finished_p)
3434         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
3435         Don't declare.
3436         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
3437         * infrun.c (clear_proceed_status_thread)
3438         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
3439         (print_stop_event): Update.
3440         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
3441         Add constructor.
3442         (step_command_fsm_ops): Remove.
3443         (new_step_command_fsm): Remove.
3444         (step_1): Update.
3445         (step_command_fsm::should_stop): Rename from
3446         step_command_fsm_should_stop.
3447         (step_command_fsm::clean_up): Rename from
3448         step_command_fsm_clean_up.
3449         (step_command_fsm::do_async_reply_reason): Rename from
3450         step_command_fsm_async_reply_reason.
3451         (struct until_next_fsm): Inherit from thread_fsm.  Add
3452         constructor.
3453         (until_next_fsm_ops): Remove.
3454         (new_until_next_fsm): Remove.
3455         (until_next_fsm::should_stop): Rename from
3456         until_next_fsm_should_stop.
3457         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
3458         (until_next_fsm::do_async_reply_reason): Rename from
3459         until_next_fsm_async_reply_reason.
3460         (struct finish_command_fsm): Inherit from thread_fsm.  Add
3461         constructor.  Change type of breakpoint.
3462         (finish_command_fsm_ops): Remove.
3463         (new_finish_command_fsm): Remove.
3464         (finish_command_fsm::should_stop): Rename from
3465         finish_command_fsm_should_stop.
3466         (finish_command_fsm::clean_up): Rename from
3467         finish_command_fsm_clean_up.
3468         (finish_command_fsm::return_value): Rename from
3469         finish_command_fsm_return_value.
3470         (finish_command_fsm::do_async_reply_reason): Rename from
3471         finish_command_fsm_async_reply_reason.
3472         (finish_command): Update.
3473         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
3474         Add constructor.
3475         (call_thread_fsm_ops): Remove.
3476         (call_thread_fsm::call_thread_fsm): Rename from
3477         new_call_thread_fsm.
3478         (call_thread_fsm::should_stop): Rename from
3479         call_thread_fsm_should_stop.
3480         (call_thread_fsm::should_notify_stop): Rename from
3481         call_thread_fsm_should_notify_stop.
3482         (run_inferior_call, call_function_by_hand_dummy): Update.
3483         * cli/cli-interp.c (should_print_stop_to_console): Update.
3484         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
3485         Add constructor.  Change type of location_breakpoint,
3486         caller_breakpoint.
3487         (until_break_fsm_ops): Remove.
3488         (new_until_break_fsm): Remove.
3489         (until_break_fsm::should_stop): Rename from
3490         until_break_fsm_should_stop.
3491         (until_break_fsm::clean_up): Rename from
3492         until_break_fsm_clean_up.
3493         (until_break_fsm::do_async_reply_reason): Rename from
3494         until_break_fsm_async_reply_reason.
3495         (until_break_command): Update.
3496         * thread-fsm.c: Remove.
3497         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
3498
3499 2019-02-07  Tom Tromey  <tom@tromey.com>
3500
3501         * yy-remap.h: Add include guard.
3502         * xtensa-tdep.h: Add include guard.
3503         * xcoffread.h: Rename include guard.
3504         * varobj-iter.h: Add include guard.
3505         * tui/tui.h: Rename include guard.
3506         * tui/tui-winsource.h: Rename include guard.
3507         * tui/tui-wingeneral.h: Rename include guard.
3508         * tui/tui-windata.h: Rename include guard.
3509         * tui/tui-win.h: Rename include guard.
3510         * tui/tui-stack.h: Rename include guard.
3511         * tui/tui-source.h: Rename include guard.
3512         * tui/tui-regs.h: Rename include guard.
3513         * tui/tui-out.h: Rename include guard.
3514         * tui/tui-layout.h: Rename include guard.
3515         * tui/tui-io.h: Rename include guard.
3516         * tui/tui-hooks.h: Rename include guard.
3517         * tui/tui-file.h: Rename include guard.
3518         * tui/tui-disasm.h: Rename include guard.
3519         * tui/tui-data.h: Rename include guard.
3520         * tui/tui-command.h: Rename include guard.
3521         * tic6x-tdep.h: Add include guard.
3522         * target/waitstatus.h: Rename include guard.
3523         * target/wait.h: Rename include guard.
3524         * target/target.h: Rename include guard.
3525         * target/resume.h: Rename include guard.
3526         * target-float.h: Rename include guard.
3527         * stabsread.h: Add include guard.
3528         * rs6000-tdep.h: Add include guard.
3529         * riscv-fbsd-tdep.h: Add include guard.
3530         * regformats/regdef.h: Rename include guard.
3531         * record.h: Rename include guard.
3532         * python/python.h: Rename include guard.
3533         * python/python-internal.h: Rename include guard.
3534         * python/py-stopevent.h: Rename include guard.
3535         * python/py-ref.h: Rename include guard.
3536         * python/py-record.h: Rename include guard.
3537         * python/py-record-full.h: Rename include guard.
3538         * python/py-record-btrace.h: Rename include guard.
3539         * python/py-instruction.h: Rename include guard.
3540         * python/py-events.h: Rename include guard.
3541         * python/py-event.h: Rename include guard.
3542         * procfs.h: Add include guard.
3543         * proc-utils.h: Add include guard.
3544         * p-lang.h: Add include guard.
3545         * or1k-tdep.h: Rename include guard.
3546         * observable.h: Rename include guard.
3547         * nto-tdep.h: Rename include guard.
3548         * nat/x86-linux.h: Rename include guard.
3549         * nat/x86-linux-dregs.h: Rename include guard.
3550         * nat/x86-gcc-cpuid.h: Add include guard.
3551         * nat/x86-dregs.h: Rename include guard.
3552         * nat/x86-cpuid.h: Rename include guard.
3553         * nat/ppc-linux.h: Rename include guard.
3554         * nat/mips-linux-watch.h: Rename include guard.
3555         * nat/linux-waitpid.h: Rename include guard.
3556         * nat/linux-ptrace.h: Rename include guard.
3557         * nat/linux-procfs.h: Rename include guard.
3558         * nat/linux-osdata.h: Rename include guard.
3559         * nat/linux-nat.h: Rename include guard.
3560         * nat/linux-namespaces.h: Rename include guard.
3561         * nat/linux-btrace.h: Rename include guard.
3562         * nat/glibc_thread_db.h: Rename include guard.
3563         * nat/gdb_thread_db.h: Rename include guard.
3564         * nat/gdb_ptrace.h: Rename include guard.
3565         * nat/fork-inferior.h: Rename include guard.
3566         * nat/amd64-linux-siginfo.h: Rename include guard.
3567         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
3568         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
3569         * nat/aarch64-linux.h: Rename include guard.
3570         * nat/aarch64-linux-hw-point.h: Rename include guard.
3571         * mn10300-tdep.h: Add include guard.
3572         * mips-linux-tdep.h: Add include guard.
3573         * mi/mi-parse.h: Rename include guard.
3574         * mi/mi-out.h: Rename include guard.
3575         * mi/mi-main.h: Rename include guard.
3576         * mi/mi-interp.h: Rename include guard.
3577         * mi/mi-getopt.h: Rename include guard.
3578         * mi/mi-console.h: Rename include guard.
3579         * mi/mi-common.h: Rename include guard.
3580         * mi/mi-cmds.h: Rename include guard.
3581         * mi/mi-cmd-break.h: Rename include guard.
3582         * m2-lang.h: Add include guard.
3583         * location.h: Rename include guard.
3584         * linux-record.h: Rename include guard.
3585         * linux-nat.h: Add include guard.
3586         * linux-fork.h: Add include guard.
3587         * i386-darwin-tdep.h: Rename include guard.
3588         * hppa-linux-offsets.h: Add include guard.
3589         * guile/guile.h: Rename include guard.
3590         * guile/guile-internal.h: Rename include guard.
3591         * gnu-nat.h: Rename include guard.
3592         * gdb-stabs.h: Rename include guard.
3593         * frv-tdep.h: Add include guard.
3594         * f-lang.h: Add include guard.
3595         * event-loop.h: Add include guard.
3596         * darwin-nat.h: Rename include guard.
3597         * cp-abi.h: Rename include guard.
3598         * config/sparc/nm-sol2.h: Rename include guard.
3599         * config/nm-nto.h: Rename include guard.
3600         * config/nm-linux.h: Add include guard.
3601         * config/i386/nm-i386gnu.h: Rename include guard.
3602         * config/djgpp/nl_types.h: Rename include guard.
3603         * config/djgpp/langinfo.h: Rename include guard.
3604         * compile/gcc-cp-plugin.h: Add include guard.
3605         * compile/gcc-c-plugin.h: Add include guard.
3606         * compile/compile.h: Rename include guard.
3607         * compile/compile-object-run.h: Rename include guard.
3608         * compile/compile-object-load.h: Rename include guard.
3609         * compile/compile-internal.h: Rename include guard.
3610         * compile/compile-cplus.h: Rename include guard.
3611         * compile/compile-c.h: Rename include guard.
3612         * common/xml-utils.h: Rename include guard.
3613         * common/x86-xstate.h: Rename include guard.
3614         * common/version.h: Rename include guard.
3615         * common/vec.h: Rename include guard.
3616         * common/tdesc.h: Rename include guard.
3617         * common/selftest.h: Rename include guard.
3618         * common/scoped_restore.h: Rename include guard.
3619         * common/scoped_mmap.h: Rename include guard.
3620         * common/scoped_fd.h: Rename include guard.
3621         * common/safe-iterator.h: Rename include guard.
3622         * common/run-time-clock.h: Rename include guard.
3623         * common/refcounted-object.h: Rename include guard.
3624         * common/queue.h: Rename include guard.
3625         * common/ptid.h: Rename include guard.
3626         * common/print-utils.h: Rename include guard.
3627         * common/preprocessor.h: Rename include guard.
3628         * common/pathstuff.h: Rename include guard.
3629         * common/observable.h: Rename include guard.
3630         * common/netstuff.h: Rename include guard.
3631         * common/job-control.h: Rename include guard.
3632         * common/host-defs.h: Rename include guard.
3633         * common/gdb_wait.h: Rename include guard.
3634         * common/gdb_vecs.h: Rename include guard.
3635         * common/gdb_unlinker.h: Rename include guard.
3636         * common/gdb_unique_ptr.h: Rename include guard.
3637         * common/gdb_tilde_expand.h: Rename include guard.
3638         * common/gdb_sys_time.h: Rename include guard.
3639         * common/gdb_string_view.h: Rename include guard.
3640         * common/gdb_splay_tree.h: Rename include guard.
3641         * common/gdb_setjmp.h: Rename include guard.
3642         * common/gdb_ref_ptr.h: Rename include guard.
3643         * common/gdb_optional.h: Rename include guard.
3644         * common/gdb_locale.h: Rename include guard.
3645         * common/gdb_assert.h: Rename include guard.
3646         * common/filtered-iterator.h: Rename include guard.
3647         * common/filestuff.h: Rename include guard.
3648         * common/fileio.h: Rename include guard.
3649         * common/environ.h: Rename include guard.
3650         * common/common-utils.h: Rename include guard.
3651         * common/common-types.h: Rename include guard.
3652         * common/common-regcache.h: Rename include guard.
3653         * common/common-inferior.h: Rename include guard.
3654         * common/common-gdbthread.h: Rename include guard.
3655         * common/common-exceptions.h: Rename include guard.
3656         * common/common-defs.h: Rename include guard.
3657         * common/common-debug.h: Rename include guard.
3658         * common/cleanups.h: Rename include guard.
3659         * common/buffer.h: Rename include guard.
3660         * common/btrace-common.h: Rename include guard.
3661         * common/break-common.h: Rename include guard.
3662         * cli/cli-utils.h: Rename include guard.
3663         * cli/cli-style.h: Rename include guard.
3664         * cli/cli-setshow.h: Rename include guard.
3665         * cli/cli-script.h: Rename include guard.
3666         * cli/cli-interp.h: Rename include guard.
3667         * cli/cli-decode.h: Rename include guard.
3668         * cli/cli-cmds.h: Rename include guard.
3669         * charset-list.h: Add include guard.
3670         * buildsym-legacy.h: Rename include guard.
3671         * bfin-tdep.h: Add include guard.
3672         * ax.h: Rename include guard.
3673         * arm-linux-tdep.h: Add include guard.
3674         * arm-fbsd-tdep.h: Add include guard.
3675         * arch/xtensa.h: Rename include guard.
3676         * arch/tic6x.h: Add include guard.
3677         * arch/i386.h: Add include guard.
3678         * arch/arm.h: Rename include guard.
3679         * arch/arm-linux.h: Rename include guard.
3680         * arch/arm-get-next-pcs.h: Rename include guard.
3681         * arch/amd64.h: Add include guard.
3682         * arch/aarch64-insn.h: Rename include guard.
3683         * arch-utils.h: Rename include guard.
3684         * annotate.h: Add include guard.
3685         * amd64-darwin-tdep.h: Rename include guard.
3686         * aarch64-linux-tdep.h: Add include guard.
3687         * aarch64-fbsd-tdep.h: Add include guard.
3688         * aarch32-linux-nat.h: Add include guard.
3689
3690 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3691
3692         * macrotab.c (macro_define_internal): New function that
3693         factorizes macro_define_object_internal and macro_define_function
3694         code.
3695         (macro_define_object_internal): Use macro_define_internal.
3696         (macro_define_function): Likewise.
3697
3698 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3699
3700         * macrocmd.c (extract_identifier): Return
3701         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
3702         callers.
3703
3704 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
3705
3706         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
3707
3708 2019-02-05  Tom Tromey  <tom@tromey.com>
3709
3710         * target.c (target_stack::unpush): Move assertion earlier.
3711
3712 2019-01-30  Tom Tromey  <tom@tromey.com>
3713
3714         PR python/23615:
3715         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
3716         (gdbpy_parse_and_eval): Likewise.
3717         * python/python-internal.h (gdbpy_allow_threads): New class.
3718
3719 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
3720
3721         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
3722         (aarch64_fbsd_fpregmap): Move earlier.
3723         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
3724         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3725         instead of individual calls to trad_frame_set_reg_addr.
3726         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
3727         earlier.
3728         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
3729         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3730         instead of individual calls to trad_frame_set_reg_addr.
3731
3732 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
3733
3734         * CONTRIBUTE: Replace contribution list with wiki link.
3735
3736 2019-01-25  Tom Tromey  <tom@tromey.com>
3737
3738         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
3739
3740 2019-01-25  Tom Tromey  <tom@tromey.com>
3741
3742         * xtensa-linux-nat.c: Fix common/ includes.
3743         * xml-support.h: Fix common/ includes.
3744         * xml-support.c: Fix common/ includes.
3745         * x86-linux-nat.c: Fix common/ includes.
3746         * windows-nat.c: Fix common/ includes.
3747         * varobj.h: Fix common/ includes.
3748         * varobj.c: Fix common/ includes.
3749         * value.c: Fix common/ includes.
3750         * valops.c: Fix common/ includes.
3751         * utils.c: Fix common/ includes.
3752         * unittests/xml-utils-selftests.c: Fix common/ includes.
3753         * unittests/utils-selftests.c: Fix common/ includes.
3754         * unittests/unpack-selftests.c: Fix common/ includes.
3755         * unittests/tracepoint-selftests.c: Fix common/ includes.
3756         * unittests/style-selftests.c: Fix common/ includes.
3757         * unittests/string_view-selftests.c: Fix common/ includes.
3758         * unittests/scoped_restore-selftests.c: Fix common/ includes.
3759         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
3760         * unittests/scoped_fd-selftests.c: Fix common/ includes.
3761         * unittests/rsp-low-selftests.c: Fix common/ includes.
3762         * unittests/parse-connection-spec-selftests.c: Fix common/
3763         includes.
3764         * unittests/optional-selftests.c: Fix common/ includes.
3765         * unittests/offset-type-selftests.c: Fix common/ includes.
3766         * unittests/observable-selftests.c: Fix common/ includes.
3767         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
3768         * unittests/memrange-selftests.c: Fix common/ includes.
3769         * unittests/memory-map-selftests.c: Fix common/ includes.
3770         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
3771         * unittests/function-view-selftests.c: Fix common/ includes.
3772         * unittests/environ-selftests.c: Fix common/ includes.
3773         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
3774         * unittests/common-utils-selftests.c: Fix common/ includes.
3775         * unittests/cli-utils-selftests.c: Fix common/ includes.
3776         * unittests/array-view-selftests.c: Fix common/ includes.
3777         * ui-file.c: Fix common/ includes.
3778         * tui/tui-io.c: Fix common/ includes.
3779         * tracepoint.h: Fix common/ includes.
3780         * tracepoint.c: Fix common/ includes.
3781         * tracefile-tfile.c: Fix common/ includes.
3782         * top.h: Fix common/ includes.
3783         * top.c: Fix common/ includes.
3784         * thread.c: Fix common/ includes.
3785         * target/waitstatus.h: Fix common/ includes.
3786         * target/waitstatus.c: Fix common/ includes.
3787         * target.h: Fix common/ includes.
3788         * target.c: Fix common/ includes.
3789         * target-memory.c: Fix common/ includes.
3790         * target-descriptions.c: Fix common/ includes.
3791         * symtab.h: Fix common/ includes.
3792         * symfile.c: Fix common/ includes.
3793         * stap-probe.c: Fix common/ includes.
3794         * spu-linux-nat.c: Fix common/ includes.
3795         * sparc-nat.c: Fix common/ includes.
3796         * source.c: Fix common/ includes.
3797         * solib.c: Fix common/ includes.
3798         * solib-target.c: Fix common/ includes.
3799         * ser-unix.c: Fix common/ includes.
3800         * ser-tcp.c: Fix common/ includes.
3801         * ser-pipe.c: Fix common/ includes.
3802         * ser-base.c: Fix common/ includes.
3803         * selftest-arch.c: Fix common/ includes.
3804         * s12z-tdep.c: Fix common/ includes.
3805         * rust-exp.y: Fix common/ includes.
3806         * rs6000-aix-tdep.c: Fix common/ includes.
3807         * riscv-tdep.c: Fix common/ includes.
3808         * remote.c: Fix common/ includes.
3809         * remote-notif.h: Fix common/ includes.
3810         * remote-fileio.h: Fix common/ includes.
3811         * remote-fileio.c: Fix common/ includes.
3812         * regcache.h: Fix common/ includes.
3813         * regcache.c: Fix common/ includes.
3814         * record-btrace.c: Fix common/ includes.
3815         * python/python.c: Fix common/ includes.
3816         * python/py-type.c: Fix common/ includes.
3817         * python/py-inferior.c: Fix common/ includes.
3818         * progspace.h: Fix common/ includes.
3819         * producer.c: Fix common/ includes.
3820         * procfs.c: Fix common/ includes.
3821         * proc-api.c: Fix common/ includes.
3822         * printcmd.c: Fix common/ includes.
3823         * ppc-linux-nat.c: Fix common/ includes.
3824         * parser-defs.h: Fix common/ includes.
3825         * osdata.c: Fix common/ includes.
3826         * obsd-nat.c: Fix common/ includes.
3827         * nat/x86-linux.c: Fix common/ includes.
3828         * nat/x86-linux-dregs.c: Fix common/ includes.
3829         * nat/x86-dregs.h: Fix common/ includes.
3830         * nat/x86-dregs.c: Fix common/ includes.
3831         * nat/ppc-linux.c: Fix common/ includes.
3832         * nat/mips-linux-watch.h: Fix common/ includes.
3833         * nat/mips-linux-watch.c: Fix common/ includes.
3834         * nat/linux-waitpid.c: Fix common/ includes.
3835         * nat/linux-ptrace.h: Fix common/ includes.
3836         * nat/linux-ptrace.c: Fix common/ includes.
3837         * nat/linux-procfs.c: Fix common/ includes.
3838         * nat/linux-personality.c: Fix common/ includes.
3839         * nat/linux-osdata.c: Fix common/ includes.
3840         * nat/linux-namespaces.c: Fix common/ includes.
3841         * nat/linux-btrace.h: Fix common/ includes.
3842         * nat/linux-btrace.c: Fix common/ includes.
3843         * nat/fork-inferior.c: Fix common/ includes.
3844         * nat/amd64-linux-siginfo.c: Fix common/ includes.
3845         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
3846         * nat/aarch64-linux.c: Fix common/ includes.
3847         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
3848         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
3849         * namespace.h: Fix common/ includes.
3850         * mips-linux-tdep.c: Fix common/ includes.
3851         * minsyms.c: Fix common/ includes.
3852         * mi/mi-parse.h: Fix common/ includes.
3853         * mi/mi-main.c: Fix common/ includes.
3854         * mi/mi-cmd-env.c: Fix common/ includes.
3855         * memrange.h: Fix common/ includes.
3856         * memattr.c: Fix common/ includes.
3857         * maint.h: Fix common/ includes.
3858         * maint.c: Fix common/ includes.
3859         * main.c: Fix common/ includes.
3860         * machoread.c: Fix common/ includes.
3861         * location.c: Fix common/ includes.
3862         * linux-thread-db.c: Fix common/ includes.
3863         * linux-nat.c: Fix common/ includes.
3864         * linux-fork.c: Fix common/ includes.
3865         * inline-frame.c: Fix common/ includes.
3866         * infrun.c: Fix common/ includes.
3867         * inflow.c: Fix common/ includes.
3868         * inferior.h: Fix common/ includes.
3869         * inferior.c: Fix common/ includes.
3870         * infcmd.c: Fix common/ includes.
3871         * inf-ptrace.c: Fix common/ includes.
3872         * inf-child.c: Fix common/ includes.
3873         * ia64-linux-nat.c: Fix common/ includes.
3874         * i387-tdep.c: Fix common/ includes.
3875         * i386-tdep.c: Fix common/ includes.
3876         * i386-linux-tdep.c: Fix common/ includes.
3877         * i386-linux-nat.c: Fix common/ includes.
3878         * i386-go32-tdep.c: Fix common/ includes.
3879         * i386-fbsd-tdep.c: Fix common/ includes.
3880         * i386-fbsd-nat.c: Fix common/ includes.
3881         * guile/scm-type.c: Fix common/ includes.
3882         * guile/guile.c: Fix common/ includes.
3883         * go32-nat.c: Fix common/ includes.
3884         * gnu-nat.c: Fix common/ includes.
3885         * gdbthread.h: Fix common/ includes.
3886         * gdbarch-selftests.c: Fix common/ includes.
3887         * gdb_usleep.c: Fix common/ includes.
3888         * gdb_select.h: Fix common/ includes.
3889         * gdb_bfd.c: Fix common/ includes.
3890         * gcore.c: Fix common/ includes.
3891         * fork-child.c: Fix common/ includes.
3892         * findvar.c: Fix common/ includes.
3893         * fbsd-nat.c: Fix common/ includes.
3894         * event-top.c: Fix common/ includes.
3895         * event-loop.c: Fix common/ includes.
3896         * dwarf2read.c: Fix common/ includes.
3897         * dwarf2loc.c: Fix common/ includes.
3898         * dwarf2-frame.c: Fix common/ includes.
3899         * dwarf-index-cache.c: Fix common/ includes.
3900         * dtrace-probe.c: Fix common/ includes.
3901         * disasm-selftests.c: Fix common/ includes.
3902         * defs.h: Fix common/ includes.
3903         * csky-tdep.c: Fix common/ includes.
3904         * cp-valprint.c: Fix common/ includes.
3905         * cp-support.h: Fix common/ includes.
3906         * cp-support.c: Fix common/ includes.
3907         * corelow.c: Fix common/ includes.
3908         * completer.h: Fix common/ includes.
3909         * completer.c: Fix common/ includes.
3910         * compile/compile.c: Fix common/ includes.
3911         * compile/compile-loc2c.c: Fix common/ includes.
3912         * compile/compile-cplus-types.c: Fix common/ includes.
3913         * compile/compile-cplus-symbols.c: Fix common/ includes.
3914         * command.h: Fix common/ includes.
3915         * cli/cli-dump.c: Fix common/ includes.
3916         * cli/cli-cmds.c: Fix common/ includes.
3917         * charset.c: Fix common/ includes.
3918         * build-id.c: Fix common/ includes.
3919         * btrace.h: Fix common/ includes.
3920         * btrace.c: Fix common/ includes.
3921         * breakpoint.h: Fix common/ includes.
3922         * breakpoint.c: Fix common/ includes.
3923         * ax.h: 
3924         (enum agent_op): Fix common/ includes.
3925         * ax-general.c (struct aop_map): Fix common/ includes.
3926         * ax-gdb.c: Fix common/ includes.
3927         * auxv.c: Fix common/ includes.
3928         * auto-load.c: Fix common/ includes.
3929         * arm-tdep.c: Fix common/ includes.
3930         * arch/riscv.c: Fix common/ includes.
3931         * arch/ppc-linux-common.c: Fix common/ includes.
3932         * arch/i386.c: Fix common/ includes.
3933         * arch/arm.c: Fix common/ includes.
3934         * arch/arm-linux.c: Fix common/ includes.
3935         * arch/arm-get-next-pcs.c: Fix common/ includes.
3936         * arch/amd64.c: Fix common/ includes.
3937         * arch/aarch64.c: Fix common/ includes.
3938         * arch/aarch64-insn.c: Fix common/ includes.
3939         * arch-utils.c: Fix common/ includes.
3940         * amd64-windows-tdep.c: Fix common/ includes.
3941         * amd64-tdep.c: Fix common/ includes.
3942         * amd64-sol2-tdep.c: Fix common/ includes.
3943         * amd64-obsd-tdep.c: Fix common/ includes.
3944         * amd64-nbsd-tdep.c: Fix common/ includes.
3945         * amd64-linux-tdep.c: Fix common/ includes.
3946         * amd64-linux-nat.c: Fix common/ includes.
3947         * amd64-fbsd-tdep.c: Fix common/ includes.
3948         * amd64-fbsd-nat.c: Fix common/ includes.
3949         * amd64-dicos-tdep.c: Fix common/ includes.
3950         * amd64-darwin-tdep.c: Fix common/ includes.
3951         * agent.c: Fix common/ includes.
3952         * ada-lang.h: Fix common/ includes.
3953         * ada-lang.c: Fix common/ includes.
3954         * aarch64-tdep.c: Fix common/ includes.
3955
3956 2019-01-25  Tom Tromey  <tom@tromey.com>
3957
3958         * common/create-version.sh: Use common/version.h.
3959
3960 2019-01-24  Pedro Alves  <palves@redhat.com>
3961
3962         * infrun.c (signal_stop, signal_print, signal_program)
3963         (signal_catch, signal_pass): Now arrays instead of pointers.
3964         (update_signals_program_target, do_target_resume)
3965         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
3966         * linux-nat.c (linux_nat_target::pass_signals)
3967         (linux_nat_target::create_inferior, linux_nat_target::attach):
3968         Adjust.
3969         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
3970         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
3971         * procfs.c (procfs_target::pass_signals): Adjust.
3972         * record-full.c (record_full_target::resume): Adjust.
3973         * remote.c (remote_target::pass_signals)
3974         (remote_target::program_signals): Adjust.
3975         * target-debug.h (target_debug_print_signals): Now takes a
3976         gdb::array_view as parameter.  Adjust.
3977         * target.h (target_ops) <pass_signals, program_signals>: Replace
3978         pointer and length parameters with gdb::array_view.
3979         (target_pass_signals, target_program_signals): Likewise.
3980         * target-delegates.c: Regenerate.
3981
3982 2019-01-24  Pedro Alves  <palves@redhat.com>
3983
3984         * common/forward-scope-exit.h
3985         (forward_scope_exit::forward_scope_exit): Pass arguments to
3986         m_bind_function directly, instead of creating a std::bind and
3987         copying that.
3988
3989 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
3990
3991         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
3992         for static members.
3993         (pass_in_v_vfp_candidate): Likewise.
3994
3995 2019-01-23  Tom Tromey  <tom@tromey.com>
3996             Pedro Alves  <palves@redhat.com>
3997
3998         * regcache.c (class regcache_invalidator): Remove.
3999         (regcache::raw_write): Use make_scope_exit.
4000
4001 2019-01-23  Tom Tromey  <tom@tromey.com>
4002
4003         * ui-out.h (class ui_out_emit_type): Update comment.
4004
4005 2019-01-23  Tom Tromey  <tom@tromey.com>
4006
4007         * infrun.c (fetch_inferior_event): Update comment.
4008
4009 2019-01-23  Tom Tromey  <tom@tromey.com>
4010             Pedro Alves  <palves@redhat.com>
4011
4012         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
4013         parameter.
4014         (fetch_inferior_event): Use SCOPE_EXIT.
4015
4016
4017 2019-01-23  Tom Tromey  <tom@tromey.com>
4018             Pedro Alves  <palves@redhat.com>
4019
4020         * infrun.c (disable_thread_events): Delete.
4021         (stop_all_threads): Use SCOPE_EXIT.
4022
4023 2019-01-23  Tom Tromey  <tom@tromey.com>
4024             Pedro Alves  <palves@redhat.com>
4025
4026         * symfile.c: Include forward-scope-exit.h.
4027         (clear_symtab_users_cleanup): Replace forward declaration with
4028         a FORWARD_SCOPE_EXIT.
4029         (syms_from_objfile_1): Use the forward_scope_exit and
4030         gdb::optional instead of cleanup_function.
4031         (reread_symbols): Use the forward_scope_exit instead of
4032         cleanup_function.
4033         (clear_symtab_users_cleanup): Remove function.
4034
4035 2019-01-23  Tom Tromey  <tom@tromey.com>
4036             Pedro Alves  <palves@redhat.com>
4037
4038         * linux-nat.c: Include scope-exit.h.
4039         (cleanup_target_stop): Remove.
4040         (linux_nat_target::static_tracepoint_markers_by_strid): Use
4041         SCOPE_EXIT.
4042
4043 2019-01-23  Tom Tromey  <tom@tromey.com>
4044             Pedro Alves  <palves@redhat.com>
4045
4046         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
4047         (call_function_by_hand_dummy): Use SCOPE_EXIT.
4048
4049 2019-01-23  Tom Tromey  <tom@tromey.com>
4050             Andrew Burgess  <andrew.burgess@embecosm.com>
4051             Pedro Alves  <palves@redhat.com>
4052
4053         * infrun.c (fetch_inferior_event): Use scope_exit.
4054         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
4055         * top.c (execute_command): Use scope_exit.
4056         * breakpoint.c (bpstat_do_actions): Use scope_exit.
4057         * utils.c (do_bpstat_clear_actions_cleanup)
4058         (make_bpstat_clear_actions_cleanup): Remove.
4059
4060 2019-01-23  Tom Tromey  <tom@tromey.com>
4061             Pedro Alves  <palves@redhat.com>
4062
4063         * infrun.c: Include "common/scope-exit.h"
4064         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
4065         (wait_for_inferior): Use SCOPE_EXIT.
4066         (fetch_inferior_event): Use scope_exit.
4067
4068 2019-01-23  Tom Tromey  <tom@tromey.com>
4069             Pedro Alves  <palves@redhat.com>
4070
4071         * breakpoint.c (create_breakpoint): Remove cleanup.
4072
4073 2019-01-23  Tom Tromey  <tom@tromey.com>
4074             Andrew Burgess  <andrew.burgess@embecosm.com>
4075             Pedro Alves  <palves@redhat.com>
4076
4077 2019-01-23  Pedro Alves  <palves@redhat.com>
4078
4079         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
4080
4081 2019-01-23  Pedro Alves  <palves@redhat.com>
4082             Andrew Burgess  <andrew.burgess@embecosm.com>
4083
4084         * gdbthread.h: Include "common/forward-scope-exit.h".
4085         (scoped_finish_thread_state): Redefine custom class in terms of
4086         forward_scope_exit.
4087
4088 2019-01-23  Pedro Alves  <palves@redhat.com>
4089             Andrew Burgess  <andrew.burgess@embecosm.com>
4090
4091         * common/forward-scope-exit.h: New file.
4092
4093 2019-01-23  Pedro Alves  <palves@redhat.com>
4094             Andrew Burgess  <andrew.burgess@embecosm.com>
4095             Tom Tromey  <tom@tromey.com>
4096
4097         * common/scope-exit.h: New file.
4098
4099 2019-01-23  Pedro Alves  <palves@redhat.com>
4100
4101         * common/preprocessor.h (ESC): Rename to ...
4102         (ESC_PARENS): ... this.
4103         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
4104         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
4105
4106 2019-01-23  Tom Tromey  <tom@tromey.com>
4107
4108         * language.h (class scoped_switch_to_sym_language_if_auto):
4109         Initialize m_lang in both cases.
4110
4111 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
4112
4113         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
4114         with XCNEW.
4115
4116 2019-01-22  Tom Tromey  <tom@tromey.com>
4117
4118         * corelow.c: Do not include sys/file.h.
4119
4120 2019-01-22  Tom Tromey  <tom@tromey.com>
4121
4122         * tui/tui-wingeneral.h: Include gdb_curses.h.
4123
4124 2019-01-22  Tom Tromey  <tom@tromey.com>
4125
4126         * source-cache.h (class source_cache) <get_source_lines,
4127         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
4128
4129 2019-01-22  Tom Tromey  <tom@tromey.com>
4130
4131         * remote-fileio.h (struct remote_target): Declare.
4132
4133 2019-01-22  Tom Tromey  <tom@tromey.com>
4134
4135         * python/py-arch.c: Do not include py-ref.h.
4136         * python/py-bpevent.c: Do not include py-ref.h.
4137         * python/py-cmd.c: Do not include py-ref.h.
4138         * python/py-continueevent.c: Do not include py-ref.h.
4139         * python/py-event.h: Do not include py-ref.h.
4140         * python/py-evtregistry.c: Do not include py-ref.h.
4141         * python/py-finishbreakpoint.c: Do not include py-ref.h.
4142         * python/py-frame.c: Do not include py-ref.h.
4143         * python/py-framefilter.c: Do not include py-ref.h.
4144         * python/py-function.c: Do not include py-ref.h.
4145         * python/py-infevents.c: Do not include py-ref.h.
4146         * python/py-linetable.c: Do not include py-ref.h.
4147         * python/py-objfile.c: Do not include py-ref.h.
4148         * python/py-param.c: Do not include py-ref.h.
4149         * python/py-prettyprint.c: Do not include py-ref.h.
4150         * python/py-progspace.c: Do not include py-ref.h.
4151         * python/py-symbol.c: Do not include py-ref.h.
4152         * python/py-symtab.c: Do not include py-ref.h.
4153         * python/py-type.c: Do not include py-ref.h.
4154         * python/py-unwind.c: Do not include py-ref.h.
4155         * python/py-utils.c: Do not include py-ref.h.
4156         * python/py-value.c: Do not include py-ref.h.
4157         * python/py-varobj.c: Do not include py-ref.h.
4158         * python/py-xmethods.c: Do not include py-ref.h.
4159         * python/python.c: Do not include py-ref.h.
4160         * varobj.c: Do not include py-ref.h.
4161
4162 2019-01-22  Tom Tromey  <tom@tromey.com>
4163
4164         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
4165         keyword for bcache.
4166
4167 2019-01-22  Tom Tromey  <tom@tromey.com>
4168
4169         * compile/compile-cplus-types.c: Remove a comment by #include.
4170
4171 2019-01-22  Tom Tromey  <tom@tromey.com>
4172
4173         * compile/gcc-c-plugin.h: Include compile-internal.h.
4174
4175 2019-01-22  Tom Tromey  <tom@tromey.com>
4176
4177         * stabsread.c (EXTERN): Do not define.
4178         (symnum, next_symbol_text_func, processing_gcc_compilation)
4179         (within_function, global_sym_chain, global_stabs)
4180         (previous_stab_code, this_object_header_files)
4181         (n_this_object_header_files)
4182         (n_allocated_this_object_header_files): Define.
4183         * stabsread.h (EXTERN): Never define.  Use "extern".
4184
4185 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4186
4187         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
4188         history_value.
4189
4190 2019-01-21  Tom Tromey  <tom@tromey.com>
4191
4192         * ui-out.c: Fix includes.
4193         * tui/tui-source.c: Fix includes.
4194         * target.c: Fix includes.
4195         * remote.c: Fix includes.
4196         * regcache.c: Fix includes.
4197         * python/py-block.c: Fix includes.
4198         * printcmd.c: Fix includes.
4199         * or1k-tdep.c: Fix includes.
4200         * mi/mi-main.c: Fix includes.
4201         * m32r-tdep.c: Fix includes.
4202         * csky-tdep.c: Fix includes.
4203         * compile/compile-cplus-types.c: Fix includes.
4204         * cli/cli-interp.c: Fix includes.
4205
4206 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
4207
4208         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4209         for padding.
4210
4211 2019-01-16  Tom Tromey  <tom@tromey.com>
4212
4213         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
4214         earlier.
4215         (struct objfile) <msymbols_range>: Move from top level.
4216         <msymbols>: New method.
4217         (class objfile_msymbols): Remove.
4218         * symtab.c (default_collect_symbol_completion_matches_break_on):
4219         Update.
4220         * symmisc.c (dump_msymbols): Update.
4221         * stabsread.c (scan_file_globals): Update.
4222         * objc-lang.c (info_selectors_command, info_classes_command)
4223         (find_methods): Update.
4224         * minsyms.c (find_solib_trampoline_target): Update.
4225         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
4226         * coffread.c (coff_symfile_read): Update.
4227         * ada-lang.c (ada_lookup_simple_minsym)
4228         (ada_collect_symbol_completion_matches): Update.
4229
4230 2019-01-16  Tom Tromey  <tom@tromey.com>
4231
4232         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
4233         type.  Remove no-argument constructor.
4234         <iterator::operator++>: Simplify.
4235         <begin>: Update.
4236         <end>: Use minimal_symbol_count.
4237
4238 2019-01-16  Tom Tromey  <tom@tromey.com>
4239
4240         * objfiles.h (struct objfile) <psymtabs>: New method.
4241         (class objfile_psymtabs): Remove.
4242         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
4243         typedef.
4244         <range>: New method.
4245         (require_partial_symbols): Change return type.
4246         * psymtab.c (require_partial_symbols)
4247         (psym_expand_symtabs_matching): Update.
4248         * mdebugread.c (parse_partial_symbols): Update.
4249         * dbxread.c (dbx_end_psymtab): Update.
4250
4251 2019-01-15  Tom Tromey  <tom@tromey.com>
4252
4253         * symtab.c (lookup_objfile_from_block)
4254         (lookup_symbol_in_objfile_symtabs)
4255         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
4256         (find_line_symtab, info_sources_command)
4257         (default_collect_symbol_completion_matches_break_on)
4258         (make_source_files_completion_list): Update.
4259         * symmisc.c (print_objfile_statistics, dump_objfile)
4260         (maintenance_print_symbols, maintenance_info_symtabs)
4261         (maintenance_check_symtabs, maintenance_info_line_tables):
4262         Update.
4263         * source.c (select_source_symtab)
4264         (forget_cached_source_info_for_objfile): Update.
4265         * objfiles.h (class objfile_compunits): Remove.
4266         (struct objfile) <compunits_range>: New typedef.
4267         (compunits): New method.
4268         * objfiles.c (objfile_relocate1): Update.
4269         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4270         * maint.c (count_symtabs_and_blocks): Update.
4271         * linespec.c (iterate_over_all_matching_symtabs): Update.
4272         * cp-support.c (add_symbol_overload_list_qualified): Update.
4273         * coffread.c (coff_symtab_read): Update.
4274         * ada-lang.c (add_nonlocal_symbols)
4275         (ada_collect_symbol_completion_matches)
4276         (ada_add_global_exceptions): Update.
4277
4278 2019-01-15  Tom Tromey  <tom@tromey.com>
4279
4280         * progspace.h (program_space) <objfiles_safe_range>: New
4281         typedef.
4282         <objfiles_safe>: New method.
4283         * objfiles.h (class all_objfiles_safe): Remove.
4284         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
4285         * jit.c (jit_inferior_exit_hook): Update.
4286
4287 2019-01-17  Tom Tromey  <tom@tromey.com>
4288
4289         * progspace.h (program_space) <objfiles_range>: New typedef.
4290         <objfiles>: New method.
4291         <objfiles_head>: Rename from objfiles.
4292         (object_files): Update.
4293         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
4294         * guile/scm-pretty-print.c
4295         (ppscm_find_pretty_printer_from_objfiles): Update.
4296         * guile/scm-objfile.c (gdbscm_objfiles): Update.
4297         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
4298         Update.
4299         * python/py-progspace.c (pspy_get_objfiles): Update.
4300         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4301         Update.
4302         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4303         (objfpy_lookup_objfile_by_build_id): Update.
4304         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4305         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
4306         Update.
4307         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4308         (expand_symtab_containing_pc, lookup_objfile_from_block)
4309         (lookup_static_symbol, basic_lookup_transparent_type)
4310         (find_pc_sect_compunit_symtab, find_symbol_at_address)
4311         (find_line_symtab, info_sources_command)
4312         (default_collect_symbol_completion_matches_break_on)
4313         (make_source_files_completion_list, find_main_name): Update.
4314         * symmisc.c (print_symbol_bcache_statistics)
4315         (print_objfile_statistics, maintenance_print_symbols)
4316         (maintenance_print_msymbols, maintenance_print_objfiles)
4317         (maintenance_info_symtabs, maintenance_check_symtabs)
4318         (maintenance_expand_symtabs, maintenance_info_line_tables):
4319         Update.
4320         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
4321         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
4322         (map_overlay_command, unmap_overlay_command)
4323         (simple_overlay_update, expand_symtabs_matching)
4324         (map_symbol_filenames): Update.
4325         * symfile-debug.c (set_debug_symfile): Update.
4326         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
4327         Update.
4328         * source.c (select_source_symtab, forget_cached_source_info):
4329         Update.
4330         * solib.c (solib_read_symbols): Update.
4331         * solib-spu.c (append_ocl_sos): Update.
4332         * psymtab.c (maintenance_print_psymbols)
4333         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
4334         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
4335         * printcmd.c (info_symbol_command): Update.
4336         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
4337         Update.
4338         * objfiles.h (class all_objfiles): Remove.
4339         * objfiles.c (have_partial_symbols, have_full_symbols)
4340         (have_minimal_symbols, qsort_cmp, update_section_map)
4341         (shared_objfile_contains_address_p)
4342         (default_iterate_over_objfiles_in_search_order): Update.
4343         * objc-lang.c (info_selectors_command, info_classes_command)
4344         (find_methods): Update.
4345         * minsyms.c (find_solib_trampoline_target): Update.
4346         * maint.c (maintenance_info_sections)
4347         (maintenance_translate_address, count_symtabs_and_blocks):
4348         Update.
4349         * main.c (captured_main_1): Update.
4350         * linux-thread-db.c (try_thread_db_load_from_pdir)
4351         (has_libpthread): Update.
4352         * linespec.c (iterate_over_all_matching_symtabs)
4353         (search_minsyms_for_name): Update.
4354         * jit.c (jit_find_objf_with_entry_addr): Update.
4355         * hppa-tdep.c (find_unwind_entry)
4356         (hppa_lookup_stub_minimal_symbol): Update.
4357         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
4358         Update.
4359         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
4360         (elf_gnu_ifunc_resolve_by_got): Update.
4361         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
4362         * dwarf-index-write.c (save_gdb_index_command): Update.
4363         * cp-support.c (add_symbol_overload_list_qualified): Update.
4364         * breakpoint.c (create_overlay_event_breakpoint)
4365         (create_longjmp_master_breakpoint)
4366         (create_std_terminate_master_breakpoint)
4367         (create_exception_master_breakpoint): Update.
4368         * blockframe.c (find_pc_partial_function): Update.
4369         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
4370         (ada_collect_symbol_completion_matches)
4371         (ada_add_global_exceptions): Update.
4372
4373 2019-01-17  Tom Tromey  <tom@tromey.com>
4374
4375         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
4376         declare VEC.
4377         (solib_target_parse_libraries): Change return type.
4378         (library_list_start_segment, library_list_start_section)
4379         (library_list_end_library, library_list_start_library); Update.
4380         (solib_target_free_library_list): Remove.
4381         (solib_target_parse_libraries): Remove cleanup.  Change return
4382         type.
4383         (solib_target_current_sos): Update.
4384
4385 2019-01-17  Tom Tromey  <tromey@bapiya>
4386
4387         * valprint.c: Replace "the the" with "the".
4388         * symtab.c: Replace "the the" with "the".
4389         * solib.c: Replace "the the" with "the".
4390         * solib-dsbt.c: Replace "the the" with "the".
4391         * linespec.c: Replace "the the" with "the".
4392         * dwarf2loc.h: Replace "the the" with "the".
4393         * amd64-windows-tdep.c: Replace "the the" with "the".
4394         * aarch64-tdep.c: Replace "the the" with "the".
4395
4396 2019-01-16  Keith Seitz  <keiths@redhat.com>
4397
4398         PR gdb/23773
4399         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
4400         <builder>: Rename to ..
4401         <m_builder>: ... this and make private.
4402         (dwarf2_cu::get_builder): New method.  Change all users of
4403         `builder' to use this method.
4404         (dwarf2_start_symtab): Move to ...
4405         (dwarf2_cu::start_symtab): ... here.  Update all callers
4406         (setup_type_unit_groups): Move to ...
4407         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
4408         callers.
4409         (dwarf2_cu::reset_builder): New method.
4410         (process_full_compunit, process_full_type_unit): Use
4411         dwarf2_cu::reset_builder.
4412         (follow_die_offset): Record the ancestor CU if it is different
4413         from the followed DIE's CU.
4414         (follow_die_sig_1): Likewise.
4415
4416 2019-01-15  Tom Tromey  <tom@tromey.com>
4417
4418         * remote.c (class remote_state) <buf>: Now a char_vector.
4419         <buf_size>: Remove.
4420         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
4421         parameter.
4422         (remote_target::getpkt_or_notif_sane_1)
4423         (remote_target::getpkt_sane)
4424         (remote_target::getpkt_or_notif_sane): Likewise.
4425         (class remote_target) <putpkt>: New overload.
4426         (remote_target::read_frame): Change type of "buf_p".  Remove
4427         sizeof_p parameter.
4428         (packet_ok): New overload.
4429         (packet_check_result): New overload.
4430         Update all uses.
4431
4432 2019-01-14  Tom Tromey  <tom@tromey.com>
4433
4434         * remote-notif.c (handle_notification, remote_notif_ack)
4435         (remote_notif_parse): Make "buf" const.
4436         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
4437         const.
4438         (remote_notif_parse, remote_notif_ack, handle_notification):
4439         Likewise.
4440         * remote.c (remote_notif_stop_parse): Make "buf" const.
4441         (remote_target::remote_parse_stop_reply): Make "buf" const.
4442         (remote_notif_stop_ack): Make "buf" const.
4443
4444 2019-01-14  Tom Tromey  <tom@tromey.com>
4445
4446         * remote.c (remote_console_output): Make parameter const.
4447
4448 2019-01-14  Tom Tromey  <tom@tromey.com>
4449
4450         * target-debug.h (target_debug_print_signals): Constify.
4451         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
4452         * procfs.c (procfs_target::pass_signals): Update.
4453         * linux-nat.c (linux_nat_target::pass_signals): Update.
4454         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
4455         * target-delegates.c: Rebuild.
4456         * remote.c (remote_target::program_signals): Update.
4457         (remote_target::pass_signals): Update.
4458         * target.c (target_pass_signals): Constify argument.
4459         (target_program_signals): Likewise.
4460         * target.h (struct target_ops) <pass_signals, program_signals>:
4461         Constify argument.
4462         (target_pass_signals, target_program_signals): Constify argument.
4463
4464 2019-01-14  Tom Tromey  <tom@tromey.com>
4465
4466         PR tui/28819:
4467         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
4468
4469 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
4470
4471         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
4472         field.
4473         * rs6000-tdep.c: Include reggroups.h.
4474         (IS_V_ALIAS_PSEUDOREG): Define.
4475         (rs6000_register_name): Return names for the "vX" aliases.
4476         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
4477         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
4478         aliases.  Call default_register_reggroup_p for all other
4479         pseudo-registers.
4480         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
4481         New functions.
4482         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
4483         Handle "vX" aliases.
4484         (v_alias_pseudo_register_collect): New function.
4485         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
4486         (rs6000_gdbarch_init): Initialize "vX" aliases as
4487         pseudo-registers.  Restore registration of
4488         rs6000_pseudo_register_reggroup_p with
4489         set_tdesc_pseudo_register_reggroup_p.
4490
4491 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
4492
4493         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
4494         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
4495         set_gdbarch_num_pseudo_regs.
4496
4497 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4498
4499         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
4500         Remove arg prefixname, add do_set and do_show.
4501         Add member functions set_list and show_list.
4502         * cli/cli-style.c (class cli_style_option): Update accordingly.
4503         (style_set_list): Move to file scope.
4504         (style_show_list): Likewise.
4505         (set_style): Call help_list.
4506         (show_style): Call cmd_show_list.
4507         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
4508         Update to use the new macro.
4509
4510 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
4511
4512         * ada-lang.c (_initialize_ada_language): Expand the help text
4513         for the "catch exception" command.
4514
4515 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4516
4517         * symtab.c (matching_obj_sections): Initialize obj,
4518         declare it closer to its usage.
4519
4520 2019-01-10  Tom Tromey  <tom@tromey.com>
4521
4522         * thread-iter.h (inf_threads_iterator): Use next_iterator.
4523         (basic_inf_threads_range): Remove.
4524         (inf_threads_range, inf_non_exited_threads_range)
4525         (safe_inf_threads_range): Use next_adapter.
4526
4527 2019-01-10  Keith Seitz  <keiths@redhat.com>
4528
4529         PR gdb/23712
4530         PR symtab/23010
4531         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
4532         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
4533
4534 2019-01-10  Keith Seitz  <keiths@redhat.com>
4535
4536         PR gdb/23712
4537         PR symtab/23010
4538         * dictionary.c (pending_to_vector): Remove.
4539         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4540         Remove _1 suffix, replacing functions of the same name.  Update
4541         all callers.
4542         (dict_create_hashed, dict_create_hashed_expandable)
4543         (dict_create_linear, dict_create_linear_expandable, dict_free)
4544         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
4545         Make functions static.
4546
4547 2019-01-10  Keith Seitz  <keiths@redhat.com>
4548
4549         PR gdb/23712
4550         PR symtab/23010
4551         * dictionary.h (struct dictionary): Replace declaration with
4552         multidictionary.
4553         (dict_create_hashed, dict_create_hashed_expandable)
4554         (dict_create_linear, dict_create_linear_expandable)
4555         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
4556         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
4557         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
4558         taking multidictionary argument.
4559         [ALL_DICT_SYMBOLS]: Update for multidictionary.
4560         * block.h (struct block) <dict>: Change to multidictionary
4561         and rename `multidict'.
4562         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
4563         symmisc.c: Update all dictionary references to multidictionary.
4564
4565 2019-01-10  Keith Seitz  <keiths@redhat.com>
4566
4567         PR gdb/23712
4568         PR symtab/23010
4569         * dictionary.c: Include unordered_map.
4570         (pending_to_vector): New function.
4571         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4572         Rewrite the non-"_1" functions to take vector instead
4573         of linked list.
4574         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
4575         "new" _1 versions of the same name.
4576         (multidictionary): Define.
4577         (std::hash<enum language): New definition.
4578         (collate_pending_symbols_by_language, mdict_create_hashed)
4579         (mdict_create_hashed_expandable, mdict_create_linear)
4580         (mdict_create_linear_expandable, mdict_free)
4581         (find_language_dictionary, create_new_language_dictionary)
4582         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
4583         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
4584         (mdict_size, mdict_empty): New functions.
4585         * dictionary.h (mdict_iterator): Define.
4586
4587 2019-01-10  Pedro Alves  <palves@redhat.com>
4588
4589         * breakpoint.c (read_uploaded_action)
4590         (create_tracepoint_from_upload): Adjust to use
4591         gdb::unique_xmalloc_ptr.
4592         * ctf.c (ctf_write_uploaded_tp):
4593         (SET_ARRAY_FIELD): Use emplace_back.
4594         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
4595         * tracefile-tfile.c (tfile_write_uploaded_tp):
4596         * tracepoint.c (parse_tracepoint_definition): Adjust to use
4597         gdb::unique_xmalloc_ptr.
4598         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
4599         at_string, cond_string, cmd_strings>: Replace char pointers
4600         with gdb::unique_xmalloc_ptr.
4601
4602 2019-01-10  Pedro Alves  <palves@redhat.com>
4603
4604         * solib-target.c (library_list_start_library): Don't xstrdup name.
4605
4606 2019-01-10  Pedro Alves  <palves@redhat.com>
4607
4608         * mdebugread.c (parse_partial_symbols): Use
4609         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
4610
4611 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4612
4613         * linux-fork.c (scoped_switch_fork_info)
4614         <~scoped_switch_fork_info>: Fix incorrect variable name.
4615
4616 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4617
4618         * linux-fork.c (scoped_switch_fork_info)
4619         <scoped_switch_fork_info>: Make explicit.
4620         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
4621
4622 2019-01-10  Tom Tromey  <tom@tromey.com>
4623
4624         * objfiles.h (objfile::reset_psymtabs): Update.
4625         * objfiles.c (objfile::objfile): Update.
4626         * psymtab.h (psymtab_storage::obstack): Update.
4627         (psymtab_storage::m_obstack): Use gdb::optional.
4628         (class psymtab_storage): Update comment.  Remove objfile
4629         parameter.
4630         * psymtab.c (psymtab_storage::psymtab_storage): Update.
4631
4632 2019-01-10  Tom Tromey  <tom@tromey.com>
4633
4634         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
4635         <free_psymtabs>: Now private.
4636         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
4637         (allocate_psymtab): Use new method.
4638
4639 2019-01-10  Tom Tromey  <tom@tromey.com>
4640
4641         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
4642         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
4643         * mdebugread.c (parse_partial_symbols): Use
4644         allocate_dependencies.
4645         * dwarf2read.c (dwarf2_create_include_psymtab): Use
4646         allocate_dependencies.
4647         (process_psymtab_comp_unit_reader)
4648         (build_type_psymtab_dependencies): Likewise.
4649         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
4650
4651 2019-01-10  Tom Tromey  <tom@tromey.com>
4652
4653         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
4654         PSYMBOL_SET_LANGUAGE.
4655         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
4656
4657 2019-01-10  Tom Tromey  <tom@tromey.com>
4658
4659         * psymtab.h (psymtab_storage::obstack): New method.
4660         <m_obstack>: Rename from obstack; now private.
4661         * psymtab.c (psymtab_storage): Update.
4662         * dwarf2read.c (create_addrmap_from_index)
4663         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
4664         Update.
4665
4666 2019-01-10  Tom Tromey  <tom@tromey.com>
4667
4668         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
4669         * objfiles.h (objfile::reset_psymtabs): New method.
4670
4671 2019-01-10  Tom Tromey  <tom@tromey.com>
4672
4673         * symmisc.c (print_symbol_bcache_statistics): Update.
4674         (print_objfile_statistics): Update.
4675         * symfile.c (reread_symbols): Update.
4676         * psymtab.h (class psymtab_storage): New.
4677         * psymtab.c (psymtab_storage): New constructor.
4678         (~psymtab_storage): New destructor.
4679         (require_partial_symbols): Update.
4680         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
4681         (find_pc_sect_psymtab, find_pc_sect_psymbol)
4682         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
4683         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
4684         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
4685         (start_psymtab_common, end_psymtab_common)
4686         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
4687         (allocate_psymtab): Update.
4688         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
4689         Update.
4690         (dump_psymtab_addrmap, maintenance_print_psymbols)
4691         (maintenance_check_psymtabs): Update.
4692         (class objfile_psymtabs): Move to objfiles.h.
4693         * psympriv.h (discard_psymtab): Now inline.
4694         (psymtab_discarder::psymtab_discarder): Update.
4695         (psymtab_discarder::~psymtab_discarder): Update.
4696         (ALL_OBJFILE_PSYMTABS): Rewrite.
4697         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
4698         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
4699         Remove fields.
4700         <partial_symtabs>: New field.
4701         (class objfile_psymtabs): Move from psymtab.h.  Update.
4702         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
4703         psymbol_cache.
4704         (objfile::~objfile): Don't destroy psymbol_cache.
4705         * mdebugread.c (parse_partial_symbols): Update.
4706         * dwarf2read.c (create_addrmap_from_index)
4707         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
4708         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
4709         (add_partial_subprogram, dwarf2_ranges_read): Update.
4710         * dwarf-index-write.c (write_address_map)
4711         (write_one_signatured_type, recursively_write_psymbols)
4712         (class debug_names, class debug_names, write_psymtabs_to_index):
4713         Update.
4714
4715 2019-01-10  Tom Tromey  <tom@tromey.com>
4716
4717         * symtab.h (SYMBOL_SET_NAMES): Update.
4718         (symbol_set_names): Update.
4719         (MSYMBOL_SET_NAMES): Update.
4720         * symtab.c (symbol_set_names): Change argument to be an
4721         objfile_per_bfd_storage.
4722         * psymtab.c (add_psymbol_to_bcache): Update.
4723         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
4724
4725 2019-01-10  Tom Tromey  <tom@tromey.com>
4726
4727         * symtab.c (create_demangled_names_hash): Change argument to be an
4728         objfile_per_bfd_storage.
4729         (symbol_set_names): Update.
4730
4731 2019-01-10  Tom Tromey  <tom@tromey.com>
4732
4733         * xcoffread.c (xcoff_initial_scan): Unconditionally call
4734         init_psymbol_list.
4735         * psymtab.c (init_psymbol_list): Do nothing if already called.
4736         * psympriv.h (init_psymbol_list): Add comment.
4737         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
4738         init_psymbol_list.
4739         * dbxread.c (dbx_symfile_read): Unconditionally call
4740         init_psymbol_list.
4741
4742 2019-01-10  Tom Tromey  <tom@tromey.com>
4743
4744         * xcoffread.c (scan_xcoff_symtab): Update.
4745         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
4746         "where".
4747         * mdebugread.c (parse_partial_symbols)
4748         (handle_psymbol_enumerators): Update.
4749         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
4750         * dbxread.c (read_dbx_symtab): Update.
4751         * psympriv.h (psymbol_placement): New enum.
4752         (add_psymbol_to_list): Update.
4753
4754 2019-01-10  Tom Tromey  <tom@tromey.com>
4755
4756         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
4757         static_psymbols parameters.
4758         (scan_xcoff_symtab): Update.
4759         * psymtab.c (start_psymtab_common): Remove global_psymbols and
4760         static_psymbols parameters.
4761         * psympriv.h (start_psymtab_common): Update.
4762         * mdebugread.c (parse_partial_symbols): Update.
4763         * dwarf2read.c (create_partial_symtab): Update.
4764         * dbxread.c (read_dbx_symtab): Update.
4765         (start_psymtab): Remove global_psymbols and static_psymbols
4766         parameters.
4767
4768 2019-01-10  Tom Tromey  <tom@tromey.com>
4769
4770         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
4771         * psymtab.c (allocate_psymtab): Add comment.
4772         * psympriv.h (allocate_psymtab): Add comment.
4773         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
4774         initializations.
4775         * dbxread.c (dbx_end_psymtab): Remove some initializations.
4776
4777 2019-01-10  Tom Tromey  <tom@tromey.com>
4778
4779         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4780         Don't declare.
4781         * mipsread.c: Include mdebugread.h.
4782         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4783         Declare.
4784         * elfread.c: Include mdebugread.h.
4785
4786 2019-01-09  Tom Tromey  <tom@tromey.com>
4787
4788         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
4789         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
4790         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
4791         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
4792         (psym_lookup_symbol, psym_find_last_source_symtab)
4793         (psym_forget_cached_source_info, psym_print_stats)
4794         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
4795         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
4796         (psym_map_matching_symbols, psym_expand_symtabs_matching)
4797         (psym_find_compunit_symtab_by_address)
4798         (maintenance_print_psymbols, maintenance_info_psymtabs)
4799         (maintenance_check_psymtabs): Use ranged for.
4800         * psymtab.h (class objfile_psymtabs): New.
4801         (require_partial_symbols): Return objfile_psymtabs.
4802         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
4803
4804 2019-01-09  Tom Tromey  <tom@tromey.com>
4805
4806         * symfile.c (overlay_invalidate_all, find_pc_overlay)
4807         (find_pc_mapped_section, list_overlays_command)
4808         (map_overlay_command, unmap_overlay_command)
4809         (simple_overlay_update): Use all_objfiles.
4810         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
4811         * printcmd.c (info_symbol_command): Use all_objfiles.
4812         * objfiles.h (ALL_OBJSECTIONS): Remove.
4813         * maint.c (maintenance_translate_address): Use all_objfiles.
4814         * gcore.c (gcore_create_callback): Use all_objfiles.
4815         (objfile_find_memory_regions): Likewise.
4816
4817 2019-01-09  Tom Tromey  <tom@tromey.com>
4818
4819         * symtab.c (find_line_symtab, info_sources_command)
4820         (make_source_files_completion_list): Use objfile_compunits.
4821         * source.c (select_source_symtab): Use objfile_compunits.
4822         * objfiles.h (struct objfile): Update comment.
4823         (ALL_OBJFILES): Remove.
4824         (ALL_FILETABS): Remove.
4825         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
4826         objfile_compunits.
4827
4828 2019-01-09  Tom Tromey  <tom@tromey.com>
4829
4830         * symmisc.c (print_objfile_statistics, dump_objfile)
4831         (maintenance_print_symbols): Use compunit_filetabs.
4832         * source.c (forget_cached_source_info_for_objfile): Use
4833         compunit_filetabs.
4834         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
4835         (ALL_FILETABS): Use compunit_filetabs.
4836         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
4837         * coffread.c (coff_symtab_read): Use compunit_filetabs.
4838
4839 2019-01-09  Tom Tromey  <tom@tromey.com>
4840
4841         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
4842         (compunit_filetabs): New.
4843         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
4844         compunit_filetabs.
4845         (info_sources_command, make_source_files_completion_list): Remove
4846         declaration.
4847         * symmisc.c (print_objfile_statistics, dump_objfile)
4848         (maintenance_print_symbols): Remove declaration.
4849         (maintenance_info_symtabs): Use compunit_filetabs.
4850         (maintenance_info_line_tables): Likewise.
4851         * source.c (select_source_symtab): Change local variable name.
4852         (forget_cached_source_info_for_objfile): Remove declaration.
4853         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
4854         * objfiles.c (objfile_relocate1): Remove declaration.
4855         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4856         declaration.
4857         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
4858         * coffread.c (coff_symtab_read): Remove declaration.
4859         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
4860         compunit_filetabs.
4861
4862 2019-01-09  Tom Tromey  <tom@tromey.com>
4863
4864         * symtab.c (lookup_objfile_from_block)
4865         (find_pc_sect_compunit_symtab, search_symbols)
4866         (default_collect_symbol_completion_matches_break_on): Use
4867         objfile_compunits.
4868         * objfiles.h (ALL_COMPUNITS): Remove.
4869         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
4870         * cp-support.c (add_symbol_overload_list_qualified): Use
4871         objfile_compunits.
4872         * ada-lang.c (ada_collect_symbol_completion_matches)
4873         (ada_add_global_exceptions): Use objfile_compunits.
4874
4875 2019-01-09  Tom Tromey  <tom@tromey.com>
4876
4877         * source.c (select_source_symtab)
4878         (forget_cached_source_info_for_objfile): Remove declaration.
4879         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4880         declaration.
4881         * maint.c (count_symtabs_and_blocks): Remove declaration.
4882         * cp-support.c (add_symbol_overload_list_qualified): Remove
4883         declaration.
4884         * coffread.c (coff_symtab_read): Remove declaration.
4885         * symtab.c (lookup_symbol_in_objfile_symtabs)
4886         (basic_lookup_transparent_type_1): Use objfile_compunits.
4887         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
4888         (info_sources_command, search_symbols)
4889         (default_collect_symbol_completion_matches_break_on)
4890         (make_source_files_completion_list): Remove declaration.
4891         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
4892         (ada_collect_symbol_completion_matches)
4893         (ada_add_global_exceptions): Remove declaration.
4894         * linespec.c (iterate_over_all_matching_symtabs): Use
4895         objfile_compunits.
4896         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
4897         (class objfile_compunits): New.
4898         (ALL_COMPUNITS): Use objfile_compunits.
4899         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
4900         (maintenance_check_symtabs, maintenance_info_line_tables): Use
4901         objfile_compunits.
4902         * objfiles.c (objfile_relocate1): Use objfile_compunits.
4903
4904 2019-01-09  Tom Tromey  <tom@tromey.com>
4905
4906         * symtab.c (search_symbols)
4907         (default_collect_symbol_completion_matches_break_on): Use
4908         objfile_msymbols.
4909         * ada-lang.c (ada_lookup_simple_minsym)
4910         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
4911         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
4912         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
4913         objfile_msymbols.
4914         * coffread.c (coff_symfile_read): Use objfile_msymbols.
4915         * symmisc.c (dump_msymbols): Use objfile_msymbols.
4916         * objc-lang.c (find_methods): Use objfile_msymbols.
4917         (info_selectors_command, info_classes_command): Likewise.
4918         * stabsread.c (scan_file_globals): Use objfile_msymbols.
4919         * objfiles.h (class objfile_msymbols): New.
4920         (ALL_OBJFILE_MSYMBOLS): Remove.
4921         (ALL_MSYMBOLS): Remove.
4922
4923 2019-01-09  Tom Tromey  <tom@tromey.com>
4924
4925         * common/next-iterator.h (next_adapter): Add Iterator template
4926         parameter.
4927         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
4928         (class all_objfiles_safe): New.
4929         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
4930         * objfiles.c (put_objfile_before): Update comment.
4931         (add_separate_debug_objfile): Likewise.
4932         (free_all_objfiles): Use all_objfiles_safe.
4933         (objfile_purge_solibs): Likewise.
4934
4935 2019-01-09  Tom Tromey  <tom@tromey.com>
4936
4937         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4938         (expand_symtab_containing_pc, lookup_static_symbol)
4939         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
4940         (find_symbol_at_address, find_line_symtab, find_main_name): Use
4941         all_objfiles.
4942         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
4943         * breakpoint.c (create_overlay_event_breakpoint)
4944         (create_longjmp_master_breakpoint)
4945         (create_std_terminate_master_breakpoint)
4946         (create_exception_master_breakpoint): Use all_objfiles.
4947         * linux-thread-db.c (try_thread_db_load_from_pdir)
4948         (has_libpthread): Use all_objfiles.
4949         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
4950         * linespec.c (iterate_over_all_matching_symtabs)
4951         (search_minsyms_for_name): Use all_objfiles.
4952         * maint.c (maintenance_info_sections): Use all_objfiles.
4953         * main.c (captured_main_1): Use all_objfiles.
4954         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
4955         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
4956         * guile/scm-pretty-print.c
4957         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
4958         * solib-spu.c (append_ocl_sos): Use all_objfiles.
4959         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
4960         (maintenance_print_msymbols): Use all_objfiles.
4961         * source.c (select_source_symtab): Use all_objfiles.
4962         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
4963         * symfile.c (remove_symbol_file_command)
4964         (expand_symtabs_matching, map_symbol_filenames): Use
4965         all_objfiles.
4966         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
4967         all_objfiles.
4968         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
4969         * objc-lang.c (find_methods): Use all_objfiles.
4970         * objfiles.c (have_partial_symbols, have_full_symbols)
4971         (have_minimal_symbols, qsort_cmp)
4972         (default_iterate_over_objfiles_in_search_order): Use
4973         all_objfiles.
4974         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
4975         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
4976         (maintenance_check_psymtabs): Use all_objfiles.
4977         (ALL_PSYMTABS): Remove.
4978         * compile/compile-object-run.c (do_module_cleanup): Use
4979         all_objfiles.
4980         * blockframe.c (find_pc_partial_function): Use all_objfiles.
4981         * cp-support.c (add_symbol_overload_list_qualified): Use
4982         all_objfiles.
4983         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
4984         Use all_objfiles.
4985         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
4986         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
4987         all_objfiles.
4988         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4989         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
4990         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4991         Uses all_objfiles.
4992         * solib.c (solib_read_symbols): Use all_objfiles
4993
4994 2019-01-09  Tom Tromey  <tom@tromey.com>
4995
4996         * probe.c (parse_probes_in_pspace): Use all_objfiles.
4997         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
4998         all_objfiles.
4999         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
5000         * symmisc.c (print_symbol_bcache_statistics)
5001         (print_objfile_statistics, maintenance_print_objfiles)
5002         (maintenance_info_symtabs, maintenance_check_symtabs)
5003         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
5004         all_objfiles.
5005         * source.c (forget_cached_source_info): Use all_objfiles.
5006         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
5007         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5008         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
5009         * objfiles.c (update_section_map): Use all_objfiles.
5010         (shared_objfile_contains_address_p): Likewise.
5011         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
5012         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
5013
5014 2019-01-09  Tom Tromey  <tom@tromey.com>
5015
5016         * common/next-iterator.h: New file.
5017         * objfiles.h (class all_objfiles): New.
5018         (struct objfile_iterator): New.
5019
5020 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5021
5022         * NEWS: Move the description of the changed "frame", "select-frame",
5023          and "info frame" commands to the Changed commands section.
5024
5025 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
5026
5027         * gdbtypes.c (check_stub_method_group): Remove handling of old
5028         mangling schemes.
5029         * linespec.c (find_methods): Likewise.
5030         * stabsread.c (read_member_functions): Likewise.
5031         * valops.c (search_struct_method): Likewise.
5032         (value_struct_elt_for_reference): Likewise.
5033         * NEWS: Mention this change.
5034
5035 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5036
5037         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
5038         print_source_lines.
5039         * source.c (print_source_lines_base): Update line number check.
5040         (print_source_lines): New function.
5041         (source_lines_range::source_lines_range): New function.
5042         * source.h (class source_lines_range): New class.
5043         (print_source_lines): New declaration.
5044
5045 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5046
5047         * linespec.c (linespec_state_destructor): Free self->canonical_names.
5048
5049 2019-01-08  Tom Tromey  <tom@tromey.com>
5050             Simon Marchi  <simon.marchi@ericsson.com>
5051
5052         PR gdb/24060
5053         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
5054         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
5055         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5056         * f-exp.y (DOLLAR_VARIABLE): Likewise.
5057         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
5058         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5059
5060 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5061
5062         * source.c (select_source_symtab): Move header comment to
5063         declaration in source.h.
5064         (forget_cached_source_info_for_objfile): Likewise.
5065         (forget_cached_source_info): Likewise.
5066         (identify_source_line): Likewise.
5067         * source.h (identify_source_line): Move declaration from symtab.h
5068         and add comment from source.c
5069         (print_source_lines): Likewise.
5070         (forget_cached_source_info_for_objfile): Likewise.
5071         (forget_cached_source_info): Likewise.
5072         (select_source_symtab): Likewise.
5073         (enum print_source_lines_flag): Move definition from symtab.h.
5074         * symtab.h (identify_source_line): Move declaration to source.h.
5075         (print_source_lines): Likewise.
5076         (forget_cached_source_info_for_objfile): Likewise.
5077         (forget_cached_source_info): Likewise.
5078         (select_source_symtab): Likewise.
5079         (enum print_source_lines_flag): Move definition to source.h.
5080         * tui/tui-hooks.c: Add 'source.h' include.
5081
5082 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5083
5084         * source.c (print_source_lines_base): Handle requests to print
5085         reverse line number sequences, and guard against empty lines
5086         string.
5087
5088 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5089
5090         * source.c (print_source_lines_base): Fix skip of '\r' if next
5091         character is '\n'.
5092
5093 2019-01-06  Tom Tromey  <tom@tromey.com>
5094
5095         * c-exp.y (struct c_parse_state) <macro_original_text,
5096         expansion_obstack>: New member.
5097         (macro_original_text, expansion_obstack): Remove globals.
5098         (scan_macro_expansion, scanning_macro_expansion)
5099         (finished_macro_expansion): Update.
5100         (scan_macro_cleanup): Remove.
5101         (yylex, c_parse): Update.
5102
5103 2019-01-06  Tom Tromey  <tom@tromey.com>
5104
5105         * c-exp.y (struct c_parse_state) <strings>: New member.
5106         (operator_stoken): Update.
5107
5108 2019-01-06  Tom Tromey  <tom@tromey.com>
5109
5110         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
5111         (union type_stack_elt) <typelist_val>: Now a pointer to
5112         std::vector.
5113         (type_stack_cleanup): Don't declare.
5114         (push_typelist): Update.
5115         * parse.c (pop_typelist): Return a std::vector.
5116         (push_typelist): Take a std::vector.
5117         (follow_types): Update.  Do not free args.
5118         (type_stack_cleanup): Remove.
5119         * c-exp.y (struct c_parse_state): New.
5120         (cpstate): New global.
5121         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
5122         (nonempty_typelist): Update.
5123         (func_mod): Create a new vector.
5124         (c_parse): Create a c_parse_state.
5125         (check_parameter_typelist): Do not delete params.
5126         (function_method): Update.  Do not delete type_list.
5127
5128 2019-01-06  Tom Tromey  <tom@tromey.com>
5129
5130         PR gdb/28155:
5131         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
5132         check_typedef.
5133         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
5134         (print_return_value): Likewise.
5135
5136 2019-01-05  Tom Tromey  <tom@tromey.com>
5137
5138         * contrib/cleanup_check.py: Remove.
5139         * contrib/gcc-with-excheck: Remove.
5140         * contrib/exsummary.py: Remove.
5141         * contrib/excheck.py: Remove.
5142
5143 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
5144
5145         * thread.c (delete_thread_1): Add gdb_assert that THR is not
5146         NULL. Initialize tpprev to NULL instead of assigning it
5147         to NULL on the next statement.
5148         * windows-nat.c (windows_delete_thread): Remove check for
5149         main_thread_id before printing thread exit notifications.
5150         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
5151         Remove thread ID check against main_thread_id.
5152         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
5153         windows_delete_thread.
5154         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
5155
5156 2019-01-04  Tom Tromey  <tom@tromey.com>
5157
5158         * compile/compile.c (_initialize_compile): Use upper case for
5159         metasyntactic variables.
5160         * symmisc.c (_initialize_symmisc): Use upper case for
5161         metasyntactic variables.
5162         * psymtab.c (_initialize_psymtab): Use upper case for
5163         metasyntactic variables.
5164         * demangle.c (demangle_command): Use upper case for metasyntactic
5165         variables.
5166         (_initialize_demangler): Likewise.
5167         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
5168         variables.
5169
5170 2019-01-03  Tom Tromey  <tom@tromey.com>
5171
5172         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
5173
5174 2019-01-03  Tom Tromey  <tom@tromey.com>
5175
5176         * python/py-symtab.c (salpy_str): Update.
5177         (struct salpy_sal_object) <symtab>: Now a PyObject.
5178         (salpy_dealloc): Update.
5179         (del_objfile_sal): Use gdbpy_ref.
5180
5181 2019-01-03  Tom Tromey  <tom@tromey.com>
5182
5183         * python/py-type.c (convert_field): Use new_reference.  Return
5184         gdbpy_ref.
5185         (make_fielditem): Return gdbpy_ref.
5186         (typy_fields): Update.
5187         (typy_getitem): Update.
5188         (field_name): Return gdbpy_ref.  Use new_reference.
5189         (typy_iterator_iternext): Update.
5190
5191 2019-01-03  Tom Tromey  <tom@tromey.com>
5192
5193         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
5194
5195 2019-01-03  Tom Tromey  <tom@tromey.com>
5196
5197         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
5198         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
5199         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
5200         (pspy_set_frame_filters, pspy_set_frame_unwinders)
5201         (pspy_set_type_printers): Likewise.
5202         * python/py-function.c (fnpy_init): Use gdbpy_ref.
5203         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
5204         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
5205         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
5206         (objfpy_set_type_printers): Likewise.
5207
5208 2019-01-03  Tom Tromey  <tom@tromey.com>
5209
5210         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
5211         (gdbpy_print_stack): Use gdbpy_err_fetch.
5212         * python/python-internal.h (class gdbpy_err_fetch): New class.
5213         (class gdbpy_enter) <m_error_type, m_error_value,
5214         m_error_traceback>: Remove.
5215         <m_error>: New member.
5216         (gdbpy_exception_to_string): Don't declare.
5217         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
5218         * python/py-value.c (convert_value_from_python): Use
5219         gdbpy_err_fetch.
5220         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
5221         gdbpy_exception_to_string.
5222         (gdbpy_handle_exception): Use gdbpy_err_fetch.
5223         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
5224         gdbpy_err_fetch.
5225
5226 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5227
5228         * linux-nat.c (delete_lwp_cleanup): Delete.
5229         (struct lwp_deleter): New struct.
5230         (lwp_info_up): New typedef.
5231         (linux_nat_target::follow_fork): Delete cleanup, and make use of
5232         lwp_info_up.
5233
5234 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5235
5236         * linux-fork.c (class scoped_switch_fork_info): New class.
5237         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
5238
5239 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5240
5241         * valops.c (find_overload_match): Remove use of null_cleanup, and
5242         calls to do_cleanups.
5243
5244 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5245
5246         * compile/compile-cplus-types.c
5247         (compile_cplus_instance::decl_name): Handle changes to
5248         cp_func_name.
5249         * cp-support.c (cp_func_name): Update header comment, update
5250         return type.
5251         * cp-support.h (cp_func_name): Update return type in declaration.
5252         * valops.c (find_overload_match): Move temp_func local to top
5253         level of function and change its type.  Use temp_func to hold and
5254         delete temporary string obtained from cp_func_name.
5255
5256 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5257
5258         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
5259         gdb::char_vector, remove cleanup, and update uses of `msg`.
5260
5261 2019-01-03  Jim Wilson  <jimw@sifive.com>
5262
5263         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
5264
5265 2019-01-02  Tom Tromey  <tom@tromey.com>
5266
5267         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
5268         (tdesc_parse_xml): Remove cleanups.
5269         * target-descriptions.h (make_cleanup_free_target_description):
5270         Don't declare.
5271         (target_desc_deleter): New struct.
5272         (target_desc_up): New typedef.
5273         * target-descriptions.c (target_desc_deleter::operator()): Rename
5274         from free_target_description.
5275         (make_cleanup_free_target_description): Remove.
5276
5277 2019-01-02  Tom Tromey  <tom@tromey.com>
5278
5279         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
5280         constructor, destructor.
5281         (linespec_parser): Remove typedef.
5282         (~linespec_parser): Rename from linespec_parser_delete.
5283         (linespec_lex_to_end, linespec_complete_label)
5284         (linespec_complete): Update.
5285         (decode_line_full): Remove cleanups.
5286         (decode_line_1): Update.
5287
5288 2019-01-02  Tom Tromey  <tom@tromey.com>
5289
5290         * python/python-internal.h (inferior_to_inferior_object): Change
5291         return type.
5292         * python/py-exitedevent.c (create_exited_event_object): Update.
5293         * python/py-inferior.c (inferior_to_inferior_object): Return
5294         gdbpy_ref.
5295         (python_new_inferior, python_inferior_deleted)
5296         (thread_to_thread_object, delete_thread_object)
5297         (build_inferior_list, gdbpy_selected_inferior): Update.
5298         * python/py-infthread.c (create_thread_object): Update.  Also fail
5299         if inferior_to_inferior_object fails.
5300
5301 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
5302
5303         * inferior.h (class inferior) <displaced_step_state>: New field.
5304         * infrun.h (struct displaced_step_state): Move here from
5305         infrun.c.  Initialize fields, add constructor.
5306         <inf>: Remove field.
5307         <reset>: New method.
5308         * infrun.c (struct displaced_step_inferior_state): Move to
5309         infrun.h.
5310         (displaced_step_inferior_states): Remove.
5311         (get_displaced_stepping_state): Adust.
5312         (displaced_step_in_progress_any_inferior): Adjust.
5313         (displaced_step_in_progress_thread): Adjust.
5314         (displaced_step_in_progress): Adjust.
5315         (add_displaced_stepping_state): Remove.
5316         (get_displaced_step_closure_by_addr): Adjust.
5317         (remove_displaced_stepping_state): Remove.
5318         (infrun_inferior_exit): Call displaced_step_state.reset.
5319         (use_displaced_stepping): Don't check for NULL.
5320         (displaced_step_prepare_throw): Call
5321         get_displaced_stepping_state.
5322         (displaced_step_fixup): Don't check for NULL.
5323         (prepare_for_detach): Don't check for NULL.
5324
5325 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5326
5327         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
5328          in case of call that did not complete.
5329
5330 2019-01-02  Andrey Utkin  <autkin@undo.io>
5331
5332         * symfile.c (find_separate_debug_file): Fix search of debug files for
5333         remote debuggee.
5334
5335 2019-01-02  Tom Tromey  <tom@tromey.com>
5336
5337         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
5338         indentation.
5339         * python/py-frame.c (frapy_older): Remove cast.
5340         (frapy_newer): Likewise.
5341         * python/py-breakpoint.c (local_setattro): Remove cast.
5342         * python/py-arch.c (archpy_name): Remove local variable.
5343         * python/py-type.c (gdbpy_lookup_type): Remove cast.
5344
5345 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
5346
5347         * unittests/basic_string_view/element_access/char/empty.cc:
5348         Fix year range in copyright header.
5349
5350 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5351
5352         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
5353         Delete.
5354         <operator==>: Update with for removed field.
5355         <hash>: Likewise.
5356         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
5357         <isa_features>: ...this.
5358         <abi_features>: New field.
5359         (riscv_isa_flen): Update comment.
5360         (riscv_abi_xlen): New declaration.
5361         (riscv_abi_flen): New declaration.
5362         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
5363         isa_features.
5364         (riscv_abi_xlen): New function.
5365         (riscv_isa_flen): Update to get answer from isa_features.
5366         (riscv_abi_flen): New function.
5367         (riscv_has_fp_abi): Update to get answer from abi_features.
5368         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
5369         xlen and flen.
5370         (riscv_call_info) <xlen, flen>: Update comment.
5371         (riscv_call_arg_struct): Remove invalid assertions
5372         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
5373         is removed.
5374         (riscv_gdbarch_init): Gather isa features and abi features
5375         separately, ensure both match on the gdbarch when reusing an old
5376         gdbarch.  Relax an error check to allow 32-bit abi float to run on
5377         a target with 64-bit float hardware.
5378
5379 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5380
5381         * source.c (search_command_helper): Stop reverse search
5382         when line 1 has been searched.
5383
5384 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5385
5386         * record-full.c (record_full_base_target::close): Rewrite
5387         record_full_core_buf_list free logic.
5388
5389 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5390
5391         * break-catch-syscall.c (print_one_catch_syscall): xfree
5392         the last text.
5393
5394 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5395
5396         * top.c (print_gdb_version): Update Copyright year in version
5397         message.
5398
5399 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5400
5401         Update copyright year range in all GDB files.
5402
5403 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
5404
5405         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
5406
5407 For older changes see ChangeLog-2018.
5408 \f
5409 Local Variables:
5410 mode: change-log
5411 left-margin: 8
5412 fill-column: 74
5413 version-control: never
5414 coding: utf-8
5415 End:
5416