gdb/ChangeLog

   1 2019-07-17  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-windata.h (tui_display_all_data): Don't declare.
   4         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
   5         from tui_display_all_data.
   6         * tui/tui-win.c
   7         (tui_data_window::do_make_visible_with_new_height): Update.
   8         * tui/tui-regs.c (tui_show_registers): Update.
   9         * tui/tui-layout.c (tui_set_layout): Update.
  10         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
  11         method.
  12
  13 2019-07-17  Tom Tromey  <tom@tromey.com>
  14
  15         * tui/tui-windata.h (tui_display_data_from): Don't declare.
  16         * tui/tui-windata.c (tui_display_data_from): Remove.
  17         (tui_data_window::refresh_all): Update.
  18
  19 2019-07-17  Tom Tromey  <tom@tromey.com>
  20
  21         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
  22         * tui/tui-windata.c (tui_display_data_from_line): Remove.
  23         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
  24         tui_display_registers_from_line.
  25         * tui/tui-regs.h (tui_display_registers_from_line): Update.
  26         * tui/tui-regs.c (tui_display_registers_from_line): Remove
  27         "force_display" parameter.
  28
  29 2019-07-17  Tom Tromey  <tom@tromey.com>
  30
  31         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
  32         declare.
  33         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
  34         Rename from tui_first_reg_element_no_inline.
  35         (tui_display_reg_element_at_line)
  36         (tui_display_registers_from_line): Update.
  37         * tui/tui-data.h (struct tui_data_window)
  38         <first_reg_element_no_inline>: New method.
  39
  40 2019-07-17  Tom Tromey  <tom@tromey.com>
  41
  42         * tui/tui-windata.c (tui_display_data_from)
  43         (tui_data_window::do_scroll_vertical): Update.
  44         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
  45         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
  46         Rename from tui_line_from_reg_element_no.
  47         (tui_display_registers_from_line): Update.
  48         * tui/tui-data.h (struct tui_data_window)
  49         <line_from_reg_element_no>: New method.
  50
  51 2019-07-17  Tom Tromey  <tom@tromey.com>
  52
  53         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
  54         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
  55         tui_last_regs_line_no.
  56         (tui_display_reg_element_at_line)
  57         (tui_display_registers_from_line): Update.
  58         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
  59         method.
  60
  61 2019-07-17  Tom Tromey  <tom@tromey.com>
  62
  63         PR tui/24722:
  64         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
  65         (tui_update_breakpoint_info): Add "being_deleted" parameter.
  66         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
  67         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
  68         (tui_update_breakpoint_info): Likewise.
  69         * tui/tui-hooks.c (tui_event_create_breakpoint)
  70         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
  71         Update.
  72
  73 2019-07-17  Tom Tromey  <tom@tromey.com>
  74
  75         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
  76
  77 2019-07-17  Tom Tromey  <tom@tromey.com>
  78
  79         * tui/tui-winsource.c (tui_update_source_window_as_is)
  80         (tui_update_source_windows_with_addr): Update.
  81         * tui/tui-source.h (tui_set_source_content)
  82         (tui_show_symtab_source): Add "win_info" parameter.
  83         * tui/tui-source.c (tui_set_source_content): Add "win_info"
  84         parameter.
  85         (tui_show_symtab_source): Likewise.
  86
  87 2019-07-17  Tom Tromey  <tom@tromey.com>
  88
  89         * tui/tui-wingeneral.c
  90         (tui_check_and_display_highlight_if_needed): Check can_highlight.
  91
  92 2019-07-17  Tom Tromey  <tom@tromey.com>
  93
  94         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
  95         (struct tui_cmd_window) <can_scroll>: New method.
  96         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
  97         method.
  98
  99 2019-07-17  Tom Tromey  <tromey@adacore.com>
 100
 101         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 102         do_field_signed>: Rename.  Change type of "value".
 103         * ui-out.c (ui_out::field_signed): Rename from field_int.
 104         Change type of "value".
 105         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 106         type of "value".
 107         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 108         do_field_int.  Change type of "value".
 109         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 110         do_field_int.  Change type of "value".
 111         * tracepoint.c (trace_status_mi, tfind_1)
 112         (print_one_static_tracepoint_marker): Update.
 113         * thread.c (print_thread_info_1, print_selected_thread_frame):
 114         Update.
 115         * stack.c (print_frame, print_frame_info): Update.
 116         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 117         Update.
 118         * source.c (print_source_lines_base): Update.
 119         * skip.c (info_skip_command): Update.
 120         * record-btrace.c (btrace_ui_out_decode_error)
 121         (btrace_call_history_src_line): Update.
 122         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 123         Update.
 124         * progspace.c (print_program_space): Update.
 125         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 126         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 127         do_field_int.  Change type of "value".
 128         * mi/mi-out.c (mi_ui_out::do_table_begin)
 129         (mi_ui_out::do_table_header): Update.
 130         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 131         type of "value".
 132         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 133         (mi_cmd_data_list_changed_registers, output_register)
 134         (mi_cmd_data_read_memory, mi_load_progress)
 135         (mi_cmd_trace_frame_collected): Update.
 136         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 137         Update.
 138         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 139         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 140         (mi_cmd_var_list_children, varobj_update_one): Update.
 141         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 142         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 143         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 144         * inferior.c (print_inferior): Update.
 145         * gdb_bfd.c (print_one_bfd): Update.
 146         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 147         Update.
 148         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 149         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 150         do_field_int.  Change type of "value".
 151         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 152         do_field_int.  Change type of "value".
 153         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 154         (print_one_breakpoint_location, print_it_catch_fork)
 155         (print_one_catch_fork, print_it_catch_vfork)
 156         (print_one_catch_vfork, print_it_catch_solib)
 157         (print_it_catch_exec, print_it_ranged_breakpoint)
 158         (print_mention_watchpoint, print_mention_masked_watchpoint)
 159         (bkpt_print_it, update_static_tracepoint): Update.
 160         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 161         * break-catch-syscall.c (print_it_catch_syscall): Update.
 162         * ada-tasks.c (print_ada_task_info): Update.
 163         * ada-lang.c (print_it_exception, print_mention_exception):
 164         Update.
 165
 166 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 167
 168         PR breakpoints/24541
 169         * gdbarch.c: Regenerate.
 170         * gdbarch.h: Regenerate.
 171         * gdbarch.sh: Adjust return type and parameter types for
 172         'stap_adjust_register'.
 173         (i386_stap_adjust_register): Adjust signature and return new
 174         register name.
 175         * stap-probe.c (stap_parse_register_operand): Adjust use of
 176         'gdbarch_stap_adjust_register'.
 177
 178 2019-07-17  Tom Tromey  <tromey@adacore.com>
 179
 180         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 181         declare VEC.
 182         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 183         std::vector.
 184         (struct s390_process_info): Add initializers.
 185         (s390_add_process): Use new.
 186         (s390_linux_nat_target::low_forget_process): Use delete.
 187         (s390_linux_nat_target::low_new_fork)
 188         (s390_linux_nat_target::stopped_by_watchpoint)
 189         (s390_linux_nat_target::low_prepare_to_resume)
 190         (s390_linux_nat_target::insert_watchpoint)
 191         (s390_linux_nat_target::insert_hw_breakpoint)
 192         (s390_linux_nat_target::remove_watchpoint)
 193         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 194
 195 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 196
 197         * aarch64-fbsd-nat.c: Include regcache.h.
 198         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 199         argument.
 200         (aarch64_fbsd_nat_target::fetch_registers)
 201         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 202         variable.
 203         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 204
 205 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 206
 207         * fbsd-nat.c: Include gdbarch.h.
 208
 209 2019-07-15  Tom Tromey  <tromey@adacore.com>
 210
 211         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 212
 213 2019-07-15  Tom Tromey  <tromey@adacore.com>
 214
 215         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 216         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 217         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 218         * cli-out.c (cli_ui_out::do_field_int): New method.
 219         * ui-out.c (ui_out::field_unsigned): New method.
 220         * symfile.c (generic_load): Use field_unsigned.
 221         (print_transfer_performance): Likewise.
 222         * record-btrace.c (ui_out_field_uint): Remove.
 223         (btrace_call_history_insn_range, btrace_call_history): Use
 224         field_unsigned.
 225         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 226         field_unsigned.
 227         * ui-out.h (class ui_out) <field_unsigned>: New method.
 228         <do_field_unsigned>: Likewise.
 229
 230 2019-07-15  Tom Tromey  <tromey@adacore.com>
 231
 232         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 233         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 234         * target.c (flash_erase_command): Use field_string.
 235         * infrun.c (print_signal_received_reason): Use field_string.
 236         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 237         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 238         field_string.
 239         * ada-tasks.c (print_ada_task_info): Use field_string.
 240
 241 2019-07-15  Tom Tromey  <tromey@adacore.com>
 242
 243         * target.c (flash_erase_command): Use field_core_addr.
 244         * symfile.c (generic_load): Use field_core_addr.
 245         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 246         Use field_core_addr.
 247         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 248         field_core_addr.
 249
 250 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 251
 252         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 253         value if its desired type is smaller than a CORE_ADDR and signed.
 254
 255 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 256
 257         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 258         of changes to field names, and use new is_reference field to
 259         decide if a property is a reference or not.
 260         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 261         field.
 262         (struct dwarf2_property_baton): Update header comment, rename
 263         'referenced_type' to 'property_type' and update comments.
 264         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 265         default property type, store in property baton, update to take
 266         accound of renamed field.
 267         (read_func_scope): Update call to attr_to_dynamic_prop.
 268         (read_array_type): Likewise.
 269         (dwarf2_per_cu_addr_sized_int_type): New function.
 270         (read_subrange_index_type): Move type finding code to
 271         dwarf2_per_cu_addr_sized_int_type.
 272         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 273         (dwarf2_per_cu_addr_type): New function.
 274         (set_die_type): Update calls to attr_to_dynamic_prop.
 275
 276 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 277
 278         * dwarf2read.c (read_subrange_index_type): New function.
 279         (read_subrange_type): Move code into new function and call it.
 280         * gdbtypes.c (create_range_type): Add some asserts.
 281
 282 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 283
 284         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 285         update return statements.
 286         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 287         declaration, and update comment to match.
 288         * gdbtypes.c (resolve_dynamic_array): Update call to
 289         dwarf2_evaluate_property to match new return type.
 290
 291 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 292
 293         * valarith.c (value_subscripted_rvalue): Change lowerbound
 294         parameter type from int to LONGEST.
 295         * value.h (value_subscripted_rvalue): Likewise in declaration.
 296
 297 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 298
 299         * cli/cli-utils.c (info_print_command_completer): New function.
 300         * cli/cli-utils.h: Add 'completer.h' include, and forward
 301         declaration for 'struct cmd_list_element'.
 302         (info_print_command_completer): Declare.
 303         * stack.c (_initialize_stack): Add completer for 'info locals' and
 304         'info args'.
 305         * symtab.c (_initialize_symtab): Add completer for 'info
 306         variables' and 'info functions'.
 307         * NEWS: Mention completion for additional info commands.
 308
 309 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 310
 311         * cli/cli-utils.c (extract_info_print_args): Delete.
 312         (extract_arg_maybe_quoted): Delete.
 313         (info_print_options_defs): New variable.
 314         (make_info_print_options_def_group): New function.
 315         (extract_info_print_options): Define new function.
 316         * cli/cli-utils.h (extract_info_print_args): Delete.
 317         (struct info_print_options): New structure.
 318         (extract_info_print_options): Declare new function.
 319         * stack.c (info_locals_command): Update to use new
 320         extract_info_print_options, also add a header comment.
 321         (info_args_command): Likewise.
 322         * symtab.c (info_variables_command): Likewise.
 323         (info_functions_command): Likewise.
 324
 325 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 326
 327         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 328         to extract string arguments.
 329         * common/common-utils.c (extract_string_maybe_quoted): New function.
 330         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 331
 332 2019-07-11  Tom Tromey  <tromey@adacore.com>
 333
 334         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 335         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 336         * top.h (gdbinit): Don't declare.
 337         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 338         into...
 339         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 340         * top.c (gdb_init): Don't call init_cli_cmds.
 341         (gdbinit): Remove.
 342         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 343
 344 2019-07-11  Tom Tromey  <tromey@adacore.com>
 345
 346         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 347         after it has been moved.
 348
 349 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 350
 351         * valops.c (value_must_coerce_to_target): Change return type to
 352         bool.
 353         * value.h (value_must_coerce_to_target): Likewise.
 354
 355 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 356
 357         * breakpoint.c (is_hardware_watchpoint): Remove
 358         forward-declaration.
 359         (is_masked_watchpoint): Change return type to bool.
 360         (is_tracepoint): Likewise.
 361         (is_breakpoint): Likewise.
 362         (is_hardware_watchpoint): Likewise.
 363         (is_watchpoint): Likewise.
 364         (is_no_memory_software_watchpoint): Likewise.
 365         (is_catchpoint): Likewise.
 366         (breakpoint_1): Make FILTER parameter's return type bool.
 367         is_masked_watchpoint): Change return type to bool.
 368         (save_breakpoints): Make FILTER parameter's return type bool.
 369         * breakpoint.h (is_breakpoint): Change return type to bool.
 370         (is_watchpoint): Likewise.
 371         (is_catchpoint): Likewise.
 372         (is_tracepoint): Likewise.
 373
 374 2019-07-10  Tom Tromey  <tom@tromey.com>
 375
 376         * defs.h: Don't include gdbarch.h.
 377         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 378         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 379         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 380         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 381         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 382         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 383         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 384         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 385         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 386         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 387         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 388         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 389         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 390         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 391         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 392         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 393         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 394         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 395         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 396         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 397         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 398         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 399         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 400         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 401         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 402         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 403         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 404
 405 2019-07-10  Tom Tromey  <tromey@adacore.com>
 406
 407         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 408         * breakpoint.c (init_ada_exception_breakpoint): Register as
 409         bp_catchpoint.
 410         (print_one_breakpoint_location, print_one_breakpoint): Use
 411         is_ada_exception_catchpoint.
 412         * ada-lang.c (class ada_catchpoint_location): Pass
 413         bp_loc_software_breakpoint to bp_location constructor.
 414         (is_ada_exception_catchpoint): New function.
 415
 416 2019-07-10  Tom Tromey  <tromey@adacore.com>
 417
 418         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 419         VEC.
 420         (struct arm_exidx_entry): New method operator<.
 421         (struct arm_exidx_data) <section_maps>: Change type.
 422         (arm_exidx_data_free): Remove.
 423         (arm_exidx_data_key): Change type.  Move lower.
 424         (arm_exidx_new_objfile): Update.
 425         (arm_compare_exidx_entries): Remove.
 426         (arm_find_exidx_entry, _initialize_arm_tdep)
 427
 428 2019-07-10  Tom Tromey  <tromey@adacore.com>
 429
 430         * solib-spu.c (ocl_program_data_key): Change type.
 431         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 432         Update.
 433
 434 2019-07-10  Tom Tromey  <tromey@adacore.com>
 435
 436         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 437         (struct solib_aix_inferior_data) <library_list>: Change type.
 438         (solib_aix_inferior_data_handle): Change type.
 439         (get_solib_aix_inferior_data): Update.
 440         (solib_aix_free_library_list): Remove.
 441         (library_list_start_library): Update.
 442         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 443         return type.
 444         (solib_aix_get_library_list)
 445         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 446         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 447
 448 2019-07-10  Tom Tromey  <tromey@adacore.com>
 449
 450         * solib-dsbt.c (struct dsbt_info): Add initializers.
 451         (solib_dsbt_pspace_data): Change type.
 452         (dsbt_pspace_data_cleanup): Remove.
 453         (get_dsbt_info, _initialize_dsbt_solib): Update.
 454
 455 2019-07-10  Tom Tromey  <tromey@adacore.com>
 456
 457         * spu-tdep.c (spu_overlay_data): Change type.
 458         (spu_get_overlay_table, spu_overlay_new_objfile)
 459         (_initialize_spu_tdep): Update.
 460
 461 2019-07-10  Tom Tromey  <tromey@adacore.com>
 462
 463         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 464         destructor.
 465         (dbx_objfile_data_key): Change type and declare later.
 466         (DBX_SYMFILE_INFO): Rewrite.
 467         * dbxread.c (dbx_objfile_data_key): Change type.
 468         (dbx_symfile_init): Update.
 469         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 470         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 471         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 472
 473 2019-07-10  Tom Tromey  <tromey@adacore.com>
 474
 475         * jit.c (jit_program_space_key): Change type.  Move lower.
 476         (get_jit_program_space_data): Update.
 477         (jit_program_space_data_cleanup): Remove.
 478         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 479         Update.
 480         (struct jit_program_space_data): Add initializers.
 481
 482 2019-07-10  Tom Tromey  <tromey@adacore.com>
 483
 484         * solib-darwin.c (struct darwin_info): Add initializers.
 485         (solib_darwin_pspace_data): Change type.
 486         (darwin_pspace_data_cleanup): Remove.
 487         (get_darwin_info, _initialize_darwin_solib): Update.
 488
 489 2019-07-10  Tom Tromey  <tromey@adacore.com>
 490
 491         * remote-sim.c (struct sim_inferior_data): Add initializers,
 492         constructor, and destructor.
 493         (sim_inferior_data_key): Change type.  Move lower.
 494         (check_for_duplicate_sim_descriptor): Update.
 495         (get_sim_inferior_data): Use new.  Update.
 496         (~sim_inferior_data_cleanup): Rename from
 497         sim_inferior_data_cleanup.  Simplify.
 498         (gdbsim_close_inferior, simulator_command)
 499         (sim_command_completer, _initialize_remote_sim): Update.
 500         (next_pid, INITIAL_PID): Move earlier.
 501
 502 2019-07-10  Tom Tromey  <tromey@adacore.com>
 503
 504         * python/python-internal.h (create_thread_object): Return
 505         gdbpy_ref.
 506         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 507         * python/py-inferior.c (struct threadlist_entry): Add
 508         constructor.
 509         <thread_obj>: Now a gdbpy_ref.
 510         (thread_to_thread_object): Update.
 511         (add_thread_object): Use new.
 512         (delete_thread_object): Use delete.
 513         (infpy_threads): Update.
 514         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 515         GIL.
 516
 517 2019-07-10  Tom Tromey  <tromey@adacore.com>
 518
 519         * valops.c (value_cast): Specialize error message for Ada.
 520
 521 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 522
 523         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 524
 525 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 526
 527         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 528         bpstat_should_step): Return bool, adjust comments.
 529         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 530         bpstat_should_step): Likewise.
 531
 532 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 533
 534         * features/Makefile: Use feature target descriptions for Arm.
 535         * features/arm/arm-core.c: Generate new file.
 536         * features/arm/arm-fpa.c: Likewise.
 537         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 538         * features/arm/arm-m-profile.c: Likewise.
 539         * features/arm/arm-vfpv2.c: Likewise.
 540         * features/arm/arm-vfpv3.c: Likewise.
 541         * features/arm/xscale-iwmmxt.c: Likewise.
 542         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 543
 544 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 545
 546         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 547         ptrace earlier.
 548
 549 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 550
 551         * features/aarch64-pauth.c: Regenerate.
 552
 553 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 554
 555         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 556         bool.
 557         (bpstat_what): Use false instead of 0.
 558
 559 2019-07-09  Pedro Alves  <palves@redhat.com>
 560
 561         * break-catch-throw.c (is_exception_catchpoint): New.
 562         * breakpoint.c (print_one_breakpoint_location): New parameter
 563         'raw_loc'.  Handle it.  Use
 564         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 565         looking at the breakpoint's type.
 566         (print_one_breakpoint): If handling "maint info breakpoints", also
 567         print locations of exception catchpoints.
 568         * breakpoint.h (is_exception_catchpoint): Declare.
 569
 570 2019-07-09  Pedro Alves  <palves@redhat.com>
 571
 572         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 573         "addr" field.
 574         (allocate_location_exception_catchpoint): New.
 575         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 576         (initialize_throw_catchpoint_ops): Install
 577         allocate_location_exception_catchpoint as allocate_location
 578         method.
 579         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 580         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 581         bp_loc_other.
 582         (breakpoint_address_is_meaningful): Delete.
 583         (bl_address_is_meaningful): New.
 584         (breakpoint_locations_match): Adjust comment.
 585         (bp_location_from_bp_type): New, factored out of...
 586         (bp_location::bp_location(breakpoint *)): ... this.
 587         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 588         factored out of...
 589         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 590         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 591         breakpoint_address_is_meaningful.
 592         (bp_locations_compare): Adjust comment.
 593         (update_global_location_list): Use bl_address_is_meaningful
 594         instead of breakpoint_address_is_meaningful.
 595         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 596         explicit.
 597         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 598         * python/py-breakpoint.c (bppy_get_location): No longer check
 599         whether location is null.
 600
 601 2019-07-09  Pedro Alves  <palves@redhat.com>
 602
 603         PR c++/15468
 604         * breakpoint.c (print_one_breakpoint_location): Remove
 605         single-location assert.
 606
 607 2019-07-09  Tom Tromey  <tom@tromey.com>
 608
 609         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 610         * configure: Rebuild.
 611         * configure.ac: Change common to gdbsupport.
 612         * gdbsupport: Rename from common.
 613         * acinclude.m4: Change common to gdbsupport.
 614         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 615         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 616         gdbsupport.
 617         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 618         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 619         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 620         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 621         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 622         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 623         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 624         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 625         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 626         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 627         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 628         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 629         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 630         coff-pe-read.c, command.h, compile/compile-c-support.c,
 631         compile/compile-c.h, compile/compile-cplus-symbols.c,
 632         compile/compile-cplus-types.c, compile/compile-cplus.h,
 633         compile/compile-loc2c.c, compile/compile.c, completer.c,
 634         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 635         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 636         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 637         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 638         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 639         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 640         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 641         features/aarch64-core.c, features/aarch64-fpu.c,
 642         features/aarch64-pauth.c, features/aarch64-sve.c,
 643         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 644         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 645         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 646         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 647         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 648         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 649         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 650         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 651         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 652         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 653         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 654         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 655         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 656         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 657         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 658         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 659         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 660         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 661         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 662         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 663         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 664         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 665         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 666         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 667         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 668         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 669         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 670         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 671         minsyms.c, mips-linux-tdep.c, namespace.h,
 672         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 673         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 674         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 675         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 676         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 677         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 678         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 679         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 680         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 681         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 682         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 683         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 684         procfs.c, producer.c, progspace.h, psymtab.h,
 685         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 686         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 687         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 688         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 689         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 690         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 691         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 692         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 693         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 694         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 695         target-memory.c, target.c, target.h, target/waitstatus.c,
 696         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 697         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 698         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 699         unittests/array-view-selftests.c,
 700         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 701         unittests/common-utils-selftests.c,
 702         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 703         unittests/format_pieces-selftests.c,
 704         unittests/function-view-selftests.c,
 705         unittests/lookup_name_info-selftests.c,
 706         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 707         unittests/mkdir-recursive-selftests.c,
 708         unittests/observable-selftests.c,
 709         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 710         unittests/parse-connection-spec-selftests.c,
 711         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 712         unittests/scoped_fd-selftests.c,
 713         unittests/scoped_mmap-selftests.c,
 714         unittests/scoped_restore-selftests.c,
 715         unittests/string_view-selftests.c, unittests/style-selftests.c,
 716         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 717         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 718         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 719         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 720         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 721         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 722
 723 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 724
 725         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 726         bool value.
 727         (decode_digits_ordinary): Set explicit_line field in sal.
 728         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 729         symtab_and_line that was set on an explicit line number in
 730         assembler code.  Do always update the recorded symtab and line if
 731         we do skip the prologue.
 732
 733 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 734
 735         * breakpoint.c (set_breakpoint_location_function): Remove
 736         explicit_loc parameter.
 737         (momentary_breakpoint_from_master): Update call to
 738         set_breakpoint_location_function.
 739         (add_location_to_breakpoint): Likewise.
 740
 741 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 742
 743         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 744         required features based on default bfd type when no specific bfd
 745         is present.
 746
 747 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 748
 749         * NEWS: Mention that GDB printf and eval commands can now print
 750         C-style and Ada-style convenience var strings without
 751         calling the inferior.
 752         * printcmd.c (printf_c_string): Locally print GDB internal var
 753         instead of transiting via the inferior.
 754         (printf_wide_c_string): Likewise.
 755
 756 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 757
 758         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
 759
 760 2019-07-04  Tom Tromey  <tom@tromey.com>
 761
 762         PR tui/24724:
 763         * tui/tui-winsource.c (tui_clear_source_content): Update.
 764         (tui_source_window_base::set_is_exec_point_at): Fix comment.
 765         (tui_update_breakpoint_info): Update.
 766         (tui_set_exec_info_content): Update.
 767         * tui/tui-source.c (tui_set_source_content_nil): Update.
 768         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
 769         has_break.
 770         * tui/tui-data.h (enum tui_bp_flag): New.
 771         (tui_bp_flags): New enum flags type.
 772         (struct tui_source_element) <break_mode>: Change type.  Rename
 773         from has_break.
 774         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
 775         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
 776         constants.
 777         * tui/tui-winsource.h: Fix comment.
 778
 779 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 780
 781         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
 782         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
 783         (store_fpregs_to_thread)
 784         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 785         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
 786         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
 787         (IWMMXT_REGS_SIZE): Add define.
 788         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
 789         (fetch_vfp_regs, store_vfp_regs)
 790         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 791         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
 792
 793 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 794
 795         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
 796         defines.
 797         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
 798         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
 799         (ARM_INT_REGISTER_SIZE): ...to this.
 800         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
 801         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
 802         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
 803         (arm_linux_collect_gregset, supply_nwfpe_register)
 804         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
 805         defines.
 806         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
 807         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
 808         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
 809         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
 810         (arm_return_in_memory, arm_store_return_value)
 811         (arm_get_longjmp_target, arm_register_g_packet_guesses)
 812         (arm_record_ld_st_multiple): Likewise.
 813         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
 814         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
 815
 816 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 817
 818         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
 819         AARCH64_DISPLACED_MODIFIED_INSNS.
 820         * aarch64-tdep.c (struct aarch64_displaced_step_data)
 821         (aarch64_displaced_step_copy_insn): Likewise.
 822         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 823         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
 824         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
 825         ARM_DISPLACED_MODIFIED_INSNS.
 826         * arm-tdep.c (arm_gdbarch_init): Likewise.
 827         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 828         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
 829         (struct arm_displaced_step_closure): Use
 830         ARM_DISPLACED_MODIFIED_INSNS.
 831
 832 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 833
 834         * features/Makefile: Remove unused xml files.
 835         * features/aarch64.xml: Remove.
 836         * features/i386/amd64-avx-avx512-linux.xml: Remove.
 837         * features/i386/amd64-avx-avx512.xml: Remove.
 838         * features/i386/amd64-avx-linux.xml: Remove.
 839         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
 840         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
 841         * features/i386/amd64-avx-mpx-linux.xml: Remove.
 842         * features/i386/amd64-avx-mpx.xml: Remove.
 843         * features/i386/amd64-avx.xml: Remove.
 844         * features/i386/amd64-linux.xml: Remove.
 845         * features/i386/amd64-mpx-linux.xml: Remove.
 846         * features/i386/amd64-mpx.xml: Remove.
 847         * features/i386/amd64.xml: Remove.
 848         * features/i386/i386-avx-avx512-linux.xml: Remove.
 849         * features/i386/i386-avx-avx512.xml: Remove.
 850         * features/i386/i386-avx-linux.xml: Remove.
 851         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
 852         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
 853         * features/i386/i386-avx-mpx-linux.xml: Remove.
 854         * features/i386/i386-avx-mpx.xml: Remove.
 855         * features/i386/i386-avx.xml: Remove.
 856         * features/i386/i386-linux.xml: Remove.
 857         * features/i386/i386-mmx-linux.xml: Remove.
 858         * features/i386/i386-mmx.xml: Remove.
 859         * features/i386/i386-mpx-linux.xml: Remove.
 860         * features/i386/i386-mpx.xml: Remove.
 861         * features/i386/i386.xml: Remove.
 862         * features/i386/x32-avx-avx512-linux.xml: Remove.
 863         * features/i386/x32-avx-linux.xml: Remove.
 864         * features/i386/x32-linux.xml: Remove.
 865
 866 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 867
 868         * regformats/aarch64.dat: Remove.
 869         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
 870         * regformats/i386/amd64-avx-linux.dat: Remove.
 871         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
 872         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
 873         * regformats/i386/amd64-linux.dat: Remove.
 874         * regformats/i386/amd64-mpx-linux.dat: Remove.
 875         * regformats/i386/amd64.dat: Remove.
 876         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
 877         * regformats/i386/i386-avx-linux.dat: Remove.
 878         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
 879         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
 880         * regformats/i386/i386-linux.dat: Remove.
 881         * regformats/i386/i386-mmx-linux.dat: Remove.
 882         * regformats/i386/i386-mpx-linux.dat: Remove.
 883         * regformats/i386/i386.dat: Remove.
 884         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
 885         * regformats/i386/x32-avx-linux.dat: Remove.
 886         * regformats/i386/x32-linux.dat: Remove.
 887
 888 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 889
 890         * aarch64-tdep.c: Remove xml self tests.
 891         * amd64-linux-tdep.c: Likewise.
 892         * amd64-tdep.c: Likewise.
 893         * i386-linux-tdep.c: Likewise.
 894         * i386-tdep.c: Likewise.
 895
 896 2019-07-03  Pedro Alves  <palves@redhat.com>
 897
 898         PR cli/24732
 899         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
 900         (pipe_cmd_option_defs): New.
 901         (make_pipe_cmd_options_def_group): New.
 902         (pipe_command): Use gdb::option::process_options.
 903         (pipe_command_completer): New function.
 904         (_initialize_cli_cmds): Install completer for "pipe" command.
 905
 906 2019-07-03  Pedro Alves  <palves@redhat.com>
 907
 908         * cli/cli-option.c (union option_value) <string>: New field.
 909         (struct option_def_and_value): Add ctor, move ctor, dtor and
 910         use DISABLE_COPY_AND_ASSIGN.
 911         (option_def_and_value::clear_value): New.
 912         (parse_option, save_option_value_in_ctx, get_val_type_str)
 913         (add_setshow_cmds_for_options): Handle var_string.
 914         * cli-option.h (union option_def::var_address) <string>: New
 915         field.
 916         (struct string_option_def): New.
 917         * maint-test-options.c (struct test_options_opts): Add default
 918         ctor and use DISABLE_COPY_AND_ASSIGN.
 919         <string_opt>: New field.
 920         (test_options_opts::~test_options_opts): New.
 921         (test_options_opts::dump): Also dump "-string".
 922         (test_options_option_defs): Install "string.
 923
 924 2019-07-03  Pedro Alves  <palves@redhat.com>
 925
 926         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
 927         option_value with a null enumeration.
 928         (complete_options): Save the option values in the context.
 929         (save_option_value_in_ctx): New, factored out from ...
 930         (process_options): ... here.
 931         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
 932         of the function.
 933         * maint-test-options.c (test_options_opts::dump): New, factored
 934         out from ...
 935         (maintenance_test_options_command_mode): ... here.
 936         (maintenance_test_options_command_completion_result): Delete.
 937         (maintenance_test_options_command_completion_text): Update
 938         comment.
 939         (maintenance_show_test_options_completion_result): Change
 940         prototype.  Just print
 941         maintenance_test_options_command_completion_text.
 942         (save_completion_result): New.
 943         (maintenance_test_options_completer_mode): Pass options context to
 944         complete_options, and then save a dump.
 945         (_initialize_maint_test_options): Use add_cmd to install "maint
 946         show test-options-completion-result".
 947
 948 2019-07-03  Pedro Alves  <palves@redhat.com>
 949
 950         * NEWS (New commands): Mention "with" and "maint with".
 951         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
 952         (with_command, with_command_completer): New.
 953         (pipe_command): Adjust to new repeat_previous
 954         interface.
 955         (_initialize_cli_cmds): Install the "with" command and its "w"
 956         alias.
 957         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
 958         declarations.
 959         * cli/cli-setshow.c (parse_cli_var_uinteger)
 960         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
 961         argument strings for all var_types.
 962         (get_setshow_command_value_string): New, factored out from ...
 963         (do_show_command): ... this.
 964         * cli/cli-setshow.h: Include <string>.
 965         (get_setshow_command_value_string): Declare.
 966         * command.h (repeat_previous): Now returns const char *.  Adjust
 967         comment.
 968         * maint.c: Include "cli/cli-cmds.h".
 969         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
 970         (_initialize_maint_cmds): Register the "maintenance with" command.
 971         * top.c (repeat_previous): Move bits from pipe_command here:
 972         Return the saved command line, if any; error out if there's no
 973         command to relaunch.
 974
 975 2019-07-03  Pedro Alves  <palves@redhat.com>
 976
 977         * NEWS (New commands): Mention "maint set/show test-settings"
 978         instead of "maint test-settings".
 979         * maint-test-settings.c (maintenance_test_settings_list): Delete.
 980         (maintenance_test_settings_set_list): Rename to ...
 981         (maintenance_set_test_settings_list): ... this.
 982         (maintenance_test_settings_show_list): Rename to  ...
 983         (maintenance_show_test_settings_list): ... this.
 984         (maintenance_test_settings_cmd): Delete.
 985         (maintenance_test_settings_set_cmd): ...
 986         (maintenance_set_test_settings_cmd): ... this.
 987         (maintenance_test_settings_show_cmd): ...
 988         (maintenance_show_test_settings_cmd): ... this.
 989         (maintenance_test_settings_show_value_cmd):
 990         (maintenance_show_test_settings_value_cmd): ... this.
 991         (_initialize_maint_test_settings): No longer install the "maint
 992         test-settings" prefix command.  Rename "maint test-settings set"
 993         to "maint set test-settings", and "maint test-settings show" to
 994         "maint show test-settings".  Adjust all subcommands.
 995
 996 2019-07-03  Pedro Alves  <palves@redhat.com>
 997
 998         * maint-test-settings.c: Fix file's intro comment.  Replace all
 999         references to "test-options" with references to "test-settings",
1000         in comments.
1001
1002 2019-07-03  Pedro Alves  <palves@redhat.com>
1003
1004         * maint-test-settings.c (maintenance_test_settings_xxx)
1005         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1006         New.
1007         (maintenance_test_settings_enums): Use them.
1008         (maintenance_test_settings_enum): Default to
1009         maintenance_test_settings_xxx.
1010         (_initialize_maint_test_settings): Initialize
1011         MAINTENANCE_TEST_SETTINGS_FILENAME.
1012
1013 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1014
1015         * breakpoint.h (remove_breakpoints_inf): Change return type to
1016         void, move function documentation here.
1017         * breakpoint.c (remove_breakpoints_inf): Change return type to
1018         void, move function documentation to header.
1019
1020 2019-07-02  Pedro Alves  <palves@redhat.com>
1021
1022         * NEWS (Completion improvements): Mention "info threads".
1023         * thread.c (struct info_threads_opts, info_threads_option_defs)
1024         (make_info_threads_options_def_group): New.
1025         (info_threads_command): Use gdb::option::process_options.
1026         (info_threads_command_completer): New.
1027         (_initialize_thread): Use gdb::option::build_help to build the
1028         help text for "info threads".
1029
1030 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1031
1032         * defs.h (generic_load): Move from here...
1033         * symfile.h (generic_load): ... to here.  Rename name parameter
1034         to args.
1035         * symfile.c (generic_load): Add comment.
1036
1037 2019-07-01  Tom Tromey  <tromey@adacore.com>
1038
1039         * dwarf2read.c
1040         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1041         declaration of without_params.  Fix formatting.
1042
1043 2019-07-01  Tom Tromey  <tromey@adacore.com>
1044
1045         * ada-exp.y (find_primitive_type): Update.
1046         * ada-lang.h (ada_lookup_symbol): Update.
1047         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1048         parameter.
1049         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1050
1051 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1052
1053         PR breakpoints/24541
1054         * gdbarch.c: Regenerate.
1055         * gdbarch.h: Regenerate.
1056         * gdbarch.sh: Add 'stap_adjust_register'.
1057         * i386-tdep.c: Include '<unordered_set>'.
1058         (i386_stap_adjust_register): New function.
1059         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1060         * stap-probe.c (stap_parse_register_operand): Call
1061         'gdbarch_stap_adjust_register'.
1062
1063 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1064
1065         PR python/24742
1066         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1067         * python/python.c (do_start_initialization): Use 'xmalloc'
1068         instead of 'PyMem_Malloc'.
1069
1070 2019-06-28  Tom Tromey  <tromey@adacore.com>
1071
1072         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1073         for Ada.
1074
1075 2019-06-27  Tom Tromey  <tromey@adacore.com>
1076
1077         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1078         objfile_key.
1079         (arm_find_mapping_symbol, arm_record_special_symbol)
1080         (_initialize_arm_tdep): Update.
1081         (arm_objfile_data_free): Remove.
1082
1083 2019-06-27  Tom Tromey  <tromey@adacore.com>
1084
1085         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1086         to cp_print_static_field.
1087
1088 2019-06-26  Tom Tromey  <tromey@adacore.com>
1089
1090         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1091         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1092         declare.
1093
1094 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1095
1096         * features/aarch64-core.c (create_feature_aarch64_core):
1097         Regenerate.
1098         * features/aarch64-core.xml: Add cpsr flags.
1099
1100 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1101
1102         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1103         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1104
1105 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1106
1107         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1108         field.
1109         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1110         use.
1111         (arm_record_special_symbol): Don't insert new symbol in sorted
1112         position, push it at the end.
1113
1114 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1115
1116         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1117         (arm_mapping_symbol_s): Remove.
1118         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1119         (arm_mapping_symbol_vec): New typedef.
1120         (struct arm_per_objfile): Add constructor.
1121         <section_maps>: Change type to
1122         std::unique_ptr<arm_mapping_symbol_vec[]>.
1123         (arm_compare_mapping_symbols): Remove.
1124         (arm_find_mapping_symbol): Adjust to section_maps type change.
1125         (arm_objfile_data_free): Call delete on arm_per_objfile.
1126         (arm_record_special_symbol): Adjust to section_maps type change.
1127         Allocate arm_per_objfile with new.
1128
1129 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1130
1131         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1132         with the command prefix.
1133
1134 2019-06-25  Tom Tromey  <tom@tromey.com>
1135
1136         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1137         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1138
1139 2019-06-25  Tom Tromey  <tom@tromey.com>
1140
1141         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1142         type.
1143         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1144         protected.
1145
1146 2019-06-25  Tom Tromey  <tom@tromey.com>
1147
1148         * tui/tui-winsource.c
1149         (tui_source_window_base::set_is_exec_point_at): Add check against
1150         LOA_ADDRESS.
1151
1152 2019-06-25  Tom Tromey  <tom@tromey.com>
1153
1154         * tui/tui-source.c (tui_set_source_content): Don't check before
1155         xfree.
1156         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1157
1158 2019-06-25  Tom Tromey  <tom@tromey.com>
1159
1160         * tui/tui-winsource.h (tui_update_source_window_as_is)
1161         (tui_alloc_source_buffer, tui_line_is_displayed)
1162         (tui_addr_is_displayed): Change type of win_info.
1163         * tui/tui-winsource.c (tui_update_source_window_as_is)
1164         (tui_clear_source_content, tui_show_source_line)
1165         (tui_show_source_content, tui_source_window_base::refill)
1166         (tui_source_window_base::set_is_exec_point_at)
1167         (tui_source_window_base::set_is_exec_point_at)
1168         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1169         (tui_alloc_source_buffer, tui_line_is_displayed)
1170         (tui_addr_is_displayed): Change type of win_info.  Update.
1171         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1172         (tui_source_window_base::do_make_visible_with_new_height):
1173         Update.
1174         * tui/tui-source.c (tui_set_source_content)
1175         (tui_set_source_content_nil)
1176         (tui_source_window::do_scroll_vertical): Update.
1177         * tui/tui-layout.c (show_layout): Update.
1178         * tui/tui-disasm.c (tui_set_disassem_content)
1179         (tui_disasm_window::do_scroll_vertical): Update.
1180         * tui/tui-data.h (tui_win_content): Remove.
1181         (struct tui_gen_win_info) <content, content_size>: Remove.
1182         (struct tui_source_element): Add initializers and destructor.
1183         (union tui_which_element, struct tui_win_element): Remove.
1184         (struct tui_source_window_base) <content>: New field.
1185         (struct tui_data_window): Remove destructor.
1186         (tui_alloc_content, tui_free_win_content)
1187         (tui_free_all_source_wins_content): Don't declare.
1188         * tui/tui-data.c (tui_initialize_static_data): Update.
1189         (init_content_element, tui_alloc_content): Remove.
1190         (~tui_gen_win_info): Update.
1191         (~tui_data_window, tui_free_all_source_wins_content)
1192         (tui_free_win_content, free_content, free_content_elements):
1193         Remove.
1194
1195 2019-06-25  Tom Tromey  <tom@tromey.com>
1196
1197         * tui/tui-winsource.h (tui_clear_source_content)
1198         (tui_erase_source_content, tui_show_source_content): Change type
1199         of win_info.
1200         * tui/tui-winsource.c (tui_clear_source_content)
1201         (tui_erase_source_content, tui_show_source_content): Change type
1202         of win_info.
1203         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1204         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1205         win_info.
1206         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1207         win_info.
1208         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1209
1210 2019-06-25  Tom Tromey  <tom@tromey.com>
1211
1212         * tui/tui-winsource.c (tui_clear_source_content)
1213         (tui_source_window_base::set_is_exec_point_at): Update.
1214         * tui/tui-source.c (tui_set_source_content_nil): Update.
1215         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1216         a bool.
1217         * tui/tui-data.c (init_content_element): Update.
1218
1219 2019-06-25  Tom Tromey  <tom@tromey.com>
1220
1221         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1222         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1223         * tui/tui-layout.c (init_and_make_win): Update.
1224         * tui/tui.h (enum tui_win_type): Update.
1225         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1226         tui_win_is_auxillary.
1227         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1228         tui_win_is_auxillary.
1229
1230 2019-06-25  Tom Tromey  <tom@tromey.com>
1231
1232         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1233         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1234         (tui_delete_data_content_windows, tui_display_all_data)
1235         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1236         Update.
1237         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1238         * tui/tui-regs.c (tui_last_regs_line_no)
1239         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1240         (tui_show_registers): Update.
1241         (tui_show_register_group): Return void.  Update.
1242         (tui_display_registers_from, tui_display_reg_element_at_line)
1243         (tui_display_registers_from_line, tui_check_register_values):
1244         Update.
1245         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1246         member.
1247         (struct tui_data_window) <regs_content>: Now a std::vector.
1248         <regs_content_count>: Remove.
1249         (tui_add_content_elements, tui_free_data_content): Don't declare.
1250         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1251         (init_content_element): Remove DATA_WIN case.  Add assert.
1252         (tui_add_content_elements): Remove.
1253         (tui_data_window): Update.
1254         (tui_free_data_content): Remove.
1255         (free_content_elements): Remove DATA_WIN case.
1256
1257 2019-06-25  Tom Tromey  <tom@tromey.com>
1258
1259         * tui/tui-data.c (tui_data_item_window): Update.
1260         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1261         * tui/tui-windata.c (tui_display_all_data)
1262         (tui_display_data_from_line): Update.
1263         (tui_check_data_values): Remove.
1264         * tui/tui-regs.c (tui_show_register_group)
1265         (tui_display_reg_element_at_line): Update.
1266         * tui/tui-hooks.c (tui_register_changed)
1267         (tui_refresh_frame_and_register_information): Call
1268         tui_check_register_values.
1269         * tui/tui-data.h (struct tui_data_window) <data_content,
1270         data_content_count, data_type>: Remove.
1271         (enum tui_data_type): Remove.
1272
1273         * tui/tui-data.c (tui_data_window::clear_detail)
1274         (~tui_data_window): Update.
1275
1276 2019-06-25  Tom Tromey  <tom@tromey.com>
1277
1278         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1279         declare.
1280         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1281         Rename from tui_first_data_item_displayed.  Update.
1282         (tui_data_window::refresh_all)
1283         (tui_data_window::do_scroll_vertical): Update.
1284         * tui/tui-data.h (struct tui_data_window)
1285         <first_data_item_displayed>: Declare new method.
1286
1287 2019-06-25  Tom Tromey  <tom@tromey.com>
1288
1289         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1290         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1291         contents...
1292         (tui_initialize_static_data): ...here.
1293
1294 2019-06-25  Tom Tromey  <tom@tromey.com>
1295
1296         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1297         (tui_display_registers_from, tui_check_register_values): Update.
1298         (tui_display_register): Remove win_info parameter; update.
1299         (tui_get_register): Change type of parameters.
1300         * tui/tui-data.h (struct tui_data_element): Remove.
1301         (union tui_which_element) <data>: Remove.
1302         <data_window>: Change type.
1303         (struct tui_data_item_window): New.
1304         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1305         case.  Add assert.
1306         (~tui_data_item_window): New destructor.
1307         (free_content_elements): Remove DATA_ITEM_WIN case.
1308
1309 2019-06-25  Tom Tromey  <tom@tromey.com>
1310
1311         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1312         Remove.
1313
1314 2019-06-25  Tom Tromey  <tom@tromey.com>
1315
1316         * tui/tui-data.h (struct tui_command_element): Remove.
1317         (union tui_which_element) <command>: Remove.
1318         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1319         assert.
1320         (free_content_elements): Remove CMD_WIN case.
1321
1322 2019-06-25  Tom Tromey  <tom@tromey.com>
1323
1324         * tui/tui-layout.c (tui_set_layout): Update.
1325         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1326         * tui/tui-data.c (layout_def): Update.
1327
1328 2019-06-25  Tom Tromey  <tom@tromey.com>
1329
1330         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1331         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1332         (tui_source_window_base::set_new_height): Update.
1333         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1334         Update.
1335         (tui_set_locator_fullname, tui_set_locator_info)
1336         (tui_show_frame_info): Update.
1337         * tui/tui-source.c (tui_set_source_content)
1338         (tui_source_is_displayed): Update.
1339         * tui/tui-layout.c (show_source_disasm_command, show_data)
1340         (show_source_or_disasm_and_command): Update.
1341         * tui/tui-disasm.c (tui_set_disassem_content)
1342         (tui_get_begin_asm_address): Update.
1343         * tui/tui-data.h (struct tui_locator_element): Remove.
1344         (union tui_which_element) <locator>: Remove.
1345         (struct tui_locator_window): New.
1346         (tui_locator_win_info_ptr): Change return type.
1347         * tui/tui-data.c (_locator): Change type.
1348         (tui_locator_win_info_ptr): Change return type.
1349         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1350         (tui_alloc_content): Add assert.
1351
1352 2019-06-25  Tom Tromey  <tom@tromey.com>
1353
1354         * tui/tui-winsource.c
1355         (tui_exec_info_window::maybe_allocate_content): New method.
1356         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1357         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1358         (make_source_or_disasm_window): Add cast.
1359         * tui/tui-data.h (union tui_which_element) <simple_string>:
1360         Remove.
1361         (struct tui_source_info): New.
1362         (struct tui_source_window_base) <execution_info>: Change type.
1363         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1364         case, and add assert.
1365         (tui_alloc_content): Add assert.
1366
1367 2019-06-25  Tom Tromey  <tom@tromey.com>
1368
1369         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1370         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1371         * tui/tui-data.c (tui_alloc_win_info): Remove.
1372
1373 2019-06-25  Tom Tromey  <tom@tromey.com>
1374
1375         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1376         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1377         can_highlight.
1378
1379 2019-06-25  Tom Tromey  <tom@tromey.com>
1380
1381         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1382         make_visible_with_new_height method.
1383         (tui_win_info::make_visible_with_new_height): New method.
1384         (tui_source_window_base::do_make_visible_with_new_height)
1385         (tui_data_window::do_make_visible_with_new_height)
1386         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1387         (make_visible_with_new_height): Remove.
1388         (tui_resize_all, tui_adjust_win_heights): Use
1389         make_visible_with_new_height method.
1390         * tui/tui-data.h (struct tui_win_info)
1391         <do_make_visible_with_new_height, make_visible_with_new_height>:
1392         New methods.
1393         (struct tui_source_window_base, struct tui_data_window)
1394         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1395         methods.
1396
1397 2019-06-25  Tom Tromey  <tom@tromey.com>
1398
1399         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1400         method.
1401         (update_tab_width): Call update_tab_width method.
1402         * tui/tui-data.h (struct tui_win_info)
1403         (struct tui_source_window_base) <update_tab_width>: New methods.
1404
1405 2019-06-25  Tom Tromey  <tom@tromey.com>
1406
1407         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1408         parameter.
1409         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1410         parameter.
1411         (tui_gen_win_info::make_visible): Update.
1412         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1413         parameter.
1414         * tui/tui-data.h (enum tui_box): New enum.
1415         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1416
1417 2019-06-25  Tom Tromey  <tom@tromey.com>
1418
1419         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1420         init_and_make_win for EXEC_INFO_WIN.
1421         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1422         longer inline.
1423         (struct tui_win_info) <~tui_win_info>: Inline.
1424         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1425         Don't declare.
1426         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1427         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1428         Remove.
1429         (tui_initialize_static_data): Update.
1430         (~tui_gen_win_info): Handle more cleanup here.
1431         (~tui_source_window_base): Delete "execution_info".
1432         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1433
1434 2019-06-25  Tom Tromey  <tom@tromey.com>
1435
1436         * tui/tui-layout.c (make_command_window): Don't set
1437         can_highlight.
1438         (show_source_disasm_command): Call the reset method.
1439         (show_data): Don't set can_highlight.  Call the reset method.
1440         (tui_gen_win_info::reset): Rename from init_gen_win_info
1441         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1442         (show_source_or_disasm_and_command): Call the reset method.
1443         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1444         (struct tui_cmd_window): Set can_highlight.
1445
1446 2019-06-25  Tom Tromey  <tom@tromey.com>
1447
1448         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1449         from make_visible.
1450         (tui_make_visible, tui_make_invisible): Rewrite.
1451         (tui_win_info::make_visible): Remove.
1452         (tui_source_window_base::make_visible): Update.
1453         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1454         method.  Moved from...
1455         (struct tui_win_info) <make_visible>: ...here.
1456
1457 2019-06-25  Tom Tromey  <tom@tromey.com>
1458
1459         * tui/tui-winsource.c
1460         (tui_source_window_base::do_scroll_horizontal): Remove direction
1461         parameter.
1462         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1463         direction parameter.
1464         * tui/tui-win.c (tui_win_info::forward_scroll)
1465         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1466         (tui_win_info::right_scroll): Update.
1467         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1468         direction parameter.
1469         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1470         direction parameter.
1471         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1472         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1473         Remove direction parameter.
1474         (struct tui_source_window_base, struct tui_source_window)
1475         (struct tui_disasm_window, struct tui_data_window)
1476         (struct tui_cmd_window): Update.
1477
1478 2019-06-25  Tom Tromey  <tom@tromey.com>
1479
1480         * tui/tui-winsource.h (tui_set_exec_info_content)
1481         (tui_show_exec_info_content, tui_erase_exec_info_content)
1482         (tui_clear_exec_info_content, tui_update_exec_info): Change
1483         argument to tui_source_window_base.
1484         * tui/tui-winsource.c (tui_set_exec_info_content)
1485         (tui_show_exec_info_content, tui_erase_exec_info_content)
1486         (tui_clear_exec_info_content, tui_update_exec_info): Change
1487         argument to tui_source_window_base.
1488
1489 2019-06-25  Tom Tromey  <tom@tromey.com>
1490
1491         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1492         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1493
1494 2019-06-25  Tom Tromey  <tom@tromey.com>
1495
1496         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1497         check.
1498
1499 2019-06-25  Tom Tromey  <tom@tromey.com>
1500
1501         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1502         type to void.
1503         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1504         type to void.
1505         * tui/tui-source.c (tui_set_source_content): Update.
1506         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1507
1508 2019-06-25  Tom Tromey  <tom@tromey.com>
1509
1510         * tui/tui-win.c (window_name_completer, tui_set_focus)
1511         (tui_all_windows_info): Use name method.
1512         * tui/tui-data.h (struct tui_gen_win_info)
1513         (struct tui_source_window, struct tui_disasm_window)
1514         (struct tui_data_window, struct tui_cmd_window) <name>: New
1515         method.
1516         (tui_win_name): Don't declare.
1517         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1518         (tui_win_name): Remove.
1519
1520 2019-06-25  Tom Tromey  <tom@tromey.com>
1521
1522         * tui/tui-winsource.h (tui_update_source_window)
1523         (tui_update_source_window_as_is): Change parameter type.
1524         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1525         to be a tui_source_window_base.
1526         (tui_update_source_window_as_is): Likewise.
1527         * tui/tui-win.c (make_visible_with_new_height): Update.
1528
1529 2019-06-25  Tom Tromey  <tom@tromey.com>
1530
1531         * tui/tui-winsource.c (tui_erase_source_content)
1532         (tui_show_source_content, tui_show_exec_info_content)
1533         (tui_erase_exec_info_content): Use refresh_window method.
1534         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1535         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1536         from tui_refresh_win.
1537         (tui_data_window::refresh_window): New method.
1538         (tui_win_info::refresh, tui_source_window_base::refresh)
1539         (tui_refresh_all): Use refresh_window method.
1540         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1541         method.
1542         * tui/tui-regs.c (tui_display_register): Call refresh_window
1543         method.
1544         * tui/tui-layout.c (show_source_disasm_command)
1545         (show_source_or_disasm_and_command): Call refresh_window method.
1546         * tui/tui-data.h (struct tui_gen_win_info)
1547         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1548         New method.
1549
1550 2019-06-25  Tom Tromey  <tom@tromey.com>
1551
1552         * tui/tui.c (tui_rl_other_window, tui_enable)
1553         (tui_is_window_visible, tui_get_command_dimension): Update.
1554         * tui/tui-winsource.c (tui_update_source_window_as_is)
1555         (tui_clear_source_content, tui_erase_source_content)
1556         (tui_show_source_line, tui_source_window_base::refill)
1557         (tui_source_window_base::do_scroll_horizontal)
1558         (tui_source_window_base::set_is_exec_point_at)
1559         (tui_update_breakpoint_info, tui_set_exec_info_content)
1560         (tui_alloc_source_buffer, tui_line_is_displayed)
1561         (tui_addr_is_displayed): Update.
1562         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1563         (tui_check_and_display_highlight_if_needed)
1564         (tui_win_info::make_visible, tui_win_info::refresh)
1565         (tui_refresh_all): Update.
1566         * tui/tui-windata.c (tui_first_data_item_displayed)
1567         (tui_delete_data_content_windows, tui_erase_data_content)
1568         (tui_display_all_data, tui_data_window::refresh_all)
1569         (tui_check_data_values): Update.
1570         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1571         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1572         (tui_win_info::backward_scroll, tui_refresh_all_win)
1573         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1574         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1575         (tui_source_window_base::set_new_height)
1576         (tui_data_window::set_new_height)
1577         (make_invisible_and_set_new_height)
1578         (make_visible_with_new_height, new_height_ok)
1579         (parse_scrolling_args): Update.
1580         * tui/tui-stack.c (tui_show_frame_info): Update.
1581         * tui/tui-source.c (tui_set_source_content)
1582         (tui_set_source_content_nil, tui_source_is_displayed)
1583         (tui_source_window::do_scroll_vertical): Update.
1584         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1585         (tui_display_registers_from, tui_display_reg_element_at_line)
1586         (tui_check_register_values, tui_reg_command): Update.
1587         * tui/tui-layout.c (tui_default_win_height)
1588         (show_source_disasm_command, show_data, init_and_make_win)
1589         (show_source_or_disasm_and_command): Update.
1590         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1591         (tui_redisplay_readline, tui_mld_flush)
1592         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1593         (tui_getc): Update.
1594         * tui/tui-disasm.c (tui_set_disassem_content)
1595         (tui_disasm_window::do_scroll_vertical): Update.
1596         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1597         Now virtual.
1598         (struct tui_win_info): Derive from tui_gen_win_info.
1599         <~tui_win_info>: Mark as override.
1600         <generic>: Remove member.
1601         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1602         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1603         (~tui_data_window, ~tui_win_info)
1604         (tui_free_all_source_wins_content): Update.
1605         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1606
1607 2019-06-25  Tom Tromey  <tom@tromey.com>
1608
1609         * tui/tui-layout.c (init_and_make_win): Use new.
1610         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1611         destructor, initializers.
1612         (tui_alloc_generic_win_info): Don't declare.
1613         * tui/tui-data.c (_locator): Add argument to constructor.
1614         (source_win, disasm_win): New globals.
1615         (exec_info): Remove.
1616         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1617         Update.
1618         (tui_alloc_generic_win_info): Remove.
1619         (init_content_element): Use new.
1620         (tui_win_info::tui_win_info): Update.
1621         (free_content_elements) <case DATA_WIN>: Use delete.
1622
1623 2019-06-25  Tom Tromey  <tom@tromey.com>
1624
1625         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1626         * tui/tui-windata.c (tui_first_data_item_displayed)
1627         (tui_delete_data_content_windows): Update.
1628         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1629         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1630         (tui_display_registers_from, tui_check_register_values): Update.
1631         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1632         pointer.
1633         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1634         window.
1635         (tui_free_data_content): Update.
1636         (free_content_elements) <case DATA_WIN>: Free the window.
1637
1638 2019-06-25  Tom Tromey  <tom@tromey.com>
1639
1640         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1641         Update.
1642         * tui/tui-layout.c (make_command_window)
1643         (show_source_disasm_command, show_data, init_and_make_win)
1644         (show_source_or_disasm_and_command): Update.
1645         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1646         method.
1647         <can_highight, is_highlighted>: Now bool.
1648         (tui_set_win_highlight): Don't declare.
1649         * tui/tui-data.c (tui_set_win_highlight): Remove.
1650
1651 2019-06-25  Tom Tromey  <tom@tromey.com>
1652
1653         * tui/tui-wingeneral.c (make_visible): Remove check of window
1654         type.
1655
1656 2019-06-25  Tom Tromey  <tom@tromey.com>
1657
1658         * tui/tui-win.c (tui_win_info::max_height)
1659         (tui_cmd_window::max_height): New methods.
1660         (new_height_ok): Call max_height.
1661         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1662         <max_height>: New method.
1663
1664 2019-06-25  Tom Tromey  <tom@tromey.com>
1665
1666         * tui/tui-win.c (tui_source_window_base::set_new_height)
1667         (tui_data_window::set_new_height): New methods.
1668         (make_invisible_and_set_new_height): Call set_new_height method.
1669         * tui/tui-data.h (struct tui_win_info)
1670         (struct tui_source_window_base, struct tui_data_window)
1671         <set_new_height>: New method.
1672
1673 2019-06-25  Tom Tromey  <tom@tromey.com>
1674
1675         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1676         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1677         tui_refresh_data_win.
1678         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1679         method.
1680         (tui_refresh_all_win): Call the refresh_all method.
1681         (tui_set_focus): Likewise.
1682         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1683         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1684         Likewise.
1685
1686 2019-06-25  Tom Tromey  <tom@tromey.com>
1687
1688         * tui/tui-winsource.h (tui_refill_source_window)
1689         (tui_set_is_exec_point_at): Don't declare.
1690         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1691         (tui_source_window_base::refill): Rename from
1692         tui_refill_source_window.
1693         (tui_source_window_base::do_scroll_horizontal): Update.
1694         (tui_source_window_base::set_is_exec_point_at): Rename from
1695         tui_set_is_exec_point_at.
1696         (tui_update_all_breakpoint_info): Update.
1697         * tui/tui-stack.c (tui_show_frame_info): Update.
1698         * tui/tui-layout.c (show_data): Add cast.
1699         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1700         * tui/tui-data.h (struct tui_source_window_base) <refill,
1701         set_is_exec_point_at>: New methods.
1702         (tui_source_windows, tui_add_to_source_windows): Update types.
1703         (tui_add_to_source_windows): Remove redundant declaration.
1704         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1705         (tui_source_windows): Change return type.
1706         (tui_clear_source_windows_detail): Update.
1707         (tui_add_to_source_windows): Change type of parameter.
1708         (tui_free_all_source_wins_content): Update.
1709
1710 2019-06-25  Tom Tromey  <tom@tromey.com>
1711
1712         * tui/tui-wingeneral.c (tui_win_info::refresh)
1713         (tui_source_window_base::refresh): New methods.
1714         (tui_refresh_all): Call the refresh method.
1715         * tui/tui-data.h (struct tui_win_info)
1716         (struct tui_source_window_base) <refresh>: New method.
1717
1718 2019-06-25  Tom Tromey  <tom@tromey.com>
1719
1720         * tui/tui.h (tui_is_window_visible): Return bool.
1721         * tui/tui.c (tui_is_window_visible): Return bool.
1722         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1723         (tui_make_visible, tui_make_invisible)
1724         (tui_win_info::make_visible)
1725         (tui_source_window_base::make_visible, make_all_visible)
1726         (tui_make_all_visible, tui_make_all_invisible): Update.
1727         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1728         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1729         bool.
1730         (struct tui_win_info, struct tui_source_window_base)
1731         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1732         * tui/tui-data.c (tui_init_generic_part): Update.
1733
1734 2019-06-25  Tom Tromey  <tom@tromey.com>
1735
1736         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1737         (tui_source_window_base::make_visible): New methods.
1738         (make_all_visible): Make method call.
1739         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1740         (struct tui_source_window_base, struct tui_cmd_window): Override
1741         make_visible.
1742         (tui_win_is_source_type): Don't declare.
1743         * tui/tui-data.c (tui_win_is_source_type): Remove.
1744
1745 2019-06-25  Tom Tromey  <tom@tromey.com>
1746
1747         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1748         NULL check.
1749
1750 2019-06-25  Tom Tromey  <tom@tromey.com>
1751
1752         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1753         Inline constructor.  Add initializers for members.
1754         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1755         constructors; now inline in class.
1756
1757 2019-06-25  Tom Tromey  <tom@tromey.com>
1758
1759         * tui/tui-regs.c (tui_show_registers): Update.
1760         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1761         bool.
1762         * tui/tui-data.c (tui_data_window::clear_detail)
1763         (tui_data_window): Update.
1764
1765 2019-06-25  Tom Tromey  <tom@tromey.com>
1766
1767         * tui/tui-windata.c (tui_display_all_data)
1768         (tui_display_data_from_line, tui_display_data_from)
1769         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1770         Update.
1771         * tui/tui-regs.c (tui_last_regs_line_no)
1772         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1773         (tui_show_registers, tui_show_register_group)
1774         (tui_display_registers_from, tui_display_reg_element_at_line)
1775         (tui_display_registers_from_line, tui_check_register_values)
1776         (tui_reg_next, tui_reg_prev): Update.
1777         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1778         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1779         tui_data_window.
1780         (struct tui_win_info) <detail>: Remove.  Add new fields from
1781         tui_data_info.
1782         (TUI_DATA_WIN): Add cast.
1783         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1784         (~tui_data_window): Simplify.
1785
1786 2019-06-25  Tom Tromey  <tom@tromey.com>
1787
1788         * tui/tui-layout.c (show_source_disasm_command)
1789         (show_source_or_disasm_and_command): Update.
1790         * tui/tui-io.c (update_cmdwin_start_line)
1791         (tui_redisplay_readline): Update.
1792         * tui/tui-data.h (struct tui_command_info): Remove.
1793         (struct tui_win_info) <detail>: Remove command_info member.
1794         (struct tui_data_window) <start_line>: New member, from
1795         tui_command_info.
1796         (TUI_CMD_WIN): Add casts.
1797
1798 2019-06-25  Tom Tromey  <tom@tromey.com>
1799
1800         * tui/tui-winsource.c (tui_update_source_window)
1801         (tui_refill_source_window)
1802         (tui_source_window_base::do_scroll_horizontal)
1803         (tui_update_breakpoint_info, tui_set_exec_info_content)
1804         (tui_show_exec_info_content, tui_erase_exec_info_content)
1805         (tui_clear_exec_info_content): Update.
1806         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1807         Update.
1808         * tui/tui-win.c (make_invisible_and_set_new_height)
1809         (make_visible_with_new_height): Update.
1810         * tui/tui-source.c (tui_set_source_content)
1811         (tui_show_symtab_source): Update.
1812         * tui/tui-layout.c (extract_display_start_addr)
1813         (show_source_disasm_command, show_data)
1814         (make_source_or_disasm_window)
1815         (show_source_or_disasm_and_command): Update.
1816         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1817         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1818         "gdbarch".
1819         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1820         to tui_source_window_base.
1821         (struct tui_win_info) <detail>: Remove source_info member.
1822         (struct tui_source_window_base) <has_locator>: Inline.
1823         Move contents from tui_source_info; rename has_locator member to
1824         m_has_locator.
1825         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1826         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1827         header file.
1828         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1829         Simplify.
1830         (tui_free_all_source_wins_content): Cast to
1831         tui_source_window_base.
1832
1833 2019-06-25  Tom Tromey  <tom@tromey.com>
1834
1835         * tui/tui-win.c (make_invisible_and_set_new_height)
1836         (make_visible_with_new_height): Call has_locator method.
1837         * tui/tui-layout.c (show_source_disasm_command, show_data)
1838         (show_source_or_disasm_and_command): Update for bool change.
1839         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1840         (tui_win_info) <has_locator>: New method.
1841         (struct tui_source_window_base) <has_locator>: New method.
1842         (tui_win_has_locator): Don't declare.
1843         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1844         from tui_win_has_locator.
1845         (tui_source_window_base): Use false, not FALSE.
1846
1847 2019-06-25  Tom Tromey  <tom@tromey.com>
1848
1849         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1850         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1851         clear_detail method directly.
1852         (tui_clear_win_detail): Remove.
1853
1854 2019-06-25  Tom Tromey  <tom@tromey.com>
1855
1856         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1857         "this", not TUI_DISASM_WIN.
1858
1859 2019-06-25  Tom Tromey  <tom@tromey.com>
1860
1861         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1862         declare.
1863         * tui/tui-winsource.c
1864         (tui_source_window_base::do_scroll_horizontal): Rename from
1865         tui_horizontal_source_scroll.
1866         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1867         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1868         from tui_vertical_data_scroll.
1869         * tui/tui-win.h (tui_scroll): Don't declare.
1870         * tui/tui-win.c (tui_win_info::forward_scroll)
1871         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1872         (tui_win_info::right_scroll): Rename and update.
1873         (tui_scroll_forward_command, tui_scroll_backward_command)
1874         (tui_scroll_left_command, tui_scroll_right_command): Update.
1875         (tui_scroll): Remove.
1876         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1877         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1878         from tui_vertical_source_scroll.
1879         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1880         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1881         from tui_vertical_disassem_scroll.
1882         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1883         do_scroll_horizontal>: New methods.
1884         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1885         Likewise.
1886         (struct tui_source_window_base): Add do_scroll_horizontal.
1887         (struct tui_source_window, struct tui_disasm_window): Add
1888         do_scroll_vertical.
1889         (struct tui_data_window, struct tui_cmd_window): Add
1890         do_scroll_horizontal and do_scroll_vertical.
1891         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1892
1893 2019-06-25  Tom Tromey  <tom@tromey.com>
1894
1895         * tui/tui-data.h (struct tui_source_window_base): New struct.
1896         (struct tui_source_window): Derive from tui_source_window_base.
1897         (struct tui_disasm_window): New struct.
1898         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1899         from tui_source_window::clear_detail.
1900         (tui_source_window_base): Rename from tui_source_window.
1901         (~tui_source_window_base): Rename from ~tui_source_window.
1902         (tui_alloc_win_info): Create a tui_disasm_window.
1903
1904 2019-06-25  Tom Tromey  <tom@tromey.com>
1905
1906         * tui/tui-data.h (struct tui_source_window)
1907         (struct tui_data_window): Declare destructors.
1908         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1909         destructors.
1910         (tui_win_info): Simplify.
1911
1912 2019-06-25  Tom Tromey  <tom@tromey.com>
1913
1914         * tui/tui-winsource.c (tui_display_main)
1915         (tui_update_source_windows_with_addr)
1916         (tui_update_all_breakpoint_info): Update.
1917         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1918         (new_height_ok, parse_scrolling_args): Update.
1919         * tui/tui-stack.c (tui_show_frame_info): Update.
1920         * tui/tui-data.h (struct tui_list): Remove.
1921         (tui_source_windows): Return a reference to a std::vector.
1922         * tui/tui-data.c (source_windows): Now a std::vector.
1923         (tui_source_windows): Change return type.
1924         (tui_clear_source_windows): Rewrite.
1925         (tui_clear_source_windows_detail, tui_add_to_source_windows)
1926         (tui_free_all_source_wins_content): Rewrite.
1927
1928 2019-06-25  Tom Tromey  <tom@tromey.com>
1929
1930         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
1931         (struct tui_data_window, struct tui_cmd_window): Declare
1932         clear_detail method.
1933         * tui/tui-data.c (tui_source_window::clear_detail)
1934         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
1935         methods.
1936         (tui_clear_win_detail): Simplify.
1937
1938 2019-06-25  Tom Tromey  <tom@tromey.com>
1939
1940         * tui/tui-layout.c (make_source_window, make_disasm_window)
1941         (make_source_or_disasm_window): Remove win_info_ptr parameter.
1942         Return the new window.
1943         (show_source_disasm_command, show_data)
1944         (show_source_or_disasm_and_command): Update.
1945
1946 2019-06-25  Tom Tromey  <tom@tromey.com>
1947
1948         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
1949         parameter.  Return the new window.
1950         (show_source_disasm_command): Update and remove NULL check.
1951         (show_source_or_disasm_and_command): Update.
1952
1953 2019-06-25  Tom Tromey  <tom@tromey.com>
1954
1955         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
1956
1957 2019-06-25  Tom Tromey  <tom@tromey.com>
1958
1959         * tui/tui-data.h (struct tui_win_info): Make constructor
1960         protected.  Make destructor virtual.  Add initializers.
1961         (tui_source_window, tui_data_window, tui_cmd_window): New
1962         classes.
1963         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
1964         constructor.  Add "type" parameter.
1965         (tui_source_window, tui_data_window, tui_cmd_window): New
1966         constructors.
1967         (tui_alloc_win_info): Instantiate the appropriate subclass.
1968
1969 2019-06-25  Tom Tromey  <tom@tromey.com>
1970
1971         * tui/tui-win.c (tui_resize_all): Use delete.
1972         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
1973         destructor.
1974         (tui_free_window): Don't declare.
1975         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
1976         Update.
1977
1978 2019-06-25  Tom Tromey  <tom@tromey.com>
1979
1980         * tui/tui-data.h (struct tui_win_info): Add constructor.
1981         * tui/tui-data.c (tui_alloc_win_info): Use new.
1982         (tui_free_window): Use delete.
1983
1984 2019-06-22  Tom Tromey  <tom@tromey.com>
1985
1986         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
1987         declare.
1988         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
1989
1990 2019-06-22  Tom Tromey  <tom@tromey.com>
1991
1992         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
1993         declare.
1994         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
1995
1996 2019-06-22  Tom de Vries  <tdevries@suse.de>
1997
1998         * dwarf2read.c (create_addrmap_from_aranges)
1999         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2000         instead of '%zu'.
2001
2002 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2003
2004         * dwarf2read.h (dwarf2_section_info_def): Remove.
2005         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2006         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2007         std::vector<dwarf2_section_info>.
2008         (struct dwo_file) <~dwo_file>: Remove.
2009         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2010         types field.
2011         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2012         (dwarf2_read_debug_names): Likewise.
2013         (create_debug_types_hash_table): Change parameter type to
2014         array_view, adjust code accordingly.
2015         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2016         (partial_die_info::fixup): Likewise.
2017         (determine_prefix): Likewise.
2018         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2019
2020 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2021
2022         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2023         gdb_bfd_ref_ptr.
2024         <~dwo_file>: Remove call to gdb_bfd_unref.
2025         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2026         gdb_bfd_ref_ptr::get.
2027
2028 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2029
2030         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2031         type to htab_up.
2032         * dwarf2read.c (struct dwo_file): Initialize fields.
2033         <~dwo_file>: New.
2034         (free_dwo_file): Remove, move content to ~dwo_file.
2035         (struct dwo_file_deleter): Remove.
2036         (dwo_file_up>: Remove custom deleter.
2037         (free_dwo_files): Remove.
2038         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2039         dwo_files.
2040         (process_skeletonless_type_units): Call unique_ptr::get.
2041         (allocate_dwo_file_hash_table): Add deleter to created hash
2042         table.  Change return type to htab_up.
2043         (lookup_dwo_file_slot): Don't memset dwo_file, call
2044         unique_ptr::get.
2045         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2046         (create_dwo_unit_in_dwp_v2): Likewise.
2047         (open_and_init_dwo_file): Likewise.
2048         (free_dwo_file_from_slot): Remove.
2049
2050 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2051
2052         * dwarf2read.h (struct dwarf2_section_info) <readin,
2053         is_virtual>: Change type to bool.
2054         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2055         true instead of 1.
2056
2057 2019-06-19  Tom Tromey  <tom@tromey.com>
2058
2059         * tui/tui-data.h (tui_init_content_element): Don't declare.
2060
2061 2019-06-19  Tom Tromey  <tom@tromey.com>
2062
2063         * tui/tui-data.h (tui_init_win_info): Don't declare.
2064
2065 2019-06-19  Tom de Vries  <tdevries@suse.de>
2066
2067         * dwarf2read.h (abstract_to_concrete): Change type to
2068         std::unordered_map<sect_offset, std::vector<sect_offset>,
2069         gdb::hash_enum<sect_offset>>.
2070
2071 2019-06-19  Tom Tromey  <tromey@adacore.com>
2072
2073         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2074         EVAL_AVOID_SIDE_EFFECTS specially.
2075
2076 2019-06-19  Tom Tromey  <tromey@adacore.com>
2077
2078         * source-cache.c (highlighter): New global.
2079         (source_cache::get_source_lines): Create a highlighter on demand.
2080
2081 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2082
2083         * defs.h (deprecated_interactive_hook): Delete declaration.
2084         * interps.c (clear_interpreter_hooks): Remove use of
2085         deprecated_interactive_hook.
2086         * top.c (deprecated_interactive_hook): Delete definition.
2087         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2088
2089 2019-06-18  Tom de Vries  <tdevries@suse.de>
2090
2091         PR gdb/24515
2092         * dwarf2read.h (abstract_to_concrete): Change type from
2093         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2094         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2095         * dwarf2read.c (read_variable): Update.
2096         (dwarf2_fetch_die_loc_sect_off): Update.
2097
2098 2019-06-17  Tom de Vries  <tdevries@suse.de>
2099
2100         PR gdb/24617
2101         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2102         accessing parent[parent_len - 1].
2103
2104 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2105
2106         PR gdb/24364
2107         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2108         call dtrace_process_dof with NULL dof.
2109
2110 2019-06-16  Tom de Vries  <tdevries@suse.de>
2111
2112         PR gdb/24445
2113         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2114
2115 2019-06-16  Tom Tromey  <tom@tromey.com>
2116
2117         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2118         (make_all_visible): Use address of member.
2119
2120 2019-06-16  Tom Tromey  <tom@tromey.com>
2121
2122         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2123         (tui_free_window, free_content, free_content_elements): Remove
2124         unnecessary cast.
2125         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2126         cast.
2127         * tui/tui-regs.c (tui_show_register_group)
2128         (tui_display_registers_from, tui_display_reg_element_at_line):
2129         Remove unnecessary cast.
2130
2131 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2132
2133         * linux-nat.c (normal_mask): Delete.
2134         (_initialize_linux_nat): Don't initialise normal_mask.
2135
2136 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2137
2138         PR gdb/24445
2139         * dwarf-index-write.h (write_psymtabs_to_index): Add
2140         dwz_basename parameter.
2141         * dwarf-index-write.c (write_gdbindex): Move file writing to
2142         write_gdbindex_1.  Change return type void.
2143         (assert_file_size): Move up, remove filename parameter.
2144         (write_gdbindex_1): New function.
2145         (write_debug_names): Change return type to void, call
2146         assert_file_size.
2147         (struct index_wip_file): New struct.
2148         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2149         file logic to index_wip_file.  Write index for dwz file if
2150         needed.
2151         (save_gdb_index_command): Pass basename of dwz file, if present.
2152         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2153         build-id of dwz file, if present.
2154         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2155         (dwarf2_get_dwz_file): Likewise.
2156         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2157         (dwarf2_get_dwz_file): Likewise.
2158
2159 2019-06-16  Tom Tromey  <tom@tromey.com>
2160
2161         * coffread.c (process_coff_symbol): Use xstrdup.
2162         * value.c (create_internalvar): Use xstrdup.
2163
2164 2019-06-16  Tom Tromey  <tom@tromey.com>
2165
2166         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2167         * breakpoint.c (stopin_command, stopat_command)
2168         (until_break_command, decode_location_default): Remove unnecessary
2169         cast.
2170         * utils.c (subset_compare): Remove unnecessary cast.
2171         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2172         cast.
2173         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2174         cast.
2175         * infcmd.c (path_command): Remove unnecessary cast.
2176         * coffread.c (decode_type): Remove unnecessary cast.
2177         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2178         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2179         * tui/tui-stack.c (tui_show_locator_content)
2180         (tui_show_frame_info): Remove unnecessary cast.
2181         * tui/tui-win.c (tui_scroll_forward_command)
2182         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2183         (parse_scrolling_args): Remove unnecessary cast.
2184         * tui/tui-data.c (init_win_info, tui_del_window)
2185         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2186         (free_content_elements): Remove unnecessary cast.
2187         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2188         unnecessary cast.
2189         * tui/tui-source.c (tui_set_source_content)
2190         (tui_vertical_source_scroll): Remove unnecessary cast.
2191         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2192         cast.
2193         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2194         * tui/tui-regs.c (tui_display_registers_from)
2195         (tui_display_register): Remove unnecessary cast.
2196         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2197         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2198         (make_visible): Remove unnecessary cast.
2199         * tui/tui-winsource.c (tui_erase_source_content)
2200         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2201         unnecessary cast.
2202         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2203         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2204         * stabsread.c (read_type, read_array_type, read_range_type):
2205         Remove unnecessary cast.
2206         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2207         (parse_symbol, parse_type, upgrade_type, parse_external)
2208         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2209         unnecessary cast.
2210         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2211
2212 2019-06-16  Tom Tromey  <tom@tromey.com>
2213
2214         * tui/tui-data.c (tui_alloc_generic_win_info)
2215         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2216         checks.
2217
2218 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2219             Andrew Burgess  <andrew.burgess@embecosm.com>
2220
2221         * f-typeprint.c (f_print_type): Don't return early for not
2222         associated or not allocated types.
2223         (f_type_print_varspec_suffix): Add print_rank parameter and print
2224         ranks of array types in case they dangling.
2225         (f_type_print_base): Add print_rank parameter.
2226
2227 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2228
2229         * NEWS: Mention new MI commands.
2230         * break-catch-throw.c (enum exception_event_kind): Move to
2231         breakpoint.h.
2232         (print_mention_exception_catchpoint): Output text as a single
2233         message.
2234         (catch_exception_command_1): Rename to...
2235         (catch_exception_event): ...this, make non-static, update header
2236         command, and change some parameter types.
2237         (catch_catch_command): Update for changes to
2238         catch_exception_command_1.
2239         (catch_throw_command): Likewise.
2240         (catch_rethrow_command): Likewise.
2241         * breakpoint.c (enum exception_event_kind): Delete.
2242         * breakpoint.h (enum exception_event_kind): Moved here from
2243         break-catch-throw.c.
2244         (catch_exception_event): Declare.
2245         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2246         (mi_cmd_catch_throw): New function.
2247         (mi_cmd_catch_rethrow): New function.
2248         (mi_cmd_catch_catch): New function.
2249         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2250         'catch-catch' entries.
2251         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2252         (mi_cmd_catch_rethrow): Declare.
2253         (mi_cmd_catch_catch): Declare.
2254
2255 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2256
2257         * annotate.c (annotate_source_line): Change return type to void,
2258         update implementation to match.
2259         * annotate.h (annotate_source_line): Change return type to void,
2260         update header comment.
2261         * stack.c (print_frame_info): Don't change what frame information
2262         is printed based on whether annotations are on or not.
2263
2264 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2265
2266         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2267         (annotate_source): Make static.
2268         (annotate_source_line): Moved from source.c and renamed from
2269         identify_source_line.  Update the return type.
2270         * annotate.h (annotate_source): Delete declaration.
2271         (annotate_source_line): Declaration moved from source.h, and
2272         renamed from identify_source_line.  Return type updated.
2273         * source.c (identify_source_line): Moved to annotate.c and renamed
2274         to annotate_source_line.
2275         (info_line_command): Remove check of annotation_level.
2276         * source.h (identify_source_line): Move declaration to annotate.h
2277         and rename to annotate_source_line.
2278         * stack.c: Add 'annotate.h' include.
2279         (print_frame_info): Remove check of annotation_level before
2280         calling annotate_source_line.
2281
2282 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2283
2284         * source-cache.c (source_cache::get_plain_source_lines): Use
2285         open_source_file_with_line_charpos instead of just
2286         open_source_file, remove call to find_source_lines.
2287         (source_cache::get_source_lines): Likewise.
2288         * source.c (find_source_lines): Make static.
2289         (get_filename_and_charpos): Renamed into...
2290         (open_source_file_with_line_charpos): ..this along with changes to
2291         return a scoped_fd, and some other minor clean ups.
2292         (identify_source_line): Use open_source_file_with_line_charpos.
2293         (search_command_helper): Use open_source_file_with_line_charpos
2294         instead of just open_source_file, remove call to
2295         find_source_lines.
2296         * source.h (open_source_file_with_line_charpos): Declare new
2297         function.
2298         (find_source_lines): Delete declaration.
2299
2300 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2301
2302         * source.c (get_filename_and_charpos): Remove fullname
2303         parameter.
2304         (identify_source_line): Update call to get_filename_and_charpos.
2305
2306 2019-06-14  Tom Tromey  <tromey@adacore.com>
2307
2308         PR gdb/24502:
2309         * ui-style.h (skip_ansi_escape): Update comment.
2310         * ui-file.h (class no_terminal_escape_file): New class.
2311         * ui-file.c (no_terminal_escape_file::write)
2312         (no_terminal_escape_file::puts): New methods.
2313         * cli/cli-logging.c (handle_redirections): Use
2314         no_terminal_escape_file.
2315
2316 2019-06-14  Tom Tromey  <tromey@adacore.com>
2317
2318         * NEWS: Move convenience variable news above Python news.
2319
2320 2019-06-14  Tom Tromey  <tom@tromey.com>
2321
2322         * gnulib: Move directory to top-level.
2323         * configure.ac: Don't configure gnulib.
2324         * configure: Rebuild.
2325         * common/common-defs.h: Use new path to gnulib.
2326         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2327         (GNULIB_H): Remove.
2328         (INCGNU): Look in new gnulib location.
2329         (HFILES_NO_SRCDIR): Remove gnulib files.
2330         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2331         (generated_files): Remove GNULIB_H.
2332         ($(LIBGNU), all-lib): Remove targets.
2333         (distclean): Don't mention GNULIB_BUILDDIR.
2334         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2335
2336 2019-06-14  Tom Tromey  <tromey@adacore.com>
2337
2338         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2339         Warn if symbol file does not provide any symbols.
2340
2341 2019-06-14  Tom Tromey  <tromey@adacore.com>
2342
2343         * source.c (find_and_open_source): Respect basenames_may_differ.
2344
2345 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2346
2347         * annotate.c (annotate_breakpoints_invalid): Make use of
2348         scoped_restore_terminal_state.
2349         (annotate_frames_invalid): Likewise.
2350
2351 2019-06-14  Tom Tromey  <tromey@adacore.com>
2352
2353         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2354         allow assignment to an internalvar.
2355
2356 2019-06-14  Tom Tromey  <tromey@adacore.com>
2357
2358         * ada-lex.l: Allow "_" in attribute names.
2359
2360 2019-06-14  Tom Tromey  <tromey@adacore.com>
2361
2362         PR gdb/24653:
2363         * regcache.c (registers_changed): Don't call alloca.
2364         * top.c (execute_command): Don't call alloca.
2365
2366 2019-06-13  Pedro Alves  <palves@redhat.com>
2367
2368         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2369         'expression'.  When parsing an expression, error out if there's
2370         junk after "unlimited".
2371         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2372         (do_set_command): Adjust calls to is_unlimited_literal.
2373
2374 2019-06-13  Pedro Alves  <palves@redhat.com>
2375
2376         * compile/compile.c (make_compile_options_def_group): Add braces
2377         around array_view initializer.
2378         * thread.c (make_thread_apply_all_options_def_group)
2379         (make_thread_apply_all_options_def_group): Likewise.
2380
2381 2019-06-13  Pedro Alves  <palves@redhat.com>
2382
2383         * NEWS (New commands): Mention "maint test-options
2384         require-delimiter", "maint test-options unknown-is-error", "maint
2385         test-options unknown-is-operand" and "maint show
2386         test-options-completion-result".
2387         (New command options, command completion): New section.
2388         (Completion improvements): New section.
2389         Mention that you can abbreviate "unlimited".
2390
2391 2019-06-13  Pedro Alves  <palves@redhat.com>
2392
2393         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2394         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2395         * unittests/cli-utils-selftests.c (test_parse_flags)
2396         (test_parse_flags_qcs): Delete.
2397         (test_cli_utils): Don't call deleted functions.
2398
2399 2019-06-13  Pedro Alves  <palves@redhat.com>
2400
2401         * thread.c: Include "cli/cli-option.h".
2402         (tp_array_compar_ascending): Global.
2403         (tp_array_compar): Delete function.
2404         (tp_array_compar_ascending, tp_array_compar_descending): New
2405         functions.
2406         (ascending_option_def, qcs_flag_option_def)
2407         (thr_qcs_flags_option_defs)
2408         (make_thread_apply_all_options_def_group)
2409         (make_thread_apply_options_def_group): New.
2410         (thread_apply_all_command): Use gdb::option::process_options.
2411         (thread_apply_command_completer)
2412         (thread_apply_all_command_completer): New.
2413         (thread_apply_command): Use gdb::option::process_options.
2414         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2415         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2416         to generate help text of "thread apply".  Adjust "taas"'s help.
2417         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2418         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2419
2420 2019-06-13  Pedro Alves  <palves@redhat.com>
2421
2422         * thread.c (thread_apply_command): Check for invalid TID with
2423         isdigit instead of !isalpha.
2424
2425 2019-06-13  Pedro Alves  <palves@redhat.com>
2426
2427         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2428         (validate_flags_qcs): New.
2429         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2430         (validate_flags_qcs): Declare.
2431         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2432         (make_frame_apply_options_def_group): New.
2433         (frame_apply_command_count): Process options with
2434         gdb::option::process_options.
2435         (frame_apply_completer): New.
2436         (frame_apply_level_completer, frame_apply_all_completer)
2437         (frame_apply_completer): New.
2438         (_initialize_stack): Update help of "frame apply", "frame apply
2439         level", "frame apply all" and "faas" to mention supported options
2440         and install command completers.
2441         * stack.h (frame_apply_all_completer): Declare.
2442         * thread.c: Include "stack.h".
2443         (tfaas_command): Add "--".
2444         (_initialize_thread): Update help "tfaas" to mention supported
2445         options and install command completer.
2446
2447 2019-06-13  Pedro Alves  <palves@redhat.com>
2448
2449         * completer.c (complete_nested_command_line): New.
2450         (gdb_completion_word_break_characters_throw): Add assertion.
2451         * completer.h (complete_nested_command_line): Declare.
2452
2453 2019-06-13  Pedro Alves  <palves@redhat.com>
2454
2455         * stack.c (parse_backtrace_qualifiers): New.
2456         (backtrace_command): Use it.
2457         (backtrace_command_completer): Complete on qualifiers.
2458
2459 2019-06-13  Pedro Alves  <palves@redhat.com>
2460
2461         * frame.c: Include "cli/cli-option.h.
2462         (user_set_backtrace_options): New.
2463         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2464         Delete.
2465         (get_prev_frame): Adjust.
2466         (boolean_option_def, uinteger_option_def)
2467         (set_backtrace_option_defs): New.
2468         (_initialize_frame): Adjust and use
2469         gdb::option::add_setshow_cmds_for_options to install "set
2470         backtrace past-main" and "set backtrace past-entry".
2471         * frame.h: Include "cli/cli-option.h".
2472         (struct frame_print_options): Forward declare.
2473         (print_frame_arguments_all, print_frame_arguments_scalars)
2474         (print_frame_arguments_none): Declare.
2475         (print_entry_values): Delete declaration.
2476         (struct frame_print_options, user_frame_print_options): New.
2477         (struct set_backtrace_options): New.
2478         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2479         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2480         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2481         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2482         (list_args_or_locals): Add frame_print_options parameter.
2483         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2484         * python/py-framefilter.c (enumerate_args): Pass down
2485         USER_FRAME_PRINT_OPTIONS.
2486         * stack.c: Include "cli/cli-option.h".
2487         (print_frame_arguments_all, print_frame_arguments_scalars)
2488         (print_frame_arguments_none): Declare.
2489         (print_raw_frame_arguments, print_entry_values): Delete.
2490         (user_frame_print_options): New.
2491         (boolean_option_def, enum_option_def, frame_print_option_defs):
2492         New.
2493         (struct backtrace_cmd_options): New.
2494         (bt_flag_option_def): New.
2495         (backtrace_command_option_defs): New.
2496         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2497         (print_frame_arg, read_frame_arg, print_frame_args)
2498         (print_frame_info, print_frame): Add frame_print_options parameter
2499         and use it.
2500         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2501         (backtrace_command_1): Add frame_print_options and
2502         backtrace_cmd_options parameters and use them.
2503         (make_backtrace_options_def_group): New.
2504         (backtrace_command): Process command options with
2505         gdb::option::process_options.
2506         (backtrace_command_completer): New.
2507         (_initialize_stack): Extend "backtrace"'s help to mention
2508         supported options.  Install completer for "backtrace".
2509         Install some settings commands with add_setshow_cmds_for_options.
2510
2511 2019-06-13  Pedro Alves  <palves@redhat.com>
2512
2513         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2514         and that "set/show print raw frame-arguments" are now deprecated.
2515
2516         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2517         command.
2518         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2519         * stack.c (_initialize_stack): Install "set/show print
2520         raw-frame-arguments", and deprecate "set/show print raw
2521         frame-arguments".
2522         * valprint.c (_initialize_valprint): Deprecate "set/show print
2523         raw".
2524
2525 2019-06-13  Pedro Alves  <palves@redhat.com>
2526
2527         * compile/compile.c (struct compile_options): New.
2528         (compile_flag_option_def, compile_command_option_defs)
2529         (make_compile_options_def_group): New.
2530         (compile_file_command): Handle options with
2531         gdb::option::process_options.
2532         (compile_file_command_completer): New function.
2533         (compile_code_command): Handle options with
2534         gdb::option::process_options.
2535         (compile_code_command_completer): New function.
2536         (_initialize_compiler): Install completers for "compile code" and
2537         "compile file".  Mention available options in "compile code" and
2538         "compile code"'s help.
2539         * completer.c (advance_to_completion_word): New, factored out from
2540         ...
2541         (advance_to_expression_complete_word_point): ... this.
2542         (advance_to_filename_complete_word_point): New.
2543         * completer.h (advance_to_filename_complete_word_point): New
2544         declaration.
2545
2546 2019-06-13  Pedro Alves  <palves@redhat.com>
2547
2548         * compile/compile.c: Include "cli/cli-option.h".
2549         (compile_print_value): Scope data pointer is now a
2550         value_print_options pointer; adjust.
2551         (compile_print_command): Process options.  Scope data pointer is
2552         now a value_print_options pointer; adjust.
2553         (_initialize_compile): Update "compile print"'s help to include
2554         supported options.  Install a completer for "compile print".
2555         * cp-valprint.c (show_vtblprint, show_objectprint)
2556         (show_static_field_print): Delete.
2557         (_initialize_cp_valprint): Don't install "set print
2558         static-members", "set print vtbl", "set print object" here.
2559         * printcmd.c: Include "cli/cli-option.h" and
2560         "common/gdb_optional.h".
2561         (print_command_parse_format): Rework to fill in a
2562         value_print_options instead of a format_data.
2563         (print_value): Change parameter type from format_data pointer to
2564         value_print_options reference.  Adjust.
2565         (print_command_1): Process options.  Adjust to pass down a
2566         value_print_options.
2567         (print_command_completer): New.
2568         (_initialize_printcmd): Install print_command_completer as
2569         handle_brkchars completer for the "print" command.  Update
2570         "print"'s help to include supported options.
2571         * valprint.c: Include "cli/cli-option.h".
2572         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2573         here from cp-valprint.c.
2574         (boolean_option_def, uinteger_option_def)
2575         (value_print_option_defs, make_value_print_options_def_group):
2576         New.  Use gdb::option::add_setshow_cmds_for_options to install
2577         "set print elements", "set print null-stop", "set print repeats",
2578         "set print pretty", "set print union", "set print array", "set
2579         print address", "set print symbol", "set print array-indexes".
2580         * valprint.h: Include <string> and "cli/cli-option.h".
2581         (make_value_print_options_def_group): Declare.
2582         (print_value): Change parameter type from format_data pointer to
2583         value_print_options reference.
2584         (print_command_completer): Declare.
2585
2586 2019-06-13  Pedro Alves  <palves@redhat.com>
2587
2588         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2589         (COMMON_SFILES): Add maint-test-settings.c.
2590         * cli/cli-decode.c (boolean_enums): New global, factored out from
2591         ...
2592         (add_setshow_boolean_cmd): ... here.
2593         * cli/cli-decode.h (boolean_enums): Declare.
2594         * cli/cli-option.c: New file.
2595         * cli/cli-option.h: New file.
2596         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2597         factored out from ...
2598         (parse_cli_boolean_value(const char *)): ... this.
2599         (is_unlimited_literal): Change parameter type to pointer to
2600         pointer.  Adjust and advance ARG pointer.
2601         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2602         (parse_cli_var_enum): New, factored out from ...
2603         (do_set_command): ... this.  Adjust.
2604         * cli/cli-setshow.h (parse_cli_boolean_value)
2605         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2606         (parse_cli_var_enum): Declare.
2607         * cli/cli-utils.c: Include "cli/cli-option.h".
2608         (get_ulongest): New.
2609         * cli/cli-utils.h (get_ulongest): Declare.
2610         (check_for_argument): New overloads.
2611         * maint-test-options.c: New file.
2612
2613 2019-06-13  Pedro Alves  <palves@redhat.com>
2614
2615         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2616         parse a range if "-" is at the end of the string.
2617
2618 2019-06-13  Pedro Alves  <palves@redhat.com>
2619
2620         * cli/cli-setshow.c (parse_auto_binary_operation)
2621         (parse_cli_boolean_value): Don't allow "o".
2622
2623 2019-06-13  Pedro Alves  <palves@redhat.com>
2624
2625         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2626         * NEWS: Mention maint test-settings KIND.
2627         * maint-test-settings.c: New file.
2628
2629 2019-06-13  Pedro Alves  <palves@redhat.com>
2630
2631         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2632         completer.
2633         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2634         "set" completers.
2635
2636 2019-06-13  Pedro Alves  <palves@redhat.com>
2637
2638         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2639         after item.
2640
2641 2019-06-13  Pedro Alves  <palves@redhat.com>
2642
2643         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2644
2645 2019-06-13  Pedro Alves <palves@redhat.com>
2646
2647         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2648         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2649         call.
2650         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2651         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2652         calls.
2653         (check_for_argument): Skip spaces after argument.
2654
2655 2019-06-13  Pedro Alves  <palves@redhat.com>
2656
2657         * thread.c (thread_apply_command): Adjust TID parsing.
2658         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2659         detected before end of string.
2660         (tid_is_in_list): Error out if LIST is invalid.
2661
2662 2019-06-13  Pedro Alves  <palves@redhat.com>
2663
2664         * completer.c (complete_line_internal_1): Rewind completion word
2665         point.
2666         (completion_tracker::advance_custom_word_point_by): Change
2667         parameter type to int.
2668         * completer.h (completion_tracker::advance_custom_word_point_by):
2669         Likewise.
2670
2671 2019-06-13  Pedro Alves  <palves@redhat.com>
2672
2673         * completer.c (advance_to_completion_word): Handle delimiters.
2674
2675 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2676
2677         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2678
2679 2019-06-11  Tom Tromey  <tom@tromey.com>
2680
2681         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2682         (xmalloc_failed): Move to alloc.c.
2683         * alloc.c: New file.
2684         * Makefile.in (COMMON_SFILES): Add alloc.c.
2685
2686 2019-06-11  Tom Tromey  <tom@tromey.com>
2687
2688         * nat/linux-waitpid.c: Don't include server.h.
2689         (linux_debug): Remove.
2690         (my_waitpid): Update.
2691
2692 2019-06-11  Tom Tromey  <tromey@adacore.com>
2693
2694         * infcall.c (_initialize_infcall): Remove trailing newline from
2695         help.
2696         * user-regs.c (_initialize_user_regs): Remove trailing newline
2697         from help.
2698         * typeprint.c (_initialize_typeprint): Remove trailing newline
2699         from help.
2700         * reverse.c (_initialize_reverse): Remove trailing newlines from
2701         help.
2702         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2703         from help.
2704         * language.c (add_set_language_command): Remove trailing newline
2705         from help.
2706         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2707         help.
2708         * disasm.c (_initialize_disasm): Remove trailing newline from
2709         help.
2710         * top.c (init_main): Remove trailing newline from help.
2711         * interps.c (_initialize_interpreter): Remove trailing newline
2712         from help.
2713         * btrace.c (_initialize_btrace): Remove trailing newlines from
2714         help.
2715         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2716         from help.
2717         * python/python.c (_initialize_python): Remove trailing newline
2718         from help.
2719         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2720         help.
2721         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2722         from help.  Reformat some text.
2723         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2724         from help.
2725         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2726         newline from help.
2727
2728 2019-06-11  Tom Tromey  <tromey@adacore.com>
2729
2730         * darwin-nat.c (darwin_decode_exception_message)
2731         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2732
2733 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2734
2735         * valops.c (value_slice): Check for not allocated or not
2736         associated values.
2737
2738 2019-06-10  Tom de Vries  <tdevries@suse.de>
2739
2740         PR gdb/24618
2741         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2742         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2743         invalid.
2744
2745 2019-06-10  Tom de Vries  <tdevries@suse.de>
2746
2747         PR gdb/24611
2748         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2749         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2750
2751 2019-06-10  Tom de Vries  <tdevries@suse.de>
2752
2753         PR symtab/24545
2754         * symtab.c (struct demangled_name_entry): Add language field.
2755         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2756         static minimal symbol".  Set and use language field.
2757
2758 2019-06-10  Tom Tromey  <tromey@adacore.com>
2759
2760         * ada-lang.c (_initialize_ada_language): Update help text.
2761
2762 2019-06-10  Tom Tromey  <tromey@adacore.com>
2763
2764         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2765         with a newline.
2766         * guile/guile.c (handle_boot_error): Don't end warning with a
2767         newline.
2768         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2769         warning with a newline.
2770         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2771         newline.
2772         (s12z_frame_cache): Likewise.
2773         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2774         a newline.
2775         * solib-svr4.c (disable_probes_interface): Don't end warning with
2776         a newline.
2777         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2778         newline.
2779         * python/python.c (do_finish_initialization): Don't end warning
2780         with a newline.
2781
2782 2019-06-10  Tom Tromey  <tom@tromey.com>
2783
2784         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2785         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2786         gdbpy_enter.
2787
2788 2019-06-10  Tom Tromey  <tromey@adacore.com>
2789
2790         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2791         data.
2792         (elf_new_init): Don't call stabsread_new_init.
2793         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2794         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2795         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2796
2797 2019-06-10  Tom de Vries  <tdevries@suse.de>
2798
2799         PR symtab/16264
2800         PR symtab/24517
2801         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2802
2803 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2804
2805         * source.c (find_and_open_source): Also rewrite relative file
2806         names.
2807
2808 2019-04-26  Amos Bird  <amosbird@gmail.com>
2809
2810         * annotate.c (annotate_thread_exited): Add "thread-exited"
2811         annotation.
2812
2813 2019-06-06  Tom Tromey  <tromey@adacore.com>
2814
2815         * maint.h (class scoped_command_stats): Use
2816         DISABLE_COPY_AND_ASSIGN.
2817         <print_time>: New method.
2818         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2819         print_time.
2820         (scoped_command_stats::print_time): New method.
2821
2822 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2823
2824         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2825         instructions of lengths 6 or 8 bytes.
2826
2827 2019-06-04  Pedro Alves  <palves@redhat.com>
2828
2829         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2830
2831         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2832         * breakpoint.c (condition_completer): Likewise.
2833         * cli/cli-dump.c (scan_expression): Likewise.
2834         * common/filestuff.c (mkdir_recursive): Likewise.
2835         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2836         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2837         (gdb_abspath): Likewise.
2838         * compile/compile-cplus-types.c
2839         (compile_cplus_instance::decl_name): Likewise.
2840         * completer.c (complete_explicit_location):
2841         (signal_completer, reg_or_group_completer_1): Likewise.
2842         * cp-support.c (cp_remove_params_if_any): Likewise.
2843         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2844         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2845         * infcmd.c (strip_bg_char): Likewise.
2846         * linespec.c (copy_token_string): Likewise.
2847         * mi/mi-main.c (output_cores): Likewise.
2848         * psymtab.c (psymtab_search_name):
2849         * symfile.c (test_set_ext_lang_command): Likewise.
2850         * target.c (target_fileio_read_stralloc): Likewise.
2851         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2852         * value.c (complete_internalvar): Likewise.
2853
2854 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2855
2856         Add objfile property to gdb.Type.
2857         * NEWS: Mention Python API addition.
2858         * python/py-type.c (typy_get_objfile): New method.
2859
2860 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2861
2862         * NEWS: Mention the new set|show style [title|highlight].
2863         Mention changes to "show style", "help" and "apropos".
2864
2865 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2866
2867         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2868         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2869         instead of print_help_for_command.
2870         (print_doc_of_command): New function.
2871         (help_list): Add 'apropos -v word' suggestion.
2872         (print_help_for_command): Style the command name using title style.
2873         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2874         (_initialize_cli_cmds): Describe -v in apropos_command help.
2875
2876 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2877
2878         * cli/cli-style.h (cli_style_option): Add name in constructor,
2879         add m_name class member, add constructor with intensity,
2880         add name class function.
2881         (cli_style_option::add_setshow_commands): Remove name argument.
2882         (highlight_style, title_style): New styles.
2883         * cli/cli-style.c (do_show): New function that shows a style
2884         characteristic styling the style name with itself.
2885         (set_style_name): New function.
2886         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2887         Update all callers according to the changes in cli/cli-style.h.
2888         * utils.h (fputs_highlighted): New function.
2889         * utils.c (fputs_highlighted): Likewise.
2890
2891 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2892
2893         * NEWS: Mention new pipe command and new convenience variables.
2894
2895 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2896
2897         * cli/cli-cmds.c (pipe_command): New function.
2898         (_initialize_cli_cmds): Call add_com for pipe_command.
2899         Define | as an alias for pipe.
2900         (exit_status_set_internal_vars): New function.
2901         (shell_escape): Call exit_status_set_internal_vars.
2902         cli/cli-decode.c (find_command_name_length): Recognize | as
2903         a single character command.
2904
2905 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2906
2907         * gdbcmd.h (execute_command_to_ui_file): New declaration.
2908         top.c (execute_command_to_ui_file): New function, mostly a copy
2909         of execute_command_to_string.
2910         (execute_command_to_string): Implement by calling
2911         execute_command_to_ui_file.
2912
2913 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2914
2915         * top.h (saved_command_line): Remove declaration.
2916         * top.c (previous_saved_command_line, previous_repeat_arguments):
2917         New variables.
2918         (saved_command_line): Make static, define together with other
2919         'repeat variables'.
2920         (dont_repeat): Clear repeat_arguments.
2921         (repeat_previous, get_saved_command_line, save_command_line):
2922         New functions.
2923         (gdb_init): Initialize saved_command_line
2924         and previous_saved_command_line.
2925         * main.c (captured_main_1): Remove saved_command_line initialization.
2926         * event-top.c (handle_line_of_input): Update to use
2927         the new 'repeat' related functions instead of direct access to
2928         saved_command_line.
2929         * command.h (repeat_previous, get_saved_command_line,
2930         save_command_line): New declarations.
2931         (dont_repeat): Add comment.
2932
2933 2019-05-30  Tom Tromey  <tromey@adacore.com>
2934
2935         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
2936         Fix comment.
2937         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
2938
2939 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
2940
2941         PR cli/24587
2942         * completer.c (complete): Initialize variable word.
2943
2944 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
2945
2946         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2947         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
2948         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
2949         'body' is NULL to the outter 'if', protecting the '!is_define'
2950         situation as well.
2951
2952 2019-05-29  Tom Tromey  <tromey@adacore.com>
2953
2954         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
2955         (dwarf_unknown): New function.
2956         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
2957         (dwarf_type_encoding_name): Use dwarf_unknown.
2958
2959 2019-05-29  Tom Tromey  <tromey@adacore.com>
2960
2961         PR c++/20020:
2962         * cp-valprint.c (cp_print_value_fields): Call
2963         cp_print_static_field inside "try".
2964
2965 2019-05-29  Tom Tromey  <tromey@adacore.com>
2966
2967         * inflow.c (struct terminal_info): Add default operator=.
2968         * configure: Rebuild.
2969         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
2970         -Wdeprecated-copy-dtor, -Wredundant-move.
2971
2972 2019-05-29  Tom Tromey  <tromey@adacore.com>
2973
2974         * NEWS: Add entry.
2975         * infcmd.c (print_return_value_1): Handle finish_print
2976         option.
2977         (show_print_finish): New function.
2978         (_initialize_infcmd): Add "set/show print finish" commands.
2979         * valprint.c (user_print_options): Initialize new member.
2980         * valprint.h (struct value_print_options) <finish_print>: New
2981         member.
2982
2983 2019-05-28  Tom Tromey  <tromey@adacore.com>
2984
2985         * ada-lang.c (ada_remove_Xbn_suffix)
2986         (find_old_style_renaming_symbol)
2987         (parse_old_style_renaming): Remove.
2988         (ada_find_renaming_symbol): Don't call
2989         find_old_style_renaming_symbol.
2990         (ada_is_renaming_symbol): Rename from
2991         ada_find_renaming_symbol.  Remove "block" parameter.  Return
2992         bool.  Now static.
2993         (ada_read_var_value): Update and simplify.
2994         * ada-exp.y (write_var_or_type): Remove old code.
2995
2996 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
2997
2998         * event-top.c: Remove include comment.
2999         * inflow.c (class scoped_ignore_sigttou): Move from here...
3000         * inflow.h (class scoped_ignore_sigttou): ...to here.
3001         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3002         * top.c:  Remove include comment.
3003
3004 2019-05-27  Tom Tromey  <tom@tromey.com>
3005
3006         * NEWS: Fix typo.
3007
3008 2019-05-22  Tom Tromey  <tromey@adacore.com>
3009
3010         * target.c (target_follow_exec): Constify parameter.
3011         * target-delegates.c: Rebuild.
3012         * remote.c (remote_target::follow_exec): Constify parameter.
3013         * infrun.c (follow_exec): Constify parameter.
3014         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3015         (target_follow_exec): Likewise.
3016
3017 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3018
3019         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3020         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3021
3022 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3023
3024         * NEWS: Add debugredirect and testsuite sections.
3025
3026 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3027
3028         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3029         target descriptions using exclusively floating point register name
3030         aliases.
3031
3032 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3033
3034         PR gdb/18644:
3035         * f-lang.c (build_fortran_types): Handle the case where
3036         gdbarch_floatformat_for_type returns a nullptr.
3037
3038 2019-05-21  Tom de Vries  <tdevries@suse.de>
3039
3040         PR cli/24587
3041         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3042
3043 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3044
3045         PR gdb/18644:
3046         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3047         16-byte floats.
3048         * i386-tdep.c (i386_floatformat_for_type): Use
3049         floatformats_ia64_quad for the 16-byte floating point component
3050         within a fortran 32-byte complex number.
3051
3052 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3053
3054         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3055         delete default constructor.
3056         (find_partial_die): Update to return const struct.
3057         (partial_die_parent_scope): Move variable declaration into scope
3058         of its use and change its type to auto.
3059         (guess_partial_die_structure_name): Likewise.
3060         (partial_die_info::fixup): Likewise.
3061
3062 2019-05-17  Tom Tromey  <tromey@adacore.com>
3063
3064         * source.c (find_and_open_source): Remove cast.
3065
3066 2019-05-17  Tom Tromey  <tromey@adacore.com>
3067
3068         * annotate.c (annotate_source): Make "filename" const.
3069         * annotate.h (annotate_source): Use const.
3070
3071 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3072
3073         * disasm.c (set_disassembler_options): Send errors to stderr.
3074
3075 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3076
3077         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3078         (cli_interp_base::set_logging): Check debug_redirect.
3079         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3080         * cli/cli-logging.c (debug_redirect): Add static variable.
3081         (pop_output_files): Add default param.
3082         (handle_redirections): Print debug setting.
3083         (show_logging_command): Likewise.
3084         (_initialize_cli_logging): Add debugredirect command.
3085         * interps.c (current_interp_set_logging): Add debug_redirect
3086         parameter.
3087         * interps.h (set_logging): Add debug_redirect parameter.
3088         (current_interp_set_logging): Likewise.
3089         * mi/mi-common.h: Likewise.
3090         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3091
3092 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3093             Tom Tromey  <tromey@adacore.com>
3094
3095         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3096         directly.
3097         * cli/cli-interp.h (make_logging_output): Remove declaration.
3098         * cli/cli-logging.c (make_logging_output): Remove function.
3099         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3100         directly.
3101         * ui-file.c (tee_file::tee_file): Remove bools.
3102         (tee_file::~tee_file): Remove deletes.
3103         * ui-file.h (tee_file): Remove bools.
3104
3105 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3106
3107         * mi/mi-cmds.h (mi_cmd_complete): New function.
3108         * mi/mi-main.c (mi_cmd_complete): Likewise.
3109         * mi/mi-cmds.c: Define new MI command -complete.
3110         * NEWS: Mention new -complete command.
3111
3112 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3113
3114         * completer.h (complete): New function.
3115         * completer.c (complete): Likewise.
3116         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3117         function defined in completer.h.
3118
3119 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3120
3121         * MAINTAINERS (Write After Approval): Add myself.
3122
3123 2019-05-17  Tom de Vries  <tdevries@suse.de>
3124
3125         PR gdb/24094
3126         * dwarf2read.c (struct cu_partial_die_info): New struct.
3127         (find_partial_die): Return cu_partial_die_info.
3128         (partial_die_parent_scope, guess_partial_die_structure_name)
3129         (partial_die_info::fixup): Handle new return type of find_partial_die.
3130
3131 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3132
3133         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3134         "std::string", simplifying the algorithm.
3135
3136 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3137
3138         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3139         (stap_static_probe_ops::get_probes): Likewise.
3140
3141 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3142
3143         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3144         '-')" and "else if".
3145         (stap_parse_single_operand): Join checks for
3146         "gdbarch_stap_parse_special_token_p" and
3147         "gdbarch_stap_parse_special_token" in the same "if" statement.
3148         Invert check when verifying for operation on register
3149         displacement.
3150
3151 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3152
3153         * stap-probe.c (stap_get_opcode): Update comment.
3154         (stap_get_expected_argument_type): Likewise.
3155         (handle_stap_probe): Likewise.
3156
3157 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3158
3159         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3160         return type to 'bool'.  Adjust comment.  Use 'bool' when
3161         appropriate.
3162         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3163         * stap-probe.c (stap_parse_argument_1): Likewise.
3164         (stap_is_operator): Likewise.
3165         (stap_is_generic_prefix): Likewise.
3166         (stap_is_register_prefix): Likewise.
3167         (stap_is_register_indirection_prefix): Likewise.
3168         (stap_is_integer_prefix): Likewise.
3169         (stap_generic_check_suffix): Likewise.
3170         (stap_check_integer_suffix): Likewise.
3171         (stap_check_register_suffix): Likewise.
3172         (stap_check_register_indirection_suffix): Likewise.
3173         (stap_parse_register_operand): Likewise.
3174         (stap_parse_single_operand): Likewise.
3175         (stap_parse_argument_1): Likewise.
3176         (stap_probe::get_argument_count): Likewise.
3177         (stap_is_operator): Likewise.
3178
3179 2019-05-16  Tom Tromey  <tromey@adacore.com>
3180
3181         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3182         keyword to foreach.
3183
3184 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3185
3186         * linux-thread-db.c (try_thread_db_load_1): Change return type
3187         to bool.
3188         (try_thread_db_load): Likewise.
3189         (try_thread_db_load_from_pdir_1): Likewise.
3190         (try_thread_db_load_from_pdir): Likewise.
3191         (try_thread_db_load_from_sdir): Likewise.
3192         (try_thread_db_load_from_dir): Likewise.
3193         (thread_db_load_search): Likewise.
3194         (has_libpthread): Likewise.
3195         (thread_db_load): Likewise.
3196
3197 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3198
3199         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3200         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3201         NULL, and complain/return if that's the case.
3202
3203 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3204
3205         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3206         (advance, posn, abstract_read_memory): New functions.
3207         [struct mem_read_abstraction]: New struct.
3208         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3209
3210 2019-05-14  Tom Tromey  <tromey@adacore.com>
3211
3212         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3213         value is not lval_memory.
3214
3215 2019-05-14  Tom Tromey  <tromey@adacore.com>
3216
3217         * solib.c (info_sharedlibrary_command): Style the file name.
3218
3219 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3220
3221         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3222         (aarch64_vnv_type): Likewise.
3223         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3224         * common/tdesc.c: Likewise.
3225         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3226         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3227         * features/aarch64-fpu.xml: Add ieee half view.
3228         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3229         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3230         * gdbtypes.h (struct builtin_type): Likewise.
3231         (struct objfile_type): Likewise.
3232
3233 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3234
3235         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3236         typo.
3237         * location.h (string_to_event_location): Likewise.
3238
3239 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3240
3241         GDB 8.3 released.
3242
3243 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3244
3245         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3246         New variable declaration.
3247         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3248         New variable.
3249         (print_one_breakpoint): Use ui_out::test_flags and new global
3250         variable to compute use_fixed_output.
3251         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3252         Remove.
3253         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3254         (mi_multi_location_breakpoint_output_fixed): Remove.
3255         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3256         new variable.
3257         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3258         fix_multi_location_breakpoint_output flag if version >= 3.
3259         * ui-out.h (enum ui_out_flag)
3260         <fix_multi_location_breakpoint_output>: New enumerator.
3261
3262 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3263
3264         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3265
3266 2019-05-10  Tom Tromey  <tromey@adacore.com>
3267
3268         * ada-lang.c (catch_ada_completer): New function.
3269         (_initialize_ada_language): Use it.
3270
3271 2019-05-10  Tom Tromey  <tromey@adacore.com>
3272
3273         * thread.c (print_thread_info): Make "requested_threads" const.
3274         * gdbthread.h (print_thread_info): Make "requested_threads"
3275         const.
3276         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3277         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3278
3279 2019-05-08  Tom Tromey  <tom@tromey.com>
3280
3281         * gdbtypes.c (objfile_type_data): Change type.
3282         (objfile_type, _initialize_gdbtypes): Update.
3283
3284 2019-05-08  Tom Tromey  <tom@tromey.com>
3285
3286         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3287         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3288         (_initialize_dwarf2_frame): Update.
3289
3290 2019-05-08  Tom Tromey  <tom@tromey.com>
3291
3292         * objc-lang.c (objc_objfile_data): Change type.
3293         (find_methods): Update.
3294         (_initialize_objc_lang): Remove.
3295
3296 2019-05-08  Tom Tromey  <tom@tromey.com>
3297
3298         * stabsread.c (rs6000_builtin_type_data): Change type.
3299         (rs6000_builtin_type, _initialize_stabsread): Update.
3300
3301 2019-05-08  Tom Tromey  <tom@tromey.com>
3302
3303         * mips-tdep.c (mips_pdr_data): Remove.
3304         (_initialize_mips_tdep): Update.
3305
3306 2019-05-08  Tom Tromey  <tom@tromey.com>
3307
3308         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3309         (hppa_init_objfile_priv_data, read_unwind_info)
3310         (find_unwind_entry, _initialize_hppa_tdep): Update.
3311
3312 2019-05-08  Tom Tromey  <tom@tromey.com>
3313
3314         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3315         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3316         on obstack.
3317         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3318
3319 2019-05-08  Tom Tromey  <tom@tromey.com>
3320
3321         * mdebugread.c (basic_type_data): Change type.
3322         (basic_type, _initialize_mdebugread): Update.
3323
3324 2019-05-08  Tom Tromey  <tom@tromey.com>
3325
3326         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3327
3328 2019-05-08  Tom Tromey  <tom@tromey.com>
3329
3330         * nto-tdep.c (nto_inferior_data_reg): Change type.
3331         (nto_inferior_data): Update.
3332         (nto_inferior_data_cleanup, nto_new_inferior_data)
3333         (_initialize_nto_tdep): Remove.
3334         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3335
3336 2019-05-08  Tom Tromey  <tom@tromey.com>
3337
3338         * ada-lang.c (struct ada_inferior_data): Add initializers.
3339         (ada_inferior_data): Change type.
3340         (ada_inferior_data_cleanup): Remove.
3341         (get_ada_inferior_data, ada_inferior_exit)
3342         (struct ada_pspace_data): Add initializers, destructor.
3343         (ada_pspace_data_handle): Change type.
3344         (get_ada_pspace_data): Update.
3345         (ada_pspace_data_cleanup): Remove.
3346
3347 2019-05-08  Tom Tromey  <tom@tromey.com>
3348
3349         * coffread.c (struct coff_symfile_info): Add initializers.
3350         (coff_objfile_data_key): Move lower.  Change type.
3351         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3352         Update.
3353         (coff_free_info): Remove.
3354
3355 2019-05-08  Tom Tromey  <tom@tromey.com>
3356
3357         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3358         (fbsd_pspace_data_handle): Move lower.  Change type.
3359         (get_fbsd_pspace_data): Update.
3360         (fbsd_pspace_data_cleanup): Remove.
3361         (_initialize_fbsd_tdep): Update.
3362
3363 2019-05-08  Tom Tromey  <tom@tromey.com>
3364
3365         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3366         (get_ada_tasks_pspace_data): Update.
3367         (ada_tasks_pspace_data_cleanup): Remove.
3368         (_initialize_tasks): Update.
3369         (ada_tasks_inferior_data_handle): Change type.
3370         (get_ada_tasks_inferior_data): Update.
3371         (ada_tasks_inferior_data_cleanup): Remove.
3372         (struct ada_tasks_pspace_data): Add initializers.
3373
3374 2019-05-08  Tom Tromey  <tom@tromey.com>
3375
3376         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3377         * symfile-debug.c (debug_sym_get_probes): Change type.
3378         * stap-probe.c (handle_stap_probe):
3379         (stap_static_probe_ops::get_probes): Change type.
3380         * probe.h (class static_probe_ops) <get_probes>: Change type.
3381         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3382         (parse_probes_in_pspace): Update.
3383         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3384         Update.
3385         (any_static_probe_ops::get_probes): Change type.
3386         * elfread.c (elfread_data): New typedef.
3387         (probe_key): Change type.
3388         (elf_get_probes): Likewise.  Update.
3389         (probe_key_free): Remove.
3390         (_initialize_elfread): Update.
3391         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3392         Change type.
3393         (dtrace_process_dof_probe, dtrace_process_dof)
3394         (dtrace_static_probe_ops::get_probe): Change type.
3395
3396 2019-05-08  Tom Tromey  <tom@tromey.com>
3397
3398         * xcoffread.c (struct xcoff_symfile_info): Rename from
3399         coff_symfile_info.  Add initializers.
3400         (xcoff_objfile_data_key): Move lower.  Change type.
3401         (XCOFF_DATA): Rewrite.
3402         (xcoff_free_info): Remove.
3403         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3404         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3405         (xcoff_initial_scan): Update.
3406
3407 2019-05-08  Tom Tromey  <tom@tromey.com>
3408
3409         * solib-svr4.c (struct svr4_info): Add initializers and
3410         destructor.
3411         <probes_table>: Now an htab_up.
3412         (solib_svr4_pspace_data): Change type.
3413         (free_probes_table): Simplify.
3414         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3415         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3416         (probes_table_remove_objfile_probes, register_solib_event_probe)
3417         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3418         (_initialize_svr4_solib): Update.
3419
3420 2019-05-08  Tom Tromey  <tom@tromey.com>
3421
3422         * remote.c (remote_pspace_data): Change type.
3423         (remote_pspace_data_cleanup): Remove.
3424         (get_remote_exec_file, set_pspace_remote_exec_file)
3425         (_initialize_remote): Update.
3426
3427 2019-05-08  Tom Tromey  <tom@tromey.com>
3428
3429         * breakpoint.c (breakpoint_objfile_key): Change type.
3430         (get_breakpoint_objfile_data): Update.
3431         (free_breakpoint_objfile_data): Remove.
3432         (_initialize_breakpoint): Update.
3433
3434 2019-05-08  Tom Tromey  <tom@tromey.com>
3435
3436         * linux-tdep.c (struct linux_info): Add initializers.
3437         (linux_inferior_data): Move.  Change type.
3438         (invalidate_linux_cache_inf): Update.
3439         (linux_inferior_data_cleanup): Remove.
3440         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3441
3442 2019-05-08  Tom Tromey  <tom@tromey.com>
3443
3444         * auxv.c (auxv_inferior_data): Move.  Change type.
3445         (auxv_inferior_data_cleanup): Remove.
3446         (invalidate_auxv_cache_inf): Rewrite.
3447         (get_auxv_inferior_data, _initialize_auxv): Update.
3448
3449 2019-05-08  Tom Tromey  <tom@tromey.com>
3450
3451         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3452         (symfile_debug_objfile_data_key): Change type.
3453         (symfile_debug_installed, debug_qf_has_symbols)
3454         (debug_qf_find_last_source_symtab)
3455         (debug_qf_forget_cached_source_info)
3456         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3457         (debug_qf_print_stats, debug_qf_dump)
3458         (debug_qf_expand_symtabs_for_function)
3459         (debug_qf_expand_all_symtabs)
3460         (debug_qf_expand_symtabs_with_fullname)
3461         (debug_qf_map_matching_symbols)
3462         (debug_qf_expand_symtabs_matching)
3463         (debug_qf_find_pc_sect_compunit_symtab)
3464         (debug_qf_map_symbol_filenames)
3465         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3466         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3467         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3468         (debug_sym_read_linetable, debug_sym_relocate): Update.
3469         (symfile_debug_free_objfile): Remove.
3470         (install_symfile_debug_logging, _initialize_symfile_debug):
3471         Update.
3472
3473 2019-05-08  Tom Tromey  <tom@tromey.com>
3474
3475         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3476         allocate_on_obstack.
3477         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3478         (get_dwarf2_per_objfile): Update.
3479         (set_dwarf2_per_objfile): Remove.
3480         (dwarf2_has_info, dwarf2_get_section_info): Update.
3481         (dwarf2_free_objfile): Remove.
3482         (_initialize_dwarf2_read): Update.
3483
3484 2019-05-08  Tom Tromey  <tom@tromey.com>
3485
3486         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3487         initializers.
3488         <unsupported_script_warning_printed,
3489         script_not_found_warning_printed>: Now bool.
3490         (auto_load_pspace_data): Change type.
3491         (~auto_load_pspace_info): Rename from
3492         auto_load_pspace_data_cleanup.
3493         (get_auto_load_pspace_data, init_loaded_scripts_info)
3494         (clear_section_scripts, maybe_print_unsupported_script_warning)
3495         (maybe_print_script_not_found_warning, _initialize_auto_load):
3496         Update.
3497
3498 2019-05-08  Tom Tromey  <tom@tromey.com>
3499
3500         * objfiles.c (objfile_pspace_info): Add destructor and
3501         initializers.
3502         (objfiles_pspace_data): Change type.
3503         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3504         (get_objfile_pspace_data): Update.
3505         (objfiles_bfd_data): Change type.
3506         (get_objfile_bfd_data): Update.
3507         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3508
3509 2019-05-08  Tom Tromey  <tom@tromey.com>
3510
3511         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3512         Change type.
3513         (get_catch_syscall_inferior_data): Update.
3514         (catch_syscall_inferior_data_cleanup): Remove.
3515         (_initialize_break_catch_syscall): Update.
3516
3517 2019-05-08  Tom Tromey  <tom@tromey.com>
3518
3519         * inflow.c (struct terminal_info): Add destructor and
3520         initializers.
3521         (inflow_inferior_data): Change type.
3522         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3523         (get_inflow_inferior_data, inflow_inferior_exit)
3524         (swap_terminal_info, _initialize_inflow): Update.
3525
3526 2019-05-08  Tom Tromey  <tom@tromey.com>
3527
3528         * target-dcache.c (target_dcache_cleanup): Remove.
3529         (target_dcache_aspace_key): Change type.
3530         (target_dcache_init_p, target_dcache_invalidate)
3531         (target_dcache_get, target_dcache_get_or_init)
3532         (_initialize_target_dcache): Update.
3533         * dcache.h (struct dcache_deleter): New.
3534
3535 2019-05-08  Tom Tromey  <tom@tromey.com>
3536
3537         * symtab.c (struct symbol_cache): Add destructor and
3538         initializers.
3539         (symbol_cache_key): Move.  Change type.
3540         (make_symbol_cache, free_symbol_cache): Remove.
3541         (get_symbol_cache): Update.
3542         (symbol_cache_cleanup): Remove.
3543         (ALL_PSPACES, symbol_cache_flush)
3544         (maintenance_print_symbol_cache)
3545         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3546         Update.
3547
3548 2019-05-08  Tom Tromey  <tom@tromey.com>
3549
3550         * symtab.c (struct main_info): Add destructor and initializers.
3551         (main_progspace_key): Move.  Change type.
3552         (get_main_info): Update.
3553         (main_info_cleanup): Remove.
3554         (_initialize_symtab): Update.
3555
3556 2019-05-08  Tom Tromey  <tom@tromey.com>
3557
3558         * registry.h (DECLARE_REGISTRY): Define the _key class.
3559
3560 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3561
3562         * NEWS: Merge two 'New commands' sections.
3563
3564 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3565
3566         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3567         parameter and use Ada language definition instead.
3568         (ada_val_print_ptr): Remove unused language parameter.
3569         (ada_val_print_num): Remove language parameter and use Ada language
3570         definition instead.
3571         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3572         parameter.
3573         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3574         parameter and use Ada language definition instead.
3575         (ada_val_print_1): Update all ada_val_print_xxx calls.
3576         Remove language parameter.
3577         (ada_val_print): Update ada_val_print_1 call.
3578
3579 2019-05-08  Tom Tromey  <tromey@adacore.com>
3580
3581         * remote.c (remote_hw_watchpoint_limit)
3582         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3583         Now static.
3584
3585 2019-05-08  Tom Tromey  <tromey@adacore.com>
3586
3587         * maint.c (_initialize_maint_cmds): Move initialization code to
3588         remote.c.
3589         (watchdog, show_watchdog): Move to remote.c.
3590         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3591         "watchdog" static.
3592         (_initialize_remote): Move initialization code from maint.c.
3593         * defs.h (watchdog): Don't declare.
3594
3595 2019-05-08  Tom Tromey  <tromey@adacore.com>
3596
3597         * tui/tui-interp.c: Include main.h.
3598         * interps.c: Include main.h.
3599         * main.h (interpreter_p): Declare.
3600         * defs.h (interpreter_p): Don't declare.
3601
3602 2019-05-08  Tom Tromey  <tromey@adacore.com>
3603
3604         * dwarf2loc.c: Include dwarf2read.h.
3605         * defs.h (read_unsigned_leb128): Don't declare.
3606         * dwarf2read.h (read_unsigned_leb128): Declare.
3607
3608 2019-05-08  Tom Tromey  <tromey@adacore.com>
3609
3610         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3611         method.
3612
3613 2019-05-08  Tom Tromey  <tromey@adacore.com>
3614
3615         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3616         when no wrap column is set.
3617
3618 2019-05-08  Tom Tromey  <tromey@adacore.com>
3619
3620         * c-lang.c (c_get_string): Handle non-C-style arrays.
3621
3622 2019-05-08  Tom Tromey  <tromey@adacore.com>
3623
3624         * typeprint.c (print_offset_data::update): Print the bit offset,
3625         not the number of bits remaining.
3626
3627 2019-05-08  Tom Tromey  <tromey@adacore.com>
3628
3629         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3630         padding at end of comment.
3631
3632 2019-05-08  Tom Tromey  <tromey@adacore.com>
3633
3634         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3635         Compare main types.
3636
3637 2019-05-06  Tom Tromey  <tom@tromey.com>
3638
3639         * common/scoped_mmap.c: Include common-defs.h.
3640         * common/scoped_mmap.h: Don't include config.h.
3641
3642 2019-05-04  Tom Tromey  <tom@tromey.com>
3643
3644         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3645         (struct aarch64_call_info): Add initializers.
3646         <si>: Now a std::vector.
3647         (pass_on_stack, aarch64_push_dummy_call): Update.
3648
3649 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3650             Tom Tromey  <tom@tromey.com>
3651
3652         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3653         (ppc_threads): Now a std::vector.  Now static.
3654         (hwdebug_find_thread_points_by_tid)
3655         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3656         Update.
3657
3658 2019-05-04  Tom Tromey  <tom@tromey.com>
3659
3660         * arc-tdep.c (arc_tdesc_init): Return bool.
3661
3662 2019-05-04  Tom Tromey  <tom@tromey.com>
3663
3664         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3665         Use gdb_assert_not_reached.
3666
3667 2019-05-04  Tom Tromey  <tom@tromey.com>
3668
3669         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3670         "false".
3671
3672 2019-05-04  Tom Tromey  <tom@tromey.com>
3673
3674         * arc-tdep.c (arc_tdesc_init): Use bool.
3675
3676 2019-05-04  Tom Tromey  <tom@tromey.com>
3677
3678         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3679
3680 2019-05-04  Tom Tromey  <tom@tromey.com>
3681
3682         * cli/cli-cmds.c (valid_command_p): Return bool.
3683
3684 2019-05-04  Tom Tromey  <tom@tromey.com>
3685
3686         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3687         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3688
3689 2019-05-04  Raul Tambre  <raul@tambre.ee>
3690
3691         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3692         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3693         operator for comparison.
3694
3695 2019-05-04  Tom Tromey  <tom@tromey.com>
3696
3697         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3698         (lookup_partial_symbol, print_partial_symbols)
3699         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3700         (psymbol_compare): Update.
3701         (add_psymbol_to_bcache): Clear the entire psymbol.
3702         (maintenance_check_psymtabs): Update.
3703         * psympriv.h (struct partial_symbol): Don't derive from
3704         general_symbol_info.
3705         <obj_section, unrelocated_address, address,
3706         set_unrelocated_address>: Update.
3707         <ginfo>: New member.
3708         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3709         (debug_names::write_psymbols): Update.
3710
3711 2019-05-04  Tom de Vries  <tdevries@suse.de>
3712
3713         * contrib/cc-with-tweaks.sh: Support -n arg.
3714
3715 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3716
3717         * corelow.c (core_target::detach): Ensure frame cache and
3718         register caches are cleared.
3719         inferior.c (exit_inferior_1): Likewise.
3720
3721 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3722             Tom Tromey  <tom@tromey.com>
3723
3724         * dictionary.c (collate_pending_symbols_by_language): Remove
3725         "struct" from foreach.
3726         * symtab.c (lookup_global_symbol_from_objfile)
3727         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3728         foreach.
3729         * ser-tcp.c (net_open): Remove "struct" from foreach.
3730         * objfiles.c (objfile_relocate, objfile_rebase)
3731         (objfile_has_symbols): Remove "struct" from foreach.
3732         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3733         from foreach.
3734         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3735         foreach.
3736         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3737         "struct" from foreach.
3738         * ada-lang.c (create_excep_cond_exprs)
3739         (ada_exception_catchpoint_cond_string): Remove "struct" from
3740         foreach.
3741
3742 2019-05-03  Tom Tromey  <tromey@adacore.com>
3743
3744         * ada-exp.y (convert_char_literal): Check suffix of each
3745         enumerator.
3746
3747 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3748
3749         PR ada/21406:
3750         * ada-exp.y (yywrap): Don't define.
3751         * ada-lex.l (%option): Add noyywrap
3752         (yywrap): Remove.
3753
3754 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3755
3756         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3757         _WIN32_WINNT to the XP level, unless already defined to a higher
3758         level.
3759
3760         * unittests/parse-connection-spec-selftests.c:
3761         * ser-tcp.c:
3762         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3763         override.
3764
3765         * symfile.c (find_separate_debug_file): Remove colon from the
3766         drive spec of DOS/Windows file names of the target, so that the
3767         file name produced from DEBUGDIR and the target's directory will
3768         be valid on DOS/Windows systems.
3769
3770 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3771
3772         * rust-lang.c (val_print_struct): Handle printing structures
3773         containing strings.
3774
3775 2019-05-02  Tom Tromey  <tromey@adacore.com>
3776
3777         * valarith.c (_initialize_valarith): Remove.
3778
3779 2019-05-01  Tom Tromey  <tromey@adacore.com>
3780
3781         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3782         bitfields.
3783
3784 2019-05-01  Tom Tromey  <tromey@adacore.com>
3785
3786         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3787         for big-endian copies.
3788
3789 2019-04-30  Ali Tamur  <tamur@google.com>
3790         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3791         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3792         (read_3_bytes): New function.
3793
3794 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3795
3796         * windows-nat.c (main_thread_id): Delete.
3797         (handle_output_debug_string): Replace main_thread_id by
3798         current_event.dwThreadId.
3799         (fake_create_process): Likewise.
3800         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3801         Do not set main_thread_id.
3802         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3803         current_event.dwThreadId.
3804         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3805
3806 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3807
3808         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3809         Use current_event.dwThreadId instead of main_thread_id.
3810
3811 2019-04-30  Tom Tromey  <tromey@adacore.com>
3812
3813         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3814         (create_excep_cond_exprs): Iterate over program spaces.
3815         (ada_exception_catchpoint_cond_string): Examine all minimal
3816         symbols for exception types.
3817
3818 2019-04-30  Tom Tromey  <tromey@adacore.com>
3819
3820         PR c++/24470:
3821         * dwarf2read.c (process_structure_scope): Handle case where type
3822         has template parameters but no symbol was created.
3823
3824 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3825             Chris January  <chris.january@arm.com>
3826
3827         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3828         qualifier.
3829         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3830
3831 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3832
3833         * f-typeprint.c (f_print_type): Update rules for printing
3834         whitespace.
3835         (f_type_print_varspec_suffix): Likewise.
3836
3837 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3838             Chris January  <chris.january@arm.com>
3839
3840         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3841         function arguments.
3842
3843 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3844
3845         * f-lang.c (build_fortran_types): Change name of void type to
3846         lower case.
3847         * f-typeprint.c (f_type_print_base): Print the name of the void
3848         type, rather than a fixed string.
3849         * f-valprint.c (f_decorations): Use lower case void string.
3850
3851 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3852             Chris January  <chris.january@arm.com>
3853
3854         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3855         types for Fortran.
3856
3857 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3858             Chris January  <chris.january@arm.com>
3859             David Lecomber  <david.lecomber@arm.com>
3860
3861         * f-exp.y (BINOP_INTRINSIC): New token.
3862         (exp): New parser rule handling BINOP_INTRINSIC.
3863         (f77_keywords): Add new builtin procedures.
3864         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3865         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3866         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3867         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3868         (print_unop_subexp_f): New function.
3869         (print_binop_subexp_f): New function.
3870         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3871         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3872         (dump_subexp_body_f): Likewise.
3873         (operator_check_f): Likewise.
3874         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3875         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3876
3877 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3878
3879         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3880         UNOP_KIND.
3881         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3882         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3883         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3884         (operator_length_f): New fuction.
3885         (print_subexp_f): New function.
3886         (op_name_f): New function.
3887         (dump_subexp_body_f): New function.
3888         (operator_check_f): New function.
3889         (exp_descriptor_f): Replace standard expression handling functions
3890         with new functions.
3891         * gdb/fortran-operator.def: New file.
3892         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3893         * gdb/std-operator.def: Remove UNOP_KIND.
3894
3895 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3896
3897         * std-operator.def: Remove unbalanced, stray double quote
3898         character.
3899
3900 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3901             Chris January  <chris.january@arm.com>
3902             Daniel Everett  <daniel.everett@arm.com>
3903             Nick Forrington  <nick.forrington@arm.com>
3904             Richard Bunt  <richard.bunt@arm.com>
3905
3906         * cp-valprint.c (cp_print_value_fields): Allow an additional level
3907         of depth when printing anonymous structs or unions.
3908         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3909         Don't print either the top-level value, or the children if the
3910         max-depth is exceeded.
3911         (ppscm_print_children): When printing the key of a map, allow one
3912         extra level of depth.
3913         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3914         print either the top-level value, or the children if the max-depth
3915         is exceeded.
3916         (print_children): When printing the key of a map, allow one extra
3917         level of depth.
3918         * python/py-value.c (valpy_format_string): Add max_depth keyword.
3919         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
3920         (user_print_options): Initialise max_depth field.
3921         (val_print_scalar_or_string_type_p): New function.
3922         (val_print): Check to see if the max depth has been reached.
3923         (val_print_check_max_depth): Define new function.
3924         (show_print_max_depth): New function.
3925         (_initialize_valprint): Add 'print max-depth' option.
3926         * valprint.h (struct value_print_options) <max_depth>: New field.
3927         (val_print_check_max_depth): Declare new function.
3928         * NEWS: Document new feature.
3929
3930 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3931
3932         * ada-lang.c (ada_language_defn): Initialise new field.
3933         * c-lang.c (c_is_string_type_p): New function.
3934         (c_language_defn): Initialise new field.
3935         (cplus_language_defn): Initialise new field.
3936         (asm_language_defn): Initialise new field.
3937         (minimal_language_defn): Initialise new field.
3938         * c-lang.h (c_is_string_type_p): Declare new function.
3939         * d-lang.c (d_language_defn): Initialise new field.
3940         * f-lang.c (f_is_string_type_p): New function.
3941         (f_language_defn): Initialise new field.
3942         * go-lang.c (go_is_string_type_p): New function.
3943         (go_language_defn): Initialise new field.
3944         * language.c (default_is_string_type_p): New function.
3945         (unknown_language_defn): Initialise new field.
3946         (auto_language_defn): Initialise new field.
3947         * language.h (struct language_defn) <la_is_string_type_p>: New
3948         member variable.
3949         (default_is_string_type_p): Declare new function.
3950         * m2-lang.c (m2_language_defn): Initialise new field.
3951         * objc-lang.c (objc_language_defn): Initialise new field.
3952         * opencl-lang.c (opencl_language_defn): Initialise new field.
3953         * p-lang.c (pascal_is_string_type_p): New function.
3954         (pascal_language_defn): Initialise new field.
3955         * rust-lang.c (rust_is_string_type_p): New function.
3956         (rust_language_defn): Initialise new field.
3957
3958 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3959
3960         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
3961         New field.
3962         * ada-lang.c (ada_language_defn): Initialise new field.
3963         * c-lang.c (c_language_defn): Likewise.
3964         (cplus_language_defn): Likewise.
3965         (asm_language_defn): Likewise.
3966         (minimal_language_defn): Likewise.
3967         * d-lang.c (d_language_defn): Likewise.
3968         * f-lang.c (f_language_defn): Likewise.
3969         * go-lang.c (go_language_defn): Likewise.
3970         * language.c (unknown_language_defn): Likewise.
3971         (auto_language_defn): Likewise.
3972         * m2-lang.c (m2_language_defn): Likewise.
3973         * objc-lang.c (objc_language_defn): Likewise.
3974         * opencl-lang.c (opencl_language_defn): Likewise.
3975         * p-lang.c (pascal_language_defn): Likewise.
3976         * rust-lang.c (rust_language_defn): Likewise.
3977
3978 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3979
3980         * ada-lang.c (ada_is_character_type): Change return type to bool.
3981         (ada_is_string_type): Likewise.
3982         * ada-lang.h (ada_is_character_type): Update declaration
3983         (ada_is_string_type): Likewise.
3984
3985 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3986
3987         Support style in 'frame|thread apply'
3988
3989         * gdbcmd.h (execute_command_to_string): New term_out parameter.
3990         * record.c (record_start, record_stop): Update callers of
3991         execute_command_to_string with false.
3992         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
3993         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
3994         methods.
3995         (class string_file): New constructor with term_out parameter.
3996         Override methods term_out and can_emit_style_escape.  New member
3997         term_out.
3998         (class stdio_file): Override can_emit_style_escape.
3999         (class tee_file): Override term_out and can_emit_style_escape.
4000         * utils.h (can_emit_style_escape): Remove.
4001         * utils.c (can_emit_style_escape): Likewise.
4002         Update all callers of can_emit_style_escape (SOMESTREAM) to
4003         SOMESTREAM->can_emit_style_escape.
4004         * source-cache.c (source_cache::get_source_lines): Likewise.
4005         * stack.c (frame_apply_command_count): Call execute_command_to_string
4006         passing the term_out characteristic of the current gdb_stdout.
4007         * thread.c (thr_try_catch_cmd): Likewise.
4008         * top.c (execute_command_to_string): pass term_out parameter
4009         to construct the string_file for the command output.
4010         * ui-file.c (term_cli_styling): New function (most code moved
4011         from utils.c can_emit_style_escape).
4012         (string_file::string_file, string_file::can_emit_style_escape,
4013         stdio_file::can_emit_style_escape, tee_file::term_out,
4014         tee_file::can_emit_style_escape): New functions.
4015
4016 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4017
4018         * NEWS: Mention the new set|show may-call-functions.
4019         * infcall.c (may_call_functions_p): New variable.
4020         (show_may_call_functions_p): New function.
4021         (call_function_by_hand_dummy): Throws an error if not
4022         may-call-functions.
4023         (_initialize_infcall): Call add_setshow_boolean_cmd for
4024         may-call-functions.
4025
4026 2019-04-25  Keith Seitz  <keiths@redhat.com>
4027
4028         PR c++/24367
4029         * cp-support.c (inspect_type): Don't attempt substitutions
4030         of symbol with the same name.
4031
4032 2019-04-25  Tom Tromey  <tromey@adacore.com>
4033
4034         PR gdb/24475:
4035         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4036         static.
4037
4038 2019-04-25  Tom Tromey  <tromey@adacore.com>
4039
4040         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4041         rvalue reference.
4042         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4043         (gdb_xml_parser::parse): Use std::move.
4044         * python/python-internal.h (gdbpy_convert_exception): Take a const
4045         reference.
4046         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4047         std::move.
4048         * python/py-utils.c (gdbpy_convert_exception): Take a const
4049         reference.
4050         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4051         Use std::move.
4052         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4053         Use std::move.
4054         * mi/mi-main.c (mi_print_exception): Take a const reference.
4055         * main.c (handle_command_errors): Take a const reference.
4056         * linespec.c (parse_linespec): Use std::move.
4057         * infcall.c (run_inferior_call): Use std::move.
4058         (call_function_by_hand_dummy): Use std::move.
4059         * exec.c (try_open_exec_file): Use std::move.
4060         * exceptions.h (exception_print, exception_fprintf)
4061         (exception_print_same): Update.
4062         * exceptions.c (print_exception, exception_print)
4063         (exception_fprintf, exception_print_same): Change parameters to
4064         const reference.
4065         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4066         * common/new-op.c: Use std::move.
4067         * common/common-exceptions.h (struct gdb_exception): Add move
4068         constructor.
4069         (struct gdb_exception_error, struct gdb_exception_quit, struct
4070         gdb_quit_bad_alloc): Change constructor to move constructor.
4071         (throw_exception): Change parameter to rvalue reference.
4072         * common/common-exceptions.c (throw_exception): Take rvalue
4073         reference.
4074         * cli/cli-interp.c (safe_execute_command): Use std::move.
4075         * breakpoint.c (insert_bp_location, location_to_sals): Use
4076         std::move.
4077
4078 2019-04-25  Tom Tromey  <tromey@adacore.com>
4079
4080         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4081         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4082         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4083         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4084         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4085         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4086         guile/scm-value.c: Use unpack.
4087         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4088         gdbscm_gdb_exception.
4089         (gdbscm_throw_gdb_exception): Likewise.
4090         (struct gdbscm_gdb_exception): New.
4091         (unpack): New function.
4092         (gdbscm_wrap): Use unpack.
4093
4094 2019-04-25  Tom Tromey  <tromey@adacore.com>
4095
4096         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4097         (gdb_rl_callback_handler): Use std::move.
4098         * common/common-exceptions.h (struct gdb_exception): Add move
4099         assignment operator.
4100         (throw_exception_sjlj): Change "exception" to const reference.
4101         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4102         (throw_exception_sjlj): Change "exception" to const reference.
4103
4104 2019-04-25  Tom Tromey  <tromey@adacore.com>
4105
4106         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4107         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4108         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4109         Update.
4110         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4111         Update.
4112         * mi/mi-interp.c (mi_interp::exec): Update.
4113         * linespec.c (parse_linespec): Update.
4114         * infcall.c (run_inferior_call): Update.
4115         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4116         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4117         (gdbscm_lookup_global_symbol): Update.
4118         * guile/scm-param.c (gdbscm_parameter_value): Update.
4119         * guile/scm-frame.c (gdbscm_frame_read_register)
4120         (gdbscm_frame_read_var): Update.
4121         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4122         * exec.c (try_open_exec_file): Update.
4123         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4124         (gdb_rl_callback_handler): Update.
4125         * common/common-exceptions.h (exception_none): Don't declare.
4126         * common/common-exceptions.c (exception_none): Don't define.
4127         (struct catcher) <exception>: Update.
4128         * cli/cli-interp.c (safe_execute_command): Update.
4129         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4130
4131 2019-04-25  Ali Tamur  <tamur@google.com>
4132
4133         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4134         (read_attribute_value): Likewise.
4135         (dwarf2_read_addr_index): Update comment.
4136         (read_str_index): Add DW_FORM_strx.
4137         (dwarf2_string_attr): Likewise.
4138         (dwarf2_const_value_attr): Likewise.
4139         (dump_die_shallow): Likewise.
4140         (dwarf2_fetch_constant_bytes): Likewise.
4141         (skip_form_bytes): Likewise.
4142         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4143
4144 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4145
4146         PR corefiles/11608
4147         PR corefiles/18187
4148         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4149         OFFSET.  Verify if current mapping contains an ELF header.
4150         (linux_find_memory_regions_full): Adjust call to
4151         dump_mapping_p.
4152
4153 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4154             Kang Li <kanglictf@gmail.com>
4155
4156         PR gdb/21600
4157
4158         * dwarf2-frame.c (read_initial_length): Be consistent about using
4159         unsigned representation of length.
4160         (decode_frame_entry_1): Likewise.  Check for wraparound of
4161         end pointer as well as buffer overflow.
4162
4163 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4164
4165         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4166         "vq".
4167
4168 2019-04-24  Tom Tromey  <tromey@adacore.com>
4169
4170         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4171
4172 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4173
4174         * s12z-tdep.c (s12z_unwind_pc): Delete.
4175         (s12z_unwind_sp): Delete.
4176         (s12z_gdbarch_init): Don't register deleted functions with
4177         gdbarch.
4178
4179 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4180
4181         * rl78-tdep.c (rl78_unwind_sp): Delete.
4182         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4183
4184 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4185
4186         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4187         (xstormy16_unwind_pc): Delete.
4188         (xstormy16_dummy_id): Delete.
4189         (xstormy16_gdbarch_init): Don't register deleted functions with
4190         gdbarch.
4191
4192 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4193
4194         * vax-tdep.c (vax_unwind_pc): Delete.
4195         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4196
4197 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4198
4199         * v850-tdep.c (v850_unwind_sp): Delete.
4200         (v850_unwind_pc): Delete.
4201         (v850_dummy_id): Delete.
4202         (v850_gdbarch_init): Don't register deleted functions with
4203         gdbarch.
4204
4205 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4206
4207         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4208         (tilegx_unwind_pc): Delete.
4209         (tilegx_unwind_dummy_id): Delete.
4210         (tilegx_gdbarch_init): Don't register deleted functions with
4211         gdbarch.
4212
4213 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4214
4215         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4216         (tic6x_dummy_id): Delete.
4217         (tic6x_gdbarch_init): Don't register deleted functions with
4218         gdbarch.
4219
4220 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4221
4222         * sparc-tdep.c (sparc_unwind_pc): Delete.
4223         (sparc32_gdbarch_init): Don't register deleted function with
4224         gdbarch.
4225
4226 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4227
4228         * sh-tdep.c (sh_unwind_sp): Delete.
4229         (sh_unwind_pc): Delete.
4230         (sh_dummy_id): Delete.
4231         (sh_gdbarch_init): Don't register deleted functions with
4232         gdbarch.
4233
4234 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4235
4236         * score-tdep.c (score_unwind_sp): Delete.
4237         (score_unwind_pc): Delete.
4238         (score_dummy_id): Delete.
4239         (score_gdbarch_init): Don't register deleted functions with
4240         gdbarch.
4241
4242 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4243
4244         * rx-tdep.c (rx_unwind_pc): Delete.
4245         (rx_unwind_sp): Delete.
4246         (rx_dummy_id): Delete.
4247         (rx_gdbarch_init): Don't register deleted functions with
4248         gdbarch.  Update comment.
4249
4250 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4251
4252         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4253         (rs6000_dummy_id): Delete.
4254         (rs6000_gdbarch_init): Don't register deleted functions with
4255         gdbarch.
4256
4257 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4258
4259         * or1k-tdep.c (or1k_dummy_id): Delete.
4260         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4261
4262 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4263
4264         * nios2-tdep.c (nios2_dummy_id): Delete.
4265         (nios2_unwind_sp): Delete.
4266         (nios2_gdbarch_init): Don't register deleted functions with
4267         gdbarch.
4268
4269 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4270
4271         * nds32-tdep.c (nds32_dummy_id): Delete.
4272         (nds32_unwind_pc): Delete.
4273         (nds32_unwind_sp): Delete.
4274         (nds32_gdbarch_init): Don't register deleted functions with
4275         gdbarch.
4276
4277 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4278
4279         * msp430-tdep.c (msp430_unwind_pc): Delete.
4280         (msp430_unwind_sp): Delete.
4281         (msp430_dummy_id): Delete.
4282         (msp430_gdbarch_init): Don't register deleted functions with
4283         gdbarch.
4284
4285 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4286
4287         * moxie-tdep.c (moxie_unwind_sp): Delete.
4288         (moxie_unwind_pc): Delete.
4289         (moxie_dummy_id): Delete.
4290         (moxie_gdbarch_init): Don't register deleted functions with
4291         gdbarch.
4292
4293 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4294
4295         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4296         (mn10300_unwind_pc): Delete.
4297         (mn10300_unwind_sp): Delete.
4298         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4299         mn10300_unwind_sp.
4300         (mn10300_frame_unwind_init): Don't register deleted functions with
4301         gdbarch.
4302
4303 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4304
4305         * mep-tdep.c (mep_unwind_pc): Delete.
4306         (mep_unwind_sp): Delete.
4307         (mep_dummy_id): Delete.
4308         (mep_gdbarch_init): Don't register deleted functions with
4309         gdbarch.
4310
4311 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4312
4313         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4314         (m68hc11_unwind_sp): Delete.
4315         (m68hc11_gdbarch_init): Don't register deleted functions with
4316         gdbarch.
4317
4318 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4319
4320         * m32r-tdep.c (m32r_unwind_sp): Delete.
4321         (m32r_unwind_pc): Delete.
4322         (m32r_dummy_id): Delete.
4323         (m32r_gdbarch_init): Don't register deleted functions with
4324         gdbarch.
4325
4326 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4327
4328         * m32c-tdep.c (m32c_unwind_pc): Delete.
4329         (m32c_unwind_sp): Delete.
4330         (m32c_dummy_id): Delete.
4331         (m32c_gdbarch_init): Don't register deleted functions with
4332         gdbarch.
4333
4334 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4335
4336         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4337         (lm32_unwind_pc): Delete.
4338         (lm32_dummy_id): Delete.
4339         (lm32_gdbarch_init): Don't register deleted functions with
4340         gdbarch.
4341
4342 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4343
4344         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4345         (iq2000_unwind_pc): Delete.
4346         (iq2000_dummy_id): Delete.
4347         (iq2000_gdbarch_init): Don't register deleted functions with
4348         gdbarch.
4349
4350 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4351
4352         * nds32-tdep.c (nds32_type_align): Delete.
4353         (nds32_push_dummy_call): Use type_align instead.
4354
4355 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4356
4357         * arm-tdep.c (arm_type_align): Only handle vector override case.
4358         (arm_push_dummy_call): Use type_align.
4359         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4360
4361 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4362
4363         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4364         case.
4365         (pass_on_stack): Use type_align.
4366         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4367         function.
4368
4369 2019-04-23  Tom Tromey  <tromey@adacore.com>
4370
4371         * dwarf2read.c (line_header::file_name_at): Remove unused
4372         overload.
4373
4374 2019-04-23  Tom de Vries  <tdevries@suse.de>
4375
4376         PR gdb/24438
4377         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4378         invocation.
4379
4380
4381 2019-03-27  Ali Tamur  <tamur@google.com>
4382
4383         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4384         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4385         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4386         (dwarf_expr_context::get_addr_index): Likewise
4387         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4388         (symbol_needs_eval_context::get_addr_index): Likewise
4389         (disassemble_dwarf_expression): Add DW_OP_addrx
4390         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4391         (read_cutu_die_from_dwo): Update comment
4392         (skip_one_die): Add DW_FORM_addrx
4393         (read_attribute_value): Likewise
4394         (var_decode_location): Add DW_OP_addrx
4395         (dwarf2_const_value_attr): Add DW_FORM_addrx
4396         (dump_die_shallow): Likewise
4397         (dwarf2_fetch_constant_bytes): Likewise
4398         (decode_locdesc): Add DW_OP_addrx
4399         (skip_form_bytes): Add DW_FORM_addrx
4400
4401 2019-04-22  Ali Tamur  <tamur@google.com>
4402
4403         * MAINTAINERS (Write After Approval): Add self.
4404
4405 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4406
4407         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4408         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4409         (open_symbol_file_object): Likewise.
4410         (svr4_default_sos): Add info parameter.
4411         (svr4_read_so_list): Likewise.
4412         (svr4_current_sos_direct): Adjust functions calls to pass down
4413         info.
4414         (svr4_current_sos_1): Add info parameter.
4415         (svr4_current_sos): Call get_svr4_info, pass info down to
4416         svr4_current_sos_1.
4417         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4418         get_svr4_info.
4419         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4420         get_svr4_info.
4421         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4422         to get_svr4_info.
4423         (probes_table_remove_objfile_probes): Likewise.
4424         (register_solib_event_probe): Add info parameter.
4425         (solist_update_incremental): Pass info parameter down to
4426         svr4_read_so_list.
4427         (disable_probes_interface): Add info parameter.
4428         (svr4_handle_solib_event): Pass current_program_space to
4429         get_svr4_info.  Adjust disable_probes_interface cleanup.
4430         (svr4_create_probe_breakpoints): Add info parameter, pass it
4431         down to register_solib_event_probe.
4432         (svr4_create_solib_event_breakpoints): Add info parameter,
4433         pass it down to svr4_create_probe_breakpoints.
4434         (enable_break): Pass info down to
4435         svr4_create_solib_event_breakpoints.
4436         (svr4_solib_create_inferior_hook): Pass current_program_space to
4437         get_svr4_info.
4438         (svr4_clear_solib): Likewise.
4439
4440 2019-04-22  Pedro Alves  <palves@redhat.com>
4441
4442         * solib-svr4.c (svr4_free_objfile_observer): New.
4443         (probe_and_action::objfile): New field.
4444         (probes_table_htab_remove_objfile_probes)
4445         (probes_table_remove_objfile_probes): New functions.
4446         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4447         in the new probe_and_action.  Don't store the probe in 'lookup'.
4448         (svr4_create_probe_breakpoints): Pass objfile to
4449         register_solib_event_probe.
4450         (_initialize_svr4_solib): Register a free_objfile observer.
4451
4452 2019-04-19  Tom Tromey  <tom@tromey.com>
4453
4454         * common/queue.h: Remove.
4455
4456 2019-04-19  Tom Tromey  <tom@tromey.com>
4457
4458         * event-loop.c: Don't include "common/queue.h".
4459
4460 2019-04-19  Tom Tromey  <tom@tromey.com>
4461
4462         * remote.c (remote_target): Use delete.
4463         * remote-notif.h: Include <list>, not "common/queue.h".
4464         (notif_client_p): Remove typedef.
4465         (remote_notif_state): Add constructor, destructor, initializer.
4466         <notif_queue>: Now a std::list.
4467         (remote_notif_state_xfree): Don't declare.
4468         * remote-notif.c (remote_notif_process, handle_notification)
4469         (remote_notif_state_allocate): Update.
4470         (~remote_notif_state): Rename from remote_notif_state_xfree.
4471
4472 2019-04-19  Tom Tromey  <tom@tromey.com>
4473
4474         * symfile.c (reread_symbols): Update.
4475         * objfiles.c (objfile_register_static_link)
4476         (objfile_lookup_static_link): Update
4477         (~objfile) Don't delete static_links.
4478         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4479
4480 2019-04-19  Tom Tromey  <tom@tromey.com>
4481
4482         * type-stack.h (struct type_stack) <insert>: Constify string.
4483         * type-stack.c (type_stack::insert): Constify string.
4484         * gdbtypes.h (lookup_template_type): Update.
4485         (address_space_name_to_int): Update.
4486         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4487         const.
4488         (lookup_template_type): Make name const.
4489         * c-exp.y: Update rules.
4490         (lex_one_token, classify_name, classify_inner_name)
4491         (c_print_token): Update.
4492         * p-exp.y: Update rules.
4493         (yylex): Update.
4494         * f-exp.y: Update rules.
4495         (yylex): Update.
4496         * d-exp.y: Update rules.
4497         (lex_one_token, classify_name, classify_inner_name): Update.
4498         * parse.c (write_dollar_variable, copy_name): Return std::string.
4499         * parser-defs.h (copy_name): Change return type.
4500         * m2-exp.y: Update rules.
4501         (yylex): Update.
4502         * go-exp.y (lex_one_token): Update.
4503         Update rules.
4504         (classify_unsafe_function, classify_packaged_name)
4505         (classify_name, yylex): Update.
4506
4507 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4508
4509         * configure.ac: add --enable-source-highlight switch.
4510         * configure: Regenerate.
4511         * top.c (print_gdb_version): plumb --enable-source-highlight
4512         status to "show configuration".
4513
4514 2019-04-19  Tom Tromey  <tromey@adacore.com>
4515
4516         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4517         Check ADA_TYPE_P.
4518         (empty_record, ada_template_to_fixed_record_type_1)
4519         (template_to_static_fixed_type)
4520         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4521         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4522         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4523         macros.
4524
4525 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4526
4527         PR symtab/24423:
4528         * source.c (print_source_lines_base): Advance "iter" when a
4529         control character is seen.
4530
4531 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4532
4533         * inferior.h (struct infcall_suspend_state_deleter):
4534         Catch exception in destructor to avoid crash.
4535
4536 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4537
4538         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4539         close to the add_com "shell".
4540
4541 2019-04-18  Tom Tromey  <tromey@adacore.com>
4542
4543         * process-stratum-target.h (class process_stratum_target)
4544         <stratum>: Add "final".
4545
4546 2019-04-17  Tom Tromey  <tromey@adacore.com>
4547
4548         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4549         against nullptr before use.
4550
4551 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4552
4553         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4554
4555 2019-04-17  Jim Wilson  <jimw@sifive.com>
4556             Andrew Burgess  <andrew.burgess@embecosm.com>
4557
4558         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4559         code read might fail, assume 4-byte breakpoint in that case.
4560
4561 2019-04-15  Leszek Swirski  <leszeks@google.com>
4562
4563         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4564         rather than a hand-rolled POD check when checking for forced MEMORY
4565         classification.
4566
4567 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4568
4569         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4570         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4571         function.
4572         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4573         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4574         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4575         declaration.
4576
4577 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4578
4579         * aarch64-linux-nat.c
4580         (aarch64_linux_nat_target::thread_architecture): Add override.
4581         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4582         each VQ.
4583
4584 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4585
4586         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4587
4588 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4589
4590         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4591         target types of size 96-bits, add some additional comments, and
4592         check that the builtin type we found was the correct size.
4593
4594 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4595
4596         * utils.c (prompt_for_continue): Don't restore the styling at the
4597         end, as applied_style has the wrong value.  This fixes styling in
4598         long lists of file names that are interrupted by the "Continue?"
4599         prompt.
4600
4601 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4602
4603         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4604         * c-lang.c (c_language_defn): Likewise.
4605         (cplus_language_defn): Likewise.
4606         (asm_language_defn): Likewise.
4607         (minimal_language_defn): Likewise.
4608         * d-lang.c (d_language_defn): Likewise.
4609         * f-lang.c (f_language_defn): Likewise.
4610         * go-lang.c (go_language_defn): Likewise.
4611         * language.c (unknown_language_defn): Likewise.
4612         (auto_language_defn): Likewise.
4613         * language.h (struct language_defn): Remove la_magic field.
4614         (LANG_MAGIC): Delete.
4615         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4616         * objc-lang.c (objc_language_defn): Likewise.
4617         * opencl-lang.c (opencl_language_defn): Likewise.
4618         * p-lang.c (pascal_language_defn): Likewise.
4619         * rust-lang.c (rust_language_defn): Likewise.
4620
4621 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4622
4623         * riscv-tdep.c (riscv_type_align): New function.
4624         (riscv_type_alignment): Delete.
4625         (riscv_arg_location): Use 'type_align'.
4626         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4627
4628 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4629
4630         * gdbtypes.c (type_align): A struct with no non-static fields also
4631         has alignment of 1.
4632
4633 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4634
4635         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4636         component to 0.
4637         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4638         member.
4639         (riscv_struct_info::analyse): New implementation using new
4640         analyse_inner member function.
4641         (riscv_struct_info::field_offset): New member function.
4642         (riscv_struct_info::m_offsets): New member variable.
4643         (riscv_struct_info::analyse_inner): New private member function,
4644         takes the old implementation of riscv_struct_info::analyse but
4645         extended to track field offsets.
4646         (riscv_call_arg_struct): Update the struct folding special cases
4647         to handle cases where empty C++ structs, which are non-zero
4648         length, are found.
4649         (riscv_arg_location): Initialise the length of each location, a
4650         non-zero length now indicates the location is in use.
4651         (riscv_push_dummy_call): Allow for the first location having a
4652         non-zero offset when setting up arguments.
4653         (riscv_return_value): Likewise, but for return values.
4654
4655 2019-04-11  Tom Tromey  <tromey@adacore.com>
4656
4657         * utils.c (internal_vproblem): Make "msg" const.
4658
4659 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4660
4661         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4662         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4663         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4664         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4665
4666 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4667
4668         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4669         function.
4670         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4671         of amd64_collect_native_gregset.
4672         (amd64_linux_nat_target::store_registers): Likewise.
4673
4674 2019-04-10  Tom Tromey  <tom@tromey.com>
4675
4676         * symtab.c (lookup_global_symbol_from_objfile)
4677         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4678         * objfiles.h (class separate_debug_iterator): New.
4679         (class separate_debug_range): New.
4680         (struct objfile) <separate_debug_objfiles>: New method.
4681         (objfile_separate_debug_iterate): Don't declare.
4682         * objfiles.c (separate_debug_iterator::operator++): Rename from
4683         objfile_separate_debug_iterate.
4684         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4685         iterator.
4686         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4687         iterator.
4688
4689 2019-04-10  Tom Tromey  <tom@tromey.com>
4690
4691         * symfile.c (reread_symbols): Remove old comment.
4692         * objfiles.c (free_all_objfiles): Fix a typo.
4693
4694 2019-04-10  Tom Tromey  <tom@tromey.com>
4695
4696         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4697         * minsyms.c (lookup_minimal_symbol): Use foreach.
4698         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4699         (lookup_minimal_symbol_solib_trampoline): Likewise.
4700         * symfile.c (reread_symbols): Use foreach.
4701
4702 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4703             Tom Tromey  <tromey@adacore.com>
4704
4705         PR rust/24414:
4706         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4707         (rust_lex_int_test): Change "value" to be LONGEST.
4708         (rust_lex_tests): Add test for long integer literal.
4709
4710 2019-04-09  Tom Tromey  <tromey@adacore.com>
4711
4712         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4713         to bool.
4714         (extended_remote_target::attach): Update.
4715         (remote_target::remote_notice_new_inferior): Update.
4716         (remote_target::add_current_inferior_and_thread): Update.
4717         * inferior.c (exit_inferior_1): Use "false".
4718         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4719
4720 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4721
4722         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4723         the "start" command.
4724
4725 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4726
4727         * python/py-inferior.c (infpy_thread_from_thread_handle):
4728         Adjust comments to reflect renaming of thread_from_thread_handle
4729         to thread_from_handle.  Adjust keywords.  Fix type error message.
4730         (inferior_object_methods): Add thread_from_handle.  Retain
4731         thread_from_thread_handle, but mark it as deprecated.
4732
4733 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4734
4735         * gdbthread.h (find_thread_by_handle): Revise declaration.
4736         * thread.c (find_thread_by_handle): Likewise.  Adjust
4737         implementation too.
4738         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4739         support for buffer objects as handles.
4740
4741 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4742
4743         * python/py-infthread.c (thpy_thread_handle): New function.
4744         (thread_object_methods): Register thpy_thread_handle.
4745
4746 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4747
4748         * gdbthread.h (thread_to_thread_handle): Declare.
4749         * thread.c (gdbtypes.h): Include.
4750         (thread_to_thread_handle): New function.
4751
4752         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4753         (target_thread_info_to_thread_handle): Declare.
4754         * target.c (target_thread_info_to_thread_handle): New function.
4755         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4756         * target-delegates.c: Regenerate.
4757
4758         * linux-thread-db.c (class thread_db_target): Add method
4759         thread_info_to_thread_handle.
4760         (thread_db_target::thread_info_to_thread_handle): Define.
4761         * remote.c (class remote_target): Add new method
4762         thread_info_to_thread_handle.
4763         (remote_target::thread_info_to_thread_handle): Define.
4764
4765 2019-04-08  Pedro Alves  <palves@redhat.com>
4766
4767         * common/common-exceptions.c (throw_exception): Don't create
4768         named object to throw; throw directly.
4769         (throw_it): Likewise.  Don't initialize gdb_exception::message
4770         here, with new; pass FMT and AP to the ctor instead.
4771         * common/common-exceptions.h: Include <string>.
4772         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4773         const char *, va_list)): New ctor.  Use std::make_shared.
4774         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4775         errors)): Delete.
4776         (gdb_exception_error::gdb_exception_error(enum errors, const char
4777         *, va_list)): New.
4778         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4779         Add assertion.
4780         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4781         errors)): Delete.
4782         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4783         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4784         Add assertion.
4785
4786 2019-04-08  Tom Tromey  <tom@tromey.com>
4787
4788         * valops.c (value_rtti_indirect_type): Replace throw_exception
4789         with throw.
4790         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4791         with throw.
4792         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4793         throw.
4794         * target.c (target_translate_tls_address): Replace throw_exception
4795         with throw.
4796         * stack.c (frame_apply_command_count): Replace throw_exception
4797         with throw.
4798         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4799         throw.
4800         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4801         with throw.
4802         * rs6000-tdep.c (rs6000_frame_cache)
4803         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4804         * remote.c: Replace throw_exception with throw.
4805         * record-full.c (record_full_message, record_full_wait_1)
4806         (record_full_restore): Replace throw_exception with throw.
4807         * record-btrace.c:
4808         (get_thread_current_frame_id, record_btrace_start_replaying)
4809         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4810         (cmd_record_btrace_start): Replace throw_exception with throw.
4811         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4812         throw.
4813         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4814         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4815         * linespec.c:
4816         (find_linespec_symbols): Replace throw_exception with throw.
4817         * infrun.c (displaced_step_prepare, resume): Replace
4818         throw_exception with throw.
4819         * infcmd.c (post_create_inferior): Replace throw_exception with
4820         throw.
4821         * inf-loop.c (inferior_event_handler): Replace throw_exception
4822         with throw.
4823         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4824         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4825         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4826         (get_prev_frame_always, get_frame_pc_if_available)
4827         (get_frame_address_in_block_if_available, get_frame_language):
4828         Replace throw_exception with throw.
4829         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4830         throw_exception with throw.
4831         * eval.c (fetch_subexp_value, evaluate_var_value)
4832         (evaluate_funcall, evaluate_subexp_standard): Replace
4833         throw_exception with throw.
4834         * dwarf2loc.c (call_site_find_chain)
4835         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4836         Replace throw_exception with throw.
4837         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4838         with throw.
4839         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4840         throw.
4841         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4842         * completer.c (complete_line_internal): Replace throw_exception
4843         with throw.
4844         * compile/compile-object-run.c (compile_object_run): Replace
4845         throw_exception with throw.
4846         * cli/cli-script.c (process_next_line): Replace throw_exception
4847         with throw.
4848         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4849         (btrace_enable, btrace_maint_update_pt_packets): Replace
4850         throw_exception with throw.
4851         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4852         throw_exception with throw.
4853         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4854         throw_exception with throw.
4855         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4856         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4857         * aarch64-tdep.c (aarch64_make_prologue_cache)
4858         (aarch64_make_stub_cache): Replace throw_exception with throw.
4859
4860 2019-04-08  Tom Tromey  <tom@tromey.com>
4861
4862         * common/common-exceptions.c (throw_exception): Rename from
4863         throw_exception_cxx.  Remove old copy.  Make argument const.
4864         (throw_it): Create and throw exception objects directly.
4865         * common/common-exceptions.h (throw_exception): Make argument
4866         const.
4867         (struct gdb_exception_error): Add constructor.
4868         (struct gdb_exception_quit): Add constructor.
4869
4870 2019-04-08  Tom Tromey  <tom@tromey.com>
4871
4872         * common/common-exceptions.h (exception_rethrow): Don't declare.
4873         (TRY_SJLJ): Update comment.
4874         (TRY, CATCH, END_CATCH): Remove.
4875         * common/common-exceptions.c (exception_rethrow): Remove.
4876
4877 2019-04-08  Tom Tromey  <tom@tromey.com>
4878
4879         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4880         Remove.
4881         (gdb_exception_error): Rename from
4882         gdb_exception_RETURN_MASK_ERROR.
4883         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4884         (gdb_quit_bad_alloc): Update.
4885         * aarch64-tdep.c: Update.
4886         * ada-lang.c: Update.
4887         * ada-typeprint.c: Update.
4888         * ada-valprint.c: Update.
4889         * amd64-tdep.c: Update.
4890         * arch-utils.c: Update.
4891         * break-catch-throw.c: Update.
4892         * breakpoint.c: Update.
4893         * btrace.c: Update.
4894         * c-varobj.c: Update.
4895         * cli/cli-cmds.c: Update.
4896         * cli/cli-interp.c: Update.
4897         * cli/cli-script.c: Update.
4898         * common/common-exceptions.c: Update.
4899         * common/new-op.c: Update.
4900         * common/selftest.c: Update.
4901         * compile/compile-c-symbols.c: Update.
4902         * compile/compile-cplus-symbols.c: Update.
4903         * compile/compile-object-load.c: Update.
4904         * compile/compile-object-run.c: Update.
4905         * completer.c: Update.
4906         * corelow.c: Update.
4907         * cp-abi.c: Update.
4908         * cp-support.c: Update.
4909         * cp-valprint.c: Update.
4910         * darwin-nat.c: Update.
4911         * disasm-selftests.c: Update.
4912         * dtrace-probe.c: Update.
4913         * dwarf-index-cache.c: Update.
4914         * dwarf-index-write.c: Update.
4915         * dwarf2-frame-tailcall.c: Update.
4916         * dwarf2-frame.c: Update.
4917         * dwarf2loc.c: Update.
4918         * dwarf2read.c: Update.
4919         * eval.c: Update.
4920         * event-loop.c: Update.
4921         * event-top.c: Update.
4922         * exec.c: Update.
4923         * f-valprint.c: Update.
4924         * fbsd-tdep.c: Update.
4925         * frame-unwind.c: Update.
4926         * frame.c: Update.
4927         * gdbtypes.c: Update.
4928         * gnu-v3-abi.c: Update.
4929         * guile/guile-internal.h: Update.
4930         * guile/scm-block.c: Update.
4931         * guile/scm-breakpoint.c: Update.
4932         * guile/scm-cmd.c: Update.
4933         * guile/scm-disasm.c: Update.
4934         * guile/scm-frame.c: Update.
4935         * guile/scm-lazy-string.c: Update.
4936         * guile/scm-math.c: Update.
4937         * guile/scm-param.c: Update.
4938         * guile/scm-ports.c: Update.
4939         * guile/scm-pretty-print.c: Update.
4940         * guile/scm-symbol.c: Update.
4941         * guile/scm-symtab.c: Update.
4942         * guile/scm-type.c: Update.
4943         * guile/scm-value.c: Update.
4944         * i386-linux-tdep.c: Update.
4945         * i386-tdep.c: Update.
4946         * inf-loop.c: Update.
4947         * infcall.c: Update.
4948         * infcmd.c: Update.
4949         * infrun.c: Update.
4950         * jit.c: Update.
4951         * language.c: Update.
4952         * linespec.c: Update.
4953         * linux-fork.c: Update.
4954         * linux-nat.c: Update.
4955         * linux-tdep.c: Update.
4956         * linux-thread-db.c: Update.
4957         * main.c: Update.
4958         * mi/mi-cmd-break.c: Update.
4959         * mi/mi-cmd-stack.c: Update.
4960         * mi/mi-interp.c: Update.
4961         * mi/mi-main.c: Update.
4962         * objc-lang.c: Update.
4963         * p-valprint.c: Update.
4964         * parse.c: Update.
4965         * ppc-linux-tdep.c: Update.
4966         * printcmd.c: Update.
4967         * python/py-arch.c: Update.
4968         * python/py-breakpoint.c: Update.
4969         * python/py-cmd.c: Update.
4970         * python/py-finishbreakpoint.c: Update.
4971         * python/py-frame.c: Update.
4972         * python/py-framefilter.c: Update.
4973         * python/py-gdb-readline.c: Update.
4974         * python/py-inferior.c: Update.
4975         * python/py-infthread.c: Update.
4976         * python/py-lazy-string.c: Update.
4977         * python/py-linetable.c: Update.
4978         * python/py-objfile.c: Update.
4979         * python/py-param.c: Update.
4980         * python/py-prettyprint.c: Update.
4981         * python/py-progspace.c: Update.
4982         * python/py-record-btrace.c: Update.
4983         * python/py-record.c: Update.
4984         * python/py-symbol.c: Update.
4985         * python/py-type.c: Update.
4986         * python/py-unwind.c: Update.
4987         * python/py-utils.c: Update.
4988         * python/py-value.c: Update.
4989         * python/python.c: Update.
4990         * record-btrace.c: Update.
4991         * record-full.c: Update.
4992         * remote-fileio.c: Update.
4993         * remote.c: Update.
4994         * riscv-tdep.c: Update.
4995         * rs6000-aix-tdep.c: Update.
4996         * rs6000-tdep.c: Update.
4997         * rust-exp.y: Update.
4998         * rust-lang.c: Update.
4999         * s390-tdep.c: Update.
5000         * selftest-arch.c: Update.
5001         * solib-dsbt.c: Update.
5002         * solib-frv.c: Update.
5003         * solib-spu.c: Update.
5004         * solib-svr4.c: Update.
5005         * solib.c: Update.
5006         * sparc64-linux-tdep.c: Update.
5007         * stack.c: Update.
5008         * symfile-mem.c: Update.
5009         * symmisc.c: Update.
5010         * target.c: Update.
5011         * thread.c: Update.
5012         * top.c: Update.
5013         * tracefile-tfile.c: Update.
5014         * tui/tui.c: Update.
5015         * typeprint.c: Update.
5016         * unittests/cli-utils-selftests.c: Update.
5017         * unittests/parse-connection-spec-selftests.c: Update.
5018         * valops.c: Update.
5019         * valprint.c: Update.
5020         * value.c: Update.
5021         * varobj.c: Update.
5022         * windows-nat.c: Update.
5023         * x86-linux-nat.c: Update.
5024         * xml-support.c: Update.
5025
5026 2019-04-08  Tom Tromey  <tom@tromey.com>
5027
5028         * xml-support.c: Use C++ exception handling.
5029         * x86-linux-nat.c: Use C++ exception handling.
5030         * windows-nat.c: Use C++ exception handling.
5031         * varobj.c: Use C++ exception handling.
5032         * value.c: Use C++ exception handling.
5033         * valprint.c: Use C++ exception handling.
5034         * valops.c: Use C++ exception handling.
5035         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5036         handling.
5037         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5038         * typeprint.c: Use C++ exception handling.
5039         * tui/tui.c: Use C++ exception handling.
5040         * tracefile-tfile.c: Use C++ exception handling.
5041         * top.c: Use C++ exception handling.
5042         * thread.c: Use C++ exception handling.
5043         * target.c: Use C++ exception handling.
5044         * symmisc.c: Use C++ exception handling.
5045         * symfile-mem.c: Use C++ exception handling.
5046         * stack.c: Use C++ exception handling.
5047         * sparc64-linux-tdep.c: Use C++ exception handling.
5048         * solib.c: Use C++ exception handling.
5049         * solib-svr4.c: Use C++ exception handling.
5050         * solib-spu.c: Use C++ exception handling.
5051         * solib-frv.c: Use C++ exception handling.
5052         * solib-dsbt.c: Use C++ exception handling.
5053         * selftest-arch.c: Use C++ exception handling.
5054         * s390-tdep.c: Use C++ exception handling.
5055         * rust-lang.c: Use C++ exception handling.
5056         * rust-exp.y: Use C++ exception handling.
5057         * rs6000-tdep.c: Use C++ exception handling.
5058         * rs6000-aix-tdep.c: Use C++ exception handling.
5059         * riscv-tdep.c: Use C++ exception handling.
5060         * remote.c: Use C++ exception handling.
5061         * remote-fileio.c: Use C++ exception handling.
5062         * record-full.c: Use C++ exception handling.
5063         * record-btrace.c: Use C++ exception handling.
5064         * python/python.c: Use C++ exception handling.
5065         * python/py-value.c: Use C++ exception handling.
5066         * python/py-utils.c: Use C++ exception handling.
5067         * python/py-unwind.c: Use C++ exception handling.
5068         * python/py-type.c: Use C++ exception handling.
5069         * python/py-symbol.c: Use C++ exception handling.
5070         * python/py-record.c: Use C++ exception handling.
5071         * python/py-record-btrace.c: Use C++ exception handling.
5072         * python/py-progspace.c: Use C++ exception handling.
5073         * python/py-prettyprint.c: Use C++ exception handling.
5074         * python/py-param.c: Use C++ exception handling.
5075         * python/py-objfile.c: Use C++ exception handling.
5076         * python/py-linetable.c: Use C++ exception handling.
5077         * python/py-lazy-string.c: Use C++ exception handling.
5078         * python/py-infthread.c: Use C++ exception handling.
5079         * python/py-inferior.c: Use C++ exception handling.
5080         * python/py-gdb-readline.c: Use C++ exception handling.
5081         * python/py-framefilter.c: Use C++ exception handling.
5082         * python/py-frame.c: Use C++ exception handling.
5083         * python/py-finishbreakpoint.c: Use C++ exception handling.
5084         * python/py-cmd.c: Use C++ exception handling.
5085         * python/py-breakpoint.c: Use C++ exception handling.
5086         * python/py-arch.c: Use C++ exception handling.
5087         * printcmd.c: Use C++ exception handling.
5088         * ppc-linux-tdep.c: Use C++ exception handling.
5089         * parse.c: Use C++ exception handling.
5090         * p-valprint.c: Use C++ exception handling.
5091         * objc-lang.c: Use C++ exception handling.
5092         * mi/mi-main.c: Use C++ exception handling.
5093         * mi/mi-interp.c: Use C++ exception handling.
5094         * mi/mi-cmd-stack.c: Use C++ exception handling.
5095         * mi/mi-cmd-break.c: Use C++ exception handling.
5096         * main.c: Use C++ exception handling.
5097         * linux-thread-db.c: Use C++ exception handling.
5098         * linux-tdep.c: Use C++ exception handling.
5099         * linux-nat.c: Use C++ exception handling.
5100         * linux-fork.c: Use C++ exception handling.
5101         * linespec.c: Use C++ exception handling.
5102         * language.c: Use C++ exception handling.
5103         * jit.c: Use C++ exception handling.
5104         * infrun.c: Use C++ exception handling.
5105         * infcmd.c: Use C++ exception handling.
5106         * infcall.c: Use C++ exception handling.
5107         * inf-loop.c: Use C++ exception handling.
5108         * i386-tdep.c: Use C++ exception handling.
5109         * i386-linux-tdep.c: Use C++ exception handling.
5110         * guile/scm-value.c: Use C++ exception handling.
5111         * guile/scm-type.c: Use C++ exception handling.
5112         * guile/scm-symtab.c: Use C++ exception handling.
5113         * guile/scm-symbol.c: Use C++ exception handling.
5114         * guile/scm-pretty-print.c: Use C++ exception handling.
5115         * guile/scm-ports.c: Use C++ exception handling.
5116         * guile/scm-param.c: Use C++ exception handling.
5117         * guile/scm-math.c: Use C++ exception handling.
5118         * guile/scm-lazy-string.c: Use C++ exception handling.
5119         * guile/scm-frame.c: Use C++ exception handling.
5120         * guile/scm-disasm.c: Use C++ exception handling.
5121         * guile/scm-cmd.c: Use C++ exception handling.
5122         * guile/scm-breakpoint.c: Use C++ exception handling.
5123         * guile/scm-block.c: Use C++ exception handling.
5124         * guile/guile-internal.h: Use C++ exception handling.
5125         * gnu-v3-abi.c: Use C++ exception handling.
5126         * gdbtypes.c: Use C++ exception handling.
5127         * frame.c: Use C++ exception handling.
5128         * frame-unwind.c: Use C++ exception handling.
5129         * fbsd-tdep.c: Use C++ exception handling.
5130         * f-valprint.c: Use C++ exception handling.
5131         * exec.c: Use C++ exception handling.
5132         * event-top.c: Use C++ exception handling.
5133         * event-loop.c: Use C++ exception handling.
5134         * eval.c: Use C++ exception handling.
5135         * dwarf2read.c: Use C++ exception handling.
5136         * dwarf2loc.c: Use C++ exception handling.
5137         * dwarf2-frame.c: Use C++ exception handling.
5138         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5139         * dwarf-index-write.c: Use C++ exception handling.
5140         * dwarf-index-cache.c: Use C++ exception handling.
5141         * dtrace-probe.c: Use C++ exception handling.
5142         * disasm-selftests.c: Use C++ exception handling.
5143         * darwin-nat.c: Use C++ exception handling.
5144         * cp-valprint.c: Use C++ exception handling.
5145         * cp-support.c: Use C++ exception handling.
5146         * cp-abi.c: Use C++ exception handling.
5147         * corelow.c: Use C++ exception handling.
5148         * completer.c: Use C++ exception handling.
5149         * compile/compile-object-run.c: Use C++ exception handling.
5150         * compile/compile-object-load.c: Use C++ exception handling.
5151         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5152         * compile/compile-c-symbols.c: Use C++ exception handling.
5153         * common/selftest.c: Use C++ exception handling.
5154         * common/new-op.c: Use C++ exception handling.
5155         * cli/cli-script.c: Use C++ exception handling.
5156         * cli/cli-interp.c: Use C++ exception handling.
5157         * cli/cli-cmds.c: Use C++ exception handling.
5158         * c-varobj.c: Use C++ exception handling.
5159         * btrace.c: Use C++ exception handling.
5160         * breakpoint.c: Use C++ exception handling.
5161         * break-catch-throw.c: Use C++ exception handling.
5162         * arch-utils.c: Use C++ exception handling.
5163         * amd64-tdep.c: Use C++ exception handling.
5164         * ada-valprint.c: Use C++ exception handling.
5165         * ada-typeprint.c: Use C++ exception handling.
5166         * ada-lang.c: Use C++ exception handling.
5167         * aarch64-tdep.c: Use C++ exception handling.
5168
5169 2019-04-08  Tom Tromey  <tom@tromey.com>
5170
5171         * xml-support.c (gdb_xml_parser::parse): Update.
5172         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5173         * value.c (show_convenience): Update.
5174         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5175         (test_parse_flags_qcs): Update.
5176         * thread.c (thr_try_catch_cmd): Update.
5177         * target.c (target_translate_tls_address): Update.
5178         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5179         (info_frame_command_core, frame_apply_command_count): Update.
5180         * rust-exp.y (rust_lex_exception_test): Update.
5181         * riscv-tdep.c (riscv_print_one_register_info): Update.
5182         * remote.c (remote_target::enable_btrace): Update.
5183         * record-btrace.c (record_btrace_enable_warn): Update.
5184         * python/py-utils.c (gdbpy_convert_exception): Update.
5185         * printcmd.c (do_one_display, print_variable_and_value): Update.
5186         * mi/mi-main.c (mi_print_exception): Update.
5187         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5188         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5189         * linux-nat.c (linux_nat_target::attach): Update.
5190         * linux-fork.c (class scoped_switch_fork_info): Update.
5191         * infrun.c (displaced_step_prepare): Update.
5192         * infcall.c (call_function_by_hand_dummy): Update.
5193         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5194         * gnu-v3-abi.c (print_one_vtable): Update.
5195         * frame.c (get_prev_frame_always): Update.
5196         * f-valprint.c (info_common_command_for_block): Update.
5197         * exec.c (try_open_exec_file): Update.
5198         * exceptions.c (print_exception, exception_print)
5199         (exception_fprintf, exception_print_same): Update.
5200         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5201         * dwarf-index-cache.c (index_cache::store)
5202         (index_cache::lookup_gdb_index): Update.
5203         * darwin-nat.c (maybe_cache_shell): Update.
5204         * cp-valprint.c (cp_print_value_fields): Update.
5205         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5206         (gcc_cplus_symbol_address): Update.
5207         * compile/compile-c-symbols.c (gcc_convert_symbol)
5208         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5209         * common/selftest.c: Update.
5210         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5211         a std::string.
5212         (exception_try_scope_entry, exception_try_scope_exit): Don't
5213         declare.
5214         (struct exception_try_scope): Remove.
5215         (TRY): Don't use exception_try_scope.
5216         (struct gdb_exception): Add constructor, operator=.
5217         <what>: New method.
5218         (struct gdb_exception_RETURN_MASK_ALL)
5219         (struct gdb_exception_RETURN_MASK_ERROR)
5220         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5221         (struct gdb_quit_bad_alloc): Update.
5222         * common/common-exceptions.c (exception_none): Change
5223         initializer.
5224         (struct catcher) <state, exception>: Initialize inline.
5225         <prev>: Remove member.
5226         (current_catcher): Remove.
5227         (catchers): New global.
5228         (exceptions_state_mc_init): Simplify.
5229         (catcher_pop): Remove.
5230         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5231         (try_scope_depth, exception_try_scope_entry)
5232         (exception_try_scope_exit): Remove.
5233         (throw_exception_sjlj): Update.
5234         (exception_messages, exception_messages_size): Remove.
5235         (throw_it): Simplify.
5236         (gdb_exception_sliced_copy): Remove.
5237         (throw_exception_cxx): Update.
5238         * cli/cli-script.c (script_from_file): Update.
5239         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5240         Update.
5241         * ada-valprint.c (ada_val_print): Update.
5242         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5243         (create_excep_cond_exprs): Update.
5244
5245 2019-04-08  Tom Tromey  <tom@tromey.com>
5246
5247         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5248         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5249         (TRY, CATCH, END_CATCH): Remove some definitions.
5250         * common/common-exceptions.c: Don't use GDB_XCPT.
5251         (catcher_list_size): Remove.
5252         (throw_exception, throw_it): Simplify.
5253
5254 2019-04-05  Tom Tromey  <tom@tromey.com>
5255
5256         Revert the header-sorting patch.
5257         * ft32-tdep.c: Revert.
5258         * frv-tdep.c: Revert.
5259         * frv-linux-tdep.c: Revert.
5260         * frame.c: Revert.
5261         * frame-unwind.c: Revert.
5262         * frame-base.c: Revert.
5263         * fork-child.c: Revert.
5264         * findvar.c: Revert.
5265         * findcmd.c: Revert.
5266         * filesystem.c: Revert.
5267         * filename-seen-cache.h: Revert.
5268         * filename-seen-cache.c: Revert.
5269         * fbsd-tdep.c: Revert.
5270         * fbsd-nat.h: Revert.
5271         * fbsd-nat.c: Revert.
5272         * f-valprint.c: Revert.
5273         * f-typeprint.c: Revert.
5274         * f-lang.c: Revert.
5275         * extension.h: Revert.
5276         * extension.c: Revert.
5277         * extension-priv.h: Revert.
5278         * expprint.c: Revert.
5279         * exec.h: Revert.
5280         * exec.c: Revert.
5281         * exceptions.c: Revert.
5282         * event-top.c: Revert.
5283         * event-loop.c: Revert.
5284         * eval.c: Revert.
5285         * elfread.c: Revert.
5286         * dwarf2read.h: Revert.
5287         * dwarf2read.c: Revert.
5288         * dwarf2loc.c: Revert.
5289         * dwarf2expr.h: Revert.
5290         * dwarf2expr.c: Revert.
5291         * dwarf2-frame.c: Revert.
5292         * dwarf2-frame-tailcall.c: Revert.
5293         * dwarf-index-write.h: Revert.
5294         * dwarf-index-write.c: Revert.
5295         * dwarf-index-common.c: Revert.
5296         * dwarf-index-cache.h: Revert.
5297         * dwarf-index-cache.c: Revert.
5298         * dummy-frame.c: Revert.
5299         * dtrace-probe.c: Revert.
5300         * disasm.h: Revert.
5301         * disasm.c: Revert.
5302         * disasm-selftests.c: Revert.
5303         * dictionary.c: Revert.
5304         * dicos-tdep.c: Revert.
5305         * demangle.c: Revert.
5306         * dcache.h: Revert.
5307         * dcache.c: Revert.
5308         * darwin-nat.h: Revert.
5309         * darwin-nat.c: Revert.
5310         * darwin-nat-info.c: Revert.
5311         * d-valprint.c: Revert.
5312         * d-namespace.c: Revert.
5313         * d-lang.c: Revert.
5314         * ctf.c: Revert.
5315         * csky-tdep.c: Revert.
5316         * csky-linux-tdep.c: Revert.
5317         * cris-tdep.c: Revert.
5318         * cris-linux-tdep.c: Revert.
5319         * cp-valprint.c: Revert.
5320         * cp-support.c: Revert.
5321         * cp-namespace.c: Revert.
5322         * cp-abi.c: Revert.
5323         * corelow.c: Revert.
5324         * corefile.c: Revert.
5325         * continuations.c: Revert.
5326         * completer.h: Revert.
5327         * completer.c: Revert.
5328         * complaints.c: Revert.
5329         * coffread.c: Revert.
5330         * coff-pe-read.c: Revert.
5331         * cli-out.h: Revert.
5332         * cli-out.c: Revert.
5333         * charset.c: Revert.
5334         * c-varobj.c: Revert.
5335         * c-valprint.c: Revert.
5336         * c-typeprint.c: Revert.
5337         * c-lang.c: Revert.
5338         * buildsym.c: Revert.
5339         * buildsym-legacy.c: Revert.
5340         * build-id.h: Revert.
5341         * build-id.c: Revert.
5342         * btrace.c: Revert.
5343         * bsd-uthread.c: Revert.
5344         * breakpoint.h: Revert.
5345         * breakpoint.c: Revert.
5346         * break-catch-throw.c: Revert.
5347         * break-catch-syscall.c: Revert.
5348         * break-catch-sig.c: Revert.
5349         * blockframe.c: Revert.
5350         * block.c: Revert.
5351         * bfin-tdep.c: Revert.
5352         * bfin-linux-tdep.c: Revert.
5353         * bfd-target.c: Revert.
5354         * bcache.c: Revert.
5355         * ax-general.c: Revert.
5356         * ax-gdb.h: Revert.
5357         * ax-gdb.c: Revert.
5358         * avr-tdep.c: Revert.
5359         * auxv.c: Revert.
5360         * auto-load.c: Revert.
5361         * arm-wince-tdep.c: Revert.
5362         * arm-tdep.c: Revert.
5363         * arm-symbian-tdep.c: Revert.
5364         * arm-pikeos-tdep.c: Revert.
5365         * arm-obsd-tdep.c: Revert.
5366         * arm-nbsd-tdep.c: Revert.
5367         * arm-nbsd-nat.c: Revert.
5368         * arm-linux-tdep.c: Revert.
5369         * arm-linux-nat.c: Revert.
5370         * arm-fbsd-tdep.c: Revert.
5371         * arm-fbsd-nat.c: Revert.
5372         * arm-bsd-tdep.c: Revert.
5373         * arch-utils.c: Revert.
5374         * arc-tdep.c: Revert.
5375         * arc-newlib-tdep.c: Revert.
5376         * annotate.h: Revert.
5377         * annotate.c: Revert.
5378         * amd64-windows-tdep.c: Revert.
5379         * amd64-windows-nat.c: Revert.
5380         * amd64-tdep.c: Revert.
5381         * amd64-sol2-tdep.c: Revert.
5382         * amd64-obsd-tdep.c: Revert.
5383         * amd64-obsd-nat.c: Revert.
5384         * amd64-nbsd-tdep.c: Revert.
5385         * amd64-nbsd-nat.c: Revert.
5386         * amd64-nat.c: Revert.
5387         * amd64-linux-tdep.c: Revert.
5388         * amd64-linux-nat.c: Revert.
5389         * amd64-fbsd-tdep.c: Revert.
5390         * amd64-fbsd-nat.c: Revert.
5391         * amd64-dicos-tdep.c: Revert.
5392         * amd64-darwin-tdep.c: Revert.
5393         * amd64-bsd-nat.c: Revert.
5394         * alpha-tdep.c: Revert.
5395         * alpha-obsd-tdep.c: Revert.
5396         * alpha-nbsd-tdep.c: Revert.
5397         * alpha-mdebug-tdep.c: Revert.
5398         * alpha-linux-tdep.c: Revert.
5399         * alpha-linux-nat.c: Revert.
5400         * alpha-bsd-tdep.c: Revert.
5401         * alpha-bsd-nat.c: Revert.
5402         * aix-thread.c: Revert.
5403         * agent.c: Revert.
5404         * addrmap.c: Revert.
5405         * ada-varobj.c: Revert.
5406         * ada-valprint.c: Revert.
5407         * ada-typeprint.c: Revert.
5408         * ada-tasks.c: Revert.
5409         * ada-lang.c: Revert.
5410         * aarch64-tdep.c: Revert.
5411         * aarch64-ravenscar-thread.c: Revert.
5412         * aarch64-newlib-tdep.c: Revert.
5413         * aarch64-linux-tdep.c: Revert.
5414         * aarch64-linux-nat.c: Revert.
5415         * aarch64-fbsd-tdep.c: Revert.
5416         * aarch64-fbsd-nat.c: Revert.
5417         * aarch32-linux-nat.c: Revert.
5418
5419 2019-04-05  Tom Tromey  <tom@tromey.com>
5420
5421         * ft32-tdep.c: Sort headers.
5422         * frv-tdep.c: Sort headers.
5423         * frv-linux-tdep.c: Sort headers.
5424         * frame.c: Sort headers.
5425         * frame-unwind.c: Sort headers.
5426         * frame-base.c: Sort headers.
5427         * fork-child.c: Sort headers.
5428         * findvar.c: Sort headers.
5429         * findcmd.c: Sort headers.
5430         * filesystem.c: Sort headers.
5431         * filename-seen-cache.h: Sort headers.
5432         * filename-seen-cache.c: Sort headers.
5433         * fbsd-tdep.c: Sort headers.
5434         * fbsd-nat.h: Sort headers.
5435         * fbsd-nat.c: Sort headers.
5436         * f-valprint.c: Sort headers.
5437         * f-typeprint.c: Sort headers.
5438         * f-lang.c: Sort headers.
5439         * extension.h: Sort headers.
5440         * extension.c: Sort headers.
5441         * extension-priv.h: Sort headers.
5442         * expprint.c: Sort headers.
5443         * exec.h: Sort headers.
5444         * exec.c: Sort headers.
5445         * exceptions.c: Sort headers.
5446         * event-top.c: Sort headers.
5447         * event-loop.c: Sort headers.
5448         * eval.c: Sort headers.
5449         * elfread.c: Sort headers.
5450         * dwarf2read.h: Sort headers.
5451         * dwarf2read.c: Sort headers.
5452         * dwarf2loc.c: Sort headers.
5453         * dwarf2expr.h: Sort headers.
5454         * dwarf2expr.c: Sort headers.
5455         * dwarf2-frame.c: Sort headers.
5456         * dwarf2-frame-tailcall.c: Sort headers.
5457         * dwarf-index-write.h: Sort headers.
5458         * dwarf-index-write.c: Sort headers.
5459         * dwarf-index-common.c: Sort headers.
5460         * dwarf-index-cache.h: Sort headers.
5461         * dwarf-index-cache.c: Sort headers.
5462         * dummy-frame.c: Sort headers.
5463         * dtrace-probe.c: Sort headers.
5464         * disasm.h: Sort headers.
5465         * disasm.c: Sort headers.
5466         * disasm-selftests.c: Sort headers.
5467         * dictionary.c: Sort headers.
5468         * dicos-tdep.c: Sort headers.
5469         * demangle.c: Sort headers.
5470         * dcache.h: Sort headers.
5471         * dcache.c: Sort headers.
5472         * darwin-nat.h: Sort headers.
5473         * darwin-nat.c: Sort headers.
5474         * darwin-nat-info.c: Sort headers.
5475         * d-valprint.c: Sort headers.
5476         * d-namespace.c: Sort headers.
5477         * d-lang.c: Sort headers.
5478         * ctf.c: Sort headers.
5479         * csky-tdep.c: Sort headers.
5480         * csky-linux-tdep.c: Sort headers.
5481         * cris-tdep.c: Sort headers.
5482         * cris-linux-tdep.c: Sort headers.
5483         * cp-valprint.c: Sort headers.
5484         * cp-support.c: Sort headers.
5485         * cp-namespace.c: Sort headers.
5486         * cp-abi.c: Sort headers.
5487         * corelow.c: Sort headers.
5488         * corefile.c: Sort headers.
5489         * continuations.c: Sort headers.
5490         * completer.h: Sort headers.
5491         * completer.c: Sort headers.
5492         * complaints.c: Sort headers.
5493         * coffread.c: Sort headers.
5494         * coff-pe-read.c: Sort headers.
5495         * cli-out.h: Sort headers.
5496         * cli-out.c: Sort headers.
5497         * charset.c: Sort headers.
5498         * c-varobj.c: Sort headers.
5499         * c-valprint.c: Sort headers.
5500         * c-typeprint.c: Sort headers.
5501         * c-lang.c: Sort headers.
5502         * buildsym.c: Sort headers.
5503         * buildsym-legacy.c: Sort headers.
5504         * build-id.h: Sort headers.
5505         * build-id.c: Sort headers.
5506         * btrace.c: Sort headers.
5507         * bsd-uthread.c: Sort headers.
5508         * breakpoint.h: Sort headers.
5509         * breakpoint.c: Sort headers.
5510         * break-catch-throw.c: Sort headers.
5511         * break-catch-syscall.c: Sort headers.
5512         * break-catch-sig.c: Sort headers.
5513         * blockframe.c: Sort headers.
5514         * block.c: Sort headers.
5515         * bfin-tdep.c: Sort headers.
5516         * bfin-linux-tdep.c: Sort headers.
5517         * bfd-target.c: Sort headers.
5518         * bcache.c: Sort headers.
5519         * ax-general.c: Sort headers.
5520         * ax-gdb.h: Sort headers.
5521         * ax-gdb.c: Sort headers.
5522         * avr-tdep.c: Sort headers.
5523         * auxv.c: Sort headers.
5524         * auto-load.c: Sort headers.
5525         * arm-wince-tdep.c: Sort headers.
5526         * arm-tdep.c: Sort headers.
5527         * arm-symbian-tdep.c: Sort headers.
5528         * arm-pikeos-tdep.c: Sort headers.
5529         * arm-obsd-tdep.c: Sort headers.
5530         * arm-nbsd-tdep.c: Sort headers.
5531         * arm-nbsd-nat.c: Sort headers.
5532         * arm-linux-tdep.c: Sort headers.
5533         * arm-linux-nat.c: Sort headers.
5534         * arm-fbsd-tdep.c: Sort headers.
5535         * arm-fbsd-nat.c: Sort headers.
5536         * arm-bsd-tdep.c: Sort headers.
5537         * arch-utils.c: Sort headers.
5538         * arc-tdep.c: Sort headers.
5539         * arc-newlib-tdep.c: Sort headers.
5540         * annotate.h: Sort headers.
5541         * annotate.c: Sort headers.
5542         * amd64-windows-tdep.c: Sort headers.
5543         * amd64-windows-nat.c: Sort headers.
5544         * amd64-tdep.c: Sort headers.
5545         * amd64-sol2-tdep.c: Sort headers.
5546         * amd64-obsd-tdep.c: Sort headers.
5547         * amd64-obsd-nat.c: Sort headers.
5548         * amd64-nbsd-tdep.c: Sort headers.
5549         * amd64-nbsd-nat.c: Sort headers.
5550         * amd64-nat.c: Sort headers.
5551         * amd64-linux-tdep.c: Sort headers.
5552         * amd64-linux-nat.c: Sort headers.
5553         * amd64-fbsd-tdep.c: Sort headers.
5554         * amd64-fbsd-nat.c: Sort headers.
5555         * amd64-dicos-tdep.c: Sort headers.
5556         * amd64-darwin-tdep.c: Sort headers.
5557         * amd64-bsd-nat.c: Sort headers.
5558         * alpha-tdep.c: Sort headers.
5559         * alpha-obsd-tdep.c: Sort headers.
5560         * alpha-nbsd-tdep.c: Sort headers.
5561         * alpha-mdebug-tdep.c: Sort headers.
5562         * alpha-linux-tdep.c: Sort headers.
5563         * alpha-linux-nat.c: Sort headers.
5564         * alpha-bsd-tdep.c: Sort headers.
5565         * alpha-bsd-nat.c: Sort headers.
5566         * aix-thread.c: Sort headers.
5567         * agent.c: Sort headers.
5568         * addrmap.c: Sort headers.
5569         * ada-varobj.c: Sort headers.
5570         * ada-valprint.c: Sort headers.
5571         * ada-typeprint.c: Sort headers.
5572         * ada-tasks.c: Sort headers.
5573         * ada-lang.c: Sort headers.
5574         * aarch64-tdep.c: Sort headers.
5575         * aarch64-ravenscar-thread.c: Sort headers.
5576         * aarch64-newlib-tdep.c: Sort headers.
5577         * aarch64-linux-tdep.c: Sort headers.
5578         * aarch64-linux-nat.c: Sort headers.
5579         * aarch64-fbsd-tdep.c: Sort headers.
5580         * aarch64-fbsd-nat.c: Sort headers.
5581         * aarch32-linux-nat.c: Sort headers.
5582
5583 2019-04-04  Tom Tromey  <tom@tromey.com>
5584
5585         * varobj.c (varobj_create): Update.
5586         * rust-exp.y (struct rust_parser) <update_innermost_block,
5587         lookup_symbol>: New methods.
5588         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5589         Rename.
5590         (rust_parser::rust_lookup_type)
5591         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5592         * printcmd.c (display_command, do_one_display): Update.
5593         * parser-defs.h (struct parser_state) <parser_state>: Add
5594         "tracker" parameter.
5595         (block_tracker): New member.
5596         (class innermost_block_tracker) <innermost_block_tracker>: Add
5597         "types" parameter.
5598         <reset>: Remove method.
5599         (innermost_block): Don't declare.
5600         (null_post_parser): Update.
5601         * parse.c (innermost_block): Remove global.
5602         (write_dollar_variable): Update.
5603         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5604         Remove "tracker_types" parameter.
5605         (parse_expression): Add "tracker" parameter.
5606         (parse_expression_for_completion): Update.
5607         (null_post_parser): Add "tracker" parameter.
5608         * p-exp.y: Update rules.
5609         * m2-exp.y: Update rules.
5610         * language.h (struct language_defn) <la_post_parser>: Add
5611         "tracker" parameter.
5612         * go-exp.y: Update rules.
5613         * f-exp.y: Update rules.
5614         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5615         parameter.
5616         * d-exp.y: Update rules.
5617         * c-exp.y: Update rules.
5618         * breakpoint.c (set_breakpoint_condition): Create an
5619         innermost_block_tracker.
5620         (watch_command_1): Likewise.
5621         * ada-lang.c (resolve): Add "tracker" parameter.
5622         (resolve_subexp): Likewise.
5623         * ada-exp.y (write_var_from_sym): Update.
5624
5625 2019-04-04  Tom Tromey  <tom@tromey.com>
5626
5627         * type-stack.h: New file.
5628         * type-stack.c: New file.
5629         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5630         type-stack.h.
5631         (insert_into_type_stack, insert_type, push_type, push_type_int)
5632         (insert_type_address_space, pop_type, pop_type_int)
5633         (pop_typelist, pop_type_stack, append_type_stack)
5634         (push_type_stack, get_type_stack, push_typelist)
5635         (follow_type_instance_flags, follow_types): Don't declare.
5636         * parse.c (type_stack): Remove global.
5637         (parse_exp_in_context): Update.
5638         (insert_into_type_stack, insert_type, push_type, push_type_int)
5639         (insert_type_address_space, pop_type, pop_type_int)
5640         (pop_typelist, pop_type_stack, append_type_stack)
5641         (push_type_stack, get_type_stack, push_typelist)
5642         (follow_type_instance_flags, follow_types): Remove (moved to
5643         type-stack.c).
5644         * f-exp.y (type_stack): New global.
5645         Update rules.
5646         (push_kind_type, f_parse): Update.
5647         * d-exp.y (type_stack): New global.
5648         Update rules.
5649         (d_parse): Update.
5650         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5651         Update rules.
5652         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5653         (HFILES_NO_SRCDIR): Add type-stack.h.
5654
5655 2019-04-04  Tom Tromey  <tom@tromey.com>
5656
5657         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5658         (rust_parser::convert_ast_to_expression, rust_parse)
5659         (rust_lex_test_completion, rust_lex_tests): Update.
5660         * parser-defs.h (struct expr_completion_state): New.
5661         (struct parser_state) <parser_state>: Add completion parameter.
5662         <mark_struct_expression, mark_completion_tag>: New methods.
5663         <parse_completion, m_completion_state>: New members.
5664         (prefixify_expression, null_post_parser): Update.
5665         (mark_struct_expression, mark_completion_tag): Don't declare.
5666         * parse.c (parse_completion, expout_last_struct)
5667         (expout_tag_completion_type, expout_completion_name): Remove
5668         globals.
5669         (parser_state::mark_struct_expression)
5670         (parser_state::mark_completion_tag): Now methods.
5671         (prefixify_expression): Add last_struct parameter.
5672         (prefixify_subexp): Likewise.
5673         (parse_exp_1): Update.
5674         (parse_exp_in_context): Add cstate parameter.  Update.
5675         (parse_expression_for_completion): Create an
5676         expr_completion_state.
5677         (null_post_parser): Add "completion" parameter.
5678         * p-exp.y: Update rules.
5679         (yylex): Update.
5680         * language.h (struct language_defn) <la_post_parser>: Add
5681         "completing" parameter.
5682         * go-exp.y: Update rules.
5683         (lex_one_token): Update.
5684         * expression.h (parse_completion): Don't declare.
5685         * d-exp.y: Update rules.
5686         (lex_one_token): Update rules.
5687         * c-exp.y: Update rules.
5688         (lex_one_token): Update.
5689         * ada-lang.c (resolve): Add "parse_completion" parameter.
5690         (resolve_subexp): Likewise.
5691         (ada_resolve_function): Likewise.
5692
5693 2019-04-04  Tom Tromey  <tom@tromey.com>
5694
5695         * parser-defs.h (struct parser_state) <start_arglist,
5696         end_arglist>: New methods.
5697         <arglist_len, m_funcall_chain>: New members.
5698         (arglist_len, start_arglist, end_arglist): Don't declare.
5699         * parse.c (arglist_len, funcall_chain): Remove global.
5700         (start_arglist, end_arglist): Remove functions.
5701         (parse_exp_in_context): Update.
5702         * p-exp.y: Update rules.
5703         * m2-exp.y: Update rules.
5704         * go-exp.y: Update rules.
5705         * f-exp.y: Update rules.
5706         * d-exp.y: Update rules.
5707         * c-exp.y: Update rules.
5708
5709 2019-04-04  Tom Tromey  <tom@tromey.com>
5710
5711         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5712         lex_operator, push_back>: New methods.
5713         Update all rules.
5714         (rust_parser::lex_hex, lex_escape): Rename and update.
5715         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5716         (rust_parser::lex_operator): Rename and update.
5717         (rust_parser::lex_number, rustyylex, rustyyerror)
5718         (rust_lex_test_init, rust_lex_test_sequence)
5719         (rust_lex_test_push_back, rust_lex_tests): Update.
5720         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5721         parameter.
5722         <lexptr, prev_lexptr>: New members.
5723         (lexptr, prev_lexptr): Don't declare.
5724         * parse.c (lexptr, prev_lexptr): Remove globals.
5725         (parse_exp_in_context): Update.
5726         * p-exp.y (yylex, yyerror): Update.
5727         * m2-exp.y (parse_number, yylex, yyerror): Update.
5728         * go-exp.y (lex_one_token, yyerror): Update.
5729         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5730         * d-exp.y (lex_one_token, yyerror): Update.
5731         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5732         (lex_one_token, yyerror): Update.
5733         * ada-lex.l (YY_INPUT): Update.
5734         (rewind_to_char): Update.
5735         * ada-exp.y (yyerror): Update.
5736
5737 2019-04-04  Tom Tromey  <tom@tromey.com>
5738
5739         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5740         * parser-defs.h (struct parser_state) <parser_state>: Add new
5741         parameter.
5742         <comma_terminates>: New member.
5743         (comma_terminates): Don't declare global.
5744         * parse.c (comma_terminates): Remove global.
5745         (parse_exp_in_context): Update.
5746         * p-exp.y (yylex): Update.
5747         * m2-exp.y (yylex): Update.
5748         * go-exp.y (lex_one_token): Update.
5749         * f-exp.y (yylex): Update.
5750         * d-exp.y (lex_one_token): Update.
5751         * c-exp.y (lex_one_token): Update.
5752         * ada-lex.l: Update.
5753
5754 2019-04-04  Tom Tromey  <tom@tromey.com>
5755
5756         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5757         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5758         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5759         * parser-defs.h (paren_depth): Don't declare.
5760         * parse.c (paren_depth): Remove global.
5761         (parse_exp_in_context): Update.
5762         * p-exp.y (paren_depth): New global.
5763         (pascal_parse): Initialize it.
5764         * m2-exp.y (paren_depth): New global.
5765         (m2_parse): Initialize it.
5766         * go-exp.y (paren_depth): New global.
5767         (go_parse): Initialize it.
5768         * f-exp.y (paren_depth): New global.
5769         (f_parse): Initialize it.
5770         * d-exp.y (paren_depth): New global.
5771         (d_parse): Initialize it.
5772         * c-exp.y (paren_depth): New global.
5773         (c_parse): Initialize it.
5774         * ada-lex.l (paren_depth): New global.
5775         (lexer_init): Initialize it.
5776
5777 2019-04-04  Tom Tromey  <tom@tromey.com>
5778
5779         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5780         (rust_parser::convert_ast_to_type)
5781         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5782         * parser-defs.h (struct parser_state) <parser_state>: Add
5783         parameters.  Initialize new members.
5784         <expression_context_block, expression_context_pc>: New members.
5785         * parse.c (expression_context_block, expression_context_pc):
5786         Remove globals.
5787         (parse_exp_in_context): Update.
5788         * p-exp.y: Update all rules.
5789         (yylex): Update.
5790         * m2-exp.y: Update all rules.
5791         (yylex): Update.
5792         * go-exp.y (yylex): Update.
5793         * f-exp.y (yylex): Update.
5794         * d-exp.y: Update all rules.
5795         (yylex): Update.
5796         * c-exp.y: Update all rules.
5797         (lex_one_token, classify_name, yylex, c_parse): Update.
5798         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5799
5800 2019-04-04  Tom Tromey  <tom@tromey.com>
5801
5802         * gdbarch.h, gdbarch.c: Rebuild.
5803         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5804         * stap-probe.h:
5805         (struct stap_parse_info): Replace "parser_state" with
5806         "expr_builder".
5807         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5808         (parser_state): New class.
5809         * parse.c (expr_builder): Rename.
5810         (expr_builder::release): Rename.
5811         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5812         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5813         (write_exp_elt_longcst, write_exp_elt_floatcst)
5814         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5815         (write_exp_string_vector, write_exp_bitstring)
5816         (write_exp_msymbol, mark_struct_expression)
5817         (write_dollar_variable)
5818         (insert_type_address_space, increase_expout_size): Replace
5819         "parser_state" with "expr_builder".
5820         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5821         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5822         "parser_state" with "expr_builder".
5823
5824 2019-04-04  Tom Tromey  <tom@tromey.com>
5825
5826         * rust-exp.y: Replace "parse_language" with method call.
5827         * p-exp.y:
5828         (yylex): Replace "parse_language" with method call.
5829         * m2-exp.y:
5830         (yylex): Replace "parse_language" with method call.
5831         * go-exp.y (classify_name): Replace "parse_language" with method
5832         call.
5833         * f-exp.y (yylex): Replace "parse_language" with method call.
5834         * d-exp.y (lex_one_token): Replace "parse_language" with method
5835         call.
5836         * c-exp.y:
5837         (lex_one_token, classify_name, yylex): Replace "parse_language"
5838         with method call.
5839         * ada-exp.y (find_primitive_type, type_char)
5840         (type_system_address): Replace "parse_language" with method call.
5841
5842 2019-04-04  Tom Tromey  <tom@tromey.com>
5843
5844         * rust-exp.y: Replace "parse_gdbarch" with method call.
5845         * parse.c (write_dollar_variable, insert_type_address_space):
5846         Replace "parse_gdbarch" with method call.
5847         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5848         call.
5849         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5850         call.
5851         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5852         "parse_gdbarch" with method call.
5853         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5854         with method call.
5855         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5856         "parse_gdbarch" with method call.
5857         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5858         "parse_gdbarch" with method call.
5859         * c-exp.y (parse_type, parse_number, classify_name): Replace
5860         "parse_gdbarch" with method call.
5861         * ada-lex.l: Replace "parse_gdbarch" with method call.
5862         * ada-exp.y (parse_type, find_primitive_type, type_char)
5863         (type_system_address): Replace "parse_gdbarch" with method call.
5864
5865 2019-04-04  Tom Tromey  <tom@tromey.com>
5866
5867         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5868         * stap-probe.c (stap_parse_argument): Update.
5869         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5870         initial_size parameter.
5871         * rust-exp.y (rust_lex_tests): Update.
5872         * parse.c (parser_state): Update.
5873         (parse_exp_in_context): Update.
5874         * parser-defs.h (struct parser_state) <parser_state>: Remove
5875         "initial_size" parameter.
5876
5877 2019-04-04  Tom Tromey  <tom@tromey.com>
5878
5879         * parser-defs.h (increase_expout_size): Don't declare.
5880         * parse.c (increase_expout_size): Now static.
5881
5882 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
5883
5884         * gnu-nat.c (gnu_nat_target::wait): Fix
5885         target_waitstatus_to_string call.
5886
5887 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5888
5889         * eval.c (evaluate_subexp_standard): Handle internal functions
5890         during Fortran function call handling.
5891
5892 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5893
5894         * NEWS: Mention new internal functions.
5895         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5896         (read_base_type): Use dwarf2_init_complex_target_type.
5897         * value.c (creal_internal_fn): New function.
5898         (cimag_internal_fn): New function.
5899         (_initialize_values): Register new internal functions.
5900
5901 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5902
5903         * infrun.c (stop_all_threads): If debug_infrun, always
5904         trace the wait status after wait_one, using
5905         target_waitstatus_to_string and target_pid_to_str.
5906         (handle_inferior_event): Replace various trace of
5907         wait status kind by a single trace.
5908         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5909         wait status kind image by target_waitstatus_to_string.
5910         * target/waitstatus.c (target_waitstatus_to_string): Fix
5911         obsolete comment.
5912
5913 2019-04-01  Tom Tromey  <tromey@adacore.com>
5914
5915         PR symtab/23331:
5916         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
5917
5918 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5919             Pedro Alves  <palves@redhat.com>
5920
5921         * top.c (quit_force): Call 'finalize_values'.
5922         * value.c (finalize_values): New function.
5923         * value.h (finalize_values): Declare.
5924
5925 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
5926
5927         * NEWS: Announce $_gdb_major and $_gdb_minor.
5928
5929         * top.c (init_gdb_version_vars): New function.
5930         (gdb_init): Call init_gdb_version_vars.
5931
5932 2019-03-29  Tom Tromey  <tromey@adacore.com>
5933
5934         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
5935         help text.  Remove dead code.
5936
5937 2019-03-29  Keith Seitz  <keiths@redhat.com>
5938
5939         From Siddhesh Poyarekar:
5940         * f-lang.h (f77_get_upperbound): Return LONGEST.
5941         (f77_get_lowerbound): Likewise.
5942         * f-typeprint.c (f_type_print_varspec_suffix): Expand
5943         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
5944         print them.
5945         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
5946         plongest to format print it.
5947         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
5948         (f77_get_upperbound): Likewise.
5949         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
5950         LOWER_BOUND to LONGEST.
5951         (f77_create_arrayprint_offset_tbl): Likewise.
5952
5953 2019-03-29  Keith Seitz  <keiths@redhat.com>
5954
5955         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
5956         %s/pulongest for TYPE_LENGTH instead of %d in format
5957         strings.
5958         * ada-typerint.c (ada_print_type): Likewise.
5959         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
5960         * compile/compile-c-support.c (generate_register_struct): Likewise.
5961         * gdbtypes.c (recursive_dump_type): Likewise.
5962         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
5963         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
5964         instead of %d in format strings.
5965         * riscv-tdep.c (riscv_type_alignment): Cast second argument
5966         to std::min to ULONGEST.
5967         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
5968         instead of %d in format strings.
5969         * tracepoint.c (info_scope_command): Likewise.
5970         * typeprint.c (print_offset_data::update)
5971         (print_offset_data::finish): Likewise.
5972         * xtensa-tdep.c (xtensa_store_return_value)
5973         (xtensa_push_dummy_call): Likewise.
5974
5975 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
5976
5977         * windows-nat.c (display_selector): Fixed format specifications
5978         for 64-bit Cygwin.
5979
5980 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5981
5982         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
5983
5984 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
5985
5986         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
5987         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
5988         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
5989         (nios2_linux_init_abi): Install it.
5990
5991 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5992
5993         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
5994
5995 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5996
5997         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
5998
5999 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6000             Tom Tromey  <tromey@adacore.com>
6001
6002         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6003
6004 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6005
6006         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6007         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6008         method to compute the bounds of range types. Also print "[evaluated]"
6009         if the bounds' values come from a dynamic evaluation.
6010
6011 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6012
6013         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6014         whitespace when pretty printing is on.
6015
6016 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6017
6018         * ppc-linux-nat.c: Add include.
6019
6020 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6021
6022         * NEWS: Mention AArch64 Pointer Authentication.
6023
6024 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6025
6026         * arm-linux-nat.c: Add include.
6027
6028 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6029
6030         * source-cache.c (source_cache::get_source_lines): Re-read
6031         fullname after calling open_source_file.
6032
6033 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6034
6035         * NEWS: Mention TLS support for FreeBSD.
6036
6037 2019-03-25  Tom Tromey  <tromey@adacore.com>
6038
6039         * minsyms.c (BUNCH_SIZE): Update comment.
6040         (~minimal_symbol_reader): Remove old comment.
6041         (compact_minimal_symbols): Update comment.
6042         (minimal_symbol_reader::install): Remove old comment.  Update
6043         other comments.
6044
6045 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6046
6047         * s390-linux-nat.c: Add include.
6048
6049 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6050
6051         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6052         Call linux_get_hwcap.
6053         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6054         Likewise.
6055         (aarch64_linux_get_hwcap): Remove function.
6056         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6057         declaration.
6058         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6059         linux_get_hwcap.
6060         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6061         * linux-tdep.c (linux_get_hwcap): Add function.
6062         (linux_get_hwcap2): Likewise.
6063         * linux-tdep.h (linux_get_hwcap): Add declaration.
6064         (linux_get_hwcap2): Likewise.
6065         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6066         (ppc_linux_get_hwcap2): Likewise.
6067         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6068         linux_get_hwcap.
6069         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6070         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6071         (ppc_linux_nat_target::read_description): Likewise.
6072         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6073         * s390-linux-nat.c: Likewise.
6074         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6075
6076 2019-03-24  Tom Tromey  <tom@tromey.com>
6077
6078         * ada-lang.c (standard_lookup): Simplify initialization.
6079         (ada_lookup_symbol_nonlocal): Simplify return.
6080         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6081         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6082         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6083         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6084         initialization.
6085         * solib.c (solib_global_lookup): Simplify.
6086         * symtab.c (null_block_symbol): Remove.
6087         (symbol_cache_lookup): Simplify returns.
6088         (lookup_language_this): Simplify returns.
6089         (lookup_symbol_aux): Simplify return.
6090         (lookup_local_symbol): Simplify returns.
6091         (lookup_global_symbol_from_objfile): Simplify return.
6092         (lookup_symbol_in_objfile_symtabs)
6093         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6094         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6095         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6096         * cp-namespace.c (cp_lookup_bare_symbol)
6097         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6098         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6099         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6100         (cp_lookup_symbol_via_imports): Simplify initialization.
6101         (find_symbol_in_baseclass): Likewise.
6102         * symtab.h (null_block_symbol): Remove.
6103         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6104         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6105         (d_lookup_symbol_module): Likewise.
6106         (find_symbol_in_baseclass): Simplify initialization.
6107
6108 2019-03-24  Tom Tromey  <tom@tromey.com>
6109
6110         * expression.h: Don't include symtab.h.
6111         (struct block): Forward declare.
6112
6113 2019-03-24  Tom Tromey  <tom@tromey.com>
6114
6115         * c-exp.y (typebase): Remove casts.
6116         * gdbtypes.c (lookup_unsigned_typename, )
6117         (lookup_signed_typename): Remove cast.
6118         * eval.c (parse_to_comma_and_eval): Remove cast.
6119         * parse.c (write_dollar_variable): Remove cast.
6120         * block.h (struct block) <superblock>: Now const.
6121         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6122         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6123         (map_block): Make "block" const.
6124         * symfile.h (struct quick_symbol_functions)
6125         <map_matching_symbols>: Constify block argument to "callback".
6126         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6127         const.
6128         (find_pc_sect_compunit_symtab): Make "b" const.
6129         (find_symbol_at_address): Likewise.
6130         (search_symbols): Likewise.
6131         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6132         (dw2_debug_names_lookup_symbol): Likewise.
6133         (dw2_map_matching_symbols): Update.
6134         * p-valprint.c (pascal_val_print): Remove "block".
6135         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6136         (aux_add_nonlocal_symbols): Make "block" const.
6137         (resolve_subexp): Remove cast.
6138         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6139         const.
6140         (iterate_over_file_blocks): Likewise.
6141         * f-exp.y (%union) <bval>: Remove.
6142         * coffread.c (patch_opaque_types): Make "b" const.
6143         * spu-tdep.c (spu_catch_start): Make "block" const.
6144         * c-valprint.c (print_unpacked_pointer): Remove "block".
6145         * symmisc.c (dump_symtab_1): Make "b" const.
6146         (block_depth): Make "block" const.
6147         * d-exp.y (%union) <bval>: Remove.
6148         * cp-support.h (cp_lookup_rtti_type): Update.
6149         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6150         * psymtab.c (psym_lookup_symbol): Make "block" const.
6151         (maintenance_check_psymtabs): Make "b" const.
6152         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6153         (enumerate_locals, enumerate_args): Update.
6154         * python/py-symtab.c (stpy_global_block): Make "block" const.
6155         (stpy_static_block): Likewise.
6156         * inline-frame.c (block_starting_point_at): Make "new_block"
6157         const.
6158         * block.c (find_block_in_blockvector): Make return type const.
6159         (blockvector_for_pc_sect): Make "b" const.
6160         (find_block_in_blockvector): Make "b" const.
6161
6162 2019-03-23  Tom Tromey  <tom@tromey.com>
6163
6164         * varobj.c (varobj_create): Update.
6165         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6166         * printcmd.c (display_command, do_one_display): Don't reset
6167         innermost_block.
6168         * parser-defs.h (enum innermost_block_tracker_type): Move to
6169         expression.h.
6170         (innermost_block): Update comment.
6171         * parse.c (parse_exp_1): Add tracker_types parameter.
6172         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6173         tracker_types parameter.  Reset innermost_block.
6174         (parse_exp_in_context): Remove.
6175         (parse_expression_for_completion): Update.
6176         * objfiles.c (~objfile): Don't reset expression_context_block or
6177         innermost_block.
6178         * expression.h (enum innermost_block_tracker_type): Move from
6179         parser-defs.h.
6180         (parse_exp_1): Add tracker_types parameter.
6181         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6182         reset innermost_block.
6183
6184 2019-03-23  Tom Tromey  <tom@tromey.com>
6185
6186         * objfiles.h: Include bcache.h.
6187
6188 2019-03-23  Tom Tromey  <tom@tromey.com>
6189
6190         * linespec.c (get_current_search_block): Use
6191         scoped_restore_current_language.
6192         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6193
6194 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6195             Jiong Wang  <jiong.wang@arm.com>
6196
6197         * aarch64-linux-tdep.c
6198         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6199         section.
6200         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6201
6202 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6203             Jiong Wang  <jiong.wang@arm.com>
6204
6205         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6206         instructions.
6207         (aarch64_analyze_prologue_test): Add PACIASP test.
6208         (aarch64_prologue_prev_register): Unmask PC value.
6209
6210 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6211             Jiong Wang  <jiong.wang@arm.com>
6212
6213         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6214         (aarch64_dwarf2_prev_register): Unmask PC value.
6215         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6216         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6217         DW_CFA_AARCH64_negate_ra_state.
6218         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6219
6220 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6221             Jiong Wang  <jiong.wang@arm.com>
6222
6223         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6224         registers.
6225         (aarch64_pseudo_register_name): Likewise.
6226         (aarch64_pseudo_register_type): Likewise.
6227         (aarch64_pseudo_register_reggroup_p): Likewise.
6228         (aarch64_gdbarch_init): Add pauth registers.
6229         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6230         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6231         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6232         (struct gdbarch_tdep): Add regnum for ra_state.
6233
6234 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6235             Jiong Wang  <jiong.wang@arm.com>
6236
6237         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6238
6239 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6240             Jiong Wang  <jiong.wang@arm.com>
6241
6242         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6243         function.
6244         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6245         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6246         (aarch64_gdbarch_init): Add puth registers.
6247         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6248         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6249         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6250
6251 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6252             Jiong Wang  <jiong.wang@arm.com>
6253
6254         * aarch64-linux-nat.c
6255         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6256         * aarch64-linux-tdep.c
6257         (aarch64_linux_core_read_description): Likewise.
6258         (aarch64_linux_get_hwcap): New function.
6259         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6260         (aarch64_linux_get_hwcap): New declaration.
6261
6262 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6263             Jiong Wang  <jiong.wang@arm.com>
6264
6265         * aarch64-linux-nat.c
6266         (aarch64_linux_nat_target::read_description): Add pauth param.
6267         * aarch64-linux-tdep.c
6268         (aarch64_linux_core_read_description): Likewise.
6269         * aarch64-tdep.c (struct target_desc): Add in pauth.
6270         (aarch64_read_description): Add pauth param.
6271         (aarch64_gdbarch_init): Likewise.
6272         * aarch64-tdep.h (aarch64_read_description): Likewise.
6273         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6274         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6275         * features/Makefile: Add new files.
6276         * features/aarch64-pauth.c: New file.
6277         * features/aarch64-pauth.xml: New file.
6278
6279 2019-03-20  Tom Tromey  <tromey@adacore.com>
6280
6281         * infrun.c (handle_inferior_event): Rename from
6282         handle_inferior_event_1.  Create a scoped_value_mark.
6283         (handle_inferior_event): Remove.
6284
6285 2019-03-19  Tom Tromey  <tromey@adacore.com>
6286
6287         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6288         * infrun.h (print_stop_event): Add "displays" parameter.
6289         * infrun.c (print_stop_event): Add "displays" parameter.
6290
6291 2019-03-19  Pedro Alves  <palves@redhat.com>
6292
6293         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6294         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6295         to -1.  Fix TABs vs spaces.
6296         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6297         * tui/tui-out.h (tui_ui_out) Add intro comments.
6298         <m_line, m_start_of_line>: In-class initialize, and add describing
6299         comment.
6300
6301 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6302
6303         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6304         variable names.
6305         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6306
6307 2019-03-18  Pedro Alves  <palves@redhat.com>
6308             Eli Zaretskii <eliz@gnu.org>
6309
6310         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6311         m_line and m_start_of_line.
6312
6313 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6314
6315         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6316         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6317         it returns a newline.  This fixes a regression in TU mode, whereby
6318         the next line is output on the same screen line as the user input.
6319
6320 2019-03-18  Tom Tromey  <tromey@adacore.com>
6321
6322         * minsyms.c (minimal_symbol_reader::install): Remove call to
6323         obstack_blank.
6324
6325 2019-03-18  Pedro Alves  <palves@redhat.com>
6326
6327         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6328         New globals.
6329         (apply_style): New, factored out from ...
6330         (apply_ansi_escape): ... this.  Handle reverse video mode.
6331         (tui_set_reverse_mode): New function.
6332         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6333         * tui/tui-winsource.c (tui_show_source_line): Use
6334         tui_set_reverse_mode instead of setting A_STANDOUT.
6335         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6336         New setter methods.
6337
6338 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6339
6340         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6341         Handle tabs.
6342
6343 2019-03-18  Tom Tromey  <tromey@adacore.com>
6344
6345         * ada-lang.c (empty_array): Add "high" parameter.
6346         (ada_evaluate_subexp): Update.
6347
6348 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6349
6350         * unittests/string_view-selftests.c: Define
6351         _initialize_string_view_selftests unconditionally.
6352
6353 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6354
6355         PR gdb/24350
6356         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6357
6358 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6359
6360         PR gdb/24351
6361         * windows-nat.c (display_selector): Fix format specifiers.
6362
6363 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6364
6365         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6366         tui_refill_source_window instead of tui_refresh_win, to update the
6367         current execution line.  This fixes redisplay of the current line
6368         when stepping through the code with "next" or "step".
6369
6370 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6371
6372         * source-cache.c (source_cache::get_source_lines): Call
6373         find_source_lines to initialize s->nlines.  This fixes vertical
6374         scrolling of TUI source window when the DOWN arrow is pressed.
6375
6376 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6377
6378         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6379         linux-thread-db.c (_initialize_thread_db): Likewise.
6380
6381 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6382
6383         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6384         wclrtoeol in tui_show_source_line".  This reverts changes made in
6385         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6386
6387 2019-03-15  Tom Tromey  <tom@tromey.com>
6388
6389         * symtab.h (struct minimal_symbol): Derive from
6390         general_symbol_info.
6391         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6392         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6393         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6394         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6395         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6396         (MSYMBOL_SEARCH_NAME): Update.
6397         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6398         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6399         * minsyms.c (minimal_symbol_reader::record_full): Update.
6400
6401 2019-03-15  Tom Tromey  <tom@tromey.com>
6402
6403         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6404
6405 2019-03-15  Tom Tromey  <tom@tromey.com>
6406
6407         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6408         unique_xmalloc_ptr.
6409         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6410         Update.
6411         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6412         (build_minimal_symbol_hash_tables)
6413         (minimal_symbol_reader::install): Update.
6414
6415 2019-03-15  Tom Tromey  <tom@tromey.com>
6416
6417         * symtab.c (create_demangled_names_hash): Update.
6418         (symbol_set_names): Update.
6419         * objfiles.h (struct objfile_per_bfd_storage)
6420         <demangled_names_hash>: Now an htab_up.
6421         * objfiles.c (objfile_per_bfd_storage): Simplify.
6422
6423 2019-03-15  Tom Tromey  <tom@tromey.com>
6424
6425         * objfiles.h (struct objfile_per_bfd_storage): Declare
6426         destructor.
6427         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6428         New.
6429         (get_objfile_bfd_data): Use new.  Don't initialize
6430         language_of_main.
6431         (free_objfile_per_bfd_storage): Remove.
6432         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6433
6434 2019-03-15  Tom Tromey  <tom@tromey.com>
6435
6436         * symfile.c (reread_symbols): Update.
6437         * objfiles.c (objfile::objfile): Update.
6438         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6439         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6440         comment.
6441         (minimal_symbol_reader::install): Update.
6442         (terminate_minimal_symbol_table): Remove.
6443         * jit.c (jit_object_close_impl): Update.
6444
6445 2019-03-15  Tom Tromey  <tom@tromey.com>
6446
6447         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6448         initializations.
6449
6450 2019-03-15  Tom Tromey  <tom@tromey.com>
6451
6452         * objfiles.h (struct objfile_per_bfd_storage)
6453         <demangled_hash_languages>: Now a bitset.
6454         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6455         (lookup_minimal_symbol): Update.
6456
6457 2019-03-15  Tom Tromey  <tom@tromey.com>
6458
6459         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6460         Don't return the symbol.
6461         * coffread.c (record_minimal_symbol): Use record_full.
6462
6463 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6464
6465         The MS-Windows port of ncurses fails to switch to a color pair if
6466         one or both of the colors are the implicit default colors.  This
6467         change records the default colors when TUI is initialized, and
6468         then specifies them explicitly when a color pair uses the default
6469         colors.  This allows color styling in TUI mode on MS-Windows.
6470
6471         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6472         ncurses_norm_attr.
6473         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6474         colors in ncurses_norm_attr.
6475         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6476         "none", replace it with the default color recorded in
6477         ncurses_norm_attr.
6478
6479 2019-03-14  Tom Tromey  <tromey@adacore.com>
6480
6481         * source-cache.h (class source_cache) <get_source_lines>: Return
6482         std::string.
6483         * source-cache.c (source_cache::extract_lines): Handle case where
6484         first_pos==npos.  Return std::string.
6485         (source_cache::get_source_lines): Update.
6486
6487 2019-03-14  Tom Tromey  <tromey@adacore.com>
6488
6489         * NEWS: Add item for "style sources" commands.
6490         * source-cache.c (source_cache::get_source_lines): Check
6491         source_styling.
6492         * cli/cli-style.c (source_styling): New global.
6493         (_initialize_cli_style): Add "style sources" commands.
6494         (show_style_sources): New function.
6495         * cli/cli-style.h (source_styling): Declare.
6496
6497 2019-03-14  Pedro Alves  <palves@redhat.com>
6498             Tom Tromey  <tromey@adacore.com>
6499
6500         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6501         * tui/tui-winsource.c (tui_refill_source_window): New function,
6502         from...
6503         (tui_horizontal_source_scroll): ... here.  Move some logic.
6504         * cli/cli-style.c (set_style_enabled): Notify new observable.
6505         * tui/tui-hooks.c (tui_redisplay_source): New function.
6506         (tui_attach_detach_observers): Attach or detach
6507         tui_redisplay_source.
6508         * observable.h (source_styling_changed): New observable.
6509         * observable.c: Define source_styling_changed observable.
6510
6511 2019-03-13  Tom Tromey  <tromey@adacore.com>
6512
6513         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6514         (i386_gnu_nat_target::store_registers): Update.
6515         * target-debug.h (target_debug_print_std_string): New macro.
6516         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6517         * windows-tdep.c (display_one_tib): Update.
6518         * tui/tui-stack.c (tui_make_status_line): Update.
6519         * top.c (print_inferior_quit_action): Update.
6520         * thread.c (thr_try_catch_cmd): Update.
6521         (add_thread_with_info): Update.
6522         (thread_target_id_str): Update.
6523         (thr_try_catch_cmd): Update.
6524         (thread_command): Update.
6525         (thread_find_command): Update.
6526         * record-btrace.c (record_btrace_target::info_record)
6527         (record_btrace_resume_thread, record_btrace_target::resume)
6528         (record_btrace_cancel_resume, record_btrace_step_thread)
6529         (record_btrace_target::wait, record_btrace_target::wait)
6530         (record_btrace_target::wait, record_btrace_target::stop): Update.
6531         * progspace.c (print_program_space): Update.
6532         * process-stratum-target.c
6533         (process_stratum_target::thread_address_space): Update.
6534         * linux-fork.c (linux_fork_mourn_inferior)
6535         (detach_checkpoint_command, info_checkpoints_command)
6536         (linux_fork_context): Update.
6537         (linux_fork_detach): Update.
6538         (class scoped_switch_fork_info): Update.
6539         (delete_checkpoint_command): Update.
6540         * infrun.c (follow_fork_inferior): Update.
6541         (follow_fork_inferior): Update.
6542         (proceed_after_vfork_done): Update.
6543         (handle_vfork_child_exec_or_exit): Update.
6544         (follow_exec): Update.
6545         (displaced_step_prepare_throw): Update.
6546         (displaced_step_restore): Update.
6547         (start_step_over): Update.
6548         (resume_1): Update.
6549         (clear_proceed_status_thread): Update.
6550         (proceed): Update.
6551         (print_target_wait_results): Update.
6552         (do_target_wait): Update.
6553         (context_switch): Update.
6554         (stop_all_threads): Update.
6555         (restart_threads): Update.
6556         (finish_step_over): Update.
6557         (handle_signal_stop): Update.
6558         (switch_back_to_stepped_thread): Update.
6559         (keep_going_pass_signal): Update.
6560         (print_exited_reason): Update.
6561         (normal_stop): Update.
6562         * inferior.c (inferior_pid_to_str): Change return type.
6563         (print_selected_inferior): Update.
6564         (add_inferior): Update.
6565         (detach_inferior): Update.
6566         * dummy-frame.c (fprint_dummy_frames): Update.
6567         * dcache.c (dcache_info_1): Update.
6568         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6569         (btrace_fetch, btrace_clear): Update.
6570         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6571         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6572         type.
6573         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6574         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6575         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6576         * gdbarch.c, gdbarch.h: Rebuild.
6577         * gdbarch.sh (core_pid_to_str): Change return type.
6578         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6579         return type.
6580         (windows_nat_target::pid_to_str): Change return type.
6581         (windows_delete_thread): Update.
6582         (windows_nat_target::attach): Update.
6583         (windows_nat_target::files_info): Update.
6584         * target-delegates.c: Rebuild.
6585         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6586         return type.
6587         (sol_thread_target::pid_to_str): Change return type.
6588         * remote.c (class remote_target) <pid_to_str>: Change return
6589         type.
6590         (remote_target::pid_to_str): Change return type.
6591         (extended_remote_target::attach, remote_target::remote_stop_ns)
6592         (remote_target::remote_notif_remove_queued_reply)
6593         (remote_target::push_stop_reply, remote_target::disable_btrace):
6594         Update.
6595         (extended_remote_target::attach): Update.
6596         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6597         type.
6598         (gdbsim_target::pid_to_str): Change return type.
6599         * ravenscar-thread.c (struct ravenscar_thread_target)
6600         <pid_to_str>: Change return type.
6601         (ravenscar_thread_target::pid_to_str): Change return type.
6602         * procfs.c (class procfs_target) <pid_to_str>: Change return
6603         type.
6604         (procfs_target::pid_to_str): Change return type.
6605         (procfs_target::attach): Update.
6606         (procfs_target::detach): Update.
6607         (procfs_target::fetch_registers): Update.
6608         (procfs_target::store_registers): Update.
6609         (procfs_target::wait): Update.
6610         (procfs_target::files_info): Update.
6611         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6612         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6613         return type.
6614         (nto_procfs_target::pid_to_str): Change return type.
6615         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6616         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6617         return type.
6618         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6619         (exit_lwp): Update.
6620         (attach_proc_task_lwp_callback, get_detach_signal)
6621         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6622         (linux_nat_target::resume, wait_lwp, stop_callback)
6623         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6624         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6625         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6626         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6627         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6628         type.
6629         (inf_ptrace_target::attach): Update.
6630         (inf_ptrace_target::files_info): Update.
6631         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6632         type.
6633         (go32_nat_target::pid_to_str): Change return type.
6634         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6635         (gnu_nat_target::wait): Update.
6636         (gnu_nat_target::wait): Update.
6637         (gnu_nat_target::resume): Update.
6638         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6639         (fbsd_nat_target::wait): Update.
6640         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6641         type.
6642         (darwin_nat_target::attach): Update.
6643         * corelow.c (class core_target) <pid_to_str>: Change return type.
6644         (core_target::pid_to_str): Change return type.
6645         * target.c (normal_pid_to_str): Change return type.
6646         (default_pid_to_str): Likewise.
6647         (target_pid_to_str): Change return type.
6648         (target_translate_tls_address): Update.
6649         (target_announce_detach): Update.
6650         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6651         return type.
6652         (bsd_uthread_target::pid_to_str): Change return type.
6653         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6654         type.
6655         (bsd_kvm_target::pid_to_str): Change return type.
6656         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6657         return type.
6658         (aix_thread_target::pid_to_str): Change return type.
6659         * target.h (struct target_ops) <pid_to_str>: Change return type.
6660         (target_pid_to_str, normal_pid_to_str): Likewise.
6661         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6662         type.
6663         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6664         type.
6665         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6666         return type.
6667         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6668         type.
6669         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6670         type.
6671         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6672         return type.
6673
6674 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6675
6676         * NEWS: Mention that the new default MI version is 3.  Mention
6677         changes to the output of commands and events that deal with
6678         multi-location breakpoints.
6679         * breakpoint.c: Include "mi/mi-out.h".
6680         (print_one_breakpoint): Change output syntax if using MI version
6681         >= 3.
6682         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6683         New.
6684         (mi_multi_location_breakpoint_output_fixed): New.
6685         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6686         (mi_cmd_fix_multi_location_breakpoint_output): New.
6687         (mi_multi_location_breakpoint_output_fixed): New.
6688         * mi/mi-cmds.c (mi_cmds): Register command
6689         -fix-multi-location-breakpoint-output.
6690         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6691         interpreter "mi".
6692
6693 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6694
6695         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6696         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6697         instantiate mi_ui_out based on interpreter name.
6698         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6699         * mi/mi-main.c (mi_load_progress): Likewise.
6700
6701 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6702
6703         * NEWS: Combine separate "New targets" sections for 8.3.
6704
6705 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6706
6707         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6708         (ppcfbsd_init_abi): Install gdbarch
6709         "fetch_tls_load_module_address" and "get_thread_local_address"
6710         methods.
6711
6712 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6713
6714         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6715         (riscv_fbsd_init_abi): Install gdbarch
6716         "fetch_tls_load_module_address" and "get_thread_local_address"
6717         methods.
6718
6719 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6720
6721         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6722         (i386fbsd_init_abi): Install gdbarch
6723         "fetch_tls_load_module_address" and "get_thread_local_address"
6724         methods.
6725
6726 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6727
6728         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6729         (amd64fbsd_init_abi): Install gdbarch
6730         "fetch_tls_load_module_address" and "get_thread_local_address"
6731         methods.
6732
6733 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6734
6735         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6736         (struct fbsd_pspace_data): New type.
6737         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6738         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6739         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6740         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6741         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6742
6743 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6744
6745         * gdbtypes.c (lookup_struct_elt): New function.
6746         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6747         * gdbtypes.h (struct struct_elt): New type.
6748         (lookup_struct_elt): New prototype.
6749
6750 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6751
6752         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6753         remove disabled code block.
6754
6755 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6756
6757         * gdbarch.sh (get_thread_local_address): New method.
6758         * gdbarch.h, gdbarch.c: Regenerate.
6759         * target.c (target_translate_tls_address): Use
6760         gdbarch_get_thread_local_address if present instead of
6761         target::get_thread_local_address.
6762
6763 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6764
6765         * target.h (target::get_thread_local_address): Update comment.
6766
6767 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6768
6769         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6770         objfile->separate_debug_objfile_backlink if not NULL.
6771
6772 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6773
6774         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6775         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6776         (amd64bsd_store_inferior_registers): Likewise.
6777         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6778         Enable segment base registers.
6779         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6780         PT_GETFSBASE and PT_GETGSBASE.
6781         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6782         PT_SETGSBASE.
6783         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6784         segment base registers.
6785         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6786
6787 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6788
6789         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6790         Update calls to i386_target_description to add 'segments'
6791         parameter.
6792         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6793         add segment base registers.
6794         * arch/i386.c (i386_create_target_description): Add 'segments'
6795         parameter to enable segment base registers.
6796         * arch/i386.h (i386_create_target_description): Likewise.
6797         * features/i386/32bit-segments.xml: New file.
6798         * features/i386/32bit-segments.c: Generate.
6799         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6800         call to i386_target_description to add 'segments' parameter.
6801         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6802         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6803         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6804         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6805         if feature is present.
6806         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6807         Add 'segments' parameter to call to i386_target_description.
6808         (i386_target_description): Add 'segments' parameter to enable
6809         segment base registers.
6810         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6811         to call to i386_target_description.
6812         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6813         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6814         Define I386_NUM_REGS.
6815         (i386_target_description): Add 'segments' parameter to enable
6816         segment base registers.
6817
6818 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6819
6820         PR/24325
6821         * source-cache.c: #undef open and close, to avoid unresolved
6822         externals during linking.
6823
6824 2019-03-12  Tom Tromey  <tromey@adacore.com>
6825
6826         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6827         const.  Add initializers.
6828         (_initialize_remote): Don't initialize ptid globals.
6829
6830 2019-03-12  Pedro Alves  <palves@redhat.com>
6831
6832         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6833
6834 2019-03-12  Pedro Alves  <palves@redhat.com>
6835
6836         * cp-name-parser.y (main): Remove unused 'len' variable.
6837
6838 2019-03-12  Tom Tromey  <tromey@adacore.com>
6839
6840         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6841         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6842
6843 2019-03-12  Tom Tromey  <tromey@adacore.com>
6844
6845         * linux-nat.c (iterate_over_lwps): Update.
6846         (stop_callback): Remove parameter.
6847         (stop_wait_callback, detach_callback, resume_set_callback)
6848         (select_singlestep_lwp_callback, set_ignore_sigint)
6849         (status_callback, resumed_callback, resume_clear_callback)
6850         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6851         data parameter.
6852         (linux_nat_target::detach, linux_nat_target::resume)
6853         (linux_stop_and_wait_all_lwps, select_event_lwp)
6854         (linux_nat_filter_event, linux_nat_wait_1)
6855         (linux_nat_target::kill, linux_nat_target::stop)
6856         (linux_nat_target::stop): Update.
6857         (linux_nat_resume_callback): Change type.
6858         (resume_stopped_resumed_lwps, count_events_callback)
6859         (select_event_lwp_callback): Likewise.
6860         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6861         * arm-linux-nat.c (struct update_registers_data): Remove.
6862         (update_registers_callback): Change type.
6863         (arm_linux_insert_hw_breakpoint1): Update.
6864         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6865         parameter.
6866         (x86_linux_dr_set_addr): Update.
6867         (x86_linux_dr_set_control): Update.
6868         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6869         (iterate_over_lwps): Use gdb::function_view.
6870         * nat/aarch64-linux-hw-point.c (struct
6871         aarch64_dr_update_callback_param): Remove.
6872         (debug_reg_change_callback): Change type.
6873         (aarch64_notify_debug_reg_change): Update.
6874         * s390-linux-nat.c (s390_refresh_per_info): Update.
6875
6876 2019-03-11  Tom Tromey  <tromey@adacore.com>
6877
6878         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6879         redundant assignment to "this_cu".
6880
6881 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6882
6883         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6884
6885 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6886
6887         * gdbtypes.c (rank_one_type_parm_set): New function extracted
6888         from...
6889         (rank_one_type): ... this.
6890
6891 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6892
6893         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6894         from...
6895         (rank_one_type): ... this.
6896
6897 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6898
6899         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6900         from...
6901         (rank_one_type): ... this.
6902
6903 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6904
6905         * gdbtypes.c (rank_one_type_parm_float): New function extracted
6906         from...
6907         (rank_one_type): ... this.
6908
6909 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6910
6911         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6912         from...
6913         (rank_one_type): ... this.
6914
6915 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6916
6917         * gdbtypes.c (rank_one_type_parm_range): New function extracted
6918         from...
6919         (rank_one_type): ... this.
6920
6921 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6922
6923         * gdbtypes.c (rank_one_type_parm_char): New function extracted
6924         from...
6925         (rank_one_type): ... this.
6926
6927 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6928
6929         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
6930         from...
6931         (rank_one_type): ... this.
6932
6933 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6934
6935         * gdbtypes.c (rank_one_type_parm_int): New function extracted
6936         from...
6937         (rank_one_type): ... this.
6938
6939 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6940
6941         * gdbtypes.c (rank_one_type_parm_func): New function extracted
6942         from...
6943         (rank_one_type): ... this.
6944
6945 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6946
6947         * gdbtypes.c (rank_one_type_parm_array): New function extracted
6948         from...
6949         (rank_one_type): ... this.
6950
6951 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6952
6953         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
6954         from...
6955         (rank_one_type): ... this.
6956
6957 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6958
6959         * inferior.c (initialize_inferiors): Ensure 'help set/show print
6960         inferior-events' shows the example events.
6961
6962 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
6963
6964         Support styling on native MS-Windows console
6965
6966         PR/24315
6967         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
6968         on MS-Windows if $TERM is not defined.
6969
6970         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
6971
6972         * posix-hdep.c (gdb_console_fputs):
6973         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
6974         functions.
6975         * ui-file.h (gdb_console_fputs): Add prototype.
6976
6977         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
6978         back to fputs only if the former returns zero.
6979
6980 2019-03-07  Tom Tromey  <tom@tromey.com>
6981
6982         * symmisc.c (print_symbol_bcache_statistics): Update.
6983         (print_objfile_statistics): Update.
6984         * symfile.c (allocate_symtab): Update.
6985         * stabsread.c: Don't include bcache.h.
6986         * psymtab.h (struct psymbol_bcache): Don't declare.
6987         (class psymtab_storage) <psymbol_cache>: Now a bcache.
6988         (psymbol_bcache_init, psymbol_bcache_free)
6989         (psymbol_bcache_get_bcache): Don't declare.
6990         * psymtab.c (struct psymbol_bcache): Remove.
6991         (psymtab_storage::psymtab_storage): Update.
6992         (psymtab_storage::~psymtab_storage): Update.
6993         (psymbol_bcache_init, psymbol_bcache_free)
6994         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
6995         (add_psymbol_to_bcache): Update.
6996         (allocate_psymtab): Update.
6997         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6998         macro_cache>: No longer pointers.
6999         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7000         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7001         * macrotab.c (macro_bcache): Update.
7002         * macroexp.c: Don't include bcache.h.
7003         * gdbtypes.c (check_types_worklist): Update.
7004         (types_deeply_equal): Remove TRY/CATCH.  Update.
7005         * elfread.c (elf_symtab_read): Update.
7006         * dwarf2read.c: Don't include bcache.h.
7007         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7008         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7009         (print_bcache_statistics, bcache_memory_used): Don't declare.
7010         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7011         methods.  Rename all data members.
7012         * bcache.c (struct bcache): Move to bcache.h.
7013         (bcache::expand_hash_table): Rename from expand_hash_table.
7014         (bcache): Remove.
7015         (bcache::insert): Rename from bcache_full.
7016         (bcache::compare): Rename from bcache_compare.
7017         (bcache_xmalloc): Remove.
7018         (bcache::~bcache): Rename from bcache_xfree.
7019         (bcache::print_statistics): Rename from print_bcache_statistics.
7020         (bcache::memory_used): Rename from bcache_memory_used.
7021
7022 2019-03-07  Pedro Alves  <palves@redhat.com>
7023
7024         * infrun.c (normal_stop): Also check for
7025         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7026
7027 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7028
7029         * f-lang.c (value_from_host_double): Moved to...
7030         * value.c (value_from_host_double): ...here.
7031         * value.h (value_from_host_double): Declare.
7032         * guile/scm-math.c (vlscm_convert_typed_number): Use
7033         value_from_host_double.
7034         (vlscm_convert_number): Likewise.
7035         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7036         * python/py-value.c (convert_value_from_python): Likewise.
7037
7038 2019-03-06  Tom Tromey  <tom@tromey.com>
7039
7040         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7041
7042 2019-03-06  Tom Tromey  <tom@tromey.com>
7043
7044         * utils.h (free_current_contents): Don't declare.
7045         * utils.c (free_current_contents): Remove.
7046
7047 2019-03-06  Tom Tromey  <tom@tromey.com>
7048
7049         * top.c (quit_force): Update.
7050         * main.c (captured_command_loop): Update.
7051         * common/new-op.c (operator new): Update.
7052         * common/common-exceptions.c (struct catcher)
7053         <save_cleanup_chain>: Remove member.
7054         (exceptions_state_mc_init): Update.
7055         (exception_try_scope_entry): Return nullptr.
7056         (exception_try_scope_exit, exception_rethrow)
7057         (throw_exception_sjlj, throw_exception_cxx): Update.
7058         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7059         (all_cleanups, do_cleanups, discard_cleanups)
7060         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7061         (restore_cleanups, restore_final_cleanups): Don't declare.
7062         (do_final_cleanups): Remove parameter.
7063         * common/cleanups.c (cleanup_chain, make_cleanup)
7064         (make_cleanup_dtor, all_cleanups, do_cleanups)
7065         (discard_my_cleanups, discard_cleanups)
7066         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7067         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7068         (null_cleanup): Remove.
7069         (do_final_cleanups): Remove parameter.
7070
7071 2019-03-06  Tom Tromey  <tom@tromey.com>
7072
7073         * remote.c (remote_target::remote_parse_stop_reply): Use
7074         unique_xmalloc_ptr.
7075
7076 2019-03-06  Tom Tromey  <tom@tromey.com>
7077
7078         * stabsread.c (struct stabs_field_info): Rename from field_info.
7079         <list, fnlist>: Add initializers.
7080         <obstack>: New member.
7081         (read_member_functions, read_struct_fields, read_baseclasses):
7082         Allocate on obstack.  Don't use cleanups.
7083         (read_one_struct_field, read_member_functions, read_struct_fields)
7084         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7085         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7086         (read_struct_type): Update.
7087
7088 2019-03-06  Tom Tromey  <tom@tromey.com>
7089
7090         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7091         * common/filestuff.h (make_cleanup_close): Don't declare.
7092         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7093         Remove.
7094
7095 2019-03-06  Tom Tromey  <tom@tromey.com>
7096
7097         * solib-aix.c: Use make_scope_exit.
7098
7099 2019-03-06  Tom Tromey  <tom@tromey.com>
7100
7101         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7102         Use make_scope_exit.
7103
7104 2019-03-06  Tom Tromey  <tom@tromey.com>
7105
7106         * solib-svr4.c (disable_probes_interface): Remove parameter.
7107         (svr4_handle_solib_event): Use make_scope_exit.
7108
7109 2019-03-06  Tom Tromey  <tom@tromey.com>
7110
7111         * remote.c (struct stop_reply_deleter): Remove.
7112         (stop_reply_up): Update.
7113         (struct stop_reply): Derive from notif_event.  Don't typedef.
7114         <regcache>: Now a std::vector.
7115         (stop_reply_xfree): Remove.
7116         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7117         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7118         (remote_target::discard_pending_stop_replies): Use delete.
7119         (remote_target::remote_parse_stop_reply): Update.
7120         (remote_target::process_stop_reply): Update.
7121         * remote-notif.h (struct notif_event): Add virtual destructor.
7122         Remove "dtr" member.
7123         (struct notif_client) <alloc_event>: Return a unique_ptr.
7124         (notif_event_xfree): Don't declare.
7125         (notif_event_up): New typedef.
7126         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7127         (notif_event_xfree, do_notif_event_xfree): Remove.
7128         (remote_notif_state_xfree): Update.
7129
7130 2019-03-06  Tom Tromey  <tom@tromey.com>
7131
7132         * infrun.c (displaced_step_clear_cleanup): Now a
7133         forward_scope_exit type.
7134         (displaced_step_prepare_throw): Update.
7135         (displaced_step_fixup): Update.
7136
7137 2019-03-06  Tom Tromey  <tom@tromey.com>
7138
7139         * inferior.h (class inferior): Update comment.
7140         * gdbthread.h (class thread_info): Update comment.
7141
7142 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7143             Tom Tromey  <tom@tromey.com>
7144
7145         * stabsread.h (struct stab_section_list): Remove.
7146         (coffstab_build_psymtabs): Update.
7147         * dbxread.c (symbuf_sections): Now a std::vector.
7148         (sect_idx): New global.
7149         (fill_symbuf): Update.
7150         (coffstab_build_psymtabs): Change type of stabsects parameter.
7151         Update.
7152         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7153         std::vector.
7154         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7155         (coff_locate_sections): Update.
7156         (coff_symfile_read): Remove cleanups.  Update.
7157         (init_stringtab): Add storage parameter.
7158         (free_stringtab, free_stringtab_cleanup): Remove.
7159         (init_lineno): Add storage parameter.
7160         (free_linetab, free_linetab_cleanup): Remove.
7161
7162 2019-03-06  Pedro Alves  <palves@redhat.com>
7163
7164         * linux-fork.c (fork_info::clobber_regs): Delete.
7165         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7166         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7167         comment.  Adjust.
7168         (scoped_switch_fork_info::scoped_switch_fork_info)
7169         (checkpoint_command, linux_fork_context): Adjust
7170         fork_save_infrun_state calls.
7171
7172 2019-03-06  Pedro Alves  <palves@redhat.com>
7173
7174         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7175         (inf_has_multiple_threads): Return 'bool' and rewrite using
7176         inferior_info::threads().
7177
7178 2019-03-06  Pedro Alves  <palves@redhat.com>
7179
7180         * linux-fork.c: Include <list>.
7181         (fork_list): Now a std::list instance.
7182         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7183         (forks_exist_p, find_last_fork): Adjust.
7184         (new_fork): Delete.
7185         (one_fork_p): New.
7186         (add_fork): Adjust.
7187         (free_fork): Delete, folded into fork_info::~fork_info().
7188         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7189         Adjust.
7190         (init_fork_list): Delete.
7191         (linux_fork_killall, linux_fork_mourn_inferior)
7192         (linux_fork_detach, info_checkpoints_command): Adjust.
7193         (_initialize_linux_fork): No longer call init_fork_list.
7194
7195 2019-03-06  Pedro Alves  <palves@redhat.com>
7196
7197         * linux-fork.c (new_fork): New, split out of ...
7198         (add_fork): ... this.  Return void.  Move "first fork" special
7199         case from here, to ...
7200         (checkpoint_command): ... here.
7201         * linux-linux.h (add_fork): Return void.
7202
7203 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7204
7205         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7206
7207 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7208             Chris January  <chris.january@arm.com>
7209             David Lecomber  <david.lecomber@arm.com>
7210
7211         * f-exp.y: New token, UNOP_INTRINSIC.
7212         (exp): New pattern using UNOP_INTRINSIC token.
7213         (f77_keywords): Add 'abs' keyword.
7214         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7215         (value_from_host_double): New function.
7216         (evaluate_subexp_f): Support UNOP_ABS.
7217
7218 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7219
7220         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7221         types.
7222
7223 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7224
7225         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7226         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7227         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7228
7229 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7230
7231         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7232
7233 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7234             Chris January  <chris.january@arm.com>
7235
7236         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7237         * f-exp.y: Define 'KIND' token.
7238         (exp): New pattern for KIND expressions.
7239         (ptype): Handle types with a kind extension.
7240         (direct_abs_decl): Extend to spot kind extensions.
7241         (f77_keywords): Add 'kind' to the list.
7242         (push_kind_type): New function.
7243         (convert_to_kind_type): New function.
7244         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7245         * parse.c (operator_length_standard): Likewise.
7246         * parser-defs.h (enum type_pieces): Add tp_kind.
7247         * std-operator.def: Add UNOP_KIND.
7248
7249 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7250
7251         * f-exp.y (f_parse): Set yydebug.
7252
7253 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7254
7255         * f-lang.c (evaluate_subexp_f): New function.
7256         (exp_descriptor_f): New global.
7257         (f_language_defn): Use exp_descriptor_f instead of
7258         exp_descriptor_standard.
7259
7260 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7261
7262         * f-exp.y (struct token): Add comments.
7263         (dot_ops): Remove uppercase versions and the end marker.
7264         (f77_keywords): Likewise.
7265         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7266         entries in the dot_ops array are case insensitive, and use
7267         strncasecmp to compare strings.  Also some whitespace cleanup in
7268         this area.  Similar for the f77_keywords array, except entries in
7269         this list might be case sensitive.
7270
7271 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7272
7273         * f-exp.y (struct f77_boolean_val): Add comments.
7274         (boolean_values): Remove uppercase versions, and end marker.
7275         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7276         and use strncasecmp to achieve case insensitivity.  Additionally,
7277         perform whitespace cleanup around this code.
7278
7279 2019-03-06  Tom Tromey  <tromey@adacore.com>
7280
7281         * remote-sim.c (gdbsim_target_open): Use result of
7282         gdb_argv::release.
7283
7284 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7285         Dirk Schubert  <dirk.schubert@arm.com>
7286         Chris January  <chris.january@arm.com>
7287
7288         * eval.c (evaluate_subexp_standard): Call Fortran argument
7289         wrapping logic.
7290         * f-lang.c (struct value): A value which can be passed into a
7291         Fortran function call.
7292         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7293         where appropriate.
7294         (struct type): Value ready for a Fortran function call.
7295         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7296         is needed.
7297         * f-lang.h (fortran_argument_convert): Declaration.
7298         (fortran_preserve_arg_pointer): Declaration.
7299         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7300
7301 2019-03-05  Tom Tromey  <tromey@adacore.com>
7302
7303         * python/py-prettyprint.c (print_string_repr): Remove #if.
7304         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7305
7306 2019-03-05  Tom Tromey  <tromey@adacore.com>
7307
7308         * target.c (the_dummy_target): Move later.  Change type to
7309         "dummy_target".
7310         (initialize_targets): Don't initialize the_dummy_target.
7311
7312 2019-03-05  Tom Tromey  <tromey@adacore.com>
7313
7314         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7315         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7316
7317 2019-03-05  Tom Tromey  <tromey@adacore.com>
7318
7319         * windows-nat.c (windows_nat_target::attach)
7320         (windows_nat_target::detach): Don't call gdb_flush.
7321         * valprint.c (generic_val_print, val_print, val_print_string):
7322         Don't call gdb_flush.
7323         * utils.c (defaulted_query): Don't call gdb_flush.
7324         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7325         * target.c (target_announce_detach): Don't call gdb_flush.
7326         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7327         * remote.c (extended_remote_target::attach): Don't call
7328         gdb_flush.
7329         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7330         * printcmd.c (do_examine): Don't call gdb_flush.
7331         (info_display_command): Don't call gdb_flush.
7332         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7333         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7334         * memattr.c (info_mem_command): Don't call gdb_flush.
7335         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7336         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7337         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7338         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7339         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7340         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7341         (gnu_nat_target::detach): Don't call gdb_flush.
7342         * f-valprint.c (f_val_print): Don't call gdb_flush.
7343         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7344         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7345         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7346         gdb_flush.
7347         * c-valprint.c (c_val_print): Don't call gdb_flush.
7348         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7349
7350 2019-03-05  Tom Tromey  <tromey@adacore.com>
7351
7352         * varobj.c (update_dynamic_varobj_children): Update.
7353         (install_default_visualizer): Use reset, not release.
7354         * value.c (set_internalvar): Update.
7355         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7356         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7357         ATTRIBUTE_UNUSED_RESULT.
7358
7359 2019-03-05  Tom Tromey  <tromey@adacore.com>
7360
7361         * remote.c (class scoped_remote_fd) <release>: Add
7362         ATTRIBUTE_UNUSED_RESULT.
7363
7364 2019-03-05  Tom Tromey  <tromey@adacore.com>
7365
7366         * macroexp.c (struct macro_buffer) <release>: Add
7367         ATTRIBUTE_UNUSED_RESULT.
7368
7369 2019-03-05  Tom Tromey  <tromey@adacore.com>
7370
7371         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7372         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7373         ATTRIBUTE_UNUSED_RESULT.
7374
7375 2019-03-05  Tom Tromey  <tromey@adacore.com>
7376
7377         * common/scoped_fd.h (class scoped_fd) <release>: Add
7378         ATTRIBUTE_UNUSED_RESULT.
7379
7380 2019-03-05  Tom Tromey  <tromey@adacore.com>
7381
7382         * parser-defs.h (struct parser_state) <release>: Add
7383         ATTRIBUTE_UNUSED_RESULT.
7384
7385 2019-03-05  Tom Tromey  <tromey@adacore.com>
7386
7387         * utils.h (class gdb_argv) <release>: Add
7388         ATTRIBUTE_UNUSED_RESULT.
7389         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7390
7391 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7392
7393         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7394         for-loop range, to avoid compiler warnings.
7395
7396         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7397         avoid compiler warnings about unused variables.
7398
7399         * NEWS: Mention end of support for native debugging on MS-Windows
7400         before XP.
7401
7402         PR gdb/24292
7403         * common/netstuff.c:
7404         * gdbserver/gdbreplay.c
7405         * gdbserver/remote-utils.c:
7406         * ser-tcp.c:
7407         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7408         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7409         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7410         'getaddrinfo' and 'freeaddrinfo' were not available before
7411         Windows XP, and mingw.org's MinGW headers by default define
7412         _WIN32_WINNT to 0x500.
7413
7414 2019-03-01  Gary Benson <gbenson@redhat.com>
7415
7416         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7417
7418 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7419             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7420
7421         PR gdb/8527
7422         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7423         set_sigint_trap, clear_sigint_trap.
7424
7425 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7426
7427         * target.c (target_detach): Clear the regcache and the
7428         frame cache.
7429
7430 2019-02-27  Pedro Alves  <palves@redhat.com>
7431
7432         * utils.c (set_screen_size): When we cap the height/width sizes,
7433         tweak the corresponding command variable to show "unlimited":
7434
7435 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7436             Pedro Alves  <palves@redhat.com>
7437
7438         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7439         before calling rl_set_screen_size.
7440
7441 2019-02-27  Tom Tromey  <tromey@adacore.com>
7442
7443         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7444         define.
7445         * python/py-value.c: Remove Python 2.4 workaround.
7446         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7447         workaround.
7448         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7449         Python 2.4 workaround.
7450         * python/python-internal.h: Remove Python 2.4 comment.
7451         (Py_ssize_t): Don't define.
7452         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7453         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7454         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7455         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7456         * python/python.c (do_start_initialization): Remove Python 2.4
7457         workaround.
7458         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7459         (print_children): Remove Python 2.4 workaround.
7460         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7461         workaround.
7462         (CHARBUFFERPROC_NAME): Remove.
7463         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7464         Python 2.4 workaround.
7465
7466 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7467
7468         * NEWS: Note minimum Python version.
7469
7470 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7471
7472         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7473         code from these functions.  Remove corresponding ifdefs.  Use
7474         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7475         Remove gotos and target of gotos.
7476         (infpy_search_memory): Likewise.
7477
7478 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7479
7480         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7481         (hppa_gdbarch_init): Don't register deleted functions with
7482         gdbarch.
7483
7484 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7485
7486         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7487         (h8300_unwind_sp): Delete.
7488         (h8300_dummy_id): Delete.
7489         (h8300_gdbarch_init): Don't register deleted functions with
7490         gdbarch.
7491
7492 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7493
7494         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7495         (ft32_unwind_pc): Delete.
7496         (ft32_unwind_sp): Delete.
7497         (ft32_gdbarch_init): Don't register deleted functions with
7498         gdbarch.
7499
7500 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7501
7502         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7503         (frv_unwind_pc): Delete.
7504         (frv_unwind_sp): Delete.
7505         (frv_gdbarch_init): Don't register deleted functions with
7506         gdbarch.
7507
7508 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7509
7510         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7511         (riscv_unwind_pc): Delete.
7512         (riscv_unwind_sp): Delete.
7513         (riscv_gdbarch_init): Don't register deleted functions with
7514         gdbarch.
7515
7516 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7517
7518         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7519         (csky_unwind_pc): Delete.
7520         (csky_unwind_sp): Delete.
7521         (csky_gdbarch_init): Don't register deleted functions with
7522         gdbarch.
7523
7524 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7525
7526         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7527         (cris_unwind_pc): Delete.
7528         (cris_unwind_sp): Delete.
7529         (cris_gdbarch_init): Don't register deleted functions with
7530         gdbarch.
7531
7532 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7533
7534         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7535         (bfin_unwind_pc): Delete.
7536         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7537
7538 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7539
7540         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7541         (arm_unwind_pc): Delete.
7542         (arm_unwind_sp): Delete.
7543         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7544
7545 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7546
7547         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7548         (arc_unwind_pc): Delete.
7549         (arc_unwind_sp): Delete.
7550         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7551
7552 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7553
7554         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7555         (alpha_unwind_pc): Delete.
7556         (alpha_gdbarch_init): Don't register deleted functions with
7557         gdbarch.
7558
7559 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7560
7561         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7562         (aarch64_unwind_pc): Delete.
7563         (aarch64_unwind_sp): Delete.
7564         (aarch64_gdbarch_init): Don't register deleted functions with
7565         gdbarch.
7566
7567 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7568
7569         * gdbtypes.c (type_align): Don't consider static members when
7570         computing structure alignment.
7571
7572 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7573
7574         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7575         return 0 for other types.
7576         * arch-utils.c (default_type_align): Always return 0.
7577         * gdbarch.h: Regenerate.
7578         * gdbarch.sh (type_align): Extend comment.
7579         * gdbtypes.c (type_align): Add additional comments, always call
7580         gdbarch_type_align before applying the default rules.
7581         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7582         generic code will then apply a suitable default.
7583         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7584         types, return 0 for other types.
7585
7586 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7587
7588         * NEWS: Create a new section for the next release branch.
7589         Rename the section of the current branch, now that it has
7590         been cut.
7591
7592 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7593
7594         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7595         * version.in: Bump version to 8.3.50.DATE-git.
7596
7597 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7598
7599         * aix-thread.c (ptid_cmp): Remove unused variable.
7600         (get_signaled_thread): Likewise.
7601         (store_regs_user_thread): Likewise.
7602         (store_regs_kernel_thread): Likewise.
7603         (fetch_regs_kernel_thread): Remove shadowed variable.
7604
7605 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7606
7607         * features/riscv/32bit-cpu.xml: Add register numbers.
7608         * features/riscv/32bit-fpu.c: Regenerate.
7609         * features/riscv/32bit-fpu.xml: Add register numbers.
7610         * features/riscv/64bit-cpu.xml: Add register numbers.
7611         * features/riscv/64bit-fpu.c: Regenerate.
7612         * features/riscv/64bit-fpu.xml: Add register numbers.
7613
7614 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7615
7616         * NEWS: Mention two argument form of gdb.Value constructor.
7617         * python/py-value.c (convert_buffer_and_type_to_value): New
7618         function.
7619         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7620         Add support for handling an optional second argument.  Call
7621         convert_buffer_and_type_to_value as appropriate.
7622         * python/python-internal.h (Py_buffer_deleter): New struct.
7623         (Py_buffer_up): New typedef.
7624
7625 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7626
7627         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7628         instead of releasing ownership.
7629
7630 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7631
7632         * dwarf2read.c (open_and_init_dwp_file): Call
7633         elf_numsections instead of bfd_count_sections to initialize
7634         dwp_file->num_sections.
7635
7636 2019-02-25  Tom Tromey  <tromey@adacore.com>
7637
7638         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7639
7640 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7641
7642         * gcore.in: Add '--readnever' option when invoking GDB.
7643
7644 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7645
7646         * MAINTAINERS: Update my email address.
7647
7648 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7649
7650         * build-id.c (build_id_to_debug_bfd_1): New function.
7651         (build_id_to_debug_bfd): Look for separate debug file in
7652         sysroot.
7653
7654 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7655
7656         * gdbarch.sh: Update the copyright year range that is placed into
7657         generated files.
7658
7659 2019-02-22  Keith Seitz  <keiths@redhat.com>
7660
7661         PR symtab/23853
7662         * linespec.c (create_sals_line_offset): Search for the default
7663         symtab's filename instead of its fullname.
7664
7665 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7666
7667         * NEWS: Update style defaults.
7668
7669 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7670
7671         * main.c (captured_main_1): Disable styling in batch mode.
7672
7673 2019-02-20  Tom Tromey  <tom@tromey.com>
7674
7675         * symtab.c (symtab_symbol_info): Fix typos.
7676
7677 2019-02-20  Tom Tromey  <tromey@adacore.com>
7678
7679         * findcmd.c (_initialize_mem_search): Use upper case for
7680         metasyntactic variables.
7681
7682 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7683
7684         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7685         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7686
7687 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7688
7689         * top.h (source_file_name): Change to std::string.
7690         * top.c (source_file_name): Likewise.
7691         (command_line_input): Adjust.
7692         * cli/cli-script.c (script_from_file): Adjust.
7693
7694 2019-02-19  Tom Tromey  <tromey@adacore.com>
7695
7696         * ravenscar-thread.c
7697         (ravenscar_thread_target::update_thread_list): Don't call
7698         ada_build_task_list.
7699         * ada-lang.h (ada_build_task_list): Don't declare.
7700         * ada-tasks.c (struct ada_tasks_inferior_data)
7701         <task_list_valid_p>: Now bool.
7702         (read_known_tasks, ada_task_list_changed)
7703         (ada_tasks_invalidate_inferior_data): Update.
7704         (read_known_tasks_array): Return bool.
7705         (read_known_tasks_list): Likewise.
7706         (read_known_tasks): Return void.
7707         (ada_build_task_list): Now static.
7708
7709 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7710
7711         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7712         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7713
7714 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7715
7716         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7717         variant for ada_tasks_pspace_data_handle and
7718         ada_tasks_inferior_data_handle.
7719         (ada_tasks_pspace_data_cleanup): New function.
7720         (ada_tasks_inferior_data_cleanup): New function.
7721
7722 2019-02-17  Tom Tromey  <tom@tromey.com>
7723
7724         * macrotab.h (macro_source_fullname): Return a std::string.
7725         * macrotab.c (macro_include, check_for_redefinition)
7726         (macro_undef, macro_lookup_definition, foreach_macro)
7727         (foreach_macro_in_scope): Update.
7728         (macro_source_fullname): Return a std::string.
7729         * macrocmd.c (show_pp_source_pos): Update.
7730
7731 2019-02-17  Tom Tromey  <tom@tromey.com>
7732
7733         * macrocmd.c (show_pp_source_pos): Style the file names.
7734
7735 2019-02-17  Tom Tromey  <tom@tromey.com>
7736
7737         PR tui/24197:
7738         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7739
7740 2019-02-17  Tom Tromey  <tom@tromey.com>
7741
7742         * ada-lang.c (user_select_syms): Use filtered printing.
7743         * utils.c (wrap_style): New global.
7744         (desired_style): Remove.
7745         (emit_style_escape): Add stream parameter.
7746         (set_output_style, reset_terminal_style, prompt_for_continue):
7747         Update.
7748         (flush_wrap_buffer): Only flush gdb_stdout.
7749         (wrap_here): Set wrap_style.
7750         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7751         treat escape sequences as a character.  Change when wrap buffer is
7752         flushed.
7753         (fputs_styled): Do not set the output style when the default is
7754         requested.
7755         * ui-style.h (struct ui_file_style) <is_default>: New method.
7756         * source.c (print_source_lines_base): Emit escape sequences in one
7757         piece.
7758
7759 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7760
7761         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7762         integers and enumeration types.
7763
7764 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7765
7766         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7767         instead of lookup_symbol_in_language
7768         (do_exact_match): New function.
7769         (ada_get_symbol_name_matcher): Return do_exact_match when
7770         doing a verbatim match.
7771
7772 2019-02-15  Tom Tromey  <tromey@adacore.com>
7773
7774         * ravenscar-thread.c (ravenscar_thread_target::resume)
7775         (ravenscar_thread_target::wait): Special case wildcard requests.
7776
7777 2019-02-15  Tom Tromey  <tromey@adacore.com>
7778
7779         * ravenscar-thread.c (base_ptid): Remove.
7780         (struct ravenscar_thread_target) <close>: New method.
7781         <m_base_ptid>: New member.
7782         <update_inferior_ptid, active_task, task_is_currently_active,
7783         runtime_initialized>: Declare methods.
7784         <ravenscar_thread_target>: Add constructor.
7785         (ravenscar_thread_target::task_is_currently_active)
7786         (ravenscar_thread_target::update_inferior_ptid)
7787         (ravenscar_runtime_initialized): Rename.  Now methods.
7788         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7789         (ravenscar_thread_target::update_thread_list): Update.
7790         (ravenscar_thread_target::active_task): Now method.
7791         (ravenscar_thread_target::store_registers)
7792         (ravenscar_thread_target::prepare_to_store)
7793         (ravenscar_thread_target::prepare_to_store)
7794         (ravenscar_thread_target::mourn_inferior): Update.
7795         (ravenscar_inferior_created): Use "new" to create target.
7796         (ravenscar_thread_target::get_ada_task_ptid): Update.
7797         (_initialize_ravenscar): Don't initialize base_ptid.
7798         (ravenscar_ops): Remove global.
7799
7800 2019-02-15  Tom Tromey  <tromey@adacore.com>
7801
7802         * target.h (push_target): Declare new overload.
7803         * target.c (push_target): New overload, taking an rvalue reference.
7804         * remote.c (remote_target::open_1): Use push_target overload.
7805         * corelow.c (core_target_open): Use push_target overload.
7806
7807 2019-02-15  Tom Tromey  <tromey@adacore.com>
7808
7809         * ravenscar-thread.c (is_ravenscar_task)
7810         (ravenscar_task_is_currently_active): Return bool.
7811         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7812         (_initialize_ravenscar): Remove "(void)".
7813         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7814         Return bool.
7815
7816 2019-02-15  Tom Tromey  <tromey@adacore.com>
7817
7818         * ravenscar-thread.c (ravenscar_runtime_initializer)
7819         (has_ravenscar_runtime, get_running_thread_id)
7820         (ravenscar_thread_target::resume): Fix indentation.
7821
7822 2019-02-15  Tom Tromey  <tromey@adacore.com>
7823
7824         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7825         from ravenscar_arch_ops.
7826         (sparc_ravenscar_ops::fetch_registers)
7827         (sparc_ravenscar_ops::store_registers): Now methods.
7828         (sparc_ravenscar_prepare_to_store): Remove.
7829         (sparc_ravenscar_ops): Redefine.
7830         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7831         methods and destructor.  Remove members.
7832         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7833         (ravenscar_thread_target::store_registers)
7834         (ravenscar_thread_target::prepare_to_store): Update.
7835         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7836         Remove.
7837         (struct ppc_ravenscar_powerpc_ops): Derive from
7838         ravenscar_arch_ops.
7839         (ppc_ravenscar_powerpc_ops::fetch_registers)
7840         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7841         (ppc_ravenscar_powerpc_ops): Redefine.
7842         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7843         (ppc_ravenscar_e500_ops::fetch_registers)
7844         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7845         (ppc_ravenscar_e500_ops): Redefine.
7846         * aarch64-ravenscar-thread.c
7847         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7848         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7849         (aarch64_ravenscar_fetch_registers)
7850         (aarch64_ravenscar_store_registers): Now methods.
7851         (aarch64_ravenscar_ops): Redefine.
7852
7853 2019-02-15  Tom Tromey  <tromey@adacore.com>
7854
7855         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7856         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7857         (ravenscar_thread_target::stopped_by_watchpoint)
7858         (ravenscar_thread_target::stopped_data_address)
7859         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7860
7861 2019-02-15  Tom Tromey  <tromey@adacore.com>
7862
7863         * ravenscar-thread.c: Fix some typos.
7864
7865 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7866             Tom Tromey  <tromey@adacore.com>
7867
7868         * ada-lang.c (ada_exception_sal): Change addr_string to a
7869         std::string.
7870         (create_ada_exception_catchpoint): Update.
7871
7872 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7873             Tom Tromey  <tromey@adacore.com>
7874
7875         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7876         (bp_location_ops): Remove.
7877         (base_breakpoint_allocate_location): Update.
7878         (free_bp_location): Update.
7879         * ada-lang.c (class ada_catchpoint_location)
7880         <ada_catchpoint_location>: Remove ops parameter.
7881         (ada_catchpoint_location_dtor): Remove.
7882         (ada_catchpoint_location_ops): Remove.
7883         (allocate_location_exception): Update.
7884         * breakpoint.h (struct bp_location_ops): Remove.
7885         (class bp_location) <bp_location>: Remove bp_location_ops
7886         parameter.
7887         <~bp_location>: Add destructor.
7888         <ops>: Remove.
7889
7890 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7891             Pedro Alves  <palves@redhat.com>
7892
7893         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7894         'PATH_MAX'.
7895
7896 2019-02-14  David Michael  <fedora.dm0@gmail.com>
7897             Samuel Thibault  <samuel.thibault@gnu.org>
7898             Thomas Schwinge  <thomas@codesourcery.com>
7899
7900         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7901         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
7902
7903 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7904
7905         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7906         (check_empty): Use "const char *".
7907
7908         * gnu-nat.c (gnu_nat_target::detach): Instead of
7909         'detach_inferior (pid)' call
7910         'detach_inferior (find_inferior_pid (pid))'.
7911
7912         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7913         'nat/fork-inferior.o'.
7914         * gnu-nat.c: #include "nat/fork-inferior.h".
7915
7916         * gnu-nat.c (gnu_nat_target::detach): Instead of
7917         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
7918         * gnu-nat.h: #include "inf-child.h".
7919         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
7920         'i386_gnu_nat_target::fetch_registers'.
7921         (gnu_store_registers): Rename/move to
7922         'i386_gnu_nat_target::store_registers'.
7923
7924         * config/i386/nm-i386gnu.h: Don't "#include" any files.
7925         * gnu-nat.h (mach_thread_info): New function.
7926         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
7927
7928         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
7929
7930 2019-02-14  Frederic Konrad  <konrad@adacore.com>
7931
7932         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
7933
7934 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
7935
7936         * windows-nat.c (windows_add_thread): Add new parameter
7937         "main_thread_p" with default value set to false.  Update
7938         function documentation as well as all callers.
7939         (windows_delete_thread): Likewise.
7940         (fake_create_process): Update call to windows_add_thread.
7941         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
7942         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
7943         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
7944         call to windows_delete_thread.
7945
7946 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
7947
7948         * MAINTAINERS: Add Andrew Burgess as global maintainer.
7949
7950 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7951
7952         * symfile.c (find_separate_debug_file): Use canonical path of
7953         sysroot with child_path instead of gdb_sysroot if it is valid.
7954
7955 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7956
7957         * symfile.c (find_separate_debug_file): Use child_path to
7958         determine if an object file is under a sysroot.
7959
7960 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7961
7962         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
7963         unittests/child-path-selftests.c.
7964         * common/pathstuff.c (child_path): New function.
7965         * common/pathstuff.h (child_path): New prototype.
7966         * unittests/child-path-selftests.c: New file.
7967
7968 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7969
7970         * symfile.c (find_separate_debug_file): Look for separate debug
7971         files in debug directories under the sysroot.
7972
7973 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7974
7975         * symtab.h (struct minimal_symbol data_p): New const method.
7976         (struct minimal_symbol text_p): Likewise.
7977         * symtab.c (output_source_filename): Use file name style
7978         to print file name.
7979         (print_symbol_info): Likewise.
7980         (print_msymbol_info): Use address style to print addresses.
7981         Use function name style to print executable text symbols.
7982         (expand_symtab_containing_pc): Use data_p.
7983         (find_pc_sect_compunit_symtab): Likewise.
7984
7985 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7986
7987         * breakpoint.c (describe_other_breakpoints): Use address style
7988         to print addresses.
7989         (say_where): Likewise.
7990
7991 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7992
7993         * ada-typeprint.c (print_func_type): Print function name
7994         style to print function name.
7995         * c-typeprint.c (c_print_type_1): Likewise.
7996
7997 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
7998
7999         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8000         for execve.
8001
8002 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8003
8004         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8005         type_stack.
8006
8007 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8008
8009         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8010         TYPE_CODE_REF types.
8011
8012 2019-02-08  Jim Wilson  <jimw@sifive.com>
8013
8014         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8015         (riscv_linux_fregset): New.
8016         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8017
8018 2019-02-07  Tom Tromey  <tom@tromey.com>
8019
8020         * thread.c (thread_cancel_execution_command): Update.
8021         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8022         methods.
8023         (struct thread_fsm_ops): Remove.
8024         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8025         (thread_fsm_should_stop, thread_fsm_return_value)
8026         (thread_fsm_set_finished, thread_fsm_finished_p)
8027         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8028         Don't declare.
8029         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8030         * infrun.c (clear_proceed_status_thread)
8031         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8032         (print_stop_event): Update.
8033         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8034         Add constructor.
8035         (step_command_fsm_ops): Remove.
8036         (new_step_command_fsm): Remove.
8037         (step_1): Update.
8038         (step_command_fsm::should_stop): Rename from
8039         step_command_fsm_should_stop.
8040         (step_command_fsm::clean_up): Rename from
8041         step_command_fsm_clean_up.
8042         (step_command_fsm::do_async_reply_reason): Rename from
8043         step_command_fsm_async_reply_reason.
8044         (struct until_next_fsm): Inherit from thread_fsm.  Add
8045         constructor.
8046         (until_next_fsm_ops): Remove.
8047         (new_until_next_fsm): Remove.
8048         (until_next_fsm::should_stop): Rename from
8049         until_next_fsm_should_stop.
8050         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8051         (until_next_fsm::do_async_reply_reason): Rename from
8052         until_next_fsm_async_reply_reason.
8053         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8054         constructor.  Change type of breakpoint.
8055         (finish_command_fsm_ops): Remove.
8056         (new_finish_command_fsm): Remove.
8057         (finish_command_fsm::should_stop): Rename from
8058         finish_command_fsm_should_stop.
8059         (finish_command_fsm::clean_up): Rename from
8060         finish_command_fsm_clean_up.
8061         (finish_command_fsm::return_value): Rename from
8062         finish_command_fsm_return_value.
8063         (finish_command_fsm::do_async_reply_reason): Rename from
8064         finish_command_fsm_async_reply_reason.
8065         (finish_command): Update.
8066         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8067         Add constructor.
8068         (call_thread_fsm_ops): Remove.
8069         (call_thread_fsm::call_thread_fsm): Rename from
8070         new_call_thread_fsm.
8071         (call_thread_fsm::should_stop): Rename from
8072         call_thread_fsm_should_stop.
8073         (call_thread_fsm::should_notify_stop): Rename from
8074         call_thread_fsm_should_notify_stop.
8075         (run_inferior_call, call_function_by_hand_dummy): Update.
8076         * cli/cli-interp.c (should_print_stop_to_console): Update.
8077         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8078         Add constructor.  Change type of location_breakpoint,
8079         caller_breakpoint.
8080         (until_break_fsm_ops): Remove.
8081         (new_until_break_fsm): Remove.
8082         (until_break_fsm::should_stop): Rename from
8083         until_break_fsm_should_stop.
8084         (until_break_fsm::clean_up): Rename from
8085         until_break_fsm_clean_up.
8086         (until_break_fsm::do_async_reply_reason): Rename from
8087         until_break_fsm_async_reply_reason.
8088         (until_break_command): Update.
8089         * thread-fsm.c: Remove.
8090         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8091
8092 2019-02-07  Tom Tromey  <tom@tromey.com>
8093
8094         * yy-remap.h: Add include guard.
8095         * xtensa-tdep.h: Add include guard.
8096         * xcoffread.h: Rename include guard.
8097         * varobj-iter.h: Add include guard.
8098         * tui/tui.h: Rename include guard.
8099         * tui/tui-winsource.h: Rename include guard.
8100         * tui/tui-wingeneral.h: Rename include guard.
8101         * tui/tui-windata.h: Rename include guard.
8102         * tui/tui-win.h: Rename include guard.
8103         * tui/tui-stack.h: Rename include guard.
8104         * tui/tui-source.h: Rename include guard.
8105         * tui/tui-regs.h: Rename include guard.
8106         * tui/tui-out.h: Rename include guard.
8107         * tui/tui-layout.h: Rename include guard.
8108         * tui/tui-io.h: Rename include guard.
8109         * tui/tui-hooks.h: Rename include guard.
8110         * tui/tui-file.h: Rename include guard.
8111         * tui/tui-disasm.h: Rename include guard.
8112         * tui/tui-data.h: Rename include guard.
8113         * tui/tui-command.h: Rename include guard.
8114         * tic6x-tdep.h: Add include guard.
8115         * target/waitstatus.h: Rename include guard.
8116         * target/wait.h: Rename include guard.
8117         * target/target.h: Rename include guard.
8118         * target/resume.h: Rename include guard.
8119         * target-float.h: Rename include guard.
8120         * stabsread.h: Add include guard.
8121         * rs6000-tdep.h: Add include guard.
8122         * riscv-fbsd-tdep.h: Add include guard.
8123         * regformats/regdef.h: Rename include guard.
8124         * record.h: Rename include guard.
8125         * python/python.h: Rename include guard.
8126         * python/python-internal.h: Rename include guard.
8127         * python/py-stopevent.h: Rename include guard.
8128         * python/py-ref.h: Rename include guard.
8129         * python/py-record.h: Rename include guard.
8130         * python/py-record-full.h: Rename include guard.
8131         * python/py-record-btrace.h: Rename include guard.
8132         * python/py-instruction.h: Rename include guard.
8133         * python/py-events.h: Rename include guard.
8134         * python/py-event.h: Rename include guard.
8135         * procfs.h: Add include guard.
8136         * proc-utils.h: Add include guard.
8137         * p-lang.h: Add include guard.
8138         * or1k-tdep.h: Rename include guard.
8139         * observable.h: Rename include guard.
8140         * nto-tdep.h: Rename include guard.
8141         * nat/x86-linux.h: Rename include guard.
8142         * nat/x86-linux-dregs.h: Rename include guard.
8143         * nat/x86-gcc-cpuid.h: Add include guard.
8144         * nat/x86-dregs.h: Rename include guard.
8145         * nat/x86-cpuid.h: Rename include guard.
8146         * nat/ppc-linux.h: Rename include guard.
8147         * nat/mips-linux-watch.h: Rename include guard.
8148         * nat/linux-waitpid.h: Rename include guard.
8149         * nat/linux-ptrace.h: Rename include guard.
8150         * nat/linux-procfs.h: Rename include guard.
8151         * nat/linux-osdata.h: Rename include guard.
8152         * nat/linux-nat.h: Rename include guard.
8153         * nat/linux-namespaces.h: Rename include guard.
8154         * nat/linux-btrace.h: Rename include guard.
8155         * nat/glibc_thread_db.h: Rename include guard.
8156         * nat/gdb_thread_db.h: Rename include guard.
8157         * nat/gdb_ptrace.h: Rename include guard.
8158         * nat/fork-inferior.h: Rename include guard.
8159         * nat/amd64-linux-siginfo.h: Rename include guard.
8160         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8161         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8162         * nat/aarch64-linux.h: Rename include guard.
8163         * nat/aarch64-linux-hw-point.h: Rename include guard.
8164         * mn10300-tdep.h: Add include guard.
8165         * mips-linux-tdep.h: Add include guard.
8166         * mi/mi-parse.h: Rename include guard.
8167         * mi/mi-out.h: Rename include guard.
8168         * mi/mi-main.h: Rename include guard.
8169         * mi/mi-interp.h: Rename include guard.
8170         * mi/mi-getopt.h: Rename include guard.
8171         * mi/mi-console.h: Rename include guard.
8172         * mi/mi-common.h: Rename include guard.
8173         * mi/mi-cmds.h: Rename include guard.
8174         * mi/mi-cmd-break.h: Rename include guard.
8175         * m2-lang.h: Add include guard.
8176         * location.h: Rename include guard.
8177         * linux-record.h: Rename include guard.
8178         * linux-nat.h: Add include guard.
8179         * linux-fork.h: Add include guard.
8180         * i386-darwin-tdep.h: Rename include guard.
8181         * hppa-linux-offsets.h: Add include guard.
8182         * guile/guile.h: Rename include guard.
8183         * guile/guile-internal.h: Rename include guard.
8184         * gnu-nat.h: Rename include guard.
8185         * gdb-stabs.h: Rename include guard.
8186         * frv-tdep.h: Add include guard.
8187         * f-lang.h: Add include guard.
8188         * event-loop.h: Add include guard.
8189         * darwin-nat.h: Rename include guard.
8190         * cp-abi.h: Rename include guard.
8191         * config/sparc/nm-sol2.h: Rename include guard.
8192         * config/nm-nto.h: Rename include guard.
8193         * config/nm-linux.h: Add include guard.
8194         * config/i386/nm-i386gnu.h: Rename include guard.
8195         * config/djgpp/nl_types.h: Rename include guard.
8196         * config/djgpp/langinfo.h: Rename include guard.
8197         * compile/gcc-cp-plugin.h: Add include guard.
8198         * compile/gcc-c-plugin.h: Add include guard.
8199         * compile/compile.h: Rename include guard.
8200         * compile/compile-object-run.h: Rename include guard.
8201         * compile/compile-object-load.h: Rename include guard.
8202         * compile/compile-internal.h: Rename include guard.
8203         * compile/compile-cplus.h: Rename include guard.
8204         * compile/compile-c.h: Rename include guard.
8205         * common/xml-utils.h: Rename include guard.
8206         * common/x86-xstate.h: Rename include guard.
8207         * common/version.h: Rename include guard.
8208         * common/vec.h: Rename include guard.
8209         * common/tdesc.h: Rename include guard.
8210         * common/selftest.h: Rename include guard.
8211         * common/scoped_restore.h: Rename include guard.
8212         * common/scoped_mmap.h: Rename include guard.
8213         * common/scoped_fd.h: Rename include guard.
8214         * common/safe-iterator.h: Rename include guard.
8215         * common/run-time-clock.h: Rename include guard.
8216         * common/refcounted-object.h: Rename include guard.
8217         * common/queue.h: Rename include guard.
8218         * common/ptid.h: Rename include guard.
8219         * common/print-utils.h: Rename include guard.
8220         * common/preprocessor.h: Rename include guard.
8221         * common/pathstuff.h: Rename include guard.
8222         * common/observable.h: Rename include guard.
8223         * common/netstuff.h: Rename include guard.
8224         * common/job-control.h: Rename include guard.
8225         * common/host-defs.h: Rename include guard.
8226         * common/gdb_wait.h: Rename include guard.
8227         * common/gdb_vecs.h: Rename include guard.
8228         * common/gdb_unlinker.h: Rename include guard.
8229         * common/gdb_unique_ptr.h: Rename include guard.
8230         * common/gdb_tilde_expand.h: Rename include guard.
8231         * common/gdb_sys_time.h: Rename include guard.
8232         * common/gdb_string_view.h: Rename include guard.
8233         * common/gdb_splay_tree.h: Rename include guard.
8234         * common/gdb_setjmp.h: Rename include guard.
8235         * common/gdb_ref_ptr.h: Rename include guard.
8236         * common/gdb_optional.h: Rename include guard.
8237         * common/gdb_locale.h: Rename include guard.
8238         * common/gdb_assert.h: Rename include guard.
8239         * common/filtered-iterator.h: Rename include guard.
8240         * common/filestuff.h: Rename include guard.
8241         * common/fileio.h: Rename include guard.
8242         * common/environ.h: Rename include guard.
8243         * common/common-utils.h: Rename include guard.
8244         * common/common-types.h: Rename include guard.
8245         * common/common-regcache.h: Rename include guard.
8246         * common/common-inferior.h: Rename include guard.
8247         * common/common-gdbthread.h: Rename include guard.
8248         * common/common-exceptions.h: Rename include guard.
8249         * common/common-defs.h: Rename include guard.
8250         * common/common-debug.h: Rename include guard.
8251         * common/cleanups.h: Rename include guard.
8252         * common/buffer.h: Rename include guard.
8253         * common/btrace-common.h: Rename include guard.
8254         * common/break-common.h: Rename include guard.
8255         * cli/cli-utils.h: Rename include guard.
8256         * cli/cli-style.h: Rename include guard.
8257         * cli/cli-setshow.h: Rename include guard.
8258         * cli/cli-script.h: Rename include guard.
8259         * cli/cli-interp.h: Rename include guard.
8260         * cli/cli-decode.h: Rename include guard.
8261         * cli/cli-cmds.h: Rename include guard.
8262         * charset-list.h: Add include guard.
8263         * buildsym-legacy.h: Rename include guard.
8264         * bfin-tdep.h: Add include guard.
8265         * ax.h: Rename include guard.
8266         * arm-linux-tdep.h: Add include guard.
8267         * arm-fbsd-tdep.h: Add include guard.
8268         * arch/xtensa.h: Rename include guard.
8269         * arch/tic6x.h: Add include guard.
8270         * arch/i386.h: Add include guard.
8271         * arch/arm.h: Rename include guard.
8272         * arch/arm-linux.h: Rename include guard.
8273         * arch/arm-get-next-pcs.h: Rename include guard.
8274         * arch/amd64.h: Add include guard.
8275         * arch/aarch64-insn.h: Rename include guard.
8276         * arch-utils.h: Rename include guard.
8277         * annotate.h: Add include guard.
8278         * amd64-darwin-tdep.h: Rename include guard.
8279         * aarch64-linux-tdep.h: Add include guard.
8280         * aarch64-fbsd-tdep.h: Add include guard.
8281         * aarch32-linux-nat.h: Add include guard.
8282
8283 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8284
8285         * macrotab.c (macro_define_internal): New function that
8286         factorizes macro_define_object_internal and macro_define_function
8287         code.
8288         (macro_define_object_internal): Use macro_define_internal.
8289         (macro_define_function): Likewise.
8290
8291 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8292
8293         * macrocmd.c (extract_identifier): Return
8294         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8295         callers.
8296
8297 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8298
8299         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8300
8301 2019-02-05  Tom Tromey  <tom@tromey.com>
8302
8303         * target.c (target_stack::unpush): Move assertion earlier.
8304
8305 2019-01-30  Tom Tromey  <tom@tromey.com>
8306
8307         PR python/23615:
8308         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8309         (gdbpy_parse_and_eval): Likewise.
8310         * python/python-internal.h (gdbpy_allow_threads): New class.
8311
8312 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8313
8314         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8315         (aarch64_fbsd_fpregmap): Move earlier.
8316         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8317         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8318         instead of individual calls to trad_frame_set_reg_addr.
8319         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8320         earlier.
8321         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8322         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8323         instead of individual calls to trad_frame_set_reg_addr.
8324
8325 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8326
8327         * CONTRIBUTE: Replace contribution list with wiki link.
8328
8329 2019-01-25  Tom Tromey  <tom@tromey.com>
8330
8331         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8332
8333 2019-01-25  Tom Tromey  <tom@tromey.com>
8334
8335         * xtensa-linux-nat.c: Fix common/ includes.
8336         * xml-support.h: Fix common/ includes.
8337         * xml-support.c: Fix common/ includes.
8338         * x86-linux-nat.c: Fix common/ includes.
8339         * windows-nat.c: Fix common/ includes.
8340         * varobj.h: Fix common/ includes.
8341         * varobj.c: Fix common/ includes.
8342         * value.c: Fix common/ includes.
8343         * valops.c: Fix common/ includes.
8344         * utils.c: Fix common/ includes.
8345         * unittests/xml-utils-selftests.c: Fix common/ includes.
8346         * unittests/utils-selftests.c: Fix common/ includes.
8347         * unittests/unpack-selftests.c: Fix common/ includes.
8348         * unittests/tracepoint-selftests.c: Fix common/ includes.
8349         * unittests/style-selftests.c: Fix common/ includes.
8350         * unittests/string_view-selftests.c: Fix common/ includes.
8351         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8352         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8353         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8354         * unittests/rsp-low-selftests.c: Fix common/ includes.
8355         * unittests/parse-connection-spec-selftests.c: Fix common/
8356         includes.
8357         * unittests/optional-selftests.c: Fix common/ includes.
8358         * unittests/offset-type-selftests.c: Fix common/ includes.
8359         * unittests/observable-selftests.c: Fix common/ includes.
8360         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8361         * unittests/memrange-selftests.c: Fix common/ includes.
8362         * unittests/memory-map-selftests.c: Fix common/ includes.
8363         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8364         * unittests/function-view-selftests.c: Fix common/ includes.
8365         * unittests/environ-selftests.c: Fix common/ includes.
8366         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8367         * unittests/common-utils-selftests.c: Fix common/ includes.
8368         * unittests/cli-utils-selftests.c: Fix common/ includes.
8369         * unittests/array-view-selftests.c: Fix common/ includes.
8370         * ui-file.c: Fix common/ includes.
8371         * tui/tui-io.c: Fix common/ includes.
8372         * tracepoint.h: Fix common/ includes.
8373         * tracepoint.c: Fix common/ includes.
8374         * tracefile-tfile.c: Fix common/ includes.
8375         * top.h: Fix common/ includes.
8376         * top.c: Fix common/ includes.
8377         * thread.c: Fix common/ includes.
8378         * target/waitstatus.h: Fix common/ includes.
8379         * target/waitstatus.c: Fix common/ includes.
8380         * target.h: Fix common/ includes.
8381         * target.c: Fix common/ includes.
8382         * target-memory.c: Fix common/ includes.
8383         * target-descriptions.c: Fix common/ includes.
8384         * symtab.h: Fix common/ includes.
8385         * symfile.c: Fix common/ includes.
8386         * stap-probe.c: Fix common/ includes.
8387         * spu-linux-nat.c: Fix common/ includes.
8388         * sparc-nat.c: Fix common/ includes.
8389         * source.c: Fix common/ includes.
8390         * solib.c: Fix common/ includes.
8391         * solib-target.c: Fix common/ includes.
8392         * ser-unix.c: Fix common/ includes.
8393         * ser-tcp.c: Fix common/ includes.
8394         * ser-pipe.c: Fix common/ includes.
8395         * ser-base.c: Fix common/ includes.
8396         * selftest-arch.c: Fix common/ includes.
8397         * s12z-tdep.c: Fix common/ includes.
8398         * rust-exp.y: Fix common/ includes.
8399         * rs6000-aix-tdep.c: Fix common/ includes.
8400         * riscv-tdep.c: Fix common/ includes.
8401         * remote.c: Fix common/ includes.
8402         * remote-notif.h: Fix common/ includes.
8403         * remote-fileio.h: Fix common/ includes.
8404         * remote-fileio.c: Fix common/ includes.
8405         * regcache.h: Fix common/ includes.
8406         * regcache.c: Fix common/ includes.
8407         * record-btrace.c: Fix common/ includes.
8408         * python/python.c: Fix common/ includes.
8409         * python/py-type.c: Fix common/ includes.
8410         * python/py-inferior.c: Fix common/ includes.
8411         * progspace.h: Fix common/ includes.
8412         * producer.c: Fix common/ includes.
8413         * procfs.c: Fix common/ includes.
8414         * proc-api.c: Fix common/ includes.
8415         * printcmd.c: Fix common/ includes.
8416         * ppc-linux-nat.c: Fix common/ includes.
8417         * parser-defs.h: Fix common/ includes.
8418         * osdata.c: Fix common/ includes.
8419         * obsd-nat.c: Fix common/ includes.
8420         * nat/x86-linux.c: Fix common/ includes.
8421         * nat/x86-linux-dregs.c: Fix common/ includes.
8422         * nat/x86-dregs.h: Fix common/ includes.
8423         * nat/x86-dregs.c: Fix common/ includes.
8424         * nat/ppc-linux.c: Fix common/ includes.
8425         * nat/mips-linux-watch.h: Fix common/ includes.
8426         * nat/mips-linux-watch.c: Fix common/ includes.
8427         * nat/linux-waitpid.c: Fix common/ includes.
8428         * nat/linux-ptrace.h: Fix common/ includes.
8429         * nat/linux-ptrace.c: Fix common/ includes.
8430         * nat/linux-procfs.c: Fix common/ includes.
8431         * nat/linux-personality.c: Fix common/ includes.
8432         * nat/linux-osdata.c: Fix common/ includes.
8433         * nat/linux-namespaces.c: Fix common/ includes.
8434         * nat/linux-btrace.h: Fix common/ includes.
8435         * nat/linux-btrace.c: Fix common/ includes.
8436         * nat/fork-inferior.c: Fix common/ includes.
8437         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8438         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8439         * nat/aarch64-linux.c: Fix common/ includes.
8440         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8441         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8442         * namespace.h: Fix common/ includes.
8443         * mips-linux-tdep.c: Fix common/ includes.
8444         * minsyms.c: Fix common/ includes.
8445         * mi/mi-parse.h: Fix common/ includes.
8446         * mi/mi-main.c: Fix common/ includes.
8447         * mi/mi-cmd-env.c: Fix common/ includes.
8448         * memrange.h: Fix common/ includes.
8449         * memattr.c: Fix common/ includes.
8450         * maint.h: Fix common/ includes.
8451         * maint.c: Fix common/ includes.
8452         * main.c: Fix common/ includes.
8453         * machoread.c: Fix common/ includes.
8454         * location.c: Fix common/ includes.
8455         * linux-thread-db.c: Fix common/ includes.
8456         * linux-nat.c: Fix common/ includes.
8457         * linux-fork.c: Fix common/ includes.
8458         * inline-frame.c: Fix common/ includes.
8459         * infrun.c: Fix common/ includes.
8460         * inflow.c: Fix common/ includes.
8461         * inferior.h: Fix common/ includes.
8462         * inferior.c: Fix common/ includes.
8463         * infcmd.c: Fix common/ includes.
8464         * inf-ptrace.c: Fix common/ includes.
8465         * inf-child.c: Fix common/ includes.
8466         * ia64-linux-nat.c: Fix common/ includes.
8467         * i387-tdep.c: Fix common/ includes.
8468         * i386-tdep.c: Fix common/ includes.
8469         * i386-linux-tdep.c: Fix common/ includes.
8470         * i386-linux-nat.c: Fix common/ includes.
8471         * i386-go32-tdep.c: Fix common/ includes.
8472         * i386-fbsd-tdep.c: Fix common/ includes.
8473         * i386-fbsd-nat.c: Fix common/ includes.
8474         * guile/scm-type.c: Fix common/ includes.
8475         * guile/guile.c: Fix common/ includes.
8476         * go32-nat.c: Fix common/ includes.
8477         * gnu-nat.c: Fix common/ includes.
8478         * gdbthread.h: Fix common/ includes.
8479         * gdbarch-selftests.c: Fix common/ includes.
8480         * gdb_usleep.c: Fix common/ includes.
8481         * gdb_select.h: Fix common/ includes.
8482         * gdb_bfd.c: Fix common/ includes.
8483         * gcore.c: Fix common/ includes.
8484         * fork-child.c: Fix common/ includes.
8485         * findvar.c: Fix common/ includes.
8486         * fbsd-nat.c: Fix common/ includes.
8487         * event-top.c: Fix common/ includes.
8488         * event-loop.c: Fix common/ includes.
8489         * dwarf2read.c: Fix common/ includes.
8490         * dwarf2loc.c: Fix common/ includes.
8491         * dwarf2-frame.c: Fix common/ includes.
8492         * dwarf-index-cache.c: Fix common/ includes.
8493         * dtrace-probe.c: Fix common/ includes.
8494         * disasm-selftests.c: Fix common/ includes.
8495         * defs.h: Fix common/ includes.
8496         * csky-tdep.c: Fix common/ includes.
8497         * cp-valprint.c: Fix common/ includes.
8498         * cp-support.h: Fix common/ includes.
8499         * cp-support.c: Fix common/ includes.
8500         * corelow.c: Fix common/ includes.
8501         * completer.h: Fix common/ includes.
8502         * completer.c: Fix common/ includes.
8503         * compile/compile.c: Fix common/ includes.
8504         * compile/compile-loc2c.c: Fix common/ includes.
8505         * compile/compile-cplus-types.c: Fix common/ includes.
8506         * compile/compile-cplus-symbols.c: Fix common/ includes.
8507         * command.h: Fix common/ includes.
8508         * cli/cli-dump.c: Fix common/ includes.
8509         * cli/cli-cmds.c: Fix common/ includes.
8510         * charset.c: Fix common/ includes.
8511         * build-id.c: Fix common/ includes.
8512         * btrace.h: Fix common/ includes.
8513         * btrace.c: Fix common/ includes.
8514         * breakpoint.h: Fix common/ includes.
8515         * breakpoint.c: Fix common/ includes.
8516         * ax.h:
8517         (enum agent_op): Fix common/ includes.
8518         * ax-general.c (struct aop_map): Fix common/ includes.
8519         * ax-gdb.c: Fix common/ includes.
8520         * auxv.c: Fix common/ includes.
8521         * auto-load.c: Fix common/ includes.
8522         * arm-tdep.c: Fix common/ includes.
8523         * arch/riscv.c: Fix common/ includes.
8524         * arch/ppc-linux-common.c: Fix common/ includes.
8525         * arch/i386.c: Fix common/ includes.
8526         * arch/arm.c: Fix common/ includes.
8527         * arch/arm-linux.c: Fix common/ includes.
8528         * arch/arm-get-next-pcs.c: Fix common/ includes.
8529         * arch/amd64.c: Fix common/ includes.
8530         * arch/aarch64.c: Fix common/ includes.
8531         * arch/aarch64-insn.c: Fix common/ includes.
8532         * arch-utils.c: Fix common/ includes.
8533         * amd64-windows-tdep.c: Fix common/ includes.
8534         * amd64-tdep.c: Fix common/ includes.
8535         * amd64-sol2-tdep.c: Fix common/ includes.
8536         * amd64-obsd-tdep.c: Fix common/ includes.
8537         * amd64-nbsd-tdep.c: Fix common/ includes.
8538         * amd64-linux-tdep.c: Fix common/ includes.
8539         * amd64-linux-nat.c: Fix common/ includes.
8540         * amd64-fbsd-tdep.c: Fix common/ includes.
8541         * amd64-fbsd-nat.c: Fix common/ includes.
8542         * amd64-dicos-tdep.c: Fix common/ includes.
8543         * amd64-darwin-tdep.c: Fix common/ includes.
8544         * agent.c: Fix common/ includes.
8545         * ada-lang.h: Fix common/ includes.
8546         * ada-lang.c: Fix common/ includes.
8547         * aarch64-tdep.c: Fix common/ includes.
8548
8549 2019-01-25  Tom Tromey  <tom@tromey.com>
8550
8551         * common/create-version.sh: Use common/version.h.
8552
8553 2019-01-24  Pedro Alves  <palves@redhat.com>
8554
8555         * infrun.c (signal_stop, signal_print, signal_program)
8556         (signal_catch, signal_pass): Now arrays instead of pointers.
8557         (update_signals_program_target, do_target_resume)
8558         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8559         * linux-nat.c (linux_nat_target::pass_signals)
8560         (linux_nat_target::create_inferior, linux_nat_target::attach):
8561         Adjust.
8562         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8563         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8564         * procfs.c (procfs_target::pass_signals): Adjust.
8565         * record-full.c (record_full_target::resume): Adjust.
8566         * remote.c (remote_target::pass_signals)
8567         (remote_target::program_signals): Adjust.
8568         * target-debug.h (target_debug_print_signals): Now takes a
8569         gdb::array_view as parameter.  Adjust.
8570         * target.h (target_ops) <pass_signals, program_signals>: Replace
8571         pointer and length parameters with gdb::array_view.
8572         (target_pass_signals, target_program_signals): Likewise.
8573         * target-delegates.c: Regenerate.
8574
8575 2019-01-24  Pedro Alves  <palves@redhat.com>
8576
8577         * common/forward-scope-exit.h
8578         (forward_scope_exit::forward_scope_exit): Pass arguments to
8579         m_bind_function directly, instead of creating a std::bind and
8580         copying that.
8581
8582 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8583
8584         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8585         for static members.
8586         (pass_in_v_vfp_candidate): Likewise.
8587
8588 2019-01-23  Tom Tromey  <tom@tromey.com>
8589             Pedro Alves  <palves@redhat.com>
8590
8591         * regcache.c (class regcache_invalidator): Remove.
8592         (regcache::raw_write): Use make_scope_exit.
8593
8594 2019-01-23  Tom Tromey  <tom@tromey.com>
8595
8596         * ui-out.h (class ui_out_emit_type): Update comment.
8597
8598 2019-01-23  Tom Tromey  <tom@tromey.com>
8599
8600         * infrun.c (fetch_inferior_event): Update comment.
8601
8602 2019-01-23  Tom Tromey  <tom@tromey.com>
8603             Pedro Alves  <palves@redhat.com>
8604
8605         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8606         parameter.
8607         (fetch_inferior_event): Use SCOPE_EXIT.
8608
8609
8610 2019-01-23  Tom Tromey  <tom@tromey.com>
8611             Pedro Alves  <palves@redhat.com>
8612
8613         * infrun.c (disable_thread_events): Delete.
8614         (stop_all_threads): Use SCOPE_EXIT.
8615
8616 2019-01-23  Tom Tromey  <tom@tromey.com>
8617             Pedro Alves  <palves@redhat.com>
8618
8619         * symfile.c: Include forward-scope-exit.h.
8620         (clear_symtab_users_cleanup): Replace forward declaration with
8621         a FORWARD_SCOPE_EXIT.
8622         (syms_from_objfile_1): Use the forward_scope_exit and
8623         gdb::optional instead of cleanup_function.
8624         (reread_symbols): Use the forward_scope_exit instead of
8625         cleanup_function.
8626         (clear_symtab_users_cleanup): Remove function.
8627
8628 2019-01-23  Tom Tromey  <tom@tromey.com>
8629             Pedro Alves  <palves@redhat.com>
8630
8631         * linux-nat.c: Include scope-exit.h.
8632         (cleanup_target_stop): Remove.
8633         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8634         SCOPE_EXIT.
8635
8636 2019-01-23  Tom Tromey  <tom@tromey.com>
8637             Pedro Alves  <palves@redhat.com>
8638
8639         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8640         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8641
8642 2019-01-23  Tom Tromey  <tom@tromey.com>
8643             Andrew Burgess  <andrew.burgess@embecosm.com>
8644             Pedro Alves  <palves@redhat.com>
8645
8646         * infrun.c (fetch_inferior_event): Use scope_exit.
8647         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8648         * top.c (execute_command): Use scope_exit.
8649         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8650         * utils.c (do_bpstat_clear_actions_cleanup)
8651         (make_bpstat_clear_actions_cleanup): Remove.
8652
8653 2019-01-23  Tom Tromey  <tom@tromey.com>
8654             Pedro Alves  <palves@redhat.com>
8655
8656         * infrun.c: Include "common/scope-exit.h"
8657         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8658         (wait_for_inferior): Use SCOPE_EXIT.
8659         (fetch_inferior_event): Use scope_exit.
8660
8661 2019-01-23  Tom Tromey  <tom@tromey.com>
8662             Pedro Alves  <palves@redhat.com>
8663
8664         * breakpoint.c (create_breakpoint): Remove cleanup.
8665
8666 2019-01-23  Tom Tromey  <tom@tromey.com>
8667             Andrew Burgess  <andrew.burgess@embecosm.com>
8668             Pedro Alves  <palves@redhat.com>
8669
8670 2019-01-23  Pedro Alves  <palves@redhat.com>
8671
8672         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8673
8674 2019-01-23  Pedro Alves  <palves@redhat.com>
8675             Andrew Burgess  <andrew.burgess@embecosm.com>
8676
8677         * gdbthread.h: Include "common/forward-scope-exit.h".
8678         (scoped_finish_thread_state): Redefine custom class in terms of
8679         forward_scope_exit.
8680
8681 2019-01-23  Pedro Alves  <palves@redhat.com>
8682             Andrew Burgess  <andrew.burgess@embecosm.com>
8683
8684         * common/forward-scope-exit.h: New file.
8685
8686 2019-01-23  Pedro Alves  <palves@redhat.com>
8687             Andrew Burgess  <andrew.burgess@embecosm.com>
8688             Tom Tromey  <tom@tromey.com>
8689
8690         * common/scope-exit.h: New file.
8691
8692 2019-01-23  Pedro Alves  <palves@redhat.com>
8693
8694         * common/preprocessor.h (ESC): Rename to ...
8695         (ESC_PARENS): ... this.
8696         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8697         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8698
8699 2019-01-23  Tom Tromey  <tom@tromey.com>
8700
8701         * language.h (class scoped_switch_to_sym_language_if_auto):
8702         Initialize m_lang in both cases.
8703
8704 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8705
8706         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8707         with XCNEW.
8708
8709 2019-01-22  Tom Tromey  <tom@tromey.com>
8710
8711         * corelow.c: Do not include sys/file.h.
8712
8713 2019-01-22  Tom Tromey  <tom@tromey.com>
8714
8715         * tui/tui-wingeneral.h: Include gdb_curses.h.
8716
8717 2019-01-22  Tom Tromey  <tom@tromey.com>
8718
8719         * source-cache.h (class source_cache) <get_source_lines,
8720         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8721
8722 2019-01-22  Tom Tromey  <tom@tromey.com>
8723
8724         * remote-fileio.h (struct remote_target): Declare.
8725
8726 2019-01-22  Tom Tromey  <tom@tromey.com>
8727
8728         * python/py-arch.c: Do not include py-ref.h.
8729         * python/py-bpevent.c: Do not include py-ref.h.
8730         * python/py-cmd.c: Do not include py-ref.h.
8731         * python/py-continueevent.c: Do not include py-ref.h.
8732         * python/py-event.h: Do not include py-ref.h.
8733         * python/py-evtregistry.c: Do not include py-ref.h.
8734         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8735         * python/py-frame.c: Do not include py-ref.h.
8736         * python/py-framefilter.c: Do not include py-ref.h.
8737         * python/py-function.c: Do not include py-ref.h.
8738         * python/py-infevents.c: Do not include py-ref.h.
8739         * python/py-linetable.c: Do not include py-ref.h.
8740         * python/py-objfile.c: Do not include py-ref.h.
8741         * python/py-param.c: Do not include py-ref.h.
8742         * python/py-prettyprint.c: Do not include py-ref.h.
8743         * python/py-progspace.c: Do not include py-ref.h.
8744         * python/py-symbol.c: Do not include py-ref.h.
8745         * python/py-symtab.c: Do not include py-ref.h.
8746         * python/py-type.c: Do not include py-ref.h.
8747         * python/py-unwind.c: Do not include py-ref.h.
8748         * python/py-utils.c: Do not include py-ref.h.
8749         * python/py-value.c: Do not include py-ref.h.
8750         * python/py-varobj.c: Do not include py-ref.h.
8751         * python/py-xmethods.c: Do not include py-ref.h.
8752         * python/python.c: Do not include py-ref.h.
8753         * varobj.c: Do not include py-ref.h.
8754
8755 2019-01-22  Tom Tromey  <tom@tromey.com>
8756
8757         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8758         keyword for bcache.
8759
8760 2019-01-22  Tom Tromey  <tom@tromey.com>
8761
8762         * compile/compile-cplus-types.c: Remove a comment by #include.
8763
8764 2019-01-22  Tom Tromey  <tom@tromey.com>
8765
8766         * compile/gcc-c-plugin.h: Include compile-internal.h.
8767
8768 2019-01-22  Tom Tromey  <tom@tromey.com>
8769
8770         * stabsread.c (EXTERN): Do not define.
8771         (symnum, next_symbol_text_func, processing_gcc_compilation)
8772         (within_function, global_sym_chain, global_stabs)
8773         (previous_stab_code, this_object_header_files)
8774         (n_this_object_header_files)
8775         (n_allocated_this_object_header_files): Define.
8776         * stabsread.h (EXTERN): Never define.  Use "extern".
8777
8778 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8779
8780         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8781         history_value.
8782
8783 2019-01-21  Tom Tromey  <tom@tromey.com>
8784
8785         * ui-out.c: Fix includes.
8786         * tui/tui-source.c: Fix includes.
8787         * target.c: Fix includes.
8788         * remote.c: Fix includes.
8789         * regcache.c: Fix includes.
8790         * python/py-block.c: Fix includes.
8791         * printcmd.c: Fix includes.
8792         * or1k-tdep.c: Fix includes.
8793         * mi/mi-main.c: Fix includes.
8794         * m32r-tdep.c: Fix includes.
8795         * csky-tdep.c: Fix includes.
8796         * compile/compile-cplus-types.c: Fix includes.
8797         * cli/cli-interp.c: Fix includes.
8798
8799 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8800
8801         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8802         for padding.
8803
8804 2019-01-16  Tom Tromey  <tom@tromey.com>
8805
8806         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8807         earlier.
8808         (struct objfile) <msymbols_range>: Move from top level.
8809         <msymbols>: New method.
8810         (class objfile_msymbols): Remove.
8811         * symtab.c (default_collect_symbol_completion_matches_break_on):
8812         Update.
8813         * symmisc.c (dump_msymbols): Update.
8814         * stabsread.c (scan_file_globals): Update.
8815         * objc-lang.c (info_selectors_command, info_classes_command)
8816         (find_methods): Update.
8817         * minsyms.c (find_solib_trampoline_target): Update.
8818         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8819         * coffread.c (coff_symfile_read): Update.
8820         * ada-lang.c (ada_lookup_simple_minsym)
8821         (ada_collect_symbol_completion_matches): Update.
8822
8823 2019-01-16  Tom Tromey  <tom@tromey.com>
8824
8825         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8826         type.  Remove no-argument constructor.
8827         <iterator::operator++>: Simplify.
8828         <begin>: Update.
8829         <end>: Use minimal_symbol_count.
8830
8831 2019-01-16  Tom Tromey  <tom@tromey.com>
8832
8833         * objfiles.h (struct objfile) <psymtabs>: New method.
8834         (class objfile_psymtabs): Remove.
8835         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8836         typedef.
8837         <range>: New method.
8838         (require_partial_symbols): Change return type.
8839         * psymtab.c (require_partial_symbols)
8840         (psym_expand_symtabs_matching): Update.
8841         * mdebugread.c (parse_partial_symbols): Update.
8842         * dbxread.c (dbx_end_psymtab): Update.
8843
8844 2019-01-15  Tom Tromey  <tom@tromey.com>
8845
8846         * symtab.c (lookup_objfile_from_block)
8847         (lookup_symbol_in_objfile_symtabs)
8848         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8849         (find_line_symtab, info_sources_command)
8850         (default_collect_symbol_completion_matches_break_on)
8851         (make_source_files_completion_list): Update.
8852         * symmisc.c (print_objfile_statistics, dump_objfile)
8853         (maintenance_print_symbols, maintenance_info_symtabs)
8854         (maintenance_check_symtabs, maintenance_info_line_tables):
8855         Update.
8856         * source.c (select_source_symtab)
8857         (forget_cached_source_info_for_objfile): Update.
8858         * objfiles.h (class objfile_compunits): Remove.
8859         (struct objfile) <compunits_range>: New typedef.
8860         (compunits): New method.
8861         * objfiles.c (objfile_relocate1): Update.
8862         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8863         * maint.c (count_symtabs_and_blocks): Update.
8864         * linespec.c (iterate_over_all_matching_symtabs): Update.
8865         * cp-support.c (add_symbol_overload_list_qualified): Update.
8866         * coffread.c (coff_symtab_read): Update.
8867         * ada-lang.c (add_nonlocal_symbols)
8868         (ada_collect_symbol_completion_matches)
8869         (ada_add_global_exceptions): Update.
8870
8871 2019-01-15  Tom Tromey  <tom@tromey.com>
8872
8873         * progspace.h (program_space) <objfiles_safe_range>: New
8874         typedef.
8875         <objfiles_safe>: New method.
8876         * objfiles.h (class all_objfiles_safe): Remove.
8877         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8878         * jit.c (jit_inferior_exit_hook): Update.
8879
8880 2019-01-17  Tom Tromey  <tom@tromey.com>
8881
8882         * progspace.h (program_space) <objfiles_range>: New typedef.
8883         <objfiles>: New method.
8884         <objfiles_head>: Rename from objfiles.
8885         (object_files): Update.
8886         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8887         * guile/scm-pretty-print.c
8888         (ppscm_find_pretty_printer_from_objfiles): Update.
8889         * guile/scm-objfile.c (gdbscm_objfiles): Update.
8890         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8891         Update.
8892         * python/py-progspace.c (pspy_get_objfiles): Update.
8893         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8894         Update.
8895         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8896         (objfpy_lookup_objfile_by_build_id): Update.
8897         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8898         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8899         Update.
8900         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8901         (expand_symtab_containing_pc, lookup_objfile_from_block)
8902         (lookup_static_symbol, basic_lookup_transparent_type)
8903         (find_pc_sect_compunit_symtab, find_symbol_at_address)
8904         (find_line_symtab, info_sources_command)
8905         (default_collect_symbol_completion_matches_break_on)
8906         (make_source_files_completion_list, find_main_name): Update.
8907         * symmisc.c (print_symbol_bcache_statistics)
8908         (print_objfile_statistics, maintenance_print_symbols)
8909         (maintenance_print_msymbols, maintenance_print_objfiles)
8910         (maintenance_info_symtabs, maintenance_check_symtabs)
8911         (maintenance_expand_symtabs, maintenance_info_line_tables):
8912         Update.
8913         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8914         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
8915         (map_overlay_command, unmap_overlay_command)
8916         (simple_overlay_update, expand_symtabs_matching)
8917         (map_symbol_filenames): Update.
8918         * symfile-debug.c (set_debug_symfile): Update.
8919         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
8920         Update.
8921         * source.c (select_source_symtab, forget_cached_source_info):
8922         Update.
8923         * solib.c (solib_read_symbols): Update.
8924         * solib-spu.c (append_ocl_sos): Update.
8925         * psymtab.c (maintenance_print_psymbols)
8926         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
8927         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
8928         * printcmd.c (info_symbol_command): Update.
8929         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
8930         Update.
8931         * objfiles.h (class all_objfiles): Remove.
8932         * objfiles.c (have_partial_symbols, have_full_symbols)
8933         (have_minimal_symbols, qsort_cmp, update_section_map)
8934         (shared_objfile_contains_address_p)
8935         (default_iterate_over_objfiles_in_search_order): Update.
8936         * objc-lang.c (info_selectors_command, info_classes_command)
8937         (find_methods): Update.
8938         * minsyms.c (find_solib_trampoline_target): Update.
8939         * maint.c (maintenance_info_sections)
8940         (maintenance_translate_address, count_symtabs_and_blocks):
8941         Update.
8942         * main.c (captured_main_1): Update.
8943         * linux-thread-db.c (try_thread_db_load_from_pdir)
8944         (has_libpthread): Update.
8945         * linespec.c (iterate_over_all_matching_symtabs)
8946         (search_minsyms_for_name): Update.
8947         * jit.c (jit_find_objf_with_entry_addr): Update.
8948         * hppa-tdep.c (find_unwind_entry)
8949         (hppa_lookup_stub_minimal_symbol): Update.
8950         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
8951         Update.
8952         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8953         (elf_gnu_ifunc_resolve_by_got): Update.
8954         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
8955         * dwarf-index-write.c (save_gdb_index_command): Update.
8956         * cp-support.c (add_symbol_overload_list_qualified): Update.
8957         * breakpoint.c (create_overlay_event_breakpoint)
8958         (create_longjmp_master_breakpoint)
8959         (create_std_terminate_master_breakpoint)
8960         (create_exception_master_breakpoint): Update.
8961         * blockframe.c (find_pc_partial_function): Update.
8962         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
8963         (ada_collect_symbol_completion_matches)
8964         (ada_add_global_exceptions): Update.
8965
8966 2019-01-17  Tom Tromey  <tom@tromey.com>
8967
8968         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
8969         declare VEC.
8970         (solib_target_parse_libraries): Change return type.
8971         (library_list_start_segment, library_list_start_section)
8972         (library_list_end_library, library_list_start_library); Update.
8973         (solib_target_free_library_list): Remove.
8974         (solib_target_parse_libraries): Remove cleanup.  Change return
8975         type.
8976         (solib_target_current_sos): Update.
8977
8978 2019-01-17  Tom Tromey  <tromey@bapiya>
8979
8980         * valprint.c: Replace "the the" with "the".
8981         * symtab.c: Replace "the the" with "the".
8982         * solib.c: Replace "the the" with "the".
8983         * solib-dsbt.c: Replace "the the" with "the".
8984         * linespec.c: Replace "the the" with "the".
8985         * dwarf2loc.h: Replace "the the" with "the".
8986         * amd64-windows-tdep.c: Replace "the the" with "the".
8987         * aarch64-tdep.c: Replace "the the" with "the".
8988
8989 2019-01-16  Keith Seitz  <keiths@redhat.com>
8990
8991         PR gdb/23773
8992         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
8993         <builder>: Rename to ..
8994         <m_builder>: ... this and make private.
8995         (dwarf2_cu::get_builder): New method.  Change all users of
8996         `builder' to use this method.
8997         (dwarf2_start_symtab): Move to ...
8998         (dwarf2_cu::start_symtab): ... here.  Update all callers
8999         (setup_type_unit_groups): Move to ...
9000         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9001         callers.
9002         (dwarf2_cu::reset_builder): New method.
9003         (process_full_compunit, process_full_type_unit): Use
9004         dwarf2_cu::reset_builder.
9005         (follow_die_offset): Record the ancestor CU if it is different
9006         from the followed DIE's CU.
9007         (follow_die_sig_1): Likewise.
9008
9009 2019-01-15  Tom Tromey  <tom@tromey.com>
9010
9011         * remote.c (class remote_state) <buf>: Now a char_vector.
9012         <buf_size>: Remove.
9013         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9014         parameter.
9015         (remote_target::getpkt_or_notif_sane_1)
9016         (remote_target::getpkt_sane)
9017         (remote_target::getpkt_or_notif_sane): Likewise.
9018         (class remote_target) <putpkt>: New overload.
9019         (remote_target::read_frame): Change type of "buf_p".  Remove
9020         sizeof_p parameter.
9021         (packet_ok): New overload.
9022         (packet_check_result): New overload.
9023         Update all uses.
9024
9025 2019-01-14  Tom Tromey  <tom@tromey.com>
9026
9027         * remote-notif.c (handle_notification, remote_notif_ack)
9028         (remote_notif_parse): Make "buf" const.
9029         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9030         const.
9031         (remote_notif_parse, remote_notif_ack, handle_notification):
9032         Likewise.
9033         * remote.c (remote_notif_stop_parse): Make "buf" const.
9034         (remote_target::remote_parse_stop_reply): Make "buf" const.
9035         (remote_notif_stop_ack): Make "buf" const.
9036
9037 2019-01-14  Tom Tromey  <tom@tromey.com>
9038
9039         * remote.c (remote_console_output): Make parameter const.
9040
9041 2019-01-14  Tom Tromey  <tom@tromey.com>
9042
9043         * target-debug.h (target_debug_print_signals): Constify.
9044         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9045         * procfs.c (procfs_target::pass_signals): Update.
9046         * linux-nat.c (linux_nat_target::pass_signals): Update.
9047         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9048         * target-delegates.c: Rebuild.
9049         * remote.c (remote_target::program_signals): Update.
9050         (remote_target::pass_signals): Update.
9051         * target.c (target_pass_signals): Constify argument.
9052         (target_program_signals): Likewise.
9053         * target.h (struct target_ops) <pass_signals, program_signals>:
9054         Constify argument.
9055         (target_pass_signals, target_program_signals): Constify argument.
9056
9057 2019-01-14  Tom Tromey  <tom@tromey.com>
9058
9059         PR tui/28819:
9060         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9061
9062 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9063
9064         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9065         field.
9066         * rs6000-tdep.c: Include reggroups.h.
9067         (IS_V_ALIAS_PSEUDOREG): Define.
9068         (rs6000_register_name): Return names for the "vX" aliases.
9069         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9070         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9071         aliases.  Call default_register_reggroup_p for all other
9072         pseudo-registers.
9073         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9074         New functions.
9075         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9076         Handle "vX" aliases.
9077         (v_alias_pseudo_register_collect): New function.
9078         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9079         (rs6000_gdbarch_init): Initialize "vX" aliases as
9080         pseudo-registers.  Restore registration of
9081         rs6000_pseudo_register_reggroup_p with
9082         set_tdesc_pseudo_register_reggroup_p.
9083
9084 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9085
9086         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9087         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9088         set_gdbarch_num_pseudo_regs.
9089
9090 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9091
9092         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9093         Remove arg prefixname, add do_set and do_show.
9094         Add member functions set_list and show_list.
9095         * cli/cli-style.c (class cli_style_option): Update accordingly.
9096         (style_set_list): Move to file scope.
9097         (style_show_list): Likewise.
9098         (set_style): Call help_list.
9099         (show_style): Call cmd_show_list.
9100         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9101         Update to use the new macro.
9102
9103 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9104
9105         * ada-lang.c (_initialize_ada_language): Expand the help text
9106         for the "catch exception" command.
9107
9108 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9109
9110         * symtab.c (matching_obj_sections): Initialize obj,
9111         declare it closer to its usage.
9112
9113 2019-01-10  Tom Tromey  <tom@tromey.com>
9114
9115         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9116         (basic_inf_threads_range): Remove.
9117         (inf_threads_range, inf_non_exited_threads_range)
9118         (safe_inf_threads_range): Use next_adapter.
9119
9120 2019-01-10  Keith Seitz  <keiths@redhat.com>
9121
9122         PR gdb/23712
9123         PR symtab/23010
9124         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9125         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9126
9127 2019-01-10  Keith Seitz  <keiths@redhat.com>
9128
9129         PR gdb/23712
9130         PR symtab/23010
9131         * dictionary.c (pending_to_vector): Remove.
9132         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9133         Remove _1 suffix, replacing functions of the same name.  Update
9134         all callers.
9135         (dict_create_hashed, dict_create_hashed_expandable)
9136         (dict_create_linear, dict_create_linear_expandable, dict_free)
9137         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9138         Make functions static.
9139
9140 2019-01-10  Keith Seitz  <keiths@redhat.com>
9141
9142         PR gdb/23712
9143         PR symtab/23010
9144         * dictionary.h (struct dictionary): Replace declaration with
9145         multidictionary.
9146         (dict_create_hashed, dict_create_hashed_expandable)
9147         (dict_create_linear, dict_create_linear_expandable)
9148         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9149         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9150         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9151         taking multidictionary argument.
9152         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9153         * block.h (struct block) <dict>: Change to multidictionary
9154         and rename `multidict'.
9155         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9156         symmisc.c: Update all dictionary references to multidictionary.
9157
9158 2019-01-10  Keith Seitz  <keiths@redhat.com>
9159
9160         PR gdb/23712
9161         PR symtab/23010
9162         * dictionary.c: Include unordered_map.
9163         (pending_to_vector): New function.
9164         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9165         Rewrite the non-"_1" functions to take vector instead
9166         of linked list.
9167         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9168         "new" _1 versions of the same name.
9169         (multidictionary): Define.
9170         (std::hash<enum language): New definition.
9171         (collate_pending_symbols_by_language, mdict_create_hashed)
9172         (mdict_create_hashed_expandable, mdict_create_linear)
9173         (mdict_create_linear_expandable, mdict_free)
9174         (find_language_dictionary, create_new_language_dictionary)
9175         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9176         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9177         (mdict_size, mdict_empty): New functions.
9178         * dictionary.h (mdict_iterator): Define.
9179
9180 2019-01-10  Pedro Alves  <palves@redhat.com>
9181
9182         * breakpoint.c (read_uploaded_action)
9183         (create_tracepoint_from_upload): Adjust to use
9184         gdb::unique_xmalloc_ptr.
9185         * ctf.c (ctf_write_uploaded_tp):
9186         (SET_ARRAY_FIELD): Use emplace_back.
9187         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9188         * tracefile-tfile.c (tfile_write_uploaded_tp):
9189         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9190         gdb::unique_xmalloc_ptr.
9191         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9192         at_string, cond_string, cmd_strings>: Replace char pointers
9193         with gdb::unique_xmalloc_ptr.
9194
9195 2019-01-10  Pedro Alves  <palves@redhat.com>
9196
9197         * solib-target.c (library_list_start_library): Don't xstrdup name.
9198
9199 2019-01-10  Pedro Alves  <palves@redhat.com>
9200
9201         * mdebugread.c (parse_partial_symbols): Use
9202         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9203
9204 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9205
9206         * linux-fork.c (scoped_switch_fork_info)
9207         <~scoped_switch_fork_info>: Fix incorrect variable name.
9208
9209 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9210
9211         * linux-fork.c (scoped_switch_fork_info)
9212         <scoped_switch_fork_info>: Make explicit.
9213         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9214
9215 2019-01-10  Tom Tromey  <tom@tromey.com>
9216
9217         * objfiles.h (objfile::reset_psymtabs): Update.
9218         * objfiles.c (objfile::objfile): Update.
9219         * psymtab.h (psymtab_storage::obstack): Update.
9220         (psymtab_storage::m_obstack): Use gdb::optional.
9221         (class psymtab_storage): Update comment.  Remove objfile
9222         parameter.
9223         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9224
9225 2019-01-10  Tom Tromey  <tom@tromey.com>
9226
9227         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9228         <free_psymtabs>: Now private.
9229         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9230         (allocate_psymtab): Use new method.
9231
9232 2019-01-10  Tom Tromey  <tom@tromey.com>
9233
9234         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9235         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9236         * mdebugread.c (parse_partial_symbols): Use
9237         allocate_dependencies.
9238         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9239         allocate_dependencies.
9240         (process_psymtab_comp_unit_reader)
9241         (build_type_psymtab_dependencies): Likewise.
9242         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9243
9244 2019-01-10  Tom Tromey  <tom@tromey.com>
9245
9246         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9247         PSYMBOL_SET_LANGUAGE.
9248         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9249
9250 2019-01-10  Tom Tromey  <tom@tromey.com>
9251
9252         * psymtab.h (psymtab_storage::obstack): New method.
9253         <m_obstack>: Rename from obstack; now private.
9254         * psymtab.c (psymtab_storage): Update.
9255         * dwarf2read.c (create_addrmap_from_index)
9256         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9257         Update.
9258
9259 2019-01-10  Tom Tromey  <tom@tromey.com>
9260
9261         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9262         * objfiles.h (objfile::reset_psymtabs): New method.
9263
9264 2019-01-10  Tom Tromey  <tom@tromey.com>
9265
9266         * symmisc.c (print_symbol_bcache_statistics): Update.
9267         (print_objfile_statistics): Update.
9268         * symfile.c (reread_symbols): Update.
9269         * psymtab.h (class psymtab_storage): New.
9270         * psymtab.c (psymtab_storage): New constructor.
9271         (~psymtab_storage): New destructor.
9272         (require_partial_symbols): Update.
9273         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9274         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9275         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9276         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9277         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9278         (start_psymtab_common, end_psymtab_common)
9279         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9280         (allocate_psymtab): Update.
9281         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9282         Update.
9283         (dump_psymtab_addrmap, maintenance_print_psymbols)
9284         (maintenance_check_psymtabs): Update.
9285         (class objfile_psymtabs): Move to objfiles.h.
9286         * psympriv.h (discard_psymtab): Now inline.
9287         (psymtab_discarder::psymtab_discarder): Update.
9288         (psymtab_discarder::~psymtab_discarder): Update.
9289         (ALL_OBJFILE_PSYMTABS): Rewrite.
9290         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9291         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9292         Remove fields.
9293         <partial_symtabs>: New field.
9294         (class objfile_psymtabs): Move from psymtab.h.  Update.
9295         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9296         psymbol_cache.
9297         (objfile::~objfile): Don't destroy psymbol_cache.
9298         * mdebugread.c (parse_partial_symbols): Update.
9299         * dwarf2read.c (create_addrmap_from_index)
9300         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9301         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9302         (add_partial_subprogram, dwarf2_ranges_read): Update.
9303         * dwarf-index-write.c (write_address_map)
9304         (write_one_signatured_type, recursively_write_psymbols)
9305         (class debug_names, class debug_names, write_psymtabs_to_index):
9306         Update.
9307
9308 2019-01-10  Tom Tromey  <tom@tromey.com>
9309
9310         * symtab.h (SYMBOL_SET_NAMES): Update.
9311         (symbol_set_names): Update.
9312         (MSYMBOL_SET_NAMES): Update.
9313         * symtab.c (symbol_set_names): Change argument to be an
9314         objfile_per_bfd_storage.
9315         * psymtab.c (add_psymbol_to_bcache): Update.
9316         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9317
9318 2019-01-10  Tom Tromey  <tom@tromey.com>
9319
9320         * symtab.c (create_demangled_names_hash): Change argument to be an
9321         objfile_per_bfd_storage.
9322         (symbol_set_names): Update.
9323
9324 2019-01-10  Tom Tromey  <tom@tromey.com>
9325
9326         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9327         init_psymbol_list.
9328         * psymtab.c (init_psymbol_list): Do nothing if already called.
9329         * psympriv.h (init_psymbol_list): Add comment.
9330         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9331         init_psymbol_list.
9332         * dbxread.c (dbx_symfile_read): Unconditionally call
9333         init_psymbol_list.
9334
9335 2019-01-10  Tom Tromey  <tom@tromey.com>
9336
9337         * xcoffread.c (scan_xcoff_symtab): Update.
9338         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9339         "where".
9340         * mdebugread.c (parse_partial_symbols)
9341         (handle_psymbol_enumerators): Update.
9342         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9343         * dbxread.c (read_dbx_symtab): Update.
9344         * psympriv.h (psymbol_placement): New enum.
9345         (add_psymbol_to_list): Update.
9346
9347 2019-01-10  Tom Tromey  <tom@tromey.com>
9348
9349         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9350         static_psymbols parameters.
9351         (scan_xcoff_symtab): Update.
9352         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9353         static_psymbols parameters.
9354         * psympriv.h (start_psymtab_common): Update.
9355         * mdebugread.c (parse_partial_symbols): Update.
9356         * dwarf2read.c (create_partial_symtab): Update.
9357         * dbxread.c (read_dbx_symtab): Update.
9358         (start_psymtab): Remove global_psymbols and static_psymbols
9359         parameters.
9360
9361 2019-01-10  Tom Tromey  <tom@tromey.com>
9362
9363         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9364         * psymtab.c (allocate_psymtab): Add comment.
9365         * psympriv.h (allocate_psymtab): Add comment.
9366         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9367         initializations.
9368         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9369
9370 2019-01-10  Tom Tromey  <tom@tromey.com>
9371
9372         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9373         Don't declare.
9374         * mipsread.c: Include mdebugread.h.
9375         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9376         Declare.
9377         * elfread.c: Include mdebugread.h.
9378
9379 2019-01-09  Tom Tromey  <tom@tromey.com>
9380
9381         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9382         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9383         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9384         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9385         (psym_lookup_symbol, psym_find_last_source_symtab)
9386         (psym_forget_cached_source_info, psym_print_stats)
9387         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9388         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9389         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9390         (psym_find_compunit_symtab_by_address)
9391         (maintenance_print_psymbols, maintenance_info_psymtabs)
9392         (maintenance_check_psymtabs): Use ranged for.
9393         * psymtab.h (class objfile_psymtabs): New.
9394         (require_partial_symbols): Return objfile_psymtabs.
9395         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9396
9397 2019-01-09  Tom Tromey  <tom@tromey.com>
9398
9399         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9400         (find_pc_mapped_section, list_overlays_command)
9401         (map_overlay_command, unmap_overlay_command)
9402         (simple_overlay_update): Use all_objfiles.
9403         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9404         * printcmd.c (info_symbol_command): Use all_objfiles.
9405         * objfiles.h (ALL_OBJSECTIONS): Remove.
9406         * maint.c (maintenance_translate_address): Use all_objfiles.
9407         * gcore.c (gcore_create_callback): Use all_objfiles.
9408         (objfile_find_memory_regions): Likewise.
9409
9410 2019-01-09  Tom Tromey  <tom@tromey.com>
9411
9412         * symtab.c (find_line_symtab, info_sources_command)
9413         (make_source_files_completion_list): Use objfile_compunits.
9414         * source.c (select_source_symtab): Use objfile_compunits.
9415         * objfiles.h (struct objfile): Update comment.
9416         (ALL_OBJFILES): Remove.
9417         (ALL_FILETABS): Remove.
9418         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9419         objfile_compunits.
9420
9421 2019-01-09  Tom Tromey  <tom@tromey.com>
9422
9423         * symmisc.c (print_objfile_statistics, dump_objfile)
9424         (maintenance_print_symbols): Use compunit_filetabs.
9425         * source.c (forget_cached_source_info_for_objfile): Use
9426         compunit_filetabs.
9427         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9428         (ALL_FILETABS): Use compunit_filetabs.
9429         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9430         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9431
9432 2019-01-09  Tom Tromey  <tom@tromey.com>
9433
9434         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9435         (compunit_filetabs): New.
9436         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9437         compunit_filetabs.
9438         (info_sources_command, make_source_files_completion_list): Remove
9439         declaration.
9440         * symmisc.c (print_objfile_statistics, dump_objfile)
9441         (maintenance_print_symbols): Remove declaration.
9442         (maintenance_info_symtabs): Use compunit_filetabs.
9443         (maintenance_info_line_tables): Likewise.
9444         * source.c (select_source_symtab): Change local variable name.
9445         (forget_cached_source_info_for_objfile): Remove declaration.
9446         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9447         * objfiles.c (objfile_relocate1): Remove declaration.
9448         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9449         declaration.
9450         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9451         * coffread.c (coff_symtab_read): Remove declaration.
9452         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9453         compunit_filetabs.
9454
9455 2019-01-09  Tom Tromey  <tom@tromey.com>
9456
9457         * symtab.c (lookup_objfile_from_block)
9458         (find_pc_sect_compunit_symtab, search_symbols)
9459         (default_collect_symbol_completion_matches_break_on): Use
9460         objfile_compunits.
9461         * objfiles.h (ALL_COMPUNITS): Remove.
9462         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9463         * cp-support.c (add_symbol_overload_list_qualified): Use
9464         objfile_compunits.
9465         * ada-lang.c (ada_collect_symbol_completion_matches)
9466         (ada_add_global_exceptions): Use objfile_compunits.
9467
9468 2019-01-09  Tom Tromey  <tom@tromey.com>
9469
9470         * source.c (select_source_symtab)
9471         (forget_cached_source_info_for_objfile): Remove declaration.
9472         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9473         declaration.
9474         * maint.c (count_symtabs_and_blocks): Remove declaration.
9475         * cp-support.c (add_symbol_overload_list_qualified): Remove
9476         declaration.
9477         * coffread.c (coff_symtab_read): Remove declaration.
9478         * symtab.c (lookup_symbol_in_objfile_symtabs)
9479         (basic_lookup_transparent_type_1): Use objfile_compunits.
9480         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9481         (info_sources_command, search_symbols)
9482         (default_collect_symbol_completion_matches_break_on)
9483         (make_source_files_completion_list): Remove declaration.
9484         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9485         (ada_collect_symbol_completion_matches)
9486         (ada_add_global_exceptions): Remove declaration.
9487         * linespec.c (iterate_over_all_matching_symtabs): Use
9488         objfile_compunits.
9489         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9490         (class objfile_compunits): New.
9491         (ALL_COMPUNITS): Use objfile_compunits.
9492         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9493         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9494         objfile_compunits.
9495         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9496
9497 2019-01-09  Tom Tromey  <tom@tromey.com>
9498
9499         * symtab.c (search_symbols)
9500         (default_collect_symbol_completion_matches_break_on): Use
9501         objfile_msymbols.
9502         * ada-lang.c (ada_lookup_simple_minsym)
9503         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9504         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9505         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9506         objfile_msymbols.
9507         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9508         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9509         * objc-lang.c (find_methods): Use objfile_msymbols.
9510         (info_selectors_command, info_classes_command): Likewise.
9511         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9512         * objfiles.h (class objfile_msymbols): New.
9513         (ALL_OBJFILE_MSYMBOLS): Remove.
9514         (ALL_MSYMBOLS): Remove.
9515
9516 2019-01-09  Tom Tromey  <tom@tromey.com>
9517
9518         * common/next-iterator.h (next_adapter): Add Iterator template
9519         parameter.
9520         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9521         (class all_objfiles_safe): New.
9522         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9523         * objfiles.c (put_objfile_before): Update comment.
9524         (add_separate_debug_objfile): Likewise.
9525         (free_all_objfiles): Use all_objfiles_safe.
9526         (objfile_purge_solibs): Likewise.
9527
9528 2019-01-09  Tom Tromey  <tom@tromey.com>
9529
9530         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9531         (expand_symtab_containing_pc, lookup_static_symbol)
9532         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9533         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9534         all_objfiles.
9535         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9536         * breakpoint.c (create_overlay_event_breakpoint)
9537         (create_longjmp_master_breakpoint)
9538         (create_std_terminate_master_breakpoint)
9539         (create_exception_master_breakpoint): Use all_objfiles.
9540         * linux-thread-db.c (try_thread_db_load_from_pdir)
9541         (has_libpthread): Use all_objfiles.
9542         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9543         * linespec.c (iterate_over_all_matching_symtabs)
9544         (search_minsyms_for_name): Use all_objfiles.
9545         * maint.c (maintenance_info_sections): Use all_objfiles.
9546         * main.c (captured_main_1): Use all_objfiles.
9547         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9548         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9549         * guile/scm-pretty-print.c
9550         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9551         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9552         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9553         (maintenance_print_msymbols): Use all_objfiles.
9554         * source.c (select_source_symtab): Use all_objfiles.
9555         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9556         * symfile.c (remove_symbol_file_command)
9557         (expand_symtabs_matching, map_symbol_filenames): Use
9558         all_objfiles.
9559         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9560         all_objfiles.
9561         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9562         * objc-lang.c (find_methods): Use all_objfiles.
9563         * objfiles.c (have_partial_symbols, have_full_symbols)
9564         (have_minimal_symbols, qsort_cmp)
9565         (default_iterate_over_objfiles_in_search_order): Use
9566         all_objfiles.
9567         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9568         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9569         (maintenance_check_psymtabs): Use all_objfiles.
9570         (ALL_PSYMTABS): Remove.
9571         * compile/compile-object-run.c (do_module_cleanup): Use
9572         all_objfiles.
9573         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9574         * cp-support.c (add_symbol_overload_list_qualified): Use
9575         all_objfiles.
9576         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9577         Use all_objfiles.
9578         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9579         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9580         all_objfiles.
9581         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9582         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9583         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9584         Uses all_objfiles.
9585         * solib.c (solib_read_symbols): Use all_objfiles
9586
9587 2019-01-09  Tom Tromey  <tom@tromey.com>
9588
9589         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9590         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9591         all_objfiles.
9592         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9593         * symmisc.c (print_symbol_bcache_statistics)
9594         (print_objfile_statistics, maintenance_print_objfiles)
9595         (maintenance_info_symtabs, maintenance_check_symtabs)
9596         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9597         all_objfiles.
9598         * source.c (forget_cached_source_info): Use all_objfiles.
9599         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9600         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9601         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9602         * objfiles.c (update_section_map): Use all_objfiles.
9603         (shared_objfile_contains_address_p): Likewise.
9604         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9605         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9606
9607 2019-01-09  Tom Tromey  <tom@tromey.com>
9608
9609         * common/next-iterator.h: New file.
9610         * objfiles.h (class all_objfiles): New.
9611         (struct objfile_iterator): New.
9612
9613 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9614
9615         * NEWS: Move the description of the changed "frame", "select-frame",
9616          and "info frame" commands to the Changed commands section.
9617
9618 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9619
9620         * gdbtypes.c (check_stub_method_group): Remove handling of old
9621         mangling schemes.
9622         * linespec.c (find_methods): Likewise.
9623         * stabsread.c (read_member_functions): Likewise.
9624         * valops.c (search_struct_method): Likewise.
9625         (value_struct_elt_for_reference): Likewise.
9626         * NEWS: Mention this change.
9627
9628 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9629
9630         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9631         print_source_lines.
9632         * source.c (print_source_lines_base): Update line number check.
9633         (print_source_lines): New function.
9634         (source_lines_range::source_lines_range): New function.
9635         * source.h (class source_lines_range): New class.
9636         (print_source_lines): New declaration.
9637
9638 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9639
9640         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9641
9642 2019-01-08  Tom Tromey  <tom@tromey.com>
9643             Simon Marchi  <simon.marchi@ericsson.com>
9644
9645         PR gdb/24060
9646         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9647         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9648         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9649         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9650         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9651         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9652
9653 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9654
9655         * source.c (select_source_symtab): Move header comment to
9656         declaration in source.h.
9657         (forget_cached_source_info_for_objfile): Likewise.
9658         (forget_cached_source_info): Likewise.
9659         (identify_source_line): Likewise.
9660         * source.h (identify_source_line): Move declaration from symtab.h
9661         and add comment from source.c
9662         (print_source_lines): Likewise.
9663         (forget_cached_source_info_for_objfile): Likewise.
9664         (forget_cached_source_info): Likewise.
9665         (select_source_symtab): Likewise.
9666         (enum print_source_lines_flag): Move definition from symtab.h.
9667         * symtab.h (identify_source_line): Move declaration to source.h.
9668         (print_source_lines): Likewise.
9669         (forget_cached_source_info_for_objfile): Likewise.
9670         (forget_cached_source_info): Likewise.
9671         (select_source_symtab): Likewise.
9672         (enum print_source_lines_flag): Move definition to source.h.
9673         * tui/tui-hooks.c: Add 'source.h' include.
9674
9675 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9676
9677         * source.c (print_source_lines_base): Handle requests to print
9678         reverse line number sequences, and guard against empty lines
9679         string.
9680
9681 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9682
9683         * source.c (print_source_lines_base): Fix skip of '\r' if next
9684         character is '\n'.
9685
9686 2019-01-06  Tom Tromey  <tom@tromey.com>
9687
9688         * c-exp.y (struct c_parse_state) <macro_original_text,
9689         expansion_obstack>: New member.
9690         (macro_original_text, expansion_obstack): Remove globals.
9691         (scan_macro_expansion, scanning_macro_expansion)
9692         (finished_macro_expansion): Update.
9693         (scan_macro_cleanup): Remove.
9694         (yylex, c_parse): Update.
9695
9696 2019-01-06  Tom Tromey  <tom@tromey.com>
9697
9698         * c-exp.y (struct c_parse_state) <strings>: New member.
9699         (operator_stoken): Update.
9700
9701 2019-01-06  Tom Tromey  <tom@tromey.com>
9702
9703         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9704         (union type_stack_elt) <typelist_val>: Now a pointer to
9705         std::vector.
9706         (type_stack_cleanup): Don't declare.
9707         (push_typelist): Update.
9708         * parse.c (pop_typelist): Return a std::vector.
9709         (push_typelist): Take a std::vector.
9710         (follow_types): Update.  Do not free args.
9711         (type_stack_cleanup): Remove.
9712         * c-exp.y (struct c_parse_state): New.
9713         (cpstate): New global.
9714         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9715         (nonempty_typelist): Update.
9716         (func_mod): Create a new vector.
9717         (c_parse): Create a c_parse_state.
9718         (check_parameter_typelist): Do not delete params.
9719         (function_method): Update.  Do not delete type_list.
9720
9721 2019-01-06  Tom Tromey  <tom@tromey.com>
9722
9723         PR gdb/28155:
9724         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9725         check_typedef.
9726         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9727         (print_return_value): Likewise.
9728
9729 2019-01-05  Tom Tromey  <tom@tromey.com>
9730
9731         * contrib/cleanup_check.py: Remove.
9732         * contrib/gcc-with-excheck: Remove.
9733         * contrib/exsummary.py: Remove.
9734         * contrib/excheck.py: Remove.
9735
9736 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9737
9738         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9739         NULL. Initialize tpprev to NULL instead of assigning it
9740         to NULL on the next statement.
9741         * windows-nat.c (windows_delete_thread): Remove check for
9742         main_thread_id before printing thread exit notifications.
9743         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9744         Remove thread ID check against main_thread_id.
9745         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9746         windows_delete_thread.
9747         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9748
9749 2019-01-04  Tom Tromey  <tom@tromey.com>
9750
9751         * compile/compile.c (_initialize_compile): Use upper case for
9752         metasyntactic variables.
9753         * symmisc.c (_initialize_symmisc): Use upper case for
9754         metasyntactic variables.
9755         * psymtab.c (_initialize_psymtab): Use upper case for
9756         metasyntactic variables.
9757         * demangle.c (demangle_command): Use upper case for metasyntactic
9758         variables.
9759         (_initialize_demangler): Likewise.
9760         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9761         variables.
9762
9763 2019-01-03  Tom Tromey  <tom@tromey.com>
9764
9765         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9766
9767 2019-01-03  Tom Tromey  <tom@tromey.com>
9768
9769         * python/py-symtab.c (salpy_str): Update.
9770         (struct salpy_sal_object) <symtab>: Now a PyObject.
9771         (salpy_dealloc): Update.
9772         (del_objfile_sal): Use gdbpy_ref.
9773
9774 2019-01-03  Tom Tromey  <tom@tromey.com>
9775
9776         * python/py-type.c (convert_field): Use new_reference.  Return
9777         gdbpy_ref.
9778         (make_fielditem): Return gdbpy_ref.
9779         (typy_fields): Update.
9780         (typy_getitem): Update.
9781         (field_name): Return gdbpy_ref.  Use new_reference.
9782         (typy_iterator_iternext): Update.
9783
9784 2019-01-03  Tom Tromey  <tom@tromey.com>
9785
9786         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9787
9788 2019-01-03  Tom Tromey  <tom@tromey.com>
9789
9790         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9791         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9792         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9793         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9794         (pspy_set_type_printers): Likewise.
9795         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9796         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9797         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9798         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9799         (objfpy_set_type_printers): Likewise.
9800
9801 2019-01-03  Tom Tromey  <tom@tromey.com>
9802
9803         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9804         (gdbpy_print_stack): Use gdbpy_err_fetch.
9805         * python/python-internal.h (class gdbpy_err_fetch): New class.
9806         (class gdbpy_enter) <m_error_type, m_error_value,
9807         m_error_traceback>: Remove.
9808         <m_error>: New member.
9809         (gdbpy_exception_to_string): Don't declare.
9810         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9811         * python/py-value.c (convert_value_from_python): Use
9812         gdbpy_err_fetch.
9813         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9814         gdbpy_exception_to_string.
9815         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9816         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9817         gdbpy_err_fetch.
9818
9819 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9820
9821         * linux-nat.c (delete_lwp_cleanup): Delete.
9822         (struct lwp_deleter): New struct.
9823         (lwp_info_up): New typedef.
9824         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9825         lwp_info_up.
9826
9827 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9828
9829         * linux-fork.c (class scoped_switch_fork_info): New class.
9830         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9831
9832 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9833
9834         * valops.c (find_overload_match): Remove use of null_cleanup, and
9835         calls to do_cleanups.
9836
9837 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9838
9839         * compile/compile-cplus-types.c
9840         (compile_cplus_instance::decl_name): Handle changes to
9841         cp_func_name.
9842         * cp-support.c (cp_func_name): Update header comment, update
9843         return type.
9844         * cp-support.h (cp_func_name): Update return type in declaration.
9845         * valops.c (find_overload_match): Move temp_func local to top
9846         level of function and change its type.  Use temp_func to hold and
9847         delete temporary string obtained from cp_func_name.
9848
9849 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9850
9851         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9852         gdb::char_vector, remove cleanup, and update uses of `msg`.
9853
9854 2019-01-03  Jim Wilson  <jimw@sifive.com>
9855
9856         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9857
9858 2019-01-02  Tom Tromey  <tom@tromey.com>
9859
9860         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9861         (tdesc_parse_xml): Remove cleanups.
9862         * target-descriptions.h (make_cleanup_free_target_description):
9863         Don't declare.
9864         (target_desc_deleter): New struct.
9865         (target_desc_up): New typedef.
9866         * target-descriptions.c (target_desc_deleter::operator()): Rename
9867         from free_target_description.
9868         (make_cleanup_free_target_description): Remove.
9869
9870 2019-01-02  Tom Tromey  <tom@tromey.com>
9871
9872         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9873         constructor, destructor.
9874         (linespec_parser): Remove typedef.
9875         (~linespec_parser): Rename from linespec_parser_delete.
9876         (linespec_lex_to_end, linespec_complete_label)
9877         (linespec_complete): Update.
9878         (decode_line_full): Remove cleanups.
9879         (decode_line_1): Update.
9880
9881 2019-01-02  Tom Tromey  <tom@tromey.com>
9882
9883         * python/python-internal.h (inferior_to_inferior_object): Change
9884         return type.
9885         * python/py-exitedevent.c (create_exited_event_object): Update.
9886         * python/py-inferior.c (inferior_to_inferior_object): Return
9887         gdbpy_ref.
9888         (python_new_inferior, python_inferior_deleted)
9889         (thread_to_thread_object, delete_thread_object)
9890         (build_inferior_list, gdbpy_selected_inferior): Update.
9891         * python/py-infthread.c (create_thread_object): Update.  Also fail
9892         if inferior_to_inferior_object fails.
9893
9894 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9895
9896         * inferior.h (class inferior) <displaced_step_state>: New field.
9897         * infrun.h (struct displaced_step_state): Move here from
9898         infrun.c.  Initialize fields, add constructor.
9899         <inf>: Remove field.
9900         <reset>: New method.
9901         * infrun.c (struct displaced_step_inferior_state): Move to
9902         infrun.h.
9903         (displaced_step_inferior_states): Remove.
9904         (get_displaced_stepping_state): Adust.
9905         (displaced_step_in_progress_any_inferior): Adjust.
9906         (displaced_step_in_progress_thread): Adjust.
9907         (displaced_step_in_progress): Adjust.
9908         (add_displaced_stepping_state): Remove.
9909         (get_displaced_step_closure_by_addr): Adjust.
9910         (remove_displaced_stepping_state): Remove.
9911         (infrun_inferior_exit): Call displaced_step_state.reset.
9912         (use_displaced_stepping): Don't check for NULL.
9913         (displaced_step_prepare_throw): Call
9914         get_displaced_stepping_state.
9915         (displaced_step_fixup): Don't check for NULL.
9916         (prepare_for_detach): Don't check for NULL.
9917
9918 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9919
9920         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
9921          in case of call that did not complete.
9922
9923 2019-01-02  Andrey Utkin  <autkin@undo.io>
9924
9925         * symfile.c (find_separate_debug_file): Fix search of debug files for
9926         remote debuggee.
9927
9928 2019-01-02  Tom Tromey  <tom@tromey.com>
9929
9930         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
9931         indentation.
9932         * python/py-frame.c (frapy_older): Remove cast.
9933         (frapy_newer): Likewise.
9934         * python/py-breakpoint.c (local_setattro): Remove cast.
9935         * python/py-arch.c (archpy_name): Remove local variable.
9936         * python/py-type.c (gdbpy_lookup_type): Remove cast.
9937
9938 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
9939
9940         * unittests/basic_string_view/element_access/char/empty.cc:
9941         Fix year range in copyright header.
9942
9943 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9944
9945         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
9946         Delete.
9947         <operator==>: Update with for removed field.
9948         <hash>: Likewise.
9949         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
9950         <isa_features>: ...this.
9951         <abi_features>: New field.
9952         (riscv_isa_flen): Update comment.
9953         (riscv_abi_xlen): New declaration.
9954         (riscv_abi_flen): New declaration.
9955         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
9956         isa_features.
9957         (riscv_abi_xlen): New function.
9958         (riscv_isa_flen): Update to get answer from isa_features.
9959         (riscv_abi_flen): New function.
9960         (riscv_has_fp_abi): Update to get answer from abi_features.
9961         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
9962         xlen and flen.
9963         (riscv_call_info) <xlen, flen>: Update comment.
9964         (riscv_call_arg_struct): Remove invalid assertions
9965         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
9966         is removed.
9967         (riscv_gdbarch_init): Gather isa features and abi features
9968         separately, ensure both match on the gdbarch when reusing an old
9969         gdbarch.  Relax an error check to allow 32-bit abi float to run on
9970         a target with 64-bit float hardware.
9971
9972 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9973
9974         * source.c (search_command_helper): Stop reverse search
9975         when line 1 has been searched.
9976
9977 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9978
9979         * record-full.c (record_full_base_target::close): Rewrite
9980         record_full_core_buf_list free logic.
9981
9982 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9983
9984         * break-catch-syscall.c (print_one_catch_syscall): xfree
9985         the last text.
9986
9987 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9988
9989         * top.c (print_gdb_version): Update Copyright year in version
9990         message.
9991
9992 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9993
9994         Update copyright year range in all GDB files.
9995
9996 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
9997
9998         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
9999
10000 For older changes see ChangeLog-2018.
10001 \f
10002 Local Variables:
10003 mode: change-log
10004 left-margin: 8
10005 fill-column: 74
10006 version-control: never
10007 coding: utf-8
10008 End:
10009