gdb/ChangeLog

   1 2018-05-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
   2
   3         * stack.c (print_frame_info): Fix comment.
   4
   5 2018-05-18  Tom Tromey  <tom@tromey.com>
   6
   7         * dwarf2read.c (struct dwz_file): Add constructor, initializers.
   8         <dwz_bfd>: Now a gdb_bfd_ref_ptr.
   9         (~dwarf2_per_objfile): Update
  10         (dwarf2_get_dwz_file): Use new.
  11         * dwarf2read.h (struct dwarf2_per_objfile) <dwz_file>: Now a
  12         unique_ptr.
  13
  14 2018-05-18  Tom Tromey  <tom@tromey.com>
  15
  16         * dwarf2read.h (struct dwarf2_per_objfile) <dwp_file>: Now a
  17         unique_ptr.
  18         * dwarf2read.c (struct dwp_file): Add constructor and
  19         initializers.
  20         (open_and_init_dwp_file): Return a unique_ptr.
  21         (dwarf2_per_objfile, create_dwp_hash_table)
  22         (create_dwo_unit_in_dwp_v1, create_dwo_unit_in_dwp_v2)
  23         (lookup_dwo_unit_in_dwp): Update.
  24         (open_and_init_dwp_file, get_dwp_file): Update.
  25
  26 2018-05-18  Tom Tromey  <tom@tromey.com>
  27
  28         * dwarf2read.c (dwarf2_per_objfile): Update.
  29         (struct mapped_index): Add initializers.
  30         (dwarf2_read_index): Use new.
  31         (dw2_symtab_iter_init): Update.
  32         * dwarf2read.h (struct dwarf2_per_objfile) <index_table>: Now a
  33         unique_ptr.
  34
  35 2018-05-18  Simon Marchi  <simon.marchi@ericsson.com>
  36
  37         * dwarf2read.c (mapped_index) <total_size>: Remove.
  38
  39 2018-05-18  Simon Marchi  <simon.marchi@ericsson.com>
  40
  41         * unittests/format_pieces-selftests.c (test_format_specifier):
  42         Add ARI comments.
  43
  44 2018-05-18  Tom Tromey  <tom@tromey.com>
  45
  46         * c-typeprint.c (maybe_print_hole): New function.
  47         (c_print_type_struct_field_offset): Update.
  48         (c_type_print_base_struct_union): Call maybe_print_hole.
  49
  50 2018-05-17  Keith Seitz  <keiths@redhat.com>
  51
  52         * breakpoint.c (build_bpstat_chain): New function, moved from
  53         bpstat_stop_status.
  54         (bpstat_stop_status): Add optional parameter, `stop_chain'.
  55         If no stop chain is passed, call build_bpstat_chain to build it.
  56         * breakpoint.h (build_bpstat_chain): Declare.
  57         (bpstat_stop_status): Move documentation here from breakpoint.c.
  58         * infrun.c (handle_signal_stop): Before eliding inlined frames,
  59         build the stop chain and pass it to skip_inline_frames.
  60         Pass this stop chain to bpstat_stop_status.
  61         * inline-frame.c: Include breakpoint.h.
  62         (stopped_by_user_bp_inline_frame): New function.
  63         (skip_inline_frames): Add parameter `stop_chain'.
  64         Move documention to inline-frame.h.
  65         If non-NULL, use stopped_by_user_bp_inline_frame to determine
  66         whether the frame should be elided.
  67         * inline-frame.h (skip_inline_frames): Add parameter `stop_chain'.
  68         Add moved documentation and update for new parameter.
  69
  70 2018-05-17  Simon Marchi  <simon.marchi@ericsson.com>
  71
  72         PR cli/14975
  73         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
  74         unittests/format_pieces-selftests.c.
  75         * common/format.h (format_piece) <operator==>: New.
  76         (format_pieces) <operator[]>: Remove.
  77         * common/format.c (format_pieces::format_pieces): Handle \e.
  78         * unittests/format_pieces-selftests.c: New.
  79
  80 2018-05-17  Tom Tromey  <tom@tromey.com>
  81
  82         PR symtab/23010:
  83         * dwarf2read.c (load_cu, dw2_do_instantiate_symtab)
  84         (dw2_instantiate_symtab): Add skip_partial parameter.
  85         (dw2_find_last_source_symtab, dw2_map_expand_apply)
  86         (dw2_lookup_symbol, dw2_expand_symtabs_for_function)
  87         (dw2_expand_all_symtabs, dw2_expand_symtabs_with_fullname)
  88         (dw2_expand_symtabs_matching_one)
  89         (dw2_find_pc_sect_compunit_symtab)
  90         (dw2_debug_names_lookup_symbol)
  91         (dw2_debug_names_expand_symtabs_for_function): Update.
  92         (init_cutu_and_read_dies): Add skip_partial parameter.
  93         (process_psymtab_comp_unit, build_type_psymtabs_1)
  94         (process_skeletonless_type_unit, load_partial_comp_unit)
  95         (psymtab_to_symtab_1): Update.
  96         (load_full_comp_unit): Add skip_partial parameter.
  97         (process_imported_unit_die, dwarf2_read_addr_index)
  98         (follow_die_offset, dwarf2_fetch_die_loc_sect_off)
  99         (dwarf2_fetch_constant_bytes, dwarf2_fetch_die_type_sect_off)
 100         (read_signatured_type): Update.
 101
 102 2018-05-17  Simon Marchi  <simon.marchi@ericsson.com>
 103
 104         * value.c (release_value): Remove unused variable.
 105         (record_latest_value): Likewise.
 106         (access_value_history): Likewise.
 107         (preserve_values): Likewise.
 108
 109 2018-05-17  Tom Tromey  <tom@tromey.com>
 110
 111         * extension.h (struct ext_lang_type_printers) <py_type_printers>:
 112         Initialize.
 113
 114 2018-05-16  Maciej W. Rozycki  <macro@mips.com>
 115
 116         PR gdb/22286
 117         * linux-nat-trad.c (linux_nat_trad_target::fetch_register):
 118         Also handle registers whose width is not a multiple of
 119         PTRACE_TYPE_RET.
 120         (linux_nat_trad_target::store_register): Likewise.
 121
 122 2018-05-16  Tom Tromey  <tom@tromey.com>
 123
 124         * gdbcore.h (core_bfd): Redefine.
 125         * corelow.c (core_target::close): Update.
 126         (core_target_open): Update.
 127         * progspace.h (struct program_space) <cbfd>: Now a
 128         gdb_bfd_ref_ptr.
 129
 130 2018-05-16  Tom Tromey  <tom@tromey.com>
 131
 132         PR cli/19551:
 133         * symfile-add-flags.h (enum symfile_add_flags)
 134         <SYMFILE_NOT_FILENAME>: New constant.
 135         * symfile.c (read_symbols): Use SYMFILE_NOT_FILENAME.  Get
 136         objfile name from BFD.
 137         (symbol_file_add_with_addrs): Check SYMFILE_NOT_FILENAME.
 138         * minidebug.c (find_separate_debug_file_in_section): Put
 139         ".gnu_debugdata" into BFD's file name.
 140
 141 2018-05-16  Simon Marchi  <simon.marchi@ericsson.com>
 142
 143         * regcache.c (regcache_read_ftype, regcache_write_ftype):
 144         Remove.
 145
 146 2018-05-15  Tamar Christina  <tamar.christina@arm.com>
 147
 148         PR binutils/21446
 149         * aarch64-tdep.c (aarch64_analyze_prologue,
 150         aarch64_software_single_step, aarch64_displaced_step_copy_insn):
 151         Indicate not interested in errors.
 152
 153 2018-05-15  Maciej W. Rozycki  <macro@mips.com>
 154
 155         * mips-linux-nat.c (mips_linux_nat_target::fetch_registers):
 156         Supply the MIPS_ZERO_REGNUM register.
 157
 158 2018-05-15  Maciej W. Rozycki  <macro@mips.com>
 159
 160         * mips-tdep.c (mask_address_var): Make variable static.
 161
 162 2018-05-14  Tom Tromey  <tom@tromey.com>
 163
 164         * dwarf2read.c (rust_union_quirks): Clear rust_unions.
 165
 166 2018-05-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 167
 168         * i387-tdep.c (i387_collect_xsave): Use FXSAVE_MXCSR_ADDR not
 169         FXSAVE_ADDR for the mxcsr register.
 170
 171 2018-05-11  Max Filippov  <jcmvbkbc@gmail.com>
 172
 173         * configure.tgt (xtensa*-*-linux*): Drop gdb_target definition.
 174
 175 2018-05-11  Pedro Alves  <palves@redhat.com>
 176
 177         * corelow.c (core_target) <core_target>: No longer inline.
 178         Initialize m_core_gdbarch, m_core_vec and build the section table
 179         here.
 180         <~core_target>: New.
 181         <core_gdbarch, get_core_register_section>: New methods.
 182         <m_core_section_table, m_core_vec, m_core_gdbarch>: New fields,
 183         factored out from ...
 184         <core_data, core_vec, core_gdbarch>: ... these deleted globals.
 185         (core_ops): Delete.
 186         (sniff_core_bfd): Add gdbarch parameter.
 187         (core_close): Delete, merged into ...
 188         (core_target::close): ... here.  Delete self.
 189         (core_close_cleanup): Delete.
 190         (core_target_open): Allocate a core_target on the heap.  Use a
 191         unique_ptr instead of a cleanup.  Bits moved into the core_target
 192         ctor.  Adjust to use core_target methods instead of globals.
 193         (get_core_register_section): Rename to ...
 194         (core_target::get_core_register_section): ... this and adjust.
 195         (struct get_core_registers_cb_data): New.
 196         (get_core_registers_cb): Use it.  Use bool.
 197         (core_target::fetch_registers, core_target::files_info)
 198         (core_target::xfer_partial, core_target::read_description)
 199         (core_target::pid_to, core_target::thread_name): Adjust to
 200         reference class fields instead of globals.
 201         * target.h (struct target_ops_deleter, target_ops_up): New.
 202
 203 2018-05-11  Pedro Alves  <palves@redhat.com>
 204
 205         * corefile.c (core_file_command): Move to corelow.c.
 206         * corelow.c (the_core_target): Delete.
 207         (core_file_command): Moved from corefile.c.  Check exec_bfd
 208         instead of the_core_target.  Use target_detach instead of calling
 209         into the_core_target directly.
 210         (maybe_say_no_core_file_now): New.
 211         (core_target::detach): Use it.
 212         (_initialize_corelow): Remove references to the_core_target.
 213         * gdbcore.h (the_core_target): Delete.
 214
 215 2018-05-11  Tom Tromey  <tromey@redhat.com>
 216             Pedro Alves  <palves@redhat.com>
 217
 218         * corefile.c (core_bfd): Remove.
 219         * gdbcore.h (core_bfd): Now a macro.
 220         * progspace.h (struct program_space) <cbfd>: New field.
 221
 222 2018-05-11  Tom Tromey  <tom@tromey.com>
 223
 224         * mdebugread.c (parse_partial_symbols, psymtab_to_symtab_1): Use
 225         gdb::def_vector.
 226
 227 2018-05-10  Tom Tromey  <tom@tromey.com>
 228
 229         * configure: Rebuild.
 230         * warning.m4 (AM_GDB_WARNINGS): Use -Wimplicit-fallthrough=3.
 231
 232 2018-05-10  Joel Brobecker  <brobecker@adacore.com>
 233
 234         PR server/23158:
 235         * regformats/regdat.sh: Adjust script, following the addition
 236         of the new expedite_regs parameter to init_target_desc.
 237
 238 2018-05-10  Omair Javaid  <omair.javaid@linaro.org>
 239
 240         PR gdb/23127
 241         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Add call to
 242         set_gdbarch_significant_addr_bit.
 243         * aarch64-tdep.c (aarch64_gdbarch_init): Remove call to
 244         set_gdbarch_significant_addr_bit.
 245         * utils.c (address_significant): Update to sign extend addr.
 246
 247 2018-05-09  Max Filippov  <jcmvbkbc@gmail.com>
 248
 249         * xtensa-linux-tdep.c (xtensa-tdep.h): New include.
 250         (xtensa_linux_init_abi): Limit tdep->num_regs by
 251         tdep->num_nopriv_regs.
 252         * xtensa-tdep.c (xtensa_derive_tdep): Calculate
 253         tdep->num_nopriv_regs and only copy it to tdep->num_regs if it's
 254         not initialized.
 255
 256 2018-05-08  Simon Marchi  <simon.marchi@ericsson.com>
 257
 258         * unittests/string_view-selftests.c: Define GNULIB_NAMESPACE.
 259
 260 2018-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 261
 262         * common/x86-xstate.h (I387_FCTRL_INIT_VAL): New constant.
 263         (I387_MXCSR_INIT_VAL): New constant.
 264         * amd64-tdep.c (amd64_supply_xsave): Only read state from xsave
 265         buffer if it was supplied by the inferior.
 266         * i387-tdep.c (i387_supply_fsave): Use I387_MXCSR_INIT_VAL.
 267         (i387_xsave_get_clear_bv): New function.
 268         (i387_supply_xsave): Only read x87 control registers from the
 269         xsave buffer if the feature is enabled, and the state will have
 270         been written, otherwise, provide a suitable default.
 271         (i387_collect_xsave): Pre-clear all registers in xsave buffer,
 272         including x87 control registers.  Update control registers if they
 273         have changed from the default value, and mark features as enabled
 274         as required.
 275         * i387-tdep.h (i387_xsave_get_clear_bv): Declare.
 276
 277 2018-05-08  Ulrich Weigand  <uweigand@de.ibm.com>
 278
 279         * spu-tdep.c (info_spu_event_command): Fix output formatting.
 280
 281 2018-05-07  Tom Tromey  <tom@tromey.com>
 282
 283         * configure: Rebuild.
 284         * warning.m4 (AM_GDB_WARNINGS): Add -Wduplicated-cond.
 285
 286 2018-05-07  Tom Tromey  <tom@tromey.com>
 287
 288         PR tdep/20362:
 289         * arm-tdep.c (arm_record_vfp_data_proc_insn): Properly mask off D
 290         bit.  Use correct value for VDIV.
 291
 292 2018-05-04  Tom Tromey  <tom@tromey.com>
 293
 294         * configure: Rebuild.
 295         * warning.m4 (AM_GDB_WARNINGS): Add -Wimplicit-fallthrough.
 296
 297 2018-05-04  Tom Tromey  <tom@tromey.com>
 298
 299         * linux-record.c (record_linux_system_call) <case
 300         RECORD_SYS_RECVFROM>: Add "break".
 301
 302 2018-05-04  Tom Tromey  <tom@tromey.com>
 303
 304         * mi/mi-main.c (mi_cmd_trace_frame_collected) <REGISTERS_FORMAT>:
 305         Add missing "break".
 306         * mi/mi-cmd-stack.c (mi_cmd_stack_list_locals) <NO_FRAME_FILTERS>:
 307         Add missing "break".
 308
 309 2018-05-04  Tom Tromey  <tom@tromey.com>
 310
 311         * rs6000-tdep.c (ppc_process_record_op4)
 312         (ppc_process_record_op63): Add fall-through comment.
 313
 314 2018-05-04  Tom Tromey  <tom@tromey.com>
 315
 316         * i386-tdep.c (i386_process_record): Add fall-through comment.
 317
 318 2018-05-04  Tom Tromey  <tom@tromey.com>
 319
 320         * stabsread.c (define_symbol) <case 'p'>: Add fall-through
 321         comment.
 322
 323 2018-05-04  Tom Tromey  <tom@tromey.com>
 324
 325         * riscv-tdep.c (riscv_isa_xlen): Add fall-through comment.
 326         * utils.c (can_dump_core) <LIMIT_CUR>: Add fall-through comment.
 327         * eval.c (fetch_subexp_value) <MEMORY_ERROR>: Add fall-through
 328         comment.
 329         * d-valprint.c (d_val_print) <TYPE_CODE_STRUCT>: Add fall-through
 330         comment.
 331         * coffread.c (coff_symtab_read) <C_LABEL>: Add fall-through
 332         comment.
 333
 334 2018-05-04  Tom Tromey  <tom@tromey.com>
 335
 336         * dwarf2loc.c (unimplemented): Add ATTRIBUTE_NORETURN.
 337
 338 2018-05-04  Tom Tromey  <tom@tromey.com>
 339
 340         * s390-tdep.c (s390_process_record): Fix fall-through comments.
 341         * xcoffread.c (scan_xcoff_symtab): Move comment later.
 342         * symfile.c (section_is_mapped): Fix fall-through comment.
 343         * stabsread.c (define_symbol, read_member_functions): Fix
 344         fall-through comment.
 345         * s390-linux-tdep.c (s390_process_record): Fix fall-through
 346         comment.
 347         * remote.c (remote_wait_as): Fix fall-through comment.
 348         * p-exp.y (yylex): Fix fall-through comment.
 349         * nat/x86-dregs.c (x86_length_and_rw_bits): Fix fall-through
 350         comment.
 351         * msp430-tdep.c (msp430_gdbarch_init): Fix fall-through comment.
 352         * mdebugread.c (parse_partial_symbols): Fix fall-through comment.
 353         * jv-exp.y (yylex): Fix fall-through comment.
 354         * go-exp.y (lex_one_token): Fix fall-through comment.
 355         * gdbtypes.c (get_discrete_bounds, rank_one_type): Fix
 356         fall-through comment.
 357         * f-exp.y (yylex): Fix fall-through comment.
 358         * dwarf2read.c (process_die): Fix fall-through comments.
 359         * dbxread.c (process_one_symbol): Fix fall-through comment.
 360         * d-exp.y (lex_one_token): Fix fall-through comment.
 361         * cp-name-parser.y (yylex): Fix fall-through comment.
 362         * coffread.c (coff_symtab_read): Fix fall-through comment.
 363         * c-exp.y (lex_one_token): Fix fall-through comment.
 364         * arm-tdep.c (arm_decode_miscellaneous): Fix fall-through
 365         comment.
 366         * arch/arm.c (arm_instruction_changes_pc): Fix fall-through
 367         comment.
 368
 369 2018-05-04  Tom Tromey  <tom@tromey.com>
 370
 371         PR python/22730:
 372         * NEWS: Mention gdb.execute change.
 373         * gdbcmd.h (execute_control_command): Don't declare.
 374         * python/python.c (execute_gdb_command): Use read_command_lines_1,
 375         execute_control_commands, execute_control_commands_to_string.
 376         * cli/cli-script.h (execute_control_commands)
 377         (execute_control_commands_to_string): Declare.
 378         (execute_control_command): Add from_tty parameter.
 379         * cli/cli-script.c (execute_control_commands)
 380         (execute_control_commands_to_string): New functions.
 381         (execute_user_command): Use execute_control_commands.
 382         (execute_control_command_1): Add "from_tty" parameter.  Update.
 383         (execute_control_command): Likewise.
 384
 385 2018-05-04  Tom Tromey  <tom@tromey.com>
 386
 387         PR python/22731:
 388         * NEWS: Mention that breakpoint commands are writable.
 389         * python/py-breakpoint.c (bppy_set_commands): New function.
 390         (breakpoint_object_getset) <"commands">: Use it.
 391
 392 2018-05-04  Tom Tromey  <tom@tromey.com>
 393
 394         * tracepoint.c (actions_command): Update.
 395         * mi/mi-cmd-break.c (mi_command_line_array)
 396         (mi_command_line_array_cnt, mi_command_line_array_ptr)
 397         (mi_read_next_line): Remove.
 398         (mi_cmd_break_commands): Update.
 399         * cli/cli-script.h (read_command_lines, read_command_lines_1): Use
 400         function_view.
 401         * cli/cli-script.c (get_command_line): Update.
 402         (process_next_line): Use function_view.  Constify.
 403         (recurse_read_control_structure, read_command_lines)
 404         (read_command_lines_1): Change argument types to function_view.
 405         (do_define_command, document_command): Update.
 406         * breakpoint.h (check_tracepoint_command): Don't declare.
 407         * breakpoint.c (check_tracepoint_command): Remove.
 408         (commands_command_1, create_tracepoint_from_upload): Update.
 409
 410 2018-05-04  Tom Tromey  <tom@tromey.com>
 411
 412         PR gdb/11750:
 413         * cli/cli-script.h (enum command_control_type) <define_control>:
 414         New constant.
 415         * cli/cli-script.c (multi_line_command_p): Handle define_control.
 416         (build_command_line, execute_control_command_1)
 417         (process_next_line): Likewise.
 418         (do_define_command): New function, extracted from define_command.
 419         (define_command): Use it.
 420
 421 2018-05-04  Tom Tromey  <tom@tromey.com>
 422
 423         * tracepoint.c (actions_command): Update.
 424         * cli/cli-script.h (read_command_lines): Update.
 425         * cli/cli-script.c (read_command_lines): Constify prompt_arg.
 426         (MAX_TMPBUF): Remove define.
 427         (define_command): Use string_printf.
 428         (document_command): Likewise.
 429         * breakpoint.c (commands_command_1): Update.
 430
 431 2018-05-04  Tom Tromey  <tom@tromey.com>
 432
 433         * top.c (execute_command): Update.
 434         * cli/cli-script.h (print_command_lines): Now varargs.
 435         * cli/cli-script.c (print_command_lines): Now varargs.
 436         (execute_control_command_1) <case while_control, case if_control>:
 437         Update.
 438
 439 2018-05-04  Tom Tromey  <tom@tromey.com>
 440
 441         * tracepoint.c (all_tracepoint_actions): Rename from
 442         all_tracepoint_actions_and_cleanup.  Change return type.
 443         (actions_command, encode_actions_1, encode_actions)
 444         (trace_dump_actions, tdump_command): Update.
 445         * remote.c (remote_download_command_source): Update.
 446         * python/python.c (gdbpy_eval_from_control_command)
 447         (python_command, python_interactive_command): Update.
 448         * mi/mi-cmd-break.c (mi_cmd_break_commands): Update.
 449         * guile/guile.c (guile_command)
 450         (gdbscm_eval_from_control_command, guile_command): Update.
 451         * compile/compile.c (compile_code_command)
 452         (compile_print_command, compile_to_object): Update.
 453         * cli/cli-script.h (struct command_lines_deleter): New.
 454         (counted_command_line): New typedef.
 455         (struct command_line): Add constructor, destructor.
 456         <body_list>: Remove.
 457         <body_list_0, body_list_1>: New members.
 458         (command_line_up): Remove typedef.
 459         (read_command_lines, read_command_lines_1, get_command_line):
 460         Update.
 461         (copy_command_lines): Don't declare.
 462         * cli/cli-script.c (build_command_line): Use "new".
 463         (get_command_line): Return counted_command_line.
 464         (print_command_lines, execute_user_command)
 465         (execute_control_command_1, while_command, if_command): Update.
 466         (realloc_body_list): Remove.
 467         (process_next_line, recurse_read_control_structure): Update.
 468         (read_command_lines, read_command_lines_1): Return counted_command_line.
 469         (free_command_lines): Use "delete".
 470         (copy_command_lines): Remove.
 471         (define_command, document_command, show_user_1): Update.
 472         * cli/cli-decode.h (struct cmd_list_element) <user_commands>: Now
 473         a counted_command_line.
 474         * breakpoint.h (counted_command_line): Remove typedef.
 475         (breakpoint_set_commands): Update.
 476         * breakpoint.c (check_no_tracepoint_commands)
 477         (validate_commands_for_breakpoint): Update.
 478         (breakpoint_set_commands): Change commands to be a
 479         counted_command_line.
 480         (commands_command_1, update_dprintf_command_list)
 481         (create_tracepoint_from_upload): Update.
 482
 483 2018-05-04  Tom Tromey  <tom@tromey.com>
 484
 485         * cli/cli-decode.h (cmd_list_element): New constructor.
 486         (~cmd_list_element): New destructor.
 487         (struct cmd_list_element): Add initializers.
 488         * cli/cli-decode.c (do_add_cmd): Use "new".
 489         (delete_cmd): Use "delete".
 490
 491 2018-05-04  Jan Kratochvil  <jan.kratochvil@redhat.com>
 492             Pedro Alves <palves@redhat.com>
 493
 494         PR breakpoints/19806 and support for PR external/20207.
 495         * NEWS: Mention Aarch64 watchpoint improvements.
 496         * aarch64-linux-nat.c (aarch64_linux_stopped_data_address): Fix missed
 497         watchpoints and PR external/20207 watchpoints.
 498         * nat/aarch64-linux-hw-point.c
 499         (kernel_supports_any_contiguous_range): New.
 500         (aarch64_watchpoint_offset): New.
 501         (aarch64_watchpoint_length): Support PR external/20207 watchpoints.
 502         (aarch64_point_encode_ctrl_reg): New parameter offset, new asserts.
 503         (aarch64_point_is_aligned): Support PR external/20207 watchpoints.
 504         (aarch64_align_watchpoint): New parameters aligned_offset_p and
 505         next_addr_orig_p.  Support PR external/20207 watchpoints.
 506         (aarch64_downgrade_regs): New.
 507         (aarch64_dr_state_insert_one_point): New parameters offset and
 508         addr_orig.
 509         (aarch64_dr_state_remove_one_point): Likewise.
 510         (aarch64_handle_breakpoint): Update caller.
 511         (aarch64_handle_aligned_watchpoint): Likewise.
 512         (aarch64_handle_unaligned_watchpoint): Support addr_orig and
 513         aligned_offset.
 514         (aarch64_linux_set_debug_regs): Remove const from state.  Call
 515         aarch64_downgrade_regs.
 516         (aarch64_show_debug_reg_state): Print also dr_addr_orig_wp.
 517         * nat/aarch64-linux-hw-point.h (DR_CONTROL_LENGTH): Rename to ...
 518         (DR_CONTROL_MASK): ... this.
 519         (struct aarch64_debug_reg_state): New field dr_addr_orig_wp.
 520         (unsigned int aarch64_watchpoint_offset): New prototype.
 521         (aarch64_linux_set_debug_regs): Remove const from state.
 522         * utils.c (align_up, align_down): Move to ...
 523         * common/common-utils.c (align_up, align_down): ... here.
 524         * utils.h (align_up, align_down): Move to ...
 525         * common/common-utils.h (align_up, align_down): ... here.
 526
 527 2018-05-04  Joel Brobecker  <brobecker@adacore.com>
 528
 529         * sparc-tdep.c (sparc_structure_return_p): Re-implement to
 530         match the ABI as summarized in GCC's gcc/config/sparc/sparc.c.
 531         (sparc_arg_by_memory_p): Renamed from sparc_arg_on_registers_p.
 532         Re-implement to match the ABI as summarized in GCC's
 533         gcc/config/sparc/sparc.c.  All callers updated.
 534         (sparc32_store_arguments): Remove assertion.
 535
 536 2018-05-04  Tom Tromey  <tom@tromey.com>
 537
 538         * printcmd.c: Don't include tui.h.
 539         (decode_format): Use skip_spaces.
 540
 541 2018-05-04  Tom Tromey  <tom@tromey.com>
 542
 543         PR gdb/22619:
 544         * printcmd.c (last_count): New global.
 545         (x_command): Use saved count when repeating.
 546
 547 2018-05-04  Tom Tromey  <tom@tromey.com>
 548
 549         * nto-procfs.c (do_closedir_cleanup): Remove.
 550         (procfs_pidlist): Use gdb_dir_up.
 551         * procfs.c (do_closedir_cleanup): Remove.
 552         (proc_update_threads): Use gdb_dir_up.
 553         * common/filestuff.h (struct gdb_dir_deleter): New.
 554         (gdb_dir_up): New typedef.
 555
 556 2018-05-04  Tom Tromey  <tom@tromey.com>
 557
 558         * ada-lang.c (print_mention_exception): Use std::string.
 559
 560 2018-05-04  Tom Tromey  <tom@tromey.com>
 561
 562         * ada-lang.c (create_excep_cond_exprs): Update.
 563         (ada_exception_catchpoint_cond_string): Use std::string.
 564
 565 2018-05-04  Tom Tromey  <tom@tromey.com>
 566
 567         * ada-lang.c (xget_renaming_scope): Return std::string.
 568         (old_renaming_is_invisible): Update.
 569
 570 2018-05-04  Tom Tromey  <tom@tromey.com>
 571
 572         * bfd-target.c (target_bfd::m_bfd): Now a gdb_bfd_ref_ptr.
 573         (target_bfd::target_bfd, target_bfd::~target_bfd): Update.
 574
 575 2018-05-04  Ulrich Weigand  <uweigand@de.ibm.com>
 576
 577         * spu-linux-nat.c (spu_linux_nat_target::wait): Fix syntax error.
 578
 579 2018-05-04  Tom Tromey  <tom@tromey.com>
 580
 581         * remote.c (remote_query_supported_append): Change type.
 582         (remote_check_symbols): Update.
 583
 584 2018-05-04  Paul Pluzhnikov  <ppluzhnikov@google.com>
 585
 586         PR gdb/11420
 587         * configure.ac: Prepend libpython.
 588         * python/python-config.py: Likewise.
 589         * configure: Regenerate.
 590
 591 2018-05-03  Simon Marchi  <simon.marchi@ericsson.com>
 592
 593         * Makefile.in (%.c: %.l): Use -t instead of --stdout.
 594
 595 2018-05-03  Pedro Alves  <palves@redhat.com>
 596
 597         * s390-linux-nat.c
 598         (s390_linux_nat_target::have_continuable_watchpoint): Mark with
 599         override.  Write 'true' instead of '1'.
 600         (s390_linux_nat_target::watchpoint_addr_within_range): Remove
 601         declaration.
 602
 603 2018-05-02  Pedro Alves  <palves@redhat.com>
 604
 605         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Use
 606         add_inf_child_target.
 607         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Use
 608         add_inf_child_target.
 609         * aix-thread.c (aix_thread_target_info): New.
 610         (aix_thread_target) <shortname, longname, doc>: Delete.
 611         <info>: New.
 612         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Use
 613         add_inf_child_target.
 614         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Use
 615         add_inf_child_target.
 616         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Use
 617         add_inf_child_target.
 618         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Use
 619         add_inf_child_target.
 620         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Use
 621         add_inf_child_target.
 622         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Use
 623         add_inf_child_target.
 624         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Use
 625         add_inf_child_target.
 626         * arm-linux-nat.c (_initialize_arm_linux_nat): Use
 627         add_inf_child_target.
 628         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Use
 629         add_inf_child_target.
 630         * bfd-target.c (target_bfd_target_info): New.
 631         (target_bfd) <shortname, longname, doc>: Delete.
 632         <info>: New.
 633         * bsd-kvm.c (bsd_kvm_target_info): New.
 634         (bsd_kvm_target) <shortname, longname, doc>: Delete.
 635         <info>: New.
 636         (bsd_kvm_target::open): Rename to ...
 637         (bsd_kvm_target_open): ... this.  Adjust.
 638         * bsd-uthread.c (bsd_uthread_target_info): New.
 639         (bsd_uthread_target) <shortname, longname, doc>: Delete.
 640         <info>: New.
 641         * corefile.c (core_file_command): Adjust.
 642         * corelow.c (core_target_info): New.
 643         (core_target) <shortname, longname, doc>: Delete.
 644         <info>: New.
 645         (core_target::open): Rename to ...
 646         (core_target_open): ... this.  Adjust.
 647         * ctf.c (ctf_target_info): New.
 648         (ctf_target) <shortname, longname, doc>: Delete.
 649         <info>: New.
 650         (ctf_target::open): Rename to ...
 651         (ctf_target_open): ... this.
 652         (_initialize_ctf): Adjust.
 653         * exec.c (exec_target_info): New.
 654         (exec_target) <shortname, longname, doc>: Delete.
 655         <info>: New.
 656         (exec_target::open): Rename to ...
 657         (exec_target_open): ... this.
 658         * gdbcore.h (core_target_open): Declare.
 659         * go32-nat.c (_initialize_go32_nat): Use add_inf_child_target.
 660         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Use
 661         add_inf_child_target.
 662         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Use
 663         add_inf_child_target.
 664         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Use
 665         add_inf_child_target.
 666         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Use
 667         add_inf_child_target.
 668         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Use
 669         add_inf_child_target.
 670         * i386-gnu-nat.c (_initialize_i386gnu_nat): Use
 671         add_inf_child_target.
 672         * i386-linux-nat.c (_initialize_i386_linux_nat): Use
 673         add_inf_child_target.
 674         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Use
 675         add_inf_child_target.
 676         * i386-obsd-nat.c (_initialize_i386obsd_nat): Use
 677         add_inf_child_target.
 678         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Use
 679         add_inf_child_target.
 680         * inf-child.c (inf_child_target_info): New.
 681         (inf_child_target::info): New.
 682         (inf_child_open_target): Remove 'target' parameter.  Use
 683         get_native_target instead.
 684         (inf_child_target::open): Delete.
 685         (add_inf_child_target): New.
 686         * inf-child.h (inf_child_target) <shortname, longname, doc, open>:
 687         Delete.
 688         <info>: New.
 689         (add_inf_child_target): Declare.
 690         (inf_child_open_target): Declare.
 691         * linux-thread-db.c (thread_db_target_info): New.
 692         (thread_db_target) <shortname, longname, doc>: Delete.
 693         <info>: New.
 694         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Use
 695         add_inf_child_target.
 696         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Use
 697         add_inf_child_target.
 698         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Use
 699         add_inf_child_target.
 700         * m88k-bsd-nat.c (_initialize_m88kbsd_nat): Use
 701         add_inf_child_target.
 702         * make-target-delegates (print_class): Adjust.
 703         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Use
 704         add_inf_child_target.
 705         * mips-linux-nat.c (_initialize_mips_linux_nat): Use
 706         add_inf_child_target.
 707         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Use
 708         add_inf_child_target.
 709         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Use
 710         add_inf_child_target.
 711         * nto-procfs.c (nto_native_target_info): New.
 712         (nto_procfs_target_native) <shortname, longname, doc>:
 713         Delete.
 714         <info>: New.
 715         (nto_procfs_target_info): New.
 716         (nto_procfs_target_procfs) <shortname, longname, doc>:
 717         Delete.
 718         <info>: New.
 719         (init_procfs_targets): Adjust.
 720         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Use
 721         add_inf_child_target.
 722         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Use
 723         add_inf_child_target.
 724         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Use
 725         add_inf_child_target.
 726         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Use
 727         add_inf_child_target.
 728         * ravenscar-thread.c (ravenscar_target_info): New.
 729         (ravenscar_thread_target) <shortname, longname, doc>:
 730         Delete.
 731         <info>: New.
 732         * record-btrace.c (record_btrace_target_info):
 733         (record_btrace_target) <shortname, longname, doc>: Delete.
 734         <info>: New.
 735         (record_btrace_target::open): Rename to ...
 736         (record_btrace_target_open): ... this.  Adjust.
 737         * record-full.c (record_longname, record_doc): New.
 738         (record_full_base_target) <shortname, longname, doc>: Delete.
 739         <info>: New.
 740         (record_full_target_info): New.
 741         (record_full_target): <shortname>: Delete.
 742         <info>: New.
 743         (record_full_core_open_1, record_full_open_1): Update comments.
 744         (record_full_base_target::open): Rename to ...
 745         (record_full_open): ... this.
 746         (cmd_record_full_restore): Update.
 747         (_initialize_record_full): Update.
 748         * remote-sim.c (remote_sim_target_info): New.
 749         (gdbsim_target) <shortname, longname, doc>: Delete.
 750         <info>: New.
 751         (gdbsim_target::open): Rename to ...
 752         (gdbsim_target_open): ... this.
 753         (_initialize_remote_sim): Adjust.
 754         * remote.c (remote_doc): New.
 755         (remote_target_info): New.
 756         (remote_target) <shortname, longname, doc>: Delete.
 757         <info>: New.
 758         (extended_remote_target_info): New.
 759         (extended_remote_target) <shortname, longname, doc>: Delete.
 760         <info>: New.
 761         (remote_target::open_1): Make static.  Adjust.
 762         * rs6000-nat.c (_initialize_rs6000_nat): Use add_inf_child_target.
 763         * s390-linux-nat.c (_initialize_s390_nat): Use
 764         add_inf_child_target.
 765         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Use
 766         add_inf_child_target.
 767         * sol-thread.c (thread_db_target_info): New.
 768         (sol_thread_target) <shortname, longname, doc>: Delete.
 769         <info>: New.
 770         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Use
 771         add_inf_child_target.
 772         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Use
 773         add_inf_child_target.
 774         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Use
 775         add_inf_child_target.
 776         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Use
 777         add_inf_child_target.
 778         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Use
 779         add_inf_child_target.
 780         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Use
 781         add_inf_child_target.
 782         * spu-linux-nat.c (_initialize_spu_nat): Use
 783         add_inf_child_target.
 784         * spu-multiarch.c (spu_multiarch_target_info): New.
 785         (spu_multiarch_target) <shortname, longname, doc>: Delete.
 786         <info>: New.
 787         * target-delegates.c: Regenerate.
 788         * target.c: Include <unordered_map>.
 789         (target_ops_p): Delete.
 790         (DEF_VEC_P(target_ops_p)): Delete.
 791         (target_factories): New.
 792         (test_target_info): New.
 793         (test_target_ops::info): New.
 794         (open_target): Adjust to use target_factories.
 795         (add_target_with_completer): Rename to ...
 796         (add_target): ... this.  Change prototype.  Register target_info
 797         and open callback in target_factories.  Register target_info in
 798         command context instead of target_ops.
 799         (add_target): Delete old implementation.
 800         (add_deprecated_target_alias): Change prototype.  Adjust.
 801         (the_native_target): New.
 802         (set_native_target, get_native_target): New.
 803         (find_default_run_target): Use the_native_target.
 804         (find_attach_target, find_run_target): Simplify.
 805         (target_ops::open): Delete.
 806         (dummy_target_info): New.
 807         (dummy_target::shortname, dummy_target::longname)
 808         (dummy_target::doc): Delete.
 809         (dummy_target::info): New.
 810         (debug_target::shortname, debug_target::longname)
 811         (debug_target::doc): Delete.
 812         (debug_target::info): New.
 813         * target.h (struct target_info): New.
 814         (target_ops::~target_ops): Add comment.
 815         (target_ops::info): New.
 816         (target_ops::shortname, target_ops::longname, target_ops::doc): No
 817         longer virtual.  Implement in terms of target_info.
 818         (set_native_target, get_native_target): Declare.
 819         (target_open_ftype): New.
 820         (add_target, add_target_with_completer)
 821         (add_deprecated_target_alias): Change prototype.
 822         (test_target) <shortname, longname, doc>: Delete.
 823         <info>: New.
 824         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Use
 825         add_inf_child_target.
 826         * tracefile-tfile.c (tfile_target_info): New.
 827         (tfile_target) <shortname, longname, doc>: Delete.
 828         <info>: New.
 829         (tfile_target::open): Rename to ...
 830         (tfile_target_open): ... this.
 831         (_initialize_tracefile_tfile): Adjust.
 832         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Use
 833         add_inf_child_target.
 834         * windows-nat.c (_initialize_windows_nat): Use
 835         add_inf_child_target.
 836         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Use
 837         add_inf_child_target.
 838
 839 2018-05-02  Pedro Alves  <palves@redhat.com>
 840
 841         * linux-nat.h (linux_nat_target) <low_new_thread,
 842         low_delete_thread, low_new_fork, low_forget_process,
 843         low_prepare_to_resume, low_siginfo_fixup, low_status_is_event>:
 844         New virtual methods.
 845         (linux_nat_set_new_thread, linux_nat_set_delete_thread)
 846         (linux_nat_new_fork_ftype, linux_nat_set_new_fork)
 847         (linux_nat_forget_process_ftype, linux_nat_set_forget_process)
 848         (linux_nat_forget_process, linux_nat_set_siginfo_fixup)
 849         (linux_nat_set_prepare_to_resume, linux_nat_set_status_is_event):
 850         Delete.
 851         * linux-fork.c (delete_fork): Adjust to call low method.
 852         * linux-nat.c (linux_nat_new_thread, linux_nat_delete_thread)
 853         (linux_nat_new_fork, linux_nat_forget_process_hook)
 854         (linux_nat_prepare_to_resume, linux_nat_siginfo_fixup)
 855         (linux_nat_status_is_event):
 856         (linux_nat_target::follow_fork, lwp_free, add_lwp, detach_one_lwp)
 857         (linux_resume_one_lwp_throw, linux_handle_extended_wait): Adjust
 858         to call low method.
 859         (sigtrap_is_event): Rename to ...
 860         (linux_nat_target::low_status_is_event): ... this.
 861         (linux_nat_set_status_is_event): Delete.
 862         (save_stop_reason, linux_nat_wait_1)
 863         (linux_nat_target::mourn_inferior, siginfo_fixup): Adjust to call
 864         low methods.
 865         (linux_nat_set_new_thread, linux_nat_set_delete_thread)
 866         (linux_nat_set_new_fork, linux_nat_set_forget_process)
 867         (linux_nat_forget_process, linux_nat_set_siginfo_fixup)
 868         (linux_nat_set_prepare_to_resume): Delete.
 869         * aarch64-linux-nat.c: All linux_nat_set_* callbacks converted to
 870         low virtual methods.
 871         * amd64-linux-nat.c: Likewise.
 872         * arm-linux-nat.c: Likewise.
 873         * i386-linux-nat.c: Likewise.
 874         * ia64-linux-nat.c: Likewise.
 875         * mips-linux-nat.c: Likewise.
 876         * ppc-linux-nat.c: Likewise.
 877         * s390-linux-nat.c: Likewise.
 878         * sparc64-linux-nat.c: Likewise.
 879         * x86-linux-nat.c: Likewise.
 880         * x86-linux-nat.h: Include "nat/x86-linux.h".
 881         (x86_linux_nat_target) <low_new_fork, low_forget_process,
 882         low_prepare_to_resume, low_new_thread, low_delete_thread>:
 883         Override methods.
 884
 885 2018-05-02  Pedro Alves  <palves@redhat.com>
 886
 887         * target.h (target_ops)
 888         <stopped_by_sw_breakpoint, supports_stopped_by_sw_breakpoint,
 889         stopped_by_hw_breakpoint, supports_stopped_by_hw_breakpoint,
 890         stopped_by_watchpoint, have_continuable_watchpoint,
 891         stopped_data_address, watchpoint_addr_within_range,
 892         can_accel_watchpoint_condition, can_run, thread_alive,
 893         has_all_memory, has_memory, has_stack, has_registers,
 894         has_execution, can_async_p, is_async_p, supports_non_stop,
 895         always_non_stop_p, can_execute_reverse, supports_multi_process,
 896         supports_enable_disable_tracepoint,
 897         supports_disable_randomization, supports_string_tracing,
 898         supports_evaluation_of_breakpoint_conditions,
 899         can_run_breakpoint_commands, filesystem_is_local,
 900         can_download_tracepoint, get_trace_state_variable_value,
 901         set_trace_notes, get_tib_address, use_agent, can_use_agent,
 902         record_is_replaying, record_will_replay,
 903         augmented_libraries_svr4_read>: Adjust to return bool.
 904         * aarch64-linux-nat.c: All implementations adjusted.
 905         * aix-thread.c: All implementations adjusted.
 906         * arm-linux-nat.c: All implementations adjusted.
 907         * breakpoint.c: All implementations adjusted.
 908         * bsd-kvm.c: All implementations adjusted.
 909         * bsd-uthread.c: All implementations adjusted.
 910         * corelow.c: All implementations adjusted.
 911         * ctf.c: All implementations adjusted.
 912         * darwin-nat.c: All implementations adjusted.
 913         * darwin-nat.h: All implementations adjusted.
 914         * exec.c: All implementations adjusted.
 915         * fbsd-nat.c: All implementations adjusted.
 916         * fbsd-nat.h: All implementations adjusted.
 917         * gnu-nat.c: All implementations adjusted.
 918         * gnu-nat.h: All implementations adjusted.
 919         * go32-nat.c: All implementations adjusted.
 920         * ia64-linux-nat.c: All implementations adjusted.
 921         * inf-child.c: All implementations adjusted.
 922         * inf-child.h: All implementations adjusted.
 923         * inf-ptrace.c: All implementations adjusted.
 924         * inf-ptrace.h: All implementations adjusted.
 925         * linux-nat.c: All implementations adjusted.
 926         * linux-nat.h: All implementations adjusted.
 927         * mips-linux-nat.c: All implementations adjusted.
 928         * nto-procfs.c: All implementations adjusted.
 929         * ppc-linux-nat.c: All implementations adjusted.
 930         * procfs.c: All implementations adjusted.
 931         * ravenscar-thread.c: All implementations adjusted.
 932         * record-btrace.c: All implementations adjusted.
 933         * record-full.c: All implementations adjusted.
 934         * remote-sim.c: All implementations adjusted.
 935         * remote.c: All implementations adjusted.
 936         * s390-linux-nat.c: All implementations adjusted.
 937         * sol-thread.c: All implementations adjusted.
 938         * spu-multiarch.c: All implementations adjusted.
 939         * target-delegates.c: All implementations adjusted.
 940         * target.c: All implementations adjusted.
 941         * target.h: All implementations adjusted.
 942         * tracefile-tfile.c: All implementations adjusted.
 943         * tracefile.c: All implementations adjusted.
 944         * tracefile.h: All implementations adjusted.
 945         * windows-nat.c: All implementations adjusted.
 946         * x86-linux-nat.h: All implementations adjusted.
 947         * x86-nat.h: All implementations adjusted.
 948
 949 2018-05-02  Pedro Alves  <palves@redhat.com>
 950
 951         * make-target-delegates (scan_target_h): Don't trim lines here.
 952         Replace sequences of tabs and/or whitespace with a single
 953         whitespace.
 954         (top level, parsing methods): Trim each line before processing it
 955         here.
 956
 957 2018-05-02  Pedro Alves  <palves@redhat.com>
 958             John Baldwin  <jhb@freebsd.org>
 959
 960         * target.h (enum strata) <debug_stratum>: New.
 961         (struct target_ops) <all delegation methods>: Replace by C++
 962         virtual methods, and drop "to_" prefix.  All references updated
 963         throughout.
 964         <to_shortname, to_longname, to_doc, to_data,
 965         to_have_steppable_watchpoint, to_have_continuable_watchpoint,
 966         to_has_thread_control, to_attach_no_wait>: Delete, replaced by
 967         virtual methods.  All references updated throughout.
 968         <can_attach, supports_terminal_ours, can_create_inferior,
 969         get_thread_control_capabilities, attach_no_wait>: New
 970         virtual methods.
 971         <insert_breakpoint, remove_breakpoint>: Now
 972         TARGET_DEFAULT_NORETURN methods.
 973         <info_proc>: Now returns bool.
 974         <to_magic>: Delete.
 975         (OPS_MAGIC): Delete.
 976         (current_target): Delete.  All references replaced by references
 977         to ...
 978         (target_stack): ... this.  New.
 979         (target_shortname, target_longname): Adjust.
 980         (target_can_run): Now a function declaration.
 981         (default_child_has_all_memory, default_child_has_memory)
 982         (default_child_has_stack, default_child_has_registers)
 983         (default_child_has_execution): Remove target_ops parameter.
 984         (complete_target_initialization): Delete.
 985         (memory_breakpoint_target): New template class.
 986         (test_target_ops): Refactor as a C++ class with virtual methods.
 987         * make-target-delegates (NAME_PART): Tighten.
 988         (POINTER_PART, CP_SYMBOL): New.
 989         (SIMPLE_RETURN_PART): Reimplement.
 990         (VEC_RETURN_PART): Expect less.
 991         (RETURN_PART, VIRTUAL_PART): New.
 992         (METHOD): Adjust to C++ virtual methods.
 993         (scan_target_h): Remove reference to C99.
 994         (dname): Output "target_ops::" prefix.
 995         (write_function_header): Adjust to output a C++ class method.
 996         (write_declaration): New.
 997         (write_delegator): Adjust to output a C++ class method.
 998         (tdname): Output "dummy_target::" prefix.
 999         (write_tdefault, write_debugmethod): Adjust to output a C++ class
1000         method.
1001         (tdefault_names, debug_names): Delete.
1002         (return_types, tdefaults, styles, argtypes_array): New.
1003         (top level): All methods are delegators.
1004         (print_class): New.
1005         (top level): Print dummy_target and debug_target classes.
1006         * target-delegates.c: Regenerate.
1007         * target-debug.h (target_debug_print_enum_info_proc_what)
1008         (target_debug_print_thread_control_capabilities)
1009         (target_debug_print_thread_info_p): New.
1010         * target.c (dummy_target): Delete.
1011         (the_dummy_target, the_debug_target): New.
1012         (target_stack): Now extern.
1013         (set_targetdebug): Push/unpush debug target.
1014         (default_child_has_all_memory, default_child_has_memory)
1015         (default_child_has_stack, default_child_has_registers)
1016         (default_child_has_execution): Remove target_ops parameter.
1017         (complete_target_initialization): Delete.
1018         (add_target_with_completer): No longer call
1019         complete_target_initialization.
1020         (target_supports_terminal_ours): Use regular delegation.
1021         (update_current_target): Delete.
1022         (push_target): No longer check magic number.  Don't call
1023         update_current_target.
1024         (unpush_target): Don't call update_current_target.
1025         (target_is_pushed): No longer check magic number.
1026         (target_require_runnable): Skip for all stratums over
1027         process_stratum.
1028         (target_ops::info_proc): New.
1029         (target_info_proc): Use find_target_at and
1030         find_default_run_target.
1031         (target_supports_disable_randomization): Use regular delegation.
1032         (target_get_osdata): Use find_target_at.
1033         (target_ops::open, target_ops::close, target_ops::can_attach)
1034         (target_ops::attach, target_ops::can_create_inferior)
1035         (target_ops::create_inferior, target_ops::can_run)
1036         (target_can_run): New.
1037         (default_fileio_target): Use regular delegation.
1038         (target_ops::fileio_open, target_ops::fileio_pwrite)
1039         (target_ops::fileio_pread, target_ops::fileio_fstat)
1040         (target_ops::fileio_close, target_ops::fileio_unlink)
1041         (target_ops::fileio_readlink): New.
1042         (target_fileio_open_1, target_fileio_unlink)
1043         (target_fileio_readlink): Always call the target method.  Handle
1044         FILEIO_ENOSYS.
1045         (return_zero, return_zero_has_execution): Delete.
1046         (init_dummy_target): Delete.
1047         (dummy_target::dummy_target, dummy_target::shortname)
1048         (dummy_target::longname, dummy_target::doc)
1049         (debug_target::debug_target, debug_target::shortname)
1050         (debug_target::longname, debug_target::doc): New.
1051         (target_supports_delete_record): Use regular delegation.
1052         (setup_target_debug): Delete.
1053         (maintenance_print_target_stack): Skip debug_stratum.
1054         (initialize_targets): Instantiate the_dummy_target and
1055         the_debug_target.
1056         * auxv.c (target_auxv_parse): Remove 'ops' parameter.  Adjust to
1057         use target_stack.
1058         (target_auxv_search, fprint_target_auxv): Adjust.
1059         (info_auxv_command): Adjust to use target_stack.
1060         * auxv.h (target_auxv_parse): Remove 'ops' parameter.
1061         * exceptions.c (print_flush): Handle a NULL target_stack.
1062         * regcache.c (target_ops_no_register): Refactor as class with
1063         virtual methods.
1064
1065         * exec.c (exec_target): New class.
1066         (exec_ops): Now an exec_target.
1067         (exec_open, exec_close_1, exec_get_section_table)
1068         (exec_xfer_partial, exec_files_info, exec_has_memory)
1069         (exec_make_note_section): Refactor as exec_target methods.
1070         (exec_file_clear, ignore, exec_remove_breakpoint, init_exec_ops):
1071         Delete.
1072         (exec_target::find_memory_regions): New.
1073         (_initialize_exec): Don't call init_exec_ops.
1074         * gdbcore.h (exec_file_clear): Delete.
1075
1076         * corefile.c (core_target): Delete.
1077         (core_file_command): Adjust.
1078         * corelow.c (core_target): New class.
1079         (the_core_target): New.
1080         (core_close): Remove target_ops parameter.
1081         (core_close_cleanup): Adjust.
1082         (core_target::close): New.
1083         (core_open, core_detach, get_core_registers, core_files_info)
1084         (core_xfer_partial, core_thread_alive, core_read_description)
1085         (core_pid_to_str, core_thread_name, core_has_memory)
1086         (core_has_stack, core_has_registers, core_info_proc): Rework as
1087         core_target methods.
1088         (ignore, core_remove_breakpoint, init_core_ops): Delete.
1089         (_initialize_corelow): Initialize the_core_target.
1090         * gdbcore.h (core_target): Delete.
1091         (the_core_target): New.
1092
1093         * ctf.c: (ctf_target): New class.
1094         (ctf_ops): Now a ctf_target.
1095         (ctf_open, ctf_close, ctf_files_info, ctf_fetch_registers)
1096         (ctf_xfer_partial, ctf_get_trace_state_variable_value)
1097         (ctf_trace_find, ctf_traceframe_info): Refactor as ctf_target
1098         methods.
1099         (init_ctf_ops): Delete.
1100         (_initialize_ctf): Don't call it.
1101         * tracefile-tfile.c (tfile_target): New class.
1102         (tfile_ops): Now a tfile_target.
1103         (tfile_open, tfile_close, tfile_files_info)
1104         (tfile_get_tracepoint_status, tfile_trace_find)
1105         (tfile_fetch_registers, tfile_xfer_partial)
1106         (tfile_get_trace_state_variable_value, tfile_traceframe_info):
1107         Refactor as tfile_target methods.
1108         (tfile_xfer_partial_features): Remove target_ops parameter.
1109         (init_tfile_ops): Delete.
1110         (_initialize_tracefile_tfile): Don't call it.
1111         * tracefile.c (tracefile_has_all_memory, tracefile_has_memory)
1112         (tracefile_has_stack, tracefile_has_registers)
1113         (tracefile_thread_alive, tracefile_get_trace_status): Refactor as
1114         tracefile_target methods.
1115         (init_tracefile_ops): Delete.
1116         (tracefile_target::tracefile_target): New.
1117         * tracefile.h: Include "target.h".
1118         (tracefile_target): New class.
1119         (init_tracefile_ops): Delete.
1120
1121         * spu-multiarch.c (spu_multiarch_target): New class.
1122         (spu_ops): Now a spu_multiarch_target.
1123         (spu_thread_architecture, spu_region_ok_for_hw_watchpoint)
1124         (spu_fetch_registers, spu_store_registers, spu_xfer_partial)
1125         (spu_search_memory, spu_mourn_inferior): Refactor as
1126         spu_multiarch_target methods.
1127         (init_spu_ops): Delete.
1128         (_initialize_spu_multiarch): Remove references to init_spu_ops,
1129         complete_target_initialization.
1130
1131         * ravenscar-thread.c (ravenscar_thread_target): New class.
1132         (ravenscar_ops): Now a ravenscar_thread_target.
1133         (ravenscar_resume, ravenscar_wait, ravenscar_update_thread_list)
1134         (ravenscar_thread_alive, ravenscar_pid_to_str)
1135         (ravenscar_fetch_registers, ravenscar_store_registers)
1136         (ravenscar_prepare_to_store, ravenscar_stopped_by_sw_breakpoint)
1137         (ravenscar_stopped_by_hw_breakpoint)
1138         (ravenscar_stopped_by_watchpoint, ravenscar_stopped_data_address)
1139         (ravenscar_mourn_inferior, ravenscar_core_of_thread)
1140         (ravenscar_get_ada_task_ptid): Refactor as ravenscar_thread_target
1141         methods.
1142         (init_ravenscar_thread_ops): Delete.
1143         (_initialize_ravenscar): Remove references to
1144         init_ravenscar_thread_ops and complete_target_initialization.
1145
1146         * bsd-uthread.c (bsd_uthread_ops_hack): Delete.
1147         (bsd_uthread_target): New class.
1148         (bsd_uthread_ops): Now a bsd_uthread_target.
1149         (bsd_uthread_activate): Adjust to refer to bsd_uthread_ops.
1150         (bsd_uthread_close, bsd_uthread_mourn_inferior)
1151         (bsd_uthread_fetch_registers, bsd_uthread_store_registers)
1152         (bsd_uthread_wait, bsd_uthread_resume, bsd_uthread_thread_alive)
1153         (bsd_uthread_update_thread_list, bsd_uthread_extra_thread_info)
1154         (bsd_uthread_pid_to_str): Refactor as bsd_uthread_target methods.
1155         (bsd_uthread_target): Delete function.
1156         (_initialize_bsd_uthread): Remove reference to
1157         complete_target_initialization.
1158
1159         * bfd-target.c (target_bfd_data): Delete.  Fields folded into ...
1160         (target_bfd): ... this new class.
1161         (target_bfd_xfer_partial, target_bfd_get_section_table)
1162         (target_bfd_close): Refactor as target_bfd methods.
1163         (target_bfd::~target_bfd): New.
1164         (target_bfd_reopen): Adjust.
1165         (target_bfd::close): New.
1166
1167         * record-btrace.c (record_btrace_target): New class.
1168         (record_btrace_ops): Now a record_btrace_target.
1169         (record_btrace_open, record_btrace_stop_recording)
1170         (record_btrace_disconnect, record_btrace_close)
1171         (record_btrace_async, record_btrace_info)
1172         (record_btrace_insn_history, record_btrace_insn_history_range)
1173         (record_btrace_insn_history_from, record_btrace_call_history)
1174         (record_btrace_call_history_range)
1175         (record_btrace_call_history_from, record_btrace_record_method)
1176         (record_btrace_is_replaying, record_btrace_will_replay)
1177         (record_btrace_xfer_partial, record_btrace_insert_breakpoint)
1178         (record_btrace_remove_breakpoint, record_btrace_fetch_registers)
1179         (record_btrace_store_registers, record_btrace_prepare_to_store)
1180         (record_btrace_to_get_unwinder)
1181         (record_btrace_to_get_tailcall_unwinder, record_btrace_resume)
1182         (record_btrace_commit_resume, record_btrace_wait)
1183         (record_btrace_stop, record_btrace_can_execute_reverse)
1184         (record_btrace_stopped_by_sw_breakpoint)
1185         (record_btrace_supports_stopped_by_sw_breakpoint)
1186         (record_btrace_stopped_by_hw_breakpoint)
1187         (record_btrace_supports_stopped_by_hw_breakpoint)
1188         (record_btrace_update_thread_list, record_btrace_thread_alive)
1189         (record_btrace_goto_begin, record_btrace_goto_end)
1190         (record_btrace_goto, record_btrace_stop_replaying_all)
1191         (record_btrace_execution_direction)
1192         (record_btrace_prepare_to_generate_core)
1193         (record_btrace_done_generating_core): Refactor as
1194         record_btrace_target methods.
1195         (init_record_btrace_ops): Delete.
1196         (_initialize_record_btrace): Remove reference to
1197         init_record_btrace_ops.
1198         * record-full.c (RECORD_FULL_IS_REPLAY): Adjust to always refer to
1199         the execution_direction global.
1200         (record_full_base_target, record_full_target)
1201         (record_full_core_target): New classes.
1202         (record_full_ops): Now a record_full_target.
1203         (record_full_core_ops): Now a record_full_core_target.
1204         (record_full_target::detach, record_full_target::disconnect)
1205         (record_full_core_target::disconnect)
1206         (record_full_target::mourn_inferior, record_full_target::kill):
1207         New.
1208         (record_full_open, record_full_close, record_full_async): Refactor
1209         as methods of the record_full_base_target class.
1210         (record_full_resume, record_full_commit_resume): Refactor
1211         as methods of the record_full_target class.
1212         (record_full_wait, record_full_stopped_by_watchpoint)
1213         (record_full_stopped_data_address)
1214         (record_full_stopped_by_sw_breakpoint)
1215         (record_full_supports_stopped_by_sw_breakpoint)
1216         (record_full_stopped_by_hw_breakpoint)
1217         (record_full_supports_stopped_by_hw_breakpoint): Refactor as
1218         methods of the record_full_base_target class.
1219         (record_full_store_registers, record_full_xfer_partial)
1220         (record_full_insert_breakpoint, record_full_remove_breakpoint):
1221         Refactor as methods of the record_full_target class.
1222         (record_full_can_execute_reverse, record_full_get_bookmark)
1223         (record_full_goto_bookmark, record_full_execution_direction)
1224         (record_full_record_method, record_full_info, record_full_delete)
1225         (record_full_is_replaying, record_full_will_replay)
1226         (record_full_goto_begin, record_full_goto_end, record_full_goto)
1227         (record_full_stop_replaying): Refactor as methods of the
1228         record_full_base_target class.
1229         (record_full_core_resume, record_full_core_kill)
1230         (record_full_core_fetch_registers)
1231         (record_full_core_prepare_to_store)
1232         (record_full_core_store_registers, record_full_core_xfer_partial)
1233         (record_full_core_insert_breakpoint)
1234         (record_full_core_remove_breakpoint)
1235         (record_full_core_has_execution): Refactor
1236         as methods of the record_full_core_target class.
1237         (record_full_base_target::supports_delete_record): New.
1238         (init_record_full_ops): Delete.
1239         (init_record_full_core_ops): Delete.
1240         (record_full_save): Refactor as method of the
1241         record_full_base_target class.
1242         (_initialize_record_full): Remove references to
1243         init_record_full_ops and init_record_full_core_ops.
1244
1245         * remote.c (remote_target, extended_remote_target): New classes.
1246         (remote_ops): Now a remote_target.
1247         (extended_remote_ops): Now an extended_remote_target.
1248         (remote_insert_fork_catchpoint, remote_remove_fork_catchpoint)
1249         (remote_insert_vfork_catchpoint, remote_remove_vfork_catchpoint)
1250         (remote_insert_exec_catchpoint, remote_remove_exec_catchpoint)
1251         (remote_pass_signals, remote_set_syscall_catchpoint)
1252         (remote_program_signals, )
1253         (remote_thread_always_alive): Remove target_ops parameter.
1254         (remote_thread_alive, remote_thread_name)
1255         (remote_update_thread_list, remote_threads_extra_info)
1256         (remote_static_tracepoint_marker_at)
1257         (remote_static_tracepoint_markers_by_strid)
1258         (remote_get_ada_task_ptid, remote_close, remote_start_remote)
1259         (remote_open): Refactor as methods of remote_target.
1260         (extended_remote_open, extended_remote_detach)
1261         (extended_remote_attach, extended_remote_post_attach):
1262         (extended_remote_supports_disable_randomization)
1263         (extended_remote_create_inferior): : Refactor as method of
1264         extended_remote_target.
1265         (remote_set_permissions, remote_open_1, remote_detach)
1266         (remote_follow_fork, remote_follow_exec, remote_disconnect)
1267         (remote_resume, remote_commit_resume, remote_stop)
1268         (remote_interrupt, remote_pass_ctrlc, remote_terminal_inferior)
1269         (remote_terminal_ours, remote_wait, remote_fetch_registers)
1270         (remote_prepare_to_store, remote_store_registers)
1271         (remote_flash_erase, remote_flash_done, remote_files_info)
1272         (remote_kill, remote_mourn, remote_insert_breakpoint)
1273         (remote_remove_breakpoint, remote_insert_watchpoint)
1274         (remote_watchpoint_addr_within_range)
1275         (remote_remove_watchpoint, remote_region_ok_for_hw_watchpoint)
1276         (remote_check_watch_resources, remote_stopped_by_sw_breakpoint)
1277         (remote_supports_stopped_by_sw_breakpoint)
1278         (remote_stopped_by_hw_breakpoint)
1279         (remote_supports_stopped_by_hw_breakpoint)
1280         (remote_stopped_by_watchpoint, remote_stopped_data_address)
1281         (remote_insert_hw_breakpoint, remote_remove_hw_breakpoint)
1282         (remote_verify_memory): Refactor as methods of remote_target.
1283         (remote_write_qxfer, remote_read_qxfer): Remove target_ops
1284         parameter.
1285         (remote_xfer_partial, remote_get_memory_xfer_limit)
1286         (remote_search_memory, remote_rcmd, remote_memory_map)
1287         (remote_pid_to_str, remote_get_thread_local_address)
1288         (remote_get_tib_address, remote_read_description): Refactor as
1289         methods of remote_target.
1290         (remote_target::fileio_open, remote_target::fileio_pwrite)
1291         (remote_target::fileio_pread, remote_target::fileio_close): New.
1292         (remote_hostio_readlink, remote_hostio_fstat)
1293         (remote_filesystem_is_local, remote_can_execute_reverse)
1294         (remote_supports_non_stop, remote_supports_disable_randomization)
1295         (remote_supports_multi_process, remote_supports_cond_breakpoints)
1296         (remote_supports_enable_disable_tracepoint)
1297         (remote_supports_string_tracing)
1298         (remote_can_run_breakpoint_commands, remote_trace_init)
1299         (remote_download_tracepoint, remote_can_download_tracepoint)
1300         (remote_download_trace_state_variable, remote_enable_tracepoint)
1301         (remote_disable_tracepoint, remote_trace_set_readonly_regions)
1302         (remote_trace_start, remote_get_trace_status)
1303         (remote_get_tracepoint_status, remote_trace_stop)
1304         (remote_trace_find, remote_get_trace_state_variable_value)
1305         (remote_save_trace_data, remote_get_raw_trace_data)
1306         (remote_set_disconnected_tracing, remote_core_of_thread)
1307         (remote_set_circular_trace_buffer, remote_traceframe_info)
1308         (remote_get_min_fast_tracepoint_insn_len)
1309         (remote_set_trace_buffer_size, remote_set_trace_notes)
1310         (remote_use_agent, remote_can_use_agent, remote_enable_btrace)
1311         (remote_disable_btrace, remote_teardown_btrace)
1312         (remote_read_btrace, remote_btrace_conf)
1313         (remote_augmented_libraries_svr4_read, remote_load)
1314         (remote_pid_to_exec_file, remote_can_do_single_step)
1315         (remote_execution_direction, remote_thread_handle_to_thread_info):
1316         Refactor as methods of remote_target.
1317         (init_remote_ops, init_extended_remote_ops): Delete.
1318         (remote_can_async_p, remote_is_async_p, remote_async)
1319         (remote_thread_events, remote_upload_tracepoints)
1320         (remote_upload_trace_state_variables): Refactor as methods of
1321         remote_target.
1322         (_initialize_remote): Remove references to init_remote_ops and
1323         init_extended_remote_ops.
1324
1325         * remote-sim.c (gdbsim_target): New class.
1326         (gdbsim_fetch_register, gdbsim_store_register, gdbsim_kill)
1327         (gdbsim_load, gdbsim_create_inferior, gdbsim_open, gdbsim_close)
1328         (gdbsim_detach, gdbsim_resume, gdbsim_interrupt)
1329         (gdbsim_wait, gdbsim_prepare_to_store, gdbsim_xfer_partial)
1330         (gdbsim_files_info, gdbsim_mourn_inferior, gdbsim_thread_alive)
1331         (gdbsim_pid_to_str, gdbsim_has_all_memory, gdbsim_has_memory):
1332         Refactor as methods of gdbsim_target.
1333         (gdbsim_ops): Now a gdbsim_target.
1334         (init_gdbsim_ops): Delete.
1335         (gdbsim_cntrl_c): Adjust.
1336         (_initialize_remote_sim): Remove reference to init_gdbsim_ops.
1337
1338         * amd64-linux-nat.c (amd64_linux_nat_target): New class.
1339         (the_amd64_linux_nat_target): New.
1340         (amd64_linux_fetch_inferior_registers)
1341         (amd64_linux_store_inferior_registers): Refactor as methods of
1342         amd64_linux_nat_target.
1343         (_initialize_amd64_linux_nat): Adjust.  Set linux_target.
1344         * i386-linux-nat.c: Don't include "linux-nat.h".
1345         (i386_linux_nat_target): New class.
1346         (the_i386_linux_nat_target): New.
1347         (i386_linux_fetch_inferior_registers)
1348         (i386_linux_store_inferior_registers, i386_linux_resume): Refactor
1349         as methods of i386_linux_nat_target.
1350         (_initialize_i386_linux_nat): Adjust.  Set linux_target.
1351         * inf-child.c (inf_child_ops): Delete.
1352         (inf_child_fetch_inferior_registers)
1353         (inf_child_store_inferior_registers): Delete.
1354         (inf_child_post_attach, inf_child_prepare_to_store): Refactor as
1355         methods of inf_child_target.
1356         (inf_child_target::supports_terminal_ours)
1357         (inf_child_target::terminal_init)
1358         (inf_child_target::terminal_inferior)
1359         (inf_child_target::terminal_ours_for_output)
1360         (inf_child_target::terminal_ours, inf_child_target::interrupt)
1361         (inf_child_target::pass_ctrlc, inf_child_target::terminal_info):
1362         New.
1363         (inf_child_open, inf_child_disconnect, inf_child_close)
1364         (inf_child_mourn_inferior, inf_child_maybe_unpush_target)
1365         (inf_child_post_startup_inferior, inf_child_can_run)
1366         (inf_child_pid_to_exec_file): Refactor as methods of
1367         inf_child_target.
1368         (inf_child_follow_fork): Delete.
1369         (inf_child_target::can_create_inferior)
1370         (inf_child_target::can_attach): New.
1371         (inf_child_target::has_all_memory, inf_child_target::has_memory)
1372         (inf_child_target::has_stack, inf_child_target::has_registers)
1373         (inf_child_target::has_execution): New.
1374         (inf_child_fileio_open, inf_child_fileio_pwrite)
1375         (inf_child_fileio_pread, inf_child_fileio_fstat)
1376         (inf_child_fileio_close, inf_child_fileio_unlink)
1377         (inf_child_fileio_readlink, inf_child_use_agent)
1378         (inf_child_can_use_agent): Refactor as methods of
1379         inf_child_target.
1380         (return_zero, inf_child_target): Delete.
1381         (inf_child_target::inf_child_target): New.
1382         * inf-child.h: Include "target.h".
1383         (inf_child_target): Delete function prototype.
1384         (inf_child_target): New class.
1385         (inf_child_open_target, inf_child_mourn_inferior)
1386         (inf_child_maybe_unpush_target): Delete.
1387         * inf-ptrace.c (inf_ptrace_target::~inf_ptrace_target): New.
1388         (inf_ptrace_follow_fork, inf_ptrace_insert_fork_catchpoint)
1389         (inf_ptrace_remove_fork_catchpoint, inf_ptrace_create_inferior)
1390         (inf_ptrace_post_startup_inferior, inf_ptrace_mourn_inferior)
1391         (inf_ptrace_attach, inf_ptrace_post_attach, inf_ptrace_detach)
1392         (inf_ptrace_detach_success, inf_ptrace_kill, inf_ptrace_resume)
1393         (inf_ptrace_wait, inf_ptrace_xfer_partial)
1394         (inf_ptrace_thread_alive, inf_ptrace_files_info)
1395         (inf_ptrace_pid_to_str, inf_ptrace_auxv_parse): Refactor as
1396         methods of inf_ptrace_target.
1397         (inf_ptrace_target): Delete function.
1398         * inf-ptrace.h: Include "inf-child.h".
1399         (inf_ptrace_target): Delete function declaration.
1400         (inf_ptrace_target): New class.
1401         (inf_ptrace_trad_target, inf_ptrace_detach_success): Delete.
1402         * linux-nat.c (linux_target): New.
1403         (linux_ops, linux_ops_saved, super_xfer_partial): Delete.
1404         (linux_nat_target::~linux_nat_target): New.
1405         (linux_child_post_attach, linux_child_post_startup_inferior)
1406         (linux_child_follow_fork, linux_child_insert_fork_catchpoint)
1407         (linux_child_remove_fork_catchpoint)
1408         (linux_child_insert_vfork_catchpoint)
1409         (linux_child_remove_vfork_catchpoint)
1410         (linux_child_insert_exec_catchpoint)
1411         (linux_child_remove_exec_catchpoint)
1412         (linux_child_set_syscall_catchpoint, linux_nat_pass_signals)
1413         (linux_nat_create_inferior, linux_nat_attach, linux_nat_detach)
1414         (linux_nat_resume, linux_nat_stopped_by_watchpoint)
1415         (linux_nat_stopped_data_address)
1416         (linux_nat_stopped_by_sw_breakpoint)
1417         (linux_nat_supports_stopped_by_sw_breakpoint)
1418         (linux_nat_stopped_by_hw_breakpoint)
1419         (linux_nat_supports_stopped_by_hw_breakpoint, linux_nat_wait)
1420         (linux_nat_kill, linux_nat_mourn_inferior)
1421         (linux_nat_xfer_partial, linux_nat_thread_alive)
1422         (linux_nat_update_thread_list, linux_nat_pid_to_str)
1423         (linux_nat_thread_name, linux_child_pid_to_exec_file)
1424         (linux_child_static_tracepoint_markers_by_strid)
1425         (linux_nat_is_async_p, linux_nat_can_async_p)
1426         (linux_nat_supports_non_stop, linux_nat_always_non_stop_p)
1427         (linux_nat_supports_multi_process)
1428         (linux_nat_supports_disable_randomization, linux_nat_async)
1429         (linux_nat_stop, linux_nat_close, linux_nat_thread_address_space)
1430         (linux_nat_core_of_thread, linux_nat_filesystem_is_local)
1431         (linux_nat_fileio_open, linux_nat_fileio_readlink)
1432         (linux_nat_fileio_unlink, linux_nat_thread_events): Refactor as
1433         methods of linux_nat_target.
1434         (linux_nat_wait_1, linux_xfer_siginfo, linux_proc_xfer_partial)
1435         (linux_proc_xfer_spu, linux_nat_xfer_osdata): Remove target_ops
1436         parameter.
1437         (check_stopped_by_watchpoint): Adjust.
1438         (linux_xfer_partial): Delete.
1439         (linux_target_install_ops, linux_target, linux_nat_add_target):
1440         Delete.
1441         (linux_nat_target::linux_nat_target): New.
1442         * linux-nat.h: Include "inf-ptrace.h".
1443         (linux_nat_target): New.
1444         (linux_target, linux_target_install_ops, linux_nat_add_target):
1445         Delete function declarations.
1446         (linux_target): Declare global.
1447         * linux-thread-db.c (thread_db_target): New.
1448         (thread_db_target::thread_db_target): New.
1449         (thread_db_ops): Delete.
1450         (the_thread_db_target): New.
1451         (thread_db_detach, thread_db_wait, thread_db_mourn_inferior)
1452         (thread_db_update_thread_list, thread_db_pid_to_str)
1453         (thread_db_extra_thread_info)
1454         (thread_db_thread_handle_to_thread_info)
1455         (thread_db_get_thread_local_address, thread_db_get_ada_task_ptid)
1456         (thread_db_resume): Refactor as methods of thread_db_target.
1457         (init_thread_db_ops): Delete.
1458         (_initialize_thread_db): Remove reference to init_thread_db_ops.
1459         * x86-linux-nat.c: Don't include "linux-nat.h".
1460         (super_post_startup_inferior): Delete.
1461         (x86_linux_nat_target::~x86_linux_nat_target): New.
1462         (x86_linux_child_post_startup_inferior)
1463         (x86_linux_read_description, x86_linux_enable_btrace)
1464         (x86_linux_disable_btrace, x86_linux_teardown_btrace)
1465         (x86_linux_read_btrace, x86_linux_btrace_conf): Refactor as
1466         methods of x86_linux_nat_target.
1467         (x86_linux_create_target): Delete.  Bits folded ...
1468         (x86_linux_add_target): ... here.  Now takes a linux_nat_target
1469         pointer.
1470         * x86-linux-nat.h: Include "linux-nat.h" and "x86-nat.h".
1471         (x86_linux_nat_target): New class.
1472         (x86_linux_create_target): Delete.
1473         (x86_linux_add_target): Now takes a linux_nat_target pointer.
1474         * x86-nat.c (x86_insert_watchpoint, x86_remove_watchpoint)
1475         (x86_region_ok_for_watchpoint, x86_stopped_data_address)
1476         (x86_stopped_by_watchpoint, x86_insert_hw_breakpoint)
1477         (x86_remove_hw_breakpoint, x86_can_use_hw_breakpoint)
1478         (x86_stopped_by_hw_breakpoint): Remove target_ops parameter and
1479         make extern.
1480         (x86_use_watchpoints): Delete.
1481         * x86-nat.h: Include "breakpoint.h" and "target.h".
1482         (x86_use_watchpoints): Delete.
1483         (x86_can_use_hw_breakpoint, x86_region_ok_for_hw_watchpoint)
1484         (x86_stopped_by_watchpoint, x86_stopped_data_address)
1485         (x86_insert_watchpoint, x86_remove_watchpoint)
1486         (x86_insert_hw_breakpoint, x86_remove_hw_breakpoint)
1487         (x86_stopped_by_hw_breakpoint): New declarations.
1488         (x86_nat_target): New template class.
1489
1490         * ppc-linux-nat.c (ppc_linux_nat_target): New class.
1491         (the_ppc_linux_nat_target): New.
1492         (ppc_linux_fetch_inferior_registers)
1493         (ppc_linux_can_use_hw_breakpoint)
1494         (ppc_linux_region_ok_for_hw_watchpoint)
1495         (ppc_linux_ranged_break_num_registers)
1496         (ppc_linux_insert_hw_breakpoint, ppc_linux_remove_hw_breakpoint)
1497         (ppc_linux_insert_mask_watchpoint)
1498         (ppc_linux_remove_mask_watchpoint)
1499         (ppc_linux_can_accel_watchpoint_condition)
1500         (ppc_linux_insert_watchpoint, ppc_linux_remove_watchpoint)
1501         (ppc_linux_stopped_data_address, ppc_linux_stopped_by_watchpoint)
1502         (ppc_linux_watchpoint_addr_within_range)
1503         (ppc_linux_masked_watch_num_registers)
1504         (ppc_linux_store_inferior_registers, ppc_linux_auxv_parse)
1505         (ppc_linux_read_description): Refactor as methods of
1506         ppc_linux_nat_target.
1507         (_initialize_ppc_linux_nat): Adjust.  Set linux_target.
1508
1509         * procfs.c (procfs_xfer_partial): Delete forward declaration.
1510         (procfs_target): New class.
1511         (the_procfs_target): New.
1512         (procfs_target): Delete function.
1513         (procfs_auxv_parse, procfs_attach, procfs_detach)
1514         (procfs_fetch_registers, procfs_store_registers, procfs_wait)
1515         (procfs_xfer_partial, procfs_resume, procfs_pass_signals)
1516         (procfs_files_info, procfs_kill_inferior, procfs_mourn_inferior)
1517         (procfs_create_inferior, procfs_update_thread_list)
1518         (procfs_thread_alive, procfs_pid_to_str)
1519         (procfs_can_use_hw_breakpoint, procfs_stopped_by_watchpoint)
1520         (procfs_stopped_data_address, procfs_insert_watchpoint)
1521         (procfs_remove_watchpoint, procfs_region_ok_for_hw_watchpoint)
1522         (proc_find_memory_regions, procfs_info_proc)
1523         (procfs_make_note_section): Refactor as methods of procfs_target.
1524         (_initialize_procfs): Adjust.
1525         * sol-thread.c (sol_thread_target): New class.
1526         (sol_thread_ops): Now a sol_thread_target.
1527         (sol_thread_detach, sol_thread_resume, sol_thread_wait)
1528         (sol_thread_fetch_registers, sol_thread_store_registers)
1529         (sol_thread_xfer_partial, sol_thread_mourn_inferior)
1530         (sol_thread_alive, solaris_pid_to_str, sol_update_thread_list)
1531         (sol_get_ada_task_ptid): Refactor as methods of sol_thread_target.
1532         (init_sol_thread_ops): Delete.
1533         (_initialize_sol_thread): Adjust.  Remove references to
1534         init_sol_thread_ops and complete_target_initialization.
1535
1536         * windows-nat.c (windows_nat_target): New class.
1537         (windows_fetch_inferior_registers)
1538         (windows_store_inferior_registers, windows_resume, windows_wait)
1539         (windows_attach, windows_detach, windows_pid_to_exec_file)
1540         (windows_files_info, windows_create_inferior)
1541         (windows_mourn_inferior, windows_interrupt, windows_kill_inferior)
1542         (windows_close, windows_pid_to_str, windows_xfer_partial)
1543         (windows_get_tib_address, windows_get_ada_task_ptid)
1544         (windows_thread_name, windows_thread_alive): Refactor as
1545         windows_nat_target methods.
1546         (do_initial_windows_stuff): Adjust.
1547         (windows_target): Delete function.
1548         (_initialize_windows_nat): Adjust.
1549
1550         * darwin-nat.c (darwin_resume, darwin_wait_to, darwin_interrupt)
1551         (darwin_mourn_inferior, darwin_kill_inferior)
1552         (darwin_create_inferior, darwin_attach, darwin_detach)
1553         (darwin_pid_to_str, darwin_thread_alive, darwin_xfer_partial)
1554         (darwin_pid_to_exec_file, darwin_get_ada_task_ptid)
1555         (darwin_supports_multi_process): Refactor as darwin_nat_target
1556         methods.
1557         (darwin_resume_to, darwin_files_info): Delete.
1558         (_initialize_darwin_inferior): Rename to ...
1559         (_initialize_darwin_nat): ... this.  Adjust to C++ification.
1560         * darwin-nat.h: Include "inf-child.h".
1561         (darwin_nat_target): New class.
1562         (darwin_complete_target): Delete.
1563         * i386-darwin-nat.c (i386_darwin_nat_target): New class.
1564         (darwin_target): New.
1565         (i386_darwin_fetch_inferior_registers)
1566         (i386_darwin_store_inferior_registers): Refactor as methods of
1567         darwin_nat_target.
1568         (darwin_complete_target): Delete, with ...
1569         (_initialize_i386_darwin_nat): ... bits factored out here.
1570
1571         * alpha-linux-nat.c (alpha_linux_nat_target): New class.
1572         (the_alpha_linux_nat_target): New.
1573         (alpha_linux_register_u_offset): Refactor as
1574         alpha_linux_nat_target method.
1575         (_initialize_alpha_linux_nat): Adjust.
1576         * linux-nat-trad.c (inf_ptrace_register_u_offset): Delete.
1577         (inf_ptrace_fetch_register, inf_ptrace_fetch_registers)
1578         (inf_ptrace_store_register, inf_ptrace_store_registers): Refact as
1579         methods of linux_nat_trad_target.
1580         (linux_trad_target): Delete.
1581         * linux-nat-trad.h (linux_trad_target): Delete function.
1582         (linux_nat_trad_target): New class.
1583         * mips-linux-nat.c (mips_linux_nat_target): New class.
1584         (super_fetch_registers, super_store_registers, super_close):
1585         Delete.
1586         (the_mips_linux_nat_target): New.
1587         (mips64_linux_regsets_fetch_registers)
1588         (mips64_linux_regsets_store_registers)
1589         (mips64_linux_fetch_registers, mips64_linux_store_registers)
1590         (mips_linux_register_u_offset, mips_linux_read_description)
1591         (mips_linux_can_use_hw_breakpoint)
1592         (mips_linux_stopped_by_watchpoint)
1593         (mips_linux_stopped_data_address)
1594         (mips_linux_region_ok_for_hw_watchpoint)
1595         (mips_linux_insert_watchpoint, mips_linux_remove_watchpoint)
1596         (mips_linux_close): Refactor as methods of mips_linux_nat.
1597         (_initialize_mips_linux_nat): Adjust to C++ification.
1598
1599         * aix-thread.c (aix_thread_target): New class.
1600         (aix_thread_ops): Now an aix_thread_target.
1601         (aix_thread_detach, aix_thread_resume, aix_thread_wait)
1602         (aix_thread_fetch_registers, aix_thread_store_registers)
1603         (aix_thread_xfer_partial, aix_thread_mourn_inferior)
1604         (aix_thread_thread_alive, aix_thread_pid_to_str)
1605         (aix_thread_extra_thread_info, aix_thread_get_ada_task_ptid):
1606         Refactor as methods of aix_thread_target.
1607         (init_aix_thread_ops): Delete.
1608         (_initialize_aix_thread): Remove references to init_aix_thread_ops
1609         and complete_target_initialization.
1610         * rs6000-nat.c (rs6000_xfer_shared_libraries): Delete.
1611         (rs6000_nat_target): New class.
1612         (the_rs6000_nat_target): New.
1613         (rs6000_fetch_inferior_registers, rs6000_store_inferior_registers)
1614         (rs6000_xfer_partial, rs6000_wait, rs6000_create_inferior)
1615         (rs6000_xfer_shared_libraries): Refactor as rs6000_nat_target methods.
1616         (super_create_inferior): Delete.
1617         (_initialize_rs6000_nat): Adjust to C++ification.
1618
1619         * arm-linux-nat.c (arm_linux_nat_target): New class.
1620         (the_arm_linux_nat_target): New.
1621         (arm_linux_fetch_inferior_registers)
1622         (arm_linux_store_inferior_registers, arm_linux_read_description)
1623         (arm_linux_can_use_hw_breakpoint, arm_linux_insert_hw_breakpoint)
1624         (arm_linux_remove_hw_breakpoint)
1625         (arm_linux_region_ok_for_hw_watchpoint)
1626         (arm_linux_insert_watchpoint, arm_linux_remove_watchpoint)
1627         (arm_linux_stopped_data_address, arm_linux_stopped_by_watchpoint)
1628         (arm_linux_watchpoint_addr_within_range): Refactor as methods of
1629         arm_linux_nat_target.
1630         (_initialize_arm_linux_nat): Adjust to C++ification.
1631
1632         * aarch64-linux-nat.c (aarch64_linux_nat_target): New class.
1633         (the_aarch64_linux_nat_target): New.
1634         (aarch64_linux_fetch_inferior_registers)
1635         (aarch64_linux_store_inferior_registers)
1636         (aarch64_linux_child_post_startup_inferior)
1637         (aarch64_linux_read_description)
1638         (aarch64_linux_can_use_hw_breakpoint)
1639         (aarch64_linux_insert_hw_breakpoint)
1640         (aarch64_linux_remove_hw_breakpoint)
1641         (aarch64_linux_insert_watchpoint, aarch64_linux_remove_watchpoint)
1642         (aarch64_linux_region_ok_for_hw_watchpoint)
1643         (aarch64_linux_stopped_data_address)
1644         (aarch64_linux_stopped_by_watchpoint)
1645         (aarch64_linux_watchpoint_addr_within_range)
1646         (aarch64_linux_can_do_single_step): Refactor as methods of
1647         aarch64_linux_nat_target.
1648         (super_post_startup_inferior): Delete.
1649         (_initialize_aarch64_linux_nat): Adjust to C++ification.
1650
1651         * hppa-linux-nat.c (hppa_linux_nat_target): New class.
1652         (the_hppa_linux_nat_target): New.
1653         (hppa_linux_fetch_inferior_registers)
1654         (hppa_linux_store_inferior_registers): Refactor as methods of
1655         hppa_linux_nat_target.
1656         (_initialize_hppa_linux_nat): Adjust to C++ification.
1657
1658         * ia64-linux-nat.c (ia64_linux_nat_target): New class.
1659         (the_ia64_linux_nat_target): New.
1660         (ia64_linux_insert_watchpoint, ia64_linux_remove_watchpoint)
1661         (ia64_linux_stopped_data_address)
1662         (ia64_linux_stopped_by_watchpoint, ia64_linux_fetch_registers)
1663         (ia64_linux_store_registers, ia64_linux_xfer_partial): Refactor as
1664         ia64_linux_nat_target methods.
1665         (super_xfer_partial): Delete.
1666         (_initialize_ia64_linux_nat): Adjust to C++ification.
1667
1668         * m32r-linux-nat.c (m32r_linux_nat_target): New class.
1669         (the_m32r_linux_nat_target): New.
1670         (m32r_linux_fetch_inferior_registers)
1671         (m32r_linux_store_inferior_registers): Refactor as
1672         m32r_linux_nat_target methods.
1673         (_initialize_m32r_linux_nat): Adjust to C++ification.
1674
1675         * m68k-linux-nat.c (m68k_linux_nat_target): New class.
1676         (the_m68k_linux_nat_target): New.
1677         (m68k_linux_fetch_inferior_registers)
1678         (m68k_linux_store_inferior_registers): Refactor as
1679         m68k_linux_nat_target methods.
1680         (_initialize_m68k_linux_nat): Adjust to C++ification.
1681
1682         * s390-linux-nat.c (s390_linux_nat_target): New class.
1683         (the_s390_linux_nat_target): New.
1684         (s390_linux_fetch_inferior_registers)
1685         (s390_linux_store_inferior_registers, s390_stopped_by_watchpoint)
1686         (s390_insert_watchpoint, s390_remove_watchpoint)
1687         (s390_can_use_hw_breakpoint, s390_insert_hw_breakpoint)
1688         (s390_remove_hw_breakpoint, s390_region_ok_for_hw_watchpoint)
1689         (s390_auxv_parse, s390_read_description): Refactor as methods of
1690         s390_linux_nat_target.
1691         (_initialize_s390_nat): Adjust to C++ification.
1692
1693         * sparc-linux-nat.c (sparc_linux_nat_target): New class.
1694         (the_sparc_linux_nat_target): New.
1695         (_initialize_sparc_linux_nat): Adjust to C++ification.
1696         * sparc-nat.c (sparc_fetch_inferior_registers)
1697         (sparc_store_inferior_registers): Remove target_ops parameter.
1698         * sparc-nat.h (sparc_fetch_inferior_registers)
1699         (sparc_store_inferior_registers): Remove target_ops parameter.
1700         * sparc64-linux-nat.c (sparc64_linux_nat_target): New class.
1701         (the_sparc64_linux_nat_target): New.
1702         (_initialize_sparc64_linux_nat): Adjust to C++ification.
1703
1704         * spu-linux-nat.c (spu_linux_nat_target): New class.
1705         (the_spu_linux_nat_target): New.
1706         (spu_child_post_startup_inferior, spu_child_post_attach)
1707         (spu_child_wait, spu_fetch_inferior_registers)
1708         (spu_store_inferior_registers, spu_xfer_partial)
1709         (spu_can_use_hw_breakpoint): Refactor as spu_linux_nat_target
1710         methods.
1711         (_initialize_spu_nat): Adjust to C++ification.
1712
1713         * tilegx-linux-nat.c (tilegx_linux_nat_target): New class.
1714         (the_tilegx_linux_nat_target): New.
1715         (fetch_inferior_registers, store_inferior_registers):
1716         Refactor as methods.
1717         (_initialize_tile_linux_nat): Adjust to C++ification.
1718
1719         * xtensa-linux-nat.c (xtensa_linux_nat_target): New class.
1720         (the_xtensa_linux_nat_target): New.
1721         (xtensa_linux_fetch_inferior_registers)
1722         (xtensa_linux_store_inferior_registers): Refactor as
1723         xtensa_linux_nat_target methods.
1724         (_initialize_xtensa_linux_nat): Adjust to C++ification.
1725
1726         * fbsd-nat.c (USE_SIGTRAP_SIGINFO): Delete.
1727         (fbsd_pid_to_exec_file, fbsd_find_memory_regions)
1728         (fbsd_find_memory_regions, fbsd_info_proc, fbsd_xfer_partial)
1729         (fbsd_thread_alive, fbsd_pid_to_str, fbsd_thread_name)
1730         (fbsd_update_thread_list, fbsd_resume, fbsd_wait)
1731         (fbsd_stopped_by_sw_breakpoint)
1732         (fbsd_supports_stopped_by_sw_breakpoint, fbsd_follow_fork)
1733         (fbsd_insert_fork_catchpoint, fbsd_remove_fork_catchpoint)
1734         (fbsd_insert_vfork_catchpoint, fbsd_remove_vfork_catchpoint)
1735         (fbsd_post_startup_inferior, fbsd_post_attach)
1736         (fbsd_insert_exec_catchpoint, fbsd_remove_exec_catchpoint)
1737         (fbsd_set_syscall_catchpoint)
1738         (super_xfer_partial, super_resume, super_wait)
1739         (fbsd_supports_stopped_by_hw_breakpoint): Delete.
1740         (fbsd_handle_debug_trap): Remove target_ops parameter.
1741         (fbsd_nat_add_target): Delete.
1742         * fbsd-nat.h: Include "inf-ptrace.h".
1743         (fbsd_nat_add_target): Delete.
1744         (USE_SIGTRAP_SIGINFO): Define.
1745         (fbsd_nat_target): New class.
1746
1747         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers)
1748         (amd64bsd_store_inferior_registers): Remove target_ops parameter.
1749         (amd64bsd_target): Delete.
1750         * amd64-bsd-nat.h: New file.
1751         * amd64-fbsd-nat.c: Include "amd64-bsd-nat.h" instead of
1752         "x86-bsd-nat.h".
1753         (amd64_fbsd_nat_target): New class.
1754         (the_amd64_fbsd_nat_target): New.
1755         (amd64fbsd_read_description): Refactor as method of
1756         amd64_fbsd_nat_target.
1757         (amd64_fbsd_nat_target::supports_stopped_by_hw_breakpoint): New.
1758         (_initialize_amd64fbsd_nat): Adjust to C++ification.
1759         * amd64-nat.h (amd64bsd_target): Delete function declaration.
1760         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers)
1761         (i386bsd_store_inferior_registers): Remove target_ops parameter.
1762         (i386bsd_target): Delete.
1763         * i386-bsd-nat.h (i386bsd_target): Delete function declaration.
1764         (i386bsd_fetch_inferior_registers)
1765         (i386bsd_store_inferior_registers): Declare.
1766         (i386_bsd_nat_target): New class.
1767         * i386-fbsd-nat.c (i386_fbsd_nat_target): New class.
1768         (the_i386_fbsd_nat_target): New.
1769         (i386fbsd_resume, i386fbsd_read_description): Refactor as
1770         i386_fbsd_nat_target methods.
1771         (i386_fbsd_nat_target::supports_stopped_by_hw_breakpoint): New.
1772         (_initialize_i386fbsd_nat): Adjust to C++ification.
1773         * x86-bsd-nat.c (super_mourn_inferior): Delete.
1774         (x86bsd_mourn_inferior, x86bsd_target): Delete.
1775         (_initialize_x86_bsd_nat): Adjust to C++ification.
1776         * x86-bsd-nat.h: Include "x86-nat.h".
1777         (x86bsd_target): Delete declaration.
1778         (x86bsd_nat_target): New class.
1779
1780         * aarch64-fbsd-nat.c (aarch64_fbsd_nat_target): New class.
1781         (the_aarch64_fbsd_nat_target): New.
1782         (aarch64_fbsd_fetch_inferior_registers)
1783         (aarch64_fbsd_store_inferior_registers): Refactor as methods of
1784         aarch64_fbsd_nat_target.
1785         (_initialize_aarch64_fbsd_nat): Adjust to C++ification.
1786         * alpha-bsd-nat.c (alpha_bsd_nat_target): New class.
1787         (the_alpha_bsd_nat_target): New.
1788         (alphabsd_fetch_inferior_registers)
1789         (alphabsd_store_inferior_registers): Refactor as
1790         alpha_bsd_nat_target methods.
1791         (_initialize_alphabsd_nat): Refactor as methods of
1792         alpha_bsd_nat_target.
1793         * amd64-nbsd-nat.c: Include "amd64-bsd-nat.h".
1794         (the_amd64_nbsd_nat_target): New.
1795         (_initialize_amd64nbsd_nat): Adjust to C++ification.
1796         * amd64-obsd-nat.c: Include "amd64-bsd-nat.h".
1797         (the_amd64_obsd_nat_target): New.
1798         (_initialize_amd64obsd_nat): Adjust to C++ification.
1799         * arm-fbsd-nat.c (arm_fbsd_nat_target): New.
1800         (the_arm_fbsd_nat_target): New.
1801         (arm_fbsd_fetch_inferior_registers)
1802         (arm_fbsd_store_inferior_registers, arm_fbsd_read_description):
1803         (_initialize_arm_fbsd_nat): Refactor as methods of
1804         arm_fbsd_nat_target.
1805         (_initialize_arm_fbsd_nat): Adjust to C++ification.
1806         * arm-nbsd-nat.c (arm_netbsd_nat_target): New class.
1807         (the_arm_netbsd_nat_target): New.
1808         (armnbsd_fetch_registers, armnbsd_store_registers): Refactor as
1809         arm_netbsd_nat_target.
1810         (_initialize_arm_netbsd_nat): Adjust to C++ification.
1811         * hppa-nbsd-nat.c (hppa_nbsd_nat_target): New class.
1812         (the_hppa_nbsd_nat_target): New.
1813         (hppanbsd_fetch_registers, hppanbsd_store_registers): Refactor as
1814         hppa_nbsd_nat_target methods.
1815         (_initialize_hppanbsd_nat): Adjust to C++ification.
1816         * hppa-obsd-nat.c (hppa_obsd_nat_target): New class.
1817         (the_hppa_obsd_nat_target): New.
1818         (hppaobsd_fetch_registers, hppaobsd_store_registers): Refactor as
1819         methods of hppa_obsd_nat_target.
1820         (_initialize_hppaobsd_nat): Adjust to C++ification.  Use
1821         add_target.
1822         * i386-nbsd-nat.c (the_i386_nbsd_nat_target): New.
1823         (_initialize_i386nbsd_nat): Adjust to C++ification.  Use
1824         add_target.
1825         * i386-obsd-nat.c (the_i386_obsd_nat_target): New.
1826         (_initialize_i386obsd_nat): Use add_target.
1827         * m68k-bsd-nat.c (m68k_bsd_nat_target): New class.
1828         (the_m68k_bsd_nat_target): New.
1829         (m68kbsd_fetch_inferior_registers)
1830         (m68kbsd_store_inferior_registers): Refactor as methods of
1831         m68k_bsd_nat_target.
1832         (_initialize_m68kbsd_nat): Adjust to C++ification.
1833         * mips-fbsd-nat.c (mips_fbsd_nat_target): New class.
1834         (the_mips_fbsd_nat_target): New.
1835         (mips_fbsd_fetch_inferior_registers)
1836         (mips_fbsd_store_inferior_registers): Refactor as methods of
1837         mips_fbsd_nat_target.
1838         (_initialize_mips_fbsd_nat): Adjust to C++ification.  Use
1839         add_target.
1840         * mips-nbsd-nat.c (mips_nbsd_nat_target): New class.
1841         (the_mips_nbsd_nat_target): New.
1842         (mipsnbsd_fetch_inferior_registers)
1843         (mipsnbsd_store_inferior_registers): Refactor as methods of
1844         mips_nbsd_nat_target.
1845         (_initialize_mipsnbsd_nat): Adjust to C++ification.
1846         * mips64-obsd-nat.c (mips64_obsd_nat_target): New class.
1847         (the_mips64_obsd_nat_target): New.
1848         (mips64obsd_fetch_inferior_registers)
1849         (mips64obsd_store_inferior_registers): Refactor as methods of
1850         mips64_obsd_nat_target.
1851         (_initialize_mips64obsd_nat): Adjust to C++ification.  Use
1852         add_target.
1853         * nbsd-nat.c (nbsd_pid_to_exec_file): Refactor as method of
1854         nbsd_nat_target.
1855         * nbsd-nat.h: Include "inf-ptrace.h".
1856         (nbsd_nat_target): New class.
1857         * obsd-nat.c (obsd_pid_to_str, obsd_update_thread_list)
1858         (obsd_wait): Refactor as methods of obsd_nat_target.
1859         (obsd_add_target): Delete.
1860         * obsd-nat.h: Include "inf-ptrace.h".
1861         (obsd_nat_target): New class.
1862         * ppc-fbsd-nat.c (ppc_fbsd_nat_target): New class.
1863         (the_ppc_fbsd_nat_target): New.
1864         (ppcfbsd_fetch_inferior_registers)
1865         (ppcfbsd_store_inferior_registers): Refactor as methods of
1866         ppc_fbsd_nat_target.
1867         (_initialize_ppcfbsd_nat): Adjust to C++ification.  Use
1868         add_target.
1869         * ppc-nbsd-nat.c (ppc_nbsd_nat_target): New class.
1870         (the_ppc_nbsd_nat_target): New.
1871         (ppcnbsd_fetch_inferior_registers)
1872         (ppcnbsd_store_inferior_registers): Refactor as methods of
1873         ppc_nbsd_nat_target.
1874         (_initialize_ppcnbsd_nat): Adjust to C++ification.
1875         * ppc-obsd-nat.c (ppc_obsd_nat_target): New class.
1876         (the_ppc_obsd_nat_target): New.
1877         (ppcobsd_fetch_registers, ppcobsd_store_registers): Refactor as
1878         methods of ppc_obsd_nat_target.
1879         (_initialize_ppcobsd_nat): Adjust to C++ification.  Use
1880         add_target.
1881         * sh-nbsd-nat.c (sh_nbsd_nat_target): New class.
1882         (the_sh_nbsd_nat_target): New.
1883         (shnbsd_fetch_inferior_registers)
1884         (shnbsd_store_inferior_registers): Refactor as methods of
1885         sh_nbsd_nat_target.
1886         (_initialize_shnbsd_nat): Adjust to C++ification.
1887         * sparc-nat.c (sparc_xfer_wcookie): Make extern.
1888         (inf_ptrace_xfer_partial): Delete.
1889         (sparc_xfer_partial, sparc_target): Delete.
1890         * sparc-nat.h (sparc_fetch_inferior_registers)
1891         (sparc_store_inferior_registers, sparc_xfer_wcookie): Declare.
1892         (sparc_target): Delete function declaration.
1893         (sparc_target): New template class.
1894         * sparc-nbsd-nat.c (the_sparc_nbsd_nat_target): New.
1895         (_initialize_sparcnbsd_nat): Adjust to C++ification.
1896         * sparc64-fbsd-nat.c (the_sparc64_fbsd_nat_target): New.
1897         (_initialize_sparc64fbsd_nat): Adjust to C++ification.  Use
1898         add_target.
1899         * sparc64-nbsd-nat.c (the_sparc64_nbsd_nat_target): New.
1900         (_initialize_sparc64nbsd_nat): Adjust to C++ification.
1901         * sparc64-obsd-nat.c (the_sparc64_obsd_nat_target): New.
1902         (_initialize_sparc64obsd_nat): Adjust to C++ification.  Use
1903         add_target.
1904         * vax-bsd-nat.c (vax_bsd_nat_target): New class.
1905         (the_vax_bsd_nat_target): New.
1906         (vaxbsd_fetch_inferior_registers)
1907         (vaxbsd_store_inferior_registers): Refactor as vax_bsd_nat_target
1908         methods.
1909         (_initialize_vaxbsd_nat): Adjust to C++ification.
1910
1911         * bsd-kvm.c (bsd_kvm_target): New class.
1912         (bsd_kvm_ops): Now a bsd_kvm_target.
1913         (bsd_kvm_open, bsd_kvm_close, bsd_kvm_xfer_partial)
1914         (bsd_kvm_files_info, bsd_kvm_fetch_registers)
1915         (bsd_kvm_thread_alive, bsd_kvm_pid_to_str): Refactor as methods of
1916         bsd_kvm_target.
1917         (bsd_kvm_return_one): Delete.
1918         (bsd_kvm_add_target): Adjust to C++ification.
1919
1920         * nto-procfs.c (nto_procfs_target, nto_procfs_target_native)
1921         (nto_procfs_target_procfs): New classes.
1922         (procfs_open_1, procfs_thread_alive, procfs_update_thread_list)
1923         (procfs_files_info, procfs_pid_to_exec_file, procfs_attach)
1924         (procfs_post_attach, procfs_wait, procfs_fetch_registers)
1925         (procfs_xfer_partial, procfs_detach, procfs_insert_breakpoint)
1926         (procfs_remove_breakpoint, procfs_insert_hw_breakpoint)
1927         (procfs_remove_hw_breakpoint, procfs_resume)
1928         (procfs_mourn_inferior, procfs_create_inferior, procfs_interrupt)
1929         (procfs_kill_inferior, procfs_store_registers)
1930         (procfs_pass_signals, procfs_pid_to_str, procfs_can_run): Refactor
1931         as methods of nto_procfs_target.
1932         (nto_procfs_ops): Now an nto_procfs_target_procfs.
1933         (nto_native_ops): Delete.
1934         (procfs_open, procfs_native_open): Delete.
1935         (nto_native_ops): Now an nto_procfs_target_native.
1936         (init_procfs_targets): Adjust to C++ification.
1937         (procfs_can_use_hw_breakpoint, procfs_remove_hw_watchpoint)
1938         (procfs_insert_hw_watchpoint, procfs_stopped_by_watchpoint):
1939         Refactor as methods of nto_procfs_target.
1940
1941         * go32-nat.c (go32_nat_target): New class.
1942         (the_go32_nat_target): New.
1943         (go32_attach, go32_resume, go32_wait, go32_fetch_registers)
1944         (go32_store_registers, go32_xfer_partial, go32_files_info)
1945         (go32_kill_inferior, go32_create_inferior, go32_mourn_inferior)
1946         (go32_terminal_init, go32_terminal_info, go32_terminal_inferior)
1947         (go32_terminal_ours, go32_pass_ctrlc, go32_thread_alive)
1948         (go32_pid_to_str): Refactor as methods of go32_nat_target.
1949         (go32_target): Delete.
1950         (_initialize_go32_nat): Adjust to C++ification.
1951
1952         * gnu-nat.c (gnu_wait, gnu_resume, gnu_kill_inferior)
1953         (gnu_mourn_inferior, gnu_create_inferior, gnu_attach, gnu_detach)
1954         (gnu_stop, gnu_thread_alive, gnu_xfer_partial)
1955         (gnu_find_memory_regions, gnu_pid_to_str): Refactor as methods of
1956         gnu_nat_target.
1957         (gnu_target): Delete.
1958         * gnu-nat.h (gnu_target): Delete.
1959         (gnu_nat_target): New class.
1960         * i386-gnu-nat.c (gnu_base_target): New.
1961         (i386_gnu_nat_target): New class.
1962         (the_i386_gnu_nat_target): New.
1963         (_initialize_i386gnu_nat): Adjust to C++ification.
1964
1965 2018-05-02  Pedro Alves  <palves@redhat.com>
1966
1967         * bfd-target.c (target_bfd_xclose): Rename to ...
1968         (target_bfd_close): ... this.
1969         (target_bfd_reopen): Adjust.
1970         * target.c (target_close): Remove references to to_xclose.
1971         * target.h (target_ops::to_xclose): Delete.
1972         (target_ops::to_close): Update comments.
1973
1974 2018-05-02  Pedro Alves  <palves@redhat.com>
1975
1976         * alpha-linux-nat.c: Include "linux-nat-trad.h" instead of
1977         "linux-nat.h".
1978         * configure.nat (alpha-linux, linux-mips): Add linux-nat-trad.o.
1979         * inf-ptrace.c (inf_ptrace_register_u_offset)
1980         (inf_ptrace_fetch_register, inf_ptrace_fetch_registers)
1981         (inf_ptrace_store_register, inf_ptrace_store_registers)
1982         (inf_ptrace_trad_target): Move to ...
1983         * linux-nat-trad.c: ... this new file.
1984         * linux-nat-trad.h: New file.
1985         * linux-nat.c (linux_target_install_ops): Make extern.
1986         (linux_trad_target): Delete.
1987         * linux-nat.h (linux_trad_target): Delete declaration.
1988         (linux_target_install_ops): Declare.
1989         * mips-linux-nat.c: Include "linux-nat-trad.h" instead of
1990         "linux-nat.h".
1991
1992 2018-05-02  Pedro Alves  <palves@redhat.com>
1993
1994         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Don't call
1995         procfs_target/add_target here.
1996         * procfs.c (procfs_target): Make static.
1997         (_initialize_procfs): Call add_target here.
1998         * procfs.h (struct target_ops): Remove forward declaration.
1999         (procfs_target): Remove declaration.
2000         * sparc-sol2-nat.c (_initialize_sparc_sol2_nat): Delete.
2001
2002 2018-05-02  Pedro Alves  <palves@redhat.com>
2003
2004         * procfs.c (procfs_stopped_by_watchpoint)
2005         (procfs_insert_watchpoint, procfs_remove_watchpoint)
2006         (procfs_region_ok_for_hw_watchpoint, procfs_stopped_data_address):
2007         Forward declare.
2008         (procfs_use_watchpoints): Delete, move contents...
2009         (procfs_target): ... here.
2010         * procfs.h (procfs_use_watchpoints): Delete declaration.
2011         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Don't call
2012         procfs_use_watchpoints.
2013         * sparc-sol2-nat.c (_initialize_sparc_sol2_nat): Don't call
2014         procfs_use_watchpoints.
2015
2016 2018-05-02  Tom Tromey  <tom@tromey.com>
2017
2018         PR python/20084:
2019         * python/python.c (gdbpy_parameter_value): Handle var_zuinteger
2020         and var_zuinteger_unlimited.
2021         * python/py-param.c (struct parm_constant): Add PARAM_ZUINTEGER
2022         and PARAM_ZUINTEGER_UNLIMITED.
2023         (set_parameter_value): Handle var_zuinteger and
2024         var_zuinteger_unlimited.
2025         (add_setshow_generic): Likewise.
2026         (parmpy_init): Likewise.
2027
2028 2018-04-28  Dan Robertson  <danlrobertson89@gmail.com>
2029
2030         PR rust/23124
2031         * gdb/rust-exp.y (convert_params_to_types): Ensure that the params
2032         pointer is not null before dereferencing it.
2033
2034 2018-04-30  Tom Tromey  <tom@tromey.com>
2035
2036         * darwin-nat-info.c (darwin_debug_regions_recurse): Remove use of
2037         is_mi_like_p.
2038
2039 2018-04-30  Tom Tromey  <tom@tromey.com>
2040
2041         * breakpoint.c (mention): Remove use of is_mi_like_p.
2042         (print_mention_ranged_breakpoint): Likewise.
2043         * break-catch-throw.c (print_it_exception_catchpoint): Remove use
2044         of is_mi_like_p.
2045
2046 2018-04-30  Tom Tromey  <tom@tromey.com>
2047
2048         * tracepoint.c (tvariables_info_1): Remove use of is_mi_like_p.
2049
2050 2018-04-30  Tom Tromey  <tom@tromey.com>
2051
2052         * spu-tdep.c (info_spu_mailbox_list, info_spu_dma_cmdlist)
2053         (info_spu_event_command): Remove some uses of is_mi_like_p.
2054
2055 2018-04-30  Tom Tromey  <tom@tromey.com>
2056
2057         * python/py-framefilter.c (py_print_single_arg)
2058         (enumerate_locals, py_print_args, py_print_frame): Remove some
2059         uses of is_mi_like_p.
2060
2061 2018-04-30  Tom Tromey  <tom@tromey.com>
2062
2063         * ui-out.c: Update.
2064         * cli-out.h (cli_ui_out::do_is_mi_like_p): Update.
2065         * ui-out.h (ui_out::is_mi_like_p): Now const.
2066         (ui_out::do_is_mi_like_p): Now const.
2067         * mi/mi-out.h (mi_ui_out::do_is_mi_like_p): Update.
2068
2069 2018-04-30  Tom Tromey  <tom@tromey.com>
2070
2071         * varobj.c (varobj_set_visualizer): Use new_reference.
2072         * python/python.c (gdbpy_decode_line): Use new_reference.
2073         * python/py-cmd.c (cmdpy_function, cmdpy_completer_helper): Use
2074         new_reference.
2075
2076 2018-04-30  Tom Tromey  <tom@tromey.com>
2077
2078         * varobj.c (install_new_value): Use new_reference.
2079         * value.h (value_incref): Return void.  Swap intro comment with
2080         value_decref.
2081         * value.c (set_value_parent): Use new_reference.
2082         (value_incref): Return void.  Update intro comment.
2083         (release_value): Use new_reference.
2084         * dwarf2loc.c (dwarf2_evaluate_loc_desc_full): Use new_reference.
2085
2086 2018-04-30  Tom Tromey  <tom@tromey.com>
2087
2088         * symfile-mem.c (symbol_file_add_from_memory): Use new_reference.
2089         * gdb_bfd.h (new_bfd_ref): Remove.
2090         (gdb_bfd_open): Update comment.
2091         * gdb_bfd.c (gdb_bfd_open, gdb_bfd_fopen, gdb_bfd_openr)
2092         (gdb_bfd_openw, gdb_bfd_openr_iovec, gdb_bfd_record_inclusion)
2093         (gdb_bfd_fdopenr): Use new_reference.
2094         * exec.c (exec_file_attach): Use new_reference.
2095
2096 2018-04-30  Tom Tromey  <tom@tromey.com>
2097
2098         * common/gdb_ref_ptr.h (ref_ptr::new_reference): New static
2099         method.
2100
2101 2018-04-30  Tom Tromey  <tom@tromey.com>
2102
2103         * jit.c (jit_read_code_entry): Use type_align.
2104         * i386-tdep.c (i386_gdbarch_init): Don't call
2105         set_gdbarch_long_long_align_bit.
2106         * gdbarch.sh: Remove long_long_align_bit.
2107         * gdbarch.c, gdbarch.h: Rebuild.
2108         * arc-tdep.c (arc_type_align): New function.
2109         (arc_gdbarch_init): Use arc_type_align.  Don't call
2110         set_gdbarch_long_long_align_bit.
2111
2112 2018-04-30  Tom Tromey  <tom@tromey.com>
2113
2114         * rust-lang.c (rust_type_alignment): Remove.
2115         (rust_composite_type): Use type_align.
2116
2117 2018-04-30  Tom Tromey  <tom@tromey.com>
2118
2119         * NEWS: Mention Type.align.
2120         * python/py-type.c (typy_get_alignof): New function.
2121         (type_object_getset): Add "alignof".
2122
2123 2018-04-30  Tom Tromey  <tom@tromey.com>
2124
2125         PR exp/17095:
2126         * NEWS: Update.
2127         * std-operator.def (UNOP_ALIGNOF): New operator.
2128         * expprint.c (dump_subexp_body_standard) <case UNOP_ALIGNOF>:
2129         New.
2130         * eval.c (evaluate_subexp_standard) <case UNOP_ALIGNOF>: New.
2131         * c-lang.c (c_op_print_tab): Add alignof.
2132         * c-exp.y (ALIGNOF): New token.
2133         (exp): Add "ALIGNOF" production.
2134         (ident_tokens): Add _Alignof and alignof.
2135
2136 2018-04-30  Tom Tromey  <tom@tromey.com>
2137
2138         * i386-tdep.c (i386_type_align): New function.
2139         (i386_gdbarch_init): Update.
2140         * gdbarch.sh (type_align): New method.
2141         * gdbarch.c, gdbarch.h: Rebuild.
2142         * arch-utils.h (default_type_align): Declare.
2143         * arch-utils.c (default_type_align): New function.
2144         * gdbtypes.h (TYPE_ALIGN_BITS): New define.
2145         (struct type) <align_log2>: New field.
2146         <instance_flags>: Now a bitfield.
2147         (TYPE_RAW_ALIGN): New macro.
2148         (type_align, type_raw_align, set_type_align): Declare.
2149         * gdbtypes.c (type_align, type_raw_align, set_type_align): New
2150         functions.
2151         * dwarf2read.c (quirk_rust_enum): Set type alignment.
2152         (get_alignment, maybe_set_alignment): New functions.
2153         (read_structure_type, read_enumeration_type, read_array_type)
2154         (read_set_type, read_tag_pointer_type, read_tag_reference_type)
2155         (read_subrange_type, read_base_type): Set type alignment.
2156
2157 2018-04-30  Simon Marchi  <simon.marchi@ericsson.com>
2158
2159         * dwarf2read.c (read_index_from_section): Use bool.
2160
2161 2018-04-29  Fabian Groffen  <grobian@gentoo.org>
2162
2163         PR gdb/22950
2164         * proc-events.c (init_syscall_table): Guard usage os SYS_uuidsys
2165         with #ifdef.
2166
2167 2018-04-29  John Reiser  <jreiser@BitWagon.com>
2168
2169         PR build/22873
2170         * gdb/Makefile.in: (.c:.l, .c:.y): Write the target only in the
2171         last step, and do it atomically.
2172
2173 2018-04-27  Alexandre Oliva  <aoliva@redhat.com>
2174
2175         * compile/compile-c-types.c (convert_int, convert_float):
2176         Update for C FE v1.
2177
2178 2018-04-27  Tom Tromey  <tom@tromey.com>
2179
2180         PR rust/22545:
2181         * rust-lang.c (rust_inclusive_range_type_p): New function.
2182         (rust_range): Handle inclusive ranges.
2183         (rust_compute_range): Likewise.
2184         * rust-exp.y (struct rust_op) <inclusive>: New field.
2185         (DOTDOTEQ): New constant.
2186         (range_expr): Add "..=" productions.
2187         (operator_tokens): Add "..=" token.
2188         (ast_range): Add "inclusive" parameter.
2189         (convert_ast_to_expression) <case OP_RANGE>: Handle inclusive
2190         ranges.
2191         * parse.c (operator_length_standard) <case OP_RANGE>: Handle new
2192         bounds values.
2193         * expression.h (enum range_type) <NONE_BOUND_DEFAULT_EXCLUSIVE,
2194         LOW_BOUND_DEFAULT_EXCLUSIVE>: New constants.
2195         Update comments.
2196         * expprint.c (print_subexp_standard): Handle new bounds values.
2197         (dump_subexp_body_standard): Likewise.
2198
2199 2018-04-27  Tom Tromey  <tom@tromey.com>
2200
2201         * configure: Rebuild.
2202         * warning.m4 (AM_GDB_WARNINGS): Add -Wsuggest-override.
2203         * dwarf2loc.c (class dwarf_evaluate_loc_desc): Use "override", not
2204         "OVERRIDE".
2205         (class symbol_needs_eval_context): Likewise.
2206         * dwarf2read.c (mock_mapped_index::symbol_name_count)
2207         (mock_mapped_index::symbol_name_at): Use "override".  Remove
2208         "virtual".
2209         * dwarf2-frame.c (dwarf_expr_executor::get_addr_index): Use
2210         "override".
2211         (class dwarf_expr_executor): Use "override", not "OVERRIDE".
2212         * aarch64-tdep.c (instruction_reader::read): Use "override".
2213         (instruction_reader_test::read): Likewise.
2214         * arm-tdep.c (instruction_reader::read): Use "override".
2215         (instruction_reader_thumb::read): Likewise.
2216
2217 2018-04-26  Andrzej Kaczmarek  <andrzej.kaczmarek@codecoup.pl>
2218
2219         PR remote/9665
2220         * remote.c (send_g_packet): Use putpkt/getpkt/packet_check_result
2221         instead of remote_send.
2222         (remote_send): Remove.
2223
2224 2018-04-26  Pedro Alves  <palves@redhat.com>
2225
2226         * elfread.c (elf_gnu_ifunc_resolver_return_stop): Use
2227         find_function_start_sal instead of find_pc_line.
2228
2229 2018-04-26  Pedro Alves  <palves@redhat.com>
2230
2231         * breakpoint.c (set_breakpoint_location_function): Handle
2232         mst_data_gnu_ifunc.
2233         * c-exp.y (variable production): Handle mst_data_gnu_ifunc.
2234         * elfread.c (elf_symtab_read): Give data symbols with
2235         BSF_GNU_INDIRECT_FUNCTION set mst_data_gnu_ifunc type.
2236         (elf_rel_plt_read): Update comment.
2237         * linespec.c (convert_linespec_to_sals): Handle
2238         mst_data_gnu_ifunc.
2239         (minsym_found): Handle mst_data_gnu_ifunc.
2240         * minsyms.c (msymbol_is_function, minimal_symbol_reader::record)
2241         (find_solib_trampoline_target): Handle mst_data_gnu_ifunc.
2242         * parse.c (find_minsym_type_and_address): Handle
2243         mst_data_gnu_ifunc.
2244         * symmisc.c (dump_msymbols): Handle mst_data_gnu_ifunc.
2245         * symtab.c (find_gnu_ifunc): Handle mst_data_gnu_ifunc.
2246         * symtab.h (minimal_symbol_type) <mst_text_gnu_ifunc>: Update
2247         comment.
2248         <mst_data_gnu_ifunc>: New enumerator.
2249
2250 2018-04-26  Pedro Alves  <palves@redhat.com>
2251
2252         * minsyms.c (lookup_minimal_symbol_by_pc_section_1): Rename to ...
2253         (lookup_minimal_symbol_by_pc_section): ... this.  Replace
2254         'want_trampoline' parameter by a lookup_msym_prefer parameter.
2255         Handle it.
2256         (lookup_minimal_symbol_by_pc_section): Delete old implementation.
2257         (lookup_minimal_symbol_by_pc): Adjust.
2258         (in_gnu_ifunc_stub): Prefer GNU ifunc symbols.
2259         (lookup_solib_trampoline_symbol_by_pc): Adjust.
2260         * minsyms.h (lookup_msym_prefer): New enum.
2261         (lookup_minimal_symbol_by_pc_section): Replace 'want_trampoline'
2262         parameter by a lookup_msym_prefer parameter.
2263
2264 2018-04-26  Pedro Alves  <palves@redhat.com>
2265
2266         * elfread.c (elf_gnu_ifunc_record_cache): Check if the symbol name
2267         ends in "@plt" instead of looking at the symbol's section.
2268
2269 2018-04-26  Pedro Alves  <palves@redhat.com>
2270
2271         * blockframe.c (cache_pc_function_is_gnu_ifunc): Delete.  Remove
2272         all references.
2273         (find_pc_partial_function_gnu_ifunc): Rename to ...
2274         (find_pc_partial_function): ... this, and remove references to
2275         'is_gnu_ifunc_p'.
2276         (find_pc_partial_function): Delete old implementation.
2277         * symtab.h (find_pc_partial_function_gnu_ifunc): Delete.
2278
2279 2018-04-26  Pedro Alves  <palves@redhat.com>
2280
2281         * linespec.c (struct bound_minimal_symbol_search_key): New.
2282         (convert_linespec_to_sals): Sort minimal symbols earlier.  Don't
2283         skip first line if we found a GNU ifunc minimal symbol by name.
2284         (compare_msymbols): Change parameters to work with a destructured
2285         lhs minsym.
2286         (compare_msymbols_for_qsort, compare_msymbols_for_bsearch): New
2287         functions.
2288
2289 2018-04-26  Pedro Alves  <palves@redhat.com>
2290
2291         * breakpoint.c (set_breakpoint_location_function): Don't resolve
2292         ifunc targets here.  Instead, if we have an ifunc minsym, use its
2293         address/name.
2294         (add_location_to_breakpoint): Store the minsym and the objfile in
2295         the breakpoint location.
2296         * breakpoint.h (bp_location) <msymbol, objfile>: New fields.
2297         * linespec.c (minsym_found): Resolve GNU ifunc targets here.
2298         Record the minsym in the sal.
2299         * symtab.h (symtab_and_line) <msymbol>: New field.
2300
2301 2018-04-26  Pedro Alves  <palves@redhat.com>
2302
2303         * elfread.c (elf_gnu_ifunc_resolve_by_got): Don't write to *ADDR_P
2304         unless we actually resolved the ifunc.
2305
2306 2018-04-26  Pedro Alves  <palves@redhat.com>
2307
2308         * c-exp.y (variable production): Prefer ifunc minsyms over
2309         regular function symbols.
2310         * symtab.c (find_gnu_ifunc): New function.
2311         * minsyms.h (lookup_msym_prefer): New enum.
2312         (lookup_minimal_symbol_by_pc_section): Replace 'want_trampoline'
2313         parameter by a lookup_msym_prefer parameter.
2314         * symtab.h (find_gnu_ifunc): New declaration.
2315
2316 2018-04-26  Pedro Alves  <palves@redhat.com>
2317
2318         * blockframe.c (find_gnu_ifunc_target_type): New function.
2319         (find_function_type): New.
2320         * eval.c (evaluate_var_msym_value): For GNU ifunc types, always
2321         return a value with a memory address.
2322         (eval_call): For calls to GNU ifunc functions, try to find the
2323         type of the target function from the type that the resolver
2324         returns.
2325         * gdbtypes.c (objfile_type): Don't install a return type for ifunc
2326         symbols.
2327         * infcall.c (find_function_return_type): Delete.
2328         (find_function_addr): Add 'function_type' parameter.  For calls to
2329         GNU ifunc functions, try to find the type of the target function
2330         from the type that the resolver returns, and return it via
2331         FUNCTION_TYPE.
2332         (call_function_by_hand_dummy): Adjust to use the function type
2333         returned by find_function_addr.
2334         (find_function_addr): Add 'function_type' parameter and move
2335         description here.
2336         * symtab.h (find_function_type, find_gnu_ifunc_target_type): New
2337         declarations.
2338
2339 2018-04-26  Pedro Alves  <palves@redhat.com>
2340
2341         * c-exp.y (variable production): Skip finding an alias for ifunc
2342         symbols.
2343
2344 2018-04-26  Pedro Alves  <palves@redhat.com>
2345
2346         * elfread.c (elf_rel_plt_read): Look for relocations for .got.plt too.
2347
2348 2018-04-25  Pedro Alves  <palves@redhat.com>
2349
2350         * infcmd.c (kill_command): Print the pid as string, not the whole
2351         thread's ptid.  Add comment.  s/has been killed/killed/ in output
2352         message.
2353         * remote.c (remote_detach_1): Print the pid as string, not the
2354         whole thread's ptid.
2355
2356 2018-04-24  Jan Kratochvil  <jan.kratochvil@redhat.com>
2357             Sergio Durigan Junior  <sergiodj@redhat.com>
2358             Pedro Alves  <palves@redhat.com>
2359
2360         * infcmd.c (kill_command): Print message when inferior has
2361         been killed.
2362         * inferior.c (print_inferior_events): Remove 'static'.  Set as
2363         '1'.
2364         (add_inferior): Improve message printed when
2365         'print_inferior_events' is on.
2366         (exit_inferior): Remove message printed when
2367         'print_inferior_events' is on.
2368         (detach_inferior): Improve message printed when
2369         'print_inferior_events' is on.
2370         (initialize_inferiors): Use 'add_inferior_silent' to set
2371         'current_inferior_'.
2372         * inferior.h (print_inferior_events): Declare here as
2373         'extern'.
2374         * infrun.c (follow_fork_inferior): Print '[Attaching...]' or
2375         '[Detaching...]' messages when 'print_inferior_events' is on.
2376         Use 'add_thread_silent' instead of 'add_thread'.  Add '[' and ']'
2377         as prefix/suffix for messages.  Remove periods.  Fix erroneous
2378         'Detaching after fork from child...', replace it by '... from
2379         parent...'.
2380         (handle_vfork_child_exec_or_exit): Add '[' and ']' as
2381         prefix/suffix when printing 'Detaching...' messages.  Print
2382         them when 'print_inferior_events' is on.
2383         * remote.c (remote_detach_1): Print message when detaching
2384         from inferior and '!is_fork_parent'.
2385
2386 2018-04-24  Tom Tromey  <tom@tromey.com>
2387
2388         * cli-out.h: Reindent.
2389
2390 2018-04-24  Tom Tromey  <tom@tromey.com>
2391
2392         * cli-out.c (cli_ui_out::out_field_fmt): Remove.
2393         (cli_ui_out::do_field_string): Use fputs_filtered.
2394         * cli-out.h (class cli_ui_out) <out_field_fmt>: Remove.
2395
2396 2018-04-23  Tom Tromey  <tom@tromey.com>
2397
2398         * guile/scm-frame.c (gdbscm_frame_read_var): Use
2399         gdb::unique_xmalloc_ptr.
2400
2401 2018-04-23  Tom Tromey  <tom@tromey.com>
2402
2403         * configure: Rebuild.
2404
2405 2018-04-22  Rajendra SY  <rajendra.sy@gmail.com>
2406
2407         PR gdb/23095
2408         * gdb/testsuite/gdb.base/break-probes.exp: Pass shlib_load to
2409         prepare_for_testing.  Set normal_bp to r_debug_state if target
2410         is bsd.
2411
2412 2018-04-21  Pedro Alves  <palves@redhat.com>
2413             Rajendra SY  <rajendra.sy@gmail.com>
2414
2415         * inf-ptrace.c (inf_ptrace_attach): Mark the thread as executing.
2416         * remote.c (extended_remote_attach): In all-stop mode, mark the
2417         thread as executing.
2418
2419 2018-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2420
2421         * thread.c (thread_apply_all_command): Fix comment.
2422         (thread_command): Fix comment.
2423
2424 2018-04-10  Alan Hayward  <alan.hayward@arm.com>
2425
2426         * common/tdesc.h (tdesc_create_feature): Remove xml filename
2427         parameter.
2428         * features/aarch64-core.c (create_feature_aarch64_core):
2429         Regenerate.
2430         * features/aarch64-fpu.c (create_feature_aarch64_fpu):
2431         Likewise.
2432         * features/i386/32bit-avx.c (create_feature_i386_32bit_avx):
2433         Likewise.
2434         * features/i386/32bit-avx512.c
2435         (create_feature_i386_32bit_avx512): Likewise.
2436         * features/i386/32bit-core.c (create_feature_i386_32bit_core):
2437         Likewise.
2438         * features/i386/32bit-linux.c (create_feature_i386_32bit_linux):
2439         Likewise.
2440         * features/i386/32bit-mpx.c (create_feature_i386_32bit_mpx):
2441         Likewise.
2442         * features/i386/32bit-pkeys.c (create_feature_i386_32bit_pkeys):
2443         Likewise.
2444         * features/i386/32bit-sse.c (create_feature_i386_32bit_sse):
2445         Likewise.
2446         * features/i386/64bit-avx.c (create_feature_i386_64bit_avx):
2447         Likewise.
2448         * features/i386/64bit-avx512.c
2449         (create_feature_i386_64bit_avx512): Likewise.
2450         * features/i386/64bit-core.c (create_feature_i386_64bit_core):
2451         Likewise.
2452         * features/i386/64bit-linux.c (create_feature_i386_64bit_linux):
2453         Likewise.
2454         * features/i386/64bit-mpx.c (create_feature_i386_64bit_mpx):
2455         Likewise.
2456         * features/i386/64bit-pkeys.c (create_feature_i386_64bit_pkeys):
2457         Likewise.
2458         * features/i386/64bit-segments.c
2459         (create_feature_i386_64bit_segments): Likewise.
2460         * features/i386/64bit-sse.c (create_feature_i386_64bit_sse):
2461         Likewise.
2462         * features/i386/x32-core.c
2463         (create_feature_i386_x32_core): Likewise.
2464         * features/tic6x-c6xp.c (create_feature_tic6x_c6xp): Likewise.
2465         * features/tic6x-core.c (create_feature_tic6x_core): Likewise.
2466         * features/tic6x-gp.c (create_feature_tic6x_gp): Likewise.
2467         * target-descriptions.c: In generated code, don't pass xml
2468         filename.
2469
2470 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
2471
2472         * common/tdesc.c (print_xml_feature::visit_pre): Add xml parsing.
2473         (print_xml_feature::visit_post): Likewise.
2474         (print_xml_feature::visit): Likewise.
2475         * common/tdesc.h (tdesc_get_features_xml): Use const tdesc.
2476         (print_xml_feature): Add new class.
2477         * regformats/regdat.sh: Null xmltarget on feature targets.
2478         * target-descriptions.c (struct target_desc): Add xmltarget.
2479         (maintenance_check_tdesc_xml_convert): Add unittest function.
2480         (tdesc_get_features_xml): Add function to get xml.
2481         (maintenance_check_xml_descriptions): Test xml generation.
2482         * xml-tdesc.c (string_read_description_xml): Add function.
2483         * xml-tdesc.h (string_read_description_xml): Add declaration.
2484
2485 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
2486
2487         * features/Makefile: Add feature marker to targets with new style
2488         target descriptions.
2489         * regformats/aarch64.dat: Regenerate.
2490         * regformats/i386/amd64-avx-avx512-linux.dat: Likewise.
2491         * regformats/i386/amd64-avx-linux.dat: Likewise.
2492         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Likewise.
2493         * regformats/i386/amd64-avx-mpx-linux.dat: Likewise.
2494         * regformats/i386/amd64-linux.dat: Likewise.
2495         * regformats/i386/amd64-mpx-linux.dat: Likewise.
2496         * regformats/i386/amd64.dat: Likewise.
2497         * regformats/i386/i386-avx-avx512-linux.dat: Likewise.
2498         * regformats/i386/i386-avx-linux.dat: Likewise.
2499         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Likewise.
2500         * regformats/i386/i386-avx-mpx-linux.dat: Likewise.
2501         * regformats/i386/i386-linux.dat: Likewise.
2502         * regformats/i386/i386-mmx-linux.dat: Likewise.
2503         * regformats/i386/i386-mpx-linux.dat: Likewise.
2504         * regformats/i386/i386.dat: Likewise.
2505         * regformats/i386/x32-avx-avx512-linux.dat: Likewise.
2506         * regformats/i386/x32-avx-linux.dat: Likewise.
2507         * regformats/i386/x32-linux.dat: Likewise.
2508         * regformats/tic6x-c62x-linux.dat: Likewise.
2509         * regformats/tic6x-c64x-linux.dat: Likewise.
2510         * regformats/tic6x-c64xp-linux.dat: Likewise.
2511         * regformats/regdat.sh: Parse feature marker.
2512
2513 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
2514
2515         * common/tdesc.h (tdesc_architecture_name): Add new declaration.
2516         (tdesc_osabi_name): Likewise.
2517         * target-descriptions.c (tdesc_architecture_name): Add new
2518         function.
2519         (tdesc_osabi_name): Likewise.
2520
2521 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
2522
2523         * common/tdesc.c (tdesc_predefined_type): Move to here.
2524         (tdesc_named_type): Likewise.
2525         (tdesc_create_vector): Likewise.
2526         (tdesc_create_struct): Likewise.
2527         (tdesc_set_struct_size): Likewise.
2528         (tdesc_create_union): Likewise.
2529         (tdesc_create_flags): Likewise.
2530         (tdesc_create_enum): Likewise.
2531         (tdesc_add_field): Likewise.
2532         (tdesc_add_typed_bitfield): Likewise.
2533         (tdesc_add_bitfield): Likewise.
2534         (tdesc_add_flag): Likewise.
2535         (tdesc_add_enum_value): Likewise.
2536         * common/tdesc.h (struct tdesc_type_builtin): Likewise.
2537         (struct tdesc_type_vector): Likewise.
2538         (struct tdesc_type_field): Likewise.
2539         (struct tdesc_type_with_fields): Likewise.
2540         (tdesc_create_enum): Add declaration.
2541         (tdesc_add_typed_bitfield): Likewise.
2542         (tdesc_add_enum_value): Likewise.
2543         * target-descriptions.c (tdesc_type_field): Move from here.
2544         (tdesc_type_builtin): Likewise.
2545         (tdesc_type_vector): Likewise.
2546         (tdesc_type_with_fields): Likewise.
2547         (tdesc_predefined_types): Likewise.
2548         (tdesc_named_type): Likewise.
2549         (tdesc_create_vector): Likewise.
2550         (tdesc_create_struct): Likewise.
2551         (tdesc_set_struct_size): Likewise.
2552         (tdesc_create_union): Likewise.
2553         (tdesc_create_flags): Likewise.
2554         (tdesc_create_enum): Likewise.
2555         (tdesc_add_field): Likewise.
2556         (tdesc_add_typed_bitfield): Likewise.
2557         (tdesc_add_bitfield): Likewise.
2558         (tdesc_add_flag): Likewise.
2559         (tdesc_add_enum_value): Likewise.
2560         * gdb/target-descriptions.h (tdesc_create_enum): Likewise.
2561         (tdesc_add_typed_bitfield): Likewise.
2562         (tdesc_add_enum_value): Likewise.
2563
2564 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
2565
2566         * common/tdesc.c (tdesc_feature::accept): Move to here.
2567         (tdesc_feature::operator==): Likewise.
2568         (tdesc_create_reg): Likewise.
2569         * common/tdesc.h (tdesc_type_kind): Likewise.
2570         (struct tdesc_type): Likewise.
2571         (struct tdesc_feature): Likewise.
2572         * regformats/regdat.sh: Create a feature.
2573         * target-descriptions.c (tdesc_type_kind): Move from here.
2574         (tdesc_type): Likewise.
2575         (tdesc_type_up): Likewise.
2576         (tdesc_feature): Likewise.
2577         (tdesc_create_reg): Likewise.
2578
2579 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
2580
2581         * Makefile.in: Add arch/tdesc.c
2582         * common/tdesc.c: New file.
2583         * common/tdesc.h (tdesc_element_visitor): Move to here.
2584         (tdesc_element): Likewise.
2585         (tdesc_reg): Likewise.
2586         (tdesc_reg_up): Likewise.
2587         * regformats/regdef.h (reg): Add offset to constructors.
2588         * target-descriptions.c (tdesc_element_visitor): Move from here.
2589         (tdesc_element): Likewise.
2590         (tdesc_reg): Likewise.
2591         (tdesc_reg_up): Likewise.
2592
2593 2018-04-17  Tom Tromey  <tom@tromey.com>
2594
2595         * dwarf2read.c (quirk_rust_enum): Conditionally drop the
2596         discriminant field.
2597
2598 2018-04-17  Tom Tromey  <tom@tromey.com>
2599
2600         * dwarf2read.c (quirk_rust_enum): Handle unions correctly.
2601
2602 2018-04-17  Andreas Arnez  <arnez@linux.vnet.ibm.com>
2603
2604         * symtab.c (print_symbol_info): Skip printing filename and line
2605         number when `last' is NULL.
2606         (symtab_symbol_info): Use empty string instead of NULL for first
2607         invocation of print_symbol_info.
2608         (rbreak_command): Pass NULL to `last' parameter of
2609         print_symbol_info.
2610
2611 2018-04-16  Simon Marchi  <simon.marchi@ericsson.com>
2612
2613         * linux-tdep.c (linux_spu_make_corefile_notes): Return note_data
2614         instead of nullptr.
2615
2616 2018-04-16  Pedro Alves  <palves@redhat.com>
2617
2618         * MAINTAINERS (sh): Remove.
2619         * Makefile.in (ALL_TARGET_OBS): Remove sh64-tdep.o.
2620         (HFILES_NO_SRCDIR): Remove sh64-tdep.h.
2621         (ALLDEPFILES): Remove sh64-tdep.c.
2622         * NEWS: Mentions that support for SH-5/SH64 is removed.
2623         * configure.tgt (sh*-*-linux*): Remove reference to sh64-tdep.o.
2624         (sh*-*-openbsd*): Ditto.
2625         (sh64-*-elf*): Remove.
2626         (sh*): Remove.
2627         * regcache.c (cooked_write_test): Remove bfd_mach_sh5 case.
2628         * sh-linux-tdep.c: Remove reference to bfd_mach_sh5.
2629         * sh-tdep.c: No longer include "sh64-tdep.h".
2630         (sh_gdbarch_init): Remove reference to bfd_mach_sh5.
2631         * sh64-tdep.c, sh64-tdep.h: Remove files.
2632
2633 2018-04-16  Pedro Alves  <palves@redhat.com>
2634
2635         * MAINTAINERS: Remove m88k.
2636         * Makefile.in (ALL_TARGET_OBS): Remove m88k-tdep.o.
2637         (HFILES_NO_SRCDIR): Remove m88k-tdep.h.
2638         (ALLDEPFILES): Remove m88k-bsd-nat.c and m88k-tdep.c.
2639         * NEWS: Mention that support for m88k was removed.
2640         * configure.host (m88*-*-*): Remove support.
2641         * configure.nat (m88k-*-*): Remove support.
2642         * configure.tgt (m88*-*-openbsd*): Remove.
2643         * m88k-bsd-nat.c, m88k-tdep.c, m88k-tdep.h: Delete.
2644
2645 2018-04-15  Simon Marchi  <simon.marchi@polymtl.ca>
2646
2647         * configure.tgt (x86_tobjs): New variable.
2648         (amd64_tobjs, i386_tobjs): Use it.
2649
2650 2018-04-13  Andreas Arnez  <arnez@linux.vnet.ibm.com>
2651
2652         * symtab.c (print_symbol_info): Precede the symbol definition by
2653         the line number when available.
2654         * NEWS: Advertise this enhancement.
2655
2656 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
2657
2658         * NEWS (New options): announce set/show record btrace cpu.
2659         * btrace.c: Include record-btrace.h.
2660         (btrace_compute_ftrace_pt): Skip enabling errata workarounds if
2661         the vendor is unknown.
2662         (btrace_compute_ftrace_1): Add cpu parameter.  Update callers.
2663         Maybe overwrite the btrace configuration's cpu.
2664         (btrace_compute_ftrace): Add cpu parameter.  Update callers.
2665         (btrace_fetch): Add cpu parameter.  Update callers.
2666         (btrace_maint_update_pt_packets): Call record_btrace_get_cpu.
2667         Maybe overwrite the btrace configuration's cpu.  Skip enabling
2668         errata workarounds if the vendor is unknown.
2669         * python/py-record-btrace.c: Include record-btrace.h.
2670         (recpy_bt_begin, recpy_bt_end, recpy_bt_instruction_history)
2671         (recpy_bt_function_call_history): Call record_btrace_get_cpu.
2672         * record-btrace.c (record_btrace_cpu_state_kind): New.
2673         (record_btrace_cpu): New.
2674         (set_record_btrace_cpu_cmdlist): New.
2675         (record_btrace_get_cpu): New.
2676         (require_btrace_thread, record_btrace_info)
2677         (record_btrace_resume_thread): Call record_btrace_get_cpu.
2678         (cmd_set_record_btrace_cpu_none): New.
2679         (cmd_set_record_btrace_cpu_auto): New.
2680         (cmd_set_record_btrace_cpu): New.
2681         (cmd_show_record_btrace_cpu): New.
2682         (_initialize_record_btrace): Initialize set/show record btrace cpu
2683         commands.
2684         * record-btrace.h (record_btrace_get_cpu): New.
2685
2686 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
2687
2688         * record.c (set_record_command): Fix typo in message.
2689
2690 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
2691
2692         * record-btrace.c (cmd_set_record_btrace): Print sub-commands.
2693
2694 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
2695
2696         * infrun.c (process_event_stop_test): Call
2697         gdbarch_in_indirect_branch_thunk.
2698         * gdbarch.sh (in_indirect_branch_thunk): New.
2699         * gdbarch.c: Regenerated.
2700         * gdbarch.h: Regenerated.
2701         * x86-tdep.h: New.
2702         * x86-tdep.c: New.
2703         * Makefile.in (ALL_TARGET_OBS): Add x86-tdep.o.
2704         (HFILES_NO_SRCDIR): Add x86-tdep.h.
2705         (ALLDEPFILES): Add x86-tdep.c.
2706         * arch-utils.h (default_in_indirect_branch_thunk): New.
2707         * arch-utils.c (default_in_indirect_branch_thunk): New.
2708         * i386-tdep: Include x86-tdep.h.
2709         (i386_in_indirect_branch_thunk): New.
2710         (i386_elf_init_abi): Set in_indirect_branch_thunk gdbarch
2711         function.
2712         * amd64-tdep: Include x86-tdep.h.
2713         (amd64_in_indirect_branch_thunk): New.
2714         (amd64_init_abi): Set in_indirect_branch_thunk gdbarch function.
2715
2716 2018-04-12  Jan Kratochvil  <jan.kratochvil@redhat.com>
2717
2718         PR gdb/23053
2719         * dwarf-index-write.c (data_buf::grow) (write_one_signatured_type)
2720         (recursively_write_psymbols) (debug_names::recursively_write_psymbols)
2721         (debug_names::write_one_signatured_type): Fix -D_GLIBCXX_DEBUG
2722         regression.
2723
2724 2018-04-12  Tom Tromey  <tom@tromey.com>
2725
2726         * rust-lang.c (rust_print_struct_def): Remove univariant code.
2727         (rust_evaluate_subexp): Likewise.
2728
2729 2018-04-12  Pedro Alves  <palves@redhat.com>
2730
2731         * procfs.c (procfs_detach): Make forward declaration's prototype
2732         match definition's protototype.
2733         (proc_get_LDT_entry): Remove stale do_cleanups call.
2734
2735 2018-04-12  Pedro Alves  <palves@redhat.com>
2736
2737         * target.h (target_ops::to_has_exited): Delete.
2738         (target_has_exited): Delete.
2739         * target-delegates.c: Regenerate.
2740
2741 2018-04-11  Pedro Alves  <palves@redhat.com>
2742
2743         * target.c (fileio_fh_t::t): Add comment.
2744         (target_fileio_pwrite, target_fileio_pread, target_fileio_fstat)
2745         (target_fileio_close): Handle a NULL target.
2746         (invalidate_fileio_fh): New.
2747         (target_close): Call it.
2748         * remote.c (remote_hostio_send_command): No longer check whether
2749         remote_desc is open.
2750
2751 2018-04-11  Pedro Alves  <palves@redhat.com>
2752
2753         * target.c (fileio_fh_t): Make it a named struct instead of a
2754         typedef.
2755         (fileio_fh_t::is_closed): New method.
2756         (DEF_VEC_O (fileio_fh_t)): Remove.
2757         (fileio_fhandles): Now a std::vector.
2758         (is_closed_fileio_fh): Delete.
2759         (acquire_fileio_fd): Adjust.  Rename parameters.
2760         (release_fileio_fd): Adjust.
2761         (fileio_fd_to_fh): Reimplement as a function instead of a macro.
2762         (target_fileio_pwrite, target_fileio_pread, target_fileio_fstat)
2763         (target_fileio_close): Adjust.
2764
2765 2018-04-10  Simon Marchi  <simon.marchi@ericsson.com>
2766
2767         * auto-load.c (auto_load_safe_path_vec_update): Iterate by
2768         index.
2769
2770 2018-04-10  Pedro Alves  <palves@redhat.com>
2771
2772         * gdbthread.h (finish_thread_state_cleanup): Delete declaration.
2773         (scoped_finish_thread_state): New class.
2774         * infcmd.c (run_command_1): Use it instead of finish_thread_state
2775         cleanup.
2776         * infrun.c (proceed, prepare_for_detach, wait_for_inferior)
2777         (fetch_inferior_event, normal_stop): Likewise.
2778         * thread.c (finish_thread_state_cleanup): Delete.
2779
2780 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
2781             Pedro Alves  <palves@redhat.com>
2782
2783         * value.c: Include "selftest.h" and "common/array-view.h".
2784         (struct range) <operator ==>: New.
2785         (test_ranges_contain): New.
2786         (check_ranges_vector): New.
2787         (test_insert_into_bit_range_vector): New.
2788         (_initialize_values): Register selftests.
2789         * common/array-view.h (operator==, operator!=): New.
2790
2791 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
2792
2793         * common/gdb_vecs.h (unordered_remove): Add overload that takes
2794         an iterator.
2795         * inline-frame.c: Include <algorithm>.
2796         (struct inline_state): Add constructor.
2797         (inline_state_s): Remove.
2798         (DEF_VEC_O(inline_state_s)): Remove.
2799         (inline_states): Change type to std::vector.
2800         (find_inline_frame_state): Adjust to std::vector.
2801         (allocate_inline_frame_state): Remove.
2802         (clear_inline_frame_state): Adjust to std::vector.
2803         (skip_inline_frames): Adjust to std::vector.
2804
2805 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
2806
2807         * tracepoint.h (struct trace_state_variable): Add constructor.
2808         <name>: Change type to std::string.
2809         * tracepoint.c (tsv_s): Remove.
2810         (DEF_VEC_O(tsv_s)): Remove.
2811         (tvariables): Change to std::vector.
2812         (create_trace_state_variable): Adjust to std::vector.
2813         (find_trace_state_variable): Likewise.
2814         (find_trace_state_variable_by_number): Likewise.
2815         (delete_trace_state_variable): Likewise.
2816         (trace_variable_command): Adjust to std::string.
2817         (delete_trace_variable_command): Likewise.
2818         (tvariables_info_1): Adjust to std::vector.
2819         (save_trace_state_variables): Likewise.
2820         (start_tracing): Likewise.
2821         (merge_uploaded_trace_state_variables): Adjust to std::vector
2822         and std::string.
2823         * target.h (struct target_ops)
2824         <to_download_trace_state_variable>: Pass reference to
2825         trace_state_variable.
2826         * target-debug.h (target_debug_print_const_trace_state_variable_r): New.
2827         * target-delegates.c: Re-generate.
2828         * mi/mi-interp.c (mi_tsv_created): Adjust to std::string.
2829         (mi_tsv_deleted): Likewise.
2830         * mi/mi-main.c (mi_cmd_trace_frame_collected): Likewise.
2831         * remote.c (remote_download_trace_state_variable): Change
2832         pointer to reference and adjust.
2833         * make-target-delegates (parse_argtypes): Handle references.
2834         (write_function_header): Likewise.
2835         (munge_type): Likewise.
2836
2837 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
2838
2839         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
2840         string_view-selftests.c.
2841         * unittests/basic_string_view/capacity/1.cc: Adapt to GDB
2842         testsuite.
2843         * unittests/basic_string_view/cons/char/1.cc: Likewise.
2844         * unittests/basic_string_view/cons/char/2.cc: Likewise.
2845         * unittests/basic_string_view/cons/char/3.cc: Likewise.
2846         * unittests/basic_string_view/element_access/char/1.cc:
2847         Likewise.
2848         * unittests/basic_string_view/element_access/char/empty.cc:
2849         Likewise.
2850         * unittests/basic_string_view/element_access/char/front_back.cc:
2851         Likewise.
2852         * unittests/basic_string_view/inserters/char/2.cc: Likewise.
2853         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc:
2854         Likewise.
2855         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc:
2856         Likewise.
2857         * unittests/basic_string_view/modifiers/swap/char/1.cc:
2858         Likewise.
2859         * unittests/basic_string_view/operations/compare/char/1.cc:
2860         Likewise.
2861         * unittests/basic_string_view/operations/compare/char/13650.cc:
2862         Likewise.
2863         * unittests/basic_string_view/operations/copy/char/1.cc:
2864         Likewise.
2865         * unittests/basic_string_view/operations/data/char/1.cc:
2866         Likewise.
2867         * unittests/basic_string_view/operations/find/char/1.cc:
2868         Likewise.
2869         * unittests/basic_string_view/operations/find/char/2.cc:
2870         Likewise.
2871         * unittests/basic_string_view/operations/find/char/3.cc:
2872         Likewise.
2873         * unittests/basic_string_view/operations/find/char/4.cc:
2874         Likewise.
2875         * unittests/basic_string_view/operations/rfind/char/1.cc:
2876         Likewise.
2877         * unittests/basic_string_view/operations/rfind/char/2.cc:
2878         Likewise.
2879         * unittests/basic_string_view/operations/rfind/char/3.cc:
2880         Likewise.
2881         * unittests/basic_string_view/operations/substr/char/1.cc:
2882         Likewise.
2883         * unittests/basic_string_view/operators/char/2.cc: Likewise.
2884         * unittests/string_view-selftests.c: New file.
2885
2886 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
2887
2888         * unittests/basic_string_view/capacity/1.cc: New file.
2889         * unittests/basic_string_view/capacity/empty_neg.cc: New file.
2890         * unittests/basic_string_view/cons/char/1.cc: New file.
2891         * unittests/basic_string_view/cons/char/2.cc: New file.
2892         * unittests/basic_string_view/cons/char/3.cc: New file.
2893         * unittests/basic_string_view/cons/wchar_t/1.cc: New file.
2894         * unittests/basic_string_view/cons/wchar_t/2.cc: New file.
2895         * unittests/basic_string_view/cons/wchar_t/3.cc: New file.
2896         * unittests/basic_string_view/element_access/char/1.cc: New file.
2897         * unittests/basic_string_view/element_access/char/2.cc: New file.
2898         * unittests/basic_string_view/element_access/char/empty.cc: New file.
2899         * unittests/basic_string_view/element_access/char/front_back.cc: New file.
2900         * unittests/basic_string_view/element_access/wchar_t/1.cc: New file.
2901         * unittests/basic_string_view/element_access/wchar_t/2.cc: New file.
2902         * unittests/basic_string_view/element_access/wchar_t/empty.cc: New file.
2903         * unittests/basic_string_view/element_access/wchar_t/front_back.cc: New file.
2904         * unittests/basic_string_view/include.cc: New file.
2905         * unittests/basic_string_view/inserters/char/1.cc: New file.
2906         * unittests/basic_string_view/inserters/char/2.cc: New file.
2907         * unittests/basic_string_view/inserters/char/3.cc: New file.
2908         * unittests/basic_string_view/inserters/pod/10081-out.cc: New file.
2909         * unittests/basic_string_view/inserters/wchar_t/1.cc: New file.
2910         * unittests/basic_string_view/inserters/wchar_t/2.cc: New file.
2911         * unittests/basic_string_view/inserters/wchar_t/3.cc: New file.
2912         * unittests/basic_string_view/literals/types.cc: New file.
2913         * unittests/basic_string_view/literals/values.cc: New file.
2914         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc: New file.
2915         * unittests/basic_string_view/modifiers/remove_prefix/wchar_t/1.cc: New file.
2916         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc: New file.
2917         * unittests/basic_string_view/modifiers/remove_suffix/wchar_t/1.cc: New file.
2918         * unittests/basic_string_view/modifiers/swap/char/1.cc: New file.
2919         * unittests/basic_string_view/modifiers/swap/wchar_t/1.cc: New file.
2920         * unittests/basic_string_view/operations/compare/char/1.cc: New file.
2921         * unittests/basic_string_view/operations/compare/char/13650.cc: New file.
2922         * unittests/basic_string_view/operations/compare/char/2.cc: New file.
2923         * unittests/basic_string_view/operations/compare/char/70483.cc: New file.
2924         * unittests/basic_string_view/operations/compare/wchar_t/1.cc: New file.
2925         * unittests/basic_string_view/operations/compare/wchar_t/13650.cc: New file.
2926         * unittests/basic_string_view/operations/compare/wchar_t/2.cc: New file.
2927         * unittests/basic_string_view/operations/copy/char/1.cc: New file.
2928         * unittests/basic_string_view/operations/copy/wchar_t/1.cc: New file.
2929         * unittests/basic_string_view/operations/data/char/1.cc: New file.
2930         * unittests/basic_string_view/operations/data/wchar_t/1.cc: New file.
2931         * unittests/basic_string_view/operations/find/char/1.cc: New file.
2932         * unittests/basic_string_view/operations/find/char/2.cc: New file.
2933         * unittests/basic_string_view/operations/find/char/3.cc: New file.
2934         * unittests/basic_string_view/operations/find/char/4.cc: New file.
2935         * unittests/basic_string_view/operations/find/wchar_t/1.cc: New file.
2936         * unittests/basic_string_view/operations/find/wchar_t/2.cc: New file.
2937         * unittests/basic_string_view/operations/find/wchar_t/3.cc: New file.
2938         * unittests/basic_string_view/operations/find/wchar_t/4.cc: New file.
2939         * unittests/basic_string_view/operations/rfind/char/1.cc: New file.
2940         * unittests/basic_string_view/operations/rfind/char/2.cc: New file.
2941         * unittests/basic_string_view/operations/rfind/char/3.cc: New file.
2942         * unittests/basic_string_view/operations/rfind/wchar_t/1.cc: New file.
2943         * unittests/basic_string_view/operations/rfind/wchar_t/2.cc: New file.
2944         * unittests/basic_string_view/operations/rfind/wchar_t/3.cc: New file.
2945         * unittests/basic_string_view/operations/string_conversion/1.cc: New file.
2946         * unittests/basic_string_view/operations/substr/char/1.cc: New file.
2947         * unittests/basic_string_view/operations/substr/wchar_t/1.cc: New file.
2948         * unittests/basic_string_view/operators/char/2.cc: New file.
2949         * unittests/basic_string_view/operators/wchar_t/2.cc: New file.
2950         * unittests/basic_string_view/range_access/char/1.cc: New file.
2951         * unittests/basic_string_view/range_access/wchar_t/1.cc: New file.
2952         * unittests/basic_string_view/requirements/explicit_instantiation/1.cc: New file.
2953         * unittests/basic_string_view/requirements/explicit_instantiation/char/1.cc: New file.
2954         * unittests/basic_string_view/requirements/explicit_instantiation/char16_t/1.cc: New file.
2955         * unittests/basic_string_view/requirements/explicit_instantiation/char32_t/1.cc: New file.
2956         * unittests/basic_string_view/requirements/explicit_instantiation/wchar_t/1.cc: New file.
2957         * unittests/basic_string_view/requirements/typedefs.cc: New file.
2958         * unittests/basic_string_view/typedefs.cc: New file.
2959         * unittests/basic_string_view/types/1.cc: New file.
2960
2961 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
2962
2963         * common/gdb_string_view.h: Remove libstdc++ implementation
2964         details, adjust to gdb reality.
2965         * common/gdb_string_view.tcc: Likewise.
2966         * cli/cli-script.c (struct string_view): Remove.
2967         (user_args) <m_args>: Change element type to gdb::string_view.
2968         (user_args::insert_args): Adjust.
2969
2970 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
2971
2972         * common/gdb_string_view.h: New file.
2973         * common/gdb_string_view.tcc: New file.
2974
2975 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
2976
2977         * ax_cxx_compile_stdcxx.m4: Sync with upstream.
2978         * configure: Re-generate.
2979
2980 2018-04-09  Pedro Alves  <palves@redhat.com>
2981
2982         * gdbarch.sh: Include "observable.h" instead of "observer.h".
2983         (set_target_gdbarch): Call
2984         gdb::observers::architecture_changed.notify instead of
2985         observer_notify_architecture_changed.
2986
2987 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
2988
2989         * tracepoint.c (struct current_traceframe_cleanup): Remove.
2990         (do_restore_current_traceframe_cleanup): Remove.
2991         (restore_current_traceframe_cleanup_dtor): Remove.
2992         (make_cleanup_restore_current_traceframe): Remove.
2993         (scoped_restore_current_traceframe::scoped_restore_current_traceframe):
2994         New.
2995         * tracepoint.h (struct scoped_restore_current_traceframe): New.
2996         * infrun.c (fetch_inferior_event): Use
2997         scoped_restore_current_traceframe.
2998
2999 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3000
3001         * dwarf2read.h (struct dwarf2_per_objfile) <n_type_units>:
3002         Remove.
3003         <n_allocated_type_units>: Remove.
3004         <all_type_units>: Change to std::vector.
3005         * dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile): Adjust
3006         to std::vector change.
3007         (dwarf2_per_objfile::get_cutu): Likewise.
3008         (dwarf2_per_objfile::get_tu): Likewise.
3009         (create_signatured_type_table_from_index): Likewise.
3010         (create_signatured_type_table_from_debug_names): Likewise.
3011         (dw2_symtab_iter_next): Likewise.
3012         (dw2_print_stats): Likewise.
3013         (dw2_expand_all_symtabs): Likewise.
3014         (dw2_expand_marked_cus): Likewise.
3015         (dw2_debug_names_iterator::next): Likewise.
3016         (dwarf2_initialize_objfile): Likewise.
3017         (add_signatured_type_cu_to_table): Likewise.
3018         (create_all_type_units): Likewise.
3019         (add_type_unit): Likewise.
3020         (struct tu_abbrev_offset): Add constructor.
3021         (build_type_psymtabs_1): Adjust to std::vector change.
3022         (print_tu_stats): Likewise.
3023         * dwarf-index-write.c (check_dwarf64_offsets): Likewise.
3024         (write_debug_names): Likewise.
3025
3026 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3027
3028         * dwarf2read.h (struct dwarf2_per_objfile) <all_comp_units>: Likewise.
3029         Make an std::vector.
3030         <n_comp_units>: Remove.
3031         * dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile): Adjust
3032         to std::vector change.
3033         (dwarf2_per_objfile::get_cutu): Likewise.
3034         (dwarf2_per_objfile::get_cu): Likewise.
3035         (create_cus_from_index): Likewise.
3036         (create_addrmap_from_index): Likewise.
3037         (create_addrmap_from_aranges): Likewise.
3038         (dwarf2_read_index): Likewise.
3039         (dw2_find_last_source_symtab): Likewise.
3040         (dw2_map_symtabs_matching_filename): Likewise.
3041         (dw2_symtab_iter_next): Likewise.
3042         (dw2_print_stats): Likewise.
3043         (dw2_expand_all_symtabs): Likewise.
3044         (dw2_expand_symtabs_with_fullname): Likewise.
3045         (dw2_expand_marked_cus): Likewise.
3046         (dw2_map_symbol_filenames): Likewise.
3047         (create_cus_from_debug_names): Likewise.
3048         (dwarf2_read_debug_names): Likewise.
3049         (dw2_debug_names_iterator::next): Likewise.
3050         (dwarf2_initialize_objfile): Likewise.
3051         (set_partial_user): Likewise.
3052         (dwarf2_build_psymtabs_hard): Likewise.
3053         (read_comp_units_from_section): Remove arguments, adjust to
3054         std::vector change.
3055         (create_all_comp_units): Adjust to std::vector and
3056         read_comp_units_from_section changes.
3057         (dwarf2_find_containing_comp_unit): Adjust to std::vector
3058         change.
3059         * dwarf-index-write.c (check_dwarf64_offsets): Likewise.
3060         (psyms_seen_size): Likewise.
3061         (write_gdbindex): Likewise.
3062         (write_debug_names): Likewise.
3063
3064 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3065
3066         * dwarf2read.c (create_cus_from_index_list): Replace objfile arg
3067         with dwarf2_per_objfile.
3068         (create_cus_from_index): Likewise.
3069         (create_signatured_type_table_from_index): Likewise.
3070         (dwarf2_read_index): Likewise.
3071         (dwarf2_initialize_objfile): Likewise.
3072         (dwarf2_fetch_die_loc_sect_off):  Get dwarf2_per_objfile from
3073         per_cu rather than get_dwarf2_per_objfile.
3074
3075 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3076
3077         * dwarf2read.h (struct signatured_type): Forward declare.
3078         (struct dwarf2_per_objfile) <get_cutu, get_cu, get_tu>:
3079         New methods.
3080         * dwarf2read.c (dwarf2_per_objfile::get_cutu): Rename from...
3081         (dw2_get_cutu): ...this.
3082         (dwarf2_per_objfile::get_cu): Rename from...
3083         (dw2_get_cu): ...this.
3084         (dwarf2_per_objfile::get_tu): New.
3085         (create_addrmap_from_index): Adjust.
3086         (create_addrmap_from_aranges): Adjust.
3087         (dw2_find_last_source_symtab): Adjust.
3088         (dw2_map_symtabs_matching_filename): Adjust.
3089         (dw2_symtab_iter_next): Adjust.
3090         (dw2_print_stats): Adjust.
3091         (dw2_expand_all_symtabs): Adjust.
3092         (dw2_expand_symtabs_with_fullname): Adjust.
3093         (dw2_expand_marked_cus): Adjust.
3094         (dw_expand_symtabs_matching_file_matcher): Adjust.
3095         (dw2_map_symbol_filenames): Adjust.
3096         (dw2_debug_names_iterator::next): Adjust.
3097         (dwarf2_initialize_objfile): Adjust.
3098         (set_partial_user): Adjust.
3099         (dwarf2_build_psymtabs_hard): Adjust.
3100
3101 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3102
3103         * dwarf2read.c (create_signatured_type_table_from_debug_names):
3104         Remove unused variables.
3105         (dw2_map_symtabs_matching_filename): Likewise.
3106         (dwarf2_record_block_ranges): Likewise.
3107         (dwarf2_read_addr_index): Likewise.
3108         (follow_die_offset): Likewise.
3109
3110 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3111
3112         * progspace.c (clone_program_space): Pass SYMFILE_DEFER_BP_RESET
3113         to symbol_file_add_main.
3114
3115 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3116
3117         PR mi/22299
3118         * mi/mi-console.c (do_fputc_async_safe): New.
3119         (mi_console_file::write_async_safe): New.
3120         (mi_console_file::flush): Adjust calls to fputstrn_unfiltered.
3121         * mi/mi-console.h (class mi_console_file) <write_async_safe>:
3122         New.
3123         * ui-file.c (ui_file::putstrn): Adjust call to
3124         fputstrn_unfiltered.
3125         * utils.c (printchar): Replace do_fputs and do_fprintf
3126         parameters by do_fputc.
3127         (fputstr_filtered): Adjust call to printchar.
3128         (fputstr_unfiltered): Likewise.
3129         (fputstrn_filtered): Likewise.
3130         (fputstrn_unfiltered): Add do_fputc parameter, pass to
3131         printchar.
3132         * utils.h (do_fputc_ftype): New typedef.
3133         (fputstrn_unfiltered): Add do_fputc parameter.
3134
3135 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3136
3137         * regformats/i386/i386-avx.dat: Remove.
3138
3139 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
3140
3141         PR gdb/22979
3142         * amd64-tdep.c (amd64_none_init_abi): New function.
3143         (amd64_x32_none_init_abi): New function.
3144         (_initialize_amd64_tdep): Register handlers for x86-64 and
3145         x64_32 with GDB_OSABI_NONE.
3146         * osabi.c (gdbarch_init_osabi): Allow running handlers for the
3147         GDB_OSABI_NONE osabi.
3148
3149 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
3150
3151         PR gdb/22980
3152         * defs.h (enum gdb_osabi): Remove GDB_OSABI_UNINITIALIZED, add
3153         GDB_OSABI_NONE.
3154         * arch-utils.c (gdbarch_info_init): Don't set info->osabi.
3155         * osabi.c (gdb_osabi_names): Add "unknown" entry.
3156
3157 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
3158
3159         * common/byte-vector.h (char_vector): New type.
3160         * target.h (target_read_alloc): Return
3161         gdb::optional<byte_vector>.
3162         (target_read_stralloc): Return gdb::optional<char_vector>.
3163         (target_get_osdata): Return gdb::optional<char_vector>.
3164         * target.c (target_read_alloc_1): Templatize.  Replacement
3165         manual memory management with vector.
3166         (target_read_alloc): Change return type, adjust.
3167         (target_read_stralloc): Change return type, adjust.
3168         (target_get_osdata): Change return type, adjust.
3169         * auxv.c (struct auxv_info) <length>: Remove.
3170         <data>: Change type to gdb::optional<byte_vector>.
3171         (auxv_inferior_data_cleanup): Free auxv_info with delete.
3172         (get_auxv_inferior_data): Allocate auxv_info with new, adjust.
3173         (target_auxv_search): Adjust.
3174         (fprint_target_auxv): Adjust.
3175         * avr-tdep.c (avr_io_reg_read_command): Adjust.
3176         * linux-tdep.c (linux_spu_make_corefile_notes): Adjust.
3177         (linux_make_corefile_notes): Adjust.
3178         * osdata.c (get_osdata): Adjust.
3179         * remote.c (remote_get_threads_with_qxfer): Adjust.
3180         (remote_memory_map): Adjust.
3181         (remote_traceframe_info): Adjust.
3182         (btrace_read_config): Adjust.
3183         (remote_read_btrace): Adjust.
3184         (remote_pid_to_exec_file): Adjust.
3185         * solib-aix.c (solib_aix_get_library_list): Adjust.
3186         * solib-dsbt.c (decode_loadmap): Don't free buf.
3187         (dsbt_get_initial_loadmaps): Adjust.
3188         * solib-svr4.c (svr4_current_sos_via_xfer_libraries): Adjust.
3189         * solib-target.c (solib_target_current_sos): Adjust.
3190         * tracepoint.c (sdata_make_value): Adjust.
3191         * xml-support.c (xinclude_start_include): Adjust.
3192         (xml_fetch_content_from_file): Adjust.
3193         * xml-support.h (xml_fetch_another): Change return type.
3194         (xml_fetch_content_from_file): Change return type.
3195         * xml-syscall.c (xml_init_syscalls_info): Adjust.
3196         * xml-tdesc.c (file_read_description_xml): Adjust.
3197         (fetch_available_features_from_target): Change return type.
3198         (target_fetch_description_xml): Adjust.
3199         (target_read_description_xml): Adjust.
3200
3201 2018-04-06  Tom Tromey  <tom@tromey.com>
3202
3203         * value.c (~value): Update.
3204         (struct value) <contents>: Now unique_xmalloc_ptr.
3205         (value_contents_bits_eq, allocate_value_contents)
3206         (value_contents_raw, value_contents_all_raw)
3207         (value_contents_for_printing, value_contents_for_printing_const)
3208         (set_value_enclosing_type): Update.
3209
3210 2018-04-06  Tom Tromey  <tom@tromey.com>
3211
3212         * value.c (range_s): Remove typedef, VEC.
3213         (struct range): Add operator<.
3214         (range_lessthan): Remove.
3215         (ranges_contain): Change type.
3216         (~value): Update.
3217         (struct value) <unavailable, optimized_out>: Now std::vector.
3218         (value_entirely_available)
3219         (value_entirely_covered_by_range_vector)
3220         (value_entirely_unavailable, value_entirely_optimized_out):
3221         Update.
3222         (insert_into_bit_range_vector): Change argument type.
3223         (find_first_range_overlap): Likewise.
3224         (struct ranges_and_idx, value_contents_bits_eq)
3225         (require_not_optimized_out, require_available): Update.
3226         (ranges_copy_adjusted): Change argument types.
3227         (value_optimized_out, value_copy, value_fetch_lazy): Update.
3228
3229 2018-04-06  Tom Tromey  <tom@tromey.com>
3230
3231         * value.c (~value): Update.
3232         (struct value) <parent>: Now a value_ref_ptr.
3233         (value_parent, set_value_parent, value_address, value_copy):
3234         Update.
3235
3236 2018-04-06  Tom Tromey  <tom@tromey.com>
3237
3238         * value.c (struct value): Add constructor, destructor, and member
3239         initializers.
3240         (allocate_value_lazy, value_decref): Update.
3241
3242 2018-04-06  Tom Tromey  <tom@tromey.com>
3243
3244         * value.c (struct value) <released, next>: Remove.
3245         (all_values): Now a std::vector.
3246         (allocate_value_lazy): Update.
3247         (value_next): Remove.
3248         (value_mark, value_free_to_mark, release_value)
3249         (value_release_to_mark): Update.
3250
3251 2018-04-06  Tom Tromey  <tom@tromey.com>
3252
3253         * value.h (fetch_subexp_value, value_release_to_mark): Update.
3254         (free_value_chain): Remove.
3255         * value.c (free_value_chain): Remove.
3256         (value_release_to_mark): Return a std::vector.
3257         * ppc-linux-nat.c (num_memory_accesses): Change "chain" to a
3258         std::vector.
3259         (check_condition): Update.
3260         * eval.c (fetch_subexp_value): Change "val_chain" to a
3261         std::vector.
3262         * breakpoint.c (update_watchpoint): Update.
3263         (can_use_hardware_watchpoint): Change "vals" to a std::vector.
3264
3265 2018-04-06  Tom Tromey  <tom@tromey.com>
3266
3267         * value.h (free_all_values): Remove.
3268         * value.c (free_all_values): Remove.
3269
3270 2018-04-06  Tom Tromey  <tom@tromey.com>
3271
3272         * value.c (VALUE_HISTORY_CHUNK, struct value_history_chunk)
3273         (value_history_chain, value_history_count): Remove.
3274         (value_history): New global.
3275         (record_latest_value, access_value_history, show_values)
3276         (preserve_values): Update.
3277
3278 2018-04-06  Tom Tromey  <tom@tromey.com>
3279
3280         * varobj.h (struct varobj) <value>: Now a value_ref_ptr.
3281         * varobj.c (varobj_set_display_format, varobj_set_value)
3282         (install_default_visualizer, construct_visualizer)
3283         (install_new_value, ~varobj, varobj_get_value_type)
3284         (my_value_of_variable, varobj_editable_p): Update.
3285         * c-varobj.c (c_describe_child, c_value_of_variable)
3286         (cplus_number_of_children, cplus_describe_child): Update.
3287         * ada-varobj.c (ada_number_of_children, ada_name_of_child)
3288         (ada_path_expr_of_child, ada_value_of_child, ada_type_of_child)
3289         (ada_value_of_variable, ada_value_is_changeable_p): Update.
3290
3291 2018-04-06  Tom Tromey  <tom@tromey.com>
3292
3293         * printcmd.c (last_examine_address): Change type to
3294         value_ref_ptr.
3295         (do_examine, x_command): Update.
3296
3297 2018-04-06  Tom Tromey  <tom@tromey.com>
3298
3299         * value.c (release_value): Update.
3300         * breakpoint.h (struct watchpoint) <val>: Now a value_ref_ptr.
3301         (struct bpstats) <val>: Now a value_ref_ptr.
3302         * breakpoint.c (update_watchpoint, breakpoint_init_inferior)
3303         (~bpstats, bpstats, bpstat_clear_actions, watchpoint_check)
3304         (~watchpoint, print_it_watchpoint, watch_command_1)
3305         (invalidate_bp_value_on_memory_change): Update.
3306
3307 2018-04-06  Tom Tromey  <tom@tromey.com>
3308
3309         * varobj.c (varobj_clear_saved_item)
3310         (update_dynamic_varobj_children, install_new_value, ~varobj):
3311         Update.
3312         * value.h (value_incref): Move declaration earlier.
3313         (value_decref): Rename from value_free.
3314         (struct value_ref_policy): New.
3315         (value_ref_ptr): New typedef.
3316         (struct value_deleter): Remove.
3317         (gdb_value_up): Remove typedef.
3318         (release_value): Change return type.
3319         (release_value_or_incref): Remove.
3320         * value.c (set_value_parent): Update.
3321         (value_incref): Change return type.
3322         (value_decref): Rename from value_free.
3323         (value_free_to_mark, free_all_values, free_value_chain): Update.
3324         (release_value): Return value_ref_ptr.
3325         (release_value_or_incref): Remove.
3326         (record_latest_value, set_internalvar, clear_internalvar):
3327         Update.
3328         * stack.c (info_frame_command): Don't call value_free.
3329         * python/py-value.c (valpy_dealloc, valpy_new)
3330         (value_to_value_object): Update.
3331         * printcmd.c (do_examine): Update.
3332         * opencl-lang.c (lval_func_free_closure): Update.
3333         * mi/mi-main.c (register_changed_p): Don't call value_free.
3334         * mep-tdep.c (mep_frame_prev_register): Don't call value_free.
3335         * m88k-tdep.c (m88k_frame_prev_register): Don't call value_free.
3336         * m68hc11-tdep.c (m68hc11_frame_prev_register): Don't call
3337         value_free.
3338         * guile/scm-value.c (vlscm_free_value_smob)
3339         (vlscm_scm_from_value): Update.
3340         * frame.c (frame_register_unwind, frame_unwind_register_signed)
3341         (frame_unwind_register_unsigned, get_frame_register_bytes)
3342         (put_frame_register_bytes): Don't call value_free.
3343         * findvar.c (address_from_register): Don't call value_free.
3344         * dwarf2read.c (dwarf2_compute_name): Don't call value_free.
3345         * dwarf2loc.c (entry_data_value_free_closure)
3346         (value_of_dwarf_reg_entry, free_pieced_value_closure)
3347         (dwarf2_evaluate_loc_desc_full): Update.
3348         * breakpoint.c (update_watchpoint, breakpoint_init_inferior)
3349         (~bpstats, bpstats, bpstat_clear_actions, watchpoint_check)
3350         (~watchpoint, watch_command_1)
3351         (invalidate_bp_value_on_memory_change): Update.
3352         * alpha-tdep.c (alpha_register_to_value): Don't call value_free.
3353
3354 2018-04-06  Simon Marchi  <simon.marchi@polymtl.ca>
3355
3356         PR gdb/23022
3357         * warning.m4: Add -Wno-error=deprecated-register.
3358         * configure: Re-generate.
3359
3360 2018-04-05  Tom Tromey  <tom@tromey.com>
3361
3362         * linespec.h: Remove include of "vec.h".
3363
3364 2018-04-05  Tom Tromey  <tom@tromey.com>
3365
3366         * linespec.c (typep): Remove typedef.
3367         (find_methods, find_superclass_methods): Take a std::vector.
3368         (find_method): Use std::vector.
3369
3370 2018-04-05  Tom Tromey  <tom@tromey.com>
3371
3372         * utils.c (compare_strings): Remove.
3373         * utils.h (compare_strings): Remove.
3374         * objc-lang.h (find_imps): Update.
3375         * objc-lang.c (find_methods): Take a std::vector.
3376         (uniquify_strings, find_imps): Likewise.
3377         * linespec.c (find_methods): Take a std::vector.
3378         (decode_objc): Use std::vector.
3379         (add_all_symbol_names_from_pspace, find_superclass_methods): Take
3380         a std::vector.
3381         (find_method, find_function_symbols): Use std::vector.
3382
3383 2018-04-05  Tom Tromey  <tom@tromey.com>
3384
3385         * completer.c (completion_tracker::completion_tracker): Remove
3386         cast.
3387         (completion_tracker::discard_completions): Likewise.
3388         * breakpoint.c (ambiguous_names_p): Remove cast.
3389         * ada-lang.c (_initialize_ada_language): Remove cast.
3390         * utils.h (streq): Update.
3391         (streq_hash): Add new declaration.
3392         * utils.c (streq): Return bool.
3393         (streq_hash): New function.
3394
3395 2018-04-05  Tom Tromey  <tom@tromey.com>
3396
3397         * linespec.c (event_location_to_sals) <case ADDRESS_LOCATION>:
3398         Remove a string copy.
3399
3400 2018-04-05  Tom Tromey  <tom@tromey.com>
3401
3402         * linespec.c (filter_results): Use std::vector.
3403         (decode_line_2, decode_line_full): Update.
3404
3405 2018-04-05  Tom Tromey  <tom@tromey.com>
3406
3407         * linespec.c (canonical_to_fullform): Return std::string.
3408         (filter_results): Update.
3409         (struct decode_line_2_item): Add constructor.
3410         <fullform, displayform>: Now std::string.
3411         (decode_line_2_compare_items): Now a std::sort comparator.
3412         (decode_line_2): Update.
3413
3414 2018-04-05  Tom Tromey  <tom@tromey.com>
3415
3416         * linespec.c (copy_token_string): Return a unique_xmalloc_ptr.
3417         (unexpected_linespec_error): Update.
3418         (linespec_parse_basic, parse_linespec): Update.
3419
3420 2018-04-05  Tom Tromey  <tom@tromey.com>
3421
3422         * linespec.c (linespec_parse_basic): Reindent.
3423
3424 2018-04-05  Tom Tromey  <tom@tromey.com>
3425
3426         * minsyms.h (iterate_over_minimal_symbols): Update.
3427         * minsyms.c (iterate_over_minimal_symbols): Take a
3428         gdb::function_view.
3429         * linespec.c (struct collect_minsyms): Remove.
3430         (compare_msyms): Now a std::sort comparator.
3431         (add_minsym): Add parameters.
3432         (search_minsyms_for_name): Update.  Use std::vector.
3433
3434 2018-04-03  Tom Tromey  <tom@tromey.com>
3435
3436         * mipsread.c (read_alphacoff_dynamic_symtab): Use
3437         gdb::byte_vector.
3438
3439 2018-04-02  Weimin Pan  <weimin.pan@oracle.com>
3440
3441         * MAINTAINERS (Write After Approval): Add Weimin Pan.
3442
3443 2018-04-02  Weimin Pan  <weimin.pan@oracle.com>
3444
3445         PR gdb/16959
3446         * cp-valprint.c: (cp_print_static_field) Fix infinite recursion when
3447         printing static type.
3448
3449 2018-04-01  Tom Tromey  <tom@tromey.com>
3450
3451         * rs6000-nat.c (rs6000_ptrace_ldinfo): Return a byte_vector.
3452         (rs6000_xfer_shared_libraries): Update.
3453
3454 2018-04-01  Simon Marchi  <simon.marchi@polymtl.ca>
3455
3456         * common/gdb_vecs.h (char_ptr): Remove.
3457         * tracepoint.c (encode_actions_1): Remove usage of char_ptr.
3458
3459 2018-03-30  Simon Marchi  <simon.marchi@polymtl.ca>
3460
3461         * guile/scm-utils.c (gdbscm_parse_function_args): Replace VEC
3462         with std::vector.
3463         * common/gdb_vecs.h (DEF_VEC_P (char_ptr)): Remove.
3464
3465 2018-03-30  Simon Marchi  <simon.marchi@polymtl.ca>
3466
3467         * tracepoint.h (struct uploaded_tp): Initialize fields.
3468         <actions, step_actions, cmd_strings>: Change type to
3469         std::vector<char *>.
3470         * tracepoint.c (get_uploaded_tp): Allocate with new.
3471         (free_uploaded_tps): Free with delete.
3472         (parse_tracepoint_definition): Adjust to std::vector change.
3473         * breakpoint.c (read_uploaded_action): Likewise.
3474         (create_tracepoint_from_upload): Likewise.
3475         * ctf.c (ctf_write_uploaded_tp): Likewise.
3476         (SET_ARRAY_FIELD): Likewise.
3477         * tracefile-tfile.c (tfile_write_uploaded_tp): Likewise.
3478
3479 2018-03-30  Tom Tromey  <tom@tromey.com>
3480
3481         * solib-svr4.c (lm_info_read): Use gdb::byte_vector.  Return
3482         std::unique_ptr.
3483         (svr4_keep_data_in_core): Update.
3484         (svr4_read_so_list): Update.
3485
3486 2018-03-30  Tom Tromey  <tom@tromey.com>
3487
3488         * windows-nat.c (handle_output_debug_string, handle_exception):
3489         Update.
3490         * target.h (target_read_string): Update.
3491         * target.c (target_read_string): Change "string" to
3492         unique_xmalloc_ptr.
3493         * solib-svr4.c (open_symbol_file_object, svr4_read_so_list):
3494         Update.
3495         * solib-frv.c (frv_current_sos): Update.
3496         * solib-dsbt.c (dsbt_current_sos): Update.
3497         * solib-darwin.c (darwin_current_sos): Update.
3498         * linux-thread-db.c (inferior_has_bug): Update.
3499         * expprint.c (print_subexp_standard) <case OP_OBJC_MSGCALL>:
3500         Update.  Remove alloca.
3501         * ada-lang.c (ada_main_name): Update.
3502
3503 2018-03-30  Tom Tromey  <tom@tromey.com>
3504
3505         * dwarf2read.c (struct free_dwo_file_cleanup_data): Remove.
3506         (struct dwo_file_deleter): New.
3507         (dwo_file_up): New typedef.
3508         (open_and_init_dwo_file): Use dwo_file_up.
3509         (free_dwo_file_cleanup): Remove.
3510
3511 2018-03-30  Tom Tromey  <tom@tromey.com>
3512
3513         * dwarf2read.c (free_dwo_file): Remove "objfile" parameter.
3514         (free_dwo_file_cleanup, free_dwo_file_from_slot): Update.
3515
3516 2018-03-30  Tom Tromey  <tom@tromey.com>
3517
3518         * dwarf2read.c (class free_cached_comp_units): New class.
3519         (dw2_instantiate_symtab, dwarf2_build_psymtabs_hard): Use it.
3520         (free_cached_comp_units): Remove function.
3521
3522 2018-03-30  Tom Tromey  <tom@tromey.com>
3523
3524         * utils.h (make_cleanup_unpush_target): Remove.
3525         * inf-ptrace.c (struct target_unpusher): New.
3526         (target_unpush_up) New typedef.
3527         (inf_ptrace_create_inferior, inf_ptrace_attach): Use
3528         target_unpush_up.
3529         * utils.c (do_unpush_target, make_cleanup_unpush_target): Remove.
3530
3531 2018-03-27  Tom Tromey  <tom@tromey.com>
3532
3533         * utils.c (prompt_for_continue): Use unique_xmalloc_ptr.
3534
3535 2018-03-27  Pedro Alves  <palves@redhat.com>
3536             Tom Tromey  <tom@tromey.com>
3537
3538         * top.c (class gdb_readline_wrapper_cleanup): Add constructor,
3539         destructor.  Now a class.
3540         (gdb_readline_wrapper_cleanup): Remove function.
3541         (gdb_readline_wrapper): Remove cleanups.
3542
3543 2018-03-27  Tom Tromey  <tom@tromey.com>
3544
3545         * typeprint.h (struct type_print_options) <local_typedefs,
3546         global_typedefs>: Remove "struct" keyword.
3547         (class typedef_hash_table): New class.
3548         (recursively_update_typedef_hash, add_template_parameters)
3549         (create_typedef_hash, free_typedef_hash, copy_typedef_hash)
3550         (find_typedef_in_hash): Don't declare.
3551         * typeprint.c (struct typedef_hash_table): Move to typeprint.h.
3552         (typedef_hash_table::recursively_update): Rename from
3553         recursively_update_typedef_hash.  Now a member.
3554         (typedef_hash_table::add_template_parameters): Rename from
3555         add_template_parameters.  Now a member.
3556         (typedef_hash_table::typedef_hash_table): Now a constructor;
3557         rename from create_typedef_hash.
3558         (typedef_hash_table::~typedef_hash_table): Now a destructor;
3559         rename from free_typedef_hash.
3560         (do_free_typedef_hash, make_cleanup_free_typedef_hash)
3561         (do_free_global_table): Remove.
3562         (typedef_hash_table::typedef_hash_table): New constructor; renamed
3563         from copy_type_recursive.
3564         (create_global_typedef_table): Remove.
3565         (typedef_hash_table::find_global_typedef): Now a member of
3566         typedef_hash_table.
3567         (typedef_hash_table::find_typedef): Rename from
3568         find_typedef_in_hash; now a member.
3569         (whatis_exp): Update.
3570         * extension.h (struct ext_lang_type_printers): Add constructor and
3571         destructor.
3572         (start_ext_lang_type_printers, free_ext_lang_type_printers): Don't
3573         declare.
3574         * extension.c (ext_lang_type_printers::ext_lang_type_printers):
3575         Now a constructor; rename from start_ext_lang_type_printers.
3576         (ext_lang_type_printers): Now a destructor; rename from
3577         free_ext_lang_type_printers.
3578         * c-typeprint.c (find_typedef_for_canonicalize, c_print_type_1):
3579         Update.
3580         (c_type_print_base_struct_union): Update.  Remove cleanups.
3581
3582 2018-03-27  Tom Tromey  <tom@tromey.com>
3583
3584         * dwarf-index-write.c: Include <cmath>.
3585
3586 2018-03-27  Joel Brobecker  <brobecker@adacore.com>
3587
3588         * NEWS: Add entry describing new "set|show varsize-limit" command.
3589         * ada-lang.c (_initialize_ada_language): Add "set/show varsize-limit"
3590         command.
3591         * printcmd.c (_initialize_printcmd): Add "set var" alias of
3592         "set variable".
3593
3594 2018-03-27  Simon Marchi  <simon.marchi@ericsson.com>
3595
3596         * Makefile.in (COMMON_SFILES): Add dwarf-index-common.c and
3597         dwarf-index-write.c
3598         (HFILES_NO_SRCDIR): Add dwarf-index-common.h and dwarf2read.h.
3599         * dwarf-index-common.c: New file.
3600         * dwarf-index-common.h: New file.
3601         * dwarf-index-write.c: New file.
3602         * dwarf2read.c: Include dwarf2read.h and dwarf-index-common.h.
3603         (struct dwarf2_section_info): Move from here.
3604         (dwarf2_section_info_def): Likewise.
3605         (DEF_VEC_O (dwarf2_section_info_def)): Likewise.
3606         (offset_type): Likewise.
3607         (DW2_GDB_INDEX_SYMBOL_STATIC_SET_VALUE): Likewise.
3608         (DW2_GDB_INDEX_SYMBOL_KIND_SET_VALUE): Likewise.
3609         (DW2_GDB_INDEX_CU_SET_VALUE): Likewise.
3610         (byte_swap): Likewise.
3611         (MAYBE_SWAP): Likewise.
3612         (dwarf2_per_cu_ptr): Likewise.
3613         (DEF_VEC_P (dwarf2_per_cu_ptr)): Likewise.
3614         (struct tu_stats): Likewise.
3615         (struct dwarf2_per_objfile): Likewise.
3616         (struct dwarf2_per_cu_data): Likewise.
3617         (struct signatured_type): Likewise.
3618         (sig_type_ptr): Likewise.
3619         (DEF_VEC_P (sig_type_ptr)): Likewise.
3620         (INDEX4_SUFFIX): Likewise.
3621         (INDEX5_SUFFIX): Likewise.
3622         (DEBUG_STR_SUFFIX): Likewise.
3623         (dwarf2_read_section): Make non-static.
3624         (mapped_index_string_hash): Move from here.
3625         (dwarf5_djb_hash): Likewise.
3626         (file_write): Likewise.
3627         (class data_buf): Likewise.
3628         (struct symtab_index_entry): Likewise.
3629         (struct mapped_symtab): Likewise.
3630         (find_slot): Likewise.
3631         (hash_expand): Likewise.
3632         (add_index_entry): Likewise.
3633         (uniquify_cu_indices): Likewise.
3634         (class c_str_view): Likewise.
3635         (class c_str_view_hasher): Likewise.
3636         (class vector_hasher): Likewise.
3637         (write_hash_table): Likewise.
3638         (psym_index_map): Likewise.
3639         (struct addrmap_index_data): Likewise.
3640         (add_address_entry): Likewise.
3641         (add_address_entry_worker): Likewise.
3642         (write_address_map): Likewise.
3643         (symbol_kind): Likewise.
3644         (write_psymbols): Likewise.
3645         (struct signatured_type_index_data): Likewise.
3646         (write_one_signatured_type): Likewise.
3647         (recursively_count_psymbols): Likewise.
3648         (recursively_write_psymbols): Likewise.
3649         (class debug_names): Likewise.
3650         (check_dwarf64_offsets): Likewise.
3651         (psyms_seen_size): Likewise.
3652         (write_gdbindex): Likewise.
3653         (write_debug_names): Likewise.
3654         (assert_file_size): Likewise.
3655         (write_psymtabs_to_index): Likewise.
3656         (save_gdb_index_command): Likewise.
3657         (_initialize_dwarf2_read): Don't register the "save gdb-index"
3658         command.
3659         * dwarf2read.h: New file.
3660
3661 2018-03-27  Joel Brobecker  <brobecker@adacore.com>
3662
3663         PR gdb/22670
3664         * dwarf2read.c (dwarf2_physname): Do not return the demangled
3665         symbol name if the CU's language stores symbol names in linkage
3666         format.
3667         * language.h (struct language_defn)
3668         <la_store_sym_names_in_linkage_form_p>: New field.  Adjust
3669         all instances of this struct.
3670
3671 2018-03-26  Tom Tromey  <tom@tromey.com>
3672
3673         * stack.c (backtrace_command_1): Remove verbose code.
3674
3675 2018-03-26  Tom Tromey  <tom@tromey.com>
3676
3677         * python/py-framefilter.c (py_print_type): Don't catch
3678         exceptions.  Return void.
3679         (py_print_value): Likewise.
3680         (py_print_single_arg): Likewise.
3681         (enumerate_args): Don't catch exceptions.
3682         (py_print_args): Likewise.
3683         (py_print_frame): Likewise.
3684         (gdbpy_apply_frame_filter): Catch exceptions here.
3685
3686 2018-03-26  Tom Tromey  <tom@tromey.com>
3687
3688         * stack.c (_initialize_stack): Remove trailing newlines from help
3689         text.  Add "Usage" line to "backtrace" help.
3690
3691 2018-03-26  Tom Tromey  <tom@tromey.com>
3692
3693         PR python/16486:
3694         * python/py-framefilter.c (py_print_args): Call wrap_hint.
3695
3696 2018-03-26  Tom Tromey  <tom@tromey.com>
3697
3698         * python/py-framefilter.c (py_print_single_arg): Return
3699         EXT_LANG_BT_ERROR from catch.
3700
3701 2018-03-26  Tom Tromey  <tom@tromey.com>
3702
3703         PR backtrace/15584:
3704         * stack.c (backtrace_command_1): Move some code into no-filters
3705         "if".
3706
3707 2018-03-26  Tom Tromey  <tom@tromey.com>
3708
3709         * python/py-framefilter.c (throw_quit_or_print_exception): New
3710         function.
3711         (gdbpy_apply_frame_filter): Use it.
3712
3713 2018-03-26  Tom Tromey  <tom@tromey.com>
3714
3715         PR cli/17716:
3716         * python/py-framefilter.c (py_print_type, py_print_value)
3717         (enumerate_args, py_print_args, gdbpy_apply_frame_filter): Use
3718         RETURN_MASK_ERROR.
3719
3720 2018-03-26  Tom Tromey  <tom@tromey.com>
3721
3722         * python/py-framefilter.c (enumerate_args): Use
3723         gdb::unique_xmalloc_ptr.
3724
3725 2018-03-26  Tom Tromey  <tom@tromey.com>
3726
3727         * python/py-framefilter.c (py_print_frame): Return
3728         EXT_LANG_BT_OK.
3729         (gdbpy_apply_frame_filter): Update comment.
3730         * extension.h (enum ext_lang_bt_status) <EXT_LANG_BT_COMPLETED>:
3731         Remove.
3732         <EXT_LANG_BT_NO_FILTERS>: Change value.
3733
3734 2018-03-26  Tom Tromey  <tom@tromey.com>
3735
3736         PR backtrace/15582:
3737         * stack.c (backtrace_command): Parse "hide" argument.
3738         * python/py-framefilter.c (py_print_frame): Handle PRINT_HIDE.
3739         * extension.h (enum frame_filter_flags) <PRINT_HIDE>: New
3740         constant.
3741
3742 2018-03-26  Tom Tromey  <tom@tromey.com>
3743
3744         * stack.c (backtrace_command_1): Remove "show_locals" parameter,
3745         add "flags".
3746         (backtrace_command): Remove "fulltrace", add "flags".
3747
3748 2018-03-26  Tom Tromey  <tom@tromey.com>
3749
3750         * stack.c (backtrace_command): Rewrite command line parsing.
3751
3752 2018-03-26  Simon Marchi  <simon.marchi@ericsson.com>
3753
3754         * dwarf2read.c (DEF_VEC_I(offset_type)): Remove.
3755
3756 2018-03-26  Simon Marchi  <simon.marchi@ericsson.com>
3757
3758         * filename-seen-cache.h: Add include guard.
3759
3760 2018-03-26  Keith Seitz  <keiths@redhat.com>
3761
3762         * symfile.c (place_section): Remove "struct" from section_addr_info
3763         in comment.
3764         * windows-nat.c (struct safe_symbol_file_add_args) <addrs>: Remove
3765         "struct" keyword from section_addr_info.
3766
3767 2018-03-26  Alan Hayward  <alan.hayward@arm.com>
3768
3769         * regformats/regdef.h (reg): Add constructors.
3770
3771 2018-03-25  Pedro Alves  <palves@redhat.com>
3772
3773         * eval.c (evaluate_funcall): Swap OP_VAR_MSYM_VALUE/OP_VAR_VALUE
3774         if then/else bodies in var_func_name extraction.
3775
3776 2018-03-23  Weimin Pan  <weimin.pan@oracle.com>
3777
3778         * minsyms.c (lookup_minimal_symbol_and_objfile): Use
3779         lookup_minimal_symbol() to find symbol entry.
3780         * minsyms.h (lookup_minimal_symbol_and_objfile): Update comment.
3781
3782 2018-03-23  Keith Seitz  <keiths@redhat.com>
3783
3784         PR c++/22968
3785         * dwarf2read.c (scan_partial_symbols): Scan structs/classes for
3786         nested type definitions for C++, too.
3787
3788 2018-03-23  Tom Tromey  <tom@tromey.com>
3789
3790         * machoread.c (struct oso_el): Add a constructor.  Don't define as
3791         a typedef.
3792         (macho_register_oso): Remove.
3793         (macho_symtab_read): Take a std::vector.
3794         (oso_el_compare_name): Now a std::sort comparator.
3795         (macho_symfile_read_all_oso): Take a std::vector.
3796         (macho_symfile_read): Use std::vector.  Remove cleanups.
3797
3798 2018-03-22  Tom Tromey  <tom@tromey.com>
3799
3800         * record-full.c (record_full_exec_insn): Use gdb::byte_vector.
3801         (record_full_goto_bookmark): Use std::string.
3802
3803 2018-03-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
3804
3805         PR tdep/18295
3806         * rs6000-tdep.c (skip_prologue): Match both stwux and stdux
3807         a single mask.
3808
3809 2018-03-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
3810
3811         * rs6000-tdep.c (store_insn_p): New function.
3812         (skip_prologue): New variable alloca_reg_offset. Set lr_reg
3813         and cr_reg to their unshifted values. Use store_insn_p to
3814         match LR saves using either R1 or fdata->alloca_reg. Use
3815         store_insn_p to match CR saves. Set alloca_reg_offset
3816         when alloca_reg and framep are set. Remove lr_reg shift
3817         when assigning to fdata->lr_register.
3818
3819 2018-03-22  Andreas Arnez  <arnez@linux.vnet.ibm.com>
3820
3821         * linux-tdep.c (linux_info_proc): For "info proc cmdline", print
3822         command line args instead of emitting a warning.
3823
3824 2018-03-22  Simon Marchi  <simon.marchi@polymtl.ca>
3825
3826         * tracepoint.h (struct static_tracepoint_marker): Initialize
3827         fields, define default constructor, move constructor and move
3828         assignment, disable the rest.
3829         <str_id, extra>: Make std::string.
3830         (release_static_tracepoint_marker): Remove.
3831         (free_current_marker): Remove.
3832         * tracepoint.c (free_current_marker): Remove.
3833         (parse_static_tracepoint_marker_definition): Adjust to
3834         std::string, use new hex2str overload.
3835         (release_static_tracepoint_marker): Remove.
3836         (print_one_static_tracepoint_marker): Get marker by reference
3837         and adjust to std::string.
3838         (info_static_tracepoint_markers_command): Adjust to std::vector
3839         changes
3840         * target.h (static_tracepoint_marker_p): Remove typedef.
3841         (DEF_VEC_P(static_tracepoint_marker_p)): Remove.
3842         (struct target_ops) <to_static_tracepoint_marker_at>: Return
3843         bool.
3844         <to_static_tracepoint_markers_by_strid>: Return std::vector.
3845         * target-debug.h
3846         (target_debug_print_VEC_static_tracepoint_marker_p_p): Remove.
3847         (target_debug_print_std_vector_static_tracepoint_marker): New.
3848         (target_debug_print_struct_static_tracepoint_marker_p): Rename
3849         to...
3850         (target_debug_print_static_tracepoint_marker_p): ... this.
3851         * target-delegates.c: Re-generate.
3852         * breakpoint.h (struct tracepoint) <static_trace_marker_id>:
3853         Make std::string.
3854         * breakpoint.c (init_breakpoint_sal): Adjust to std::string.
3855         (decode_static_tracepoint_spec): Adjust to std::vector.
3856         (tracepoint_print_one_detail): Adjust to std::string.
3857         (strace_marker_decode_location): Adjust to std::string.
3858         (update_static_tracepoint): Adjust to std::string, remove call
3859         to release_static_tracepoint_marker.
3860         * linux-nat.c (linux_child_static_tracepoint_markers_by_strid):
3861         Adjust to std::vector.
3862         * remote.c (remote_static_tracepoint_marker_at): Return bool.
3863         (remote_static_tracepoint_markers_by_strid): Adjust to
3864         std::vector.
3865         * common/rsp-low.h (hex2str): New overload with explicit count
3866         of bytes.
3867         * common/rsp-low.c (hex2str): New overload with explicit count
3868         of bytes.
3869         * unittests/rsp-low-selftests.c (test_hex2str): New function.
3870         (_initialize_rsp_low_selftests): Add test_hex2str test.
3871         * unittests/tracepoint-selftests.c
3872         (test_parse_static_tracepoint_marker_definition): Adjust to
3873         std::string.
3874
3875 2018-03-22  Simon Marchi  <simon.marchi@polymtl.ca>
3876
3877         * tracepoint.c (parse_static_tracepoint_marker_definition):
3878         Consider case where the definition is followed by more
3879         definitions.
3880         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
3881         tracepoint-selftests.c.
3882         * unittests/tracepoint-selftests.c: New.
3883
3884 2018-03-21  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
3885
3886         * MAINTAINERS (Write After Approval): Add Pedro Franco de
3887         Carvalho.
3888
3889 2018-03-20  Stephen Roberts  <stephen.roberts@arm.com>
3890
3891         * symtab.c (find_pc_sect_line): fixed indentation.
3892
3893 2018-03-20  Stephen Roberts  <stephen.roberts@arm.com>
3894
3895         * symtab.c (find_pc_sect_line): now uses binary search.
3896
3897 2018-03-19  Tom Tromey  <tom@tromey.com>
3898
3899         * rust-exp.y (struct_expr_tail, struct_expr_list): Add plain
3900         "IDENT" production.
3901
3902 2018-03-19  Pedro Alves  <palves@redhat.com>
3903             Tom Tromey  <tom@tromey.com>
3904
3905         * unittests/observable-selftests.c: New file.
3906         * common/observable.h: New file.
3907         * observable.h: New file.
3908         * ada-lang.c, ada-tasks.c, agent.c, aix-thread.c, annotate.c,
3909         arm-tdep.c, auto-load.c, auxv.c, break-catch-syscall.c,
3910         breakpoint.c, bsd-uthread.c, cli/cli-interp.c, cli/cli-setshow.c,
3911         corefile.c, dummy-frame.c, event-loop.c, event-top.c, exec.c,
3912         extension.c, frame.c, gdbarch.c, guile/scm-breakpoint.c,
3913         infcall.c, infcmd.c, inferior.c, inflow.c, infrun.c, jit.c,
3914         linux-tdep.c, linux-thread-db.c, m68klinux-tdep.c,
3915         mi/mi-cmd-break.c, mi/mi-interp.c, mi/mi-main.c, objfiles.c,
3916         ppc-linux-nat.c, ppc-linux-tdep.c, printcmd.c, procfs.c,
3917         python/py-breakpoint.c, python/py-finishbreakpoint.c,
3918         python/py-inferior.c, python/py-unwind.c, ravenscar-thread.c,
3919         record-btrace.c, record-full.c, record.c, regcache.c, remote.c,
3920         riscv-tdep.c, sol-thread.c, solib-aix.c, solib-spu.c, solib.c,
3921         spu-multiarch.c, spu-tdep.c, stack.c, symfile-mem.c, symfile.c,
3922         symtab.c, thread.c, top.c, tracepoint.c, tui/tui-hooks.c,
3923         tui/tui-interp.c, valops.c: Update all users.
3924         * tui/tui-hooks.c (tui_bp_created_observer)
3925         (tui_bp_deleted_observer, tui_bp_modified_observer)
3926         (tui_inferior_exit_observer, tui_before_prompt_observer)
3927         (tui_normal_stop_observer, tui_register_changed_observer):
3928         Remove.
3929         (tui_observers_token): New global.
3930         (attach_or_detach, tui_attach_detach_observers): New functions.
3931         (tui_install_hooks, tui_remove_hooks): Use
3932         tui_attach_detach_observers.
3933         * record-btrace.c (record_btrace_thread_observer): Remove.
3934         (record_btrace_thread_observer_token): New global.
3935         * observer.sh: Remove.
3936         * observer.c: Rename to observable.c.
3937         * observable.c (namespace gdb_observers): Define new objects.
3938         (observer_debug): Move into gdb_observers namespace.
3939         (struct observer, struct observer_list, xalloc_observer_list_node)
3940         (xfree_observer_list_node, generic_observer_attach)
3941         (generic_observer_detach, generic_observer_notify): Remove.
3942         (_initialize_observer): Update.
3943         Don't include observer.inc.
3944         * Makefile.in (generated_files): Remove observer.h, observer.inc.
3945         (clean mostlyclean): Likewise.
3946         (observer.h, observer.inc): Remove targets.
3947         (SUBDIR_UNITTESTS_SRCS): Add observable-selftests.c.
3948         (COMMON_SFILES): Use observable.c, not observer.c.
3949         * .gitignore: Remove observer.h.
3950
3951 2018-03-18  Tom Tromey  <tom@tromey.com>
3952
3953         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Use
3954         gdb::def_vector.
3955         (bfd_lookup_symbol_from_dyn_symtab): Likewise.
3956
3957 2018-03-17  Tom Tromey  <tom@tromey.com>
3958
3959         * auto-load.c (auto_load_objfile_script_1): Use std::string.
3960
3961 2018-03-17  Tom Tromey  <tom@tromey.com>
3962
3963         * target.c (class scoped_target_fd): New.
3964         (target_fileio_close_cleanup): Remove.
3965         (target_fileio_read_alloc_1): Use scoped_target_fd.
3966
3967 2018-03-16  Simon Marchi  <simon.marchi@polymtl.ca>
3968
3969         * silent-rules.mk: New.
3970         * Makefile.in: Include silent-rules.mk
3971         (srcdir, VPATH, top_srcdir): Move up.
3972         (COMPILE): Add ECHO_CXX.
3973         (test-cp-name-parser$(EXEEXT)): Add ECHO_CXXLD.
3974         (init.c): Add ECHO_INIT_C.
3975         (gdb$(EXEEXT)): Add SILENCE and ECHO_CXXLD.
3976         (version.c): Add ECHO_GEN.
3977         (printcmd.o): Add ECHO_CXX.
3978         (target-float.o): Add ECHO_CXX.
3979         (ada-exp.o): Add ECHO_CXX.
3980         (stamp-xml): Add SILENCE and ECHO_GEN_XML_BUILTIN.
3981         (insight$(EXEEXT)): Add ECHO_CXXLD.
3982         * gnulib/configure.ac: Add AM_SILENT_RULES.
3983         * gnulib/aclocal.m4: Re-generate.
3984         * gnulib/configure: Re-generate.
3985         * gnulib/import/Makefile.in: Re-generate.
3986
3987 2018-03-16  Tom Tromey  <tom@tromey.com>
3988
3989         * xcoffread.c (xcoff_symfile_offsets): Change type of "addrs".
3990         * utils.h (make_cleanup_free_section_addr_info): Don't declare.
3991         * utils.c (do_free_section_addr_info)
3992         (make_cleanup_free_section_addr_info): Remove.
3993         * symfile.h (struct other_sections): Add constructor.
3994         (struct section_addr_info): Remove.
3995         (section_addr_info): New typedef.
3996         (struct sym_fns) <sym_offsets>: Change type of parameter.
3997         (build_section_addr_info_from_objfile)
3998         (relative_addr_info_to_section_offsets, addr_info_make_relative)
3999         (default_symfile_offsets, symbol_file_add)
4000         (symbol_file_add_from_bfd)
4001         (build_section_addr_info_from_section_table): Update.
4002         (alloc_section_addr_info, free_section_addr_info): Don't declare.
4003         * symfile.c (alloc_section_addr_info): Remove.
4004         (build_section_addr_info_from_section_table): Change return type.
4005         Update.
4006         (build_section_addr_info_from_bfd)
4007         (build_section_addr_info_from_objfile): Likewise.
4008         (free_section_addr_info): Remove.
4009         (relative_addr_info_to_section_offsets): Change type of "addrs".
4010         (addrs_section_compar): Now a std::sort comparator.
4011         (addrs_section_sort): Change return type.
4012         (addr_info_make_relative): Change type of "addrs".  Update.
4013         (default_symfile_offsets, syms_from_objfile_1)
4014         (syms_from_objfile, symbol_file_add_with_addrs): Likewise.
4015         (symbol_file_add_separate): Update.
4016         (symbol_file_add): Change type of "addrs".  Update.
4017         (add_symbol_file_command): Update.  Remove cleanups.
4018         * symfile-mem.c (symbol_file_add_from_memory): Update.  Remove
4019         cleanups.
4020         * symfile-debug.c (debug_sym_offsets): Change type of "info".
4021         * solib.c (solib_read_symbols): Update.
4022         * objfiles.c (objfile_relocate): Update.  Remove cleanups.
4023         * machoread.c (macho_symfile_offsets): Update.
4024         * jit.c (jit_bfd_try_read_symtab): Update.
4025
4026 2018-03-15  Simon Marchi  <simon.marchi@polymtl.ca>
4027
4028         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4029         unittests/utils-selftests.c.
4030         * unittests/utils-selftests.c: New file.
4031
4032 2018-03-14  Tom Tromey  <tom@tromey.com>
4033
4034         PR cli/14977:
4035         * printcmd.c (printf_c_string, printf_wide_c_string): Special case
4036         for NULL.
4037
4038 2018-03-14  Tom Tromey  <tom@tromey.com>
4039
4040         PR cli/19918:
4041         * printcmd.c (printf_pointer): Allow "-" in format.
4042
4043 2018-03-14  Tom Tromey  <tom@tromey.com>
4044
4045         * printcmd.c (_initialize_printcmd): Add usage to printf.
4046
4047 2018-03-14  Yao Qi  <qiyao@sourceware.org>
4048
4049         * MAINTAINERS: Update my email address.
4050
4051 2018-03-13  Tom Tromey  <tom@tromey.com>
4052
4053         * machoread.c (macho_check_dsym): Change filenamep to a
4054         std::string*.
4055         (macho_symfile_read): Update.
4056         * symfile.c (load_command): Use std::string.
4057
4058 2018-03-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4059
4060         * riscv-tdep.c (riscv_sw_breakpoint_from_kind): Add localization
4061         to error message string.
4062         (riscv_register_name): Use xsnprintf instead of sprintf.
4063         (riscv_insn::fetch_instruction): Use gdb_assert instead of
4064         internal_error.
4065         (riscv_print_arg_location): Use gdb_assert_not_reached instead of
4066         error.
4067         (riscv_push_dummy_call): Likewise.
4068
4069 2018-03-12  Tom Tromey  <tom@tromey.com>
4070
4071         * rs6000-aix-tdep.c (rs6000_aix_core_xfer_shared_libraries_aix):
4072         Use gdb::byte_vector.
4073         * arm-tdep.c (arm_exidx_new_objfile): Use gdb::byte_vector.
4074
4075 2018-03-12  Yao Qi  <yao.qi@linaro.org>
4076
4077         * ia64-libunwind-tdep.c (libunwind_get_reg_special): Change
4078         parameter type to readable_regcache.
4079         * ia64-libunwind-tdep.h (libunwind_get_reg_special): Update
4080         the declaration.
4081
4082 2018-03-11  Tom Tromey  <tom@tromey.com>
4083
4084         * dwarf2read.c (struct nextfield): Add initializers.
4085         (struct nextfnfield): Remove.
4086         (struct fnfieldlist): Add initializers.  Remove "length" and
4087         "head", use std::vector.
4088         (struct decl_field_list): Remove.
4089         (struct field_info): Add initializers.
4090         <fields, baseclasses>: Now std::vector.
4091         <nbaseclasses, nfnfields, typedef_field_list_count,
4092         nested_types_list_count>: Remove.
4093         (dwarf2_add_field, dwarf2_add_type_defn)
4094         (dwarf2_attach_fields_to_type, dwarf2_add_member_fn)
4095         (dwarf2_attach_fn_fields_to_type, handle_struct_member_die)
4096         (process_structure_scope): Update.
4097
4098 2018-03-11  Tom Tromey  <tom@tromey.com>
4099
4100         * dwarf2read.c (sort_tu_by_abbrev_offset): Change to be suitable
4101         for use by std::sort.
4102         (build_type_psymtabs_1): Use std::vector.
4103
4104 2018-03-09  Eli Zaretskii  <eliz@gnu.org>
4105
4106         * top.c (print_gdb_configuration): Reflect LIBIPT, LIBMEMCHECK,
4107         and LIBMPFR in the printed configuration.
4108
4109 2018-03-08  Tom Tromey  <tom@tromey.com>
4110
4111         * source.c (get_filename_and_charpos): Use scoped_fd.
4112         * nto-procfs.c (procfs_open_1): Use scoped_fd.
4113         (procfs_pidlist): Likewise.
4114         * procfs.c (proc_get_LDT_entry): Use scoped_fd.
4115         (iterate_over_mappings): Likewise.
4116
4117 2018-03-08  Tom Tromey  <tom@tromey.com>
4118
4119         * infcall.c (struct call_return_meta_info)
4120         <stack_temporaries_enabled>: Remove.
4121         (get_call_return_value, call_function_by_hand_dummy): Update.
4122         * thread.c (disable_thread_stack_temporaries): Remove.
4123         (enable_thread_stack_temporaries): Remove.
4124         (thread_stack_temporaries_enabled_p): Return bool.
4125         (push_thread_stack_temporary, value_in_thread_stack_temporaries)
4126         (get_last_thread_stack_temporary): Update.
4127         * eval.c (evaluate_subexp): Update.
4128         * gdbthread.h (class enable_thread_stack_temporaries): Now a
4129         class, not a function.
4130         (value_ptr, value_vec): Remove typedefs.
4131         (class thread_info) <stack_temporaries_enabled>: Now bool.
4132         <stack_temporaries>: Now a std::vector.
4133         (thread_stack_temporaries_enabled_p)
4134         (value_in_thread_stack_temporaries): Return bool.
4135
4136 2018-03-08  Simon Marchi  <simon.marchi@ericsson.com>
4137
4138         * remote.c (putpkt_binary): Fix omitted bytes reporting.
4139         (getpkt_or_notif_sane_1): Likewise.
4140
4141 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
4142
4143         * build-id.c (build_id_to_debug_bfd): Use std::string.
4144
4145 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
4146
4147         * build-id.c (find_separate_debug_file_by_buildid): Return
4148         std::string.
4149         * build-id.h (find_separate_debug_file_by_buildid): Return
4150         std::string.
4151         * coffread.c (coff_symfile_read): Adjust to std::string.
4152         * elfread.c (elf_symfile_read): Adjust to std::string.
4153         * symfile.c (separate_debug_file_exists): Change parameter to
4154         std::string.
4155         (find_separate_debug_file): Return std::string.
4156         (find_separate_debug_file_by_debuglink): Return std::string.
4157         * symfile.h (find_separate_debug_file_by_debuglink): Return
4158         std::string.
4159
4160 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
4161
4162         * common/xml-utils.c (xml_escape_text): Move code to...
4163         (xml_escape_text_append): ... this new function.
4164         * common/xml-utils.h (xml_escape_text_append): New declaration.
4165         * unittests/xml-utils-selftests.c (test_xml_escape_text_append):
4166         New function.
4167         (_initialize_xml_utils): register test_xml_escape_text_append as
4168         a selftest.
4169
4170 2018-03-07  Alan Hayward  <alan.hayward@arm.com>
4171
4172         * defs.h: Remove MAX_REGISTER_SIZE.
4173         * regcache.c (init_regcache_descr): Remove MAX_REGISTER_SIZE
4174         asserts.
4175         * python/py-unwind.c (pyuw_sniffer): Likewise.
4176
4177 2018-03-07  Tom Tromey  <tom@tromey.com>
4178
4179         * linux-tdep.c (linux_info_proc): Update.
4180         * target.h (struct target_ops) <to_fileio_readlink>: Return
4181         optional<string>.
4182         (target_fileio_readlink): Return optional<string>.
4183         * remote.c (remote_hostio_readlink): Return optional<string>.
4184         * inf-child.c (inf_child_fileio_readlink): Return
4185         optional<string>.
4186         * target.c (target_fileio_readlink): Return optional<string>.
4187
4188 2018-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
4189
4190         * regcache.c (cooked_read_test): Add riscv to the list of
4191         architectures that have a save_reggroup.
4192
4193 2018-03-07  Andreas Arnez  <arnez@linux.vnet.ibm.com>
4194
4195         * gnu-v3-abi.c (gnuv3_rtti_type): Add early exit if the given
4196         value is not a dynamic class object.
4197
4198 2018-03-06  Tom Tromey  <tom@tromey.com>
4199
4200         * rust-exp.y: Formatting fixes.
4201
4202 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4203
4204         * riscv-tdep.c (riscv_register_name): Remove target description
4205         support.
4206         (riscv_gdbarch_init): Remove target description check.
4207
4208 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4209
4210         * riscv-tdep.c: Remove 'Contributed by ...' lines from header
4211         comment.
4212         * riscv-tdep.h: Likewise.
4213
4214 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4215
4216         * riscv-tdep.c (riscv_pseudo_register_read): Delete.
4217         (riscv_pseudo_register_write): Delete.
4218         (riscv_gdbarch_init): Remove all use of pseudo registers.
4219
4220 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
4221
4222         * record-btrace.c (btrace_print_lines): Replace cleanup
4223         parameter with RAII equivalents.
4224         (btrace_insn_history): Replace cleanup with RAII equivalents.
4225         * ui-out.h (make_cleanup_ui_out_list_begin_end,
4226         make_cleanup_ui_out_tuple_begin_end): Remove.
4227         * ui-out.c (struct ui_out_end_cleanup_data, do_cleanup_end,
4228         make_cleanup_ui_out_end, make_cleanup_ui_out_tuple_begin_end,
4229         make_cleanup_ui_out_list_begin_end): Remove.
4230
4231 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
4232
4233         * record-btrace.c (record_btrace_maybe_mark_async_event): Change
4234         parameter types to std::vector.  Use bool.
4235         (record_btrace_wait): Replace VEC(tp_t) with
4236         std::vector<thread_info *>.
4237         * common/gdb_vecs.h (unordered_remove, ordered_remove): New.
4238
4239 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
4240
4241         * record-btrace.c (record_btrace_disable_callback): Remove.
4242         (struct scoped_btrace_disable): New.
4243         (record_btrace_open): Use scoped_btrace_disable.
4244
4245 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4246
4247         * riscv-tdep.c (riscv_return_value): Change type to ULONGEST for
4248         reading values from registers.
4249
4250 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4251
4252         * riscv-tdep.c (riscv_push_dummy_call): Use core_addr_to_string_nz
4253         where appropriate.
4254
4255 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4256
4257         * riscv-tdep.c (riscv_print_arg_location): Add header comment,
4258         change parameter type.  Use GDB's print functions, and use
4259         core_addr_to_string where appropriate.
4260         (riscv_push_dummy_call): Use core_addr_to_string where
4261         appropriate, update call to riscv_print_arg_location, and reindent
4262         a few lines.
4263         (riscv_return_value): Update call to riscv_print_arg_location.
4264
4265 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4266             Tim Newsome <tim@sifive.com>
4267             Albert Ou <a0u@eecs.berkeley.edu>
4268             Darius Rad <darius@bluespec.com>
4269
4270         * Makefile.in (ALL_TARGET_OBS): Add riscv-tdep.o
4271         (HFILES_NO_SRCDIR): Add riscv-tdep.h.
4272         (ALLDEPFILES): Add riscv-tdep.c
4273         * configure.tgt: Add riscv support.
4274         * riscv-tdep.c: New file.
4275         * riscv-tdep.h: New file.
4276         * NEWS: Mention new target.
4277         * MAINTAINERS: Add entry for riscv.
4278
4279 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4280
4281         * amd64-tdep.c (amd64_classify_aggregate): Ignore zero sized
4282         fields within aggregates.
4283
4284 2018-03-04  Simon Marchi  <simon.marchi@polymtl.ca>
4285
4286         * record-btrace.c (btrace_print_lines): Change type of flags to
4287         gdb_disassembly_flags.
4288
4289 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
4290
4291         * fbsd-nat.c: Include "inf-ptrace.h".
4292         (USE_SIGTRAP_SIGINFO): Conditionally define.
4293         [USE_SIGTRAP_SIGINFO] (fbsd_handle_debug_trap): New function.
4294         (fbsd_wait) [USE_SIGTRAP_SIGINFO]: Call "fbsd_handle_debug_trap".
4295         [USE_SIGTRAP_SIGINFO] (fbsd_stopped_by_sw_breakpoint): New
4296         function.
4297         [USE_SIGTRAP_SIGINFO] (fbsd_supports_stopped_by_sw_breakpoint):
4298         Likewise.
4299         [USE_SIGTRAP_SIGINFO] (fbsd_supports_stopped_by_hw_breakpoint):
4300         Likewise.
4301         (fbsd_nat_add_target) [USE_SIGTRAP_SIGINFO]: Set
4302         "stopped_by_sw_breakpoint", "supports_stopped_by_sw_breakpoint",
4303         "supports_stopped_by_hw_breakpoint" target methods.
4304
4305 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
4306
4307         * NEWS (Changes since GDB 8.1): Add "set/show debug fbsd-nat".
4308         * fbsd-nat.c (debug_fbsd_nat): New variable.
4309         (show_fbsd_nat_debug): New function.
4310         (fbsd_wait): Log LWP info if "debug_fbsd_nat" is enabled.
4311         (_initialize_fbsd_nat): Add "fbsd-nat" debug boolean command.
4312
4313 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
4314
4315         * nat/x86-dregs.c (x86_dr_stopped_by_hw_breakpoint): New function.
4316         * nat/x86-dregs.h (x86_dr_stopped_by_hw_breakpoint): New
4317         prototype.
4318         * x86-nat.c (x86_stopped_by_hw_breakpoint): New function.
4319         (x86_use_watchpoints): Set "stopped_by_hw_breakpoint" target
4320         method.
4321
4322 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
4323
4324         * common/gdb_vecs.c (free_char_ptr_vec): Remove.
4325         * common/gdb_vecs.h (free_char_ptr_vec): Remove.
4326
4327 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
4328
4329         * charset.c (struct charset_vector): New.
4330         (charsets): Change type to charset_vector.
4331         (find_charset_names): Adjust.
4332         (add_one): Adjust.
4333         (_initialize_charset): Adjust.
4334
4335 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
4336
4337         * progspace.h (struct program_space) <deleted_solibs>: Change
4338         type to std::vector<std::string>.
4339         * progspace.c (clear_program_space_solib_cache): Adjust.
4340         * breakpoint.c (print_solib_event): Adjust.
4341         (check_status_catch_solib): Adjust.
4342         * solib.c (update_solib_list): Adjust.
4343         * ui-out.h (class ui_out) <field_string>: New overload.
4344         * ui-out.c (ui_out::field_string): New overload.
4345
4346 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
4347
4348         * progspace.h (struct program_space): Add constructor and
4349         destructor, initialize fields.
4350         (add_program_space): Remove.
4351         * progspace.c (add_program_space): Rename to...
4352         (program_space::program_space): ... this.
4353         (release_program_space): Rename to...
4354         (program_space::~program_space): ... this.
4355         (delete_program_space): Use delete to delete program_space.
4356         (initialize_progspace): Use new to allocate program_space.
4357         * inferior.c (add_inferior_with_spaces): Likewise.
4358         (clone_inferior_command): Likewise.
4359         * infrun.c (follow_fork_inferior): Likewise.
4360         (handle_vfork_child_exec_or_exit): Likewise.
4361
4362 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
4363
4364         * common/gdb_vecs.h (make_cleanup_free_char_ptr_vec): Remove.
4365         (delim_string_to_char_ptr_vec): Return std::vector of
4366         gdb::unique_xmalloc_ptr.
4367         (dirnames_to_char_ptr_vec_append): Take std::vector of
4368         gdb::unique_xmalloc_ptr.
4369         (dirnames_to_char_ptr_vec): Return std::vector of
4370         gdb::unique_xmalloc_ptr.
4371         * common/gdb_vecs.c (delim_string_to_char_ptr_vec_append):
4372         Take std::vector of gdb::unique_xmalloc_ptr, adjust the code.
4373         (delim_string_to_char_ptr_vec): Return an std::vector of
4374         gdb::unique_xmalloc_ptr, adjust the code.
4375         (dirnames_to_char_ptr_vec_append): Take an std::vector of
4376         gdb::unique_xmalloc_ptr, adjust the code.
4377         (dirnames_to_char_ptr_vec): Return an std::vector of
4378         gdb::unique_xmalloc_ptr, adjust the code.
4379         * auto-load.c (auto_load_safe_path_vec): Change type to
4380         std::vector of gdb::unique_xmalloc_ptr.
4381         (auto_load_expand_dir_vars): Return an std::vector of
4382         gdb::unique_xmalloc_ptr, adjust the code.
4383         (auto_load_safe_path_vec_update): Adjust.
4384         (filename_is_in_auto_load_safe_path_vec): Adjust.
4385         (auto_load_objfile_script_1): Adjust.
4386         * build-id.c (build_id_to_debug_bfd): Adjust.
4387         * linux-thread-db.c (thread_db_load_search): Adjust.
4388         * source.c (add_path): Adjust.
4389         (openp): Adjust.
4390         * symfile.c (find_separate_debug_file): Adjust.
4391         * utils.c (do_free_char_ptr_vec): Remove.
4392         (make_cleanup_free_char_ptr_vec): Remove.
4393
4394 2018-03-01  Sergio Durigan Junior  <sergiodj@redhat.com>
4395
4396         PR gdb/22907
4397         * common/pathstuff.c: Conditionally include "<windows.h>".
4398
4399 2018-03-01  Georg Sauthoff  <mail@georg.so>
4400
4401         PR gdb/22888
4402         * gcore.in: Quote variables and switch interpreter to bash.
4403
4404 2018-03-01  Tom Tromey  <tom@tromey.com>
4405
4406         * dwarf2read.c (alloc_discriminant_info): Fix default_index
4407         assertion.  Add assertion for discriminant_index.
4408         (quirk_rust_enum): Use correct base type name in univariant case.
4409
4410 2018-03-01  Simon Marchi  <simon.marchi@ericsson.com>
4411
4412         * record.c (get_call_history_modifiers): Return a
4413         record_print_flags.
4414         (cmd_record_call_history): Adjust.
4415         * record-btrace.c (record_btrace_call_history): Adjust.
4416         (record_btrace_call_history_range): Adjust.
4417         (record_btrace_call_history_from): Adjust.
4418         * target-debug.h (target_debug_print_record_print_flags): New.
4419         * target-delegates.c: Re-generate.
4420         * target.c (target_call_history): Change flags type.
4421         (target_call_history_from): Likewise.
4422         (target_call_history_range): Likewise.
4423         * target.h (struct target_ops) <target_call_history>: Likewise.
4424         (target_call_history_from): Likewise.
4425         (target_call_history_range): Likewise.
4426
4427 2018-02-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4428             Simon Marchi  <simon.marchi@polymtl.ca>
4429
4430         * common/common-utils.c: Include "sys/stat.h".
4431         (is_regular_file): Move here from "source.c"; change return
4432         type to "bool".
4433         * common/common-utils.h (is_regular_file): New prototype.
4434         * common/pathstuff.c (contains_dir_separator): New function.
4435         * common/pathstuff.h (contains_dir_separator): New prototype.
4436         * source.c: Don't include "sys/stat.h".
4437         (is_regular_file): Move to "common/common-utils.c".
4438
4439 2018-02-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4440
4441         * Makefile.in (COMMON_SFILES): Add "common/pathstuff.c".
4442         (HFILES_NO_SRCDIR): Add "common/pathstuff.h".
4443         * auto-load.c: Include "common/pathstuff.h".
4444         * common/common-def.h (current_directory): Move here.
4445         * common/gdb_tilde_expand.c (gdb_tilde_expand_up): New
4446         function.
4447         * common/gdb_tilde_expand.h (gdb_tilde_expand_up): New
4448         prototype.
4449         * common/pathstuff.c: New file.
4450         * common/pathstuff.h: New file.
4451         * compile/compile.c: Include "common/pathstuff.h".
4452         * defs.h (current_directory): Move to "common/common-defs.h".
4453         * dwarf2read.c: Include "common/pathstuff.h".
4454         * exec.c: Likewise.
4455         * guile/scm-safe-call.c: Likewise.
4456         * linux-thread-db.c: Likewise.
4457         * main.c: Likewise.
4458         * nto-tdep.c: Likewise.
4459         * objfiles.c: Likewise.
4460         * source.c: Likewise.
4461         * symtab.c: Likewise.
4462         * utils.c: Include "common/pathstuff.h".
4463         (gdb_realpath): Move to "common/pathstuff.c".
4464         (gdb_realpath_keepfile): Likewise.
4465         (gdb_abspath): Likewise.
4466         * utils.h (gdb_realpath): Move to "common/pathstuff.h".
4467         (gdb_realpath_keepfile): Likewise.
4468         (gdb_abspath): Likewise.
4469
4470 2018-02-28  John Baldwin  <jhb@FreeBSD.org>
4471
4472         * fbsd-nat.c (fbsd_resume): Use PT_SETSTEP for stepping and a
4473         wildcard process pid for super_resume for kernels with a
4474         specific bug.
4475
4476 2018-02-27  Phil Muldoon  <pmuldoon@redhat.com>
4477
4478         * compile/compile.c (get_args): Add additional comments
4479         explaining function.
4480
4481 2018-02-27  Simon Marchi  <simon.marchi@polymtl.ca>
4482             Tom Tromey  <tom@tromey.com>
4483
4484         * target.h (memory_write_request_s): Remove typedef.  Don't define
4485         VEC.
4486         (target_write_memory_blocks): Change argument to std::vector.
4487         (struct memory_write_request): Add constructor.
4488         * target-memory.c (compare_block_starting_address): Return bool.
4489         Change argument types.
4490         (claim_memory): Change arguments to use std::vector.
4491         (split_regular_and_flash_blocks, blocks_to_erase)
4492         (compute_garbled_blocks): Likewise.
4493         (cleanup_request_data, cleanup_write_requests_vector): Remove.
4494         (target_write_memory_blocks): Change argument to std::vector.
4495         * symfile.c (struct load_section_data): Add constructor and
4496         destructor.  Use std::vector for "requests".
4497         (struct load_progress_data): Add initializers.
4498         (load_section_callback): Update.  Use "new".
4499         (clear_memory_write_data): Remove.
4500         (generic_load): Update.
4501
4502 2018-02-27  Alan Hayward  <alan.hayward@arm.com>
4503
4504         * arch/aarch64.h: Use common/tdesc.h.
4505
4506 2018-02-26  Maciej W. Rozycki  <macro@mips.com>
4507
4508         * mips-tdep.c (mips_gdbarch_init): Don't use a 32-bit BFD
4509         architecture with a 64-bit ABI.
4510
4511 2018-02-26  Maciej W. Rozycki  <macro@mips.com>
4512
4513         * gdb/mips-tdep.c (mips_gdbarch_init): Reorder ABI determination
4514         ahead of target description loading.
4515
4516 2018-02-26  Tom Tromey  <tom@tromey.com>
4517
4518         * stack.c (backtrace_command_1): Update.
4519         * python/python-internal.h (gdbpy_apply_frame_filter): Change type
4520         of "flags".
4521         * python/py-framefilter.c (py_print_frame)
4522         (gdbpy_apply_frame_filter): Change type of "flags".
4523         * mi/mi-cmd-stack.c (mi_apply_ext_lang_frame_filter): Change type
4524         of "flags".
4525         (mi_cmd_stack_list_frames, mi_cmd_stack_list_locals)
4526         (mi_cmd_stack_list_args, mi_cmd_stack_list_variables): Update.
4527         * extension.h (enum frame_filter_flag): Rename from
4528         frame_filter_flags.
4529         (frame_filter_flags): Define using DEF_ENUM_FLAGS_TYPE.
4530         (apply_ext_lang_frame_filter): Change type of "flags".
4531         * extension.c (apply_ext_lang_frame_filter): Change type of
4532         "flags".
4533         * extension-priv.h (struct extension_language_ops)
4534         <apply_frame_filter>: Change type of "flags".
4535
4536 2018-02-26  Tom Tromey  <tom@tromey.com>
4537
4538         PR python/16497:
4539         * stack.c (backtrace_command_1): Set PRINT_MORE_FRAMES flag.  Fix
4540         off-by-one in py_end computation.
4541         * python/py-framefilter.c (gdbpy_apply_frame_filter): Handle
4542         PRINT_MORE_FRAMES.
4543         * extension.h (enum frame_filter_flags) <PRINT_MORE_FRAMES>: New
4544         constant.
4545
4546 2018-02-26  Tom Tromey  <tom@tromey.com>
4547
4548         * dwarf2read.c (struct variant_field): New.
4549         (struct nextfield) <variant>: New field.
4550         (dwarf2_add_field): Handle DW_TAG_variant_part.
4551         (dwarf2_attach_fields_to_type): Attach a discriminant_info to a
4552         discriminated union.
4553         (read_structure_type): Handle DW_TAG_variant_part.
4554         (handle_struct_member_die): New function, extracted from
4555         process_structure_scope.  Handle DW_TAG_variant.
4556         (process_structure_scope): Handle discriminated unions.  Call
4557         handle_struct_member_die.
4558
4559 2018-02-26  Tom Tromey  <tom@tromey.com>
4560
4561         * rust-lang.h (rust_last_path_segment): Declare.
4562         * rust-lang.c (rust_last_path_segment): Now public.  Change
4563         contract.
4564         (struct disr_info): Remove.
4565         (RUST_ENUM_PREFIX, RUST_ENCODED_ENUM_REAL)
4566         (RUST_ENCODED_ENUM_HIDDEN, rust_union_is_untagged)
4567         (rust_get_disr_info, rust_tuple_variant_type_p): Remove.
4568         (rust_enum_p, rust_enum_variant): New function.
4569         (rust_underscore_fields): Remove "offset" parameter.
4570         (rust_print_enum): New function.
4571         (rust_val_print) <TYPE_CODE_UNION>: Remove enum code.
4572         <TYPE_CODE_STRUCT>: Call rust_print_enum when appropriate.
4573         (rust_print_struct_def): Add "for_rust_enum" parameter.  Handle
4574         enums.
4575         (rust_internal_print_type): New function, from rust_print_type.
4576         Remove enum code.
4577         (rust_print_type): Call rust_internal_print_type.
4578         (rust_evaluate_subexp) <STRUCTOP_ANONYMOUS, STRUCTOP_STRUCT>:
4579         Update enum handling.
4580         * dwarf2read.c (struct dwarf2_cu) <rust_unions>: New field.
4581         (rust_fully_qualify, alloc_discriminant_info, quirk_rust_enum)
4582         (rust_union_quirks): New functions.
4583         (process_full_comp_unit, process_full_type_unit): Call
4584         rust_union_quirks.
4585         (process_structure_scope): Update rust_unions if necessary.
4586
4587 2018-02-26  Tom Tromey  <tom@tromey.com>
4588
4589         * value.h (value_union_variant): Declare.
4590         * valops.c (value_union_variant): New function.
4591         * gdbtypes.h (TYPE_FLAG_DISCRIMINATED_UNION): New macro.
4592         (struct discriminant_info): New.
4593         (enum dynamic_prop_node_kind) <DYN_PROP_DISCRIMINATED>: New
4594         enumerator.
4595         (struct main_type) <flag_discriminated_union>: New field.
4596
4597 2018-02-26  Tom Tromey  <tom@tromey.com>
4598
4599         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4600         unittests/unpack-selftests.c.
4601         * unittests/unpack-selftests.c: New file.
4602         * value.c (unpack_bits_as_long): Fix bugs in non-bitfield cases.
4603
4604 2018-02-26  Yao Qi  <yao.qi@linaro.org>
4605
4606         * dwarf2read.c (struct partial_die_info) <read>: New method.
4607         (read_partial_die): Remove the declaration.
4608         (load_partial_dies): Update.
4609         (partial_die_info::partial_die_info):
4610         (read_partial_die): Change it to partial_die_info::read.
4611
4612 2018-02-26  Yao Qi  <yao.qi@linaro.org>
4613
4614         * dwarf2read.c (struct partial_die_info) <fixup>: New method.
4615         (fixup_partial_die): Remove declaration.
4616         (scan_partial_symbols): Update.
4617         (partial_die_parent_scope): Likewise.
4618         (partial_die_full_name): Likewise.
4619         (fixup_partial_die): Change it to partial_die_info::fixup.
4620
4621 2018-02-26  Yao Qi  <yao.qi@linaro.org>
4622
4623         * dwarf2read.c (read_partial_die): Update the declaration.
4624         (load_partial_dies): Caller update.
4625         (read_partial_die): Remove one argument abbrev_len.
4626
4627 2018-02-26  Yao Qi  <yao.qi@linaro.org>
4628
4629         * dwarf2read.c (struct partial_die_info): Add ctor, delete
4630         assignment operator.
4631         (load_partial_dies): Use ctor and copy ctor.
4632         (read_partial_die): Update.
4633         (dwarf2_cu::find_partial_die): Use ctor.
4634
4635 2018-02-26  Yao Qi  <yao.qi@linaro.org>
4636
4637         * dwarf2read.c (struct dwarf2_cu) <find_partial_die>: New method.
4638         (find_partial_die_in_comp_unit): Change it to
4639         dwarf2_cu::find_partial_die.
4640         (find_partial_die): Update.
4641
4642 2018-02-26  Yao Qi  <yao.qi@linaro.org>
4643
4644         * dwarf2read.c (read_partial_die): Remove the code checking abbrev
4645         is NULL.
4646
4647 2018-02-26  Yao Qi  <yao.qi@linaro.org>
4648
4649         * dwarf2read.c (load_partial_dies): Move the location of XOBNEW.
4650
4651 2018-02-26  Alan Hayward  <alan.hayward@arm.com>
4652
4653         * arch/amd64.h: Use common/tdesc.h.
4654         * arch/i386.c: Likewise.
4655         * arch/i386.h: Likewise.
4656         * arch/tic6x.c: Likewise.
4657         * arch/tdesc.h: Move file from here...
4658         * common/tdesc.h: ...to here.
4659         * features/aarch64-core.c: Regenerate.
4660         * features/aarch64-fpu.c: Regenerate.
4661         * features/i386/32bit-avx.c: Regenerate.
4662         * features/i386/32bit-avx512.c: Regenerate.
4663         * features/i386/32bit-core.c: Regenerate.
4664         * features/i386/32bit-linux.c: Regenerate.
4665         * features/i386/32bit-mpx.c: Regenerate.
4666         * features/i386/32bit-pkeys.c: Regenerate.
4667         * features/i386/32bit-sse.c: Regenerate.
4668         * features/i386/64bit-avx.c: Regenerate.
4669         * features/i386/64bit-avx512.c: Regenerate.
4670         * features/i386/64bit-core.c: Regenerate.
4671         * features/i386/64bit-linux.c: Regenerate.
4672         * features/i386/64bit-mpx.c: Regenerate.
4673         * features/i386/64bit-pkeys.c: Regenerate.
4674         * features/i386/64bit-segments.c: Regenerate.
4675         * features/i386/64bit-sse.c: Regenerate.
4676         * features/i386/x32-core.c: Regenerate.
4677         * features/tic6x-c6xp.c: Regenerate.
4678         * features/tic6x-core.c: Regenerate.
4679         * features/tic6x-gp.c: Regenerate.
4680         * target-descriptions.c: Use common/tdesc.h.
4681         * target-descriptions.h: Likewise.
4682
4683 2018-02-24  Tom Tromey  <tom@tromey.com>
4684
4685         * linux-thread-db.c (try_thread_db_load_from_pdir_1)
4686         (try_thread_db_load_from_dir, thread_db_load_search): Use
4687         std::string.
4688         (info_auto_load_libthread_db_compare): Return bool.  Change
4689         argument types.
4690         (info_auto_load_libthread_db): Use std::vector, std::string.
4691         Remove cleanups.
4692
4693 2018-02-24  Tom Tromey  <tom@tromey.com>
4694
4695         * i386-tdep.c (i386_fast_tracepoint_valid_at): "msg" now a
4696         std::string.
4697         * gdbarch.sh (fast_tracepoint_valid_at): Change "msg" to a
4698         std::string*.
4699         * gdbarch.c: Rebuild.
4700         * gdbarch.h: Rebuild.
4701         * breakpoint.c (check_fast_tracepoint_sals): Use std::string.
4702         * arch-utils.h (default_fast_tracepoint_valid_at): Update.
4703         * arch-utils.c (default_fast_tracepoint_valid_at): "msg" now a
4704         std::string*.
4705
4706 2018-02-23  Simon Marchi  <simon.marchi@polymtl.ca>
4707
4708         * gdbtypes.h (sect_offset): Change type to uint64_t.
4709         (sect_offset_str): New function.
4710         * dwarf2read.c (create_addrmap_from_aranges): Use
4711         sect_offset_str.
4712         (error_check_comp_unit_head): Likewise.
4713         (create_debug_type_hash_table): Likewise.
4714         (read_cutu_die_from_dwo): Likewise.
4715         (init_cutu_and_read_dies): Likewise.
4716         (init_cutu_and_read_dies_no_follow): Likewise.
4717         (process_psymtab_comp_unit_reader): Likewise.
4718         (partial_die_parent_scope): Likewise.
4719         (peek_die_abbrev): Likewise.
4720         (process_queue): Likewise.
4721         (dwarf2_physname): Likewise.
4722         (read_namespace_alias): Likewise.
4723         (read_import_statement): Likewise.
4724         (create_dwo_cu_reader): Likewise.
4725         (create_cus_hash_table): Likewise.
4726         (lookup_dwo_cutu): Likewise.
4727         (inherit_abstract_dies): Likewise.
4728         (read_func_scope): Likewise.
4729         (read_call_site_scope): Likewise.
4730         (dwarf2_add_member_fn): Likewise.
4731         (read_common_block): Likewise.
4732         (read_module_type): Likewise.
4733         (read_typedef): Likewise.
4734         (read_subrange_type): Likewise.
4735         (load_partial_dies): Likewise.
4736         (read_partial_die): Likewise.
4737         (find_partial_die): Likewise.
4738         (read_str_index): Likewise.
4739         (dwarf2_string_attr): Likewise.
4740         (build_error_marker_type): Likewise.
4741         (lookup_die_type): Likewise.
4742         (dump_die_shallow): Likewise.
4743         (follow_die_ref): Likewise.
4744         (dwarf2_fetch_die_loc_sect_off): Likewise.
4745         (dwarf2_fetch_constant_bytes): Likewise.
4746         (follow_die_sig): Likewise.
4747         (get_signatured_type): Likewise.
4748         (get_DW_AT_signature_type): Likewise.
4749         (dwarf2_find_containing_comp_unit): Likewise.
4750         (set_die_type): Likewise.
4751
4752 2018-02-21  John Baldwin  <jhb@FreeBSD.org>
4753
4754         * arch/aarch64.c: Include "common-defs.h".
4755         * arch/amd64.c: Likewise.
4756         * arch/i386.c: Likewise.
4757
4758 2018-02-21  Tom Tromey  <tom@tromey.com>
4759
4760         * value.h: (extract_field_op): Update.
4761         * eval.c (extract_field_op): Return a const char *.
4762         * expression.h (parse_expression_for_completion): Update.
4763         * completer.c (complete_expression): Update.
4764         (add_struct_fields): Make fieldname const.
4765         * parse.c (expout_completion_name): Now a unique_xmalloc_ptr.
4766         (mark_completion_tag, parse_exp_in_context_1): Update.
4767         (parse_expression_for_completion): Change "name" to
4768         unique_xmalloc_ptr*.
4769
4770 2018-02-21  Tom Tromey  <tom@tromey.com>
4771
4772         * infcall.c (call_function_by_hand_dummy): Use std::vector.
4773
4774 2018-02-21  Yao Qi  <yao.qi@linaro.org>
4775
4776         * avr-tdep.c (avr_read_pc): Change parameter type to
4777         readable_regcache.
4778         * gdbarch.sh (read_pc): Likewise.
4779         * gdbarch.c: Re-generated.
4780         * gdbarch.h: Re-generated.
4781         * hppa-tdep.c (hppa_read_pc): Change parameter type to
4782         readable_regcache.
4783         * ia64-tdep.c (ia64_read_pc): Likewise.
4784         * mips-tdep.c (mips_read_pc): Likewise.
4785         * spu-tdep.c (spu_read_pc): Likewise.
4786
4787 2018-02-21  Yao Qi  <yao.qi@linaro.org>
4788
4789         * Makefile.in (COMMON_SFILES): Add regcache-dump.c
4790         * regcache-dump.c: New file.
4791         * regcache.c: Move register_dump to regcache-dump.c.
4792         (maintenance_print_registers): Likewise.
4793         (maintenance_print_raw_registers): Likewise.
4794         (maintenance_print_cooked_registers): Likewise.
4795         (maintenance_print_register_groups): Likewise.
4796         (maintenance_print_remote_registers): Likewise.
4797         (_initialize_regcache): Likewise.
4798         * regcache.h (register_dump): Moved from regcache.c.
4799
4800 2018-02-21  Yao Qi  <yao.qi@linaro.org>
4801
4802         * regcache.c (regcache::regcache): Update.
4803         (regcache::invalidate): Move it to detached_regcache::invalidate.
4804         (get_thread_arch_aspace_regcache): Update.
4805         (regcache::raw_update): Update.
4806         (regcache::cooked_read): Remove some code.
4807         (regcache::cooked_read_value): Likewise.
4808         (regcache::raw_write): Remove assert on m_readonly_p.
4809         (regcache::raw_supply_integer): Move it to
4810         detached_regcache::raw_supply_integer.
4811         (regcache::raw_supply_zeroed): Likewise.
4812         * regcache.h (detached_regcache) <raw_supply_integer>: New
4813         declaration.
4814         <raw_supply_zeroed, invalidate>: Likewise.
4815         (regcache) <raw_supply_integer, raw_supply_zeroed>: Removed.
4816         <invalidate>: Likewise.
4817         <m_readonly_p>: Removed.
4818
4819 2018-02-21  Yao Qi  <yao.qi@linaro.org>
4820
4821         * infcmd.c (get_return_value): Let stop_regs point to
4822         get_current_regcache.
4823         * regcache.c (regcache::regcache): Remove.
4824         (register_dump_reg_buffer): New class.
4825         (regcache_print): Adjust.
4826         * regcache.h (regcache): Remove constructors.
4827
4828 2018-02-21  Yao Qi  <yao.qi@linaro.org>
4829
4830         * regcache.c (class register_dump): New class.
4831         (register_dump_regcache, register_dump_none): New class.
4832         (register_dump_remote, register_dump_groups): New class.
4833         (regcache_print): Update.
4834         * regcache.h (regcache_dump_what): Move it to regcache.c.
4835         (regcache) <dump>: Remove.
4836
4837 2018-02-21  Yao Qi  <yao.qi@linaro.org>
4838
4839         * jit.c (struct jit_unwind_private) <regcache>: Change its type to
4840          reg_buffer_rw *.
4841         (jit_unwind_reg_set_impl): Call raw_supply.
4842         (jit_frame_sniffer): Use reg_buffer_rw.
4843         * record-full.c (record_full_core_regbuf): Change its type.
4844         (record_full_core_open_1): Use reg_buffer_rw.
4845         (record_full_close): Likewise.
4846         (record_full_core_fetch_registers): Use regcache->raw_supply.
4847         (record_full_core_store_registers): Likewise.
4848         * regcache.c (regcache::get_register_status): Move it to
4849         reg_buffer.
4850         (regcache_raw_set_cached_value): Remove.
4851         (regcache::raw_set_cached_value): Remove.
4852         (regcache::raw_write): Call raw_supply.
4853         (regcache::raw_supply): Move it to reg_buffer_rw.
4854         * regcache.h (regcache_raw_set_cached_value): Remove.
4855         (reg_buffer_rw): New class.
4856
4857 2018-02-21  Yao Qi  <yao.qi@linaro.org>
4858
4859         * dummy-frame.c (dummy_frame_cache) <prev_regcache>: Use
4860         readonly_detached_regcache.
4861         (dummy_frame_prev_register): Use regcache->cooked_read.
4862         * frame.c (frame_save_as_regcache): Change return type.
4863         (frame_pop): Update.
4864         * frame.h (frame_save_as_regcache): Update declaration.
4865         * inferior.h (get_infcall_suspend_state_regcache): Update
4866         declaration.
4867         * infrun.c (infcall_suspend_state) <registers>: use
4868         readonly_detached_regcache.
4869         (save_infcall_suspend_state): Don't use regcache_dup.
4870         (get_infcall_suspend_state_regcache): Change return type.
4871         * linux-fork.c (struct fork_info) <savedregs>: Change to
4872         readonly_detached_regcache.
4873         <pc>: New field.
4874         (fork_save_infrun_state): Don't use regcache_dup.
4875         (info_checkpoints_command): Adjust.
4876         * mi/mi-main.c (register_changed_p): Update declaration.
4877         (mi_cmd_data_list_changed_registers): Use
4878         readonly_detached_regcache.
4879         (register_changed_p): Change parameter type to
4880         readonly_detached_regcache.
4881         * ppc-linux-tdep.c (ppu2spu_cache) <regcache>: Use
4882         readonly_detached_regcache.
4883         (ppu2spu_sniffer): Construct a new readonly_detached_regcache.
4884         * regcache.c (readonly_detached_regcache::readonly_detached_regcache):
4885         New.
4886         (regcache::save): Move it to reg_buffer.
4887         (regcache::restore): Change parameter type.
4888         (regcache_dup): Remove.
4889         * regcache.h (reg_buffer) <save>: New method.
4890         (readonly_detached_regcache): New class.
4891         * spu-tdep.c (spu2ppu_cache) <regcache>: Use
4892         readonly_detached_regcache.
4893         (spu2ppu_sniffer): Construct a new readonly_detached_regcache.
4894
4895 2018-02-21  Yao Qi  <yao.qi@linaro.org>
4896
4897         * frame.c (frame_save_as_regcache): Use regcache method save.
4898         (frame_pop): Use regcache method restore.
4899         * infrun.c (restore_infcall_suspend_state): Likewise.
4900         * linux-fork.c (fork_load_infrun_state): Likewise.
4901         * ppc-linux-tdep.c (ppu2spu_sniffer): User regcache method
4902         save.
4903         * regcache.c (regcache_save): Remove.
4904         (regcache::restore): More asserts.
4905         (regcache_cpy): Remove.
4906         * regcache.h (regcache_save): Remove the declaration.
4907         (regcache::restore): Move from private to public.
4908         Remove the friend declaration of regcache_cpy.
4909         (regcache_cpy): Remove declaration.
4910
4911 2018-02-21  Yao Qi  <yao.qi@linaro.org>
4912
4913         * aarch64-tdep.c (aarch64_pseudo_register_read_value): Change
4914         parameter type to 'readable_regcache *'.
4915         * amd64-tdep.c (amd64_pseudo_register_read_value): Likewise.
4916         * arm-tdep.c (arm_neon_quad_read): Likewise.
4917         (arm_pseudo_read): Likewise.
4918         * avr-tdep.c (avr_pseudo_register_read): Likewise.
4919         * bfin-tdep.c (bfin_pseudo_register_read): Likewise.
4920         * frv-tdep.c (frv_pseudo_register_read): Likewise.
4921         * gdbarch.c: Re-generated.
4922         * gdbarch.h: Re-generated.
4923         * gdbarch.sh (pseudo_register_read): Change parameter type to
4924         'readable_regcache *'.
4925         (pseudo_register_read_value): Likewise.
4926         * h8300-tdep.c (pseudo_from_raw_register): Likewise.
4927         (h8300_pseudo_register_read): Likewise.
4928         * hppa-tdep.c (hppa_pseudo_register_read): Likewise.
4929         * i386-tdep.c (i386_mmx_regnum_to_fp_regnum): Likewise.
4930         (i386_pseudo_register_read_into_value): Likewise.
4931         (i386_pseudo_register_read_value): Likewise.
4932         * i386-tdep.h (i386_pseudo_register_read_into_value): Update
4933         declaration.
4934         * ia64-tdep.c (ia64_pseudo_register_read): Likewise.
4935         * m32c-tdep.c (m32c_raw_read): Likewise.
4936         (m32c_read_flg): Likewise.
4937         (m32c_banked_register): Likewise.
4938         (m32c_banked_read): Likewise.
4939         (m32c_sb_read): Likewise.
4940         (m32c_part_read): Likewise.
4941         (m32c_cat_read): Likewise.
4942         (m32c_r3r2r1r0_read): Likewise.
4943         (m32c_pseudo_register_read): Likewise.
4944         * m68hc11-tdep.c (m68hc11_pseudo_register_read): Likewise.
4945         * mep-tdep.c (mep_pseudo_cr32_read): Likewise.
4946         (mep_pseudo_cr64_read): Likewise.
4947         (mep_pseudo_register_read): Likewise.
4948         * mips-tdep.c (mips_pseudo_register_read): Likewise.
4949         * msp430-tdep.c (msp430_pseudo_register_read): Likewise.
4950         * nds32-tdep.c (nds32_pseudo_register_read): Likewise.
4951         * regcache.c (regcache::raw_read): Move it to readable_regcache.
4952         (regcache::cooked_read): Likewise.
4953         (regcache::cooked_read_value): Likewise.
4954         (regcache_cooked_read_signed):
4955         (regcache::cooked_read): Likewise.
4956         * regcache.h (readable_regcache): New class.
4957         (regcache): Inherit readable_regcache.  Move some methods to
4958         readable_regcache.
4959         * rl78-tdep.c (rl78_pseudo_register_read): Change
4960         parameter type to 'readable_regcache *'.
4961         * rs6000-tdep.c (do_regcache_raw_read): Remove.
4962         (e500_pseudo_register_read): Change parameter type to
4963         'readable_regcache *'.
4964         (dfp_pseudo_register_read): Likewise.
4965         (vsx_pseudo_register_read): Likewise.
4966         (efpr_pseudo_register_read): Likewise.
4967         * s390-tdep.c (s390_pseudo_register_read): Likewise.
4968         * sh-tdep.c (sh_pseudo_register_read): Likewise.
4969         * sh64-tdep.c (pseudo_register_read_portions): Likewise.
4970         (sh64_pseudo_register_read): Likewise.
4971         * sparc-tdep.c (sparc32_pseudo_register_read): Likewise.
4972         * sparc64-tdep.c (sparc64_pseudo_register_read): Likewise.
4973         * spu-tdep.c (spu_pseudo_register_read_spu): Likewise.
4974         (spu_pseudo_register_read): Likewise.
4975         * xtensa-tdep.c (xtensa_register_read_masked): Likewise.
4976         (xtensa_pseudo_register_read): Likewise.
4977
4978 2018-02-21  Yao Qi  <yao.qi@linaro.org>
4979
4980         * regcache.c (regcache::regcache): Call reg_buffer ctor.
4981         (regcache::arch): Move it to reg_buffer::arch.
4982         (regcache::register_buffer): Likewise.
4983         (regcache::assert_regnum): Likewise.
4984         (regcache::num_raw_registers): Likewise.
4985         * regcache.h (reg_buffer): New class.
4986         (regcache): Inherit reg_buffer.
4987
4988 2018-02-20  Simon Marchi  <simon.marchi@ericsson.com>
4989
4990         * remote-sim.c (gdb_os_printf_filtered, gdb_os_vprintf_filtered,
4991         gdb_os_evprintf_filtered, gdb_os_error): Add ATTRIBUTE_PRINTF.
4992
4993 2018-02-20  Markus Metzger  <markus.t.metzger@intel.com>
4994
4995         * gnulib/update-gnulib.sh (IMPORTED_GNULIB_MODULES): Add mkstemp.
4996
4997 2018-02-19  Alan Hayward  <alan.hayward@arm.com>
4998
4999         * Makefile.in: (COMMON_SFILES): Add common/*.c files.
5000         (SFILES): Remove common/*.c files.
5001         (COMMON_OBS): Remove some *.o files built from common/*.c files.
5002         * common/common.host: Add common reference.
5003         * configure.ac: Likewise.
5004         * configure: Regenerate.
5005
5006 2018-02-16  Yao Qi  <yao.qi@linaro.org>
5007
5008         * block.c (block_namespace_info): Inherit allocate_on_obstack.
5009         (block_initialize_namespace): Use new.
5010         * dwarf2read.c (dwarf2_per_objfile): Inherit allocate_on_obstack.
5011         (dwarf2_free_objfile): Use delete.
5012         * gdbtypes.c (type_pair): Inherit allocate_on_obstack.
5013         (copy_type_recursive): Use new.
5014         * gdb_obstack.h (allocate_on_obstack): New.
5015
5016 2018-02-15  Yao Qi  <yao.qi@linaro.org>
5017
5018         PR gdb/22849
5019         * inferior.c (exit_inferior_1): Reset inf->control.
5020
5021 2018-02-15  Joel Brobecker  <brobecker@adacore.com>
5022
5023         * ada-lang.c (ada_to_fixed_value_create): Delete advance
5024         declaration.
5025
5026 2018-02-14  Pedro Alves  <palves@redhat.com>
5027
5028         * frame-unwind.c (frame_unwind_try_unwinder): Always call
5029         frame_cleanup_after_sniffer on exception.
5030
5031 2018-02-14  Tom Tromey  <tom@tromey.com>
5032
5033         * solist.h (struct target_so_ops) <bfd_open>: Make pathname
5034         const.
5035         (solib_bfd_open): Make pathname const.
5036         * solib.c (solib_bfd_open): Make pathname const.
5037         * solib-spu.c (spu_bfd_fopen): Make name const.
5038         (spu_bfd_open): Make pathname const.
5039         * solib-darwin.c (darwin_bfd_open): Make pathname const.
5040         * solib-aix.c (solib_aix_bfd_open): Make pathname const.
5041
5042 2018-02-14  Tom Tromey  <tom@tromey.com>
5043
5044         * symfile.c (symfile_bfd_open): Update.
5045         * source.h (openp, source_full_path_of, find_and_open_source):
5046         Change argument type to unique_xmalloc_ptr.
5047         * source.c (openp): Take a unique_xmalloc_ptr.
5048         (source_full_path_of, find_and_open_source): Likewise.
5049         (open_source_file, symtab_to_fullname): Update.
5050         * solist.h (struct target_so_ops) <find_and_open_solib>: Take a
5051         unique_xmalloc_ptr.
5052         * solib.c (solib_find_1): Use unique_xmalloc_ptr.
5053         (exec_file_find): Update.
5054         * psymtab.c (psymtab_to_fullname): Update.
5055         * nto-tdep.h (nto_find_and_open_solib): Update.
5056         * nto-tdep.c (nto_find_and_open_solib): Change temp_path to a
5057         unique_xmalloc_ptr.
5058         * exec.c (exec_file_attach): Update.
5059         * dwarf2read.c (try_open_dwop_file): Use unique_xmalloc_ptr.
5060         * cli/cli-cmds.c (find_and_open_script): Use unique_xmalloc_ptr.
5061
5062 2018-02-14  Tom Tromey  <tom@tromey.com>
5063
5064         * solib.c: Include source.h.
5065         * nto-tdep.c: Include source.h.
5066         * mi/mi-cmd-env.c: Include source.h.
5067         * infcmd.c: Include source.h.
5068         * exec.c: Include source.h.
5069         * defs.h (enum openp_flag, openp, source_full_path_of, mod_path)
5070         (add_path, directory_switch, source_path, init_source_path): Move
5071         declarations...
5072         * source.h (enum openp_flag, openp, source_full_path_of, mod_path)
5073         (add_path, directory_switch, source_path, init_source_path):
5074         ...here.
5075
5076 2018-02-14  Tom Tromey  <tom@tromey.com>
5077
5078         * solist.h (exec_file_find, solib_find): Return
5079         unique_xmalloc_ptr.
5080         (solib_bfd_fopen): Take a const char *.
5081         * solib.c (solib_find_1): Return unique_xmalloc_ptr.
5082         (exec_file_find, solib_find): Likewise.
5083         (solib_bfd_fopen): Do not take ownership of "pathname".
5084         (solib_bfd_open): Use unique_xmalloc_ptr.
5085         * solib-darwin.c (darwin_bfd_open): Use unique_xmalloc_ptr.
5086         * solib-aix.c (solib_aix_bfd_open): Use unique_xmalloc_ptr.
5087         * infrun.c (follow_exec): Use unique_xmalloc_ptr.
5088         * exec.c (exec_file_locate_attach): Use unique_xmalloc_ptr.
5089
5090 2018-02-14  Joel Brobecker  <brobecker@adacore.com>
5091
5092         * ada-lang.c (name_match_type_from_name): Remove reference to
5093         ada_name_for_lookup in function's documentation.
5094         * ada-lang.h (ada_name_for_lookup): Delete declaration.
5095
5096 2018-02-13  Simon Marchi  <simon.marchi@polymtl.ca>
5097
5098         * defs.h (enum openp_flags): New enum.
5099         (OPF_TRY_CWD_FIRST, OPF_SEARCH_IN_PATH, OPF_RETURN_REALPATH):
5100         Move to enum openp_flags.
5101         (openp_flags): New enum flags.
5102         (openp): Change parameter type to openp_flags.
5103         * source.c (openp): Change parameter type to openp_flags.
5104         * cli/cli-cmds.c (find_and_open_script): Use openp_flags.
5105         * dwarf2read.c (try_open_dwop_file): Use openp_flags.
5106
5107 2018-02-13  Simon Marchi  <simon.marchi@polymtl.ca>
5108
5109         * maint.c (_initialize_maint_cmds): Fix prefix of maint set/show
5110         per-command.
5111
5112 2018-02-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5113
5114         * dwarf2read.c (dwarf2_release_queue): Delete function, move body
5115         into...
5116         (class dwarf2_queue_guard): ...the destructor of this new class.
5117         (dw2_do_instantiate_symtab): Create instance of the new class
5118         dwarf2_queue_guard, remove cleanup.
5119
5120 2018-02-09  Tom Tromey  <tom@tromey.com>
5121
5122         * source.c (find_source_lines): Don't reference past the end of
5123         the vector.
5124
5125 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5126
5127         * remote.c (remote_btrace_maybe_reopen): Change error message.
5128         * btrace.c (btrace_enable): Likewise.
5129         (parse_xml_btrace): Likewise.
5130         (parse_xml_btrace_conf): Likewise.
5131
5132 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5133
5134         * nat/linux-btrace.c (diagnose_perf_event_open_fail): New.
5135         (linux_enable_pt, linux_enable_bts): Call
5136         diagnose_perf_event_open_fail.
5137
5138 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5139
5140         * nat/linux-btrace.c (perf_event_pt_event_type): Improve error message.
5141         Remove parameter and change return type.  Update callers.  Move it.
5142         (linux_enable_bts, linux_enable_pt): Improve error message.
5143         (linux_enable_pt): Remove zero buffer size check.
5144         (linux_enable_btrace): Improve error messages.  Remove NULL return
5145         check.
5146
5147 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5148
5149         * btrace.c (btrace_enable): Remove target_supports_btrace call.
5150         * nat/linux-btrace.c (perf_event_pt_event_type): Move.
5151         (kernel_supports_bts, kernel_supports_pt, linux_supports_bts)
5152         (linux_supports_pt, linux_supports_btrace): Remove.
5153         (linux_enable_bts): Call cpu_supports_bts.
5154         * nat/linux-btrace.h (linux_supports_btrace): Remove.
5155         * remote.c (remote_supports_btrace): Remove.
5156         (init_remote_ops): Remove remote_supports_btrace.
5157         * target-delegates.c: Regenerated.
5158         * target.c (target_supports_btrace): Remove.
5159         * target.h (target_ops) <to_supports_btrace>: Remove
5160         (target_supports_btrace): Remove.
5161         * x86-linux-nat.c (x86_linux_create_target): Remove
5162         linux_supports_btrace.
5163
5164 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5165
5166         * nat/linux-btrace.c (linux_enable_btrace): Throw exception if enabling
5167         btrace failed.
5168         * x86-linux-nat.c (x86_linux_enable_btrace): Catch btrace enabling
5169         exception and use message in own exception.
5170
5171 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5172
5173         * nat/linux-btrace.c: Include scoped_fd.h and scoped_mmap.h.
5174         (perf_event_pt_event_type): Use gdb_file_up.
5175         (linux_enable_bts, linux_enable_pt): Use gdb::unique_xmalloc_ptr,
5176         scoped_fd, and scoped_mmap.
5177
5178 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5179
5180         * common/scoped_mmap.h: New.
5181         * unittests/scoped_mmap-selftest.c: New.
5182         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5183         unittests/scoped_mmap-selftest.c.
5184
5185 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5186
5187         * common/scoped_fd.h: New.
5188         * unittests/scoped_fd-selftest.c: New.
5189         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5190         unittests/scoped_fd-selftest.c.
5191
5192 2018-02-09  Tom Tromey  <tom@tromey.com>
5193
5194         * auto-load.c (auto_load_section_scripts): Use
5195         gdb::unique_xmalloc_ptr.
5196
5197 2018-02-09  Tom Tromey  <tom@tromey.com>
5198
5199         * auto-load.c (execute_script_contents): Use std::string.
5200
5201 2018-02-09  Joel Brobecker  <brobecker@adacore.com>
5202
5203         * NEWS <Changes in GDB 8.1>: Clarify that "rbreak" is a new
5204         Python function, rather than a new command.
5205
5206 2018-02-08  Tom Tromey  <tom@tromey.com>
5207
5208         * solib.c (solib_find_1): Use std::string.
5209         (solib_bfd_fopen): Use unique_xmalloc_ptr.
5210
5211 2018-02-08  Tom Tromey  <tom@tromey.com>
5212
5213         * build-id.c (build_id_to_debug_bfd): Use unique_xmalloc_ptr.
5214
5215 2018-02-08  Tom Tromey  <tom@tromey.com>
5216
5217         * source.c (find_source_lines): Use gdb::def_vector.
5218
5219 2018-02-08  Tom Tromey  <tom@tromey.com>
5220
5221         * macrocmd.c (struct temporary_macro_definition): New.
5222         (macro_define_command): Use temporary_macro_definition.  Remove
5223         cleanups.
5224         (free_macro_definition_ptr): Remove.
5225
5226 2018-02-08  Tom Tromey  <tom@tromey.com>
5227
5228         * macroexp.c (maybe_expand): Use std::string.
5229
5230 2018-02-08  Tom Tromey  <tom@tromey.com>
5231
5232         * macroexp.c (struct macro_buffer): Add initializers for some
5233         members.
5234         (init_buffer, init_shared_buffer, free_buffer)
5235         (free_buffer_return_text): Remove.
5236         (macro_buffer): New constructors.
5237         (~macro_buffer): New destructor.
5238         (macro_buffer::set_shared): New method.
5239         (macro_buffer::resize_buffer, macro_buffer::appendc)
5240         (macro_buffer::appendmem): Now methods, not free functions.
5241         (set_token, append_tokens_without_splicing, stringify)
5242         (macro_stringify): Update.
5243         (gather_arguments): Change return type.  Remove argc_p argument,
5244         add args_ptr argument.  Use std::vector.
5245         (substitute_args): Remove argc argument.  Accept std::vector.
5246         (expand): Update.  Use std::vector.
5247         (scan, macro_expand, macro_expand_next): Update.
5248
5249 2018-02-08  Tom Tromey  <tom@tromey.com>
5250
5251         * symtab.c (default_collect_symbol_completion_matches_break_on):
5252         Use unique_xmalloc_ptr.
5253         * macroscope.h: (sal_macro_scope, user_macro_scope)
5254         (default_macro_scope): Return unique_xmalloc_ptr.
5255         * macroscope.c (sal_macro_scope, user_macro_scope)
5256         (default_macro_scope): Return unique_xmalloc_ptr.
5257         * macroexp.h (macro_expand, macro_expand_once): Return
5258         unique_xmalloc_ptr.
5259         * macroexp.c (macro_expand, macro_expand_once): Return
5260         unique_xmalloc_ptr.
5261         * macrocmd.c (macro_expand_command, macro_expand_once_command)
5262         (info_macro_command, info_macros_command): Use
5263         unique_xmalloc_ptr.
5264         * compile/compile-c-support.c (write_macro_definitions): Use
5265         unique_xmalloc_ptr.
5266         * c-exp.y (c_parse): Use unique_xmalloc_ptr.
5267
5268 2018-02-07  Simon Marchi  <simon.marchi@ericsson.com>
5269
5270         * value.c (value_static_field): Assign field type instead of
5271         containing type when returning an optimized out value.
5272
5273 2018-02-06  Yao Qi  <yao.qi@linaro.org>
5274
5275         * ft32-tdep.c (ft32_read_pc): Remove.
5276         (ft32_write_pc): Remove.
5277         (ft32_gdbarch_init): Update.
5278         * m32r-tdep.c (m32r_read_pc): Remove.
5279         (m32r_gdbarch_init): Update.
5280         * mep-tdep.c (mep_read_pc): Remove.
5281         (mep_gdbarch_init): Update.
5282         * microblaze-tdep.c (microblaze_write_pc): Remove.
5283         (microblaze_gdbarch_init): Update.
5284         * mn10300-tdep.c (mn10300_read_pc): Remove.
5285         (mn10300_write_pc): Remove.
5286         (mn10300_gdbarch_init): Update.
5287         * moxie-tdep.c (moxie_read_pc): Remove.
5288         (moxie_write_pc): Remove.
5289         (moxie_gdbarch_init): Update.
5290
5291 2018-02-06  Yao Qi  <yao.qi@linaro.org>
5292
5293         * expprint.c (print_subexp_standard): Handle
5294         OP_F77_UNDETERMINED_ARGLIST.
5295         (dump_subexp_body_standard): Likewise.
5296
5297 2018-02-05  Alan Hayward  <alan.hayward@arm.com>
5298
5299         * target-descriptions.c (tdesc_element_visitor) Add empty
5300         implementations.
5301         (tdesc_type): Move make_gdb_type from here.
5302         (tdesc_type_builtin): Likewise.
5303         (tdesc_type_vector): Likewise.
5304         (tdesc_type_with_fields): Move make_gdb_type_ functions from here.
5305         (make_gdb_type_struct): Move from tdesc_type_with_fields.
5306         (make_gdb_type_union): Likewise.
5307         (make_gdb_type_flags): Likewise.
5308         (make_gdb_type_enum): Likewise.
5309         (make_gdb_type): New function.
5310         (tdesc_register_type): Use static make_gdb_type.
5311
5312 2018-02-05  Ruslan Kabatsayev <b7.10110111@gmail.com>
5313
5314         * infcmd.c (default_print_one_register_info): Align natural-format
5315         column values consistently one under another.
5316         (pad_to_column): New function.
5317
5318 2018-02-05  Joel Brobecker  <brobecker@adacore.com>
5319
5320         * dwarf2read.c (dwarf2_physname): Move commment.
5321
5322 2018-02-01  Leszek Swirski  <leszeks@google.com>
5323
5324         * varobj.c (varobj_formatted_print_options): Allow recursive
5325         pretty printing if pretty printing is enabled.
5326
5327 2018-02-01  Leszek Swirski  <leszeks@google.com>
5328
5329         * c-exp.y (lex_one_token, classify_name, yylex): Don't classify
5330         names after a structop as a filename.
5331
5332 2018-02-01  Yao Qi  <yao.qi@linaro.org>
5333
5334         * arm-tdep.c (arm_record_data_proc_misc_ld_str): Rewrite it.
5335         (arm_record_coproc_data_proc): Likewise.
5336
5337 2018-02-01  Yao Qi  <yao.qi@linaro.org>
5338
5339         * arm-tdep.c (arm_record_extension_space): Change ret to signed.
5340
5341 2018-01-31  Nikola Prica  <nikola.prica@rt-rk.com>
5342
5343         * rs6000-tdep.c (skip_prologue): Remove shifting for lr_reg and
5344         assign shifted lr_reg to fdata->lr_register when lr_reg is set.
5345
5346 2018-01-31  Pedro Alves  <palves@redhat.com>
5347
5348         * darwin-nat.c (darwin_interrupt): Remove ptid_t parameter.
5349         * inflow.c (child_terminal_save_inferior): Wrap reference to
5350         tcgetpgrp in HAVE_TERMIOS_H.
5351         (child_interrupt, child_pass_ctrlc): Wrap references to signal in
5352         _WIN32.
5353         * remote-sim.c (gdbsim_interrupt): Remove ptid_t parameter and
5354         always iterate over all inferiors.
5355         (gdbsim_cntrl_c): Adjust.
5356         * windows-nat.c (windows_interrupt): Remove 'ptid_t' parameter.
5357
5358 2018-01-31  Joel Brobecker  <brobecker@adacore.com>
5359
5360         * gdbtypes.c (lookup_array_range_type): Make sure the array's
5361         index type is objfile-owned if the element type is as well.
5362
5363 2018-01-31  Joel Brobecker  <brobecker@adacore.com>
5364
5365         GDB 8.1 released.
5366
5367 2018-01-30  Philipp Rudo  <prudo@linux.vnet.ibm.com>
5368
5369         * s390-linux-tdep.c: Remove includes "features/s390-linux32.c" and
5370         "features/s390x-linux64.c".
5371         (_initialize_s390_linux_tdep): Remove initialization of tdescs
5372         s390_linux32 and s390x_linux64.
5373         (s390_linux_init_abi_31, s390_linux_init_abi_64): Don't set
5374         default tdesc.
5375         * s390-tdep.c: Include "features/s390-linux32.c" and
5376         "features/s390x-linux64.c".
5377         (s390_tdesc_valid): Add check for tdesc_has_registers.
5378         (s390_gdbarch_init): Make sure there is always a valid tdesc.
5379         (_initialize_s390_tdep): Initialize tdesc_s390_linux32 and
5380         tdesc_s390x_linux64.
5381         * s390-linux-tdep.h: Move export of tdesc_s390_linux32 and
5382         tdesc_s390x_linux64 to...
5383         * s390-tdep.h: ...here.
5384
5385 2018-01-30  Pedro Alves  <palves@redhat.com>
5386
5387         PR gdb/13211
5388         * config.in, configure: Regenerate.
5389         * configure.ac: Check for getpgid.
5390         * go32-nat.c (go32_pass_ctrlc): New.
5391         (go32_target): Install it.
5392         * inf-child.c (inf_child_target): Install
5393         child_terminal_save_inferior, child_pass_ctrlc and
5394         child_interrupt.
5395         * inf-ptrace.c (inf_ptrace_interrupt): Delete.
5396         (inf_ptrace_target): No longer install it.
5397         * infcmd.c (interrupt_target_1): Adjust.
5398         * inferior.h (child_terminal_save_inferior, child_pass_ctrlc)
5399         (child_interrupt): Declare.
5400         (inferior::terminal_state): New.
5401         * inflow.c (struct terminal_info): Update comments.
5402         (inferior_process_group): Delete.
5403         (terminal_is_ours): Delete.
5404         (gdb_tty_state): New.
5405         (child_terminal_init): Adjust.
5406         (is_gdb_terminal, sharing_input_terminal_1)
5407         (sharing_input_terminal): New functions.
5408         (child_terminal_inferior): Adjust.  Use sharing_input_terminal.
5409         Set the process's actual process group in the foreground if
5410         possible.  Handle is_ours_for_output/is_ours distinction.  Don't
5411         mark terminal as the inferior's if not sharing GDB's terminal.
5412         Don't check attach_flag.
5413         (child_terminal_ours_for_output, child_terminal_ours): Adjust to
5414         pass down a target_terminal_state.
5415         (child_terminal_save_inferior): New, factored out from ...
5416         (child_terminal_ours_1): ... this.  Handle
5417         target_terminal_state::is_ours_for_output.
5418         (child_interrupt, child_pass_ctrlc): New.
5419         (inflow_inferior_exit): Clear the inferior's terminal_state.
5420         (copy_terminal_info): Copy the inferior's terminal state.
5421         (_initialize_inflow): Remove reference to terminal_is_ours.
5422         * inflow.h (inferior_process_group): Delete.
5423         * nto-procfs.c (nto_handle_sigint, procfs_interrupt): Adjust.
5424         * procfs.c (procfs_target): Don't install procfs_interrupt.
5425         (procfs_interrupt): Delete.
5426         * remote.c (remote_serial_quit_handler): Adjust.
5427         (remote_interrupt): Remove ptid parameter.  Adjust.
5428         * target-delegates.c: Regenerate.
5429         * target.c: Include "terminal.h".
5430         (target_terminal::terminal_state): Rename to ...
5431         (target_terminal::m_terminal_state): ... this.
5432         (target_terminal::init): Adjust.
5433         (target_terminal::inferior): Adjust to per-inferior
5434         terminal_state.
5435         (target_terminal::restore_inferior, target_terminal_is_ours_kind): New.
5436         (target_terminal::ours, target_terminal::ours_for_output): Use
5437         target_terminal_is_ours_kind.
5438         (target_interrupt): Remove ptid parameter.  Adjust.
5439         (default_target_pass_ctrlc): Adjust.
5440         * target.h (target_ops::to_terminal_save_inferior): New field.
5441         (target_ops::to_interrupt): Remove ptid_t parameter.
5442         (target_interrupt): Remove ptid_t parameter.  Update comment.
5443         (target_pass_ctrlc): Update comment.
5444         * target/target.h (target_terminal_state): New scoped enum,
5445         factored out of ...
5446         (target_terminal::terminal_state): ... here.
5447         (target_terminal::inferior): Update comments.
5448         (target_terminal::restore_inferior): New.
5449         (target_terminal::is_inferior, target_terminal::is_ours)
5450         (target_terminal::is_ours_for_output): Adjust.
5451         (target_terminal::scoped_restore_terminal_state): Adjust to
5452         rename, and call restore_inferior() instead of inferior().
5453         (target_terminal::scoped_restore_terminal_state::m_state): Change
5454         type.
5455         (target_terminal::terminal_state): Rename to ...
5456         (target_terminal::m_terminal_state): ... this and change type.
5457
5458 2018-01-30  Pedro Alves  <palves@redhat.com>
5459
5460         * linux-nat.c (wait_for_signal): New function.
5461         (wait_lwp, linux_nat_wait_1): Use it instead of calling sigsuspend
5462         directly.
5463         (async_terminal_is_ours)
5464         (linux_nat_terminal_inferior, linux_nat_terminal_ours): Delete.
5465         (linux_nat_add_target): Don't override
5466         to_terminal_inferior/to_terminal_ours.
5467
5468 2018-01-29  Sergio Durigan Junior  <sergiodj@redhat.com>
5469
5470         * remote.c (remote_follow_fork): Don't call "detach_inferior".
5471
5472 2018-01-28  Simon Marchi  <simon.marchi@ericsson.com>
5473
5474         * dwarf2read.c (free_dwo_files): Add forward-declaration.
5475         (dwarf2_per_objfile::~dwarf2_per_objfile): Move content from
5476         dwarf2_per_objfile_free here.
5477         (dwarf2_per_objfile_free): Remove.
5478         (_initialize_dwarf2_read): Don't register
5479         dwarf2_per_objfile_free as a registry cleanup.
5480
5481 2018-01-27  Eli Zaretskii  <eliz@gnu.org>
5482
5483         Avoid compilation errors in MinGW native builds
5484
5485         The error is triggered by including python-internal.h, and the
5486         error message is:
5487
5488              In file included from d:\usr\lib\gcc\mingw32\6.3.0\include\c++\math.h:36:0,
5489                       from build-gnulib/import/math.h:27,
5490                       from d:/usr/Python26/include/pyport.h:235,
5491                       from d:/usr/Python26/include/Python.h:58,
5492                       from python/python-internal.h:94,
5493                       from python/py-arch.c:24:
5494              d:\usr\lib\gcc\mingw32\6.3.0\include\c++\cmath:1157:11: error: '::hypot' has not been declared
5495         using ::hypot;
5496                 ^~~~~
5497
5498         This happens because Python headers define 'hypot' to expand t
5499         '_hypot' in the Windows builds.
5500         * python/python-internal.h (_hypot) [__MINGW32__]: Define back to
5501         'hypoth'.  This avoids a compilation error.
5502
5503 2018-01-26  Alan Hayward  <alan.hayward@arm.com>
5504
5505         * MAINTAINERS (Write After Approval): Fix ordering.
5506
5507 2018-01-26  Alan Hayward  <alan.hayward@arm.com>
5508
5509         * MAINTAINERS (Write After Approval): Add Alan Hayward.
5510
5511 2018-01-26  Alan Modra  <amodra@gmail.com>
5512
5513         * ppc-linux-tdep.c (powerpc32_plt_stub): Make const.
5514         (powerpc32_plt_stub_so_1): Rename from powerpc32_plt_stub_so.
5515         Remove nop.  Make const.  Comment.
5516         (powerpc32_plt_stub_so_2): New.
5517         (POWERPC32_PLT_CHECK_LEN): Rename from POWERPC32_PLT_STUB_LEN.
5518         Correct count.  Update uses.
5519         (ppc_skip_trampoline_code): Match powerpc32_plt_stub_so_2 too.
5520         Move common code reading PLT entry word.  Correct
5521         powerpc32_plt_stub PLT address calculation.
5522         * ppc64-tdep.c (ppc64_standard_linkage1): Make const.
5523         (ppc64_standard_linkage2, ppc64_standard_linkage3): Likewise.
5524         (ppc64_standard_linkage4, ppc64_standard_linkage5): Likewise.
5525         (ppc64_standard_linkage6, ppc64_standard_linkage7): Likewise.
5526         (ppc64_standard_linkage8): Likewise.
5527         * rs6000-tdep.c (ppc_insns_match_pattern): Make pattern const.
5528         Correct insns description.
5529         * ppc-tdep.h (ppc_insns_match_pattern): Update prototype.
5530
5531 2018-01-24  Pedro Alves  <palves@redhat.com>
5532
5533         GCC PR libstdc++/83906
5534         * gdbtypes.c (operator==(const dynamic_prop &,
5535         const dynamic_prop &)): New.
5536         (operator==(const range_bounds &, const range_bounds &)): New.
5537         (check_types_equal): Use them instead of memcmp.
5538         * gdbtypes.h (operator==(const dynamic_prop &,
5539         const dynamic_prop &)): Declare.
5540         (operator!=(const dynamic_prop &, const dynamic_prop &)): Declare.
5541         (operator==(const range_bounds &, const range_bounds &)): Declare.
5542         (operator!=(const range_bounds &, const range_bounds &)): Declare.
5543
5544 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
5545
5546         * s390-linux-tdep.c (s390_record_address_mask)
5547         (s390_record_calc_disp_common, s390_record_calc_disp)
5548         (s390_record_calc_disp_vsce, s390_record_calc_rl, s390_popcnt)
5549         (s390_record_gpr_g, s390_record_gpr_h, s390_record_vr)
5550         (s390_process_record): Move to s390-tdep.c.
5551         (s390_linux_init_abi_any): Adjust.
5552         * s390-tdep.c (s390_record_address_mask)
5553         (s390_record_calc_disp_common, s390_record_calc_disp)
5554         (s390_record_calc_disp_vsce, s390_record_calc_rl, s390_popcnt)
5555         (s390_record_gpr_g, s390_record_gpr_h, s390_record_vr)
5556         (s390_process_record): Moved from s390-linux-tdep.c
5557         (s390_gdbarch_init): Adjust.
5558
5559 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
5560
5561         * s390-linux-nat.c (s390-tdep.h): New include.
5562         * Makefile.in (ALL_TARGET_OBS): Add s390-tdep.o.
5563         (HFILES_NO_SRCDIR): Add s390-tdep.h.
5564         (ALLDEPFILES): Add s390-tdep.c.
5565         * configure.tgt (s390*-*-linux*): Add s390-tdep.o.
5566         * s390-linux-tdep.h (HWCAP_S390_*, S390_*_REGNUM): Move to...
5567         * s390-tdep.h: ...this.  New file.
5568         * s390-linux-tdep.c (s390-tdep.h): New include.
5569         (_initialize_s390_tdep): Rename to...
5570         (_initialize_s390_linux_tdep): ...this and adjust.
5571         (s390_abi_kind, s390_vector_abi_kind, gdbarch_tdep)
5572         (enum named opcodes, S390_NUM_GPRS, S390_NUM_FPRS): Move to
5573         s390-tdep.h.
5574         (s390_break_insn, s390_breakpoint, s390_readinstruction, is_ri)
5575         (is_ril, is_rr, is_rre, is_rs, is_rsy, is_rx, is_rxy)
5576         (s390_is_partial_instruction, s390_software_single_step)
5577         (is_non_branch_ril, s390_displaced_step_copy_insn)
5578         (s390_displaced_step_fixup, s390_displaced_step_hw_singlestep)
5579         (s390_prologue_data, s390_addr, s390_store, s390_load)
5580         (s390_check_for_saved, s390_analyze_prologue, s390_skip_prologue)
5581         (s390_register_call_saved, s390_guess_tracepoint_registers)
5582         (s390_register_name, s390_dwarf_regmap, s390_dwarf_reg_to_regnum)
5583         (regnum_is_gpr_full, regnum_is_vxr_full, s390_value_from_register)
5584         (s390_pseudo_register_name, s390_pseudo_register_type)
5585         (s390_pseudo_register_read, s390_pseudo_register_write)
5586         (s390_pseudo_register_reggroup_p, s390_ax_pseudo_register_collect)
5587         (s390_ax_pseudo_register_push_stack, s390_gen_return_address)
5588         (s390_addr_bits_remove, s390_address_class_type_flags)
5589         (s390_address_class_type_flags_to_name)
5590         (s390_address_class_name_to_type_flags, s390_effective_inner_type)
5591         (s390_function_arg_float, s390_function_arg_vector)
5592         (is_power_of_two, s390_function_arg_integer, s390_arg_state)
5593         (s390_handle_arg, s390_push_dummy_call, s390_dummy_id)
5594         (s390_frame_align, s390_register_return_value, s390_return_value)
5595         (s390_stack_frame_destroyed_p, s390_unwind_pc, s390_unwind_sp)
5596         (s390_unwind_pseudo_register, s390_adjust_frame_regnum)
5597         (s390_dwarf2_prev_register, s390_dwarf2_frame_init_reg)
5598         (s390_trad_frame_prev_register, s390_unwind_cache)
5599         (s390_prologue_frame_unwind_cache)
5600         (s390_backchain_frame_unwind_cache, s390_frame_unwind_cache)
5601         (s390_frame_this_id, s390_frame_prev_register, s390_frame_unwind)
5602         (s390_stub_unwind_cache, s390_stub_frame_unwind_cache)
5603         (s390_stub_frame_this_id, s390_stub_frame_prev_register)
5604         (s390_stub_frame_sniffer, s390_stub_frame_unwind)
5605         (s390_frame_base_address, s390_local_base_address)
5606         (s390_frame_base, s390_gcc_target_options)
5607         (s390_gnu_triplet_regexp, s390_stap_is_single_operand)
5608         (s390_validate_reg_range, s390_tdesc_valid)
5609         (s390_gdbarch_tdep_alloc, s390_gdbarch_init): Move to...
5610         * s390-tdep.c: ...this.  New file.
5611
5612 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
5613
5614         * s390-linux-tdep.c (gdbarch_tdep.s390_syscall_record): New hook.
5615         (s390_process_record, s390_gdbarch_tdep_alloc)
5616         (s390_linux_init_abi_any): Use/set new hook.
5617
5618 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
5619
5620         * s390-linux-tdep.c (osabi.h): New include.
5621         (s390_linux_init_abi_31, s390_linux_init_abi_64)
5622         (s390_linux_init_abi_any): New functions.
5623         (s390_gdbarch_init, _initialize_s390_tdep): Adjust.
5624
5625 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
5626
5627         * s390-linux-tdep.c (s390_gdbarch_init): Use gdb_assert for
5628         tdesc_has_registers check
5629
5630 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
5631
5632         * s390-linux-tdep.c (s390_tdesc_valid): New function.
5633         (s390_validate_reg_range): New macro.
5634         (s390_gdbarch_init): Adjust.
5635
5636 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
5637
5638         * s390-linux-tdep.c (gdbarch_tdep) <tdesc>: New field.
5639         (s390_gdbarch_tdep_alloc): Adjust.
5640         (s390_gdbarch_init): Adjust.
5641
5642 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
5643
5644         * s390-linux-tdep.c (gdbarch_tdep) <have_linux_v1, have_linux_v2>
5645         <have_tdb>: Change type to bool.
5646         (s390_gdbarch_tdep_alloc): Adjust.
5647         (s390_gdbarch_init): Adjust.
5648
5649 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
5650
5651         * s390-linux-tdep (s390_abi_kind) <ABI_NONE>: New default field.
5652         (gdbarch_tdep) <have_upper, have_vx>: New fields.
5653         (s390_gdbarch_tdep_alloc): New function.
5654         (s390_gdbarch_init): Allocate tdep at start and use its fields
5655         instead of separate variables.
5656
5657 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
5658
5659         * s390-linux-tdep.c (s390_gdbarch_init): Remove duplicate checks
5660         when looking for cached gdbarch and add comment for remaining.
5661
5662 2018-01-22  Pedro Alves  <palves@redhat.com>
5663             Sergio Durigan Junior  <sergiodj@redhat.com>
5664
5665         * typeprint.c (whatis_exp): Initialize "val" in the "whatis type"
5666         case.
5667
5668 2018-01-22  Maciej W. Rozycki  <macro@mips.com>
5669
5670         * MAINTAINERS: Update my company e-mail address.
5671
5672 2018-01-22  Yao Qi  <yao.qi@linaro.org>
5673
5674         * regcache.c (cooked_write_test): New function.
5675         (_initialize_regcache): Register the test.
5676
5677 2018-01-22  Yao Qi  <yao.qi@linaro.org>
5678
5679         * ia64-tdep.c (ia64_pseudo_register_read): Call
5680         regcache->cooked_read instead of regcache_cooked_read_unsigned.
5681         * m32c-tdep.c (m32c_cat_read): Likewise.
5682         (m32c_r3r2r1r0_read): Likewise.
5683         * m68hc11-tdep.c (m68hc11_pseudo_register_read): Likewise.
5684         * xtensa-tdep.c (xtensa_register_read_masked): Likewise.
5685
5686 2018-01-22  Yao Qi  <yao.qi@linaro.org>
5687
5688         * aarch64-tdep.c (aarch64_pseudo_read_value): Call regcache
5689         method raw_read instead of regcache_raw_read.
5690         * amd64-tdep.c (amd64_pseudo_register_read_value): Likewise.
5691         * arm-tdep.c (arm_neon_quad_read): Likewise.
5692         * avr-tdep.c (avr_pseudo_register_read): Likewise.
5693         * bfin-tdep.c (bfin_pseudo_register_read): Likewise.
5694         * frv-tdep.c (frv_pseudo_register_read): Likewise.
5695         * h8300-tdep.c (h8300_pseudo_register_read): Likewise.
5696         * i386-tdep.c (i386_mmx_regnum_to_fp_regnum): Likewise.
5697         (i386_pseudo_register_read_into_value): Likewise.
5698         * mep-tdep.c (mep_pseudo_cr32_read): Likewise.
5699         * msp430-tdep.c (msp430_pseudo_register_read): Likewise.
5700         * nds32-tdep.c (nds32_pseudo_register_read): Likewise.
5701         * rl78-tdep.c (rl78_pseudo_register_read): Likewise.
5702         * s390-linux-tdep.c (s390_pseudo_register_read): Likewise.
5703         * sparc-tdep.c (sparc32_pseudo_register_read):  Likewise.
5704         * sparc64-tdep.c (sparc64_pseudo_register_read): Likewise.
5705         * spu-tdep.c (spu_pseudo_register_read_spu):  Likewise.
5706         * xtensa-tdep.c (xtensa_pseudo_register_read): Likewise.
5707
5708 2018-01-22  Yao Qi  <yao.qi@linaro.org>
5709
5710         * Makefile.in (ALL_TARGET_OBS): Remove mt-tdep.o.
5711         * configure.tgt: Remove target mt.
5712         * mt-tdep.c: Remove.
5713         * regcache.c (cooked_read_test): Remove the check for mt.
5714
5715 2018-01-22  Yao Qi  <yao.qi@linaro.org>
5716
5717         * jit.c (jit_frame_prev_register): Call regcache::cooked_read
5718         instead of gdbarch_pseudo_register_read_value.
5719
5720 2018-01-22  Joel Brobecker  <brobecker@adacore.com>
5721
5722         * dwarf2read.c (need_gnat_info): Return nonzero if the cu's
5723         language is Ada.
5724
5725 2018-01-22  Joel Brobecker  <brobecker@adacore.com>
5726
5727         * linespec.c (create_sals_line_offset): Remove code that preserved
5728         the symtab_and_line's line number.
5729
5730 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
5731
5732         * varobj.c (varobj_create): Don't set valid_block when creating a
5733         floating varobj.
5734
5735 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
5736
5737         * varobj.c (varobj_create): Remove out of date comment.
5738
5739 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
5740
5741         PR mi/20395
5742         * ada-exp.y (write_var_from_sym): Pass extra parameter when
5743         updating innermost block.
5744         * parse.c (innermost_block_tracker::update): Take extra type
5745         parameter, and check types match before updating innermost block.
5746         (write_dollar_variable): Update innermost block for registers.
5747         * parser-defs.h (enum innermost_block_tracker_type): New enum.
5748         (innermost_block_tracker::innermost_block_tracker): Initialise
5749         m_types member.
5750         (innermost_block_tracker::reset): Take type parameter.
5751         (innermost_block_tracker::update): Take type parameter, and pass
5752         type through as needed.
5753         (innermost_block_tracker::m_types): New member.
5754         * varobj.c (varobj_create): Pass type when reseting innermost
5755         block.
5756
5757 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
5758
5759         * ada-exp.y (write_var_from_sym): Switch to innermost_block API.
5760         * ada-lang.c (resolve_subexp): Likewise.
5761         * breakpoint.c (set_breakpoint_condition) Likewise.
5762         (watch_command_1) Likewise.
5763         * c-exp.y (variable): Likewise.
5764         * d-exp.y (PrimaryExpression): Likewise.
5765         * f-exp.y (variable): Likewise.
5766         * go-exp.y (variable): Likewise.
5767         * m2-exp.y (variable): Likewise.
5768         * objfiles.c (objfile::~objfile): Likewise.
5769         * p-exp.y (variable): Likewise.
5770         * parse.c (innermost_block): Change type.
5771         * parser-defs.h (class innermost_block_tracker): New.
5772         (innermost_block): Change to innermost_block_tracker.
5773         * printcmd.c (display_command): Switch to innermost_block API.
5774         (do_one_display): Likewise.
5775         * rust-exp.y (do_one_display): Likewise.
5776         * symfile.c (clear_symtab_users): Likewise.
5777         * varobj.c (varobj_create): Switch to innermost_block API, replace
5778         use of innermost_block with block stored on varobj object.
5779
5780 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
5781
5782         * expression.h (innermost_block): Remove declaration.
5783         * varobj.c: Add 'parser-defs.h' include.
5784
5785 2018-01-19  Tom Tromey  <tom@tromey.com>
5786
5787         * rust-lang.c (rust_lookup_symbol_nonlocal): Look up qualified
5788         symbols in the static and global blocks.
5789
5790 2018-01-19  James Clarke  <jrtc27@jrtc27.com>
5791
5792         * nat/linux-ptrace.c: Remove unnecessary reinclusion of
5793         gdb_ptrace.h, and move including gdb_wait.h ...
5794         * nat/linux-ptrace.h: ... to here.
5795
5796 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
5797
5798         * inf-ptrace.c (inf_ptrace_detach): Adjust call to
5799         inf_ptrace_detach_success.
5800         (inf_ptrace_detach_success): Add inferior parameter, use it
5801         instead of inferior_ptid, pass it to detach_inferior.
5802         * inf-ptrace.h (inf_ptrace_detach_success): Add inferior
5803         parameter.
5804         * inferior.c (detach_inferior): Add overload that takes an
5805         inferior object.
5806         * inferior.h (detach_inferior): Likewise.
5807         * linux-nat.c (linux_nat_detach): Use the inf parameter, don't
5808         use inferior_ptid, adjust call to inf_ptrace_detach_success.
5809         * linux-thread-db.c (thread_db_detach): Use inf parameter.
5810
5811 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
5812
5813         * target.h (struct target_ops) <to_detach>: Add inferior
5814         parameter.
5815         (target_detach): Likewise.
5816         * target.c (dispose_inferior): Pass inferior down.
5817         (target_detach): Pass inferior down.  Assert that it is equal to
5818         the current inferior.
5819         * aix-thread.c (aix_thread_detach): Pass inferior down.
5820         * corefile.c (core_file_command): Pass current_inferior() down.
5821         * corelow.c (core_detach): Add inferior parameter.
5822         * darwin-nat.c (darwin_detach): Likewise.
5823         * gnu-nat.c (gnu_detach): Likewise.
5824         * inf-ptrace.c (inf_ptrace_detach): Likewise.
5825         * infcmd.c (detach_command): Pass current_inferior() down to
5826         target_detach.
5827         * infrun.c (follow_fork_inferior): Pass parent_inf to
5828         target_detach.
5829         (handle_vfork_child_exec_or_exit): Pass inf->vfork_parent to
5830         target_detach.
5831         * linux-nat.c (linux_nat_detach): Add inferior parameter.
5832         * linux-thread-db.c (thread_db_detach): Likewise.
5833         * nto-procfs.c (procfs_detach): Likewise.
5834         * procfs.c (procfs_detach): Likewise.
5835         * record.c (record_detach): Likewise.
5836         * record.h (struct inferior): Forward-declare.
5837         (record_detach): Add inferior parameter.
5838         * remote-sim.c (gdbsim_detach): Likewise.
5839         * remote.c (remote_detach_1): Likewise.
5840         (remote_detach): Likewise.
5841         (extended_remote_detach): Likewise.
5842         * sol-thread.c (sol_thread_detach): Likewise.
5843         * target-debug.h (target_debug_print_inferior_p): New macro.
5844         * target-delegates.c: Re-generate.
5845         * top.c (kill_or_detach): Pass inferior down to target_detach.
5846         * windows-nat.c (windows_detach): Add inferior parameter.
5847
5848 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
5849
5850         * target.h (struct target_ops) <to_detach>: Remove args
5851         parameter.
5852         (target_detach): Likewise.
5853         * target.c (dispose_inferior): Adjust.
5854         (target_detach): Remove args parameter, adjust.
5855         * aix-thread.c (aix_thread_detach): Adjust.
5856         * corefile.c (core_file_command): Adjust.
5857         * corelow.c (core_detach): Adjust.
5858         * darwin-nat.c (darwin_detach): Adjust.
5859         * gnu-nat.c (gnu_detach): Adjust.
5860         * inf-ptrace.c (inf_ptrace_detach): Adjust.
5861         * infcmd.c (detach_command): Adjust
5862         * infrun.c (follow_fork_inferior): Adjust.
5863         (handle_vfork_child_exec_or_exit): Adjust.
5864         * linux-fork.c (linux_fork_detach): Remove args parameter.
5865         * linux-fork.h (linux_fork_detach): Likewise.
5866         * linux-nat.c (linux_nat_detach): Likewise, and adjust.
5867         * linux-thread-db.c (thread_db_detach): Likewise.
5868         * nto-procfs.c (procfs_detach): Likewise.
5869         * procfs.c (procfs_detach): Likewise.
5870         (do_detach): Remove signo parameter.
5871         * record.c (record_detach): Remove args parameter.
5872         * record.h (record_detach): Likewise.
5873         * remote-sim.c (gdbsim_detach): Likewise.
5874         * remote.c (remote_detach_1): Likewise.
5875         (remote_detach): Likewise.
5876         (extended_remote_detach): Likewise.
5877         * sol-thread.c (sol_thread_detach): Likewise.
5878         * target-delegates.c: Re-generate.
5879         * top.c (struct qt_args) <args>: Remove field.
5880         (kill_or_detach): Don't pass args.
5881         (quit_force): Don't set args.
5882         * windows-nat.c (windows_detach): Remove args parameter.
5883
5884 2018-01-19  Yao Qi  <yao.qi@linaro.org>
5885
5886         * arm-linux-tdep.c (arm_linux_gcc_target_options): New function.
5887         (arm_linux_init_abi): Install it.
5888
5889 2018-01-19  Yao Qi  <yao.qi@linaro.org>
5890
5891         * osabi.c (gdb_osabi_names): Extend the regexp for
5892         arm-linux-gnueabihf.
5893
5894 2018-01-18  Yao Qi  <yao.qi@linaro.org>
5895
5896         * dwarf2read.c (abbrev_table) <abbrevs>: Rename it to
5897         m_abbrevs.
5898         (abbrev_table::add_abbrev): Update.
5899         (abbrev_table::lookup_abbrev): Update.
5900
5901 2018-01-18  Yao Qi  <yao.qi@linaro.org>
5902
5903         * ppc-linux-tdep.c (ppu2spu_prev_register): Call cooked_read.
5904
5905 2018-01-17  Sergio Durigan Junior  <sergiodj@redhat.com>
5906
5907         * compile/compile.c (compile_to_object): Convert "triplet_rx"
5908         to "std::string".
5909
5910 2018-01-17  Tom Tromey  <tom@tromey.com>
5911
5912         * dwarf2read.c (symbolp): Remove typedef.  Don't instantiate VEC.
5913
5914 2018-01-17  Tom Tromey  <tom@tromey.com>
5915
5916         * gdbtypes.h (add_dyn_prop): Remove objfile parameter.
5917         * gdbtypes.c (add_dyn_prop): Remove objfile parameter.
5918         (create_array_type_with_stride): Update.
5919         * dwarf2read.c (set_die_type): Update.
5920
5921 2018-01-17  Tom Tromey  <tom@tromey.com>
5922
5923         * dwarf2read.c (delayed_method_info): Remove typedef.
5924         (dwarf2_cu::method_info): Now a std::vector.
5925         (add_to_method_list): Update.
5926         (free_delayed_list): Remove.
5927         (compute_delayed_physnames): Update.
5928         (process_full_comp_unit, process_full_type_unit): Clear the method
5929         list.  Remove cleanups.
5930         (psymtab_include_file_name): Add name_holder parameter.  Use
5931         unique_xmalloc_ptr.
5932         (dwarf_decode_lines): Update.
5933
5934 2018-01-17  Tom Tromey  <tom@tromey.com>
5935             Simon Marchi  <simon.marchi@ericsson.com>
5936
5937         * dwarf2read.c (struct dwarf2_cu): Add constructor, destructor.
5938         (dwarf2_per_objfile::free_cached_comp_units)
5939         (init_tu_and_read_dwo_dies, init_cutu_and_read_dies)
5940         (init_cutu_and_read_dies_no_follow): Update.
5941         (dwarf2_cu::dwarf2_cu): Rename from init_one_comp_unit.
5942         (dwarf2_cu::~dwarf2_cu): New.
5943         (free_heap_comp_unit, free_stack_comp_unit): Remove.
5944         (age_cached_comp_units, free_one_cached_comp_unit): Update.
5945
5946 2018-01-17  Tom Tromey  <tom@tromey.com>
5947             Simon Marchi  <simon.marchi@ericsson.com>
5948
5949         * dwarf2read.c (struct dwarf2_cu) <abbrev_table>: Remove.
5950         (struct die_reader_specs) <abbrev_table>: New member.
5951         (struct abbrev_table): Add constructor.
5952         <alloc_abbrev, add_abbrev, lookup_abbrev>: Declare.
5953         <abbrev_obstack>: Now an auto_obstack.
5954         (abbrev_table_up): New typedef.
5955         (init_cu_die_reader): Add abbrev_table parameter.
5956         (read_cutu_die_from_dwo): Remove abbrev_table_provided parameter.
5957         Add result_dwo_abbrev_table.
5958         (init_tu_and_read_dwo_dies, init_cutu_and_read_dies)
5959         (init_cutu_and_read_dies_no_follow, build_type_psymtabs_1):
5960         Update.
5961         (peek_die_abbrev): Take die_reader_specs, not dwarf_cu as
5962         parameter.
5963         (skip_children): Update.
5964         (abbrev_table::alloc_abbrev): Rename from
5965         abbrev_table_alloc_abbrev.
5966         (abbrev_table::add_abbrev): Rename from abbrev_table_add_abbrev.
5967         (abbrev_table::lookup_abbrev): Rename from
5968         abbrev_table_lookup_abbrev.
5969         (abbrev_table_read_table): Return abbrev_table_up.
5970         (abbrev_table_free, abbrev_table_free_cleanup)
5971         (dwarf2_read_abbrevs, dwarf2_free_abbrev_table): Remove.
5972         (load_partial_dies): Update.
5973
5974 2018-01-17  Tom Tromey  <tom@tromey.com>
5975
5976         * dwarf2read.c (dwarf2_compute_name): Update comment.
5977         (read_func_scope, read_variable): Update.
5978         (new_symbol): Remove.
5979         (new_symbol_full): Rename to new_symbol.
5980
5981 2018-01-17  Mike Gulick  <mgulick@mathworks.com>
5982
5983         PR gdb/16577
5984         * gdb_bfd.c (gdb_bfd_map_section): If unable to read object file, issue
5985         a warning instead of throwing an error, set section size to 0 and return
5986         NULL.
5987         * gdb_bfd.h (gdb_bfd_map_section): Update description.
5988
5989 2018-01-17  Simon Marchi  <simon.marchi@ericsson.com>
5990
5991         * nat/linux-ptrace.h (linux_ptrace_attach_fail_reason): Return
5992         std::string.
5993         (linux_ptrace_attach_fail_reason_string): Likewise.
5994         * nat/linux-ptrace.c (linux_ptrace_attach_fail_reason):
5995         Likewise.
5996         (linux_ptrace_attach_fail_reason_string): Likewise.
5997         * linux-nat.c (attach_proc_task_lwp_callback): Adjust.
5998
5999 2018-01-17  Simon Marchi  <simon.marchi@ericsson.com>
6000
6001         * linux-nat.c (linux_nat_attach): Remove xstrdup.
6002
6003 2018-01-17  Eldar Abusalimov  <eldar.abusalimov@jetbrains.com>
6004
6005         PR gdb/21559
6006         * configure.ac: Include <sys/types.h> prior to <sys/user.h> when
6007         checking for fs_base/gs_base fields in struct user_regs_struct.
6008         * configure: Regenerate.
6009
6010 2018-01-17  Yao Qi  <yao.qi@linaro.org>
6011
6012         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): New
6013         function.
6014         (aarch64_linux_init_abi): Install it to gdbarch hook
6015         gcc_target_options.
6016
6017 2018-01-15  Pedro Alves  <palves@redhat.com>
6018
6019         * common/signals-state-save-restore.c
6020         (save_original_signals_state): Fix typos.
6021
6022 2017-01-12  Tom Tromey  <tom@tromey.com>
6023             Sergio Durigan Junior  <sergiodj@redhat.com>
6024
6025         * Makefile.in (install-only): Install gdb-add-index.
6026
6027 2018-01-12  John Baldwin  <jhb@FreeBSD.org>
6028
6029         * fbsd-tdep.c (KVE_PROTECTION): Correct value.
6030
6031 2018-01-12  Andreas Arnez  <arnez@linux.vnet.ibm.com>
6032
6033         * infrun.c (keep_going_pass_signal): Clear step-over info when
6034         insert_breakpoints fails.
6035
6036 2018-01-11  Pedro Alves  <palves@redhat.com>
6037
6038         PR gdb/22583
6039         * infrun.c (resume): Rename to ...
6040         (resume_1): ... this.
6041         (resume): Reimplement as wrapper around resume_1.
6042
6043 2018-01-11  Pedro Alves  <palves@redhat.com>
6044
6045         PR remote/22597
6046         * remote.c (remote_parse_stop_reply): Default to the last-set
6047         general thread instead of to 'magic_null_ptid'.
6048
6049 2018-01-10  Pedro Alves  <palves@redhat.com>
6050
6051         * language.h (language_get_symbol_name_matcher): Rename ...
6052         (get_symbol_name_matcher): ... this.
6053         * language.c (language_get_symbol_name_matcher): Ditto.
6054         * dictionary.c, linespec.c, minsyms.c, psymtab.c, symtab.c: All
6055         callers adjusted.
6056
6057 2018-01-10  Pedro Alves  <palves@redhat.com>
6058
6059         PR gdb/22670
6060         * dwarf2read.c
6061         (gdb_index_symbol_name_matcher::gdb_index_symbol_name_matcher):
6062         Adjust to use language_get_symbol_name_matcher instead of
6063         language_defn::la_get_symbol_name_matcher.
6064         * language.c (language_get_symbol_name_matcher): If in Ada mode
6065         and the lookup name is a verbatim match, return Ada's matcher.
6066         * language.h (language_get_symbol_name_matcher): Adjust comment.
6067         (ada_lookup_name_info::verbatim_p):: New method.
6068
6069 2018-01-10  Pedro Alves  <palves@redhat.com>
6070
6071         PR gdb/22670
6072         * ada-lang.c (ada_collect_symbol_completion_matches): If the
6073         minsym's language is language_auto or language_cplus, pass down
6074         language_ada instead.
6075         * symtab.c (compare_symbol_name): Don't frob symbol language here.
6076
6077 2018-01-10  Pedro Alves  <palves@redhat.com>
6078
6079         PR gdb/22670
6080         * minsyms.c (linkage_name_str): New function.
6081         (iterate_over_minimal_symbols): Use it.
6082
6083 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
6084
6085         * NEWS: Document that 'info proc' now works on FreeBSD.
6086
6087 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
6088
6089         * configure.ac: Check for kinfo_getfile in libutil.
6090         * configure: Regenerate.
6091         * config.in: Regenerate.
6092         * fbsd-nat.c: Include "fbsd-tdep.h".
6093         (fbsd_fetch_cmdline): New.
6094         (fbsd_fetch_kinfo_proc): Move earlier and change to return a bool
6095         rather than calling error.
6096         (fbsd_info_proc): New.
6097         (fbsd_thread_name): Report error if fbsd_fetch_kinfo_proc fails.
6098         (fbsd_wait): Report warning if fbsd_fetch_kinfo_proc fails.
6099         (fbsd_nat_add_target): Set "to_info_proc" to "fbsd_info_proc".
6100
6101 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
6102
6103         * fbsd-nat.c (struct free_deleter): Remove.
6104         (fbsd_find_memory_regions): Use gdb::unique_xmalloc_ptr<>.
6105
6106 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
6107
6108         * fbsd-nat.c (fbsd_pid_to_exec_file) [KERN_PROC_PATHNAME]: Return
6109         NULL for an empty pathname.
6110
6111 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
6112
6113         * fbsd-tdep.c (KVE_STRUCTSIZE, KVE_START, KVE_END, KVE_OFFSET)
6114         (KVE_FLAGS, KVE_PROTECTION, KVE_PATH, KINFO_VME_PROT_READ)
6115         (KINFO_VME_PROT_WRITE, KINFO_VME_PROT_EXEC, KINFO_VME_FLAG_COW)
6116         (KINFO_VME_FLAG_NEEDS_COPY, KINFO_VME_FLAG_NOCOREDUMP)
6117         (KINFO_VME_FLAG_SUPER, KINFO_VME_FLAG_GROWS_UP)
6118         (KINFO_VME_FLAG_GROWS_DOWN, KF_STRUCTSIZE, KF_TYPE, KF_FD)
6119         (KF_PATH, KINFO_FILE_TYPE_VNODE, KINFO_FILE_FD_TYPE_CWD)
6120         (KINFO_FILE_FD_TYPE_TEXT, SIG_WORDS, struct kinfo_proc_layout)
6121         (kinfo_proc_layout_32, kinfo_proc_layout_i386)
6122         (kinfo_proc_layout_64, fbsd_vm_map_entry_flags)
6123         (fbsd_core_info_proc_mappings, fbsd_core_vnode_path)
6124         (fbsd_core_fetch_timeval, fbsd_print_sigset)
6125         (fbsd_core_info_proc_status, fbsd_core_info_proc): New.
6126         (fbsd_init_abi):  Install gdbarch "core_info_proc" method.
6127         * fbsd-tdep.h (fbsd_vm_map_entry_flags): New.
6128
6129 2018-01-08  Samuel Thibault  <samuel.thibault@ens-lyon.org>
6130
6131         * gdb/gnu-nat.c: Include <elf.h> and <link.h>.
6132         (gnu_xfer_auxv): New function.
6133         (gnu_xfer_partial): Call gnu_xfer_auxv when `object' is
6134         TARGET_OBJECT_AUXV.
6135
6136 2018-01-08  Yao Qi  <yao.qi@linaro.org>
6137             Simon Marchi  <simon.marchi@ericsson.com>
6138
6139         * Makefile.in (COMMON_SFILES): Remove selftest-arch.c and
6140         common/selftest.c.
6141         (COMMON_OBS): Remove selftest.o.
6142         * configure.ac: Append selftest-arch.c and common/selftest.c to
6143         CONFIG_SRCS.  Append selftest-arch.o and selftest.o to COMMON_OBS.
6144         * configure: Re-generated.
6145         * maint.c (maintenance_selftest): Wrap selftests::run_tests with
6146         GDB_SELF_TEST.
6147         (maintenance_info_selftests): Likewise.
6148
6149 2018-01-08  Xavier Roirand  <roirand@adacore.com>
6150
6151         * ada-valprint.c (val_print_packed_array_elements): Use
6152         proper number of elements when printing an array indexed
6153         by an enumeration type.
6154
6155 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
6156
6157         * dwarf2read.c (struct dwarf2_cu) <dwarf2_per_objfile>: Remove.
6158         (dw2_get_file_names_reader): Adjust.
6159         (lookup_dwo_signatured_type): Adjust.
6160         (lookup_dwp_signatured_type): Adjust.
6161         (lookup_signatured_type): Adjust.
6162         (create_type_unit_group): Adjust.
6163         (get_type_unit_group): Adjust.
6164         (process_psymtab_comp_unit_reader): Adjust.
6165         (build_type_psymtabs_reader): Adjust.
6166         (scan_partial_symbols): Adjust.
6167         (add_partial_symbol): Adjust.
6168         (add_partial_subprogram): Adjust.
6169         (peek_die_abbrev): Adjust.
6170         (fixup_go_packaging): Adjust.
6171         (process_imported_unit_die): Adjust.
6172         (dwarf2_compute_name): Adjust.
6173         (dwarf2_physname): Adjust.
6174         (read_import_statement): Adjust.
6175         (handle_DW_AT_stmt_list): Adjust.
6176         (read_file_scope): Adjust.
6177         (read_func_scope): Adjust.
6178         (read_lexical_block_scope): Adjust.
6179         (read_call_site_scope): Adjust.
6180         (read_variable): Adjust.
6181         (dwarf2_rnglists_process): Adjust.
6182         (dwarf2_ranges_process): Adjust.
6183         (dwarf2_ranges_read): Adjust.
6184         (dwarf2_get_pc_bounds): Adjust.
6185         (dwarf2_record_block_ranges): Adjust.
6186         (dwarf2_add_field): Adjust.
6187         (dwarf2_add_member_fn): Adjust.
6188         (read_structure_type): Adjust.
6189         (process_structure_scope): Adjust.
6190         (read_enumeration_type): Adjust.
6191         (read_array_type): Adjust.
6192         (mark_common_block_symbol_computed): Adjust.
6193         (read_common_block): Adjust.
6194         (read_namespace_type): Adjust.
6195         (read_namespace): Adjust.
6196         (read_module_type): Adjust.
6197         (read_tag_pointer_type): Adjust.
6198         (read_tag_ptr_to_member_type): Adjust.
6199         (read_tag_string_type): Adjust.
6200         (read_subroutine_type): Adjust.
6201         (read_typedef): Adjust.
6202         (read_base_type): Adjust.
6203         (attr_to_dynamic_prop): Adjust.
6204         (read_subrange_type): Adjust.
6205         (read_unspecified_type): Adjust.
6206         (dwarf2_read_abbrevs): Adjust.
6207         (load_partial_dies): Adjust.
6208         (read_partial_die): Adjust.
6209         (find_partial_die): Adjust.
6210         (guess_partial_die_structure_name): Adjust.
6211         (fixup_partial_die): Adjust.
6212         (read_attribute_value): Adjust.
6213         (read_addr_index): Adjust.
6214         (read_addr_index_from_leb128): Adjust.
6215         (read_str_index): Adjust.
6216         (dwarf2_string_attr): Adjust.
6217         (get_debug_line_section): Adjust.
6218         (dwarf_decode_line_header): Adjust.
6219         (lnp_state_machine::check_line_address): Adjust.
6220         (dwarf_decode_lines_1): Adjust.
6221         (dwarf_decode_lines): Adjust.
6222         (dwarf2_start_symtab): Adjust.
6223         (var_decode_location): Adjust.
6224         (new_symbol_full): Adjust.
6225         (dwarf2_const_value_data): Adjust.
6226         (dwarf2_const_value_attr): Adjust.
6227         (dwarf2_const_value): Adjust.
6228         (die_type): Adjust.
6229         (die_containing_type): Adjust.
6230         (build_error_marker_type): Adjust.
6231         (lookup_die_type): Adjust.
6232         (guess_full_die_structure_name): Adjust.
6233         (anonymous_struct_prefix): Adjust.
6234         (determine_prefix): Adjust.
6235         (dwarf2_name): Adjust.
6236         (follow_die_ref_or_sig): Adjust.
6237         (follow_die_offset): Adjust.
6238         (follow_die_ref): Adjust.
6239         (follow_die_sig_1): Adjust.
6240         (follow_die_sig): Adjust.
6241         (get_signatured_type): Adjust.
6242         (get_DW_AT_signature_type): Adjust.
6243         (decode_locdesc): Adjust.
6244         (dwarf_decode_macros): Adjust.
6245         (cu_debug_loc_section): Adjust.
6246         (fill_in_loclist_baton): Adjust.
6247         (dwarf2_symbol_mark_computed): Adjust.
6248         (init_one_comp_unit): Don't assign
6249         dwarf2_cu::dwarf2_per_objfile.
6250         (set_die_type): Adjust.
6251
6252 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
6253
6254         * dwarf2read.c (struct mapped_debug_names): Add constructor.
6255         <dwarf2_per_objfile>: New field.
6256         (dwarf2_per_objfile): Remove global.
6257         (get_dwarf2_per_objfile): New function.
6258         (set_dwarf2_per_objfile): New function.
6259         (dwarf2_build_psymtabs_hard): Change objfile parameter to
6260         dwarf2_per_objfile.
6261         (abbrev_table_read_table): Add dwarf2_per_objfile parameter.
6262         (read_abbrev_offset): Likewise.
6263         (read_indirect_string): Likewise.
6264         (read_indirect_line_string): Likewise.
6265         (read_indirect_string_at_offset): Likewise.
6266         (read_indirect_string_from_dwz): Likewise.
6267         (dwarf2_find_containing_comp_unit): Change objfile parameter to
6268         dwarf2_per_objfile.
6269         (age_cached_comp_units): Add dwarf2_per_objfile parameter.
6270         (create_all_comp_units): Change objfile parameter to
6271         dwarf2_per_objfile.
6272         (create_all_type_units): Likewise.
6273         (process_queue): Add dwarf2_per_objfile parameter.
6274         (read_and_check_comp_unit_head): Likewise.
6275         (lookup_dwo_unit_in_dwp): Likewise.
6276         (get_dwp_file): Likewise.
6277         (process_cu_includes): Likewise.
6278         (struct free_dwo_file_cleanup_data): New struct.
6279         (dwarf2_has_info): Use get_dwarf2_per_objfile and
6280         set_dwarf2_per_objfile.
6281         (dwarf2_get_dwz_file): Add dwarf2_per_objfile parameter.
6282         (dw2_do_instantiate_symtab): Get dwarf2_per_objfile from
6283         context, adjust calls.
6284         (dw2_instantiate_symtab): Likewise.
6285         (dw2_get_cutu): Add dwarf2_per_objfile parameter.
6286         (dw2_get_cu): Likewise.
6287         (create_cu_from_index_list): Change objfile parameter to
6288         dwarf2_per_objfile.
6289         (create_cus_from_index_list): Get dwarf2_per_objfile from
6290         context, adjust calls.
6291         (create_cus_from_index): Likewise.
6292         (create_signatured_type_table_from_index): Change objfile
6293         parameter to dwarf2_per_objfile.
6294         (create_signatured_type_table_from_debug_names): Change objfile
6295         parameter to dwarf2_per_objfile.
6296         (create_addrmap_from_index): Likewise.
6297         (create_addrmap_from_aranges): Likewise.
6298         (dwarf2_read_index): Use get_dwarf2_per_objfile, adjust calls.
6299         (dw2_setup): Remove.
6300         (dw2_get_file_names_reader): Get dwarf2_per_objfile from
6301         context.
6302         (dw2_find_last_source_symtab): Get dwarf2_per_objfile using
6303         get_dwarf2_per_objfile.
6304         (dw2_forget_cached_source_info): Likewise.
6305         (dw2_map_symtabs_matching_filename): Likewise.
6306         (struct dw2_symtab_iterator) <index>: Remove.
6307         <dwarf2_per_objfile>: New field.
6308         (dw2_symtab_iter_init): Replace index parameter with
6309         dwarf2_per_objfile.
6310         (dw2_symtab_iter_next): Use dwarf2_per_objfile from iter.
6311         (dw2_lookup_symbol): Use get_dwarf2_per_objfile and adjust.
6312         (dw2_print_stats): Likewise.
6313         (dw2_dump): Likewise.
6314         (dw2_expand_symtabs_for_function): Likewise.
6315         (dw2_expand_all_symtabs): Likewise.
6316         (dw2_expand_symtabs_with_fullname): Likewise.
6317         (dw2_expand_marked_cus): Replace index and objfile parameters
6318         with dwarf2_per_objfile.
6319         (dw_expand_symtabs_matching_file_matcher): Add
6320         dwarf2_per_objfile parameter and adjust calls.
6321         (dw2_expand_symtabs_matching): Use get_dwarf2_per_objfile and
6322         adjust calls.
6323         (dw2_find_pc_sect_compunit_symtab): Don't call dw2_setup.
6324         (dw2_map_symbol_filenames): Use get_dwarf2_per_objfile and
6325         adjust calls.
6326         (create_cus_from_debug_names_list): Replace objfile parameter
6327         with dwarf2_per_objfile and adjust calls.
6328         (create_cus_from_debug_names): Likewise.
6329         (dwarf2_read_debug_names): Likewise.
6330         (mapped_debug_names::namei_to_name): Adjust call.
6331         (dw2_debug_names_iterator::next): Likewise.
6332         (dw2_debug_names_iterator::find_vec_in_debug_names): Likewise.
6333         (dw2_debug_names_lookup_symbol): Use get_dwarf2_per_objfile.
6334         (dw2_debug_names_dump): Likewise.
6335         (dw2_debug_names_expand_symtabs_for_function): Likewise.
6336         (dw2_debug_names_expand_symtabs_matching): Likewise.
6337         (dwarf2_initialize_objfile): Likewise.
6338         (dwarf2_build_psymtabs): Likewise.
6339         (get_abbrev_section_for_cu): Get dwarf2_per_objfile from
6340         this_cu.
6341         (error_check_comp_unit_head): Add dwarf2_per_objfile parameter.
6342         (read_and_check_comp_unit_head): Likewise.
6343         (read_abbrev_offset): Likewise.
6344         (create_debug_type_hash_table): Likewise.
6345         (create_debug_types_hash_table): Likewise.
6346         (create_all_type_units): Replace objfile parameter with
6347         dwarf2_per_objfile.
6348         (add_type_unit): Add dwarf2_per_objfile parameter.
6349         (fill_in_sig_entry_from_dwo_entry): Replace objfile parameter
6350         with dwarf2_per_objfile.
6351         (lookup_dwo_signatured_type): Get dwarf2_per_objfile from cu.
6352         (lookup_dwp_signatured_type): Likewise.
6353         (lookup_signatured_type): Likewise.
6354         (read_cutu_die_from_dwo): Likewise.
6355         (init_tu_and_read_dwo_dies): Likewise.
6356         (init_cutu_and_read_dies): Likewise.
6357         (init_cutu_and_read_dies_no_follow): Likewise.
6358         (allocate_type_unit_groups_table): Add objfile parameter.
6359         (create_type_unit_group): Use dwarf2_per_objfile from cu.
6360         (get_type_unit_group): Likewise.
6361         (process_psymtab_comp_unit): Update call.
6362         (build_type_psymtabs_reader): Use dwarf2_per_objfile from cu.
6363         (build_type_psymtabs_1): Add dwarf2_per_objfile parameter.
6364         (print_tu_stats): Likewise.
6365         (build_type_psymtab_dependencies): Use dwarf2_per_objfile passed
6366         in void* parameter.
6367         (build_type_psymtabs): Change objfile parameter to
6368         dwarf2_per_objfile.
6369         (process_skeletonless_type_unit): Use dwarf2_per_objfile
6370         passed in void* parameter.
6371         (process_skeletonless_type_units): Change objfile parameter to
6372         dwarf2_per_objfile.
6373         (set_partial_user): Likewise.
6374         (dwarf2_build_psymtabs_hard): Likewise.
6375         (read_comp_units_from_section): Likewise.
6376         (create_all_comp_units): Likewise.
6377         (scan_partial_symbols): Update calls.
6378         (add_partial_symbol): Likewise.
6379         (dwarf2_read_symtab): Use get_dwarf2_per_objfile.
6380         (maybe_queue_comp_unit): Use dwarf2_read_symtab from cu.
6381         (process_queue): Add dwarf2_per_objfile parameter.
6382         (get_compunit_symtab): Use dwarf2_per_objfile from cu.
6383         (compute_compunit_symtab_includes): Likewise.
6384         (process_cu_includes): Add dwarf2_per_objfile parameter.
6385         (process_full_comp_unit): Use dwarf2_per_objfile from cu.
6386         (process_full_type_unit): Likewise.
6387         (process_imported_unit_die): Update call.
6388         (handle_DW_AT_stmt_list): Use dwarf2_per_objfile from cu.
6389         (read_file_scope): Likewise.
6390         (allocate_dwo_file_hash_table): Add objfile parameter.
6391         (lookup_dwo_file_slot): Add dwarf2_per_objfile parameter.
6392         (create_cus_hash_table): Likewise.
6393         (create_dwp_hash_table): Likewise.
6394         (create_dwo_unit_in_dwp_v1): Likewise.
6395         (create_dwp_v2_section): Likewise.
6396         (create_dwo_unit_in_dwp_v2): Likewise.
6397         (lookup_dwo_unit_in_dwp): Likewise.
6398         (try_open_dwop_file): Likewise.
6399         (open_dwo_file): Likewise. Use dwarf2_per_objfile from cu.
6400         (open_and_init_dwo_file): Use dwarf2_per_objfile from cu, update
6401         cleanup to include a reference to dwarf2_per_objfile.
6402         (open_dwp_file): Add dwarf2_per_objfile parameter.
6403         (open_and_init_dwp_file): Likewise.
6404         (get_dwp_file): Likewise.
6405         (lookup_dwo_cutu): Use dwarf2_per_objfile from cu.
6406         (queue_and_load_all_dwo_tus): Update call.
6407         (free_dwo_file_cleanup): Use dwarf2_per_objfile from cleanup
6408         data.
6409         (dwarf2_rnglists_process): Use dwarf2_per_objfile from cu.
6410         (dwarf2_ranges_process): Likewise.
6411         (dwarf2_get_pc_bounds): Likewise.
6412         (mark_common_block_symbol_computed): Likewise.
6413         (abbrev_table_read_table): Add dwarf2_per_objfile parameter.
6414         (dwarf2_read_abbrevs): Update call.
6415         (read_partial_die): Use dwarf2_per_objfile from cu.
6416         (find_partial_die): Likewise.
6417         (fixup_partial_die): Likewise.
6418         (read_attribute_value): Likewise.
6419         (read_indirect_string_at_offset_from): Add objfile parameter.
6420         (read_indirect_string_at_offset): Add dwarf2_per_objfile
6421         parameter.
6422         (read_indirect_string_from_dwz): Add objfile parameter.
6423         (read_indirect_string): Add objfile parameter.
6424         (read_addr_index_1): Add dwarf2_per_objfile parameter.
6425         (read_addr_index): Use dwarf2_per_objfile from cu.
6426         (dwarf2_read_addr_index): Use dwarf2_per_objfile from cu, don't
6427         call dw2_setup.
6428         (read_str_index): Use dwarf2_per_objfile from cu.
6429         (get_debug_line_section): Likewise.
6430         (read_formatted_entries): Add dwarf2_per_objfile parameter.
6431         (dwarf_decode_line_header): Use dwarf2_per_objfile from cu.
6432         (new_symbol_full): Use dwarf2_per_objfile from cu.
6433         (build_error_marker_type): Likewise.
6434         (lookup_die_type): Likewise.
6435         (determine_prefix): Likewise.
6436         (follow_die_offset): Likewise.
6437         (dwarf2_fetch_die_loc_sect_off): Use get_dwarf2_per_objfile.
6438         (dwarf2_fetch_constant_bytes): Don't call dw2_setup.
6439         (dwarf2_fetch_die_type_sect_off): Likewise.
6440         (dwarf2_get_die_type): Likewise.
6441         (follow_die_sig_1): Use dwarf2_per_objfile from cu.
6442         (get_signatured_type): Likewise.
6443         (get_DW_AT_signature_type): Likewise.
6444         (dwarf_decode_macro_bytes): Add dwarf2_per_objfile parameter.
6445         (dwarf_decode_macros): Use dwarf2_per_objfile from cu.
6446         (cu_debug_loc_section): Likewise.
6447         (fill_in_loclist_baton): Likewise.
6448         (dwarf2_symbol_mark_computed): Likewise.
6449         (dwarf2_find_containing_comp_unit): Change objfile parameter to
6450         dwarf2_per_objfile.
6451         (free_cached_comp_units): Use dwarf2_per_objfile passed in void*
6452         parameter.
6453         (age_cached_comp_units): Add dwarf2_per_objfile parameter.
6454         (free_one_cached_comp_unit): Use dwarf2_per_objfile from cu.
6455         (dwarf2_free_objfile): Use get_dwarf2_per_objfile.
6456         (set_die_type): Use dwarf2_free_objfile from cu.
6457         (get_die_type_at_offset): Likewise.
6458         (dwarf2_per_objfile_free): Don't assign global variable.
6459         (debug_names) <constructor>: Add dwarf2_per_objfile
6460         parameter, update m_debugstrlookup construction.
6461         (debug_names::debug_str_lookup): Add dwarf2_per_objfile
6462         parameter.
6463         <m_dwarf2_per_objfile>: New field.
6464         <lookup>: Use m_dwarf2_per_objfile.
6465         (check_dwarf64_offsets): Add dwarf2_per_objfile parameter.
6466         (psyms_seen_size): Likewise.
6467         (write_gdbindex): Replace objfile parameter with
6468         dwarf2_per_objfile.
6469         (write_debug_names): Likewise.
6470         (write_psymtabs_to_index): Likewise.
6471         (save_gdb_index_command): Use get_dwarf2_per_objfile, update
6472         calls.
6473
6474 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
6475
6476         * dwarf2read.c (struct dwarf2_cu) <objfile>: Remove.
6477         <dwarf2_per_objfile>: New field.
6478         (struct dwarf2_per_cu_data) <objfile>: Remove.
6479         <dwarf2_per_objfile>: New field.
6480         (create_cu_from_index_list): Assign dwarf2_per_objfile instead
6481         of objfile.
6482         (create_signatured_type_table_from_index): Likewise.
6483         (create_debug_type_hash_table): Likewise.
6484         (fill_in_sig_entry_from_dwo_entry): Likewise.
6485         (lookup_dwo_unit): Access objfile through dwarf2_per_objfile.
6486         (create_type_unit_group): Assign dwarf2_per_objfile instead of
6487         objfile.
6488         (create_partial_symtab): Access objfile through
6489         dwarf2_per_objfile.
6490         (process_psymtab_comp_unit_reader): Likewise.
6491         (read_comp_units_from_section): Likewise.
6492         (scan_partial_symbols): Likewise.
6493         (add_partial_symbol): Likewise.
6494         (add_partial_subprogram): Likewise.
6495         (peek_die_abbrev): Likewise.
6496         (fixup_go_packaging): Likewise.
6497         (process_full_comp_unit): Likewise.
6498         (process_full_type_unit): Likewise.
6499         (process_imported_unit_die): Likewise.
6500         (dwarf2_compute_name): Likewise.
6501         (dwarf2_physname): Likewise.
6502         (read_import_statement): Likewise.
6503         (create_cus_hash_table): Assign dwarf2_physname instead of
6504         objfile.
6505         (read_func_scope): Access objfile through dwarf2_per_objfile.
6506         (read_lexical_block_scope): Likewise.
6507         (read_call_site_scope): Likewise.
6508         (read_variable): Likewise.
6509         (dwarf2_rnglists_process): Likewise.
6510         (dwarf2_ranges_process): Likewise.
6511         (dwarf2_ranges_read): Likewise.
6512         (dwarf2_record_block_ranges): Likewise.
6513         (dwarf2_add_field): Likewise.
6514         (dwarf2_add_member_fn): Likewise.
6515         (read_structure_type): Likewise.
6516         (process_structure_scope): Likewise.
6517         (read_enumeration_type): Likewise.
6518         (read_array_type): Likewise.
6519         (read_common_block): Likewise.
6520         (read_namespace_type): Likewise.
6521         (read_namespace): Likewise.
6522         (read_module_type): Likewise.
6523         (read_tag_pointer_type): Likewise.
6524         (read_tag_ptr_to_member_type): Likewise.
6525         (read_tag_string_type): Likewise.
6526         (read_subroutine_type): Likewise.
6527         (read_typedef): Likewise.
6528         (read_base_type): Likewise.
6529         (attr_to_dynamic_prop): Likewise.
6530         (read_subrange_type): Likewise.
6531         (read_unspecified_type): Likewise.
6532         (load_partial_dies): Likewise.
6533         (read_partial_die): Likewise.
6534         (find_partial_die): Likewise.
6535         (guess_partial_die_structure_name): Likewise.
6536         (fixup_partial_die): Likewise.
6537         (read_attribute_value): Likewise.
6538         (read_addr_index_from_leb128): Likewise.
6539         (dwarf2_read_addr_index): Likewise.
6540         (dwarf2_string_attr): Likewise.
6541         (lnp_state_machine::check_line_address): Likewise.
6542         (dwarf_decode_lines_1): Likewise.
6543         (dwarf_decode_lines): Likewise.
6544         (dwarf2_start_symtab): Likewise.
6545         (var_decode_location): Likewise.
6546         (new_symbol_full): Likewise.
6547         (dwarf2_const_value_data): Likewise.
6548         (dwarf2_const_value_attr): Likewise.
6549         (dwarf2_const_value): Likewise.
6550         (die_type): Likewise.
6551         (die_containing_type): Likewise.
6552         (lookup_die_type): Likewise.
6553         (guess_full_die_structure_name): Likewise.
6554         (anonymous_struct_prefix): Likewise.
6555         (dwarf2_name): Likewise.
6556         (follow_die_ref_or_sig): Likewise.
6557         (follow_die_offset): Likewise.
6558         (follow_die_ref): Likewise.
6559         (dwarf2_fetch_die_loc_sect_off): Likewise.
6560         (dwarf2_fetch_constant_bytes): Likewise.
6561         (dwarf2_fetch_die_type_sect_off): Likewise.
6562         (dwarf2_get_die_type): Likewise.
6563         (follow_die_sig): Likewise.
6564         (decode_locdesc): Likewise.
6565         (dwarf2_per_cu_objfile): Likewise.
6566         (dwarf2_per_cu_text_offset): Likewise.
6567         (init_one_comp_unit): Assign dwarf2_per_objfile instead of
6568         objfile.
6569         (set_die_type): Access objfile through
6570         dwarf2_per_objfile.
6571
6572 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
6573
6574         * valprint.c (converted_character_d): Remove typedef.
6575         (DEF_VEC_O (converted_character_d)): Remove.
6576         (count_next_character): Use std::vector.
6577         (print_converted_chars_to_obstack): Likewise.
6578         (generic_printstr): Likewise.
6579
6580 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
6581
6582         * xml-support.h (struct gdb_xml_value): Add constructor.
6583         <value>: Change type to unique_xmalloc_ptr.
6584         (gdb_xml_value_s): Remove typedef.
6585         (DEF_VEC_O (gdb_xml_value_s)): Remove.
6586         (gdb_xml_element_start_handler): Change parameter type to
6587         std::vector.
6588         (xml_find_attribute): Likewise.
6589         * xml-support.c (xml_find_attribute): Change parameter type to
6590         std::vector and adjust.
6591         (gdb_xml_values_cleanup): Remove.
6592         (gdb_xml_parser::start_element): Adjust to std::vector.
6593         (xinclude_start_include): Change paraeter type to std::vector
6594         and adjust.
6595         * btrace.c (check_xml_btrace_version): Likewise.
6596         (parse_xml_btrace_block): Likewise.
6597         (parse_xml_btrace_pt_config_cpu): Likewise.
6598         (parse_xml_btrace_pt): Likewise.
6599         (parse_xml_btrace_conf_bts): Likewise.
6600         (parse_xml_btrace_conf_pt): Likewise.
6601         * memory-map.c (memory_map_start_memory): Likewise.
6602         (memory_map_start_property): Likewise.
6603         * osdata.c (osdata_start_osdata): Likewise.
6604         (osdata_start_item): Likewise.
6605         (osdata_start_column): Likewise.
6606         * remote.c (start_thread): Likewise.
6607         * solib-aix.c (library_list_start_library): Likewise.
6608         (library_list_start_list): Likewise.
6609         * solib-svr4.c (library_list_start_library): Likewise.
6610         (svr4_library_list_start_list): Likewise.
6611         * solib-target.c (library_list_start_segment): Likewise.
6612         (library_list_start_section): Likewise.
6613         (library_list_start_library): Likewise.
6614         (library_list_start_list): Likewise.
6615         * tracepoint.c (traceframe_info_start_memory): Likewise.
6616         (traceframe_info_start_tvar): Likewise.
6617         * xml-syscall.c (syscall_start_syscall): Likewise.
6618         * xml-tdesc.c (tdesc_start_target): Likewise.
6619         (tdesc_start_feature): Likewise.
6620         (tdesc_start_reg): Likewise.
6621         (tdesc_start_union): Likewise.
6622         (tdesc_start_struct): Likewise.
6623         (tdesc_start_flags): Likewise.
6624         (tdesc_start_enum): Likewise.
6625         (tdesc_start_field): Likewise.
6626         (tdesc_start_enum_value): Likewise.
6627         (tdesc_start_vector): Likewise.
6628
6629 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
6630
6631         * extension.h (struct xmethod_worker) <clone>: Remove.
6632         * python/py-xmethods.c (struct python_xmethod_worker) <clone>:
6633         Remove.
6634         (python_xmethod_worker::clone): Remove.
6635         * valops.c (find_overload_match): Use std::move instead of
6636         clone.
6637
6638 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
6639
6640         * extension-priv.h (enum ext_lang_rc): Remove, move to extension.h.
6641         (struct extension_language_ops) <clone_xmethod_worker_data>: Remove.
6642         <free_xmethod_worker_data>: Remove.
6643         <get_matching_xmethod_workers>: Chance VEC to std::vector.
6644         <get_xmethod_arg_types>: Remove.
6645         <get_xmethod_result_type>: Remove.
6646         <invoke_xmethod>: Remove.
6647         * extension.c (new_xmethod_worker): Remove.
6648         (clone_xmethod_worker): Remove.
6649         (get_matching_xmethod_workers): Return void, pass std::vector by
6650         pointer.
6651         (get_xmethod_arg_types): Rename to...
6652         (xmethod_worker::get_arg_types): ... this, and adjust.
6653         (get_xmethod_result_type): Rename to...
6654         (xmethod_worker::get_result_type): ... this, and adjust.
6655         (invoke_xmethod): Remove.
6656         (free_xmethod_worker): Remove.
6657         (free_xmethod_worker_vec): Remove.
6658         * extension.h (enum ext_lang_rc): Move here from
6659         extension-priv.h.
6660         (struct xmethod_worker): Add constructor and destructor.
6661         <data>: Remove.
6662         <value>: Remove.
6663         <invoke, clone, do_get_result_type, do_get_arg_types>: New
6664         virtual pure methods.
6665         <get_arg_types, get_result_type>: New methods.
6666         (xmethod_worker_ptr): Remove typedef.
6667         (DEF_VEC_P (xmethod_worker_ptr)): Remove.
6668         (xmethod_worker_vec): Remove typedef.
6669         (xmethod_worker_up): New typedef.
6670         (invoke_xmethod): Remove.
6671         (clone_xmethod_worker): Remove.
6672         (free_xmethod_worker): Remove.
6673         (free_xmethod_worker_vec): Remove.
6674         (get_xmethod_arg_types): Remove.
6675         (get_xmethod_result_type): Remove.
6676         * valops.c (find_method_list): Use std::vector, don't use
6677         intermediate vector.
6678         (value_find_oload_method_list): Use std::vector.
6679         (find_overload_match): Use std::vector.
6680         (find_oload_champ): Use std::vector.
6681         * value.c (value_free): Use operator delete.
6682         (value_of_xmethod): Rename to...
6683         (value_from_xmethod): ... this.  Don't assign
6684         xmethod_worker::value, take rvalue-reference.
6685         (result_type_of_xmethod): Adjust.
6686         (call_xmethod): Adjust.
6687         * value.h: Include extension.h.
6688         (struct xmethod_worker): Don't forward-declare.
6689         (value_of_xmethod): Rename to...
6690         (value_from_xmethod): ... this, take rvalue-reference.
6691         * python/py-xmethods.c (struct gdbpy_worker_data): Rename to...
6692         (struct python_xmethod_worker): ... this, add constructor and
6693         destructor.
6694         <invoke, clone, do_get_arg_types, do_get_result_type>: Implement.
6695         (gdbpy_free_xmethod_worker_data): Rename to...
6696         (python_xmethod_worker::~python_xmethod_worker): ... this and
6697         adjust.
6698         (gdbpy_clone_xmethod_worker_data): Rename to...
6699         (python_xmethod_worker::clone): ... this and adjust.
6700         (gdbpy_get_matching_xmethod_workers): Use std::vector, don't use
6701         temporary vector.
6702         (gdbpy_get_xmethod_arg_types): Rename to...
6703         (python_xmethod_worker::do_get_arg_types): ... this and adjust.
6704         (gdbpy_get_xmethod_result_type): Rename to...
6705         (python_xmethod_worker::do_get_result_type): ... this and
6706         adjust.
6707         (gdbpy_invoke_xmethod): Rename to...
6708         (python_xmethod_worker::invoke): ... this and adjust.
6709         (new_python_xmethod_worker): Rename to...
6710         (python_xmethod_worker::python_xmethod_worker): ... this and
6711         adjust.
6712         * python/python-internal.h (gdbpy_clone_xmethod_worker_data):
6713         Remove.
6714         (gdbpy_free_xmethod_worker_data): Remove.
6715         (gdbpy_get_matching_xmethod_workers): Use std::vector.
6716         (gdbpy_get_xmethod_arg_types): Remove.
6717         (gdbpy_get_xmethod_result_type): Remove.
6718         (gdbpy_invoke_xmethod): Remove.
6719         * python/python.c (python_extension_ops): Remove obsolete
6720         callbacks.
6721
6722 2018-01-05  Pedro Alves  <palves@redhat.com>
6723
6724         PR gdb/18653
6725         * common/signals-state-save-restore.c
6726         (save_original_signals_state): New parameter 'quiet'.  Warn if we
6727         find a custom handler preinstalled, instead of internal erroring.
6728         But only warn if !quiet.
6729         * common/signals-state-save-restore.h
6730         (save_original_signals_state): New parameter 'quiet'.
6731         * main.c (captured_main_1): Move save_original_signals_state call
6732         after option handling, and pass QUIET.
6733
6734 2018-01-05  Pedro Alves  <palves@redhat.com>
6735
6736         * spu-tdep.c (spu_catch_start): Pass
6737         symbol_name_match_type::SEARCH_NAME to block_lookup_symbol.
6738
6739 2018-01-05  Pedro Alves  <palves@redhat.com>
6740
6741         PR gdb/22670
6742         * ada-lang.c (literal_symbol_name_matcher): New function.
6743         (ada_get_symbol_name_matcher): Use it for
6744         symbol_name_match_type::SEARCH_NAME.
6745         * block.c (block_lookup_symbol): New parameter 'match_type'.  Pass
6746         it down instead of assuming symbol_name_match_type::FULL.
6747         * block.h (block_lookup_symbol): New parameter 'match_type'.
6748         * c-valprint.c (print_unpacked_pointer): Use
6749         lookup_symbol_search_name instead of lookup_symbol.
6750         * compile/compile-object-load.c (get_out_value_type): Pass down
6751         symbol_name_match_type::SEARCH_NAME.
6752         * cp-namespace.c (cp_basic_lookup_symbol): Pass down
6753         symbol_name_match_type::FULL.
6754         * cp-support.c (cp_get_symbol_name_matcher): Handle
6755         symbol_name_match_type::SEARCH_NAME.
6756         * infrun.c (insert_exception_resume_breakpoint): Use
6757         lookup_symbol_search_name.
6758         * p-valprint.c (pascal_val_print): Use lookup_symbol_search_name.
6759         * psymtab.c (maintenance_check_psymtabs): Use
6760         symbol_name_match_type::SEARCH_NAME and SYMBOL_SEARCH_NAME.
6761         * stack.c (print_frame_args): Use lookup_symbol_search_name and
6762         SYMBOL_SEARCH_NAME.
6763         * symtab.c (lookup_local_symbol): Don't demangle the lookup name
6764         if symbol_name_match_type::SEARCH_NAME.
6765         (lookup_symbol_in_language): Pass down
6766         symbol_name_match_type::FULL.
6767         (lookup_symbol_search_name): New.
6768         (lookup_language_this): Pass down
6769         symbol_name_match_type::SEARCH_NAME.
6770         (lookup_symbol_aux, lookup_local_symbol): New parameter
6771         'match_type'.  Pass it down.
6772         * symtab.h (symbol_name_match_type::SEARCH_NAME): New enumerator.
6773         (lookup_symbol_search_name): New declaration.
6774         (lookup_symbol_in_block): New 'match_type' parameter.
6775
6776 2018-01-05  Pedro Alves  <palves@redhat.com>
6777
6778         PR gdb/22670
6779         * ada-lang.c (ada_lookup_encoded_symbol): Reimplement in terms of
6780         ada_lookup_symbol.
6781         (ada_lookup_symbol): Reimplement in terms of
6782         ada_lookup_symbol_list, bits factored out from
6783         ada_lookup_encoded_symbol.
6784
6785 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
6786
6787         * ada-exp.y (write_object_renaming): When subscripting an array
6788         using a symbol as the index, pass the block in call to
6789         ada_lookup_encoded_symbol when looking that symbol up.
6790
6791 2018-01-05  Jerome Guitton  <guitton@adacore.com>
6792
6793         * ada-lang.c (ada_array_length): Use ada_index_type instead of
6794         TYPE_INDEX_TYPE.
6795
6796 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
6797
6798         * ada-lang.c (ada_to_fixed_value_create): Add handling of
6799         the case where VALUE_LVAL (val0) is not lval_memory.
6800
6801 2018-01-05  Xavier Roirand  <roirand@adacore.com>
6802
6803         * ada-valprint.c (print_optional_low_bound): Handle
6804         character-indexed array printing like boolean-indexed array
6805         printing.
6806
6807 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
6808
6809         * NEWS: Create a new section for the next release branch.
6810         Rename the section of the current branch, now that it has
6811         been cut.
6812
6813 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
6814
6815         GDB 8.1 branch created (5219ac6237c272b938c28517bf371429260c71e7):
6816         * version.in: Bump version to 8.1.50.DATE-git.
6817
6818 2018-01-03  Xavier Roirand  <roirand@adacore.com>
6819
6820         * ada-lang.h (ada_exception_catchpoint_kind) <ada_catch_handlers>:
6821         Add field.
6822         * ada-lang.c (struct exception_support_info) <catch_handlers_sym>:
6823         Add field.
6824         (default_exception_support_info) <catch_handlers_sym>: Add field.
6825         (exception_support_info_fallback) <catch_handlers_sym>: Add field.
6826         (ada_exception_name_addr_1): Add "catch handlers" handling.
6827         (ada_exception_catchpoint_cond_string) <ex>: New parameter.
6828         Update all callers.
6829         (create_excep_cond_exprs) <ex>: Add parameter.
6830         (re_set_exception): Update create_excep_cond_exprs call.
6831         (print_it_exception, print_one_exception, print_mention_exception)
6832         (print_recreate_exception): Add "catch handler" handling.
6833         (allocate_location_catch_handlers, re_set_catch_handlers)
6834         (check_status_catch_handlers, print_it_catch_handlers)
6835         (print_one_catch_handlers, print_mention_catch_handlers)
6836         (print_recreate_catch_handlers): New function.
6837         (catch_handlers_breakpoint_ops): New variable.
6838         (catch_ada_exception_command_split) <is_catch_handlers_cmd>:
6839         Add parameter.  Add "catch handler" handling.
6840         (ada_exception_sym_name, ada_exception_breakpoint_ops):
6841         Add "catch handler" handling.
6842         (ada_exception_catchpoint_cond_string): Add "catch handler"
6843         handling.
6844         (create_ada_exception_catchpoint): Update create_excep_cond_exprs
6845         call.
6846         (catch_ada_handlers_command): New function.
6847         (initialize_ada_catchpoint_ops): Initialize "catch handlers"
6848         operations structure.
6849         (_initialize_ada_language): Add "catch handlers" command entry.
6850         * NEWS: Document "catch handlers" feature.
6851
6852 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
6853
6854         * ada-lang.c (ada_value_slice_from_ptr): Take array stride into
6855         account when creating the array type of the slice.
6856         (ada_value_slice): Likewise.
6857
6858 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
6859
6860         * gdbtypes.h (enum dynamic_prop_node_kind) <DYN_PROP_BYTE_STRIDE>:
6861         New enum value.
6862         (create_array_type_with_stride): Add byte_stride_prop parameter.
6863         * gdbtypes.c (create_array_type_with_stride) <byte_stride_prop>:
6864         New parameter.  Update all callers in this file.
6865         (array_type_has_dynamic_stride): New function.
6866         (is_dynamic_type_internal, resolve_dynamic_array): Add handling
6867         of arrays with dynamic byte strides.
6868         * dwarf2read.c (read_array_type): Add support for dynamic
6869         DW_AT_byte_stride attributes.
6870
6871 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
6872
6873         * dwarf2read.c (read_unspecified_type): Treat
6874         DW_TAG_enumeration_type DIEs from Ada units as stubs.
6875
6876 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
6877
6878         Update copyright year range in all GDB files.
6879
6880 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
6881
6882         * copyright.py (BY_HAND): Remove gdb/testsuite/gdb.base/step-line.inp
6883         and gdb/testsuite/gdb.base/step-line.c.
6884
6885 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
6886
6887         * copyright.py (main): Dump the contents of
6888         MULTIPLE_COPYRIGHT_HEADERS (separately) from BY_HAND,
6889         even if BY_HAND is empty.
6890
6891 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
6892
6893         * top.c (print_gdb_version): Update Copyright year in version
6894         message.
6895
6896 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
6897
6898         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2017.
6899
6900 For older changes see ChangeLog-2017.
6901 \f
6902 Local Variables:
6903 mode: change-log
6904 left-margin: 8
6905 fill-column: 74
6906 version-control: never
6907 coding: utf-8
6908 End: