gdb/ChangeLog

   1 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
   2
   3         * objfiles.h (objfile): Add a comment describing partial symbols.
   4
   5 2019-08-05  Tom Tromey  <tromey@adacore.com>
   6
   7         * compile/compile.c (_initialize_compile): Use _(), not N_().
   8         * thread.c (_initialize_thread): Use _(), not N_().
   9         * stack.c (_initialize_stack): Use _(), not N_().
  10         * printcmd.c (_initialize_printcmd): Use _(), not N_().
  11
  12 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
  13
  14         * dwarf2read.c (struct dw2_symtab_iterator):
  15         <want_specific_block>: Remove.
  16         <block_index>: Change type to gdb::optional.
  17         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
  18         change type of BLOCK_INDEX parameter to gdb::optional.
  19         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
  20         (dw2_lookup_symbol): Don't pass argument for
  21         WANT_SPECIFIC_BLOCK.
  22         (dw2_expand_symtabs_for_function): Don't pass argument for
  23         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
  24         (class dw2_debug_names_iterator)
  25         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
  26         parameter, change BLOCK_INDEX type to gdb::optional.
  27         <m_want_specific_block>: Remove.
  28         <m_block_index>: Change type to gdb::optional.
  29         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
  30         gdb::optional.  Re-write in function of gdb::optional.
  31         (dw2_debug_names_lookup_symbol): Don't pass argument for
  32         WANT_SPECIFIC_BLOCK.
  33         (dw2_debug_names_expand_symtabs_for_function): Don't pass
  34         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
  35         BLOCK_INDEX.
  36
  37 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  38
  39         * NEWS: Mention changes to "info sources" command.
  40
  41 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  42
  43         * symtab.c (filename_partial_match_opts): New struct type.
  44         (struct output_source_filename_data): New members
  45         regexp, c_regexp, partial_match.
  46         (output_source_filename): Use new members to decide to print file.
  47         (info_sources_option_defs): New variable.
  48         (make_info_sources_options_def_group, print_info_sources_header,
  49         info_sources_command_completer):
  50         New functions.
  51         (info_sources_command): Read new optional arguments.
  52         (_initialize_symtab): Update info sources help.
  53
  54 2019-08-02  Alexandre Oliva <oliva@adacore.com>
  55
  56         * ada-lang.c (exception_support_info_v0): Renamed from...
  57         (default_exception_support_info): ... this.  Create new
  58         definition for v1.
  59         (ada_has_this_exception_support): Look up catch_handlers_sym.
  60         (ada_exception_support_info_sniffer): Try v0 after default.
  61
  62 2019-08-01  Tom Tromey  <tromey@adacore.com>
  63
  64         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
  65         gdbarch.h.
  66
  67 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
  68
  69         * s12z-tdep.c: Fix include path for s12z-opc.h.
  70
  71 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
  72
  73         * NEWS: Require GNU make 3.82.
  74
  75 2019-07-16  Tom Tromey  <tom@tromey.com>
  76
  77         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
  78         declare.
  79
  80 2019-07-30  Tom Tromey  <tromey@adacore.com>
  81
  82         * block.c (contained_in): Remove BLOCK_FUNCTION check.
  83
  84 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
  85
  86         * printcmd.c (print_address_symbolic): Print negative offsets.
  87         (build_address_symbolic): Force signed arithmetic when computing
  88         offset.
  89
  90 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
  91
  92         PR/24474: Add a function to lookup static variables.
  93         * NEWS: Mention this new function.
  94         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
  95         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
  96         * python/python.c (python_GdbMethods): Add new function.
  97
  98 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
  99
 100         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
 101         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
 102         (objfpy_lookup_static_symbol): New function.
 103         (objfile_object_methods): Add new functions.
 104
 105 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 106
 107         * NEWS: Mention 'set|show print frame-info'.  Mention new
 108         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
 109         backtrace argument.  Mention that python frame filtering code
 110         is now consistent with what 'backtrace' command prints.
 111
 112 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 113
 114         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
 115         comments.
 116         (print_frame_info_auto, print_frame_info_source_line,
 117         print_frame_info_location, print_frame_info_source_and_location,
 118         print_frame_info_location_and_address, print_frame_info_short_location):
 119         New declarations.
 120         (struct frame_print_options): New member print_frame_info.
 121         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
 122         * stack.h (get_user_print_what_frame_info): New declaration.
 123         (frame_show_address): New declaration.
 124         * stack.c (print_frame_arguments_choices): New value 'presence'.
 125         (print_frame_info_auto, print_frame_info_source_line,
 126         print_frame_info_location, print_frame_info_source_and_location,
 127         print_frame_info_location_and_address, print_frame_info_short_location,
 128         print_frame_info_choices, print_frame_info_print_what): New definitions.
 129         (print_frame_args): Only print dots for args if print frame-arguments
 130         is 'presence'.
 131         (frame_print_option_defs): New element for "frame-info".
 132         (get_user_print_what_frame_info): New function.
 133         (frame_show_address): Make non static.  Move comment to stack.h.
 134         (print_frame_info_to_print_what): New function.
 135         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
 136         to decide what to print.
 137         (backtrace_command_1): Handle the new print_frame_arguments_presence
 138         value.
 139         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
 140         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
 141         (py_print_frame): In non-mi mode, use LOCATION as default for
 142         print_what, similarly to frame information printed directly by
 143         backtrace command. Handle frame-info user option in non MI mode.
 144
 145 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 146
 147         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
 148         Add case for debugging 32-bit target on 64-bit host.  Revise
 149         comment.
 150
 151 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 152
 153         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
 154         instead of find_function_entry_range_from_pc.
 155
 156 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 157
 158         * stack.c (find_frame_funname): Remove code which preferred
 159         minsym over symtab sym in "certain pathological cases".
 160
 161         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
 162         parameter.  Change type of "do_demangle" to bool.
 163         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 164         Pass suitable "prefer_sym_over_minsym" flag to
 165         build_address_symbolic().  Don't output "+" for negative offsets.
 166         * printcmd.c (print_address_symbolic): Update invocation of
 167         build_address_symbolic to include a "prefer_sym_over_minsym"
 168         flag.
 169         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
 170         Restrict cases in which use of minimal symbol is preferred to that
 171         of a found symbol.  Update comments.
 172
 173         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
 174         for entry pc when entry pc is out of range for that FDE.
 175
 176 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
 177
 178         PR gdb/24839:
 179         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
 180         type.
 181
 182 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
 183
 184         * python/py-objfile.c (add_separate_debug_file): Fix comment about
 185         this function's Python signature.
 186
 187
 188 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
 189
 190         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
 191         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 192         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 193         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
 194         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
 195
 196
 197 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
 198
 199         * h8300-tdep.c (h8300_register_name_common): New.
 200         h8300_register_name): Use h8300_register_name_common.
 201         (h8300s_register_name): Likewise.
 202         (h8300sx_register_name): Likewise.
 203         (h8300h_register_nam): New.
 204         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
 205
 206
 207 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
 208
 209         * arm-tdep.c (arm_skip_cmse_entry): New function.
 210         (arm_is_sgstubs_section): New function.
 211         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
 212
 213 2019-07-22  Tom Tromey  <tom@tromey.com>
 214
 215         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
 216         Don't self-assign.
 217
 218 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 219
 220         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
 221         type_print.
 222
 223 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 224
 225         * symtab.c (search_symbols): Adjust msymbol matching type arrays
 226         so that GDB doesn't match any msymbols when searching in the
 227         TYPES_DOMAIN.
 228         (print_symbol_info): Print using typedef_print or type_print based
 229         on the type of the symbol.  Add updated FIXME comment moved from...
 230         (_initialize_symtab): ... move and update FIXME comment to above.
 231
 232 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 233
 234         * NEWS: Mention adding -q option to "info types".
 235         * symtab.c (struct info_types_options): New struct.
 236         (info_types_options_defs): New variable.
 237         (make_info_types_options_def_group): New function.
 238         (info_types_command): Use gdb::option framework to parse options.
 239         (info_types_command_completer): New function.
 240         (_initialize_symtab): Extend the help text on "info types" and
 241         register command completer.
 242
 243 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
 244
 245         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
 246         (lookup_symbol_in_objfile): Change int to block_enum and add a
 247         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
 248
 249 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
 250
 251         * MAINTAINERS (Write After Approval): Add self.
 252
 253 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 254
 255         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
 256         instruction to the dummy code region.
 257
 258 2019-07-19  Tom Tromey  <tromey@adacore.com>
 259
 260         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
 261         (ARGSUSED, PARAMS, __func__): Remove rules.
 262
 263 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 264
 265         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
 266         * features/arm/arm-with-iwmmxt.c: Remove.
 267         * features/arm/arm-with-iwmmxt.xml: Remove.
 268         * features/arm/arm-with-m-fpa-layout.c: Remove.
 269         * features/arm/arm-with-m-fpa-layout.xml: Remove.
 270         * features/arm/arm-with-m-vfp-d16.c: Remove.
 271         * features/arm/arm-with-m-vfp-d16.xml: Remove.
 272         * features/arm/arm-with-m.c: Remove.
 273         * features/arm/arm-with-m.xml: Remove.
 274         * features/arm/arm-with-neon.c: Remove.
 275         * features/arm/arm-with-neon.xml: Remove.
 276         * features/arm/arm-with-vfpv2.c: Remove.
 277         * features/arm/arm-with-vfpv2.xml: Remove.
 278         * features/arm/arm-with-vfpv3.c: Remove.
 279         * features/arm/arm-with-vfpv3.xml: Remove.
 280
 281 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 282
 283         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
 284
 285 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 286
 287         * arch/aarch32.c (aarch32_create_target_description): Create
 288         target descriptions using features.
 289         * arch/arm.c (arm_create_target_description)
 290         (arm_create_mprofile_target_description): Likewise.
 291         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
 292
 293 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 294
 295         * Makefile.in: Add new files.
 296         * aarch32-tdep.c: New file.
 297         * aarch32-tdep.h: New file.
 298         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 299         Call aarch32_read_description.
 300         * arch/aarch32.c: New file.
 301         * arch/aarch32.h: New file.
 302         * arch/arm.c (arm_create_target_description)
 303         (arm_create_mprofile_target_description): New function.
 304         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
 305         (arm_create_target_description)
 306         (arm_create_mprofile_target_description): New declaration.
 307         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
 308         read_description functions.
 309         * arm-linux-nat.c (arm_linux_nat_target::read_description):
 310         Likewise.
 311         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 312         * arm-tdep.c (tdesc_arm_list): New variable.
 313         (arm_register_g_packet_guesses): Call create description functions.
 314         (arm_read_description) (arm_read_mprofile_description): New
 315         function.
 316         * arm-tdep.h (arm_read_description)
 317         (arm_read_mprofile_description): Add declaration.
 318         * configure.tgt: Add new files.
 319
 320 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
 321
 322         * top.c (new_ui_command): Open specified terminal just once.
 323
 324 2019-07-18  Tom Tromey  <tromey@adacore.com>
 325
 326         * symtab.c (main_name): Constify return type.
 327         * symfile.c (set_initial_language): Update.
 328         * symtab.h (main_name): Constify return type.
 329
 330 2019-07-17  Tom Tromey  <tom@tromey.com>
 331
 332         * tui/tui-winsource.c (tui_update_source_window)
 333         (tui_update_source_window_as_is)
 334         (tui_update_source_windows_with_line): Remove return.
 335         * tui/tui-disasm.c (tui_show_disassem)
 336         (tui_show_disassem_and_update_source): Remove return.
 337         * tui/tui.c (tui_reset): Remove return.
 338         * tui/tui-wingeneral.c
 339         (tui_check_and_display_highlight_if_needed): Remove return.
 340
 341 2019-07-17  Tom Tromey  <tom@tromey.com>
 342
 343         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
 344
 345 2019-07-17  Tom Tromey  <tom@tromey.com>
 346
 347         * tui/tui-winsource.h (struct tui_exec_info_window)
 348         (struct tui_source_window_base): Move from tui-data.h.
 349         * tui/tui-winsource.c: Move many method definitions from
 350         elsewhere.  Remove "structuring" comments.
 351         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
 352         (tui_source_window_base::refresh_window): Move to
 353         tui-winsource.c.
 354         * tui/tui-win.c (tui_source_window_base::refresh_all)
 355         (tui_source_window_base::update_tab_width)
 356         (tui_source_window_base::set_new_height)
 357         (tui_source_window_base::do_make_visible_with_new_height): Move to
 358         tui-winsource.c.
 359         * tui/tui-source.h: Update.
 360         * tui/tui-source.c (tui_source_window_base::reset): Move to
 361         tui-winsource.c.
 362         * tui/tui-disasm.h: Update.
 363         * tui/tui-data.h (struct tui_exec_info_window): Move to
 364         tui-winsource.h.
 365         (struct tui_source_window_base): Likewise.
 366         * tui/tui-data.c (tui_source_window_base::clear_detail)
 367         (tui_source_window_base, ~tui_source_window_base): Move to
 368         tui-winsource.c.
 369
 370 2019-07-17  Tom Tromey  <tom@tromey.com>
 371
 372         * tui/tui-win.c (tui_resize_all)
 373         (tui_source_window_base::update_tab_width)
 374         (tui_adjust_win_heights): Update.
 375         (tui_win_info::make_invisible_and_set_new_height): Rename from
 376         make_invisible_and_set_new_height.
 377         * tui/tui-data.h (struct tui_win_info)
 378         <make_invisible_and_set_new_height>: New method.
 379
 380 2019-07-17  Tom Tromey  <tom@tromey.com>
 381
 382         * tui/tui.c: Update.
 383         * tui/tui-source.h (struct tui_source_window): Move from
 384         tui-data.h.
 385         * tui/tui-layout.c: Update.
 386         * tui/tui-disasm.c: Update.
 387         * tui/tui-data.h (struct tui_source_window): Move to
 388         tui-source.h.
 389
 390 2019-07-17  Tom Tromey  <tom@tromey.com>
 391
 392         * tui/tui-disasm.h (struct tui_disasm_window): Move from
 393         tui-data.h.
 394         * tui/tui-data.h (struct tui_disasm_window): Move to
 395         tui-disasm.h.
 396
 397 2019-07-17  Tom Tromey  <tom@tromey.com>
 398
 399         * tui/tui-regs.h (struct tui_data_item_window): Move from
 400         tui-data.h.
 401         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
 402         * tui/tui-data.h (struct tui_data_item_window): Move to
 403         tui-regs.h.
 404         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
 405
 406 2019-07-17  Tom Tromey  <tom@tromey.com>
 407
 408         * tui/tui.c: Update.
 409         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
 410         (tui_cmd_window::max_height): Move to tui-command.c.
 411         * tui/tui-layout.c: Update.
 412         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
 413         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
 414         tui-command.c.
 415         * tui/tui-command.h (struct tui_cmd_window): Move from
 416         tui-data.h.
 417         * tui/tui-command.c: Remove "structuring" comments.
 418         (tui_cmd_window::clear_detail)
 419         (tui_cmd_window::do_make_visible_with_new_height)
 420         (tui_cmd_window::max_height): Move from elsewhere.
 421
 422 2019-07-17  Tom Tromey  <tom@tromey.com>
 423
 424         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
 425         Now static.
 426         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
 427         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
 428
 429 2019-07-17  Tom Tromey  <tom@tromey.com>
 430
 431         * tui/tui.c: Update.
 432         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
 433         tui-regs.c.
 434         * tui/tui-windata.h: Remove file.
 435         * tui/tui-windata.c: Remove file.
 436         * tui/tui-win.c (tui_data_window::set_new_height)
 437         (tui_data_window::do_make_visible_with_new_height): Move to
 438         tui-regs.c.
 439         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
 440         * tui/tui-regs.c: Remove "structuring" comments.
 441         (tui_data_window::first_data_item_displayed)
 442         (tui_data_window::delete_data_content_windows)
 443         (tui_data_window::erase_data_content)
 444         (tui_data_window::display_all_data)
 445         (tui_data_window::refresh_all)
 446         (tui_data_window::do_scroll_vertical)
 447         (tui_data_window::clear_detail, tui_data_window::set_new_height)
 448         (tui_data_window::do_make_visible_with_new_height)
 449         (tui_data_window::refresh_window): Move from elsewhere.
 450         (_initialize_tui_regs): Move to end of file.
 451         * tui/tui-layout.c: Update.
 452         * tui/tui-hooks.c: Update.
 453         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
 454         * tui/tui-data.c (tui_data_window::clear_detail): Move to
 455         tui-regs.c.
 456         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
 457
 458 2019-07-17  Tom Tromey  <tom@tromey.com>
 459
 460         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
 461         seen.
 462
 463 2019-07-17  Tom Tromey  <tom@tromey.com>
 464
 465         * tui/tui-win.c (tui_source_window_base::set_new_height)
 466         (tui_source_window_base::do_make_visible_with_new_height): Use
 467         m_has_locator field directly.
 468         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
 469         method.
 470         (struct tui_source_window_base) <has_locator>: Likewise.
 471
 472 2019-07-17  Tom Tromey  <tom@tromey.com>
 473
 474         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
 475         Don't declare.
 476         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
 477         Remove.
 478         * tui/tui-win.c (tui_source_window_base::set_new_height)
 479         (tui_source_window_base::set_new_height)
 480         (make_invisible_and_set_new_height)
 481         (tui_source_window_base::do_make_visible_with_new_height)
 482         (tui_source_window_base::do_make_visible_with_new_height):
 483         Update.
 484         * tui/tui-layout.c (show_source_disasm_command, show_data)
 485         (show_source_or_disasm_and_command): Update.
 486         * tui/tui-layout.c (show_layout): Update.
 487
 488 2019-07-17  Tom Tromey  <tom@tromey.com>
 489
 490         * tui/tui-layout.c (make_data_window): Remove.
 491         (show_data): Unify creation and re-initialization cases.
 492
 493 2019-07-17  Tom Tromey  <tom@tromey.com>
 494
 495         * tui/tui-layout.c (make_source_window, make_disasm_window):
 496         Remove.
 497         (show_data): Unify creation and re-initialization cases.
 498
 499 2019-07-17  Tom Tromey  <tom@tromey.com>
 500
 501         * tui/tui-layout.c (make_command_window): Remove.
 502         (show_source_disasm_command, show_source_or_disasm_and_command):
 503         Unify creation and re-initialization cases.
 504
 505 2019-07-17  Tom Tromey  <tom@tromey.com>
 506
 507         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 508         creation and re-initialization cases.
 509
 510 2019-07-17  Tom Tromey  <tom@tromey.com>
 511
 512         * tui/tui-regs.c (tui_get_register): Return void.
 513
 514 2019-07-17  Tom Tromey  <tom@tromey.com>
 515
 516         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 517         Simplify.
 518
 519 2019-07-17  Tom Tromey  <tom@tromey.com>
 520
 521         * tui/tui-layout.c (show_source_disasm_command): Simplify window
 522         resetting.
 523
 524 2019-07-17  Tom Tromey  <tom@tromey.com>
 525
 526         * tui/tui.h (tui_set_layout_by_name): Don't declare.
 527         * tui/tui-regs.c (tui_reg_layout): New function.
 528         (tui_show_registers, tui_reg_command): Use it.
 529         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 530         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 531         parameters.
 532         (tui_layout_command): Remove.
 533
 534 2019-07-17  Tom Tromey  <tom@tromey.com>
 535
 536         * tui/tui-layout.h (tui/tui-layout): Return void.
 537         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 538
 539 2019-07-17  Tom Tromey  <tom@tromey.com>
 540
 541         * tui/tui-layout.c (show_source_disasm_command, show_data):
 542         Update.
 543         (reset_locator): Remove.
 544         (show_source_or_disasm_and_command): Update.
 545
 546 2019-07-17  Tom Tromey  <tom@tromey.com>
 547
 548         * tui/tui-source.c (tui_source_window_base::reset): Remove
 549         win_type parameter.
 550         * tui/tui-layout.c (make_command_window, make_source_window)
 551         (make_disasm_window, make_data_window)
 552         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 553         (reset_locator, show_source_or_disasm_and_command): Update.
 554         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 555         win_type parameter.
 556         (struct tui_source_window_base) <reset>: Likewise.
 557
 558 2019-07-17  Tom Tromey  <tom@tromey.com>
 559
 560         * tui/tui-layout.c (show_source_disasm_command): Use
 561         reset_locator.
 562         (reset_locator): New function.
 563         (init_and_make_win): Remove.
 564         (show_source_or_disasm_and_command): Use reset_locator.
 565
 566 2019-07-17  Tom Tromey  <tom@tromey.com>
 567
 568         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 569         condition.
 570         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 571         Remove condition.
 572         * tui/tui-source.c (tui_source_window_base::reset): New method.
 573         * tui/tui-layout.c (make_command_window): Don't call
 574         init_and_make_win.
 575         (make_source_window, make_disasm_window): Don't call
 576         make_source_or_disasm_window.
 577         (make_data_window): Don't call init_and_make_win.  Change calling
 578         convention.
 579         (show_source_disasm_command, show_data): Simplify.
 580         (make_source_or_disasm_window): Remove.
 581         (show_source_or_disasm_and_command): Simplify.
 582         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 583         (struct tui_source_window_base) <reset>: Likewise.
 584         <execution_info>: Remove initializer.
 585         * tui/tui-data.c (tui_source_window_base): Initialize
 586         execution_info.
 587
 588 2019-07-17  Tom Tromey  <tom@tromey.com>
 589
 590         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 591         variable.
 592
 593 2019-07-17  Tom Tromey  <tom@tromey.com>
 594
 595         * tui/tui.c (tui_rl_other_window): Update.
 596         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 597         superclass method first.  Always iterate over regs_content.
 598         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 599         method.
 600         * tui/tui-win.c (tui_set_focus_command): Update.
 601
 602 2019-07-17  Tom Tromey  <tom@tromey.com>
 603
 604         * tui/tui-win.c (tui_set_focus_command): Rename from
 605         tui_set_focus.  Call tui_enable.
 606         (tui_set_focus_command): Remove.
 607
 608 2019-07-17  Tom Tromey  <tom@tromey.com>
 609
 610         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 611         refresh_window.
 612         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 613         touchwin.
 614         (tui_data_window::refresh_window): Call refresh_window on data
 615         items.  Always call superclass refresh_window.
 616         (tui_win_info::refresh): Remove.
 617         (tui_source_window_base::refresh_window): Update.
 618         (tui_refresh_all): Update.
 619         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 620         refresh_window.
 621         (show_source_or_disasm_and_command): Likewise.
 622         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 623         (struct tui_source_window_base) <refresh>: Likewise.
 624
 625 2019-07-17  Tom Tromey  <tom@tromey.com>
 626
 627         * tui/tui-winsource.c (tui_clear_source_content)
 628         (tui_show_source_content): Update.
 629         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 630         whether content is empty.
 631         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 632         Remove.
 633
 634 2019-07-17  Tom Tromey  <tom@tromey.com>
 635
 636         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 637         window's contents.
 638         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 639         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 640
 641 2019-07-17  Tom Tromey  <tom@tromey.com>
 642
 643         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 644         (struct tui_data_item_window): Update.
 645
 646 2019-07-17  Tom Tromey  <tom@tromey.com>
 647
 648         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 649         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 650         defines.
 651
 652 2019-07-17  Tom Tromey  <tom@tromey.com>
 653
 654         * tui/tui-winsource.h (tui_erase_source_content)
 655         (tui_clear_source_content): Remove "display_prompt" parameter.
 656         * tui/tui-winsource.c (tui_update_source_window_as_is)
 657         (tui_update_source_windows_with_addr): Update.
 658         (tui_clear_source_content): Remove "display_prompt" parameter.
 659         (tui_erase_source_content): Likewise.  Simplify.
 660         (tui_show_source_content): Update.
 661         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 662         * tui/tui-stack.c (tui_show_frame_info): Update.
 663         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 664         Remove defines.
 665
 666 2019-07-17  Tom Tromey  <tom@tromey.com>
 667
 668         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 669         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 670         parameter.
 671         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 672         parameter.
 673
 674 2019-07-17  Tom Tromey  <tom@tromey.com>
 675
 676         * tui/tui-winsource.c (tui_clear_source_content)
 677         (tui_show_source_content, tui_show_exec_info_content)
 678         (tui_clear_exec_info_content): Update.
 679         * tui/tui-stack.c (tui_show_locator_content): Update.
 680         (tui_show_frame_info): Update.
 681         * tui/tui-source.h (tui_source_window): Don't declare.
 682         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 683         from tui_source_is_displayed.
 684         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 685         Remove field.
 686         (struct tui_source_window_base) <content_in_use>: New field.  Now
 687         bool.
 688         (struct tui_source_window) <showing_source_p>: New method.
 689         (TUI_SRC_WIN): Change cast.
 690         * tui/tui-data.c (tui_initialize_static_data): Update.
 691
 692 2019-07-17  Tom Tromey  <tom@tromey.com>
 693
 694         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 695         location_matches_p.
 696         * tui/tui-source.c (tui_source_window::location_matches_p): New
 697         method.
 698         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 699         method.
 700         * tui/tui-data.h (struct tui_source_window_base)
 701         <location_matches_p>: New method.
 702         (struct tui_source_window, struct tui_disasm_window)
 703         <location_matches_p>: Likewise.
 704
 705 2019-07-17  Tom Tromey  <tom@tromey.com>
 706
 707         * tui/tui-win.c (tui_set_win_height_command): Rename from
 708         tui_set_win_height.
 709         (tui_set_win_height_command): Remove.
 710
 711 2019-07-17  Tom Tromey  <tom@tromey.com>
 712
 713         * tui/tui-source.c (tui_source_window): New constructor.  Add
 714         observer.
 715         (~tui_source_window): New destructor.
 716         (tui_source_window::style_changed): New method.
 717         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 718         (tui_attach_detach_observers): Update.
 719         * tui/tui-data.h (struct tui_source_window): Make constructor not
 720         inline.  Add destructor.
 721         (struct tui_source_window) <style_changed>: New method.
 722         <m_observable>: New member.
 723
 724 2019-07-17  Tom Tromey  <tom@tromey.com>
 725
 726         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 727         * tui/tui-win.c (tui_resize_all): Fix typo.
 728
 729 2019-07-17  Tom Tromey  <tom@tromey.com>
 730
 731         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 732         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 733         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 734         * tui/tui-win.c (window_name_completer): Use foreach.
 735         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 736         (update_tab_width): Likewise.
 737         * tui/tui-layout.c (show_layout): Update.
 738         * tui/tui-data.h (class tui_window_iterator): New.
 739         (struct all_tui_windows): New.
 740         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 741
 742 2019-07-17  Tom Tromey  <tom@tromey.com>
 743
 744         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 745         parameter.  Don't reference globals.
 746         (tui_reg_command): Update.
 747
 748 2019-07-17  Tom Tromey  <tom@tromey.com>
 749
 750         * tui/tui-regs.c (tui_show_registers): Simplify.
 751
 752 2019-07-17  Tom Tromey  <tom@tromey.com>
 753
 754         * tui/tui-regs.c (tui_show_registers): Update.
 755         (tui_show_register_group): Add win_info parameter.
 756
 757 2019-07-17  Tom Tromey  <tom@tromey.com>
 758
 759         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 760         Rename from tui_display_reg_element_at_line.
 761         (tui_data_window::display_registers_from_line): Update.
 762         * tui/tui-data.h (struct tui_data_window)
 763         <display_reg_element_at_line>: New method.
 764
 765 2019-07-17  Tom Tromey  <tom@tromey.com>
 766
 767         * tui/tui-regs.h (tui_display_registers_from)
 768         (tui_display_registers_from_line): Don't declare.
 769         * tui/tui-windata.c (tui_data_window::display_all_data)
 770         (tui_data_window::refresh_all)
 771         (tui_data_window::do_scroll_vertical): Update.
 772         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 773         from tui_display_registers_from.
 774         (tui_display_reg_element_at_line): Update.
 775         (tui_data_window::display_registers_from_line): Rename from
 776         tui_display_registers_from_line.
 777         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 778         display_registers_from_line>: New methods.
 779
 780 2019-07-17  Tom Tromey  <tom@tromey.com>
 781
 782         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 783         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 784         from tui_erase_data_content.
 785         (tui_data_window::display_all_data)
 786         (tui_data_window::refresh_all)
 787         (tui_data_window::do_scroll_vertical): Update.
 788         * tui/tui-regs.c (tui_show_registers): Update.
 789         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 790         New method.
 791
 792 2019-07-17  Tom Tromey  <tom@tromey.com>
 793
 794         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 795         declare.
 796         * tui/tui-windata.c
 797         (tui_data_window::delete_data_content_windows): Rename from
 798         tui_delete_data_content_windows.
 799         (tui_data_window::display_all_data)
 800         (tui_data_window::do_scroll_vertical): Update.
 801         * tui/tui-data.h (struct tui_data_window)
 802         <delete_data_content_windows>: New method.
 803
 804 2019-07-17  Tom Tromey  <tom@tromey.com>
 805
 806         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 807         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 808
 809 2019-07-17  Tom Tromey  <tom@tromey.com>
 810
 811         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 812         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 813         from tui_display_all_data.
 814         * tui/tui-win.c
 815         (tui_data_window::do_make_visible_with_new_height): Update.
 816         * tui/tui-regs.c (tui_show_registers): Update.
 817         * tui/tui-layout.c (tui_set_layout): Update.
 818         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 819         method.
 820
 821 2019-07-17  Tom Tromey  <tom@tromey.com>
 822
 823         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 824         * tui/tui-windata.c (tui_display_data_from): Remove.
 825         (tui_data_window::refresh_all): Update.
 826
 827 2019-07-17  Tom Tromey  <tom@tromey.com>
 828
 829         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 830         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 831         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 832         tui_display_registers_from_line.
 833         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 834         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 835         "force_display" parameter.
 836
 837 2019-07-17  Tom Tromey  <tom@tromey.com>
 838
 839         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 840         declare.
 841         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 842         Rename from tui_first_reg_element_no_inline.
 843         (tui_display_reg_element_at_line)
 844         (tui_display_registers_from_line): Update.
 845         * tui/tui-data.h (struct tui_data_window)
 846         <first_reg_element_no_inline>: New method.
 847
 848 2019-07-17  Tom Tromey  <tom@tromey.com>
 849
 850         * tui/tui-windata.c (tui_display_data_from)
 851         (tui_data_window::do_scroll_vertical): Update.
 852         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 853         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 854         Rename from tui_line_from_reg_element_no.
 855         (tui_display_registers_from_line): Update.
 856         * tui/tui-data.h (struct tui_data_window)
 857         <line_from_reg_element_no>: New method.
 858
 859 2019-07-17  Tom Tromey  <tom@tromey.com>
 860
 861         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 862         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 863         tui_last_regs_line_no.
 864         (tui_display_reg_element_at_line)
 865         (tui_display_registers_from_line): Update.
 866         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 867         method.
 868
 869 2019-07-17  Tom Tromey  <tom@tromey.com>
 870
 871         PR tui/24722:
 872         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 873         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 874         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 875         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 876         (tui_update_breakpoint_info): Likewise.
 877         * tui/tui-hooks.c (tui_event_create_breakpoint)
 878         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 879         Update.
 880
 881 2019-07-17  Tom Tromey  <tom@tromey.com>
 882
 883         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 884
 885 2019-07-17  Tom Tromey  <tom@tromey.com>
 886
 887         * tui/tui-winsource.c (tui_update_source_window_as_is)
 888         (tui_update_source_windows_with_addr): Update.
 889         * tui/tui-source.h (tui_set_source_content)
 890         (tui_show_symtab_source): Add "win_info" parameter.
 891         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 892         parameter.
 893         (tui_show_symtab_source): Likewise.
 894
 895 2019-07-17  Tom Tromey  <tom@tromey.com>
 896
 897         * tui/tui-wingeneral.c
 898         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 899
 900 2019-07-17  Tom Tromey  <tom@tromey.com>
 901
 902         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 903         (struct tui_cmd_window) <can_scroll>: New method.
 904         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 905         method.
 906
 907 2019-07-17  Tom Tromey  <tromey@adacore.com>
 908
 909         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 910         do_field_signed>: Rename.  Change type of "value".
 911         * ui-out.c (ui_out::field_signed): Rename from field_int.
 912         Change type of "value".
 913         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 914         type of "value".
 915         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 916         do_field_int.  Change type of "value".
 917         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 918         do_field_int.  Change type of "value".
 919         * tracepoint.c (trace_status_mi, tfind_1)
 920         (print_one_static_tracepoint_marker): Update.
 921         * thread.c (print_thread_info_1, print_selected_thread_frame):
 922         Update.
 923         * stack.c (print_frame, print_frame_info): Update.
 924         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 925         Update.
 926         * source.c (print_source_lines_base): Update.
 927         * skip.c (info_skip_command): Update.
 928         * record-btrace.c (btrace_ui_out_decode_error)
 929         (btrace_call_history_src_line): Update.
 930         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 931         Update.
 932         * progspace.c (print_program_space): Update.
 933         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 934         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 935         do_field_int.  Change type of "value".
 936         * mi/mi-out.c (mi_ui_out::do_table_begin)
 937         (mi_ui_out::do_table_header): Update.
 938         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 939         type of "value".
 940         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 941         (mi_cmd_data_list_changed_registers, output_register)
 942         (mi_cmd_data_read_memory, mi_load_progress)
 943         (mi_cmd_trace_frame_collected): Update.
 944         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 945         Update.
 946         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 947         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 948         (mi_cmd_var_list_children, varobj_update_one): Update.
 949         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 950         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 951         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 952         * inferior.c (print_inferior): Update.
 953         * gdb_bfd.c (print_one_bfd): Update.
 954         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 955         Update.
 956         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 957         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 958         do_field_int.  Change type of "value".
 959         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 960         do_field_int.  Change type of "value".
 961         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 962         (print_one_breakpoint_location, print_it_catch_fork)
 963         (print_one_catch_fork, print_it_catch_vfork)
 964         (print_one_catch_vfork, print_it_catch_solib)
 965         (print_it_catch_exec, print_it_ranged_breakpoint)
 966         (print_mention_watchpoint, print_mention_masked_watchpoint)
 967         (bkpt_print_it, update_static_tracepoint): Update.
 968         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 969         * break-catch-syscall.c (print_it_catch_syscall): Update.
 970         * ada-tasks.c (print_ada_task_info): Update.
 971         * ada-lang.c (print_it_exception, print_mention_exception):
 972         Update.
 973
 974 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 975
 976         PR breakpoints/24541
 977         * gdbarch.c: Regenerate.
 978         * gdbarch.h: Regenerate.
 979         * gdbarch.sh: Adjust return type and parameter types for
 980         'stap_adjust_register'.
 981         (i386_stap_adjust_register): Adjust signature and return new
 982         register name.
 983         * stap-probe.c (stap_parse_register_operand): Adjust use of
 984         'gdbarch_stap_adjust_register'.
 985
 986 2019-07-17  Tom Tromey  <tromey@adacore.com>
 987
 988         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 989         declare VEC.
 990         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 991         std::vector.
 992         (struct s390_process_info): Add initializers.
 993         (s390_add_process): Use new.
 994         (s390_linux_nat_target::low_forget_process): Use delete.
 995         (s390_linux_nat_target::low_new_fork)
 996         (s390_linux_nat_target::stopped_by_watchpoint)
 997         (s390_linux_nat_target::low_prepare_to_resume)
 998         (s390_linux_nat_target::insert_watchpoint)
 999         (s390_linux_nat_target::insert_hw_breakpoint)
1000         (s390_linux_nat_target::remove_watchpoint)
1001         (s390_linux_nat_target::remove_hw_breakpoint): Update.
1002
1003 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1004
1005         * aarch64-fbsd-nat.c: Include regcache.h.
1006         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1007         argument.
1008         (aarch64_fbsd_nat_target::fetch_registers)
1009         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1010         variable.
1011         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1012
1013 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1014
1015         * fbsd-nat.c: Include gdbarch.h.
1016
1017 2019-07-15  Tom Tromey  <tromey@adacore.com>
1018
1019         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1020
1021 2019-07-15  Tom Tromey  <tromey@adacore.com>
1022
1023         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1024         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1025         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1026         * cli-out.c (cli_ui_out::do_field_int): New method.
1027         * ui-out.c (ui_out::field_unsigned): New method.
1028         * symfile.c (generic_load): Use field_unsigned.
1029         (print_transfer_performance): Likewise.
1030         * record-btrace.c (ui_out_field_uint): Remove.
1031         (btrace_call_history_insn_range, btrace_call_history): Use
1032         field_unsigned.
1033         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
1034         field_unsigned.
1035         * ui-out.h (class ui_out) <field_unsigned>: New method.
1036         <do_field_unsigned>: Likewise.
1037
1038 2019-07-15  Tom Tromey  <tromey@adacore.com>
1039
1040         * mi/mi-main.c (list_available_thread_groups): Use field_string.
1041         * mi/mi-interp.c (mi_memory_changed): Use field_string.
1042         * target.c (flash_erase_command): Use field_string.
1043         * infrun.c (print_signal_received_reason): Use field_string.
1044         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
1045         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
1046         field_string.
1047         * ada-tasks.c (print_ada_task_info): Use field_string.
1048
1049 2019-07-15  Tom Tromey  <tromey@adacore.com>
1050
1051         * target.c (flash_erase_command): Use field_core_addr.
1052         * symfile.c (generic_load): Use field_core_addr.
1053         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1054         Use field_core_addr.
1055         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
1056         field_core_addr.
1057
1058 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1059
1060         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1061         value if its desired type is smaller than a CORE_ADDR and signed.
1062
1063 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1064
1065         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1066         of changes to field names, and use new is_reference field to
1067         decide if a property is a reference or not.
1068         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1069         field.
1070         (struct dwarf2_property_baton): Update header comment, rename
1071         'referenced_type' to 'property_type' and update comments.
1072         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1073         default property type, store in property baton, update to take
1074         accound of renamed field.
1075         (read_func_scope): Update call to attr_to_dynamic_prop.
1076         (read_array_type): Likewise.
1077         (dwarf2_per_cu_addr_sized_int_type): New function.
1078         (read_subrange_index_type): Move type finding code to
1079         dwarf2_per_cu_addr_sized_int_type.
1080         (read_subrange_type): Update calls to attr_to_dynamic_prop.
1081         (dwarf2_per_cu_addr_type): New function.
1082         (set_die_type): Update calls to attr_to_dynamic_prop.
1083
1084 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1085
1086         * dwarf2read.c (read_subrange_index_type): New function.
1087         (read_subrange_type): Move code into new function and call it.
1088         * gdbtypes.c (create_range_type): Add some asserts.
1089
1090 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1091
1092         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1093         update return statements.
1094         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1095         declaration, and update comment to match.
1096         * gdbtypes.c (resolve_dynamic_array): Update call to
1097         dwarf2_evaluate_property to match new return type.
1098
1099 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1100
1101         * valarith.c (value_subscripted_rvalue): Change lowerbound
1102         parameter type from int to LONGEST.
1103         * value.h (value_subscripted_rvalue): Likewise in declaration.
1104
1105 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1106
1107         * cli/cli-utils.c (info_print_command_completer): New function.
1108         * cli/cli-utils.h: Add 'completer.h' include, and forward
1109         declaration for 'struct cmd_list_element'.
1110         (info_print_command_completer): Declare.
1111         * stack.c (_initialize_stack): Add completer for 'info locals' and
1112         'info args'.
1113         * symtab.c (_initialize_symtab): Add completer for 'info
1114         variables' and 'info functions'.
1115         * NEWS: Mention completion for additional info commands.
1116
1117 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1118
1119         * cli/cli-utils.c (extract_info_print_args): Delete.
1120         (extract_arg_maybe_quoted): Delete.
1121         (info_print_options_defs): New variable.
1122         (make_info_print_options_def_group): New function.
1123         (extract_info_print_options): Define new function.
1124         * cli/cli-utils.h (extract_info_print_args): Delete.
1125         (struct info_print_options): New structure.
1126         (extract_info_print_options): Declare new function.
1127         * stack.c (info_locals_command): Update to use new
1128         extract_info_print_options, also add a header comment.
1129         (info_args_command): Likewise.
1130         * symtab.c (info_variables_command): Likewise.
1131         (info_functions_command): Likewise.
1132
1133 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1134
1135         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1136         to extract string arguments.
1137         * common/common-utils.c (extract_string_maybe_quoted): New function.
1138         * common/common-utils.h (extract_string_maybe_quoted): Declare.
1139
1140 2019-07-11  Tom Tromey  <tromey@adacore.com>
1141
1142         * main.c (get_init_files): Use GDBINIT, not gdbinit.
1143         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1144         * top.h (gdbinit): Don't declare.
1145         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1146         into...
1147         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
1148         * top.c (gdb_init): Don't call init_cli_cmds.
1149         (gdbinit): Remove.
1150         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1151
1152 2019-07-11  Tom Tromey  <tromey@adacore.com>
1153
1154         * python/py-inferior.c (add_thread_object): Don't use thread_obj
1155         after it has been moved.
1156
1157 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1158
1159         * valops.c (value_must_coerce_to_target): Change return type to
1160         bool.
1161         * value.h (value_must_coerce_to_target): Likewise.
1162
1163 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
1164
1165         * breakpoint.c (is_hardware_watchpoint): Remove
1166         forward-declaration.
1167         (is_masked_watchpoint): Change return type to bool.
1168         (is_tracepoint): Likewise.
1169         (is_breakpoint): Likewise.
1170         (is_hardware_watchpoint): Likewise.
1171         (is_watchpoint): Likewise.
1172         (is_no_memory_software_watchpoint): Likewise.
1173         (is_catchpoint): Likewise.
1174         (breakpoint_1): Make FILTER parameter's return type bool.
1175         is_masked_watchpoint): Change return type to bool.
1176         (save_breakpoints): Make FILTER parameter's return type bool.
1177         * breakpoint.h (is_breakpoint): Change return type to bool.
1178         (is_watchpoint): Likewise.
1179         (is_catchpoint): Likewise.
1180         (is_tracepoint): Likewise.
1181
1182 2019-07-10  Tom Tromey  <tom@tromey.com>
1183
1184         * defs.h: Don't include gdbarch.h.
1185         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1186         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1187         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1188         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1189         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1190         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1191         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1192         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1193         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1194         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1195         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1196         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1197         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1198         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1199         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1200         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1201         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1202         record-btrace.c, record.h, regcache-dump.c, regcache.h,
1203         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1204         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1205         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1206         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1207         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1208         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1209         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1210         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1211         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1212
1213 2019-07-10  Tom Tromey  <tromey@adacore.com>
1214
1215         * ada-lang.h (is_ada_exception_catchpoint): Declare.
1216         * breakpoint.c (init_ada_exception_breakpoint): Register as
1217         bp_catchpoint.
1218         (print_one_breakpoint_location, print_one_breakpoint): Use
1219         is_ada_exception_catchpoint.
1220         * ada-lang.c (class ada_catchpoint_location): Pass
1221         bp_loc_software_breakpoint to bp_location constructor.
1222         (is_ada_exception_catchpoint): New function.
1223
1224 2019-07-10  Tom Tromey  <tromey@adacore.com>
1225
1226         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
1227         VEC.
1228         (struct arm_exidx_entry): New method operator<.
1229         (struct arm_exidx_data) <section_maps>: Change type.
1230         (arm_exidx_data_free): Remove.
1231         (arm_exidx_data_key): Change type.  Move lower.
1232         (arm_exidx_new_objfile): Update.
1233         (arm_compare_exidx_entries): Remove.
1234         (arm_find_exidx_entry, _initialize_arm_tdep)
1235
1236 2019-07-10  Tom Tromey  <tromey@adacore.com>
1237
1238         * solib-spu.c (ocl_program_data_key): Change type.
1239         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1240         Update.
1241
1242 2019-07-10  Tom Tromey  <tromey@adacore.com>
1243
1244         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1245         (struct solib_aix_inferior_data) <library_list>: Change type.
1246         (solib_aix_inferior_data_handle): Change type.
1247         (get_solib_aix_inferior_data): Update.
1248         (solib_aix_free_library_list): Remove.
1249         (library_list_start_library): Update.
1250         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1251         return type.
1252         (solib_aix_get_library_list)
1253         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1254         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1255
1256 2019-07-10  Tom Tromey  <tromey@adacore.com>
1257
1258         * solib-dsbt.c (struct dsbt_info): Add initializers.
1259         (solib_dsbt_pspace_data): Change type.
1260         (dsbt_pspace_data_cleanup): Remove.
1261         (get_dsbt_info, _initialize_dsbt_solib): Update.
1262
1263 2019-07-10  Tom Tromey  <tromey@adacore.com>
1264
1265         * spu-tdep.c (spu_overlay_data): Change type.
1266         (spu_get_overlay_table, spu_overlay_new_objfile)
1267         (_initialize_spu_tdep): Update.
1268
1269 2019-07-10  Tom Tromey  <tromey@adacore.com>
1270
1271         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1272         destructor.
1273         (dbx_objfile_data_key): Change type and declare later.
1274         (DBX_SYMFILE_INFO): Rewrite.
1275         * dbxread.c (dbx_objfile_data_key): Change type.
1276         (dbx_symfile_init): Update.
1277         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1278         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1279         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1280
1281 2019-07-10  Tom Tromey  <tromey@adacore.com>
1282
1283         * jit.c (jit_program_space_key): Change type.  Move lower.
1284         (get_jit_program_space_data): Update.
1285         (jit_program_space_data_cleanup): Remove.
1286         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1287         Update.
1288         (struct jit_program_space_data): Add initializers.
1289
1290 2019-07-10  Tom Tromey  <tromey@adacore.com>
1291
1292         * solib-darwin.c (struct darwin_info): Add initializers.
1293         (solib_darwin_pspace_data): Change type.
1294         (darwin_pspace_data_cleanup): Remove.
1295         (get_darwin_info, _initialize_darwin_solib): Update.
1296
1297 2019-07-10  Tom Tromey  <tromey@adacore.com>
1298
1299         * remote-sim.c (struct sim_inferior_data): Add initializers,
1300         constructor, and destructor.
1301         (sim_inferior_data_key): Change type.  Move lower.
1302         (check_for_duplicate_sim_descriptor): Update.
1303         (get_sim_inferior_data): Use new.  Update.
1304         (~sim_inferior_data_cleanup): Rename from
1305         sim_inferior_data_cleanup.  Simplify.
1306         (gdbsim_close_inferior, simulator_command)
1307         (sim_command_completer, _initialize_remote_sim): Update.
1308         (next_pid, INITIAL_PID): Move earlier.
1309
1310 2019-07-10  Tom Tromey  <tromey@adacore.com>
1311
1312         * python/python-internal.h (create_thread_object): Return
1313         gdbpy_ref.
1314         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1315         * python/py-inferior.c (struct threadlist_entry): Add
1316         constructor.
1317         <thread_obj>: Now a gdbpy_ref.
1318         (thread_to_thread_object): Update.
1319         (add_thread_object): Use new.
1320         (delete_thread_object): Use delete.
1321         (infpy_threads): Update.
1322         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1323         GIL.
1324
1325 2019-07-10  Tom Tromey  <tromey@adacore.com>
1326
1327         * valops.c (value_cast): Specialize error message for Ada.
1328
1329 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1330
1331         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1332
1333 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1334
1335         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1336         bpstat_should_step): Return bool, adjust comments.
1337         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1338         bpstat_should_step): Likewise.
1339
1340 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1341
1342         * features/Makefile: Use feature target descriptions for Arm.
1343         * features/arm/arm-core.c: Generate new file.
1344         * features/arm/arm-fpa.c: Likewise.
1345         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1346         * features/arm/arm-m-profile.c: Likewise.
1347         * features/arm/arm-vfpv2.c: Likewise.
1348         * features/arm/arm-vfpv3.c: Likewise.
1349         * features/arm/xscale-iwmmxt.c: Likewise.
1350         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1351
1352 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1353
1354         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1355         ptrace earlier.
1356
1357 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1358
1359         * features/aarch64-pauth.c: Regenerate.
1360
1361 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1362
1363         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1364         bool.
1365         (bpstat_what): Use false instead of 0.
1366
1367 2019-07-09  Pedro Alves  <palves@redhat.com>
1368
1369         * break-catch-throw.c (is_exception_catchpoint): New.
1370         * breakpoint.c (print_one_breakpoint_location): New parameter
1371         'raw_loc'.  Handle it.  Use
1372         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1373         looking at the breakpoint's type.
1374         (print_one_breakpoint): If handling "maint info breakpoints", also
1375         print locations of exception catchpoints.
1376         * breakpoint.h (is_exception_catchpoint): Declare.
1377
1378 2019-07-09  Pedro Alves  <palves@redhat.com>
1379
1380         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1381         "addr" field.
1382         (allocate_location_exception_catchpoint): New.
1383         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1384         (initialize_throw_catchpoint_ops): Install
1385         allocate_location_exception_catchpoint as allocate_location
1386         method.
1387         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1388         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1389         bp_loc_other.
1390         (breakpoint_address_is_meaningful): Delete.
1391         (bl_address_is_meaningful): New.
1392         (breakpoint_locations_match): Adjust comment.
1393         (bp_location_from_bp_type): New, factored out of...
1394         (bp_location::bp_location(breakpoint *)): ... this.
1395         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1396         factored out of...
1397         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1398         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1399         breakpoint_address_is_meaningful.
1400         (bp_locations_compare): Adjust comment.
1401         (update_global_location_list): Use bl_address_is_meaningful
1402         instead of breakpoint_address_is_meaningful.
1403         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1404         explicit.
1405         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1406         * python/py-breakpoint.c (bppy_get_location): No longer check
1407         whether location is null.
1408
1409 2019-07-09  Pedro Alves  <palves@redhat.com>
1410
1411         PR c++/15468
1412         * breakpoint.c (print_one_breakpoint_location): Remove
1413         single-location assert.
1414
1415 2019-07-09  Tom Tromey  <tom@tromey.com>
1416
1417         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1418         * configure: Rebuild.
1419         * configure.ac: Change common to gdbsupport.
1420         * gdbsupport: Rename from common.
1421         * acinclude.m4: Change common to gdbsupport.
1422         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1423         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1424         gdbsupport.
1425         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1426         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1427         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1428         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1429         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1430         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1431         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1432         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1433         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1434         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1435         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1436         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1437         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1438         coff-pe-read.c, command.h, compile/compile-c-support.c,
1439         compile/compile-c.h, compile/compile-cplus-symbols.c,
1440         compile/compile-cplus-types.c, compile/compile-cplus.h,
1441         compile/compile-loc2c.c, compile/compile.c, completer.c,
1442         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1443         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1444         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1445         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1446         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1447         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1448         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1449         features/aarch64-core.c, features/aarch64-fpu.c,
1450         features/aarch64-pauth.c, features/aarch64-sve.c,
1451         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1452         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1453         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1454         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1455         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1456         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1457         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1458         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1459         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1460         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1461         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1462         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1463         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1464         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1465         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1466         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1467         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1468         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1469         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1470         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1471         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1472         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1473         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1474         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1475         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1476         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1477         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1478         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1479         minsyms.c, mips-linux-tdep.c, namespace.h,
1480         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1481         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1482         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1483         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1484         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1485         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1486         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1487         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1488         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1489         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1490         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1491         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1492         procfs.c, producer.c, progspace.h, psymtab.h,
1493         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1494         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1495         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1496         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1497         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1498         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1499         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1500         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1501         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1502         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1503         target-memory.c, target.c, target.h, target/waitstatus.c,
1504         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1505         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1506         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1507         unittests/array-view-selftests.c,
1508         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1509         unittests/common-utils-selftests.c,
1510         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1511         unittests/format_pieces-selftests.c,
1512         unittests/function-view-selftests.c,
1513         unittests/lookup_name_info-selftests.c,
1514         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1515         unittests/mkdir-recursive-selftests.c,
1516         unittests/observable-selftests.c,
1517         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1518         unittests/parse-connection-spec-selftests.c,
1519         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1520         unittests/scoped_fd-selftests.c,
1521         unittests/scoped_mmap-selftests.c,
1522         unittests/scoped_restore-selftests.c,
1523         unittests/string_view-selftests.c, unittests/style-selftests.c,
1524         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1525         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1526         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1527         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1528         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1529         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1530
1531 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1532
1533         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1534         bool value.
1535         (decode_digits_ordinary): Set explicit_line field in sal.
1536         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1537         symtab_and_line that was set on an explicit line number in
1538         assembler code.  Do always update the recorded symtab and line if
1539         we do skip the prologue.
1540
1541 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1542
1543         * breakpoint.c (set_breakpoint_location_function): Remove
1544         explicit_loc parameter.
1545         (momentary_breakpoint_from_master): Update call to
1546         set_breakpoint_location_function.
1547         (add_location_to_breakpoint): Likewise.
1548
1549 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1550
1551         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1552         required features based on default bfd type when no specific bfd
1553         is present.
1554
1555 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1556
1557         * NEWS: Mention that GDB printf and eval commands can now print
1558         C-style and Ada-style convenience var strings without
1559         calling the inferior.
1560         * printcmd.c (printf_c_string): Locally print GDB internal var
1561         instead of transiting via the inferior.
1562         (printf_wide_c_string): Likewise.
1563
1564 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1565
1566         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1567
1568 2019-07-04  Tom Tromey  <tom@tromey.com>
1569
1570         PR tui/24724:
1571         * tui/tui-winsource.c (tui_clear_source_content): Update.
1572         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1573         (tui_update_breakpoint_info): Update.
1574         (tui_set_exec_info_content): Update.
1575         * tui/tui-source.c (tui_set_source_content_nil): Update.
1576         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1577         has_break.
1578         * tui/tui-data.h (enum tui_bp_flag): New.
1579         (tui_bp_flags): New enum flags type.
1580         (struct tui_source_element) <break_mode>: Change type.  Rename
1581         from has_break.
1582         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1583         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1584         constants.
1585         * tui/tui-winsource.h: Fix comment.
1586
1587 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1588
1589         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1590         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1591         (store_fpregs_to_thread)
1592         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1593         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1594         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1595         (IWMMXT_REGS_SIZE): Add define.
1596         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1597         (fetch_vfp_regs, store_vfp_regs)
1598         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1599         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1600
1601 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1602
1603         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1604         defines.
1605         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1606         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1607         (ARM_INT_REGISTER_SIZE): ...to this.
1608         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1609         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1610         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1611         (arm_linux_collect_gregset, supply_nwfpe_register)
1612         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1613         defines.
1614         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1615         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1616         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1617         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1618         (arm_return_in_memory, arm_store_return_value)
1619         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1620         (arm_record_ld_st_multiple): Likewise.
1621         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1622         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1623
1624 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1625
1626         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1627         AARCH64_DISPLACED_MODIFIED_INSNS.
1628         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1629         (aarch64_displaced_step_copy_insn): Likewise.
1630         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1631         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1632         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1633         ARM_DISPLACED_MODIFIED_INSNS.
1634         * arm-tdep.c (arm_gdbarch_init): Likewise.
1635         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1636         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1637         (struct arm_displaced_step_closure): Use
1638         ARM_DISPLACED_MODIFIED_INSNS.
1639
1640 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1641
1642         * features/Makefile: Remove unused xml files.
1643         * features/aarch64.xml: Remove.
1644         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1645         * features/i386/amd64-avx-avx512.xml: Remove.
1646         * features/i386/amd64-avx-linux.xml: Remove.
1647         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1648         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1649         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1650         * features/i386/amd64-avx-mpx.xml: Remove.
1651         * features/i386/amd64-avx.xml: Remove.
1652         * features/i386/amd64-linux.xml: Remove.
1653         * features/i386/amd64-mpx-linux.xml: Remove.
1654         * features/i386/amd64-mpx.xml: Remove.
1655         * features/i386/amd64.xml: Remove.
1656         * features/i386/i386-avx-avx512-linux.xml: Remove.
1657         * features/i386/i386-avx-avx512.xml: Remove.
1658         * features/i386/i386-avx-linux.xml: Remove.
1659         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1660         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1661         * features/i386/i386-avx-mpx-linux.xml: Remove.
1662         * features/i386/i386-avx-mpx.xml: Remove.
1663         * features/i386/i386-avx.xml: Remove.
1664         * features/i386/i386-linux.xml: Remove.
1665         * features/i386/i386-mmx-linux.xml: Remove.
1666         * features/i386/i386-mmx.xml: Remove.
1667         * features/i386/i386-mpx-linux.xml: Remove.
1668         * features/i386/i386-mpx.xml: Remove.
1669         * features/i386/i386.xml: Remove.
1670         * features/i386/x32-avx-avx512-linux.xml: Remove.
1671         * features/i386/x32-avx-linux.xml: Remove.
1672         * features/i386/x32-linux.xml: Remove.
1673
1674 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1675
1676         * regformats/aarch64.dat: Remove.
1677         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1678         * regformats/i386/amd64-avx-linux.dat: Remove.
1679         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1680         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1681         * regformats/i386/amd64-linux.dat: Remove.
1682         * regformats/i386/amd64-mpx-linux.dat: Remove.
1683         * regformats/i386/amd64.dat: Remove.
1684         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1685         * regformats/i386/i386-avx-linux.dat: Remove.
1686         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1687         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1688         * regformats/i386/i386-linux.dat: Remove.
1689         * regformats/i386/i386-mmx-linux.dat: Remove.
1690         * regformats/i386/i386-mpx-linux.dat: Remove.
1691         * regformats/i386/i386.dat: Remove.
1692         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1693         * regformats/i386/x32-avx-linux.dat: Remove.
1694         * regformats/i386/x32-linux.dat: Remove.
1695
1696 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1697
1698         * aarch64-tdep.c: Remove xml self tests.
1699         * amd64-linux-tdep.c: Likewise.
1700         * amd64-tdep.c: Likewise.
1701         * i386-linux-tdep.c: Likewise.
1702         * i386-tdep.c: Likewise.
1703
1704 2019-07-03  Pedro Alves  <palves@redhat.com>
1705
1706         PR cli/24732
1707         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1708         (pipe_cmd_option_defs): New.
1709         (make_pipe_cmd_options_def_group): New.
1710         (pipe_command): Use gdb::option::process_options.
1711         (pipe_command_completer): New function.
1712         (_initialize_cli_cmds): Install completer for "pipe" command.
1713
1714 2019-07-03  Pedro Alves  <palves@redhat.com>
1715
1716         * cli/cli-option.c (union option_value) <string>: New field.
1717         (struct option_def_and_value): Add ctor, move ctor, dtor and
1718         use DISABLE_COPY_AND_ASSIGN.
1719         (option_def_and_value::clear_value): New.
1720         (parse_option, save_option_value_in_ctx, get_val_type_str)
1721         (add_setshow_cmds_for_options): Handle var_string.
1722         * cli-option.h (union option_def::var_address) <string>: New
1723         field.
1724         (struct string_option_def): New.
1725         * maint-test-options.c (struct test_options_opts): Add default
1726         ctor and use DISABLE_COPY_AND_ASSIGN.
1727         <string_opt>: New field.
1728         (test_options_opts::~test_options_opts): New.
1729         (test_options_opts::dump): Also dump "-string".
1730         (test_options_option_defs): Install "string.
1731
1732 2019-07-03  Pedro Alves  <palves@redhat.com>
1733
1734         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1735         option_value with a null enumeration.
1736         (complete_options): Save the option values in the context.
1737         (save_option_value_in_ctx): New, factored out from ...
1738         (process_options): ... here.
1739         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1740         of the function.
1741         * maint-test-options.c (test_options_opts::dump): New, factored
1742         out from ...
1743         (maintenance_test_options_command_mode): ... here.
1744         (maintenance_test_options_command_completion_result): Delete.
1745         (maintenance_test_options_command_completion_text): Update
1746         comment.
1747         (maintenance_show_test_options_completion_result): Change
1748         prototype.  Just print
1749         maintenance_test_options_command_completion_text.
1750         (save_completion_result): New.
1751         (maintenance_test_options_completer_mode): Pass options context to
1752         complete_options, and then save a dump.
1753         (_initialize_maint_test_options): Use add_cmd to install "maint
1754         show test-options-completion-result".
1755
1756 2019-07-03  Pedro Alves  <palves@redhat.com>
1757
1758         * NEWS (New commands): Mention "with" and "maint with".
1759         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1760         (with_command, with_command_completer): New.
1761         (pipe_command): Adjust to new repeat_previous
1762         interface.
1763         (_initialize_cli_cmds): Install the "with" command and its "w"
1764         alias.
1765         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1766         declarations.
1767         * cli/cli-setshow.c (parse_cli_var_uinteger)
1768         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1769         argument strings for all var_types.
1770         (get_setshow_command_value_string): New, factored out from ...
1771         (do_show_command): ... this.
1772         * cli/cli-setshow.h: Include <string>.
1773         (get_setshow_command_value_string): Declare.
1774         * command.h (repeat_previous): Now returns const char *.  Adjust
1775         comment.
1776         * maint.c: Include "cli/cli-cmds.h".
1777         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1778         (_initialize_maint_cmds): Register the "maintenance with" command.
1779         * top.c (repeat_previous): Move bits from pipe_command here:
1780         Return the saved command line, if any; error out if there's no
1781         command to relaunch.
1782
1783 2019-07-03  Pedro Alves  <palves@redhat.com>
1784
1785         * NEWS (New commands): Mention "maint set/show test-settings"
1786         instead of "maint test-settings".
1787         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1788         (maintenance_test_settings_set_list): Rename to ...
1789         (maintenance_set_test_settings_list): ... this.
1790         (maintenance_test_settings_show_list): Rename to  ...
1791         (maintenance_show_test_settings_list): ... this.
1792         (maintenance_test_settings_cmd): Delete.
1793         (maintenance_test_settings_set_cmd): ...
1794         (maintenance_set_test_settings_cmd): ... this.
1795         (maintenance_test_settings_show_cmd): ...
1796         (maintenance_show_test_settings_cmd): ... this.
1797         (maintenance_test_settings_show_value_cmd):
1798         (maintenance_show_test_settings_value_cmd): ... this.
1799         (_initialize_maint_test_settings): No longer install the "maint
1800         test-settings" prefix command.  Rename "maint test-settings set"
1801         to "maint set test-settings", and "maint test-settings show" to
1802         "maint show test-settings".  Adjust all subcommands.
1803
1804 2019-07-03  Pedro Alves  <palves@redhat.com>
1805
1806         * maint-test-settings.c: Fix file's intro comment.  Replace all
1807         references to "test-options" with references to "test-settings",
1808         in comments.
1809
1810 2019-07-03  Pedro Alves  <palves@redhat.com>
1811
1812         * maint-test-settings.c (maintenance_test_settings_xxx)
1813         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1814         New.
1815         (maintenance_test_settings_enums): Use them.
1816         (maintenance_test_settings_enum): Default to
1817         maintenance_test_settings_xxx.
1818         (_initialize_maint_test_settings): Initialize
1819         MAINTENANCE_TEST_SETTINGS_FILENAME.
1820
1821 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1822
1823         * breakpoint.h (remove_breakpoints_inf): Change return type to
1824         void, move function documentation here.
1825         * breakpoint.c (remove_breakpoints_inf): Change return type to
1826         void, move function documentation to header.
1827
1828 2019-07-02  Pedro Alves  <palves@redhat.com>
1829
1830         * NEWS (Completion improvements): Mention "info threads".
1831         * thread.c (struct info_threads_opts, info_threads_option_defs)
1832         (make_info_threads_options_def_group): New.
1833         (info_threads_command): Use gdb::option::process_options.
1834         (info_threads_command_completer): New.
1835         (_initialize_thread): Use gdb::option::build_help to build the
1836         help text for "info threads".
1837
1838 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1839
1840         * defs.h (generic_load): Move from here...
1841         * symfile.h (generic_load): ... to here.  Rename name parameter
1842         to args.
1843         * symfile.c (generic_load): Add comment.
1844
1845 2019-07-01  Tom Tromey  <tromey@adacore.com>
1846
1847         * dwarf2read.c
1848         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1849         declaration of without_params.  Fix formatting.
1850
1851 2019-07-01  Tom Tromey  <tromey@adacore.com>
1852
1853         * ada-exp.y (find_primitive_type): Update.
1854         * ada-lang.h (ada_lookup_symbol): Update.
1855         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1856         parameter.
1857         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1858
1859 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1860
1861         PR breakpoints/24541
1862         * gdbarch.c: Regenerate.
1863         * gdbarch.h: Regenerate.
1864         * gdbarch.sh: Add 'stap_adjust_register'.
1865         * i386-tdep.c: Include '<unordered_set>'.
1866         (i386_stap_adjust_register): New function.
1867         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1868         * stap-probe.c (stap_parse_register_operand): Call
1869         'gdbarch_stap_adjust_register'.
1870
1871 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1872
1873         PR python/24742
1874         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1875         * python/python.c (do_start_initialization): Use 'xmalloc'
1876         instead of 'PyMem_Malloc'.
1877
1878 2019-06-28  Tom Tromey  <tromey@adacore.com>
1879
1880         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1881         for Ada.
1882
1883 2019-06-27  Tom Tromey  <tromey@adacore.com>
1884
1885         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1886         objfile_key.
1887         (arm_find_mapping_symbol, arm_record_special_symbol)
1888         (_initialize_arm_tdep): Update.
1889         (arm_objfile_data_free): Remove.
1890
1891 2019-06-27  Tom Tromey  <tromey@adacore.com>
1892
1893         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1894         to cp_print_static_field.
1895
1896 2019-06-26  Tom Tromey  <tromey@adacore.com>
1897
1898         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1899         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1900         declare.
1901
1902 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1903
1904         * features/aarch64-core.c (create_feature_aarch64_core):
1905         Regenerate.
1906         * features/aarch64-core.xml: Add cpsr flags.
1907
1908 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1909
1910         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1911         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1912
1913 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1914
1915         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1916         field.
1917         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1918         use.
1919         (arm_record_special_symbol): Don't insert new symbol in sorted
1920         position, push it at the end.
1921
1922 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1923
1924         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1925         (arm_mapping_symbol_s): Remove.
1926         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1927         (arm_mapping_symbol_vec): New typedef.
1928         (struct arm_per_objfile): Add constructor.
1929         <section_maps>: Change type to
1930         std::unique_ptr<arm_mapping_symbol_vec[]>.
1931         (arm_compare_mapping_symbols): Remove.
1932         (arm_find_mapping_symbol): Adjust to section_maps type change.
1933         (arm_objfile_data_free): Call delete on arm_per_objfile.
1934         (arm_record_special_symbol): Adjust to section_maps type change.
1935         Allocate arm_per_objfile with new.
1936
1937 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1938
1939         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1940         with the command prefix.
1941
1942 2019-06-25  Tom Tromey  <tom@tromey.com>
1943
1944         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1945         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1946
1947 2019-06-25  Tom Tromey  <tom@tromey.com>
1948
1949         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1950         type.
1951         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1952         protected.
1953
1954 2019-06-25  Tom Tromey  <tom@tromey.com>
1955
1956         * tui/tui-winsource.c
1957         (tui_source_window_base::set_is_exec_point_at): Add check against
1958         LOA_ADDRESS.
1959
1960 2019-06-25  Tom Tromey  <tom@tromey.com>
1961
1962         * tui/tui-source.c (tui_set_source_content): Don't check before
1963         xfree.
1964         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1965
1966 2019-06-25  Tom Tromey  <tom@tromey.com>
1967
1968         * tui/tui-winsource.h (tui_update_source_window_as_is)
1969         (tui_alloc_source_buffer, tui_line_is_displayed)
1970         (tui_addr_is_displayed): Change type of win_info.
1971         * tui/tui-winsource.c (tui_update_source_window_as_is)
1972         (tui_clear_source_content, tui_show_source_line)
1973         (tui_show_source_content, tui_source_window_base::refill)
1974         (tui_source_window_base::set_is_exec_point_at)
1975         (tui_source_window_base::set_is_exec_point_at)
1976         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1977         (tui_alloc_source_buffer, tui_line_is_displayed)
1978         (tui_addr_is_displayed): Change type of win_info.  Update.
1979         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1980         (tui_source_window_base::do_make_visible_with_new_height):
1981         Update.
1982         * tui/tui-source.c (tui_set_source_content)
1983         (tui_set_source_content_nil)
1984         (tui_source_window::do_scroll_vertical): Update.
1985         * tui/tui-layout.c (show_layout): Update.
1986         * tui/tui-disasm.c (tui_set_disassem_content)
1987         (tui_disasm_window::do_scroll_vertical): Update.
1988         * tui/tui-data.h (tui_win_content): Remove.
1989         (struct tui_gen_win_info) <content, content_size>: Remove.
1990         (struct tui_source_element): Add initializers and destructor.
1991         (union tui_which_element, struct tui_win_element): Remove.
1992         (struct tui_source_window_base) <content>: New field.
1993         (struct tui_data_window): Remove destructor.
1994         (tui_alloc_content, tui_free_win_content)
1995         (tui_free_all_source_wins_content): Don't declare.
1996         * tui/tui-data.c (tui_initialize_static_data): Update.
1997         (init_content_element, tui_alloc_content): Remove.
1998         (~tui_gen_win_info): Update.
1999         (~tui_data_window, tui_free_all_source_wins_content)
2000         (tui_free_win_content, free_content, free_content_elements):
2001         Remove.
2002
2003 2019-06-25  Tom Tromey  <tom@tromey.com>
2004
2005         * tui/tui-winsource.h (tui_clear_source_content)
2006         (tui_erase_source_content, tui_show_source_content): Change type
2007         of win_info.
2008         * tui/tui-winsource.c (tui_clear_source_content)
2009         (tui_erase_source_content, tui_show_source_content): Change type
2010         of win_info.
2011         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2012         * tui/tui-source.h (tui_set_source_content_nil): Change type of
2013         win_info.
2014         * tui/tui-source.c (tui_set_source_content_nil): Change type of
2015         win_info.
2016         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2017
2018 2019-06-25  Tom Tromey  <tom@tromey.com>
2019
2020         * tui/tui-winsource.c (tui_clear_source_content)
2021         (tui_source_window_base::set_is_exec_point_at): Update.
2022         * tui/tui-source.c (tui_set_source_content_nil): Update.
2023         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2024         a bool.
2025         * tui/tui-data.c (init_content_element): Update.
2026
2027 2019-06-25  Tom Tromey  <tom@tromey.com>
2028
2029         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2030         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2031         * tui/tui-layout.c (init_and_make_win): Update.
2032         * tui/tui.h (enum tui_win_type): Update.
2033         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
2034         tui_win_is_auxillary.
2035         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
2036         tui_win_is_auxillary.
2037
2038 2019-06-25  Tom Tromey  <tom@tromey.com>
2039
2040         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
2041         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
2042         (tui_delete_data_content_windows, tui_display_all_data)
2043         (tui_data_window::do_scroll_vertical, tui_display_data_from):
2044         Update.
2045         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
2046         * tui/tui-regs.c (tui_last_regs_line_no)
2047         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2048         (tui_show_registers): Update.
2049         (tui_show_register_group): Return void.  Update.
2050         (tui_display_registers_from, tui_display_reg_element_at_line)
2051         (tui_display_registers_from_line, tui_check_register_values):
2052         Update.
2053         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2054         member.
2055         (struct tui_data_window) <regs_content>: Now a std::vector.
2056         <regs_content_count>: Remove.
2057         (tui_add_content_elements, tui_free_data_content): Don't declare.
2058         * tui/tui-data.c (tui_data_window::clear_detail): Update.
2059         (init_content_element): Remove DATA_WIN case.  Add assert.
2060         (tui_add_content_elements): Remove.
2061         (tui_data_window): Update.
2062         (tui_free_data_content): Remove.
2063         (free_content_elements): Remove DATA_WIN case.
2064
2065 2019-06-25  Tom Tromey  <tom@tromey.com>
2066
2067         * tui/tui-data.c (tui_data_item_window): Update.
2068         * tui/tui-windata.h (tui_check_data_values): Don't declare.
2069         * tui/tui-windata.c (tui_display_all_data)
2070         (tui_display_data_from_line): Update.
2071         (tui_check_data_values): Remove.
2072         * tui/tui-regs.c (tui_show_register_group)
2073         (tui_display_reg_element_at_line): Update.
2074         * tui/tui-hooks.c (tui_register_changed)
2075         (tui_refresh_frame_and_register_information): Call
2076         tui_check_register_values.
2077         * tui/tui-data.h (struct tui_data_window) <data_content,
2078         data_content_count, data_type>: Remove.
2079         (enum tui_data_type): Remove.
2080
2081         * tui/tui-data.c (tui_data_window::clear_detail)
2082         (~tui_data_window): Update.
2083
2084 2019-06-25  Tom Tromey  <tom@tromey.com>
2085
2086         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2087         declare.
2088         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2089         Rename from tui_first_data_item_displayed.  Update.
2090         (tui_data_window::refresh_all)
2091         (tui_data_window::do_scroll_vertical): Update.
2092         * tui/tui-data.h (struct tui_data_window)
2093         <first_data_item_displayed>: Declare new method.
2094
2095 2019-06-25  Tom Tromey  <tom@tromey.com>
2096
2097         * tui/tui-data.h (tui_init_generic_part): Don't declare.
2098         * tui/tui-data.c (tui_init_generic_part): Remove, moving
2099         contents...
2100         (tui_initialize_static_data): ...here.
2101
2102 2019-06-25  Tom Tromey  <tom@tromey.com>
2103
2104         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2105         (tui_display_registers_from, tui_check_register_values): Update.
2106         (tui_display_register): Remove win_info parameter; update.
2107         (tui_get_register): Change type of parameters.
2108         * tui/tui-data.h (struct tui_data_element): Remove.
2109         (union tui_which_element) <data>: Remove.
2110         <data_window>: Change type.
2111         (struct tui_data_item_window): New.
2112         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2113         case.  Add assert.
2114         (~tui_data_item_window): New destructor.
2115         (free_content_elements): Remove DATA_ITEM_WIN case.
2116
2117 2019-06-25  Tom Tromey  <tom@tromey.com>
2118
2119         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2120         Remove.
2121
2122 2019-06-25  Tom Tromey  <tom@tromey.com>
2123
2124         * tui/tui-data.h (struct tui_command_element): Remove.
2125         (union tui_which_element) <command>: Remove.
2126         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
2127         assert.
2128         (free_content_elements): Remove CMD_WIN case.
2129
2130 2019-06-25  Tom Tromey  <tom@tromey.com>
2131
2132         * tui/tui-layout.c (tui_set_layout): Update.
2133         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2134         * tui/tui-data.c (layout_def): Update.
2135
2136 2019-06-25  Tom Tromey  <tom@tromey.com>
2137
2138         * tui/tui-wingeneral.c (tui_refresh_all): Update.
2139         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2140         (tui_source_window_base::set_new_height): Update.
2141         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2142         Update.
2143         (tui_set_locator_fullname, tui_set_locator_info)
2144         (tui_show_frame_info): Update.
2145         * tui/tui-source.c (tui_set_source_content)
2146         (tui_source_is_displayed): Update.
2147         * tui/tui-layout.c (show_source_disasm_command, show_data)
2148         (show_source_or_disasm_and_command): Update.
2149         * tui/tui-disasm.c (tui_set_disassem_content)
2150         (tui_get_begin_asm_address): Update.
2151         * tui/tui-data.h (struct tui_locator_element): Remove.
2152         (union tui_which_element) <locator>: Remove.
2153         (struct tui_locator_window): New.
2154         (tui_locator_win_info_ptr): Change return type.
2155         * tui/tui-data.c (_locator): Change type.
2156         (tui_locator_win_info_ptr): Change return type.
2157         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
2158         (tui_alloc_content): Add assert.
2159
2160 2019-06-25  Tom Tromey  <tom@tromey.com>
2161
2162         * tui/tui-winsource.c
2163         (tui_exec_info_window::maybe_allocate_content): New method.
2164         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2165         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2166         (make_source_or_disasm_window): Add cast.
2167         * tui/tui-data.h (union tui_which_element) <simple_string>:
2168         Remove.
2169         (struct tui_source_info): New.
2170         (struct tui_source_window_base) <execution_info>: Change type.
2171         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2172         case, and add assert.
2173         (tui_alloc_content): Add assert.
2174
2175 2019-06-25  Tom Tromey  <tom@tromey.com>
2176
2177         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2178         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2179         * tui/tui-data.c (tui_alloc_win_info): Remove.
2180
2181 2019-06-25  Tom Tromey  <tom@tromey.com>
2182
2183         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2184         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2185         can_highlight.
2186
2187 2019-06-25  Tom Tromey  <tom@tromey.com>
2188
2189         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2190         make_visible_with_new_height method.
2191         (tui_win_info::make_visible_with_new_height): New method.
2192         (tui_source_window_base::do_make_visible_with_new_height)
2193         (tui_data_window::do_make_visible_with_new_height)
2194         (tui_cmd_window::do_make_visible_with_new_height): New methods.
2195         (make_visible_with_new_height): Remove.
2196         (tui_resize_all, tui_adjust_win_heights): Use
2197         make_visible_with_new_height method.
2198         * tui/tui-data.h (struct tui_win_info)
2199         <do_make_visible_with_new_height, make_visible_with_new_height>:
2200         New methods.
2201         (struct tui_source_window_base, struct tui_data_window)
2202         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2203         methods.
2204
2205 2019-06-25  Tom Tromey  <tom@tromey.com>
2206
2207         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2208         method.
2209         (update_tab_width): Call update_tab_width method.
2210         * tui/tui-data.h (struct tui_win_info)
2211         (struct tui_source_window_base) <update_tab_width>: New methods.
2212
2213 2019-06-25  Tom Tromey  <tom@tromey.com>
2214
2215         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2216         parameter.
2217         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2218         parameter.
2219         (tui_gen_win_info::make_visible): Update.
2220         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2221         parameter.
2222         * tui/tui-data.h (enum tui_box): New enum.
2223         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2224
2225 2019-06-25  Tom Tromey  <tom@tromey.com>
2226
2227         * tui/tui-layout.c (make_source_or_disasm_window): Always use
2228         init_and_make_win for EXEC_INFO_WIN.
2229         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2230         longer inline.
2231         (struct tui_win_info) <~tui_win_info>: Inline.
2232         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2233         Don't declare.
2234         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2235         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2236         Remove.
2237         (tui_initialize_static_data): Update.
2238         (~tui_gen_win_info): Handle more cleanup here.
2239         (~tui_source_window_base): Delete "execution_info".
2240         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2241
2242 2019-06-25  Tom Tromey  <tom@tromey.com>
2243
2244         * tui/tui-layout.c (make_command_window): Don't set
2245         can_highlight.
2246         (show_source_disasm_command): Call the reset method.
2247         (show_data): Don't set can_highlight.  Call the reset method.
2248         (tui_gen_win_info::reset): Rename from init_gen_win_info
2249         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2250         (show_source_or_disasm_and_command): Call the reset method.
2251         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2252         (struct tui_cmd_window): Set can_highlight.
2253
2254 2019-06-25  Tom Tromey  <tom@tromey.com>
2255
2256         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2257         from make_visible.
2258         (tui_make_visible, tui_make_invisible): Rewrite.
2259         (tui_win_info::make_visible): Remove.
2260         (tui_source_window_base::make_visible): Update.
2261         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2262         method.  Moved from...
2263         (struct tui_win_info) <make_visible>: ...here.
2264
2265 2019-06-25  Tom Tromey  <tom@tromey.com>
2266
2267         * tui/tui-winsource.c
2268         (tui_source_window_base::do_scroll_horizontal): Remove direction
2269         parameter.
2270         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2271         direction parameter.
2272         * tui/tui-win.c (tui_win_info::forward_scroll)
2273         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2274         (tui_win_info::right_scroll): Update.
2275         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2276         direction parameter.
2277         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2278         direction parameter.
2279         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2280         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2281         Remove direction parameter.
2282         (struct tui_source_window_base, struct tui_source_window)
2283         (struct tui_disasm_window, struct tui_data_window)
2284         (struct tui_cmd_window): Update.
2285
2286 2019-06-25  Tom Tromey  <tom@tromey.com>
2287
2288         * tui/tui-winsource.h (tui_set_exec_info_content)
2289         (tui_show_exec_info_content, tui_erase_exec_info_content)
2290         (tui_clear_exec_info_content, tui_update_exec_info): Change
2291         argument to tui_source_window_base.
2292         * tui/tui-winsource.c (tui_set_exec_info_content)
2293         (tui_show_exec_info_content, tui_erase_exec_info_content)
2294         (tui_clear_exec_info_content, tui_update_exec_info): Change
2295         argument to tui_source_window_base.
2296
2297 2019-06-25  Tom Tromey  <tom@tromey.com>
2298
2299         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2300         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2301
2302 2019-06-25  Tom Tromey  <tom@tromey.com>
2303
2304         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2305         check.
2306
2307 2019-06-25  Tom Tromey  <tom@tromey.com>
2308
2309         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2310         type to void.
2311         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2312         type to void.
2313         * tui/tui-source.c (tui_set_source_content): Update.
2314         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2315
2316 2019-06-25  Tom Tromey  <tom@tromey.com>
2317
2318         * tui/tui-win.c (window_name_completer, tui_set_focus)
2319         (tui_all_windows_info): Use name method.
2320         * tui/tui-data.h (struct tui_gen_win_info)
2321         (struct tui_source_window, struct tui_disasm_window)
2322         (struct tui_data_window, struct tui_cmd_window) <name>: New
2323         method.
2324         (tui_win_name): Don't declare.
2325         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2326         (tui_win_name): Remove.
2327
2328 2019-06-25  Tom Tromey  <tom@tromey.com>
2329
2330         * tui/tui-winsource.h (tui_update_source_window)
2331         (tui_update_source_window_as_is): Change parameter type.
2332         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2333         to be a tui_source_window_base.
2334         (tui_update_source_window_as_is): Likewise.
2335         * tui/tui-win.c (make_visible_with_new_height): Update.
2336
2337 2019-06-25  Tom Tromey  <tom@tromey.com>
2338
2339         * tui/tui-winsource.c (tui_erase_source_content)
2340         (tui_show_source_content, tui_show_exec_info_content)
2341         (tui_erase_exec_info_content): Use refresh_window method.
2342         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2343         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2344         from tui_refresh_win.
2345         (tui_data_window::refresh_window): New method.
2346         (tui_win_info::refresh, tui_source_window_base::refresh)
2347         (tui_refresh_all): Use refresh_window method.
2348         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2349         method.
2350         * tui/tui-regs.c (tui_display_register): Call refresh_window
2351         method.
2352         * tui/tui-layout.c (show_source_disasm_command)
2353         (show_source_or_disasm_and_command): Call refresh_window method.
2354         * tui/tui-data.h (struct tui_gen_win_info)
2355         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2356         New method.
2357
2358 2019-06-25  Tom Tromey  <tom@tromey.com>
2359
2360         * tui/tui.c (tui_rl_other_window, tui_enable)
2361         (tui_is_window_visible, tui_get_command_dimension): Update.
2362         * tui/tui-winsource.c (tui_update_source_window_as_is)
2363         (tui_clear_source_content, tui_erase_source_content)
2364         (tui_show_source_line, tui_source_window_base::refill)
2365         (tui_source_window_base::do_scroll_horizontal)
2366         (tui_source_window_base::set_is_exec_point_at)
2367         (tui_update_breakpoint_info, tui_set_exec_info_content)
2368         (tui_alloc_source_buffer, tui_line_is_displayed)
2369         (tui_addr_is_displayed): Update.
2370         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2371         (tui_check_and_display_highlight_if_needed)
2372         (tui_win_info::make_visible, tui_win_info::refresh)
2373         (tui_refresh_all): Update.
2374         * tui/tui-windata.c (tui_first_data_item_displayed)
2375         (tui_delete_data_content_windows, tui_erase_data_content)
2376         (tui_display_all_data, tui_data_window::refresh_all)
2377         (tui_check_data_values): Update.
2378         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2379         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2380         (tui_win_info::backward_scroll, tui_refresh_all_win)
2381         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2382         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2383         (tui_source_window_base::set_new_height)
2384         (tui_data_window::set_new_height)
2385         (make_invisible_and_set_new_height)
2386         (make_visible_with_new_height, new_height_ok)
2387         (parse_scrolling_args): Update.
2388         * tui/tui-stack.c (tui_show_frame_info): Update.
2389         * tui/tui-source.c (tui_set_source_content)
2390         (tui_set_source_content_nil, tui_source_is_displayed)
2391         (tui_source_window::do_scroll_vertical): Update.
2392         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2393         (tui_display_registers_from, tui_display_reg_element_at_line)
2394         (tui_check_register_values, tui_reg_command): Update.
2395         * tui/tui-layout.c (tui_default_win_height)
2396         (show_source_disasm_command, show_data, init_and_make_win)
2397         (show_source_or_disasm_and_command): Update.
2398         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2399         (tui_redisplay_readline, tui_mld_flush)
2400         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2401         (tui_getc): Update.
2402         * tui/tui-disasm.c (tui_set_disassem_content)
2403         (tui_disasm_window::do_scroll_vertical): Update.
2404         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2405         Now virtual.
2406         (struct tui_win_info): Derive from tui_gen_win_info.
2407         <~tui_win_info>: Mark as override.
2408         <generic>: Remove member.
2409         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2410         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2411         (~tui_data_window, ~tui_win_info)
2412         (tui_free_all_source_wins_content): Update.
2413         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2414
2415 2019-06-25  Tom Tromey  <tom@tromey.com>
2416
2417         * tui/tui-layout.c (init_and_make_win): Use new.
2418         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2419         destructor, initializers.
2420         (tui_alloc_generic_win_info): Don't declare.
2421         * tui/tui-data.c (_locator): Add argument to constructor.
2422         (source_win, disasm_win): New globals.
2423         (exec_info): Remove.
2424         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2425         Update.
2426         (tui_alloc_generic_win_info): Remove.
2427         (init_content_element): Use new.
2428         (tui_win_info::tui_win_info): Update.
2429         (free_content_elements) <case DATA_WIN>: Use delete.
2430
2431 2019-06-25  Tom Tromey  <tom@tromey.com>
2432
2433         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2434         * tui/tui-windata.c (tui_first_data_item_displayed)
2435         (tui_delete_data_content_windows): Update.
2436         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2437         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2438         (tui_display_registers_from, tui_check_register_values): Update.
2439         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2440         pointer.
2441         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2442         window.
2443         (tui_free_data_content): Update.
2444         (free_content_elements) <case DATA_WIN>: Free the window.
2445
2446 2019-06-25  Tom Tromey  <tom@tromey.com>
2447
2448         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2449         Update.
2450         * tui/tui-layout.c (make_command_window)
2451         (show_source_disasm_command, show_data, init_and_make_win)
2452         (show_source_or_disasm_and_command): Update.
2453         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2454         method.
2455         <can_highight, is_highlighted>: Now bool.
2456         (tui_set_win_highlight): Don't declare.
2457         * tui/tui-data.c (tui_set_win_highlight): Remove.
2458
2459 2019-06-25  Tom Tromey  <tom@tromey.com>
2460
2461         * tui/tui-wingeneral.c (make_visible): Remove check of window
2462         type.
2463
2464 2019-06-25  Tom Tromey  <tom@tromey.com>
2465
2466         * tui/tui-win.c (tui_win_info::max_height)
2467         (tui_cmd_window::max_height): New methods.
2468         (new_height_ok): Call max_height.
2469         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2470         <max_height>: New method.
2471
2472 2019-06-25  Tom Tromey  <tom@tromey.com>
2473
2474         * tui/tui-win.c (tui_source_window_base::set_new_height)
2475         (tui_data_window::set_new_height): New methods.
2476         (make_invisible_and_set_new_height): Call set_new_height method.
2477         * tui/tui-data.h (struct tui_win_info)
2478         (struct tui_source_window_base, struct tui_data_window)
2479         <set_new_height>: New method.
2480
2481 2019-06-25  Tom Tromey  <tom@tromey.com>
2482
2483         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2484         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2485         tui_refresh_data_win.
2486         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2487         method.
2488         (tui_refresh_all_win): Call the refresh_all method.
2489         (tui_set_focus): Likewise.
2490         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2491         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2492         Likewise.
2493
2494 2019-06-25  Tom Tromey  <tom@tromey.com>
2495
2496         * tui/tui-winsource.h (tui_refill_source_window)
2497         (tui_set_is_exec_point_at): Don't declare.
2498         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2499         (tui_source_window_base::refill): Rename from
2500         tui_refill_source_window.
2501         (tui_source_window_base::do_scroll_horizontal): Update.
2502         (tui_source_window_base::set_is_exec_point_at): Rename from
2503         tui_set_is_exec_point_at.
2504         (tui_update_all_breakpoint_info): Update.
2505         * tui/tui-stack.c (tui_show_frame_info): Update.
2506         * tui/tui-layout.c (show_data): Add cast.
2507         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2508         * tui/tui-data.h (struct tui_source_window_base) <refill,
2509         set_is_exec_point_at>: New methods.
2510         (tui_source_windows, tui_add_to_source_windows): Update types.
2511         (tui_add_to_source_windows): Remove redundant declaration.
2512         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2513         (tui_source_windows): Change return type.
2514         (tui_clear_source_windows_detail): Update.
2515         (tui_add_to_source_windows): Change type of parameter.
2516         (tui_free_all_source_wins_content): Update.
2517
2518 2019-06-25  Tom Tromey  <tom@tromey.com>
2519
2520         * tui/tui-wingeneral.c (tui_win_info::refresh)
2521         (tui_source_window_base::refresh): New methods.
2522         (tui_refresh_all): Call the refresh method.
2523         * tui/tui-data.h (struct tui_win_info)
2524         (struct tui_source_window_base) <refresh>: New method.
2525
2526 2019-06-25  Tom Tromey  <tom@tromey.com>
2527
2528         * tui/tui.h (tui_is_window_visible): Return bool.
2529         * tui/tui.c (tui_is_window_visible): Return bool.
2530         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2531         (tui_make_visible, tui_make_invisible)
2532         (tui_win_info::make_visible)
2533         (tui_source_window_base::make_visible, make_all_visible)
2534         (tui_make_all_visible, tui_make_all_invisible): Update.
2535         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2536         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2537         bool.
2538         (struct tui_win_info, struct tui_source_window_base)
2539         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2540         * tui/tui-data.c (tui_init_generic_part): Update.
2541
2542 2019-06-25  Tom Tromey  <tom@tromey.com>
2543
2544         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2545         (tui_source_window_base::make_visible): New methods.
2546         (make_all_visible): Make method call.
2547         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2548         (struct tui_source_window_base, struct tui_cmd_window): Override
2549         make_visible.
2550         (tui_win_is_source_type): Don't declare.
2551         * tui/tui-data.c (tui_win_is_source_type): Remove.
2552
2553 2019-06-25  Tom Tromey  <tom@tromey.com>
2554
2555         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2556         NULL check.
2557
2558 2019-06-25  Tom Tromey  <tom@tromey.com>
2559
2560         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2561         Inline constructor.  Add initializers for members.
2562         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2563         constructors; now inline in class.
2564
2565 2019-06-25  Tom Tromey  <tom@tromey.com>
2566
2567         * tui/tui-regs.c (tui_show_registers): Update.
2568         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2569         bool.
2570         * tui/tui-data.c (tui_data_window::clear_detail)
2571         (tui_data_window): Update.
2572
2573 2019-06-25  Tom Tromey  <tom@tromey.com>
2574
2575         * tui/tui-windata.c (tui_display_all_data)
2576         (tui_display_data_from_line, tui_display_data_from)
2577         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2578         Update.
2579         * tui/tui-regs.c (tui_last_regs_line_no)
2580         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2581         (tui_show_registers, tui_show_register_group)
2582         (tui_display_registers_from, tui_display_reg_element_at_line)
2583         (tui_display_registers_from_line, tui_check_register_values)
2584         (tui_reg_next, tui_reg_prev): Update.
2585         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2586         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2587         tui_data_window.
2588         (struct tui_win_info) <detail>: Remove.  Add new fields from
2589         tui_data_info.
2590         (TUI_DATA_WIN): Add cast.
2591         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2592         (~tui_data_window): Simplify.
2593
2594 2019-06-25  Tom Tromey  <tom@tromey.com>
2595
2596         * tui/tui-layout.c (show_source_disasm_command)
2597         (show_source_or_disasm_and_command): Update.
2598         * tui/tui-io.c (update_cmdwin_start_line)
2599         (tui_redisplay_readline): Update.
2600         * tui/tui-data.h (struct tui_command_info): Remove.
2601         (struct tui_win_info) <detail>: Remove command_info member.
2602         (struct tui_data_window) <start_line>: New member, from
2603         tui_command_info.
2604         (TUI_CMD_WIN): Add casts.
2605
2606 2019-06-25  Tom Tromey  <tom@tromey.com>
2607
2608         * tui/tui-winsource.c (tui_update_source_window)
2609         (tui_refill_source_window)
2610         (tui_source_window_base::do_scroll_horizontal)
2611         (tui_update_breakpoint_info, tui_set_exec_info_content)
2612         (tui_show_exec_info_content, tui_erase_exec_info_content)
2613         (tui_clear_exec_info_content): Update.
2614         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2615         Update.
2616         * tui/tui-win.c (make_invisible_and_set_new_height)
2617         (make_visible_with_new_height): Update.
2618         * tui/tui-source.c (tui_set_source_content)
2619         (tui_show_symtab_source): Update.
2620         * tui/tui-layout.c (extract_display_start_addr)
2621         (show_source_disasm_command, show_data)
2622         (make_source_or_disasm_window)
2623         (show_source_or_disasm_and_command): Update.
2624         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2625         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2626         "gdbarch".
2627         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2628         to tui_source_window_base.
2629         (struct tui_win_info) <detail>: Remove source_info member.
2630         (struct tui_source_window_base) <has_locator>: Inline.
2631         Move contents from tui_source_info; rename has_locator member to
2632         m_has_locator.
2633         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2634         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2635         header file.
2636         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2637         Simplify.
2638         (tui_free_all_source_wins_content): Cast to
2639         tui_source_window_base.
2640
2641 2019-06-25  Tom Tromey  <tom@tromey.com>
2642
2643         * tui/tui-win.c (make_invisible_and_set_new_height)
2644         (make_visible_with_new_height): Call has_locator method.
2645         * tui/tui-layout.c (show_source_disasm_command, show_data)
2646         (show_source_or_disasm_and_command): Update for bool change.
2647         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2648         (tui_win_info) <has_locator>: New method.
2649         (struct tui_source_window_base) <has_locator>: New method.
2650         (tui_win_has_locator): Don't declare.
2651         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2652         from tui_win_has_locator.
2653         (tui_source_window_base): Use false, not FALSE.
2654
2655 2019-06-25  Tom Tromey  <tom@tromey.com>
2656
2657         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2658         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2659         clear_detail method directly.
2660         (tui_clear_win_detail): Remove.
2661
2662 2019-06-25  Tom Tromey  <tom@tromey.com>
2663
2664         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2665         "this", not TUI_DISASM_WIN.
2666
2667 2019-06-25  Tom Tromey  <tom@tromey.com>
2668
2669         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2670         declare.
2671         * tui/tui-winsource.c
2672         (tui_source_window_base::do_scroll_horizontal): Rename from
2673         tui_horizontal_source_scroll.
2674         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2675         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2676         from tui_vertical_data_scroll.
2677         * tui/tui-win.h (tui_scroll): Don't declare.
2678         * tui/tui-win.c (tui_win_info::forward_scroll)
2679         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2680         (tui_win_info::right_scroll): Rename and update.
2681         (tui_scroll_forward_command, tui_scroll_backward_command)
2682         (tui_scroll_left_command, tui_scroll_right_command): Update.
2683         (tui_scroll): Remove.
2684         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2685         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2686         from tui_vertical_source_scroll.
2687         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2688         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2689         from tui_vertical_disassem_scroll.
2690         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2691         do_scroll_horizontal>: New methods.
2692         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2693         Likewise.
2694         (struct tui_source_window_base): Add do_scroll_horizontal.
2695         (struct tui_source_window, struct tui_disasm_window): Add
2696         do_scroll_vertical.
2697         (struct tui_data_window, struct tui_cmd_window): Add
2698         do_scroll_horizontal and do_scroll_vertical.
2699         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2700
2701 2019-06-25  Tom Tromey  <tom@tromey.com>
2702
2703         * tui/tui-data.h (struct tui_source_window_base): New struct.
2704         (struct tui_source_window): Derive from tui_source_window_base.
2705         (struct tui_disasm_window): New struct.
2706         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2707         from tui_source_window::clear_detail.
2708         (tui_source_window_base): Rename from tui_source_window.
2709         (~tui_source_window_base): Rename from ~tui_source_window.
2710         (tui_alloc_win_info): Create a tui_disasm_window.
2711
2712 2019-06-25  Tom Tromey  <tom@tromey.com>
2713
2714         * tui/tui-data.h (struct tui_source_window)
2715         (struct tui_data_window): Declare destructors.
2716         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2717         destructors.
2718         (tui_win_info): Simplify.
2719
2720 2019-06-25  Tom Tromey  <tom@tromey.com>
2721
2722         * tui/tui-winsource.c (tui_display_main)
2723         (tui_update_source_windows_with_addr)
2724         (tui_update_all_breakpoint_info): Update.
2725         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2726         (new_height_ok, parse_scrolling_args): Update.
2727         * tui/tui-stack.c (tui_show_frame_info): Update.
2728         * tui/tui-data.h (struct tui_list): Remove.
2729         (tui_source_windows): Return a reference to a std::vector.
2730         * tui/tui-data.c (source_windows): Now a std::vector.
2731         (tui_source_windows): Change return type.
2732         (tui_clear_source_windows): Rewrite.
2733         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2734         (tui_free_all_source_wins_content): Rewrite.
2735
2736 2019-06-25  Tom Tromey  <tom@tromey.com>
2737
2738         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2739         (struct tui_data_window, struct tui_cmd_window): Declare
2740         clear_detail method.
2741         * tui/tui-data.c (tui_source_window::clear_detail)
2742         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2743         methods.
2744         (tui_clear_win_detail): Simplify.
2745
2746 2019-06-25  Tom Tromey  <tom@tromey.com>
2747
2748         * tui/tui-layout.c (make_source_window, make_disasm_window)
2749         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2750         Return the new window.
2751         (show_source_disasm_command, show_data)
2752         (show_source_or_disasm_and_command): Update.
2753
2754 2019-06-25  Tom Tromey  <tom@tromey.com>
2755
2756         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2757         parameter.  Return the new window.
2758         (show_source_disasm_command): Update and remove NULL check.
2759         (show_source_or_disasm_and_command): Update.
2760
2761 2019-06-25  Tom Tromey  <tom@tromey.com>
2762
2763         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2764
2765 2019-06-25  Tom Tromey  <tom@tromey.com>
2766
2767         * tui/tui-data.h (struct tui_win_info): Make constructor
2768         protected.  Make destructor virtual.  Add initializers.
2769         (tui_source_window, tui_data_window, tui_cmd_window): New
2770         classes.
2771         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2772         constructor.  Add "type" parameter.
2773         (tui_source_window, tui_data_window, tui_cmd_window): New
2774         constructors.
2775         (tui_alloc_win_info): Instantiate the appropriate subclass.
2776
2777 2019-06-25  Tom Tromey  <tom@tromey.com>
2778
2779         * tui/tui-win.c (tui_resize_all): Use delete.
2780         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2781         destructor.
2782         (tui_free_window): Don't declare.
2783         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2784         Update.
2785
2786 2019-06-25  Tom Tromey  <tom@tromey.com>
2787
2788         * tui/tui-data.h (struct tui_win_info): Add constructor.
2789         * tui/tui-data.c (tui_alloc_win_info): Use new.
2790         (tui_free_window): Use delete.
2791
2792 2019-06-22  Tom Tromey  <tom@tromey.com>
2793
2794         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2795         declare.
2796         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2797
2798 2019-06-22  Tom Tromey  <tom@tromey.com>
2799
2800         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2801         declare.
2802         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2803
2804 2019-06-22  Tom de Vries  <tdevries@suse.de>
2805
2806         * dwarf2read.c (create_addrmap_from_aranges)
2807         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2808         instead of '%zu'.
2809
2810 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2811
2812         * dwarf2read.h (dwarf2_section_info_def): Remove.
2813         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2814         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2815         std::vector<dwarf2_section_info>.
2816         (struct dwo_file) <~dwo_file>: Remove.
2817         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2818         types field.
2819         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2820         (dwarf2_read_debug_names): Likewise.
2821         (create_debug_types_hash_table): Change parameter type to
2822         array_view, adjust code accordingly.
2823         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2824         (partial_die_info::fixup): Likewise.
2825         (determine_prefix): Likewise.
2826         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2827
2828 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2829
2830         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2831         gdb_bfd_ref_ptr.
2832         <~dwo_file>: Remove call to gdb_bfd_unref.
2833         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2834         gdb_bfd_ref_ptr::get.
2835
2836 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2837
2838         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2839         type to htab_up.
2840         * dwarf2read.c (struct dwo_file): Initialize fields.
2841         <~dwo_file>: New.
2842         (free_dwo_file): Remove, move content to ~dwo_file.
2843         (struct dwo_file_deleter): Remove.
2844         (dwo_file_up>: Remove custom deleter.
2845         (free_dwo_files): Remove.
2846         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2847         dwo_files.
2848         (process_skeletonless_type_units): Call unique_ptr::get.
2849         (allocate_dwo_file_hash_table): Add deleter to created hash
2850         table.  Change return type to htab_up.
2851         (lookup_dwo_file_slot): Don't memset dwo_file, call
2852         unique_ptr::get.
2853         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2854         (create_dwo_unit_in_dwp_v2): Likewise.
2855         (open_and_init_dwo_file): Likewise.
2856         (free_dwo_file_from_slot): Remove.
2857
2858 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2859
2860         * dwarf2read.h (struct dwarf2_section_info) <readin,
2861         is_virtual>: Change type to bool.
2862         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2863         true instead of 1.
2864
2865 2019-06-19  Tom Tromey  <tom@tromey.com>
2866
2867         * tui/tui-data.h (tui_init_content_element): Don't declare.
2868
2869 2019-06-19  Tom Tromey  <tom@tromey.com>
2870
2871         * tui/tui-data.h (tui_init_win_info): Don't declare.
2872
2873 2019-06-19  Tom de Vries  <tdevries@suse.de>
2874
2875         * dwarf2read.h (abstract_to_concrete): Change type to
2876         std::unordered_map<sect_offset, std::vector<sect_offset>,
2877         gdb::hash_enum<sect_offset>>.
2878
2879 2019-06-19  Tom Tromey  <tromey@adacore.com>
2880
2881         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2882         EVAL_AVOID_SIDE_EFFECTS specially.
2883
2884 2019-06-19  Tom Tromey  <tromey@adacore.com>
2885
2886         * source-cache.c (highlighter): New global.
2887         (source_cache::get_source_lines): Create a highlighter on demand.
2888
2889 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2890
2891         * defs.h (deprecated_interactive_hook): Delete declaration.
2892         * interps.c (clear_interpreter_hooks): Remove use of
2893         deprecated_interactive_hook.
2894         * top.c (deprecated_interactive_hook): Delete definition.
2895         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2896
2897 2019-06-18  Tom de Vries  <tdevries@suse.de>
2898
2899         PR gdb/24515
2900         * dwarf2read.h (abstract_to_concrete): Change type from
2901         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2902         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2903         * dwarf2read.c (read_variable): Update.
2904         (dwarf2_fetch_die_loc_sect_off): Update.
2905
2906 2019-06-17  Tom de Vries  <tdevries@suse.de>
2907
2908         PR gdb/24617
2909         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2910         accessing parent[parent_len - 1].
2911
2912 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2913
2914         PR gdb/24364
2915         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2916         call dtrace_process_dof with NULL dof.
2917
2918 2019-06-16  Tom de Vries  <tdevries@suse.de>
2919
2920         PR gdb/24445
2921         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2922
2923 2019-06-16  Tom Tromey  <tom@tromey.com>
2924
2925         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2926         (make_all_visible): Use address of member.
2927
2928 2019-06-16  Tom Tromey  <tom@tromey.com>
2929
2930         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2931         (tui_free_window, free_content, free_content_elements): Remove
2932         unnecessary cast.
2933         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2934         cast.
2935         * tui/tui-regs.c (tui_show_register_group)
2936         (tui_display_registers_from, tui_display_reg_element_at_line):
2937         Remove unnecessary cast.
2938
2939 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2940
2941         * linux-nat.c (normal_mask): Delete.
2942         (_initialize_linux_nat): Don't initialise normal_mask.
2943
2944 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2945
2946         PR gdb/24445
2947         * dwarf-index-write.h (write_psymtabs_to_index): Add
2948         dwz_basename parameter.
2949         * dwarf-index-write.c (write_gdbindex): Move file writing to
2950         write_gdbindex_1.  Change return type void.
2951         (assert_file_size): Move up, remove filename parameter.
2952         (write_gdbindex_1): New function.
2953         (write_debug_names): Change return type to void, call
2954         assert_file_size.
2955         (struct index_wip_file): New struct.
2956         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2957         file logic to index_wip_file.  Write index for dwz file if
2958         needed.
2959         (save_gdb_index_command): Pass basename of dwz file, if present.
2960         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2961         build-id of dwz file, if present.
2962         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2963         (dwarf2_get_dwz_file): Likewise.
2964         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2965         (dwarf2_get_dwz_file): Likewise.
2966
2967 2019-06-16  Tom Tromey  <tom@tromey.com>
2968
2969         * coffread.c (process_coff_symbol): Use xstrdup.
2970         * value.c (create_internalvar): Use xstrdup.
2971
2972 2019-06-16  Tom Tromey  <tom@tromey.com>
2973
2974         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2975         * breakpoint.c (stopin_command, stopat_command)
2976         (until_break_command, decode_location_default): Remove unnecessary
2977         cast.
2978         * utils.c (subset_compare): Remove unnecessary cast.
2979         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2980         cast.
2981         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2982         cast.
2983         * infcmd.c (path_command): Remove unnecessary cast.
2984         * coffread.c (decode_type): Remove unnecessary cast.
2985         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2986         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2987         * tui/tui-stack.c (tui_show_locator_content)
2988         (tui_show_frame_info): Remove unnecessary cast.
2989         * tui/tui-win.c (tui_scroll_forward_command)
2990         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2991         (parse_scrolling_args): Remove unnecessary cast.
2992         * tui/tui-data.c (init_win_info, tui_del_window)
2993         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2994         (free_content_elements): Remove unnecessary cast.
2995         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2996         unnecessary cast.
2997         * tui/tui-source.c (tui_set_source_content)
2998         (tui_vertical_source_scroll): Remove unnecessary cast.
2999         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3000         cast.
3001         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3002         * tui/tui-regs.c (tui_display_registers_from)
3003         (tui_display_register): Remove unnecessary cast.
3004         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3005         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3006         (make_visible): Remove unnecessary cast.
3007         * tui/tui-winsource.c (tui_erase_source_content)
3008         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3009         unnecessary cast.
3010         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3011         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3012         * stabsread.c (read_type, read_array_type, read_range_type):
3013         Remove unnecessary cast.
3014         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3015         (parse_symbol, parse_type, upgrade_type, parse_external)
3016         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3017         unnecessary cast.
3018         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3019
3020 2019-06-16  Tom Tromey  <tom@tromey.com>
3021
3022         * tui/tui-data.c (tui_alloc_generic_win_info)
3023         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3024         checks.
3025
3026 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
3027             Andrew Burgess  <andrew.burgess@embecosm.com>
3028
3029         * f-typeprint.c (f_print_type): Don't return early for not
3030         associated or not allocated types.
3031         (f_type_print_varspec_suffix): Add print_rank parameter and print
3032         ranks of array types in case they dangling.
3033         (f_type_print_base): Add print_rank parameter.
3034
3035 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3036
3037         * NEWS: Mention new MI commands.
3038         * break-catch-throw.c (enum exception_event_kind): Move to
3039         breakpoint.h.
3040         (print_mention_exception_catchpoint): Output text as a single
3041         message.
3042         (catch_exception_command_1): Rename to...
3043         (catch_exception_event): ...this, make non-static, update header
3044         command, and change some parameter types.
3045         (catch_catch_command): Update for changes to
3046         catch_exception_command_1.
3047         (catch_throw_command): Likewise.
3048         (catch_rethrow_command): Likewise.
3049         * breakpoint.c (enum exception_event_kind): Delete.
3050         * breakpoint.h (enum exception_event_kind): Moved here from
3051         break-catch-throw.c.
3052         (catch_exception_event): Declare.
3053         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3054         (mi_cmd_catch_throw): New function.
3055         (mi_cmd_catch_rethrow): New function.
3056         (mi_cmd_catch_catch): New function.
3057         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
3058         'catch-catch' entries.
3059         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
3060         (mi_cmd_catch_rethrow): Declare.
3061         (mi_cmd_catch_catch): Declare.
3062
3063 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3064
3065         * annotate.c (annotate_source_line): Change return type to void,
3066         update implementation to match.
3067         * annotate.h (annotate_source_line): Change return type to void,
3068         update header comment.
3069         * stack.c (print_frame_info): Don't change what frame information
3070         is printed based on whether annotations are on or not.
3071
3072 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3073
3074         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3075         (annotate_source): Make static.
3076         (annotate_source_line): Moved from source.c and renamed from
3077         identify_source_line.  Update the return type.
3078         * annotate.h (annotate_source): Delete declaration.
3079         (annotate_source_line): Declaration moved from source.h, and
3080         renamed from identify_source_line.  Return type updated.
3081         * source.c (identify_source_line): Moved to annotate.c and renamed
3082         to annotate_source_line.
3083         (info_line_command): Remove check of annotation_level.
3084         * source.h (identify_source_line): Move declaration to annotate.h
3085         and rename to annotate_source_line.
3086         * stack.c: Add 'annotate.h' include.
3087         (print_frame_info): Remove check of annotation_level before
3088         calling annotate_source_line.
3089
3090 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3091
3092         * source-cache.c (source_cache::get_plain_source_lines): Use
3093         open_source_file_with_line_charpos instead of just
3094         open_source_file, remove call to find_source_lines.
3095         (source_cache::get_source_lines): Likewise.
3096         * source.c (find_source_lines): Make static.
3097         (get_filename_and_charpos): Renamed into...
3098         (open_source_file_with_line_charpos): ..this along with changes to
3099         return a scoped_fd, and some other minor clean ups.
3100         (identify_source_line): Use open_source_file_with_line_charpos.
3101         (search_command_helper): Use open_source_file_with_line_charpos
3102         instead of just open_source_file, remove call to
3103         find_source_lines.
3104         * source.h (open_source_file_with_line_charpos): Declare new
3105         function.
3106         (find_source_lines): Delete declaration.
3107
3108 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3109
3110         * source.c (get_filename_and_charpos): Remove fullname
3111         parameter.
3112         (identify_source_line): Update call to get_filename_and_charpos.
3113
3114 2019-06-14  Tom Tromey  <tromey@adacore.com>
3115
3116         PR gdb/24502:
3117         * ui-style.h (skip_ansi_escape): Update comment.
3118         * ui-file.h (class no_terminal_escape_file): New class.
3119         * ui-file.c (no_terminal_escape_file::write)
3120         (no_terminal_escape_file::puts): New methods.
3121         * cli/cli-logging.c (handle_redirections): Use
3122         no_terminal_escape_file.
3123
3124 2019-06-14  Tom Tromey  <tromey@adacore.com>
3125
3126         * NEWS: Move convenience variable news above Python news.
3127
3128 2019-06-14  Tom Tromey  <tom@tromey.com>
3129
3130         * gnulib: Move directory to top-level.
3131         * configure.ac: Don't configure gnulib.
3132         * configure: Rebuild.
3133         * common/common-defs.h: Use new path to gnulib.
3134         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3135         (GNULIB_H): Remove.
3136         (INCGNU): Look in new gnulib location.
3137         (HFILES_NO_SRCDIR): Remove gnulib files.
3138         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3139         (generated_files): Remove GNULIB_H.
3140         ($(LIBGNU), all-lib): Remove targets.
3141         (distclean): Don't mention GNULIB_BUILDDIR.
3142         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3143
3144 2019-06-14  Tom Tromey  <tromey@adacore.com>
3145
3146         * symfile.c (add_symbol_file_command): Remove obsolete comment.
3147         Warn if symbol file does not provide any symbols.
3148
3149 2019-06-14  Tom Tromey  <tromey@adacore.com>
3150
3151         * source.c (find_and_open_source): Respect basenames_may_differ.
3152
3153 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
3154
3155         * annotate.c (annotate_breakpoints_invalid): Make use of
3156         scoped_restore_terminal_state.
3157         (annotate_frames_invalid): Likewise.
3158
3159 2019-06-14  Tom Tromey  <tromey@adacore.com>
3160
3161         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3162         allow assignment to an internalvar.
3163
3164 2019-06-14  Tom Tromey  <tromey@adacore.com>
3165
3166         * ada-lex.l: Allow "_" in attribute names.
3167
3168 2019-06-14  Tom Tromey  <tromey@adacore.com>
3169
3170         PR gdb/24653:
3171         * regcache.c (registers_changed): Don't call alloca.
3172         * top.c (execute_command): Don't call alloca.
3173
3174 2019-06-13  Pedro Alves  <palves@redhat.com>
3175
3176         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3177         'expression'.  When parsing an expression, error out if there's
3178         junk after "unlimited".
3179         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3180         (do_set_command): Adjust calls to is_unlimited_literal.
3181
3182 2019-06-13  Pedro Alves  <palves@redhat.com>
3183
3184         * compile/compile.c (make_compile_options_def_group): Add braces
3185         around array_view initializer.
3186         * thread.c (make_thread_apply_all_options_def_group)
3187         (make_thread_apply_all_options_def_group): Likewise.
3188
3189 2019-06-13  Pedro Alves  <palves@redhat.com>
3190
3191         * NEWS (New commands): Mention "maint test-options
3192         require-delimiter", "maint test-options unknown-is-error", "maint
3193         test-options unknown-is-operand" and "maint show
3194         test-options-completion-result".
3195         (New command options, command completion): New section.
3196         (Completion improvements): New section.
3197         Mention that you can abbreviate "unlimited".
3198
3199 2019-06-13  Pedro Alves  <palves@redhat.com>
3200
3201         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3202         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3203         * unittests/cli-utils-selftests.c (test_parse_flags)
3204         (test_parse_flags_qcs): Delete.
3205         (test_cli_utils): Don't call deleted functions.
3206
3207 2019-06-13  Pedro Alves  <palves@redhat.com>
3208
3209         * thread.c: Include "cli/cli-option.h".
3210         (tp_array_compar_ascending): Global.
3211         (tp_array_compar): Delete function.
3212         (tp_array_compar_ascending, tp_array_compar_descending): New
3213         functions.
3214         (ascending_option_def, qcs_flag_option_def)
3215         (thr_qcs_flags_option_defs)
3216         (make_thread_apply_all_options_def_group)
3217         (make_thread_apply_options_def_group): New.
3218         (thread_apply_all_command): Use gdb::option::process_options.
3219         (thread_apply_command_completer)
3220         (thread_apply_all_command_completer): New.
3221         (thread_apply_command): Use gdb::option::process_options.
3222         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3223         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
3224         to generate help text of "thread apply".  Adjust "taas"'s help.
3225         * tid-parse.c (tid_range_parser::in_thread_range): New method.
3226         * tid-parse.h (tid_range_parser::in_thread_range): New method.
3227
3228 2019-06-13  Pedro Alves  <palves@redhat.com>
3229
3230         * thread.c (thread_apply_command): Check for invalid TID with
3231         isdigit instead of !isalpha.
3232
3233 2019-06-13  Pedro Alves  <palves@redhat.com>
3234
3235         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3236         (validate_flags_qcs): New.
3237         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3238         (validate_flags_qcs): Declare.
3239         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3240         (make_frame_apply_options_def_group): New.
3241         (frame_apply_command_count): Process options with
3242         gdb::option::process_options.
3243         (frame_apply_completer): New.
3244         (frame_apply_level_completer, frame_apply_all_completer)
3245         (frame_apply_completer): New.
3246         (_initialize_stack): Update help of "frame apply", "frame apply
3247         level", "frame apply all" and "faas" to mention supported options
3248         and install command completers.
3249         * stack.h (frame_apply_all_completer): Declare.
3250         * thread.c: Include "stack.h".
3251         (tfaas_command): Add "--".
3252         (_initialize_thread): Update help "tfaas" to mention supported
3253         options and install command completer.
3254
3255 2019-06-13  Pedro Alves  <palves@redhat.com>
3256
3257         * completer.c (complete_nested_command_line): New.
3258         (gdb_completion_word_break_characters_throw): Add assertion.
3259         * completer.h (complete_nested_command_line): Declare.
3260
3261 2019-06-13  Pedro Alves  <palves@redhat.com>
3262
3263         * stack.c (parse_backtrace_qualifiers): New.
3264         (backtrace_command): Use it.
3265         (backtrace_command_completer): Complete on qualifiers.
3266
3267 2019-06-13  Pedro Alves  <palves@redhat.com>
3268
3269         * frame.c: Include "cli/cli-option.h.
3270         (user_set_backtrace_options): New.
3271         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3272         Delete.
3273         (get_prev_frame): Adjust.
3274         (boolean_option_def, uinteger_option_def)
3275         (set_backtrace_option_defs): New.
3276         (_initialize_frame): Adjust and use
3277         gdb::option::add_setshow_cmds_for_options to install "set
3278         backtrace past-main" and "set backtrace past-entry".
3279         * frame.h: Include "cli/cli-option.h".
3280         (struct frame_print_options): Forward declare.
3281         (print_frame_arguments_all, print_frame_arguments_scalars)
3282         (print_frame_arguments_none): Declare.
3283         (print_entry_values): Delete declaration.
3284         (struct frame_print_options, user_frame_print_options): New.
3285         (struct set_backtrace_options): New.
3286         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3287         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3288         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3289         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3290         (list_args_or_locals): Add frame_print_options parameter.
3291         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3292         * python/py-framefilter.c (enumerate_args): Pass down
3293         USER_FRAME_PRINT_OPTIONS.
3294         * stack.c: Include "cli/cli-option.h".
3295         (print_frame_arguments_all, print_frame_arguments_scalars)
3296         (print_frame_arguments_none): Declare.
3297         (print_raw_frame_arguments, print_entry_values): Delete.
3298         (user_frame_print_options): New.
3299         (boolean_option_def, enum_option_def, frame_print_option_defs):
3300         New.
3301         (struct backtrace_cmd_options): New.
3302         (bt_flag_option_def): New.
3303         (backtrace_command_option_defs): New.
3304         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3305         (print_frame_arg, read_frame_arg, print_frame_args)
3306         (print_frame_info, print_frame): Add frame_print_options parameter
3307         and use it.
3308         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3309         (backtrace_command_1): Add frame_print_options and
3310         backtrace_cmd_options parameters and use them.
3311         (make_backtrace_options_def_group): New.
3312         (backtrace_command): Process command options with
3313         gdb::option::process_options.
3314         (backtrace_command_completer): New.
3315         (_initialize_stack): Extend "backtrace"'s help to mention
3316         supported options.  Install completer for "backtrace".
3317         Install some settings commands with add_setshow_cmds_for_options.
3318
3319 2019-06-13  Pedro Alves  <palves@redhat.com>
3320
3321         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3322         and that "set/show print raw frame-arguments" are now deprecated.
3323
3324         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3325         command.
3326         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3327         * stack.c (_initialize_stack): Install "set/show print
3328         raw-frame-arguments", and deprecate "set/show print raw
3329         frame-arguments".
3330         * valprint.c (_initialize_valprint): Deprecate "set/show print
3331         raw".
3332
3333 2019-06-13  Pedro Alves  <palves@redhat.com>
3334
3335         * compile/compile.c (struct compile_options): New.
3336         (compile_flag_option_def, compile_command_option_defs)
3337         (make_compile_options_def_group): New.
3338         (compile_file_command): Handle options with
3339         gdb::option::process_options.
3340         (compile_file_command_completer): New function.
3341         (compile_code_command): Handle options with
3342         gdb::option::process_options.
3343         (compile_code_command_completer): New function.
3344         (_initialize_compiler): Install completers for "compile code" and
3345         "compile file".  Mention available options in "compile code" and
3346         "compile code"'s help.
3347         * completer.c (advance_to_completion_word): New, factored out from
3348         ...
3349         (advance_to_expression_complete_word_point): ... this.
3350         (advance_to_filename_complete_word_point): New.
3351         * completer.h (advance_to_filename_complete_word_point): New
3352         declaration.
3353
3354 2019-06-13  Pedro Alves  <palves@redhat.com>
3355
3356         * compile/compile.c: Include "cli/cli-option.h".
3357         (compile_print_value): Scope data pointer is now a
3358         value_print_options pointer; adjust.
3359         (compile_print_command): Process options.  Scope data pointer is
3360         now a value_print_options pointer; adjust.
3361         (_initialize_compile): Update "compile print"'s help to include
3362         supported options.  Install a completer for "compile print".
3363         * cp-valprint.c (show_vtblprint, show_objectprint)
3364         (show_static_field_print): Delete.
3365         (_initialize_cp_valprint): Don't install "set print
3366         static-members", "set print vtbl", "set print object" here.
3367         * printcmd.c: Include "cli/cli-option.h" and
3368         "common/gdb_optional.h".
3369         (print_command_parse_format): Rework to fill in a
3370         value_print_options instead of a format_data.
3371         (print_value): Change parameter type from format_data pointer to
3372         value_print_options reference.  Adjust.
3373         (print_command_1): Process options.  Adjust to pass down a
3374         value_print_options.
3375         (print_command_completer): New.
3376         (_initialize_printcmd): Install print_command_completer as
3377         handle_brkchars completer for the "print" command.  Update
3378         "print"'s help to include supported options.
3379         * valprint.c: Include "cli/cli-option.h".
3380         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3381         here from cp-valprint.c.
3382         (boolean_option_def, uinteger_option_def)
3383         (value_print_option_defs, make_value_print_options_def_group):
3384         New.  Use gdb::option::add_setshow_cmds_for_options to install
3385         "set print elements", "set print null-stop", "set print repeats",
3386         "set print pretty", "set print union", "set print array", "set
3387         print address", "set print symbol", "set print array-indexes".
3388         * valprint.h: Include <string> and "cli/cli-option.h".
3389         (make_value_print_options_def_group): Declare.
3390         (print_value): Change parameter type from format_data pointer to
3391         value_print_options reference.
3392         (print_command_completer): Declare.
3393
3394 2019-06-13  Pedro Alves  <palves@redhat.com>
3395
3396         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3397         (COMMON_SFILES): Add maint-test-settings.c.
3398         * cli/cli-decode.c (boolean_enums): New global, factored out from
3399         ...
3400         (add_setshow_boolean_cmd): ... here.
3401         * cli/cli-decode.h (boolean_enums): Declare.
3402         * cli/cli-option.c: New file.
3403         * cli/cli-option.h: New file.
3404         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3405         factored out from ...
3406         (parse_cli_boolean_value(const char *)): ... this.
3407         (is_unlimited_literal): Change parameter type to pointer to
3408         pointer.  Adjust and advance ARG pointer.
3409         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3410         (parse_cli_var_enum): New, factored out from ...
3411         (do_set_command): ... this.  Adjust.
3412         * cli/cli-setshow.h (parse_cli_boolean_value)
3413         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3414         (parse_cli_var_enum): Declare.
3415         * cli/cli-utils.c: Include "cli/cli-option.h".
3416         (get_ulongest): New.
3417         * cli/cli-utils.h (get_ulongest): Declare.
3418         (check_for_argument): New overloads.
3419         * maint-test-options.c: New file.
3420
3421 2019-06-13  Pedro Alves  <palves@redhat.com>
3422
3423         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3424         parse a range if "-" is at the end of the string.
3425
3426 2019-06-13  Pedro Alves  <palves@redhat.com>
3427
3428         * cli/cli-setshow.c (parse_auto_binary_operation)
3429         (parse_cli_boolean_value): Don't allow "o".
3430
3431 2019-06-13  Pedro Alves  <palves@redhat.com>
3432
3433         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3434         * NEWS: Mention maint test-settings KIND.
3435         * maint-test-settings.c: New file.
3436
3437 2019-06-13  Pedro Alves  <palves@redhat.com>
3438
3439         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3440         completer.
3441         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3442         "set" completers.
3443
3444 2019-06-13  Pedro Alves  <palves@redhat.com>
3445
3446         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3447         after item.
3448
3449 2019-06-13  Pedro Alves  <palves@redhat.com>
3450
3451         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3452
3453 2019-06-13  Pedro Alves <palves@redhat.com>
3454
3455         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3456         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3457         call.
3458         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3459         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3460         calls.
3461         (check_for_argument): Skip spaces after argument.
3462
3463 2019-06-13  Pedro Alves  <palves@redhat.com>
3464
3465         * thread.c (thread_apply_command): Adjust TID parsing.
3466         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3467         detected before end of string.
3468         (tid_is_in_list): Error out if LIST is invalid.
3469
3470 2019-06-13  Pedro Alves  <palves@redhat.com>
3471
3472         * completer.c (complete_line_internal_1): Rewind completion word
3473         point.
3474         (completion_tracker::advance_custom_word_point_by): Change
3475         parameter type to int.
3476         * completer.h (completion_tracker::advance_custom_word_point_by):
3477         Likewise.
3478
3479 2019-06-13  Pedro Alves  <palves@redhat.com>
3480
3481         * completer.c (advance_to_completion_word): Handle delimiters.
3482
3483 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3484
3485         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3486
3487 2019-06-11  Tom Tromey  <tom@tromey.com>
3488
3489         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3490         (xmalloc_failed): Move to alloc.c.
3491         * alloc.c: New file.
3492         * Makefile.in (COMMON_SFILES): Add alloc.c.
3493
3494 2019-06-11  Tom Tromey  <tom@tromey.com>
3495
3496         * nat/linux-waitpid.c: Don't include server.h.
3497         (linux_debug): Remove.
3498         (my_waitpid): Update.
3499
3500 2019-06-11  Tom Tromey  <tromey@adacore.com>
3501
3502         * infcall.c (_initialize_infcall): Remove trailing newline from
3503         help.
3504         * user-regs.c (_initialize_user_regs): Remove trailing newline
3505         from help.
3506         * typeprint.c (_initialize_typeprint): Remove trailing newline
3507         from help.
3508         * reverse.c (_initialize_reverse): Remove trailing newlines from
3509         help.
3510         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3511         from help.
3512         * language.c (add_set_language_command): Remove trailing newline
3513         from help.
3514         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3515         help.
3516         * disasm.c (_initialize_disasm): Remove trailing newline from
3517         help.
3518         * top.c (init_main): Remove trailing newline from help.
3519         * interps.c (_initialize_interpreter): Remove trailing newline
3520         from help.
3521         * btrace.c (_initialize_btrace): Remove trailing newlines from
3522         help.
3523         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3524         from help.
3525         * python/python.c (_initialize_python): Remove trailing newline
3526         from help.
3527         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3528         help.
3529         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3530         from help.  Reformat some text.
3531         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3532         from help.
3533         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3534         newline from help.
3535
3536 2019-06-11  Tom Tromey  <tromey@adacore.com>
3537
3538         * darwin-nat.c (darwin_decode_exception_message)
3539         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3540
3541 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3542
3543         * valops.c (value_slice): Check for not allocated or not
3544         associated values.
3545
3546 2019-06-10  Tom de Vries  <tdevries@suse.de>
3547
3548         PR gdb/24618
3549         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3550         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3551         invalid.
3552
3553 2019-06-10  Tom de Vries  <tdevries@suse.de>
3554
3555         PR gdb/24611
3556         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3557         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3558
3559 2019-06-10  Tom de Vries  <tdevries@suse.de>
3560
3561         PR symtab/24545
3562         * symtab.c (struct demangled_name_entry): Add language field.
3563         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3564         static minimal symbol".  Set and use language field.
3565
3566 2019-06-10  Tom Tromey  <tromey@adacore.com>
3567
3568         * ada-lang.c (_initialize_ada_language): Update help text.
3569
3570 2019-06-10  Tom Tromey  <tromey@adacore.com>
3571
3572         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3573         with a newline.
3574         * guile/guile.c (handle_boot_error): Don't end warning with a
3575         newline.
3576         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3577         warning with a newline.
3578         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3579         newline.
3580         (s12z_frame_cache): Likewise.
3581         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3582         a newline.
3583         * solib-svr4.c (disable_probes_interface): Don't end warning with
3584         a newline.
3585         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3586         newline.
3587         * python/python.c (do_finish_initialization): Don't end warning
3588         with a newline.
3589
3590 2019-06-10  Tom Tromey  <tom@tromey.com>
3591
3592         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3593         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3594         gdbpy_enter.
3595
3596 2019-06-10  Tom Tromey  <tromey@adacore.com>
3597
3598         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3599         data.
3600         (elf_new_init): Don't call stabsread_new_init.
3601         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3602         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3603         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3604
3605 2019-06-10  Tom de Vries  <tdevries@suse.de>
3606
3607         PR symtab/16264
3608         PR symtab/24517
3609         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3610
3611 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3612
3613         * source.c (find_and_open_source): Also rewrite relative file
3614         names.
3615
3616 2019-04-26  Amos Bird  <amosbird@gmail.com>
3617
3618         * annotate.c (annotate_thread_exited): Add "thread-exited"
3619         annotation.
3620
3621 2019-06-06  Tom Tromey  <tromey@adacore.com>
3622
3623         * maint.h (class scoped_command_stats): Use
3624         DISABLE_COPY_AND_ASSIGN.
3625         <print_time>: New method.
3626         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3627         print_time.
3628         (scoped_command_stats::print_time): New method.
3629
3630 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3631
3632         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3633         instructions of lengths 6 or 8 bytes.
3634
3635 2019-06-04  Pedro Alves  <palves@redhat.com>
3636
3637         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3638
3639         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3640         * breakpoint.c (condition_completer): Likewise.
3641         * cli/cli-dump.c (scan_expression): Likewise.
3642         * common/filestuff.c (mkdir_recursive): Likewise.
3643         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3644         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3645         (gdb_abspath): Likewise.
3646         * compile/compile-cplus-types.c
3647         (compile_cplus_instance::decl_name): Likewise.
3648         * completer.c (complete_explicit_location):
3649         (signal_completer, reg_or_group_completer_1): Likewise.
3650         * cp-support.c (cp_remove_params_if_any): Likewise.
3651         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3652         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3653         * infcmd.c (strip_bg_char): Likewise.
3654         * linespec.c (copy_token_string): Likewise.
3655         * mi/mi-main.c (output_cores): Likewise.
3656         * psymtab.c (psymtab_search_name):
3657         * symfile.c (test_set_ext_lang_command): Likewise.
3658         * target.c (target_fileio_read_stralloc): Likewise.
3659         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3660         * value.c (complete_internalvar): Likewise.
3661
3662 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3663
3664         Add objfile property to gdb.Type.
3665         * NEWS: Mention Python API addition.
3666         * python/py-type.c (typy_get_objfile): New method.
3667
3668 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3669
3670         * NEWS: Mention the new set|show style [title|highlight].
3671         Mention changes to "show style", "help" and "apropos".
3672
3673 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3674
3675         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3676         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3677         instead of print_help_for_command.
3678         (print_doc_of_command): New function.
3679         (help_list): Add 'apropos -v word' suggestion.
3680         (print_help_for_command): Style the command name using title style.
3681         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3682         (_initialize_cli_cmds): Describe -v in apropos_command help.
3683
3684 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3685
3686         * cli/cli-style.h (cli_style_option): Add name in constructor,
3687         add m_name class member, add constructor with intensity,
3688         add name class function.
3689         (cli_style_option::add_setshow_commands): Remove name argument.
3690         (highlight_style, title_style): New styles.
3691         * cli/cli-style.c (do_show): New function that shows a style
3692         characteristic styling the style name with itself.
3693         (set_style_name): New function.
3694         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3695         Update all callers according to the changes in cli/cli-style.h.
3696         * utils.h (fputs_highlighted): New function.
3697         * utils.c (fputs_highlighted): Likewise.
3698
3699 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3700
3701         * NEWS: Mention new pipe command and new convenience variables.
3702
3703 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3704
3705         * cli/cli-cmds.c (pipe_command): New function.
3706         (_initialize_cli_cmds): Call add_com for pipe_command.
3707         Define | as an alias for pipe.
3708         (exit_status_set_internal_vars): New function.
3709         (shell_escape): Call exit_status_set_internal_vars.
3710         cli/cli-decode.c (find_command_name_length): Recognize | as
3711         a single character command.
3712
3713 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3714
3715         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3716         top.c (execute_command_to_ui_file): New function, mostly a copy
3717         of execute_command_to_string.
3718         (execute_command_to_string): Implement by calling
3719         execute_command_to_ui_file.
3720
3721 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3722
3723         * top.h (saved_command_line): Remove declaration.
3724         * top.c (previous_saved_command_line, previous_repeat_arguments):
3725         New variables.
3726         (saved_command_line): Make static, define together with other
3727         'repeat variables'.
3728         (dont_repeat): Clear repeat_arguments.
3729         (repeat_previous, get_saved_command_line, save_command_line):
3730         New functions.
3731         (gdb_init): Initialize saved_command_line
3732         and previous_saved_command_line.
3733         * main.c (captured_main_1): Remove saved_command_line initialization.
3734         * event-top.c (handle_line_of_input): Update to use
3735         the new 'repeat' related functions instead of direct access to
3736         saved_command_line.
3737         * command.h (repeat_previous, get_saved_command_line,
3738         save_command_line): New declarations.
3739         (dont_repeat): Add comment.
3740
3741 2019-05-30  Tom Tromey  <tromey@adacore.com>
3742
3743         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3744         Fix comment.
3745         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3746
3747 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3748
3749         PR cli/24587
3750         * completer.c (complete): Initialize variable word.
3751
3752 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3753
3754         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3755         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3756         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3757         'body' is NULL to the outter 'if', protecting the '!is_define'
3758         situation as well.
3759
3760 2019-05-29  Tom Tromey  <tromey@adacore.com>
3761
3762         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3763         (dwarf_unknown): New function.
3764         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3765         (dwarf_type_encoding_name): Use dwarf_unknown.
3766
3767 2019-05-29  Tom Tromey  <tromey@adacore.com>
3768
3769         PR c++/20020:
3770         * cp-valprint.c (cp_print_value_fields): Call
3771         cp_print_static_field inside "try".
3772
3773 2019-05-29  Tom Tromey  <tromey@adacore.com>
3774
3775         * inflow.c (struct terminal_info): Add default operator=.
3776         * configure: Rebuild.
3777         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3778         -Wdeprecated-copy-dtor, -Wredundant-move.
3779
3780 2019-05-29  Tom Tromey  <tromey@adacore.com>
3781
3782         * NEWS: Add entry.
3783         * infcmd.c (print_return_value_1): Handle finish_print
3784         option.
3785         (show_print_finish): New function.
3786         (_initialize_infcmd): Add "set/show print finish" commands.
3787         * valprint.c (user_print_options): Initialize new member.
3788         * valprint.h (struct value_print_options) <finish_print>: New
3789         member.
3790
3791 2019-05-28  Tom Tromey  <tromey@adacore.com>
3792
3793         * ada-lang.c (ada_remove_Xbn_suffix)
3794         (find_old_style_renaming_symbol)
3795         (parse_old_style_renaming): Remove.
3796         (ada_find_renaming_symbol): Don't call
3797         find_old_style_renaming_symbol.
3798         (ada_is_renaming_symbol): Rename from
3799         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3800         bool.  Now static.
3801         (ada_read_var_value): Update and simplify.
3802         * ada-exp.y (write_var_or_type): Remove old code.
3803
3804 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3805
3806         * event-top.c: Remove include comment.
3807         * inflow.c (class scoped_ignore_sigttou): Move from here...
3808         * inflow.h (class scoped_ignore_sigttou): ...to here.
3809         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3810         * top.c:  Remove include comment.
3811
3812 2019-05-27  Tom Tromey  <tom@tromey.com>
3813
3814         * NEWS: Fix typo.
3815
3816 2019-05-22  Tom Tromey  <tromey@adacore.com>
3817
3818         * target.c (target_follow_exec): Constify parameter.
3819         * target-delegates.c: Rebuild.
3820         * remote.c (remote_target::follow_exec): Constify parameter.
3821         * infrun.c (follow_exec): Constify parameter.
3822         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3823         (target_follow_exec): Likewise.
3824
3825 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3826
3827         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3828         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3829
3830 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3831
3832         * NEWS: Add debugredirect and testsuite sections.
3833
3834 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3835
3836         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3837         target descriptions using exclusively floating point register name
3838         aliases.
3839
3840 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3841
3842         PR gdb/18644:
3843         * f-lang.c (build_fortran_types): Handle the case where
3844         gdbarch_floatformat_for_type returns a nullptr.
3845
3846 2019-05-21  Tom de Vries  <tdevries@suse.de>
3847
3848         PR cli/24587
3849         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3850
3851 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3852
3853         PR gdb/18644:
3854         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3855         16-byte floats.
3856         * i386-tdep.c (i386_floatformat_for_type): Use
3857         floatformats_ia64_quad for the 16-byte floating point component
3858         within a fortran 32-byte complex number.
3859
3860 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3861
3862         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3863         delete default constructor.
3864         (find_partial_die): Update to return const struct.
3865         (partial_die_parent_scope): Move variable declaration into scope
3866         of its use and change its type to auto.
3867         (guess_partial_die_structure_name): Likewise.
3868         (partial_die_info::fixup): Likewise.
3869
3870 2019-05-17  Tom Tromey  <tromey@adacore.com>
3871
3872         * source.c (find_and_open_source): Remove cast.
3873
3874 2019-05-17  Tom Tromey  <tromey@adacore.com>
3875
3876         * annotate.c (annotate_source): Make "filename" const.
3877         * annotate.h (annotate_source): Use const.
3878
3879 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3880
3881         * disasm.c (set_disassembler_options): Send errors to stderr.
3882
3883 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3884
3885         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3886         (cli_interp_base::set_logging): Check debug_redirect.
3887         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3888         * cli/cli-logging.c (debug_redirect): Add static variable.
3889         (pop_output_files): Add default param.
3890         (handle_redirections): Print debug setting.
3891         (show_logging_command): Likewise.
3892         (_initialize_cli_logging): Add debugredirect command.
3893         * interps.c (current_interp_set_logging): Add debug_redirect
3894         parameter.
3895         * interps.h (set_logging): Add debug_redirect parameter.
3896         (current_interp_set_logging): Likewise.
3897         * mi/mi-common.h: Likewise.
3898         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3899
3900 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3901             Tom Tromey  <tromey@adacore.com>
3902
3903         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3904         directly.
3905         * cli/cli-interp.h (make_logging_output): Remove declaration.
3906         * cli/cli-logging.c (make_logging_output): Remove function.
3907         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3908         directly.
3909         * ui-file.c (tee_file::tee_file): Remove bools.
3910         (tee_file::~tee_file): Remove deletes.
3911         * ui-file.h (tee_file): Remove bools.
3912
3913 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3914
3915         * mi/mi-cmds.h (mi_cmd_complete): New function.
3916         * mi/mi-main.c (mi_cmd_complete): Likewise.
3917         * mi/mi-cmds.c: Define new MI command -complete.
3918         * NEWS: Mention new -complete command.
3919
3920 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3921
3922         * completer.h (complete): New function.
3923         * completer.c (complete): Likewise.
3924         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3925         function defined in completer.h.
3926
3927 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3928
3929         * MAINTAINERS (Write After Approval): Add myself.
3930
3931 2019-05-17  Tom de Vries  <tdevries@suse.de>
3932
3933         PR gdb/24094
3934         * dwarf2read.c (struct cu_partial_die_info): New struct.
3935         (find_partial_die): Return cu_partial_die_info.
3936         (partial_die_parent_scope, guess_partial_die_structure_name)
3937         (partial_die_info::fixup): Handle new return type of find_partial_die.
3938
3939 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3940
3941         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3942         "std::string", simplifying the algorithm.
3943
3944 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3945
3946         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3947         (stap_static_probe_ops::get_probes): Likewise.
3948
3949 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3950
3951         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3952         '-')" and "else if".
3953         (stap_parse_single_operand): Join checks for
3954         "gdbarch_stap_parse_special_token_p" and
3955         "gdbarch_stap_parse_special_token" in the same "if" statement.
3956         Invert check when verifying for operation on register
3957         displacement.
3958
3959 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3960
3961         * stap-probe.c (stap_get_opcode): Update comment.
3962         (stap_get_expected_argument_type): Likewise.
3963         (handle_stap_probe): Likewise.
3964
3965 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3966
3967         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3968         return type to 'bool'.  Adjust comment.  Use 'bool' when
3969         appropriate.
3970         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3971         * stap-probe.c (stap_parse_argument_1): Likewise.
3972         (stap_is_operator): Likewise.
3973         (stap_is_generic_prefix): Likewise.
3974         (stap_is_register_prefix): Likewise.
3975         (stap_is_register_indirection_prefix): Likewise.
3976         (stap_is_integer_prefix): Likewise.
3977         (stap_generic_check_suffix): Likewise.
3978         (stap_check_integer_suffix): Likewise.
3979         (stap_check_register_suffix): Likewise.
3980         (stap_check_register_indirection_suffix): Likewise.
3981         (stap_parse_register_operand): Likewise.
3982         (stap_parse_single_operand): Likewise.
3983         (stap_parse_argument_1): Likewise.
3984         (stap_probe::get_argument_count): Likewise.
3985         (stap_is_operator): Likewise.
3986
3987 2019-05-16  Tom Tromey  <tromey@adacore.com>
3988
3989         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3990         keyword to foreach.
3991
3992 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3993
3994         * linux-thread-db.c (try_thread_db_load_1): Change return type
3995         to bool.
3996         (try_thread_db_load): Likewise.
3997         (try_thread_db_load_from_pdir_1): Likewise.
3998         (try_thread_db_load_from_pdir): Likewise.
3999         (try_thread_db_load_from_sdir): Likewise.
4000         (try_thread_db_load_from_dir): Likewise.
4001         (thread_db_load_search): Likewise.
4002         (has_libpthread): Likewise.
4003         (thread_db_load): Likewise.
4004
4005 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
4006
4007         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4008         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4009         NULL, and complain/return if that's the case.
4010
4011 2019-05-15  John Darrington <john@darrington.wattle.id.au>
4012
4013         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4014         (advance, posn, abstract_read_memory): New functions.
4015         [struct mem_read_abstraction]: New struct.
4016         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4017
4018 2019-05-14  Tom Tromey  <tromey@adacore.com>
4019
4020         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4021         value is not lval_memory.
4022
4023 2019-05-14  Tom Tromey  <tromey@adacore.com>
4024
4025         * solib.c (info_sharedlibrary_command): Style the file name.
4026
4027 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
4028
4029         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4030         (aarch64_vnv_type): Likewise.
4031         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4032         * common/tdesc.c: Likewise.
4033         * common/tdesc.h (enum tdesc_type_kind): Likewise.
4034         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
4035         * features/aarch64-fpu.xml: Add ieee half view.
4036         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
4037         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
4038         * gdbtypes.h (struct builtin_type): Likewise.
4039         (struct objfile_type): Likewise.
4040
4041 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
4042
4043         * language.c (language_sniff_from_mangled_name): Fix "langauge"
4044         typo.
4045         * location.h (string_to_event_location): Likewise.
4046
4047 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
4048
4049         GDB 8.3 released.
4050
4051 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4052
4053         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4054         New variable declaration.
4055         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
4056         New variable.
4057         (print_one_breakpoint): Use ui_out::test_flags and new global
4058         variable to compute use_fixed_output.
4059         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
4060         Remove.
4061         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4062         (mi_multi_location_breakpoint_output_fixed): Remove.
4063         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4064         new variable.
4065         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4066         fix_multi_location_breakpoint_output flag if version >= 3.
4067         * ui-out.h (enum ui_out_flag)
4068         <fix_multi_location_breakpoint_output>: New enumerator.
4069
4070 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4071
4072         * contrib/cc-with-tweaks.sh: Validate dwz's work.
4073
4074 2019-05-10  Tom Tromey  <tromey@adacore.com>
4075
4076         * ada-lang.c (catch_ada_completer): New function.
4077         (_initialize_ada_language): Use it.
4078
4079 2019-05-10  Tom Tromey  <tromey@adacore.com>
4080
4081         * thread.c (print_thread_info): Make "requested_threads" const.
4082         * gdbthread.h (print_thread_info): Make "requested_threads"
4083         const.
4084         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4085         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4086
4087 2019-05-08  Tom Tromey  <tom@tromey.com>
4088
4089         * gdbtypes.c (objfile_type_data): Change type.
4090         (objfile_type, _initialize_gdbtypes): Update.
4091
4092 2019-05-08  Tom Tromey  <tom@tromey.com>
4093
4094         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4095         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4096         (_initialize_dwarf2_frame): Update.
4097
4098 2019-05-08  Tom Tromey  <tom@tromey.com>
4099
4100         * objc-lang.c (objc_objfile_data): Change type.
4101         (find_methods): Update.
4102         (_initialize_objc_lang): Remove.
4103
4104 2019-05-08  Tom Tromey  <tom@tromey.com>
4105
4106         * stabsread.c (rs6000_builtin_type_data): Change type.
4107         (rs6000_builtin_type, _initialize_stabsread): Update.
4108
4109 2019-05-08  Tom Tromey  <tom@tromey.com>
4110
4111         * mips-tdep.c (mips_pdr_data): Remove.
4112         (_initialize_mips_tdep): Update.
4113
4114 2019-05-08  Tom Tromey  <tom@tromey.com>
4115
4116         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4117         (hppa_init_objfile_priv_data, read_unwind_info)
4118         (find_unwind_entry, _initialize_hppa_tdep): Update.
4119
4120 2019-05-08  Tom Tromey  <tom@tromey.com>
4121
4122         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4123         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
4124         on obstack.
4125         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4126
4127 2019-05-08  Tom Tromey  <tom@tromey.com>
4128
4129         * mdebugread.c (basic_type_data): Change type.
4130         (basic_type, _initialize_mdebugread): Update.
4131
4132 2019-05-08  Tom Tromey  <tom@tromey.com>
4133
4134         * common/gdb_unique_ptr.h (struct noop_deleter): New.
4135
4136 2019-05-08  Tom Tromey  <tom@tromey.com>
4137
4138         * nto-tdep.c (nto_inferior_data_reg): Change type.
4139         (nto_inferior_data): Update.
4140         (nto_inferior_data_cleanup, nto_new_inferior_data)
4141         (_initialize_nto_tdep): Remove.
4142         * nto-tdep.h (struct nto_inferior_data): Add initializers.
4143
4144 2019-05-08  Tom Tromey  <tom@tromey.com>
4145
4146         * ada-lang.c (struct ada_inferior_data): Add initializers.
4147         (ada_inferior_data): Change type.
4148         (ada_inferior_data_cleanup): Remove.
4149         (get_ada_inferior_data, ada_inferior_exit)
4150         (struct ada_pspace_data): Add initializers, destructor.
4151         (ada_pspace_data_handle): Change type.
4152         (get_ada_pspace_data): Update.
4153         (ada_pspace_data_cleanup): Remove.
4154
4155 2019-05-08  Tom Tromey  <tom@tromey.com>
4156
4157         * coffread.c (struct coff_symfile_info): Add initializers.
4158         (coff_objfile_data_key): Move lower.  Change type.
4159         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4160         Update.
4161         (coff_free_info): Remove.
4162
4163 2019-05-08  Tom Tromey  <tom@tromey.com>
4164
4165         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4166         (fbsd_pspace_data_handle): Move lower.  Change type.
4167         (get_fbsd_pspace_data): Update.
4168         (fbsd_pspace_data_cleanup): Remove.
4169         (_initialize_fbsd_tdep): Update.
4170
4171 2019-05-08  Tom Tromey  <tom@tromey.com>
4172
4173         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4174         (get_ada_tasks_pspace_data): Update.
4175         (ada_tasks_pspace_data_cleanup): Remove.
4176         (_initialize_tasks): Update.
4177         (ada_tasks_inferior_data_handle): Change type.
4178         (get_ada_tasks_inferior_data): Update.
4179         (ada_tasks_inferior_data_cleanup): Remove.
4180         (struct ada_tasks_pspace_data): Add initializers.
4181
4182 2019-05-08  Tom Tromey  <tom@tromey.com>
4183
4184         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4185         * symfile-debug.c (debug_sym_get_probes): Change type.
4186         * stap-probe.c (handle_stap_probe):
4187         (stap_static_probe_ops::get_probes): Change type.
4188         * probe.h (class static_probe_ops) <get_probes>: Change type.
4189         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4190         (parse_probes_in_pspace): Update.
4191         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4192         Update.
4193         (any_static_probe_ops::get_probes): Change type.
4194         * elfread.c (elfread_data): New typedef.
4195         (probe_key): Change type.
4196         (elf_get_probes): Likewise.  Update.
4197         (probe_key_free): Remove.
4198         (_initialize_elfread): Update.
4199         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4200         Change type.
4201         (dtrace_process_dof_probe, dtrace_process_dof)
4202         (dtrace_static_probe_ops::get_probe): Change type.
4203
4204 2019-05-08  Tom Tromey  <tom@tromey.com>
4205
4206         * xcoffread.c (struct xcoff_symfile_info): Rename from
4207         coff_symfile_info.  Add initializers.
4208         (xcoff_objfile_data_key): Move lower.  Change type.
4209         (XCOFF_DATA): Rewrite.
4210         (xcoff_free_info): Remove.
4211         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4212         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4213         (xcoff_initial_scan): Update.
4214
4215 2019-05-08  Tom Tromey  <tom@tromey.com>
4216
4217         * solib-svr4.c (struct svr4_info): Add initializers and
4218         destructor.
4219         <probes_table>: Now an htab_up.
4220         (solib_svr4_pspace_data): Change type.
4221         (free_probes_table): Simplify.
4222         (~svr4_info): Rename from svr4_pspace_data_cleanup.
4223         (get_svr4_info, probes_table_htab_remove_objfile_probes)
4224         (probes_table_remove_objfile_probes, register_solib_event_probe)
4225         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4226         (_initialize_svr4_solib): Update.
4227
4228 2019-05-08  Tom Tromey  <tom@tromey.com>
4229
4230         * remote.c (remote_pspace_data): Change type.
4231         (remote_pspace_data_cleanup): Remove.
4232         (get_remote_exec_file, set_pspace_remote_exec_file)
4233         (_initialize_remote): Update.
4234
4235 2019-05-08  Tom Tromey  <tom@tromey.com>
4236
4237         * breakpoint.c (breakpoint_objfile_key): Change type.
4238         (get_breakpoint_objfile_data): Update.
4239         (free_breakpoint_objfile_data): Remove.
4240         (_initialize_breakpoint): Update.
4241
4242 2019-05-08  Tom Tromey  <tom@tromey.com>
4243
4244         * linux-tdep.c (struct linux_info): Add initializers.
4245         (linux_inferior_data): Move.  Change type.
4246         (invalidate_linux_cache_inf): Update.
4247         (linux_inferior_data_cleanup): Remove.
4248         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4249
4250 2019-05-08  Tom Tromey  <tom@tromey.com>
4251
4252         * auxv.c (auxv_inferior_data): Move.  Change type.
4253         (auxv_inferior_data_cleanup): Remove.
4254         (invalidate_auxv_cache_inf): Rewrite.
4255         (get_auxv_inferior_data, _initialize_auxv): Update.
4256
4257 2019-05-08  Tom Tromey  <tom@tromey.com>
4258
4259         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4260         (symfile_debug_objfile_data_key): Change type.
4261         (symfile_debug_installed, debug_qf_has_symbols)
4262         (debug_qf_find_last_source_symtab)
4263         (debug_qf_forget_cached_source_info)
4264         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4265         (debug_qf_print_stats, debug_qf_dump)
4266         (debug_qf_expand_symtabs_for_function)
4267         (debug_qf_expand_all_symtabs)
4268         (debug_qf_expand_symtabs_with_fullname)
4269         (debug_qf_map_matching_symbols)
4270         (debug_qf_expand_symtabs_matching)
4271         (debug_qf_find_pc_sect_compunit_symtab)
4272         (debug_qf_map_symbol_filenames)
4273         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4274         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4275         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4276         (debug_sym_read_linetable, debug_sym_relocate): Update.
4277         (symfile_debug_free_objfile): Remove.
4278         (install_symfile_debug_logging, _initialize_symfile_debug):
4279         Update.
4280
4281 2019-05-08  Tom Tromey  <tom@tromey.com>
4282
4283         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4284         allocate_on_obstack.
4285         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4286         (get_dwarf2_per_objfile): Update.
4287         (set_dwarf2_per_objfile): Remove.
4288         (dwarf2_has_info, dwarf2_get_section_info): Update.
4289         (dwarf2_free_objfile): Remove.
4290         (_initialize_dwarf2_read): Update.
4291
4292 2019-05-08  Tom Tromey  <tom@tromey.com>
4293
4294         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4295         initializers.
4296         <unsupported_script_warning_printed,
4297         script_not_found_warning_printed>: Now bool.
4298         (auto_load_pspace_data): Change type.
4299         (~auto_load_pspace_info): Rename from
4300         auto_load_pspace_data_cleanup.
4301         (get_auto_load_pspace_data, init_loaded_scripts_info)
4302         (clear_section_scripts, maybe_print_unsupported_script_warning)
4303         (maybe_print_script_not_found_warning, _initialize_auto_load):
4304         Update.
4305
4306 2019-05-08  Tom Tromey  <tom@tromey.com>
4307
4308         * objfiles.c (objfile_pspace_info): Add destructor and
4309         initializers.
4310         (objfiles_pspace_data): Change type.
4311         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4312         (get_objfile_pspace_data): Update.
4313         (objfiles_bfd_data): Change type.
4314         (get_objfile_bfd_data): Update.
4315         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4316
4317 2019-05-08  Tom Tromey  <tom@tromey.com>
4318
4319         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4320         Change type.
4321         (get_catch_syscall_inferior_data): Update.
4322         (catch_syscall_inferior_data_cleanup): Remove.
4323         (_initialize_break_catch_syscall): Update.
4324
4325 2019-05-08  Tom Tromey  <tom@tromey.com>
4326
4327         * inflow.c (struct terminal_info): Add destructor and
4328         initializers.
4329         (inflow_inferior_data): Change type.
4330         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4331         (get_inflow_inferior_data, inflow_inferior_exit)
4332         (swap_terminal_info, _initialize_inflow): Update.
4333
4334 2019-05-08  Tom Tromey  <tom@tromey.com>
4335
4336         * target-dcache.c (target_dcache_cleanup): Remove.
4337         (target_dcache_aspace_key): Change type.
4338         (target_dcache_init_p, target_dcache_invalidate)
4339         (target_dcache_get, target_dcache_get_or_init)
4340         (_initialize_target_dcache): Update.
4341         * dcache.h (struct dcache_deleter): New.
4342
4343 2019-05-08  Tom Tromey  <tom@tromey.com>
4344
4345         * symtab.c (struct symbol_cache): Add destructor and
4346         initializers.
4347         (symbol_cache_key): Move.  Change type.
4348         (make_symbol_cache, free_symbol_cache): Remove.
4349         (get_symbol_cache): Update.
4350         (symbol_cache_cleanup): Remove.
4351         (ALL_PSPACES, symbol_cache_flush)
4352         (maintenance_print_symbol_cache)
4353         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4354         Update.
4355
4356 2019-05-08  Tom Tromey  <tom@tromey.com>
4357
4358         * symtab.c (struct main_info): Add destructor and initializers.
4359         (main_progspace_key): Move.  Change type.
4360         (get_main_info): Update.
4361         (main_info_cleanup): Remove.
4362         (_initialize_symtab): Update.
4363
4364 2019-05-08  Tom Tromey  <tom@tromey.com>
4365
4366         * registry.h (DECLARE_REGISTRY): Define the _key class.
4367
4368 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4369
4370         * NEWS: Merge two 'New commands' sections.
4371
4372 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4373
4374         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4375         parameter and use Ada language definition instead.
4376         (ada_val_print_ptr): Remove unused language parameter.
4377         (ada_val_print_num): Remove language parameter and use Ada language
4378         definition instead.
4379         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4380         parameter.
4381         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4382         parameter and use Ada language definition instead.
4383         (ada_val_print_1): Update all ada_val_print_xxx calls.
4384         Remove language parameter.
4385         (ada_val_print): Update ada_val_print_1 call.
4386
4387 2019-05-08  Tom Tromey  <tromey@adacore.com>
4388
4389         * remote.c (remote_hw_watchpoint_limit)
4390         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4391         Now static.
4392
4393 2019-05-08  Tom Tromey  <tromey@adacore.com>
4394
4395         * maint.c (_initialize_maint_cmds): Move initialization code to
4396         remote.c.
4397         (watchdog, show_watchdog): Move to remote.c.
4398         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4399         "watchdog" static.
4400         (_initialize_remote): Move initialization code from maint.c.
4401         * defs.h (watchdog): Don't declare.
4402
4403 2019-05-08  Tom Tromey  <tromey@adacore.com>
4404
4405         * tui/tui-interp.c: Include main.h.
4406         * interps.c: Include main.h.
4407         * main.h (interpreter_p): Declare.
4408         * defs.h (interpreter_p): Don't declare.
4409
4410 2019-05-08  Tom Tromey  <tromey@adacore.com>
4411
4412         * dwarf2loc.c: Include dwarf2read.h.
4413         * defs.h (read_unsigned_leb128): Don't declare.
4414         * dwarf2read.h (read_unsigned_leb128): Declare.
4415
4416 2019-05-08  Tom Tromey  <tromey@adacore.com>
4417
4418         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4419         method.
4420
4421 2019-05-08  Tom Tromey  <tromey@adacore.com>
4422
4423         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4424         when no wrap column is set.
4425
4426 2019-05-08  Tom Tromey  <tromey@adacore.com>
4427
4428         * c-lang.c (c_get_string): Handle non-C-style arrays.
4429
4430 2019-05-08  Tom Tromey  <tromey@adacore.com>
4431
4432         * typeprint.c (print_offset_data::update): Print the bit offset,
4433         not the number of bits remaining.
4434
4435 2019-05-08  Tom Tromey  <tromey@adacore.com>
4436
4437         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4438         padding at end of comment.
4439
4440 2019-05-08  Tom Tromey  <tromey@adacore.com>
4441
4442         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4443         Compare main types.
4444
4445 2019-05-06  Tom Tromey  <tom@tromey.com>
4446
4447         * common/scoped_mmap.c: Include common-defs.h.
4448         * common/scoped_mmap.h: Don't include config.h.
4449
4450 2019-05-04  Tom Tromey  <tom@tromey.com>
4451
4452         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4453         (struct aarch64_call_info): Add initializers.
4454         <si>: Now a std::vector.
4455         (pass_on_stack, aarch64_push_dummy_call): Update.
4456
4457 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4458             Tom Tromey  <tom@tromey.com>
4459
4460         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4461         (ppc_threads): Now a std::vector.  Now static.
4462         (hwdebug_find_thread_points_by_tid)
4463         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4464         Update.
4465
4466 2019-05-04  Tom Tromey  <tom@tromey.com>
4467
4468         * arc-tdep.c (arc_tdesc_init): Return bool.
4469
4470 2019-05-04  Tom Tromey  <tom@tromey.com>
4471
4472         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4473         Use gdb_assert_not_reached.
4474
4475 2019-05-04  Tom Tromey  <tom@tromey.com>
4476
4477         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4478         "false".
4479
4480 2019-05-04  Tom Tromey  <tom@tromey.com>
4481
4482         * arc-tdep.c (arc_tdesc_init): Use bool.
4483
4484 2019-05-04  Tom Tromey  <tom@tromey.com>
4485
4486         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4487
4488 2019-05-04  Tom Tromey  <tom@tromey.com>
4489
4490         * cli/cli-cmds.c (valid_command_p): Return bool.
4491
4492 2019-05-04  Tom Tromey  <tom@tromey.com>
4493
4494         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4495         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4496
4497 2019-05-04  Raul Tambre  <raul@tambre.ee>
4498
4499         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4500         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4501         operator for comparison.
4502
4503 2019-05-04  Tom Tromey  <tom@tromey.com>
4504
4505         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4506         (lookup_partial_symbol, print_partial_symbols)
4507         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4508         (psymbol_compare): Update.
4509         (add_psymbol_to_bcache): Clear the entire psymbol.
4510         (maintenance_check_psymtabs): Update.
4511         * psympriv.h (struct partial_symbol): Don't derive from
4512         general_symbol_info.
4513         <obj_section, unrelocated_address, address,
4514         set_unrelocated_address>: Update.
4515         <ginfo>: New member.
4516         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4517         (debug_names::write_psymbols): Update.
4518
4519 2019-05-04  Tom de Vries  <tdevries@suse.de>
4520
4521         * contrib/cc-with-tweaks.sh: Support -n arg.
4522
4523 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4524
4525         * corelow.c (core_target::detach): Ensure frame cache and
4526         register caches are cleared.
4527         inferior.c (exit_inferior_1): Likewise.
4528
4529 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4530             Tom Tromey  <tom@tromey.com>
4531
4532         * dictionary.c (collate_pending_symbols_by_language): Remove
4533         "struct" from foreach.
4534         * symtab.c (lookup_global_symbol_from_objfile)
4535         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4536         foreach.
4537         * ser-tcp.c (net_open): Remove "struct" from foreach.
4538         * objfiles.c (objfile_relocate, objfile_rebase)
4539         (objfile_has_symbols): Remove "struct" from foreach.
4540         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4541         from foreach.
4542         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4543         foreach.
4544         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4545         "struct" from foreach.
4546         * ada-lang.c (create_excep_cond_exprs)
4547         (ada_exception_catchpoint_cond_string): Remove "struct" from
4548         foreach.
4549
4550 2019-05-03  Tom Tromey  <tromey@adacore.com>
4551
4552         * ada-exp.y (convert_char_literal): Check suffix of each
4553         enumerator.
4554
4555 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4556
4557         PR ada/21406:
4558         * ada-exp.y (yywrap): Don't define.
4559         * ada-lex.l (%option): Add noyywrap
4560         (yywrap): Remove.
4561
4562 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4563
4564         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4565         _WIN32_WINNT to the XP level, unless already defined to a higher
4566         level.
4567
4568         * unittests/parse-connection-spec-selftests.c:
4569         * ser-tcp.c:
4570         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4571         override.
4572
4573         * symfile.c (find_separate_debug_file): Remove colon from the
4574         drive spec of DOS/Windows file names of the target, so that the
4575         file name produced from DEBUGDIR and the target's directory will
4576         be valid on DOS/Windows systems.
4577
4578 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4579
4580         * rust-lang.c (val_print_struct): Handle printing structures
4581         containing strings.
4582
4583 2019-05-02  Tom Tromey  <tromey@adacore.com>
4584
4585         * valarith.c (_initialize_valarith): Remove.
4586
4587 2019-05-01  Tom Tromey  <tromey@adacore.com>
4588
4589         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4590         bitfields.
4591
4592 2019-05-01  Tom Tromey  <tromey@adacore.com>
4593
4594         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4595         for big-endian copies.
4596
4597 2019-04-30  Ali Tamur  <tamur@google.com>
4598         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4599         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4600         (read_3_bytes): New function.
4601
4602 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4603
4604         * windows-nat.c (main_thread_id): Delete.
4605         (handle_output_debug_string): Replace main_thread_id by
4606         current_event.dwThreadId.
4607         (fake_create_process): Likewise.
4608         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4609         Do not set main_thread_id.
4610         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4611         current_event.dwThreadId.
4612         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4613
4614 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4615
4616         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4617         Use current_event.dwThreadId instead of main_thread_id.
4618
4619 2019-04-30  Tom Tromey  <tromey@adacore.com>
4620
4621         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4622         (create_excep_cond_exprs): Iterate over program spaces.
4623         (ada_exception_catchpoint_cond_string): Examine all minimal
4624         symbols for exception types.
4625
4626 2019-04-30  Tom Tromey  <tromey@adacore.com>
4627
4628         PR c++/24470:
4629         * dwarf2read.c (process_structure_scope): Handle case where type
4630         has template parameters but no symbol was created.
4631
4632 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4633             Chris January  <chris.january@arm.com>
4634
4635         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4636         qualifier.
4637         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4638
4639 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4640
4641         * f-typeprint.c (f_print_type): Update rules for printing
4642         whitespace.
4643         (f_type_print_varspec_suffix): Likewise.
4644
4645 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4646             Chris January  <chris.january@arm.com>
4647
4648         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4649         function arguments.
4650
4651 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4652
4653         * f-lang.c (build_fortran_types): Change name of void type to
4654         lower case.
4655         * f-typeprint.c (f_type_print_base): Print the name of the void
4656         type, rather than a fixed string.
4657         * f-valprint.c (f_decorations): Use lower case void string.
4658
4659 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4660             Chris January  <chris.january@arm.com>
4661
4662         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4663         types for Fortran.
4664
4665 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4666             Chris January  <chris.january@arm.com>
4667             David Lecomber  <david.lecomber@arm.com>
4668
4669         * f-exp.y (BINOP_INTRINSIC): New token.
4670         (exp): New parser rule handling BINOP_INTRINSIC.
4671         (f77_keywords): Add new builtin procedures.
4672         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4673         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4674         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4675         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4676         (print_unop_subexp_f): New function.
4677         (print_binop_subexp_f): New function.
4678         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4679         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4680         (dump_subexp_body_f): Likewise.
4681         (operator_check_f): Likewise.
4682         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4683         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4684
4685 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4686
4687         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4688         UNOP_KIND.
4689         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4690         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4691         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4692         (operator_length_f): New fuction.
4693         (print_subexp_f): New function.
4694         (op_name_f): New function.
4695         (dump_subexp_body_f): New function.
4696         (operator_check_f): New function.
4697         (exp_descriptor_f): Replace standard expression handling functions
4698         with new functions.
4699         * gdb/fortran-operator.def: New file.
4700         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4701         * gdb/std-operator.def: Remove UNOP_KIND.
4702
4703 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4704
4705         * std-operator.def: Remove unbalanced, stray double quote
4706         character.
4707
4708 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4709             Chris January  <chris.january@arm.com>
4710             Daniel Everett  <daniel.everett@arm.com>
4711             Nick Forrington  <nick.forrington@arm.com>
4712             Richard Bunt  <richard.bunt@arm.com>
4713
4714         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4715         of depth when printing anonymous structs or unions.
4716         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4717         Don't print either the top-level value, or the children if the
4718         max-depth is exceeded.
4719         (ppscm_print_children): When printing the key of a map, allow one
4720         extra level of depth.
4721         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4722         print either the top-level value, or the children if the max-depth
4723         is exceeded.
4724         (print_children): When printing the key of a map, allow one extra
4725         level of depth.
4726         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4727         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4728         (user_print_options): Initialise max_depth field.
4729         (val_print_scalar_or_string_type_p): New function.
4730         (val_print): Check to see if the max depth has been reached.
4731         (val_print_check_max_depth): Define new function.
4732         (show_print_max_depth): New function.
4733         (_initialize_valprint): Add 'print max-depth' option.
4734         * valprint.h (struct value_print_options) <max_depth>: New field.
4735         (val_print_check_max_depth): Declare new function.
4736         * NEWS: Document new feature.
4737
4738 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4739
4740         * ada-lang.c (ada_language_defn): Initialise new field.
4741         * c-lang.c (c_is_string_type_p): New function.
4742         (c_language_defn): Initialise new field.
4743         (cplus_language_defn): Initialise new field.
4744         (asm_language_defn): Initialise new field.
4745         (minimal_language_defn): Initialise new field.
4746         * c-lang.h (c_is_string_type_p): Declare new function.
4747         * d-lang.c (d_language_defn): Initialise new field.
4748         * f-lang.c (f_is_string_type_p): New function.
4749         (f_language_defn): Initialise new field.
4750         * go-lang.c (go_is_string_type_p): New function.
4751         (go_language_defn): Initialise new field.
4752         * language.c (default_is_string_type_p): New function.
4753         (unknown_language_defn): Initialise new field.
4754         (auto_language_defn): Initialise new field.
4755         * language.h (struct language_defn) <la_is_string_type_p>: New
4756         member variable.
4757         (default_is_string_type_p): Declare new function.
4758         * m2-lang.c (m2_language_defn): Initialise new field.
4759         * objc-lang.c (objc_language_defn): Initialise new field.
4760         * opencl-lang.c (opencl_language_defn): Initialise new field.
4761         * p-lang.c (pascal_is_string_type_p): New function.
4762         (pascal_language_defn): Initialise new field.
4763         * rust-lang.c (rust_is_string_type_p): New function.
4764         (rust_language_defn): Initialise new field.
4765
4766 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4767
4768         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4769         New field.
4770         * ada-lang.c (ada_language_defn): Initialise new field.
4771         * c-lang.c (c_language_defn): Likewise.
4772         (cplus_language_defn): Likewise.
4773         (asm_language_defn): Likewise.
4774         (minimal_language_defn): Likewise.
4775         * d-lang.c (d_language_defn): Likewise.
4776         * f-lang.c (f_language_defn): Likewise.
4777         * go-lang.c (go_language_defn): Likewise.
4778         * language.c (unknown_language_defn): Likewise.
4779         (auto_language_defn): Likewise.
4780         * m2-lang.c (m2_language_defn): Likewise.
4781         * objc-lang.c (objc_language_defn): Likewise.
4782         * opencl-lang.c (opencl_language_defn): Likewise.
4783         * p-lang.c (pascal_language_defn): Likewise.
4784         * rust-lang.c (rust_language_defn): Likewise.
4785
4786 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4787
4788         * ada-lang.c (ada_is_character_type): Change return type to bool.
4789         (ada_is_string_type): Likewise.
4790         * ada-lang.h (ada_is_character_type): Update declaration
4791         (ada_is_string_type): Likewise.
4792
4793 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4794
4795         Support style in 'frame|thread apply'
4796
4797         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4798         * record.c (record_start, record_stop): Update callers of
4799         execute_command_to_string with false.
4800         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4801         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4802         methods.
4803         (class string_file): New constructor with term_out parameter.
4804         Override methods term_out and can_emit_style_escape.  New member
4805         term_out.
4806         (class stdio_file): Override can_emit_style_escape.
4807         (class tee_file): Override term_out and can_emit_style_escape.
4808         * utils.h (can_emit_style_escape): Remove.
4809         * utils.c (can_emit_style_escape): Likewise.
4810         Update all callers of can_emit_style_escape (SOMESTREAM) to
4811         SOMESTREAM->can_emit_style_escape.
4812         * source-cache.c (source_cache::get_source_lines): Likewise.
4813         * stack.c (frame_apply_command_count): Call execute_command_to_string
4814         passing the term_out characteristic of the current gdb_stdout.
4815         * thread.c (thr_try_catch_cmd): Likewise.
4816         * top.c (execute_command_to_string): pass term_out parameter
4817         to construct the string_file for the command output.
4818         * ui-file.c (term_cli_styling): New function (most code moved
4819         from utils.c can_emit_style_escape).
4820         (string_file::string_file, string_file::can_emit_style_escape,
4821         stdio_file::can_emit_style_escape, tee_file::term_out,
4822         tee_file::can_emit_style_escape): New functions.
4823
4824 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4825
4826         * NEWS: Mention the new set|show may-call-functions.
4827         * infcall.c (may_call_functions_p): New variable.
4828         (show_may_call_functions_p): New function.
4829         (call_function_by_hand_dummy): Throws an error if not
4830         may-call-functions.
4831         (_initialize_infcall): Call add_setshow_boolean_cmd for
4832         may-call-functions.
4833
4834 2019-04-25  Keith Seitz  <keiths@redhat.com>
4835
4836         PR c++/24367
4837         * cp-support.c (inspect_type): Don't attempt substitutions
4838         of symbol with the same name.
4839
4840 2019-04-25  Tom Tromey  <tromey@adacore.com>
4841
4842         PR gdb/24475:
4843         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4844         static.
4845
4846 2019-04-25  Tom Tromey  <tromey@adacore.com>
4847
4848         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4849         rvalue reference.
4850         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4851         (gdb_xml_parser::parse): Use std::move.
4852         * python/python-internal.h (gdbpy_convert_exception): Take a const
4853         reference.
4854         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4855         std::move.
4856         * python/py-utils.c (gdbpy_convert_exception): Take a const
4857         reference.
4858         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4859         Use std::move.
4860         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4861         Use std::move.
4862         * mi/mi-main.c (mi_print_exception): Take a const reference.
4863         * main.c (handle_command_errors): Take a const reference.
4864         * linespec.c (parse_linespec): Use std::move.
4865         * infcall.c (run_inferior_call): Use std::move.
4866         (call_function_by_hand_dummy): Use std::move.
4867         * exec.c (try_open_exec_file): Use std::move.
4868         * exceptions.h (exception_print, exception_fprintf)
4869         (exception_print_same): Update.
4870         * exceptions.c (print_exception, exception_print)
4871         (exception_fprintf, exception_print_same): Change parameters to
4872         const reference.
4873         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4874         * common/new-op.c: Use std::move.
4875         * common/common-exceptions.h (struct gdb_exception): Add move
4876         constructor.
4877         (struct gdb_exception_error, struct gdb_exception_quit, struct
4878         gdb_quit_bad_alloc): Change constructor to move constructor.
4879         (throw_exception): Change parameter to rvalue reference.
4880         * common/common-exceptions.c (throw_exception): Take rvalue
4881         reference.
4882         * cli/cli-interp.c (safe_execute_command): Use std::move.
4883         * breakpoint.c (insert_bp_location, location_to_sals): Use
4884         std::move.
4885
4886 2019-04-25  Tom Tromey  <tromey@adacore.com>
4887
4888         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4889         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4890         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4891         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4892         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4893         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4894         guile/scm-value.c: Use unpack.
4895         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4896         gdbscm_gdb_exception.
4897         (gdbscm_throw_gdb_exception): Likewise.
4898         (struct gdbscm_gdb_exception): New.
4899         (unpack): New function.
4900         (gdbscm_wrap): Use unpack.
4901
4902 2019-04-25  Tom Tromey  <tromey@adacore.com>
4903
4904         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4905         (gdb_rl_callback_handler): Use std::move.
4906         * common/common-exceptions.h (struct gdb_exception): Add move
4907         assignment operator.
4908         (throw_exception_sjlj): Change "exception" to const reference.
4909         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4910         (throw_exception_sjlj): Change "exception" to const reference.
4911
4912 2019-04-25  Tom Tromey  <tromey@adacore.com>
4913
4914         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4915         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4916         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4917         Update.
4918         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4919         Update.
4920         * mi/mi-interp.c (mi_interp::exec): Update.
4921         * linespec.c (parse_linespec): Update.
4922         * infcall.c (run_inferior_call): Update.
4923         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4924         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4925         (gdbscm_lookup_global_symbol): Update.
4926         * guile/scm-param.c (gdbscm_parameter_value): Update.
4927         * guile/scm-frame.c (gdbscm_frame_read_register)
4928         (gdbscm_frame_read_var): Update.
4929         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4930         * exec.c (try_open_exec_file): Update.
4931         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4932         (gdb_rl_callback_handler): Update.
4933         * common/common-exceptions.h (exception_none): Don't declare.
4934         * common/common-exceptions.c (exception_none): Don't define.
4935         (struct catcher) <exception>: Update.
4936         * cli/cli-interp.c (safe_execute_command): Update.
4937         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4938
4939 2019-04-25  Ali Tamur  <tamur@google.com>
4940
4941         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4942         (read_attribute_value): Likewise.
4943         (dwarf2_read_addr_index): Update comment.
4944         (read_str_index): Add DW_FORM_strx.
4945         (dwarf2_string_attr): Likewise.
4946         (dwarf2_const_value_attr): Likewise.
4947         (dump_die_shallow): Likewise.
4948         (dwarf2_fetch_constant_bytes): Likewise.
4949         (skip_form_bytes): Likewise.
4950         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4951
4952 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4953
4954         PR corefiles/11608
4955         PR corefiles/18187
4956         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4957         OFFSET.  Verify if current mapping contains an ELF header.
4958         (linux_find_memory_regions_full): Adjust call to
4959         dump_mapping_p.
4960
4961 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4962             Kang Li <kanglictf@gmail.com>
4963
4964         PR gdb/21600
4965
4966         * dwarf2-frame.c (read_initial_length): Be consistent about using
4967         unsigned representation of length.
4968         (decode_frame_entry_1): Likewise.  Check for wraparound of
4969         end pointer as well as buffer overflow.
4970
4971 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4972
4973         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4974         "vq".
4975
4976 2019-04-24  Tom Tromey  <tromey@adacore.com>
4977
4978         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4979
4980 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4981
4982         * s12z-tdep.c (s12z_unwind_pc): Delete.
4983         (s12z_unwind_sp): Delete.
4984         (s12z_gdbarch_init): Don't register deleted functions with
4985         gdbarch.
4986
4987 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4988
4989         * rl78-tdep.c (rl78_unwind_sp): Delete.
4990         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4991
4992 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4993
4994         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4995         (xstormy16_unwind_pc): Delete.
4996         (xstormy16_dummy_id): Delete.
4997         (xstormy16_gdbarch_init): Don't register deleted functions with
4998         gdbarch.
4999
5000 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5001
5002         * vax-tdep.c (vax_unwind_pc): Delete.
5003         (vax_gdbarch_init): Don't register deleted function with gdbarch.
5004
5005 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5006
5007         * v850-tdep.c (v850_unwind_sp): Delete.
5008         (v850_unwind_pc): Delete.
5009         (v850_dummy_id): Delete.
5010         (v850_gdbarch_init): Don't register deleted functions with
5011         gdbarch.
5012
5013 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5014
5015         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5016         (tilegx_unwind_pc): Delete.
5017         (tilegx_unwind_dummy_id): Delete.
5018         (tilegx_gdbarch_init): Don't register deleted functions with
5019         gdbarch.
5020
5021 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5022
5023         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5024         (tic6x_dummy_id): Delete.
5025         (tic6x_gdbarch_init): Don't register deleted functions with
5026         gdbarch.
5027
5028 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5029
5030         * sparc-tdep.c (sparc_unwind_pc): Delete.
5031         (sparc32_gdbarch_init): Don't register deleted function with
5032         gdbarch.
5033
5034 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5035
5036         * sh-tdep.c (sh_unwind_sp): Delete.
5037         (sh_unwind_pc): Delete.
5038         (sh_dummy_id): Delete.
5039         (sh_gdbarch_init): Don't register deleted functions with
5040         gdbarch.
5041
5042 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5043
5044         * score-tdep.c (score_unwind_sp): Delete.
5045         (score_unwind_pc): Delete.
5046         (score_dummy_id): Delete.
5047         (score_gdbarch_init): Don't register deleted functions with
5048         gdbarch.
5049
5050 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5051
5052         * rx-tdep.c (rx_unwind_pc): Delete.
5053         (rx_unwind_sp): Delete.
5054         (rx_dummy_id): Delete.
5055         (rx_gdbarch_init): Don't register deleted functions with
5056         gdbarch.  Update comment.
5057
5058 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5059
5060         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5061         (rs6000_dummy_id): Delete.
5062         (rs6000_gdbarch_init): Don't register deleted functions with
5063         gdbarch.
5064
5065 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5066
5067         * or1k-tdep.c (or1k_dummy_id): Delete.
5068         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5069
5070 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5071
5072         * nios2-tdep.c (nios2_dummy_id): Delete.
5073         (nios2_unwind_sp): Delete.
5074         (nios2_gdbarch_init): Don't register deleted functions with
5075         gdbarch.
5076
5077 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5078
5079         * nds32-tdep.c (nds32_dummy_id): Delete.
5080         (nds32_unwind_pc): Delete.
5081         (nds32_unwind_sp): Delete.
5082         (nds32_gdbarch_init): Don't register deleted functions with
5083         gdbarch.
5084
5085 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5086
5087         * msp430-tdep.c (msp430_unwind_pc): Delete.
5088         (msp430_unwind_sp): Delete.
5089         (msp430_dummy_id): Delete.
5090         (msp430_gdbarch_init): Don't register deleted functions with
5091         gdbarch.
5092
5093 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5094
5095         * moxie-tdep.c (moxie_unwind_sp): Delete.
5096         (moxie_unwind_pc): Delete.
5097         (moxie_dummy_id): Delete.
5098         (moxie_gdbarch_init): Don't register deleted functions with
5099         gdbarch.
5100
5101 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5102
5103         * mn10300-tdep.c (mn10300_dummy_id): Delete.
5104         (mn10300_unwind_pc): Delete.
5105         (mn10300_unwind_sp): Delete.
5106         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5107         mn10300_unwind_sp.
5108         (mn10300_frame_unwind_init): Don't register deleted functions with
5109         gdbarch.
5110
5111 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5112
5113         * mep-tdep.c (mep_unwind_pc): Delete.
5114         (mep_unwind_sp): Delete.
5115         (mep_dummy_id): Delete.
5116         (mep_gdbarch_init): Don't register deleted functions with
5117         gdbarch.
5118
5119 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5120
5121         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5122         (m68hc11_unwind_sp): Delete.
5123         (m68hc11_gdbarch_init): Don't register deleted functions with
5124         gdbarch.
5125
5126 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5127
5128         * m32r-tdep.c (m32r_unwind_sp): Delete.
5129         (m32r_unwind_pc): Delete.
5130         (m32r_dummy_id): Delete.
5131         (m32r_gdbarch_init): Don't register deleted functions with
5132         gdbarch.
5133
5134 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5135
5136         * m32c-tdep.c (m32c_unwind_pc): Delete.
5137         (m32c_unwind_sp): Delete.
5138         (m32c_dummy_id): Delete.
5139         (m32c_gdbarch_init): Don't register deleted functions with
5140         gdbarch.
5141
5142 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5143
5144         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5145         (lm32_unwind_pc): Delete.
5146         (lm32_dummy_id): Delete.
5147         (lm32_gdbarch_init): Don't register deleted functions with
5148         gdbarch.
5149
5150 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5151
5152         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5153         (iq2000_unwind_pc): Delete.
5154         (iq2000_dummy_id): Delete.
5155         (iq2000_gdbarch_init): Don't register deleted functions with
5156         gdbarch.
5157
5158 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5159
5160         * nds32-tdep.c (nds32_type_align): Delete.
5161         (nds32_push_dummy_call): Use type_align instead.
5162
5163 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5164
5165         * arm-tdep.c (arm_type_align): Only handle vector override case.
5166         (arm_push_dummy_call): Use type_align.
5167         (arm_gdbarch_init): Register arm_type_align gdbarch function.
5168
5169 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5170
5171         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5172         case.
5173         (pass_on_stack): Use type_align.
5174         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5175         function.
5176
5177 2019-04-23  Tom Tromey  <tromey@adacore.com>
5178
5179         * dwarf2read.c (line_header::file_name_at): Remove unused
5180         overload.
5181
5182 2019-04-23  Tom de Vries  <tdevries@suse.de>
5183
5184         PR gdb/24438
5185         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5186         invocation.
5187
5188
5189 2019-03-27  Ali Tamur  <tamur@google.com>
5190
5191         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5192         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5193         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5194         (dwarf_expr_context::get_addr_index): Likewise
5195         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5196         (symbol_needs_eval_context::get_addr_index): Likewise
5197         (disassemble_dwarf_expression): Add DW_OP_addrx
5198         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5199         (read_cutu_die_from_dwo): Update comment
5200         (skip_one_die): Add DW_FORM_addrx
5201         (read_attribute_value): Likewise
5202         (var_decode_location): Add DW_OP_addrx
5203         (dwarf2_const_value_attr): Add DW_FORM_addrx
5204         (dump_die_shallow): Likewise
5205         (dwarf2_fetch_constant_bytes): Likewise
5206         (decode_locdesc): Add DW_OP_addrx
5207         (skip_form_bytes): Add DW_FORM_addrx
5208
5209 2019-04-22  Ali Tamur  <tamur@google.com>
5210
5211         * MAINTAINERS (Write After Approval): Add self.
5212
5213 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
5214
5215         * solib-svr4.c (get_svr4_info): Add pspace parameter.
5216         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5217         (open_symbol_file_object): Likewise.
5218         (svr4_default_sos): Add info parameter.
5219         (svr4_read_so_list): Likewise.
5220         (svr4_current_sos_direct): Adjust functions calls to pass down
5221         info.
5222         (svr4_current_sos_1): Add info parameter.
5223         (svr4_current_sos): Call get_svr4_info, pass info down to
5224         svr4_current_sos_1.
5225         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5226         get_svr4_info.
5227         (svr4_in_dynsym_resolve_code): Pass current_program_space to
5228         get_svr4_info.
5229         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5230         to get_svr4_info.
5231         (probes_table_remove_objfile_probes): Likewise.
5232         (register_solib_event_probe): Add info parameter.
5233         (solist_update_incremental): Pass info parameter down to
5234         svr4_read_so_list.
5235         (disable_probes_interface): Add info parameter.
5236         (svr4_handle_solib_event): Pass current_program_space to
5237         get_svr4_info.  Adjust disable_probes_interface cleanup.
5238         (svr4_create_probe_breakpoints): Add info parameter, pass it
5239         down to register_solib_event_probe.
5240         (svr4_create_solib_event_breakpoints): Add info parameter,
5241         pass it down to svr4_create_probe_breakpoints.
5242         (enable_break): Pass info down to
5243         svr4_create_solib_event_breakpoints.
5244         (svr4_solib_create_inferior_hook): Pass current_program_space to
5245         get_svr4_info.
5246         (svr4_clear_solib): Likewise.
5247
5248 2019-04-22  Pedro Alves  <palves@redhat.com>
5249
5250         * solib-svr4.c (svr4_free_objfile_observer): New.
5251         (probe_and_action::objfile): New field.
5252         (probes_table_htab_remove_objfile_probes)
5253         (probes_table_remove_objfile_probes): New functions.
5254         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5255         in the new probe_and_action.  Don't store the probe in 'lookup'.
5256         (svr4_create_probe_breakpoints): Pass objfile to
5257         register_solib_event_probe.
5258         (_initialize_svr4_solib): Register a free_objfile observer.
5259
5260 2019-04-19  Tom Tromey  <tom@tromey.com>
5261
5262         * common/queue.h: Remove.
5263
5264 2019-04-19  Tom Tromey  <tom@tromey.com>
5265
5266         * event-loop.c: Don't include "common/queue.h".
5267
5268 2019-04-19  Tom Tromey  <tom@tromey.com>
5269
5270         * remote.c (remote_target): Use delete.
5271         * remote-notif.h: Include <list>, not "common/queue.h".
5272         (notif_client_p): Remove typedef.
5273         (remote_notif_state): Add constructor, destructor, initializer.
5274         <notif_queue>: Now a std::list.
5275         (remote_notif_state_xfree): Don't declare.
5276         * remote-notif.c (remote_notif_process, handle_notification)
5277         (remote_notif_state_allocate): Update.
5278         (~remote_notif_state): Rename from remote_notif_state_xfree.
5279
5280 2019-04-19  Tom Tromey  <tom@tromey.com>
5281
5282         * symfile.c (reread_symbols): Update.
5283         * objfiles.c (objfile_register_static_link)
5284         (objfile_lookup_static_link): Update
5285         (~objfile) Don't delete static_links.
5286         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5287
5288 2019-04-19  Tom Tromey  <tom@tromey.com>
5289
5290         * type-stack.h (struct type_stack) <insert>: Constify string.
5291         * type-stack.c (type_stack::insert): Constify string.
5292         * gdbtypes.h (lookup_template_type): Update.
5293         (address_space_name_to_int): Update.
5294         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5295         const.
5296         (lookup_template_type): Make name const.
5297         * c-exp.y: Update rules.
5298         (lex_one_token, classify_name, classify_inner_name)
5299         (c_print_token): Update.
5300         * p-exp.y: Update rules.
5301         (yylex): Update.
5302         * f-exp.y: Update rules.
5303         (yylex): Update.
5304         * d-exp.y: Update rules.
5305         (lex_one_token, classify_name, classify_inner_name): Update.
5306         * parse.c (write_dollar_variable, copy_name): Return std::string.
5307         * parser-defs.h (copy_name): Change return type.
5308         * m2-exp.y: Update rules.
5309         (yylex): Update.
5310         * go-exp.y (lex_one_token): Update.
5311         Update rules.
5312         (classify_unsafe_function, classify_packaged_name)
5313         (classify_name, yylex): Update.
5314
5315 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5316
5317         * configure.ac: add --enable-source-highlight switch.
5318         * configure: Regenerate.
5319         * top.c (print_gdb_version): plumb --enable-source-highlight
5320         status to "show configuration".
5321
5322 2019-04-19  Tom Tromey  <tromey@adacore.com>
5323
5324         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5325         Check ADA_TYPE_P.
5326         (empty_record, ada_template_to_fixed_record_type_1)
5327         (template_to_static_fixed_type)
5328         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5329         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5330         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5331         macros.
5332
5333 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5334
5335         PR symtab/24423:
5336         * source.c (print_source_lines_base): Advance "iter" when a
5337         control character is seen.
5338
5339 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5340
5341         * inferior.h (struct infcall_suspend_state_deleter):
5342         Catch exception in destructor to avoid crash.
5343
5344 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5345
5346         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5347         close to the add_com "shell".
5348
5349 2019-04-18  Tom Tromey  <tromey@adacore.com>
5350
5351         * process-stratum-target.h (class process_stratum_target)
5352         <stratum>: Add "final".
5353
5354 2019-04-17  Tom Tromey  <tromey@adacore.com>
5355
5356         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5357         against nullptr before use.
5358
5359 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5360
5361         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5362
5363 2019-04-17  Jim Wilson  <jimw@sifive.com>
5364             Andrew Burgess  <andrew.burgess@embecosm.com>
5365
5366         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5367         code read might fail, assume 4-byte breakpoint in that case.
5368
5369 2019-04-15  Leszek Swirski  <leszeks@google.com>
5370
5371         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5372         rather than a hand-rolled POD check when checking for forced MEMORY
5373         classification.
5374
5375 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5376
5377         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5378         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5379         function.
5380         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5381         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5382         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5383         declaration.
5384
5385 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5386
5387         * aarch64-linux-nat.c
5388         (aarch64_linux_nat_target::thread_architecture): Add override.
5389         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5390         each VQ.
5391
5392 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5393
5394         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5395
5396 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5397
5398         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5399         target types of size 96-bits, add some additional comments, and
5400         check that the builtin type we found was the correct size.
5401
5402 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5403
5404         * utils.c (prompt_for_continue): Don't restore the styling at the
5405         end, as applied_style has the wrong value.  This fixes styling in
5406         long lists of file names that are interrupted by the "Continue?"
5407         prompt.
5408
5409 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5410
5411         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5412         * c-lang.c (c_language_defn): Likewise.
5413         (cplus_language_defn): Likewise.
5414         (asm_language_defn): Likewise.
5415         (minimal_language_defn): Likewise.
5416         * d-lang.c (d_language_defn): Likewise.
5417         * f-lang.c (f_language_defn): Likewise.
5418         * go-lang.c (go_language_defn): Likewise.
5419         * language.c (unknown_language_defn): Likewise.
5420         (auto_language_defn): Likewise.
5421         * language.h (struct language_defn): Remove la_magic field.
5422         (LANG_MAGIC): Delete.
5423         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5424         * objc-lang.c (objc_language_defn): Likewise.
5425         * opencl-lang.c (opencl_language_defn): Likewise.
5426         * p-lang.c (pascal_language_defn): Likewise.
5427         * rust-lang.c (rust_language_defn): Likewise.
5428
5429 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5430
5431         * riscv-tdep.c (riscv_type_align): New function.
5432         (riscv_type_alignment): Delete.
5433         (riscv_arg_location): Use 'type_align'.
5434         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5435
5436 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5437
5438         * gdbtypes.c (type_align): A struct with no non-static fields also
5439         has alignment of 1.
5440
5441 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5442
5443         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5444         component to 0.
5445         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5446         member.
5447         (riscv_struct_info::analyse): New implementation using new
5448         analyse_inner member function.
5449         (riscv_struct_info::field_offset): New member function.
5450         (riscv_struct_info::m_offsets): New member variable.
5451         (riscv_struct_info::analyse_inner): New private member function,
5452         takes the old implementation of riscv_struct_info::analyse but
5453         extended to track field offsets.
5454         (riscv_call_arg_struct): Update the struct folding special cases
5455         to handle cases where empty C++ structs, which are non-zero
5456         length, are found.
5457         (riscv_arg_location): Initialise the length of each location, a
5458         non-zero length now indicates the location is in use.
5459         (riscv_push_dummy_call): Allow for the first location having a
5460         non-zero offset when setting up arguments.
5461         (riscv_return_value): Likewise, but for return values.
5462
5463 2019-04-11  Tom Tromey  <tromey@adacore.com>
5464
5465         * utils.c (internal_vproblem): Make "msg" const.
5466
5467 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5468
5469         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5470         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5471         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5472         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5473
5474 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5475
5476         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5477         function.
5478         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5479         of amd64_collect_native_gregset.
5480         (amd64_linux_nat_target::store_registers): Likewise.
5481
5482 2019-04-10  Tom Tromey  <tom@tromey.com>
5483
5484         * symtab.c (lookup_global_symbol_from_objfile)
5485         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5486         * objfiles.h (class separate_debug_iterator): New.
5487         (class separate_debug_range): New.
5488         (struct objfile) <separate_debug_objfiles>: New method.
5489         (objfile_separate_debug_iterate): Don't declare.
5490         * objfiles.c (separate_debug_iterator::operator++): Rename from
5491         objfile_separate_debug_iterate.
5492         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5493         iterator.
5494         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5495         iterator.
5496
5497 2019-04-10  Tom Tromey  <tom@tromey.com>
5498
5499         * symfile.c (reread_symbols): Remove old comment.
5500         * objfiles.c (free_all_objfiles): Fix a typo.
5501
5502 2019-04-10  Tom Tromey  <tom@tromey.com>
5503
5504         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5505         * minsyms.c (lookup_minimal_symbol): Use foreach.
5506         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5507         (lookup_minimal_symbol_solib_trampoline): Likewise.
5508         * symfile.c (reread_symbols): Use foreach.
5509
5510 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5511             Tom Tromey  <tromey@adacore.com>
5512
5513         PR rust/24414:
5514         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5515         (rust_lex_int_test): Change "value" to be LONGEST.
5516         (rust_lex_tests): Add test for long integer literal.
5517
5518 2019-04-09  Tom Tromey  <tromey@adacore.com>
5519
5520         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5521         to bool.
5522         (extended_remote_target::attach): Update.
5523         (remote_target::remote_notice_new_inferior): Update.
5524         (remote_target::add_current_inferior_and_thread): Update.
5525         * inferior.c (exit_inferior_1): Use "false".
5526         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5527
5528 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5529
5530         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5531         the "start" command.
5532
5533 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5534
5535         * python/py-inferior.c (infpy_thread_from_thread_handle):
5536         Adjust comments to reflect renaming of thread_from_thread_handle
5537         to thread_from_handle.  Adjust keywords.  Fix type error message.
5538         (inferior_object_methods): Add thread_from_handle.  Retain
5539         thread_from_thread_handle, but mark it as deprecated.
5540
5541 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5542
5543         * gdbthread.h (find_thread_by_handle): Revise declaration.
5544         * thread.c (find_thread_by_handle): Likewise.  Adjust
5545         implementation too.
5546         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5547         support for buffer objects as handles.
5548
5549 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5550
5551         * python/py-infthread.c (thpy_thread_handle): New function.
5552         (thread_object_methods): Register thpy_thread_handle.
5553
5554 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5555
5556         * gdbthread.h (thread_to_thread_handle): Declare.
5557         * thread.c (gdbtypes.h): Include.
5558         (thread_to_thread_handle): New function.
5559
5560         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5561         (target_thread_info_to_thread_handle): Declare.
5562         * target.c (target_thread_info_to_thread_handle): New function.
5563         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5564         * target-delegates.c: Regenerate.
5565
5566         * linux-thread-db.c (class thread_db_target): Add method
5567         thread_info_to_thread_handle.
5568         (thread_db_target::thread_info_to_thread_handle): Define.
5569         * remote.c (class remote_target): Add new method
5570         thread_info_to_thread_handle.
5571         (remote_target::thread_info_to_thread_handle): Define.
5572
5573 2019-04-08  Pedro Alves  <palves@redhat.com>
5574
5575         * common/common-exceptions.c (throw_exception): Don't create
5576         named object to throw; throw directly.
5577         (throw_it): Likewise.  Don't initialize gdb_exception::message
5578         here, with new; pass FMT and AP to the ctor instead.
5579         * common/common-exceptions.h: Include <string>.
5580         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5581         const char *, va_list)): New ctor.  Use std::make_shared.
5582         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5583         errors)): Delete.
5584         (gdb_exception_error::gdb_exception_error(enum errors, const char
5585         *, va_list)): New.
5586         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5587         Add assertion.
5588         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5589         errors)): Delete.
5590         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5591         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5592         Add assertion.
5593
5594 2019-04-08  Tom Tromey  <tom@tromey.com>
5595
5596         * valops.c (value_rtti_indirect_type): Replace throw_exception
5597         with throw.
5598         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5599         with throw.
5600         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5601         throw.
5602         * target.c (target_translate_tls_address): Replace throw_exception
5603         with throw.
5604         * stack.c (frame_apply_command_count): Replace throw_exception
5605         with throw.
5606         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5607         throw.
5608         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5609         with throw.
5610         * rs6000-tdep.c (rs6000_frame_cache)
5611         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5612         * remote.c: Replace throw_exception with throw.
5613         * record-full.c (record_full_message, record_full_wait_1)
5614         (record_full_restore): Replace throw_exception with throw.
5615         * record-btrace.c:
5616         (get_thread_current_frame_id, record_btrace_start_replaying)
5617         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5618         (cmd_record_btrace_start): Replace throw_exception with throw.
5619         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5620         throw.
5621         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5622         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5623         * linespec.c:
5624         (find_linespec_symbols): Replace throw_exception with throw.
5625         * infrun.c (displaced_step_prepare, resume): Replace
5626         throw_exception with throw.
5627         * infcmd.c (post_create_inferior): Replace throw_exception with
5628         throw.
5629         * inf-loop.c (inferior_event_handler): Replace throw_exception
5630         with throw.
5631         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5632         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5633         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5634         (get_prev_frame_always, get_frame_pc_if_available)
5635         (get_frame_address_in_block_if_available, get_frame_language):
5636         Replace throw_exception with throw.
5637         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5638         throw_exception with throw.
5639         * eval.c (fetch_subexp_value, evaluate_var_value)
5640         (evaluate_funcall, evaluate_subexp_standard): Replace
5641         throw_exception with throw.
5642         * dwarf2loc.c (call_site_find_chain)
5643         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5644         Replace throw_exception with throw.
5645         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5646         with throw.
5647         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5648         throw.
5649         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5650         * completer.c (complete_line_internal): Replace throw_exception
5651         with throw.
5652         * compile/compile-object-run.c (compile_object_run): Replace
5653         throw_exception with throw.
5654         * cli/cli-script.c (process_next_line): Replace throw_exception
5655         with throw.
5656         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5657         (btrace_enable, btrace_maint_update_pt_packets): Replace
5658         throw_exception with throw.
5659         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5660         throw_exception with throw.
5661         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5662         throw_exception with throw.
5663         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5664         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5665         * aarch64-tdep.c (aarch64_make_prologue_cache)
5666         (aarch64_make_stub_cache): Replace throw_exception with throw.
5667
5668 2019-04-08  Tom Tromey  <tom@tromey.com>
5669
5670         * common/common-exceptions.c (throw_exception): Rename from
5671         throw_exception_cxx.  Remove old copy.  Make argument const.
5672         (throw_it): Create and throw exception objects directly.
5673         * common/common-exceptions.h (throw_exception): Make argument
5674         const.
5675         (struct gdb_exception_error): Add constructor.
5676         (struct gdb_exception_quit): Add constructor.
5677
5678 2019-04-08  Tom Tromey  <tom@tromey.com>
5679
5680         * common/common-exceptions.h (exception_rethrow): Don't declare.
5681         (TRY_SJLJ): Update comment.
5682         (TRY, CATCH, END_CATCH): Remove.
5683         * common/common-exceptions.c (exception_rethrow): Remove.
5684
5685 2019-04-08  Tom Tromey  <tom@tromey.com>
5686
5687         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5688         Remove.
5689         (gdb_exception_error): Rename from
5690         gdb_exception_RETURN_MASK_ERROR.
5691         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5692         (gdb_quit_bad_alloc): Update.
5693         * aarch64-tdep.c: Update.
5694         * ada-lang.c: Update.
5695         * ada-typeprint.c: Update.
5696         * ada-valprint.c: Update.
5697         * amd64-tdep.c: Update.
5698         * arch-utils.c: Update.
5699         * break-catch-throw.c: Update.
5700         * breakpoint.c: Update.
5701         * btrace.c: Update.
5702         * c-varobj.c: Update.
5703         * cli/cli-cmds.c: Update.
5704         * cli/cli-interp.c: Update.
5705         * cli/cli-script.c: Update.
5706         * common/common-exceptions.c: Update.
5707         * common/new-op.c: Update.
5708         * common/selftest.c: Update.
5709         * compile/compile-c-symbols.c: Update.
5710         * compile/compile-cplus-symbols.c: Update.
5711         * compile/compile-object-load.c: Update.
5712         * compile/compile-object-run.c: Update.
5713         * completer.c: Update.
5714         * corelow.c: Update.
5715         * cp-abi.c: Update.
5716         * cp-support.c: Update.
5717         * cp-valprint.c: Update.
5718         * darwin-nat.c: Update.
5719         * disasm-selftests.c: Update.
5720         * dtrace-probe.c: Update.
5721         * dwarf-index-cache.c: Update.
5722         * dwarf-index-write.c: Update.
5723         * dwarf2-frame-tailcall.c: Update.
5724         * dwarf2-frame.c: Update.
5725         * dwarf2loc.c: Update.
5726         * dwarf2read.c: Update.
5727         * eval.c: Update.
5728         * event-loop.c: Update.
5729         * event-top.c: Update.
5730         * exec.c: Update.
5731         * f-valprint.c: Update.
5732         * fbsd-tdep.c: Update.
5733         * frame-unwind.c: Update.
5734         * frame.c: Update.
5735         * gdbtypes.c: Update.
5736         * gnu-v3-abi.c: Update.
5737         * guile/guile-internal.h: Update.
5738         * guile/scm-block.c: Update.
5739         * guile/scm-breakpoint.c: Update.
5740         * guile/scm-cmd.c: Update.
5741         * guile/scm-disasm.c: Update.
5742         * guile/scm-frame.c: Update.
5743         * guile/scm-lazy-string.c: Update.
5744         * guile/scm-math.c: Update.
5745         * guile/scm-param.c: Update.
5746         * guile/scm-ports.c: Update.
5747         * guile/scm-pretty-print.c: Update.
5748         * guile/scm-symbol.c: Update.
5749         * guile/scm-symtab.c: Update.
5750         * guile/scm-type.c: Update.
5751         * guile/scm-value.c: Update.
5752         * i386-linux-tdep.c: Update.
5753         * i386-tdep.c: Update.
5754         * inf-loop.c: Update.
5755         * infcall.c: Update.
5756         * infcmd.c: Update.
5757         * infrun.c: Update.
5758         * jit.c: Update.
5759         * language.c: Update.
5760         * linespec.c: Update.
5761         * linux-fork.c: Update.
5762         * linux-nat.c: Update.
5763         * linux-tdep.c: Update.
5764         * linux-thread-db.c: Update.
5765         * main.c: Update.
5766         * mi/mi-cmd-break.c: Update.
5767         * mi/mi-cmd-stack.c: Update.
5768         * mi/mi-interp.c: Update.
5769         * mi/mi-main.c: Update.
5770         * objc-lang.c: Update.
5771         * p-valprint.c: Update.
5772         * parse.c: Update.
5773         * ppc-linux-tdep.c: Update.
5774         * printcmd.c: Update.
5775         * python/py-arch.c: Update.
5776         * python/py-breakpoint.c: Update.
5777         * python/py-cmd.c: Update.
5778         * python/py-finishbreakpoint.c: Update.
5779         * python/py-frame.c: Update.
5780         * python/py-framefilter.c: Update.
5781         * python/py-gdb-readline.c: Update.
5782         * python/py-inferior.c: Update.
5783         * python/py-infthread.c: Update.
5784         * python/py-lazy-string.c: Update.
5785         * python/py-linetable.c: Update.
5786         * python/py-objfile.c: Update.
5787         * python/py-param.c: Update.
5788         * python/py-prettyprint.c: Update.
5789         * python/py-progspace.c: Update.
5790         * python/py-record-btrace.c: Update.
5791         * python/py-record.c: Update.
5792         * python/py-symbol.c: Update.
5793         * python/py-type.c: Update.
5794         * python/py-unwind.c: Update.
5795         * python/py-utils.c: Update.
5796         * python/py-value.c: Update.
5797         * python/python.c: Update.
5798         * record-btrace.c: Update.
5799         * record-full.c: Update.
5800         * remote-fileio.c: Update.
5801         * remote.c: Update.
5802         * riscv-tdep.c: Update.
5803         * rs6000-aix-tdep.c: Update.
5804         * rs6000-tdep.c: Update.
5805         * rust-exp.y: Update.
5806         * rust-lang.c: Update.
5807         * s390-tdep.c: Update.
5808         * selftest-arch.c: Update.
5809         * solib-dsbt.c: Update.
5810         * solib-frv.c: Update.
5811         * solib-spu.c: Update.
5812         * solib-svr4.c: Update.
5813         * solib.c: Update.
5814         * sparc64-linux-tdep.c: Update.
5815         * stack.c: Update.
5816         * symfile-mem.c: Update.
5817         * symmisc.c: Update.
5818         * target.c: Update.
5819         * thread.c: Update.
5820         * top.c: Update.
5821         * tracefile-tfile.c: Update.
5822         * tui/tui.c: Update.
5823         * typeprint.c: Update.
5824         * unittests/cli-utils-selftests.c: Update.
5825         * unittests/parse-connection-spec-selftests.c: Update.
5826         * valops.c: Update.
5827         * valprint.c: Update.
5828         * value.c: Update.
5829         * varobj.c: Update.
5830         * windows-nat.c: Update.
5831         * x86-linux-nat.c: Update.
5832         * xml-support.c: Update.
5833
5834 2019-04-08  Tom Tromey  <tom@tromey.com>
5835
5836         * xml-support.c: Use C++ exception handling.
5837         * x86-linux-nat.c: Use C++ exception handling.
5838         * windows-nat.c: Use C++ exception handling.
5839         * varobj.c: Use C++ exception handling.
5840         * value.c: Use C++ exception handling.
5841         * valprint.c: Use C++ exception handling.
5842         * valops.c: Use C++ exception handling.
5843         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5844         handling.
5845         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5846         * typeprint.c: Use C++ exception handling.
5847         * tui/tui.c: Use C++ exception handling.
5848         * tracefile-tfile.c: Use C++ exception handling.
5849         * top.c: Use C++ exception handling.
5850         * thread.c: Use C++ exception handling.
5851         * target.c: Use C++ exception handling.
5852         * symmisc.c: Use C++ exception handling.
5853         * symfile-mem.c: Use C++ exception handling.
5854         * stack.c: Use C++ exception handling.
5855         * sparc64-linux-tdep.c: Use C++ exception handling.
5856         * solib.c: Use C++ exception handling.
5857         * solib-svr4.c: Use C++ exception handling.
5858         * solib-spu.c: Use C++ exception handling.
5859         * solib-frv.c: Use C++ exception handling.
5860         * solib-dsbt.c: Use C++ exception handling.
5861         * selftest-arch.c: Use C++ exception handling.
5862         * s390-tdep.c: Use C++ exception handling.
5863         * rust-lang.c: Use C++ exception handling.
5864         * rust-exp.y: Use C++ exception handling.
5865         * rs6000-tdep.c: Use C++ exception handling.
5866         * rs6000-aix-tdep.c: Use C++ exception handling.
5867         * riscv-tdep.c: Use C++ exception handling.
5868         * remote.c: Use C++ exception handling.
5869         * remote-fileio.c: Use C++ exception handling.
5870         * record-full.c: Use C++ exception handling.
5871         * record-btrace.c: Use C++ exception handling.
5872         * python/python.c: Use C++ exception handling.
5873         * python/py-value.c: Use C++ exception handling.
5874         * python/py-utils.c: Use C++ exception handling.
5875         * python/py-unwind.c: Use C++ exception handling.
5876         * python/py-type.c: Use C++ exception handling.
5877         * python/py-symbol.c: Use C++ exception handling.
5878         * python/py-record.c: Use C++ exception handling.
5879         * python/py-record-btrace.c: Use C++ exception handling.
5880         * python/py-progspace.c: Use C++ exception handling.
5881         * python/py-prettyprint.c: Use C++ exception handling.
5882         * python/py-param.c: Use C++ exception handling.
5883         * python/py-objfile.c: Use C++ exception handling.
5884         * python/py-linetable.c: Use C++ exception handling.
5885         * python/py-lazy-string.c: Use C++ exception handling.
5886         * python/py-infthread.c: Use C++ exception handling.
5887         * python/py-inferior.c: Use C++ exception handling.
5888         * python/py-gdb-readline.c: Use C++ exception handling.
5889         * python/py-framefilter.c: Use C++ exception handling.
5890         * python/py-frame.c: Use C++ exception handling.
5891         * python/py-finishbreakpoint.c: Use C++ exception handling.
5892         * python/py-cmd.c: Use C++ exception handling.
5893         * python/py-breakpoint.c: Use C++ exception handling.
5894         * python/py-arch.c: Use C++ exception handling.
5895         * printcmd.c: Use C++ exception handling.
5896         * ppc-linux-tdep.c: Use C++ exception handling.
5897         * parse.c: Use C++ exception handling.
5898         * p-valprint.c: Use C++ exception handling.
5899         * objc-lang.c: Use C++ exception handling.
5900         * mi/mi-main.c: Use C++ exception handling.
5901         * mi/mi-interp.c: Use C++ exception handling.
5902         * mi/mi-cmd-stack.c: Use C++ exception handling.
5903         * mi/mi-cmd-break.c: Use C++ exception handling.
5904         * main.c: Use C++ exception handling.
5905         * linux-thread-db.c: Use C++ exception handling.
5906         * linux-tdep.c: Use C++ exception handling.
5907         * linux-nat.c: Use C++ exception handling.
5908         * linux-fork.c: Use C++ exception handling.
5909         * linespec.c: Use C++ exception handling.
5910         * language.c: Use C++ exception handling.
5911         * jit.c: Use C++ exception handling.
5912         * infrun.c: Use C++ exception handling.
5913         * infcmd.c: Use C++ exception handling.
5914         * infcall.c: Use C++ exception handling.
5915         * inf-loop.c: Use C++ exception handling.
5916         * i386-tdep.c: Use C++ exception handling.
5917         * i386-linux-tdep.c: Use C++ exception handling.
5918         * guile/scm-value.c: Use C++ exception handling.
5919         * guile/scm-type.c: Use C++ exception handling.
5920         * guile/scm-symtab.c: Use C++ exception handling.
5921         * guile/scm-symbol.c: Use C++ exception handling.
5922         * guile/scm-pretty-print.c: Use C++ exception handling.
5923         * guile/scm-ports.c: Use C++ exception handling.
5924         * guile/scm-param.c: Use C++ exception handling.
5925         * guile/scm-math.c: Use C++ exception handling.
5926         * guile/scm-lazy-string.c: Use C++ exception handling.
5927         * guile/scm-frame.c: Use C++ exception handling.
5928         * guile/scm-disasm.c: Use C++ exception handling.
5929         * guile/scm-cmd.c: Use C++ exception handling.
5930         * guile/scm-breakpoint.c: Use C++ exception handling.
5931         * guile/scm-block.c: Use C++ exception handling.
5932         * guile/guile-internal.h: Use C++ exception handling.
5933         * gnu-v3-abi.c: Use C++ exception handling.
5934         * gdbtypes.c: Use C++ exception handling.
5935         * frame.c: Use C++ exception handling.
5936         * frame-unwind.c: Use C++ exception handling.
5937         * fbsd-tdep.c: Use C++ exception handling.
5938         * f-valprint.c: Use C++ exception handling.
5939         * exec.c: Use C++ exception handling.
5940         * event-top.c: Use C++ exception handling.
5941         * event-loop.c: Use C++ exception handling.
5942         * eval.c: Use C++ exception handling.
5943         * dwarf2read.c: Use C++ exception handling.
5944         * dwarf2loc.c: Use C++ exception handling.
5945         * dwarf2-frame.c: Use C++ exception handling.
5946         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5947         * dwarf-index-write.c: Use C++ exception handling.
5948         * dwarf-index-cache.c: Use C++ exception handling.
5949         * dtrace-probe.c: Use C++ exception handling.
5950         * disasm-selftests.c: Use C++ exception handling.
5951         * darwin-nat.c: Use C++ exception handling.
5952         * cp-valprint.c: Use C++ exception handling.
5953         * cp-support.c: Use C++ exception handling.
5954         * cp-abi.c: Use C++ exception handling.
5955         * corelow.c: Use C++ exception handling.
5956         * completer.c: Use C++ exception handling.
5957         * compile/compile-object-run.c: Use C++ exception handling.
5958         * compile/compile-object-load.c: Use C++ exception handling.
5959         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5960         * compile/compile-c-symbols.c: Use C++ exception handling.
5961         * common/selftest.c: Use C++ exception handling.
5962         * common/new-op.c: Use C++ exception handling.
5963         * cli/cli-script.c: Use C++ exception handling.
5964         * cli/cli-interp.c: Use C++ exception handling.
5965         * cli/cli-cmds.c: Use C++ exception handling.
5966         * c-varobj.c: Use C++ exception handling.
5967         * btrace.c: Use C++ exception handling.
5968         * breakpoint.c: Use C++ exception handling.
5969         * break-catch-throw.c: Use C++ exception handling.
5970         * arch-utils.c: Use C++ exception handling.
5971         * amd64-tdep.c: Use C++ exception handling.
5972         * ada-valprint.c: Use C++ exception handling.
5973         * ada-typeprint.c: Use C++ exception handling.
5974         * ada-lang.c: Use C++ exception handling.
5975         * aarch64-tdep.c: Use C++ exception handling.
5976
5977 2019-04-08  Tom Tromey  <tom@tromey.com>
5978
5979         * xml-support.c (gdb_xml_parser::parse): Update.
5980         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5981         * value.c (show_convenience): Update.
5982         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5983         (test_parse_flags_qcs): Update.
5984         * thread.c (thr_try_catch_cmd): Update.
5985         * target.c (target_translate_tls_address): Update.
5986         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5987         (info_frame_command_core, frame_apply_command_count): Update.
5988         * rust-exp.y (rust_lex_exception_test): Update.
5989         * riscv-tdep.c (riscv_print_one_register_info): Update.
5990         * remote.c (remote_target::enable_btrace): Update.
5991         * record-btrace.c (record_btrace_enable_warn): Update.
5992         * python/py-utils.c (gdbpy_convert_exception): Update.
5993         * printcmd.c (do_one_display, print_variable_and_value): Update.
5994         * mi/mi-main.c (mi_print_exception): Update.
5995         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5996         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5997         * linux-nat.c (linux_nat_target::attach): Update.
5998         * linux-fork.c (class scoped_switch_fork_info): Update.
5999         * infrun.c (displaced_step_prepare): Update.
6000         * infcall.c (call_function_by_hand_dummy): Update.
6001         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6002         * gnu-v3-abi.c (print_one_vtable): Update.
6003         * frame.c (get_prev_frame_always): Update.
6004         * f-valprint.c (info_common_command_for_block): Update.
6005         * exec.c (try_open_exec_file): Update.
6006         * exceptions.c (print_exception, exception_print)
6007         (exception_fprintf, exception_print_same): Update.
6008         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6009         * dwarf-index-cache.c (index_cache::store)
6010         (index_cache::lookup_gdb_index): Update.
6011         * darwin-nat.c (maybe_cache_shell): Update.
6012         * cp-valprint.c (cp_print_value_fields): Update.
6013         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6014         (gcc_cplus_symbol_address): Update.
6015         * compile/compile-c-symbols.c (gcc_convert_symbol)
6016         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6017         * common/selftest.c: Update.
6018         * common/common-exceptions.h (struct gdb_exception) <message>: Now
6019         a std::string.
6020         (exception_try_scope_entry, exception_try_scope_exit): Don't
6021         declare.
6022         (struct exception_try_scope): Remove.
6023         (TRY): Don't use exception_try_scope.
6024         (struct gdb_exception): Add constructor, operator=.
6025         <what>: New method.
6026         (struct gdb_exception_RETURN_MASK_ALL)
6027         (struct gdb_exception_RETURN_MASK_ERROR)
6028         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6029         (struct gdb_quit_bad_alloc): Update.
6030         * common/common-exceptions.c (exception_none): Change
6031         initializer.
6032         (struct catcher) <state, exception>: Initialize inline.
6033         <prev>: Remove member.
6034         (current_catcher): Remove.
6035         (catchers): New global.
6036         (exceptions_state_mc_init): Simplify.
6037         (catcher_pop): Remove.
6038         (exceptions_state_mc, exceptions_state_mc_catch): Update.
6039         (try_scope_depth, exception_try_scope_entry)
6040         (exception_try_scope_exit): Remove.
6041         (throw_exception_sjlj): Update.
6042         (exception_messages, exception_messages_size): Remove.
6043         (throw_it): Simplify.
6044         (gdb_exception_sliced_copy): Remove.
6045         (throw_exception_cxx): Update.
6046         * cli/cli-script.c (script_from_file): Update.
6047         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
6048         Update.
6049         * ada-valprint.c (ada_val_print): Update.
6050         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
6051         (create_excep_cond_exprs): Update.
6052
6053 2019-04-08  Tom Tromey  <tom@tromey.com>
6054
6055         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
6056         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
6057         (TRY, CATCH, END_CATCH): Remove some definitions.
6058         * common/common-exceptions.c: Don't use GDB_XCPT.
6059         (catcher_list_size): Remove.
6060         (throw_exception, throw_it): Simplify.
6061
6062 2019-04-05  Tom Tromey  <tom@tromey.com>
6063
6064         Revert the header-sorting patch.
6065         * ft32-tdep.c: Revert.
6066         * frv-tdep.c: Revert.
6067         * frv-linux-tdep.c: Revert.
6068         * frame.c: Revert.
6069         * frame-unwind.c: Revert.
6070         * frame-base.c: Revert.
6071         * fork-child.c: Revert.
6072         * findvar.c: Revert.
6073         * findcmd.c: Revert.
6074         * filesystem.c: Revert.
6075         * filename-seen-cache.h: Revert.
6076         * filename-seen-cache.c: Revert.
6077         * fbsd-tdep.c: Revert.
6078         * fbsd-nat.h: Revert.
6079         * fbsd-nat.c: Revert.
6080         * f-valprint.c: Revert.
6081         * f-typeprint.c: Revert.
6082         * f-lang.c: Revert.
6083         * extension.h: Revert.
6084         * extension.c: Revert.
6085         * extension-priv.h: Revert.
6086         * expprint.c: Revert.
6087         * exec.h: Revert.
6088         * exec.c: Revert.
6089         * exceptions.c: Revert.
6090         * event-top.c: Revert.
6091         * event-loop.c: Revert.
6092         * eval.c: Revert.
6093         * elfread.c: Revert.
6094         * dwarf2read.h: Revert.
6095         * dwarf2read.c: Revert.
6096         * dwarf2loc.c: Revert.
6097         * dwarf2expr.h: Revert.
6098         * dwarf2expr.c: Revert.
6099         * dwarf2-frame.c: Revert.
6100         * dwarf2-frame-tailcall.c: Revert.
6101         * dwarf-index-write.h: Revert.
6102         * dwarf-index-write.c: Revert.
6103         * dwarf-index-common.c: Revert.
6104         * dwarf-index-cache.h: Revert.
6105         * dwarf-index-cache.c: Revert.
6106         * dummy-frame.c: Revert.
6107         * dtrace-probe.c: Revert.
6108         * disasm.h: Revert.
6109         * disasm.c: Revert.
6110         * disasm-selftests.c: Revert.
6111         * dictionary.c: Revert.
6112         * dicos-tdep.c: Revert.
6113         * demangle.c: Revert.
6114         * dcache.h: Revert.
6115         * dcache.c: Revert.
6116         * darwin-nat.h: Revert.
6117         * darwin-nat.c: Revert.
6118         * darwin-nat-info.c: Revert.
6119         * d-valprint.c: Revert.
6120         * d-namespace.c: Revert.
6121         * d-lang.c: Revert.
6122         * ctf.c: Revert.
6123         * csky-tdep.c: Revert.
6124         * csky-linux-tdep.c: Revert.
6125         * cris-tdep.c: Revert.
6126         * cris-linux-tdep.c: Revert.
6127         * cp-valprint.c: Revert.
6128         * cp-support.c: Revert.
6129         * cp-namespace.c: Revert.
6130         * cp-abi.c: Revert.
6131         * corelow.c: Revert.
6132         * corefile.c: Revert.
6133         * continuations.c: Revert.
6134         * completer.h: Revert.
6135         * completer.c: Revert.
6136         * complaints.c: Revert.
6137         * coffread.c: Revert.
6138         * coff-pe-read.c: Revert.
6139         * cli-out.h: Revert.
6140         * cli-out.c: Revert.
6141         * charset.c: Revert.
6142         * c-varobj.c: Revert.
6143         * c-valprint.c: Revert.
6144         * c-typeprint.c: Revert.
6145         * c-lang.c: Revert.
6146         * buildsym.c: Revert.
6147         * buildsym-legacy.c: Revert.
6148         * build-id.h: Revert.
6149         * build-id.c: Revert.
6150         * btrace.c: Revert.
6151         * bsd-uthread.c: Revert.
6152         * breakpoint.h: Revert.
6153         * breakpoint.c: Revert.
6154         * break-catch-throw.c: Revert.
6155         * break-catch-syscall.c: Revert.
6156         * break-catch-sig.c: Revert.
6157         * blockframe.c: Revert.
6158         * block.c: Revert.
6159         * bfin-tdep.c: Revert.
6160         * bfin-linux-tdep.c: Revert.
6161         * bfd-target.c: Revert.
6162         * bcache.c: Revert.
6163         * ax-general.c: Revert.
6164         * ax-gdb.h: Revert.
6165         * ax-gdb.c: Revert.
6166         * avr-tdep.c: Revert.
6167         * auxv.c: Revert.
6168         * auto-load.c: Revert.
6169         * arm-wince-tdep.c: Revert.
6170         * arm-tdep.c: Revert.
6171         * arm-symbian-tdep.c: Revert.
6172         * arm-pikeos-tdep.c: Revert.
6173         * arm-obsd-tdep.c: Revert.
6174         * arm-nbsd-tdep.c: Revert.
6175         * arm-nbsd-nat.c: Revert.
6176         * arm-linux-tdep.c: Revert.
6177         * arm-linux-nat.c: Revert.
6178         * arm-fbsd-tdep.c: Revert.
6179         * arm-fbsd-nat.c: Revert.
6180         * arm-bsd-tdep.c: Revert.
6181         * arch-utils.c: Revert.
6182         * arc-tdep.c: Revert.
6183         * arc-newlib-tdep.c: Revert.
6184         * annotate.h: Revert.
6185         * annotate.c: Revert.
6186         * amd64-windows-tdep.c: Revert.
6187         * amd64-windows-nat.c: Revert.
6188         * amd64-tdep.c: Revert.
6189         * amd64-sol2-tdep.c: Revert.
6190         * amd64-obsd-tdep.c: Revert.
6191         * amd64-obsd-nat.c: Revert.
6192         * amd64-nbsd-tdep.c: Revert.
6193         * amd64-nbsd-nat.c: Revert.
6194         * amd64-nat.c: Revert.
6195         * amd64-linux-tdep.c: Revert.
6196         * amd64-linux-nat.c: Revert.
6197         * amd64-fbsd-tdep.c: Revert.
6198         * amd64-fbsd-nat.c: Revert.
6199         * amd64-dicos-tdep.c: Revert.
6200         * amd64-darwin-tdep.c: Revert.
6201         * amd64-bsd-nat.c: Revert.
6202         * alpha-tdep.c: Revert.
6203         * alpha-obsd-tdep.c: Revert.
6204         * alpha-nbsd-tdep.c: Revert.
6205         * alpha-mdebug-tdep.c: Revert.
6206         * alpha-linux-tdep.c: Revert.
6207         * alpha-linux-nat.c: Revert.
6208         * alpha-bsd-tdep.c: Revert.
6209         * alpha-bsd-nat.c: Revert.
6210         * aix-thread.c: Revert.
6211         * agent.c: Revert.
6212         * addrmap.c: Revert.
6213         * ada-varobj.c: Revert.
6214         * ada-valprint.c: Revert.
6215         * ada-typeprint.c: Revert.
6216         * ada-tasks.c: Revert.
6217         * ada-lang.c: Revert.
6218         * aarch64-tdep.c: Revert.
6219         * aarch64-ravenscar-thread.c: Revert.
6220         * aarch64-newlib-tdep.c: Revert.
6221         * aarch64-linux-tdep.c: Revert.
6222         * aarch64-linux-nat.c: Revert.
6223         * aarch64-fbsd-tdep.c: Revert.
6224         * aarch64-fbsd-nat.c: Revert.
6225         * aarch32-linux-nat.c: Revert.
6226
6227 2019-04-05  Tom Tromey  <tom@tromey.com>
6228
6229         * ft32-tdep.c: Sort headers.
6230         * frv-tdep.c: Sort headers.
6231         * frv-linux-tdep.c: Sort headers.
6232         * frame.c: Sort headers.
6233         * frame-unwind.c: Sort headers.
6234         * frame-base.c: Sort headers.
6235         * fork-child.c: Sort headers.
6236         * findvar.c: Sort headers.
6237         * findcmd.c: Sort headers.
6238         * filesystem.c: Sort headers.
6239         * filename-seen-cache.h: Sort headers.
6240         * filename-seen-cache.c: Sort headers.
6241         * fbsd-tdep.c: Sort headers.
6242         * fbsd-nat.h: Sort headers.
6243         * fbsd-nat.c: Sort headers.
6244         * f-valprint.c: Sort headers.
6245         * f-typeprint.c: Sort headers.
6246         * f-lang.c: Sort headers.
6247         * extension.h: Sort headers.
6248         * extension.c: Sort headers.
6249         * extension-priv.h: Sort headers.
6250         * expprint.c: Sort headers.
6251         * exec.h: Sort headers.
6252         * exec.c: Sort headers.
6253         * exceptions.c: Sort headers.
6254         * event-top.c: Sort headers.
6255         * event-loop.c: Sort headers.
6256         * eval.c: Sort headers.
6257         * elfread.c: Sort headers.
6258         * dwarf2read.h: Sort headers.
6259         * dwarf2read.c: Sort headers.
6260         * dwarf2loc.c: Sort headers.
6261         * dwarf2expr.h: Sort headers.
6262         * dwarf2expr.c: Sort headers.
6263         * dwarf2-frame.c: Sort headers.
6264         * dwarf2-frame-tailcall.c: Sort headers.
6265         * dwarf-index-write.h: Sort headers.
6266         * dwarf-index-write.c: Sort headers.
6267         * dwarf-index-common.c: Sort headers.
6268         * dwarf-index-cache.h: Sort headers.
6269         * dwarf-index-cache.c: Sort headers.
6270         * dummy-frame.c: Sort headers.
6271         * dtrace-probe.c: Sort headers.
6272         * disasm.h: Sort headers.
6273         * disasm.c: Sort headers.
6274         * disasm-selftests.c: Sort headers.
6275         * dictionary.c: Sort headers.
6276         * dicos-tdep.c: Sort headers.
6277         * demangle.c: Sort headers.
6278         * dcache.h: Sort headers.
6279         * dcache.c: Sort headers.
6280         * darwin-nat.h: Sort headers.
6281         * darwin-nat.c: Sort headers.
6282         * darwin-nat-info.c: Sort headers.
6283         * d-valprint.c: Sort headers.
6284         * d-namespace.c: Sort headers.
6285         * d-lang.c: Sort headers.
6286         * ctf.c: Sort headers.
6287         * csky-tdep.c: Sort headers.
6288         * csky-linux-tdep.c: Sort headers.
6289         * cris-tdep.c: Sort headers.
6290         * cris-linux-tdep.c: Sort headers.
6291         * cp-valprint.c: Sort headers.
6292         * cp-support.c: Sort headers.
6293         * cp-namespace.c: Sort headers.
6294         * cp-abi.c: Sort headers.
6295         * corelow.c: Sort headers.
6296         * corefile.c: Sort headers.
6297         * continuations.c: Sort headers.
6298         * completer.h: Sort headers.
6299         * completer.c: Sort headers.
6300         * complaints.c: Sort headers.
6301         * coffread.c: Sort headers.
6302         * coff-pe-read.c: Sort headers.
6303         * cli-out.h: Sort headers.
6304         * cli-out.c: Sort headers.
6305         * charset.c: Sort headers.
6306         * c-varobj.c: Sort headers.
6307         * c-valprint.c: Sort headers.
6308         * c-typeprint.c: Sort headers.
6309         * c-lang.c: Sort headers.
6310         * buildsym.c: Sort headers.
6311         * buildsym-legacy.c: Sort headers.
6312         * build-id.h: Sort headers.
6313         * build-id.c: Sort headers.
6314         * btrace.c: Sort headers.
6315         * bsd-uthread.c: Sort headers.
6316         * breakpoint.h: Sort headers.
6317         * breakpoint.c: Sort headers.
6318         * break-catch-throw.c: Sort headers.
6319         * break-catch-syscall.c: Sort headers.
6320         * break-catch-sig.c: Sort headers.
6321         * blockframe.c: Sort headers.
6322         * block.c: Sort headers.
6323         * bfin-tdep.c: Sort headers.
6324         * bfin-linux-tdep.c: Sort headers.
6325         * bfd-target.c: Sort headers.
6326         * bcache.c: Sort headers.
6327         * ax-general.c: Sort headers.
6328         * ax-gdb.h: Sort headers.
6329         * ax-gdb.c: Sort headers.
6330         * avr-tdep.c: Sort headers.
6331         * auxv.c: Sort headers.
6332         * auto-load.c: Sort headers.
6333         * arm-wince-tdep.c: Sort headers.
6334         * arm-tdep.c: Sort headers.
6335         * arm-symbian-tdep.c: Sort headers.
6336         * arm-pikeos-tdep.c: Sort headers.
6337         * arm-obsd-tdep.c: Sort headers.
6338         * arm-nbsd-tdep.c: Sort headers.
6339         * arm-nbsd-nat.c: Sort headers.
6340         * arm-linux-tdep.c: Sort headers.
6341         * arm-linux-nat.c: Sort headers.
6342         * arm-fbsd-tdep.c: Sort headers.
6343         * arm-fbsd-nat.c: Sort headers.
6344         * arm-bsd-tdep.c: Sort headers.
6345         * arch-utils.c: Sort headers.
6346         * arc-tdep.c: Sort headers.
6347         * arc-newlib-tdep.c: Sort headers.
6348         * annotate.h: Sort headers.
6349         * annotate.c: Sort headers.
6350         * amd64-windows-tdep.c: Sort headers.
6351         * amd64-windows-nat.c: Sort headers.
6352         * amd64-tdep.c: Sort headers.
6353         * amd64-sol2-tdep.c: Sort headers.
6354         * amd64-obsd-tdep.c: Sort headers.
6355         * amd64-obsd-nat.c: Sort headers.
6356         * amd64-nbsd-tdep.c: Sort headers.
6357         * amd64-nbsd-nat.c: Sort headers.
6358         * amd64-nat.c: Sort headers.
6359         * amd64-linux-tdep.c: Sort headers.
6360         * amd64-linux-nat.c: Sort headers.
6361         * amd64-fbsd-tdep.c: Sort headers.
6362         * amd64-fbsd-nat.c: Sort headers.
6363         * amd64-dicos-tdep.c: Sort headers.
6364         * amd64-darwin-tdep.c: Sort headers.
6365         * amd64-bsd-nat.c: Sort headers.
6366         * alpha-tdep.c: Sort headers.
6367         * alpha-obsd-tdep.c: Sort headers.
6368         * alpha-nbsd-tdep.c: Sort headers.
6369         * alpha-mdebug-tdep.c: Sort headers.
6370         * alpha-linux-tdep.c: Sort headers.
6371         * alpha-linux-nat.c: Sort headers.
6372         * alpha-bsd-tdep.c: Sort headers.
6373         * alpha-bsd-nat.c: Sort headers.
6374         * aix-thread.c: Sort headers.
6375         * agent.c: Sort headers.
6376         * addrmap.c: Sort headers.
6377         * ada-varobj.c: Sort headers.
6378         * ada-valprint.c: Sort headers.
6379         * ada-typeprint.c: Sort headers.
6380         * ada-tasks.c: Sort headers.
6381         * ada-lang.c: Sort headers.
6382         * aarch64-tdep.c: Sort headers.
6383         * aarch64-ravenscar-thread.c: Sort headers.
6384         * aarch64-newlib-tdep.c: Sort headers.
6385         * aarch64-linux-tdep.c: Sort headers.
6386         * aarch64-linux-nat.c: Sort headers.
6387         * aarch64-fbsd-tdep.c: Sort headers.
6388         * aarch64-fbsd-nat.c: Sort headers.
6389         * aarch32-linux-nat.c: Sort headers.
6390
6391 2019-04-04  Tom Tromey  <tom@tromey.com>
6392
6393         * varobj.c (varobj_create): Update.
6394         * rust-exp.y (struct rust_parser) <update_innermost_block,
6395         lookup_symbol>: New methods.
6396         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6397         Rename.
6398         (rust_parser::rust_lookup_type)
6399         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6400         * printcmd.c (display_command, do_one_display): Update.
6401         * parser-defs.h (struct parser_state) <parser_state>: Add
6402         "tracker" parameter.
6403         (block_tracker): New member.
6404         (class innermost_block_tracker) <innermost_block_tracker>: Add
6405         "types" parameter.
6406         <reset>: Remove method.
6407         (innermost_block): Don't declare.
6408         (null_post_parser): Update.
6409         * parse.c (innermost_block): Remove global.
6410         (write_dollar_variable): Update.
6411         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6412         Remove "tracker_types" parameter.
6413         (parse_expression): Add "tracker" parameter.
6414         (parse_expression_for_completion): Update.
6415         (null_post_parser): Add "tracker" parameter.
6416         * p-exp.y: Update rules.
6417         * m2-exp.y: Update rules.
6418         * language.h (struct language_defn) <la_post_parser>: Add
6419         "tracker" parameter.
6420         * go-exp.y: Update rules.
6421         * f-exp.y: Update rules.
6422         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6423         parameter.
6424         * d-exp.y: Update rules.
6425         * c-exp.y: Update rules.
6426         * breakpoint.c (set_breakpoint_condition): Create an
6427         innermost_block_tracker.
6428         (watch_command_1): Likewise.
6429         * ada-lang.c (resolve): Add "tracker" parameter.
6430         (resolve_subexp): Likewise.
6431         * ada-exp.y (write_var_from_sym): Update.
6432
6433 2019-04-04  Tom Tromey  <tom@tromey.com>
6434
6435         * type-stack.h: New file.
6436         * type-stack.c: New file.
6437         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6438         type-stack.h.
6439         (insert_into_type_stack, insert_type, push_type, push_type_int)
6440         (insert_type_address_space, pop_type, pop_type_int)
6441         (pop_typelist, pop_type_stack, append_type_stack)
6442         (push_type_stack, get_type_stack, push_typelist)
6443         (follow_type_instance_flags, follow_types): Don't declare.
6444         * parse.c (type_stack): Remove global.
6445         (parse_exp_in_context): Update.
6446         (insert_into_type_stack, insert_type, push_type, push_type_int)
6447         (insert_type_address_space, pop_type, pop_type_int)
6448         (pop_typelist, pop_type_stack, append_type_stack)
6449         (push_type_stack, get_type_stack, push_typelist)
6450         (follow_type_instance_flags, follow_types): Remove (moved to
6451         type-stack.c).
6452         * f-exp.y (type_stack): New global.
6453         Update rules.
6454         (push_kind_type, f_parse): Update.
6455         * d-exp.y (type_stack): New global.
6456         Update rules.
6457         (d_parse): Update.
6458         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6459         Update rules.
6460         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6461         (HFILES_NO_SRCDIR): Add type-stack.h.
6462
6463 2019-04-04  Tom Tromey  <tom@tromey.com>
6464
6465         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6466         (rust_parser::convert_ast_to_expression, rust_parse)
6467         (rust_lex_test_completion, rust_lex_tests): Update.
6468         * parser-defs.h (struct expr_completion_state): New.
6469         (struct parser_state) <parser_state>: Add completion parameter.
6470         <mark_struct_expression, mark_completion_tag>: New methods.
6471         <parse_completion, m_completion_state>: New members.
6472         (prefixify_expression, null_post_parser): Update.
6473         (mark_struct_expression, mark_completion_tag): Don't declare.
6474         * parse.c (parse_completion, expout_last_struct)
6475         (expout_tag_completion_type, expout_completion_name): Remove
6476         globals.
6477         (parser_state::mark_struct_expression)
6478         (parser_state::mark_completion_tag): Now methods.
6479         (prefixify_expression): Add last_struct parameter.
6480         (prefixify_subexp): Likewise.
6481         (parse_exp_1): Update.
6482         (parse_exp_in_context): Add cstate parameter.  Update.
6483         (parse_expression_for_completion): Create an
6484         expr_completion_state.
6485         (null_post_parser): Add "completion" parameter.
6486         * p-exp.y: Update rules.
6487         (yylex): Update.
6488         * language.h (struct language_defn) <la_post_parser>: Add
6489         "completing" parameter.
6490         * go-exp.y: Update rules.
6491         (lex_one_token): Update.
6492         * expression.h (parse_completion): Don't declare.
6493         * d-exp.y: Update rules.
6494         (lex_one_token): Update rules.
6495         * c-exp.y: Update rules.
6496         (lex_one_token): Update.
6497         * ada-lang.c (resolve): Add "parse_completion" parameter.
6498         (resolve_subexp): Likewise.
6499         (ada_resolve_function): Likewise.
6500
6501 2019-04-04  Tom Tromey  <tom@tromey.com>
6502
6503         * parser-defs.h (struct parser_state) <start_arglist,
6504         end_arglist>: New methods.
6505         <arglist_len, m_funcall_chain>: New members.
6506         (arglist_len, start_arglist, end_arglist): Don't declare.
6507         * parse.c (arglist_len, funcall_chain): Remove global.
6508         (start_arglist, end_arglist): Remove functions.
6509         (parse_exp_in_context): Update.
6510         * p-exp.y: Update rules.
6511         * m2-exp.y: Update rules.
6512         * go-exp.y: Update rules.
6513         * f-exp.y: Update rules.
6514         * d-exp.y: Update rules.
6515         * c-exp.y: Update rules.
6516
6517 2019-04-04  Tom Tromey  <tom@tromey.com>
6518
6519         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6520         lex_operator, push_back>: New methods.
6521         Update all rules.
6522         (rust_parser::lex_hex, lex_escape): Rename and update.
6523         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6524         (rust_parser::lex_operator): Rename and update.
6525         (rust_parser::lex_number, rustyylex, rustyyerror)
6526         (rust_lex_test_init, rust_lex_test_sequence)
6527         (rust_lex_test_push_back, rust_lex_tests): Update.
6528         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6529         parameter.
6530         <lexptr, prev_lexptr>: New members.
6531         (lexptr, prev_lexptr): Don't declare.
6532         * parse.c (lexptr, prev_lexptr): Remove globals.
6533         (parse_exp_in_context): Update.
6534         * p-exp.y (yylex, yyerror): Update.
6535         * m2-exp.y (parse_number, yylex, yyerror): Update.
6536         * go-exp.y (lex_one_token, yyerror): Update.
6537         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6538         * d-exp.y (lex_one_token, yyerror): Update.
6539         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6540         (lex_one_token, yyerror): Update.
6541         * ada-lex.l (YY_INPUT): Update.
6542         (rewind_to_char): Update.
6543         * ada-exp.y (yyerror): Update.
6544
6545 2019-04-04  Tom Tromey  <tom@tromey.com>
6546
6547         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6548         * parser-defs.h (struct parser_state) <parser_state>: Add new
6549         parameter.
6550         <comma_terminates>: New member.
6551         (comma_terminates): Don't declare global.
6552         * parse.c (comma_terminates): Remove global.
6553         (parse_exp_in_context): Update.
6554         * p-exp.y (yylex): Update.
6555         * m2-exp.y (yylex): Update.
6556         * go-exp.y (lex_one_token): Update.
6557         * f-exp.y (yylex): Update.
6558         * d-exp.y (lex_one_token): Update.
6559         * c-exp.y (lex_one_token): Update.
6560         * ada-lex.l: Update.
6561
6562 2019-04-04  Tom Tromey  <tom@tromey.com>
6563
6564         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6565         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6566         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6567         * parser-defs.h (paren_depth): Don't declare.
6568         * parse.c (paren_depth): Remove global.
6569         (parse_exp_in_context): Update.
6570         * p-exp.y (paren_depth): New global.
6571         (pascal_parse): Initialize it.
6572         * m2-exp.y (paren_depth): New global.
6573         (m2_parse): Initialize it.
6574         * go-exp.y (paren_depth): New global.
6575         (go_parse): Initialize it.
6576         * f-exp.y (paren_depth): New global.
6577         (f_parse): Initialize it.
6578         * d-exp.y (paren_depth): New global.
6579         (d_parse): Initialize it.
6580         * c-exp.y (paren_depth): New global.
6581         (c_parse): Initialize it.
6582         * ada-lex.l (paren_depth): New global.
6583         (lexer_init): Initialize it.
6584
6585 2019-04-04  Tom Tromey  <tom@tromey.com>
6586
6587         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6588         (rust_parser::convert_ast_to_type)
6589         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6590         * parser-defs.h (struct parser_state) <parser_state>: Add
6591         parameters.  Initialize new members.
6592         <expression_context_block, expression_context_pc>: New members.
6593         * parse.c (expression_context_block, expression_context_pc):
6594         Remove globals.
6595         (parse_exp_in_context): Update.
6596         * p-exp.y: Update all rules.
6597         (yylex): Update.
6598         * m2-exp.y: Update all rules.
6599         (yylex): Update.
6600         * go-exp.y (yylex): Update.
6601         * f-exp.y (yylex): Update.
6602         * d-exp.y: Update all rules.
6603         (yylex): Update.
6604         * c-exp.y: Update all rules.
6605         (lex_one_token, classify_name, yylex, c_parse): Update.
6606         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6607
6608 2019-04-04  Tom Tromey  <tom@tromey.com>
6609
6610         * gdbarch.h, gdbarch.c: Rebuild.
6611         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6612         * stap-probe.h:
6613         (struct stap_parse_info): Replace "parser_state" with
6614         "expr_builder".
6615         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6616         (parser_state): New class.
6617         * parse.c (expr_builder): Rename.
6618         (expr_builder::release): Rename.
6619         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6620         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6621         (write_exp_elt_longcst, write_exp_elt_floatcst)
6622         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6623         (write_exp_string_vector, write_exp_bitstring)
6624         (write_exp_msymbol, mark_struct_expression)
6625         (write_dollar_variable)
6626         (insert_type_address_space, increase_expout_size): Replace
6627         "parser_state" with "expr_builder".
6628         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6629         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6630         "parser_state" with "expr_builder".
6631
6632 2019-04-04  Tom Tromey  <tom@tromey.com>
6633
6634         * rust-exp.y: Replace "parse_language" with method call.
6635         * p-exp.y:
6636         (yylex): Replace "parse_language" with method call.
6637         * m2-exp.y:
6638         (yylex): Replace "parse_language" with method call.
6639         * go-exp.y (classify_name): Replace "parse_language" with method
6640         call.
6641         * f-exp.y (yylex): Replace "parse_language" with method call.
6642         * d-exp.y (lex_one_token): Replace "parse_language" with method
6643         call.
6644         * c-exp.y:
6645         (lex_one_token, classify_name, yylex): Replace "parse_language"
6646         with method call.
6647         * ada-exp.y (find_primitive_type, type_char)
6648         (type_system_address): Replace "parse_language" with method call.
6649
6650 2019-04-04  Tom Tromey  <tom@tromey.com>
6651
6652         * rust-exp.y: Replace "parse_gdbarch" with method call.
6653         * parse.c (write_dollar_variable, insert_type_address_space):
6654         Replace "parse_gdbarch" with method call.
6655         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6656         call.
6657         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6658         call.
6659         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6660         "parse_gdbarch" with method call.
6661         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6662         with method call.
6663         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6664         "parse_gdbarch" with method call.
6665         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6666         "parse_gdbarch" with method call.
6667         * c-exp.y (parse_type, parse_number, classify_name): Replace
6668         "parse_gdbarch" with method call.
6669         * ada-lex.l: Replace "parse_gdbarch" with method call.
6670         * ada-exp.y (parse_type, find_primitive_type, type_char)
6671         (type_system_address): Replace "parse_gdbarch" with method call.
6672
6673 2019-04-04  Tom Tromey  <tom@tromey.com>
6674
6675         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6676         * stap-probe.c (stap_parse_argument): Update.
6677         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6678         initial_size parameter.
6679         * rust-exp.y (rust_lex_tests): Update.
6680         * parse.c (parser_state): Update.
6681         (parse_exp_in_context): Update.
6682         * parser-defs.h (struct parser_state) <parser_state>: Remove
6683         "initial_size" parameter.
6684
6685 2019-04-04  Tom Tromey  <tom@tromey.com>
6686
6687         * parser-defs.h (increase_expout_size): Don't declare.
6688         * parse.c (increase_expout_size): Now static.
6689
6690 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6691
6692         * gnu-nat.c (gnu_nat_target::wait): Fix
6693         target_waitstatus_to_string call.
6694
6695 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6696
6697         * eval.c (evaluate_subexp_standard): Handle internal functions
6698         during Fortran function call handling.
6699
6700 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6701
6702         * NEWS: Mention new internal functions.
6703         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6704         (read_base_type): Use dwarf2_init_complex_target_type.
6705         * value.c (creal_internal_fn): New function.
6706         (cimag_internal_fn): New function.
6707         (_initialize_values): Register new internal functions.
6708
6709 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6710
6711         * infrun.c (stop_all_threads): If debug_infrun, always
6712         trace the wait status after wait_one, using
6713         target_waitstatus_to_string and target_pid_to_str.
6714         (handle_inferior_event): Replace various trace of
6715         wait status kind by a single trace.
6716         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6717         wait status kind image by target_waitstatus_to_string.
6718         * target/waitstatus.c (target_waitstatus_to_string): Fix
6719         obsolete comment.
6720
6721 2019-04-01  Tom Tromey  <tromey@adacore.com>
6722
6723         PR symtab/23331:
6724         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6725
6726 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6727             Pedro Alves  <palves@redhat.com>
6728
6729         * top.c (quit_force): Call 'finalize_values'.
6730         * value.c (finalize_values): New function.
6731         * value.h (finalize_values): Declare.
6732
6733 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6734
6735         * NEWS: Announce $_gdb_major and $_gdb_minor.
6736
6737         * top.c (init_gdb_version_vars): New function.
6738         (gdb_init): Call init_gdb_version_vars.
6739
6740 2019-03-29  Tom Tromey  <tromey@adacore.com>
6741
6742         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6743         help text.  Remove dead code.
6744
6745 2019-03-29  Keith Seitz  <keiths@redhat.com>
6746
6747         From Siddhesh Poyarekar:
6748         * f-lang.h (f77_get_upperbound): Return LONGEST.
6749         (f77_get_lowerbound): Likewise.
6750         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6751         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6752         print them.
6753         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6754         plongest to format print it.
6755         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6756         (f77_get_upperbound): Likewise.
6757         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6758         LOWER_BOUND to LONGEST.
6759         (f77_create_arrayprint_offset_tbl): Likewise.
6760
6761 2019-03-29  Keith Seitz  <keiths@redhat.com>
6762
6763         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6764         %s/pulongest for TYPE_LENGTH instead of %d in format
6765         strings.
6766         * ada-typerint.c (ada_print_type): Likewise.
6767         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6768         * compile/compile-c-support.c (generate_register_struct): Likewise.
6769         * gdbtypes.c (recursive_dump_type): Likewise.
6770         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6771         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6772         instead of %d in format strings.
6773         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6774         to std::min to ULONGEST.
6775         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6776         instead of %d in format strings.
6777         * tracepoint.c (info_scope_command): Likewise.
6778         * typeprint.c (print_offset_data::update)
6779         (print_offset_data::finish): Likewise.
6780         * xtensa-tdep.c (xtensa_store_return_value)
6781         (xtensa_push_dummy_call): Likewise.
6782
6783 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6784
6785         * windows-nat.c (display_selector): Fixed format specifications
6786         for 64-bit Cygwin.
6787
6788 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6789
6790         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6791
6792 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6793
6794         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6795         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6796         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6797         (nios2_linux_init_abi): Install it.
6798
6799 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6800
6801         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6802
6803 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6804
6805         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6806
6807 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6808             Tom Tromey  <tromey@adacore.com>
6809
6810         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6811
6812 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6813
6814         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6815         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6816         method to compute the bounds of range types. Also print "[evaluated]"
6817         if the bounds' values come from a dynamic evaluation.
6818
6819 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6820
6821         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6822         whitespace when pretty printing is on.
6823
6824 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6825
6826         * ppc-linux-nat.c: Add include.
6827
6828 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6829
6830         * NEWS: Mention AArch64 Pointer Authentication.
6831
6832 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6833
6834         * arm-linux-nat.c: Add include.
6835
6836 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6837
6838         * source-cache.c (source_cache::get_source_lines): Re-read
6839         fullname after calling open_source_file.
6840
6841 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6842
6843         * NEWS: Mention TLS support for FreeBSD.
6844
6845 2019-03-25  Tom Tromey  <tromey@adacore.com>
6846
6847         * minsyms.c (BUNCH_SIZE): Update comment.
6848         (~minimal_symbol_reader): Remove old comment.
6849         (compact_minimal_symbols): Update comment.
6850         (minimal_symbol_reader::install): Remove old comment.  Update
6851         other comments.
6852
6853 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6854
6855         * s390-linux-nat.c: Add include.
6856
6857 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6858
6859         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6860         Call linux_get_hwcap.
6861         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6862         Likewise.
6863         (aarch64_linux_get_hwcap): Remove function.
6864         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6865         declaration.
6866         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6867         linux_get_hwcap.
6868         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6869         * linux-tdep.c (linux_get_hwcap): Add function.
6870         (linux_get_hwcap2): Likewise.
6871         * linux-tdep.h (linux_get_hwcap): Add declaration.
6872         (linux_get_hwcap2): Likewise.
6873         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6874         (ppc_linux_get_hwcap2): Likewise.
6875         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6876         linux_get_hwcap.
6877         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6878         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6879         (ppc_linux_nat_target::read_description): Likewise.
6880         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6881         * s390-linux-nat.c: Likewise.
6882         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6883
6884 2019-03-24  Tom Tromey  <tom@tromey.com>
6885
6886         * ada-lang.c (standard_lookup): Simplify initialization.
6887         (ada_lookup_symbol_nonlocal): Simplify return.
6888         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6889         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6890         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6891         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6892         initialization.
6893         * solib.c (solib_global_lookup): Simplify.
6894         * symtab.c (null_block_symbol): Remove.
6895         (symbol_cache_lookup): Simplify returns.
6896         (lookup_language_this): Simplify returns.
6897         (lookup_symbol_aux): Simplify return.
6898         (lookup_local_symbol): Simplify returns.
6899         (lookup_global_symbol_from_objfile): Simplify return.
6900         (lookup_symbol_in_objfile_symtabs)
6901         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6902         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6903         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6904         * cp-namespace.c (cp_lookup_bare_symbol)
6905         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6906         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6907         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6908         (cp_lookup_symbol_via_imports): Simplify initialization.
6909         (find_symbol_in_baseclass): Likewise.
6910         * symtab.h (null_block_symbol): Remove.
6911         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6912         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6913         (d_lookup_symbol_module): Likewise.
6914         (find_symbol_in_baseclass): Simplify initialization.
6915
6916 2019-03-24  Tom Tromey  <tom@tromey.com>
6917
6918         * expression.h: Don't include symtab.h.
6919         (struct block): Forward declare.
6920
6921 2019-03-24  Tom Tromey  <tom@tromey.com>
6922
6923         * c-exp.y (typebase): Remove casts.
6924         * gdbtypes.c (lookup_unsigned_typename, )
6925         (lookup_signed_typename): Remove cast.
6926         * eval.c (parse_to_comma_and_eval): Remove cast.
6927         * parse.c (write_dollar_variable): Remove cast.
6928         * block.h (struct block) <superblock>: Now const.
6929         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6930         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6931         (map_block): Make "block" const.
6932         * symfile.h (struct quick_symbol_functions)
6933         <map_matching_symbols>: Constify block argument to "callback".
6934         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6935         const.
6936         (find_pc_sect_compunit_symtab): Make "b" const.
6937         (find_symbol_at_address): Likewise.
6938         (search_symbols): Likewise.
6939         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6940         (dw2_debug_names_lookup_symbol): Likewise.
6941         (dw2_map_matching_symbols): Update.
6942         * p-valprint.c (pascal_val_print): Remove "block".
6943         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6944         (aux_add_nonlocal_symbols): Make "block" const.
6945         (resolve_subexp): Remove cast.
6946         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6947         const.
6948         (iterate_over_file_blocks): Likewise.
6949         * f-exp.y (%union) <bval>: Remove.
6950         * coffread.c (patch_opaque_types): Make "b" const.
6951         * spu-tdep.c (spu_catch_start): Make "block" const.
6952         * c-valprint.c (print_unpacked_pointer): Remove "block".
6953         * symmisc.c (dump_symtab_1): Make "b" const.
6954         (block_depth): Make "block" const.
6955         * d-exp.y (%union) <bval>: Remove.
6956         * cp-support.h (cp_lookup_rtti_type): Update.
6957         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6958         * psymtab.c (psym_lookup_symbol): Make "block" const.
6959         (maintenance_check_psymtabs): Make "b" const.
6960         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6961         (enumerate_locals, enumerate_args): Update.
6962         * python/py-symtab.c (stpy_global_block): Make "block" const.
6963         (stpy_static_block): Likewise.
6964         * inline-frame.c (block_starting_point_at): Make "new_block"
6965         const.
6966         * block.c (find_block_in_blockvector): Make return type const.
6967         (blockvector_for_pc_sect): Make "b" const.
6968         (find_block_in_blockvector): Make "b" const.
6969
6970 2019-03-23  Tom Tromey  <tom@tromey.com>
6971
6972         * varobj.c (varobj_create): Update.
6973         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6974         * printcmd.c (display_command, do_one_display): Don't reset
6975         innermost_block.
6976         * parser-defs.h (enum innermost_block_tracker_type): Move to
6977         expression.h.
6978         (innermost_block): Update comment.
6979         * parse.c (parse_exp_1): Add tracker_types parameter.
6980         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6981         tracker_types parameter.  Reset innermost_block.
6982         (parse_exp_in_context): Remove.
6983         (parse_expression_for_completion): Update.
6984         * objfiles.c (~objfile): Don't reset expression_context_block or
6985         innermost_block.
6986         * expression.h (enum innermost_block_tracker_type): Move from
6987         parser-defs.h.
6988         (parse_exp_1): Add tracker_types parameter.
6989         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6990         reset innermost_block.
6991
6992 2019-03-23  Tom Tromey  <tom@tromey.com>
6993
6994         * objfiles.h: Include bcache.h.
6995
6996 2019-03-23  Tom Tromey  <tom@tromey.com>
6997
6998         * linespec.c (get_current_search_block): Use
6999         scoped_restore_current_language.
7000         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7001
7002 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7003             Jiong Wang  <jiong.wang@arm.com>
7004
7005         * aarch64-linux-tdep.c
7006         (aarch64_linux_iterate_over_regset_sections): Check for pauth
7007         section.
7008         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7009
7010 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7011             Jiong Wang  <jiong.wang@arm.com>
7012
7013         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7014         instructions.
7015         (aarch64_analyze_prologue_test): Add PACIASP test.
7016         (aarch64_prologue_prev_register): Unmask PC value.
7017
7018 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7019             Jiong Wang  <jiong.wang@arm.com>
7020
7021         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7022         (aarch64_dwarf2_prev_register): Unmask PC value.
7023         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7024         (aarch64_execute_dwarf_cfa_vendor_op): Check for
7025         DW_CFA_AARCH64_negate_ra_state.
7026         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7027
7028 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7029             Jiong Wang  <jiong.wang@arm.com>
7030
7031         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7032         registers.
7033         (aarch64_pseudo_register_name): Likewise.
7034         (aarch64_pseudo_register_type): Likewise.
7035         (aarch64_pseudo_register_reggroup_p): Likewise.
7036         (aarch64_gdbarch_init): Add pauth registers.
7037         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
7038         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
7039         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
7040         (struct gdbarch_tdep): Add regnum for ra_state.
7041
7042 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7043             Jiong Wang  <jiong.wang@arm.com>
7044
7045         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
7046
7047 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7048             Jiong Wang  <jiong.wang@arm.com>
7049
7050         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
7051         function.
7052         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7053         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7054         (aarch64_gdbarch_init): Add puth registers.
7055         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
7056         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
7057         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
7058
7059 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7060             Jiong Wang  <jiong.wang@arm.com>
7061
7062         * aarch64-linux-nat.c
7063         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7064         * aarch64-linux-tdep.c
7065         (aarch64_linux_core_read_description): Likewise.
7066         (aarch64_linux_get_hwcap): New function.
7067         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7068         (aarch64_linux_get_hwcap): New declaration.
7069
7070 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7071             Jiong Wang  <jiong.wang@arm.com>
7072
7073         * aarch64-linux-nat.c
7074         (aarch64_linux_nat_target::read_description): Add pauth param.
7075         * aarch64-linux-tdep.c
7076         (aarch64_linux_core_read_description): Likewise.
7077         * aarch64-tdep.c (struct target_desc): Add in pauth.
7078         (aarch64_read_description): Add pauth param.
7079         (aarch64_gdbarch_init): Likewise.
7080         * aarch64-tdep.h (aarch64_read_description): Likewise.
7081         * arch/aarch64.c (aarch64_create_target_description): Likewise.
7082         * arch/aarch64.h (aarch64_create_target_description): Likewise.
7083         * features/Makefile: Add new files.
7084         * features/aarch64-pauth.c: New file.
7085         * features/aarch64-pauth.xml: New file.
7086
7087 2019-03-20  Tom Tromey  <tromey@adacore.com>
7088
7089         * infrun.c (handle_inferior_event): Rename from
7090         handle_inferior_event_1.  Create a scoped_value_mark.
7091         (handle_inferior_event): Remove.
7092
7093 2019-03-19  Tom Tromey  <tromey@adacore.com>
7094
7095         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7096         * infrun.h (print_stop_event): Add "displays" parameter.
7097         * infrun.c (print_stop_event): Add "displays" parameter.
7098
7099 2019-03-19  Pedro Alves  <palves@redhat.com>
7100
7101         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7102         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
7103         to -1.  Fix TABs vs spaces.
7104         (tui_ui_out::tui_ui_out): Don't initialize fields here.
7105         * tui/tui-out.h (tui_ui_out) Add intro comments.
7106         <m_line, m_start_of_line>: In-class initialize, and add describing
7107         comment.
7108
7109 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
7110
7111         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7112         variable names.
7113         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7114
7115 2019-03-18  Pedro Alves  <palves@redhat.com>
7116             Eli Zaretskii <eliz@gnu.org>
7117
7118         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7119         m_line and m_start_of_line.
7120
7121 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
7122
7123         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7124         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7125         it returns a newline.  This fixes a regression in TU mode, whereby
7126         the next line is output on the same screen line as the user input.
7127
7128 2019-03-18  Tom Tromey  <tromey@adacore.com>
7129
7130         * minsyms.c (minimal_symbol_reader::install): Remove call to
7131         obstack_blank.
7132
7133 2019-03-18  Pedro Alves  <palves@redhat.com>
7134
7135         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7136         New globals.
7137         (apply_style): New, factored out from ...
7138         (apply_ansi_escape): ... this.  Handle reverse video mode.
7139         (tui_set_reverse_mode): New function.
7140         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7141         * tui/tui-winsource.c (tui_show_source_line): Use
7142         tui_set_reverse_mode instead of setting A_STANDOUT.
7143         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7144         New setter methods.
7145
7146 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
7147
7148         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7149         Handle tabs.
7150
7151 2019-03-18  Tom Tromey  <tromey@adacore.com>
7152
7153         * ada-lang.c (empty_array): Add "high" parameter.
7154         (ada_evaluate_subexp): Update.
7155
7156 2019-03-17  Sergei Trofimovich <siarheit@google.com>
7157
7158         * unittests/string_view-selftests.c: Define
7159         _initialize_string_view_selftests unconditionally.
7160
7161 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7162
7163         PR gdb/24350
7164         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7165
7166 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7167
7168         PR gdb/24351
7169         * windows-nat.c (display_selector): Fix format specifiers.
7170
7171 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
7172
7173         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7174         tui_refill_source_window instead of tui_refresh_win, to update the
7175         current execution line.  This fixes redisplay of the current line
7176         when stepping through the code with "next" or "step".
7177
7178 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7179
7180         * source-cache.c (source_cache::get_source_lines): Call
7181         find_source_lines to initialize s->nlines.  This fixes vertical
7182         scrolling of TUI source window when the DOWN arrow is pressed.
7183
7184 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7185
7186         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7187         linux-thread-db.c (_initialize_thread_db): Likewise.
7188
7189 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7190
7191         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7192         wclrtoeol in tui_show_source_line".  This reverts changes made in
7193         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7194
7195 2019-03-15  Tom Tromey  <tom@tromey.com>
7196
7197         * symtab.h (struct minimal_symbol): Derive from
7198         general_symbol_info.
7199         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7200         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7201         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7202         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7203         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7204         (MSYMBOL_SEARCH_NAME): Update.
7205         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7206         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7207         * minsyms.c (minimal_symbol_reader::record_full): Update.
7208
7209 2019-03-15  Tom Tromey  <tom@tromey.com>
7210
7211         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7212
7213 2019-03-15  Tom Tromey  <tom@tromey.com>
7214
7215         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7216         unique_xmalloc_ptr.
7217         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7218         Update.
7219         * minsyms.c (lookup_minimal_symbol_by_pc_section)
7220         (build_minimal_symbol_hash_tables)
7221         (minimal_symbol_reader::install): Update.
7222
7223 2019-03-15  Tom Tromey  <tom@tromey.com>
7224
7225         * symtab.c (create_demangled_names_hash): Update.
7226         (symbol_set_names): Update.
7227         * objfiles.h (struct objfile_per_bfd_storage)
7228         <demangled_names_hash>: Now an htab_up.
7229         * objfiles.c (objfile_per_bfd_storage): Simplify.
7230
7231 2019-03-15  Tom Tromey  <tom@tromey.com>
7232
7233         * objfiles.h (struct objfile_per_bfd_storage): Declare
7234         destructor.
7235         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7236         New.
7237         (get_objfile_bfd_data): Use new.  Don't initialize
7238         language_of_main.
7239         (free_objfile_per_bfd_storage): Remove.
7240         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7241
7242 2019-03-15  Tom Tromey  <tom@tromey.com>
7243
7244         * symfile.c (reread_symbols): Update.
7245         * objfiles.c (objfile::objfile): Update.
7246         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7247         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7248         comment.
7249         (minimal_symbol_reader::install): Update.
7250         (terminate_minimal_symbol_table): Remove.
7251         * jit.c (jit_object_close_impl): Update.
7252
7253 2019-03-15  Tom Tromey  <tom@tromey.com>
7254
7255         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7256         initializations.
7257
7258 2019-03-15  Tom Tromey  <tom@tromey.com>
7259
7260         * objfiles.h (struct objfile_per_bfd_storage)
7261         <demangled_hash_languages>: Now a bitset.
7262         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7263         (lookup_minimal_symbol): Update.
7264
7265 2019-03-15  Tom Tromey  <tom@tromey.com>
7266
7267         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7268         Don't return the symbol.
7269         * coffread.c (record_minimal_symbol): Use record_full.
7270
7271 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7272
7273         The MS-Windows port of ncurses fails to switch to a color pair if
7274         one or both of the colors are the implicit default colors.  This
7275         change records the default colors when TUI is initialized, and
7276         then specifies them explicitly when a color pair uses the default
7277         colors.  This allows color styling in TUI mode on MS-Windows.
7278
7279         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7280         ncurses_norm_attr.
7281         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7282         colors in ncurses_norm_attr.
7283         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7284         "none", replace it with the default color recorded in
7285         ncurses_norm_attr.
7286
7287 2019-03-14  Tom Tromey  <tromey@adacore.com>
7288
7289         * source-cache.h (class source_cache) <get_source_lines>: Return
7290         std::string.
7291         * source-cache.c (source_cache::extract_lines): Handle case where
7292         first_pos==npos.  Return std::string.
7293         (source_cache::get_source_lines): Update.
7294
7295 2019-03-14  Tom Tromey  <tromey@adacore.com>
7296
7297         * NEWS: Add item for "style sources" commands.
7298         * source-cache.c (source_cache::get_source_lines): Check
7299         source_styling.
7300         * cli/cli-style.c (source_styling): New global.
7301         (_initialize_cli_style): Add "style sources" commands.
7302         (show_style_sources): New function.
7303         * cli/cli-style.h (source_styling): Declare.
7304
7305 2019-03-14  Pedro Alves  <palves@redhat.com>
7306             Tom Tromey  <tromey@adacore.com>
7307
7308         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7309         * tui/tui-winsource.c (tui_refill_source_window): New function,
7310         from...
7311         (tui_horizontal_source_scroll): ... here.  Move some logic.
7312         * cli/cli-style.c (set_style_enabled): Notify new observable.
7313         * tui/tui-hooks.c (tui_redisplay_source): New function.
7314         (tui_attach_detach_observers): Attach or detach
7315         tui_redisplay_source.
7316         * observable.h (source_styling_changed): New observable.
7317         * observable.c: Define source_styling_changed observable.
7318
7319 2019-03-13  Tom Tromey  <tromey@adacore.com>
7320
7321         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7322         (i386_gnu_nat_target::store_registers): Update.
7323         * target-debug.h (target_debug_print_std_string): New macro.
7324         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7325         * windows-tdep.c (display_one_tib): Update.
7326         * tui/tui-stack.c (tui_make_status_line): Update.
7327         * top.c (print_inferior_quit_action): Update.
7328         * thread.c (thr_try_catch_cmd): Update.
7329         (add_thread_with_info): Update.
7330         (thread_target_id_str): Update.
7331         (thr_try_catch_cmd): Update.
7332         (thread_command): Update.
7333         (thread_find_command): Update.
7334         * record-btrace.c (record_btrace_target::info_record)
7335         (record_btrace_resume_thread, record_btrace_target::resume)
7336         (record_btrace_cancel_resume, record_btrace_step_thread)
7337         (record_btrace_target::wait, record_btrace_target::wait)
7338         (record_btrace_target::wait, record_btrace_target::stop): Update.
7339         * progspace.c (print_program_space): Update.
7340         * process-stratum-target.c
7341         (process_stratum_target::thread_address_space): Update.
7342         * linux-fork.c (linux_fork_mourn_inferior)
7343         (detach_checkpoint_command, info_checkpoints_command)
7344         (linux_fork_context): Update.
7345         (linux_fork_detach): Update.
7346         (class scoped_switch_fork_info): Update.
7347         (delete_checkpoint_command): Update.
7348         * infrun.c (follow_fork_inferior): Update.
7349         (follow_fork_inferior): Update.
7350         (proceed_after_vfork_done): Update.
7351         (handle_vfork_child_exec_or_exit): Update.
7352         (follow_exec): Update.
7353         (displaced_step_prepare_throw): Update.
7354         (displaced_step_restore): Update.
7355         (start_step_over): Update.
7356         (resume_1): Update.
7357         (clear_proceed_status_thread): Update.
7358         (proceed): Update.
7359         (print_target_wait_results): Update.
7360         (do_target_wait): Update.
7361         (context_switch): Update.
7362         (stop_all_threads): Update.
7363         (restart_threads): Update.
7364         (finish_step_over): Update.
7365         (handle_signal_stop): Update.
7366         (switch_back_to_stepped_thread): Update.
7367         (keep_going_pass_signal): Update.
7368         (print_exited_reason): Update.
7369         (normal_stop): Update.
7370         * inferior.c (inferior_pid_to_str): Change return type.
7371         (print_selected_inferior): Update.
7372         (add_inferior): Update.
7373         (detach_inferior): Update.
7374         * dummy-frame.c (fprint_dummy_frames): Update.
7375         * dcache.c (dcache_info_1): Update.
7376         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7377         (btrace_fetch, btrace_clear): Update.
7378         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7379         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7380         type.
7381         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7382         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7383         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7384         * gdbarch.c, gdbarch.h: Rebuild.
7385         * gdbarch.sh (core_pid_to_str): Change return type.
7386         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7387         return type.
7388         (windows_nat_target::pid_to_str): Change return type.
7389         (windows_delete_thread): Update.
7390         (windows_nat_target::attach): Update.
7391         (windows_nat_target::files_info): Update.
7392         * target-delegates.c: Rebuild.
7393         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7394         return type.
7395         (sol_thread_target::pid_to_str): Change return type.
7396         * remote.c (class remote_target) <pid_to_str>: Change return
7397         type.
7398         (remote_target::pid_to_str): Change return type.
7399         (extended_remote_target::attach, remote_target::remote_stop_ns)
7400         (remote_target::remote_notif_remove_queued_reply)
7401         (remote_target::push_stop_reply, remote_target::disable_btrace):
7402         Update.
7403         (extended_remote_target::attach): Update.
7404         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7405         type.
7406         (gdbsim_target::pid_to_str): Change return type.
7407         * ravenscar-thread.c (struct ravenscar_thread_target)
7408         <pid_to_str>: Change return type.
7409         (ravenscar_thread_target::pid_to_str): Change return type.
7410         * procfs.c (class procfs_target) <pid_to_str>: Change return
7411         type.
7412         (procfs_target::pid_to_str): Change return type.
7413         (procfs_target::attach): Update.
7414         (procfs_target::detach): Update.
7415         (procfs_target::fetch_registers): Update.
7416         (procfs_target::store_registers): Update.
7417         (procfs_target::wait): Update.
7418         (procfs_target::files_info): Update.
7419         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7420         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7421         return type.
7422         (nto_procfs_target::pid_to_str): Change return type.
7423         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7424         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7425         return type.
7426         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7427         (exit_lwp): Update.
7428         (attach_proc_task_lwp_callback, get_detach_signal)
7429         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7430         (linux_nat_target::resume, wait_lwp, stop_callback)
7431         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7432         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7433         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7434         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7435         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7436         type.
7437         (inf_ptrace_target::attach): Update.
7438         (inf_ptrace_target::files_info): Update.
7439         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7440         type.
7441         (go32_nat_target::pid_to_str): Change return type.
7442         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7443         (gnu_nat_target::wait): Update.
7444         (gnu_nat_target::wait): Update.
7445         (gnu_nat_target::resume): Update.
7446         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7447         (fbsd_nat_target::wait): Update.
7448         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7449         type.
7450         (darwin_nat_target::attach): Update.
7451         * corelow.c (class core_target) <pid_to_str>: Change return type.
7452         (core_target::pid_to_str): Change return type.
7453         * target.c (normal_pid_to_str): Change return type.
7454         (default_pid_to_str): Likewise.
7455         (target_pid_to_str): Change return type.
7456         (target_translate_tls_address): Update.
7457         (target_announce_detach): Update.
7458         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7459         return type.
7460         (bsd_uthread_target::pid_to_str): Change return type.
7461         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7462         type.
7463         (bsd_kvm_target::pid_to_str): Change return type.
7464         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7465         return type.
7466         (aix_thread_target::pid_to_str): Change return type.
7467         * target.h (struct target_ops) <pid_to_str>: Change return type.
7468         (target_pid_to_str, normal_pid_to_str): Likewise.
7469         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7470         type.
7471         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7472         type.
7473         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7474         return type.
7475         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7476         type.
7477         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7478         type.
7479         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7480         return type.
7481
7482 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7483
7484         * NEWS: Mention that the new default MI version is 3.  Mention
7485         changes to the output of commands and events that deal with
7486         multi-location breakpoints.
7487         * breakpoint.c: Include "mi/mi-out.h".
7488         (print_one_breakpoint): Change output syntax if using MI version
7489         >= 3.
7490         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7491         New.
7492         (mi_multi_location_breakpoint_output_fixed): New.
7493         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7494         (mi_cmd_fix_multi_location_breakpoint_output): New.
7495         (mi_multi_location_breakpoint_output_fixed): New.
7496         * mi/mi-cmds.c (mi_cmds): Register command
7497         -fix-multi-location-breakpoint-output.
7498         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7499         interpreter "mi".
7500
7501 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7502
7503         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7504         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7505         instantiate mi_ui_out based on interpreter name.
7506         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7507         * mi/mi-main.c (mi_load_progress): Likewise.
7508
7509 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7510
7511         * NEWS: Combine separate "New targets" sections for 8.3.
7512
7513 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7514
7515         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7516         (ppcfbsd_init_abi): Install gdbarch
7517         "fetch_tls_load_module_address" and "get_thread_local_address"
7518         methods.
7519
7520 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7521
7522         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7523         (riscv_fbsd_init_abi): Install gdbarch
7524         "fetch_tls_load_module_address" and "get_thread_local_address"
7525         methods.
7526
7527 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7528
7529         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7530         (i386fbsd_init_abi): Install gdbarch
7531         "fetch_tls_load_module_address" and "get_thread_local_address"
7532         methods.
7533
7534 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7535
7536         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7537         (amd64fbsd_init_abi): Install gdbarch
7538         "fetch_tls_load_module_address" and "get_thread_local_address"
7539         methods.
7540
7541 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7542
7543         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7544         (struct fbsd_pspace_data): New type.
7545         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7546         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7547         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7548         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7549         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7550
7551 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7552
7553         * gdbtypes.c (lookup_struct_elt): New function.
7554         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7555         * gdbtypes.h (struct struct_elt): New type.
7556         (lookup_struct_elt): New prototype.
7557
7558 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7559
7560         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7561         remove disabled code block.
7562
7563 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7564
7565         * gdbarch.sh (get_thread_local_address): New method.
7566         * gdbarch.h, gdbarch.c: Regenerate.
7567         * target.c (target_translate_tls_address): Use
7568         gdbarch_get_thread_local_address if present instead of
7569         target::get_thread_local_address.
7570
7571 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7572
7573         * target.h (target::get_thread_local_address): Update comment.
7574
7575 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7576
7577         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7578         objfile->separate_debug_objfile_backlink if not NULL.
7579
7580 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7581
7582         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7583         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7584         (amd64bsd_store_inferior_registers): Likewise.
7585         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7586         Enable segment base registers.
7587         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7588         PT_GETFSBASE and PT_GETGSBASE.
7589         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7590         PT_SETGSBASE.
7591         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7592         segment base registers.
7593         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7594
7595 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7596
7597         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7598         Update calls to i386_target_description to add 'segments'
7599         parameter.
7600         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7601         add segment base registers.
7602         * arch/i386.c (i386_create_target_description): Add 'segments'
7603         parameter to enable segment base registers.
7604         * arch/i386.h (i386_create_target_description): Likewise.
7605         * features/i386/32bit-segments.xml: New file.
7606         * features/i386/32bit-segments.c: Generate.
7607         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7608         call to i386_target_description to add 'segments' parameter.
7609         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7610         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7611         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7612         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7613         if feature is present.
7614         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7615         Add 'segments' parameter to call to i386_target_description.
7616         (i386_target_description): Add 'segments' parameter to enable
7617         segment base registers.
7618         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7619         to call to i386_target_description.
7620         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7621         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7622         Define I386_NUM_REGS.
7623         (i386_target_description): Add 'segments' parameter to enable
7624         segment base registers.
7625
7626 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7627
7628         PR/24325
7629         * source-cache.c: #undef open and close, to avoid unresolved
7630         externals during linking.
7631
7632 2019-03-12  Tom Tromey  <tromey@adacore.com>
7633
7634         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7635         const.  Add initializers.
7636         (_initialize_remote): Don't initialize ptid globals.
7637
7638 2019-03-12  Pedro Alves  <palves@redhat.com>
7639
7640         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7641
7642 2019-03-12  Pedro Alves  <palves@redhat.com>
7643
7644         * cp-name-parser.y (main): Remove unused 'len' variable.
7645
7646 2019-03-12  Tom Tromey  <tromey@adacore.com>
7647
7648         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7649         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7650
7651 2019-03-12  Tom Tromey  <tromey@adacore.com>
7652
7653         * linux-nat.c (iterate_over_lwps): Update.
7654         (stop_callback): Remove parameter.
7655         (stop_wait_callback, detach_callback, resume_set_callback)
7656         (select_singlestep_lwp_callback, set_ignore_sigint)
7657         (status_callback, resumed_callback, resume_clear_callback)
7658         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7659         data parameter.
7660         (linux_nat_target::detach, linux_nat_target::resume)
7661         (linux_stop_and_wait_all_lwps, select_event_lwp)
7662         (linux_nat_filter_event, linux_nat_wait_1)
7663         (linux_nat_target::kill, linux_nat_target::stop)
7664         (linux_nat_target::stop): Update.
7665         (linux_nat_resume_callback): Change type.
7666         (resume_stopped_resumed_lwps, count_events_callback)
7667         (select_event_lwp_callback): Likewise.
7668         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7669         * arm-linux-nat.c (struct update_registers_data): Remove.
7670         (update_registers_callback): Change type.
7671         (arm_linux_insert_hw_breakpoint1): Update.
7672         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7673         parameter.
7674         (x86_linux_dr_set_addr): Update.
7675         (x86_linux_dr_set_control): Update.
7676         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7677         (iterate_over_lwps): Use gdb::function_view.
7678         * nat/aarch64-linux-hw-point.c (struct
7679         aarch64_dr_update_callback_param): Remove.
7680         (debug_reg_change_callback): Change type.
7681         (aarch64_notify_debug_reg_change): Update.
7682         * s390-linux-nat.c (s390_refresh_per_info): Update.
7683
7684 2019-03-11  Tom Tromey  <tromey@adacore.com>
7685
7686         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7687         redundant assignment to "this_cu".
7688
7689 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7690
7691         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7692
7693 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7694
7695         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7696         from...
7697         (rank_one_type): ... this.
7698
7699 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7700
7701         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7702         from...
7703         (rank_one_type): ... this.
7704
7705 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7706
7707         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7708         from...
7709         (rank_one_type): ... this.
7710
7711 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7712
7713         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7714         from...
7715         (rank_one_type): ... this.
7716
7717 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7718
7719         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7720         from...
7721         (rank_one_type): ... this.
7722
7723 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7724
7725         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7726         from...
7727         (rank_one_type): ... this.
7728
7729 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7730
7731         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7732         from...
7733         (rank_one_type): ... this.
7734
7735 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7736
7737         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7738         from...
7739         (rank_one_type): ... this.
7740
7741 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7742
7743         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7744         from...
7745         (rank_one_type): ... this.
7746
7747 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7748
7749         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7750         from...
7751         (rank_one_type): ... this.
7752
7753 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7754
7755         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7756         from...
7757         (rank_one_type): ... this.
7758
7759 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7760
7761         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7762         from...
7763         (rank_one_type): ... this.
7764
7765 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7766
7767         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7768         inferior-events' shows the example events.
7769
7770 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7771
7772         Support styling on native MS-Windows console
7773
7774         PR/24315
7775         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7776         on MS-Windows if $TERM is not defined.
7777
7778         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7779
7780         * posix-hdep.c (gdb_console_fputs):
7781         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7782         functions.
7783         * ui-file.h (gdb_console_fputs): Add prototype.
7784
7785         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7786         back to fputs only if the former returns zero.
7787
7788 2019-03-07  Tom Tromey  <tom@tromey.com>
7789
7790         * symmisc.c (print_symbol_bcache_statistics): Update.
7791         (print_objfile_statistics): Update.
7792         * symfile.c (allocate_symtab): Update.
7793         * stabsread.c: Don't include bcache.h.
7794         * psymtab.h (struct psymbol_bcache): Don't declare.
7795         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7796         (psymbol_bcache_init, psymbol_bcache_free)
7797         (psymbol_bcache_get_bcache): Don't declare.
7798         * psymtab.c (struct psymbol_bcache): Remove.
7799         (psymtab_storage::psymtab_storage): Update.
7800         (psymtab_storage::~psymtab_storage): Update.
7801         (psymbol_bcache_init, psymbol_bcache_free)
7802         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7803         (add_psymbol_to_bcache): Update.
7804         (allocate_psymtab): Update.
7805         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7806         macro_cache>: No longer pointers.
7807         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7808         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7809         * macrotab.c (macro_bcache): Update.
7810         * macroexp.c: Don't include bcache.h.
7811         * gdbtypes.c (check_types_worklist): Update.
7812         (types_deeply_equal): Remove TRY/CATCH.  Update.
7813         * elfread.c (elf_symtab_read): Update.
7814         * dwarf2read.c: Don't include bcache.h.
7815         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7816         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7817         (print_bcache_statistics, bcache_memory_used): Don't declare.
7818         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7819         methods.  Rename all data members.
7820         * bcache.c (struct bcache): Move to bcache.h.
7821         (bcache::expand_hash_table): Rename from expand_hash_table.
7822         (bcache): Remove.
7823         (bcache::insert): Rename from bcache_full.
7824         (bcache::compare): Rename from bcache_compare.
7825         (bcache_xmalloc): Remove.
7826         (bcache::~bcache): Rename from bcache_xfree.
7827         (bcache::print_statistics): Rename from print_bcache_statistics.
7828         (bcache::memory_used): Rename from bcache_memory_used.
7829
7830 2019-03-07  Pedro Alves  <palves@redhat.com>
7831
7832         * infrun.c (normal_stop): Also check for
7833         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7834
7835 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7836
7837         * f-lang.c (value_from_host_double): Moved to...
7838         * value.c (value_from_host_double): ...here.
7839         * value.h (value_from_host_double): Declare.
7840         * guile/scm-math.c (vlscm_convert_typed_number): Use
7841         value_from_host_double.
7842         (vlscm_convert_number): Likewise.
7843         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7844         * python/py-value.c (convert_value_from_python): Likewise.
7845
7846 2019-03-06  Tom Tromey  <tom@tromey.com>
7847
7848         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7849
7850 2019-03-06  Tom Tromey  <tom@tromey.com>
7851
7852         * utils.h (free_current_contents): Don't declare.
7853         * utils.c (free_current_contents): Remove.
7854
7855 2019-03-06  Tom Tromey  <tom@tromey.com>
7856
7857         * top.c (quit_force): Update.
7858         * main.c (captured_command_loop): Update.
7859         * common/new-op.c (operator new): Update.
7860         * common/common-exceptions.c (struct catcher)
7861         <save_cleanup_chain>: Remove member.
7862         (exceptions_state_mc_init): Update.
7863         (exception_try_scope_entry): Return nullptr.
7864         (exception_try_scope_exit, exception_rethrow)
7865         (throw_exception_sjlj, throw_exception_cxx): Update.
7866         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7867         (all_cleanups, do_cleanups, discard_cleanups)
7868         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7869         (restore_cleanups, restore_final_cleanups): Don't declare.
7870         (do_final_cleanups): Remove parameter.
7871         * common/cleanups.c (cleanup_chain, make_cleanup)
7872         (make_cleanup_dtor, all_cleanups, do_cleanups)
7873         (discard_my_cleanups, discard_cleanups)
7874         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7875         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7876         (null_cleanup): Remove.
7877         (do_final_cleanups): Remove parameter.
7878
7879 2019-03-06  Tom Tromey  <tom@tromey.com>
7880
7881         * remote.c (remote_target::remote_parse_stop_reply): Use
7882         unique_xmalloc_ptr.
7883
7884 2019-03-06  Tom Tromey  <tom@tromey.com>
7885
7886         * stabsread.c (struct stabs_field_info): Rename from field_info.
7887         <list, fnlist>: Add initializers.
7888         <obstack>: New member.
7889         (read_member_functions, read_struct_fields, read_baseclasses):
7890         Allocate on obstack.  Don't use cleanups.
7891         (read_one_struct_field, read_member_functions, read_struct_fields)
7892         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7893         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7894         (read_struct_type): Update.
7895
7896 2019-03-06  Tom Tromey  <tom@tromey.com>
7897
7898         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7899         * common/filestuff.h (make_cleanup_close): Don't declare.
7900         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7901         Remove.
7902
7903 2019-03-06  Tom Tromey  <tom@tromey.com>
7904
7905         * solib-aix.c: Use make_scope_exit.
7906
7907 2019-03-06  Tom Tromey  <tom@tromey.com>
7908
7909         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7910         Use make_scope_exit.
7911
7912 2019-03-06  Tom Tromey  <tom@tromey.com>
7913
7914         * solib-svr4.c (disable_probes_interface): Remove parameter.
7915         (svr4_handle_solib_event): Use make_scope_exit.
7916
7917 2019-03-06  Tom Tromey  <tom@tromey.com>
7918
7919         * remote.c (struct stop_reply_deleter): Remove.
7920         (stop_reply_up): Update.
7921         (struct stop_reply): Derive from notif_event.  Don't typedef.
7922         <regcache>: Now a std::vector.
7923         (stop_reply_xfree): Remove.
7924         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7925         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7926         (remote_target::discard_pending_stop_replies): Use delete.
7927         (remote_target::remote_parse_stop_reply): Update.
7928         (remote_target::process_stop_reply): Update.
7929         * remote-notif.h (struct notif_event): Add virtual destructor.
7930         Remove "dtr" member.
7931         (struct notif_client) <alloc_event>: Return a unique_ptr.
7932         (notif_event_xfree): Don't declare.
7933         (notif_event_up): New typedef.
7934         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7935         (notif_event_xfree, do_notif_event_xfree): Remove.
7936         (remote_notif_state_xfree): Update.
7937
7938 2019-03-06  Tom Tromey  <tom@tromey.com>
7939
7940         * infrun.c (displaced_step_clear_cleanup): Now a
7941         forward_scope_exit type.
7942         (displaced_step_prepare_throw): Update.
7943         (displaced_step_fixup): Update.
7944
7945 2019-03-06  Tom Tromey  <tom@tromey.com>
7946
7947         * inferior.h (class inferior): Update comment.
7948         * gdbthread.h (class thread_info): Update comment.
7949
7950 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7951             Tom Tromey  <tom@tromey.com>
7952
7953         * stabsread.h (struct stab_section_list): Remove.
7954         (coffstab_build_psymtabs): Update.
7955         * dbxread.c (symbuf_sections): Now a std::vector.
7956         (sect_idx): New global.
7957         (fill_symbuf): Update.
7958         (coffstab_build_psymtabs): Change type of stabsects parameter.
7959         Update.
7960         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7961         std::vector.
7962         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7963         (coff_locate_sections): Update.
7964         (coff_symfile_read): Remove cleanups.  Update.
7965         (init_stringtab): Add storage parameter.
7966         (free_stringtab, free_stringtab_cleanup): Remove.
7967         (init_lineno): Add storage parameter.
7968         (free_linetab, free_linetab_cleanup): Remove.
7969
7970 2019-03-06  Pedro Alves  <palves@redhat.com>
7971
7972         * linux-fork.c (fork_info::clobber_regs): Delete.
7973         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7974         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7975         comment.  Adjust.
7976         (scoped_switch_fork_info::scoped_switch_fork_info)
7977         (checkpoint_command, linux_fork_context): Adjust
7978         fork_save_infrun_state calls.
7979
7980 2019-03-06  Pedro Alves  <palves@redhat.com>
7981
7982         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7983         (inf_has_multiple_threads): Return 'bool' and rewrite using
7984         inferior_info::threads().
7985
7986 2019-03-06  Pedro Alves  <palves@redhat.com>
7987
7988         * linux-fork.c: Include <list>.
7989         (fork_list): Now a std::list instance.
7990         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7991         (forks_exist_p, find_last_fork): Adjust.
7992         (new_fork): Delete.
7993         (one_fork_p): New.
7994         (add_fork): Adjust.
7995         (free_fork): Delete, folded into fork_info::~fork_info().
7996         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7997         Adjust.
7998         (init_fork_list): Delete.
7999         (linux_fork_killall, linux_fork_mourn_inferior)
8000         (linux_fork_detach, info_checkpoints_command): Adjust.
8001         (_initialize_linux_fork): No longer call init_fork_list.
8002
8003 2019-03-06  Pedro Alves  <palves@redhat.com>
8004
8005         * linux-fork.c (new_fork): New, split out of ...
8006         (add_fork): ... this.  Return void.  Move "first fork" special
8007         case from here, to ...
8008         (checkpoint_command): ... here.
8009         * linux-linux.h (add_fork): Return void.
8010
8011 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8012
8013         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8014
8015 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8016             Chris January  <chris.january@arm.com>
8017             David Lecomber  <david.lecomber@arm.com>
8018
8019         * f-exp.y: New token, UNOP_INTRINSIC.
8020         (exp): New pattern using UNOP_INTRINSIC token.
8021         (f77_keywords): Add 'abs' keyword.
8022         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8023         (value_from_host_double): New function.
8024         (evaluate_subexp_f): Support UNOP_ABS.
8025
8026 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8027
8028         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8029         types.
8030
8031 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8032
8033         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
8034         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
8035         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
8036
8037 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8038
8039         * f-exp.y (convert_to_kind_type): Handle more type kinds.
8040
8041 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8042             Chris January  <chris.january@arm.com>
8043
8044         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
8045         * f-exp.y: Define 'KIND' token.
8046         (exp): New pattern for KIND expressions.
8047         (ptype): Handle types with a kind extension.
8048         (direct_abs_decl): Extend to spot kind extensions.
8049         (f77_keywords): Add 'kind' to the list.
8050         (push_kind_type): New function.
8051         (convert_to_kind_type): New function.
8052         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8053         * parse.c (operator_length_standard): Likewise.
8054         * parser-defs.h (enum type_pieces): Add tp_kind.
8055         * std-operator.def: Add UNOP_KIND.
8056
8057 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8058
8059         * f-exp.y (f_parse): Set yydebug.
8060
8061 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8062
8063         * f-lang.c (evaluate_subexp_f): New function.
8064         (exp_descriptor_f): New global.
8065         (f_language_defn): Use exp_descriptor_f instead of
8066         exp_descriptor_standard.
8067
8068 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8069
8070         * f-exp.y (struct token): Add comments.
8071         (dot_ops): Remove uppercase versions and the end marker.
8072         (f77_keywords): Likewise.
8073         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8074         entries in the dot_ops array are case insensitive, and use
8075         strncasecmp to compare strings.  Also some whitespace cleanup in
8076         this area.  Similar for the f77_keywords array, except entries in
8077         this list might be case sensitive.
8078
8079 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8080
8081         * f-exp.y (struct f77_boolean_val): Add comments.
8082         (boolean_values): Remove uppercase versions, and end marker.
8083         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8084         and use strncasecmp to achieve case insensitivity.  Additionally,
8085         perform whitespace cleanup around this code.
8086
8087 2019-03-06  Tom Tromey  <tromey@adacore.com>
8088
8089         * remote-sim.c (gdbsim_target_open): Use result of
8090         gdb_argv::release.
8091
8092 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
8093         Dirk Schubert  <dirk.schubert@arm.com>
8094         Chris January  <chris.january@arm.com>
8095
8096         * eval.c (evaluate_subexp_standard): Call Fortran argument
8097         wrapping logic.
8098         * f-lang.c (struct value): A value which can be passed into a
8099         Fortran function call.
8100         (fortran_argument_convert): Wrap Fortran arguments in a pointer
8101         where appropriate.
8102         (struct type): Value ready for a Fortran function call.
8103         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8104         is needed.
8105         * f-lang.h (fortran_argument_convert): Declaration.
8106         (fortran_preserve_arg_pointer): Declaration.
8107         * infcall.c (value_arg_coerce): Call Fortran argument logic.
8108
8109 2019-03-05  Tom Tromey  <tromey@adacore.com>
8110
8111         * python/py-prettyprint.c (print_string_repr): Remove #if.
8112         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8113
8114 2019-03-05  Tom Tromey  <tromey@adacore.com>
8115
8116         * target.c (the_dummy_target): Move later.  Change type to
8117         "dummy_target".
8118         (initialize_targets): Don't initialize the_dummy_target.
8119
8120 2019-03-05  Tom Tromey  <tromey@adacore.com>
8121
8122         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8123         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8124
8125 2019-03-05  Tom Tromey  <tromey@adacore.com>
8126
8127         * windows-nat.c (windows_nat_target::attach)
8128         (windows_nat_target::detach): Don't call gdb_flush.
8129         * valprint.c (generic_val_print, val_print, val_print_string):
8130         Don't call gdb_flush.
8131         * utils.c (defaulted_query): Don't call gdb_flush.
8132         * typeprint.c (print_type_scalar): Don't call gdb_flush.
8133         * target.c (target_announce_detach): Don't call gdb_flush.
8134         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8135         * remote.c (extended_remote_target::attach): Don't call
8136         gdb_flush.
8137         * procfs.c (procfs_target::detach): Don't call gdb_flush.
8138         * printcmd.c (do_examine): Don't call gdb_flush.
8139         (info_display_command): Don't call gdb_flush.
8140         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8141         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8142         * memattr.c (info_mem_command): Don't call gdb_flush.
8143         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8144         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8145         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8146         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8147         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8148         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8149         (gnu_nat_target::detach): Don't call gdb_flush.
8150         * f-valprint.c (f_val_print): Don't call gdb_flush.
8151         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8152         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8153         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8154         gdb_flush.
8155         * c-valprint.c (c_val_print): Don't call gdb_flush.
8156         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8157
8158 2019-03-05  Tom Tromey  <tromey@adacore.com>
8159
8160         * varobj.c (update_dynamic_varobj_children): Update.
8161         (install_default_visualizer): Use reset, not release.
8162         * value.c (set_internalvar): Update.
8163         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8164         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8165         ATTRIBUTE_UNUSED_RESULT.
8166
8167 2019-03-05  Tom Tromey  <tromey@adacore.com>
8168
8169         * remote.c (class scoped_remote_fd) <release>: Add
8170         ATTRIBUTE_UNUSED_RESULT.
8171
8172 2019-03-05  Tom Tromey  <tromey@adacore.com>
8173
8174         * macroexp.c (struct macro_buffer) <release>: Add
8175         ATTRIBUTE_UNUSED_RESULT.
8176
8177 2019-03-05  Tom Tromey  <tromey@adacore.com>
8178
8179         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8180         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8181         ATTRIBUTE_UNUSED_RESULT.
8182
8183 2019-03-05  Tom Tromey  <tromey@adacore.com>
8184
8185         * common/scoped_fd.h (class scoped_fd) <release>: Add
8186         ATTRIBUTE_UNUSED_RESULT.
8187
8188 2019-03-05  Tom Tromey  <tromey@adacore.com>
8189
8190         * parser-defs.h (struct parser_state) <release>: Add
8191         ATTRIBUTE_UNUSED_RESULT.
8192
8193 2019-03-05  Tom Tromey  <tromey@adacore.com>
8194
8195         * utils.h (class gdb_argv) <release>: Add
8196         ATTRIBUTE_UNUSED_RESULT.
8197         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8198
8199 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
8200
8201         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8202         for-loop range, to avoid compiler warnings.
8203
8204         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8205         avoid compiler warnings about unused variables.
8206
8207         * NEWS: Mention end of support for native debugging on MS-Windows
8208         before XP.
8209
8210         PR gdb/24292
8211         * common/netstuff.c:
8212         * gdbserver/gdbreplay.c
8213         * gdbserver/remote-utils.c:
8214         * ser-tcp.c:
8215         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8216         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
8217         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8218         'getaddrinfo' and 'freeaddrinfo' were not available before
8219         Windows XP, and mingw.org's MinGW headers by default define
8220         _WIN32_WINNT to 0x500.
8221
8222 2019-03-01  Gary Benson <gbenson@redhat.com>
8223
8224         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8225
8226 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
8227             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
8228
8229         PR gdb/8527
8230         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8231         set_sigint_trap, clear_sigint_trap.
8232
8233 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8234
8235         * target.c (target_detach): Clear the regcache and the
8236         frame cache.
8237
8238 2019-02-27  Pedro Alves  <palves@redhat.com>
8239
8240         * utils.c (set_screen_size): When we cap the height/width sizes,
8241         tweak the corresponding command variable to show "unlimited":
8242
8243 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8244             Pedro Alves  <palves@redhat.com>
8245
8246         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8247         before calling rl_set_screen_size.
8248
8249 2019-02-27  Tom Tromey  <tromey@adacore.com>
8250
8251         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8252         define.
8253         * python/py-value.c: Remove Python 2.4 workaround.
8254         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8255         workaround.
8256         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8257         Python 2.4 workaround.
8258         * python/python-internal.h: Remove Python 2.4 comment.
8259         (Py_ssize_t): Don't define.
8260         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8261         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8262         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8263         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8264         * python/python.c (do_start_initialization): Remove Python 2.4
8265         workaround.
8266         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8267         (print_children): Remove Python 2.4 workaround.
8268         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8269         workaround.
8270         (CHARBUFFERPROC_NAME): Remove.
8271         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8272         Python 2.4 workaround.
8273
8274 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8275
8276         * NEWS: Note minimum Python version.
8277
8278 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8279
8280         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8281         code from these functions.  Remove corresponding ifdefs.  Use
8282         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8283         Remove gotos and target of gotos.
8284         (infpy_search_memory): Likewise.
8285
8286 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8287
8288         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8289         (hppa_gdbarch_init): Don't register deleted functions with
8290         gdbarch.
8291
8292 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8293
8294         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8295         (h8300_unwind_sp): Delete.
8296         (h8300_dummy_id): Delete.
8297         (h8300_gdbarch_init): Don't register deleted functions with
8298         gdbarch.
8299
8300 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8301
8302         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8303         (ft32_unwind_pc): Delete.
8304         (ft32_unwind_sp): Delete.
8305         (ft32_gdbarch_init): Don't register deleted functions with
8306         gdbarch.
8307
8308 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8309
8310         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8311         (frv_unwind_pc): Delete.
8312         (frv_unwind_sp): Delete.
8313         (frv_gdbarch_init): Don't register deleted functions with
8314         gdbarch.
8315
8316 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8317
8318         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8319         (riscv_unwind_pc): Delete.
8320         (riscv_unwind_sp): Delete.
8321         (riscv_gdbarch_init): Don't register deleted functions with
8322         gdbarch.
8323
8324 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8325
8326         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8327         (csky_unwind_pc): Delete.
8328         (csky_unwind_sp): Delete.
8329         (csky_gdbarch_init): Don't register deleted functions with
8330         gdbarch.
8331
8332 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8333
8334         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8335         (cris_unwind_pc): Delete.
8336         (cris_unwind_sp): Delete.
8337         (cris_gdbarch_init): Don't register deleted functions with
8338         gdbarch.
8339
8340 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8341
8342         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8343         (bfin_unwind_pc): Delete.
8344         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8345
8346 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8347
8348         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8349         (arm_unwind_pc): Delete.
8350         (arm_unwind_sp): Delete.
8351         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8352
8353 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8354
8355         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8356         (arc_unwind_pc): Delete.
8357         (arc_unwind_sp): Delete.
8358         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8359
8360 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8361
8362         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8363         (alpha_unwind_pc): Delete.
8364         (alpha_gdbarch_init): Don't register deleted functions with
8365         gdbarch.
8366
8367 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8368
8369         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8370         (aarch64_unwind_pc): Delete.
8371         (aarch64_unwind_sp): Delete.
8372         (aarch64_gdbarch_init): Don't register deleted functions with
8373         gdbarch.
8374
8375 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8376
8377         * gdbtypes.c (type_align): Don't consider static members when
8378         computing structure alignment.
8379
8380 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8381
8382         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8383         return 0 for other types.
8384         * arch-utils.c (default_type_align): Always return 0.
8385         * gdbarch.h: Regenerate.
8386         * gdbarch.sh (type_align): Extend comment.
8387         * gdbtypes.c (type_align): Add additional comments, always call
8388         gdbarch_type_align before applying the default rules.
8389         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8390         generic code will then apply a suitable default.
8391         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8392         types, return 0 for other types.
8393
8394 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8395
8396         * NEWS: Create a new section for the next release branch.
8397         Rename the section of the current branch, now that it has
8398         been cut.
8399
8400 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8401
8402         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8403         * version.in: Bump version to 8.3.50.DATE-git.
8404
8405 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8406
8407         * aix-thread.c (ptid_cmp): Remove unused variable.
8408         (get_signaled_thread): Likewise.
8409         (store_regs_user_thread): Likewise.
8410         (store_regs_kernel_thread): Likewise.
8411         (fetch_regs_kernel_thread): Remove shadowed variable.
8412
8413 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8414
8415         * features/riscv/32bit-cpu.xml: Add register numbers.
8416         * features/riscv/32bit-fpu.c: Regenerate.
8417         * features/riscv/32bit-fpu.xml: Add register numbers.
8418         * features/riscv/64bit-cpu.xml: Add register numbers.
8419         * features/riscv/64bit-fpu.c: Regenerate.
8420         * features/riscv/64bit-fpu.xml: Add register numbers.
8421
8422 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8423
8424         * NEWS: Mention two argument form of gdb.Value constructor.
8425         * python/py-value.c (convert_buffer_and_type_to_value): New
8426         function.
8427         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8428         Add support for handling an optional second argument.  Call
8429         convert_buffer_and_type_to_value as appropriate.
8430         * python/python-internal.h (Py_buffer_deleter): New struct.
8431         (Py_buffer_up): New typedef.
8432
8433 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8434
8435         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8436         instead of releasing ownership.
8437
8438 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8439
8440         * dwarf2read.c (open_and_init_dwp_file): Call
8441         elf_numsections instead of bfd_count_sections to initialize
8442         dwp_file->num_sections.
8443
8444 2019-02-25  Tom Tromey  <tromey@adacore.com>
8445
8446         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8447
8448 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8449
8450         * gcore.in: Add '--readnever' option when invoking GDB.
8451
8452 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8453
8454         * MAINTAINERS: Update my email address.
8455
8456 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8457
8458         * build-id.c (build_id_to_debug_bfd_1): New function.
8459         (build_id_to_debug_bfd): Look for separate debug file in
8460         sysroot.
8461
8462 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8463
8464         * gdbarch.sh: Update the copyright year range that is placed into
8465         generated files.
8466
8467 2019-02-22  Keith Seitz  <keiths@redhat.com>
8468
8469         PR symtab/23853
8470         * linespec.c (create_sals_line_offset): Search for the default
8471         symtab's filename instead of its fullname.
8472
8473 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8474
8475         * NEWS: Update style defaults.
8476
8477 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8478
8479         * main.c (captured_main_1): Disable styling in batch mode.
8480
8481 2019-02-20  Tom Tromey  <tom@tromey.com>
8482
8483         * symtab.c (symtab_symbol_info): Fix typos.
8484
8485 2019-02-20  Tom Tromey  <tromey@adacore.com>
8486
8487         * findcmd.c (_initialize_mem_search): Use upper case for
8488         metasyntactic variables.
8489
8490 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8491
8492         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8493         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8494
8495 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8496
8497         * top.h (source_file_name): Change to std::string.
8498         * top.c (source_file_name): Likewise.
8499         (command_line_input): Adjust.
8500         * cli/cli-script.c (script_from_file): Adjust.
8501
8502 2019-02-19  Tom Tromey  <tromey@adacore.com>
8503
8504         * ravenscar-thread.c
8505         (ravenscar_thread_target::update_thread_list): Don't call
8506         ada_build_task_list.
8507         * ada-lang.h (ada_build_task_list): Don't declare.
8508         * ada-tasks.c (struct ada_tasks_inferior_data)
8509         <task_list_valid_p>: Now bool.
8510         (read_known_tasks, ada_task_list_changed)
8511         (ada_tasks_invalidate_inferior_data): Update.
8512         (read_known_tasks_array): Return bool.
8513         (read_known_tasks_list): Likewise.
8514         (read_known_tasks): Return void.
8515         (ada_build_task_list): Now static.
8516
8517 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8518
8519         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8520         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8521
8522 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8523
8524         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8525         variant for ada_tasks_pspace_data_handle and
8526         ada_tasks_inferior_data_handle.
8527         (ada_tasks_pspace_data_cleanup): New function.
8528         (ada_tasks_inferior_data_cleanup): New function.
8529
8530 2019-02-17  Tom Tromey  <tom@tromey.com>
8531
8532         * macrotab.h (macro_source_fullname): Return a std::string.
8533         * macrotab.c (macro_include, check_for_redefinition)
8534         (macro_undef, macro_lookup_definition, foreach_macro)
8535         (foreach_macro_in_scope): Update.
8536         (macro_source_fullname): Return a std::string.
8537         * macrocmd.c (show_pp_source_pos): Update.
8538
8539 2019-02-17  Tom Tromey  <tom@tromey.com>
8540
8541         * macrocmd.c (show_pp_source_pos): Style the file names.
8542
8543 2019-02-17  Tom Tromey  <tom@tromey.com>
8544
8545         PR tui/24197:
8546         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8547
8548 2019-02-17  Tom Tromey  <tom@tromey.com>
8549
8550         * ada-lang.c (user_select_syms): Use filtered printing.
8551         * utils.c (wrap_style): New global.
8552         (desired_style): Remove.
8553         (emit_style_escape): Add stream parameter.
8554         (set_output_style, reset_terminal_style, prompt_for_continue):
8555         Update.
8556         (flush_wrap_buffer): Only flush gdb_stdout.
8557         (wrap_here): Set wrap_style.
8558         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8559         treat escape sequences as a character.  Change when wrap buffer is
8560         flushed.
8561         (fputs_styled): Do not set the output style when the default is
8562         requested.
8563         * ui-style.h (struct ui_file_style) <is_default>: New method.
8564         * source.c (print_source_lines_base): Emit escape sequences in one
8565         piece.
8566
8567 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8568
8569         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8570         integers and enumeration types.
8571
8572 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8573
8574         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8575         instead of lookup_symbol_in_language
8576         (do_exact_match): New function.
8577         (ada_get_symbol_name_matcher): Return do_exact_match when
8578         doing a verbatim match.
8579
8580 2019-02-15  Tom Tromey  <tromey@adacore.com>
8581
8582         * ravenscar-thread.c (ravenscar_thread_target::resume)
8583         (ravenscar_thread_target::wait): Special case wildcard requests.
8584
8585 2019-02-15  Tom Tromey  <tromey@adacore.com>
8586
8587         * ravenscar-thread.c (base_ptid): Remove.
8588         (struct ravenscar_thread_target) <close>: New method.
8589         <m_base_ptid>: New member.
8590         <update_inferior_ptid, active_task, task_is_currently_active,
8591         runtime_initialized>: Declare methods.
8592         <ravenscar_thread_target>: Add constructor.
8593         (ravenscar_thread_target::task_is_currently_active)
8594         (ravenscar_thread_target::update_inferior_ptid)
8595         (ravenscar_runtime_initialized): Rename.  Now methods.
8596         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8597         (ravenscar_thread_target::update_thread_list): Update.
8598         (ravenscar_thread_target::active_task): Now method.
8599         (ravenscar_thread_target::store_registers)
8600         (ravenscar_thread_target::prepare_to_store)
8601         (ravenscar_thread_target::prepare_to_store)
8602         (ravenscar_thread_target::mourn_inferior): Update.
8603         (ravenscar_inferior_created): Use "new" to create target.
8604         (ravenscar_thread_target::get_ada_task_ptid): Update.
8605         (_initialize_ravenscar): Don't initialize base_ptid.
8606         (ravenscar_ops): Remove global.
8607
8608 2019-02-15  Tom Tromey  <tromey@adacore.com>
8609
8610         * target.h (push_target): Declare new overload.
8611         * target.c (push_target): New overload, taking an rvalue reference.
8612         * remote.c (remote_target::open_1): Use push_target overload.
8613         * corelow.c (core_target_open): Use push_target overload.
8614
8615 2019-02-15  Tom Tromey  <tromey@adacore.com>
8616
8617         * ravenscar-thread.c (is_ravenscar_task)
8618         (ravenscar_task_is_currently_active): Return bool.
8619         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8620         (_initialize_ravenscar): Remove "(void)".
8621         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8622         Return bool.
8623
8624 2019-02-15  Tom Tromey  <tromey@adacore.com>
8625
8626         * ravenscar-thread.c (ravenscar_runtime_initializer)
8627         (has_ravenscar_runtime, get_running_thread_id)
8628         (ravenscar_thread_target::resume): Fix indentation.
8629
8630 2019-02-15  Tom Tromey  <tromey@adacore.com>
8631
8632         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8633         from ravenscar_arch_ops.
8634         (sparc_ravenscar_ops::fetch_registers)
8635         (sparc_ravenscar_ops::store_registers): Now methods.
8636         (sparc_ravenscar_prepare_to_store): Remove.
8637         (sparc_ravenscar_ops): Redefine.
8638         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8639         methods and destructor.  Remove members.
8640         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8641         (ravenscar_thread_target::store_registers)
8642         (ravenscar_thread_target::prepare_to_store): Update.
8643         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8644         Remove.
8645         (struct ppc_ravenscar_powerpc_ops): Derive from
8646         ravenscar_arch_ops.
8647         (ppc_ravenscar_powerpc_ops::fetch_registers)
8648         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8649         (ppc_ravenscar_powerpc_ops): Redefine.
8650         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8651         (ppc_ravenscar_e500_ops::fetch_registers)
8652         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8653         (ppc_ravenscar_e500_ops): Redefine.
8654         * aarch64-ravenscar-thread.c
8655         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8656         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8657         (aarch64_ravenscar_fetch_registers)
8658         (aarch64_ravenscar_store_registers): Now methods.
8659         (aarch64_ravenscar_ops): Redefine.
8660
8661 2019-02-15  Tom Tromey  <tromey@adacore.com>
8662
8663         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8664         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8665         (ravenscar_thread_target::stopped_by_watchpoint)
8666         (ravenscar_thread_target::stopped_data_address)
8667         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8668
8669 2019-02-15  Tom Tromey  <tromey@adacore.com>
8670
8671         * ravenscar-thread.c: Fix some typos.
8672
8673 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8674             Tom Tromey  <tromey@adacore.com>
8675
8676         * ada-lang.c (ada_exception_sal): Change addr_string to a
8677         std::string.
8678         (create_ada_exception_catchpoint): Update.
8679
8680 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8681             Tom Tromey  <tromey@adacore.com>
8682
8683         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8684         (bp_location_ops): Remove.
8685         (base_breakpoint_allocate_location): Update.
8686         (free_bp_location): Update.
8687         * ada-lang.c (class ada_catchpoint_location)
8688         <ada_catchpoint_location>: Remove ops parameter.
8689         (ada_catchpoint_location_dtor): Remove.
8690         (ada_catchpoint_location_ops): Remove.
8691         (allocate_location_exception): Update.
8692         * breakpoint.h (struct bp_location_ops): Remove.
8693         (class bp_location) <bp_location>: Remove bp_location_ops
8694         parameter.
8695         <~bp_location>: Add destructor.
8696         <ops>: Remove.
8697
8698 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8699             Pedro Alves  <palves@redhat.com>
8700
8701         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8702         'PATH_MAX'.
8703
8704 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8705             Samuel Thibault  <samuel.thibault@gnu.org>
8706             Thomas Schwinge  <thomas@codesourcery.com>
8707
8708         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8709         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8710
8711 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8712
8713         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8714         (check_empty): Use "const char *".
8715
8716         * gnu-nat.c (gnu_nat_target::detach): Instead of
8717         'detach_inferior (pid)' call
8718         'detach_inferior (find_inferior_pid (pid))'.
8719
8720         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8721         'nat/fork-inferior.o'.
8722         * gnu-nat.c: #include "nat/fork-inferior.h".
8723
8724         * gnu-nat.c (gnu_nat_target::detach): Instead of
8725         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8726         * gnu-nat.h: #include "inf-child.h".
8727         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8728         'i386_gnu_nat_target::fetch_registers'.
8729         (gnu_store_registers): Rename/move to
8730         'i386_gnu_nat_target::store_registers'.
8731
8732         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8733         * gnu-nat.h (mach_thread_info): New function.
8734         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8735
8736         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8737
8738 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8739
8740         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8741
8742 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8743
8744         * windows-nat.c (windows_add_thread): Add new parameter
8745         "main_thread_p" with default value set to false.  Update
8746         function documentation as well as all callers.
8747         (windows_delete_thread): Likewise.
8748         (fake_create_process): Update call to windows_add_thread.
8749         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8750         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8751         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8752         call to windows_delete_thread.
8753
8754 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8755
8756         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8757
8758 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8759
8760         * symfile.c (find_separate_debug_file): Use canonical path of
8761         sysroot with child_path instead of gdb_sysroot if it is valid.
8762
8763 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8764
8765         * symfile.c (find_separate_debug_file): Use child_path to
8766         determine if an object file is under a sysroot.
8767
8768 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8769
8770         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8771         unittests/child-path-selftests.c.
8772         * common/pathstuff.c (child_path): New function.
8773         * common/pathstuff.h (child_path): New prototype.
8774         * unittests/child-path-selftests.c: New file.
8775
8776 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8777
8778         * symfile.c (find_separate_debug_file): Look for separate debug
8779         files in debug directories under the sysroot.
8780
8781 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8782
8783         * symtab.h (struct minimal_symbol data_p): New const method.
8784         (struct minimal_symbol text_p): Likewise.
8785         * symtab.c (output_source_filename): Use file name style
8786         to print file name.
8787         (print_symbol_info): Likewise.
8788         (print_msymbol_info): Use address style to print addresses.
8789         Use function name style to print executable text symbols.
8790         (expand_symtab_containing_pc): Use data_p.
8791         (find_pc_sect_compunit_symtab): Likewise.
8792
8793 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8794
8795         * breakpoint.c (describe_other_breakpoints): Use address style
8796         to print addresses.
8797         (say_where): Likewise.
8798
8799 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8800
8801         * ada-typeprint.c (print_func_type): Print function name
8802         style to print function name.
8803         * c-typeprint.c (c_print_type_1): Likewise.
8804
8805 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8806
8807         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8808         for execve.
8809
8810 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8811
8812         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8813         type_stack.
8814
8815 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8816
8817         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8818         TYPE_CODE_REF types.
8819
8820 2019-02-08  Jim Wilson  <jimw@sifive.com>
8821
8822         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8823         (riscv_linux_fregset): New.
8824         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8825
8826 2019-02-07  Tom Tromey  <tom@tromey.com>
8827
8828         * thread.c (thread_cancel_execution_command): Update.
8829         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8830         methods.
8831         (struct thread_fsm_ops): Remove.
8832         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8833         (thread_fsm_should_stop, thread_fsm_return_value)
8834         (thread_fsm_set_finished, thread_fsm_finished_p)
8835         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8836         Don't declare.
8837         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8838         * infrun.c (clear_proceed_status_thread)
8839         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8840         (print_stop_event): Update.
8841         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8842         Add constructor.
8843         (step_command_fsm_ops): Remove.
8844         (new_step_command_fsm): Remove.
8845         (step_1): Update.
8846         (step_command_fsm::should_stop): Rename from
8847         step_command_fsm_should_stop.
8848         (step_command_fsm::clean_up): Rename from
8849         step_command_fsm_clean_up.
8850         (step_command_fsm::do_async_reply_reason): Rename from
8851         step_command_fsm_async_reply_reason.
8852         (struct until_next_fsm): Inherit from thread_fsm.  Add
8853         constructor.
8854         (until_next_fsm_ops): Remove.
8855         (new_until_next_fsm): Remove.
8856         (until_next_fsm::should_stop): Rename from
8857         until_next_fsm_should_stop.
8858         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8859         (until_next_fsm::do_async_reply_reason): Rename from
8860         until_next_fsm_async_reply_reason.
8861         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8862         constructor.  Change type of breakpoint.
8863         (finish_command_fsm_ops): Remove.
8864         (new_finish_command_fsm): Remove.
8865         (finish_command_fsm::should_stop): Rename from
8866         finish_command_fsm_should_stop.
8867         (finish_command_fsm::clean_up): Rename from
8868         finish_command_fsm_clean_up.
8869         (finish_command_fsm::return_value): Rename from
8870         finish_command_fsm_return_value.
8871         (finish_command_fsm::do_async_reply_reason): Rename from
8872         finish_command_fsm_async_reply_reason.
8873         (finish_command): Update.
8874         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8875         Add constructor.
8876         (call_thread_fsm_ops): Remove.
8877         (call_thread_fsm::call_thread_fsm): Rename from
8878         new_call_thread_fsm.
8879         (call_thread_fsm::should_stop): Rename from
8880         call_thread_fsm_should_stop.
8881         (call_thread_fsm::should_notify_stop): Rename from
8882         call_thread_fsm_should_notify_stop.
8883         (run_inferior_call, call_function_by_hand_dummy): Update.
8884         * cli/cli-interp.c (should_print_stop_to_console): Update.
8885         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8886         Add constructor.  Change type of location_breakpoint,
8887         caller_breakpoint.
8888         (until_break_fsm_ops): Remove.
8889         (new_until_break_fsm): Remove.
8890         (until_break_fsm::should_stop): Rename from
8891         until_break_fsm_should_stop.
8892         (until_break_fsm::clean_up): Rename from
8893         until_break_fsm_clean_up.
8894         (until_break_fsm::do_async_reply_reason): Rename from
8895         until_break_fsm_async_reply_reason.
8896         (until_break_command): Update.
8897         * thread-fsm.c: Remove.
8898         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8899
8900 2019-02-07  Tom Tromey  <tom@tromey.com>
8901
8902         * yy-remap.h: Add include guard.
8903         * xtensa-tdep.h: Add include guard.
8904         * xcoffread.h: Rename include guard.
8905         * varobj-iter.h: Add include guard.
8906         * tui/tui.h: Rename include guard.
8907         * tui/tui-winsource.h: Rename include guard.
8908         * tui/tui-wingeneral.h: Rename include guard.
8909         * tui/tui-windata.h: Rename include guard.
8910         * tui/tui-win.h: Rename include guard.
8911         * tui/tui-stack.h: Rename include guard.
8912         * tui/tui-source.h: Rename include guard.
8913         * tui/tui-regs.h: Rename include guard.
8914         * tui/tui-out.h: Rename include guard.
8915         * tui/tui-layout.h: Rename include guard.
8916         * tui/tui-io.h: Rename include guard.
8917         * tui/tui-hooks.h: Rename include guard.
8918         * tui/tui-file.h: Rename include guard.
8919         * tui/tui-disasm.h: Rename include guard.
8920         * tui/tui-data.h: Rename include guard.
8921         * tui/tui-command.h: Rename include guard.
8922         * tic6x-tdep.h: Add include guard.
8923         * target/waitstatus.h: Rename include guard.
8924         * target/wait.h: Rename include guard.
8925         * target/target.h: Rename include guard.
8926         * target/resume.h: Rename include guard.
8927         * target-float.h: Rename include guard.
8928         * stabsread.h: Add include guard.
8929         * rs6000-tdep.h: Add include guard.
8930         * riscv-fbsd-tdep.h: Add include guard.
8931         * regformats/regdef.h: Rename include guard.
8932         * record.h: Rename include guard.
8933         * python/python.h: Rename include guard.
8934         * python/python-internal.h: Rename include guard.
8935         * python/py-stopevent.h: Rename include guard.
8936         * python/py-ref.h: Rename include guard.
8937         * python/py-record.h: Rename include guard.
8938         * python/py-record-full.h: Rename include guard.
8939         * python/py-record-btrace.h: Rename include guard.
8940         * python/py-instruction.h: Rename include guard.
8941         * python/py-events.h: Rename include guard.
8942         * python/py-event.h: Rename include guard.
8943         * procfs.h: Add include guard.
8944         * proc-utils.h: Add include guard.
8945         * p-lang.h: Add include guard.
8946         * or1k-tdep.h: Rename include guard.
8947         * observable.h: Rename include guard.
8948         * nto-tdep.h: Rename include guard.
8949         * nat/x86-linux.h: Rename include guard.
8950         * nat/x86-linux-dregs.h: Rename include guard.
8951         * nat/x86-gcc-cpuid.h: Add include guard.
8952         * nat/x86-dregs.h: Rename include guard.
8953         * nat/x86-cpuid.h: Rename include guard.
8954         * nat/ppc-linux.h: Rename include guard.
8955         * nat/mips-linux-watch.h: Rename include guard.
8956         * nat/linux-waitpid.h: Rename include guard.
8957         * nat/linux-ptrace.h: Rename include guard.
8958         * nat/linux-procfs.h: Rename include guard.
8959         * nat/linux-osdata.h: Rename include guard.
8960         * nat/linux-nat.h: Rename include guard.
8961         * nat/linux-namespaces.h: Rename include guard.
8962         * nat/linux-btrace.h: Rename include guard.
8963         * nat/glibc_thread_db.h: Rename include guard.
8964         * nat/gdb_thread_db.h: Rename include guard.
8965         * nat/gdb_ptrace.h: Rename include guard.
8966         * nat/fork-inferior.h: Rename include guard.
8967         * nat/amd64-linux-siginfo.h: Rename include guard.
8968         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8969         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8970         * nat/aarch64-linux.h: Rename include guard.
8971         * nat/aarch64-linux-hw-point.h: Rename include guard.
8972         * mn10300-tdep.h: Add include guard.
8973         * mips-linux-tdep.h: Add include guard.
8974         * mi/mi-parse.h: Rename include guard.
8975         * mi/mi-out.h: Rename include guard.
8976         * mi/mi-main.h: Rename include guard.
8977         * mi/mi-interp.h: Rename include guard.
8978         * mi/mi-getopt.h: Rename include guard.
8979         * mi/mi-console.h: Rename include guard.
8980         * mi/mi-common.h: Rename include guard.
8981         * mi/mi-cmds.h: Rename include guard.
8982         * mi/mi-cmd-break.h: Rename include guard.
8983         * m2-lang.h: Add include guard.
8984         * location.h: Rename include guard.
8985         * linux-record.h: Rename include guard.
8986         * linux-nat.h: Add include guard.
8987         * linux-fork.h: Add include guard.
8988         * i386-darwin-tdep.h: Rename include guard.
8989         * hppa-linux-offsets.h: Add include guard.
8990         * guile/guile.h: Rename include guard.
8991         * guile/guile-internal.h: Rename include guard.
8992         * gnu-nat.h: Rename include guard.
8993         * gdb-stabs.h: Rename include guard.
8994         * frv-tdep.h: Add include guard.
8995         * f-lang.h: Add include guard.
8996         * event-loop.h: Add include guard.
8997         * darwin-nat.h: Rename include guard.
8998         * cp-abi.h: Rename include guard.
8999         * config/sparc/nm-sol2.h: Rename include guard.
9000         * config/nm-nto.h: Rename include guard.
9001         * config/nm-linux.h: Add include guard.
9002         * config/i386/nm-i386gnu.h: Rename include guard.
9003         * config/djgpp/nl_types.h: Rename include guard.
9004         * config/djgpp/langinfo.h: Rename include guard.
9005         * compile/gcc-cp-plugin.h: Add include guard.
9006         * compile/gcc-c-plugin.h: Add include guard.
9007         * compile/compile.h: Rename include guard.
9008         * compile/compile-object-run.h: Rename include guard.
9009         * compile/compile-object-load.h: Rename include guard.
9010         * compile/compile-internal.h: Rename include guard.
9011         * compile/compile-cplus.h: Rename include guard.
9012         * compile/compile-c.h: Rename include guard.
9013         * common/xml-utils.h: Rename include guard.
9014         * common/x86-xstate.h: Rename include guard.
9015         * common/version.h: Rename include guard.
9016         * common/vec.h: Rename include guard.
9017         * common/tdesc.h: Rename include guard.
9018         * common/selftest.h: Rename include guard.
9019         * common/scoped_restore.h: Rename include guard.
9020         * common/scoped_mmap.h: Rename include guard.
9021         * common/scoped_fd.h: Rename include guard.
9022         * common/safe-iterator.h: Rename include guard.
9023         * common/run-time-clock.h: Rename include guard.
9024         * common/refcounted-object.h: Rename include guard.
9025         * common/queue.h: Rename include guard.
9026         * common/ptid.h: Rename include guard.
9027         * common/print-utils.h: Rename include guard.
9028         * common/preprocessor.h: Rename include guard.
9029         * common/pathstuff.h: Rename include guard.
9030         * common/observable.h: Rename include guard.
9031         * common/netstuff.h: Rename include guard.
9032         * common/job-control.h: Rename include guard.
9033         * common/host-defs.h: Rename include guard.
9034         * common/gdb_wait.h: Rename include guard.
9035         * common/gdb_vecs.h: Rename include guard.
9036         * common/gdb_unlinker.h: Rename include guard.
9037         * common/gdb_unique_ptr.h: Rename include guard.
9038         * common/gdb_tilde_expand.h: Rename include guard.
9039         * common/gdb_sys_time.h: Rename include guard.
9040         * common/gdb_string_view.h: Rename include guard.
9041         * common/gdb_splay_tree.h: Rename include guard.
9042         * common/gdb_setjmp.h: Rename include guard.
9043         * common/gdb_ref_ptr.h: Rename include guard.
9044         * common/gdb_optional.h: Rename include guard.
9045         * common/gdb_locale.h: Rename include guard.
9046         * common/gdb_assert.h: Rename include guard.
9047         * common/filtered-iterator.h: Rename include guard.
9048         * common/filestuff.h: Rename include guard.
9049         * common/fileio.h: Rename include guard.
9050         * common/environ.h: Rename include guard.
9051         * common/common-utils.h: Rename include guard.
9052         * common/common-types.h: Rename include guard.
9053         * common/common-regcache.h: Rename include guard.
9054         * common/common-inferior.h: Rename include guard.
9055         * common/common-gdbthread.h: Rename include guard.
9056         * common/common-exceptions.h: Rename include guard.
9057         * common/common-defs.h: Rename include guard.
9058         * common/common-debug.h: Rename include guard.
9059         * common/cleanups.h: Rename include guard.
9060         * common/buffer.h: Rename include guard.
9061         * common/btrace-common.h: Rename include guard.
9062         * common/break-common.h: Rename include guard.
9063         * cli/cli-utils.h: Rename include guard.
9064         * cli/cli-style.h: Rename include guard.
9065         * cli/cli-setshow.h: Rename include guard.
9066         * cli/cli-script.h: Rename include guard.
9067         * cli/cli-interp.h: Rename include guard.
9068         * cli/cli-decode.h: Rename include guard.
9069         * cli/cli-cmds.h: Rename include guard.
9070         * charset-list.h: Add include guard.
9071         * buildsym-legacy.h: Rename include guard.
9072         * bfin-tdep.h: Add include guard.
9073         * ax.h: Rename include guard.
9074         * arm-linux-tdep.h: Add include guard.
9075         * arm-fbsd-tdep.h: Add include guard.
9076         * arch/xtensa.h: Rename include guard.
9077         * arch/tic6x.h: Add include guard.
9078         * arch/i386.h: Add include guard.
9079         * arch/arm.h: Rename include guard.
9080         * arch/arm-linux.h: Rename include guard.
9081         * arch/arm-get-next-pcs.h: Rename include guard.
9082         * arch/amd64.h: Add include guard.
9083         * arch/aarch64-insn.h: Rename include guard.
9084         * arch-utils.h: Rename include guard.
9085         * annotate.h: Add include guard.
9086         * amd64-darwin-tdep.h: Rename include guard.
9087         * aarch64-linux-tdep.h: Add include guard.
9088         * aarch64-fbsd-tdep.h: Add include guard.
9089         * aarch32-linux-nat.h: Add include guard.
9090
9091 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9092
9093         * macrotab.c (macro_define_internal): New function that
9094         factorizes macro_define_object_internal and macro_define_function
9095         code.
9096         (macro_define_object_internal): Use macro_define_internal.
9097         (macro_define_function): Likewise.
9098
9099 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9100
9101         * macrocmd.c (extract_identifier): Return
9102         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9103         callers.
9104
9105 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
9106
9107         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9108
9109 2019-02-05  Tom Tromey  <tom@tromey.com>
9110
9111         * target.c (target_stack::unpush): Move assertion earlier.
9112
9113 2019-01-30  Tom Tromey  <tom@tromey.com>
9114
9115         PR python/23615:
9116         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9117         (gdbpy_parse_and_eval): Likewise.
9118         * python/python-internal.h (gdbpy_allow_threads): New class.
9119
9120 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
9121
9122         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9123         (aarch64_fbsd_fpregmap): Move earlier.
9124         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9125         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9126         instead of individual calls to trad_frame_set_reg_addr.
9127         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9128         earlier.
9129         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9130         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9131         instead of individual calls to trad_frame_set_reg_addr.
9132
9133 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
9134
9135         * CONTRIBUTE: Replace contribution list with wiki link.
9136
9137 2019-01-25  Tom Tromey  <tom@tromey.com>
9138
9139         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9140
9141 2019-01-25  Tom Tromey  <tom@tromey.com>
9142
9143         * xtensa-linux-nat.c: Fix common/ includes.
9144         * xml-support.h: Fix common/ includes.
9145         * xml-support.c: Fix common/ includes.
9146         * x86-linux-nat.c: Fix common/ includes.
9147         * windows-nat.c: Fix common/ includes.
9148         * varobj.h: Fix common/ includes.
9149         * varobj.c: Fix common/ includes.
9150         * value.c: Fix common/ includes.
9151         * valops.c: Fix common/ includes.
9152         * utils.c: Fix common/ includes.
9153         * unittests/xml-utils-selftests.c: Fix common/ includes.
9154         * unittests/utils-selftests.c: Fix common/ includes.
9155         * unittests/unpack-selftests.c: Fix common/ includes.
9156         * unittests/tracepoint-selftests.c: Fix common/ includes.
9157         * unittests/style-selftests.c: Fix common/ includes.
9158         * unittests/string_view-selftests.c: Fix common/ includes.
9159         * unittests/scoped_restore-selftests.c: Fix common/ includes.
9160         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9161         * unittests/scoped_fd-selftests.c: Fix common/ includes.
9162         * unittests/rsp-low-selftests.c: Fix common/ includes.
9163         * unittests/parse-connection-spec-selftests.c: Fix common/
9164         includes.
9165         * unittests/optional-selftests.c: Fix common/ includes.
9166         * unittests/offset-type-selftests.c: Fix common/ includes.
9167         * unittests/observable-selftests.c: Fix common/ includes.
9168         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9169         * unittests/memrange-selftests.c: Fix common/ includes.
9170         * unittests/memory-map-selftests.c: Fix common/ includes.
9171         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9172         * unittests/function-view-selftests.c: Fix common/ includes.
9173         * unittests/environ-selftests.c: Fix common/ includes.
9174         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9175         * unittests/common-utils-selftests.c: Fix common/ includes.
9176         * unittests/cli-utils-selftests.c: Fix common/ includes.
9177         * unittests/array-view-selftests.c: Fix common/ includes.
9178         * ui-file.c: Fix common/ includes.
9179         * tui/tui-io.c: Fix common/ includes.
9180         * tracepoint.h: Fix common/ includes.
9181         * tracepoint.c: Fix common/ includes.
9182         * tracefile-tfile.c: Fix common/ includes.
9183         * top.h: Fix common/ includes.
9184         * top.c: Fix common/ includes.
9185         * thread.c: Fix common/ includes.
9186         * target/waitstatus.h: Fix common/ includes.
9187         * target/waitstatus.c: Fix common/ includes.
9188         * target.h: Fix common/ includes.
9189         * target.c: Fix common/ includes.
9190         * target-memory.c: Fix common/ includes.
9191         * target-descriptions.c: Fix common/ includes.
9192         * symtab.h: Fix common/ includes.
9193         * symfile.c: Fix common/ includes.
9194         * stap-probe.c: Fix common/ includes.
9195         * spu-linux-nat.c: Fix common/ includes.
9196         * sparc-nat.c: Fix common/ includes.
9197         * source.c: Fix common/ includes.
9198         * solib.c: Fix common/ includes.
9199         * solib-target.c: Fix common/ includes.
9200         * ser-unix.c: Fix common/ includes.
9201         * ser-tcp.c: Fix common/ includes.
9202         * ser-pipe.c: Fix common/ includes.
9203         * ser-base.c: Fix common/ includes.
9204         * selftest-arch.c: Fix common/ includes.
9205         * s12z-tdep.c: Fix common/ includes.
9206         * rust-exp.y: Fix common/ includes.
9207         * rs6000-aix-tdep.c: Fix common/ includes.
9208         * riscv-tdep.c: Fix common/ includes.
9209         * remote.c: Fix common/ includes.
9210         * remote-notif.h: Fix common/ includes.
9211         * remote-fileio.h: Fix common/ includes.
9212         * remote-fileio.c: Fix common/ includes.
9213         * regcache.h: Fix common/ includes.
9214         * regcache.c: Fix common/ includes.
9215         * record-btrace.c: Fix common/ includes.
9216         * python/python.c: Fix common/ includes.
9217         * python/py-type.c: Fix common/ includes.
9218         * python/py-inferior.c: Fix common/ includes.
9219         * progspace.h: Fix common/ includes.
9220         * producer.c: Fix common/ includes.
9221         * procfs.c: Fix common/ includes.
9222         * proc-api.c: Fix common/ includes.
9223         * printcmd.c: Fix common/ includes.
9224         * ppc-linux-nat.c: Fix common/ includes.
9225         * parser-defs.h: Fix common/ includes.
9226         * osdata.c: Fix common/ includes.
9227         * obsd-nat.c: Fix common/ includes.
9228         * nat/x86-linux.c: Fix common/ includes.
9229         * nat/x86-linux-dregs.c: Fix common/ includes.
9230         * nat/x86-dregs.h: Fix common/ includes.
9231         * nat/x86-dregs.c: Fix common/ includes.
9232         * nat/ppc-linux.c: Fix common/ includes.
9233         * nat/mips-linux-watch.h: Fix common/ includes.
9234         * nat/mips-linux-watch.c: Fix common/ includes.
9235         * nat/linux-waitpid.c: Fix common/ includes.
9236         * nat/linux-ptrace.h: Fix common/ includes.
9237         * nat/linux-ptrace.c: Fix common/ includes.
9238         * nat/linux-procfs.c: Fix common/ includes.
9239         * nat/linux-personality.c: Fix common/ includes.
9240         * nat/linux-osdata.c: Fix common/ includes.
9241         * nat/linux-namespaces.c: Fix common/ includes.
9242         * nat/linux-btrace.h: Fix common/ includes.
9243         * nat/linux-btrace.c: Fix common/ includes.
9244         * nat/fork-inferior.c: Fix common/ includes.
9245         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9246         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9247         * nat/aarch64-linux.c: Fix common/ includes.
9248         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9249         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9250         * namespace.h: Fix common/ includes.
9251         * mips-linux-tdep.c: Fix common/ includes.
9252         * minsyms.c: Fix common/ includes.
9253         * mi/mi-parse.h: Fix common/ includes.
9254         * mi/mi-main.c: Fix common/ includes.
9255         * mi/mi-cmd-env.c: Fix common/ includes.
9256         * memrange.h: Fix common/ includes.
9257         * memattr.c: Fix common/ includes.
9258         * maint.h: Fix common/ includes.
9259         * maint.c: Fix common/ includes.
9260         * main.c: Fix common/ includes.
9261         * machoread.c: Fix common/ includes.
9262         * location.c: Fix common/ includes.
9263         * linux-thread-db.c: Fix common/ includes.
9264         * linux-nat.c: Fix common/ includes.
9265         * linux-fork.c: Fix common/ includes.
9266         * inline-frame.c: Fix common/ includes.
9267         * infrun.c: Fix common/ includes.
9268         * inflow.c: Fix common/ includes.
9269         * inferior.h: Fix common/ includes.
9270         * inferior.c: Fix common/ includes.
9271         * infcmd.c: Fix common/ includes.
9272         * inf-ptrace.c: Fix common/ includes.
9273         * inf-child.c: Fix common/ includes.
9274         * ia64-linux-nat.c: Fix common/ includes.
9275         * i387-tdep.c: Fix common/ includes.
9276         * i386-tdep.c: Fix common/ includes.
9277         * i386-linux-tdep.c: Fix common/ includes.
9278         * i386-linux-nat.c: Fix common/ includes.
9279         * i386-go32-tdep.c: Fix common/ includes.
9280         * i386-fbsd-tdep.c: Fix common/ includes.
9281         * i386-fbsd-nat.c: Fix common/ includes.
9282         * guile/scm-type.c: Fix common/ includes.
9283         * guile/guile.c: Fix common/ includes.
9284         * go32-nat.c: Fix common/ includes.
9285         * gnu-nat.c: Fix common/ includes.
9286         * gdbthread.h: Fix common/ includes.
9287         * gdbarch-selftests.c: Fix common/ includes.
9288         * gdb_usleep.c: Fix common/ includes.
9289         * gdb_select.h: Fix common/ includes.
9290         * gdb_bfd.c: Fix common/ includes.
9291         * gcore.c: Fix common/ includes.
9292         * fork-child.c: Fix common/ includes.
9293         * findvar.c: Fix common/ includes.
9294         * fbsd-nat.c: Fix common/ includes.
9295         * event-top.c: Fix common/ includes.
9296         * event-loop.c: Fix common/ includes.
9297         * dwarf2read.c: Fix common/ includes.
9298         * dwarf2loc.c: Fix common/ includes.
9299         * dwarf2-frame.c: Fix common/ includes.
9300         * dwarf-index-cache.c: Fix common/ includes.
9301         * dtrace-probe.c: Fix common/ includes.
9302         * disasm-selftests.c: Fix common/ includes.
9303         * defs.h: Fix common/ includes.
9304         * csky-tdep.c: Fix common/ includes.
9305         * cp-valprint.c: Fix common/ includes.
9306         * cp-support.h: Fix common/ includes.
9307         * cp-support.c: Fix common/ includes.
9308         * corelow.c: Fix common/ includes.
9309         * completer.h: Fix common/ includes.
9310         * completer.c: Fix common/ includes.
9311         * compile/compile.c: Fix common/ includes.
9312         * compile/compile-loc2c.c: Fix common/ includes.
9313         * compile/compile-cplus-types.c: Fix common/ includes.
9314         * compile/compile-cplus-symbols.c: Fix common/ includes.
9315         * command.h: Fix common/ includes.
9316         * cli/cli-dump.c: Fix common/ includes.
9317         * cli/cli-cmds.c: Fix common/ includes.
9318         * charset.c: Fix common/ includes.
9319         * build-id.c: Fix common/ includes.
9320         * btrace.h: Fix common/ includes.
9321         * btrace.c: Fix common/ includes.
9322         * breakpoint.h: Fix common/ includes.
9323         * breakpoint.c: Fix common/ includes.
9324         * ax.h:
9325         (enum agent_op): Fix common/ includes.
9326         * ax-general.c (struct aop_map): Fix common/ includes.
9327         * ax-gdb.c: Fix common/ includes.
9328         * auxv.c: Fix common/ includes.
9329         * auto-load.c: Fix common/ includes.
9330         * arm-tdep.c: Fix common/ includes.
9331         * arch/riscv.c: Fix common/ includes.
9332         * arch/ppc-linux-common.c: Fix common/ includes.
9333         * arch/i386.c: Fix common/ includes.
9334         * arch/arm.c: Fix common/ includes.
9335         * arch/arm-linux.c: Fix common/ includes.
9336         * arch/arm-get-next-pcs.c: Fix common/ includes.
9337         * arch/amd64.c: Fix common/ includes.
9338         * arch/aarch64.c: Fix common/ includes.
9339         * arch/aarch64-insn.c: Fix common/ includes.
9340         * arch-utils.c: Fix common/ includes.
9341         * amd64-windows-tdep.c: Fix common/ includes.
9342         * amd64-tdep.c: Fix common/ includes.
9343         * amd64-sol2-tdep.c: Fix common/ includes.
9344         * amd64-obsd-tdep.c: Fix common/ includes.
9345         * amd64-nbsd-tdep.c: Fix common/ includes.
9346         * amd64-linux-tdep.c: Fix common/ includes.
9347         * amd64-linux-nat.c: Fix common/ includes.
9348         * amd64-fbsd-tdep.c: Fix common/ includes.
9349         * amd64-fbsd-nat.c: Fix common/ includes.
9350         * amd64-dicos-tdep.c: Fix common/ includes.
9351         * amd64-darwin-tdep.c: Fix common/ includes.
9352         * agent.c: Fix common/ includes.
9353         * ada-lang.h: Fix common/ includes.
9354         * ada-lang.c: Fix common/ includes.
9355         * aarch64-tdep.c: Fix common/ includes.
9356
9357 2019-01-25  Tom Tromey  <tom@tromey.com>
9358
9359         * common/create-version.sh: Use common/version.h.
9360
9361 2019-01-24  Pedro Alves  <palves@redhat.com>
9362
9363         * infrun.c (signal_stop, signal_print, signal_program)
9364         (signal_catch, signal_pass): Now arrays instead of pointers.
9365         (update_signals_program_target, do_target_resume)
9366         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9367         * linux-nat.c (linux_nat_target::pass_signals)
9368         (linux_nat_target::create_inferior, linux_nat_target::attach):
9369         Adjust.
9370         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9371         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9372         * procfs.c (procfs_target::pass_signals): Adjust.
9373         * record-full.c (record_full_target::resume): Adjust.
9374         * remote.c (remote_target::pass_signals)
9375         (remote_target::program_signals): Adjust.
9376         * target-debug.h (target_debug_print_signals): Now takes a
9377         gdb::array_view as parameter.  Adjust.
9378         * target.h (target_ops) <pass_signals, program_signals>: Replace
9379         pointer and length parameters with gdb::array_view.
9380         (target_pass_signals, target_program_signals): Likewise.
9381         * target-delegates.c: Regenerate.
9382
9383 2019-01-24  Pedro Alves  <palves@redhat.com>
9384
9385         * common/forward-scope-exit.h
9386         (forward_scope_exit::forward_scope_exit): Pass arguments to
9387         m_bind_function directly, instead of creating a std::bind and
9388         copying that.
9389
9390 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9391
9392         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9393         for static members.
9394         (pass_in_v_vfp_candidate): Likewise.
9395
9396 2019-01-23  Tom Tromey  <tom@tromey.com>
9397             Pedro Alves  <palves@redhat.com>
9398
9399         * regcache.c (class regcache_invalidator): Remove.
9400         (regcache::raw_write): Use make_scope_exit.
9401
9402 2019-01-23  Tom Tromey  <tom@tromey.com>
9403
9404         * ui-out.h (class ui_out_emit_type): Update comment.
9405
9406 2019-01-23  Tom Tromey  <tom@tromey.com>
9407
9408         * infrun.c (fetch_inferior_event): Update comment.
9409
9410 2019-01-23  Tom Tromey  <tom@tromey.com>
9411             Pedro Alves  <palves@redhat.com>
9412
9413         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9414         parameter.
9415         (fetch_inferior_event): Use SCOPE_EXIT.
9416
9417
9418 2019-01-23  Tom Tromey  <tom@tromey.com>
9419             Pedro Alves  <palves@redhat.com>
9420
9421         * infrun.c (disable_thread_events): Delete.
9422         (stop_all_threads): Use SCOPE_EXIT.
9423
9424 2019-01-23  Tom Tromey  <tom@tromey.com>
9425             Pedro Alves  <palves@redhat.com>
9426
9427         * symfile.c: Include forward-scope-exit.h.
9428         (clear_symtab_users_cleanup): Replace forward declaration with
9429         a FORWARD_SCOPE_EXIT.
9430         (syms_from_objfile_1): Use the forward_scope_exit and
9431         gdb::optional instead of cleanup_function.
9432         (reread_symbols): Use the forward_scope_exit instead of
9433         cleanup_function.
9434         (clear_symtab_users_cleanup): Remove function.
9435
9436 2019-01-23  Tom Tromey  <tom@tromey.com>
9437             Pedro Alves  <palves@redhat.com>
9438
9439         * linux-nat.c: Include scope-exit.h.
9440         (cleanup_target_stop): Remove.
9441         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9442         SCOPE_EXIT.
9443
9444 2019-01-23  Tom Tromey  <tom@tromey.com>
9445             Pedro Alves  <palves@redhat.com>
9446
9447         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9448         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9449
9450 2019-01-23  Tom Tromey  <tom@tromey.com>
9451             Andrew Burgess  <andrew.burgess@embecosm.com>
9452             Pedro Alves  <palves@redhat.com>
9453
9454         * infrun.c (fetch_inferior_event): Use scope_exit.
9455         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9456         * top.c (execute_command): Use scope_exit.
9457         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9458         * utils.c (do_bpstat_clear_actions_cleanup)
9459         (make_bpstat_clear_actions_cleanup): Remove.
9460
9461 2019-01-23  Tom Tromey  <tom@tromey.com>
9462             Pedro Alves  <palves@redhat.com>
9463
9464         * infrun.c: Include "common/scope-exit.h"
9465         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9466         (wait_for_inferior): Use SCOPE_EXIT.
9467         (fetch_inferior_event): Use scope_exit.
9468
9469 2019-01-23  Tom Tromey  <tom@tromey.com>
9470             Pedro Alves  <palves@redhat.com>
9471
9472         * breakpoint.c (create_breakpoint): Remove cleanup.
9473
9474 2019-01-23  Tom Tromey  <tom@tromey.com>
9475             Andrew Burgess  <andrew.burgess@embecosm.com>
9476             Pedro Alves  <palves@redhat.com>
9477
9478 2019-01-23  Pedro Alves  <palves@redhat.com>
9479
9480         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9481
9482 2019-01-23  Pedro Alves  <palves@redhat.com>
9483             Andrew Burgess  <andrew.burgess@embecosm.com>
9484
9485         * gdbthread.h: Include "common/forward-scope-exit.h".
9486         (scoped_finish_thread_state): Redefine custom class in terms of
9487         forward_scope_exit.
9488
9489 2019-01-23  Pedro Alves  <palves@redhat.com>
9490             Andrew Burgess  <andrew.burgess@embecosm.com>
9491
9492         * common/forward-scope-exit.h: New file.
9493
9494 2019-01-23  Pedro Alves  <palves@redhat.com>
9495             Andrew Burgess  <andrew.burgess@embecosm.com>
9496             Tom Tromey  <tom@tromey.com>
9497
9498         * common/scope-exit.h: New file.
9499
9500 2019-01-23  Pedro Alves  <palves@redhat.com>
9501
9502         * common/preprocessor.h (ESC): Rename to ...
9503         (ESC_PARENS): ... this.
9504         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9505         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9506
9507 2019-01-23  Tom Tromey  <tom@tromey.com>
9508
9509         * language.h (class scoped_switch_to_sym_language_if_auto):
9510         Initialize m_lang in both cases.
9511
9512 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9513
9514         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9515         with XCNEW.
9516
9517 2019-01-22  Tom Tromey  <tom@tromey.com>
9518
9519         * corelow.c: Do not include sys/file.h.
9520
9521 2019-01-22  Tom Tromey  <tom@tromey.com>
9522
9523         * tui/tui-wingeneral.h: Include gdb_curses.h.
9524
9525 2019-01-22  Tom Tromey  <tom@tromey.com>
9526
9527         * source-cache.h (class source_cache) <get_source_lines,
9528         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9529
9530 2019-01-22  Tom Tromey  <tom@tromey.com>
9531
9532         * remote-fileio.h (struct remote_target): Declare.
9533
9534 2019-01-22  Tom Tromey  <tom@tromey.com>
9535
9536         * python/py-arch.c: Do not include py-ref.h.
9537         * python/py-bpevent.c: Do not include py-ref.h.
9538         * python/py-cmd.c: Do not include py-ref.h.
9539         * python/py-continueevent.c: Do not include py-ref.h.
9540         * python/py-event.h: Do not include py-ref.h.
9541         * python/py-evtregistry.c: Do not include py-ref.h.
9542         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9543         * python/py-frame.c: Do not include py-ref.h.
9544         * python/py-framefilter.c: Do not include py-ref.h.
9545         * python/py-function.c: Do not include py-ref.h.
9546         * python/py-infevents.c: Do not include py-ref.h.
9547         * python/py-linetable.c: Do not include py-ref.h.
9548         * python/py-objfile.c: Do not include py-ref.h.
9549         * python/py-param.c: Do not include py-ref.h.
9550         * python/py-prettyprint.c: Do not include py-ref.h.
9551         * python/py-progspace.c: Do not include py-ref.h.
9552         * python/py-symbol.c: Do not include py-ref.h.
9553         * python/py-symtab.c: Do not include py-ref.h.
9554         * python/py-type.c: Do not include py-ref.h.
9555         * python/py-unwind.c: Do not include py-ref.h.
9556         * python/py-utils.c: Do not include py-ref.h.
9557         * python/py-value.c: Do not include py-ref.h.
9558         * python/py-varobj.c: Do not include py-ref.h.
9559         * python/py-xmethods.c: Do not include py-ref.h.
9560         * python/python.c: Do not include py-ref.h.
9561         * varobj.c: Do not include py-ref.h.
9562
9563 2019-01-22  Tom Tromey  <tom@tromey.com>
9564
9565         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9566         keyword for bcache.
9567
9568 2019-01-22  Tom Tromey  <tom@tromey.com>
9569
9570         * compile/compile-cplus-types.c: Remove a comment by #include.
9571
9572 2019-01-22  Tom Tromey  <tom@tromey.com>
9573
9574         * compile/gcc-c-plugin.h: Include compile-internal.h.
9575
9576 2019-01-22  Tom Tromey  <tom@tromey.com>
9577
9578         * stabsread.c (EXTERN): Do not define.
9579         (symnum, next_symbol_text_func, processing_gcc_compilation)
9580         (within_function, global_sym_chain, global_stabs)
9581         (previous_stab_code, this_object_header_files)
9582         (n_this_object_header_files)
9583         (n_allocated_this_object_header_files): Define.
9584         * stabsread.h (EXTERN): Never define.  Use "extern".
9585
9586 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9587
9588         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9589         history_value.
9590
9591 2019-01-21  Tom Tromey  <tom@tromey.com>
9592
9593         * ui-out.c: Fix includes.
9594         * tui/tui-source.c: Fix includes.
9595         * target.c: Fix includes.
9596         * remote.c: Fix includes.
9597         * regcache.c: Fix includes.
9598         * python/py-block.c: Fix includes.
9599         * printcmd.c: Fix includes.
9600         * or1k-tdep.c: Fix includes.
9601         * mi/mi-main.c: Fix includes.
9602         * m32r-tdep.c: Fix includes.
9603         * csky-tdep.c: Fix includes.
9604         * compile/compile-cplus-types.c: Fix includes.
9605         * cli/cli-interp.c: Fix includes.
9606
9607 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9608
9609         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9610         for padding.
9611
9612 2019-01-16  Tom Tromey  <tom@tromey.com>
9613
9614         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9615         earlier.
9616         (struct objfile) <msymbols_range>: Move from top level.
9617         <msymbols>: New method.
9618         (class objfile_msymbols): Remove.
9619         * symtab.c (default_collect_symbol_completion_matches_break_on):
9620         Update.
9621         * symmisc.c (dump_msymbols): Update.
9622         * stabsread.c (scan_file_globals): Update.
9623         * objc-lang.c (info_selectors_command, info_classes_command)
9624         (find_methods): Update.
9625         * minsyms.c (find_solib_trampoline_target): Update.
9626         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9627         * coffread.c (coff_symfile_read): Update.
9628         * ada-lang.c (ada_lookup_simple_minsym)
9629         (ada_collect_symbol_completion_matches): Update.
9630
9631 2019-01-16  Tom Tromey  <tom@tromey.com>
9632
9633         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9634         type.  Remove no-argument constructor.
9635         <iterator::operator++>: Simplify.
9636         <begin>: Update.
9637         <end>: Use minimal_symbol_count.
9638
9639 2019-01-16  Tom Tromey  <tom@tromey.com>
9640
9641         * objfiles.h (struct objfile) <psymtabs>: New method.
9642         (class objfile_psymtabs): Remove.
9643         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9644         typedef.
9645         <range>: New method.
9646         (require_partial_symbols): Change return type.
9647         * psymtab.c (require_partial_symbols)
9648         (psym_expand_symtabs_matching): Update.
9649         * mdebugread.c (parse_partial_symbols): Update.
9650         * dbxread.c (dbx_end_psymtab): Update.
9651
9652 2019-01-15  Tom Tromey  <tom@tromey.com>
9653
9654         * symtab.c (lookup_objfile_from_block)
9655         (lookup_symbol_in_objfile_symtabs)
9656         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9657         (find_line_symtab, info_sources_command)
9658         (default_collect_symbol_completion_matches_break_on)
9659         (make_source_files_completion_list): Update.
9660         * symmisc.c (print_objfile_statistics, dump_objfile)
9661         (maintenance_print_symbols, maintenance_info_symtabs)
9662         (maintenance_check_symtabs, maintenance_info_line_tables):
9663         Update.
9664         * source.c (select_source_symtab)
9665         (forget_cached_source_info_for_objfile): Update.
9666         * objfiles.h (class objfile_compunits): Remove.
9667         (struct objfile) <compunits_range>: New typedef.
9668         (compunits): New method.
9669         * objfiles.c (objfile_relocate1): Update.
9670         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9671         * maint.c (count_symtabs_and_blocks): Update.
9672         * linespec.c (iterate_over_all_matching_symtabs): Update.
9673         * cp-support.c (add_symbol_overload_list_qualified): Update.
9674         * coffread.c (coff_symtab_read): Update.
9675         * ada-lang.c (add_nonlocal_symbols)
9676         (ada_collect_symbol_completion_matches)
9677         (ada_add_global_exceptions): Update.
9678
9679 2019-01-15  Tom Tromey  <tom@tromey.com>
9680
9681         * progspace.h (program_space) <objfiles_safe_range>: New
9682         typedef.
9683         <objfiles_safe>: New method.
9684         * objfiles.h (class all_objfiles_safe): Remove.
9685         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9686         * jit.c (jit_inferior_exit_hook): Update.
9687
9688 2019-01-17  Tom Tromey  <tom@tromey.com>
9689
9690         * progspace.h (program_space) <objfiles_range>: New typedef.
9691         <objfiles>: New method.
9692         <objfiles_head>: Rename from objfiles.
9693         (object_files): Update.
9694         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9695         * guile/scm-pretty-print.c
9696         (ppscm_find_pretty_printer_from_objfiles): Update.
9697         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9698         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9699         Update.
9700         * python/py-progspace.c (pspy_get_objfiles): Update.
9701         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9702         Update.
9703         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9704         (objfpy_lookup_objfile_by_build_id): Update.
9705         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9706         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9707         Update.
9708         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9709         (expand_symtab_containing_pc, lookup_objfile_from_block)
9710         (lookup_static_symbol, basic_lookup_transparent_type)
9711         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9712         (find_line_symtab, info_sources_command)
9713         (default_collect_symbol_completion_matches_break_on)
9714         (make_source_files_completion_list, find_main_name): Update.
9715         * symmisc.c (print_symbol_bcache_statistics)
9716         (print_objfile_statistics, maintenance_print_symbols)
9717         (maintenance_print_msymbols, maintenance_print_objfiles)
9718         (maintenance_info_symtabs, maintenance_check_symtabs)
9719         (maintenance_expand_symtabs, maintenance_info_line_tables):
9720         Update.
9721         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9722         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9723         (map_overlay_command, unmap_overlay_command)
9724         (simple_overlay_update, expand_symtabs_matching)
9725         (map_symbol_filenames): Update.
9726         * symfile-debug.c (set_debug_symfile): Update.
9727         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9728         Update.
9729         * source.c (select_source_symtab, forget_cached_source_info):
9730         Update.
9731         * solib.c (solib_read_symbols): Update.
9732         * solib-spu.c (append_ocl_sos): Update.
9733         * psymtab.c (maintenance_print_psymbols)
9734         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9735         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9736         * printcmd.c (info_symbol_command): Update.
9737         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9738         Update.
9739         * objfiles.h (class all_objfiles): Remove.
9740         * objfiles.c (have_partial_symbols, have_full_symbols)
9741         (have_minimal_symbols, qsort_cmp, update_section_map)
9742         (shared_objfile_contains_address_p)
9743         (default_iterate_over_objfiles_in_search_order): Update.
9744         * objc-lang.c (info_selectors_command, info_classes_command)
9745         (find_methods): Update.
9746         * minsyms.c (find_solib_trampoline_target): Update.
9747         * maint.c (maintenance_info_sections)
9748         (maintenance_translate_address, count_symtabs_and_blocks):
9749         Update.
9750         * main.c (captured_main_1): Update.
9751         * linux-thread-db.c (try_thread_db_load_from_pdir)
9752         (has_libpthread): Update.
9753         * linespec.c (iterate_over_all_matching_symtabs)
9754         (search_minsyms_for_name): Update.
9755         * jit.c (jit_find_objf_with_entry_addr): Update.
9756         * hppa-tdep.c (find_unwind_entry)
9757         (hppa_lookup_stub_minimal_symbol): Update.
9758         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9759         Update.
9760         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9761         (elf_gnu_ifunc_resolve_by_got): Update.
9762         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9763         * dwarf-index-write.c (save_gdb_index_command): Update.
9764         * cp-support.c (add_symbol_overload_list_qualified): Update.
9765         * breakpoint.c (create_overlay_event_breakpoint)
9766         (create_longjmp_master_breakpoint)
9767         (create_std_terminate_master_breakpoint)
9768         (create_exception_master_breakpoint): Update.
9769         * blockframe.c (find_pc_partial_function): Update.
9770         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9771         (ada_collect_symbol_completion_matches)
9772         (ada_add_global_exceptions): Update.
9773
9774 2019-01-17  Tom Tromey  <tom@tromey.com>
9775
9776         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9777         declare VEC.
9778         (solib_target_parse_libraries): Change return type.
9779         (library_list_start_segment, library_list_start_section)
9780         (library_list_end_library, library_list_start_library); Update.
9781         (solib_target_free_library_list): Remove.
9782         (solib_target_parse_libraries): Remove cleanup.  Change return
9783         type.
9784         (solib_target_current_sos): Update.
9785
9786 2019-01-17  Tom Tromey  <tromey@bapiya>
9787
9788         * valprint.c: Replace "the the" with "the".
9789         * symtab.c: Replace "the the" with "the".
9790         * solib.c: Replace "the the" with "the".
9791         * solib-dsbt.c: Replace "the the" with "the".
9792         * linespec.c: Replace "the the" with "the".
9793         * dwarf2loc.h: Replace "the the" with "the".
9794         * amd64-windows-tdep.c: Replace "the the" with "the".
9795         * aarch64-tdep.c: Replace "the the" with "the".
9796
9797 2019-01-16  Keith Seitz  <keiths@redhat.com>
9798
9799         PR gdb/23773
9800         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9801         <builder>: Rename to ..
9802         <m_builder>: ... this and make private.
9803         (dwarf2_cu::get_builder): New method.  Change all users of
9804         `builder' to use this method.
9805         (dwarf2_start_symtab): Move to ...
9806         (dwarf2_cu::start_symtab): ... here.  Update all callers
9807         (setup_type_unit_groups): Move to ...
9808         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9809         callers.
9810         (dwarf2_cu::reset_builder): New method.
9811         (process_full_compunit, process_full_type_unit): Use
9812         dwarf2_cu::reset_builder.
9813         (follow_die_offset): Record the ancestor CU if it is different
9814         from the followed DIE's CU.
9815         (follow_die_sig_1): Likewise.
9816
9817 2019-01-15  Tom Tromey  <tom@tromey.com>
9818
9819         * remote.c (class remote_state) <buf>: Now a char_vector.
9820         <buf_size>: Remove.
9821         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9822         parameter.
9823         (remote_target::getpkt_or_notif_sane_1)
9824         (remote_target::getpkt_sane)
9825         (remote_target::getpkt_or_notif_sane): Likewise.
9826         (class remote_target) <putpkt>: New overload.
9827         (remote_target::read_frame): Change type of "buf_p".  Remove
9828         sizeof_p parameter.
9829         (packet_ok): New overload.
9830         (packet_check_result): New overload.
9831         Update all uses.
9832
9833 2019-01-14  Tom Tromey  <tom@tromey.com>
9834
9835         * remote-notif.c (handle_notification, remote_notif_ack)
9836         (remote_notif_parse): Make "buf" const.
9837         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9838         const.
9839         (remote_notif_parse, remote_notif_ack, handle_notification):
9840         Likewise.
9841         * remote.c (remote_notif_stop_parse): Make "buf" const.
9842         (remote_target::remote_parse_stop_reply): Make "buf" const.
9843         (remote_notif_stop_ack): Make "buf" const.
9844
9845 2019-01-14  Tom Tromey  <tom@tromey.com>
9846
9847         * remote.c (remote_console_output): Make parameter const.
9848
9849 2019-01-14  Tom Tromey  <tom@tromey.com>
9850
9851         * target-debug.h (target_debug_print_signals): Constify.
9852         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9853         * procfs.c (procfs_target::pass_signals): Update.
9854         * linux-nat.c (linux_nat_target::pass_signals): Update.
9855         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9856         * target-delegates.c: Rebuild.
9857         * remote.c (remote_target::program_signals): Update.
9858         (remote_target::pass_signals): Update.
9859         * target.c (target_pass_signals): Constify argument.
9860         (target_program_signals): Likewise.
9861         * target.h (struct target_ops) <pass_signals, program_signals>:
9862         Constify argument.
9863         (target_pass_signals, target_program_signals): Constify argument.
9864
9865 2019-01-14  Tom Tromey  <tom@tromey.com>
9866
9867         PR tui/28819:
9868         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9869
9870 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9871
9872         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9873         field.
9874         * rs6000-tdep.c: Include reggroups.h.
9875         (IS_V_ALIAS_PSEUDOREG): Define.
9876         (rs6000_register_name): Return names for the "vX" aliases.
9877         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9878         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9879         aliases.  Call default_register_reggroup_p for all other
9880         pseudo-registers.
9881         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9882         New functions.
9883         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9884         Handle "vX" aliases.
9885         (v_alias_pseudo_register_collect): New function.
9886         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9887         (rs6000_gdbarch_init): Initialize "vX" aliases as
9888         pseudo-registers.  Restore registration of
9889         rs6000_pseudo_register_reggroup_p with
9890         set_tdesc_pseudo_register_reggroup_p.
9891
9892 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9893
9894         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9895         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9896         set_gdbarch_num_pseudo_regs.
9897
9898 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9899
9900         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9901         Remove arg prefixname, add do_set and do_show.
9902         Add member functions set_list and show_list.
9903         * cli/cli-style.c (class cli_style_option): Update accordingly.
9904         (style_set_list): Move to file scope.
9905         (style_show_list): Likewise.
9906         (set_style): Call help_list.
9907         (show_style): Call cmd_show_list.
9908         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9909         Update to use the new macro.
9910
9911 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9912
9913         * ada-lang.c (_initialize_ada_language): Expand the help text
9914         for the "catch exception" command.
9915
9916 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9917
9918         * symtab.c (matching_obj_sections): Initialize obj,
9919         declare it closer to its usage.
9920
9921 2019-01-10  Tom Tromey  <tom@tromey.com>
9922
9923         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9924         (basic_inf_threads_range): Remove.
9925         (inf_threads_range, inf_non_exited_threads_range)
9926         (safe_inf_threads_range): Use next_adapter.
9927
9928 2019-01-10  Keith Seitz  <keiths@redhat.com>
9929
9930         PR gdb/23712
9931         PR symtab/23010
9932         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9933         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9934
9935 2019-01-10  Keith Seitz  <keiths@redhat.com>
9936
9937         PR gdb/23712
9938         PR symtab/23010
9939         * dictionary.c (pending_to_vector): Remove.
9940         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9941         Remove _1 suffix, replacing functions of the same name.  Update
9942         all callers.
9943         (dict_create_hashed, dict_create_hashed_expandable)
9944         (dict_create_linear, dict_create_linear_expandable, dict_free)
9945         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9946         Make functions static.
9947
9948 2019-01-10  Keith Seitz  <keiths@redhat.com>
9949
9950         PR gdb/23712
9951         PR symtab/23010
9952         * dictionary.h (struct dictionary): Replace declaration with
9953         multidictionary.
9954         (dict_create_hashed, dict_create_hashed_expandable)
9955         (dict_create_linear, dict_create_linear_expandable)
9956         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9957         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9958         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9959         taking multidictionary argument.
9960         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9961         * block.h (struct block) <dict>: Change to multidictionary
9962         and rename `multidict'.
9963         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9964         symmisc.c: Update all dictionary references to multidictionary.
9965
9966 2019-01-10  Keith Seitz  <keiths@redhat.com>
9967
9968         PR gdb/23712
9969         PR symtab/23010
9970         * dictionary.c: Include unordered_map.
9971         (pending_to_vector): New function.
9972         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9973         Rewrite the non-"_1" functions to take vector instead
9974         of linked list.
9975         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9976         "new" _1 versions of the same name.
9977         (multidictionary): Define.
9978         (std::hash<enum language): New definition.
9979         (collate_pending_symbols_by_language, mdict_create_hashed)
9980         (mdict_create_hashed_expandable, mdict_create_linear)
9981         (mdict_create_linear_expandable, mdict_free)
9982         (find_language_dictionary, create_new_language_dictionary)
9983         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9984         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9985         (mdict_size, mdict_empty): New functions.
9986         * dictionary.h (mdict_iterator): Define.
9987
9988 2019-01-10  Pedro Alves  <palves@redhat.com>
9989
9990         * breakpoint.c (read_uploaded_action)
9991         (create_tracepoint_from_upload): Adjust to use
9992         gdb::unique_xmalloc_ptr.
9993         * ctf.c (ctf_write_uploaded_tp):
9994         (SET_ARRAY_FIELD): Use emplace_back.
9995         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9996         * tracefile-tfile.c (tfile_write_uploaded_tp):
9997         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9998         gdb::unique_xmalloc_ptr.
9999         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10000         at_string, cond_string, cmd_strings>: Replace char pointers
10001         with gdb::unique_xmalloc_ptr.
10002
10003 2019-01-10  Pedro Alves  <palves@redhat.com>
10004
10005         * solib-target.c (library_list_start_library): Don't xstrdup name.
10006
10007 2019-01-10  Pedro Alves  <palves@redhat.com>
10008
10009         * mdebugread.c (parse_partial_symbols): Use
10010         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10011
10012 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10013
10014         * linux-fork.c (scoped_switch_fork_info)
10015         <~scoped_switch_fork_info>: Fix incorrect variable name.
10016
10017 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10018
10019         * linux-fork.c (scoped_switch_fork_info)
10020         <scoped_switch_fork_info>: Make explicit.
10021         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10022
10023 2019-01-10  Tom Tromey  <tom@tromey.com>
10024
10025         * objfiles.h (objfile::reset_psymtabs): Update.
10026         * objfiles.c (objfile::objfile): Update.
10027         * psymtab.h (psymtab_storage::obstack): Update.
10028         (psymtab_storage::m_obstack): Use gdb::optional.
10029         (class psymtab_storage): Update comment.  Remove objfile
10030         parameter.
10031         * psymtab.c (psymtab_storage::psymtab_storage): Update.
10032
10033 2019-01-10  Tom Tromey  <tom@tromey.com>
10034
10035         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
10036         <free_psymtabs>: Now private.
10037         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
10038         (allocate_psymtab): Use new method.
10039
10040 2019-01-10  Tom Tromey  <tom@tromey.com>
10041
10042         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
10043         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
10044         * mdebugread.c (parse_partial_symbols): Use
10045         allocate_dependencies.
10046         * dwarf2read.c (dwarf2_create_include_psymtab): Use
10047         allocate_dependencies.
10048         (process_psymtab_comp_unit_reader)
10049         (build_type_psymtab_dependencies): Likewise.
10050         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
10051
10052 2019-01-10  Tom Tromey  <tom@tromey.com>
10053
10054         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
10055         PSYMBOL_SET_LANGUAGE.
10056         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
10057
10058 2019-01-10  Tom Tromey  <tom@tromey.com>
10059
10060         * psymtab.h (psymtab_storage::obstack): New method.
10061         <m_obstack>: Rename from obstack; now private.
10062         * psymtab.c (psymtab_storage): Update.
10063         * dwarf2read.c (create_addrmap_from_index)
10064         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10065         Update.
10066
10067 2019-01-10  Tom Tromey  <tom@tromey.com>
10068
10069         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10070         * objfiles.h (objfile::reset_psymtabs): New method.
10071
10072 2019-01-10  Tom Tromey  <tom@tromey.com>
10073
10074         * symmisc.c (print_symbol_bcache_statistics): Update.
10075         (print_objfile_statistics): Update.
10076         * symfile.c (reread_symbols): Update.
10077         * psymtab.h (class psymtab_storage): New.
10078         * psymtab.c (psymtab_storage): New constructor.
10079         (~psymtab_storage): New destructor.
10080         (require_partial_symbols): Update.
10081         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10082         (find_pc_sect_psymtab, find_pc_sect_psymbol)
10083         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10084         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10085         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10086         (start_psymtab_common, end_psymtab_common)
10087         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10088         (allocate_psymtab): Update.
10089         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10090         Update.
10091         (dump_psymtab_addrmap, maintenance_print_psymbols)
10092         (maintenance_check_psymtabs): Update.
10093         (class objfile_psymtabs): Move to objfiles.h.
10094         * psympriv.h (discard_psymtab): Now inline.
10095         (psymtab_discarder::psymtab_discarder): Update.
10096         (psymtab_discarder::~psymtab_discarder): Update.
10097         (ALL_OBJFILE_PSYMTABS): Rewrite.
10098         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10099         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10100         Remove fields.
10101         <partial_symtabs>: New field.
10102         (class objfile_psymtabs): Move from psymtab.h.  Update.
10103         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10104         psymbol_cache.
10105         (objfile::~objfile): Don't destroy psymbol_cache.
10106         * mdebugread.c (parse_partial_symbols): Update.
10107         * dwarf2read.c (create_addrmap_from_index)
10108         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10109         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10110         (add_partial_subprogram, dwarf2_ranges_read): Update.
10111         * dwarf-index-write.c (write_address_map)
10112         (write_one_signatured_type, recursively_write_psymbols)
10113         (class debug_names, class debug_names, write_psymtabs_to_index):
10114         Update.
10115
10116 2019-01-10  Tom Tromey  <tom@tromey.com>
10117
10118         * symtab.h (SYMBOL_SET_NAMES): Update.
10119         (symbol_set_names): Update.
10120         (MSYMBOL_SET_NAMES): Update.
10121         * symtab.c (symbol_set_names): Change argument to be an
10122         objfile_per_bfd_storage.
10123         * psymtab.c (add_psymbol_to_bcache): Update.
10124         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10125
10126 2019-01-10  Tom Tromey  <tom@tromey.com>
10127
10128         * symtab.c (create_demangled_names_hash): Change argument to be an
10129         objfile_per_bfd_storage.
10130         (symbol_set_names): Update.
10131
10132 2019-01-10  Tom Tromey  <tom@tromey.com>
10133
10134         * xcoffread.c (xcoff_initial_scan): Unconditionally call
10135         init_psymbol_list.
10136         * psymtab.c (init_psymbol_list): Do nothing if already called.
10137         * psympriv.h (init_psymbol_list): Add comment.
10138         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10139         init_psymbol_list.
10140         * dbxread.c (dbx_symfile_read): Unconditionally call
10141         init_psymbol_list.
10142
10143 2019-01-10  Tom Tromey  <tom@tromey.com>
10144
10145         * xcoffread.c (scan_xcoff_symtab): Update.
10146         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10147         "where".
10148         * mdebugread.c (parse_partial_symbols)
10149         (handle_psymbol_enumerators): Update.
10150         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10151         * dbxread.c (read_dbx_symtab): Update.
10152         * psympriv.h (psymbol_placement): New enum.
10153         (add_psymbol_to_list): Update.
10154
10155 2019-01-10  Tom Tromey  <tom@tromey.com>
10156
10157         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10158         static_psymbols parameters.
10159         (scan_xcoff_symtab): Update.
10160         * psymtab.c (start_psymtab_common): Remove global_psymbols and
10161         static_psymbols parameters.
10162         * psympriv.h (start_psymtab_common): Update.
10163         * mdebugread.c (parse_partial_symbols): Update.
10164         * dwarf2read.c (create_partial_symtab): Update.
10165         * dbxread.c (read_dbx_symtab): Update.
10166         (start_psymtab): Remove global_psymbols and static_psymbols
10167         parameters.
10168
10169 2019-01-10  Tom Tromey  <tom@tromey.com>
10170
10171         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10172         * psymtab.c (allocate_psymtab): Add comment.
10173         * psympriv.h (allocate_psymtab): Add comment.
10174         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10175         initializations.
10176         * dbxread.c (dbx_end_psymtab): Remove some initializations.
10177
10178 2019-01-10  Tom Tromey  <tom@tromey.com>
10179
10180         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10181         Don't declare.
10182         * mipsread.c: Include mdebugread.h.
10183         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10184         Declare.
10185         * elfread.c: Include mdebugread.h.
10186
10187 2019-01-09  Tom Tromey  <tom@tromey.com>
10188
10189         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10190         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10191         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10192         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10193         (psym_lookup_symbol, psym_find_last_source_symtab)
10194         (psym_forget_cached_source_info, psym_print_stats)
10195         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10196         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10197         (psym_map_matching_symbols, psym_expand_symtabs_matching)
10198         (psym_find_compunit_symtab_by_address)
10199         (maintenance_print_psymbols, maintenance_info_psymtabs)
10200         (maintenance_check_psymtabs): Use ranged for.
10201         * psymtab.h (class objfile_psymtabs): New.
10202         (require_partial_symbols): Return objfile_psymtabs.
10203         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10204
10205 2019-01-09  Tom Tromey  <tom@tromey.com>
10206
10207         * symfile.c (overlay_invalidate_all, find_pc_overlay)
10208         (find_pc_mapped_section, list_overlays_command)
10209         (map_overlay_command, unmap_overlay_command)
10210         (simple_overlay_update): Use all_objfiles.
10211         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10212         * printcmd.c (info_symbol_command): Use all_objfiles.
10213         * objfiles.h (ALL_OBJSECTIONS): Remove.
10214         * maint.c (maintenance_translate_address): Use all_objfiles.
10215         * gcore.c (gcore_create_callback): Use all_objfiles.
10216         (objfile_find_memory_regions): Likewise.
10217
10218 2019-01-09  Tom Tromey  <tom@tromey.com>
10219
10220         * symtab.c (find_line_symtab, info_sources_command)
10221         (make_source_files_completion_list): Use objfile_compunits.
10222         * source.c (select_source_symtab): Use objfile_compunits.
10223         * objfiles.h (struct objfile): Update comment.
10224         (ALL_OBJFILES): Remove.
10225         (ALL_FILETABS): Remove.
10226         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10227         objfile_compunits.
10228
10229 2019-01-09  Tom Tromey  <tom@tromey.com>
10230
10231         * symmisc.c (print_objfile_statistics, dump_objfile)
10232         (maintenance_print_symbols): Use compunit_filetabs.
10233         * source.c (forget_cached_source_info_for_objfile): Use
10234         compunit_filetabs.
10235         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10236         (ALL_FILETABS): Use compunit_filetabs.
10237         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10238         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10239
10240 2019-01-09  Tom Tromey  <tom@tromey.com>
10241
10242         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10243         (compunit_filetabs): New.
10244         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10245         compunit_filetabs.
10246         (info_sources_command, make_source_files_completion_list): Remove
10247         declaration.
10248         * symmisc.c (print_objfile_statistics, dump_objfile)
10249         (maintenance_print_symbols): Remove declaration.
10250         (maintenance_info_symtabs): Use compunit_filetabs.
10251         (maintenance_info_line_tables): Likewise.
10252         * source.c (select_source_symtab): Change local variable name.
10253         (forget_cached_source_info_for_objfile): Remove declaration.
10254         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10255         * objfiles.c (objfile_relocate1): Remove declaration.
10256         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10257         declaration.
10258         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10259         * coffread.c (coff_symtab_read): Remove declaration.
10260         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10261         compunit_filetabs.
10262
10263 2019-01-09  Tom Tromey  <tom@tromey.com>
10264
10265         * symtab.c (lookup_objfile_from_block)
10266         (find_pc_sect_compunit_symtab, search_symbols)
10267         (default_collect_symbol_completion_matches_break_on): Use
10268         objfile_compunits.
10269         * objfiles.h (ALL_COMPUNITS): Remove.
10270         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10271         * cp-support.c (add_symbol_overload_list_qualified): Use
10272         objfile_compunits.
10273         * ada-lang.c (ada_collect_symbol_completion_matches)
10274         (ada_add_global_exceptions): Use objfile_compunits.
10275
10276 2019-01-09  Tom Tromey  <tom@tromey.com>
10277
10278         * source.c (select_source_symtab)
10279         (forget_cached_source_info_for_objfile): Remove declaration.
10280         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10281         declaration.
10282         * maint.c (count_symtabs_and_blocks): Remove declaration.
10283         * cp-support.c (add_symbol_overload_list_qualified): Remove
10284         declaration.
10285         * coffread.c (coff_symtab_read): Remove declaration.
10286         * symtab.c (lookup_symbol_in_objfile_symtabs)
10287         (basic_lookup_transparent_type_1): Use objfile_compunits.
10288         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10289         (info_sources_command, search_symbols)
10290         (default_collect_symbol_completion_matches_break_on)
10291         (make_source_files_completion_list): Remove declaration.
10292         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10293         (ada_collect_symbol_completion_matches)
10294         (ada_add_global_exceptions): Remove declaration.
10295         * linespec.c (iterate_over_all_matching_symtabs): Use
10296         objfile_compunits.
10297         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10298         (class objfile_compunits): New.
10299         (ALL_COMPUNITS): Use objfile_compunits.
10300         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10301         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10302         objfile_compunits.
10303         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10304
10305 2019-01-09  Tom Tromey  <tom@tromey.com>
10306
10307         * symtab.c (search_symbols)
10308         (default_collect_symbol_completion_matches_break_on): Use
10309         objfile_msymbols.
10310         * ada-lang.c (ada_lookup_simple_minsym)
10311         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10312         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10313         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10314         objfile_msymbols.
10315         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10316         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10317         * objc-lang.c (find_methods): Use objfile_msymbols.
10318         (info_selectors_command, info_classes_command): Likewise.
10319         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10320         * objfiles.h (class objfile_msymbols): New.
10321         (ALL_OBJFILE_MSYMBOLS): Remove.
10322         (ALL_MSYMBOLS): Remove.
10323
10324 2019-01-09  Tom Tromey  <tom@tromey.com>
10325
10326         * common/next-iterator.h (next_adapter): Add Iterator template
10327         parameter.
10328         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10329         (class all_objfiles_safe): New.
10330         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10331         * objfiles.c (put_objfile_before): Update comment.
10332         (add_separate_debug_objfile): Likewise.
10333         (free_all_objfiles): Use all_objfiles_safe.
10334         (objfile_purge_solibs): Likewise.
10335
10336 2019-01-09  Tom Tromey  <tom@tromey.com>
10337
10338         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10339         (expand_symtab_containing_pc, lookup_static_symbol)
10340         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10341         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10342         all_objfiles.
10343         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10344         * breakpoint.c (create_overlay_event_breakpoint)
10345         (create_longjmp_master_breakpoint)
10346         (create_std_terminate_master_breakpoint)
10347         (create_exception_master_breakpoint): Use all_objfiles.
10348         * linux-thread-db.c (try_thread_db_load_from_pdir)
10349         (has_libpthread): Use all_objfiles.
10350         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10351         * linespec.c (iterate_over_all_matching_symtabs)
10352         (search_minsyms_for_name): Use all_objfiles.
10353         * maint.c (maintenance_info_sections): Use all_objfiles.
10354         * main.c (captured_main_1): Use all_objfiles.
10355         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10356         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10357         * guile/scm-pretty-print.c
10358         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10359         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10360         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10361         (maintenance_print_msymbols): Use all_objfiles.
10362         * source.c (select_source_symtab): Use all_objfiles.
10363         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10364         * symfile.c (remove_symbol_file_command)
10365         (expand_symtabs_matching, map_symbol_filenames): Use
10366         all_objfiles.
10367         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10368         all_objfiles.
10369         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10370         * objc-lang.c (find_methods): Use all_objfiles.
10371         * objfiles.c (have_partial_symbols, have_full_symbols)
10372         (have_minimal_symbols, qsort_cmp)
10373         (default_iterate_over_objfiles_in_search_order): Use
10374         all_objfiles.
10375         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10376         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10377         (maintenance_check_psymtabs): Use all_objfiles.
10378         (ALL_PSYMTABS): Remove.
10379         * compile/compile-object-run.c (do_module_cleanup): Use
10380         all_objfiles.
10381         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10382         * cp-support.c (add_symbol_overload_list_qualified): Use
10383         all_objfiles.
10384         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10385         Use all_objfiles.
10386         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10387         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10388         all_objfiles.
10389         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10390         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10391         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10392         Uses all_objfiles.
10393         * solib.c (solib_read_symbols): Use all_objfiles
10394
10395 2019-01-09  Tom Tromey  <tom@tromey.com>
10396
10397         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10398         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10399         all_objfiles.
10400         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10401         * symmisc.c (print_symbol_bcache_statistics)
10402         (print_objfile_statistics, maintenance_print_objfiles)
10403         (maintenance_info_symtabs, maintenance_check_symtabs)
10404         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10405         all_objfiles.
10406         * source.c (forget_cached_source_info): Use all_objfiles.
10407         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10408         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10409         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10410         * objfiles.c (update_section_map): Use all_objfiles.
10411         (shared_objfile_contains_address_p): Likewise.
10412         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10413         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10414
10415 2019-01-09  Tom Tromey  <tom@tromey.com>
10416
10417         * common/next-iterator.h: New file.
10418         * objfiles.h (class all_objfiles): New.
10419         (struct objfile_iterator): New.
10420
10421 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10422
10423         * NEWS: Move the description of the changed "frame", "select-frame",
10424          and "info frame" commands to the Changed commands section.
10425
10426 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10427
10428         * gdbtypes.c (check_stub_method_group): Remove handling of old
10429         mangling schemes.
10430         * linespec.c (find_methods): Likewise.
10431         * stabsread.c (read_member_functions): Likewise.
10432         * valops.c (search_struct_method): Likewise.
10433         (value_struct_elt_for_reference): Likewise.
10434         * NEWS: Mention this change.
10435
10436 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10437
10438         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10439         print_source_lines.
10440         * source.c (print_source_lines_base): Update line number check.
10441         (print_source_lines): New function.
10442         (source_lines_range::source_lines_range): New function.
10443         * source.h (class source_lines_range): New class.
10444         (print_source_lines): New declaration.
10445
10446 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10447
10448         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10449
10450 2019-01-08  Tom Tromey  <tom@tromey.com>
10451             Simon Marchi  <simon.marchi@ericsson.com>
10452
10453         PR gdb/24060
10454         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10455         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10456         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10457         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10458         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10459         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10460
10461 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10462
10463         * source.c (select_source_symtab): Move header comment to
10464         declaration in source.h.
10465         (forget_cached_source_info_for_objfile): Likewise.
10466         (forget_cached_source_info): Likewise.
10467         (identify_source_line): Likewise.
10468         * source.h (identify_source_line): Move declaration from symtab.h
10469         and add comment from source.c
10470         (print_source_lines): Likewise.
10471         (forget_cached_source_info_for_objfile): Likewise.
10472         (forget_cached_source_info): Likewise.
10473         (select_source_symtab): Likewise.
10474         (enum print_source_lines_flag): Move definition from symtab.h.
10475         * symtab.h (identify_source_line): Move declaration to source.h.
10476         (print_source_lines): Likewise.
10477         (forget_cached_source_info_for_objfile): Likewise.
10478         (forget_cached_source_info): Likewise.
10479         (select_source_symtab): Likewise.
10480         (enum print_source_lines_flag): Move definition to source.h.
10481         * tui/tui-hooks.c: Add 'source.h' include.
10482
10483 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10484
10485         * source.c (print_source_lines_base): Handle requests to print
10486         reverse line number sequences, and guard against empty lines
10487         string.
10488
10489 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10490
10491         * source.c (print_source_lines_base): Fix skip of '\r' if next
10492         character is '\n'.
10493
10494 2019-01-06  Tom Tromey  <tom@tromey.com>
10495
10496         * c-exp.y (struct c_parse_state) <macro_original_text,
10497         expansion_obstack>: New member.
10498         (macro_original_text, expansion_obstack): Remove globals.
10499         (scan_macro_expansion, scanning_macro_expansion)
10500         (finished_macro_expansion): Update.
10501         (scan_macro_cleanup): Remove.
10502         (yylex, c_parse): Update.
10503
10504 2019-01-06  Tom Tromey  <tom@tromey.com>
10505
10506         * c-exp.y (struct c_parse_state) <strings>: New member.
10507         (operator_stoken): Update.
10508
10509 2019-01-06  Tom Tromey  <tom@tromey.com>
10510
10511         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10512         (union type_stack_elt) <typelist_val>: Now a pointer to
10513         std::vector.
10514         (type_stack_cleanup): Don't declare.
10515         (push_typelist): Update.
10516         * parse.c (pop_typelist): Return a std::vector.
10517         (push_typelist): Take a std::vector.
10518         (follow_types): Update.  Do not free args.
10519         (type_stack_cleanup): Remove.
10520         * c-exp.y (struct c_parse_state): New.
10521         (cpstate): New global.
10522         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10523         (nonempty_typelist): Update.
10524         (func_mod): Create a new vector.
10525         (c_parse): Create a c_parse_state.
10526         (check_parameter_typelist): Do not delete params.
10527         (function_method): Update.  Do not delete type_list.
10528
10529 2019-01-06  Tom Tromey  <tom@tromey.com>
10530
10531         PR gdb/28155:
10532         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10533         check_typedef.
10534         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10535         (print_return_value): Likewise.
10536
10537 2019-01-05  Tom Tromey  <tom@tromey.com>
10538
10539         * contrib/cleanup_check.py: Remove.
10540         * contrib/gcc-with-excheck: Remove.
10541         * contrib/exsummary.py: Remove.
10542         * contrib/excheck.py: Remove.
10543
10544 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10545
10546         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10547         NULL. Initialize tpprev to NULL instead of assigning it
10548         to NULL on the next statement.
10549         * windows-nat.c (windows_delete_thread): Remove check for
10550         main_thread_id before printing thread exit notifications.
10551         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10552         Remove thread ID check against main_thread_id.
10553         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10554         windows_delete_thread.
10555         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10556
10557 2019-01-04  Tom Tromey  <tom@tromey.com>
10558
10559         * compile/compile.c (_initialize_compile): Use upper case for
10560         metasyntactic variables.
10561         * symmisc.c (_initialize_symmisc): Use upper case for
10562         metasyntactic variables.
10563         * psymtab.c (_initialize_psymtab): Use upper case for
10564         metasyntactic variables.
10565         * demangle.c (demangle_command): Use upper case for metasyntactic
10566         variables.
10567         (_initialize_demangler): Likewise.
10568         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10569         variables.
10570
10571 2019-01-03  Tom Tromey  <tom@tromey.com>
10572
10573         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10574
10575 2019-01-03  Tom Tromey  <tom@tromey.com>
10576
10577         * python/py-symtab.c (salpy_str): Update.
10578         (struct salpy_sal_object) <symtab>: Now a PyObject.
10579         (salpy_dealloc): Update.
10580         (del_objfile_sal): Use gdbpy_ref.
10581
10582 2019-01-03  Tom Tromey  <tom@tromey.com>
10583
10584         * python/py-type.c (convert_field): Use new_reference.  Return
10585         gdbpy_ref.
10586         (make_fielditem): Return gdbpy_ref.
10587         (typy_fields): Update.
10588         (typy_getitem): Update.
10589         (field_name): Return gdbpy_ref.  Use new_reference.
10590         (typy_iterator_iternext): Update.
10591
10592 2019-01-03  Tom Tromey  <tom@tromey.com>
10593
10594         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10595
10596 2019-01-03  Tom Tromey  <tom@tromey.com>
10597
10598         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10599         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10600         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10601         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10602         (pspy_set_type_printers): Likewise.
10603         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10604         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10605         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10606         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10607         (objfpy_set_type_printers): Likewise.
10608
10609 2019-01-03  Tom Tromey  <tom@tromey.com>
10610
10611         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10612         (gdbpy_print_stack): Use gdbpy_err_fetch.
10613         * python/python-internal.h (class gdbpy_err_fetch): New class.
10614         (class gdbpy_enter) <m_error_type, m_error_value,
10615         m_error_traceback>: Remove.
10616         <m_error>: New member.
10617         (gdbpy_exception_to_string): Don't declare.
10618         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10619         * python/py-value.c (convert_value_from_python): Use
10620         gdbpy_err_fetch.
10621         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10622         gdbpy_exception_to_string.
10623         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10624         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10625         gdbpy_err_fetch.
10626
10627 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10628
10629         * linux-nat.c (delete_lwp_cleanup): Delete.
10630         (struct lwp_deleter): New struct.
10631         (lwp_info_up): New typedef.
10632         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10633         lwp_info_up.
10634
10635 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10636
10637         * linux-fork.c (class scoped_switch_fork_info): New class.
10638         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10639
10640 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10641
10642         * valops.c (find_overload_match): Remove use of null_cleanup, and
10643         calls to do_cleanups.
10644
10645 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10646
10647         * compile/compile-cplus-types.c
10648         (compile_cplus_instance::decl_name): Handle changes to
10649         cp_func_name.
10650         * cp-support.c (cp_func_name): Update header comment, update
10651         return type.
10652         * cp-support.h (cp_func_name): Update return type in declaration.
10653         * valops.c (find_overload_match): Move temp_func local to top
10654         level of function and change its type.  Use temp_func to hold and
10655         delete temporary string obtained from cp_func_name.
10656
10657 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10658
10659         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10660         gdb::char_vector, remove cleanup, and update uses of `msg`.
10661
10662 2019-01-03  Jim Wilson  <jimw@sifive.com>
10663
10664         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10665
10666 2019-01-02  Tom Tromey  <tom@tromey.com>
10667
10668         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10669         (tdesc_parse_xml): Remove cleanups.
10670         * target-descriptions.h (make_cleanup_free_target_description):
10671         Don't declare.
10672         (target_desc_deleter): New struct.
10673         (target_desc_up): New typedef.
10674         * target-descriptions.c (target_desc_deleter::operator()): Rename
10675         from free_target_description.
10676         (make_cleanup_free_target_description): Remove.
10677
10678 2019-01-02  Tom Tromey  <tom@tromey.com>
10679
10680         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10681         constructor, destructor.
10682         (linespec_parser): Remove typedef.
10683         (~linespec_parser): Rename from linespec_parser_delete.
10684         (linespec_lex_to_end, linespec_complete_label)
10685         (linespec_complete): Update.
10686         (decode_line_full): Remove cleanups.
10687         (decode_line_1): Update.
10688
10689 2019-01-02  Tom Tromey  <tom@tromey.com>
10690
10691         * python/python-internal.h (inferior_to_inferior_object): Change
10692         return type.
10693         * python/py-exitedevent.c (create_exited_event_object): Update.
10694         * python/py-inferior.c (inferior_to_inferior_object): Return
10695         gdbpy_ref.
10696         (python_new_inferior, python_inferior_deleted)
10697         (thread_to_thread_object, delete_thread_object)
10698         (build_inferior_list, gdbpy_selected_inferior): Update.
10699         * python/py-infthread.c (create_thread_object): Update.  Also fail
10700         if inferior_to_inferior_object fails.
10701
10702 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10703
10704         * inferior.h (class inferior) <displaced_step_state>: New field.
10705         * infrun.h (struct displaced_step_state): Move here from
10706         infrun.c.  Initialize fields, add constructor.
10707         <inf>: Remove field.
10708         <reset>: New method.
10709         * infrun.c (struct displaced_step_inferior_state): Move to
10710         infrun.h.
10711         (displaced_step_inferior_states): Remove.
10712         (get_displaced_stepping_state): Adust.
10713         (displaced_step_in_progress_any_inferior): Adjust.
10714         (displaced_step_in_progress_thread): Adjust.
10715         (displaced_step_in_progress): Adjust.
10716         (add_displaced_stepping_state): Remove.
10717         (get_displaced_step_closure_by_addr): Adjust.
10718         (remove_displaced_stepping_state): Remove.
10719         (infrun_inferior_exit): Call displaced_step_state.reset.
10720         (use_displaced_stepping): Don't check for NULL.
10721         (displaced_step_prepare_throw): Call
10722         get_displaced_stepping_state.
10723         (displaced_step_fixup): Don't check for NULL.
10724         (prepare_for_detach): Don't check for NULL.
10725
10726 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10727
10728         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10729          in case of call that did not complete.
10730
10731 2019-01-02  Andrey Utkin  <autkin@undo.io>
10732
10733         * symfile.c (find_separate_debug_file): Fix search of debug files for
10734         remote debuggee.
10735
10736 2019-01-02  Tom Tromey  <tom@tromey.com>
10737
10738         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10739         indentation.
10740         * python/py-frame.c (frapy_older): Remove cast.
10741         (frapy_newer): Likewise.
10742         * python/py-breakpoint.c (local_setattro): Remove cast.
10743         * python/py-arch.c (archpy_name): Remove local variable.
10744         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10745
10746 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10747
10748         * unittests/basic_string_view/element_access/char/empty.cc:
10749         Fix year range in copyright header.
10750
10751 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10752
10753         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10754         Delete.
10755         <operator==>: Update with for removed field.
10756         <hash>: Likewise.
10757         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10758         <isa_features>: ...this.
10759         <abi_features>: New field.
10760         (riscv_isa_flen): Update comment.
10761         (riscv_abi_xlen): New declaration.
10762         (riscv_abi_flen): New declaration.
10763         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10764         isa_features.
10765         (riscv_abi_xlen): New function.
10766         (riscv_isa_flen): Update to get answer from isa_features.
10767         (riscv_abi_flen): New function.
10768         (riscv_has_fp_abi): Update to get answer from abi_features.
10769         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10770         xlen and flen.
10771         (riscv_call_info) <xlen, flen>: Update comment.
10772         (riscv_call_arg_struct): Remove invalid assertions
10773         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10774         is removed.
10775         (riscv_gdbarch_init): Gather isa features and abi features
10776         separately, ensure both match on the gdbarch when reusing an old
10777         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10778         a target with 64-bit float hardware.
10779
10780 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10781
10782         * source.c (search_command_helper): Stop reverse search
10783         when line 1 has been searched.
10784
10785 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10786
10787         * record-full.c (record_full_base_target::close): Rewrite
10788         record_full_core_buf_list free logic.
10789
10790 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10791
10792         * break-catch-syscall.c (print_one_catch_syscall): xfree
10793         the last text.
10794
10795 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10796
10797         * top.c (print_gdb_version): Update Copyright year in version
10798         message.
10799
10800 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10801
10802         Update copyright year range in all GDB files.
10803
10804 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10805
10806         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10807
10808 For older changes see ChangeLog-2018.
10809 \f
10810 Local Variables:
10811 mode: change-log
10812 left-margin: 8
10813 fill-column: 74
10814 version-control: never
10815 coding: utf-8
10816 End:
10817