Remove "noisy" parameter from clear_complaints
[external/binutils.git] / gdb / ChangeLog
1 2018-05-23  Tom Tromey  <tom@tromey.com>
2
3         * complaints.c (clear_complaints): Remove "noisy" parameter.
4         * complaints.h (clear_complaints): Update.
5         * symfile.c (syms_from_objfile_1, finish_new_objfile)
6         (reread_symbols): Update.
7
8 2018-05-23  Tom Tromey  <tom@tromey.com>
9
10         * complaints.c (enum complaint_series): Remove FIRST_MESSAGE,
11         SUBSEQUENT_MESSAGE.
12         (vcomplaint, clear_complaints): Update.
13         (symfile_explanations): Remove some messages.
14
15 2018-05-23  Tom Tromey  <tom@tromey.com>
16
17         * complaints.c (internal_complaint): Remove.
18         * complaints.h (internal_complaint): Remove.
19
20 2018-05-22  Maciej W. Rozycki  <macro@mips.com>
21
22         * i387-tdep.c (i387_collect_xsave): Make `i' unsigned.
23
24 2018-05-22  Pedro Alves  <palves@redhat.com>
25
26         * remote-fileio.c (remote_fileio_reply, remote_fileio_ioerror)
27         (remote_fileio_badfd, remote_fileio_return_errno)
28         (remote_fileio_return_success, remote_fileio_func_open)
29         (remote_fileio_func_open, remote_fileio_func_close)
30         (remote_fileio_func_read, remote_fileio_func_write)
31         (remote_fileio_func_lseek, remote_fileio_func_rename)
32         (remote_fileio_func_unlink, remote_fileio_func_stat)
33         (remote_fileio_func_fstat, remote_fileio_func_gettimeofday)
34         (remote_fileio_func_isatty, remote_fileio_func_system): Add
35         remote_target parameter.
36         (remote_fio_func_map) <func>: Add remote_target parameter.
37         (do_remote_fileio_request, remote_fileio_request):
38         * remote-fileio.h (remote_fileio_request):
39         * remote-notif.c (remote_notif_ack, remote_notif_parse, ): Add
40         remote_target parameter.
41         (remote_notif_process, handle_notification): Adjust to pass down
42         the remote.
43         (remote_notif_state_allocate): Add remote_target parameter.  Save
44         it.
45         * remote-notif.h (struct remote_target): Forward declare.
46         (struct notif_client) <parse, ack, can_get_pending_events>: Add
47         remote_target parameter.
48         (struct remote_notif_state) <remote>: New field.
49         (remote_notif_ack, remote_notif_parse): Add remote_target
50         parameter.
51         (remote_notif_state_allocate, remote_notif_state_allocate): Add
52         remote_target parameter.
53         * remote.c (OPAQUETHREADBYTES, threadref, gdb_ext_thread_info)
54         (threads_listing_context, rmt_thread_action, protocol_feature)
55         (packet_reg, stop_reply, stop_reply_p, enum packet_support)
56         (packet_result, struct threads_listing_context, remote_state):
57         Move definitions and declarations higher up.
58         (remote_target) <~remote_target>: Declare.
59         (remote_download_command_source, remote_file_put, remote_file_get)
60         (remote_file_delete, remote_hostio_pread, remote_hostio_pwrite)
61         (remote_hostio_pread_vFile, remote_hostio_send_command)
62         (remote_hostio_set_filesystem, remote_hostio_open)
63         (remote_hostio_close, remote_hostio_unlink, remote_state)
64         (get_remote_state, get_remote_packet_size, get_memory_packet_size)
65         (get_memory_write_packet_size, get_memory_read_packet_size)
66         (append_pending_thread_resumptions, remote_detach_1)
67         (append_resumption, remote_resume_with_vcont)
68         (add_current_inferior_and_thread, wait_ns, wait_as)
69         (process_stop_reply, remote_notice_new_inferior)
70         (process_initial_stop_replies, remote_add_thread)
71         (btrace_sync_conf, remote_btrace_maybe_reopen)
72         (remove_new_fork_children, kill_new_fork_children)
73         (discard_pending_stop_replies, stop_reply_queue_length)
74         (check_pending_events_prevent_wildcard_vcont)
75         (discard_pending_stop_replies_in_queue, stop_reply)
76         (remote_notif_remove_queued_reply, stop_reply *queued_stop_reply)
77         (peek_stop_reply, remote_parse_stop_reply, remote_stop_ns)
78         (remote_interrupt_as, remote_interrupt_ns)
79         (remote_get_noisy_reply, remote_query_attached)
80         (remote_add_inferior, remote_current_thread, get_current_thread)
81         (set_thread, set_general_thread, set_continue_thread)
82         (set_general_process, write_ptid)
83         (remote_unpack_thread_info_response, remote_get_threadinfo)
84         (parse_threadlist_response, remote_get_threadlist)
85         (remote_threadlist_iterator, remote_get_threads_with_ql)
86         (remote_get_threads_with_qxfer)
87         (remote_get_threads_with_qthreadinfo, extended_remote_restart)
88         (get_offsets, remote_check_symbols, remote_supported_packet)
89         (remote_query_supported, remote_packet_size)
90         (remote_serial_quit_handler, remote_detach_pid)
91         (remote_vcont_probe, remote_resume_with_hc)
92         (send_interrupt_sequence, interrupt_query)
93         (remote_notif_get_pending_events, fetch_register_using_p)
94         (send_g_packet, process_g_packet, fetch_registers_using_g)
95         (store_register_using_P, store_registers_using_G)
96         (set_remote_traceframe, check_binary_download)
97         (remote_write_bytes_aux, remote_write_bytes, remote_read_bytes_1)
98         (remote_xfer_live_readonly_partial, remote_read_bytes)
99         (remote_send_printf, remote_flash_write, readchar)
100         (remote_serial_write, putpkt, putpkt_binary, skip_frame)
101         (read_frame, getpkt, getpkt_or_notif_sane_1, getpkt_sane)
102         (getpkt_or_notif_sane, remote_vkill, remote_kill_k)
103         (extended_remote_disable_randomization, extended_remote_run)
104         (send_environment_packet, extended_remote_environment_support)
105         (extended_remote_set_inferior_cwd, remote_write_qxfer)
106         (remote_read_qxfer, push_stop_reply, vcont_r_supported)
107         (packet_command): Now methods of ...
108         (remote_target): ... this class.
109         (m_remote_state) <remote_target>: New field.
110         (struct remote_state) <stop_reply_queue,
111         remote_async_inferior_event_token, wait_forever_enabled_p>: New
112         fields.
113         (remote_state::remote_state): Allocate stop_reply_queue.
114         (remote_state): Delete global.
115         (get_remote_state_raw): Delete.
116         (remote_target::get_remote_state): Allocate m_remote_state on
117         demand.
118         (get_current_remote_target): New.
119         (remote_ops, extended_remote_ops): Delete.
120         (wait_forever_enabled_p, remote_async_inferior_event_token):
121         Delete, moved to struct remote_state.
122         (remote_target::close): Delete self.  Destruction bits split to
123         ...
124         (remote_target::~remote_target): ... this.
125         (show_memory_packet_size): Adjust to use
126         get_current_remote_target.
127         (struct protocol_feature) <func>: Add remote_target parameter.
128         All callers adjusted.
129         (curr_quit_handler_target): New.
130         (remote_serial_quit_handler): Reimplement.
131         (remote_target::open_1): Adjust to use get_current_remote_target.
132         Heap-allocate remote_target/extended_remote_target instances.
133         (vcont_builder::vcont_builder): Add remote_target parameter, and
134         save it in m_remote.  All callers adjusted.
135         (vcont_builder::m_remote): New field.
136         (vcont_builder::restart, vcont_builder::flush)
137         (vcont_builder::push_action): Use it.
138         (remote_target::commit_resume): Use it.
139         (struct queue_iter_param) <remote>: New field.
140         (remote_target::remove_new_fork_children): Fill in 'remote' field.
141         (check_pending_event_prevents_wildcard_vcont_callback_data): New.
142         (check_pending_event_prevents_wildcard_vcont_callback)
143         (remote_target::check_pending_events_prevent_wildcard_vcont)
144         (remote_target::discard_pending_stop_replies)
145         (remote_target::discard_pending_stop_replies_in_queue)
146         (remote_target::remote_notif_remove_queued_reply): Fill in
147         'remote' field.
148         (remote_notif_get_pending_events): New.
149         (remote_target::readchar, remote_target::remote_serial_write):
150         Save/restore curr_quit_handler_target.
151         (putpkt): New.
152         (kill_new_fork_children): Fill in 'remote' field.
153         (packet_command): Use get_current_remote_target, defer to
154         remote_target method of same name.
155         (scoped_remote_fd::scoped_remote_fd): Add 'remote_target'
156         parameter, and save it in m_remote.  All callers adjusted.
157         (scoped_remote_fd::release): Use m_remote.
158         (scoped_remote_fd::m_remote): New field.
159         (remote_file_put, remote_file_get, remote_file_delete): Use
160         get_current_remote_target, defer to remote_target method of same
161         name.
162         (remote_btrace_reset): Add remote_state paremeter.  Update all
163         callers.
164         (remote_async_inferior_event_handler). Pass down 'data'.
165         (remote_new_objfile): Use get_current_remote_target.
166         (remote_target::vcont_r_supported): New.
167         (set_range_stepping): Use get_current_remote_target and
168         remote_target::vcont_r_supported.
169         (_initialize_remote): Don't allocate 'remote_state' and
170         'stop_reply_queue' globals.
171         * remote.h (struct remote_target): Forward declare.
172         (getpkt, putpkt, remote_notif_get_pending_events): Add
173         'remote_target' parameter.
174
175 2018-05-22  Pedro Alves  <palves@redhat.com>
176
177         * remote.c (vcont_builder): Now a class.  Make all data members
178         private.
179         (vcont_builder) <vcont_builder, restart, flush, push_action>:
180         Declare methods.
181         (vcont_builder_restart): Rename to ...
182         (vcont_builder::restart): ... this.
183         (vcont_builder_flush): Rename to ...
184         (vcont_builder::flush): ... this.
185         (vcont_builder_push_action): Rename to ...
186         (vcont_builder::push_action): ... this.
187         (remote_target::commit_resume): Adjust.
188
189 2018-05-22  Pedro Alves  <palves@redhat.com>
190
191         * remote.c (DEFAULT_MAX_MEMORY_PACKET_SIZE): Rename to ...
192         (DEFAULT_MAX_MEMORY_PACKET_SIZE_FIXED): ... this.
193         (get_fixed_memory_packet_size): New.
194         (get_memory_packet_size): Use it.
195         (set_memory_packet_size): Don't override the config size with
196         DEFAULT_MAX_MEMORY_PACKET_SIZE.
197         (show_memory_packet_size): Use get_fixed_memory_packet_size.
198         Don't refer to get_memory_packet_size if not connected to a remote
199         target.  Show "(default)" if configured size is 0.
200
201 2018-05-22  Pedro Alves  <palves@redhat.com>
202
203         * remote.c (remote_target::mourn_inferior): Move
204         discard_pending_stop_replies call here from ...
205         (_initialize_remote): ... here.
206
207 2018-05-22  Pedro Alves  <palves@redhat.com>
208
209         * remote.c (compare_section_command): Remove set_general_process
210         call.
211
212 2018-05-22  Pedro Alves  <palves@redhat.com>
213
214         * remote.c (struct packet_reg, struct remote_arch_state):
215         Move higher up in the file.
216         (remote_state) <m_arch_states>: Store remote_arch_state values
217         instead of remote_arch_state pointers.
218         (remote_state::get_remote_arch_state): Adjust.
219
220 2018-05-22  Pedro Alves  <palves@redhat.com>
221
222         * remote.c: Include <unordered_map>.
223         (remote_state): Now a class.
224         (remote_state) <get_remote_arch_state>: Declare method.
225         <get_remote_arch_state>: New field.
226         (remote_arch_state) <remote_arch_state>: Declare ctor.
227         <regs>: Now a unique_ptr.
228         (remote_gdbarch_data_handle): Delete.
229         (get_remote_arch_state): Delete.
230         (remote_state::get_remote_arch_state): New.
231         (get_remote_state): Adjust to call remote_state's
232         get_remote_arch_state method.
233         (init_remote_state): Delete, bits factored out to ...
234         (remote_arch_state::remote_arch_state): ... this new method.
235         (get_remote_packet_size, get_memory_packet_size)
236         (process_g_packet, remote_target::fetch_registers)
237         (remote_target::prepare_to_store, store_registers_using_G)
238         (remote_target::store_registers, remote_target::get_trace_status):
239         Adjust to call remote_state's method.
240         (_initialize_remote): Remove reference to
241         remote_gdbarch_data_handle.
242
243 2018-05-22  Pedro Alves  <palves@redhat.com>
244
245         * remote.c (struct readahead_cache) <invalidate, invalidate_fd,
246         pread>: New method declarations.
247         (remote_target::open_1): Adjust.
248         (readahead_cache_invalidate): Rename to ...
249         (readahead_cache::invalidate): ... this, and adjust to be a class
250         method.
251         (readahead_cache_invalidate_fd): Rename to ...
252         (readahead_cache::invalidate_fd): ... this, and adjust to be a
253         class method.
254         (remote_hostio_pwrite): Adjust.
255         (remote_hostio_pread_from_cache): Rename to ...
256         (readahead_cache::pread): ... this, and adjust to be a class
257         method.
258         (remote_hostio_close): Adjust.
259
260 2018-05-22  Pedro Alves  <palves@redhat.com>
261
262         * remote.c (remote_hostio_close_cleanup): Delete.
263         (class scoped_remote_fd): New.
264         (remote_file_put, remote_file_get): Use it.
265
266 2018-05-22  Pedro Alves  <palves@redhat.com>
267
268         (struct vCont_action_support): Use bool and initialize all fields.
269         (struct readahead_cache): Initialize all fields.
270         (remote_state): Use bool and initialize all fields.
271         (remote_state::remote_state, remote_state::~remote_state): New.
272         (new_remote_state): Delete.
273         (_initialize_remote): Use new to allocate remote_state.
274
275 2018-05-22  Pedro Alves  <palves@redhat.com>
276             張俊芝  <zjz@zjz.name>
277
278         PR gdb/22973
279         * c-exp.y: Include "c-support.h".
280         (parse_number, c_parse_escape, lex_one_token): Use TOLOWER instead
281         of tolower.  Use c_ident_is_alpha to scan names.
282         * c-lang.c: Include "c-support.h".
283         (convert_ucn, convert_octal, convert_hex, convert_escape): Use
284         ISXDIGIT instead of isxdigit and ISDIGIT instead of isdigit.
285         * c-support.h: New file, with bits factored out from ...
286         * cp-name-parser.y: ... this file.
287         Include "c-support.h".
288         (cp_ident_is_alpha, cp_ident_is_alnum): Deleted, moved to
289         c-support.h and renamed.
290         (symbol_end, yylex): Adjust.
291
292 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
293
294         * arch/ppc-linux-common.c (ppc_linux_has_isa205): Change the
295         parameter type to CORE_ADDR.
296         * arch/ppc-linux-common.h (ppc_linux_has_isa205): Change the
297         parameter type in declaration to CORE_ADDR.
298         * ppc-linux-tdep.c (ppc_linux_core_read_description): Call
299         target_auxv_search to get AT_HWCAP and use the result to get the
300         target description.
301         * ppc-linux-nat.c (ppc_linux_get_hwcap): Change the return type
302         to CORE_ADDR. Remove the cast of the return value to unsigned
303         long. Fix error predicate of target_auxv_search.
304         (ppc_linux_nat_target::read_description): Change the type of the
305         hwcap variable to CORE_ADDR.
306
307 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
308
309         * rs6000-tdep.c (rs6000_gdbarch_init): Assign 1 to have_dfp only
310         if the size of fpscr is larger than 32 bits.
311
312 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
313
314         * ppc-linux-tdep.c (ppc_linux_vsxregset): New function.
315         (ppc32_linux_vsxregmap): New global.
316         (ppc32_linux_vsxregset): Initialize with ppc32_linux_vsxregmap,
317         regcache_supply_regset, and regcache_collect_regset.
318         * ppc-linux-tdep.h (ppc_linux_vsxregset): Declare.
319         * ppc-linux-nat.c (supply_vsxregset, fill_vsxregset): Remove.
320         (fetch_vsx_register, store_vsx_register): Remove.
321         (fetch_vsx_registers): Add regno parameter. Get regset using
322         ppc_linux_vsxregset. Use regset to supply registers.
323         (store_vsx_registers): Add regno parameter. Get regset using
324         ppc_linux_vsxregset. Use regset to collect registers.
325         (fetch_register): Call fetch_vsx_registers instead of
326         fetch_vsx_register.
327         (store_register): Call store_vsx_registers instead of
328         store_vsx_register.
329         (fetch_ppc_registers): Call fetch_vsx_registers with -1 for the
330         new regno parameter.
331         (store_ppc_registers): Call store_vsx_registers with -1 for the
332         new regno parameter.
333         * rs6000-tdep.c (ppc_vsx_support_p, ppc_supply_vsxreget)
334         (ppc_collect_vsxregset): Remove.
335
336 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
337
338         * ppc-tdep.h (struct ppc_reg_offsets): Remove vector register
339         offset fields.
340         * ppc-fbsd-tdep.c (ppc32_fbsd_reg_offsets): Remove initializers
341         for vector register offset fields.
342         (ppc64_fbsd_reg_offsets): Likewise.
343         * ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Remove assignment
344         to vector register offset fields.
345         * ppc-obsd-tdep.c (_initialize_ppcnbsd_tdep): Remove assignment
346         to vector register offset fields.
347         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Remove assignment to
348         vector register offset fields.
349         * rs6000-aix-tdep.c (rs6000_aix32_reg_offsets): Remove
350         initializers for vector register offset fields.
351         (rs6000_aix64_reg_offsets): Likewise.
352         * rs6000-tdep.c (ppc_vrreg_offset): Remove.
353         (ppc_supply_vrregset): Remove.
354         (ppc_collect_vrregset): Remove.
355         * ppc-linux-tdep.c (ppc_linux_collect_vrregset): New function.
356         (ppc_linux_vrregset) : New function.
357         (ppc32_le_linux_vrregmap, ppc32_be_linux_vrregmap)
358         (ppc32_le_linux_vrregset, ppc32_be_linux_vrregset): New globals.
359         (ppc32_linux_vrregset): Remove.
360         (ppc_linux_iterate_over_regset_sections): Call ppc_linux_vrregset
361         and use result instead of ppc32_linux_vrregset.
362         (ppc32_linux_reg_offsets): Remove initializers for vector register
363         offset fields.
364         (ppc64_linux_reg_offsets): Likewise.
365         * ppc-linux-tdep.h (ppc_linux_vrregset): New declaration.
366         * ppc-linux-nat.c: Include regset.h.
367         (gdb_vrregset_t): Adjust comment to account for little-endian
368         mode.
369         (supply_vrregset, fill_vrregset): Remove.
370         (fetch_altivec_register, store_altivec_register): Remove.
371         (fetch_altivec_registers): Add regno parameter. Get regset using
372         ppc_linux_vrregset. Use regset to supply registers.
373         (store_altivec_registers): Add regno parameter. Get regset using
374         ppc_linux_vrregset. Use regset to collect registers.
375         (fetch_register): Call fetch_altivec_registers instead of
376         fetch_altivec_register.
377         (store_register): Call store_altivec_registers instead of
378         store_altivec_register.
379         (fetch_ppc_registers): Call fetch_altivec_registers with -1 for
380         the new regno parameter.
381         (store_ppc_registers): Call store_altivec_registers with -1 for
382         the new regno parameter.
383
384 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
385
386         * arch/ppc-linux-common.h (PPC_LINUX_SIZEOF_VRREGSET)
387         (PPC_LINUX_SIZEOF_VSXREGSET): Define.
388         * ppc-linux-nat.c (SIZEOF_VSXREGS, SIZEOF_VRREGS): Remove.
389         (gdb_vrregset_t): Change array type size to
390         PPC_LINUX_SIZEOF_VRREGSET.
391         (gdb_vsxregset_t): Change array type size to
392         PPC_LINUX_SIZEOF_VSXREGSET.
393         * ppc-linux-tdep.c (ppc_linux_iterate_over_regset_sections):
394         Change integer literals to PPC_LINUX_SIZEOF_VRREGSET and
395         PPC_LINUX_SIZEOF_VSXREGSET.
396
397 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
398
399         * configure.nat <linux powerpc>: Add ppc-linux.o to NATDEPFILES.
400         * ppc-linux-nat.c (ppc_linux_target_wordsize): Move to
401         nat/ppc-linux.c.
402         (ppc_linux_nat_target::auxv_parse): Get thread id tid. Call
403         ppc_linux_target_wordsize with tid.
404         (ppc_linux_nat_target::read_description): Call ppc_linux_target
405         wordsize with tid.
406         * nat/ppc-linux.c: Include nat/gdb_ptrace.h.
407         (ppc64_64bit_inferior_p): Add static and inline specifiers.
408         (ppc_linux_target_wordsize): Move here from ppc-linux-nat.c. Add
409         tid parameter. Remove static specifier.
410         * nat/ppc-linux.h (ppc64_64bit_inferior_p): Remove declaration.
411         (ppc_linux_target_wordsize): New declaration.
412
413 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
414
415         * arch/ppc-linux-common.c: New file.
416         * arch/ppc-linux-common.h: New file.
417         * arch/ppc-linux-tdesc.h: New file.
418         * configure.tgt (powerpc*-*-linux*): Add arch/ppc-linux-common.o.
419         * Makefile.in (ALL_TARGET_OBS): Add arch/ppc-linux-common.o.
420         (HFILES_NO_SRCDIR): Add arch/ppc-linux-common.h and
421         arch/ppc-linux-tdesc.h.
422         * ppc-linux-nat.c: Include arch/ppc-linux-common.h and
423         arch/ppc-linux-tdesc.h.
424         (ppc_linux_nat_target::read_description): Remove target
425         description matching code. Fill a ppc_linux_features struct and
426         call ppc_linux_match_description with it. Move comment about ISA
427         2.05 to ppc-linux-common.c.
428         * ppc-linux-tdep.c: Include arch/ppc-linux-common.h and
429         arch/ppc-linux-tdesc.h.
430         (ppc_linux_core_read_description): Remove target description
431         matching code. Fill a ppc_linux_features struct and call
432         ppc_linux_match_description with it.
433         * ppc-linux-tdep.h (tdesc_powerpc_32l, tdesc_powerpc_64l)
434         (tdesc_powerpc_altivec32l, tdesc_powerpc_altivec64l)
435         (tdesc_powerpc_cell32l, tdesc_powerpc_cell64l)
436         (tdesc_powerpc_vsx32l, tdesc_powerpc_vsx64l)
437         (tdesc_powerpc_isa205_32l, tdesc_powerpc_isa205_64l)
438         (tdesc_powerpc_isa205_altivec32l, tdesc_powerpc_isa205_altivec64l)
439         (tdesc_powerpc_isa205_vsx32l, tdesc_powerpc_isa205_vsx64l)
440         (tdesc_powerpc_e500l): Remove.
441
442 2018-05-22  Joel Brobecker  <brobecker@adacore.com>
443
444         * ada-lang.c (catch_assert_command): Pass empty string instead
445         of NULL for excep_string argument.
446
447 2018-05-22  Maciej W. Rozycki  <macro@mips.com>
448
449         * mips-linux-nat.c (mips64_linux_register_addr): Return -1 if
450         the width of the requested register exceeds the width of the
451         `ptrace' data type.
452
453 2018-05-21  Tom Tromey  <tom@tromey.com>
454
455         * printcmd.c (output_command): Remove.
456         (output_command_const): Rename to output_command.
457         * valprint.h (output_command): Rename from output_command_const.
458         * tracepoint.c (trace_dump_actions): Call output_command.
459
460 2018-05-21  Tom Tromey  <tom@tromey.com>
461
462         * mi/mi-cmd-catch.c (mi_cmd_catch_assert)
463         (mi_cmd_catch_exception, mi_cmd_catch_handlers): Update.
464         * ada-lang.h (create_ada_exception_catchpoint): Update.
465         * ada-lang.c (struct ada_catchpoint) <excep_string>: Now a
466         std::string.
467         (create_excep_cond_exprs, ~ada_catchpoint)
468         (should_stop_exception, print_one_exception)
469         (print_mention_exception, print_recreate_exception): Update.
470         (ada_get_next_arg): Remove.
471         (catch_ada_exception_command_split): Use std::string.  Change type
472         of "excep_string", "cond_string".
473         (catch_ada_exception_command): Update.
474         (create_ada_exception_catchpoint): Change type of excep_string.
475         (ada_exception_sal): Remove excep_string parameter.
476         (~ada_catchpoint): Remove.
477
478 2018-05-21  Tom Tromey  <tom@tromey.com>
479
480         * ada-lang.c (ada_collect_symbol_completion_matches): Remove
481         cleanup.
482
483 2018-05-21  Tom Tromey  <tom@tromey.com>
484
485         * ada-lang.c (ada_exception_message_1, ada_exception_message):
486         Return unique_xmalloc_ptr.
487         (print_it_exception): Update.
488
489 2018-05-21  Tom Tromey  <tom@tromey.com>
490
491         * tracepoint.c (trace_dump_actions): Use std::string.
492
493 2018-05-21  Tom Tromey  <tom@tromey.com>
494
495         * symfile.c (reread_symbols): Use std::string for original_name.
496
497 2018-05-21  Tom Tromey  <tom@tromey.com>
498
499         * dwarf2read.c (dwarf2_read_debug_names): Use std::unique_ptr.
500         (mapped_index_base): Use DISABLE_COPY_AND_ASSIGN.  Default
501         constructor.
502
503 2018-05-20  Simon Marchi  <simon.marchi@polymtl.ca>
504
505         * common/traits.h (HAVE_IS_TRIVIALLY_COPYABLE): Rename the wrong
506         instance to...
507         (HAVE_IS_TRIVIALLY_CONSTRUCTIBLE): ... this.
508         * objfiles.c (get_objfile_bfd_data): Allocate
509         objfile_per_bfd_storage with obstack_new when allocating on
510         obstack.
511
512 2018-05-20  Simon Marchi  <simon.marchi@ericsson.com>
513
514         * ada-lang.c (cache_symbol): Use XOBNEW and/or XOBNEWVEC and/or
515         OBSTACK_ZALLOC.
516         * dwarf2-frame.c (dwarf2_build_frame_info): Likewise.
517         * hppa-tdep.c (hppa_init_objfile_priv_data): Likewise.
518         * mdebugread.c (mdebug_build_psymtabs): Likewise.
519         (add_pending): Likewise.
520         (parse_symbol): Likewise.
521         (parse_partial_symbols): Likewise.
522         (psymtab_to_symtab_1): Likewise.
523         (new_psymtab): Likewise.
524         (elfmdebug_build_psymtabs): Likewise.
525         * minsyms.c (terminate_minimal_symbol_table): Likewise.
526         * objfiles.c (get_objfile_bfd_data): Likewise.
527         (objfile_register_static_link): Likewise.
528         * psymtab.c (allocate_psymtab): Likewise.
529         * stabsread.c (read_member_functions): Likewise.
530         * xcoffread.c (xcoff_end_psymtab): Likewise.
531
532 2018-05-20  Simon Marchi  <simon.marchi@ericsson.com>
533
534         * common/traits.h (HAVE_IS_TRIVIALLY_COPYABLE): Define if
535         compiler supports std::is_trivially_constructible.
536         * common/poison.h: Include obstack.h.
537         (IsMallocable): Define to is_trivially_constructible if the
538         compiler supports it, define to true_type otherwise.
539         (xobnew): New.
540         (XOBNEW): Redefine.
541         (xobnewvec): New.
542         (XOBNEWVEC): Redefine.
543         * gdb_obstack.h (obstack_zalloc): New.
544         (OBSTACK_ZALLOC): Redefine.
545         (obstack_calloc): New.
546         (OBSTACK_CALLOC): Redefine.
547         (obstack_new): New.
548         * gdbarch.sh: Include gdb_obstack in gdbarch.h.
549         (gdbarch_obstack): New declaration in gdbarch.h, definition in
550         gdbarch.c.
551         (GDBARCH_OBSTACK_CALLOC, GDBARCH_OBSTACK_ZALLOC): Use
552         obstack_calloc/obstack_zalloc.
553         (gdbarch_obstack_zalloc): Remove.
554         * target-descriptions.c (tdesc_data_init): Use obstack_new.
555
556 2018-05-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
557
558         * stack.c (backtrace_command_1): Remove useless variable int i.
559
560 2018-05-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
561
562         * stack.c (print_frame_info): Fix comment.
563
564 2018-05-18  Tom Tromey  <tom@tromey.com>
565
566         * dwarf2read.c (struct dwz_file): Add constructor, initializers.
567         <dwz_bfd>: Now a gdb_bfd_ref_ptr.
568         (~dwarf2_per_objfile): Update
569         (dwarf2_get_dwz_file): Use new.
570         * dwarf2read.h (struct dwarf2_per_objfile) <dwz_file>: Now a
571         unique_ptr.
572
573 2018-05-18  Tom Tromey  <tom@tromey.com>
574
575         * dwarf2read.h (struct dwarf2_per_objfile) <dwp_file>: Now a
576         unique_ptr.
577         * dwarf2read.c (struct dwp_file): Add constructor and
578         initializers.
579         (open_and_init_dwp_file): Return a unique_ptr.
580         (dwarf2_per_objfile, create_dwp_hash_table)
581         (create_dwo_unit_in_dwp_v1, create_dwo_unit_in_dwp_v2)
582         (lookup_dwo_unit_in_dwp): Update.
583         (open_and_init_dwp_file, get_dwp_file): Update.
584
585 2018-05-18  Tom Tromey  <tom@tromey.com>
586
587         * dwarf2read.c (dwarf2_per_objfile): Update.
588         (struct mapped_index): Add initializers.
589         (dwarf2_read_index): Use new.
590         (dw2_symtab_iter_init): Update.
591         * dwarf2read.h (struct dwarf2_per_objfile) <index_table>: Now a
592         unique_ptr.
593
594 2018-05-18  Simon Marchi  <simon.marchi@ericsson.com>
595
596         * dwarf2read.c (mapped_index) <total_size>: Remove.
597
598 2018-05-18  Simon Marchi  <simon.marchi@ericsson.com>
599
600         * unittests/format_pieces-selftests.c (test_format_specifier):
601         Add ARI comments.
602
603 2018-05-18  Tom Tromey  <tom@tromey.com>
604
605         * c-typeprint.c (maybe_print_hole): New function.
606         (c_print_type_struct_field_offset): Update.
607         (c_type_print_base_struct_union): Call maybe_print_hole.
608
609 2018-05-17  Keith Seitz  <keiths@redhat.com>
610
611         * breakpoint.c (build_bpstat_chain): New function, moved from
612         bpstat_stop_status.
613         (bpstat_stop_status): Add optional parameter, `stop_chain'.
614         If no stop chain is passed, call build_bpstat_chain to build it.
615         * breakpoint.h (build_bpstat_chain): Declare.
616         (bpstat_stop_status): Move documentation here from breakpoint.c.
617         * infrun.c (handle_signal_stop): Before eliding inlined frames,
618         build the stop chain and pass it to skip_inline_frames.
619         Pass this stop chain to bpstat_stop_status.
620         * inline-frame.c: Include breakpoint.h.
621         (stopped_by_user_bp_inline_frame): New function.
622         (skip_inline_frames): Add parameter `stop_chain'.
623         Move documention to inline-frame.h.
624         If non-NULL, use stopped_by_user_bp_inline_frame to determine
625         whether the frame should be elided.
626         * inline-frame.h (skip_inline_frames): Add parameter `stop_chain'.
627         Add moved documentation and update for new parameter.
628
629 2018-05-17  Simon Marchi  <simon.marchi@ericsson.com>
630
631         PR cli/14975
632         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
633         unittests/format_pieces-selftests.c.
634         * common/format.h (format_piece) <operator==>: New.
635         (format_pieces) <operator[]>: Remove.
636         * common/format.c (format_pieces::format_pieces): Handle \e.
637         * unittests/format_pieces-selftests.c: New.
638
639 2018-05-17  Tom Tromey  <tom@tromey.com>
640
641         PR symtab/23010:
642         * dwarf2read.c (load_cu, dw2_do_instantiate_symtab)
643         (dw2_instantiate_symtab): Add skip_partial parameter.
644         (dw2_find_last_source_symtab, dw2_map_expand_apply)
645         (dw2_lookup_symbol, dw2_expand_symtabs_for_function)
646         (dw2_expand_all_symtabs, dw2_expand_symtabs_with_fullname)
647         (dw2_expand_symtabs_matching_one)
648         (dw2_find_pc_sect_compunit_symtab)
649         (dw2_debug_names_lookup_symbol)
650         (dw2_debug_names_expand_symtabs_for_function): Update.
651         (init_cutu_and_read_dies): Add skip_partial parameter.
652         (process_psymtab_comp_unit, build_type_psymtabs_1)
653         (process_skeletonless_type_unit, load_partial_comp_unit)
654         (psymtab_to_symtab_1): Update.
655         (load_full_comp_unit): Add skip_partial parameter.
656         (process_imported_unit_die, dwarf2_read_addr_index)
657         (follow_die_offset, dwarf2_fetch_die_loc_sect_off)
658         (dwarf2_fetch_constant_bytes, dwarf2_fetch_die_type_sect_off)
659         (read_signatured_type): Update.
660
661 2018-05-17  Simon Marchi  <simon.marchi@ericsson.com>
662
663         * value.c (release_value): Remove unused variable.
664         (record_latest_value): Likewise.
665         (access_value_history): Likewise.
666         (preserve_values): Likewise.
667
668 2018-05-17  Tom Tromey  <tom@tromey.com>
669
670         * extension.h (struct ext_lang_type_printers) <py_type_printers>:
671         Initialize.
672
673 2018-05-16  Maciej W. Rozycki  <macro@mips.com>
674
675         PR gdb/22286
676         * linux-nat-trad.c (linux_nat_trad_target::fetch_register):
677         Also handle registers whose width is not a multiple of
678         PTRACE_TYPE_RET.
679         (linux_nat_trad_target::store_register): Likewise.
680
681 2018-05-16  Tom Tromey  <tom@tromey.com>
682
683         * gdbcore.h (core_bfd): Redefine.
684         * corelow.c (core_target::close): Update.
685         (core_target_open): Update.
686         * progspace.h (struct program_space) <cbfd>: Now a
687         gdb_bfd_ref_ptr.
688
689 2018-05-16  Tom Tromey  <tom@tromey.com>
690
691         PR cli/19551:
692         * symfile-add-flags.h (enum symfile_add_flags)
693         <SYMFILE_NOT_FILENAME>: New constant.
694         * symfile.c (read_symbols): Use SYMFILE_NOT_FILENAME.  Get
695         objfile name from BFD.
696         (symbol_file_add_with_addrs): Check SYMFILE_NOT_FILENAME.
697         * minidebug.c (find_separate_debug_file_in_section): Put
698         ".gnu_debugdata" into BFD's file name.
699
700 2018-05-16  Simon Marchi  <simon.marchi@ericsson.com>
701
702         * regcache.c (regcache_read_ftype, regcache_write_ftype):
703         Remove.
704
705 2018-05-15  Tamar Christina  <tamar.christina@arm.com>
706
707         PR binutils/21446
708         * aarch64-tdep.c (aarch64_analyze_prologue,
709         aarch64_software_single_step, aarch64_displaced_step_copy_insn):
710         Indicate not interested in errors.
711
712 2018-05-15  Maciej W. Rozycki  <macro@mips.com>
713
714         * mips-linux-nat.c (mips_linux_nat_target::fetch_registers):
715         Supply the MIPS_ZERO_REGNUM register.
716
717 2018-05-15  Maciej W. Rozycki  <macro@mips.com>
718
719         * mips-tdep.c (mask_address_var): Make variable static.
720
721 2018-05-14  Tom Tromey  <tom@tromey.com>
722
723         * dwarf2read.c (rust_union_quirks): Clear rust_unions.
724
725 2018-05-11  Andrew Burgess  <andrew.burgess@embecosm.com>
726
727         * i387-tdep.c (i387_collect_xsave): Use FXSAVE_MXCSR_ADDR not
728         FXSAVE_ADDR for the mxcsr register.
729
730 2018-05-11  Max Filippov  <jcmvbkbc@gmail.com>
731
732         * configure.tgt (xtensa*-*-linux*): Drop gdb_target definition.
733
734 2018-05-11  Pedro Alves  <palves@redhat.com>
735
736         * corelow.c (core_target) <core_target>: No longer inline.
737         Initialize m_core_gdbarch, m_core_vec and build the section table
738         here.
739         <~core_target>: New.
740         <core_gdbarch, get_core_register_section>: New methods.
741         <m_core_section_table, m_core_vec, m_core_gdbarch>: New fields,
742         factored out from ...
743         <core_data, core_vec, core_gdbarch>: ... these deleted globals.
744         (core_ops): Delete.
745         (sniff_core_bfd): Add gdbarch parameter.
746         (core_close): Delete, merged into ...
747         (core_target::close): ... here.  Delete self.
748         (core_close_cleanup): Delete.
749         (core_target_open): Allocate a core_target on the heap.  Use a
750         unique_ptr instead of a cleanup.  Bits moved into the core_target
751         ctor.  Adjust to use core_target methods instead of globals.
752         (get_core_register_section): Rename to ...
753         (core_target::get_core_register_section): ... this and adjust.
754         (struct get_core_registers_cb_data): New.
755         (get_core_registers_cb): Use it.  Use bool.
756         (core_target::fetch_registers, core_target::files_info)
757         (core_target::xfer_partial, core_target::read_description)
758         (core_target::pid_to, core_target::thread_name): Adjust to
759         reference class fields instead of globals.
760         * target.h (struct target_ops_deleter, target_ops_up): New.
761
762 2018-05-11  Pedro Alves  <palves@redhat.com>
763
764         * corefile.c (core_file_command): Move to corelow.c.
765         * corelow.c (the_core_target): Delete.
766         (core_file_command): Moved from corefile.c.  Check exec_bfd
767         instead of the_core_target.  Use target_detach instead of calling
768         into the_core_target directly.
769         (maybe_say_no_core_file_now): New.
770         (core_target::detach): Use it.
771         (_initialize_corelow): Remove references to the_core_target.
772         * gdbcore.h (the_core_target): Delete.
773
774 2018-05-11  Tom Tromey  <tromey@redhat.com>
775             Pedro Alves  <palves@redhat.com>
776
777         * corefile.c (core_bfd): Remove.
778         * gdbcore.h (core_bfd): Now a macro.
779         * progspace.h (struct program_space) <cbfd>: New field.
780
781 2018-05-11  Tom Tromey  <tom@tromey.com>
782
783         * mdebugread.c (parse_partial_symbols, psymtab_to_symtab_1): Use
784         gdb::def_vector.
785
786 2018-05-10  Tom Tromey  <tom@tromey.com>
787
788         * configure: Rebuild.
789         * warning.m4 (AM_GDB_WARNINGS): Use -Wimplicit-fallthrough=3.
790
791 2018-05-10  Joel Brobecker  <brobecker@adacore.com>
792
793         PR server/23158:
794         * regformats/regdat.sh: Adjust script, following the addition
795         of the new expedite_regs parameter to init_target_desc.
796
797 2018-05-10  Omair Javaid  <omair.javaid@linaro.org>
798     
799         PR gdb/23127
800         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Add call to
801         set_gdbarch_significant_addr_bit.
802         * aarch64-tdep.c (aarch64_gdbarch_init): Remove call to
803         set_gdbarch_significant_addr_bit.
804         * utils.c (address_significant): Update to sign extend addr.
805
806 2018-05-09  Max Filippov  <jcmvbkbc@gmail.com>
807
808         * xtensa-linux-tdep.c (xtensa-tdep.h): New include.
809         (xtensa_linux_init_abi): Limit tdep->num_regs by
810         tdep->num_nopriv_regs.
811         * xtensa-tdep.c (xtensa_derive_tdep): Calculate
812         tdep->num_nopriv_regs and only copy it to tdep->num_regs if it's
813         not initialized.
814
815 2018-05-08  Simon Marchi  <simon.marchi@ericsson.com>
816
817         * unittests/string_view-selftests.c: Define GNULIB_NAMESPACE.
818
819 2018-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
820
821         * common/x86-xstate.h (I387_FCTRL_INIT_VAL): New constant.
822         (I387_MXCSR_INIT_VAL): New constant.
823         * amd64-tdep.c (amd64_supply_xsave): Only read state from xsave
824         buffer if it was supplied by the inferior.
825         * i387-tdep.c (i387_supply_fsave): Use I387_MXCSR_INIT_VAL.
826         (i387_xsave_get_clear_bv): New function.
827         (i387_supply_xsave): Only read x87 control registers from the
828         xsave buffer if the feature is enabled, and the state will have
829         been written, otherwise, provide a suitable default.
830         (i387_collect_xsave): Pre-clear all registers in xsave buffer,
831         including x87 control registers.  Update control registers if they
832         have changed from the default value, and mark features as enabled
833         as required.
834         * i387-tdep.h (i387_xsave_get_clear_bv): Declare.
835
836 2018-05-08  Ulrich Weigand  <uweigand@de.ibm.com>
837
838         * spu-tdep.c (info_spu_event_command): Fix output formatting.
839
840 2018-05-07  Tom Tromey  <tom@tromey.com>
841
842         * configure: Rebuild.
843         * warning.m4 (AM_GDB_WARNINGS): Add -Wduplicated-cond.
844
845 2018-05-07  Tom Tromey  <tom@tromey.com>
846
847         PR tdep/20362:
848         * arm-tdep.c (arm_record_vfp_data_proc_insn): Properly mask off D
849         bit.  Use correct value for VDIV.
850
851 2018-05-04  Tom Tromey  <tom@tromey.com>
852
853         * configure: Rebuild.
854         * warning.m4 (AM_GDB_WARNINGS): Add -Wimplicit-fallthrough.
855
856 2018-05-04  Tom Tromey  <tom@tromey.com>
857
858         * linux-record.c (record_linux_system_call) <case
859         RECORD_SYS_RECVFROM>: Add "break".
860
861 2018-05-04  Tom Tromey  <tom@tromey.com>
862
863         * mi/mi-main.c (mi_cmd_trace_frame_collected) <REGISTERS_FORMAT>:
864         Add missing "break".
865         * mi/mi-cmd-stack.c (mi_cmd_stack_list_locals) <NO_FRAME_FILTERS>:
866         Add missing "break".
867
868 2018-05-04  Tom Tromey  <tom@tromey.com>
869
870         * rs6000-tdep.c (ppc_process_record_op4)
871         (ppc_process_record_op63): Add fall-through comment.
872
873 2018-05-04  Tom Tromey  <tom@tromey.com>
874
875         * i386-tdep.c (i386_process_record): Add fall-through comment.
876
877 2018-05-04  Tom Tromey  <tom@tromey.com>
878
879         * stabsread.c (define_symbol) <case 'p'>: Add fall-through
880         comment.
881
882 2018-05-04  Tom Tromey  <tom@tromey.com>
883
884         * riscv-tdep.c (riscv_isa_xlen): Add fall-through comment.
885         * utils.c (can_dump_core) <LIMIT_CUR>: Add fall-through comment.
886         * eval.c (fetch_subexp_value) <MEMORY_ERROR>: Add fall-through
887         comment.
888         * d-valprint.c (d_val_print) <TYPE_CODE_STRUCT>: Add fall-through
889         comment.
890         * coffread.c (coff_symtab_read) <C_LABEL>: Add fall-through
891         comment.
892
893 2018-05-04  Tom Tromey  <tom@tromey.com>
894
895         * dwarf2loc.c (unimplemented): Add ATTRIBUTE_NORETURN.
896
897 2018-05-04  Tom Tromey  <tom@tromey.com>
898
899         * s390-tdep.c (s390_process_record): Fix fall-through comments.
900         * xcoffread.c (scan_xcoff_symtab): Move comment later.
901         * symfile.c (section_is_mapped): Fix fall-through comment.
902         * stabsread.c (define_symbol, read_member_functions): Fix
903         fall-through comment.
904         * s390-linux-tdep.c (s390_process_record): Fix fall-through
905         comment.
906         * remote.c (remote_wait_as): Fix fall-through comment.
907         * p-exp.y (yylex): Fix fall-through comment.
908         * nat/x86-dregs.c (x86_length_and_rw_bits): Fix fall-through
909         comment.
910         * msp430-tdep.c (msp430_gdbarch_init): Fix fall-through comment.
911         * mdebugread.c (parse_partial_symbols): Fix fall-through comment.
912         * jv-exp.y (yylex): Fix fall-through comment.
913         * go-exp.y (lex_one_token): Fix fall-through comment.
914         * gdbtypes.c (get_discrete_bounds, rank_one_type): Fix
915         fall-through comment.
916         * f-exp.y (yylex): Fix fall-through comment.
917         * dwarf2read.c (process_die): Fix fall-through comments.
918         * dbxread.c (process_one_symbol): Fix fall-through comment.
919         * d-exp.y (lex_one_token): Fix fall-through comment.
920         * cp-name-parser.y (yylex): Fix fall-through comment.
921         * coffread.c (coff_symtab_read): Fix fall-through comment.
922         * c-exp.y (lex_one_token): Fix fall-through comment.
923         * arm-tdep.c (arm_decode_miscellaneous): Fix fall-through
924         comment.
925         * arch/arm.c (arm_instruction_changes_pc): Fix fall-through
926         comment.
927
928 2018-05-04  Tom Tromey  <tom@tromey.com>
929
930         PR python/22730:
931         * NEWS: Mention gdb.execute change.
932         * gdbcmd.h (execute_control_command): Don't declare.
933         * python/python.c (execute_gdb_command): Use read_command_lines_1,
934         execute_control_commands, execute_control_commands_to_string.
935         * cli/cli-script.h (execute_control_commands)
936         (execute_control_commands_to_string): Declare.
937         (execute_control_command): Add from_tty parameter.
938         * cli/cli-script.c (execute_control_commands)
939         (execute_control_commands_to_string): New functions.
940         (execute_user_command): Use execute_control_commands.
941         (execute_control_command_1): Add "from_tty" parameter.  Update.
942         (execute_control_command): Likewise.
943
944 2018-05-04  Tom Tromey  <tom@tromey.com>
945
946         PR python/22731:
947         * NEWS: Mention that breakpoint commands are writable.
948         * python/py-breakpoint.c (bppy_set_commands): New function.
949         (breakpoint_object_getset) <"commands">: Use it.
950
951 2018-05-04  Tom Tromey  <tom@tromey.com>
952
953         * tracepoint.c (actions_command): Update.
954         * mi/mi-cmd-break.c (mi_command_line_array)
955         (mi_command_line_array_cnt, mi_command_line_array_ptr)
956         (mi_read_next_line): Remove.
957         (mi_cmd_break_commands): Update.
958         * cli/cli-script.h (read_command_lines, read_command_lines_1): Use
959         function_view.
960         * cli/cli-script.c (get_command_line): Update.
961         (process_next_line): Use function_view.  Constify.
962         (recurse_read_control_structure, read_command_lines)
963         (read_command_lines_1): Change argument types to function_view.
964         (do_define_command, document_command): Update.
965         * breakpoint.h (check_tracepoint_command): Don't declare.
966         * breakpoint.c (check_tracepoint_command): Remove.
967         (commands_command_1, create_tracepoint_from_upload): Update.
968
969 2018-05-04  Tom Tromey  <tom@tromey.com>
970
971         PR gdb/11750:
972         * cli/cli-script.h (enum command_control_type) <define_control>:
973         New constant.
974         * cli/cli-script.c (multi_line_command_p): Handle define_control.
975         (build_command_line, execute_control_command_1)
976         (process_next_line): Likewise.
977         (do_define_command): New function, extracted from define_command.
978         (define_command): Use it.
979
980 2018-05-04  Tom Tromey  <tom@tromey.com>
981
982         * tracepoint.c (actions_command): Update.
983         * cli/cli-script.h (read_command_lines): Update.
984         * cli/cli-script.c (read_command_lines): Constify prompt_arg.
985         (MAX_TMPBUF): Remove define.
986         (define_command): Use string_printf.
987         (document_command): Likewise.
988         * breakpoint.c (commands_command_1): Update.
989
990 2018-05-04  Tom Tromey  <tom@tromey.com>
991
992         * top.c (execute_command): Update.
993         * cli/cli-script.h (print_command_lines): Now varargs.
994         * cli/cli-script.c (print_command_lines): Now varargs.
995         (execute_control_command_1) <case while_control, case if_control>:
996         Update.
997
998 2018-05-04  Tom Tromey  <tom@tromey.com>
999
1000         * tracepoint.c (all_tracepoint_actions): Rename from
1001         all_tracepoint_actions_and_cleanup.  Change return type.
1002         (actions_command, encode_actions_1, encode_actions)
1003         (trace_dump_actions, tdump_command): Update.
1004         * remote.c (remote_download_command_source): Update.
1005         * python/python.c (gdbpy_eval_from_control_command)
1006         (python_command, python_interactive_command): Update.
1007         * mi/mi-cmd-break.c (mi_cmd_break_commands): Update.
1008         * guile/guile.c (guile_command)
1009         (gdbscm_eval_from_control_command, guile_command): Update.
1010         * compile/compile.c (compile_code_command)
1011         (compile_print_command, compile_to_object): Update.
1012         * cli/cli-script.h (struct command_lines_deleter): New.
1013         (counted_command_line): New typedef.
1014         (struct command_line): Add constructor, destructor.
1015         <body_list>: Remove.
1016         <body_list_0, body_list_1>: New members.
1017         (command_line_up): Remove typedef.
1018         (read_command_lines, read_command_lines_1, get_command_line):
1019         Update.
1020         (copy_command_lines): Don't declare.
1021         * cli/cli-script.c (build_command_line): Use "new".
1022         (get_command_line): Return counted_command_line.
1023         (print_command_lines, execute_user_command)
1024         (execute_control_command_1, while_command, if_command): Update.
1025         (realloc_body_list): Remove.
1026         (process_next_line, recurse_read_control_structure): Update.
1027         (read_command_lines, read_command_lines_1): Return counted_command_line.
1028         (free_command_lines): Use "delete".
1029         (copy_command_lines): Remove.
1030         (define_command, document_command, show_user_1): Update.
1031         * cli/cli-decode.h (struct cmd_list_element) <user_commands>: Now
1032         a counted_command_line.
1033         * breakpoint.h (counted_command_line): Remove typedef.
1034         (breakpoint_set_commands): Update.
1035         * breakpoint.c (check_no_tracepoint_commands)
1036         (validate_commands_for_breakpoint): Update.
1037         (breakpoint_set_commands): Change commands to be a
1038         counted_command_line.
1039         (commands_command_1, update_dprintf_command_list)
1040         (create_tracepoint_from_upload): Update.
1041
1042 2018-05-04  Tom Tromey  <tom@tromey.com>
1043
1044         * cli/cli-decode.h (cmd_list_element): New constructor.
1045         (~cmd_list_element): New destructor.
1046         (struct cmd_list_element): Add initializers.
1047         * cli/cli-decode.c (do_add_cmd): Use "new".
1048         (delete_cmd): Use "delete".
1049
1050 2018-05-04  Jan Kratochvil  <jan.kratochvil@redhat.com>
1051             Pedro Alves <palves@redhat.com>
1052
1053         PR breakpoints/19806 and support for PR external/20207.
1054         * NEWS: Mention Aarch64 watchpoint improvements.
1055         * aarch64-linux-nat.c (aarch64_linux_stopped_data_address): Fix missed
1056         watchpoints and PR external/20207 watchpoints.
1057         * nat/aarch64-linux-hw-point.c
1058         (kernel_supports_any_contiguous_range): New.
1059         (aarch64_watchpoint_offset): New.
1060         (aarch64_watchpoint_length): Support PR external/20207 watchpoints.
1061         (aarch64_point_encode_ctrl_reg): New parameter offset, new asserts.
1062         (aarch64_point_is_aligned): Support PR external/20207 watchpoints.
1063         (aarch64_align_watchpoint): New parameters aligned_offset_p and
1064         next_addr_orig_p.  Support PR external/20207 watchpoints.
1065         (aarch64_downgrade_regs): New.
1066         (aarch64_dr_state_insert_one_point): New parameters offset and
1067         addr_orig.
1068         (aarch64_dr_state_remove_one_point): Likewise.
1069         (aarch64_handle_breakpoint): Update caller.
1070         (aarch64_handle_aligned_watchpoint): Likewise.
1071         (aarch64_handle_unaligned_watchpoint): Support addr_orig and
1072         aligned_offset.
1073         (aarch64_linux_set_debug_regs): Remove const from state.  Call
1074         aarch64_downgrade_regs.
1075         (aarch64_show_debug_reg_state): Print also dr_addr_orig_wp.
1076         * nat/aarch64-linux-hw-point.h (DR_CONTROL_LENGTH): Rename to ...
1077         (DR_CONTROL_MASK): ... this.
1078         (struct aarch64_debug_reg_state): New field dr_addr_orig_wp.
1079         (unsigned int aarch64_watchpoint_offset): New prototype.
1080         (aarch64_linux_set_debug_regs): Remove const from state.
1081         * utils.c (align_up, align_down): Move to ...
1082         * common/common-utils.c (align_up, align_down): ... here.
1083         * utils.h (align_up, align_down): Move to ...
1084         * common/common-utils.h (align_up, align_down): ... here.
1085
1086 2018-05-04  Joel Brobecker  <brobecker@adacore.com>
1087
1088         * sparc-tdep.c (sparc_structure_return_p): Re-implement to
1089         match the ABI as summarized in GCC's gcc/config/sparc/sparc.c.
1090         (sparc_arg_by_memory_p): Renamed from sparc_arg_on_registers_p.
1091         Re-implement to match the ABI as summarized in GCC's
1092         gcc/config/sparc/sparc.c.  All callers updated.
1093         (sparc32_store_arguments): Remove assertion.
1094
1095 2018-05-04  Tom Tromey  <tom@tromey.com>
1096
1097         * printcmd.c: Don't include tui.h.
1098         (decode_format): Use skip_spaces.
1099
1100 2018-05-04  Tom Tromey  <tom@tromey.com>
1101
1102         PR gdb/22619:
1103         * printcmd.c (last_count): New global.
1104         (x_command): Use saved count when repeating.
1105
1106 2018-05-04  Tom Tromey  <tom@tromey.com>
1107
1108         * nto-procfs.c (do_closedir_cleanup): Remove.
1109         (procfs_pidlist): Use gdb_dir_up.
1110         * procfs.c (do_closedir_cleanup): Remove.
1111         (proc_update_threads): Use gdb_dir_up.
1112         * common/filestuff.h (struct gdb_dir_deleter): New.
1113         (gdb_dir_up): New typedef.
1114
1115 2018-05-04  Tom Tromey  <tom@tromey.com>
1116
1117         * ada-lang.c (print_mention_exception): Use std::string.
1118
1119 2018-05-04  Tom Tromey  <tom@tromey.com>
1120
1121         * ada-lang.c (create_excep_cond_exprs): Update.
1122         (ada_exception_catchpoint_cond_string): Use std::string.
1123
1124 2018-05-04  Tom Tromey  <tom@tromey.com>
1125
1126         * ada-lang.c (xget_renaming_scope): Return std::string.
1127         (old_renaming_is_invisible): Update.
1128
1129 2018-05-04  Tom Tromey  <tom@tromey.com>
1130
1131         * bfd-target.c (target_bfd::m_bfd): Now a gdb_bfd_ref_ptr.
1132         (target_bfd::target_bfd, target_bfd::~target_bfd): Update.
1133
1134 2018-05-04  Ulrich Weigand  <uweigand@de.ibm.com>
1135
1136         * spu-linux-nat.c (spu_linux_nat_target::wait): Fix syntax error.
1137
1138 2018-05-04  Tom Tromey  <tom@tromey.com>
1139
1140         * remote.c (remote_query_supported_append): Change type.
1141         (remote_check_symbols): Update.
1142
1143 2018-05-04  Paul Pluzhnikov  <ppluzhnikov@google.com>
1144
1145         PR gdb/11420
1146         * configure.ac: Prepend libpython.
1147         * python/python-config.py: Likewise.
1148         * configure: Regenerate.
1149
1150 2018-05-03  Simon Marchi  <simon.marchi@ericsson.com>
1151
1152         * Makefile.in (%.c: %.l): Use -t instead of --stdout.
1153
1154 2018-05-03  Pedro Alves  <palves@redhat.com>
1155
1156         * s390-linux-nat.c
1157         (s390_linux_nat_target::have_continuable_watchpoint): Mark with
1158         override.  Write 'true' instead of '1'.
1159         (s390_linux_nat_target::watchpoint_addr_within_range): Remove
1160         declaration.
1161
1162 2018-05-02  Pedro Alves  <palves@redhat.com>
1163
1164         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Use
1165         add_inf_child_target.
1166         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Use
1167         add_inf_child_target.
1168         * aix-thread.c (aix_thread_target_info): New.
1169         (aix_thread_target) <shortname, longname, doc>: Delete.
1170         <info>: New.
1171         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Use
1172         add_inf_child_target.
1173         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Use
1174         add_inf_child_target.
1175         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Use
1176         add_inf_child_target.
1177         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Use
1178         add_inf_child_target.
1179         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Use
1180         add_inf_child_target.
1181         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Use
1182         add_inf_child_target.
1183         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Use
1184         add_inf_child_target.
1185         * arm-linux-nat.c (_initialize_arm_linux_nat): Use
1186         add_inf_child_target.
1187         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Use
1188         add_inf_child_target.
1189         * bfd-target.c (target_bfd_target_info): New.
1190         (target_bfd) <shortname, longname, doc>: Delete.
1191         <info>: New.
1192         * bsd-kvm.c (bsd_kvm_target_info): New.
1193         (bsd_kvm_target) <shortname, longname, doc>: Delete.
1194         <info>: New.
1195         (bsd_kvm_target::open): Rename to ...
1196         (bsd_kvm_target_open): ... this.  Adjust.
1197         * bsd-uthread.c (bsd_uthread_target_info): New.
1198         (bsd_uthread_target) <shortname, longname, doc>: Delete.
1199         <info>: New.
1200         * corefile.c (core_file_command): Adjust.
1201         * corelow.c (core_target_info): New.
1202         (core_target) <shortname, longname, doc>: Delete.
1203         <info>: New.
1204         (core_target::open): Rename to ...
1205         (core_target_open): ... this.  Adjust.
1206         * ctf.c (ctf_target_info): New.
1207         (ctf_target) <shortname, longname, doc>: Delete.
1208         <info>: New.
1209         (ctf_target::open): Rename to ...
1210         (ctf_target_open): ... this.
1211         (_initialize_ctf): Adjust.
1212         * exec.c (exec_target_info): New.
1213         (exec_target) <shortname, longname, doc>: Delete.
1214         <info>: New.
1215         (exec_target::open): Rename to ...
1216         (exec_target_open): ... this.
1217         * gdbcore.h (core_target_open): Declare.
1218         * go32-nat.c (_initialize_go32_nat): Use add_inf_child_target.
1219         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Use
1220         add_inf_child_target.
1221         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Use
1222         add_inf_child_target.
1223         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Use
1224         add_inf_child_target.
1225         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Use
1226         add_inf_child_target.
1227         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Use
1228         add_inf_child_target.
1229         * i386-gnu-nat.c (_initialize_i386gnu_nat): Use
1230         add_inf_child_target.
1231         * i386-linux-nat.c (_initialize_i386_linux_nat): Use
1232         add_inf_child_target.
1233         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Use
1234         add_inf_child_target.
1235         * i386-obsd-nat.c (_initialize_i386obsd_nat): Use
1236         add_inf_child_target.
1237         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Use
1238         add_inf_child_target.
1239         * inf-child.c (inf_child_target_info): New.
1240         (inf_child_target::info): New.
1241         (inf_child_open_target): Remove 'target' parameter.  Use
1242         get_native_target instead.
1243         (inf_child_target::open): Delete.
1244         (add_inf_child_target): New.
1245         * inf-child.h (inf_child_target) <shortname, longname, doc, open>:
1246         Delete.
1247         <info>: New.
1248         (add_inf_child_target): Declare.
1249         (inf_child_open_target): Declare.
1250         * linux-thread-db.c (thread_db_target_info): New.
1251         (thread_db_target) <shortname, longname, doc>: Delete.
1252         <info>: New.
1253         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Use
1254         add_inf_child_target.
1255         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Use
1256         add_inf_child_target.
1257         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Use
1258         add_inf_child_target.
1259         * m88k-bsd-nat.c (_initialize_m88kbsd_nat): Use
1260         add_inf_child_target.
1261         * make-target-delegates (print_class): Adjust.
1262         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Use
1263         add_inf_child_target.
1264         * mips-linux-nat.c (_initialize_mips_linux_nat): Use
1265         add_inf_child_target.
1266         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Use
1267         add_inf_child_target.
1268         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Use
1269         add_inf_child_target.
1270         * nto-procfs.c (nto_native_target_info): New.
1271         (nto_procfs_target_native) <shortname, longname, doc>:
1272         Delete.
1273         <info>: New.
1274         (nto_procfs_target_info): New.
1275         (nto_procfs_target_procfs) <shortname, longname, doc>:
1276         Delete.
1277         <info>: New.
1278         (init_procfs_targets): Adjust.
1279         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Use
1280         add_inf_child_target.
1281         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Use
1282         add_inf_child_target.
1283         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Use
1284         add_inf_child_target.
1285         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Use
1286         add_inf_child_target.
1287         * ravenscar-thread.c (ravenscar_target_info): New.
1288         (ravenscar_thread_target) <shortname, longname, doc>:
1289         Delete.
1290         <info>: New.
1291         * record-btrace.c (record_btrace_target_info):
1292         (record_btrace_target) <shortname, longname, doc>: Delete.
1293         <info>: New.
1294         (record_btrace_target::open): Rename to ...
1295         (record_btrace_target_open): ... this.  Adjust.
1296         * record-full.c (record_longname, record_doc): New.
1297         (record_full_base_target) <shortname, longname, doc>: Delete.
1298         <info>: New.
1299         (record_full_target_info): New.
1300         (record_full_target): <shortname>: Delete.
1301         <info>: New.
1302         (record_full_core_open_1, record_full_open_1): Update comments.
1303         (record_full_base_target::open): Rename to ...
1304         (record_full_open): ... this.
1305         (cmd_record_full_restore): Update.
1306         (_initialize_record_full): Update.
1307         * remote-sim.c (remote_sim_target_info): New.
1308         (gdbsim_target) <shortname, longname, doc>: Delete.
1309         <info>: New.
1310         (gdbsim_target::open): Rename to ...
1311         (gdbsim_target_open): ... this.
1312         (_initialize_remote_sim): Adjust.
1313         * remote.c (remote_doc): New.
1314         (remote_target_info): New.
1315         (remote_target) <shortname, longname, doc>: Delete.
1316         <info>: New.
1317         (extended_remote_target_info): New.
1318         (extended_remote_target) <shortname, longname, doc>: Delete.
1319         <info>: New.
1320         (remote_target::open_1): Make static.  Adjust.
1321         * rs6000-nat.c (_initialize_rs6000_nat): Use add_inf_child_target.
1322         * s390-linux-nat.c (_initialize_s390_nat): Use
1323         add_inf_child_target.
1324         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Use
1325         add_inf_child_target.
1326         * sol-thread.c (thread_db_target_info): New.
1327         (sol_thread_target) <shortname, longname, doc>: Delete.
1328         <info>: New.
1329         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Use
1330         add_inf_child_target.
1331         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Use
1332         add_inf_child_target.
1333         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Use
1334         add_inf_child_target.
1335         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Use
1336         add_inf_child_target.
1337         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Use
1338         add_inf_child_target.
1339         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Use
1340         add_inf_child_target.
1341         * spu-linux-nat.c (_initialize_spu_nat): Use
1342         add_inf_child_target.
1343         * spu-multiarch.c (spu_multiarch_target_info): New.
1344         (spu_multiarch_target) <shortname, longname, doc>: Delete.
1345         <info>: New.
1346         * target-delegates.c: Regenerate.
1347         * target.c: Include <unordered_map>.
1348         (target_ops_p): Delete.
1349         (DEF_VEC_P(target_ops_p)): Delete.
1350         (target_factories): New.
1351         (test_target_info): New.
1352         (test_target_ops::info): New.
1353         (open_target): Adjust to use target_factories.
1354         (add_target_with_completer): Rename to ...
1355         (add_target): ... this.  Change prototype.  Register target_info
1356         and open callback in target_factories.  Register target_info in
1357         command context instead of target_ops.
1358         (add_target): Delete old implementation.
1359         (add_deprecated_target_alias): Change prototype.  Adjust.
1360         (the_native_target): New.
1361         (set_native_target, get_native_target): New.
1362         (find_default_run_target): Use the_native_target.
1363         (find_attach_target, find_run_target): Simplify.
1364         (target_ops::open): Delete.
1365         (dummy_target_info): New.
1366         (dummy_target::shortname, dummy_target::longname)
1367         (dummy_target::doc): Delete.
1368         (dummy_target::info): New.
1369         (debug_target::shortname, debug_target::longname)
1370         (debug_target::doc): Delete.
1371         (debug_target::info): New.
1372         * target.h (struct target_info): New.
1373         (target_ops::~target_ops): Add comment.
1374         (target_ops::info): New.
1375         (target_ops::shortname, target_ops::longname, target_ops::doc): No
1376         longer virtual.  Implement in terms of target_info.
1377         (set_native_target, get_native_target): Declare.
1378         (target_open_ftype): New.
1379         (add_target, add_target_with_completer)
1380         (add_deprecated_target_alias): Change prototype.
1381         (test_target) <shortname, longname, doc>: Delete.
1382         <info>: New.
1383         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Use
1384         add_inf_child_target.
1385         * tracefile-tfile.c (tfile_target_info): New.
1386         (tfile_target) <shortname, longname, doc>: Delete.
1387         <info>: New.
1388         (tfile_target::open): Rename to ...
1389         (tfile_target_open): ... this.
1390         (_initialize_tracefile_tfile): Adjust.
1391         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Use
1392         add_inf_child_target.
1393         * windows-nat.c (_initialize_windows_nat): Use
1394         add_inf_child_target.
1395         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Use
1396         add_inf_child_target.
1397
1398 2018-05-02  Pedro Alves  <palves@redhat.com>
1399
1400         * linux-nat.h (linux_nat_target) <low_new_thread,
1401         low_delete_thread, low_new_fork, low_forget_process,
1402         low_prepare_to_resume, low_siginfo_fixup, low_status_is_event>:
1403         New virtual methods.
1404         (linux_nat_set_new_thread, linux_nat_set_delete_thread)
1405         (linux_nat_new_fork_ftype, linux_nat_set_new_fork)
1406         (linux_nat_forget_process_ftype, linux_nat_set_forget_process)
1407         (linux_nat_forget_process, linux_nat_set_siginfo_fixup)
1408         (linux_nat_set_prepare_to_resume, linux_nat_set_status_is_event):
1409         Delete.
1410         * linux-fork.c (delete_fork): Adjust to call low method.
1411         * linux-nat.c (linux_nat_new_thread, linux_nat_delete_thread)
1412         (linux_nat_new_fork, linux_nat_forget_process_hook)
1413         (linux_nat_prepare_to_resume, linux_nat_siginfo_fixup)
1414         (linux_nat_status_is_event):
1415         (linux_nat_target::follow_fork, lwp_free, add_lwp, detach_one_lwp)
1416         (linux_resume_one_lwp_throw, linux_handle_extended_wait): Adjust
1417         to call low method.
1418         (sigtrap_is_event): Rename to ...
1419         (linux_nat_target::low_status_is_event): ... this.
1420         (linux_nat_set_status_is_event): Delete.
1421         (save_stop_reason, linux_nat_wait_1)
1422         (linux_nat_target::mourn_inferior, siginfo_fixup): Adjust to call
1423         low methods.
1424         (linux_nat_set_new_thread, linux_nat_set_delete_thread)
1425         (linux_nat_set_new_fork, linux_nat_set_forget_process)
1426         (linux_nat_forget_process, linux_nat_set_siginfo_fixup)
1427         (linux_nat_set_prepare_to_resume): Delete.
1428         * aarch64-linux-nat.c: All linux_nat_set_* callbacks converted to
1429         low virtual methods.
1430         * amd64-linux-nat.c: Likewise.
1431         * arm-linux-nat.c: Likewise.
1432         * i386-linux-nat.c: Likewise.
1433         * ia64-linux-nat.c: Likewise.
1434         * mips-linux-nat.c: Likewise.
1435         * ppc-linux-nat.c: Likewise.
1436         * s390-linux-nat.c: Likewise.
1437         * sparc64-linux-nat.c: Likewise.
1438         * x86-linux-nat.c: Likewise.
1439         * x86-linux-nat.h: Include "nat/x86-linux.h".
1440         (x86_linux_nat_target) <low_new_fork, low_forget_process,
1441         low_prepare_to_resume, low_new_thread, low_delete_thread>:
1442         Override methods.
1443
1444 2018-05-02  Pedro Alves  <palves@redhat.com>
1445
1446         * target.h (target_ops)
1447         <stopped_by_sw_breakpoint, supports_stopped_by_sw_breakpoint,
1448         stopped_by_hw_breakpoint, supports_stopped_by_hw_breakpoint,
1449         stopped_by_watchpoint, have_continuable_watchpoint,
1450         stopped_data_address, watchpoint_addr_within_range,
1451         can_accel_watchpoint_condition, can_run, thread_alive,
1452         has_all_memory, has_memory, has_stack, has_registers,
1453         has_execution, can_async_p, is_async_p, supports_non_stop,
1454         always_non_stop_p, can_execute_reverse, supports_multi_process,
1455         supports_enable_disable_tracepoint,
1456         supports_disable_randomization, supports_string_tracing,
1457         supports_evaluation_of_breakpoint_conditions,
1458         can_run_breakpoint_commands, filesystem_is_local,
1459         can_download_tracepoint, get_trace_state_variable_value,
1460         set_trace_notes, get_tib_address, use_agent, can_use_agent,
1461         record_is_replaying, record_will_replay,
1462         augmented_libraries_svr4_read>: Adjust to return bool.
1463         * aarch64-linux-nat.c: All implementations adjusted.
1464         * aix-thread.c: All implementations adjusted.
1465         * arm-linux-nat.c: All implementations adjusted.
1466         * breakpoint.c: All implementations adjusted.
1467         * bsd-kvm.c: All implementations adjusted.
1468         * bsd-uthread.c: All implementations adjusted.
1469         * corelow.c: All implementations adjusted.
1470         * ctf.c: All implementations adjusted.
1471         * darwin-nat.c: All implementations adjusted.
1472         * darwin-nat.h: All implementations adjusted.
1473         * exec.c: All implementations adjusted.
1474         * fbsd-nat.c: All implementations adjusted.
1475         * fbsd-nat.h: All implementations adjusted.
1476         * gnu-nat.c: All implementations adjusted.
1477         * gnu-nat.h: All implementations adjusted.
1478         * go32-nat.c: All implementations adjusted.
1479         * ia64-linux-nat.c: All implementations adjusted.
1480         * inf-child.c: All implementations adjusted.
1481         * inf-child.h: All implementations adjusted.
1482         * inf-ptrace.c: All implementations adjusted.
1483         * inf-ptrace.h: All implementations adjusted.
1484         * linux-nat.c: All implementations adjusted.
1485         * linux-nat.h: All implementations adjusted.
1486         * mips-linux-nat.c: All implementations adjusted.
1487         * nto-procfs.c: All implementations adjusted.
1488         * ppc-linux-nat.c: All implementations adjusted.
1489         * procfs.c: All implementations adjusted.
1490         * ravenscar-thread.c: All implementations adjusted.
1491         * record-btrace.c: All implementations adjusted.
1492         * record-full.c: All implementations adjusted.
1493         * remote-sim.c: All implementations adjusted.
1494         * remote.c: All implementations adjusted.
1495         * s390-linux-nat.c: All implementations adjusted.
1496         * sol-thread.c: All implementations adjusted.
1497         * spu-multiarch.c: All implementations adjusted.
1498         * target-delegates.c: All implementations adjusted.
1499         * target.c: All implementations adjusted.
1500         * target.h: All implementations adjusted.
1501         * tracefile-tfile.c: All implementations adjusted.
1502         * tracefile.c: All implementations adjusted.
1503         * tracefile.h: All implementations adjusted.
1504         * windows-nat.c: All implementations adjusted.
1505         * x86-linux-nat.h: All implementations adjusted.
1506         * x86-nat.h: All implementations adjusted.
1507
1508 2018-05-02  Pedro Alves  <palves@redhat.com>
1509
1510         * make-target-delegates (scan_target_h): Don't trim lines here.
1511         Replace sequences of tabs and/or whitespace with a single
1512         whitespace.
1513         (top level, parsing methods): Trim each line before processing it
1514         here.
1515
1516 2018-05-02  Pedro Alves  <palves@redhat.com>
1517             John Baldwin  <jhb@freebsd.org>
1518
1519         * target.h (enum strata) <debug_stratum>: New.
1520         (struct target_ops) <all delegation methods>: Replace by C++
1521         virtual methods, and drop "to_" prefix.  All references updated
1522         throughout.
1523         <to_shortname, to_longname, to_doc, to_data,
1524         to_have_steppable_watchpoint, to_have_continuable_watchpoint,
1525         to_has_thread_control, to_attach_no_wait>: Delete, replaced by
1526         virtual methods.  All references updated throughout.
1527         <can_attach, supports_terminal_ours, can_create_inferior,
1528         get_thread_control_capabilities, attach_no_wait>: New
1529         virtual methods.
1530         <insert_breakpoint, remove_breakpoint>: Now
1531         TARGET_DEFAULT_NORETURN methods.
1532         <info_proc>: Now returns bool.
1533         <to_magic>: Delete.
1534         (OPS_MAGIC): Delete.
1535         (current_target): Delete.  All references replaced by references
1536         to ...
1537         (target_stack): ... this.  New.
1538         (target_shortname, target_longname): Adjust.
1539         (target_can_run): Now a function declaration.
1540         (default_child_has_all_memory, default_child_has_memory)
1541         (default_child_has_stack, default_child_has_registers)
1542         (default_child_has_execution): Remove target_ops parameter.
1543         (complete_target_initialization): Delete.
1544         (memory_breakpoint_target): New template class.
1545         (test_target_ops): Refactor as a C++ class with virtual methods.
1546         * make-target-delegates (NAME_PART): Tighten.
1547         (POINTER_PART, CP_SYMBOL): New.
1548         (SIMPLE_RETURN_PART): Reimplement.
1549         (VEC_RETURN_PART): Expect less.
1550         (RETURN_PART, VIRTUAL_PART): New.
1551         (METHOD): Adjust to C++ virtual methods.
1552         (scan_target_h): Remove reference to C99.
1553         (dname): Output "target_ops::" prefix.
1554         (write_function_header): Adjust to output a C++ class method.
1555         (write_declaration): New.
1556         (write_delegator): Adjust to output a C++ class method.
1557         (tdname): Output "dummy_target::" prefix.
1558         (write_tdefault, write_debugmethod): Adjust to output a C++ class
1559         method.
1560         (tdefault_names, debug_names): Delete.
1561         (return_types, tdefaults, styles, argtypes_array): New.
1562         (top level): All methods are delegators.
1563         (print_class): New.
1564         (top level): Print dummy_target and debug_target classes.
1565         * target-delegates.c: Regenerate.
1566         * target-debug.h (target_debug_print_enum_info_proc_what)
1567         (target_debug_print_thread_control_capabilities)
1568         (target_debug_print_thread_info_p): New.
1569         * target.c (dummy_target): Delete.
1570         (the_dummy_target, the_debug_target): New.
1571         (target_stack): Now extern.
1572         (set_targetdebug): Push/unpush debug target.
1573         (default_child_has_all_memory, default_child_has_memory)
1574         (default_child_has_stack, default_child_has_registers)
1575         (default_child_has_execution): Remove target_ops parameter.
1576         (complete_target_initialization): Delete.
1577         (add_target_with_completer): No longer call
1578         complete_target_initialization.
1579         (target_supports_terminal_ours): Use regular delegation.
1580         (update_current_target): Delete.
1581         (push_target): No longer check magic number.  Don't call
1582         update_current_target.
1583         (unpush_target): Don't call update_current_target.
1584         (target_is_pushed): No longer check magic number.
1585         (target_require_runnable): Skip for all stratums over
1586         process_stratum.
1587         (target_ops::info_proc): New.
1588         (target_info_proc): Use find_target_at and
1589         find_default_run_target.
1590         (target_supports_disable_randomization): Use regular delegation.
1591         (target_get_osdata): Use find_target_at.
1592         (target_ops::open, target_ops::close, target_ops::can_attach)
1593         (target_ops::attach, target_ops::can_create_inferior)
1594         (target_ops::create_inferior, target_ops::can_run)
1595         (target_can_run): New.
1596         (default_fileio_target): Use regular delegation.
1597         (target_ops::fileio_open, target_ops::fileio_pwrite)
1598         (target_ops::fileio_pread, target_ops::fileio_fstat)
1599         (target_ops::fileio_close, target_ops::fileio_unlink)
1600         (target_ops::fileio_readlink): New.
1601         (target_fileio_open_1, target_fileio_unlink)
1602         (target_fileio_readlink): Always call the target method.  Handle
1603         FILEIO_ENOSYS.
1604         (return_zero, return_zero_has_execution): Delete.
1605         (init_dummy_target): Delete.
1606         (dummy_target::dummy_target, dummy_target::shortname)
1607         (dummy_target::longname, dummy_target::doc)
1608         (debug_target::debug_target, debug_target::shortname)
1609         (debug_target::longname, debug_target::doc): New.
1610         (target_supports_delete_record): Use regular delegation.
1611         (setup_target_debug): Delete.
1612         (maintenance_print_target_stack): Skip debug_stratum.
1613         (initialize_targets): Instantiate the_dummy_target and
1614         the_debug_target.
1615         * auxv.c (target_auxv_parse): Remove 'ops' parameter.  Adjust to
1616         use target_stack.
1617         (target_auxv_search, fprint_target_auxv): Adjust.
1618         (info_auxv_command): Adjust to use target_stack.
1619         * auxv.h (target_auxv_parse): Remove 'ops' parameter.
1620         * exceptions.c (print_flush): Handle a NULL target_stack.
1621         * regcache.c (target_ops_no_register): Refactor as class with
1622         virtual methods.
1623
1624         * exec.c (exec_target): New class.
1625         (exec_ops): Now an exec_target.
1626         (exec_open, exec_close_1, exec_get_section_table)
1627         (exec_xfer_partial, exec_files_info, exec_has_memory)
1628         (exec_make_note_section): Refactor as exec_target methods.
1629         (exec_file_clear, ignore, exec_remove_breakpoint, init_exec_ops):
1630         Delete.
1631         (exec_target::find_memory_regions): New.
1632         (_initialize_exec): Don't call init_exec_ops.
1633         * gdbcore.h (exec_file_clear): Delete.
1634
1635         * corefile.c (core_target): Delete.
1636         (core_file_command): Adjust.
1637         * corelow.c (core_target): New class.
1638         (the_core_target): New.
1639         (core_close): Remove target_ops parameter.
1640         (core_close_cleanup): Adjust.
1641         (core_target::close): New.
1642         (core_open, core_detach, get_core_registers, core_files_info)
1643         (core_xfer_partial, core_thread_alive, core_read_description)
1644         (core_pid_to_str, core_thread_name, core_has_memory)
1645         (core_has_stack, core_has_registers, core_info_proc): Rework as
1646         core_target methods.
1647         (ignore, core_remove_breakpoint, init_core_ops): Delete.
1648         (_initialize_corelow): Initialize the_core_target.
1649         * gdbcore.h (core_target): Delete.
1650         (the_core_target): New.
1651
1652         * ctf.c: (ctf_target): New class.
1653         (ctf_ops): Now a ctf_target.
1654         (ctf_open, ctf_close, ctf_files_info, ctf_fetch_registers)
1655         (ctf_xfer_partial, ctf_get_trace_state_variable_value)
1656         (ctf_trace_find, ctf_traceframe_info): Refactor as ctf_target
1657         methods.
1658         (init_ctf_ops): Delete.
1659         (_initialize_ctf): Don't call it.
1660         * tracefile-tfile.c (tfile_target): New class.
1661         (tfile_ops): Now a tfile_target.
1662         (tfile_open, tfile_close, tfile_files_info)
1663         (tfile_get_tracepoint_status, tfile_trace_find)
1664         (tfile_fetch_registers, tfile_xfer_partial)
1665         (tfile_get_trace_state_variable_value, tfile_traceframe_info):
1666         Refactor as tfile_target methods.
1667         (tfile_xfer_partial_features): Remove target_ops parameter.
1668         (init_tfile_ops): Delete.
1669         (_initialize_tracefile_tfile): Don't call it.
1670         * tracefile.c (tracefile_has_all_memory, tracefile_has_memory)
1671         (tracefile_has_stack, tracefile_has_registers)
1672         (tracefile_thread_alive, tracefile_get_trace_status): Refactor as
1673         tracefile_target methods.
1674         (init_tracefile_ops): Delete.
1675         (tracefile_target::tracefile_target): New.
1676         * tracefile.h: Include "target.h".
1677         (tracefile_target): New class.
1678         (init_tracefile_ops): Delete.
1679
1680         * spu-multiarch.c (spu_multiarch_target): New class.
1681         (spu_ops): Now a spu_multiarch_target.
1682         (spu_thread_architecture, spu_region_ok_for_hw_watchpoint)
1683         (spu_fetch_registers, spu_store_registers, spu_xfer_partial)
1684         (spu_search_memory, spu_mourn_inferior): Refactor as
1685         spu_multiarch_target methods.
1686         (init_spu_ops): Delete.
1687         (_initialize_spu_multiarch): Remove references to init_spu_ops,
1688         complete_target_initialization.
1689
1690         * ravenscar-thread.c (ravenscar_thread_target): New class.
1691         (ravenscar_ops): Now a ravenscar_thread_target.
1692         (ravenscar_resume, ravenscar_wait, ravenscar_update_thread_list)
1693         (ravenscar_thread_alive, ravenscar_pid_to_str)
1694         (ravenscar_fetch_registers, ravenscar_store_registers)
1695         (ravenscar_prepare_to_store, ravenscar_stopped_by_sw_breakpoint)
1696         (ravenscar_stopped_by_hw_breakpoint)
1697         (ravenscar_stopped_by_watchpoint, ravenscar_stopped_data_address)
1698         (ravenscar_mourn_inferior, ravenscar_core_of_thread)
1699         (ravenscar_get_ada_task_ptid): Refactor as ravenscar_thread_target
1700         methods.
1701         (init_ravenscar_thread_ops): Delete.
1702         (_initialize_ravenscar): Remove references to
1703         init_ravenscar_thread_ops and complete_target_initialization.
1704
1705         * bsd-uthread.c (bsd_uthread_ops_hack): Delete.
1706         (bsd_uthread_target): New class.
1707         (bsd_uthread_ops): Now a bsd_uthread_target.
1708         (bsd_uthread_activate): Adjust to refer to bsd_uthread_ops.
1709         (bsd_uthread_close, bsd_uthread_mourn_inferior)
1710         (bsd_uthread_fetch_registers, bsd_uthread_store_registers)
1711         (bsd_uthread_wait, bsd_uthread_resume, bsd_uthread_thread_alive)
1712         (bsd_uthread_update_thread_list, bsd_uthread_extra_thread_info)
1713         (bsd_uthread_pid_to_str): Refactor as bsd_uthread_target methods.
1714         (bsd_uthread_target): Delete function.
1715         (_initialize_bsd_uthread): Remove reference to
1716         complete_target_initialization.
1717
1718         * bfd-target.c (target_bfd_data): Delete.  Fields folded into ...
1719         (target_bfd): ... this new class.
1720         (target_bfd_xfer_partial, target_bfd_get_section_table)
1721         (target_bfd_close): Refactor as target_bfd methods.
1722         (target_bfd::~target_bfd): New.
1723         (target_bfd_reopen): Adjust.
1724         (target_bfd::close): New.
1725
1726         * record-btrace.c (record_btrace_target): New class.
1727         (record_btrace_ops): Now a record_btrace_target.
1728         (record_btrace_open, record_btrace_stop_recording)
1729         (record_btrace_disconnect, record_btrace_close)
1730         (record_btrace_async, record_btrace_info)
1731         (record_btrace_insn_history, record_btrace_insn_history_range)
1732         (record_btrace_insn_history_from, record_btrace_call_history)
1733         (record_btrace_call_history_range)
1734         (record_btrace_call_history_from, record_btrace_record_method)
1735         (record_btrace_is_replaying, record_btrace_will_replay)
1736         (record_btrace_xfer_partial, record_btrace_insert_breakpoint)
1737         (record_btrace_remove_breakpoint, record_btrace_fetch_registers)
1738         (record_btrace_store_registers, record_btrace_prepare_to_store)
1739         (record_btrace_to_get_unwinder)
1740         (record_btrace_to_get_tailcall_unwinder, record_btrace_resume)
1741         (record_btrace_commit_resume, record_btrace_wait)
1742         (record_btrace_stop, record_btrace_can_execute_reverse)
1743         (record_btrace_stopped_by_sw_breakpoint)
1744         (record_btrace_supports_stopped_by_sw_breakpoint)
1745         (record_btrace_stopped_by_hw_breakpoint)
1746         (record_btrace_supports_stopped_by_hw_breakpoint)
1747         (record_btrace_update_thread_list, record_btrace_thread_alive)
1748         (record_btrace_goto_begin, record_btrace_goto_end)
1749         (record_btrace_goto, record_btrace_stop_replaying_all)
1750         (record_btrace_execution_direction)
1751         (record_btrace_prepare_to_generate_core)
1752         (record_btrace_done_generating_core): Refactor as
1753         record_btrace_target methods.
1754         (init_record_btrace_ops): Delete.
1755         (_initialize_record_btrace): Remove reference to
1756         init_record_btrace_ops.
1757         * record-full.c (RECORD_FULL_IS_REPLAY): Adjust to always refer to
1758         the execution_direction global.
1759         (record_full_base_target, record_full_target)
1760         (record_full_core_target): New classes.
1761         (record_full_ops): Now a record_full_target.
1762         (record_full_core_ops): Now a record_full_core_target.
1763         (record_full_target::detach, record_full_target::disconnect)
1764         (record_full_core_target::disconnect)
1765         (record_full_target::mourn_inferior, record_full_target::kill):
1766         New.
1767         (record_full_open, record_full_close, record_full_async): Refactor
1768         as methods of the record_full_base_target class.
1769         (record_full_resume, record_full_commit_resume): Refactor
1770         as methods of the record_full_target class.
1771         (record_full_wait, record_full_stopped_by_watchpoint)
1772         (record_full_stopped_data_address)
1773         (record_full_stopped_by_sw_breakpoint)
1774         (record_full_supports_stopped_by_sw_breakpoint)
1775         (record_full_stopped_by_hw_breakpoint)
1776         (record_full_supports_stopped_by_hw_breakpoint): Refactor as
1777         methods of the record_full_base_target class.
1778         (record_full_store_registers, record_full_xfer_partial)
1779         (record_full_insert_breakpoint, record_full_remove_breakpoint):
1780         Refactor as methods of the record_full_target class.
1781         (record_full_can_execute_reverse, record_full_get_bookmark)
1782         (record_full_goto_bookmark, record_full_execution_direction)
1783         (record_full_record_method, record_full_info, record_full_delete)
1784         (record_full_is_replaying, record_full_will_replay)
1785         (record_full_goto_begin, record_full_goto_end, record_full_goto)
1786         (record_full_stop_replaying): Refactor as methods of the
1787         record_full_base_target class.
1788         (record_full_core_resume, record_full_core_kill)
1789         (record_full_core_fetch_registers)
1790         (record_full_core_prepare_to_store)
1791         (record_full_core_store_registers, record_full_core_xfer_partial)
1792         (record_full_core_insert_breakpoint)
1793         (record_full_core_remove_breakpoint)
1794         (record_full_core_has_execution): Refactor
1795         as methods of the record_full_core_target class.
1796         (record_full_base_target::supports_delete_record): New.
1797         (init_record_full_ops): Delete.
1798         (init_record_full_core_ops): Delete.
1799         (record_full_save): Refactor as method of the
1800         record_full_base_target class.
1801         (_initialize_record_full): Remove references to
1802         init_record_full_ops and init_record_full_core_ops.
1803
1804         * remote.c (remote_target, extended_remote_target): New classes.
1805         (remote_ops): Now a remote_target.
1806         (extended_remote_ops): Now an extended_remote_target.
1807         (remote_insert_fork_catchpoint, remote_remove_fork_catchpoint)
1808         (remote_insert_vfork_catchpoint, remote_remove_vfork_catchpoint)
1809         (remote_insert_exec_catchpoint, remote_remove_exec_catchpoint)
1810         (remote_pass_signals, remote_set_syscall_catchpoint)
1811         (remote_program_signals, )
1812         (remote_thread_always_alive): Remove target_ops parameter.
1813         (remote_thread_alive, remote_thread_name)
1814         (remote_update_thread_list, remote_threads_extra_info)
1815         (remote_static_tracepoint_marker_at)
1816         (remote_static_tracepoint_markers_by_strid)
1817         (remote_get_ada_task_ptid, remote_close, remote_start_remote)
1818         (remote_open): Refactor as methods of remote_target.
1819         (extended_remote_open, extended_remote_detach)
1820         (extended_remote_attach, extended_remote_post_attach):
1821         (extended_remote_supports_disable_randomization)
1822         (extended_remote_create_inferior): : Refactor as method of
1823         extended_remote_target.
1824         (remote_set_permissions, remote_open_1, remote_detach)
1825         (remote_follow_fork, remote_follow_exec, remote_disconnect)
1826         (remote_resume, remote_commit_resume, remote_stop)
1827         (remote_interrupt, remote_pass_ctrlc, remote_terminal_inferior)
1828         (remote_terminal_ours, remote_wait, remote_fetch_registers)
1829         (remote_prepare_to_store, remote_store_registers)
1830         (remote_flash_erase, remote_flash_done, remote_files_info)
1831         (remote_kill, remote_mourn, remote_insert_breakpoint)
1832         (remote_remove_breakpoint, remote_insert_watchpoint)
1833         (remote_watchpoint_addr_within_range)
1834         (remote_remove_watchpoint, remote_region_ok_for_hw_watchpoint)
1835         (remote_check_watch_resources, remote_stopped_by_sw_breakpoint)
1836         (remote_supports_stopped_by_sw_breakpoint)
1837         (remote_stopped_by_hw_breakpoint)
1838         (remote_supports_stopped_by_hw_breakpoint)
1839         (remote_stopped_by_watchpoint, remote_stopped_data_address)
1840         (remote_insert_hw_breakpoint, remote_remove_hw_breakpoint)
1841         (remote_verify_memory): Refactor as methods of remote_target.
1842         (remote_write_qxfer, remote_read_qxfer): Remove target_ops
1843         parameter.
1844         (remote_xfer_partial, remote_get_memory_xfer_limit)
1845         (remote_search_memory, remote_rcmd, remote_memory_map)
1846         (remote_pid_to_str, remote_get_thread_local_address)
1847         (remote_get_tib_address, remote_read_description): Refactor as
1848         methods of remote_target.
1849         (remote_target::fileio_open, remote_target::fileio_pwrite)
1850         (remote_target::fileio_pread, remote_target::fileio_close): New.
1851         (remote_hostio_readlink, remote_hostio_fstat)
1852         (remote_filesystem_is_local, remote_can_execute_reverse)
1853         (remote_supports_non_stop, remote_supports_disable_randomization)
1854         (remote_supports_multi_process, remote_supports_cond_breakpoints)
1855         (remote_supports_enable_disable_tracepoint)
1856         (remote_supports_string_tracing)
1857         (remote_can_run_breakpoint_commands, remote_trace_init)
1858         (remote_download_tracepoint, remote_can_download_tracepoint)
1859         (remote_download_trace_state_variable, remote_enable_tracepoint)
1860         (remote_disable_tracepoint, remote_trace_set_readonly_regions)
1861         (remote_trace_start, remote_get_trace_status)
1862         (remote_get_tracepoint_status, remote_trace_stop)
1863         (remote_trace_find, remote_get_trace_state_variable_value)
1864         (remote_save_trace_data, remote_get_raw_trace_data)
1865         (remote_set_disconnected_tracing, remote_core_of_thread)
1866         (remote_set_circular_trace_buffer, remote_traceframe_info)
1867         (remote_get_min_fast_tracepoint_insn_len)
1868         (remote_set_trace_buffer_size, remote_set_trace_notes)
1869         (remote_use_agent, remote_can_use_agent, remote_enable_btrace)
1870         (remote_disable_btrace, remote_teardown_btrace)
1871         (remote_read_btrace, remote_btrace_conf)
1872         (remote_augmented_libraries_svr4_read, remote_load)
1873         (remote_pid_to_exec_file, remote_can_do_single_step)
1874         (remote_execution_direction, remote_thread_handle_to_thread_info):
1875         Refactor as methods of remote_target.
1876         (init_remote_ops, init_extended_remote_ops): Delete.
1877         (remote_can_async_p, remote_is_async_p, remote_async)
1878         (remote_thread_events, remote_upload_tracepoints)
1879         (remote_upload_trace_state_variables): Refactor as methods of
1880         remote_target.
1881         (_initialize_remote): Remove references to init_remote_ops and
1882         init_extended_remote_ops.
1883
1884         * remote-sim.c (gdbsim_target): New class.
1885         (gdbsim_fetch_register, gdbsim_store_register, gdbsim_kill)
1886         (gdbsim_load, gdbsim_create_inferior, gdbsim_open, gdbsim_close)
1887         (gdbsim_detach, gdbsim_resume, gdbsim_interrupt)
1888         (gdbsim_wait, gdbsim_prepare_to_store, gdbsim_xfer_partial)
1889         (gdbsim_files_info, gdbsim_mourn_inferior, gdbsim_thread_alive)
1890         (gdbsim_pid_to_str, gdbsim_has_all_memory, gdbsim_has_memory):
1891         Refactor as methods of gdbsim_target.
1892         (gdbsim_ops): Now a gdbsim_target.
1893         (init_gdbsim_ops): Delete.
1894         (gdbsim_cntrl_c): Adjust.
1895         (_initialize_remote_sim): Remove reference to init_gdbsim_ops.
1896
1897         * amd64-linux-nat.c (amd64_linux_nat_target): New class.
1898         (the_amd64_linux_nat_target): New.
1899         (amd64_linux_fetch_inferior_registers)
1900         (amd64_linux_store_inferior_registers): Refactor as methods of
1901         amd64_linux_nat_target.
1902         (_initialize_amd64_linux_nat): Adjust.  Set linux_target.
1903         * i386-linux-nat.c: Don't include "linux-nat.h".
1904         (i386_linux_nat_target): New class.
1905         (the_i386_linux_nat_target): New.
1906         (i386_linux_fetch_inferior_registers)
1907         (i386_linux_store_inferior_registers, i386_linux_resume): Refactor
1908         as methods of i386_linux_nat_target.
1909         (_initialize_i386_linux_nat): Adjust.  Set linux_target.
1910         * inf-child.c (inf_child_ops): Delete.
1911         (inf_child_fetch_inferior_registers)
1912         (inf_child_store_inferior_registers): Delete.
1913         (inf_child_post_attach, inf_child_prepare_to_store): Refactor as
1914         methods of inf_child_target.
1915         (inf_child_target::supports_terminal_ours)
1916         (inf_child_target::terminal_init)
1917         (inf_child_target::terminal_inferior)
1918         (inf_child_target::terminal_ours_for_output)
1919         (inf_child_target::terminal_ours, inf_child_target::interrupt)
1920         (inf_child_target::pass_ctrlc, inf_child_target::terminal_info):
1921         New.
1922         (inf_child_open, inf_child_disconnect, inf_child_close)
1923         (inf_child_mourn_inferior, inf_child_maybe_unpush_target)
1924         (inf_child_post_startup_inferior, inf_child_can_run)
1925         (inf_child_pid_to_exec_file): Refactor as methods of
1926         inf_child_target.
1927         (inf_child_follow_fork): Delete.
1928         (inf_child_target::can_create_inferior)
1929         (inf_child_target::can_attach): New.
1930         (inf_child_target::has_all_memory, inf_child_target::has_memory)
1931         (inf_child_target::has_stack, inf_child_target::has_registers)
1932         (inf_child_target::has_execution): New.
1933         (inf_child_fileio_open, inf_child_fileio_pwrite)
1934         (inf_child_fileio_pread, inf_child_fileio_fstat)
1935         (inf_child_fileio_close, inf_child_fileio_unlink)
1936         (inf_child_fileio_readlink, inf_child_use_agent)
1937         (inf_child_can_use_agent): Refactor as methods of
1938         inf_child_target.
1939         (return_zero, inf_child_target): Delete.
1940         (inf_child_target::inf_child_target): New.
1941         * inf-child.h: Include "target.h".
1942         (inf_child_target): Delete function prototype.
1943         (inf_child_target): New class.
1944         (inf_child_open_target, inf_child_mourn_inferior)
1945         (inf_child_maybe_unpush_target): Delete.
1946         * inf-ptrace.c (inf_ptrace_target::~inf_ptrace_target): New.
1947         (inf_ptrace_follow_fork, inf_ptrace_insert_fork_catchpoint)
1948         (inf_ptrace_remove_fork_catchpoint, inf_ptrace_create_inferior)
1949         (inf_ptrace_post_startup_inferior, inf_ptrace_mourn_inferior)
1950         (inf_ptrace_attach, inf_ptrace_post_attach, inf_ptrace_detach)
1951         (inf_ptrace_detach_success, inf_ptrace_kill, inf_ptrace_resume)
1952         (inf_ptrace_wait, inf_ptrace_xfer_partial)
1953         (inf_ptrace_thread_alive, inf_ptrace_files_info)
1954         (inf_ptrace_pid_to_str, inf_ptrace_auxv_parse): Refactor as
1955         methods of inf_ptrace_target.
1956         (inf_ptrace_target): Delete function.
1957         * inf-ptrace.h: Include "inf-child.h".
1958         (inf_ptrace_target): Delete function declaration.
1959         (inf_ptrace_target): New class.
1960         (inf_ptrace_trad_target, inf_ptrace_detach_success): Delete.
1961         * linux-nat.c (linux_target): New.
1962         (linux_ops, linux_ops_saved, super_xfer_partial): Delete.
1963         (linux_nat_target::~linux_nat_target): New.
1964         (linux_child_post_attach, linux_child_post_startup_inferior)
1965         (linux_child_follow_fork, linux_child_insert_fork_catchpoint)
1966         (linux_child_remove_fork_catchpoint)
1967         (linux_child_insert_vfork_catchpoint)
1968         (linux_child_remove_vfork_catchpoint)
1969         (linux_child_insert_exec_catchpoint)
1970         (linux_child_remove_exec_catchpoint)
1971         (linux_child_set_syscall_catchpoint, linux_nat_pass_signals)
1972         (linux_nat_create_inferior, linux_nat_attach, linux_nat_detach)
1973         (linux_nat_resume, linux_nat_stopped_by_watchpoint)
1974         (linux_nat_stopped_data_address)
1975         (linux_nat_stopped_by_sw_breakpoint)
1976         (linux_nat_supports_stopped_by_sw_breakpoint)
1977         (linux_nat_stopped_by_hw_breakpoint)
1978         (linux_nat_supports_stopped_by_hw_breakpoint, linux_nat_wait)
1979         (linux_nat_kill, linux_nat_mourn_inferior)
1980         (linux_nat_xfer_partial, linux_nat_thread_alive)
1981         (linux_nat_update_thread_list, linux_nat_pid_to_str)
1982         (linux_nat_thread_name, linux_child_pid_to_exec_file)
1983         (linux_child_static_tracepoint_markers_by_strid)
1984         (linux_nat_is_async_p, linux_nat_can_async_p)
1985         (linux_nat_supports_non_stop, linux_nat_always_non_stop_p)
1986         (linux_nat_supports_multi_process)
1987         (linux_nat_supports_disable_randomization, linux_nat_async)
1988         (linux_nat_stop, linux_nat_close, linux_nat_thread_address_space)
1989         (linux_nat_core_of_thread, linux_nat_filesystem_is_local)
1990         (linux_nat_fileio_open, linux_nat_fileio_readlink)
1991         (linux_nat_fileio_unlink, linux_nat_thread_events): Refactor as
1992         methods of linux_nat_target.
1993         (linux_nat_wait_1, linux_xfer_siginfo, linux_proc_xfer_partial)
1994         (linux_proc_xfer_spu, linux_nat_xfer_osdata): Remove target_ops
1995         parameter.
1996         (check_stopped_by_watchpoint): Adjust.
1997         (linux_xfer_partial): Delete.
1998         (linux_target_install_ops, linux_target, linux_nat_add_target):
1999         Delete.
2000         (linux_nat_target::linux_nat_target): New.
2001         * linux-nat.h: Include "inf-ptrace.h".
2002         (linux_nat_target): New.
2003         (linux_target, linux_target_install_ops, linux_nat_add_target):
2004         Delete function declarations.
2005         (linux_target): Declare global.
2006         * linux-thread-db.c (thread_db_target): New.
2007         (thread_db_target::thread_db_target): New.
2008         (thread_db_ops): Delete.
2009         (the_thread_db_target): New.
2010         (thread_db_detach, thread_db_wait, thread_db_mourn_inferior)
2011         (thread_db_update_thread_list, thread_db_pid_to_str)
2012         (thread_db_extra_thread_info)
2013         (thread_db_thread_handle_to_thread_info)
2014         (thread_db_get_thread_local_address, thread_db_get_ada_task_ptid)
2015         (thread_db_resume): Refactor as methods of thread_db_target.
2016         (init_thread_db_ops): Delete.
2017         (_initialize_thread_db): Remove reference to init_thread_db_ops.
2018         * x86-linux-nat.c: Don't include "linux-nat.h".
2019         (super_post_startup_inferior): Delete.
2020         (x86_linux_nat_target::~x86_linux_nat_target): New.
2021         (x86_linux_child_post_startup_inferior)
2022         (x86_linux_read_description, x86_linux_enable_btrace)
2023         (x86_linux_disable_btrace, x86_linux_teardown_btrace)
2024         (x86_linux_read_btrace, x86_linux_btrace_conf): Refactor as
2025         methods of x86_linux_nat_target.
2026         (x86_linux_create_target): Delete.  Bits folded ...
2027         (x86_linux_add_target): ... here.  Now takes a linux_nat_target
2028         pointer.
2029         * x86-linux-nat.h: Include "linux-nat.h" and "x86-nat.h".
2030         (x86_linux_nat_target): New class.
2031         (x86_linux_create_target): Delete.
2032         (x86_linux_add_target): Now takes a linux_nat_target pointer.
2033         * x86-nat.c (x86_insert_watchpoint, x86_remove_watchpoint)
2034         (x86_region_ok_for_watchpoint, x86_stopped_data_address)
2035         (x86_stopped_by_watchpoint, x86_insert_hw_breakpoint)
2036         (x86_remove_hw_breakpoint, x86_can_use_hw_breakpoint)
2037         (x86_stopped_by_hw_breakpoint): Remove target_ops parameter and
2038         make extern.
2039         (x86_use_watchpoints): Delete.
2040         * x86-nat.h: Include "breakpoint.h" and "target.h".
2041         (x86_use_watchpoints): Delete.
2042         (x86_can_use_hw_breakpoint, x86_region_ok_for_hw_watchpoint)
2043         (x86_stopped_by_watchpoint, x86_stopped_data_address)
2044         (x86_insert_watchpoint, x86_remove_watchpoint)
2045         (x86_insert_hw_breakpoint, x86_remove_hw_breakpoint)
2046         (x86_stopped_by_hw_breakpoint): New declarations.
2047         (x86_nat_target): New template class.
2048
2049         * ppc-linux-nat.c (ppc_linux_nat_target): New class.
2050         (the_ppc_linux_nat_target): New.
2051         (ppc_linux_fetch_inferior_registers)
2052         (ppc_linux_can_use_hw_breakpoint)
2053         (ppc_linux_region_ok_for_hw_watchpoint)
2054         (ppc_linux_ranged_break_num_registers)
2055         (ppc_linux_insert_hw_breakpoint, ppc_linux_remove_hw_breakpoint)
2056         (ppc_linux_insert_mask_watchpoint)
2057         (ppc_linux_remove_mask_watchpoint)
2058         (ppc_linux_can_accel_watchpoint_condition)
2059         (ppc_linux_insert_watchpoint, ppc_linux_remove_watchpoint)
2060         (ppc_linux_stopped_data_address, ppc_linux_stopped_by_watchpoint)
2061         (ppc_linux_watchpoint_addr_within_range)
2062         (ppc_linux_masked_watch_num_registers)
2063         (ppc_linux_store_inferior_registers, ppc_linux_auxv_parse)
2064         (ppc_linux_read_description): Refactor as methods of
2065         ppc_linux_nat_target.
2066         (_initialize_ppc_linux_nat): Adjust.  Set linux_target.
2067
2068         * procfs.c (procfs_xfer_partial): Delete forward declaration.
2069         (procfs_target): New class.
2070         (the_procfs_target): New.
2071         (procfs_target): Delete function.
2072         (procfs_auxv_parse, procfs_attach, procfs_detach)
2073         (procfs_fetch_registers, procfs_store_registers, procfs_wait)
2074         (procfs_xfer_partial, procfs_resume, procfs_pass_signals)
2075         (procfs_files_info, procfs_kill_inferior, procfs_mourn_inferior)
2076         (procfs_create_inferior, procfs_update_thread_list)
2077         (procfs_thread_alive, procfs_pid_to_str)
2078         (procfs_can_use_hw_breakpoint, procfs_stopped_by_watchpoint)
2079         (procfs_stopped_data_address, procfs_insert_watchpoint)
2080         (procfs_remove_watchpoint, procfs_region_ok_for_hw_watchpoint)
2081         (proc_find_memory_regions, procfs_info_proc)
2082         (procfs_make_note_section): Refactor as methods of procfs_target.
2083         (_initialize_procfs): Adjust.
2084         * sol-thread.c (sol_thread_target): New class.
2085         (sol_thread_ops): Now a sol_thread_target.
2086         (sol_thread_detach, sol_thread_resume, sol_thread_wait)
2087         (sol_thread_fetch_registers, sol_thread_store_registers)
2088         (sol_thread_xfer_partial, sol_thread_mourn_inferior)
2089         (sol_thread_alive, solaris_pid_to_str, sol_update_thread_list)
2090         (sol_get_ada_task_ptid): Refactor as methods of sol_thread_target.
2091         (init_sol_thread_ops): Delete.
2092         (_initialize_sol_thread): Adjust.  Remove references to
2093         init_sol_thread_ops and complete_target_initialization.
2094
2095         * windows-nat.c (windows_nat_target): New class.
2096         (windows_fetch_inferior_registers)
2097         (windows_store_inferior_registers, windows_resume, windows_wait)
2098         (windows_attach, windows_detach, windows_pid_to_exec_file)
2099         (windows_files_info, windows_create_inferior)
2100         (windows_mourn_inferior, windows_interrupt, windows_kill_inferior)
2101         (windows_close, windows_pid_to_str, windows_xfer_partial)
2102         (windows_get_tib_address, windows_get_ada_task_ptid)
2103         (windows_thread_name, windows_thread_alive): Refactor as
2104         windows_nat_target methods.
2105         (do_initial_windows_stuff): Adjust.
2106         (windows_target): Delete function.
2107         (_initialize_windows_nat): Adjust.
2108
2109         * darwin-nat.c (darwin_resume, darwin_wait_to, darwin_interrupt)
2110         (darwin_mourn_inferior, darwin_kill_inferior)
2111         (darwin_create_inferior, darwin_attach, darwin_detach)
2112         (darwin_pid_to_str, darwin_thread_alive, darwin_xfer_partial)
2113         (darwin_pid_to_exec_file, darwin_get_ada_task_ptid)
2114         (darwin_supports_multi_process): Refactor as darwin_nat_target
2115         methods.
2116         (darwin_resume_to, darwin_files_info): Delete.
2117         (_initialize_darwin_inferior): Rename to ...
2118         (_initialize_darwin_nat): ... this.  Adjust to C++ification.
2119         * darwin-nat.h: Include "inf-child.h".
2120         (darwin_nat_target): New class.
2121         (darwin_complete_target): Delete.
2122         * i386-darwin-nat.c (i386_darwin_nat_target): New class.
2123         (darwin_target): New.
2124         (i386_darwin_fetch_inferior_registers)
2125         (i386_darwin_store_inferior_registers): Refactor as methods of
2126         darwin_nat_target.
2127         (darwin_complete_target): Delete, with ...
2128         (_initialize_i386_darwin_nat): ... bits factored out here.
2129
2130         * alpha-linux-nat.c (alpha_linux_nat_target): New class.
2131         (the_alpha_linux_nat_target): New.
2132         (alpha_linux_register_u_offset): Refactor as
2133         alpha_linux_nat_target method.
2134         (_initialize_alpha_linux_nat): Adjust.
2135         * linux-nat-trad.c (inf_ptrace_register_u_offset): Delete.
2136         (inf_ptrace_fetch_register, inf_ptrace_fetch_registers)
2137         (inf_ptrace_store_register, inf_ptrace_store_registers): Refact as
2138         methods of linux_nat_trad_target.
2139         (linux_trad_target): Delete.
2140         * linux-nat-trad.h (linux_trad_target): Delete function.
2141         (linux_nat_trad_target): New class.
2142         * mips-linux-nat.c (mips_linux_nat_target): New class.
2143         (super_fetch_registers, super_store_registers, super_close):
2144         Delete.
2145         (the_mips_linux_nat_target): New.
2146         (mips64_linux_regsets_fetch_registers)
2147         (mips64_linux_regsets_store_registers)
2148         (mips64_linux_fetch_registers, mips64_linux_store_registers)
2149         (mips_linux_register_u_offset, mips_linux_read_description)
2150         (mips_linux_can_use_hw_breakpoint)
2151         (mips_linux_stopped_by_watchpoint)
2152         (mips_linux_stopped_data_address)
2153         (mips_linux_region_ok_for_hw_watchpoint)
2154         (mips_linux_insert_watchpoint, mips_linux_remove_watchpoint)
2155         (mips_linux_close): Refactor as methods of mips_linux_nat.
2156         (_initialize_mips_linux_nat): Adjust to C++ification.
2157
2158         * aix-thread.c (aix_thread_target): New class.
2159         (aix_thread_ops): Now an aix_thread_target.
2160         (aix_thread_detach, aix_thread_resume, aix_thread_wait)
2161         (aix_thread_fetch_registers, aix_thread_store_registers)
2162         (aix_thread_xfer_partial, aix_thread_mourn_inferior)
2163         (aix_thread_thread_alive, aix_thread_pid_to_str)
2164         (aix_thread_extra_thread_info, aix_thread_get_ada_task_ptid):
2165         Refactor as methods of aix_thread_target.
2166         (init_aix_thread_ops): Delete.
2167         (_initialize_aix_thread): Remove references to init_aix_thread_ops
2168         and complete_target_initialization.
2169         * rs6000-nat.c (rs6000_xfer_shared_libraries): Delete.
2170         (rs6000_nat_target): New class.
2171         (the_rs6000_nat_target): New.
2172         (rs6000_fetch_inferior_registers, rs6000_store_inferior_registers)
2173         (rs6000_xfer_partial, rs6000_wait, rs6000_create_inferior)
2174         (rs6000_xfer_shared_libraries): Refactor as rs6000_nat_target methods.
2175         (super_create_inferior): Delete.
2176         (_initialize_rs6000_nat): Adjust to C++ification.
2177
2178         * arm-linux-nat.c (arm_linux_nat_target): New class.
2179         (the_arm_linux_nat_target): New.
2180         (arm_linux_fetch_inferior_registers)
2181         (arm_linux_store_inferior_registers, arm_linux_read_description)
2182         (arm_linux_can_use_hw_breakpoint, arm_linux_insert_hw_breakpoint)
2183         (arm_linux_remove_hw_breakpoint)
2184         (arm_linux_region_ok_for_hw_watchpoint)
2185         (arm_linux_insert_watchpoint, arm_linux_remove_watchpoint)
2186         (arm_linux_stopped_data_address, arm_linux_stopped_by_watchpoint)
2187         (arm_linux_watchpoint_addr_within_range): Refactor as methods of
2188         arm_linux_nat_target.
2189         (_initialize_arm_linux_nat): Adjust to C++ification.
2190
2191         * aarch64-linux-nat.c (aarch64_linux_nat_target): New class.
2192         (the_aarch64_linux_nat_target): New.
2193         (aarch64_linux_fetch_inferior_registers)
2194         (aarch64_linux_store_inferior_registers)
2195         (aarch64_linux_child_post_startup_inferior)
2196         (aarch64_linux_read_description)
2197         (aarch64_linux_can_use_hw_breakpoint)
2198         (aarch64_linux_insert_hw_breakpoint)
2199         (aarch64_linux_remove_hw_breakpoint)
2200         (aarch64_linux_insert_watchpoint, aarch64_linux_remove_watchpoint)
2201         (aarch64_linux_region_ok_for_hw_watchpoint)
2202         (aarch64_linux_stopped_data_address)
2203         (aarch64_linux_stopped_by_watchpoint)
2204         (aarch64_linux_watchpoint_addr_within_range)
2205         (aarch64_linux_can_do_single_step): Refactor as methods of
2206         aarch64_linux_nat_target.
2207         (super_post_startup_inferior): Delete.
2208         (_initialize_aarch64_linux_nat): Adjust to C++ification.
2209
2210         * hppa-linux-nat.c (hppa_linux_nat_target): New class.
2211         (the_hppa_linux_nat_target): New.
2212         (hppa_linux_fetch_inferior_registers)
2213         (hppa_linux_store_inferior_registers): Refactor as methods of
2214         hppa_linux_nat_target.
2215         (_initialize_hppa_linux_nat): Adjust to C++ification.
2216
2217         * ia64-linux-nat.c (ia64_linux_nat_target): New class.
2218         (the_ia64_linux_nat_target): New.
2219         (ia64_linux_insert_watchpoint, ia64_linux_remove_watchpoint)
2220         (ia64_linux_stopped_data_address)
2221         (ia64_linux_stopped_by_watchpoint, ia64_linux_fetch_registers)
2222         (ia64_linux_store_registers, ia64_linux_xfer_partial): Refactor as
2223         ia64_linux_nat_target methods.
2224         (super_xfer_partial): Delete.
2225         (_initialize_ia64_linux_nat): Adjust to C++ification.
2226
2227         * m32r-linux-nat.c (m32r_linux_nat_target): New class.
2228         (the_m32r_linux_nat_target): New.
2229         (m32r_linux_fetch_inferior_registers)
2230         (m32r_linux_store_inferior_registers): Refactor as
2231         m32r_linux_nat_target methods.
2232         (_initialize_m32r_linux_nat): Adjust to C++ification.
2233
2234         * m68k-linux-nat.c (m68k_linux_nat_target): New class.
2235         (the_m68k_linux_nat_target): New.
2236         (m68k_linux_fetch_inferior_registers)
2237         (m68k_linux_store_inferior_registers): Refactor as
2238         m68k_linux_nat_target methods.
2239         (_initialize_m68k_linux_nat): Adjust to C++ification.
2240
2241         * s390-linux-nat.c (s390_linux_nat_target): New class.
2242         (the_s390_linux_nat_target): New.
2243         (s390_linux_fetch_inferior_registers)
2244         (s390_linux_store_inferior_registers, s390_stopped_by_watchpoint)
2245         (s390_insert_watchpoint, s390_remove_watchpoint)
2246         (s390_can_use_hw_breakpoint, s390_insert_hw_breakpoint)
2247         (s390_remove_hw_breakpoint, s390_region_ok_for_hw_watchpoint)
2248         (s390_auxv_parse, s390_read_description): Refactor as methods of
2249         s390_linux_nat_target.
2250         (_initialize_s390_nat): Adjust to C++ification.
2251
2252         * sparc-linux-nat.c (sparc_linux_nat_target): New class.
2253         (the_sparc_linux_nat_target): New.
2254         (_initialize_sparc_linux_nat): Adjust to C++ification.
2255         * sparc-nat.c (sparc_fetch_inferior_registers)
2256         (sparc_store_inferior_registers): Remove target_ops parameter.
2257         * sparc-nat.h (sparc_fetch_inferior_registers)
2258         (sparc_store_inferior_registers): Remove target_ops parameter.
2259         * sparc64-linux-nat.c (sparc64_linux_nat_target): New class.
2260         (the_sparc64_linux_nat_target): New.
2261         (_initialize_sparc64_linux_nat): Adjust to C++ification.
2262
2263         * spu-linux-nat.c (spu_linux_nat_target): New class.
2264         (the_spu_linux_nat_target): New.
2265         (spu_child_post_startup_inferior, spu_child_post_attach)
2266         (spu_child_wait, spu_fetch_inferior_registers)
2267         (spu_store_inferior_registers, spu_xfer_partial)
2268         (spu_can_use_hw_breakpoint): Refactor as spu_linux_nat_target
2269         methods.
2270         (_initialize_spu_nat): Adjust to C++ification.
2271
2272         * tilegx-linux-nat.c (tilegx_linux_nat_target): New class.
2273         (the_tilegx_linux_nat_target): New.
2274         (fetch_inferior_registers, store_inferior_registers):
2275         Refactor as methods.
2276         (_initialize_tile_linux_nat): Adjust to C++ification.
2277
2278         * xtensa-linux-nat.c (xtensa_linux_nat_target): New class.
2279         (the_xtensa_linux_nat_target): New.
2280         (xtensa_linux_fetch_inferior_registers)
2281         (xtensa_linux_store_inferior_registers): Refactor as
2282         xtensa_linux_nat_target methods.
2283         (_initialize_xtensa_linux_nat): Adjust to C++ification.
2284
2285         * fbsd-nat.c (USE_SIGTRAP_SIGINFO): Delete.
2286         (fbsd_pid_to_exec_file, fbsd_find_memory_regions)
2287         (fbsd_find_memory_regions, fbsd_info_proc, fbsd_xfer_partial)
2288         (fbsd_thread_alive, fbsd_pid_to_str, fbsd_thread_name)
2289         (fbsd_update_thread_list, fbsd_resume, fbsd_wait)
2290         (fbsd_stopped_by_sw_breakpoint)
2291         (fbsd_supports_stopped_by_sw_breakpoint, fbsd_follow_fork)
2292         (fbsd_insert_fork_catchpoint, fbsd_remove_fork_catchpoint)
2293         (fbsd_insert_vfork_catchpoint, fbsd_remove_vfork_catchpoint)
2294         (fbsd_post_startup_inferior, fbsd_post_attach)
2295         (fbsd_insert_exec_catchpoint, fbsd_remove_exec_catchpoint)
2296         (fbsd_set_syscall_catchpoint)
2297         (super_xfer_partial, super_resume, super_wait)
2298         (fbsd_supports_stopped_by_hw_breakpoint): Delete.
2299         (fbsd_handle_debug_trap): Remove target_ops parameter.
2300         (fbsd_nat_add_target): Delete.
2301         * fbsd-nat.h: Include "inf-ptrace.h".
2302         (fbsd_nat_add_target): Delete.
2303         (USE_SIGTRAP_SIGINFO): Define.
2304         (fbsd_nat_target): New class.
2305
2306         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers)
2307         (amd64bsd_store_inferior_registers): Remove target_ops parameter.
2308         (amd64bsd_target): Delete.
2309         * amd64-bsd-nat.h: New file.
2310         * amd64-fbsd-nat.c: Include "amd64-bsd-nat.h" instead of
2311         "x86-bsd-nat.h".
2312         (amd64_fbsd_nat_target): New class.
2313         (the_amd64_fbsd_nat_target): New.
2314         (amd64fbsd_read_description): Refactor as method of
2315         amd64_fbsd_nat_target.
2316         (amd64_fbsd_nat_target::supports_stopped_by_hw_breakpoint): New.
2317         (_initialize_amd64fbsd_nat): Adjust to C++ification.
2318         * amd64-nat.h (amd64bsd_target): Delete function declaration.
2319         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers)
2320         (i386bsd_store_inferior_registers): Remove target_ops parameter.
2321         (i386bsd_target): Delete.
2322         * i386-bsd-nat.h (i386bsd_target): Delete function declaration.
2323         (i386bsd_fetch_inferior_registers)
2324         (i386bsd_store_inferior_registers): Declare.
2325         (i386_bsd_nat_target): New class.
2326         * i386-fbsd-nat.c (i386_fbsd_nat_target): New class.
2327         (the_i386_fbsd_nat_target): New.
2328         (i386fbsd_resume, i386fbsd_read_description): Refactor as
2329         i386_fbsd_nat_target methods.
2330         (i386_fbsd_nat_target::supports_stopped_by_hw_breakpoint): New.
2331         (_initialize_i386fbsd_nat): Adjust to C++ification.
2332         * x86-bsd-nat.c (super_mourn_inferior): Delete.
2333         (x86bsd_mourn_inferior, x86bsd_target): Delete.
2334         (_initialize_x86_bsd_nat): Adjust to C++ification.
2335         * x86-bsd-nat.h: Include "x86-nat.h".
2336         (x86bsd_target): Delete declaration.
2337         (x86bsd_nat_target): New class.
2338
2339         * aarch64-fbsd-nat.c (aarch64_fbsd_nat_target): New class.
2340         (the_aarch64_fbsd_nat_target): New.
2341         (aarch64_fbsd_fetch_inferior_registers)
2342         (aarch64_fbsd_store_inferior_registers): Refactor as methods of
2343         aarch64_fbsd_nat_target.
2344         (_initialize_aarch64_fbsd_nat): Adjust to C++ification.
2345         * alpha-bsd-nat.c (alpha_bsd_nat_target): New class.
2346         (the_alpha_bsd_nat_target): New.
2347         (alphabsd_fetch_inferior_registers)
2348         (alphabsd_store_inferior_registers): Refactor as
2349         alpha_bsd_nat_target methods.
2350         (_initialize_alphabsd_nat): Refactor as methods of
2351         alpha_bsd_nat_target.
2352         * amd64-nbsd-nat.c: Include "amd64-bsd-nat.h".
2353         (the_amd64_nbsd_nat_target): New.
2354         (_initialize_amd64nbsd_nat): Adjust to C++ification.
2355         * amd64-obsd-nat.c: Include "amd64-bsd-nat.h".
2356         (the_amd64_obsd_nat_target): New.
2357         (_initialize_amd64obsd_nat): Adjust to C++ification.
2358         * arm-fbsd-nat.c (arm_fbsd_nat_target): New.
2359         (the_arm_fbsd_nat_target): New.
2360         (arm_fbsd_fetch_inferior_registers)
2361         (arm_fbsd_store_inferior_registers, arm_fbsd_read_description):
2362         (_initialize_arm_fbsd_nat): Refactor as methods of
2363         arm_fbsd_nat_target.
2364         (_initialize_arm_fbsd_nat): Adjust to C++ification.
2365         * arm-nbsd-nat.c (arm_netbsd_nat_target): New class.
2366         (the_arm_netbsd_nat_target): New.
2367         (armnbsd_fetch_registers, armnbsd_store_registers): Refactor as
2368         arm_netbsd_nat_target.
2369         (_initialize_arm_netbsd_nat): Adjust to C++ification.
2370         * hppa-nbsd-nat.c (hppa_nbsd_nat_target): New class.
2371         (the_hppa_nbsd_nat_target): New.
2372         (hppanbsd_fetch_registers, hppanbsd_store_registers): Refactor as
2373         hppa_nbsd_nat_target methods.
2374         (_initialize_hppanbsd_nat): Adjust to C++ification.
2375         * hppa-obsd-nat.c (hppa_obsd_nat_target): New class.
2376         (the_hppa_obsd_nat_target): New.
2377         (hppaobsd_fetch_registers, hppaobsd_store_registers): Refactor as
2378         methods of hppa_obsd_nat_target.
2379         (_initialize_hppaobsd_nat): Adjust to C++ification.  Use
2380         add_target.
2381         * i386-nbsd-nat.c (the_i386_nbsd_nat_target): New.
2382         (_initialize_i386nbsd_nat): Adjust to C++ification.  Use
2383         add_target.
2384         * i386-obsd-nat.c (the_i386_obsd_nat_target): New.
2385         (_initialize_i386obsd_nat): Use add_target.
2386         * m68k-bsd-nat.c (m68k_bsd_nat_target): New class.
2387         (the_m68k_bsd_nat_target): New.
2388         (m68kbsd_fetch_inferior_registers)
2389         (m68kbsd_store_inferior_registers): Refactor as methods of
2390         m68k_bsd_nat_target.
2391         (_initialize_m68kbsd_nat): Adjust to C++ification.
2392         * mips-fbsd-nat.c (mips_fbsd_nat_target): New class.
2393         (the_mips_fbsd_nat_target): New.
2394         (mips_fbsd_fetch_inferior_registers)
2395         (mips_fbsd_store_inferior_registers): Refactor as methods of
2396         mips_fbsd_nat_target.
2397         (_initialize_mips_fbsd_nat): Adjust to C++ification.  Use
2398         add_target.
2399         * mips-nbsd-nat.c (mips_nbsd_nat_target): New class.
2400         (the_mips_nbsd_nat_target): New.
2401         (mipsnbsd_fetch_inferior_registers)
2402         (mipsnbsd_store_inferior_registers): Refactor as methods of
2403         mips_nbsd_nat_target.
2404         (_initialize_mipsnbsd_nat): Adjust to C++ification.
2405         * mips64-obsd-nat.c (mips64_obsd_nat_target): New class.
2406         (the_mips64_obsd_nat_target): New.
2407         (mips64obsd_fetch_inferior_registers)
2408         (mips64obsd_store_inferior_registers): Refactor as methods of
2409         mips64_obsd_nat_target.
2410         (_initialize_mips64obsd_nat): Adjust to C++ification.  Use
2411         add_target.
2412         * nbsd-nat.c (nbsd_pid_to_exec_file): Refactor as method of
2413         nbsd_nat_target.
2414         * nbsd-nat.h: Include "inf-ptrace.h".
2415         (nbsd_nat_target): New class.
2416         * obsd-nat.c (obsd_pid_to_str, obsd_update_thread_list)
2417         (obsd_wait): Refactor as methods of obsd_nat_target.
2418         (obsd_add_target): Delete.
2419         * obsd-nat.h: Include "inf-ptrace.h".
2420         (obsd_nat_target): New class.
2421         * ppc-fbsd-nat.c (ppc_fbsd_nat_target): New class.
2422         (the_ppc_fbsd_nat_target): New.
2423         (ppcfbsd_fetch_inferior_registers)
2424         (ppcfbsd_store_inferior_registers): Refactor as methods of
2425         ppc_fbsd_nat_target.
2426         (_initialize_ppcfbsd_nat): Adjust to C++ification.  Use
2427         add_target.
2428         * ppc-nbsd-nat.c (ppc_nbsd_nat_target): New class.
2429         (the_ppc_nbsd_nat_target): New.
2430         (ppcnbsd_fetch_inferior_registers)
2431         (ppcnbsd_store_inferior_registers): Refactor as methods of
2432         ppc_nbsd_nat_target.
2433         (_initialize_ppcnbsd_nat): Adjust to C++ification.
2434         * ppc-obsd-nat.c (ppc_obsd_nat_target): New class.
2435         (the_ppc_obsd_nat_target): New.
2436         (ppcobsd_fetch_registers, ppcobsd_store_registers): Refactor as
2437         methods of ppc_obsd_nat_target.
2438         (_initialize_ppcobsd_nat): Adjust to C++ification.  Use
2439         add_target.
2440         * sh-nbsd-nat.c (sh_nbsd_nat_target): New class.
2441         (the_sh_nbsd_nat_target): New.
2442         (shnbsd_fetch_inferior_registers)
2443         (shnbsd_store_inferior_registers): Refactor as methods of
2444         sh_nbsd_nat_target.
2445         (_initialize_shnbsd_nat): Adjust to C++ification.
2446         * sparc-nat.c (sparc_xfer_wcookie): Make extern.
2447         (inf_ptrace_xfer_partial): Delete.
2448         (sparc_xfer_partial, sparc_target): Delete.
2449         * sparc-nat.h (sparc_fetch_inferior_registers)
2450         (sparc_store_inferior_registers, sparc_xfer_wcookie): Declare.
2451         (sparc_target): Delete function declaration.
2452         (sparc_target): New template class.
2453         * sparc-nbsd-nat.c (the_sparc_nbsd_nat_target): New.
2454         (_initialize_sparcnbsd_nat): Adjust to C++ification.
2455         * sparc64-fbsd-nat.c (the_sparc64_fbsd_nat_target): New.
2456         (_initialize_sparc64fbsd_nat): Adjust to C++ification.  Use
2457         add_target.
2458         * sparc64-nbsd-nat.c (the_sparc64_nbsd_nat_target): New.
2459         (_initialize_sparc64nbsd_nat): Adjust to C++ification.
2460         * sparc64-obsd-nat.c (the_sparc64_obsd_nat_target): New.
2461         (_initialize_sparc64obsd_nat): Adjust to C++ification.  Use
2462         add_target.
2463         * vax-bsd-nat.c (vax_bsd_nat_target): New class.
2464         (the_vax_bsd_nat_target): New.
2465         (vaxbsd_fetch_inferior_registers)
2466         (vaxbsd_store_inferior_registers): Refactor as vax_bsd_nat_target
2467         methods.
2468         (_initialize_vaxbsd_nat): Adjust to C++ification.
2469
2470         * bsd-kvm.c (bsd_kvm_target): New class.
2471         (bsd_kvm_ops): Now a bsd_kvm_target.
2472         (bsd_kvm_open, bsd_kvm_close, bsd_kvm_xfer_partial)
2473         (bsd_kvm_files_info, bsd_kvm_fetch_registers)
2474         (bsd_kvm_thread_alive, bsd_kvm_pid_to_str): Refactor as methods of
2475         bsd_kvm_target.
2476         (bsd_kvm_return_one): Delete.
2477         (bsd_kvm_add_target): Adjust to C++ification.
2478
2479         * nto-procfs.c (nto_procfs_target, nto_procfs_target_native)
2480         (nto_procfs_target_procfs): New classes.
2481         (procfs_open_1, procfs_thread_alive, procfs_update_thread_list)
2482         (procfs_files_info, procfs_pid_to_exec_file, procfs_attach)
2483         (procfs_post_attach, procfs_wait, procfs_fetch_registers)
2484         (procfs_xfer_partial, procfs_detach, procfs_insert_breakpoint)
2485         (procfs_remove_breakpoint, procfs_insert_hw_breakpoint)
2486         (procfs_remove_hw_breakpoint, procfs_resume)
2487         (procfs_mourn_inferior, procfs_create_inferior, procfs_interrupt)
2488         (procfs_kill_inferior, procfs_store_registers)
2489         (procfs_pass_signals, procfs_pid_to_str, procfs_can_run): Refactor
2490         as methods of nto_procfs_target.
2491         (nto_procfs_ops): Now an nto_procfs_target_procfs.
2492         (nto_native_ops): Delete.
2493         (procfs_open, procfs_native_open): Delete.
2494         (nto_native_ops): Now an nto_procfs_target_native.
2495         (init_procfs_targets): Adjust to C++ification.
2496         (procfs_can_use_hw_breakpoint, procfs_remove_hw_watchpoint)
2497         (procfs_insert_hw_watchpoint, procfs_stopped_by_watchpoint):
2498         Refactor as methods of nto_procfs_target.
2499
2500         * go32-nat.c (go32_nat_target): New class.
2501         (the_go32_nat_target): New.
2502         (go32_attach, go32_resume, go32_wait, go32_fetch_registers)
2503         (go32_store_registers, go32_xfer_partial, go32_files_info)
2504         (go32_kill_inferior, go32_create_inferior, go32_mourn_inferior)
2505         (go32_terminal_init, go32_terminal_info, go32_terminal_inferior)
2506         (go32_terminal_ours, go32_pass_ctrlc, go32_thread_alive)
2507         (go32_pid_to_str): Refactor as methods of go32_nat_target.
2508         (go32_target): Delete.
2509         (_initialize_go32_nat): Adjust to C++ification.
2510
2511         * gnu-nat.c (gnu_wait, gnu_resume, gnu_kill_inferior)
2512         (gnu_mourn_inferior, gnu_create_inferior, gnu_attach, gnu_detach)
2513         (gnu_stop, gnu_thread_alive, gnu_xfer_partial)
2514         (gnu_find_memory_regions, gnu_pid_to_str): Refactor as methods of
2515         gnu_nat_target.
2516         (gnu_target): Delete.
2517         * gnu-nat.h (gnu_target): Delete.
2518         (gnu_nat_target): New class.
2519         * i386-gnu-nat.c (gnu_base_target): New.
2520         (i386_gnu_nat_target): New class.
2521         (the_i386_gnu_nat_target): New.
2522         (_initialize_i386gnu_nat): Adjust to C++ification.
2523
2524 2018-05-02  Pedro Alves  <palves@redhat.com>
2525
2526         * bfd-target.c (target_bfd_xclose): Rename to ...
2527         (target_bfd_close): ... this.
2528         (target_bfd_reopen): Adjust.
2529         * target.c (target_close): Remove references to to_xclose.
2530         * target.h (target_ops::to_xclose): Delete.
2531         (target_ops::to_close): Update comments.
2532
2533 2018-05-02  Pedro Alves  <palves@redhat.com>
2534
2535         * alpha-linux-nat.c: Include "linux-nat-trad.h" instead of
2536         "linux-nat.h".
2537         * configure.nat (alpha-linux, linux-mips): Add linux-nat-trad.o.
2538         * inf-ptrace.c (inf_ptrace_register_u_offset)
2539         (inf_ptrace_fetch_register, inf_ptrace_fetch_registers)
2540         (inf_ptrace_store_register, inf_ptrace_store_registers)
2541         (inf_ptrace_trad_target): Move to ...
2542         * linux-nat-trad.c: ... this new file.
2543         * linux-nat-trad.h: New file.
2544         * linux-nat.c (linux_target_install_ops): Make extern.
2545         (linux_trad_target): Delete.
2546         * linux-nat.h (linux_trad_target): Delete declaration.
2547         (linux_target_install_ops): Declare.
2548         * mips-linux-nat.c: Include "linux-nat-trad.h" instead of
2549         "linux-nat.h".
2550
2551 2018-05-02  Pedro Alves  <palves@redhat.com>
2552
2553         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Don't call
2554         procfs_target/add_target here.
2555         * procfs.c (procfs_target): Make static.
2556         (_initialize_procfs): Call add_target here.
2557         * procfs.h (struct target_ops): Remove forward declaration.
2558         (procfs_target): Remove declaration.
2559         * sparc-sol2-nat.c (_initialize_sparc_sol2_nat): Delete.
2560
2561 2018-05-02  Pedro Alves  <palves@redhat.com>
2562
2563         * procfs.c (procfs_stopped_by_watchpoint)
2564         (procfs_insert_watchpoint, procfs_remove_watchpoint)
2565         (procfs_region_ok_for_hw_watchpoint, procfs_stopped_data_address):
2566         Forward declare.
2567         (procfs_use_watchpoints): Delete, move contents...
2568         (procfs_target): ... here.
2569         * procfs.h (procfs_use_watchpoints): Delete declaration.
2570         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Don't call
2571         procfs_use_watchpoints.
2572         * sparc-sol2-nat.c (_initialize_sparc_sol2_nat): Don't call
2573         procfs_use_watchpoints.
2574
2575 2018-05-02  Tom Tromey  <tom@tromey.com>
2576
2577         PR python/20084:
2578         * python/python.c (gdbpy_parameter_value): Handle var_zuinteger
2579         and var_zuinteger_unlimited.
2580         * python/py-param.c (struct parm_constant): Add PARAM_ZUINTEGER
2581         and PARAM_ZUINTEGER_UNLIMITED.
2582         (set_parameter_value): Handle var_zuinteger and
2583         var_zuinteger_unlimited.
2584         (add_setshow_generic): Likewise.
2585         (parmpy_init): Likewise.
2586
2587 2018-04-28  Dan Robertson  <danlrobertson89@gmail.com>
2588
2589         PR rust/23124
2590         * gdb/rust-exp.y (convert_params_to_types): Ensure that the params
2591         pointer is not null before dereferencing it.
2592
2593 2018-04-30  Tom Tromey  <tom@tromey.com>
2594
2595         * darwin-nat-info.c (darwin_debug_regions_recurse): Remove use of
2596         is_mi_like_p.
2597
2598 2018-04-30  Tom Tromey  <tom@tromey.com>
2599
2600         * breakpoint.c (mention): Remove use of is_mi_like_p.
2601         (print_mention_ranged_breakpoint): Likewise.
2602         * break-catch-throw.c (print_it_exception_catchpoint): Remove use
2603         of is_mi_like_p.
2604
2605 2018-04-30  Tom Tromey  <tom@tromey.com>
2606
2607         * tracepoint.c (tvariables_info_1): Remove use of is_mi_like_p.
2608
2609 2018-04-30  Tom Tromey  <tom@tromey.com>
2610
2611         * spu-tdep.c (info_spu_mailbox_list, info_spu_dma_cmdlist)
2612         (info_spu_event_command): Remove some uses of is_mi_like_p.
2613
2614 2018-04-30  Tom Tromey  <tom@tromey.com>
2615
2616         * python/py-framefilter.c (py_print_single_arg)
2617         (enumerate_locals, py_print_args, py_print_frame): Remove some
2618         uses of is_mi_like_p.
2619
2620 2018-04-30  Tom Tromey  <tom@tromey.com>
2621
2622         * ui-out.c: Update.
2623         * cli-out.h (cli_ui_out::do_is_mi_like_p): Update.
2624         * ui-out.h (ui_out::is_mi_like_p): Now const.
2625         (ui_out::do_is_mi_like_p): Now const.
2626         * mi/mi-out.h (mi_ui_out::do_is_mi_like_p): Update.
2627
2628 2018-04-30  Tom Tromey  <tom@tromey.com>
2629
2630         * varobj.c (varobj_set_visualizer): Use new_reference.
2631         * python/python.c (gdbpy_decode_line): Use new_reference.
2632         * python/py-cmd.c (cmdpy_function, cmdpy_completer_helper): Use
2633         new_reference.
2634
2635 2018-04-30  Tom Tromey  <tom@tromey.com>
2636
2637         * varobj.c (install_new_value): Use new_reference.
2638         * value.h (value_incref): Return void.  Swap intro comment with
2639         value_decref.
2640         * value.c (set_value_parent): Use new_reference.
2641         (value_incref): Return void.  Update intro comment.
2642         (release_value): Use new_reference.
2643         * dwarf2loc.c (dwarf2_evaluate_loc_desc_full): Use new_reference.
2644
2645 2018-04-30  Tom Tromey  <tom@tromey.com>
2646
2647         * symfile-mem.c (symbol_file_add_from_memory): Use new_reference.
2648         * gdb_bfd.h (new_bfd_ref): Remove.
2649         (gdb_bfd_open): Update comment.
2650         * gdb_bfd.c (gdb_bfd_open, gdb_bfd_fopen, gdb_bfd_openr)
2651         (gdb_bfd_openw, gdb_bfd_openr_iovec, gdb_bfd_record_inclusion)
2652         (gdb_bfd_fdopenr): Use new_reference.
2653         * exec.c (exec_file_attach): Use new_reference.
2654
2655 2018-04-30  Tom Tromey  <tom@tromey.com>
2656
2657         * common/gdb_ref_ptr.h (ref_ptr::new_reference): New static
2658         method.
2659
2660 2018-04-30  Tom Tromey  <tom@tromey.com>
2661
2662         * jit.c (jit_read_code_entry): Use type_align.
2663         * i386-tdep.c (i386_gdbarch_init): Don't call
2664         set_gdbarch_long_long_align_bit.
2665         * gdbarch.sh: Remove long_long_align_bit.
2666         * gdbarch.c, gdbarch.h: Rebuild.
2667         * arc-tdep.c (arc_type_align): New function.
2668         (arc_gdbarch_init): Use arc_type_align.  Don't call
2669         set_gdbarch_long_long_align_bit.
2670
2671 2018-04-30  Tom Tromey  <tom@tromey.com>
2672
2673         * rust-lang.c (rust_type_alignment): Remove.
2674         (rust_composite_type): Use type_align.
2675
2676 2018-04-30  Tom Tromey  <tom@tromey.com>
2677
2678         * NEWS: Mention Type.align.
2679         * python/py-type.c (typy_get_alignof): New function.
2680         (type_object_getset): Add "alignof".
2681
2682 2018-04-30  Tom Tromey  <tom@tromey.com>
2683
2684         PR exp/17095:
2685         * NEWS: Update.
2686         * std-operator.def (UNOP_ALIGNOF): New operator.
2687         * expprint.c (dump_subexp_body_standard) <case UNOP_ALIGNOF>:
2688         New.
2689         * eval.c (evaluate_subexp_standard) <case UNOP_ALIGNOF>: New.
2690         * c-lang.c (c_op_print_tab): Add alignof.
2691         * c-exp.y (ALIGNOF): New token.
2692         (exp): Add "ALIGNOF" production.
2693         (ident_tokens): Add _Alignof and alignof.
2694
2695 2018-04-30  Tom Tromey  <tom@tromey.com>
2696
2697         * i386-tdep.c (i386_type_align): New function.
2698         (i386_gdbarch_init): Update.
2699         * gdbarch.sh (type_align): New method.
2700         * gdbarch.c, gdbarch.h: Rebuild.
2701         * arch-utils.h (default_type_align): Declare.
2702         * arch-utils.c (default_type_align): New function.
2703         * gdbtypes.h (TYPE_ALIGN_BITS): New define.
2704         (struct type) <align_log2>: New field.
2705         <instance_flags>: Now a bitfield.
2706         (TYPE_RAW_ALIGN): New macro.
2707         (type_align, type_raw_align, set_type_align): Declare.
2708         * gdbtypes.c (type_align, type_raw_align, set_type_align): New
2709         functions.
2710         * dwarf2read.c (quirk_rust_enum): Set type alignment.
2711         (get_alignment, maybe_set_alignment): New functions.
2712         (read_structure_type, read_enumeration_type, read_array_type)
2713         (read_set_type, read_tag_pointer_type, read_tag_reference_type)
2714         (read_subrange_type, read_base_type): Set type alignment.
2715
2716 2018-04-30  Simon Marchi  <simon.marchi@ericsson.com>
2717
2718         * dwarf2read.c (read_index_from_section): Use bool.
2719
2720 2018-04-29  Fabian Groffen  <grobian@gentoo.org>
2721
2722         PR gdb/22950
2723         * proc-events.c (init_syscall_table): Guard usage os SYS_uuidsys
2724         with #ifdef.
2725
2726 2018-04-29  John Reiser  <jreiser@BitWagon.com>
2727
2728         PR build/22873
2729         * gdb/Makefile.in: (.c:.l, .c:.y): Write the target only in the
2730         last step, and do it atomically.
2731
2732 2018-04-27  Alexandre Oliva  <aoliva@redhat.com>
2733
2734         * compile/compile-c-types.c (convert_int, convert_float):
2735         Update for C FE v1.
2736
2737 2018-04-27  Tom Tromey  <tom@tromey.com>
2738
2739         PR rust/22545:
2740         * rust-lang.c (rust_inclusive_range_type_p): New function.
2741         (rust_range): Handle inclusive ranges.
2742         (rust_compute_range): Likewise.
2743         * rust-exp.y (struct rust_op) <inclusive>: New field.
2744         (DOTDOTEQ): New constant.
2745         (range_expr): Add "..=" productions.
2746         (operator_tokens): Add "..=" token.
2747         (ast_range): Add "inclusive" parameter.
2748         (convert_ast_to_expression) <case OP_RANGE>: Handle inclusive
2749         ranges.
2750         * parse.c (operator_length_standard) <case OP_RANGE>: Handle new
2751         bounds values.
2752         * expression.h (enum range_type) <NONE_BOUND_DEFAULT_EXCLUSIVE,
2753         LOW_BOUND_DEFAULT_EXCLUSIVE>: New constants.
2754         Update comments.
2755         * expprint.c (print_subexp_standard): Handle new bounds values.
2756         (dump_subexp_body_standard): Likewise.
2757
2758 2018-04-27  Tom Tromey  <tom@tromey.com>
2759
2760         * configure: Rebuild.
2761         * warning.m4 (AM_GDB_WARNINGS): Add -Wsuggest-override.
2762         * dwarf2loc.c (class dwarf_evaluate_loc_desc): Use "override", not
2763         "OVERRIDE".
2764         (class symbol_needs_eval_context): Likewise.
2765         * dwarf2read.c (mock_mapped_index::symbol_name_count)
2766         (mock_mapped_index::symbol_name_at): Use "override".  Remove
2767         "virtual".
2768         * dwarf2-frame.c (dwarf_expr_executor::get_addr_index): Use
2769         "override".
2770         (class dwarf_expr_executor): Use "override", not "OVERRIDE".
2771         * aarch64-tdep.c (instruction_reader::read): Use "override".
2772         (instruction_reader_test::read): Likewise.
2773         * arm-tdep.c (instruction_reader::read): Use "override".
2774         (instruction_reader_thumb::read): Likewise.
2775
2776 2018-04-26  Andrzej Kaczmarek  <andrzej.kaczmarek@codecoup.pl>
2777
2778         PR remote/9665
2779         * remote.c (send_g_packet): Use putpkt/getpkt/packet_check_result
2780         instead of remote_send.
2781         (remote_send): Remove.
2782
2783 2018-04-26  Pedro Alves  <palves@redhat.com>
2784
2785         * elfread.c (elf_gnu_ifunc_resolver_return_stop): Use
2786         find_function_start_sal instead of find_pc_line.
2787
2788 2018-04-26  Pedro Alves  <palves@redhat.com>
2789
2790         * breakpoint.c (set_breakpoint_location_function): Handle
2791         mst_data_gnu_ifunc.
2792         * c-exp.y (variable production): Handle mst_data_gnu_ifunc.
2793         * elfread.c (elf_symtab_read): Give data symbols with
2794         BSF_GNU_INDIRECT_FUNCTION set mst_data_gnu_ifunc type.
2795         (elf_rel_plt_read): Update comment.
2796         * linespec.c (convert_linespec_to_sals): Handle
2797         mst_data_gnu_ifunc.
2798         (minsym_found): Handle mst_data_gnu_ifunc.
2799         * minsyms.c (msymbol_is_function, minimal_symbol_reader::record)
2800         (find_solib_trampoline_target): Handle mst_data_gnu_ifunc.
2801         * parse.c (find_minsym_type_and_address): Handle
2802         mst_data_gnu_ifunc.
2803         * symmisc.c (dump_msymbols): Handle mst_data_gnu_ifunc.
2804         * symtab.c (find_gnu_ifunc): Handle mst_data_gnu_ifunc.
2805         * symtab.h (minimal_symbol_type) <mst_text_gnu_ifunc>: Update
2806         comment.
2807         <mst_data_gnu_ifunc>: New enumerator.
2808
2809 2018-04-26  Pedro Alves  <palves@redhat.com>
2810
2811         * minsyms.c (lookup_minimal_symbol_by_pc_section_1): Rename to ...
2812         (lookup_minimal_symbol_by_pc_section): ... this.  Replace
2813         'want_trampoline' parameter by a lookup_msym_prefer parameter.
2814         Handle it.
2815         (lookup_minimal_symbol_by_pc_section): Delete old implementation.
2816         (lookup_minimal_symbol_by_pc): Adjust.
2817         (in_gnu_ifunc_stub): Prefer GNU ifunc symbols.
2818         (lookup_solib_trampoline_symbol_by_pc): Adjust.
2819         * minsyms.h (lookup_msym_prefer): New enum.
2820         (lookup_minimal_symbol_by_pc_section): Replace 'want_trampoline'
2821         parameter by a lookup_msym_prefer parameter.
2822
2823 2018-04-26  Pedro Alves  <palves@redhat.com>
2824
2825         * elfread.c (elf_gnu_ifunc_record_cache): Check if the symbol name
2826         ends in "@plt" instead of looking at the symbol's section.
2827
2828 2018-04-26  Pedro Alves  <palves@redhat.com>
2829
2830         * blockframe.c (cache_pc_function_is_gnu_ifunc): Delete.  Remove
2831         all references.
2832         (find_pc_partial_function_gnu_ifunc): Rename to ...
2833         (find_pc_partial_function): ... this, and remove references to
2834         'is_gnu_ifunc_p'.
2835         (find_pc_partial_function): Delete old implementation.
2836         * symtab.h (find_pc_partial_function_gnu_ifunc): Delete.
2837
2838 2018-04-26  Pedro Alves  <palves@redhat.com>
2839
2840         * linespec.c (struct bound_minimal_symbol_search_key): New.
2841         (convert_linespec_to_sals): Sort minimal symbols earlier.  Don't
2842         skip first line if we found a GNU ifunc minimal symbol by name.
2843         (compare_msymbols): Change parameters to work with a destructured
2844         lhs minsym.
2845         (compare_msymbols_for_qsort, compare_msymbols_for_bsearch): New
2846         functions.
2847
2848 2018-04-26  Pedro Alves  <palves@redhat.com>
2849
2850         * breakpoint.c (set_breakpoint_location_function): Don't resolve
2851         ifunc targets here.  Instead, if we have an ifunc minsym, use its
2852         address/name.
2853         (add_location_to_breakpoint): Store the minsym and the objfile in
2854         the breakpoint location.
2855         * breakpoint.h (bp_location) <msymbol, objfile>: New fields.
2856         * linespec.c (minsym_found): Resolve GNU ifunc targets here.
2857         Record the minsym in the sal.
2858         * symtab.h (symtab_and_line) <msymbol>: New field.
2859
2860 2018-04-26  Pedro Alves  <palves@redhat.com>
2861
2862         * elfread.c (elf_gnu_ifunc_resolve_by_got): Don't write to *ADDR_P
2863         unless we actually resolved the ifunc.
2864
2865 2018-04-26  Pedro Alves  <palves@redhat.com>
2866
2867         * c-exp.y (variable production): Prefer ifunc minsyms over
2868         regular function symbols.
2869         * symtab.c (find_gnu_ifunc): New function.
2870         * minsyms.h (lookup_msym_prefer): New enum.
2871         (lookup_minimal_symbol_by_pc_section): Replace 'want_trampoline'
2872         parameter by a lookup_msym_prefer parameter.
2873         * symtab.h (find_gnu_ifunc): New declaration.
2874
2875 2018-04-26  Pedro Alves  <palves@redhat.com>
2876
2877         * blockframe.c (find_gnu_ifunc_target_type): New function.
2878         (find_function_type): New.
2879         * eval.c (evaluate_var_msym_value): For GNU ifunc types, always
2880         return a value with a memory address.
2881         (eval_call): For calls to GNU ifunc functions, try to find the
2882         type of the target function from the type that the resolver
2883         returns.
2884         * gdbtypes.c (objfile_type): Don't install a return type for ifunc
2885         symbols.
2886         * infcall.c (find_function_return_type): Delete.
2887         (find_function_addr): Add 'function_type' parameter.  For calls to
2888         GNU ifunc functions, try to find the type of the target function
2889         from the type that the resolver returns, and return it via
2890         FUNCTION_TYPE.
2891         (call_function_by_hand_dummy): Adjust to use the function type
2892         returned by find_function_addr.
2893         (find_function_addr): Add 'function_type' parameter and move
2894         description here.
2895         * symtab.h (find_function_type, find_gnu_ifunc_target_type): New
2896         declarations.
2897
2898 2018-04-26  Pedro Alves  <palves@redhat.com>
2899
2900         * c-exp.y (variable production): Skip finding an alias for ifunc
2901         symbols.
2902
2903 2018-04-26  Pedro Alves  <palves@redhat.com>
2904
2905         * elfread.c (elf_rel_plt_read): Look for relocations for .got.plt too.
2906
2907 2018-04-25  Pedro Alves  <palves@redhat.com>
2908
2909         * infcmd.c (kill_command): Print the pid as string, not the whole
2910         thread's ptid.  Add comment.  s/has been killed/killed/ in output
2911         message.
2912         * remote.c (remote_detach_1): Print the pid as string, not the
2913         whole thread's ptid.
2914
2915 2018-04-24  Jan Kratochvil  <jan.kratochvil@redhat.com>
2916             Sergio Durigan Junior  <sergiodj@redhat.com>
2917             Pedro Alves  <palves@redhat.com>
2918
2919         * infcmd.c (kill_command): Print message when inferior has
2920         been killed.
2921         * inferior.c (print_inferior_events): Remove 'static'.  Set as
2922         '1'.
2923         (add_inferior): Improve message printed when
2924         'print_inferior_events' is on.
2925         (exit_inferior): Remove message printed when
2926         'print_inferior_events' is on.
2927         (detach_inferior): Improve message printed when
2928         'print_inferior_events' is on.
2929         (initialize_inferiors): Use 'add_inferior_silent' to set
2930         'current_inferior_'.
2931         * inferior.h (print_inferior_events): Declare here as
2932         'extern'.
2933         * infrun.c (follow_fork_inferior): Print '[Attaching...]' or
2934         '[Detaching...]' messages when 'print_inferior_events' is on.
2935         Use 'add_thread_silent' instead of 'add_thread'.  Add '[' and ']'
2936         as prefix/suffix for messages.  Remove periods.  Fix erroneous
2937         'Detaching after fork from child...', replace it by '... from
2938         parent...'.
2939         (handle_vfork_child_exec_or_exit): Add '[' and ']' as
2940         prefix/suffix when printing 'Detaching...' messages.  Print
2941         them when 'print_inferior_events' is on.
2942         * remote.c (remote_detach_1): Print message when detaching
2943         from inferior and '!is_fork_parent'.
2944
2945 2018-04-24  Tom Tromey  <tom@tromey.com>
2946
2947         * cli-out.h: Reindent.
2948
2949 2018-04-24  Tom Tromey  <tom@tromey.com>
2950
2951         * cli-out.c (cli_ui_out::out_field_fmt): Remove.
2952         (cli_ui_out::do_field_string): Use fputs_filtered.
2953         * cli-out.h (class cli_ui_out) <out_field_fmt>: Remove.
2954
2955 2018-04-23  Tom Tromey  <tom@tromey.com>
2956
2957         * guile/scm-frame.c (gdbscm_frame_read_var): Use
2958         gdb::unique_xmalloc_ptr.
2959
2960 2018-04-23  Tom Tromey  <tom@tromey.com>
2961
2962         * configure: Rebuild.
2963
2964 2018-04-22  Rajendra SY  <rajendra.sy@gmail.com>
2965
2966         PR gdb/23095
2967         * gdb/testsuite/gdb.base/break-probes.exp: Pass shlib_load to
2968         prepare_for_testing.  Set normal_bp to r_debug_state if target
2969         is bsd.
2970
2971 2018-04-21  Pedro Alves  <palves@redhat.com>
2972             Rajendra SY  <rajendra.sy@gmail.com>
2973
2974         * inf-ptrace.c (inf_ptrace_attach): Mark the thread as executing.
2975         * remote.c (extended_remote_attach): In all-stop mode, mark the
2976         thread as executing.
2977
2978 2018-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2979
2980         * thread.c (thread_apply_all_command): Fix comment.
2981         (thread_command): Fix comment.
2982
2983 2018-04-10  Alan Hayward  <alan.hayward@arm.com>
2984
2985         * common/tdesc.h (tdesc_create_feature): Remove xml filename
2986         parameter.
2987         * features/aarch64-core.c (create_feature_aarch64_core):
2988         Regenerate.
2989         * features/aarch64-fpu.c (create_feature_aarch64_fpu):
2990         Likewise.
2991         * features/i386/32bit-avx.c (create_feature_i386_32bit_avx):
2992         Likewise.
2993         * features/i386/32bit-avx512.c
2994         (create_feature_i386_32bit_avx512): Likewise.
2995         * features/i386/32bit-core.c (create_feature_i386_32bit_core):
2996         Likewise.
2997         * features/i386/32bit-linux.c (create_feature_i386_32bit_linux):
2998         Likewise.
2999         * features/i386/32bit-mpx.c (create_feature_i386_32bit_mpx):
3000         Likewise.
3001         * features/i386/32bit-pkeys.c (create_feature_i386_32bit_pkeys):
3002         Likewise.
3003         * features/i386/32bit-sse.c (create_feature_i386_32bit_sse):
3004         Likewise.
3005         * features/i386/64bit-avx.c (create_feature_i386_64bit_avx):
3006         Likewise.
3007         * features/i386/64bit-avx512.c
3008         (create_feature_i386_64bit_avx512): Likewise.
3009         * features/i386/64bit-core.c (create_feature_i386_64bit_core):
3010         Likewise.
3011         * features/i386/64bit-linux.c (create_feature_i386_64bit_linux):
3012         Likewise.
3013         * features/i386/64bit-mpx.c (create_feature_i386_64bit_mpx):
3014         Likewise.
3015         * features/i386/64bit-pkeys.c (create_feature_i386_64bit_pkeys):
3016         Likewise.
3017         * features/i386/64bit-segments.c
3018         (create_feature_i386_64bit_segments): Likewise.
3019         * features/i386/64bit-sse.c (create_feature_i386_64bit_sse):
3020         Likewise.
3021         * features/i386/x32-core.c
3022         (create_feature_i386_x32_core): Likewise.
3023         * features/tic6x-c6xp.c (create_feature_tic6x_c6xp): Likewise.
3024         * features/tic6x-core.c (create_feature_tic6x_core): Likewise.
3025         * features/tic6x-gp.c (create_feature_tic6x_gp): Likewise.
3026         * target-descriptions.c: In generated code, don't pass xml
3027         filename.
3028
3029 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3030
3031         * common/tdesc.c (print_xml_feature::visit_pre): Add xml parsing.
3032         (print_xml_feature::visit_post): Likewise.
3033         (print_xml_feature::visit): Likewise.
3034         * common/tdesc.h (tdesc_get_features_xml): Use const tdesc.
3035         (print_xml_feature): Add new class.
3036         * regformats/regdat.sh: Null xmltarget on feature targets.
3037         * target-descriptions.c (struct target_desc): Add xmltarget.
3038         (maintenance_check_tdesc_xml_convert): Add unittest function.
3039         (tdesc_get_features_xml): Add function to get xml.
3040         (maintenance_check_xml_descriptions): Test xml generation.
3041         * xml-tdesc.c (string_read_description_xml): Add function.
3042         * xml-tdesc.h (string_read_description_xml): Add declaration.
3043
3044 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3045
3046         * features/Makefile: Add feature marker to targets with new style
3047         target descriptions.
3048         * regformats/aarch64.dat: Regenerate.
3049         * regformats/i386/amd64-avx-avx512-linux.dat: Likewise.
3050         * regformats/i386/amd64-avx-linux.dat: Likewise.
3051         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Likewise.
3052         * regformats/i386/amd64-avx-mpx-linux.dat: Likewise.
3053         * regformats/i386/amd64-linux.dat: Likewise.
3054         * regformats/i386/amd64-mpx-linux.dat: Likewise.
3055         * regformats/i386/amd64.dat: Likewise.
3056         * regformats/i386/i386-avx-avx512-linux.dat: Likewise.
3057         * regformats/i386/i386-avx-linux.dat: Likewise.
3058         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Likewise.
3059         * regformats/i386/i386-avx-mpx-linux.dat: Likewise.
3060         * regformats/i386/i386-linux.dat: Likewise.
3061         * regformats/i386/i386-mmx-linux.dat: Likewise.
3062         * regformats/i386/i386-mpx-linux.dat: Likewise.
3063         * regformats/i386/i386.dat: Likewise.
3064         * regformats/i386/x32-avx-avx512-linux.dat: Likewise.
3065         * regformats/i386/x32-avx-linux.dat: Likewise.
3066         * regformats/i386/x32-linux.dat: Likewise.
3067         * regformats/tic6x-c62x-linux.dat: Likewise.
3068         * regformats/tic6x-c64x-linux.dat: Likewise.
3069         * regformats/tic6x-c64xp-linux.dat: Likewise.
3070         * regformats/regdat.sh: Parse feature marker.
3071
3072 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3073
3074         * common/tdesc.h (tdesc_architecture_name): Add new declaration.
3075         (tdesc_osabi_name): Likewise.
3076         * target-descriptions.c (tdesc_architecture_name): Add new
3077         function.
3078         (tdesc_osabi_name): Likewise.
3079
3080 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3081
3082         * common/tdesc.c (tdesc_predefined_type): Move to here.
3083         (tdesc_named_type): Likewise.
3084         (tdesc_create_vector): Likewise.
3085         (tdesc_create_struct): Likewise.
3086         (tdesc_set_struct_size): Likewise.
3087         (tdesc_create_union): Likewise.
3088         (tdesc_create_flags): Likewise.
3089         (tdesc_create_enum): Likewise.
3090         (tdesc_add_field): Likewise.
3091         (tdesc_add_typed_bitfield): Likewise.
3092         (tdesc_add_bitfield): Likewise.
3093         (tdesc_add_flag): Likewise.
3094         (tdesc_add_enum_value): Likewise.
3095         * common/tdesc.h (struct tdesc_type_builtin): Likewise.
3096         (struct tdesc_type_vector): Likewise.
3097         (struct tdesc_type_field): Likewise.
3098         (struct tdesc_type_with_fields): Likewise.
3099         (tdesc_create_enum): Add declaration.
3100         (tdesc_add_typed_bitfield): Likewise.
3101         (tdesc_add_enum_value): Likewise.
3102         * target-descriptions.c (tdesc_type_field): Move from here.
3103         (tdesc_type_builtin): Likewise.
3104         (tdesc_type_vector): Likewise.
3105         (tdesc_type_with_fields): Likewise.
3106         (tdesc_predefined_types): Likewise.
3107         (tdesc_named_type): Likewise.
3108         (tdesc_create_vector): Likewise.
3109         (tdesc_create_struct): Likewise.
3110         (tdesc_set_struct_size): Likewise.
3111         (tdesc_create_union): Likewise.
3112         (tdesc_create_flags): Likewise.
3113         (tdesc_create_enum): Likewise.
3114         (tdesc_add_field): Likewise.
3115         (tdesc_add_typed_bitfield): Likewise.
3116         (tdesc_add_bitfield): Likewise.
3117         (tdesc_add_flag): Likewise.
3118         (tdesc_add_enum_value): Likewise.
3119         * gdb/target-descriptions.h (tdesc_create_enum): Likewise.
3120         (tdesc_add_typed_bitfield): Likewise.
3121         (tdesc_add_enum_value): Likewise.
3122
3123 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3124
3125         * common/tdesc.c (tdesc_feature::accept): Move to here.
3126         (tdesc_feature::operator==): Likewise.
3127         (tdesc_create_reg): Likewise.
3128         * common/tdesc.h (tdesc_type_kind): Likewise.
3129         (struct tdesc_type): Likewise.
3130         (struct tdesc_feature): Likewise.
3131         * regformats/regdat.sh: Create a feature.
3132         * target-descriptions.c (tdesc_type_kind): Move from here.
3133         (tdesc_type): Likewise.
3134         (tdesc_type_up): Likewise.
3135         (tdesc_feature): Likewise.
3136         (tdesc_create_reg): Likewise.
3137
3138 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3139
3140         * Makefile.in: Add arch/tdesc.c
3141         * common/tdesc.c: New file.
3142         * common/tdesc.h (tdesc_element_visitor): Move to here.
3143         (tdesc_element): Likewise.
3144         (tdesc_reg): Likewise.
3145         (tdesc_reg_up): Likewise.
3146         * regformats/regdef.h (reg): Add offset to constructors.
3147         * target-descriptions.c (tdesc_element_visitor): Move from here.
3148         (tdesc_element): Likewise.
3149         (tdesc_reg): Likewise.
3150         (tdesc_reg_up): Likewise.
3151
3152 2018-04-17  Tom Tromey  <tom@tromey.com>
3153
3154         * dwarf2read.c (quirk_rust_enum): Conditionally drop the
3155         discriminant field.
3156
3157 2018-04-17  Tom Tromey  <tom@tromey.com>
3158
3159         * dwarf2read.c (quirk_rust_enum): Handle unions correctly.
3160
3161 2018-04-17  Andreas Arnez  <arnez@linux.vnet.ibm.com>
3162
3163         * symtab.c (print_symbol_info): Skip printing filename and line
3164         number when `last' is NULL.
3165         (symtab_symbol_info): Use empty string instead of NULL for first
3166         invocation of print_symbol_info.
3167         (rbreak_command): Pass NULL to `last' parameter of
3168         print_symbol_info.
3169
3170 2018-04-16  Simon Marchi  <simon.marchi@ericsson.com>
3171
3172         * linux-tdep.c (linux_spu_make_corefile_notes): Return note_data
3173         instead of nullptr.
3174
3175 2018-04-16  Pedro Alves  <palves@redhat.com>
3176
3177         * MAINTAINERS (sh): Remove.
3178         * Makefile.in (ALL_TARGET_OBS): Remove sh64-tdep.o.
3179         (HFILES_NO_SRCDIR): Remove sh64-tdep.h.
3180         (ALLDEPFILES): Remove sh64-tdep.c.
3181         * NEWS: Mentions that support for SH-5/SH64 is removed.
3182         * configure.tgt (sh*-*-linux*): Remove reference to sh64-tdep.o.
3183         (sh*-*-openbsd*): Ditto.
3184         (sh64-*-elf*): Remove.
3185         (sh*): Remove.
3186         * regcache.c (cooked_write_test): Remove bfd_mach_sh5 case.
3187         * sh-linux-tdep.c: Remove reference to bfd_mach_sh5.
3188         * sh-tdep.c: No longer include "sh64-tdep.h".
3189         (sh_gdbarch_init): Remove reference to bfd_mach_sh5.
3190         * sh64-tdep.c, sh64-tdep.h: Remove files.
3191
3192 2018-04-16  Pedro Alves  <palves@redhat.com>
3193
3194         * MAINTAINERS: Remove m88k.
3195         * Makefile.in (ALL_TARGET_OBS): Remove m88k-tdep.o.
3196         (HFILES_NO_SRCDIR): Remove m88k-tdep.h.
3197         (ALLDEPFILES): Remove m88k-bsd-nat.c and m88k-tdep.c.
3198         * NEWS: Mention that support for m88k was removed.
3199         * configure.host (m88*-*-*): Remove support.
3200         * configure.nat (m88k-*-*): Remove support.
3201         * configure.tgt (m88*-*-openbsd*): Remove.
3202         * m88k-bsd-nat.c, m88k-tdep.c, m88k-tdep.h: Delete.
3203
3204 2018-04-15  Simon Marchi  <simon.marchi@polymtl.ca>
3205
3206         * configure.tgt (x86_tobjs): New variable.
3207         (amd64_tobjs, i386_tobjs): Use it.
3208
3209 2018-04-13  Andreas Arnez  <arnez@linux.vnet.ibm.com>
3210
3211         * symtab.c (print_symbol_info): Precede the symbol definition by
3212         the line number when available.
3213         * NEWS: Advertise this enhancement.
3214
3215 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
3216
3217         * NEWS (New options): announce set/show record btrace cpu.
3218         * btrace.c: Include record-btrace.h.
3219         (btrace_compute_ftrace_pt): Skip enabling errata workarounds if
3220         the vendor is unknown.
3221         (btrace_compute_ftrace_1): Add cpu parameter.  Update callers.
3222         Maybe overwrite the btrace configuration's cpu.
3223         (btrace_compute_ftrace): Add cpu parameter.  Update callers.
3224         (btrace_fetch): Add cpu parameter.  Update callers.
3225         (btrace_maint_update_pt_packets): Call record_btrace_get_cpu.
3226         Maybe overwrite the btrace configuration's cpu.  Skip enabling
3227         errata workarounds if the vendor is unknown.
3228         * python/py-record-btrace.c: Include record-btrace.h.
3229         (recpy_bt_begin, recpy_bt_end, recpy_bt_instruction_history)
3230         (recpy_bt_function_call_history): Call record_btrace_get_cpu.
3231         * record-btrace.c (record_btrace_cpu_state_kind): New.
3232         (record_btrace_cpu): New.
3233         (set_record_btrace_cpu_cmdlist): New.
3234         (record_btrace_get_cpu): New.
3235         (require_btrace_thread, record_btrace_info)
3236         (record_btrace_resume_thread): Call record_btrace_get_cpu.
3237         (cmd_set_record_btrace_cpu_none): New.
3238         (cmd_set_record_btrace_cpu_auto): New.
3239         (cmd_set_record_btrace_cpu): New.
3240         (cmd_show_record_btrace_cpu): New.
3241         (_initialize_record_btrace): Initialize set/show record btrace cpu
3242         commands.
3243         * record-btrace.h (record_btrace_get_cpu): New.
3244
3245 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
3246
3247         * record.c (set_record_command): Fix typo in message.
3248
3249 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
3250
3251         * record-btrace.c (cmd_set_record_btrace): Print sub-commands.
3252
3253 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
3254
3255         * infrun.c (process_event_stop_test): Call
3256         gdbarch_in_indirect_branch_thunk.
3257         * gdbarch.sh (in_indirect_branch_thunk): New.
3258         * gdbarch.c: Regenerated.
3259         * gdbarch.h: Regenerated.
3260         * x86-tdep.h: New.
3261         * x86-tdep.c: New.
3262         * Makefile.in (ALL_TARGET_OBS): Add x86-tdep.o.
3263         (HFILES_NO_SRCDIR): Add x86-tdep.h.
3264         (ALLDEPFILES): Add x86-tdep.c.
3265         * arch-utils.h (default_in_indirect_branch_thunk): New.
3266         * arch-utils.c (default_in_indirect_branch_thunk): New.
3267         * i386-tdep: Include x86-tdep.h.
3268         (i386_in_indirect_branch_thunk): New.
3269         (i386_elf_init_abi): Set in_indirect_branch_thunk gdbarch
3270         function.
3271         * amd64-tdep: Include x86-tdep.h.
3272         (amd64_in_indirect_branch_thunk): New.
3273         (amd64_init_abi): Set in_indirect_branch_thunk gdbarch function.
3274
3275 2018-04-12  Jan Kratochvil  <jan.kratochvil@redhat.com>
3276
3277         PR gdb/23053
3278         * dwarf-index-write.c (data_buf::grow) (write_one_signatured_type)
3279         (recursively_write_psymbols) (debug_names::recursively_write_psymbols)
3280         (debug_names::write_one_signatured_type): Fix -D_GLIBCXX_DEBUG
3281         regression.
3282
3283 2018-04-12  Tom Tromey  <tom@tromey.com>
3284
3285         * rust-lang.c (rust_print_struct_def): Remove univariant code.
3286         (rust_evaluate_subexp): Likewise.
3287
3288 2018-04-12  Pedro Alves  <palves@redhat.com>
3289
3290         * procfs.c (procfs_detach): Make forward declaration's prototype
3291         match definition's protototype.
3292         (proc_get_LDT_entry): Remove stale do_cleanups call.
3293
3294 2018-04-12  Pedro Alves  <palves@redhat.com>
3295
3296         * target.h (target_ops::to_has_exited): Delete.
3297         (target_has_exited): Delete.
3298         * target-delegates.c: Regenerate.
3299
3300 2018-04-11  Pedro Alves  <palves@redhat.com>
3301
3302         * target.c (fileio_fh_t::t): Add comment.
3303         (target_fileio_pwrite, target_fileio_pread, target_fileio_fstat)
3304         (target_fileio_close): Handle a NULL target.
3305         (invalidate_fileio_fh): New.
3306         (target_close): Call it.
3307         * remote.c (remote_hostio_send_command): No longer check whether
3308         remote_desc is open.
3309
3310 2018-04-11  Pedro Alves  <palves@redhat.com>
3311
3312         * target.c (fileio_fh_t): Make it a named struct instead of a
3313         typedef.
3314         (fileio_fh_t::is_closed): New method.
3315         (DEF_VEC_O (fileio_fh_t)): Remove.
3316         (fileio_fhandles): Now a std::vector.
3317         (is_closed_fileio_fh): Delete.
3318         (acquire_fileio_fd): Adjust.  Rename parameters.
3319         (release_fileio_fd): Adjust.
3320         (fileio_fd_to_fh): Reimplement as a function instead of a macro.
3321         (target_fileio_pwrite, target_fileio_pread, target_fileio_fstat)
3322         (target_fileio_close): Adjust.
3323
3324 2018-04-10  Simon Marchi  <simon.marchi@ericsson.com>
3325
3326         * auto-load.c (auto_load_safe_path_vec_update): Iterate by
3327         index.
3328
3329 2018-04-10  Pedro Alves  <palves@redhat.com>
3330
3331         * gdbthread.h (finish_thread_state_cleanup): Delete declaration.
3332         (scoped_finish_thread_state): New class.
3333         * infcmd.c (run_command_1): Use it instead of finish_thread_state
3334         cleanup.
3335         * infrun.c (proceed, prepare_for_detach, wait_for_inferior)
3336         (fetch_inferior_event, normal_stop): Likewise.
3337         * thread.c (finish_thread_state_cleanup): Delete.
3338
3339 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3340             Pedro Alves  <palves@redhat.com>
3341
3342         * value.c: Include "selftest.h" and "common/array-view.h".
3343         (struct range) <operator ==>: New.
3344         (test_ranges_contain): New.
3345         (check_ranges_vector): New.
3346         (test_insert_into_bit_range_vector): New.
3347         (_initialize_values): Register selftests.
3348         * common/array-view.h (operator==, operator!=): New.
3349
3350 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3351
3352         * common/gdb_vecs.h (unordered_remove): Add overload that takes
3353         an iterator.
3354         * inline-frame.c: Include <algorithm>.
3355         (struct inline_state): Add constructor.
3356         (inline_state_s): Remove.
3357         (DEF_VEC_O(inline_state_s)): Remove.
3358         (inline_states): Change type to std::vector.
3359         (find_inline_frame_state): Adjust to std::vector.
3360         (allocate_inline_frame_state): Remove.
3361         (clear_inline_frame_state): Adjust to std::vector.
3362         (skip_inline_frames): Adjust to std::vector.
3363
3364 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3365
3366         * tracepoint.h (struct trace_state_variable): Add constructor.
3367         <name>: Change type to std::string.
3368         * tracepoint.c (tsv_s): Remove.
3369         (DEF_VEC_O(tsv_s)): Remove.
3370         (tvariables): Change to std::vector.
3371         (create_trace_state_variable): Adjust to std::vector.
3372         (find_trace_state_variable): Likewise.
3373         (find_trace_state_variable_by_number): Likewise.
3374         (delete_trace_state_variable): Likewise.
3375         (trace_variable_command): Adjust to std::string.
3376         (delete_trace_variable_command): Likewise.
3377         (tvariables_info_1): Adjust to std::vector.
3378         (save_trace_state_variables): Likewise.
3379         (start_tracing): Likewise.
3380         (merge_uploaded_trace_state_variables): Adjust to std::vector
3381         and std::string.
3382         * target.h (struct target_ops)
3383         <to_download_trace_state_variable>: Pass reference to
3384         trace_state_variable.
3385         * target-debug.h (target_debug_print_const_trace_state_variable_r): New.
3386         * target-delegates.c: Re-generate.
3387         * mi/mi-interp.c (mi_tsv_created): Adjust to std::string.
3388         (mi_tsv_deleted): Likewise.
3389         * mi/mi-main.c (mi_cmd_trace_frame_collected): Likewise.
3390         * remote.c (remote_download_trace_state_variable): Change
3391         pointer to reference and adjust.
3392         * make-target-delegates (parse_argtypes): Handle references.
3393         (write_function_header): Likewise.
3394         (munge_type): Likewise.
3395
3396 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3397
3398         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
3399         string_view-selftests.c.
3400         * unittests/basic_string_view/capacity/1.cc: Adapt to GDB
3401         testsuite.
3402         * unittests/basic_string_view/cons/char/1.cc: Likewise.
3403         * unittests/basic_string_view/cons/char/2.cc: Likewise.
3404         * unittests/basic_string_view/cons/char/3.cc: Likewise.
3405         * unittests/basic_string_view/element_access/char/1.cc:
3406         Likewise.
3407         * unittests/basic_string_view/element_access/char/empty.cc:
3408         Likewise.
3409         * unittests/basic_string_view/element_access/char/front_back.cc:
3410         Likewise.
3411         * unittests/basic_string_view/inserters/char/2.cc: Likewise.
3412         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc:
3413         Likewise.
3414         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc:
3415         Likewise.
3416         * unittests/basic_string_view/modifiers/swap/char/1.cc:
3417         Likewise.
3418         * unittests/basic_string_view/operations/compare/char/1.cc:
3419         Likewise.
3420         * unittests/basic_string_view/operations/compare/char/13650.cc:
3421         Likewise.
3422         * unittests/basic_string_view/operations/copy/char/1.cc:
3423         Likewise.
3424         * unittests/basic_string_view/operations/data/char/1.cc:
3425         Likewise.
3426         * unittests/basic_string_view/operations/find/char/1.cc:
3427         Likewise.
3428         * unittests/basic_string_view/operations/find/char/2.cc:
3429         Likewise.
3430         * unittests/basic_string_view/operations/find/char/3.cc:
3431         Likewise.
3432         * unittests/basic_string_view/operations/find/char/4.cc:
3433         Likewise.
3434         * unittests/basic_string_view/operations/rfind/char/1.cc:
3435         Likewise.
3436         * unittests/basic_string_view/operations/rfind/char/2.cc:
3437         Likewise.
3438         * unittests/basic_string_view/operations/rfind/char/3.cc:
3439         Likewise.
3440         * unittests/basic_string_view/operations/substr/char/1.cc:
3441         Likewise.
3442         * unittests/basic_string_view/operators/char/2.cc: Likewise.
3443         * unittests/string_view-selftests.c: New file.
3444
3445 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3446
3447         * unittests/basic_string_view/capacity/1.cc: New file.
3448         * unittests/basic_string_view/capacity/empty_neg.cc: New file.
3449         * unittests/basic_string_view/cons/char/1.cc: New file.
3450         * unittests/basic_string_view/cons/char/2.cc: New file.
3451         * unittests/basic_string_view/cons/char/3.cc: New file.
3452         * unittests/basic_string_view/cons/wchar_t/1.cc: New file.
3453         * unittests/basic_string_view/cons/wchar_t/2.cc: New file.
3454         * unittests/basic_string_view/cons/wchar_t/3.cc: New file.
3455         * unittests/basic_string_view/element_access/char/1.cc: New file.
3456         * unittests/basic_string_view/element_access/char/2.cc: New file.
3457         * unittests/basic_string_view/element_access/char/empty.cc: New file.
3458         * unittests/basic_string_view/element_access/char/front_back.cc: New file.
3459         * unittests/basic_string_view/element_access/wchar_t/1.cc: New file.
3460         * unittests/basic_string_view/element_access/wchar_t/2.cc: New file.
3461         * unittests/basic_string_view/element_access/wchar_t/empty.cc: New file.
3462         * unittests/basic_string_view/element_access/wchar_t/front_back.cc: New file.
3463         * unittests/basic_string_view/include.cc: New file.
3464         * unittests/basic_string_view/inserters/char/1.cc: New file.
3465         * unittests/basic_string_view/inserters/char/2.cc: New file.
3466         * unittests/basic_string_view/inserters/char/3.cc: New file.
3467         * unittests/basic_string_view/inserters/pod/10081-out.cc: New file.
3468         * unittests/basic_string_view/inserters/wchar_t/1.cc: New file.
3469         * unittests/basic_string_view/inserters/wchar_t/2.cc: New file.
3470         * unittests/basic_string_view/inserters/wchar_t/3.cc: New file.
3471         * unittests/basic_string_view/literals/types.cc: New file.
3472         * unittests/basic_string_view/literals/values.cc: New file.
3473         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc: New file.
3474         * unittests/basic_string_view/modifiers/remove_prefix/wchar_t/1.cc: New file.
3475         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc: New file.
3476         * unittests/basic_string_view/modifiers/remove_suffix/wchar_t/1.cc: New file.
3477         * unittests/basic_string_view/modifiers/swap/char/1.cc: New file.
3478         * unittests/basic_string_view/modifiers/swap/wchar_t/1.cc: New file.
3479         * unittests/basic_string_view/operations/compare/char/1.cc: New file.
3480         * unittests/basic_string_view/operations/compare/char/13650.cc: New file.
3481         * unittests/basic_string_view/operations/compare/char/2.cc: New file.
3482         * unittests/basic_string_view/operations/compare/char/70483.cc: New file.
3483         * unittests/basic_string_view/operations/compare/wchar_t/1.cc: New file.
3484         * unittests/basic_string_view/operations/compare/wchar_t/13650.cc: New file.
3485         * unittests/basic_string_view/operations/compare/wchar_t/2.cc: New file.
3486         * unittests/basic_string_view/operations/copy/char/1.cc: New file.
3487         * unittests/basic_string_view/operations/copy/wchar_t/1.cc: New file.
3488         * unittests/basic_string_view/operations/data/char/1.cc: New file.
3489         * unittests/basic_string_view/operations/data/wchar_t/1.cc: New file.
3490         * unittests/basic_string_view/operations/find/char/1.cc: New file.
3491         * unittests/basic_string_view/operations/find/char/2.cc: New file.
3492         * unittests/basic_string_view/operations/find/char/3.cc: New file.
3493         * unittests/basic_string_view/operations/find/char/4.cc: New file.
3494         * unittests/basic_string_view/operations/find/wchar_t/1.cc: New file.
3495         * unittests/basic_string_view/operations/find/wchar_t/2.cc: New file.
3496         * unittests/basic_string_view/operations/find/wchar_t/3.cc: New file.
3497         * unittests/basic_string_view/operations/find/wchar_t/4.cc: New file.
3498         * unittests/basic_string_view/operations/rfind/char/1.cc: New file.
3499         * unittests/basic_string_view/operations/rfind/char/2.cc: New file.
3500         * unittests/basic_string_view/operations/rfind/char/3.cc: New file.
3501         * unittests/basic_string_view/operations/rfind/wchar_t/1.cc: New file.
3502         * unittests/basic_string_view/operations/rfind/wchar_t/2.cc: New file.
3503         * unittests/basic_string_view/operations/rfind/wchar_t/3.cc: New file.
3504         * unittests/basic_string_view/operations/string_conversion/1.cc: New file.
3505         * unittests/basic_string_view/operations/substr/char/1.cc: New file.
3506         * unittests/basic_string_view/operations/substr/wchar_t/1.cc: New file.
3507         * unittests/basic_string_view/operators/char/2.cc: New file.
3508         * unittests/basic_string_view/operators/wchar_t/2.cc: New file.
3509         * unittests/basic_string_view/range_access/char/1.cc: New file.
3510         * unittests/basic_string_view/range_access/wchar_t/1.cc: New file.
3511         * unittests/basic_string_view/requirements/explicit_instantiation/1.cc: New file.
3512         * unittests/basic_string_view/requirements/explicit_instantiation/char/1.cc: New file.
3513         * unittests/basic_string_view/requirements/explicit_instantiation/char16_t/1.cc: New file.
3514         * unittests/basic_string_view/requirements/explicit_instantiation/char32_t/1.cc: New file.
3515         * unittests/basic_string_view/requirements/explicit_instantiation/wchar_t/1.cc: New file.
3516         * unittests/basic_string_view/requirements/typedefs.cc: New file.
3517         * unittests/basic_string_view/typedefs.cc: New file.
3518         * unittests/basic_string_view/types/1.cc: New file.
3519
3520 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3521
3522         * common/gdb_string_view.h: Remove libstdc++ implementation
3523         details, adjust to gdb reality.
3524         * common/gdb_string_view.tcc: Likewise.
3525         * cli/cli-script.c (struct string_view): Remove.
3526         (user_args) <m_args>: Change element type to gdb::string_view.
3527         (user_args::insert_args): Adjust.
3528
3529 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3530
3531         * common/gdb_string_view.h: New file.
3532         * common/gdb_string_view.tcc: New file.
3533
3534 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3535
3536         * ax_cxx_compile_stdcxx.m4: Sync with upstream.
3537         * configure: Re-generate.
3538
3539 2018-04-09  Pedro Alves  <palves@redhat.com>
3540
3541         * gdbarch.sh: Include "observable.h" instead of "observer.h".
3542         (set_target_gdbarch): Call
3543         gdb::observers::architecture_changed.notify instead of
3544         observer_notify_architecture_changed.
3545
3546 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3547
3548         * tracepoint.c (struct current_traceframe_cleanup): Remove.
3549         (do_restore_current_traceframe_cleanup): Remove.
3550         (restore_current_traceframe_cleanup_dtor): Remove.
3551         (make_cleanup_restore_current_traceframe): Remove.
3552         (scoped_restore_current_traceframe::scoped_restore_current_traceframe):
3553         New.
3554         * tracepoint.h (struct scoped_restore_current_traceframe): New.
3555         * infrun.c (fetch_inferior_event): Use
3556         scoped_restore_current_traceframe.
3557
3558 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3559
3560         * dwarf2read.h (struct dwarf2_per_objfile) <n_type_units>:
3561         Remove.
3562         <n_allocated_type_units>: Remove.
3563         <all_type_units>: Change to std::vector.
3564         * dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile): Adjust
3565         to std::vector change.
3566         (dwarf2_per_objfile::get_cutu): Likewise.
3567         (dwarf2_per_objfile::get_tu): Likewise.
3568         (create_signatured_type_table_from_index): Likewise.
3569         (create_signatured_type_table_from_debug_names): Likewise.
3570         (dw2_symtab_iter_next): Likewise.
3571         (dw2_print_stats): Likewise.
3572         (dw2_expand_all_symtabs): Likewise.
3573         (dw2_expand_marked_cus): Likewise.
3574         (dw2_debug_names_iterator::next): Likewise.
3575         (dwarf2_initialize_objfile): Likewise.
3576         (add_signatured_type_cu_to_table): Likewise.
3577         (create_all_type_units): Likewise.
3578         (add_type_unit): Likewise.
3579         (struct tu_abbrev_offset): Add constructor.
3580         (build_type_psymtabs_1): Adjust to std::vector change.
3581         (print_tu_stats): Likewise.
3582         * dwarf-index-write.c (check_dwarf64_offsets): Likewise.
3583         (write_debug_names): Likewise.
3584
3585 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3586
3587         * dwarf2read.h (struct dwarf2_per_objfile) <all_comp_units>: Likewise.
3588         Make an std::vector.
3589         <n_comp_units>: Remove.
3590         * dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile): Adjust
3591         to std::vector change.
3592         (dwarf2_per_objfile::get_cutu): Likewise.
3593         (dwarf2_per_objfile::get_cu): Likewise.
3594         (create_cus_from_index): Likewise.
3595         (create_addrmap_from_index): Likewise.
3596         (create_addrmap_from_aranges): Likewise.
3597         (dwarf2_read_index): Likewise.
3598         (dw2_find_last_source_symtab): Likewise.
3599         (dw2_map_symtabs_matching_filename): Likewise.
3600         (dw2_symtab_iter_next): Likewise.
3601         (dw2_print_stats): Likewise.
3602         (dw2_expand_all_symtabs): Likewise.
3603         (dw2_expand_symtabs_with_fullname): Likewise.
3604         (dw2_expand_marked_cus): Likewise.
3605         (dw2_map_symbol_filenames): Likewise.
3606         (create_cus_from_debug_names): Likewise.
3607         (dwarf2_read_debug_names): Likewise.
3608         (dw2_debug_names_iterator::next): Likewise.
3609         (dwarf2_initialize_objfile): Likewise.
3610         (set_partial_user): Likewise.
3611         (dwarf2_build_psymtabs_hard): Likewise.
3612         (read_comp_units_from_section): Remove arguments, adjust to
3613         std::vector change.
3614         (create_all_comp_units): Adjust to std::vector and
3615         read_comp_units_from_section changes.
3616         (dwarf2_find_containing_comp_unit): Adjust to std::vector
3617         change.
3618         * dwarf-index-write.c (check_dwarf64_offsets): Likewise.
3619         (psyms_seen_size): Likewise.
3620         (write_gdbindex): Likewise.
3621         (write_debug_names): Likewise.
3622
3623 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3624
3625         * dwarf2read.c (create_cus_from_index_list): Replace objfile arg
3626         with dwarf2_per_objfile.
3627         (create_cus_from_index): Likewise.
3628         (create_signatured_type_table_from_index): Likewise.
3629         (dwarf2_read_index): Likewise.
3630         (dwarf2_initialize_objfile): Likewise.
3631         (dwarf2_fetch_die_loc_sect_off):  Get dwarf2_per_objfile from
3632         per_cu rather than get_dwarf2_per_objfile.
3633
3634 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3635
3636         * dwarf2read.h (struct signatured_type): Forward declare.
3637         (struct dwarf2_per_objfile) <get_cutu, get_cu, get_tu>:
3638         New methods.
3639         * dwarf2read.c (dwarf2_per_objfile::get_cutu): Rename from...
3640         (dw2_get_cutu): ...this.
3641         (dwarf2_per_objfile::get_cu): Rename from...
3642         (dw2_get_cu): ...this.
3643         (dwarf2_per_objfile::get_tu): New.
3644         (create_addrmap_from_index): Adjust.
3645         (create_addrmap_from_aranges): Adjust.
3646         (dw2_find_last_source_symtab): Adjust.
3647         (dw2_map_symtabs_matching_filename): Adjust.
3648         (dw2_symtab_iter_next): Adjust.
3649         (dw2_print_stats): Adjust.
3650         (dw2_expand_all_symtabs): Adjust.
3651         (dw2_expand_symtabs_with_fullname): Adjust.
3652         (dw2_expand_marked_cus): Adjust.
3653         (dw_expand_symtabs_matching_file_matcher): Adjust.
3654         (dw2_map_symbol_filenames): Adjust.
3655         (dw2_debug_names_iterator::next): Adjust.
3656         (dwarf2_initialize_objfile): Adjust.
3657         (set_partial_user): Adjust.
3658         (dwarf2_build_psymtabs_hard): Adjust.
3659
3660 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3661
3662         * dwarf2read.c (create_signatured_type_table_from_debug_names):
3663         Remove unused variables.
3664         (dw2_map_symtabs_matching_filename): Likewise.
3665         (dwarf2_record_block_ranges): Likewise.
3666         (dwarf2_read_addr_index): Likewise.
3667         (follow_die_offset): Likewise.
3668
3669 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3670
3671         * progspace.c (clone_program_space): Pass SYMFILE_DEFER_BP_RESET
3672         to symbol_file_add_main.
3673
3674 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3675
3676         PR mi/22299
3677         * mi/mi-console.c (do_fputc_async_safe): New.
3678         (mi_console_file::write_async_safe): New.
3679         (mi_console_file::flush): Adjust calls to fputstrn_unfiltered.
3680         * mi/mi-console.h (class mi_console_file) <write_async_safe>:
3681         New.
3682         * ui-file.c (ui_file::putstrn): Adjust call to
3683         fputstrn_unfiltered.
3684         * utils.c (printchar): Replace do_fputs and do_fprintf
3685         parameters by do_fputc.
3686         (fputstr_filtered): Adjust call to printchar.
3687         (fputstr_unfiltered): Likewise.
3688         (fputstrn_filtered): Likewise.
3689         (fputstrn_unfiltered): Add do_fputc parameter, pass to
3690         printchar.
3691         * utils.h (do_fputc_ftype): New typedef.
3692         (fputstrn_unfiltered): Add do_fputc parameter.
3693
3694 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3695
3696         * regformats/i386/i386-avx.dat: Remove.
3697
3698 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
3699
3700         PR gdb/22979
3701         * amd64-tdep.c (amd64_none_init_abi): New function.
3702         (amd64_x32_none_init_abi): New function.
3703         (_initialize_amd64_tdep): Register handlers for x86-64 and
3704         x64_32 with GDB_OSABI_NONE.
3705         * osabi.c (gdbarch_init_osabi): Allow running handlers for the
3706         GDB_OSABI_NONE osabi.
3707
3708 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
3709
3710         PR gdb/22980
3711         * defs.h (enum gdb_osabi): Remove GDB_OSABI_UNINITIALIZED, add
3712         GDB_OSABI_NONE.
3713         * arch-utils.c (gdbarch_info_init): Don't set info->osabi.
3714         * osabi.c (gdb_osabi_names): Add "unknown" entry.
3715
3716 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
3717
3718         * common/byte-vector.h (char_vector): New type.
3719         * target.h (target_read_alloc): Return
3720         gdb::optional<byte_vector>.
3721         (target_read_stralloc): Return gdb::optional<char_vector>.
3722         (target_get_osdata): Return gdb::optional<char_vector>.
3723         * target.c (target_read_alloc_1): Templatize.  Replacement
3724         manual memory management with vector.
3725         (target_read_alloc): Change return type, adjust.
3726         (target_read_stralloc): Change return type, adjust.
3727         (target_get_osdata): Change return type, adjust.
3728         * auxv.c (struct auxv_info) <length>: Remove.
3729         <data>: Change type to gdb::optional<byte_vector>.
3730         (auxv_inferior_data_cleanup): Free auxv_info with delete.
3731         (get_auxv_inferior_data): Allocate auxv_info with new, adjust.
3732         (target_auxv_search): Adjust.
3733         (fprint_target_auxv): Adjust.
3734         * avr-tdep.c (avr_io_reg_read_command): Adjust.
3735         * linux-tdep.c (linux_spu_make_corefile_notes): Adjust.
3736         (linux_make_corefile_notes): Adjust.
3737         * osdata.c (get_osdata): Adjust.
3738         * remote.c (remote_get_threads_with_qxfer): Adjust.
3739         (remote_memory_map): Adjust.
3740         (remote_traceframe_info): Adjust.
3741         (btrace_read_config): Adjust.
3742         (remote_read_btrace): Adjust.
3743         (remote_pid_to_exec_file): Adjust.
3744         * solib-aix.c (solib_aix_get_library_list): Adjust.
3745         * solib-dsbt.c (decode_loadmap): Don't free buf.
3746         (dsbt_get_initial_loadmaps): Adjust.
3747         * solib-svr4.c (svr4_current_sos_via_xfer_libraries): Adjust.
3748         * solib-target.c (solib_target_current_sos): Adjust.
3749         * tracepoint.c (sdata_make_value): Adjust.
3750         * xml-support.c (xinclude_start_include): Adjust.
3751         (xml_fetch_content_from_file): Adjust.
3752         * xml-support.h (xml_fetch_another): Change return type.
3753         (xml_fetch_content_from_file): Change return type.
3754         * xml-syscall.c (xml_init_syscalls_info): Adjust.
3755         * xml-tdesc.c (file_read_description_xml): Adjust.
3756         (fetch_available_features_from_target): Change return type.
3757         (target_fetch_description_xml): Adjust.
3758         (target_read_description_xml): Adjust.
3759
3760 2018-04-06  Tom Tromey  <tom@tromey.com>
3761
3762         * value.c (~value): Update.
3763         (struct value) <contents>: Now unique_xmalloc_ptr.
3764         (value_contents_bits_eq, allocate_value_contents)
3765         (value_contents_raw, value_contents_all_raw)
3766         (value_contents_for_printing, value_contents_for_printing_const)
3767         (set_value_enclosing_type): Update.
3768
3769 2018-04-06  Tom Tromey  <tom@tromey.com>
3770
3771         * value.c (range_s): Remove typedef, VEC.
3772         (struct range): Add operator<.
3773         (range_lessthan): Remove.
3774         (ranges_contain): Change type.
3775         (~value): Update.
3776         (struct value) <unavailable, optimized_out>: Now std::vector.
3777         (value_entirely_available)
3778         (value_entirely_covered_by_range_vector)
3779         (value_entirely_unavailable, value_entirely_optimized_out):
3780         Update.
3781         (insert_into_bit_range_vector): Change argument type.
3782         (find_first_range_overlap): Likewise.
3783         (struct ranges_and_idx, value_contents_bits_eq)
3784         (require_not_optimized_out, require_available): Update.
3785         (ranges_copy_adjusted): Change argument types.
3786         (value_optimized_out, value_copy, value_fetch_lazy): Update.
3787
3788 2018-04-06  Tom Tromey  <tom@tromey.com>
3789
3790         * value.c (~value): Update.
3791         (struct value) <parent>: Now a value_ref_ptr.
3792         (value_parent, set_value_parent, value_address, value_copy):
3793         Update.
3794
3795 2018-04-06  Tom Tromey  <tom@tromey.com>
3796
3797         * value.c (struct value): Add constructor, destructor, and member
3798         initializers.
3799         (allocate_value_lazy, value_decref): Update.
3800
3801 2018-04-06  Tom Tromey  <tom@tromey.com>
3802
3803         * value.c (struct value) <released, next>: Remove.
3804         (all_values): Now a std::vector.
3805         (allocate_value_lazy): Update.
3806         (value_next): Remove.
3807         (value_mark, value_free_to_mark, release_value)
3808         (value_release_to_mark): Update.
3809
3810 2018-04-06  Tom Tromey  <tom@tromey.com>
3811
3812         * value.h (fetch_subexp_value, value_release_to_mark): Update.
3813         (free_value_chain): Remove.
3814         * value.c (free_value_chain): Remove.
3815         (value_release_to_mark): Return a std::vector.
3816         * ppc-linux-nat.c (num_memory_accesses): Change "chain" to a
3817         std::vector.
3818         (check_condition): Update.
3819         * eval.c (fetch_subexp_value): Change "val_chain" to a
3820         std::vector.
3821         * breakpoint.c (update_watchpoint): Update.
3822         (can_use_hardware_watchpoint): Change "vals" to a std::vector.
3823
3824 2018-04-06  Tom Tromey  <tom@tromey.com>
3825
3826         * value.h (free_all_values): Remove.
3827         * value.c (free_all_values): Remove.
3828
3829 2018-04-06  Tom Tromey  <tom@tromey.com>
3830
3831         * value.c (VALUE_HISTORY_CHUNK, struct value_history_chunk)
3832         (value_history_chain, value_history_count): Remove.
3833         (value_history): New global.
3834         (record_latest_value, access_value_history, show_values)
3835         (preserve_values): Update.
3836
3837 2018-04-06  Tom Tromey  <tom@tromey.com>
3838
3839         * varobj.h (struct varobj) <value>: Now a value_ref_ptr.
3840         * varobj.c (varobj_set_display_format, varobj_set_value)
3841         (install_default_visualizer, construct_visualizer)
3842         (install_new_value, ~varobj, varobj_get_value_type)
3843         (my_value_of_variable, varobj_editable_p): Update.
3844         * c-varobj.c (c_describe_child, c_value_of_variable)
3845         (cplus_number_of_children, cplus_describe_child): Update.
3846         * ada-varobj.c (ada_number_of_children, ada_name_of_child)
3847         (ada_path_expr_of_child, ada_value_of_child, ada_type_of_child)
3848         (ada_value_of_variable, ada_value_is_changeable_p): Update.
3849
3850 2018-04-06  Tom Tromey  <tom@tromey.com>
3851
3852         * printcmd.c (last_examine_address): Change type to
3853         value_ref_ptr.
3854         (do_examine, x_command): Update.
3855
3856 2018-04-06  Tom Tromey  <tom@tromey.com>
3857
3858         * value.c (release_value): Update.
3859         * breakpoint.h (struct watchpoint) <val>: Now a value_ref_ptr.
3860         (struct bpstats) <val>: Now a value_ref_ptr.
3861         * breakpoint.c (update_watchpoint, breakpoint_init_inferior)
3862         (~bpstats, bpstats, bpstat_clear_actions, watchpoint_check)
3863         (~watchpoint, print_it_watchpoint, watch_command_1)
3864         (invalidate_bp_value_on_memory_change): Update.
3865
3866 2018-04-06  Tom Tromey  <tom@tromey.com>
3867
3868         * varobj.c (varobj_clear_saved_item)
3869         (update_dynamic_varobj_children, install_new_value, ~varobj):
3870         Update.
3871         * value.h (value_incref): Move declaration earlier.
3872         (value_decref): Rename from value_free.
3873         (struct value_ref_policy): New.
3874         (value_ref_ptr): New typedef.
3875         (struct value_deleter): Remove.
3876         (gdb_value_up): Remove typedef.
3877         (release_value): Change return type.
3878         (release_value_or_incref): Remove.
3879         * value.c (set_value_parent): Update.
3880         (value_incref): Change return type.
3881         (value_decref): Rename from value_free.
3882         (value_free_to_mark, free_all_values, free_value_chain): Update.
3883         (release_value): Return value_ref_ptr.
3884         (release_value_or_incref): Remove.
3885         (record_latest_value, set_internalvar, clear_internalvar):
3886         Update.
3887         * stack.c (info_frame_command): Don't call value_free.
3888         * python/py-value.c (valpy_dealloc, valpy_new)
3889         (value_to_value_object): Update.
3890         * printcmd.c (do_examine): Update.
3891         * opencl-lang.c (lval_func_free_closure): Update.
3892         * mi/mi-main.c (register_changed_p): Don't call value_free.
3893         * mep-tdep.c (mep_frame_prev_register): Don't call value_free.
3894         * m88k-tdep.c (m88k_frame_prev_register): Don't call value_free.
3895         * m68hc11-tdep.c (m68hc11_frame_prev_register): Don't call
3896         value_free.
3897         * guile/scm-value.c (vlscm_free_value_smob)
3898         (vlscm_scm_from_value): Update.
3899         * frame.c (frame_register_unwind, frame_unwind_register_signed)
3900         (frame_unwind_register_unsigned, get_frame_register_bytes)
3901         (put_frame_register_bytes): Don't call value_free.
3902         * findvar.c (address_from_register): Don't call value_free.
3903         * dwarf2read.c (dwarf2_compute_name): Don't call value_free.
3904         * dwarf2loc.c (entry_data_value_free_closure)
3905         (value_of_dwarf_reg_entry, free_pieced_value_closure)
3906         (dwarf2_evaluate_loc_desc_full): Update.
3907         * breakpoint.c (update_watchpoint, breakpoint_init_inferior)
3908         (~bpstats, bpstats, bpstat_clear_actions, watchpoint_check)
3909         (~watchpoint, watch_command_1)
3910         (invalidate_bp_value_on_memory_change): Update.
3911         * alpha-tdep.c (alpha_register_to_value): Don't call value_free.
3912
3913 2018-04-06  Simon Marchi  <simon.marchi@polymtl.ca>
3914
3915         PR gdb/23022
3916         * warning.m4: Add -Wno-error=deprecated-register.
3917         * configure: Re-generate.
3918
3919 2018-04-05  Tom Tromey  <tom@tromey.com>
3920
3921         * linespec.h: Remove include of "vec.h".
3922
3923 2018-04-05  Tom Tromey  <tom@tromey.com>
3924
3925         * linespec.c (typep): Remove typedef.
3926         (find_methods, find_superclass_methods): Take a std::vector.
3927         (find_method): Use std::vector.
3928
3929 2018-04-05  Tom Tromey  <tom@tromey.com>
3930
3931         * utils.c (compare_strings): Remove.
3932         * utils.h (compare_strings): Remove.
3933         * objc-lang.h (find_imps): Update.
3934         * objc-lang.c (find_methods): Take a std::vector.
3935         (uniquify_strings, find_imps): Likewise.
3936         * linespec.c (find_methods): Take a std::vector.
3937         (decode_objc): Use std::vector.
3938         (add_all_symbol_names_from_pspace, find_superclass_methods): Take
3939         a std::vector.
3940         (find_method, find_function_symbols): Use std::vector.
3941
3942 2018-04-05  Tom Tromey  <tom@tromey.com>
3943
3944         * completer.c (completion_tracker::completion_tracker): Remove
3945         cast.
3946         (completion_tracker::discard_completions): Likewise.
3947         * breakpoint.c (ambiguous_names_p): Remove cast.
3948         * ada-lang.c (_initialize_ada_language): Remove cast.
3949         * utils.h (streq): Update.
3950         (streq_hash): Add new declaration.
3951         * utils.c (streq): Return bool.
3952         (streq_hash): New function.
3953
3954 2018-04-05  Tom Tromey  <tom@tromey.com>
3955
3956         * linespec.c (event_location_to_sals) <case ADDRESS_LOCATION>:
3957         Remove a string copy.
3958
3959 2018-04-05  Tom Tromey  <tom@tromey.com>
3960
3961         * linespec.c (filter_results): Use std::vector.
3962         (decode_line_2, decode_line_full): Update.
3963
3964 2018-04-05  Tom Tromey  <tom@tromey.com>
3965
3966         * linespec.c (canonical_to_fullform): Return std::string.
3967         (filter_results): Update.
3968         (struct decode_line_2_item): Add constructor.
3969         <fullform, displayform>: Now std::string.
3970         (decode_line_2_compare_items): Now a std::sort comparator.
3971         (decode_line_2): Update.
3972
3973 2018-04-05  Tom Tromey  <tom@tromey.com>
3974
3975         * linespec.c (copy_token_string): Return a unique_xmalloc_ptr.
3976         (unexpected_linespec_error): Update.
3977         (linespec_parse_basic, parse_linespec): Update.
3978
3979 2018-04-05  Tom Tromey  <tom@tromey.com>
3980
3981         * linespec.c (linespec_parse_basic): Reindent.
3982
3983 2018-04-05  Tom Tromey  <tom@tromey.com>
3984
3985         * minsyms.h (iterate_over_minimal_symbols): Update.
3986         * minsyms.c (iterate_over_minimal_symbols): Take a
3987         gdb::function_view.
3988         * linespec.c (struct collect_minsyms): Remove.
3989         (compare_msyms): Now a std::sort comparator.
3990         (add_minsym): Add parameters.
3991         (search_minsyms_for_name): Update.  Use std::vector.
3992
3993 2018-04-03  Tom Tromey  <tom@tromey.com>
3994
3995         * mipsread.c (read_alphacoff_dynamic_symtab): Use
3996         gdb::byte_vector.
3997
3998 2018-04-02  Weimin Pan  <weimin.pan@oracle.com>
3999
4000         * MAINTAINERS (Write After Approval): Add Weimin Pan.
4001
4002 2018-04-02  Weimin Pan  <weimin.pan@oracle.com>
4003
4004         PR gdb/16959
4005         * cp-valprint.c: (cp_print_static_field) Fix infinite recursion when 
4006         printing static type.
4007
4008 2018-04-01  Tom Tromey  <tom@tromey.com>
4009
4010         * rs6000-nat.c (rs6000_ptrace_ldinfo): Return a byte_vector.
4011         (rs6000_xfer_shared_libraries): Update.
4012
4013 2018-04-01  Simon Marchi  <simon.marchi@polymtl.ca>
4014
4015         * common/gdb_vecs.h (char_ptr): Remove.
4016         * tracepoint.c (encode_actions_1): Remove usage of char_ptr.
4017
4018 2018-03-30  Simon Marchi  <simon.marchi@polymtl.ca>
4019
4020         * guile/scm-utils.c (gdbscm_parse_function_args): Replace VEC
4021         with std::vector.
4022         * common/gdb_vecs.h (DEF_VEC_P (char_ptr)): Remove.
4023
4024 2018-03-30  Simon Marchi  <simon.marchi@polymtl.ca>
4025
4026         * tracepoint.h (struct uploaded_tp): Initialize fields.
4027         <actions, step_actions, cmd_strings>: Change type to
4028         std::vector<char *>.
4029         * tracepoint.c (get_uploaded_tp): Allocate with new.
4030         (free_uploaded_tps): Free with delete.
4031         (parse_tracepoint_definition): Adjust to std::vector change.
4032         * breakpoint.c (read_uploaded_action): Likewise.
4033         (create_tracepoint_from_upload): Likewise.
4034         * ctf.c (ctf_write_uploaded_tp): Likewise.
4035         (SET_ARRAY_FIELD): Likewise.
4036         * tracefile-tfile.c (tfile_write_uploaded_tp): Likewise.
4037
4038 2018-03-30  Tom Tromey  <tom@tromey.com>
4039
4040         * solib-svr4.c (lm_info_read): Use gdb::byte_vector.  Return
4041         std::unique_ptr.
4042         (svr4_keep_data_in_core): Update.
4043         (svr4_read_so_list): Update.
4044
4045 2018-03-30  Tom Tromey  <tom@tromey.com>
4046
4047         * windows-nat.c (handle_output_debug_string, handle_exception):
4048         Update.
4049         * target.h (target_read_string): Update.
4050         * target.c (target_read_string): Change "string" to
4051         unique_xmalloc_ptr.
4052         * solib-svr4.c (open_symbol_file_object, svr4_read_so_list):
4053         Update.
4054         * solib-frv.c (frv_current_sos): Update.
4055         * solib-dsbt.c (dsbt_current_sos): Update.
4056         * solib-darwin.c (darwin_current_sos): Update.
4057         * linux-thread-db.c (inferior_has_bug): Update.
4058         * expprint.c (print_subexp_standard) <case OP_OBJC_MSGCALL>:
4059         Update.  Remove alloca.
4060         * ada-lang.c (ada_main_name): Update.
4061
4062 2018-03-30  Tom Tromey  <tom@tromey.com>
4063
4064         * dwarf2read.c (struct free_dwo_file_cleanup_data): Remove.
4065         (struct dwo_file_deleter): New.
4066         (dwo_file_up): New typedef.
4067         (open_and_init_dwo_file): Use dwo_file_up.
4068         (free_dwo_file_cleanup): Remove.
4069
4070 2018-03-30  Tom Tromey  <tom@tromey.com>
4071
4072         * dwarf2read.c (free_dwo_file): Remove "objfile" parameter.
4073         (free_dwo_file_cleanup, free_dwo_file_from_slot): Update.
4074
4075 2018-03-30  Tom Tromey  <tom@tromey.com>
4076
4077         * dwarf2read.c (class free_cached_comp_units): New class.
4078         (dw2_instantiate_symtab, dwarf2_build_psymtabs_hard): Use it.
4079         (free_cached_comp_units): Remove function.
4080
4081 2018-03-30  Tom Tromey  <tom@tromey.com>
4082
4083         * utils.h (make_cleanup_unpush_target): Remove.
4084         * inf-ptrace.c (struct target_unpusher): New.
4085         (target_unpush_up) New typedef.
4086         (inf_ptrace_create_inferior, inf_ptrace_attach): Use
4087         target_unpush_up.
4088         * utils.c (do_unpush_target, make_cleanup_unpush_target): Remove.
4089
4090 2018-03-27  Tom Tromey  <tom@tromey.com>
4091
4092         * utils.c (prompt_for_continue): Use unique_xmalloc_ptr.
4093
4094 2018-03-27  Pedro Alves  <palves@redhat.com>
4095             Tom Tromey  <tom@tromey.com>
4096
4097         * top.c (class gdb_readline_wrapper_cleanup): Add constructor,
4098         destructor.  Now a class.
4099         (gdb_readline_wrapper_cleanup): Remove function.
4100         (gdb_readline_wrapper): Remove cleanups.
4101
4102 2018-03-27  Tom Tromey  <tom@tromey.com>
4103
4104         * typeprint.h (struct type_print_options) <local_typedefs,
4105         global_typedefs>: Remove "struct" keyword.
4106         (class typedef_hash_table): New class.
4107         (recursively_update_typedef_hash, add_template_parameters)
4108         (create_typedef_hash, free_typedef_hash, copy_typedef_hash)
4109         (find_typedef_in_hash): Don't declare.
4110         * typeprint.c (struct typedef_hash_table): Move to typeprint.h.
4111         (typedef_hash_table::recursively_update): Rename from
4112         recursively_update_typedef_hash.  Now a member.
4113         (typedef_hash_table::add_template_parameters): Rename from
4114         add_template_parameters.  Now a member.
4115         (typedef_hash_table::typedef_hash_table): Now a constructor;
4116         rename from create_typedef_hash.
4117         (typedef_hash_table::~typedef_hash_table): Now a destructor;
4118         rename from free_typedef_hash.
4119         (do_free_typedef_hash, make_cleanup_free_typedef_hash)
4120         (do_free_global_table): Remove.
4121         (typedef_hash_table::typedef_hash_table): New constructor; renamed
4122         from copy_type_recursive.
4123         (create_global_typedef_table): Remove.
4124         (typedef_hash_table::find_global_typedef): Now a member of
4125         typedef_hash_table.
4126         (typedef_hash_table::find_typedef): Rename from
4127         find_typedef_in_hash; now a member.
4128         (whatis_exp): Update.
4129         * extension.h (struct ext_lang_type_printers): Add constructor and
4130         destructor.
4131         (start_ext_lang_type_printers, free_ext_lang_type_printers): Don't
4132         declare.
4133         * extension.c (ext_lang_type_printers::ext_lang_type_printers):
4134         Now a constructor; rename from start_ext_lang_type_printers.
4135         (ext_lang_type_printers): Now a destructor; rename from
4136         free_ext_lang_type_printers.
4137         * c-typeprint.c (find_typedef_for_canonicalize, c_print_type_1):
4138         Update.
4139         (c_type_print_base_struct_union): Update.  Remove cleanups.
4140
4141 2018-03-27  Tom Tromey  <tom@tromey.com>
4142
4143         * dwarf-index-write.c: Include <cmath>.
4144
4145 2018-03-27  Joel Brobecker  <brobecker@adacore.com>
4146
4147         * NEWS: Add entry describing new "set|show varsize-limit" command.
4148         * ada-lang.c (_initialize_ada_language): Add "set/show varsize-limit"
4149         command.
4150         * printcmd.c (_initialize_printcmd): Add "set var" alias of
4151         "set variable".
4152
4153 2018-03-27  Simon Marchi  <simon.marchi@ericsson.com>
4154
4155         * Makefile.in (COMMON_SFILES): Add dwarf-index-common.c and
4156         dwarf-index-write.c
4157         (HFILES_NO_SRCDIR): Add dwarf-index-common.h and dwarf2read.h.
4158         * dwarf-index-common.c: New file.
4159         * dwarf-index-common.h: New file.
4160         * dwarf-index-write.c: New file.
4161         * dwarf2read.c: Include dwarf2read.h and dwarf-index-common.h.
4162         (struct dwarf2_section_info): Move from here.
4163         (dwarf2_section_info_def): Likewise.
4164         (DEF_VEC_O (dwarf2_section_info_def)): Likewise.
4165         (offset_type): Likewise.
4166         (DW2_GDB_INDEX_SYMBOL_STATIC_SET_VALUE): Likewise.
4167         (DW2_GDB_INDEX_SYMBOL_KIND_SET_VALUE): Likewise.
4168         (DW2_GDB_INDEX_CU_SET_VALUE): Likewise.
4169         (byte_swap): Likewise.
4170         (MAYBE_SWAP): Likewise.
4171         (dwarf2_per_cu_ptr): Likewise.
4172         (DEF_VEC_P (dwarf2_per_cu_ptr)): Likewise.
4173         (struct tu_stats): Likewise.
4174         (struct dwarf2_per_objfile): Likewise.
4175         (struct dwarf2_per_cu_data): Likewise.
4176         (struct signatured_type): Likewise.
4177         (sig_type_ptr): Likewise.
4178         (DEF_VEC_P (sig_type_ptr)): Likewise.
4179         (INDEX4_SUFFIX): Likewise.
4180         (INDEX5_SUFFIX): Likewise.
4181         (DEBUG_STR_SUFFIX): Likewise.
4182         (dwarf2_read_section): Make non-static.
4183         (mapped_index_string_hash): Move from here.
4184         (dwarf5_djb_hash): Likewise.
4185         (file_write): Likewise.
4186         (class data_buf): Likewise.
4187         (struct symtab_index_entry): Likewise.
4188         (struct mapped_symtab): Likewise.
4189         (find_slot): Likewise.
4190         (hash_expand): Likewise.
4191         (add_index_entry): Likewise.
4192         (uniquify_cu_indices): Likewise.
4193         (class c_str_view): Likewise.
4194         (class c_str_view_hasher): Likewise.
4195         (class vector_hasher): Likewise.
4196         (write_hash_table): Likewise.
4197         (psym_index_map): Likewise.
4198         (struct addrmap_index_data): Likewise.
4199         (add_address_entry): Likewise.
4200         (add_address_entry_worker): Likewise.
4201         (write_address_map): Likewise.
4202         (symbol_kind): Likewise.
4203         (write_psymbols): Likewise.
4204         (struct signatured_type_index_data): Likewise.
4205         (write_one_signatured_type): Likewise.
4206         (recursively_count_psymbols): Likewise.
4207         (recursively_write_psymbols): Likewise.
4208         (class debug_names): Likewise.
4209         (check_dwarf64_offsets): Likewise.
4210         (psyms_seen_size): Likewise.
4211         (write_gdbindex): Likewise.
4212         (write_debug_names): Likewise.
4213         (assert_file_size): Likewise.
4214         (write_psymtabs_to_index): Likewise.
4215         (save_gdb_index_command): Likewise.
4216         (_initialize_dwarf2_read): Don't register the "save gdb-index"
4217         command.
4218         * dwarf2read.h: New file.
4219
4220 2018-03-27  Joel Brobecker  <brobecker@adacore.com>
4221
4222         PR gdb/22670
4223         * dwarf2read.c (dwarf2_physname): Do not return the demangled
4224         symbol name if the CU's language stores symbol names in linkage
4225         format.
4226         * language.h (struct language_defn)
4227         <la_store_sym_names_in_linkage_form_p>: New field.  Adjust
4228         all instances of this struct.
4229
4230 2018-03-26  Tom Tromey  <tom@tromey.com>
4231
4232         * stack.c (backtrace_command_1): Remove verbose code.
4233
4234 2018-03-26  Tom Tromey  <tom@tromey.com>
4235
4236         * python/py-framefilter.c (py_print_type): Don't catch
4237         exceptions.  Return void.
4238         (py_print_value): Likewise.
4239         (py_print_single_arg): Likewise.
4240         (enumerate_args): Don't catch exceptions.
4241         (py_print_args): Likewise.
4242         (py_print_frame): Likewise.
4243         (gdbpy_apply_frame_filter): Catch exceptions here.
4244
4245 2018-03-26  Tom Tromey  <tom@tromey.com>
4246
4247         * stack.c (_initialize_stack): Remove trailing newlines from help
4248         text.  Add "Usage" line to "backtrace" help.
4249
4250 2018-03-26  Tom Tromey  <tom@tromey.com>
4251
4252         PR python/16486:
4253         * python/py-framefilter.c (py_print_args): Call wrap_hint.
4254
4255 2018-03-26  Tom Tromey  <tom@tromey.com>
4256
4257         * python/py-framefilter.c (py_print_single_arg): Return
4258         EXT_LANG_BT_ERROR from catch.
4259
4260 2018-03-26  Tom Tromey  <tom@tromey.com>
4261
4262         PR backtrace/15584:
4263         * stack.c (backtrace_command_1): Move some code into no-filters
4264         "if".
4265
4266 2018-03-26  Tom Tromey  <tom@tromey.com>
4267
4268         * python/py-framefilter.c (throw_quit_or_print_exception): New
4269         function.
4270         (gdbpy_apply_frame_filter): Use it.
4271
4272 2018-03-26  Tom Tromey  <tom@tromey.com>
4273
4274         PR cli/17716:
4275         * python/py-framefilter.c (py_print_type, py_print_value)
4276         (enumerate_args, py_print_args, gdbpy_apply_frame_filter): Use
4277         RETURN_MASK_ERROR.
4278
4279 2018-03-26  Tom Tromey  <tom@tromey.com>
4280
4281         * python/py-framefilter.c (enumerate_args): Use
4282         gdb::unique_xmalloc_ptr.
4283
4284 2018-03-26  Tom Tromey  <tom@tromey.com>
4285
4286         * python/py-framefilter.c (py_print_frame): Return
4287         EXT_LANG_BT_OK.
4288         (gdbpy_apply_frame_filter): Update comment.
4289         * extension.h (enum ext_lang_bt_status) <EXT_LANG_BT_COMPLETED>:
4290         Remove.
4291         <EXT_LANG_BT_NO_FILTERS>: Change value.
4292
4293 2018-03-26  Tom Tromey  <tom@tromey.com>
4294
4295         PR backtrace/15582:
4296         * stack.c (backtrace_command): Parse "hide" argument.
4297         * python/py-framefilter.c (py_print_frame): Handle PRINT_HIDE.
4298         * extension.h (enum frame_filter_flags) <PRINT_HIDE>: New
4299         constant.
4300
4301 2018-03-26  Tom Tromey  <tom@tromey.com>
4302
4303         * stack.c (backtrace_command_1): Remove "show_locals" parameter,
4304         add "flags".
4305         (backtrace_command): Remove "fulltrace", add "flags".
4306
4307 2018-03-26  Tom Tromey  <tom@tromey.com>
4308
4309         * stack.c (backtrace_command): Rewrite command line parsing.
4310
4311 2018-03-26  Simon Marchi  <simon.marchi@ericsson.com>
4312
4313         * dwarf2read.c (DEF_VEC_I(offset_type)): Remove.
4314
4315 2018-03-26  Simon Marchi  <simon.marchi@ericsson.com>
4316
4317         * filename-seen-cache.h: Add include guard.
4318
4319 2018-03-26  Keith Seitz  <keiths@redhat.com>
4320
4321         * symfile.c (place_section): Remove "struct" from section_addr_info
4322         in comment.
4323         * windows-nat.c (struct safe_symbol_file_add_args) <addrs>: Remove
4324         "struct" keyword from section_addr_info.
4325
4326 2018-03-26  Alan Hayward  <alan.hayward@arm.com>
4327
4328         * regformats/regdef.h (reg): Add constructors.
4329
4330 2018-03-25  Pedro Alves  <palves@redhat.com>
4331
4332         * eval.c (evaluate_funcall): Swap OP_VAR_MSYM_VALUE/OP_VAR_VALUE
4333         if then/else bodies in var_func_name extraction.
4334
4335 2018-03-23  Weimin Pan  <weimin.pan@oracle.com>
4336
4337         * minsyms.c (lookup_minimal_symbol_and_objfile): Use
4338         lookup_minimal_symbol() to find symbol entry.
4339         * minsyms.h (lookup_minimal_symbol_and_objfile): Update comment.
4340
4341 2018-03-23  Keith Seitz  <keiths@redhat.com>
4342
4343         PR c++/22968
4344         * dwarf2read.c (scan_partial_symbols): Scan structs/classes for
4345         nested type definitions for C++, too.
4346
4347 2018-03-23  Tom Tromey  <tom@tromey.com>
4348
4349         * machoread.c (struct oso_el): Add a constructor.  Don't define as
4350         a typedef.
4351         (macho_register_oso): Remove.
4352         (macho_symtab_read): Take a std::vector.
4353         (oso_el_compare_name): Now a std::sort comparator.
4354         (macho_symfile_read_all_oso): Take a std::vector.
4355         (macho_symfile_read): Use std::vector.  Remove cleanups.
4356
4357 2018-03-22  Tom Tromey  <tom@tromey.com>
4358
4359         * record-full.c (record_full_exec_insn): Use gdb::byte_vector.
4360         (record_full_goto_bookmark): Use std::string.
4361
4362 2018-03-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
4363
4364         PR tdep/18295
4365         * rs6000-tdep.c (skip_prologue): Match both stwux and stdux
4366         a single mask.
4367
4368 2018-03-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
4369
4370         * rs6000-tdep.c (store_insn_p): New function.
4371         (skip_prologue): New variable alloca_reg_offset. Set lr_reg
4372         and cr_reg to their unshifted values. Use store_insn_p to
4373         match LR saves using either R1 or fdata->alloca_reg. Use
4374         store_insn_p to match CR saves. Set alloca_reg_offset
4375         when alloca_reg and framep are set. Remove lr_reg shift
4376         when assigning to fdata->lr_register.
4377
4378 2018-03-22  Andreas Arnez  <arnez@linux.vnet.ibm.com>
4379
4380         * linux-tdep.c (linux_info_proc): For "info proc cmdline", print
4381         command line args instead of emitting a warning.
4382
4383 2018-03-22  Simon Marchi  <simon.marchi@polymtl.ca>
4384
4385         * tracepoint.h (struct static_tracepoint_marker): Initialize
4386         fields, define default constructor, move constructor and move
4387         assignment, disable the rest.
4388         <str_id, extra>: Make std::string.
4389         (release_static_tracepoint_marker): Remove.
4390         (free_current_marker): Remove.
4391         * tracepoint.c (free_current_marker): Remove.
4392         (parse_static_tracepoint_marker_definition): Adjust to
4393         std::string, use new hex2str overload.
4394         (release_static_tracepoint_marker): Remove.
4395         (print_one_static_tracepoint_marker): Get marker by reference
4396         and adjust to std::string.
4397         (info_static_tracepoint_markers_command): Adjust to std::vector
4398         changes
4399         * target.h (static_tracepoint_marker_p): Remove typedef.
4400         (DEF_VEC_P(static_tracepoint_marker_p)): Remove.
4401         (struct target_ops) <to_static_tracepoint_marker_at>: Return
4402         bool.
4403         <to_static_tracepoint_markers_by_strid>: Return std::vector.
4404         * target-debug.h
4405         (target_debug_print_VEC_static_tracepoint_marker_p_p): Remove.
4406         (target_debug_print_std_vector_static_tracepoint_marker): New.
4407         (target_debug_print_struct_static_tracepoint_marker_p): Rename
4408         to...
4409         (target_debug_print_static_tracepoint_marker_p): ... this.
4410         * target-delegates.c: Re-generate.
4411         * breakpoint.h (struct tracepoint) <static_trace_marker_id>:
4412         Make std::string.
4413         * breakpoint.c (init_breakpoint_sal): Adjust to std::string.
4414         (decode_static_tracepoint_spec): Adjust to std::vector.
4415         (tracepoint_print_one_detail): Adjust to std::string.
4416         (strace_marker_decode_location): Adjust to std::string.
4417         (update_static_tracepoint): Adjust to std::string, remove call
4418         to release_static_tracepoint_marker.
4419         * linux-nat.c (linux_child_static_tracepoint_markers_by_strid):
4420         Adjust to std::vector.
4421         * remote.c (remote_static_tracepoint_marker_at): Return bool.
4422         (remote_static_tracepoint_markers_by_strid): Adjust to
4423         std::vector.
4424         * common/rsp-low.h (hex2str): New overload with explicit count
4425         of bytes.
4426         * common/rsp-low.c (hex2str): New overload with explicit count
4427         of bytes.
4428         * unittests/rsp-low-selftests.c (test_hex2str): New function.
4429         (_initialize_rsp_low_selftests): Add test_hex2str test.
4430         * unittests/tracepoint-selftests.c
4431         (test_parse_static_tracepoint_marker_definition): Adjust to
4432         std::string.
4433
4434 2018-03-22  Simon Marchi  <simon.marchi@polymtl.ca>
4435
4436         * tracepoint.c (parse_static_tracepoint_marker_definition):
4437         Consider case where the definition is followed by more
4438         definitions.
4439         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4440         tracepoint-selftests.c.
4441         * unittests/tracepoint-selftests.c: New.
4442
4443 2018-03-21  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
4444
4445         * MAINTAINERS (Write After Approval): Add Pedro Franco de
4446         Carvalho.
4447
4448 2018-03-20  Stephen Roberts  <stephen.roberts@arm.com>
4449
4450         * symtab.c (find_pc_sect_line): fixed indentation.
4451
4452 2018-03-20  Stephen Roberts  <stephen.roberts@arm.com>
4453
4454         * symtab.c (find_pc_sect_line): now uses binary search.
4455
4456 2018-03-19  Tom Tromey  <tom@tromey.com>
4457
4458         * rust-exp.y (struct_expr_tail, struct_expr_list): Add plain
4459         "IDENT" production.
4460
4461 2018-03-19  Pedro Alves  <palves@redhat.com>
4462             Tom Tromey  <tom@tromey.com>
4463
4464         * unittests/observable-selftests.c: New file.
4465         * common/observable.h: New file.
4466         * observable.h: New file.
4467         * ada-lang.c, ada-tasks.c, agent.c, aix-thread.c, annotate.c,
4468         arm-tdep.c, auto-load.c, auxv.c, break-catch-syscall.c,
4469         breakpoint.c, bsd-uthread.c, cli/cli-interp.c, cli/cli-setshow.c,
4470         corefile.c, dummy-frame.c, event-loop.c, event-top.c, exec.c,
4471         extension.c, frame.c, gdbarch.c, guile/scm-breakpoint.c,
4472         infcall.c, infcmd.c, inferior.c, inflow.c, infrun.c, jit.c,
4473         linux-tdep.c, linux-thread-db.c, m68klinux-tdep.c,
4474         mi/mi-cmd-break.c, mi/mi-interp.c, mi/mi-main.c, objfiles.c,
4475         ppc-linux-nat.c, ppc-linux-tdep.c, printcmd.c, procfs.c,
4476         python/py-breakpoint.c, python/py-finishbreakpoint.c,
4477         python/py-inferior.c, python/py-unwind.c, ravenscar-thread.c,
4478         record-btrace.c, record-full.c, record.c, regcache.c, remote.c,
4479         riscv-tdep.c, sol-thread.c, solib-aix.c, solib-spu.c, solib.c,
4480         spu-multiarch.c, spu-tdep.c, stack.c, symfile-mem.c, symfile.c,
4481         symtab.c, thread.c, top.c, tracepoint.c, tui/tui-hooks.c,
4482         tui/tui-interp.c, valops.c: Update all users.
4483         * tui/tui-hooks.c (tui_bp_created_observer)
4484         (tui_bp_deleted_observer, tui_bp_modified_observer)
4485         (tui_inferior_exit_observer, tui_before_prompt_observer)
4486         (tui_normal_stop_observer, tui_register_changed_observer):
4487         Remove.
4488         (tui_observers_token): New global.
4489         (attach_or_detach, tui_attach_detach_observers): New functions.
4490         (tui_install_hooks, tui_remove_hooks): Use
4491         tui_attach_detach_observers.
4492         * record-btrace.c (record_btrace_thread_observer): Remove.
4493         (record_btrace_thread_observer_token): New global.
4494         * observer.sh: Remove.
4495         * observer.c: Rename to observable.c.
4496         * observable.c (namespace gdb_observers): Define new objects.
4497         (observer_debug): Move into gdb_observers namespace.
4498         (struct observer, struct observer_list, xalloc_observer_list_node)
4499         (xfree_observer_list_node, generic_observer_attach)
4500         (generic_observer_detach, generic_observer_notify): Remove.
4501         (_initialize_observer): Update.
4502         Don't include observer.inc.
4503         * Makefile.in (generated_files): Remove observer.h, observer.inc.
4504         (clean mostlyclean): Likewise.
4505         (observer.h, observer.inc): Remove targets.
4506         (SUBDIR_UNITTESTS_SRCS): Add observable-selftests.c.
4507         (COMMON_SFILES): Use observable.c, not observer.c.
4508         * .gitignore: Remove observer.h.
4509
4510 2018-03-18  Tom Tromey  <tom@tromey.com>
4511
4512         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Use
4513         gdb::def_vector.
4514         (bfd_lookup_symbol_from_dyn_symtab): Likewise.
4515
4516 2018-03-17  Tom Tromey  <tom@tromey.com>
4517
4518         * auto-load.c (auto_load_objfile_script_1): Use std::string.
4519
4520 2018-03-17  Tom Tromey  <tom@tromey.com>
4521
4522         * target.c (class scoped_target_fd): New.
4523         (target_fileio_close_cleanup): Remove.
4524         (target_fileio_read_alloc_1): Use scoped_target_fd.
4525
4526 2018-03-16  Simon Marchi  <simon.marchi@polymtl.ca>
4527
4528         * silent-rules.mk: New.
4529         * Makefile.in: Include silent-rules.mk
4530         (srcdir, VPATH, top_srcdir): Move up.
4531         (COMPILE): Add ECHO_CXX.
4532         (test-cp-name-parser$(EXEEXT)): Add ECHO_CXXLD.
4533         (init.c): Add ECHO_INIT_C.
4534         (gdb$(EXEEXT)): Add SILENCE and ECHO_CXXLD.
4535         (version.c): Add ECHO_GEN.
4536         (printcmd.o): Add ECHO_CXX.
4537         (target-float.o): Add ECHO_CXX.
4538         (ada-exp.o): Add ECHO_CXX.
4539         (stamp-xml): Add SILENCE and ECHO_GEN_XML_BUILTIN.
4540         (insight$(EXEEXT)): Add ECHO_CXXLD.
4541         * gnulib/configure.ac: Add AM_SILENT_RULES.
4542         * gnulib/aclocal.m4: Re-generate.
4543         * gnulib/configure: Re-generate.
4544         * gnulib/import/Makefile.in: Re-generate.
4545
4546 2018-03-16  Tom Tromey  <tom@tromey.com>
4547
4548         * xcoffread.c (xcoff_symfile_offsets): Change type of "addrs".
4549         * utils.h (make_cleanup_free_section_addr_info): Don't declare.
4550         * utils.c (do_free_section_addr_info)
4551         (make_cleanup_free_section_addr_info): Remove.
4552         * symfile.h (struct other_sections): Add constructor.
4553         (struct section_addr_info): Remove.
4554         (section_addr_info): New typedef.
4555         (struct sym_fns) <sym_offsets>: Change type of parameter.
4556         (build_section_addr_info_from_objfile)
4557         (relative_addr_info_to_section_offsets, addr_info_make_relative)
4558         (default_symfile_offsets, symbol_file_add)
4559         (symbol_file_add_from_bfd)
4560         (build_section_addr_info_from_section_table): Update.
4561         (alloc_section_addr_info, free_section_addr_info): Don't declare.
4562         * symfile.c (alloc_section_addr_info): Remove.
4563         (build_section_addr_info_from_section_table): Change return type.
4564         Update.
4565         (build_section_addr_info_from_bfd)
4566         (build_section_addr_info_from_objfile): Likewise.
4567         (free_section_addr_info): Remove.
4568         (relative_addr_info_to_section_offsets): Change type of "addrs".
4569         (addrs_section_compar): Now a std::sort comparator.
4570         (addrs_section_sort): Change return type.
4571         (addr_info_make_relative): Change type of "addrs".  Update.
4572         (default_symfile_offsets, syms_from_objfile_1)
4573         (syms_from_objfile, symbol_file_add_with_addrs): Likewise.
4574         (symbol_file_add_separate): Update.
4575         (symbol_file_add): Change type of "addrs".  Update.
4576         (add_symbol_file_command): Update.  Remove cleanups.
4577         * symfile-mem.c (symbol_file_add_from_memory): Update.  Remove
4578         cleanups.
4579         * symfile-debug.c (debug_sym_offsets): Change type of "info".
4580         * solib.c (solib_read_symbols): Update.
4581         * objfiles.c (objfile_relocate): Update.  Remove cleanups.
4582         * machoread.c (macho_symfile_offsets): Update.
4583         * jit.c (jit_bfd_try_read_symtab): Update.
4584
4585 2018-03-15  Simon Marchi  <simon.marchi@polymtl.ca>
4586
4587         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4588         unittests/utils-selftests.c.
4589         * unittests/utils-selftests.c: New file.
4590
4591 2018-03-14  Tom Tromey  <tom@tromey.com>
4592
4593         PR cli/14977:
4594         * printcmd.c (printf_c_string, printf_wide_c_string): Special case
4595         for NULL.
4596
4597 2018-03-14  Tom Tromey  <tom@tromey.com>
4598
4599         PR cli/19918:
4600         * printcmd.c (printf_pointer): Allow "-" in format.
4601
4602 2018-03-14  Tom Tromey  <tom@tromey.com>
4603
4604         * printcmd.c (_initialize_printcmd): Add usage to printf.
4605
4606 2018-03-14  Yao Qi  <qiyao@sourceware.org>
4607
4608         * MAINTAINERS: Update my email address.
4609
4610 2018-03-13  Tom Tromey  <tom@tromey.com>
4611
4612         * machoread.c (macho_check_dsym): Change filenamep to a
4613         std::string*.
4614         (macho_symfile_read): Update.
4615         * symfile.c (load_command): Use std::string.
4616
4617 2018-03-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4618
4619         * riscv-tdep.c (riscv_sw_breakpoint_from_kind): Add localization
4620         to error message string.
4621         (riscv_register_name): Use xsnprintf instead of sprintf.
4622         (riscv_insn::fetch_instruction): Use gdb_assert instead of
4623         internal_error.
4624         (riscv_print_arg_location): Use gdb_assert_not_reached instead of
4625         error.
4626         (riscv_push_dummy_call): Likewise.
4627
4628 2018-03-12  Tom Tromey  <tom@tromey.com>
4629
4630         * rs6000-aix-tdep.c (rs6000_aix_core_xfer_shared_libraries_aix):
4631         Use gdb::byte_vector.
4632         * arm-tdep.c (arm_exidx_new_objfile): Use gdb::byte_vector.
4633
4634 2018-03-12  Yao Qi  <yao.qi@linaro.org>
4635
4636         * ia64-libunwind-tdep.c (libunwind_get_reg_special): Change
4637         parameter type to readable_regcache.
4638         * ia64-libunwind-tdep.h (libunwind_get_reg_special): Update
4639         the declaration.
4640
4641 2018-03-11  Tom Tromey  <tom@tromey.com>
4642
4643         * dwarf2read.c (struct nextfield): Add initializers.
4644         (struct nextfnfield): Remove.
4645         (struct fnfieldlist): Add initializers.  Remove "length" and
4646         "head", use std::vector.
4647         (struct decl_field_list): Remove.
4648         (struct field_info): Add initializers.
4649         <fields, baseclasses>: Now std::vector.
4650         <nbaseclasses, nfnfields, typedef_field_list_count,
4651         nested_types_list_count>: Remove.
4652         (dwarf2_add_field, dwarf2_add_type_defn)
4653         (dwarf2_attach_fields_to_type, dwarf2_add_member_fn)
4654         (dwarf2_attach_fn_fields_to_type, handle_struct_member_die)
4655         (process_structure_scope): Update.
4656
4657 2018-03-11  Tom Tromey  <tom@tromey.com>
4658
4659         * dwarf2read.c (sort_tu_by_abbrev_offset): Change to be suitable
4660         for use by std::sort.
4661         (build_type_psymtabs_1): Use std::vector.
4662
4663 2018-03-09  Eli Zaretskii  <eliz@gnu.org>
4664
4665         * top.c (print_gdb_configuration): Reflect LIBIPT, LIBMEMCHECK,
4666         and LIBMPFR in the printed configuration.
4667
4668 2018-03-08  Tom Tromey  <tom@tromey.com>
4669
4670         * source.c (get_filename_and_charpos): Use scoped_fd.
4671         * nto-procfs.c (procfs_open_1): Use scoped_fd.
4672         (procfs_pidlist): Likewise.
4673         * procfs.c (proc_get_LDT_entry): Use scoped_fd.
4674         (iterate_over_mappings): Likewise.
4675
4676 2018-03-08  Tom Tromey  <tom@tromey.com>
4677
4678         * infcall.c (struct call_return_meta_info)
4679         <stack_temporaries_enabled>: Remove.
4680         (get_call_return_value, call_function_by_hand_dummy): Update.
4681         * thread.c (disable_thread_stack_temporaries): Remove.
4682         (enable_thread_stack_temporaries): Remove.
4683         (thread_stack_temporaries_enabled_p): Return bool.
4684         (push_thread_stack_temporary, value_in_thread_stack_temporaries)
4685         (get_last_thread_stack_temporary): Update.
4686         * eval.c (evaluate_subexp): Update.
4687         * gdbthread.h (class enable_thread_stack_temporaries): Now a
4688         class, not a function.
4689         (value_ptr, value_vec): Remove typedefs.
4690         (class thread_info) <stack_temporaries_enabled>: Now bool.
4691         <stack_temporaries>: Now a std::vector.
4692         (thread_stack_temporaries_enabled_p)
4693         (value_in_thread_stack_temporaries): Return bool.
4694
4695 2018-03-08  Simon Marchi  <simon.marchi@ericsson.com>
4696
4697         * remote.c (putpkt_binary): Fix omitted bytes reporting.
4698         (getpkt_or_notif_sane_1): Likewise.
4699
4700 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
4701
4702         * build-id.c (build_id_to_debug_bfd): Use std::string.
4703
4704 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
4705
4706         * build-id.c (find_separate_debug_file_by_buildid): Return
4707         std::string.
4708         * build-id.h (find_separate_debug_file_by_buildid): Return
4709         std::string.
4710         * coffread.c (coff_symfile_read): Adjust to std::string.
4711         * elfread.c (elf_symfile_read): Adjust to std::string.
4712         * symfile.c (separate_debug_file_exists): Change parameter to
4713         std::string.
4714         (find_separate_debug_file): Return std::string.
4715         (find_separate_debug_file_by_debuglink): Return std::string.
4716         * symfile.h (find_separate_debug_file_by_debuglink): Return
4717         std::string.
4718
4719 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
4720
4721         * common/xml-utils.c (xml_escape_text): Move code to...
4722         (xml_escape_text_append): ... this new function.
4723         * common/xml-utils.h (xml_escape_text_append): New declaration.
4724         * unittests/xml-utils-selftests.c (test_xml_escape_text_append):
4725         New function.
4726         (_initialize_xml_utils): register test_xml_escape_text_append as
4727         a selftest.
4728
4729 2018-03-07  Alan Hayward  <alan.hayward@arm.com>
4730
4731         * defs.h: Remove MAX_REGISTER_SIZE.
4732         * regcache.c (init_regcache_descr): Remove MAX_REGISTER_SIZE
4733         asserts.
4734         * python/py-unwind.c (pyuw_sniffer): Likewise.
4735
4736 2018-03-07  Tom Tromey  <tom@tromey.com>
4737
4738         * linux-tdep.c (linux_info_proc): Update.
4739         * target.h (struct target_ops) <to_fileio_readlink>: Return
4740         optional<string>.
4741         (target_fileio_readlink): Return optional<string>.
4742         * remote.c (remote_hostio_readlink): Return optional<string>.
4743         * inf-child.c (inf_child_fileio_readlink): Return
4744         optional<string>.
4745         * target.c (target_fileio_readlink): Return optional<string>.
4746
4747 2018-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
4748
4749         * regcache.c (cooked_read_test): Add riscv to the list of
4750         architectures that have a save_reggroup.
4751
4752 2018-03-07  Andreas Arnez  <arnez@linux.vnet.ibm.com>
4753
4754         * gnu-v3-abi.c (gnuv3_rtti_type): Add early exit if the given
4755         value is not a dynamic class object.
4756
4757 2018-03-06  Tom Tromey  <tom@tromey.com>
4758
4759         * rust-exp.y: Formatting fixes.
4760
4761 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4762
4763         * riscv-tdep.c (riscv_register_name): Remove target description
4764         support.
4765         (riscv_gdbarch_init): Remove target description check.
4766
4767 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4768
4769         * riscv-tdep.c: Remove 'Contributed by ...' lines from header
4770         comment.
4771         * riscv-tdep.h: Likewise.
4772
4773 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4774
4775         * riscv-tdep.c (riscv_pseudo_register_read): Delete.
4776         (riscv_pseudo_register_write): Delete.
4777         (riscv_gdbarch_init): Remove all use of pseudo registers.
4778
4779 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
4780
4781         * record-btrace.c (btrace_print_lines): Replace cleanup
4782         parameter with RAII equivalents.
4783         (btrace_insn_history): Replace cleanup with RAII equivalents.
4784         * ui-out.h (make_cleanup_ui_out_list_begin_end,
4785         make_cleanup_ui_out_tuple_begin_end): Remove.
4786         * ui-out.c (struct ui_out_end_cleanup_data, do_cleanup_end,
4787         make_cleanup_ui_out_end, make_cleanup_ui_out_tuple_begin_end,
4788         make_cleanup_ui_out_list_begin_end): Remove.
4789
4790 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
4791
4792         * record-btrace.c (record_btrace_maybe_mark_async_event): Change
4793         parameter types to std::vector.  Use bool.
4794         (record_btrace_wait): Replace VEC(tp_t) with
4795         std::vector<thread_info *>.
4796         * common/gdb_vecs.h (unordered_remove, ordered_remove): New.
4797
4798 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
4799
4800         * record-btrace.c (record_btrace_disable_callback): Remove.
4801         (struct scoped_btrace_disable): New.
4802         (record_btrace_open): Use scoped_btrace_disable.
4803
4804 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4805
4806         * riscv-tdep.c (riscv_return_value): Change type to ULONGEST for
4807         reading values from registers.
4808
4809 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4810
4811         * riscv-tdep.c (riscv_push_dummy_call): Use core_addr_to_string_nz
4812         where appropriate.
4813
4814 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4815
4816         * riscv-tdep.c (riscv_print_arg_location): Add header comment,
4817         change parameter type.  Use GDB's print functions, and use
4818         core_addr_to_string where appropriate.
4819         (riscv_push_dummy_call): Use core_addr_to_string where
4820         appropriate, update call to riscv_print_arg_location, and reindent
4821         a few lines.
4822         (riscv_return_value): Update call to riscv_print_arg_location.
4823
4824 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4825             Tim Newsome <tim@sifive.com>
4826             Albert Ou <a0u@eecs.berkeley.edu>
4827             Darius Rad <darius@bluespec.com>
4828
4829         * Makefile.in (ALL_TARGET_OBS): Add riscv-tdep.o
4830         (HFILES_NO_SRCDIR): Add riscv-tdep.h.
4831         (ALLDEPFILES): Add riscv-tdep.c
4832         * configure.tgt: Add riscv support.
4833         * riscv-tdep.c: New file.
4834         * riscv-tdep.h: New file.
4835         * NEWS: Mention new target.
4836         * MAINTAINERS: Add entry for riscv.
4837
4838 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4839
4840         * amd64-tdep.c (amd64_classify_aggregate): Ignore zero sized
4841         fields within aggregates.
4842
4843 2018-03-04  Simon Marchi  <simon.marchi@polymtl.ca>
4844
4845         * record-btrace.c (btrace_print_lines): Change type of flags to
4846         gdb_disassembly_flags.
4847
4848 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
4849
4850         * fbsd-nat.c: Include "inf-ptrace.h".
4851         (USE_SIGTRAP_SIGINFO): Conditionally define.
4852         [USE_SIGTRAP_SIGINFO] (fbsd_handle_debug_trap): New function.
4853         (fbsd_wait) [USE_SIGTRAP_SIGINFO]: Call "fbsd_handle_debug_trap".
4854         [USE_SIGTRAP_SIGINFO] (fbsd_stopped_by_sw_breakpoint): New
4855         function.
4856         [USE_SIGTRAP_SIGINFO] (fbsd_supports_stopped_by_sw_breakpoint):
4857         Likewise.
4858         [USE_SIGTRAP_SIGINFO] (fbsd_supports_stopped_by_hw_breakpoint):
4859         Likewise.
4860         (fbsd_nat_add_target) [USE_SIGTRAP_SIGINFO]: Set
4861         "stopped_by_sw_breakpoint", "supports_stopped_by_sw_breakpoint",
4862         "supports_stopped_by_hw_breakpoint" target methods.
4863
4864 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
4865
4866         * NEWS (Changes since GDB 8.1): Add "set/show debug fbsd-nat".
4867         * fbsd-nat.c (debug_fbsd_nat): New variable.
4868         (show_fbsd_nat_debug): New function.
4869         (fbsd_wait): Log LWP info if "debug_fbsd_nat" is enabled.
4870         (_initialize_fbsd_nat): Add "fbsd-nat" debug boolean command.
4871
4872 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
4873
4874         * nat/x86-dregs.c (x86_dr_stopped_by_hw_breakpoint): New function.
4875         * nat/x86-dregs.h (x86_dr_stopped_by_hw_breakpoint): New
4876         prototype.
4877         * x86-nat.c (x86_stopped_by_hw_breakpoint): New function.
4878         (x86_use_watchpoints): Set "stopped_by_hw_breakpoint" target
4879         method.
4880
4881 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
4882
4883         * common/gdb_vecs.c (free_char_ptr_vec): Remove.
4884         * common/gdb_vecs.h (free_char_ptr_vec): Remove.
4885
4886 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
4887
4888         * charset.c (struct charset_vector): New.
4889         (charsets): Change type to charset_vector.
4890         (find_charset_names): Adjust.
4891         (add_one): Adjust.
4892         (_initialize_charset): Adjust.
4893
4894 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
4895
4896         * progspace.h (struct program_space) <deleted_solibs>: Change
4897         type to std::vector<std::string>.
4898         * progspace.c (clear_program_space_solib_cache): Adjust.
4899         * breakpoint.c (print_solib_event): Adjust.
4900         (check_status_catch_solib): Adjust.
4901         * solib.c (update_solib_list): Adjust.
4902         * ui-out.h (class ui_out) <field_string>: New overload.
4903         * ui-out.c (ui_out::field_string): New overload.
4904
4905 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
4906
4907         * progspace.h (struct program_space): Add constructor and
4908         destructor, initialize fields.
4909         (add_program_space): Remove.
4910         * progspace.c (add_program_space): Rename to...
4911         (program_space::program_space): ... this.
4912         (release_program_space): Rename to...
4913         (program_space::~program_space): ... this.
4914         (delete_program_space): Use delete to delete program_space.
4915         (initialize_progspace): Use new to allocate program_space.
4916         * inferior.c (add_inferior_with_spaces): Likewise.
4917         (clone_inferior_command): Likewise.
4918         * infrun.c (follow_fork_inferior): Likewise.
4919         (handle_vfork_child_exec_or_exit): Likewise.
4920
4921 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
4922
4923         * common/gdb_vecs.h (make_cleanup_free_char_ptr_vec): Remove.
4924         (delim_string_to_char_ptr_vec): Return std::vector of
4925         gdb::unique_xmalloc_ptr.
4926         (dirnames_to_char_ptr_vec_append): Take std::vector of
4927         gdb::unique_xmalloc_ptr.
4928         (dirnames_to_char_ptr_vec): Return std::vector of
4929         gdb::unique_xmalloc_ptr.
4930         * common/gdb_vecs.c (delim_string_to_char_ptr_vec_append):
4931         Take std::vector of gdb::unique_xmalloc_ptr, adjust the code.
4932         (delim_string_to_char_ptr_vec): Return an std::vector of
4933         gdb::unique_xmalloc_ptr, adjust the code.
4934         (dirnames_to_char_ptr_vec_append): Take an std::vector of
4935         gdb::unique_xmalloc_ptr, adjust the code.
4936         (dirnames_to_char_ptr_vec): Return an std::vector of
4937         gdb::unique_xmalloc_ptr, adjust the code.
4938         * auto-load.c (auto_load_safe_path_vec): Change type to
4939         std::vector of gdb::unique_xmalloc_ptr.
4940         (auto_load_expand_dir_vars): Return an std::vector of
4941         gdb::unique_xmalloc_ptr, adjust the code.
4942         (auto_load_safe_path_vec_update): Adjust.
4943         (filename_is_in_auto_load_safe_path_vec): Adjust.
4944         (auto_load_objfile_script_1): Adjust.
4945         * build-id.c (build_id_to_debug_bfd): Adjust.
4946         * linux-thread-db.c (thread_db_load_search): Adjust.
4947         * source.c (add_path): Adjust.
4948         (openp): Adjust.
4949         * symfile.c (find_separate_debug_file): Adjust.
4950         * utils.c (do_free_char_ptr_vec): Remove.
4951         (make_cleanup_free_char_ptr_vec): Remove.
4952
4953 2018-03-01  Sergio Durigan Junior  <sergiodj@redhat.com>
4954
4955         PR gdb/22907
4956         * common/pathstuff.c: Conditionally include "<windows.h>".
4957
4958 2018-03-01  Georg Sauthoff  <mail@georg.so>
4959
4960         PR gdb/22888
4961         * gcore.in: Quote variables and switch interpreter to bash.
4962
4963 2018-03-01  Tom Tromey  <tom@tromey.com>
4964
4965         * dwarf2read.c (alloc_discriminant_info): Fix default_index
4966         assertion.  Add assertion for discriminant_index.
4967         (quirk_rust_enum): Use correct base type name in univariant case.
4968
4969 2018-03-01  Simon Marchi  <simon.marchi@ericsson.com>
4970
4971         * record.c (get_call_history_modifiers): Return a
4972         record_print_flags.
4973         (cmd_record_call_history): Adjust.
4974         * record-btrace.c (record_btrace_call_history): Adjust.
4975         (record_btrace_call_history_range): Adjust.
4976         (record_btrace_call_history_from): Adjust.
4977         * target-debug.h (target_debug_print_record_print_flags): New.
4978         * target-delegates.c: Re-generate.
4979         * target.c (target_call_history): Change flags type.
4980         (target_call_history_from): Likewise.
4981         (target_call_history_range): Likewise.
4982         * target.h (struct target_ops) <target_call_history>: Likewise.
4983         (target_call_history_from): Likewise.
4984         (target_call_history_range): Likewise.
4985
4986 2018-02-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4987             Simon Marchi  <simon.marchi@polymtl.ca>
4988
4989         * common/common-utils.c: Include "sys/stat.h".
4990         (is_regular_file): Move here from "source.c"; change return
4991         type to "bool".
4992         * common/common-utils.h (is_regular_file): New prototype.
4993         * common/pathstuff.c (contains_dir_separator): New function.
4994         * common/pathstuff.h (contains_dir_separator): New prototype.
4995         * source.c: Don't include "sys/stat.h".
4996         (is_regular_file): Move to "common/common-utils.c".
4997
4998 2018-02-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4999
5000         * Makefile.in (COMMON_SFILES): Add "common/pathstuff.c".
5001         (HFILES_NO_SRCDIR): Add "common/pathstuff.h".
5002         * auto-load.c: Include "common/pathstuff.h".
5003         * common/common-def.h (current_directory): Move here.
5004         * common/gdb_tilde_expand.c (gdb_tilde_expand_up): New
5005         function.
5006         * common/gdb_tilde_expand.h (gdb_tilde_expand_up): New
5007         prototype.
5008         * common/pathstuff.c: New file.
5009         * common/pathstuff.h: New file.
5010         * compile/compile.c: Include "common/pathstuff.h".
5011         * defs.h (current_directory): Move to "common/common-defs.h".
5012         * dwarf2read.c: Include "common/pathstuff.h".
5013         * exec.c: Likewise.
5014         * guile/scm-safe-call.c: Likewise.
5015         * linux-thread-db.c: Likewise.
5016         * main.c: Likewise.
5017         * nto-tdep.c: Likewise.
5018         * objfiles.c: Likewise.
5019         * source.c: Likewise.
5020         * symtab.c: Likewise.
5021         * utils.c: Include "common/pathstuff.h".
5022         (gdb_realpath): Move to "common/pathstuff.c".
5023         (gdb_realpath_keepfile): Likewise.
5024         (gdb_abspath): Likewise.
5025         * utils.h (gdb_realpath): Move to "common/pathstuff.h".
5026         (gdb_realpath_keepfile): Likewise.
5027         (gdb_abspath): Likewise.
5028
5029 2018-02-28  John Baldwin  <jhb@FreeBSD.org>
5030
5031         * fbsd-nat.c (fbsd_resume): Use PT_SETSTEP for stepping and a
5032         wildcard process pid for super_resume for kernels with a
5033         specific bug.
5034
5035 2018-02-27  Phil Muldoon  <pmuldoon@redhat.com>
5036
5037         * compile/compile.c (get_args): Add additional comments
5038         explaining function.
5039
5040 2018-02-27  Simon Marchi  <simon.marchi@polymtl.ca>
5041             Tom Tromey  <tom@tromey.com>
5042
5043         * target.h (memory_write_request_s): Remove typedef.  Don't define
5044         VEC.
5045         (target_write_memory_blocks): Change argument to std::vector.
5046         (struct memory_write_request): Add constructor.
5047         * target-memory.c (compare_block_starting_address): Return bool.
5048         Change argument types.
5049         (claim_memory): Change arguments to use std::vector.
5050         (split_regular_and_flash_blocks, blocks_to_erase)
5051         (compute_garbled_blocks): Likewise.
5052         (cleanup_request_data, cleanup_write_requests_vector): Remove.
5053         (target_write_memory_blocks): Change argument to std::vector.
5054         * symfile.c (struct load_section_data): Add constructor and
5055         destructor.  Use std::vector for "requests".
5056         (struct load_progress_data): Add initializers.
5057         (load_section_callback): Update.  Use "new".
5058         (clear_memory_write_data): Remove.
5059         (generic_load): Update.
5060
5061 2018-02-27  Alan Hayward  <alan.hayward@arm.com>
5062
5063         * arch/aarch64.h: Use common/tdesc.h.
5064
5065 2018-02-26  Maciej W. Rozycki  <macro@mips.com>
5066
5067         * mips-tdep.c (mips_gdbarch_init): Don't use a 32-bit BFD
5068         architecture with a 64-bit ABI.
5069
5070 2018-02-26  Maciej W. Rozycki  <macro@mips.com>
5071
5072         * gdb/mips-tdep.c (mips_gdbarch_init): Reorder ABI determination
5073         ahead of target description loading.
5074
5075 2018-02-26  Tom Tromey  <tom@tromey.com>
5076
5077         * stack.c (backtrace_command_1): Update.
5078         * python/python-internal.h (gdbpy_apply_frame_filter): Change type
5079         of "flags".
5080         * python/py-framefilter.c (py_print_frame)
5081         (gdbpy_apply_frame_filter): Change type of "flags".
5082         * mi/mi-cmd-stack.c (mi_apply_ext_lang_frame_filter): Change type
5083         of "flags".
5084         (mi_cmd_stack_list_frames, mi_cmd_stack_list_locals)
5085         (mi_cmd_stack_list_args, mi_cmd_stack_list_variables): Update.
5086         * extension.h (enum frame_filter_flag): Rename from
5087         frame_filter_flags.
5088         (frame_filter_flags): Define using DEF_ENUM_FLAGS_TYPE.
5089         (apply_ext_lang_frame_filter): Change type of "flags".
5090         * extension.c (apply_ext_lang_frame_filter): Change type of
5091         "flags".
5092         * extension-priv.h (struct extension_language_ops)
5093         <apply_frame_filter>: Change type of "flags".
5094
5095 2018-02-26  Tom Tromey  <tom@tromey.com>
5096
5097         PR python/16497:
5098         * stack.c (backtrace_command_1): Set PRINT_MORE_FRAMES flag.  Fix
5099         off-by-one in py_end computation.
5100         * python/py-framefilter.c (gdbpy_apply_frame_filter): Handle
5101         PRINT_MORE_FRAMES.
5102         * extension.h (enum frame_filter_flags) <PRINT_MORE_FRAMES>: New
5103         constant.
5104
5105 2018-02-26  Tom Tromey  <tom@tromey.com>
5106
5107         * dwarf2read.c (struct variant_field): New.
5108         (struct nextfield) <variant>: New field.
5109         (dwarf2_add_field): Handle DW_TAG_variant_part.
5110         (dwarf2_attach_fields_to_type): Attach a discriminant_info to a
5111         discriminated union.
5112         (read_structure_type): Handle DW_TAG_variant_part.
5113         (handle_struct_member_die): New function, extracted from
5114         process_structure_scope.  Handle DW_TAG_variant.
5115         (process_structure_scope): Handle discriminated unions.  Call
5116         handle_struct_member_die.
5117
5118 2018-02-26  Tom Tromey  <tom@tromey.com>
5119
5120         * rust-lang.h (rust_last_path_segment): Declare.
5121         * rust-lang.c (rust_last_path_segment): Now public.  Change
5122         contract.
5123         (struct disr_info): Remove.
5124         (RUST_ENUM_PREFIX, RUST_ENCODED_ENUM_REAL)
5125         (RUST_ENCODED_ENUM_HIDDEN, rust_union_is_untagged)
5126         (rust_get_disr_info, rust_tuple_variant_type_p): Remove.
5127         (rust_enum_p, rust_enum_variant): New function.
5128         (rust_underscore_fields): Remove "offset" parameter.
5129         (rust_print_enum): New function.
5130         (rust_val_print) <TYPE_CODE_UNION>: Remove enum code.
5131         <TYPE_CODE_STRUCT>: Call rust_print_enum when appropriate.
5132         (rust_print_struct_def): Add "for_rust_enum" parameter.  Handle
5133         enums.
5134         (rust_internal_print_type): New function, from rust_print_type.
5135         Remove enum code.
5136         (rust_print_type): Call rust_internal_print_type.
5137         (rust_evaluate_subexp) <STRUCTOP_ANONYMOUS, STRUCTOP_STRUCT>:
5138         Update enum handling.
5139         * dwarf2read.c (struct dwarf2_cu) <rust_unions>: New field.
5140         (rust_fully_qualify, alloc_discriminant_info, quirk_rust_enum)
5141         (rust_union_quirks): New functions.
5142         (process_full_comp_unit, process_full_type_unit): Call
5143         rust_union_quirks.
5144         (process_structure_scope): Update rust_unions if necessary.
5145
5146 2018-02-26  Tom Tromey  <tom@tromey.com>
5147
5148         * value.h (value_union_variant): Declare.
5149         * valops.c (value_union_variant): New function.
5150         * gdbtypes.h (TYPE_FLAG_DISCRIMINATED_UNION): New macro.
5151         (struct discriminant_info): New.
5152         (enum dynamic_prop_node_kind) <DYN_PROP_DISCRIMINATED>: New
5153         enumerator.
5154         (struct main_type) <flag_discriminated_union>: New field.
5155
5156 2018-02-26  Tom Tromey  <tom@tromey.com>
5157
5158         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5159         unittests/unpack-selftests.c.
5160         * unittests/unpack-selftests.c: New file.
5161         * value.c (unpack_bits_as_long): Fix bugs in non-bitfield cases.
5162
5163 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5164
5165         * dwarf2read.c (struct partial_die_info) <read>: New method.
5166         (read_partial_die): Remove the declaration.
5167         (load_partial_dies): Update.
5168         (partial_die_info::partial_die_info):
5169         (read_partial_die): Change it to partial_die_info::read.
5170
5171 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5172
5173         * dwarf2read.c (struct partial_die_info) <fixup>: New method.
5174         (fixup_partial_die): Remove declaration.
5175         (scan_partial_symbols): Update.
5176         (partial_die_parent_scope): Likewise.
5177         (partial_die_full_name): Likewise.
5178         (fixup_partial_die): Change it to partial_die_info::fixup.
5179
5180 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5181
5182         * dwarf2read.c (read_partial_die): Update the declaration.
5183         (load_partial_dies): Caller update.
5184         (read_partial_die): Remove one argument abbrev_len.
5185
5186 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5187
5188         * dwarf2read.c (struct partial_die_info): Add ctor, delete
5189         assignment operator.
5190         (load_partial_dies): Use ctor and copy ctor.
5191         (read_partial_die): Update.
5192         (dwarf2_cu::find_partial_die): Use ctor.
5193
5194 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5195
5196         * dwarf2read.c (struct dwarf2_cu) <find_partial_die>: New method.
5197         (find_partial_die_in_comp_unit): Change it to
5198         dwarf2_cu::find_partial_die.
5199         (find_partial_die): Update.
5200
5201 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5202
5203         * dwarf2read.c (read_partial_die): Remove the code checking abbrev
5204         is NULL.
5205
5206 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5207
5208         * dwarf2read.c (load_partial_dies): Move the location of XOBNEW.
5209
5210 2018-02-26  Alan Hayward  <alan.hayward@arm.com>
5211
5212         * arch/amd64.h: Use common/tdesc.h.
5213         * arch/i386.c: Likewise.
5214         * arch/i386.h: Likewise.
5215         * arch/tic6x.c: Likewise.
5216         * arch/tdesc.h: Move file from here...
5217         * common/tdesc.h: ...to here.
5218         * features/aarch64-core.c: Regenerate.
5219         * features/aarch64-fpu.c: Regenerate.
5220         * features/i386/32bit-avx.c: Regenerate.
5221         * features/i386/32bit-avx512.c: Regenerate.
5222         * features/i386/32bit-core.c: Regenerate.
5223         * features/i386/32bit-linux.c: Regenerate.
5224         * features/i386/32bit-mpx.c: Regenerate.
5225         * features/i386/32bit-pkeys.c: Regenerate.
5226         * features/i386/32bit-sse.c: Regenerate.
5227         * features/i386/64bit-avx.c: Regenerate.
5228         * features/i386/64bit-avx512.c: Regenerate.
5229         * features/i386/64bit-core.c: Regenerate.
5230         * features/i386/64bit-linux.c: Regenerate.
5231         * features/i386/64bit-mpx.c: Regenerate.
5232         * features/i386/64bit-pkeys.c: Regenerate.
5233         * features/i386/64bit-segments.c: Regenerate.
5234         * features/i386/64bit-sse.c: Regenerate.
5235         * features/i386/x32-core.c: Regenerate.
5236         * features/tic6x-c6xp.c: Regenerate.
5237         * features/tic6x-core.c: Regenerate.
5238         * features/tic6x-gp.c: Regenerate.
5239         * target-descriptions.c: Use common/tdesc.h.
5240         * target-descriptions.h: Likewise.
5241
5242 2018-02-24  Tom Tromey  <tom@tromey.com>
5243
5244         * linux-thread-db.c (try_thread_db_load_from_pdir_1)
5245         (try_thread_db_load_from_dir, thread_db_load_search): Use
5246         std::string.
5247         (info_auto_load_libthread_db_compare): Return bool.  Change
5248         argument types.
5249         (info_auto_load_libthread_db): Use std::vector, std::string.
5250         Remove cleanups.
5251
5252 2018-02-24  Tom Tromey  <tom@tromey.com>
5253
5254         * i386-tdep.c (i386_fast_tracepoint_valid_at): "msg" now a
5255         std::string.
5256         * gdbarch.sh (fast_tracepoint_valid_at): Change "msg" to a
5257         std::string*.
5258         * gdbarch.c: Rebuild.
5259         * gdbarch.h: Rebuild.
5260         * breakpoint.c (check_fast_tracepoint_sals): Use std::string.
5261         * arch-utils.h (default_fast_tracepoint_valid_at): Update.
5262         * arch-utils.c (default_fast_tracepoint_valid_at): "msg" now a
5263         std::string*.
5264
5265 2018-02-23  Simon Marchi  <simon.marchi@polymtl.ca>
5266
5267         * gdbtypes.h (sect_offset): Change type to uint64_t.
5268         (sect_offset_str): New function.
5269         * dwarf2read.c (create_addrmap_from_aranges): Use
5270         sect_offset_str.
5271         (error_check_comp_unit_head): Likewise.
5272         (create_debug_type_hash_table): Likewise.
5273         (read_cutu_die_from_dwo): Likewise.
5274         (init_cutu_and_read_dies): Likewise.
5275         (init_cutu_and_read_dies_no_follow): Likewise.
5276         (process_psymtab_comp_unit_reader): Likewise.
5277         (partial_die_parent_scope): Likewise.
5278         (peek_die_abbrev): Likewise.
5279         (process_queue): Likewise.
5280         (dwarf2_physname): Likewise.
5281         (read_namespace_alias): Likewise.
5282         (read_import_statement): Likewise.
5283         (create_dwo_cu_reader): Likewise.
5284         (create_cus_hash_table): Likewise.
5285         (lookup_dwo_cutu): Likewise.
5286         (inherit_abstract_dies): Likewise.
5287         (read_func_scope): Likewise.
5288         (read_call_site_scope): Likewise.
5289         (dwarf2_add_member_fn): Likewise.
5290         (read_common_block): Likewise.
5291         (read_module_type): Likewise.
5292         (read_typedef): Likewise.
5293         (read_subrange_type): Likewise.
5294         (load_partial_dies): Likewise.
5295         (read_partial_die): Likewise.
5296         (find_partial_die): Likewise.
5297         (read_str_index): Likewise.
5298         (dwarf2_string_attr): Likewise.
5299         (build_error_marker_type): Likewise.
5300         (lookup_die_type): Likewise.
5301         (dump_die_shallow): Likewise.
5302         (follow_die_ref): Likewise.
5303         (dwarf2_fetch_die_loc_sect_off): Likewise.
5304         (dwarf2_fetch_constant_bytes): Likewise.
5305         (follow_die_sig): Likewise.
5306         (get_signatured_type): Likewise.
5307         (get_DW_AT_signature_type): Likewise.
5308         (dwarf2_find_containing_comp_unit): Likewise.
5309         (set_die_type): Likewise.
5310
5311 2018-02-21  John Baldwin  <jhb@FreeBSD.org>
5312
5313         * arch/aarch64.c: Include "common-defs.h".
5314         * arch/amd64.c: Likewise.
5315         * arch/i386.c: Likewise.
5316
5317 2018-02-21  Tom Tromey  <tom@tromey.com>
5318
5319         * value.h: (extract_field_op): Update.
5320         * eval.c (extract_field_op): Return a const char *.
5321         * expression.h (parse_expression_for_completion): Update.
5322         * completer.c (complete_expression): Update.
5323         (add_struct_fields): Make fieldname const.
5324         * parse.c (expout_completion_name): Now a unique_xmalloc_ptr.
5325         (mark_completion_tag, parse_exp_in_context_1): Update.
5326         (parse_expression_for_completion): Change "name" to
5327         unique_xmalloc_ptr*.
5328
5329 2018-02-21  Tom Tromey  <tom@tromey.com>
5330
5331         * infcall.c (call_function_by_hand_dummy): Use std::vector.
5332
5333 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5334
5335         * avr-tdep.c (avr_read_pc): Change parameter type to
5336         readable_regcache.
5337         * gdbarch.sh (read_pc): Likewise.
5338         * gdbarch.c: Re-generated.
5339         * gdbarch.h: Re-generated.
5340         * hppa-tdep.c (hppa_read_pc): Change parameter type to
5341         readable_regcache.
5342         * ia64-tdep.c (ia64_read_pc): Likewise.
5343         * mips-tdep.c (mips_read_pc): Likewise.
5344         * spu-tdep.c (spu_read_pc): Likewise.
5345
5346 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5347
5348         * Makefile.in (COMMON_SFILES): Add regcache-dump.c
5349         * regcache-dump.c: New file.
5350         * regcache.c: Move register_dump to regcache-dump.c.
5351         (maintenance_print_registers): Likewise.
5352         (maintenance_print_raw_registers): Likewise.
5353         (maintenance_print_cooked_registers): Likewise.
5354         (maintenance_print_register_groups): Likewise.
5355         (maintenance_print_remote_registers): Likewise.
5356         (_initialize_regcache): Likewise.
5357         * regcache.h (register_dump): Moved from regcache.c.
5358
5359 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5360
5361         * regcache.c (regcache::regcache): Update.
5362         (regcache::invalidate): Move it to detached_regcache::invalidate.
5363         (get_thread_arch_aspace_regcache): Update.
5364         (regcache::raw_update): Update.
5365         (regcache::cooked_read): Remove some code.
5366         (regcache::cooked_read_value): Likewise.
5367         (regcache::raw_write): Remove assert on m_readonly_p.
5368         (regcache::raw_supply_integer): Move it to
5369         detached_regcache::raw_supply_integer.
5370         (regcache::raw_supply_zeroed): Likewise.
5371         * regcache.h (detached_regcache) <raw_supply_integer>: New
5372         declaration.
5373         <raw_supply_zeroed, invalidate>: Likewise.
5374         (regcache) <raw_supply_integer, raw_supply_zeroed>: Removed.
5375         <invalidate>: Likewise.
5376         <m_readonly_p>: Removed.
5377
5378 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5379
5380         * infcmd.c (get_return_value): Let stop_regs point to
5381         get_current_regcache.
5382         * regcache.c (regcache::regcache): Remove.
5383         (register_dump_reg_buffer): New class.
5384         (regcache_print): Adjust.
5385         * regcache.h (regcache): Remove constructors.
5386
5387 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5388
5389         * regcache.c (class register_dump): New class.
5390         (register_dump_regcache, register_dump_none): New class.
5391         (register_dump_remote, register_dump_groups): New class.
5392         (regcache_print): Update.
5393         * regcache.h (regcache_dump_what): Move it to regcache.c.
5394         (regcache) <dump>: Remove.
5395
5396 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5397
5398         * jit.c (struct jit_unwind_private) <regcache>: Change its type to
5399          reg_buffer_rw *.
5400         (jit_unwind_reg_set_impl): Call raw_supply.
5401         (jit_frame_sniffer): Use reg_buffer_rw.
5402         * record-full.c (record_full_core_regbuf): Change its type.
5403         (record_full_core_open_1): Use reg_buffer_rw.
5404         (record_full_close): Likewise.
5405         (record_full_core_fetch_registers): Use regcache->raw_supply.
5406         (record_full_core_store_registers): Likewise.
5407         * regcache.c (regcache::get_register_status): Move it to
5408         reg_buffer.
5409         (regcache_raw_set_cached_value): Remove.
5410         (regcache::raw_set_cached_value): Remove.
5411         (regcache::raw_write): Call raw_supply.
5412         (regcache::raw_supply): Move it to reg_buffer_rw.
5413         * regcache.h (regcache_raw_set_cached_value): Remove.
5414         (reg_buffer_rw): New class.
5415
5416 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5417
5418         * dummy-frame.c (dummy_frame_cache) <prev_regcache>: Use
5419         readonly_detached_regcache.
5420         (dummy_frame_prev_register): Use regcache->cooked_read.
5421         * frame.c (frame_save_as_regcache): Change return type.
5422         (frame_pop): Update.
5423         * frame.h (frame_save_as_regcache): Update declaration.
5424         * inferior.h (get_infcall_suspend_state_regcache): Update
5425         declaration.
5426         * infrun.c (infcall_suspend_state) <registers>: use
5427         readonly_detached_regcache.
5428         (save_infcall_suspend_state): Don't use regcache_dup.
5429         (get_infcall_suspend_state_regcache): Change return type.
5430         * linux-fork.c (struct fork_info) <savedregs>: Change to
5431         readonly_detached_regcache.
5432         <pc>: New field.
5433         (fork_save_infrun_state): Don't use regcache_dup.
5434         (info_checkpoints_command): Adjust.
5435         * mi/mi-main.c (register_changed_p): Update declaration.
5436         (mi_cmd_data_list_changed_registers): Use
5437         readonly_detached_regcache.
5438         (register_changed_p): Change parameter type to
5439         readonly_detached_regcache.
5440         * ppc-linux-tdep.c (ppu2spu_cache) <regcache>: Use
5441         readonly_detached_regcache.
5442         (ppu2spu_sniffer): Construct a new readonly_detached_regcache.
5443         * regcache.c (readonly_detached_regcache::readonly_detached_regcache):
5444         New.
5445         (regcache::save): Move it to reg_buffer.
5446         (regcache::restore): Change parameter type.
5447         (regcache_dup): Remove.
5448         * regcache.h (reg_buffer) <save>: New method.
5449         (readonly_detached_regcache): New class.
5450         * spu-tdep.c (spu2ppu_cache) <regcache>: Use
5451         readonly_detached_regcache.
5452         (spu2ppu_sniffer): Construct a new readonly_detached_regcache.
5453
5454 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5455
5456         * frame.c (frame_save_as_regcache): Use regcache method save.
5457         (frame_pop): Use regcache method restore.
5458         * infrun.c (restore_infcall_suspend_state): Likewise.
5459         * linux-fork.c (fork_load_infrun_state): Likewise.
5460         * ppc-linux-tdep.c (ppu2spu_sniffer): User regcache method
5461         save.
5462         * regcache.c (regcache_save): Remove.
5463         (regcache::restore): More asserts.
5464         (regcache_cpy): Remove.
5465         * regcache.h (regcache_save): Remove the declaration.
5466         (regcache::restore): Move from private to public.
5467         Remove the friend declaration of regcache_cpy.
5468         (regcache_cpy): Remove declaration.
5469
5470 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5471
5472         * aarch64-tdep.c (aarch64_pseudo_register_read_value): Change
5473         parameter type to 'readable_regcache *'.
5474         * amd64-tdep.c (amd64_pseudo_register_read_value): Likewise.
5475         * arm-tdep.c (arm_neon_quad_read): Likewise.
5476         (arm_pseudo_read): Likewise.
5477         * avr-tdep.c (avr_pseudo_register_read): Likewise.
5478         * bfin-tdep.c (bfin_pseudo_register_read): Likewise.
5479         * frv-tdep.c (frv_pseudo_register_read): Likewise.
5480         * gdbarch.c: Re-generated.
5481         * gdbarch.h: Re-generated.
5482         * gdbarch.sh (pseudo_register_read): Change parameter type to
5483         'readable_regcache *'.
5484         (pseudo_register_read_value): Likewise.
5485         * h8300-tdep.c (pseudo_from_raw_register): Likewise.
5486         (h8300_pseudo_register_read): Likewise.
5487         * hppa-tdep.c (hppa_pseudo_register_read): Likewise.
5488         * i386-tdep.c (i386_mmx_regnum_to_fp_regnum): Likewise.
5489         (i386_pseudo_register_read_into_value): Likewise.
5490         (i386_pseudo_register_read_value): Likewise.
5491         * i386-tdep.h (i386_pseudo_register_read_into_value): Update
5492         declaration.
5493         * ia64-tdep.c (ia64_pseudo_register_read): Likewise.
5494         * m32c-tdep.c (m32c_raw_read): Likewise.
5495         (m32c_read_flg): Likewise.
5496         (m32c_banked_register): Likewise.
5497         (m32c_banked_read): Likewise.
5498         (m32c_sb_read): Likewise.
5499         (m32c_part_read): Likewise.
5500         (m32c_cat_read): Likewise.
5501         (m32c_r3r2r1r0_read): Likewise.
5502         (m32c_pseudo_register_read): Likewise.
5503         * m68hc11-tdep.c (m68hc11_pseudo_register_read): Likewise.
5504         * mep-tdep.c (mep_pseudo_cr32_read): Likewise.
5505         (mep_pseudo_cr64_read): Likewise.
5506         (mep_pseudo_register_read): Likewise.
5507         * mips-tdep.c (mips_pseudo_register_read): Likewise.
5508         * msp430-tdep.c (msp430_pseudo_register_read): Likewise.
5509         * nds32-tdep.c (nds32_pseudo_register_read): Likewise.
5510         * regcache.c (regcache::raw_read): Move it to readable_regcache.
5511         (regcache::cooked_read): Likewise.
5512         (regcache::cooked_read_value): Likewise.
5513         (regcache_cooked_read_signed):
5514         (regcache::cooked_read): Likewise.
5515         * regcache.h (readable_regcache): New class.
5516         (regcache): Inherit readable_regcache.  Move some methods to
5517         readable_regcache.
5518         * rl78-tdep.c (rl78_pseudo_register_read): Change
5519         parameter type to 'readable_regcache *'.
5520         * rs6000-tdep.c (do_regcache_raw_read): Remove.
5521         (e500_pseudo_register_read): Change parameter type to
5522         'readable_regcache *'.
5523         (dfp_pseudo_register_read): Likewise.
5524         (vsx_pseudo_register_read): Likewise.
5525         (efpr_pseudo_register_read): Likewise.
5526         * s390-tdep.c (s390_pseudo_register_read): Likewise.
5527         * sh-tdep.c (sh_pseudo_register_read): Likewise.
5528         * sh64-tdep.c (pseudo_register_read_portions): Likewise.
5529         (sh64_pseudo_register_read): Likewise.
5530         * sparc-tdep.c (sparc32_pseudo_register_read): Likewise.
5531         * sparc64-tdep.c (sparc64_pseudo_register_read): Likewise.
5532         * spu-tdep.c (spu_pseudo_register_read_spu): Likewise.
5533         (spu_pseudo_register_read): Likewise.
5534         * xtensa-tdep.c (xtensa_register_read_masked): Likewise.
5535         (xtensa_pseudo_register_read): Likewise.
5536
5537 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5538
5539         * regcache.c (regcache::regcache): Call reg_buffer ctor.
5540         (regcache::arch): Move it to reg_buffer::arch.
5541         (regcache::register_buffer): Likewise.
5542         (regcache::assert_regnum): Likewise.
5543         (regcache::num_raw_registers): Likewise.
5544         * regcache.h (reg_buffer): New class.
5545         (regcache): Inherit reg_buffer.
5546
5547 2018-02-20  Simon Marchi  <simon.marchi@ericsson.com>
5548
5549         * remote-sim.c (gdb_os_printf_filtered, gdb_os_vprintf_filtered,
5550         gdb_os_evprintf_filtered, gdb_os_error): Add ATTRIBUTE_PRINTF.
5551
5552 2018-02-20  Markus Metzger  <markus.t.metzger@intel.com>
5553
5554         * gnulib/update-gnulib.sh (IMPORTED_GNULIB_MODULES): Add mkstemp.
5555
5556 2018-02-19  Alan Hayward  <alan.hayward@arm.com>
5557
5558         * Makefile.in: (COMMON_SFILES): Add common/*.c files.
5559         (SFILES): Remove common/*.c files.
5560         (COMMON_OBS): Remove some *.o files built from common/*.c files.
5561         * common/common.host: Add common reference.
5562         * configure.ac: Likewise.
5563         * configure: Regenerate.
5564
5565 2018-02-16  Yao Qi  <yao.qi@linaro.org>
5566
5567         * block.c (block_namespace_info): Inherit allocate_on_obstack.
5568         (block_initialize_namespace): Use new.
5569         * dwarf2read.c (dwarf2_per_objfile): Inherit allocate_on_obstack.
5570         (dwarf2_free_objfile): Use delete.
5571         * gdbtypes.c (type_pair): Inherit allocate_on_obstack.
5572         (copy_type_recursive): Use new.
5573         * gdb_obstack.h (allocate_on_obstack): New.
5574
5575 2018-02-15  Yao Qi  <yao.qi@linaro.org>
5576
5577         PR gdb/22849
5578         * inferior.c (exit_inferior_1): Reset inf->control.
5579
5580 2018-02-15  Joel Brobecker  <brobecker@adacore.com>
5581
5582         * ada-lang.c (ada_to_fixed_value_create): Delete advance
5583         declaration.
5584
5585 2018-02-14  Pedro Alves  <palves@redhat.com>
5586
5587         * frame-unwind.c (frame_unwind_try_unwinder): Always call
5588         frame_cleanup_after_sniffer on exception.
5589
5590 2018-02-14  Tom Tromey  <tom@tromey.com>
5591
5592         * solist.h (struct target_so_ops) <bfd_open>: Make pathname
5593         const.
5594         (solib_bfd_open): Make pathname const.
5595         * solib.c (solib_bfd_open): Make pathname const.
5596         * solib-spu.c (spu_bfd_fopen): Make name const.
5597         (spu_bfd_open): Make pathname const.
5598         * solib-darwin.c (darwin_bfd_open): Make pathname const.
5599         * solib-aix.c (solib_aix_bfd_open): Make pathname const.
5600
5601 2018-02-14  Tom Tromey  <tom@tromey.com>
5602
5603         * symfile.c (symfile_bfd_open): Update.
5604         * source.h (openp, source_full_path_of, find_and_open_source):
5605         Change argument type to unique_xmalloc_ptr.
5606         * source.c (openp): Take a unique_xmalloc_ptr.
5607         (source_full_path_of, find_and_open_source): Likewise.
5608         (open_source_file, symtab_to_fullname): Update.
5609         * solist.h (struct target_so_ops) <find_and_open_solib>: Take a
5610         unique_xmalloc_ptr.
5611         * solib.c (solib_find_1): Use unique_xmalloc_ptr.
5612         (exec_file_find): Update.
5613         * psymtab.c (psymtab_to_fullname): Update.
5614         * nto-tdep.h (nto_find_and_open_solib): Update.
5615         * nto-tdep.c (nto_find_and_open_solib): Change temp_path to a
5616         unique_xmalloc_ptr.
5617         * exec.c (exec_file_attach): Update.
5618         * dwarf2read.c (try_open_dwop_file): Use unique_xmalloc_ptr.
5619         * cli/cli-cmds.c (find_and_open_script): Use unique_xmalloc_ptr.
5620
5621 2018-02-14  Tom Tromey  <tom@tromey.com>
5622
5623         * solib.c: Include source.h.
5624         * nto-tdep.c: Include source.h.
5625         * mi/mi-cmd-env.c: Include source.h.
5626         * infcmd.c: Include source.h.
5627         * exec.c: Include source.h.
5628         * defs.h (enum openp_flag, openp, source_full_path_of, mod_path)
5629         (add_path, directory_switch, source_path, init_source_path): Move
5630         declarations...
5631         * source.h (enum openp_flag, openp, source_full_path_of, mod_path)
5632         (add_path, directory_switch, source_path, init_source_path):
5633         ...here.
5634
5635 2018-02-14  Tom Tromey  <tom@tromey.com>
5636
5637         * solist.h (exec_file_find, solib_find): Return
5638         unique_xmalloc_ptr.
5639         (solib_bfd_fopen): Take a const char *.
5640         * solib.c (solib_find_1): Return unique_xmalloc_ptr.
5641         (exec_file_find, solib_find): Likewise.
5642         (solib_bfd_fopen): Do not take ownership of "pathname".
5643         (solib_bfd_open): Use unique_xmalloc_ptr.
5644         * solib-darwin.c (darwin_bfd_open): Use unique_xmalloc_ptr.
5645         * solib-aix.c (solib_aix_bfd_open): Use unique_xmalloc_ptr.
5646         * infrun.c (follow_exec): Use unique_xmalloc_ptr.
5647         * exec.c (exec_file_locate_attach): Use unique_xmalloc_ptr.
5648
5649 2018-02-14  Joel Brobecker  <brobecker@adacore.com>
5650
5651         * ada-lang.c (name_match_type_from_name): Remove reference to
5652         ada_name_for_lookup in function's documentation.
5653         * ada-lang.h (ada_name_for_lookup): Delete declaration.
5654
5655 2018-02-13  Simon Marchi  <simon.marchi@polymtl.ca>
5656
5657         * defs.h (enum openp_flags): New enum.
5658         (OPF_TRY_CWD_FIRST, OPF_SEARCH_IN_PATH, OPF_RETURN_REALPATH):
5659         Move to enum openp_flags.
5660         (openp_flags): New enum flags.
5661         (openp): Change parameter type to openp_flags.
5662         * source.c (openp): Change parameter type to openp_flags.
5663         * cli/cli-cmds.c (find_and_open_script): Use openp_flags.
5664         * dwarf2read.c (try_open_dwop_file): Use openp_flags.
5665
5666 2018-02-13  Simon Marchi  <simon.marchi@polymtl.ca>
5667
5668         * maint.c (_initialize_maint_cmds): Fix prefix of maint set/show
5669         per-command.
5670
5671 2018-02-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5672
5673         * dwarf2read.c (dwarf2_release_queue): Delete function, move body
5674         into...
5675         (class dwarf2_queue_guard): ...the destructor of this new class.
5676         (dw2_do_instantiate_symtab): Create instance of the new class
5677         dwarf2_queue_guard, remove cleanup.
5678
5679 2018-02-09  Tom Tromey  <tom@tromey.com>
5680
5681         * source.c (find_source_lines): Don't reference past the end of
5682         the vector.
5683
5684 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5685
5686         * remote.c (remote_btrace_maybe_reopen): Change error message.
5687         * btrace.c (btrace_enable): Likewise.
5688         (parse_xml_btrace): Likewise.
5689         (parse_xml_btrace_conf): Likewise.
5690
5691 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5692
5693         * nat/linux-btrace.c (diagnose_perf_event_open_fail): New.
5694         (linux_enable_pt, linux_enable_bts): Call
5695         diagnose_perf_event_open_fail.
5696
5697 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5698
5699         * nat/linux-btrace.c (perf_event_pt_event_type): Improve error message.
5700         Remove parameter and change return type.  Update callers.  Move it.
5701         (linux_enable_bts, linux_enable_pt): Improve error message.
5702         (linux_enable_pt): Remove zero buffer size check.
5703         (linux_enable_btrace): Improve error messages.  Remove NULL return
5704         check.
5705
5706 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5707
5708         * btrace.c (btrace_enable): Remove target_supports_btrace call.
5709         * nat/linux-btrace.c (perf_event_pt_event_type): Move.
5710         (kernel_supports_bts, kernel_supports_pt, linux_supports_bts)
5711         (linux_supports_pt, linux_supports_btrace): Remove.
5712         (linux_enable_bts): Call cpu_supports_bts.
5713         * nat/linux-btrace.h (linux_supports_btrace): Remove.
5714         * remote.c (remote_supports_btrace): Remove.
5715         (init_remote_ops): Remove remote_supports_btrace.
5716         * target-delegates.c: Regenerated.
5717         * target.c (target_supports_btrace): Remove.
5718         * target.h (target_ops) <to_supports_btrace>: Remove
5719         (target_supports_btrace): Remove.
5720         * x86-linux-nat.c (x86_linux_create_target): Remove
5721         linux_supports_btrace.
5722
5723 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5724
5725         * nat/linux-btrace.c (linux_enable_btrace): Throw exception if enabling
5726         btrace failed.
5727         * x86-linux-nat.c (x86_linux_enable_btrace): Catch btrace enabling
5728         exception and use message in own exception.
5729
5730 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5731
5732         * nat/linux-btrace.c: Include scoped_fd.h and scoped_mmap.h.
5733         (perf_event_pt_event_type): Use gdb_file_up.
5734         (linux_enable_bts, linux_enable_pt): Use gdb::unique_xmalloc_ptr,
5735         scoped_fd, and scoped_mmap.
5736
5737 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5738
5739         * common/scoped_mmap.h: New.
5740         * unittests/scoped_mmap-selftest.c: New.
5741         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5742         unittests/scoped_mmap-selftest.c.
5743
5744 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5745
5746         * common/scoped_fd.h: New.
5747         * unittests/scoped_fd-selftest.c: New.
5748         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5749         unittests/scoped_fd-selftest.c.
5750
5751 2018-02-09  Tom Tromey  <tom@tromey.com>
5752
5753         * auto-load.c (auto_load_section_scripts): Use
5754         gdb::unique_xmalloc_ptr.
5755
5756 2018-02-09  Tom Tromey  <tom@tromey.com>
5757
5758         * auto-load.c (execute_script_contents): Use std::string.
5759
5760 2018-02-09  Joel Brobecker  <brobecker@adacore.com>
5761
5762         * NEWS <Changes in GDB 8.1>: Clarify that "rbreak" is a new
5763         Python function, rather than a new command.
5764
5765 2018-02-08  Tom Tromey  <tom@tromey.com>
5766
5767         * solib.c (solib_find_1): Use std::string.
5768         (solib_bfd_fopen): Use unique_xmalloc_ptr.
5769
5770 2018-02-08  Tom Tromey  <tom@tromey.com>
5771
5772         * build-id.c (build_id_to_debug_bfd): Use unique_xmalloc_ptr.
5773
5774 2018-02-08  Tom Tromey  <tom@tromey.com>
5775
5776         * source.c (find_source_lines): Use gdb::def_vector.
5777
5778 2018-02-08  Tom Tromey  <tom@tromey.com>
5779
5780         * macrocmd.c (struct temporary_macro_definition): New.
5781         (macro_define_command): Use temporary_macro_definition.  Remove
5782         cleanups.
5783         (free_macro_definition_ptr): Remove.
5784
5785 2018-02-08  Tom Tromey  <tom@tromey.com>
5786
5787         * macroexp.c (maybe_expand): Use std::string.
5788
5789 2018-02-08  Tom Tromey  <tom@tromey.com>
5790
5791         * macroexp.c (struct macro_buffer): Add initializers for some
5792         members.
5793         (init_buffer, init_shared_buffer, free_buffer)
5794         (free_buffer_return_text): Remove.
5795         (macro_buffer): New constructors.
5796         (~macro_buffer): New destructor.
5797         (macro_buffer::set_shared): New method.
5798         (macro_buffer::resize_buffer, macro_buffer::appendc)
5799         (macro_buffer::appendmem): Now methods, not free functions.
5800         (set_token, append_tokens_without_splicing, stringify)
5801         (macro_stringify): Update.
5802         (gather_arguments): Change return type.  Remove argc_p argument,
5803         add args_ptr argument.  Use std::vector.
5804         (substitute_args): Remove argc argument.  Accept std::vector.
5805         (expand): Update.  Use std::vector.
5806         (scan, macro_expand, macro_expand_next): Update.
5807
5808 2018-02-08  Tom Tromey  <tom@tromey.com>
5809
5810         * symtab.c (default_collect_symbol_completion_matches_break_on):
5811         Use unique_xmalloc_ptr.
5812         * macroscope.h: (sal_macro_scope, user_macro_scope)
5813         (default_macro_scope): Return unique_xmalloc_ptr.
5814         * macroscope.c (sal_macro_scope, user_macro_scope)
5815         (default_macro_scope): Return unique_xmalloc_ptr.
5816         * macroexp.h (macro_expand, macro_expand_once): Return
5817         unique_xmalloc_ptr.
5818         * macroexp.c (macro_expand, macro_expand_once): Return
5819         unique_xmalloc_ptr.
5820         * macrocmd.c (macro_expand_command, macro_expand_once_command)
5821         (info_macro_command, info_macros_command): Use
5822         unique_xmalloc_ptr.
5823         * compile/compile-c-support.c (write_macro_definitions): Use
5824         unique_xmalloc_ptr.
5825         * c-exp.y (c_parse): Use unique_xmalloc_ptr.
5826
5827 2018-02-07  Simon Marchi  <simon.marchi@ericsson.com>
5828
5829         * value.c (value_static_field): Assign field type instead of
5830         containing type when returning an optimized out value.
5831
5832 2018-02-06  Yao Qi  <yao.qi@linaro.org>
5833
5834         * ft32-tdep.c (ft32_read_pc): Remove.
5835         (ft32_write_pc): Remove.
5836         (ft32_gdbarch_init): Update.
5837         * m32r-tdep.c (m32r_read_pc): Remove.
5838         (m32r_gdbarch_init): Update.
5839         * mep-tdep.c (mep_read_pc): Remove.
5840         (mep_gdbarch_init): Update.
5841         * microblaze-tdep.c (microblaze_write_pc): Remove.
5842         (microblaze_gdbarch_init): Update.
5843         * mn10300-tdep.c (mn10300_read_pc): Remove.
5844         (mn10300_write_pc): Remove.
5845         (mn10300_gdbarch_init): Update.
5846         * moxie-tdep.c (moxie_read_pc): Remove.
5847         (moxie_write_pc): Remove.
5848         (moxie_gdbarch_init): Update.
5849
5850 2018-02-06  Yao Qi  <yao.qi@linaro.org>
5851
5852         * expprint.c (print_subexp_standard): Handle
5853         OP_F77_UNDETERMINED_ARGLIST.
5854         (dump_subexp_body_standard): Likewise.
5855
5856 2018-02-05  Alan Hayward  <alan.hayward@arm.com>
5857
5858         * target-descriptions.c (tdesc_element_visitor) Add empty
5859         implementations.
5860         (tdesc_type): Move make_gdb_type from here.
5861         (tdesc_type_builtin): Likewise.
5862         (tdesc_type_vector): Likewise.
5863         (tdesc_type_with_fields): Move make_gdb_type_ functions from here.
5864         (make_gdb_type_struct): Move from tdesc_type_with_fields.
5865         (make_gdb_type_union): Likewise.
5866         (make_gdb_type_flags): Likewise.
5867         (make_gdb_type_enum): Likewise.
5868         (make_gdb_type): New function.
5869         (tdesc_register_type): Use static make_gdb_type.
5870
5871 2018-02-05  Ruslan Kabatsayev <b7.10110111@gmail.com>
5872
5873         * infcmd.c (default_print_one_register_info): Align natural-format
5874         column values consistently one under another.
5875         (pad_to_column): New function.
5876
5877 2018-02-05  Joel Brobecker  <brobecker@adacore.com>
5878
5879         * dwarf2read.c (dwarf2_physname): Move commment.
5880
5881 2018-02-01  Leszek Swirski  <leszeks@google.com>
5882
5883         * varobj.c (varobj_formatted_print_options): Allow recursive
5884         pretty printing if pretty printing is enabled.
5885
5886 2018-02-01  Leszek Swirski  <leszeks@google.com>
5887
5888         * c-exp.y (lex_one_token, classify_name, yylex): Don't classify
5889         names after a structop as a filename.
5890
5891 2018-02-01  Yao Qi  <yao.qi@linaro.org>
5892
5893         * arm-tdep.c (arm_record_data_proc_misc_ld_str): Rewrite it.
5894         (arm_record_coproc_data_proc): Likewise.
5895
5896 2018-02-01  Yao Qi  <yao.qi@linaro.org>
5897
5898         * arm-tdep.c (arm_record_extension_space): Change ret to signed.
5899
5900 2018-01-31  Nikola Prica  <nikola.prica@rt-rk.com>
5901
5902         * rs6000-tdep.c (skip_prologue): Remove shifting for lr_reg and
5903         assign shifted lr_reg to fdata->lr_register when lr_reg is set.
5904
5905 2018-01-31  Pedro Alves  <palves@redhat.com>
5906
5907         * darwin-nat.c (darwin_interrupt): Remove ptid_t parameter.
5908         * inflow.c (child_terminal_save_inferior): Wrap reference to
5909         tcgetpgrp in HAVE_TERMIOS_H.
5910         (child_interrupt, child_pass_ctrlc): Wrap references to signal in
5911         _WIN32.
5912         * remote-sim.c (gdbsim_interrupt): Remove ptid_t parameter and
5913         always iterate over all inferiors.
5914         (gdbsim_cntrl_c): Adjust.
5915         * windows-nat.c (windows_interrupt): Remove 'ptid_t' parameter.
5916
5917 2018-01-31  Joel Brobecker  <brobecker@adacore.com>
5918
5919         * gdbtypes.c (lookup_array_range_type): Make sure the array's
5920         index type is objfile-owned if the element type is as well.
5921
5922 2018-01-31  Joel Brobecker  <brobecker@adacore.com>
5923
5924         GDB 8.1 released.
5925
5926 2018-01-30  Philipp Rudo  <prudo@linux.vnet.ibm.com>
5927
5928         * s390-linux-tdep.c: Remove includes "features/s390-linux32.c" and
5929         "features/s390x-linux64.c".
5930         (_initialize_s390_linux_tdep): Remove initialization of tdescs
5931         s390_linux32 and s390x_linux64.
5932         (s390_linux_init_abi_31, s390_linux_init_abi_64): Don't set
5933         default tdesc.
5934         * s390-tdep.c: Include "features/s390-linux32.c" and
5935         "features/s390x-linux64.c".
5936         (s390_tdesc_valid): Add check for tdesc_has_registers.
5937         (s390_gdbarch_init): Make sure there is always a valid tdesc.
5938         (_initialize_s390_tdep): Initialize tdesc_s390_linux32 and
5939         tdesc_s390x_linux64.
5940         * s390-linux-tdep.h: Move export of tdesc_s390_linux32 and
5941         tdesc_s390x_linux64 to...
5942         * s390-tdep.h: ...here.
5943
5944 2018-01-30  Pedro Alves  <palves@redhat.com>
5945
5946         PR gdb/13211
5947         * config.in, configure: Regenerate.
5948         * configure.ac: Check for getpgid.
5949         * go32-nat.c (go32_pass_ctrlc): New.
5950         (go32_target): Install it.
5951         * inf-child.c (inf_child_target): Install
5952         child_terminal_save_inferior, child_pass_ctrlc and
5953         child_interrupt.
5954         * inf-ptrace.c (inf_ptrace_interrupt): Delete.
5955         (inf_ptrace_target): No longer install it.
5956         * infcmd.c (interrupt_target_1): Adjust.
5957         * inferior.h (child_terminal_save_inferior, child_pass_ctrlc)
5958         (child_interrupt): Declare.
5959         (inferior::terminal_state): New.
5960         * inflow.c (struct terminal_info): Update comments.
5961         (inferior_process_group): Delete.
5962         (terminal_is_ours): Delete.
5963         (gdb_tty_state): New.
5964         (child_terminal_init): Adjust.
5965         (is_gdb_terminal, sharing_input_terminal_1)
5966         (sharing_input_terminal): New functions.
5967         (child_terminal_inferior): Adjust.  Use sharing_input_terminal.
5968         Set the process's actual process group in the foreground if
5969         possible.  Handle is_ours_for_output/is_ours distinction.  Don't
5970         mark terminal as the inferior's if not sharing GDB's terminal.
5971         Don't check attach_flag.
5972         (child_terminal_ours_for_output, child_terminal_ours): Adjust to
5973         pass down a target_terminal_state.
5974         (child_terminal_save_inferior): New, factored out from ...
5975         (child_terminal_ours_1): ... this.  Handle
5976         target_terminal_state::is_ours_for_output.
5977         (child_interrupt, child_pass_ctrlc): New.
5978         (inflow_inferior_exit): Clear the inferior's terminal_state.
5979         (copy_terminal_info): Copy the inferior's terminal state.
5980         (_initialize_inflow): Remove reference to terminal_is_ours.
5981         * inflow.h (inferior_process_group): Delete.
5982         * nto-procfs.c (nto_handle_sigint, procfs_interrupt): Adjust.
5983         * procfs.c (procfs_target): Don't install procfs_interrupt.
5984         (procfs_interrupt): Delete.
5985         * remote.c (remote_serial_quit_handler): Adjust.
5986         (remote_interrupt): Remove ptid parameter.  Adjust.
5987         * target-delegates.c: Regenerate.
5988         * target.c: Include "terminal.h".
5989         (target_terminal::terminal_state): Rename to ...
5990         (target_terminal::m_terminal_state): ... this.
5991         (target_terminal::init): Adjust.
5992         (target_terminal::inferior): Adjust to per-inferior
5993         terminal_state.
5994         (target_terminal::restore_inferior, target_terminal_is_ours_kind): New.
5995         (target_terminal::ours, target_terminal::ours_for_output): Use
5996         target_terminal_is_ours_kind.
5997         (target_interrupt): Remove ptid parameter.  Adjust.
5998         (default_target_pass_ctrlc): Adjust.
5999         * target.h (target_ops::to_terminal_save_inferior): New field.
6000         (target_ops::to_interrupt): Remove ptid_t parameter.
6001         (target_interrupt): Remove ptid_t parameter.  Update comment.
6002         (target_pass_ctrlc): Update comment.
6003         * target/target.h (target_terminal_state): New scoped enum,
6004         factored out of ...
6005         (target_terminal::terminal_state): ... here.
6006         (target_terminal::inferior): Update comments.
6007         (target_terminal::restore_inferior): New.
6008         (target_terminal::is_inferior, target_terminal::is_ours)
6009         (target_terminal::is_ours_for_output): Adjust.
6010         (target_terminal::scoped_restore_terminal_state): Adjust to
6011         rename, and call restore_inferior() instead of inferior().
6012         (target_terminal::scoped_restore_terminal_state::m_state): Change
6013         type.
6014         (target_terminal::terminal_state): Rename to ...
6015         (target_terminal::m_terminal_state): ... this and change type.
6016
6017 2018-01-30  Pedro Alves  <palves@redhat.com>
6018
6019         * linux-nat.c (wait_for_signal): New function.
6020         (wait_lwp, linux_nat_wait_1): Use it instead of calling sigsuspend
6021         directly.
6022         (async_terminal_is_ours)
6023         (linux_nat_terminal_inferior, linux_nat_terminal_ours): Delete.
6024         (linux_nat_add_target): Don't override
6025         to_terminal_inferior/to_terminal_ours.
6026
6027 2018-01-29  Sergio Durigan Junior  <sergiodj@redhat.com>
6028
6029         * remote.c (remote_follow_fork): Don't call "detach_inferior".
6030
6031 2018-01-28  Simon Marchi  <simon.marchi@ericsson.com>
6032
6033         * dwarf2read.c (free_dwo_files): Add forward-declaration.
6034         (dwarf2_per_objfile::~dwarf2_per_objfile): Move content from
6035         dwarf2_per_objfile_free here.
6036         (dwarf2_per_objfile_free): Remove.
6037         (_initialize_dwarf2_read): Don't register
6038         dwarf2_per_objfile_free as a registry cleanup.
6039
6040 2018-01-27  Eli Zaretskii  <eliz@gnu.org>
6041
6042         Avoid compilation errors in MinGW native builds
6043
6044         The error is triggered by including python-internal.h, and the
6045         error message is:
6046
6047              In file included from d:\usr\lib\gcc\mingw32\6.3.0\include\c++\math.h:36:0,
6048                       from build-gnulib/import/math.h:27,
6049                       from d:/usr/Python26/include/pyport.h:235,
6050                       from d:/usr/Python26/include/Python.h:58,
6051                       from python/python-internal.h:94,
6052                       from python/py-arch.c:24:
6053              d:\usr\lib\gcc\mingw32\6.3.0\include\c++\cmath:1157:11: error: '::hypot' has not been declared
6054         using ::hypot;
6055                 ^~~~~
6056
6057         This happens because Python headers define 'hypot' to expand t
6058         '_hypot' in the Windows builds.
6059         * python/python-internal.h (_hypot) [__MINGW32__]: Define back to
6060         'hypoth'.  This avoids a compilation error.
6061
6062 2018-01-26  Alan Hayward  <alan.hayward@arm.com>
6063
6064         * MAINTAINERS (Write After Approval): Fix ordering.
6065
6066 2018-01-26  Alan Hayward  <alan.hayward@arm.com>
6067
6068         * MAINTAINERS (Write After Approval): Add Alan Hayward.
6069
6070 2018-01-26  Alan Modra  <amodra@gmail.com>
6071
6072         * ppc-linux-tdep.c (powerpc32_plt_stub): Make const.
6073         (powerpc32_plt_stub_so_1): Rename from powerpc32_plt_stub_so.
6074         Remove nop.  Make const.  Comment.
6075         (powerpc32_plt_stub_so_2): New.
6076         (POWERPC32_PLT_CHECK_LEN): Rename from POWERPC32_PLT_STUB_LEN.
6077         Correct count.  Update uses.
6078         (ppc_skip_trampoline_code): Match powerpc32_plt_stub_so_2 too.
6079         Move common code reading PLT entry word.  Correct
6080         powerpc32_plt_stub PLT address calculation.
6081         * ppc64-tdep.c (ppc64_standard_linkage1): Make const.
6082         (ppc64_standard_linkage2, ppc64_standard_linkage3): Likewise.
6083         (ppc64_standard_linkage4, ppc64_standard_linkage5): Likewise.
6084         (ppc64_standard_linkage6, ppc64_standard_linkage7): Likewise.
6085         (ppc64_standard_linkage8): Likewise.
6086         * rs6000-tdep.c (ppc_insns_match_pattern): Make pattern const.
6087         Correct insns description.
6088         * ppc-tdep.h (ppc_insns_match_pattern): Update prototype.
6089
6090 2018-01-24  Pedro Alves  <palves@redhat.com>
6091
6092         GCC PR libstdc++/83906
6093         * gdbtypes.c (operator==(const dynamic_prop &,
6094         const dynamic_prop &)): New.
6095         (operator==(const range_bounds &, const range_bounds &)): New.
6096         (check_types_equal): Use them instead of memcmp.
6097         * gdbtypes.h (operator==(const dynamic_prop &,
6098         const dynamic_prop &)): Declare.
6099         (operator!=(const dynamic_prop &, const dynamic_prop &)): Declare.
6100         (operator==(const range_bounds &, const range_bounds &)): Declare.
6101         (operator!=(const range_bounds &, const range_bounds &)): Declare.
6102
6103 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6104
6105         * s390-linux-tdep.c (s390_record_address_mask)
6106         (s390_record_calc_disp_common, s390_record_calc_disp)
6107         (s390_record_calc_disp_vsce, s390_record_calc_rl, s390_popcnt)
6108         (s390_record_gpr_g, s390_record_gpr_h, s390_record_vr)
6109         (s390_process_record): Move to s390-tdep.c.
6110         (s390_linux_init_abi_any): Adjust.
6111         * s390-tdep.c (s390_record_address_mask)
6112         (s390_record_calc_disp_common, s390_record_calc_disp)
6113         (s390_record_calc_disp_vsce, s390_record_calc_rl, s390_popcnt)
6114         (s390_record_gpr_g, s390_record_gpr_h, s390_record_vr)
6115         (s390_process_record): Moved from s390-linux-tdep.c
6116         (s390_gdbarch_init): Adjust.
6117
6118 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6119
6120         * s390-linux-nat.c (s390-tdep.h): New include.
6121         * Makefile.in (ALL_TARGET_OBS): Add s390-tdep.o.
6122         (HFILES_NO_SRCDIR): Add s390-tdep.h.
6123         (ALLDEPFILES): Add s390-tdep.c.
6124         * configure.tgt (s390*-*-linux*): Add s390-tdep.o.
6125         * s390-linux-tdep.h (HWCAP_S390_*, S390_*_REGNUM): Move to...
6126         * s390-tdep.h: ...this.  New file.
6127         * s390-linux-tdep.c (s390-tdep.h): New include.
6128         (_initialize_s390_tdep): Rename to...
6129         (_initialize_s390_linux_tdep): ...this and adjust.
6130         (s390_abi_kind, s390_vector_abi_kind, gdbarch_tdep)
6131         (enum named opcodes, S390_NUM_GPRS, S390_NUM_FPRS): Move to
6132         s390-tdep.h.
6133         (s390_break_insn, s390_breakpoint, s390_readinstruction, is_ri)
6134         (is_ril, is_rr, is_rre, is_rs, is_rsy, is_rx, is_rxy)
6135         (s390_is_partial_instruction, s390_software_single_step)
6136         (is_non_branch_ril, s390_displaced_step_copy_insn)
6137         (s390_displaced_step_fixup, s390_displaced_step_hw_singlestep)
6138         (s390_prologue_data, s390_addr, s390_store, s390_load)
6139         (s390_check_for_saved, s390_analyze_prologue, s390_skip_prologue)
6140         (s390_register_call_saved, s390_guess_tracepoint_registers)
6141         (s390_register_name, s390_dwarf_regmap, s390_dwarf_reg_to_regnum)
6142         (regnum_is_gpr_full, regnum_is_vxr_full, s390_value_from_register)
6143         (s390_pseudo_register_name, s390_pseudo_register_type)
6144         (s390_pseudo_register_read, s390_pseudo_register_write)
6145         (s390_pseudo_register_reggroup_p, s390_ax_pseudo_register_collect)
6146         (s390_ax_pseudo_register_push_stack, s390_gen_return_address)
6147         (s390_addr_bits_remove, s390_address_class_type_flags)
6148         (s390_address_class_type_flags_to_name)
6149         (s390_address_class_name_to_type_flags, s390_effective_inner_type)
6150         (s390_function_arg_float, s390_function_arg_vector)
6151         (is_power_of_two, s390_function_arg_integer, s390_arg_state)
6152         (s390_handle_arg, s390_push_dummy_call, s390_dummy_id)
6153         (s390_frame_align, s390_register_return_value, s390_return_value)
6154         (s390_stack_frame_destroyed_p, s390_unwind_pc, s390_unwind_sp)
6155         (s390_unwind_pseudo_register, s390_adjust_frame_regnum)
6156         (s390_dwarf2_prev_register, s390_dwarf2_frame_init_reg)
6157         (s390_trad_frame_prev_register, s390_unwind_cache)
6158         (s390_prologue_frame_unwind_cache)
6159         (s390_backchain_frame_unwind_cache, s390_frame_unwind_cache)
6160         (s390_frame_this_id, s390_frame_prev_register, s390_frame_unwind)
6161         (s390_stub_unwind_cache, s390_stub_frame_unwind_cache)
6162         (s390_stub_frame_this_id, s390_stub_frame_prev_register)
6163         (s390_stub_frame_sniffer, s390_stub_frame_unwind)
6164         (s390_frame_base_address, s390_local_base_address)
6165         (s390_frame_base, s390_gcc_target_options)
6166         (s390_gnu_triplet_regexp, s390_stap_is_single_operand)
6167         (s390_validate_reg_range, s390_tdesc_valid)
6168         (s390_gdbarch_tdep_alloc, s390_gdbarch_init): Move to...
6169         * s390-tdep.c: ...this.  New file.
6170
6171 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6172
6173         * s390-linux-tdep.c (gdbarch_tdep.s390_syscall_record): New hook.
6174         (s390_process_record, s390_gdbarch_tdep_alloc)
6175         (s390_linux_init_abi_any): Use/set new hook.
6176
6177 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6178
6179         * s390-linux-tdep.c (osabi.h): New include.
6180         (s390_linux_init_abi_31, s390_linux_init_abi_64)
6181         (s390_linux_init_abi_any): New functions.
6182         (s390_gdbarch_init, _initialize_s390_tdep): Adjust.
6183
6184 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6185
6186         * s390-linux-tdep.c (s390_gdbarch_init): Use gdb_assert for
6187         tdesc_has_registers check
6188
6189 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6190
6191         * s390-linux-tdep.c (s390_tdesc_valid): New function.
6192         (s390_validate_reg_range): New macro.
6193         (s390_gdbarch_init): Adjust.
6194
6195 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6196
6197         * s390-linux-tdep.c (gdbarch_tdep) <tdesc>: New field.
6198         (s390_gdbarch_tdep_alloc): Adjust.
6199         (s390_gdbarch_init): Adjust.
6200
6201 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6202
6203         * s390-linux-tdep.c (gdbarch_tdep) <have_linux_v1, have_linux_v2>
6204         <have_tdb>: Change type to bool.
6205         (s390_gdbarch_tdep_alloc): Adjust.
6206         (s390_gdbarch_init): Adjust.
6207
6208 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6209
6210         * s390-linux-tdep (s390_abi_kind) <ABI_NONE>: New default field.
6211         (gdbarch_tdep) <have_upper, have_vx>: New fields.
6212         (s390_gdbarch_tdep_alloc): New function.
6213         (s390_gdbarch_init): Allocate tdep at start and use its fields
6214         instead of separate variables.
6215
6216 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6217
6218         * s390-linux-tdep.c (s390_gdbarch_init): Remove duplicate checks
6219         when looking for cached gdbarch and add comment for remaining.
6220
6221 2018-01-22  Pedro Alves  <palves@redhat.com>
6222             Sergio Durigan Junior  <sergiodj@redhat.com>
6223
6224         * typeprint.c (whatis_exp): Initialize "val" in the "whatis type"
6225         case.
6226
6227 2018-01-22  Maciej W. Rozycki  <macro@mips.com>
6228
6229         * MAINTAINERS: Update my company e-mail address.
6230
6231 2018-01-22  Yao Qi  <yao.qi@linaro.org>
6232
6233         * regcache.c (cooked_write_test): New function.
6234         (_initialize_regcache): Register the test.
6235
6236 2018-01-22  Yao Qi  <yao.qi@linaro.org>
6237
6238         * ia64-tdep.c (ia64_pseudo_register_read): Call
6239         regcache->cooked_read instead of regcache_cooked_read_unsigned.
6240         * m32c-tdep.c (m32c_cat_read): Likewise.
6241         (m32c_r3r2r1r0_read): Likewise.
6242         * m68hc11-tdep.c (m68hc11_pseudo_register_read): Likewise.
6243         * xtensa-tdep.c (xtensa_register_read_masked): Likewise.
6244
6245 2018-01-22  Yao Qi  <yao.qi@linaro.org>
6246
6247         * aarch64-tdep.c (aarch64_pseudo_read_value): Call regcache
6248         method raw_read instead of regcache_raw_read.
6249         * amd64-tdep.c (amd64_pseudo_register_read_value): Likewise.
6250         * arm-tdep.c (arm_neon_quad_read): Likewise.
6251         * avr-tdep.c (avr_pseudo_register_read): Likewise.
6252         * bfin-tdep.c (bfin_pseudo_register_read): Likewise.
6253         * frv-tdep.c (frv_pseudo_register_read): Likewise.
6254         * h8300-tdep.c (h8300_pseudo_register_read): Likewise.
6255         * i386-tdep.c (i386_mmx_regnum_to_fp_regnum): Likewise.
6256         (i386_pseudo_register_read_into_value): Likewise.
6257         * mep-tdep.c (mep_pseudo_cr32_read): Likewise.
6258         * msp430-tdep.c (msp430_pseudo_register_read): Likewise.
6259         * nds32-tdep.c (nds32_pseudo_register_read): Likewise.
6260         * rl78-tdep.c (rl78_pseudo_register_read): Likewise.
6261         * s390-linux-tdep.c (s390_pseudo_register_read): Likewise.
6262         * sparc-tdep.c (sparc32_pseudo_register_read):  Likewise.
6263         * sparc64-tdep.c (sparc64_pseudo_register_read): Likewise.
6264         * spu-tdep.c (spu_pseudo_register_read_spu):  Likewise.
6265         * xtensa-tdep.c (xtensa_pseudo_register_read): Likewise.
6266
6267 2018-01-22  Yao Qi  <yao.qi@linaro.org>
6268
6269         * Makefile.in (ALL_TARGET_OBS): Remove mt-tdep.o.
6270         * configure.tgt: Remove target mt.
6271         * mt-tdep.c: Remove.
6272         * regcache.c (cooked_read_test): Remove the check for mt.
6273
6274 2018-01-22  Yao Qi  <yao.qi@linaro.org>
6275
6276         * jit.c (jit_frame_prev_register): Call regcache::cooked_read
6277         instead of gdbarch_pseudo_register_read_value.
6278
6279 2018-01-22  Joel Brobecker  <brobecker@adacore.com>
6280
6281         * dwarf2read.c (need_gnat_info): Return nonzero if the cu's
6282         language is Ada.
6283
6284 2018-01-22  Joel Brobecker  <brobecker@adacore.com>
6285
6286         * linespec.c (create_sals_line_offset): Remove code that preserved
6287         the symtab_and_line's line number.
6288
6289 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6290
6291         * varobj.c (varobj_create): Don't set valid_block when creating a
6292         floating varobj.
6293
6294 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6295
6296         * varobj.c (varobj_create): Remove out of date comment.
6297
6298 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6299
6300         PR mi/20395
6301         * ada-exp.y (write_var_from_sym): Pass extra parameter when
6302         updating innermost block.
6303         * parse.c (innermost_block_tracker::update): Take extra type
6304         parameter, and check types match before updating innermost block.
6305         (write_dollar_variable): Update innermost block for registers.
6306         * parser-defs.h (enum innermost_block_tracker_type): New enum.
6307         (innermost_block_tracker::innermost_block_tracker): Initialise
6308         m_types member.
6309         (innermost_block_tracker::reset): Take type parameter.
6310         (innermost_block_tracker::update): Take type parameter, and pass
6311         type through as needed.
6312         (innermost_block_tracker::m_types): New member.
6313         * varobj.c (varobj_create): Pass type when reseting innermost
6314         block.
6315
6316 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6317
6318         * ada-exp.y (write_var_from_sym): Switch to innermost_block API.
6319         * ada-lang.c (resolve_subexp): Likewise.
6320         * breakpoint.c (set_breakpoint_condition) Likewise.
6321         (watch_command_1) Likewise.
6322         * c-exp.y (variable): Likewise.
6323         * d-exp.y (PrimaryExpression): Likewise.
6324         * f-exp.y (variable): Likewise.
6325         * go-exp.y (variable): Likewise.
6326         * m2-exp.y (variable): Likewise.
6327         * objfiles.c (objfile::~objfile): Likewise.
6328         * p-exp.y (variable): Likewise.
6329         * parse.c (innermost_block): Change type.
6330         * parser-defs.h (class innermost_block_tracker): New.
6331         (innermost_block): Change to innermost_block_tracker.
6332         * printcmd.c (display_command): Switch to innermost_block API.
6333         (do_one_display): Likewise.
6334         * rust-exp.y (do_one_display): Likewise.
6335         * symfile.c (clear_symtab_users): Likewise.
6336         * varobj.c (varobj_create): Switch to innermost_block API, replace
6337         use of innermost_block with block stored on varobj object.
6338
6339 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6340
6341         * expression.h (innermost_block): Remove declaration.
6342         * varobj.c: Add 'parser-defs.h' include.
6343
6344 2018-01-19  Tom Tromey  <tom@tromey.com>
6345
6346         * rust-lang.c (rust_lookup_symbol_nonlocal): Look up qualified
6347         symbols in the static and global blocks.
6348
6349 2018-01-19  James Clarke  <jrtc27@jrtc27.com>
6350
6351         * nat/linux-ptrace.c: Remove unnecessary reinclusion of
6352         gdb_ptrace.h, and move including gdb_wait.h ...
6353         * nat/linux-ptrace.h: ... to here.
6354
6355 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
6356
6357         * inf-ptrace.c (inf_ptrace_detach): Adjust call to
6358         inf_ptrace_detach_success.
6359         (inf_ptrace_detach_success): Add inferior parameter, use it
6360         instead of inferior_ptid, pass it to detach_inferior.
6361         * inf-ptrace.h (inf_ptrace_detach_success): Add inferior
6362         parameter.
6363         * inferior.c (detach_inferior): Add overload that takes an
6364         inferior object.
6365         * inferior.h (detach_inferior): Likewise.
6366         * linux-nat.c (linux_nat_detach): Use the inf parameter, don't
6367         use inferior_ptid, adjust call to inf_ptrace_detach_success.
6368         * linux-thread-db.c (thread_db_detach): Use inf parameter.
6369
6370 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
6371
6372         * target.h (struct target_ops) <to_detach>: Add inferior
6373         parameter.
6374         (target_detach): Likewise.
6375         * target.c (dispose_inferior): Pass inferior down.
6376         (target_detach): Pass inferior down.  Assert that it is equal to
6377         the current inferior.
6378         * aix-thread.c (aix_thread_detach): Pass inferior down.
6379         * corefile.c (core_file_command): Pass current_inferior() down.
6380         * corelow.c (core_detach): Add inferior parameter.
6381         * darwin-nat.c (darwin_detach): Likewise.
6382         * gnu-nat.c (gnu_detach): Likewise.
6383         * inf-ptrace.c (inf_ptrace_detach): Likewise.
6384         * infcmd.c (detach_command): Pass current_inferior() down to
6385         target_detach.
6386         * infrun.c (follow_fork_inferior): Pass parent_inf to
6387         target_detach.
6388         (handle_vfork_child_exec_or_exit): Pass inf->vfork_parent to
6389         target_detach.
6390         * linux-nat.c (linux_nat_detach): Add inferior parameter.
6391         * linux-thread-db.c (thread_db_detach): Likewise.
6392         * nto-procfs.c (procfs_detach): Likewise.
6393         * procfs.c (procfs_detach): Likewise.
6394         * record.c (record_detach): Likewise.
6395         * record.h (struct inferior): Forward-declare.
6396         (record_detach): Add inferior parameter.
6397         * remote-sim.c (gdbsim_detach): Likewise.
6398         * remote.c (remote_detach_1): Likewise.
6399         (remote_detach): Likewise.
6400         (extended_remote_detach): Likewise.
6401         * sol-thread.c (sol_thread_detach): Likewise.
6402         * target-debug.h (target_debug_print_inferior_p): New macro.
6403         * target-delegates.c: Re-generate.
6404         * top.c (kill_or_detach): Pass inferior down to target_detach.
6405         * windows-nat.c (windows_detach): Add inferior parameter.
6406
6407 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
6408
6409         * target.h (struct target_ops) <to_detach>: Remove args
6410         parameter.
6411         (target_detach): Likewise.
6412         * target.c (dispose_inferior): Adjust.
6413         (target_detach): Remove args parameter, adjust.
6414         * aix-thread.c (aix_thread_detach): Adjust.
6415         * corefile.c (core_file_command): Adjust.
6416         * corelow.c (core_detach): Adjust.
6417         * darwin-nat.c (darwin_detach): Adjust.
6418         * gnu-nat.c (gnu_detach): Adjust.
6419         * inf-ptrace.c (inf_ptrace_detach): Adjust.
6420         * infcmd.c (detach_command): Adjust
6421         * infrun.c (follow_fork_inferior): Adjust.
6422         (handle_vfork_child_exec_or_exit): Adjust.
6423         * linux-fork.c (linux_fork_detach): Remove args parameter.
6424         * linux-fork.h (linux_fork_detach): Likewise.
6425         * linux-nat.c (linux_nat_detach): Likewise, and adjust.
6426         * linux-thread-db.c (thread_db_detach): Likewise.
6427         * nto-procfs.c (procfs_detach): Likewise.
6428         * procfs.c (procfs_detach): Likewise.
6429         (do_detach): Remove signo parameter.
6430         * record.c (record_detach): Remove args parameter.
6431         * record.h (record_detach): Likewise.
6432         * remote-sim.c (gdbsim_detach): Likewise.
6433         * remote.c (remote_detach_1): Likewise.
6434         (remote_detach): Likewise.
6435         (extended_remote_detach): Likewise.
6436         * sol-thread.c (sol_thread_detach): Likewise.
6437         * target-delegates.c: Re-generate.
6438         * top.c (struct qt_args) <args>: Remove field.
6439         (kill_or_detach): Don't pass args.
6440         (quit_force): Don't set args.
6441         * windows-nat.c (windows_detach): Remove args parameter.
6442
6443 2018-01-19  Yao Qi  <yao.qi@linaro.org>
6444
6445         * arm-linux-tdep.c (arm_linux_gcc_target_options): New function.
6446         (arm_linux_init_abi): Install it.
6447
6448 2018-01-19  Yao Qi  <yao.qi@linaro.org>
6449
6450         * osabi.c (gdb_osabi_names): Extend the regexp for
6451         arm-linux-gnueabihf.
6452
6453 2018-01-18  Yao Qi  <yao.qi@linaro.org>
6454
6455         * dwarf2read.c (abbrev_table) <abbrevs>: Rename it to
6456         m_abbrevs.
6457         (abbrev_table::add_abbrev): Update.
6458         (abbrev_table::lookup_abbrev): Update.
6459
6460 2018-01-18  Yao Qi  <yao.qi@linaro.org>
6461
6462         * ppc-linux-tdep.c (ppu2spu_prev_register): Call cooked_read.
6463
6464 2018-01-17  Sergio Durigan Junior  <sergiodj@redhat.com>
6465
6466         * compile/compile.c (compile_to_object): Convert "triplet_rx"
6467         to "std::string".
6468
6469 2018-01-17  Tom Tromey  <tom@tromey.com>
6470
6471         * dwarf2read.c (symbolp): Remove typedef.  Don't instantiate VEC.
6472
6473 2018-01-17  Tom Tromey  <tom@tromey.com>
6474
6475         * gdbtypes.h (add_dyn_prop): Remove objfile parameter.
6476         * gdbtypes.c (add_dyn_prop): Remove objfile parameter.
6477         (create_array_type_with_stride): Update.
6478         * dwarf2read.c (set_die_type): Update.
6479
6480 2018-01-17  Tom Tromey  <tom@tromey.com>
6481
6482         * dwarf2read.c (delayed_method_info): Remove typedef.
6483         (dwarf2_cu::method_info): Now a std::vector.
6484         (add_to_method_list): Update.
6485         (free_delayed_list): Remove.
6486         (compute_delayed_physnames): Update.
6487         (process_full_comp_unit, process_full_type_unit): Clear the method
6488         list.  Remove cleanups.
6489         (psymtab_include_file_name): Add name_holder parameter.  Use
6490         unique_xmalloc_ptr.
6491         (dwarf_decode_lines): Update.
6492
6493 2018-01-17  Tom Tromey  <tom@tromey.com>
6494             Simon Marchi  <simon.marchi@ericsson.com>
6495
6496         * dwarf2read.c (struct dwarf2_cu): Add constructor, destructor.
6497         (dwarf2_per_objfile::free_cached_comp_units)
6498         (init_tu_and_read_dwo_dies, init_cutu_and_read_dies)
6499         (init_cutu_and_read_dies_no_follow): Update.
6500         (dwarf2_cu::dwarf2_cu): Rename from init_one_comp_unit.
6501         (dwarf2_cu::~dwarf2_cu): New.
6502         (free_heap_comp_unit, free_stack_comp_unit): Remove.
6503         (age_cached_comp_units, free_one_cached_comp_unit): Update.
6504
6505 2018-01-17  Tom Tromey  <tom@tromey.com>
6506             Simon Marchi  <simon.marchi@ericsson.com>
6507
6508         * dwarf2read.c (struct dwarf2_cu) <abbrev_table>: Remove.
6509         (struct die_reader_specs) <abbrev_table>: New member.
6510         (struct abbrev_table): Add constructor.
6511         <alloc_abbrev, add_abbrev, lookup_abbrev>: Declare.
6512         <abbrev_obstack>: Now an auto_obstack.
6513         (abbrev_table_up): New typedef.
6514         (init_cu_die_reader): Add abbrev_table parameter.
6515         (read_cutu_die_from_dwo): Remove abbrev_table_provided parameter.
6516         Add result_dwo_abbrev_table.
6517         (init_tu_and_read_dwo_dies, init_cutu_and_read_dies)
6518         (init_cutu_and_read_dies_no_follow, build_type_psymtabs_1):
6519         Update.
6520         (peek_die_abbrev): Take die_reader_specs, not dwarf_cu as
6521         parameter.
6522         (skip_children): Update.
6523         (abbrev_table::alloc_abbrev): Rename from
6524         abbrev_table_alloc_abbrev.
6525         (abbrev_table::add_abbrev): Rename from abbrev_table_add_abbrev.
6526         (abbrev_table::lookup_abbrev): Rename from
6527         abbrev_table_lookup_abbrev.
6528         (abbrev_table_read_table): Return abbrev_table_up.
6529         (abbrev_table_free, abbrev_table_free_cleanup)
6530         (dwarf2_read_abbrevs, dwarf2_free_abbrev_table): Remove.
6531         (load_partial_dies): Update.
6532
6533 2018-01-17  Tom Tromey  <tom@tromey.com>
6534
6535         * dwarf2read.c (dwarf2_compute_name): Update comment.
6536         (read_func_scope, read_variable): Update.
6537         (new_symbol): Remove.
6538         (new_symbol_full): Rename to new_symbol.
6539
6540 2018-01-17  Mike Gulick  <mgulick@mathworks.com>
6541
6542         PR gdb/16577
6543         * gdb_bfd.c (gdb_bfd_map_section): If unable to read object file, issue
6544         a warning instead of throwing an error, set section size to 0 and return
6545         NULL.
6546         * gdb_bfd.h (gdb_bfd_map_section): Update description.
6547
6548 2018-01-17  Simon Marchi  <simon.marchi@ericsson.com>
6549
6550         * nat/linux-ptrace.h (linux_ptrace_attach_fail_reason): Return
6551         std::string.
6552         (linux_ptrace_attach_fail_reason_string): Likewise.
6553         * nat/linux-ptrace.c (linux_ptrace_attach_fail_reason):
6554         Likewise.
6555         (linux_ptrace_attach_fail_reason_string): Likewise.
6556         * linux-nat.c (attach_proc_task_lwp_callback): Adjust.
6557
6558 2018-01-17  Simon Marchi  <simon.marchi@ericsson.com>
6559
6560         * linux-nat.c (linux_nat_attach): Remove xstrdup.
6561
6562 2018-01-17  Eldar Abusalimov  <eldar.abusalimov@jetbrains.com>
6563
6564         PR gdb/21559
6565         * configure.ac: Include <sys/types.h> prior to <sys/user.h> when
6566         checking for fs_base/gs_base fields in struct user_regs_struct.
6567         * configure: Regenerate.
6568
6569 2018-01-17  Yao Qi  <yao.qi@linaro.org>
6570
6571         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): New
6572         function.
6573         (aarch64_linux_init_abi): Install it to gdbarch hook
6574         gcc_target_options.
6575
6576 2018-01-15  Pedro Alves  <palves@redhat.com>
6577
6578         * common/signals-state-save-restore.c
6579         (save_original_signals_state): Fix typos.
6580
6581 2017-01-12  Tom Tromey  <tom@tromey.com>
6582             Sergio Durigan Junior  <sergiodj@redhat.com>
6583
6584         * Makefile.in (install-only): Install gdb-add-index.
6585
6586 2018-01-12  John Baldwin  <jhb@FreeBSD.org>
6587
6588         * fbsd-tdep.c (KVE_PROTECTION): Correct value.
6589
6590 2018-01-12  Andreas Arnez  <arnez@linux.vnet.ibm.com>
6591
6592         * infrun.c (keep_going_pass_signal): Clear step-over info when
6593         insert_breakpoints fails.
6594
6595 2018-01-11  Pedro Alves  <palves@redhat.com>
6596
6597         PR gdb/22583
6598         * infrun.c (resume): Rename to ...
6599         (resume_1): ... this.
6600         (resume): Reimplement as wrapper around resume_1.
6601
6602 2018-01-11  Pedro Alves  <palves@redhat.com>
6603
6604         PR remote/22597
6605         * remote.c (remote_parse_stop_reply): Default to the last-set
6606         general thread instead of to 'magic_null_ptid'.
6607
6608 2018-01-10  Pedro Alves  <palves@redhat.com>
6609
6610         * language.h (language_get_symbol_name_matcher): Rename ...
6611         (get_symbol_name_matcher): ... this.
6612         * language.c (language_get_symbol_name_matcher): Ditto.
6613         * dictionary.c, linespec.c, minsyms.c, psymtab.c, symtab.c: All
6614         callers adjusted.
6615
6616 2018-01-10  Pedro Alves  <palves@redhat.com>
6617
6618         PR gdb/22670
6619         * dwarf2read.c
6620         (gdb_index_symbol_name_matcher::gdb_index_symbol_name_matcher):
6621         Adjust to use language_get_symbol_name_matcher instead of
6622         language_defn::la_get_symbol_name_matcher.
6623         * language.c (language_get_symbol_name_matcher): If in Ada mode
6624         and the lookup name is a verbatim match, return Ada's matcher.
6625         * language.h (language_get_symbol_name_matcher): Adjust comment.
6626         (ada_lookup_name_info::verbatim_p):: New method.
6627
6628 2018-01-10  Pedro Alves  <palves@redhat.com>
6629
6630         PR gdb/22670
6631         * ada-lang.c (ada_collect_symbol_completion_matches): If the
6632         minsym's language is language_auto or language_cplus, pass down
6633         language_ada instead.
6634         * symtab.c (compare_symbol_name): Don't frob symbol language here.
6635
6636 2018-01-10  Pedro Alves  <palves@redhat.com>
6637
6638         PR gdb/22670
6639         * minsyms.c (linkage_name_str): New function.
6640         (iterate_over_minimal_symbols): Use it.
6641
6642 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
6643
6644         * NEWS: Document that 'info proc' now works on FreeBSD.
6645
6646 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
6647
6648         * configure.ac: Check for kinfo_getfile in libutil.
6649         * configure: Regenerate.
6650         * config.in: Regenerate.
6651         * fbsd-nat.c: Include "fbsd-tdep.h".
6652         (fbsd_fetch_cmdline): New.
6653         (fbsd_fetch_kinfo_proc): Move earlier and change to return a bool
6654         rather than calling error.
6655         (fbsd_info_proc): New.
6656         (fbsd_thread_name): Report error if fbsd_fetch_kinfo_proc fails.
6657         (fbsd_wait): Report warning if fbsd_fetch_kinfo_proc fails.
6658         (fbsd_nat_add_target): Set "to_info_proc" to "fbsd_info_proc".
6659
6660 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
6661
6662         * fbsd-nat.c (struct free_deleter): Remove.
6663         (fbsd_find_memory_regions): Use gdb::unique_xmalloc_ptr<>.
6664
6665 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
6666
6667         * fbsd-nat.c (fbsd_pid_to_exec_file) [KERN_PROC_PATHNAME]: Return
6668         NULL for an empty pathname.
6669
6670 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
6671
6672         * fbsd-tdep.c (KVE_STRUCTSIZE, KVE_START, KVE_END, KVE_OFFSET)
6673         (KVE_FLAGS, KVE_PROTECTION, KVE_PATH, KINFO_VME_PROT_READ)
6674         (KINFO_VME_PROT_WRITE, KINFO_VME_PROT_EXEC, KINFO_VME_FLAG_COW)
6675         (KINFO_VME_FLAG_NEEDS_COPY, KINFO_VME_FLAG_NOCOREDUMP)
6676         (KINFO_VME_FLAG_SUPER, KINFO_VME_FLAG_GROWS_UP)
6677         (KINFO_VME_FLAG_GROWS_DOWN, KF_STRUCTSIZE, KF_TYPE, KF_FD)
6678         (KF_PATH, KINFO_FILE_TYPE_VNODE, KINFO_FILE_FD_TYPE_CWD)
6679         (KINFO_FILE_FD_TYPE_TEXT, SIG_WORDS, struct kinfo_proc_layout)
6680         (kinfo_proc_layout_32, kinfo_proc_layout_i386)
6681         (kinfo_proc_layout_64, fbsd_vm_map_entry_flags)
6682         (fbsd_core_info_proc_mappings, fbsd_core_vnode_path)
6683         (fbsd_core_fetch_timeval, fbsd_print_sigset)
6684         (fbsd_core_info_proc_status, fbsd_core_info_proc): New.
6685         (fbsd_init_abi):  Install gdbarch "core_info_proc" method.
6686         * fbsd-tdep.h (fbsd_vm_map_entry_flags): New.
6687
6688 2018-01-08  Samuel Thibault  <samuel.thibault@ens-lyon.org>
6689
6690         * gdb/gnu-nat.c: Include <elf.h> and <link.h>.
6691         (gnu_xfer_auxv): New function.
6692         (gnu_xfer_partial): Call gnu_xfer_auxv when `object' is
6693         TARGET_OBJECT_AUXV.
6694
6695 2018-01-08  Yao Qi  <yao.qi@linaro.org>
6696             Simon Marchi  <simon.marchi@ericsson.com>
6697
6698         * Makefile.in (COMMON_SFILES): Remove selftest-arch.c and
6699         common/selftest.c.
6700         (COMMON_OBS): Remove selftest.o.
6701         * configure.ac: Append selftest-arch.c and common/selftest.c to
6702         CONFIG_SRCS.  Append selftest-arch.o and selftest.o to COMMON_OBS.
6703         * configure: Re-generated.
6704         * maint.c (maintenance_selftest): Wrap selftests::run_tests with
6705         GDB_SELF_TEST.
6706         (maintenance_info_selftests): Likewise.
6707
6708 2018-01-08  Xavier Roirand  <roirand@adacore.com>
6709
6710         * ada-valprint.c (val_print_packed_array_elements): Use
6711         proper number of elements when printing an array indexed
6712         by an enumeration type.
6713
6714 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
6715
6716         * dwarf2read.c (struct dwarf2_cu) <dwarf2_per_objfile>: Remove.
6717         (dw2_get_file_names_reader): Adjust.
6718         (lookup_dwo_signatured_type): Adjust.
6719         (lookup_dwp_signatured_type): Adjust.
6720         (lookup_signatured_type): Adjust.
6721         (create_type_unit_group): Adjust.
6722         (get_type_unit_group): Adjust.
6723         (process_psymtab_comp_unit_reader): Adjust.
6724         (build_type_psymtabs_reader): Adjust.
6725         (scan_partial_symbols): Adjust.
6726         (add_partial_symbol): Adjust.
6727         (add_partial_subprogram): Adjust.
6728         (peek_die_abbrev): Adjust.
6729         (fixup_go_packaging): Adjust.
6730         (process_imported_unit_die): Adjust.
6731         (dwarf2_compute_name): Adjust.
6732         (dwarf2_physname): Adjust.
6733         (read_import_statement): Adjust.
6734         (handle_DW_AT_stmt_list): Adjust.
6735         (read_file_scope): Adjust.
6736         (read_func_scope): Adjust.
6737         (read_lexical_block_scope): Adjust.
6738         (read_call_site_scope): Adjust.
6739         (read_variable): Adjust.
6740         (dwarf2_rnglists_process): Adjust.
6741         (dwarf2_ranges_process): Adjust.
6742         (dwarf2_ranges_read): Adjust.
6743         (dwarf2_get_pc_bounds): Adjust.
6744         (dwarf2_record_block_ranges): Adjust.
6745         (dwarf2_add_field): Adjust.
6746         (dwarf2_add_member_fn): Adjust.
6747         (read_structure_type): Adjust.
6748         (process_structure_scope): Adjust.
6749         (read_enumeration_type): Adjust.
6750         (read_array_type): Adjust.
6751         (mark_common_block_symbol_computed): Adjust.
6752         (read_common_block): Adjust.
6753         (read_namespace_type): Adjust.
6754         (read_namespace): Adjust.
6755         (read_module_type): Adjust.
6756         (read_tag_pointer_type): Adjust.
6757         (read_tag_ptr_to_member_type): Adjust.
6758         (read_tag_string_type): Adjust.
6759         (read_subroutine_type): Adjust.
6760         (read_typedef): Adjust.
6761         (read_base_type): Adjust.
6762         (attr_to_dynamic_prop): Adjust.
6763         (read_subrange_type): Adjust.
6764         (read_unspecified_type): Adjust.
6765         (dwarf2_read_abbrevs): Adjust.
6766         (load_partial_dies): Adjust.
6767         (read_partial_die): Adjust.
6768         (find_partial_die): Adjust.
6769         (guess_partial_die_structure_name): Adjust.
6770         (fixup_partial_die): Adjust.
6771         (read_attribute_value): Adjust.
6772         (read_addr_index): Adjust.
6773         (read_addr_index_from_leb128): Adjust.
6774         (read_str_index): Adjust.
6775         (dwarf2_string_attr): Adjust.
6776         (get_debug_line_section): Adjust.
6777         (dwarf_decode_line_header): Adjust.
6778         (lnp_state_machine::check_line_address): Adjust.
6779         (dwarf_decode_lines_1): Adjust.
6780         (dwarf_decode_lines): Adjust.
6781         (dwarf2_start_symtab): Adjust.
6782         (var_decode_location): Adjust.
6783         (new_symbol_full): Adjust.
6784         (dwarf2_const_value_data): Adjust.
6785         (dwarf2_const_value_attr): Adjust.
6786         (dwarf2_const_value): Adjust.
6787         (die_type): Adjust.
6788         (die_containing_type): Adjust.
6789         (build_error_marker_type): Adjust.
6790         (lookup_die_type): Adjust.
6791         (guess_full_die_structure_name): Adjust.
6792         (anonymous_struct_prefix): Adjust.
6793         (determine_prefix): Adjust.
6794         (dwarf2_name): Adjust.
6795         (follow_die_ref_or_sig): Adjust.
6796         (follow_die_offset): Adjust.
6797         (follow_die_ref): Adjust.
6798         (follow_die_sig_1): Adjust.
6799         (follow_die_sig): Adjust.
6800         (get_signatured_type): Adjust.
6801         (get_DW_AT_signature_type): Adjust.
6802         (decode_locdesc): Adjust.
6803         (dwarf_decode_macros): Adjust.
6804         (cu_debug_loc_section): Adjust.
6805         (fill_in_loclist_baton): Adjust.
6806         (dwarf2_symbol_mark_computed): Adjust.
6807         (init_one_comp_unit): Don't assign
6808         dwarf2_cu::dwarf2_per_objfile.
6809         (set_die_type): Adjust.
6810
6811 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
6812
6813         * dwarf2read.c (struct mapped_debug_names): Add constructor.
6814         <dwarf2_per_objfile>: New field.
6815         (dwarf2_per_objfile): Remove global.
6816         (get_dwarf2_per_objfile): New function.
6817         (set_dwarf2_per_objfile): New function.
6818         (dwarf2_build_psymtabs_hard): Change objfile parameter to
6819         dwarf2_per_objfile.
6820         (abbrev_table_read_table): Add dwarf2_per_objfile parameter.
6821         (read_abbrev_offset): Likewise.
6822         (read_indirect_string): Likewise.
6823         (read_indirect_line_string): Likewise.
6824         (read_indirect_string_at_offset): Likewise.
6825         (read_indirect_string_from_dwz): Likewise.
6826         (dwarf2_find_containing_comp_unit): Change objfile parameter to
6827         dwarf2_per_objfile.
6828         (age_cached_comp_units): Add dwarf2_per_objfile parameter.
6829         (create_all_comp_units): Change objfile parameter to
6830         dwarf2_per_objfile.
6831         (create_all_type_units): Likewise.
6832         (process_queue): Add dwarf2_per_objfile parameter.
6833         (read_and_check_comp_unit_head): Likewise.
6834         (lookup_dwo_unit_in_dwp): Likewise.
6835         (get_dwp_file): Likewise.
6836         (process_cu_includes): Likewise.
6837         (struct free_dwo_file_cleanup_data): New struct.
6838         (dwarf2_has_info): Use get_dwarf2_per_objfile and
6839         set_dwarf2_per_objfile.
6840         (dwarf2_get_dwz_file): Add dwarf2_per_objfile parameter.
6841         (dw2_do_instantiate_symtab): Get dwarf2_per_objfile from
6842         context, adjust calls.
6843         (dw2_instantiate_symtab): Likewise.
6844         (dw2_get_cutu): Add dwarf2_per_objfile parameter.
6845         (dw2_get_cu): Likewise.
6846         (create_cu_from_index_list): Change objfile parameter to
6847         dwarf2_per_objfile.
6848         (create_cus_from_index_list): Get dwarf2_per_objfile from
6849         context, adjust calls.
6850         (create_cus_from_index): Likewise.
6851         (create_signatured_type_table_from_index): Change objfile
6852         parameter to dwarf2_per_objfile.
6853         (create_signatured_type_table_from_debug_names): Change objfile
6854         parameter to dwarf2_per_objfile.
6855         (create_addrmap_from_index): Likewise.
6856         (create_addrmap_from_aranges): Likewise.
6857         (dwarf2_read_index): Use get_dwarf2_per_objfile, adjust calls.
6858         (dw2_setup): Remove.
6859         (dw2_get_file_names_reader): Get dwarf2_per_objfile from
6860         context.
6861         (dw2_find_last_source_symtab): Get dwarf2_per_objfile using
6862         get_dwarf2_per_objfile.
6863         (dw2_forget_cached_source_info): Likewise.
6864         (dw2_map_symtabs_matching_filename): Likewise.
6865         (struct dw2_symtab_iterator) <index>: Remove.
6866         <dwarf2_per_objfile>: New field.
6867         (dw2_symtab_iter_init): Replace index parameter with
6868         dwarf2_per_objfile.
6869         (dw2_symtab_iter_next): Use dwarf2_per_objfile from iter.
6870         (dw2_lookup_symbol): Use get_dwarf2_per_objfile and adjust.
6871         (dw2_print_stats): Likewise.
6872         (dw2_dump): Likewise.
6873         (dw2_expand_symtabs_for_function): Likewise.
6874         (dw2_expand_all_symtabs): Likewise.
6875         (dw2_expand_symtabs_with_fullname): Likewise.
6876         (dw2_expand_marked_cus): Replace index and objfile parameters
6877         with dwarf2_per_objfile.
6878         (dw_expand_symtabs_matching_file_matcher): Add
6879         dwarf2_per_objfile parameter and adjust calls.
6880         (dw2_expand_symtabs_matching): Use get_dwarf2_per_objfile and
6881         adjust calls.
6882         (dw2_find_pc_sect_compunit_symtab): Don't call dw2_setup.
6883         (dw2_map_symbol_filenames): Use get_dwarf2_per_objfile and
6884         adjust calls.
6885         (create_cus_from_debug_names_list): Replace objfile parameter
6886         with dwarf2_per_objfile and adjust calls.
6887         (create_cus_from_debug_names): Likewise.
6888         (dwarf2_read_debug_names): Likewise.
6889         (mapped_debug_names::namei_to_name): Adjust call.
6890         (dw2_debug_names_iterator::next): Likewise.
6891         (dw2_debug_names_iterator::find_vec_in_debug_names): Likewise.
6892         (dw2_debug_names_lookup_symbol): Use get_dwarf2_per_objfile.
6893         (dw2_debug_names_dump): Likewise.
6894         (dw2_debug_names_expand_symtabs_for_function): Likewise.
6895         (dw2_debug_names_expand_symtabs_matching): Likewise.
6896         (dwarf2_initialize_objfile): Likewise.
6897         (dwarf2_build_psymtabs): Likewise.
6898         (get_abbrev_section_for_cu): Get dwarf2_per_objfile from
6899         this_cu.
6900         (error_check_comp_unit_head): Add dwarf2_per_objfile parameter.
6901         (read_and_check_comp_unit_head): Likewise.
6902         (read_abbrev_offset): Likewise.
6903         (create_debug_type_hash_table): Likewise.
6904         (create_debug_types_hash_table): Likewise.
6905         (create_all_type_units): Replace objfile parameter with
6906         dwarf2_per_objfile.
6907         (add_type_unit): Add dwarf2_per_objfile parameter.
6908         (fill_in_sig_entry_from_dwo_entry): Replace objfile parameter
6909         with dwarf2_per_objfile.
6910         (lookup_dwo_signatured_type): Get dwarf2_per_objfile from cu.
6911         (lookup_dwp_signatured_type): Likewise.
6912         (lookup_signatured_type): Likewise.
6913         (read_cutu_die_from_dwo): Likewise.
6914         (init_tu_and_read_dwo_dies): Likewise.
6915         (init_cutu_and_read_dies): Likewise.
6916         (init_cutu_and_read_dies_no_follow): Likewise.
6917         (allocate_type_unit_groups_table): Add objfile parameter.
6918         (create_type_unit_group): Use dwarf2_per_objfile from cu.
6919         (get_type_unit_group): Likewise.
6920         (process_psymtab_comp_unit): Update call.
6921         (build_type_psymtabs_reader): Use dwarf2_per_objfile from cu.
6922         (build_type_psymtabs_1): Add dwarf2_per_objfile parameter.
6923         (print_tu_stats): Likewise.
6924         (build_type_psymtab_dependencies): Use dwarf2_per_objfile passed
6925         in void* parameter.
6926         (build_type_psymtabs): Change objfile parameter to
6927         dwarf2_per_objfile.
6928         (process_skeletonless_type_unit): Use dwarf2_per_objfile
6929         passed in void* parameter.
6930         (process_skeletonless_type_units): Change objfile parameter to
6931         dwarf2_per_objfile.
6932         (set_partial_user): Likewise.
6933         (dwarf2_build_psymtabs_hard): Likewise.
6934         (read_comp_units_from_section): Likewise.
6935         (create_all_comp_units): Likewise.
6936         (scan_partial_symbols): Update calls.
6937         (add_partial_symbol): Likewise.
6938         (dwarf2_read_symtab): Use get_dwarf2_per_objfile.
6939         (maybe_queue_comp_unit): Use dwarf2_read_symtab from cu.
6940         (process_queue): Add dwarf2_per_objfile parameter.
6941         (get_compunit_symtab): Use dwarf2_per_objfile from cu.
6942         (compute_compunit_symtab_includes): Likewise.
6943         (process_cu_includes): Add dwarf2_per_objfile parameter.
6944         (process_full_comp_unit): Use dwarf2_per_objfile from cu.
6945         (process_full_type_unit): Likewise.
6946         (process_imported_unit_die): Update call.
6947         (handle_DW_AT_stmt_list): Use dwarf2_per_objfile from cu.
6948         (read_file_scope): Likewise.
6949         (allocate_dwo_file_hash_table): Add objfile parameter.
6950         (lookup_dwo_file_slot): Add dwarf2_per_objfile parameter.
6951         (create_cus_hash_table): Likewise.
6952         (create_dwp_hash_table): Likewise.
6953         (create_dwo_unit_in_dwp_v1): Likewise.
6954         (create_dwp_v2_section): Likewise.
6955         (create_dwo_unit_in_dwp_v2): Likewise.
6956         (lookup_dwo_unit_in_dwp): Likewise.
6957         (try_open_dwop_file): Likewise.
6958         (open_dwo_file): Likewise. Use dwarf2_per_objfile from cu.
6959         (open_and_init_dwo_file): Use dwarf2_per_objfile from cu, update
6960         cleanup to include a reference to dwarf2_per_objfile.
6961         (open_dwp_file): Add dwarf2_per_objfile parameter.
6962         (open_and_init_dwp_file): Likewise.
6963         (get_dwp_file): Likewise.
6964         (lookup_dwo_cutu): Use dwarf2_per_objfile from cu.
6965         (queue_and_load_all_dwo_tus): Update call.
6966         (free_dwo_file_cleanup): Use dwarf2_per_objfile from cleanup
6967         data.
6968         (dwarf2_rnglists_process): Use dwarf2_per_objfile from cu.
6969         (dwarf2_ranges_process): Likewise.
6970         (dwarf2_get_pc_bounds): Likewise.
6971         (mark_common_block_symbol_computed): Likewise.
6972         (abbrev_table_read_table): Add dwarf2_per_objfile parameter.
6973         (dwarf2_read_abbrevs): Update call.
6974         (read_partial_die): Use dwarf2_per_objfile from cu.
6975         (find_partial_die): Likewise.
6976         (fixup_partial_die): Likewise.
6977         (read_attribute_value): Likewise.
6978         (read_indirect_string_at_offset_from): Add objfile parameter.
6979         (read_indirect_string_at_offset): Add dwarf2_per_objfile
6980         parameter.
6981         (read_indirect_string_from_dwz): Add objfile parameter.
6982         (read_indirect_string): Add objfile parameter.
6983         (read_addr_index_1): Add dwarf2_per_objfile parameter.
6984         (read_addr_index): Use dwarf2_per_objfile from cu.
6985         (dwarf2_read_addr_index): Use dwarf2_per_objfile from cu, don't
6986         call dw2_setup.
6987         (read_str_index): Use dwarf2_per_objfile from cu.
6988         (get_debug_line_section): Likewise.
6989         (read_formatted_entries): Add dwarf2_per_objfile parameter.
6990         (dwarf_decode_line_header): Use dwarf2_per_objfile from cu.
6991         (new_symbol_full): Use dwarf2_per_objfile from cu.
6992         (build_error_marker_type): Likewise.
6993         (lookup_die_type): Likewise.
6994         (determine_prefix): Likewise.
6995         (follow_die_offset): Likewise.
6996         (dwarf2_fetch_die_loc_sect_off): Use get_dwarf2_per_objfile.
6997         (dwarf2_fetch_constant_bytes): Don't call dw2_setup.
6998         (dwarf2_fetch_die_type_sect_off): Likewise.
6999         (dwarf2_get_die_type): Likewise.
7000         (follow_die_sig_1): Use dwarf2_per_objfile from cu.
7001         (get_signatured_type): Likewise.
7002         (get_DW_AT_signature_type): Likewise.
7003         (dwarf_decode_macro_bytes): Add dwarf2_per_objfile parameter.
7004         (dwarf_decode_macros): Use dwarf2_per_objfile from cu.
7005         (cu_debug_loc_section): Likewise.
7006         (fill_in_loclist_baton): Likewise.
7007         (dwarf2_symbol_mark_computed): Likewise.
7008         (dwarf2_find_containing_comp_unit): Change objfile parameter to
7009         dwarf2_per_objfile.
7010         (free_cached_comp_units): Use dwarf2_per_objfile passed in void*
7011         parameter.
7012         (age_cached_comp_units): Add dwarf2_per_objfile parameter.
7013         (free_one_cached_comp_unit): Use dwarf2_per_objfile from cu.
7014         (dwarf2_free_objfile): Use get_dwarf2_per_objfile.
7015         (set_die_type): Use dwarf2_free_objfile from cu.
7016         (get_die_type_at_offset): Likewise.
7017         (dwarf2_per_objfile_free): Don't assign global variable.
7018         (debug_names) <constructor>: Add dwarf2_per_objfile
7019         parameter, update m_debugstrlookup construction.
7020         (debug_names::debug_str_lookup): Add dwarf2_per_objfile
7021         parameter.
7022         <m_dwarf2_per_objfile>: New field.
7023         <lookup>: Use m_dwarf2_per_objfile.
7024         (check_dwarf64_offsets): Add dwarf2_per_objfile parameter.
7025         (psyms_seen_size): Likewise.
7026         (write_gdbindex): Replace objfile parameter with
7027         dwarf2_per_objfile.
7028         (write_debug_names): Likewise.
7029         (write_psymtabs_to_index): Likewise.
7030         (save_gdb_index_command): Use get_dwarf2_per_objfile, update
7031         calls.
7032
7033 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
7034
7035         * dwarf2read.c (struct dwarf2_cu) <objfile>: Remove.
7036         <dwarf2_per_objfile>: New field.
7037         (struct dwarf2_per_cu_data) <objfile>: Remove.
7038         <dwarf2_per_objfile>: New field.
7039         (create_cu_from_index_list): Assign dwarf2_per_objfile instead
7040         of objfile.
7041         (create_signatured_type_table_from_index): Likewise.
7042         (create_debug_type_hash_table): Likewise.
7043         (fill_in_sig_entry_from_dwo_entry): Likewise.
7044         (lookup_dwo_unit): Access objfile through dwarf2_per_objfile.
7045         (create_type_unit_group): Assign dwarf2_per_objfile instead of
7046         objfile.
7047         (create_partial_symtab): Access objfile through
7048         dwarf2_per_objfile.
7049         (process_psymtab_comp_unit_reader): Likewise.
7050         (read_comp_units_from_section): Likewise.
7051         (scan_partial_symbols): Likewise.
7052         (add_partial_symbol): Likewise.
7053         (add_partial_subprogram): Likewise.
7054         (peek_die_abbrev): Likewise.
7055         (fixup_go_packaging): Likewise.
7056         (process_full_comp_unit): Likewise.
7057         (process_full_type_unit): Likewise.
7058         (process_imported_unit_die): Likewise.
7059         (dwarf2_compute_name): Likewise.
7060         (dwarf2_physname): Likewise.
7061         (read_import_statement): Likewise.
7062         (create_cus_hash_table): Assign dwarf2_physname instead of
7063         objfile.
7064         (read_func_scope): Access objfile through dwarf2_per_objfile.
7065         (read_lexical_block_scope): Likewise.
7066         (read_call_site_scope): Likewise.
7067         (read_variable): Likewise.
7068         (dwarf2_rnglists_process): Likewise.
7069         (dwarf2_ranges_process): Likewise.
7070         (dwarf2_ranges_read): Likewise.
7071         (dwarf2_record_block_ranges): Likewise.
7072         (dwarf2_add_field): Likewise.
7073         (dwarf2_add_member_fn): Likewise.
7074         (read_structure_type): Likewise.
7075         (process_structure_scope): Likewise.
7076         (read_enumeration_type): Likewise.
7077         (read_array_type): Likewise.
7078         (read_common_block): Likewise.
7079         (read_namespace_type): Likewise.
7080         (read_namespace): Likewise.
7081         (read_module_type): Likewise.
7082         (read_tag_pointer_type): Likewise.
7083         (read_tag_ptr_to_member_type): Likewise.
7084         (read_tag_string_type): Likewise.
7085         (read_subroutine_type): Likewise.
7086         (read_typedef): Likewise.
7087         (read_base_type): Likewise.
7088         (attr_to_dynamic_prop): Likewise.
7089         (read_subrange_type): Likewise.
7090         (read_unspecified_type): Likewise.
7091         (load_partial_dies): Likewise.
7092         (read_partial_die): Likewise.
7093         (find_partial_die): Likewise.
7094         (guess_partial_die_structure_name): Likewise.
7095         (fixup_partial_die): Likewise.
7096         (read_attribute_value): Likewise.
7097         (read_addr_index_from_leb128): Likewise.
7098         (dwarf2_read_addr_index): Likewise.
7099         (dwarf2_string_attr): Likewise.
7100         (lnp_state_machine::check_line_address): Likewise.
7101         (dwarf_decode_lines_1): Likewise.
7102         (dwarf_decode_lines): Likewise.
7103         (dwarf2_start_symtab): Likewise.
7104         (var_decode_location): Likewise.
7105         (new_symbol_full): Likewise.
7106         (dwarf2_const_value_data): Likewise.
7107         (dwarf2_const_value_attr): Likewise.
7108         (dwarf2_const_value): Likewise.
7109         (die_type): Likewise.
7110         (die_containing_type): Likewise.
7111         (lookup_die_type): Likewise.
7112         (guess_full_die_structure_name): Likewise.
7113         (anonymous_struct_prefix): Likewise.
7114         (dwarf2_name): Likewise.
7115         (follow_die_ref_or_sig): Likewise.
7116         (follow_die_offset): Likewise.
7117         (follow_die_ref): Likewise.
7118         (dwarf2_fetch_die_loc_sect_off): Likewise.
7119         (dwarf2_fetch_constant_bytes): Likewise.
7120         (dwarf2_fetch_die_type_sect_off): Likewise.
7121         (dwarf2_get_die_type): Likewise.
7122         (follow_die_sig): Likewise.
7123         (decode_locdesc): Likewise.
7124         (dwarf2_per_cu_objfile): Likewise.
7125         (dwarf2_per_cu_text_offset): Likewise.
7126         (init_one_comp_unit): Assign dwarf2_per_objfile instead of
7127         objfile.
7128         (set_die_type): Access objfile through
7129         dwarf2_per_objfile.
7130
7131 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
7132
7133         * valprint.c (converted_character_d): Remove typedef.
7134         (DEF_VEC_O (converted_character_d)): Remove.
7135         (count_next_character): Use std::vector.
7136         (print_converted_chars_to_obstack): Likewise.
7137         (generic_printstr): Likewise.
7138
7139 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
7140
7141         * xml-support.h (struct gdb_xml_value): Add constructor.
7142         <value>: Change type to unique_xmalloc_ptr.
7143         (gdb_xml_value_s): Remove typedef.
7144         (DEF_VEC_O (gdb_xml_value_s)): Remove.
7145         (gdb_xml_element_start_handler): Change parameter type to
7146         std::vector.
7147         (xml_find_attribute): Likewise.
7148         * xml-support.c (xml_find_attribute): Change parameter type to
7149         std::vector and adjust.
7150         (gdb_xml_values_cleanup): Remove.
7151         (gdb_xml_parser::start_element): Adjust to std::vector.
7152         (xinclude_start_include): Change paraeter type to std::vector
7153         and adjust.
7154         * btrace.c (check_xml_btrace_version): Likewise.
7155         (parse_xml_btrace_block): Likewise.
7156         (parse_xml_btrace_pt_config_cpu): Likewise.
7157         (parse_xml_btrace_pt): Likewise.
7158         (parse_xml_btrace_conf_bts): Likewise.
7159         (parse_xml_btrace_conf_pt): Likewise.
7160         * memory-map.c (memory_map_start_memory): Likewise.
7161         (memory_map_start_property): Likewise.
7162         * osdata.c (osdata_start_osdata): Likewise.
7163         (osdata_start_item): Likewise.
7164         (osdata_start_column): Likewise.
7165         * remote.c (start_thread): Likewise.
7166         * solib-aix.c (library_list_start_library): Likewise.
7167         (library_list_start_list): Likewise.
7168         * solib-svr4.c (library_list_start_library): Likewise.
7169         (svr4_library_list_start_list): Likewise.
7170         * solib-target.c (library_list_start_segment): Likewise.
7171         (library_list_start_section): Likewise.
7172         (library_list_start_library): Likewise.
7173         (library_list_start_list): Likewise.
7174         * tracepoint.c (traceframe_info_start_memory): Likewise.
7175         (traceframe_info_start_tvar): Likewise.
7176         * xml-syscall.c (syscall_start_syscall): Likewise.
7177         * xml-tdesc.c (tdesc_start_target): Likewise.
7178         (tdesc_start_feature): Likewise.
7179         (tdesc_start_reg): Likewise.
7180         (tdesc_start_union): Likewise.
7181         (tdesc_start_struct): Likewise.
7182         (tdesc_start_flags): Likewise.
7183         (tdesc_start_enum): Likewise.
7184         (tdesc_start_field): Likewise.
7185         (tdesc_start_enum_value): Likewise.
7186         (tdesc_start_vector): Likewise.
7187
7188 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
7189
7190         * extension.h (struct xmethod_worker) <clone>: Remove.
7191         * python/py-xmethods.c (struct python_xmethod_worker) <clone>:
7192         Remove.
7193         (python_xmethod_worker::clone): Remove.
7194         * valops.c (find_overload_match): Use std::move instead of
7195         clone.
7196
7197 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
7198
7199         * extension-priv.h (enum ext_lang_rc): Remove, move to extension.h.
7200         (struct extension_language_ops) <clone_xmethod_worker_data>: Remove.
7201         <free_xmethod_worker_data>: Remove.
7202         <get_matching_xmethod_workers>: Chance VEC to std::vector.
7203         <get_xmethod_arg_types>: Remove.
7204         <get_xmethod_result_type>: Remove.
7205         <invoke_xmethod>: Remove.
7206         * extension.c (new_xmethod_worker): Remove.
7207         (clone_xmethod_worker): Remove.
7208         (get_matching_xmethod_workers): Return void, pass std::vector by
7209         pointer.
7210         (get_xmethod_arg_types): Rename to...
7211         (xmethod_worker::get_arg_types): ... this, and adjust.
7212         (get_xmethod_result_type): Rename to...
7213         (xmethod_worker::get_result_type): ... this, and adjust.
7214         (invoke_xmethod): Remove.
7215         (free_xmethod_worker): Remove.
7216         (free_xmethod_worker_vec): Remove.
7217         * extension.h (enum ext_lang_rc): Move here from
7218         extension-priv.h.
7219         (struct xmethod_worker): Add constructor and destructor.
7220         <data>: Remove.
7221         <value>: Remove.
7222         <invoke, clone, do_get_result_type, do_get_arg_types>: New
7223         virtual pure methods.
7224         <get_arg_types, get_result_type>: New methods.
7225         (xmethod_worker_ptr): Remove typedef.
7226         (DEF_VEC_P (xmethod_worker_ptr)): Remove.
7227         (xmethod_worker_vec): Remove typedef.
7228         (xmethod_worker_up): New typedef.
7229         (invoke_xmethod): Remove.
7230         (clone_xmethod_worker): Remove.
7231         (free_xmethod_worker): Remove.
7232         (free_xmethod_worker_vec): Remove.
7233         (get_xmethod_arg_types): Remove.
7234         (get_xmethod_result_type): Remove.
7235         * valops.c (find_method_list): Use std::vector, don't use
7236         intermediate vector.
7237         (value_find_oload_method_list): Use std::vector.
7238         (find_overload_match): Use std::vector.
7239         (find_oload_champ): Use std::vector.
7240         * value.c (value_free): Use operator delete.
7241         (value_of_xmethod): Rename to...
7242         (value_from_xmethod): ... this.  Don't assign
7243         xmethod_worker::value, take rvalue-reference.
7244         (result_type_of_xmethod): Adjust.
7245         (call_xmethod): Adjust.
7246         * value.h: Include extension.h.
7247         (struct xmethod_worker): Don't forward-declare.
7248         (value_of_xmethod): Rename to...
7249         (value_from_xmethod): ... this, take rvalue-reference.
7250         * python/py-xmethods.c (struct gdbpy_worker_data): Rename to...
7251         (struct python_xmethod_worker): ... this, add constructor and
7252         destructor.
7253         <invoke, clone, do_get_arg_types, do_get_result_type>: Implement.
7254         (gdbpy_free_xmethod_worker_data): Rename to...
7255         (python_xmethod_worker::~python_xmethod_worker): ... this and
7256         adjust.
7257         (gdbpy_clone_xmethod_worker_data): Rename to...
7258         (python_xmethod_worker::clone): ... this and adjust.
7259         (gdbpy_get_matching_xmethod_workers): Use std::vector, don't use
7260         temporary vector.
7261         (gdbpy_get_xmethod_arg_types): Rename to...
7262         (python_xmethod_worker::do_get_arg_types): ... this and adjust.
7263         (gdbpy_get_xmethod_result_type): Rename to...
7264         (python_xmethod_worker::do_get_result_type): ... this and
7265         adjust.
7266         (gdbpy_invoke_xmethod): Rename to...
7267         (python_xmethod_worker::invoke): ... this and adjust.
7268         (new_python_xmethod_worker): Rename to...
7269         (python_xmethod_worker::python_xmethod_worker): ... this and
7270         adjust.
7271         * python/python-internal.h (gdbpy_clone_xmethod_worker_data):
7272         Remove.
7273         (gdbpy_free_xmethod_worker_data): Remove.
7274         (gdbpy_get_matching_xmethod_workers): Use std::vector.
7275         (gdbpy_get_xmethod_arg_types): Remove.
7276         (gdbpy_get_xmethod_result_type): Remove.
7277         (gdbpy_invoke_xmethod): Remove.
7278         * python/python.c (python_extension_ops): Remove obsolete
7279         callbacks.
7280
7281 2018-01-05  Pedro Alves  <palves@redhat.com>
7282
7283         PR gdb/18653
7284         * common/signals-state-save-restore.c
7285         (save_original_signals_state): New parameter 'quiet'.  Warn if we
7286         find a custom handler preinstalled, instead of internal erroring.
7287         But only warn if !quiet.
7288         * common/signals-state-save-restore.h
7289         (save_original_signals_state): New parameter 'quiet'.
7290         * main.c (captured_main_1): Move save_original_signals_state call
7291         after option handling, and pass QUIET.
7292
7293 2018-01-05  Pedro Alves  <palves@redhat.com>
7294
7295         * spu-tdep.c (spu_catch_start): Pass
7296         symbol_name_match_type::SEARCH_NAME to block_lookup_symbol.
7297
7298 2018-01-05  Pedro Alves  <palves@redhat.com>
7299
7300         PR gdb/22670
7301         * ada-lang.c (literal_symbol_name_matcher): New function.
7302         (ada_get_symbol_name_matcher): Use it for
7303         symbol_name_match_type::SEARCH_NAME.
7304         * block.c (block_lookup_symbol): New parameter 'match_type'.  Pass
7305         it down instead of assuming symbol_name_match_type::FULL.
7306         * block.h (block_lookup_symbol): New parameter 'match_type'.
7307         * c-valprint.c (print_unpacked_pointer): Use
7308         lookup_symbol_search_name instead of lookup_symbol.
7309         * compile/compile-object-load.c (get_out_value_type): Pass down
7310         symbol_name_match_type::SEARCH_NAME.
7311         * cp-namespace.c (cp_basic_lookup_symbol): Pass down
7312         symbol_name_match_type::FULL.
7313         * cp-support.c (cp_get_symbol_name_matcher): Handle
7314         symbol_name_match_type::SEARCH_NAME.
7315         * infrun.c (insert_exception_resume_breakpoint): Use
7316         lookup_symbol_search_name.
7317         * p-valprint.c (pascal_val_print): Use lookup_symbol_search_name.
7318         * psymtab.c (maintenance_check_psymtabs): Use
7319         symbol_name_match_type::SEARCH_NAME and SYMBOL_SEARCH_NAME.
7320         * stack.c (print_frame_args): Use lookup_symbol_search_name and
7321         SYMBOL_SEARCH_NAME.
7322         * symtab.c (lookup_local_symbol): Don't demangle the lookup name
7323         if symbol_name_match_type::SEARCH_NAME.
7324         (lookup_symbol_in_language): Pass down
7325         symbol_name_match_type::FULL.
7326         (lookup_symbol_search_name): New.
7327         (lookup_language_this): Pass down
7328         symbol_name_match_type::SEARCH_NAME.
7329         (lookup_symbol_aux, lookup_local_symbol): New parameter
7330         'match_type'.  Pass it down.
7331         * symtab.h (symbol_name_match_type::SEARCH_NAME): New enumerator.
7332         (lookup_symbol_search_name): New declaration.
7333         (lookup_symbol_in_block): New 'match_type' parameter.
7334
7335 2018-01-05  Pedro Alves  <palves@redhat.com>
7336
7337         PR gdb/22670
7338         * ada-lang.c (ada_lookup_encoded_symbol): Reimplement in terms of
7339         ada_lookup_symbol.
7340         (ada_lookup_symbol): Reimplement in terms of
7341         ada_lookup_symbol_list, bits factored out from
7342         ada_lookup_encoded_symbol.
7343
7344 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
7345
7346         * ada-exp.y (write_object_renaming): When subscripting an array
7347         using a symbol as the index, pass the block in call to
7348         ada_lookup_encoded_symbol when looking that symbol up.
7349
7350 2018-01-05  Jerome Guitton  <guitton@adacore.com>
7351
7352         * ada-lang.c (ada_array_length): Use ada_index_type instead of
7353         TYPE_INDEX_TYPE.
7354
7355 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
7356
7357         * ada-lang.c (ada_to_fixed_value_create): Add handling of
7358         the case where VALUE_LVAL (val0) is not lval_memory.
7359
7360 2018-01-05  Xavier Roirand  <roirand@adacore.com>
7361
7362         * ada-valprint.c (print_optional_low_bound): Handle
7363         character-indexed array printing like boolean-indexed array
7364         printing.
7365
7366 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
7367
7368         * NEWS: Create a new section for the next release branch.
7369         Rename the section of the current branch, now that it has
7370         been cut.
7371
7372 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
7373
7374         GDB 8.1 branch created (5219ac6237c272b938c28517bf371429260c71e7):
7375         * version.in: Bump version to 8.1.50.DATE-git.
7376
7377 2018-01-03  Xavier Roirand  <roirand@adacore.com>
7378
7379         * ada-lang.h (ada_exception_catchpoint_kind) <ada_catch_handlers>:
7380         Add field.
7381         * ada-lang.c (struct exception_support_info) <catch_handlers_sym>:
7382         Add field.
7383         (default_exception_support_info) <catch_handlers_sym>: Add field.
7384         (exception_support_info_fallback) <catch_handlers_sym>: Add field.
7385         (ada_exception_name_addr_1): Add "catch handlers" handling.
7386         (ada_exception_catchpoint_cond_string) <ex>: New parameter.
7387         Update all callers.
7388         (create_excep_cond_exprs) <ex>: Add parameter.
7389         (re_set_exception): Update create_excep_cond_exprs call.
7390         (print_it_exception, print_one_exception, print_mention_exception)
7391         (print_recreate_exception): Add "catch handler" handling.
7392         (allocate_location_catch_handlers, re_set_catch_handlers)
7393         (check_status_catch_handlers, print_it_catch_handlers)
7394         (print_one_catch_handlers, print_mention_catch_handlers)
7395         (print_recreate_catch_handlers): New function.
7396         (catch_handlers_breakpoint_ops): New variable.
7397         (catch_ada_exception_command_split) <is_catch_handlers_cmd>:
7398         Add parameter.  Add "catch handler" handling.
7399         (ada_exception_sym_name, ada_exception_breakpoint_ops):
7400         Add "catch handler" handling.
7401         (ada_exception_catchpoint_cond_string): Add "catch handler"
7402         handling.
7403         (create_ada_exception_catchpoint): Update create_excep_cond_exprs
7404         call.
7405         (catch_ada_handlers_command): New function.
7406         (initialize_ada_catchpoint_ops): Initialize "catch handlers"
7407         operations structure.
7408         (_initialize_ada_language): Add "catch handlers" command entry.
7409         * NEWS: Document "catch handlers" feature.
7410
7411 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
7412
7413         * ada-lang.c (ada_value_slice_from_ptr): Take array stride into
7414         account when creating the array type of the slice.
7415         (ada_value_slice): Likewise.
7416
7417 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
7418
7419         * gdbtypes.h (enum dynamic_prop_node_kind) <DYN_PROP_BYTE_STRIDE>:
7420         New enum value.
7421         (create_array_type_with_stride): Add byte_stride_prop parameter.
7422         * gdbtypes.c (create_array_type_with_stride) <byte_stride_prop>:
7423         New parameter.  Update all callers in this file.
7424         (array_type_has_dynamic_stride): New function.
7425         (is_dynamic_type_internal, resolve_dynamic_array): Add handling
7426         of arrays with dynamic byte strides.
7427         * dwarf2read.c (read_array_type): Add support for dynamic
7428         DW_AT_byte_stride attributes.
7429
7430 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
7431
7432         * dwarf2read.c (read_unspecified_type): Treat
7433         DW_TAG_enumeration_type DIEs from Ada units as stubs.
7434
7435 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
7436
7437         Update copyright year range in all GDB files.
7438
7439 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
7440
7441         * copyright.py (BY_HAND): Remove gdb/testsuite/gdb.base/step-line.inp
7442         and gdb/testsuite/gdb.base/step-line.c.
7443
7444 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
7445
7446         * copyright.py (main): Dump the contents of
7447         MULTIPLE_COPYRIGHT_HEADERS (separately) from BY_HAND,
7448         even if BY_HAND is empty.
7449
7450 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
7451
7452         * top.c (print_gdb_version): Update Copyright year in version
7453         message.
7454
7455 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
7456
7457         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2017.
7458
7459 For older changes see ChangeLog-2017.
7460 \f
7461 Local Variables:
7462 mode: change-log
7463 left-margin: 8
7464 fill-column: 74
7465 version-control: never
7466 coding: utf-8
7467 End: