gdb/ChangeLog

   1 2019-07-17  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-layout.c (show_source_disasm_command, show_data):
   4         Update.
   5         (reset_locator): Remove.
   6         (show_source_or_disasm_and_command): Update.
   7
   8 2019-07-17  Tom Tromey  <tom@tromey.com>
   9
  10         * tui/tui-source.c (tui_source_window_base::reset): Remove
  11         win_type parameter.
  12         * tui/tui-layout.c (make_command_window, make_source_window)
  13         (make_disasm_window, make_data_window)
  14         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
  15         (reset_locator, show_source_or_disasm_and_command): Update.
  16         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
  17         win_type parameter.
  18         (struct tui_source_window_base) <reset>: Likewise.
  19
  20 2019-07-17  Tom Tromey  <tom@tromey.com>
  21
  22         * tui/tui-layout.c (show_source_disasm_command): Use
  23         reset_locator.
  24         (reset_locator): New function.
  25         (init_and_make_win): Remove.
  26         (show_source_or_disasm_and_command): Use reset_locator.
  27
  28 2019-07-17  Tom Tromey  <tom@tromey.com>
  29
  30         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
  31         condition.
  32         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
  33         Remove condition.
  34         * tui/tui-source.c (tui_source_window_base::reset): New method.
  35         * tui/tui-layout.c (make_command_window): Don't call
  36         init_and_make_win.
  37         (make_source_window, make_disasm_window): Don't call
  38         make_source_or_disasm_window.
  39         (make_data_window): Don't call init_and_make_win.  Change calling
  40         convention.
  41         (show_source_disasm_command, show_data): Simplify.
  42         (make_source_or_disasm_window): Remove.
  43         (show_source_or_disasm_and_command): Simplify.
  44         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
  45         (struct tui_source_window_base) <reset>: Likewise.
  46         <execution_info>: Remove initializer.
  47         * tui/tui-data.c (tui_source_window_base): Initialize
  48         execution_info.
  49
  50 2019-07-17  Tom Tromey  <tom@tromey.com>
  51
  52         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
  53         variable.
  54
  55 2019-07-17  Tom Tromey  <tom@tromey.com>
  56
  57         * tui/tui.c (tui_rl_other_window): Update.
  58         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
  59         superclass method first.  Always iterate over regs_content.
  60         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
  61         method.
  62         * tui/tui-win.c (tui_set_focus_command): Update.
  63
  64 2019-07-17  Tom Tromey  <tom@tromey.com>
  65
  66         * tui/tui-win.c (tui_set_focus_command): Rename from
  67         tui_set_focus.  Call tui_enable.
  68         (tui_set_focus_command): Remove.
  69
  70 2019-07-17  Tom Tromey  <tom@tromey.com>
  71
  72         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
  73         refresh_window.
  74         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
  75         touchwin.
  76         (tui_data_window::refresh_window): Call refresh_window on data
  77         items.  Always call superclass refresh_window.
  78         (tui_win_info::refresh): Remove.
  79         (tui_source_window_base::refresh_window): Update.
  80         (tui_refresh_all): Update.
  81         * tui/tui-layout.c (show_source_disasm_command): Remove call to
  82         refresh_window.
  83         (show_source_or_disasm_and_command): Likewise.
  84         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
  85         (struct tui_source_window_base) <refresh>: Likewise.
  86
  87 2019-07-17  Tom Tromey  <tom@tromey.com>
  88
  89         * tui/tui-winsource.c (tui_clear_source_content)
  90         (tui_show_source_content): Update.
  91         * tui/tui-source.c (tui_source_window::showing_source_p): Check
  92         whether content is empty.
  93         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
  94         Remove.
  95
  96 2019-07-17  Tom Tromey  <tom@tromey.com>
  97
  98         * tui/tui-winsource.c (tui_erase_source_content): Clear the
  99         window's contents.
 100         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 101         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 102
 103 2019-07-17  Tom Tromey  <tom@tromey.com>
 104
 105         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 106         (struct tui_data_item_window): Update.
 107
 108 2019-07-17  Tom Tromey  <tom@tromey.com>
 109
 110         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 111         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 112         defines.
 113
 114 2019-07-17  Tom Tromey  <tom@tromey.com>
 115
 116         * tui/tui-winsource.h (tui_erase_source_content)
 117         (tui_clear_source_content): Remove "display_prompt" parameter.
 118         * tui/tui-winsource.c (tui_update_source_window_as_is)
 119         (tui_update_source_windows_with_addr): Update.
 120         (tui_clear_source_content): Remove "display_prompt" parameter.
 121         (tui_erase_source_content): Likewise.  Simplify.
 122         (tui_show_source_content): Update.
 123         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 124         * tui/tui-stack.c (tui_show_frame_info): Update.
 125         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 126         Remove defines.
 127
 128 2019-07-17  Tom Tromey  <tom@tromey.com>
 129
 130         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 131         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 132         parameter.
 133         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 134         parameter.
 135
 136 2019-07-17  Tom Tromey  <tom@tromey.com>
 137
 138         * tui/tui-winsource.c (tui_clear_source_content)
 139         (tui_show_source_content, tui_show_exec_info_content)
 140         (tui_clear_exec_info_content): Update.
 141         * tui/tui-stack.c (tui_show_locator_content): Update.
 142         (tui_show_frame_info): Update.
 143         * tui/tui-source.h (tui_source_window): Don't declare.
 144         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 145         from tui_source_is_displayed.
 146         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 147         Remove field.
 148         (struct tui_source_window_base) <content_in_use>: New field.  Now
 149         bool.
 150         (struct tui_source_window) <showing_source_p>: New method.
 151         (TUI_SRC_WIN): Change cast.
 152         * tui/tui-data.c (tui_initialize_static_data): Update.
 153
 154 2019-07-17  Tom Tromey  <tom@tromey.com>
 155
 156         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 157         location_matches_p.
 158         * tui/tui-source.c (tui_source_window::location_matches_p): New
 159         method.
 160         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 161         method.
 162         * tui/tui-data.h (struct tui_source_window_base)
 163         <location_matches_p>: New method.
 164         (struct tui_source_window, struct tui_disasm_window)
 165         <location_matches_p>: Likewise.
 166
 167 2019-07-17  Tom Tromey  <tom@tromey.com>
 168
 169         * tui/tui-win.c (tui_set_win_height_command): Rename from
 170         tui_set_win_height.
 171         (tui_set_win_height_command): Remove.
 172
 173 2019-07-17  Tom Tromey  <tom@tromey.com>
 174
 175         * tui/tui-source.c (tui_source_window): New constructor.  Add
 176         observer.
 177         (~tui_source_window): New destructor.
 178         (tui_source_window::style_changed): New method.
 179         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 180         (tui_attach_detach_observers): Update.
 181         * tui/tui-data.h (struct tui_source_window): Make constructor not
 182         inline.  Add destructor.
 183         (struct tui_source_window) <style_changed>: New method.
 184         <m_observable>: New member.
 185
 186 2019-07-17  Tom Tromey  <tom@tromey.com>
 187
 188         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 189         * tui/tui-win.c (tui_resize_all): Fix typo.
 190
 191 2019-07-17  Tom Tromey  <tom@tromey.com>
 192
 193         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 194         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 195         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 196         * tui/tui-win.c (window_name_completer): Use foreach.
 197         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 198         (update_tab_width): Likewise.
 199         * tui/tui-layout.c (show_layout): Update.
 200         * tui/tui-data.h (class tui_window_iterator): New.
 201         (struct all_tui_windows): New.
 202         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 203
 204 2019-07-17  Tom Tromey  <tom@tromey.com>
 205
 206         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 207         parameter.  Don't reference globals.
 208         (tui_reg_command): Update.
 209
 210 2019-07-17  Tom Tromey  <tom@tromey.com>
 211
 212         * tui/tui-regs.c (tui_show_registers): Simplify.
 213
 214 2019-07-17  Tom Tromey  <tom@tromey.com>
 215
 216         * tui/tui-regs.c (tui_show_registers): Update.
 217         (tui_show_register_group): Add win_info parameter.
 218
 219 2019-07-17  Tom Tromey  <tom@tromey.com>
 220
 221         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 222         Rename from tui_display_reg_element_at_line.
 223         (tui_data_window::display_registers_from_line): Update.
 224         * tui/tui-data.h (struct tui_data_window)
 225         <display_reg_element_at_line>: New method.
 226
 227 2019-07-17  Tom Tromey  <tom@tromey.com>
 228
 229         * tui/tui-regs.h (tui_display_registers_from)
 230         (tui_display_registers_from_line): Don't declare.
 231         * tui/tui-windata.c (tui_data_window::display_all_data)
 232         (tui_data_window::refresh_all)
 233         (tui_data_window::do_scroll_vertical): Update.
 234         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 235         from tui_display_registers_from.
 236         (tui_display_reg_element_at_line): Update.
 237         (tui_data_window::display_registers_from_line): Rename from
 238         tui_display_registers_from_line.
 239         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 240         display_registers_from_line>: New methods.
 241
 242 2019-07-17  Tom Tromey  <tom@tromey.com>
 243
 244         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 245         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 246         from tui_erase_data_content.
 247         (tui_data_window::display_all_data)
 248         (tui_data_window::refresh_all)
 249         (tui_data_window::do_scroll_vertical): Update.
 250         * tui/tui-regs.c (tui_show_registers): Update.
 251         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 252         New method.
 253
 254 2019-07-17  Tom Tromey  <tom@tromey.com>
 255
 256         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 257         declare.
 258         * tui/tui-windata.c
 259         (tui_data_window::delete_data_content_windows): Rename from
 260         tui_delete_data_content_windows.
 261         (tui_data_window::display_all_data)
 262         (tui_data_window::do_scroll_vertical): Update.
 263         * tui/tui-data.h (struct tui_data_window)
 264         <delete_data_content_windows>: New method.
 265
 266 2019-07-17  Tom Tromey  <tom@tromey.com>
 267
 268         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 269         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 270
 271 2019-07-17  Tom Tromey  <tom@tromey.com>
 272
 273         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 274         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 275         from tui_display_all_data.
 276         * tui/tui-win.c
 277         (tui_data_window::do_make_visible_with_new_height): Update.
 278         * tui/tui-regs.c (tui_show_registers): Update.
 279         * tui/tui-layout.c (tui_set_layout): Update.
 280         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 281         method.
 282
 283 2019-07-17  Tom Tromey  <tom@tromey.com>
 284
 285         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 286         * tui/tui-windata.c (tui_display_data_from): Remove.
 287         (tui_data_window::refresh_all): Update.
 288
 289 2019-07-17  Tom Tromey  <tom@tromey.com>
 290
 291         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 292         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 293         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 294         tui_display_registers_from_line.
 295         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 296         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 297         "force_display" parameter.
 298
 299 2019-07-17  Tom Tromey  <tom@tromey.com>
 300
 301         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 302         declare.
 303         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 304         Rename from tui_first_reg_element_no_inline.
 305         (tui_display_reg_element_at_line)
 306         (tui_display_registers_from_line): Update.
 307         * tui/tui-data.h (struct tui_data_window)
 308         <first_reg_element_no_inline>: New method.
 309
 310 2019-07-17  Tom Tromey  <tom@tromey.com>
 311
 312         * tui/tui-windata.c (tui_display_data_from)
 313         (tui_data_window::do_scroll_vertical): Update.
 314         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 315         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 316         Rename from tui_line_from_reg_element_no.
 317         (tui_display_registers_from_line): Update.
 318         * tui/tui-data.h (struct tui_data_window)
 319         <line_from_reg_element_no>: New method.
 320
 321 2019-07-17  Tom Tromey  <tom@tromey.com>
 322
 323         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 324         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 325         tui_last_regs_line_no.
 326         (tui_display_reg_element_at_line)
 327         (tui_display_registers_from_line): Update.
 328         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 329         method.
 330
 331 2019-07-17  Tom Tromey  <tom@tromey.com>
 332
 333         PR tui/24722:
 334         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 335         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 336         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 337         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 338         (tui_update_breakpoint_info): Likewise.
 339         * tui/tui-hooks.c (tui_event_create_breakpoint)
 340         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 341         Update.
 342
 343 2019-07-17  Tom Tromey  <tom@tromey.com>
 344
 345         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 346
 347 2019-07-17  Tom Tromey  <tom@tromey.com>
 348
 349         * tui/tui-winsource.c (tui_update_source_window_as_is)
 350         (tui_update_source_windows_with_addr): Update.
 351         * tui/tui-source.h (tui_set_source_content)
 352         (tui_show_symtab_source): Add "win_info" parameter.
 353         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 354         parameter.
 355         (tui_show_symtab_source): Likewise.
 356
 357 2019-07-17  Tom Tromey  <tom@tromey.com>
 358
 359         * tui/tui-wingeneral.c
 360         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 361
 362 2019-07-17  Tom Tromey  <tom@tromey.com>
 363
 364         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 365         (struct tui_cmd_window) <can_scroll>: New method.
 366         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 367         method.
 368
 369 2019-07-17  Tom Tromey  <tromey@adacore.com>
 370
 371         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 372         do_field_signed>: Rename.  Change type of "value".
 373         * ui-out.c (ui_out::field_signed): Rename from field_int.
 374         Change type of "value".
 375         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 376         type of "value".
 377         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 378         do_field_int.  Change type of "value".
 379         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 380         do_field_int.  Change type of "value".
 381         * tracepoint.c (trace_status_mi, tfind_1)
 382         (print_one_static_tracepoint_marker): Update.
 383         * thread.c (print_thread_info_1, print_selected_thread_frame):
 384         Update.
 385         * stack.c (print_frame, print_frame_info): Update.
 386         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 387         Update.
 388         * source.c (print_source_lines_base): Update.
 389         * skip.c (info_skip_command): Update.
 390         * record-btrace.c (btrace_ui_out_decode_error)
 391         (btrace_call_history_src_line): Update.
 392         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 393         Update.
 394         * progspace.c (print_program_space): Update.
 395         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 396         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 397         do_field_int.  Change type of "value".
 398         * mi/mi-out.c (mi_ui_out::do_table_begin)
 399         (mi_ui_out::do_table_header): Update.
 400         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 401         type of "value".
 402         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 403         (mi_cmd_data_list_changed_registers, output_register)
 404         (mi_cmd_data_read_memory, mi_load_progress)
 405         (mi_cmd_trace_frame_collected): Update.
 406         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 407         Update.
 408         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 409         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 410         (mi_cmd_var_list_children, varobj_update_one): Update.
 411         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 412         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 413         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 414         * inferior.c (print_inferior): Update.
 415         * gdb_bfd.c (print_one_bfd): Update.
 416         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 417         Update.
 418         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 419         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 420         do_field_int.  Change type of "value".
 421         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 422         do_field_int.  Change type of "value".
 423         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 424         (print_one_breakpoint_location, print_it_catch_fork)
 425         (print_one_catch_fork, print_it_catch_vfork)
 426         (print_one_catch_vfork, print_it_catch_solib)
 427         (print_it_catch_exec, print_it_ranged_breakpoint)
 428         (print_mention_watchpoint, print_mention_masked_watchpoint)
 429         (bkpt_print_it, update_static_tracepoint): Update.
 430         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 431         * break-catch-syscall.c (print_it_catch_syscall): Update.
 432         * ada-tasks.c (print_ada_task_info): Update.
 433         * ada-lang.c (print_it_exception, print_mention_exception):
 434         Update.
 435
 436 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 437
 438         PR breakpoints/24541
 439         * gdbarch.c: Regenerate.
 440         * gdbarch.h: Regenerate.
 441         * gdbarch.sh: Adjust return type and parameter types for
 442         'stap_adjust_register'.
 443         (i386_stap_adjust_register): Adjust signature and return new
 444         register name.
 445         * stap-probe.c (stap_parse_register_operand): Adjust use of
 446         'gdbarch_stap_adjust_register'.
 447
 448 2019-07-17  Tom Tromey  <tromey@adacore.com>
 449
 450         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 451         declare VEC.
 452         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 453         std::vector.
 454         (struct s390_process_info): Add initializers.
 455         (s390_add_process): Use new.
 456         (s390_linux_nat_target::low_forget_process): Use delete.
 457         (s390_linux_nat_target::low_new_fork)
 458         (s390_linux_nat_target::stopped_by_watchpoint)
 459         (s390_linux_nat_target::low_prepare_to_resume)
 460         (s390_linux_nat_target::insert_watchpoint)
 461         (s390_linux_nat_target::insert_hw_breakpoint)
 462         (s390_linux_nat_target::remove_watchpoint)
 463         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 464
 465 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 466
 467         * aarch64-fbsd-nat.c: Include regcache.h.
 468         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 469         argument.
 470         (aarch64_fbsd_nat_target::fetch_registers)
 471         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 472         variable.
 473         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 474
 475 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 476
 477         * fbsd-nat.c: Include gdbarch.h.
 478
 479 2019-07-15  Tom Tromey  <tromey@adacore.com>
 480
 481         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 482
 483 2019-07-15  Tom Tromey  <tromey@adacore.com>
 484
 485         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 486         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 487         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 488         * cli-out.c (cli_ui_out::do_field_int): New method.
 489         * ui-out.c (ui_out::field_unsigned): New method.
 490         * symfile.c (generic_load): Use field_unsigned.
 491         (print_transfer_performance): Likewise.
 492         * record-btrace.c (ui_out_field_uint): Remove.
 493         (btrace_call_history_insn_range, btrace_call_history): Use
 494         field_unsigned.
 495         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 496         field_unsigned.
 497         * ui-out.h (class ui_out) <field_unsigned>: New method.
 498         <do_field_unsigned>: Likewise.
 499
 500 2019-07-15  Tom Tromey  <tromey@adacore.com>
 501
 502         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 503         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 504         * target.c (flash_erase_command): Use field_string.
 505         * infrun.c (print_signal_received_reason): Use field_string.
 506         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 507         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 508         field_string.
 509         * ada-tasks.c (print_ada_task_info): Use field_string.
 510
 511 2019-07-15  Tom Tromey  <tromey@adacore.com>
 512
 513         * target.c (flash_erase_command): Use field_core_addr.
 514         * symfile.c (generic_load): Use field_core_addr.
 515         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 516         Use field_core_addr.
 517         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 518         field_core_addr.
 519
 520 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 521
 522         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 523         value if its desired type is smaller than a CORE_ADDR and signed.
 524
 525 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 526
 527         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 528         of changes to field names, and use new is_reference field to
 529         decide if a property is a reference or not.
 530         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 531         field.
 532         (struct dwarf2_property_baton): Update header comment, rename
 533         'referenced_type' to 'property_type' and update comments.
 534         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 535         default property type, store in property baton, update to take
 536         accound of renamed field.
 537         (read_func_scope): Update call to attr_to_dynamic_prop.
 538         (read_array_type): Likewise.
 539         (dwarf2_per_cu_addr_sized_int_type): New function.
 540         (read_subrange_index_type): Move type finding code to
 541         dwarf2_per_cu_addr_sized_int_type.
 542         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 543         (dwarf2_per_cu_addr_type): New function.
 544         (set_die_type): Update calls to attr_to_dynamic_prop.
 545
 546 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 547
 548         * dwarf2read.c (read_subrange_index_type): New function.
 549         (read_subrange_type): Move code into new function and call it.
 550         * gdbtypes.c (create_range_type): Add some asserts.
 551
 552 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 553
 554         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 555         update return statements.
 556         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 557         declaration, and update comment to match.
 558         * gdbtypes.c (resolve_dynamic_array): Update call to
 559         dwarf2_evaluate_property to match new return type.
 560
 561 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 562
 563         * valarith.c (value_subscripted_rvalue): Change lowerbound
 564         parameter type from int to LONGEST.
 565         * value.h (value_subscripted_rvalue): Likewise in declaration.
 566
 567 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 568
 569         * cli/cli-utils.c (info_print_command_completer): New function.
 570         * cli/cli-utils.h: Add 'completer.h' include, and forward
 571         declaration for 'struct cmd_list_element'.
 572         (info_print_command_completer): Declare.
 573         * stack.c (_initialize_stack): Add completer for 'info locals' and
 574         'info args'.
 575         * symtab.c (_initialize_symtab): Add completer for 'info
 576         variables' and 'info functions'.
 577         * NEWS: Mention completion for additional info commands.
 578
 579 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 580
 581         * cli/cli-utils.c (extract_info_print_args): Delete.
 582         (extract_arg_maybe_quoted): Delete.
 583         (info_print_options_defs): New variable.
 584         (make_info_print_options_def_group): New function.
 585         (extract_info_print_options): Define new function.
 586         * cli/cli-utils.h (extract_info_print_args): Delete.
 587         (struct info_print_options): New structure.
 588         (extract_info_print_options): Declare new function.
 589         * stack.c (info_locals_command): Update to use new
 590         extract_info_print_options, also add a header comment.
 591         (info_args_command): Likewise.
 592         * symtab.c (info_variables_command): Likewise.
 593         (info_functions_command): Likewise.
 594
 595 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 596
 597         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 598         to extract string arguments.
 599         * common/common-utils.c (extract_string_maybe_quoted): New function.
 600         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 601
 602 2019-07-11  Tom Tromey  <tromey@adacore.com>
 603
 604         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 605         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 606         * top.h (gdbinit): Don't declare.
 607         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 608         into...
 609         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 610         * top.c (gdb_init): Don't call init_cli_cmds.
 611         (gdbinit): Remove.
 612         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 613
 614 2019-07-11  Tom Tromey  <tromey@adacore.com>
 615
 616         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 617         after it has been moved.
 618
 619 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 620
 621         * valops.c (value_must_coerce_to_target): Change return type to
 622         bool.
 623         * value.h (value_must_coerce_to_target): Likewise.
 624
 625 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 626
 627         * breakpoint.c (is_hardware_watchpoint): Remove
 628         forward-declaration.
 629         (is_masked_watchpoint): Change return type to bool.
 630         (is_tracepoint): Likewise.
 631         (is_breakpoint): Likewise.
 632         (is_hardware_watchpoint): Likewise.
 633         (is_watchpoint): Likewise.
 634         (is_no_memory_software_watchpoint): Likewise.
 635         (is_catchpoint): Likewise.
 636         (breakpoint_1): Make FILTER parameter's return type bool.
 637         is_masked_watchpoint): Change return type to bool.
 638         (save_breakpoints): Make FILTER parameter's return type bool.
 639         * breakpoint.h (is_breakpoint): Change return type to bool.
 640         (is_watchpoint): Likewise.
 641         (is_catchpoint): Likewise.
 642         (is_tracepoint): Likewise.
 643
 644 2019-07-10  Tom Tromey  <tom@tromey.com>
 645
 646         * defs.h: Don't include gdbarch.h.
 647         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 648         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 649         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 650         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 651         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 652         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 653         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 654         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 655         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 656         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 657         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 658         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 659         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 660         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 661         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 662         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 663         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 664         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 665         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 666         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 667         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 668         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 669         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 670         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 671         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 672         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 673         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 674
 675 2019-07-10  Tom Tromey  <tromey@adacore.com>
 676
 677         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 678         * breakpoint.c (init_ada_exception_breakpoint): Register as
 679         bp_catchpoint.
 680         (print_one_breakpoint_location, print_one_breakpoint): Use
 681         is_ada_exception_catchpoint.
 682         * ada-lang.c (class ada_catchpoint_location): Pass
 683         bp_loc_software_breakpoint to bp_location constructor.
 684         (is_ada_exception_catchpoint): New function.
 685
 686 2019-07-10  Tom Tromey  <tromey@adacore.com>
 687
 688         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 689         VEC.
 690         (struct arm_exidx_entry): New method operator<.
 691         (struct arm_exidx_data) <section_maps>: Change type.
 692         (arm_exidx_data_free): Remove.
 693         (arm_exidx_data_key): Change type.  Move lower.
 694         (arm_exidx_new_objfile): Update.
 695         (arm_compare_exidx_entries): Remove.
 696         (arm_find_exidx_entry, _initialize_arm_tdep)
 697
 698 2019-07-10  Tom Tromey  <tromey@adacore.com>
 699
 700         * solib-spu.c (ocl_program_data_key): Change type.
 701         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 702         Update.
 703
 704 2019-07-10  Tom Tromey  <tromey@adacore.com>
 705
 706         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 707         (struct solib_aix_inferior_data) <library_list>: Change type.
 708         (solib_aix_inferior_data_handle): Change type.
 709         (get_solib_aix_inferior_data): Update.
 710         (solib_aix_free_library_list): Remove.
 711         (library_list_start_library): Update.
 712         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 713         return type.
 714         (solib_aix_get_library_list)
 715         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 716         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 717
 718 2019-07-10  Tom Tromey  <tromey@adacore.com>
 719
 720         * solib-dsbt.c (struct dsbt_info): Add initializers.
 721         (solib_dsbt_pspace_data): Change type.
 722         (dsbt_pspace_data_cleanup): Remove.
 723         (get_dsbt_info, _initialize_dsbt_solib): Update.
 724
 725 2019-07-10  Tom Tromey  <tromey@adacore.com>
 726
 727         * spu-tdep.c (spu_overlay_data): Change type.
 728         (spu_get_overlay_table, spu_overlay_new_objfile)
 729         (_initialize_spu_tdep): Update.
 730
 731 2019-07-10  Tom Tromey  <tromey@adacore.com>
 732
 733         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 734         destructor.
 735         (dbx_objfile_data_key): Change type and declare later.
 736         (DBX_SYMFILE_INFO): Rewrite.
 737         * dbxread.c (dbx_objfile_data_key): Change type.
 738         (dbx_symfile_init): Update.
 739         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 740         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 741         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 742
 743 2019-07-10  Tom Tromey  <tromey@adacore.com>
 744
 745         * jit.c (jit_program_space_key): Change type.  Move lower.
 746         (get_jit_program_space_data): Update.
 747         (jit_program_space_data_cleanup): Remove.
 748         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 749         Update.
 750         (struct jit_program_space_data): Add initializers.
 751
 752 2019-07-10  Tom Tromey  <tromey@adacore.com>
 753
 754         * solib-darwin.c (struct darwin_info): Add initializers.
 755         (solib_darwin_pspace_data): Change type.
 756         (darwin_pspace_data_cleanup): Remove.
 757         (get_darwin_info, _initialize_darwin_solib): Update.
 758
 759 2019-07-10  Tom Tromey  <tromey@adacore.com>
 760
 761         * remote-sim.c (struct sim_inferior_data): Add initializers,
 762         constructor, and destructor.
 763         (sim_inferior_data_key): Change type.  Move lower.
 764         (check_for_duplicate_sim_descriptor): Update.
 765         (get_sim_inferior_data): Use new.  Update.
 766         (~sim_inferior_data_cleanup): Rename from
 767         sim_inferior_data_cleanup.  Simplify.
 768         (gdbsim_close_inferior, simulator_command)
 769         (sim_command_completer, _initialize_remote_sim): Update.
 770         (next_pid, INITIAL_PID): Move earlier.
 771
 772 2019-07-10  Tom Tromey  <tromey@adacore.com>
 773
 774         * python/python-internal.h (create_thread_object): Return
 775         gdbpy_ref.
 776         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 777         * python/py-inferior.c (struct threadlist_entry): Add
 778         constructor.
 779         <thread_obj>: Now a gdbpy_ref.
 780         (thread_to_thread_object): Update.
 781         (add_thread_object): Use new.
 782         (delete_thread_object): Use delete.
 783         (infpy_threads): Update.
 784         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 785         GIL.
 786
 787 2019-07-10  Tom Tromey  <tromey@adacore.com>
 788
 789         * valops.c (value_cast): Specialize error message for Ada.
 790
 791 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 792
 793         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 794
 795 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 796
 797         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 798         bpstat_should_step): Return bool, adjust comments.
 799         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 800         bpstat_should_step): Likewise.
 801
 802 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 803
 804         * features/Makefile: Use feature target descriptions for Arm.
 805         * features/arm/arm-core.c: Generate new file.
 806         * features/arm/arm-fpa.c: Likewise.
 807         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 808         * features/arm/arm-m-profile.c: Likewise.
 809         * features/arm/arm-vfpv2.c: Likewise.
 810         * features/arm/arm-vfpv3.c: Likewise.
 811         * features/arm/xscale-iwmmxt.c: Likewise.
 812         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 813
 814 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 815
 816         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 817         ptrace earlier.
 818
 819 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 820
 821         * features/aarch64-pauth.c: Regenerate.
 822
 823 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 824
 825         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 826         bool.
 827         (bpstat_what): Use false instead of 0.
 828
 829 2019-07-09  Pedro Alves  <palves@redhat.com>
 830
 831         * break-catch-throw.c (is_exception_catchpoint): New.
 832         * breakpoint.c (print_one_breakpoint_location): New parameter
 833         'raw_loc'.  Handle it.  Use
 834         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 835         looking at the breakpoint's type.
 836         (print_one_breakpoint): If handling "maint info breakpoints", also
 837         print locations of exception catchpoints.
 838         * breakpoint.h (is_exception_catchpoint): Declare.
 839
 840 2019-07-09  Pedro Alves  <palves@redhat.com>
 841
 842         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 843         "addr" field.
 844         (allocate_location_exception_catchpoint): New.
 845         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 846         (initialize_throw_catchpoint_ops): Install
 847         allocate_location_exception_catchpoint as allocate_location
 848         method.
 849         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 850         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 851         bp_loc_other.
 852         (breakpoint_address_is_meaningful): Delete.
 853         (bl_address_is_meaningful): New.
 854         (breakpoint_locations_match): Adjust comment.
 855         (bp_location_from_bp_type): New, factored out of...
 856         (bp_location::bp_location(breakpoint *)): ... this.
 857         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 858         factored out of...
 859         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 860         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 861         breakpoint_address_is_meaningful.
 862         (bp_locations_compare): Adjust comment.
 863         (update_global_location_list): Use bl_address_is_meaningful
 864         instead of breakpoint_address_is_meaningful.
 865         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 866         explicit.
 867         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 868         * python/py-breakpoint.c (bppy_get_location): No longer check
 869         whether location is null.
 870
 871 2019-07-09  Pedro Alves  <palves@redhat.com>
 872
 873         PR c++/15468
 874         * breakpoint.c (print_one_breakpoint_location): Remove
 875         single-location assert.
 876
 877 2019-07-09  Tom Tromey  <tom@tromey.com>
 878
 879         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 880         * configure: Rebuild.
 881         * configure.ac: Change common to gdbsupport.
 882         * gdbsupport: Rename from common.
 883         * acinclude.m4: Change common to gdbsupport.
 884         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 885         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 886         gdbsupport.
 887         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 888         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 889         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 890         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 891         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 892         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 893         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 894         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 895         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 896         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 897         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 898         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 899         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 900         coff-pe-read.c, command.h, compile/compile-c-support.c,
 901         compile/compile-c.h, compile/compile-cplus-symbols.c,
 902         compile/compile-cplus-types.c, compile/compile-cplus.h,
 903         compile/compile-loc2c.c, compile/compile.c, completer.c,
 904         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 905         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 906         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 907         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 908         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 909         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 910         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 911         features/aarch64-core.c, features/aarch64-fpu.c,
 912         features/aarch64-pauth.c, features/aarch64-sve.c,
 913         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 914         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 915         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 916         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 917         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 918         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 919         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 920         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 921         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 922         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 923         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 924         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 925         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 926         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 927         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 928         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 929         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 930         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 931         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 932         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 933         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 934         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 935         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 936         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 937         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 938         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 939         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 940         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 941         minsyms.c, mips-linux-tdep.c, namespace.h,
 942         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 943         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 944         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 945         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 946         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 947         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 948         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 949         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 950         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 951         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 952         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 953         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 954         procfs.c, producer.c, progspace.h, psymtab.h,
 955         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 956         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 957         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 958         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 959         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 960         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 961         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 962         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 963         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 964         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 965         target-memory.c, target.c, target.h, target/waitstatus.c,
 966         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 967         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 968         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 969         unittests/array-view-selftests.c,
 970         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 971         unittests/common-utils-selftests.c,
 972         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 973         unittests/format_pieces-selftests.c,
 974         unittests/function-view-selftests.c,
 975         unittests/lookup_name_info-selftests.c,
 976         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 977         unittests/mkdir-recursive-selftests.c,
 978         unittests/observable-selftests.c,
 979         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 980         unittests/parse-connection-spec-selftests.c,
 981         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 982         unittests/scoped_fd-selftests.c,
 983         unittests/scoped_mmap-selftests.c,
 984         unittests/scoped_restore-selftests.c,
 985         unittests/string_view-selftests.c, unittests/style-selftests.c,
 986         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 987         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 988         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 989         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 990         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 991         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 992
 993 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 994
 995         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 996         bool value.
 997         (decode_digits_ordinary): Set explicit_line field in sal.
 998         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 999         symtab_and_line that was set on an explicit line number in
1000         assembler code.  Do always update the recorded symtab and line if
1001         we do skip the prologue.
1002
1003 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1004
1005         * breakpoint.c (set_breakpoint_location_function): Remove
1006         explicit_loc parameter.
1007         (momentary_breakpoint_from_master): Update call to
1008         set_breakpoint_location_function.
1009         (add_location_to_breakpoint): Likewise.
1010
1011 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1012
1013         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1014         required features based on default bfd type when no specific bfd
1015         is present.
1016
1017 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1018
1019         * NEWS: Mention that GDB printf and eval commands can now print
1020         C-style and Ada-style convenience var strings without
1021         calling the inferior.
1022         * printcmd.c (printf_c_string): Locally print GDB internal var
1023         instead of transiting via the inferior.
1024         (printf_wide_c_string): Likewise.
1025
1026 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1027
1028         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1029
1030 2019-07-04  Tom Tromey  <tom@tromey.com>
1031
1032         PR tui/24724:
1033         * tui/tui-winsource.c (tui_clear_source_content): Update.
1034         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1035         (tui_update_breakpoint_info): Update.
1036         (tui_set_exec_info_content): Update.
1037         * tui/tui-source.c (tui_set_source_content_nil): Update.
1038         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1039         has_break.
1040         * tui/tui-data.h (enum tui_bp_flag): New.
1041         (tui_bp_flags): New enum flags type.
1042         (struct tui_source_element) <break_mode>: Change type.  Rename
1043         from has_break.
1044         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1045         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1046         constants.
1047         * tui/tui-winsource.h: Fix comment.
1048
1049 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1050
1051         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1052         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1053         (store_fpregs_to_thread)
1054         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1055         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1056         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1057         (IWMMXT_REGS_SIZE): Add define.
1058         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1059         (fetch_vfp_regs, store_vfp_regs)
1060         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1061         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1062
1063 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1064
1065         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1066         defines.
1067         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1068         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1069         (ARM_INT_REGISTER_SIZE): ...to this.
1070         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1071         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1072         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1073         (arm_linux_collect_gregset, supply_nwfpe_register)
1074         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1075         defines.
1076         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1077         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1078         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1079         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1080         (arm_return_in_memory, arm_store_return_value)
1081         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1082         (arm_record_ld_st_multiple): Likewise.
1083         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1084         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1085
1086 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1087
1088         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1089         AARCH64_DISPLACED_MODIFIED_INSNS.
1090         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1091         (aarch64_displaced_step_copy_insn): Likewise.
1092         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1093         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1094         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1095         ARM_DISPLACED_MODIFIED_INSNS.
1096         * arm-tdep.c (arm_gdbarch_init): Likewise.
1097         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1098         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1099         (struct arm_displaced_step_closure): Use
1100         ARM_DISPLACED_MODIFIED_INSNS.
1101
1102 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1103
1104         * features/Makefile: Remove unused xml files.
1105         * features/aarch64.xml: Remove.
1106         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1107         * features/i386/amd64-avx-avx512.xml: Remove.
1108         * features/i386/amd64-avx-linux.xml: Remove.
1109         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1110         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1111         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1112         * features/i386/amd64-avx-mpx.xml: Remove.
1113         * features/i386/amd64-avx.xml: Remove.
1114         * features/i386/amd64-linux.xml: Remove.
1115         * features/i386/amd64-mpx-linux.xml: Remove.
1116         * features/i386/amd64-mpx.xml: Remove.
1117         * features/i386/amd64.xml: Remove.
1118         * features/i386/i386-avx-avx512-linux.xml: Remove.
1119         * features/i386/i386-avx-avx512.xml: Remove.
1120         * features/i386/i386-avx-linux.xml: Remove.
1121         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1122         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1123         * features/i386/i386-avx-mpx-linux.xml: Remove.
1124         * features/i386/i386-avx-mpx.xml: Remove.
1125         * features/i386/i386-avx.xml: Remove.
1126         * features/i386/i386-linux.xml: Remove.
1127         * features/i386/i386-mmx-linux.xml: Remove.
1128         * features/i386/i386-mmx.xml: Remove.
1129         * features/i386/i386-mpx-linux.xml: Remove.
1130         * features/i386/i386-mpx.xml: Remove.
1131         * features/i386/i386.xml: Remove.
1132         * features/i386/x32-avx-avx512-linux.xml: Remove.
1133         * features/i386/x32-avx-linux.xml: Remove.
1134         * features/i386/x32-linux.xml: Remove.
1135
1136 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1137
1138         * regformats/aarch64.dat: Remove.
1139         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1140         * regformats/i386/amd64-avx-linux.dat: Remove.
1141         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1142         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1143         * regformats/i386/amd64-linux.dat: Remove.
1144         * regformats/i386/amd64-mpx-linux.dat: Remove.
1145         * regformats/i386/amd64.dat: Remove.
1146         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1147         * regformats/i386/i386-avx-linux.dat: Remove.
1148         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1149         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1150         * regformats/i386/i386-linux.dat: Remove.
1151         * regformats/i386/i386-mmx-linux.dat: Remove.
1152         * regformats/i386/i386-mpx-linux.dat: Remove.
1153         * regformats/i386/i386.dat: Remove.
1154         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1155         * regformats/i386/x32-avx-linux.dat: Remove.
1156         * regformats/i386/x32-linux.dat: Remove.
1157
1158 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1159
1160         * aarch64-tdep.c: Remove xml self tests.
1161         * amd64-linux-tdep.c: Likewise.
1162         * amd64-tdep.c: Likewise.
1163         * i386-linux-tdep.c: Likewise.
1164         * i386-tdep.c: Likewise.
1165
1166 2019-07-03  Pedro Alves  <palves@redhat.com>
1167
1168         PR cli/24732
1169         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1170         (pipe_cmd_option_defs): New.
1171         (make_pipe_cmd_options_def_group): New.
1172         (pipe_command): Use gdb::option::process_options.
1173         (pipe_command_completer): New function.
1174         (_initialize_cli_cmds): Install completer for "pipe" command.
1175
1176 2019-07-03  Pedro Alves  <palves@redhat.com>
1177
1178         * cli/cli-option.c (union option_value) <string>: New field.
1179         (struct option_def_and_value): Add ctor, move ctor, dtor and
1180         use DISABLE_COPY_AND_ASSIGN.
1181         (option_def_and_value::clear_value): New.
1182         (parse_option, save_option_value_in_ctx, get_val_type_str)
1183         (add_setshow_cmds_for_options): Handle var_string.
1184         * cli-option.h (union option_def::var_address) <string>: New
1185         field.
1186         (struct string_option_def): New.
1187         * maint-test-options.c (struct test_options_opts): Add default
1188         ctor and use DISABLE_COPY_AND_ASSIGN.
1189         <string_opt>: New field.
1190         (test_options_opts::~test_options_opts): New.
1191         (test_options_opts::dump): Also dump "-string".
1192         (test_options_option_defs): Install "string.
1193
1194 2019-07-03  Pedro Alves  <palves@redhat.com>
1195
1196         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1197         option_value with a null enumeration.
1198         (complete_options): Save the option values in the context.
1199         (save_option_value_in_ctx): New, factored out from ...
1200         (process_options): ... here.
1201         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1202         of the function.
1203         * maint-test-options.c (test_options_opts::dump): New, factored
1204         out from ...
1205         (maintenance_test_options_command_mode): ... here.
1206         (maintenance_test_options_command_completion_result): Delete.
1207         (maintenance_test_options_command_completion_text): Update
1208         comment.
1209         (maintenance_show_test_options_completion_result): Change
1210         prototype.  Just print
1211         maintenance_test_options_command_completion_text.
1212         (save_completion_result): New.
1213         (maintenance_test_options_completer_mode): Pass options context to
1214         complete_options, and then save a dump.
1215         (_initialize_maint_test_options): Use add_cmd to install "maint
1216         show test-options-completion-result".
1217
1218 2019-07-03  Pedro Alves  <palves@redhat.com>
1219
1220         * NEWS (New commands): Mention "with" and "maint with".
1221         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1222         (with_command, with_command_completer): New.
1223         (pipe_command): Adjust to new repeat_previous
1224         interface.
1225         (_initialize_cli_cmds): Install the "with" command and its "w"
1226         alias.
1227         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1228         declarations.
1229         * cli/cli-setshow.c (parse_cli_var_uinteger)
1230         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1231         argument strings for all var_types.
1232         (get_setshow_command_value_string): New, factored out from ...
1233         (do_show_command): ... this.
1234         * cli/cli-setshow.h: Include <string>.
1235         (get_setshow_command_value_string): Declare.
1236         * command.h (repeat_previous): Now returns const char *.  Adjust
1237         comment.
1238         * maint.c: Include "cli/cli-cmds.h".
1239         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1240         (_initialize_maint_cmds): Register the "maintenance with" command.
1241         * top.c (repeat_previous): Move bits from pipe_command here:
1242         Return the saved command line, if any; error out if there's no
1243         command to relaunch.
1244
1245 2019-07-03  Pedro Alves  <palves@redhat.com>
1246
1247         * NEWS (New commands): Mention "maint set/show test-settings"
1248         instead of "maint test-settings".
1249         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1250         (maintenance_test_settings_set_list): Rename to ...
1251         (maintenance_set_test_settings_list): ... this.
1252         (maintenance_test_settings_show_list): Rename to  ...
1253         (maintenance_show_test_settings_list): ... this.
1254         (maintenance_test_settings_cmd): Delete.
1255         (maintenance_test_settings_set_cmd): ...
1256         (maintenance_set_test_settings_cmd): ... this.
1257         (maintenance_test_settings_show_cmd): ...
1258         (maintenance_show_test_settings_cmd): ... this.
1259         (maintenance_test_settings_show_value_cmd):
1260         (maintenance_show_test_settings_value_cmd): ... this.
1261         (_initialize_maint_test_settings): No longer install the "maint
1262         test-settings" prefix command.  Rename "maint test-settings set"
1263         to "maint set test-settings", and "maint test-settings show" to
1264         "maint show test-settings".  Adjust all subcommands.
1265
1266 2019-07-03  Pedro Alves  <palves@redhat.com>
1267
1268         * maint-test-settings.c: Fix file's intro comment.  Replace all
1269         references to "test-options" with references to "test-settings",
1270         in comments.
1271
1272 2019-07-03  Pedro Alves  <palves@redhat.com>
1273
1274         * maint-test-settings.c (maintenance_test_settings_xxx)
1275         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1276         New.
1277         (maintenance_test_settings_enums): Use them.
1278         (maintenance_test_settings_enum): Default to
1279         maintenance_test_settings_xxx.
1280         (_initialize_maint_test_settings): Initialize
1281         MAINTENANCE_TEST_SETTINGS_FILENAME.
1282
1283 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1284
1285         * breakpoint.h (remove_breakpoints_inf): Change return type to
1286         void, move function documentation here.
1287         * breakpoint.c (remove_breakpoints_inf): Change return type to
1288         void, move function documentation to header.
1289
1290 2019-07-02  Pedro Alves  <palves@redhat.com>
1291
1292         * NEWS (Completion improvements): Mention "info threads".
1293         * thread.c (struct info_threads_opts, info_threads_option_defs)
1294         (make_info_threads_options_def_group): New.
1295         (info_threads_command): Use gdb::option::process_options.
1296         (info_threads_command_completer): New.
1297         (_initialize_thread): Use gdb::option::build_help to build the
1298         help text for "info threads".
1299
1300 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1301
1302         * defs.h (generic_load): Move from here...
1303         * symfile.h (generic_load): ... to here.  Rename name parameter
1304         to args.
1305         * symfile.c (generic_load): Add comment.
1306
1307 2019-07-01  Tom Tromey  <tromey@adacore.com>
1308
1309         * dwarf2read.c
1310         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1311         declaration of without_params.  Fix formatting.
1312
1313 2019-07-01  Tom Tromey  <tromey@adacore.com>
1314
1315         * ada-exp.y (find_primitive_type): Update.
1316         * ada-lang.h (ada_lookup_symbol): Update.
1317         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1318         parameter.
1319         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1320
1321 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1322
1323         PR breakpoints/24541
1324         * gdbarch.c: Regenerate.
1325         * gdbarch.h: Regenerate.
1326         * gdbarch.sh: Add 'stap_adjust_register'.
1327         * i386-tdep.c: Include '<unordered_set>'.
1328         (i386_stap_adjust_register): New function.
1329         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1330         * stap-probe.c (stap_parse_register_operand): Call
1331         'gdbarch_stap_adjust_register'.
1332
1333 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1334
1335         PR python/24742
1336         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1337         * python/python.c (do_start_initialization): Use 'xmalloc'
1338         instead of 'PyMem_Malloc'.
1339
1340 2019-06-28  Tom Tromey  <tromey@adacore.com>
1341
1342         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1343         for Ada.
1344
1345 2019-06-27  Tom Tromey  <tromey@adacore.com>
1346
1347         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1348         objfile_key.
1349         (arm_find_mapping_symbol, arm_record_special_symbol)
1350         (_initialize_arm_tdep): Update.
1351         (arm_objfile_data_free): Remove.
1352
1353 2019-06-27  Tom Tromey  <tromey@adacore.com>
1354
1355         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1356         to cp_print_static_field.
1357
1358 2019-06-26  Tom Tromey  <tromey@adacore.com>
1359
1360         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1361         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1362         declare.
1363
1364 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1365
1366         * features/aarch64-core.c (create_feature_aarch64_core):
1367         Regenerate.
1368         * features/aarch64-core.xml: Add cpsr flags.
1369
1370 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1371
1372         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1373         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1374
1375 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1376
1377         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1378         field.
1379         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1380         use.
1381         (arm_record_special_symbol): Don't insert new symbol in sorted
1382         position, push it at the end.
1383
1384 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1385
1386         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1387         (arm_mapping_symbol_s): Remove.
1388         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1389         (arm_mapping_symbol_vec): New typedef.
1390         (struct arm_per_objfile): Add constructor.
1391         <section_maps>: Change type to
1392         std::unique_ptr<arm_mapping_symbol_vec[]>.
1393         (arm_compare_mapping_symbols): Remove.
1394         (arm_find_mapping_symbol): Adjust to section_maps type change.
1395         (arm_objfile_data_free): Call delete on arm_per_objfile.
1396         (arm_record_special_symbol): Adjust to section_maps type change.
1397         Allocate arm_per_objfile with new.
1398
1399 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1400
1401         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1402         with the command prefix.
1403
1404 2019-06-25  Tom Tromey  <tom@tromey.com>
1405
1406         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1407         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1408
1409 2019-06-25  Tom Tromey  <tom@tromey.com>
1410
1411         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1412         type.
1413         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1414         protected.
1415
1416 2019-06-25  Tom Tromey  <tom@tromey.com>
1417
1418         * tui/tui-winsource.c
1419         (tui_source_window_base::set_is_exec_point_at): Add check against
1420         LOA_ADDRESS.
1421
1422 2019-06-25  Tom Tromey  <tom@tromey.com>
1423
1424         * tui/tui-source.c (tui_set_source_content): Don't check before
1425         xfree.
1426         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1427
1428 2019-06-25  Tom Tromey  <tom@tromey.com>
1429
1430         * tui/tui-winsource.h (tui_update_source_window_as_is)
1431         (tui_alloc_source_buffer, tui_line_is_displayed)
1432         (tui_addr_is_displayed): Change type of win_info.
1433         * tui/tui-winsource.c (tui_update_source_window_as_is)
1434         (tui_clear_source_content, tui_show_source_line)
1435         (tui_show_source_content, tui_source_window_base::refill)
1436         (tui_source_window_base::set_is_exec_point_at)
1437         (tui_source_window_base::set_is_exec_point_at)
1438         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1439         (tui_alloc_source_buffer, tui_line_is_displayed)
1440         (tui_addr_is_displayed): Change type of win_info.  Update.
1441         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1442         (tui_source_window_base::do_make_visible_with_new_height):
1443         Update.
1444         * tui/tui-source.c (tui_set_source_content)
1445         (tui_set_source_content_nil)
1446         (tui_source_window::do_scroll_vertical): Update.
1447         * tui/tui-layout.c (show_layout): Update.
1448         * tui/tui-disasm.c (tui_set_disassem_content)
1449         (tui_disasm_window::do_scroll_vertical): Update.
1450         * tui/tui-data.h (tui_win_content): Remove.
1451         (struct tui_gen_win_info) <content, content_size>: Remove.
1452         (struct tui_source_element): Add initializers and destructor.
1453         (union tui_which_element, struct tui_win_element): Remove.
1454         (struct tui_source_window_base) <content>: New field.
1455         (struct tui_data_window): Remove destructor.
1456         (tui_alloc_content, tui_free_win_content)
1457         (tui_free_all_source_wins_content): Don't declare.
1458         * tui/tui-data.c (tui_initialize_static_data): Update.
1459         (init_content_element, tui_alloc_content): Remove.
1460         (~tui_gen_win_info): Update.
1461         (~tui_data_window, tui_free_all_source_wins_content)
1462         (tui_free_win_content, free_content, free_content_elements):
1463         Remove.
1464
1465 2019-06-25  Tom Tromey  <tom@tromey.com>
1466
1467         * tui/tui-winsource.h (tui_clear_source_content)
1468         (tui_erase_source_content, tui_show_source_content): Change type
1469         of win_info.
1470         * tui/tui-winsource.c (tui_clear_source_content)
1471         (tui_erase_source_content, tui_show_source_content): Change type
1472         of win_info.
1473         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1474         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1475         win_info.
1476         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1477         win_info.
1478         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1479
1480 2019-06-25  Tom Tromey  <tom@tromey.com>
1481
1482         * tui/tui-winsource.c (tui_clear_source_content)
1483         (tui_source_window_base::set_is_exec_point_at): Update.
1484         * tui/tui-source.c (tui_set_source_content_nil): Update.
1485         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1486         a bool.
1487         * tui/tui-data.c (init_content_element): Update.
1488
1489 2019-06-25  Tom Tromey  <tom@tromey.com>
1490
1491         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1492         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1493         * tui/tui-layout.c (init_and_make_win): Update.
1494         * tui/tui.h (enum tui_win_type): Update.
1495         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1496         tui_win_is_auxillary.
1497         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1498         tui_win_is_auxillary.
1499
1500 2019-06-25  Tom Tromey  <tom@tromey.com>
1501
1502         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1503         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1504         (tui_delete_data_content_windows, tui_display_all_data)
1505         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1506         Update.
1507         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1508         * tui/tui-regs.c (tui_last_regs_line_no)
1509         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1510         (tui_show_registers): Update.
1511         (tui_show_register_group): Return void.  Update.
1512         (tui_display_registers_from, tui_display_reg_element_at_line)
1513         (tui_display_registers_from_line, tui_check_register_values):
1514         Update.
1515         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1516         member.
1517         (struct tui_data_window) <regs_content>: Now a std::vector.
1518         <regs_content_count>: Remove.
1519         (tui_add_content_elements, tui_free_data_content): Don't declare.
1520         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1521         (init_content_element): Remove DATA_WIN case.  Add assert.
1522         (tui_add_content_elements): Remove.
1523         (tui_data_window): Update.
1524         (tui_free_data_content): Remove.
1525         (free_content_elements): Remove DATA_WIN case.
1526
1527 2019-06-25  Tom Tromey  <tom@tromey.com>
1528
1529         * tui/tui-data.c (tui_data_item_window): Update.
1530         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1531         * tui/tui-windata.c (tui_display_all_data)
1532         (tui_display_data_from_line): Update.
1533         (tui_check_data_values): Remove.
1534         * tui/tui-regs.c (tui_show_register_group)
1535         (tui_display_reg_element_at_line): Update.
1536         * tui/tui-hooks.c (tui_register_changed)
1537         (tui_refresh_frame_and_register_information): Call
1538         tui_check_register_values.
1539         * tui/tui-data.h (struct tui_data_window) <data_content,
1540         data_content_count, data_type>: Remove.
1541         (enum tui_data_type): Remove.
1542
1543         * tui/tui-data.c (tui_data_window::clear_detail)
1544         (~tui_data_window): Update.
1545
1546 2019-06-25  Tom Tromey  <tom@tromey.com>
1547
1548         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1549         declare.
1550         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1551         Rename from tui_first_data_item_displayed.  Update.
1552         (tui_data_window::refresh_all)
1553         (tui_data_window::do_scroll_vertical): Update.
1554         * tui/tui-data.h (struct tui_data_window)
1555         <first_data_item_displayed>: Declare new method.
1556
1557 2019-06-25  Tom Tromey  <tom@tromey.com>
1558
1559         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1560         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1561         contents...
1562         (tui_initialize_static_data): ...here.
1563
1564 2019-06-25  Tom Tromey  <tom@tromey.com>
1565
1566         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1567         (tui_display_registers_from, tui_check_register_values): Update.
1568         (tui_display_register): Remove win_info parameter; update.
1569         (tui_get_register): Change type of parameters.
1570         * tui/tui-data.h (struct tui_data_element): Remove.
1571         (union tui_which_element) <data>: Remove.
1572         <data_window>: Change type.
1573         (struct tui_data_item_window): New.
1574         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1575         case.  Add assert.
1576         (~tui_data_item_window): New destructor.
1577         (free_content_elements): Remove DATA_ITEM_WIN case.
1578
1579 2019-06-25  Tom Tromey  <tom@tromey.com>
1580
1581         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1582         Remove.
1583
1584 2019-06-25  Tom Tromey  <tom@tromey.com>
1585
1586         * tui/tui-data.h (struct tui_command_element): Remove.
1587         (union tui_which_element) <command>: Remove.
1588         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1589         assert.
1590         (free_content_elements): Remove CMD_WIN case.
1591
1592 2019-06-25  Tom Tromey  <tom@tromey.com>
1593
1594         * tui/tui-layout.c (tui_set_layout): Update.
1595         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1596         * tui/tui-data.c (layout_def): Update.
1597
1598 2019-06-25  Tom Tromey  <tom@tromey.com>
1599
1600         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1601         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1602         (tui_source_window_base::set_new_height): Update.
1603         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1604         Update.
1605         (tui_set_locator_fullname, tui_set_locator_info)
1606         (tui_show_frame_info): Update.
1607         * tui/tui-source.c (tui_set_source_content)
1608         (tui_source_is_displayed): Update.
1609         * tui/tui-layout.c (show_source_disasm_command, show_data)
1610         (show_source_or_disasm_and_command): Update.
1611         * tui/tui-disasm.c (tui_set_disassem_content)
1612         (tui_get_begin_asm_address): Update.
1613         * tui/tui-data.h (struct tui_locator_element): Remove.
1614         (union tui_which_element) <locator>: Remove.
1615         (struct tui_locator_window): New.
1616         (tui_locator_win_info_ptr): Change return type.
1617         * tui/tui-data.c (_locator): Change type.
1618         (tui_locator_win_info_ptr): Change return type.
1619         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1620         (tui_alloc_content): Add assert.
1621
1622 2019-06-25  Tom Tromey  <tom@tromey.com>
1623
1624         * tui/tui-winsource.c
1625         (tui_exec_info_window::maybe_allocate_content): New method.
1626         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1627         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1628         (make_source_or_disasm_window): Add cast.
1629         * tui/tui-data.h (union tui_which_element) <simple_string>:
1630         Remove.
1631         (struct tui_source_info): New.
1632         (struct tui_source_window_base) <execution_info>: Change type.
1633         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1634         case, and add assert.
1635         (tui_alloc_content): Add assert.
1636
1637 2019-06-25  Tom Tromey  <tom@tromey.com>
1638
1639         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1640         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1641         * tui/tui-data.c (tui_alloc_win_info): Remove.
1642
1643 2019-06-25  Tom Tromey  <tom@tromey.com>
1644
1645         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1646         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1647         can_highlight.
1648
1649 2019-06-25  Tom Tromey  <tom@tromey.com>
1650
1651         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1652         make_visible_with_new_height method.
1653         (tui_win_info::make_visible_with_new_height): New method.
1654         (tui_source_window_base::do_make_visible_with_new_height)
1655         (tui_data_window::do_make_visible_with_new_height)
1656         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1657         (make_visible_with_new_height): Remove.
1658         (tui_resize_all, tui_adjust_win_heights): Use
1659         make_visible_with_new_height method.
1660         * tui/tui-data.h (struct tui_win_info)
1661         <do_make_visible_with_new_height, make_visible_with_new_height>:
1662         New methods.
1663         (struct tui_source_window_base, struct tui_data_window)
1664         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1665         methods.
1666
1667 2019-06-25  Tom Tromey  <tom@tromey.com>
1668
1669         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1670         method.
1671         (update_tab_width): Call update_tab_width method.
1672         * tui/tui-data.h (struct tui_win_info)
1673         (struct tui_source_window_base) <update_tab_width>: New methods.
1674
1675 2019-06-25  Tom Tromey  <tom@tromey.com>
1676
1677         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1678         parameter.
1679         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1680         parameter.
1681         (tui_gen_win_info::make_visible): Update.
1682         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1683         parameter.
1684         * tui/tui-data.h (enum tui_box): New enum.
1685         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1686
1687 2019-06-25  Tom Tromey  <tom@tromey.com>
1688
1689         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1690         init_and_make_win for EXEC_INFO_WIN.
1691         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1692         longer inline.
1693         (struct tui_win_info) <~tui_win_info>: Inline.
1694         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1695         Don't declare.
1696         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1697         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1698         Remove.
1699         (tui_initialize_static_data): Update.
1700         (~tui_gen_win_info): Handle more cleanup here.
1701         (~tui_source_window_base): Delete "execution_info".
1702         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1703
1704 2019-06-25  Tom Tromey  <tom@tromey.com>
1705
1706         * tui/tui-layout.c (make_command_window): Don't set
1707         can_highlight.
1708         (show_source_disasm_command): Call the reset method.
1709         (show_data): Don't set can_highlight.  Call the reset method.
1710         (tui_gen_win_info::reset): Rename from init_gen_win_info
1711         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1712         (show_source_or_disasm_and_command): Call the reset method.
1713         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1714         (struct tui_cmd_window): Set can_highlight.
1715
1716 2019-06-25  Tom Tromey  <tom@tromey.com>
1717
1718         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1719         from make_visible.
1720         (tui_make_visible, tui_make_invisible): Rewrite.
1721         (tui_win_info::make_visible): Remove.
1722         (tui_source_window_base::make_visible): Update.
1723         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1724         method.  Moved from...
1725         (struct tui_win_info) <make_visible>: ...here.
1726
1727 2019-06-25  Tom Tromey  <tom@tromey.com>
1728
1729         * tui/tui-winsource.c
1730         (tui_source_window_base::do_scroll_horizontal): Remove direction
1731         parameter.
1732         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1733         direction parameter.
1734         * tui/tui-win.c (tui_win_info::forward_scroll)
1735         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1736         (tui_win_info::right_scroll): Update.
1737         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1738         direction parameter.
1739         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1740         direction parameter.
1741         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1742         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1743         Remove direction parameter.
1744         (struct tui_source_window_base, struct tui_source_window)
1745         (struct tui_disasm_window, struct tui_data_window)
1746         (struct tui_cmd_window): Update.
1747
1748 2019-06-25  Tom Tromey  <tom@tromey.com>
1749
1750         * tui/tui-winsource.h (tui_set_exec_info_content)
1751         (tui_show_exec_info_content, tui_erase_exec_info_content)
1752         (tui_clear_exec_info_content, tui_update_exec_info): Change
1753         argument to tui_source_window_base.
1754         * tui/tui-winsource.c (tui_set_exec_info_content)
1755         (tui_show_exec_info_content, tui_erase_exec_info_content)
1756         (tui_clear_exec_info_content, tui_update_exec_info): Change
1757         argument to tui_source_window_base.
1758
1759 2019-06-25  Tom Tromey  <tom@tromey.com>
1760
1761         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1762         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1763
1764 2019-06-25  Tom Tromey  <tom@tromey.com>
1765
1766         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1767         check.
1768
1769 2019-06-25  Tom Tromey  <tom@tromey.com>
1770
1771         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1772         type to void.
1773         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1774         type to void.
1775         * tui/tui-source.c (tui_set_source_content): Update.
1776         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1777
1778 2019-06-25  Tom Tromey  <tom@tromey.com>
1779
1780         * tui/tui-win.c (window_name_completer, tui_set_focus)
1781         (tui_all_windows_info): Use name method.
1782         * tui/tui-data.h (struct tui_gen_win_info)
1783         (struct tui_source_window, struct tui_disasm_window)
1784         (struct tui_data_window, struct tui_cmd_window) <name>: New
1785         method.
1786         (tui_win_name): Don't declare.
1787         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1788         (tui_win_name): Remove.
1789
1790 2019-06-25  Tom Tromey  <tom@tromey.com>
1791
1792         * tui/tui-winsource.h (tui_update_source_window)
1793         (tui_update_source_window_as_is): Change parameter type.
1794         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1795         to be a tui_source_window_base.
1796         (tui_update_source_window_as_is): Likewise.
1797         * tui/tui-win.c (make_visible_with_new_height): Update.
1798
1799 2019-06-25  Tom Tromey  <tom@tromey.com>
1800
1801         * tui/tui-winsource.c (tui_erase_source_content)
1802         (tui_show_source_content, tui_show_exec_info_content)
1803         (tui_erase_exec_info_content): Use refresh_window method.
1804         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1805         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1806         from tui_refresh_win.
1807         (tui_data_window::refresh_window): New method.
1808         (tui_win_info::refresh, tui_source_window_base::refresh)
1809         (tui_refresh_all): Use refresh_window method.
1810         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1811         method.
1812         * tui/tui-regs.c (tui_display_register): Call refresh_window
1813         method.
1814         * tui/tui-layout.c (show_source_disasm_command)
1815         (show_source_or_disasm_and_command): Call refresh_window method.
1816         * tui/tui-data.h (struct tui_gen_win_info)
1817         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1818         New method.
1819
1820 2019-06-25  Tom Tromey  <tom@tromey.com>
1821
1822         * tui/tui.c (tui_rl_other_window, tui_enable)
1823         (tui_is_window_visible, tui_get_command_dimension): Update.
1824         * tui/tui-winsource.c (tui_update_source_window_as_is)
1825         (tui_clear_source_content, tui_erase_source_content)
1826         (tui_show_source_line, tui_source_window_base::refill)
1827         (tui_source_window_base::do_scroll_horizontal)
1828         (tui_source_window_base::set_is_exec_point_at)
1829         (tui_update_breakpoint_info, tui_set_exec_info_content)
1830         (tui_alloc_source_buffer, tui_line_is_displayed)
1831         (tui_addr_is_displayed): Update.
1832         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1833         (tui_check_and_display_highlight_if_needed)
1834         (tui_win_info::make_visible, tui_win_info::refresh)
1835         (tui_refresh_all): Update.
1836         * tui/tui-windata.c (tui_first_data_item_displayed)
1837         (tui_delete_data_content_windows, tui_erase_data_content)
1838         (tui_display_all_data, tui_data_window::refresh_all)
1839         (tui_check_data_values): Update.
1840         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1841         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1842         (tui_win_info::backward_scroll, tui_refresh_all_win)
1843         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1844         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1845         (tui_source_window_base::set_new_height)
1846         (tui_data_window::set_new_height)
1847         (make_invisible_and_set_new_height)
1848         (make_visible_with_new_height, new_height_ok)
1849         (parse_scrolling_args): Update.
1850         * tui/tui-stack.c (tui_show_frame_info): Update.
1851         * tui/tui-source.c (tui_set_source_content)
1852         (tui_set_source_content_nil, tui_source_is_displayed)
1853         (tui_source_window::do_scroll_vertical): Update.
1854         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1855         (tui_display_registers_from, tui_display_reg_element_at_line)
1856         (tui_check_register_values, tui_reg_command): Update.
1857         * tui/tui-layout.c (tui_default_win_height)
1858         (show_source_disasm_command, show_data, init_and_make_win)
1859         (show_source_or_disasm_and_command): Update.
1860         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1861         (tui_redisplay_readline, tui_mld_flush)
1862         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1863         (tui_getc): Update.
1864         * tui/tui-disasm.c (tui_set_disassem_content)
1865         (tui_disasm_window::do_scroll_vertical): Update.
1866         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1867         Now virtual.
1868         (struct tui_win_info): Derive from tui_gen_win_info.
1869         <~tui_win_info>: Mark as override.
1870         <generic>: Remove member.
1871         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1872         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1873         (~tui_data_window, ~tui_win_info)
1874         (tui_free_all_source_wins_content): Update.
1875         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1876
1877 2019-06-25  Tom Tromey  <tom@tromey.com>
1878
1879         * tui/tui-layout.c (init_and_make_win): Use new.
1880         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1881         destructor, initializers.
1882         (tui_alloc_generic_win_info): Don't declare.
1883         * tui/tui-data.c (_locator): Add argument to constructor.
1884         (source_win, disasm_win): New globals.
1885         (exec_info): Remove.
1886         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1887         Update.
1888         (tui_alloc_generic_win_info): Remove.
1889         (init_content_element): Use new.
1890         (tui_win_info::tui_win_info): Update.
1891         (free_content_elements) <case DATA_WIN>: Use delete.
1892
1893 2019-06-25  Tom Tromey  <tom@tromey.com>
1894
1895         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1896         * tui/tui-windata.c (tui_first_data_item_displayed)
1897         (tui_delete_data_content_windows): Update.
1898         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1899         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1900         (tui_display_registers_from, tui_check_register_values): Update.
1901         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1902         pointer.
1903         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1904         window.
1905         (tui_free_data_content): Update.
1906         (free_content_elements) <case DATA_WIN>: Free the window.
1907
1908 2019-06-25  Tom Tromey  <tom@tromey.com>
1909
1910         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1911         Update.
1912         * tui/tui-layout.c (make_command_window)
1913         (show_source_disasm_command, show_data, init_and_make_win)
1914         (show_source_or_disasm_and_command): Update.
1915         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1916         method.
1917         <can_highight, is_highlighted>: Now bool.
1918         (tui_set_win_highlight): Don't declare.
1919         * tui/tui-data.c (tui_set_win_highlight): Remove.
1920
1921 2019-06-25  Tom Tromey  <tom@tromey.com>
1922
1923         * tui/tui-wingeneral.c (make_visible): Remove check of window
1924         type.
1925
1926 2019-06-25  Tom Tromey  <tom@tromey.com>
1927
1928         * tui/tui-win.c (tui_win_info::max_height)
1929         (tui_cmd_window::max_height): New methods.
1930         (new_height_ok): Call max_height.
1931         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1932         <max_height>: New method.
1933
1934 2019-06-25  Tom Tromey  <tom@tromey.com>
1935
1936         * tui/tui-win.c (tui_source_window_base::set_new_height)
1937         (tui_data_window::set_new_height): New methods.
1938         (make_invisible_and_set_new_height): Call set_new_height method.
1939         * tui/tui-data.h (struct tui_win_info)
1940         (struct tui_source_window_base, struct tui_data_window)
1941         <set_new_height>: New method.
1942
1943 2019-06-25  Tom Tromey  <tom@tromey.com>
1944
1945         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1946         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1947         tui_refresh_data_win.
1948         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1949         method.
1950         (tui_refresh_all_win): Call the refresh_all method.
1951         (tui_set_focus): Likewise.
1952         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1953         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1954         Likewise.
1955
1956 2019-06-25  Tom Tromey  <tom@tromey.com>
1957
1958         * tui/tui-winsource.h (tui_refill_source_window)
1959         (tui_set_is_exec_point_at): Don't declare.
1960         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1961         (tui_source_window_base::refill): Rename from
1962         tui_refill_source_window.
1963         (tui_source_window_base::do_scroll_horizontal): Update.
1964         (tui_source_window_base::set_is_exec_point_at): Rename from
1965         tui_set_is_exec_point_at.
1966         (tui_update_all_breakpoint_info): Update.
1967         * tui/tui-stack.c (tui_show_frame_info): Update.
1968         * tui/tui-layout.c (show_data): Add cast.
1969         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1970         * tui/tui-data.h (struct tui_source_window_base) <refill,
1971         set_is_exec_point_at>: New methods.
1972         (tui_source_windows, tui_add_to_source_windows): Update types.
1973         (tui_add_to_source_windows): Remove redundant declaration.
1974         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1975         (tui_source_windows): Change return type.
1976         (tui_clear_source_windows_detail): Update.
1977         (tui_add_to_source_windows): Change type of parameter.
1978         (tui_free_all_source_wins_content): Update.
1979
1980 2019-06-25  Tom Tromey  <tom@tromey.com>
1981
1982         * tui/tui-wingeneral.c (tui_win_info::refresh)
1983         (tui_source_window_base::refresh): New methods.
1984         (tui_refresh_all): Call the refresh method.
1985         * tui/tui-data.h (struct tui_win_info)
1986         (struct tui_source_window_base) <refresh>: New method.
1987
1988 2019-06-25  Tom Tromey  <tom@tromey.com>
1989
1990         * tui/tui.h (tui_is_window_visible): Return bool.
1991         * tui/tui.c (tui_is_window_visible): Return bool.
1992         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1993         (tui_make_visible, tui_make_invisible)
1994         (tui_win_info::make_visible)
1995         (tui_source_window_base::make_visible, make_all_visible)
1996         (tui_make_all_visible, tui_make_all_invisible): Update.
1997         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1998         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1999         bool.
2000         (struct tui_win_info, struct tui_source_window_base)
2001         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2002         * tui/tui-data.c (tui_init_generic_part): Update.
2003
2004 2019-06-25  Tom Tromey  <tom@tromey.com>
2005
2006         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2007         (tui_source_window_base::make_visible): New methods.
2008         (make_all_visible): Make method call.
2009         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2010         (struct tui_source_window_base, struct tui_cmd_window): Override
2011         make_visible.
2012         (tui_win_is_source_type): Don't declare.
2013         * tui/tui-data.c (tui_win_is_source_type): Remove.
2014
2015 2019-06-25  Tom Tromey  <tom@tromey.com>
2016
2017         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2018         NULL check.
2019
2020 2019-06-25  Tom Tromey  <tom@tromey.com>
2021
2022         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2023         Inline constructor.  Add initializers for members.
2024         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2025         constructors; now inline in class.
2026
2027 2019-06-25  Tom Tromey  <tom@tromey.com>
2028
2029         * tui/tui-regs.c (tui_show_registers): Update.
2030         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2031         bool.
2032         * tui/tui-data.c (tui_data_window::clear_detail)
2033         (tui_data_window): Update.
2034
2035 2019-06-25  Tom Tromey  <tom@tromey.com>
2036
2037         * tui/tui-windata.c (tui_display_all_data)
2038         (tui_display_data_from_line, tui_display_data_from)
2039         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2040         Update.
2041         * tui/tui-regs.c (tui_last_regs_line_no)
2042         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2043         (tui_show_registers, tui_show_register_group)
2044         (tui_display_registers_from, tui_display_reg_element_at_line)
2045         (tui_display_registers_from_line, tui_check_register_values)
2046         (tui_reg_next, tui_reg_prev): Update.
2047         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2048         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2049         tui_data_window.
2050         (struct tui_win_info) <detail>: Remove.  Add new fields from
2051         tui_data_info.
2052         (TUI_DATA_WIN): Add cast.
2053         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2054         (~tui_data_window): Simplify.
2055
2056 2019-06-25  Tom Tromey  <tom@tromey.com>
2057
2058         * tui/tui-layout.c (show_source_disasm_command)
2059         (show_source_or_disasm_and_command): Update.
2060         * tui/tui-io.c (update_cmdwin_start_line)
2061         (tui_redisplay_readline): Update.
2062         * tui/tui-data.h (struct tui_command_info): Remove.
2063         (struct tui_win_info) <detail>: Remove command_info member.
2064         (struct tui_data_window) <start_line>: New member, from
2065         tui_command_info.
2066         (TUI_CMD_WIN): Add casts.
2067
2068 2019-06-25  Tom Tromey  <tom@tromey.com>
2069
2070         * tui/tui-winsource.c (tui_update_source_window)
2071         (tui_refill_source_window)
2072         (tui_source_window_base::do_scroll_horizontal)
2073         (tui_update_breakpoint_info, tui_set_exec_info_content)
2074         (tui_show_exec_info_content, tui_erase_exec_info_content)
2075         (tui_clear_exec_info_content): Update.
2076         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2077         Update.
2078         * tui/tui-win.c (make_invisible_and_set_new_height)
2079         (make_visible_with_new_height): Update.
2080         * tui/tui-source.c (tui_set_source_content)
2081         (tui_show_symtab_source): Update.
2082         * tui/tui-layout.c (extract_display_start_addr)
2083         (show_source_disasm_command, show_data)
2084         (make_source_or_disasm_window)
2085         (show_source_or_disasm_and_command): Update.
2086         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2087         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2088         "gdbarch".
2089         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2090         to tui_source_window_base.
2091         (struct tui_win_info) <detail>: Remove source_info member.
2092         (struct tui_source_window_base) <has_locator>: Inline.
2093         Move contents from tui_source_info; rename has_locator member to
2094         m_has_locator.
2095         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2096         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2097         header file.
2098         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2099         Simplify.
2100         (tui_free_all_source_wins_content): Cast to
2101         tui_source_window_base.
2102
2103 2019-06-25  Tom Tromey  <tom@tromey.com>
2104
2105         * tui/tui-win.c (make_invisible_and_set_new_height)
2106         (make_visible_with_new_height): Call has_locator method.
2107         * tui/tui-layout.c (show_source_disasm_command, show_data)
2108         (show_source_or_disasm_and_command): Update for bool change.
2109         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2110         (tui_win_info) <has_locator>: New method.
2111         (struct tui_source_window_base) <has_locator>: New method.
2112         (tui_win_has_locator): Don't declare.
2113         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2114         from tui_win_has_locator.
2115         (tui_source_window_base): Use false, not FALSE.
2116
2117 2019-06-25  Tom Tromey  <tom@tromey.com>
2118
2119         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2120         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2121         clear_detail method directly.
2122         (tui_clear_win_detail): Remove.
2123
2124 2019-06-25  Tom Tromey  <tom@tromey.com>
2125
2126         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2127         "this", not TUI_DISASM_WIN.
2128
2129 2019-06-25  Tom Tromey  <tom@tromey.com>
2130
2131         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2132         declare.
2133         * tui/tui-winsource.c
2134         (tui_source_window_base::do_scroll_horizontal): Rename from
2135         tui_horizontal_source_scroll.
2136         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2137         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2138         from tui_vertical_data_scroll.
2139         * tui/tui-win.h (tui_scroll): Don't declare.
2140         * tui/tui-win.c (tui_win_info::forward_scroll)
2141         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2142         (tui_win_info::right_scroll): Rename and update.
2143         (tui_scroll_forward_command, tui_scroll_backward_command)
2144         (tui_scroll_left_command, tui_scroll_right_command): Update.
2145         (tui_scroll): Remove.
2146         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2147         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2148         from tui_vertical_source_scroll.
2149         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2150         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2151         from tui_vertical_disassem_scroll.
2152         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2153         do_scroll_horizontal>: New methods.
2154         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2155         Likewise.
2156         (struct tui_source_window_base): Add do_scroll_horizontal.
2157         (struct tui_source_window, struct tui_disasm_window): Add
2158         do_scroll_vertical.
2159         (struct tui_data_window, struct tui_cmd_window): Add
2160         do_scroll_horizontal and do_scroll_vertical.
2161         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2162
2163 2019-06-25  Tom Tromey  <tom@tromey.com>
2164
2165         * tui/tui-data.h (struct tui_source_window_base): New struct.
2166         (struct tui_source_window): Derive from tui_source_window_base.
2167         (struct tui_disasm_window): New struct.
2168         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2169         from tui_source_window::clear_detail.
2170         (tui_source_window_base): Rename from tui_source_window.
2171         (~tui_source_window_base): Rename from ~tui_source_window.
2172         (tui_alloc_win_info): Create a tui_disasm_window.
2173
2174 2019-06-25  Tom Tromey  <tom@tromey.com>
2175
2176         * tui/tui-data.h (struct tui_source_window)
2177         (struct tui_data_window): Declare destructors.
2178         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2179         destructors.
2180         (tui_win_info): Simplify.
2181
2182 2019-06-25  Tom Tromey  <tom@tromey.com>
2183
2184         * tui/tui-winsource.c (tui_display_main)
2185         (tui_update_source_windows_with_addr)
2186         (tui_update_all_breakpoint_info): Update.
2187         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2188         (new_height_ok, parse_scrolling_args): Update.
2189         * tui/tui-stack.c (tui_show_frame_info): Update.
2190         * tui/tui-data.h (struct tui_list): Remove.
2191         (tui_source_windows): Return a reference to a std::vector.
2192         * tui/tui-data.c (source_windows): Now a std::vector.
2193         (tui_source_windows): Change return type.
2194         (tui_clear_source_windows): Rewrite.
2195         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2196         (tui_free_all_source_wins_content): Rewrite.
2197
2198 2019-06-25  Tom Tromey  <tom@tromey.com>
2199
2200         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2201         (struct tui_data_window, struct tui_cmd_window): Declare
2202         clear_detail method.
2203         * tui/tui-data.c (tui_source_window::clear_detail)
2204         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2205         methods.
2206         (tui_clear_win_detail): Simplify.
2207
2208 2019-06-25  Tom Tromey  <tom@tromey.com>
2209
2210         * tui/tui-layout.c (make_source_window, make_disasm_window)
2211         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2212         Return the new window.
2213         (show_source_disasm_command, show_data)
2214         (show_source_or_disasm_and_command): Update.
2215
2216 2019-06-25  Tom Tromey  <tom@tromey.com>
2217
2218         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2219         parameter.  Return the new window.
2220         (show_source_disasm_command): Update and remove NULL check.
2221         (show_source_or_disasm_and_command): Update.
2222
2223 2019-06-25  Tom Tromey  <tom@tromey.com>
2224
2225         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2226
2227 2019-06-25  Tom Tromey  <tom@tromey.com>
2228
2229         * tui/tui-data.h (struct tui_win_info): Make constructor
2230         protected.  Make destructor virtual.  Add initializers.
2231         (tui_source_window, tui_data_window, tui_cmd_window): New
2232         classes.
2233         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2234         constructor.  Add "type" parameter.
2235         (tui_source_window, tui_data_window, tui_cmd_window): New
2236         constructors.
2237         (tui_alloc_win_info): Instantiate the appropriate subclass.
2238
2239 2019-06-25  Tom Tromey  <tom@tromey.com>
2240
2241         * tui/tui-win.c (tui_resize_all): Use delete.
2242         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2243         destructor.
2244         (tui_free_window): Don't declare.
2245         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2246         Update.
2247
2248 2019-06-25  Tom Tromey  <tom@tromey.com>
2249
2250         * tui/tui-data.h (struct tui_win_info): Add constructor.
2251         * tui/tui-data.c (tui_alloc_win_info): Use new.
2252         (tui_free_window): Use delete.
2253
2254 2019-06-22  Tom Tromey  <tom@tromey.com>
2255
2256         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2257         declare.
2258         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2259
2260 2019-06-22  Tom Tromey  <tom@tromey.com>
2261
2262         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2263         declare.
2264         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2265
2266 2019-06-22  Tom de Vries  <tdevries@suse.de>
2267
2268         * dwarf2read.c (create_addrmap_from_aranges)
2269         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2270         instead of '%zu'.
2271
2272 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2273
2274         * dwarf2read.h (dwarf2_section_info_def): Remove.
2275         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2276         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2277         std::vector<dwarf2_section_info>.
2278         (struct dwo_file) <~dwo_file>: Remove.
2279         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2280         types field.
2281         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2282         (dwarf2_read_debug_names): Likewise.
2283         (create_debug_types_hash_table): Change parameter type to
2284         array_view, adjust code accordingly.
2285         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2286         (partial_die_info::fixup): Likewise.
2287         (determine_prefix): Likewise.
2288         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2289
2290 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2291
2292         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2293         gdb_bfd_ref_ptr.
2294         <~dwo_file>: Remove call to gdb_bfd_unref.
2295         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2296         gdb_bfd_ref_ptr::get.
2297
2298 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2299
2300         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2301         type to htab_up.
2302         * dwarf2read.c (struct dwo_file): Initialize fields.
2303         <~dwo_file>: New.
2304         (free_dwo_file): Remove, move content to ~dwo_file.
2305         (struct dwo_file_deleter): Remove.
2306         (dwo_file_up>: Remove custom deleter.
2307         (free_dwo_files): Remove.
2308         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2309         dwo_files.
2310         (process_skeletonless_type_units): Call unique_ptr::get.
2311         (allocate_dwo_file_hash_table): Add deleter to created hash
2312         table.  Change return type to htab_up.
2313         (lookup_dwo_file_slot): Don't memset dwo_file, call
2314         unique_ptr::get.
2315         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2316         (create_dwo_unit_in_dwp_v2): Likewise.
2317         (open_and_init_dwo_file): Likewise.
2318         (free_dwo_file_from_slot): Remove.
2319
2320 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2321
2322         * dwarf2read.h (struct dwarf2_section_info) <readin,
2323         is_virtual>: Change type to bool.
2324         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2325         true instead of 1.
2326
2327 2019-06-19  Tom Tromey  <tom@tromey.com>
2328
2329         * tui/tui-data.h (tui_init_content_element): Don't declare.
2330
2331 2019-06-19  Tom Tromey  <tom@tromey.com>
2332
2333         * tui/tui-data.h (tui_init_win_info): Don't declare.
2334
2335 2019-06-19  Tom de Vries  <tdevries@suse.de>
2336
2337         * dwarf2read.h (abstract_to_concrete): Change type to
2338         std::unordered_map<sect_offset, std::vector<sect_offset>,
2339         gdb::hash_enum<sect_offset>>.
2340
2341 2019-06-19  Tom Tromey  <tromey@adacore.com>
2342
2343         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2344         EVAL_AVOID_SIDE_EFFECTS specially.
2345
2346 2019-06-19  Tom Tromey  <tromey@adacore.com>
2347
2348         * source-cache.c (highlighter): New global.
2349         (source_cache::get_source_lines): Create a highlighter on demand.
2350
2351 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2352
2353         * defs.h (deprecated_interactive_hook): Delete declaration.
2354         * interps.c (clear_interpreter_hooks): Remove use of
2355         deprecated_interactive_hook.
2356         * top.c (deprecated_interactive_hook): Delete definition.
2357         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2358
2359 2019-06-18  Tom de Vries  <tdevries@suse.de>
2360
2361         PR gdb/24515
2362         * dwarf2read.h (abstract_to_concrete): Change type from
2363         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2364         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2365         * dwarf2read.c (read_variable): Update.
2366         (dwarf2_fetch_die_loc_sect_off): Update.
2367
2368 2019-06-17  Tom de Vries  <tdevries@suse.de>
2369
2370         PR gdb/24617
2371         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2372         accessing parent[parent_len - 1].
2373
2374 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2375
2376         PR gdb/24364
2377         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2378         call dtrace_process_dof with NULL dof.
2379
2380 2019-06-16  Tom de Vries  <tdevries@suse.de>
2381
2382         PR gdb/24445
2383         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2384
2385 2019-06-16  Tom Tromey  <tom@tromey.com>
2386
2387         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2388         (make_all_visible): Use address of member.
2389
2390 2019-06-16  Tom Tromey  <tom@tromey.com>
2391
2392         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2393         (tui_free_window, free_content, free_content_elements): Remove
2394         unnecessary cast.
2395         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2396         cast.
2397         * tui/tui-regs.c (tui_show_register_group)
2398         (tui_display_registers_from, tui_display_reg_element_at_line):
2399         Remove unnecessary cast.
2400
2401 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2402
2403         * linux-nat.c (normal_mask): Delete.
2404         (_initialize_linux_nat): Don't initialise normal_mask.
2405
2406 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2407
2408         PR gdb/24445
2409         * dwarf-index-write.h (write_psymtabs_to_index): Add
2410         dwz_basename parameter.
2411         * dwarf-index-write.c (write_gdbindex): Move file writing to
2412         write_gdbindex_1.  Change return type void.
2413         (assert_file_size): Move up, remove filename parameter.
2414         (write_gdbindex_1): New function.
2415         (write_debug_names): Change return type to void, call
2416         assert_file_size.
2417         (struct index_wip_file): New struct.
2418         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2419         file logic to index_wip_file.  Write index for dwz file if
2420         needed.
2421         (save_gdb_index_command): Pass basename of dwz file, if present.
2422         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2423         build-id of dwz file, if present.
2424         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2425         (dwarf2_get_dwz_file): Likewise.
2426         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2427         (dwarf2_get_dwz_file): Likewise.
2428
2429 2019-06-16  Tom Tromey  <tom@tromey.com>
2430
2431         * coffread.c (process_coff_symbol): Use xstrdup.
2432         * value.c (create_internalvar): Use xstrdup.
2433
2434 2019-06-16  Tom Tromey  <tom@tromey.com>
2435
2436         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2437         * breakpoint.c (stopin_command, stopat_command)
2438         (until_break_command, decode_location_default): Remove unnecessary
2439         cast.
2440         * utils.c (subset_compare): Remove unnecessary cast.
2441         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2442         cast.
2443         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2444         cast.
2445         * infcmd.c (path_command): Remove unnecessary cast.
2446         * coffread.c (decode_type): Remove unnecessary cast.
2447         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2448         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2449         * tui/tui-stack.c (tui_show_locator_content)
2450         (tui_show_frame_info): Remove unnecessary cast.
2451         * tui/tui-win.c (tui_scroll_forward_command)
2452         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2453         (parse_scrolling_args): Remove unnecessary cast.
2454         * tui/tui-data.c (init_win_info, tui_del_window)
2455         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2456         (free_content_elements): Remove unnecessary cast.
2457         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2458         unnecessary cast.
2459         * tui/tui-source.c (tui_set_source_content)
2460         (tui_vertical_source_scroll): Remove unnecessary cast.
2461         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2462         cast.
2463         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2464         * tui/tui-regs.c (tui_display_registers_from)
2465         (tui_display_register): Remove unnecessary cast.
2466         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2467         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2468         (make_visible): Remove unnecessary cast.
2469         * tui/tui-winsource.c (tui_erase_source_content)
2470         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2471         unnecessary cast.
2472         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2473         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2474         * stabsread.c (read_type, read_array_type, read_range_type):
2475         Remove unnecessary cast.
2476         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2477         (parse_symbol, parse_type, upgrade_type, parse_external)
2478         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2479         unnecessary cast.
2480         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2481
2482 2019-06-16  Tom Tromey  <tom@tromey.com>
2483
2484         * tui/tui-data.c (tui_alloc_generic_win_info)
2485         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2486         checks.
2487
2488 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2489             Andrew Burgess  <andrew.burgess@embecosm.com>
2490
2491         * f-typeprint.c (f_print_type): Don't return early for not
2492         associated or not allocated types.
2493         (f_type_print_varspec_suffix): Add print_rank parameter and print
2494         ranks of array types in case they dangling.
2495         (f_type_print_base): Add print_rank parameter.
2496
2497 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2498
2499         * NEWS: Mention new MI commands.
2500         * break-catch-throw.c (enum exception_event_kind): Move to
2501         breakpoint.h.
2502         (print_mention_exception_catchpoint): Output text as a single
2503         message.
2504         (catch_exception_command_1): Rename to...
2505         (catch_exception_event): ...this, make non-static, update header
2506         command, and change some parameter types.
2507         (catch_catch_command): Update for changes to
2508         catch_exception_command_1.
2509         (catch_throw_command): Likewise.
2510         (catch_rethrow_command): Likewise.
2511         * breakpoint.c (enum exception_event_kind): Delete.
2512         * breakpoint.h (enum exception_event_kind): Moved here from
2513         break-catch-throw.c.
2514         (catch_exception_event): Declare.
2515         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2516         (mi_cmd_catch_throw): New function.
2517         (mi_cmd_catch_rethrow): New function.
2518         (mi_cmd_catch_catch): New function.
2519         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2520         'catch-catch' entries.
2521         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2522         (mi_cmd_catch_rethrow): Declare.
2523         (mi_cmd_catch_catch): Declare.
2524
2525 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2526
2527         * annotate.c (annotate_source_line): Change return type to void,
2528         update implementation to match.
2529         * annotate.h (annotate_source_line): Change return type to void,
2530         update header comment.
2531         * stack.c (print_frame_info): Don't change what frame information
2532         is printed based on whether annotations are on or not.
2533
2534 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2535
2536         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2537         (annotate_source): Make static.
2538         (annotate_source_line): Moved from source.c and renamed from
2539         identify_source_line.  Update the return type.
2540         * annotate.h (annotate_source): Delete declaration.
2541         (annotate_source_line): Declaration moved from source.h, and
2542         renamed from identify_source_line.  Return type updated.
2543         * source.c (identify_source_line): Moved to annotate.c and renamed
2544         to annotate_source_line.
2545         (info_line_command): Remove check of annotation_level.
2546         * source.h (identify_source_line): Move declaration to annotate.h
2547         and rename to annotate_source_line.
2548         * stack.c: Add 'annotate.h' include.
2549         (print_frame_info): Remove check of annotation_level before
2550         calling annotate_source_line.
2551
2552 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2553
2554         * source-cache.c (source_cache::get_plain_source_lines): Use
2555         open_source_file_with_line_charpos instead of just
2556         open_source_file, remove call to find_source_lines.
2557         (source_cache::get_source_lines): Likewise.
2558         * source.c (find_source_lines): Make static.
2559         (get_filename_and_charpos): Renamed into...
2560         (open_source_file_with_line_charpos): ..this along with changes to
2561         return a scoped_fd, and some other minor clean ups.
2562         (identify_source_line): Use open_source_file_with_line_charpos.
2563         (search_command_helper): Use open_source_file_with_line_charpos
2564         instead of just open_source_file, remove call to
2565         find_source_lines.
2566         * source.h (open_source_file_with_line_charpos): Declare new
2567         function.
2568         (find_source_lines): Delete declaration.
2569
2570 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2571
2572         * source.c (get_filename_and_charpos): Remove fullname
2573         parameter.
2574         (identify_source_line): Update call to get_filename_and_charpos.
2575
2576 2019-06-14  Tom Tromey  <tromey@adacore.com>
2577
2578         PR gdb/24502:
2579         * ui-style.h (skip_ansi_escape): Update comment.
2580         * ui-file.h (class no_terminal_escape_file): New class.
2581         * ui-file.c (no_terminal_escape_file::write)
2582         (no_terminal_escape_file::puts): New methods.
2583         * cli/cli-logging.c (handle_redirections): Use
2584         no_terminal_escape_file.
2585
2586 2019-06-14  Tom Tromey  <tromey@adacore.com>
2587
2588         * NEWS: Move convenience variable news above Python news.
2589
2590 2019-06-14  Tom Tromey  <tom@tromey.com>
2591
2592         * gnulib: Move directory to top-level.
2593         * configure.ac: Don't configure gnulib.
2594         * configure: Rebuild.
2595         * common/common-defs.h: Use new path to gnulib.
2596         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2597         (GNULIB_H): Remove.
2598         (INCGNU): Look in new gnulib location.
2599         (HFILES_NO_SRCDIR): Remove gnulib files.
2600         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2601         (generated_files): Remove GNULIB_H.
2602         ($(LIBGNU), all-lib): Remove targets.
2603         (distclean): Don't mention GNULIB_BUILDDIR.
2604         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2605
2606 2019-06-14  Tom Tromey  <tromey@adacore.com>
2607
2608         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2609         Warn if symbol file does not provide any symbols.
2610
2611 2019-06-14  Tom Tromey  <tromey@adacore.com>
2612
2613         * source.c (find_and_open_source): Respect basenames_may_differ.
2614
2615 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2616
2617         * annotate.c (annotate_breakpoints_invalid): Make use of
2618         scoped_restore_terminal_state.
2619         (annotate_frames_invalid): Likewise.
2620
2621 2019-06-14  Tom Tromey  <tromey@adacore.com>
2622
2623         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2624         allow assignment to an internalvar.
2625
2626 2019-06-14  Tom Tromey  <tromey@adacore.com>
2627
2628         * ada-lex.l: Allow "_" in attribute names.
2629
2630 2019-06-14  Tom Tromey  <tromey@adacore.com>
2631
2632         PR gdb/24653:
2633         * regcache.c (registers_changed): Don't call alloca.
2634         * top.c (execute_command): Don't call alloca.
2635
2636 2019-06-13  Pedro Alves  <palves@redhat.com>
2637
2638         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2639         'expression'.  When parsing an expression, error out if there's
2640         junk after "unlimited".
2641         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2642         (do_set_command): Adjust calls to is_unlimited_literal.
2643
2644 2019-06-13  Pedro Alves  <palves@redhat.com>
2645
2646         * compile/compile.c (make_compile_options_def_group): Add braces
2647         around array_view initializer.
2648         * thread.c (make_thread_apply_all_options_def_group)
2649         (make_thread_apply_all_options_def_group): Likewise.
2650
2651 2019-06-13  Pedro Alves  <palves@redhat.com>
2652
2653         * NEWS (New commands): Mention "maint test-options
2654         require-delimiter", "maint test-options unknown-is-error", "maint
2655         test-options unknown-is-operand" and "maint show
2656         test-options-completion-result".
2657         (New command options, command completion): New section.
2658         (Completion improvements): New section.
2659         Mention that you can abbreviate "unlimited".
2660
2661 2019-06-13  Pedro Alves  <palves@redhat.com>
2662
2663         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2664         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2665         * unittests/cli-utils-selftests.c (test_parse_flags)
2666         (test_parse_flags_qcs): Delete.
2667         (test_cli_utils): Don't call deleted functions.
2668
2669 2019-06-13  Pedro Alves  <palves@redhat.com>
2670
2671         * thread.c: Include "cli/cli-option.h".
2672         (tp_array_compar_ascending): Global.
2673         (tp_array_compar): Delete function.
2674         (tp_array_compar_ascending, tp_array_compar_descending): New
2675         functions.
2676         (ascending_option_def, qcs_flag_option_def)
2677         (thr_qcs_flags_option_defs)
2678         (make_thread_apply_all_options_def_group)
2679         (make_thread_apply_options_def_group): New.
2680         (thread_apply_all_command): Use gdb::option::process_options.
2681         (thread_apply_command_completer)
2682         (thread_apply_all_command_completer): New.
2683         (thread_apply_command): Use gdb::option::process_options.
2684         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2685         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2686         to generate help text of "thread apply".  Adjust "taas"'s help.
2687         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2688         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2689
2690 2019-06-13  Pedro Alves  <palves@redhat.com>
2691
2692         * thread.c (thread_apply_command): Check for invalid TID with
2693         isdigit instead of !isalpha.
2694
2695 2019-06-13  Pedro Alves  <palves@redhat.com>
2696
2697         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2698         (validate_flags_qcs): New.
2699         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2700         (validate_flags_qcs): Declare.
2701         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2702         (make_frame_apply_options_def_group): New.
2703         (frame_apply_command_count): Process options with
2704         gdb::option::process_options.
2705         (frame_apply_completer): New.
2706         (frame_apply_level_completer, frame_apply_all_completer)
2707         (frame_apply_completer): New.
2708         (_initialize_stack): Update help of "frame apply", "frame apply
2709         level", "frame apply all" and "faas" to mention supported options
2710         and install command completers.
2711         * stack.h (frame_apply_all_completer): Declare.
2712         * thread.c: Include "stack.h".
2713         (tfaas_command): Add "--".
2714         (_initialize_thread): Update help "tfaas" to mention supported
2715         options and install command completer.
2716
2717 2019-06-13  Pedro Alves  <palves@redhat.com>
2718
2719         * completer.c (complete_nested_command_line): New.
2720         (gdb_completion_word_break_characters_throw): Add assertion.
2721         * completer.h (complete_nested_command_line): Declare.
2722
2723 2019-06-13  Pedro Alves  <palves@redhat.com>
2724
2725         * stack.c (parse_backtrace_qualifiers): New.
2726         (backtrace_command): Use it.
2727         (backtrace_command_completer): Complete on qualifiers.
2728
2729 2019-06-13  Pedro Alves  <palves@redhat.com>
2730
2731         * frame.c: Include "cli/cli-option.h.
2732         (user_set_backtrace_options): New.
2733         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2734         Delete.
2735         (get_prev_frame): Adjust.
2736         (boolean_option_def, uinteger_option_def)
2737         (set_backtrace_option_defs): New.
2738         (_initialize_frame): Adjust and use
2739         gdb::option::add_setshow_cmds_for_options to install "set
2740         backtrace past-main" and "set backtrace past-entry".
2741         * frame.h: Include "cli/cli-option.h".
2742         (struct frame_print_options): Forward declare.
2743         (print_frame_arguments_all, print_frame_arguments_scalars)
2744         (print_frame_arguments_none): Declare.
2745         (print_entry_values): Delete declaration.
2746         (struct frame_print_options, user_frame_print_options): New.
2747         (struct set_backtrace_options): New.
2748         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2749         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2750         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2751         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2752         (list_args_or_locals): Add frame_print_options parameter.
2753         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2754         * python/py-framefilter.c (enumerate_args): Pass down
2755         USER_FRAME_PRINT_OPTIONS.
2756         * stack.c: Include "cli/cli-option.h".
2757         (print_frame_arguments_all, print_frame_arguments_scalars)
2758         (print_frame_arguments_none): Declare.
2759         (print_raw_frame_arguments, print_entry_values): Delete.
2760         (user_frame_print_options): New.
2761         (boolean_option_def, enum_option_def, frame_print_option_defs):
2762         New.
2763         (struct backtrace_cmd_options): New.
2764         (bt_flag_option_def): New.
2765         (backtrace_command_option_defs): New.
2766         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2767         (print_frame_arg, read_frame_arg, print_frame_args)
2768         (print_frame_info, print_frame): Add frame_print_options parameter
2769         and use it.
2770         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2771         (backtrace_command_1): Add frame_print_options and
2772         backtrace_cmd_options parameters and use them.
2773         (make_backtrace_options_def_group): New.
2774         (backtrace_command): Process command options with
2775         gdb::option::process_options.
2776         (backtrace_command_completer): New.
2777         (_initialize_stack): Extend "backtrace"'s help to mention
2778         supported options.  Install completer for "backtrace".
2779         Install some settings commands with add_setshow_cmds_for_options.
2780
2781 2019-06-13  Pedro Alves  <palves@redhat.com>
2782
2783         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2784         and that "set/show print raw frame-arguments" are now deprecated.
2785
2786         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2787         command.
2788         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2789         * stack.c (_initialize_stack): Install "set/show print
2790         raw-frame-arguments", and deprecate "set/show print raw
2791         frame-arguments".
2792         * valprint.c (_initialize_valprint): Deprecate "set/show print
2793         raw".
2794
2795 2019-06-13  Pedro Alves  <palves@redhat.com>
2796
2797         * compile/compile.c (struct compile_options): New.
2798         (compile_flag_option_def, compile_command_option_defs)
2799         (make_compile_options_def_group): New.
2800         (compile_file_command): Handle options with
2801         gdb::option::process_options.
2802         (compile_file_command_completer): New function.
2803         (compile_code_command): Handle options with
2804         gdb::option::process_options.
2805         (compile_code_command_completer): New function.
2806         (_initialize_compiler): Install completers for "compile code" and
2807         "compile file".  Mention available options in "compile code" and
2808         "compile code"'s help.
2809         * completer.c (advance_to_completion_word): New, factored out from
2810         ...
2811         (advance_to_expression_complete_word_point): ... this.
2812         (advance_to_filename_complete_word_point): New.
2813         * completer.h (advance_to_filename_complete_word_point): New
2814         declaration.
2815
2816 2019-06-13  Pedro Alves  <palves@redhat.com>
2817
2818         * compile/compile.c: Include "cli/cli-option.h".
2819         (compile_print_value): Scope data pointer is now a
2820         value_print_options pointer; adjust.
2821         (compile_print_command): Process options.  Scope data pointer is
2822         now a value_print_options pointer; adjust.
2823         (_initialize_compile): Update "compile print"'s help to include
2824         supported options.  Install a completer for "compile print".
2825         * cp-valprint.c (show_vtblprint, show_objectprint)
2826         (show_static_field_print): Delete.
2827         (_initialize_cp_valprint): Don't install "set print
2828         static-members", "set print vtbl", "set print object" here.
2829         * printcmd.c: Include "cli/cli-option.h" and
2830         "common/gdb_optional.h".
2831         (print_command_parse_format): Rework to fill in a
2832         value_print_options instead of a format_data.
2833         (print_value): Change parameter type from format_data pointer to
2834         value_print_options reference.  Adjust.
2835         (print_command_1): Process options.  Adjust to pass down a
2836         value_print_options.
2837         (print_command_completer): New.
2838         (_initialize_printcmd): Install print_command_completer as
2839         handle_brkchars completer for the "print" command.  Update
2840         "print"'s help to include supported options.
2841         * valprint.c: Include "cli/cli-option.h".
2842         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2843         here from cp-valprint.c.
2844         (boolean_option_def, uinteger_option_def)
2845         (value_print_option_defs, make_value_print_options_def_group):
2846         New.  Use gdb::option::add_setshow_cmds_for_options to install
2847         "set print elements", "set print null-stop", "set print repeats",
2848         "set print pretty", "set print union", "set print array", "set
2849         print address", "set print symbol", "set print array-indexes".
2850         * valprint.h: Include <string> and "cli/cli-option.h".
2851         (make_value_print_options_def_group): Declare.
2852         (print_value): Change parameter type from format_data pointer to
2853         value_print_options reference.
2854         (print_command_completer): Declare.
2855
2856 2019-06-13  Pedro Alves  <palves@redhat.com>
2857
2858         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2859         (COMMON_SFILES): Add maint-test-settings.c.
2860         * cli/cli-decode.c (boolean_enums): New global, factored out from
2861         ...
2862         (add_setshow_boolean_cmd): ... here.
2863         * cli/cli-decode.h (boolean_enums): Declare.
2864         * cli/cli-option.c: New file.
2865         * cli/cli-option.h: New file.
2866         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2867         factored out from ...
2868         (parse_cli_boolean_value(const char *)): ... this.
2869         (is_unlimited_literal): Change parameter type to pointer to
2870         pointer.  Adjust and advance ARG pointer.
2871         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2872         (parse_cli_var_enum): New, factored out from ...
2873         (do_set_command): ... this.  Adjust.
2874         * cli/cli-setshow.h (parse_cli_boolean_value)
2875         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2876         (parse_cli_var_enum): Declare.
2877         * cli/cli-utils.c: Include "cli/cli-option.h".
2878         (get_ulongest): New.
2879         * cli/cli-utils.h (get_ulongest): Declare.
2880         (check_for_argument): New overloads.
2881         * maint-test-options.c: New file.
2882
2883 2019-06-13  Pedro Alves  <palves@redhat.com>
2884
2885         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2886         parse a range if "-" is at the end of the string.
2887
2888 2019-06-13  Pedro Alves  <palves@redhat.com>
2889
2890         * cli/cli-setshow.c (parse_auto_binary_operation)
2891         (parse_cli_boolean_value): Don't allow "o".
2892
2893 2019-06-13  Pedro Alves  <palves@redhat.com>
2894
2895         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2896         * NEWS: Mention maint test-settings KIND.
2897         * maint-test-settings.c: New file.
2898
2899 2019-06-13  Pedro Alves  <palves@redhat.com>
2900
2901         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2902         completer.
2903         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2904         "set" completers.
2905
2906 2019-06-13  Pedro Alves  <palves@redhat.com>
2907
2908         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2909         after item.
2910
2911 2019-06-13  Pedro Alves  <palves@redhat.com>
2912
2913         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2914
2915 2019-06-13  Pedro Alves <palves@redhat.com>
2916
2917         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2918         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2919         call.
2920         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2921         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2922         calls.
2923         (check_for_argument): Skip spaces after argument.
2924
2925 2019-06-13  Pedro Alves  <palves@redhat.com>
2926
2927         * thread.c (thread_apply_command): Adjust TID parsing.
2928         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2929         detected before end of string.
2930         (tid_is_in_list): Error out if LIST is invalid.
2931
2932 2019-06-13  Pedro Alves  <palves@redhat.com>
2933
2934         * completer.c (complete_line_internal_1): Rewind completion word
2935         point.
2936         (completion_tracker::advance_custom_word_point_by): Change
2937         parameter type to int.
2938         * completer.h (completion_tracker::advance_custom_word_point_by):
2939         Likewise.
2940
2941 2019-06-13  Pedro Alves  <palves@redhat.com>
2942
2943         * completer.c (advance_to_completion_word): Handle delimiters.
2944
2945 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2946
2947         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2948
2949 2019-06-11  Tom Tromey  <tom@tromey.com>
2950
2951         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2952         (xmalloc_failed): Move to alloc.c.
2953         * alloc.c: New file.
2954         * Makefile.in (COMMON_SFILES): Add alloc.c.
2955
2956 2019-06-11  Tom Tromey  <tom@tromey.com>
2957
2958         * nat/linux-waitpid.c: Don't include server.h.
2959         (linux_debug): Remove.
2960         (my_waitpid): Update.
2961
2962 2019-06-11  Tom Tromey  <tromey@adacore.com>
2963
2964         * infcall.c (_initialize_infcall): Remove trailing newline from
2965         help.
2966         * user-regs.c (_initialize_user_regs): Remove trailing newline
2967         from help.
2968         * typeprint.c (_initialize_typeprint): Remove trailing newline
2969         from help.
2970         * reverse.c (_initialize_reverse): Remove trailing newlines from
2971         help.
2972         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2973         from help.
2974         * language.c (add_set_language_command): Remove trailing newline
2975         from help.
2976         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2977         help.
2978         * disasm.c (_initialize_disasm): Remove trailing newline from
2979         help.
2980         * top.c (init_main): Remove trailing newline from help.
2981         * interps.c (_initialize_interpreter): Remove trailing newline
2982         from help.
2983         * btrace.c (_initialize_btrace): Remove trailing newlines from
2984         help.
2985         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2986         from help.
2987         * python/python.c (_initialize_python): Remove trailing newline
2988         from help.
2989         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2990         help.
2991         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2992         from help.  Reformat some text.
2993         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2994         from help.
2995         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2996         newline from help.
2997
2998 2019-06-11  Tom Tromey  <tromey@adacore.com>
2999
3000         * darwin-nat.c (darwin_decode_exception_message)
3001         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3002
3003 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3004
3005         * valops.c (value_slice): Check for not allocated or not
3006         associated values.
3007
3008 2019-06-10  Tom de Vries  <tdevries@suse.de>
3009
3010         PR gdb/24618
3011         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3012         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3013         invalid.
3014
3015 2019-06-10  Tom de Vries  <tdevries@suse.de>
3016
3017         PR gdb/24611
3018         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3019         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3020
3021 2019-06-10  Tom de Vries  <tdevries@suse.de>
3022
3023         PR symtab/24545
3024         * symtab.c (struct demangled_name_entry): Add language field.
3025         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3026         static minimal symbol".  Set and use language field.
3027
3028 2019-06-10  Tom Tromey  <tromey@adacore.com>
3029
3030         * ada-lang.c (_initialize_ada_language): Update help text.
3031
3032 2019-06-10  Tom Tromey  <tromey@adacore.com>
3033
3034         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3035         with a newline.
3036         * guile/guile.c (handle_boot_error): Don't end warning with a
3037         newline.
3038         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3039         warning with a newline.
3040         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3041         newline.
3042         (s12z_frame_cache): Likewise.
3043         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3044         a newline.
3045         * solib-svr4.c (disable_probes_interface): Don't end warning with
3046         a newline.
3047         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3048         newline.
3049         * python/python.c (do_finish_initialization): Don't end warning
3050         with a newline.
3051
3052 2019-06-10  Tom Tromey  <tom@tromey.com>
3053
3054         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3055         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3056         gdbpy_enter.
3057
3058 2019-06-10  Tom Tromey  <tromey@adacore.com>
3059
3060         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3061         data.
3062         (elf_new_init): Don't call stabsread_new_init.
3063         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3064         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3065         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3066
3067 2019-06-10  Tom de Vries  <tdevries@suse.de>
3068
3069         PR symtab/16264
3070         PR symtab/24517
3071         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3072
3073 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3074
3075         * source.c (find_and_open_source): Also rewrite relative file
3076         names.
3077
3078 2019-04-26  Amos Bird  <amosbird@gmail.com>
3079
3080         * annotate.c (annotate_thread_exited): Add "thread-exited"
3081         annotation.
3082
3083 2019-06-06  Tom Tromey  <tromey@adacore.com>
3084
3085         * maint.h (class scoped_command_stats): Use
3086         DISABLE_COPY_AND_ASSIGN.
3087         <print_time>: New method.
3088         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3089         print_time.
3090         (scoped_command_stats::print_time): New method.
3091
3092 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3093
3094         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3095         instructions of lengths 6 or 8 bytes.
3096
3097 2019-06-04  Pedro Alves  <palves@redhat.com>
3098
3099         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3100
3101         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3102         * breakpoint.c (condition_completer): Likewise.
3103         * cli/cli-dump.c (scan_expression): Likewise.
3104         * common/filestuff.c (mkdir_recursive): Likewise.
3105         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3106         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3107         (gdb_abspath): Likewise.
3108         * compile/compile-cplus-types.c
3109         (compile_cplus_instance::decl_name): Likewise.
3110         * completer.c (complete_explicit_location):
3111         (signal_completer, reg_or_group_completer_1): Likewise.
3112         * cp-support.c (cp_remove_params_if_any): Likewise.
3113         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3114         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3115         * infcmd.c (strip_bg_char): Likewise.
3116         * linespec.c (copy_token_string): Likewise.
3117         * mi/mi-main.c (output_cores): Likewise.
3118         * psymtab.c (psymtab_search_name):
3119         * symfile.c (test_set_ext_lang_command): Likewise.
3120         * target.c (target_fileio_read_stralloc): Likewise.
3121         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3122         * value.c (complete_internalvar): Likewise.
3123
3124 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3125
3126         Add objfile property to gdb.Type.
3127         * NEWS: Mention Python API addition.
3128         * python/py-type.c (typy_get_objfile): New method.
3129
3130 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3131
3132         * NEWS: Mention the new set|show style [title|highlight].
3133         Mention changes to "show style", "help" and "apropos".
3134
3135 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3136
3137         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3138         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3139         instead of print_help_for_command.
3140         (print_doc_of_command): New function.
3141         (help_list): Add 'apropos -v word' suggestion.
3142         (print_help_for_command): Style the command name using title style.
3143         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3144         (_initialize_cli_cmds): Describe -v in apropos_command help.
3145
3146 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3147
3148         * cli/cli-style.h (cli_style_option): Add name in constructor,
3149         add m_name class member, add constructor with intensity,
3150         add name class function.
3151         (cli_style_option::add_setshow_commands): Remove name argument.
3152         (highlight_style, title_style): New styles.
3153         * cli/cli-style.c (do_show): New function that shows a style
3154         characteristic styling the style name with itself.
3155         (set_style_name): New function.
3156         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3157         Update all callers according to the changes in cli/cli-style.h.
3158         * utils.h (fputs_highlighted): New function.
3159         * utils.c (fputs_highlighted): Likewise.
3160
3161 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3162
3163         * NEWS: Mention new pipe command and new convenience variables.
3164
3165 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3166
3167         * cli/cli-cmds.c (pipe_command): New function.
3168         (_initialize_cli_cmds): Call add_com for pipe_command.
3169         Define | as an alias for pipe.
3170         (exit_status_set_internal_vars): New function.
3171         (shell_escape): Call exit_status_set_internal_vars.
3172         cli/cli-decode.c (find_command_name_length): Recognize | as
3173         a single character command.
3174
3175 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3176
3177         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3178         top.c (execute_command_to_ui_file): New function, mostly a copy
3179         of execute_command_to_string.
3180         (execute_command_to_string): Implement by calling
3181         execute_command_to_ui_file.
3182
3183 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3184
3185         * top.h (saved_command_line): Remove declaration.
3186         * top.c (previous_saved_command_line, previous_repeat_arguments):
3187         New variables.
3188         (saved_command_line): Make static, define together with other
3189         'repeat variables'.
3190         (dont_repeat): Clear repeat_arguments.
3191         (repeat_previous, get_saved_command_line, save_command_line):
3192         New functions.
3193         (gdb_init): Initialize saved_command_line
3194         and previous_saved_command_line.
3195         * main.c (captured_main_1): Remove saved_command_line initialization.
3196         * event-top.c (handle_line_of_input): Update to use
3197         the new 'repeat' related functions instead of direct access to
3198         saved_command_line.
3199         * command.h (repeat_previous, get_saved_command_line,
3200         save_command_line): New declarations.
3201         (dont_repeat): Add comment.
3202
3203 2019-05-30  Tom Tromey  <tromey@adacore.com>
3204
3205         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3206         Fix comment.
3207         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3208
3209 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3210
3211         PR cli/24587
3212         * completer.c (complete): Initialize variable word.
3213
3214 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3215
3216         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3217         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3218         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3219         'body' is NULL to the outter 'if', protecting the '!is_define'
3220         situation as well.
3221
3222 2019-05-29  Tom Tromey  <tromey@adacore.com>
3223
3224         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3225         (dwarf_unknown): New function.
3226         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3227         (dwarf_type_encoding_name): Use dwarf_unknown.
3228
3229 2019-05-29  Tom Tromey  <tromey@adacore.com>
3230
3231         PR c++/20020:
3232         * cp-valprint.c (cp_print_value_fields): Call
3233         cp_print_static_field inside "try".
3234
3235 2019-05-29  Tom Tromey  <tromey@adacore.com>
3236
3237         * inflow.c (struct terminal_info): Add default operator=.
3238         * configure: Rebuild.
3239         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3240         -Wdeprecated-copy-dtor, -Wredundant-move.
3241
3242 2019-05-29  Tom Tromey  <tromey@adacore.com>
3243
3244         * NEWS: Add entry.
3245         * infcmd.c (print_return_value_1): Handle finish_print
3246         option.
3247         (show_print_finish): New function.
3248         (_initialize_infcmd): Add "set/show print finish" commands.
3249         * valprint.c (user_print_options): Initialize new member.
3250         * valprint.h (struct value_print_options) <finish_print>: New
3251         member.
3252
3253 2019-05-28  Tom Tromey  <tromey@adacore.com>
3254
3255         * ada-lang.c (ada_remove_Xbn_suffix)
3256         (find_old_style_renaming_symbol)
3257         (parse_old_style_renaming): Remove.
3258         (ada_find_renaming_symbol): Don't call
3259         find_old_style_renaming_symbol.
3260         (ada_is_renaming_symbol): Rename from
3261         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3262         bool.  Now static.
3263         (ada_read_var_value): Update and simplify.
3264         * ada-exp.y (write_var_or_type): Remove old code.
3265
3266 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3267
3268         * event-top.c: Remove include comment.
3269         * inflow.c (class scoped_ignore_sigttou): Move from here...
3270         * inflow.h (class scoped_ignore_sigttou): ...to here.
3271         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3272         * top.c:  Remove include comment.
3273
3274 2019-05-27  Tom Tromey  <tom@tromey.com>
3275
3276         * NEWS: Fix typo.
3277
3278 2019-05-22  Tom Tromey  <tromey@adacore.com>
3279
3280         * target.c (target_follow_exec): Constify parameter.
3281         * target-delegates.c: Rebuild.
3282         * remote.c (remote_target::follow_exec): Constify parameter.
3283         * infrun.c (follow_exec): Constify parameter.
3284         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3285         (target_follow_exec): Likewise.
3286
3287 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3288
3289         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3290         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3291
3292 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3293
3294         * NEWS: Add debugredirect and testsuite sections.
3295
3296 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3297
3298         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3299         target descriptions using exclusively floating point register name
3300         aliases.
3301
3302 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3303
3304         PR gdb/18644:
3305         * f-lang.c (build_fortran_types): Handle the case where
3306         gdbarch_floatformat_for_type returns a nullptr.
3307
3308 2019-05-21  Tom de Vries  <tdevries@suse.de>
3309
3310         PR cli/24587
3311         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3312
3313 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3314
3315         PR gdb/18644:
3316         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3317         16-byte floats.
3318         * i386-tdep.c (i386_floatformat_for_type): Use
3319         floatformats_ia64_quad for the 16-byte floating point component
3320         within a fortran 32-byte complex number.
3321
3322 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3323
3324         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3325         delete default constructor.
3326         (find_partial_die): Update to return const struct.
3327         (partial_die_parent_scope): Move variable declaration into scope
3328         of its use and change its type to auto.
3329         (guess_partial_die_structure_name): Likewise.
3330         (partial_die_info::fixup): Likewise.
3331
3332 2019-05-17  Tom Tromey  <tromey@adacore.com>
3333
3334         * source.c (find_and_open_source): Remove cast.
3335
3336 2019-05-17  Tom Tromey  <tromey@adacore.com>
3337
3338         * annotate.c (annotate_source): Make "filename" const.
3339         * annotate.h (annotate_source): Use const.
3340
3341 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3342
3343         * disasm.c (set_disassembler_options): Send errors to stderr.
3344
3345 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3346
3347         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3348         (cli_interp_base::set_logging): Check debug_redirect.
3349         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3350         * cli/cli-logging.c (debug_redirect): Add static variable.
3351         (pop_output_files): Add default param.
3352         (handle_redirections): Print debug setting.
3353         (show_logging_command): Likewise.
3354         (_initialize_cli_logging): Add debugredirect command.
3355         * interps.c (current_interp_set_logging): Add debug_redirect
3356         parameter.
3357         * interps.h (set_logging): Add debug_redirect parameter.
3358         (current_interp_set_logging): Likewise.
3359         * mi/mi-common.h: Likewise.
3360         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3361
3362 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3363             Tom Tromey  <tromey@adacore.com>
3364
3365         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3366         directly.
3367         * cli/cli-interp.h (make_logging_output): Remove declaration.
3368         * cli/cli-logging.c (make_logging_output): Remove function.
3369         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3370         directly.
3371         * ui-file.c (tee_file::tee_file): Remove bools.
3372         (tee_file::~tee_file): Remove deletes.
3373         * ui-file.h (tee_file): Remove bools.
3374
3375 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3376
3377         * mi/mi-cmds.h (mi_cmd_complete): New function.
3378         * mi/mi-main.c (mi_cmd_complete): Likewise.
3379         * mi/mi-cmds.c: Define new MI command -complete.
3380         * NEWS: Mention new -complete command.
3381
3382 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3383
3384         * completer.h (complete): New function.
3385         * completer.c (complete): Likewise.
3386         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3387         function defined in completer.h.
3388
3389 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3390
3391         * MAINTAINERS (Write After Approval): Add myself.
3392
3393 2019-05-17  Tom de Vries  <tdevries@suse.de>
3394
3395         PR gdb/24094
3396         * dwarf2read.c (struct cu_partial_die_info): New struct.
3397         (find_partial_die): Return cu_partial_die_info.
3398         (partial_die_parent_scope, guess_partial_die_structure_name)
3399         (partial_die_info::fixup): Handle new return type of find_partial_die.
3400
3401 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3402
3403         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3404         "std::string", simplifying the algorithm.
3405
3406 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3407
3408         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3409         (stap_static_probe_ops::get_probes): Likewise.
3410
3411 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3412
3413         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3414         '-')" and "else if".
3415         (stap_parse_single_operand): Join checks for
3416         "gdbarch_stap_parse_special_token_p" and
3417         "gdbarch_stap_parse_special_token" in the same "if" statement.
3418         Invert check when verifying for operation on register
3419         displacement.
3420
3421 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3422
3423         * stap-probe.c (stap_get_opcode): Update comment.
3424         (stap_get_expected_argument_type): Likewise.
3425         (handle_stap_probe): Likewise.
3426
3427 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3428
3429         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3430         return type to 'bool'.  Adjust comment.  Use 'bool' when
3431         appropriate.
3432         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3433         * stap-probe.c (stap_parse_argument_1): Likewise.
3434         (stap_is_operator): Likewise.
3435         (stap_is_generic_prefix): Likewise.
3436         (stap_is_register_prefix): Likewise.
3437         (stap_is_register_indirection_prefix): Likewise.
3438         (stap_is_integer_prefix): Likewise.
3439         (stap_generic_check_suffix): Likewise.
3440         (stap_check_integer_suffix): Likewise.
3441         (stap_check_register_suffix): Likewise.
3442         (stap_check_register_indirection_suffix): Likewise.
3443         (stap_parse_register_operand): Likewise.
3444         (stap_parse_single_operand): Likewise.
3445         (stap_parse_argument_1): Likewise.
3446         (stap_probe::get_argument_count): Likewise.
3447         (stap_is_operator): Likewise.
3448
3449 2019-05-16  Tom Tromey  <tromey@adacore.com>
3450
3451         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3452         keyword to foreach.
3453
3454 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3455
3456         * linux-thread-db.c (try_thread_db_load_1): Change return type
3457         to bool.
3458         (try_thread_db_load): Likewise.
3459         (try_thread_db_load_from_pdir_1): Likewise.
3460         (try_thread_db_load_from_pdir): Likewise.
3461         (try_thread_db_load_from_sdir): Likewise.
3462         (try_thread_db_load_from_dir): Likewise.
3463         (thread_db_load_search): Likewise.
3464         (has_libpthread): Likewise.
3465         (thread_db_load): Likewise.
3466
3467 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3468
3469         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3470         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3471         NULL, and complain/return if that's the case.
3472
3473 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3474
3475         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3476         (advance, posn, abstract_read_memory): New functions.
3477         [struct mem_read_abstraction]: New struct.
3478         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3479
3480 2019-05-14  Tom Tromey  <tromey@adacore.com>
3481
3482         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3483         value is not lval_memory.
3484
3485 2019-05-14  Tom Tromey  <tromey@adacore.com>
3486
3487         * solib.c (info_sharedlibrary_command): Style the file name.
3488
3489 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3490
3491         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3492         (aarch64_vnv_type): Likewise.
3493         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3494         * common/tdesc.c: Likewise.
3495         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3496         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3497         * features/aarch64-fpu.xml: Add ieee half view.
3498         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3499         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3500         * gdbtypes.h (struct builtin_type): Likewise.
3501         (struct objfile_type): Likewise.
3502
3503 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3504
3505         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3506         typo.
3507         * location.h (string_to_event_location): Likewise.
3508
3509 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3510
3511         GDB 8.3 released.
3512
3513 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3514
3515         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3516         New variable declaration.
3517         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3518         New variable.
3519         (print_one_breakpoint): Use ui_out::test_flags and new global
3520         variable to compute use_fixed_output.
3521         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3522         Remove.
3523         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3524         (mi_multi_location_breakpoint_output_fixed): Remove.
3525         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3526         new variable.
3527         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3528         fix_multi_location_breakpoint_output flag if version >= 3.
3529         * ui-out.h (enum ui_out_flag)
3530         <fix_multi_location_breakpoint_output>: New enumerator.
3531
3532 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3533
3534         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3535
3536 2019-05-10  Tom Tromey  <tromey@adacore.com>
3537
3538         * ada-lang.c (catch_ada_completer): New function.
3539         (_initialize_ada_language): Use it.
3540
3541 2019-05-10  Tom Tromey  <tromey@adacore.com>
3542
3543         * thread.c (print_thread_info): Make "requested_threads" const.
3544         * gdbthread.h (print_thread_info): Make "requested_threads"
3545         const.
3546         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3547         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3548
3549 2019-05-08  Tom Tromey  <tom@tromey.com>
3550
3551         * gdbtypes.c (objfile_type_data): Change type.
3552         (objfile_type, _initialize_gdbtypes): Update.
3553
3554 2019-05-08  Tom Tromey  <tom@tromey.com>
3555
3556         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3557         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3558         (_initialize_dwarf2_frame): Update.
3559
3560 2019-05-08  Tom Tromey  <tom@tromey.com>
3561
3562         * objc-lang.c (objc_objfile_data): Change type.
3563         (find_methods): Update.
3564         (_initialize_objc_lang): Remove.
3565
3566 2019-05-08  Tom Tromey  <tom@tromey.com>
3567
3568         * stabsread.c (rs6000_builtin_type_data): Change type.
3569         (rs6000_builtin_type, _initialize_stabsread): Update.
3570
3571 2019-05-08  Tom Tromey  <tom@tromey.com>
3572
3573         * mips-tdep.c (mips_pdr_data): Remove.
3574         (_initialize_mips_tdep): Update.
3575
3576 2019-05-08  Tom Tromey  <tom@tromey.com>
3577
3578         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3579         (hppa_init_objfile_priv_data, read_unwind_info)
3580         (find_unwind_entry, _initialize_hppa_tdep): Update.
3581
3582 2019-05-08  Tom Tromey  <tom@tromey.com>
3583
3584         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3585         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3586         on obstack.
3587         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3588
3589 2019-05-08  Tom Tromey  <tom@tromey.com>
3590
3591         * mdebugread.c (basic_type_data): Change type.
3592         (basic_type, _initialize_mdebugread): Update.
3593
3594 2019-05-08  Tom Tromey  <tom@tromey.com>
3595
3596         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3597
3598 2019-05-08  Tom Tromey  <tom@tromey.com>
3599
3600         * nto-tdep.c (nto_inferior_data_reg): Change type.
3601         (nto_inferior_data): Update.
3602         (nto_inferior_data_cleanup, nto_new_inferior_data)
3603         (_initialize_nto_tdep): Remove.
3604         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3605
3606 2019-05-08  Tom Tromey  <tom@tromey.com>
3607
3608         * ada-lang.c (struct ada_inferior_data): Add initializers.
3609         (ada_inferior_data): Change type.
3610         (ada_inferior_data_cleanup): Remove.
3611         (get_ada_inferior_data, ada_inferior_exit)
3612         (struct ada_pspace_data): Add initializers, destructor.
3613         (ada_pspace_data_handle): Change type.
3614         (get_ada_pspace_data): Update.
3615         (ada_pspace_data_cleanup): Remove.
3616
3617 2019-05-08  Tom Tromey  <tom@tromey.com>
3618
3619         * coffread.c (struct coff_symfile_info): Add initializers.
3620         (coff_objfile_data_key): Move lower.  Change type.
3621         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3622         Update.
3623         (coff_free_info): Remove.
3624
3625 2019-05-08  Tom Tromey  <tom@tromey.com>
3626
3627         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3628         (fbsd_pspace_data_handle): Move lower.  Change type.
3629         (get_fbsd_pspace_data): Update.
3630         (fbsd_pspace_data_cleanup): Remove.
3631         (_initialize_fbsd_tdep): Update.
3632
3633 2019-05-08  Tom Tromey  <tom@tromey.com>
3634
3635         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3636         (get_ada_tasks_pspace_data): Update.
3637         (ada_tasks_pspace_data_cleanup): Remove.
3638         (_initialize_tasks): Update.
3639         (ada_tasks_inferior_data_handle): Change type.
3640         (get_ada_tasks_inferior_data): Update.
3641         (ada_tasks_inferior_data_cleanup): Remove.
3642         (struct ada_tasks_pspace_data): Add initializers.
3643
3644 2019-05-08  Tom Tromey  <tom@tromey.com>
3645
3646         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3647         * symfile-debug.c (debug_sym_get_probes): Change type.
3648         * stap-probe.c (handle_stap_probe):
3649         (stap_static_probe_ops::get_probes): Change type.
3650         * probe.h (class static_probe_ops) <get_probes>: Change type.
3651         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3652         (parse_probes_in_pspace): Update.
3653         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3654         Update.
3655         (any_static_probe_ops::get_probes): Change type.
3656         * elfread.c (elfread_data): New typedef.
3657         (probe_key): Change type.
3658         (elf_get_probes): Likewise.  Update.
3659         (probe_key_free): Remove.
3660         (_initialize_elfread): Update.
3661         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3662         Change type.
3663         (dtrace_process_dof_probe, dtrace_process_dof)
3664         (dtrace_static_probe_ops::get_probe): Change type.
3665
3666 2019-05-08  Tom Tromey  <tom@tromey.com>
3667
3668         * xcoffread.c (struct xcoff_symfile_info): Rename from
3669         coff_symfile_info.  Add initializers.
3670         (xcoff_objfile_data_key): Move lower.  Change type.
3671         (XCOFF_DATA): Rewrite.
3672         (xcoff_free_info): Remove.
3673         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3674         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3675         (xcoff_initial_scan): Update.
3676
3677 2019-05-08  Tom Tromey  <tom@tromey.com>
3678
3679         * solib-svr4.c (struct svr4_info): Add initializers and
3680         destructor.
3681         <probes_table>: Now an htab_up.
3682         (solib_svr4_pspace_data): Change type.
3683         (free_probes_table): Simplify.
3684         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3685         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3686         (probes_table_remove_objfile_probes, register_solib_event_probe)
3687         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3688         (_initialize_svr4_solib): Update.
3689
3690 2019-05-08  Tom Tromey  <tom@tromey.com>
3691
3692         * remote.c (remote_pspace_data): Change type.
3693         (remote_pspace_data_cleanup): Remove.
3694         (get_remote_exec_file, set_pspace_remote_exec_file)
3695         (_initialize_remote): Update.
3696
3697 2019-05-08  Tom Tromey  <tom@tromey.com>
3698
3699         * breakpoint.c (breakpoint_objfile_key): Change type.
3700         (get_breakpoint_objfile_data): Update.
3701         (free_breakpoint_objfile_data): Remove.
3702         (_initialize_breakpoint): Update.
3703
3704 2019-05-08  Tom Tromey  <tom@tromey.com>
3705
3706         * linux-tdep.c (struct linux_info): Add initializers.
3707         (linux_inferior_data): Move.  Change type.
3708         (invalidate_linux_cache_inf): Update.
3709         (linux_inferior_data_cleanup): Remove.
3710         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3711
3712 2019-05-08  Tom Tromey  <tom@tromey.com>
3713
3714         * auxv.c (auxv_inferior_data): Move.  Change type.
3715         (auxv_inferior_data_cleanup): Remove.
3716         (invalidate_auxv_cache_inf): Rewrite.
3717         (get_auxv_inferior_data, _initialize_auxv): Update.
3718
3719 2019-05-08  Tom Tromey  <tom@tromey.com>
3720
3721         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3722         (symfile_debug_objfile_data_key): Change type.
3723         (symfile_debug_installed, debug_qf_has_symbols)
3724         (debug_qf_find_last_source_symtab)
3725         (debug_qf_forget_cached_source_info)
3726         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3727         (debug_qf_print_stats, debug_qf_dump)
3728         (debug_qf_expand_symtabs_for_function)
3729         (debug_qf_expand_all_symtabs)
3730         (debug_qf_expand_symtabs_with_fullname)
3731         (debug_qf_map_matching_symbols)
3732         (debug_qf_expand_symtabs_matching)
3733         (debug_qf_find_pc_sect_compunit_symtab)
3734         (debug_qf_map_symbol_filenames)
3735         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3736         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3737         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3738         (debug_sym_read_linetable, debug_sym_relocate): Update.
3739         (symfile_debug_free_objfile): Remove.
3740         (install_symfile_debug_logging, _initialize_symfile_debug):
3741         Update.
3742
3743 2019-05-08  Tom Tromey  <tom@tromey.com>
3744
3745         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3746         allocate_on_obstack.
3747         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3748         (get_dwarf2_per_objfile): Update.
3749         (set_dwarf2_per_objfile): Remove.
3750         (dwarf2_has_info, dwarf2_get_section_info): Update.
3751         (dwarf2_free_objfile): Remove.
3752         (_initialize_dwarf2_read): Update.
3753
3754 2019-05-08  Tom Tromey  <tom@tromey.com>
3755
3756         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3757         initializers.
3758         <unsupported_script_warning_printed,
3759         script_not_found_warning_printed>: Now bool.
3760         (auto_load_pspace_data): Change type.
3761         (~auto_load_pspace_info): Rename from
3762         auto_load_pspace_data_cleanup.
3763         (get_auto_load_pspace_data, init_loaded_scripts_info)
3764         (clear_section_scripts, maybe_print_unsupported_script_warning)
3765         (maybe_print_script_not_found_warning, _initialize_auto_load):
3766         Update.
3767
3768 2019-05-08  Tom Tromey  <tom@tromey.com>
3769
3770         * objfiles.c (objfile_pspace_info): Add destructor and
3771         initializers.
3772         (objfiles_pspace_data): Change type.
3773         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3774         (get_objfile_pspace_data): Update.
3775         (objfiles_bfd_data): Change type.
3776         (get_objfile_bfd_data): Update.
3777         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3778
3779 2019-05-08  Tom Tromey  <tom@tromey.com>
3780
3781         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3782         Change type.
3783         (get_catch_syscall_inferior_data): Update.
3784         (catch_syscall_inferior_data_cleanup): Remove.
3785         (_initialize_break_catch_syscall): Update.
3786
3787 2019-05-08  Tom Tromey  <tom@tromey.com>
3788
3789         * inflow.c (struct terminal_info): Add destructor and
3790         initializers.
3791         (inflow_inferior_data): Change type.
3792         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3793         (get_inflow_inferior_data, inflow_inferior_exit)
3794         (swap_terminal_info, _initialize_inflow): Update.
3795
3796 2019-05-08  Tom Tromey  <tom@tromey.com>
3797
3798         * target-dcache.c (target_dcache_cleanup): Remove.
3799         (target_dcache_aspace_key): Change type.
3800         (target_dcache_init_p, target_dcache_invalidate)
3801         (target_dcache_get, target_dcache_get_or_init)
3802         (_initialize_target_dcache): Update.
3803         * dcache.h (struct dcache_deleter): New.
3804
3805 2019-05-08  Tom Tromey  <tom@tromey.com>
3806
3807         * symtab.c (struct symbol_cache): Add destructor and
3808         initializers.
3809         (symbol_cache_key): Move.  Change type.
3810         (make_symbol_cache, free_symbol_cache): Remove.
3811         (get_symbol_cache): Update.
3812         (symbol_cache_cleanup): Remove.
3813         (ALL_PSPACES, symbol_cache_flush)
3814         (maintenance_print_symbol_cache)
3815         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3816         Update.
3817
3818 2019-05-08  Tom Tromey  <tom@tromey.com>
3819
3820         * symtab.c (struct main_info): Add destructor and initializers.
3821         (main_progspace_key): Move.  Change type.
3822         (get_main_info): Update.
3823         (main_info_cleanup): Remove.
3824         (_initialize_symtab): Update.
3825
3826 2019-05-08  Tom Tromey  <tom@tromey.com>
3827
3828         * registry.h (DECLARE_REGISTRY): Define the _key class.
3829
3830 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3831
3832         * NEWS: Merge two 'New commands' sections.
3833
3834 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3835
3836         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3837         parameter and use Ada language definition instead.
3838         (ada_val_print_ptr): Remove unused language parameter.
3839         (ada_val_print_num): Remove language parameter and use Ada language
3840         definition instead.
3841         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3842         parameter.
3843         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3844         parameter and use Ada language definition instead.
3845         (ada_val_print_1): Update all ada_val_print_xxx calls.
3846         Remove language parameter.
3847         (ada_val_print): Update ada_val_print_1 call.
3848
3849 2019-05-08  Tom Tromey  <tromey@adacore.com>
3850
3851         * remote.c (remote_hw_watchpoint_limit)
3852         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3853         Now static.
3854
3855 2019-05-08  Tom Tromey  <tromey@adacore.com>
3856
3857         * maint.c (_initialize_maint_cmds): Move initialization code to
3858         remote.c.
3859         (watchdog, show_watchdog): Move to remote.c.
3860         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3861         "watchdog" static.
3862         (_initialize_remote): Move initialization code from maint.c.
3863         * defs.h (watchdog): Don't declare.
3864
3865 2019-05-08  Tom Tromey  <tromey@adacore.com>
3866
3867         * tui/tui-interp.c: Include main.h.
3868         * interps.c: Include main.h.
3869         * main.h (interpreter_p): Declare.
3870         * defs.h (interpreter_p): Don't declare.
3871
3872 2019-05-08  Tom Tromey  <tromey@adacore.com>
3873
3874         * dwarf2loc.c: Include dwarf2read.h.
3875         * defs.h (read_unsigned_leb128): Don't declare.
3876         * dwarf2read.h (read_unsigned_leb128): Declare.
3877
3878 2019-05-08  Tom Tromey  <tromey@adacore.com>
3879
3880         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3881         method.
3882
3883 2019-05-08  Tom Tromey  <tromey@adacore.com>
3884
3885         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3886         when no wrap column is set.
3887
3888 2019-05-08  Tom Tromey  <tromey@adacore.com>
3889
3890         * c-lang.c (c_get_string): Handle non-C-style arrays.
3891
3892 2019-05-08  Tom Tromey  <tromey@adacore.com>
3893
3894         * typeprint.c (print_offset_data::update): Print the bit offset,
3895         not the number of bits remaining.
3896
3897 2019-05-08  Tom Tromey  <tromey@adacore.com>
3898
3899         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3900         padding at end of comment.
3901
3902 2019-05-08  Tom Tromey  <tromey@adacore.com>
3903
3904         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3905         Compare main types.
3906
3907 2019-05-06  Tom Tromey  <tom@tromey.com>
3908
3909         * common/scoped_mmap.c: Include common-defs.h.
3910         * common/scoped_mmap.h: Don't include config.h.
3911
3912 2019-05-04  Tom Tromey  <tom@tromey.com>
3913
3914         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3915         (struct aarch64_call_info): Add initializers.
3916         <si>: Now a std::vector.
3917         (pass_on_stack, aarch64_push_dummy_call): Update.
3918
3919 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3920             Tom Tromey  <tom@tromey.com>
3921
3922         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3923         (ppc_threads): Now a std::vector.  Now static.
3924         (hwdebug_find_thread_points_by_tid)
3925         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3926         Update.
3927
3928 2019-05-04  Tom Tromey  <tom@tromey.com>
3929
3930         * arc-tdep.c (arc_tdesc_init): Return bool.
3931
3932 2019-05-04  Tom Tromey  <tom@tromey.com>
3933
3934         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3935         Use gdb_assert_not_reached.
3936
3937 2019-05-04  Tom Tromey  <tom@tromey.com>
3938
3939         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3940         "false".
3941
3942 2019-05-04  Tom Tromey  <tom@tromey.com>
3943
3944         * arc-tdep.c (arc_tdesc_init): Use bool.
3945
3946 2019-05-04  Tom Tromey  <tom@tromey.com>
3947
3948         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3949
3950 2019-05-04  Tom Tromey  <tom@tromey.com>
3951
3952         * cli/cli-cmds.c (valid_command_p): Return bool.
3953
3954 2019-05-04  Tom Tromey  <tom@tromey.com>
3955
3956         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3957         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3958
3959 2019-05-04  Raul Tambre  <raul@tambre.ee>
3960
3961         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3962         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3963         operator for comparison.
3964
3965 2019-05-04  Tom Tromey  <tom@tromey.com>
3966
3967         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3968         (lookup_partial_symbol, print_partial_symbols)
3969         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3970         (psymbol_compare): Update.
3971         (add_psymbol_to_bcache): Clear the entire psymbol.
3972         (maintenance_check_psymtabs): Update.
3973         * psympriv.h (struct partial_symbol): Don't derive from
3974         general_symbol_info.
3975         <obj_section, unrelocated_address, address,
3976         set_unrelocated_address>: Update.
3977         <ginfo>: New member.
3978         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3979         (debug_names::write_psymbols): Update.
3980
3981 2019-05-04  Tom de Vries  <tdevries@suse.de>
3982
3983         * contrib/cc-with-tweaks.sh: Support -n arg.
3984
3985 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3986
3987         * corelow.c (core_target::detach): Ensure frame cache and
3988         register caches are cleared.
3989         inferior.c (exit_inferior_1): Likewise.
3990
3991 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3992             Tom Tromey  <tom@tromey.com>
3993
3994         * dictionary.c (collate_pending_symbols_by_language): Remove
3995         "struct" from foreach.
3996         * symtab.c (lookup_global_symbol_from_objfile)
3997         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3998         foreach.
3999         * ser-tcp.c (net_open): Remove "struct" from foreach.
4000         * objfiles.c (objfile_relocate, objfile_rebase)
4001         (objfile_has_symbols): Remove "struct" from foreach.
4002         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4003         from foreach.
4004         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4005         foreach.
4006         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4007         "struct" from foreach.
4008         * ada-lang.c (create_excep_cond_exprs)
4009         (ada_exception_catchpoint_cond_string): Remove "struct" from
4010         foreach.
4011
4012 2019-05-03  Tom Tromey  <tromey@adacore.com>
4013
4014         * ada-exp.y (convert_char_literal): Check suffix of each
4015         enumerator.
4016
4017 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4018
4019         PR ada/21406:
4020         * ada-exp.y (yywrap): Don't define.
4021         * ada-lex.l (%option): Add noyywrap
4022         (yywrap): Remove.
4023
4024 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4025
4026         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4027         _WIN32_WINNT to the XP level, unless already defined to a higher
4028         level.
4029
4030         * unittests/parse-connection-spec-selftests.c:
4031         * ser-tcp.c:
4032         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4033         override.
4034
4035         * symfile.c (find_separate_debug_file): Remove colon from the
4036         drive spec of DOS/Windows file names of the target, so that the
4037         file name produced from DEBUGDIR and the target's directory will
4038         be valid on DOS/Windows systems.
4039
4040 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4041
4042         * rust-lang.c (val_print_struct): Handle printing structures
4043         containing strings.
4044
4045 2019-05-02  Tom Tromey  <tromey@adacore.com>
4046
4047         * valarith.c (_initialize_valarith): Remove.
4048
4049 2019-05-01  Tom Tromey  <tromey@adacore.com>
4050
4051         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4052         bitfields.
4053
4054 2019-05-01  Tom Tromey  <tromey@adacore.com>
4055
4056         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4057         for big-endian copies.
4058
4059 2019-04-30  Ali Tamur  <tamur@google.com>
4060         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4061         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4062         (read_3_bytes): New function.
4063
4064 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4065
4066         * windows-nat.c (main_thread_id): Delete.
4067         (handle_output_debug_string): Replace main_thread_id by
4068         current_event.dwThreadId.
4069         (fake_create_process): Likewise.
4070         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4071         Do not set main_thread_id.
4072         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4073         current_event.dwThreadId.
4074         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4075
4076 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4077
4078         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4079         Use current_event.dwThreadId instead of main_thread_id.
4080
4081 2019-04-30  Tom Tromey  <tromey@adacore.com>
4082
4083         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4084         (create_excep_cond_exprs): Iterate over program spaces.
4085         (ada_exception_catchpoint_cond_string): Examine all minimal
4086         symbols for exception types.
4087
4088 2019-04-30  Tom Tromey  <tromey@adacore.com>
4089
4090         PR c++/24470:
4091         * dwarf2read.c (process_structure_scope): Handle case where type
4092         has template parameters but no symbol was created.
4093
4094 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4095             Chris January  <chris.january@arm.com>
4096
4097         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4098         qualifier.
4099         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4100
4101 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4102
4103         * f-typeprint.c (f_print_type): Update rules for printing
4104         whitespace.
4105         (f_type_print_varspec_suffix): Likewise.
4106
4107 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4108             Chris January  <chris.january@arm.com>
4109
4110         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4111         function arguments.
4112
4113 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4114
4115         * f-lang.c (build_fortran_types): Change name of void type to
4116         lower case.
4117         * f-typeprint.c (f_type_print_base): Print the name of the void
4118         type, rather than a fixed string.
4119         * f-valprint.c (f_decorations): Use lower case void string.
4120
4121 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4122             Chris January  <chris.january@arm.com>
4123
4124         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4125         types for Fortran.
4126
4127 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4128             Chris January  <chris.january@arm.com>
4129             David Lecomber  <david.lecomber@arm.com>
4130
4131         * f-exp.y (BINOP_INTRINSIC): New token.
4132         (exp): New parser rule handling BINOP_INTRINSIC.
4133         (f77_keywords): Add new builtin procedures.
4134         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4135         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4136         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4137         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4138         (print_unop_subexp_f): New function.
4139         (print_binop_subexp_f): New function.
4140         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4141         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4142         (dump_subexp_body_f): Likewise.
4143         (operator_check_f): Likewise.
4144         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4145         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4146
4147 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4148
4149         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4150         UNOP_KIND.
4151         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4152         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4153         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4154         (operator_length_f): New fuction.
4155         (print_subexp_f): New function.
4156         (op_name_f): New function.
4157         (dump_subexp_body_f): New function.
4158         (operator_check_f): New function.
4159         (exp_descriptor_f): Replace standard expression handling functions
4160         with new functions.
4161         * gdb/fortran-operator.def: New file.
4162         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4163         * gdb/std-operator.def: Remove UNOP_KIND.
4164
4165 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4166
4167         * std-operator.def: Remove unbalanced, stray double quote
4168         character.
4169
4170 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4171             Chris January  <chris.january@arm.com>
4172             Daniel Everett  <daniel.everett@arm.com>
4173             Nick Forrington  <nick.forrington@arm.com>
4174             Richard Bunt  <richard.bunt@arm.com>
4175
4176         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4177         of depth when printing anonymous structs or unions.
4178         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4179         Don't print either the top-level value, or the children if the
4180         max-depth is exceeded.
4181         (ppscm_print_children): When printing the key of a map, allow one
4182         extra level of depth.
4183         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4184         print either the top-level value, or the children if the max-depth
4185         is exceeded.
4186         (print_children): When printing the key of a map, allow one extra
4187         level of depth.
4188         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4189         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4190         (user_print_options): Initialise max_depth field.
4191         (val_print_scalar_or_string_type_p): New function.
4192         (val_print): Check to see if the max depth has been reached.
4193         (val_print_check_max_depth): Define new function.
4194         (show_print_max_depth): New function.
4195         (_initialize_valprint): Add 'print max-depth' option.
4196         * valprint.h (struct value_print_options) <max_depth>: New field.
4197         (val_print_check_max_depth): Declare new function.
4198         * NEWS: Document new feature.
4199
4200 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4201
4202         * ada-lang.c (ada_language_defn): Initialise new field.
4203         * c-lang.c (c_is_string_type_p): New function.
4204         (c_language_defn): Initialise new field.
4205         (cplus_language_defn): Initialise new field.
4206         (asm_language_defn): Initialise new field.
4207         (minimal_language_defn): Initialise new field.
4208         * c-lang.h (c_is_string_type_p): Declare new function.
4209         * d-lang.c (d_language_defn): Initialise new field.
4210         * f-lang.c (f_is_string_type_p): New function.
4211         (f_language_defn): Initialise new field.
4212         * go-lang.c (go_is_string_type_p): New function.
4213         (go_language_defn): Initialise new field.
4214         * language.c (default_is_string_type_p): New function.
4215         (unknown_language_defn): Initialise new field.
4216         (auto_language_defn): Initialise new field.
4217         * language.h (struct language_defn) <la_is_string_type_p>: New
4218         member variable.
4219         (default_is_string_type_p): Declare new function.
4220         * m2-lang.c (m2_language_defn): Initialise new field.
4221         * objc-lang.c (objc_language_defn): Initialise new field.
4222         * opencl-lang.c (opencl_language_defn): Initialise new field.
4223         * p-lang.c (pascal_is_string_type_p): New function.
4224         (pascal_language_defn): Initialise new field.
4225         * rust-lang.c (rust_is_string_type_p): New function.
4226         (rust_language_defn): Initialise new field.
4227
4228 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4229
4230         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4231         New field.
4232         * ada-lang.c (ada_language_defn): Initialise new field.
4233         * c-lang.c (c_language_defn): Likewise.
4234         (cplus_language_defn): Likewise.
4235         (asm_language_defn): Likewise.
4236         (minimal_language_defn): Likewise.
4237         * d-lang.c (d_language_defn): Likewise.
4238         * f-lang.c (f_language_defn): Likewise.
4239         * go-lang.c (go_language_defn): Likewise.
4240         * language.c (unknown_language_defn): Likewise.
4241         (auto_language_defn): Likewise.
4242         * m2-lang.c (m2_language_defn): Likewise.
4243         * objc-lang.c (objc_language_defn): Likewise.
4244         * opencl-lang.c (opencl_language_defn): Likewise.
4245         * p-lang.c (pascal_language_defn): Likewise.
4246         * rust-lang.c (rust_language_defn): Likewise.
4247
4248 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4249
4250         * ada-lang.c (ada_is_character_type): Change return type to bool.
4251         (ada_is_string_type): Likewise.
4252         * ada-lang.h (ada_is_character_type): Update declaration
4253         (ada_is_string_type): Likewise.
4254
4255 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4256
4257         Support style in 'frame|thread apply'
4258
4259         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4260         * record.c (record_start, record_stop): Update callers of
4261         execute_command_to_string with false.
4262         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4263         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4264         methods.
4265         (class string_file): New constructor with term_out parameter.
4266         Override methods term_out and can_emit_style_escape.  New member
4267         term_out.
4268         (class stdio_file): Override can_emit_style_escape.
4269         (class tee_file): Override term_out and can_emit_style_escape.
4270         * utils.h (can_emit_style_escape): Remove.
4271         * utils.c (can_emit_style_escape): Likewise.
4272         Update all callers of can_emit_style_escape (SOMESTREAM) to
4273         SOMESTREAM->can_emit_style_escape.
4274         * source-cache.c (source_cache::get_source_lines): Likewise.
4275         * stack.c (frame_apply_command_count): Call execute_command_to_string
4276         passing the term_out characteristic of the current gdb_stdout.
4277         * thread.c (thr_try_catch_cmd): Likewise.
4278         * top.c (execute_command_to_string): pass term_out parameter
4279         to construct the string_file for the command output.
4280         * ui-file.c (term_cli_styling): New function (most code moved
4281         from utils.c can_emit_style_escape).
4282         (string_file::string_file, string_file::can_emit_style_escape,
4283         stdio_file::can_emit_style_escape, tee_file::term_out,
4284         tee_file::can_emit_style_escape): New functions.
4285
4286 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4287
4288         * NEWS: Mention the new set|show may-call-functions.
4289         * infcall.c (may_call_functions_p): New variable.
4290         (show_may_call_functions_p): New function.
4291         (call_function_by_hand_dummy): Throws an error if not
4292         may-call-functions.
4293         (_initialize_infcall): Call add_setshow_boolean_cmd for
4294         may-call-functions.
4295
4296 2019-04-25  Keith Seitz  <keiths@redhat.com>
4297
4298         PR c++/24367
4299         * cp-support.c (inspect_type): Don't attempt substitutions
4300         of symbol with the same name.
4301
4302 2019-04-25  Tom Tromey  <tromey@adacore.com>
4303
4304         PR gdb/24475:
4305         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4306         static.
4307
4308 2019-04-25  Tom Tromey  <tromey@adacore.com>
4309
4310         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4311         rvalue reference.
4312         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4313         (gdb_xml_parser::parse): Use std::move.
4314         * python/python-internal.h (gdbpy_convert_exception): Take a const
4315         reference.
4316         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4317         std::move.
4318         * python/py-utils.c (gdbpy_convert_exception): Take a const
4319         reference.
4320         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4321         Use std::move.
4322         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4323         Use std::move.
4324         * mi/mi-main.c (mi_print_exception): Take a const reference.
4325         * main.c (handle_command_errors): Take a const reference.
4326         * linespec.c (parse_linespec): Use std::move.
4327         * infcall.c (run_inferior_call): Use std::move.
4328         (call_function_by_hand_dummy): Use std::move.
4329         * exec.c (try_open_exec_file): Use std::move.
4330         * exceptions.h (exception_print, exception_fprintf)
4331         (exception_print_same): Update.
4332         * exceptions.c (print_exception, exception_print)
4333         (exception_fprintf, exception_print_same): Change parameters to
4334         const reference.
4335         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4336         * common/new-op.c: Use std::move.
4337         * common/common-exceptions.h (struct gdb_exception): Add move
4338         constructor.
4339         (struct gdb_exception_error, struct gdb_exception_quit, struct
4340         gdb_quit_bad_alloc): Change constructor to move constructor.
4341         (throw_exception): Change parameter to rvalue reference.
4342         * common/common-exceptions.c (throw_exception): Take rvalue
4343         reference.
4344         * cli/cli-interp.c (safe_execute_command): Use std::move.
4345         * breakpoint.c (insert_bp_location, location_to_sals): Use
4346         std::move.
4347
4348 2019-04-25  Tom Tromey  <tromey@adacore.com>
4349
4350         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4351         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4352         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4353         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4354         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4355         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4356         guile/scm-value.c: Use unpack.
4357         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4358         gdbscm_gdb_exception.
4359         (gdbscm_throw_gdb_exception): Likewise.
4360         (struct gdbscm_gdb_exception): New.
4361         (unpack): New function.
4362         (gdbscm_wrap): Use unpack.
4363
4364 2019-04-25  Tom Tromey  <tromey@adacore.com>
4365
4366         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4367         (gdb_rl_callback_handler): Use std::move.
4368         * common/common-exceptions.h (struct gdb_exception): Add move
4369         assignment operator.
4370         (throw_exception_sjlj): Change "exception" to const reference.
4371         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4372         (throw_exception_sjlj): Change "exception" to const reference.
4373
4374 2019-04-25  Tom Tromey  <tromey@adacore.com>
4375
4376         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4377         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4378         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4379         Update.
4380         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4381         Update.
4382         * mi/mi-interp.c (mi_interp::exec): Update.
4383         * linespec.c (parse_linespec): Update.
4384         * infcall.c (run_inferior_call): Update.
4385         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4386         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4387         (gdbscm_lookup_global_symbol): Update.
4388         * guile/scm-param.c (gdbscm_parameter_value): Update.
4389         * guile/scm-frame.c (gdbscm_frame_read_register)
4390         (gdbscm_frame_read_var): Update.
4391         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4392         * exec.c (try_open_exec_file): Update.
4393         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4394         (gdb_rl_callback_handler): Update.
4395         * common/common-exceptions.h (exception_none): Don't declare.
4396         * common/common-exceptions.c (exception_none): Don't define.
4397         (struct catcher) <exception>: Update.
4398         * cli/cli-interp.c (safe_execute_command): Update.
4399         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4400
4401 2019-04-25  Ali Tamur  <tamur@google.com>
4402
4403         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4404         (read_attribute_value): Likewise.
4405         (dwarf2_read_addr_index): Update comment.
4406         (read_str_index): Add DW_FORM_strx.
4407         (dwarf2_string_attr): Likewise.
4408         (dwarf2_const_value_attr): Likewise.
4409         (dump_die_shallow): Likewise.
4410         (dwarf2_fetch_constant_bytes): Likewise.
4411         (skip_form_bytes): Likewise.
4412         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4413
4414 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4415
4416         PR corefiles/11608
4417         PR corefiles/18187
4418         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4419         OFFSET.  Verify if current mapping contains an ELF header.
4420         (linux_find_memory_regions_full): Adjust call to
4421         dump_mapping_p.
4422
4423 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4424             Kang Li <kanglictf@gmail.com>
4425
4426         PR gdb/21600
4427
4428         * dwarf2-frame.c (read_initial_length): Be consistent about using
4429         unsigned representation of length.
4430         (decode_frame_entry_1): Likewise.  Check for wraparound of
4431         end pointer as well as buffer overflow.
4432
4433 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4434
4435         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4436         "vq".
4437
4438 2019-04-24  Tom Tromey  <tromey@adacore.com>
4439
4440         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4441
4442 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4443
4444         * s12z-tdep.c (s12z_unwind_pc): Delete.
4445         (s12z_unwind_sp): Delete.
4446         (s12z_gdbarch_init): Don't register deleted functions with
4447         gdbarch.
4448
4449 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4450
4451         * rl78-tdep.c (rl78_unwind_sp): Delete.
4452         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4453
4454 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4455
4456         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4457         (xstormy16_unwind_pc): Delete.
4458         (xstormy16_dummy_id): Delete.
4459         (xstormy16_gdbarch_init): Don't register deleted functions with
4460         gdbarch.
4461
4462 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4463
4464         * vax-tdep.c (vax_unwind_pc): Delete.
4465         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4466
4467 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4468
4469         * v850-tdep.c (v850_unwind_sp): Delete.
4470         (v850_unwind_pc): Delete.
4471         (v850_dummy_id): Delete.
4472         (v850_gdbarch_init): Don't register deleted functions with
4473         gdbarch.
4474
4475 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4476
4477         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4478         (tilegx_unwind_pc): Delete.
4479         (tilegx_unwind_dummy_id): Delete.
4480         (tilegx_gdbarch_init): Don't register deleted functions with
4481         gdbarch.
4482
4483 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4484
4485         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4486         (tic6x_dummy_id): Delete.
4487         (tic6x_gdbarch_init): Don't register deleted functions with
4488         gdbarch.
4489
4490 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4491
4492         * sparc-tdep.c (sparc_unwind_pc): Delete.
4493         (sparc32_gdbarch_init): Don't register deleted function with
4494         gdbarch.
4495
4496 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4497
4498         * sh-tdep.c (sh_unwind_sp): Delete.
4499         (sh_unwind_pc): Delete.
4500         (sh_dummy_id): Delete.
4501         (sh_gdbarch_init): Don't register deleted functions with
4502         gdbarch.
4503
4504 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4505
4506         * score-tdep.c (score_unwind_sp): Delete.
4507         (score_unwind_pc): Delete.
4508         (score_dummy_id): Delete.
4509         (score_gdbarch_init): Don't register deleted functions with
4510         gdbarch.
4511
4512 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4513
4514         * rx-tdep.c (rx_unwind_pc): Delete.
4515         (rx_unwind_sp): Delete.
4516         (rx_dummy_id): Delete.
4517         (rx_gdbarch_init): Don't register deleted functions with
4518         gdbarch.  Update comment.
4519
4520 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4521
4522         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4523         (rs6000_dummy_id): Delete.
4524         (rs6000_gdbarch_init): Don't register deleted functions with
4525         gdbarch.
4526
4527 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4528
4529         * or1k-tdep.c (or1k_dummy_id): Delete.
4530         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4531
4532 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4533
4534         * nios2-tdep.c (nios2_dummy_id): Delete.
4535         (nios2_unwind_sp): Delete.
4536         (nios2_gdbarch_init): Don't register deleted functions with
4537         gdbarch.
4538
4539 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4540
4541         * nds32-tdep.c (nds32_dummy_id): Delete.
4542         (nds32_unwind_pc): Delete.
4543         (nds32_unwind_sp): Delete.
4544         (nds32_gdbarch_init): Don't register deleted functions with
4545         gdbarch.
4546
4547 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4548
4549         * msp430-tdep.c (msp430_unwind_pc): Delete.
4550         (msp430_unwind_sp): Delete.
4551         (msp430_dummy_id): Delete.
4552         (msp430_gdbarch_init): Don't register deleted functions with
4553         gdbarch.
4554
4555 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4556
4557         * moxie-tdep.c (moxie_unwind_sp): Delete.
4558         (moxie_unwind_pc): Delete.
4559         (moxie_dummy_id): Delete.
4560         (moxie_gdbarch_init): Don't register deleted functions with
4561         gdbarch.
4562
4563 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4564
4565         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4566         (mn10300_unwind_pc): Delete.
4567         (mn10300_unwind_sp): Delete.
4568         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4569         mn10300_unwind_sp.
4570         (mn10300_frame_unwind_init): Don't register deleted functions with
4571         gdbarch.
4572
4573 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4574
4575         * mep-tdep.c (mep_unwind_pc): Delete.
4576         (mep_unwind_sp): Delete.
4577         (mep_dummy_id): Delete.
4578         (mep_gdbarch_init): Don't register deleted functions with
4579         gdbarch.
4580
4581 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4582
4583         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4584         (m68hc11_unwind_sp): Delete.
4585         (m68hc11_gdbarch_init): Don't register deleted functions with
4586         gdbarch.
4587
4588 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4589
4590         * m32r-tdep.c (m32r_unwind_sp): Delete.
4591         (m32r_unwind_pc): Delete.
4592         (m32r_dummy_id): Delete.
4593         (m32r_gdbarch_init): Don't register deleted functions with
4594         gdbarch.
4595
4596 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4597
4598         * m32c-tdep.c (m32c_unwind_pc): Delete.
4599         (m32c_unwind_sp): Delete.
4600         (m32c_dummy_id): Delete.
4601         (m32c_gdbarch_init): Don't register deleted functions with
4602         gdbarch.
4603
4604 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4605
4606         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4607         (lm32_unwind_pc): Delete.
4608         (lm32_dummy_id): Delete.
4609         (lm32_gdbarch_init): Don't register deleted functions with
4610         gdbarch.
4611
4612 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4613
4614         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4615         (iq2000_unwind_pc): Delete.
4616         (iq2000_dummy_id): Delete.
4617         (iq2000_gdbarch_init): Don't register deleted functions with
4618         gdbarch.
4619
4620 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4621
4622         * nds32-tdep.c (nds32_type_align): Delete.
4623         (nds32_push_dummy_call): Use type_align instead.
4624
4625 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4626
4627         * arm-tdep.c (arm_type_align): Only handle vector override case.
4628         (arm_push_dummy_call): Use type_align.
4629         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4630
4631 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4632
4633         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4634         case.
4635         (pass_on_stack): Use type_align.
4636         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4637         function.
4638
4639 2019-04-23  Tom Tromey  <tromey@adacore.com>
4640
4641         * dwarf2read.c (line_header::file_name_at): Remove unused
4642         overload.
4643
4644 2019-04-23  Tom de Vries  <tdevries@suse.de>
4645
4646         PR gdb/24438
4647         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4648         invocation.
4649
4650
4651 2019-03-27  Ali Tamur  <tamur@google.com>
4652
4653         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4654         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4655         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4656         (dwarf_expr_context::get_addr_index): Likewise
4657         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4658         (symbol_needs_eval_context::get_addr_index): Likewise
4659         (disassemble_dwarf_expression): Add DW_OP_addrx
4660         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4661         (read_cutu_die_from_dwo): Update comment
4662         (skip_one_die): Add DW_FORM_addrx
4663         (read_attribute_value): Likewise
4664         (var_decode_location): Add DW_OP_addrx
4665         (dwarf2_const_value_attr): Add DW_FORM_addrx
4666         (dump_die_shallow): Likewise
4667         (dwarf2_fetch_constant_bytes): Likewise
4668         (decode_locdesc): Add DW_OP_addrx
4669         (skip_form_bytes): Add DW_FORM_addrx
4670
4671 2019-04-22  Ali Tamur  <tamur@google.com>
4672
4673         * MAINTAINERS (Write After Approval): Add self.
4674
4675 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4676
4677         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4678         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4679         (open_symbol_file_object): Likewise.
4680         (svr4_default_sos): Add info parameter.
4681         (svr4_read_so_list): Likewise.
4682         (svr4_current_sos_direct): Adjust functions calls to pass down
4683         info.
4684         (svr4_current_sos_1): Add info parameter.
4685         (svr4_current_sos): Call get_svr4_info, pass info down to
4686         svr4_current_sos_1.
4687         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4688         get_svr4_info.
4689         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4690         get_svr4_info.
4691         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4692         to get_svr4_info.
4693         (probes_table_remove_objfile_probes): Likewise.
4694         (register_solib_event_probe): Add info parameter.
4695         (solist_update_incremental): Pass info parameter down to
4696         svr4_read_so_list.
4697         (disable_probes_interface): Add info parameter.
4698         (svr4_handle_solib_event): Pass current_program_space to
4699         get_svr4_info.  Adjust disable_probes_interface cleanup.
4700         (svr4_create_probe_breakpoints): Add info parameter, pass it
4701         down to register_solib_event_probe.
4702         (svr4_create_solib_event_breakpoints): Add info parameter,
4703         pass it down to svr4_create_probe_breakpoints.
4704         (enable_break): Pass info down to
4705         svr4_create_solib_event_breakpoints.
4706         (svr4_solib_create_inferior_hook): Pass current_program_space to
4707         get_svr4_info.
4708         (svr4_clear_solib): Likewise.
4709
4710 2019-04-22  Pedro Alves  <palves@redhat.com>
4711
4712         * solib-svr4.c (svr4_free_objfile_observer): New.
4713         (probe_and_action::objfile): New field.
4714         (probes_table_htab_remove_objfile_probes)
4715         (probes_table_remove_objfile_probes): New functions.
4716         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4717         in the new probe_and_action.  Don't store the probe in 'lookup'.
4718         (svr4_create_probe_breakpoints): Pass objfile to
4719         register_solib_event_probe.
4720         (_initialize_svr4_solib): Register a free_objfile observer.
4721
4722 2019-04-19  Tom Tromey  <tom@tromey.com>
4723
4724         * common/queue.h: Remove.
4725
4726 2019-04-19  Tom Tromey  <tom@tromey.com>
4727
4728         * event-loop.c: Don't include "common/queue.h".
4729
4730 2019-04-19  Tom Tromey  <tom@tromey.com>
4731
4732         * remote.c (remote_target): Use delete.
4733         * remote-notif.h: Include <list>, not "common/queue.h".
4734         (notif_client_p): Remove typedef.
4735         (remote_notif_state): Add constructor, destructor, initializer.
4736         <notif_queue>: Now a std::list.
4737         (remote_notif_state_xfree): Don't declare.
4738         * remote-notif.c (remote_notif_process, handle_notification)
4739         (remote_notif_state_allocate): Update.
4740         (~remote_notif_state): Rename from remote_notif_state_xfree.
4741
4742 2019-04-19  Tom Tromey  <tom@tromey.com>
4743
4744         * symfile.c (reread_symbols): Update.
4745         * objfiles.c (objfile_register_static_link)
4746         (objfile_lookup_static_link): Update
4747         (~objfile) Don't delete static_links.
4748         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4749
4750 2019-04-19  Tom Tromey  <tom@tromey.com>
4751
4752         * type-stack.h (struct type_stack) <insert>: Constify string.
4753         * type-stack.c (type_stack::insert): Constify string.
4754         * gdbtypes.h (lookup_template_type): Update.
4755         (address_space_name_to_int): Update.
4756         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4757         const.
4758         (lookup_template_type): Make name const.
4759         * c-exp.y: Update rules.
4760         (lex_one_token, classify_name, classify_inner_name)
4761         (c_print_token): Update.
4762         * p-exp.y: Update rules.
4763         (yylex): Update.
4764         * f-exp.y: Update rules.
4765         (yylex): Update.
4766         * d-exp.y: Update rules.
4767         (lex_one_token, classify_name, classify_inner_name): Update.
4768         * parse.c (write_dollar_variable, copy_name): Return std::string.
4769         * parser-defs.h (copy_name): Change return type.
4770         * m2-exp.y: Update rules.
4771         (yylex): Update.
4772         * go-exp.y (lex_one_token): Update.
4773         Update rules.
4774         (classify_unsafe_function, classify_packaged_name)
4775         (classify_name, yylex): Update.
4776
4777 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4778
4779         * configure.ac: add --enable-source-highlight switch.
4780         * configure: Regenerate.
4781         * top.c (print_gdb_version): plumb --enable-source-highlight
4782         status to "show configuration".
4783
4784 2019-04-19  Tom Tromey  <tromey@adacore.com>
4785
4786         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4787         Check ADA_TYPE_P.
4788         (empty_record, ada_template_to_fixed_record_type_1)
4789         (template_to_static_fixed_type)
4790         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4791         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4792         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4793         macros.
4794
4795 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4796
4797         PR symtab/24423:
4798         * source.c (print_source_lines_base): Advance "iter" when a
4799         control character is seen.
4800
4801 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4802
4803         * inferior.h (struct infcall_suspend_state_deleter):
4804         Catch exception in destructor to avoid crash.
4805
4806 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4807
4808         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4809         close to the add_com "shell".
4810
4811 2019-04-18  Tom Tromey  <tromey@adacore.com>
4812
4813         * process-stratum-target.h (class process_stratum_target)
4814         <stratum>: Add "final".
4815
4816 2019-04-17  Tom Tromey  <tromey@adacore.com>
4817
4818         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4819         against nullptr before use.
4820
4821 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4822
4823         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4824
4825 2019-04-17  Jim Wilson  <jimw@sifive.com>
4826             Andrew Burgess  <andrew.burgess@embecosm.com>
4827
4828         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4829         code read might fail, assume 4-byte breakpoint in that case.
4830
4831 2019-04-15  Leszek Swirski  <leszeks@google.com>
4832
4833         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4834         rather than a hand-rolled POD check when checking for forced MEMORY
4835         classification.
4836
4837 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4838
4839         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4840         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4841         function.
4842         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4843         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4844         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4845         declaration.
4846
4847 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4848
4849         * aarch64-linux-nat.c
4850         (aarch64_linux_nat_target::thread_architecture): Add override.
4851         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4852         each VQ.
4853
4854 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4855
4856         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4857
4858 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4859
4860         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4861         target types of size 96-bits, add some additional comments, and
4862         check that the builtin type we found was the correct size.
4863
4864 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4865
4866         * utils.c (prompt_for_continue): Don't restore the styling at the
4867         end, as applied_style has the wrong value.  This fixes styling in
4868         long lists of file names that are interrupted by the "Continue?"
4869         prompt.
4870
4871 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4872
4873         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4874         * c-lang.c (c_language_defn): Likewise.
4875         (cplus_language_defn): Likewise.
4876         (asm_language_defn): Likewise.
4877         (minimal_language_defn): Likewise.
4878         * d-lang.c (d_language_defn): Likewise.
4879         * f-lang.c (f_language_defn): Likewise.
4880         * go-lang.c (go_language_defn): Likewise.
4881         * language.c (unknown_language_defn): Likewise.
4882         (auto_language_defn): Likewise.
4883         * language.h (struct language_defn): Remove la_magic field.
4884         (LANG_MAGIC): Delete.
4885         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4886         * objc-lang.c (objc_language_defn): Likewise.
4887         * opencl-lang.c (opencl_language_defn): Likewise.
4888         * p-lang.c (pascal_language_defn): Likewise.
4889         * rust-lang.c (rust_language_defn): Likewise.
4890
4891 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4892
4893         * riscv-tdep.c (riscv_type_align): New function.
4894         (riscv_type_alignment): Delete.
4895         (riscv_arg_location): Use 'type_align'.
4896         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4897
4898 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4899
4900         * gdbtypes.c (type_align): A struct with no non-static fields also
4901         has alignment of 1.
4902
4903 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4904
4905         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4906         component to 0.
4907         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4908         member.
4909         (riscv_struct_info::analyse): New implementation using new
4910         analyse_inner member function.
4911         (riscv_struct_info::field_offset): New member function.
4912         (riscv_struct_info::m_offsets): New member variable.
4913         (riscv_struct_info::analyse_inner): New private member function,
4914         takes the old implementation of riscv_struct_info::analyse but
4915         extended to track field offsets.
4916         (riscv_call_arg_struct): Update the struct folding special cases
4917         to handle cases where empty C++ structs, which are non-zero
4918         length, are found.
4919         (riscv_arg_location): Initialise the length of each location, a
4920         non-zero length now indicates the location is in use.
4921         (riscv_push_dummy_call): Allow for the first location having a
4922         non-zero offset when setting up arguments.
4923         (riscv_return_value): Likewise, but for return values.
4924
4925 2019-04-11  Tom Tromey  <tromey@adacore.com>
4926
4927         * utils.c (internal_vproblem): Make "msg" const.
4928
4929 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4930
4931         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4932         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4933         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4934         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4935
4936 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4937
4938         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4939         function.
4940         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4941         of amd64_collect_native_gregset.
4942         (amd64_linux_nat_target::store_registers): Likewise.
4943
4944 2019-04-10  Tom Tromey  <tom@tromey.com>
4945
4946         * symtab.c (lookup_global_symbol_from_objfile)
4947         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4948         * objfiles.h (class separate_debug_iterator): New.
4949         (class separate_debug_range): New.
4950         (struct objfile) <separate_debug_objfiles>: New method.
4951         (objfile_separate_debug_iterate): Don't declare.
4952         * objfiles.c (separate_debug_iterator::operator++): Rename from
4953         objfile_separate_debug_iterate.
4954         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4955         iterator.
4956         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4957         iterator.
4958
4959 2019-04-10  Tom Tromey  <tom@tromey.com>
4960
4961         * symfile.c (reread_symbols): Remove old comment.
4962         * objfiles.c (free_all_objfiles): Fix a typo.
4963
4964 2019-04-10  Tom Tromey  <tom@tromey.com>
4965
4966         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4967         * minsyms.c (lookup_minimal_symbol): Use foreach.
4968         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4969         (lookup_minimal_symbol_solib_trampoline): Likewise.
4970         * symfile.c (reread_symbols): Use foreach.
4971
4972 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4973             Tom Tromey  <tromey@adacore.com>
4974
4975         PR rust/24414:
4976         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4977         (rust_lex_int_test): Change "value" to be LONGEST.
4978         (rust_lex_tests): Add test for long integer literal.
4979
4980 2019-04-09  Tom Tromey  <tromey@adacore.com>
4981
4982         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4983         to bool.
4984         (extended_remote_target::attach): Update.
4985         (remote_target::remote_notice_new_inferior): Update.
4986         (remote_target::add_current_inferior_and_thread): Update.
4987         * inferior.c (exit_inferior_1): Use "false".
4988         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4989
4990 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4991
4992         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4993         the "start" command.
4994
4995 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4996
4997         * python/py-inferior.c (infpy_thread_from_thread_handle):
4998         Adjust comments to reflect renaming of thread_from_thread_handle
4999         to thread_from_handle.  Adjust keywords.  Fix type error message.
5000         (inferior_object_methods): Add thread_from_handle.  Retain
5001         thread_from_thread_handle, but mark it as deprecated.
5002
5003 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5004
5005         * gdbthread.h (find_thread_by_handle): Revise declaration.
5006         * thread.c (find_thread_by_handle): Likewise.  Adjust
5007         implementation too.
5008         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5009         support for buffer objects as handles.
5010
5011 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5012
5013         * python/py-infthread.c (thpy_thread_handle): New function.
5014         (thread_object_methods): Register thpy_thread_handle.
5015
5016 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5017
5018         * gdbthread.h (thread_to_thread_handle): Declare.
5019         * thread.c (gdbtypes.h): Include.
5020         (thread_to_thread_handle): New function.
5021
5022         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5023         (target_thread_info_to_thread_handle): Declare.
5024         * target.c (target_thread_info_to_thread_handle): New function.
5025         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5026         * target-delegates.c: Regenerate.
5027
5028         * linux-thread-db.c (class thread_db_target): Add method
5029         thread_info_to_thread_handle.
5030         (thread_db_target::thread_info_to_thread_handle): Define.
5031         * remote.c (class remote_target): Add new method
5032         thread_info_to_thread_handle.
5033         (remote_target::thread_info_to_thread_handle): Define.
5034
5035 2019-04-08  Pedro Alves  <palves@redhat.com>
5036
5037         * common/common-exceptions.c (throw_exception): Don't create
5038         named object to throw; throw directly.
5039         (throw_it): Likewise.  Don't initialize gdb_exception::message
5040         here, with new; pass FMT and AP to the ctor instead.
5041         * common/common-exceptions.h: Include <string>.
5042         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5043         const char *, va_list)): New ctor.  Use std::make_shared.
5044         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5045         errors)): Delete.
5046         (gdb_exception_error::gdb_exception_error(enum errors, const char
5047         *, va_list)): New.
5048         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5049         Add assertion.
5050         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5051         errors)): Delete.
5052         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5053         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5054         Add assertion.
5055
5056 2019-04-08  Tom Tromey  <tom@tromey.com>
5057
5058         * valops.c (value_rtti_indirect_type): Replace throw_exception
5059         with throw.
5060         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5061         with throw.
5062         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5063         throw.
5064         * target.c (target_translate_tls_address): Replace throw_exception
5065         with throw.
5066         * stack.c (frame_apply_command_count): Replace throw_exception
5067         with throw.
5068         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5069         throw.
5070         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5071         with throw.
5072         * rs6000-tdep.c (rs6000_frame_cache)
5073         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5074         * remote.c: Replace throw_exception with throw.
5075         * record-full.c (record_full_message, record_full_wait_1)
5076         (record_full_restore): Replace throw_exception with throw.
5077         * record-btrace.c:
5078         (get_thread_current_frame_id, record_btrace_start_replaying)
5079         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5080         (cmd_record_btrace_start): Replace throw_exception with throw.
5081         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5082         throw.
5083         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5084         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5085         * linespec.c:
5086         (find_linespec_symbols): Replace throw_exception with throw.
5087         * infrun.c (displaced_step_prepare, resume): Replace
5088         throw_exception with throw.
5089         * infcmd.c (post_create_inferior): Replace throw_exception with
5090         throw.
5091         * inf-loop.c (inferior_event_handler): Replace throw_exception
5092         with throw.
5093         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5094         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5095         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5096         (get_prev_frame_always, get_frame_pc_if_available)
5097         (get_frame_address_in_block_if_available, get_frame_language):
5098         Replace throw_exception with throw.
5099         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5100         throw_exception with throw.
5101         * eval.c (fetch_subexp_value, evaluate_var_value)
5102         (evaluate_funcall, evaluate_subexp_standard): Replace
5103         throw_exception with throw.
5104         * dwarf2loc.c (call_site_find_chain)
5105         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5106         Replace throw_exception with throw.
5107         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5108         with throw.
5109         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5110         throw.
5111         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5112         * completer.c (complete_line_internal): Replace throw_exception
5113         with throw.
5114         * compile/compile-object-run.c (compile_object_run): Replace
5115         throw_exception with throw.
5116         * cli/cli-script.c (process_next_line): Replace throw_exception
5117         with throw.
5118         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5119         (btrace_enable, btrace_maint_update_pt_packets): Replace
5120         throw_exception with throw.
5121         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5122         throw_exception with throw.
5123         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5124         throw_exception with throw.
5125         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5126         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5127         * aarch64-tdep.c (aarch64_make_prologue_cache)
5128         (aarch64_make_stub_cache): Replace throw_exception with throw.
5129
5130 2019-04-08  Tom Tromey  <tom@tromey.com>
5131
5132         * common/common-exceptions.c (throw_exception): Rename from
5133         throw_exception_cxx.  Remove old copy.  Make argument const.
5134         (throw_it): Create and throw exception objects directly.
5135         * common/common-exceptions.h (throw_exception): Make argument
5136         const.
5137         (struct gdb_exception_error): Add constructor.
5138         (struct gdb_exception_quit): Add constructor.
5139
5140 2019-04-08  Tom Tromey  <tom@tromey.com>
5141
5142         * common/common-exceptions.h (exception_rethrow): Don't declare.
5143         (TRY_SJLJ): Update comment.
5144         (TRY, CATCH, END_CATCH): Remove.
5145         * common/common-exceptions.c (exception_rethrow): Remove.
5146
5147 2019-04-08  Tom Tromey  <tom@tromey.com>
5148
5149         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5150         Remove.
5151         (gdb_exception_error): Rename from
5152         gdb_exception_RETURN_MASK_ERROR.
5153         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5154         (gdb_quit_bad_alloc): Update.
5155         * aarch64-tdep.c: Update.
5156         * ada-lang.c: Update.
5157         * ada-typeprint.c: Update.
5158         * ada-valprint.c: Update.
5159         * amd64-tdep.c: Update.
5160         * arch-utils.c: Update.
5161         * break-catch-throw.c: Update.
5162         * breakpoint.c: Update.
5163         * btrace.c: Update.
5164         * c-varobj.c: Update.
5165         * cli/cli-cmds.c: Update.
5166         * cli/cli-interp.c: Update.
5167         * cli/cli-script.c: Update.
5168         * common/common-exceptions.c: Update.
5169         * common/new-op.c: Update.
5170         * common/selftest.c: Update.
5171         * compile/compile-c-symbols.c: Update.
5172         * compile/compile-cplus-symbols.c: Update.
5173         * compile/compile-object-load.c: Update.
5174         * compile/compile-object-run.c: Update.
5175         * completer.c: Update.
5176         * corelow.c: Update.
5177         * cp-abi.c: Update.
5178         * cp-support.c: Update.
5179         * cp-valprint.c: Update.
5180         * darwin-nat.c: Update.
5181         * disasm-selftests.c: Update.
5182         * dtrace-probe.c: Update.
5183         * dwarf-index-cache.c: Update.
5184         * dwarf-index-write.c: Update.
5185         * dwarf2-frame-tailcall.c: Update.
5186         * dwarf2-frame.c: Update.
5187         * dwarf2loc.c: Update.
5188         * dwarf2read.c: Update.
5189         * eval.c: Update.
5190         * event-loop.c: Update.
5191         * event-top.c: Update.
5192         * exec.c: Update.
5193         * f-valprint.c: Update.
5194         * fbsd-tdep.c: Update.
5195         * frame-unwind.c: Update.
5196         * frame.c: Update.
5197         * gdbtypes.c: Update.
5198         * gnu-v3-abi.c: Update.
5199         * guile/guile-internal.h: Update.
5200         * guile/scm-block.c: Update.
5201         * guile/scm-breakpoint.c: Update.
5202         * guile/scm-cmd.c: Update.
5203         * guile/scm-disasm.c: Update.
5204         * guile/scm-frame.c: Update.
5205         * guile/scm-lazy-string.c: Update.
5206         * guile/scm-math.c: Update.
5207         * guile/scm-param.c: Update.
5208         * guile/scm-ports.c: Update.
5209         * guile/scm-pretty-print.c: Update.
5210         * guile/scm-symbol.c: Update.
5211         * guile/scm-symtab.c: Update.
5212         * guile/scm-type.c: Update.
5213         * guile/scm-value.c: Update.
5214         * i386-linux-tdep.c: Update.
5215         * i386-tdep.c: Update.
5216         * inf-loop.c: Update.
5217         * infcall.c: Update.
5218         * infcmd.c: Update.
5219         * infrun.c: Update.
5220         * jit.c: Update.
5221         * language.c: Update.
5222         * linespec.c: Update.
5223         * linux-fork.c: Update.
5224         * linux-nat.c: Update.
5225         * linux-tdep.c: Update.
5226         * linux-thread-db.c: Update.
5227         * main.c: Update.
5228         * mi/mi-cmd-break.c: Update.
5229         * mi/mi-cmd-stack.c: Update.
5230         * mi/mi-interp.c: Update.
5231         * mi/mi-main.c: Update.
5232         * objc-lang.c: Update.
5233         * p-valprint.c: Update.
5234         * parse.c: Update.
5235         * ppc-linux-tdep.c: Update.
5236         * printcmd.c: Update.
5237         * python/py-arch.c: Update.
5238         * python/py-breakpoint.c: Update.
5239         * python/py-cmd.c: Update.
5240         * python/py-finishbreakpoint.c: Update.
5241         * python/py-frame.c: Update.
5242         * python/py-framefilter.c: Update.
5243         * python/py-gdb-readline.c: Update.
5244         * python/py-inferior.c: Update.
5245         * python/py-infthread.c: Update.
5246         * python/py-lazy-string.c: Update.
5247         * python/py-linetable.c: Update.
5248         * python/py-objfile.c: Update.
5249         * python/py-param.c: Update.
5250         * python/py-prettyprint.c: Update.
5251         * python/py-progspace.c: Update.
5252         * python/py-record-btrace.c: Update.
5253         * python/py-record.c: Update.
5254         * python/py-symbol.c: Update.
5255         * python/py-type.c: Update.
5256         * python/py-unwind.c: Update.
5257         * python/py-utils.c: Update.
5258         * python/py-value.c: Update.
5259         * python/python.c: Update.
5260         * record-btrace.c: Update.
5261         * record-full.c: Update.
5262         * remote-fileio.c: Update.
5263         * remote.c: Update.
5264         * riscv-tdep.c: Update.
5265         * rs6000-aix-tdep.c: Update.
5266         * rs6000-tdep.c: Update.
5267         * rust-exp.y: Update.
5268         * rust-lang.c: Update.
5269         * s390-tdep.c: Update.
5270         * selftest-arch.c: Update.
5271         * solib-dsbt.c: Update.
5272         * solib-frv.c: Update.
5273         * solib-spu.c: Update.
5274         * solib-svr4.c: Update.
5275         * solib.c: Update.
5276         * sparc64-linux-tdep.c: Update.
5277         * stack.c: Update.
5278         * symfile-mem.c: Update.
5279         * symmisc.c: Update.
5280         * target.c: Update.
5281         * thread.c: Update.
5282         * top.c: Update.
5283         * tracefile-tfile.c: Update.
5284         * tui/tui.c: Update.
5285         * typeprint.c: Update.
5286         * unittests/cli-utils-selftests.c: Update.
5287         * unittests/parse-connection-spec-selftests.c: Update.
5288         * valops.c: Update.
5289         * valprint.c: Update.
5290         * value.c: Update.
5291         * varobj.c: Update.
5292         * windows-nat.c: Update.
5293         * x86-linux-nat.c: Update.
5294         * xml-support.c: Update.
5295
5296 2019-04-08  Tom Tromey  <tom@tromey.com>
5297
5298         * xml-support.c: Use C++ exception handling.
5299         * x86-linux-nat.c: Use C++ exception handling.
5300         * windows-nat.c: Use C++ exception handling.
5301         * varobj.c: Use C++ exception handling.
5302         * value.c: Use C++ exception handling.
5303         * valprint.c: Use C++ exception handling.
5304         * valops.c: Use C++ exception handling.
5305         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5306         handling.
5307         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5308         * typeprint.c: Use C++ exception handling.
5309         * tui/tui.c: Use C++ exception handling.
5310         * tracefile-tfile.c: Use C++ exception handling.
5311         * top.c: Use C++ exception handling.
5312         * thread.c: Use C++ exception handling.
5313         * target.c: Use C++ exception handling.
5314         * symmisc.c: Use C++ exception handling.
5315         * symfile-mem.c: Use C++ exception handling.
5316         * stack.c: Use C++ exception handling.
5317         * sparc64-linux-tdep.c: Use C++ exception handling.
5318         * solib.c: Use C++ exception handling.
5319         * solib-svr4.c: Use C++ exception handling.
5320         * solib-spu.c: Use C++ exception handling.
5321         * solib-frv.c: Use C++ exception handling.
5322         * solib-dsbt.c: Use C++ exception handling.
5323         * selftest-arch.c: Use C++ exception handling.
5324         * s390-tdep.c: Use C++ exception handling.
5325         * rust-lang.c: Use C++ exception handling.
5326         * rust-exp.y: Use C++ exception handling.
5327         * rs6000-tdep.c: Use C++ exception handling.
5328         * rs6000-aix-tdep.c: Use C++ exception handling.
5329         * riscv-tdep.c: Use C++ exception handling.
5330         * remote.c: Use C++ exception handling.
5331         * remote-fileio.c: Use C++ exception handling.
5332         * record-full.c: Use C++ exception handling.
5333         * record-btrace.c: Use C++ exception handling.
5334         * python/python.c: Use C++ exception handling.
5335         * python/py-value.c: Use C++ exception handling.
5336         * python/py-utils.c: Use C++ exception handling.
5337         * python/py-unwind.c: Use C++ exception handling.
5338         * python/py-type.c: Use C++ exception handling.
5339         * python/py-symbol.c: Use C++ exception handling.
5340         * python/py-record.c: Use C++ exception handling.
5341         * python/py-record-btrace.c: Use C++ exception handling.
5342         * python/py-progspace.c: Use C++ exception handling.
5343         * python/py-prettyprint.c: Use C++ exception handling.
5344         * python/py-param.c: Use C++ exception handling.
5345         * python/py-objfile.c: Use C++ exception handling.
5346         * python/py-linetable.c: Use C++ exception handling.
5347         * python/py-lazy-string.c: Use C++ exception handling.
5348         * python/py-infthread.c: Use C++ exception handling.
5349         * python/py-inferior.c: Use C++ exception handling.
5350         * python/py-gdb-readline.c: Use C++ exception handling.
5351         * python/py-framefilter.c: Use C++ exception handling.
5352         * python/py-frame.c: Use C++ exception handling.
5353         * python/py-finishbreakpoint.c: Use C++ exception handling.
5354         * python/py-cmd.c: Use C++ exception handling.
5355         * python/py-breakpoint.c: Use C++ exception handling.
5356         * python/py-arch.c: Use C++ exception handling.
5357         * printcmd.c: Use C++ exception handling.
5358         * ppc-linux-tdep.c: Use C++ exception handling.
5359         * parse.c: Use C++ exception handling.
5360         * p-valprint.c: Use C++ exception handling.
5361         * objc-lang.c: Use C++ exception handling.
5362         * mi/mi-main.c: Use C++ exception handling.
5363         * mi/mi-interp.c: Use C++ exception handling.
5364         * mi/mi-cmd-stack.c: Use C++ exception handling.
5365         * mi/mi-cmd-break.c: Use C++ exception handling.
5366         * main.c: Use C++ exception handling.
5367         * linux-thread-db.c: Use C++ exception handling.
5368         * linux-tdep.c: Use C++ exception handling.
5369         * linux-nat.c: Use C++ exception handling.
5370         * linux-fork.c: Use C++ exception handling.
5371         * linespec.c: Use C++ exception handling.
5372         * language.c: Use C++ exception handling.
5373         * jit.c: Use C++ exception handling.
5374         * infrun.c: Use C++ exception handling.
5375         * infcmd.c: Use C++ exception handling.
5376         * infcall.c: Use C++ exception handling.
5377         * inf-loop.c: Use C++ exception handling.
5378         * i386-tdep.c: Use C++ exception handling.
5379         * i386-linux-tdep.c: Use C++ exception handling.
5380         * guile/scm-value.c: Use C++ exception handling.
5381         * guile/scm-type.c: Use C++ exception handling.
5382         * guile/scm-symtab.c: Use C++ exception handling.
5383         * guile/scm-symbol.c: Use C++ exception handling.
5384         * guile/scm-pretty-print.c: Use C++ exception handling.
5385         * guile/scm-ports.c: Use C++ exception handling.
5386         * guile/scm-param.c: Use C++ exception handling.
5387         * guile/scm-math.c: Use C++ exception handling.
5388         * guile/scm-lazy-string.c: Use C++ exception handling.
5389         * guile/scm-frame.c: Use C++ exception handling.
5390         * guile/scm-disasm.c: Use C++ exception handling.
5391         * guile/scm-cmd.c: Use C++ exception handling.
5392         * guile/scm-breakpoint.c: Use C++ exception handling.
5393         * guile/scm-block.c: Use C++ exception handling.
5394         * guile/guile-internal.h: Use C++ exception handling.
5395         * gnu-v3-abi.c: Use C++ exception handling.
5396         * gdbtypes.c: Use C++ exception handling.
5397         * frame.c: Use C++ exception handling.
5398         * frame-unwind.c: Use C++ exception handling.
5399         * fbsd-tdep.c: Use C++ exception handling.
5400         * f-valprint.c: Use C++ exception handling.
5401         * exec.c: Use C++ exception handling.
5402         * event-top.c: Use C++ exception handling.
5403         * event-loop.c: Use C++ exception handling.
5404         * eval.c: Use C++ exception handling.
5405         * dwarf2read.c: Use C++ exception handling.
5406         * dwarf2loc.c: Use C++ exception handling.
5407         * dwarf2-frame.c: Use C++ exception handling.
5408         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5409         * dwarf-index-write.c: Use C++ exception handling.
5410         * dwarf-index-cache.c: Use C++ exception handling.
5411         * dtrace-probe.c: Use C++ exception handling.
5412         * disasm-selftests.c: Use C++ exception handling.
5413         * darwin-nat.c: Use C++ exception handling.
5414         * cp-valprint.c: Use C++ exception handling.
5415         * cp-support.c: Use C++ exception handling.
5416         * cp-abi.c: Use C++ exception handling.
5417         * corelow.c: Use C++ exception handling.
5418         * completer.c: Use C++ exception handling.
5419         * compile/compile-object-run.c: Use C++ exception handling.
5420         * compile/compile-object-load.c: Use C++ exception handling.
5421         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5422         * compile/compile-c-symbols.c: Use C++ exception handling.
5423         * common/selftest.c: Use C++ exception handling.
5424         * common/new-op.c: Use C++ exception handling.
5425         * cli/cli-script.c: Use C++ exception handling.
5426         * cli/cli-interp.c: Use C++ exception handling.
5427         * cli/cli-cmds.c: Use C++ exception handling.
5428         * c-varobj.c: Use C++ exception handling.
5429         * btrace.c: Use C++ exception handling.
5430         * breakpoint.c: Use C++ exception handling.
5431         * break-catch-throw.c: Use C++ exception handling.
5432         * arch-utils.c: Use C++ exception handling.
5433         * amd64-tdep.c: Use C++ exception handling.
5434         * ada-valprint.c: Use C++ exception handling.
5435         * ada-typeprint.c: Use C++ exception handling.
5436         * ada-lang.c: Use C++ exception handling.
5437         * aarch64-tdep.c: Use C++ exception handling.
5438
5439 2019-04-08  Tom Tromey  <tom@tromey.com>
5440
5441         * xml-support.c (gdb_xml_parser::parse): Update.
5442         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5443         * value.c (show_convenience): Update.
5444         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5445         (test_parse_flags_qcs): Update.
5446         * thread.c (thr_try_catch_cmd): Update.
5447         * target.c (target_translate_tls_address): Update.
5448         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5449         (info_frame_command_core, frame_apply_command_count): Update.
5450         * rust-exp.y (rust_lex_exception_test): Update.
5451         * riscv-tdep.c (riscv_print_one_register_info): Update.
5452         * remote.c (remote_target::enable_btrace): Update.
5453         * record-btrace.c (record_btrace_enable_warn): Update.
5454         * python/py-utils.c (gdbpy_convert_exception): Update.
5455         * printcmd.c (do_one_display, print_variable_and_value): Update.
5456         * mi/mi-main.c (mi_print_exception): Update.
5457         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5458         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5459         * linux-nat.c (linux_nat_target::attach): Update.
5460         * linux-fork.c (class scoped_switch_fork_info): Update.
5461         * infrun.c (displaced_step_prepare): Update.
5462         * infcall.c (call_function_by_hand_dummy): Update.
5463         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5464         * gnu-v3-abi.c (print_one_vtable): Update.
5465         * frame.c (get_prev_frame_always): Update.
5466         * f-valprint.c (info_common_command_for_block): Update.
5467         * exec.c (try_open_exec_file): Update.
5468         * exceptions.c (print_exception, exception_print)
5469         (exception_fprintf, exception_print_same): Update.
5470         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5471         * dwarf-index-cache.c (index_cache::store)
5472         (index_cache::lookup_gdb_index): Update.
5473         * darwin-nat.c (maybe_cache_shell): Update.
5474         * cp-valprint.c (cp_print_value_fields): Update.
5475         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5476         (gcc_cplus_symbol_address): Update.
5477         * compile/compile-c-symbols.c (gcc_convert_symbol)
5478         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5479         * common/selftest.c: Update.
5480         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5481         a std::string.
5482         (exception_try_scope_entry, exception_try_scope_exit): Don't
5483         declare.
5484         (struct exception_try_scope): Remove.
5485         (TRY): Don't use exception_try_scope.
5486         (struct gdb_exception): Add constructor, operator=.
5487         <what>: New method.
5488         (struct gdb_exception_RETURN_MASK_ALL)
5489         (struct gdb_exception_RETURN_MASK_ERROR)
5490         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5491         (struct gdb_quit_bad_alloc): Update.
5492         * common/common-exceptions.c (exception_none): Change
5493         initializer.
5494         (struct catcher) <state, exception>: Initialize inline.
5495         <prev>: Remove member.
5496         (current_catcher): Remove.
5497         (catchers): New global.
5498         (exceptions_state_mc_init): Simplify.
5499         (catcher_pop): Remove.
5500         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5501         (try_scope_depth, exception_try_scope_entry)
5502         (exception_try_scope_exit): Remove.
5503         (throw_exception_sjlj): Update.
5504         (exception_messages, exception_messages_size): Remove.
5505         (throw_it): Simplify.
5506         (gdb_exception_sliced_copy): Remove.
5507         (throw_exception_cxx): Update.
5508         * cli/cli-script.c (script_from_file): Update.
5509         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5510         Update.
5511         * ada-valprint.c (ada_val_print): Update.
5512         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5513         (create_excep_cond_exprs): Update.
5514
5515 2019-04-08  Tom Tromey  <tom@tromey.com>
5516
5517         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5518         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5519         (TRY, CATCH, END_CATCH): Remove some definitions.
5520         * common/common-exceptions.c: Don't use GDB_XCPT.
5521         (catcher_list_size): Remove.
5522         (throw_exception, throw_it): Simplify.
5523
5524 2019-04-05  Tom Tromey  <tom@tromey.com>
5525
5526         Revert the header-sorting patch.
5527         * ft32-tdep.c: Revert.
5528         * frv-tdep.c: Revert.
5529         * frv-linux-tdep.c: Revert.
5530         * frame.c: Revert.
5531         * frame-unwind.c: Revert.
5532         * frame-base.c: Revert.
5533         * fork-child.c: Revert.
5534         * findvar.c: Revert.
5535         * findcmd.c: Revert.
5536         * filesystem.c: Revert.
5537         * filename-seen-cache.h: Revert.
5538         * filename-seen-cache.c: Revert.
5539         * fbsd-tdep.c: Revert.
5540         * fbsd-nat.h: Revert.
5541         * fbsd-nat.c: Revert.
5542         * f-valprint.c: Revert.
5543         * f-typeprint.c: Revert.
5544         * f-lang.c: Revert.
5545         * extension.h: Revert.
5546         * extension.c: Revert.
5547         * extension-priv.h: Revert.
5548         * expprint.c: Revert.
5549         * exec.h: Revert.
5550         * exec.c: Revert.
5551         * exceptions.c: Revert.
5552         * event-top.c: Revert.
5553         * event-loop.c: Revert.
5554         * eval.c: Revert.
5555         * elfread.c: Revert.
5556         * dwarf2read.h: Revert.
5557         * dwarf2read.c: Revert.
5558         * dwarf2loc.c: Revert.
5559         * dwarf2expr.h: Revert.
5560         * dwarf2expr.c: Revert.
5561         * dwarf2-frame.c: Revert.
5562         * dwarf2-frame-tailcall.c: Revert.
5563         * dwarf-index-write.h: Revert.
5564         * dwarf-index-write.c: Revert.
5565         * dwarf-index-common.c: Revert.
5566         * dwarf-index-cache.h: Revert.
5567         * dwarf-index-cache.c: Revert.
5568         * dummy-frame.c: Revert.
5569         * dtrace-probe.c: Revert.
5570         * disasm.h: Revert.
5571         * disasm.c: Revert.
5572         * disasm-selftests.c: Revert.
5573         * dictionary.c: Revert.
5574         * dicos-tdep.c: Revert.
5575         * demangle.c: Revert.
5576         * dcache.h: Revert.
5577         * dcache.c: Revert.
5578         * darwin-nat.h: Revert.
5579         * darwin-nat.c: Revert.
5580         * darwin-nat-info.c: Revert.
5581         * d-valprint.c: Revert.
5582         * d-namespace.c: Revert.
5583         * d-lang.c: Revert.
5584         * ctf.c: Revert.
5585         * csky-tdep.c: Revert.
5586         * csky-linux-tdep.c: Revert.
5587         * cris-tdep.c: Revert.
5588         * cris-linux-tdep.c: Revert.
5589         * cp-valprint.c: Revert.
5590         * cp-support.c: Revert.
5591         * cp-namespace.c: Revert.
5592         * cp-abi.c: Revert.
5593         * corelow.c: Revert.
5594         * corefile.c: Revert.
5595         * continuations.c: Revert.
5596         * completer.h: Revert.
5597         * completer.c: Revert.
5598         * complaints.c: Revert.
5599         * coffread.c: Revert.
5600         * coff-pe-read.c: Revert.
5601         * cli-out.h: Revert.
5602         * cli-out.c: Revert.
5603         * charset.c: Revert.
5604         * c-varobj.c: Revert.
5605         * c-valprint.c: Revert.
5606         * c-typeprint.c: Revert.
5607         * c-lang.c: Revert.
5608         * buildsym.c: Revert.
5609         * buildsym-legacy.c: Revert.
5610         * build-id.h: Revert.
5611         * build-id.c: Revert.
5612         * btrace.c: Revert.
5613         * bsd-uthread.c: Revert.
5614         * breakpoint.h: Revert.
5615         * breakpoint.c: Revert.
5616         * break-catch-throw.c: Revert.
5617         * break-catch-syscall.c: Revert.
5618         * break-catch-sig.c: Revert.
5619         * blockframe.c: Revert.
5620         * block.c: Revert.
5621         * bfin-tdep.c: Revert.
5622         * bfin-linux-tdep.c: Revert.
5623         * bfd-target.c: Revert.
5624         * bcache.c: Revert.
5625         * ax-general.c: Revert.
5626         * ax-gdb.h: Revert.
5627         * ax-gdb.c: Revert.
5628         * avr-tdep.c: Revert.
5629         * auxv.c: Revert.
5630         * auto-load.c: Revert.
5631         * arm-wince-tdep.c: Revert.
5632         * arm-tdep.c: Revert.
5633         * arm-symbian-tdep.c: Revert.
5634         * arm-pikeos-tdep.c: Revert.
5635         * arm-obsd-tdep.c: Revert.
5636         * arm-nbsd-tdep.c: Revert.
5637         * arm-nbsd-nat.c: Revert.
5638         * arm-linux-tdep.c: Revert.
5639         * arm-linux-nat.c: Revert.
5640         * arm-fbsd-tdep.c: Revert.
5641         * arm-fbsd-nat.c: Revert.
5642         * arm-bsd-tdep.c: Revert.
5643         * arch-utils.c: Revert.
5644         * arc-tdep.c: Revert.
5645         * arc-newlib-tdep.c: Revert.
5646         * annotate.h: Revert.
5647         * annotate.c: Revert.
5648         * amd64-windows-tdep.c: Revert.
5649         * amd64-windows-nat.c: Revert.
5650         * amd64-tdep.c: Revert.
5651         * amd64-sol2-tdep.c: Revert.
5652         * amd64-obsd-tdep.c: Revert.
5653         * amd64-obsd-nat.c: Revert.
5654         * amd64-nbsd-tdep.c: Revert.
5655         * amd64-nbsd-nat.c: Revert.
5656         * amd64-nat.c: Revert.
5657         * amd64-linux-tdep.c: Revert.
5658         * amd64-linux-nat.c: Revert.
5659         * amd64-fbsd-tdep.c: Revert.
5660         * amd64-fbsd-nat.c: Revert.
5661         * amd64-dicos-tdep.c: Revert.
5662         * amd64-darwin-tdep.c: Revert.
5663         * amd64-bsd-nat.c: Revert.
5664         * alpha-tdep.c: Revert.
5665         * alpha-obsd-tdep.c: Revert.
5666         * alpha-nbsd-tdep.c: Revert.
5667         * alpha-mdebug-tdep.c: Revert.
5668         * alpha-linux-tdep.c: Revert.
5669         * alpha-linux-nat.c: Revert.
5670         * alpha-bsd-tdep.c: Revert.
5671         * alpha-bsd-nat.c: Revert.
5672         * aix-thread.c: Revert.
5673         * agent.c: Revert.
5674         * addrmap.c: Revert.
5675         * ada-varobj.c: Revert.
5676         * ada-valprint.c: Revert.
5677         * ada-typeprint.c: Revert.
5678         * ada-tasks.c: Revert.
5679         * ada-lang.c: Revert.
5680         * aarch64-tdep.c: Revert.
5681         * aarch64-ravenscar-thread.c: Revert.
5682         * aarch64-newlib-tdep.c: Revert.
5683         * aarch64-linux-tdep.c: Revert.
5684         * aarch64-linux-nat.c: Revert.
5685         * aarch64-fbsd-tdep.c: Revert.
5686         * aarch64-fbsd-nat.c: Revert.
5687         * aarch32-linux-nat.c: Revert.
5688
5689 2019-04-05  Tom Tromey  <tom@tromey.com>
5690
5691         * ft32-tdep.c: Sort headers.
5692         * frv-tdep.c: Sort headers.
5693         * frv-linux-tdep.c: Sort headers.
5694         * frame.c: Sort headers.
5695         * frame-unwind.c: Sort headers.
5696         * frame-base.c: Sort headers.
5697         * fork-child.c: Sort headers.
5698         * findvar.c: Sort headers.
5699         * findcmd.c: Sort headers.
5700         * filesystem.c: Sort headers.
5701         * filename-seen-cache.h: Sort headers.
5702         * filename-seen-cache.c: Sort headers.
5703         * fbsd-tdep.c: Sort headers.
5704         * fbsd-nat.h: Sort headers.
5705         * fbsd-nat.c: Sort headers.
5706         * f-valprint.c: Sort headers.
5707         * f-typeprint.c: Sort headers.
5708         * f-lang.c: Sort headers.
5709         * extension.h: Sort headers.
5710         * extension.c: Sort headers.
5711         * extension-priv.h: Sort headers.
5712         * expprint.c: Sort headers.
5713         * exec.h: Sort headers.
5714         * exec.c: Sort headers.
5715         * exceptions.c: Sort headers.
5716         * event-top.c: Sort headers.
5717         * event-loop.c: Sort headers.
5718         * eval.c: Sort headers.
5719         * elfread.c: Sort headers.
5720         * dwarf2read.h: Sort headers.
5721         * dwarf2read.c: Sort headers.
5722         * dwarf2loc.c: Sort headers.
5723         * dwarf2expr.h: Sort headers.
5724         * dwarf2expr.c: Sort headers.
5725         * dwarf2-frame.c: Sort headers.
5726         * dwarf2-frame-tailcall.c: Sort headers.
5727         * dwarf-index-write.h: Sort headers.
5728         * dwarf-index-write.c: Sort headers.
5729         * dwarf-index-common.c: Sort headers.
5730         * dwarf-index-cache.h: Sort headers.
5731         * dwarf-index-cache.c: Sort headers.
5732         * dummy-frame.c: Sort headers.
5733         * dtrace-probe.c: Sort headers.
5734         * disasm.h: Sort headers.
5735         * disasm.c: Sort headers.
5736         * disasm-selftests.c: Sort headers.
5737         * dictionary.c: Sort headers.
5738         * dicos-tdep.c: Sort headers.
5739         * demangle.c: Sort headers.
5740         * dcache.h: Sort headers.
5741         * dcache.c: Sort headers.
5742         * darwin-nat.h: Sort headers.
5743         * darwin-nat.c: Sort headers.
5744         * darwin-nat-info.c: Sort headers.
5745         * d-valprint.c: Sort headers.
5746         * d-namespace.c: Sort headers.
5747         * d-lang.c: Sort headers.
5748         * ctf.c: Sort headers.
5749         * csky-tdep.c: Sort headers.
5750         * csky-linux-tdep.c: Sort headers.
5751         * cris-tdep.c: Sort headers.
5752         * cris-linux-tdep.c: Sort headers.
5753         * cp-valprint.c: Sort headers.
5754         * cp-support.c: Sort headers.
5755         * cp-namespace.c: Sort headers.
5756         * cp-abi.c: Sort headers.
5757         * corelow.c: Sort headers.
5758         * corefile.c: Sort headers.
5759         * continuations.c: Sort headers.
5760         * completer.h: Sort headers.
5761         * completer.c: Sort headers.
5762         * complaints.c: Sort headers.
5763         * coffread.c: Sort headers.
5764         * coff-pe-read.c: Sort headers.
5765         * cli-out.h: Sort headers.
5766         * cli-out.c: Sort headers.
5767         * charset.c: Sort headers.
5768         * c-varobj.c: Sort headers.
5769         * c-valprint.c: Sort headers.
5770         * c-typeprint.c: Sort headers.
5771         * c-lang.c: Sort headers.
5772         * buildsym.c: Sort headers.
5773         * buildsym-legacy.c: Sort headers.
5774         * build-id.h: Sort headers.
5775         * build-id.c: Sort headers.
5776         * btrace.c: Sort headers.
5777         * bsd-uthread.c: Sort headers.
5778         * breakpoint.h: Sort headers.
5779         * breakpoint.c: Sort headers.
5780         * break-catch-throw.c: Sort headers.
5781         * break-catch-syscall.c: Sort headers.
5782         * break-catch-sig.c: Sort headers.
5783         * blockframe.c: Sort headers.
5784         * block.c: Sort headers.
5785         * bfin-tdep.c: Sort headers.
5786         * bfin-linux-tdep.c: Sort headers.
5787         * bfd-target.c: Sort headers.
5788         * bcache.c: Sort headers.
5789         * ax-general.c: Sort headers.
5790         * ax-gdb.h: Sort headers.
5791         * ax-gdb.c: Sort headers.
5792         * avr-tdep.c: Sort headers.
5793         * auxv.c: Sort headers.
5794         * auto-load.c: Sort headers.
5795         * arm-wince-tdep.c: Sort headers.
5796         * arm-tdep.c: Sort headers.
5797         * arm-symbian-tdep.c: Sort headers.
5798         * arm-pikeos-tdep.c: Sort headers.
5799         * arm-obsd-tdep.c: Sort headers.
5800         * arm-nbsd-tdep.c: Sort headers.
5801         * arm-nbsd-nat.c: Sort headers.
5802         * arm-linux-tdep.c: Sort headers.
5803         * arm-linux-nat.c: Sort headers.
5804         * arm-fbsd-tdep.c: Sort headers.
5805         * arm-fbsd-nat.c: Sort headers.
5806         * arm-bsd-tdep.c: Sort headers.
5807         * arch-utils.c: Sort headers.
5808         * arc-tdep.c: Sort headers.
5809         * arc-newlib-tdep.c: Sort headers.
5810         * annotate.h: Sort headers.
5811         * annotate.c: Sort headers.
5812         * amd64-windows-tdep.c: Sort headers.
5813         * amd64-windows-nat.c: Sort headers.
5814         * amd64-tdep.c: Sort headers.
5815         * amd64-sol2-tdep.c: Sort headers.
5816         * amd64-obsd-tdep.c: Sort headers.
5817         * amd64-obsd-nat.c: Sort headers.
5818         * amd64-nbsd-tdep.c: Sort headers.
5819         * amd64-nbsd-nat.c: Sort headers.
5820         * amd64-nat.c: Sort headers.
5821         * amd64-linux-tdep.c: Sort headers.
5822         * amd64-linux-nat.c: Sort headers.
5823         * amd64-fbsd-tdep.c: Sort headers.
5824         * amd64-fbsd-nat.c: Sort headers.
5825         * amd64-dicos-tdep.c: Sort headers.
5826         * amd64-darwin-tdep.c: Sort headers.
5827         * amd64-bsd-nat.c: Sort headers.
5828         * alpha-tdep.c: Sort headers.
5829         * alpha-obsd-tdep.c: Sort headers.
5830         * alpha-nbsd-tdep.c: Sort headers.
5831         * alpha-mdebug-tdep.c: Sort headers.
5832         * alpha-linux-tdep.c: Sort headers.
5833         * alpha-linux-nat.c: Sort headers.
5834         * alpha-bsd-tdep.c: Sort headers.
5835         * alpha-bsd-nat.c: Sort headers.
5836         * aix-thread.c: Sort headers.
5837         * agent.c: Sort headers.
5838         * addrmap.c: Sort headers.
5839         * ada-varobj.c: Sort headers.
5840         * ada-valprint.c: Sort headers.
5841         * ada-typeprint.c: Sort headers.
5842         * ada-tasks.c: Sort headers.
5843         * ada-lang.c: Sort headers.
5844         * aarch64-tdep.c: Sort headers.
5845         * aarch64-ravenscar-thread.c: Sort headers.
5846         * aarch64-newlib-tdep.c: Sort headers.
5847         * aarch64-linux-tdep.c: Sort headers.
5848         * aarch64-linux-nat.c: Sort headers.
5849         * aarch64-fbsd-tdep.c: Sort headers.
5850         * aarch64-fbsd-nat.c: Sort headers.
5851         * aarch32-linux-nat.c: Sort headers.
5852
5853 2019-04-04  Tom Tromey  <tom@tromey.com>
5854
5855         * varobj.c (varobj_create): Update.
5856         * rust-exp.y (struct rust_parser) <update_innermost_block,
5857         lookup_symbol>: New methods.
5858         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5859         Rename.
5860         (rust_parser::rust_lookup_type)
5861         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5862         * printcmd.c (display_command, do_one_display): Update.
5863         * parser-defs.h (struct parser_state) <parser_state>: Add
5864         "tracker" parameter.
5865         (block_tracker): New member.
5866         (class innermost_block_tracker) <innermost_block_tracker>: Add
5867         "types" parameter.
5868         <reset>: Remove method.
5869         (innermost_block): Don't declare.
5870         (null_post_parser): Update.
5871         * parse.c (innermost_block): Remove global.
5872         (write_dollar_variable): Update.
5873         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5874         Remove "tracker_types" parameter.
5875         (parse_expression): Add "tracker" parameter.
5876         (parse_expression_for_completion): Update.
5877         (null_post_parser): Add "tracker" parameter.
5878         * p-exp.y: Update rules.
5879         * m2-exp.y: Update rules.
5880         * language.h (struct language_defn) <la_post_parser>: Add
5881         "tracker" parameter.
5882         * go-exp.y: Update rules.
5883         * f-exp.y: Update rules.
5884         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5885         parameter.
5886         * d-exp.y: Update rules.
5887         * c-exp.y: Update rules.
5888         * breakpoint.c (set_breakpoint_condition): Create an
5889         innermost_block_tracker.
5890         (watch_command_1): Likewise.
5891         * ada-lang.c (resolve): Add "tracker" parameter.
5892         (resolve_subexp): Likewise.
5893         * ada-exp.y (write_var_from_sym): Update.
5894
5895 2019-04-04  Tom Tromey  <tom@tromey.com>
5896
5897         * type-stack.h: New file.
5898         * type-stack.c: New file.
5899         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5900         type-stack.h.
5901         (insert_into_type_stack, insert_type, push_type, push_type_int)
5902         (insert_type_address_space, pop_type, pop_type_int)
5903         (pop_typelist, pop_type_stack, append_type_stack)
5904         (push_type_stack, get_type_stack, push_typelist)
5905         (follow_type_instance_flags, follow_types): Don't declare.
5906         * parse.c (type_stack): Remove global.
5907         (parse_exp_in_context): Update.
5908         (insert_into_type_stack, insert_type, push_type, push_type_int)
5909         (insert_type_address_space, pop_type, pop_type_int)
5910         (pop_typelist, pop_type_stack, append_type_stack)
5911         (push_type_stack, get_type_stack, push_typelist)
5912         (follow_type_instance_flags, follow_types): Remove (moved to
5913         type-stack.c).
5914         * f-exp.y (type_stack): New global.
5915         Update rules.
5916         (push_kind_type, f_parse): Update.
5917         * d-exp.y (type_stack): New global.
5918         Update rules.
5919         (d_parse): Update.
5920         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5921         Update rules.
5922         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5923         (HFILES_NO_SRCDIR): Add type-stack.h.
5924
5925 2019-04-04  Tom Tromey  <tom@tromey.com>
5926
5927         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5928         (rust_parser::convert_ast_to_expression, rust_parse)
5929         (rust_lex_test_completion, rust_lex_tests): Update.
5930         * parser-defs.h (struct expr_completion_state): New.
5931         (struct parser_state) <parser_state>: Add completion parameter.
5932         <mark_struct_expression, mark_completion_tag>: New methods.
5933         <parse_completion, m_completion_state>: New members.
5934         (prefixify_expression, null_post_parser): Update.
5935         (mark_struct_expression, mark_completion_tag): Don't declare.
5936         * parse.c (parse_completion, expout_last_struct)
5937         (expout_tag_completion_type, expout_completion_name): Remove
5938         globals.
5939         (parser_state::mark_struct_expression)
5940         (parser_state::mark_completion_tag): Now methods.
5941         (prefixify_expression): Add last_struct parameter.
5942         (prefixify_subexp): Likewise.
5943         (parse_exp_1): Update.
5944         (parse_exp_in_context): Add cstate parameter.  Update.
5945         (parse_expression_for_completion): Create an
5946         expr_completion_state.
5947         (null_post_parser): Add "completion" parameter.
5948         * p-exp.y: Update rules.
5949         (yylex): Update.
5950         * language.h (struct language_defn) <la_post_parser>: Add
5951         "completing" parameter.
5952         * go-exp.y: Update rules.
5953         (lex_one_token): Update.
5954         * expression.h (parse_completion): Don't declare.
5955         * d-exp.y: Update rules.
5956         (lex_one_token): Update rules.
5957         * c-exp.y: Update rules.
5958         (lex_one_token): Update.
5959         * ada-lang.c (resolve): Add "parse_completion" parameter.
5960         (resolve_subexp): Likewise.
5961         (ada_resolve_function): Likewise.
5962
5963 2019-04-04  Tom Tromey  <tom@tromey.com>
5964
5965         * parser-defs.h (struct parser_state) <start_arglist,
5966         end_arglist>: New methods.
5967         <arglist_len, m_funcall_chain>: New members.
5968         (arglist_len, start_arglist, end_arglist): Don't declare.
5969         * parse.c (arglist_len, funcall_chain): Remove global.
5970         (start_arglist, end_arglist): Remove functions.
5971         (parse_exp_in_context): Update.
5972         * p-exp.y: Update rules.
5973         * m2-exp.y: Update rules.
5974         * go-exp.y: Update rules.
5975         * f-exp.y: Update rules.
5976         * d-exp.y: Update rules.
5977         * c-exp.y: Update rules.
5978
5979 2019-04-04  Tom Tromey  <tom@tromey.com>
5980
5981         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5982         lex_operator, push_back>: New methods.
5983         Update all rules.
5984         (rust_parser::lex_hex, lex_escape): Rename and update.
5985         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5986         (rust_parser::lex_operator): Rename and update.
5987         (rust_parser::lex_number, rustyylex, rustyyerror)
5988         (rust_lex_test_init, rust_lex_test_sequence)
5989         (rust_lex_test_push_back, rust_lex_tests): Update.
5990         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5991         parameter.
5992         <lexptr, prev_lexptr>: New members.
5993         (lexptr, prev_lexptr): Don't declare.
5994         * parse.c (lexptr, prev_lexptr): Remove globals.
5995         (parse_exp_in_context): Update.
5996         * p-exp.y (yylex, yyerror): Update.
5997         * m2-exp.y (parse_number, yylex, yyerror): Update.
5998         * go-exp.y (lex_one_token, yyerror): Update.
5999         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6000         * d-exp.y (lex_one_token, yyerror): Update.
6001         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6002         (lex_one_token, yyerror): Update.
6003         * ada-lex.l (YY_INPUT): Update.
6004         (rewind_to_char): Update.
6005         * ada-exp.y (yyerror): Update.
6006
6007 2019-04-04  Tom Tromey  <tom@tromey.com>
6008
6009         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6010         * parser-defs.h (struct parser_state) <parser_state>: Add new
6011         parameter.
6012         <comma_terminates>: New member.
6013         (comma_terminates): Don't declare global.
6014         * parse.c (comma_terminates): Remove global.
6015         (parse_exp_in_context): Update.
6016         * p-exp.y (yylex): Update.
6017         * m2-exp.y (yylex): Update.
6018         * go-exp.y (lex_one_token): Update.
6019         * f-exp.y (yylex): Update.
6020         * d-exp.y (lex_one_token): Update.
6021         * c-exp.y (lex_one_token): Update.
6022         * ada-lex.l: Update.
6023
6024 2019-04-04  Tom Tromey  <tom@tromey.com>
6025
6026         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6027         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6028         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6029         * parser-defs.h (paren_depth): Don't declare.
6030         * parse.c (paren_depth): Remove global.
6031         (parse_exp_in_context): Update.
6032         * p-exp.y (paren_depth): New global.
6033         (pascal_parse): Initialize it.
6034         * m2-exp.y (paren_depth): New global.
6035         (m2_parse): Initialize it.
6036         * go-exp.y (paren_depth): New global.
6037         (go_parse): Initialize it.
6038         * f-exp.y (paren_depth): New global.
6039         (f_parse): Initialize it.
6040         * d-exp.y (paren_depth): New global.
6041         (d_parse): Initialize it.
6042         * c-exp.y (paren_depth): New global.
6043         (c_parse): Initialize it.
6044         * ada-lex.l (paren_depth): New global.
6045         (lexer_init): Initialize it.
6046
6047 2019-04-04  Tom Tromey  <tom@tromey.com>
6048
6049         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6050         (rust_parser::convert_ast_to_type)
6051         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6052         * parser-defs.h (struct parser_state) <parser_state>: Add
6053         parameters.  Initialize new members.
6054         <expression_context_block, expression_context_pc>: New members.
6055         * parse.c (expression_context_block, expression_context_pc):
6056         Remove globals.
6057         (parse_exp_in_context): Update.
6058         * p-exp.y: Update all rules.
6059         (yylex): Update.
6060         * m2-exp.y: Update all rules.
6061         (yylex): Update.
6062         * go-exp.y (yylex): Update.
6063         * f-exp.y (yylex): Update.
6064         * d-exp.y: Update all rules.
6065         (yylex): Update.
6066         * c-exp.y: Update all rules.
6067         (lex_one_token, classify_name, yylex, c_parse): Update.
6068         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6069
6070 2019-04-04  Tom Tromey  <tom@tromey.com>
6071
6072         * gdbarch.h, gdbarch.c: Rebuild.
6073         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6074         * stap-probe.h:
6075         (struct stap_parse_info): Replace "parser_state" with
6076         "expr_builder".
6077         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6078         (parser_state): New class.
6079         * parse.c (expr_builder): Rename.
6080         (expr_builder::release): Rename.
6081         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6082         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6083         (write_exp_elt_longcst, write_exp_elt_floatcst)
6084         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6085         (write_exp_string_vector, write_exp_bitstring)
6086         (write_exp_msymbol, mark_struct_expression)
6087         (write_dollar_variable)
6088         (insert_type_address_space, increase_expout_size): Replace
6089         "parser_state" with "expr_builder".
6090         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6091         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6092         "parser_state" with "expr_builder".
6093
6094 2019-04-04  Tom Tromey  <tom@tromey.com>
6095
6096         * rust-exp.y: Replace "parse_language" with method call.
6097         * p-exp.y:
6098         (yylex): Replace "parse_language" with method call.
6099         * m2-exp.y:
6100         (yylex): Replace "parse_language" with method call.
6101         * go-exp.y (classify_name): Replace "parse_language" with method
6102         call.
6103         * f-exp.y (yylex): Replace "parse_language" with method call.
6104         * d-exp.y (lex_one_token): Replace "parse_language" with method
6105         call.
6106         * c-exp.y:
6107         (lex_one_token, classify_name, yylex): Replace "parse_language"
6108         with method call.
6109         * ada-exp.y (find_primitive_type, type_char)
6110         (type_system_address): Replace "parse_language" with method call.
6111
6112 2019-04-04  Tom Tromey  <tom@tromey.com>
6113
6114         * rust-exp.y: Replace "parse_gdbarch" with method call.
6115         * parse.c (write_dollar_variable, insert_type_address_space):
6116         Replace "parse_gdbarch" with method call.
6117         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6118         call.
6119         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6120         call.
6121         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6122         "parse_gdbarch" with method call.
6123         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6124         with method call.
6125         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6126         "parse_gdbarch" with method call.
6127         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6128         "parse_gdbarch" with method call.
6129         * c-exp.y (parse_type, parse_number, classify_name): Replace
6130         "parse_gdbarch" with method call.
6131         * ada-lex.l: Replace "parse_gdbarch" with method call.
6132         * ada-exp.y (parse_type, find_primitive_type, type_char)
6133         (type_system_address): Replace "parse_gdbarch" with method call.
6134
6135 2019-04-04  Tom Tromey  <tom@tromey.com>
6136
6137         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6138         * stap-probe.c (stap_parse_argument): Update.
6139         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6140         initial_size parameter.
6141         * rust-exp.y (rust_lex_tests): Update.
6142         * parse.c (parser_state): Update.
6143         (parse_exp_in_context): Update.
6144         * parser-defs.h (struct parser_state) <parser_state>: Remove
6145         "initial_size" parameter.
6146
6147 2019-04-04  Tom Tromey  <tom@tromey.com>
6148
6149         * parser-defs.h (increase_expout_size): Don't declare.
6150         * parse.c (increase_expout_size): Now static.
6151
6152 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6153
6154         * gnu-nat.c (gnu_nat_target::wait): Fix
6155         target_waitstatus_to_string call.
6156
6157 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6158
6159         * eval.c (evaluate_subexp_standard): Handle internal functions
6160         during Fortran function call handling.
6161
6162 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6163
6164         * NEWS: Mention new internal functions.
6165         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6166         (read_base_type): Use dwarf2_init_complex_target_type.
6167         * value.c (creal_internal_fn): New function.
6168         (cimag_internal_fn): New function.
6169         (_initialize_values): Register new internal functions.
6170
6171 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6172
6173         * infrun.c (stop_all_threads): If debug_infrun, always
6174         trace the wait status after wait_one, using
6175         target_waitstatus_to_string and target_pid_to_str.
6176         (handle_inferior_event): Replace various trace of
6177         wait status kind by a single trace.
6178         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6179         wait status kind image by target_waitstatus_to_string.
6180         * target/waitstatus.c (target_waitstatus_to_string): Fix
6181         obsolete comment.
6182
6183 2019-04-01  Tom Tromey  <tromey@adacore.com>
6184
6185         PR symtab/23331:
6186         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6187
6188 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6189             Pedro Alves  <palves@redhat.com>
6190
6191         * top.c (quit_force): Call 'finalize_values'.
6192         * value.c (finalize_values): New function.
6193         * value.h (finalize_values): Declare.
6194
6195 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6196
6197         * NEWS: Announce $_gdb_major and $_gdb_minor.
6198
6199         * top.c (init_gdb_version_vars): New function.
6200         (gdb_init): Call init_gdb_version_vars.
6201
6202 2019-03-29  Tom Tromey  <tromey@adacore.com>
6203
6204         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6205         help text.  Remove dead code.
6206
6207 2019-03-29  Keith Seitz  <keiths@redhat.com>
6208
6209         From Siddhesh Poyarekar:
6210         * f-lang.h (f77_get_upperbound): Return LONGEST.
6211         (f77_get_lowerbound): Likewise.
6212         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6213         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6214         print them.
6215         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6216         plongest to format print it.
6217         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6218         (f77_get_upperbound): Likewise.
6219         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6220         LOWER_BOUND to LONGEST.
6221         (f77_create_arrayprint_offset_tbl): Likewise.
6222
6223 2019-03-29  Keith Seitz  <keiths@redhat.com>
6224
6225         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6226         %s/pulongest for TYPE_LENGTH instead of %d in format
6227         strings.
6228         * ada-typerint.c (ada_print_type): Likewise.
6229         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6230         * compile/compile-c-support.c (generate_register_struct): Likewise.
6231         * gdbtypes.c (recursive_dump_type): Likewise.
6232         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6233         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6234         instead of %d in format strings.
6235         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6236         to std::min to ULONGEST.
6237         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6238         instead of %d in format strings.
6239         * tracepoint.c (info_scope_command): Likewise.
6240         * typeprint.c (print_offset_data::update)
6241         (print_offset_data::finish): Likewise.
6242         * xtensa-tdep.c (xtensa_store_return_value)
6243         (xtensa_push_dummy_call): Likewise.
6244
6245 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6246
6247         * windows-nat.c (display_selector): Fixed format specifications
6248         for 64-bit Cygwin.
6249
6250 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6251
6252         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6253
6254 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6255
6256         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6257         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6258         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6259         (nios2_linux_init_abi): Install it.
6260
6261 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6262
6263         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6264
6265 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6266
6267         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6268
6269 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6270             Tom Tromey  <tromey@adacore.com>
6271
6272         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6273
6274 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6275
6276         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6277         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6278         method to compute the bounds of range types. Also print "[evaluated]"
6279         if the bounds' values come from a dynamic evaluation.
6280
6281 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6282
6283         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6284         whitespace when pretty printing is on.
6285
6286 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6287
6288         * ppc-linux-nat.c: Add include.
6289
6290 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6291
6292         * NEWS: Mention AArch64 Pointer Authentication.
6293
6294 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6295
6296         * arm-linux-nat.c: Add include.
6297
6298 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6299
6300         * source-cache.c (source_cache::get_source_lines): Re-read
6301         fullname after calling open_source_file.
6302
6303 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6304
6305         * NEWS: Mention TLS support for FreeBSD.
6306
6307 2019-03-25  Tom Tromey  <tromey@adacore.com>
6308
6309         * minsyms.c (BUNCH_SIZE): Update comment.
6310         (~minimal_symbol_reader): Remove old comment.
6311         (compact_minimal_symbols): Update comment.
6312         (minimal_symbol_reader::install): Remove old comment.  Update
6313         other comments.
6314
6315 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6316
6317         * s390-linux-nat.c: Add include.
6318
6319 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6320
6321         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6322         Call linux_get_hwcap.
6323         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6324         Likewise.
6325         (aarch64_linux_get_hwcap): Remove function.
6326         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6327         declaration.
6328         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6329         linux_get_hwcap.
6330         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6331         * linux-tdep.c (linux_get_hwcap): Add function.
6332         (linux_get_hwcap2): Likewise.
6333         * linux-tdep.h (linux_get_hwcap): Add declaration.
6334         (linux_get_hwcap2): Likewise.
6335         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6336         (ppc_linux_get_hwcap2): Likewise.
6337         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6338         linux_get_hwcap.
6339         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6340         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6341         (ppc_linux_nat_target::read_description): Likewise.
6342         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6343         * s390-linux-nat.c: Likewise.
6344         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6345
6346 2019-03-24  Tom Tromey  <tom@tromey.com>
6347
6348         * ada-lang.c (standard_lookup): Simplify initialization.
6349         (ada_lookup_symbol_nonlocal): Simplify return.
6350         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6351         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6352         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6353         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6354         initialization.
6355         * solib.c (solib_global_lookup): Simplify.
6356         * symtab.c (null_block_symbol): Remove.
6357         (symbol_cache_lookup): Simplify returns.
6358         (lookup_language_this): Simplify returns.
6359         (lookup_symbol_aux): Simplify return.
6360         (lookup_local_symbol): Simplify returns.
6361         (lookup_global_symbol_from_objfile): Simplify return.
6362         (lookup_symbol_in_objfile_symtabs)
6363         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6364         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6365         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6366         * cp-namespace.c (cp_lookup_bare_symbol)
6367         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6368         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6369         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6370         (cp_lookup_symbol_via_imports): Simplify initialization.
6371         (find_symbol_in_baseclass): Likewise.
6372         * symtab.h (null_block_symbol): Remove.
6373         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6374         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6375         (d_lookup_symbol_module): Likewise.
6376         (find_symbol_in_baseclass): Simplify initialization.
6377
6378 2019-03-24  Tom Tromey  <tom@tromey.com>
6379
6380         * expression.h: Don't include symtab.h.
6381         (struct block): Forward declare.
6382
6383 2019-03-24  Tom Tromey  <tom@tromey.com>
6384
6385         * c-exp.y (typebase): Remove casts.
6386         * gdbtypes.c (lookup_unsigned_typename, )
6387         (lookup_signed_typename): Remove cast.
6388         * eval.c (parse_to_comma_and_eval): Remove cast.
6389         * parse.c (write_dollar_variable): Remove cast.
6390         * block.h (struct block) <superblock>: Now const.
6391         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6392         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6393         (map_block): Make "block" const.
6394         * symfile.h (struct quick_symbol_functions)
6395         <map_matching_symbols>: Constify block argument to "callback".
6396         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6397         const.
6398         (find_pc_sect_compunit_symtab): Make "b" const.
6399         (find_symbol_at_address): Likewise.
6400         (search_symbols): Likewise.
6401         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6402         (dw2_debug_names_lookup_symbol): Likewise.
6403         (dw2_map_matching_symbols): Update.
6404         * p-valprint.c (pascal_val_print): Remove "block".
6405         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6406         (aux_add_nonlocal_symbols): Make "block" const.
6407         (resolve_subexp): Remove cast.
6408         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6409         const.
6410         (iterate_over_file_blocks): Likewise.
6411         * f-exp.y (%union) <bval>: Remove.
6412         * coffread.c (patch_opaque_types): Make "b" const.
6413         * spu-tdep.c (spu_catch_start): Make "block" const.
6414         * c-valprint.c (print_unpacked_pointer): Remove "block".
6415         * symmisc.c (dump_symtab_1): Make "b" const.
6416         (block_depth): Make "block" const.
6417         * d-exp.y (%union) <bval>: Remove.
6418         * cp-support.h (cp_lookup_rtti_type): Update.
6419         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6420         * psymtab.c (psym_lookup_symbol): Make "block" const.
6421         (maintenance_check_psymtabs): Make "b" const.
6422         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6423         (enumerate_locals, enumerate_args): Update.
6424         * python/py-symtab.c (stpy_global_block): Make "block" const.
6425         (stpy_static_block): Likewise.
6426         * inline-frame.c (block_starting_point_at): Make "new_block"
6427         const.
6428         * block.c (find_block_in_blockvector): Make return type const.
6429         (blockvector_for_pc_sect): Make "b" const.
6430         (find_block_in_blockvector): Make "b" const.
6431
6432 2019-03-23  Tom Tromey  <tom@tromey.com>
6433
6434         * varobj.c (varobj_create): Update.
6435         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6436         * printcmd.c (display_command, do_one_display): Don't reset
6437         innermost_block.
6438         * parser-defs.h (enum innermost_block_tracker_type): Move to
6439         expression.h.
6440         (innermost_block): Update comment.
6441         * parse.c (parse_exp_1): Add tracker_types parameter.
6442         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6443         tracker_types parameter.  Reset innermost_block.
6444         (parse_exp_in_context): Remove.
6445         (parse_expression_for_completion): Update.
6446         * objfiles.c (~objfile): Don't reset expression_context_block or
6447         innermost_block.
6448         * expression.h (enum innermost_block_tracker_type): Move from
6449         parser-defs.h.
6450         (parse_exp_1): Add tracker_types parameter.
6451         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6452         reset innermost_block.
6453
6454 2019-03-23  Tom Tromey  <tom@tromey.com>
6455
6456         * objfiles.h: Include bcache.h.
6457
6458 2019-03-23  Tom Tromey  <tom@tromey.com>
6459
6460         * linespec.c (get_current_search_block): Use
6461         scoped_restore_current_language.
6462         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6463
6464 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6465             Jiong Wang  <jiong.wang@arm.com>
6466
6467         * aarch64-linux-tdep.c
6468         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6469         section.
6470         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6471
6472 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6473             Jiong Wang  <jiong.wang@arm.com>
6474
6475         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6476         instructions.
6477         (aarch64_analyze_prologue_test): Add PACIASP test.
6478         (aarch64_prologue_prev_register): Unmask PC value.
6479
6480 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6481             Jiong Wang  <jiong.wang@arm.com>
6482
6483         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6484         (aarch64_dwarf2_prev_register): Unmask PC value.
6485         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6486         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6487         DW_CFA_AARCH64_negate_ra_state.
6488         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6489
6490 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6491             Jiong Wang  <jiong.wang@arm.com>
6492
6493         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6494         registers.
6495         (aarch64_pseudo_register_name): Likewise.
6496         (aarch64_pseudo_register_type): Likewise.
6497         (aarch64_pseudo_register_reggroup_p): Likewise.
6498         (aarch64_gdbarch_init): Add pauth registers.
6499         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6500         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6501         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6502         (struct gdbarch_tdep): Add regnum for ra_state.
6503
6504 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6505             Jiong Wang  <jiong.wang@arm.com>
6506
6507         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6508
6509 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6510             Jiong Wang  <jiong.wang@arm.com>
6511
6512         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6513         function.
6514         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6515         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6516         (aarch64_gdbarch_init): Add puth registers.
6517         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6518         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6519         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6520
6521 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6522             Jiong Wang  <jiong.wang@arm.com>
6523
6524         * aarch64-linux-nat.c
6525         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6526         * aarch64-linux-tdep.c
6527         (aarch64_linux_core_read_description): Likewise.
6528         (aarch64_linux_get_hwcap): New function.
6529         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6530         (aarch64_linux_get_hwcap): New declaration.
6531
6532 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6533             Jiong Wang  <jiong.wang@arm.com>
6534
6535         * aarch64-linux-nat.c
6536         (aarch64_linux_nat_target::read_description): Add pauth param.
6537         * aarch64-linux-tdep.c
6538         (aarch64_linux_core_read_description): Likewise.
6539         * aarch64-tdep.c (struct target_desc): Add in pauth.
6540         (aarch64_read_description): Add pauth param.
6541         (aarch64_gdbarch_init): Likewise.
6542         * aarch64-tdep.h (aarch64_read_description): Likewise.
6543         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6544         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6545         * features/Makefile: Add new files.
6546         * features/aarch64-pauth.c: New file.
6547         * features/aarch64-pauth.xml: New file.
6548
6549 2019-03-20  Tom Tromey  <tromey@adacore.com>
6550
6551         * infrun.c (handle_inferior_event): Rename from
6552         handle_inferior_event_1.  Create a scoped_value_mark.
6553         (handle_inferior_event): Remove.
6554
6555 2019-03-19  Tom Tromey  <tromey@adacore.com>
6556
6557         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6558         * infrun.h (print_stop_event): Add "displays" parameter.
6559         * infrun.c (print_stop_event): Add "displays" parameter.
6560
6561 2019-03-19  Pedro Alves  <palves@redhat.com>
6562
6563         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6564         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6565         to -1.  Fix TABs vs spaces.
6566         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6567         * tui/tui-out.h (tui_ui_out) Add intro comments.
6568         <m_line, m_start_of_line>: In-class initialize, and add describing
6569         comment.
6570
6571 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6572
6573         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6574         variable names.
6575         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6576
6577 2019-03-18  Pedro Alves  <palves@redhat.com>
6578             Eli Zaretskii <eliz@gnu.org>
6579
6580         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6581         m_line and m_start_of_line.
6582
6583 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6584
6585         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6586         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6587         it returns a newline.  This fixes a regression in TU mode, whereby
6588         the next line is output on the same screen line as the user input.
6589
6590 2019-03-18  Tom Tromey  <tromey@adacore.com>
6591
6592         * minsyms.c (minimal_symbol_reader::install): Remove call to
6593         obstack_blank.
6594
6595 2019-03-18  Pedro Alves  <palves@redhat.com>
6596
6597         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6598         New globals.
6599         (apply_style): New, factored out from ...
6600         (apply_ansi_escape): ... this.  Handle reverse video mode.
6601         (tui_set_reverse_mode): New function.
6602         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6603         * tui/tui-winsource.c (tui_show_source_line): Use
6604         tui_set_reverse_mode instead of setting A_STANDOUT.
6605         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6606         New setter methods.
6607
6608 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6609
6610         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6611         Handle tabs.
6612
6613 2019-03-18  Tom Tromey  <tromey@adacore.com>
6614
6615         * ada-lang.c (empty_array): Add "high" parameter.
6616         (ada_evaluate_subexp): Update.
6617
6618 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6619
6620         * unittests/string_view-selftests.c: Define
6621         _initialize_string_view_selftests unconditionally.
6622
6623 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6624
6625         PR gdb/24350
6626         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6627
6628 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6629
6630         PR gdb/24351
6631         * windows-nat.c (display_selector): Fix format specifiers.
6632
6633 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6634
6635         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6636         tui_refill_source_window instead of tui_refresh_win, to update the
6637         current execution line.  This fixes redisplay of the current line
6638         when stepping through the code with "next" or "step".
6639
6640 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6641
6642         * source-cache.c (source_cache::get_source_lines): Call
6643         find_source_lines to initialize s->nlines.  This fixes vertical
6644         scrolling of TUI source window when the DOWN arrow is pressed.
6645
6646 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6647
6648         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6649         linux-thread-db.c (_initialize_thread_db): Likewise.
6650
6651 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6652
6653         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6654         wclrtoeol in tui_show_source_line".  This reverts changes made in
6655         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6656
6657 2019-03-15  Tom Tromey  <tom@tromey.com>
6658
6659         * symtab.h (struct minimal_symbol): Derive from
6660         general_symbol_info.
6661         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6662         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6663         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6664         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6665         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6666         (MSYMBOL_SEARCH_NAME): Update.
6667         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6668         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6669         * minsyms.c (minimal_symbol_reader::record_full): Update.
6670
6671 2019-03-15  Tom Tromey  <tom@tromey.com>
6672
6673         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6674
6675 2019-03-15  Tom Tromey  <tom@tromey.com>
6676
6677         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6678         unique_xmalloc_ptr.
6679         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6680         Update.
6681         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6682         (build_minimal_symbol_hash_tables)
6683         (minimal_symbol_reader::install): Update.
6684
6685 2019-03-15  Tom Tromey  <tom@tromey.com>
6686
6687         * symtab.c (create_demangled_names_hash): Update.
6688         (symbol_set_names): Update.
6689         * objfiles.h (struct objfile_per_bfd_storage)
6690         <demangled_names_hash>: Now an htab_up.
6691         * objfiles.c (objfile_per_bfd_storage): Simplify.
6692
6693 2019-03-15  Tom Tromey  <tom@tromey.com>
6694
6695         * objfiles.h (struct objfile_per_bfd_storage): Declare
6696         destructor.
6697         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6698         New.
6699         (get_objfile_bfd_data): Use new.  Don't initialize
6700         language_of_main.
6701         (free_objfile_per_bfd_storage): Remove.
6702         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6703
6704 2019-03-15  Tom Tromey  <tom@tromey.com>
6705
6706         * symfile.c (reread_symbols): Update.
6707         * objfiles.c (objfile::objfile): Update.
6708         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6709         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6710         comment.
6711         (minimal_symbol_reader::install): Update.
6712         (terminate_minimal_symbol_table): Remove.
6713         * jit.c (jit_object_close_impl): Update.
6714
6715 2019-03-15  Tom Tromey  <tom@tromey.com>
6716
6717         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6718         initializations.
6719
6720 2019-03-15  Tom Tromey  <tom@tromey.com>
6721
6722         * objfiles.h (struct objfile_per_bfd_storage)
6723         <demangled_hash_languages>: Now a bitset.
6724         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6725         (lookup_minimal_symbol): Update.
6726
6727 2019-03-15  Tom Tromey  <tom@tromey.com>
6728
6729         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6730         Don't return the symbol.
6731         * coffread.c (record_minimal_symbol): Use record_full.
6732
6733 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6734
6735         The MS-Windows port of ncurses fails to switch to a color pair if
6736         one or both of the colors are the implicit default colors.  This
6737         change records the default colors when TUI is initialized, and
6738         then specifies them explicitly when a color pair uses the default
6739         colors.  This allows color styling in TUI mode on MS-Windows.
6740
6741         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6742         ncurses_norm_attr.
6743         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6744         colors in ncurses_norm_attr.
6745         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6746         "none", replace it with the default color recorded in
6747         ncurses_norm_attr.
6748
6749 2019-03-14  Tom Tromey  <tromey@adacore.com>
6750
6751         * source-cache.h (class source_cache) <get_source_lines>: Return
6752         std::string.
6753         * source-cache.c (source_cache::extract_lines): Handle case where
6754         first_pos==npos.  Return std::string.
6755         (source_cache::get_source_lines): Update.
6756
6757 2019-03-14  Tom Tromey  <tromey@adacore.com>
6758
6759         * NEWS: Add item for "style sources" commands.
6760         * source-cache.c (source_cache::get_source_lines): Check
6761         source_styling.
6762         * cli/cli-style.c (source_styling): New global.
6763         (_initialize_cli_style): Add "style sources" commands.
6764         (show_style_sources): New function.
6765         * cli/cli-style.h (source_styling): Declare.
6766
6767 2019-03-14  Pedro Alves  <palves@redhat.com>
6768             Tom Tromey  <tromey@adacore.com>
6769
6770         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6771         * tui/tui-winsource.c (tui_refill_source_window): New function,
6772         from...
6773         (tui_horizontal_source_scroll): ... here.  Move some logic.
6774         * cli/cli-style.c (set_style_enabled): Notify new observable.
6775         * tui/tui-hooks.c (tui_redisplay_source): New function.
6776         (tui_attach_detach_observers): Attach or detach
6777         tui_redisplay_source.
6778         * observable.h (source_styling_changed): New observable.
6779         * observable.c: Define source_styling_changed observable.
6780
6781 2019-03-13  Tom Tromey  <tromey@adacore.com>
6782
6783         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6784         (i386_gnu_nat_target::store_registers): Update.
6785         * target-debug.h (target_debug_print_std_string): New macro.
6786         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6787         * windows-tdep.c (display_one_tib): Update.
6788         * tui/tui-stack.c (tui_make_status_line): Update.
6789         * top.c (print_inferior_quit_action): Update.
6790         * thread.c (thr_try_catch_cmd): Update.
6791         (add_thread_with_info): Update.
6792         (thread_target_id_str): Update.
6793         (thr_try_catch_cmd): Update.
6794         (thread_command): Update.
6795         (thread_find_command): Update.
6796         * record-btrace.c (record_btrace_target::info_record)
6797         (record_btrace_resume_thread, record_btrace_target::resume)
6798         (record_btrace_cancel_resume, record_btrace_step_thread)
6799         (record_btrace_target::wait, record_btrace_target::wait)
6800         (record_btrace_target::wait, record_btrace_target::stop): Update.
6801         * progspace.c (print_program_space): Update.
6802         * process-stratum-target.c
6803         (process_stratum_target::thread_address_space): Update.
6804         * linux-fork.c (linux_fork_mourn_inferior)
6805         (detach_checkpoint_command, info_checkpoints_command)
6806         (linux_fork_context): Update.
6807         (linux_fork_detach): Update.
6808         (class scoped_switch_fork_info): Update.
6809         (delete_checkpoint_command): Update.
6810         * infrun.c (follow_fork_inferior): Update.
6811         (follow_fork_inferior): Update.
6812         (proceed_after_vfork_done): Update.
6813         (handle_vfork_child_exec_or_exit): Update.
6814         (follow_exec): Update.
6815         (displaced_step_prepare_throw): Update.
6816         (displaced_step_restore): Update.
6817         (start_step_over): Update.
6818         (resume_1): Update.
6819         (clear_proceed_status_thread): Update.
6820         (proceed): Update.
6821         (print_target_wait_results): Update.
6822         (do_target_wait): Update.
6823         (context_switch): Update.
6824         (stop_all_threads): Update.
6825         (restart_threads): Update.
6826         (finish_step_over): Update.
6827         (handle_signal_stop): Update.
6828         (switch_back_to_stepped_thread): Update.
6829         (keep_going_pass_signal): Update.
6830         (print_exited_reason): Update.
6831         (normal_stop): Update.
6832         * inferior.c (inferior_pid_to_str): Change return type.
6833         (print_selected_inferior): Update.
6834         (add_inferior): Update.
6835         (detach_inferior): Update.
6836         * dummy-frame.c (fprint_dummy_frames): Update.
6837         * dcache.c (dcache_info_1): Update.
6838         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6839         (btrace_fetch, btrace_clear): Update.
6840         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6841         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6842         type.
6843         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6844         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6845         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6846         * gdbarch.c, gdbarch.h: Rebuild.
6847         * gdbarch.sh (core_pid_to_str): Change return type.
6848         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6849         return type.
6850         (windows_nat_target::pid_to_str): Change return type.
6851         (windows_delete_thread): Update.
6852         (windows_nat_target::attach): Update.
6853         (windows_nat_target::files_info): Update.
6854         * target-delegates.c: Rebuild.
6855         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6856         return type.
6857         (sol_thread_target::pid_to_str): Change return type.
6858         * remote.c (class remote_target) <pid_to_str>: Change return
6859         type.
6860         (remote_target::pid_to_str): Change return type.
6861         (extended_remote_target::attach, remote_target::remote_stop_ns)
6862         (remote_target::remote_notif_remove_queued_reply)
6863         (remote_target::push_stop_reply, remote_target::disable_btrace):
6864         Update.
6865         (extended_remote_target::attach): Update.
6866         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6867         type.
6868         (gdbsim_target::pid_to_str): Change return type.
6869         * ravenscar-thread.c (struct ravenscar_thread_target)
6870         <pid_to_str>: Change return type.
6871         (ravenscar_thread_target::pid_to_str): Change return type.
6872         * procfs.c (class procfs_target) <pid_to_str>: Change return
6873         type.
6874         (procfs_target::pid_to_str): Change return type.
6875         (procfs_target::attach): Update.
6876         (procfs_target::detach): Update.
6877         (procfs_target::fetch_registers): Update.
6878         (procfs_target::store_registers): Update.
6879         (procfs_target::wait): Update.
6880         (procfs_target::files_info): Update.
6881         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6882         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6883         return type.
6884         (nto_procfs_target::pid_to_str): Change return type.
6885         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6886         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6887         return type.
6888         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6889         (exit_lwp): Update.
6890         (attach_proc_task_lwp_callback, get_detach_signal)
6891         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6892         (linux_nat_target::resume, wait_lwp, stop_callback)
6893         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6894         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6895         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6896         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6897         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6898         type.
6899         (inf_ptrace_target::attach): Update.
6900         (inf_ptrace_target::files_info): Update.
6901         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6902         type.
6903         (go32_nat_target::pid_to_str): Change return type.
6904         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6905         (gnu_nat_target::wait): Update.
6906         (gnu_nat_target::wait): Update.
6907         (gnu_nat_target::resume): Update.
6908         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6909         (fbsd_nat_target::wait): Update.
6910         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6911         type.
6912         (darwin_nat_target::attach): Update.
6913         * corelow.c (class core_target) <pid_to_str>: Change return type.
6914         (core_target::pid_to_str): Change return type.
6915         * target.c (normal_pid_to_str): Change return type.
6916         (default_pid_to_str): Likewise.
6917         (target_pid_to_str): Change return type.
6918         (target_translate_tls_address): Update.
6919         (target_announce_detach): Update.
6920         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6921         return type.
6922         (bsd_uthread_target::pid_to_str): Change return type.
6923         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6924         type.
6925         (bsd_kvm_target::pid_to_str): Change return type.
6926         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6927         return type.
6928         (aix_thread_target::pid_to_str): Change return type.
6929         * target.h (struct target_ops) <pid_to_str>: Change return type.
6930         (target_pid_to_str, normal_pid_to_str): Likewise.
6931         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6932         type.
6933         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6934         type.
6935         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6936         return type.
6937         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6938         type.
6939         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6940         type.
6941         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6942         return type.
6943
6944 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6945
6946         * NEWS: Mention that the new default MI version is 3.  Mention
6947         changes to the output of commands and events that deal with
6948         multi-location breakpoints.
6949         * breakpoint.c: Include "mi/mi-out.h".
6950         (print_one_breakpoint): Change output syntax if using MI version
6951         >= 3.
6952         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6953         New.
6954         (mi_multi_location_breakpoint_output_fixed): New.
6955         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6956         (mi_cmd_fix_multi_location_breakpoint_output): New.
6957         (mi_multi_location_breakpoint_output_fixed): New.
6958         * mi/mi-cmds.c (mi_cmds): Register command
6959         -fix-multi-location-breakpoint-output.
6960         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6961         interpreter "mi".
6962
6963 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6964
6965         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6966         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6967         instantiate mi_ui_out based on interpreter name.
6968         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6969         * mi/mi-main.c (mi_load_progress): Likewise.
6970
6971 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6972
6973         * NEWS: Combine separate "New targets" sections for 8.3.
6974
6975 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6976
6977         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6978         (ppcfbsd_init_abi): Install gdbarch
6979         "fetch_tls_load_module_address" and "get_thread_local_address"
6980         methods.
6981
6982 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6983
6984         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6985         (riscv_fbsd_init_abi): Install gdbarch
6986         "fetch_tls_load_module_address" and "get_thread_local_address"
6987         methods.
6988
6989 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6990
6991         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6992         (i386fbsd_init_abi): Install gdbarch
6993         "fetch_tls_load_module_address" and "get_thread_local_address"
6994         methods.
6995
6996 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6997
6998         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6999         (amd64fbsd_init_abi): Install gdbarch
7000         "fetch_tls_load_module_address" and "get_thread_local_address"
7001         methods.
7002
7003 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7004
7005         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7006         (struct fbsd_pspace_data): New type.
7007         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7008         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7009         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7010         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7011         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7012
7013 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7014
7015         * gdbtypes.c (lookup_struct_elt): New function.
7016         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7017         * gdbtypes.h (struct struct_elt): New type.
7018         (lookup_struct_elt): New prototype.
7019
7020 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7021
7022         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7023         remove disabled code block.
7024
7025 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7026
7027         * gdbarch.sh (get_thread_local_address): New method.
7028         * gdbarch.h, gdbarch.c: Regenerate.
7029         * target.c (target_translate_tls_address): Use
7030         gdbarch_get_thread_local_address if present instead of
7031         target::get_thread_local_address.
7032
7033 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7034
7035         * target.h (target::get_thread_local_address): Update comment.
7036
7037 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7038
7039         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7040         objfile->separate_debug_objfile_backlink if not NULL.
7041
7042 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7043
7044         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7045         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7046         (amd64bsd_store_inferior_registers): Likewise.
7047         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7048         Enable segment base registers.
7049         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7050         PT_GETFSBASE and PT_GETGSBASE.
7051         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7052         PT_SETGSBASE.
7053         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7054         segment base registers.
7055         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7056
7057 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7058
7059         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7060         Update calls to i386_target_description to add 'segments'
7061         parameter.
7062         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7063         add segment base registers.
7064         * arch/i386.c (i386_create_target_description): Add 'segments'
7065         parameter to enable segment base registers.
7066         * arch/i386.h (i386_create_target_description): Likewise.
7067         * features/i386/32bit-segments.xml: New file.
7068         * features/i386/32bit-segments.c: Generate.
7069         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7070         call to i386_target_description to add 'segments' parameter.
7071         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7072         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7073         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7074         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7075         if feature is present.
7076         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7077         Add 'segments' parameter to call to i386_target_description.
7078         (i386_target_description): Add 'segments' parameter to enable
7079         segment base registers.
7080         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7081         to call to i386_target_description.
7082         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7083         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7084         Define I386_NUM_REGS.
7085         (i386_target_description): Add 'segments' parameter to enable
7086         segment base registers.
7087
7088 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7089
7090         PR/24325
7091         * source-cache.c: #undef open and close, to avoid unresolved
7092         externals during linking.
7093
7094 2019-03-12  Tom Tromey  <tromey@adacore.com>
7095
7096         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7097         const.  Add initializers.
7098         (_initialize_remote): Don't initialize ptid globals.
7099
7100 2019-03-12  Pedro Alves  <palves@redhat.com>
7101
7102         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7103
7104 2019-03-12  Pedro Alves  <palves@redhat.com>
7105
7106         * cp-name-parser.y (main): Remove unused 'len' variable.
7107
7108 2019-03-12  Tom Tromey  <tromey@adacore.com>
7109
7110         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7111         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7112
7113 2019-03-12  Tom Tromey  <tromey@adacore.com>
7114
7115         * linux-nat.c (iterate_over_lwps): Update.
7116         (stop_callback): Remove parameter.
7117         (stop_wait_callback, detach_callback, resume_set_callback)
7118         (select_singlestep_lwp_callback, set_ignore_sigint)
7119         (status_callback, resumed_callback, resume_clear_callback)
7120         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7121         data parameter.
7122         (linux_nat_target::detach, linux_nat_target::resume)
7123         (linux_stop_and_wait_all_lwps, select_event_lwp)
7124         (linux_nat_filter_event, linux_nat_wait_1)
7125         (linux_nat_target::kill, linux_nat_target::stop)
7126         (linux_nat_target::stop): Update.
7127         (linux_nat_resume_callback): Change type.
7128         (resume_stopped_resumed_lwps, count_events_callback)
7129         (select_event_lwp_callback): Likewise.
7130         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7131         * arm-linux-nat.c (struct update_registers_data): Remove.
7132         (update_registers_callback): Change type.
7133         (arm_linux_insert_hw_breakpoint1): Update.
7134         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7135         parameter.
7136         (x86_linux_dr_set_addr): Update.
7137         (x86_linux_dr_set_control): Update.
7138         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7139         (iterate_over_lwps): Use gdb::function_view.
7140         * nat/aarch64-linux-hw-point.c (struct
7141         aarch64_dr_update_callback_param): Remove.
7142         (debug_reg_change_callback): Change type.
7143         (aarch64_notify_debug_reg_change): Update.
7144         * s390-linux-nat.c (s390_refresh_per_info): Update.
7145
7146 2019-03-11  Tom Tromey  <tromey@adacore.com>
7147
7148         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7149         redundant assignment to "this_cu".
7150
7151 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7152
7153         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7154
7155 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7156
7157         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7158         from...
7159         (rank_one_type): ... this.
7160
7161 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7162
7163         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7164         from...
7165         (rank_one_type): ... this.
7166
7167 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7168
7169         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7170         from...
7171         (rank_one_type): ... this.
7172
7173 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7174
7175         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7176         from...
7177         (rank_one_type): ... this.
7178
7179 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7180
7181         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7182         from...
7183         (rank_one_type): ... this.
7184
7185 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7186
7187         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7188         from...
7189         (rank_one_type): ... this.
7190
7191 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7192
7193         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7194         from...
7195         (rank_one_type): ... this.
7196
7197 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7198
7199         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7200         from...
7201         (rank_one_type): ... this.
7202
7203 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7204
7205         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7206         from...
7207         (rank_one_type): ... this.
7208
7209 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7210
7211         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7212         from...
7213         (rank_one_type): ... this.
7214
7215 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7216
7217         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7218         from...
7219         (rank_one_type): ... this.
7220
7221 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7222
7223         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7224         from...
7225         (rank_one_type): ... this.
7226
7227 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7228
7229         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7230         inferior-events' shows the example events.
7231
7232 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7233
7234         Support styling on native MS-Windows console
7235
7236         PR/24315
7237         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7238         on MS-Windows if $TERM is not defined.
7239
7240         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7241
7242         * posix-hdep.c (gdb_console_fputs):
7243         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7244         functions.
7245         * ui-file.h (gdb_console_fputs): Add prototype.
7246
7247         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7248         back to fputs only if the former returns zero.
7249
7250 2019-03-07  Tom Tromey  <tom@tromey.com>
7251
7252         * symmisc.c (print_symbol_bcache_statistics): Update.
7253         (print_objfile_statistics): Update.
7254         * symfile.c (allocate_symtab): Update.
7255         * stabsread.c: Don't include bcache.h.
7256         * psymtab.h (struct psymbol_bcache): Don't declare.
7257         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7258         (psymbol_bcache_init, psymbol_bcache_free)
7259         (psymbol_bcache_get_bcache): Don't declare.
7260         * psymtab.c (struct psymbol_bcache): Remove.
7261         (psymtab_storage::psymtab_storage): Update.
7262         (psymtab_storage::~psymtab_storage): Update.
7263         (psymbol_bcache_init, psymbol_bcache_free)
7264         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7265         (add_psymbol_to_bcache): Update.
7266         (allocate_psymtab): Update.
7267         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7268         macro_cache>: No longer pointers.
7269         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7270         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7271         * macrotab.c (macro_bcache): Update.
7272         * macroexp.c: Don't include bcache.h.
7273         * gdbtypes.c (check_types_worklist): Update.
7274         (types_deeply_equal): Remove TRY/CATCH.  Update.
7275         * elfread.c (elf_symtab_read): Update.
7276         * dwarf2read.c: Don't include bcache.h.
7277         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7278         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7279         (print_bcache_statistics, bcache_memory_used): Don't declare.
7280         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7281         methods.  Rename all data members.
7282         * bcache.c (struct bcache): Move to bcache.h.
7283         (bcache::expand_hash_table): Rename from expand_hash_table.
7284         (bcache): Remove.
7285         (bcache::insert): Rename from bcache_full.
7286         (bcache::compare): Rename from bcache_compare.
7287         (bcache_xmalloc): Remove.
7288         (bcache::~bcache): Rename from bcache_xfree.
7289         (bcache::print_statistics): Rename from print_bcache_statistics.
7290         (bcache::memory_used): Rename from bcache_memory_used.
7291
7292 2019-03-07  Pedro Alves  <palves@redhat.com>
7293
7294         * infrun.c (normal_stop): Also check for
7295         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7296
7297 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7298
7299         * f-lang.c (value_from_host_double): Moved to...
7300         * value.c (value_from_host_double): ...here.
7301         * value.h (value_from_host_double): Declare.
7302         * guile/scm-math.c (vlscm_convert_typed_number): Use
7303         value_from_host_double.
7304         (vlscm_convert_number): Likewise.
7305         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7306         * python/py-value.c (convert_value_from_python): Likewise.
7307
7308 2019-03-06  Tom Tromey  <tom@tromey.com>
7309
7310         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7311
7312 2019-03-06  Tom Tromey  <tom@tromey.com>
7313
7314         * utils.h (free_current_contents): Don't declare.
7315         * utils.c (free_current_contents): Remove.
7316
7317 2019-03-06  Tom Tromey  <tom@tromey.com>
7318
7319         * top.c (quit_force): Update.
7320         * main.c (captured_command_loop): Update.
7321         * common/new-op.c (operator new): Update.
7322         * common/common-exceptions.c (struct catcher)
7323         <save_cleanup_chain>: Remove member.
7324         (exceptions_state_mc_init): Update.
7325         (exception_try_scope_entry): Return nullptr.
7326         (exception_try_scope_exit, exception_rethrow)
7327         (throw_exception_sjlj, throw_exception_cxx): Update.
7328         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7329         (all_cleanups, do_cleanups, discard_cleanups)
7330         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7331         (restore_cleanups, restore_final_cleanups): Don't declare.
7332         (do_final_cleanups): Remove parameter.
7333         * common/cleanups.c (cleanup_chain, make_cleanup)
7334         (make_cleanup_dtor, all_cleanups, do_cleanups)
7335         (discard_my_cleanups, discard_cleanups)
7336         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7337         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7338         (null_cleanup): Remove.
7339         (do_final_cleanups): Remove parameter.
7340
7341 2019-03-06  Tom Tromey  <tom@tromey.com>
7342
7343         * remote.c (remote_target::remote_parse_stop_reply): Use
7344         unique_xmalloc_ptr.
7345
7346 2019-03-06  Tom Tromey  <tom@tromey.com>
7347
7348         * stabsread.c (struct stabs_field_info): Rename from field_info.
7349         <list, fnlist>: Add initializers.
7350         <obstack>: New member.
7351         (read_member_functions, read_struct_fields, read_baseclasses):
7352         Allocate on obstack.  Don't use cleanups.
7353         (read_one_struct_field, read_member_functions, read_struct_fields)
7354         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7355         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7356         (read_struct_type): Update.
7357
7358 2019-03-06  Tom Tromey  <tom@tromey.com>
7359
7360         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7361         * common/filestuff.h (make_cleanup_close): Don't declare.
7362         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7363         Remove.
7364
7365 2019-03-06  Tom Tromey  <tom@tromey.com>
7366
7367         * solib-aix.c: Use make_scope_exit.
7368
7369 2019-03-06  Tom Tromey  <tom@tromey.com>
7370
7371         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7372         Use make_scope_exit.
7373
7374 2019-03-06  Tom Tromey  <tom@tromey.com>
7375
7376         * solib-svr4.c (disable_probes_interface): Remove parameter.
7377         (svr4_handle_solib_event): Use make_scope_exit.
7378
7379 2019-03-06  Tom Tromey  <tom@tromey.com>
7380
7381         * remote.c (struct stop_reply_deleter): Remove.
7382         (stop_reply_up): Update.
7383         (struct stop_reply): Derive from notif_event.  Don't typedef.
7384         <regcache>: Now a std::vector.
7385         (stop_reply_xfree): Remove.
7386         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7387         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7388         (remote_target::discard_pending_stop_replies): Use delete.
7389         (remote_target::remote_parse_stop_reply): Update.
7390         (remote_target::process_stop_reply): Update.
7391         * remote-notif.h (struct notif_event): Add virtual destructor.
7392         Remove "dtr" member.
7393         (struct notif_client) <alloc_event>: Return a unique_ptr.
7394         (notif_event_xfree): Don't declare.
7395         (notif_event_up): New typedef.
7396         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7397         (notif_event_xfree, do_notif_event_xfree): Remove.
7398         (remote_notif_state_xfree): Update.
7399
7400 2019-03-06  Tom Tromey  <tom@tromey.com>
7401
7402         * infrun.c (displaced_step_clear_cleanup): Now a
7403         forward_scope_exit type.
7404         (displaced_step_prepare_throw): Update.
7405         (displaced_step_fixup): Update.
7406
7407 2019-03-06  Tom Tromey  <tom@tromey.com>
7408
7409         * inferior.h (class inferior): Update comment.
7410         * gdbthread.h (class thread_info): Update comment.
7411
7412 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7413             Tom Tromey  <tom@tromey.com>
7414
7415         * stabsread.h (struct stab_section_list): Remove.
7416         (coffstab_build_psymtabs): Update.
7417         * dbxread.c (symbuf_sections): Now a std::vector.
7418         (sect_idx): New global.
7419         (fill_symbuf): Update.
7420         (coffstab_build_psymtabs): Change type of stabsects parameter.
7421         Update.
7422         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7423         std::vector.
7424         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7425         (coff_locate_sections): Update.
7426         (coff_symfile_read): Remove cleanups.  Update.
7427         (init_stringtab): Add storage parameter.
7428         (free_stringtab, free_stringtab_cleanup): Remove.
7429         (init_lineno): Add storage parameter.
7430         (free_linetab, free_linetab_cleanup): Remove.
7431
7432 2019-03-06  Pedro Alves  <palves@redhat.com>
7433
7434         * linux-fork.c (fork_info::clobber_regs): Delete.
7435         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7436         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7437         comment.  Adjust.
7438         (scoped_switch_fork_info::scoped_switch_fork_info)
7439         (checkpoint_command, linux_fork_context): Adjust
7440         fork_save_infrun_state calls.
7441
7442 2019-03-06  Pedro Alves  <palves@redhat.com>
7443
7444         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7445         (inf_has_multiple_threads): Return 'bool' and rewrite using
7446         inferior_info::threads().
7447
7448 2019-03-06  Pedro Alves  <palves@redhat.com>
7449
7450         * linux-fork.c: Include <list>.
7451         (fork_list): Now a std::list instance.
7452         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7453         (forks_exist_p, find_last_fork): Adjust.
7454         (new_fork): Delete.
7455         (one_fork_p): New.
7456         (add_fork): Adjust.
7457         (free_fork): Delete, folded into fork_info::~fork_info().
7458         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7459         Adjust.
7460         (init_fork_list): Delete.
7461         (linux_fork_killall, linux_fork_mourn_inferior)
7462         (linux_fork_detach, info_checkpoints_command): Adjust.
7463         (_initialize_linux_fork): No longer call init_fork_list.
7464
7465 2019-03-06  Pedro Alves  <palves@redhat.com>
7466
7467         * linux-fork.c (new_fork): New, split out of ...
7468         (add_fork): ... this.  Return void.  Move "first fork" special
7469         case from here, to ...
7470         (checkpoint_command): ... here.
7471         * linux-linux.h (add_fork): Return void.
7472
7473 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7474
7475         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7476
7477 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7478             Chris January  <chris.january@arm.com>
7479             David Lecomber  <david.lecomber@arm.com>
7480
7481         * f-exp.y: New token, UNOP_INTRINSIC.
7482         (exp): New pattern using UNOP_INTRINSIC token.
7483         (f77_keywords): Add 'abs' keyword.
7484         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7485         (value_from_host_double): New function.
7486         (evaluate_subexp_f): Support UNOP_ABS.
7487
7488 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7489
7490         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7491         types.
7492
7493 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7494
7495         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7496         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7497         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7498
7499 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7500
7501         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7502
7503 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7504             Chris January  <chris.january@arm.com>
7505
7506         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7507         * f-exp.y: Define 'KIND' token.
7508         (exp): New pattern for KIND expressions.
7509         (ptype): Handle types with a kind extension.
7510         (direct_abs_decl): Extend to spot kind extensions.
7511         (f77_keywords): Add 'kind' to the list.
7512         (push_kind_type): New function.
7513         (convert_to_kind_type): New function.
7514         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7515         * parse.c (operator_length_standard): Likewise.
7516         * parser-defs.h (enum type_pieces): Add tp_kind.
7517         * std-operator.def: Add UNOP_KIND.
7518
7519 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7520
7521         * f-exp.y (f_parse): Set yydebug.
7522
7523 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7524
7525         * f-lang.c (evaluate_subexp_f): New function.
7526         (exp_descriptor_f): New global.
7527         (f_language_defn): Use exp_descriptor_f instead of
7528         exp_descriptor_standard.
7529
7530 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7531
7532         * f-exp.y (struct token): Add comments.
7533         (dot_ops): Remove uppercase versions and the end marker.
7534         (f77_keywords): Likewise.
7535         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7536         entries in the dot_ops array are case insensitive, and use
7537         strncasecmp to compare strings.  Also some whitespace cleanup in
7538         this area.  Similar for the f77_keywords array, except entries in
7539         this list might be case sensitive.
7540
7541 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7542
7543         * f-exp.y (struct f77_boolean_val): Add comments.
7544         (boolean_values): Remove uppercase versions, and end marker.
7545         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7546         and use strncasecmp to achieve case insensitivity.  Additionally,
7547         perform whitespace cleanup around this code.
7548
7549 2019-03-06  Tom Tromey  <tromey@adacore.com>
7550
7551         * remote-sim.c (gdbsim_target_open): Use result of
7552         gdb_argv::release.
7553
7554 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7555         Dirk Schubert  <dirk.schubert@arm.com>
7556         Chris January  <chris.january@arm.com>
7557
7558         * eval.c (evaluate_subexp_standard): Call Fortran argument
7559         wrapping logic.
7560         * f-lang.c (struct value): A value which can be passed into a
7561         Fortran function call.
7562         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7563         where appropriate.
7564         (struct type): Value ready for a Fortran function call.
7565         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7566         is needed.
7567         * f-lang.h (fortran_argument_convert): Declaration.
7568         (fortran_preserve_arg_pointer): Declaration.
7569         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7570
7571 2019-03-05  Tom Tromey  <tromey@adacore.com>
7572
7573         * python/py-prettyprint.c (print_string_repr): Remove #if.
7574         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7575
7576 2019-03-05  Tom Tromey  <tromey@adacore.com>
7577
7578         * target.c (the_dummy_target): Move later.  Change type to
7579         "dummy_target".
7580         (initialize_targets): Don't initialize the_dummy_target.
7581
7582 2019-03-05  Tom Tromey  <tromey@adacore.com>
7583
7584         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7585         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7586
7587 2019-03-05  Tom Tromey  <tromey@adacore.com>
7588
7589         * windows-nat.c (windows_nat_target::attach)
7590         (windows_nat_target::detach): Don't call gdb_flush.
7591         * valprint.c (generic_val_print, val_print, val_print_string):
7592         Don't call gdb_flush.
7593         * utils.c (defaulted_query): Don't call gdb_flush.
7594         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7595         * target.c (target_announce_detach): Don't call gdb_flush.
7596         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7597         * remote.c (extended_remote_target::attach): Don't call
7598         gdb_flush.
7599         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7600         * printcmd.c (do_examine): Don't call gdb_flush.
7601         (info_display_command): Don't call gdb_flush.
7602         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7603         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7604         * memattr.c (info_mem_command): Don't call gdb_flush.
7605         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7606         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7607         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7608         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7609         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7610         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7611         (gnu_nat_target::detach): Don't call gdb_flush.
7612         * f-valprint.c (f_val_print): Don't call gdb_flush.
7613         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7614         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7615         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7616         gdb_flush.
7617         * c-valprint.c (c_val_print): Don't call gdb_flush.
7618         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7619
7620 2019-03-05  Tom Tromey  <tromey@adacore.com>
7621
7622         * varobj.c (update_dynamic_varobj_children): Update.
7623         (install_default_visualizer): Use reset, not release.
7624         * value.c (set_internalvar): Update.
7625         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7626         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7627         ATTRIBUTE_UNUSED_RESULT.
7628
7629 2019-03-05  Tom Tromey  <tromey@adacore.com>
7630
7631         * remote.c (class scoped_remote_fd) <release>: Add
7632         ATTRIBUTE_UNUSED_RESULT.
7633
7634 2019-03-05  Tom Tromey  <tromey@adacore.com>
7635
7636         * macroexp.c (struct macro_buffer) <release>: Add
7637         ATTRIBUTE_UNUSED_RESULT.
7638
7639 2019-03-05  Tom Tromey  <tromey@adacore.com>
7640
7641         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7642         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7643         ATTRIBUTE_UNUSED_RESULT.
7644
7645 2019-03-05  Tom Tromey  <tromey@adacore.com>
7646
7647         * common/scoped_fd.h (class scoped_fd) <release>: Add
7648         ATTRIBUTE_UNUSED_RESULT.
7649
7650 2019-03-05  Tom Tromey  <tromey@adacore.com>
7651
7652         * parser-defs.h (struct parser_state) <release>: Add
7653         ATTRIBUTE_UNUSED_RESULT.
7654
7655 2019-03-05  Tom Tromey  <tromey@adacore.com>
7656
7657         * utils.h (class gdb_argv) <release>: Add
7658         ATTRIBUTE_UNUSED_RESULT.
7659         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7660
7661 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7662
7663         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7664         for-loop range, to avoid compiler warnings.
7665
7666         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7667         avoid compiler warnings about unused variables.
7668
7669         * NEWS: Mention end of support for native debugging on MS-Windows
7670         before XP.
7671
7672         PR gdb/24292
7673         * common/netstuff.c:
7674         * gdbserver/gdbreplay.c
7675         * gdbserver/remote-utils.c:
7676         * ser-tcp.c:
7677         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7678         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7679         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7680         'getaddrinfo' and 'freeaddrinfo' were not available before
7681         Windows XP, and mingw.org's MinGW headers by default define
7682         _WIN32_WINNT to 0x500.
7683
7684 2019-03-01  Gary Benson <gbenson@redhat.com>
7685
7686         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7687
7688 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7689             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7690
7691         PR gdb/8527
7692         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7693         set_sigint_trap, clear_sigint_trap.
7694
7695 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7696
7697         * target.c (target_detach): Clear the regcache and the
7698         frame cache.
7699
7700 2019-02-27  Pedro Alves  <palves@redhat.com>
7701
7702         * utils.c (set_screen_size): When we cap the height/width sizes,
7703         tweak the corresponding command variable to show "unlimited":
7704
7705 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7706             Pedro Alves  <palves@redhat.com>
7707
7708         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7709         before calling rl_set_screen_size.
7710
7711 2019-02-27  Tom Tromey  <tromey@adacore.com>
7712
7713         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7714         define.
7715         * python/py-value.c: Remove Python 2.4 workaround.
7716         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7717         workaround.
7718         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7719         Python 2.4 workaround.
7720         * python/python-internal.h: Remove Python 2.4 comment.
7721         (Py_ssize_t): Don't define.
7722         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7723         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7724         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7725         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7726         * python/python.c (do_start_initialization): Remove Python 2.4
7727         workaround.
7728         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7729         (print_children): Remove Python 2.4 workaround.
7730         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7731         workaround.
7732         (CHARBUFFERPROC_NAME): Remove.
7733         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7734         Python 2.4 workaround.
7735
7736 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7737
7738         * NEWS: Note minimum Python version.
7739
7740 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7741
7742         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7743         code from these functions.  Remove corresponding ifdefs.  Use
7744         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7745         Remove gotos and target of gotos.
7746         (infpy_search_memory): Likewise.
7747
7748 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7749
7750         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7751         (hppa_gdbarch_init): Don't register deleted functions with
7752         gdbarch.
7753
7754 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7755
7756         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7757         (h8300_unwind_sp): Delete.
7758         (h8300_dummy_id): Delete.
7759         (h8300_gdbarch_init): Don't register deleted functions with
7760         gdbarch.
7761
7762 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7763
7764         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7765         (ft32_unwind_pc): Delete.
7766         (ft32_unwind_sp): Delete.
7767         (ft32_gdbarch_init): Don't register deleted functions with
7768         gdbarch.
7769
7770 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7771
7772         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7773         (frv_unwind_pc): Delete.
7774         (frv_unwind_sp): Delete.
7775         (frv_gdbarch_init): Don't register deleted functions with
7776         gdbarch.
7777
7778 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7779
7780         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7781         (riscv_unwind_pc): Delete.
7782         (riscv_unwind_sp): Delete.
7783         (riscv_gdbarch_init): Don't register deleted functions with
7784         gdbarch.
7785
7786 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7787
7788         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7789         (csky_unwind_pc): Delete.
7790         (csky_unwind_sp): Delete.
7791         (csky_gdbarch_init): Don't register deleted functions with
7792         gdbarch.
7793
7794 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7795
7796         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7797         (cris_unwind_pc): Delete.
7798         (cris_unwind_sp): Delete.
7799         (cris_gdbarch_init): Don't register deleted functions with
7800         gdbarch.
7801
7802 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7803
7804         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7805         (bfin_unwind_pc): Delete.
7806         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7807
7808 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7809
7810         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7811         (arm_unwind_pc): Delete.
7812         (arm_unwind_sp): Delete.
7813         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7814
7815 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7816
7817         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7818         (arc_unwind_pc): Delete.
7819         (arc_unwind_sp): Delete.
7820         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7821
7822 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7823
7824         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7825         (alpha_unwind_pc): Delete.
7826         (alpha_gdbarch_init): Don't register deleted functions with
7827         gdbarch.
7828
7829 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7830
7831         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7832         (aarch64_unwind_pc): Delete.
7833         (aarch64_unwind_sp): Delete.
7834         (aarch64_gdbarch_init): Don't register deleted functions with
7835         gdbarch.
7836
7837 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7838
7839         * gdbtypes.c (type_align): Don't consider static members when
7840         computing structure alignment.
7841
7842 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7843
7844         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7845         return 0 for other types.
7846         * arch-utils.c (default_type_align): Always return 0.
7847         * gdbarch.h: Regenerate.
7848         * gdbarch.sh (type_align): Extend comment.
7849         * gdbtypes.c (type_align): Add additional comments, always call
7850         gdbarch_type_align before applying the default rules.
7851         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7852         generic code will then apply a suitable default.
7853         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7854         types, return 0 for other types.
7855
7856 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7857
7858         * NEWS: Create a new section for the next release branch.
7859         Rename the section of the current branch, now that it has
7860         been cut.
7861
7862 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7863
7864         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7865         * version.in: Bump version to 8.3.50.DATE-git.
7866
7867 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7868
7869         * aix-thread.c (ptid_cmp): Remove unused variable.
7870         (get_signaled_thread): Likewise.
7871         (store_regs_user_thread): Likewise.
7872         (store_regs_kernel_thread): Likewise.
7873         (fetch_regs_kernel_thread): Remove shadowed variable.
7874
7875 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7876
7877         * features/riscv/32bit-cpu.xml: Add register numbers.
7878         * features/riscv/32bit-fpu.c: Regenerate.
7879         * features/riscv/32bit-fpu.xml: Add register numbers.
7880         * features/riscv/64bit-cpu.xml: Add register numbers.
7881         * features/riscv/64bit-fpu.c: Regenerate.
7882         * features/riscv/64bit-fpu.xml: Add register numbers.
7883
7884 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7885
7886         * NEWS: Mention two argument form of gdb.Value constructor.
7887         * python/py-value.c (convert_buffer_and_type_to_value): New
7888         function.
7889         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7890         Add support for handling an optional second argument.  Call
7891         convert_buffer_and_type_to_value as appropriate.
7892         * python/python-internal.h (Py_buffer_deleter): New struct.
7893         (Py_buffer_up): New typedef.
7894
7895 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7896
7897         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7898         instead of releasing ownership.
7899
7900 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7901
7902         * dwarf2read.c (open_and_init_dwp_file): Call
7903         elf_numsections instead of bfd_count_sections to initialize
7904         dwp_file->num_sections.
7905
7906 2019-02-25  Tom Tromey  <tromey@adacore.com>
7907
7908         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7909
7910 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7911
7912         * gcore.in: Add '--readnever' option when invoking GDB.
7913
7914 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7915
7916         * MAINTAINERS: Update my email address.
7917
7918 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7919
7920         * build-id.c (build_id_to_debug_bfd_1): New function.
7921         (build_id_to_debug_bfd): Look for separate debug file in
7922         sysroot.
7923
7924 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7925
7926         * gdbarch.sh: Update the copyright year range that is placed into
7927         generated files.
7928
7929 2019-02-22  Keith Seitz  <keiths@redhat.com>
7930
7931         PR symtab/23853
7932         * linespec.c (create_sals_line_offset): Search for the default
7933         symtab's filename instead of its fullname.
7934
7935 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7936
7937         * NEWS: Update style defaults.
7938
7939 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7940
7941         * main.c (captured_main_1): Disable styling in batch mode.
7942
7943 2019-02-20  Tom Tromey  <tom@tromey.com>
7944
7945         * symtab.c (symtab_symbol_info): Fix typos.
7946
7947 2019-02-20  Tom Tromey  <tromey@adacore.com>
7948
7949         * findcmd.c (_initialize_mem_search): Use upper case for
7950         metasyntactic variables.
7951
7952 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7953
7954         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7955         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7956
7957 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7958
7959         * top.h (source_file_name): Change to std::string.
7960         * top.c (source_file_name): Likewise.
7961         (command_line_input): Adjust.
7962         * cli/cli-script.c (script_from_file): Adjust.
7963
7964 2019-02-19  Tom Tromey  <tromey@adacore.com>
7965
7966         * ravenscar-thread.c
7967         (ravenscar_thread_target::update_thread_list): Don't call
7968         ada_build_task_list.
7969         * ada-lang.h (ada_build_task_list): Don't declare.
7970         * ada-tasks.c (struct ada_tasks_inferior_data)
7971         <task_list_valid_p>: Now bool.
7972         (read_known_tasks, ada_task_list_changed)
7973         (ada_tasks_invalidate_inferior_data): Update.
7974         (read_known_tasks_array): Return bool.
7975         (read_known_tasks_list): Likewise.
7976         (read_known_tasks): Return void.
7977         (ada_build_task_list): Now static.
7978
7979 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7980
7981         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7982         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7983
7984 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7985
7986         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7987         variant for ada_tasks_pspace_data_handle and
7988         ada_tasks_inferior_data_handle.
7989         (ada_tasks_pspace_data_cleanup): New function.
7990         (ada_tasks_inferior_data_cleanup): New function.
7991
7992 2019-02-17  Tom Tromey  <tom@tromey.com>
7993
7994         * macrotab.h (macro_source_fullname): Return a std::string.
7995         * macrotab.c (macro_include, check_for_redefinition)
7996         (macro_undef, macro_lookup_definition, foreach_macro)
7997         (foreach_macro_in_scope): Update.
7998         (macro_source_fullname): Return a std::string.
7999         * macrocmd.c (show_pp_source_pos): Update.
8000
8001 2019-02-17  Tom Tromey  <tom@tromey.com>
8002
8003         * macrocmd.c (show_pp_source_pos): Style the file names.
8004
8005 2019-02-17  Tom Tromey  <tom@tromey.com>
8006
8007         PR tui/24197:
8008         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8009
8010 2019-02-17  Tom Tromey  <tom@tromey.com>
8011
8012         * ada-lang.c (user_select_syms): Use filtered printing.
8013         * utils.c (wrap_style): New global.
8014         (desired_style): Remove.
8015         (emit_style_escape): Add stream parameter.
8016         (set_output_style, reset_terminal_style, prompt_for_continue):
8017         Update.
8018         (flush_wrap_buffer): Only flush gdb_stdout.
8019         (wrap_here): Set wrap_style.
8020         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8021         treat escape sequences as a character.  Change when wrap buffer is
8022         flushed.
8023         (fputs_styled): Do not set the output style when the default is
8024         requested.
8025         * ui-style.h (struct ui_file_style) <is_default>: New method.
8026         * source.c (print_source_lines_base): Emit escape sequences in one
8027         piece.
8028
8029 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8030
8031         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8032         integers and enumeration types.
8033
8034 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8035
8036         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8037         instead of lookup_symbol_in_language
8038         (do_exact_match): New function.
8039         (ada_get_symbol_name_matcher): Return do_exact_match when
8040         doing a verbatim match.
8041
8042 2019-02-15  Tom Tromey  <tromey@adacore.com>
8043
8044         * ravenscar-thread.c (ravenscar_thread_target::resume)
8045         (ravenscar_thread_target::wait): Special case wildcard requests.
8046
8047 2019-02-15  Tom Tromey  <tromey@adacore.com>
8048
8049         * ravenscar-thread.c (base_ptid): Remove.
8050         (struct ravenscar_thread_target) <close>: New method.
8051         <m_base_ptid>: New member.
8052         <update_inferior_ptid, active_task, task_is_currently_active,
8053         runtime_initialized>: Declare methods.
8054         <ravenscar_thread_target>: Add constructor.
8055         (ravenscar_thread_target::task_is_currently_active)
8056         (ravenscar_thread_target::update_inferior_ptid)
8057         (ravenscar_runtime_initialized): Rename.  Now methods.
8058         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8059         (ravenscar_thread_target::update_thread_list): Update.
8060         (ravenscar_thread_target::active_task): Now method.
8061         (ravenscar_thread_target::store_registers)
8062         (ravenscar_thread_target::prepare_to_store)
8063         (ravenscar_thread_target::prepare_to_store)
8064         (ravenscar_thread_target::mourn_inferior): Update.
8065         (ravenscar_inferior_created): Use "new" to create target.
8066         (ravenscar_thread_target::get_ada_task_ptid): Update.
8067         (_initialize_ravenscar): Don't initialize base_ptid.
8068         (ravenscar_ops): Remove global.
8069
8070 2019-02-15  Tom Tromey  <tromey@adacore.com>
8071
8072         * target.h (push_target): Declare new overload.
8073         * target.c (push_target): New overload, taking an rvalue reference.
8074         * remote.c (remote_target::open_1): Use push_target overload.
8075         * corelow.c (core_target_open): Use push_target overload.
8076
8077 2019-02-15  Tom Tromey  <tromey@adacore.com>
8078
8079         * ravenscar-thread.c (is_ravenscar_task)
8080         (ravenscar_task_is_currently_active): Return bool.
8081         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8082         (_initialize_ravenscar): Remove "(void)".
8083         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8084         Return bool.
8085
8086 2019-02-15  Tom Tromey  <tromey@adacore.com>
8087
8088         * ravenscar-thread.c (ravenscar_runtime_initializer)
8089         (has_ravenscar_runtime, get_running_thread_id)
8090         (ravenscar_thread_target::resume): Fix indentation.
8091
8092 2019-02-15  Tom Tromey  <tromey@adacore.com>
8093
8094         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8095         from ravenscar_arch_ops.
8096         (sparc_ravenscar_ops::fetch_registers)
8097         (sparc_ravenscar_ops::store_registers): Now methods.
8098         (sparc_ravenscar_prepare_to_store): Remove.
8099         (sparc_ravenscar_ops): Redefine.
8100         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8101         methods and destructor.  Remove members.
8102         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8103         (ravenscar_thread_target::store_registers)
8104         (ravenscar_thread_target::prepare_to_store): Update.
8105         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8106         Remove.
8107         (struct ppc_ravenscar_powerpc_ops): Derive from
8108         ravenscar_arch_ops.
8109         (ppc_ravenscar_powerpc_ops::fetch_registers)
8110         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8111         (ppc_ravenscar_powerpc_ops): Redefine.
8112         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8113         (ppc_ravenscar_e500_ops::fetch_registers)
8114         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8115         (ppc_ravenscar_e500_ops): Redefine.
8116         * aarch64-ravenscar-thread.c
8117         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8118         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8119         (aarch64_ravenscar_fetch_registers)
8120         (aarch64_ravenscar_store_registers): Now methods.
8121         (aarch64_ravenscar_ops): Redefine.
8122
8123 2019-02-15  Tom Tromey  <tromey@adacore.com>
8124
8125         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8126         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8127         (ravenscar_thread_target::stopped_by_watchpoint)
8128         (ravenscar_thread_target::stopped_data_address)
8129         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8130
8131 2019-02-15  Tom Tromey  <tromey@adacore.com>
8132
8133         * ravenscar-thread.c: Fix some typos.
8134
8135 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8136             Tom Tromey  <tromey@adacore.com>
8137
8138         * ada-lang.c (ada_exception_sal): Change addr_string to a
8139         std::string.
8140         (create_ada_exception_catchpoint): Update.
8141
8142 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8143             Tom Tromey  <tromey@adacore.com>
8144
8145         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8146         (bp_location_ops): Remove.
8147         (base_breakpoint_allocate_location): Update.
8148         (free_bp_location): Update.
8149         * ada-lang.c (class ada_catchpoint_location)
8150         <ada_catchpoint_location>: Remove ops parameter.
8151         (ada_catchpoint_location_dtor): Remove.
8152         (ada_catchpoint_location_ops): Remove.
8153         (allocate_location_exception): Update.
8154         * breakpoint.h (struct bp_location_ops): Remove.
8155         (class bp_location) <bp_location>: Remove bp_location_ops
8156         parameter.
8157         <~bp_location>: Add destructor.
8158         <ops>: Remove.
8159
8160 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8161             Pedro Alves  <palves@redhat.com>
8162
8163         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8164         'PATH_MAX'.
8165
8166 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8167             Samuel Thibault  <samuel.thibault@gnu.org>
8168             Thomas Schwinge  <thomas@codesourcery.com>
8169
8170         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8171         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8172
8173 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8174
8175         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8176         (check_empty): Use "const char *".
8177
8178         * gnu-nat.c (gnu_nat_target::detach): Instead of
8179         'detach_inferior (pid)' call
8180         'detach_inferior (find_inferior_pid (pid))'.
8181
8182         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8183         'nat/fork-inferior.o'.
8184         * gnu-nat.c: #include "nat/fork-inferior.h".
8185
8186         * gnu-nat.c (gnu_nat_target::detach): Instead of
8187         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8188         * gnu-nat.h: #include "inf-child.h".
8189         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8190         'i386_gnu_nat_target::fetch_registers'.
8191         (gnu_store_registers): Rename/move to
8192         'i386_gnu_nat_target::store_registers'.
8193
8194         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8195         * gnu-nat.h (mach_thread_info): New function.
8196         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8197
8198         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8199
8200 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8201
8202         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8203
8204 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8205
8206         * windows-nat.c (windows_add_thread): Add new parameter
8207         "main_thread_p" with default value set to false.  Update
8208         function documentation as well as all callers.
8209         (windows_delete_thread): Likewise.
8210         (fake_create_process): Update call to windows_add_thread.
8211         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8212         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8213         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8214         call to windows_delete_thread.
8215
8216 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8217
8218         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8219
8220 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8221
8222         * symfile.c (find_separate_debug_file): Use canonical path of
8223         sysroot with child_path instead of gdb_sysroot if it is valid.
8224
8225 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8226
8227         * symfile.c (find_separate_debug_file): Use child_path to
8228         determine if an object file is under a sysroot.
8229
8230 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8231
8232         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8233         unittests/child-path-selftests.c.
8234         * common/pathstuff.c (child_path): New function.
8235         * common/pathstuff.h (child_path): New prototype.
8236         * unittests/child-path-selftests.c: New file.
8237
8238 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8239
8240         * symfile.c (find_separate_debug_file): Look for separate debug
8241         files in debug directories under the sysroot.
8242
8243 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8244
8245         * symtab.h (struct minimal_symbol data_p): New const method.
8246         (struct minimal_symbol text_p): Likewise.
8247         * symtab.c (output_source_filename): Use file name style
8248         to print file name.
8249         (print_symbol_info): Likewise.
8250         (print_msymbol_info): Use address style to print addresses.
8251         Use function name style to print executable text symbols.
8252         (expand_symtab_containing_pc): Use data_p.
8253         (find_pc_sect_compunit_symtab): Likewise.
8254
8255 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8256
8257         * breakpoint.c (describe_other_breakpoints): Use address style
8258         to print addresses.
8259         (say_where): Likewise.
8260
8261 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8262
8263         * ada-typeprint.c (print_func_type): Print function name
8264         style to print function name.
8265         * c-typeprint.c (c_print_type_1): Likewise.
8266
8267 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8268
8269         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8270         for execve.
8271
8272 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8273
8274         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8275         type_stack.
8276
8277 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8278
8279         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8280         TYPE_CODE_REF types.
8281
8282 2019-02-08  Jim Wilson  <jimw@sifive.com>
8283
8284         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8285         (riscv_linux_fregset): New.
8286         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8287
8288 2019-02-07  Tom Tromey  <tom@tromey.com>
8289
8290         * thread.c (thread_cancel_execution_command): Update.
8291         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8292         methods.
8293         (struct thread_fsm_ops): Remove.
8294         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8295         (thread_fsm_should_stop, thread_fsm_return_value)
8296         (thread_fsm_set_finished, thread_fsm_finished_p)
8297         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8298         Don't declare.
8299         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8300         * infrun.c (clear_proceed_status_thread)
8301         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8302         (print_stop_event): Update.
8303         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8304         Add constructor.
8305         (step_command_fsm_ops): Remove.
8306         (new_step_command_fsm): Remove.
8307         (step_1): Update.
8308         (step_command_fsm::should_stop): Rename from
8309         step_command_fsm_should_stop.
8310         (step_command_fsm::clean_up): Rename from
8311         step_command_fsm_clean_up.
8312         (step_command_fsm::do_async_reply_reason): Rename from
8313         step_command_fsm_async_reply_reason.
8314         (struct until_next_fsm): Inherit from thread_fsm.  Add
8315         constructor.
8316         (until_next_fsm_ops): Remove.
8317         (new_until_next_fsm): Remove.
8318         (until_next_fsm::should_stop): Rename from
8319         until_next_fsm_should_stop.
8320         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8321         (until_next_fsm::do_async_reply_reason): Rename from
8322         until_next_fsm_async_reply_reason.
8323         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8324         constructor.  Change type of breakpoint.
8325         (finish_command_fsm_ops): Remove.
8326         (new_finish_command_fsm): Remove.
8327         (finish_command_fsm::should_stop): Rename from
8328         finish_command_fsm_should_stop.
8329         (finish_command_fsm::clean_up): Rename from
8330         finish_command_fsm_clean_up.
8331         (finish_command_fsm::return_value): Rename from
8332         finish_command_fsm_return_value.
8333         (finish_command_fsm::do_async_reply_reason): Rename from
8334         finish_command_fsm_async_reply_reason.
8335         (finish_command): Update.
8336         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8337         Add constructor.
8338         (call_thread_fsm_ops): Remove.
8339         (call_thread_fsm::call_thread_fsm): Rename from
8340         new_call_thread_fsm.
8341         (call_thread_fsm::should_stop): Rename from
8342         call_thread_fsm_should_stop.
8343         (call_thread_fsm::should_notify_stop): Rename from
8344         call_thread_fsm_should_notify_stop.
8345         (run_inferior_call, call_function_by_hand_dummy): Update.
8346         * cli/cli-interp.c (should_print_stop_to_console): Update.
8347         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8348         Add constructor.  Change type of location_breakpoint,
8349         caller_breakpoint.
8350         (until_break_fsm_ops): Remove.
8351         (new_until_break_fsm): Remove.
8352         (until_break_fsm::should_stop): Rename from
8353         until_break_fsm_should_stop.
8354         (until_break_fsm::clean_up): Rename from
8355         until_break_fsm_clean_up.
8356         (until_break_fsm::do_async_reply_reason): Rename from
8357         until_break_fsm_async_reply_reason.
8358         (until_break_command): Update.
8359         * thread-fsm.c: Remove.
8360         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8361
8362 2019-02-07  Tom Tromey  <tom@tromey.com>
8363
8364         * yy-remap.h: Add include guard.
8365         * xtensa-tdep.h: Add include guard.
8366         * xcoffread.h: Rename include guard.
8367         * varobj-iter.h: Add include guard.
8368         * tui/tui.h: Rename include guard.
8369         * tui/tui-winsource.h: Rename include guard.
8370         * tui/tui-wingeneral.h: Rename include guard.
8371         * tui/tui-windata.h: Rename include guard.
8372         * tui/tui-win.h: Rename include guard.
8373         * tui/tui-stack.h: Rename include guard.
8374         * tui/tui-source.h: Rename include guard.
8375         * tui/tui-regs.h: Rename include guard.
8376         * tui/tui-out.h: Rename include guard.
8377         * tui/tui-layout.h: Rename include guard.
8378         * tui/tui-io.h: Rename include guard.
8379         * tui/tui-hooks.h: Rename include guard.
8380         * tui/tui-file.h: Rename include guard.
8381         * tui/tui-disasm.h: Rename include guard.
8382         * tui/tui-data.h: Rename include guard.
8383         * tui/tui-command.h: Rename include guard.
8384         * tic6x-tdep.h: Add include guard.
8385         * target/waitstatus.h: Rename include guard.
8386         * target/wait.h: Rename include guard.
8387         * target/target.h: Rename include guard.
8388         * target/resume.h: Rename include guard.
8389         * target-float.h: Rename include guard.
8390         * stabsread.h: Add include guard.
8391         * rs6000-tdep.h: Add include guard.
8392         * riscv-fbsd-tdep.h: Add include guard.
8393         * regformats/regdef.h: Rename include guard.
8394         * record.h: Rename include guard.
8395         * python/python.h: Rename include guard.
8396         * python/python-internal.h: Rename include guard.
8397         * python/py-stopevent.h: Rename include guard.
8398         * python/py-ref.h: Rename include guard.
8399         * python/py-record.h: Rename include guard.
8400         * python/py-record-full.h: Rename include guard.
8401         * python/py-record-btrace.h: Rename include guard.
8402         * python/py-instruction.h: Rename include guard.
8403         * python/py-events.h: Rename include guard.
8404         * python/py-event.h: Rename include guard.
8405         * procfs.h: Add include guard.
8406         * proc-utils.h: Add include guard.
8407         * p-lang.h: Add include guard.
8408         * or1k-tdep.h: Rename include guard.
8409         * observable.h: Rename include guard.
8410         * nto-tdep.h: Rename include guard.
8411         * nat/x86-linux.h: Rename include guard.
8412         * nat/x86-linux-dregs.h: Rename include guard.
8413         * nat/x86-gcc-cpuid.h: Add include guard.
8414         * nat/x86-dregs.h: Rename include guard.
8415         * nat/x86-cpuid.h: Rename include guard.
8416         * nat/ppc-linux.h: Rename include guard.
8417         * nat/mips-linux-watch.h: Rename include guard.
8418         * nat/linux-waitpid.h: Rename include guard.
8419         * nat/linux-ptrace.h: Rename include guard.
8420         * nat/linux-procfs.h: Rename include guard.
8421         * nat/linux-osdata.h: Rename include guard.
8422         * nat/linux-nat.h: Rename include guard.
8423         * nat/linux-namespaces.h: Rename include guard.
8424         * nat/linux-btrace.h: Rename include guard.
8425         * nat/glibc_thread_db.h: Rename include guard.
8426         * nat/gdb_thread_db.h: Rename include guard.
8427         * nat/gdb_ptrace.h: Rename include guard.
8428         * nat/fork-inferior.h: Rename include guard.
8429         * nat/amd64-linux-siginfo.h: Rename include guard.
8430         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8431         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8432         * nat/aarch64-linux.h: Rename include guard.
8433         * nat/aarch64-linux-hw-point.h: Rename include guard.
8434         * mn10300-tdep.h: Add include guard.
8435         * mips-linux-tdep.h: Add include guard.
8436         * mi/mi-parse.h: Rename include guard.
8437         * mi/mi-out.h: Rename include guard.
8438         * mi/mi-main.h: Rename include guard.
8439         * mi/mi-interp.h: Rename include guard.
8440         * mi/mi-getopt.h: Rename include guard.
8441         * mi/mi-console.h: Rename include guard.
8442         * mi/mi-common.h: Rename include guard.
8443         * mi/mi-cmds.h: Rename include guard.
8444         * mi/mi-cmd-break.h: Rename include guard.
8445         * m2-lang.h: Add include guard.
8446         * location.h: Rename include guard.
8447         * linux-record.h: Rename include guard.
8448         * linux-nat.h: Add include guard.
8449         * linux-fork.h: Add include guard.
8450         * i386-darwin-tdep.h: Rename include guard.
8451         * hppa-linux-offsets.h: Add include guard.
8452         * guile/guile.h: Rename include guard.
8453         * guile/guile-internal.h: Rename include guard.
8454         * gnu-nat.h: Rename include guard.
8455         * gdb-stabs.h: Rename include guard.
8456         * frv-tdep.h: Add include guard.
8457         * f-lang.h: Add include guard.
8458         * event-loop.h: Add include guard.
8459         * darwin-nat.h: Rename include guard.
8460         * cp-abi.h: Rename include guard.
8461         * config/sparc/nm-sol2.h: Rename include guard.
8462         * config/nm-nto.h: Rename include guard.
8463         * config/nm-linux.h: Add include guard.
8464         * config/i386/nm-i386gnu.h: Rename include guard.
8465         * config/djgpp/nl_types.h: Rename include guard.
8466         * config/djgpp/langinfo.h: Rename include guard.
8467         * compile/gcc-cp-plugin.h: Add include guard.
8468         * compile/gcc-c-plugin.h: Add include guard.
8469         * compile/compile.h: Rename include guard.
8470         * compile/compile-object-run.h: Rename include guard.
8471         * compile/compile-object-load.h: Rename include guard.
8472         * compile/compile-internal.h: Rename include guard.
8473         * compile/compile-cplus.h: Rename include guard.
8474         * compile/compile-c.h: Rename include guard.
8475         * common/xml-utils.h: Rename include guard.
8476         * common/x86-xstate.h: Rename include guard.
8477         * common/version.h: Rename include guard.
8478         * common/vec.h: Rename include guard.
8479         * common/tdesc.h: Rename include guard.
8480         * common/selftest.h: Rename include guard.
8481         * common/scoped_restore.h: Rename include guard.
8482         * common/scoped_mmap.h: Rename include guard.
8483         * common/scoped_fd.h: Rename include guard.
8484         * common/safe-iterator.h: Rename include guard.
8485         * common/run-time-clock.h: Rename include guard.
8486         * common/refcounted-object.h: Rename include guard.
8487         * common/queue.h: Rename include guard.
8488         * common/ptid.h: Rename include guard.
8489         * common/print-utils.h: Rename include guard.
8490         * common/preprocessor.h: Rename include guard.
8491         * common/pathstuff.h: Rename include guard.
8492         * common/observable.h: Rename include guard.
8493         * common/netstuff.h: Rename include guard.
8494         * common/job-control.h: Rename include guard.
8495         * common/host-defs.h: Rename include guard.
8496         * common/gdb_wait.h: Rename include guard.
8497         * common/gdb_vecs.h: Rename include guard.
8498         * common/gdb_unlinker.h: Rename include guard.
8499         * common/gdb_unique_ptr.h: Rename include guard.
8500         * common/gdb_tilde_expand.h: Rename include guard.
8501         * common/gdb_sys_time.h: Rename include guard.
8502         * common/gdb_string_view.h: Rename include guard.
8503         * common/gdb_splay_tree.h: Rename include guard.
8504         * common/gdb_setjmp.h: Rename include guard.
8505         * common/gdb_ref_ptr.h: Rename include guard.
8506         * common/gdb_optional.h: Rename include guard.
8507         * common/gdb_locale.h: Rename include guard.
8508         * common/gdb_assert.h: Rename include guard.
8509         * common/filtered-iterator.h: Rename include guard.
8510         * common/filestuff.h: Rename include guard.
8511         * common/fileio.h: Rename include guard.
8512         * common/environ.h: Rename include guard.
8513         * common/common-utils.h: Rename include guard.
8514         * common/common-types.h: Rename include guard.
8515         * common/common-regcache.h: Rename include guard.
8516         * common/common-inferior.h: Rename include guard.
8517         * common/common-gdbthread.h: Rename include guard.
8518         * common/common-exceptions.h: Rename include guard.
8519         * common/common-defs.h: Rename include guard.
8520         * common/common-debug.h: Rename include guard.
8521         * common/cleanups.h: Rename include guard.
8522         * common/buffer.h: Rename include guard.
8523         * common/btrace-common.h: Rename include guard.
8524         * common/break-common.h: Rename include guard.
8525         * cli/cli-utils.h: Rename include guard.
8526         * cli/cli-style.h: Rename include guard.
8527         * cli/cli-setshow.h: Rename include guard.
8528         * cli/cli-script.h: Rename include guard.
8529         * cli/cli-interp.h: Rename include guard.
8530         * cli/cli-decode.h: Rename include guard.
8531         * cli/cli-cmds.h: Rename include guard.
8532         * charset-list.h: Add include guard.
8533         * buildsym-legacy.h: Rename include guard.
8534         * bfin-tdep.h: Add include guard.
8535         * ax.h: Rename include guard.
8536         * arm-linux-tdep.h: Add include guard.
8537         * arm-fbsd-tdep.h: Add include guard.
8538         * arch/xtensa.h: Rename include guard.
8539         * arch/tic6x.h: Add include guard.
8540         * arch/i386.h: Add include guard.
8541         * arch/arm.h: Rename include guard.
8542         * arch/arm-linux.h: Rename include guard.
8543         * arch/arm-get-next-pcs.h: Rename include guard.
8544         * arch/amd64.h: Add include guard.
8545         * arch/aarch64-insn.h: Rename include guard.
8546         * arch-utils.h: Rename include guard.
8547         * annotate.h: Add include guard.
8548         * amd64-darwin-tdep.h: Rename include guard.
8549         * aarch64-linux-tdep.h: Add include guard.
8550         * aarch64-fbsd-tdep.h: Add include guard.
8551         * aarch32-linux-nat.h: Add include guard.
8552
8553 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8554
8555         * macrotab.c (macro_define_internal): New function that
8556         factorizes macro_define_object_internal and macro_define_function
8557         code.
8558         (macro_define_object_internal): Use macro_define_internal.
8559         (macro_define_function): Likewise.
8560
8561 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8562
8563         * macrocmd.c (extract_identifier): Return
8564         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8565         callers.
8566
8567 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8568
8569         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8570
8571 2019-02-05  Tom Tromey  <tom@tromey.com>
8572
8573         * target.c (target_stack::unpush): Move assertion earlier.
8574
8575 2019-01-30  Tom Tromey  <tom@tromey.com>
8576
8577         PR python/23615:
8578         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8579         (gdbpy_parse_and_eval): Likewise.
8580         * python/python-internal.h (gdbpy_allow_threads): New class.
8581
8582 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8583
8584         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8585         (aarch64_fbsd_fpregmap): Move earlier.
8586         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8587         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8588         instead of individual calls to trad_frame_set_reg_addr.
8589         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8590         earlier.
8591         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8592         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8593         instead of individual calls to trad_frame_set_reg_addr.
8594
8595 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8596
8597         * CONTRIBUTE: Replace contribution list with wiki link.
8598
8599 2019-01-25  Tom Tromey  <tom@tromey.com>
8600
8601         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8602
8603 2019-01-25  Tom Tromey  <tom@tromey.com>
8604
8605         * xtensa-linux-nat.c: Fix common/ includes.
8606         * xml-support.h: Fix common/ includes.
8607         * xml-support.c: Fix common/ includes.
8608         * x86-linux-nat.c: Fix common/ includes.
8609         * windows-nat.c: Fix common/ includes.
8610         * varobj.h: Fix common/ includes.
8611         * varobj.c: Fix common/ includes.
8612         * value.c: Fix common/ includes.
8613         * valops.c: Fix common/ includes.
8614         * utils.c: Fix common/ includes.
8615         * unittests/xml-utils-selftests.c: Fix common/ includes.
8616         * unittests/utils-selftests.c: Fix common/ includes.
8617         * unittests/unpack-selftests.c: Fix common/ includes.
8618         * unittests/tracepoint-selftests.c: Fix common/ includes.
8619         * unittests/style-selftests.c: Fix common/ includes.
8620         * unittests/string_view-selftests.c: Fix common/ includes.
8621         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8622         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8623         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8624         * unittests/rsp-low-selftests.c: Fix common/ includes.
8625         * unittests/parse-connection-spec-selftests.c: Fix common/
8626         includes.
8627         * unittests/optional-selftests.c: Fix common/ includes.
8628         * unittests/offset-type-selftests.c: Fix common/ includes.
8629         * unittests/observable-selftests.c: Fix common/ includes.
8630         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8631         * unittests/memrange-selftests.c: Fix common/ includes.
8632         * unittests/memory-map-selftests.c: Fix common/ includes.
8633         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8634         * unittests/function-view-selftests.c: Fix common/ includes.
8635         * unittests/environ-selftests.c: Fix common/ includes.
8636         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8637         * unittests/common-utils-selftests.c: Fix common/ includes.
8638         * unittests/cli-utils-selftests.c: Fix common/ includes.
8639         * unittests/array-view-selftests.c: Fix common/ includes.
8640         * ui-file.c: Fix common/ includes.
8641         * tui/tui-io.c: Fix common/ includes.
8642         * tracepoint.h: Fix common/ includes.
8643         * tracepoint.c: Fix common/ includes.
8644         * tracefile-tfile.c: Fix common/ includes.
8645         * top.h: Fix common/ includes.
8646         * top.c: Fix common/ includes.
8647         * thread.c: Fix common/ includes.
8648         * target/waitstatus.h: Fix common/ includes.
8649         * target/waitstatus.c: Fix common/ includes.
8650         * target.h: Fix common/ includes.
8651         * target.c: Fix common/ includes.
8652         * target-memory.c: Fix common/ includes.
8653         * target-descriptions.c: Fix common/ includes.
8654         * symtab.h: Fix common/ includes.
8655         * symfile.c: Fix common/ includes.
8656         * stap-probe.c: Fix common/ includes.
8657         * spu-linux-nat.c: Fix common/ includes.
8658         * sparc-nat.c: Fix common/ includes.
8659         * source.c: Fix common/ includes.
8660         * solib.c: Fix common/ includes.
8661         * solib-target.c: Fix common/ includes.
8662         * ser-unix.c: Fix common/ includes.
8663         * ser-tcp.c: Fix common/ includes.
8664         * ser-pipe.c: Fix common/ includes.
8665         * ser-base.c: Fix common/ includes.
8666         * selftest-arch.c: Fix common/ includes.
8667         * s12z-tdep.c: Fix common/ includes.
8668         * rust-exp.y: Fix common/ includes.
8669         * rs6000-aix-tdep.c: Fix common/ includes.
8670         * riscv-tdep.c: Fix common/ includes.
8671         * remote.c: Fix common/ includes.
8672         * remote-notif.h: Fix common/ includes.
8673         * remote-fileio.h: Fix common/ includes.
8674         * remote-fileio.c: Fix common/ includes.
8675         * regcache.h: Fix common/ includes.
8676         * regcache.c: Fix common/ includes.
8677         * record-btrace.c: Fix common/ includes.
8678         * python/python.c: Fix common/ includes.
8679         * python/py-type.c: Fix common/ includes.
8680         * python/py-inferior.c: Fix common/ includes.
8681         * progspace.h: Fix common/ includes.
8682         * producer.c: Fix common/ includes.
8683         * procfs.c: Fix common/ includes.
8684         * proc-api.c: Fix common/ includes.
8685         * printcmd.c: Fix common/ includes.
8686         * ppc-linux-nat.c: Fix common/ includes.
8687         * parser-defs.h: Fix common/ includes.
8688         * osdata.c: Fix common/ includes.
8689         * obsd-nat.c: Fix common/ includes.
8690         * nat/x86-linux.c: Fix common/ includes.
8691         * nat/x86-linux-dregs.c: Fix common/ includes.
8692         * nat/x86-dregs.h: Fix common/ includes.
8693         * nat/x86-dregs.c: Fix common/ includes.
8694         * nat/ppc-linux.c: Fix common/ includes.
8695         * nat/mips-linux-watch.h: Fix common/ includes.
8696         * nat/mips-linux-watch.c: Fix common/ includes.
8697         * nat/linux-waitpid.c: Fix common/ includes.
8698         * nat/linux-ptrace.h: Fix common/ includes.
8699         * nat/linux-ptrace.c: Fix common/ includes.
8700         * nat/linux-procfs.c: Fix common/ includes.
8701         * nat/linux-personality.c: Fix common/ includes.
8702         * nat/linux-osdata.c: Fix common/ includes.
8703         * nat/linux-namespaces.c: Fix common/ includes.
8704         * nat/linux-btrace.h: Fix common/ includes.
8705         * nat/linux-btrace.c: Fix common/ includes.
8706         * nat/fork-inferior.c: Fix common/ includes.
8707         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8708         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8709         * nat/aarch64-linux.c: Fix common/ includes.
8710         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8711         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8712         * namespace.h: Fix common/ includes.
8713         * mips-linux-tdep.c: Fix common/ includes.
8714         * minsyms.c: Fix common/ includes.
8715         * mi/mi-parse.h: Fix common/ includes.
8716         * mi/mi-main.c: Fix common/ includes.
8717         * mi/mi-cmd-env.c: Fix common/ includes.
8718         * memrange.h: Fix common/ includes.
8719         * memattr.c: Fix common/ includes.
8720         * maint.h: Fix common/ includes.
8721         * maint.c: Fix common/ includes.
8722         * main.c: Fix common/ includes.
8723         * machoread.c: Fix common/ includes.
8724         * location.c: Fix common/ includes.
8725         * linux-thread-db.c: Fix common/ includes.
8726         * linux-nat.c: Fix common/ includes.
8727         * linux-fork.c: Fix common/ includes.
8728         * inline-frame.c: Fix common/ includes.
8729         * infrun.c: Fix common/ includes.
8730         * inflow.c: Fix common/ includes.
8731         * inferior.h: Fix common/ includes.
8732         * inferior.c: Fix common/ includes.
8733         * infcmd.c: Fix common/ includes.
8734         * inf-ptrace.c: Fix common/ includes.
8735         * inf-child.c: Fix common/ includes.
8736         * ia64-linux-nat.c: Fix common/ includes.
8737         * i387-tdep.c: Fix common/ includes.
8738         * i386-tdep.c: Fix common/ includes.
8739         * i386-linux-tdep.c: Fix common/ includes.
8740         * i386-linux-nat.c: Fix common/ includes.
8741         * i386-go32-tdep.c: Fix common/ includes.
8742         * i386-fbsd-tdep.c: Fix common/ includes.
8743         * i386-fbsd-nat.c: Fix common/ includes.
8744         * guile/scm-type.c: Fix common/ includes.
8745         * guile/guile.c: Fix common/ includes.
8746         * go32-nat.c: Fix common/ includes.
8747         * gnu-nat.c: Fix common/ includes.
8748         * gdbthread.h: Fix common/ includes.
8749         * gdbarch-selftests.c: Fix common/ includes.
8750         * gdb_usleep.c: Fix common/ includes.
8751         * gdb_select.h: Fix common/ includes.
8752         * gdb_bfd.c: Fix common/ includes.
8753         * gcore.c: Fix common/ includes.
8754         * fork-child.c: Fix common/ includes.
8755         * findvar.c: Fix common/ includes.
8756         * fbsd-nat.c: Fix common/ includes.
8757         * event-top.c: Fix common/ includes.
8758         * event-loop.c: Fix common/ includes.
8759         * dwarf2read.c: Fix common/ includes.
8760         * dwarf2loc.c: Fix common/ includes.
8761         * dwarf2-frame.c: Fix common/ includes.
8762         * dwarf-index-cache.c: Fix common/ includes.
8763         * dtrace-probe.c: Fix common/ includes.
8764         * disasm-selftests.c: Fix common/ includes.
8765         * defs.h: Fix common/ includes.
8766         * csky-tdep.c: Fix common/ includes.
8767         * cp-valprint.c: Fix common/ includes.
8768         * cp-support.h: Fix common/ includes.
8769         * cp-support.c: Fix common/ includes.
8770         * corelow.c: Fix common/ includes.
8771         * completer.h: Fix common/ includes.
8772         * completer.c: Fix common/ includes.
8773         * compile/compile.c: Fix common/ includes.
8774         * compile/compile-loc2c.c: Fix common/ includes.
8775         * compile/compile-cplus-types.c: Fix common/ includes.
8776         * compile/compile-cplus-symbols.c: Fix common/ includes.
8777         * command.h: Fix common/ includes.
8778         * cli/cli-dump.c: Fix common/ includes.
8779         * cli/cli-cmds.c: Fix common/ includes.
8780         * charset.c: Fix common/ includes.
8781         * build-id.c: Fix common/ includes.
8782         * btrace.h: Fix common/ includes.
8783         * btrace.c: Fix common/ includes.
8784         * breakpoint.h: Fix common/ includes.
8785         * breakpoint.c: Fix common/ includes.
8786         * ax.h:
8787         (enum agent_op): Fix common/ includes.
8788         * ax-general.c (struct aop_map): Fix common/ includes.
8789         * ax-gdb.c: Fix common/ includes.
8790         * auxv.c: Fix common/ includes.
8791         * auto-load.c: Fix common/ includes.
8792         * arm-tdep.c: Fix common/ includes.
8793         * arch/riscv.c: Fix common/ includes.
8794         * arch/ppc-linux-common.c: Fix common/ includes.
8795         * arch/i386.c: Fix common/ includes.
8796         * arch/arm.c: Fix common/ includes.
8797         * arch/arm-linux.c: Fix common/ includes.
8798         * arch/arm-get-next-pcs.c: Fix common/ includes.
8799         * arch/amd64.c: Fix common/ includes.
8800         * arch/aarch64.c: Fix common/ includes.
8801         * arch/aarch64-insn.c: Fix common/ includes.
8802         * arch-utils.c: Fix common/ includes.
8803         * amd64-windows-tdep.c: Fix common/ includes.
8804         * amd64-tdep.c: Fix common/ includes.
8805         * amd64-sol2-tdep.c: Fix common/ includes.
8806         * amd64-obsd-tdep.c: Fix common/ includes.
8807         * amd64-nbsd-tdep.c: Fix common/ includes.
8808         * amd64-linux-tdep.c: Fix common/ includes.
8809         * amd64-linux-nat.c: Fix common/ includes.
8810         * amd64-fbsd-tdep.c: Fix common/ includes.
8811         * amd64-fbsd-nat.c: Fix common/ includes.
8812         * amd64-dicos-tdep.c: Fix common/ includes.
8813         * amd64-darwin-tdep.c: Fix common/ includes.
8814         * agent.c: Fix common/ includes.
8815         * ada-lang.h: Fix common/ includes.
8816         * ada-lang.c: Fix common/ includes.
8817         * aarch64-tdep.c: Fix common/ includes.
8818
8819 2019-01-25  Tom Tromey  <tom@tromey.com>
8820
8821         * common/create-version.sh: Use common/version.h.
8822
8823 2019-01-24  Pedro Alves  <palves@redhat.com>
8824
8825         * infrun.c (signal_stop, signal_print, signal_program)
8826         (signal_catch, signal_pass): Now arrays instead of pointers.
8827         (update_signals_program_target, do_target_resume)
8828         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8829         * linux-nat.c (linux_nat_target::pass_signals)
8830         (linux_nat_target::create_inferior, linux_nat_target::attach):
8831         Adjust.
8832         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8833         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8834         * procfs.c (procfs_target::pass_signals): Adjust.
8835         * record-full.c (record_full_target::resume): Adjust.
8836         * remote.c (remote_target::pass_signals)
8837         (remote_target::program_signals): Adjust.
8838         * target-debug.h (target_debug_print_signals): Now takes a
8839         gdb::array_view as parameter.  Adjust.
8840         * target.h (target_ops) <pass_signals, program_signals>: Replace
8841         pointer and length parameters with gdb::array_view.
8842         (target_pass_signals, target_program_signals): Likewise.
8843         * target-delegates.c: Regenerate.
8844
8845 2019-01-24  Pedro Alves  <palves@redhat.com>
8846
8847         * common/forward-scope-exit.h
8848         (forward_scope_exit::forward_scope_exit): Pass arguments to
8849         m_bind_function directly, instead of creating a std::bind and
8850         copying that.
8851
8852 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8853
8854         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8855         for static members.
8856         (pass_in_v_vfp_candidate): Likewise.
8857
8858 2019-01-23  Tom Tromey  <tom@tromey.com>
8859             Pedro Alves  <palves@redhat.com>
8860
8861         * regcache.c (class regcache_invalidator): Remove.
8862         (regcache::raw_write): Use make_scope_exit.
8863
8864 2019-01-23  Tom Tromey  <tom@tromey.com>
8865
8866         * ui-out.h (class ui_out_emit_type): Update comment.
8867
8868 2019-01-23  Tom Tromey  <tom@tromey.com>
8869
8870         * infrun.c (fetch_inferior_event): Update comment.
8871
8872 2019-01-23  Tom Tromey  <tom@tromey.com>
8873             Pedro Alves  <palves@redhat.com>
8874
8875         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8876         parameter.
8877         (fetch_inferior_event): Use SCOPE_EXIT.
8878
8879
8880 2019-01-23  Tom Tromey  <tom@tromey.com>
8881             Pedro Alves  <palves@redhat.com>
8882
8883         * infrun.c (disable_thread_events): Delete.
8884         (stop_all_threads): Use SCOPE_EXIT.
8885
8886 2019-01-23  Tom Tromey  <tom@tromey.com>
8887             Pedro Alves  <palves@redhat.com>
8888
8889         * symfile.c: Include forward-scope-exit.h.
8890         (clear_symtab_users_cleanup): Replace forward declaration with
8891         a FORWARD_SCOPE_EXIT.
8892         (syms_from_objfile_1): Use the forward_scope_exit and
8893         gdb::optional instead of cleanup_function.
8894         (reread_symbols): Use the forward_scope_exit instead of
8895         cleanup_function.
8896         (clear_symtab_users_cleanup): Remove function.
8897
8898 2019-01-23  Tom Tromey  <tom@tromey.com>
8899             Pedro Alves  <palves@redhat.com>
8900
8901         * linux-nat.c: Include scope-exit.h.
8902         (cleanup_target_stop): Remove.
8903         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8904         SCOPE_EXIT.
8905
8906 2019-01-23  Tom Tromey  <tom@tromey.com>
8907             Pedro Alves  <palves@redhat.com>
8908
8909         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8910         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8911
8912 2019-01-23  Tom Tromey  <tom@tromey.com>
8913             Andrew Burgess  <andrew.burgess@embecosm.com>
8914             Pedro Alves  <palves@redhat.com>
8915
8916         * infrun.c (fetch_inferior_event): Use scope_exit.
8917         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8918         * top.c (execute_command): Use scope_exit.
8919         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8920         * utils.c (do_bpstat_clear_actions_cleanup)
8921         (make_bpstat_clear_actions_cleanup): Remove.
8922
8923 2019-01-23  Tom Tromey  <tom@tromey.com>
8924             Pedro Alves  <palves@redhat.com>
8925
8926         * infrun.c: Include "common/scope-exit.h"
8927         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8928         (wait_for_inferior): Use SCOPE_EXIT.
8929         (fetch_inferior_event): Use scope_exit.
8930
8931 2019-01-23  Tom Tromey  <tom@tromey.com>
8932             Pedro Alves  <palves@redhat.com>
8933
8934         * breakpoint.c (create_breakpoint): Remove cleanup.
8935
8936 2019-01-23  Tom Tromey  <tom@tromey.com>
8937             Andrew Burgess  <andrew.burgess@embecosm.com>
8938             Pedro Alves  <palves@redhat.com>
8939
8940 2019-01-23  Pedro Alves  <palves@redhat.com>
8941
8942         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8943
8944 2019-01-23  Pedro Alves  <palves@redhat.com>
8945             Andrew Burgess  <andrew.burgess@embecosm.com>
8946
8947         * gdbthread.h: Include "common/forward-scope-exit.h".
8948         (scoped_finish_thread_state): Redefine custom class in terms of
8949         forward_scope_exit.
8950
8951 2019-01-23  Pedro Alves  <palves@redhat.com>
8952             Andrew Burgess  <andrew.burgess@embecosm.com>
8953
8954         * common/forward-scope-exit.h: New file.
8955
8956 2019-01-23  Pedro Alves  <palves@redhat.com>
8957             Andrew Burgess  <andrew.burgess@embecosm.com>
8958             Tom Tromey  <tom@tromey.com>
8959
8960         * common/scope-exit.h: New file.
8961
8962 2019-01-23  Pedro Alves  <palves@redhat.com>
8963
8964         * common/preprocessor.h (ESC): Rename to ...
8965         (ESC_PARENS): ... this.
8966         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8967         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8968
8969 2019-01-23  Tom Tromey  <tom@tromey.com>
8970
8971         * language.h (class scoped_switch_to_sym_language_if_auto):
8972         Initialize m_lang in both cases.
8973
8974 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8975
8976         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8977         with XCNEW.
8978
8979 2019-01-22  Tom Tromey  <tom@tromey.com>
8980
8981         * corelow.c: Do not include sys/file.h.
8982
8983 2019-01-22  Tom Tromey  <tom@tromey.com>
8984
8985         * tui/tui-wingeneral.h: Include gdb_curses.h.
8986
8987 2019-01-22  Tom Tromey  <tom@tromey.com>
8988
8989         * source-cache.h (class source_cache) <get_source_lines,
8990         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8991
8992 2019-01-22  Tom Tromey  <tom@tromey.com>
8993
8994         * remote-fileio.h (struct remote_target): Declare.
8995
8996 2019-01-22  Tom Tromey  <tom@tromey.com>
8997
8998         * python/py-arch.c: Do not include py-ref.h.
8999         * python/py-bpevent.c: Do not include py-ref.h.
9000         * python/py-cmd.c: Do not include py-ref.h.
9001         * python/py-continueevent.c: Do not include py-ref.h.
9002         * python/py-event.h: Do not include py-ref.h.
9003         * python/py-evtregistry.c: Do not include py-ref.h.
9004         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9005         * python/py-frame.c: Do not include py-ref.h.
9006         * python/py-framefilter.c: Do not include py-ref.h.
9007         * python/py-function.c: Do not include py-ref.h.
9008         * python/py-infevents.c: Do not include py-ref.h.
9009         * python/py-linetable.c: Do not include py-ref.h.
9010         * python/py-objfile.c: Do not include py-ref.h.
9011         * python/py-param.c: Do not include py-ref.h.
9012         * python/py-prettyprint.c: Do not include py-ref.h.
9013         * python/py-progspace.c: Do not include py-ref.h.
9014         * python/py-symbol.c: Do not include py-ref.h.
9015         * python/py-symtab.c: Do not include py-ref.h.
9016         * python/py-type.c: Do not include py-ref.h.
9017         * python/py-unwind.c: Do not include py-ref.h.
9018         * python/py-utils.c: Do not include py-ref.h.
9019         * python/py-value.c: Do not include py-ref.h.
9020         * python/py-varobj.c: Do not include py-ref.h.
9021         * python/py-xmethods.c: Do not include py-ref.h.
9022         * python/python.c: Do not include py-ref.h.
9023         * varobj.c: Do not include py-ref.h.
9024
9025 2019-01-22  Tom Tromey  <tom@tromey.com>
9026
9027         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9028         keyword for bcache.
9029
9030 2019-01-22  Tom Tromey  <tom@tromey.com>
9031
9032         * compile/compile-cplus-types.c: Remove a comment by #include.
9033
9034 2019-01-22  Tom Tromey  <tom@tromey.com>
9035
9036         * compile/gcc-c-plugin.h: Include compile-internal.h.
9037
9038 2019-01-22  Tom Tromey  <tom@tromey.com>
9039
9040         * stabsread.c (EXTERN): Do not define.
9041         (symnum, next_symbol_text_func, processing_gcc_compilation)
9042         (within_function, global_sym_chain, global_stabs)
9043         (previous_stab_code, this_object_header_files)
9044         (n_this_object_header_files)
9045         (n_allocated_this_object_header_files): Define.
9046         * stabsread.h (EXTERN): Never define.  Use "extern".
9047
9048 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9049
9050         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9051         history_value.
9052
9053 2019-01-21  Tom Tromey  <tom@tromey.com>
9054
9055         * ui-out.c: Fix includes.
9056         * tui/tui-source.c: Fix includes.
9057         * target.c: Fix includes.
9058         * remote.c: Fix includes.
9059         * regcache.c: Fix includes.
9060         * python/py-block.c: Fix includes.
9061         * printcmd.c: Fix includes.
9062         * or1k-tdep.c: Fix includes.
9063         * mi/mi-main.c: Fix includes.
9064         * m32r-tdep.c: Fix includes.
9065         * csky-tdep.c: Fix includes.
9066         * compile/compile-cplus-types.c: Fix includes.
9067         * cli/cli-interp.c: Fix includes.
9068
9069 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9070
9071         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9072         for padding.
9073
9074 2019-01-16  Tom Tromey  <tom@tromey.com>
9075
9076         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9077         earlier.
9078         (struct objfile) <msymbols_range>: Move from top level.
9079         <msymbols>: New method.
9080         (class objfile_msymbols): Remove.
9081         * symtab.c (default_collect_symbol_completion_matches_break_on):
9082         Update.
9083         * symmisc.c (dump_msymbols): Update.
9084         * stabsread.c (scan_file_globals): Update.
9085         * objc-lang.c (info_selectors_command, info_classes_command)
9086         (find_methods): Update.
9087         * minsyms.c (find_solib_trampoline_target): Update.
9088         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9089         * coffread.c (coff_symfile_read): Update.
9090         * ada-lang.c (ada_lookup_simple_minsym)
9091         (ada_collect_symbol_completion_matches): Update.
9092
9093 2019-01-16  Tom Tromey  <tom@tromey.com>
9094
9095         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9096         type.  Remove no-argument constructor.
9097         <iterator::operator++>: Simplify.
9098         <begin>: Update.
9099         <end>: Use minimal_symbol_count.
9100
9101 2019-01-16  Tom Tromey  <tom@tromey.com>
9102
9103         * objfiles.h (struct objfile) <psymtabs>: New method.
9104         (class objfile_psymtabs): Remove.
9105         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9106         typedef.
9107         <range>: New method.
9108         (require_partial_symbols): Change return type.
9109         * psymtab.c (require_partial_symbols)
9110         (psym_expand_symtabs_matching): Update.
9111         * mdebugread.c (parse_partial_symbols): Update.
9112         * dbxread.c (dbx_end_psymtab): Update.
9113
9114 2019-01-15  Tom Tromey  <tom@tromey.com>
9115
9116         * symtab.c (lookup_objfile_from_block)
9117         (lookup_symbol_in_objfile_symtabs)
9118         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9119         (find_line_symtab, info_sources_command)
9120         (default_collect_symbol_completion_matches_break_on)
9121         (make_source_files_completion_list): Update.
9122         * symmisc.c (print_objfile_statistics, dump_objfile)
9123         (maintenance_print_symbols, maintenance_info_symtabs)
9124         (maintenance_check_symtabs, maintenance_info_line_tables):
9125         Update.
9126         * source.c (select_source_symtab)
9127         (forget_cached_source_info_for_objfile): Update.
9128         * objfiles.h (class objfile_compunits): Remove.
9129         (struct objfile) <compunits_range>: New typedef.
9130         (compunits): New method.
9131         * objfiles.c (objfile_relocate1): Update.
9132         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9133         * maint.c (count_symtabs_and_blocks): Update.
9134         * linespec.c (iterate_over_all_matching_symtabs): Update.
9135         * cp-support.c (add_symbol_overload_list_qualified): Update.
9136         * coffread.c (coff_symtab_read): Update.
9137         * ada-lang.c (add_nonlocal_symbols)
9138         (ada_collect_symbol_completion_matches)
9139         (ada_add_global_exceptions): Update.
9140
9141 2019-01-15  Tom Tromey  <tom@tromey.com>
9142
9143         * progspace.h (program_space) <objfiles_safe_range>: New
9144         typedef.
9145         <objfiles_safe>: New method.
9146         * objfiles.h (class all_objfiles_safe): Remove.
9147         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9148         * jit.c (jit_inferior_exit_hook): Update.
9149
9150 2019-01-17  Tom Tromey  <tom@tromey.com>
9151
9152         * progspace.h (program_space) <objfiles_range>: New typedef.
9153         <objfiles>: New method.
9154         <objfiles_head>: Rename from objfiles.
9155         (object_files): Update.
9156         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9157         * guile/scm-pretty-print.c
9158         (ppscm_find_pretty_printer_from_objfiles): Update.
9159         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9160         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9161         Update.
9162         * python/py-progspace.c (pspy_get_objfiles): Update.
9163         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9164         Update.
9165         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9166         (objfpy_lookup_objfile_by_build_id): Update.
9167         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9168         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9169         Update.
9170         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9171         (expand_symtab_containing_pc, lookup_objfile_from_block)
9172         (lookup_static_symbol, basic_lookup_transparent_type)
9173         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9174         (find_line_symtab, info_sources_command)
9175         (default_collect_symbol_completion_matches_break_on)
9176         (make_source_files_completion_list, find_main_name): Update.
9177         * symmisc.c (print_symbol_bcache_statistics)
9178         (print_objfile_statistics, maintenance_print_symbols)
9179         (maintenance_print_msymbols, maintenance_print_objfiles)
9180         (maintenance_info_symtabs, maintenance_check_symtabs)
9181         (maintenance_expand_symtabs, maintenance_info_line_tables):
9182         Update.
9183         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9184         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9185         (map_overlay_command, unmap_overlay_command)
9186         (simple_overlay_update, expand_symtabs_matching)
9187         (map_symbol_filenames): Update.
9188         * symfile-debug.c (set_debug_symfile): Update.
9189         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9190         Update.
9191         * source.c (select_source_symtab, forget_cached_source_info):
9192         Update.
9193         * solib.c (solib_read_symbols): Update.
9194         * solib-spu.c (append_ocl_sos): Update.
9195         * psymtab.c (maintenance_print_psymbols)
9196         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9197         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9198         * printcmd.c (info_symbol_command): Update.
9199         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9200         Update.
9201         * objfiles.h (class all_objfiles): Remove.
9202         * objfiles.c (have_partial_symbols, have_full_symbols)
9203         (have_minimal_symbols, qsort_cmp, update_section_map)
9204         (shared_objfile_contains_address_p)
9205         (default_iterate_over_objfiles_in_search_order): Update.
9206         * objc-lang.c (info_selectors_command, info_classes_command)
9207         (find_methods): Update.
9208         * minsyms.c (find_solib_trampoline_target): Update.
9209         * maint.c (maintenance_info_sections)
9210         (maintenance_translate_address, count_symtabs_and_blocks):
9211         Update.
9212         * main.c (captured_main_1): Update.
9213         * linux-thread-db.c (try_thread_db_load_from_pdir)
9214         (has_libpthread): Update.
9215         * linespec.c (iterate_over_all_matching_symtabs)
9216         (search_minsyms_for_name): Update.
9217         * jit.c (jit_find_objf_with_entry_addr): Update.
9218         * hppa-tdep.c (find_unwind_entry)
9219         (hppa_lookup_stub_minimal_symbol): Update.
9220         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9221         Update.
9222         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9223         (elf_gnu_ifunc_resolve_by_got): Update.
9224         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9225         * dwarf-index-write.c (save_gdb_index_command): Update.
9226         * cp-support.c (add_symbol_overload_list_qualified): Update.
9227         * breakpoint.c (create_overlay_event_breakpoint)
9228         (create_longjmp_master_breakpoint)
9229         (create_std_terminate_master_breakpoint)
9230         (create_exception_master_breakpoint): Update.
9231         * blockframe.c (find_pc_partial_function): Update.
9232         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9233         (ada_collect_symbol_completion_matches)
9234         (ada_add_global_exceptions): Update.
9235
9236 2019-01-17  Tom Tromey  <tom@tromey.com>
9237
9238         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9239         declare VEC.
9240         (solib_target_parse_libraries): Change return type.
9241         (library_list_start_segment, library_list_start_section)
9242         (library_list_end_library, library_list_start_library); Update.
9243         (solib_target_free_library_list): Remove.
9244         (solib_target_parse_libraries): Remove cleanup.  Change return
9245         type.
9246         (solib_target_current_sos): Update.
9247
9248 2019-01-17  Tom Tromey  <tromey@bapiya>
9249
9250         * valprint.c: Replace "the the" with "the".
9251         * symtab.c: Replace "the the" with "the".
9252         * solib.c: Replace "the the" with "the".
9253         * solib-dsbt.c: Replace "the the" with "the".
9254         * linespec.c: Replace "the the" with "the".
9255         * dwarf2loc.h: Replace "the the" with "the".
9256         * amd64-windows-tdep.c: Replace "the the" with "the".
9257         * aarch64-tdep.c: Replace "the the" with "the".
9258
9259 2019-01-16  Keith Seitz  <keiths@redhat.com>
9260
9261         PR gdb/23773
9262         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9263         <builder>: Rename to ..
9264         <m_builder>: ... this and make private.
9265         (dwarf2_cu::get_builder): New method.  Change all users of
9266         `builder' to use this method.
9267         (dwarf2_start_symtab): Move to ...
9268         (dwarf2_cu::start_symtab): ... here.  Update all callers
9269         (setup_type_unit_groups): Move to ...
9270         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9271         callers.
9272         (dwarf2_cu::reset_builder): New method.
9273         (process_full_compunit, process_full_type_unit): Use
9274         dwarf2_cu::reset_builder.
9275         (follow_die_offset): Record the ancestor CU if it is different
9276         from the followed DIE's CU.
9277         (follow_die_sig_1): Likewise.
9278
9279 2019-01-15  Tom Tromey  <tom@tromey.com>
9280
9281         * remote.c (class remote_state) <buf>: Now a char_vector.
9282         <buf_size>: Remove.
9283         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9284         parameter.
9285         (remote_target::getpkt_or_notif_sane_1)
9286         (remote_target::getpkt_sane)
9287         (remote_target::getpkt_or_notif_sane): Likewise.
9288         (class remote_target) <putpkt>: New overload.
9289         (remote_target::read_frame): Change type of "buf_p".  Remove
9290         sizeof_p parameter.
9291         (packet_ok): New overload.
9292         (packet_check_result): New overload.
9293         Update all uses.
9294
9295 2019-01-14  Tom Tromey  <tom@tromey.com>
9296
9297         * remote-notif.c (handle_notification, remote_notif_ack)
9298         (remote_notif_parse): Make "buf" const.
9299         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9300         const.
9301         (remote_notif_parse, remote_notif_ack, handle_notification):
9302         Likewise.
9303         * remote.c (remote_notif_stop_parse): Make "buf" const.
9304         (remote_target::remote_parse_stop_reply): Make "buf" const.
9305         (remote_notif_stop_ack): Make "buf" const.
9306
9307 2019-01-14  Tom Tromey  <tom@tromey.com>
9308
9309         * remote.c (remote_console_output): Make parameter const.
9310
9311 2019-01-14  Tom Tromey  <tom@tromey.com>
9312
9313         * target-debug.h (target_debug_print_signals): Constify.
9314         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9315         * procfs.c (procfs_target::pass_signals): Update.
9316         * linux-nat.c (linux_nat_target::pass_signals): Update.
9317         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9318         * target-delegates.c: Rebuild.
9319         * remote.c (remote_target::program_signals): Update.
9320         (remote_target::pass_signals): Update.
9321         * target.c (target_pass_signals): Constify argument.
9322         (target_program_signals): Likewise.
9323         * target.h (struct target_ops) <pass_signals, program_signals>:
9324         Constify argument.
9325         (target_pass_signals, target_program_signals): Constify argument.
9326
9327 2019-01-14  Tom Tromey  <tom@tromey.com>
9328
9329         PR tui/28819:
9330         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9331
9332 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9333
9334         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9335         field.
9336         * rs6000-tdep.c: Include reggroups.h.
9337         (IS_V_ALIAS_PSEUDOREG): Define.
9338         (rs6000_register_name): Return names for the "vX" aliases.
9339         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9340         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9341         aliases.  Call default_register_reggroup_p for all other
9342         pseudo-registers.
9343         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9344         New functions.
9345         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9346         Handle "vX" aliases.
9347         (v_alias_pseudo_register_collect): New function.
9348         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9349         (rs6000_gdbarch_init): Initialize "vX" aliases as
9350         pseudo-registers.  Restore registration of
9351         rs6000_pseudo_register_reggroup_p with
9352         set_tdesc_pseudo_register_reggroup_p.
9353
9354 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9355
9356         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9357         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9358         set_gdbarch_num_pseudo_regs.
9359
9360 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9361
9362         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9363         Remove arg prefixname, add do_set and do_show.
9364         Add member functions set_list and show_list.
9365         * cli/cli-style.c (class cli_style_option): Update accordingly.
9366         (style_set_list): Move to file scope.
9367         (style_show_list): Likewise.
9368         (set_style): Call help_list.
9369         (show_style): Call cmd_show_list.
9370         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9371         Update to use the new macro.
9372
9373 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9374
9375         * ada-lang.c (_initialize_ada_language): Expand the help text
9376         for the "catch exception" command.
9377
9378 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9379
9380         * symtab.c (matching_obj_sections): Initialize obj,
9381         declare it closer to its usage.
9382
9383 2019-01-10  Tom Tromey  <tom@tromey.com>
9384
9385         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9386         (basic_inf_threads_range): Remove.
9387         (inf_threads_range, inf_non_exited_threads_range)
9388         (safe_inf_threads_range): Use next_adapter.
9389
9390 2019-01-10  Keith Seitz  <keiths@redhat.com>
9391
9392         PR gdb/23712
9393         PR symtab/23010
9394         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9395         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9396
9397 2019-01-10  Keith Seitz  <keiths@redhat.com>
9398
9399         PR gdb/23712
9400         PR symtab/23010
9401         * dictionary.c (pending_to_vector): Remove.
9402         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9403         Remove _1 suffix, replacing functions of the same name.  Update
9404         all callers.
9405         (dict_create_hashed, dict_create_hashed_expandable)
9406         (dict_create_linear, dict_create_linear_expandable, dict_free)
9407         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9408         Make functions static.
9409
9410 2019-01-10  Keith Seitz  <keiths@redhat.com>
9411
9412         PR gdb/23712
9413         PR symtab/23010
9414         * dictionary.h (struct dictionary): Replace declaration with
9415         multidictionary.
9416         (dict_create_hashed, dict_create_hashed_expandable)
9417         (dict_create_linear, dict_create_linear_expandable)
9418         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9419         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9420         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9421         taking multidictionary argument.
9422         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9423         * block.h (struct block) <dict>: Change to multidictionary
9424         and rename `multidict'.
9425         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9426         symmisc.c: Update all dictionary references to multidictionary.
9427
9428 2019-01-10  Keith Seitz  <keiths@redhat.com>
9429
9430         PR gdb/23712
9431         PR symtab/23010
9432         * dictionary.c: Include unordered_map.
9433         (pending_to_vector): New function.
9434         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9435         Rewrite the non-"_1" functions to take vector instead
9436         of linked list.
9437         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9438         "new" _1 versions of the same name.
9439         (multidictionary): Define.
9440         (std::hash<enum language): New definition.
9441         (collate_pending_symbols_by_language, mdict_create_hashed)
9442         (mdict_create_hashed_expandable, mdict_create_linear)
9443         (mdict_create_linear_expandable, mdict_free)
9444         (find_language_dictionary, create_new_language_dictionary)
9445         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9446         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9447         (mdict_size, mdict_empty): New functions.
9448         * dictionary.h (mdict_iterator): Define.
9449
9450 2019-01-10  Pedro Alves  <palves@redhat.com>
9451
9452         * breakpoint.c (read_uploaded_action)
9453         (create_tracepoint_from_upload): Adjust to use
9454         gdb::unique_xmalloc_ptr.
9455         * ctf.c (ctf_write_uploaded_tp):
9456         (SET_ARRAY_FIELD): Use emplace_back.
9457         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9458         * tracefile-tfile.c (tfile_write_uploaded_tp):
9459         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9460         gdb::unique_xmalloc_ptr.
9461         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9462         at_string, cond_string, cmd_strings>: Replace char pointers
9463         with gdb::unique_xmalloc_ptr.
9464
9465 2019-01-10  Pedro Alves  <palves@redhat.com>
9466
9467         * solib-target.c (library_list_start_library): Don't xstrdup name.
9468
9469 2019-01-10  Pedro Alves  <palves@redhat.com>
9470
9471         * mdebugread.c (parse_partial_symbols): Use
9472         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9473
9474 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9475
9476         * linux-fork.c (scoped_switch_fork_info)
9477         <~scoped_switch_fork_info>: Fix incorrect variable name.
9478
9479 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9480
9481         * linux-fork.c (scoped_switch_fork_info)
9482         <scoped_switch_fork_info>: Make explicit.
9483         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9484
9485 2019-01-10  Tom Tromey  <tom@tromey.com>
9486
9487         * objfiles.h (objfile::reset_psymtabs): Update.
9488         * objfiles.c (objfile::objfile): Update.
9489         * psymtab.h (psymtab_storage::obstack): Update.
9490         (psymtab_storage::m_obstack): Use gdb::optional.
9491         (class psymtab_storage): Update comment.  Remove objfile
9492         parameter.
9493         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9494
9495 2019-01-10  Tom Tromey  <tom@tromey.com>
9496
9497         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9498         <free_psymtabs>: Now private.
9499         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9500         (allocate_psymtab): Use new method.
9501
9502 2019-01-10  Tom Tromey  <tom@tromey.com>
9503
9504         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9505         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9506         * mdebugread.c (parse_partial_symbols): Use
9507         allocate_dependencies.
9508         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9509         allocate_dependencies.
9510         (process_psymtab_comp_unit_reader)
9511         (build_type_psymtab_dependencies): Likewise.
9512         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9513
9514 2019-01-10  Tom Tromey  <tom@tromey.com>
9515
9516         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9517         PSYMBOL_SET_LANGUAGE.
9518         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9519
9520 2019-01-10  Tom Tromey  <tom@tromey.com>
9521
9522         * psymtab.h (psymtab_storage::obstack): New method.
9523         <m_obstack>: Rename from obstack; now private.
9524         * psymtab.c (psymtab_storage): Update.
9525         * dwarf2read.c (create_addrmap_from_index)
9526         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9527         Update.
9528
9529 2019-01-10  Tom Tromey  <tom@tromey.com>
9530
9531         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9532         * objfiles.h (objfile::reset_psymtabs): New method.
9533
9534 2019-01-10  Tom Tromey  <tom@tromey.com>
9535
9536         * symmisc.c (print_symbol_bcache_statistics): Update.
9537         (print_objfile_statistics): Update.
9538         * symfile.c (reread_symbols): Update.
9539         * psymtab.h (class psymtab_storage): New.
9540         * psymtab.c (psymtab_storage): New constructor.
9541         (~psymtab_storage): New destructor.
9542         (require_partial_symbols): Update.
9543         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9544         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9545         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9546         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9547         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9548         (start_psymtab_common, end_psymtab_common)
9549         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9550         (allocate_psymtab): Update.
9551         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9552         Update.
9553         (dump_psymtab_addrmap, maintenance_print_psymbols)
9554         (maintenance_check_psymtabs): Update.
9555         (class objfile_psymtabs): Move to objfiles.h.
9556         * psympriv.h (discard_psymtab): Now inline.
9557         (psymtab_discarder::psymtab_discarder): Update.
9558         (psymtab_discarder::~psymtab_discarder): Update.
9559         (ALL_OBJFILE_PSYMTABS): Rewrite.
9560         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9561         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9562         Remove fields.
9563         <partial_symtabs>: New field.
9564         (class objfile_psymtabs): Move from psymtab.h.  Update.
9565         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9566         psymbol_cache.
9567         (objfile::~objfile): Don't destroy psymbol_cache.
9568         * mdebugread.c (parse_partial_symbols): Update.
9569         * dwarf2read.c (create_addrmap_from_index)
9570         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9571         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9572         (add_partial_subprogram, dwarf2_ranges_read): Update.
9573         * dwarf-index-write.c (write_address_map)
9574         (write_one_signatured_type, recursively_write_psymbols)
9575         (class debug_names, class debug_names, write_psymtabs_to_index):
9576         Update.
9577
9578 2019-01-10  Tom Tromey  <tom@tromey.com>
9579
9580         * symtab.h (SYMBOL_SET_NAMES): Update.
9581         (symbol_set_names): Update.
9582         (MSYMBOL_SET_NAMES): Update.
9583         * symtab.c (symbol_set_names): Change argument to be an
9584         objfile_per_bfd_storage.
9585         * psymtab.c (add_psymbol_to_bcache): Update.
9586         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9587
9588 2019-01-10  Tom Tromey  <tom@tromey.com>
9589
9590         * symtab.c (create_demangled_names_hash): Change argument to be an
9591         objfile_per_bfd_storage.
9592         (symbol_set_names): Update.
9593
9594 2019-01-10  Tom Tromey  <tom@tromey.com>
9595
9596         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9597         init_psymbol_list.
9598         * psymtab.c (init_psymbol_list): Do nothing if already called.
9599         * psympriv.h (init_psymbol_list): Add comment.
9600         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9601         init_psymbol_list.
9602         * dbxread.c (dbx_symfile_read): Unconditionally call
9603         init_psymbol_list.
9604
9605 2019-01-10  Tom Tromey  <tom@tromey.com>
9606
9607         * xcoffread.c (scan_xcoff_symtab): Update.
9608         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9609         "where".
9610         * mdebugread.c (parse_partial_symbols)
9611         (handle_psymbol_enumerators): Update.
9612         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9613         * dbxread.c (read_dbx_symtab): Update.
9614         * psympriv.h (psymbol_placement): New enum.
9615         (add_psymbol_to_list): Update.
9616
9617 2019-01-10  Tom Tromey  <tom@tromey.com>
9618
9619         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9620         static_psymbols parameters.
9621         (scan_xcoff_symtab): Update.
9622         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9623         static_psymbols parameters.
9624         * psympriv.h (start_psymtab_common): Update.
9625         * mdebugread.c (parse_partial_symbols): Update.
9626         * dwarf2read.c (create_partial_symtab): Update.
9627         * dbxread.c (read_dbx_symtab): Update.
9628         (start_psymtab): Remove global_psymbols and static_psymbols
9629         parameters.
9630
9631 2019-01-10  Tom Tromey  <tom@tromey.com>
9632
9633         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9634         * psymtab.c (allocate_psymtab): Add comment.
9635         * psympriv.h (allocate_psymtab): Add comment.
9636         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9637         initializations.
9638         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9639
9640 2019-01-10  Tom Tromey  <tom@tromey.com>
9641
9642         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9643         Don't declare.
9644         * mipsread.c: Include mdebugread.h.
9645         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9646         Declare.
9647         * elfread.c: Include mdebugread.h.
9648
9649 2019-01-09  Tom Tromey  <tom@tromey.com>
9650
9651         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9652         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9653         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9654         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9655         (psym_lookup_symbol, psym_find_last_source_symtab)
9656         (psym_forget_cached_source_info, psym_print_stats)
9657         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9658         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9659         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9660         (psym_find_compunit_symtab_by_address)
9661         (maintenance_print_psymbols, maintenance_info_psymtabs)
9662         (maintenance_check_psymtabs): Use ranged for.
9663         * psymtab.h (class objfile_psymtabs): New.
9664         (require_partial_symbols): Return objfile_psymtabs.
9665         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9666
9667 2019-01-09  Tom Tromey  <tom@tromey.com>
9668
9669         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9670         (find_pc_mapped_section, list_overlays_command)
9671         (map_overlay_command, unmap_overlay_command)
9672         (simple_overlay_update): Use all_objfiles.
9673         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9674         * printcmd.c (info_symbol_command): Use all_objfiles.
9675         * objfiles.h (ALL_OBJSECTIONS): Remove.
9676         * maint.c (maintenance_translate_address): Use all_objfiles.
9677         * gcore.c (gcore_create_callback): Use all_objfiles.
9678         (objfile_find_memory_regions): Likewise.
9679
9680 2019-01-09  Tom Tromey  <tom@tromey.com>
9681
9682         * symtab.c (find_line_symtab, info_sources_command)
9683         (make_source_files_completion_list): Use objfile_compunits.
9684         * source.c (select_source_symtab): Use objfile_compunits.
9685         * objfiles.h (struct objfile): Update comment.
9686         (ALL_OBJFILES): Remove.
9687         (ALL_FILETABS): Remove.
9688         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9689         objfile_compunits.
9690
9691 2019-01-09  Tom Tromey  <tom@tromey.com>
9692
9693         * symmisc.c (print_objfile_statistics, dump_objfile)
9694         (maintenance_print_symbols): Use compunit_filetabs.
9695         * source.c (forget_cached_source_info_for_objfile): Use
9696         compunit_filetabs.
9697         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9698         (ALL_FILETABS): Use compunit_filetabs.
9699         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9700         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9701
9702 2019-01-09  Tom Tromey  <tom@tromey.com>
9703
9704         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9705         (compunit_filetabs): New.
9706         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9707         compunit_filetabs.
9708         (info_sources_command, make_source_files_completion_list): Remove
9709         declaration.
9710         * symmisc.c (print_objfile_statistics, dump_objfile)
9711         (maintenance_print_symbols): Remove declaration.
9712         (maintenance_info_symtabs): Use compunit_filetabs.
9713         (maintenance_info_line_tables): Likewise.
9714         * source.c (select_source_symtab): Change local variable name.
9715         (forget_cached_source_info_for_objfile): Remove declaration.
9716         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9717         * objfiles.c (objfile_relocate1): Remove declaration.
9718         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9719         declaration.
9720         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9721         * coffread.c (coff_symtab_read): Remove declaration.
9722         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9723         compunit_filetabs.
9724
9725 2019-01-09  Tom Tromey  <tom@tromey.com>
9726
9727         * symtab.c (lookup_objfile_from_block)
9728         (find_pc_sect_compunit_symtab, search_symbols)
9729         (default_collect_symbol_completion_matches_break_on): Use
9730         objfile_compunits.
9731         * objfiles.h (ALL_COMPUNITS): Remove.
9732         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9733         * cp-support.c (add_symbol_overload_list_qualified): Use
9734         objfile_compunits.
9735         * ada-lang.c (ada_collect_symbol_completion_matches)
9736         (ada_add_global_exceptions): Use objfile_compunits.
9737
9738 2019-01-09  Tom Tromey  <tom@tromey.com>
9739
9740         * source.c (select_source_symtab)
9741         (forget_cached_source_info_for_objfile): Remove declaration.
9742         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9743         declaration.
9744         * maint.c (count_symtabs_and_blocks): Remove declaration.
9745         * cp-support.c (add_symbol_overload_list_qualified): Remove
9746         declaration.
9747         * coffread.c (coff_symtab_read): Remove declaration.
9748         * symtab.c (lookup_symbol_in_objfile_symtabs)
9749         (basic_lookup_transparent_type_1): Use objfile_compunits.
9750         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9751         (info_sources_command, search_symbols)
9752         (default_collect_symbol_completion_matches_break_on)
9753         (make_source_files_completion_list): Remove declaration.
9754         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9755         (ada_collect_symbol_completion_matches)
9756         (ada_add_global_exceptions): Remove declaration.
9757         * linespec.c (iterate_over_all_matching_symtabs): Use
9758         objfile_compunits.
9759         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9760         (class objfile_compunits): New.
9761         (ALL_COMPUNITS): Use objfile_compunits.
9762         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9763         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9764         objfile_compunits.
9765         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9766
9767 2019-01-09  Tom Tromey  <tom@tromey.com>
9768
9769         * symtab.c (search_symbols)
9770         (default_collect_symbol_completion_matches_break_on): Use
9771         objfile_msymbols.
9772         * ada-lang.c (ada_lookup_simple_minsym)
9773         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9774         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9775         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9776         objfile_msymbols.
9777         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9778         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9779         * objc-lang.c (find_methods): Use objfile_msymbols.
9780         (info_selectors_command, info_classes_command): Likewise.
9781         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9782         * objfiles.h (class objfile_msymbols): New.
9783         (ALL_OBJFILE_MSYMBOLS): Remove.
9784         (ALL_MSYMBOLS): Remove.
9785
9786 2019-01-09  Tom Tromey  <tom@tromey.com>
9787
9788         * common/next-iterator.h (next_adapter): Add Iterator template
9789         parameter.
9790         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9791         (class all_objfiles_safe): New.
9792         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9793         * objfiles.c (put_objfile_before): Update comment.
9794         (add_separate_debug_objfile): Likewise.
9795         (free_all_objfiles): Use all_objfiles_safe.
9796         (objfile_purge_solibs): Likewise.
9797
9798 2019-01-09  Tom Tromey  <tom@tromey.com>
9799
9800         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9801         (expand_symtab_containing_pc, lookup_static_symbol)
9802         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9803         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9804         all_objfiles.
9805         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9806         * breakpoint.c (create_overlay_event_breakpoint)
9807         (create_longjmp_master_breakpoint)
9808         (create_std_terminate_master_breakpoint)
9809         (create_exception_master_breakpoint): Use all_objfiles.
9810         * linux-thread-db.c (try_thread_db_load_from_pdir)
9811         (has_libpthread): Use all_objfiles.
9812         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9813         * linespec.c (iterate_over_all_matching_symtabs)
9814         (search_minsyms_for_name): Use all_objfiles.
9815         * maint.c (maintenance_info_sections): Use all_objfiles.
9816         * main.c (captured_main_1): Use all_objfiles.
9817         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9818         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9819         * guile/scm-pretty-print.c
9820         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9821         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9822         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9823         (maintenance_print_msymbols): Use all_objfiles.
9824         * source.c (select_source_symtab): Use all_objfiles.
9825         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9826         * symfile.c (remove_symbol_file_command)
9827         (expand_symtabs_matching, map_symbol_filenames): Use
9828         all_objfiles.
9829         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9830         all_objfiles.
9831         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9832         * objc-lang.c (find_methods): Use all_objfiles.
9833         * objfiles.c (have_partial_symbols, have_full_symbols)
9834         (have_minimal_symbols, qsort_cmp)
9835         (default_iterate_over_objfiles_in_search_order): Use
9836         all_objfiles.
9837         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9838         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9839         (maintenance_check_psymtabs): Use all_objfiles.
9840         (ALL_PSYMTABS): Remove.
9841         * compile/compile-object-run.c (do_module_cleanup): Use
9842         all_objfiles.
9843         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9844         * cp-support.c (add_symbol_overload_list_qualified): Use
9845         all_objfiles.
9846         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9847         Use all_objfiles.
9848         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9849         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9850         all_objfiles.
9851         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9852         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9853         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9854         Uses all_objfiles.
9855         * solib.c (solib_read_symbols): Use all_objfiles
9856
9857 2019-01-09  Tom Tromey  <tom@tromey.com>
9858
9859         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9860         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9861         all_objfiles.
9862         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9863         * symmisc.c (print_symbol_bcache_statistics)
9864         (print_objfile_statistics, maintenance_print_objfiles)
9865         (maintenance_info_symtabs, maintenance_check_symtabs)
9866         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9867         all_objfiles.
9868         * source.c (forget_cached_source_info): Use all_objfiles.
9869         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9870         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9871         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9872         * objfiles.c (update_section_map): Use all_objfiles.
9873         (shared_objfile_contains_address_p): Likewise.
9874         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9875         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9876
9877 2019-01-09  Tom Tromey  <tom@tromey.com>
9878
9879         * common/next-iterator.h: New file.
9880         * objfiles.h (class all_objfiles): New.
9881         (struct objfile_iterator): New.
9882
9883 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9884
9885         * NEWS: Move the description of the changed "frame", "select-frame",
9886          and "info frame" commands to the Changed commands section.
9887
9888 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9889
9890         * gdbtypes.c (check_stub_method_group): Remove handling of old
9891         mangling schemes.
9892         * linespec.c (find_methods): Likewise.
9893         * stabsread.c (read_member_functions): Likewise.
9894         * valops.c (search_struct_method): Likewise.
9895         (value_struct_elt_for_reference): Likewise.
9896         * NEWS: Mention this change.
9897
9898 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9899
9900         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9901         print_source_lines.
9902         * source.c (print_source_lines_base): Update line number check.
9903         (print_source_lines): New function.
9904         (source_lines_range::source_lines_range): New function.
9905         * source.h (class source_lines_range): New class.
9906         (print_source_lines): New declaration.
9907
9908 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9909
9910         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9911
9912 2019-01-08  Tom Tromey  <tom@tromey.com>
9913             Simon Marchi  <simon.marchi@ericsson.com>
9914
9915         PR gdb/24060
9916         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9917         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9918         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9919         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9920         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9921         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9922
9923 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9924
9925         * source.c (select_source_symtab): Move header comment to
9926         declaration in source.h.
9927         (forget_cached_source_info_for_objfile): Likewise.
9928         (forget_cached_source_info): Likewise.
9929         (identify_source_line): Likewise.
9930         * source.h (identify_source_line): Move declaration from symtab.h
9931         and add comment from source.c
9932         (print_source_lines): Likewise.
9933         (forget_cached_source_info_for_objfile): Likewise.
9934         (forget_cached_source_info): Likewise.
9935         (select_source_symtab): Likewise.
9936         (enum print_source_lines_flag): Move definition from symtab.h.
9937         * symtab.h (identify_source_line): Move declaration to source.h.
9938         (print_source_lines): Likewise.
9939         (forget_cached_source_info_for_objfile): Likewise.
9940         (forget_cached_source_info): Likewise.
9941         (select_source_symtab): Likewise.
9942         (enum print_source_lines_flag): Move definition to source.h.
9943         * tui/tui-hooks.c: Add 'source.h' include.
9944
9945 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9946
9947         * source.c (print_source_lines_base): Handle requests to print
9948         reverse line number sequences, and guard against empty lines
9949         string.
9950
9951 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9952
9953         * source.c (print_source_lines_base): Fix skip of '\r' if next
9954         character is '\n'.
9955
9956 2019-01-06  Tom Tromey  <tom@tromey.com>
9957
9958         * c-exp.y (struct c_parse_state) <macro_original_text,
9959         expansion_obstack>: New member.
9960         (macro_original_text, expansion_obstack): Remove globals.
9961         (scan_macro_expansion, scanning_macro_expansion)
9962         (finished_macro_expansion): Update.
9963         (scan_macro_cleanup): Remove.
9964         (yylex, c_parse): Update.
9965
9966 2019-01-06  Tom Tromey  <tom@tromey.com>
9967
9968         * c-exp.y (struct c_parse_state) <strings>: New member.
9969         (operator_stoken): Update.
9970
9971 2019-01-06  Tom Tromey  <tom@tromey.com>
9972
9973         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9974         (union type_stack_elt) <typelist_val>: Now a pointer to
9975         std::vector.
9976         (type_stack_cleanup): Don't declare.
9977         (push_typelist): Update.
9978         * parse.c (pop_typelist): Return a std::vector.
9979         (push_typelist): Take a std::vector.
9980         (follow_types): Update.  Do not free args.
9981         (type_stack_cleanup): Remove.
9982         * c-exp.y (struct c_parse_state): New.
9983         (cpstate): New global.
9984         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9985         (nonempty_typelist): Update.
9986         (func_mod): Create a new vector.
9987         (c_parse): Create a c_parse_state.
9988         (check_parameter_typelist): Do not delete params.
9989         (function_method): Update.  Do not delete type_list.
9990
9991 2019-01-06  Tom Tromey  <tom@tromey.com>
9992
9993         PR gdb/28155:
9994         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9995         check_typedef.
9996         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9997         (print_return_value): Likewise.
9998
9999 2019-01-05  Tom Tromey  <tom@tromey.com>
10000
10001         * contrib/cleanup_check.py: Remove.
10002         * contrib/gcc-with-excheck: Remove.
10003         * contrib/exsummary.py: Remove.
10004         * contrib/excheck.py: Remove.
10005
10006 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10007
10008         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10009         NULL. Initialize tpprev to NULL instead of assigning it
10010         to NULL on the next statement.
10011         * windows-nat.c (windows_delete_thread): Remove check for
10012         main_thread_id before printing thread exit notifications.
10013         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10014         Remove thread ID check against main_thread_id.
10015         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10016         windows_delete_thread.
10017         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10018
10019 2019-01-04  Tom Tromey  <tom@tromey.com>
10020
10021         * compile/compile.c (_initialize_compile): Use upper case for
10022         metasyntactic variables.
10023         * symmisc.c (_initialize_symmisc): Use upper case for
10024         metasyntactic variables.
10025         * psymtab.c (_initialize_psymtab): Use upper case for
10026         metasyntactic variables.
10027         * demangle.c (demangle_command): Use upper case for metasyntactic
10028         variables.
10029         (_initialize_demangler): Likewise.
10030         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10031         variables.
10032
10033 2019-01-03  Tom Tromey  <tom@tromey.com>
10034
10035         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10036
10037 2019-01-03  Tom Tromey  <tom@tromey.com>
10038
10039         * python/py-symtab.c (salpy_str): Update.
10040         (struct salpy_sal_object) <symtab>: Now a PyObject.
10041         (salpy_dealloc): Update.
10042         (del_objfile_sal): Use gdbpy_ref.
10043
10044 2019-01-03  Tom Tromey  <tom@tromey.com>
10045
10046         * python/py-type.c (convert_field): Use new_reference.  Return
10047         gdbpy_ref.
10048         (make_fielditem): Return gdbpy_ref.
10049         (typy_fields): Update.
10050         (typy_getitem): Update.
10051         (field_name): Return gdbpy_ref.  Use new_reference.
10052         (typy_iterator_iternext): Update.
10053
10054 2019-01-03  Tom Tromey  <tom@tromey.com>
10055
10056         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10057
10058 2019-01-03  Tom Tromey  <tom@tromey.com>
10059
10060         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10061         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10062         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10063         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10064         (pspy_set_type_printers): Likewise.
10065         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10066         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10067         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10068         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10069         (objfpy_set_type_printers): Likewise.
10070
10071 2019-01-03  Tom Tromey  <tom@tromey.com>
10072
10073         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10074         (gdbpy_print_stack): Use gdbpy_err_fetch.
10075         * python/python-internal.h (class gdbpy_err_fetch): New class.
10076         (class gdbpy_enter) <m_error_type, m_error_value,
10077         m_error_traceback>: Remove.
10078         <m_error>: New member.
10079         (gdbpy_exception_to_string): Don't declare.
10080         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10081         * python/py-value.c (convert_value_from_python): Use
10082         gdbpy_err_fetch.
10083         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10084         gdbpy_exception_to_string.
10085         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10086         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10087         gdbpy_err_fetch.
10088
10089 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10090
10091         * linux-nat.c (delete_lwp_cleanup): Delete.
10092         (struct lwp_deleter): New struct.
10093         (lwp_info_up): New typedef.
10094         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10095         lwp_info_up.
10096
10097 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10098
10099         * linux-fork.c (class scoped_switch_fork_info): New class.
10100         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10101
10102 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10103
10104         * valops.c (find_overload_match): Remove use of null_cleanup, and
10105         calls to do_cleanups.
10106
10107 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10108
10109         * compile/compile-cplus-types.c
10110         (compile_cplus_instance::decl_name): Handle changes to
10111         cp_func_name.
10112         * cp-support.c (cp_func_name): Update header comment, update
10113         return type.
10114         * cp-support.h (cp_func_name): Update return type in declaration.
10115         * valops.c (find_overload_match): Move temp_func local to top
10116         level of function and change its type.  Use temp_func to hold and
10117         delete temporary string obtained from cp_func_name.
10118
10119 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10120
10121         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10122         gdb::char_vector, remove cleanup, and update uses of `msg`.
10123
10124 2019-01-03  Jim Wilson  <jimw@sifive.com>
10125
10126         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10127
10128 2019-01-02  Tom Tromey  <tom@tromey.com>
10129
10130         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10131         (tdesc_parse_xml): Remove cleanups.
10132         * target-descriptions.h (make_cleanup_free_target_description):
10133         Don't declare.
10134         (target_desc_deleter): New struct.
10135         (target_desc_up): New typedef.
10136         * target-descriptions.c (target_desc_deleter::operator()): Rename
10137         from free_target_description.
10138         (make_cleanup_free_target_description): Remove.
10139
10140 2019-01-02  Tom Tromey  <tom@tromey.com>
10141
10142         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10143         constructor, destructor.
10144         (linespec_parser): Remove typedef.
10145         (~linespec_parser): Rename from linespec_parser_delete.
10146         (linespec_lex_to_end, linespec_complete_label)
10147         (linespec_complete): Update.
10148         (decode_line_full): Remove cleanups.
10149         (decode_line_1): Update.
10150
10151 2019-01-02  Tom Tromey  <tom@tromey.com>
10152
10153         * python/python-internal.h (inferior_to_inferior_object): Change
10154         return type.
10155         * python/py-exitedevent.c (create_exited_event_object): Update.
10156         * python/py-inferior.c (inferior_to_inferior_object): Return
10157         gdbpy_ref.
10158         (python_new_inferior, python_inferior_deleted)
10159         (thread_to_thread_object, delete_thread_object)
10160         (build_inferior_list, gdbpy_selected_inferior): Update.
10161         * python/py-infthread.c (create_thread_object): Update.  Also fail
10162         if inferior_to_inferior_object fails.
10163
10164 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10165
10166         * inferior.h (class inferior) <displaced_step_state>: New field.
10167         * infrun.h (struct displaced_step_state): Move here from
10168         infrun.c.  Initialize fields, add constructor.
10169         <inf>: Remove field.
10170         <reset>: New method.
10171         * infrun.c (struct displaced_step_inferior_state): Move to
10172         infrun.h.
10173         (displaced_step_inferior_states): Remove.
10174         (get_displaced_stepping_state): Adust.
10175         (displaced_step_in_progress_any_inferior): Adjust.
10176         (displaced_step_in_progress_thread): Adjust.
10177         (displaced_step_in_progress): Adjust.
10178         (add_displaced_stepping_state): Remove.
10179         (get_displaced_step_closure_by_addr): Adjust.
10180         (remove_displaced_stepping_state): Remove.
10181         (infrun_inferior_exit): Call displaced_step_state.reset.
10182         (use_displaced_stepping): Don't check for NULL.
10183         (displaced_step_prepare_throw): Call
10184         get_displaced_stepping_state.
10185         (displaced_step_fixup): Don't check for NULL.
10186         (prepare_for_detach): Don't check for NULL.
10187
10188 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10189
10190         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10191          in case of call that did not complete.
10192
10193 2019-01-02  Andrey Utkin  <autkin@undo.io>
10194
10195         * symfile.c (find_separate_debug_file): Fix search of debug files for
10196         remote debuggee.
10197
10198 2019-01-02  Tom Tromey  <tom@tromey.com>
10199
10200         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10201         indentation.
10202         * python/py-frame.c (frapy_older): Remove cast.
10203         (frapy_newer): Likewise.
10204         * python/py-breakpoint.c (local_setattro): Remove cast.
10205         * python/py-arch.c (archpy_name): Remove local variable.
10206         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10207
10208 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10209
10210         * unittests/basic_string_view/element_access/char/empty.cc:
10211         Fix year range in copyright header.
10212
10213 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10214
10215         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10216         Delete.
10217         <operator==>: Update with for removed field.
10218         <hash>: Likewise.
10219         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10220         <isa_features>: ...this.
10221         <abi_features>: New field.
10222         (riscv_isa_flen): Update comment.
10223         (riscv_abi_xlen): New declaration.
10224         (riscv_abi_flen): New declaration.
10225         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10226         isa_features.
10227         (riscv_abi_xlen): New function.
10228         (riscv_isa_flen): Update to get answer from isa_features.
10229         (riscv_abi_flen): New function.
10230         (riscv_has_fp_abi): Update to get answer from abi_features.
10231         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10232         xlen and flen.
10233         (riscv_call_info) <xlen, flen>: Update comment.
10234         (riscv_call_arg_struct): Remove invalid assertions
10235         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10236         is removed.
10237         (riscv_gdbarch_init): Gather isa features and abi features
10238         separately, ensure both match on the gdbarch when reusing an old
10239         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10240         a target with 64-bit float hardware.
10241
10242 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10243
10244         * source.c (search_command_helper): Stop reverse search
10245         when line 1 has been searched.
10246
10247 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10248
10249         * record-full.c (record_full_base_target::close): Rewrite
10250         record_full_core_buf_list free logic.
10251
10252 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10253
10254         * break-catch-syscall.c (print_one_catch_syscall): xfree
10255         the last text.
10256
10257 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10258
10259         * top.c (print_gdb_version): Update Copyright year in version
10260         message.
10261
10262 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10263
10264         Update copyright year range in all GDB files.
10265
10266 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10267
10268         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10269
10270 For older changes see ChangeLog-2018.
10271 \f
10272 Local Variables:
10273 mode: change-log
10274 left-margin: 8
10275 fill-column: 74
10276 version-control: never
10277 coding: utf-8
10278 End:
10279