gdb/ChangeLog

   1 2019-04-05  Tom Tromey  <tom@tromey.com>
   2
   3         Revert the header-sorting patch.
   4         * ft32-tdep.c: Revert.
   5         * frv-tdep.c: Revert.
   6         * frv-linux-tdep.c: Revert.
   7         * frame.c: Revert.
   8         * frame-unwind.c: Revert.
   9         * frame-base.c: Revert.
  10         * fork-child.c: Revert.
  11         * findvar.c: Revert.
  12         * findcmd.c: Revert.
  13         * filesystem.c: Revert.
  14         * filename-seen-cache.h: Revert.
  15         * filename-seen-cache.c: Revert.
  16         * fbsd-tdep.c: Revert.
  17         * fbsd-nat.h: Revert.
  18         * fbsd-nat.c: Revert.
  19         * f-valprint.c: Revert.
  20         * f-typeprint.c: Revert.
  21         * f-lang.c: Revert.
  22         * extension.h: Revert.
  23         * extension.c: Revert.
  24         * extension-priv.h: Revert.
  25         * expprint.c: Revert.
  26         * exec.h: Revert.
  27         * exec.c: Revert.
  28         * exceptions.c: Revert.
  29         * event-top.c: Revert.
  30         * event-loop.c: Revert.
  31         * eval.c: Revert.
  32         * elfread.c: Revert.
  33         * dwarf2read.h: Revert.
  34         * dwarf2read.c: Revert.
  35         * dwarf2loc.c: Revert.
  36         * dwarf2expr.h: Revert.
  37         * dwarf2expr.c: Revert.
  38         * dwarf2-frame.c: Revert.
  39         * dwarf2-frame-tailcall.c: Revert.
  40         * dwarf-index-write.h: Revert.
  41         * dwarf-index-write.c: Revert.
  42         * dwarf-index-common.c: Revert.
  43         * dwarf-index-cache.h: Revert.
  44         * dwarf-index-cache.c: Revert.
  45         * dummy-frame.c: Revert.
  46         * dtrace-probe.c: Revert.
  47         * disasm.h: Revert.
  48         * disasm.c: Revert.
  49         * disasm-selftests.c: Revert.
  50         * dictionary.c: Revert.
  51         * dicos-tdep.c: Revert.
  52         * demangle.c: Revert.
  53         * dcache.h: Revert.
  54         * dcache.c: Revert.
  55         * darwin-nat.h: Revert.
  56         * darwin-nat.c: Revert.
  57         * darwin-nat-info.c: Revert.
  58         * d-valprint.c: Revert.
  59         * d-namespace.c: Revert.
  60         * d-lang.c: Revert.
  61         * ctf.c: Revert.
  62         * csky-tdep.c: Revert.
  63         * csky-linux-tdep.c: Revert.
  64         * cris-tdep.c: Revert.
  65         * cris-linux-tdep.c: Revert.
  66         * cp-valprint.c: Revert.
  67         * cp-support.c: Revert.
  68         * cp-namespace.c: Revert.
  69         * cp-abi.c: Revert.
  70         * corelow.c: Revert.
  71         * corefile.c: Revert.
  72         * continuations.c: Revert.
  73         * completer.h: Revert.
  74         * completer.c: Revert.
  75         * complaints.c: Revert.
  76         * coffread.c: Revert.
  77         * coff-pe-read.c: Revert.
  78         * cli-out.h: Revert.
  79         * cli-out.c: Revert.
  80         * charset.c: Revert.
  81         * c-varobj.c: Revert.
  82         * c-valprint.c: Revert.
  83         * c-typeprint.c: Revert.
  84         * c-lang.c: Revert.
  85         * buildsym.c: Revert.
  86         * buildsym-legacy.c: Revert.
  87         * build-id.h: Revert.
  88         * build-id.c: Revert.
  89         * btrace.c: Revert.
  90         * bsd-uthread.c: Revert.
  91         * breakpoint.h: Revert.
  92         * breakpoint.c: Revert.
  93         * break-catch-throw.c: Revert.
  94         * break-catch-syscall.c: Revert.
  95         * break-catch-sig.c: Revert.
  96         * blockframe.c: Revert.
  97         * block.c: Revert.
  98         * bfin-tdep.c: Revert.
  99         * bfin-linux-tdep.c: Revert.
 100         * bfd-target.c: Revert.
 101         * bcache.c: Revert.
 102         * ax-general.c: Revert.
 103         * ax-gdb.h: Revert.
 104         * ax-gdb.c: Revert.
 105         * avr-tdep.c: Revert.
 106         * auxv.c: Revert.
 107         * auto-load.c: Revert.
 108         * arm-wince-tdep.c: Revert.
 109         * arm-tdep.c: Revert.
 110         * arm-symbian-tdep.c: Revert.
 111         * arm-pikeos-tdep.c: Revert.
 112         * arm-obsd-tdep.c: Revert.
 113         * arm-nbsd-tdep.c: Revert.
 114         * arm-nbsd-nat.c: Revert.
 115         * arm-linux-tdep.c: Revert.
 116         * arm-linux-nat.c: Revert.
 117         * arm-fbsd-tdep.c: Revert.
 118         * arm-fbsd-nat.c: Revert.
 119         * arm-bsd-tdep.c: Revert.
 120         * arch-utils.c: Revert.
 121         * arc-tdep.c: Revert.
 122         * arc-newlib-tdep.c: Revert.
 123         * annotate.h: Revert.
 124         * annotate.c: Revert.
 125         * amd64-windows-tdep.c: Revert.
 126         * amd64-windows-nat.c: Revert.
 127         * amd64-tdep.c: Revert.
 128         * amd64-sol2-tdep.c: Revert.
 129         * amd64-obsd-tdep.c: Revert.
 130         * amd64-obsd-nat.c: Revert.
 131         * amd64-nbsd-tdep.c: Revert.
 132         * amd64-nbsd-nat.c: Revert.
 133         * amd64-nat.c: Revert.
 134         * amd64-linux-tdep.c: Revert.
 135         * amd64-linux-nat.c: Revert.
 136         * amd64-fbsd-tdep.c: Revert.
 137         * amd64-fbsd-nat.c: Revert.
 138         * amd64-dicos-tdep.c: Revert.
 139         * amd64-darwin-tdep.c: Revert.
 140         * amd64-bsd-nat.c: Revert.
 141         * alpha-tdep.c: Revert.
 142         * alpha-obsd-tdep.c: Revert.
 143         * alpha-nbsd-tdep.c: Revert.
 144         * alpha-mdebug-tdep.c: Revert.
 145         * alpha-linux-tdep.c: Revert.
 146         * alpha-linux-nat.c: Revert.
 147         * alpha-bsd-tdep.c: Revert.
 148         * alpha-bsd-nat.c: Revert.
 149         * aix-thread.c: Revert.
 150         * agent.c: Revert.
 151         * addrmap.c: Revert.
 152         * ada-varobj.c: Revert.
 153         * ada-valprint.c: Revert.
 154         * ada-typeprint.c: Revert.
 155         * ada-tasks.c: Revert.
 156         * ada-lang.c: Revert.
 157         * aarch64-tdep.c: Revert.
 158         * aarch64-ravenscar-thread.c: Revert.
 159         * aarch64-newlib-tdep.c: Revert.
 160         * aarch64-linux-tdep.c: Revert.
 161         * aarch64-linux-nat.c: Revert.
 162         * aarch64-fbsd-tdep.c: Revert.
 163         * aarch64-fbsd-nat.c: Revert.
 164         * aarch32-linux-nat.c: Revert.
 165
 166 2019-04-05  Tom Tromey  <tom@tromey.com>
 167
 168         * ft32-tdep.c: Sort headers.
 169         * frv-tdep.c: Sort headers.
 170         * frv-linux-tdep.c: Sort headers.
 171         * frame.c: Sort headers.
 172         * frame-unwind.c: Sort headers.
 173         * frame-base.c: Sort headers.
 174         * fork-child.c: Sort headers.
 175         * findvar.c: Sort headers.
 176         * findcmd.c: Sort headers.
 177         * filesystem.c: Sort headers.
 178         * filename-seen-cache.h: Sort headers.
 179         * filename-seen-cache.c: Sort headers.
 180         * fbsd-tdep.c: Sort headers.
 181         * fbsd-nat.h: Sort headers.
 182         * fbsd-nat.c: Sort headers.
 183         * f-valprint.c: Sort headers.
 184         * f-typeprint.c: Sort headers.
 185         * f-lang.c: Sort headers.
 186         * extension.h: Sort headers.
 187         * extension.c: Sort headers.
 188         * extension-priv.h: Sort headers.
 189         * expprint.c: Sort headers.
 190         * exec.h: Sort headers.
 191         * exec.c: Sort headers.
 192         * exceptions.c: Sort headers.
 193         * event-top.c: Sort headers.
 194         * event-loop.c: Sort headers.
 195         * eval.c: Sort headers.
 196         * elfread.c: Sort headers.
 197         * dwarf2read.h: Sort headers.
 198         * dwarf2read.c: Sort headers.
 199         * dwarf2loc.c: Sort headers.
 200         * dwarf2expr.h: Sort headers.
 201         * dwarf2expr.c: Sort headers.
 202         * dwarf2-frame.c: Sort headers.
 203         * dwarf2-frame-tailcall.c: Sort headers.
 204         * dwarf-index-write.h: Sort headers.
 205         * dwarf-index-write.c: Sort headers.
 206         * dwarf-index-common.c: Sort headers.
 207         * dwarf-index-cache.h: Sort headers.
 208         * dwarf-index-cache.c: Sort headers.
 209         * dummy-frame.c: Sort headers.
 210         * dtrace-probe.c: Sort headers.
 211         * disasm.h: Sort headers.
 212         * disasm.c: Sort headers.
 213         * disasm-selftests.c: Sort headers.
 214         * dictionary.c: Sort headers.
 215         * dicos-tdep.c: Sort headers.
 216         * demangle.c: Sort headers.
 217         * dcache.h: Sort headers.
 218         * dcache.c: Sort headers.
 219         * darwin-nat.h: Sort headers.
 220         * darwin-nat.c: Sort headers.
 221         * darwin-nat-info.c: Sort headers.
 222         * d-valprint.c: Sort headers.
 223         * d-namespace.c: Sort headers.
 224         * d-lang.c: Sort headers.
 225         * ctf.c: Sort headers.
 226         * csky-tdep.c: Sort headers.
 227         * csky-linux-tdep.c: Sort headers.
 228         * cris-tdep.c: Sort headers.
 229         * cris-linux-tdep.c: Sort headers.
 230         * cp-valprint.c: Sort headers.
 231         * cp-support.c: Sort headers.
 232         * cp-namespace.c: Sort headers.
 233         * cp-abi.c: Sort headers.
 234         * corelow.c: Sort headers.
 235         * corefile.c: Sort headers.
 236         * continuations.c: Sort headers.
 237         * completer.h: Sort headers.
 238         * completer.c: Sort headers.
 239         * complaints.c: Sort headers.
 240         * coffread.c: Sort headers.
 241         * coff-pe-read.c: Sort headers.
 242         * cli-out.h: Sort headers.
 243         * cli-out.c: Sort headers.
 244         * charset.c: Sort headers.
 245         * c-varobj.c: Sort headers.
 246         * c-valprint.c: Sort headers.
 247         * c-typeprint.c: Sort headers.
 248         * c-lang.c: Sort headers.
 249         * buildsym.c: Sort headers.
 250         * buildsym-legacy.c: Sort headers.
 251         * build-id.h: Sort headers.
 252         * build-id.c: Sort headers.
 253         * btrace.c: Sort headers.
 254         * bsd-uthread.c: Sort headers.
 255         * breakpoint.h: Sort headers.
 256         * breakpoint.c: Sort headers.
 257         * break-catch-throw.c: Sort headers.
 258         * break-catch-syscall.c: Sort headers.
 259         * break-catch-sig.c: Sort headers.
 260         * blockframe.c: Sort headers.
 261         * block.c: Sort headers.
 262         * bfin-tdep.c: Sort headers.
 263         * bfin-linux-tdep.c: Sort headers.
 264         * bfd-target.c: Sort headers.
 265         * bcache.c: Sort headers.
 266         * ax-general.c: Sort headers.
 267         * ax-gdb.h: Sort headers.
 268         * ax-gdb.c: Sort headers.
 269         * avr-tdep.c: Sort headers.
 270         * auxv.c: Sort headers.
 271         * auto-load.c: Sort headers.
 272         * arm-wince-tdep.c: Sort headers.
 273         * arm-tdep.c: Sort headers.
 274         * arm-symbian-tdep.c: Sort headers.
 275         * arm-pikeos-tdep.c: Sort headers.
 276         * arm-obsd-tdep.c: Sort headers.
 277         * arm-nbsd-tdep.c: Sort headers.
 278         * arm-nbsd-nat.c: Sort headers.
 279         * arm-linux-tdep.c: Sort headers.
 280         * arm-linux-nat.c: Sort headers.
 281         * arm-fbsd-tdep.c: Sort headers.
 282         * arm-fbsd-nat.c: Sort headers.
 283         * arm-bsd-tdep.c: Sort headers.
 284         * arch-utils.c: Sort headers.
 285         * arc-tdep.c: Sort headers.
 286         * arc-newlib-tdep.c: Sort headers.
 287         * annotate.h: Sort headers.
 288         * annotate.c: Sort headers.
 289         * amd64-windows-tdep.c: Sort headers.
 290         * amd64-windows-nat.c: Sort headers.
 291         * amd64-tdep.c: Sort headers.
 292         * amd64-sol2-tdep.c: Sort headers.
 293         * amd64-obsd-tdep.c: Sort headers.
 294         * amd64-obsd-nat.c: Sort headers.
 295         * amd64-nbsd-tdep.c: Sort headers.
 296         * amd64-nbsd-nat.c: Sort headers.
 297         * amd64-nat.c: Sort headers.
 298         * amd64-linux-tdep.c: Sort headers.
 299         * amd64-linux-nat.c: Sort headers.
 300         * amd64-fbsd-tdep.c: Sort headers.
 301         * amd64-fbsd-nat.c: Sort headers.
 302         * amd64-dicos-tdep.c: Sort headers.
 303         * amd64-darwin-tdep.c: Sort headers.
 304         * amd64-bsd-nat.c: Sort headers.
 305         * alpha-tdep.c: Sort headers.
 306         * alpha-obsd-tdep.c: Sort headers.
 307         * alpha-nbsd-tdep.c: Sort headers.
 308         * alpha-mdebug-tdep.c: Sort headers.
 309         * alpha-linux-tdep.c: Sort headers.
 310         * alpha-linux-nat.c: Sort headers.
 311         * alpha-bsd-tdep.c: Sort headers.
 312         * alpha-bsd-nat.c: Sort headers.
 313         * aix-thread.c: Sort headers.
 314         * agent.c: Sort headers.
 315         * addrmap.c: Sort headers.
 316         * ada-varobj.c: Sort headers.
 317         * ada-valprint.c: Sort headers.
 318         * ada-typeprint.c: Sort headers.
 319         * ada-tasks.c: Sort headers.
 320         * ada-lang.c: Sort headers.
 321         * aarch64-tdep.c: Sort headers.
 322         * aarch64-ravenscar-thread.c: Sort headers.
 323         * aarch64-newlib-tdep.c: Sort headers.
 324         * aarch64-linux-tdep.c: Sort headers.
 325         * aarch64-linux-nat.c: Sort headers.
 326         * aarch64-fbsd-tdep.c: Sort headers.
 327         * aarch64-fbsd-nat.c: Sort headers.
 328         * aarch32-linux-nat.c: Sort headers.
 329
 330 2019-04-04  Tom Tromey  <tom@tromey.com>
 331
 332         * varobj.c (varobj_create): Update.
 333         * rust-exp.y (struct rust_parser) <update_innermost_block,
 334         lookup_symbol>: New methods.
 335         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
 336         Rename.
 337         (rust_parser::rust_lookup_type)
 338         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
 339         * printcmd.c (display_command, do_one_display): Update.
 340         * parser-defs.h (struct parser_state) <parser_state>: Add
 341         "tracker" parameter.
 342         (block_tracker): New member.
 343         (class innermost_block_tracker) <innermost_block_tracker>: Add
 344         "types" parameter.
 345         <reset>: Remove method.
 346         (innermost_block): Don't declare.
 347         (null_post_parser): Update.
 348         * parse.c (innermost_block): Remove global.
 349         (write_dollar_variable): Update.
 350         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
 351         Remove "tracker_types" parameter.
 352         (parse_expression): Add "tracker" parameter.
 353         (parse_expression_for_completion): Update.
 354         (null_post_parser): Add "tracker" parameter.
 355         * p-exp.y: Update rules.
 356         * m2-exp.y: Update rules.
 357         * language.h (struct language_defn) <la_post_parser>: Add
 358         "tracker" parameter.
 359         * go-exp.y: Update rules.
 360         * f-exp.y: Update rules.
 361         * expression.h (parse_expression, parse_exp_1): Add "tracker"
 362         parameter.
 363         * d-exp.y: Update rules.
 364         * c-exp.y: Update rules.
 365         * breakpoint.c (set_breakpoint_condition): Create an
 366         innermost_block_tracker.
 367         (watch_command_1): Likewise.
 368         * ada-lang.c (resolve): Add "tracker" parameter.
 369         (resolve_subexp): Likewise.
 370         * ada-exp.y (write_var_from_sym): Update.
 371
 372 2019-04-04  Tom Tromey  <tom@tromey.com>
 373
 374         * type-stack.h: New file.
 375         * type-stack.c: New file.
 376         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
 377         type-stack.h.
 378         (insert_into_type_stack, insert_type, push_type, push_type_int)
 379         (insert_type_address_space, pop_type, pop_type_int)
 380         (pop_typelist, pop_type_stack, append_type_stack)
 381         (push_type_stack, get_type_stack, push_typelist)
 382         (follow_type_instance_flags, follow_types): Don't declare.
 383         * parse.c (type_stack): Remove global.
 384         (parse_exp_in_context): Update.
 385         (insert_into_type_stack, insert_type, push_type, push_type_int)
 386         (insert_type_address_space, pop_type, pop_type_int)
 387         (pop_typelist, pop_type_stack, append_type_stack)
 388         (push_type_stack, get_type_stack, push_typelist)
 389         (follow_type_instance_flags, follow_types): Remove (moved to
 390         type-stack.c).
 391         * f-exp.y (type_stack): New global.
 392         Update rules.
 393         (push_kind_type, f_parse): Update.
 394         * d-exp.y (type_stack): New global.
 395         Update rules.
 396         (d_parse): Update.
 397         * c-exp.y (struct c_parse_state) <type_stack>: New member.
 398         Update rules.
 399         * Makefile.in (COMMON_SFILES): Add type-stack.c.
 400         (HFILES_NO_SRCDIR): Add type-stack.h.
 401
 402 2019-04-04  Tom Tromey  <tom@tromey.com>
 403
 404         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
 405         (rust_parser::convert_ast_to_expression, rust_parse)
 406         (rust_lex_test_completion, rust_lex_tests): Update.
 407         * parser-defs.h (struct expr_completion_state): New.
 408         (struct parser_state) <parser_state>: Add completion parameter.
 409         <mark_struct_expression, mark_completion_tag>: New methods.
 410         <parse_completion, m_completion_state>: New members.
 411         (prefixify_expression, null_post_parser): Update.
 412         (mark_struct_expression, mark_completion_tag): Don't declare.
 413         * parse.c (parse_completion, expout_last_struct)
 414         (expout_tag_completion_type, expout_completion_name): Remove
 415         globals.
 416         (parser_state::mark_struct_expression)
 417         (parser_state::mark_completion_tag): Now methods.
 418         (prefixify_expression): Add last_struct parameter.
 419         (prefixify_subexp): Likewise.
 420         (parse_exp_1): Update.
 421         (parse_exp_in_context): Add cstate parameter.  Update.
 422         (parse_expression_for_completion): Create an
 423         expr_completion_state.
 424         (null_post_parser): Add "completion" parameter.
 425         * p-exp.y: Update rules.
 426         (yylex): Update.
 427         * language.h (struct language_defn) <la_post_parser>: Add
 428         "completing" parameter.
 429         * go-exp.y: Update rules.
 430         (lex_one_token): Update.
 431         * expression.h (parse_completion): Don't declare.
 432         * d-exp.y: Update rules.
 433         (lex_one_token): Update rules.
 434         * c-exp.y: Update rules.
 435         (lex_one_token): Update.
 436         * ada-lang.c (resolve): Add "parse_completion" parameter.
 437         (resolve_subexp): Likewise.
 438         (ada_resolve_function): Likewise.
 439
 440 2019-04-04  Tom Tromey  <tom@tromey.com>
 441
 442         * parser-defs.h (struct parser_state) <start_arglist,
 443         end_arglist>: New methods.
 444         <arglist_len, m_funcall_chain>: New members.
 445         (arglist_len, start_arglist, end_arglist): Don't declare.
 446         * parse.c (arglist_len, funcall_chain): Remove global.
 447         (start_arglist, end_arglist): Remove functions.
 448         (parse_exp_in_context): Update.
 449         * p-exp.y: Update rules.
 450         * m2-exp.y: Update rules.
 451         * go-exp.y: Update rules.
 452         * f-exp.y: Update rules.
 453         * d-exp.y: Update rules.
 454         * c-exp.y: Update rules.
 455
 456 2019-04-04  Tom Tromey  <tom@tromey.com>
 457
 458         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
 459         lex_operator, push_back>: New methods.
 460         Update all rules.
 461         (rust_parser::lex_hex, lex_escape): Rename and update.
 462         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
 463         (rust_parser::lex_operator): Rename and update.
 464         (rust_parser::lex_number, rustyylex, rustyyerror)
 465         (rust_lex_test_init, rust_lex_test_sequence)
 466         (rust_lex_test_push_back, rust_lex_tests): Update.
 467         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
 468         parameter.
 469         <lexptr, prev_lexptr>: New members.
 470         (lexptr, prev_lexptr): Don't declare.
 471         * parse.c (lexptr, prev_lexptr): Remove globals.
 472         (parse_exp_in_context): Update.
 473         * p-exp.y (yylex, yyerror): Update.
 474         * m2-exp.y (parse_number, yylex, yyerror): Update.
 475         * go-exp.y (lex_one_token, yyerror): Update.
 476         * f-exp.y (match_string_literal, yylex, yyerror): Update.
 477         * d-exp.y (lex_one_token, yyerror): Update.
 478         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
 479         (lex_one_token, yyerror): Update.
 480         * ada-lex.l (YY_INPUT): Update.
 481         (rewind_to_char): Update.
 482         * ada-exp.y (yyerror): Update.
 483
 484 2019-04-04  Tom Tromey  <tom@tromey.com>
 485
 486         * rust-exp.y (rustyylex, rust_lex_tests): Update.
 487         * parser-defs.h (struct parser_state) <parser_state>: Add new
 488         parameter.
 489         <comma_terminates>: New member.
 490         (comma_terminates): Don't declare global.
 491         * parse.c (comma_terminates): Remove global.
 492         (parse_exp_in_context): Update.
 493         * p-exp.y (yylex): Update.
 494         * m2-exp.y (yylex): Update.
 495         * go-exp.y (lex_one_token): Update.
 496         * f-exp.y (yylex): Update.
 497         * d-exp.y (lex_one_token): Update.
 498         * c-exp.y (lex_one_token): Update.
 499         * ada-lex.l: Update.
 500
 501 2019-04-04  Tom Tromey  <tom@tromey.com>
 502
 503         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
 504         (rustyylex, rust_lex_test_init, rust_lex_test_one)
 505         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
 506         * parser-defs.h (paren_depth): Don't declare.
 507         * parse.c (paren_depth): Remove global.
 508         (parse_exp_in_context): Update.
 509         * p-exp.y (paren_depth): New global.
 510         (pascal_parse): Initialize it.
 511         * m2-exp.y (paren_depth): New global.
 512         (m2_parse): Initialize it.
 513         * go-exp.y (paren_depth): New global.
 514         (go_parse): Initialize it.
 515         * f-exp.y (paren_depth): New global.
 516         (f_parse): Initialize it.
 517         * d-exp.y (paren_depth): New global.
 518         (d_parse): Initialize it.
 519         * c-exp.y (paren_depth): New global.
 520         (c_parse): Initialize it.
 521         * ada-lex.l (paren_depth): New global.
 522         (lexer_init): Initialize it.
 523
 524 2019-04-04  Tom Tromey  <tom@tromey.com>
 525
 526         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
 527         (rust_parser::convert_ast_to_type)
 528         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
 529         * parser-defs.h (struct parser_state) <parser_state>: Add
 530         parameters.  Initialize new members.
 531         <expression_context_block, expression_context_pc>: New members.
 532         * parse.c (expression_context_block, expression_context_pc):
 533         Remove globals.
 534         (parse_exp_in_context): Update.
 535         * p-exp.y: Update all rules.
 536         (yylex): Update.
 537         * m2-exp.y: Update all rules.
 538         (yylex): Update.
 539         * go-exp.y (yylex): Update.
 540         * f-exp.y (yylex): Update.
 541         * d-exp.y: Update all rules.
 542         (yylex): Update.
 543         * c-exp.y: Update all rules.
 544         (lex_one_token, classify_name, yylex, c_parse): Update.
 545         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
 546
 547 2019-04-04  Tom Tromey  <tom@tromey.com>
 548
 549         * gdbarch.h, gdbarch.c: Rebuild.
 550         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
 551         * stap-probe.h:
 552         (struct stap_parse_info): Replace "parser_state" with
 553         "expr_builder".
 554         * parser-defs.h (struct expr_builder): Rename from "parser_state".
 555         (parser_state): New class.
 556         * parse.c (expr_builder): Rename.
 557         (expr_builder::release): Rename.
 558         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
 559         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
 560         (write_exp_elt_longcst, write_exp_elt_floatcst)
 561         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
 562         (write_exp_string_vector, write_exp_bitstring)
 563         (write_exp_msymbol, mark_struct_expression)
 564         (write_dollar_variable)
 565         (insert_type_address_space, increase_expout_size): Replace
 566         "parser_state" with "expr_builder".
 567         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
 568         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
 569         "parser_state" with "expr_builder".
 570
 571 2019-04-04  Tom Tromey  <tom@tromey.com>
 572
 573         * rust-exp.y: Replace "parse_language" with method call.
 574         * p-exp.y:
 575         (yylex): Replace "parse_language" with method call.
 576         * m2-exp.y:
 577         (yylex): Replace "parse_language" with method call.
 578         * go-exp.y (classify_name): Replace "parse_language" with method
 579         call.
 580         * f-exp.y (yylex): Replace "parse_language" with method call.
 581         * d-exp.y (lex_one_token): Replace "parse_language" with method
 582         call.
 583         * c-exp.y:
 584         (lex_one_token, classify_name, yylex): Replace "parse_language"
 585         with method call.
 586         * ada-exp.y (find_primitive_type, type_char)
 587         (type_system_address): Replace "parse_language" with method call.
 588
 589 2019-04-04  Tom Tromey  <tom@tromey.com>
 590
 591         * rust-exp.y: Replace "parse_gdbarch" with method call.
 592         * parse.c (write_dollar_variable, insert_type_address_space):
 593         Replace "parse_gdbarch" with method call.
 594         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
 595         call.
 596         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
 597         call.
 598         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
 599         "parse_gdbarch" with method call.
 600         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
 601         with method call.
 602         * f-exp.y (parse_type, parse_f_type, yylex): Replace
 603         "parse_gdbarch" with method call.
 604         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
 605         "parse_gdbarch" with method call.
 606         * c-exp.y (parse_type, parse_number, classify_name): Replace
 607         "parse_gdbarch" with method call.
 608         * ada-lex.l: Replace "parse_gdbarch" with method call.
 609         * ada-exp.y (parse_type, find_primitive_type, type_char)
 610         (type_system_address): Replace "parse_gdbarch" with method call.
 611
 612 2019-04-04  Tom Tromey  <tom@tromey.com>
 613
 614         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
 615         * stap-probe.c (stap_parse_argument): Update.
 616         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
 617         initial_size parameter.
 618         * rust-exp.y (rust_lex_tests): Update.
 619         * parse.c (parser_state): Update.
 620         (parse_exp_in_context): Update.
 621         * parser-defs.h (struct parser_state) <parser_state>: Remove
 622         "initial_size" parameter.
 623
 624 2019-04-04  Tom Tromey  <tom@tromey.com>
 625
 626         * parser-defs.h (increase_expout_size): Don't declare.
 627         * parse.c (increase_expout_size): Now static.
 628
 629 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
 630
 631         * gnu-nat.c (gnu_nat_target::wait): Fix
 632         target_waitstatus_to_string call.
 633
 634 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 635
 636         * eval.c (evaluate_subexp_standard): Handle internal functions
 637         during Fortran function call handling.
 638
 639 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 640
 641         * NEWS: Mention new internal functions.
 642         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
 643         (read_base_type): Use dwarf2_init_complex_target_type.
 644         * value.c (creal_internal_fn): New function.
 645         (cimag_internal_fn): New function.
 646         (_initialize_values): Register new internal functions.
 647
 648 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 649
 650         * infrun.c (stop_all_threads): If debug_infrun, always
 651         trace the wait status after wait_one, using
 652         target_waitstatus_to_string and target_pid_to_str.
 653         (handle_inferior_event): Replace various trace of
 654         wait status kind by a single trace.
 655         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
 656         wait status kind image by target_waitstatus_to_string.
 657         * target/waitstatus.c (target_waitstatus_to_string): Fix
 658         obsolete comment.
 659
 660 2019-04-01  Tom Tromey  <tromey@adacore.com>
 661
 662         PR symtab/23331:
 663         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
 664
 665 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
 666             Pedro Alves  <palves@redhat.com>
 667
 668         * top.c (quit_force): Call 'finalize_values'.
 669         * value.c (finalize_values): New function.
 670         * value.h (finalize_values): Declare.
 671
 672 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
 673
 674         * NEWS: Announce $_gdb_major and $_gdb_minor.
 675
 676         * top.c (init_gdb_version_vars): New function.
 677         (gdb_init): Call init_gdb_version_vars.
 678
 679 2019-03-29  Tom Tromey  <tromey@adacore.com>
 680
 681         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
 682         help text.  Remove dead code.
 683
 684 2019-03-29  Keith Seitz  <keiths@redhat.com>
 685
 686         From Siddhesh Poyarekar:
 687         * f-lang.h (f77_get_upperbound): Return LONGEST.
 688         (f77_get_lowerbound): Likewise.
 689         * f-typeprint.c (f_type_print_varspec_suffix): Expand
 690         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
 691         print them.
 692         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
 693         plongest to format print it.
 694         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
 695         (f77_get_upperbound): Likewise.
 696         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
 697         LOWER_BOUND to LONGEST.
 698         (f77_create_arrayprint_offset_tbl): Likewise.
 699
 700 2019-03-29  Keith Seitz  <keiths@redhat.com>
 701
 702         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
 703         %s/pulongest for TYPE_LENGTH instead of %d in format
 704         strings.
 705         * ada-typerint.c (ada_print_type): Likewise.
 706         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
 707         * compile/compile-c-support.c (generate_register_struct): Likewise.
 708         * gdbtypes.c (recursive_dump_type): Likewise.
 709         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
 710         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
 711         instead of %d in format strings.
 712         * riscv-tdep.c (riscv_type_alignment): Cast second argument
 713         to std::min to ULONGEST.
 714         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
 715         instead of %d in format strings.
 716         * tracepoint.c (info_scope_command): Likewise.
 717         * typeprint.c (print_offset_data::update)
 718         (print_offset_data::finish): Likewise.
 719         * xtensa-tdep.c (xtensa_store_return_value)
 720         (xtensa_push_dummy_call): Likewise.
 721
 722 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
 723
 724         * windows-nat.c (display_selector): Fixed format specifications
 725         for 64-bit Cygwin.
 726
 727 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 728
 729         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
 730
 731 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
 732
 733         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
 734         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
 735         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
 736         (nios2_linux_init_abi): Install it.
 737
 738 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
 739
 740         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
 741
 742 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
 743
 744         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
 745
 746 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 747             Tom Tromey  <tromey@adacore.com>
 748
 749         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
 750
 751 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
 752
 753         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
 754         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
 755         method to compute the bounds of range types. Also print "[evaluated]"
 756         if the bounds' values come from a dynamic evaluation.
 757
 758 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
 759
 760         * cp-valprint.c (cp_print_value_fields): Don't print trailing
 761         whitespace when pretty printing is on.
 762
 763 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
 764
 765         * ppc-linux-nat.c: Add include.
 766
 767 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
 768
 769         * NEWS: Mention AArch64 Pointer Authentication.
 770
 771 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
 772
 773         * arm-linux-nat.c: Add include.
 774
 775 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
 776
 777         * source-cache.c (source_cache::get_source_lines): Re-read
 778         fullname after calling open_source_file.
 779
 780 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
 781
 782         * NEWS: Mention TLS support for FreeBSD.
 783
 784 2019-03-25  Tom Tromey  <tromey@adacore.com>
 785
 786         * minsyms.c (BUNCH_SIZE): Update comment.
 787         (~minimal_symbol_reader): Remove old comment.
 788         (compact_minimal_symbols): Update comment.
 789         (minimal_symbol_reader::install): Remove old comment.  Update
 790         other comments.
 791
 792 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
 793
 794         * s390-linux-nat.c: Add include.
 795
 796 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
 797
 798         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 799         Call linux_get_hwcap.
 800         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
 801         Likewise.
 802         (aarch64_linux_get_hwcap): Remove function.
 803         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
 804         declaration.
 805         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
 806         linux_get_hwcap.
 807         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 808         * linux-tdep.c (linux_get_hwcap): Add function.
 809         (linux_get_hwcap2): Likewise.
 810         * linux-tdep.h (linux_get_hwcap): Add declaration.
 811         (linux_get_hwcap2): Likewise.
 812         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
 813         (ppc_linux_get_hwcap2): Likewise.
 814         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
 815         linux_get_hwcap.
 816         (ppc_linux_nat_target::insert_watchpoint): Likewise.
 817         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
 818         (ppc_linux_nat_target::read_description): Likewise.
 819         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
 820         * s390-linux-nat.c: Likewise.
 821         * s390-linux-tdep.c (s390_core_read_description): Likewise.
 822
 823 2019-03-24  Tom Tromey  <tom@tromey.com>
 824
 825         * ada-lang.c (standard_lookup): Simplify initialization.
 826         (ada_lookup_symbol_nonlocal): Simplify return.
 827         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
 828         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
 829         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
 830         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
 831         initialization.
 832         * solib.c (solib_global_lookup): Simplify.
 833         * symtab.c (null_block_symbol): Remove.
 834         (symbol_cache_lookup): Simplify returns.
 835         (lookup_language_this): Simplify returns.
 836         (lookup_symbol_aux): Simplify return.
 837         (lookup_local_symbol): Simplify returns.
 838         (lookup_global_symbol_from_objfile): Simplify return.
 839         (lookup_symbol_in_objfile_symtabs)
 840         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
 841         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
 842         (lookup_static_symbol, lookup_global_symbol): Simplify return.
 843         * cp-namespace.c (cp_lookup_bare_symbol)
 844         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
 845         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
 846         (cp_lookup_nested_symbol): Don't use null_block_symbol.
 847         (cp_lookup_symbol_via_imports): Simplify initialization.
 848         (find_symbol_in_baseclass): Likewise.
 849         * symtab.h (null_block_symbol): Remove.
 850         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
 851         (d_lookup_nested_symbol, d_lookup_symbol_imports)
 852         (d_lookup_symbol_module): Likewise.
 853         (find_symbol_in_baseclass): Simplify initialization.
 854
 855 2019-03-24  Tom Tromey  <tom@tromey.com>
 856
 857         * expression.h: Don't include symtab.h.
 858         (struct block): Forward declare.
 859
 860 2019-03-24  Tom Tromey  <tom@tromey.com>
 861
 862         * c-exp.y (typebase): Remove casts.
 863         * gdbtypes.c (lookup_unsigned_typename, )
 864         (lookup_signed_typename): Remove cast.
 865         * eval.c (parse_to_comma_and_eval): Remove cast.
 866         * parse.c (write_dollar_variable): Remove cast.
 867         * block.h (struct block) <superblock>: Now const.
 868         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
 869         * psymtab.c (psym_map_matching_symbols): Make "block" const.
 870         (map_block): Make "block" const.
 871         * symfile.h (struct quick_symbol_functions)
 872         <map_matching_symbols>: Constify block argument to "callback".
 873         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
 874         const.
 875         (find_pc_sect_compunit_symtab): Make "b" const.
 876         (find_symbol_at_address): Likewise.
 877         (search_symbols): Likewise.
 878         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
 879         (dw2_debug_names_lookup_symbol): Likewise.
 880         (dw2_map_matching_symbols): Update.
 881         * p-valprint.c (pascal_val_print): Remove "block".
 882         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
 883         (aux_add_nonlocal_symbols): Make "block" const.
 884         (resolve_subexp): Remove cast.
 885         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
 886         const.
 887         (iterate_over_file_blocks): Likewise.
 888         * f-exp.y (%union) <bval>: Remove.
 889         * coffread.c (patch_opaque_types): Make "b" const.
 890         * spu-tdep.c (spu_catch_start): Make "block" const.
 891         * c-valprint.c (print_unpacked_pointer): Remove "block".
 892         * symmisc.c (dump_symtab_1): Make "b" const.
 893         (block_depth): Make "block" const.
 894         * d-exp.y (%union) <bval>: Remove.
 895         * cp-support.h (cp_lookup_rtti_type): Update.
 896         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
 897         * psymtab.c (psym_lookup_symbol): Make "block" const.
 898         (maintenance_check_psymtabs): Make "b" const.
 899         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
 900         (enumerate_locals, enumerate_args): Update.
 901         * python/py-symtab.c (stpy_global_block): Make "block" const.
 902         (stpy_static_block): Likewise.
 903         * inline-frame.c (block_starting_point_at): Make "new_block"
 904         const.
 905         * block.c (find_block_in_blockvector): Make return type const.
 906         (blockvector_for_pc_sect): Make "b" const.
 907         (find_block_in_blockvector): Make "b" const.
 908
 909 2019-03-23  Tom Tromey  <tom@tromey.com>
 910
 911         * varobj.c (varobj_create): Update.
 912         * symfile.c (clear_symtab_users): Don't reset innermost_block.
 913         * printcmd.c (display_command, do_one_display): Don't reset
 914         innermost_block.
 915         * parser-defs.h (enum innermost_block_tracker_type): Move to
 916         expression.h.
 917         (innermost_block): Update comment.
 918         * parse.c (parse_exp_1): Add tracker_types parameter.
 919         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
 920         tracker_types parameter.  Reset innermost_block.
 921         (parse_exp_in_context): Remove.
 922         (parse_expression_for_completion): Update.
 923         * objfiles.c (~objfile): Don't reset expression_context_block or
 924         innermost_block.
 925         * expression.h (enum innermost_block_tracker_type): Move from
 926         parser-defs.h.
 927         (parse_exp_1): Add tracker_types parameter.
 928         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
 929         reset innermost_block.
 930
 931 2019-03-23  Tom Tromey  <tom@tromey.com>
 932
 933         * objfiles.h: Include bcache.h.
 934
 935 2019-03-23  Tom Tromey  <tom@tromey.com>
 936
 937         * linespec.c (get_current_search_block): Use
 938         scoped_restore_current_language.
 939         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
 940
 941 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 942             Jiong Wang  <jiong.wang@arm.com>
 943
 944         * aarch64-linux-tdep.c
 945         (aarch64_linux_iterate_over_regset_sections): Check for pauth
 946         section.
 947         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
 948
 949 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 950             Jiong Wang  <jiong.wang@arm.com>
 951
 952         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
 953         instructions.
 954         (aarch64_analyze_prologue_test): Add PACIASP test.
 955         (aarch64_prologue_prev_register): Unmask PC value.
 956
 957 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 958             Jiong Wang  <jiong.wang@arm.com>
 959
 960         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
 961         (aarch64_dwarf2_prev_register): Unmask PC value.
 962         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
 963         (aarch64_execute_dwarf_cfa_vendor_op): Check for
 964         DW_CFA_AARCH64_negate_ra_state.
 965         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
 966
 967 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 968             Jiong Wang  <jiong.wang@arm.com>
 969
 970         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
 971         registers.
 972         (aarch64_pseudo_register_name): Likewise.
 973         (aarch64_pseudo_register_type): Likewise.
 974         (aarch64_pseudo_register_reggroup_p): Likewise.
 975         (aarch64_gdbarch_init): Add pauth registers.
 976         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
 977         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
 978         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
 979         (struct gdbarch_tdep): Add regnum for ra_state.
 980
 981 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 982             Jiong Wang  <jiong.wang@arm.com>
 983
 984         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
 985
 986 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 987             Jiong Wang  <jiong.wang@arm.com>
 988
 989         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
 990         function.
 991         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
 992         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
 993         (aarch64_gdbarch_init): Add puth registers.
 994         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
 995         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
 996         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
 997
 998 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 999             Jiong Wang  <jiong.wang@arm.com>
1000
1001         * aarch64-linux-nat.c
1002         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
1003         * aarch64-linux-tdep.c
1004         (aarch64_linux_core_read_description): Likewise.
1005         (aarch64_linux_get_hwcap): New function.
1006         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
1007         (aarch64_linux_get_hwcap): New declaration.
1008
1009 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1010             Jiong Wang  <jiong.wang@arm.com>
1011
1012         * aarch64-linux-nat.c
1013         (aarch64_linux_nat_target::read_description): Add pauth param.
1014         * aarch64-linux-tdep.c
1015         (aarch64_linux_core_read_description): Likewise.
1016         * aarch64-tdep.c (struct target_desc): Add in pauth.
1017         (aarch64_read_description): Add pauth param.
1018         (aarch64_gdbarch_init): Likewise.
1019         * aarch64-tdep.h (aarch64_read_description): Likewise.
1020         * arch/aarch64.c (aarch64_create_target_description): Likewise.
1021         * arch/aarch64.h (aarch64_create_target_description): Likewise.
1022         * features/Makefile: Add new files.
1023         * features/aarch64-pauth.c: New file.
1024         * features/aarch64-pauth.xml: New file.
1025
1026 2019-03-20  Tom Tromey  <tromey@adacore.com>
1027
1028         * infrun.c (handle_inferior_event): Rename from
1029         handle_inferior_event_1.  Create a scoped_value_mark.
1030         (handle_inferior_event): Remove.
1031
1032 2019-03-19  Tom Tromey  <tromey@adacore.com>
1033
1034         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
1035         * infrun.h (print_stop_event): Add "displays" parameter.
1036         * infrun.c (print_stop_event): Add "displays" parameter.
1037
1038 2019-03-19  Pedro Alves  <palves@redhat.com>
1039
1040         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
1041         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
1042         to -1.  Fix TABs vs spaces.
1043         (tui_ui_out::tui_ui_out): Don't initialize fields here.
1044         * tui/tui-out.h (tui_ui_out) Add intro comments.
1045         <m_line, m_start_of_line>: In-class initialize, and add describing
1046         comment.
1047
1048 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
1049
1050         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
1051         variable names.
1052         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
1053
1054 2019-03-18  Pedro Alves  <palves@redhat.com>
1055             Eli Zaretskii <eliz@gnu.org>
1056
1057         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
1058         m_line and m_start_of_line.
1059
1060 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
1061
1062         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
1063         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
1064         it returns a newline.  This fixes a regression in TU mode, whereby
1065         the next line is output on the same screen line as the user input.
1066
1067 2019-03-18  Tom Tromey  <tromey@adacore.com>
1068
1069         * minsyms.c (minimal_symbol_reader::install): Remove call to
1070         obstack_blank.
1071
1072 2019-03-18  Pedro Alves  <palves@redhat.com>
1073
1074         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
1075         New globals.
1076         (apply_style): New, factored out from ...
1077         (apply_ansi_escape): ... this.  Handle reverse video mode.
1078         (tui_set_reverse_mode): New function.
1079         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
1080         * tui/tui-winsource.c (tui_show_source_line): Use
1081         tui_set_reverse_mode instead of setting A_STANDOUT.
1082         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
1083         New setter methods.
1084
1085 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
1086
1087         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
1088         Handle tabs.
1089
1090 2019-03-18  Tom Tromey  <tromey@adacore.com>
1091
1092         * ada-lang.c (empty_array): Add "high" parameter.
1093         (ada_evaluate_subexp): Update.
1094
1095 2019-03-17  Sergei Trofimovich <siarheit@google.com>
1096
1097         * unittests/string_view-selftests.c: Define
1098         _initialize_string_view_selftests unconditionally.
1099
1100 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1101
1102         PR gdb/24350
1103         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
1104
1105 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1106
1107         PR gdb/24351
1108         * windows-nat.c (display_selector): Fix format specifiers.
1109
1110 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
1111
1112         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
1113         tui_refill_source_window instead of tui_refresh_win, to update the
1114         current execution line.  This fixes redisplay of the current line
1115         when stepping through the code with "next" or "step".
1116
1117 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1118
1119         * source-cache.c (source_cache::get_source_lines): Call
1120         find_source_lines to initialize s->nlines.  This fixes vertical
1121         scrolling of TUI source window when the DOWN arrow is pressed.
1122
1123 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1124
1125         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
1126         linux-thread-db.c (_initialize_thread_db): Likewise.
1127
1128 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1129
1130         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
1131         wclrtoeol in tui_show_source_line".  This reverts changes made in
1132         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
1133
1134 2019-03-15  Tom Tromey  <tom@tromey.com>
1135
1136         * symtab.h (struct minimal_symbol): Derive from
1137         general_symbol_info.
1138         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
1139         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
1140         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
1141         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
1142         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
1143         (MSYMBOL_SEARCH_NAME): Update.
1144         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
1145         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
1146         * minsyms.c (minimal_symbol_reader::record_full): Update.
1147
1148 2019-03-15  Tom Tromey  <tom@tromey.com>
1149
1150         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
1151
1152 2019-03-15  Tom Tromey  <tom@tromey.com>
1153
1154         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
1155         unique_xmalloc_ptr.
1156         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
1157         Update.
1158         * minsyms.c (lookup_minimal_symbol_by_pc_section)
1159         (build_minimal_symbol_hash_tables)
1160         (minimal_symbol_reader::install): Update.
1161
1162 2019-03-15  Tom Tromey  <tom@tromey.com>
1163
1164         * symtab.c (create_demangled_names_hash): Update.
1165         (symbol_set_names): Update.
1166         * objfiles.h (struct objfile_per_bfd_storage)
1167         <demangled_names_hash>: Now an htab_up.
1168         * objfiles.c (objfile_per_bfd_storage): Simplify.
1169
1170 2019-03-15  Tom Tromey  <tom@tromey.com>
1171
1172         * objfiles.h (struct objfile_per_bfd_storage): Declare
1173         destructor.
1174         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
1175         New.
1176         (get_objfile_bfd_data): Use new.  Don't initialize
1177         language_of_main.
1178         (free_objfile_per_bfd_storage): Remove.
1179         (objfile_bfd_data_free, objfile::~objfile): Use delete.
1180
1181 2019-03-15  Tom Tromey  <tom@tromey.com>
1182
1183         * symfile.c (reread_symbols): Update.
1184         * objfiles.c (objfile::objfile): Update.
1185         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
1186         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
1187         comment.
1188         (minimal_symbol_reader::install): Update.
1189         (terminate_minimal_symbol_table): Remove.
1190         * jit.c (jit_object_close_impl): Update.
1191
1192 2019-03-15  Tom Tromey  <tom@tromey.com>
1193
1194         * minsyms.c (minimal_symbol_reader::record_full): Remove some
1195         initializations.
1196
1197 2019-03-15  Tom Tromey  <tom@tromey.com>
1198
1199         * objfiles.h (struct objfile_per_bfd_storage)
1200         <demangled_hash_languages>: Now a bitset.
1201         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
1202         (lookup_minimal_symbol): Update.
1203
1204 2019-03-15  Tom Tromey  <tom@tromey.com>
1205
1206         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
1207         Don't return the symbol.
1208         * coffread.c (record_minimal_symbol): Use record_full.
1209
1210 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
1211
1212         The MS-Windows port of ncurses fails to switch to a color pair if
1213         one or both of the colors are the implicit default colors.  This
1214         change records the default colors when TUI is initialized, and
1215         then specifies them explicitly when a color pair uses the default
1216         colors.  This allows color styling in TUI mode on MS-Windows.
1217
1218         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
1219         ncurses_norm_attr.
1220         (tui_initialize_io) [__MINGW32__]: Record the default terminal
1221         colors in ncurses_norm_attr.
1222         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
1223         "none", replace it with the default color recorded in
1224         ncurses_norm_attr.
1225
1226 2019-03-14  Tom Tromey  <tromey@adacore.com>
1227
1228         * source-cache.h (class source_cache) <get_source_lines>: Return
1229         std::string.
1230         * source-cache.c (source_cache::extract_lines): Handle case where
1231         first_pos==npos.  Return std::string.
1232         (source_cache::get_source_lines): Update.
1233
1234 2019-03-14  Tom Tromey  <tromey@adacore.com>
1235
1236         * NEWS: Add item for "style sources" commands.
1237         * source-cache.c (source_cache::get_source_lines): Check
1238         source_styling.
1239         * cli/cli-style.c (source_styling): New global.
1240         (_initialize_cli_style): Add "style sources" commands.
1241         (show_style_sources): New function.
1242         * cli/cli-style.h (source_styling): Declare.
1243
1244 2019-03-14  Pedro Alves  <palves@redhat.com>
1245             Tom Tromey  <tromey@adacore.com>
1246
1247         * tui/tui-winsource.h (tui_refill_source_window): Declare.
1248         * tui/tui-winsource.c (tui_refill_source_window): New function,
1249         from...
1250         (tui_horizontal_source_scroll): ... here.  Move some logic.
1251         * cli/cli-style.c (set_style_enabled): Notify new observable.
1252         * tui/tui-hooks.c (tui_redisplay_source): New function.
1253         (tui_attach_detach_observers): Attach or detach
1254         tui_redisplay_source.
1255         * observable.h (source_styling_changed): New observable.
1256         * observable.c: Define source_styling_changed observable.
1257
1258 2019-03-13  Tom Tromey  <tromey@adacore.com>
1259
1260         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
1261         (i386_gnu_nat_target::store_registers): Update.
1262         * target-debug.h (target_debug_print_std_string): New macro.
1263         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1264         * windows-tdep.c (display_one_tib): Update.
1265         * tui/tui-stack.c (tui_make_status_line): Update.
1266         * top.c (print_inferior_quit_action): Update.
1267         * thread.c (thr_try_catch_cmd): Update.
1268         (add_thread_with_info): Update.
1269         (thread_target_id_str): Update.
1270         (thr_try_catch_cmd): Update.
1271         (thread_command): Update.
1272         (thread_find_command): Update.
1273         * record-btrace.c (record_btrace_target::info_record)
1274         (record_btrace_resume_thread, record_btrace_target::resume)
1275         (record_btrace_cancel_resume, record_btrace_step_thread)
1276         (record_btrace_target::wait, record_btrace_target::wait)
1277         (record_btrace_target::wait, record_btrace_target::stop): Update.
1278         * progspace.c (print_program_space): Update.
1279         * process-stratum-target.c
1280         (process_stratum_target::thread_address_space): Update.
1281         * linux-fork.c (linux_fork_mourn_inferior)
1282         (detach_checkpoint_command, info_checkpoints_command)
1283         (linux_fork_context): Update.
1284         (linux_fork_detach): Update.
1285         (class scoped_switch_fork_info): Update.
1286         (delete_checkpoint_command): Update.
1287         * infrun.c (follow_fork_inferior): Update.
1288         (follow_fork_inferior): Update.
1289         (proceed_after_vfork_done): Update.
1290         (handle_vfork_child_exec_or_exit): Update.
1291         (follow_exec): Update.
1292         (displaced_step_prepare_throw): Update.
1293         (displaced_step_restore): Update.
1294         (start_step_over): Update.
1295         (resume_1): Update.
1296         (clear_proceed_status_thread): Update.
1297         (proceed): Update.
1298         (print_target_wait_results): Update.
1299         (do_target_wait): Update.
1300         (context_switch): Update.
1301         (stop_all_threads): Update.
1302         (restart_threads): Update.
1303         (finish_step_over): Update.
1304         (handle_signal_stop): Update.
1305         (switch_back_to_stepped_thread): Update.
1306         (keep_going_pass_signal): Update.
1307         (print_exited_reason): Update.
1308         (normal_stop): Update.
1309         * inferior.c (inferior_pid_to_str): Change return type.
1310         (print_selected_inferior): Update.
1311         (add_inferior): Update.
1312         (detach_inferior): Update.
1313         * dummy-frame.c (fprint_dummy_frames): Update.
1314         * dcache.c (dcache_info_1): Update.
1315         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
1316         (btrace_fetch, btrace_clear): Update.
1317         * linux-tdep.c (linux_core_pid_to_str): Change return type.
1318         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
1319         type.
1320         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
1321         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
1322         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
1323         * gdbarch.c, gdbarch.h: Rebuild.
1324         * gdbarch.sh (core_pid_to_str): Change return type.
1325         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
1326         return type.
1327         (windows_nat_target::pid_to_str): Change return type.
1328         (windows_delete_thread): Update.
1329         (windows_nat_target::attach): Update.
1330         (windows_nat_target::files_info): Update.
1331         * target-delegates.c: Rebuild.
1332         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
1333         return type.
1334         (sol_thread_target::pid_to_str): Change return type.
1335         * remote.c (class remote_target) <pid_to_str>: Change return
1336         type.
1337         (remote_target::pid_to_str): Change return type.
1338         (extended_remote_target::attach, remote_target::remote_stop_ns)
1339         (remote_target::remote_notif_remove_queued_reply)
1340         (remote_target::push_stop_reply, remote_target::disable_btrace):
1341         Update.
1342         (extended_remote_target::attach): Update.
1343         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
1344         type.
1345         (gdbsim_target::pid_to_str): Change return type.
1346         * ravenscar-thread.c (struct ravenscar_thread_target)
1347         <pid_to_str>: Change return type.
1348         (ravenscar_thread_target::pid_to_str): Change return type.
1349         * procfs.c (class procfs_target) <pid_to_str>: Change return
1350         type.
1351         (procfs_target::pid_to_str): Change return type.
1352         (procfs_target::attach): Update.
1353         (procfs_target::detach): Update.
1354         (procfs_target::fetch_registers): Update.
1355         (procfs_target::store_registers): Update.
1356         (procfs_target::wait): Update.
1357         (procfs_target::files_info): Update.
1358         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
1359         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
1360         return type.
1361         (nto_procfs_target::pid_to_str): Change return type.
1362         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
1363         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
1364         return type.
1365         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
1366         (exit_lwp): Update.
1367         (attach_proc_task_lwp_callback, get_detach_signal)
1368         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
1369         (linux_nat_target::resume, wait_lwp, stop_callback)
1370         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
1371         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
1372         (linux_nat_wait_1, resume_stopped_resumed_lwps)
1373         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
1374         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
1375         type.
1376         (inf_ptrace_target::attach): Update.
1377         (inf_ptrace_target::files_info): Update.
1378         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
1379         type.
1380         (go32_nat_target::pid_to_str): Change return type.
1381         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
1382         (gnu_nat_target::wait): Update.
1383         (gnu_nat_target::wait): Update.
1384         (gnu_nat_target::resume): Update.
1385         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
1386         (fbsd_nat_target::wait): Update.
1387         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
1388         type.
1389         (darwin_nat_target::attach): Update.
1390         * corelow.c (class core_target) <pid_to_str>: Change return type.
1391         (core_target::pid_to_str): Change return type.
1392         * target.c (normal_pid_to_str): Change return type.
1393         (default_pid_to_str): Likewise.
1394         (target_pid_to_str): Change return type.
1395         (target_translate_tls_address): Update.
1396         (target_announce_detach): Update.
1397         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
1398         return type.
1399         (bsd_uthread_target::pid_to_str): Change return type.
1400         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
1401         type.
1402         (bsd_kvm_target::pid_to_str): Change return type.
1403         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
1404         return type.
1405         (aix_thread_target::pid_to_str): Change return type.
1406         * target.h (struct target_ops) <pid_to_str>: Change return type.
1407         (target_pid_to_str, normal_pid_to_str): Likewise.
1408         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
1409         type.
1410         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
1411         type.
1412         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
1413         return type.
1414         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
1415         type.
1416         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
1417         type.
1418         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
1419         return type.
1420
1421 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
1422
1423         * NEWS: Mention that the new default MI version is 3.  Mention
1424         changes to the output of commands and events that deal with
1425         multi-location breakpoints.
1426         * breakpoint.c: Include "mi/mi-out.h".
1427         (print_one_breakpoint): Change output syntax if using MI version
1428         >= 3.
1429         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
1430         New.
1431         (mi_multi_location_breakpoint_output_fixed): New.
1432         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
1433         (mi_cmd_fix_multi_location_breakpoint_output): New.
1434         (mi_multi_location_breakpoint_output_fixed): New.
1435         * mi/mi-cmds.c (mi_cmds): Register command
1436         -fix-multi-location-breakpoint-output.
1437         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
1438         interpreter "mi".
1439
1440 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
1441
1442         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
1443         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
1444         instantiate mi_ui_out based on interpreter name.
1445         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
1446         * mi/mi-main.c (mi_load_progress): Likewise.
1447
1448 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1449
1450         * NEWS: Combine separate "New targets" sections for 8.3.
1451
1452 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1453
1454         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
1455         (ppcfbsd_init_abi): Install gdbarch
1456         "fetch_tls_load_module_address" and "get_thread_local_address"
1457         methods.
1458
1459 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1460
1461         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
1462         (riscv_fbsd_init_abi): Install gdbarch
1463         "fetch_tls_load_module_address" and "get_thread_local_address"
1464         methods.
1465
1466 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1467
1468         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
1469         (i386fbsd_init_abi): Install gdbarch
1470         "fetch_tls_load_module_address" and "get_thread_local_address"
1471         methods.
1472
1473 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1474
1475         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
1476         (amd64fbsd_init_abi): Install gdbarch
1477         "fetch_tls_load_module_address" and "get_thread_local_address"
1478         methods.
1479
1480 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1481
1482         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
1483         (struct fbsd_pspace_data): New type.
1484         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
1485         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
1486         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
1487         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
1488         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
1489
1490 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1491
1492         * gdbtypes.c (lookup_struct_elt): New function.
1493         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
1494         * gdbtypes.h (struct struct_elt): New type.
1495         (lookup_struct_elt): New prototype.
1496
1497 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1498
1499         * gdbtypes.c (lookup_struct_elt_type): Update comment and
1500         remove disabled code block.
1501
1502 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1503
1504         * gdbarch.sh (get_thread_local_address): New method.
1505         * gdbarch.h, gdbarch.c: Regenerate.
1506         * target.c (target_translate_tls_address): Use
1507         gdbarch_get_thread_local_address if present instead of
1508         target::get_thread_local_address.
1509
1510 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1511
1512         * target.h (target::get_thread_local_address): Update comment.
1513
1514 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1515
1516         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
1517         objfile->separate_debug_objfile_backlink if not NULL.
1518
1519 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1520
1521         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
1522         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
1523         (amd64bsd_store_inferior_registers): Likewise.
1524         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
1525         Enable segment base registers.
1526         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
1527         PT_GETFSBASE and PT_GETGSBASE.
1528         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
1529         PT_SETGSBASE.
1530         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
1531         segment base registers.
1532         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
1533
1534 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1535
1536         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
1537         Update calls to i386_target_description to add 'segments'
1538         parameter.
1539         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
1540         add segment base registers.
1541         * arch/i386.c (i386_create_target_description): Add 'segments'
1542         parameter to enable segment base registers.
1543         * arch/i386.h (i386_create_target_description): Likewise.
1544         * features/i386/32bit-segments.xml: New file.
1545         * features/i386/32bit-segments.c: Generate.
1546         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
1547         call to i386_target_description to add 'segments' parameter.
1548         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
1549         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
1550         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
1551         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
1552         if feature is present.
1553         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
1554         Add 'segments' parameter to call to i386_target_description.
1555         (i386_target_description): Add 'segments' parameter to enable
1556         segment base registers.
1557         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
1558         to call to i386_target_description.
1559         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
1560         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
1561         Define I386_NUM_REGS.
1562         (i386_target_description): Add 'segments' parameter to enable
1563         segment base registers.
1564
1565 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
1566
1567         PR/24325
1568         * source-cache.c: #undef open and close, to avoid unresolved
1569         externals during linking.
1570
1571 2019-03-12  Tom Tromey  <tromey@adacore.com>
1572
1573         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
1574         const.  Add initializers.
1575         (_initialize_remote): Don't initialize ptid globals.
1576
1577 2019-03-12  Pedro Alves  <palves@redhat.com>
1578
1579         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
1580
1581 2019-03-12  Pedro Alves  <palves@redhat.com>
1582
1583         * cp-name-parser.y (main): Remove unused 'len' variable.
1584
1585 2019-03-12  Tom Tromey  <tromey@adacore.com>
1586
1587         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
1588         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
1589
1590 2019-03-12  Tom Tromey  <tromey@adacore.com>
1591
1592         * linux-nat.c (iterate_over_lwps): Update.
1593         (stop_callback): Remove parameter.
1594         (stop_wait_callback, detach_callback, resume_set_callback)
1595         (select_singlestep_lwp_callback, set_ignore_sigint)
1596         (status_callback, resumed_callback, resume_clear_callback)
1597         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
1598         data parameter.
1599         (linux_nat_target::detach, linux_nat_target::resume)
1600         (linux_stop_and_wait_all_lwps, select_event_lwp)
1601         (linux_nat_filter_event, linux_nat_wait_1)
1602         (linux_nat_target::kill, linux_nat_target::stop)
1603         (linux_nat_target::stop): Update.
1604         (linux_nat_resume_callback): Change type.
1605         (resume_stopped_resumed_lwps, count_events_callback)
1606         (select_event_lwp_callback): Likewise.
1607         (linux_stop_lwp, linux_nat_stop_lwp): Update.
1608         * arm-linux-nat.c (struct update_registers_data): Remove.
1609         (update_registers_callback): Change type.
1610         (arm_linux_insert_hw_breakpoint1): Update.
1611         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
1612         parameter.
1613         (x86_linux_dr_set_addr): Update.
1614         (x86_linux_dr_set_control): Update.
1615         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
1616         (iterate_over_lwps): Use gdb::function_view.
1617         * nat/aarch64-linux-hw-point.c (struct
1618         aarch64_dr_update_callback_param): Remove.
1619         (debug_reg_change_callback): Change type.
1620         (aarch64_notify_debug_reg_change): Update.
1621         * s390-linux-nat.c (s390_refresh_per_info): Update.
1622
1623 2019-03-11  Tom Tromey  <tromey@adacore.com>
1624
1625         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
1626         redundant assignment to "this_cu".
1627
1628 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1629
1630         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
1631
1632 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1633
1634         * gdbtypes.c (rank_one_type_parm_set): New function extracted
1635         from...
1636         (rank_one_type): ... this.
1637
1638 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1639
1640         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
1641         from...
1642         (rank_one_type): ... this.
1643
1644 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1645
1646         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
1647         from...
1648         (rank_one_type): ... this.
1649
1650 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1651
1652         * gdbtypes.c (rank_one_type_parm_float): New function extracted
1653         from...
1654         (rank_one_type): ... this.
1655
1656 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1657
1658         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
1659         from...
1660         (rank_one_type): ... this.
1661
1662 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1663
1664         * gdbtypes.c (rank_one_type_parm_range): New function extracted
1665         from...
1666         (rank_one_type): ... this.
1667
1668 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1669
1670         * gdbtypes.c (rank_one_type_parm_char): New function extracted
1671         from...
1672         (rank_one_type): ... this.
1673
1674 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1675
1676         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
1677         from...
1678         (rank_one_type): ... this.
1679
1680 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1681
1682         * gdbtypes.c (rank_one_type_parm_int): New function extracted
1683         from...
1684         (rank_one_type): ... this.
1685
1686 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1687
1688         * gdbtypes.c (rank_one_type_parm_func): New function extracted
1689         from...
1690         (rank_one_type): ... this.
1691
1692 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1693
1694         * gdbtypes.c (rank_one_type_parm_array): New function extracted
1695         from...
1696         (rank_one_type): ... this.
1697
1698 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1699
1700         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
1701         from...
1702         (rank_one_type): ... this.
1703
1704 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1705
1706         * inferior.c (initialize_inferiors): Ensure 'help set/show print
1707         inferior-events' shows the example events.
1708
1709 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
1710
1711         Support styling on native MS-Windows console
1712
1713         PR/24315
1714         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
1715         on MS-Windows if $TERM is not defined.
1716
1717         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
1718
1719         * posix-hdep.c (gdb_console_fputs):
1720         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
1721         functions.
1722         * ui-file.h (gdb_console_fputs): Add prototype.
1723
1724         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
1725         back to fputs only if the former returns zero.
1726
1727 2019-03-07  Tom Tromey  <tom@tromey.com>
1728
1729         * symmisc.c (print_symbol_bcache_statistics): Update.
1730         (print_objfile_statistics): Update.
1731         * symfile.c (allocate_symtab): Update.
1732         * stabsread.c: Don't include bcache.h.
1733         * psymtab.h (struct psymbol_bcache): Don't declare.
1734         (class psymtab_storage) <psymbol_cache>: Now a bcache.
1735         (psymbol_bcache_init, psymbol_bcache_free)
1736         (psymbol_bcache_get_bcache): Don't declare.
1737         * psymtab.c (struct psymbol_bcache): Remove.
1738         (psymtab_storage::psymtab_storage): Update.
1739         (psymtab_storage::~psymtab_storage): Update.
1740         (psymbol_bcache_init, psymbol_bcache_free)
1741         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
1742         (add_psymbol_to_bcache): Update.
1743         (allocate_psymtab): Update.
1744         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
1745         macro_cache>: No longer pointers.
1746         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
1747         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
1748         * macrotab.c (macro_bcache): Update.
1749         * macroexp.c: Don't include bcache.h.
1750         * gdbtypes.c (check_types_worklist): Update.
1751         (types_deeply_equal): Remove TRY/CATCH.  Update.
1752         * elfread.c (elf_symtab_read): Update.
1753         * dwarf2read.c: Don't include bcache.h.
1754         * buildsym.c (buildsym_compunit::get_macro_table): Update.
1755         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
1756         (print_bcache_statistics, bcache_memory_used): Don't declare.
1757         (struct bcache): Move from bcache.c.  Add constructor, destructor,
1758         methods.  Rename all data members.
1759         * bcache.c (struct bcache): Move to bcache.h.
1760         (bcache::expand_hash_table): Rename from expand_hash_table.
1761         (bcache): Remove.
1762         (bcache::insert): Rename from bcache_full.
1763         (bcache::compare): Rename from bcache_compare.
1764         (bcache_xmalloc): Remove.
1765         (bcache::~bcache): Rename from bcache_xfree.
1766         (bcache::print_statistics): Rename from print_bcache_statistics.
1767         (bcache::memory_used): Rename from bcache_memory_used.
1768
1769 2019-03-07  Pedro Alves  <palves@redhat.com>
1770
1771         * infrun.c (normal_stop): Also check for
1772         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
1773
1774 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
1775
1776         * f-lang.c (value_from_host_double): Moved to...
1777         * value.c (value_from_host_double): ...here.
1778         * value.h (value_from_host_double): Declare.
1779         * guile/scm-math.c (vlscm_convert_typed_number): Use
1780         value_from_host_double.
1781         (vlscm_convert_number): Likewise.
1782         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
1783         * python/py-value.c (convert_value_from_python): Likewise.
1784
1785 2019-03-06  Tom Tromey  <tom@tromey.com>
1786
1787         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
1788
1789 2019-03-06  Tom Tromey  <tom@tromey.com>
1790
1791         * utils.h (free_current_contents): Don't declare.
1792         * utils.c (free_current_contents): Remove.
1793
1794 2019-03-06  Tom Tromey  <tom@tromey.com>
1795
1796         * top.c (quit_force): Update.
1797         * main.c (captured_command_loop): Update.
1798         * common/new-op.c (operator new): Update.
1799         * common/common-exceptions.c (struct catcher)
1800         <save_cleanup_chain>: Remove member.
1801         (exceptions_state_mc_init): Update.
1802         (exception_try_scope_entry): Return nullptr.
1803         (exception_try_scope_exit, exception_rethrow)
1804         (throw_exception_sjlj, throw_exception_cxx): Update.
1805         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
1806         (all_cleanups, do_cleanups, discard_cleanups)
1807         (discard_final_cleanups, save_cleanups, save_final_cleanups)
1808         (restore_cleanups, restore_final_cleanups): Don't declare.
1809         (do_final_cleanups): Remove parameter.
1810         * common/cleanups.c (cleanup_chain, make_cleanup)
1811         (make_cleanup_dtor, all_cleanups, do_cleanups)
1812         (discard_my_cleanups, discard_cleanups)
1813         (discard_final_cleanups, save_my_cleanups, save_cleanups)
1814         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
1815         (null_cleanup): Remove.
1816         (do_final_cleanups): Remove parameter.
1817
1818 2019-03-06  Tom Tromey  <tom@tromey.com>
1819
1820         * remote.c (remote_target::remote_parse_stop_reply): Use
1821         unique_xmalloc_ptr.
1822
1823 2019-03-06  Tom Tromey  <tom@tromey.com>
1824
1825         * stabsread.c (struct stabs_field_info): Rename from field_info.
1826         <list, fnlist>: Add initializers.
1827         <obstack>: New member.
1828         (read_member_functions, read_struct_fields, read_baseclasses):
1829         Allocate on obstack.  Don't use cleanups.
1830         (read_one_struct_field, read_member_functions, read_struct_fields)
1831         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
1832         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
1833         (read_struct_type): Update.
1834
1835 2019-03-06  Tom Tromey  <tom@tromey.com>
1836
1837         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
1838         * common/filestuff.h (make_cleanup_close): Don't declare.
1839         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
1840         Remove.
1841
1842 2019-03-06  Tom Tromey  <tom@tromey.com>
1843
1844         * solib-aix.c: Use make_scope_exit.
1845
1846 2019-03-06  Tom Tromey  <tom@tromey.com>
1847
1848         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
1849         Use make_scope_exit.
1850
1851 2019-03-06  Tom Tromey  <tom@tromey.com>
1852
1853         * solib-svr4.c (disable_probes_interface): Remove parameter.
1854         (svr4_handle_solib_event): Use make_scope_exit.
1855
1856 2019-03-06  Tom Tromey  <tom@tromey.com>
1857
1858         * remote.c (struct stop_reply_deleter): Remove.
1859         (stop_reply_up): Update.
1860         (struct stop_reply): Derive from notif_event.  Don't typedef.
1861         <regcache>: Now a std::vector.
1862         (stop_reply_xfree): Remove.
1863         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
1864         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
1865         (remote_target::discard_pending_stop_replies): Use delete.
1866         (remote_target::remote_parse_stop_reply): Update.
1867         (remote_target::process_stop_reply): Update.
1868         * remote-notif.h (struct notif_event): Add virtual destructor.
1869         Remove "dtr" member.
1870         (struct notif_client) <alloc_event>: Return a unique_ptr.
1871         (notif_event_xfree): Don't declare.
1872         (notif_event_up): New typedef.
1873         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
1874         (notif_event_xfree, do_notif_event_xfree): Remove.
1875         (remote_notif_state_xfree): Update.
1876
1877 2019-03-06  Tom Tromey  <tom@tromey.com>
1878
1879         * infrun.c (displaced_step_clear_cleanup): Now a
1880         forward_scope_exit type.
1881         (displaced_step_prepare_throw): Update.
1882         (displaced_step_fixup): Update.
1883
1884 2019-03-06  Tom Tromey  <tom@tromey.com>
1885
1886         * inferior.h (class inferior): Update comment.
1887         * gdbthread.h (class thread_info): Update comment.
1888
1889 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
1890             Tom Tromey  <tom@tromey.com>
1891
1892         * stabsread.h (struct stab_section_list): Remove.
1893         (coffstab_build_psymtabs): Update.
1894         * dbxread.c (symbuf_sections): Now a std::vector.
1895         (sect_idx): New global.
1896         (fill_symbuf): Update.
1897         (coffstab_build_psymtabs): Change type of stabsects parameter.
1898         Update.
1899         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
1900         std::vector.
1901         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
1902         (coff_locate_sections): Update.
1903         (coff_symfile_read): Remove cleanups.  Update.
1904         (init_stringtab): Add storage parameter.
1905         (free_stringtab, free_stringtab_cleanup): Remove.
1906         (init_lineno): Add storage parameter.
1907         (free_linetab, free_linetab_cleanup): Remove.
1908
1909 2019-03-06  Pedro Alves  <palves@redhat.com>
1910
1911         * linux-fork.c (fork_info::clobber_regs): Delete.
1912         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
1913         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
1914         comment.  Adjust.
1915         (scoped_switch_fork_info::scoped_switch_fork_info)
1916         (checkpoint_command, linux_fork_context): Adjust
1917         fork_save_infrun_state calls.
1918
1919 2019-03-06  Pedro Alves  <palves@redhat.com>
1920
1921         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
1922         (inf_has_multiple_threads): Return 'bool' and rewrite using
1923         inferior_info::threads().
1924
1925 2019-03-06  Pedro Alves  <palves@redhat.com>
1926
1927         * linux-fork.c: Include <list>.
1928         (fork_list): Now a std::list instance.
1929         (fork_info): Add ctor, dtor, and in-class initialize all fields.
1930         (forks_exist_p, find_last_fork): Adjust.
1931         (new_fork): Delete.
1932         (one_fork_p): New.
1933         (add_fork): Adjust.
1934         (free_fork): Delete, folded into fork_info::~fork_info().
1935         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
1936         Adjust.
1937         (init_fork_list): Delete.
1938         (linux_fork_killall, linux_fork_mourn_inferior)
1939         (linux_fork_detach, info_checkpoints_command): Adjust.
1940         (_initialize_linux_fork): No longer call init_fork_list.
1941
1942 2019-03-06  Pedro Alves  <palves@redhat.com>
1943
1944         * linux-fork.c (new_fork): New, split out of ...
1945         (add_fork): ... this.  Return void.  Move "first fork" special
1946         case from here, to ...
1947         (checkpoint_command): ... here.
1948         * linux-linux.h (add_fork): Return void.
1949
1950 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1951
1952         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
1953
1954 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1955             Chris January  <chris.january@arm.com>
1956             David Lecomber  <david.lecomber@arm.com>
1957
1958         * f-exp.y: New token, UNOP_INTRINSIC.
1959         (exp): New pattern using UNOP_INTRINSIC token.
1960         (f77_keywords): Add 'abs' keyword.
1961         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
1962         (value_from_host_double): New function.
1963         (evaluate_subexp_f): Support UNOP_ABS.
1964
1965 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1966
1967         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
1968         types.
1969
1970 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1971
1972         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
1973         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
1974         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
1975
1976 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1977
1978         * f-exp.y (convert_to_kind_type): Handle more type kinds.
1979
1980 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1981             Chris January  <chris.january@arm.com>
1982
1983         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
1984         * f-exp.y: Define 'KIND' token.
1985         (exp): New pattern for KIND expressions.
1986         (ptype): Handle types with a kind extension.
1987         (direct_abs_decl): Extend to spot kind extensions.
1988         (f77_keywords): Add 'kind' to the list.
1989         (push_kind_type): New function.
1990         (convert_to_kind_type): New function.
1991         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
1992         * parse.c (operator_length_standard): Likewise.
1993         * parser-defs.h (enum type_pieces): Add tp_kind.
1994         * std-operator.def: Add UNOP_KIND.
1995
1996 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1997
1998         * f-exp.y (f_parse): Set yydebug.
1999
2000 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2001
2002         * f-lang.c (evaluate_subexp_f): New function.
2003         (exp_descriptor_f): New global.
2004         (f_language_defn): Use exp_descriptor_f instead of
2005         exp_descriptor_standard.
2006
2007 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2008
2009         * f-exp.y (struct token): Add comments.
2010         (dot_ops): Remove uppercase versions and the end marker.
2011         (f77_keywords): Likewise.
2012         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
2013         entries in the dot_ops array are case insensitive, and use
2014         strncasecmp to compare strings.  Also some whitespace cleanup in
2015         this area.  Similar for the f77_keywords array, except entries in
2016         this list might be case sensitive.
2017
2018 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2019
2020         * f-exp.y (struct f77_boolean_val): Add comments.
2021         (boolean_values): Remove uppercase versions, and end marker.
2022         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
2023         and use strncasecmp to achieve case insensitivity.  Additionally,
2024         perform whitespace cleanup around this code.
2025
2026 2019-03-06  Tom Tromey  <tromey@adacore.com>
2027
2028         * remote-sim.c (gdbsim_target_open): Use result of
2029         gdb_argv::release.
2030
2031 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
2032         Dirk Schubert  <dirk.schubert@arm.com>
2033         Chris January  <chris.january@arm.com>
2034
2035         * eval.c (evaluate_subexp_standard): Call Fortran argument
2036         wrapping logic.
2037         * f-lang.c (struct value): A value which can be passed into a
2038         Fortran function call.
2039         (fortran_argument_convert): Wrap Fortran arguments in a pointer
2040         where appropriate.
2041         (struct type): Value ready for a Fortran function call.
2042         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
2043         is needed.
2044         * f-lang.h (fortran_argument_convert): Declaration.
2045         (fortran_preserve_arg_pointer): Declaration.
2046         * infcall.c (value_arg_coerce): Call Fortran argument logic.
2047
2048 2019-03-05  Tom Tromey  <tromey@adacore.com>
2049
2050         * python/py-prettyprint.c (print_string_repr): Remove #if.
2051         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
2052
2053 2019-03-05  Tom Tromey  <tromey@adacore.com>
2054
2055         * target.c (the_dummy_target): Move later.  Change type to
2056         "dummy_target".
2057         (initialize_targets): Don't initialize the_dummy_target.
2058
2059 2019-03-05  Tom Tromey  <tromey@adacore.com>
2060
2061         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
2062         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
2063
2064 2019-03-05  Tom Tromey  <tromey@adacore.com>
2065
2066         * windows-nat.c (windows_nat_target::attach)
2067         (windows_nat_target::detach): Don't call gdb_flush.
2068         * valprint.c (generic_val_print, val_print, val_print_string):
2069         Don't call gdb_flush.
2070         * utils.c (defaulted_query): Don't call gdb_flush.
2071         * typeprint.c (print_type_scalar): Don't call gdb_flush.
2072         * target.c (target_announce_detach): Don't call gdb_flush.
2073         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
2074         * remote.c (extended_remote_target::attach): Don't call
2075         gdb_flush.
2076         * procfs.c (procfs_target::detach): Don't call gdb_flush.
2077         * printcmd.c (do_examine): Don't call gdb_flush.
2078         (info_display_command): Don't call gdb_flush.
2079         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
2080         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
2081         * memattr.c (info_mem_command): Don't call gdb_flush.
2082         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
2083         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
2084         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
2085         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
2086         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
2087         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
2088         (gnu_nat_target::detach): Don't call gdb_flush.
2089         * f-valprint.c (f_val_print): Don't call gdb_flush.
2090         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
2091         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
2092         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
2093         gdb_flush.
2094         * c-valprint.c (c_val_print): Don't call gdb_flush.
2095         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
2096
2097 2019-03-05  Tom Tromey  <tromey@adacore.com>
2098
2099         * varobj.c (update_dynamic_varobj_children): Update.
2100         (install_default_visualizer): Use reset, not release.
2101         * value.c (set_internalvar): Update.
2102         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
2103         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
2104         ATTRIBUTE_UNUSED_RESULT.
2105
2106 2019-03-05  Tom Tromey  <tromey@adacore.com>
2107
2108         * remote.c (class scoped_remote_fd) <release>: Add
2109         ATTRIBUTE_UNUSED_RESULT.
2110
2111 2019-03-05  Tom Tromey  <tromey@adacore.com>
2112
2113         * macroexp.c (struct macro_buffer) <release>: Add
2114         ATTRIBUTE_UNUSED_RESULT.
2115
2116 2019-03-05  Tom Tromey  <tromey@adacore.com>
2117
2118         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
2119         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
2120         ATTRIBUTE_UNUSED_RESULT.
2121
2122 2019-03-05  Tom Tromey  <tromey@adacore.com>
2123
2124         * common/scoped_fd.h (class scoped_fd) <release>: Add
2125         ATTRIBUTE_UNUSED_RESULT.
2126
2127 2019-03-05  Tom Tromey  <tromey@adacore.com>
2128
2129         * parser-defs.h (struct parser_state) <release>: Add
2130         ATTRIBUTE_UNUSED_RESULT.
2131
2132 2019-03-05  Tom Tromey  <tromey@adacore.com>
2133
2134         * utils.h (class gdb_argv) <release>: Add
2135         ATTRIBUTE_UNUSED_RESULT.
2136         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
2137
2138 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
2139
2140         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
2141         for-loop range, to avoid compiler warnings.
2142
2143         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
2144         avoid compiler warnings about unused variables.
2145
2146         * NEWS: Mention end of support for native debugging on MS-Windows
2147         before XP.
2148
2149         PR gdb/24292
2150         * common/netstuff.c:
2151         * gdbserver/gdbreplay.c
2152         * gdbserver/remote-utils.c:
2153         * ser-tcp.c:
2154         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
2155         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
2156         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
2157         'getaddrinfo' and 'freeaddrinfo' were not available before
2158         Windows XP, and mingw.org's MinGW headers by default define
2159         _WIN32_WINNT to 0x500.
2160
2161 2019-03-01  Gary Benson <gbenson@redhat.com>
2162
2163         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
2164
2165 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
2166             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2167
2168         PR gdb/8527
2169         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
2170         set_sigint_trap, clear_sigint_trap.
2171
2172 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2173
2174         * target.c (target_detach): Clear the regcache and the
2175         frame cache.
2176
2177 2019-02-27  Pedro Alves  <palves@redhat.com>
2178
2179         * utils.c (set_screen_size): When we cap the height/width sizes,
2180         tweak the corresponding command variable to show "unlimited":
2181
2182 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
2183             Pedro Alves  <palves@redhat.com>
2184
2185         * utils.c (set_screen_size): Reduce "infinite" rows and columns
2186         before calling rl_set_screen_size.
2187
2188 2019-02-27  Tom Tromey  <tromey@adacore.com>
2189
2190         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
2191         define.
2192         * python/py-value.c: Remove Python 2.4 workaround.
2193         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
2194         workaround.
2195         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
2196         Python 2.4 workaround.
2197         * python/python-internal.h: Remove Python 2.4 comment.
2198         (Py_ssize_t): Don't define.
2199         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
2200         (gdb_Py_DECREF): Remove Python 2.4 workaround.
2201         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
2202         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
2203         * python/python.c (do_start_initialization): Remove Python 2.4
2204         workaround.
2205         * python/py-prettyprint.c (class dummy_python_frame): Remove.
2206         (print_children): Remove Python 2.4 workaround.
2207         * python/py-inferior.c (buffer_procs): Remove Python 2.4
2208         workaround.
2209         (CHARBUFFERPROC_NAME): Remove.
2210         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
2211         Python 2.4 workaround.
2212
2213 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
2214
2215         * NEWS: Note minimum Python version.
2216
2217 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
2218
2219         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
2220         code from these functions.  Remove corresponding ifdefs.  Use
2221         Py_buffer_up instead of explicit calls to PyBuffer_Release.
2222         Remove gotos and target of gotos.
2223         (infpy_search_memory): Likewise.
2224
2225 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2226
2227         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
2228         (hppa_gdbarch_init): Don't register deleted functions with
2229         gdbarch.
2230
2231 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2232
2233         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
2234         (h8300_unwind_sp): Delete.
2235         (h8300_dummy_id): Delete.
2236         (h8300_gdbarch_init): Don't register deleted functions with
2237         gdbarch.
2238
2239 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2240
2241         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
2242         (ft32_unwind_pc): Delete.
2243         (ft32_unwind_sp): Delete.
2244         (ft32_gdbarch_init): Don't register deleted functions with
2245         gdbarch.
2246
2247 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2248
2249         * gdb/frv-tdep.c (frv_dummy_id): Delete.
2250         (frv_unwind_pc): Delete.
2251         (frv_unwind_sp): Delete.
2252         (frv_gdbarch_init): Don't register deleted functions with
2253         gdbarch.
2254
2255 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2256
2257         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
2258         (riscv_unwind_pc): Delete.
2259         (riscv_unwind_sp): Delete.
2260         (riscv_gdbarch_init): Don't register deleted functions with
2261         gdbarch.
2262
2263 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2264
2265         * gdb/csky-tdep.c (csky_dummy_id): Delete.
2266         (csky_unwind_pc): Delete.
2267         (csky_unwind_sp): Delete.
2268         (csky_gdbarch_init): Don't register deleted functions with
2269         gdbarch.
2270
2271 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2272
2273         * gdb/cris-tdep.c (cris_dummy_id): Delete.
2274         (cris_unwind_pc): Delete.
2275         (cris_unwind_sp): Delete.
2276         (cris_gdbarch_init): Don't register deleted functions with
2277         gdbarch.
2278
2279 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2280
2281         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
2282         (bfin_unwind_pc): Delete.
2283         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
2284
2285 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2286
2287         * gdb/arm-tdep.c (arm_dummy_id): Delete.
2288         (arm_unwind_pc): Delete.
2289         (arm_unwind_sp): Delete.
2290         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
2291
2292 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2293
2294         * gdb/arc-tdep.c (arc_dummy_id): Delete.
2295         (arc_unwind_pc): Delete.
2296         (arc_unwind_sp): Delete.
2297         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
2298
2299 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2300
2301         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
2302         (alpha_unwind_pc): Delete.
2303         (alpha_gdbarch_init): Don't register deleted functions with
2304         gdbarch.
2305
2306 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2307
2308         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
2309         (aarch64_unwind_pc): Delete.
2310         (aarch64_unwind_sp): Delete.
2311         (aarch64_gdbarch_init): Don't register deleted functions with
2312         gdbarch.
2313
2314 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2315
2316         * gdbtypes.c (type_align): Don't consider static members when
2317         computing structure alignment.
2318
2319 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2320
2321         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
2322         return 0 for other types.
2323         * arch-utils.c (default_type_align): Always return 0.
2324         * gdbarch.h: Regenerate.
2325         * gdbarch.sh (type_align): Extend comment.
2326         * gdbtypes.c (type_align): Add additional comments, always call
2327         gdbarch_type_align before applying the default rules.
2328         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
2329         generic code will then apply a suitable default.
2330         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
2331         types, return 0 for other types.
2332
2333 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
2334
2335         * NEWS: Create a new section for the next release branch.
2336         Rename the section of the current branch, now that it has
2337         been cut.
2338
2339 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
2340
2341         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
2342         * version.in: Bump version to 8.3.50.DATE-git.
2343
2344 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
2345
2346         * aix-thread.c (ptid_cmp): Remove unused variable.
2347         (get_signaled_thread): Likewise.
2348         (store_regs_user_thread): Likewise.
2349         (store_regs_kernel_thread): Likewise.
2350         (fetch_regs_kernel_thread): Remove shadowed variable.
2351
2352 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2353
2354         * features/riscv/32bit-cpu.xml: Add register numbers.
2355         * features/riscv/32bit-fpu.c: Regenerate.
2356         * features/riscv/32bit-fpu.xml: Add register numbers.
2357         * features/riscv/64bit-cpu.xml: Add register numbers.
2358         * features/riscv/64bit-fpu.c: Regenerate.
2359         * features/riscv/64bit-fpu.xml: Add register numbers.
2360
2361 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
2362
2363         * NEWS: Mention two argument form of gdb.Value constructor.
2364         * python/py-value.c (convert_buffer_and_type_to_value): New
2365         function.
2366         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
2367         Add support for handling an optional second argument.  Call
2368         convert_buffer_and_type_to_value as appropriate.
2369         * python/python-internal.h (Py_buffer_deleter): New struct.
2370         (Py_buffer_up): New typedef.
2371
2372 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
2373
2374         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
2375         instead of releasing ownership.
2376
2377 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
2378
2379         * dwarf2read.c (open_and_init_dwp_file): Call
2380         elf_numsections instead of bfd_count_sections to initialize
2381         dwp_file->num_sections.
2382
2383 2019-02-25  Tom Tromey  <tromey@adacore.com>
2384
2385         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
2386
2387 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
2388
2389         * gcore.in: Add '--readnever' option when invoking GDB.
2390
2391 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
2392
2393         * MAINTAINERS: Update my email address.
2394
2395 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
2396
2397         * build-id.c (build_id_to_debug_bfd_1): New function.
2398         (build_id_to_debug_bfd): Look for separate debug file in
2399         sysroot.
2400
2401 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2402
2403         * gdbarch.sh: Update the copyright year range that is placed into
2404         generated files.
2405
2406 2019-02-22  Keith Seitz  <keiths@redhat.com>
2407
2408         PR symtab/23853
2409         * linespec.c (create_sals_line_offset): Search for the default
2410         symtab's filename instead of its fullname.
2411
2412 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
2413
2414         * NEWS: Update style defaults.
2415
2416 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
2417
2418         * main.c (captured_main_1): Disable styling in batch mode.
2419
2420 2019-02-20  Tom Tromey  <tom@tromey.com>
2421
2422         * symtab.c (symtab_symbol_info): Fix typos.
2423
2424 2019-02-20  Tom Tromey  <tromey@adacore.com>
2425
2426         * findcmd.c (_initialize_mem_search): Use upper case for
2427         metasyntactic variables.
2428
2429 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
2430
2431         * aarch64-tdep.c (aarch64_add_reggroups): New function.
2432         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
2433
2434 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
2435
2436         * top.h (source_file_name): Change to std::string.
2437         * top.c (source_file_name): Likewise.
2438         (command_line_input): Adjust.
2439         * cli/cli-script.c (script_from_file): Adjust.
2440
2441 2019-02-19  Tom Tromey  <tromey@adacore.com>
2442
2443         * ravenscar-thread.c
2444         (ravenscar_thread_target::update_thread_list): Don't call
2445         ada_build_task_list.
2446         * ada-lang.h (ada_build_task_list): Don't declare.
2447         * ada-tasks.c (struct ada_tasks_inferior_data)
2448         <task_list_valid_p>: Now bool.
2449         (read_known_tasks, ada_task_list_changed)
2450         (ada_tasks_invalidate_inferior_data): Update.
2451         (read_known_tasks_array): Return bool.
2452         (read_known_tasks_list): Likewise.
2453         (read_known_tasks): Return void.
2454         (ada_build_task_list): Now static.
2455
2456 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2457
2458         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
2459         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
2460
2461 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2462
2463         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
2464         variant for ada_tasks_pspace_data_handle and
2465         ada_tasks_inferior_data_handle.
2466         (ada_tasks_pspace_data_cleanup): New function.
2467         (ada_tasks_inferior_data_cleanup): New function.
2468
2469 2019-02-17  Tom Tromey  <tom@tromey.com>
2470
2471         * macrotab.h (macro_source_fullname): Return a std::string.
2472         * macrotab.c (macro_include, check_for_redefinition)
2473         (macro_undef, macro_lookup_definition, foreach_macro)
2474         (foreach_macro_in_scope): Update.
2475         (macro_source_fullname): Return a std::string.
2476         * macrocmd.c (show_pp_source_pos): Update.
2477
2478 2019-02-17  Tom Tromey  <tom@tromey.com>
2479
2480         * macrocmd.c (show_pp_source_pos): Style the file names.
2481
2482 2019-02-17  Tom Tromey  <tom@tromey.com>
2483
2484         PR tui/24197:
2485         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
2486
2487 2019-02-17  Tom Tromey  <tom@tromey.com>
2488
2489         * ada-lang.c (user_select_syms): Use filtered printing.
2490         * utils.c (wrap_style): New global.
2491         (desired_style): Remove.
2492         (emit_style_escape): Add stream parameter.
2493         (set_output_style, reset_terminal_style, prompt_for_continue):
2494         Update.
2495         (flush_wrap_buffer): Only flush gdb_stdout.
2496         (wrap_here): Set wrap_style.
2497         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
2498         treat escape sequences as a character.  Change when wrap buffer is
2499         flushed.
2500         (fputs_styled): Do not set the output style when the default is
2501         requested.
2502         * ui-style.h (struct ui_file_style) <is_default>: New method.
2503         * source.c (print_source_lines_base): Emit escape sequences in one
2504         piece.
2505
2506 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
2507
2508         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
2509         integers and enumeration types.
2510
2511 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
2512
2513         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
2514         instead of lookup_symbol_in_language
2515         (do_exact_match): New function.
2516         (ada_get_symbol_name_matcher): Return do_exact_match when
2517         doing a verbatim match.
2518
2519 2019-02-15  Tom Tromey  <tromey@adacore.com>
2520
2521         * ravenscar-thread.c (ravenscar_thread_target::resume)
2522         (ravenscar_thread_target::wait): Special case wildcard requests.
2523
2524 2019-02-15  Tom Tromey  <tromey@adacore.com>
2525
2526         * ravenscar-thread.c (base_ptid): Remove.
2527         (struct ravenscar_thread_target) <close>: New method.
2528         <m_base_ptid>: New member.
2529         <update_inferior_ptid, active_task, task_is_currently_active,
2530         runtime_initialized>: Declare methods.
2531         <ravenscar_thread_target>: Add constructor.
2532         (ravenscar_thread_target::task_is_currently_active)
2533         (ravenscar_thread_target::update_inferior_ptid)
2534         (ravenscar_runtime_initialized): Rename.  Now methods.
2535         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
2536         (ravenscar_thread_target::update_thread_list): Update.
2537         (ravenscar_thread_target::active_task): Now method.
2538         (ravenscar_thread_target::store_registers)
2539         (ravenscar_thread_target::prepare_to_store)
2540         (ravenscar_thread_target::prepare_to_store)
2541         (ravenscar_thread_target::mourn_inferior): Update.
2542         (ravenscar_inferior_created): Use "new" to create target.
2543         (ravenscar_thread_target::get_ada_task_ptid): Update.
2544         (_initialize_ravenscar): Don't initialize base_ptid.
2545         (ravenscar_ops): Remove global.
2546
2547 2019-02-15  Tom Tromey  <tromey@adacore.com>
2548
2549         * target.h (push_target): Declare new overload.
2550         * target.c (push_target): New overload, taking an rvalue reference.
2551         * remote.c (remote_target::open_1): Use push_target overload.
2552         * corelow.c (core_target_open): Use push_target overload.
2553
2554 2019-02-15  Tom Tromey  <tromey@adacore.com>
2555
2556         * ravenscar-thread.c (is_ravenscar_task)
2557         (ravenscar_task_is_currently_active): Return bool.
2558         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
2559         (_initialize_ravenscar): Remove "(void)".
2560         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
2561         Return bool.
2562
2563 2019-02-15  Tom Tromey  <tromey@adacore.com>
2564
2565         * ravenscar-thread.c (ravenscar_runtime_initializer)
2566         (has_ravenscar_runtime, get_running_thread_id)
2567         (ravenscar_thread_target::resume): Fix indentation.
2568
2569 2019-02-15  Tom Tromey  <tromey@adacore.com>
2570
2571         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
2572         from ravenscar_arch_ops.
2573         (sparc_ravenscar_ops::fetch_registers)
2574         (sparc_ravenscar_ops::store_registers): Now methods.
2575         (sparc_ravenscar_prepare_to_store): Remove.
2576         (sparc_ravenscar_ops): Redefine.
2577         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
2578         methods and destructor.  Remove members.
2579         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
2580         (ravenscar_thread_target::store_registers)
2581         (ravenscar_thread_target::prepare_to_store): Update.
2582         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
2583         Remove.
2584         (struct ppc_ravenscar_powerpc_ops): Derive from
2585         ravenscar_arch_ops.
2586         (ppc_ravenscar_powerpc_ops::fetch_registers)
2587         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
2588         (ppc_ravenscar_powerpc_ops): Redefine.
2589         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
2590         (ppc_ravenscar_e500_ops::fetch_registers)
2591         (ppc_ravenscar_e500_ops::store_registers): Now methods.
2592         (ppc_ravenscar_e500_ops): Redefine.
2593         * aarch64-ravenscar-thread.c
2594         (aarch64_ravenscar_generic_prepare_to_store): Remove.
2595         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
2596         (aarch64_ravenscar_fetch_registers)
2597         (aarch64_ravenscar_store_registers): Now methods.
2598         (aarch64_ravenscar_ops): Redefine.
2599
2600 2019-02-15  Tom Tromey  <tromey@adacore.com>
2601
2602         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
2603         (ravenscar_thread_target::stopped_by_hw_breakpoint)
2604         (ravenscar_thread_target::stopped_by_watchpoint)
2605         (ravenscar_thread_target::stopped_data_address)
2606         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
2607
2608 2019-02-15  Tom Tromey  <tromey@adacore.com>
2609
2610         * ravenscar-thread.c: Fix some typos.
2611
2612 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2613             Tom Tromey  <tromey@adacore.com>
2614
2615         * ada-lang.c (ada_exception_sal): Change addr_string to a
2616         std::string.
2617         (create_ada_exception_catchpoint): Update.
2618
2619 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2620             Tom Tromey  <tromey@adacore.com>
2621
2622         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
2623         (bp_location_ops): Remove.
2624         (base_breakpoint_allocate_location): Update.
2625         (free_bp_location): Update.
2626         * ada-lang.c (class ada_catchpoint_location)
2627         <ada_catchpoint_location>: Remove ops parameter.
2628         (ada_catchpoint_location_dtor): Remove.
2629         (ada_catchpoint_location_ops): Remove.
2630         (allocate_location_exception): Update.
2631         * breakpoint.h (struct bp_location_ops): Remove.
2632         (class bp_location) <bp_location>: Remove bp_location_ops
2633         parameter.
2634         <~bp_location>: Add destructor.
2635         <ops>: Remove.
2636
2637 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
2638             Pedro Alves  <palves@redhat.com>
2639
2640         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
2641         'PATH_MAX'.
2642
2643 2019-02-14  David Michael  <fedora.dm0@gmail.com>
2644             Samuel Thibault  <samuel.thibault@gnu.org>
2645             Thomas Schwinge  <thomas@codesourcery.com>
2646
2647         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
2648         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
2649
2650 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
2651
2652         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
2653         (check_empty): Use "const char *".
2654
2655         * gnu-nat.c (gnu_nat_target::detach): Instead of
2656         'detach_inferior (pid)' call
2657         'detach_inferior (find_inferior_pid (pid))'.
2658
2659         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
2660         'nat/fork-inferior.o'.
2661         * gnu-nat.c: #include "nat/fork-inferior.h".
2662
2663         * gnu-nat.c (gnu_nat_target::detach): Instead of
2664         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
2665         * gnu-nat.h: #include "inf-child.h".
2666         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
2667         'i386_gnu_nat_target::fetch_registers'.
2668         (gnu_store_registers): Rename/move to
2669         'i386_gnu_nat_target::store_registers'.
2670
2671         * config/i386/nm-i386gnu.h: Don't "#include" any files.
2672         * gnu-nat.h (mach_thread_info): New function.
2673         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
2674
2675         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
2676
2677 2019-02-14  Frederic Konrad  <konrad@adacore.com>
2678
2679         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
2680
2681 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
2682
2683         * windows-nat.c (windows_add_thread): Add new parameter
2684         "main_thread_p" with default value set to false.  Update
2685         function documentation as well as all callers.
2686         (windows_delete_thread): Likewise.
2687         (fake_create_process): Update call to windows_add_thread.
2688         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
2689         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
2690         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
2691         call to windows_delete_thread.
2692
2693 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
2694
2695         * MAINTAINERS: Add Andrew Burgess as global maintainer.
2696
2697 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2698
2699         * symfile.c (find_separate_debug_file): Use canonical path of
2700         sysroot with child_path instead of gdb_sysroot if it is valid.
2701
2702 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2703
2704         * symfile.c (find_separate_debug_file): Use child_path to
2705         determine if an object file is under a sysroot.
2706
2707 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2708
2709         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
2710         unittests/child-path-selftests.c.
2711         * common/pathstuff.c (child_path): New function.
2712         * common/pathstuff.h (child_path): New prototype.
2713         * unittests/child-path-selftests.c: New file.
2714
2715 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2716
2717         * symfile.c (find_separate_debug_file): Look for separate debug
2718         files in debug directories under the sysroot.
2719
2720 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2721
2722         * symtab.h (struct minimal_symbol data_p): New const method.
2723         (struct minimal_symbol text_p): Likewise.
2724         * symtab.c (output_source_filename): Use file name style
2725         to print file name.
2726         (print_symbol_info): Likewise.
2727         (print_msymbol_info): Use address style to print addresses.
2728         Use function name style to print executable text symbols.
2729         (expand_symtab_containing_pc): Use data_p.
2730         (find_pc_sect_compunit_symtab): Likewise.
2731
2732 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2733
2734         * breakpoint.c (describe_other_breakpoints): Use address style
2735         to print addresses.
2736         (say_where): Likewise.
2737
2738 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2739
2740         * ada-typeprint.c (print_func_type): Print function name
2741         style to print function name.
2742         * c-typeprint.c (c_print_type_1): Likewise.
2743
2744 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
2745
2746         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
2747         for execve.
2748
2749 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2750
2751         * c-exp.y (direct_abs_decl): Use emplace_back to record the
2752         type_stack.
2753
2754 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
2755
2756         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
2757         TYPE_CODE_REF types.
2758
2759 2019-02-08  Jim Wilson  <jimw@sifive.com>
2760
2761         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
2762         (riscv_linux_fregset): New.
2763         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
2764
2765 2019-02-07  Tom Tromey  <tom@tromey.com>
2766
2767         * thread.c (thread_cancel_execution_command): Update.
2768         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
2769         methods.
2770         (struct thread_fsm_ops): Remove.
2771         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
2772         (thread_fsm_should_stop, thread_fsm_return_value)
2773         (thread_fsm_set_finished, thread_fsm_finished_p)
2774         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
2775         Don't declare.
2776         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
2777         * infrun.c (clear_proceed_status_thread)
2778         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
2779         (print_stop_event): Update.
2780         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
2781         Add constructor.
2782         (step_command_fsm_ops): Remove.
2783         (new_step_command_fsm): Remove.
2784         (step_1): Update.
2785         (step_command_fsm::should_stop): Rename from
2786         step_command_fsm_should_stop.
2787         (step_command_fsm::clean_up): Rename from
2788         step_command_fsm_clean_up.
2789         (step_command_fsm::do_async_reply_reason): Rename from
2790         step_command_fsm_async_reply_reason.
2791         (struct until_next_fsm): Inherit from thread_fsm.  Add
2792         constructor.
2793         (until_next_fsm_ops): Remove.
2794         (new_until_next_fsm): Remove.
2795         (until_next_fsm::should_stop): Rename from
2796         until_next_fsm_should_stop.
2797         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
2798         (until_next_fsm::do_async_reply_reason): Rename from
2799         until_next_fsm_async_reply_reason.
2800         (struct finish_command_fsm): Inherit from thread_fsm.  Add
2801         constructor.  Change type of breakpoint.
2802         (finish_command_fsm_ops): Remove.
2803         (new_finish_command_fsm): Remove.
2804         (finish_command_fsm::should_stop): Rename from
2805         finish_command_fsm_should_stop.
2806         (finish_command_fsm::clean_up): Rename from
2807         finish_command_fsm_clean_up.
2808         (finish_command_fsm::return_value): Rename from
2809         finish_command_fsm_return_value.
2810         (finish_command_fsm::do_async_reply_reason): Rename from
2811         finish_command_fsm_async_reply_reason.
2812         (finish_command): Update.
2813         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
2814         Add constructor.
2815         (call_thread_fsm_ops): Remove.
2816         (call_thread_fsm::call_thread_fsm): Rename from
2817         new_call_thread_fsm.
2818         (call_thread_fsm::should_stop): Rename from
2819         call_thread_fsm_should_stop.
2820         (call_thread_fsm::should_notify_stop): Rename from
2821         call_thread_fsm_should_notify_stop.
2822         (run_inferior_call, call_function_by_hand_dummy): Update.
2823         * cli/cli-interp.c (should_print_stop_to_console): Update.
2824         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
2825         Add constructor.  Change type of location_breakpoint,
2826         caller_breakpoint.
2827         (until_break_fsm_ops): Remove.
2828         (new_until_break_fsm): Remove.
2829         (until_break_fsm::should_stop): Rename from
2830         until_break_fsm_should_stop.
2831         (until_break_fsm::clean_up): Rename from
2832         until_break_fsm_clean_up.
2833         (until_break_fsm::do_async_reply_reason): Rename from
2834         until_break_fsm_async_reply_reason.
2835         (until_break_command): Update.
2836         * thread-fsm.c: Remove.
2837         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
2838
2839 2019-02-07  Tom Tromey  <tom@tromey.com>
2840
2841         * yy-remap.h: Add include guard.
2842         * xtensa-tdep.h: Add include guard.
2843         * xcoffread.h: Rename include guard.
2844         * varobj-iter.h: Add include guard.
2845         * tui/tui.h: Rename include guard.
2846         * tui/tui-winsource.h: Rename include guard.
2847         * tui/tui-wingeneral.h: Rename include guard.
2848         * tui/tui-windata.h: Rename include guard.
2849         * tui/tui-win.h: Rename include guard.
2850         * tui/tui-stack.h: Rename include guard.
2851         * tui/tui-source.h: Rename include guard.
2852         * tui/tui-regs.h: Rename include guard.
2853         * tui/tui-out.h: Rename include guard.
2854         * tui/tui-layout.h: Rename include guard.
2855         * tui/tui-io.h: Rename include guard.
2856         * tui/tui-hooks.h: Rename include guard.
2857         * tui/tui-file.h: Rename include guard.
2858         * tui/tui-disasm.h: Rename include guard.
2859         * tui/tui-data.h: Rename include guard.
2860         * tui/tui-command.h: Rename include guard.
2861         * tic6x-tdep.h: Add include guard.
2862         * target/waitstatus.h: Rename include guard.
2863         * target/wait.h: Rename include guard.
2864         * target/target.h: Rename include guard.
2865         * target/resume.h: Rename include guard.
2866         * target-float.h: Rename include guard.
2867         * stabsread.h: Add include guard.
2868         * rs6000-tdep.h: Add include guard.
2869         * riscv-fbsd-tdep.h: Add include guard.
2870         * regformats/regdef.h: Rename include guard.
2871         * record.h: Rename include guard.
2872         * python/python.h: Rename include guard.
2873         * python/python-internal.h: Rename include guard.
2874         * python/py-stopevent.h: Rename include guard.
2875         * python/py-ref.h: Rename include guard.
2876         * python/py-record.h: Rename include guard.
2877         * python/py-record-full.h: Rename include guard.
2878         * python/py-record-btrace.h: Rename include guard.
2879         * python/py-instruction.h: Rename include guard.
2880         * python/py-events.h: Rename include guard.
2881         * python/py-event.h: Rename include guard.
2882         * procfs.h: Add include guard.
2883         * proc-utils.h: Add include guard.
2884         * p-lang.h: Add include guard.
2885         * or1k-tdep.h: Rename include guard.
2886         * observable.h: Rename include guard.
2887         * nto-tdep.h: Rename include guard.
2888         * nat/x86-linux.h: Rename include guard.
2889         * nat/x86-linux-dregs.h: Rename include guard.
2890         * nat/x86-gcc-cpuid.h: Add include guard.
2891         * nat/x86-dregs.h: Rename include guard.
2892         * nat/x86-cpuid.h: Rename include guard.
2893         * nat/ppc-linux.h: Rename include guard.
2894         * nat/mips-linux-watch.h: Rename include guard.
2895         * nat/linux-waitpid.h: Rename include guard.
2896         * nat/linux-ptrace.h: Rename include guard.
2897         * nat/linux-procfs.h: Rename include guard.
2898         * nat/linux-osdata.h: Rename include guard.
2899         * nat/linux-nat.h: Rename include guard.
2900         * nat/linux-namespaces.h: Rename include guard.
2901         * nat/linux-btrace.h: Rename include guard.
2902         * nat/glibc_thread_db.h: Rename include guard.
2903         * nat/gdb_thread_db.h: Rename include guard.
2904         * nat/gdb_ptrace.h: Rename include guard.
2905         * nat/fork-inferior.h: Rename include guard.
2906         * nat/amd64-linux-siginfo.h: Rename include guard.
2907         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
2908         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
2909         * nat/aarch64-linux.h: Rename include guard.
2910         * nat/aarch64-linux-hw-point.h: Rename include guard.
2911         * mn10300-tdep.h: Add include guard.
2912         * mips-linux-tdep.h: Add include guard.
2913         * mi/mi-parse.h: Rename include guard.
2914         * mi/mi-out.h: Rename include guard.
2915         * mi/mi-main.h: Rename include guard.
2916         * mi/mi-interp.h: Rename include guard.
2917         * mi/mi-getopt.h: Rename include guard.
2918         * mi/mi-console.h: Rename include guard.
2919         * mi/mi-common.h: Rename include guard.
2920         * mi/mi-cmds.h: Rename include guard.
2921         * mi/mi-cmd-break.h: Rename include guard.
2922         * m2-lang.h: Add include guard.
2923         * location.h: Rename include guard.
2924         * linux-record.h: Rename include guard.
2925         * linux-nat.h: Add include guard.
2926         * linux-fork.h: Add include guard.
2927         * i386-darwin-tdep.h: Rename include guard.
2928         * hppa-linux-offsets.h: Add include guard.
2929         * guile/guile.h: Rename include guard.
2930         * guile/guile-internal.h: Rename include guard.
2931         * gnu-nat.h: Rename include guard.
2932         * gdb-stabs.h: Rename include guard.
2933         * frv-tdep.h: Add include guard.
2934         * f-lang.h: Add include guard.
2935         * event-loop.h: Add include guard.
2936         * darwin-nat.h: Rename include guard.
2937         * cp-abi.h: Rename include guard.
2938         * config/sparc/nm-sol2.h: Rename include guard.
2939         * config/nm-nto.h: Rename include guard.
2940         * config/nm-linux.h: Add include guard.
2941         * config/i386/nm-i386gnu.h: Rename include guard.
2942         * config/djgpp/nl_types.h: Rename include guard.
2943         * config/djgpp/langinfo.h: Rename include guard.
2944         * compile/gcc-cp-plugin.h: Add include guard.
2945         * compile/gcc-c-plugin.h: Add include guard.
2946         * compile/compile.h: Rename include guard.
2947         * compile/compile-object-run.h: Rename include guard.
2948         * compile/compile-object-load.h: Rename include guard.
2949         * compile/compile-internal.h: Rename include guard.
2950         * compile/compile-cplus.h: Rename include guard.
2951         * compile/compile-c.h: Rename include guard.
2952         * common/xml-utils.h: Rename include guard.
2953         * common/x86-xstate.h: Rename include guard.
2954         * common/version.h: Rename include guard.
2955         * common/vec.h: Rename include guard.
2956         * common/tdesc.h: Rename include guard.
2957         * common/selftest.h: Rename include guard.
2958         * common/scoped_restore.h: Rename include guard.
2959         * common/scoped_mmap.h: Rename include guard.
2960         * common/scoped_fd.h: Rename include guard.
2961         * common/safe-iterator.h: Rename include guard.
2962         * common/run-time-clock.h: Rename include guard.
2963         * common/refcounted-object.h: Rename include guard.
2964         * common/queue.h: Rename include guard.
2965         * common/ptid.h: Rename include guard.
2966         * common/print-utils.h: Rename include guard.
2967         * common/preprocessor.h: Rename include guard.
2968         * common/pathstuff.h: Rename include guard.
2969         * common/observable.h: Rename include guard.
2970         * common/netstuff.h: Rename include guard.
2971         * common/job-control.h: Rename include guard.
2972         * common/host-defs.h: Rename include guard.
2973         * common/gdb_wait.h: Rename include guard.
2974         * common/gdb_vecs.h: Rename include guard.
2975         * common/gdb_unlinker.h: Rename include guard.
2976         * common/gdb_unique_ptr.h: Rename include guard.
2977         * common/gdb_tilde_expand.h: Rename include guard.
2978         * common/gdb_sys_time.h: Rename include guard.
2979         * common/gdb_string_view.h: Rename include guard.
2980         * common/gdb_splay_tree.h: Rename include guard.
2981         * common/gdb_setjmp.h: Rename include guard.
2982         * common/gdb_ref_ptr.h: Rename include guard.
2983         * common/gdb_optional.h: Rename include guard.
2984         * common/gdb_locale.h: Rename include guard.
2985         * common/gdb_assert.h: Rename include guard.
2986         * common/filtered-iterator.h: Rename include guard.
2987         * common/filestuff.h: Rename include guard.
2988         * common/fileio.h: Rename include guard.
2989         * common/environ.h: Rename include guard.
2990         * common/common-utils.h: Rename include guard.
2991         * common/common-types.h: Rename include guard.
2992         * common/common-regcache.h: Rename include guard.
2993         * common/common-inferior.h: Rename include guard.
2994         * common/common-gdbthread.h: Rename include guard.
2995         * common/common-exceptions.h: Rename include guard.
2996         * common/common-defs.h: Rename include guard.
2997         * common/common-debug.h: Rename include guard.
2998         * common/cleanups.h: Rename include guard.
2999         * common/buffer.h: Rename include guard.
3000         * common/btrace-common.h: Rename include guard.
3001         * common/break-common.h: Rename include guard.
3002         * cli/cli-utils.h: Rename include guard.
3003         * cli/cli-style.h: Rename include guard.
3004         * cli/cli-setshow.h: Rename include guard.
3005         * cli/cli-script.h: Rename include guard.
3006         * cli/cli-interp.h: Rename include guard.
3007         * cli/cli-decode.h: Rename include guard.
3008         * cli/cli-cmds.h: Rename include guard.
3009         * charset-list.h: Add include guard.
3010         * buildsym-legacy.h: Rename include guard.
3011         * bfin-tdep.h: Add include guard.
3012         * ax.h: Rename include guard.
3013         * arm-linux-tdep.h: Add include guard.
3014         * arm-fbsd-tdep.h: Add include guard.
3015         * arch/xtensa.h: Rename include guard.
3016         * arch/tic6x.h: Add include guard.
3017         * arch/i386.h: Add include guard.
3018         * arch/arm.h: Rename include guard.
3019         * arch/arm-linux.h: Rename include guard.
3020         * arch/arm-get-next-pcs.h: Rename include guard.
3021         * arch/amd64.h: Add include guard.
3022         * arch/aarch64-insn.h: Rename include guard.
3023         * arch-utils.h: Rename include guard.
3024         * annotate.h: Add include guard.
3025         * amd64-darwin-tdep.h: Rename include guard.
3026         * aarch64-linux-tdep.h: Add include guard.
3027         * aarch64-fbsd-tdep.h: Add include guard.
3028         * aarch32-linux-nat.h: Add include guard.
3029
3030 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3031
3032         * macrotab.c (macro_define_internal): New function that
3033         factorizes macro_define_object_internal and macro_define_function
3034         code.
3035         (macro_define_object_internal): Use macro_define_internal.
3036         (macro_define_function): Likewise.
3037
3038 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3039
3040         * macrocmd.c (extract_identifier): Return
3041         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
3042         callers.
3043
3044 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
3045
3046         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
3047
3048 2019-02-05  Tom Tromey  <tom@tromey.com>
3049
3050         * target.c (target_stack::unpush): Move assertion earlier.
3051
3052 2019-01-30  Tom Tromey  <tom@tromey.com>
3053
3054         PR python/23615:
3055         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
3056         (gdbpy_parse_and_eval): Likewise.
3057         * python/python-internal.h (gdbpy_allow_threads): New class.
3058
3059 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
3060
3061         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
3062         (aarch64_fbsd_fpregmap): Move earlier.
3063         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
3064         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3065         instead of individual calls to trad_frame_set_reg_addr.
3066         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
3067         earlier.
3068         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
3069         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3070         instead of individual calls to trad_frame_set_reg_addr.
3071
3072 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
3073
3074         * CONTRIBUTE: Replace contribution list with wiki link.
3075
3076 2019-01-25  Tom Tromey  <tom@tromey.com>
3077
3078         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
3079
3080 2019-01-25  Tom Tromey  <tom@tromey.com>
3081
3082         * xtensa-linux-nat.c: Fix common/ includes.
3083         * xml-support.h: Fix common/ includes.
3084         * xml-support.c: Fix common/ includes.
3085         * x86-linux-nat.c: Fix common/ includes.
3086         * windows-nat.c: Fix common/ includes.
3087         * varobj.h: Fix common/ includes.
3088         * varobj.c: Fix common/ includes.
3089         * value.c: Fix common/ includes.
3090         * valops.c: Fix common/ includes.
3091         * utils.c: Fix common/ includes.
3092         * unittests/xml-utils-selftests.c: Fix common/ includes.
3093         * unittests/utils-selftests.c: Fix common/ includes.
3094         * unittests/unpack-selftests.c: Fix common/ includes.
3095         * unittests/tracepoint-selftests.c: Fix common/ includes.
3096         * unittests/style-selftests.c: Fix common/ includes.
3097         * unittests/string_view-selftests.c: Fix common/ includes.
3098         * unittests/scoped_restore-selftests.c: Fix common/ includes.
3099         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
3100         * unittests/scoped_fd-selftests.c: Fix common/ includes.
3101         * unittests/rsp-low-selftests.c: Fix common/ includes.
3102         * unittests/parse-connection-spec-selftests.c: Fix common/
3103         includes.
3104         * unittests/optional-selftests.c: Fix common/ includes.
3105         * unittests/offset-type-selftests.c: Fix common/ includes.
3106         * unittests/observable-selftests.c: Fix common/ includes.
3107         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
3108         * unittests/memrange-selftests.c: Fix common/ includes.
3109         * unittests/memory-map-selftests.c: Fix common/ includes.
3110         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
3111         * unittests/function-view-selftests.c: Fix common/ includes.
3112         * unittests/environ-selftests.c: Fix common/ includes.
3113         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
3114         * unittests/common-utils-selftests.c: Fix common/ includes.
3115         * unittests/cli-utils-selftests.c: Fix common/ includes.
3116         * unittests/array-view-selftests.c: Fix common/ includes.
3117         * ui-file.c: Fix common/ includes.
3118         * tui/tui-io.c: Fix common/ includes.
3119         * tracepoint.h: Fix common/ includes.
3120         * tracepoint.c: Fix common/ includes.
3121         * tracefile-tfile.c: Fix common/ includes.
3122         * top.h: Fix common/ includes.
3123         * top.c: Fix common/ includes.
3124         * thread.c: Fix common/ includes.
3125         * target/waitstatus.h: Fix common/ includes.
3126         * target/waitstatus.c: Fix common/ includes.
3127         * target.h: Fix common/ includes.
3128         * target.c: Fix common/ includes.
3129         * target-memory.c: Fix common/ includes.
3130         * target-descriptions.c: Fix common/ includes.
3131         * symtab.h: Fix common/ includes.
3132         * symfile.c: Fix common/ includes.
3133         * stap-probe.c: Fix common/ includes.
3134         * spu-linux-nat.c: Fix common/ includes.
3135         * sparc-nat.c: Fix common/ includes.
3136         * source.c: Fix common/ includes.
3137         * solib.c: Fix common/ includes.
3138         * solib-target.c: Fix common/ includes.
3139         * ser-unix.c: Fix common/ includes.
3140         * ser-tcp.c: Fix common/ includes.
3141         * ser-pipe.c: Fix common/ includes.
3142         * ser-base.c: Fix common/ includes.
3143         * selftest-arch.c: Fix common/ includes.
3144         * s12z-tdep.c: Fix common/ includes.
3145         * rust-exp.y: Fix common/ includes.
3146         * rs6000-aix-tdep.c: Fix common/ includes.
3147         * riscv-tdep.c: Fix common/ includes.
3148         * remote.c: Fix common/ includes.
3149         * remote-notif.h: Fix common/ includes.
3150         * remote-fileio.h: Fix common/ includes.
3151         * remote-fileio.c: Fix common/ includes.
3152         * regcache.h: Fix common/ includes.
3153         * regcache.c: Fix common/ includes.
3154         * record-btrace.c: Fix common/ includes.
3155         * python/python.c: Fix common/ includes.
3156         * python/py-type.c: Fix common/ includes.
3157         * python/py-inferior.c: Fix common/ includes.
3158         * progspace.h: Fix common/ includes.
3159         * producer.c: Fix common/ includes.
3160         * procfs.c: Fix common/ includes.
3161         * proc-api.c: Fix common/ includes.
3162         * printcmd.c: Fix common/ includes.
3163         * ppc-linux-nat.c: Fix common/ includes.
3164         * parser-defs.h: Fix common/ includes.
3165         * osdata.c: Fix common/ includes.
3166         * obsd-nat.c: Fix common/ includes.
3167         * nat/x86-linux.c: Fix common/ includes.
3168         * nat/x86-linux-dregs.c: Fix common/ includes.
3169         * nat/x86-dregs.h: Fix common/ includes.
3170         * nat/x86-dregs.c: Fix common/ includes.
3171         * nat/ppc-linux.c: Fix common/ includes.
3172         * nat/mips-linux-watch.h: Fix common/ includes.
3173         * nat/mips-linux-watch.c: Fix common/ includes.
3174         * nat/linux-waitpid.c: Fix common/ includes.
3175         * nat/linux-ptrace.h: Fix common/ includes.
3176         * nat/linux-ptrace.c: Fix common/ includes.
3177         * nat/linux-procfs.c: Fix common/ includes.
3178         * nat/linux-personality.c: Fix common/ includes.
3179         * nat/linux-osdata.c: Fix common/ includes.
3180         * nat/linux-namespaces.c: Fix common/ includes.
3181         * nat/linux-btrace.h: Fix common/ includes.
3182         * nat/linux-btrace.c: Fix common/ includes.
3183         * nat/fork-inferior.c: Fix common/ includes.
3184         * nat/amd64-linux-siginfo.c: Fix common/ includes.
3185         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
3186         * nat/aarch64-linux.c: Fix common/ includes.
3187         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
3188         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
3189         * namespace.h: Fix common/ includes.
3190         * mips-linux-tdep.c: Fix common/ includes.
3191         * minsyms.c: Fix common/ includes.
3192         * mi/mi-parse.h: Fix common/ includes.
3193         * mi/mi-main.c: Fix common/ includes.
3194         * mi/mi-cmd-env.c: Fix common/ includes.
3195         * memrange.h: Fix common/ includes.
3196         * memattr.c: Fix common/ includes.
3197         * maint.h: Fix common/ includes.
3198         * maint.c: Fix common/ includes.
3199         * main.c: Fix common/ includes.
3200         * machoread.c: Fix common/ includes.
3201         * location.c: Fix common/ includes.
3202         * linux-thread-db.c: Fix common/ includes.
3203         * linux-nat.c: Fix common/ includes.
3204         * linux-fork.c: Fix common/ includes.
3205         * inline-frame.c: Fix common/ includes.
3206         * infrun.c: Fix common/ includes.
3207         * inflow.c: Fix common/ includes.
3208         * inferior.h: Fix common/ includes.
3209         * inferior.c: Fix common/ includes.
3210         * infcmd.c: Fix common/ includes.
3211         * inf-ptrace.c: Fix common/ includes.
3212         * inf-child.c: Fix common/ includes.
3213         * ia64-linux-nat.c: Fix common/ includes.
3214         * i387-tdep.c: Fix common/ includes.
3215         * i386-tdep.c: Fix common/ includes.
3216         * i386-linux-tdep.c: Fix common/ includes.
3217         * i386-linux-nat.c: Fix common/ includes.
3218         * i386-go32-tdep.c: Fix common/ includes.
3219         * i386-fbsd-tdep.c: Fix common/ includes.
3220         * i386-fbsd-nat.c: Fix common/ includes.
3221         * guile/scm-type.c: Fix common/ includes.
3222         * guile/guile.c: Fix common/ includes.
3223         * go32-nat.c: Fix common/ includes.
3224         * gnu-nat.c: Fix common/ includes.
3225         * gdbthread.h: Fix common/ includes.
3226         * gdbarch-selftests.c: Fix common/ includes.
3227         * gdb_usleep.c: Fix common/ includes.
3228         * gdb_select.h: Fix common/ includes.
3229         * gdb_bfd.c: Fix common/ includes.
3230         * gcore.c: Fix common/ includes.
3231         * fork-child.c: Fix common/ includes.
3232         * findvar.c: Fix common/ includes.
3233         * fbsd-nat.c: Fix common/ includes.
3234         * event-top.c: Fix common/ includes.
3235         * event-loop.c: Fix common/ includes.
3236         * dwarf2read.c: Fix common/ includes.
3237         * dwarf2loc.c: Fix common/ includes.
3238         * dwarf2-frame.c: Fix common/ includes.
3239         * dwarf-index-cache.c: Fix common/ includes.
3240         * dtrace-probe.c: Fix common/ includes.
3241         * disasm-selftests.c: Fix common/ includes.
3242         * defs.h: Fix common/ includes.
3243         * csky-tdep.c: Fix common/ includes.
3244         * cp-valprint.c: Fix common/ includes.
3245         * cp-support.h: Fix common/ includes.
3246         * cp-support.c: Fix common/ includes.
3247         * corelow.c: Fix common/ includes.
3248         * completer.h: Fix common/ includes.
3249         * completer.c: Fix common/ includes.
3250         * compile/compile.c: Fix common/ includes.
3251         * compile/compile-loc2c.c: Fix common/ includes.
3252         * compile/compile-cplus-types.c: Fix common/ includes.
3253         * compile/compile-cplus-symbols.c: Fix common/ includes.
3254         * command.h: Fix common/ includes.
3255         * cli/cli-dump.c: Fix common/ includes.
3256         * cli/cli-cmds.c: Fix common/ includes.
3257         * charset.c: Fix common/ includes.
3258         * build-id.c: Fix common/ includes.
3259         * btrace.h: Fix common/ includes.
3260         * btrace.c: Fix common/ includes.
3261         * breakpoint.h: Fix common/ includes.
3262         * breakpoint.c: Fix common/ includes.
3263         * ax.h:
3264         (enum agent_op): Fix common/ includes.
3265         * ax-general.c (struct aop_map): Fix common/ includes.
3266         * ax-gdb.c: Fix common/ includes.
3267         * auxv.c: Fix common/ includes.
3268         * auto-load.c: Fix common/ includes.
3269         * arm-tdep.c: Fix common/ includes.
3270         * arch/riscv.c: Fix common/ includes.
3271         * arch/ppc-linux-common.c: Fix common/ includes.
3272         * arch/i386.c: Fix common/ includes.
3273         * arch/arm.c: Fix common/ includes.
3274         * arch/arm-linux.c: Fix common/ includes.
3275         * arch/arm-get-next-pcs.c: Fix common/ includes.
3276         * arch/amd64.c: Fix common/ includes.
3277         * arch/aarch64.c: Fix common/ includes.
3278         * arch/aarch64-insn.c: Fix common/ includes.
3279         * arch-utils.c: Fix common/ includes.
3280         * amd64-windows-tdep.c: Fix common/ includes.
3281         * amd64-tdep.c: Fix common/ includes.
3282         * amd64-sol2-tdep.c: Fix common/ includes.
3283         * amd64-obsd-tdep.c: Fix common/ includes.
3284         * amd64-nbsd-tdep.c: Fix common/ includes.
3285         * amd64-linux-tdep.c: Fix common/ includes.
3286         * amd64-linux-nat.c: Fix common/ includes.
3287         * amd64-fbsd-tdep.c: Fix common/ includes.
3288         * amd64-fbsd-nat.c: Fix common/ includes.
3289         * amd64-dicos-tdep.c: Fix common/ includes.
3290         * amd64-darwin-tdep.c: Fix common/ includes.
3291         * agent.c: Fix common/ includes.
3292         * ada-lang.h: Fix common/ includes.
3293         * ada-lang.c: Fix common/ includes.
3294         * aarch64-tdep.c: Fix common/ includes.
3295
3296 2019-01-25  Tom Tromey  <tom@tromey.com>
3297
3298         * common/create-version.sh: Use common/version.h.
3299
3300 2019-01-24  Pedro Alves  <palves@redhat.com>
3301
3302         * infrun.c (signal_stop, signal_print, signal_program)
3303         (signal_catch, signal_pass): Now arrays instead of pointers.
3304         (update_signals_program_target, do_target_resume)
3305         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
3306         * linux-nat.c (linux_nat_target::pass_signals)
3307         (linux_nat_target::create_inferior, linux_nat_target::attach):
3308         Adjust.
3309         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
3310         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
3311         * procfs.c (procfs_target::pass_signals): Adjust.
3312         * record-full.c (record_full_target::resume): Adjust.
3313         * remote.c (remote_target::pass_signals)
3314         (remote_target::program_signals): Adjust.
3315         * target-debug.h (target_debug_print_signals): Now takes a
3316         gdb::array_view as parameter.  Adjust.
3317         * target.h (target_ops) <pass_signals, program_signals>: Replace
3318         pointer and length parameters with gdb::array_view.
3319         (target_pass_signals, target_program_signals): Likewise.
3320         * target-delegates.c: Regenerate.
3321
3322 2019-01-24  Pedro Alves  <palves@redhat.com>
3323
3324         * common/forward-scope-exit.h
3325         (forward_scope_exit::forward_scope_exit): Pass arguments to
3326         m_bind_function directly, instead of creating a std::bind and
3327         copying that.
3328
3329 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
3330
3331         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
3332         for static members.
3333         (pass_in_v_vfp_candidate): Likewise.
3334
3335 2019-01-23  Tom Tromey  <tom@tromey.com>
3336             Pedro Alves  <palves@redhat.com>
3337
3338         * regcache.c (class regcache_invalidator): Remove.
3339         (regcache::raw_write): Use make_scope_exit.
3340
3341 2019-01-23  Tom Tromey  <tom@tromey.com>
3342
3343         * ui-out.h (class ui_out_emit_type): Update comment.
3344
3345 2019-01-23  Tom Tromey  <tom@tromey.com>
3346
3347         * infrun.c (fetch_inferior_event): Update comment.
3348
3349 2019-01-23  Tom Tromey  <tom@tromey.com>
3350             Pedro Alves  <palves@redhat.com>
3351
3352         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
3353         parameter.
3354         (fetch_inferior_event): Use SCOPE_EXIT.
3355
3356
3357 2019-01-23  Tom Tromey  <tom@tromey.com>
3358             Pedro Alves  <palves@redhat.com>
3359
3360         * infrun.c (disable_thread_events): Delete.
3361         (stop_all_threads): Use SCOPE_EXIT.
3362
3363 2019-01-23  Tom Tromey  <tom@tromey.com>
3364             Pedro Alves  <palves@redhat.com>
3365
3366         * symfile.c: Include forward-scope-exit.h.
3367         (clear_symtab_users_cleanup): Replace forward declaration with
3368         a FORWARD_SCOPE_EXIT.
3369         (syms_from_objfile_1): Use the forward_scope_exit and
3370         gdb::optional instead of cleanup_function.
3371         (reread_symbols): Use the forward_scope_exit instead of
3372         cleanup_function.
3373         (clear_symtab_users_cleanup): Remove function.
3374
3375 2019-01-23  Tom Tromey  <tom@tromey.com>
3376             Pedro Alves  <palves@redhat.com>
3377
3378         * linux-nat.c: Include scope-exit.h.
3379         (cleanup_target_stop): Remove.
3380         (linux_nat_target::static_tracepoint_markers_by_strid): Use
3381         SCOPE_EXIT.
3382
3383 2019-01-23  Tom Tromey  <tom@tromey.com>
3384             Pedro Alves  <palves@redhat.com>
3385
3386         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
3387         (call_function_by_hand_dummy): Use SCOPE_EXIT.
3388
3389 2019-01-23  Tom Tromey  <tom@tromey.com>
3390             Andrew Burgess  <andrew.burgess@embecosm.com>
3391             Pedro Alves  <palves@redhat.com>
3392
3393         * infrun.c (fetch_inferior_event): Use scope_exit.
3394         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
3395         * top.c (execute_command): Use scope_exit.
3396         * breakpoint.c (bpstat_do_actions): Use scope_exit.
3397         * utils.c (do_bpstat_clear_actions_cleanup)
3398         (make_bpstat_clear_actions_cleanup): Remove.
3399
3400 2019-01-23  Tom Tromey  <tom@tromey.com>
3401             Pedro Alves  <palves@redhat.com>
3402
3403         * infrun.c: Include "common/scope-exit.h"
3404         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
3405         (wait_for_inferior): Use SCOPE_EXIT.
3406         (fetch_inferior_event): Use scope_exit.
3407
3408 2019-01-23  Tom Tromey  <tom@tromey.com>
3409             Pedro Alves  <palves@redhat.com>
3410
3411         * breakpoint.c (create_breakpoint): Remove cleanup.
3412
3413 2019-01-23  Tom Tromey  <tom@tromey.com>
3414             Andrew Burgess  <andrew.burgess@embecosm.com>
3415             Pedro Alves  <palves@redhat.com>
3416
3417 2019-01-23  Pedro Alves  <palves@redhat.com>
3418
3419         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
3420
3421 2019-01-23  Pedro Alves  <palves@redhat.com>
3422             Andrew Burgess  <andrew.burgess@embecosm.com>
3423
3424         * gdbthread.h: Include "common/forward-scope-exit.h".
3425         (scoped_finish_thread_state): Redefine custom class in terms of
3426         forward_scope_exit.
3427
3428 2019-01-23  Pedro Alves  <palves@redhat.com>
3429             Andrew Burgess  <andrew.burgess@embecosm.com>
3430
3431         * common/forward-scope-exit.h: New file.
3432
3433 2019-01-23  Pedro Alves  <palves@redhat.com>
3434             Andrew Burgess  <andrew.burgess@embecosm.com>
3435             Tom Tromey  <tom@tromey.com>
3436
3437         * common/scope-exit.h: New file.
3438
3439 2019-01-23  Pedro Alves  <palves@redhat.com>
3440
3441         * common/preprocessor.h (ESC): Rename to ...
3442         (ESC_PARENS): ... this.
3443         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
3444         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
3445
3446 2019-01-23  Tom Tromey  <tom@tromey.com>
3447
3448         * language.h (class scoped_switch_to_sym_language_if_auto):
3449         Initialize m_lang in both cases.
3450
3451 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
3452
3453         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
3454         with XCNEW.
3455
3456 2019-01-22  Tom Tromey  <tom@tromey.com>
3457
3458         * corelow.c: Do not include sys/file.h.
3459
3460 2019-01-22  Tom Tromey  <tom@tromey.com>
3461
3462         * tui/tui-wingeneral.h: Include gdb_curses.h.
3463
3464 2019-01-22  Tom Tromey  <tom@tromey.com>
3465
3466         * source-cache.h (class source_cache) <get_source_lines,
3467         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
3468
3469 2019-01-22  Tom Tromey  <tom@tromey.com>
3470
3471         * remote-fileio.h (struct remote_target): Declare.
3472
3473 2019-01-22  Tom Tromey  <tom@tromey.com>
3474
3475         * python/py-arch.c: Do not include py-ref.h.
3476         * python/py-bpevent.c: Do not include py-ref.h.
3477         * python/py-cmd.c: Do not include py-ref.h.
3478         * python/py-continueevent.c: Do not include py-ref.h.
3479         * python/py-event.h: Do not include py-ref.h.
3480         * python/py-evtregistry.c: Do not include py-ref.h.
3481         * python/py-finishbreakpoint.c: Do not include py-ref.h.
3482         * python/py-frame.c: Do not include py-ref.h.
3483         * python/py-framefilter.c: Do not include py-ref.h.
3484         * python/py-function.c: Do not include py-ref.h.
3485         * python/py-infevents.c: Do not include py-ref.h.
3486         * python/py-linetable.c: Do not include py-ref.h.
3487         * python/py-objfile.c: Do not include py-ref.h.
3488         * python/py-param.c: Do not include py-ref.h.
3489         * python/py-prettyprint.c: Do not include py-ref.h.
3490         * python/py-progspace.c: Do not include py-ref.h.
3491         * python/py-symbol.c: Do not include py-ref.h.
3492         * python/py-symtab.c: Do not include py-ref.h.
3493         * python/py-type.c: Do not include py-ref.h.
3494         * python/py-unwind.c: Do not include py-ref.h.
3495         * python/py-utils.c: Do not include py-ref.h.
3496         * python/py-value.c: Do not include py-ref.h.
3497         * python/py-varobj.c: Do not include py-ref.h.
3498         * python/py-xmethods.c: Do not include py-ref.h.
3499         * python/python.c: Do not include py-ref.h.
3500         * varobj.c: Do not include py-ref.h.
3501
3502 2019-01-22  Tom Tromey  <tom@tromey.com>
3503
3504         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
3505         keyword for bcache.
3506
3507 2019-01-22  Tom Tromey  <tom@tromey.com>
3508
3509         * compile/compile-cplus-types.c: Remove a comment by #include.
3510
3511 2019-01-22  Tom Tromey  <tom@tromey.com>
3512
3513         * compile/gcc-c-plugin.h: Include compile-internal.h.
3514
3515 2019-01-22  Tom Tromey  <tom@tromey.com>
3516
3517         * stabsread.c (EXTERN): Do not define.
3518         (symnum, next_symbol_text_func, processing_gcc_compilation)
3519         (within_function, global_sym_chain, global_stabs)
3520         (previous_stab_code, this_object_header_files)
3521         (n_this_object_header_files)
3522         (n_allocated_this_object_header_files): Define.
3523         * stabsread.h (EXTERN): Never define.  Use "extern".
3524
3525 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3526
3527         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
3528         history_value.
3529
3530 2019-01-21  Tom Tromey  <tom@tromey.com>
3531
3532         * ui-out.c: Fix includes.
3533         * tui/tui-source.c: Fix includes.
3534         * target.c: Fix includes.
3535         * remote.c: Fix includes.
3536         * regcache.c: Fix includes.
3537         * python/py-block.c: Fix includes.
3538         * printcmd.c: Fix includes.
3539         * or1k-tdep.c: Fix includes.
3540         * mi/mi-main.c: Fix includes.
3541         * m32r-tdep.c: Fix includes.
3542         * csky-tdep.c: Fix includes.
3543         * compile/compile-cplus-types.c: Fix includes.
3544         * cli/cli-interp.c: Fix includes.
3545
3546 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
3547
3548         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
3549         for padding.
3550
3551 2019-01-16  Tom Tromey  <tom@tromey.com>
3552
3553         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
3554         earlier.
3555         (struct objfile) <msymbols_range>: Move from top level.
3556         <msymbols>: New method.
3557         (class objfile_msymbols): Remove.
3558         * symtab.c (default_collect_symbol_completion_matches_break_on):
3559         Update.
3560         * symmisc.c (dump_msymbols): Update.
3561         * stabsread.c (scan_file_globals): Update.
3562         * objc-lang.c (info_selectors_command, info_classes_command)
3563         (find_methods): Update.
3564         * minsyms.c (find_solib_trampoline_target): Update.
3565         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
3566         * coffread.c (coff_symfile_read): Update.
3567         * ada-lang.c (ada_lookup_simple_minsym)
3568         (ada_collect_symbol_completion_matches): Update.
3569
3570 2019-01-16  Tom Tromey  <tom@tromey.com>
3571
3572         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
3573         type.  Remove no-argument constructor.
3574         <iterator::operator++>: Simplify.
3575         <begin>: Update.
3576         <end>: Use minimal_symbol_count.
3577
3578 2019-01-16  Tom Tromey  <tom@tromey.com>
3579
3580         * objfiles.h (struct objfile) <psymtabs>: New method.
3581         (class objfile_psymtabs): Remove.
3582         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
3583         typedef.
3584         <range>: New method.
3585         (require_partial_symbols): Change return type.
3586         * psymtab.c (require_partial_symbols)
3587         (psym_expand_symtabs_matching): Update.
3588         * mdebugread.c (parse_partial_symbols): Update.
3589         * dbxread.c (dbx_end_psymtab): Update.
3590
3591 2019-01-15  Tom Tromey  <tom@tromey.com>
3592
3593         * symtab.c (lookup_objfile_from_block)
3594         (lookup_symbol_in_objfile_symtabs)
3595         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
3596         (find_line_symtab, info_sources_command)
3597         (default_collect_symbol_completion_matches_break_on)
3598         (make_source_files_completion_list): Update.
3599         * symmisc.c (print_objfile_statistics, dump_objfile)
3600         (maintenance_print_symbols, maintenance_info_symtabs)
3601         (maintenance_check_symtabs, maintenance_info_line_tables):
3602         Update.
3603         * source.c (select_source_symtab)
3604         (forget_cached_source_info_for_objfile): Update.
3605         * objfiles.h (class objfile_compunits): Remove.
3606         (struct objfile) <compunits_range>: New typedef.
3607         (compunits): New method.
3608         * objfiles.c (objfile_relocate1): Update.
3609         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
3610         * maint.c (count_symtabs_and_blocks): Update.
3611         * linespec.c (iterate_over_all_matching_symtabs): Update.
3612         * cp-support.c (add_symbol_overload_list_qualified): Update.
3613         * coffread.c (coff_symtab_read): Update.
3614         * ada-lang.c (add_nonlocal_symbols)
3615         (ada_collect_symbol_completion_matches)
3616         (ada_add_global_exceptions): Update.
3617
3618 2019-01-15  Tom Tromey  <tom@tromey.com>
3619
3620         * progspace.h (program_space) <objfiles_safe_range>: New
3621         typedef.
3622         <objfiles_safe>: New method.
3623         * objfiles.h (class all_objfiles_safe): Remove.
3624         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
3625         * jit.c (jit_inferior_exit_hook): Update.
3626
3627 2019-01-17  Tom Tromey  <tom@tromey.com>
3628
3629         * progspace.h (program_space) <objfiles_range>: New typedef.
3630         <objfiles>: New method.
3631         <objfiles_head>: Rename from objfiles.
3632         (object_files): Update.
3633         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
3634         * guile/scm-pretty-print.c
3635         (ppscm_find_pretty_printer_from_objfiles): Update.
3636         * guile/scm-objfile.c (gdbscm_objfiles): Update.
3637         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
3638         Update.
3639         * python/py-progspace.c (pspy_get_objfiles): Update.
3640         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3641         Update.
3642         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3643         (objfpy_lookup_objfile_by_build_id): Update.
3644         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
3645         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3646         Update.
3647         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3648         (expand_symtab_containing_pc, lookup_objfile_from_block)
3649         (lookup_static_symbol, basic_lookup_transparent_type)
3650         (find_pc_sect_compunit_symtab, find_symbol_at_address)
3651         (find_line_symtab, info_sources_command)
3652         (default_collect_symbol_completion_matches_break_on)
3653         (make_source_files_completion_list, find_main_name): Update.
3654         * symmisc.c (print_symbol_bcache_statistics)
3655         (print_objfile_statistics, maintenance_print_symbols)
3656         (maintenance_print_msymbols, maintenance_print_objfiles)
3657         (maintenance_info_symtabs, maintenance_check_symtabs)
3658         (maintenance_expand_symtabs, maintenance_info_line_tables):
3659         Update.
3660         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
3661         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
3662         (map_overlay_command, unmap_overlay_command)
3663         (simple_overlay_update, expand_symtabs_matching)
3664         (map_symbol_filenames): Update.
3665         * symfile-debug.c (set_debug_symfile): Update.
3666         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
3667         Update.
3668         * source.c (select_source_symtab, forget_cached_source_info):
3669         Update.
3670         * solib.c (solib_read_symbols): Update.
3671         * solib-spu.c (append_ocl_sos): Update.
3672         * psymtab.c (maintenance_print_psymbols)
3673         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
3674         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
3675         * printcmd.c (info_symbol_command): Update.
3676         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
3677         Update.
3678         * objfiles.h (class all_objfiles): Remove.
3679         * objfiles.c (have_partial_symbols, have_full_symbols)
3680         (have_minimal_symbols, qsort_cmp, update_section_map)
3681         (shared_objfile_contains_address_p)
3682         (default_iterate_over_objfiles_in_search_order): Update.
3683         * objc-lang.c (info_selectors_command, info_classes_command)
3684         (find_methods): Update.
3685         * minsyms.c (find_solib_trampoline_target): Update.
3686         * maint.c (maintenance_info_sections)
3687         (maintenance_translate_address, count_symtabs_and_blocks):
3688         Update.
3689         * main.c (captured_main_1): Update.
3690         * linux-thread-db.c (try_thread_db_load_from_pdir)
3691         (has_libpthread): Update.
3692         * linespec.c (iterate_over_all_matching_symtabs)
3693         (search_minsyms_for_name): Update.
3694         * jit.c (jit_find_objf_with_entry_addr): Update.
3695         * hppa-tdep.c (find_unwind_entry)
3696         (hppa_lookup_stub_minimal_symbol): Update.
3697         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
3698         Update.
3699         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3700         (elf_gnu_ifunc_resolve_by_got): Update.
3701         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
3702         * dwarf-index-write.c (save_gdb_index_command): Update.
3703         * cp-support.c (add_symbol_overload_list_qualified): Update.
3704         * breakpoint.c (create_overlay_event_breakpoint)
3705         (create_longjmp_master_breakpoint)
3706         (create_std_terminate_master_breakpoint)
3707         (create_exception_master_breakpoint): Update.
3708         * blockframe.c (find_pc_partial_function): Update.
3709         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
3710         (ada_collect_symbol_completion_matches)
3711         (ada_add_global_exceptions): Update.
3712
3713 2019-01-17  Tom Tromey  <tom@tromey.com>
3714
3715         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
3716         declare VEC.
3717         (solib_target_parse_libraries): Change return type.
3718         (library_list_start_segment, library_list_start_section)
3719         (library_list_end_library, library_list_start_library); Update.
3720         (solib_target_free_library_list): Remove.
3721         (solib_target_parse_libraries): Remove cleanup.  Change return
3722         type.
3723         (solib_target_current_sos): Update.
3724
3725 2019-01-17  Tom Tromey  <tromey@bapiya>
3726
3727         * valprint.c: Replace "the the" with "the".
3728         * symtab.c: Replace "the the" with "the".
3729         * solib.c: Replace "the the" with "the".
3730         * solib-dsbt.c: Replace "the the" with "the".
3731         * linespec.c: Replace "the the" with "the".
3732         * dwarf2loc.h: Replace "the the" with "the".
3733         * amd64-windows-tdep.c: Replace "the the" with "the".
3734         * aarch64-tdep.c: Replace "the the" with "the".
3735
3736 2019-01-16  Keith Seitz  <keiths@redhat.com>
3737
3738         PR gdb/23773
3739         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
3740         <builder>: Rename to ..
3741         <m_builder>: ... this and make private.
3742         (dwarf2_cu::get_builder): New method.  Change all users of
3743         `builder' to use this method.
3744         (dwarf2_start_symtab): Move to ...
3745         (dwarf2_cu::start_symtab): ... here.  Update all callers
3746         (setup_type_unit_groups): Move to ...
3747         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
3748         callers.
3749         (dwarf2_cu::reset_builder): New method.
3750         (process_full_compunit, process_full_type_unit): Use
3751         dwarf2_cu::reset_builder.
3752         (follow_die_offset): Record the ancestor CU if it is different
3753         from the followed DIE's CU.
3754         (follow_die_sig_1): Likewise.
3755
3756 2019-01-15  Tom Tromey  <tom@tromey.com>
3757
3758         * remote.c (class remote_state) <buf>: Now a char_vector.
3759         <buf_size>: Remove.
3760         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
3761         parameter.
3762         (remote_target::getpkt_or_notif_sane_1)
3763         (remote_target::getpkt_sane)
3764         (remote_target::getpkt_or_notif_sane): Likewise.
3765         (class remote_target) <putpkt>: New overload.
3766         (remote_target::read_frame): Change type of "buf_p".  Remove
3767         sizeof_p parameter.
3768         (packet_ok): New overload.
3769         (packet_check_result): New overload.
3770         Update all uses.
3771
3772 2019-01-14  Tom Tromey  <tom@tromey.com>
3773
3774         * remote-notif.c (handle_notification, remote_notif_ack)
3775         (remote_notif_parse): Make "buf" const.
3776         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
3777         const.
3778         (remote_notif_parse, remote_notif_ack, handle_notification):
3779         Likewise.
3780         * remote.c (remote_notif_stop_parse): Make "buf" const.
3781         (remote_target::remote_parse_stop_reply): Make "buf" const.
3782         (remote_notif_stop_ack): Make "buf" const.
3783
3784 2019-01-14  Tom Tromey  <tom@tromey.com>
3785
3786         * remote.c (remote_console_output): Make parameter const.
3787
3788 2019-01-14  Tom Tromey  <tom@tromey.com>
3789
3790         * target-debug.h (target_debug_print_signals): Constify.
3791         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
3792         * procfs.c (procfs_target::pass_signals): Update.
3793         * linux-nat.c (linux_nat_target::pass_signals): Update.
3794         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
3795         * target-delegates.c: Rebuild.
3796         * remote.c (remote_target::program_signals): Update.
3797         (remote_target::pass_signals): Update.
3798         * target.c (target_pass_signals): Constify argument.
3799         (target_program_signals): Likewise.
3800         * target.h (struct target_ops) <pass_signals, program_signals>:
3801         Constify argument.
3802         (target_pass_signals, target_program_signals): Constify argument.
3803
3804 2019-01-14  Tom Tromey  <tom@tromey.com>
3805
3806         PR tui/28819:
3807         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
3808
3809 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3810
3811         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
3812         field.
3813         * rs6000-tdep.c: Include reggroups.h.
3814         (IS_V_ALIAS_PSEUDOREG): Define.
3815         (rs6000_register_name): Return names for the "vX" aliases.
3816         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
3817         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
3818         aliases.  Call default_register_reggroup_p for all other
3819         pseudo-registers.
3820         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
3821         New functions.
3822         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
3823         Handle "vX" aliases.
3824         (v_alias_pseudo_register_collect): New function.
3825         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
3826         (rs6000_gdbarch_init): Initialize "vX" aliases as
3827         pseudo-registers.  Restore registration of
3828         rs6000_pseudo_register_reggroup_p with
3829         set_tdesc_pseudo_register_reggroup_p.
3830
3831 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
3832
3833         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
3834         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
3835         set_gdbarch_num_pseudo_regs.
3836
3837 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3838
3839         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
3840         Remove arg prefixname, add do_set and do_show.
3841         Add member functions set_list and show_list.
3842         * cli/cli-style.c (class cli_style_option): Update accordingly.
3843         (style_set_list): Move to file scope.
3844         (style_show_list): Likewise.
3845         (set_style): Call help_list.
3846         (show_style): Call cmd_show_list.
3847         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
3848         Update to use the new macro.
3849
3850 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
3851
3852         * ada-lang.c (_initialize_ada_language): Expand the help text
3853         for the "catch exception" command.
3854
3855 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3856
3857         * symtab.c (matching_obj_sections): Initialize obj,
3858         declare it closer to its usage.
3859
3860 2019-01-10  Tom Tromey  <tom@tromey.com>
3861
3862         * thread-iter.h (inf_threads_iterator): Use next_iterator.
3863         (basic_inf_threads_range): Remove.
3864         (inf_threads_range, inf_non_exited_threads_range)
3865         (safe_inf_threads_range): Use next_adapter.
3866
3867 2019-01-10  Keith Seitz  <keiths@redhat.com>
3868
3869         PR gdb/23712
3870         PR symtab/23010
3871         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
3872         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
3873
3874 2019-01-10  Keith Seitz  <keiths@redhat.com>
3875
3876         PR gdb/23712
3877         PR symtab/23010
3878         * dictionary.c (pending_to_vector): Remove.
3879         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3880         Remove _1 suffix, replacing functions of the same name.  Update
3881         all callers.
3882         (dict_create_hashed, dict_create_hashed_expandable)
3883         (dict_create_linear, dict_create_linear_expandable, dict_free)
3884         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
3885         Make functions static.
3886
3887 2019-01-10  Keith Seitz  <keiths@redhat.com>
3888
3889         PR gdb/23712
3890         PR symtab/23010
3891         * dictionary.h (struct dictionary): Replace declaration with
3892         multidictionary.
3893         (dict_create_hashed, dict_create_hashed_expandable)
3894         (dict_create_linear, dict_create_linear_expandable)
3895         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
3896         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
3897         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
3898         taking multidictionary argument.
3899         [ALL_DICT_SYMBOLS]: Update for multidictionary.
3900         * block.h (struct block) <dict>: Change to multidictionary
3901         and rename `multidict'.
3902         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
3903         symmisc.c: Update all dictionary references to multidictionary.
3904
3905 2019-01-10  Keith Seitz  <keiths@redhat.com>
3906
3907         PR gdb/23712
3908         PR symtab/23010
3909         * dictionary.c: Include unordered_map.
3910         (pending_to_vector): New function.
3911         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3912         Rewrite the non-"_1" functions to take vector instead
3913         of linked list.
3914         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
3915         "new" _1 versions of the same name.
3916         (multidictionary): Define.
3917         (std::hash<enum language): New definition.
3918         (collate_pending_symbols_by_language, mdict_create_hashed)
3919         (mdict_create_hashed_expandable, mdict_create_linear)
3920         (mdict_create_linear_expandable, mdict_free)
3921         (find_language_dictionary, create_new_language_dictionary)
3922         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
3923         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
3924         (mdict_size, mdict_empty): New functions.
3925         * dictionary.h (mdict_iterator): Define.
3926
3927 2019-01-10  Pedro Alves  <palves@redhat.com>
3928
3929         * breakpoint.c (read_uploaded_action)
3930         (create_tracepoint_from_upload): Adjust to use
3931         gdb::unique_xmalloc_ptr.
3932         * ctf.c (ctf_write_uploaded_tp):
3933         (SET_ARRAY_FIELD): Use emplace_back.
3934         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
3935         * tracefile-tfile.c (tfile_write_uploaded_tp):
3936         * tracepoint.c (parse_tracepoint_definition): Adjust to use
3937         gdb::unique_xmalloc_ptr.
3938         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
3939         at_string, cond_string, cmd_strings>: Replace char pointers
3940         with gdb::unique_xmalloc_ptr.
3941
3942 2019-01-10  Pedro Alves  <palves@redhat.com>
3943
3944         * solib-target.c (library_list_start_library): Don't xstrdup name.
3945
3946 2019-01-10  Pedro Alves  <palves@redhat.com>
3947
3948         * mdebugread.c (parse_partial_symbols): Use
3949         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
3950
3951 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3952
3953         * linux-fork.c (scoped_switch_fork_info)
3954         <~scoped_switch_fork_info>: Fix incorrect variable name.
3955
3956 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3957
3958         * linux-fork.c (scoped_switch_fork_info)
3959         <scoped_switch_fork_info>: Make explicit.
3960         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
3961
3962 2019-01-10  Tom Tromey  <tom@tromey.com>
3963
3964         * objfiles.h (objfile::reset_psymtabs): Update.
3965         * objfiles.c (objfile::objfile): Update.
3966         * psymtab.h (psymtab_storage::obstack): Update.
3967         (psymtab_storage::m_obstack): Use gdb::optional.
3968         (class psymtab_storage): Update comment.  Remove objfile
3969         parameter.
3970         * psymtab.c (psymtab_storage::psymtab_storage): Update.
3971
3972 2019-01-10  Tom Tromey  <tom@tromey.com>
3973
3974         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
3975         <free_psymtabs>: Now private.
3976         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
3977         (allocate_psymtab): Use new method.
3978
3979 2019-01-10  Tom Tromey  <tom@tromey.com>
3980
3981         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
3982         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
3983         * mdebugread.c (parse_partial_symbols): Use
3984         allocate_dependencies.
3985         * dwarf2read.c (dwarf2_create_include_psymtab): Use
3986         allocate_dependencies.
3987         (process_psymtab_comp_unit_reader)
3988         (build_type_psymtab_dependencies): Likewise.
3989         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
3990
3991 2019-01-10  Tom Tromey  <tom@tromey.com>
3992
3993         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
3994         PSYMBOL_SET_LANGUAGE.
3995         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
3996
3997 2019-01-10  Tom Tromey  <tom@tromey.com>
3998
3999         * psymtab.h (psymtab_storage::obstack): New method.
4000         <m_obstack>: Rename from obstack; now private.
4001         * psymtab.c (psymtab_storage): Update.
4002         * dwarf2read.c (create_addrmap_from_index)
4003         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
4004         Update.
4005
4006 2019-01-10  Tom Tromey  <tom@tromey.com>
4007
4008         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
4009         * objfiles.h (objfile::reset_psymtabs): New method.
4010
4011 2019-01-10  Tom Tromey  <tom@tromey.com>
4012
4013         * symmisc.c (print_symbol_bcache_statistics): Update.
4014         (print_objfile_statistics): Update.
4015         * symfile.c (reread_symbols): Update.
4016         * psymtab.h (class psymtab_storage): New.
4017         * psymtab.c (psymtab_storage): New constructor.
4018         (~psymtab_storage): New destructor.
4019         (require_partial_symbols): Update.
4020         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
4021         (find_pc_sect_psymtab, find_pc_sect_psymbol)
4022         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
4023         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
4024         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
4025         (start_psymtab_common, end_psymtab_common)
4026         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
4027         (allocate_psymtab): Update.
4028         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
4029         Update.
4030         (dump_psymtab_addrmap, maintenance_print_psymbols)
4031         (maintenance_check_psymtabs): Update.
4032         (class objfile_psymtabs): Move to objfiles.h.
4033         * psympriv.h (discard_psymtab): Now inline.
4034         (psymtab_discarder::psymtab_discarder): Update.
4035         (psymtab_discarder::~psymtab_discarder): Update.
4036         (ALL_OBJFILE_PSYMTABS): Rewrite.
4037         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
4038         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
4039         Remove fields.
4040         <partial_symtabs>: New field.
4041         (class objfile_psymtabs): Move from psymtab.h.  Update.
4042         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
4043         psymbol_cache.
4044         (objfile::~objfile): Don't destroy psymbol_cache.
4045         * mdebugread.c (parse_partial_symbols): Update.
4046         * dwarf2read.c (create_addrmap_from_index)
4047         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
4048         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
4049         (add_partial_subprogram, dwarf2_ranges_read): Update.
4050         * dwarf-index-write.c (write_address_map)
4051         (write_one_signatured_type, recursively_write_psymbols)
4052         (class debug_names, class debug_names, write_psymtabs_to_index):
4053         Update.
4054
4055 2019-01-10  Tom Tromey  <tom@tromey.com>
4056
4057         * symtab.h (SYMBOL_SET_NAMES): Update.
4058         (symbol_set_names): Update.
4059         (MSYMBOL_SET_NAMES): Update.
4060         * symtab.c (symbol_set_names): Change argument to be an
4061         objfile_per_bfd_storage.
4062         * psymtab.c (add_psymbol_to_bcache): Update.
4063         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
4064
4065 2019-01-10  Tom Tromey  <tom@tromey.com>
4066
4067         * symtab.c (create_demangled_names_hash): Change argument to be an
4068         objfile_per_bfd_storage.
4069         (symbol_set_names): Update.
4070
4071 2019-01-10  Tom Tromey  <tom@tromey.com>
4072
4073         * xcoffread.c (xcoff_initial_scan): Unconditionally call
4074         init_psymbol_list.
4075         * psymtab.c (init_psymbol_list): Do nothing if already called.
4076         * psympriv.h (init_psymbol_list): Add comment.
4077         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
4078         init_psymbol_list.
4079         * dbxread.c (dbx_symfile_read): Unconditionally call
4080         init_psymbol_list.
4081
4082 2019-01-10  Tom Tromey  <tom@tromey.com>
4083
4084         * xcoffread.c (scan_xcoff_symtab): Update.
4085         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
4086         "where".
4087         * mdebugread.c (parse_partial_symbols)
4088         (handle_psymbol_enumerators): Update.
4089         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
4090         * dbxread.c (read_dbx_symtab): Update.
4091         * psympriv.h (psymbol_placement): New enum.
4092         (add_psymbol_to_list): Update.
4093
4094 2019-01-10  Tom Tromey  <tom@tromey.com>
4095
4096         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
4097         static_psymbols parameters.
4098         (scan_xcoff_symtab): Update.
4099         * psymtab.c (start_psymtab_common): Remove global_psymbols and
4100         static_psymbols parameters.
4101         * psympriv.h (start_psymtab_common): Update.
4102         * mdebugread.c (parse_partial_symbols): Update.
4103         * dwarf2read.c (create_partial_symtab): Update.
4104         * dbxread.c (read_dbx_symtab): Update.
4105         (start_psymtab): Remove global_psymbols and static_psymbols
4106         parameters.
4107
4108 2019-01-10  Tom Tromey  <tom@tromey.com>
4109
4110         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
4111         * psymtab.c (allocate_psymtab): Add comment.
4112         * psympriv.h (allocate_psymtab): Add comment.
4113         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
4114         initializations.
4115         * dbxread.c (dbx_end_psymtab): Remove some initializations.
4116
4117 2019-01-10  Tom Tromey  <tom@tromey.com>
4118
4119         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4120         Don't declare.
4121         * mipsread.c: Include mdebugread.h.
4122         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4123         Declare.
4124         * elfread.c: Include mdebugread.h.
4125
4126 2019-01-09  Tom Tromey  <tom@tromey.com>
4127
4128         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
4129         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
4130         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
4131         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
4132         (psym_lookup_symbol, psym_find_last_source_symtab)
4133         (psym_forget_cached_source_info, psym_print_stats)
4134         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
4135         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
4136         (psym_map_matching_symbols, psym_expand_symtabs_matching)
4137         (psym_find_compunit_symtab_by_address)
4138         (maintenance_print_psymbols, maintenance_info_psymtabs)
4139         (maintenance_check_psymtabs): Use ranged for.
4140         * psymtab.h (class objfile_psymtabs): New.
4141         (require_partial_symbols): Return objfile_psymtabs.
4142         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
4143
4144 2019-01-09  Tom Tromey  <tom@tromey.com>
4145
4146         * symfile.c (overlay_invalidate_all, find_pc_overlay)
4147         (find_pc_mapped_section, list_overlays_command)
4148         (map_overlay_command, unmap_overlay_command)
4149         (simple_overlay_update): Use all_objfiles.
4150         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
4151         * printcmd.c (info_symbol_command): Use all_objfiles.
4152         * objfiles.h (ALL_OBJSECTIONS): Remove.
4153         * maint.c (maintenance_translate_address): Use all_objfiles.
4154         * gcore.c (gcore_create_callback): Use all_objfiles.
4155         (objfile_find_memory_regions): Likewise.
4156
4157 2019-01-09  Tom Tromey  <tom@tromey.com>
4158
4159         * symtab.c (find_line_symtab, info_sources_command)
4160         (make_source_files_completion_list): Use objfile_compunits.
4161         * source.c (select_source_symtab): Use objfile_compunits.
4162         * objfiles.h (struct objfile): Update comment.
4163         (ALL_OBJFILES): Remove.
4164         (ALL_FILETABS): Remove.
4165         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
4166         objfile_compunits.
4167
4168 2019-01-09  Tom Tromey  <tom@tromey.com>
4169
4170         * symmisc.c (print_objfile_statistics, dump_objfile)
4171         (maintenance_print_symbols): Use compunit_filetabs.
4172         * source.c (forget_cached_source_info_for_objfile): Use
4173         compunit_filetabs.
4174         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
4175         (ALL_FILETABS): Use compunit_filetabs.
4176         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
4177         * coffread.c (coff_symtab_read): Use compunit_filetabs.
4178
4179 2019-01-09  Tom Tromey  <tom@tromey.com>
4180
4181         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
4182         (compunit_filetabs): New.
4183         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
4184         compunit_filetabs.
4185         (info_sources_command, make_source_files_completion_list): Remove
4186         declaration.
4187         * symmisc.c (print_objfile_statistics, dump_objfile)
4188         (maintenance_print_symbols): Remove declaration.
4189         (maintenance_info_symtabs): Use compunit_filetabs.
4190         (maintenance_info_line_tables): Likewise.
4191         * source.c (select_source_symtab): Change local variable name.
4192         (forget_cached_source_info_for_objfile): Remove declaration.
4193         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
4194         * objfiles.c (objfile_relocate1): Remove declaration.
4195         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4196         declaration.
4197         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
4198         * coffread.c (coff_symtab_read): Remove declaration.
4199         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
4200         compunit_filetabs.
4201
4202 2019-01-09  Tom Tromey  <tom@tromey.com>
4203
4204         * symtab.c (lookup_objfile_from_block)
4205         (find_pc_sect_compunit_symtab, search_symbols)
4206         (default_collect_symbol_completion_matches_break_on): Use
4207         objfile_compunits.
4208         * objfiles.h (ALL_COMPUNITS): Remove.
4209         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
4210         * cp-support.c (add_symbol_overload_list_qualified): Use
4211         objfile_compunits.
4212         * ada-lang.c (ada_collect_symbol_completion_matches)
4213         (ada_add_global_exceptions): Use objfile_compunits.
4214
4215 2019-01-09  Tom Tromey  <tom@tromey.com>
4216
4217         * source.c (select_source_symtab)
4218         (forget_cached_source_info_for_objfile): Remove declaration.
4219         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4220         declaration.
4221         * maint.c (count_symtabs_and_blocks): Remove declaration.
4222         * cp-support.c (add_symbol_overload_list_qualified): Remove
4223         declaration.
4224         * coffread.c (coff_symtab_read): Remove declaration.
4225         * symtab.c (lookup_symbol_in_objfile_symtabs)
4226         (basic_lookup_transparent_type_1): Use objfile_compunits.
4227         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
4228         (info_sources_command, search_symbols)
4229         (default_collect_symbol_completion_matches_break_on)
4230         (make_source_files_completion_list): Remove declaration.
4231         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
4232         (ada_collect_symbol_completion_matches)
4233         (ada_add_global_exceptions): Remove declaration.
4234         * linespec.c (iterate_over_all_matching_symtabs): Use
4235         objfile_compunits.
4236         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
4237         (class objfile_compunits): New.
4238         (ALL_COMPUNITS): Use objfile_compunits.
4239         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
4240         (maintenance_check_symtabs, maintenance_info_line_tables): Use
4241         objfile_compunits.
4242         * objfiles.c (objfile_relocate1): Use objfile_compunits.
4243
4244 2019-01-09  Tom Tromey  <tom@tromey.com>
4245
4246         * symtab.c (search_symbols)
4247         (default_collect_symbol_completion_matches_break_on): Use
4248         objfile_msymbols.
4249         * ada-lang.c (ada_lookup_simple_minsym)
4250         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
4251         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
4252         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
4253         objfile_msymbols.
4254         * coffread.c (coff_symfile_read): Use objfile_msymbols.
4255         * symmisc.c (dump_msymbols): Use objfile_msymbols.
4256         * objc-lang.c (find_methods): Use objfile_msymbols.
4257         (info_selectors_command, info_classes_command): Likewise.
4258         * stabsread.c (scan_file_globals): Use objfile_msymbols.
4259         * objfiles.h (class objfile_msymbols): New.
4260         (ALL_OBJFILE_MSYMBOLS): Remove.
4261         (ALL_MSYMBOLS): Remove.
4262
4263 2019-01-09  Tom Tromey  <tom@tromey.com>
4264
4265         * common/next-iterator.h (next_adapter): Add Iterator template
4266         parameter.
4267         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
4268         (class all_objfiles_safe): New.
4269         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
4270         * objfiles.c (put_objfile_before): Update comment.
4271         (add_separate_debug_objfile): Likewise.
4272         (free_all_objfiles): Use all_objfiles_safe.
4273         (objfile_purge_solibs): Likewise.
4274
4275 2019-01-09  Tom Tromey  <tom@tromey.com>
4276
4277         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4278         (expand_symtab_containing_pc, lookup_static_symbol)
4279         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
4280         (find_symbol_at_address, find_line_symtab, find_main_name): Use
4281         all_objfiles.
4282         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
4283         * breakpoint.c (create_overlay_event_breakpoint)
4284         (create_longjmp_master_breakpoint)
4285         (create_std_terminate_master_breakpoint)
4286         (create_exception_master_breakpoint): Use all_objfiles.
4287         * linux-thread-db.c (try_thread_db_load_from_pdir)
4288         (has_libpthread): Use all_objfiles.
4289         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
4290         * linespec.c (iterate_over_all_matching_symtabs)
4291         (search_minsyms_for_name): Use all_objfiles.
4292         * maint.c (maintenance_info_sections): Use all_objfiles.
4293         * main.c (captured_main_1): Use all_objfiles.
4294         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
4295         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
4296         * guile/scm-pretty-print.c
4297         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
4298         * solib-spu.c (append_ocl_sos): Use all_objfiles.
4299         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
4300         (maintenance_print_msymbols): Use all_objfiles.
4301         * source.c (select_source_symtab): Use all_objfiles.
4302         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
4303         * symfile.c (remove_symbol_file_command)
4304         (expand_symtabs_matching, map_symbol_filenames): Use
4305         all_objfiles.
4306         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
4307         all_objfiles.
4308         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
4309         * objc-lang.c (find_methods): Use all_objfiles.
4310         * objfiles.c (have_partial_symbols, have_full_symbols)
4311         (have_minimal_symbols, qsort_cmp)
4312         (default_iterate_over_objfiles_in_search_order): Use
4313         all_objfiles.
4314         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
4315         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
4316         (maintenance_check_psymtabs): Use all_objfiles.
4317         (ALL_PSYMTABS): Remove.
4318         * compile/compile-object-run.c (do_module_cleanup): Use
4319         all_objfiles.
4320         * blockframe.c (find_pc_partial_function): Use all_objfiles.
4321         * cp-support.c (add_symbol_overload_list_qualified): Use
4322         all_objfiles.
4323         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
4324         Use all_objfiles.
4325         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
4326         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
4327         all_objfiles.
4328         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4329         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
4330         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4331         Uses all_objfiles.
4332         * solib.c (solib_read_symbols): Use all_objfiles
4333
4334 2019-01-09  Tom Tromey  <tom@tromey.com>
4335
4336         * probe.c (parse_probes_in_pspace): Use all_objfiles.
4337         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
4338         all_objfiles.
4339         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
4340         * symmisc.c (print_symbol_bcache_statistics)
4341         (print_objfile_statistics, maintenance_print_objfiles)
4342         (maintenance_info_symtabs, maintenance_check_symtabs)
4343         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
4344         all_objfiles.
4345         * source.c (forget_cached_source_info): Use all_objfiles.
4346         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
4347         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
4348         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
4349         * objfiles.c (update_section_map): Use all_objfiles.
4350         (shared_objfile_contains_address_p): Likewise.
4351         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
4352         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
4353
4354 2019-01-09  Tom Tromey  <tom@tromey.com>
4355
4356         * common/next-iterator.h: New file.
4357         * objfiles.h (class all_objfiles): New.
4358         (struct objfile_iterator): New.
4359
4360 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4361
4362         * NEWS: Move the description of the changed "frame", "select-frame",
4363          and "info frame" commands to the Changed commands section.
4364
4365 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
4366
4367         * gdbtypes.c (check_stub_method_group): Remove handling of old
4368         mangling schemes.
4369         * linespec.c (find_methods): Likewise.
4370         * stabsread.c (read_member_functions): Likewise.
4371         * valops.c (search_struct_method): Likewise.
4372         (value_struct_elt_for_reference): Likewise.
4373         * NEWS: Mention this change.
4374
4375 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4376
4377         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
4378         print_source_lines.
4379         * source.c (print_source_lines_base): Update line number check.
4380         (print_source_lines): New function.
4381         (source_lines_range::source_lines_range): New function.
4382         * source.h (class source_lines_range): New class.
4383         (print_source_lines): New declaration.
4384
4385 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4386
4387         * linespec.c (linespec_state_destructor): Free self->canonical_names.
4388
4389 2019-01-08  Tom Tromey  <tom@tromey.com>
4390             Simon Marchi  <simon.marchi@ericsson.com>
4391
4392         PR gdb/24060
4393         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
4394         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
4395         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
4396         * f-exp.y (DOLLAR_VARIABLE): Likewise.
4397         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
4398         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
4399
4400 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4401
4402         * source.c (select_source_symtab): Move header comment to
4403         declaration in source.h.
4404         (forget_cached_source_info_for_objfile): Likewise.
4405         (forget_cached_source_info): Likewise.
4406         (identify_source_line): Likewise.
4407         * source.h (identify_source_line): Move declaration from symtab.h
4408         and add comment from source.c
4409         (print_source_lines): Likewise.
4410         (forget_cached_source_info_for_objfile): Likewise.
4411         (forget_cached_source_info): Likewise.
4412         (select_source_symtab): Likewise.
4413         (enum print_source_lines_flag): Move definition from symtab.h.
4414         * symtab.h (identify_source_line): Move declaration to source.h.
4415         (print_source_lines): Likewise.
4416         (forget_cached_source_info_for_objfile): Likewise.
4417         (forget_cached_source_info): Likewise.
4418         (select_source_symtab): Likewise.
4419         (enum print_source_lines_flag): Move definition to source.h.
4420         * tui/tui-hooks.c: Add 'source.h' include.
4421
4422 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4423
4424         * source.c (print_source_lines_base): Handle requests to print
4425         reverse line number sequences, and guard against empty lines
4426         string.
4427
4428 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4429
4430         * source.c (print_source_lines_base): Fix skip of '\r' if next
4431         character is '\n'.
4432
4433 2019-01-06  Tom Tromey  <tom@tromey.com>
4434
4435         * c-exp.y (struct c_parse_state) <macro_original_text,
4436         expansion_obstack>: New member.
4437         (macro_original_text, expansion_obstack): Remove globals.
4438         (scan_macro_expansion, scanning_macro_expansion)
4439         (finished_macro_expansion): Update.
4440         (scan_macro_cleanup): Remove.
4441         (yylex, c_parse): Update.
4442
4443 2019-01-06  Tom Tromey  <tom@tromey.com>
4444
4445         * c-exp.y (struct c_parse_state) <strings>: New member.
4446         (operator_stoken): Update.
4447
4448 2019-01-06  Tom Tromey  <tom@tromey.com>
4449
4450         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
4451         (union type_stack_elt) <typelist_val>: Now a pointer to
4452         std::vector.
4453         (type_stack_cleanup): Don't declare.
4454         (push_typelist): Update.
4455         * parse.c (pop_typelist): Return a std::vector.
4456         (push_typelist): Take a std::vector.
4457         (follow_types): Update.  Do not free args.
4458         (type_stack_cleanup): Remove.
4459         * c-exp.y (struct c_parse_state): New.
4460         (cpstate): New global.
4461         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
4462         (nonempty_typelist): Update.
4463         (func_mod): Create a new vector.
4464         (c_parse): Create a c_parse_state.
4465         (check_parameter_typelist): Do not delete params.
4466         (function_method): Update.  Do not delete type_list.
4467
4468 2019-01-06  Tom Tromey  <tom@tromey.com>
4469
4470         PR gdb/28155:
4471         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
4472         check_typedef.
4473         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
4474         (print_return_value): Likewise.
4475
4476 2019-01-05  Tom Tromey  <tom@tromey.com>
4477
4478         * contrib/cleanup_check.py: Remove.
4479         * contrib/gcc-with-excheck: Remove.
4480         * contrib/exsummary.py: Remove.
4481         * contrib/excheck.py: Remove.
4482
4483 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
4484
4485         * thread.c (delete_thread_1): Add gdb_assert that THR is not
4486         NULL. Initialize tpprev to NULL instead of assigning it
4487         to NULL on the next statement.
4488         * windows-nat.c (windows_delete_thread): Remove check for
4489         main_thread_id before printing thread exit notifications.
4490         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
4491         Remove thread ID check against main_thread_id.
4492         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
4493         windows_delete_thread.
4494         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
4495
4496 2019-01-04  Tom Tromey  <tom@tromey.com>
4497
4498         * compile/compile.c (_initialize_compile): Use upper case for
4499         metasyntactic variables.
4500         * symmisc.c (_initialize_symmisc): Use upper case for
4501         metasyntactic variables.
4502         * psymtab.c (_initialize_psymtab): Use upper case for
4503         metasyntactic variables.
4504         * demangle.c (demangle_command): Use upper case for metasyntactic
4505         variables.
4506         (_initialize_demangler): Likewise.
4507         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
4508         variables.
4509
4510 2019-01-03  Tom Tromey  <tom@tromey.com>
4511
4512         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
4513
4514 2019-01-03  Tom Tromey  <tom@tromey.com>
4515
4516         * python/py-symtab.c (salpy_str): Update.
4517         (struct salpy_sal_object) <symtab>: Now a PyObject.
4518         (salpy_dealloc): Update.
4519         (del_objfile_sal): Use gdbpy_ref.
4520
4521 2019-01-03  Tom Tromey  <tom@tromey.com>
4522
4523         * python/py-type.c (convert_field): Use new_reference.  Return
4524         gdbpy_ref.
4525         (make_fielditem): Return gdbpy_ref.
4526         (typy_fields): Update.
4527         (typy_getitem): Update.
4528         (field_name): Return gdbpy_ref.  Use new_reference.
4529         (typy_iterator_iternext): Update.
4530
4531 2019-01-03  Tom Tromey  <tom@tromey.com>
4532
4533         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
4534
4535 2019-01-03  Tom Tromey  <tom@tromey.com>
4536
4537         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
4538         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
4539         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
4540         (pspy_set_frame_filters, pspy_set_frame_unwinders)
4541         (pspy_set_type_printers): Likewise.
4542         * python/py-function.c (fnpy_init): Use gdbpy_ref.
4543         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
4544         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
4545         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
4546         (objfpy_set_type_printers): Likewise.
4547
4548 2019-01-03  Tom Tromey  <tom@tromey.com>
4549
4550         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
4551         (gdbpy_print_stack): Use gdbpy_err_fetch.
4552         * python/python-internal.h (class gdbpy_err_fetch): New class.
4553         (class gdbpy_enter) <m_error_type, m_error_value,
4554         m_error_traceback>: Remove.
4555         <m_error>: New member.
4556         (gdbpy_exception_to_string): Don't declare.
4557         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
4558         * python/py-value.c (convert_value_from_python): Use
4559         gdbpy_err_fetch.
4560         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
4561         gdbpy_exception_to_string.
4562         (gdbpy_handle_exception): Use gdbpy_err_fetch.
4563         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
4564         gdbpy_err_fetch.
4565
4566 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4567
4568         * linux-nat.c (delete_lwp_cleanup): Delete.
4569         (struct lwp_deleter): New struct.
4570         (lwp_info_up): New typedef.
4571         (linux_nat_target::follow_fork): Delete cleanup, and make use of
4572         lwp_info_up.
4573
4574 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4575
4576         * linux-fork.c (class scoped_switch_fork_info): New class.
4577         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
4578
4579 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4580
4581         * valops.c (find_overload_match): Remove use of null_cleanup, and
4582         calls to do_cleanups.
4583
4584 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4585
4586         * compile/compile-cplus-types.c
4587         (compile_cplus_instance::decl_name): Handle changes to
4588         cp_func_name.
4589         * cp-support.c (cp_func_name): Update header comment, update
4590         return type.
4591         * cp-support.h (cp_func_name): Update return type in declaration.
4592         * valops.c (find_overload_match): Move temp_func local to top
4593         level of function and change its type.  Use temp_func to hold and
4594         delete temporary string obtained from cp_func_name.
4595
4596 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4597
4598         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
4599         gdb::char_vector, remove cleanup, and update uses of `msg`.
4600
4601 2019-01-03  Jim Wilson  <jimw@sifive.com>
4602
4603         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
4604
4605 2019-01-02  Tom Tromey  <tom@tromey.com>
4606
4607         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
4608         (tdesc_parse_xml): Remove cleanups.
4609         * target-descriptions.h (make_cleanup_free_target_description):
4610         Don't declare.
4611         (target_desc_deleter): New struct.
4612         (target_desc_up): New typedef.
4613         * target-descriptions.c (target_desc_deleter::operator()): Rename
4614         from free_target_description.
4615         (make_cleanup_free_target_description): Remove.
4616
4617 2019-01-02  Tom Tromey  <tom@tromey.com>
4618
4619         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
4620         constructor, destructor.
4621         (linespec_parser): Remove typedef.
4622         (~linespec_parser): Rename from linespec_parser_delete.
4623         (linespec_lex_to_end, linespec_complete_label)
4624         (linespec_complete): Update.
4625         (decode_line_full): Remove cleanups.
4626         (decode_line_1): Update.
4627
4628 2019-01-02  Tom Tromey  <tom@tromey.com>
4629
4630         * python/python-internal.h (inferior_to_inferior_object): Change
4631         return type.
4632         * python/py-exitedevent.c (create_exited_event_object): Update.
4633         * python/py-inferior.c (inferior_to_inferior_object): Return
4634         gdbpy_ref.
4635         (python_new_inferior, python_inferior_deleted)
4636         (thread_to_thread_object, delete_thread_object)
4637         (build_inferior_list, gdbpy_selected_inferior): Update.
4638         * python/py-infthread.c (create_thread_object): Update.  Also fail
4639         if inferior_to_inferior_object fails.
4640
4641 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
4642
4643         * inferior.h (class inferior) <displaced_step_state>: New field.
4644         * infrun.h (struct displaced_step_state): Move here from
4645         infrun.c.  Initialize fields, add constructor.
4646         <inf>: Remove field.
4647         <reset>: New method.
4648         * infrun.c (struct displaced_step_inferior_state): Move to
4649         infrun.h.
4650         (displaced_step_inferior_states): Remove.
4651         (get_displaced_stepping_state): Adust.
4652         (displaced_step_in_progress_any_inferior): Adjust.
4653         (displaced_step_in_progress_thread): Adjust.
4654         (displaced_step_in_progress): Adjust.
4655         (add_displaced_stepping_state): Remove.
4656         (get_displaced_step_closure_by_addr): Adjust.
4657         (remove_displaced_stepping_state): Remove.
4658         (infrun_inferior_exit): Call displaced_step_state.reset.
4659         (use_displaced_stepping): Don't check for NULL.
4660         (displaced_step_prepare_throw): Call
4661         get_displaced_stepping_state.
4662         (displaced_step_fixup): Don't check for NULL.
4663         (prepare_for_detach): Don't check for NULL.
4664
4665 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4666
4667         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
4668          in case of call that did not complete.
4669
4670 2019-01-02  Andrey Utkin  <autkin@undo.io>
4671
4672         * symfile.c (find_separate_debug_file): Fix search of debug files for
4673         remote debuggee.
4674
4675 2019-01-02  Tom Tromey  <tom@tromey.com>
4676
4677         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
4678         indentation.
4679         * python/py-frame.c (frapy_older): Remove cast.
4680         (frapy_newer): Likewise.
4681         * python/py-breakpoint.c (local_setattro): Remove cast.
4682         * python/py-arch.c (archpy_name): Remove local variable.
4683         * python/py-type.c (gdbpy_lookup_type): Remove cast.
4684
4685 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
4686
4687         * unittests/basic_string_view/element_access/char/empty.cc:
4688         Fix year range in copyright header.
4689
4690 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4691
4692         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
4693         Delete.
4694         <operator==>: Update with for removed field.
4695         <hash>: Likewise.
4696         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
4697         <isa_features>: ...this.
4698         <abi_features>: New field.
4699         (riscv_isa_flen): Update comment.
4700         (riscv_abi_xlen): New declaration.
4701         (riscv_abi_flen): New declaration.
4702         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
4703         isa_features.
4704         (riscv_abi_xlen): New function.
4705         (riscv_isa_flen): Update to get answer from isa_features.
4706         (riscv_abi_flen): New function.
4707         (riscv_has_fp_abi): Update to get answer from abi_features.
4708         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
4709         xlen and flen.
4710         (riscv_call_info) <xlen, flen>: Update comment.
4711         (riscv_call_arg_struct): Remove invalid assertions
4712         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
4713         is removed.
4714         (riscv_gdbarch_init): Gather isa features and abi features
4715         separately, ensure both match on the gdbarch when reusing an old
4716         gdbarch.  Relax an error check to allow 32-bit abi float to run on
4717         a target with 64-bit float hardware.
4718
4719 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4720
4721         * source.c (search_command_helper): Stop reverse search
4722         when line 1 has been searched.
4723
4724 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4725
4726         * record-full.c (record_full_base_target::close): Rewrite
4727         record_full_core_buf_list free logic.
4728
4729 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4730
4731         * break-catch-syscall.c (print_one_catch_syscall): xfree
4732         the last text.
4733
4734 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
4735
4736         * top.c (print_gdb_version): Update Copyright year in version
4737         message.
4738
4739 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
4740
4741         Update copyright year range in all GDB files.
4742
4743 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
4744
4745         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
4746
4747 For older changes see ChangeLog-2018.
4748 \f
4749 Local Variables:
4750 mode: change-log
4751 left-margin: 8
4752 fill-column: 74
4753 version-control: never
4754 coding: utf-8
4755 End:
4756