gdb/ChangeLog

   1 2019-07-17  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-win.c (tui_set_win_height_command): Rename from
   4         tui_set_win_height.
   5         (tui_set_win_height_command): Remove.
   6
   7 2019-07-17  Tom Tromey  <tom@tromey.com>
   8
   9         * tui/tui-source.c (tui_source_window): New constructor.  Add
  10         observer.
  11         (~tui_source_window): New destructor.
  12         (tui_source_window::style_changed): New method.
  13         * tui/tui-hooks.c (tui_redisplay_source): Remove.
  14         (tui_attach_detach_observers): Update.
  15         * tui/tui-data.h (struct tui_source_window): Make constructor not
  16         inline.  Add destructor.
  17         (struct tui_source_window) <style_changed>: New method.
  18         <m_observable>: New member.
  19
  20 2019-07-17  Tom Tromey  <tom@tromey.com>
  21
  22         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
  23         * tui/tui-win.c (tui_resize_all): Fix typo.
  24
  25 2019-07-17  Tom Tromey  <tom@tromey.com>
  26
  27         * tui/tui-wingeneral.h (tui_refresh_all): Update.
  28         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
  29         (tui_refresh_all): Remove "list" parameter.  Use foreach.
  30         * tui/tui-win.c (window_name_completer): Use foreach.
  31         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
  32         (update_tab_width): Likewise.
  33         * tui/tui-layout.c (show_layout): Update.
  34         * tui/tui-data.h (class tui_window_iterator): New.
  35         (struct all_tui_windows): New.
  36         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
  37
  38 2019-07-17  Tom Tromey  <tom@tromey.com>
  39
  40         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
  41         parameter.  Don't reference globals.
  42         (tui_reg_command): Update.
  43
  44 2019-07-17  Tom Tromey  <tom@tromey.com>
  45
  46         * tui/tui-regs.c (tui_show_registers): Simplify.
  47
  48 2019-07-17  Tom Tromey  <tom@tromey.com>
  49
  50         * tui/tui-regs.c (tui_show_registers): Update.
  51         (tui_show_register_group): Add win_info parameter.
  52
  53 2019-07-17  Tom Tromey  <tom@tromey.com>
  54
  55         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
  56         Rename from tui_display_reg_element_at_line.
  57         (tui_data_window::display_registers_from_line): Update.
  58         * tui/tui-data.h (struct tui_data_window)
  59         <display_reg_element_at_line>: New method.
  60
  61 2019-07-17  Tom Tromey  <tom@tromey.com>
  62
  63         * tui/tui-regs.h (tui_display_registers_from)
  64         (tui_display_registers_from_line): Don't declare.
  65         * tui/tui-windata.c (tui_data_window::display_all_data)
  66         (tui_data_window::refresh_all)
  67         (tui_data_window::do_scroll_vertical): Update.
  68         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
  69         from tui_display_registers_from.
  70         (tui_display_reg_element_at_line): Update.
  71         (tui_data_window::display_registers_from_line): Rename from
  72         tui_display_registers_from_line.
  73         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
  74         display_registers_from_line>: New methods.
  75
  76 2019-07-17  Tom Tromey  <tom@tromey.com>
  77
  78         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
  79         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
  80         from tui_erase_data_content.
  81         (tui_data_window::display_all_data)
  82         (tui_data_window::refresh_all)
  83         (tui_data_window::do_scroll_vertical): Update.
  84         * tui/tui-regs.c (tui_show_registers): Update.
  85         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
  86         New method.
  87
  88 2019-07-17  Tom Tromey  <tom@tromey.com>
  89
  90         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
  91         declare.
  92         * tui/tui-windata.c
  93         (tui_data_window::delete_data_content_windows): Rename from
  94         tui_delete_data_content_windows.
  95         (tui_data_window::display_all_data)
  96         (tui_data_window::do_scroll_vertical): Update.
  97         * tui/tui-data.h (struct tui_data_window)
  98         <delete_data_content_windows>: New method.
  99
 100 2019-07-17  Tom Tromey  <tom@tromey.com>
 101
 102         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 103         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 104
 105 2019-07-17  Tom Tromey  <tom@tromey.com>
 106
 107         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 108         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 109         from tui_display_all_data.
 110         * tui/tui-win.c
 111         (tui_data_window::do_make_visible_with_new_height): Update.
 112         * tui/tui-regs.c (tui_show_registers): Update.
 113         * tui/tui-layout.c (tui_set_layout): Update.
 114         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 115         method.
 116
 117 2019-07-17  Tom Tromey  <tom@tromey.com>
 118
 119         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 120         * tui/tui-windata.c (tui_display_data_from): Remove.
 121         (tui_data_window::refresh_all): Update.
 122
 123 2019-07-17  Tom Tromey  <tom@tromey.com>
 124
 125         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 126         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 127         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 128         tui_display_registers_from_line.
 129         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 130         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 131         "force_display" parameter.
 132
 133 2019-07-17  Tom Tromey  <tom@tromey.com>
 134
 135         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 136         declare.
 137         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 138         Rename from tui_first_reg_element_no_inline.
 139         (tui_display_reg_element_at_line)
 140         (tui_display_registers_from_line): Update.
 141         * tui/tui-data.h (struct tui_data_window)
 142         <first_reg_element_no_inline>: New method.
 143
 144 2019-07-17  Tom Tromey  <tom@tromey.com>
 145
 146         * tui/tui-windata.c (tui_display_data_from)
 147         (tui_data_window::do_scroll_vertical): Update.
 148         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 149         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 150         Rename from tui_line_from_reg_element_no.
 151         (tui_display_registers_from_line): Update.
 152         * tui/tui-data.h (struct tui_data_window)
 153         <line_from_reg_element_no>: New method.
 154
 155 2019-07-17  Tom Tromey  <tom@tromey.com>
 156
 157         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 158         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 159         tui_last_regs_line_no.
 160         (tui_display_reg_element_at_line)
 161         (tui_display_registers_from_line): Update.
 162         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 163         method.
 164
 165 2019-07-17  Tom Tromey  <tom@tromey.com>
 166
 167         PR tui/24722:
 168         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 169         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 170         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 171         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 172         (tui_update_breakpoint_info): Likewise.
 173         * tui/tui-hooks.c (tui_event_create_breakpoint)
 174         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 175         Update.
 176
 177 2019-07-17  Tom Tromey  <tom@tromey.com>
 178
 179         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 180
 181 2019-07-17  Tom Tromey  <tom@tromey.com>
 182
 183         * tui/tui-winsource.c (tui_update_source_window_as_is)
 184         (tui_update_source_windows_with_addr): Update.
 185         * tui/tui-source.h (tui_set_source_content)
 186         (tui_show_symtab_source): Add "win_info" parameter.
 187         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 188         parameter.
 189         (tui_show_symtab_source): Likewise.
 190
 191 2019-07-17  Tom Tromey  <tom@tromey.com>
 192
 193         * tui/tui-wingeneral.c
 194         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 195
 196 2019-07-17  Tom Tromey  <tom@tromey.com>
 197
 198         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 199         (struct tui_cmd_window) <can_scroll>: New method.
 200         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 201         method.
 202
 203 2019-07-17  Tom Tromey  <tromey@adacore.com>
 204
 205         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 206         do_field_signed>: Rename.  Change type of "value".
 207         * ui-out.c (ui_out::field_signed): Rename from field_int.
 208         Change type of "value".
 209         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 210         type of "value".
 211         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 212         do_field_int.  Change type of "value".
 213         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 214         do_field_int.  Change type of "value".
 215         * tracepoint.c (trace_status_mi, tfind_1)
 216         (print_one_static_tracepoint_marker): Update.
 217         * thread.c (print_thread_info_1, print_selected_thread_frame):
 218         Update.
 219         * stack.c (print_frame, print_frame_info): Update.
 220         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 221         Update.
 222         * source.c (print_source_lines_base): Update.
 223         * skip.c (info_skip_command): Update.
 224         * record-btrace.c (btrace_ui_out_decode_error)
 225         (btrace_call_history_src_line): Update.
 226         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 227         Update.
 228         * progspace.c (print_program_space): Update.
 229         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 230         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 231         do_field_int.  Change type of "value".
 232         * mi/mi-out.c (mi_ui_out::do_table_begin)
 233         (mi_ui_out::do_table_header): Update.
 234         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 235         type of "value".
 236         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 237         (mi_cmd_data_list_changed_registers, output_register)
 238         (mi_cmd_data_read_memory, mi_load_progress)
 239         (mi_cmd_trace_frame_collected): Update.
 240         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 241         Update.
 242         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 243         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 244         (mi_cmd_var_list_children, varobj_update_one): Update.
 245         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 246         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 247         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 248         * inferior.c (print_inferior): Update.
 249         * gdb_bfd.c (print_one_bfd): Update.
 250         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 251         Update.
 252         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 253         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 254         do_field_int.  Change type of "value".
 255         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 256         do_field_int.  Change type of "value".
 257         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 258         (print_one_breakpoint_location, print_it_catch_fork)
 259         (print_one_catch_fork, print_it_catch_vfork)
 260         (print_one_catch_vfork, print_it_catch_solib)
 261         (print_it_catch_exec, print_it_ranged_breakpoint)
 262         (print_mention_watchpoint, print_mention_masked_watchpoint)
 263         (bkpt_print_it, update_static_tracepoint): Update.
 264         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 265         * break-catch-syscall.c (print_it_catch_syscall): Update.
 266         * ada-tasks.c (print_ada_task_info): Update.
 267         * ada-lang.c (print_it_exception, print_mention_exception):
 268         Update.
 269
 270 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 271
 272         PR breakpoints/24541
 273         * gdbarch.c: Regenerate.
 274         * gdbarch.h: Regenerate.
 275         * gdbarch.sh: Adjust return type and parameter types for
 276         'stap_adjust_register'.
 277         (i386_stap_adjust_register): Adjust signature and return new
 278         register name.
 279         * stap-probe.c (stap_parse_register_operand): Adjust use of
 280         'gdbarch_stap_adjust_register'.
 281
 282 2019-07-17  Tom Tromey  <tromey@adacore.com>
 283
 284         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 285         declare VEC.
 286         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 287         std::vector.
 288         (struct s390_process_info): Add initializers.
 289         (s390_add_process): Use new.
 290         (s390_linux_nat_target::low_forget_process): Use delete.
 291         (s390_linux_nat_target::low_new_fork)
 292         (s390_linux_nat_target::stopped_by_watchpoint)
 293         (s390_linux_nat_target::low_prepare_to_resume)
 294         (s390_linux_nat_target::insert_watchpoint)
 295         (s390_linux_nat_target::insert_hw_breakpoint)
 296         (s390_linux_nat_target::remove_watchpoint)
 297         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 298
 299 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 300
 301         * aarch64-fbsd-nat.c: Include regcache.h.
 302         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 303         argument.
 304         (aarch64_fbsd_nat_target::fetch_registers)
 305         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 306         variable.
 307         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 308
 309 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 310
 311         * fbsd-nat.c: Include gdbarch.h.
 312
 313 2019-07-15  Tom Tromey  <tromey@adacore.com>
 314
 315         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 316
 317 2019-07-15  Tom Tromey  <tromey@adacore.com>
 318
 319         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 320         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 321         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 322         * cli-out.c (cli_ui_out::do_field_int): New method.
 323         * ui-out.c (ui_out::field_unsigned): New method.
 324         * symfile.c (generic_load): Use field_unsigned.
 325         (print_transfer_performance): Likewise.
 326         * record-btrace.c (ui_out_field_uint): Remove.
 327         (btrace_call_history_insn_range, btrace_call_history): Use
 328         field_unsigned.
 329         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 330         field_unsigned.
 331         * ui-out.h (class ui_out) <field_unsigned>: New method.
 332         <do_field_unsigned>: Likewise.
 333
 334 2019-07-15  Tom Tromey  <tromey@adacore.com>
 335
 336         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 337         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 338         * target.c (flash_erase_command): Use field_string.
 339         * infrun.c (print_signal_received_reason): Use field_string.
 340         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 341         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 342         field_string.
 343         * ada-tasks.c (print_ada_task_info): Use field_string.
 344
 345 2019-07-15  Tom Tromey  <tromey@adacore.com>
 346
 347         * target.c (flash_erase_command): Use field_core_addr.
 348         * symfile.c (generic_load): Use field_core_addr.
 349         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 350         Use field_core_addr.
 351         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 352         field_core_addr.
 353
 354 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 355
 356         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 357         value if its desired type is smaller than a CORE_ADDR and signed.
 358
 359 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 360
 361         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 362         of changes to field names, and use new is_reference field to
 363         decide if a property is a reference or not.
 364         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 365         field.
 366         (struct dwarf2_property_baton): Update header comment, rename
 367         'referenced_type' to 'property_type' and update comments.
 368         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 369         default property type, store in property baton, update to take
 370         accound of renamed field.
 371         (read_func_scope): Update call to attr_to_dynamic_prop.
 372         (read_array_type): Likewise.
 373         (dwarf2_per_cu_addr_sized_int_type): New function.
 374         (read_subrange_index_type): Move type finding code to
 375         dwarf2_per_cu_addr_sized_int_type.
 376         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 377         (dwarf2_per_cu_addr_type): New function.
 378         (set_die_type): Update calls to attr_to_dynamic_prop.
 379
 380 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 381
 382         * dwarf2read.c (read_subrange_index_type): New function.
 383         (read_subrange_type): Move code into new function and call it.
 384         * gdbtypes.c (create_range_type): Add some asserts.
 385
 386 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 387
 388         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 389         update return statements.
 390         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 391         declaration, and update comment to match.
 392         * gdbtypes.c (resolve_dynamic_array): Update call to
 393         dwarf2_evaluate_property to match new return type.
 394
 395 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 396
 397         * valarith.c (value_subscripted_rvalue): Change lowerbound
 398         parameter type from int to LONGEST.
 399         * value.h (value_subscripted_rvalue): Likewise in declaration.
 400
 401 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 402
 403         * cli/cli-utils.c (info_print_command_completer): New function.
 404         * cli/cli-utils.h: Add 'completer.h' include, and forward
 405         declaration for 'struct cmd_list_element'.
 406         (info_print_command_completer): Declare.
 407         * stack.c (_initialize_stack): Add completer for 'info locals' and
 408         'info args'.
 409         * symtab.c (_initialize_symtab): Add completer for 'info
 410         variables' and 'info functions'.
 411         * NEWS: Mention completion for additional info commands.
 412
 413 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 414
 415         * cli/cli-utils.c (extract_info_print_args): Delete.
 416         (extract_arg_maybe_quoted): Delete.
 417         (info_print_options_defs): New variable.
 418         (make_info_print_options_def_group): New function.
 419         (extract_info_print_options): Define new function.
 420         * cli/cli-utils.h (extract_info_print_args): Delete.
 421         (struct info_print_options): New structure.
 422         (extract_info_print_options): Declare new function.
 423         * stack.c (info_locals_command): Update to use new
 424         extract_info_print_options, also add a header comment.
 425         (info_args_command): Likewise.
 426         * symtab.c (info_variables_command): Likewise.
 427         (info_functions_command): Likewise.
 428
 429 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 430
 431         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 432         to extract string arguments.
 433         * common/common-utils.c (extract_string_maybe_quoted): New function.
 434         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 435
 436 2019-07-11  Tom Tromey  <tromey@adacore.com>
 437
 438         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 439         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 440         * top.h (gdbinit): Don't declare.
 441         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 442         into...
 443         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 444         * top.c (gdb_init): Don't call init_cli_cmds.
 445         (gdbinit): Remove.
 446         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 447
 448 2019-07-11  Tom Tromey  <tromey@adacore.com>
 449
 450         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 451         after it has been moved.
 452
 453 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 454
 455         * valops.c (value_must_coerce_to_target): Change return type to
 456         bool.
 457         * value.h (value_must_coerce_to_target): Likewise.
 458
 459 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 460
 461         * breakpoint.c (is_hardware_watchpoint): Remove
 462         forward-declaration.
 463         (is_masked_watchpoint): Change return type to bool.
 464         (is_tracepoint): Likewise.
 465         (is_breakpoint): Likewise.
 466         (is_hardware_watchpoint): Likewise.
 467         (is_watchpoint): Likewise.
 468         (is_no_memory_software_watchpoint): Likewise.
 469         (is_catchpoint): Likewise.
 470         (breakpoint_1): Make FILTER parameter's return type bool.
 471         is_masked_watchpoint): Change return type to bool.
 472         (save_breakpoints): Make FILTER parameter's return type bool.
 473         * breakpoint.h (is_breakpoint): Change return type to bool.
 474         (is_watchpoint): Likewise.
 475         (is_catchpoint): Likewise.
 476         (is_tracepoint): Likewise.
 477
 478 2019-07-10  Tom Tromey  <tom@tromey.com>
 479
 480         * defs.h: Don't include gdbarch.h.
 481         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 482         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 483         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 484         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 485         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 486         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 487         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 488         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 489         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 490         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 491         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 492         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 493         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 494         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 495         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 496         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 497         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 498         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 499         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 500         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 501         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 502         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 503         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 504         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 505         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 506         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 507         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 508
 509 2019-07-10  Tom Tromey  <tromey@adacore.com>
 510
 511         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 512         * breakpoint.c (init_ada_exception_breakpoint): Register as
 513         bp_catchpoint.
 514         (print_one_breakpoint_location, print_one_breakpoint): Use
 515         is_ada_exception_catchpoint.
 516         * ada-lang.c (class ada_catchpoint_location): Pass
 517         bp_loc_software_breakpoint to bp_location constructor.
 518         (is_ada_exception_catchpoint): New function.
 519
 520 2019-07-10  Tom Tromey  <tromey@adacore.com>
 521
 522         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 523         VEC.
 524         (struct arm_exidx_entry): New method operator<.
 525         (struct arm_exidx_data) <section_maps>: Change type.
 526         (arm_exidx_data_free): Remove.
 527         (arm_exidx_data_key): Change type.  Move lower.
 528         (arm_exidx_new_objfile): Update.
 529         (arm_compare_exidx_entries): Remove.
 530         (arm_find_exidx_entry, _initialize_arm_tdep)
 531
 532 2019-07-10  Tom Tromey  <tromey@adacore.com>
 533
 534         * solib-spu.c (ocl_program_data_key): Change type.
 535         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 536         Update.
 537
 538 2019-07-10  Tom Tromey  <tromey@adacore.com>
 539
 540         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 541         (struct solib_aix_inferior_data) <library_list>: Change type.
 542         (solib_aix_inferior_data_handle): Change type.
 543         (get_solib_aix_inferior_data): Update.
 544         (solib_aix_free_library_list): Remove.
 545         (library_list_start_library): Update.
 546         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 547         return type.
 548         (solib_aix_get_library_list)
 549         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 550         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 551
 552 2019-07-10  Tom Tromey  <tromey@adacore.com>
 553
 554         * solib-dsbt.c (struct dsbt_info): Add initializers.
 555         (solib_dsbt_pspace_data): Change type.
 556         (dsbt_pspace_data_cleanup): Remove.
 557         (get_dsbt_info, _initialize_dsbt_solib): Update.
 558
 559 2019-07-10  Tom Tromey  <tromey@adacore.com>
 560
 561         * spu-tdep.c (spu_overlay_data): Change type.
 562         (spu_get_overlay_table, spu_overlay_new_objfile)
 563         (_initialize_spu_tdep): Update.
 564
 565 2019-07-10  Tom Tromey  <tromey@adacore.com>
 566
 567         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 568         destructor.
 569         (dbx_objfile_data_key): Change type and declare later.
 570         (DBX_SYMFILE_INFO): Rewrite.
 571         * dbxread.c (dbx_objfile_data_key): Change type.
 572         (dbx_symfile_init): Update.
 573         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 574         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 575         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 576
 577 2019-07-10  Tom Tromey  <tromey@adacore.com>
 578
 579         * jit.c (jit_program_space_key): Change type.  Move lower.
 580         (get_jit_program_space_data): Update.
 581         (jit_program_space_data_cleanup): Remove.
 582         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 583         Update.
 584         (struct jit_program_space_data): Add initializers.
 585
 586 2019-07-10  Tom Tromey  <tromey@adacore.com>
 587
 588         * solib-darwin.c (struct darwin_info): Add initializers.
 589         (solib_darwin_pspace_data): Change type.
 590         (darwin_pspace_data_cleanup): Remove.
 591         (get_darwin_info, _initialize_darwin_solib): Update.
 592
 593 2019-07-10  Tom Tromey  <tromey@adacore.com>
 594
 595         * remote-sim.c (struct sim_inferior_data): Add initializers,
 596         constructor, and destructor.
 597         (sim_inferior_data_key): Change type.  Move lower.
 598         (check_for_duplicate_sim_descriptor): Update.
 599         (get_sim_inferior_data): Use new.  Update.
 600         (~sim_inferior_data_cleanup): Rename from
 601         sim_inferior_data_cleanup.  Simplify.
 602         (gdbsim_close_inferior, simulator_command)
 603         (sim_command_completer, _initialize_remote_sim): Update.
 604         (next_pid, INITIAL_PID): Move earlier.
 605
 606 2019-07-10  Tom Tromey  <tromey@adacore.com>
 607
 608         * python/python-internal.h (create_thread_object): Return
 609         gdbpy_ref.
 610         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 611         * python/py-inferior.c (struct threadlist_entry): Add
 612         constructor.
 613         <thread_obj>: Now a gdbpy_ref.
 614         (thread_to_thread_object): Update.
 615         (add_thread_object): Use new.
 616         (delete_thread_object): Use delete.
 617         (infpy_threads): Update.
 618         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 619         GIL.
 620
 621 2019-07-10  Tom Tromey  <tromey@adacore.com>
 622
 623         * valops.c (value_cast): Specialize error message for Ada.
 624
 625 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 626
 627         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 628
 629 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 630
 631         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 632         bpstat_should_step): Return bool, adjust comments.
 633         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 634         bpstat_should_step): Likewise.
 635
 636 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 637
 638         * features/Makefile: Use feature target descriptions for Arm.
 639         * features/arm/arm-core.c: Generate new file.
 640         * features/arm/arm-fpa.c: Likewise.
 641         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 642         * features/arm/arm-m-profile.c: Likewise.
 643         * features/arm/arm-vfpv2.c: Likewise.
 644         * features/arm/arm-vfpv3.c: Likewise.
 645         * features/arm/xscale-iwmmxt.c: Likewise.
 646         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 647
 648 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 649
 650         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 651         ptrace earlier.
 652
 653 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 654
 655         * features/aarch64-pauth.c: Regenerate.
 656
 657 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 658
 659         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 660         bool.
 661         (bpstat_what): Use false instead of 0.
 662
 663 2019-07-09  Pedro Alves  <palves@redhat.com>
 664
 665         * break-catch-throw.c (is_exception_catchpoint): New.
 666         * breakpoint.c (print_one_breakpoint_location): New parameter
 667         'raw_loc'.  Handle it.  Use
 668         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 669         looking at the breakpoint's type.
 670         (print_one_breakpoint): If handling "maint info breakpoints", also
 671         print locations of exception catchpoints.
 672         * breakpoint.h (is_exception_catchpoint): Declare.
 673
 674 2019-07-09  Pedro Alves  <palves@redhat.com>
 675
 676         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 677         "addr" field.
 678         (allocate_location_exception_catchpoint): New.
 679         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 680         (initialize_throw_catchpoint_ops): Install
 681         allocate_location_exception_catchpoint as allocate_location
 682         method.
 683         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 684         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 685         bp_loc_other.
 686         (breakpoint_address_is_meaningful): Delete.
 687         (bl_address_is_meaningful): New.
 688         (breakpoint_locations_match): Adjust comment.
 689         (bp_location_from_bp_type): New, factored out of...
 690         (bp_location::bp_location(breakpoint *)): ... this.
 691         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 692         factored out of...
 693         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 694         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 695         breakpoint_address_is_meaningful.
 696         (bp_locations_compare): Adjust comment.
 697         (update_global_location_list): Use bl_address_is_meaningful
 698         instead of breakpoint_address_is_meaningful.
 699         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 700         explicit.
 701         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 702         * python/py-breakpoint.c (bppy_get_location): No longer check
 703         whether location is null.
 704
 705 2019-07-09  Pedro Alves  <palves@redhat.com>
 706
 707         PR c++/15468
 708         * breakpoint.c (print_one_breakpoint_location): Remove
 709         single-location assert.
 710
 711 2019-07-09  Tom Tromey  <tom@tromey.com>
 712
 713         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 714         * configure: Rebuild.
 715         * configure.ac: Change common to gdbsupport.
 716         * gdbsupport: Rename from common.
 717         * acinclude.m4: Change common to gdbsupport.
 718         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 719         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 720         gdbsupport.
 721         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 722         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 723         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 724         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 725         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 726         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 727         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 728         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 729         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 730         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 731         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 732         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 733         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 734         coff-pe-read.c, command.h, compile/compile-c-support.c,
 735         compile/compile-c.h, compile/compile-cplus-symbols.c,
 736         compile/compile-cplus-types.c, compile/compile-cplus.h,
 737         compile/compile-loc2c.c, compile/compile.c, completer.c,
 738         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 739         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 740         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 741         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 742         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 743         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 744         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 745         features/aarch64-core.c, features/aarch64-fpu.c,
 746         features/aarch64-pauth.c, features/aarch64-sve.c,
 747         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 748         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 749         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 750         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 751         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 752         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 753         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 754         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 755         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 756         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 757         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 758         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 759         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 760         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 761         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 762         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 763         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 764         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 765         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 766         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 767         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 768         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 769         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 770         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 771         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 772         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 773         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 774         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 775         minsyms.c, mips-linux-tdep.c, namespace.h,
 776         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 777         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 778         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 779         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 780         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 781         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 782         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 783         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 784         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 785         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 786         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 787         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 788         procfs.c, producer.c, progspace.h, psymtab.h,
 789         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 790         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 791         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 792         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 793         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 794         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 795         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 796         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 797         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 798         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 799         target-memory.c, target.c, target.h, target/waitstatus.c,
 800         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 801         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 802         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 803         unittests/array-view-selftests.c,
 804         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 805         unittests/common-utils-selftests.c,
 806         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 807         unittests/format_pieces-selftests.c,
 808         unittests/function-view-selftests.c,
 809         unittests/lookup_name_info-selftests.c,
 810         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 811         unittests/mkdir-recursive-selftests.c,
 812         unittests/observable-selftests.c,
 813         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 814         unittests/parse-connection-spec-selftests.c,
 815         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 816         unittests/scoped_fd-selftests.c,
 817         unittests/scoped_mmap-selftests.c,
 818         unittests/scoped_restore-selftests.c,
 819         unittests/string_view-selftests.c, unittests/style-selftests.c,
 820         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 821         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 822         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 823         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 824         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 825         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 826
 827 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 828
 829         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 830         bool value.
 831         (decode_digits_ordinary): Set explicit_line field in sal.
 832         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 833         symtab_and_line that was set on an explicit line number in
 834         assembler code.  Do always update the recorded symtab and line if
 835         we do skip the prologue.
 836
 837 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 838
 839         * breakpoint.c (set_breakpoint_location_function): Remove
 840         explicit_loc parameter.
 841         (momentary_breakpoint_from_master): Update call to
 842         set_breakpoint_location_function.
 843         (add_location_to_breakpoint): Likewise.
 844
 845 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 846
 847         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 848         required features based on default bfd type when no specific bfd
 849         is present.
 850
 851 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 852
 853         * NEWS: Mention that GDB printf and eval commands can now print
 854         C-style and Ada-style convenience var strings without
 855         calling the inferior.
 856         * printcmd.c (printf_c_string): Locally print GDB internal var
 857         instead of transiting via the inferior.
 858         (printf_wide_c_string): Likewise.
 859
 860 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 861
 862         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
 863
 864 2019-07-04  Tom Tromey  <tom@tromey.com>
 865
 866         PR tui/24724:
 867         * tui/tui-winsource.c (tui_clear_source_content): Update.
 868         (tui_source_window_base::set_is_exec_point_at): Fix comment.
 869         (tui_update_breakpoint_info): Update.
 870         (tui_set_exec_info_content): Update.
 871         * tui/tui-source.c (tui_set_source_content_nil): Update.
 872         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
 873         has_break.
 874         * tui/tui-data.h (enum tui_bp_flag): New.
 875         (tui_bp_flags): New enum flags type.
 876         (struct tui_source_element) <break_mode>: Change type.  Rename
 877         from has_break.
 878         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
 879         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
 880         constants.
 881         * tui/tui-winsource.h: Fix comment.
 882
 883 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 884
 885         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
 886         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
 887         (store_fpregs_to_thread)
 888         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 889         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
 890         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
 891         (IWMMXT_REGS_SIZE): Add define.
 892         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
 893         (fetch_vfp_regs, store_vfp_regs)
 894         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 895         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
 896
 897 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 898
 899         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
 900         defines.
 901         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
 902         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
 903         (ARM_INT_REGISTER_SIZE): ...to this.
 904         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
 905         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
 906         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
 907         (arm_linux_collect_gregset, supply_nwfpe_register)
 908         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
 909         defines.
 910         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
 911         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
 912         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
 913         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
 914         (arm_return_in_memory, arm_store_return_value)
 915         (arm_get_longjmp_target, arm_register_g_packet_guesses)
 916         (arm_record_ld_st_multiple): Likewise.
 917         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
 918         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
 919
 920 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 921
 922         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
 923         AARCH64_DISPLACED_MODIFIED_INSNS.
 924         * aarch64-tdep.c (struct aarch64_displaced_step_data)
 925         (aarch64_displaced_step_copy_insn): Likewise.
 926         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 927         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
 928         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
 929         ARM_DISPLACED_MODIFIED_INSNS.
 930         * arm-tdep.c (arm_gdbarch_init): Likewise.
 931         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 932         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
 933         (struct arm_displaced_step_closure): Use
 934         ARM_DISPLACED_MODIFIED_INSNS.
 935
 936 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 937
 938         * features/Makefile: Remove unused xml files.
 939         * features/aarch64.xml: Remove.
 940         * features/i386/amd64-avx-avx512-linux.xml: Remove.
 941         * features/i386/amd64-avx-avx512.xml: Remove.
 942         * features/i386/amd64-avx-linux.xml: Remove.
 943         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
 944         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
 945         * features/i386/amd64-avx-mpx-linux.xml: Remove.
 946         * features/i386/amd64-avx-mpx.xml: Remove.
 947         * features/i386/amd64-avx.xml: Remove.
 948         * features/i386/amd64-linux.xml: Remove.
 949         * features/i386/amd64-mpx-linux.xml: Remove.
 950         * features/i386/amd64-mpx.xml: Remove.
 951         * features/i386/amd64.xml: Remove.
 952         * features/i386/i386-avx-avx512-linux.xml: Remove.
 953         * features/i386/i386-avx-avx512.xml: Remove.
 954         * features/i386/i386-avx-linux.xml: Remove.
 955         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
 956         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
 957         * features/i386/i386-avx-mpx-linux.xml: Remove.
 958         * features/i386/i386-avx-mpx.xml: Remove.
 959         * features/i386/i386-avx.xml: Remove.
 960         * features/i386/i386-linux.xml: Remove.
 961         * features/i386/i386-mmx-linux.xml: Remove.
 962         * features/i386/i386-mmx.xml: Remove.
 963         * features/i386/i386-mpx-linux.xml: Remove.
 964         * features/i386/i386-mpx.xml: Remove.
 965         * features/i386/i386.xml: Remove.
 966         * features/i386/x32-avx-avx512-linux.xml: Remove.
 967         * features/i386/x32-avx-linux.xml: Remove.
 968         * features/i386/x32-linux.xml: Remove.
 969
 970 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 971
 972         * regformats/aarch64.dat: Remove.
 973         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
 974         * regformats/i386/amd64-avx-linux.dat: Remove.
 975         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
 976         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
 977         * regformats/i386/amd64-linux.dat: Remove.
 978         * regformats/i386/amd64-mpx-linux.dat: Remove.
 979         * regformats/i386/amd64.dat: Remove.
 980         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
 981         * regformats/i386/i386-avx-linux.dat: Remove.
 982         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
 983         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
 984         * regformats/i386/i386-linux.dat: Remove.
 985         * regformats/i386/i386-mmx-linux.dat: Remove.
 986         * regformats/i386/i386-mpx-linux.dat: Remove.
 987         * regformats/i386/i386.dat: Remove.
 988         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
 989         * regformats/i386/x32-avx-linux.dat: Remove.
 990         * regformats/i386/x32-linux.dat: Remove.
 991
 992 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 993
 994         * aarch64-tdep.c: Remove xml self tests.
 995         * amd64-linux-tdep.c: Likewise.
 996         * amd64-tdep.c: Likewise.
 997         * i386-linux-tdep.c: Likewise.
 998         * i386-tdep.c: Likewise.
 999
1000 2019-07-03  Pedro Alves  <palves@redhat.com>
1001
1002         PR cli/24732
1003         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1004         (pipe_cmd_option_defs): New.
1005         (make_pipe_cmd_options_def_group): New.
1006         (pipe_command): Use gdb::option::process_options.
1007         (pipe_command_completer): New function.
1008         (_initialize_cli_cmds): Install completer for "pipe" command.
1009
1010 2019-07-03  Pedro Alves  <palves@redhat.com>
1011
1012         * cli/cli-option.c (union option_value) <string>: New field.
1013         (struct option_def_and_value): Add ctor, move ctor, dtor and
1014         use DISABLE_COPY_AND_ASSIGN.
1015         (option_def_and_value::clear_value): New.
1016         (parse_option, save_option_value_in_ctx, get_val_type_str)
1017         (add_setshow_cmds_for_options): Handle var_string.
1018         * cli-option.h (union option_def::var_address) <string>: New
1019         field.
1020         (struct string_option_def): New.
1021         * maint-test-options.c (struct test_options_opts): Add default
1022         ctor and use DISABLE_COPY_AND_ASSIGN.
1023         <string_opt>: New field.
1024         (test_options_opts::~test_options_opts): New.
1025         (test_options_opts::dump): Also dump "-string".
1026         (test_options_option_defs): Install "string.
1027
1028 2019-07-03  Pedro Alves  <palves@redhat.com>
1029
1030         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1031         option_value with a null enumeration.
1032         (complete_options): Save the option values in the context.
1033         (save_option_value_in_ctx): New, factored out from ...
1034         (process_options): ... here.
1035         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1036         of the function.
1037         * maint-test-options.c (test_options_opts::dump): New, factored
1038         out from ...
1039         (maintenance_test_options_command_mode): ... here.
1040         (maintenance_test_options_command_completion_result): Delete.
1041         (maintenance_test_options_command_completion_text): Update
1042         comment.
1043         (maintenance_show_test_options_completion_result): Change
1044         prototype.  Just print
1045         maintenance_test_options_command_completion_text.
1046         (save_completion_result): New.
1047         (maintenance_test_options_completer_mode): Pass options context to
1048         complete_options, and then save a dump.
1049         (_initialize_maint_test_options): Use add_cmd to install "maint
1050         show test-options-completion-result".
1051
1052 2019-07-03  Pedro Alves  <palves@redhat.com>
1053
1054         * NEWS (New commands): Mention "with" and "maint with".
1055         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1056         (with_command, with_command_completer): New.
1057         (pipe_command): Adjust to new repeat_previous
1058         interface.
1059         (_initialize_cli_cmds): Install the "with" command and its "w"
1060         alias.
1061         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1062         declarations.
1063         * cli/cli-setshow.c (parse_cli_var_uinteger)
1064         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1065         argument strings for all var_types.
1066         (get_setshow_command_value_string): New, factored out from ...
1067         (do_show_command): ... this.
1068         * cli/cli-setshow.h: Include <string>.
1069         (get_setshow_command_value_string): Declare.
1070         * command.h (repeat_previous): Now returns const char *.  Adjust
1071         comment.
1072         * maint.c: Include "cli/cli-cmds.h".
1073         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1074         (_initialize_maint_cmds): Register the "maintenance with" command.
1075         * top.c (repeat_previous): Move bits from pipe_command here:
1076         Return the saved command line, if any; error out if there's no
1077         command to relaunch.
1078
1079 2019-07-03  Pedro Alves  <palves@redhat.com>
1080
1081         * NEWS (New commands): Mention "maint set/show test-settings"
1082         instead of "maint test-settings".
1083         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1084         (maintenance_test_settings_set_list): Rename to ...
1085         (maintenance_set_test_settings_list): ... this.
1086         (maintenance_test_settings_show_list): Rename to  ...
1087         (maintenance_show_test_settings_list): ... this.
1088         (maintenance_test_settings_cmd): Delete.
1089         (maintenance_test_settings_set_cmd): ...
1090         (maintenance_set_test_settings_cmd): ... this.
1091         (maintenance_test_settings_show_cmd): ...
1092         (maintenance_show_test_settings_cmd): ... this.
1093         (maintenance_test_settings_show_value_cmd):
1094         (maintenance_show_test_settings_value_cmd): ... this.
1095         (_initialize_maint_test_settings): No longer install the "maint
1096         test-settings" prefix command.  Rename "maint test-settings set"
1097         to "maint set test-settings", and "maint test-settings show" to
1098         "maint show test-settings".  Adjust all subcommands.
1099
1100 2019-07-03  Pedro Alves  <palves@redhat.com>
1101
1102         * maint-test-settings.c: Fix file's intro comment.  Replace all
1103         references to "test-options" with references to "test-settings",
1104         in comments.
1105
1106 2019-07-03  Pedro Alves  <palves@redhat.com>
1107
1108         * maint-test-settings.c (maintenance_test_settings_xxx)
1109         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1110         New.
1111         (maintenance_test_settings_enums): Use them.
1112         (maintenance_test_settings_enum): Default to
1113         maintenance_test_settings_xxx.
1114         (_initialize_maint_test_settings): Initialize
1115         MAINTENANCE_TEST_SETTINGS_FILENAME.
1116
1117 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1118
1119         * breakpoint.h (remove_breakpoints_inf): Change return type to
1120         void, move function documentation here.
1121         * breakpoint.c (remove_breakpoints_inf): Change return type to
1122         void, move function documentation to header.
1123
1124 2019-07-02  Pedro Alves  <palves@redhat.com>
1125
1126         * NEWS (Completion improvements): Mention "info threads".
1127         * thread.c (struct info_threads_opts, info_threads_option_defs)
1128         (make_info_threads_options_def_group): New.
1129         (info_threads_command): Use gdb::option::process_options.
1130         (info_threads_command_completer): New.
1131         (_initialize_thread): Use gdb::option::build_help to build the
1132         help text for "info threads".
1133
1134 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1135
1136         * defs.h (generic_load): Move from here...
1137         * symfile.h (generic_load): ... to here.  Rename name parameter
1138         to args.
1139         * symfile.c (generic_load): Add comment.
1140
1141 2019-07-01  Tom Tromey  <tromey@adacore.com>
1142
1143         * dwarf2read.c
1144         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1145         declaration of without_params.  Fix formatting.
1146
1147 2019-07-01  Tom Tromey  <tromey@adacore.com>
1148
1149         * ada-exp.y (find_primitive_type): Update.
1150         * ada-lang.h (ada_lookup_symbol): Update.
1151         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1152         parameter.
1153         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1154
1155 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1156
1157         PR breakpoints/24541
1158         * gdbarch.c: Regenerate.
1159         * gdbarch.h: Regenerate.
1160         * gdbarch.sh: Add 'stap_adjust_register'.
1161         * i386-tdep.c: Include '<unordered_set>'.
1162         (i386_stap_adjust_register): New function.
1163         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1164         * stap-probe.c (stap_parse_register_operand): Call
1165         'gdbarch_stap_adjust_register'.
1166
1167 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1168
1169         PR python/24742
1170         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1171         * python/python.c (do_start_initialization): Use 'xmalloc'
1172         instead of 'PyMem_Malloc'.
1173
1174 2019-06-28  Tom Tromey  <tromey@adacore.com>
1175
1176         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1177         for Ada.
1178
1179 2019-06-27  Tom Tromey  <tromey@adacore.com>
1180
1181         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1182         objfile_key.
1183         (arm_find_mapping_symbol, arm_record_special_symbol)
1184         (_initialize_arm_tdep): Update.
1185         (arm_objfile_data_free): Remove.
1186
1187 2019-06-27  Tom Tromey  <tromey@adacore.com>
1188
1189         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1190         to cp_print_static_field.
1191
1192 2019-06-26  Tom Tromey  <tromey@adacore.com>
1193
1194         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1195         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1196         declare.
1197
1198 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1199
1200         * features/aarch64-core.c (create_feature_aarch64_core):
1201         Regenerate.
1202         * features/aarch64-core.xml: Add cpsr flags.
1203
1204 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1205
1206         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1207         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1208
1209 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1210
1211         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1212         field.
1213         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1214         use.
1215         (arm_record_special_symbol): Don't insert new symbol in sorted
1216         position, push it at the end.
1217
1218 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1219
1220         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1221         (arm_mapping_symbol_s): Remove.
1222         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1223         (arm_mapping_symbol_vec): New typedef.
1224         (struct arm_per_objfile): Add constructor.
1225         <section_maps>: Change type to
1226         std::unique_ptr<arm_mapping_symbol_vec[]>.
1227         (arm_compare_mapping_symbols): Remove.
1228         (arm_find_mapping_symbol): Adjust to section_maps type change.
1229         (arm_objfile_data_free): Call delete on arm_per_objfile.
1230         (arm_record_special_symbol): Adjust to section_maps type change.
1231         Allocate arm_per_objfile with new.
1232
1233 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1234
1235         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1236         with the command prefix.
1237
1238 2019-06-25  Tom Tromey  <tom@tromey.com>
1239
1240         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1241         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1242
1243 2019-06-25  Tom Tromey  <tom@tromey.com>
1244
1245         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1246         type.
1247         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1248         protected.
1249
1250 2019-06-25  Tom Tromey  <tom@tromey.com>
1251
1252         * tui/tui-winsource.c
1253         (tui_source_window_base::set_is_exec_point_at): Add check against
1254         LOA_ADDRESS.
1255
1256 2019-06-25  Tom Tromey  <tom@tromey.com>
1257
1258         * tui/tui-source.c (tui_set_source_content): Don't check before
1259         xfree.
1260         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1261
1262 2019-06-25  Tom Tromey  <tom@tromey.com>
1263
1264         * tui/tui-winsource.h (tui_update_source_window_as_is)
1265         (tui_alloc_source_buffer, tui_line_is_displayed)
1266         (tui_addr_is_displayed): Change type of win_info.
1267         * tui/tui-winsource.c (tui_update_source_window_as_is)
1268         (tui_clear_source_content, tui_show_source_line)
1269         (tui_show_source_content, tui_source_window_base::refill)
1270         (tui_source_window_base::set_is_exec_point_at)
1271         (tui_source_window_base::set_is_exec_point_at)
1272         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1273         (tui_alloc_source_buffer, tui_line_is_displayed)
1274         (tui_addr_is_displayed): Change type of win_info.  Update.
1275         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1276         (tui_source_window_base::do_make_visible_with_new_height):
1277         Update.
1278         * tui/tui-source.c (tui_set_source_content)
1279         (tui_set_source_content_nil)
1280         (tui_source_window::do_scroll_vertical): Update.
1281         * tui/tui-layout.c (show_layout): Update.
1282         * tui/tui-disasm.c (tui_set_disassem_content)
1283         (tui_disasm_window::do_scroll_vertical): Update.
1284         * tui/tui-data.h (tui_win_content): Remove.
1285         (struct tui_gen_win_info) <content, content_size>: Remove.
1286         (struct tui_source_element): Add initializers and destructor.
1287         (union tui_which_element, struct tui_win_element): Remove.
1288         (struct tui_source_window_base) <content>: New field.
1289         (struct tui_data_window): Remove destructor.
1290         (tui_alloc_content, tui_free_win_content)
1291         (tui_free_all_source_wins_content): Don't declare.
1292         * tui/tui-data.c (tui_initialize_static_data): Update.
1293         (init_content_element, tui_alloc_content): Remove.
1294         (~tui_gen_win_info): Update.
1295         (~tui_data_window, tui_free_all_source_wins_content)
1296         (tui_free_win_content, free_content, free_content_elements):
1297         Remove.
1298
1299 2019-06-25  Tom Tromey  <tom@tromey.com>
1300
1301         * tui/tui-winsource.h (tui_clear_source_content)
1302         (tui_erase_source_content, tui_show_source_content): Change type
1303         of win_info.
1304         * tui/tui-winsource.c (tui_clear_source_content)
1305         (tui_erase_source_content, tui_show_source_content): Change type
1306         of win_info.
1307         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1308         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1309         win_info.
1310         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1311         win_info.
1312         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1313
1314 2019-06-25  Tom Tromey  <tom@tromey.com>
1315
1316         * tui/tui-winsource.c (tui_clear_source_content)
1317         (tui_source_window_base::set_is_exec_point_at): Update.
1318         * tui/tui-source.c (tui_set_source_content_nil): Update.
1319         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1320         a bool.
1321         * tui/tui-data.c (init_content_element): Update.
1322
1323 2019-06-25  Tom Tromey  <tom@tromey.com>
1324
1325         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1326         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1327         * tui/tui-layout.c (init_and_make_win): Update.
1328         * tui/tui.h (enum tui_win_type): Update.
1329         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1330         tui_win_is_auxillary.
1331         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1332         tui_win_is_auxillary.
1333
1334 2019-06-25  Tom Tromey  <tom@tromey.com>
1335
1336         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1337         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1338         (tui_delete_data_content_windows, tui_display_all_data)
1339         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1340         Update.
1341         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1342         * tui/tui-regs.c (tui_last_regs_line_no)
1343         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1344         (tui_show_registers): Update.
1345         (tui_show_register_group): Return void.  Update.
1346         (tui_display_registers_from, tui_display_reg_element_at_line)
1347         (tui_display_registers_from_line, tui_check_register_values):
1348         Update.
1349         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1350         member.
1351         (struct tui_data_window) <regs_content>: Now a std::vector.
1352         <regs_content_count>: Remove.
1353         (tui_add_content_elements, tui_free_data_content): Don't declare.
1354         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1355         (init_content_element): Remove DATA_WIN case.  Add assert.
1356         (tui_add_content_elements): Remove.
1357         (tui_data_window): Update.
1358         (tui_free_data_content): Remove.
1359         (free_content_elements): Remove DATA_WIN case.
1360
1361 2019-06-25  Tom Tromey  <tom@tromey.com>
1362
1363         * tui/tui-data.c (tui_data_item_window): Update.
1364         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1365         * tui/tui-windata.c (tui_display_all_data)
1366         (tui_display_data_from_line): Update.
1367         (tui_check_data_values): Remove.
1368         * tui/tui-regs.c (tui_show_register_group)
1369         (tui_display_reg_element_at_line): Update.
1370         * tui/tui-hooks.c (tui_register_changed)
1371         (tui_refresh_frame_and_register_information): Call
1372         tui_check_register_values.
1373         * tui/tui-data.h (struct tui_data_window) <data_content,
1374         data_content_count, data_type>: Remove.
1375         (enum tui_data_type): Remove.
1376
1377         * tui/tui-data.c (tui_data_window::clear_detail)
1378         (~tui_data_window): Update.
1379
1380 2019-06-25  Tom Tromey  <tom@tromey.com>
1381
1382         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1383         declare.
1384         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1385         Rename from tui_first_data_item_displayed.  Update.
1386         (tui_data_window::refresh_all)
1387         (tui_data_window::do_scroll_vertical): Update.
1388         * tui/tui-data.h (struct tui_data_window)
1389         <first_data_item_displayed>: Declare new method.
1390
1391 2019-06-25  Tom Tromey  <tom@tromey.com>
1392
1393         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1394         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1395         contents...
1396         (tui_initialize_static_data): ...here.
1397
1398 2019-06-25  Tom Tromey  <tom@tromey.com>
1399
1400         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1401         (tui_display_registers_from, tui_check_register_values): Update.
1402         (tui_display_register): Remove win_info parameter; update.
1403         (tui_get_register): Change type of parameters.
1404         * tui/tui-data.h (struct tui_data_element): Remove.
1405         (union tui_which_element) <data>: Remove.
1406         <data_window>: Change type.
1407         (struct tui_data_item_window): New.
1408         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1409         case.  Add assert.
1410         (~tui_data_item_window): New destructor.
1411         (free_content_elements): Remove DATA_ITEM_WIN case.
1412
1413 2019-06-25  Tom Tromey  <tom@tromey.com>
1414
1415         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1416         Remove.
1417
1418 2019-06-25  Tom Tromey  <tom@tromey.com>
1419
1420         * tui/tui-data.h (struct tui_command_element): Remove.
1421         (union tui_which_element) <command>: Remove.
1422         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1423         assert.
1424         (free_content_elements): Remove CMD_WIN case.
1425
1426 2019-06-25  Tom Tromey  <tom@tromey.com>
1427
1428         * tui/tui-layout.c (tui_set_layout): Update.
1429         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1430         * tui/tui-data.c (layout_def): Update.
1431
1432 2019-06-25  Tom Tromey  <tom@tromey.com>
1433
1434         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1435         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1436         (tui_source_window_base::set_new_height): Update.
1437         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1438         Update.
1439         (tui_set_locator_fullname, tui_set_locator_info)
1440         (tui_show_frame_info): Update.
1441         * tui/tui-source.c (tui_set_source_content)
1442         (tui_source_is_displayed): Update.
1443         * tui/tui-layout.c (show_source_disasm_command, show_data)
1444         (show_source_or_disasm_and_command): Update.
1445         * tui/tui-disasm.c (tui_set_disassem_content)
1446         (tui_get_begin_asm_address): Update.
1447         * tui/tui-data.h (struct tui_locator_element): Remove.
1448         (union tui_which_element) <locator>: Remove.
1449         (struct tui_locator_window): New.
1450         (tui_locator_win_info_ptr): Change return type.
1451         * tui/tui-data.c (_locator): Change type.
1452         (tui_locator_win_info_ptr): Change return type.
1453         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1454         (tui_alloc_content): Add assert.
1455
1456 2019-06-25  Tom Tromey  <tom@tromey.com>
1457
1458         * tui/tui-winsource.c
1459         (tui_exec_info_window::maybe_allocate_content): New method.
1460         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1461         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1462         (make_source_or_disasm_window): Add cast.
1463         * tui/tui-data.h (union tui_which_element) <simple_string>:
1464         Remove.
1465         (struct tui_source_info): New.
1466         (struct tui_source_window_base) <execution_info>: Change type.
1467         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1468         case, and add assert.
1469         (tui_alloc_content): Add assert.
1470
1471 2019-06-25  Tom Tromey  <tom@tromey.com>
1472
1473         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1474         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1475         * tui/tui-data.c (tui_alloc_win_info): Remove.
1476
1477 2019-06-25  Tom Tromey  <tom@tromey.com>
1478
1479         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1480         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1481         can_highlight.
1482
1483 2019-06-25  Tom Tromey  <tom@tromey.com>
1484
1485         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1486         make_visible_with_new_height method.
1487         (tui_win_info::make_visible_with_new_height): New method.
1488         (tui_source_window_base::do_make_visible_with_new_height)
1489         (tui_data_window::do_make_visible_with_new_height)
1490         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1491         (make_visible_with_new_height): Remove.
1492         (tui_resize_all, tui_adjust_win_heights): Use
1493         make_visible_with_new_height method.
1494         * tui/tui-data.h (struct tui_win_info)
1495         <do_make_visible_with_new_height, make_visible_with_new_height>:
1496         New methods.
1497         (struct tui_source_window_base, struct tui_data_window)
1498         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1499         methods.
1500
1501 2019-06-25  Tom Tromey  <tom@tromey.com>
1502
1503         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1504         method.
1505         (update_tab_width): Call update_tab_width method.
1506         * tui/tui-data.h (struct tui_win_info)
1507         (struct tui_source_window_base) <update_tab_width>: New methods.
1508
1509 2019-06-25  Tom Tromey  <tom@tromey.com>
1510
1511         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1512         parameter.
1513         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1514         parameter.
1515         (tui_gen_win_info::make_visible): Update.
1516         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1517         parameter.
1518         * tui/tui-data.h (enum tui_box): New enum.
1519         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1520
1521 2019-06-25  Tom Tromey  <tom@tromey.com>
1522
1523         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1524         init_and_make_win for EXEC_INFO_WIN.
1525         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1526         longer inline.
1527         (struct tui_win_info) <~tui_win_info>: Inline.
1528         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1529         Don't declare.
1530         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1531         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1532         Remove.
1533         (tui_initialize_static_data): Update.
1534         (~tui_gen_win_info): Handle more cleanup here.
1535         (~tui_source_window_base): Delete "execution_info".
1536         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1537
1538 2019-06-25  Tom Tromey  <tom@tromey.com>
1539
1540         * tui/tui-layout.c (make_command_window): Don't set
1541         can_highlight.
1542         (show_source_disasm_command): Call the reset method.
1543         (show_data): Don't set can_highlight.  Call the reset method.
1544         (tui_gen_win_info::reset): Rename from init_gen_win_info
1545         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1546         (show_source_or_disasm_and_command): Call the reset method.
1547         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1548         (struct tui_cmd_window): Set can_highlight.
1549
1550 2019-06-25  Tom Tromey  <tom@tromey.com>
1551
1552         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1553         from make_visible.
1554         (tui_make_visible, tui_make_invisible): Rewrite.
1555         (tui_win_info::make_visible): Remove.
1556         (tui_source_window_base::make_visible): Update.
1557         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1558         method.  Moved from...
1559         (struct tui_win_info) <make_visible>: ...here.
1560
1561 2019-06-25  Tom Tromey  <tom@tromey.com>
1562
1563         * tui/tui-winsource.c
1564         (tui_source_window_base::do_scroll_horizontal): Remove direction
1565         parameter.
1566         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1567         direction parameter.
1568         * tui/tui-win.c (tui_win_info::forward_scroll)
1569         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1570         (tui_win_info::right_scroll): Update.
1571         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1572         direction parameter.
1573         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1574         direction parameter.
1575         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1576         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1577         Remove direction parameter.
1578         (struct tui_source_window_base, struct tui_source_window)
1579         (struct tui_disasm_window, struct tui_data_window)
1580         (struct tui_cmd_window): Update.
1581
1582 2019-06-25  Tom Tromey  <tom@tromey.com>
1583
1584         * tui/tui-winsource.h (tui_set_exec_info_content)
1585         (tui_show_exec_info_content, tui_erase_exec_info_content)
1586         (tui_clear_exec_info_content, tui_update_exec_info): Change
1587         argument to tui_source_window_base.
1588         * tui/tui-winsource.c (tui_set_exec_info_content)
1589         (tui_show_exec_info_content, tui_erase_exec_info_content)
1590         (tui_clear_exec_info_content, tui_update_exec_info): Change
1591         argument to tui_source_window_base.
1592
1593 2019-06-25  Tom Tromey  <tom@tromey.com>
1594
1595         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1596         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1597
1598 2019-06-25  Tom Tromey  <tom@tromey.com>
1599
1600         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1601         check.
1602
1603 2019-06-25  Tom Tromey  <tom@tromey.com>
1604
1605         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1606         type to void.
1607         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1608         type to void.
1609         * tui/tui-source.c (tui_set_source_content): Update.
1610         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1611
1612 2019-06-25  Tom Tromey  <tom@tromey.com>
1613
1614         * tui/tui-win.c (window_name_completer, tui_set_focus)
1615         (tui_all_windows_info): Use name method.
1616         * tui/tui-data.h (struct tui_gen_win_info)
1617         (struct tui_source_window, struct tui_disasm_window)
1618         (struct tui_data_window, struct tui_cmd_window) <name>: New
1619         method.
1620         (tui_win_name): Don't declare.
1621         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1622         (tui_win_name): Remove.
1623
1624 2019-06-25  Tom Tromey  <tom@tromey.com>
1625
1626         * tui/tui-winsource.h (tui_update_source_window)
1627         (tui_update_source_window_as_is): Change parameter type.
1628         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1629         to be a tui_source_window_base.
1630         (tui_update_source_window_as_is): Likewise.
1631         * tui/tui-win.c (make_visible_with_new_height): Update.
1632
1633 2019-06-25  Tom Tromey  <tom@tromey.com>
1634
1635         * tui/tui-winsource.c (tui_erase_source_content)
1636         (tui_show_source_content, tui_show_exec_info_content)
1637         (tui_erase_exec_info_content): Use refresh_window method.
1638         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1639         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1640         from tui_refresh_win.
1641         (tui_data_window::refresh_window): New method.
1642         (tui_win_info::refresh, tui_source_window_base::refresh)
1643         (tui_refresh_all): Use refresh_window method.
1644         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1645         method.
1646         * tui/tui-regs.c (tui_display_register): Call refresh_window
1647         method.
1648         * tui/tui-layout.c (show_source_disasm_command)
1649         (show_source_or_disasm_and_command): Call refresh_window method.
1650         * tui/tui-data.h (struct tui_gen_win_info)
1651         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1652         New method.
1653
1654 2019-06-25  Tom Tromey  <tom@tromey.com>
1655
1656         * tui/tui.c (tui_rl_other_window, tui_enable)
1657         (tui_is_window_visible, tui_get_command_dimension): Update.
1658         * tui/tui-winsource.c (tui_update_source_window_as_is)
1659         (tui_clear_source_content, tui_erase_source_content)
1660         (tui_show_source_line, tui_source_window_base::refill)
1661         (tui_source_window_base::do_scroll_horizontal)
1662         (tui_source_window_base::set_is_exec_point_at)
1663         (tui_update_breakpoint_info, tui_set_exec_info_content)
1664         (tui_alloc_source_buffer, tui_line_is_displayed)
1665         (tui_addr_is_displayed): Update.
1666         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1667         (tui_check_and_display_highlight_if_needed)
1668         (tui_win_info::make_visible, tui_win_info::refresh)
1669         (tui_refresh_all): Update.
1670         * tui/tui-windata.c (tui_first_data_item_displayed)
1671         (tui_delete_data_content_windows, tui_erase_data_content)
1672         (tui_display_all_data, tui_data_window::refresh_all)
1673         (tui_check_data_values): Update.
1674         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1675         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1676         (tui_win_info::backward_scroll, tui_refresh_all_win)
1677         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1678         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1679         (tui_source_window_base::set_new_height)
1680         (tui_data_window::set_new_height)
1681         (make_invisible_and_set_new_height)
1682         (make_visible_with_new_height, new_height_ok)
1683         (parse_scrolling_args): Update.
1684         * tui/tui-stack.c (tui_show_frame_info): Update.
1685         * tui/tui-source.c (tui_set_source_content)
1686         (tui_set_source_content_nil, tui_source_is_displayed)
1687         (tui_source_window::do_scroll_vertical): Update.
1688         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1689         (tui_display_registers_from, tui_display_reg_element_at_line)
1690         (tui_check_register_values, tui_reg_command): Update.
1691         * tui/tui-layout.c (tui_default_win_height)
1692         (show_source_disasm_command, show_data, init_and_make_win)
1693         (show_source_or_disasm_and_command): Update.
1694         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1695         (tui_redisplay_readline, tui_mld_flush)
1696         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1697         (tui_getc): Update.
1698         * tui/tui-disasm.c (tui_set_disassem_content)
1699         (tui_disasm_window::do_scroll_vertical): Update.
1700         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1701         Now virtual.
1702         (struct tui_win_info): Derive from tui_gen_win_info.
1703         <~tui_win_info>: Mark as override.
1704         <generic>: Remove member.
1705         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1706         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1707         (~tui_data_window, ~tui_win_info)
1708         (tui_free_all_source_wins_content): Update.
1709         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1710
1711 2019-06-25  Tom Tromey  <tom@tromey.com>
1712
1713         * tui/tui-layout.c (init_and_make_win): Use new.
1714         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1715         destructor, initializers.
1716         (tui_alloc_generic_win_info): Don't declare.
1717         * tui/tui-data.c (_locator): Add argument to constructor.
1718         (source_win, disasm_win): New globals.
1719         (exec_info): Remove.
1720         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1721         Update.
1722         (tui_alloc_generic_win_info): Remove.
1723         (init_content_element): Use new.
1724         (tui_win_info::tui_win_info): Update.
1725         (free_content_elements) <case DATA_WIN>: Use delete.
1726
1727 2019-06-25  Tom Tromey  <tom@tromey.com>
1728
1729         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1730         * tui/tui-windata.c (tui_first_data_item_displayed)
1731         (tui_delete_data_content_windows): Update.
1732         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1733         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1734         (tui_display_registers_from, tui_check_register_values): Update.
1735         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1736         pointer.
1737         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1738         window.
1739         (tui_free_data_content): Update.
1740         (free_content_elements) <case DATA_WIN>: Free the window.
1741
1742 2019-06-25  Tom Tromey  <tom@tromey.com>
1743
1744         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1745         Update.
1746         * tui/tui-layout.c (make_command_window)
1747         (show_source_disasm_command, show_data, init_and_make_win)
1748         (show_source_or_disasm_and_command): Update.
1749         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1750         method.
1751         <can_highight, is_highlighted>: Now bool.
1752         (tui_set_win_highlight): Don't declare.
1753         * tui/tui-data.c (tui_set_win_highlight): Remove.
1754
1755 2019-06-25  Tom Tromey  <tom@tromey.com>
1756
1757         * tui/tui-wingeneral.c (make_visible): Remove check of window
1758         type.
1759
1760 2019-06-25  Tom Tromey  <tom@tromey.com>
1761
1762         * tui/tui-win.c (tui_win_info::max_height)
1763         (tui_cmd_window::max_height): New methods.
1764         (new_height_ok): Call max_height.
1765         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1766         <max_height>: New method.
1767
1768 2019-06-25  Tom Tromey  <tom@tromey.com>
1769
1770         * tui/tui-win.c (tui_source_window_base::set_new_height)
1771         (tui_data_window::set_new_height): New methods.
1772         (make_invisible_and_set_new_height): Call set_new_height method.
1773         * tui/tui-data.h (struct tui_win_info)
1774         (struct tui_source_window_base, struct tui_data_window)
1775         <set_new_height>: New method.
1776
1777 2019-06-25  Tom Tromey  <tom@tromey.com>
1778
1779         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1780         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1781         tui_refresh_data_win.
1782         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1783         method.
1784         (tui_refresh_all_win): Call the refresh_all method.
1785         (tui_set_focus): Likewise.
1786         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1787         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1788         Likewise.
1789
1790 2019-06-25  Tom Tromey  <tom@tromey.com>
1791
1792         * tui/tui-winsource.h (tui_refill_source_window)
1793         (tui_set_is_exec_point_at): Don't declare.
1794         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1795         (tui_source_window_base::refill): Rename from
1796         tui_refill_source_window.
1797         (tui_source_window_base::do_scroll_horizontal): Update.
1798         (tui_source_window_base::set_is_exec_point_at): Rename from
1799         tui_set_is_exec_point_at.
1800         (tui_update_all_breakpoint_info): Update.
1801         * tui/tui-stack.c (tui_show_frame_info): Update.
1802         * tui/tui-layout.c (show_data): Add cast.
1803         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1804         * tui/tui-data.h (struct tui_source_window_base) <refill,
1805         set_is_exec_point_at>: New methods.
1806         (tui_source_windows, tui_add_to_source_windows): Update types.
1807         (tui_add_to_source_windows): Remove redundant declaration.
1808         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1809         (tui_source_windows): Change return type.
1810         (tui_clear_source_windows_detail): Update.
1811         (tui_add_to_source_windows): Change type of parameter.
1812         (tui_free_all_source_wins_content): Update.
1813
1814 2019-06-25  Tom Tromey  <tom@tromey.com>
1815
1816         * tui/tui-wingeneral.c (tui_win_info::refresh)
1817         (tui_source_window_base::refresh): New methods.
1818         (tui_refresh_all): Call the refresh method.
1819         * tui/tui-data.h (struct tui_win_info)
1820         (struct tui_source_window_base) <refresh>: New method.
1821
1822 2019-06-25  Tom Tromey  <tom@tromey.com>
1823
1824         * tui/tui.h (tui_is_window_visible): Return bool.
1825         * tui/tui.c (tui_is_window_visible): Return bool.
1826         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1827         (tui_make_visible, tui_make_invisible)
1828         (tui_win_info::make_visible)
1829         (tui_source_window_base::make_visible, make_all_visible)
1830         (tui_make_all_visible, tui_make_all_invisible): Update.
1831         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1832         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1833         bool.
1834         (struct tui_win_info, struct tui_source_window_base)
1835         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1836         * tui/tui-data.c (tui_init_generic_part): Update.
1837
1838 2019-06-25  Tom Tromey  <tom@tromey.com>
1839
1840         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1841         (tui_source_window_base::make_visible): New methods.
1842         (make_all_visible): Make method call.
1843         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1844         (struct tui_source_window_base, struct tui_cmd_window): Override
1845         make_visible.
1846         (tui_win_is_source_type): Don't declare.
1847         * tui/tui-data.c (tui_win_is_source_type): Remove.
1848
1849 2019-06-25  Tom Tromey  <tom@tromey.com>
1850
1851         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1852         NULL check.
1853
1854 2019-06-25  Tom Tromey  <tom@tromey.com>
1855
1856         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1857         Inline constructor.  Add initializers for members.
1858         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1859         constructors; now inline in class.
1860
1861 2019-06-25  Tom Tromey  <tom@tromey.com>
1862
1863         * tui/tui-regs.c (tui_show_registers): Update.
1864         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1865         bool.
1866         * tui/tui-data.c (tui_data_window::clear_detail)
1867         (tui_data_window): Update.
1868
1869 2019-06-25  Tom Tromey  <tom@tromey.com>
1870
1871         * tui/tui-windata.c (tui_display_all_data)
1872         (tui_display_data_from_line, tui_display_data_from)
1873         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1874         Update.
1875         * tui/tui-regs.c (tui_last_regs_line_no)
1876         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1877         (tui_show_registers, tui_show_register_group)
1878         (tui_display_registers_from, tui_display_reg_element_at_line)
1879         (tui_display_registers_from_line, tui_check_register_values)
1880         (tui_reg_next, tui_reg_prev): Update.
1881         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1882         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1883         tui_data_window.
1884         (struct tui_win_info) <detail>: Remove.  Add new fields from
1885         tui_data_info.
1886         (TUI_DATA_WIN): Add cast.
1887         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1888         (~tui_data_window): Simplify.
1889
1890 2019-06-25  Tom Tromey  <tom@tromey.com>
1891
1892         * tui/tui-layout.c (show_source_disasm_command)
1893         (show_source_or_disasm_and_command): Update.
1894         * tui/tui-io.c (update_cmdwin_start_line)
1895         (tui_redisplay_readline): Update.
1896         * tui/tui-data.h (struct tui_command_info): Remove.
1897         (struct tui_win_info) <detail>: Remove command_info member.
1898         (struct tui_data_window) <start_line>: New member, from
1899         tui_command_info.
1900         (TUI_CMD_WIN): Add casts.
1901
1902 2019-06-25  Tom Tromey  <tom@tromey.com>
1903
1904         * tui/tui-winsource.c (tui_update_source_window)
1905         (tui_refill_source_window)
1906         (tui_source_window_base::do_scroll_horizontal)
1907         (tui_update_breakpoint_info, tui_set_exec_info_content)
1908         (tui_show_exec_info_content, tui_erase_exec_info_content)
1909         (tui_clear_exec_info_content): Update.
1910         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1911         Update.
1912         * tui/tui-win.c (make_invisible_and_set_new_height)
1913         (make_visible_with_new_height): Update.
1914         * tui/tui-source.c (tui_set_source_content)
1915         (tui_show_symtab_source): Update.
1916         * tui/tui-layout.c (extract_display_start_addr)
1917         (show_source_disasm_command, show_data)
1918         (make_source_or_disasm_window)
1919         (show_source_or_disasm_and_command): Update.
1920         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1921         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1922         "gdbarch".
1923         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1924         to tui_source_window_base.
1925         (struct tui_win_info) <detail>: Remove source_info member.
1926         (struct tui_source_window_base) <has_locator>: Inline.
1927         Move contents from tui_source_info; rename has_locator member to
1928         m_has_locator.
1929         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1930         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1931         header file.
1932         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1933         Simplify.
1934         (tui_free_all_source_wins_content): Cast to
1935         tui_source_window_base.
1936
1937 2019-06-25  Tom Tromey  <tom@tromey.com>
1938
1939         * tui/tui-win.c (make_invisible_and_set_new_height)
1940         (make_visible_with_new_height): Call has_locator method.
1941         * tui/tui-layout.c (show_source_disasm_command, show_data)
1942         (show_source_or_disasm_and_command): Update for bool change.
1943         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1944         (tui_win_info) <has_locator>: New method.
1945         (struct tui_source_window_base) <has_locator>: New method.
1946         (tui_win_has_locator): Don't declare.
1947         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1948         from tui_win_has_locator.
1949         (tui_source_window_base): Use false, not FALSE.
1950
1951 2019-06-25  Tom Tromey  <tom@tromey.com>
1952
1953         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1954         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1955         clear_detail method directly.
1956         (tui_clear_win_detail): Remove.
1957
1958 2019-06-25  Tom Tromey  <tom@tromey.com>
1959
1960         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1961         "this", not TUI_DISASM_WIN.
1962
1963 2019-06-25  Tom Tromey  <tom@tromey.com>
1964
1965         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1966         declare.
1967         * tui/tui-winsource.c
1968         (tui_source_window_base::do_scroll_horizontal): Rename from
1969         tui_horizontal_source_scroll.
1970         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1971         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1972         from tui_vertical_data_scroll.
1973         * tui/tui-win.h (tui_scroll): Don't declare.
1974         * tui/tui-win.c (tui_win_info::forward_scroll)
1975         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1976         (tui_win_info::right_scroll): Rename and update.
1977         (tui_scroll_forward_command, tui_scroll_backward_command)
1978         (tui_scroll_left_command, tui_scroll_right_command): Update.
1979         (tui_scroll): Remove.
1980         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1981         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1982         from tui_vertical_source_scroll.
1983         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1984         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1985         from tui_vertical_disassem_scroll.
1986         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1987         do_scroll_horizontal>: New methods.
1988         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1989         Likewise.
1990         (struct tui_source_window_base): Add do_scroll_horizontal.
1991         (struct tui_source_window, struct tui_disasm_window): Add
1992         do_scroll_vertical.
1993         (struct tui_data_window, struct tui_cmd_window): Add
1994         do_scroll_horizontal and do_scroll_vertical.
1995         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1996
1997 2019-06-25  Tom Tromey  <tom@tromey.com>
1998
1999         * tui/tui-data.h (struct tui_source_window_base): New struct.
2000         (struct tui_source_window): Derive from tui_source_window_base.
2001         (struct tui_disasm_window): New struct.
2002         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2003         from tui_source_window::clear_detail.
2004         (tui_source_window_base): Rename from tui_source_window.
2005         (~tui_source_window_base): Rename from ~tui_source_window.
2006         (tui_alloc_win_info): Create a tui_disasm_window.
2007
2008 2019-06-25  Tom Tromey  <tom@tromey.com>
2009
2010         * tui/tui-data.h (struct tui_source_window)
2011         (struct tui_data_window): Declare destructors.
2012         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2013         destructors.
2014         (tui_win_info): Simplify.
2015
2016 2019-06-25  Tom Tromey  <tom@tromey.com>
2017
2018         * tui/tui-winsource.c (tui_display_main)
2019         (tui_update_source_windows_with_addr)
2020         (tui_update_all_breakpoint_info): Update.
2021         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2022         (new_height_ok, parse_scrolling_args): Update.
2023         * tui/tui-stack.c (tui_show_frame_info): Update.
2024         * tui/tui-data.h (struct tui_list): Remove.
2025         (tui_source_windows): Return a reference to a std::vector.
2026         * tui/tui-data.c (source_windows): Now a std::vector.
2027         (tui_source_windows): Change return type.
2028         (tui_clear_source_windows): Rewrite.
2029         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2030         (tui_free_all_source_wins_content): Rewrite.
2031
2032 2019-06-25  Tom Tromey  <tom@tromey.com>
2033
2034         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2035         (struct tui_data_window, struct tui_cmd_window): Declare
2036         clear_detail method.
2037         * tui/tui-data.c (tui_source_window::clear_detail)
2038         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2039         methods.
2040         (tui_clear_win_detail): Simplify.
2041
2042 2019-06-25  Tom Tromey  <tom@tromey.com>
2043
2044         * tui/tui-layout.c (make_source_window, make_disasm_window)
2045         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2046         Return the new window.
2047         (show_source_disasm_command, show_data)
2048         (show_source_or_disasm_and_command): Update.
2049
2050 2019-06-25  Tom Tromey  <tom@tromey.com>
2051
2052         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2053         parameter.  Return the new window.
2054         (show_source_disasm_command): Update and remove NULL check.
2055         (show_source_or_disasm_and_command): Update.
2056
2057 2019-06-25  Tom Tromey  <tom@tromey.com>
2058
2059         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2060
2061 2019-06-25  Tom Tromey  <tom@tromey.com>
2062
2063         * tui/tui-data.h (struct tui_win_info): Make constructor
2064         protected.  Make destructor virtual.  Add initializers.
2065         (tui_source_window, tui_data_window, tui_cmd_window): New
2066         classes.
2067         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2068         constructor.  Add "type" parameter.
2069         (tui_source_window, tui_data_window, tui_cmd_window): New
2070         constructors.
2071         (tui_alloc_win_info): Instantiate the appropriate subclass.
2072
2073 2019-06-25  Tom Tromey  <tom@tromey.com>
2074
2075         * tui/tui-win.c (tui_resize_all): Use delete.
2076         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2077         destructor.
2078         (tui_free_window): Don't declare.
2079         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2080         Update.
2081
2082 2019-06-25  Tom Tromey  <tom@tromey.com>
2083
2084         * tui/tui-data.h (struct tui_win_info): Add constructor.
2085         * tui/tui-data.c (tui_alloc_win_info): Use new.
2086         (tui_free_window): Use delete.
2087
2088 2019-06-22  Tom Tromey  <tom@tromey.com>
2089
2090         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2091         declare.
2092         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2093
2094 2019-06-22  Tom Tromey  <tom@tromey.com>
2095
2096         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2097         declare.
2098         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2099
2100 2019-06-22  Tom de Vries  <tdevries@suse.de>
2101
2102         * dwarf2read.c (create_addrmap_from_aranges)
2103         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2104         instead of '%zu'.
2105
2106 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2107
2108         * dwarf2read.h (dwarf2_section_info_def): Remove.
2109         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2110         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2111         std::vector<dwarf2_section_info>.
2112         (struct dwo_file) <~dwo_file>: Remove.
2113         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2114         types field.
2115         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2116         (dwarf2_read_debug_names): Likewise.
2117         (create_debug_types_hash_table): Change parameter type to
2118         array_view, adjust code accordingly.
2119         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2120         (partial_die_info::fixup): Likewise.
2121         (determine_prefix): Likewise.
2122         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2123
2124 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2125
2126         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2127         gdb_bfd_ref_ptr.
2128         <~dwo_file>: Remove call to gdb_bfd_unref.
2129         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2130         gdb_bfd_ref_ptr::get.
2131
2132 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2133
2134         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2135         type to htab_up.
2136         * dwarf2read.c (struct dwo_file): Initialize fields.
2137         <~dwo_file>: New.
2138         (free_dwo_file): Remove, move content to ~dwo_file.
2139         (struct dwo_file_deleter): Remove.
2140         (dwo_file_up>: Remove custom deleter.
2141         (free_dwo_files): Remove.
2142         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2143         dwo_files.
2144         (process_skeletonless_type_units): Call unique_ptr::get.
2145         (allocate_dwo_file_hash_table): Add deleter to created hash
2146         table.  Change return type to htab_up.
2147         (lookup_dwo_file_slot): Don't memset dwo_file, call
2148         unique_ptr::get.
2149         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2150         (create_dwo_unit_in_dwp_v2): Likewise.
2151         (open_and_init_dwo_file): Likewise.
2152         (free_dwo_file_from_slot): Remove.
2153
2154 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2155
2156         * dwarf2read.h (struct dwarf2_section_info) <readin,
2157         is_virtual>: Change type to bool.
2158         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2159         true instead of 1.
2160
2161 2019-06-19  Tom Tromey  <tom@tromey.com>
2162
2163         * tui/tui-data.h (tui_init_content_element): Don't declare.
2164
2165 2019-06-19  Tom Tromey  <tom@tromey.com>
2166
2167         * tui/tui-data.h (tui_init_win_info): Don't declare.
2168
2169 2019-06-19  Tom de Vries  <tdevries@suse.de>
2170
2171         * dwarf2read.h (abstract_to_concrete): Change type to
2172         std::unordered_map<sect_offset, std::vector<sect_offset>,
2173         gdb::hash_enum<sect_offset>>.
2174
2175 2019-06-19  Tom Tromey  <tromey@adacore.com>
2176
2177         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2178         EVAL_AVOID_SIDE_EFFECTS specially.
2179
2180 2019-06-19  Tom Tromey  <tromey@adacore.com>
2181
2182         * source-cache.c (highlighter): New global.
2183         (source_cache::get_source_lines): Create a highlighter on demand.
2184
2185 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2186
2187         * defs.h (deprecated_interactive_hook): Delete declaration.
2188         * interps.c (clear_interpreter_hooks): Remove use of
2189         deprecated_interactive_hook.
2190         * top.c (deprecated_interactive_hook): Delete definition.
2191         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2192
2193 2019-06-18  Tom de Vries  <tdevries@suse.de>
2194
2195         PR gdb/24515
2196         * dwarf2read.h (abstract_to_concrete): Change type from
2197         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2198         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2199         * dwarf2read.c (read_variable): Update.
2200         (dwarf2_fetch_die_loc_sect_off): Update.
2201
2202 2019-06-17  Tom de Vries  <tdevries@suse.de>
2203
2204         PR gdb/24617
2205         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2206         accessing parent[parent_len - 1].
2207
2208 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2209
2210         PR gdb/24364
2211         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2212         call dtrace_process_dof with NULL dof.
2213
2214 2019-06-16  Tom de Vries  <tdevries@suse.de>
2215
2216         PR gdb/24445
2217         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2218
2219 2019-06-16  Tom Tromey  <tom@tromey.com>
2220
2221         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2222         (make_all_visible): Use address of member.
2223
2224 2019-06-16  Tom Tromey  <tom@tromey.com>
2225
2226         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2227         (tui_free_window, free_content, free_content_elements): Remove
2228         unnecessary cast.
2229         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2230         cast.
2231         * tui/tui-regs.c (tui_show_register_group)
2232         (tui_display_registers_from, tui_display_reg_element_at_line):
2233         Remove unnecessary cast.
2234
2235 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2236
2237         * linux-nat.c (normal_mask): Delete.
2238         (_initialize_linux_nat): Don't initialise normal_mask.
2239
2240 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2241
2242         PR gdb/24445
2243         * dwarf-index-write.h (write_psymtabs_to_index): Add
2244         dwz_basename parameter.
2245         * dwarf-index-write.c (write_gdbindex): Move file writing to
2246         write_gdbindex_1.  Change return type void.
2247         (assert_file_size): Move up, remove filename parameter.
2248         (write_gdbindex_1): New function.
2249         (write_debug_names): Change return type to void, call
2250         assert_file_size.
2251         (struct index_wip_file): New struct.
2252         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2253         file logic to index_wip_file.  Write index for dwz file if
2254         needed.
2255         (save_gdb_index_command): Pass basename of dwz file, if present.
2256         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2257         build-id of dwz file, if present.
2258         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2259         (dwarf2_get_dwz_file): Likewise.
2260         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2261         (dwarf2_get_dwz_file): Likewise.
2262
2263 2019-06-16  Tom Tromey  <tom@tromey.com>
2264
2265         * coffread.c (process_coff_symbol): Use xstrdup.
2266         * value.c (create_internalvar): Use xstrdup.
2267
2268 2019-06-16  Tom Tromey  <tom@tromey.com>
2269
2270         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2271         * breakpoint.c (stopin_command, stopat_command)
2272         (until_break_command, decode_location_default): Remove unnecessary
2273         cast.
2274         * utils.c (subset_compare): Remove unnecessary cast.
2275         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2276         cast.
2277         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2278         cast.
2279         * infcmd.c (path_command): Remove unnecessary cast.
2280         * coffread.c (decode_type): Remove unnecessary cast.
2281         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2282         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2283         * tui/tui-stack.c (tui_show_locator_content)
2284         (tui_show_frame_info): Remove unnecessary cast.
2285         * tui/tui-win.c (tui_scroll_forward_command)
2286         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2287         (parse_scrolling_args): Remove unnecessary cast.
2288         * tui/tui-data.c (init_win_info, tui_del_window)
2289         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2290         (free_content_elements): Remove unnecessary cast.
2291         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2292         unnecessary cast.
2293         * tui/tui-source.c (tui_set_source_content)
2294         (tui_vertical_source_scroll): Remove unnecessary cast.
2295         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2296         cast.
2297         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2298         * tui/tui-regs.c (tui_display_registers_from)
2299         (tui_display_register): Remove unnecessary cast.
2300         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2301         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2302         (make_visible): Remove unnecessary cast.
2303         * tui/tui-winsource.c (tui_erase_source_content)
2304         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2305         unnecessary cast.
2306         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2307         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2308         * stabsread.c (read_type, read_array_type, read_range_type):
2309         Remove unnecessary cast.
2310         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2311         (parse_symbol, parse_type, upgrade_type, parse_external)
2312         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2313         unnecessary cast.
2314         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2315
2316 2019-06-16  Tom Tromey  <tom@tromey.com>
2317
2318         * tui/tui-data.c (tui_alloc_generic_win_info)
2319         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2320         checks.
2321
2322 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2323             Andrew Burgess  <andrew.burgess@embecosm.com>
2324
2325         * f-typeprint.c (f_print_type): Don't return early for not
2326         associated or not allocated types.
2327         (f_type_print_varspec_suffix): Add print_rank parameter and print
2328         ranks of array types in case they dangling.
2329         (f_type_print_base): Add print_rank parameter.
2330
2331 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2332
2333         * NEWS: Mention new MI commands.
2334         * break-catch-throw.c (enum exception_event_kind): Move to
2335         breakpoint.h.
2336         (print_mention_exception_catchpoint): Output text as a single
2337         message.
2338         (catch_exception_command_1): Rename to...
2339         (catch_exception_event): ...this, make non-static, update header
2340         command, and change some parameter types.
2341         (catch_catch_command): Update for changes to
2342         catch_exception_command_1.
2343         (catch_throw_command): Likewise.
2344         (catch_rethrow_command): Likewise.
2345         * breakpoint.c (enum exception_event_kind): Delete.
2346         * breakpoint.h (enum exception_event_kind): Moved here from
2347         break-catch-throw.c.
2348         (catch_exception_event): Declare.
2349         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2350         (mi_cmd_catch_throw): New function.
2351         (mi_cmd_catch_rethrow): New function.
2352         (mi_cmd_catch_catch): New function.
2353         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2354         'catch-catch' entries.
2355         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2356         (mi_cmd_catch_rethrow): Declare.
2357         (mi_cmd_catch_catch): Declare.
2358
2359 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2360
2361         * annotate.c (annotate_source_line): Change return type to void,
2362         update implementation to match.
2363         * annotate.h (annotate_source_line): Change return type to void,
2364         update header comment.
2365         * stack.c (print_frame_info): Don't change what frame information
2366         is printed based on whether annotations are on or not.
2367
2368 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2369
2370         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2371         (annotate_source): Make static.
2372         (annotate_source_line): Moved from source.c and renamed from
2373         identify_source_line.  Update the return type.
2374         * annotate.h (annotate_source): Delete declaration.
2375         (annotate_source_line): Declaration moved from source.h, and
2376         renamed from identify_source_line.  Return type updated.
2377         * source.c (identify_source_line): Moved to annotate.c and renamed
2378         to annotate_source_line.
2379         (info_line_command): Remove check of annotation_level.
2380         * source.h (identify_source_line): Move declaration to annotate.h
2381         and rename to annotate_source_line.
2382         * stack.c: Add 'annotate.h' include.
2383         (print_frame_info): Remove check of annotation_level before
2384         calling annotate_source_line.
2385
2386 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2387
2388         * source-cache.c (source_cache::get_plain_source_lines): Use
2389         open_source_file_with_line_charpos instead of just
2390         open_source_file, remove call to find_source_lines.
2391         (source_cache::get_source_lines): Likewise.
2392         * source.c (find_source_lines): Make static.
2393         (get_filename_and_charpos): Renamed into...
2394         (open_source_file_with_line_charpos): ..this along with changes to
2395         return a scoped_fd, and some other minor clean ups.
2396         (identify_source_line): Use open_source_file_with_line_charpos.
2397         (search_command_helper): Use open_source_file_with_line_charpos
2398         instead of just open_source_file, remove call to
2399         find_source_lines.
2400         * source.h (open_source_file_with_line_charpos): Declare new
2401         function.
2402         (find_source_lines): Delete declaration.
2403
2404 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2405
2406         * source.c (get_filename_and_charpos): Remove fullname
2407         parameter.
2408         (identify_source_line): Update call to get_filename_and_charpos.
2409
2410 2019-06-14  Tom Tromey  <tromey@adacore.com>
2411
2412         PR gdb/24502:
2413         * ui-style.h (skip_ansi_escape): Update comment.
2414         * ui-file.h (class no_terminal_escape_file): New class.
2415         * ui-file.c (no_terminal_escape_file::write)
2416         (no_terminal_escape_file::puts): New methods.
2417         * cli/cli-logging.c (handle_redirections): Use
2418         no_terminal_escape_file.
2419
2420 2019-06-14  Tom Tromey  <tromey@adacore.com>
2421
2422         * NEWS: Move convenience variable news above Python news.
2423
2424 2019-06-14  Tom Tromey  <tom@tromey.com>
2425
2426         * gnulib: Move directory to top-level.
2427         * configure.ac: Don't configure gnulib.
2428         * configure: Rebuild.
2429         * common/common-defs.h: Use new path to gnulib.
2430         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2431         (GNULIB_H): Remove.
2432         (INCGNU): Look in new gnulib location.
2433         (HFILES_NO_SRCDIR): Remove gnulib files.
2434         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2435         (generated_files): Remove GNULIB_H.
2436         ($(LIBGNU), all-lib): Remove targets.
2437         (distclean): Don't mention GNULIB_BUILDDIR.
2438         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2439
2440 2019-06-14  Tom Tromey  <tromey@adacore.com>
2441
2442         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2443         Warn if symbol file does not provide any symbols.
2444
2445 2019-06-14  Tom Tromey  <tromey@adacore.com>
2446
2447         * source.c (find_and_open_source): Respect basenames_may_differ.
2448
2449 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2450
2451         * annotate.c (annotate_breakpoints_invalid): Make use of
2452         scoped_restore_terminal_state.
2453         (annotate_frames_invalid): Likewise.
2454
2455 2019-06-14  Tom Tromey  <tromey@adacore.com>
2456
2457         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2458         allow assignment to an internalvar.
2459
2460 2019-06-14  Tom Tromey  <tromey@adacore.com>
2461
2462         * ada-lex.l: Allow "_" in attribute names.
2463
2464 2019-06-14  Tom Tromey  <tromey@adacore.com>
2465
2466         PR gdb/24653:
2467         * regcache.c (registers_changed): Don't call alloca.
2468         * top.c (execute_command): Don't call alloca.
2469
2470 2019-06-13  Pedro Alves  <palves@redhat.com>
2471
2472         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2473         'expression'.  When parsing an expression, error out if there's
2474         junk after "unlimited".
2475         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2476         (do_set_command): Adjust calls to is_unlimited_literal.
2477
2478 2019-06-13  Pedro Alves  <palves@redhat.com>
2479
2480         * compile/compile.c (make_compile_options_def_group): Add braces
2481         around array_view initializer.
2482         * thread.c (make_thread_apply_all_options_def_group)
2483         (make_thread_apply_all_options_def_group): Likewise.
2484
2485 2019-06-13  Pedro Alves  <palves@redhat.com>
2486
2487         * NEWS (New commands): Mention "maint test-options
2488         require-delimiter", "maint test-options unknown-is-error", "maint
2489         test-options unknown-is-operand" and "maint show
2490         test-options-completion-result".
2491         (New command options, command completion): New section.
2492         (Completion improvements): New section.
2493         Mention that you can abbreviate "unlimited".
2494
2495 2019-06-13  Pedro Alves  <palves@redhat.com>
2496
2497         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2498         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2499         * unittests/cli-utils-selftests.c (test_parse_flags)
2500         (test_parse_flags_qcs): Delete.
2501         (test_cli_utils): Don't call deleted functions.
2502
2503 2019-06-13  Pedro Alves  <palves@redhat.com>
2504
2505         * thread.c: Include "cli/cli-option.h".
2506         (tp_array_compar_ascending): Global.
2507         (tp_array_compar): Delete function.
2508         (tp_array_compar_ascending, tp_array_compar_descending): New
2509         functions.
2510         (ascending_option_def, qcs_flag_option_def)
2511         (thr_qcs_flags_option_defs)
2512         (make_thread_apply_all_options_def_group)
2513         (make_thread_apply_options_def_group): New.
2514         (thread_apply_all_command): Use gdb::option::process_options.
2515         (thread_apply_command_completer)
2516         (thread_apply_all_command_completer): New.
2517         (thread_apply_command): Use gdb::option::process_options.
2518         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2519         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2520         to generate help text of "thread apply".  Adjust "taas"'s help.
2521         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2522         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2523
2524 2019-06-13  Pedro Alves  <palves@redhat.com>
2525
2526         * thread.c (thread_apply_command): Check for invalid TID with
2527         isdigit instead of !isalpha.
2528
2529 2019-06-13  Pedro Alves  <palves@redhat.com>
2530
2531         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2532         (validate_flags_qcs): New.
2533         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2534         (validate_flags_qcs): Declare.
2535         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2536         (make_frame_apply_options_def_group): New.
2537         (frame_apply_command_count): Process options with
2538         gdb::option::process_options.
2539         (frame_apply_completer): New.
2540         (frame_apply_level_completer, frame_apply_all_completer)
2541         (frame_apply_completer): New.
2542         (_initialize_stack): Update help of "frame apply", "frame apply
2543         level", "frame apply all" and "faas" to mention supported options
2544         and install command completers.
2545         * stack.h (frame_apply_all_completer): Declare.
2546         * thread.c: Include "stack.h".
2547         (tfaas_command): Add "--".
2548         (_initialize_thread): Update help "tfaas" to mention supported
2549         options and install command completer.
2550
2551 2019-06-13  Pedro Alves  <palves@redhat.com>
2552
2553         * completer.c (complete_nested_command_line): New.
2554         (gdb_completion_word_break_characters_throw): Add assertion.
2555         * completer.h (complete_nested_command_line): Declare.
2556
2557 2019-06-13  Pedro Alves  <palves@redhat.com>
2558
2559         * stack.c (parse_backtrace_qualifiers): New.
2560         (backtrace_command): Use it.
2561         (backtrace_command_completer): Complete on qualifiers.
2562
2563 2019-06-13  Pedro Alves  <palves@redhat.com>
2564
2565         * frame.c: Include "cli/cli-option.h.
2566         (user_set_backtrace_options): New.
2567         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2568         Delete.
2569         (get_prev_frame): Adjust.
2570         (boolean_option_def, uinteger_option_def)
2571         (set_backtrace_option_defs): New.
2572         (_initialize_frame): Adjust and use
2573         gdb::option::add_setshow_cmds_for_options to install "set
2574         backtrace past-main" and "set backtrace past-entry".
2575         * frame.h: Include "cli/cli-option.h".
2576         (struct frame_print_options): Forward declare.
2577         (print_frame_arguments_all, print_frame_arguments_scalars)
2578         (print_frame_arguments_none): Declare.
2579         (print_entry_values): Delete declaration.
2580         (struct frame_print_options, user_frame_print_options): New.
2581         (struct set_backtrace_options): New.
2582         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2583         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2584         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2585         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2586         (list_args_or_locals): Add frame_print_options parameter.
2587         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2588         * python/py-framefilter.c (enumerate_args): Pass down
2589         USER_FRAME_PRINT_OPTIONS.
2590         * stack.c: Include "cli/cli-option.h".
2591         (print_frame_arguments_all, print_frame_arguments_scalars)
2592         (print_frame_arguments_none): Declare.
2593         (print_raw_frame_arguments, print_entry_values): Delete.
2594         (user_frame_print_options): New.
2595         (boolean_option_def, enum_option_def, frame_print_option_defs):
2596         New.
2597         (struct backtrace_cmd_options): New.
2598         (bt_flag_option_def): New.
2599         (backtrace_command_option_defs): New.
2600         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2601         (print_frame_arg, read_frame_arg, print_frame_args)
2602         (print_frame_info, print_frame): Add frame_print_options parameter
2603         and use it.
2604         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2605         (backtrace_command_1): Add frame_print_options and
2606         backtrace_cmd_options parameters and use them.
2607         (make_backtrace_options_def_group): New.
2608         (backtrace_command): Process command options with
2609         gdb::option::process_options.
2610         (backtrace_command_completer): New.
2611         (_initialize_stack): Extend "backtrace"'s help to mention
2612         supported options.  Install completer for "backtrace".
2613         Install some settings commands with add_setshow_cmds_for_options.
2614
2615 2019-06-13  Pedro Alves  <palves@redhat.com>
2616
2617         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2618         and that "set/show print raw frame-arguments" are now deprecated.
2619
2620         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2621         command.
2622         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2623         * stack.c (_initialize_stack): Install "set/show print
2624         raw-frame-arguments", and deprecate "set/show print raw
2625         frame-arguments".
2626         * valprint.c (_initialize_valprint): Deprecate "set/show print
2627         raw".
2628
2629 2019-06-13  Pedro Alves  <palves@redhat.com>
2630
2631         * compile/compile.c (struct compile_options): New.
2632         (compile_flag_option_def, compile_command_option_defs)
2633         (make_compile_options_def_group): New.
2634         (compile_file_command): Handle options with
2635         gdb::option::process_options.
2636         (compile_file_command_completer): New function.
2637         (compile_code_command): Handle options with
2638         gdb::option::process_options.
2639         (compile_code_command_completer): New function.
2640         (_initialize_compiler): Install completers for "compile code" and
2641         "compile file".  Mention available options in "compile code" and
2642         "compile code"'s help.
2643         * completer.c (advance_to_completion_word): New, factored out from
2644         ...
2645         (advance_to_expression_complete_word_point): ... this.
2646         (advance_to_filename_complete_word_point): New.
2647         * completer.h (advance_to_filename_complete_word_point): New
2648         declaration.
2649
2650 2019-06-13  Pedro Alves  <palves@redhat.com>
2651
2652         * compile/compile.c: Include "cli/cli-option.h".
2653         (compile_print_value): Scope data pointer is now a
2654         value_print_options pointer; adjust.
2655         (compile_print_command): Process options.  Scope data pointer is
2656         now a value_print_options pointer; adjust.
2657         (_initialize_compile): Update "compile print"'s help to include
2658         supported options.  Install a completer for "compile print".
2659         * cp-valprint.c (show_vtblprint, show_objectprint)
2660         (show_static_field_print): Delete.
2661         (_initialize_cp_valprint): Don't install "set print
2662         static-members", "set print vtbl", "set print object" here.
2663         * printcmd.c: Include "cli/cli-option.h" and
2664         "common/gdb_optional.h".
2665         (print_command_parse_format): Rework to fill in a
2666         value_print_options instead of a format_data.
2667         (print_value): Change parameter type from format_data pointer to
2668         value_print_options reference.  Adjust.
2669         (print_command_1): Process options.  Adjust to pass down a
2670         value_print_options.
2671         (print_command_completer): New.
2672         (_initialize_printcmd): Install print_command_completer as
2673         handle_brkchars completer for the "print" command.  Update
2674         "print"'s help to include supported options.
2675         * valprint.c: Include "cli/cli-option.h".
2676         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2677         here from cp-valprint.c.
2678         (boolean_option_def, uinteger_option_def)
2679         (value_print_option_defs, make_value_print_options_def_group):
2680         New.  Use gdb::option::add_setshow_cmds_for_options to install
2681         "set print elements", "set print null-stop", "set print repeats",
2682         "set print pretty", "set print union", "set print array", "set
2683         print address", "set print symbol", "set print array-indexes".
2684         * valprint.h: Include <string> and "cli/cli-option.h".
2685         (make_value_print_options_def_group): Declare.
2686         (print_value): Change parameter type from format_data pointer to
2687         value_print_options reference.
2688         (print_command_completer): Declare.
2689
2690 2019-06-13  Pedro Alves  <palves@redhat.com>
2691
2692         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2693         (COMMON_SFILES): Add maint-test-settings.c.
2694         * cli/cli-decode.c (boolean_enums): New global, factored out from
2695         ...
2696         (add_setshow_boolean_cmd): ... here.
2697         * cli/cli-decode.h (boolean_enums): Declare.
2698         * cli/cli-option.c: New file.
2699         * cli/cli-option.h: New file.
2700         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2701         factored out from ...
2702         (parse_cli_boolean_value(const char *)): ... this.
2703         (is_unlimited_literal): Change parameter type to pointer to
2704         pointer.  Adjust and advance ARG pointer.
2705         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2706         (parse_cli_var_enum): New, factored out from ...
2707         (do_set_command): ... this.  Adjust.
2708         * cli/cli-setshow.h (parse_cli_boolean_value)
2709         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2710         (parse_cli_var_enum): Declare.
2711         * cli/cli-utils.c: Include "cli/cli-option.h".
2712         (get_ulongest): New.
2713         * cli/cli-utils.h (get_ulongest): Declare.
2714         (check_for_argument): New overloads.
2715         * maint-test-options.c: New file.
2716
2717 2019-06-13  Pedro Alves  <palves@redhat.com>
2718
2719         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2720         parse a range if "-" is at the end of the string.
2721
2722 2019-06-13  Pedro Alves  <palves@redhat.com>
2723
2724         * cli/cli-setshow.c (parse_auto_binary_operation)
2725         (parse_cli_boolean_value): Don't allow "o".
2726
2727 2019-06-13  Pedro Alves  <palves@redhat.com>
2728
2729         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2730         * NEWS: Mention maint test-settings KIND.
2731         * maint-test-settings.c: New file.
2732
2733 2019-06-13  Pedro Alves  <palves@redhat.com>
2734
2735         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2736         completer.
2737         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2738         "set" completers.
2739
2740 2019-06-13  Pedro Alves  <palves@redhat.com>
2741
2742         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2743         after item.
2744
2745 2019-06-13  Pedro Alves  <palves@redhat.com>
2746
2747         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2748
2749 2019-06-13  Pedro Alves <palves@redhat.com>
2750
2751         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2752         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2753         call.
2754         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2755         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2756         calls.
2757         (check_for_argument): Skip spaces after argument.
2758
2759 2019-06-13  Pedro Alves  <palves@redhat.com>
2760
2761         * thread.c (thread_apply_command): Adjust TID parsing.
2762         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2763         detected before end of string.
2764         (tid_is_in_list): Error out if LIST is invalid.
2765
2766 2019-06-13  Pedro Alves  <palves@redhat.com>
2767
2768         * completer.c (complete_line_internal_1): Rewind completion word
2769         point.
2770         (completion_tracker::advance_custom_word_point_by): Change
2771         parameter type to int.
2772         * completer.h (completion_tracker::advance_custom_word_point_by):
2773         Likewise.
2774
2775 2019-06-13  Pedro Alves  <palves@redhat.com>
2776
2777         * completer.c (advance_to_completion_word): Handle delimiters.
2778
2779 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2780
2781         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2782
2783 2019-06-11  Tom Tromey  <tom@tromey.com>
2784
2785         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2786         (xmalloc_failed): Move to alloc.c.
2787         * alloc.c: New file.
2788         * Makefile.in (COMMON_SFILES): Add alloc.c.
2789
2790 2019-06-11  Tom Tromey  <tom@tromey.com>
2791
2792         * nat/linux-waitpid.c: Don't include server.h.
2793         (linux_debug): Remove.
2794         (my_waitpid): Update.
2795
2796 2019-06-11  Tom Tromey  <tromey@adacore.com>
2797
2798         * infcall.c (_initialize_infcall): Remove trailing newline from
2799         help.
2800         * user-regs.c (_initialize_user_regs): Remove trailing newline
2801         from help.
2802         * typeprint.c (_initialize_typeprint): Remove trailing newline
2803         from help.
2804         * reverse.c (_initialize_reverse): Remove trailing newlines from
2805         help.
2806         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2807         from help.
2808         * language.c (add_set_language_command): Remove trailing newline
2809         from help.
2810         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2811         help.
2812         * disasm.c (_initialize_disasm): Remove trailing newline from
2813         help.
2814         * top.c (init_main): Remove trailing newline from help.
2815         * interps.c (_initialize_interpreter): Remove trailing newline
2816         from help.
2817         * btrace.c (_initialize_btrace): Remove trailing newlines from
2818         help.
2819         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2820         from help.
2821         * python/python.c (_initialize_python): Remove trailing newline
2822         from help.
2823         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2824         help.
2825         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2826         from help.  Reformat some text.
2827         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2828         from help.
2829         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2830         newline from help.
2831
2832 2019-06-11  Tom Tromey  <tromey@adacore.com>
2833
2834         * darwin-nat.c (darwin_decode_exception_message)
2835         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2836
2837 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2838
2839         * valops.c (value_slice): Check for not allocated or not
2840         associated values.
2841
2842 2019-06-10  Tom de Vries  <tdevries@suse.de>
2843
2844         PR gdb/24618
2845         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2846         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2847         invalid.
2848
2849 2019-06-10  Tom de Vries  <tdevries@suse.de>
2850
2851         PR gdb/24611
2852         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2853         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2854
2855 2019-06-10  Tom de Vries  <tdevries@suse.de>
2856
2857         PR symtab/24545
2858         * symtab.c (struct demangled_name_entry): Add language field.
2859         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2860         static minimal symbol".  Set and use language field.
2861
2862 2019-06-10  Tom Tromey  <tromey@adacore.com>
2863
2864         * ada-lang.c (_initialize_ada_language): Update help text.
2865
2866 2019-06-10  Tom Tromey  <tromey@adacore.com>
2867
2868         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2869         with a newline.
2870         * guile/guile.c (handle_boot_error): Don't end warning with a
2871         newline.
2872         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2873         warning with a newline.
2874         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2875         newline.
2876         (s12z_frame_cache): Likewise.
2877         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2878         a newline.
2879         * solib-svr4.c (disable_probes_interface): Don't end warning with
2880         a newline.
2881         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2882         newline.
2883         * python/python.c (do_finish_initialization): Don't end warning
2884         with a newline.
2885
2886 2019-06-10  Tom Tromey  <tom@tromey.com>
2887
2888         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2889         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2890         gdbpy_enter.
2891
2892 2019-06-10  Tom Tromey  <tromey@adacore.com>
2893
2894         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2895         data.
2896         (elf_new_init): Don't call stabsread_new_init.
2897         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2898         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2899         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2900
2901 2019-06-10  Tom de Vries  <tdevries@suse.de>
2902
2903         PR symtab/16264
2904         PR symtab/24517
2905         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2906
2907 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2908
2909         * source.c (find_and_open_source): Also rewrite relative file
2910         names.
2911
2912 2019-04-26  Amos Bird  <amosbird@gmail.com>
2913
2914         * annotate.c (annotate_thread_exited): Add "thread-exited"
2915         annotation.
2916
2917 2019-06-06  Tom Tromey  <tromey@adacore.com>
2918
2919         * maint.h (class scoped_command_stats): Use
2920         DISABLE_COPY_AND_ASSIGN.
2921         <print_time>: New method.
2922         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2923         print_time.
2924         (scoped_command_stats::print_time): New method.
2925
2926 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2927
2928         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2929         instructions of lengths 6 or 8 bytes.
2930
2931 2019-06-04  Pedro Alves  <palves@redhat.com>
2932
2933         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2934
2935         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2936         * breakpoint.c (condition_completer): Likewise.
2937         * cli/cli-dump.c (scan_expression): Likewise.
2938         * common/filestuff.c (mkdir_recursive): Likewise.
2939         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2940         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2941         (gdb_abspath): Likewise.
2942         * compile/compile-cplus-types.c
2943         (compile_cplus_instance::decl_name): Likewise.
2944         * completer.c (complete_explicit_location):
2945         (signal_completer, reg_or_group_completer_1): Likewise.
2946         * cp-support.c (cp_remove_params_if_any): Likewise.
2947         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2948         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2949         * infcmd.c (strip_bg_char): Likewise.
2950         * linespec.c (copy_token_string): Likewise.
2951         * mi/mi-main.c (output_cores): Likewise.
2952         * psymtab.c (psymtab_search_name):
2953         * symfile.c (test_set_ext_lang_command): Likewise.
2954         * target.c (target_fileio_read_stralloc): Likewise.
2955         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2956         * value.c (complete_internalvar): Likewise.
2957
2958 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2959
2960         Add objfile property to gdb.Type.
2961         * NEWS: Mention Python API addition.
2962         * python/py-type.c (typy_get_objfile): New method.
2963
2964 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2965
2966         * NEWS: Mention the new set|show style [title|highlight].
2967         Mention changes to "show style", "help" and "apropos".
2968
2969 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2970
2971         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2972         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2973         instead of print_help_for_command.
2974         (print_doc_of_command): New function.
2975         (help_list): Add 'apropos -v word' suggestion.
2976         (print_help_for_command): Style the command name using title style.
2977         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2978         (_initialize_cli_cmds): Describe -v in apropos_command help.
2979
2980 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2981
2982         * cli/cli-style.h (cli_style_option): Add name in constructor,
2983         add m_name class member, add constructor with intensity,
2984         add name class function.
2985         (cli_style_option::add_setshow_commands): Remove name argument.
2986         (highlight_style, title_style): New styles.
2987         * cli/cli-style.c (do_show): New function that shows a style
2988         characteristic styling the style name with itself.
2989         (set_style_name): New function.
2990         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2991         Update all callers according to the changes in cli/cli-style.h.
2992         * utils.h (fputs_highlighted): New function.
2993         * utils.c (fputs_highlighted): Likewise.
2994
2995 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2996
2997         * NEWS: Mention new pipe command and new convenience variables.
2998
2999 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3000
3001         * cli/cli-cmds.c (pipe_command): New function.
3002         (_initialize_cli_cmds): Call add_com for pipe_command.
3003         Define | as an alias for pipe.
3004         (exit_status_set_internal_vars): New function.
3005         (shell_escape): Call exit_status_set_internal_vars.
3006         cli/cli-decode.c (find_command_name_length): Recognize | as
3007         a single character command.
3008
3009 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3010
3011         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3012         top.c (execute_command_to_ui_file): New function, mostly a copy
3013         of execute_command_to_string.
3014         (execute_command_to_string): Implement by calling
3015         execute_command_to_ui_file.
3016
3017 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3018
3019         * top.h (saved_command_line): Remove declaration.
3020         * top.c (previous_saved_command_line, previous_repeat_arguments):
3021         New variables.
3022         (saved_command_line): Make static, define together with other
3023         'repeat variables'.
3024         (dont_repeat): Clear repeat_arguments.
3025         (repeat_previous, get_saved_command_line, save_command_line):
3026         New functions.
3027         (gdb_init): Initialize saved_command_line
3028         and previous_saved_command_line.
3029         * main.c (captured_main_1): Remove saved_command_line initialization.
3030         * event-top.c (handle_line_of_input): Update to use
3031         the new 'repeat' related functions instead of direct access to
3032         saved_command_line.
3033         * command.h (repeat_previous, get_saved_command_line,
3034         save_command_line): New declarations.
3035         (dont_repeat): Add comment.
3036
3037 2019-05-30  Tom Tromey  <tromey@adacore.com>
3038
3039         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3040         Fix comment.
3041         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3042
3043 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3044
3045         PR cli/24587
3046         * completer.c (complete): Initialize variable word.
3047
3048 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3049
3050         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3051         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3052         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3053         'body' is NULL to the outter 'if', protecting the '!is_define'
3054         situation as well.
3055
3056 2019-05-29  Tom Tromey  <tromey@adacore.com>
3057
3058         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3059         (dwarf_unknown): New function.
3060         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3061         (dwarf_type_encoding_name): Use dwarf_unknown.
3062
3063 2019-05-29  Tom Tromey  <tromey@adacore.com>
3064
3065         PR c++/20020:
3066         * cp-valprint.c (cp_print_value_fields): Call
3067         cp_print_static_field inside "try".
3068
3069 2019-05-29  Tom Tromey  <tromey@adacore.com>
3070
3071         * inflow.c (struct terminal_info): Add default operator=.
3072         * configure: Rebuild.
3073         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3074         -Wdeprecated-copy-dtor, -Wredundant-move.
3075
3076 2019-05-29  Tom Tromey  <tromey@adacore.com>
3077
3078         * NEWS: Add entry.
3079         * infcmd.c (print_return_value_1): Handle finish_print
3080         option.
3081         (show_print_finish): New function.
3082         (_initialize_infcmd): Add "set/show print finish" commands.
3083         * valprint.c (user_print_options): Initialize new member.
3084         * valprint.h (struct value_print_options) <finish_print>: New
3085         member.
3086
3087 2019-05-28  Tom Tromey  <tromey@adacore.com>
3088
3089         * ada-lang.c (ada_remove_Xbn_suffix)
3090         (find_old_style_renaming_symbol)
3091         (parse_old_style_renaming): Remove.
3092         (ada_find_renaming_symbol): Don't call
3093         find_old_style_renaming_symbol.
3094         (ada_is_renaming_symbol): Rename from
3095         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3096         bool.  Now static.
3097         (ada_read_var_value): Update and simplify.
3098         * ada-exp.y (write_var_or_type): Remove old code.
3099
3100 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3101
3102         * event-top.c: Remove include comment.
3103         * inflow.c (class scoped_ignore_sigttou): Move from here...
3104         * inflow.h (class scoped_ignore_sigttou): ...to here.
3105         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3106         * top.c:  Remove include comment.
3107
3108 2019-05-27  Tom Tromey  <tom@tromey.com>
3109
3110         * NEWS: Fix typo.
3111
3112 2019-05-22  Tom Tromey  <tromey@adacore.com>
3113
3114         * target.c (target_follow_exec): Constify parameter.
3115         * target-delegates.c: Rebuild.
3116         * remote.c (remote_target::follow_exec): Constify parameter.
3117         * infrun.c (follow_exec): Constify parameter.
3118         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3119         (target_follow_exec): Likewise.
3120
3121 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3122
3123         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3124         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3125
3126 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3127
3128         * NEWS: Add debugredirect and testsuite sections.
3129
3130 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3131
3132         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3133         target descriptions using exclusively floating point register name
3134         aliases.
3135
3136 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3137
3138         PR gdb/18644:
3139         * f-lang.c (build_fortran_types): Handle the case where
3140         gdbarch_floatformat_for_type returns a nullptr.
3141
3142 2019-05-21  Tom de Vries  <tdevries@suse.de>
3143
3144         PR cli/24587
3145         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3146
3147 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3148
3149         PR gdb/18644:
3150         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3151         16-byte floats.
3152         * i386-tdep.c (i386_floatformat_for_type): Use
3153         floatformats_ia64_quad for the 16-byte floating point component
3154         within a fortran 32-byte complex number.
3155
3156 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3157
3158         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3159         delete default constructor.
3160         (find_partial_die): Update to return const struct.
3161         (partial_die_parent_scope): Move variable declaration into scope
3162         of its use and change its type to auto.
3163         (guess_partial_die_structure_name): Likewise.
3164         (partial_die_info::fixup): Likewise.
3165
3166 2019-05-17  Tom Tromey  <tromey@adacore.com>
3167
3168         * source.c (find_and_open_source): Remove cast.
3169
3170 2019-05-17  Tom Tromey  <tromey@adacore.com>
3171
3172         * annotate.c (annotate_source): Make "filename" const.
3173         * annotate.h (annotate_source): Use const.
3174
3175 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3176
3177         * disasm.c (set_disassembler_options): Send errors to stderr.
3178
3179 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3180
3181         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3182         (cli_interp_base::set_logging): Check debug_redirect.
3183         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3184         * cli/cli-logging.c (debug_redirect): Add static variable.
3185         (pop_output_files): Add default param.
3186         (handle_redirections): Print debug setting.
3187         (show_logging_command): Likewise.
3188         (_initialize_cli_logging): Add debugredirect command.
3189         * interps.c (current_interp_set_logging): Add debug_redirect
3190         parameter.
3191         * interps.h (set_logging): Add debug_redirect parameter.
3192         (current_interp_set_logging): Likewise.
3193         * mi/mi-common.h: Likewise.
3194         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3195
3196 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3197             Tom Tromey  <tromey@adacore.com>
3198
3199         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3200         directly.
3201         * cli/cli-interp.h (make_logging_output): Remove declaration.
3202         * cli/cli-logging.c (make_logging_output): Remove function.
3203         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3204         directly.
3205         * ui-file.c (tee_file::tee_file): Remove bools.
3206         (tee_file::~tee_file): Remove deletes.
3207         * ui-file.h (tee_file): Remove bools.
3208
3209 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3210
3211         * mi/mi-cmds.h (mi_cmd_complete): New function.
3212         * mi/mi-main.c (mi_cmd_complete): Likewise.
3213         * mi/mi-cmds.c: Define new MI command -complete.
3214         * NEWS: Mention new -complete command.
3215
3216 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3217
3218         * completer.h (complete): New function.
3219         * completer.c (complete): Likewise.
3220         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3221         function defined in completer.h.
3222
3223 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3224
3225         * MAINTAINERS (Write After Approval): Add myself.
3226
3227 2019-05-17  Tom de Vries  <tdevries@suse.de>
3228
3229         PR gdb/24094
3230         * dwarf2read.c (struct cu_partial_die_info): New struct.
3231         (find_partial_die): Return cu_partial_die_info.
3232         (partial_die_parent_scope, guess_partial_die_structure_name)
3233         (partial_die_info::fixup): Handle new return type of find_partial_die.
3234
3235 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3236
3237         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3238         "std::string", simplifying the algorithm.
3239
3240 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3241
3242         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3243         (stap_static_probe_ops::get_probes): Likewise.
3244
3245 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3246
3247         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3248         '-')" and "else if".
3249         (stap_parse_single_operand): Join checks for
3250         "gdbarch_stap_parse_special_token_p" and
3251         "gdbarch_stap_parse_special_token" in the same "if" statement.
3252         Invert check when verifying for operation on register
3253         displacement.
3254
3255 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3256
3257         * stap-probe.c (stap_get_opcode): Update comment.
3258         (stap_get_expected_argument_type): Likewise.
3259         (handle_stap_probe): Likewise.
3260
3261 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3262
3263         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3264         return type to 'bool'.  Adjust comment.  Use 'bool' when
3265         appropriate.
3266         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3267         * stap-probe.c (stap_parse_argument_1): Likewise.
3268         (stap_is_operator): Likewise.
3269         (stap_is_generic_prefix): Likewise.
3270         (stap_is_register_prefix): Likewise.
3271         (stap_is_register_indirection_prefix): Likewise.
3272         (stap_is_integer_prefix): Likewise.
3273         (stap_generic_check_suffix): Likewise.
3274         (stap_check_integer_suffix): Likewise.
3275         (stap_check_register_suffix): Likewise.
3276         (stap_check_register_indirection_suffix): Likewise.
3277         (stap_parse_register_operand): Likewise.
3278         (stap_parse_single_operand): Likewise.
3279         (stap_parse_argument_1): Likewise.
3280         (stap_probe::get_argument_count): Likewise.
3281         (stap_is_operator): Likewise.
3282
3283 2019-05-16  Tom Tromey  <tromey@adacore.com>
3284
3285         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3286         keyword to foreach.
3287
3288 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3289
3290         * linux-thread-db.c (try_thread_db_load_1): Change return type
3291         to bool.
3292         (try_thread_db_load): Likewise.
3293         (try_thread_db_load_from_pdir_1): Likewise.
3294         (try_thread_db_load_from_pdir): Likewise.
3295         (try_thread_db_load_from_sdir): Likewise.
3296         (try_thread_db_load_from_dir): Likewise.
3297         (thread_db_load_search): Likewise.
3298         (has_libpthread): Likewise.
3299         (thread_db_load): Likewise.
3300
3301 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3302
3303         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3304         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3305         NULL, and complain/return if that's the case.
3306
3307 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3308
3309         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3310         (advance, posn, abstract_read_memory): New functions.
3311         [struct mem_read_abstraction]: New struct.
3312         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3313
3314 2019-05-14  Tom Tromey  <tromey@adacore.com>
3315
3316         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3317         value is not lval_memory.
3318
3319 2019-05-14  Tom Tromey  <tromey@adacore.com>
3320
3321         * solib.c (info_sharedlibrary_command): Style the file name.
3322
3323 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3324
3325         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3326         (aarch64_vnv_type): Likewise.
3327         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3328         * common/tdesc.c: Likewise.
3329         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3330         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3331         * features/aarch64-fpu.xml: Add ieee half view.
3332         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3333         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3334         * gdbtypes.h (struct builtin_type): Likewise.
3335         (struct objfile_type): Likewise.
3336
3337 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3338
3339         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3340         typo.
3341         * location.h (string_to_event_location): Likewise.
3342
3343 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3344
3345         GDB 8.3 released.
3346
3347 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3348
3349         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3350         New variable declaration.
3351         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3352         New variable.
3353         (print_one_breakpoint): Use ui_out::test_flags and new global
3354         variable to compute use_fixed_output.
3355         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3356         Remove.
3357         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3358         (mi_multi_location_breakpoint_output_fixed): Remove.
3359         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3360         new variable.
3361         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3362         fix_multi_location_breakpoint_output flag if version >= 3.
3363         * ui-out.h (enum ui_out_flag)
3364         <fix_multi_location_breakpoint_output>: New enumerator.
3365
3366 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3367
3368         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3369
3370 2019-05-10  Tom Tromey  <tromey@adacore.com>
3371
3372         * ada-lang.c (catch_ada_completer): New function.
3373         (_initialize_ada_language): Use it.
3374
3375 2019-05-10  Tom Tromey  <tromey@adacore.com>
3376
3377         * thread.c (print_thread_info): Make "requested_threads" const.
3378         * gdbthread.h (print_thread_info): Make "requested_threads"
3379         const.
3380         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3381         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3382
3383 2019-05-08  Tom Tromey  <tom@tromey.com>
3384
3385         * gdbtypes.c (objfile_type_data): Change type.
3386         (objfile_type, _initialize_gdbtypes): Update.
3387
3388 2019-05-08  Tom Tromey  <tom@tromey.com>
3389
3390         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3391         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3392         (_initialize_dwarf2_frame): Update.
3393
3394 2019-05-08  Tom Tromey  <tom@tromey.com>
3395
3396         * objc-lang.c (objc_objfile_data): Change type.
3397         (find_methods): Update.
3398         (_initialize_objc_lang): Remove.
3399
3400 2019-05-08  Tom Tromey  <tom@tromey.com>
3401
3402         * stabsread.c (rs6000_builtin_type_data): Change type.
3403         (rs6000_builtin_type, _initialize_stabsread): Update.
3404
3405 2019-05-08  Tom Tromey  <tom@tromey.com>
3406
3407         * mips-tdep.c (mips_pdr_data): Remove.
3408         (_initialize_mips_tdep): Update.
3409
3410 2019-05-08  Tom Tromey  <tom@tromey.com>
3411
3412         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3413         (hppa_init_objfile_priv_data, read_unwind_info)
3414         (find_unwind_entry, _initialize_hppa_tdep): Update.
3415
3416 2019-05-08  Tom Tromey  <tom@tromey.com>
3417
3418         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3419         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3420         on obstack.
3421         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3422
3423 2019-05-08  Tom Tromey  <tom@tromey.com>
3424
3425         * mdebugread.c (basic_type_data): Change type.
3426         (basic_type, _initialize_mdebugread): Update.
3427
3428 2019-05-08  Tom Tromey  <tom@tromey.com>
3429
3430         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3431
3432 2019-05-08  Tom Tromey  <tom@tromey.com>
3433
3434         * nto-tdep.c (nto_inferior_data_reg): Change type.
3435         (nto_inferior_data): Update.
3436         (nto_inferior_data_cleanup, nto_new_inferior_data)
3437         (_initialize_nto_tdep): Remove.
3438         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3439
3440 2019-05-08  Tom Tromey  <tom@tromey.com>
3441
3442         * ada-lang.c (struct ada_inferior_data): Add initializers.
3443         (ada_inferior_data): Change type.
3444         (ada_inferior_data_cleanup): Remove.
3445         (get_ada_inferior_data, ada_inferior_exit)
3446         (struct ada_pspace_data): Add initializers, destructor.
3447         (ada_pspace_data_handle): Change type.
3448         (get_ada_pspace_data): Update.
3449         (ada_pspace_data_cleanup): Remove.
3450
3451 2019-05-08  Tom Tromey  <tom@tromey.com>
3452
3453         * coffread.c (struct coff_symfile_info): Add initializers.
3454         (coff_objfile_data_key): Move lower.  Change type.
3455         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3456         Update.
3457         (coff_free_info): Remove.
3458
3459 2019-05-08  Tom Tromey  <tom@tromey.com>
3460
3461         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3462         (fbsd_pspace_data_handle): Move lower.  Change type.
3463         (get_fbsd_pspace_data): Update.
3464         (fbsd_pspace_data_cleanup): Remove.
3465         (_initialize_fbsd_tdep): Update.
3466
3467 2019-05-08  Tom Tromey  <tom@tromey.com>
3468
3469         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3470         (get_ada_tasks_pspace_data): Update.
3471         (ada_tasks_pspace_data_cleanup): Remove.
3472         (_initialize_tasks): Update.
3473         (ada_tasks_inferior_data_handle): Change type.
3474         (get_ada_tasks_inferior_data): Update.
3475         (ada_tasks_inferior_data_cleanup): Remove.
3476         (struct ada_tasks_pspace_data): Add initializers.
3477
3478 2019-05-08  Tom Tromey  <tom@tromey.com>
3479
3480         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3481         * symfile-debug.c (debug_sym_get_probes): Change type.
3482         * stap-probe.c (handle_stap_probe):
3483         (stap_static_probe_ops::get_probes): Change type.
3484         * probe.h (class static_probe_ops) <get_probes>: Change type.
3485         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3486         (parse_probes_in_pspace): Update.
3487         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3488         Update.
3489         (any_static_probe_ops::get_probes): Change type.
3490         * elfread.c (elfread_data): New typedef.
3491         (probe_key): Change type.
3492         (elf_get_probes): Likewise.  Update.
3493         (probe_key_free): Remove.
3494         (_initialize_elfread): Update.
3495         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3496         Change type.
3497         (dtrace_process_dof_probe, dtrace_process_dof)
3498         (dtrace_static_probe_ops::get_probe): Change type.
3499
3500 2019-05-08  Tom Tromey  <tom@tromey.com>
3501
3502         * xcoffread.c (struct xcoff_symfile_info): Rename from
3503         coff_symfile_info.  Add initializers.
3504         (xcoff_objfile_data_key): Move lower.  Change type.
3505         (XCOFF_DATA): Rewrite.
3506         (xcoff_free_info): Remove.
3507         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3508         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3509         (xcoff_initial_scan): Update.
3510
3511 2019-05-08  Tom Tromey  <tom@tromey.com>
3512
3513         * solib-svr4.c (struct svr4_info): Add initializers and
3514         destructor.
3515         <probes_table>: Now an htab_up.
3516         (solib_svr4_pspace_data): Change type.
3517         (free_probes_table): Simplify.
3518         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3519         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3520         (probes_table_remove_objfile_probes, register_solib_event_probe)
3521         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3522         (_initialize_svr4_solib): Update.
3523
3524 2019-05-08  Tom Tromey  <tom@tromey.com>
3525
3526         * remote.c (remote_pspace_data): Change type.
3527         (remote_pspace_data_cleanup): Remove.
3528         (get_remote_exec_file, set_pspace_remote_exec_file)
3529         (_initialize_remote): Update.
3530
3531 2019-05-08  Tom Tromey  <tom@tromey.com>
3532
3533         * breakpoint.c (breakpoint_objfile_key): Change type.
3534         (get_breakpoint_objfile_data): Update.
3535         (free_breakpoint_objfile_data): Remove.
3536         (_initialize_breakpoint): Update.
3537
3538 2019-05-08  Tom Tromey  <tom@tromey.com>
3539
3540         * linux-tdep.c (struct linux_info): Add initializers.
3541         (linux_inferior_data): Move.  Change type.
3542         (invalidate_linux_cache_inf): Update.
3543         (linux_inferior_data_cleanup): Remove.
3544         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3545
3546 2019-05-08  Tom Tromey  <tom@tromey.com>
3547
3548         * auxv.c (auxv_inferior_data): Move.  Change type.
3549         (auxv_inferior_data_cleanup): Remove.
3550         (invalidate_auxv_cache_inf): Rewrite.
3551         (get_auxv_inferior_data, _initialize_auxv): Update.
3552
3553 2019-05-08  Tom Tromey  <tom@tromey.com>
3554
3555         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3556         (symfile_debug_objfile_data_key): Change type.
3557         (symfile_debug_installed, debug_qf_has_symbols)
3558         (debug_qf_find_last_source_symtab)
3559         (debug_qf_forget_cached_source_info)
3560         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3561         (debug_qf_print_stats, debug_qf_dump)
3562         (debug_qf_expand_symtabs_for_function)
3563         (debug_qf_expand_all_symtabs)
3564         (debug_qf_expand_symtabs_with_fullname)
3565         (debug_qf_map_matching_symbols)
3566         (debug_qf_expand_symtabs_matching)
3567         (debug_qf_find_pc_sect_compunit_symtab)
3568         (debug_qf_map_symbol_filenames)
3569         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3570         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3571         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3572         (debug_sym_read_linetable, debug_sym_relocate): Update.
3573         (symfile_debug_free_objfile): Remove.
3574         (install_symfile_debug_logging, _initialize_symfile_debug):
3575         Update.
3576
3577 2019-05-08  Tom Tromey  <tom@tromey.com>
3578
3579         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3580         allocate_on_obstack.
3581         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3582         (get_dwarf2_per_objfile): Update.
3583         (set_dwarf2_per_objfile): Remove.
3584         (dwarf2_has_info, dwarf2_get_section_info): Update.
3585         (dwarf2_free_objfile): Remove.
3586         (_initialize_dwarf2_read): Update.
3587
3588 2019-05-08  Tom Tromey  <tom@tromey.com>
3589
3590         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3591         initializers.
3592         <unsupported_script_warning_printed,
3593         script_not_found_warning_printed>: Now bool.
3594         (auto_load_pspace_data): Change type.
3595         (~auto_load_pspace_info): Rename from
3596         auto_load_pspace_data_cleanup.
3597         (get_auto_load_pspace_data, init_loaded_scripts_info)
3598         (clear_section_scripts, maybe_print_unsupported_script_warning)
3599         (maybe_print_script_not_found_warning, _initialize_auto_load):
3600         Update.
3601
3602 2019-05-08  Tom Tromey  <tom@tromey.com>
3603
3604         * objfiles.c (objfile_pspace_info): Add destructor and
3605         initializers.
3606         (objfiles_pspace_data): Change type.
3607         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3608         (get_objfile_pspace_data): Update.
3609         (objfiles_bfd_data): Change type.
3610         (get_objfile_bfd_data): Update.
3611         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3612
3613 2019-05-08  Tom Tromey  <tom@tromey.com>
3614
3615         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3616         Change type.
3617         (get_catch_syscall_inferior_data): Update.
3618         (catch_syscall_inferior_data_cleanup): Remove.
3619         (_initialize_break_catch_syscall): Update.
3620
3621 2019-05-08  Tom Tromey  <tom@tromey.com>
3622
3623         * inflow.c (struct terminal_info): Add destructor and
3624         initializers.
3625         (inflow_inferior_data): Change type.
3626         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3627         (get_inflow_inferior_data, inflow_inferior_exit)
3628         (swap_terminal_info, _initialize_inflow): Update.
3629
3630 2019-05-08  Tom Tromey  <tom@tromey.com>
3631
3632         * target-dcache.c (target_dcache_cleanup): Remove.
3633         (target_dcache_aspace_key): Change type.
3634         (target_dcache_init_p, target_dcache_invalidate)
3635         (target_dcache_get, target_dcache_get_or_init)
3636         (_initialize_target_dcache): Update.
3637         * dcache.h (struct dcache_deleter): New.
3638
3639 2019-05-08  Tom Tromey  <tom@tromey.com>
3640
3641         * symtab.c (struct symbol_cache): Add destructor and
3642         initializers.
3643         (symbol_cache_key): Move.  Change type.
3644         (make_symbol_cache, free_symbol_cache): Remove.
3645         (get_symbol_cache): Update.
3646         (symbol_cache_cleanup): Remove.
3647         (ALL_PSPACES, symbol_cache_flush)
3648         (maintenance_print_symbol_cache)
3649         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3650         Update.
3651
3652 2019-05-08  Tom Tromey  <tom@tromey.com>
3653
3654         * symtab.c (struct main_info): Add destructor and initializers.
3655         (main_progspace_key): Move.  Change type.
3656         (get_main_info): Update.
3657         (main_info_cleanup): Remove.
3658         (_initialize_symtab): Update.
3659
3660 2019-05-08  Tom Tromey  <tom@tromey.com>
3661
3662         * registry.h (DECLARE_REGISTRY): Define the _key class.
3663
3664 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3665
3666         * NEWS: Merge two 'New commands' sections.
3667
3668 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3669
3670         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3671         parameter and use Ada language definition instead.
3672         (ada_val_print_ptr): Remove unused language parameter.
3673         (ada_val_print_num): Remove language parameter and use Ada language
3674         definition instead.
3675         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3676         parameter.
3677         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3678         parameter and use Ada language definition instead.
3679         (ada_val_print_1): Update all ada_val_print_xxx calls.
3680         Remove language parameter.
3681         (ada_val_print): Update ada_val_print_1 call.
3682
3683 2019-05-08  Tom Tromey  <tromey@adacore.com>
3684
3685         * remote.c (remote_hw_watchpoint_limit)
3686         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3687         Now static.
3688
3689 2019-05-08  Tom Tromey  <tromey@adacore.com>
3690
3691         * maint.c (_initialize_maint_cmds): Move initialization code to
3692         remote.c.
3693         (watchdog, show_watchdog): Move to remote.c.
3694         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3695         "watchdog" static.
3696         (_initialize_remote): Move initialization code from maint.c.
3697         * defs.h (watchdog): Don't declare.
3698
3699 2019-05-08  Tom Tromey  <tromey@adacore.com>
3700
3701         * tui/tui-interp.c: Include main.h.
3702         * interps.c: Include main.h.
3703         * main.h (interpreter_p): Declare.
3704         * defs.h (interpreter_p): Don't declare.
3705
3706 2019-05-08  Tom Tromey  <tromey@adacore.com>
3707
3708         * dwarf2loc.c: Include dwarf2read.h.
3709         * defs.h (read_unsigned_leb128): Don't declare.
3710         * dwarf2read.h (read_unsigned_leb128): Declare.
3711
3712 2019-05-08  Tom Tromey  <tromey@adacore.com>
3713
3714         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3715         method.
3716
3717 2019-05-08  Tom Tromey  <tromey@adacore.com>
3718
3719         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3720         when no wrap column is set.
3721
3722 2019-05-08  Tom Tromey  <tromey@adacore.com>
3723
3724         * c-lang.c (c_get_string): Handle non-C-style arrays.
3725
3726 2019-05-08  Tom Tromey  <tromey@adacore.com>
3727
3728         * typeprint.c (print_offset_data::update): Print the bit offset,
3729         not the number of bits remaining.
3730
3731 2019-05-08  Tom Tromey  <tromey@adacore.com>
3732
3733         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3734         padding at end of comment.
3735
3736 2019-05-08  Tom Tromey  <tromey@adacore.com>
3737
3738         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3739         Compare main types.
3740
3741 2019-05-06  Tom Tromey  <tom@tromey.com>
3742
3743         * common/scoped_mmap.c: Include common-defs.h.
3744         * common/scoped_mmap.h: Don't include config.h.
3745
3746 2019-05-04  Tom Tromey  <tom@tromey.com>
3747
3748         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3749         (struct aarch64_call_info): Add initializers.
3750         <si>: Now a std::vector.
3751         (pass_on_stack, aarch64_push_dummy_call): Update.
3752
3753 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3754             Tom Tromey  <tom@tromey.com>
3755
3756         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3757         (ppc_threads): Now a std::vector.  Now static.
3758         (hwdebug_find_thread_points_by_tid)
3759         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3760         Update.
3761
3762 2019-05-04  Tom Tromey  <tom@tromey.com>
3763
3764         * arc-tdep.c (arc_tdesc_init): Return bool.
3765
3766 2019-05-04  Tom Tromey  <tom@tromey.com>
3767
3768         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3769         Use gdb_assert_not_reached.
3770
3771 2019-05-04  Tom Tromey  <tom@tromey.com>
3772
3773         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3774         "false".
3775
3776 2019-05-04  Tom Tromey  <tom@tromey.com>
3777
3778         * arc-tdep.c (arc_tdesc_init): Use bool.
3779
3780 2019-05-04  Tom Tromey  <tom@tromey.com>
3781
3782         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3783
3784 2019-05-04  Tom Tromey  <tom@tromey.com>
3785
3786         * cli/cli-cmds.c (valid_command_p): Return bool.
3787
3788 2019-05-04  Tom Tromey  <tom@tromey.com>
3789
3790         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3791         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3792
3793 2019-05-04  Raul Tambre  <raul@tambre.ee>
3794
3795         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3796         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3797         operator for comparison.
3798
3799 2019-05-04  Tom Tromey  <tom@tromey.com>
3800
3801         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3802         (lookup_partial_symbol, print_partial_symbols)
3803         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3804         (psymbol_compare): Update.
3805         (add_psymbol_to_bcache): Clear the entire psymbol.
3806         (maintenance_check_psymtabs): Update.
3807         * psympriv.h (struct partial_symbol): Don't derive from
3808         general_symbol_info.
3809         <obj_section, unrelocated_address, address,
3810         set_unrelocated_address>: Update.
3811         <ginfo>: New member.
3812         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3813         (debug_names::write_psymbols): Update.
3814
3815 2019-05-04  Tom de Vries  <tdevries@suse.de>
3816
3817         * contrib/cc-with-tweaks.sh: Support -n arg.
3818
3819 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3820
3821         * corelow.c (core_target::detach): Ensure frame cache and
3822         register caches are cleared.
3823         inferior.c (exit_inferior_1): Likewise.
3824
3825 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3826             Tom Tromey  <tom@tromey.com>
3827
3828         * dictionary.c (collate_pending_symbols_by_language): Remove
3829         "struct" from foreach.
3830         * symtab.c (lookup_global_symbol_from_objfile)
3831         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3832         foreach.
3833         * ser-tcp.c (net_open): Remove "struct" from foreach.
3834         * objfiles.c (objfile_relocate, objfile_rebase)
3835         (objfile_has_symbols): Remove "struct" from foreach.
3836         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3837         from foreach.
3838         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3839         foreach.
3840         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3841         "struct" from foreach.
3842         * ada-lang.c (create_excep_cond_exprs)
3843         (ada_exception_catchpoint_cond_string): Remove "struct" from
3844         foreach.
3845
3846 2019-05-03  Tom Tromey  <tromey@adacore.com>
3847
3848         * ada-exp.y (convert_char_literal): Check suffix of each
3849         enumerator.
3850
3851 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3852
3853         PR ada/21406:
3854         * ada-exp.y (yywrap): Don't define.
3855         * ada-lex.l (%option): Add noyywrap
3856         (yywrap): Remove.
3857
3858 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3859
3860         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3861         _WIN32_WINNT to the XP level, unless already defined to a higher
3862         level.
3863
3864         * unittests/parse-connection-spec-selftests.c:
3865         * ser-tcp.c:
3866         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3867         override.
3868
3869         * symfile.c (find_separate_debug_file): Remove colon from the
3870         drive spec of DOS/Windows file names of the target, so that the
3871         file name produced from DEBUGDIR and the target's directory will
3872         be valid on DOS/Windows systems.
3873
3874 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3875
3876         * rust-lang.c (val_print_struct): Handle printing structures
3877         containing strings.
3878
3879 2019-05-02  Tom Tromey  <tromey@adacore.com>
3880
3881         * valarith.c (_initialize_valarith): Remove.
3882
3883 2019-05-01  Tom Tromey  <tromey@adacore.com>
3884
3885         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3886         bitfields.
3887
3888 2019-05-01  Tom Tromey  <tromey@adacore.com>
3889
3890         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3891         for big-endian copies.
3892
3893 2019-04-30  Ali Tamur  <tamur@google.com>
3894         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3895         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3896         (read_3_bytes): New function.
3897
3898 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3899
3900         * windows-nat.c (main_thread_id): Delete.
3901         (handle_output_debug_string): Replace main_thread_id by
3902         current_event.dwThreadId.
3903         (fake_create_process): Likewise.
3904         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3905         Do not set main_thread_id.
3906         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3907         current_event.dwThreadId.
3908         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3909
3910 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3911
3912         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3913         Use current_event.dwThreadId instead of main_thread_id.
3914
3915 2019-04-30  Tom Tromey  <tromey@adacore.com>
3916
3917         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3918         (create_excep_cond_exprs): Iterate over program spaces.
3919         (ada_exception_catchpoint_cond_string): Examine all minimal
3920         symbols for exception types.
3921
3922 2019-04-30  Tom Tromey  <tromey@adacore.com>
3923
3924         PR c++/24470:
3925         * dwarf2read.c (process_structure_scope): Handle case where type
3926         has template parameters but no symbol was created.
3927
3928 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3929             Chris January  <chris.january@arm.com>
3930
3931         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3932         qualifier.
3933         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3934
3935 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3936
3937         * f-typeprint.c (f_print_type): Update rules for printing
3938         whitespace.
3939         (f_type_print_varspec_suffix): Likewise.
3940
3941 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3942             Chris January  <chris.january@arm.com>
3943
3944         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3945         function arguments.
3946
3947 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3948
3949         * f-lang.c (build_fortran_types): Change name of void type to
3950         lower case.
3951         * f-typeprint.c (f_type_print_base): Print the name of the void
3952         type, rather than a fixed string.
3953         * f-valprint.c (f_decorations): Use lower case void string.
3954
3955 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3956             Chris January  <chris.january@arm.com>
3957
3958         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3959         types for Fortran.
3960
3961 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3962             Chris January  <chris.january@arm.com>
3963             David Lecomber  <david.lecomber@arm.com>
3964
3965         * f-exp.y (BINOP_INTRINSIC): New token.
3966         (exp): New parser rule handling BINOP_INTRINSIC.
3967         (f77_keywords): Add new builtin procedures.
3968         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3969         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3970         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3971         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3972         (print_unop_subexp_f): New function.
3973         (print_binop_subexp_f): New function.
3974         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3975         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3976         (dump_subexp_body_f): Likewise.
3977         (operator_check_f): Likewise.
3978         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3979         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3980
3981 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3982
3983         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3984         UNOP_KIND.
3985         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3986         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3987         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3988         (operator_length_f): New fuction.
3989         (print_subexp_f): New function.
3990         (op_name_f): New function.
3991         (dump_subexp_body_f): New function.
3992         (operator_check_f): New function.
3993         (exp_descriptor_f): Replace standard expression handling functions
3994         with new functions.
3995         * gdb/fortran-operator.def: New file.
3996         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3997         * gdb/std-operator.def: Remove UNOP_KIND.
3998
3999 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4000
4001         * std-operator.def: Remove unbalanced, stray double quote
4002         character.
4003
4004 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4005             Chris January  <chris.january@arm.com>
4006             Daniel Everett  <daniel.everett@arm.com>
4007             Nick Forrington  <nick.forrington@arm.com>
4008             Richard Bunt  <richard.bunt@arm.com>
4009
4010         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4011         of depth when printing anonymous structs or unions.
4012         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4013         Don't print either the top-level value, or the children if the
4014         max-depth is exceeded.
4015         (ppscm_print_children): When printing the key of a map, allow one
4016         extra level of depth.
4017         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4018         print either the top-level value, or the children if the max-depth
4019         is exceeded.
4020         (print_children): When printing the key of a map, allow one extra
4021         level of depth.
4022         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4023         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4024         (user_print_options): Initialise max_depth field.
4025         (val_print_scalar_or_string_type_p): New function.
4026         (val_print): Check to see if the max depth has been reached.
4027         (val_print_check_max_depth): Define new function.
4028         (show_print_max_depth): New function.
4029         (_initialize_valprint): Add 'print max-depth' option.
4030         * valprint.h (struct value_print_options) <max_depth>: New field.
4031         (val_print_check_max_depth): Declare new function.
4032         * NEWS: Document new feature.
4033
4034 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4035
4036         * ada-lang.c (ada_language_defn): Initialise new field.
4037         * c-lang.c (c_is_string_type_p): New function.
4038         (c_language_defn): Initialise new field.
4039         (cplus_language_defn): Initialise new field.
4040         (asm_language_defn): Initialise new field.
4041         (minimal_language_defn): Initialise new field.
4042         * c-lang.h (c_is_string_type_p): Declare new function.
4043         * d-lang.c (d_language_defn): Initialise new field.
4044         * f-lang.c (f_is_string_type_p): New function.
4045         (f_language_defn): Initialise new field.
4046         * go-lang.c (go_is_string_type_p): New function.
4047         (go_language_defn): Initialise new field.
4048         * language.c (default_is_string_type_p): New function.
4049         (unknown_language_defn): Initialise new field.
4050         (auto_language_defn): Initialise new field.
4051         * language.h (struct language_defn) <la_is_string_type_p>: New
4052         member variable.
4053         (default_is_string_type_p): Declare new function.
4054         * m2-lang.c (m2_language_defn): Initialise new field.
4055         * objc-lang.c (objc_language_defn): Initialise new field.
4056         * opencl-lang.c (opencl_language_defn): Initialise new field.
4057         * p-lang.c (pascal_is_string_type_p): New function.
4058         (pascal_language_defn): Initialise new field.
4059         * rust-lang.c (rust_is_string_type_p): New function.
4060         (rust_language_defn): Initialise new field.
4061
4062 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4063
4064         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4065         New field.
4066         * ada-lang.c (ada_language_defn): Initialise new field.
4067         * c-lang.c (c_language_defn): Likewise.
4068         (cplus_language_defn): Likewise.
4069         (asm_language_defn): Likewise.
4070         (minimal_language_defn): Likewise.
4071         * d-lang.c (d_language_defn): Likewise.
4072         * f-lang.c (f_language_defn): Likewise.
4073         * go-lang.c (go_language_defn): Likewise.
4074         * language.c (unknown_language_defn): Likewise.
4075         (auto_language_defn): Likewise.
4076         * m2-lang.c (m2_language_defn): Likewise.
4077         * objc-lang.c (objc_language_defn): Likewise.
4078         * opencl-lang.c (opencl_language_defn): Likewise.
4079         * p-lang.c (pascal_language_defn): Likewise.
4080         * rust-lang.c (rust_language_defn): Likewise.
4081
4082 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4083
4084         * ada-lang.c (ada_is_character_type): Change return type to bool.
4085         (ada_is_string_type): Likewise.
4086         * ada-lang.h (ada_is_character_type): Update declaration
4087         (ada_is_string_type): Likewise.
4088
4089 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4090
4091         Support style in 'frame|thread apply'
4092
4093         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4094         * record.c (record_start, record_stop): Update callers of
4095         execute_command_to_string with false.
4096         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4097         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4098         methods.
4099         (class string_file): New constructor with term_out parameter.
4100         Override methods term_out and can_emit_style_escape.  New member
4101         term_out.
4102         (class stdio_file): Override can_emit_style_escape.
4103         (class tee_file): Override term_out and can_emit_style_escape.
4104         * utils.h (can_emit_style_escape): Remove.
4105         * utils.c (can_emit_style_escape): Likewise.
4106         Update all callers of can_emit_style_escape (SOMESTREAM) to
4107         SOMESTREAM->can_emit_style_escape.
4108         * source-cache.c (source_cache::get_source_lines): Likewise.
4109         * stack.c (frame_apply_command_count): Call execute_command_to_string
4110         passing the term_out characteristic of the current gdb_stdout.
4111         * thread.c (thr_try_catch_cmd): Likewise.
4112         * top.c (execute_command_to_string): pass term_out parameter
4113         to construct the string_file for the command output.
4114         * ui-file.c (term_cli_styling): New function (most code moved
4115         from utils.c can_emit_style_escape).
4116         (string_file::string_file, string_file::can_emit_style_escape,
4117         stdio_file::can_emit_style_escape, tee_file::term_out,
4118         tee_file::can_emit_style_escape): New functions.
4119
4120 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4121
4122         * NEWS: Mention the new set|show may-call-functions.
4123         * infcall.c (may_call_functions_p): New variable.
4124         (show_may_call_functions_p): New function.
4125         (call_function_by_hand_dummy): Throws an error if not
4126         may-call-functions.
4127         (_initialize_infcall): Call add_setshow_boolean_cmd for
4128         may-call-functions.
4129
4130 2019-04-25  Keith Seitz  <keiths@redhat.com>
4131
4132         PR c++/24367
4133         * cp-support.c (inspect_type): Don't attempt substitutions
4134         of symbol with the same name.
4135
4136 2019-04-25  Tom Tromey  <tromey@adacore.com>
4137
4138         PR gdb/24475:
4139         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4140         static.
4141
4142 2019-04-25  Tom Tromey  <tromey@adacore.com>
4143
4144         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4145         rvalue reference.
4146         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4147         (gdb_xml_parser::parse): Use std::move.
4148         * python/python-internal.h (gdbpy_convert_exception): Take a const
4149         reference.
4150         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4151         std::move.
4152         * python/py-utils.c (gdbpy_convert_exception): Take a const
4153         reference.
4154         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4155         Use std::move.
4156         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4157         Use std::move.
4158         * mi/mi-main.c (mi_print_exception): Take a const reference.
4159         * main.c (handle_command_errors): Take a const reference.
4160         * linespec.c (parse_linespec): Use std::move.
4161         * infcall.c (run_inferior_call): Use std::move.
4162         (call_function_by_hand_dummy): Use std::move.
4163         * exec.c (try_open_exec_file): Use std::move.
4164         * exceptions.h (exception_print, exception_fprintf)
4165         (exception_print_same): Update.
4166         * exceptions.c (print_exception, exception_print)
4167         (exception_fprintf, exception_print_same): Change parameters to
4168         const reference.
4169         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4170         * common/new-op.c: Use std::move.
4171         * common/common-exceptions.h (struct gdb_exception): Add move
4172         constructor.
4173         (struct gdb_exception_error, struct gdb_exception_quit, struct
4174         gdb_quit_bad_alloc): Change constructor to move constructor.
4175         (throw_exception): Change parameter to rvalue reference.
4176         * common/common-exceptions.c (throw_exception): Take rvalue
4177         reference.
4178         * cli/cli-interp.c (safe_execute_command): Use std::move.
4179         * breakpoint.c (insert_bp_location, location_to_sals): Use
4180         std::move.
4181
4182 2019-04-25  Tom Tromey  <tromey@adacore.com>
4183
4184         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4185         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4186         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4187         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4188         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4189         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4190         guile/scm-value.c: Use unpack.
4191         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4192         gdbscm_gdb_exception.
4193         (gdbscm_throw_gdb_exception): Likewise.
4194         (struct gdbscm_gdb_exception): New.
4195         (unpack): New function.
4196         (gdbscm_wrap): Use unpack.
4197
4198 2019-04-25  Tom Tromey  <tromey@adacore.com>
4199
4200         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4201         (gdb_rl_callback_handler): Use std::move.
4202         * common/common-exceptions.h (struct gdb_exception): Add move
4203         assignment operator.
4204         (throw_exception_sjlj): Change "exception" to const reference.
4205         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4206         (throw_exception_sjlj): Change "exception" to const reference.
4207
4208 2019-04-25  Tom Tromey  <tromey@adacore.com>
4209
4210         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4211         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4212         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4213         Update.
4214         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4215         Update.
4216         * mi/mi-interp.c (mi_interp::exec): Update.
4217         * linespec.c (parse_linespec): Update.
4218         * infcall.c (run_inferior_call): Update.
4219         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4220         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4221         (gdbscm_lookup_global_symbol): Update.
4222         * guile/scm-param.c (gdbscm_parameter_value): Update.
4223         * guile/scm-frame.c (gdbscm_frame_read_register)
4224         (gdbscm_frame_read_var): Update.
4225         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4226         * exec.c (try_open_exec_file): Update.
4227         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4228         (gdb_rl_callback_handler): Update.
4229         * common/common-exceptions.h (exception_none): Don't declare.
4230         * common/common-exceptions.c (exception_none): Don't define.
4231         (struct catcher) <exception>: Update.
4232         * cli/cli-interp.c (safe_execute_command): Update.
4233         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4234
4235 2019-04-25  Ali Tamur  <tamur@google.com>
4236
4237         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4238         (read_attribute_value): Likewise.
4239         (dwarf2_read_addr_index): Update comment.
4240         (read_str_index): Add DW_FORM_strx.
4241         (dwarf2_string_attr): Likewise.
4242         (dwarf2_const_value_attr): Likewise.
4243         (dump_die_shallow): Likewise.
4244         (dwarf2_fetch_constant_bytes): Likewise.
4245         (skip_form_bytes): Likewise.
4246         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4247
4248 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4249
4250         PR corefiles/11608
4251         PR corefiles/18187
4252         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4253         OFFSET.  Verify if current mapping contains an ELF header.
4254         (linux_find_memory_regions_full): Adjust call to
4255         dump_mapping_p.
4256
4257 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4258             Kang Li <kanglictf@gmail.com>
4259
4260         PR gdb/21600
4261
4262         * dwarf2-frame.c (read_initial_length): Be consistent about using
4263         unsigned representation of length.
4264         (decode_frame_entry_1): Likewise.  Check for wraparound of
4265         end pointer as well as buffer overflow.
4266
4267 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4268
4269         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4270         "vq".
4271
4272 2019-04-24  Tom Tromey  <tromey@adacore.com>
4273
4274         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4275
4276 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4277
4278         * s12z-tdep.c (s12z_unwind_pc): Delete.
4279         (s12z_unwind_sp): Delete.
4280         (s12z_gdbarch_init): Don't register deleted functions with
4281         gdbarch.
4282
4283 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4284
4285         * rl78-tdep.c (rl78_unwind_sp): Delete.
4286         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4287
4288 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4289
4290         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4291         (xstormy16_unwind_pc): Delete.
4292         (xstormy16_dummy_id): Delete.
4293         (xstormy16_gdbarch_init): Don't register deleted functions with
4294         gdbarch.
4295
4296 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4297
4298         * vax-tdep.c (vax_unwind_pc): Delete.
4299         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4300
4301 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4302
4303         * v850-tdep.c (v850_unwind_sp): Delete.
4304         (v850_unwind_pc): Delete.
4305         (v850_dummy_id): Delete.
4306         (v850_gdbarch_init): Don't register deleted functions with
4307         gdbarch.
4308
4309 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4310
4311         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4312         (tilegx_unwind_pc): Delete.
4313         (tilegx_unwind_dummy_id): Delete.
4314         (tilegx_gdbarch_init): Don't register deleted functions with
4315         gdbarch.
4316
4317 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4318
4319         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4320         (tic6x_dummy_id): Delete.
4321         (tic6x_gdbarch_init): Don't register deleted functions with
4322         gdbarch.
4323
4324 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4325
4326         * sparc-tdep.c (sparc_unwind_pc): Delete.
4327         (sparc32_gdbarch_init): Don't register deleted function with
4328         gdbarch.
4329
4330 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4331
4332         * sh-tdep.c (sh_unwind_sp): Delete.
4333         (sh_unwind_pc): Delete.
4334         (sh_dummy_id): Delete.
4335         (sh_gdbarch_init): Don't register deleted functions with
4336         gdbarch.
4337
4338 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4339
4340         * score-tdep.c (score_unwind_sp): Delete.
4341         (score_unwind_pc): Delete.
4342         (score_dummy_id): Delete.
4343         (score_gdbarch_init): Don't register deleted functions with
4344         gdbarch.
4345
4346 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4347
4348         * rx-tdep.c (rx_unwind_pc): Delete.
4349         (rx_unwind_sp): Delete.
4350         (rx_dummy_id): Delete.
4351         (rx_gdbarch_init): Don't register deleted functions with
4352         gdbarch.  Update comment.
4353
4354 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4355
4356         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4357         (rs6000_dummy_id): Delete.
4358         (rs6000_gdbarch_init): Don't register deleted functions with
4359         gdbarch.
4360
4361 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4362
4363         * or1k-tdep.c (or1k_dummy_id): Delete.
4364         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4365
4366 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4367
4368         * nios2-tdep.c (nios2_dummy_id): Delete.
4369         (nios2_unwind_sp): Delete.
4370         (nios2_gdbarch_init): Don't register deleted functions with
4371         gdbarch.
4372
4373 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4374
4375         * nds32-tdep.c (nds32_dummy_id): Delete.
4376         (nds32_unwind_pc): Delete.
4377         (nds32_unwind_sp): Delete.
4378         (nds32_gdbarch_init): Don't register deleted functions with
4379         gdbarch.
4380
4381 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4382
4383         * msp430-tdep.c (msp430_unwind_pc): Delete.
4384         (msp430_unwind_sp): Delete.
4385         (msp430_dummy_id): Delete.
4386         (msp430_gdbarch_init): Don't register deleted functions with
4387         gdbarch.
4388
4389 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4390
4391         * moxie-tdep.c (moxie_unwind_sp): Delete.
4392         (moxie_unwind_pc): Delete.
4393         (moxie_dummy_id): Delete.
4394         (moxie_gdbarch_init): Don't register deleted functions with
4395         gdbarch.
4396
4397 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4398
4399         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4400         (mn10300_unwind_pc): Delete.
4401         (mn10300_unwind_sp): Delete.
4402         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4403         mn10300_unwind_sp.
4404         (mn10300_frame_unwind_init): Don't register deleted functions with
4405         gdbarch.
4406
4407 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4408
4409         * mep-tdep.c (mep_unwind_pc): Delete.
4410         (mep_unwind_sp): Delete.
4411         (mep_dummy_id): Delete.
4412         (mep_gdbarch_init): Don't register deleted functions with
4413         gdbarch.
4414
4415 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4416
4417         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4418         (m68hc11_unwind_sp): Delete.
4419         (m68hc11_gdbarch_init): Don't register deleted functions with
4420         gdbarch.
4421
4422 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4423
4424         * m32r-tdep.c (m32r_unwind_sp): Delete.
4425         (m32r_unwind_pc): Delete.
4426         (m32r_dummy_id): Delete.
4427         (m32r_gdbarch_init): Don't register deleted functions with
4428         gdbarch.
4429
4430 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4431
4432         * m32c-tdep.c (m32c_unwind_pc): Delete.
4433         (m32c_unwind_sp): Delete.
4434         (m32c_dummy_id): Delete.
4435         (m32c_gdbarch_init): Don't register deleted functions with
4436         gdbarch.
4437
4438 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4439
4440         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4441         (lm32_unwind_pc): Delete.
4442         (lm32_dummy_id): Delete.
4443         (lm32_gdbarch_init): Don't register deleted functions with
4444         gdbarch.
4445
4446 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4447
4448         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4449         (iq2000_unwind_pc): Delete.
4450         (iq2000_dummy_id): Delete.
4451         (iq2000_gdbarch_init): Don't register deleted functions with
4452         gdbarch.
4453
4454 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4455
4456         * nds32-tdep.c (nds32_type_align): Delete.
4457         (nds32_push_dummy_call): Use type_align instead.
4458
4459 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4460
4461         * arm-tdep.c (arm_type_align): Only handle vector override case.
4462         (arm_push_dummy_call): Use type_align.
4463         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4464
4465 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4466
4467         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4468         case.
4469         (pass_on_stack): Use type_align.
4470         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4471         function.
4472
4473 2019-04-23  Tom Tromey  <tromey@adacore.com>
4474
4475         * dwarf2read.c (line_header::file_name_at): Remove unused
4476         overload.
4477
4478 2019-04-23  Tom de Vries  <tdevries@suse.de>
4479
4480         PR gdb/24438
4481         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4482         invocation.
4483
4484
4485 2019-03-27  Ali Tamur  <tamur@google.com>
4486
4487         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4488         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4489         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4490         (dwarf_expr_context::get_addr_index): Likewise
4491         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4492         (symbol_needs_eval_context::get_addr_index): Likewise
4493         (disassemble_dwarf_expression): Add DW_OP_addrx
4494         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4495         (read_cutu_die_from_dwo): Update comment
4496         (skip_one_die): Add DW_FORM_addrx
4497         (read_attribute_value): Likewise
4498         (var_decode_location): Add DW_OP_addrx
4499         (dwarf2_const_value_attr): Add DW_FORM_addrx
4500         (dump_die_shallow): Likewise
4501         (dwarf2_fetch_constant_bytes): Likewise
4502         (decode_locdesc): Add DW_OP_addrx
4503         (skip_form_bytes): Add DW_FORM_addrx
4504
4505 2019-04-22  Ali Tamur  <tamur@google.com>
4506
4507         * MAINTAINERS (Write After Approval): Add self.
4508
4509 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4510
4511         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4512         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4513         (open_symbol_file_object): Likewise.
4514         (svr4_default_sos): Add info parameter.
4515         (svr4_read_so_list): Likewise.
4516         (svr4_current_sos_direct): Adjust functions calls to pass down
4517         info.
4518         (svr4_current_sos_1): Add info parameter.
4519         (svr4_current_sos): Call get_svr4_info, pass info down to
4520         svr4_current_sos_1.
4521         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4522         get_svr4_info.
4523         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4524         get_svr4_info.
4525         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4526         to get_svr4_info.
4527         (probes_table_remove_objfile_probes): Likewise.
4528         (register_solib_event_probe): Add info parameter.
4529         (solist_update_incremental): Pass info parameter down to
4530         svr4_read_so_list.
4531         (disable_probes_interface): Add info parameter.
4532         (svr4_handle_solib_event): Pass current_program_space to
4533         get_svr4_info.  Adjust disable_probes_interface cleanup.
4534         (svr4_create_probe_breakpoints): Add info parameter, pass it
4535         down to register_solib_event_probe.
4536         (svr4_create_solib_event_breakpoints): Add info parameter,
4537         pass it down to svr4_create_probe_breakpoints.
4538         (enable_break): Pass info down to
4539         svr4_create_solib_event_breakpoints.
4540         (svr4_solib_create_inferior_hook): Pass current_program_space to
4541         get_svr4_info.
4542         (svr4_clear_solib): Likewise.
4543
4544 2019-04-22  Pedro Alves  <palves@redhat.com>
4545
4546         * solib-svr4.c (svr4_free_objfile_observer): New.
4547         (probe_and_action::objfile): New field.
4548         (probes_table_htab_remove_objfile_probes)
4549         (probes_table_remove_objfile_probes): New functions.
4550         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4551         in the new probe_and_action.  Don't store the probe in 'lookup'.
4552         (svr4_create_probe_breakpoints): Pass objfile to
4553         register_solib_event_probe.
4554         (_initialize_svr4_solib): Register a free_objfile observer.
4555
4556 2019-04-19  Tom Tromey  <tom@tromey.com>
4557
4558         * common/queue.h: Remove.
4559
4560 2019-04-19  Tom Tromey  <tom@tromey.com>
4561
4562         * event-loop.c: Don't include "common/queue.h".
4563
4564 2019-04-19  Tom Tromey  <tom@tromey.com>
4565
4566         * remote.c (remote_target): Use delete.
4567         * remote-notif.h: Include <list>, not "common/queue.h".
4568         (notif_client_p): Remove typedef.
4569         (remote_notif_state): Add constructor, destructor, initializer.
4570         <notif_queue>: Now a std::list.
4571         (remote_notif_state_xfree): Don't declare.
4572         * remote-notif.c (remote_notif_process, handle_notification)
4573         (remote_notif_state_allocate): Update.
4574         (~remote_notif_state): Rename from remote_notif_state_xfree.
4575
4576 2019-04-19  Tom Tromey  <tom@tromey.com>
4577
4578         * symfile.c (reread_symbols): Update.
4579         * objfiles.c (objfile_register_static_link)
4580         (objfile_lookup_static_link): Update
4581         (~objfile) Don't delete static_links.
4582         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4583
4584 2019-04-19  Tom Tromey  <tom@tromey.com>
4585
4586         * type-stack.h (struct type_stack) <insert>: Constify string.
4587         * type-stack.c (type_stack::insert): Constify string.
4588         * gdbtypes.h (lookup_template_type): Update.
4589         (address_space_name_to_int): Update.
4590         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4591         const.
4592         (lookup_template_type): Make name const.
4593         * c-exp.y: Update rules.
4594         (lex_one_token, classify_name, classify_inner_name)
4595         (c_print_token): Update.
4596         * p-exp.y: Update rules.
4597         (yylex): Update.
4598         * f-exp.y: Update rules.
4599         (yylex): Update.
4600         * d-exp.y: Update rules.
4601         (lex_one_token, classify_name, classify_inner_name): Update.
4602         * parse.c (write_dollar_variable, copy_name): Return std::string.
4603         * parser-defs.h (copy_name): Change return type.
4604         * m2-exp.y: Update rules.
4605         (yylex): Update.
4606         * go-exp.y (lex_one_token): Update.
4607         Update rules.
4608         (classify_unsafe_function, classify_packaged_name)
4609         (classify_name, yylex): Update.
4610
4611 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4612
4613         * configure.ac: add --enable-source-highlight switch.
4614         * configure: Regenerate.
4615         * top.c (print_gdb_version): plumb --enable-source-highlight
4616         status to "show configuration".
4617
4618 2019-04-19  Tom Tromey  <tromey@adacore.com>
4619
4620         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4621         Check ADA_TYPE_P.
4622         (empty_record, ada_template_to_fixed_record_type_1)
4623         (template_to_static_fixed_type)
4624         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4625         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4626         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4627         macros.
4628
4629 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4630
4631         PR symtab/24423:
4632         * source.c (print_source_lines_base): Advance "iter" when a
4633         control character is seen.
4634
4635 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4636
4637         * inferior.h (struct infcall_suspend_state_deleter):
4638         Catch exception in destructor to avoid crash.
4639
4640 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4641
4642         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4643         close to the add_com "shell".
4644
4645 2019-04-18  Tom Tromey  <tromey@adacore.com>
4646
4647         * process-stratum-target.h (class process_stratum_target)
4648         <stratum>: Add "final".
4649
4650 2019-04-17  Tom Tromey  <tromey@adacore.com>
4651
4652         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4653         against nullptr before use.
4654
4655 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4656
4657         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4658
4659 2019-04-17  Jim Wilson  <jimw@sifive.com>
4660             Andrew Burgess  <andrew.burgess@embecosm.com>
4661
4662         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4663         code read might fail, assume 4-byte breakpoint in that case.
4664
4665 2019-04-15  Leszek Swirski  <leszeks@google.com>
4666
4667         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4668         rather than a hand-rolled POD check when checking for forced MEMORY
4669         classification.
4670
4671 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4672
4673         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4674         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4675         function.
4676         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4677         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4678         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4679         declaration.
4680
4681 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4682
4683         * aarch64-linux-nat.c
4684         (aarch64_linux_nat_target::thread_architecture): Add override.
4685         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4686         each VQ.
4687
4688 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4689
4690         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4691
4692 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4693
4694         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4695         target types of size 96-bits, add some additional comments, and
4696         check that the builtin type we found was the correct size.
4697
4698 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4699
4700         * utils.c (prompt_for_continue): Don't restore the styling at the
4701         end, as applied_style has the wrong value.  This fixes styling in
4702         long lists of file names that are interrupted by the "Continue?"
4703         prompt.
4704
4705 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4706
4707         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4708         * c-lang.c (c_language_defn): Likewise.
4709         (cplus_language_defn): Likewise.
4710         (asm_language_defn): Likewise.
4711         (minimal_language_defn): Likewise.
4712         * d-lang.c (d_language_defn): Likewise.
4713         * f-lang.c (f_language_defn): Likewise.
4714         * go-lang.c (go_language_defn): Likewise.
4715         * language.c (unknown_language_defn): Likewise.
4716         (auto_language_defn): Likewise.
4717         * language.h (struct language_defn): Remove la_magic field.
4718         (LANG_MAGIC): Delete.
4719         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4720         * objc-lang.c (objc_language_defn): Likewise.
4721         * opencl-lang.c (opencl_language_defn): Likewise.
4722         * p-lang.c (pascal_language_defn): Likewise.
4723         * rust-lang.c (rust_language_defn): Likewise.
4724
4725 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4726
4727         * riscv-tdep.c (riscv_type_align): New function.
4728         (riscv_type_alignment): Delete.
4729         (riscv_arg_location): Use 'type_align'.
4730         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4731
4732 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4733
4734         * gdbtypes.c (type_align): A struct with no non-static fields also
4735         has alignment of 1.
4736
4737 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4738
4739         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4740         component to 0.
4741         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4742         member.
4743         (riscv_struct_info::analyse): New implementation using new
4744         analyse_inner member function.
4745         (riscv_struct_info::field_offset): New member function.
4746         (riscv_struct_info::m_offsets): New member variable.
4747         (riscv_struct_info::analyse_inner): New private member function,
4748         takes the old implementation of riscv_struct_info::analyse but
4749         extended to track field offsets.
4750         (riscv_call_arg_struct): Update the struct folding special cases
4751         to handle cases where empty C++ structs, which are non-zero
4752         length, are found.
4753         (riscv_arg_location): Initialise the length of each location, a
4754         non-zero length now indicates the location is in use.
4755         (riscv_push_dummy_call): Allow for the first location having a
4756         non-zero offset when setting up arguments.
4757         (riscv_return_value): Likewise, but for return values.
4758
4759 2019-04-11  Tom Tromey  <tromey@adacore.com>
4760
4761         * utils.c (internal_vproblem): Make "msg" const.
4762
4763 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4764
4765         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4766         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4767         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4768         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4769
4770 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4771
4772         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4773         function.
4774         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4775         of amd64_collect_native_gregset.
4776         (amd64_linux_nat_target::store_registers): Likewise.
4777
4778 2019-04-10  Tom Tromey  <tom@tromey.com>
4779
4780         * symtab.c (lookup_global_symbol_from_objfile)
4781         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4782         * objfiles.h (class separate_debug_iterator): New.
4783         (class separate_debug_range): New.
4784         (struct objfile) <separate_debug_objfiles>: New method.
4785         (objfile_separate_debug_iterate): Don't declare.
4786         * objfiles.c (separate_debug_iterator::operator++): Rename from
4787         objfile_separate_debug_iterate.
4788         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4789         iterator.
4790         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4791         iterator.
4792
4793 2019-04-10  Tom Tromey  <tom@tromey.com>
4794
4795         * symfile.c (reread_symbols): Remove old comment.
4796         * objfiles.c (free_all_objfiles): Fix a typo.
4797
4798 2019-04-10  Tom Tromey  <tom@tromey.com>
4799
4800         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4801         * minsyms.c (lookup_minimal_symbol): Use foreach.
4802         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4803         (lookup_minimal_symbol_solib_trampoline): Likewise.
4804         * symfile.c (reread_symbols): Use foreach.
4805
4806 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4807             Tom Tromey  <tromey@adacore.com>
4808
4809         PR rust/24414:
4810         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4811         (rust_lex_int_test): Change "value" to be LONGEST.
4812         (rust_lex_tests): Add test for long integer literal.
4813
4814 2019-04-09  Tom Tromey  <tromey@adacore.com>
4815
4816         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4817         to bool.
4818         (extended_remote_target::attach): Update.
4819         (remote_target::remote_notice_new_inferior): Update.
4820         (remote_target::add_current_inferior_and_thread): Update.
4821         * inferior.c (exit_inferior_1): Use "false".
4822         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4823
4824 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4825
4826         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4827         the "start" command.
4828
4829 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4830
4831         * python/py-inferior.c (infpy_thread_from_thread_handle):
4832         Adjust comments to reflect renaming of thread_from_thread_handle
4833         to thread_from_handle.  Adjust keywords.  Fix type error message.
4834         (inferior_object_methods): Add thread_from_handle.  Retain
4835         thread_from_thread_handle, but mark it as deprecated.
4836
4837 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4838
4839         * gdbthread.h (find_thread_by_handle): Revise declaration.
4840         * thread.c (find_thread_by_handle): Likewise.  Adjust
4841         implementation too.
4842         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4843         support for buffer objects as handles.
4844
4845 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4846
4847         * python/py-infthread.c (thpy_thread_handle): New function.
4848         (thread_object_methods): Register thpy_thread_handle.
4849
4850 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4851
4852         * gdbthread.h (thread_to_thread_handle): Declare.
4853         * thread.c (gdbtypes.h): Include.
4854         (thread_to_thread_handle): New function.
4855
4856         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4857         (target_thread_info_to_thread_handle): Declare.
4858         * target.c (target_thread_info_to_thread_handle): New function.
4859         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4860         * target-delegates.c: Regenerate.
4861
4862         * linux-thread-db.c (class thread_db_target): Add method
4863         thread_info_to_thread_handle.
4864         (thread_db_target::thread_info_to_thread_handle): Define.
4865         * remote.c (class remote_target): Add new method
4866         thread_info_to_thread_handle.
4867         (remote_target::thread_info_to_thread_handle): Define.
4868
4869 2019-04-08  Pedro Alves  <palves@redhat.com>
4870
4871         * common/common-exceptions.c (throw_exception): Don't create
4872         named object to throw; throw directly.
4873         (throw_it): Likewise.  Don't initialize gdb_exception::message
4874         here, with new; pass FMT and AP to the ctor instead.
4875         * common/common-exceptions.h: Include <string>.
4876         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4877         const char *, va_list)): New ctor.  Use std::make_shared.
4878         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4879         errors)): Delete.
4880         (gdb_exception_error::gdb_exception_error(enum errors, const char
4881         *, va_list)): New.
4882         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4883         Add assertion.
4884         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4885         errors)): Delete.
4886         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4887         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4888         Add assertion.
4889
4890 2019-04-08  Tom Tromey  <tom@tromey.com>
4891
4892         * valops.c (value_rtti_indirect_type): Replace throw_exception
4893         with throw.
4894         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4895         with throw.
4896         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4897         throw.
4898         * target.c (target_translate_tls_address): Replace throw_exception
4899         with throw.
4900         * stack.c (frame_apply_command_count): Replace throw_exception
4901         with throw.
4902         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4903         throw.
4904         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4905         with throw.
4906         * rs6000-tdep.c (rs6000_frame_cache)
4907         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4908         * remote.c: Replace throw_exception with throw.
4909         * record-full.c (record_full_message, record_full_wait_1)
4910         (record_full_restore): Replace throw_exception with throw.
4911         * record-btrace.c:
4912         (get_thread_current_frame_id, record_btrace_start_replaying)
4913         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4914         (cmd_record_btrace_start): Replace throw_exception with throw.
4915         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4916         throw.
4917         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4918         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4919         * linespec.c:
4920         (find_linespec_symbols): Replace throw_exception with throw.
4921         * infrun.c (displaced_step_prepare, resume): Replace
4922         throw_exception with throw.
4923         * infcmd.c (post_create_inferior): Replace throw_exception with
4924         throw.
4925         * inf-loop.c (inferior_event_handler): Replace throw_exception
4926         with throw.
4927         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4928         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4929         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4930         (get_prev_frame_always, get_frame_pc_if_available)
4931         (get_frame_address_in_block_if_available, get_frame_language):
4932         Replace throw_exception with throw.
4933         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4934         throw_exception with throw.
4935         * eval.c (fetch_subexp_value, evaluate_var_value)
4936         (evaluate_funcall, evaluate_subexp_standard): Replace
4937         throw_exception with throw.
4938         * dwarf2loc.c (call_site_find_chain)
4939         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4940         Replace throw_exception with throw.
4941         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4942         with throw.
4943         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4944         throw.
4945         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4946         * completer.c (complete_line_internal): Replace throw_exception
4947         with throw.
4948         * compile/compile-object-run.c (compile_object_run): Replace
4949         throw_exception with throw.
4950         * cli/cli-script.c (process_next_line): Replace throw_exception
4951         with throw.
4952         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4953         (btrace_enable, btrace_maint_update_pt_packets): Replace
4954         throw_exception with throw.
4955         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4956         throw_exception with throw.
4957         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4958         throw_exception with throw.
4959         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4960         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4961         * aarch64-tdep.c (aarch64_make_prologue_cache)
4962         (aarch64_make_stub_cache): Replace throw_exception with throw.
4963
4964 2019-04-08  Tom Tromey  <tom@tromey.com>
4965
4966         * common/common-exceptions.c (throw_exception): Rename from
4967         throw_exception_cxx.  Remove old copy.  Make argument const.
4968         (throw_it): Create and throw exception objects directly.
4969         * common/common-exceptions.h (throw_exception): Make argument
4970         const.
4971         (struct gdb_exception_error): Add constructor.
4972         (struct gdb_exception_quit): Add constructor.
4973
4974 2019-04-08  Tom Tromey  <tom@tromey.com>
4975
4976         * common/common-exceptions.h (exception_rethrow): Don't declare.
4977         (TRY_SJLJ): Update comment.
4978         (TRY, CATCH, END_CATCH): Remove.
4979         * common/common-exceptions.c (exception_rethrow): Remove.
4980
4981 2019-04-08  Tom Tromey  <tom@tromey.com>
4982
4983         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4984         Remove.
4985         (gdb_exception_error): Rename from
4986         gdb_exception_RETURN_MASK_ERROR.
4987         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4988         (gdb_quit_bad_alloc): Update.
4989         * aarch64-tdep.c: Update.
4990         * ada-lang.c: Update.
4991         * ada-typeprint.c: Update.
4992         * ada-valprint.c: Update.
4993         * amd64-tdep.c: Update.
4994         * arch-utils.c: Update.
4995         * break-catch-throw.c: Update.
4996         * breakpoint.c: Update.
4997         * btrace.c: Update.
4998         * c-varobj.c: Update.
4999         * cli/cli-cmds.c: Update.
5000         * cli/cli-interp.c: Update.
5001         * cli/cli-script.c: Update.
5002         * common/common-exceptions.c: Update.
5003         * common/new-op.c: Update.
5004         * common/selftest.c: Update.
5005         * compile/compile-c-symbols.c: Update.
5006         * compile/compile-cplus-symbols.c: Update.
5007         * compile/compile-object-load.c: Update.
5008         * compile/compile-object-run.c: Update.
5009         * completer.c: Update.
5010         * corelow.c: Update.
5011         * cp-abi.c: Update.
5012         * cp-support.c: Update.
5013         * cp-valprint.c: Update.
5014         * darwin-nat.c: Update.
5015         * disasm-selftests.c: Update.
5016         * dtrace-probe.c: Update.
5017         * dwarf-index-cache.c: Update.
5018         * dwarf-index-write.c: Update.
5019         * dwarf2-frame-tailcall.c: Update.
5020         * dwarf2-frame.c: Update.
5021         * dwarf2loc.c: Update.
5022         * dwarf2read.c: Update.
5023         * eval.c: Update.
5024         * event-loop.c: Update.
5025         * event-top.c: Update.
5026         * exec.c: Update.
5027         * f-valprint.c: Update.
5028         * fbsd-tdep.c: Update.
5029         * frame-unwind.c: Update.
5030         * frame.c: Update.
5031         * gdbtypes.c: Update.
5032         * gnu-v3-abi.c: Update.
5033         * guile/guile-internal.h: Update.
5034         * guile/scm-block.c: Update.
5035         * guile/scm-breakpoint.c: Update.
5036         * guile/scm-cmd.c: Update.
5037         * guile/scm-disasm.c: Update.
5038         * guile/scm-frame.c: Update.
5039         * guile/scm-lazy-string.c: Update.
5040         * guile/scm-math.c: Update.
5041         * guile/scm-param.c: Update.
5042         * guile/scm-ports.c: Update.
5043         * guile/scm-pretty-print.c: Update.
5044         * guile/scm-symbol.c: Update.
5045         * guile/scm-symtab.c: Update.
5046         * guile/scm-type.c: Update.
5047         * guile/scm-value.c: Update.
5048         * i386-linux-tdep.c: Update.
5049         * i386-tdep.c: Update.
5050         * inf-loop.c: Update.
5051         * infcall.c: Update.
5052         * infcmd.c: Update.
5053         * infrun.c: Update.
5054         * jit.c: Update.
5055         * language.c: Update.
5056         * linespec.c: Update.
5057         * linux-fork.c: Update.
5058         * linux-nat.c: Update.
5059         * linux-tdep.c: Update.
5060         * linux-thread-db.c: Update.
5061         * main.c: Update.
5062         * mi/mi-cmd-break.c: Update.
5063         * mi/mi-cmd-stack.c: Update.
5064         * mi/mi-interp.c: Update.
5065         * mi/mi-main.c: Update.
5066         * objc-lang.c: Update.
5067         * p-valprint.c: Update.
5068         * parse.c: Update.
5069         * ppc-linux-tdep.c: Update.
5070         * printcmd.c: Update.
5071         * python/py-arch.c: Update.
5072         * python/py-breakpoint.c: Update.
5073         * python/py-cmd.c: Update.
5074         * python/py-finishbreakpoint.c: Update.
5075         * python/py-frame.c: Update.
5076         * python/py-framefilter.c: Update.
5077         * python/py-gdb-readline.c: Update.
5078         * python/py-inferior.c: Update.
5079         * python/py-infthread.c: Update.
5080         * python/py-lazy-string.c: Update.
5081         * python/py-linetable.c: Update.
5082         * python/py-objfile.c: Update.
5083         * python/py-param.c: Update.
5084         * python/py-prettyprint.c: Update.
5085         * python/py-progspace.c: Update.
5086         * python/py-record-btrace.c: Update.
5087         * python/py-record.c: Update.
5088         * python/py-symbol.c: Update.
5089         * python/py-type.c: Update.
5090         * python/py-unwind.c: Update.
5091         * python/py-utils.c: Update.
5092         * python/py-value.c: Update.
5093         * python/python.c: Update.
5094         * record-btrace.c: Update.
5095         * record-full.c: Update.
5096         * remote-fileio.c: Update.
5097         * remote.c: Update.
5098         * riscv-tdep.c: Update.
5099         * rs6000-aix-tdep.c: Update.
5100         * rs6000-tdep.c: Update.
5101         * rust-exp.y: Update.
5102         * rust-lang.c: Update.
5103         * s390-tdep.c: Update.
5104         * selftest-arch.c: Update.
5105         * solib-dsbt.c: Update.
5106         * solib-frv.c: Update.
5107         * solib-spu.c: Update.
5108         * solib-svr4.c: Update.
5109         * solib.c: Update.
5110         * sparc64-linux-tdep.c: Update.
5111         * stack.c: Update.
5112         * symfile-mem.c: Update.
5113         * symmisc.c: Update.
5114         * target.c: Update.
5115         * thread.c: Update.
5116         * top.c: Update.
5117         * tracefile-tfile.c: Update.
5118         * tui/tui.c: Update.
5119         * typeprint.c: Update.
5120         * unittests/cli-utils-selftests.c: Update.
5121         * unittests/parse-connection-spec-selftests.c: Update.
5122         * valops.c: Update.
5123         * valprint.c: Update.
5124         * value.c: Update.
5125         * varobj.c: Update.
5126         * windows-nat.c: Update.
5127         * x86-linux-nat.c: Update.
5128         * xml-support.c: Update.
5129
5130 2019-04-08  Tom Tromey  <tom@tromey.com>
5131
5132         * xml-support.c: Use C++ exception handling.
5133         * x86-linux-nat.c: Use C++ exception handling.
5134         * windows-nat.c: Use C++ exception handling.
5135         * varobj.c: Use C++ exception handling.
5136         * value.c: Use C++ exception handling.
5137         * valprint.c: Use C++ exception handling.
5138         * valops.c: Use C++ exception handling.
5139         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5140         handling.
5141         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5142         * typeprint.c: Use C++ exception handling.
5143         * tui/tui.c: Use C++ exception handling.
5144         * tracefile-tfile.c: Use C++ exception handling.
5145         * top.c: Use C++ exception handling.
5146         * thread.c: Use C++ exception handling.
5147         * target.c: Use C++ exception handling.
5148         * symmisc.c: Use C++ exception handling.
5149         * symfile-mem.c: Use C++ exception handling.
5150         * stack.c: Use C++ exception handling.
5151         * sparc64-linux-tdep.c: Use C++ exception handling.
5152         * solib.c: Use C++ exception handling.
5153         * solib-svr4.c: Use C++ exception handling.
5154         * solib-spu.c: Use C++ exception handling.
5155         * solib-frv.c: Use C++ exception handling.
5156         * solib-dsbt.c: Use C++ exception handling.
5157         * selftest-arch.c: Use C++ exception handling.
5158         * s390-tdep.c: Use C++ exception handling.
5159         * rust-lang.c: Use C++ exception handling.
5160         * rust-exp.y: Use C++ exception handling.
5161         * rs6000-tdep.c: Use C++ exception handling.
5162         * rs6000-aix-tdep.c: Use C++ exception handling.
5163         * riscv-tdep.c: Use C++ exception handling.
5164         * remote.c: Use C++ exception handling.
5165         * remote-fileio.c: Use C++ exception handling.
5166         * record-full.c: Use C++ exception handling.
5167         * record-btrace.c: Use C++ exception handling.
5168         * python/python.c: Use C++ exception handling.
5169         * python/py-value.c: Use C++ exception handling.
5170         * python/py-utils.c: Use C++ exception handling.
5171         * python/py-unwind.c: Use C++ exception handling.
5172         * python/py-type.c: Use C++ exception handling.
5173         * python/py-symbol.c: Use C++ exception handling.
5174         * python/py-record.c: Use C++ exception handling.
5175         * python/py-record-btrace.c: Use C++ exception handling.
5176         * python/py-progspace.c: Use C++ exception handling.
5177         * python/py-prettyprint.c: Use C++ exception handling.
5178         * python/py-param.c: Use C++ exception handling.
5179         * python/py-objfile.c: Use C++ exception handling.
5180         * python/py-linetable.c: Use C++ exception handling.
5181         * python/py-lazy-string.c: Use C++ exception handling.
5182         * python/py-infthread.c: Use C++ exception handling.
5183         * python/py-inferior.c: Use C++ exception handling.
5184         * python/py-gdb-readline.c: Use C++ exception handling.
5185         * python/py-framefilter.c: Use C++ exception handling.
5186         * python/py-frame.c: Use C++ exception handling.
5187         * python/py-finishbreakpoint.c: Use C++ exception handling.
5188         * python/py-cmd.c: Use C++ exception handling.
5189         * python/py-breakpoint.c: Use C++ exception handling.
5190         * python/py-arch.c: Use C++ exception handling.
5191         * printcmd.c: Use C++ exception handling.
5192         * ppc-linux-tdep.c: Use C++ exception handling.
5193         * parse.c: Use C++ exception handling.
5194         * p-valprint.c: Use C++ exception handling.
5195         * objc-lang.c: Use C++ exception handling.
5196         * mi/mi-main.c: Use C++ exception handling.
5197         * mi/mi-interp.c: Use C++ exception handling.
5198         * mi/mi-cmd-stack.c: Use C++ exception handling.
5199         * mi/mi-cmd-break.c: Use C++ exception handling.
5200         * main.c: Use C++ exception handling.
5201         * linux-thread-db.c: Use C++ exception handling.
5202         * linux-tdep.c: Use C++ exception handling.
5203         * linux-nat.c: Use C++ exception handling.
5204         * linux-fork.c: Use C++ exception handling.
5205         * linespec.c: Use C++ exception handling.
5206         * language.c: Use C++ exception handling.
5207         * jit.c: Use C++ exception handling.
5208         * infrun.c: Use C++ exception handling.
5209         * infcmd.c: Use C++ exception handling.
5210         * infcall.c: Use C++ exception handling.
5211         * inf-loop.c: Use C++ exception handling.
5212         * i386-tdep.c: Use C++ exception handling.
5213         * i386-linux-tdep.c: Use C++ exception handling.
5214         * guile/scm-value.c: Use C++ exception handling.
5215         * guile/scm-type.c: Use C++ exception handling.
5216         * guile/scm-symtab.c: Use C++ exception handling.
5217         * guile/scm-symbol.c: Use C++ exception handling.
5218         * guile/scm-pretty-print.c: Use C++ exception handling.
5219         * guile/scm-ports.c: Use C++ exception handling.
5220         * guile/scm-param.c: Use C++ exception handling.
5221         * guile/scm-math.c: Use C++ exception handling.
5222         * guile/scm-lazy-string.c: Use C++ exception handling.
5223         * guile/scm-frame.c: Use C++ exception handling.
5224         * guile/scm-disasm.c: Use C++ exception handling.
5225         * guile/scm-cmd.c: Use C++ exception handling.
5226         * guile/scm-breakpoint.c: Use C++ exception handling.
5227         * guile/scm-block.c: Use C++ exception handling.
5228         * guile/guile-internal.h: Use C++ exception handling.
5229         * gnu-v3-abi.c: Use C++ exception handling.
5230         * gdbtypes.c: Use C++ exception handling.
5231         * frame.c: Use C++ exception handling.
5232         * frame-unwind.c: Use C++ exception handling.
5233         * fbsd-tdep.c: Use C++ exception handling.
5234         * f-valprint.c: Use C++ exception handling.
5235         * exec.c: Use C++ exception handling.
5236         * event-top.c: Use C++ exception handling.
5237         * event-loop.c: Use C++ exception handling.
5238         * eval.c: Use C++ exception handling.
5239         * dwarf2read.c: Use C++ exception handling.
5240         * dwarf2loc.c: Use C++ exception handling.
5241         * dwarf2-frame.c: Use C++ exception handling.
5242         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5243         * dwarf-index-write.c: Use C++ exception handling.
5244         * dwarf-index-cache.c: Use C++ exception handling.
5245         * dtrace-probe.c: Use C++ exception handling.
5246         * disasm-selftests.c: Use C++ exception handling.
5247         * darwin-nat.c: Use C++ exception handling.
5248         * cp-valprint.c: Use C++ exception handling.
5249         * cp-support.c: Use C++ exception handling.
5250         * cp-abi.c: Use C++ exception handling.
5251         * corelow.c: Use C++ exception handling.
5252         * completer.c: Use C++ exception handling.
5253         * compile/compile-object-run.c: Use C++ exception handling.
5254         * compile/compile-object-load.c: Use C++ exception handling.
5255         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5256         * compile/compile-c-symbols.c: Use C++ exception handling.
5257         * common/selftest.c: Use C++ exception handling.
5258         * common/new-op.c: Use C++ exception handling.
5259         * cli/cli-script.c: Use C++ exception handling.
5260         * cli/cli-interp.c: Use C++ exception handling.
5261         * cli/cli-cmds.c: Use C++ exception handling.
5262         * c-varobj.c: Use C++ exception handling.
5263         * btrace.c: Use C++ exception handling.
5264         * breakpoint.c: Use C++ exception handling.
5265         * break-catch-throw.c: Use C++ exception handling.
5266         * arch-utils.c: Use C++ exception handling.
5267         * amd64-tdep.c: Use C++ exception handling.
5268         * ada-valprint.c: Use C++ exception handling.
5269         * ada-typeprint.c: Use C++ exception handling.
5270         * ada-lang.c: Use C++ exception handling.
5271         * aarch64-tdep.c: Use C++ exception handling.
5272
5273 2019-04-08  Tom Tromey  <tom@tromey.com>
5274
5275         * xml-support.c (gdb_xml_parser::parse): Update.
5276         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5277         * value.c (show_convenience): Update.
5278         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5279         (test_parse_flags_qcs): Update.
5280         * thread.c (thr_try_catch_cmd): Update.
5281         * target.c (target_translate_tls_address): Update.
5282         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5283         (info_frame_command_core, frame_apply_command_count): Update.
5284         * rust-exp.y (rust_lex_exception_test): Update.
5285         * riscv-tdep.c (riscv_print_one_register_info): Update.
5286         * remote.c (remote_target::enable_btrace): Update.
5287         * record-btrace.c (record_btrace_enable_warn): Update.
5288         * python/py-utils.c (gdbpy_convert_exception): Update.
5289         * printcmd.c (do_one_display, print_variable_and_value): Update.
5290         * mi/mi-main.c (mi_print_exception): Update.
5291         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5292         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5293         * linux-nat.c (linux_nat_target::attach): Update.
5294         * linux-fork.c (class scoped_switch_fork_info): Update.
5295         * infrun.c (displaced_step_prepare): Update.
5296         * infcall.c (call_function_by_hand_dummy): Update.
5297         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5298         * gnu-v3-abi.c (print_one_vtable): Update.
5299         * frame.c (get_prev_frame_always): Update.
5300         * f-valprint.c (info_common_command_for_block): Update.
5301         * exec.c (try_open_exec_file): Update.
5302         * exceptions.c (print_exception, exception_print)
5303         (exception_fprintf, exception_print_same): Update.
5304         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5305         * dwarf-index-cache.c (index_cache::store)
5306         (index_cache::lookup_gdb_index): Update.
5307         * darwin-nat.c (maybe_cache_shell): Update.
5308         * cp-valprint.c (cp_print_value_fields): Update.
5309         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5310         (gcc_cplus_symbol_address): Update.
5311         * compile/compile-c-symbols.c (gcc_convert_symbol)
5312         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5313         * common/selftest.c: Update.
5314         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5315         a std::string.
5316         (exception_try_scope_entry, exception_try_scope_exit): Don't
5317         declare.
5318         (struct exception_try_scope): Remove.
5319         (TRY): Don't use exception_try_scope.
5320         (struct gdb_exception): Add constructor, operator=.
5321         <what>: New method.
5322         (struct gdb_exception_RETURN_MASK_ALL)
5323         (struct gdb_exception_RETURN_MASK_ERROR)
5324         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5325         (struct gdb_quit_bad_alloc): Update.
5326         * common/common-exceptions.c (exception_none): Change
5327         initializer.
5328         (struct catcher) <state, exception>: Initialize inline.
5329         <prev>: Remove member.
5330         (current_catcher): Remove.
5331         (catchers): New global.
5332         (exceptions_state_mc_init): Simplify.
5333         (catcher_pop): Remove.
5334         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5335         (try_scope_depth, exception_try_scope_entry)
5336         (exception_try_scope_exit): Remove.
5337         (throw_exception_sjlj): Update.
5338         (exception_messages, exception_messages_size): Remove.
5339         (throw_it): Simplify.
5340         (gdb_exception_sliced_copy): Remove.
5341         (throw_exception_cxx): Update.
5342         * cli/cli-script.c (script_from_file): Update.
5343         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5344         Update.
5345         * ada-valprint.c (ada_val_print): Update.
5346         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5347         (create_excep_cond_exprs): Update.
5348
5349 2019-04-08  Tom Tromey  <tom@tromey.com>
5350
5351         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5352         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5353         (TRY, CATCH, END_CATCH): Remove some definitions.
5354         * common/common-exceptions.c: Don't use GDB_XCPT.
5355         (catcher_list_size): Remove.
5356         (throw_exception, throw_it): Simplify.
5357
5358 2019-04-05  Tom Tromey  <tom@tromey.com>
5359
5360         Revert the header-sorting patch.
5361         * ft32-tdep.c: Revert.
5362         * frv-tdep.c: Revert.
5363         * frv-linux-tdep.c: Revert.
5364         * frame.c: Revert.
5365         * frame-unwind.c: Revert.
5366         * frame-base.c: Revert.
5367         * fork-child.c: Revert.
5368         * findvar.c: Revert.
5369         * findcmd.c: Revert.
5370         * filesystem.c: Revert.
5371         * filename-seen-cache.h: Revert.
5372         * filename-seen-cache.c: Revert.
5373         * fbsd-tdep.c: Revert.
5374         * fbsd-nat.h: Revert.
5375         * fbsd-nat.c: Revert.
5376         * f-valprint.c: Revert.
5377         * f-typeprint.c: Revert.
5378         * f-lang.c: Revert.
5379         * extension.h: Revert.
5380         * extension.c: Revert.
5381         * extension-priv.h: Revert.
5382         * expprint.c: Revert.
5383         * exec.h: Revert.
5384         * exec.c: Revert.
5385         * exceptions.c: Revert.
5386         * event-top.c: Revert.
5387         * event-loop.c: Revert.
5388         * eval.c: Revert.
5389         * elfread.c: Revert.
5390         * dwarf2read.h: Revert.
5391         * dwarf2read.c: Revert.
5392         * dwarf2loc.c: Revert.
5393         * dwarf2expr.h: Revert.
5394         * dwarf2expr.c: Revert.
5395         * dwarf2-frame.c: Revert.
5396         * dwarf2-frame-tailcall.c: Revert.
5397         * dwarf-index-write.h: Revert.
5398         * dwarf-index-write.c: Revert.
5399         * dwarf-index-common.c: Revert.
5400         * dwarf-index-cache.h: Revert.
5401         * dwarf-index-cache.c: Revert.
5402         * dummy-frame.c: Revert.
5403         * dtrace-probe.c: Revert.
5404         * disasm.h: Revert.
5405         * disasm.c: Revert.
5406         * disasm-selftests.c: Revert.
5407         * dictionary.c: Revert.
5408         * dicos-tdep.c: Revert.
5409         * demangle.c: Revert.
5410         * dcache.h: Revert.
5411         * dcache.c: Revert.
5412         * darwin-nat.h: Revert.
5413         * darwin-nat.c: Revert.
5414         * darwin-nat-info.c: Revert.
5415         * d-valprint.c: Revert.
5416         * d-namespace.c: Revert.
5417         * d-lang.c: Revert.
5418         * ctf.c: Revert.
5419         * csky-tdep.c: Revert.
5420         * csky-linux-tdep.c: Revert.
5421         * cris-tdep.c: Revert.
5422         * cris-linux-tdep.c: Revert.
5423         * cp-valprint.c: Revert.
5424         * cp-support.c: Revert.
5425         * cp-namespace.c: Revert.
5426         * cp-abi.c: Revert.
5427         * corelow.c: Revert.
5428         * corefile.c: Revert.
5429         * continuations.c: Revert.
5430         * completer.h: Revert.
5431         * completer.c: Revert.
5432         * complaints.c: Revert.
5433         * coffread.c: Revert.
5434         * coff-pe-read.c: Revert.
5435         * cli-out.h: Revert.
5436         * cli-out.c: Revert.
5437         * charset.c: Revert.
5438         * c-varobj.c: Revert.
5439         * c-valprint.c: Revert.
5440         * c-typeprint.c: Revert.
5441         * c-lang.c: Revert.
5442         * buildsym.c: Revert.
5443         * buildsym-legacy.c: Revert.
5444         * build-id.h: Revert.
5445         * build-id.c: Revert.
5446         * btrace.c: Revert.
5447         * bsd-uthread.c: Revert.
5448         * breakpoint.h: Revert.
5449         * breakpoint.c: Revert.
5450         * break-catch-throw.c: Revert.
5451         * break-catch-syscall.c: Revert.
5452         * break-catch-sig.c: Revert.
5453         * blockframe.c: Revert.
5454         * block.c: Revert.
5455         * bfin-tdep.c: Revert.
5456         * bfin-linux-tdep.c: Revert.
5457         * bfd-target.c: Revert.
5458         * bcache.c: Revert.
5459         * ax-general.c: Revert.
5460         * ax-gdb.h: Revert.
5461         * ax-gdb.c: Revert.
5462         * avr-tdep.c: Revert.
5463         * auxv.c: Revert.
5464         * auto-load.c: Revert.
5465         * arm-wince-tdep.c: Revert.
5466         * arm-tdep.c: Revert.
5467         * arm-symbian-tdep.c: Revert.
5468         * arm-pikeos-tdep.c: Revert.
5469         * arm-obsd-tdep.c: Revert.
5470         * arm-nbsd-tdep.c: Revert.
5471         * arm-nbsd-nat.c: Revert.
5472         * arm-linux-tdep.c: Revert.
5473         * arm-linux-nat.c: Revert.
5474         * arm-fbsd-tdep.c: Revert.
5475         * arm-fbsd-nat.c: Revert.
5476         * arm-bsd-tdep.c: Revert.
5477         * arch-utils.c: Revert.
5478         * arc-tdep.c: Revert.
5479         * arc-newlib-tdep.c: Revert.
5480         * annotate.h: Revert.
5481         * annotate.c: Revert.
5482         * amd64-windows-tdep.c: Revert.
5483         * amd64-windows-nat.c: Revert.
5484         * amd64-tdep.c: Revert.
5485         * amd64-sol2-tdep.c: Revert.
5486         * amd64-obsd-tdep.c: Revert.
5487         * amd64-obsd-nat.c: Revert.
5488         * amd64-nbsd-tdep.c: Revert.
5489         * amd64-nbsd-nat.c: Revert.
5490         * amd64-nat.c: Revert.
5491         * amd64-linux-tdep.c: Revert.
5492         * amd64-linux-nat.c: Revert.
5493         * amd64-fbsd-tdep.c: Revert.
5494         * amd64-fbsd-nat.c: Revert.
5495         * amd64-dicos-tdep.c: Revert.
5496         * amd64-darwin-tdep.c: Revert.
5497         * amd64-bsd-nat.c: Revert.
5498         * alpha-tdep.c: Revert.
5499         * alpha-obsd-tdep.c: Revert.
5500         * alpha-nbsd-tdep.c: Revert.
5501         * alpha-mdebug-tdep.c: Revert.
5502         * alpha-linux-tdep.c: Revert.
5503         * alpha-linux-nat.c: Revert.
5504         * alpha-bsd-tdep.c: Revert.
5505         * alpha-bsd-nat.c: Revert.
5506         * aix-thread.c: Revert.
5507         * agent.c: Revert.
5508         * addrmap.c: Revert.
5509         * ada-varobj.c: Revert.
5510         * ada-valprint.c: Revert.
5511         * ada-typeprint.c: Revert.
5512         * ada-tasks.c: Revert.
5513         * ada-lang.c: Revert.
5514         * aarch64-tdep.c: Revert.
5515         * aarch64-ravenscar-thread.c: Revert.
5516         * aarch64-newlib-tdep.c: Revert.
5517         * aarch64-linux-tdep.c: Revert.
5518         * aarch64-linux-nat.c: Revert.
5519         * aarch64-fbsd-tdep.c: Revert.
5520         * aarch64-fbsd-nat.c: Revert.
5521         * aarch32-linux-nat.c: Revert.
5522
5523 2019-04-05  Tom Tromey  <tom@tromey.com>
5524
5525         * ft32-tdep.c: Sort headers.
5526         * frv-tdep.c: Sort headers.
5527         * frv-linux-tdep.c: Sort headers.
5528         * frame.c: Sort headers.
5529         * frame-unwind.c: Sort headers.
5530         * frame-base.c: Sort headers.
5531         * fork-child.c: Sort headers.
5532         * findvar.c: Sort headers.
5533         * findcmd.c: Sort headers.
5534         * filesystem.c: Sort headers.
5535         * filename-seen-cache.h: Sort headers.
5536         * filename-seen-cache.c: Sort headers.
5537         * fbsd-tdep.c: Sort headers.
5538         * fbsd-nat.h: Sort headers.
5539         * fbsd-nat.c: Sort headers.
5540         * f-valprint.c: Sort headers.
5541         * f-typeprint.c: Sort headers.
5542         * f-lang.c: Sort headers.
5543         * extension.h: Sort headers.
5544         * extension.c: Sort headers.
5545         * extension-priv.h: Sort headers.
5546         * expprint.c: Sort headers.
5547         * exec.h: Sort headers.
5548         * exec.c: Sort headers.
5549         * exceptions.c: Sort headers.
5550         * event-top.c: Sort headers.
5551         * event-loop.c: Sort headers.
5552         * eval.c: Sort headers.
5553         * elfread.c: Sort headers.
5554         * dwarf2read.h: Sort headers.
5555         * dwarf2read.c: Sort headers.
5556         * dwarf2loc.c: Sort headers.
5557         * dwarf2expr.h: Sort headers.
5558         * dwarf2expr.c: Sort headers.
5559         * dwarf2-frame.c: Sort headers.
5560         * dwarf2-frame-tailcall.c: Sort headers.
5561         * dwarf-index-write.h: Sort headers.
5562         * dwarf-index-write.c: Sort headers.
5563         * dwarf-index-common.c: Sort headers.
5564         * dwarf-index-cache.h: Sort headers.
5565         * dwarf-index-cache.c: Sort headers.
5566         * dummy-frame.c: Sort headers.
5567         * dtrace-probe.c: Sort headers.
5568         * disasm.h: Sort headers.
5569         * disasm.c: Sort headers.
5570         * disasm-selftests.c: Sort headers.
5571         * dictionary.c: Sort headers.
5572         * dicos-tdep.c: Sort headers.
5573         * demangle.c: Sort headers.
5574         * dcache.h: Sort headers.
5575         * dcache.c: Sort headers.
5576         * darwin-nat.h: Sort headers.
5577         * darwin-nat.c: Sort headers.
5578         * darwin-nat-info.c: Sort headers.
5579         * d-valprint.c: Sort headers.
5580         * d-namespace.c: Sort headers.
5581         * d-lang.c: Sort headers.
5582         * ctf.c: Sort headers.
5583         * csky-tdep.c: Sort headers.
5584         * csky-linux-tdep.c: Sort headers.
5585         * cris-tdep.c: Sort headers.
5586         * cris-linux-tdep.c: Sort headers.
5587         * cp-valprint.c: Sort headers.
5588         * cp-support.c: Sort headers.
5589         * cp-namespace.c: Sort headers.
5590         * cp-abi.c: Sort headers.
5591         * corelow.c: Sort headers.
5592         * corefile.c: Sort headers.
5593         * continuations.c: Sort headers.
5594         * completer.h: Sort headers.
5595         * completer.c: Sort headers.
5596         * complaints.c: Sort headers.
5597         * coffread.c: Sort headers.
5598         * coff-pe-read.c: Sort headers.
5599         * cli-out.h: Sort headers.
5600         * cli-out.c: Sort headers.
5601         * charset.c: Sort headers.
5602         * c-varobj.c: Sort headers.
5603         * c-valprint.c: Sort headers.
5604         * c-typeprint.c: Sort headers.
5605         * c-lang.c: Sort headers.
5606         * buildsym.c: Sort headers.
5607         * buildsym-legacy.c: Sort headers.
5608         * build-id.h: Sort headers.
5609         * build-id.c: Sort headers.
5610         * btrace.c: Sort headers.
5611         * bsd-uthread.c: Sort headers.
5612         * breakpoint.h: Sort headers.
5613         * breakpoint.c: Sort headers.
5614         * break-catch-throw.c: Sort headers.
5615         * break-catch-syscall.c: Sort headers.
5616         * break-catch-sig.c: Sort headers.
5617         * blockframe.c: Sort headers.
5618         * block.c: Sort headers.
5619         * bfin-tdep.c: Sort headers.
5620         * bfin-linux-tdep.c: Sort headers.
5621         * bfd-target.c: Sort headers.
5622         * bcache.c: Sort headers.
5623         * ax-general.c: Sort headers.
5624         * ax-gdb.h: Sort headers.
5625         * ax-gdb.c: Sort headers.
5626         * avr-tdep.c: Sort headers.
5627         * auxv.c: Sort headers.
5628         * auto-load.c: Sort headers.
5629         * arm-wince-tdep.c: Sort headers.
5630         * arm-tdep.c: Sort headers.
5631         * arm-symbian-tdep.c: Sort headers.
5632         * arm-pikeos-tdep.c: Sort headers.
5633         * arm-obsd-tdep.c: Sort headers.
5634         * arm-nbsd-tdep.c: Sort headers.
5635         * arm-nbsd-nat.c: Sort headers.
5636         * arm-linux-tdep.c: Sort headers.
5637         * arm-linux-nat.c: Sort headers.
5638         * arm-fbsd-tdep.c: Sort headers.
5639         * arm-fbsd-nat.c: Sort headers.
5640         * arm-bsd-tdep.c: Sort headers.
5641         * arch-utils.c: Sort headers.
5642         * arc-tdep.c: Sort headers.
5643         * arc-newlib-tdep.c: Sort headers.
5644         * annotate.h: Sort headers.
5645         * annotate.c: Sort headers.
5646         * amd64-windows-tdep.c: Sort headers.
5647         * amd64-windows-nat.c: Sort headers.
5648         * amd64-tdep.c: Sort headers.
5649         * amd64-sol2-tdep.c: Sort headers.
5650         * amd64-obsd-tdep.c: Sort headers.
5651         * amd64-obsd-nat.c: Sort headers.
5652         * amd64-nbsd-tdep.c: Sort headers.
5653         * amd64-nbsd-nat.c: Sort headers.
5654         * amd64-nat.c: Sort headers.
5655         * amd64-linux-tdep.c: Sort headers.
5656         * amd64-linux-nat.c: Sort headers.
5657         * amd64-fbsd-tdep.c: Sort headers.
5658         * amd64-fbsd-nat.c: Sort headers.
5659         * amd64-dicos-tdep.c: Sort headers.
5660         * amd64-darwin-tdep.c: Sort headers.
5661         * amd64-bsd-nat.c: Sort headers.
5662         * alpha-tdep.c: Sort headers.
5663         * alpha-obsd-tdep.c: Sort headers.
5664         * alpha-nbsd-tdep.c: Sort headers.
5665         * alpha-mdebug-tdep.c: Sort headers.
5666         * alpha-linux-tdep.c: Sort headers.
5667         * alpha-linux-nat.c: Sort headers.
5668         * alpha-bsd-tdep.c: Sort headers.
5669         * alpha-bsd-nat.c: Sort headers.
5670         * aix-thread.c: Sort headers.
5671         * agent.c: Sort headers.
5672         * addrmap.c: Sort headers.
5673         * ada-varobj.c: Sort headers.
5674         * ada-valprint.c: Sort headers.
5675         * ada-typeprint.c: Sort headers.
5676         * ada-tasks.c: Sort headers.
5677         * ada-lang.c: Sort headers.
5678         * aarch64-tdep.c: Sort headers.
5679         * aarch64-ravenscar-thread.c: Sort headers.
5680         * aarch64-newlib-tdep.c: Sort headers.
5681         * aarch64-linux-tdep.c: Sort headers.
5682         * aarch64-linux-nat.c: Sort headers.
5683         * aarch64-fbsd-tdep.c: Sort headers.
5684         * aarch64-fbsd-nat.c: Sort headers.
5685         * aarch32-linux-nat.c: Sort headers.
5686
5687 2019-04-04  Tom Tromey  <tom@tromey.com>
5688
5689         * varobj.c (varobj_create): Update.
5690         * rust-exp.y (struct rust_parser) <update_innermost_block,
5691         lookup_symbol>: New methods.
5692         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5693         Rename.
5694         (rust_parser::rust_lookup_type)
5695         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5696         * printcmd.c (display_command, do_one_display): Update.
5697         * parser-defs.h (struct parser_state) <parser_state>: Add
5698         "tracker" parameter.
5699         (block_tracker): New member.
5700         (class innermost_block_tracker) <innermost_block_tracker>: Add
5701         "types" parameter.
5702         <reset>: Remove method.
5703         (innermost_block): Don't declare.
5704         (null_post_parser): Update.
5705         * parse.c (innermost_block): Remove global.
5706         (write_dollar_variable): Update.
5707         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5708         Remove "tracker_types" parameter.
5709         (parse_expression): Add "tracker" parameter.
5710         (parse_expression_for_completion): Update.
5711         (null_post_parser): Add "tracker" parameter.
5712         * p-exp.y: Update rules.
5713         * m2-exp.y: Update rules.
5714         * language.h (struct language_defn) <la_post_parser>: Add
5715         "tracker" parameter.
5716         * go-exp.y: Update rules.
5717         * f-exp.y: Update rules.
5718         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5719         parameter.
5720         * d-exp.y: Update rules.
5721         * c-exp.y: Update rules.
5722         * breakpoint.c (set_breakpoint_condition): Create an
5723         innermost_block_tracker.
5724         (watch_command_1): Likewise.
5725         * ada-lang.c (resolve): Add "tracker" parameter.
5726         (resolve_subexp): Likewise.
5727         * ada-exp.y (write_var_from_sym): Update.
5728
5729 2019-04-04  Tom Tromey  <tom@tromey.com>
5730
5731         * type-stack.h: New file.
5732         * type-stack.c: New file.
5733         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5734         type-stack.h.
5735         (insert_into_type_stack, insert_type, push_type, push_type_int)
5736         (insert_type_address_space, pop_type, pop_type_int)
5737         (pop_typelist, pop_type_stack, append_type_stack)
5738         (push_type_stack, get_type_stack, push_typelist)
5739         (follow_type_instance_flags, follow_types): Don't declare.
5740         * parse.c (type_stack): Remove global.
5741         (parse_exp_in_context): Update.
5742         (insert_into_type_stack, insert_type, push_type, push_type_int)
5743         (insert_type_address_space, pop_type, pop_type_int)
5744         (pop_typelist, pop_type_stack, append_type_stack)
5745         (push_type_stack, get_type_stack, push_typelist)
5746         (follow_type_instance_flags, follow_types): Remove (moved to
5747         type-stack.c).
5748         * f-exp.y (type_stack): New global.
5749         Update rules.
5750         (push_kind_type, f_parse): Update.
5751         * d-exp.y (type_stack): New global.
5752         Update rules.
5753         (d_parse): Update.
5754         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5755         Update rules.
5756         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5757         (HFILES_NO_SRCDIR): Add type-stack.h.
5758
5759 2019-04-04  Tom Tromey  <tom@tromey.com>
5760
5761         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5762         (rust_parser::convert_ast_to_expression, rust_parse)
5763         (rust_lex_test_completion, rust_lex_tests): Update.
5764         * parser-defs.h (struct expr_completion_state): New.
5765         (struct parser_state) <parser_state>: Add completion parameter.
5766         <mark_struct_expression, mark_completion_tag>: New methods.
5767         <parse_completion, m_completion_state>: New members.
5768         (prefixify_expression, null_post_parser): Update.
5769         (mark_struct_expression, mark_completion_tag): Don't declare.
5770         * parse.c (parse_completion, expout_last_struct)
5771         (expout_tag_completion_type, expout_completion_name): Remove
5772         globals.
5773         (parser_state::mark_struct_expression)
5774         (parser_state::mark_completion_tag): Now methods.
5775         (prefixify_expression): Add last_struct parameter.
5776         (prefixify_subexp): Likewise.
5777         (parse_exp_1): Update.
5778         (parse_exp_in_context): Add cstate parameter.  Update.
5779         (parse_expression_for_completion): Create an
5780         expr_completion_state.
5781         (null_post_parser): Add "completion" parameter.
5782         * p-exp.y: Update rules.
5783         (yylex): Update.
5784         * language.h (struct language_defn) <la_post_parser>: Add
5785         "completing" parameter.
5786         * go-exp.y: Update rules.
5787         (lex_one_token): Update.
5788         * expression.h (parse_completion): Don't declare.
5789         * d-exp.y: Update rules.
5790         (lex_one_token): Update rules.
5791         * c-exp.y: Update rules.
5792         (lex_one_token): Update.
5793         * ada-lang.c (resolve): Add "parse_completion" parameter.
5794         (resolve_subexp): Likewise.
5795         (ada_resolve_function): Likewise.
5796
5797 2019-04-04  Tom Tromey  <tom@tromey.com>
5798
5799         * parser-defs.h (struct parser_state) <start_arglist,
5800         end_arglist>: New methods.
5801         <arglist_len, m_funcall_chain>: New members.
5802         (arglist_len, start_arglist, end_arglist): Don't declare.
5803         * parse.c (arglist_len, funcall_chain): Remove global.
5804         (start_arglist, end_arglist): Remove functions.
5805         (parse_exp_in_context): Update.
5806         * p-exp.y: Update rules.
5807         * m2-exp.y: Update rules.
5808         * go-exp.y: Update rules.
5809         * f-exp.y: Update rules.
5810         * d-exp.y: Update rules.
5811         * c-exp.y: Update rules.
5812
5813 2019-04-04  Tom Tromey  <tom@tromey.com>
5814
5815         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5816         lex_operator, push_back>: New methods.
5817         Update all rules.
5818         (rust_parser::lex_hex, lex_escape): Rename and update.
5819         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5820         (rust_parser::lex_operator): Rename and update.
5821         (rust_parser::lex_number, rustyylex, rustyyerror)
5822         (rust_lex_test_init, rust_lex_test_sequence)
5823         (rust_lex_test_push_back, rust_lex_tests): Update.
5824         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5825         parameter.
5826         <lexptr, prev_lexptr>: New members.
5827         (lexptr, prev_lexptr): Don't declare.
5828         * parse.c (lexptr, prev_lexptr): Remove globals.
5829         (parse_exp_in_context): Update.
5830         * p-exp.y (yylex, yyerror): Update.
5831         * m2-exp.y (parse_number, yylex, yyerror): Update.
5832         * go-exp.y (lex_one_token, yyerror): Update.
5833         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5834         * d-exp.y (lex_one_token, yyerror): Update.
5835         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5836         (lex_one_token, yyerror): Update.
5837         * ada-lex.l (YY_INPUT): Update.
5838         (rewind_to_char): Update.
5839         * ada-exp.y (yyerror): Update.
5840
5841 2019-04-04  Tom Tromey  <tom@tromey.com>
5842
5843         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5844         * parser-defs.h (struct parser_state) <parser_state>: Add new
5845         parameter.
5846         <comma_terminates>: New member.
5847         (comma_terminates): Don't declare global.
5848         * parse.c (comma_terminates): Remove global.
5849         (parse_exp_in_context): Update.
5850         * p-exp.y (yylex): Update.
5851         * m2-exp.y (yylex): Update.
5852         * go-exp.y (lex_one_token): Update.
5853         * f-exp.y (yylex): Update.
5854         * d-exp.y (lex_one_token): Update.
5855         * c-exp.y (lex_one_token): Update.
5856         * ada-lex.l: Update.
5857
5858 2019-04-04  Tom Tromey  <tom@tromey.com>
5859
5860         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5861         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5862         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5863         * parser-defs.h (paren_depth): Don't declare.
5864         * parse.c (paren_depth): Remove global.
5865         (parse_exp_in_context): Update.
5866         * p-exp.y (paren_depth): New global.
5867         (pascal_parse): Initialize it.
5868         * m2-exp.y (paren_depth): New global.
5869         (m2_parse): Initialize it.
5870         * go-exp.y (paren_depth): New global.
5871         (go_parse): Initialize it.
5872         * f-exp.y (paren_depth): New global.
5873         (f_parse): Initialize it.
5874         * d-exp.y (paren_depth): New global.
5875         (d_parse): Initialize it.
5876         * c-exp.y (paren_depth): New global.
5877         (c_parse): Initialize it.
5878         * ada-lex.l (paren_depth): New global.
5879         (lexer_init): Initialize it.
5880
5881 2019-04-04  Tom Tromey  <tom@tromey.com>
5882
5883         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5884         (rust_parser::convert_ast_to_type)
5885         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5886         * parser-defs.h (struct parser_state) <parser_state>: Add
5887         parameters.  Initialize new members.
5888         <expression_context_block, expression_context_pc>: New members.
5889         * parse.c (expression_context_block, expression_context_pc):
5890         Remove globals.
5891         (parse_exp_in_context): Update.
5892         * p-exp.y: Update all rules.
5893         (yylex): Update.
5894         * m2-exp.y: Update all rules.
5895         (yylex): Update.
5896         * go-exp.y (yylex): Update.
5897         * f-exp.y (yylex): Update.
5898         * d-exp.y: Update all rules.
5899         (yylex): Update.
5900         * c-exp.y: Update all rules.
5901         (lex_one_token, classify_name, yylex, c_parse): Update.
5902         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5903
5904 2019-04-04  Tom Tromey  <tom@tromey.com>
5905
5906         * gdbarch.h, gdbarch.c: Rebuild.
5907         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5908         * stap-probe.h:
5909         (struct stap_parse_info): Replace "parser_state" with
5910         "expr_builder".
5911         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5912         (parser_state): New class.
5913         * parse.c (expr_builder): Rename.
5914         (expr_builder::release): Rename.
5915         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5916         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5917         (write_exp_elt_longcst, write_exp_elt_floatcst)
5918         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5919         (write_exp_string_vector, write_exp_bitstring)
5920         (write_exp_msymbol, mark_struct_expression)
5921         (write_dollar_variable)
5922         (insert_type_address_space, increase_expout_size): Replace
5923         "parser_state" with "expr_builder".
5924         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5925         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5926         "parser_state" with "expr_builder".
5927
5928 2019-04-04  Tom Tromey  <tom@tromey.com>
5929
5930         * rust-exp.y: Replace "parse_language" with method call.
5931         * p-exp.y:
5932         (yylex): Replace "parse_language" with method call.
5933         * m2-exp.y:
5934         (yylex): Replace "parse_language" with method call.
5935         * go-exp.y (classify_name): Replace "parse_language" with method
5936         call.
5937         * f-exp.y (yylex): Replace "parse_language" with method call.
5938         * d-exp.y (lex_one_token): Replace "parse_language" with method
5939         call.
5940         * c-exp.y:
5941         (lex_one_token, classify_name, yylex): Replace "parse_language"
5942         with method call.
5943         * ada-exp.y (find_primitive_type, type_char)
5944         (type_system_address): Replace "parse_language" with method call.
5945
5946 2019-04-04  Tom Tromey  <tom@tromey.com>
5947
5948         * rust-exp.y: Replace "parse_gdbarch" with method call.
5949         * parse.c (write_dollar_variable, insert_type_address_space):
5950         Replace "parse_gdbarch" with method call.
5951         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5952         call.
5953         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5954         call.
5955         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5956         "parse_gdbarch" with method call.
5957         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5958         with method call.
5959         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5960         "parse_gdbarch" with method call.
5961         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5962         "parse_gdbarch" with method call.
5963         * c-exp.y (parse_type, parse_number, classify_name): Replace
5964         "parse_gdbarch" with method call.
5965         * ada-lex.l: Replace "parse_gdbarch" with method call.
5966         * ada-exp.y (parse_type, find_primitive_type, type_char)
5967         (type_system_address): Replace "parse_gdbarch" with method call.
5968
5969 2019-04-04  Tom Tromey  <tom@tromey.com>
5970
5971         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5972         * stap-probe.c (stap_parse_argument): Update.
5973         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5974         initial_size parameter.
5975         * rust-exp.y (rust_lex_tests): Update.
5976         * parse.c (parser_state): Update.
5977         (parse_exp_in_context): Update.
5978         * parser-defs.h (struct parser_state) <parser_state>: Remove
5979         "initial_size" parameter.
5980
5981 2019-04-04  Tom Tromey  <tom@tromey.com>
5982
5983         * parser-defs.h (increase_expout_size): Don't declare.
5984         * parse.c (increase_expout_size): Now static.
5985
5986 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
5987
5988         * gnu-nat.c (gnu_nat_target::wait): Fix
5989         target_waitstatus_to_string call.
5990
5991 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5992
5993         * eval.c (evaluate_subexp_standard): Handle internal functions
5994         during Fortran function call handling.
5995
5996 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5997
5998         * NEWS: Mention new internal functions.
5999         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6000         (read_base_type): Use dwarf2_init_complex_target_type.
6001         * value.c (creal_internal_fn): New function.
6002         (cimag_internal_fn): New function.
6003         (_initialize_values): Register new internal functions.
6004
6005 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6006
6007         * infrun.c (stop_all_threads): If debug_infrun, always
6008         trace the wait status after wait_one, using
6009         target_waitstatus_to_string and target_pid_to_str.
6010         (handle_inferior_event): Replace various trace of
6011         wait status kind by a single trace.
6012         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6013         wait status kind image by target_waitstatus_to_string.
6014         * target/waitstatus.c (target_waitstatus_to_string): Fix
6015         obsolete comment.
6016
6017 2019-04-01  Tom Tromey  <tromey@adacore.com>
6018
6019         PR symtab/23331:
6020         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6021
6022 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6023             Pedro Alves  <palves@redhat.com>
6024
6025         * top.c (quit_force): Call 'finalize_values'.
6026         * value.c (finalize_values): New function.
6027         * value.h (finalize_values): Declare.
6028
6029 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6030
6031         * NEWS: Announce $_gdb_major and $_gdb_minor.
6032
6033         * top.c (init_gdb_version_vars): New function.
6034         (gdb_init): Call init_gdb_version_vars.
6035
6036 2019-03-29  Tom Tromey  <tromey@adacore.com>
6037
6038         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6039         help text.  Remove dead code.
6040
6041 2019-03-29  Keith Seitz  <keiths@redhat.com>
6042
6043         From Siddhesh Poyarekar:
6044         * f-lang.h (f77_get_upperbound): Return LONGEST.
6045         (f77_get_lowerbound): Likewise.
6046         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6047         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6048         print them.
6049         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6050         plongest to format print it.
6051         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6052         (f77_get_upperbound): Likewise.
6053         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6054         LOWER_BOUND to LONGEST.
6055         (f77_create_arrayprint_offset_tbl): Likewise.
6056
6057 2019-03-29  Keith Seitz  <keiths@redhat.com>
6058
6059         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6060         %s/pulongest for TYPE_LENGTH instead of %d in format
6061         strings.
6062         * ada-typerint.c (ada_print_type): Likewise.
6063         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6064         * compile/compile-c-support.c (generate_register_struct): Likewise.
6065         * gdbtypes.c (recursive_dump_type): Likewise.
6066         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6067         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6068         instead of %d in format strings.
6069         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6070         to std::min to ULONGEST.
6071         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6072         instead of %d in format strings.
6073         * tracepoint.c (info_scope_command): Likewise.
6074         * typeprint.c (print_offset_data::update)
6075         (print_offset_data::finish): Likewise.
6076         * xtensa-tdep.c (xtensa_store_return_value)
6077         (xtensa_push_dummy_call): Likewise.
6078
6079 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6080
6081         * windows-nat.c (display_selector): Fixed format specifications
6082         for 64-bit Cygwin.
6083
6084 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6085
6086         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6087
6088 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6089
6090         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6091         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6092         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6093         (nios2_linux_init_abi): Install it.
6094
6095 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6096
6097         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6098
6099 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6100
6101         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6102
6103 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6104             Tom Tromey  <tromey@adacore.com>
6105
6106         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6107
6108 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6109
6110         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6111         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6112         method to compute the bounds of range types. Also print "[evaluated]"
6113         if the bounds' values come from a dynamic evaluation.
6114
6115 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6116
6117         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6118         whitespace when pretty printing is on.
6119
6120 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6121
6122         * ppc-linux-nat.c: Add include.
6123
6124 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6125
6126         * NEWS: Mention AArch64 Pointer Authentication.
6127
6128 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6129
6130         * arm-linux-nat.c: Add include.
6131
6132 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6133
6134         * source-cache.c (source_cache::get_source_lines): Re-read
6135         fullname after calling open_source_file.
6136
6137 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6138
6139         * NEWS: Mention TLS support for FreeBSD.
6140
6141 2019-03-25  Tom Tromey  <tromey@adacore.com>
6142
6143         * minsyms.c (BUNCH_SIZE): Update comment.
6144         (~minimal_symbol_reader): Remove old comment.
6145         (compact_minimal_symbols): Update comment.
6146         (minimal_symbol_reader::install): Remove old comment.  Update
6147         other comments.
6148
6149 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6150
6151         * s390-linux-nat.c: Add include.
6152
6153 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6154
6155         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6156         Call linux_get_hwcap.
6157         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6158         Likewise.
6159         (aarch64_linux_get_hwcap): Remove function.
6160         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6161         declaration.
6162         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6163         linux_get_hwcap.
6164         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6165         * linux-tdep.c (linux_get_hwcap): Add function.
6166         (linux_get_hwcap2): Likewise.
6167         * linux-tdep.h (linux_get_hwcap): Add declaration.
6168         (linux_get_hwcap2): Likewise.
6169         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6170         (ppc_linux_get_hwcap2): Likewise.
6171         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6172         linux_get_hwcap.
6173         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6174         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6175         (ppc_linux_nat_target::read_description): Likewise.
6176         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6177         * s390-linux-nat.c: Likewise.
6178         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6179
6180 2019-03-24  Tom Tromey  <tom@tromey.com>
6181
6182         * ada-lang.c (standard_lookup): Simplify initialization.
6183         (ada_lookup_symbol_nonlocal): Simplify return.
6184         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6185         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6186         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6187         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6188         initialization.
6189         * solib.c (solib_global_lookup): Simplify.
6190         * symtab.c (null_block_symbol): Remove.
6191         (symbol_cache_lookup): Simplify returns.
6192         (lookup_language_this): Simplify returns.
6193         (lookup_symbol_aux): Simplify return.
6194         (lookup_local_symbol): Simplify returns.
6195         (lookup_global_symbol_from_objfile): Simplify return.
6196         (lookup_symbol_in_objfile_symtabs)
6197         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6198         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6199         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6200         * cp-namespace.c (cp_lookup_bare_symbol)
6201         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6202         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6203         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6204         (cp_lookup_symbol_via_imports): Simplify initialization.
6205         (find_symbol_in_baseclass): Likewise.
6206         * symtab.h (null_block_symbol): Remove.
6207         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6208         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6209         (d_lookup_symbol_module): Likewise.
6210         (find_symbol_in_baseclass): Simplify initialization.
6211
6212 2019-03-24  Tom Tromey  <tom@tromey.com>
6213
6214         * expression.h: Don't include symtab.h.
6215         (struct block): Forward declare.
6216
6217 2019-03-24  Tom Tromey  <tom@tromey.com>
6218
6219         * c-exp.y (typebase): Remove casts.
6220         * gdbtypes.c (lookup_unsigned_typename, )
6221         (lookup_signed_typename): Remove cast.
6222         * eval.c (parse_to_comma_and_eval): Remove cast.
6223         * parse.c (write_dollar_variable): Remove cast.
6224         * block.h (struct block) <superblock>: Now const.
6225         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6226         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6227         (map_block): Make "block" const.
6228         * symfile.h (struct quick_symbol_functions)
6229         <map_matching_symbols>: Constify block argument to "callback".
6230         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6231         const.
6232         (find_pc_sect_compunit_symtab): Make "b" const.
6233         (find_symbol_at_address): Likewise.
6234         (search_symbols): Likewise.
6235         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6236         (dw2_debug_names_lookup_symbol): Likewise.
6237         (dw2_map_matching_symbols): Update.
6238         * p-valprint.c (pascal_val_print): Remove "block".
6239         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6240         (aux_add_nonlocal_symbols): Make "block" const.
6241         (resolve_subexp): Remove cast.
6242         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6243         const.
6244         (iterate_over_file_blocks): Likewise.
6245         * f-exp.y (%union) <bval>: Remove.
6246         * coffread.c (patch_opaque_types): Make "b" const.
6247         * spu-tdep.c (spu_catch_start): Make "block" const.
6248         * c-valprint.c (print_unpacked_pointer): Remove "block".
6249         * symmisc.c (dump_symtab_1): Make "b" const.
6250         (block_depth): Make "block" const.
6251         * d-exp.y (%union) <bval>: Remove.
6252         * cp-support.h (cp_lookup_rtti_type): Update.
6253         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6254         * psymtab.c (psym_lookup_symbol): Make "block" const.
6255         (maintenance_check_psymtabs): Make "b" const.
6256         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6257         (enumerate_locals, enumerate_args): Update.
6258         * python/py-symtab.c (stpy_global_block): Make "block" const.
6259         (stpy_static_block): Likewise.
6260         * inline-frame.c (block_starting_point_at): Make "new_block"
6261         const.
6262         * block.c (find_block_in_blockvector): Make return type const.
6263         (blockvector_for_pc_sect): Make "b" const.
6264         (find_block_in_blockvector): Make "b" const.
6265
6266 2019-03-23  Tom Tromey  <tom@tromey.com>
6267
6268         * varobj.c (varobj_create): Update.
6269         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6270         * printcmd.c (display_command, do_one_display): Don't reset
6271         innermost_block.
6272         * parser-defs.h (enum innermost_block_tracker_type): Move to
6273         expression.h.
6274         (innermost_block): Update comment.
6275         * parse.c (parse_exp_1): Add tracker_types parameter.
6276         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6277         tracker_types parameter.  Reset innermost_block.
6278         (parse_exp_in_context): Remove.
6279         (parse_expression_for_completion): Update.
6280         * objfiles.c (~objfile): Don't reset expression_context_block or
6281         innermost_block.
6282         * expression.h (enum innermost_block_tracker_type): Move from
6283         parser-defs.h.
6284         (parse_exp_1): Add tracker_types parameter.
6285         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6286         reset innermost_block.
6287
6288 2019-03-23  Tom Tromey  <tom@tromey.com>
6289
6290         * objfiles.h: Include bcache.h.
6291
6292 2019-03-23  Tom Tromey  <tom@tromey.com>
6293
6294         * linespec.c (get_current_search_block): Use
6295         scoped_restore_current_language.
6296         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6297
6298 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6299             Jiong Wang  <jiong.wang@arm.com>
6300
6301         * aarch64-linux-tdep.c
6302         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6303         section.
6304         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6305
6306 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6307             Jiong Wang  <jiong.wang@arm.com>
6308
6309         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6310         instructions.
6311         (aarch64_analyze_prologue_test): Add PACIASP test.
6312         (aarch64_prologue_prev_register): Unmask PC value.
6313
6314 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6315             Jiong Wang  <jiong.wang@arm.com>
6316
6317         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6318         (aarch64_dwarf2_prev_register): Unmask PC value.
6319         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6320         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6321         DW_CFA_AARCH64_negate_ra_state.
6322         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6323
6324 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6325             Jiong Wang  <jiong.wang@arm.com>
6326
6327         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6328         registers.
6329         (aarch64_pseudo_register_name): Likewise.
6330         (aarch64_pseudo_register_type): Likewise.
6331         (aarch64_pseudo_register_reggroup_p): Likewise.
6332         (aarch64_gdbarch_init): Add pauth registers.
6333         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6334         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6335         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6336         (struct gdbarch_tdep): Add regnum for ra_state.
6337
6338 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6339             Jiong Wang  <jiong.wang@arm.com>
6340
6341         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6342
6343 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6344             Jiong Wang  <jiong.wang@arm.com>
6345
6346         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6347         function.
6348         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6349         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6350         (aarch64_gdbarch_init): Add puth registers.
6351         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6352         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6353         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6354
6355 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6356             Jiong Wang  <jiong.wang@arm.com>
6357
6358         * aarch64-linux-nat.c
6359         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6360         * aarch64-linux-tdep.c
6361         (aarch64_linux_core_read_description): Likewise.
6362         (aarch64_linux_get_hwcap): New function.
6363         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6364         (aarch64_linux_get_hwcap): New declaration.
6365
6366 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6367             Jiong Wang  <jiong.wang@arm.com>
6368
6369         * aarch64-linux-nat.c
6370         (aarch64_linux_nat_target::read_description): Add pauth param.
6371         * aarch64-linux-tdep.c
6372         (aarch64_linux_core_read_description): Likewise.
6373         * aarch64-tdep.c (struct target_desc): Add in pauth.
6374         (aarch64_read_description): Add pauth param.
6375         (aarch64_gdbarch_init): Likewise.
6376         * aarch64-tdep.h (aarch64_read_description): Likewise.
6377         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6378         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6379         * features/Makefile: Add new files.
6380         * features/aarch64-pauth.c: New file.
6381         * features/aarch64-pauth.xml: New file.
6382
6383 2019-03-20  Tom Tromey  <tromey@adacore.com>
6384
6385         * infrun.c (handle_inferior_event): Rename from
6386         handle_inferior_event_1.  Create a scoped_value_mark.
6387         (handle_inferior_event): Remove.
6388
6389 2019-03-19  Tom Tromey  <tromey@adacore.com>
6390
6391         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6392         * infrun.h (print_stop_event): Add "displays" parameter.
6393         * infrun.c (print_stop_event): Add "displays" parameter.
6394
6395 2019-03-19  Pedro Alves  <palves@redhat.com>
6396
6397         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6398         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6399         to -1.  Fix TABs vs spaces.
6400         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6401         * tui/tui-out.h (tui_ui_out) Add intro comments.
6402         <m_line, m_start_of_line>: In-class initialize, and add describing
6403         comment.
6404
6405 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6406
6407         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6408         variable names.
6409         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6410
6411 2019-03-18  Pedro Alves  <palves@redhat.com>
6412             Eli Zaretskii <eliz@gnu.org>
6413
6414         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6415         m_line and m_start_of_line.
6416
6417 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6418
6419         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6420         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6421         it returns a newline.  This fixes a regression in TU mode, whereby
6422         the next line is output on the same screen line as the user input.
6423
6424 2019-03-18  Tom Tromey  <tromey@adacore.com>
6425
6426         * minsyms.c (minimal_symbol_reader::install): Remove call to
6427         obstack_blank.
6428
6429 2019-03-18  Pedro Alves  <palves@redhat.com>
6430
6431         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6432         New globals.
6433         (apply_style): New, factored out from ...
6434         (apply_ansi_escape): ... this.  Handle reverse video mode.
6435         (tui_set_reverse_mode): New function.
6436         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6437         * tui/tui-winsource.c (tui_show_source_line): Use
6438         tui_set_reverse_mode instead of setting A_STANDOUT.
6439         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6440         New setter methods.
6441
6442 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6443
6444         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6445         Handle tabs.
6446
6447 2019-03-18  Tom Tromey  <tromey@adacore.com>
6448
6449         * ada-lang.c (empty_array): Add "high" parameter.
6450         (ada_evaluate_subexp): Update.
6451
6452 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6453
6454         * unittests/string_view-selftests.c: Define
6455         _initialize_string_view_selftests unconditionally.
6456
6457 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6458
6459         PR gdb/24350
6460         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6461
6462 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6463
6464         PR gdb/24351
6465         * windows-nat.c (display_selector): Fix format specifiers.
6466
6467 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6468
6469         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6470         tui_refill_source_window instead of tui_refresh_win, to update the
6471         current execution line.  This fixes redisplay of the current line
6472         when stepping through the code with "next" or "step".
6473
6474 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6475
6476         * source-cache.c (source_cache::get_source_lines): Call
6477         find_source_lines to initialize s->nlines.  This fixes vertical
6478         scrolling of TUI source window when the DOWN arrow is pressed.
6479
6480 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6481
6482         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6483         linux-thread-db.c (_initialize_thread_db): Likewise.
6484
6485 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6486
6487         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6488         wclrtoeol in tui_show_source_line".  This reverts changes made in
6489         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6490
6491 2019-03-15  Tom Tromey  <tom@tromey.com>
6492
6493         * symtab.h (struct minimal_symbol): Derive from
6494         general_symbol_info.
6495         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6496         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6497         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6498         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6499         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6500         (MSYMBOL_SEARCH_NAME): Update.
6501         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6502         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6503         * minsyms.c (minimal_symbol_reader::record_full): Update.
6504
6505 2019-03-15  Tom Tromey  <tom@tromey.com>
6506
6507         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6508
6509 2019-03-15  Tom Tromey  <tom@tromey.com>
6510
6511         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6512         unique_xmalloc_ptr.
6513         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6514         Update.
6515         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6516         (build_minimal_symbol_hash_tables)
6517         (minimal_symbol_reader::install): Update.
6518
6519 2019-03-15  Tom Tromey  <tom@tromey.com>
6520
6521         * symtab.c (create_demangled_names_hash): Update.
6522         (symbol_set_names): Update.
6523         * objfiles.h (struct objfile_per_bfd_storage)
6524         <demangled_names_hash>: Now an htab_up.
6525         * objfiles.c (objfile_per_bfd_storage): Simplify.
6526
6527 2019-03-15  Tom Tromey  <tom@tromey.com>
6528
6529         * objfiles.h (struct objfile_per_bfd_storage): Declare
6530         destructor.
6531         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6532         New.
6533         (get_objfile_bfd_data): Use new.  Don't initialize
6534         language_of_main.
6535         (free_objfile_per_bfd_storage): Remove.
6536         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6537
6538 2019-03-15  Tom Tromey  <tom@tromey.com>
6539
6540         * symfile.c (reread_symbols): Update.
6541         * objfiles.c (objfile::objfile): Update.
6542         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6543         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6544         comment.
6545         (minimal_symbol_reader::install): Update.
6546         (terminate_minimal_symbol_table): Remove.
6547         * jit.c (jit_object_close_impl): Update.
6548
6549 2019-03-15  Tom Tromey  <tom@tromey.com>
6550
6551         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6552         initializations.
6553
6554 2019-03-15  Tom Tromey  <tom@tromey.com>
6555
6556         * objfiles.h (struct objfile_per_bfd_storage)
6557         <demangled_hash_languages>: Now a bitset.
6558         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6559         (lookup_minimal_symbol): Update.
6560
6561 2019-03-15  Tom Tromey  <tom@tromey.com>
6562
6563         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6564         Don't return the symbol.
6565         * coffread.c (record_minimal_symbol): Use record_full.
6566
6567 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6568
6569         The MS-Windows port of ncurses fails to switch to a color pair if
6570         one or both of the colors are the implicit default colors.  This
6571         change records the default colors when TUI is initialized, and
6572         then specifies them explicitly when a color pair uses the default
6573         colors.  This allows color styling in TUI mode on MS-Windows.
6574
6575         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6576         ncurses_norm_attr.
6577         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6578         colors in ncurses_norm_attr.
6579         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6580         "none", replace it with the default color recorded in
6581         ncurses_norm_attr.
6582
6583 2019-03-14  Tom Tromey  <tromey@adacore.com>
6584
6585         * source-cache.h (class source_cache) <get_source_lines>: Return
6586         std::string.
6587         * source-cache.c (source_cache::extract_lines): Handle case where
6588         first_pos==npos.  Return std::string.
6589         (source_cache::get_source_lines): Update.
6590
6591 2019-03-14  Tom Tromey  <tromey@adacore.com>
6592
6593         * NEWS: Add item for "style sources" commands.
6594         * source-cache.c (source_cache::get_source_lines): Check
6595         source_styling.
6596         * cli/cli-style.c (source_styling): New global.
6597         (_initialize_cli_style): Add "style sources" commands.
6598         (show_style_sources): New function.
6599         * cli/cli-style.h (source_styling): Declare.
6600
6601 2019-03-14  Pedro Alves  <palves@redhat.com>
6602             Tom Tromey  <tromey@adacore.com>
6603
6604         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6605         * tui/tui-winsource.c (tui_refill_source_window): New function,
6606         from...
6607         (tui_horizontal_source_scroll): ... here.  Move some logic.
6608         * cli/cli-style.c (set_style_enabled): Notify new observable.
6609         * tui/tui-hooks.c (tui_redisplay_source): New function.
6610         (tui_attach_detach_observers): Attach or detach
6611         tui_redisplay_source.
6612         * observable.h (source_styling_changed): New observable.
6613         * observable.c: Define source_styling_changed observable.
6614
6615 2019-03-13  Tom Tromey  <tromey@adacore.com>
6616
6617         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6618         (i386_gnu_nat_target::store_registers): Update.
6619         * target-debug.h (target_debug_print_std_string): New macro.
6620         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6621         * windows-tdep.c (display_one_tib): Update.
6622         * tui/tui-stack.c (tui_make_status_line): Update.
6623         * top.c (print_inferior_quit_action): Update.
6624         * thread.c (thr_try_catch_cmd): Update.
6625         (add_thread_with_info): Update.
6626         (thread_target_id_str): Update.
6627         (thr_try_catch_cmd): Update.
6628         (thread_command): Update.
6629         (thread_find_command): Update.
6630         * record-btrace.c (record_btrace_target::info_record)
6631         (record_btrace_resume_thread, record_btrace_target::resume)
6632         (record_btrace_cancel_resume, record_btrace_step_thread)
6633         (record_btrace_target::wait, record_btrace_target::wait)
6634         (record_btrace_target::wait, record_btrace_target::stop): Update.
6635         * progspace.c (print_program_space): Update.
6636         * process-stratum-target.c
6637         (process_stratum_target::thread_address_space): Update.
6638         * linux-fork.c (linux_fork_mourn_inferior)
6639         (detach_checkpoint_command, info_checkpoints_command)
6640         (linux_fork_context): Update.
6641         (linux_fork_detach): Update.
6642         (class scoped_switch_fork_info): Update.
6643         (delete_checkpoint_command): Update.
6644         * infrun.c (follow_fork_inferior): Update.
6645         (follow_fork_inferior): Update.
6646         (proceed_after_vfork_done): Update.
6647         (handle_vfork_child_exec_or_exit): Update.
6648         (follow_exec): Update.
6649         (displaced_step_prepare_throw): Update.
6650         (displaced_step_restore): Update.
6651         (start_step_over): Update.
6652         (resume_1): Update.
6653         (clear_proceed_status_thread): Update.
6654         (proceed): Update.
6655         (print_target_wait_results): Update.
6656         (do_target_wait): Update.
6657         (context_switch): Update.
6658         (stop_all_threads): Update.
6659         (restart_threads): Update.
6660         (finish_step_over): Update.
6661         (handle_signal_stop): Update.
6662         (switch_back_to_stepped_thread): Update.
6663         (keep_going_pass_signal): Update.
6664         (print_exited_reason): Update.
6665         (normal_stop): Update.
6666         * inferior.c (inferior_pid_to_str): Change return type.
6667         (print_selected_inferior): Update.
6668         (add_inferior): Update.
6669         (detach_inferior): Update.
6670         * dummy-frame.c (fprint_dummy_frames): Update.
6671         * dcache.c (dcache_info_1): Update.
6672         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6673         (btrace_fetch, btrace_clear): Update.
6674         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6675         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6676         type.
6677         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6678         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6679         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6680         * gdbarch.c, gdbarch.h: Rebuild.
6681         * gdbarch.sh (core_pid_to_str): Change return type.
6682         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6683         return type.
6684         (windows_nat_target::pid_to_str): Change return type.
6685         (windows_delete_thread): Update.
6686         (windows_nat_target::attach): Update.
6687         (windows_nat_target::files_info): Update.
6688         * target-delegates.c: Rebuild.
6689         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6690         return type.
6691         (sol_thread_target::pid_to_str): Change return type.
6692         * remote.c (class remote_target) <pid_to_str>: Change return
6693         type.
6694         (remote_target::pid_to_str): Change return type.
6695         (extended_remote_target::attach, remote_target::remote_stop_ns)
6696         (remote_target::remote_notif_remove_queued_reply)
6697         (remote_target::push_stop_reply, remote_target::disable_btrace):
6698         Update.
6699         (extended_remote_target::attach): Update.
6700         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6701         type.
6702         (gdbsim_target::pid_to_str): Change return type.
6703         * ravenscar-thread.c (struct ravenscar_thread_target)
6704         <pid_to_str>: Change return type.
6705         (ravenscar_thread_target::pid_to_str): Change return type.
6706         * procfs.c (class procfs_target) <pid_to_str>: Change return
6707         type.
6708         (procfs_target::pid_to_str): Change return type.
6709         (procfs_target::attach): Update.
6710         (procfs_target::detach): Update.
6711         (procfs_target::fetch_registers): Update.
6712         (procfs_target::store_registers): Update.
6713         (procfs_target::wait): Update.
6714         (procfs_target::files_info): Update.
6715         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6716         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6717         return type.
6718         (nto_procfs_target::pid_to_str): Change return type.
6719         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6720         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6721         return type.
6722         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6723         (exit_lwp): Update.
6724         (attach_proc_task_lwp_callback, get_detach_signal)
6725         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6726         (linux_nat_target::resume, wait_lwp, stop_callback)
6727         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6728         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6729         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6730         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6731         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6732         type.
6733         (inf_ptrace_target::attach): Update.
6734         (inf_ptrace_target::files_info): Update.
6735         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6736         type.
6737         (go32_nat_target::pid_to_str): Change return type.
6738         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6739         (gnu_nat_target::wait): Update.
6740         (gnu_nat_target::wait): Update.
6741         (gnu_nat_target::resume): Update.
6742         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6743         (fbsd_nat_target::wait): Update.
6744         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6745         type.
6746         (darwin_nat_target::attach): Update.
6747         * corelow.c (class core_target) <pid_to_str>: Change return type.
6748         (core_target::pid_to_str): Change return type.
6749         * target.c (normal_pid_to_str): Change return type.
6750         (default_pid_to_str): Likewise.
6751         (target_pid_to_str): Change return type.
6752         (target_translate_tls_address): Update.
6753         (target_announce_detach): Update.
6754         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6755         return type.
6756         (bsd_uthread_target::pid_to_str): Change return type.
6757         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6758         type.
6759         (bsd_kvm_target::pid_to_str): Change return type.
6760         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6761         return type.
6762         (aix_thread_target::pid_to_str): Change return type.
6763         * target.h (struct target_ops) <pid_to_str>: Change return type.
6764         (target_pid_to_str, normal_pid_to_str): Likewise.
6765         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6766         type.
6767         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6768         type.
6769         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6770         return type.
6771         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6772         type.
6773         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6774         type.
6775         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6776         return type.
6777
6778 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6779
6780         * NEWS: Mention that the new default MI version is 3.  Mention
6781         changes to the output of commands and events that deal with
6782         multi-location breakpoints.
6783         * breakpoint.c: Include "mi/mi-out.h".
6784         (print_one_breakpoint): Change output syntax if using MI version
6785         >= 3.
6786         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6787         New.
6788         (mi_multi_location_breakpoint_output_fixed): New.
6789         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6790         (mi_cmd_fix_multi_location_breakpoint_output): New.
6791         (mi_multi_location_breakpoint_output_fixed): New.
6792         * mi/mi-cmds.c (mi_cmds): Register command
6793         -fix-multi-location-breakpoint-output.
6794         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6795         interpreter "mi".
6796
6797 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6798
6799         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6800         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6801         instantiate mi_ui_out based on interpreter name.
6802         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6803         * mi/mi-main.c (mi_load_progress): Likewise.
6804
6805 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6806
6807         * NEWS: Combine separate "New targets" sections for 8.3.
6808
6809 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6810
6811         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6812         (ppcfbsd_init_abi): Install gdbarch
6813         "fetch_tls_load_module_address" and "get_thread_local_address"
6814         methods.
6815
6816 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6817
6818         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6819         (riscv_fbsd_init_abi): Install gdbarch
6820         "fetch_tls_load_module_address" and "get_thread_local_address"
6821         methods.
6822
6823 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6824
6825         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6826         (i386fbsd_init_abi): Install gdbarch
6827         "fetch_tls_load_module_address" and "get_thread_local_address"
6828         methods.
6829
6830 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6831
6832         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6833         (amd64fbsd_init_abi): Install gdbarch
6834         "fetch_tls_load_module_address" and "get_thread_local_address"
6835         methods.
6836
6837 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6838
6839         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6840         (struct fbsd_pspace_data): New type.
6841         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6842         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6843         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6844         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6845         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6846
6847 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6848
6849         * gdbtypes.c (lookup_struct_elt): New function.
6850         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6851         * gdbtypes.h (struct struct_elt): New type.
6852         (lookup_struct_elt): New prototype.
6853
6854 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6855
6856         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6857         remove disabled code block.
6858
6859 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6860
6861         * gdbarch.sh (get_thread_local_address): New method.
6862         * gdbarch.h, gdbarch.c: Regenerate.
6863         * target.c (target_translate_tls_address): Use
6864         gdbarch_get_thread_local_address if present instead of
6865         target::get_thread_local_address.
6866
6867 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6868
6869         * target.h (target::get_thread_local_address): Update comment.
6870
6871 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6872
6873         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6874         objfile->separate_debug_objfile_backlink if not NULL.
6875
6876 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6877
6878         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6879         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6880         (amd64bsd_store_inferior_registers): Likewise.
6881         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6882         Enable segment base registers.
6883         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6884         PT_GETFSBASE and PT_GETGSBASE.
6885         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6886         PT_SETGSBASE.
6887         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6888         segment base registers.
6889         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6890
6891 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6892
6893         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6894         Update calls to i386_target_description to add 'segments'
6895         parameter.
6896         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6897         add segment base registers.
6898         * arch/i386.c (i386_create_target_description): Add 'segments'
6899         parameter to enable segment base registers.
6900         * arch/i386.h (i386_create_target_description): Likewise.
6901         * features/i386/32bit-segments.xml: New file.
6902         * features/i386/32bit-segments.c: Generate.
6903         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6904         call to i386_target_description to add 'segments' parameter.
6905         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6906         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6907         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6908         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6909         if feature is present.
6910         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6911         Add 'segments' parameter to call to i386_target_description.
6912         (i386_target_description): Add 'segments' parameter to enable
6913         segment base registers.
6914         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6915         to call to i386_target_description.
6916         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6917         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6918         Define I386_NUM_REGS.
6919         (i386_target_description): Add 'segments' parameter to enable
6920         segment base registers.
6921
6922 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6923
6924         PR/24325
6925         * source-cache.c: #undef open and close, to avoid unresolved
6926         externals during linking.
6927
6928 2019-03-12  Tom Tromey  <tromey@adacore.com>
6929
6930         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6931         const.  Add initializers.
6932         (_initialize_remote): Don't initialize ptid globals.
6933
6934 2019-03-12  Pedro Alves  <palves@redhat.com>
6935
6936         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6937
6938 2019-03-12  Pedro Alves  <palves@redhat.com>
6939
6940         * cp-name-parser.y (main): Remove unused 'len' variable.
6941
6942 2019-03-12  Tom Tromey  <tromey@adacore.com>
6943
6944         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6945         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6946
6947 2019-03-12  Tom Tromey  <tromey@adacore.com>
6948
6949         * linux-nat.c (iterate_over_lwps): Update.
6950         (stop_callback): Remove parameter.
6951         (stop_wait_callback, detach_callback, resume_set_callback)
6952         (select_singlestep_lwp_callback, set_ignore_sigint)
6953         (status_callback, resumed_callback, resume_clear_callback)
6954         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6955         data parameter.
6956         (linux_nat_target::detach, linux_nat_target::resume)
6957         (linux_stop_and_wait_all_lwps, select_event_lwp)
6958         (linux_nat_filter_event, linux_nat_wait_1)
6959         (linux_nat_target::kill, linux_nat_target::stop)
6960         (linux_nat_target::stop): Update.
6961         (linux_nat_resume_callback): Change type.
6962         (resume_stopped_resumed_lwps, count_events_callback)
6963         (select_event_lwp_callback): Likewise.
6964         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6965         * arm-linux-nat.c (struct update_registers_data): Remove.
6966         (update_registers_callback): Change type.
6967         (arm_linux_insert_hw_breakpoint1): Update.
6968         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6969         parameter.
6970         (x86_linux_dr_set_addr): Update.
6971         (x86_linux_dr_set_control): Update.
6972         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6973         (iterate_over_lwps): Use gdb::function_view.
6974         * nat/aarch64-linux-hw-point.c (struct
6975         aarch64_dr_update_callback_param): Remove.
6976         (debug_reg_change_callback): Change type.
6977         (aarch64_notify_debug_reg_change): Update.
6978         * s390-linux-nat.c (s390_refresh_per_info): Update.
6979
6980 2019-03-11  Tom Tromey  <tromey@adacore.com>
6981
6982         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6983         redundant assignment to "this_cu".
6984
6985 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6986
6987         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6988
6989 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6990
6991         * gdbtypes.c (rank_one_type_parm_set): New function extracted
6992         from...
6993         (rank_one_type): ... this.
6994
6995 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6996
6997         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6998         from...
6999         (rank_one_type): ... this.
7000
7001 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7002
7003         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7004         from...
7005         (rank_one_type): ... this.
7006
7007 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7008
7009         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7010         from...
7011         (rank_one_type): ... this.
7012
7013 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7014
7015         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7016         from...
7017         (rank_one_type): ... this.
7018
7019 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7020
7021         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7022         from...
7023         (rank_one_type): ... this.
7024
7025 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7026
7027         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7028         from...
7029         (rank_one_type): ... this.
7030
7031 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7032
7033         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7034         from...
7035         (rank_one_type): ... this.
7036
7037 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7038
7039         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7040         from...
7041         (rank_one_type): ... this.
7042
7043 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7044
7045         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7046         from...
7047         (rank_one_type): ... this.
7048
7049 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7050
7051         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7052         from...
7053         (rank_one_type): ... this.
7054
7055 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7056
7057         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7058         from...
7059         (rank_one_type): ... this.
7060
7061 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7062
7063         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7064         inferior-events' shows the example events.
7065
7066 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7067
7068         Support styling on native MS-Windows console
7069
7070         PR/24315
7071         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7072         on MS-Windows if $TERM is not defined.
7073
7074         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7075
7076         * posix-hdep.c (gdb_console_fputs):
7077         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7078         functions.
7079         * ui-file.h (gdb_console_fputs): Add prototype.
7080
7081         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7082         back to fputs only if the former returns zero.
7083
7084 2019-03-07  Tom Tromey  <tom@tromey.com>
7085
7086         * symmisc.c (print_symbol_bcache_statistics): Update.
7087         (print_objfile_statistics): Update.
7088         * symfile.c (allocate_symtab): Update.
7089         * stabsread.c: Don't include bcache.h.
7090         * psymtab.h (struct psymbol_bcache): Don't declare.
7091         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7092         (psymbol_bcache_init, psymbol_bcache_free)
7093         (psymbol_bcache_get_bcache): Don't declare.
7094         * psymtab.c (struct psymbol_bcache): Remove.
7095         (psymtab_storage::psymtab_storage): Update.
7096         (psymtab_storage::~psymtab_storage): Update.
7097         (psymbol_bcache_init, psymbol_bcache_free)
7098         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7099         (add_psymbol_to_bcache): Update.
7100         (allocate_psymtab): Update.
7101         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7102         macro_cache>: No longer pointers.
7103         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7104         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7105         * macrotab.c (macro_bcache): Update.
7106         * macroexp.c: Don't include bcache.h.
7107         * gdbtypes.c (check_types_worklist): Update.
7108         (types_deeply_equal): Remove TRY/CATCH.  Update.
7109         * elfread.c (elf_symtab_read): Update.
7110         * dwarf2read.c: Don't include bcache.h.
7111         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7112         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7113         (print_bcache_statistics, bcache_memory_used): Don't declare.
7114         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7115         methods.  Rename all data members.
7116         * bcache.c (struct bcache): Move to bcache.h.
7117         (bcache::expand_hash_table): Rename from expand_hash_table.
7118         (bcache): Remove.
7119         (bcache::insert): Rename from bcache_full.
7120         (bcache::compare): Rename from bcache_compare.
7121         (bcache_xmalloc): Remove.
7122         (bcache::~bcache): Rename from bcache_xfree.
7123         (bcache::print_statistics): Rename from print_bcache_statistics.
7124         (bcache::memory_used): Rename from bcache_memory_used.
7125
7126 2019-03-07  Pedro Alves  <palves@redhat.com>
7127
7128         * infrun.c (normal_stop): Also check for
7129         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7130
7131 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7132
7133         * f-lang.c (value_from_host_double): Moved to...
7134         * value.c (value_from_host_double): ...here.
7135         * value.h (value_from_host_double): Declare.
7136         * guile/scm-math.c (vlscm_convert_typed_number): Use
7137         value_from_host_double.
7138         (vlscm_convert_number): Likewise.
7139         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7140         * python/py-value.c (convert_value_from_python): Likewise.
7141
7142 2019-03-06  Tom Tromey  <tom@tromey.com>
7143
7144         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7145
7146 2019-03-06  Tom Tromey  <tom@tromey.com>
7147
7148         * utils.h (free_current_contents): Don't declare.
7149         * utils.c (free_current_contents): Remove.
7150
7151 2019-03-06  Tom Tromey  <tom@tromey.com>
7152
7153         * top.c (quit_force): Update.
7154         * main.c (captured_command_loop): Update.
7155         * common/new-op.c (operator new): Update.
7156         * common/common-exceptions.c (struct catcher)
7157         <save_cleanup_chain>: Remove member.
7158         (exceptions_state_mc_init): Update.
7159         (exception_try_scope_entry): Return nullptr.
7160         (exception_try_scope_exit, exception_rethrow)
7161         (throw_exception_sjlj, throw_exception_cxx): Update.
7162         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7163         (all_cleanups, do_cleanups, discard_cleanups)
7164         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7165         (restore_cleanups, restore_final_cleanups): Don't declare.
7166         (do_final_cleanups): Remove parameter.
7167         * common/cleanups.c (cleanup_chain, make_cleanup)
7168         (make_cleanup_dtor, all_cleanups, do_cleanups)
7169         (discard_my_cleanups, discard_cleanups)
7170         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7171         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7172         (null_cleanup): Remove.
7173         (do_final_cleanups): Remove parameter.
7174
7175 2019-03-06  Tom Tromey  <tom@tromey.com>
7176
7177         * remote.c (remote_target::remote_parse_stop_reply): Use
7178         unique_xmalloc_ptr.
7179
7180 2019-03-06  Tom Tromey  <tom@tromey.com>
7181
7182         * stabsread.c (struct stabs_field_info): Rename from field_info.
7183         <list, fnlist>: Add initializers.
7184         <obstack>: New member.
7185         (read_member_functions, read_struct_fields, read_baseclasses):
7186         Allocate on obstack.  Don't use cleanups.
7187         (read_one_struct_field, read_member_functions, read_struct_fields)
7188         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7189         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7190         (read_struct_type): Update.
7191
7192 2019-03-06  Tom Tromey  <tom@tromey.com>
7193
7194         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7195         * common/filestuff.h (make_cleanup_close): Don't declare.
7196         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7197         Remove.
7198
7199 2019-03-06  Tom Tromey  <tom@tromey.com>
7200
7201         * solib-aix.c: Use make_scope_exit.
7202
7203 2019-03-06  Tom Tromey  <tom@tromey.com>
7204
7205         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7206         Use make_scope_exit.
7207
7208 2019-03-06  Tom Tromey  <tom@tromey.com>
7209
7210         * solib-svr4.c (disable_probes_interface): Remove parameter.
7211         (svr4_handle_solib_event): Use make_scope_exit.
7212
7213 2019-03-06  Tom Tromey  <tom@tromey.com>
7214
7215         * remote.c (struct stop_reply_deleter): Remove.
7216         (stop_reply_up): Update.
7217         (struct stop_reply): Derive from notif_event.  Don't typedef.
7218         <regcache>: Now a std::vector.
7219         (stop_reply_xfree): Remove.
7220         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7221         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7222         (remote_target::discard_pending_stop_replies): Use delete.
7223         (remote_target::remote_parse_stop_reply): Update.
7224         (remote_target::process_stop_reply): Update.
7225         * remote-notif.h (struct notif_event): Add virtual destructor.
7226         Remove "dtr" member.
7227         (struct notif_client) <alloc_event>: Return a unique_ptr.
7228         (notif_event_xfree): Don't declare.
7229         (notif_event_up): New typedef.
7230         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7231         (notif_event_xfree, do_notif_event_xfree): Remove.
7232         (remote_notif_state_xfree): Update.
7233
7234 2019-03-06  Tom Tromey  <tom@tromey.com>
7235
7236         * infrun.c (displaced_step_clear_cleanup): Now a
7237         forward_scope_exit type.
7238         (displaced_step_prepare_throw): Update.
7239         (displaced_step_fixup): Update.
7240
7241 2019-03-06  Tom Tromey  <tom@tromey.com>
7242
7243         * inferior.h (class inferior): Update comment.
7244         * gdbthread.h (class thread_info): Update comment.
7245
7246 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7247             Tom Tromey  <tom@tromey.com>
7248
7249         * stabsread.h (struct stab_section_list): Remove.
7250         (coffstab_build_psymtabs): Update.
7251         * dbxread.c (symbuf_sections): Now a std::vector.
7252         (sect_idx): New global.
7253         (fill_symbuf): Update.
7254         (coffstab_build_psymtabs): Change type of stabsects parameter.
7255         Update.
7256         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7257         std::vector.
7258         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7259         (coff_locate_sections): Update.
7260         (coff_symfile_read): Remove cleanups.  Update.
7261         (init_stringtab): Add storage parameter.
7262         (free_stringtab, free_stringtab_cleanup): Remove.
7263         (init_lineno): Add storage parameter.
7264         (free_linetab, free_linetab_cleanup): Remove.
7265
7266 2019-03-06  Pedro Alves  <palves@redhat.com>
7267
7268         * linux-fork.c (fork_info::clobber_regs): Delete.
7269         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7270         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7271         comment.  Adjust.
7272         (scoped_switch_fork_info::scoped_switch_fork_info)
7273         (checkpoint_command, linux_fork_context): Adjust
7274         fork_save_infrun_state calls.
7275
7276 2019-03-06  Pedro Alves  <palves@redhat.com>
7277
7278         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7279         (inf_has_multiple_threads): Return 'bool' and rewrite using
7280         inferior_info::threads().
7281
7282 2019-03-06  Pedro Alves  <palves@redhat.com>
7283
7284         * linux-fork.c: Include <list>.
7285         (fork_list): Now a std::list instance.
7286         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7287         (forks_exist_p, find_last_fork): Adjust.
7288         (new_fork): Delete.
7289         (one_fork_p): New.
7290         (add_fork): Adjust.
7291         (free_fork): Delete, folded into fork_info::~fork_info().
7292         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7293         Adjust.
7294         (init_fork_list): Delete.
7295         (linux_fork_killall, linux_fork_mourn_inferior)
7296         (linux_fork_detach, info_checkpoints_command): Adjust.
7297         (_initialize_linux_fork): No longer call init_fork_list.
7298
7299 2019-03-06  Pedro Alves  <palves@redhat.com>
7300
7301         * linux-fork.c (new_fork): New, split out of ...
7302         (add_fork): ... this.  Return void.  Move "first fork" special
7303         case from here, to ...
7304         (checkpoint_command): ... here.
7305         * linux-linux.h (add_fork): Return void.
7306
7307 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7308
7309         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7310
7311 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7312             Chris January  <chris.january@arm.com>
7313             David Lecomber  <david.lecomber@arm.com>
7314
7315         * f-exp.y: New token, UNOP_INTRINSIC.
7316         (exp): New pattern using UNOP_INTRINSIC token.
7317         (f77_keywords): Add 'abs' keyword.
7318         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7319         (value_from_host_double): New function.
7320         (evaluate_subexp_f): Support UNOP_ABS.
7321
7322 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7323
7324         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7325         types.
7326
7327 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7328
7329         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7330         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7331         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7332
7333 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7334
7335         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7336
7337 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7338             Chris January  <chris.january@arm.com>
7339
7340         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7341         * f-exp.y: Define 'KIND' token.
7342         (exp): New pattern for KIND expressions.
7343         (ptype): Handle types with a kind extension.
7344         (direct_abs_decl): Extend to spot kind extensions.
7345         (f77_keywords): Add 'kind' to the list.
7346         (push_kind_type): New function.
7347         (convert_to_kind_type): New function.
7348         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7349         * parse.c (operator_length_standard): Likewise.
7350         * parser-defs.h (enum type_pieces): Add tp_kind.
7351         * std-operator.def: Add UNOP_KIND.
7352
7353 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7354
7355         * f-exp.y (f_parse): Set yydebug.
7356
7357 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7358
7359         * f-lang.c (evaluate_subexp_f): New function.
7360         (exp_descriptor_f): New global.
7361         (f_language_defn): Use exp_descriptor_f instead of
7362         exp_descriptor_standard.
7363
7364 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7365
7366         * f-exp.y (struct token): Add comments.
7367         (dot_ops): Remove uppercase versions and the end marker.
7368         (f77_keywords): Likewise.
7369         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7370         entries in the dot_ops array are case insensitive, and use
7371         strncasecmp to compare strings.  Also some whitespace cleanup in
7372         this area.  Similar for the f77_keywords array, except entries in
7373         this list might be case sensitive.
7374
7375 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7376
7377         * f-exp.y (struct f77_boolean_val): Add comments.
7378         (boolean_values): Remove uppercase versions, and end marker.
7379         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7380         and use strncasecmp to achieve case insensitivity.  Additionally,
7381         perform whitespace cleanup around this code.
7382
7383 2019-03-06  Tom Tromey  <tromey@adacore.com>
7384
7385         * remote-sim.c (gdbsim_target_open): Use result of
7386         gdb_argv::release.
7387
7388 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7389         Dirk Schubert  <dirk.schubert@arm.com>
7390         Chris January  <chris.january@arm.com>
7391
7392         * eval.c (evaluate_subexp_standard): Call Fortran argument
7393         wrapping logic.
7394         * f-lang.c (struct value): A value which can be passed into a
7395         Fortran function call.
7396         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7397         where appropriate.
7398         (struct type): Value ready for a Fortran function call.
7399         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7400         is needed.
7401         * f-lang.h (fortran_argument_convert): Declaration.
7402         (fortran_preserve_arg_pointer): Declaration.
7403         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7404
7405 2019-03-05  Tom Tromey  <tromey@adacore.com>
7406
7407         * python/py-prettyprint.c (print_string_repr): Remove #if.
7408         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7409
7410 2019-03-05  Tom Tromey  <tromey@adacore.com>
7411
7412         * target.c (the_dummy_target): Move later.  Change type to
7413         "dummy_target".
7414         (initialize_targets): Don't initialize the_dummy_target.
7415
7416 2019-03-05  Tom Tromey  <tromey@adacore.com>
7417
7418         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7419         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7420
7421 2019-03-05  Tom Tromey  <tromey@adacore.com>
7422
7423         * windows-nat.c (windows_nat_target::attach)
7424         (windows_nat_target::detach): Don't call gdb_flush.
7425         * valprint.c (generic_val_print, val_print, val_print_string):
7426         Don't call gdb_flush.
7427         * utils.c (defaulted_query): Don't call gdb_flush.
7428         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7429         * target.c (target_announce_detach): Don't call gdb_flush.
7430         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7431         * remote.c (extended_remote_target::attach): Don't call
7432         gdb_flush.
7433         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7434         * printcmd.c (do_examine): Don't call gdb_flush.
7435         (info_display_command): Don't call gdb_flush.
7436         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7437         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7438         * memattr.c (info_mem_command): Don't call gdb_flush.
7439         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7440         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7441         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7442         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7443         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7444         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7445         (gnu_nat_target::detach): Don't call gdb_flush.
7446         * f-valprint.c (f_val_print): Don't call gdb_flush.
7447         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7448         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7449         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7450         gdb_flush.
7451         * c-valprint.c (c_val_print): Don't call gdb_flush.
7452         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7453
7454 2019-03-05  Tom Tromey  <tromey@adacore.com>
7455
7456         * varobj.c (update_dynamic_varobj_children): Update.
7457         (install_default_visualizer): Use reset, not release.
7458         * value.c (set_internalvar): Update.
7459         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7460         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7461         ATTRIBUTE_UNUSED_RESULT.
7462
7463 2019-03-05  Tom Tromey  <tromey@adacore.com>
7464
7465         * remote.c (class scoped_remote_fd) <release>: Add
7466         ATTRIBUTE_UNUSED_RESULT.
7467
7468 2019-03-05  Tom Tromey  <tromey@adacore.com>
7469
7470         * macroexp.c (struct macro_buffer) <release>: Add
7471         ATTRIBUTE_UNUSED_RESULT.
7472
7473 2019-03-05  Tom Tromey  <tromey@adacore.com>
7474
7475         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7476         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7477         ATTRIBUTE_UNUSED_RESULT.
7478
7479 2019-03-05  Tom Tromey  <tromey@adacore.com>
7480
7481         * common/scoped_fd.h (class scoped_fd) <release>: Add
7482         ATTRIBUTE_UNUSED_RESULT.
7483
7484 2019-03-05  Tom Tromey  <tromey@adacore.com>
7485
7486         * parser-defs.h (struct parser_state) <release>: Add
7487         ATTRIBUTE_UNUSED_RESULT.
7488
7489 2019-03-05  Tom Tromey  <tromey@adacore.com>
7490
7491         * utils.h (class gdb_argv) <release>: Add
7492         ATTRIBUTE_UNUSED_RESULT.
7493         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7494
7495 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7496
7497         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7498         for-loop range, to avoid compiler warnings.
7499
7500         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7501         avoid compiler warnings about unused variables.
7502
7503         * NEWS: Mention end of support for native debugging on MS-Windows
7504         before XP.
7505
7506         PR gdb/24292
7507         * common/netstuff.c:
7508         * gdbserver/gdbreplay.c
7509         * gdbserver/remote-utils.c:
7510         * ser-tcp.c:
7511         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7512         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7513         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7514         'getaddrinfo' and 'freeaddrinfo' were not available before
7515         Windows XP, and mingw.org's MinGW headers by default define
7516         _WIN32_WINNT to 0x500.
7517
7518 2019-03-01  Gary Benson <gbenson@redhat.com>
7519
7520         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7521
7522 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7523             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7524
7525         PR gdb/8527
7526         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7527         set_sigint_trap, clear_sigint_trap.
7528
7529 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7530
7531         * target.c (target_detach): Clear the regcache and the
7532         frame cache.
7533
7534 2019-02-27  Pedro Alves  <palves@redhat.com>
7535
7536         * utils.c (set_screen_size): When we cap the height/width sizes,
7537         tweak the corresponding command variable to show "unlimited":
7538
7539 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7540             Pedro Alves  <palves@redhat.com>
7541
7542         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7543         before calling rl_set_screen_size.
7544
7545 2019-02-27  Tom Tromey  <tromey@adacore.com>
7546
7547         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7548         define.
7549         * python/py-value.c: Remove Python 2.4 workaround.
7550         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7551         workaround.
7552         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7553         Python 2.4 workaround.
7554         * python/python-internal.h: Remove Python 2.4 comment.
7555         (Py_ssize_t): Don't define.
7556         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7557         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7558         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7559         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7560         * python/python.c (do_start_initialization): Remove Python 2.4
7561         workaround.
7562         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7563         (print_children): Remove Python 2.4 workaround.
7564         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7565         workaround.
7566         (CHARBUFFERPROC_NAME): Remove.
7567         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7568         Python 2.4 workaround.
7569
7570 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7571
7572         * NEWS: Note minimum Python version.
7573
7574 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7575
7576         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7577         code from these functions.  Remove corresponding ifdefs.  Use
7578         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7579         Remove gotos and target of gotos.
7580         (infpy_search_memory): Likewise.
7581
7582 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7583
7584         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7585         (hppa_gdbarch_init): Don't register deleted functions with
7586         gdbarch.
7587
7588 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7589
7590         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7591         (h8300_unwind_sp): Delete.
7592         (h8300_dummy_id): Delete.
7593         (h8300_gdbarch_init): Don't register deleted functions with
7594         gdbarch.
7595
7596 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7597
7598         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7599         (ft32_unwind_pc): Delete.
7600         (ft32_unwind_sp): Delete.
7601         (ft32_gdbarch_init): Don't register deleted functions with
7602         gdbarch.
7603
7604 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7605
7606         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7607         (frv_unwind_pc): Delete.
7608         (frv_unwind_sp): Delete.
7609         (frv_gdbarch_init): Don't register deleted functions with
7610         gdbarch.
7611
7612 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7613
7614         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7615         (riscv_unwind_pc): Delete.
7616         (riscv_unwind_sp): Delete.
7617         (riscv_gdbarch_init): Don't register deleted functions with
7618         gdbarch.
7619
7620 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7621
7622         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7623         (csky_unwind_pc): Delete.
7624         (csky_unwind_sp): Delete.
7625         (csky_gdbarch_init): Don't register deleted functions with
7626         gdbarch.
7627
7628 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7629
7630         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7631         (cris_unwind_pc): Delete.
7632         (cris_unwind_sp): Delete.
7633         (cris_gdbarch_init): Don't register deleted functions with
7634         gdbarch.
7635
7636 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7637
7638         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7639         (bfin_unwind_pc): Delete.
7640         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7641
7642 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7643
7644         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7645         (arm_unwind_pc): Delete.
7646         (arm_unwind_sp): Delete.
7647         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7648
7649 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7650
7651         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7652         (arc_unwind_pc): Delete.
7653         (arc_unwind_sp): Delete.
7654         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7655
7656 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7657
7658         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7659         (alpha_unwind_pc): Delete.
7660         (alpha_gdbarch_init): Don't register deleted functions with
7661         gdbarch.
7662
7663 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7664
7665         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7666         (aarch64_unwind_pc): Delete.
7667         (aarch64_unwind_sp): Delete.
7668         (aarch64_gdbarch_init): Don't register deleted functions with
7669         gdbarch.
7670
7671 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7672
7673         * gdbtypes.c (type_align): Don't consider static members when
7674         computing structure alignment.
7675
7676 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7677
7678         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7679         return 0 for other types.
7680         * arch-utils.c (default_type_align): Always return 0.
7681         * gdbarch.h: Regenerate.
7682         * gdbarch.sh (type_align): Extend comment.
7683         * gdbtypes.c (type_align): Add additional comments, always call
7684         gdbarch_type_align before applying the default rules.
7685         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7686         generic code will then apply a suitable default.
7687         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7688         types, return 0 for other types.
7689
7690 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7691
7692         * NEWS: Create a new section for the next release branch.
7693         Rename the section of the current branch, now that it has
7694         been cut.
7695
7696 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7697
7698         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7699         * version.in: Bump version to 8.3.50.DATE-git.
7700
7701 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7702
7703         * aix-thread.c (ptid_cmp): Remove unused variable.
7704         (get_signaled_thread): Likewise.
7705         (store_regs_user_thread): Likewise.
7706         (store_regs_kernel_thread): Likewise.
7707         (fetch_regs_kernel_thread): Remove shadowed variable.
7708
7709 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7710
7711         * features/riscv/32bit-cpu.xml: Add register numbers.
7712         * features/riscv/32bit-fpu.c: Regenerate.
7713         * features/riscv/32bit-fpu.xml: Add register numbers.
7714         * features/riscv/64bit-cpu.xml: Add register numbers.
7715         * features/riscv/64bit-fpu.c: Regenerate.
7716         * features/riscv/64bit-fpu.xml: Add register numbers.
7717
7718 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7719
7720         * NEWS: Mention two argument form of gdb.Value constructor.
7721         * python/py-value.c (convert_buffer_and_type_to_value): New
7722         function.
7723         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7724         Add support for handling an optional second argument.  Call
7725         convert_buffer_and_type_to_value as appropriate.
7726         * python/python-internal.h (Py_buffer_deleter): New struct.
7727         (Py_buffer_up): New typedef.
7728
7729 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7730
7731         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7732         instead of releasing ownership.
7733
7734 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7735
7736         * dwarf2read.c (open_and_init_dwp_file): Call
7737         elf_numsections instead of bfd_count_sections to initialize
7738         dwp_file->num_sections.
7739
7740 2019-02-25  Tom Tromey  <tromey@adacore.com>
7741
7742         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7743
7744 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7745
7746         * gcore.in: Add '--readnever' option when invoking GDB.
7747
7748 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7749
7750         * MAINTAINERS: Update my email address.
7751
7752 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7753
7754         * build-id.c (build_id_to_debug_bfd_1): New function.
7755         (build_id_to_debug_bfd): Look for separate debug file in
7756         sysroot.
7757
7758 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7759
7760         * gdbarch.sh: Update the copyright year range that is placed into
7761         generated files.
7762
7763 2019-02-22  Keith Seitz  <keiths@redhat.com>
7764
7765         PR symtab/23853
7766         * linespec.c (create_sals_line_offset): Search for the default
7767         symtab's filename instead of its fullname.
7768
7769 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7770
7771         * NEWS: Update style defaults.
7772
7773 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7774
7775         * main.c (captured_main_1): Disable styling in batch mode.
7776
7777 2019-02-20  Tom Tromey  <tom@tromey.com>
7778
7779         * symtab.c (symtab_symbol_info): Fix typos.
7780
7781 2019-02-20  Tom Tromey  <tromey@adacore.com>
7782
7783         * findcmd.c (_initialize_mem_search): Use upper case for
7784         metasyntactic variables.
7785
7786 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7787
7788         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7789         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7790
7791 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7792
7793         * top.h (source_file_name): Change to std::string.
7794         * top.c (source_file_name): Likewise.
7795         (command_line_input): Adjust.
7796         * cli/cli-script.c (script_from_file): Adjust.
7797
7798 2019-02-19  Tom Tromey  <tromey@adacore.com>
7799
7800         * ravenscar-thread.c
7801         (ravenscar_thread_target::update_thread_list): Don't call
7802         ada_build_task_list.
7803         * ada-lang.h (ada_build_task_list): Don't declare.
7804         * ada-tasks.c (struct ada_tasks_inferior_data)
7805         <task_list_valid_p>: Now bool.
7806         (read_known_tasks, ada_task_list_changed)
7807         (ada_tasks_invalidate_inferior_data): Update.
7808         (read_known_tasks_array): Return bool.
7809         (read_known_tasks_list): Likewise.
7810         (read_known_tasks): Return void.
7811         (ada_build_task_list): Now static.
7812
7813 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7814
7815         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7816         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7817
7818 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7819
7820         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7821         variant for ada_tasks_pspace_data_handle and
7822         ada_tasks_inferior_data_handle.
7823         (ada_tasks_pspace_data_cleanup): New function.
7824         (ada_tasks_inferior_data_cleanup): New function.
7825
7826 2019-02-17  Tom Tromey  <tom@tromey.com>
7827
7828         * macrotab.h (macro_source_fullname): Return a std::string.
7829         * macrotab.c (macro_include, check_for_redefinition)
7830         (macro_undef, macro_lookup_definition, foreach_macro)
7831         (foreach_macro_in_scope): Update.
7832         (macro_source_fullname): Return a std::string.
7833         * macrocmd.c (show_pp_source_pos): Update.
7834
7835 2019-02-17  Tom Tromey  <tom@tromey.com>
7836
7837         * macrocmd.c (show_pp_source_pos): Style the file names.
7838
7839 2019-02-17  Tom Tromey  <tom@tromey.com>
7840
7841         PR tui/24197:
7842         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7843
7844 2019-02-17  Tom Tromey  <tom@tromey.com>
7845
7846         * ada-lang.c (user_select_syms): Use filtered printing.
7847         * utils.c (wrap_style): New global.
7848         (desired_style): Remove.
7849         (emit_style_escape): Add stream parameter.
7850         (set_output_style, reset_terminal_style, prompt_for_continue):
7851         Update.
7852         (flush_wrap_buffer): Only flush gdb_stdout.
7853         (wrap_here): Set wrap_style.
7854         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7855         treat escape sequences as a character.  Change when wrap buffer is
7856         flushed.
7857         (fputs_styled): Do not set the output style when the default is
7858         requested.
7859         * ui-style.h (struct ui_file_style) <is_default>: New method.
7860         * source.c (print_source_lines_base): Emit escape sequences in one
7861         piece.
7862
7863 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7864
7865         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7866         integers and enumeration types.
7867
7868 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7869
7870         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7871         instead of lookup_symbol_in_language
7872         (do_exact_match): New function.
7873         (ada_get_symbol_name_matcher): Return do_exact_match when
7874         doing a verbatim match.
7875
7876 2019-02-15  Tom Tromey  <tromey@adacore.com>
7877
7878         * ravenscar-thread.c (ravenscar_thread_target::resume)
7879         (ravenscar_thread_target::wait): Special case wildcard requests.
7880
7881 2019-02-15  Tom Tromey  <tromey@adacore.com>
7882
7883         * ravenscar-thread.c (base_ptid): Remove.
7884         (struct ravenscar_thread_target) <close>: New method.
7885         <m_base_ptid>: New member.
7886         <update_inferior_ptid, active_task, task_is_currently_active,
7887         runtime_initialized>: Declare methods.
7888         <ravenscar_thread_target>: Add constructor.
7889         (ravenscar_thread_target::task_is_currently_active)
7890         (ravenscar_thread_target::update_inferior_ptid)
7891         (ravenscar_runtime_initialized): Rename.  Now methods.
7892         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7893         (ravenscar_thread_target::update_thread_list): Update.
7894         (ravenscar_thread_target::active_task): Now method.
7895         (ravenscar_thread_target::store_registers)
7896         (ravenscar_thread_target::prepare_to_store)
7897         (ravenscar_thread_target::prepare_to_store)
7898         (ravenscar_thread_target::mourn_inferior): Update.
7899         (ravenscar_inferior_created): Use "new" to create target.
7900         (ravenscar_thread_target::get_ada_task_ptid): Update.
7901         (_initialize_ravenscar): Don't initialize base_ptid.
7902         (ravenscar_ops): Remove global.
7903
7904 2019-02-15  Tom Tromey  <tromey@adacore.com>
7905
7906         * target.h (push_target): Declare new overload.
7907         * target.c (push_target): New overload, taking an rvalue reference.
7908         * remote.c (remote_target::open_1): Use push_target overload.
7909         * corelow.c (core_target_open): Use push_target overload.
7910
7911 2019-02-15  Tom Tromey  <tromey@adacore.com>
7912
7913         * ravenscar-thread.c (is_ravenscar_task)
7914         (ravenscar_task_is_currently_active): Return bool.
7915         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7916         (_initialize_ravenscar): Remove "(void)".
7917         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7918         Return bool.
7919
7920 2019-02-15  Tom Tromey  <tromey@adacore.com>
7921
7922         * ravenscar-thread.c (ravenscar_runtime_initializer)
7923         (has_ravenscar_runtime, get_running_thread_id)
7924         (ravenscar_thread_target::resume): Fix indentation.
7925
7926 2019-02-15  Tom Tromey  <tromey@adacore.com>
7927
7928         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7929         from ravenscar_arch_ops.
7930         (sparc_ravenscar_ops::fetch_registers)
7931         (sparc_ravenscar_ops::store_registers): Now methods.
7932         (sparc_ravenscar_prepare_to_store): Remove.
7933         (sparc_ravenscar_ops): Redefine.
7934         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7935         methods and destructor.  Remove members.
7936         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7937         (ravenscar_thread_target::store_registers)
7938         (ravenscar_thread_target::prepare_to_store): Update.
7939         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7940         Remove.
7941         (struct ppc_ravenscar_powerpc_ops): Derive from
7942         ravenscar_arch_ops.
7943         (ppc_ravenscar_powerpc_ops::fetch_registers)
7944         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7945         (ppc_ravenscar_powerpc_ops): Redefine.
7946         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7947         (ppc_ravenscar_e500_ops::fetch_registers)
7948         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7949         (ppc_ravenscar_e500_ops): Redefine.
7950         * aarch64-ravenscar-thread.c
7951         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7952         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7953         (aarch64_ravenscar_fetch_registers)
7954         (aarch64_ravenscar_store_registers): Now methods.
7955         (aarch64_ravenscar_ops): Redefine.
7956
7957 2019-02-15  Tom Tromey  <tromey@adacore.com>
7958
7959         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7960         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7961         (ravenscar_thread_target::stopped_by_watchpoint)
7962         (ravenscar_thread_target::stopped_data_address)
7963         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7964
7965 2019-02-15  Tom Tromey  <tromey@adacore.com>
7966
7967         * ravenscar-thread.c: Fix some typos.
7968
7969 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7970             Tom Tromey  <tromey@adacore.com>
7971
7972         * ada-lang.c (ada_exception_sal): Change addr_string to a
7973         std::string.
7974         (create_ada_exception_catchpoint): Update.
7975
7976 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7977             Tom Tromey  <tromey@adacore.com>
7978
7979         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7980         (bp_location_ops): Remove.
7981         (base_breakpoint_allocate_location): Update.
7982         (free_bp_location): Update.
7983         * ada-lang.c (class ada_catchpoint_location)
7984         <ada_catchpoint_location>: Remove ops parameter.
7985         (ada_catchpoint_location_dtor): Remove.
7986         (ada_catchpoint_location_ops): Remove.
7987         (allocate_location_exception): Update.
7988         * breakpoint.h (struct bp_location_ops): Remove.
7989         (class bp_location) <bp_location>: Remove bp_location_ops
7990         parameter.
7991         <~bp_location>: Add destructor.
7992         <ops>: Remove.
7993
7994 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7995             Pedro Alves  <palves@redhat.com>
7996
7997         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7998         'PATH_MAX'.
7999
8000 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8001             Samuel Thibault  <samuel.thibault@gnu.org>
8002             Thomas Schwinge  <thomas@codesourcery.com>
8003
8004         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8005         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8006
8007 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8008
8009         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8010         (check_empty): Use "const char *".
8011
8012         * gnu-nat.c (gnu_nat_target::detach): Instead of
8013         'detach_inferior (pid)' call
8014         'detach_inferior (find_inferior_pid (pid))'.
8015
8016         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8017         'nat/fork-inferior.o'.
8018         * gnu-nat.c: #include "nat/fork-inferior.h".
8019
8020         * gnu-nat.c (gnu_nat_target::detach): Instead of
8021         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8022         * gnu-nat.h: #include "inf-child.h".
8023         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8024         'i386_gnu_nat_target::fetch_registers'.
8025         (gnu_store_registers): Rename/move to
8026         'i386_gnu_nat_target::store_registers'.
8027
8028         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8029         * gnu-nat.h (mach_thread_info): New function.
8030         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8031
8032         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8033
8034 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8035
8036         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8037
8038 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8039
8040         * windows-nat.c (windows_add_thread): Add new parameter
8041         "main_thread_p" with default value set to false.  Update
8042         function documentation as well as all callers.
8043         (windows_delete_thread): Likewise.
8044         (fake_create_process): Update call to windows_add_thread.
8045         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8046         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8047         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8048         call to windows_delete_thread.
8049
8050 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8051
8052         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8053
8054 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8055
8056         * symfile.c (find_separate_debug_file): Use canonical path of
8057         sysroot with child_path instead of gdb_sysroot if it is valid.
8058
8059 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8060
8061         * symfile.c (find_separate_debug_file): Use child_path to
8062         determine if an object file is under a sysroot.
8063
8064 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8065
8066         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8067         unittests/child-path-selftests.c.
8068         * common/pathstuff.c (child_path): New function.
8069         * common/pathstuff.h (child_path): New prototype.
8070         * unittests/child-path-selftests.c: New file.
8071
8072 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8073
8074         * symfile.c (find_separate_debug_file): Look for separate debug
8075         files in debug directories under the sysroot.
8076
8077 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8078
8079         * symtab.h (struct minimal_symbol data_p): New const method.
8080         (struct minimal_symbol text_p): Likewise.
8081         * symtab.c (output_source_filename): Use file name style
8082         to print file name.
8083         (print_symbol_info): Likewise.
8084         (print_msymbol_info): Use address style to print addresses.
8085         Use function name style to print executable text symbols.
8086         (expand_symtab_containing_pc): Use data_p.
8087         (find_pc_sect_compunit_symtab): Likewise.
8088
8089 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8090
8091         * breakpoint.c (describe_other_breakpoints): Use address style
8092         to print addresses.
8093         (say_where): Likewise.
8094
8095 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8096
8097         * ada-typeprint.c (print_func_type): Print function name
8098         style to print function name.
8099         * c-typeprint.c (c_print_type_1): Likewise.
8100
8101 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8102
8103         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8104         for execve.
8105
8106 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8107
8108         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8109         type_stack.
8110
8111 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8112
8113         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8114         TYPE_CODE_REF types.
8115
8116 2019-02-08  Jim Wilson  <jimw@sifive.com>
8117
8118         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8119         (riscv_linux_fregset): New.
8120         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8121
8122 2019-02-07  Tom Tromey  <tom@tromey.com>
8123
8124         * thread.c (thread_cancel_execution_command): Update.
8125         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8126         methods.
8127         (struct thread_fsm_ops): Remove.
8128         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8129         (thread_fsm_should_stop, thread_fsm_return_value)
8130         (thread_fsm_set_finished, thread_fsm_finished_p)
8131         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8132         Don't declare.
8133         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8134         * infrun.c (clear_proceed_status_thread)
8135         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8136         (print_stop_event): Update.
8137         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8138         Add constructor.
8139         (step_command_fsm_ops): Remove.
8140         (new_step_command_fsm): Remove.
8141         (step_1): Update.
8142         (step_command_fsm::should_stop): Rename from
8143         step_command_fsm_should_stop.
8144         (step_command_fsm::clean_up): Rename from
8145         step_command_fsm_clean_up.
8146         (step_command_fsm::do_async_reply_reason): Rename from
8147         step_command_fsm_async_reply_reason.
8148         (struct until_next_fsm): Inherit from thread_fsm.  Add
8149         constructor.
8150         (until_next_fsm_ops): Remove.
8151         (new_until_next_fsm): Remove.
8152         (until_next_fsm::should_stop): Rename from
8153         until_next_fsm_should_stop.
8154         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8155         (until_next_fsm::do_async_reply_reason): Rename from
8156         until_next_fsm_async_reply_reason.
8157         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8158         constructor.  Change type of breakpoint.
8159         (finish_command_fsm_ops): Remove.
8160         (new_finish_command_fsm): Remove.
8161         (finish_command_fsm::should_stop): Rename from
8162         finish_command_fsm_should_stop.
8163         (finish_command_fsm::clean_up): Rename from
8164         finish_command_fsm_clean_up.
8165         (finish_command_fsm::return_value): Rename from
8166         finish_command_fsm_return_value.
8167         (finish_command_fsm::do_async_reply_reason): Rename from
8168         finish_command_fsm_async_reply_reason.
8169         (finish_command): Update.
8170         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8171         Add constructor.
8172         (call_thread_fsm_ops): Remove.
8173         (call_thread_fsm::call_thread_fsm): Rename from
8174         new_call_thread_fsm.
8175         (call_thread_fsm::should_stop): Rename from
8176         call_thread_fsm_should_stop.
8177         (call_thread_fsm::should_notify_stop): Rename from
8178         call_thread_fsm_should_notify_stop.
8179         (run_inferior_call, call_function_by_hand_dummy): Update.
8180         * cli/cli-interp.c (should_print_stop_to_console): Update.
8181         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8182         Add constructor.  Change type of location_breakpoint,
8183         caller_breakpoint.
8184         (until_break_fsm_ops): Remove.
8185         (new_until_break_fsm): Remove.
8186         (until_break_fsm::should_stop): Rename from
8187         until_break_fsm_should_stop.
8188         (until_break_fsm::clean_up): Rename from
8189         until_break_fsm_clean_up.
8190         (until_break_fsm::do_async_reply_reason): Rename from
8191         until_break_fsm_async_reply_reason.
8192         (until_break_command): Update.
8193         * thread-fsm.c: Remove.
8194         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8195
8196 2019-02-07  Tom Tromey  <tom@tromey.com>
8197
8198         * yy-remap.h: Add include guard.
8199         * xtensa-tdep.h: Add include guard.
8200         * xcoffread.h: Rename include guard.
8201         * varobj-iter.h: Add include guard.
8202         * tui/tui.h: Rename include guard.
8203         * tui/tui-winsource.h: Rename include guard.
8204         * tui/tui-wingeneral.h: Rename include guard.
8205         * tui/tui-windata.h: Rename include guard.
8206         * tui/tui-win.h: Rename include guard.
8207         * tui/tui-stack.h: Rename include guard.
8208         * tui/tui-source.h: Rename include guard.
8209         * tui/tui-regs.h: Rename include guard.
8210         * tui/tui-out.h: Rename include guard.
8211         * tui/tui-layout.h: Rename include guard.
8212         * tui/tui-io.h: Rename include guard.
8213         * tui/tui-hooks.h: Rename include guard.
8214         * tui/tui-file.h: Rename include guard.
8215         * tui/tui-disasm.h: Rename include guard.
8216         * tui/tui-data.h: Rename include guard.
8217         * tui/tui-command.h: Rename include guard.
8218         * tic6x-tdep.h: Add include guard.
8219         * target/waitstatus.h: Rename include guard.
8220         * target/wait.h: Rename include guard.
8221         * target/target.h: Rename include guard.
8222         * target/resume.h: Rename include guard.
8223         * target-float.h: Rename include guard.
8224         * stabsread.h: Add include guard.
8225         * rs6000-tdep.h: Add include guard.
8226         * riscv-fbsd-tdep.h: Add include guard.
8227         * regformats/regdef.h: Rename include guard.
8228         * record.h: Rename include guard.
8229         * python/python.h: Rename include guard.
8230         * python/python-internal.h: Rename include guard.
8231         * python/py-stopevent.h: Rename include guard.
8232         * python/py-ref.h: Rename include guard.
8233         * python/py-record.h: Rename include guard.
8234         * python/py-record-full.h: Rename include guard.
8235         * python/py-record-btrace.h: Rename include guard.
8236         * python/py-instruction.h: Rename include guard.
8237         * python/py-events.h: Rename include guard.
8238         * python/py-event.h: Rename include guard.
8239         * procfs.h: Add include guard.
8240         * proc-utils.h: Add include guard.
8241         * p-lang.h: Add include guard.
8242         * or1k-tdep.h: Rename include guard.
8243         * observable.h: Rename include guard.
8244         * nto-tdep.h: Rename include guard.
8245         * nat/x86-linux.h: Rename include guard.
8246         * nat/x86-linux-dregs.h: Rename include guard.
8247         * nat/x86-gcc-cpuid.h: Add include guard.
8248         * nat/x86-dregs.h: Rename include guard.
8249         * nat/x86-cpuid.h: Rename include guard.
8250         * nat/ppc-linux.h: Rename include guard.
8251         * nat/mips-linux-watch.h: Rename include guard.
8252         * nat/linux-waitpid.h: Rename include guard.
8253         * nat/linux-ptrace.h: Rename include guard.
8254         * nat/linux-procfs.h: Rename include guard.
8255         * nat/linux-osdata.h: Rename include guard.
8256         * nat/linux-nat.h: Rename include guard.
8257         * nat/linux-namespaces.h: Rename include guard.
8258         * nat/linux-btrace.h: Rename include guard.
8259         * nat/glibc_thread_db.h: Rename include guard.
8260         * nat/gdb_thread_db.h: Rename include guard.
8261         * nat/gdb_ptrace.h: Rename include guard.
8262         * nat/fork-inferior.h: Rename include guard.
8263         * nat/amd64-linux-siginfo.h: Rename include guard.
8264         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8265         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8266         * nat/aarch64-linux.h: Rename include guard.
8267         * nat/aarch64-linux-hw-point.h: Rename include guard.
8268         * mn10300-tdep.h: Add include guard.
8269         * mips-linux-tdep.h: Add include guard.
8270         * mi/mi-parse.h: Rename include guard.
8271         * mi/mi-out.h: Rename include guard.
8272         * mi/mi-main.h: Rename include guard.
8273         * mi/mi-interp.h: Rename include guard.
8274         * mi/mi-getopt.h: Rename include guard.
8275         * mi/mi-console.h: Rename include guard.
8276         * mi/mi-common.h: Rename include guard.
8277         * mi/mi-cmds.h: Rename include guard.
8278         * mi/mi-cmd-break.h: Rename include guard.
8279         * m2-lang.h: Add include guard.
8280         * location.h: Rename include guard.
8281         * linux-record.h: Rename include guard.
8282         * linux-nat.h: Add include guard.
8283         * linux-fork.h: Add include guard.
8284         * i386-darwin-tdep.h: Rename include guard.
8285         * hppa-linux-offsets.h: Add include guard.
8286         * guile/guile.h: Rename include guard.
8287         * guile/guile-internal.h: Rename include guard.
8288         * gnu-nat.h: Rename include guard.
8289         * gdb-stabs.h: Rename include guard.
8290         * frv-tdep.h: Add include guard.
8291         * f-lang.h: Add include guard.
8292         * event-loop.h: Add include guard.
8293         * darwin-nat.h: Rename include guard.
8294         * cp-abi.h: Rename include guard.
8295         * config/sparc/nm-sol2.h: Rename include guard.
8296         * config/nm-nto.h: Rename include guard.
8297         * config/nm-linux.h: Add include guard.
8298         * config/i386/nm-i386gnu.h: Rename include guard.
8299         * config/djgpp/nl_types.h: Rename include guard.
8300         * config/djgpp/langinfo.h: Rename include guard.
8301         * compile/gcc-cp-plugin.h: Add include guard.
8302         * compile/gcc-c-plugin.h: Add include guard.
8303         * compile/compile.h: Rename include guard.
8304         * compile/compile-object-run.h: Rename include guard.
8305         * compile/compile-object-load.h: Rename include guard.
8306         * compile/compile-internal.h: Rename include guard.
8307         * compile/compile-cplus.h: Rename include guard.
8308         * compile/compile-c.h: Rename include guard.
8309         * common/xml-utils.h: Rename include guard.
8310         * common/x86-xstate.h: Rename include guard.
8311         * common/version.h: Rename include guard.
8312         * common/vec.h: Rename include guard.
8313         * common/tdesc.h: Rename include guard.
8314         * common/selftest.h: Rename include guard.
8315         * common/scoped_restore.h: Rename include guard.
8316         * common/scoped_mmap.h: Rename include guard.
8317         * common/scoped_fd.h: Rename include guard.
8318         * common/safe-iterator.h: Rename include guard.
8319         * common/run-time-clock.h: Rename include guard.
8320         * common/refcounted-object.h: Rename include guard.
8321         * common/queue.h: Rename include guard.
8322         * common/ptid.h: Rename include guard.
8323         * common/print-utils.h: Rename include guard.
8324         * common/preprocessor.h: Rename include guard.
8325         * common/pathstuff.h: Rename include guard.
8326         * common/observable.h: Rename include guard.
8327         * common/netstuff.h: Rename include guard.
8328         * common/job-control.h: Rename include guard.
8329         * common/host-defs.h: Rename include guard.
8330         * common/gdb_wait.h: Rename include guard.
8331         * common/gdb_vecs.h: Rename include guard.
8332         * common/gdb_unlinker.h: Rename include guard.
8333         * common/gdb_unique_ptr.h: Rename include guard.
8334         * common/gdb_tilde_expand.h: Rename include guard.
8335         * common/gdb_sys_time.h: Rename include guard.
8336         * common/gdb_string_view.h: Rename include guard.
8337         * common/gdb_splay_tree.h: Rename include guard.
8338         * common/gdb_setjmp.h: Rename include guard.
8339         * common/gdb_ref_ptr.h: Rename include guard.
8340         * common/gdb_optional.h: Rename include guard.
8341         * common/gdb_locale.h: Rename include guard.
8342         * common/gdb_assert.h: Rename include guard.
8343         * common/filtered-iterator.h: Rename include guard.
8344         * common/filestuff.h: Rename include guard.
8345         * common/fileio.h: Rename include guard.
8346         * common/environ.h: Rename include guard.
8347         * common/common-utils.h: Rename include guard.
8348         * common/common-types.h: Rename include guard.
8349         * common/common-regcache.h: Rename include guard.
8350         * common/common-inferior.h: Rename include guard.
8351         * common/common-gdbthread.h: Rename include guard.
8352         * common/common-exceptions.h: Rename include guard.
8353         * common/common-defs.h: Rename include guard.
8354         * common/common-debug.h: Rename include guard.
8355         * common/cleanups.h: Rename include guard.
8356         * common/buffer.h: Rename include guard.
8357         * common/btrace-common.h: Rename include guard.
8358         * common/break-common.h: Rename include guard.
8359         * cli/cli-utils.h: Rename include guard.
8360         * cli/cli-style.h: Rename include guard.
8361         * cli/cli-setshow.h: Rename include guard.
8362         * cli/cli-script.h: Rename include guard.
8363         * cli/cli-interp.h: Rename include guard.
8364         * cli/cli-decode.h: Rename include guard.
8365         * cli/cli-cmds.h: Rename include guard.
8366         * charset-list.h: Add include guard.
8367         * buildsym-legacy.h: Rename include guard.
8368         * bfin-tdep.h: Add include guard.
8369         * ax.h: Rename include guard.
8370         * arm-linux-tdep.h: Add include guard.
8371         * arm-fbsd-tdep.h: Add include guard.
8372         * arch/xtensa.h: Rename include guard.
8373         * arch/tic6x.h: Add include guard.
8374         * arch/i386.h: Add include guard.
8375         * arch/arm.h: Rename include guard.
8376         * arch/arm-linux.h: Rename include guard.
8377         * arch/arm-get-next-pcs.h: Rename include guard.
8378         * arch/amd64.h: Add include guard.
8379         * arch/aarch64-insn.h: Rename include guard.
8380         * arch-utils.h: Rename include guard.
8381         * annotate.h: Add include guard.
8382         * amd64-darwin-tdep.h: Rename include guard.
8383         * aarch64-linux-tdep.h: Add include guard.
8384         * aarch64-fbsd-tdep.h: Add include guard.
8385         * aarch32-linux-nat.h: Add include guard.
8386
8387 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8388
8389         * macrotab.c (macro_define_internal): New function that
8390         factorizes macro_define_object_internal and macro_define_function
8391         code.
8392         (macro_define_object_internal): Use macro_define_internal.
8393         (macro_define_function): Likewise.
8394
8395 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8396
8397         * macrocmd.c (extract_identifier): Return
8398         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8399         callers.
8400
8401 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8402
8403         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8404
8405 2019-02-05  Tom Tromey  <tom@tromey.com>
8406
8407         * target.c (target_stack::unpush): Move assertion earlier.
8408
8409 2019-01-30  Tom Tromey  <tom@tromey.com>
8410
8411         PR python/23615:
8412         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8413         (gdbpy_parse_and_eval): Likewise.
8414         * python/python-internal.h (gdbpy_allow_threads): New class.
8415
8416 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8417
8418         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8419         (aarch64_fbsd_fpregmap): Move earlier.
8420         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8421         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8422         instead of individual calls to trad_frame_set_reg_addr.
8423         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8424         earlier.
8425         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8426         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8427         instead of individual calls to trad_frame_set_reg_addr.
8428
8429 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8430
8431         * CONTRIBUTE: Replace contribution list with wiki link.
8432
8433 2019-01-25  Tom Tromey  <tom@tromey.com>
8434
8435         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8436
8437 2019-01-25  Tom Tromey  <tom@tromey.com>
8438
8439         * xtensa-linux-nat.c: Fix common/ includes.
8440         * xml-support.h: Fix common/ includes.
8441         * xml-support.c: Fix common/ includes.
8442         * x86-linux-nat.c: Fix common/ includes.
8443         * windows-nat.c: Fix common/ includes.
8444         * varobj.h: Fix common/ includes.
8445         * varobj.c: Fix common/ includes.
8446         * value.c: Fix common/ includes.
8447         * valops.c: Fix common/ includes.
8448         * utils.c: Fix common/ includes.
8449         * unittests/xml-utils-selftests.c: Fix common/ includes.
8450         * unittests/utils-selftests.c: Fix common/ includes.
8451         * unittests/unpack-selftests.c: Fix common/ includes.
8452         * unittests/tracepoint-selftests.c: Fix common/ includes.
8453         * unittests/style-selftests.c: Fix common/ includes.
8454         * unittests/string_view-selftests.c: Fix common/ includes.
8455         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8456         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8457         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8458         * unittests/rsp-low-selftests.c: Fix common/ includes.
8459         * unittests/parse-connection-spec-selftests.c: Fix common/
8460         includes.
8461         * unittests/optional-selftests.c: Fix common/ includes.
8462         * unittests/offset-type-selftests.c: Fix common/ includes.
8463         * unittests/observable-selftests.c: Fix common/ includes.
8464         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8465         * unittests/memrange-selftests.c: Fix common/ includes.
8466         * unittests/memory-map-selftests.c: Fix common/ includes.
8467         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8468         * unittests/function-view-selftests.c: Fix common/ includes.
8469         * unittests/environ-selftests.c: Fix common/ includes.
8470         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8471         * unittests/common-utils-selftests.c: Fix common/ includes.
8472         * unittests/cli-utils-selftests.c: Fix common/ includes.
8473         * unittests/array-view-selftests.c: Fix common/ includes.
8474         * ui-file.c: Fix common/ includes.
8475         * tui/tui-io.c: Fix common/ includes.
8476         * tracepoint.h: Fix common/ includes.
8477         * tracepoint.c: Fix common/ includes.
8478         * tracefile-tfile.c: Fix common/ includes.
8479         * top.h: Fix common/ includes.
8480         * top.c: Fix common/ includes.
8481         * thread.c: Fix common/ includes.
8482         * target/waitstatus.h: Fix common/ includes.
8483         * target/waitstatus.c: Fix common/ includes.
8484         * target.h: Fix common/ includes.
8485         * target.c: Fix common/ includes.
8486         * target-memory.c: Fix common/ includes.
8487         * target-descriptions.c: Fix common/ includes.
8488         * symtab.h: Fix common/ includes.
8489         * symfile.c: Fix common/ includes.
8490         * stap-probe.c: Fix common/ includes.
8491         * spu-linux-nat.c: Fix common/ includes.
8492         * sparc-nat.c: Fix common/ includes.
8493         * source.c: Fix common/ includes.
8494         * solib.c: Fix common/ includes.
8495         * solib-target.c: Fix common/ includes.
8496         * ser-unix.c: Fix common/ includes.
8497         * ser-tcp.c: Fix common/ includes.
8498         * ser-pipe.c: Fix common/ includes.
8499         * ser-base.c: Fix common/ includes.
8500         * selftest-arch.c: Fix common/ includes.
8501         * s12z-tdep.c: Fix common/ includes.
8502         * rust-exp.y: Fix common/ includes.
8503         * rs6000-aix-tdep.c: Fix common/ includes.
8504         * riscv-tdep.c: Fix common/ includes.
8505         * remote.c: Fix common/ includes.
8506         * remote-notif.h: Fix common/ includes.
8507         * remote-fileio.h: Fix common/ includes.
8508         * remote-fileio.c: Fix common/ includes.
8509         * regcache.h: Fix common/ includes.
8510         * regcache.c: Fix common/ includes.
8511         * record-btrace.c: Fix common/ includes.
8512         * python/python.c: Fix common/ includes.
8513         * python/py-type.c: Fix common/ includes.
8514         * python/py-inferior.c: Fix common/ includes.
8515         * progspace.h: Fix common/ includes.
8516         * producer.c: Fix common/ includes.
8517         * procfs.c: Fix common/ includes.
8518         * proc-api.c: Fix common/ includes.
8519         * printcmd.c: Fix common/ includes.
8520         * ppc-linux-nat.c: Fix common/ includes.
8521         * parser-defs.h: Fix common/ includes.
8522         * osdata.c: Fix common/ includes.
8523         * obsd-nat.c: Fix common/ includes.
8524         * nat/x86-linux.c: Fix common/ includes.
8525         * nat/x86-linux-dregs.c: Fix common/ includes.
8526         * nat/x86-dregs.h: Fix common/ includes.
8527         * nat/x86-dregs.c: Fix common/ includes.
8528         * nat/ppc-linux.c: Fix common/ includes.
8529         * nat/mips-linux-watch.h: Fix common/ includes.
8530         * nat/mips-linux-watch.c: Fix common/ includes.
8531         * nat/linux-waitpid.c: Fix common/ includes.
8532         * nat/linux-ptrace.h: Fix common/ includes.
8533         * nat/linux-ptrace.c: Fix common/ includes.
8534         * nat/linux-procfs.c: Fix common/ includes.
8535         * nat/linux-personality.c: Fix common/ includes.
8536         * nat/linux-osdata.c: Fix common/ includes.
8537         * nat/linux-namespaces.c: Fix common/ includes.
8538         * nat/linux-btrace.h: Fix common/ includes.
8539         * nat/linux-btrace.c: Fix common/ includes.
8540         * nat/fork-inferior.c: Fix common/ includes.
8541         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8542         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8543         * nat/aarch64-linux.c: Fix common/ includes.
8544         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8545         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8546         * namespace.h: Fix common/ includes.
8547         * mips-linux-tdep.c: Fix common/ includes.
8548         * minsyms.c: Fix common/ includes.
8549         * mi/mi-parse.h: Fix common/ includes.
8550         * mi/mi-main.c: Fix common/ includes.
8551         * mi/mi-cmd-env.c: Fix common/ includes.
8552         * memrange.h: Fix common/ includes.
8553         * memattr.c: Fix common/ includes.
8554         * maint.h: Fix common/ includes.
8555         * maint.c: Fix common/ includes.
8556         * main.c: Fix common/ includes.
8557         * machoread.c: Fix common/ includes.
8558         * location.c: Fix common/ includes.
8559         * linux-thread-db.c: Fix common/ includes.
8560         * linux-nat.c: Fix common/ includes.
8561         * linux-fork.c: Fix common/ includes.
8562         * inline-frame.c: Fix common/ includes.
8563         * infrun.c: Fix common/ includes.
8564         * inflow.c: Fix common/ includes.
8565         * inferior.h: Fix common/ includes.
8566         * inferior.c: Fix common/ includes.
8567         * infcmd.c: Fix common/ includes.
8568         * inf-ptrace.c: Fix common/ includes.
8569         * inf-child.c: Fix common/ includes.
8570         * ia64-linux-nat.c: Fix common/ includes.
8571         * i387-tdep.c: Fix common/ includes.
8572         * i386-tdep.c: Fix common/ includes.
8573         * i386-linux-tdep.c: Fix common/ includes.
8574         * i386-linux-nat.c: Fix common/ includes.
8575         * i386-go32-tdep.c: Fix common/ includes.
8576         * i386-fbsd-tdep.c: Fix common/ includes.
8577         * i386-fbsd-nat.c: Fix common/ includes.
8578         * guile/scm-type.c: Fix common/ includes.
8579         * guile/guile.c: Fix common/ includes.
8580         * go32-nat.c: Fix common/ includes.
8581         * gnu-nat.c: Fix common/ includes.
8582         * gdbthread.h: Fix common/ includes.
8583         * gdbarch-selftests.c: Fix common/ includes.
8584         * gdb_usleep.c: Fix common/ includes.
8585         * gdb_select.h: Fix common/ includes.
8586         * gdb_bfd.c: Fix common/ includes.
8587         * gcore.c: Fix common/ includes.
8588         * fork-child.c: Fix common/ includes.
8589         * findvar.c: Fix common/ includes.
8590         * fbsd-nat.c: Fix common/ includes.
8591         * event-top.c: Fix common/ includes.
8592         * event-loop.c: Fix common/ includes.
8593         * dwarf2read.c: Fix common/ includes.
8594         * dwarf2loc.c: Fix common/ includes.
8595         * dwarf2-frame.c: Fix common/ includes.
8596         * dwarf-index-cache.c: Fix common/ includes.
8597         * dtrace-probe.c: Fix common/ includes.
8598         * disasm-selftests.c: Fix common/ includes.
8599         * defs.h: Fix common/ includes.
8600         * csky-tdep.c: Fix common/ includes.
8601         * cp-valprint.c: Fix common/ includes.
8602         * cp-support.h: Fix common/ includes.
8603         * cp-support.c: Fix common/ includes.
8604         * corelow.c: Fix common/ includes.
8605         * completer.h: Fix common/ includes.
8606         * completer.c: Fix common/ includes.
8607         * compile/compile.c: Fix common/ includes.
8608         * compile/compile-loc2c.c: Fix common/ includes.
8609         * compile/compile-cplus-types.c: Fix common/ includes.
8610         * compile/compile-cplus-symbols.c: Fix common/ includes.
8611         * command.h: Fix common/ includes.
8612         * cli/cli-dump.c: Fix common/ includes.
8613         * cli/cli-cmds.c: Fix common/ includes.
8614         * charset.c: Fix common/ includes.
8615         * build-id.c: Fix common/ includes.
8616         * btrace.h: Fix common/ includes.
8617         * btrace.c: Fix common/ includes.
8618         * breakpoint.h: Fix common/ includes.
8619         * breakpoint.c: Fix common/ includes.
8620         * ax.h:
8621         (enum agent_op): Fix common/ includes.
8622         * ax-general.c (struct aop_map): Fix common/ includes.
8623         * ax-gdb.c: Fix common/ includes.
8624         * auxv.c: Fix common/ includes.
8625         * auto-load.c: Fix common/ includes.
8626         * arm-tdep.c: Fix common/ includes.
8627         * arch/riscv.c: Fix common/ includes.
8628         * arch/ppc-linux-common.c: Fix common/ includes.
8629         * arch/i386.c: Fix common/ includes.
8630         * arch/arm.c: Fix common/ includes.
8631         * arch/arm-linux.c: Fix common/ includes.
8632         * arch/arm-get-next-pcs.c: Fix common/ includes.
8633         * arch/amd64.c: Fix common/ includes.
8634         * arch/aarch64.c: Fix common/ includes.
8635         * arch/aarch64-insn.c: Fix common/ includes.
8636         * arch-utils.c: Fix common/ includes.
8637         * amd64-windows-tdep.c: Fix common/ includes.
8638         * amd64-tdep.c: Fix common/ includes.
8639         * amd64-sol2-tdep.c: Fix common/ includes.
8640         * amd64-obsd-tdep.c: Fix common/ includes.
8641         * amd64-nbsd-tdep.c: Fix common/ includes.
8642         * amd64-linux-tdep.c: Fix common/ includes.
8643         * amd64-linux-nat.c: Fix common/ includes.
8644         * amd64-fbsd-tdep.c: Fix common/ includes.
8645         * amd64-fbsd-nat.c: Fix common/ includes.
8646         * amd64-dicos-tdep.c: Fix common/ includes.
8647         * amd64-darwin-tdep.c: Fix common/ includes.
8648         * agent.c: Fix common/ includes.
8649         * ada-lang.h: Fix common/ includes.
8650         * ada-lang.c: Fix common/ includes.
8651         * aarch64-tdep.c: Fix common/ includes.
8652
8653 2019-01-25  Tom Tromey  <tom@tromey.com>
8654
8655         * common/create-version.sh: Use common/version.h.
8656
8657 2019-01-24  Pedro Alves  <palves@redhat.com>
8658
8659         * infrun.c (signal_stop, signal_print, signal_program)
8660         (signal_catch, signal_pass): Now arrays instead of pointers.
8661         (update_signals_program_target, do_target_resume)
8662         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8663         * linux-nat.c (linux_nat_target::pass_signals)
8664         (linux_nat_target::create_inferior, linux_nat_target::attach):
8665         Adjust.
8666         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8667         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8668         * procfs.c (procfs_target::pass_signals): Adjust.
8669         * record-full.c (record_full_target::resume): Adjust.
8670         * remote.c (remote_target::pass_signals)
8671         (remote_target::program_signals): Adjust.
8672         * target-debug.h (target_debug_print_signals): Now takes a
8673         gdb::array_view as parameter.  Adjust.
8674         * target.h (target_ops) <pass_signals, program_signals>: Replace
8675         pointer and length parameters with gdb::array_view.
8676         (target_pass_signals, target_program_signals): Likewise.
8677         * target-delegates.c: Regenerate.
8678
8679 2019-01-24  Pedro Alves  <palves@redhat.com>
8680
8681         * common/forward-scope-exit.h
8682         (forward_scope_exit::forward_scope_exit): Pass arguments to
8683         m_bind_function directly, instead of creating a std::bind and
8684         copying that.
8685
8686 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8687
8688         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8689         for static members.
8690         (pass_in_v_vfp_candidate): Likewise.
8691
8692 2019-01-23  Tom Tromey  <tom@tromey.com>
8693             Pedro Alves  <palves@redhat.com>
8694
8695         * regcache.c (class regcache_invalidator): Remove.
8696         (regcache::raw_write): Use make_scope_exit.
8697
8698 2019-01-23  Tom Tromey  <tom@tromey.com>
8699
8700         * ui-out.h (class ui_out_emit_type): Update comment.
8701
8702 2019-01-23  Tom Tromey  <tom@tromey.com>
8703
8704         * infrun.c (fetch_inferior_event): Update comment.
8705
8706 2019-01-23  Tom Tromey  <tom@tromey.com>
8707             Pedro Alves  <palves@redhat.com>
8708
8709         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8710         parameter.
8711         (fetch_inferior_event): Use SCOPE_EXIT.
8712
8713
8714 2019-01-23  Tom Tromey  <tom@tromey.com>
8715             Pedro Alves  <palves@redhat.com>
8716
8717         * infrun.c (disable_thread_events): Delete.
8718         (stop_all_threads): Use SCOPE_EXIT.
8719
8720 2019-01-23  Tom Tromey  <tom@tromey.com>
8721             Pedro Alves  <palves@redhat.com>
8722
8723         * symfile.c: Include forward-scope-exit.h.
8724         (clear_symtab_users_cleanup): Replace forward declaration with
8725         a FORWARD_SCOPE_EXIT.
8726         (syms_from_objfile_1): Use the forward_scope_exit and
8727         gdb::optional instead of cleanup_function.
8728         (reread_symbols): Use the forward_scope_exit instead of
8729         cleanup_function.
8730         (clear_symtab_users_cleanup): Remove function.
8731
8732 2019-01-23  Tom Tromey  <tom@tromey.com>
8733             Pedro Alves  <palves@redhat.com>
8734
8735         * linux-nat.c: Include scope-exit.h.
8736         (cleanup_target_stop): Remove.
8737         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8738         SCOPE_EXIT.
8739
8740 2019-01-23  Tom Tromey  <tom@tromey.com>
8741             Pedro Alves  <palves@redhat.com>
8742
8743         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8744         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8745
8746 2019-01-23  Tom Tromey  <tom@tromey.com>
8747             Andrew Burgess  <andrew.burgess@embecosm.com>
8748             Pedro Alves  <palves@redhat.com>
8749
8750         * infrun.c (fetch_inferior_event): Use scope_exit.
8751         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8752         * top.c (execute_command): Use scope_exit.
8753         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8754         * utils.c (do_bpstat_clear_actions_cleanup)
8755         (make_bpstat_clear_actions_cleanup): Remove.
8756
8757 2019-01-23  Tom Tromey  <tom@tromey.com>
8758             Pedro Alves  <palves@redhat.com>
8759
8760         * infrun.c: Include "common/scope-exit.h"
8761         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8762         (wait_for_inferior): Use SCOPE_EXIT.
8763         (fetch_inferior_event): Use scope_exit.
8764
8765 2019-01-23  Tom Tromey  <tom@tromey.com>
8766             Pedro Alves  <palves@redhat.com>
8767
8768         * breakpoint.c (create_breakpoint): Remove cleanup.
8769
8770 2019-01-23  Tom Tromey  <tom@tromey.com>
8771             Andrew Burgess  <andrew.burgess@embecosm.com>
8772             Pedro Alves  <palves@redhat.com>
8773
8774 2019-01-23  Pedro Alves  <palves@redhat.com>
8775
8776         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8777
8778 2019-01-23  Pedro Alves  <palves@redhat.com>
8779             Andrew Burgess  <andrew.burgess@embecosm.com>
8780
8781         * gdbthread.h: Include "common/forward-scope-exit.h".
8782         (scoped_finish_thread_state): Redefine custom class in terms of
8783         forward_scope_exit.
8784
8785 2019-01-23  Pedro Alves  <palves@redhat.com>
8786             Andrew Burgess  <andrew.burgess@embecosm.com>
8787
8788         * common/forward-scope-exit.h: New file.
8789
8790 2019-01-23  Pedro Alves  <palves@redhat.com>
8791             Andrew Burgess  <andrew.burgess@embecosm.com>
8792             Tom Tromey  <tom@tromey.com>
8793
8794         * common/scope-exit.h: New file.
8795
8796 2019-01-23  Pedro Alves  <palves@redhat.com>
8797
8798         * common/preprocessor.h (ESC): Rename to ...
8799         (ESC_PARENS): ... this.
8800         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8801         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8802
8803 2019-01-23  Tom Tromey  <tom@tromey.com>
8804
8805         * language.h (class scoped_switch_to_sym_language_if_auto):
8806         Initialize m_lang in both cases.
8807
8808 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8809
8810         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8811         with XCNEW.
8812
8813 2019-01-22  Tom Tromey  <tom@tromey.com>
8814
8815         * corelow.c: Do not include sys/file.h.
8816
8817 2019-01-22  Tom Tromey  <tom@tromey.com>
8818
8819         * tui/tui-wingeneral.h: Include gdb_curses.h.
8820
8821 2019-01-22  Tom Tromey  <tom@tromey.com>
8822
8823         * source-cache.h (class source_cache) <get_source_lines,
8824         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8825
8826 2019-01-22  Tom Tromey  <tom@tromey.com>
8827
8828         * remote-fileio.h (struct remote_target): Declare.
8829
8830 2019-01-22  Tom Tromey  <tom@tromey.com>
8831
8832         * python/py-arch.c: Do not include py-ref.h.
8833         * python/py-bpevent.c: Do not include py-ref.h.
8834         * python/py-cmd.c: Do not include py-ref.h.
8835         * python/py-continueevent.c: Do not include py-ref.h.
8836         * python/py-event.h: Do not include py-ref.h.
8837         * python/py-evtregistry.c: Do not include py-ref.h.
8838         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8839         * python/py-frame.c: Do not include py-ref.h.
8840         * python/py-framefilter.c: Do not include py-ref.h.
8841         * python/py-function.c: Do not include py-ref.h.
8842         * python/py-infevents.c: Do not include py-ref.h.
8843         * python/py-linetable.c: Do not include py-ref.h.
8844         * python/py-objfile.c: Do not include py-ref.h.
8845         * python/py-param.c: Do not include py-ref.h.
8846         * python/py-prettyprint.c: Do not include py-ref.h.
8847         * python/py-progspace.c: Do not include py-ref.h.
8848         * python/py-symbol.c: Do not include py-ref.h.
8849         * python/py-symtab.c: Do not include py-ref.h.
8850         * python/py-type.c: Do not include py-ref.h.
8851         * python/py-unwind.c: Do not include py-ref.h.
8852         * python/py-utils.c: Do not include py-ref.h.
8853         * python/py-value.c: Do not include py-ref.h.
8854         * python/py-varobj.c: Do not include py-ref.h.
8855         * python/py-xmethods.c: Do not include py-ref.h.
8856         * python/python.c: Do not include py-ref.h.
8857         * varobj.c: Do not include py-ref.h.
8858
8859 2019-01-22  Tom Tromey  <tom@tromey.com>
8860
8861         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8862         keyword for bcache.
8863
8864 2019-01-22  Tom Tromey  <tom@tromey.com>
8865
8866         * compile/compile-cplus-types.c: Remove a comment by #include.
8867
8868 2019-01-22  Tom Tromey  <tom@tromey.com>
8869
8870         * compile/gcc-c-plugin.h: Include compile-internal.h.
8871
8872 2019-01-22  Tom Tromey  <tom@tromey.com>
8873
8874         * stabsread.c (EXTERN): Do not define.
8875         (symnum, next_symbol_text_func, processing_gcc_compilation)
8876         (within_function, global_sym_chain, global_stabs)
8877         (previous_stab_code, this_object_header_files)
8878         (n_this_object_header_files)
8879         (n_allocated_this_object_header_files): Define.
8880         * stabsread.h (EXTERN): Never define.  Use "extern".
8881
8882 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8883
8884         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8885         history_value.
8886
8887 2019-01-21  Tom Tromey  <tom@tromey.com>
8888
8889         * ui-out.c: Fix includes.
8890         * tui/tui-source.c: Fix includes.
8891         * target.c: Fix includes.
8892         * remote.c: Fix includes.
8893         * regcache.c: Fix includes.
8894         * python/py-block.c: Fix includes.
8895         * printcmd.c: Fix includes.
8896         * or1k-tdep.c: Fix includes.
8897         * mi/mi-main.c: Fix includes.
8898         * m32r-tdep.c: Fix includes.
8899         * csky-tdep.c: Fix includes.
8900         * compile/compile-cplus-types.c: Fix includes.
8901         * cli/cli-interp.c: Fix includes.
8902
8903 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8904
8905         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8906         for padding.
8907
8908 2019-01-16  Tom Tromey  <tom@tromey.com>
8909
8910         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8911         earlier.
8912         (struct objfile) <msymbols_range>: Move from top level.
8913         <msymbols>: New method.
8914         (class objfile_msymbols): Remove.
8915         * symtab.c (default_collect_symbol_completion_matches_break_on):
8916         Update.
8917         * symmisc.c (dump_msymbols): Update.
8918         * stabsread.c (scan_file_globals): Update.
8919         * objc-lang.c (info_selectors_command, info_classes_command)
8920         (find_methods): Update.
8921         * minsyms.c (find_solib_trampoline_target): Update.
8922         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8923         * coffread.c (coff_symfile_read): Update.
8924         * ada-lang.c (ada_lookup_simple_minsym)
8925         (ada_collect_symbol_completion_matches): Update.
8926
8927 2019-01-16  Tom Tromey  <tom@tromey.com>
8928
8929         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8930         type.  Remove no-argument constructor.
8931         <iterator::operator++>: Simplify.
8932         <begin>: Update.
8933         <end>: Use minimal_symbol_count.
8934
8935 2019-01-16  Tom Tromey  <tom@tromey.com>
8936
8937         * objfiles.h (struct objfile) <psymtabs>: New method.
8938         (class objfile_psymtabs): Remove.
8939         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8940         typedef.
8941         <range>: New method.
8942         (require_partial_symbols): Change return type.
8943         * psymtab.c (require_partial_symbols)
8944         (psym_expand_symtabs_matching): Update.
8945         * mdebugread.c (parse_partial_symbols): Update.
8946         * dbxread.c (dbx_end_psymtab): Update.
8947
8948 2019-01-15  Tom Tromey  <tom@tromey.com>
8949
8950         * symtab.c (lookup_objfile_from_block)
8951         (lookup_symbol_in_objfile_symtabs)
8952         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8953         (find_line_symtab, info_sources_command)
8954         (default_collect_symbol_completion_matches_break_on)
8955         (make_source_files_completion_list): Update.
8956         * symmisc.c (print_objfile_statistics, dump_objfile)
8957         (maintenance_print_symbols, maintenance_info_symtabs)
8958         (maintenance_check_symtabs, maintenance_info_line_tables):
8959         Update.
8960         * source.c (select_source_symtab)
8961         (forget_cached_source_info_for_objfile): Update.
8962         * objfiles.h (class objfile_compunits): Remove.
8963         (struct objfile) <compunits_range>: New typedef.
8964         (compunits): New method.
8965         * objfiles.c (objfile_relocate1): Update.
8966         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8967         * maint.c (count_symtabs_and_blocks): Update.
8968         * linespec.c (iterate_over_all_matching_symtabs): Update.
8969         * cp-support.c (add_symbol_overload_list_qualified): Update.
8970         * coffread.c (coff_symtab_read): Update.
8971         * ada-lang.c (add_nonlocal_symbols)
8972         (ada_collect_symbol_completion_matches)
8973         (ada_add_global_exceptions): Update.
8974
8975 2019-01-15  Tom Tromey  <tom@tromey.com>
8976
8977         * progspace.h (program_space) <objfiles_safe_range>: New
8978         typedef.
8979         <objfiles_safe>: New method.
8980         * objfiles.h (class all_objfiles_safe): Remove.
8981         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8982         * jit.c (jit_inferior_exit_hook): Update.
8983
8984 2019-01-17  Tom Tromey  <tom@tromey.com>
8985
8986         * progspace.h (program_space) <objfiles_range>: New typedef.
8987         <objfiles>: New method.
8988         <objfiles_head>: Rename from objfiles.
8989         (object_files): Update.
8990         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8991         * guile/scm-pretty-print.c
8992         (ppscm_find_pretty_printer_from_objfiles): Update.
8993         * guile/scm-objfile.c (gdbscm_objfiles): Update.
8994         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8995         Update.
8996         * python/py-progspace.c (pspy_get_objfiles): Update.
8997         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8998         Update.
8999         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9000         (objfpy_lookup_objfile_by_build_id): Update.
9001         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9002         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9003         Update.
9004         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9005         (expand_symtab_containing_pc, lookup_objfile_from_block)
9006         (lookup_static_symbol, basic_lookup_transparent_type)
9007         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9008         (find_line_symtab, info_sources_command)
9009         (default_collect_symbol_completion_matches_break_on)
9010         (make_source_files_completion_list, find_main_name): Update.
9011         * symmisc.c (print_symbol_bcache_statistics)
9012         (print_objfile_statistics, maintenance_print_symbols)
9013         (maintenance_print_msymbols, maintenance_print_objfiles)
9014         (maintenance_info_symtabs, maintenance_check_symtabs)
9015         (maintenance_expand_symtabs, maintenance_info_line_tables):
9016         Update.
9017         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9018         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9019         (map_overlay_command, unmap_overlay_command)
9020         (simple_overlay_update, expand_symtabs_matching)
9021         (map_symbol_filenames): Update.
9022         * symfile-debug.c (set_debug_symfile): Update.
9023         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9024         Update.
9025         * source.c (select_source_symtab, forget_cached_source_info):
9026         Update.
9027         * solib.c (solib_read_symbols): Update.
9028         * solib-spu.c (append_ocl_sos): Update.
9029         * psymtab.c (maintenance_print_psymbols)
9030         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9031         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9032         * printcmd.c (info_symbol_command): Update.
9033         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9034         Update.
9035         * objfiles.h (class all_objfiles): Remove.
9036         * objfiles.c (have_partial_symbols, have_full_symbols)
9037         (have_minimal_symbols, qsort_cmp, update_section_map)
9038         (shared_objfile_contains_address_p)
9039         (default_iterate_over_objfiles_in_search_order): Update.
9040         * objc-lang.c (info_selectors_command, info_classes_command)
9041         (find_methods): Update.
9042         * minsyms.c (find_solib_trampoline_target): Update.
9043         * maint.c (maintenance_info_sections)
9044         (maintenance_translate_address, count_symtabs_and_blocks):
9045         Update.
9046         * main.c (captured_main_1): Update.
9047         * linux-thread-db.c (try_thread_db_load_from_pdir)
9048         (has_libpthread): Update.
9049         * linespec.c (iterate_over_all_matching_symtabs)
9050         (search_minsyms_for_name): Update.
9051         * jit.c (jit_find_objf_with_entry_addr): Update.
9052         * hppa-tdep.c (find_unwind_entry)
9053         (hppa_lookup_stub_minimal_symbol): Update.
9054         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9055         Update.
9056         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9057         (elf_gnu_ifunc_resolve_by_got): Update.
9058         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9059         * dwarf-index-write.c (save_gdb_index_command): Update.
9060         * cp-support.c (add_symbol_overload_list_qualified): Update.
9061         * breakpoint.c (create_overlay_event_breakpoint)
9062         (create_longjmp_master_breakpoint)
9063         (create_std_terminate_master_breakpoint)
9064         (create_exception_master_breakpoint): Update.
9065         * blockframe.c (find_pc_partial_function): Update.
9066         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9067         (ada_collect_symbol_completion_matches)
9068         (ada_add_global_exceptions): Update.
9069
9070 2019-01-17  Tom Tromey  <tom@tromey.com>
9071
9072         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9073         declare VEC.
9074         (solib_target_parse_libraries): Change return type.
9075         (library_list_start_segment, library_list_start_section)
9076         (library_list_end_library, library_list_start_library); Update.
9077         (solib_target_free_library_list): Remove.
9078         (solib_target_parse_libraries): Remove cleanup.  Change return
9079         type.
9080         (solib_target_current_sos): Update.
9081
9082 2019-01-17  Tom Tromey  <tromey@bapiya>
9083
9084         * valprint.c: Replace "the the" with "the".
9085         * symtab.c: Replace "the the" with "the".
9086         * solib.c: Replace "the the" with "the".
9087         * solib-dsbt.c: Replace "the the" with "the".
9088         * linespec.c: Replace "the the" with "the".
9089         * dwarf2loc.h: Replace "the the" with "the".
9090         * amd64-windows-tdep.c: Replace "the the" with "the".
9091         * aarch64-tdep.c: Replace "the the" with "the".
9092
9093 2019-01-16  Keith Seitz  <keiths@redhat.com>
9094
9095         PR gdb/23773
9096         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9097         <builder>: Rename to ..
9098         <m_builder>: ... this and make private.
9099         (dwarf2_cu::get_builder): New method.  Change all users of
9100         `builder' to use this method.
9101         (dwarf2_start_symtab): Move to ...
9102         (dwarf2_cu::start_symtab): ... here.  Update all callers
9103         (setup_type_unit_groups): Move to ...
9104         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9105         callers.
9106         (dwarf2_cu::reset_builder): New method.
9107         (process_full_compunit, process_full_type_unit): Use
9108         dwarf2_cu::reset_builder.
9109         (follow_die_offset): Record the ancestor CU if it is different
9110         from the followed DIE's CU.
9111         (follow_die_sig_1): Likewise.
9112
9113 2019-01-15  Tom Tromey  <tom@tromey.com>
9114
9115         * remote.c (class remote_state) <buf>: Now a char_vector.
9116         <buf_size>: Remove.
9117         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9118         parameter.
9119         (remote_target::getpkt_or_notif_sane_1)
9120         (remote_target::getpkt_sane)
9121         (remote_target::getpkt_or_notif_sane): Likewise.
9122         (class remote_target) <putpkt>: New overload.
9123         (remote_target::read_frame): Change type of "buf_p".  Remove
9124         sizeof_p parameter.
9125         (packet_ok): New overload.
9126         (packet_check_result): New overload.
9127         Update all uses.
9128
9129 2019-01-14  Tom Tromey  <tom@tromey.com>
9130
9131         * remote-notif.c (handle_notification, remote_notif_ack)
9132         (remote_notif_parse): Make "buf" const.
9133         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9134         const.
9135         (remote_notif_parse, remote_notif_ack, handle_notification):
9136         Likewise.
9137         * remote.c (remote_notif_stop_parse): Make "buf" const.
9138         (remote_target::remote_parse_stop_reply): Make "buf" const.
9139         (remote_notif_stop_ack): Make "buf" const.
9140
9141 2019-01-14  Tom Tromey  <tom@tromey.com>
9142
9143         * remote.c (remote_console_output): Make parameter const.
9144
9145 2019-01-14  Tom Tromey  <tom@tromey.com>
9146
9147         * target-debug.h (target_debug_print_signals): Constify.
9148         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9149         * procfs.c (procfs_target::pass_signals): Update.
9150         * linux-nat.c (linux_nat_target::pass_signals): Update.
9151         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9152         * target-delegates.c: Rebuild.
9153         * remote.c (remote_target::program_signals): Update.
9154         (remote_target::pass_signals): Update.
9155         * target.c (target_pass_signals): Constify argument.
9156         (target_program_signals): Likewise.
9157         * target.h (struct target_ops) <pass_signals, program_signals>:
9158         Constify argument.
9159         (target_pass_signals, target_program_signals): Constify argument.
9160
9161 2019-01-14  Tom Tromey  <tom@tromey.com>
9162
9163         PR tui/28819:
9164         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9165
9166 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9167
9168         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9169         field.
9170         * rs6000-tdep.c: Include reggroups.h.
9171         (IS_V_ALIAS_PSEUDOREG): Define.
9172         (rs6000_register_name): Return names for the "vX" aliases.
9173         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9174         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9175         aliases.  Call default_register_reggroup_p for all other
9176         pseudo-registers.
9177         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9178         New functions.
9179         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9180         Handle "vX" aliases.
9181         (v_alias_pseudo_register_collect): New function.
9182         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9183         (rs6000_gdbarch_init): Initialize "vX" aliases as
9184         pseudo-registers.  Restore registration of
9185         rs6000_pseudo_register_reggroup_p with
9186         set_tdesc_pseudo_register_reggroup_p.
9187
9188 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9189
9190         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9191         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9192         set_gdbarch_num_pseudo_regs.
9193
9194 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9195
9196         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9197         Remove arg prefixname, add do_set and do_show.
9198         Add member functions set_list and show_list.
9199         * cli/cli-style.c (class cli_style_option): Update accordingly.
9200         (style_set_list): Move to file scope.
9201         (style_show_list): Likewise.
9202         (set_style): Call help_list.
9203         (show_style): Call cmd_show_list.
9204         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9205         Update to use the new macro.
9206
9207 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9208
9209         * ada-lang.c (_initialize_ada_language): Expand the help text
9210         for the "catch exception" command.
9211
9212 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9213
9214         * symtab.c (matching_obj_sections): Initialize obj,
9215         declare it closer to its usage.
9216
9217 2019-01-10  Tom Tromey  <tom@tromey.com>
9218
9219         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9220         (basic_inf_threads_range): Remove.
9221         (inf_threads_range, inf_non_exited_threads_range)
9222         (safe_inf_threads_range): Use next_adapter.
9223
9224 2019-01-10  Keith Seitz  <keiths@redhat.com>
9225
9226         PR gdb/23712
9227         PR symtab/23010
9228         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9229         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9230
9231 2019-01-10  Keith Seitz  <keiths@redhat.com>
9232
9233         PR gdb/23712
9234         PR symtab/23010
9235         * dictionary.c (pending_to_vector): Remove.
9236         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9237         Remove _1 suffix, replacing functions of the same name.  Update
9238         all callers.
9239         (dict_create_hashed, dict_create_hashed_expandable)
9240         (dict_create_linear, dict_create_linear_expandable, dict_free)
9241         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9242         Make functions static.
9243
9244 2019-01-10  Keith Seitz  <keiths@redhat.com>
9245
9246         PR gdb/23712
9247         PR symtab/23010
9248         * dictionary.h (struct dictionary): Replace declaration with
9249         multidictionary.
9250         (dict_create_hashed, dict_create_hashed_expandable)
9251         (dict_create_linear, dict_create_linear_expandable)
9252         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9253         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9254         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9255         taking multidictionary argument.
9256         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9257         * block.h (struct block) <dict>: Change to multidictionary
9258         and rename `multidict'.
9259         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9260         symmisc.c: Update all dictionary references to multidictionary.
9261
9262 2019-01-10  Keith Seitz  <keiths@redhat.com>
9263
9264         PR gdb/23712
9265         PR symtab/23010
9266         * dictionary.c: Include unordered_map.
9267         (pending_to_vector): New function.
9268         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9269         Rewrite the non-"_1" functions to take vector instead
9270         of linked list.
9271         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9272         "new" _1 versions of the same name.
9273         (multidictionary): Define.
9274         (std::hash<enum language): New definition.
9275         (collate_pending_symbols_by_language, mdict_create_hashed)
9276         (mdict_create_hashed_expandable, mdict_create_linear)
9277         (mdict_create_linear_expandable, mdict_free)
9278         (find_language_dictionary, create_new_language_dictionary)
9279         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9280         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9281         (mdict_size, mdict_empty): New functions.
9282         * dictionary.h (mdict_iterator): Define.
9283
9284 2019-01-10  Pedro Alves  <palves@redhat.com>
9285
9286         * breakpoint.c (read_uploaded_action)
9287         (create_tracepoint_from_upload): Adjust to use
9288         gdb::unique_xmalloc_ptr.
9289         * ctf.c (ctf_write_uploaded_tp):
9290         (SET_ARRAY_FIELD): Use emplace_back.
9291         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9292         * tracefile-tfile.c (tfile_write_uploaded_tp):
9293         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9294         gdb::unique_xmalloc_ptr.
9295         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9296         at_string, cond_string, cmd_strings>: Replace char pointers
9297         with gdb::unique_xmalloc_ptr.
9298
9299 2019-01-10  Pedro Alves  <palves@redhat.com>
9300
9301         * solib-target.c (library_list_start_library): Don't xstrdup name.
9302
9303 2019-01-10  Pedro Alves  <palves@redhat.com>
9304
9305         * mdebugread.c (parse_partial_symbols): Use
9306         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9307
9308 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9309
9310         * linux-fork.c (scoped_switch_fork_info)
9311         <~scoped_switch_fork_info>: Fix incorrect variable name.
9312
9313 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9314
9315         * linux-fork.c (scoped_switch_fork_info)
9316         <scoped_switch_fork_info>: Make explicit.
9317         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9318
9319 2019-01-10  Tom Tromey  <tom@tromey.com>
9320
9321         * objfiles.h (objfile::reset_psymtabs): Update.
9322         * objfiles.c (objfile::objfile): Update.
9323         * psymtab.h (psymtab_storage::obstack): Update.
9324         (psymtab_storage::m_obstack): Use gdb::optional.
9325         (class psymtab_storage): Update comment.  Remove objfile
9326         parameter.
9327         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9328
9329 2019-01-10  Tom Tromey  <tom@tromey.com>
9330
9331         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9332         <free_psymtabs>: Now private.
9333         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9334         (allocate_psymtab): Use new method.
9335
9336 2019-01-10  Tom Tromey  <tom@tromey.com>
9337
9338         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9339         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9340         * mdebugread.c (parse_partial_symbols): Use
9341         allocate_dependencies.
9342         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9343         allocate_dependencies.
9344         (process_psymtab_comp_unit_reader)
9345         (build_type_psymtab_dependencies): Likewise.
9346         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9347
9348 2019-01-10  Tom Tromey  <tom@tromey.com>
9349
9350         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9351         PSYMBOL_SET_LANGUAGE.
9352         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9353
9354 2019-01-10  Tom Tromey  <tom@tromey.com>
9355
9356         * psymtab.h (psymtab_storage::obstack): New method.
9357         <m_obstack>: Rename from obstack; now private.
9358         * psymtab.c (psymtab_storage): Update.
9359         * dwarf2read.c (create_addrmap_from_index)
9360         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9361         Update.
9362
9363 2019-01-10  Tom Tromey  <tom@tromey.com>
9364
9365         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9366         * objfiles.h (objfile::reset_psymtabs): New method.
9367
9368 2019-01-10  Tom Tromey  <tom@tromey.com>
9369
9370         * symmisc.c (print_symbol_bcache_statistics): Update.
9371         (print_objfile_statistics): Update.
9372         * symfile.c (reread_symbols): Update.
9373         * psymtab.h (class psymtab_storage): New.
9374         * psymtab.c (psymtab_storage): New constructor.
9375         (~psymtab_storage): New destructor.
9376         (require_partial_symbols): Update.
9377         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9378         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9379         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9380         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9381         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9382         (start_psymtab_common, end_psymtab_common)
9383         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9384         (allocate_psymtab): Update.
9385         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9386         Update.
9387         (dump_psymtab_addrmap, maintenance_print_psymbols)
9388         (maintenance_check_psymtabs): Update.
9389         (class objfile_psymtabs): Move to objfiles.h.
9390         * psympriv.h (discard_psymtab): Now inline.
9391         (psymtab_discarder::psymtab_discarder): Update.
9392         (psymtab_discarder::~psymtab_discarder): Update.
9393         (ALL_OBJFILE_PSYMTABS): Rewrite.
9394         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9395         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9396         Remove fields.
9397         <partial_symtabs>: New field.
9398         (class objfile_psymtabs): Move from psymtab.h.  Update.
9399         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9400         psymbol_cache.
9401         (objfile::~objfile): Don't destroy psymbol_cache.
9402         * mdebugread.c (parse_partial_symbols): Update.
9403         * dwarf2read.c (create_addrmap_from_index)
9404         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9405         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9406         (add_partial_subprogram, dwarf2_ranges_read): Update.
9407         * dwarf-index-write.c (write_address_map)
9408         (write_one_signatured_type, recursively_write_psymbols)
9409         (class debug_names, class debug_names, write_psymtabs_to_index):
9410         Update.
9411
9412 2019-01-10  Tom Tromey  <tom@tromey.com>
9413
9414         * symtab.h (SYMBOL_SET_NAMES): Update.
9415         (symbol_set_names): Update.
9416         (MSYMBOL_SET_NAMES): Update.
9417         * symtab.c (symbol_set_names): Change argument to be an
9418         objfile_per_bfd_storage.
9419         * psymtab.c (add_psymbol_to_bcache): Update.
9420         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9421
9422 2019-01-10  Tom Tromey  <tom@tromey.com>
9423
9424         * symtab.c (create_demangled_names_hash): Change argument to be an
9425         objfile_per_bfd_storage.
9426         (symbol_set_names): Update.
9427
9428 2019-01-10  Tom Tromey  <tom@tromey.com>
9429
9430         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9431         init_psymbol_list.
9432         * psymtab.c (init_psymbol_list): Do nothing if already called.
9433         * psympriv.h (init_psymbol_list): Add comment.
9434         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9435         init_psymbol_list.
9436         * dbxread.c (dbx_symfile_read): Unconditionally call
9437         init_psymbol_list.
9438
9439 2019-01-10  Tom Tromey  <tom@tromey.com>
9440
9441         * xcoffread.c (scan_xcoff_symtab): Update.
9442         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9443         "where".
9444         * mdebugread.c (parse_partial_symbols)
9445         (handle_psymbol_enumerators): Update.
9446         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9447         * dbxread.c (read_dbx_symtab): Update.
9448         * psympriv.h (psymbol_placement): New enum.
9449         (add_psymbol_to_list): Update.
9450
9451 2019-01-10  Tom Tromey  <tom@tromey.com>
9452
9453         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9454         static_psymbols parameters.
9455         (scan_xcoff_symtab): Update.
9456         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9457         static_psymbols parameters.
9458         * psympriv.h (start_psymtab_common): Update.
9459         * mdebugread.c (parse_partial_symbols): Update.
9460         * dwarf2read.c (create_partial_symtab): Update.
9461         * dbxread.c (read_dbx_symtab): Update.
9462         (start_psymtab): Remove global_psymbols and static_psymbols
9463         parameters.
9464
9465 2019-01-10  Tom Tromey  <tom@tromey.com>
9466
9467         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9468         * psymtab.c (allocate_psymtab): Add comment.
9469         * psympriv.h (allocate_psymtab): Add comment.
9470         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9471         initializations.
9472         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9473
9474 2019-01-10  Tom Tromey  <tom@tromey.com>
9475
9476         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9477         Don't declare.
9478         * mipsread.c: Include mdebugread.h.
9479         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9480         Declare.
9481         * elfread.c: Include mdebugread.h.
9482
9483 2019-01-09  Tom Tromey  <tom@tromey.com>
9484
9485         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9486         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9487         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9488         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9489         (psym_lookup_symbol, psym_find_last_source_symtab)
9490         (psym_forget_cached_source_info, psym_print_stats)
9491         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9492         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9493         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9494         (psym_find_compunit_symtab_by_address)
9495         (maintenance_print_psymbols, maintenance_info_psymtabs)
9496         (maintenance_check_psymtabs): Use ranged for.
9497         * psymtab.h (class objfile_psymtabs): New.
9498         (require_partial_symbols): Return objfile_psymtabs.
9499         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9500
9501 2019-01-09  Tom Tromey  <tom@tromey.com>
9502
9503         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9504         (find_pc_mapped_section, list_overlays_command)
9505         (map_overlay_command, unmap_overlay_command)
9506         (simple_overlay_update): Use all_objfiles.
9507         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9508         * printcmd.c (info_symbol_command): Use all_objfiles.
9509         * objfiles.h (ALL_OBJSECTIONS): Remove.
9510         * maint.c (maintenance_translate_address): Use all_objfiles.
9511         * gcore.c (gcore_create_callback): Use all_objfiles.
9512         (objfile_find_memory_regions): Likewise.
9513
9514 2019-01-09  Tom Tromey  <tom@tromey.com>
9515
9516         * symtab.c (find_line_symtab, info_sources_command)
9517         (make_source_files_completion_list): Use objfile_compunits.
9518         * source.c (select_source_symtab): Use objfile_compunits.
9519         * objfiles.h (struct objfile): Update comment.
9520         (ALL_OBJFILES): Remove.
9521         (ALL_FILETABS): Remove.
9522         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9523         objfile_compunits.
9524
9525 2019-01-09  Tom Tromey  <tom@tromey.com>
9526
9527         * symmisc.c (print_objfile_statistics, dump_objfile)
9528         (maintenance_print_symbols): Use compunit_filetabs.
9529         * source.c (forget_cached_source_info_for_objfile): Use
9530         compunit_filetabs.
9531         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9532         (ALL_FILETABS): Use compunit_filetabs.
9533         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9534         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9535
9536 2019-01-09  Tom Tromey  <tom@tromey.com>
9537
9538         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9539         (compunit_filetabs): New.
9540         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9541         compunit_filetabs.
9542         (info_sources_command, make_source_files_completion_list): Remove
9543         declaration.
9544         * symmisc.c (print_objfile_statistics, dump_objfile)
9545         (maintenance_print_symbols): Remove declaration.
9546         (maintenance_info_symtabs): Use compunit_filetabs.
9547         (maintenance_info_line_tables): Likewise.
9548         * source.c (select_source_symtab): Change local variable name.
9549         (forget_cached_source_info_for_objfile): Remove declaration.
9550         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9551         * objfiles.c (objfile_relocate1): Remove declaration.
9552         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9553         declaration.
9554         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9555         * coffread.c (coff_symtab_read): Remove declaration.
9556         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9557         compunit_filetabs.
9558
9559 2019-01-09  Tom Tromey  <tom@tromey.com>
9560
9561         * symtab.c (lookup_objfile_from_block)
9562         (find_pc_sect_compunit_symtab, search_symbols)
9563         (default_collect_symbol_completion_matches_break_on): Use
9564         objfile_compunits.
9565         * objfiles.h (ALL_COMPUNITS): Remove.
9566         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9567         * cp-support.c (add_symbol_overload_list_qualified): Use
9568         objfile_compunits.
9569         * ada-lang.c (ada_collect_symbol_completion_matches)
9570         (ada_add_global_exceptions): Use objfile_compunits.
9571
9572 2019-01-09  Tom Tromey  <tom@tromey.com>
9573
9574         * source.c (select_source_symtab)
9575         (forget_cached_source_info_for_objfile): Remove declaration.
9576         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9577         declaration.
9578         * maint.c (count_symtabs_and_blocks): Remove declaration.
9579         * cp-support.c (add_symbol_overload_list_qualified): Remove
9580         declaration.
9581         * coffread.c (coff_symtab_read): Remove declaration.
9582         * symtab.c (lookup_symbol_in_objfile_symtabs)
9583         (basic_lookup_transparent_type_1): Use objfile_compunits.
9584         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9585         (info_sources_command, search_symbols)
9586         (default_collect_symbol_completion_matches_break_on)
9587         (make_source_files_completion_list): Remove declaration.
9588         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9589         (ada_collect_symbol_completion_matches)
9590         (ada_add_global_exceptions): Remove declaration.
9591         * linespec.c (iterate_over_all_matching_symtabs): Use
9592         objfile_compunits.
9593         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9594         (class objfile_compunits): New.
9595         (ALL_COMPUNITS): Use objfile_compunits.
9596         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9597         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9598         objfile_compunits.
9599         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9600
9601 2019-01-09  Tom Tromey  <tom@tromey.com>
9602
9603         * symtab.c (search_symbols)
9604         (default_collect_symbol_completion_matches_break_on): Use
9605         objfile_msymbols.
9606         * ada-lang.c (ada_lookup_simple_minsym)
9607         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9608         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9609         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9610         objfile_msymbols.
9611         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9612         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9613         * objc-lang.c (find_methods): Use objfile_msymbols.
9614         (info_selectors_command, info_classes_command): Likewise.
9615         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9616         * objfiles.h (class objfile_msymbols): New.
9617         (ALL_OBJFILE_MSYMBOLS): Remove.
9618         (ALL_MSYMBOLS): Remove.
9619
9620 2019-01-09  Tom Tromey  <tom@tromey.com>
9621
9622         * common/next-iterator.h (next_adapter): Add Iterator template
9623         parameter.
9624         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9625         (class all_objfiles_safe): New.
9626         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9627         * objfiles.c (put_objfile_before): Update comment.
9628         (add_separate_debug_objfile): Likewise.
9629         (free_all_objfiles): Use all_objfiles_safe.
9630         (objfile_purge_solibs): Likewise.
9631
9632 2019-01-09  Tom Tromey  <tom@tromey.com>
9633
9634         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9635         (expand_symtab_containing_pc, lookup_static_symbol)
9636         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9637         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9638         all_objfiles.
9639         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9640         * breakpoint.c (create_overlay_event_breakpoint)
9641         (create_longjmp_master_breakpoint)
9642         (create_std_terminate_master_breakpoint)
9643         (create_exception_master_breakpoint): Use all_objfiles.
9644         * linux-thread-db.c (try_thread_db_load_from_pdir)
9645         (has_libpthread): Use all_objfiles.
9646         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9647         * linespec.c (iterate_over_all_matching_symtabs)
9648         (search_minsyms_for_name): Use all_objfiles.
9649         * maint.c (maintenance_info_sections): Use all_objfiles.
9650         * main.c (captured_main_1): Use all_objfiles.
9651         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9652         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9653         * guile/scm-pretty-print.c
9654         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9655         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9656         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9657         (maintenance_print_msymbols): Use all_objfiles.
9658         * source.c (select_source_symtab): Use all_objfiles.
9659         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9660         * symfile.c (remove_symbol_file_command)
9661         (expand_symtabs_matching, map_symbol_filenames): Use
9662         all_objfiles.
9663         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9664         all_objfiles.
9665         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9666         * objc-lang.c (find_methods): Use all_objfiles.
9667         * objfiles.c (have_partial_symbols, have_full_symbols)
9668         (have_minimal_symbols, qsort_cmp)
9669         (default_iterate_over_objfiles_in_search_order): Use
9670         all_objfiles.
9671         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9672         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9673         (maintenance_check_psymtabs): Use all_objfiles.
9674         (ALL_PSYMTABS): Remove.
9675         * compile/compile-object-run.c (do_module_cleanup): Use
9676         all_objfiles.
9677         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9678         * cp-support.c (add_symbol_overload_list_qualified): Use
9679         all_objfiles.
9680         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9681         Use all_objfiles.
9682         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9683         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9684         all_objfiles.
9685         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9686         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9687         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9688         Uses all_objfiles.
9689         * solib.c (solib_read_symbols): Use all_objfiles
9690
9691 2019-01-09  Tom Tromey  <tom@tromey.com>
9692
9693         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9694         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9695         all_objfiles.
9696         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9697         * symmisc.c (print_symbol_bcache_statistics)
9698         (print_objfile_statistics, maintenance_print_objfiles)
9699         (maintenance_info_symtabs, maintenance_check_symtabs)
9700         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9701         all_objfiles.
9702         * source.c (forget_cached_source_info): Use all_objfiles.
9703         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9704         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9705         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9706         * objfiles.c (update_section_map): Use all_objfiles.
9707         (shared_objfile_contains_address_p): Likewise.
9708         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9709         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9710
9711 2019-01-09  Tom Tromey  <tom@tromey.com>
9712
9713         * common/next-iterator.h: New file.
9714         * objfiles.h (class all_objfiles): New.
9715         (struct objfile_iterator): New.
9716
9717 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9718
9719         * NEWS: Move the description of the changed "frame", "select-frame",
9720          and "info frame" commands to the Changed commands section.
9721
9722 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9723
9724         * gdbtypes.c (check_stub_method_group): Remove handling of old
9725         mangling schemes.
9726         * linespec.c (find_methods): Likewise.
9727         * stabsread.c (read_member_functions): Likewise.
9728         * valops.c (search_struct_method): Likewise.
9729         (value_struct_elt_for_reference): Likewise.
9730         * NEWS: Mention this change.
9731
9732 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9733
9734         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9735         print_source_lines.
9736         * source.c (print_source_lines_base): Update line number check.
9737         (print_source_lines): New function.
9738         (source_lines_range::source_lines_range): New function.
9739         * source.h (class source_lines_range): New class.
9740         (print_source_lines): New declaration.
9741
9742 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9743
9744         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9745
9746 2019-01-08  Tom Tromey  <tom@tromey.com>
9747             Simon Marchi  <simon.marchi@ericsson.com>
9748
9749         PR gdb/24060
9750         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9751         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9752         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9753         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9754         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9755         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9756
9757 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9758
9759         * source.c (select_source_symtab): Move header comment to
9760         declaration in source.h.
9761         (forget_cached_source_info_for_objfile): Likewise.
9762         (forget_cached_source_info): Likewise.
9763         (identify_source_line): Likewise.
9764         * source.h (identify_source_line): Move declaration from symtab.h
9765         and add comment from source.c
9766         (print_source_lines): Likewise.
9767         (forget_cached_source_info_for_objfile): Likewise.
9768         (forget_cached_source_info): Likewise.
9769         (select_source_symtab): Likewise.
9770         (enum print_source_lines_flag): Move definition from symtab.h.
9771         * symtab.h (identify_source_line): Move declaration to source.h.
9772         (print_source_lines): Likewise.
9773         (forget_cached_source_info_for_objfile): Likewise.
9774         (forget_cached_source_info): Likewise.
9775         (select_source_symtab): Likewise.
9776         (enum print_source_lines_flag): Move definition to source.h.
9777         * tui/tui-hooks.c: Add 'source.h' include.
9778
9779 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9780
9781         * source.c (print_source_lines_base): Handle requests to print
9782         reverse line number sequences, and guard against empty lines
9783         string.
9784
9785 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9786
9787         * source.c (print_source_lines_base): Fix skip of '\r' if next
9788         character is '\n'.
9789
9790 2019-01-06  Tom Tromey  <tom@tromey.com>
9791
9792         * c-exp.y (struct c_parse_state) <macro_original_text,
9793         expansion_obstack>: New member.
9794         (macro_original_text, expansion_obstack): Remove globals.
9795         (scan_macro_expansion, scanning_macro_expansion)
9796         (finished_macro_expansion): Update.
9797         (scan_macro_cleanup): Remove.
9798         (yylex, c_parse): Update.
9799
9800 2019-01-06  Tom Tromey  <tom@tromey.com>
9801
9802         * c-exp.y (struct c_parse_state) <strings>: New member.
9803         (operator_stoken): Update.
9804
9805 2019-01-06  Tom Tromey  <tom@tromey.com>
9806
9807         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9808         (union type_stack_elt) <typelist_val>: Now a pointer to
9809         std::vector.
9810         (type_stack_cleanup): Don't declare.
9811         (push_typelist): Update.
9812         * parse.c (pop_typelist): Return a std::vector.
9813         (push_typelist): Take a std::vector.
9814         (follow_types): Update.  Do not free args.
9815         (type_stack_cleanup): Remove.
9816         * c-exp.y (struct c_parse_state): New.
9817         (cpstate): New global.
9818         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9819         (nonempty_typelist): Update.
9820         (func_mod): Create a new vector.
9821         (c_parse): Create a c_parse_state.
9822         (check_parameter_typelist): Do not delete params.
9823         (function_method): Update.  Do not delete type_list.
9824
9825 2019-01-06  Tom Tromey  <tom@tromey.com>
9826
9827         PR gdb/28155:
9828         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9829         check_typedef.
9830         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9831         (print_return_value): Likewise.
9832
9833 2019-01-05  Tom Tromey  <tom@tromey.com>
9834
9835         * contrib/cleanup_check.py: Remove.
9836         * contrib/gcc-with-excheck: Remove.
9837         * contrib/exsummary.py: Remove.
9838         * contrib/excheck.py: Remove.
9839
9840 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9841
9842         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9843         NULL. Initialize tpprev to NULL instead of assigning it
9844         to NULL on the next statement.
9845         * windows-nat.c (windows_delete_thread): Remove check for
9846         main_thread_id before printing thread exit notifications.
9847         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9848         Remove thread ID check against main_thread_id.
9849         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9850         windows_delete_thread.
9851         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9852
9853 2019-01-04  Tom Tromey  <tom@tromey.com>
9854
9855         * compile/compile.c (_initialize_compile): Use upper case for
9856         metasyntactic variables.
9857         * symmisc.c (_initialize_symmisc): Use upper case for
9858         metasyntactic variables.
9859         * psymtab.c (_initialize_psymtab): Use upper case for
9860         metasyntactic variables.
9861         * demangle.c (demangle_command): Use upper case for metasyntactic
9862         variables.
9863         (_initialize_demangler): Likewise.
9864         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9865         variables.
9866
9867 2019-01-03  Tom Tromey  <tom@tromey.com>
9868
9869         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9870
9871 2019-01-03  Tom Tromey  <tom@tromey.com>
9872
9873         * python/py-symtab.c (salpy_str): Update.
9874         (struct salpy_sal_object) <symtab>: Now a PyObject.
9875         (salpy_dealloc): Update.
9876         (del_objfile_sal): Use gdbpy_ref.
9877
9878 2019-01-03  Tom Tromey  <tom@tromey.com>
9879
9880         * python/py-type.c (convert_field): Use new_reference.  Return
9881         gdbpy_ref.
9882         (make_fielditem): Return gdbpy_ref.
9883         (typy_fields): Update.
9884         (typy_getitem): Update.
9885         (field_name): Return gdbpy_ref.  Use new_reference.
9886         (typy_iterator_iternext): Update.
9887
9888 2019-01-03  Tom Tromey  <tom@tromey.com>
9889
9890         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9891
9892 2019-01-03  Tom Tromey  <tom@tromey.com>
9893
9894         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9895         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9896         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9897         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9898         (pspy_set_type_printers): Likewise.
9899         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9900         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9901         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9902         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9903         (objfpy_set_type_printers): Likewise.
9904
9905 2019-01-03  Tom Tromey  <tom@tromey.com>
9906
9907         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9908         (gdbpy_print_stack): Use gdbpy_err_fetch.
9909         * python/python-internal.h (class gdbpy_err_fetch): New class.
9910         (class gdbpy_enter) <m_error_type, m_error_value,
9911         m_error_traceback>: Remove.
9912         <m_error>: New member.
9913         (gdbpy_exception_to_string): Don't declare.
9914         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9915         * python/py-value.c (convert_value_from_python): Use
9916         gdbpy_err_fetch.
9917         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9918         gdbpy_exception_to_string.
9919         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9920         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9921         gdbpy_err_fetch.
9922
9923 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9924
9925         * linux-nat.c (delete_lwp_cleanup): Delete.
9926         (struct lwp_deleter): New struct.
9927         (lwp_info_up): New typedef.
9928         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9929         lwp_info_up.
9930
9931 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9932
9933         * linux-fork.c (class scoped_switch_fork_info): New class.
9934         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9935
9936 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9937
9938         * valops.c (find_overload_match): Remove use of null_cleanup, and
9939         calls to do_cleanups.
9940
9941 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9942
9943         * compile/compile-cplus-types.c
9944         (compile_cplus_instance::decl_name): Handle changes to
9945         cp_func_name.
9946         * cp-support.c (cp_func_name): Update header comment, update
9947         return type.
9948         * cp-support.h (cp_func_name): Update return type in declaration.
9949         * valops.c (find_overload_match): Move temp_func local to top
9950         level of function and change its type.  Use temp_func to hold and
9951         delete temporary string obtained from cp_func_name.
9952
9953 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9954
9955         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9956         gdb::char_vector, remove cleanup, and update uses of `msg`.
9957
9958 2019-01-03  Jim Wilson  <jimw@sifive.com>
9959
9960         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9961
9962 2019-01-02  Tom Tromey  <tom@tromey.com>
9963
9964         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9965         (tdesc_parse_xml): Remove cleanups.
9966         * target-descriptions.h (make_cleanup_free_target_description):
9967         Don't declare.
9968         (target_desc_deleter): New struct.
9969         (target_desc_up): New typedef.
9970         * target-descriptions.c (target_desc_deleter::operator()): Rename
9971         from free_target_description.
9972         (make_cleanup_free_target_description): Remove.
9973
9974 2019-01-02  Tom Tromey  <tom@tromey.com>
9975
9976         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9977         constructor, destructor.
9978         (linespec_parser): Remove typedef.
9979         (~linespec_parser): Rename from linespec_parser_delete.
9980         (linespec_lex_to_end, linespec_complete_label)
9981         (linespec_complete): Update.
9982         (decode_line_full): Remove cleanups.
9983         (decode_line_1): Update.
9984
9985 2019-01-02  Tom Tromey  <tom@tromey.com>
9986
9987         * python/python-internal.h (inferior_to_inferior_object): Change
9988         return type.
9989         * python/py-exitedevent.c (create_exited_event_object): Update.
9990         * python/py-inferior.c (inferior_to_inferior_object): Return
9991         gdbpy_ref.
9992         (python_new_inferior, python_inferior_deleted)
9993         (thread_to_thread_object, delete_thread_object)
9994         (build_inferior_list, gdbpy_selected_inferior): Update.
9995         * python/py-infthread.c (create_thread_object): Update.  Also fail
9996         if inferior_to_inferior_object fails.
9997
9998 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9999
10000         * inferior.h (class inferior) <displaced_step_state>: New field.
10001         * infrun.h (struct displaced_step_state): Move here from
10002         infrun.c.  Initialize fields, add constructor.
10003         <inf>: Remove field.
10004         <reset>: New method.
10005         * infrun.c (struct displaced_step_inferior_state): Move to
10006         infrun.h.
10007         (displaced_step_inferior_states): Remove.
10008         (get_displaced_stepping_state): Adust.
10009         (displaced_step_in_progress_any_inferior): Adjust.
10010         (displaced_step_in_progress_thread): Adjust.
10011         (displaced_step_in_progress): Adjust.
10012         (add_displaced_stepping_state): Remove.
10013         (get_displaced_step_closure_by_addr): Adjust.
10014         (remove_displaced_stepping_state): Remove.
10015         (infrun_inferior_exit): Call displaced_step_state.reset.
10016         (use_displaced_stepping): Don't check for NULL.
10017         (displaced_step_prepare_throw): Call
10018         get_displaced_stepping_state.
10019         (displaced_step_fixup): Don't check for NULL.
10020         (prepare_for_detach): Don't check for NULL.
10021
10022 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10023
10024         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10025          in case of call that did not complete.
10026
10027 2019-01-02  Andrey Utkin  <autkin@undo.io>
10028
10029         * symfile.c (find_separate_debug_file): Fix search of debug files for
10030         remote debuggee.
10031
10032 2019-01-02  Tom Tromey  <tom@tromey.com>
10033
10034         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10035         indentation.
10036         * python/py-frame.c (frapy_older): Remove cast.
10037         (frapy_newer): Likewise.
10038         * python/py-breakpoint.c (local_setattro): Remove cast.
10039         * python/py-arch.c (archpy_name): Remove local variable.
10040         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10041
10042 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10043
10044         * unittests/basic_string_view/element_access/char/empty.cc:
10045         Fix year range in copyright header.
10046
10047 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10048
10049         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10050         Delete.
10051         <operator==>: Update with for removed field.
10052         <hash>: Likewise.
10053         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10054         <isa_features>: ...this.
10055         <abi_features>: New field.
10056         (riscv_isa_flen): Update comment.
10057         (riscv_abi_xlen): New declaration.
10058         (riscv_abi_flen): New declaration.
10059         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10060         isa_features.
10061         (riscv_abi_xlen): New function.
10062         (riscv_isa_flen): Update to get answer from isa_features.
10063         (riscv_abi_flen): New function.
10064         (riscv_has_fp_abi): Update to get answer from abi_features.
10065         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10066         xlen and flen.
10067         (riscv_call_info) <xlen, flen>: Update comment.
10068         (riscv_call_arg_struct): Remove invalid assertions
10069         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10070         is removed.
10071         (riscv_gdbarch_init): Gather isa features and abi features
10072         separately, ensure both match on the gdbarch when reusing an old
10073         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10074         a target with 64-bit float hardware.
10075
10076 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10077
10078         * source.c (search_command_helper): Stop reverse search
10079         when line 1 has been searched.
10080
10081 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10082
10083         * record-full.c (record_full_base_target::close): Rewrite
10084         record_full_core_buf_list free logic.
10085
10086 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10087
10088         * break-catch-syscall.c (print_one_catch_syscall): xfree
10089         the last text.
10090
10091 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10092
10093         * top.c (print_gdb_version): Update Copyright year in version
10094         message.
10095
10096 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10097
10098         Update copyright year range in all GDB files.
10099
10100 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10101
10102         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10103
10104 For older changes see ChangeLog-2018.
10105 \f
10106 Local Variables:
10107 mode: change-log
10108 left-margin: 8
10109 fill-column: 74
10110 version-control: never
10111 coding: utf-8
10112 End:
10113